* lisp/emacs-lisp/edebug.el: Miscellaneous cleanup.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
2a7931e3
JB
12012-09-14 Juanma Barranquero <lekktu@gmail.com>
2
3 * makefile.w32-in ($(BLD)/alloc.$(O)): Update dependencies.
4
c18e885b
PE
52012-09-13 Paul Eggert <eggert@cs.ucla.edu>
6
7 Use a more backwards-compatible timer format (Bug#12430).
8 * keyboard.c (decode_timer): Get PSECS from the 8th (origin-0)
9 vector element, not from the 4th, since PSECS is now at the end.
10 (Fcurrent_idle_time): Doc fix.
11
d59a1afb
DA
122012-09-13 Dmitry Antipov <dmantipov@yandex.ru>
13
14 Function to mark objects and remove killed buffers at once.
15 * alloc.c (discard_killed_buffers): Rename to ...
16 (mark_discard_killed buffers) ... new name. Add marking
17 of remaining objects. Fix comment. Adjust users.
18 (mark_object): Do not touch frame buffer lists here.
19 * frame.c (delete_frame): Reset frame buffer lists here.
20
5f0cb45a
PE
212012-09-13 Paul Eggert <eggert@cs.ucla.edu>
22
8ea47e3a
PE
23 Better workaround for GNOME bug when --enable-gcc-warnings.
24 * emacsgtkfixed.c (G_STATIC_ASSERT): Remove, undoing last change.
25 Instead, disable -Wunused-local-typedefs. See Dmitry Antipov in
26 <http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00335.html>.
27
4a4bbad2
PE
28 Simplify SIGIO usage (Bug#12408).
29 The code that dealt with SIGIO was crufty and confusing, e.g., it
30 played tricks like "#undef SIGIO" but these tricks were not used
31 consistently. Simplify mostly by not #undeffing standard symbols,
32 e.g., use "defined USABLE_SIGIO" (our symbol, which we can define
33 or not as we please) rather than "defined SIGIO" (standard symbol
34 that we probably shouldn't #undef).
35 * conf_post.h [USG5_4]: Do not include <sys/wait.h> here.
36 Modules that need it can include it.
37 [USG5_4 && emacs]: Likewise, do not include the streams stuff here.
38 * dispextern.h (ignore_sigio): New decl.
39 * emacs.c (shut_down_emacs): Invoke unrequest_sigio
40 unconditionally, since it's now a no-op if !USABLE_SIGIO.
41 * emacs.c (shut_down_emacs):
42 * keyboard.c (kbd_buffer_store_event_hold):
43 Use ignore_sigio rather than invoking 'signal' directly.
44 * keyboard.c (USABLE_FIONREAD && USG5_4): Include <sys/filio.h>,
45 for FIONREAD.
46 (FIONREAD, SIGIO): Do not #undef.
47 (tty_read_avail_input): Use #error rather than a syntax error.
48 * process.c [USG5_4]: Include <sys/stream.h> and <sys/stropts.h>,
49 for I_PIPE, used by SETUP_SLAVE_PTY.
50 (DATAGRAM_SOCKETS): Simplify defn, based on USABLE_FIONREAD.
51 * sysdep.c (croak): Remove; no longer needed. This bit of
52 temporary code, with Fred N. Fish's comment that it's temporary,
53 has been in Emacs since at least 1992!
54 (init_sigio, reset_sigio, request_sigio, unrequest_sigio):
55 Arrange for them to be no-ops in all cases when ! USABLE_SIGIO.
56 * syssignal.h (croak): Remove decl.
57 (SIGIO, SIGPOO, SIGAIO, SIGPTY): Do not #undef; that's too fragile.
58 * systty.h [!NO_TERMIO]: Do not include <termio.h>; no longer needed
59 now that we're termios-only.
60 (FIONREAD, ASYNC) [BROKEN_FIONREAD]: Do not #undef.
61 * term.c (dissociate_if_controlling_tty): Use #error rather than
62 a run-time error.
63
5f0cb45a
PE
64 Work around GCC and GNOME bugs when --enable-gcc-warnings.
65 * emacsgtkfixed.c (G_STATIC_ASSERT): Redefine to use 'verify',
66 to work around GNOME bug 683906.
67 * image.c (jpeg_load_body) [HAVE_JPEG && lint]: Pacify gcc -Wclobber.
68 (struct my_jpeg_error_mgr) [HAVE_JPEG && lint]: New member fp.
69 This works around GCC bug 54561.
70
40bce90b
PE
712012-09-12 Paul Eggert <eggert@cs.ucla.edu>
72
73 More fixes for 'volatile' and setjmp/longjmp.
74 * eval.c (Fdefvar, Fcondition_case): Remove unnecessary 'volatile's.
75 * image.c (struct png_load_context) [HAVE_PNG]: New type.
76 (png_load_body) [HAVE_PNG]:
77 (jpeg_load_body) [HAVE_JPEG]:
78 New function, with most of the old parent function's body.
79 (png_load) [HAVE_PNG]:
80 (jpeg_load) [HAVE_JPEG]:
81 Invoke the new function, to avoid longjmp munging our locals.
82 (struct my_jpeg_error_mgr) [HAVE_JPEG]: New members cinfo, failure_code.
83 (my_error_exit) [HAVE_JPEG]: Don't trust 'setjmp' to return 2 when
84 longjmp is passed 2, as the C standard doesn't guarantee this.
85 Instead, store the failure code into mgr->failure_code.
86
bfeae2cf
SM
872012-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
88
89 * keyboard.c (read_char, requeued_events_pending_p, Finput_pending_p)
90 (Fdiscard_input, quit_throw_to_read_char, init_keyboard)
91 (syms_of_keyboard): Remove support for unread-command-char.
92
8099e36b
EZ
932012-09-12 Eli Zaretskii <eliz@gnu.org>
94
95 * w32proc.c (sys_kill): If PID is our process ID and the signal is
96 SIGABRT, call emacs_abort. Avoids silently exiting upon assertion
97 violation. (Bug#12426)
98
92547ff9
PE
992012-09-12 Paul Eggert <eggert@cs.ucla.edu>
100
101 * image.c (jpeg_memory_src): Don't assume string len fits in unsigned.
102
45b82ad0
SM
1032012-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
104
105 * eval.c: Add `inhibit-debugger'.
106 (Qinhibit_debugger): New symbol.
107 (call_debugger): Bind it instead of Qdebug_on_error.
108 (maybe_call_debugger): Test Vinhibit_debugger.
109 (syms_of_eval): Define inhibit-debugger.
110 * xdisp.c (set_message): Don't bind Qinhibit_debug_on_message.
111 (syms_of_xdisp): Remove inhibit-debug-on-message.
112
5779a1dc
PE
1132012-09-11 Paul Eggert <eggert@cs.ucla.edu>
114
50f2e553
PE
115 Avoid _setjmp/_longjmp problems with local nonvolatile variables.
116 If a nonvolatile local variable is written before a _longjmp to
117 the frame containing the variable, and is read after the _longjmp,
118 the value read is indeterminate. Some local variables of type
119 'struct handler' and 'struct catchtag' are used in this way, so
120 mark each of their slots as volatile if the slot can be set before
121 _longjmp and read afterwards.
122 * lisp.h (struct handler): var and chosen_clause are now volatile.
123 (struct catchtag): val, next, and pdlcount are now volatile.
124
ae1d87e2
PE
125 * bidi.c (bidi_push_it, bidi_pop_it):
126 * fns.c (copy_hash_table):
127 * image.c (define_image_type):
128 * keyboard.c (kbd_buffer_store_event_hold):
129 * process.c (Fprocess_send_eof):
130 * xfaces.c (x_create_gc) [HAVE_NS]:
131 * xgselect.c (xg_select):
132 Prefer assignment to memcpy when either will do.
133
5779a1dc
PE
134 * alloc.c (discard_killed_buffers): Tune and simplify a bit.
135 Use pointer-to-a-pointer to simplify and avoid a NILP check each
136 time an item is removed. No need to mark this function 'inline';
137 the compiler knows better than we do.
138
c4c9756b
JD
1392012-09-11 Jan Djärv <jan.h.d@swipnet.se>
140
141 * nsterm.m (ns_judge_scroll_bars): Pass NO to updateFrameSize.
142 (updateFrameSize:): Add delay parameter to updateFrameSize, send it
143 to change_frame_size (Bug#12388).
144 (windowDidResize:): Pass YES to updateFrameSize.
145
146 * nsterm.h: Add delay parameter to updateFrameSize.
147
d73e321c
DA
1482012-09-11 Dmitry Antipov <dmantipov@yandex.ru>
149
150 Discard killed buffers from deleted window and frame objects.
151 This reduces an amount of references to killed buffers and
152 helps GC to reclaim them faster.
153 * alloc.c (discard_killed_buffers): New function.
154 (mark_object): Use it for deleted windows and frames.
155 (mark_object): If symbol's value is set up for a killed buffer
156 or deleted frame, restore it's global binding.
157 * data.c (swap_in_global_binding): Add GC notice.
158 (swap_in_symval_forwarding): Use convenient set_blv_where.
159 * window.c (wset_next_buffers, wset_prev_buffers): Move ...
160 * window.h: ... to here.
161
e578f381
DA
1622012-09-11 Dmitry Antipov <dmantipov@yandex.ru>
163
164 Convenient macro to check whether the buffer is live.
165 * buffer.h (BUFFER_LIVE_P): New macro.
166 * alloc.c, buffer.c, editfns.c, insdel.c, lread.c, marker.c:
167 * minibuf.c, print.c, process.c, window.c, xdisp.c: Use it.
168
3057e615
YM
1692012-09-11 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
170
171 * xdisp.c (right_overwritten, right_overwriting): Also handle gstring
172 composition cases (Bug#12364).
173
174 * xterm.c (x_draw_glyph_string): Avoid overwriting inverted left
175 overhang of succeeding glyphs overlapping box cursor.
176
177 * w32term.c (x_draw_glyph_string): Likewise.
178
6fda35f2
PE
1792012-09-11 Paul Eggert <eggert@cs.ucla.edu>
180
c990426a
PE
181 Simplify, document, and port floating-point (Bug#12381).
182 The porting part of this patch fixes bugs on non-IEEE platforms
183 with frexp, ldexp, logb.
184 * data.c, lisp.h (Qdomain_error, Qsingularity_error, Qunderflow_error):
185 Now static.
186 * floatfns.c: Simplify discussion of functions that Emacs doesn't
187 support, by removing commented-out code and briefly listing the
188 C89 functions excluded. The commented-out stuff was confusing
189 maintenance, e.g., we thought we needed cbrt but it was commented out.
190 (logb): Remove decl; no longer needed.
191 (isfinite): New macro, if not already supplied.
192 (isnan): Don't replace any existing macro.
193 (Ffrexp, Fldexp): Define even if !HAVE_COPYSIGN, as frexp and ldexp
194 are present on all C89 platforms.
195 (Ffrexp): Do not special-case zero, as frexp does the right thing
196 for that case.
197 (Flogb): Do not use logb, as it doesn't have the desired meaning
198 on hosts that use non-base-2 floating point. Instead, stick with
199 frexp, which is C89 anyway. Do not pass an infinity or a NaN to
200 frexp, to avoid getting an unspecified result.
201
6fda35f2
PE
202 * xdisp.c (Qinhibit_debug_on_message): Now static.
203
16130a58
JD
2042012-09-10 Jan Djärv <jan.h.d@swipnet.se>
205
206 * nsterm.m (ns_update_begin): Set clip path to whole view by using
207 NSBezierPath (Bug#12131).
208
d105a573
CY
2092012-09-10 Chong Yidong <cyd@gnu.org>
210
211 * fns.c (Fdelq, Fdelete): Doc fix.
212
ff55dfe8
PE
2132012-09-10 Paul Eggert <eggert@cs.ucla.edu>
214
215 * lisp.h (XSETINT, XSETCONS, XSETVECTOR, XSETSTRING, XSETSYMBOL)
216 (XSETFLOAT, XSETMISC): Parenthesize macro bodies.
217
e7032e7c
SM
2182012-09-09 Stefan Monnier <monnier@iro.umontreal.ca>
219
220 * lisp.h (make_lisp_ptr): New macro to replace XSET.
221 (XSETCONS, XSETVECTOR, XSETSTRING, XSETSYMBOL, XSETFLOAT, XSETMISC):
222 Use it.
223
e9957956
EZ
2242012-09-09 Eli Zaretskii <eliz@gnu.org>
225
aba05ce9
EZ
226 * fringe.c (draw_fringe_bitmap_1): Don't reduce the width of the
227 left fringe if the window has a left margin. This avoids leaving
228 traces of the cursor because its leftmost pixel is not drawn over.
229
e9957956
EZ
230 * dispnew.c (update_window_line): When the left margin area of a
231 screen line is updated, set the redraw_fringe_bitmaps_p flag of
232 that screen line. (Bug#12277)
233
f6196b87
PE
2342012-09-09 Paul Eggert <eggert@cs.ucla.edu>
235
236 Assume C89 or later for math functions (Bug#12381).
237 This simplifies the code, and makes it a bit smaller and faster,
238 and (most important) makes it easier to clean up signal handling
239 since we can stop worring about floating-point exceptions in
240 library code. That was a problem before C89, but the problem
241 went away many years ago on all practical Emacs targets.
242 * data.c, image.c, lread.c, print.c:
243 Don't include <math.h>; no longer needed.
244 * data.c, floatfns.c (IEEE_FLOATING_POINT): Don't worry that it
245 might be autoconfigured, as that never happens.
246 * data.c (fmod):
247 * doprnt.c (DBL_MAX_10_EXP):
248 * print.c (DBL_DIG):
249 Remove. C89 or later always defines these.
250 * floatfns.c (HAVE_MATHERR, FLOAT_CHECK_ERRNO, FLOAT_CHECK_DOMAIN)
251 (in_float, float_error_arg, float_error_arg2, float_error_fn_name)
252 (arith_error, domain_error, domain_error2):
253 Remove all this pre-C89 cruft. Do not include <errno.h> as that's
254 no longer needed -- we simply return what C returns. All uses removed.
255 (IN_FLOAT, IN_FLOAT2): Remove. All uses replaced with
256 the wrapped code.
257 (FLOAT_TO_INT, FLOAT_TO_INT2, range_error, range_error2):
258 Remove. All uses expanded, as these macros are no longer used
259 more than once and are now more trouble than they're worth.
260 (Ftan): Use tan, not sin / cos.
261 (Flogb): Assume C89 frexp.
262 (fmod_float): Assume C89 fmod.
263 (matherr) [HAVE_MATHERR]: Remove; no longer needed.
264 (init_floatfns): Remove. All uses removed.
265
9d7f1863
JD
2662012-09-08 Jan Djärv <jan.h.d@swipnet.se>
267
268 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Take back
269 compositeToPoint for OSX < 10.6 (Bug#12390).
270
eabf0404
PE
2712012-09-08 Paul Eggert <eggert@cs.ucla.edu>
272
273 * floatfns.c (Ftan): Use tan (x), not (sin (x) / cos (x)).
274 This produces more-accurate results.
275
0b3b1d23
JD
2762012-09-08 Jan Djärv <jan.h.d@swipnet.se>
277
278 * nsterm.m (updateFrameSize): Call setFrame: on the view when size
279 changes (Bug#12088).
280
6dcef6ec
CY
2812012-09-08 Chong Yidong <cyd@gnu.org>
282
283 * syntax.c (Fstring_to_syntax): Doc fix.
284
aa7d57c5
JD
2852012-09-08 Jan Djärv <jan.h.d@swipnet.se>
286
287 * nsterm.m (ns_clip_to_row): Remove code that deals with drawing fringe
288 in the internal border.
289 (x_set_window_size): Remove static variables and their usage.
290 (ns_redraw_scroll_bars): Fix NSTRACE arg.
291 (ns_after_update_window_line, ns_draw_fringe_bitmap): Remove
292 fringe/internal border adjustment (Bug#11052).
293 (ns_draw_fringe_bitmap): Make code more like other terms (xterm.c).
294 (ns_draw_window_cursor): Remove fringe/internal border adjustment.
295 (ns_fix_rect_ibw): Remove.
296 (ns_get_glyph_string_clip_rect): Remove call to ns_fix_rect_ibw.
297 (ns_dumpglyphs_box_or_relief): Ditto.
298 (ns_maybe_dumpglyphs_background): Remove fringe/internal border
299 adjustment.
300 (ns_dumpglyphs_image): Ditto.
fc0c31f8 301 (ns_dumpglyphs_stretch): Fix coding style. Remove fringe/internal
aa7d57c5
JD
302 border adjustment.
303 (ns_set_vertical_scroll_bar): Remove variables barOnVeryLeft/Right and
304 their usage. Add fringe_extended_p and its use as in other terms.
305 (ns_judge_scroll_bars): Code style fix. Call updateFrameSize if
306 scroll bar was removed.
307 (updateFrameSize): New function.
308 (windowDidResize): Move code to updateFrameSize and call it.
309
310 * nsterm.h (EmacsView): Add updateFrameSize.
311
1a5432bc
CY
3122012-09-07 Chong Yidong <cyd@gnu.org>
313
b4f5313e
CY
314 * textprop.c (Fget_text_property): Minor doc fix (Bug#12323).
315
1a5432bc
CY
316 * data.c (Flocal_variable_if_set_p): Doc fix (Bug#10713).
317
1a4f1e9b
PE
3182012-09-07 Paul Eggert <eggert@cs.ucla.edu>
319
320 More signal-handler cleanup (Bug#12327).
eddb36a7
PE
321 * emacs.c (main): Convert three 'signal' calls to 'sigaction' calls.
322 Problem introduced when merging patches. Noted by Eli Zaretskii in
323 <http://bugs.gnu.org/12327#67>.
1a4f1e9b
PE
324 * floatfns.c: Comment fix.
325 * lisp.h (force_auto_save_soon): Declare regardless of SIGDANGER.
326 SIGDANGER might not be in scope so "#ifdef SIGDANGER" is not right,
327 and anyway the declaration is harmless even if SIGDANGER is not defined.
328 * syssignal.h (SIGIO): Also #undef if (! defined FIONREAD ||
329 defined BROKEN_FIONREAD). systty.h formerly did this, but other
330 source files not surprisingly expected syssignal.h to define, or
331 not define, SIGIO, and it's cleaner to do it that way, for consistency.
332 Include <sys/ioctl.h>, for FIONREAD.
333 * systty.h (SIGIO): Do not #undef here; it's now syssignal.h's job.
334 This eliminates a problem whereby other files mysteriously had
335 to include "syssignal.h" before including "systty.h" if they
336 wanted to use "#ifdef SIGIO".
337
bc8000ff
EZ
3382012-09-07 Eli Zaretskii <eliz@gnu.org>
339
3e6d6928
EZ
340 * w32proc.c (sigaction): New function, emulates Posix 'sigaction'.
341
342 * w32.c (sigemptyset): Empty the set.
343 (sigsetmask, sigmask, sigblock, sigunblock): Remove unused functions.
344
bc8000ff
EZ
345 * alloc.c [ENABLE_CHECKING]: Include signal.h, since we need SIGABRT.
346
b4fa72f2
DA
3472012-09-07 Dmitry Antipov <dmantipov@yandex.ru>
348
349 * alloc.c (mark_buffer): Revert unsafe marking optimization.
350 (mark_object): Likewise for frame objects.
351
30730c93
PE
3522012-09-07 Paul Eggert <eggert@cs.ucla.edu>
353
354 * syssignal.h (handle_on_main_thread): Always declare,
355 even if FORWARD_SIGNAL_TO_MAIN_THREAD is not defined.
356 This ports to platforms without HAVE_PTHREAD.
357
2fe28299
PE
3582012-09-06 Paul Eggert <eggert@cs.ucla.edu>
359
360 Signal-handler cleanup (Bug#12327).
361 Emacs's signal handlers were written in the old 4.2BSD style with
362 sigblock and sigmask and so forth, and this led to some
363 inefficiencies and confusion. Rewrite these to use
364 pthread_sigmask etc. without copying signal sets around. Also,
365 get rid of the confusing macros 'SIGNAL_THREAD_CHECK' and
366 'signal', and instead use functions that do not attempt to take
367 over the system name space. This patch causes Emacs's text
368 segment to shrink by 0.7% on my platform, Fedora 17 x86-64.
369 * alloc.c, emacsgtkfixed.c, nsfns.m, widget.c, xmenu.c:
370 Do not include <signal.h> or "syssignal.h", as these
371 modules do not use signals.
372 * atimer.c, callproc.c, data.c, dispnew.c, emacs.c, floatfns.c:
373 * gtkutil.c, keyboard.c, process.c, sound.c, sysdep.c, term.c, xterm.c:
374 Do not include <signal.h>, as "syssignal.h" does that for us now.
375 * atimer.c (sigmask_atimers): New function.
376 (block_atimers, unblock_atimers): New functions,
377 replacing the old macros BLOCK_ATIMERS and UNBLOCK_ATIMERS.
378 All uses replaced.
379 * conf_post.h [SIGNAL_H_AHB]: Do not include <signal.h>;
380 no longer needed here.
381 * emacs.c (main): Inspect existing signal handler with sigaction,
fc0c31f8 382 so that there's no need to block and unblock SIGHUP.
2fe28299
PE
383 * sysdep.c (struct save_signal): New member 'action', replacing
384 old member 'handler'.
385 (save_signal_handlers, restore_signal_handlers):
386 Use sigaction instead of 'signal' to save and restore.
387 (get_set_sighandler, set_sighandler) [!WINDOWSNT]:
388 New function. All users of 'signal' modified to use set_sighandler
389 if they're writeonly, and to use sys_signal if they're read+write.
390 (emacs_sigaction_init, forwarded_signal): New functions.
391 (sys_signal): Remove. All uses replaced by calls to sigaction
392 and emacs_sigaction_init, or by direct calls to 'signal'.
393 (sys_sigmask) [!__GNUC__]: Remove; no longer needed.
394 (sys_sigblock, sys_sigunblock, sys_sigsetmask): Remove;
395 all uses replaced by pthread_sigmask etc. calls.
396 * syssignal.h: Include <signal.h>.
397 (emacs_sigaction_init, forwarded_signal): New decls.
398 (SIGMASKTYPE): Remove. All uses replaced by its definiens, sigset_t.
399 (SIGEMPTYMASK): Remove; all uses replaced by its definiens, empty_mask.
400 (sigmask, sys_sigmask): Remove; no longer needed.
401 (sigpause): Remove. All uses replaced by its definiens, sigsuspend.
402 (sigblock, sigunblock, sigfree):
403 (sigsetmask) [!defined sigsetmask]:
404 Remove. All uses replaced by pthread_sigmask.
405 (signal): Remove. Its remaining uses (with SIG_DFL and SIG_IGN)
406 no longer need to be replaced, and its typical old uses
407 are now done via emacs_sigaction_init and sigaction.
408 (sys_sigblock, sys_sigunblock, sys_sigsetmask): Remove decls.
409 (sys_sigdel): Remove; unused.
410 (NSIG): Remove a FIXME; the code's fine. Remove an unnecessary ifdef.
411
0216c128
EZ
4122012-09-06 Eli Zaretskii <eliz@gnu.org>
413
414 * process.c (CAN_HANDLE_MULTIPLE_CHILDREN): Fix a typo that broke
415 SIGCHLD handling on systems that don't have WNOHANG. (Bug#12327)
416
c752cfa9
DA
4172012-09-06 Dmitry Antipov <dmantipov@yandex.ru>
418
419 Explicitly mark buffer_defaults and buffer_local_symbols.
420 * alloc.c (Fgarbage_collect): Mark buffer_defaults and
421 mark_local_symbols here.
422 (mark_object): If GC_CHECK_MARKED_OBJECTS, simplify checking
423 since special buffers aren't marked here any more.
424 (allocate_buffer): Chain new buffer with all_buffers here...
425 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer): ...and
426 not here.
427 (Vbuffer_defaults, Vbuffer_local_symbols): Remove.
428 (syms_of_buffer): Remove staticpro of the above.
429 (init_buffer_once): Set names for buffer_defaults and
430 buffer_local_symbols.
431
a864ef14
PE
4322012-09-06 Paul Eggert <eggert@cs.ucla.edu>
433
434 Use bool for booleans in font-related modules.
435 * font.c (font_intern_prop, font_style_to_value)
436 (font_style_symbolic, font_parse_xlfd, font_parse_fcname)
437 (generate_otf_features, font_check_otf_features, font_check_otf)
438 (font_match_p, font_list_entities, font_at):
439 * fontset.c (fontset_id_valid_p, reorder_font_vector
440 (fontset_find_font, Fset_fontset_font)
441 (face_suitable_for_char_p) [0]:
442 * ftfont.c (fc_initialized, ftfont_get_open_type_spec)
443 (ftfont_open, ftfont_text_extents, ftfont_check_otf):
444 (m17n_flt_initialized, ftfont_shape_by_flt):
445 * ftxfont.c (ftxfont_draw_bitmap, ftxfont_draw):
446 * nsfont.m (nsfont_draw):
447 * w32font.c (w32font_draw):
448 * w32term.c (x_draw_glyphless_glyph_string_foreground):
449 Use bool for booleans.
450 * font.h: Adjust to above API changes.
451 (struct font, struct font_driver, struct font_driver_list):
452 Use bool for booleans.
453 (struct font): Remove useless member encoding_type.
454 All users removed.
455 * fontset.c, xftfont.c: Omit unnecessary static decls.
456
0699fc18
DA
4572012-09-06 Dmitry Antipov <dmantipov@yandex.ru>
458
459 * alloc.c (mark_object): Revert window marking code
460 since it's unsafe for the Fset_window_configuration.
461
20ef56db
PE
4622012-09-05 Paul Eggert <eggert@cs.ucla.edu>
463
2fe28299 464 Fix race conditions with signal handlers and errno (Bug#12327).
20ef56db
PE
465 Be more systematic about preserving errno whenever a signal
466 handler returns, even if it's not in the main thread. Do this by
467 renaming signal handlers to distinguish between signal delivery
468 and signal handling. All uses changed.
469 * atimer.c (deliver_alarm_signal): Rename from alarm_signal_handler.
470 * data.c (deliver_arith_signal): Rename from arith_error.
471 * dispnew.c (deliver_window_change_signal): Rename from
472 window_change_signal.
473 * emacs.c (deliver_error_signal): Rename from fatal_error_signal.
474 (deliver_danger_signal) [SIGDANGER]: Rename from memory_warning_signal.
475 * keyboard.c (deliver_input_available_signal): Rename from
476 input_available_signal.
477 (deliver_user_signal): Rename from handle_user_signal.
478 (deliver_interrupt_signal): Rename from interrupt_signal.
479 * process.c (deliver_pipe_signal): Rename from send_process_trap.
480 (deliver_child_signal): Rename from sigchld_handler.
481 * atimer.c (handle_alarm_signal):
482 * data.c (handle_arith_signal):
483 * dispnew.c (handle_window_change_signal):
484 * emacs.c (handle_fatal_signal, handle_danger_signal):
485 * keyboard.c (handle_input_available_signal):
486 * keyboard.c (handle_user_signal, handle_interrupt_signal):
487 * process.c (handle_pipe_signal, handle_child_signal):
488 New functions, with the actual signal-handling code taken from the
489 original respective signal handlers, sans the sporadic attempts to
490 preserve errno, since that's now done by handle_on_main_thread.
491 * atimer.c (alarm_signal_handler): Remove unnecessary decl.
492 * emacs.c, floatfns.c, lisp.h: Remove unused FLOAT_CATCH_SIGKILL cruft.
493 * emacs.c (main_thread) [FORWARD_SIGNAL_TO_MAIN_THREAD]:
494 Move to sysdep.c.
495 (main) [FORWARD_SIGNAL_TO_MAIN_THREAD]:
496 Move initialization of main_thread to sysdep.c's init_signals.
497 * process.c (waitpid) [!WNOHANG]: #define to wait; that's good enough for
498 our usage, and simplifies the mainline code.
499 (record_child_status_change): New static function, as a helper
500 for handle_child_signal, and with most of the old child handler's
501 contents.
502 (CAN_HANDLE_MULTIPLE_CHILDREN): New constant.
503 (handle_child_signal): Use the above.
504 * sysdep.c (main_thread) [FORWARD_SIGNAL_TO_MAIN_THREAD]:
505 Moved here from emacs.c.
506 (init_signals) [FORWARD_SIGNAL_TO_MAIN_THREAD]: Initialize it;
507 code moved here from emacs.c's main function.
508 * sysdep.c, syssignal.h (handle_on_main_thread): New function,
509 replacing the old SIGNAL_THREAD_CHECK. All uses changed. This
510 lets callers save and restore errno properly.
511
e3ccf108
DA
5122012-09-05 Dmitry Antipov <dmantipov@yandex.ru>
513
514 Remove redundant or unused things here and there.
515 * lisp.h (CYCLE_CHECK, CHAR_TABLE_TRANSLATE): Remove.
516 * conf_post.h (RE_TRANSLATE): Use char_table_translate.
517 * editfns.c (Fcompare_buffer_substrings): Likewise.
518 * frame.h (struct terminal, struct font_driver_list):
519 Remove redundant declarations.
520 * window.h (Qleft, Qright): Likewise.
521
697e1e39
DA
5222012-09-05 Dmitry Antipov <dmantipov@yandex.ru>
523
524 Do not mark objects from deleted buffers, windows and frames.
525 * alloc.c (mark_buffer): Mark just the buffer if it is dead.
526 (mark_object): Likewise for windows and frames.
527
c1ca42ca
DA
5282012-09-05 Dmitry Antipov <dmantipov@yandex.ru>
529
530 * alloc.c (valid_lisp_object_p): Treat killed buffers,
531 buffer_defaults and buffer_local_symbols as valid objects.
532 Return special value to denote them.
533
014d93be
PE
5342012-09-05 Paul Eggert <eggert@cs.ucla.edu>
535
f75d7a91
PE
536 * fileio.c, filelock.c, floatfns.c, fns.c: Use bool for boolean.
537 * fileio.c (auto_saving, auto_save_error_occurred, make_temp_name)
538 (Fexpand_file_name, barf_or_query_if_file_exists, Fcopy_file)
539 (file_name_absolute_p, Fsubstitute_in_file_name):
540 (check_executable, check_writable, Ffile_accessible_directory_p)
541 (Fset_file_selinux_context, Fdefault_file_modes)
542 (Finsert_file_contents, choose_write_coding_system)
543 (Fwrite_region, build_annotations, a_write, e_write)
544 (Fdo_auto_save):
545 * filelock.c (boot_time_initialized, get_boot_time)
546 (get_boot_time_1, lock_file_1, within_one_second):
547 * floatfns.c (in_float):
548 * fns.c (concat, internal_equal, Frequire, base64_encode_1)
549 (base64_decode_1, cmpfn_eql, cmpfn_user_defined)
550 (sweep_weak_table, sweep_weak_hash_tables, secure_hash):
551 * lisp.h (struct Lisp_Hash_Table.cmpfn):
552 * window.c (compare_window_configurations):
553 Use bool for booleans.
554 * fileio.c (auto_saving_dir_umask, auto_saving_mode_bits)
555 (Fdefault_file_modes): Now mode_t, not int, for modes.
556 (Fdo_auto_save): Set a boolean to 1 rather than using ++.
557 (internal_delete_file): Now returns void, not a (boolean) int,
558 since nobody was looking at the return value.
559 * lisp.h, window.h: Adjust to above API changes.
560
014d93be
PE
561 * xdisp.c (set_message): Simplify and reindent last change.
562
776f29e1
JB
5632012-09-05 Juanma Barranquero <lekktu@gmail.com>
564
565 * makefile.w32-in ($(BLD)/sysdep.$(O)): Update dependencies.
566
7f7e0167
LI
5672012-09-04 Lars Ingebrigtsen <larsi@gnus.org>
568
569 * eval.c (call_debugger): Make the function non-static so that we
570 can call it from set_message.
571
572 * xdisp.c (set_message): Implement the new variable `debug-on-message'.
573 (syms_of_xdisp): Defvar it and `inhibit-debug-on-message'.
574
cf29dd84
PE
5752012-09-04 Paul Eggert <eggert@cs.ucla.edu>
576
577 Give more-useful info on a fatal error (Bug#12328).
578 * alloc.c [ENABLE_CHECKING]: Do not include <execinfo.h>.
579 (die) [ENABLE_CHECKING]: Call fatal_error_backtrace instead
580 of doing the work ourselves.
581 * emacs.c (fatal_error_signal): Let fatal_error_backtrace
582 do most of the work.
583 (fatal_error_backtrace): New function, taken from the guts
584 of the old fatal_error_signal, but with a new option to output
585 a backtrace.
586 (shut_down_emacs) [!DOS_NT]: Use strsignal to give more-useful
587 info about the signal than just its number.
588 * lisp.h (fatal_error_backtrace, emacs_backtrace): New decls.
589 * sysdep.c: Include <execinfo.h>
590 (emacs_backtrace): New function, taken partly from the previous
591 code of the 'die' function.
592 (emacs_abort): Call fatal_error_backtrace rather than abort.
593
972debf2
SM
5942012-09-04 Stefan Monnier <monnier@iro.umontreal.ca>
595
596 * lread.c (readevalloop): Call internal-macroexpand-for-load to perform
597 eager (load-time) macro-expansion.
598 * lisp.mk (lisp): Add macroexp.
599
1088b922
PE
6002012-09-04 Paul Eggert <eggert@cs.ucla.edu>
601
602 Simplify redefinition of 'abort' (Bug#12316).
603 Do not try to redefine the 'abort' function. Instead, redo
604 the code so that it calls 'emacs_abort' rather than 'abort'.
605 This removes the need for the NO_ABORT configure-time macro
606 and makes it easier to change the abort code to do a backtrace.
607 * .gdbinit: Just stop at emacs_abort, not at w32_abort or abort.
608 * emacs.c (abort) [!DOS_NT && !NO_ABORT]:
609 Remove; sysdep.c's emacs_abort now takes its place.
610 * lisp.h (emacs_abort): New decl. All calls from Emacs code to
611 'abort' changed to use 'emacs_abort'.
612 * msdos.c (dos_abort) [defined abort]: Remove; not used.
613 (abort) [!defined abort]: Rename to ...
614 (emacs_abort): ... new name.
615 * sysdep.c (emacs_abort) [!HAVE_NTGUI]: New function, taking
616 the place of the old 'abort' in emacs.c.
617 * w32.c, w32fns.c (abort): Do not #undef.
618 * w32.c (emacs_abort): Rename from w32_abort.
619
30934d33
EZ
6202012-09-04 Eli Zaretskii <eliz@gnu.org>
621
622 * w32uniscribe.c (uniscribe_shape): Reverse the sign of
623 offsets[j].dv, since the y axis of the screen coordinates points
624 down, while the y axis of the font definition coordinates points
625 up. This fixes display of Arabic diacritics such as KASRA and
626 KASRATAN. (Bug#11860)
627
af26b72c
PE
6282012-09-04 Paul Eggert <eggert@cs.ucla.edu>
629
630 Be more systematic about _setjmp vs setjmp.
631 * alloc.c (test_setjmp, mark_stack):
632 * image.c (PNG_LONGJMP) [PNG_LIBPNG_VER < 10500]:
633 (PNG_JMPBUF) [! (PNG_LIBPNG_VER < 10500)]:
634 (png_load, my_error_exit, jpeg_load):
635 * process.c (send_process_trap, send_process):
636 Uniformly prefer _setjmp and _longjmp to setjmp and longjmp.
637 The underscored versions are up to 30x faster on some hosts.
638 Formerly, the code used setjmp+longjmp sometimes and
639 _setjmp+_longjmp at other times, with no particular reason to
640 prefer setjmp+longjmp.
641
26d4541d
PE
6422012-09-03 Paul Eggert <eggert@cs.ucla.edu>
643
d42f4f0f 644 Fix minor problem found by static checking.
26d4541d 645 * buffer.c (Fdelete_all_overlays): Return nil.
26d4541d 646
c5e28e39
MR
6472012-09-03 Martin Rudalics <rudalics@gmx.at>
648
649 * buffer.c (Fdelete_all_overlays): New function.
650
3eab3ca9
CY
6512012-09-03 Chong Yidong <cyd@gnu.org>
652
653 * gtkutil.c: Add extern decl for Qxft.
654
c04889f8
PE
6552012-09-02 Paul Eggert <eggert@cs.ucla.edu>
656
1882aa38
PE
657 * emacs.c, eval.c: Use bool for boolean.
658 * emacs.c (initialized, inhibit_window_system, running_asynch_code):
659 (malloc_using_checking) [DOUG_LEA_MALLOC]:
660 (display_arg) [HAVE_X_WINDOWS || HAVE_NS]:
661 (noninteractive, no_site_lisp, fatal_error_in_progress, argmatch)
662 (main, decode_env_path, Fdaemon_initialized):
663 * eval.c (call_debugger, Finteractive_p, interactive_p):
664 (unwind_to_catch, Fsignal, wants_debugger, skip_debugger)
665 (maybe_call_debugger, Fbacktrace):
666 * process.c (read_process_output, exec_sentinel):
667 Use bool for booleans.
668 * emacs.c (shut_down_emacs): Omit unused boolean argument NO_X.
669 All callers changed.
670 * eval.c (interactive_p): Omit always-true boolean argument
671 EXCLUDE_SUBRS_P. All callers changed.
672 * dispextern.h, lisp.h: Reflect above API changes.
673 * firstfile.c (dummy): Use the address of 'main', whose signature
674 won't change, instead of the address of 'initialize', whose
675 signature just changed from int to bool.
676 * lisp.h (fatal_error_in_progress): New decl of boolean, moved here ...
677 * msdos.c (fatal_error_in_progress): ... from here.
678 * xdisp.c (redisplaying_p): Now a boolean. Set it to 1 instead
679 of incrementing it.
680 (redisplay_internal, unwind_redisplay): Simply clear
681 REDISPLAYING_P when unwinding, instead of saving its previous,
682 always-false value and then restoring it.
683
a411ac43
PE
684 Clean up some extern decls.
685 Mostly, this hoists extern decls out of .c files and into .h files.
686 That way, we're more likely to catch errors if the interfaces change.
687 * alloc.c [USE_GTK]: Include "gtkutil.h" so that we need not
688 declare xg_mark_data.
689 * dispextern.h (x_frame_parm_handlers):
690 * font.h (Qxft):
691 * lisp.h (Qlexical_binding, Qinternal_interpreter_environment)
692 (Qextra_light, Qlight, Qsemi_light, Qsemi_bold, Qbold, Qextra_bold)
693 (Qultra_bold, Qoblique, Qitalic):
694 Move extern decl here from .c file.
695 * alloc.c (xg_mark_data) [USE_GTK]:
696 * doc.c (Qclosure):
697 * eval.c (Qlexical_binding):
698 * fns.c (time) [!HAVE_UNISTD_H]:
699 * gtkutil.c (Qxft, Qnormal, Qextra_light, Qlight, Qsemi_light)
700 (Qsemi_bold, Qbold, Qextra_bold, Qultra_bold, Qoblique, Qitalic):
701 * image.c (Vlibrary_cache, QCloaded_from) [HAVE_NTGUI]:
702 * lread.c (Qinternal_interpreter_environment):
703 * minibuf.c (Qbuffer):
704 * process.c (QCfamily, QCfilter):
705 * widget.c (free_frame_faces):
706 * xfaces.c (free_frame_menubar) [USE_X_TOOLKIT]:
707 * xfont.c (x_clear_errors):
708 * xterm.c (x_frame_parm_handlers):
709 Remove now-redundant extern decls.
710 * keyboard.c, keyboard.h (ignore_mouse_drag_p) [USE_GTK || HAVE_NS]:
711 * xfaces.c (Qultra_light, Qreverse_oblique, Qreverse_italic):
712 Now static.
713 * xfaces.c: Remove unnecessary static decls.
714 * xterm.c (updating_frame): Remove decl of nonexistent object.
715
c04889f8
PE
716 * Makefile.in (gl-stamp): Don't scan $(SOME_MACHINE_OBJECTS)
717 when building globals.h, as the objects that are not built on
718 this host are not needed to compile C files on this host.
719
8b339673
JD
7202012-09-02 Jan Djärv <jan.h.d@swipnet.se>
721
722 * gtkutil.h: Remove prototype for x_wm_set_size_hint.
723
724 * frame.h: Add missing prototype for x_wm_set_size_hint.
725
a08d4ba7
PE
7262012-09-02 Paul Eggert <eggert@cs.ucla.edu>
727
728 * doc.c, editfns.c, insdel.c, intervals.c: Use bool for boolean.
729 * doc.c (read_bytecode_char, get_doc_string, reread_doc_file)
730 (Fdocumentation, Fdocumentation_property, Fsnarf_documentation)
731 (Fsubstitute_command_keys):
732 * editfns.c (region_limit, find_field, Fconstrain_to_field)
733 (save_excursion_save, save_excursion_restore)
734 (disassemble_lisp_time, decode_time_components, emacs_nmemftime)
735 (format_time_string, general_insert_function)
736 (make_buffer_string, make_buffer_string_both)
737 (Fsubst_char_in_region, Ftranslate_region_internal, Fformat):
738 * insdel.c (check_markers, gap_left, adjust_markers_for_insert)
739 (copy_text, insert_1, insert_1_both, insert_from_string)
740 (insert_from_string_before_markers, insert_from_string_1)
741 (insert_from_buffer, insert_from_buffer_1, replace_range)
742 (replace_range_2, del_range_1, del_range_byte, del_range_both)
743 (del_range_2, modify_region):
744 * intervals.c (intervals_equal, balance_possible_root_interval)
745 (adjust_intervals_for_insertion, merge_properties_sticky)
746 (graft_intervals_into_buffer, lookup_char_property)
747 (adjust_for_invis_intang, set_point_both)
748 (get_property_and_range, compare_string_intervals)
749 (set_intervals_multibyte_1, set_intervals_multibyte):
750 * keyboard.c (decode_timer):
751 Use bool for boolean.
752 * intervals.h, lisp.h, systime.h: Reflect above API changes.
753 * editfns.c (struct info): Use 1-bit unsigned bitfields for booleans.
754
48c948de
CY
7552012-09-02 Chong Yidong <cyd@gnu.org>
756
757 * keymap.c (push_key_description): Print M-TAB as C-M-i
758 (Bug#11758).
759
6c49a40b
JB
7602012-09-02 Juanma Barranquero <lekktu@gmail.com>
761
762 * makefile.w32-in (CCL_H, W32FONT_H): New macros.
763 (ATIMER_H, FONT_H, $(BLD)/alloc.$(O), $(BLD)/callproc.$(O))
764 ($(BLD)/editfns.$(O), $(BLD)/ccl.$(O), $(BLD)/chartab.$(O))
765 ($(BLD)/coding.$(O), $(BLD)/sysdep.$(O), $(BLD)/fontset.$(O))
766 ($(BLD)/sysdep.$(O), $(BLD)/w32fns.$(O), $(BLD)/keyboard.$(O))
767 ($(BLD)/w32term.$(O), $(BLD)/w32menu.$(O), $(BLD)/process.$(O))
768 ($(BLD)/w32font.$(O), $(BLD)/w32uniscribe.$(O)): Update dependencies.
769
4dfbd238
EZ
7702012-09-01 Eli Zaretskii <eliz@gnu.org>
771
7e510e28
EZ
772 * w32uniscribe.c (uniscribe_shape): Handle correctly the case of
773 more than one grapheme cluster passed to the shaper: compute the
774 offset adjustment values separately for each cluster. (Bug#11860)
775
4dfbd238
EZ
776 * image.c: Restore mistakenly removed inclusion of w32.h. Without
777 it, GCC doesn't see prototypes of w32_delayed_load, and complains
778 about implicit conversions from integer to pointer.
779
86571ae0
DC
7802012-09-01 Daniel Colascione <dancol@dancol.org>
781
782 * w32fns.c (x_display_info_for_name): Prevent crash if w32 window
783 system used too early.
784
0e23ef9d
PE
7852012-09-01 Paul Eggert <eggert@cs.ucla.edu>
786
787 Better seed support for (random).
788 * emacs.c (main): Call init_random.
789 * fns.c (Frandom): Set the seed from a string argument, if given.
790 Remove long-obsolete Gentzel cruft.
791 * lisp.h, sysdep.c (seed_random): Now takes address and size, not long.
792 (init_random): New function.
793
17a2cbbd
DC
7942012-09-01 Daniel Colascione <dancol@dancol.org>
795
796 * xterm.h: Add header guards. Declare x_menubar_window_to_frame.
797 Remove x_set_frame_alpha, x_bitmap_icon, x_make_frame_visible,
798 x_make_frame_invisible, x_iconify_frame, x_free_frame_resources,
799 x_wm_set_size_hint, x_query_colors, x_real_positions,
800 x_set_menu_bar_lines, x_char_width, x_char_height, x_sync,
801 x_set_tool_bar_lines, x_activate_menubar, and free_frame_menubar,
802 all of which have been moved to common code.
803
804 * xfaces.c: Include TERM_HEADER instead of listing all possible
805 window-system headers.
806
807 * w32xfns.c (x_sync): Correct definition of x_sync (a no-op here)
808 to match header.
809
810 * w32term.h (FRAME_X_WINDOW): Use FRAME_W32_WINDOW instead of
811 directly accessing frame internals.
812
f18cbb28 813 * w32font.h: Include font.h. Define syms_of_w32font and
17a2cbbd
DC
814 globals_of_w32font.
815
816 * process.c: Include TERM_HEADER instead of listing all possible
817 window-system headers.
818
819 * nsterm.h: Remove declarations now in frame.h. Define
820 FRAME_X_SCREEN, FRAME_X_VISUAL.
821
822 * menu.c: Include TERM_HEADER instead of listing all possible
823 window-system headers.
824
825 * keyboard.h: Declare ignore_mouse_drag_p whenever we have a
826 window system.
827
828 * keyboard.c: Include TERM_HEADER instead of listing all possible
829 window-system headers.
830
831 * image.c: Include TERM_HEADER instead of listing all possible
832 window-system headers. Declare Vlibrary_cache when compiling for
833 Windows.
834
835 * gtkutil.h (xg_list_node_): Include xterm.h to pick up needed
836 window system declarations.
837
838 * frame.h: Move common functions here: set_frame_menubar,
839 x_set_window_size, x_sync, x_get_focus_frame,
840 x_set_mouse_position, x_set_mouse_pixel_position,
841 x_make_frame_visible, x_make_frame_invisible, x_iconify_frame,
842 x_char_width, x_char_height, x_pixel_width, x_pixel_height,
843 x_set_frame_alpha, x_set_menu_bar_lines, x_set_tool_bar_lines,
844 x_activate_menubar, x_real_positions, x_bitmap_icon,
845 x_set_menu_bar_lines, free_frame_menubar, x_free_frame_resources,
846 and x_query_colors.
847
848 * frame.c: Include TERM_HEADER instead of listing all possible
849 window-system headers.
850
851 * font.c: Include TERM_HEADER instead of listing all possible
852 window-system headers.
853
854 * emacs.c: Include TERM_HEADER.
855
f18cbb28
EZ
856 * dispnew.c: Include TERM_HEADER instead of listing all possible
857 window-system headers.
17a2cbbd 858
f18cbb28 859 * ccl.h: Include character.h.
17a2cbbd
DC
860
861 * Makefile.in: Define WINDOW_SYSTEM_OBJ to hold objects needed for
862 the current window system; include in list of objects to link into
863 Emacs.
864
c650a5de
DA
8652012-08-31 Dmitry Antipov <dmantipov@yandex.ru>
866
867 Remove mark_ttys function and fix tty_display_info initialization.
868 * lisp.h (mark_ttys): Remove prototype.
869 * alloc.c (Fgarbage_collect): Remove redundant (and the only) call
870 to mark_ttys because all possible values of 'top_frame' slot are
871 the frames which are reachable from Vframe_list.
872 * term.c (mark_ttys): Remove.
873 (init_tty): Safely initialize 'top_frame' slot with Qnil.
874
4e0f6479
DA
8752012-08-31 Dmitry Antipov <dmantipov@yandex.ru>
876
877 Change struct frame bitfields from unsigned char to unsigned.
878 * frame.h (struct frame): Change type of 'display_preempted',
879 'visible', 'iconified', 'has_minibuffer', 'wants_modeline',
880 'auto_raise', 'auto_lower', 'no_split', 'explicit_name',
881 'window_sizes_changed', 'mouse_moved' and 'pointer_invisible'
882 bitfields from unsigned char to unsigned.
883
8b96a52c
DA
8842012-08-31 Dmitry Antipov <dmantipov@yandex.ru>
885
886 Remove unused member of struct x_output and struct w32_output.
887 * xterm.h (struct x_output): Remove unused field 'needs_exposure'.
888 * w32term.h (struct w32_output): Likewise.
889
b4444c8a
JD
8902012-08-30 Jan Djärv <jan.h.d@swipnet.se>
891
892 * gtkutil.c (x_wm_set_size_hint): Use 1 col for base_width so it
893 does not become zero (Bug#12234).
894
b98521db
PE
8952012-08-30 Paul Eggert <eggert@cs.ucla.edu>
896
897 * dispnew.c (update_frame_1): Pacify gcc -Wstrict-overflow
898 for GCC 4.7.1 x86-64.
899
31d02438
GM
9002012-08-30 Glenn Morris <rgm@gnu.org>
901
902 * lread.c (init_lread): For out-of-tree builds, only add the
903 source directory's site-lisp dir to the load-path if it exists,
904 consistent with in-tree builds. (Bug#12302)
905
7f8941d8
JD
9062012-08-28 Jan Djärv <jan.h.d@swipnet.se>
907
908 * nsmenu.m (initWithContentRect:styleMask:backing:defer:): Initialize
fc0c31f8 909 button_values to NULL. Call setStykeMask so dialogs get a close button.
7f8941d8
JD
910 (windowShouldClose:): Set window_closed.
911 (dealloc): New member, free button_values.
fc0c31f8
JB
912 (process_dialog:): Make member function. Remove window argument,
913 replace window with self. Count buttons and allocate and store values
7f8941d8
JD
914 in button_values.
915 (addButton:value:row:): value is int with the name tag. Call setTag
fc0c31f8 916 with tag. Remove return self, declare return value as void.
7f8941d8
JD
917 (addString:row:): Remove return self, declare return value as void.
918 (addSplit): Remove return self, declare return value as void.
919 (clicked:): Remove return self, declare return value as void.
fc0c31f8 920 Set dialog_return to button_values[seltag]. Code formatting change.
7f8941d8
JD
921 (initFromContents:isQuestion:): Adjust call to process_dialog.
922 Code formatting change.
923 (timeout_handler:): Set timer_fired to YES.
924 (runDialogAt:): Set timer_fired to NO.
925 Handle click on close button as quit.
926
927 * nsterm.h (EmacsDialogPanel): Make timer_fired BOOL.
928 Add window_closed and button_values. Add void as return value for
929 add(Button|String|Split). addButton takes int instead of Lisp_Object.
930 Add process_dialog as new member.
931
eada0861 9322012-08-28 Eli Zaretskii <eliz@gnu.org>
19c17fc1 933
eada0861
GM
934 * ralloc.c (free_bloc): Don't dereference a 'heap' structure if it
935 is not one of the heaps we manage. (Bug#12242)
936
9372012-08-28 Glenn Morris <rgm@gnu.org>
938
939 * eval.c (Fcalled_interactively_p): Doc fix. (Bug#11747)
940
457294dd
MR
9412012-08-28 Martin Rudalics <rudalics@gmx.at>
942
943 * window.c (Fset_window_configuration): Remove handling of
37b9743e
MR
944 auto-buffer-name window parameter. Install revision of reverted
945 fix.
457294dd 946
4f2daf31
DA
9472012-08-28 Dmitry Antipov <dmantipov@yandex.ru>
948
949 Do not allow to set major mode for a dead buffer.
950 * buffer.c (Fset_buffer_major_mode): Signal an error
951 if the buffer is dead.
952 (Fother_buffer, other_buffer_safely): Remove redundant
953 nested declaration.
954
66322887
DA
9552012-08-28 Dmitry Antipov <dmantipov@yandex.ru>
956
957 Always use set_buffer_if_live to restore original buffer at unwind.
958 * buffer.h (record_unwind_current_buffer): New function.
959 * bytecode.c, dispnew.c, editfns.c, fileio.c, fns.c, insdel.c:
960 * keyboard.c, keymap.c, minibuf.c, print.c, process.c, textprop.c:
961 * undo.c, window.c: Adjust users.
962 * buffer.c (set_buffer_if_live): Fix comment.
963
a3d794a1
DA
9642012-08-28 Dmitry Antipov <dmantipov@yandex.ru>
965
966 Fix usage of set_buffer_internal.
967 * buffer.h (set_buffer_internal): Make it BUFFER_INLINE.
968 * buffer.c (set_buffer_if_live): Use set_buffer_internal.
969 * coding.c (decode_coding): Omit redundant test.
970 * fileio.c (decide_coding_unwind): Likewise.
971 * fns.c (secure_hash): Likewise.
972 * insdel.c (modify_region): Likewise.
973 * keyboard.c (command_loop_1): Likewise.
974 * print.c (PRINTFINISH): Likewise.
975 * xdisp.c (run_window_scroll_functions): Use set_buffer_internal.
976
59ea14cd
PE
9772012-08-27 Paul Eggert <eggert@cs.ucla.edu>
978
979 * dispnew.c: Use bool for boolean.
980 (frame_garbaged, display_completed, delayed_size_change)
981 (fonts_changed_p, add_window_display_history)
982 (add_frame_display_history, verify_row_hash)
983 (adjust_glyph_matrix, clear_window_matrices, glyph_row_slice_p)
984 (row_equal_p, realloc_glyph_pool)
985 (allocate_matrices_for_frame_redisplay)
986 (showing_window_margins_p)
987 (adjust_frame_glyphs_for_frame_redisplay)
988 (build_frame_matrix_from_leaf_window, make_current)
989 (mirrored_line_dance, mirror_line_dance, update_frame)
990 (update_window_tree, update_single_window)
991 (check_current_matrix_flags, update_window, update_text_area)
992 (update_window_line, set_window_update_flags, scrolling_window)
993 (update_frame_1, scrolling, buffer_posn_from_coords)
994 (do_pending_window_change, change_frame_size)
995 (change_frame_size_1, sit_for):
996 Use bool for boolean.
997 (clear_glyph_matrix_rows): Rename from enable_glyph_matrix_rows,
998 and remove last int (actually boolean) argument, which was always 0.
999 All callers changed.
1000 * dispextern.h, frame.h, lisp.h: Reflect above API changes.
1001 * dispextern.h (struct composition_it): Use bool for boolean.
1002 (struct glyph_matrix): Don't assume buffer sizes can fit in 'int'.
1003 (struct bidi_it): Use unsigned:1, not int, for boolean prev_was_pdf.
1004 * dired.c (file_name_completion):
1005 Use bool for boolean. (This was missed in an earlier change.)
1006
95072a94
MR
10072012-08-27 Martin Rudalics <rudalics@gmx.at>
1008
1009 * window.c (Fset_window_configuration): Revert first part of
1010 last change.
1011
0f19feff
JD
10122012-08-27 Jan Djärv <jan.h.d@swipnet.se>
1013
1014 * nsterm.h (NSPanel): New class variable dialog_return.
1015
1016 * nsmenu.m (initWithContentRect:styleMask:backing:defer:): Initialize
1017 dialog_return.
1018 (windowShouldClose:): Use stop instead of stopModalWithCode.
1019 (clicked:): Ditto, and also set dialog_return (Bug#12258).
1020 (timeout_handler:): Use stop instead of abortModal. Send a dummy
1021 event.
1022 (runDialogAt:): Make ret Lisp_Object. Set it from dialog_return when
1023 modal loop returns.
1024
f10fe38f
PE
10252012-08-27 Paul Eggert <eggert@cs.ucla.edu>
1026
de1339b0
PE
1027 * composite.c, data.c, dbusbind.c, dired.c: Use bool for booleans.
1028 * composite.c (find_composition, composition_gstring_p)
1029 (composition_reseat_it, find_automatic_composition):
1030 * data.c (let_shadows_buffer_binding_p)
1031 (let_shadows_global_binding_p, set_internal, make_blv)
1032 (Fmake_variable_buffer_local, Fmake_local_variable)
1033 (Fmake_variable_frame_local, arithcompare, cons_to_unsigned)
1034 (cons_to_signed, arith_driver):
1035 * dbusbind.c (xd_in_read_queued_messages):
1036 * dired.c (directory_files_internal, file_name_completion):
1037 Use bool for booleans.
1038 * dired.c (file_name_completion):
1039 * process.h (fd_callback):
1040 Omit int (actually boolean) argument. It wasn't being used.
1041 All uses changed.
1042 * composite.h, lisp.h: Reflect above API changes.
1043
f10fe38f
PE
1044 * cmds.c, coding.c: Use bool for booleans.
1045 * cmds.c (move_point, Fself_insert_command):
1046 * coding.h (struct composition status, struct coding_system):
1047 * coding.c (detect_coding_utf_8, encode_coding_utf_8)
1048 (detect_coding_utf_16, encode_coding_utf_16, detect_coding_emacs_mule)
1049 (emacs_mule_char, decode_coding_emacs_mule)
1050 (encode_coding_emacs_mule, detect_coding_iso_2022)
1051 (decode_coding_iso_2022, encode_invocation_designation)
1052 (encode_designation_at_bol, encode_coding_iso_2022)
1053 (detect_coding_sjis, detect_coding_big5, decode_coding_sjis)
1054 (decode_coding_big5, encode_coding_sjis, encode_coding_big5)
1055 (detect_coding_ccl, encode_coding_ccl, decode_coding_raw_text)
1056 (encode_coding_raw_text, detect_coding_charset)
1057 (decode_coding_charset, encode_coding_charset, detect_eol)
1058 (detect_coding, get_translation_table, produce_chars)
1059 (consume_chars, reused_workbuf_in_use)
1060 (make_conversion_work_buffer, code_conversion_save)
1061 (decode_coding_object, encode_coding_object)
1062 (detect_coding_system, char_encodable_p)
1063 (Funencodable_char_position, code_convert_region)
1064 (code_convert_string, code_convert_string_norecord)
1065 (Fset_coding_system_priority):
1066 * fileio.c (Finsert_file_contents):
1067 Use bool for booleans.
1068 * coding.h, lisp.h: Reflect above API changes.
1069 * coding.c: Remove unnecessary static function decls.
1070 (detect_coding): Use unsigned, not signed, to copy an unsigned field.
1071 (decode_coding, encode_coding, decode_coding_gap): Return 'void',
1072 not a boolean 'int', since callers never look at the return value.
1073 (ALLOC_CONVERSION_WORK_AREA): Assume caller returns 'void', not 'int'.
1074 * coding.h (decoding_buffer_size, encoding_buffer_size)
1075 (emacs_mule_string_char): Remove unused extern decls.
1076 (struct iso_2022_spec, struct coding_system):
1077 Use 'unsigned int : 1' for boolean fields, since there's more than one.
1078 (struct emacs_mule_spec): Remove unused field 'full_support'.
1079 All initializations removed.
1080 * cmds.c (internal_self_insert): Don't assume EMACS_INT fits in 'int'.
1081
5474c384
DA
10822012-08-27 Dmitry Antipov <dmantipov@yandex.ru>
1083
f10fe38f 1084 Fix spare memory change (Bug#12286).
5474c384
DA
1085 * alloc.c (mark_maybe_pointer): Handle MEM_TYPE_SPARE.
1086 (valid_lisp_object_p): Likewise.
1087
c4b6914d
MR
10882012-08-27 Martin Rudalics <rudalics@gmx.at>
1089
1090 * window.c (Fset_window_configuration): Record any window's old
1091 buffer if it's replaced (see Bug#8789). If the new current
1092 buffer doesn't appear in the selected window, go to its old
1093 point (Bug#12208).
1094
35aaa1ea
DA
10952012-08-27 Dmitry Antipov <dmantipov@yandex.ru>
1096
1097 Special MEM_TYPE_SPARE to denote reserved memory.
1098 * alloc.c (enum mem_type): New memory type.
1099 (refill_memory_reserve): Use new type for spare memory.
1100 This prevents live_cons_p and live_string_p from incorrect
1101 detection of uninitialized objects from spare memory as live.
1102
6af64513
PE
11032012-08-26 Paul Eggert <eggert@cs.ucla.edu>
1104
8b2e00a3
PE
1105 Spelling fixes.
1106 * Makefile.in (.PHONY): versioclean -> versionclean.
1107
b52d6985
PE
1108 Remove unused external symbols.
1109 * data.c (Qcons, Qfloat, Qmisc, Qstring, Qvector):
1110 * window.c (Qwindow_valid_p, decode_valid_window):
1111 Now static, not extern.
1112 * data.c (Qinterval): Remove; unused.
1113 (syms_of_data): Do not define 'interval'.
1114 * lisp.h (Qinteger, Qstring, Qmisc, Qvector, Qfloat, Qcons):
1115 * window.h (decode_valid_window):
1116 Remove decls.
1117
d5172d4f
PE
1118 * character.c, charset.c, chartab.c: Use bool for booleans.
1119 * character.c (lisp_string_width, string_count_byte8)
1120 (string_escape_byte8):
1121 * charset.c (charset_map_loaded, load_charset_map, read_hex):
1122 (load_charset_map_from_file, map_charset_chars)
1123 (Fdefine_charset_internal, define_charset_internal)
1124 (Fdeclare_equiv_charset, find_charsets_in_text)
1125 (Ffind_charset_region, char_charset, Fiso_charset):
1126 * chartab.c (sub_char_table_ref, sub_char_table_ref_and_range)
1127 (sub_char_table_set, sub_char_table_set_range)
1128 (char_table_set_range, optimize_sub_char_table)
1129 (map_sub_char_table):
1130 Use bool for boolean.
1131 * character.c (str_to_unibyte): Omit last boolean argument; it was
1132 always 0. All callers changed.
1133 * character.h, charset.h: Adjust to match previous changes.
1134 * character.h (char_printable_p): Remove decl of nonexistent function.
1135 * charset.h (struct charset): Members code_linear_p, iso_chars_96,
1136 ascii_compatible_p, supplementary_p, compact_codes_p, unified_p
1137 are all boolean, so make them single-bit bitfields.
1138
6af64513
PE
1139 * lisp.h (ASET): Remove attempt to detect side effects.
1140 It was meant to be temporary and it often doesn't work,
1141 because when IDX has side effects the behavior of IDX==IDX
1142 is undefined. See Stefan Monnier in
1143 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00762.html>.
1144
e1f29348
BR
11452012-08-26 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
1146
1147 * lisp.h (functionp): New function (extracted from Ffunctionp).
1148 (FUNCTIONP): Use it.
1149 * eval.c (Ffunctionp): Use it.
1150
17c05d74
PE
11512012-08-25 Paul Eggert <eggert@cs.ucla.edu>
1152
0f46bc75
PE
1153 * xgselect.c (xg_select): Use auto storage for the GPollFD buffer
1154 as that's faster and simpler than static storage. Don't bother
1155 with the g_main_context_query overhead if g_main_context_pending
1156 says no events are pending.
1157 (gfds, gfds_size): Remove these static vars.
1158 (xgselect_initialize): Remove; no longer needed.
1159 All uses and decls removed.
1160
ee4c0f69
PE
1161 * emacs.c (fatal_error_signal_hook): Remove.
1162 All uses removed. This leftover from old code was always 0.
1163
17c05d74
PE
1164 * casefiddle.c, casetab.c, category.c: Use bool for boolean.
1165 * casefiddle.c (casify_object, casify_region):
1166 * casetab.c (set_case_table):
1167 * category.c, category.h (word_boundary_p):
1168 * category.h (CHAR_HAS_CATEGORY):
1169 Use bool for booleans, instead of int.
1170
391ceac5
EZ
11712012-08-25 Eli Zaretskii <eliz@gnu.org>
1172
1173 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on $(GNU_LIB)/execinfo.h.
1174
2f221583
PE
11752012-08-25 Paul Eggert <eggert@cs.ucla.edu>
1176
f4a681b0
PE
1177 On assertion failure, print backtrace if available.
1178 * alloc.c [ENABLE_CHECKING]: Include <execinfo.h>.
1179 (die) [ENABLE_CHECKING]: Print a backtrace if available.
1180 * Makefile.in (LIB_EXECINFO): New macro.
1181 (LIBES): Use it.
1182
2f221583
PE
1183 * bytecode.c, callint.c, callproc.c: Use bool for boolean.
1184 * bytecode.c (exec_byte_code):
1185 * callint.c (check_mark, Fcall_interactively):
1186 * callproc.c (Fcall_process, add_env, child_setup, getenv_internal_1)
1187 (getenv_internal, sync_process_alive, call_process_exited):
1188 * lisp.h (USE_SAFE_ALLOCA):
1189 Use bool for booleans, instead of int.
1190 * lisp.h, process.h: Adjust prototypes to match above changes.
1191 * callint.c (Fcall_interactively): Don't assume the mark's
1192 offset fits in 'int'.
1193
37ef52bb
PE
11942012-08-24 Paul Eggert <eggert@cs.ucla.edu>
1195
1196 * buffer.c, buffer.h: Use bool for boolean.
1197 * buffer.c (reset_buffer_local_variables)
1198 (buffer_lisp_local_variables, Fset_buffer_modified_p)
1199 (Frestore_buffer_modified_p, Fset_buffer_multibyte):
1200 (overlays_at, overlays_in, mouse_face_overlay_overlaps)
1201 (overlay_touches_p, overlay_strings, Foverlay_put)
1202 (report_overlay_modification, call_overlay_mod_hooks):
1203 (mmap_enlarge, mmap_set_vars):
1204 * buffer.h (buffer_has_overlays, uppercasep, lowercasep):
1205 Use bool for booleans, instead of int.
1206 * buffer.c (compact_buffer, mmap_free_1): Return void, not int,
1207 since the 1-or-0 return value is always ignored anyway.
1208 (mmap_initialized_p):
1209 * buffer.h (struct buffer_text.inhibit_shrinking): Now bool, not int.
1210 * buffer.h, lisp.h: Adjust prototypes to match above changes.
1211
2cc21167
PE
12122012-08-23 Paul Eggert <eggert@cs.ucla.edu>
1213
1214 * bidi.c: Use bool for boolean.
1215 This is a bit more readable, and makes the text segment of bidi.o
1216 0.4% smaller on my platform (GCC 4.7.1 x86-64, Fedora 15).
1217 Presumably it's faster too.
1218 (bidi_initialized, bidi_ignore_explicit_marks_for_paragraph_level):
1219 Now bool.
1220 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1221 (bidi_unshelve_cache, bidi_init_it, bidi_count_bytes)
1222 (bidi_char_at_pos, bidi_fetch_char, bidi_paragraph_init)
1223 (bidi_explicit_dir_char, bidi_level_of_next_char)
1224 (bidi_find_other_level_edge, bidi_move_to_visually_next):
1225 Use bool for booleans, instead of int.
1226 * dispextern.h (bidi_init_it, bidi_paragraph_init)
1227 (bidi_unshelve_cache): Adjust decls to match code.
1228
7db4ddf4
MR
12292012-08-23 Martin Rudalics <rudalics@gmx.at>
1230
1231 * keyboard.c (Fposn_at_x_y): Do not allow internal window as
1232 argument.
1233
b1bb8011
PE
12342012-08-23 Paul Eggert <eggert@cs.ucla.edu>
1235
1236 * atimer.c, atimer.h (turn_on_atimers): Use bool for boolean.
1237 * atimer.h: Include <stdbool.h>.
1238
ff687885
DN
12392012-08-22 Dan Nicolaescu <dann@gnu.org>
1240
1241 * frame.h (FRAME_W32_P, FRAME_MSDOS_P, FRAME_NS_P): Change to
1242 compile time tests instead of run time tests on systems that do
1243 not use them.
1244 (FRAME_MAC_P): Remove leftover from deleted code.
1245 * frame.c (syms_of_frame): Remove leftover from deleted code.
1246
4ce7a138
JD
12472012-08-22 Jan Djärv <jan.h.d@swipnet.se>
1248
1249 * nsterm.m (insertText:): Don't clear modifiers if code is space.
1250
d733ec6d
PE
12512012-08-22 Paul Eggert <eggert@cs.ucla.edu>
1252
1253 * fontset.c (FONTSET_ADD): Return void, not Lisp_Object.
1254 Otherwise, the compiler complains about (A?B:C) where B is void
fc0c31f8 1255 and C is Lisp_Object. This fixes an incompatibility with Sun C 5.12.
d733ec6d
PE
1256 (fontset_add): Return void, for FONTSET_ADD.
1257
d0d2d26f
PE
12582012-08-21 Paul Eggert <eggert@cs.ucla.edu>
1259
fce31d69
PE
1260 * alloc.c: Use bool for booleans.
1261 (gc_in_progress, abort_on_gc)
1262 (setjmp_tested_p) [!GC_SAVE_REGISTERS_ON_STACK && !GC_SETJMP_WORKS]:
1263 (dont_register_blocks) [GC_MALLOC_CHECK]:
1264 (suppress_checking) [ENABLE_CHECKING]: Now bool, not int.
1265 (check_string_bytes, make_specified_string, memory_full)
1266 (live_string_p, live_cons_p, live_symbol_p, live_float_p)
1267 (live_misc_p, live_vector_p, live_buffer_p, mark_maybe_object)
1268 (mark_stack, valid_pointer_p, make_pure_string)
1269 (Fgarbage_collect, survives_gc_p, gc_sweep):
1270 Use bool for booleans, instead of int.
1271 (test_setjmp) [!GC_SAVE_REGISTERS_ON_STACK && !GC_SETJMP_WORKS]:
1272 Remove unused local.
1273 * alloc.c (PURE_POINTER_P):
1274 * lisp.h (STRING_MULTIBYTE): Document that it returns a boolean.
1275 * editfns.c (Fformat):
1276 * fileio.c (Fexpand_file_name, Fsubstitute_in_file_name)
1277 (Fdo_auto_save):
1278 * fns.c (sweep_weak_table):
1279 * lisp.h (suppress_checking, push_message, survives_gc_p)
1280 (make_pure_string, gc_in_progress, abort_on_gc):
1281 * lread.c (readchar, read1):
1282 * print.c (Fprin1_to_string):
1283 * xdisp.c (push_message):
1284 Use bool for booleans affected directly or indirectly by
1285 alloc.c's changes.
1286
d0d2d26f
PE
1287 Make recently-introduced setters macros.
1288 * fontset.c (set_fontset_id, set_fontset_name, set_fontset_ascii)
1289 (set_fontset_base, set_fontset_frame, set_fontset_nofont_face)
1290 (set_fontset_default, set_fontset_fallback): Rename from their
1291 upper-case counterparts, and make them functions rather than macros.
1292 This is more consistent with the other recently-introduced setters.
1293 These don't need to be inline, since they're local.
1294
d18e2bb6
JD
12952012-08-21 Jan Djärv <jan.h.d@swipnet.se>
1296
1297 * nsterm.m (fd_handler:): Alloc and release a NSAutoreleasePool in
1298 the loop (Bug#12247).
1299
1b9d9d16
PE
13002012-08-21 Paul Eggert <eggert@cs.ucla.edu>
1301
1302 * lisp.h (vcopy): Use memcpy rather than our own loop.
1303 This fixes a performance regression introduced by the recent
1304 addition of vcopy. This means 'vcopy' will need to be modified
1305 for a copying collector, but that's OK. Also, tighten the
1306 checking in the assertion.
1307
b2f09701
EZ
13082012-08-21 Eli Zaretskii <eliz@gnu.org>
1309
1310 * w32uniscribe.c (uniscribe_shape): Fix producing gstring
1311 components for RTL text (Bug#11860). Adjust X-OFFSET of each
1312 non-base glyph for the width of the base character, according to
e1f29348
BR
1313 what x_draw_composite_glyph_string_foreground expects.
1314 Generate WADJUST value according to composition_gstring_width's
b2f09701
EZ
1315 expectations, to produce correct width of the composed character.
1316 Reverse the sign of the DU offset produced by ScriptPlace.
1317
9b994fed
PE
13182012-08-21 Paul Eggert <eggert@cs.ucla.edu>
1319
1320 * dbusbind.c (xd_remove_watch): Do not assume C99 comments.
1321
086ca913
DA
13222012-08-21 Dmitry Antipov <dmantipov@yandex.ru>
1323
1324 Avoid direct writes to contents member of struct Lisp_Vector.
1325 * lisp.h (vcopy): New function to copy data into vector.
1326 * dispnew.c (Fframe_or_buffer_changed_p): Use AREF and ASET.
1327 * fns.c (Ffillarray): Use ASET.
1328 * keyboard.c (timer_check_2): Use AREF and ASET.
1329 (append_tool_bar_item, Frecent_keys): Use vcopy.
1330 * lread.c (read_vector): Use ASET.
1331 * msdos.c (Frecent_doskeys): Use vcopy.
1332 * xface.c (Finternal_copy_lisp_face): Use vcopy.
1333 (Finternal_merge_in_global_face): Use ASET and vcopy.
1334 * xfont.c (xfont_list_pattern): Likewise.
1335
5481664a
MR
13362012-08-21 Martin Rudalics <rudalics@gmx.at>
1337
1338 * window.c (Fwindow_point): For the selected window always return
1339 the position of its buffer's point.
1340 (Fset_window_point): For the selected window always go in its
1341 buffer to the specified position.
1342
6d470bdd
DA
13432012-08-21 Dmitry Antipov <dmantipov@yandex.ru>
1344
1345 Setter macros for fontsets.
1346 * fontset.c (SET_FONTSET_ID, SET_FONTSET_NAME, SET_FONTSET_ASCII)
1347 (SET_FONTSET_BASE, SET_FONTSET_FRAME, SET_FONTSET_NOFONT_FACE)
1348 (SET_FONTSET_DEFAULT, SET_FONTSET_FALLBACK): New macros.
1349 Adjust users.
1350
24564fe1
GM
13512012-08-20 Glenn Morris <rgm@gnu.org>
1352
1353 * Makefile.in (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
1354 Don't assume that `ln -f' works.
1355
0a05a035
EZ
13562012-08-20 Eli Zaretskii <eliz@gnu.org>
1357
1358 * .gdbinit: Use "set $dummy = ..." to avoid warnings from GDB 7.5
1359 and later about non-assignments with no effect. See discussion at
1360 http://sourceware.org/ml/gdb-patches/2012-08/msg00518.html for
1361 details.
1362
e46f2325
DA
13632012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
1364
1365 Inline setter functions for Lisp_Objects slots of struct specbinding.
1366 * eval.c (set_specpdl_symbol, set_specpdl_old_value): New functions.
1367 Adjust users.
1368
734fbd86
MR
13692012-08-20 Martin Rudalics <rudalics@gmx.at>
1370
1371 * window.c (select_window): Always make selected window's buffer
1372 current.
1373
f1a95992
DA
13742012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
1375
1376 Use AREF and ASET for docstrings of category tables.
1377 * category.h (CATEGORY_DOCSTRING): Use AREF.
1378 (SET_CATEGORY_DOCSTRING): Use ASET.
1379 * category.c (Fdefine_category): Use SET_CATEGORY_DOCSTRING.
1380
e83064be
DA
13812012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
1382
1383 Inline setter functions for hash table members.
1384 * lisp.h (set_hash_key, set_hash_value, set_hash_next)
1385 (set_hash_hash, set_hash_index): Rename with _slot suffix.
1386 (set_hash_key_and_value, set_hash_index, set_hash_next)
1387 (set_hash_hash): New functions.
1388 * charset.c, fns.c: Adjust users.
1389
4ce60d2e
DA
13902012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
1391
1392 Inline getter and setter functions for per-buffer values.
1393 * buffer.h (per_buffer_default, set_per_buffer_default)
1394 (per_buffer_value, set_per_buffer_value): New functions.
1395 (PER_BUFFER_VALUE, PER_BUFFER_DEFAULT): Remove.
1396 * buffer.c, data.c: Adjust users.
1397
c06c9690
JB
13982012-08-20 Juanma Barranquero <lekktu@gmail.com>
1399
1400 * makefile.w32-in ($(BLD)/vm-limit.$(O)): Update dependencies.
1401
32bd4250
PE
14022012-08-19 Paul Eggert <eggert@cs.ucla.edu>
1403
bad03192 1404 Rely on <config.h> + <unistd.h> to declare 'environ',
b69a6d22
PE
1405 as gnulib does this if the system doesn't.
1406 * callproc.c, editfns.c, process.c (environ) [!USE_CRT_DLL]:
72279493
EZ
1407 Remove declaration. MS-Windows declares it on stdlib.h which is
1408 included by conf_post.h.
b69a6d22
PE
1409 * emacs.c (environ) [DOUG_LEA_MALLOC]:
1410 * vm-limit.c (environ) [ORDINARY_LINK]: Remove decl.
1411 * vm-limit.c: Include <unistd.h>, for 'environ'.
1412
22d7feb2
PE
1413 * unexaix.c, unexcoff.c: Include "mem-limits.h".
1414 (start_of_data): Remove decl; mem-limits.h provides it.
1415
32bd4250
PE
1416 * xdisp.c (handle_invisible_prop): Make it a bit faster
1417 and avoid a gcc -Wmaybe-uninitialized diagnostic.
1418
450809af
CY
14192012-08-19 Chong Yidong <cyd@gnu.org>
1420
1421 * xdisp.c (handle_invisible_prop): Fix ellipses at overlay string
1422 ends (Bug#3874).
1423
9e677988
AS
14242012-08-19 Andreas Schwab <schwab@linux-m68k.org>
1425
6b1319ce
AS
1426 * .gdbinit: Use call instead of set when calling a function in the
1427 inferior.
1428
9e677988
AS
1429 * data.c (set_internal): Don't use set_blv_found.
1430 (Fkill_local_variable): Likewise.
1431
d7191076
AA
14322012-08-18 Alp Aker <alp.tekin.aker@gmail.com>
1433
1434 * nsfont.m (ns_ascii_average_width): Ensure the string
1435 ascii_printable is initialized with a null-terminated character
1436 array. Otherwise, it can contain undesired extra characters.
1437
e757f1c6
PE
14382012-08-18 Paul Eggert <eggert@cs.ucla.edu>
1439
1440 port new setting code to Sun C 5.8 2005/10/13
1441 * chartab.c, lisp.h (char_table_set, char_table_set_range):
1442 Return void, not Lisp_Object. Otherwise, the compiler
1443 complains about (A?B:C) where B is void and C is Lisp_Object
1444 when compiling CHAR_TABLE_SET, due to the recent change to
1445 the API of sub_char_table_set_contents.
1446
a999ce26
CY
14472012-08-18 Chong Yidong <cyd@gnu.org>
1448
1449 * xdisp.c (handle_invisible_prop): Obey TEXT_PROP_MEANS_INVISIBLE
1450 for the string case (Bug#3874).
1451
3f22b86f
PE
14522012-08-18 Paul Eggert <eggert@cs.ucla.edu>
1453
39eb03f1
PE
1454 * buffer.h (BSET): Remove (Bug#12215).
1455 Replace all uses with calls to new setter functions.
1456 (bset_bidi_paragraph_direction, bset_case_canon_table)
1457 (bset_case_eqv_table, bset_directory, bset_display_count)
1458 (bset_display_time, bset_downcase_table)
1459 (bset_enable_multibyte_characters, bset_filename, bset_keymap)
1460 (bset_last_selected_window, bset_local_var_alist)
1461 (bset_mark_active, bset_point_before_scroll, bset_read_only)
1462 (bset_truncate_lines, bset_undo_list, bset_upcase_table)
1463 (bset_width_table):
1464 * buffer.c (bset_abbrev_mode, bset_abbrev_table)
1465 (bset_auto_fill_function, bset_auto_save_file_format)
1466 (bset_auto_save_file_name, bset_backed_up, bset_begv_marker)
1467 (bset_bidi_display_reordering, bset_buffer_file_coding_system)
1468 (bset_cache_long_line_scans, bset_case_fold_search)
1469 (bset_ctl_arrow, bset_cursor_in_non_selected_windows)
1470 (bset_cursor_type, bset_display_table, bset_extra_line_spacing)
1471 (bset_file_format, bset_file_truename, bset_fringe_cursor_alist)
1472 (bset_fringe_indicator_alist, bset_fringes_outside_margins)
1473 (bset_header_line_format, bset_indicate_buffer_boundaries)
1474 (bset_indicate_empty_lines, bset_invisibility_spec)
1475 (bset_left_fringe_width, bset_major_mode, bset_mark)
1476 (bset_minor_modes, bset_mode_line_format, bset_mode_name)
1477 (bset_name, bset_overwrite_mode, bset_pt_marker)
1478 (bset_right_fringe_width, bset_save_length)
1479 (bset_scroll_bar_width, bset_scroll_down_aggressively)
1480 (bset_scroll_up_aggressively, bset_selective_display)
1481 (bset_selective_display_ellipses, bset_vertical_scroll_bar_type)
1482 (bset_word_wrap, bset_zv_marker):
1483 * category.c (bset_category_table):
1484 * syntax.c (bset_syntax_table):
1485 New setter functions.
1486
6a09a33b
PE
1487 * process.h (PSET): Remove (Bug#12215).
1488 Replace all uses with calls to new setter functions.
1489 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
1490 (PROCESS_INLINE): New macro.
1491 (pset_childp): New setter function.
1492 (pset_gnutls_cred_type) [HAVE_GNUTLS]: New setter function.
1493 * process.c (PROCESS_INLINE):
1494 Define to EXTERN_INLINE, so that the corresponding functions
1495 are compiled into code.
1496 (pset_buffer, pset_command, pset_decode_coding_system)
1497 (pset_decoding_buf, pset_encode_coding_system)
1498 (pset_encoding_buf, pset_filter, pset_log, pset_mark, pset_name)
1499 (pset_plist, pset_sentinel, pset_status, pset_tty_name)
1500 (pset_type, pset_write_queue): New setter functions.
1501
e8c17b81
PE
1502 * window.h (WSET): Remove (Bug#12215).
1503 Replace all uses with calls to new setter functions.
1504 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
1505 (WINDOW_INLINE): New macro.
1506 (wset_buffer, wset_frame, wset_left_col, wset_next, wset_prev)
1507 (wset_redisplay_end_trigger, wset_top_line, wset_total_cols)
1508 (wset_total_lines, wset_vertical_scroll_bar)
1509 (wset_window_end_pos, wset_window_end_valid)
1510 (wset_window_end_vpos): New setter functions.
1511 * window.c (WINDOW_INLINE):
1512 Define to EXTERN_INLINE, so that the corresponding functions
1513 are compiled into code.
1514 (wset_combination_limit, wset_dedicated, wset_display_table)
1515 (wset_hchild, wset_left_fringe_width, wset_left_margin_cols)
1516 (wset_new_normal, wset_new_total, wset_next_buffers)
1517 (wset_normal_cols, wset_normal_lines, wset_parent, wset_pointm)
1518 (wset_prev_buffers, wset_right_fringe_width)
1519 (wset_right_margin_cols, wset_scroll_bar_width, wset_start)
1520 (wset_temslot, wset_vchild, wset_vertical_scroll_bar_type)
1521 (wset_window_parameters):
1522 * xdisp.c (wset_base_line_number, wset_base_line_pos)
1523 (wset_column_number_displayed, wset_region_showing):
1524 New setter functions.
1525
3f22b86f
PE
1526 * termhooks.h (TSET): Remove (Bug#12215).
1527 Replace all uses with calls to new setter functions.
1528 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
1529 (TERMHOOKS_INLINE): New macro.
1530 (tset_charset_list, tset_selection_alist): New setter functions.
1531 * terminal.c (TERMHOOKS_INLINE):
1532 Define to EXTERN_INLINE, so that the corresponding functions
1533 are compiled into code.
1534 (tset_param_alist): New setter function.
1535
742af32f
PE
15362012-08-17 Paul Eggert <eggert@cs.ucla.edu>
1537
15dbb4d6
PE
1538 * keyboard.h (KSET): Remove (Bug#12215).
1539 Replace all uses with calls to new setter functions.
1540 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
1541 (KEYBOARD_INLINE): New macro.
1542 (kset_default_minibuffer_frame, kset_defining_kbd_macro)
1543 (kset_input_decode_map, kset_last_command, kset_last_kbd_macro)
1544 (kset_prefix_arg, kset_system_key_alist, kset_window_system):
1545 New setter functions.
1546 * keyboard.c (KEYBOARD_INLINE):
1547 Define to EXTERN_INLINE, so that the corresponding functions
1548 are compiled into code.
1549 (kset_echo_string, kset_kbd_queue)
1550 (kset_keyboard_translate_table, kset_last_prefix_arg)
1551 (kset_last_repeatable_command, kset_local_function_key_map)
1552 (kset_overriding_terminal_local_map, kset_real_last_command)
1553 (kset_system_key_syms): New setter functions.
1554
f00af5b1
PE
1555 * frame.h (FSET): Remove (Bug#12215).
1556 Replace all uses with calls to new setter functions.
1557 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
1558 (FRAME_INLINE): New macro.
1559 (fset_buffer_list, fset_buried_buffer_list, fset_condemned_scroll_bars)
1560 (fset_current_tool_bar_string, fset_desired_tool_bar_string)
1561 (fset_face_alist, fset_focus_frame, fset_icon_name, fset_menu_bar_items)
1562 (fset_menu_bar_vector, fset_menu_bar_window, fset_name)
1563 (fset_param_alist, fset_root_window, fset_scroll_bars)
1564 (fset_selected_window, fset_title, fset_tool_bar_items)
1565 (fset_tool_bar_position, fset_tool_bar_window): New functions.
1566 * frame.c (FRAME_INLINE):
1567 Define to EXTERN_INLINE, so that the corresponding functions
1568 are compiled into code.
1569 (fset_buffer_predicate, fset_minibuffer_window): New setter functions.
1570
0c94c8d6
PE
1571 A few more naming-convention fixes for getters and setters.
1572 * buffer.c (set_buffer_overlays_before): Move here from buffer.h,
1573 and rename from buffer_overlays_set_before.
1574 (set_buffer_overlays_after): Move here from buffer.h, and rename
1575 from buffer_overlays_set_after.
1576 * buffer.h (buffer_intervals): Rename from buffer_get_intervals.
1577 All uses changed.
1578 (set_buffer_intervals): Rename from buffer_set_intervals.
1579 * intervals.c (set_interval_object): Move here from intervals.h,
1580 and rename from interval_set_object.
1581 (set_interval_left): Move here from intervals.h, and rename from
1582 interval_set_left.
1583 (set_interval_right): Move here from intervals.h, and rename from
1584 interval_set_right.
1585 (copy_interval_parent): Move here from intervals.h, and rename from
1586 interval_copy_parent.
1587 * intervals.h (set_interval_parent): Rename from interval_set_parent.
1588 (set_interval_plist): Rename from interval_set_plist.
1589 Return void, not Lisp_Object, since no caller uses the result.
1590 * lisp.h (string_intervals): Rename from string_get_intervals.
1591 (set_string_intervals): Rename from string_set_intervals.
1592
34dabdb7
PE
1593 * lisp.h (set_char_table_extras): Rename from char_table_set_extras.
1594 (set_char_table_contents): Rename from char_table_set_contents.
0b390a9d 1595 (set_sub_char_table_contents): Rename from sub_char_table_set_contents.
34dabdb7
PE
1596 All uses changed. See the end of
1597 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00549.html>.
1598
742af32f
PE
1599 * lisp.h (CSET): Remove (Bug#12215).
1600 (set_char_table_ascii, set_char_table_defalt, set_char_table_parent)
1601 (set_char_table_purpose): New functions,
1602 replacing CSET. All uses changed. For example, replace
1603 "CSET (XCHAR_TABLE (char_table), parent, parent);" with
c24eb18a 1604 "set_char_table_parent (char_table, parent);".
742af32f
PE
1605 The old version was confusing because it used the same name
1606 'parent' for two different things.
1607
a04e2c62
DA
16082012-08-17 Dmitry Antipov <dmantipov@yandex.ru>
1609
1610 Functions to get and set Lisp_Object fields of buffer-local variables.
1611 * lisp.h (blv_found, set_blv_found, blv_value, set_blv_value)
1612 (set_blv_where, set_blv_defcell, set_blv_valcell): New functions.
1613 (BLV_FOUND, SET_BLV_FOUND, BLV_VALUE, SET_BLV_VALUE): Remove.
1614 * data.c, eval.c, frame.c: Adjust users.
1615
383dcbf9
CY
16162012-08-17 Chong Yidong <cyd@gnu.org>
1617
1618 * xfaces.c (merge_face_vectors): If the target font specfies a
1619 font spec, make the font's attributes take precedence over
1620 directly-specified attributes.
1621 (merge_face_ref): Recognize :font.
1622
44386687
DA
16232012-08-17 Dmitry Antipov <dmantipov@yandex.ru>
1624
1625 Do not use memcpy for copying intervals.
1626 * intervals.c (reproduce_interval): New function.
1627 (reproduce_tree, reproduce_tree_obj): Use it.
1628 (reproduce_tree_obj): Remove prototype.
1629
927c7216
PE
16302012-08-17 Paul Eggert <eggert@cs.ucla.edu>
1631
1632 * lisp.h (duration_to_sec_usec): Remove unused decl.
1633
93044f7b
AA
16342012-08-17 Alp Aker <alp.tekin.aker@gmail.com>
1635
1636 * nsfont.m (ns_ascii_average_width): Send initWithFormat selector
1637 to an allocated instance of NSString, not to the class itself.
1638
9851e4a5
JB
16392012-08-17 Juanma Barranquero <lekktu@gmail.com>
1640
1641 * makefile.w32-in (C_CTYPE_H): New macro.
1642 (LISP_H, $(BLD)/ccl.$(O), $(BLD)/doc.$(O), $(BLD)/w32console.$(O)):
1643 ($(BLD)/fontset.$(O), $(BLD)/frame.$(O), $(BLD)/composite.$(O)):
1644 ($(BLD)/sysdep.$(O), $(BLD)/w32uniscribe.$(O)): Update dependencies.
1645
620f13b0
PE
16462012-08-16 Paul Eggert <eggert@cs.ucla.edu>
1647
1648 Use ASCII tests for character types.
1649 * category.c, dispnew.c, doprnt.c, editfns.c, syntax.c, term.c:
1650 * xfns.c, xterm.c:
1651 Don't include <ctype.h>; was not needed.
1652 * charset.c, doc.c, fileio.c, font.c, frame.c, gtkutil.c, image.c:
1653 * sysdep.c, xfaces.c:
1654 Include <c-ctype.h> instead of <ctype.h>.
1655 * nsterm.m: Include <c-ctype.h>.
1656 * charset.c (read_hex):
1657 * doc.c (Fsnarf_documentation):
1658 * fileio.c (IS_DRIVE) [WINDOWSNT]:
1659 (DRIVE_LETTER) [DOS_NT]:
1660 (Ffile_name_directory, Fexpand_file_name)
1661 (Fsubstitute_in_file_name):
1662 * font.c (font_parse_xlfd, font_parse_fcname):
1663 * frame.c (x_set_font_backend):
1664 * gtkutil.c (xg_get_font):
1665 * image.c (xbm_scan, xpm_scan, pbm_scan_number):
1666 * nsimage.m (hexchar):
1667 * nsterm.m (ns_xlfd_to_fontname):
1668 * sysdep.c (system_process_attributes):
1669 * xfaces.c (hash_string_case_insensitive):
1670 Use C-locale tests instead of locale-specific tests for character
1671 types, since we want the ASCII interpretation here, not the
1672 interpretation suitable for whatever happens to be the current locale.
1673
52162052
MR
16742012-08-16 Martin Rudalics <rudalics@gmx.at>
1675
1676 Consistently check windows for validity/liveness
1677 (Bug#11984, Bug#12025, Bug#12026).
1678 * lisp.h (CHECK_VALID_WINDOW): New macro.
1679 * window.c (decode_window): Rename to decode_live_window.
1680 (decode_valid_window, Fwindow_valid_p): New functions.
1681 (Fwindow_frame, Fframe_root_window, Fwindow_minibuffer_p)
1682 (Fframe_first_window, Fframe_selected_window, Fwindow_parent)
1683 (Fwindow_top_child, Fwindow_left_child, Fwindow_next_sibling)
1684 (Fwindow_prev_sibling, Fwindow_combination_limit)
1685 (Fset_window_combination_limit, Fwindow_use_time)
1686 (Fwindow_total_height, Fwindow_total_width, Fwindow_new_total)
1687 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_left_column)
1688 (Fwindow_top_line, Fwindow_body_height, Fwindow_body_width)
1689 (Fwindow_hscroll, Fset_window_hscroll)
1690 (Fwindow_redisplay_end_trigger)
1691 (Fset_window_redisplay_end_trigger, Fwindow_edges)
1692 (Fwindow_pixel_edges, Fwindow_absolute_pixel_edges)
1693 (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1694 (Fcoordinates_in_window_p, Fwindow_point, Fwindow_start)
1695 (Fwindow_end, Fset_window_point, Fset_window_start)
1696 (Fpos_visible_in_window_p, Fwindow_line_height)
1697 (Fwindow_dedicated_p, Fset_window_dedicated_p)
1698 (Fwindow_prev_buffers, Fset_window_prev_buffers)
1699 (Fwindow_next_buffers, Fwindow_parameters, Fwindow_parameter)
1700 (Fset_window_parameter, Fwindow_display_table)
1701 (Fset_window_display_table, Fdelete_other_windows_internal)
1702 (Fset_window_buffer, Fset_window_new_total)
1703 (Fset_window_new_normal, Fdelete_window_internal)
1704 (Fwindow_text_height, Fset_window_margins, Fwindow_margins)
1705 (Fset_window_fringes, Fwindow_fringes, Fset_window_scroll_bars)
1706 (Fwindow_scroll_bars): Check whether argument window is a valid or
1707 live window. Update doc-strings.
1708 (syms_of_window): New symbol Qwindow_valid_p.
1709 * keyboard.c (Fposn_at_x_y): Check whether argument
1710 frame_or_window denotes a valid window.
1711
2751c80f
DA
17122012-08-16 Dmitry Antipov <dmantipov@yandex.ru>
1713
1714 Fix previous char table change.
1715 * lisp.h (CHAR_TABLE_SET): Use sub_char_table_set_contents.
1716 * chartab.c (optimize_sub_char_table): Likewise.
1717
032a42c8
CY
17182012-08-16 Chong Yidong <cyd@gnu.org>
1719
a2d19368
CY
1720 * gtkutil.c (xg_get_font): Demand an Xft font (Bug#3228).
1721
032a42c8
CY
1722 * xfont.c (xfont_open):
1723 * xftfont.c (xftfont_open): Set the font's max_width field.
1724
1725 * nsfont.m (nsfont_open): Similar to the Xft backend, set
1726 min_width to space_width and average_width to the average over
1727 printable ASCII characters.
1728 (ns_char_width): Code cleanup.
1729 (ns_ascii_average_width): New utility function.
1730
1731 * font.h (struct font): Update comments.
1732
a098c930
DA
17332012-08-16 Dmitry Antipov <dmantipov@yandex.ru>
1734
032a42c8 1735 Simple interface to set Lisp_Object fields of character tables.
a098c930
DA
1736 * lisp.h (CSET): New macro.
1737 (char_table_set_extras, char_table_set_contents)
1738 (sub_char_table_set_contents): New function.
1739 * casetab.c, category.c, chartab.c, fns.c, fontset.c, search.c:
1740 * syntax.c: Adjust users.
1741
8be3a09c
SM
17422012-08-16 Stefan Monnier <monnier@iro.umontreal.ca>
1743
1744 * eval.c (eval_sub): Bind lexical-binding.
1745 * lread.c (Qlexical_binding): Make non-static.
1746
ac4845a6
JD
17472012-08-15 Jan Djärv <jan.h.d@swipnet.se>
1748
ddee6515
JD
1749 * nsmenu.m (popupSession): Remove.
1750 (pop_down_menu): Remove endModalSession.
1751 (timeout_handler:): New method.
1752 (runDialogAt:): Get next timeout. Start a NSTimer with that timeout.
1753 Call runModalForWindow. Check timer_fired when it returns.
1754 If not set, cancel timer and break out of loop.
1755 Otherwise loop again, with a new timeout.
1756
1757 * nsterm.m: Include fcntl.h if present.
1758 (fd_entry, t_readfds, inNsSelect): Remove.
1759 (select_writefds, select_valid, select_timeout, selfds)
1760 (select_mutex, apploopnr): Add.
1761 (EV_TRAILER): Call kbd_buffer_store_event_hold only if q_event_ptr.
1762 Otherwise call kbd_buffer_store_event.
1763 (ns_send_appdefined): Remove release of fd_entry.
1764 (ns_read_socket): Always send appdefined. Remove inNsSelect check.
1765 Increment and decrement apploopnr.
1766 (ns_select): If no file descriptors, just do a NSTimer.
1767 Otherwise copy read/write masks and start select thread (fd_handler).
1768 Start main loop and wait for application defined event.
1769 Inform select thread to stop selecting after main loop is exited.
1770 (ns_term_init): Create selfds pipe and set non-blocking.
fc0c31f8 1771 Initialize select_mutex. Start the select thread (fd_handler).
ddee6515
JD
1772 (fd_handler:): Loop forever, wait for info from the main thread
1773 to either start or stop selecting. When select returns, send
1774 and appdefined event.
1775 (sendScrollEventAtLoc:fromEvent:): Check if q_event_ptr is set.
1776 If not call kbd_buffer_store_event.
1777
1778 * nsterm.h (EmacsApp): fd_handler takes id argument.
1779 (EmacsDialogPanel): Add timer_fired and timeout_handler.
1780
ac4845a6
JD
1781 * gtkutil.c (xg_mark_data): Use FRAME_X_P.
1782
eb424fe3
EZ
17832012-08-15 Eli Zaretskii <eliz@gnu.org>
1784
1785 * region-cache.c (move_cache_gap): Update gap_len using the actual
1786 growth of the boundaries array. Do not change cache_len.
1787 (Bug#12196)
1788
4e6a86c6
DA
17892012-08-15 Dmitry Antipov <dmantipov@yandex.ru>
1790
1791 Generalize and cleanup font subsystem checks.
1792 * font.h (FONT_DEBUG, font_assert): Remove.
8be3a09c
SM
1793 * font.c, fontset.c, w32font.c, xfont.c, xftfont.c:
1794 Change font_assert to eassert. Use eassert where appropriate.
4e6a86c6 1795
5bf192ca
DA
17962012-08-15 Dmitry Antipov <dmantipov@yandex.ru>
1797
1798 * gtkutil.c (xg_get_font): Use pango_units_to_double.
1799
f2045622
CY
18002012-08-15 Chong Yidong <cyd@gnu.org>
1801
8be3a09c
SM
1802 * gtkutil.c (xg_get_font): Rename from xg_get_font_name.
1803 When using the new font chooser, use gtk_font_chooser_get_font_desc to
1804 extract the font descriptor instead of just the font name.
1805 In that case, return a font spec instead of a string.
f2045622
CY
1806 (x_last_font_name): Move to this file from xfns.c.
1807
1808 * xfns.c (Fx_select_font): The return value can also be a font
1809 spec. Move x_last_font_name management to gtkutil.c.
1810
1811 * xfaces.c: Make font weight and style symbols non-static.
1812
7f6feb56
SM
18132012-08-15 Stefan Monnier <monnier@iro.umontreal.ca>
1814
1815 * minibuf.c (read_minibuf): Ignore caller's inhibit-read-only
1816 (bug#12117).
1817
fecbd8ff
SM
18182012-08-14 Stefan Monnier <monnier@iro.umontreal.ca>
1819
1820 * alloc.c (Fgarbage_collect): Use plural form consistently.
1821
9b8d5165
EZ
18222012-08-14 Eli Zaretskii <eliz@gnu.org>
1823
1824 * keyboard.c (command_loop_1): Reset ignore_mouse_drag_p flag each
1825 iteration through the command loop. Fixes a problem whereby mouse
1826 movements are ignored until the first mouse click.
1827
f5d9e83a
PE
18282012-08-14 Paul Eggert <eggert@cs.ucla.edu>
1829
1830 Use bool, not int, for Lisp booleans.
1831 This is more natural, and on my platform (GCC 4.7.1 x86-64) it
1832 makes Emacs a bit smaller and presumably a bit faster.
1833 * lisp.h: Include <stdbool.h>.
1834 (struct Lisp_Boolfwd, defvar_bool):
1835 * lread.c (defvar_bool): Use bool, not int, for Lisp booleans.
1836 * regex.c [!emacs]: Include <stdbool.h>.
1837 (false, true): Remove; <stdbool.h> does this for us now.
1838
55802e4a
CY
18392012-08-14 Chong Yidong <cyd@gnu.org>
1840
4abcdac8
CY
1841 * character.c (Fcharacterp): Doc fix (Bug#12076).
1842
1843 * data.c (Findirect_variable): Doc fix (Bug#11040).
1844
55802e4a
CY
1845 * chartab.c (Fmap_char_table): Doc fix (Bug#12061).
1846
1847 * editfns.c (Fformat): Doc fix (Bug#12059).
4abcdac8 1848 (Fsave_current_buffer): Doc fix (Bug#11542).
55802e4a 1849
8e99d072
BR
18502012-08-14 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
1851
1852 * keyboard.c (access_keymap_keyremap): Accept anonymous functions
1853 (bug#12022).
1854
08908aca
MR
18552012-08-14 Martin Rudalics <rudalics@gmx.at>
1856
1857 * frame.c (make_frame_without_minibuffer, make_minibuffer_frame)
1858 (delete_frame, Fmake_frame_invisible, Ficonify_frame):
1859 * minibuf.c (choose_minibuf_frame, read_minibuf):
1860 * w32fns.c (x_create_tip_frame):
1861 * xfns.c (x_create_tip_frame): Call set_window_buffer instead of
1862 Fset_window_buffer (Bug#11984, Bug#12025, Bug#12026).
1863
56120d6f
PE
18642012-08-14 Paul Eggert <eggert@cs.ucla.edu>
1865
1866 * intervals.c (offset_intervals): Remove obsolete comment.
1867
67b77c0b
AS
18682012-08-14 Andreas Schwab <schwab@linux-m68k.org>
1869
1870 * gtkutil.c (find_rtl_image, update_frame_tool_bar): Use NILP.
1871
f48b82fd
GR
18722012-08-14 Gergely Risko <gergely@risko.hu>
1873
1874 * coding.c (decode_coding): Record buffer modification before
1875 disabling undo_list (Bug#11773).
1876
fd318b54
DA
18772012-08-14 Dmitry Antipov <dmantipov@yandex.ru>
1878
1879 Revert and cleanup some recent overlay changes.
1880 * buffer.h (enum overlay_type): Remove.
1881 (buffer_get_overlays, buffer_set_overlays): Likewise.
1882 (buffer_set_overlays_before, buffer_set_overlays_after):
1883 New function. Adjust users.
1884 (unchain_both): Add eassert.
1885
41a62dd9
DA
18862012-08-14 Dmitry Antipov <dmantipov@yandex.ru>
1887
1888 * gtkutil.c (update_frame_tool_bar): Use EQ where appropriate.
1889
5884c324
PE
18902012-08-14 Paul Eggert <eggert@cs.ucla.edu>
1891
1892 * gtkutil.c (xg_mark_data): Don't assume C99.
1893
ca06f160
JD
18942012-08-13 Jan Djärv <jan.h.d@swipnet.se>
1895
1896 * gtkutil.c (xg_frame_tb_info): New struct.
1897 (TB_INFO_KEY): New define.
1898 (xg_free_frame_widgets): Free xg_frame_tb_info for frame if present.
1899 (xg_mark_data): Mark Lisp_Objects in xg_frame_tb_info.
1900 (xg_create_tool_bar): Allocate and initialize a xg_frame_tb_info
1901 if not present.
1902 (update_frame_tool_bar): Return early if data in xg_frame_tb_info
fc0c31f8 1903 is up to date. Otherwise store new data.
ca06f160
JD
1904 (free_frame_tool_bar): Free xg_frame_tb_info if present.
1905
7864a3f7
DA
19062012-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1907
1908 Use KSET for write access to Lisp_Object members of struct kboard.
1909 * keyboard.h (KSET): New macro.
1910 * callint.c, category.c, frame.c, keyboard.c, keyboard.h, macros.c:
1911 * msdos.c, nsfns.m, nsterm.m, term.c, w32fns.c, w32term.c, xfns.c:
1912 * xterm.c: Adjust users.
1913
4c31be61
DA
19142012-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1915
1916 Use BSET for write access to Lisp_Object members of struct buffer.
1917 * buffer.h (BSET): New macro.
1918 * buffer.c, casetab.c, cmds.c, coding.c, data.c, editfns.c:
1919 * fileio.c, frame.c, indent.c, insdel.c, intervals.c, keymap.c:
1920 * minibuf.c, print.c, process.c, syntax.c, undo.c, w32fns.c:
1921 * window.c, xdisp.c, xfns.c: Adjust users.
1922
14ae4239
BT
19232012-08-11 BT Templeton <bpt@hcoop.net> (tiny change)
1924
1925 * lread.c (syms_of_lread): Initialize Vlexical_binding.
1926
32bcadb4
JD
19272012-08-11 Jan Djärv <jan.h.d@swipnet.se>
1928
3d29b2ce 1929 * nsterm.m (not_in_argv): New function.
fc0c31f8 1930 (application:openFile, application:openTempFile:):
3d29b2ce
JD
1931 (application:openFileWithoutUI:, application:openFiles:): Open file
1932 if not_in_argv returns non-zero (bug#12171).
1933
32bcadb4 1934 * gtkutil.c (gtk_font_chooser_dialog_new, GTK_FONT_CHOOSER)
14ae4239
BT
1935 (gtk_font_chooser_set_font, gtk_font_chooser_get_font):
1936 Define for Gtk+ versions less than 3.2.
32bcadb4
JD
1937 (xg_get_font_name): Use those functions/macros here.
1938 Reported by Frans Oilinki <moilinki@gmail.com>.
1939
9ff9402d 19402012-08-11 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8ccd072a
YM
1941
1942 * unexmacosx.c (copy_data_segment): Copy initialized data in
1943 statically linked libraries from input file rather than memory.
1944
db74a5fc
YM
1945 * unexmacosx.c (print_load_command_name): Add cases LC_MAIN,
1946 LC_SOURCE_VERSION, and LC_DYLIB_CODE_SIGN_DRS.
1947 (dump_it) [LC_DYLIB_CODE_SIGN_DRS]: Call copy_linkedit_data.
1948
25e65510
GM
19492012-08-10 Glenn Morris <rgm@gnu.org>
1950
1951 * conf_post.h (IF_LINT, lint_assume): Move here from lisp.h.
1952 * lisp.h (IF_LINT, lint_assume): Move to conf_post.h.
1953
7961135c
DA
19542012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
1955
1956 Fix last change to allow compilation with low optimization levels.
1957 * intervals.c (INTERVALS_INLINE): Define to EXTERN_INLINE.
1958 Reported by Jan Djärv <jan.h.d@swipnet.se>.
1959
42b3a444
DA
19602012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
1961
1962 Use common inline syntax in intervals.h.
1963 * intervals.h (INTERVALS_INLINE): New macro.
1964 Change all users from LISP_INLINE.
1965
9fb0c957
DA
19662012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
1967
1968 Define Qnone once for all platforms.
1969 * frame.c (Qnone): Define here.
1970 (syms_of_frame): DEFSYM it.
1971 * lisp.h (Qnone): New declaration.
1972 * nsfns.m, nsterm.h, nsterm.m, w32fns.c, w32font.c:
1973 * xfns.c: Remove duplication. Adjust users.
1974
65e8ee52
DA
19752012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
1976
1977 Remove unused macros from intervals.h.
1978 * intervals.h (MERGE_INSERTIONS, DISPLAY_INVISIBLE_GLYPH): Remove.
1979 * intervals.c: Adjust comment.
1980
9b855fd6
EZ
19812012-08-10 Eli Zaretskii <eliz@gnu.org>
1982
1983 * w32fns.c <w32_unicode_gui>: New static variable.
1984 (globals_of_w32fns): Initialize it according to os_subtype.
1985 (w32_init_class, w32_msg_pump, w32_wnd_proc): Use it instead of
1986 testing os_subtype.
1987
39cb9e56 19882012-08-10 Joakim Hårsman <joakim.harsman@gmail.com> (tiny change)
d30be705
EZ
1989 Eli Zaretskii <eliz@gnu.org>
1990
1991 Fix bug #10299 with Unicode characters sent by customized
1992 keyboards created by MSKLC.
1993 * w32fns.c (INIT_WINDOW_CLASS): New macro.
1994 (w32_init_class): Use it to initialize the Emacs class with either
1995 ANSI or Unicode API calls.
1996 (w32_msg_pump): Call GetMessageW and DispatchMessageW on NT and
1997 later.
1998 (w32_wnd_proc): If the character code sent by WM_CHAR or
1999 WM_SYSCHAR is above 255, post a WM_UNICHAR message, not the
2000 original message. Call DefWindowProcW on NT and later.
2001
9374581a
GM
20022012-08-10 Glenn Morris <rgm@gnu.org>
2003
4b94e8cf
GM
2004 * Makefile.in (config_h): Fix conf_post.h out-of-tree build location.
2005
9374581a
GM
2006 * lisp.h (DIRECTORY_SEP): Let configure set it.
2007
a2752828
DA
20082012-08-09 Dmitry Antipov <dmantipov@yandex.ru>
2009
2010 Use TSET for write access to Lisp_Object slots of struct terminal.
2011 * termhooks.h (TSET): New macro.
2012 * coding.c, terminal.c, xselect.c: Adjust users.
2013
cc92c454
SM
20142012-08-08 Stefan Monnier <monnier@iro.umontreal.ca>
2015
2016 * xdisp.c (safe_eval_handler): Remove prototype. Receive args describing
2017 the failing expression, include them in the error message.
2018 * eval.c (internal_condition_case_n): Pass nargs and args to hfun.
2019 * lisp.h (internal_condition_case_n): Update declaration.
2020
4cb3e6b3
DA
20212012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
2022
2023 Inline functions to examine and change buffer overlays.
2024 * buffer.c (unchain_both): New function.
2025 * buffer.h (buffer_get_overlays, buffer_set_overlays):
2026 (buffer_has_overlays): New function.
2027 (enum overlay_type): New enum.
2028 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c:
2029 * insdel.c, intervals.c, print.c, xdisp.c: Adjust users.
2030
8707c1e5
DA
20312012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
2032
2033 Inline functions to examine and change buffer intervals.
2034 * alloc.c (mark_interval_tree): Remove.
2035 (MARK_INTERVAL_TREE): Simplify.
2036 (UNMARK_BALANCE_INTERVALS): Remove. Adjust users.
2037 * intervals.c (buffer_balance_intervals): New function.
2038 (graft_intervals_into_buffer): Adjust indentation.
2039 (set_intervals_multibyte): Simplify.
2040 * buffer.h (BUF_INTERVALS): Remove.
2041 (buffer_get_intervals, buffer_set_intervals): New function.
2042 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c, insdel.c:
2043 * intervals.c, textprop.c: Adjust users.
2044
ad8c997f
DA
20452012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
2046
2047 Inline functions to examine and change string intervals.
2048 * lisp.h (STRING_INTERVALS, STRING_SET_INTERVALS): Remove.
2049 (string_get_intervals, string_set_intervals): New function.
2050 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
2051 * lread.c, print.c, textprop.c: Adjust users.
2052
32ac3a6b
GM
20532012-08-08 Glenn Morris <rgm@gnu.org>
2054
2055 * lisp.mk (lisp): Remove language/persian.elc.
2056
77c7bcb1
DA
20572012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
2058
2059 Cleanup intervals.
2060 * intervals.h (NULL_INTERVAL, DEFAULT_INTERVAL): Remove.
2061 (NULL_INTERVAL_P): Likewise. Adjust users.
14ae4239
BT
2062 (FRONT_STICKY_P, END_NONSTICKY_P, FRONT_NONSTICKY_P):
2063 Adjust comment. Move under #if 0.
77c7bcb1
DA
2064 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
2065 * print.c, syntax.c, textprop.c, xdisp.c: Adjust users.
2066
9c08a8d4
DA
20672012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
2068
2069 Check total length of intervals with eassert.
2070 * intervals.h (CHECK_TOTAL_LENGTH): Remove.
2071 * intervals.c: Change all users to eassert.
2072
26d16b35
EZ
20732012-08-07 Eli Zaretskii <eliz@gnu.org>
2074
14ae4239
BT
2075 * .gdbinit (xframe, xwindow, nextcons, xcar, xcdr, xlist):
2076 Rename fields to match removal of FGET and WGET and disuse of
26d16b35
EZ
2077 INTERNAL_FIELD in Lisp_Cons.
2078
c644523b
DA
20792012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
2080
2081 Revert and cleanup Lisp_Cons, Lisp_Misc and Lisp_Symbol things.
2082 * lisp.h (struct Lisp_Symbol): Change xname to meaningful
2083 name since all xname users are fixed long time ago. Do not
2084 use INTERNAL_FIELD.
2085 (set_symbol_name, set_symbol_function, set_symbol_plist):
2086 (set_symbol_next, set_overlay_plist): New function.
2087 (struct Lisp_Cons): Do not use INTERNAL_FIELD.
2088 (struct Lisp_Overlay): Likewise.
2089 (CVAR, MVAR, SVAR): Remove.
2090 * alloc.c, buffer.c, buffer.h, bytecode.c, cmds.c, data.c:
2091 * doc.c, eval.c, fns.c, keyboard.c, lread.c, nsselect.m:
2092 * xterm.c: Adjust users.
2093 * .gdbinit: Change to use name field of struct Lisp_Symbol
2094 where appropriate.
2095
6a3d20cc
DA
20962012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
2097
2098 Basic functions to set Lisp_Object and pointer slots of intervals.
2099 * intervals.h (interval_set_parent, interval_set_object):
2100 (interval_set_left, interval_set_right, interval_set_plist):
2101 (interval_copy_parent): New function.
2102 (SET_INTERVAL_OBJECT, SET_INTERVAL_PARENT, INTERVAL_PTR_SIZE): Remove.
14ae4239
BT
2103 (RESET_INTERVAL, COPY_INTERVAL_CACHE, MERGE_INTERVAL_CACHE):
2104 Adjust indentation.
6a3d20cc
DA
2105 (INTERVAL_SIZE): Remove. Adjust users.
2106 * alloc.c, intervals.c, lread.c, textprop.c: Use new functions.
2107
4d2b044c
DA
21082012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
2109
2110 Drop PGET and revert read access to Lisp_Objects slots of Lisp_Process.
2111 * process.h (PGET): Remove.
2112 (struct Lisp_Process): Do not use INTERNAL_FIELD.
2113 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
2114
d3d50620
DA
21152012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
2116
2117 Drop WGET and revert read access to Lisp_Objects slots of struct window.
2118 * window.h (WGET): Remove.
2119 (struct window): Do not use INTERNAL_FIELD.
2120 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
2121 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
2122 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
2123 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
2124 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
2125 Adjust users.
2126
d10a51dc
CY
21272012-08-07 Chong Yidong <cyd@gnu.org>
2128
2129 * window.c (Fwindow_edges, Fwindow_pixel_edges)
2130 (Fwindow_absolute_pixel_edges, Fdelete_other_windows_internal)
2131 (Fdelete_window_internal): Signal an error if the window is not on
2132 a live frame (Bug#12025).
2133
e69b0960
DA
21342012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
2135
2136 Drop FGET and revert read access to Lisp_Objects slots of struct frame.
2137 * frame.h (FGET): Remove.
2138 (struct frame): Do not use INTERNAL_FIELD.
2139 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
2140 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
2141 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
2142 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
2143
25a20a3a
JB
21442012-08-06 Juanma Barranquero <lekktu@gmail.com>
2145
2146 * w32.c: Silence compiler warnings.
2147 (map_w32_filename): Remove unused variable `is_fat'.
2148 (chase_symlinks): Add parentheses around expression.
2149
1c6f11f4
GM
21502012-08-06 Glenn Morris <rgm@gnu.org>
2151
1db4583a
GM
2152 * sysdep.c: Respect BROKEN_GETWD.
2153
1c6f11f4
GM
2154 * dispnew.c (GNU_LIBRARY_PENDING_OUTPUT_COUNT, PENDING_OUTPUT_COUNT):
2155 Let configure handle it.
2156 (stdio_ext.h) [DISPNEW_NEEDS_STDIO_EXT]: Include it.
2157
2b90362b
DA
21582012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2159
2160 Use GCALIGNMENT where appropriate.
2161 * alloc.c (XMALLOC_HEADER_ALIGNMENT, roundup_size):
2162 (union aligned_Lisp_Symbol, union aligned_Lisp_Misc):
2163 (mark_maybe_pointer, pure_alloc): Change to use GCALIGNMENT.
2164
5f50daf2
EZ
21652012-08-06 Eli Zaretskii <eliz@gnu.org>
2166
14ae4239
BT
2167 * w32menu.c (set_frame_menubar, initialize_frame_menubar):
2168 Don't use FRAME_MENU_BAR_ITEMS as an lvalue.
5f50daf2 2169
cbcc7007
SM
21702012-08-06 Stefan Monnier <monnier@iro.umontreal.ca>
2171
2172 * buffer.h (struct buffer): Revert `indirections' to a simple int;
2173 that should be sufficient for everyone.
2174
4d365fa4
JD
21752012-08-06 Jan Djärv <jan.h.d@swipnet.se>
2176
2177 * keyboard.c (timer_check_2): Add break so timer_check returns next
2178 timeout.
2179
dd86bd82
DA
21802012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2181
2182 Fix Windows build errors introduced after converting to WGET and WSET.
2183 * w32term.c (w32_set_vertical_scroll_bar): Change to use WSET.
2184 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
2185
054e1668
JD
21862012-08-06 Jan Djärv <jan.h.d@swipnet.se>
2187
2188 * nsterm.m (ns_frame_rehighlight): Use FSET.
2189
2190 * nsmenu.m (ns_update_menubar): Use FSET.
2191
21238f11
DA
21922012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2193
2194 Separate read and write access to Lisp_Object slots of Lisp_Process.
2195 * process.h (PGET, PSET): New macros similar to AREF and ASET.
2196 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
2197
077288cf
DA
21982012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2199
2200 Separate read and write access to Lisp_Object slots of struct window.
2201 * window.h (WGET, WSET): New macros similar to AREF and ASET.
2202 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
2203 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
2204 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
2205 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
2206 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
2207 Adjust users.
2208
71688bd7
DA
22092012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2210
2211 Fix Windows build errors introduced after converting to FGET and FSET.
2212 * w32term.c (x_frame_rehighlight, x_scroll_bar_create):
2213 (w32_condemn_scroll_bars, w32_redeem_scroll_bar):
2214 (w32_judge_scroll_bars): Change to use FSET.
2215 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
2216
f99bac93
DA
22172012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2218
2219 Fix replacement typo.
2220 * window.c (replace_window): Set root_window instead of
2221 selected_window. This fixes a total window subsystem
2222 malfunction reported by Bastien Guerry <bzg@gnu.org>.
2223
8c2a0f2d
GM
22242012-08-06 Glenn Morris <rgm@gnu.org>
2225
2226 * lisp.mk (lisp): Add language/persian.elc.
2227
edd74c35
DA
22282012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2229
2230 Separate read and write access to Lisp_Object slots of struct frame.
2231 * frame.h (FGET, FSET): New macros similar to AREF and ASET.
2232 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
2233 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
2234 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
2235 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
2236
8671676c
AS
22372012-08-05 Andreas Schwab <schwab@linux-m68k.org>
2238
2239 * emacs.c (decode_env_path): Only use defaulted if WINDOWSNT.
2240
663e2b3f
DA
22412012-08-05 Dmitry Antipov <dmantipov@yandex.ru>
2242
2243 Generalize common compile-time constants.
2244 * lisp.h (header_size, bool_header_size, word_size): Now here.
2245 (struct Lisp_Vector): Add comment.
2246 (struct Lisp_Bool_Vector): Move up to define handy constants.
2247 (VECSIZE, PSEUDOVECSIZE): Simplify.
2248 (SAFE_ALLOCA_LISP): Use new constant. Adjust indentation.
2249 * buffer.c, buffer.h, bytecode.c, callint.c, eval.c, fns.c:
2250 * font.c, fontset.c, keyboard.c, keymap.c, macros.c, menu.c:
2251 * msdos.c, w32menu.c, w32term.h, window.c, xdisp.c, xfaces.c:
2252 * xfont.c, xmenu.c: Use word_size where appropriate.
2253
d32e47af
LM
22542012-08-05 Lawrence Mitchell <wence@gmx.li>
2255
2256 * search.c (Freplace_match): Treat \? in the replacement text
2257 literally (Bug#8161).
2258
e5d9c0d1
CY
22592012-08-05 Chong Yidong <cyd@gnu.org>
2260
2261 * term.c (Vsuspend_tty_functions, Vresume_tty_functions):
2262 * frame.c (Vdelete_frame_functions):
2263 * emacs.c (Vkill_emacs_hook): Doc fix.
2264
8da0576b
EZ
22652012-08-04 Eli Zaretskii <eliz@gnu.org>
2266
2267 * xfns.c (x_set_menu_bar_lines): Fix compilation error in
2268 --with-x-toolkit=no builds.
2269 Reported by Carsten Mattner <carstenmattner@gmail.com>.
2270
02676e5d
CY
22712012-08-04 Chong Yidong <cyd@gnu.org>
2272
2273 * syntax.c (Fmodify_syntax_entry): Doc fix.
2274
97147da9
EZ
22752012-08-04 Eli Zaretskii <eliz@gnu.org>
2276
76151e2c
EZ
2277 Fix startup warnings about ../site-lisp on MS-Windows. (Bug#11959)
2278 * w32.c (init_environment): Change the default values of many
2279 environment variables in dflt_envvars[] to NULL, to avoid pushing
14ae4239
BT
2280 them into environment when they were not already defined.
2281 Remove the code that deletes site-lisp subdirectories from the default
76151e2c 2282 value of EMACSLOADPATH, as it is no longer needed.
14ae4239
BT
2283 (check_windows_init_file): Now external, not static.
2284 Use Vload_path as is, without adding anything, as this function is now
76151e2c
EZ
2285 called when Vload_path is already set up.
2286
2287 * w32.h (check_windows_init_file): Add prototype.
2288
2289 * emacs.c (init_cmdargs) [WINDOWSNT]: When running from the build
2290 directory, ignore the /*/i386/ tail in Vinvocation_directory, for
2291 compatibility with Posix platforms.
2292 (main): Move the call to check_windows_init_file to here from
2293 w32.c.
2294 (decode_env_path) [WINDOWSNT]: Expand the %emacs_dir%/ prefix, if
2295 any, in the DEFALT argument into the root of the Emacs build or
2296 installation tree, as appropriate.
2297
2298 * callproc.c (init_callproc_1): Call decode_env_path instead of
2299 doing its equivalent by hand.
2300 (init_callproc): Replace DOS_NT condition with MSDOS, thus letting
2301 the code that sets Vexec_path run on MS-Windows.
2302
2303 * lread.c (init_lread): Add comments to #ifdef's.
2304
97147da9
EZ
2305 * msdos.c (dos_set_window_size, IT_update_begin)
2306 (IT_frame_up_to_date, IT_set_frame_parameters): Use FVAR and WVAR
2307 instead of direct references.
2308
185ee146
PE
23092012-08-04 Paul Eggert <eggert@cs.ucla.edu>
2310
2311 Export DEFAULT_REHASH_* to GDB.
2312 * lisp.h (DEFAULT_REHASH_THRESHOLD, DEFAULT_REHASH_SIZE):
2313 Now constants, not macros.
2314
8834c57a
PE
23152012-08-03 Paul Eggert <eggert@cs.ucla.edu>
2316
98c6f1e3
PE
2317 Remove unnecessary casts involving pointers.
2318 These casts are no longer needed now that we assume C89 or later,
2319 since they involve casting to or from void *.
2320 * alloc.c (make_pure_string, make_pure_c_string, pure_cons)
2321 (make_pure_float, make_pure_vector):
2322 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP):
2323 * macros.c (Fstart_kbd_macro):
2324 * menu.c (find_and_return_menu_selection):
2325 * minibuf.c (read_minibuf_noninteractive):
2326 * sysdep.c (closedir):
2327 * xdisp.c (x_produce_glyphs):
2328 * xfaces.c (compare_fonts_by_sort_order):
2329 * xfns.c (x_real_positions, select_visual):
2330 * xselect.c (x_stop_queuing_selection_requests)
2331 (x_get_window_property, x_get_window_property_as_lisp_data):
2332 * xterm.c (x_set_frame_alpha, x_find_modifier_meanings):
2333 Remove unnecessary pointer casts.
2334 * alloc.c (record_xmalloc): New function.
2335 * lisp.h (record_xmalloc): New decl.
2336 (SAFE_ALLOCA): Now takes just one arg -- the size -- and acts
2337 more like a function. This is because the pointer cast is not
2338 needed. All uses changed.
2339 * print.c (print_string, print_error_message): Avoid length recalc.
2340
8834c57a
PE
2341 Improve fix for macroexp crash with debugging (Bug#12118).
2342 * lisp.h (ASET) [ENABLE_CHECKING]: Pay attention to
2343 ARRAY_MARK_FLAG when checking subscripts, because ASET is
2344 not supposed to be invoked from the garbage collector.
2345 See Andreas Schwab in <http://bugs.gnu.org/12118#25>.
2346 (gc_aset): New function, which is like ASET but can be
2347 used in the garbage collector.
2348 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
2349 (set_hash_index): Use it instead of ASET.
2350
6dad7178
EZ
23512012-08-03 Eli Zaretskii <eliz@gnu.org>
2352
2353 Support symlinks on latest versions of MS-Windows.
2354 * w32.c: Include winioctl.h and aclapi.h.
2355 (is_symlink, chase_symlinks, enable_privilege, restore_privilege)
2356 (revert_to_self): Forward declarations of static functions.
2357 <static BOOL g_b_init_get_security_info>:
2358 <g_b_init_create_symbolic_link>: New static flags.
2359 (globals_of_w32): Initialize them to zero.
2360 (GetSecurityInfo_Proc, CreateSymbolicLink_Proc): New typedefs.
2361 (map_w32_filename): Improve commentary. Simplify switch.
2362 (SYMBOLIC_LINK_FLAG_DIRECTORY): Define if not defined in system
2363 headers (most versions of MinGW w32api don't).
2364 (get_security_info, create_symbolic_link)
2365 (get_file_security_desc_by_handle, is_symlink, chase_symlinks):
2366 New functions.
2367 (sys_access, sys_chmod): Call 'chase_symlinks' to resolve symlinks
2368 in the argument file name.
2369 (sys_access): Call unc_volume_file_attributes only if
2370 GetFileAttributes fails with network-related error codes.
2371 (sys_rename): Diagnose renaming of a symlink when the user doesn't
2372 have the required privileges.
14ae4239 2373 (get_file_security_desc_by_name): Rename from
6dad7178
EZ
2374 get_file_security_desc.
2375 (stat_worker): New function, with most of the guts of 'stat', and
14ae4239
BT
2376 with addition of handling of symlinks and support for 'lstat'.
2377 If possible, get file's attributes and security information by
6dad7178
EZ
2378 handle, not by name. Produce S_IFLNK bit for symlinks, when
2379 called from 'lstat'.
2380 (stat, lstat): New functions, call 'stat_worker'.
2381 (symlink, readlink, careadlinkat): Rewritten to create and resolve
2382 symlinks when the underlying filesystem supports them.
2383
f162bcc3
PE
23842012-08-02 Paul Eggert <eggert@cs.ucla.edu>
2385
79ea6c20
PE
2386 Fix macroexp crash on Windows with debugging (Bug#12118).
2387 * lisp.h (ASET) [ENABLE_CHECKING]: Ignore ARRAY_MARK_FLAG when
2388 checking subscripts; problem introduced with the recent
2389 "ASET (a, i, v)" rather than "AREF (a, i) = v" patch.
2390 (ARRAY_MARK_FLAG): Now a macro as well as a constant,
2391 since it's used in non-static inline functions now.
2392
c0ce93fd
PE
2393 * xfaces.c (face_at_buffer_position, face_for_overlay_string):
2394 Don't assume buffer size fits in 'int'. Remove unused local.
c71f5156 2395
f162bcc3
PE
2396 Use C99-style 'extern inline' if available.
2397 * buffer.h (BUFFER_INLINE):
2398 * category.h (CATEGORY_INLINE):
2399 * character.h (CHARACTER_INLINE):
2400 * charset.h (CHARSET_INLINE):
2401 * composite.h (COMPOSITE_INLINE):
2402 * dispextern.h (DISPEXTERN_INLINE):
2403 * lisp.h (LISP_INLINE):
2404 * systime.h (SYSTIME_INLINE):
2405 New macro, replacing 'static inline' in this header.
2406 * buffer.h, category.h, character.h, charset.h, composite.h:
2407 * dispextern.h, lisp.h, systime.h:
2408 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
2409 * alloc.c (LISP_INLINE):
2410 * buffer.c (BUFFER_INLINE):
2411 * category.c (CATEGORY_INLINE):
2412 * character.c (CHARACTER_INLINE):
2413 * charset.c (CHARSET_INLINE):
2414 * composite.c (COMPOSITE_INLINE):
2415 * dispnew.c (DISPEXTERN_INLINE):
2416 * sysdep.c (SYSTIME_INLINE):
2417 Define to EXTERN_INLINE, so that the corresponding functions
2418 are compiled into code.
2419 * conf_post.h (INLINE, EXTERN_INLINE, INLINE_HEADER_BEGIN)
2420 (INLINE_HEADER_END): New macros.
2421 * lisp.h (PSEUDOVECTOR_FLAG): Now a macro as well as a constant,
2422 since it's used in non-static inline functions now.
a8333d03 2423 (VALMASK) [!USE_LSB_TAG]: Likewise.
f162bcc3 2424
837b365b
GM
24252012-08-02 Glenn Morris <rgm@gnu.org>
2426
d66b744d
GM
2427 * s/: Remove empty directory.
2428
837b365b
GM
2429 * s/ms-w32.h: Move to ../nt/inc.
2430 * makefile.w32-in (TAGS, TAGS-gmake, MS_W32_H):
2431 Update for new ms-w32.h location.
2432
13294f95
PE
24332012-08-02 Paul Eggert <eggert@cs.ucla.edu>
2434
2435 Port to Solaris 8.
2436 * syswait.h (WRETCODE): Remove, consistently with ../configure.ac.
2437
90df0db3
GM
24382012-08-02 Glenn Morris <rgm@gnu.org>
2439
2440 * nsterm.m (ns_exec_path, ns_load_path): Use SEPCHAR rather than
2441 hard-coding the path separator.
2442
4939150c
PE
24432012-08-01 Paul Eggert <eggert@cs.ucla.edu>
2444
2445 Use "ASET (a, i, v)" rather than "AREF (a, i) = v".
2446 This how ASET and AREF are supposed to work, and makes
2447 it easier to think about future improvements. See
2448 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00026.html>.
2449 * charset.h (set_charset_attr): New function.
2450 All lvalue-style uses of CHARSET_DECODER etc. changed to use it.
2451 * lisp.h (ASET): Rewrite so as not to use AREF in an lvalue style.
2452 (aref_addr): New function. All uses of &AREF(...) changed.
2453 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
2454 (set_hash_index): New functions. All lvalue-style uses of
2455 HASH_KEY etc. changed.
2456 * keyboard.c (set_prop): New function. All lvalue-style uses
2457 of PROP changed.
2458
947b2afd
AA
24592012-08-01 Alp Aker <alp.tekin.aker@gmail.com>
2460
2461 * nsterm.m (ns_set_vertical_scroll_bar, ns_redeem_scroll_bar)
2462 (EmacsWindow-accessibilityAttributeValue, EmacsScroller-initFrame:)
2463 (EmacsScroller-dealloc): Adjust to use WVAR. (Bug#12114)
2464 * nsfns.m (ns_set_name_as_filename): Likewise.
2465 * nsmenu.m (ns_update_menubar): Likewise.
2466 * nsselect.m (symbol_to_nsstring): Adjust to use SVAR.
2467
4f5d0325
EZ
24682012-08-01 Eli Zaretskii <eliz@gnu.org>
2469
2008beae
EZ
2470 * .gdbinit (xcar, xcdr, xlist, xwindow, nextcons, xprintsym):
2471 Adapt to latest changes in field names of the corresponding Lisp
288479f6 2472 objects.
2008beae 2473
4f5d0325
EZ
2474 * xdisp.c (try_window_id): Use WVAR in IF_DEBUG code.
2475
fe3cc771
GM
24762012-08-01 Glenn Morris <rgm@gnu.org>
2477
2478 * s/msdos.h: Remove file.
2479 * conf_post.h [MSDOS]: New section, moved from s/msdos.h.
2480 * Makefile.in (S_FILE): Remove.
2481 (config_h): Remove S_FILE.
2482
c90acc54
JB
24832012-08-01 Juanma Barranquero <lekktu@gmail.com>
2484
2485 * s/ms-w32.h (DEVICE_SEP, IS_DIRECTORY_SEP, IS_ANY_SEP):
2486 Remove; moved to nt/config.nt.
2487
d8a05828
DA
24882012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2489
2490 Use INTERNAL_FIELD for conses and overlays.
2491 * lisp.h (struct Lisp_Cons): Use INTERNAL_FIELD.
2492 Remove obsolete comment.
2493 (MVAR): New macro.
2494 (struct Lisp_Overlay): Use INTERNAL_FIELD.
2495 * alloc.c, buffer.c, buffer.h, fns.c: Adjust users.
2496
8271d590
DA
24972012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2498
2499 Use INTERNAL_FIELD for symbols.
2500 * lisp.h (SVAR): New macro. Adjust users.
2501 * alloc.c, bytecode.c, cmds.c, data.c, doc.c, eval.c:
2502 * fns.c, keyboard.c, lread.c, xterm.c: Users changed.
2503
3193acd2
DA
25042012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2505
2506 Use INTERNAL_FIELD for processes.
2507 * process.h (PVAR): New macro. Adjust style.
2508 (struct Lisp_Process): Change Lisp_Object members to INTERNAL_FIELD.
2509 * print.c, process.c, sysdep.c, w32.c, xdisp.c: Users changed.
2510
3a45383a
DA
25112012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2512
2513 Use INTERNAL_FIELD for windows.
2514 * window.h (WVAR): New macro.
2515 (struct window): Change Lisp_Object members to INTERNAL_FIELD.
2516 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
2517 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
2518 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, nsterm.m, print.c:
2519 * textprop.c, w32fns.c, w32menu.c, w32term.c, window.c, xdisp.c:
2520 * xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
2521
c1dbc63c
PE
25222012-08-01 Paul Eggert <eggert@cs.ucla.edu>
2523
2524 * coding.h (CODING_ATTR_FLUSHING): Remove; unused and wouldn't work.
2525
5c0c0e8a
GM
25262012-08-01 Glenn Morris <rgm@gnu.org>
2527
2528 * lisp.h (IS_DIRECTORY_SEP, IS_DEVICE_SEP, IS_ANY_SEP):
2529 Move to configure.ac.
2530
552a99b4
JB
25312012-08-01 Juanma Barranquero <lekktu@gmail.com>
2532
2533 * makefile.w32-in (CONFIG_H): Update dependencies.
2534 (CONF_POST_H): New macro.
2535
2536 * s/ms-w32.h (SEPCHAR, NULL_DEVICE): Remove; moved to nt/config.nt.
2537
8d8e2dfe
GM
25382012-07-31 Glenn Morris <rgm@gnu.org>
2539
bc96620a
GM
2540 * Makefile.in (S_FILE): No longer set by configure.
2541
476b1b2d
GM
2542 * conf_post.h (config_opsysfile): Move earlier, so that WINDOWSNT
2543 is available.
2544 (alloca.h) [WINDOWSNT]: Don't include it on MS Windows.
2545
b2c7a106
GM
2546 * process.h (NULL_DEVICE):
2547 * emacs.c (SEPCHAR):
2548 * editfns.c (USER_FULL_NAME): Let configure set them.
2549
d53d062a
GM
2550 * s/README, s/template.h: Remove files.
2551
4515017f
GM
2552 * conf_post.h [HPUX]: Undefine HAVE_RANDOM and HAVE_RINT.
2553
8d8e2dfe
GM
2554 * conf_post.h (AMPERSAND_FULL_NAME, subprocesses):
2555 Move to configure.ac.
2556
5b20b3cc
EZ
25572012-07-31 Eli Zaretskii <eliz@gnu.org>
2558
1e0afd9a
EZ
2559 * .gdbinit (xframe): Adapt to introduction of FVAR and the
2560 resulting renaming of 'struct frame' members.
2561
5b20b3cc
EZ
2562 * w32menu.c (w32_menu_show): Revert bogus introduction of FVAR.
2563
2564 * fontset.c (dump_fontset): Fix compilation with ENABLE_CHECKING
2565 after introduction of FVAR.
2566
f1310128
JD
25672012-07-31 Jan Djärv <jan.h.d@swipnet.se>
2568
79e721e0
JD
2569 * nsmenu.m (update_frame_tool_bar): Change key from NSObject* to id.
2570
2571 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Use drawInRect
2572 instead of compositeToPoint.
2573 (applicationShouldTerminate): Pass NS String literal to NSRunAlertPanel.
2574
8d7c7eed 2575 * nsfns.m, nsmenu.m, nsterm.m: Adopt to struct frame/FVAR changes.
f1310128 2576
e34f7f79
DA
25772012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
2578
2579 Generalize INTERNAL_FIELD between buffers, keyboards and frames.
2580 * lisp.h (INTERNAL_FIELD): New macro.
14ae4239 2581 * buffer.h (BUFFER_INTERNAL_FIELD): Remove.
e34f7f79
DA
2582 (BVAR): Change to use INTERNAL_FIELD.
2583 * keyboard.h (KBOARD_INTERNAL_FIELD): Likewise.
2584 (KVAR): Change to use INTERNAL_FIELD.
2585 * frame.h (FVAR): New macro.
2586 (struct frame): Use INTERNAL_FIELD for all Lisp_Object fields.
3a45383a
DA
2587 * alloc.c, buffer.c, data.c, dispnew.c, dosfns.c, eval.c, frame.c:
2588 * fringe.c, gtkutil.c, minibuf.c, nsfns.m, nsterm.m, print.c:
2589 * term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
e34f7f79
DA
2590 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
2591
c09bfb2f
DA
25922012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
2593
2594 Miscellaneous fixes for non-default X toolkits.
2595 * xfns.c (Fx_file_dialog): Change to SSDATA to avoid warnings.
2596 * xterm.c (x_frame_of_widget): Remove redundant prototype.
2597 Move under #ifdef USE_LUCID.
2598 (x_create_toolkit_scroll_bar): Adjust scroll_bar_name
2599 definition and usage to avoid warnings.
2600
14c114ae
JD
26012012-07-31 Jan Djärv <jan.h.d@swipnet.se>
2602
2603 * nsterm.m (openFiles): Fix previous checkin.
2604
3bd21e82
PE
26052012-07-31 Paul Eggert <eggert@cs.ucla.edu>
2606
2607 * indent.c (compute_motion): Remove unused local.
2608
c1529ded
GM
26092012-07-31 Glenn Morris <rgm@gnu.org>
2610
400d5621
GM
2611 * s/usg5-4-common.h (wait3, WRETCODE): Let configure set them.
2612
268e2432
GM
2613 * conf_post.h [USG5_4]:
2614 Move remaining contents of s/usg5-4-common.h here.
2615 * s/usg5-4-common.h: Remove file.
2616
7552f3ee
GM
2617 * conf_post.h [IRIX6_5]: Move remaining contents of s/irix6-5.h here.
2618 * s/irix6-5.h: Remove file.
2619
6a381852
GM
2620 * conf_post.h [DARWIN_OS]: Move remaining contents of s/darwin.h here.
2621 * s/darwin.h: Remove file.
2622
c1529ded
GM
2623 * conf_post.h [HPUX]: Move random, srandom here from s/hpux10-20.h.
2624 * s/hpux10-20.h: Remove file, which is now empty.
2625
b429a4ee
GM
26262012-07-30 Glenn Morris <rgm@gnu.org>
2627
2628 * conf_post.h: New, split from configure.ac's AH_BOTTOM.
2629 * Makefile.in (config_h): Add conf_post.h.
2630 * makefile.w32-in (CONFIG_H): Add conf_post.h.
2631
adff3182
JD
26322012-07-30 Jan Djärv <jan.h.d@swipnet.se>
2633
2634 * nsterm.m (ns_do_open_file): New variable.
b9031d69 2635 (ns_term_init): Set ns_do_open_file to YES after run returns.
14ae4239
BT
2636 (openFile, openTempFile, openFileWithoutUI, openFiles):
2637 Open files only if ns_do_open_file.
adff3182 2638
c32af1e4
PE
26392012-07-30 Paul Eggert <eggert@cs.ucla.edu>
2640
7393bcbb
PE
2641 * lisp.h (SWITCH_ENUM_CAST): Remove. All uses removed.
2642 This no-op macro hasn't been needed for many years.
2643 * src/regex.c (SWITCH_ENUM_CAST) [!emacs]: Likewise.
2644
c32af1e4
PE
2645 Export DIRECTORY_SEP, TYPEMASK, VALMASK to GDB.
2646 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]: Add lsb_bits.
2647 * lisp.h (enum lsb_bits) [USE_LSB_TAG]: New enum, for
2648 gdb_make_enums_visible.
2649 (TYPEMASK, VALMASK) [USE_LSB_TAGS]: Now enum constants, not macros.
2650 (DIRECTORY_SEP): Now a constant, not a macro.
2651
302fc036
EZ
26522012-07-30 Eli Zaretskii <eliz@gnu.org>
2653
2654 * w32fns.c (w32_wnd_proc): Pass w32_keyboard_codepage to
2655 w32_kbd_patch_key as the 2nd arg. (Bug#12082)
2656
2657 * w32term.c <w32_keyboard_codepage>: Renamed from
2658 keyboard_codepage and now external. All users changed.
2659
2660 * w32term.h: Add declaration of w32_keyboard_codepage.
2661
2662 * w32inevt.c (w32_kbd_patch_key): Accept an additional argument --
2663 the codepage to translate keys to Unicode. If this argument is
2664 -1, use the value returned by GetConsoleCP. All callers changed.
2665
88fb40b4
PE
26662012-07-30 Paul Eggert <eggert@cs.ucla.edu>
2667
0aee6912
PE
2668 Update .PHONY listings in makefiles.
2669 * Makefile.in (.PHONY): Add all, mostlyclean, clean,
2670 bootstrap-clean, distclean, maintainer-clean, versioclean,
2671 extraclean, frc.
2672
88fb40b4
PE
2673 * lisp.h (STRING_BYTES_BOUND): Cast entire result to ptrdiff_t.
2674 This is a bit clearer. Fix some commentary typos.
2675
0a763bd1
GM
26762012-07-30 Glenn Morris <rgm@gnu.org>
2677
32bac6d6
GM
2678 * s/netbsd.h: Let configure include signal.h if needed.
2679 Remove file, which is now empty.
2680
b65e7c46
GM
2681 * s/usg5-4-common.h (_longjmp, _setjmp, TIOCSIGSEND):
2682 Let configure set them.
2683 * s/irix6-5.h (_longjmp, _setjmp, TIOCSIGSEND):
2684 No more need to undefine.
0a763bd1 2685
169304bd
AS
26862012-07-30 Andreas Schwab <schwab@linux-m68k.org>
2687
2688 * keymap.c (Fkey_description): Don't remove 0x80 bit from
2689 non-single-byte char when adding meta modifier. (Bug#12090)
2690
6cd7a139
DA
26912012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
2692
2693 Convert safe_call to use variable number of arguments.
2694 * xdisp.c (safe_call): Convert to use varargs. Adjust users.
2695 (safe_call2): Fix comment.
2696 * lisp.h (safe_call): Adjust prototype.
2697 * coding.c (encode_coding_object): Change to use safe_call2.
2698 * xfaces.c (merge_face_heights): Change to use safe_call1.
2699
d34d6ffc
GM
27002012-07-30 Glenn Morris <rgm@gnu.org>
2701
7b8a48e4 2702 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
227f5bd0 2703 does that unconditionally. Remove file, which is now empty.
7b8a48e4 2704
d34d6ffc
GM
2705 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
2706 Remove empty files.
2707
03a660a6
PE
27082012-07-30 Paul Eggert <eggert@cs.ucla.edu>
2709
2710 Export to GDB most of lisp.h's remaining object-like macros.
2711 * lisp.h (min, max): Move earlier, because they're used earlier now.
2712 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
2713 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
2714 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
2715 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
2716 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
2717 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
2718 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
2719 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
2720 Now constants, for GDB. They need not be macros.
2721 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
2722 Now constants, for GDB, as well as macros, for static initializers.
2723 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
2724 Move to after the definition of struct Lisp_Char_Table,
2725 since the former now needs that type defined.
2726 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
2727 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
2728 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
2729 New enums, for gdb_make_enums_visible.
2730 (GLYPH_MODE_LINE_FACE): Remove; unused.
88fb40b4 2731 * alloc.c (STRING_BYTES_MAX): Now a constant, not a macro.
03a660a6
PE
2732 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
2733 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
2734 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
2735 enum maxargs, enum MAX_ALLOCA.
2736 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
2737 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
2738 no longer needed, now that they are done in lisp.h.
2739
e499d0ee
DA
27402012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
2741
2742 Cleanup string bytes checking.
2743 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
2744 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
2745 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
2746 (check_sblock, compact_small_strings): Simplify.
2747
d5040d2d
PE
27482012-07-29 Paul Eggert <eggert@cs.ucla.edu>
2749
2750 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
2751 These macros are confusing and no longer need to be defined, as
2752 the enum values now suffice. All uses replaced with definiens.
2753 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
2754
7f259ae6
JB
27552012-07-29 Juanma Barranquero <lekktu@gmail.com>
2756
2757 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
2758 ($(BLD)/w32console.$(O)): Update dependencies.
2759
7e63e0c3
DA
27602012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
2761
2762 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
2763 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
2764 time. Adjust users.
2765 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
2766
ffd817eb
JD
27672012-07-29 Jan Djärv <jan.h.d@swipnet.se>
2768
2769 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
2770 setting sitelisp (Bug#12010).
2771
417a7a0e
EZ
27722012-07-29 Eli Zaretskii <eliz@gnu.org>
2773
14ae4239 2774 * w32heap.h (OS_9X): Rename from OS_WINDOWS_95.
417a7a0e
EZ
2775
2776 * w32heap.c (cache_system_info):
2777 * w32.c (sys_rename):
2778 * w32proc.c (find_child_console, sys_kill): All users changed.
2779
387d4d92
PE
27802012-07-29 Paul Eggert <eggert@cs.ucla.edu>
2781
2782 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
2783
55a6cca6
EZ
27842012-07-29 Eli Zaretskii <eliz@gnu.org>
2785
2786 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
2787
dbcf001c
DA
27882012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
2789
2790 Cleanup statistics calculation in Fgarbage_collect.
14ae4239
BT
2791 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start.
2792 Fix zombies percentage calculation. Simplify elapsed time calculation.
dbcf001c 2793
e2688e4a
DA
27942012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
2795
2796 Generalize marker debugging code under MARKER_DEBUG and use eassert.
2797 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
2798 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
2799 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
2800 (replace_range, replace_range_2, del_range_2): Change to eassert.
2801 * marker.c (byte_char_debug_check): Adjust style.
2802
b46a6a83
PE
28032012-07-29 Paul Eggert <eggert@cs.ucla.edu>
2804
2805 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
2806 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
2807 long-ago-commented-out code that talks about "WIN32".
2808 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
2809 All uses changed.
2810
e32a5799
PE
28112012-07-28 Paul Eggert <eggert@cs.ucla.edu>
2812
2813 Use Gnulib stdalign module (Bug#9772, Bug#9960).
2814 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
2815 Simplify by using alignof.
2816 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
2817 * lisp.h: Include <stdalign.h>.
2818 (GCALIGNMENT): New macro and constant.
2819 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
2820 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
2821 (stdalign): New macro, if not already defined.
2822
df81cd29
EZ
28232012-07-28 Eli Zaretskii <eliz@gnu.org>
2824
01bd1b0d
EZ
2825 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
2826 * w32inevt.c: Include w32inevt.h.
2827 (w32_read_console_input): New inline function, calls either
2828 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
2829 w32_console_unicode_input.
2830 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
2831 (w32_kbd_patch_key, key_event): Use the codepage returned by
2832 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
2833 (key_event): use uChar.UnicodeChar only if
2834 w32_console_unicode_input is non-zero.
2835
2836 * w32console.c: Include w32heap.h.
2837 <w32_console_unicode_input>: New global variable.
2838 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
2839 family of Windows, zero otherwise.
2840
2841 * w32inevt.h: Declare w32_console_unicode_input.
2842
df81cd29
EZ
2843 * xdisp.c (init_iterator): Don't reference tip_frame in a build
2844 --without-x. (Bug#11742)
2845
c20fdd9e
PE
28462012-07-27 Paul Eggert <eggert@cs.ucla.edu>
2847
2848 Adjust GDB to reflect pvec_type changes (Bug#12036).
2849 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
14ae4239
BT
2850 2012-07-04 changes to pseudovector representation.
2851 Problem reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
c20fdd9e 2852
32770973 28532012-07-27 Michael Albinus <michael.albinus@gmx.de>
e518bc71
MA
2854
2855 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
2856 bus address.
2857 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
2858
3438fe21
EZ
28592012-07-27 Eli Zaretskii <eliz@gnu.org>
2860
bcfbc9de
EZ
2861 * alloc.c (listn): Fix the order the arguments are consed onto the
2862 list.
2863
3438fe21
EZ
2864 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
2865 enumeration constants, as PURE and HEAP are too general, and clash
2866 with other headers and sources, such as gmalloc.c and the
2867 MS-Windows system headers. All users changed.
2868
eeaea515
DA
28692012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
2870
2871 Revert last save_excursion_save and save_excursion_restore changes.
2872 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
2873 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
2874
073c88c2
DA
28752012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
2876
2877 Fix recently-introduced typos in Windows port.
2878 Reported by Martin Rudalics <rudalics@gmx.at>.
2879 * w32.c (init_environment): Replace comma with semicolon.
eeaea515 2880 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
073c88c2 2881
4706125e
PE
28822012-07-27 Paul Eggert <eggert@cs.ucla.edu>
2883
2884 Improve GDB symbol export (Bug#12036).
2885 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
2886 arms of an 'if', not using conditional expressions; otherwise GDB
2887 complains about the types in the unevaluated arm when the argument
2888 is an integer literal.
2889 (xgetint): Simplify expression.
2890 * alloc.c (gdb_make_enums_visible): New constant. This ports to
2891 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
2892 Zaretskii in <http://bugs.gnu.org/12036#13>.
2893 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
2894 needed now that we have gdb_make_enums_visible.
2895 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
2896 (enum enum_USE_LSB_TAG):
2897 New enum types, packaging up enums that need to be exported to GDB.
2898
694b6c97
DA
28992012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
2900
2901 Utility function to make a list from specified amount of objects.
2902 * lisp.h (enum constype): New datatype.
2903 (listn): New prototype.
2904 * alloc.c (listn): New function.
2905 (Fmemory_use_count, syms_of_alloc): Use it.
2906 * buffer.c (syms_of_buffer): Likewise.
2907 * callint.c (syms_of_callint): Likewise.
2908 * charset.c (define_charset_internal): Likewise.
2909 * coding.c (syms_of_coding): Likewise.
2910 * keymap.c (syms_of_keymap): Likewise.
2911 * search.c (syms_of_search): Likewise.
2912 * syntax.c (syms_of_syntax): Likewise.
2913 * w32.c (init_environment): Likewise.
2914 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
2915 * xdisp.c (syms_of_xdisp): Likewise.
2916 * xfns.c (syms_of_xfns): Likewise.
2917
6195f384
DA
29182012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
2919
2920 Fast save_excursion_save and save_excursion_restore.
2921 * lisp.h (struct Lisp_Excursion): New data type.
2922 (PVEC_EXCURSION): New pseudovector type.
2923 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
2924 to deal with it. Adjust comments.
2925 (init_marker, attach_marker): New prototype.
2926 (unchain_marker): Adjust prototype.
2927 * marker.c (attach_marker): Change to global.
2928 (init_marker): New function.
2929 * alloc.c (Fmake_marker, build_marker): Use it.
2930 (build_marker): More easserts.
2931 (mark_object): Handle struct Lisp_Excursion.
2932 * editfns.c (save_excursion_save, save_excursion_restore):
2933 Reimplement to use struct Lisp_Excursion. Add comments.
2934
5eceb8fb
PE
29352012-07-26 Paul Eggert <eggert@cs.ucla.edu>
2936
2937 Fix export of symbols to GDB (Bug#12036).
2938 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
2939 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
2940 emacs.c, as this is a more-suitable home. Had this been done earlier
2941 the fix for 12036 would have avoided some of the problems noted in
2942 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
2943 would have been more obvious.
562157c8
PE
2944 * emacs.c: Do not include <verify.h>; no longer needed.
2945 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
5eceb8fb
PE
2946 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
2947 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
2948 Remove; now done in lisp.h.
2949 * lisp.h (PUBLISH_TO_GDB): New macro.
2950 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
2951 (DATA_SEG_BITS): Use it.
2952 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
2953 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
2954 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
2955 not be usable in #if. This simplifies things.
2956
d6749401
JB
29572012-07-26 Juanma Barranquero <lekktu@gmail.com>
2958
2959 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
2960
1781b9e9
PE
29612012-07-26 Paul Eggert <eggert@cs.ucla.edu>
2962
d89518db 2963 Simplify export of symbols to GDB (Bug#12036).
1781b9e9
PE
2964 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
2965 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
2966 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
2967 Adjust to changes in lisp.h and emacs.c, by using
2968 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
2969 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
2970 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
2971 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
2972 instead of gdb_valbits.
2973 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
2974 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
2975 instead of gdb_array_mark_flag.
2976 (xboolvector): Get size from $->size, not $->header.size.
2977 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
2978 (xreload, hook-run, hookpost-run): Remove.
2979 * emacs.c: Include <verify.h>.
2980 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
2981 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
2982 Remove.
2983 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
2984 (gdb_USE_LSB_TAG): New enum constants.
2985 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
2986 Also define these as enum constants, so they're visible to GDB.
2987 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
2988 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
2989 as constants, so they're visible to GDB.
2990 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
2991 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
2992 Now enum constants, not macros, so they're visible to GDB.
2993 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
2994 more convenient now. All uses changed.
2995 (VALMASK) [USE_LSB_TAG]: Also define in this case.
2996 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
2997
3628596a
DA
29982012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
2999
3000 Explicitly free restriction data that are not needed anymore.
3001 * editfns.c (save_restriction_restore): Free restriction data.
3002
7abaf5cc
SM
30032012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
3004
3005 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
3006 add argument, tune behavior, and adjust all callers.
3007
71f88e00
PE
30082012-07-25 Paul Eggert <eggert@cs.ucla.edu>
3009
3010 Use typedef for EMACS_INT, EMACS_UINT.
3011 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
3012 than macros. This simplifies debugging in the usual case, since
3013 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
3014 and it allows expressions involving EMACS_INT casts.
3015 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
3016
57ec3034
JD
30172012-07-25 Jan Djärv <jan.h.d@swipnet.se>
3018
3019 * nsterm.m (ns_read_socket): Return early if there is a modal
3020 window (Bug#12043).
3021
8137e7b3
MR
30222012-07-25 Martin Rudalics <rudalics@gmx.at>
3023
3024 * frame.c (Fredirect_frame_focus): In doc-string don't mention
3025 that FOCUS-FRAME can be omitted.
3026
04e9897c
DA
30272012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
3028
3029 Adjust buffer text indirection counters at the end of Fkill_buffer.
3030 * buffer.c (Fkill_buffer): Adjust indirection counters when the
3031 buffer is definitely dead. This should really fix an issue reported
3032 by Christoph Scholtes again. (Bug#12007).
3033 (init_buffer_once): Initialize indirection counters of
3034 buffer_defaults and buffer_local_symbols (for sanity and safety).
3035
8a0484e1
EZ
30362012-07-24 Eli Zaretskii <eliz@gnu.org>
3037
3038 * xdisp.c (init_iterator): Don't compute dimensions of truncation
3039 and continuation glyphs on tooltip frames, leave them at zero.
3040 Avoids continued lines in tooltips. (Bug#11832)
3041
fa691a83
DA
30422012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
3043
3044 Simplify copy_overlay.
04e9897c 3045 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
3046 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
3047
436bc8e0
EZ
30482012-07-23 Eli Zaretskii <eliz@gnu.org>
3049
3050 * print.c (print_object): Don't crash when a frame's name is nil
3051 or invalid. (Bug#12025)
3052
3053 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
3054 it signals an error when a tooltip frame is being created.
3055
d7a7fda3
DA
30562012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
3057
3058 Cleanup miscellaneous objects allocation and initialization.
3059 * alloc.c (allocate_misc): Change to static. Add argument to
3060 specify the subtype. Adjust comment and users.
3061 (build_overlay): New function.
3062 * buffer.c (copy_overlays, Fmake_overlay): Use it.
3063 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
3064 (allocate_misc): Remove prototype.
3065 (build_overlay): Add prototype.
3066
30672012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
3068
3069 Swap buffer text indirection counters in Fbuffer_swap_text.
3070 * buffer.c (Fbuffer_swap_text): Swap indirections too.
3071 This avoids crash reported by Christoph Scholtes at
3072 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
3073
9d7fa573
JD
30742012-07-22 Jan Djärv <jan.h.d@swipnet.se>
3075
3076 * nsmenu.m (Popdown_data): New struct.
3077 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
3078 free Popdown_data.
3079 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
3080 (initWithContentRect): Make imgView and contentView non-static
3081 and autorelease them. Also autorelease img and matrix (Bug#12005).
3082 (dealloc): Remove (Bug#12005).
3083
0dd6d66d
DA
30842012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
3085
3086 Adjust consing_since_gc when objects are explicitly freed.
3087 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
3088 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
3089 (free_cons, free_misc): Subtract object size from consing_since_gc.
3090
d36d71df
DA
30912012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
3092
3093 Simplify and cleanup markers positioning code.
3094 * marker.c (attach_marker): More useful eassert.
3095 (live_buffer, set_marker_internal): New function.
3096 (Fset_marker, set_marker_restricted): Use set_marker_internal.
3097 (set_marker_both, set_marker_restricted_both): Use live_buffer.
3098
fb9ea40f
PE
30992012-07-22 Paul Eggert <eggert@cs.ucla.edu>
3100
3101 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
3102 as it's limited by the amount of memory, not by INT_MAX.
3103
2d5c5f7d
EZ
31042012-07-21 Eli Zaretskii <eliz@gnu.org>
3105
07fb592e
EZ
3106 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
3107 in special-event-map. See the discussion at
3108 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
3109 for the reasons.
3110
37a9eac8 3111 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
14ae4239
BT
3112 info.dwItemData. Fixes crashes on 64-bit Windows.
3113 Suggested by Fabrice Popineau <fabrice.popineau@supelec.fr>.
2d5c5f7d 3114
c4328746
JD
31152012-07-21 Jan Djärv <jan.h.d@swipnet.se>
3116
fc0c31f8 3117 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 3118 (conversationIdentifier): Return value is NSInteger.
784051c4 3119 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 3120
6e5d1c12
CY
31212012-07-21 Chong Yidong <cyd@gnu.org>
3122
3123 * window.c (decode_any_window): Signal an error if the window is
3124 on a dead frame (Bug#11984).
3125
9928463d
DA
31262012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
3127
3128 Add indirection counting to speed up Fkill_buffer.
3129 * buffer.h (struct buffer): New member.
3130 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
3131 (Fmake_indirect_buffer): Set indirection counter to -1, increment
3132 base buffer indirection counter.
3133 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
3134 (Fkill_buffer): Adjust indirection counters as needed, don't walk
3135 through buffer list if indirection counter is 0.
3136
f8643a6b
DA
31372012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
3138
3139 Extend the value returned by Fgarbage_collect with heap statistics.
3140 * alloc.c (Qheap): New symbol.
3141 (syms_of_alloc): DEFSYM it.
3142 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
3143 (Fmemory_free): Remove.
3144 (syms_of_alloc): Don't defsubr it.
3145 * buffer.c (Fcompact_buffer): Remove.
3146 (syms_of_buffer): Don't defsubr it.
3147
dac616ff
DA
31482012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
3149
3150 Make maybe_gc inline.
3151 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
3152 * lisp.h (consing_since_gc, gc_relative_threshold)
3153 (memory_full_cons_threshold): Revert declaration.
3154 (maybe_gc): Remove prototype, define as inline.
3155 * alloc.c: Remove old commented-out code.
3156 (consing_since_gc, gc_relative_threshold)
3157 (memory_full_cons_threshold): Revert to global.
3158 (maybe_gc): Remove.
3159
d7ea76b4
DA
31602012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
3161
3162 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
3163 * lisp.h (build_unibyte_string): New function.
3164 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
3165 * sysdep.c, w32fns.c, xfns.c: Use it.
3166 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
3167 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
3168 Adjust users accordingly.
3169 * font.h (font_open_by_name): Adjust prototype.
3170
765e61e3
DA
31712012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
3172
3173 Cleanup calls to Fgarbage_collect.
3174 * lisp.h (maybe_gc): New prototype.
3175 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
3176 Remove declarations.
3177 * alloc.c (maybe_gc): New function.
3178 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
3179 Make them static.
3180 * bytecode.c (MAYBE_GC): Use maybe_gc.
3181 * eval.c (eval_sub, Ffuncall): Likewise.
3182 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
3183 to avoid dependency from auto-save feature.
3184
52b852c7
PE
31852012-07-19 Paul Eggert <eggert@cs.ucla.edu>
3186
3187 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
3188 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
3189 'for_each_per_buffer_object_at'.
3190 All uses changed. It's better to use upper-case for macros that
3191 cannot be implemented as functions, to give the reader a clue
3192 that they're special.
3193
5db81e33
SM
31942012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
3195
3196 * alloc.c (Fgarbage_collect): Tweak docstring.
3197
5b835e1d
DA
31982012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
3199
3200 Tweak the value returned from Fgarbage_collect again.
3201 * alloc.c (Fgarbage_collect): New return value, as confirmed in
3202 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
3203 Adjust documentation.
3204 (total_vector_bytes): Rename to total_vector_slots, adjust
3205 accounting.
3206 (total_free_vector_bytes): Rename to total_free_vector_slots,
3207 adjust accounting.
3208 (Qstring_bytes, Qvector_slots): New symbols.
3209 (syms_of_alloc): DEFSYM them.
3210
9cd47b72
DA
32112012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
3212
3213 Buffer compaction primitive which may be used from Lisp.
3214 * buffer.c (compact_buffer, Fcompact_buffer): New function.
3215 (syms_of_buffer): Register Fcompact_buffer.
3216 * alloc.c (Fgarbage_collect): Use compact_buffer.
3217 * buffer.h (compact_buffer): New prototype.
3218 (struct buffer_text): New member.
3219
d17337e5
DA
32202012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
3221
3222 New macro to iterate over all buffers, miscellaneous cleanups.
3223 * lisp.h (all_buffers): Remove declaration.
3224 * buffer.h (all_buffers): Add declaration, with comment.
3225 (for_each_buffer): New macro.
3226 * alloc.c (Fgarbage_collect, mark_object): Use it.
3227 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
3228 (init_buffer): Likewise.
3229 * data.c (Fset_default): Likewise.
3230 * coding.c (code_conversion_restore): Remove redundant check
3231 for dead buffer.
3232 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
3233
60cfd278
AS
32342012-07-18 Andreas Schwab <schwab@linux-m68k.org>
3235
3236 Fix bug that created negative-length intervals.
3237 * intervals.c (merge_interval_right, merge_interval_left):
3238 Do not zero out this interval if it is absorbed by its children,
3239 as this interval's total length doesn't change in that case. See
3240 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
3241
d06714cb
PE
32422012-07-18 Paul Eggert <eggert@cs.ucla.edu>
3243
83713154
PE
3244 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
3245 when invoking (make-bool-vector N t) and N is a positive
3246 multiple of 8 -- the last 8 bits were mistakenly cleared.
3247
d06714cb
PE
3248 Remove some struct layout assumptions in bool vectors.
3249 * alloc.c (bool_header_size): New constant.
3250 (header_size, word_size): Move earlier, as they're now used earlier.
3251 Use 'word_size' in a few more places, where it's appropriate.
3252 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
3253 padding before the data member of a bool vector.
3254 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
3255 than doing the check by hand with an abort ().
3256
464d5a5e
SM
32572012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3258
5fbc0409
SM
3259 * eval.c (Fdefvar): Don't check constants since we only set the var if
3260 it's not yet defined anyway (bug#11904).
3261
464d5a5e
SM
3262 * lisp.h (last_undo_boundary): Declare new var.
3263 * keyboard.c (command_loop_1): Set it.
3264 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
3265 were auto-added by the command loop (bug#11774).
3266
8dc2e44a
AS
32672012-07-18 Andreas Schwab <schwab@linux-m68k.org>
3268
3269 * w32font.c (Qsymbol): Remove local definition.
3270 (syms_of_w32font): Don't DEFSYM it.
3271
169925ec
DA
32722012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
3273
3274 Fix sweep_vectors to handle large bool vectors correctly.
3275 * alloc.c (sweep_vectors): Account total_vector_bytes for
3276 bool vectors larger than VBLOCK_BYTES_MAX.
3277
5fbfb018
CY
32782012-07-18 Chong Yidong <cyd@gnu.org>
3279
3280 * frame.c (x_set_frame_parameters): Revert bogus change introduced
3281 in 2012-05-25 commit by Paul Eggert (Bug#11738).
3282
3ab6e069
DA
32832012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
3284
3285 Return more descriptive data from Fgarbage_collect.
3286 Suggested by Stefan Monnier in
3287 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
3288 * alloc.c (bounded_number): New function.
3289 (total_buffers, total_vectors): New variable.
3290 (total_string_size): Rename to total_string_bytes, adjust users.
3291 (total_vector_size): Rename to total_vector_bytes, adjust users.
3292 (sweep_vectors): Account total_vectors and total_vector_bytes.
3293 (Fgarbage_collect): New return value. Adjust documentation.
3294 (gc_sweep): Account total_buffers.
3295 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
3296 (VECTOR_SIZE): Remove.
3297 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
3298 (Qinterval, Qmisc): New symbols.
3299 (syms_of_data): Initialize them.
3300 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
3301 (Qcons, Qbuffer): New declarations.
3302
6d02fe5b
PE
33032012-07-17 Paul Eggert <eggert@cs.ucla.edu>
3304
3305 * alloc.c (Fmemory_free): Account for memory-free's own storage.
3306 Round up, not down. Improve doc.
3307
b7ffe040
DA
33082012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
3309
3310 Restore old code in allocate_string_data to avoid Faset breakage.
3311 Reported by Julien Danjou <julien@danjou.info> in
3312 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
3313 * alloc.c (allocate_string_data): Restore old code with minor
3314 adjustments, fix comment to explain this subtle issue.
3315
4dc7c8d5
SM
33162012-07-17 Eli Zaretskii <eliz@gnu.org>
3317
3318 Remove FILE_SYSTEM_CASE.
3319 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
3320
3321 * fileio.c (FILE_SYSTEM_CASE): Don't define.
3322 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
3323 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
3324 call-process-region passes it through expand-file-name.
3325
3326 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
3327
33282012-07-17 Andreas Schwab <schwab@linux-m68k.org>
3329
3330 Fix crash when creating indirect buffer (Bug#11917)
3331 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
3332 Don't handle unbound variables specially if non-zero.
3333 (Fbuffer_local_variables): Pass zero.
3334 (clone_per_buffer_values): Pass non-zero.
3335
33362012-07-17 Andreas Schwab <schwab@linux-m68k.org>
3337
3338 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
3339 to make the loop interruptible.
3340
33412012-07-17 Andreas Schwab <schwab@linux-m68k.org>
3342
3343 * gnutls.c (emacs_gnutls_handshake): Only retry if
3344 GNUTLS_E_INTERRUPTED.
3345
cce7fefc
DA
33462012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
3347
3348 Cleanup and convert miscellaneous checks to eassert.
3349 * alloc.c (mark_interval): Fix comment, partially rephrase
3350 old comment from intervals.h (see below).
3351 * intervals.c (find_interval, adjust_intervals_for_insertion)
3352 (delete_interval, adjust_intervals_for_deletion)
3353 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
3354 Convert to eassert.
3355 (adjust_intervals_for_insertion, make_new_interval):
3356 Remove obsolete and unused code.
3357 * intervals.h (struct interval): Remove obsolete comment.
3358 * textprotp.c (erase_properties): Remove unused code.
3359 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
3360 (Fremove_list_of_text_properties): Convert to eassert.
3361
9ea10cc3
CY
33622012-07-17 Chong Yidong <cyd@gnu.org>
3363
3364 * editfns.c (Finsert_char): Doc fix.
3365
3900d5de
DA
33662012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
3367
3368 Fix previous change to make Fmemory_free always accurate.
3369 * alloc.c (make_interval): Update total_free_intervals.
3370 (make_float): Likewise for total_free_floats.
3371 (free_cons, Fcons): Likewise for total_free_conses.
3372 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
3373 Likewise for total_free_vector_bytes.
3374 (Fmake_symbol): Likewise for total_free_symbols.
3375 (bytes_free): Remove.
3376
7098646f
DA
33772012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
3378
3379 Simple free memory accounting feature.
3380 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
3381 (sweep_vectors): Accumulate size of free vectors.
3382 (Fgarbage_collect): Setup bytes_free.
3383 (Fmemory_free): New function.
3384 (syms_of_alloc): Register it.
3385
22657b40
DA
33862012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
3387
3388 Cleanup overlays checking.
3389 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
3390 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
3391 eassert and OVERLAYP.
3392 (sort_overlays): Change to use OVERLAYP.
3393
ddfc8813
RK
33942012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
3395
3396 * editfns.c (Finsert_char): Make it interactive, and make the
3397 second arg optional. Copy interactive spec and docstring from
3398 ucs-insert.
3399
7c26cf3c
PE
34002012-07-17 Paul Eggert <eggert@cs.ucla.edu>
3401
3402 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
3403 Unlike the other wrapped functions, fabs has an unspecified
3404 effect on errno.
3405
5d127af9
JD
34062012-07-16 Jan Djärv <jan.h.d@swipnet.se>
3407
3408 * nsterm.m (keyDown): Interpret flags without left/right bits
3409 as the left key (Bug#11670).
3410
6a0dd1d7
DA
34112012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
3412
3413 Remove empty and useless init functions.
3414 * lisp.h (init_character_once, init_fns, init_image)
3415 (init_filelock, init_sound): Remove prototype.
3416 * character.c (init_character_once): Remove.
3417 * filelock.c (init_filelock): Likewise.
3418 * fns.c (init_fns): Likewise.
3419 * image.c (init_image): Likewise.
3420 * sound.c (init_sound): Likewise.
3421 * emacs.c (main): Adjust accordingly.
3422
7a6136fd
DA
34232012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
3424
3425 * gtkutil.h: Tiny cleanups.
3426 (use_old_gtk_file_dialog): Remove useless declaration.
3427 (xg_uses_old_file_dialog): Add suggested const attribute.
3428
ce811ad9
EZ
34292012-07-15 Eli Zaretskii <eliz@gnu.org>
3430
3431 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
3432 (bidi_paragraph_init): Use it to limit search forward for a strong
3433 directional character in abnormally large paragraphs full of
3434 neutral or weak characters. (Bug#11943)
3435
c9adfeaa
SF
34362012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
3437
3438 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
3439 the toolbar (Bug#9451).
3440 (xg_make_tool_item): Give the widget event box a transparent
3441 background.
3442
fff62aa9
DA
34432012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
3444
3445 Cleanup basic allocation variables and functions.
3446 * alloc.c (ignore_warnings, init_intervals, init_float)
3447 (init_cons, init_symbol, init_marker): Remove.
3448 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
3449 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
3450 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
3451 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
3452 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
3453 (staticidx, init_alloc_once, init_strings, free_ablock):
3454 Remove redundant initialization.
3455 * fns.c (init_weak_hash_tables): Remove.
3456 * lisp.h (init_weak_hash_tables): Remove prototype.
3457
9730daca
DA
34582012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
3459
3460 Use zero_vector where appropriate.
3461 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
3462 accordingly.
3463 * lisp.h (zero_vector): New declaration.
3464 * font.c (null_vector): Remove.
3465 (syms_of_font): Remove initialization and staticpro.
3466 (font_list_entities, font_find_for_lface): Change to use zero_vector.
3467 * keymap.c (Faccessible_keymaps): Likewise.
3468
2e2d2a13
LL
34692012-07-15 Leo Liu <sdl.web@gmail.com>
3470
3471 * fringe.c: Fix typo in comments.
3472
cd276f6e
LL
34732012-07-14 Leo Liu <sdl.web@gmail.com>
3474
3475 * fringe.c: Add a new bitmap exclamation-mark.
3476
5a1131d9
EZ
34772012-07-14 Eli Zaretskii <eliz@gnu.org>
3478
3479 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
3480
3481 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
3482 (HAVE_MENUS): Don't define, defined by editing config.in with
3483 msdos/sed2v2.inp.
3484 (GMALLOC_INHIBIT_VALLOC): Don't define.
3485 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
3486
22e983b7
JB
34872012-07-14 Juanma Barranquero <lekktu@gmail.com>
3488
3489 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
3490
5b3f250f
GM
34912012-07-14 Glenn Morris <rgm@gnu.org>
3492
3493 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
3494 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
3495 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
3496
33d63ff4
GM
34972012-07-13 Glenn Morris <rgm@gnu.org>
3498
5b633342
GM
3499 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
3500
33d63ff4
GM
3501 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
3502 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
3503
b55b9f85
JD
35042012-07-13 Jan Djärv <jan.h.d@swipnet.se>
3505
0dc8cf50
JD
3506 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
3507 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
3508 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
3509 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
3510 where appropriate.
3511 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
3512 as boolean expression.
3513 (x_set_window_size): Remove unused variable toolbar.
3514 (ns_get_color_default, ns_mod_to_lisp): Remove.
3515 (ns_mouse_position): Remove unused variables xchar and ychar.
3516 (ns_compute_glyph_string_overhangs): Remove unused variable face.
3517 (ns_set_vertical_scroll_bar): Remove unused variable count.
3518 (ns_delete_terminal): Remove unused variable i.
3519 (ns_term_init): Remove unused variables r, g and b.
3520 (mouseDown): Remove unused variable window.
3521 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
3522 (initFrameFromEmacs): Remove unused variable vbextra.
3523 (mouseEntered): Remove unused variables p and dpyinfo.
3524 (mouseExited): Remove unused variables p and r.
3525 (ns_define_frame_cursor, ns_clear_frame_area)
3526 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
3527 (menuDown): Assign [sender tag] to variable and cast the variable.
3528
3529 * nsterm.h (menuDown): Add id as type to argument sender.
3530 (ns_display_info_for_name): Add Lisp_Object argument.
3531 (ns_term_init): Add Lisp_Object argument.
3532 (ns_map_event_to_object): Add void argument.
3533 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
3534 prototype with arguments and only declare if __OBJC__.
3535 (nxatoms_of_nsselect): Add void argument.
3536 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
3537 (ns_alloc_autorelease_pool): Add void argument.
3538 (ns_release_autorelease_pool): Add void* argument.
3539 (ns_get_defaults_value): Add const char* argument.
3540
3541 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
3542 (initFromContents): Use SSDATA where appropriate.
3543 (ns_update_menubar): Add braces to ambigous if-else.
3544 (initWithTitle): Put () around assignment in if statement.
3545 (ns_menu_show): Remove unused variables window and keymap.
3546 (update_frame_tool_bar): Remove unused variable selected_p.
3547 (initWithContentRect): Remove unused variable this_cmd_name.
3548
3549 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
3550 appropriate.
3551 (setXBMColor): Remove unused variable len.
3552 (setPixmapData): Put () around assignment in loop statement.
3553
3554 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
3555 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
3556 where appropriate.
3557 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
3558 around assignment in loop statement.
3559 (nsfont_open): Remove unused variable i.
3560 (nsfont_open): Remove unused variable len.
3561 (nsfont_draw): Remove unused variable cs.
3562
3563 * nsfns.m (x_set_icon_name, ns_set_name_internal)
3564 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
3565 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
3566 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
3567 (Fns_font_name, Fns_perform_service)
3568 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
3569 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
3570 (ns_set_name): Remove unused variable view.
3571 (x_set_menu_bar_lines): Remove unused variable olines.
3572 (x_set_tool_bar_lines): Remove unused variable root_window.
3573 (Fns_list_colors): Put () around assignment in while statement.
3574 (Fns_perform_service): Remove unused variable len.
3575 (Fns_display_usable_bounds): Remove unused variable top.
3576 (syms_of_nsfns): Remove unused variable i.
3577
b55b9f85
JD
3578 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
3579 memcpy (Bug#11907).
3580
ed9265fc 35812012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
3582
3583 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
3584 and free it with DestroyExceptionInfo (Bug#11558).
3585
ef099b57
JB
35862012-07-13 Juanma Barranquero <lekktu@gmail.com>
3587
3588 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
3589 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
3590 Set here, not in nt/config.nt.
3591
ea814a5d
EZ
35922012-07-13 Eli Zaretskii <eliz@gnu.org>
3593
3594 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
3595 cursor overflow into the last glyph on display line when the right
3596 fringe is off. (Bug#11832)
3597
1a952767
PE
35982012-07-13 Paul Eggert <eggert@cs.ucla.edu>
3599
3600 * xdisp.c (produce_special_glyphs): Now static.
3601 * dispextern.h (produce_special_glyphs): Remove decl.
3602
983188fd
GM
36032012-07-13 Glenn Morris <rgm@gnu.org>
3604
8d7c7eed 3605 * s/bsd-common.h, s/cygwin.h: Remove empty files.
32fb4bb6
GM
3606 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
3607
983188fd
GM
3608 * s/usg5-4-common.h (USG, USG5):
3609 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
3610 * s/sol2-6.h (SOLARIS2):
3611 * s/irix6-5.h (IRIX6_5):
3612 * s/hpux10-20.h (USG, USG5, HPUX):
3613 * s/gnu-linux.h (USG, GNU_LINUX):
3614 * s/freebsd.h (BSD_SYSTEM):
3615 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
3616 * s/cygwin.h (CYGWIN):
3617 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
3618 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
3619
d1e68667 36202012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
3621
3622 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 3623
6de0e799
GM
36242012-07-13 Glenn Morris <rgm@gnu.org>
3625
739ae010
GM
3626 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
3627
dbee5793
GM
3628 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
3629
6de0e799
GM
3630 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
3631 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
3632
b82da769
GM
36332012-07-12 Glenn Morris <rgm@gnu.org>
3634
4fae5a7a 3635 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
3636
3637 * process.c (init_process_emacs): Rename from init_process.
3638 The old name is also the name of a Mach system call.
3639 * lisp.h, emacs.c: Update for this name change.
3640 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
3641 longer needed.
3642
5a979817
EZ
36432012-07-12 Eli Zaretskii <eliz@gnu.org>
3644
3645 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
3646 memmove call that removes glyphs covered by the left truncation
3647 glyph. Improve commentary.
3648 (display_line): Fix display of continuation glyphs on GUI frames
3649 when the right fringe is turned off and variable-size fonts are
3650 used in the window. Move the code that appends a stretch glyph to
3651 produce_special_glyphs, so that it could be used for truncation
3652 and continuation glyphs alike.
3653 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
3654 glyph of a suitably computed width, to align the special glyphs at
3655 the window margin. Code moved from display_line. (Bug#11832)
3656
3e91a053
GM
36572012-07-12 Glenn Morris <rgm@gnu.org>
3658
ba9e4b84
GM
3659 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
3660
3661 * s/gnu-linux.h, s/hpux10-20.h:
3662 Do not unconditionally define HAVE_XRMSETDATABASE.
3663
3e91a053
GM
3664 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
3665
b300b1f4
PE
36662012-07-12 Paul Eggert <eggert@cs.ucla.edu>
3667
3668 Fix typos that broke OS X build.
3669 Reported by Randal L. Schwartz in
3670 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
3671 * nsterm.m (ns_timeout): Add missing local decl.
3672 (ns_get_color): snprintf -> sprintf, to fix typo.
3673
6e777848
GM
36742012-07-12 Glenn Morris <rgm@gnu.org>
3675
3f922c37
GM
3676 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
3677 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
3678 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
3679 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
3680
0ab7b23a
GM
3681 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
3682 Move PTY_OPEN to configure.
3683
6e777848
GM
3684 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
3685 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
3686 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
3687
4a7edc24
DA
36882012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
3689
3690 Use empty_unibyte_string where applicable.
3691 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
3692 * lread.c (read1): Likewise.
3693 * xsettings.c (syms_of_xsettings): Likewise.
3694
308aab79
GM
36952012-07-12 Glenn Morris <rgm@gnu.org>
3696
42bd1719
GM
3697 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
3698 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
3699 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
3700 * s/hpux10-20.h (RUN_TIME_REMAP):
3701 * s/bsd-common.h (TABDLY): Move to configure.
3702
3703 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
3704
3705 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
3706
ea0bbd17 3707 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 3708 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
3709
3710 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 3711
308aab79
GM
3712 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
3713 * s/template.h: Move NARROWPROTO to configure.
3714
ee1cf5cf
GM
37152012-07-11 Glenn Morris <rgm@gnu.org>
3716
30fe9bf4
GM
3717 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
3718 unused since 2011-01-17 change to systty.h.
3719
ee1cf5cf
GM
3720 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
3721 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
3722 Move HAVE_PTYS and HAVE_SOCKETS to configure.
3723
63e47e07
PE
37242012-07-11 Paul Eggert <eggert@cs.ucla.edu>
3725
3726 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
3727
c43fb4c3
GM
37282012-07-11 Glenn Morris <rgm@gnu.org>
3729
3730 * s/darwin.h, s/gnu-linux.h, s/template.h:
3731 Move INTERRUPT_INPUT to configure.
3732
e8df9267
DA
37332012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
3734
3735 Minor adjustments to interning code.
3736 * lisp.h (intern, intern_c_string): Redefine as static inline
3737 wrappers for intern_1 and intern_c_string_1, respectively.
3738 (intern_1, intern_c_string_1): Rename prototypes.
14ae4239
BT
3739 * lread.c (intern_1, intern_c_string_1, oblookup):
3740 Simplify Vobarray checking.
e8df9267
DA
3741 * font.c (font_intern_prop): Likewise. Adjust comment.
3742 * w32font.c (intern_font_name): Likewise.
3743
34348bd4
AS
37442012-07-11 Andreas Schwab <schwab@linux-m68k.org>
3745
d96a1e0c
AS
3746 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
3747
34348bd4
AS
3748 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
3749 of Fcar/Fcdr if possible.
3750 * font.c (check_otf_features): Likewise.
3751 * fontset.c (Fnew_fontset): Likewise.
3752 * gnutls.c (Fgnutls_boot): Likewise.
3753 * minibuf.c (read_minibuf): Likewise.
3754 * msdos.c (IT_set_frame_parameters): Likewise.
3755 * xmenu.c (Fx_popup_dialog): Likewise.
3756 * w32menu.c (Fx_popup_dialog): Likewise.
3757
c8add24e
GM
37582012-07-11 Glenn Morris <rgm@gnu.org>
3759
4b575b3c
GM
3760 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
3761 since nothing has defined it on these platforms.
3762
09f4e3b0
GM
3763 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
3764 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
3765
172bedef
GM
3766 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
3767 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
3768 Move CLASH_DETECTION to configure.
3769
249685df
GM
3770 * s/gnu.h: Remove file, which is now empty.
3771
c8add24e
GM
3772 * s/gnu.h, s/gnu-linux.h:
3773 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
3774
b41253a3
JW
37752012-07-11 John Wiegley <johnw@newartisans.com>
3776
3777 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
3778 function attribute, so we only use it if it exists in the
3779 compiler.
3780
d923b542
DA
37812012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
3782
3783 Avoid call to strlen in fast_c_string_match_ignore_case.
3784 * search.c (fast_c_string_match_ignore_case): Change to use
3785 length argument. Adjust users accordingly.
3786 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
3787
5ebbef1d
PE
37882012-07-11 Paul Eggert <eggert@cs.ucla.edu>
3789
bb352260
PE
3790 Assume mkdir, rmdir.
3791 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
3792 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
3793
57054ddd
PE
3794 Assume rename.
3795 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
3796
b747d3f7
PE
3797 Assume perror.
3798 * s/hpux10-20.h (HAVE_PERROR): Remove.
3799 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
3800 Remove dummy definition, as this problem was obsolete long ago.
3801
5ebbef1d
PE
3802 Assume strerror.
3803 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
3804
984e7f30
DA
38052012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
3806
3807 Avoid calls to strlen in font processing functions.
3808 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
14ae4239
BT
3809 (font_open_by_name): Change to use length argument.
3810 Adjust users accordingly.
d923b542
DA
3811 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
3812 Adjust prototypes.
3813 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
3814 Change to return ptrdiff_t.
984e7f30
DA
3815 (xfont_list_pattern, xfont_match): Use length returned by
3816 xfont_decode_coding_xlfd.
3817 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
3818
20e94fdd
GM
38192012-07-11 Glenn Morris <rgm@gnu.org>
3820
9d596af3
GM
3821 * s/darwin.h, s/freebsd.h, s/netbsd.h:
3822 Move DONT_REOPEN_PTY to configure.
3823
20e94fdd
GM
3824 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
3825 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
3826
e99a530f
PE
38272012-07-10 Paul Eggert <eggert@cs.ucla.edu>
3828
22ffb973
PE
3829 Remove "#define unix" that is no longer needed (Bug#11905).
3830 * s/aix4-2.h (unix): Remove; no longer needed.
3831
e9a9ae03
PE
3832 EMACS_TIME simplification (Bug#11875).
3833 This replaces macros (which typically do not work in GDB)
3834 with functions, typedefs and enums, making the code easier to debug.
3835 The functional style also makes code easier to read and maintain.
3836 * systime.h: Include <sys/time.h> on all hosts, not just if
3837 WINDOWSNT, since 'struct timeval' is needed in general.
3838 (EMACS_TIME): Now a typedef, not a macro.
3839 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
3840 not macros.
3841 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
3842 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
3843 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
3844 (EMACS_TIME_LE): Now functions, not macros.
3845 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
3846 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
3847 which are not functions. All uses rewritten to use:
3848 (make_emacs_time): New function.
3849 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
3850 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
3851 not functions. All uses rewritten to use the following, respectively:
3852 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
3853 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 3854 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
3855 * fileio.c (Fcopy_file):
3856 * xterm.c (XTflash): Get the current time closer to when it's used.
3857 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
3858
ffacb126
PE
3859 * bytecode.c (targets): Suppress -Woverride-init warnings.
3860
e99a530f
PE
3861 Simplify by avoiding confusing use of strncpy etc.
3862 * doc.c (Fsnarf_documentation):
3863 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
3864 * frame.c (Fmake_terminal_frame):
3865 * gtkutil.c (get_utf8_string):
3866 * lread.c (openp):
3867 * nsmenu.m (ns_update_menubar):
3868 * regex.c (regerror):
3869 Prefer memcpy to strncpy and strncat when either will do.
3870 * fileio.c (Fsubstitute_in_file_name):
3871 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
3872 (menu_separator_name_p):
3873 * nsmenu.m (ns_update_menubar):
3874 Prefer memcmp to strncmp when either will do.
3875 * nsterm.m: Include <ftoastr.h>.
3876 (ns_get_color):
3877 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
3878 Prefer snprintf to strncpy.
3879 * nsterm.m (ns_term_init):
3880 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
3881 * nsterm.m (ns_term_init):
3882 Avoid the need for strncpy, by using build_string or
3883 make_unibyte_string directly. Use dtoastr, not snprintf.
3884 * process.c (Fmake_network_process): Diagnose service names that
3885 are too long, rather than silently truncating them or creating
3886 non-null-terminated names.
3887 (Fnetwork_interface_info): Likewise, for interface names.
3888 * sysdep.c (system_process_attributes) [GNU_LINUX]:
3889 Prefer sprintf to strncat.
3890 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
3891 Prefer vsnprintf to vsprintf + strncpy.
3892
c59592b3
GM
38932012-07-10 Glenn Morris <rgm@gnu.org>
3894
3895 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
3896 Clarify fallback case.
3897
7d7bbefd
DA
38982012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
3899
3900 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
3901 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
3902 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 3903 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
3904 where argument type is known to be a Lisp_Cons.
3905
3a4c8000
TT
39062012-07-10 Tom Tromey <tromey@redhat.com>
3907
3908 * bytecode.c (BYTE_CODE_THREADED): New macro.
3909 (BYTE_CODES): New macro. Replaces all old byte-code defines.
3910 (enum byte_code_op): New type.
3911 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
3912 (exec_byte_code): Use them. Use token threading when applicable.
3913
2a0213a6
DA
39142012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
3915
3916 Optimize pure C strings initialization.
3917 * lisp.h (make_pure_string): Fix prototype.
3918 (build_pure_c_string): New function, defined as static inline. This
3919 provides a better opportunity to optimize away calls to strlen when
3920 the function is called with compile-time constant argument.
3921 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
3922 argument, adjust users accordingly. Use build_pure_c_string where
3923 appropriate.
3924 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
3925 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
3926 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
3927
cb1caeaf
DA
39282012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
3929
3930 Avoid calls to strlen in miscellaneous functions.
3931 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
3932 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
3933 * lread.c (openp): Likewise.
3934
c293e30c
DA
39352012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
3936
3937 Avoid calls to strlen in path processing functions.
3938 * fileio.c (file_name_as_directory): Add comment. Change to add
3939 srclen argument and return the length of result. Adjust users
3940 accordingly.
3941 (directory_file_name): Fix comment. Change to add srclen argument,
14ae4239
BT
3942 swap 1st and 2nd arguments to obey the common convention.
3943 Adjust users accordingly.
c293e30c
DA
3944 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
3945
9e059e3f
GM
39462012-07-10 Glenn Morris <rgm@gnu.org>
3947
d02eb359
GM
3948 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
3949 Move PENDING_OUTPUT_COUNT definition to configure.
3950
882cf227
GM
3951 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
3952 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
3953 * s/gnu.h (DATA_START): Move definitions to configure.
3954
af6e839f
GM
3955 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
3956 We include usg5-4-common.h, which defines them both.
3957
40289a12
GM
3958 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
3959 O_RDONLY already includes it).
3960
9e059e3f
GM
3961 Stop ns builds setting the EMACSLOADPATH environment variable.
3962 * nsterm.m (ns_load_path): Rename from ns_init_paths.
3963 Now it does not set EMACSLOADPATH, just returns the load-path string.
3964 * nsterm.h: Update accordingly.
3965 * lread.c [HAVE_NS]: Include nsterm.h.
3966 (init_lread) [HAVE_NS]: Use ns_load_path.
3967 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
3968
7c4e8ec0
GM
39692012-07-09 Glenn Morris <rgm@gnu.org>
3970
d4f600ff
GM
3971 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
3972 since the included bsd-common.h does so.
3973
cbb31951
GM
3974 Stop ns builds setting the EMACSPATH environment variable.
3975 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
3976 (ns_init_paths): Do not set EMACSPATH.
3977 * nsterm.h (ns_exec_path): Add it.
3978 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
3979 Use ns_exec_path.
3980
7c4e8ec0
GM
3981 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
3982
26bccfae
PE
39832012-07-09 Paul Eggert <eggert@cs.ucla.edu>
3984
a0bee46f
PE
3985 * process.c (wait_reading_process_output): 'waitchannels' was unset
3986 when read_kbd || !NILP (wait_for_cell); fix this.
3987
5994c183
PE
3988 Add GCC-style 'const' attribute to functions that can use it.
3989 * character.h (char_resolve_modifier_mask):
3990 * keyboard.h (make_ctrl_char):
3991 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
3992 (init_character_once, next_almost_prime, init_fns, init_image)
3993 (flush_pending_output, init_sound):
3994 * mem-limits.h (start_of_data):
3995 * menu.h (finish_menu_items):
3996 Add ATTRIBUTE_CONST.
3997 * emacs.c (DEFINE_DUMMY_FUNCTION):
3998 Declare the dummy function with ATTRIBUTE_CONST.
3999 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
4000 Add decls with ATTRIBUTE_CONST.
4001
26bccfae
PE
4002 Minor improvements to make_formatted_string.
4003 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
4004 where int is good enough, as vsprintf returns an int.
4005 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
4006
a8290ec3
DA
40072012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
4008
4009 Use make_formatted_string to avoid double length calculation.
4010 * lisp.h (make_formatted_string): New prototype.
4011 * alloc.c (make_formatted_string): New function.
4012 * buffer.c (Fgenerate_new_buffer_name): Use it.
4013 * dbus.c (syms_of_dbusbind): Likewise.
4014 * editfns.c (Fcurrent_time_zone): Likewise.
4015 * filelock.c (get_boot_time): Likewise.
4016 * frame.c (make_terminal_frame, set_term_frame_name)
4017 (x_report_frame_params): Likewise.
4018 * image.c (gs_load): Likewise.
4019 * minibuf.c (get_minibuffer): Likewise.
4020 * msdos.c (dos_set_window_size): Likewise.
4021 * process.c (make_process): Likewise.
4022 * xdisp.c (ensure_echo_area_buffers): Likewise.
4023 * xsettings.c (apply_xft_settings): Likewise.
4024
d01ba2f1
GM
40252012-07-09 Glenn Morris <rgm@gnu.org>
4026
4027 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
4028 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
4029 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
4030 * nsterm.h (ns_etc_directory): Add it.
4031 * callproc.c [HAVE_NS]: Include nsterm.h.
4032 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
4033
f1f924b6
DA
40342012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
4035
4036 Move marker debugging code under MARKER_DEBUG.
4037 * marker.c (MARKER_DEBUG): Move marker debugging code under
4038 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
4039 for bootstrap with --enable-checking (~3x slowdown reported
4040 by Juanma Barranquero <lekktu@gmail.com>).
4041 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
4042
ab531b66
PE
40432012-07-08 Paul Eggert <eggert@cs.ucla.edu>
4044
4045 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
4046 See <http://bugs.gnu.org/11825#29>.
4047
c4b3bc8a
EZ
40482012-07-08 Eli Zaretskii <eliz@gnu.org>
4049
4050 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
4051 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
4052 (display_line): Add commentary about displaying truncation glyphs
4053 on GUI frames.
4054 (produce_special_glyphs): Move here from term.c.
4055
4056 * term.c (produce_special_glyphs): Move to xdisp.c.
4057
4058 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
4059 section.
c4b3bc8a 4060
b676b881
AS
40612012-07-07 Andreas Schwab <schwab@linux-m68k.org>
4062
f17c5273
AS
4063 * xdisp.c (display_line): Avoid warning about implicit declaration
4064 of FRAME_FONT.
4065
298819b9
AS
4066 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
4067
b676b881
AS
4068 * lisp.h: Remove empty conditional.
4069
6045c4fd
PE
40702012-07-07 Paul Eggert <eggert@cs.ucla.edu>
4071
b3350bf9
PE
4072 * lread.c (load_path_check): Now static.
4073
6045c4fd
PE
4074 Fix some minor --with-ns problems found by static checking.
4075 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
4076 (x_set_font) [!HAVE_X_WINDOWS]:
4077 * image.c (xpm_load_image) [HAVE_NS]:
4078 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
4079 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
4080 Remove unused local.
4081 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
4082 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
4083 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
4084 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
4085 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
4086 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
4087 Fix pointer signedness problem.
4088 * xfaces.c (FRAME_X_FONT_TABLE):
4089 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
4090
929e7845
GM
40912012-07-07 Glenn Morris <rgm@gnu.org>
4092
4093 * lread.c (load_path_check): New function, split from init_lread.
4094 (init_lread): Reorganize. Motivation:
4095 If EMACSLOADPATH is set, check/warn about that rather than the
4096 defaults, which we are not going to use. Hence we can remove
4097 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
4098 Don't warn if site-lisp directories are missing.
4099 If not installed, start from a blank load-path, since
4100 PATH_LOADSEARCH refers to the eventual installation directories.
4101
58dd0aa4
EZ
41022012-07-07 Eli Zaretskii <eliz@gnu.org>
4103
4104 Support truncation and continuation glyphs on GUI frames, when
4105 fringes are disabled. (Bug#11832)
4106 * xdisp.c (init_iterator): Get dimensions of truncation and
14ae4239
BT
4107 continuation glyphs even if on GUI frames.
4108 Adjust it->last_visible_x on GUI frames when the left or right fringes,
58dd0aa4
EZ
4109 or both, are absent.
4110 (start_display, move_it_in_display_line_to): Handle the case of a
4111 GUI frame without a fringe to display continuation or truncation
4112 glyphs.
4113 (insert_left_trunc_glyphs): Support GUI frames: make sure
4114 truncation glyphs overwrite enough glyphs from the current line to
4115 have sufficient space in pixels.
4116 (display_line): Support truncation and continuation glyphs on GUI
4117 frames. If some spare pixels are left on the line after inserting
4118 the truncation glyphs, fill that space with a stretch glyph of a
4119 suitably computed width.
4120
4121 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
4122 produce_glyphs, to support GUI sessions.
4123
31571fd7
PE
41242012-07-07 Paul Eggert <eggert@cs.ucla.edu>
4125
5a16b9bc
PE
4126 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
4127
f3047c75
PE
4128 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
4129
31571fd7
PE
4130 Do not require float-time's arg to fit in time_t (Bug#11825).
4131 This works better on hosts where time_t is unsigned, and where
4132 float-time is applied to the (negative) difference between two times.
4133 * editfns.c (decode_time_components): Last arg is now double *,
4134 not int *, and means to store all the result as a double, without
4135 worrying about whether the seconds part fits in time_t.
4136 All callers changed.
4137 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
4138 All callers changed.
4139 (Ffloat_time): Do not fail merely because the specified time falls
4140 outside of time_t range.
4141
4516fbef
GM
41422012-07-07 Glenn Morris <rgm@gnu.org>
4143
4144 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
4145 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
4146 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
4147
07adc2c6
JB
41482012-07-07 Juanma Barranquero <lekktu@gmail.com>
4149
4150 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
4151 Update dependencies.
4152
4153 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
4154
fd573f31
PE
41552012-07-06 Paul Eggert <eggert@cs.ucla.edu>
4156
fee5959d
PE
4157 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
4158 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
4159 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
4160 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
4161 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
4162 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
4163
fd573f31
PE
4164 * xfont.c (compare_font_names): Redo to omit the need for casts.
4165
ddadbc0e
AS
41662012-07-06 Andreas Schwab <schwab@linux-m68k.org>
4167
fca8d6b6
AS
4168 * xfns.c (Fx_change_window_property): Doc fix.
4169 * w32fns.c (Fx_change_window_property): Doc fix.
4170
ddadbc0e
AS
4171 * w32fns.c (Fx_window_property): Accept the same arguments as the
4172 X Windows version. Doc fix.
4173 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
4174
ed9265fc 41752012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
4176 Eli Zaretskii <eliz@gnu.org>
4177
4178 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
4179 Windows-specific code from nt/config.nt moved here.
4180 Obsolete settings removed.
4181
216ee680
PE
41822012-07-06 Paul Eggert <eggert@cs.ucla.edu>
4183
4184 * process.c: Avoid unnecessary calls to gettime.
4185 (wait_reading_process_output): Don't get the time of day
4186 when gobbling data immediately and not waiting, as there's no need
4187 for it in that case. This removes a FIXME.
4188
bdd091e4
JD
41892012-07-06 Jan Djärv <jan.h.d@swipnet.se>
4190
4191 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
4192 is defined (Bug#11768).
4193
9d44f8ce
DA
41942012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
4195
4196 Fix marker debugging code.
4197 * marker.c (byte_char_debug_check): Do not perform the check
4198 if buffer is not multibyte.
090bd7cb
JB
4199 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
4200 Call byte_char_debug_check with correct arguments.
9d44f8ce 4201
90fc4786
DA
42022012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
4203
4204 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
4205 * marker.c (byte_char_debug_check, count_markers):
4206 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
4207 (byte_debug_flag): Remove.
4208 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
4209 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
4210
7b7ae965
DA
42112012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
4212
4e57b342
DA
4213 Avoid code repetition in marker-related functions.
4214 * marker.c (attach_marker): New function.
4215 (Fset_marker, set_marker_restricted, set_marker_both)
4216 (set_marker_restricted_both): Use it.
4217 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
4218 Consistently rename charno to charpos.
4219 (marker_position): Add eassert.
4220 (marker_byte_position): Convert to eassert.
4221
42222012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
4223
4224 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 4225 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 4226 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 4227
657924ff
DA
42282012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
4229
4230 Introduce fast path for the widely used marker operation.
4231 * alloc.c (build_marker): New function.
4232 * lisp.h (build_marker): New prototype.
4233 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
4234 * composite.c (autocmp_chars): Likewise.
4235 * editfns.c (buildmark): Remove.
4236 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
4237 (save_restriction_save): Use build_marker.
4238 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
4239 * window.c (save_window_save): Likewise.
4240
041a49a6
DA
42412012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
4242
4243 Do not use Fdelete_overlay in delete_all_overlays
4244 to avoid redundant calls to unchain_overlay.
4245 * buffer.c (drop_overlay): New function.
4246 (delete_all_overlays, Fdelete_overlay): Use it.
4247 * minibuf.c (get_minibuffer): Fix comment.
4248
7dca65a4
PE
42492012-07-06 Paul Eggert <eggert@cs.ucla.edu>
4250
4251 Port to OpenBSD 5.1 amd64.
4252 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
4253 This is needed for OpenBSD, and should be harmless on all BSD systems.
4254 Also, include <sys/sysctl.h>, as it should be available on all
4255 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
4256 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
4257 use p_pid member, not kp_proc.pid.
4258
8eb876e2
GM
42592012-07-06 Glenn Morris <rgm@gnu.org>
4260
4261 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
4262
38182d90
PE
42632012-07-05 Paul Eggert <eggert@cs.ucla.edu>
4264
4265 More xmalloc and related cleanup.
4266 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
4267 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
4268 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
4269 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
4270 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
4271 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
4272 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
4273 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
4274 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
4275 * xterm.c:
4276 Omit needless casts involving void * pointers and allocation.
4277 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
4278 as the former is more robust if P's type is changed.
4279 Prefer xzalloc to xmalloc + memset 0.
4280 Simplify malloc-or-realloc to realloc.
4281 Don't worry about xmalloc returning a null pointer.
4282 Prefer xstrdup to xmalloc + strcpy.
4283 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
4284 growing it.
4285 * keyboard.c (apply_modifiers_uncached): Prefer local array to
4286 alloca of a constant.
4287
6dd5a677
EZ
42882012-07-05 Eli Zaretskii <eliz@gnu.org>
4289
4290 * xdisp.c (display_line): Fix horizontal pixel coordinates when
4291 hscroll is larger than the line width. Fixes long and futile
4292 looping inside extend_face_to_end_of_line (on a TTY) producing
4293 glyphs that are not needed and thrown away.
4294
6b312f0f
DA
42952012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
4296
4297 * marker.c (set_marker_restricted_both): Simplify by using
4298 clip_to_bounds.
4299
f520ef9b
PE
43002012-07-05 Paul Eggert <eggert@cs.ucla.edu>
4301
4302 * editfns.c (region_limit): Simplify by using clip_to_bounds.
4303
383b7c95
JD
43042012-07-05 Jan Djärv <jan.h.d@swipnet.se>
4305
4306 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
4307 not defined (Bug#11768).
4308 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
4309 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
4310 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
4311 followed by gtk_box_set_homogeneous (Bug#11768).
4312 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
4313 (update_theme_scrollbar_width, xg_create_scroll_bar):
4314 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
4315 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
4316 (is_box_type): New function (Bug#11768).
4317 (xg_tool_item_stale_p): Call is_box_type.
5293d758 4318 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
4319 with default display (Bug#11768).
4320
d6e7bf45
EZ
43212012-07-05 Eli Zaretskii <eliz@gnu.org>
4322
4323 * xdisp.c (window_hscroll_limited): New function.
4324 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
4325 coordinates when window's hscroll is set to insanely large
4326 values. (Bug#11857)
4327
431391ec
JB
43282012-07-05 Juanma Barranquero <lekktu@gmail.com>
4329
4330 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
4331 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
4332
23f86fce
DA
43332012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
4334
4335 Cleanup xmalloc.
4336 * lisp.h (xzalloc): New prototype. Omit needless casts.
4337 * alloc.c (xzalloc): New function. Omit needless casts.
4338 * charset.c: Omit needless casts. Convert all calls to
4339 xmalloc with following memset to xzalloc.
4340 * dispnew.c: Likewise.
4341 * fringe.c: Likewise.
4342 * image.c: Likewise.
4343 * sound.c: Likewise.
4344 * term.c: Likewise.
4345 * w32fns.c: Likewise.
4346 * w32font.c: Likewise.
4347 * w32term.c: Likewise.
4348 * xfaces.c: Likewise.
4349 * xfns.c: Likewise.
4350 * xterm.c: Likewise.
4351 * atimer.c: Omit needless casts.
4352 * buffer.c: Likewise.
4353 * callproc.c: Likewise.
4354 * ccl.c: Likewise.
4355 * coding.c: Likewise.
4356 * composite.c: Likewise.
4357 * doc.c: Likewise.
4358 * doprnt.c: Likewise.
4359 * editfns.c: Likewise.
4360 * emacs.c: Likewise.
4361 * eval.c: Likewise.
4362 * filelock.c: Likewise.
4363 * fns.c: Likewise.
4364 * gtkutil.c: Likewise.
4365 * keyboard.c: Likewise.
4366 * lisp.h: Likewise.
4367 * lread.c: Likewise.
4368 * minibuf.c: Likewise.
4369 * msdos.c: Likewise.
4370 * print.c: Likewise.
4371 * process.c: Likewise.
4372 * region-cache.c: Likewise.
4373 * search.c: Likewise.
4374 * sysdep.c: Likewise.
4375 * termcap.c: Likewise.
4376 * terminal.c: Likewise.
4377 * tparam.c: Likewise.
4378 * w16select.c: Likewise.
4379 * w32.c: Likewise.
4380 * w32reg.c: Likewise.
4381 * w32select.c: Likewise.
4382 * w32uniscribe.c: Likewise.
4383 * widget.c: Likewise.
4384 * xdisp.c: Likewise.
4385 * xmenu.c: Likewise.
4386 * xrdb.c: Likewise.
4387 * xselect.c: Likewise.
4388
0497dc44
PE
43892012-07-05 Paul Eggert <eggert@cs.ucla.edu>
4390
4391 * fileio.c (time_error_value): Check the right error number.
4392 Problem reported by Troels Nielsen in
4393 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
4394
356e7178
PE
43952012-07-04 Paul Eggert <eggert@cs.ucla.edu>
4396
4e71fd89
PE
4397 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
4398 This should be fixed in a better way; see Eli Zaretskii in
4399 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
4400 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
4401
f0941253
PE
4402 * fileio.c (time_error_value): Rename from special_mtime.
4403 The old name's problems were noted by Eli Zaretskii in
4404 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
4405
065c9eb4
PE
4406 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
4407 This variable's comment says Emacs needs at least one GDB-visible
4408 symbol of type enum pvec_type, to work around GDB problems.
4409 The symbol's value doesn't matter.
4410
356e7178
PE
4411 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
4412 that causes compilation to fail on pre-C99 compilers.
4413
ed9265fc 44142012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
4415
4416 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
4417 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
4418
3884d954
DA
44192012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
4420
d209e2fb 4421 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
4422 headers for buffer_defaults and buffer_local_symbols.
4423 Reported by Juanma Barranquero <lekktu@gmail.com>.
4424
ee28be33
SM
44252012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4426
4427 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
4428 * lisp.h (enum pvec_type): Use fewer bits.
4429 (PSEUDOVECTOR_SIZE_BITS): New constant.
4430 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
4431 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
4432 change in pvec_type.
4433 (PSEUDOVECTOR_TYPEP): New macro.
4434 (TYPED_PSEUDOVECTORP): Use it.
4435 * fns.c (internal_equal): Adapt code to extract pvectype.
4436 * emacs.c (gdb_pvec_type): Update type.
4437 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
4438 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
4439 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
4440 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
4441 (sweep_vectors): Use it. Use local var `total_bytes' instead of
4442 abusing vector->header.next.nbytes.
4443 (live_vector_p): Use PVEC_TYPE.
4444 (mark_object): Adapt code to extract pvectype. Use switch.
4445
c7f2cd7f
PE
44462012-07-04 Paul Eggert <eggert@cs.ucla.edu>
4447
4448 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
4449 Tighten new eassert a bit.
4450
8ce70ed2
DA
44512012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
4452
4453 Fix compilation with --enable-gcc-warnings and -O1
4454 optimization level.
4455 * doprnt.c (doprnt): Change type of tem to int, initialize
4456 to avoid compiler warning. Add eassert.
4457 * search.c (simple_search): Initialize match_byte to avoid
4458 compiler warning. Add eassert.
4459
dea7f1e5
PE
44602012-07-04 Paul Eggert <eggert@cs.ucla.edu>
4461
24a212eb
PE
4462 Avoid weird behavior with large horizontal scrolls.
4463 Without this change, for example, large hscroll values would
4464 mess up Emacs's display on Fedora 15 x86, presumably due to
4465 overflows in int calculations in the display code.
4466 Also, if buffers had long lines, Emacs would freeze.
4467 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
4468 (set_window_hscroll): New function, containing the old guts of
4469 Fset_window_hscroll. Return the clipped value.
4470 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
4471 This avoids the need to check against PTRDIFF_MAX.
4472
dea7f1e5
PE
4473 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
4474
76046526
DA
44752012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
4476
4477 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
4478
39adff0d
PE
44792012-07-04 Paul Eggert <eggert@cs.ucla.edu>
4480
63807d47
PE
4481 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
4482 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
4483 since GCC 4.4.6 issues a bogus warning for them.
4484
39adff0d
PE
4485 Fix bugs in file timestamp newness comparisons.
4486 * fileio.c (Ffile_newer_than_file_p):
4487 * lread.c (Fload): Use full timestamp resolution of files,
4488 not just the 1-second resolution, so that files that are only
4489 slightly newer still count as newer.
4490 * fileio.c (Ffile_newer_than_file_p): Don't assume file
4491 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
4492
dbeed9a6
PE
44932012-07-03 Paul Eggert <eggert@cs.ucla.edu>
4494
4495 * fileio.c: Improve handling of file time marker. (Bug#11852)
4496 (special_mtime): New function.
4497 (Finsert_file_contents, Fverify_visited_file_modtime):
4498 Use it to set special mtime values consistently.
4499
636334d6
AS
45002012-07-03 Andreas Schwab <schwab@linux-m68k.org>
4501
4502 * fileio.c (Finsert_file_contents): Properly handle st_mtime
4503 marker for non-existing file. (Bug#11852)
4504
e2017fe2
GM
45052012-07-03 Glenn Morris <rgm@gnu.org>
4506
4507 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
4508 and did not make it into globals.h).
4509
404dbd37
TT
45102012-07-03 Tom Tromey <tromey@redhat.com>
4511
4512 * window.c (Fset_window_margins, Fset_window_fringes)
4513 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
4514 * textprop.c (Fprevious_property_change): No longer static.
4515 * syntax.c (Fsyntax_table_p): No longer static.
4516 * process.c (Fget_process, Fprocess_datagram_address): No longer
4517 static.
4518 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
4519 * keyboard.c (Fcommand_execute): No longer static.
4520 Remove EXFUN.
4521 * insdel.c (Fcombine_after_change_execute): No longer static.
4522 * image.c (Finit_image_library): No longer static.
4523 * fileio.c (Fmake_symbolic_link): No longer static.
4524 * eval.c (Ffetch_bytecode): No longer static.
4525 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
4526 * doc.c (Fdocumentation_property, Fsnarf_documentation):
4527 No longer static.
404dbd37
TT
4528 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
4529 static.
4530 * dired.c (Ffile_attributes): No longer static.
4531 * composite.c (Fcomposition_get_gstring): No longer static.
4532 * callproc.c (Fgetenv_internal): No longer static.
4533
4534 * ccl.h: Remove EXFUNs.
4535 * buffer.h: Remove EXFUNs.
4536 * dispextern.h: Remove EXFUNs.
4537 * intervals.h: Remove EXFUNs.
4538 * fontset.h: Remove EXFUN.
4539 * font.h: Remove EXFUNs.
4540 * dosfns.c (system_process_attributes): Remove EXFUN.
4541 * keymap.h: Remove EXFUNs.
4542 * lisp.h: Remove EXFUNs.
4543 * w32term.h: Remove EXFUNs.
4544 * window.h: Remove EXFUNs.
4545 * xsettings.h: Remove EXFUN.
4546 * xterm.h: Remove EXFUN.
4547
8e4fd1e1
GM
45482012-07-03 Glenn Morris <rgm@gnu.org>
4549
4550 * lisp.h (Frandom): Make it visible to C.
4551 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
4552 buffer for invisible buffers. (Bug#1229)
4553
ca95b3eb
DA
45542012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
4555
4556 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
4557 values which aren't power of 2.
14ae4239
BT
4558 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro.
4559 Verify it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
ca95b3eb
DA
4560 accordingly.
4561
7555c33f
SM
45622012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
4563
4564 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
4565
4566 * alloc.c (mark_object): Revert part of last patch to use `switch'.
4567
d12e8f5a
DA
45682012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
4569
4570 * alloc.c (allocate_vector_block): Remove redundant
4571 calls to mallopt if DOUG_LEA_MALLOC is defined.
4572 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
4573 avoid calls to mallopt if zero_vector is returned.
4574
296094c3
DA
45752012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
4576
4577 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
4578 is enabled, avoid dereferencing NULL current_sblock if
4579 running undumped.
4580
36429c89
DA
45812012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
4582
4583 Cleanup basic buffer management.
4584 * buffer.h (struct buffer): Change layout to use generic vector
4585 marking code. Fix some comments. Change type of 'clip_changed'
4586 to bitfield. Remove unused #ifndef old.
4587 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
4588 (GET_OVERLAYS_AT): Fix indentation.
4589 (for_each_per_buffer_object_at): New macro.
4590 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
4591 (Fbuffer_local_variables): Use it.
4592 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
4593 * alloc.c (allocate_buffer): Adjust to match new layout of
4594 struct buffer. Fix comment.
4595 (mark_overlay): New function.
4596 (mark_buffer): Use it. Use mark_vectorlike to mark normal
4597 Lisp area of struct buffer.
4598 (mark_object): Use it. Adjust marking of misc objects
4599 and related comments.
4600
3b3e4cac
PE
46012012-07-02 Paul Eggert <eggert@cs.ucla.edu>
4602
4603 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
4604 wrapper that is not needed because the wrapped code is a no-op (zero
4605 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
4606 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
4607
cf5c0175
DA
46082012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
4609
4610 * alloc.c (mark_buffer): Simplify. Remove prototype.
4611 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 4612 objects. Use CHECK_LIVE for all vector-like objects except buffers
14ae4239
BT
4613 and subroutines when GC_CHECK_MARKED_OBJECTS is defined.
4614 Avoid redundant calls to mark_vectorlike for bool vectors.
cf5c0175 4615
ca26824c
GM
46162012-06-30 Glenn Morris <rgm@gnu.org>
4617
2e4c5312
GM
4618 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
4619
ca26824c
GM
4620 * epaths.in (PATH_SITELOADSEARCH): New.
4621 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
4622 This is rather than relying on --enable-locallisppath elements
4623 having "site-lisp" in their names. (Bug#10208#25, 11658)
4624
0d23c240
EZ
46252012-06-30 Eli Zaretskii <eliz@gnu.org>
4626
c9240d7a
EZ
4627 * w32proc.c (sys_select): Accept and ignore one more argument.
4628
4629 * w32.c (emacs_gnutls_pull): Call select with one more argument.
4630
0d23c240 4631 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 4632 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
4633
4634 * sysdep.c: Don't include dos.h and dosfns.h.
4635
4636 * process.c (sys_select):
4637 * msdos.c (sys_select): Accept one more argument and ignore it.
4638
4639 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
4640 adapt data types and code to that.
4641
4642 * dosfns.c:
4643 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
4644 which clashes with the gnulib function of the same name.
4645
af5a5a98
AS
46462012-06-30 Andreas Schwab <schwab@linux-m68k.org>
4647
c5e4379c
AS
4648 * font.c (font_style_to_value, font_style_symbolic)
4649 (font_prop_validate_style): Add type checks for values in
4650 font_style_table.
4651
af5a5a98
AS
4652 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
4653 argument.
4654 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
4655 uses.
4656
8d38f461
EZ
46572012-06-29 Eli Zaretskii <eliz@gnu.org>
4658
2e5a6631
EZ
4659 * xdisp.c (try_window_id): Undo last change.
4660
8d38f461
EZ
4661 * w32.c (getwd): Adjust commentary about startup_dir.
4662 (init_environment): Always call sys_access, even in non-MSVC
4663 builds. Don't chdir to the directory of the Emacs executable.
4664 This undoes code from 1997 which was justified by the need to
4665 "avoid conflicts when removing and renaming directories". But its
4666 downside was that every relative file name was being interpreted
4667 relative to the directory of the Emacs executable, which can never
4668 be TRT. In particular, it broke sys_access when called with
4669 relative file names.
4670 (sys_access): Map GetLastError to errno.
4671
2af3565e
DA
46722012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
4673
4674 * window.h (struct window): Change type of 'fringes_outside_margins'
4675 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 4676 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
4677 Adjust comment.
4678 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
4679 to ptrdiff_t.
4680
c8d3a25c 46812012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 4682
c8d3a25c
GM
4683 * gnutls.c (emacs_gnutls_handshake):
4684 Add QUIT to make the loop interruptible.
57570cd3 4685
c8d3a25c 46862012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 4687
c8d3a25c
GM
4688 * charset.c (init_charset): Make lack of etc/charsets fatal.
4689
3e984ee8
DA
46902012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
4691
4692 * editfns.c (region_limit): Fix type mismatch.
4693
ef884f23
DA
46942012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
4695
4696 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
4697 undefined. Convert from xassert to eassert.
4698 * nsmenu.m: Convert from xassert to eassert.
4699 * nsterm.m: Likewise.
4700
7d7e0027
SM
47012012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
4702
4703 * editfns.c (region_limit): Clip to narrowing (bug#11770).
4704
aa754e6a
PE
47052012-06-28 Paul Eggert <eggert@cs.ucla.edu>
4706
4707 Avoid integer overflow on scroll-left and scroll-right.
4708 * window.c (HSCROLL_MAX): New macro.
4709 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
4710 overflow when requested scroll falls outside ptrdiff_t range.
4711
80b00b08
DA
47122012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
4713
4714 * window.h (struct window): Change type of 'hscroll',
4715 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
4716 'last_modified' and 'last_overlay_modified' to EMACS_INT.
4717 Adjust users accordingly.
4718 * xdisp.c (try_cursor_movement): Replace type check with eassert.
4719 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
4720 from EMACS_INT to ptrdiff_t.
4721 (make_window): Omit redundant initialization.
4722
62b2bcf6
JB
47232012-06-28 Juanma Barranquero <lekktu@gmail.com>
4724
4725 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
4726
45942c7d
DA
47272012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
4728
4729 * window.h (struct window): Change type of 'use_time' and
4730 'sequence_number' from Lisp_Object to int.
4731 * frame.c (make_frame): Adjust users accordingly.
4732 * print.c (print_object): Likewise.
4733 * window.c (select_window, Fwindow_use_time, make_parent_window)
4734 (make_window): Likewise.
4735
e509cfa6
DA
47362012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
4737
4738 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
4739 enabled with --enable-checking=[all,glyphs] configure option.
4740 Fix GLYPH_DEBUG usage assuming that it may be undefined,
4741 adjust comments accordingly.
4742 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
4743 undefined, adjust comments accordingly.
4744 * image.c: Likewise.
4745 * scroll.c: Likewise.
4746 * w32fns.c: Likewise.
4747 * w32term.c: Likewise.
4748 * xdisp.c: Likewise.
4749 * xfaces.c: Likewise.
4750 * xfns.c: Likewise.
4751 * xterm.c: Likewise.
4752
a54e2c05
DA
47532012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
4754
4755 Generalize run-time debugging checks.
4756 * dispextern.h (XASSERTS): Remove.
4757 * fontset.c (xassert): Remove.
4758 Convert from xassert to eassert.
4759 * alloc.c: Convert from xassert to eassert.
4760 * bidi.c: Likewise.
4761 * dispnew.c: Likewise.
4762 * fns.c: Likewise.
4763 * fringe.c: Likewise.
4764 * ftfont.c: Likewise.
4765 * gtkutil.c: Likewise.
4766 * image.c: Likewise.
4767 * keyboard.c: Likewise.
4768 * menu.c: Likewise.
4769 * process.c: Likewise.
4770 * scroll.c: Likewise.
4771 * sound.c: Likewise.
4772 * term.c: Likewise.
4773 * w32console.c: Likewise.
4774 * w32fns.c: Likewise.
4775 * w32term.c: Likewise.
4776 * window.c: Likewise.
4777 * xdisp.c: Likewise.
4778 * xfaces.c: Likewise.
4779 * xfns.c: Likewise.
4780 * xselect.c: Likewise.
4781 * xterm.c: Likewise.
4782
1ec4b7b2
SM
47832012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
4784
4785 * fns.c (maybe_resize_hash_table): Output message when growing the
4786 purify-hashtable.
4787
2014308a
DA
47882012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
4789
4790 * alloc.c (allocate_string_data): Remove dead code.
4791 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
4792 avoid GCC warning about unused macro.
4793
246155eb
DA
47942012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
4795
4796 * alloc.c (allocate_string): Omit intervals initialization.
4797 * alloc.c (make_uninit_multibyte_string): Initialize intervals
4798 as in make_pure_string and make_pure_c_string.
4799
43184b7b
DA
48002012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
4801
d209e2fb 4802 * alloc.c (allocate_string): Fix last change.
43184b7b 4803
3fe6dd74
DA
48042012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
4805
d209e2fb 4806 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
4807 to memset, add explicit initialization where appropriate.
4808
1ba6038a
GM
48092012-06-27 Glenn Morris <rgm@gnu.org>
4810
4811 * lisp.mk (lisp): Remove paths.elc.
4812
c89926a5
CY
48132012-06-27 Chong Yidong <cyd@gnu.org>
4814
4815 * doc.c (Fsubstitute_command_keys): Fix punctuation.
4816
ed6b3510
JW
48172012-06-26 John Wiegley <johnw@newartisans.com>
4818
1ec4b7b2 4819 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
4820 on Mac OS X Lion: __mod_init_func and __mod_term_func.
4821
ed6b3510
JW
4822 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
4823 when building with Clang.
4824
8edd4a2b
SM
48252012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
4826
4827 * eval.c (Fapply): Allow calling it with a single argument.
4828
f6f62d1b
EZ
48292012-06-26 Eli Zaretskii <eliz@gnu.org>
4830
4831 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
4832 _stricmp and _strnicmp.
4833 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
4834
62efea5e
DA
48352012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
4836
4837 * alloc.c (allocate_window): Zero out non-Lisp part of newly
4838 allocated window.
4839 (allocate_process): Likewise for new process.
8edd4a2b 4840 (allocate_terminal): Change to use offsetof.
62efea5e
DA
4841 (allocate_frame): Likewise.
4842 * frame.c (make_frame): Omit redundant initialization.
4843 * window.c (make_parent_window): Use memset.
4844 (make_window): Omit redundant initialization.
4845 * process.c (make_process): Omit redundant initialization.
4846 * terminal.c (create_terminal): Likewise.
4847
42997f4d
DA
48482012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
4849
4850 * term.c (delete_tty): Remove redundant call to memset.
4851
1130ecfc
DA
48522012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
4853
4854 * alloc.c: Remove build_string.
4855 * lisp.h: Define build_string as static inline. This provides
4856 a better opportunity to optimize away calls to strlen when the
4857 function is called with compile-time constant argument.
4858 * image.c (imagemagick_error): Convert to build_string.
4859 * w32proc.c (sys_spawnve): Likewise.
4860 * xterm.c (x_term_init): Likewise.
4861
cf38a720
PE
48622012-06-26 Paul Eggert <eggert@cs.ucla.edu>
4863
99027bdd
PE
4864 Use sprintf return value instead of invoking strlen on result.
4865 In the old days this wasn't portable, since some sprintf
4866 implementations returned char *. But they died out years ago and
4867 Emacs already assumes sprintf returns int.
4868 Similarly for float_to_string.
4869 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
4870 * ccl.c (ccl_driver):
4871 * character.c (string_escape_byte8):
4872 * data.c (Fnumber_to_string):
4873 * doprnt.c (doprnt):
4874 * print.c (print_object):
4875 * xdisp.c (message_dolog):
4876 * xfns.c (syms_of_xfns):
4877 Use sprintf or float_to_string result to avoid need to call strlen.
4878 * data.c (Fnumber_to_string):
4879 Use make_unibyte_string, since the string must be ASCII.
4880 * lisp.h, print.c (float_to_string): Now returns int length.
4881 * term.c (produce_glyphless_glyph):
4882 Use sprintf result rather than recomputing it.
4883
cf38a720
PE
4884 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
4885 * Makefile.in (ALL_CFLAGS):
4886 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
4887 * gmalloc.c, regex.c: Include <config.h> unconditionally.
4888
3511c784
DA
48892012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
4890
0a08eb21 4891 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
4892 strcasecmp if available.
4893 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
4894
fb7da12e
AS
48952012-06-25 Andreas Schwab <schwab@linux-m68k.org>
4896
4897 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
4898 Avoid comma operator.
4899 * menu.c (push_submenu_start, push_submenu_end)
4900 (push_left_right_boundary, push_menu_pane): Likewise.
4901 * msdos.c (dos_rawgetc): Likewise.
4902
afa2ffd8
DA
49032012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
4904
4905 * xfns.c (xic_create_fontsetname): Remove redundant calls
4906 to memset.
4907
b3b4476b
PE
49082012-06-25 Paul Eggert <eggert@cs.ucla.edu>
4909
4495ff38
PE
4910 * gtkutil.c (get_utf8_string): Remove redundant assignment.
4911 sprintf already null-terminates its output.
4912
b3b4476b
PE
4913 * xfns.c (x_window): Remove redundant cast.
4914
b00876c9
DA
49152012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
4916
4917 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
4918 `const char *' to `char *' to avoid compiler warning.
4919
d188e26b
PE
49202012-06-24 Paul Eggert <eggert@cs.ucla.edu>
4921
885d1d74
PE
4922 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
4923 instead of truncating it to 63 (admittedly a generous limit).
4924
d188e26b
PE
4925 * process.c: Fix spelling and caps in comments.
4926
e2f560b1
DN
49272012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
4928
e86db54b 4929 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
4930 * sysdep.c (setpgrp): Remove definition, not used in this file.
4931
7583a3a1
JB
49322012-06-24 Juanma Barranquero <lekktu@gmail.com>
4933
4934 * makefile.w32-in: Update dependencies.
4935
696056c2
EZ
49362012-06-24 Eli Zaretskii <eliz@gnu.org>
4937
4938 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
4939 (SYSTIME_H): Add nt/inc/sys/time.h.
4940
4941 * systime.h [WINDOWSNT]: Include sys/time.h.
4942
4943 * s/ms-w32.h (struct timespec): Definition moved from
4944 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
4945
845ca893
PE
49462012-06-24 Paul Eggert <eggert@cs.ucla.edu>
4947
4948 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
4949 * buffer.h (buffer_slot_type_mismatch):
4950 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
4951 * eval.c (unwind_to_catch):
4952 * image.c (my_png_error, my_error_exit):
4953 * keyboard.c (quit_throw_to_read_char, user_error)
4954 (Fexit_recursive_edit, Fabort_recursive_edit):
4955 * lisp.h (die, args_out_of_range, args_out_of_range_3)
4956 (wrong_type_argument, buffer_overflow, __executable_start)
4957 (memory_full, buffer_memory_full, string_overflow, Fthrow)
4958 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
4959 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
4960 (fatal):
4961 (child_setup) [!DOS_NT]:
4962 * lread.c (end_of_file_error, invalid_syntax):
4963 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
4964 * puresize.h (pure_write_error):
4965 * search.c (matcher_overflow):
4966 * sound.c (sound_perror, alsa_sound_perror):
4967 * sysdep.c, syssignal.h (croak):
4968 * term.c (maybe_fatal, vfatal):
4969 * textprop.c (text_read_only):
4970 * undo.c (user_error):
4971 * unexmacosx.c (unexec_error):
4972 * xterm.c (x_ins_del_lines, x_delete_glyphs):
4973 Use _Noreturn rather than NO_RETURN.
4974 No need for separate decl merely because of _Noreturn.
4975 * sound.c (sound_warning, parse_sound):
4976 Remove unnecessary forward decls.
4977
f1dd8073
PE
49782012-06-24 Paul Eggert <eggert@cs.ucla.edu>
4979
4980 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
4981 * lisp.h (WAIT_READING_MAX): New macro.
4982 * dispnew.c (Fsleep_for, sit_for):
4983 * keyboard.c (kbd_buffer_get_event):
4984 * process.c (Faccept_process_output):
4985 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
4986 This improves on the previous patch, which introduced a bug
4987 when time_t is unsigned and as wide as intmax_t.
4988 See <http://bugs.gnu.org/9000#51>.
4989
b82c1755
EZ
49902012-06-23 Eli Zaretskii <eliz@gnu.org>
4991
4992 * dispnew.c (sit_for, Fsleep_for):
4993 * keyboard.c (kbd_buffer_get_event):
4994 * process.c (Faccept_process_output): Avoid compiler warnings when
4995 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
4996
ca300656
JB
49972012-06-23 Juanma Barranquero <lekktu@gmail.com>
4998
049ec95b
JB
4999 * makefile.w32-in: Update dependencies.
5000
ca300656
JB
5001 * w32.c (ltime): Add return type and declare static.
5002 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
5003
db7b8d06
PE
50042012-06-23 Paul Eggert <eggert@cs.ucla.edu>
5005
5006 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
5007 Privately reported by Herbert J. Skuhra.
5008 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
5009 All uses changed.
5010 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
5011 not make_lisp_timeval, when the argument is of type EMACS_TIME.
5012
0bd8297f
EZ
50132012-06-23 Eli Zaretskii <eliz@gnu.org>
5014
96512555
EZ
5015 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
5016 last argument of make_unibyte_string.
5017
0bd8297f
EZ
5018 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
5019 language ID in the event parameters.
5020
5021 * w32term.c (w32_read_socket): Put the new keyboard codepage into
5022 event.code, not the obscure "character set ID".
5023
63def6b6
CY
50242012-06-23 Chong Yidong <cyd@gnu.org>
5025
5026 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
5027
e8a02204
EZ
50282012-06-23 Eli Zaretskii <eliz@gnu.org>
5029
388cdec0
EZ
5030 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
5031 * w32.c (fdutimens): New function.
5032
5033 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
5034
5035 * s/ms-w32.h (pselect): Redirect to sys_select.
5036
5037 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
5038
e8a02204
EZ
5039 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
5040 in the logic of incrementing and decrementing the value of
5041 use_relocatable_buffers.
5042
d054f3fb
PE
50432012-06-23 Paul Eggert <eggert@cs.ucla.edu>
5044
5045 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
5046 Privately reported by Herbert J. Skuhra.
5047 [__FreeBSD__]: Remove "*/" typo after "#include".
5048 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
5049 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
5050 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
5051 Don't assume EMACS_TIME and struct timeval are the same type.
5052
d35af63c
PE
50532012-06-22 Paul Eggert <eggert@cs.ucla.edu>
5054
5055 Support higher-resolution time stamps (Bug#9000).
5056 The time stamps are only nanosecond-resolution at the C level,
5057 since that's the best that any real-world system supports now.
5058 But they are picosecond-resolution at the Lisp level, as that's
5059 easy, and leaves room for future OS improvements.
5060
5061 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
5062 (LIBES): Use it.
5063
5064 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
5065 Don't get current time unless it's needed.
5066
5067 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
5068 now provides it if it's absent.
5069 (start_atimer): Port to higher-res time stamps.
5070 Check for time stamp overflow. Don't get current time more
5071 often than is needed.
5072
5073 * buffer.h (struct buffer): Buffer modtime now has high resolution.
5074 Include systime.h, not time.h.
5075 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
5076
5077 * dired.c: Include stat-time.h.
5078 (Ffile-attributes): File times now have higher resolution.
5079
5080 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
5081 (struct image): Timestamp now has higher resolution.
5082
5083 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
5084 has at least microseconds now. All uses removed.
5085 (update_frame, update_single_window, update_window, update_frame_1)
5086 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
927c7216 5087 (duration_to_sec_usec): Remove; no longer needed.
d35af63c
PE
5088
5089 * editfns.c (time_overflow): Now extern.
5090 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
5091 (float-time, Fformat_time_string, Fcurrent_time_string)
5092 (Fcurrent_time_zone): Accept and generate higher-resolution
5093 time stamps.
5094 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
5095 (decode_time_components, lisp_seconds_argument): New functions.
5096 (make_time): Now static.
5097 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
5098 Report an error if the time is invalid, rather than having the caller
5099 do that.
5100
5101 * fileio.c: Include <stat-time.h>
5102 (Fcopy_file): Copy higher-resolution time stamps.
5103 Prefer to set the time stamp via a file descriptor if that works.
5104 (Fset_file_times, Finsert_file_contents, Fwrite_region)
5105 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
5106 (Fvisited_file_modtime, Fset_visited_file_modtime):
5107 Support higher-resolution time stamps.
5108
5109 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
5110
5111 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
5112
5113 * image.c (prepare_image_for_display, clear_image_cache)
5114 (lookup_image): Port to higer-resolution time stamps.
5115
5116 * keyboard.c (start_polling, bind_polling_period):
5117 Check for time stamp overflow.
5118 (read_char, kbd_buffer_get_event, timer_start_idle)
5119 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
5120 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
5121 Port to higher-resolution time stamps. Do not assume time_t is signed.
5122 (decode_timer): New function. Timers are now vectors of length 9,
5123 not 8, to accommodate the picosecond component.
5124 (timer_check_2): Use it.
5125
5126 * nsterm.m (select_timeout, timeval_subtract): Remove.
5127 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
5128 as they're a bit more accurate and handle overflow better.
5129 (ns_select): Change prototype to be compatible with pselect.
5130 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
5131 * nsterm.h (ns_select): Adjust prototype.
5132
5133 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
5134 us-resolution time stamps.
5135 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
5136
5137 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
5138
5139 * lisp.h (time_overflow): New decl.
5140 (wait_reading_process_output): First arg is now intmax_t, not int,
5141 to accommodate larger waits.
5142
5143 * process.h (struct Lisp_Process.read_output_delay):
5144 Now counts nanoseconds, not microseconds.
5145 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
5146 EMACS_HAS_USECS.
5147 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
5148 (wait_reading_process_output):
5149 Port to ns-resolution time stamps.
5150 (Faccept_process_output, wait_reading_process_output):
5151 Check for time stamp overflow. Do not assume time_t is signed.
5152 (select_wrapper): Remove; we now use pselect.
5153 (Fprocess_attributes): Now generates ns-resolution time stamps.
5154
5155 * sysdep.c: Include utimens.h. Don't include utime.h
5156 or worry about struct utimbuf; gnulib does that for us now.
5157 (gettimeofday): Remove; gnulib provides a substitute.
5158 (make_timeval): New function.
5159 (set_file_times): Now sets ns-resolution time stamps.
5160 New arg FD; all uses changed.
5161 (time_from_jiffies, ltime_from_jiffies, get_up_time)
5162 (system_process_attributes):
5163 Now returns ns-resolution time stamp. All uses changed.
5164 Check for time stamp overflow.
5165
5166 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
5167 provides a substitute now.
5168
5169 * systime.h: Include timespec.h rather than sys/time.h and time.h,
5170 since it guarantees struct timespec.
5171 (EMACS_TIME): Now struct timespec, so that we can support
5172 ns-resolution time stamps.
5173 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
5174 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
5175 (EMACS_USECS): Remove.
5176 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
5177 so multiply the arg by 1000 before storing it.
5178 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
5179 New macros.
5180 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
5181 Port to ns-resolution time stamps.
5182 (EMACS_TIME_NEG_P): Remove; replaced by....
5183 (EMACS_TIME_SIGN): New macro.
5184 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
5185 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
5186 (set_file_times, make_time, lisp_time_argument): Adjust signature.
5187 (make_timeval, make_lisp_time, decode_time_components): New decls.
5188 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
5189 that it mishandled time_t overflow. You can't compare by subtracting!
5190 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
5191 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
5192
5193 * term.c: Include <sys/time.h>.
5194 (timeval_to_Time): New function, for proper overflow wraparound.
5195 (term_mouse_position, term_mouse_click): Use it.
5196
5197 * undo.c (record_first_change): Support higher-resolution time stamps
5198 in the undo buffer.
5199 (Fprimitive_undo): Use them when restoring time stamps.
5200
5201 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
5202 (w32_get_internal_run_time):
5203 Port to higher-resolution Emacs time stamps.
5204 (ltime): Now accepts single 64-bit integer, as that's more convenient
5205 for callers.
5206
5207 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
5208
5209 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
5210 for compatibility with pselect. Support ns-resolution time stamps.
5211
5212 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
5213
5214 * xselect.c (wait_for_property_change, x_get_foreign_selection):
5215 Check for time stamp overflow, and support ns-resolution time stamps.
5216
5217 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
5218 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
5219 (timeval_subtract): Remove; no longer needed.
5220 (XTflash, XTring_bell, x_wait_for_event):
5221 Port to ns-resolution time stamps. Don't assume time_t is signed.
5222
b6a92dfe
CY
52232012-06-22 Chong Yidong <cyd@gnu.org>
5224
5225 * xdisp.c (x_consider_frame_title): Revert last change.
5226
d251c37c
EZ
52272012-06-22 Eli Zaretskii <eliz@gnu.org>
5228
5229 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
5230 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
5231 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
5232 staticidx goes up to 1597 out of 1600 = 0x640.)
5233
f10deafb
PE
52342012-06-20 Paul Eggert <eggert@cs.ucla.edu>
5235
5236 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
5237 Otherwise, the umask might be mistakenly 0 while handling input signals.
5238
ec6de1e2
SM
52392012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
5240
5241 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
5242
28be1ada
DA
52432012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
5244
5245 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
5246 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
5247 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
5248 access to `contents' member of Lisp_Vector objects with AREF and ASET
5249 where appropriate.
5250
c6bf3022
CY
52512012-06-19 Chong Yidong <cyd@gnu.org>
5252
5253 * frame.c (delete_frame): When selecting a frame on a different
5254 text terminal, do not alter the terminal's top-frame.
5255
5256 * xdisp.c (format_mode_line_unwind_data): Record the target
5257 frame's selected window and its terminal's top-frame.
5258 (unwind_format_mode_line): Restore them.
5259 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
5260 Callers changed.
5261 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
5262 since tty frames can be explicitly named.
5263 (prepare_menu_bars): Likewise.
5264
5265 * term.c (Ftty_top_frame): New function.
5266
defd4196
PE
52672012-06-18 Paul Eggert <eggert@cs.ucla.edu>
5268
5269 Port byte-code-meter to modern targets.
5270 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
5271 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 5272 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
5273 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
5274 (METER_1, METER_2): Simplify.
5275
1053a871
SM
52762012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
5277
5278 * data.c (Fdefalias): Return `symbol' (bug#11686).
5279
b7e8d081
MR
52802012-06-18 Martin Rudalics <rudalics@gmx.at>
5281
5282 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
5283 gets killed during executing of this function (Bug#11665).
5284 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
5285 (Vkill_buffer_query_functions): In doc-string say that functions
5286 run by this hook should not change the current buffer.
5287
7ea2b339
PE
52882012-06-18 Paul Eggert <eggert@cs.ucla.edu>
5289
5290 Fix recently-introduced process.c problems found by static checking.
5291 * process.c (write_queue_push, write_queue_pop, send_process):
5292 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
5293 (write_queue_pop): Fix pointer signedness problem.
5294 (send_process): Remove unused local.
5295
96a313a1
CY
52962012-06-17 Chong Yidong <cyd@gnu.org>
5297
5298 * xdisp.c (redisplay_internal): No need to redisplay terminal
5299 frames that are not on top.
5300
20ca2e94
TN
53012012-06-17 Troels Nielsen <bn.troels@gmail.com>
5302
5303 * process.c (make_process): Initialize write_queue.
5304 (write_queue_push, write_queue_pop): New functions.
5305 (send_process): Use them to maintain correct ordering of process
5306 writes (Bug#10815).
5307
9a900ca9
PE
53082012-06-17 Paul Eggert <eggert@cs.ucla.edu>
5309
310fbfa8
PE
5310 * lisp.h (eassert): Assume C89 or later.
5311 This removes the need for CHECK.
5312 (CHECK): Remove. Its comments about always evaluating its
5313 argument were confusing, as 'eassert' typically does not evaluate
5314 its argument.
5315
27bb1ca4
PE
5316 * coding.c (produce_chars): Use ptrdiff_t, not int.
5317
9a900ca9
PE
5318 * xterm.c (x_draw_underwave): Check for integer overflow.
5319 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
5320
41b7f8bc 53212012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
5322
5323 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
5324 referenced (Bug#11583).
5325
9b0e3eba
AA
53262012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
5327
5328 Implement wave-style variant of underlining.
5329 * dispextern.h (face_underline_type): New enum.
5330 (face): Add field for underline type.
5331 * nsterm.m (ns_draw_underwave): New function.
5332 (ns_draw_text_decoration): Use it.
5333 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
5334 New functions.
5335 (x_draw_glyph_string): Use them.
5336 * xfaces.c (Qline, Qwave): New Lisp objects.
5337 (check_lface_attrs, merge_face_ref)
1053a871
SM
5338 (Finternal_set_lisp_face_attribute, realize_x_face):
5339 Handle wave-style underline face attributes.
9b0e3eba
AA
5340 * xterm.c (x_draw_underwave): New function.
5341 (x_draw_glyph_string): Use it.
5342
0fb52f11
JB
53432012-06-16 Juanma Barranquero <lekktu@gmail.com>
5344
5345 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
5346 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
5347 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
5348 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
5349 ($(BLD)/w32select.$(O)): Update dependencies.
5350
e5560ff7
AS
53512012-06-16 Andreas Schwab <schwab@linux-m68k.org>
5352
5353 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
5354 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
5355 * character.c (_fetch_multibyte_char_p): Remove.
5356 * alloc.c: Include "character.h" before "buffer.h".
5357 * bidi.c: Likewise.
5358 * buffer.c: Likewise.
5359 * bytecode.c: Likewise.
5360 * callint.c: Likewise.
5361 * callproc.c: Likewise.
5362 * casefiddle.c: Likewise.
5363 * casetab.c: Likewise.
5364 * category.c: Likewise.
5365 * cmds.c: Likewise.
5366 * coding.c: Likewise.
5367 * composite.c: Likewise.
5368 * dired.c: Likewise.
5369 * dispnew.c: Likewise.
5370 * doc.c: Likewise.
5371 * dosfns.c: Likewise.
5372 * editfns.c: Likewise.
5373 * emacs.c: Likewise.
5374 * fileio.c: Likewise.
5375 * filelock.c: Likewise.
5376 * font.c: Likewise.
5377 * fontset.c: Likewise.
5378 * fringe.c: Likewise.
5379 * indent.c: Likewise.
5380 * insdel.c: Likewise.
5381 * intervals.c: Likewise.
5382 * keyboard.c: Likewise.
5383 * keymap.c: Likewise.
5384 * lread.c: Likewise.
5385 * macros.c: Likewise.
5386 * marker.c: Likewise.
5387 * minibuf.c: Likewise.
5388 * nsfns.m: Likewise.
5389 * nsmenu.m: Likewise.
5390 * print.c: Likewise.
5391 * process.c: Likewise.
5392 * regex.c: Likewise.
5393 * region-cache.c: Likewise.
5394 * search.c: Likewise.
5395 * syntax.c: Likewise.
5396 * term.c: Likewise.
5397 * textprop.c: Likewise.
5398 * undo.c: Likewise.
5399 * unexsol.c: Likewise.
5400 * w16select.c: Likewise.
5401 * w32fns.c: Likewise.
5402 * w32menu.c: Likewise.
5403 * window.c: Likewise.
5404 * xdisp.c: Likewise.
5405 * xfns.c: Likewise.
5406 * xmenu.c: Likewise.
5407 * xml.c: Likewise.
5408 * xselect.c: Likewise.
5409
2f07e6af
EZ
54102012-06-16 Eli Zaretskii <eliz@gnu.org>
5411
1053a871
SM
5412 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
5413 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 5414 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
5415 row.
5416 (handle_face_prop): Use chunk-relative overlay string index when
5417 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
5418 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
5419 the rightmost. (Bug#11720)
2f07e6af 5420
29b83cec
AS
54212012-06-16 Andreas Schwab <schwab@linux-m68k.org>
5422
5423 * category.h (CHAR_HAS_CATEGORY): Define as inline.
5424 (CATEGORY_MEMBER): Enforce 1/0 value.
5425 * category.c (_temp_category_set): Remove.
5426
4c5501e9
EZ
54272012-06-16 Eli Zaretskii <eliz@gnu.org>
5428
5429 * window.c (Fdelete_other_windows_internal)
5430 (Fdelete_window_internal): Don't access frame's mouse highlight
5431 info of the initial frame. (Bug#11677)
5432
2b570124
PE
54332012-06-14 Paul Eggert <eggert@cs.ucla.edu>
5434
e93864f9
PE
5435 * .gdbinit (xgetint): Fix recently-introduced paren typo.
5436 Assume USE_2_TAGS_FOR_INTS.
5437 (xreload): Adjust $tagmask width to match recent lisp.h change.
5438
2b570124
PE
5439 Simplify lisp.h in minor ways that should not affect code.
5440 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
5441 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
5442 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
5443 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
5444 (INTTYPEBITS): New macro, for clarity.
5445 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
5446 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
5447 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
5448 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
5449 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
5450
81755f69
JB
54512012-06-13 Juanma Barranquero <lekktu@gmail.com>
5452
5453 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
5454
16192a57
GM
54552012-06-13 Glenn Morris <rgm@gnu.org>
5456
5457 * s/bsd-common.h (BSD4_3):
5458 * s/usg5-4-common.h (USG5_4): No longer define; unused.
5459
646b5f55
AS
54602012-06-13 Andreas Schwab <schwab@linux-m68k.org>
5461
5462 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
5463 instead of union.
5464 (XLI, XIL): Define.
1053a871
SM
5465 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
5466 Use them.
5467 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 5468 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 5469 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
5470 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
5471 * frame.c (delete_frame): Remove outdated comment.
5472 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
5473 USE_LISP_UNION_TYPE.
5474 (Fw32_unregister_hot_key): Likewise.
5475 (Fw32_toggle_lock_key): Likewise.
5476 * w32menu.c (add_menu_item): Likewise.
5477 (w32_menu_display_help): Use XIL instead of checking
5478 USE_LISP_UNION_TYPE.
5479 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
5480 (init_heap): Likewise.
5481 * w32term.c (w32_read_socket): Update comment.
5482
1d3823c9
GM
54832012-06-13 Glenn Morris <rgm@gnu.org>
5484
c62ff706
GM
5485 * s/usg5-4-common.h, src/s/unixware.h:
5486 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
5487
1d3823c9
GM
5488 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
5489
bfe3e0a2
PE
54902012-06-13 Paul Eggert <eggert@cs.ucla.edu>
5491
5492 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
5493 * alloc.c (make_number) [!defined make_number]:
5494 Remove, as lisp.h always defines this now.
5495 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
5496 (roundup_size): Verify that it is a power of 2.
5497 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
5498 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
5499 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
5500 -DUSE_LSB_TAG=0, to override the automatically-selected default.
5501 USE_LSB_TAG now is always defined to be either 0 or 1.
5502 All uses changed.
5503 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
5504 code works fine either way, and efficiency is not a concern here,
5505 as the union type is for debugging, not for production.
5506 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
5507 Use an inline function on all platforms when using the union type,
5508 since this is simpler and 'static inline' can be used portably
5509 within Emacs now.
5510 (LISP_INITIALLY_ZERO): New macro.
5511 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
5512 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
5513
45fa9c0f
GM
55142012-06-12 Glenn Morris <rgm@gnu.org>
5515
b4492cba
GM
5516 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
5517
5518 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 5519
45fa9c0f
GM
5520 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
5521 Move BROKEN_SIGIO to configure.
5522
5523 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
5524 Move NO_TERMIO to configure.
5525
0e25d334
CY
55262012-06-12 Chong Yidong <cyd@gnu.org>
5527
5528 * image.c (imagemagick_load_image): Use MagickFlattenImage if
5529 MagickMergeImageLayers is undefined. Use pixel pusher loop if
5530 MagickExportImagePixels is undefined.
5531
43682bb6
PE
55322012-06-12 Paul Eggert <eggert@cs.ucla.edu>
5533
5534 * image.c (imagemagick_load_image): Remove unused label.
5535
a9be7d2b
GM
55362012-06-11 Glenn Morris <rgm@gnu.org>
5537
5538 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
5539 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
5540 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
5541 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
5542
3017f87f
SM
55432012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
5544
5545 * alloc.c (make_byte_code): New function.
5546 (Fmake_byte_code): Use it. Don't purify here.
5547 * lread.c (read1): Use it as well to avoid extra allocation.
5548
1b9b4cf4
CY
55492012-06-11 Chong Yidong <cyd@gnu.org>
5550
5551 * image.c (imagemagick_load_image): Implement transparency.
5552
95988fcf
AS
55532012-06-10 Andreas Schwab <schwab@linux-m68k.org>
5554
5555 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
5556 account for preceding backslashes. (Bug#11663)
5557
cd4eb164
CY
55582012-06-09 Chong Yidong <cyd@gnu.org>
5559
5560 * term.c: Support italics in capable terminals (Bug#9652).
5561 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
5562 (turn_on_face): Output using TS_enter_italic_mode if available.
5563 Don't handle unused blinking and alt-charset cases.
5564 (turn_off_face): Handle italic case; discard unused tty_blinking_p
5565 and tty_alt_charset_p cases.
5566 (tty_capable_p, init_tty): Support italics.
5567
5568 * termchar.h (struct tty_display_info): Add field for italics.
5569 Remove unused blink field.
5570
5571 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
5572 Handle slant.
5573
5574 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
5575 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
5576 tty_alt_charset_p. Add tty_italic_p.
5577
ff88beb8
MA
55782012-06-09 Michael Albinus <michael.albinus@gmx.de>
5579
5580 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
5581 dbus_type_is_basic if available.
5582 (xd_extract_signed, xd_extract_unsigned): Rename from
5583 extract_signed and extract_unsigned, respectively. Adapt callers.
5584
44286096
CY
55852012-06-09 Chong Yidong <cyd@gnu.org>
5586
1682701f
CY
5587 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
5588
44286096
CY
5589 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
5590 case (Bug#9752).
5591
d86feb17
PE
55922012-06-08 Paul Eggert <eggert@cs.ucla.edu>
5593
5594 * xdisp.c (vmessage): Treat frame message as multibyte.
5595 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
5596 would generate the diagnostic "Making \302\247 buffer-local while
5597 let-bound!".
5598
d5c20fe8
EZ
55992012-06-08 Eli Zaretskii <eliz@gnu.org>
5600
5601 * dispnew.c (showing_window_margins_p): Undo last change, which
5602 was done due to an inadvertent commit.
5603 (adjust_frame_glyphs_for_frame_redisplay): Do call
5604 showing_window_margins_p.
5605
513749ee
SM
56062012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
5607
5608 * eval.c (Fmake_var_non_special): New primitive.
5609 (syms_of_eval): Defsubr it.
5610 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
5611
d4a8f5c1
JB
56122012-06-08 Juanma Barranquero <lekktu@gmail.com>
5613
5614 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
5615 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
5616
8bbbc977
EZ
56172012-06-08 Eli Zaretskii <eliz@gnu.org>
5618
5619 * alloc.c (allocate_vectorlike): Fix last change.
5620
f3372c87
DA
56212012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
5622
5623 Block-based vector allocation of small vectors.
5624 * lisp.h (struct vectorlike_header): New field `nbytes',
5625 adjust comment accordingly.
5626 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
fc0c31f8 5627 to denote vector blocks. Adjust users (live_vector_p,
f3372c87
DA
5628 mark_maybe_pointer, valid_lisp_object_p) accordingly.
5629 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
5630 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
5631 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
5632 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
5633 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
5634 (roundup_size): New constant.
5635 (struct vector_block): New data type.
5636 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 5637 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
5638 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
5639 (sweep_vectors): New functions.
5640 (allocate_vectorlike): Return `zero_vector' as the only vector of
fc0c31f8 5641 0 items. Allocate new vector from block if vector size is less than
f3372c87
DA
5642 or equal to VBLOCK_BYTES_MAX.
5643 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
5644 (init_alloc_once): Add call to init_vectors.
5645
4f18a4ed
SM
56462012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
5647
5648 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
5649
86f158bc
PE
56502012-06-07 Paul Eggert <eggert@cs.ucla.edu>
5651
5652 * doprnt.c (doprnt): Truncate multibyte char correctly.
5653 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
5654 would mishandle a string argument "Xc" if X was a multibyte
5655 character of length 2: it would truncate after X's first byte
5656 rather than including all of X.
5657
c5cfcbe0
CY
56582012-06-06 Chong Yidong <cyd@gnu.org>
5659
5660 * buffer.c (word_wrap): Doc fix.
5661
c05cf390
PE
56622012-06-04 Paul Eggert <eggert@cs.ucla.edu>
5663
5664 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
5665
0c3461de
GM
56662012-06-03 Glenn Morris <rgm@gnu.org>
5667
5668 * xdisp.c (tool-bar-style): Doc fix.
5669
c71232db
UM
56702012-06-03 Ulrich Müller <ulm@gentoo.org>
5671
5672 * Makefile.in (PAXCTL): Define.
5673 (temacs$(EXEEXT)): Disable memory randomization for the temacs
5674 binary via PaX flags if the paxctl utility is available.
5675 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
5676 Restore PaX flags to their default. (Bug#11398)
5677
383f7350
CY
56782012-06-03 Chong Yidong <cyd@gnu.org>
5679
5680 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
5681 buffer (Bug#11226).
5682
5f2c76c6
CY
56832012-06-03 Chong Yidong <cyd@gnu.org>
5684
5685 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
5686 (note_mode_line_or_margin_highlight): If there is no help echo,
5687 use mode-line-default-help-echo. Handle the case where the mouse
5688 position is past the end of the mode line string.
5689
5690 * buffer.c (buffer_local_value_1): New function, split from
5691 Fbuffer_local_value; can return Qunbound.
5692 (Fbuffer_local_value): Use it.
5693 (Vmode_line_format): Docstring tweaks.
5694
773d47f6
PE
56952012-06-02 Paul Eggert <eggert@cs.ucla.edu>
5696
5697 * sysdep.c (system_process_attributes): Improve comment.
5698
f2d6a3df
SM
56992012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
5700
5701 * keyboard.c: Export real-this-command to Elisp.
5702 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
5703 and DEFVAR it. Update all users.
5704
63810350
PE
57052012-06-02 Paul Eggert <eggert@cs.ucla.edu>
5706
7bd5c1f4
PE
5707 * minibuf.c (Fassoc_string): Remove duplicate declaration.
5708
63810350
PE
5709 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
5710 Convert pctcpu and pctmem to Lisp float properly.
5711 Let the compiler fold better, as 100.0/0x8000 is exact.
5712
a2821611
AS
57132012-06-02 Andreas Schwab <schwab@linux-m68k.org>
5714
5715 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
5716 cons_block.
5717
5fceba1d
PE
57182012-06-01 Paul Eggert <eggert@cs.ucla.edu>
5719
5720 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
5721
c98ff5dd
DA
57222012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
5723
5724 For a 'struct window', replace some Lisp_Object fields to
5725 bitfields where appropriate, remove unused fields.
5726 * window.h (struct window): Remove unused 'last_mark_x' and
5727 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
5728 change it's type from Lisp_Object to bitfield.
5729 Change type of 'force_start', 'optional_new_start',
5730 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
fc0c31f8 5731 fields from Lisp_Object to bitfield. Adjust users accordingly.
c98ff5dd 5732
ca34e0be
PE
57332012-05-31 Paul Eggert <eggert@cs.ucla.edu>
5734
5735 Pacify gcc -Wdouble-precision when using Xaw.
5736 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
5737 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
5738 Use 'float' consistently, rather than 'float' in most places
5739 and 'double' in a couple of places.
5740
efc00ab1 57412012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
5742
5743 * xdisp.c (handle_stop): Detect whether we have overlay strings
5744 loaded by testing it->current.overlay_string_index to be
5745 non-negative, instead of checking whether n_overlay_strings is
5746 positive. (Bug#11587)
5747
efc00ab1 57482012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
5749
5750 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
5751
5752 * doc.c (Fsubstitute_command_keys): Doc fix.
5753
efc00ab1 57542012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
5755
5756 * search.c (search_buffer): Remove calls to
5757 r_alloc_inhibit_buffer_relocation, as it is now called by
5758 maybe_unify_char, which was the cause of relocation of buffer text
5759 in bug#11519.
5760
efc00ab1 57612012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
5762
5763 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
5764 for the duration of call to load_charset, to avoid problems with
5765 callers of maybe_unify_char that access buffer text through C
5766 pointers.
5767
5768 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
5769 decrement the inhibition flag, instead of just setting or
5770 resetting it.
5771
ba93a187
PE
57722012-05-31 Paul Eggert <eggert@cs.ucla.edu>
5773
5774 Remove obsolete '#define static' cruft.
5775 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
5776 This #undef was "temporary" in 2000; it is no longer needed
5777 now that '#define static' has gone away.
5778 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
5779 (gray_bitmap_bits): Remove; no longer needed.
5780 All uses replaced with definiens.
5781 * xterm.c: Include "bitmaps/gray.xbm".
5782
9e4bf381
PE
57832012-05-30 Paul Eggert <eggert@cs.ucla.edu>
5784
5785 Clean up __executable_start, monstartup when --enable-profiling.
5786 The following changes affect the code only when profiling.
5787 * dispnew.c (__executable_start): Rename from safe_bcopy.
5788 Define only on platforms that need it.
5789 * emacs.c: Include <sys/gmon.h> when profiling.
5790 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
5791 (__executable_start): Remove decl, since lisp.h does it now.
5792 (safe_bcopy): Remove decl; no longer has that name.
5793 (main): Coalesce #if into single bit of code, for simplicity.
5794 Cast pointers to uintptr_t, since standard libraries want integers
5795 and not pointers.
5796 * lisp.h (__executable_start): New decl.
5797
32d72c2f
GM
57982012-05-31 Glenn Morris <rgm@gnu.org>
5799
5800 * image.c (Fimagemagick_types): Doc fix.
5801
baac5bc7
JM
58022012-05-30 Jim Meyering <meyering@redhat.com>
5803
5804 * callproc.c (Fcall_process_region): Include directory component
5805 in mkstemp error message (Bug#11586).
5806
72cb32cf
PE
58072012-05-30 Paul Eggert <eggert@cs.ucla.edu>
5808
5809 * alloc.c, lisp.h (make_pure_vector): Now static.
5810
61b108cc
SM
58112012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
5812
5813 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
5814 Move to byte-run.el.
5815 (Fautoload): Do the hash-doc more carefully.
5816 * data.c (Fdefalias): Purify definition, except for keymaps.
5817 (Qdefun): Move from eval.c.
5818 * lisp.h (Qdefun): Remove.
5819 * lread.c (read1): Tiny simplification.
5820
471fe23d
TN
58212012-05-29 Troels Nielsen <bn.troels@gmail.com>
5822
934f3f58 5823 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
5824 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
5825 Bug#9642, but explicitly check that the buffer the overlay would
5826 be moved to is live and rearrange lines to make sure that errors
5827 will not put the overlay in an inconsistent state.
5828 (Fdelete_overlay): Cosmetics.
5829
85d0efd1
EZ
58302012-05-28 Eli Zaretskii <eliz@gnu.org>
5831
5832 * w32term.c (my_bring_window_to_top): New function.
5833 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
5834 could be different from the original one.
5835 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
5836 (Bug#11513)
5837
5838 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
5839 by calling BringWindowToTop.
5840
5841 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
5842 (WM_EMACS_END): Increase by one.
5843
da92a98c
PE
58442012-05-28 Paul Eggert <eggert@cs.ucla.edu>
5845
5846 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
5847 This avoids undefined behavior that might cause the eassert
5848 to not catch an out-of-range value.
5849
74d1f848
JB
58502012-05-28 Juanma Barranquero <lekktu@gmail.com>
5851
5852 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
5853 Update dependencies.
5854
9e1a06fc
EZ
58552012-05-27 Eli Zaretskii <eliz@gnu.org>
5856
5857 * bidi.c (bidi_mirror_char): Fix last change.
5858
f3dd7312
AS
58592012-05-27 Andreas Schwab <schwab@linux-m68k.org>
5860
5861 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
5862 when referring to sectname field in printf format.
5863
81899c91
PE
58642012-05-27 Paul Eggert <eggert@cs.ucla.edu>
5865
57b81a9f
PE
5866 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
5867 Only r_alloc_inhibit_buffer_relocation needed to be added;
5868 the others were already declared.
5869
81899c91
PE
5870 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
5871 before checking whether it's out of range. Put the check inside
5872 eassert. See
5873 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
5874
33017faf 58752012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
5876
5877 * callproc.c (Fcall_process): Restore a line that was accidentally
5878 commented out in the 2011-02-13 change (bug#11547).
5879
33017faf 58802012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
5881
5882 * lisp.h [REL_ALLOC]: Add prototypes for external functions
5883 defined on ralloc.c.
5884
5885 * buffer.c [REL_ALLOC]: Remove prototypes of
5886 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
5887 they are now on lisp.h.
5888
5889 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
5890
5891 * search.c (search_buffer): Use it to inhibit relocation of buffer
5892 text while re_search_2 is doing its job, because re_search_2 is
5893 passed C pointers to buffer text. (Bug#11519)
5894
23415acf
EZ
5895 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
5896 Update value to 24.
5897
44e27368
EZ
5898 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
5899 state after an additional call to move_it_in_display_line_to, keep
5900 the values of it->max_ascent and it->max_descent found for the
5901 entire line.
5902 (pos_visible_p): Revert the comparison against bottom_y to what it
5903 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
5904 (Bug#11464)
5905
c1892f11
PE
59062012-05-26 Paul Eggert <eggert@cs.ucla.edu>
5907
5908 Fix coding-related core dumps with gcc -ftrapv.
5909 The code was computing A - B, where A and B are pointers, and B is
5910 random garbage. This can lead to core dumps on platforms that
5911 have special pointer registers, and it also leads to core dumps on
5912 x86-64 when compiled with gcc -ftrapv. The fix is to compute
5913 A - B only when B is initialized properly.
5914 * coding.c (coding_set_source, coding_set_destination): Return void.
5915 (coding_change_source, coding_change_destinations): New functions,
5916 with the old behaviors of coding_set_source and coding_set_destination.
5917 All callers that need an offset changed to use these new functions.
5918
eb7afdad
GM
59192012-05-26 Glenn Morris <rgm@gnu.org>
5920
5921 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
5922
f12fdf02
EZ
59232012-05-26 Eli Zaretskii <eliz@gnu.org>
5924
53a63be6 5925 Extend mouse support on W32 text-mode console.
61b108cc
SM
5926 * xdisp.c (draw_row_with_mouse_face):
5927 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 5928
eb3f6f01 5929 * w32console.c: Include window.h.
61b108cc
SM
5930 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
5931 New functions.
eb3f6f01
EZ
5932 (initialize_w32_display): Initialize mouse-highlight data.
5933
53a63be6
EZ
5934 * w32inevt.c: Include termchar.h and window.h.
5935 (do_mouse_event): Support mouse-autoselect-window. When the mouse
5936 moves, call note_mouse_highlight. If help_echo changed, call
5937 gen_help_event to produce help-echo message in the echo area.
5938 Call clear_mouse_face if mouse_face_hidden is set in the mouse
5939 highlight info.
5940
4cfd81f6
PE
59412012-05-26 Paul Eggert <eggert@cs.ucla.edu>
5942
5943 * lread.c (read1): Simplify slightly to avoid an overflow warning
5944 with GCC 4.7.0 on x86-64.
5945
4446092a
EZ
59462012-05-26 Eli Zaretskii <eliz@gnu.org>
5947
5948 * bidi.c (bidi_mirror_char): Revert last change: an int is
5949 definitely wide enough here.
5950
42b2a986 59512012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 5952
42b2a986 5953 Fix integer width and related bugs (Bug#9874).
eb106a49 5954 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
5955 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
5956 (string_bytes, check_sblock, allocate_string_data):
5957 (compact_small_strings, Fmake_bool_vector, make_string)
5958 (make_unibyte_string, make_multibyte_string)
5959 (make_string_from_bytes, make_specified_string)
5960 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
5961 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
5962 (mark_vectorlike):
5963 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5964 (allocate_pseudovector):
5965 Use int, not EMACS_INT, where int is wide enough.
5966 (inhibit_garbage_collection, Fgarbage_collect):
5967 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5968 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
5969 int might not be wide enough.
5970 (bidi_cache_search, bidi_cache_find, bidi_init_it)
5971 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
5972 (bidi_at_paragraph_end, bidi_find_paragraph_start)
5973 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5974 (bidi_level_of_next_char, bidi_move_to_visually_next):
5975 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5976 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
5977 (Fkill_buffer, Fset_buffer_major_mode)
5978 (advance_to_char_boundary, Fbuffer_swap_text)
5979 (Fset_buffer_multibyte, overlays_at, overlays_in)
5980 (overlay_touches_p, struct sortvec, record_overlay_string)
5981 (overlay_strings, recenter_overlay_lists)
5982 (adjust_overlays_for_insert, adjust_overlays_for_delete)
5983 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
5984 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
5985 (Foverlay_recenter, last_overlay_modification_hooks_used)
5986 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
5987 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
5988 (validate_region): Omit unnecessary test for b <= e,
5989 since that's guaranteed by the previous test.
d311d28c
PE
5990 (adjust_overlays_for_delete): Avoid pos + length overflow.
5991 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
5992 (report_overlay_modification):
5993 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5994 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
5995 Omit pointer cast, which isn't needed anyway, and doesn't work
5996 after the EMACS_INT -> ptrdiff_t change.
02481186 5997 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
5998 * buffer.h: Adjust decls to match defn changes elsewhere.
5999 (struct buffer_text, struct buffer):
6000 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6001 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
6002 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
6003 not int, to avoid needless 32-bit limit on 64-bit hosts.
6004 (exec_byte_code): Use tighter memory-full test, one that checks
6005 for alloca overflow. Don't compute the address of the object just
6006 before an array, as that's not portable. Use EMACS_INT, not
6007 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
6008 * callint.c (Fcall_interactively):
6009 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6010 * callproc.c (call_process_kill, Fcall_process):
6011 Don't assume pid_t fits into an Emacs fixnum.
6012 (call_process_cleanup, Fcall_process, child_setup):
6013 Don't assume pid_t fits into int.
6014 (call_process_cleanup, Fcall_process, delete_temp_file)
6015 (Fcall_process_region):
6016 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6017 (Fcall_process): Simplify handling of volatile integers.
6018 Use int, not EMACS_INT, where int will do.
6019 * casefiddle.c (casify_object, casify_region, operate_on_word)
6020 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
6021 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6022 (casify_object): Avoid integer overflow when overallocating buffer.
6023 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 6024 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
6025 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
6026 * category.h (CATEGORYP): Don't assume arg is nonnegative.
6027 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
6028 integers are now checked earlier. All uses replaced with XINT.
6029 (ccl_driver):
6030 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6031 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
6032 (ccl_driver, Fregister_code_conversion_map):
6033 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
6034 (resolve_symbol_ccl_program): Check that vector header is in range.
6035 Always copy the vector, so that we can check its contents reliably
6036 now rather than having to recheck each instruction as it's being
6037 executed. Check that vector words fit in 'int'.
6038 (ccl_get_compiled_code, Fregister_ccl_program)
6039 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
6040 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
6041 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
6042 contents are in range.
6043 (Fccl_execute_on_string): Check that status is in range.
6044 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
6045 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
6046 Accept and return EMACS_INT, not int, because callers can pass values
6047 out of 'int' range.
6048 (c_string_width, strwidth, lisp_string_width, chars_in_text)
6049 (multibyte_chars_in_text, parse_str_as_multibyte)
6050 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
6051 (str_as_unibyte, str_to_unibyte, string_count_byte8)
6052 (string_escape_byte8, Fget_byte):
6053 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 6054 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
6055 avoid mishandling large integers.
6056 * character.h: Adjust decls to match defn changes elsewhere.
6057 * charset.c (load_charset_map_from_file, find_charsets_in_text)
6058 (Ffind_charset_region):
6059 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6060 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
6061 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 6062 Don't assume fixnum fits in int.
d311d28c
PE
6063 (load_charset_map_from_vector, Fmap_charset_chars):
6064 Remove now-unnecessary CHECK_NATNUMs.
6065 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
6066 Don't rely on undefined behavior with signed left shift overflow.
6067 Don't assume unsigned int fits into fixnum, or that fixnum fits
6068 into unsigned int. Don't require max_code to be a valid fixnum;
6069 that's not true for gb10830 4-byte on a 32-bit host. Allow
6070 invalid_code to be a cons, for the same reason. Require code_offset
6071 to be a character. Avoid int overflow if max_char is close
6072 to INT_MAX.
6073 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
6074 this is intended anyway and avoids some undefined behavior.
6075 (load_charset_map): Pass unsigned, not int, as 2nd arg of
6076 INDEX_TO_CODE_POINT, as that's what it expects.
6077 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
6078 * charset.h (DECODE_CHAR): Return int, not unsigned;
6079 this is what was intended anyway, and it avoids undefined behavior.
6080 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
6081 integer-overflow issues.
6082 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
6083 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
6084 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
6085 * chartab.c (Fmake_char_table, Fset_char_table_range)
6086 (uniprop_get_decoder, uniprop_get_encoder):
6087 Don't assume fixnum fits in int.
6088 * cmds.c (move_point): New function, that does the gist of
6089 Fforward_char and Fbackward_char, but does so while checking
6090 for integer overflow more accurately.
c96e5d6a 6091 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
6092 (Fforward_line, Fend_of_line, internal_self_insert)
6093 (internal_self_insert):
6094 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6095 Fix a FIXME, by checking for integer overflow when calculating
6096 target_clm and actual_clm.
6097 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 6098 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
6099 (ASSURE_DESTINATION, coding_alloc_by_realloc)
6100 (coding_alloc_by_making_gap, alloc_destination)
6101 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
6102 (encode_coding_utf_16, detect_coding_emacs_mule)
6103 (decode_coding_emacs_mule, encode_coding_emacs_mule)
6104 (detect_coding_iso_2022, decode_coding_iso_2022)
6105 (encode_invocation_designation, encode_designation_at_bol)
6106 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6107 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
6108 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
6109 (encode_coding_ccl, encode_coding_raw_text)
6110 (detect_coding_charset, decode_coding_charset)
6111 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
6112 (produce_composition, produce_charset, produce_annotation)
6113 (decode_coding, handle_composition_annotation)
6114 (handle_charset_annotation, consume_chars, decode_coding_gap)
6115 (decode_coding_object, encode_coding_object, detect_coding_system)
6116 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
6117 (code_convert_region, code_convert_string)
8f50130c
PE
6118 (Fdefine_coding_system_internal)
6119 (coding_set_source, coding_set_destination):
d311d28c
PE
6120 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6121 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
6122 (Fdefine_coding_system_internal):
6123 Don't assume fixnums fit in int.
6124 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 6125 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
6126 (Funencodable_char_position, Fcheck_coding_systems_region)
6127 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 6128 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 6129 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 6130 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 6131 Don't access memory outside of the args array.
d311d28c 6132 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
6133 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
6134 result of ENCODE_CHAR.
d311d28c
PE
6135 * coding.h: Adjust decls to match defn changes elsewhere.
6136 (struct coding_system):
6137 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6138 * composite.c (get_composition_id, find_composition)
6139 (run_composition_function, update_compositions)
6140 (compose_text, composition_gstring_put_cache)
6141 (composition_gstring_p, composition_gstring_width)
6142 (fill_gstring_header, fill_gstring_body, autocmp_chars)
6143 (composition_compute_stop_pos, composition_reseat_it)
6144 (composition_update_it, struct position_record)
6145 (find_automatic_composition, composition_adjust_point)
6146 (Fcomposition_get_gstring, Ffind_composition_internal):
6147 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6148 (update_compositions):
6149 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6150 * composite.h: Adjust decls to match defn changes elsewhere.
6151 (struct composition):
6152 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6153 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
6154 Do not attempt to compute the address of the object just before a
6155 buffer; this is not portable.
6156 (Faref, Faset):
6157 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6158 (Faset): Use int, not EMACS_INT, where int is wide enough.
6159 (Fstring_to_number): Don't assume fixnums fit in int.
6160 (Frem): Don't assume arg is nonnegative.
6161 * dbusbind.c (xd_append_arg): Check for integers out of range.
6162 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 6163 (extract_signed, extract_unsigned): New functions.
243e0530
PE
6164 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
6165 (xd_get_connection_references): Return ptrdiff_t, not int.
6166 All uses changed.
6167 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
6168 (xd_read_message_1):
6169 Use int, not unsigned, where the dbus API uses int.
6170 (Fdbus_message_internal): Don't overflow mtype.
6171 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
6172 * dired.c (directory_files_internal, file_name_completion, scmp)
6173 (file_name_completion_stat):
6174 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6175 (file_name_completion): Don't overflow matchcount.
6176 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
6177 * dispextern.h: Adjust decls to match defn changes elsewhere.
6178 (struct text_pos, struct glyph, struct bidi_saved_info)
6179 (struct bidi_string_data, struct bidi_it, struct composition_it)
6180 (struct it):
6181 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6182 (struct display_pos, struct composition_it, struct it):
6183 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6184 * dispnew.c (increment_matrix_positions)
6185 (increment_row_positions, mode_line_string)
6186 (marginal_area_string):
6187 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 6188 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
6189 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6190 (duration_to_sec_usec): New function, to check for overflow better.
6191 (Fsleep_for, sit_for): Use it.
6192 * doc.c (get_doc_string, store_function_docstring):
6193 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6194 (get_doc_string, Fsnarf_documentation):
6195 Use int, not EMACS_INT, where int is wide enough.
6196 (get_doc_string):
6197 Use SAFE_ALLOCA, not alloca.
6198 Check for overflow when converting EMACS_INT to off_t.
6199 * doprnt.c (doprnt):
6200 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6201 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
6202 Don't assume uid_t fits into fixnum.
6203 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
6204 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
6205 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
6206 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
6207 (general_insert_function)
6208 (Finsert_char, make_buffer_string, make_buffer_string_both)
6209 (update_buffer_properties, Fbuffer_substring)
6210 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
6211 (Fsubst_char_in_region, check_translation)
6212 (Ftranslate_region_internal, save_restriction_restore, Fformat)
6213 (transpose_markers, Ftranspose_regions):
6214 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6215 (clip_to_bounds): Move to lisp.h as an inline function).
6216 (Fconstrain_to_field): Don't assume integers are nonnegative.
6217 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
6218 (Fsubst_char_in_region, Fsave_restriction):
6219 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6220 (Femacs_pid): Don't assume pid_t fits into fixnum.
6221 (lo_time): Use int, not EMACS_INT, when int suffices.
6222 (lisp_time_argument): Check for usec out of range.
6223 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
6224 (Fuser_login_name, Fuser_full_name): Signal an error
6225 if a uid argument is out of range, rather than relying on
6226 undefined behavior.
c8d5c857
PE
6227 (Fformat_time_string): Remove now-unnecessary check.
6228 lisp_time_argument checks for out-of-range usec now.
243e0530 6229 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
6230 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
6231 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
6232 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
6233 (init_cmdargs, Fdump_emacs):
6234 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6235 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
6236 the bottom (typically) 32 bits of the fixnum.
6237 * eval.c (specpdl_size, call_debugger):
6238 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6239 (when_entered_debugger, Fbacktrace_debug):
6240 Don't assume fixnum can fit in int.
6241 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
6242 the object just before a buffer; this is not portable.
6243 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
6244 (grow_specpdl, unbind_to):
6245 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6246 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
6247 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 6248 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
6249 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
6250 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
6251 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6252 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
6253 (a_write, e_write):
6254 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6255 (Fcopy_file, non_regular_nbytes, read_non_regular)
6256 (Finsert_file_contents):
6257 Use int, not EMACS_INT, where int is wide enough.
6258 (READ_BUF_SIZE): Verify that it fits in int.
6259 (Finsert_file_contents): Check that counts are in proper range,
6260 rather than assuming fixnums fit into ptrdiff_t etc.
6261 Don't assume fixnums fit into int.
125b3835 6262 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
6263 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
6264 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
6265 (string_char_to_byte, string_byte_to_char)
6266 (string_make_multibyte, string_to_multibyte)
6267 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
6268 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
6269 (substring_both, Fdelete, internal_equal, Ffillarray)
6270 (Fclear_string, mapcar1)
6271 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
6272 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
6273 (larger_vector, make_hash_table, maybe_resize_hash_table)
6274 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
6275 (Fmaphash, secure_hash):
6276 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6277 (concat): Check for string index and length overflow.
6278 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
6279 (Frequire):
6280 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6281 (larger_vector): New API (vec, incr_min, size_max) replaces old
6282 one (vec, new_size, init). This catches size overflow.
6283 INIT was removed because it was always Qnil.
6284 All callers changed.
6285 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
6286 the upper bound on a hash table index size.
6287 (make_hash_table, maybe_resize_hash_table): Use it.
6288 (secure_hash): Computer start_byte and end_byte only after
6289 they're known to be in ptrdiff_t range.
6290 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
6291 (Ffont_get_glyphs, Ffont_at):
6292 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6293 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
6294 (Flist_fonts, Fopen_font):
6295 Don't assume fixnum can fit in int.
6296 (check_gstring): Don't assume index can fit in int.
6297 (font_match_p): Check that fixnum is a character, not a nonnegative
6298 fixnum, since the later code needs to stuff it into an int.
6299 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
6300 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
6301 conversion overflow issues.
6302 (Fopen_font): Check for integer out of range.
6303 (Ffont_get_glyphs): Don't assume index can fit in int.
6304 * font.h: Adjust decls to match defn changes elsewhere.
6305 * fontset.c (reorder_font_vector): Redo score calculation to avoid
6306 integer overflow.
6307 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
6308 printmax_t, where ptrdiff_t is wide enough.
6309 (Finternal_char_font):
6310 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6311 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
6312 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
6313 (Fset_frame_position, x_set_frame_parameters)
6314 (x_set_line_spacing, x_set_border_width)
6315 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
6316 Check that fixnums are in proper range for system types.
6317 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
6318 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6319 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
6320 Use SAFE_ALLOCA_LISP, not alloca.
6321 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
6322 intptr_t is wide enough.
6323 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
6324 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
6325 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
6326 Check for fixnum out of range.
6327 * ftfont.c (ftfont_list): Don't assume index fits in int.
6328 Check that fixnums are in proper range for system types.
6329 (ftfont_shape_by_flt):
6330 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
6331 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6332 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6333 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
6334 Check that fixnums are in proper range for system types.
6335 * gnutls.h: Adjust decls to match defn changes elsewhere.
6336 * gtkutil.c (xg_dialog_run):
6337 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6338 (update_frame_tool_bar):
6339 Check that fixnums are in proper range for system types.
6340 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 6341 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
6342 * indent.c (last_known_column, last_known_column_point):
6343 (current_column_bol_cache):
6344 (skip_invisible, current_column, check_display_width):
6345 (check_display_width, scan_for_column, current_column_1)
6346 (Findent_to, Fcurrent_indentation, position_indentation)
6347 (indented_beyond_p, Fmove_to_column, compute_motion):
6348 (Fcompute_motion, Fvertical_motion):
6349 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6350 (last_known_column_modified): Use EMACS_INT, not int.
6351 (check_display_width):
6352 (Fcompute_motion):
6353 Check that fixnums and floats are in proper range for system types.
6354 (compute_motion): Don't assume index or fixnum fits in int.
6355 (compute_motion, Fcompute_motion):
6356 Use int, not EMACS_INT, when it is wide enough.
6357 (vmotion): Omit local var start_hpos that is always 0; that way
6358 we don't need to worry about overflow in expressions involving it.
6359 * indent.h: Adjust decls to match defn changes elsewhere.
6360 (struct position):
6361 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6362 Use int, not EMACS_INT, where int is wide enough.
6363 Remove unused members ovstring_chars_done and tab_offset;
6364 all uses removed.
6365 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
6366 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
6367 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
6368 (make_gap, copy_text, insert, insert_and_inherit)
6369 (insert_before_markers, insert_before_markers_and_inherit)
6370 (insert_1, count_combining_before, count_combining_after)
6371 (insert_1_both, insert_from_string)
6372 (insert_from_string_before_markers, insert_from_string_1)
6373 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
6374 (adjust_after_replace, adjust_after_insert, replace_range)
6375 (replace_range_2, del_range, del_range_1, del_range_byte)
6376 (del_range_both, del_range_2, modify_region)
6377 (prepare_to_modify_buffer, signal_before_change)
6378 (signal_after_change, Fcombine_after_change_execute):
6379 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6380 * intervals.c (traverse_intervals, rotate_right, rotate_left)
6381 (balance_an_interval, split_interval_right, split_interval_left)
6382 (find_interval, next_interval, update_interval)
6383 (adjust_intervals_for_insertion, delete_node, delete_interval)
6384 (interval_deletion_adjustment, adjust_intervals_for_deletion)
6385 (static_offset_intervals, offset_intervals)
6386 (merge_interval_right, merge_interval_left, make_new_interval)
6387 (graft_intervals_into_buffer, temp_set_point_both)
6388 (temp_set_point, set_point, adjust_for_invis_intang)
6389 (set_point_both, move_if_not_intangible, get_property_and_range)
6390 (get_local_map, copy_intervals, copy_intervals_to_string)
6391 (compare_string_intervals, set_intervals_multibyte_1):
6392 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6393 * intervals.h: Adjust decls to match defn changes elsewhere.
6394 (struct interval):
6395 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6396 * keyboard.c (this_command_key_count, this_single_command_key_start)
6397 (before_command_key_count, before_command_echo_length, echo_now)
6398 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
6399 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
6400 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
6401 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
6402 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6403 (last_non_minibuf_size, last_point_position, echo_truncate)
6404 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
6405 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
6406 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
6407 (stuff_buffered_input):
6408 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6409 (last_auto_save, command_loop_1, read_char):
6410 Use EMACS_INT, not int, to avoid integer overflow.
6411 (record_char): Avoid overflow in total_keys computation.
6412 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
6413 * keyboard.h: Adjust decls to match defn changes elsewhere.
6414 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
6415 (Fkey_description, Fdescribe_vector, Flookup_key):
6416 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6417 (click_position): New function, to check that positions are in range.
6418 (Fcurrent_active_maps):
6419 (describe_command):
6420 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6421 (Faccessible_keymaps, Fkey_description):
6422 (preferred_sequence_p):
6423 Don't assume fixnum can fit into int.
6424 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
6425 Check for integer overflow in size calculations.
6426 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
6427 avoid mishandling large integers.
6428 * lisp.h: Adjust decls to match defn changes elsewhere.
6429 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
6430 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
6431 (struct Lisp_Marker):
6432 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6433 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
6434 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
6435 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
6436 All callers changed.
6437 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
6438 Assume the arg has valid form, since it always does.
6439 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
6440 unsigned integer system type.
6441 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
6442 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
6443 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6444 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
6445 (duration_to_sec_usec): New decl.
6446 * lread.c (read_from_string_index, read_from_string_index_byte)
6447 (read_from_string_limit, readchar, unreadchar, openp)
6448 (read_internal_start, read1, oblookup):
6449 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6450 (Fload, readevalloop, Feval_buffer, Feval_region):
6451 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6452 (openp): Check for out-of-range argument to 'access'.
6453 (read1): Use int, not EMACS_INT, where int is wide enough.
6454 Don't assume fixnum fits into int.
6efdadfd 6455 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
6456 (read_filtered_event): Use duration_to_sec_usec
6457 to do proper overflow checking on durations.
d311d28c
PE
6458 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
6459 in size calculation.
6460 (Fexecute_kbd_macro):
6461 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6462 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
6463 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
6464 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
6465 (set_marker_both, set_marker_restricted_both, marker_position)
6466 (marker_byte_position, Fbuffer_has_markers_at):
6467 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6468 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 6469 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
6470 It now merely ensures that the menu is large enough, without
6471 necessarily growing it, as this avoids some integer overflow issues.
6472 All callers changed.
6473 (keymap_panes, parse_single_submenu, Fx_popup_menu):
6474 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6475 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
6476 Use SAFE_ALLOCA_LISP, not alloca.
6477 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
6478 to EMACS_INT. Check that fixnums are in proper range for system types.
6479 * minibuf.c (minibuf_prompt_width, string_to_object)
6480 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
6481 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
6482 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6483 (get_minibuffer, read_minibuf_unwind):
6484 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6485 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
6486 this simplifies overflow checking. All callers changed.
6487 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
6488 (Ftest_completion):
6489 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6490 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
6491 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
6492 Check that fixnums are in proper range for system types.
6493 (Fx_create_frame, Fx_show_tip):
6494 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6495 * nsfont.m (ns_findfonts, nsfont_list_family):
6496 Don't assume fixnum fits in long.
6497 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
6498 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6499 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
6500 wide enough.
17fdb222 6501 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
6502 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6503 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
6504 (PRINTDECLARE, PRINTPREPARE):
6505 (strout, print_string):
6506 (print, print_preprocess, print_check_string_charset_prop)
6507 (print_object):
6508 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6509 (PRINTDECLARE):
6510 (temp_output_buffer_setup, Fprin1_to_string, print_object):
6511 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6512 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 6513 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 6514 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
6515 (print_error_message): Use SAFE_ALLOCA, not alloca.
6516 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
6517 (print_depth, new_backquote_output, print_number_index):
6518 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
6519 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
6520 (Fset_process_window_size, Fformat_network_address)
6521 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 6522 (sigchld_handler):
d311d28c 6523 Check that fixnums are in proper range for system types.
d44287d4 6524 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
6525 Check for process-ids out of pid_t range rather than relying on
6526 undefined behavior.
e4d81efc 6527 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
6528 (Fformat_network_address, read_process_output, send_process)
6529 (Fprocess_send_region, status_notify):
6530 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6531 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
6532 (wait_reading_process_output, read_process_output, exec_sentinel):
6533 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6534 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
6535 (Faccept_process_output): Use duration_to_sec_usec to do proper
6536 overflow checking on durations.
dde14581
PE
6537 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
6538 Don't assume pid_t fits in int.
02481186
PE
6539 * process.h (struct Lisp_Process): Members tick and update_tick
6540 are now of type EMACS_INT, not int.
b62b53e8
PE
6541 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
6542 configured --with-wide-int.
d311d28c
PE
6543 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
6544 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
6545 * search.c (looking_at_1, string_match_1):
6546 (fast_string_match, fast_c_string_match_ignore_case)
6547 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
6548 (scan_newline, find_before_next_newline, search_command)
6549 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
6550 (set_search_regs, wordify):
6551 (Freplace_match):
6552 (Fmatch_data):
6553 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6554 (string_match_1, search_buffer, set_search_regs):
6555 (Fmatch_data):
6556 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6557 (wordify): Check for overflow in size calculation.
6558 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
6559 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
6560 Check that fixnums are in proper range for system types.
6561 * sound.c (struct sound_device)
6562 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
6563 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6564 (Fplay_sound_internal):
6565 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 6566 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
6567 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
6568 (Fparse_partial_sexp):
6569 Don't assume fixnums can fit in int.
6570 (struct lisp_parse_state, find_start_pos, find_start_value)
6571 (find_start_value_byte, find_start_begv)
6572 (update_syntax_table, char_quoted, dec_bytepos)
6573 (find_defun_start, prev_char_comend_first, back_comment):
6574 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
6575 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
6576 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6577 (Finternal_describe_syntax_value): Check that match_lisp is a
6578 character, not an integer, since the code stuffs it into int.
6579 (scan_words, scan_sexps_forward):
6580 Check that fixnums are in proper range for system types.
6581 (Fforward_word):
6582 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6583 (scan_sexps_forward):
6584 Use CHARACTERP, not INTEGERP, since the value must fit into int.
6585 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
6586 * syntax.h: Adjust decls to match defn changes elsewhere.
6587 (struct gl_state_s):
6588 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
6589 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
6590 MOST_POSITIVE_FIXNUM.
d311d28c
PE
6591 * sysdep.c (wait_for_termination_1, wait_for_termination)
6592 (interruptible_wait_for_termination, mkdir):
6593 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
6594 (emacs_read, emacs_write):
6595 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
6596 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
6597 and double all fit in int.
d311d28c
PE
6598 * term.c (set_tty_color_mode):
6599 Check that fixnums are in proper range for system types.
6600 * termhooks.h (struct input_event):
6601 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6602 * textprop.c (validate_interval_range, interval_of)
6603 (Fadd_text_properties, set_text_properties_1)
6604 (Fremove_text_properties, Fremove_list_of_text_properties)
6605 (Ftext_property_any, Ftext_property_not_all)
6606 (copy_text_properties, text_property_list, extend_property_ranges)
6607 (verify_interval_modification):
6608 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6609 (Fnext_single_char_property_change)
6610 (Fprevious_single_char_property_change):
6611 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
6612 (copy_text_properties):
6613 Check for integer overflow in index calculation.
d311d28c
PE
6614 * undo.c (last_boundary_position, record_point, record_insert)
6615 (record_delete, record_marker_adjustment, record_change)
6616 (record_property_change):
6617 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6618 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
6619 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6620 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
6621 (Fx_hide_tip, Fx_file_dialog):
6622 * w32menu.c (set_frame_menubar):
6623 Use ptrdiff_t, not int, for consistency with rest of code.
6624 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
6625 (select_window, Fdelete_other_windows_internal)
6626 (window_scroll_pixel_based, window_scroll_line_based)
6627 (Frecenter, Fset_window_configuration):
6628 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6629 (Fset_window_hscroll, run_window_configuration_change_hook)
6630 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 6631 (Fscroll_other_window, Frecenter):
d311d28c
PE
6632 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6633 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
6634 Don't assume fixnum fits in int.
6635 (Fset_window_scroll_bars):
6636 Check that fixnums are in proper range for system types.
6637 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
6638 (string_pos, c_string_pos, number_of_chars, init_iterator)
6639 (in_ellipses_for_invisible_text_p, init_from_display_pos)
6640 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
6641 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
6642 (face_before_or_after_it_pos, handle_invisible_prop)
6643 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
6644 (display_prop_intangible_p, string_buffer_position_lim)
6645 (string_buffer_position, handle_composition_prop, load_overlay_strings)
6646 (get_overlay_strings_1, get_overlay_strings)
6647 (iterate_out_of_display_property, forward_to_next_line_start)
6648 (back_to_previous_visible_line_start, reseat, reseat_to_string)
6649 (get_next_display_element, set_iterator_to_next)
6650 (get_visually_first_element, compute_stop_pos_backwards)
6651 (handle_stop_backwards, next_element_from_buffer)
6652 (move_it_in_display_line_to, move_it_in_display_line)
6653 (move_it_to, move_it_vertically_backward, move_it_by_lines)
6654 (add_to_log, message_dolog, message_log_check_duplicate)
6655 (message2, message2_nolog, message3, message3_nolog
6656 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
6657 (current_message_1, truncate_echo_area, truncate_message_1)
6658 (set_message, set_message_1, store_mode_line_noprop)
6659 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
6660 (text_outside_line_unchanged_p, check_point_in_composition)
6661 (reconsider_clip_changes)
6662 (redisplay_internal, set_cursor_from_row, try_scrolling)
6663 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
6664 (redisplay_window, find_last_unchanged_at_beg_row)
6665 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
6666 (trailing_whitespace_p, find_row_edges, display_line)
6667 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
6668 (display_mode_element, store_mode_line_string)
6669 (pint2str, pint2hrstr, decode_mode_spec)
6670 (display_count_lines, display_string, draw_glyphs)
6671 (x_produce_glyphs, x_insert_glyphs)
6672 (rows_from_pos_range, mouse_face_from_buffer_pos)
6673 (fast_find_string_pos, mouse_face_from_string_pos)
6674 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6675 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6676 (safe_call, init_from_display_pos, handle_fontified_prop)
6677 (handle_single_display_spec, load_overlay_strings)
6678 (with_echo_area_buffer, setup_echo_area_for_printing)
6679 (display_echo_area, echo_area_display)
6680 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
6681 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
6682 (redisplay_window, dump_glyph_row, display_mode_line)
6683 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 6684 (handle_display_spec, display_prop_string_p):
d311d28c
PE
6685 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6686 (handle_single_display_spec, build_desired_tool_bar_string)
6687 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
6688 (get_specified_cursor_type):
6689 Check that fixnums are in proper range for system types.
6690 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
6691 (Flookup_image_map):
6692 Don't assume fixnums fit in int.
6693 (compare_overlay_entries):
6694 Avoid mishandling comparisons due to subtraction overflow.
6695 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
6696 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
6697 (handle_tool_bar_click):
6698 Use int, not unsigned, since we prefer signed and the signedness
6699 doesn't matter here.
6700 (get_next_display_element, next_element_from_display_vector):
6701 Use int, not EMACS_INT, when int is wide enough.
6702 (start_hourglass): Use duration_to_sec_usec to do proper
6703 overflow checking on durations.
6704 * xfaces.c (Fbitmap_spec_p):
6705 Check that fixnums are in proper range for system types.
6706 (compare_fonts_by_sort_order):
6707 Avoid mishandling comparisons due to subtraction overflow.
6708 (Fx_family_fonts, realize_basic_faces):
6709 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6710 (Fx_family_fonts):
6711 Don't assume fixnum fits in int.
6712 Use SAFE_ALLOCA_LISP, not alloca.
6713 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
6714 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
6715 (face_at_buffer_position, face_for_overlay_string)
6716 (face_at_string_position):
6717 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6718 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
6719 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
6720 (Fx_show_tip):
6721 Check that fixnums are in proper range for system types.
6722 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
6723 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
6724 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6725 (Fx_change_window_property): Don't assume fixnums fit in int.
6726 * xfont.c (xfont_chars_supported):
6727 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6728 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
6729 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
6730 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6731 * xml.c (parse_region):
6732 * xrdb.c (magic_file_p):
6733 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6734 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
6735 (x_get_local_selection, x_reply_selection_request)
6736 (x_handle_selection_request, wait_for_property_change):
6737 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6738 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
6739 short is wide enough.
6740 (x_send_client_event): Don't assume fixnum fits in int.
6741 * xterm.c (x_x_to_emacs_modifiers):
6742 Don't assume EMACS_INT overflows nicely into int.
6743 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
6744 may come from Lisp.
6745 (handle_one_xevent): NATNUMP can eval its arg twice.
6746 (x_connection_closed):
6747 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6748 * xterm.h: Adjust decls to match defn changes elsewhere.
6749 (struct scroll_bar): Use struct vectorlike_header
6750 rather than rolling our own approximation.
6751 (SCROLL_BAR_VEC_SIZE): Remove; not used.
6752
c6574eb5
GM
67532012-05-25 Glenn Morris <rgm@gnu.org>
6754
6755 * lisp.mk (lisp): Update for more files being compiled now.
6756
e8d32c7e
SM
67572012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
6758
48def666
SM
6759 * lread.c: Remove `read_pure' which makes no difference.
6760 (read_pure): Remove var.
6761 (unreadpure): Remove function.
6762 (readevalloop): Don't call read_list with -1 flag.
6763 (read1, read_vector): Don't test read_pure any more.
6764 (read_list): Simplify.
6765
e8d32c7e
SM
6766 * fileio.c, character.h: Minor style tweaks.
6767
4b2addb7
DA
67682012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
6769
6770 * window.h (clip_changed): Remove useless declaration.
6771
584461b2
JB
67722012-05-22 Juanma Barranquero <lekktu@gmail.com>
6773
6774 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
6775 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
6776
34374650
PE
67772012-05-22 Paul Eggert <eggert@cs.ucla.edu>
6778
6779 Remove src/m/*.
6780 This directory predates autoconf and is no longer needed nowadays.
6781 Move its few remaining bits of functionality to where they're needed.
6782 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
6783 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
6784 * m/template.h: Remove.
6785 * Makefile.in (M_FILE): Remove. All uses removed.
6786 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
6787 * lisp.h (USE_LSB_TAG):
6788 * mem-limits.h (EXCEEDS_LISP_PTR):
6789 Use VAL_MAX, not VALBITS, in #if.
6790 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
6791 (EMACS_UINT): Define unconditionally now.
6792 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
6793 (BITS_PER_EMACS_INT): New constants, replacing
6794 what used to be in config.h, but not useful in #if.
6795 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
6796 define them any more.
6797 (VAL_MAX): New macro.
6798 (VALMASK): Use it.
6799 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
6800 BITS_PER_EMACS_INT, in #if.
6801 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
6802 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
6803 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
6804 * s/ms-w32.h (DATA_START):
6805 Move here from removed file m/intel386.h.
6806 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
6807 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
6808
261cb4bb
PE
68092012-05-21 Paul Eggert <eggert@cs.ucla.edu>
6810
6811 Assume C89 or later.
6812 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
6813 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
6814 (xrealloc):
6815 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
6816 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
6817 * textprop.c, tparam.c (NULL): Remove.
6818 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
6819 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
6820 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
6821 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
6822 * xterm.c (input_signal_count): Assume volatile works.
6823
ff23cd9f
KB
68242012-05-21 Ken Brown <kbrown@cornell.edu>
6825
6826 * xgselect.c (xg_select): Fix first argument in call to 'select'
6827 (bug#11508).
6828
1b170bc6
KB
68292012-05-20 Ken Brown <kbrown@cornell.edu>
6830
6831 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 6832 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 6833
b2f4d39f
KB
68342012-05-19 Ken Brown <kbrown@cornell.edu>
6835
6836 * xfns.c (x_in_use): Remove `static' qualifier.
6837 * xterm.h (x_in_use): Declare.
6838 * xgselect.c: Include xterm.h.
6839 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
6840 and `display_arg' (bug#9754).
6841
003fdae2
PE
68422012-05-19 Paul Eggert <eggert@cs.ucla.edu>
6843
9232a6d9
PE
6844 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
6845
003fdae2
PE
6846 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
6847 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
6848
784b56e2
EZ
68492012-05-18 Eli Zaretskii <eliz@gnu.org>
6850
6851 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
6852
6853 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 6854 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
6855
6856 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
6857 reference to image_cache->refcount.
6858 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
6859
a0a79cde
JL
68602012-05-17 Juri Linkov <juri@jurta.org>
6861
6862 * search.c (Fword_search_regexp, Fword_search_backward)
6863 (Fword_search_forward, Fword_search_backward_lax)
6864 (Fword_search_forward_lax): Move functions to isearch.el
6865 (bug#10145, bug#11381).
6866
b0572523
PE
68672012-05-16 Paul Eggert <eggert@cs.ucla.edu>
6868
6869 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
6870
9660f5fc
SM
68712012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
6872
6873 * lread.c (init_obarray): Declare Qt and Qnil as special.
6874
4374de83
GM
68752012-05-14 Glenn Morris <rgm@gnu.org>
6876
6877 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 6878 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 6879
dc44c39a
PE
68802012-05-14 Paul Eggert <eggert@cs.ucla.edu>
6881
078c97cb
PE
6882 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
6883
dc44c39a
PE
6884 * unexaix.c: Port to more-recent AIX compilers.
6885 (report_error, report_error_1, make_hdr, copy_sym)
6886 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
6887 Make arguments const char *, not char *, to avoid violations of C
6888 standard and to fix some AIX warnings reported by Gilles Pion.
6889
e18afed7 68902012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
6891
6892 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
6893 already have overlays loaded.
6894 (handle_single_display_spec): Before returning without displaying
6895 fringe bitmap, synchronize the bidi iterator with the main display
6896 iterator, by calling iterate_out_of_display_property.
6897 (iterate_out_of_display_property): Detect buffer iteration by
6898 testing that it->string is a Lisp string.
6899 (get_next_display_element): When the current object is exhausted,
6900 and there's something on it->stack, call set_iterator_to_next to
6901 proceed with what's on the stack, instead of returning zero.
6902 (set_iterator_to_next): If called at the end of a Lisp string,
6903 proceed to consider_string_end without incrementing string
6904 position. Don't increment display vector index past the end of
6905 the display vector. (Bug#11417)
c8fb9dc6
EZ
6906 (pos_visible_p): Don't report a position visible when move_it_to
6907 stopped at the last line of window, which happens to be scanned
6908 backwards by the bidi iteration. (Bug#11464)
ac268e67 6909
e18afed7 69102012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
6911
6912 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
6913 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
6914 are on a TTY, and thus unable to display on the fringes.
6915 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
6916 so we need to signal to the caller that this is a "replacing"
6917 display spec. This fixes display when the spec is invalid or we
6918 are on a TTY.
6919
e18afed7 69202012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
6921
6922 * unexaix.c (make_hdr): Fix typo in prototype.
6923 This bug broke the build on AIX. Problem reported by Gilles Pion.
6924
9d0a235a
MA
69252012-05-14 Michael Albinus <michael.albinus@gmx.de>
6926
6927 * keyboard.c (kbd_buffer_get_event): Read special events also in
6928 batch mode. (Bug#11415)
6929
9e6b06ed
GM
69302012-05-12 Glenn Morris <rgm@gnu.org>
6931
6932 * ns.mk: Update for ns_appbindir no longer having trailing "/".
6933
c1a1d7a3
EZ
69342012-05-12 Eli Zaretskii <eliz@gnu.org>
6935
6936 * lisp.mk (lisp): Add newcomment.elc.
6937
3fe7cdc8
GM
69382012-05-12 Glenn Morris <rgm@gnu.org>
6939
6940 * Makefile.in (MKDIR_P): New, set by configure.
6941 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
6942
53f7d2c0
PE
69432012-05-11 Paul Eggert <eggert@cs.ucla.edu>
6944
6945 Remove unused function hourglass_started.
6946 * dispextern.h (hourglass_started):
6947 * w32fns.c (hourglass_started):
6948 * xdisp.c (hourglass_started): Remove.
6949
75aafb17
JB
69502012-05-10 Juanma Barranquero <lekktu@gmail.com>
6951
6952 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
6953 Update dependencies.
6954
12959e8e
PE
69552012-05-10 Paul Eggert <eggert@cs.ucla.edu>
6956
97107e2e
PE
6957 * xgselect.c (xg_select): Put maxfds+1 into a var.
6958 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
6959
12959e8e
PE
6960 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
6961
836d29b3
DA
69622012-05-10 Dave Abrahams <dave@boostpro.com>
6963
6964 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
6965 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
6966
5cb67954
MA
69672012-05-09 Michael Albinus <michael.albinus@gmx.de>
6968
6969 * dbusbind.c (xd_registered_buses): New internal Lisp object.
6970 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
6971 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
6972 Initialize xd_registered_buses.
6973
3478ec45
PE
69742012-05-09 Paul Eggert <eggert@cs.ucla.edu>
6975
b263a6b0
PE
6976 Untag more efficiently if USE_LSB_TAG.
6977 This is based on a proposal by YAMAMOTO Mitsuharu in
6978 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
6979 For an admittedly artificial (nth 8000 longlist) benchmark on
6980 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
6981 Emacs's overall text size by 1%.
6982 * lisp.h (XUNTAG): New macro.
6983 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
6984 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
6985 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
6986 * eval.c (Fautoload):
6987 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
6988 * frame.h (XFRAME): Use XUNTAG.
6989
3478ec45
PE
6990 Port recent dbusbind.c changes to 32-bit --with-wide-int.
6991 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
6992 Remove unportable assumptions about print widths of types like
6993 dbus_uint32_t.
6994 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
6995 intptr_t when converting between pointer and integer, to avoid GCC
6996 warnings about wrong width.
6997
666b903b 69982012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
6999
7000 * w32proc.c (new_child): Force Windows to reserve only 64KB of
7001 stack for each reader_thread, instead of defaulting to 8MB
7002 determined by the linker. This avoids failures in creating
7003 subprocesses on Windows 7, see the discussion in this thread:
7004 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
7005
b120cc17
JC
70062012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
7007
7008 Fix up display of the *Minibuf-0* buffer in the mini window.
7009 * keyboard.c (read_char): Don't clear the echo area if there's no
7010 message to clear.
7011 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 7012 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 7013
9a4b36f8
MA
70142012-05-07 Michael Albinus <michael.albinus@gmx.de>
7015
7016 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
7017 batch mode.
7018
e5f9458f
CY
70192012-05-06 Chong Yidong <cyd@gnu.org>
7020
7021 * lisp.mk (lisp): Update.
7022
eceeb5fc 70232012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
7024
7025 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
7026
71873e2b
SM
70272012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
7028
7029 * data.c (PUT_ERROR): New macro.
7030 (syms_of_data): Use it. Add new error type `user-error'.
7031 * undo.c (user_error): New function.
7032 (Fprimitive_undo): Use it.
7033 * print.c (print_error_message): Adjust print style for `user-error'.
7034 * keyboard.c (user_error): New function.
7035 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
7036
ab0fa4e4
PE
70372012-05-03 Paul Eggert <eggert@cs.ucla.edu>
7038
7039 Do not limit current-time-string to years 1000..9999.
7040 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
7041 (Fcurrent_time_string): Support any year that is supported by the
7042 underlying localtime representation. Don't use asctime, as it
7043 has undefined behavior for years outside the range -999..9999.
7044
7ed806a7
PE
70452012-05-02 Paul Eggert <eggert@cs.ucla.edu>
7046
7047 Fix race conditions involving setenv, gmtime, localtime, asctime.
7048 Without this fix, interrupts could mess up code that uses these
7049 nonreentrant functions, since setting TZ invalidates existing
7050 tm_zone or tzname values, and since most of these functions return
7051 pointers to static storage.
7052 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
7053 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
7054 Grow the critical sections to include not just invoking
7055 localtime/gmtime, but also accessing these functions' results
7056 including their tm_zone values if any, and any related TZ setting.
7057 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
7058 so that the struct tm is saved in the critical section.
7059 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
7060 motivated by the fact that memory allocation needs to be outside
7061 the critical section.
7062
0c16dfed
DA
70632012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
7064
7065 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
7066 with RESET_INTERVAL.
7067
7068 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7069 Remove duplicated buffer name initialization.
7070
3f83ace8
JM
70712012-05-02 Jim Meyering <jim@meyering.net>
7072
7073 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
7074
c7b8541e
JM
7075 * xfns.c (x_window): Use xstrdup (Bug#11375).
7076
90207a15 70772012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
7078
7079 * xdisp.c (pos_visible_p): If already at a newline from the
7080 display string before the 'while' loop, don't walk back the glyphs
7081 from it3.glyph_row. Solves assertion violation when the display
7082 string begins with a newline (egg.el). (Bug#11367)
7083
b593d6a9
AH
70842012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
7085
7086 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
7087 Move to simple.el.
7088
4737362e
GM
70892012-05-01 Glenn Morris <rgm@gnu.org>
7090
99cf43f9
GM
7091 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
7092 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
7093 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
7094 All were removed before 23.1.
7095
9311dcff
GM
7096 * dispnew.c: Remove HAVE_LIBNCURSES test;
7097 it is always true on relevant platforms.
7098
4d5c6349
GM
7099 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
7100 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
7101
4737362e
GM
7102 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
7103
74dd3a6b
AS
71042012-04-30 Andreas Schwab <schwab@linux-m68k.org>
7105
7106 * .gdbinit (xpr): Remove checks for no longer existing misc types.
7107 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
7108 Remove.
7109
13c379ee
PE
71102012-04-28 Paul Eggert <eggert@cs.ucla.edu>
7111
7112 Do not avoid creating empty evaporating overlays (Bug#9642).
7113 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
7114 That is, do not delete an evaporating overlay if it becomes
7115 empty after its bounds are adjusted to fit within its buffer.
7116 This fix caused other problems, and I'm reverting it until we get
7117 to the bottom of them.
7118
a8e7d6d7 71192012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
7120
7121 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
7122
a8e7d6d7 71232012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
7124
7125 * xdisp.c (pos_visible_p): If the window start position is beyond
7126 ZV, start the display from buffer beginning. Prevents assertion
7127 violation in init_iterator when the minibuffer window is scrolled
7128 via the scroll bar.
7129
7130 * window.c (window_scroll_pixel_based): Likewise.
7131
a8e7d6d7 71322012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
7133
7134 * keymap.c (where_is_internal): Doc fix (Bug#10872).
7135
a8e7d6d7 71362012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
7137
7138 * fileio.c (Fcopy_file, Fset_file_selinux_context):
7139 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
7140
a8e7d6d7 71412012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 7142
b593d6a9
AH
7143 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
7144 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 7145
1c6900d9
EZ
71462012-04-26 Eli Zaretskii <eliz@gnu.org>
7147
4c3fa1d9
EZ
7148 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
7149 display element, check also the underlying string or buffer
7150 character. (Bug#11341)
7151
1c6900d9
EZ
7152 * w32menu.c: Include w32heap.h.
7153 (add_menu_item): If the call to AppendMenuW (via
7154 unicode_append_menu) fails, disable Unicode menus only if we are
7155 running on Windows 9X/Me.
7156
42bf8205
AS
71572012-04-24 Andreas Schwab <schwab@linux-m68k.org>
7158
7159 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
7160 (xgetint): Add missing shift for LSB tags.
7161
b1bac16e
MR
71622012-04-24 Martin Rudalics <rudalics@gmx.at>
7163
7164 * keyboard.c (read_char): Don't wipe echo area for select window
7165 events: These might get delayed via `mouse-autoselect-window'
7166 (Bug#11304).
7167
d69621cc
JB
71682012-04-24 Juanma Barranquero <lekktu@gmail.com>
7169
7170 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
7171 manipulation of :loaded-from data.
7172
02fd101b
JB
71732012-04-23 Juanma Barranquero <lekktu@gmail.com>
7174
7175 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
7176 now a cons (bug#11311).
7177
888bec30
PE
71782012-04-23 Paul Eggert <eggert@cs.ucla.edu>
7179
89a438bd
PE
7180 Do not create empty overlays with the evaporate property (Bug#9642).
7181 * buffer.c (Fmove_overlay): Delete an evaporating overlay
7182 if it becomes empty after its bounds are adjusted to fit within
7183 its buffer. Without this fix, in a nonempty buffer (let ((o
7184 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
7185 yields an empty overlay that has the evaporate property, which is
7186 not supposed to happen.
7187
1068fe4d
PE
7188 Fix minor GTK3 problems found by static checking.
7189 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
7190 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
7191 (struct _EmacsFixedClass, emacs_fixed_get_type):
7192 Move decls here from emacsgtkfixed.h, since they needn't be public.
7193 (emacs_fixed_get_type): Now static.
7194 (emacs_fixed_class_init): Omit unused local.
7195 (emacs_fixed_child_type): Remove; unused.
7196 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
7197 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
7198 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
7199 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
7200 (EMACS_FIXED_GET_CLASS): Remove; unused.
7201 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
7202
888bec30
PE
7203 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
7204 Problem reported by Juanma Barranquero for Windows -Wunused-function.
7205
de85e130
PE
72062012-04-22 Paul Eggert <eggert@cs.ucla.edu>
7207
d0baac98 7208 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 7209 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
7210 (__malloc_size_t, __malloc_ptrdiff_t):
7211 Remove. All uses removed, replaced by the definiens if needed,
7212 since we can assume C89 or better now.
7213 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
7214 (protect_malloc_state, align, get_contiguous_space)
7215 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
7216 (malloc_atfork_handler_child, malloc_enable_thread)
7217 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
7218 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
7219 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
7220 (special_realloc, _realloc_internal_nolock, _realloc_internal)
7221 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
7222 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
7223 Define using prototypes, not old style.
7224 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
7225 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
7226 (align): Don't assume that signed integer overflow wraps around.
7227 Omit unused local var.
7228 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
7229 (_free_internal_nolock, memalign, mallochook, reallochook):
7230 Omit no-longer-needed casts.
7231 (valloc): Use getpagesize, not __getpagesize.
7232 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
7233 (struct hdr): The 'magic' member is now size_t, not unsigned long.
7234
de85e130
PE
7235 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
7236
dcbf5805
MA
72372012-04-22 Michael Albinus <michael.albinus@gmx.de>
7238
7239 Move functions from C to Lisp. Make non-blocking method calls
7240 the default. Implement further D-Bus standard interfaces.
7241
7242 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
7243 (QCdbus_request_name_allow_replacement)
7244 (QCdbus_request_name_replace_existing)
7245 (QCdbus_request_name_do_not_queue)
7246 (QCdbus_request_name_reply_primary_owner)
7247 (QCdbus_request_name_reply_in_queue)
7248 (QCdbus_request_name_reply_exists)
7249 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
7250 (QCdbus_registered_serial, QCdbus_registered_method)
7251 (QCdbus_registered_signal): New Lisp objects.
7252 (XD_DEBUG_MESSAGE): Use sizeof.
7253 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
7254 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
7255 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
7256 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
7257 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
7258 (xd_signature, xd_append_arg): Allow float for integer types.
7259 (xd_get_connection_references): New function.
b593d6a9
AH
7260 (xd_get_connection_address): Rename from xd_initialize.
7261 Return cached address.
dcbf5805
MA
7262 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
7263 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
7264 level.
7265 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 7266 Return number of refcounts.
dcbf5805
MA
7267 (Fdbus_get_unique_name): Make stronger parameter check.
7268 (Fdbus_message_internal): New defun.
7269 (Fdbus_call_method, Fdbus_call_method_asynchronously)
7270 (Fdbus_method_return_internal, Fdbus_method_error_internal)
7271 (Fdbus_send_signal, Fdbus_register_service)
7272 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
7273 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
7274 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
7275 (Vdbus_compiled_version, Vdbus_runtime_version)
7276 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
7277 (Vdbus_message_type_method_return, Vdbus_message_type_error)
7278 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
7279 (Vdbus_registered_buses, Vdbus_registered_objects_table):
7280 Adapt docstring.
dcbf5805 7281
52828e02
PE
72822012-04-22 Paul Eggert <eggert@cs.ucla.edu>
7283
da05bc4c
PE
7284 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
7285 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
7286 Do not assume ptrdiff_t is the same width as 'int'.
7287
52828e02
PE
7288 * alloc.c: Handle unusual debugging option combinations.
7289 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
7290 since the two debugging options are incompatible.
7291 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
7292 is defined.
7293 (mem_init, mem_insert, mem_insert_fixup):
7294 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
7295 (NEED_MEM_INSERT): Remove; no longer needed.
7296
f01769f9
LL
72972012-04-22 Leo Liu <sdl.web@gmail.com>
7298
7299 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
7300
5790543d
PE
73012012-04-22 Paul Eggert <eggert@cs.ucla.edu>
7302
7303 * sysdep.c [__FreeBSD__]: Minor cleanups.
7304 (list_system_processes, system_process_attributes) [__FreeBSD__]:
7305 Use Emacs indenting style more consistently. Avoid some casts.
7306 Use 'double' consistently rather than mixing 'float' and 'double'.
7307
b91b7e4d
EW
73082012-04-21 Eduard Wiebe <usenet@pusto.de>
7309
b593d6a9
AH
7310 * sysdep.c (list_system_processes, system_process_attributes):
7311 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 7312
6114eb15
AS
73132012-04-21 Andreas Schwab <schwab@linux-m68k.org>
7314
7315 * lisp.mk (lisp): Update.
7316
2f38dff7
PE
73172012-04-20 Paul Eggert <eggert@cs.ucla.edu>
7318
7319 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
7320 It is never used otherwise.
7321
4ae29f89
SM
73222012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
7323
7324 * print.c (print_preprocess): Only check print_depth if print-circle
7325 is nil.
7326 (print_object): Check for cycles even when print-circle is nil and
7327 print-gensym is t, but only check print_depth if print-circle is nil.
7328
f30d612a
CY
73292012-04-20 Chong Yidong <cyd@gnu.org>
7330
7331 * process.c (wait_reading_process_output): If EIO occurs on a pty,
7332 set the status to "failed" and ensure that sentinel is run.
7333
c07a4c0b 73342012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
7335
7336 * process.c (Fset_process_inherit_coding_system_flag)
7337 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 7338 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 7339
c07a4c0b 73402012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
7341
7342 * xdisp.c (string_buffer_position_lim): Limit starting position to
7343 BEGV.
7344 (set_cursor_from_row): If called for a mode-line or header-line
7345 row, return zero immediately.
7346 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
7347 farther than the first row after the header line, if any.
7348 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
7349 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
7350
c07a4c0b 73512012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 7352
4ae29f89
SM
7353 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
7354 (bug#11238).
ad3a2b41 7355
c07a4c0b 73562012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 73572012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
7358
7359 configure: new option --enable-gcc-warnings (Bug#11207)
7360 * Makefile.in (C_WARNINGS_SWITCH): Remove.
7361 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
7362 (ALL_CFLAGS): Use new macros rather than old.
7363 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
7364 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
7365 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
7366 -Wunused-result, -Wunused-variable. This should go away once
7367 the Emacs and Gnulib regex code is merged.
7368 (xmalloc, xrealloc): Now static.
7369
aba027e8
PE
73702012-04-17 Paul Eggert <eggert@cs.ucla.edu>
7371
7372 * dired.c (Fsystem_groups): Remove unused local.
7373
e5a36063
GM
73742012-04-17 Glenn Morris <rgm@gnu.org>
7375
7376 * dired.c (Fsystem_users): Doc fix.
7377
316411f0
DA
73782012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
7379
7380 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
7381 (syms_of_dired): Add them.
7382
9426aba4
PE
73832012-04-16 Paul Eggert <eggert@cs.ucla.edu>
7384
b62a57be
PE
7385 Fix minor alloc.c problems found by static checking.
7386 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
7387 New extern decls, to avoid calling undeclared functions.
7388 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
7389 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
7390 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
7391 (NEED_MEM_INSERT): New macro.
7392 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 7393 Remove one incorrect comment and fix another.
b62a57be 7394
3539f31f
PE
7395 Fix minor ralloc.c problems found by static checking.
7396 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
7397 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
7398 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
7399 (r_alloc_sbrk): Now static.
7400
a041960a
PE
7401 Improve ralloc.c interface checking.
7402 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
7403 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
7404 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
7405 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
7406 [REL_ALLOC]: ... to here, to check interface.
7407 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
7408 Remove decls. This fixes an "It stinks!".
7409
9426aba4
PE
7410 * alloc.c (which_symbols): Fix alignment issue / type clash.
7411
d55c12ed
AS
74122012-04-15 Andreas Schwab <schwab@linux-m68k.org>
7413
7414 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
7415 (struct Lisp_Misc_Any): Likewise.
7416 (struct Lisp_Free): Likewise.
7417 * alloc.c (union aligned_Lisp_Symbol): Define.
7418 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
7419 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
7420 (union aligned_Lisp_Misc): Define.
7421 (MARKER_BLOCK_SIZE, struct marker_block): Use union
7422 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 7423 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 7424
b948ce8b
PE
74252012-04-14 Paul Eggert <eggert@cs.ucla.edu>
7426
7427 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
7428 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
7429 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
7430 * s/netbsd.h, s/sol2-6.h:
7431 Remove definition of GC_MARK_STACK, since the default now works.
7432 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
7433 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
7434 no longer the default.
7435 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
7436
35dc09a1 74372012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 7438
35dc09a1
GM
7439 * lread.c (lisp_file_lexically_bound_p):
7440 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 7441
35dc09a1
GM
74422012-04-14 Eli Zaretskii <eliz@gnu.org>
7443
7444 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
7445 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
7446
74472012-04-14 Jan Djärv <jan.h.d@swipnet.se>
7448
7449 * nsterm.m (constrainFrameRect): Always constrain when there is only
7450 one screen (Bug#10962).
7451
bcd86815
KB
74522012-04-13 Ken Brown <kbrown@cornell.edu>
7453
7454 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
7455
c25df26e
RT
74562012-04-13 Reuben Thomas <rrt@sc3d.org>
7457
7458 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
7459
0fc59f1e
DC
74602012-04-11 Daniel Colascione <dancol@dancol.org>
7461
7462 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
7463 against is gone. It's better to use vfork now so that when Cygwin
7464 gains a new, working vfork, we use it automatically (bug#10398).
7465
de8c03dc
SM
74662012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
7467
7468 * window.c (save_window_save): Obey window-point-insertion-type.
7469
2f097256
GM
74702012-04-11 Glenn Morris <rgm@gnu.org>
7471
7472 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
7473
453b951e
SM
74742012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
7475
7476 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
7477
75f1671a 74782012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
7479
7480 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
7481 (force_quit_count): New var.
7482 (handle_interrupt): Use it.
7483
2a8ce227
JB
74842012-04-10 Juanma Barranquero <lekktu@gmail.com>
7485
7486 * w32.c (w32_delayed_load): Record the full path of the library
7487 being loaded (bug#10424).
7488
935396c0
GM
74892012-04-09 Glenn Morris <rgm@gnu.org>
7490
05920a43
GM
7491 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
7492 not just in the obarray, before snarfing them. (Bug#11036)
7493
935396c0
GM
7494 * Makefile.in ($(leimdir)/leim-list.el):
7495 Pass EMACS rather than BUILT_EMACS.
7496
a18ecafa
TZ
74972012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
7498
7499 * process.c (make_process):
7500 * process.h: Add integer `gnutls_handshakes_tried' member to
7501 process struct.
7502
6bbef4e5
JC
7503 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
7504 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
7505
7506 * gnutls.c (gnutls_log_function2i): Convenience log function.
7507 (emacs_gnutls_read): Use new log functions,
7508 `gnutls_handshakes_tried' process member, and
7509 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
7510 attempts per process (connection).
7511
b4d3bc10
CY
75122012-04-09 Chong Yidong <cyd@gnu.org>
7513
7514 * eval.c (Fuser_variable_p, user_variable_p_eh)
7515 (lisp_indirect_variable): Functions deleted.
7516 (Fdefvar): Caller changed.
7517
7518 * callint.c (Finteractive, Fcall_interactively):
7519 * minibuf.c (Fread_variable): Callers changed.
7520
70f4d973
EZ
75212012-04-09 Eli Zaretskii <eliz@gnu.org>
7522
7523 * xdisp.c (set_cursor_from_row): If the display string appears in
7524 the buffer at position that is closer to point than the position
7525 after the display string, display the cursor on the first glyph of
7526 the display string. Fixes cursor display when a 'display' text
7527 property immediately follows invisible text. (Bug#11094)
7528
cb3c2e3e
PE
75292012-04-09 Paul Eggert <eggert@cs.ucla.edu>
7530
7531 composite.c: use 'double' consistently
7532 * composite.c (get_composition_id): Use 'double' consistently
7533 instead of converting 'float' to 'double' and vice versa; this is
7534 easier to understand and avoids a GCC warning.
7535
fd06db5d
GM
75362012-04-09 Glenn Morris <rgm@gnu.org>
7537
50fe702a
GM
7538 * Makefile.in: Generate leim-list with bootstrap-emacs, in
7539 preparation for dumping it with emacs. (Bug#4789)
7540 (leimdir): New variable.
7541 ($(leimdir)/leim-list.el): New rule.
7542 (emacs$(EXEEXT)): Depend on leim-list.el.
7543
fd06db5d
GM
7544 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
7545 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
7546 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
7547
55c131ee
AS
75482012-04-08 Andreas Schwab <schwab@linux-m68k.org>
7549
7550 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
7551 proper alignment.
7552
9209588f
JB
75532012-04-07 Juanma Barranquero <lekktu@gmail.com>
7554
7555 * xml.c (init_libxml2_functions) [WINDOWSNT]:
7556 Remove unused local variable.
7557
e3fb2efb
PE
75582012-04-07 Paul Eggert <eggert@cs.ucla.edu>
7559
7560 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
7561 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
7562 (mark_memory): Mark Lisp_Objects only if pointers might hide in
7563 objects, as mark_maybe_pointer will catch them otherwise.
7564 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
7565 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
7566
b5385551
PE
75672012-04-07 Paul Eggert <eggert@cs.ucla.edu>
7568
7569 Fix typo that broke non-Windows builds.
7570 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
7571
9078ead6
EZ
75722012-04-07 Eli Zaretskii <eliz@gnu.org>
7573
7574 Support building on MS-Windows with libxml2.
7575
7576 * makefile.w32-in (OBJ2): Add xml.$(O).
7577 (GLOBAL_SOURCES): Add xml.c.
7578 ($(BLD)/xml.$(O)): New dependency list.
7579
7580 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
7581 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
7582 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
7583 [!WINDOWSNT]: New macros.
7584 (init_libxml2_functions, libxml2_loaded_p): New functions.
7585 (parse_region): Call fn_xmlCheckVersion instead of using the macro
7586 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
7587 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
7588 Calls xmlCleanupParser only if libxml2 was loaded (or statically
7589 linked in).
6bbef4e5
JC
7590 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
7591 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
7592 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
7593
7594 * emacs.c: Don't include libxml/parser.h.
7595 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
7596 xmlCleanupParser directly.
7597
7598 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
7599
3811fdf3
EZ
76002012-04-07 Eli Zaretskii <eliz@gnu.org>
7601
7602 * indent.c (Fvertical_motion): If there is a display string at
7603 point, use it.vpos to compute how many lines to backtrack after
7604 move_it_to point. (Bug#11133)
7605
2f8e16b2
EZ
76062012-04-06 Eli Zaretskii <eliz@gnu.org>
7607
7608 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
7609 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
7610 about subtle differences between FETCH_CHAR* and STRING_CHAR*
7611 macros related to unification of CJK characters. For the details,
7612 see the discussion following the message here:
7613 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
7614
3d439cd1
CY
76152012-04-04 Chong Yidong <cyd@gnu.org>
7616
7617 * keyboard.c (Vdelayed_warnings_list): Doc fix.
7618
8bc53d00
EZ
76192012-04-01 Eli Zaretskii <eliz@gnu.org>
7620
7621 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
7622 instead of alloca. (Bug#11138)
7623
3b0512a3
AS
76242012-04-01 Andreas Schwab <schwab@linux-m68k.org>
7625
7626 * w32menu.c (is_simple_dialog): Properly check lisp types.
7627 (Bug#11141)
7628
8427ddd2
EZ
76292012-03-31 Eli Zaretskii <eliz@gnu.org>
7630
979022ef
EZ
7631 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
7632 position we get to after a call to move_it_to fails the
7633 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
7634 only if we wind up in a string from display property. (Bug#11063)
7635
a6b1c7cc
EZ
7636 * window.c (Fdelete_other_windows_internal): Invalidate the row
7637 and column information about mouse highlight, so that redisplay
7638 restores it after reallocating the glyph matrices. (Bug#7464)
7639
8427ddd2
EZ
7640 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
7641 string comes from a `display' text property, use the buffer
7642 position of that property as if we actually saw that position in
7643 the row's glyphs.
697ba24b
EZ
7644 (move_it_by_lines): Remove the assertion that
7645 "it->current_x == 0 && it->hpos == 0" which can be legitimately
7646 violated when there's a before-string at the beginning of a line.
7647 (Bug#11063)
8427ddd2 7648
65a0a738
EZ
76492012-03-30 Eli Zaretskii <eliz@gnu.org>
7650
7651 * xdisp.c (append_space_for_newline): If the default face was
7652 remapped, use the remapped face for the appended newline.
7653 (extend_face_to_end_of_line): Use the remapped default face for
7654 extending the face to the end of the line.
7655 (display_line): Call extend_face_to_end_of_line when the default
7656 face was remapped. (Bug#11068)
7657
581355cc
EZ
76582012-03-29 Eli Zaretskii <eliz@gnu.org>
7659
7660 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
7661
e8fc049f
SM
76622012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7663
7664 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
7665
4fb9a543
GM
76662012-03-27 Glenn Morris <rgm@gnu.org>
7667
7668 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
7669 Doc fixes.
7670
679910f1
KH
76712012-03-26 Kenichi Handa <handa@m17n.org>
7672
7673 * dispextern.h (struct glyph): Fix previous change. Change the
7674 bit length of glyphless.ch to 25 (Bug#11082).
7675
90d49b7f
CY
76762012-03-26 Chong Yidong <cyd@gnu.org>
7677
7678 * keyboard.c (Vselection_inhibit_update_commands): New variable.
7679 (command_loop_1): Use it; inhibit selection update for
7680 handle-select-window too (Bug#8996).
7681
f514f6f0
FP
76822012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
7683
e8fc049f 7684 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 7685
bf43fa51
KH
76862012-03-25 Kenichi Handa <handa@m17n.org>
7687
7688 * dispextern.h (struct glyph): Change the bit length of
7689 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
7690
8a0c01dd
EZ
76912012-03-24 Eli Zaretskii <eliz@gnu.org>
7692
7693 * s/ms-w32.h (tzname): Include time.h before redirecting to
7694 _tzname. Fixes the MSVC build. (Bug#9960)
7695
7d1c3a76
AS
76962012-03-24 Andreas Schwab <schwab@linux-m68k.org>
7697
8ed79523
AS
7698 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
7699 characters.
7700
7d1c3a76
AS
7701 * xterm.c (XTread_socket): Only modify handling_signal if
7702 !SYNC_INPUT. (Bug#11080)
7703
e99a9b8b
EZ
77042012-03-23 Eli Zaretskii <eliz@gnu.org>
7705
7706 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
7707 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
7708 when fetching a multibyte character consumes more bytes than
7709 CHAR_BYTES returns, due to unification of CJK characters in
7710 string_char. (Bug#11073)
7711
5063c0e1
TN
77122012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
7713
7714 * process.c (wait_reading_process_output): Handle pty disconnect
7715 by refraining from sending oneself a SIGCHLD (bug#10933).
7716
9f851fbd
CY
77172012-03-22 Chong Yidong <cyd@gnu.org>
7718
7719 * dispextern.h (struct it): New member string_from_prefix_prop_p.
7720
5063c0e1 7721 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
7722 Mark string as coming from a prefix property.
7723 (handle_face_prop): Use default face for prefix strings (Bug#4281).
7724 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
7725
fb5b8aca
CY
77262012-03-21 Chong Yidong <cyd@gnu.org>
7727
7728 * xfaces.c (Vface_remapping_alist): Doc fix.
7729
62356a1b
EZ
77302012-03-20 Eli Zaretskii <eliz@gnu.org>
7731
7732 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
7733 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
7734 Doc fixes.
62356a1b 7735
025de85b
CY
77362012-03-20 Chong Yidong <cyd@gnu.org>
7737
7738 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
7739 to reflect default non-nil value of redisplay-dont-pause.
7740
4827f94e
KH
77412012-03-19 Kenichi Handa <handa@m17n.org>
7742
7743 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
7744 it fit in a valid range (Bug#11003).
7745
e50a24a2
EZ
77462012-03-18 Eli Zaretskii <eliz@gnu.org>
7747
7748 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
7749 that is not from display property, accept the row as a "cursor
7750 row" if one of the string's character has a non-nil `cursor'
7751 property. Fixes cursor positioning when there are newlines in
7752 overlay strings, e.g. in icomplete.el. (Bug#11035)
7753
9af5ed87
PE
77542012-03-12 Paul Eggert <eggert@cs.ucla.edu>
7755
7756 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
7757
d1f55f16
CY
77582012-03-12 Chong Yidong <cyd@gnu.org>
7759
7760 * eval.c (inhibit_lisp_code): Rename from
7761 inhibit_window_configuration_change_hook; move from window.c.
7762
7763 * xfns.c (unwind_create_frame_1, Fx_create_frame):
7764 * window.c (run_window_configuration_change_hook)
7765 (syms_of_window): Callers changed.
7766
66c5eebd
CY
77672012-03-11 Chong Yidong <cyd@gnu.org>
7768
413df973
CY
7769 * keymap.c (Fkey_description): Doc fix (Bug#9700).
7770
66c5eebd
CY
7771 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
7772
1de11f56
CY
77732012-03-10 Chong Yidong <cyd@gnu.org>
7774
7775 * frame.c (other_visible_frames): Don't assume the selected frame
7776 is visible (Bug#10955).
7777
cae07000
SM
77782012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
7779
7780 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
7781
89c94350
JD
77822012-03-08 Jan Djärv <jan.h.d@swipnet.se>
7783
7784 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
7785 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
7786 zero (Bug#10954).
7787
999dd333
GM
77882012-03-03 Glenn Morris <rgm@gnu.org>
7789
01a6dcc8 7790 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 7791
de0100f2
EZ
77922012-03-02 Eli Zaretskii <eliz@gnu.org>
7793
7794 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
7795 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
7796 (redisplay_window, next_element_from_string): Fix typos in
7797 comments.
3e441275
EZ
7798 (redisplay_window): Pass to move_it_vertically the margin in
7799 pixels, not in screen lines.
de0100f2 7800
96a72ee9
GM
78012012-03-02 Glenn Morris <rgm@gnu.org>
7802
7803 * buffer.c (buffer-list-update-hook): Doc fix.
7804
312508d7
EZ
78052012-02-29 Eli Zaretskii <eliz@gnu.org>
7806
7807 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
7808 push_it before setting up the iterator for the first overlay
7809 string, even if we have an empty string loaded.
7810 (next_overlay_string): If there's an empty string on the iterator
7811 stack, pop the stack. (Bug#10903)
7812
27f3c637
PE
78132012-02-25 Paul Eggert <eggert@cs.ucla.edu>
7814
7815 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
7816 Suggested by Stefan Monnier in
7817 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
7818 * alloc.c (widen_to_Lisp_Object): New static function.
7819 (mark_memory): Also mark Lisp_Objects by fetching pointer words
7820 and widening them to Lisp_Objects. This would work even if
7821 USE_LSB_TAG is defined and wide integers are used, which might
7822 happen in a future version of Emacs.
7823
3c9dfce6
CY
78242012-02-25 Chong Yidong <cyd@gnu.org>
7825
fa74b241
CY
7826 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
7827 Doc fix.
7828
3c9dfce6
CY
7829 * xselect.c (Fx_selection_exists_p): Doc fix.
7830 (x_clipboard_manager_save_all): Print an informative message
7831 before saving to clipboard manager.
7832
9486df08
CY
78332012-02-24 Chong Yidong <cyd@gnu.org>
7834
7835 * keyboard.c (process_special_events): Handle all X selection
7836 requests in kbd_buffer, not just the next one (Bug#8869).
7837
f01d3321
CY
78382012-02-23 Chong Yidong <cyd@gnu.org>
7839
7840 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
7841 call when setting menu-bar-lines and tool-bar-lines parameters.
7842 (unwind_create_frame_1): New helper function.
7843
7844 * window.c (inhibit_window_configuration_change_hook): New var.
7845 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 7846 (syms_of_window): Initialize it.
f01d3321 7847
86b847b6
CY
78482012-02-22 Chong Yidong <cyd@gnu.org>
7849
7850 * xterm.c (x_draw_image_relief): Add missing type check for
7851 Vtool_bar_button_margin (Bug#10743).
7852
a59225b1
CY
78532012-02-21 Chong Yidong <cyd@gnu.org>
7854
7855 * fileio.c (Vfile_name_handler_alist): Doc fix.
7856
7857 * buffer.c (Fget_file_buffer): Protect against invalid file
7858 handler return value.
7859
310f5bd4
PE
78602012-02-20 Paul Eggert <eggert@cs.ucla.edu>
7861
cb3a28cc
PE
7862 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
7863 when computing $valmask.
7864
310f5bd4
PE
7865 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
7866 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
7867 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
7868 It's useless in that case, and it can cause problems on hosts
7869 that allocate halves of EMACS_INT values separately.
7870 Reported by Dan Horák. Diagnosed by Andreas Schwab in
7871 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
7872 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
7873 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
7874 it avoids undefined behavior on hosts where shifting right by more
7875 than the word width has undefined behavior.
7876
2375c96a
CY
78772012-02-19 Chong Yidong <cyd@gnu.org>
7878
7879 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
7880 (Funhandled_file_name_directory, Ffile_name_as_directory)
7881 (Fdirectory_file_name, Fexpand_file_name)
7882 (Fsubstitute_in_file_name): Protect against invalid file handler
7883 return values (Bug#10845).
7884
3eb49e71
EZ
78852012-02-18 Eli Zaretskii <eliz@gnu.org>
7886
7887 * .gdbinit (pitx): Fix incorrect references to fields of the
7888 iterator stack.
7889
7b926f3f
CY
78902012-02-17 Chong Yidong <cyd@gnu.org>
7891
7892 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
7893
11273115
PE
78942012-02-15 Paul Eggert <eggert@cs.ucla.edu>
7895
7896 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
7897 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
7898
c3a70e2b
CY
78992012-02-15 Chong Yidong <cyd@gnu.org>
7900
7901 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
7902 marked as special. Also, starting docstrings with * is obsolete.
7903
0ca43699
AS
79042012-02-13 Andreas Schwab <schwab@linux-m68k.org>
7905
7906 * gnutls.c (emacs_gnutls_write): Fix last change.
7907
2e8f3c56
LI
79082012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
7909
7910 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
7911 send_process.
7912
af70074f
SM
79132012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
7914
7915 * keymap.c (Fsingle_key_description): Handle char ranges.
7916
95986d52
CY
79172012-02-12 Chong Yidong <cyd@gnu.org>
7918
afd83bd1
CY
7919 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
7920 as that creates a dangerous corner case.
7921
95986d52
CY
7922 * window.c (Fdelete_window_internal): Invalidate the mouse
7923 highlight (Bug#9904).
7924
bd7da63e
GM
79252012-02-12 Glenn Morris <rgm@gnu.org>
7926
7927 * xselect.c (Fx_own_selection_internal)
7928 (Fx_get_selection_internal, Fx_disown_selection_internal)
7929 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
7930 * nsselect.m (Fx_own_selection_internal)
7931 (Fx_disown_selection_internal, Fx_selection_exists_p)
7932 (Fx_selection_owner_p, Fx_get_selection_internal):
7933 Sync docs and argument specs with the xselect.c versions.
7934
77abcbc2
LI
79352012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
7936
7937 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
7938
90b671e2
EZ
79392012-02-11 Eli Zaretskii <eliz@gnu.org>
7940
1c0ca0b7
EZ
7941 * w32select.c (Fx_selection_exists_p): Sync doc string and
7942 argument list with xselect.c. (Bug#10783)
7943
7944 * w16select.c (Fx_selection_exists_p): Sync doc string and
7945 argument list with xselect.c. (Bug#10783)
90b671e2 7946
49241268
GM
79472012-02-10 Glenn Morris <rgm@gnu.org>
7948
7949 * fns.c (Fsecure_hash): Doc fix.
7950
f998bbe7 79512012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
7952
7953 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
7954
0992bd9c
CY
79552012-02-07 Chong Yidong <cyd@gnu.org>
7956
7957 * buffer.c (Fbuffer_local_variables)
7958 (buffer_lisp_local_variables): Handle unbound vars correctly;
7959 don't let Qunbound leak into Lisp.
7960
af008560
GM
79612012-02-07 Glenn Morris <rgm@gnu.org>
7962
dd605cc4
GM
7963 * image.c (Fimagemagick_types): Doc fix.
7964
af008560
GM
7965 * image.c (imagemagick-render-type): Change it from a lisp object
7966 to an integer. Move the doc here from the lisp manual.
7967 Treat all values not equal to 0 the same.
7968
1449fa1d
CY
79692012-02-06 Chong Yidong <cyd@gnu.org>
7970
7971 * doc.c (store_function_docstring): Avoid applying docstring of
7972 alias to base function (Bug#2603).
7973
3723ec07
AS
79742012-02-04 Andreas Schwab <schwab@linux-m68k.org>
7975
7976 * .gdbinit (pp1, pv1): Remove redundant defines.
7977 (pr): Use pp.
7978
79c1cc1e
CY
79792012-02-04 Chong Yidong <cyd@gnu.org>
7980
7981 * nsterm.m: Declare a global (Bug#10694).
7982
d7f29f8e
EZ
79832012-02-04 Eli Zaretskii <eliz@gnu.org>
7984
cae07000
SM
7985 * w32.c (get_emacs_configuration_options):
7986 Include --enable-checking, if specified, in the return value.
d7f29f8e 7987
3b95a6f9
MR
79882012-02-04 Martin Rudalics <rudalics@gmx.at>
7989
7990 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
7991 after rounding frame sizes. (Bug#9723)
7992
d6fa96a6
EZ
79932012-02-04 Eli Zaretskii <eliz@gnu.org>
7994
7995 * keyboard.c (adjust_point_for_property): Don't position point
7996 before BEGV. (Bug#10696)
7997
df0b2940
PE
79982012-02-03 Paul Eggert <eggert@cs.ucla.edu>
7999
8000 Handle overflow when computing char display width (Bug#9496).
8001 * character.c (char_width): Return EMACS_INT, not int.
8002 (char_width, c_string_width): Check for overflow when
8003 computing the width; this is possible now that individual
8004 characters can have unbounded width. Problem introduced
8005 by merge from Emacs 23 on 2012-01-19.
8006
6bee44d6
MA
80072012-02-02 Michael Albinus <michael.albinus@gmx.de>
8008
8009 * dbusbind.c (Fdbus_register_method): Mention the return value
8010 :ignore in the docstring.
8011
44f92739
GM
80122012-02-02 Glenn Morris <rgm@gnu.org>
8013
1b9f60cc
GM
8014 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
8015
44f92739
GM
8016 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
8017 Unconditionally set to t. (Bug#10673)
8018 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
8019 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
8020 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
8021
c5d3843c
KH
80222012-02-02 Kenichi Handa <handa@m17n.org>
8023
8024 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
8025 0, do not call append_composite_glyph.
8026
159462d4 80272012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
8028
8029 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
8030 NULL (Bug#6988).
8031 (x_produce_glyphs): If the component of a composition is a null
8032 string, set it->pixel_width to 1 to avoid zero-width glyph.
8033
78cef877
EZ
80342012-02-01 Eli Zaretskii <eliz@gnu.org>
8035
8036 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
8037 first 2 arguments are identical. This makes inserting large
8038 output from a subprocess an order of magnitude faster on
8039 MS-Windows, where all sbrk'ed memory is always contiguous.
8040
97897668
GM
80412012-01-31 Glenn Morris <rgm@gnu.org>
8042
8043 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 8044 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
8045 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
8046
31fd3586
GM
80472012-01-29 Glenn Morris <rgm@gnu.org>
8048
8049 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
8050
0e24a8b2
CY
80512012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
8052
8053 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
8054
cc0adcb0
CY
80552012-01-28 Chong Yidong <cyd@gnu.org>
8056
8057 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
8058
acc28cb9
CY
80592012-01-26 Chong Yidong <cyd@gnu.org>
8060
9c69cfb7
CY
8061 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
8062
acc28cb9
CY
8063 * search.c (Fsearch_forward, Fsearch_backward): Document negative
8064 repeat counts (Bug#10507).
8065
48da7392
GM
80662012-01-26 Glenn Morris <rgm@gnu.org>
8067
8068 * lread.c (syms_of_lread): Doc fix.
8069
14af5f7f
CY
80702012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
8071
8072 * coding.c (encode_designation_at_bol): Change return value to
8073 EMACS_INT.
8074
0b21c100
CY
80752012-01-25 Chong Yidong <cyd@gnu.org>
8076
8077 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
8078
3c2907f7
CY
80792012-01-21 Chong Yidong <cyd@gnu.org>
8080
8081 * floatfns.c (Fcopysign): Make the second argument non-optional,
8082 since nil is not allowed anyway.
8083
959ad23f
AS
80842012-01-21 Andreas Schwab <schwab@linux-m68k.org>
8085
8086 * process.c (read_process_output): Use p instead of XPROCESS (proc).
8087 (send_process): Likewise.
8088
34a02f46
MR
80892012-01-19 Martin Rudalics <rudalics@gmx.at>
8090
8091 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
8092 (Vwindow_persistent_parameters): Do not use Qstate.
8093 Rewrite doc-strings.
34a02f46 8094
1259009a 80952012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
8096
8097 * character.c (char_width): New function.
70d4fdf6
GM
8098 (Fchar_width, c_string_width, lisp_string_width):
8099 Use char_width (Bug#9496).
25ed9e61 8100
6a6ee00d
MR
81012012-01-16 Martin Rudalics <rudalics@gmx.at>
8102
8103 * window.c (Vwindow_persistent_parameters): New variable.
8104 (Fset_window_configuration, save_window_save): Handle persistent
8105 window parameters.
8106
c85efaf7
EZ
81072012-01-14 Eli Zaretskii <eliz@gnu.org>
8108
8109 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
8110 thrashing the stack of the thread. (Bug#9087)
8111
5944709e
PE
81122012-01-12 Paul Eggert <eggert@cs.ucla.edu>
8113
8114 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
8115
e71f5d99
EZ
81162012-01-11 Eli Zaretskii <eliz@gnu.org>
8117
8118 * xdisp.c (rows_from_pos_range): Handle the case where the
8119 highlight ends on a newline. (Bug#10464)
8120 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
8121 he end column for display of highlight that ends on a newline
8122 before a R2L line.
8123
ce316182
GM
81242012-01-11 Glenn Morris <rgm@gnu.org>
8125
8126 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
8127 from load-path also when installation-directory is nil. (Bug#10208)
8128
5b43da69
GM
81292012-01-10 Glenn Morris <rgm@gnu.org>
8130
74cc8ff9
GM
8131 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
8132
7d8d6e4e
GM
8133 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
8134 Update template values to be closer to their typical values these days.
5b43da69 8135
a0db8d43
EZ
81362012-01-09 Eli Zaretskii <eliz@gnu.org>
8137
8138 * xdisp.c (rows_from_pos_range): Accept additional argument
8139 DISP_STRING, and accept any glyph in a row whose object is that
8140 string as eligible for mouse highlight. Fixes mouse highlight of
8141 display strings from overlays. (Bug#10464)
8142
9a0115ab 81432012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 8144
b9110d6a 8145 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
8146 * fileio.c (auto_saving_dir_umask): New static var.
8147 (Fmake_directory_internal): Use it.
8148 (do_auto_save_make_dir): Set it, instead of invoking chmod after
8149 creating the directory. The old code temporarily assigns
8150 too-generous permissions to the directory.
8151 (do_auto_save_eh): Clear it.
b9110d6a 8152 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
8153 that the var is always cleared.
8154
6c1bd3f3
EZ
81552012-01-07 Eli Zaretskii <eliz@gnu.org>
8156
8157 * search.c (scan_buffer): Pass character positions to
8158 know_region_cache, not byte positions. (Bug#6540)
8159
069d2b50
L
81602012-01-07 LynX <_LynX@bk.ru> (tiny change)
8161
8162 * w32.c (sys_rename): Report EXDEV when rename of a directory
8163 fails because the target is on another logical disk. (Bug#10284)
8164
75bf0d33
DB
81652012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
8166
8167 * xterm.c (x_embed_request_focus): New function.
8168
8169 * xterm.h: Add prototype.
8170
8171 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
8172
1c6e5a32
GM
81732012-01-05 Glenn Morris <rgm@gnu.org>
8174
8175 * emacs.c (emacs_copyright): Update short copyright year to 2012.
8176
651e947e
EZ
81772012-01-01 Eli Zaretskii <eliz@gnu.org>
8178
8179 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
8180 Load gnutls_transport_set_lowat only if GnuTLS version is below
8181 2.11.1.
8182 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
8183 GnuTLS versions below 2.11.1.
8184
3778cdd8
AL
81852011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
8186
8187 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
8188 to the doc string advising against its use for altering the way
8189 windows are scrolled.
8190
0e5317f7
KH
81912011-12-28 Kenichi Handa <handa@m17n.org>
8192
8193 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
8194 coding-system ASCII compatible only when it does not produce BOM
8195 on encoding (Bug#10383).
8196
93d5ca1f
JD
81972011-12-26 Jan Djärv <jan.h.d@swipnet.se>
8198
8199 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
8200 can scroll.
8201 (create_and_show_popup_menu): Always use menu_position_func for
8202 Gtk3 (Bug#10361).
8203
ca22b785
AS
82042011-12-24 Andreas Schwab <schwab@linux-m68k.org>
8205
8206 * callint.c (Fcall_interactively): Don't truncate prompt string.
8207
d048e1e6
EZ
82082011-12-23 Eli Zaretskii <eliz@gnu.org>
8209
8210 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
8211 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 8212 resumed from there (after widening). (Bug#10360)
d048e1e6 8213
5ccaba1f
JD
82142011-12-22 Jan Djärv <jan.h.d@swipnet.se>
8215
8216 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
8217
204ee57f
JD
82182011-12-21 Jan Djärv <jan.h.d@swipnet.se>
8219
b81d40f0
JB
8220 * nsterm.m (x_free_frame_resources):
8221 Release f->output_data.ns->miniimage.
204ee57f
JD
8222 (ns_index_color): Fix indentation. Do not retain
8223 color_table->colors[i].
8224
8225 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
8226 before returning.
8227
8228 * nsfns.m (x_set_background_color): Assign return value from
8229 ns_index_color to face-background instead of NSColor*.
8230 (ns_implicitly_set_icon_type): Fix indentation.
8231 Change assignment in for loop to comparison.
8232
8233 * emacs.c (ns_pool): New variable.
8234 (main): Assign ns_pool.
8235 (Fkill_emacs): Call ns_release_autorelease_pool.
8236
8237 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
8238 autorelease fdesc, release fdAttrs and tdict.
8239 (ns_get_covering_families): Release charset.
8240 (ns_findfonts): Release NSFontDescriptor created with new.
8241 (ns_uni_to_glyphs): Fix indentation.
8242 (setString): Release attrStr before assigning new value.
8243
c803b2b7
JD
82442011-12-18 Jan Djärv <jan.h.d@swipnet.se>
8245
678f4426
JD
8246 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
8247 and NS_IMPL_COCOA.
8248 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
8249 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
8250
cd394be1 82512011-12-18 David Reitter <reitter@cmu.edu>
678f4426 8252
5fecd5fc
JD
8253 * nsterm.m (ns_term_init): Subscribe for notifications
8254 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
8255 to method trackingNotification in EmacsMenu.
8256
8257 * nsmenu.m (trackingMenu): New variable.
3771cb17 8258 (trackingNotification): New method (from Aquamacs).
5fecd5fc 8259 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 8260 from Aquamacs (Bug#7030).
678f4426
JD
8261
82622011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 8263
c803b2b7
JD
8264 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
8265 (symbol_to_nsstring): Fix indentation.
8266 (ns_symbol_to_pb): New function.
cae07000
SM
8267 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
8268 (Fns_rotate_cut_buffers_internal): Remove.
8269 (Fns_store_selection_internal): Rename from
c803b2b7
JD
8270 Fns_store_cut_buffer_internal.
8271 (ns_get_foreign_selection, Fx_own_selection_internal)
8272 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
8273 (Fns_get_selection_internal, Fns_store_selection_internal):
8274 Use ns_symbol_to_pb and check if return value is nil.
8275 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
8276 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
8277 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
8278 renamed to Sns_store_selection_internal.
8279 (ns_handle_selection_request): Move code to Fx_own_selection_internal
8280 and remove this function.
8281 (ns_handle_selection_clear): Remove, never used.
8282 (Fx_own_selection_internal): Move code from ns_handle_selection_request
8283 here.
8284
e1b01a3a
KB
82852011-12-17 Ken Brown <kbrown@cornell.edu>
8286
8287 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
8288 GID is unknown (Bug#10257).
8289
2adb6e85
PE
82902011-12-17 Paul Eggert <eggert@cs.ucla.edu>
8291
8292 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
8293 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
8294 which caused a build failure on GNU/Linux IA-64. This problem was
8295 introduced by my 2011-10-07 patch.
8296
d1d7b339
JL
82972011-12-15 Juri Linkov <juri@jurta.org>
8298
8299 * image.c (imagemagick_error): New function. (Bug#10112)
8300 (imagemagick_load_image): Comment out `MagickSetResolution' call.
8301 Use `imagemagick_error' where ImageMagick functions return
8302 `MagickFalse'.
8303 (Fimagemagick_types): Add `Fnreverse' to return the list in the
8304 proper order.
8305
100d5755
KH
83062011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8307
8308 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
8309 fill background (Bug#8992).
8310
454592a6
MR
83112011-12-13 Martin Rudalics <rudalics@gmx.at>
8312
8313 * window.c (Vwindow_combination_resize)
8314 (Vwindow_combination_limit): Use t instead of non-nil in
8315 doc-strings.
61d4b438
MR
8316 (Vrecenter_redisplay): Add first sentence of doc-string on
8317 separate line.
53524d93 8318 (Frecenter): Fix doc-string typo.
454592a6 8319
3633e3aa
KH
83202011-12-11 Kenichi Handa <handa@m17n.org>
8321
8322 * coding.c (Funencodable_char_position): Pay attention to the
8323 buffer text relocation (Bug#9389).
8324
7b9d523a 83252011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 8326
7b9d523a
JD
8327 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
8328 gtk_init (Bug#10100).
8329
b73189c6
EZ
83302011-12-10 Eli Zaretskii <eliz@gnu.org>
8331
8332 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
8333 IT->string is nil. (Bug#10263)
8334
f7dfe5d6
JD
83352011-12-10 Jan Djärv <jan.h.d@swipnet.se>
8336
83faebb4
JD
8337 * nsterm.h (x_free_frame_resources): Declare.
8338
f7dfe5d6
JD
8339 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
8340 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
8341
8342 * nsterm.h (ns_get_defaults_value): Declare.
8343
8344 * nsterm.m (ns_default): Call ns_get_defaults_value.
8345
7cd4e72c
EZ
83462011-12-09 Eli Zaretskii <eliz@gnu.org>
8347
8348 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
8349 (Bug#10170)
8350
b34d7317
YM
83512011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8352
8353 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
8354 that where the value of an _OBJC_* symbol points to is in the .bss
8355 section (Bug#10240).
8356
76470ad1
KH
83572011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
8358
8359 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 8360 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 8361
745fff94
KH
83622011-12-08 Kenichi Handa <handa@m17n.org>
8363
8364 * ftfont.c (get_adstyle_property): Fix previous change
8365 (Bug#10233).
8366
6e44397c
JB
83672011-12-07 Juanma Barranquero <lekktu@gmail.com>
8368
8369 * w32.c (init_environment): If no_site_lisp, remove site-lisp
8370 dirs from the default value of EMACSLOADPATH (bug#10208).
8371
7efa6272
GM
83722011-12-07 Glenn Morris <rgm@gnu.org>
8373
8374 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
8375 installation and source directories as well. (Bug#10208)
8376
f6fc4d87
CY
83772011-12-06 Chong Yidong <cyd@gnu.org>
8378
8379 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
8380
2bf26180
GM
83812011-12-06 Glenn Morris <rgm@gnu.org>
8382
8383 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
8384 as an error, not just -1. (Bug#10217)
8385
3a6ad4f0
CY
83862011-12-05 Chong Yidong <cyd@gnu.org>
8387
8388 * keyboard.c (process_special_events): New function.
8389 (swallow_events, Finput_pending_p): Use it (Bug#10195).
8390
75a3b399
PE
83912011-12-05 Paul Eggert <eggert@cs.ucla.edu>
8392
8393 * coding.c (encode_designation_at_bol): Don't use uninitialized
8394 local variable (Bug#9318).
8395
c3c9e25e
KH
83962011-12-05 Kenichi Handa <handa@m17n.org>
8397
8398 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
8399 return Qnil (Bug#8046, Bug#10193).
8400
5eb05ea3
KH
84012011-12-05 Kenichi Handa <handa@m17n.org>
8402
8403 * coding.c (encode_designation_at_bol): New args charbuf_end and
8404 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
8405 (coding_set_source): Return how many bytes coding->source was
8406 relocated.
8407 (coding_set_destination): Return how many bytes
8408 coding->destination was relocated.
8409 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 8410 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
8411
84122011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
8413
8414 * coding.c (CODING_CHAR_CHARSET_P): New macro.
8415 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
8416 macro (Bug#9318).
8417
84182011-12-05 Andreas Schwab <schwab@linux-m68k.org>
8419
8420 The following changes are to fix Bug#9318.
8421
a79703f5 8422 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
8423 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
8424 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 8425 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 8426
7dbda6df
JB
84272011-12-05 Juanma Barranquero <lekktu@gmail.com>
8428
8429 * lisp.h (process_quit_flag): Fix external declaration.
8430
6d5eb5b0
SM
84312011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
8432
8433 Don't macro-inline non-performance-critical code.
8434 * eval.c (process_quit_flag): New function.
8435 * lisp.h (QUIT): Use it.
8436
a0c3fad0
JD
84372011-12-04 Jan Djärv <jan.h.d@swipnet.se>
8438
8439 * nsfns.m (get_geometry_from_preferences): New function.
8440 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
8441
6c07aac2
AS
84422011-12-04 Andreas Schwab <schwab@linux-m68k.org>
8443
8444 * emacs.c (Qkill_emacs): Define.
8445 (syms_of_emacs): Initialize it.
8446 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
8447 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
8448 (quit_throw_to_read_char): Add parameter `from_signal'.
8449 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
8450 * lisp.h (QUIT): Call Fkill_emacs if requested.
8451
c052ead4
JD
84522011-12-03 Jan Djärv <jan.h.d@swipnet.se>
8453
8454 * widget.c (update_wm_hints): Return if wmshell is null.
8455 (widget_update_wm_size_hints): New function.
8456
8457 * widget.h (widget_update_wm_size_hints): Declare.
8458
8459 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
8460 widget_update_wm_size_hints (Bug#10104).
8461
9e49252b
EZ
84622011-12-03 Eli Zaretskii <eliz@gnu.org>
8463
8464 * xdisp.c (handle_invisible_prop): If the invisible text ends just
8465 before a newline, prepare the bidi iterator for consuming the
8466 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 8467 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 8468
02b16839
JL
84692011-12-02 Juri Linkov <juri@jurta.org>
8470
8471 * search.c (Fword_search_regexp): New Lisp function created from
8472 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
8473 (Fword_search_backward, Fword_search_forward)
8474 (Fword_search_backward_lax, Fword_search_forward_lax):
8475 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
8476 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
8477
0068070e
SM
84782011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
8479
8480 * fileio.c (Finsert_file_contents): Move after-change-function call
8481 to before the "handled:" label, since all "goto handled" appear in
8482 cases where the *-change-functions have already been properly called
8483 (bug#10117).
8484
3360a3fc
AS
84852011-12-01 Andreas Schwab <schwab@linux-m68k.org>
8486
8487 * keyboard.c (interrupt_signal): Don't call kill-emacs when
8488 waiting for input. (Bug#10169)
8489
73d6c093
EZ
84902011-11-30 Eli Zaretskii <eliz@gnu.org>
8491
8492 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
8493 verifies glyph row's hash code--we have just reallocated the
8494 glyphs, so their contents can be complete garbage. (Bug#10164)
8495
febe6bea
JB
84962011-11-30 Juanma Barranquero <lekktu@gmail.com>
8497
8498 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
8499
801a4313
EZ
85002011-11-30 Eli Zaretskii <eliz@gnu.org>
8501
8502 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
8503 attributes are tested _before_ calling verify_row_hash, to protect
8504 against GCC re-ordering of the tests. (Bug#10164)
8505
2b56b87e
JD
85062011-11-29 Jan Djärv <jan.h.d@swipnet.se>
8507
8508 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
8509
8510 * xterm.c (handle_one_xevent): Only set async_visible and friends
8511 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 8512 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
8513 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
8514
dbf31225
PE
85152011-11-28 Paul Eggert <eggert@cs.ucla.edu>
8516
8517 Remove GCPRO-related macros that exist only to avoid shadowing locals.
8518 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
8519 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
8520 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
8521 All uses changed to use GCPRO1 etc.
8522 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
8523 Revert to old implementation (i.e., before 2011-03-11).
8524
1305621b
YM
85252011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8526
8527 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
8528 of scroll runs so as to avoid assigning disabled bogus rows and
8529 unnecessary graphics copy operations.
8530
8c9afb46
EZ
85312011-11-27 Eli Zaretskii <eliz@gnu.org>
8532
8533 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
8534 (snprintf) [_MSC_VER]: Redirect to _snprintf.
8535 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
8536 (malloc, free, realloc, calloc): Redirect to e_* only when
8537 compiling Emacs.
8538
8539 * lisp.h (GCTYPEBITS): Move before first use.
8540 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
8541 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
8542 this macro definition.
8543
8544 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
8545 _MSC_VER.
8546
54e9e3bf
JD
85472011-11-27 Jan Djärv <jan.h.d@swipnet.se>
8548
6d5eb5b0
SM
8549 * gtkutil.c (xg_create_frame_widgets):
8550 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
8551 present with Gtk+ 2.0.
8552
83aca1cb
PE
85532011-11-26 Paul Eggert <eggert@cs.ucla.edu>
8554
8555 * fileio.c (Finsert_file_contents): Undo previous change; see
8556 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
8557
5b76caa4
PE
85582011-11-26 Paul Eggert <eggert@cs.ucla.edu>
8559
8560 Rename locals to avoid shadowing.
8561 * fileio.c (Finsert_file_contents):
8562 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
8563 * process.c (wait_reading_process_output):
8564 Rename inner 'proc' to 'p' to avoid shadowing.
8565 Indent for consistency with usual Emacs style.
8566
8c535114
EZ
85672011-11-25 Eli Zaretskii <eliz@gnu.org>
8568
8569 * xdisp.c (redisplay_window): If cursor row is not fully visible
8570 after recentering, and scroll-conservatively is set to a large
8571 number, scroll window by a few more lines to make the cursor fully
8572 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
8573 (start_display): Don't move to the next line if the display should
8574 start at a newline that is part of a display vector or an overlay
8575 string. (Bug#10119)
8c535114 8576
fa4fdb5c
JL
85772011-11-24 Juri Linkov <juri@jurta.org>
8578
8579 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
8580 after the `MagickPingImage' call. (Bug#10112)
8581
90ec88df
CY
85822011-11-23 Chong Yidong <cyd@gnu.org>
8583
8584 * window.c (Fcoordinates_in_window_p): Accept only live windows.
8585
56e2e794
MR
85862011-11-23 Martin Rudalics <rudalics@gmx.at>
8587
8588 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
8589 making another buffer current. (Bug#10114)
8590
b6e64c41
GM
85912011-11-23 Glenn Morris <rgm@gnu.org>
8592
8593 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
8594
6b21de18
CY
85952011-11-23 Chong Yidong <cyd@gnu.org>
8596
8597 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
8598 using it (Bug#5984).
8599
b12cd789
EZ
86002011-11-22 Eli Zaretskii <eliz@gnu.org>
8601
8602 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
8603 and header-lines, as they don't have one computed for them.
8604 (Bug#10098)
8605
8606 * .gdbinit (prow): Make displayed values more self-explaining.
8607 Add row's hash code.
8608
261b6fd4
LMI
86092011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
8610
8611 * process.c (wait_reading_process_output): Fix asynchrounous
8612 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 8613 (wait_reading_process_output): Add comment and URL.
261b6fd4 8614
e7cfd277
JD
86152011-11-21 Jan Djärv <jan.h.d@swipnet.se>
8616
8617 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
8618
a9b9b7f5
CY
86192011-11-21 Chong Yidong <cyd@gnu.org>
8620
8621 * window.c (Fnext_window, Fprevious_window): Doc fix.
8622
b0d15b4f
SM
86232011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
8624
8625 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
8626
fe7a3057
JB
86272011-11-20 Juanma Barranquero <lekktu@gmail.com>
8628
8629 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
8630
d2999b1a
MR
86312011-11-20 Martin Rudalics <rudalics@gmx.at>
8632
8633 * window.c (Fset_window_combination_limit): Rename argument
8634 STATUS to LIMIT.
8635 (Vwindow_combination_limit): Remove "status" from doc-string.
8636
d5ff9cd0
AS
86372011-11-20 Andreas Schwab <schwab@linux-m68k.org>
8638
8639 * m/ibms390.h: Remove.
8640 * m/ibms390x.h: Don't include "ibms390.h".
8641
a5bb9bd3
SM
86422011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
8643
8644 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
8645 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
8646
cd1181db
JB
86472011-11-20 Juanma Barranquero <lekktu@gmail.com>
8648
8649 * casetab.c (Fset_case_table):
8650 * charset.c (Fcharset_after): Fix typos.
8651
615a3b8d 86522011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 8653
17e845af
PE
8654 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
8655 Otherwise, valgrind does not work on some platforms.
8656 Problem reported by Andreas Schwab in
6a0bf43d
PE
8657 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
8658 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
8659 is set, removing the need for VIRT_ADDRESS_VARIES.
8660 (PURE_P): Use a more-efficient implementation that needs just one
8661 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
8662 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
8663 to 4 (xorl, subq, cmpq, setbe).
8664 * alloc.c (pure): Always extern now, since that's the
8665 VIRT_ADDR_VARIES behavior.
8666 (PURE_POINTER_P): Use a single comparison, not two, for
8667 consistency with the new puresize.h.
8668 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
8669 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
8670 Remove VIRT_ADDR_VARIES no longer needed.
8671
f8fe6f96
EZ
86722011-11-19 Eli Zaretskii <eliz@gnu.org>
8673
8674 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
8675 (erase_phys_cursor, update_window_cursor, show_mouse_face)
8676 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
8677 behave as if the cursor position were at the window margin.
8678
8679 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
8680 and the cursor position is out of bounds, behave as if the cursor
8681 position were at the window margin. (Bug#10075)
8682
df05a53c
CY
86832011-11-18 Chong Yidong <cyd@gnu.org>
8684
8685 * window.c (Fwindow_combination_limit): Make first argument
8686 non-optional, since it is meaningless for live windows like the
8687 selected window.
61ccba97 8688
2071918e
DA
86892011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
8690
8691 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
8692
b50a28de
SM
86932011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
8694
8695 * intervals.c: Fix grafting over the whole buffer (bug#10071).
8696 (graft_intervals_into_buffer): Simplify.
8697
015137db
EZ
86982011-11-18 Eli Zaretskii <eliz@gnu.org>
8699
8700 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
8701 hash values of the two rows.
8702 (copy_row_except_pointers): Preserve the used[] arrays and the
8703 hash values of the two rows. (Bug#10035)
68c95424 8704 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
8705
8706 * xdisp.c (row_hash): New function, body extracted from
8707 compute_line_metrics.
8708 (compute_line_metrics): Call row_hash, instead of computing the
8709 hash code inline.
8710
8711 * dispnew.c (verify_row_hash): Call row_hash for computing the
8712 hash code of a row, instead of duplicating code from xdisp.c.
8713
8714 * dispextern.h (row_hash): Add prototype.
8715
a2addb04
TH
87162011-11-18 Tassilo Horn <tassilo@member.fsf.org>
8717
8718 * frame.c (delete_frame): Don't delete the terminal when the last
8719 X frame is closed if emacs is built with GTK toolkit.
8720
df85d315
JB
87212011-11-17 Juanma Barranquero <lekktu@gmail.com>
8722
8723 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
8724
a0c2d0ae
MR
87252011-11-17 Martin Rudalics <rudalics@gmx.at>
8726
8727 * window.c (Vwindow_splits): Rename to
8728 Vwindow_combination_resize. Suggested by Juri Linkov.
8729 (Fsplit_window_internal): Use Vwindow_combination_resize instead
8730 of Vwindow_splits.
8731
58179cce
JB
87322011-11-16 Juanma Barranquero <lekktu@gmail.com>
8733
7877f373
JB
8734 * nsfns.m (Fns_font_name):
8735 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 8736
b6f67890
MR
87372011-11-16 Martin Rudalics <rudalics@gmx.at>
8738
8739 * window.h (window): Rename slot "nest" to "combination_limit".
8740 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
8741 (Fset_window_nest): Rename to Fset_window_combination_limit.
8742 (Vwindow_nest): Rename to Vwindow_combination_limit.
8743 (recombine_windows, make_parent_window, make_window)
8744 (Fsplit_window_internal, saved_window)
8745 (Fset_window_configuration, save_window_save): Rename all
8746 occurrences of window_nest to window_combination_limit.
8747
c7015153
JB
87482011-11-15 Juanma Barranquero <lekktu@gmail.com>
8749
8750 * image.c (imagemagick_load_image): Fix typo.
8751
322ad6ec
EZ
87522011-11-14 Eli Zaretskii <eliz@gnu.org>
8753
8754 * xdisp.c (display_line): Move the call to
8755 highlight_trailing_whitespace before the call to
8756 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
8757 faces of all the glyphs to compute ROW's hash value.
8758 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 8759
f067b8ec
JB
87602011-11-14 Juanma Barranquero <lekktu@gmail.com>
8761
8762 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
8763 just return (bug#10044).
8764
1e5b2111
EZ
87652011-11-12 Eli Zaretskii <eliz@gnu.org>
8766
7ef3cbd5
EZ
8767 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
8768 with user-defined heap size. Bump the default size of the temacs
8769 heap to 27MB, to avoid memory warning when running temacs.
8770 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
8771
1e5b2111
EZ
8772 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
8773 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
8774 (verify_row_hash) [XASSERTS]: New function.
8775 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
8776 that the hash value of glyph rows is correct.
1e5b2111 8777
89d61221
MR
87782011-11-12 Martin Rudalics <rudalics@gmx.at>
8779
8780 * window.h (window): Remove splits slot.
8781 * window.c (Fwindow_splits, Fset_window_splits): Remove.
8782 (Fdelete_other_windows_internal, make_parent_window)
8783 (make_window, Fsplit_window_internal, Fdelete_window_internal)
8784 (Fset_window_configuration, save_window_save): Don't deal with
8785 split status of windows.
8786 (saved_window): Remove splits slot.
8787 (Vwindow_splits): Rewrite doc-string.
8788
97f18cc8
JD
87892011-11-11 Jan Djärv <jan.h.d@swipnet.se>
8790
8791 * xfns.c (unwind_create_frame):
8792 * nsfns.m (unwind_create_frame):
8793 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
8794 Vframe_list (Bug#9999).
8795
22a648b4
DA
87962011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
8797
0b381c7e 8798 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 8799
659afede
KH
88002011-11-11 Kenichi Handa <handa@m17n.org>
8801
8802 * callproc.c (Fcall_process): Set the member dst_multibyte of
8803 process_coding.
8804
9ac0394b
KH
88052011-11-11 Johan Bockgård <bojohan@gnu.org>
8806
8807 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
8808 avoid a crash (bug#9496).
8809
2fbdc249
CY
88102011-11-09 Chong Yidong <cyd@gnu.org>
8811
8812 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
8813 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
8814
ac6b1f81
PE
88152011-11-08 Paul Eggert <eggert@cs.ucla.edu>
8816
8817 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
8818
09db192c
PE
88192011-11-08 Paul Eggert <eggert@cs.ucla.edu>
8820
8821 Avoid some portability problems by eschewing 'extern inline' functions.
8822 The trivial performance wins aren't worth the portability hassles; see
8823 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
8824 et seq.
8825 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
8826 (window_box_width, window_box_left, window_box_left_offset)
8827 (window_box_right, window_box_right_offset): Undo previous change,
8828 by removing the "extern"s.
8829 * intervals.c (adjust_intervals_for_insertion)
8830 (adjust_intervals_for_deletion): Undo previous change,
8831 making these static again.
8832 (offset_intervals, temp_set_point_both, temp_set_point)
8833 (copy_intervals_to_string): No longer inline.
8834 * xdisp.c (window_text_bottom_y, window_box_width)
8835 (window_box_height, window_box_left_offset)
8836 (window_box_right_offset, window_box_left, window_box_right)
8837 (window_box): No longer inline.
8838
105216ed
CY
88392011-11-08 Chong Yidong <cyd@gnu.org>
8840
8841 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
8842 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
8843 Signal an error if not a live window.
105216ed
CY
8844 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
8845 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
8846
ae9e237f
JB
88472011-11-07 Juanma Barranquero <lekktu@gmail.com>
8848
8849 * lisp.h (syms_of_abbrev): Remove declaration.
8850 Reported by CHENG Gao <chenggao@royau.me>.
8851
c7aa8333
EZ
88522011-11-07 Eli Zaretskii <eliz@gnu.org>
8853
8854 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
8855 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
8856 of temacs in GUI mode.
8857
be7f5545
MR
88582011-11-07 Martin Rudalics <rudalics@gmx.at>
8859
8860 * window.h: Declare delete_all_child_windows instead of
8861 delete_all_subwindows.
8862 * window.c (Fwindow_nest, Fset_window_nest)
8863 (Fset_window_new_total, Fset_window_new_normal)
8864 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
8865 (delete_all_subwindows): Rename to delete_all_child_windows.
8866 (Fdelete_other_windows_internal, Fset_window_configuration):
8867 Call delete_all_child_windows instead of delete_all_subwindows.
8868 * frame.c (delete_frame): Call delete_all_child_windows instead
8869 of delete_all_subwindows.
8870
ca78dc43
PE
88712011-11-07 Paul Eggert <eggert@cs.ucla.edu>
8872
8873 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
8874 This is also needed for porting to any host where GC_MARK_STACK is
8875 not GC_MAKE_GCPROS_NOOPS.
8876 (which_symbols): Use it.
8877
a0241d01
KH
88782011-11-07 Kenichi Handa <handa@m17n.org>
8879
8880 * coding.c (coding_set_destination): Check coding->src_pos only
8881 when coding->src_object is a buffer (bug#9910).
8882
8883 * process.c (send_process): Set the member src_multibyte of coding
8884 to 0 (bug#9911) when sending a unibyte text.
8885
8886 * callproc.c (Fcall_process): Set the member src_multibyte of
8887 process_coding to 0 (bug#9912).
8888
a64bfdfa 88892011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
8890
8891 * xmenu.c (cleanup_widget_value_tree): New function.
8892 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
8893 calling free_menubar_widget_value_tree directly (Bug#9830).
8894
cb41b32a
PE
88952011-11-06 Paul Eggert <eggert@cs.ucla.edu>
8896
8897 Fix some portability problems with 'inline'.
8898 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
8899 (window_box_width, window_box_left, window_box_left_offset)
8900 (window_box_right, window_box_right_offset): Declare extern.
8901 Otherwise, these inline functions do not conform to C99 and
8902 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
8903 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
8904 * intervals.c (adjust_intervals_for_insertion)
8905 (adjust_intervals_for_deletion): Now extern, because otherwise the
8906 extern inline functions 'offset_intervals' couldn't refer to it.
8907 (static_offset_intervals): Remove.
8908 (offset_intervals): Rewrite using the old contents of
8909 static_offset_intervals. The old version didn't conform to C99
8910 because an extern inline function contained a reference to an
8911 identifier with static linkage.
8912
b7041366
AS
89132011-11-06 Andreas Schwab <schwab@linux-m68k.org>
8914
8915 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
8916 GC.
8917
88a37c4d
EZ
89182011-11-06 Eli Zaretskii <eliz@gnu.org>
8919
8920 * xdisp.c (init_iterator, reseat_to_string): Don't set the
8921 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
8922 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
8923 return Qleft_to_right.
8924
49745b39
CY
89252011-11-06 Chong Yidong <cyd@gnu.org>
8926
8927 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
8928 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
8929 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
8930 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
8931 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
8932 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
8933 (Fwindow_vscroll): Doc fix.
8934 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
8935 argument, since it makes no sense to pass a live window and for
8936 consistency with window-child.
8937
1f05cd82
CS
89382011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
8939
8940 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
8941 support MSVC.
8942
22610910
JR
89432011-11-05 Jason Rumney <jasonr@gnu.org>
8944
8945 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
8946 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
8947 fonts (Bug#6029).
8948 (add_font_entity_to_list): Fix logic errors in mixed boolean and
8949 bitwise arithmetic preventing use of unicode-sip and non-truetype
8950 opentype fonts.
8951
a06776b2
EZ
89522011-11-05 Eli Zaretskii <eliz@gnu.org>
8953
3ad924ba
EZ
8954 * s/ms-w32.h (fstat, stat, utime): Move redirections to
8955 "emacs"-only part.
8956
a06776b2
EZ
8957 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
8958 initialization code to keep similarity to xfns.c after changes
8959 from 2011-11-05.
8960
c9e7db78
JD
89612011-11-05 Jan Djärv <jan.h.d@swipnet.se>
8962
a97f8f3f
JD
8963 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
8964 (unwind_create_frame): New function (Bug#9943).
8965 (Fx_create_frame): Restructure code to be more similar to the one in
8966 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
8967 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
8968 Move terminal->reference_count++ just before making the frame official
8969 (Bug#9943).
8970
8971 * nsterm.m (x_free_frame_resources): New function.
8972 (x_destroy_window): Move code to x_free_frame_resources.
8973
c9e7db78 8974 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
8975 (Fx_create_frame, x_create_tip_frame):
8976 Move terminal->reference_count++ just before making the frame
75f1671a 8977 official. Move initialization of image_cache_refcount and
c9e7db78
JD
8978 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
8979
a6fc3b5c
EZ
89802011-11-05 Eli Zaretskii <eliz@gnu.org>
8981
8982 Support MSVC build with newer versions of Visual Studio.
8983 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
8984 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
8985 nt/gmake.defs.
8986
8987 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
8988 which are not supported by MSVC.
8989 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
8990 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
8991 bitfields.
8992 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
8993 types in bitfields.
8994 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
8995
8996 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
8997
58179cce 89982011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
8999
9000 Support MSVC build with newer versions of Visual Studio.
9001 * w32.c: Don't include w32api.h for MSVC.
9002 (init_environment) [_MSC_VER]: Call sys_access, not _access.
9003
9004 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
9005 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
9006 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
9007 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
9008 e_* cousins.
9009 (alloca) [_MSC_VER]: Define to _alloca.
9010
9011 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
9012
9013 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
9014
a58c13ed
EZ
90152011-11-04 Eli Zaretskii <eliz@gnu.org>
9016
9017 * xdisp.c (note_mouse_highlight): If either of
9018 previous/next-single-property-change returns nil, treat that as
9019 the beginning or the end of the buffer. (Bug#9955)
9020
fe0b6370
JD
90212011-11-04 Jan Djärv <jan.h.d@swipnet.se>
9022
a58c13ed 9023 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
9024 label is not null (Bug#9951).
9025 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
9026 may be NULL.
9027
89bd5ee1
EZ
90282011-11-04 Eli Zaretskii <eliz@gnu.org>
9029
9030 * window.c (Fwindow_body_size): Mention in the doc string that the
9031 return value is in frame's canonical units. (Bug#9949)
9032
84c3edb9
EZ
90332011-11-03 Eli Zaretskii <eliz@gnu.org>
9034
4e2fb5c7
EZ
9035 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
9036
84c3edb9 9037 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 9038 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 9039 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 9040
bc17a887
EZ
90412011-11-01 Eli Zaretskii <eliz@gnu.org>
9042
9043 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
9044 Don't stop backward scan on the continuation glyph, even though
9045 its CHARPOS is positive.
6d5eb5b0
SM
9046 (mouse_face_from_buffer_pos, note_mouse_highlight):
9047 Rename cover_string to disp_string.
bc17a887 9048
4ee88440
MR
90492011-11-01 Martin Rudalics <rudalics@gmx.at>
9050
9051 * window.c (temp_output_buffer_show): Don't use
9052 Vtemp_buffer_show_specifiers.
9053 (Vtemp_buffer_show_specifiers): Remove unused variable.
9054
c2ff3c02
EZ
90552011-10-30 Eli Zaretskii <eliz@gnu.org>
9056
9057 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
9058 past the beginning of the current glyph matrix.
9059
58179cce 90602011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
9061
9062 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
9063 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
9064 HAVE_GTK3 (Bug#9869).
b77a6a7f 9065
3b574623
JD
9066 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
9067 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
9068
b77a6a7f
JD
9069 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
9070
9071 * xterm.c: Declare x_handle_net_wm_state to return int.
9072 (handle_one_xevent): Check if we are iconified but don't have
9073 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
9074 (get_current_wm_state): Return non-zero if not hidden,
9075 check for _NET_WM_STATE_HIDDEN (Bug#9893).
9076 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
9077 (x_handle_net_wm_state): Return what get_current_wm_state returns.
9078 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
9079
196e41e4
PE
90802011-10-29 Paul Eggert <eggert@cs.ucla.edu>
9081
9082 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
9083 so that this new function doesn't get optimized away by a
9084 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
9085
021f2e1a
AS
90862011-10-29 Andreas Schwab <schwab@linux-m68k.org>
9087
9088 * frame.h (MOUSE_HL_INFO): Remove excess parens.
9089
8b058d44
EZ
90902011-10-29 Eli Zaretskii <eliz@gnu.org>
9091
9092 Fix the `xbytecode' command.
9093 * .gdbinit (xprintbytestr): New command.
b50a28de 9094 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
9095 (xbytecode): Print the byte-code string as well.
9096
4452fb80
EZ
90972011-10-29 Kim Storm <storm@cua.dk>
9098
8b058d44
EZ
9099 * alloc.c (which_symbols): New function.
9100
21b72067
AS
91012011-10-29 Andreas Schwab <schwab@linux-m68k.org>
9102
9103 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
9104 line. (Bug#9903)
9105
83ed7b5c
GM
91062011-10-29 Glenn Morris <rgm@gnu.org>
9107
9108 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
9109 Not clear what it was for, and it causes various bugs. (Bug#9839)
9110
5a7a728b
EZ
91112011-10-28 Eli Zaretskii <eliz@gnu.org>
9112
9113 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
9114 possible random value that matches one of those tested as
9115 condition to clear the mouse face.
9116
d3d0842f
CY
91172011-10-28 Chong Yidong <cyd@gnu.org>
9118
9119 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
9120
31b39d13
DN
91212011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
9122
9123 * window.c (make_window): Initialize phys_cursor_on_p.
9124
9aba6043
SM
91252011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
9126
9127 * lisp.h (struct Lisp_Symbol): Update comments.
9128
c20992f4
JB
91292011-10-28 Juanma Barranquero <lekktu@gmail.com>
9130
9131 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
9132
db4f02f2
EZ
91332011-10-28 Eli Zaretskii <eliz@gnu.org>
9134
9135 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
9136 <oslsachem@gmail.com> for helping to debug this.
9137
9138 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
9139 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
9140 (g_b_init_get_glyph_outline_w): New static variables.
9141 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
9142 (GetGlyphOutlineW_Proc): New typedefs.
9143 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
9144 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
9145 New functions.
9146 (w32font_open_internal, compute_metrics):
9147 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
9148 instead of calling the "wide" APIs directly.
9149
9150 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
9151
9152 * w32.h (syms_of_w32font): Add prototype.
9153
87e68db4
JB
91542011-10-27 Juanma Barranquero <lekktu@gmail.com>
9155
9156 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
9157 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
9158 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
9159 (Fmove_to_window_line): Doc fix.
9160
435c1d67
CY
91612011-10-27 Chong Yidong <cyd@gnu.org>
9162
9163 * process.c (make_process): Set gnutls_state to NULL.
9164
9165 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
9166 non-NULL, regardless of GNUTLS_INITSTAGE.
9167 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
9168 an error. Set process slots as soon as we allocate them.
9169
9170 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
9171
9c6c6f49
CY
91722011-10-27 Chong Yidong <cyd@gnu.org>
9173
9aba6043
SM
9174 * gnutls.c (emacs_gnutls_deinit): New function.
9175 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
9176 (Fgnutls_deinit, Fgnutls_boot): Use it.
9177
9178 * process.c (make_process): Initialize GnuTLS credentials to NULL.
9179 (deactivate_process): Call emacs_gnutls_deinit.
9180
657d08d3
JB
91812011-10-27 Juanma Barranquero <lekktu@gmail.com>
9182
9183 * image.c (x_create_x_image_and_pixmap):
9184 * w32.c (sys_rename, w32_delayed_load):
9185 * w32font.c (fill_in_logfont):
9186 * w32reg.c (x_get_string_resource): Silence compiler warnings.
9187
5430d399
JB
91882011-10-26 Juanma Barranquero <lekktu@gmail.com>
9189
9190 * w32fns.c (w32_default_color_map): New function,
9191 extracted from Fw32_default_color_map.
a7ef684b 9192 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 9193
fe0055fa
PE
91942011-10-25 Paul Eggert <eggert@cs.ucla.edu>
9195
9196 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
9197
e6346438
SM
91982011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
9199
9200 * keyboard.c (test_undefined): New function (bug#9751).
9201 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
9202
e112cc37
ET
92032011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
9204
9205 * sysdep.c (init_sys_modes): Fix the check for the controlling
9206 terminal (Bug#6649).
9207
7b5d6677
EZ
92082011-10-20 Eli Zaretskii <eliz@gnu.org>
9209
9210 * dispextern.h (struct bidi_it): New member next_en_type.
9211
9212 * bidi.c (bidi_line_init): Initialize the next_en_type member.
9213 (bidi_resolve_explicit_1): When next_en_pos is valid for the
9214 current character, check also for next_en_type being WEAK_EN.
9215 (bidi_resolve_weak): Don't enter the expensive loop if the current
9216 position is before next_en_pos. Record the bidi type of the first
9217 non-ET, non-BN character we find, in addition to its position.
9218 (bidi_level_of_next_char): Invalidate next_en_type when
9219 next_en_pos is over-stepped.
9220
7da0b018
PE
92212011-10-20 Paul Eggert <eggert@cs.ucla.edu>
9222
9223 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
9224 * editfns.c: Rewrite current-time-zone so that it invokes
9225 the equivalent of (format-time-string "%Z") to get the time zone name.
9226 This fixes a bug when the time zone name contains characters that
9227 need converting from the system time locale to Emacs internal format.
9228 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
9229 that patch fixed format-time-string to do the conversion, but
9230 I forgot to fix current-time-zone.
9231 (format_time_string): New function, containing most of
9232 what Fformat_time_string used to contain.
9233 (Fformat_time_string): Rewrite in terms of format_time_string.
9234 This doesn't change this function's behavior.
9235 (current-time-zone): Rewrite to use format_time_string.
9236 This fixes the bug reported by Michael Schierl in
9237 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
9238 Jason Rumney's 2007-06-07 change worked around this bug, but
9239 didn't fix it.
9240 * systime.h (tzname, timezone): Remove no-longer-used declarations.
9241
8547b010
EZ
92422011-10-19 Eli Zaretskii <eliz@gnu.org>
9243
9244 * xdisp.c (start_display): If the character at POS is displayed
9245 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
9246 (try_window_reusing_current_matrix): If a line ends in a display
9247 vector or the next line starts in a display vector, continue
9248 redrawing the window even though the character position of
9249 start_row was reached.
8547b010
EZ
9250 (Bug#9771, part 2)
9251
4e948d15
CY
92522011-10-18 Chong Yidong <cyd@gnu.org>
9253
9254 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
9255 with nobreak-char-display too.
9256
4787455f
EZ
92572011-10-18 Eli Zaretskii <eliz@gnu.org>
9258
9259 Fix part 3 of bug#9771.
9260 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
9261 (bidi_resolve_neutral): Don't enter the expensive loop looking for
9262 non-neutral characters if the current character is a paragraph
9263 separator (a.k.a. Newline). This avoids running the same
9264 expensive loop twice, once when we consume the preceding newline
9265 and the other time when the line actually needs to be displayed.
9266 Avoid the loop when we see neutrals on the base embedding level
9267 following a character whose directionality is the same as the
9268 paragraph's. This avoids running the expensive loop when a line
9269 ends in a long sequence of neutrals, like control characters.
9270 Add assertion against STRONG_AL type. Slightly rearrange code
9271 that determines the type of a neutral given the first non-neutral
9272 that follows it.
9273 (bidi_level_of_next_char): Set next_en_pos to zero when
9274 invalidating its info.
9275
2c91f553
EZ
92762011-10-17 Eli Zaretskii <eliz@gnu.org>
9277
9278 * xdisp.c (push_display_prop): Determine whether to record string
9279 or buffer position by IT->string, not by IT->method. Allow
9280 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
9281 (move_it_vertically_backward): Don't look for character position
9282 immediately after the newline when in a continuation line.
9283 (Bug#9771, part 1)
2c91f553 9284
c7b08b0d
MR
92852011-10-15 Martin Rudalics <rudalics@gmx.at>
9286
9287 * window.c (coordinates_in_window): Rewrite and delabelize
9288 vertical border check. (Bug#5357) (Bug#9618)
9289
6b02f655
SM
92902011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
9291
9292 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
9293 errors in XSetWindowBorder (bug#9310).
9294
81d40c92
DA
92952011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
9296
9297 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
9298 avoid crash when xmalloc overrun checking is enabled.
9299
d4172c3b
EZ
93002011-10-13 Eli Zaretskii <eliz@gnu.org>
9301
9302 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
9303 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
9304 cursor motion with <left> and <right> arrow keys.
9305
9306 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
9307 some callers set that themselves.
9308
b00eea75
EZ
93092011-10-12 Eli Zaretskii <eliz@gnu.org>
9310
9311 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
9312 display string and the previous row comes from the same string and
9313 is empty. (Bug#9739) (Bug#9738)
9314
8fe012c4
SM
93152011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
9316
9317 * doc.c (get_doc_string): Encode file name (bug#9735).
9318
0074aef2
EZ
93192011-10-12 Eli Zaretskii <eliz@gnu.org>
9320
79beb178
EZ
9321 * bidi.c (bidi_level_of_next_char):
9322 * xdisp.c (get_visually_first_element): Remove old incorrect
9323 comments regarding the Unicode Line Separator character.
9324
0074aef2
EZ
9325 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
9326
6e4b3fbe
DA
93272011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
9328
9329 * alloc.c (Fgc_status): Do not access beyond zombies array
9330 boundary if nzombies > MAX_ZOMBIES.
9331 * alloc.c (dump_zombies): Add missing format specifier.
9332
0324f3af
PE
93332011-10-12 Paul Eggert <eggert@cs.ucla.edu>
9334
b5525cac
PE
9335 * xdisp.c (set_cursor_from_row): Simplify conditionals,
9336 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
9337
0324f3af
PE
9338 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
9339 Some packages use them to denote characters with modifiers.
9340
e9b5f888
AS
93412011-10-11 Andreas Schwab <schwab@linux-m68k.org>
9342
9343 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
9344 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
9345 matching a pp-number. Rename parameter var to var1.
9346
127827c0
SM
93472011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
9348
9349 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
9350
c8fd3bd0
GM
93512011-10-08 Glenn Morris <rgm@gnu.org>
9352
9353 * callint.c (Fcall_interactively): Give a more explicit error for the
9354 'c' case with a non-character input. (Bug#8479)
9355
352ec8ff
EZ
93562011-10-08 Eli Zaretskii <eliz@gnu.org>
9357
03669ccb
EZ
9358 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
9359 lines.
7061c986
EZ
9360 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
9361 lines that are hscrolled on the left.
03669ccb 9362
352ec8ff
EZ
9363 * dispnew.c (buffer_posn_from_coords): Account for a possible
9364 presence of header-line. (Bug#4426)
9365
a66cfb1c
SM
93662011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
9367
6b02f655
SM
9368 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
9369 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 9370
7c5ee88e
PE
93712011-10-07 Paul Eggert <eggert@cs.ucla.edu>
9372
9373 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
9374 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
9375 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
9376 this makes Emacs dump core during garbage collection on rare
9377 occasions. sizeof is obviously inferior to offsetof here, so
9378 stick with offsetof.
9379 (GC_POINTER_ALIGNMENT): New macro.
9380 (mark_memory): Omit 3rd (offset) arg; caller changed.
9381 Don't assume EMACS_INT alignment is the same as pointer alignment.
9382
df1bbe5b
SM
93832011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
9384
9385 * keyboard.c (read_key_sequence_remapped): New var.
9386 (read_key_sequence): Compute remapping in the right buffer.
9387 (command_loop_1): Use read_key_sequence's remapping directly.
9388
51553db6
SM
93892011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
9390
32c1fffd
SM
9391 * dired.c (file_name_completion): Don't expand file name.
9392 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
9393 before checking file name handler.
9394
51553db6
SM
9395 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
9396 they've been requested explicitly (bug#9591).
9397
b6bd1599 93982011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
9399
9400 * keymap.c (Fsingle_key_description): Use make_specified_string
9401 instead of build_string to build string from push_key_description.
9402 (Bug#5193)
9403
f701dc2a
PE
94042011-09-30 Paul Eggert <eggert@cs.ucla.edu>
9405
4222c55d
PE
9406 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
9407 This fixes a Y2038 bug on 64-bit hosts.
9408 * buffer.c (reset_buffer):
9409 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
9410 (Fclear_buffer_auto_save_failure):
9411 Use 0, not -1, to represent an unset failure time, since time_t
9412 might not be signed.
9413
f701dc2a
PE
9414 Remove dependency on glibc malloc internals.
9415 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
9416 Move back here from lisp.h, but with their new implementations.
9417 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
9418 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
9419 * charset.c (charset_table_init): New static var.
9420 (syms_of_charset): Use it instead of xmalloc. This removes a
9421 dependency on glibc malloc internals. See Eli Zaretskii's comment in
9422 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
9423 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
9424 Move back to alloc.c.
9425 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
9426 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
9427
9ceebf39
JD
94282011-09-30 Jan Djärv <jan.h.d@swipnet.se>
9429
9430 * nsterm.m (windowDidResize): Call x_set_window_size only when
9431 ns_in_resize is true. Otherwise set pixelwidth/height and
9432 call change_frame_size (Bug#9628).
9433
cb993c58
PE
94342011-09-30 Paul Eggert <eggert@cs.ucla.edu>
9435
3930c88b
PE
9436 Port --enable-checking=all to Fedora 14 x86-64.
9437 * charset.c (syms_of_charset): Also account for glibc malloc's
9438 internal overhead when calculating the initial malloc maximum.
9439
cb993c58
PE
9440 Port --enable-checking=all to Fedora 14 x86.
9441 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
9442 Move to lisp.h.
9443 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
9444 (overrun_check_realloc, overrun_check_free):
9445 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
9446 That way, xmalloc returns a properly-aligned pointer even if
9447 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
9448 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
9449 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
9450 into account when calculating the initial malloc maximum.
9451 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
9452 Move here from alloc.c, so that charset.c can use it too.
9453 Properly align; the old code wasn't right for common 32-bit hosts
9454 when configured with --enable-checking=all.
9455 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
9456 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
9457
31bed486
EZ
94582011-09-29 Eli Zaretskii <eliz@gnu.org>
9459
04c70788 9460 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
9461 use EDOM.
9462
fbcaa2f3
EZ
94632011-09-28 Eli Zaretskii <eliz@gnu.org>
9464
9465 * xdisp.c (compute_display_string_end): If there's no display
9466 string at CHARPOS, return -1.
9467
9468 * bidi.c (bidi_fetch_char): When compute_display_string_end
9469 returns a negative value, treat the character as a normal
9470 character not covered by a display string. (Bug#9624)
9471
a239d4e9
JB
94722011-09-28 Juanma Barranquero <lekktu@gmail.com>
9473
9474 * lread.c (Fread_from_string): Fix typo in docstring.
9475
88652fd5
EZ
94762011-09-27 Eli Zaretskii <eliz@gnu.org>
9477
9478 * xdisp.c (handle_invisible_prop): If invisible text ends on a
9479 newline, reseat the iterator instead of bidi-iterating there one
9480 character at a time. (Bug#9610)
32c1fffd
SM
9481 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
9482 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 9483
ed497dd4
AS
94842011-09-27 Andreas Schwab <schwab@linux-m68k.org>
9485
9486 * lread.c (readevalloop): Use correct code for NBSP.
9487 (read1): Likewise. (Bug#9608)
9488
b2bf61aa
MA
94892011-09-25 Michael Albinus <michael.albinus@gmx.de>
9490
9491 * dbusbind.c (Fdbus_register_signal): When service is not
9492 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
9493
32bbb17c
GM
94942011-09-25 Glenn Morris <rgm@gnu.org>
9495
9496 * buffer.c (truncate-lines): Doc fix.
9497
94e0933e
CY
94982011-09-24 Chong Yidong <cyd@stupidchicken.com>
9499
9500 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
9501 (Fset_window_next_buffers): Doc fix.
9502
cddde921
GM
95032011-09-24 Glenn Morris <rgm@gnu.org>
9504
9505 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
9506
1260aef1
PE
95072011-09-24 Paul Eggert <eggert@cs.ucla.edu>
9508
25b4bfa0
PE
9509 Fix minor problems found by static checking.
9510 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
9511 * indent.c (Fvertical_motion): Fix == vs = typo.
9512
e3cbd34b
EZ
95132011-09-24 Eli Zaretskii <eliz@gnu.org>
9514
a66cfb1c
SM
9515 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
9516 Default value is now t. Doc fix.
6bf7006f 9517
e3cbd34b 9518 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 9519 logic when moving up, not only when moving down. Fix the
e3cbd34b 9520 confusing name and values of the it_overshoot_expected variable;
32c1fffd 9521 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
9522
9523 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
9524 CHARPOS is covered by a display string which includes newlines.
9525 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
9526 is covered by a display string with embedded newlines.
9527
a3de0cbd
MA
95282011-09-24 Michael Albinus <michael.albinus@gmx.de>
9529
9530 * dbusbind.c (Fdbus_register_signal): Add match rule to
9531 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
9532 (Fdbus_register_method, Vdbus_registered_objects_table):
9533 Fix docstring.
a3de0cbd 9534
b260039d
JM
95352011-09-24 Jim Meyering <meyering@redhat.com>
9536
32c1fffd 9537 do not ignore write error for any output size
b260039d
JM
9538 The previous change was incomplete.
9539 While it makes emacs --batch detect the vast majority of stdout
9540 write failures, errors were still ignored whenever the output size is
9541 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
9542 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
9543 && echo FAIL: ignored write error
9544 FAIL: ignored write error
9545 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
9546 && echo FAIL: ignored write error
9547 FAIL: ignored write error
9548 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
9549
8eca8a7c
AS
95502011-09-23 Andreas Schwab <schwab@linux-m68k.org>
9551
9552 * emacs.c (Fkill_emacs): In noninteractive mode exit
9553 non-successfully if a write error occurred on stdout. (Bug#9574)
9554
3341db62
EZ
95552011-09-21 Eli Zaretskii <eliz@gnu.org>
9556
9557 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
9558 the xassert test.
9559
9560 * dispextern.h (struct it): Update the comment documenting what
9561 can it->OBJECT be.
9562
8c203dbf
EZ
95632011-09-20 Eli Zaretskii <eliz@gnu.org>
9564
9565 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
9566 a display string, extend search for cursor position to end of row.
9567 (find_row_edges): If the row ends in a newline from a display
9568 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
9569 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
9570 (Fcurrent_bidi_paragraph_direction): Fix search for previous
9571 non-empty line. Fixes confusing cursor motion with arrow keys at
9572 the beginning of a line that starts with whitespace.
8c203dbf 9573
a4824228
LMI
95742011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
9575
9576 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
9577 (bug#9493).
9578
33ed493b
CY
95792011-09-18 Chong Yidong <cyd@stupidchicken.com>
9580
9581 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
9582 boolean (Bug#9154).
9583
56cd55c8
EZ
95842011-09-18 Eli Zaretskii <eliz@gnu.org>
9585
9586 * xdisp.c (display_line): Record maximum and minimum buffer
9587 positions even if no glyphs were produced (e.g., by a zero-width
9588 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
9589 buffer positions that will be removed from the glyph row because
9590 they don't fit.
c02dcedf
EZ
9591 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
9592 column is beyond frame width: don't subtract 1 "pixel" when
9593 computing width of the stretch.
3e62b7e0
EZ
9594 (reseat_at_next_visible_line_start): Undo the change made on
9595 2011-09-17 that saved paragraph information and restored it after
9596 the call to `reseat'. (Bug#9545)
56cd55c8 9597
5ed99d36 95982011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
9599
9600 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
9601 and turn window cursor on if cleared (Bug#9415).
9602
5ed99d36 96032011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
9604
9605 * search.c (boyer_moore): Take unibyte characters from pattern
9606 literally. (Bug#9458)
9607
9bade7b2
EZ
96082011-09-18 Eli Zaretskii <eliz@gnu.org>
9609
9610 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
9611
e5e9d610
PE
96122011-09-18 Paul Eggert <eggert@cs.ucla.edu>
9613
87e4427a
PE
9614 Fix minor problem found by static checking.
9615 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
9616 initialized, to pacify gcc -Wuninitialized.
9617
e5e9d610
PE
9618 * fileio.c: Report proper errno when syscall falls.
9619 (Finsert_file_contents): Save and restore errno,
9620 so that report_file_error outputs the correct diagnostic.
9621 (Fwrite_region) [CLASH_DETECTION]: Likewise.
9622
a1674f0b
EZ
96232011-09-18 Eli Zaretskii <eliz@gnu.org>
9624
9625 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
9626
fbfb6dd4
EZ
96272011-09-17 Eli Zaretskii <eliz@gnu.org>
9628
9629 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
9630 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
9631
bb187662
EZ
96322011-09-17 Eli Zaretskii <eliz@gnu.org>
9633
1137e8b8 9634 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 9635 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
9636
9637 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
9638 (bidi_find_paragraph_start): Search back for paragraph beginning
9639 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
9640 (bidi_move_to_visually_next): Only trigger paragraph-related
9641 computations when the last character is a newline or at EOB, not
9642 just any NEUTRAL_B. (Bug#9470)
9643
bb187662
EZ
9644 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
9645 truncated lines if point is covered by a display string. (Bug#9524)
9646
2e621251
PE
96472011-09-16 Paul Eggert <eggert@cs.ucla.edu>
9648
9649 * xselect.c: Relax test for outgoing X longs (Bug#9498).
9650 (cons_to_x_long): New function.
9651 (lisp_data_to_selection_data): Use it. Correct the test for
9652 short-versus-long data; it was negated. Break out of vector
9653 loop, for efficiency, when a long datum is discovered.
9654
91a15bc6
SM
96552011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
9656
9657 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
9658
b41c3a35
EZ
96592011-09-16 Eli Zaretskii <eliz@gnu.org>
9660
9661 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
9662 GCC PR/17406) by declaring this function with external scope.
9663
7812ba2d
PE
96642011-09-15 Paul Eggert <eggert@cs.ucla.edu>
9665
9666 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
9667 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
9668
cf7edc2a
AS
96692011-09-15 Andreas Schwab <schwab@linux-m68k.org>
9670
9671 * editfns.c (Fformat): Correctly handle text properties on "%%".
9672
bd01620e
EZ
96732011-09-15 Eli Zaretskii <eliz@gnu.org>
9674
9675 * xterm.c (x_draw_composite_glyph_string_foreground):
9676 * w32term.c (x_draw_composite_glyph_string_foreground):
9677 * term.c (encode_terminal_code):
9678 * composite.c (composition_update_it, get_composition_id):
9679 * xdisp.c (get_next_display_element)
9680 (fill_composite_glyph_string): Add comments about special meaning
9681 of TAB characters in a composition.
9682
a02719a3
PE
96832011-09-15 Paul Eggert <eggert@cs.ucla.edu>
9684
9685 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
9686 This occurs when processing a multibyte format.
9687 Problem reported by Wolfgang Jenker.
a02719a3 9688
72589a3c
JB
96892011-09-15 Johan Bockgård <bojohan@gnu.org>
9690
9691 * xdisp.c (try_cursor_movement): Only check for exact match if
9692 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
9693
1c14176c
PE
96942011-09-14 Paul Eggert <eggert@cs.ucla.edu>
9695
9696 Remove unused external symbols.
9697 * dispextern.h (calc_pixel_width_or_height): Remove decl.
9698 * xdisp.c (calc_pixel_width_or_height): Now static.
9699 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
9700 * indent.c (check_display_width):
9701 * w32term.c: Fix comment to match code.
9702 * xterm.c, xterm.h (x_catching_errors): Remove.
9703
d2eea5b5
PE
97042011-09-14 Paul Eggert <eggert@cs.ucla.edu>
9705
9706 * xselect.c: Use signed conversions more consistently (Bug#9498).
9707 (selection_data_to_lisp_data): Assume incoming selection data are
9708 signed integers, not unsigned. This is to be consistent with
9709 outgoing selection data, which was modified to use signed integers
9710 in as part of the fix to Bug#9196 in response to Jan D.'s comment
9711 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
9712 expects long, not unsigned long.
9713
46888499
EZ
97142011-09-14 Eli Zaretskii <eliz@gnu.org>
9715
9716 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
9717 computation of loop end. Reported by Johan Bockgård
9718 <bojohan@gnu.org>.
9719
ef8ef9fb
CY
97202011-09-13 Chong Yidong <cyd@stupidchicken.com>
9721
9722 * frame.c (Fother_visible_frames_p): Function deleted.
9723
fa819fed
EZ
97242011-09-12 Eli Zaretskii <eliz@gnu.org>
9725
9726 * indent.c (compute_motion): Process display vector front to back
9727 rather than the other way around. (Bug#2496)
9728
2ba8e008
SM
97292011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
9730
9731 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
9732
20f53c69
CY
97332011-09-11 Chong Yidong <cyd@stupidchicken.com>
9734
9735 * minibuf.c (Fread_from_minibuffer): Doc fix.
9736
d562d7a4
EZ
97372011-09-11 Eli Zaretskii <eliz@gnu.org>
9738
9739 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
9740 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
9741
1c4d7f3d
LMI
97422011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
9743
9744 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
9745 value for non-existent files.
9746
b885bf36
EZ
97472011-09-11 Eli Zaretskii <eliz@gnu.org>
9748
9749 * fileio.c (Finsert_file_contents): If the file cannot be opened,
9750 set its "size" to -1. This will set the modtime_size field of
9751 the corresponding buffer to -1, which is what
9752 verify-visited-file-modtime expects for files that do not exist.
9753 (Bug#9139)
9754
6612f0bf
PE
97552011-09-11 Paul Eggert <eggert@cs.ucla.edu>
9756
9757 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
9758 here ...
9759 * lisp.h: ... from here. push_key_description is no longer
9760 defined in keyboard.c, so its declaration should not be in
9761 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
9762 logically belongs with push_key_description.
9763
dfb3f755
PE
97642011-09-10 Paul Eggert <eggert@cs.ucla.edu>
9765
9766 * buffer.h: Include <sys/types.h> instead of <time.h>.
9767 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
9768 Problem reported by Herbert J. Skuhra.
9769
3134906c
LMI
97702011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
9771
9772 * xml.c (parse_region): Make the parsing work for
9773 non-comment-starting XML files again (bug#9144).
9774
8d903f4e
AS
97752011-09-10 Andreas Schwab <schwab@linux-m68k.org>
9776
9777 * image.c (gif_load): Fix calculation of bottom and right corner.
9778 (Bug#9468)
9779
80ad64f4
EZ
97802011-09-10 Eli Zaretskii <eliz@gnu.org>
9781
9782 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
9783 redisplay in small windows.
9784
208a048d
EZ
97852011-09-09 Eli Zaretskii <eliz@gnu.org>
9786
9787 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
9788
9b1c252e
MR
97892011-09-08 Martin Rudalics <rudalics@gmx.at>
9790
9791 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
9792 Operate on live windows only.
9793
2949f33b
JB
97942011-09-08 Juanma Barranquero <lekktu@gmail.com>
9795
9796 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
9797
e08dcafd
EZ
97982011-09-07 Eli Zaretskii <eliz@gnu.org>
9799
9800 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
9801 only under bidi iteration.
9802
115b96bd
JD
98032011-09-07 Jan Djärv <jan.h.d@swipnet.se>
9804
9805 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
9806
c8199d0f
PE
98072011-09-06 Paul Eggert <eggert@cs.ucla.edu>
9808
9809 isnan: Fix porting problem to Solaris 10 with bundled gcc.
9810 Without this fix, the command to link temacs failed due to an
9811 undefined symbol __builtin_isnan. This is because
9812 /usr/include/iso/math_c99.h #defines isnan(x) to
9813 __builtin_isnan(x), but the bundled gcc, which identifies itself
9814 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
9815 a __builtin_isnan.
9816 * floatfns.c (isnan): #undef, and then #define to a clone of
9817 what's in data.c.
9818 (Fisnan): Always define, since it's always available now.
9819 (syms_of_floatfns): Always define isnan at the Lisp level.
9820
e39b275c 98212011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
9822
9823 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
9824
b2db44d9 98252011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 9826
f4af5137 9827 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
9828 The previous code assumed that file offsets (off_t values) fit in
9829 EMACS_INT variables, which is not true on typical 32-bit hosts.
9830 The code messed up by falsely reporting buffer overflow in cases
9831 such as (insert-file-contents "big" nil 1 2) into an empty buffer
9832 when "big" contains more than 2**29 bytes, even though this
9833 inserts just one byte and does not overflow the buffer.
9834 (Finsert_file_contents): Store file offsets as off_t
9835 values, not as EMACS_INT values. Check for overflow when
9836 converting between EMACS_INT and off_t. When checking for
9837 buffer overflow or for overlap, take the offsets into account.
9838 Don't use EMACS_INT for small values where int suffices.
9839 When checking for overlap, fix a typo: ZV was used where
9840 ZV_BYTE was intended.
9841 (Fwrite_region): Don't assume off_t fits into 'long'.
9842 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
9843
ecfc0a49
MA
98442011-09-05 Michael Albinus <michael.albinus@gmx.de>
9845
9846 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
9847
6511acf2 98482011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 9849
0999621a 9850 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
9851
9852 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 9853 (esprintf, exprintf, evxprintf): New functions.
62f19c19 9854 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 9855 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
9856 (modify_event_symbol): Do not assume that the length of
9857 name_alist_or_stem is safe to alloca and fits in int.
9858 (Fexecute_extended_command): Likewise for function name and binding.
9859 (Frecursion_depth): Wrap around reliably on integer overflow.
9860 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
9861 since some callers pass EMACS_INT values.
9862 (Fsingle_key_description): Don't crash if symbol name contains more
9863 than MAX_ALLOCA bytes.
9864 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
9865 (get_minibuffer): Arg is now EMACS_INT, not int.
9866 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 9867 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
9868 * window.h (command_loop_level, minibuf_level): Reflect API changes.
9869
2be7d702
PE
9870 * dbusbind.c (signature_cat): New function.
9871 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
9872 Do not overrun buffer; instead, report string overflow.
9873
9d1df220
PE
9874 * dispnew.c (add_window_display_history): Don't overrun buffer.
9875 Truncate instead; this is OK since it's just a log.
9876
33ef5c64
PE
9877 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
9878 even if the time zone offset is outlandishly large.
9879 Don't mishandle offset == INT_MIN.
9880
66c6fdd5
PE
9881 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
9882 when creating daemon; the previous buffer-overflow check was incorrect.
9883
d749b01b
PE
9884 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
9885 which has the guts of the old verror function.
9886
b5cd1905
PE
9887 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
9888 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
9889
6e1a67fb
PE
9890 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
9891 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 9892 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 9893 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
9894 length of string rather than counting it via multiple sprintfs;
9895 that's simpler and more reliable.
c21721cc
PE
9896 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
9897 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
9898 sprintf, in case result does not fit in int.
9899
c57b67fc
PE
9900 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
9901 (fontset_from_font): Print it.
9902
8a401434
PE
9903 * frame.c (tty_frame_count): Now printmax_t, not int.
9904 (make_terminal_frame, set_term_frame_name): Print it.
9905 (x_report_frame_params): In X, window IDs are unsigned long,
9906 not signed long, so print them as unsigned.
9907 (validate_x_resource_name): Check for implausibly long names,
9908 and don't assume name length fits in 'int'.
9909 (x_get_resource_string): Don't blindly alloca invocation name;
9910 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
9911 not fit in int.
9912
6e1a67fb
PE
9913 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
9914 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
9915 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
9916
0df02bf3
PE
9917 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
9918 Use esprintf, not sprintf, in case result does not fit in int.
9919
48e30793
PE
9920 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
9921 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
9922 it as a large positive number.
9923 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
9924 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
9925
a66ff6d8
PE
9926 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
9927 in case result does not fit in int.
9928
aca216ff
PE
9929 * print.c (float_to_string): Detect width overflow more reliably.
9930 (print_object): Make sprintf buffer a bit bigger, to avoid potential
9931 buffer overrun. Don't assume list length fits in 'int'. Treat
9932 print length of 0 as 0, not as infinity; to be consistent with other
9933 uses of print length in this function. Don't overflow print length
9934 index. Don't assume hash table size fits in 'long', or that
9935 vectorlike size fits in 'unsigned long'.
9936
31c286f7
PE
9937 * process.c (make_process): Use printmax_t, not int, to format
9938 process-name gensyms.
9939
55e5faa1
PE
9940 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
9941
80f2e268
PE
9942 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
9943 to avoid potential buffer overrun.
9944
670741ab
PE
9945 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
9946 if X resource line is longer than 512 bytes.
9947
b7163a50
PE
9948 * xfns.c (x_window): Make sprintf buffer a bit bigger
9949 to avoid potential buffer overrun.
9950
ae58ff1f
PE
9951 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
9952
c43c8a6a
PE
9953 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
9954
3f8236f4
PE
99552011-09-04 Paul Eggert <eggert@cs.ucla.edu>
9956
53e9fe90 9957 Integer overflow fixes for scrolling, etc.
6511acf2
PE
9958 Without these, Emacs silently mishandles large integers sometimes.
9959 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
9960 it were "C-u 1 M-x recenter" on a typical 64-bit host.
9961
6511acf2
PE
9962 * xdisp.c (try_window_id): Check Emacs fixnum range before
9963 converting to 'int'.
806add1d 9964
6511acf2 9965 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
9966 Check that an Emacs fixnum is in range before assigning it to 'int'.
9967 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
9968 values converted from Emacs fixnums.
9969 (Frecenter): Don't wrap around a line count if it is out of 'int'
9970 range; instead, treat it as an extreme value.
9971 (Fset_window_configuration, compare_window_configurations):
9972 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
9973
6511acf2
PE
9974 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
9975 that can exceed INT_MAX. Check that EMACS_INT value is in range
9976 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
9977 (match_limit): Don't assume that a fixnum can fit in 'int'.
9978
6511acf2 9979 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
9980 exceed INT_MAX.
9981
6511acf2 9982 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
9983 (Fvertical_motion): Don't wrap around LINES values that don't fit
9984 in 'int'. Instead, treat them as extreme values. This is good
9985 enough for windows, which can't have more than INT_MAX lines anyway.
9986
fcb901a7
LMI
99872011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9988
0f2f6b6d
LMI
9989 * Require libxml/parser.h to avoid compilation warning.
9990
fcb901a7
LMI
9991 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
9992
9993 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
9994 since this reportedly can destroy thread storage.
9995
6e20a0d4
CY
99962011-08-30 Chong Yidong <cyd@stupidchicken.com>
9997
9998 * syntax.c (find_defun_start): Update all cache variables if
9999 exiting early (Bug#9401).
10000
148ae00e
EZ
100012011-08-30 Eli Zaretskii <eliz@gnu.org>
10002
f6cfbd8f
EZ
10003 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
10004
148ae00e
EZ
10005 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
10006 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
10007 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
10008
10009 * term.c (tty_append_glyph): New function.
10010 (produce_stretch_glyph): Static function and its prototype deleted.
10011
a66cfb1c
SM
10012 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
10013 Add prototypes.
148ae00e 10014
c4a07a4c
PE
100152011-08-29 Paul Eggert <eggert@cs.ucla.edu>
10016
10017 * image.c (parse_image_spec): Check for nonnegative, not for positive,
10018 when checking :margin (Bug#9390).
10019 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 10020 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
10021 so that the name doesn't mislead. All uses changed.
10022
6bc8cd65
JB
100232011-08-28 Johan Bockgård <bojohan@gnu.org>
10024
10025 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
10026 set_tty_hooks.
10027
dca4927e
EZ
100282011-08-27 Eli Zaretskii <eliz@gnu.org>
10029
10030 * xdisp.c (move_it_to): Don't bail out early when reaching
10031 position beyond to_charpos, if we are scanning backwards.
10032 (move_it_vertically_backward): When DY == 0, make sure we get to
10033 the first character in the line after the newline.
10034
f2cad773
PE
100352011-08-27 Paul Eggert <eggert@cs.ucla.edu>
10036
10037 * ccl.c: Improve and simplify overflow checking (Bug#9196).
10038 (ccl_driver): Do not generate an out-of-range pointer.
10039 (Fccl_execute_on_string): Remove unnecessary check for
10040 integer overflow, noted by Stefan Monnier in
10041 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
10042 Remove a FIXME that didn't need fixing.
10043 Simplify the newly-introduced buffer reallocation code.
10044
0cae2cdb
JB
100452011-08-27 Juanma Barranquero <lekktu@gmail.com>
10046
10047 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
10048
5fc295a4 100492011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 10050
70c60eb2 10051 Integer and memory overflow issues (Bug#9196).
726e0ab1 10052
d31850da
PE
10053 * doc.c (get_doc_string): Rework so that
10054 get_doc_string_buffer_size is the actual buffer size, rather than
10055 being 1 less than the actual buffer size; this makes xpalloc more
10056 convenient.
10057
a69fbedb
PE
10058 * image.c (x_allocate_bitmap_record, cache_image):
10059 * xselect.c (Fx_register_dnd_atom):
10060 Simplify previous changes by using xpalloc.
10061
fe5c5d37
PE
10062 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
10063 since either will do and ptrdiff_t is convenient with xpalloc.
10064
0065d054
PE
10065 * charset.c (charset_table_size)
10066 (struct charset_sort_data.priority): Now ptrdiff_t.
10067 (charset_compare): Don't overflow if priorities differ greatly.
10068 (Fsort_charsets): Don't assume list length fits in int.
10069 Check for size-calculation overflow when allocating sort data.
10070 (syms_of_charset): Allocate an initial charset table that is
10071 just under 64 KiB, to avoid problems with glibc malloc and mmap.
10072
10073 * cmds.c (internal_self_insert): Check for size-calculation overflow.
10074
10075 * composite.h (struct composition.glyph_len): Now int, not unsigned.
10076 The actual value is always <= INT_MAX, and leaving it unsigned made
10077 overflow checking harder.
10078
10079 * dispextern.h (struct glyph_matrix.rows_allocated)
10080 (struct face_cache.size): Now ptrdiff_t, for convenience in use
10081 with xpalloc. The values are still always <= INT_MAX.
10082
10083 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
10084
10085 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
10086 (SAFE_NALLOCA): New macro.
10087
10088 * region-cache.c (struct boundary.pos, find_cache_boundary)
10089 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
10090 (set_cache_region, invalidate_region_cache)
10091 (revalidate_region_cache, know_region_cache, region_cache_forward)
10092 (region_cache_backward, pp_cache):
10093 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
10094 so that ptrdiff_t * can be passed to xpalloc.
10095 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
10096 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
10097 (pp_cache): Don't assume cache_len fits in int.
10098 * region-cache.h: Adjust extern decls to match.
10099
10100 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
10101 EMACS_INT, since either will do, for xpalloc.
10102
10103 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
10104 (xnmalloc, xnrealloc, xpalloc): New functions.
10105
726e0ab1
PE
10106 * bidi.c (bidi_shelve_header_size): New constant.
10107 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
10108 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
10109
51f30bc5 10110 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
10111 * buffer.c (overlays_at, overlays_in, record_overlay_string)
10112 (overlay_strings):
10113 Don't update size of array until after memory allocation succeeds,
10114 because xmalloc/xrealloc may not return.
0065d054
PE
10115 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
10116 now that we have proper integer overflow checking.
10117 (record_overlay_string, overlay_strings): Catch overflows when
10118 calculating size of overlay_str_buf.
726e0ab1 10119
0065d054
PE
10120 * callproc.c (Fcall_process): Check for size overflow when
10121 calculating size of args2.
10122 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
10123 Normally we prefer signed values, but sticking with ptrdiff_t would
10124 require adding more-complicated checks.
726e0ab1
PE
10125
10126 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
10127 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
10128 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 10129 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
10130
10131 * character.c (Fstring): Check for size-calculation overflow.
10132
10133 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
10134 unnecessary integer overflow. Check for size overflow.
10135 (encode_coding_object): Don't update size until xmalloc succeeds.
10136
10137 * composite.c (get_composition_id): Check for overflow in glyph
10138 length calculations.
10139
10140 Integer and memory overflow fixes for display code.
10141 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
10142 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
10143 (scrolling_window): Check for overflow in size calculations.
10144 (line_draw_cost, realloc_glyph_pool, add_row_entry):
10145 Don't assume glyph table len fits in int.
10146 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
10147 (row_table_size): Now ptrdiff_t, not int.
10148 (scrolling_window): Avoid overflow in size calculations.
10149 Don't update size until allocation succeeds.
10150 * fns.c (concat): Check for overflow in size calculations.
10151 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
10152 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
10153 (NEXT_ALMOST_PRIME_LIMIT): New constant.
10154
10155 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
10156 (get_doc_string): Check for size calculation overflow.
10157 Don't update size until allocation succeeds.
10158 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
10159 EMACS_INT, where ptrdiff_t will do.
10160 (Fsubstitute_command_keys): Check for string overflow.
10161
10162 * editfns.c (set_time_zone_rule): Don't assume environment length
10163 fits in int.
10164 (message_length): Now ptrdiff_t, not int.
10165 (Fmessage_box): Don't update size until allocation succeeds.
10166 Don't assume message length fits in int.
10167 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
10168
0065d054
PE
10169 * emacs.c (main): Do not reallocate argv, since there is a null at
10170 the end that can be overwritten, and this way there's no need to
10171 worry about size-calculation overflow.
10172 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
10173
10174 * eval.c (init_eval_once, grow_specpdl): Don't update size until
10175 alloc succeeds.
10176 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
10177
10178 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
10179 (x_set_scroll_bar_width, x_figure_window_size):
10180 Check for integer overflow.
10181 (x_set_alpha): Do not assume XINT fits in int.
10182
10183 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
10184 This is for the members text_lines, text_cols, total_lines, total_cols,
10185 where the system imposes an 'int' limit.
10186
10187 * fringe.c (Fdefine_fringe_bitmap):
10188 Don't update size until alloc works.
10189
10190 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
10191 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
10192
10193 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
10194 Check for size-calculation overflow.
10195 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
10196 do, as we prefer signed integers.
10197 (id_to_widget.max_size, id_to_widget.used)
10198 (xg_store_widget_in_map, xg_remove_widget_from_map)
10199 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
10200 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
10201 Use and return ptrdiff_t, not int.
10202 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
10203 * gtkutil.h: Change prototypes to match the above.
10204
10205 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
10206 are duplicate now that they've been promoted to lisp.h.
10207 (x_allocate_bitmap_record, x_alloc_image_color)
10208 (make_image_cache, cache_image, xpm_load):
10209 Don't update size until alloc is done.
10210 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
10211 (x_detect_edges):
3256efce 10212 Check for size calculation overflow.
726e0ab1
PE
10213 (ct_colors_allocated_max): New constant.
10214 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
10215 overflow.
3256efce 10216
726e0ab1
PE
10217 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
10218 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
10219 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
10220 Use ptrdiff_t, not int, to count maps.
10221 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
10222 calculations. Don't update size until allocation succeeds.
10223 Redo calculations to avoid overflow.
726e0ab1
PE
10224 * keyboard.h: Change prototypes to match the above.
10225
10226 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
10227 to count maps.
10228 (current_minor_maps): Check for size calculation overflow.
10229 * keymap.h: Change prototypes to match the above.
10230
10231 * lread.c (read1, init_obarray): Don't update size until alloc done.
10232
10233 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
10234 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
10235
726e0ab1
PE
10236 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
10237 Now ptrdiff_t, not int.
10238 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
10239 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
10240
10241 * process.c (Fnetwork_interface_list): Check for overflow
10242 in size calculation.
10243
10244 * region-cache.c (move_cache_gap): Check for size calculation overflow.
10245
10246 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
10247 overflow. Don't bother calling xmalloc when xrealloc will do.
10248
10249 * search.c (Freplace_match): Check for size calculation overflow.
10250 (Fset_match_data): Don't assume list lengths fit in 'int'.
10251
10252 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
10253 for command line length. Do not attempt to address one before the
10254 beginning of an array, as that's not portable.
10255
10256 * term.c (max_frame_lines): Remove; unused.
10257 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
10258 not int.
10259 (encode_terminal_code, calculate_costs): Check for size
10260 calculation overflow.
10261 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
10262 table lengths and related sizes. Don't update size until alloc
10263 done. Redo calculations to avoid overflow.
10264 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
10265
10266 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
10267 subtracting pointers.
10268 (gobble_line): Check for overflow more carefully. Don't update size
10269 until alloc done.
10270
10271 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
10272 Don't update size until alloc done.
10273 Redo size calculations to avoid overflow.
10274 Check for size calculation overflow.
0065d054 10275 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
10276
10277 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
10278 Use ptrdiff_t, not int, for sizes.
10279 (store_mode_line_noprop_char): Don't update size until alloc done.
10280
0065d054
PE
10281 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
10282 Use ptrdiff_t, not int, for sizes.
10283 (Finternal_make_lisp_face, cache_face):
10284 Check for size calculation overflow.
10285 (cache_face): Treat size calculation overflows as if they were
10286 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
10287
10288 * xfns.c (x_encode_text, x_set_name_internal)
10289 (Fx_change_window_property): Use ptrdiff_t, not int, to count
10290 sizes, since they can exceed INT_MAX in size. Check for size
10291 calculation overflow.
10292
0065d054
PE
10293 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
10294 (xg_select): Check for size calculation overflow.
726e0ab1
PE
10295 Don't update size until alloc done.
10296
0065d054 10297 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 10298 as sprintf is limited to int lengths.
1d526e2f 10299
252c5ee1
PE
10300 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
10301 (X_LONG_MIN): New macros.
864d7ce7
PE
10302 Use them to make the following changes clearer.
10303 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
10304 This change doesn't affect the value now, but it may help remind
10305 future maintainers not to raise the value too much later.
10306 (SELECTION_QUANTUM): Remove, replacing with ...
10307 (selection_quantum): ... new function, which avoids overflow.
10308 All uses changed.
10309 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
10310 assumption that selection length fits in 'int'.
10311 (x_reply_selection_request, x_handle_selection_request)
10312 (x_get_window_property, receive_incremental_selection)
10313 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
10314 (lisp_data_to_selection_data, clean_local_selection_data):
10315 Use ptrdiff_t, not int, to record length of selection.
10316 (x_reply_selection_request, x_get_window_property)
10317 (receive_incremental_selection, x_property_data_to_lisp):
10318 Redo calculations to avoid overflow.
10319 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 10320 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
10321 something.
10322 (x_get_window_property, receive_incremental_selection)
10323 (lisp_data_to_selection_data, x_property_data_to_lisp):
10324 Check for size-calculation overflow.
10325 (x_get_window_property, receive_incremental_selection)
10326 (lisp_data_to_selection_data, Fx_register_dnd_atom):
10327 Don't store size until memory allocation succeeds.
10328 (x_get_window_property): Plug memory leak on memory exhaustion.
10329 Don't double-block input; malloc is safe here. Don't assume 2**34
10330 - 4 fits in unsigned long. Add an xassert to check
10331 XGetWindowProperty overflow. Be more careful about overflow
10332 calculations, and distinguish size from memory overflow better.
10333 (receive_incremental_selection): When tracing, don't assume
10334 unsigned int is less than INT_MAX.
10335 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
10336 harmful) conversions of unsigned short to int.
10337 (lisp_data_to_selection_data): Don't assume that integers
10338 in the range -65535 through -1 fit in an X unsigned short.
10339 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
10340 result parameters unless successful. Rely on cons_to_unsigned
10341 to report problems with elements; the old code wasn't right anyway.
10342 (x_check_property_data): Check for int overflow; we cannot use
10343 a wider type due to X limits.
10344 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
10345
726e0ab1 10346 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 10347
0065d054
PE
10348 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
10349 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
10350 (x_color_cells): Don't store size until memory allocation succeeds.
10351 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 10352 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
10353 (x_term_init): Don't assume length fits in int (sprintf is limited
10354 to int size).
bc18e09d 10355
ebfa62c0
PE
10356 Use ptrdiff_t for composition IDs.
10357 * character.c (lisp_string_width):
10358 * composite.c (composition_table_size, n_compositions)
10359 (get_composition_id, composition_gstring_from_id):
10360 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
10361 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
10362 * window.c (Frecenter):
10363 Use ptrdiff_t, not int, for composition IDs.
10364 * composite.c (get_composition_id): Check for integer overflow.
10365 * composite.h: Adjust prototypes to match the above changes.
10366
d3411f89
PE
10367 Use ptrdiff_t for hash table indexes.
10368 * category.c (hash_get_category_set):
10369 * ccl.c (ccl_driver):
10370 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
10371 * coding.c (coding_system_charset_list, detect_coding_system):
10372 * coding.h (struct coding_system.id):
10373 * composite.c (get_composition_id, gstring_lookup_cache):
10374 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
10375 * image.c (xpm_get_color_table_h):
10376 * lisp.h (hash_lookup, hash_put):
10377 * minibuf.c (Ftest_completion):
10378 Use ptrdiff_t for hash table indexes, not int (which is too
10379 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
10380 32-bit --with-wide-int hosts).
10381
e097a6fa
PE
10382 * charset.c (Fdefine_charset_internal): Check for integer overflow.
10383 Add a FIXME comment about memory leaks.
10384 (syms_of_charset): Don't assume xmalloc returns.
10385
5637687f
PE
10386 Don't assume that stated character widths fit in int.
10387 * character.c (Fchar_width, c_string_width, lisp_string_width):
10388 * character.h (CHAR_WIDTH):
10389 * indent.c (MULTIBYTE_BYTES_WIDTH):
10390 Use sanitize_char_width to avoid undefined and/or bad behavior
10391 with outlandish widths.
a66cfb1c 10392 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
10393 now that we have two such functions. All uses changed.
10394 (sanitize_char_width): New inline function.
10395
a2271ba2
PE
10396 Don't assume that tab-width fits in int.
10397 * character.h (sanitize_width): New inline function.
10398 (SANE_TAB_WIDTH): New macro.
10399 (ASCII_CHAR_WIDTH): Use it.
10400 * indent.c (sane_tab_width): Remove. All uses replaced by
10401 SANE_TAB_WIDTH (current_buffer).
10402 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
10403
18c52557
PE
10404 * fileio.c: Integer overflow issues with file modes.
10405 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
10406
caeeedc1
PE
10407 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
10408 Remove unreachable code.
10409 (read_hex, load_charset_map_from_file): Check for integer overflow.
10410
6df6ae42 10411 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
10412 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
10413 (x_send_scroll_bar_event): Likewise. Check that the size does not
10414 exceed limits imposed by XClientMessageEvent, as well as the usual
10415 ptrdiff_t and size_t limits.
10416
b13995db
PE
10417 * keyboard.c: Overflow, signedness and related fixes.
10418 (make_lispy_movement): Use same integer type in forward decl
10419 that is used in the definition.
10420 (read_key_sequence, keyremap_step):
10421 Change bufsize argument back to int, undoing my 2011-03-30 change.
10422 We prefer signed types, and int is wide enough here.
10423 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
10424 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
10425 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
10426 length, not size_t. Use ptrdiff_t for index, not int.
10427 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
10428 possibility of integer overflow.
10429
13464394
PE
10430 Overflow, signedness and related fixes for images.
10431
10432 * dispextern.h (struct it.stack[0].u.image.image_id)
10433 (struct_it.image_id, struct image.id, struct image_cache.size)
10434 (struct image_cache.used, struct image_cache.ref_count):
10435 * gtkutil.c (update_frame_tool_bar):
10436 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
10437 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
10438 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
10439 * nsmenu.m (update_frame_tool_bar):
10440 * xdisp.c (calc_pixel_width_or_height):
10441 * xfns.c (image_cache_refcount):
10442 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
10443 on typical 64-bit hosts.
10444
10445 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
10446 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
10447 Omit unnecessary casts to int.
10448 (parse_image_spec): Check that integers fall into 'int' range
10449 when the callers expect that.
10450 (image_ascent): Redo ascent calculation to avoid int overflow.
10451 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
10452 (lookup_image): Remove unnecessary tests.
10453 (xbm_image_p): Locals are now of int, not EMACS_INT,
10454 since parse_image_check makes sure they fit into int.
10455 (png_load, gif_load, svg_load_image):
10456 Prefer int to unsigned where either will do.
10457 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
10458 old tiff_error_handler and tiff_warning_handler.
10459 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
10460 stack buffer overflows. It uses only the features of vsnprintf
10461 that are common to both POSIX and native Microsoft.
10462 (tiff_error_handler, tiff_warning_handler): Use it.
10463 (tiff_load, gif_load, imagemagick_load_image):
10464 Don't assume :index value fits in 'int'.
10465 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
10466 (imagemagick_load_image): Check that crop parameters fit into
10467 the integer types that MagickCropImage accepts. Don't assume
10468 Vimagemagick_render_type has a nonnegative value. Don't assume
10469 size_t fits in 'long'.
10470 (gs_load): Use printmax_t to print the widest integers possible.
10471 Check for integer overflow when computing image height and width.
10472
c11821d4
EZ
104732011-08-26 Eli Zaretskii <eliz@gnu.org>
10474
10475 * xdisp.c (redisplay_window): Don't force window start if point
10476 will be invisible in the resulting window. (Bug#9324)
10477
0c95fcf7
EZ
104782011-08-25 Eli Zaretskii <eliz@gnu.org>
10479
10480 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
10481 the display spec is of the form `(space ...)'.
10482 (handle_display_spec): Return the value returned by
10483 handle_single_display_spec, not just 1 or zero.
10484 (handle_single_display_spec): If the display spec is of the form
10485 `(space ...)', and specifies display in the text area, return 2
10486 rather than 1.
fee65a97 10487 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
10488 accurately, and prefer exact match for point under bidi.
10489 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
10490
10491 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
10492 into disp_prop; all users changed.
10493
10494 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
10495 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
10496 for the text covered by the display property.
10497
e4ed06f1
CY
104982011-08-25 Chong Yidong <cyd@stupidchicken.com>
10499
10500 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
10501 Change return value to nil.
10502 (Frecord_buffer): Delete unused function.
10503
f67cdd7f
EZ
105042011-08-24 Eli Zaretskii <eliz@gnu.org>
10505
5980d4c6
EZ
10506 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
10507 buffers, return left-to-right.
8610fe8b
EZ
10508 (set_cursor_from_row): Consider candidate row a win if its glyph
10509 represents a newline and point is on that newline. Fixes cursor
10510 positioning on the newline at EOL of R2L text within L2R
10511 paragraph, and vice versa.
10512 (try_cursor_movement): Check continued rows, in addition to
10513 continuation rows. Fixes unwarranted scroll when point enters a
10514 continued line of R2L text within an L2R paragraph, or vice versa.
10515 (cursor_row_p): Consider the case of point being equal to
10516 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
10517 from the end of a short line to the beginning of a continued line
10518 of R2L text within L2R paragraph.
10519 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
10520 composed characters.
5980d4c6 10521
f67cdd7f
EZ
10522 * bidi.c (bidi_check_type): Use xassert.
10523 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
10524 members.
10525
bca633fb
EZ
105262011-08-23 Eli Zaretskii <eliz@gnu.org>
10527
10528 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
10529 a character.
10530
4a5885a7
CY
105312011-08-23 Chong Yidong <cyd@stupidchicken.com>
10532
10533 * nsfont.m (ns_otf_to_script): Fix typo.
10534
0902a04e
KH
105352011-08-22 Kenichi Handa <handa@m17n.org>
10536
10537 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
10538 extra slot even if the purpose is char-code-property-table.
10539
1a2e6670
EZ
105402011-08-23 Eli Zaretskii <eliz@gnu.org>
10541
8ddde651
EZ
10542 * xdisp.c (redisplay_window): When computing centering_position,
10543 account for the height of the header line. (Bug#8874)
10544
425cc014
EZ
10545 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
10546 instead of CHAR_TO_BYTE. Fixes a crash when a completion
10547 candidate is selected by the mouse, and that candidate has a
10548 composed character under the mouse.
10549
1a2e6670
EZ
10550 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
10551 coordinates reported by pos-visible-in-window-p for a composed
10552 character in column zero.
10553
8b76d6f8
SM
105542011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
10555
10556 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
10557
dac347dd
EZ
105582011-08-22 Eli Zaretskii <eliz@gnu.org>
10559
10560 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
10561 consider it a hit if to_charpos is anywhere in the range of the
10562 composed buffer positions.
10563
e013fb34
CY
105642011-08-22 Chong Yidong <cyd@stupidchicken.com>
10565
10566 * image.c (gif_load): Don't assume that each subimage has the same
10567 dimensions as the base image. Handle disposal method that is
10568 "undefined" by the gif spec (Bug#9335).
10569
bd1ba3e8
CY
105702011-08-20 Chong Yidong <cyd@stupidchicken.com>
10571
10572 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 10573 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 10574
54a1215b
EZ
105752011-08-19 Eli Zaretskii <eliz@gnu.org>
10576
823564e5
EZ
10577 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
10578 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
10579 from an Org mode buffer to a Speedbar frame.
10580
54a1215b
EZ
10581 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
10582 a composition, take its buffer position from IT->cmp_it.charpos.
10583 Fixes cursor positioning at the beginning of a line that begins
10584 with a composed character.
10585
9778ebcc
EZ
105862011-08-18 Eli Zaretskii <eliz@gnu.org>
10587
0be6ee06
EZ
10588 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
10589 character bidirectional type, use STRONG_L instead. Fixes crashes
10590 in a buffer produced by `describe-categories'.
10591
9778ebcc
EZ
10592 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
10593 members before the level stack, so they would be saved and
10594 restored when copying iterator state. Fixes incorrect reordering
10595 around TABs covered by display properties.
10596
156bffbe
AS
105972011-08-18 Andreas Schwab <schwab@linux-m68k.org>
10598
6b02f655 10599 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 10600
72ad093b
CY
106012011-08-17 Chong Yidong <cyd@stupidchicken.com>
10602
10603 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
10604 (internal_condition_case_2, internal_condition_case_n):
10605 Remove unnecessary aborts (Bug#9081).
72ad093b 10606
35774242
EZ
106072011-08-17 Eli Zaretskii <eliz@gnu.org>
10608
10609 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
10610 has no `load' handler, try opening the file locally. (Bug#9311)
10611
db76dd85
KB
106122011-08-16 Ken Brown <kbrown@cornell.edu>
10613
10614 * gmalloc.c: Expand comment.
10615
b215eee5
EZ
106162011-08-16 Eli Zaretskii <eliz@gnu.org>
10617
10618 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
10619 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
10620
a4579d33
KB
106212011-08-16 Ken Brown <kbrown@cornell.edu>
10622
10623 Fix memory allocation problems in Cygwin build (Bug#9273).
10624
10625 * unexcw.c ( __malloc_initialized): Declare external variable.
10626 (fixup_executable): Force the dumped emacs to reinitialize malloc.
10627
8b76d6f8
SM
10628 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
10629 New variables.
a4579d33
KB
10630 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
10631 dumped emacs.
10632 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
10633 in the static heap.
10634 [CYGWIN] (special_realloc): New function.
10635 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
10636 requests to realloc storage in the static heap.
10637
3ebec551
PE
106382011-08-15 Paul Eggert <eggert@cs.ucla.edu>
10639
10640 * bidi.c (bidi_initialize): Remove unused local.
10641
9fd8be00
EZ
106422011-08-15 Eli Zaretskii <eliz@gnu.org>
10643
6b02f655
SM
10644 * bidimirror.h:
10645 * biditype.h: Remove file.
10646 * makefile.w32-in ($(BLD)/bidi.$(O)):
10647 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
10648
10649 * dispextern.h: Fix a typo in the comment to bidi_type_t.
10650
10651 * chartab.c: Improve commentary for the uniprop_table API.
10652
32413314
EZ
10653 * bidi.c (bidi_paragraph_init): Support zero value of
10654 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
10655 (bidi_initialize): Use uniprop_table instead of including
10656 biditype.h and bidimirror.h.
32413314 10657
9fd8be00
EZ
10658 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
10659 coordinates of the iterator when restoring from ppos_it.
10660 (Bug#9296)
10661
5cf2b69b
KH
106622011-08-14 Kenichi Handa <handa@m17n.org>
10663
10664 * process.c (create_process): Call setup_process_coding_systems
72ad093b 10665 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 10666
daf17d00
EZ
106672011-08-14 Eli Zaretskii <eliz@gnu.org>
10668
10669 * xdisp.c (move_it_in_display_line_to): Don't invoke
10670 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
10671 ppos_it. Fixes vertical cursor motion when line beginning is
10672 covered by an image. (Bug#9296)
10673
08e3161a
JD
106742011-08-14 Jan Djärv <jan.h.d@swipnet.se>
10675
10676 * nsterm.h (ns_run_ascript): Declare.
10677 (NSAPP_DATA2_RUNASSCRIPT): Define.
10678
10679 * nsfns.m (as_script, as_result, as_status): New static variables.
10680 (ns_run_ascript): New function.
5e617bc2 10681 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
10682 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
10683 the event loop. Get status from as_status (Bug#7276).
10684
10685 * nsterm.m (sendEvent): If event is NSApplicationDefined and
10686 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
10687 the event loop (Bug#7276).
10688
a3720aa2
AS
106892011-08-14 Andreas Schwab <schwab@linux-m68k.org>
10690
10691 * gnutls.c (QCgnutls_bootprop_priority)
10692 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
10693 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
10694 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
10695 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
10696 (QCgnutls_bootprop_verify_hostname_error)
10697 (QCgnutls_bootprop_callbacks_verify): Rename from
10698 Qgnutls_bootprop_..., all uses changed.
10699
10700 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
10701 uses changed.
10702
0a0d27fb
PE
107032011-08-14 Paul Eggert <eggert@cs.ucla.edu>
10704
19d5c50c
PE
10705 * xfaces.c (Qframe_set_background_mode): Now static.
10706 * dispextern.h (Qframe_set_background_mode): Remove decl.
10707
0a0d27fb
PE
10708 * process.c (Fnetwork_interface_info): Declare local only if needed.
10709
377538cb
JD
107102011-08-13 Jan Djärv <jan.h.d@swipnet.se>
10711
10712 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
10713 (Fnetwork_interface_list): Allocate in increments of bytes instead
10714 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
10715 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
10716 sockaddr.
10717 (struct ifflag_def): notrailers is smart on OSX.
10718 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
10719 Get hardware address with getifaddrs if available.
10720
08fff70c
EZ
107212011-08-12 Eli Zaretskii <eliz@gnu.org>
10722
10723 * xdisp.c (iterate_out_of_display_property): xassert that
10724 IT->position is set to within IT->object's boundaries. Break from
10725 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
10726 when IT->position is set up wrongly due to some bug.
10727 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
10728 (push_display_prop): Allow GET_FROM_STRING as IT->method on
10729 entry. Force push_it to save on the stack the current
10730 buffer/string position, to be restored by pop_it. Fix flags in
10731 the iterator structure wrt the object coming from a display
10732 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
10733 properties. (Bug#9284)
10734
7be1c708 107352011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 10736
7be1c708
CY
10737 * fontset.c (fontset_get_font_group): Add proper type checks.
10738 (Bug#9172)
aac0c6e3 10739
7be1c708 107402011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 10741
7be1c708
CY
10742 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
10743 and LC_VERSION_MIN_MACOSX.
10744 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
10745 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 10746
97bb72a6
EZ
107472011-08-08 Eli Zaretskii <eliz@gnu.org>
10748
10749 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
10750 no-display-properties-and-no-overlays under bidi display.
10751 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 10752 properties and overlays.
97bb72a6 10753
d5617611
CY
107542011-08-08 Chong Yidong <cyd@stupidchicken.com>
10755
37e11a63
CY
10756 * editfns.c (Fset_time_zone_rule): Document relationship with the
10757 setenv function.
10758
d5617611
CY
10759 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
10760 the font entity extracted from the cache (Bug#8109).
10761
58872834
CY
107622011-08-07 Chong Yidong <cyd@stupidchicken.com>
10763
10764 * composite.c (autocmp_chars): Don't reset point. That is done by
10765 restore_point_unwind (Bug#5984).
10766
75bfc667
JL
107672011-08-07 Juri Linkov <juri@jurta.org>
10768
10769 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
10770 to show the arg `TIME' instead of `TIMEVAL'.
10771
d1410150
EZ
107722011-08-06 Eli Zaretskii <eliz@gnu.org>
10773
10774 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
10775 display property strides EOL and includes a newline, as in
10776 longlines-mode. (Bug#9254)
75b771e4
EZ
10777 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
10778 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
10779
10780 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
10781 is non-zero, even if the data buffer is NULL. Fixes a crash in
10782 vertical-motion with longlines-mode. (Bug#9254)
10783
35928349
EZ
107842011-08-05 Eli Zaretskii <eliz@gnu.org>
10785
ec7cc85b
EZ
10786 * bidi.c <bidi_cache_total_alloc>: Now static.
10787 (bidi_initialize): Initialize bidi_cache_total_alloc.
10788
8b76d6f8 10789 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
10790 cache. (Bug#9221)
10791
10792 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
10793 amount allocated this far in `bidi_cache_total_alloc'.
10794 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
10795 non-zero, only free the data buffer without restoring the cache
10796 contents. All callers changed.
10797
10798 * dispextern.h (bidi_unshelve_cache): Update prototype.
10799
10800 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
10801 (move_it_in_display_line, move_it_to)
10802 (move_it_vertically_backward, move_it_by_lines): Replace the call
10803 to xfree to an equivalent call to bidi_unshelve_cache.
10804 (move_it_in_display_line_to): Fix logic of returning
412b6358 10805 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 10806
e2e2423b
EZ
108072011-08-05 Eli Zaretskii <eliz@gnu.org>
10808
10809 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
10810 came from a string character with a `cursor' property. (Bug#9229)
10811
ae9e757a
JD
108122011-08-04 Jan Djärv <jan.h.d@swipnet.se>
10813
10814 * Makefile.in (LIB_PTHREAD): New variable.
10815 (LIBES): Add LIB_PTHREAD (Bug#9216).
10816
10817 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
10818 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
10819
213bd7f2
AS
108202011-08-04 Andreas Schwab <schwab@linux-m68k.org>
10821
6b02f655 10822 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 10823
99aaf75f
JD
108242011-08-04 Jan Djärv <jan.h.d@swipnet.se>
10825
10826 * xterm.c (x_find_topmost_parent): New function.
10827 (x_set_frame_alpha): Find topmost parent window with
10828 x_find_topmost_parent and set the property there also (bug#9181).
10829 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
10830
c74e9d86
PE
108312011-08-04 Paul Eggert <eggert@cs.ucla.edu>
10832
10833 * callproc.c (Fcall_process): Avoid vfork clobbering
10834 the local vars buffer, coding_systems, current_dir.
10835
640c8776
SM
108362011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
10837
10838 * keymap.c (Fmake_composed_keymap): Move to subr.el.
10839
f26d0e4c
PE
108402011-08-03 Paul Eggert <eggert@cs.ucla.edu>
10841
8a10d76c
PE
10842 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
10843 so that it is not optimized away.
10844
f26d0e4c
PE
10845 * xdisp.c (compute_display_string_pos): Remove unused local.
10846
55439c61
EZ
108472011-08-02 Eli Zaretskii <eliz@gnu.org>
10848
10849 Fix slow cursor motion and scrolling in large buffers with
10850 selective display, like Org Mode buffers. (Bug#9218)
10851
10852 * dispextern.h (struct bidi_it): New member disp_prop_p.
10853
10854 * xdisp.c: Remove one-slot cache of display string positions.
10855 (compute_display_string_pos): Accept an additional argument
5e617bc2 10856 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
10857 for a display string or property. If found, set DISP_PROP_P
10858 non-zero.
10859
10860 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
10861 DISP_PROP_P, and pass it to compute_display_string_pos.
10862 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
10863 non-zero. All callers of bidi_fetch_char changed.
10864
fb33fa43
SM
108652011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
10866
10867 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
10868
b099e063
DM
108692010-12-03 Don March <don@ohspite.net>
10870
10871 * keymap.c (Fdefine_key): Fix non-prefix key error message when
10872 last character M-[char] is translated to ESC [char] (bug#7541).
10873
5cc7f7af
KH
108742011-08-02 Kenichi Handa <handa@m17n.org>
10875
d0fffa3f 10876 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
10877
10878 * chartab.c (uniprop_table): Make it non-static.
10879
525d5e6e
EZ
108802011-08-01 Eli Zaretskii <eliz@gnu.org>
10881
10882 * xdisp.c (forward_to_next_line_start): Accept additional argument
10883 BIDI_IT_PREV, and store into it the state of the bidi iterator had
10884 on the newline.
10885 (reseat_at_next_visible_line_start): Use the bidi iterator state
10886 returned by forward_to_next_line_start to restore the state of
10887 it->bidi_it after backing up to previous newline. (Bug#9212)
10888
31011111
AS
108892011-07-30 Andreas Schwab <schwab@linux-m68k.org>
10890
10891 * regex.c (re_comp): Protoize.
10892 (re_exec): Fix return type.
10893 (regexec): Fix type of `ret'. (Bug#9203)
10894
476371c4
PE
108952011-07-28 Paul Eggert <eggert@cs.ucla.edu>
10896
e5d76069
PE
10897 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
10898 This is needed if max-image-size is a floating-point number.
10899
9a79b20c
AS
109002011-07-28 Andreas Schwab <schwab@linux-m68k.org>
10901
10902 * print.c (print_object): Print empty symbol as ##.
10903
10904 * lread.c (read1): Read ## as empty symbol.
10905
d8c2fa78
AA
109062011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
10907
10908 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
10909 setting frame foreground color (Bug#9175).
10910 (x_set_background_color): Likewise.
10911
ffe57a7a
AA
10912 * nsmenu.m (-setText): Size tooltip dimensions precisely to
10913 contents (Bug#9176).
10914 (EmacsTooltip -init): Remove bezels and add shadows to
10915 tooltip windows.
10916
bf3492a5
AA
10917 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
10918 or scroll bar (Bug#8470).
10919
d55e9c53
AA
10920 * nsfont.m (nsfont_open): Remove assignment to voffset and
10921 unnecessary vars hshink, expand, hd, full_height, min_height.
10922 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
10923
10924 * nsterm.h (nsfont_info): Remove voffset field.
10925
d8c2fa78 109262011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
10927
10928 Implement strike-through and overline on NextStep (Bug#8863).
10929
10930 * nsfont.m (nsfont_open): Use underline position provided by font,
10931 instead of hard-coded value of 2.
10932 (nsfont_draw): Call ns_draw_text_decoration instead.
10933
10934 * nsterm.h: Add declaration for ns_draw_text_decoration.
10935
10936 * nsterm.m (ns_draw_text_decoration): New function for drawing
10937 underline, overline, and strike-through.
10938 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
10939 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 10940 accommodate underlining, etc.
4843aac3 10941
4cc60b9b
EZ
109422011-07-28 Eli Zaretskii <eliz@gnu.org>
10943
bc7ece87
EZ
10944 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
10945 default.
4cc60b9b 10946
476371c4
PE
109472011-07-28 Paul Eggert <eggert@cs.ucla.edu>
10948
66606eea
PE
10949 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
10950 Without this fix, if a signal arrives just after memory fills up,
10951 'malloc' might be invoked reentrantly.
10952
476371c4
PE
10953 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
10954 In other words, assume that every image size is allowed, on non-X
10955 hosts. This assumption is probably wrong, but it lets Emacs compile.
10956
f3fcc40d
AS
109572011-07-28 Andreas Schwab <schwab@linux-m68k.org>
10958
10959 * regex.c (re_iswctype): Convert return values to boolean.
10960
350c992f
EZ
109612011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
10962
10963 * xdisp.c (compute_display_string_pos): Don't use cached display
10964 string position if the buffer had its restriction changed.
10965 (Bug#9184)
10966
5266b4bb
PE
109672011-07-28 Paul Eggert <eggert@cs.ucla.edu>
10968
10969 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
10970
2573a837 109712011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 10972
41f55ccd 10973 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 10974
39e378da
PE
10975 * bidi.c: Integer size and overflow fixes.
10976 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
10977 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
10978 (bidi_cache_find_level_change, bidi_cache_ensure_space)
10979 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
10980 (bidi_find_other_level_edge):
10981 Use ptrdiff_t instead of EMACS_INT where either will do.
10982 This works better on 32-bit hosts configured --with-wide-int.
10983 (bidi_cache_ensure_space): Check for size-calculation overflow.
10984 Use % rather than repeated addition, for better worst-case speed.
10985 Don't set bidi_cache_size until after xrealloc returns, because it
10986 might not return.
10987 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
10988 (bidi_cache_ensure_space): Also check that the bidi cache size
10989 does not exceed that of the largest Lisp string or buffer. See Eli
10990 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 10991
5e927815
PE
10992 * alloc.c (__malloc_size_t): Remove.
10993 All uses replaced by size_t. See Andreas Schwab's note
10994 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
10995
ca4aa935
PE
10996 * image.c: Improve checking for integer overflow.
10997 (check_image_size): Assume that f is nonnull, since
10998 it is always nonnull in practice. This is one less thing to
10999 worry about when checking for integer overflow later.
11000 (x_check_image_size): New function, which checks for integer
11001 overflow issues inside X.
11002 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
11003 This removes the need for a memory_full check.
11004 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
11005 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
11006 (xbm_read_bitmap_data): Change locals back to 'int', since
11007 their values must fit in 'int'.
11008 (xpm_load_image, png_load, tiff_load):
11009 Invoke x_create_x_image_and_pixmap earlier,
11010 to avoid much needless work if the image is too large.
11011 (tiff_load): Treat overly large images as if
11012 x_create_x_image_and_pixmap failed, not as malloc failures.
11013 (gs_load): Use x_check_image_size.
11014
5f8f9cc2
PE
11015 * gtkutil.c: Omit integer casts.
11016 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
11017 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
11018
5adf60bc
PE
11019 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
11020
c8907a93
PE
11021 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
11022 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
11023 would wrongly return t on a 64-bit host.
11024
e3c25c68
PE
11025 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
11026 The plain *_OVERFLOW macros run afoul of GCC bug 49705
11027 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
11028 and therefore cause GCC to emit a bogus diagnostic in some cases.
11029
3f791afe
PE
11030 * image.c: Integer signedness and overflow and related fixes.
11031 This is not an exhaustive set of fixes, but it's time to
11032 record what I've got.
11033 (lookup_pixel_color, check_image_size): Remove redundant decls.
11034 (check_image_size): Don't assume that arbitrary EMACS_INT values
11035 fit in 'int', or that arbitrary 'double' values fit in 'int'.
11036 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
11037 (tiff_load, imagemagick_load_image):
11038 Check for overflow in size calculations.
11039 (x_create_x_image_and_pixmap): Remove unnecessary test for
11040 xmalloc returning NULL; that can't happen.
11041 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
11042 (xpm_color_bucket): Use better integer hashing function.
11043 (xpm_cache_color): Don't possibly over-allocate memory.
11044 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
11045 (gif_memory_source):
11046 Use ptrdiff_t, not int or size_t, to record sizes.
11047 (png_load): Don't assume values greater than 2**31 fit in 'int'.
11048 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
11049 either works, as we prefer signed integers.
11050 (tiff_read_from_memory, tiff_write_from_memory):
11051 Return tsize_t, not size_t, since that's what the TIFF API wants.
11052 (tiff_read_from_memory): Don't fail simply because the read would
11053 go past EOF; instead, return a short read.
11054 (tiff_load): Omit no-longer-needed casts.
11055 (Fimagemagick_types): Don't assume size fits into 'int'.
11056
3cc5a532
PE
11057 Improve hashing quality when configured --with-wide-int.
11058 * fns.c (hash_string): New function, taken from sxhash_string.
11059 Do not discard information about ASCII character case; this
11060 discarding is no longer needed.
11061 (sxhash-string): Use it. Change sig to match it. Caller changed.
11062 * lisp.h: Declare it.
11063 * lread.c (hash_string): Remove, since we now use fns.c's version.
11064 The fns.c version returns a wider integer if --with-wide-int is
11065 specified, so this should help the quality of the hashing a bit.
11066
b312a492
PE
11067 * emacs.c: Integer overflow minor fix.
11068 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
11069 Define only if GNU_LINUX.
11070 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
11071
dfd153ae
PE
11072 * dispnew.c: Integer signedness and overflow fixes.
11073 Remove unnecessary forward decls, that were a maintenance hassle.
11074 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
11075 All uses changed.
11076 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
11077 (scrolling_window): Use ptrdiff_t, not int, for byte count.
11078 (prepare_desired_row, line_draw_cost):
11079 Use int, not unsigned, where either works.
11080 (save_current_matrix, restore_current_matrix):
11081 Use ptrdiff_t, not size_t, where either works.
11082 (init_display): Check for overflow more accurately, and without
11083 relying on undefined behavior.
11084
a81d11a3
PE
11085 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
11086 Remove, replacing with the new symbols in lisp.h. All uses changed.
11087 * fileio.c (make_temp_name):
11088 * filelock.c (lock_file_1, lock_file):
11089 * xdisp.c (message_dolog):
11090 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
11091 Use pMd etc. instead.
11092 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
11093 replacing the pWIDE etc. symbols removed from editfns.c.
11094
3300e6fd
PE
11095 * keyboard.h (num_input_events): Now uintmax_t.
11096 This is (very slightly) less likely to mess up due to wraparound.
11097 All uses changed.
11098
fd05c7e9
PE
11099 * buffer.c: Integer signedness fixes.
11100 (alloc_buffer_text, enlarge_buffer_text):
11101 Use ptrdiff_t rather than size_t when either will do, as we prefer
11102 signed integers.
11103
903fe15d
PE
11104 * alloc.c: Integer signedness and overflow fixes.
11105 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
11106 (__malloc_size_t): Default to size_t, not to int.
11107 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
11108 (Fgarbage_collect, mark_object_loop_halt, mark_object):
11109 Prefer ptrdiff_t to size_t when either would do, as we prefer
11110 signed integers.
11111 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
11112 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
11113 Now const. Initialize with values that are in range even if char
11114 is signed.
11115 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
11116 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
11117 These functions do the right thing with sizes > 2**32.
11118 (check_depth): Now ptrdiff_t, not int.
11119 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
11120 Adjust to new way of storing sizes. Check for size overflow bugs
11121 in rest of code.
11122 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
11123 slightly wrong anyway, as it missed one instance of
11124 XMALLOC_OVERRUN_CHECK_OVERHEAD.
11125 (refill_memory_reserve): Omit needless cast to size_t.
11126 (mark_object_loop_halt): Mark as externally visible.
11127
ac82cc6a
PE
11128 * xselect.c: Integer signedness and overflow fixes.
11129 (Fx_register_dnd_atom, x_handle_dnd_message):
11130 Use ptrdiff_t, not size_t, since we prefer signed.
11131 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
11132 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
11133 x_dnd_atoms_size and x_dnd_atoms_length.
11134
c2d1e36d
PE
11135 * doprnt.c: Prefer signed to unsigned when either works.
11136 * eval.c (verror):
11137 * doprnt.c (doprnt):
11138 * lisp.h (doprnt):
11139 * xdisp.c (vmessage):
11140 Use ptrdiff_t, not size_t, when using or implementing doprnt,
11141 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
11142 prefer signed arithmetic to avoid comparison confusion.
11143 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
11144 but is a bit tricky.
11145
0e926e56
PE
11146 Assume freestanding C89 headers, string.h, stdlib.h.
11147 * data.c, doprnt.c, floatfns.c, print.c:
11148 Include float.h unconditionally.
11149 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
11150 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
11151 * regex.c: Likewise for stddef.h, string.h.
11152 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
11153 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
11154 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
11155 (STDC_HEADERS): Remove obsolete defines.
11156 * sysdep.c: Include limits.h unconditionally.
11157
9cfdb3ec
PE
11158 Assume support for memcmp, memcpy, memmove, memset.
11159 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
11160 * regex.c (memcmp, memcpy):
11161 Remove; we assume C89 now.
11162
11163 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
11164 (__malloc_safe_bcopy): Remove; no longer needed.
11165
cf950e6b 11166 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
11167 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
11168 well either way, and we prefer signed to unsigned.
11169
dbf38e02
LMI
111702011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
11171
11172 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
11173 closes the connection while we're reading (bug#9182).
11174
d6f0886c 111752011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 11176
d6f0886c
JD
11177 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
11178 are specified (Bug#9168).
24e0f6b1 11179
2eb1f9e6
PE
111802011-07-25 Paul Eggert <eggert@cs.ucla.edu>
11181
11182 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
11183 Found by GCC static checking and --with-wide-int on a 32-bit host.
11184
22381272 111852011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
11186
11187 * xdisp.c (compute_display_string_pos): Fix logic of caching
11188 previous display string position. Initialize cached_prev_pos to
11189 -1. Fixes slow-down at the beginning of a buffer.
11190
f25e39b4
EZ
111912011-07-24 Eli Zaretskii <eliz@gnu.org>
11192
11193 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
11194 for attrs[LFACE_FONTSET_INDEX].
11195
04c4b52e
PE
111962011-07-23 Paul Eggert <eggert@cs.ucla.edu>
11197
11198 * xml.c (parse_region): Remove unused local
11199 that was recently introduced.
11200
c1734fbd
EZ
112012011-07-23 Eli Zaretskii <eliz@gnu.org>
11202
be18c5a5
EZ
11203 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
11204 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
11205
c1734fbd
EZ
11206 * xdisp.c (move_it_in_display_line_to): Record the best matching
11207 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
11208 exit if none of the characters scanned was an exact match.
11209 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
11210 when exact match is impossible due to invisible text, and the
11211 lines are truncated.
11212
a258d627
JD
112132011-07-23 Jan Djärv <jan.h.d@swipnet.se>
11214
11215 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
11216 for OSX >= 10.7.
11217
b6d5a689
EZ
112182011-07-22 Eli Zaretskii <eliz@gnu.org>
11219
0f74f785
EZ
11220 Fix a significant slow-down of cursor motion with C-n, C-p,
11221 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
11222 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 11223 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
11224 (next_element_from_buffer): Call compute_stop_pos_backwards to
11225 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
11226 base_level_stop.
11227 (reseat): Don't look for prev_stop, as that could mean a very long
11228 run.
11229 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
11230 <cached_disp_overlay_modiff>: Cache for last found display string
11231 position.
551918c1 11232 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
11233 about the same buffer in the same area of character positions, and
11234 the buffer wasn't changed since the time the display string
11235 position was cached.
551918c1 11236
b2d0c91a
EZ
112372011-07-22 Eli Zaretskii <eliz@gnu.org>
11238
11239 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
11240 is an integer, which is important for empty lines. (Bug#9149)
11241
043604ee
CY
112422011-07-22 Chong Yidong <cyd@stupidchicken.com>
11243
11244 * frame.c (Fmodify_frame_parameters): In tty case, update the
11245 default face if necessary (Bug#4238).
11246
da4adb04
CY
112472011-07-21 Chong Yidong <cyd@stupidchicken.com>
11248
11249 * editfns.c (Fstring_to_char): No need to explain what a character
11250 is in the docstring (Bug#6576).
11251
9abd0532
LMI
112522011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
11253
11254 * xml.c (parse_region): Make sure we always return a tree.
11255
36881d16
HK
112562011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
11257
11258 * xml.c (parse_region): If a document contains only comments,
11259 return that, too.
11260
1e98674d
LMI
112612011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
11262
11263 * xml.c (make_dom): Return comments, too.
11264
590bd467
PE
112652011-07-19 Paul Eggert <eggert@cs.ucla.edu>
11266
11267 Port to OpenBSD.
11268 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
11269 and the surrounding thread.
11270 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
11271 rather than fgets, and retry after EINTR. Otherwise, 'emacs
11272 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
11273 timer goes off.
11274 * s/openbsd.h (BROKEN_SIGIO): Define.
11275 * unexelf.c (unexec) [__OpenBSD__]:
11276 Don't update the .mdebug section of the Alpha COFF symbol table.
11277
f41628b2
LMI
112782011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
11279
11280 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
11281 (bug#8460).
11282
b59b67c5
PE
112832011-07-18 Paul Eggert <eggert@cs.ucla.edu>
11284
15e3a074
PE
11285 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
11286 This fixes some race conditions on the permissions of any newly
11287 created file.
11288
41bed37d
PE
11289 * alloc.c (valid_pointer_p): Use pipe, not open.
11290 This fixes some permissions issues when debugging.
11291
b59b67c5
PE
11292 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
11293 If fchown fails to set both uid and gid, try to set just gid,
11294 as that is sometimes allowed. Adjust the file's mode to eliminate
11295 setuid or setgid bits that are inappropriate if fchown fails.
11296
925a6be7
SM
112972011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
11298
11299 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
11300 to compare Lisp_Objects.
11301 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
11302 global_gnutls_log_level, don't mistake it for a Lisp_Object.
11303 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
11304
52968808
AS
113052011-07-17 Andreas Schwab <schwab@linux-m68k.org>
11306
0a6a104b
AS
11307 * lread.c (read_integer): Unread even EOF character.
11308 (read1): Likewise. Properly record start position of symbol.
11309
52968808
AS
11310 * lread.c (read1): Read `#:' as empty uninterned symbol if no
11311 symbol character follows.
11312
9e381cdd
PE
113132011-07-17 Paul Eggert <eggert@cs.ucla.edu>
11314
11315 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
11316 This works around a problem with the previous change to Fcopy_file.
11317 Recent glibc declares fchown with __attribute__((warn_unused_result)),
11318 and without this change, GCC might complain about discarding
11319 fchown's return value.
11320
b5641435
JB
113212011-07-16 Juanma Barranquero <lekktu@gmail.com>
11322
11323 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
11324
a8031457
PE
113252011-07-16 Paul Eggert <eggert@cs.ucla.edu>
11326
11327 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
11328
dd889327
LMI
113292011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
11330
750c33f7
LMI
11331 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
11332 it's used from the C level.
11333
dd889327
LMI
11334 * process.c: Use the same condition for POLL_FOR_INPUT in both
11335 keyboard.c and process.c (bug#1858).
11336
87e86684
LM
113372011-07-09 Lawrence Mitchell <wence@gmx.li>
11338
11339 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
11340 (Fgnutls_boot): Use it.
11341
64348f40
AS
113422011-07-15 Andreas Schwab <schwab@linux-m68k.org>
11343
11344 * doc.c (Fsubstitute_command_keys): Revert last change.
11345
1d698799
LMI
113462011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
11347
f863868c
LMI
11348 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
11349 quotes the next character, and doesn't affect other longer
11350 sequences (bug#8935).
11351
1d698799
LMI
11352 * lread.c (syms_of_lread): Clarify that is isn't only
11353 `eval-buffer' and `eval-defun' that's affected by
11354 `lexical-binding' (bug#8460).
11355
aa4b6df6
EZ
113562011-07-15 Eli Zaretskii <eliz@gnu.org>
11357
11358 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 11359 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 11360
5d856da6
PE
113612011-07-14 Paul Eggert <eggert@cs.ucla.edu>
11362
ad6042bb
PE
11363 Fix minor problems found by static checking.
11364 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
11365 (elsz): Now a signed constant, not a size_t var. We prefer signed
11366 types to unsigned, to avoid integer comparison confusion. Without
11367 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
11368 "cannot optimize loop, the loop counter may overflow", a symptom
11369 of the confusion.
f00bbb22 11370 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
11371 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
11372
6468f31c
LMI
113732011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
11374
49080b10
LMI
11375 * search.c (Fre_search_backward): Mention `case-fold-search' in
11376 all the re_search_* functions (bug#8138).
11377
6468f31c
LMI
11378 * keyboard.c (Fopen_dribble_file): Document when the file is
11379 closed (bug#8056).
11380
c965adc5
EZ
113812011-07-14 Eli Zaretskii <eliz@gnu.org>
11382
df9733bf
EZ
11383 * bidi.c (bidi_dump_cached_states): Fix format of displaying
11384 bidi_cache_idx.
11385
0bb23927
EZ
11386 Support bidi reordering of display and overlay strings.
11387 * xdisp.c (compute_display_string_pos)
11388 (compute_display_string_end): Accept additional argument STRING.
11389 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
11390 (reseat_to_string): Initialize bidi_it->string.s and
11391 bidi_it->string.schars.
11392 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
11393 NULL (avoids a crash in bidi_paragraph_init).
11394 Initialize itb.string.lstring.
0bb23927
EZ
11395 (init_iterator): Call bidi_init_it only of a valid
11396 buffer position was specified. Initialize paragraph_embedding to
11397 L2R.
11398 (reseat_to_string): Initialize the bidi iterator.
11399 (display_string): If we need to ignore text properties of
11400 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
11401 original value of -1 will not work with bidi.)
11402 (compute_display_string_pos): First arg is now struct
11403 `text_pos *'; all callers changed. Support display properties on
11404 Lisp strings.
11405 (compute_display_string_end): Support display properties on Lisp
11406 strings.
11407 (init_iterator, reseat_1, reseat_to_string): Initialize the
11408 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
11409 when iterating on a string not from display properties).
640c8776
SM
11410 (compute_display_string_pos, compute_display_string_end):
11411 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
11412 arrow keys.
11413 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
11414 base_level_stop; instead, set base_level_stop to BEGV.
11415 Fixes crashes in vertical-motion.
0bb23927
EZ
11416 (next_element_from_buffer): Improve commentary for when
11417 the iterator is before prev_stop.
11418 (init_iterator): Initialize bidi_p from the default value of
11419 bidi-display-reordering, not from buffer-local value. Use the
11420 buffer-local value only if initializing for buffer iteration.
11421 (handle_invisible_prop): Support invisible properties on strings
11422 that are being bidi-reordered.
11423 (set_iterator_to_next): Support bidi reordering of C strings and
11424 Lisp strings.
11425 (next_element_from_string): Support bidi reordering of Lisp
11426 strings.
11427 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
11428 (display_string): Support display of R2L glyph rows.
11429 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
11430 (init_iterator): Don't initialize it->bidi_p for strings
11431 here.
11432 (reseat_to_string): Initialize it->bidi_p for strings here.
11433 (next_element_from_string, next_element_from_c_string)
11434 (next_element_from_buffer): Add xassert's for correspondence
11435 between IT's object being iterated and it->bidi_it.string
11436 structure.
11437 (face_before_or_after_it_pos): Support bidi iteration.
11438 (next_element_from_c_string): Handle the case of the first string
11439 character that is not the first one in the visual order.
11440 (get_visually_first_element): New function, refactored from common
11441 parts of next_element_from_buffer, next_element_from_string, and
11442 next_element_from_c_string.
11443 (tool_bar_lines_needed, redisplay_tool_bar)
11444 (display_menu_bar): Force left-to-right direction. Add a FIXME
11445 comment for making that be controlled by a user option.
11446 (push_it, pop_it): Save and restore the state of the
11447 bidi iterator. Save and restore the bidi_p flag.
11448 (pop_it): Iterate out of display property for string iteration as
11449 well.
11450 (iterate_out_of_display_property): Support iteration over strings.
11451 (handle_single_display_spec): Set up it->bidi_it for iteration
11452 over a display string, and call bidi_init_it.
11453 (handle_single_display_spec, next_overlay_string)
11454 (get_overlay_strings_1, push_display_prop): Set up the bidi
11455 iterator for displaying display or overlay strings.
11456 (forward_to_next_line_start): Don't use the shortcut if
11457 bidi-iterating.
11458 (back_to_previous_visible_line_start): If handle_display_prop
11459 pushed the iterator stack, restore the internal state of the bidi
11460 iterator by calling bidi_pop_it same number of times.
11461 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
11462 and we are bidi-iterating, don't decrement the iterator position;
11463 instead, set the first_elt flag in the bidi iterator, to produce
11464 the same effect.
11465 (reseat_1): Remove redundant setting of string_from_display_prop_p.
11466 (push_display_prop): xassert that we are iterating a buffer.
11467 (push_it, pop_it): Save and restore paragraph_embedding member.
11468 (handle_single_display_spec, next_overlay_string)
11469 (get_overlay_strings_1, reseat_1, reseat_to_string)
11470 (push_display_prop): Set up the `unibyte' member of bidi_it.string
11471 correctly. Don't assume unibyte strings are not bidi-reordered.
11472 (compute_display_string_pos)
11473 (compute_display_string_end): Fix handling the case of C string.
11474 (push_it, pop_it): Save and restore from_disp_prop_p.
11475 (handle_single_display_spec, push_display_prop): Set the
11476 from_disp_prop_p flag.
11477 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
11478 (pop_it): Call iterate_out_of_display_property only if we are
11479 popping after iteration over a string that came from a display
11480 property. Fix a typo in popping stretch info. Add an assertion
11481 for verifying that the iterator position is in sync with the bidi
11482 iterator.
11483 (handle_single_display_spec, get_overlay_strings_1)
11484 (push_display_prop): Fix initialization of paragraph direction for
11485 string when that of the parent object is not yet determined.
11486 (reseat_1): Call bidi_init_it to resync the bidi
11487 iterator with IT's position. (Bug#7616)
11488 (find_row_edges): If ROW->start.pos gives position
11489 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
11490 (handle_stop, back_to_previous_visible_line_start, reseat_1):
11491 Reset the from_disp_prop_p flag.
11492 (SAVE_IT, RESTORE_IT): New macros.
11493 (pos_visible_p, face_before_or_after_it_pos)
11494 (back_to_previous_visible_line_start)
11495 (move_it_in_display_line_to, move_it_in_display_line)
11496 (move_it_to, move_it_vertically_backward, move_it_by_lines)
11497 (try_scrolling, redisplay_window, display_line): Use them when
11498 saving a temporary copy of the iterator and restoring it back.
11499 (back_to_previous_visible_line_start, reseat_1)
11500 (init_iterator): Empty the bidi cache "stack".
11501 (move_it_in_display_line_to): If iterator ended up at
11502 EOL, but we never saw any buffer positions smaller than
11503 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
11504 motion in bidi-reordered lines.
11505 (move_it_in_display_line_to): Record prev_method and prev_pos
11506 immediately before the call to set_iterator_to_next. Fixes cursor
11507 motion in bidi-reordered lines with stretch glyphs and strings
11508 displayed in margins. (Bug#8133) (Bug#8867)
11509 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
11510 TO_CHARPOS.
640c8776
SM
11511 (pos_visible_p): Support positions in bidi-reordered lines.
11512 Save and restore bidi cache.
0bb23927
EZ
11513
11514 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
11515 (bidi_paragraph_info): Delete unused struct.
11516 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
11517 (bidi_cache_start): New variable.
11518 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
11519 to zero.
11520 (bidi_cache_fetch_state, bidi_cache_search)
11521 (bidi_cache_find_level_change, bidi_cache_iterator_state)
11522 (bidi_cache_find, bidi_peek_at_next_level)
11523 (bidi_level_of_next_char, bidi_find_other_level_edge)
11524 (bidi_move_to_visually_next): Compare cache index with
11525 bidi_cache_start rather than with zero.
11526 (bidi_fetch_char): Accept new argument STRING; all callers
11527 changed. Support iteration over a string. Support strings with
11528 display properties. Support unibyte strings. Fix the type of
11529 `len' according to what STRING_CHAR_AND_LENGTH expects.
11530 (bidi_paragraph_init, bidi_resolve_explicit_1)
11531 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
11532 (bidi_level_of_next_char, bidi_move_to_visually_next):
11533 Support iteration over a string.
0bb23927
EZ
11534 (bidi_set_sor_type, bidi_resolve_explicit_1)
11535 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
11536 can now be zero (for strings); special values 0 and -1 were
11537 changed to -1 and -2, respectively.
11538 (bidi_char_at_pos): New function.
11539 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
11540 Call it instead of FETCH_MULTIBYTE_CHAR.
11541 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
11542 initialized to valid values.
11543 (bidi_init_it): Don't initialize charpos and bytepos with invalid
11544 values.
11545 (bidi_level_of_next_char): Allow the sentinel "position" to pass
11546 the test for valid cached positions. Fix the logic for looking up
11547 the sentinel state in the cache. GCPRO the Lisp string we are
11548 iterating.
11549 (bidi_push_it, bidi_pop_it): New functions.
11550 (bidi_initialize): Initialize the bidi cache start stack pointer.
11551 (bidi_cache_ensure_space): New function, refactored from part of
11552 bidi_cache_iterator_state. Don't assume the required size is just
11553 one BIDI_CACHE_CHUNK away.
11554 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
11555 (bidi_count_bytes, bidi_char_at_pos): New functions.
11556 (bidi_cache_search): Don't assume bidi_cache_last_idx is
11557 always valid if bidi_cache_idx is valid.
11558 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
11559 is valid if it's going to be used.
11560 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
11561 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
11562 (bidi_cache_find_level_change, bidi_cache_ensure_space)
11563 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
11564 (bidi_find_other_level_edge, bidi_cache_start_stack):
11565 All variables related to cache indices are now EMACS_INT.
c965adc5 11566
0bb23927
EZ
11567 * dispextern.h (struct bidi_string_data): New structure.
11568 (struct bidi_it): New member `string'. Make flag members be 1-bit
11569 fields, and put them last in the struct.
640c8776
SM
11570 (compute_display_string_pos, compute_display_string_end):
11571 Update prototypes.
0bb23927
EZ
11572 (bidi_push_it, bidi_pop_it): Add prototypes.
11573 (struct iterator_stack_entry): New members bidi_p,
11574 paragraph_embedding, and from_disp_prop_p.
11575 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
11576 (bidi_shelve_cache, bidi_unshelve_cache):
11577 Declare prototypes.
0bb23927
EZ
11578
11579 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
11580 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
11581 and vector-like objects.
11582
11583 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
11584 cache around display iteration.
11585
11586 * window.c (Fwindow_end, window_scroll_pixel_based)
11587 (displayed_window_lines, Frecenter): Save and restore the bidi
11588 cache around display iteration.
11589
3bbd2265
LMI
115902011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
11591
11592 * editfns.c (Fdelete_region): Clarify the use of the named
11593 parameters (bug#6788).
11594
adc47434
MR
115952011-07-14 Martin Rudalics <rudalics@gmx.at>
11596
11597 * indent.c (Fvertical_motion): Set and restore w->pointm when
11598 saving and restoring the window's buffer (Bug#9006).
11599
837c31f8
LMI
116002011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
11601
11602 * editfns.c (Fstring_to_char): Clarify just what is returned
11603 (bug#6576). Text by Eli Zaretskii.
11604
ac389d0c
JB
116052011-07-13 Juanma Barranquero <lekktu@gmail.com>
11606
11607 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
11608
0be0ce47
EZ
116092011-07-13 Eli Zaretskii <eliz@gnu.org>
11610
11611 * buffer.c (mmap_find): Fix a typo.
11612
cd18e7e3
JB
116132011-07-13 Johan Bockgård <bojohan@gnu.org>
11614
11615 Fix execution of x selection hooks.
11616 * xselect.c (Qx_lost_selection_functions)
11617 (Qx_sent_selection_functions): New vars.
11618 (syms_of_xselect): DEFSYM them.
11619 (x_handle_selection_request): Pass Qx_sent_selection_functions
11620 rather than Vx_sent_selection_functions to Frun_hook_with_args.
11621 (x_handle_selection_clear,x_clear_frame_selections):
11622 Pass Qx_lost_selection_functions rather than
11623 Vx_lost_selection_functions to Frun_hook_with_args.
11624
47ea7f44
PE
116252011-07-13 Paul Eggert <eggert@cs.ucla.edu>
11626
ac389d0c 11627 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
11628 The old code sometimes used this field without initializing it.
11629
47ea7f44
PE
11630 * alloc.c (gc_sweep): Don't read past end of array.
11631 In theory, the old code could also have corrupted Emacs internals,
11632 though it'd be very unlikely.
11633
bc985c87
AS
116342011-07-12 Andreas Schwab <schwab@linux-m68k.org>
11635
11636 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 11637 argument. (Bug#4026)
bc985c87 11638
0cf34688
LMI
116392011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
11640
b3dadd76
LMI
11641 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
11642 key" (bug#4257).
11643
0cf34688
LMI
11644 * window.c (Fset_window_start): Doc fix (bug#4199).
11645 (Fset_window_hscroll): Ditto.
11646
270768cd
PE
116472011-07-12 Paul Eggert <eggert@cs.ucla.edu>
11648
077e3dda 11649 Fix minor new problems caught by GCC 4.6.1.
270768cd 11650 * term.c (init_tty): Remove unused local.
490011a6 11651 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 11652 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 11653 not used otherwise.
270768cd 11654
b1f58454
CY
116552011-07-12 Chong Yidong <cyd@stupidchicken.com>
11656
11657 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
11658
22b9578d
LMI
116592011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
11660
6e70ab07
LMI
11661 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
11662 are the mini-buffer and the echo area (bug#3320).
11663
22b9578d
LMI
11664 * term.c (init_tty): Remove support for supdup, c10 and perq
11665 terminals, which are no longer supported (bug#1482).
11666
8974cc9f
JB
116672011-07-10 Johan Bockgård <bojohan@gnu.org>
11668
11669 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
11670
a560d974
JD
116712011-07-10 Jan Djärv <jan.h.d@swipnet.se>
11672
11673 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
11674 for non-popups (Bug#3642).
11675
1dae0f0a
AS
116762011-07-10 Andreas Schwab <schwab@linux-m68k.org>
11677
268c2c36 11678 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 11679 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
11680 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
11681 * cm.c (losecursor): Likewise.
1dae0f0a
AS
11682 * data.c (fmod): Likewise.
11683 * dispnew.c (swap_glyphs_in_rows): Likewise.
11684 * emacs.c (memory_warning_signal): Likewise.
11685 * floatfns.c (float_error): Likewise.
11686 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
11687 (otf_open, font_otf_capability, generate_otf_features)
11688 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
11689 Likewise.
11690 * image.c (pbm_read_file): Likewise.
11691 * indent.c (string_display_width): Likewise.
11692 * intervals.c (check_for_interval, search_for_interval)
11693 (inc_interval_count, count_intervals, root_interval)
11694 (adjust_intervals_for_insertion, make_new_interval): Likewise.
11695 * lread.c (defalias): Likewise.
268c2c36 11696 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
11697 * regex.c (set_image_of_range_1, set_image_of_range)
11698 (regex_grow_registers): Likewise.
11699 * sysdep.c (strerror): Likewise.
11700 * termcap.c (valid_filename_p, tprint, main): Likewise.
11701 * tparam.c (main): Likewise.
11702 * unexhp9k800.c (run_time_remap, save_data_space)
11703 (update_file_ptrs, read_header, write_header, calculate_checksum)
11704 (copy_file, copy_rest, display_header): Likewise.
11705 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
11706 Likewise.
11707 * xdisp.c (check_it): Likewise.
11708 * xfaces.c (register_color, unregister_color, unregister_colors):
11709 Likewise.
11710 * xfns.c (print_fontset_result): Likewise.
11711 * xrdb.c (member, fatal, main): Likewise.
11712
99033785
PE
117132011-07-10 Paul Eggert <eggert@cs.ucla.edu>
11714
11715 Fix minor problems found by static checking (Bug#9031).
11716 * chartab.c (char_table_set_range, map_sub_char_table):
11717 Remove unused locals.
11718 (uniprop_table): Now static.
11719 * composite.c (_work_char): Remove unused static var.
11720
9cb2ac56
JB
117212011-07-09 Juanma Barranquero <lekktu@gmail.com>
11722
11723 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
11724
f25661f0
JD
117252011-07-09 Jan Djärv <jan.h.d@swipnet.se>
11726
11727 * gtkutil.c (qttip_cb): Remove code without function.
11728
8278c4fe
EZ
117292011-07-09 Eli Zaretskii <eliz@gnu.org>
11730
11731 * w32.c (pthread_sigmask): New stub.
11732
1692ae2d 117332011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 11734
8a6ebd58 11735 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
11736 sigprocmask is portable only for single-threaded applications, and
11737 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
11738 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
11739 (LIBES): Use it.
11740 * callproc.c (Fcall_process):
11741 * process.c (create_process):
11742 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
11743 Use pthread_sigmask, not sigprocmask.
123403e4 11744
1b854618
JD
117452011-07-08 Jan Djärv <jan.h.d@swipnet.se>
11746
11747 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
11748 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
11749 wrong (Bug#8591).
11750
3fe4b549
JD
117512011-07-08 Jan Djärv <jan.h.d@swipnet.se>
11752
0ce7e563
JD
11753 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
11754 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
11755 (xg_hide_tooltip): Fix comment.
11756
3fe4b549
JD
11757 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
11758 in registerServicesMenuSendTypes.
11759 (validRequestorForSendType): Don't check ns_return_types.
11760
11761 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
11762 ns_return_type.
11763
5df75e47
JR
117642011-07-08 Jason Rumney <jasonr@gnu.org>
11765
22610910
JR
11766 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
11767 SH_SHOW for hidden windows (Bug#5482).
11768
5df75e47
JR
11769 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
11770 frame struct members of non-existent frames (Bug#6284).
11771
699c10bd
JD
117722011-07-08 Jan Djärv <jan.h.d@swipnet.se>
11773
4393663b
JD
11774 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
11775 variable firstTime not needed on OSX >= 10.6.
11776 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
11777 >= 10.5. Use setKnobProportion, setDoubleValue.
11778
11779 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
11780 (MAC_OS_X_VERSION_10_5): Define if not defined.
11781 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
11782 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
11783 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
11784
11785 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 11786 cString and lossyCString on OSX >= 10.4.
4393663b 11787
58179cce 11788 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
11789 sizeToFit on OSX >= 10.2.
11790
11791 * nsimage.m (allocInitFromFile): Don't use deprecated method
11792 bestRepresentationForDevice on OSX >= 10.6.
11793
11794 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
11795 to avoid warning.
11796
11797 * emacs.c: Declare unexec_init_emacs_zone.
11798
a63e0781
JD
11799 * nsgui.h: Fix compiler warning about gnulib redefining verify.
11800
699c10bd
JD
11801 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
11802
11803 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
11804 on svcsMenu (Bug#8842).
11805
11806 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
11807 ns_return_types.
11808 (Fns_list_services): Just return Qnil on 10.6, code not working there.
11809
11810 * nsterm.m (QUTF8_STRING): Declare.
11811 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
11812 (validRequestorForSendType): Return type is (id).
11813 Change indexOfObjectIdenticalTo to indexOfObject.
11814 Check if we have local selection before returning self (Bug#8842).
11815 (writeSelectionToPasteboard): Put local selection into paste board
11816 if we have a local selection (Bug#8842).
11817 (syms_of_nsterm): DEFSYM QUTF8_STRING.
11818
11819 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
11820 (ns_get_local_selection): Declare.
11821
54e10184
LMI
118222011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
11823
9888ff71
LMI
11824 * keymap.c (describe_map_tree): Don't insert a double newline at
11825 the end of the buffer (bug#1169) and return whether we inserted
11826 something.
11827
54e10184
LMI
11828 * callint.c (Fcall_interactively): Change "reading args" to
11829 "providing args" to try to clarify what it does (bug#1010).
11830
15fa4783
KH
118312011-07-07 Kenichi Handa <handa@m17n.org>
11832
11833 * composite.c (composition_compute_stop_pos): Ignore a static
11834 composition starting before CHARPOS (Bug#8915).
11835
11836 * xdisp.c (handle_composition_prop): Likewise.
11837
a8815b00
EZ
118382011-07-07 Eli Zaretskii <eliz@gnu.org>
11839
11840 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
11841 (Bug#9015)
11842
ef7b981d 118432011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
11844
11845 * character.h (unicode_category_t): New enum type.
11846
11847 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
11848 (Qchar_code_property_table): New variable.
11849 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
11850 (UNIPROP_COMPRESSED_FORM_P): New macros.
11851 (char_table_ascii): Uncompress the compressed values.
11852 (sub_char_table_ref): New arg is_uniprop. Callers changed.
11853 Uncompress the compressed values.
ac389d0c 11854 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
11855 (char_table_ref_and_range): Uncompress the compressed values.
11856 (sub_char_table_set): New arg is_uniprop. Callers changed.
11857 Uncompress the compressed values.
11858 (sub_char_table_set_range): Args changed. Callers changed.
11859 (char_table_set_range): Adjuted for the above change.
11860 (map_sub_char_table): Delete args default_val and parent. Add arg
11861 top. Give decoded values to a Lisp function.
640c8776 11862 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
11863 values to a Lisp function. Gcpro more variables.
11864 (uniprop_table_uncompress)
11865 (uniprop_decode_value_run_length): New functions.
11866 (uniprop_decoder, uniprop_decoder_count): New variables.
11867 (uniprop_get_decoder, uniprop_encode_value_character)
11868 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
11869 New functions.
11870 (uniprop_encoder, uniprop_encoder_count): New variables.
11871 (uniprop_get_encoder, uniprop_table)
11872 (Funicode_property_table_internal, Fget_unicode_property_internal)
11873 (Fput_unicode_property_internal): New functions.
11874 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
11875 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 11876 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
11877 char-code-property-alist.
11878
640c8776 11879 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
11880 Vunicode_category_table.
11881
640c8776 11882 * font.c (font_range): Adjust for the change of
c805dec0
KH
11883 Vunicode_category_table.
11884
76b397fb
DN
118852011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
11886
11887 * m/iris4d.h: Remove file, move contents ...
11888 * s/irix6-5.h: ... here.
11889
22b4128e
PE
118902011-07-06 Paul Eggert <eggert@cs.ucla.edu>
11891
11892 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
11893 * alloc.c (mark_buffer):
11894 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
11895 (clone_per_buffer_values): Don't assume that
22b4128e
PE
11896 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
11897 This isn't true in general, and it's particularly not true
11898 if Emacs is configured with --with-wide-int.
11899 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
11900 New macros, used in the buffer.c change.
11901
869795d6
JD
119022011-07-05 Jan Djärv <jan.h.d@swipnet.se>
11903
11904 * xsettings.c: Use both GConf and GSettings if both are available.
11905 (store_config_changed_event): Add comment.
11906 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
11907 (store_tool_bar_style_changed): New functions.
5e617bc2 11908 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
11909 (struct xsettings): Move font inside HAVE_XFT.
11910 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 11911 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 11912 Move inside HAVE_XFT.
640c8776 11913 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
11914 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
11915 also.
11916 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 11917 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 11918 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
11919 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
11920 (parse_settings): Move check for font inside HAVE_XFT.
11921 (read_settings, apply_xft_settings): Add comment.
11922 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
11923 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
11924 call store_font_name_changed.
11925 (xft_settings_event): Add comment.
11926 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
11927 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
11928 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
11929 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
11930 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
11931 (xsettings_get_system_font, xsettings_get_system_normal_font):
11932 Add comment.
869795d6 11933
d8ed26bd
PE
119342011-07-05 Paul Eggert <eggert@cs.ucla.edu>
11935
11936 Random fixes. E.g., (random) never returned negative values.
11937 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
11938 subseconds part to the entropy, as that's a bit more random.
11939 Prefer signed to unsigned, since the signedness doesn't matter and
11940 in general we prefer signed. When given a limit, use a
11941 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
11942 latter isn't right if USE_2_TAGS_FOR_INTS.
11943 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
11944 not 0..VALMASK. Don't discard "excess" bits that random () returns.
11945
cabf1cac
SM
119462011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
11947
11948 * textprop.c (text_property_stickiness):
11949 Obey Vtext_property_default_nonsticky.
11950 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
11951 * w32fns.c (syms_of_w32fns):
11952 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
11953
6e9b2be9
PE
119542011-07-04 Paul Eggert <eggert@cs.ucla.edu>
11955
11956 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
11957 This is more efficient than Ffile_directory_p and avoids a minor race.
11958
90186c68
LMI
119592011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
11960
7c301272
LMI
11961 * buffer.c (Foverlay_put): Say what the return value is
11962 (bug#7835).
11963
c4f2d8d4
LMI
11964 * fileio.c (barf_or_query_if_file_exists): Check first if the file
11965 is a directory before asking whether to use the file name
11966 (bug#7564).
ad637907
LMI
11967 (barf_or_query_if_file_exists): Make the "File is a directory"
11968 error be more correct.
c4f2d8d4 11969
90186c68
LMI
11970 * fns.c (Frequire): Remove the mention of the .gz files, since
11971 that's installation-specific, but keep the mention of
11972 `get-load-suffixes'.
11973
da64016e
PE
119742011-07-04 Paul Eggert <eggert@cs.ucla.edu>
11975
11976 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
11977 Report string overflow if the output is too long.
11978
7d47b580
JB
119792011-07-04 Juanma Barranquero <lekktu@gmail.com>
11980
a555cb87
JB
11981 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
11982 (syms_of_gnutls): Remove duplicate DEFSYM for
11983 Qgnutls_bootprop_verify_hostname_error, an error for
11984 Qgnutls_bootprop_verify_error (which is no longer used).
11985
7d47b580
JB
11986 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
11987 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
11988 Also (re)move comments that are misplaced or no longer relevant.
11989
1e49bfab
LMI
119902011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
11991
11992 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
11993
1485f4c0
CY
119942011-07-03 Chong Yidong <cyd@stupidchicken.com>
11995
11996 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
11997 and background color parameters if they have been changed.
11998
a9ab721e
LMI
119992011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
12000
12001 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
12002
cf7cff57
PE
120032011-07-03 Paul Eggert <eggert@cs.ucla.edu>
12004
2e13213d
PE
12005 * xsettings.c (SYSTEM_FONT): Define only when used.
12006 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
12007
cf7cff57
PE
12008 * keymap.c (access_keymap_1): Now static.
12009
7a8e04f7
CY
120102011-07-02 Chong Yidong <cyd@stupidchicken.com>
12011
12012 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
12013 leave any prefix arg for the up event (Bug#1586).
12014
61352f62
LMI
120152011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
12016
69bb1ef7
LMI
12017 * lread.c (syms_of_lread): Mention single symbols defined by
12018 `defvar' or `defconst' (bug#7154).
12019
61352f62 12020 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 12021 (Frequire): Mention get-load-suffixes.
61352f62 12022
28545e04
MR
120232011-07-02 Martin Rudalics <rudalics@gmx.at>
12024
12025 * window.h (window): Remove clone_number slot.
12026 * window.c (Fwindow_clone_number, Fset_window_clone_number):
12027 Remove.
12028 (make_parent_window, make_window, saved_window)
12029 (Fset_window_configuration, save_window_save): Don't deal with
12030 clone numbers.
12031 * buffer.c (Qclone_number): Remove declaration.
12032 (sort_overlays, overlay_strings): Don't deal with clone numbers.
12033
3349e122
SM
120342011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
12035
12036 Add multiple inheritance to keymaps.
12037 * keymap.c (Fmake_composed_keymap): New function.
12038 (Fset_keymap_parent): Simplify.
12039 (fix_submap_inheritance): Remove.
12040 (access_keymap_1): New function extracted from access_keymap to handle
12041 embedded parents and handle lists of maps.
12042 (access_keymap): Use it.
12043 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
12044 (Fcopy_keymap): Handle embedded parents.
12045 (Fcommand_remapping, define_as_prefix): Simplify.
12046 (Fkey_binding): Simplify.
12047 (syms_of_keymap): Move minibuffer-local-completion-map,
12048 minibuffer-local-filename-completion-map,
12049 minibuffer-local-must-match-map, and
12050 minibuffer-local-filename-must-match-map to Elisp.
12051 (syms_of_keymap): Defsubr make-composed-keymap.
12052 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
12053 (parse_menu_item): Trivial simplification.
12054
3279eb87
GM
120552011-07-01 Glenn Morris <rgm@gnu.org>
12056
12057 * Makefile.in (SETTINGS_LIBS): Fix typo.
12058
39cb9e56 120592011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4550efdf
KI
12060
12061 * coding.c (Fencode_coding_string): Record the last coding system
12062 used, as the function doc string says (bug#8738).
12063
0949d2b6
JD
120642011-07-01 Jan Djärv <jan.h.d@swipnet.se>
12065
12066 * xsettings.c (store_monospaced_changed): Take new font as arg and
12067 check for change against current_mono_font.
12068 (EMACS_TYPE_SETTINGS): Remove this and related defines.
12069 (emacs_settings_constructor, emacs_settings_get_property)
12070 (emacs_settings_set_property, emacs_settings_class_init)
12071 (emacs_settings_init, gsettings_obj): Remove.
12072 (something_changedCB): New function for HAVE_GSETTINGS.
12073 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
12074 with value as argument.
12075 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
12076 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 12077 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
12078 "changed".
12079
12080 * xgselect.c: Add defined (HAVE_GSETTINGS).
12081 (xgselect_initialize): Ditto.
12082
12083 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
12084 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
12085 xg_select.
12086
bbc6b304
PE
120872011-07-01 Paul Eggert <eggert@cs.ucla.edu>
12088
12089 * eval.c (struct backtrace): Simplify and port the data structure.
12090 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
12091 signed bit field, as this assumption is not portable and it makes
12092 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
12093 "char debug_on_exit : 1" as this is not portable either; instead,
12094 use the portable "unsigned int debug_on_exit : 1". Remove unused
12095 member evalargs. Remove obsolete comments about cc bombing out.
12096
9851bfc5
JD
120972011-06-30 Jan Djärv <jan.h.d@swipnet.se>
12098
51bb811f 12099 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
12100 Let HAVE_GSETTINGS override HAVE_GCONF.
12101 (store_monospaced_changed): New function.
12102 (EMACS_SETTINGS): A new type derived from GObject to handle
12103 GSettings notifications.
12104 (emacs_settings_constructor, emacs_settings_get_property)
12105 (emacs_settings_set_property, emacs_settings_class_init):
12106 New functions.
12107 (gsettings_client, gsettings_obj): New variables.
12108 (GSETTINGS_SCHEMA): New define.
12109 (something_changedCB): Call store_monospaced_changed.
12110 (init_gsettings): New function.
12111 (xsettings_initialize): Call init_gsettings.
12112 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
12113 to NULL.
12114
640c8776 12115 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
12116 GCONF_CFLAGS/LIBS.
12117
5386012d
MR
121182011-06-29 Martin Rudalics <rudalics@gmx.at>
12119
12120 * window.c (resize_root_window, grow_mini_window)
12121 (shrink_mini_window): Rename Qresize_root_window to
12122 Qwindow_resize_root_window and Qresize_root_window_vertically to
12123 Qwindow_resize_root_window_vertically.
12124
f13e0b08
PE
121252011-06-28 Paul Eggert <eggert@cs.ucla.edu>
12126
12127 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
12128
94515237
JB
121292011-06-27 Juanma Barranquero <lekktu@gmail.com>
12130
12131 * makefile.w32-in: Redesign dependencies so they reflect more
12132 clearly which files are directly included by each source file,
12133 and not through other includes.
12134
e43b6e43
MR
121352011-06-27 Martin Rudalics <rudalics@gmx.at>
12136
12137 * buffer.c (Qclone_number): Declare static and DEFSYM it.
12138 (sort_overlays, overlay_strings): When an overlay's clone number
12139 matches the window's clone number process the overlay even if
12140 the overlay's window property doesn't match the current window.
12141
d68443dc
MR
12142 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
12143 (Fwindow_hchild): Rename to Fwindow_left_child.
12144 (Fwindow_next): Rename to Fwindow_next_sibling.
12145 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
12146 (resize_window_check): Rename to window_resize_check.
12147 (resize_window_apply): Rename to window_resize_apply.
12148 (Fresize_window_apply): Rename to Fwindow_resize_apply.
12149 (Fdelete_other_windows_internal, resize_frame_windows)
12150 (Fsplit_window_internal, Fdelete_window_internal)
12151 (grow_mini_window, shrink_mini_window)
12152 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 12153
c7e73be5
JD
121542011-06-26 Jan Djärv <jan.h.d@swipnet.se>
12155
12156 * emacsgtkfixed.h: State that this is only used with Gtk+3.
12157 (emacs_fixed_set_min_size): Remove.
12158 (emacs_fixed_new): Take frame as argument.
12159
12160 * emacsgtkfixed.c: State that this is only used with Gtk+3.
12161 (_EmacsFixedPrivate): Remove minwidth/height.
12162 Add struct frame *f.
12163 (emacs_fixed_init): Initialize priv->f.
12164 (get_parent_class, emacs_fixed_set_min_size): Remove.
12165 (emacs_fixed_new): Set priv->f to argument.
12166 (emacs_fixed_get_preferred_width)
12167 (emacs_fixed_get_preferred_height): Use min_width/height from
12168 frames size_hint to set minimum and natural (Bug#8919).
12169 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
12170 and use min_width/height from frames size_hint to set
12171 min_width/height (Bug#8919).
12172
12173 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
12174 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
12175 Fix indentation.
c7e73be5 12176
cf99dcf8
EZ
121772011-06-26 Eli Zaretskii <eliz@gnu.org>
12178
12179 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
12180 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
12181 called at ZV.
12182
029529ac
CY
121832011-06-26 Chong Yidong <cyd@stupidchicken.com>
12184
12185 * process.c (wait_reading_process_output): Bypass select if
12186 waiting for a cell while ignoring keyboard input, and input is
12187 pending. Suggested by Jan Djärv (Bug#8869).
12188
7a7ef429
PE
121892011-06-25 Paul Eggert <eggert@cs.ucla.edu>
12190
12191 Use gnulib's dup2 module instead of rolling our own.
12192 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
12193
11fdef7d 121942011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
12195
12196 * dispnew.c (scrolling_window): Before scrolling, turn off a
12197 mouse-highlight in the window being scrolled.
12198
cd3520a4
JB
121992011-06-24 Juanma Barranquero <lekktu@gmail.com>
12200
12201 Move DEFSYM to lisp.h and use everywhere.
12202
12203 * character.h (DEFSYM): Move declaration...
12204 * lisp.h (DEFSYM): ...here.
12205
12206 * gnutls.c:
12207 * minibuf.c:
12208 * w32menu.c:
12209 * w32proc.c:
12210 * w32select.c: Don't include character.h.
12211
12212 * alloc.c (syms_of_alloc):
12213 * buffer.c (syms_of_buffer):
12214 * bytecode.c (syms_of_bytecode):
12215 * callint.c (syms_of_callint):
12216 * casefiddle.c (syms_of_casefiddle):
12217 * casetab.c (init_casetab_once):
12218 * category.c (init_category_once, syms_of_category):
12219 * ccl.c (syms_of_ccl):
12220 * cmds.c (syms_of_cmds):
12221 * composite.c (syms_of_composite):
12222 * dbusbind.c (syms_of_dbusbind):
12223 * dired.c (syms_of_dired):
12224 * dispnew.c (syms_of_display):
12225 * doc.c (syms_of_doc):
12226 * editfns.c (syms_of_editfns):
12227 * emacs.c (syms_of_emacs):
12228 * eval.c (syms_of_eval):
12229 * fileio.c (syms_of_fileio):
12230 * fns.c (syms_of_fns):
12231 * frame.c (syms_of_frame):
12232 * fringe.c (syms_of_fringe):
12233 * insdel.c (syms_of_insdel):
12234 * keymap.c (syms_of_keymap):
12235 * lread.c (init_obarray, syms_of_lread):
12236 * macros.c (syms_of_macros):
12237 * msdos.c (syms_of_msdos):
12238 * print.c (syms_of_print):
12239 * process.c (syms_of_process):
12240 * search.c (syms_of_search):
12241 * sound.c (syms_of_sound):
12242 * syntax.c (init_syntax_once, syms_of_syntax):
12243 * terminal.c (syms_of_terminal):
12244 * textprop.c (syms_of_textprop):
12245 * undo.c (syms_of_undo):
12246 * w32.c (globals_of_w32):
12247 * window.c (syms_of_window):
12248 * xdisp.c (syms_of_xdisp):
12249 * xfaces.c (syms_of_xfaces):
12250 * xfns.c (syms_of_xfns):
12251 * xmenu.c (syms_of_xmenu):
12252 * xsettings.c (syms_of_xsettings):
12253 * xterm.c (syms_of_xterm): Use DEFSYM.
12254
4228cf16
TZ
122552011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
12256
cd3520a4 12257 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 12258
7fcccf1e
PE
122592011-06-23 Paul Eggert <eggert@cs.ucla.edu>
12260
7efb4e0e
PE
12261 Integer and buffer overflow fixes (Bug#8873).
12262
ff5844ad
PE
12263 * print.c (printchar, strout): Check for string overflow.
12264 (PRINTPREPARE, printchar, strout):
12265 Don't set size unless allocation succeeds.
12266
90532f02
PE
12267 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
12268 for sizes. Check for string overflow more accurately.
12269 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
12270
6d84508d
PE
12271 * macros.c: Integer and buffer overflow fixes.
12272 * keyboard.h (struct keyboard.kbd_macro_bufsize):
12273 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
12274 Use ptrdiff_t, not int, for sizes.
12275 Don't increment bufsize until after realloc succeeds.
12276 Check for size-calculation overflow.
12277 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
12278
437b2cb4
PE
12279 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
12280
8b9ac8b4
PE
12281 * lread.c: Integer overflow fixes.
12282 (read_integer): Radix is now EMACS_INT, not int,
12283 to improve quality of diagnostics for out-of-range radices.
12284 Calculate buffer size correctly for out-of-range radices.
12285 (read1): Check for integer overflow in radices, and in
12286 read-circle numbers.
82cb60d3
PE
12287 (read_escape): Avoid int overflow.
12288 (Fload, openp, read_buffer_size, read1)
12289 (substitute_object_recurse, read_vector, read_list, map_obarray):
12290 Use ptrdiff_t, not int, for sizes.
12291 (read1): Use EMACS_INT, not int, for sizes.
20270765 12292 Check for size overflow.
8b9ac8b4 12293
7fcccf1e
PE
12294 * image.c (cache_image): Check for size arithmetic overflow.
12295
bfbbd7e7
PE
12296 * lread.c: Integer overflow issues.
12297 (saved_doc_string_size, saved_doc_string_length)
12298 (prev_saved_doc_string_size, prev_saved_doc_string_length):
12299 Now ptrdiff_t, not int.
12300 (read1): Don't assume doc string length fits in int. Check for
12301 out-of-range doc string lengths.
12302 (read_list): Don't assume file position fits in int.
39019e54 12303 (read_escape): Check for hex character overflow.
bfbbd7e7 12304
4e323265
LL
123052011-06-22 Leo Liu <sdl.web@gmail.com>
12306
12307 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
12308 Move to minibuffer.el.
12309
85fece3e
PE
123102011-06-22 Paul Eggert <eggert@cs.ucla.edu>
12311
20b84ce9 12312 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
12313 The following patches are for when GLYPH_DEBUG && !XASSERT.
12314 * dispextern.h (trace_redisplay_p, dump_glyph_string):
12315 * dispnew.c (flush_stdout):
12316 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
12317 Mark as externally visible.
12318 * dispnew.c (check_window_matrix_pointers): Now static.
12319 * dispnew.c (window_to_frame_vpos):
12320 * xfns.c (unwind_create_frame):
12321 * xterm.c (x_check_font): Remove unused local.
12322 * scroll.c (CHECK_BOUNDS):
12323 * xfaces.c (cache_fache): Rename local to avoid shadowing.
12324 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
12325 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
12326 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
12327 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
12328 Now static.
12329 (debug_method_add): Use va_list and vsprintf rather than relying
12330 on undefined behavior with wrong number of arguments.
12331 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
12332 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
12333 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
12334 since we're not interested in debugging glyphs with old libraries.
12335 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
12336 GCC 4.6.0's static checking.
12337
0766b489
PE
123382011-06-22 Paul Eggert <eggert@cs.ucla.edu>
12339
31fd4b32
PE
12340 Integer overflow and signedness fixes (Bug#8873).
12341 A few related buffer overrun fixes, too.
12342
b79e8648
PE
12343 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
12344
0766b489
PE
12345 * dispextern.h (struct face.stipple):
12346 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
12347 (x_bitmap_mask, x_allocate_bitmap_record)
12348 (x_create_bitmap_from_data, x_create_bitmap_from_file)
12349 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
12350 (x_create_bitmap_from_xpm_data):
12351 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
12352 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
12353 (.bitmaps_last):
12354 * xfaces.c (load_pixmap):
12355 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
12356 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
12357 (.bitmaps_last, struct x_output.icon_bitmap):
12358 Use ptrdiff_t, not int, for bitmap indexes.
12359 (x_allocate_bitmap_record): Check for size overflow.
12360 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
12361
b081724f
PE
12362 Use ptrdiff_t, not int, for overlay counts.
12363 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
12364 * editfns.c (overlays_around, get_pos_property):
12365 * textprop.c (get_char_property_and_overlay):
12366 * xdisp.c (next_overlay_change, note_mouse_highlight):
12367 * xfaces.c (face_at_buffer_position):
21514da7
PE
12368 * buffer.c (OVERLAY_COUNT_MAX): New macro.
12369 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
12370 (Fnext_overlay_change, Fprevious_overlay_change)
12371 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 12372 Use ptrdiff_t, not int, for sizes.
21514da7 12373 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 12374
3de73e5e
PE
12375 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
12376
2606c57b
PE
12377 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
12378 (x_session_initialize): Do not assume string length fits in int.
12379
aaafe47a
PE
12380 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
12381 This is unlikely, but can occur if DPI is outlandish.
12382
2674ddc8 12383 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
12384 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
12385
28154962
PE
12386 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
12387 * xrdb.c (magic_file_p, search_magic_path):
12388 Omit last arg SUFFIX; it was always 0. All callers changed.
12389 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
12390
7de51af5
PE
12391 * xfont.c (xfont_match): Avoid need for strlen.
12392
25ed6cc3
PE
12393 * xfns.c: Don't assume strlen fits in int.
12394 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
12395
4eab31dd
PE
12396 * xdisp.c (message_log_check_duplicate): Return intmax_t,
12397 not unsigned long, as we prefer signed integers. All callers changed.
12398 Detect integer overflow in repeat count.
12399 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 12400 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 12401
171e2a58
PE
12402 * termcap.c: Don't assume sizes fit in int and never overflow.
12403 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
12404 (gobble_line): Check for size-calculation overflow.
12405
ad39faca 12406 * minibuf.c (Fread_buffer):
6e5bb2dc 12407 * lread.c (intern, intern_c_string):
74ca2eb3
PE
12408 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
12409 Don't assume string length fits in int.
12410
52c61c22 12411 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
12412 * gtkutil.c (style_changed_cb): Avoid need for strlen.
12413
b5b8c9e5
PE
12414 * font.c: Don't assume string length fits in int.
12415 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
12416 Use ptrdiff_t, not int.
ccd6111c
PE
12417 (font_intern_prop): Don't assume string length fits in int.
12418 Don't assume integer property fits in fixnum.
12419 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 12420
882f0d81 12421 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 12422 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
12423 Reformulate so as not to need the command string.
12424 Invoke gzip -cd rather than gunzip, as it's more portable.
12425 (lock_info_type, lock_file_1, lock_file):
12426 Don't assume pid_t and time_t fit in unsigned long.
12427 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
12428 (current_lock_owner): Prefer signed type for sizes.
12429 Use memcpy, not strncpy, where memcpy is what is really wanted.
12430 Don't assume (via atoi) that time_t and pid_t fit in int.
12431 Check for time_t and/or pid_t out of range, e.g., via a network share.
12432 Don't alloca where an auto var works fine.
12433
93f4cf88
PE
12434 * fileio.c: Fix some integer overflow issues.
12435 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
12436 Don't assume string length fits in int.
12437 (directory_file_name): Don't assume string length fits in long.
12438 (make_temp_name): Don't assume pid fits in int, or that its print
12439 length is less than 20.
12440
f3e92b69
PE
12441 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
12442
1bfdaf10
PE
12443 * coding.c (make_subsidiaries): Don't assume string length fits in int.
12444
35016e9a
PE
12445 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
12446
3d1e65a1
PE
12447 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
12448 We prefer signed integers, even for size calculations.
12449
0b963a93
PE
12450 * emacs.c: Don't assume string length fits in 'int'.
12451 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
12452 (main): Don't invoke strlen when not needed.
12453
573f4b54
PE
12454 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
12455 (XD_DEBUG_MESSAGE): Don't waste a byte.
12456
989f33ba
PE
12457 * callproc.c (getenv_internal_1, getenv_internal)
12458 (Fgetenv_internal):
965d34eb
PE
12459 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
12460
e4d29b33
PE
12461 * lread.c (invalid_syntax): Omit length argument.
12462 All uses changed. This doesn't fix a bug, but it simplifies the
12463 code away from its former Hollerith-constant appearance, and it's
12464 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 12465 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 12466
eb49b136
PE
12467 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
12468 This didn't break anything, but it didn't help either.
12469 It's confusing to put a bogus integer in a place where the actual
12470 value does not matter.
9f62aeb1 12471 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 12472 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 12473
15375a22
PE
12474 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
12475 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
12476 implementation.
b61cc01c
PE
12477 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
12478 We prefer signed types, and the value cannot exceed the EMACS_INT
12479 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
12480 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
12481 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
12482 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 12483
53b2623d
PE
12484 * indent.c (sane_tab_width): New function.
12485 (current_column, scan_for_column, Findent_to, position_indentation)
12486 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 12487 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 12488
51cab52b 12489 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 12490
f2ed8a70
PE
12491 * lisp.h (lint_assume): New macro.
12492 * composite.c (composition_gstring_put_cache):
12493 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
12494
abe80cc6
PE
12495 * editfns.c, insdel.c:
12496 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 12497
b02c740e
PE
12498 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
12499
ebc96716
PE
12500 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
12501
b4e50fa0 12502 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 12503 Use much-faster test for byte-length change.
311d5d7c 12504 Don't assume string byte-length fits in 'int'.
a4cf38e4 12505 Check that character arg fits in 'int'.
85461888 12506 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 12507
c0c1ee9f
PE
12508 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
12509
a498d7f4
PE
12510 * fns.c (concat): Catch string overflow earlier.
12511 Do not rely on integer wraparound.
12512
51cab52b
PE
12513 * dispextern.h (struct it.overlay_strings_charpos)
12514 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
12515 * xdisp.c (forward_to_next_line_start)
12516 (back_to_previous_visible_line_start)
12517 (reseat_at_next_visible_line_start, next_element_from_buffer):
12518 Don't arbitrarily truncate the value of 'selective' to int.
12519
76031fad
PE
12520 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
12521
5eb55db9
PE
12522 * composite.c: Don't truncate sizes to 'int'.
12523 (composition_gstring_p, composition_reseat_it)
12524 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
12525 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
12526 not EMACS_UINT, for indexes.
5eb55db9 12527
0703a717
PE
12528 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
12529
d6202519
PE
12530 * buffer.c: Include <verify.h>.
12531 (struct sortvec.priority, struct sortstr.priority):
8961a454 12532 Now EMACS_INT, not int.
c20998a7 12533 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
12534 (struct sortstr.size, record_overlay_string)
12535 (struct sortstrlist.size, struct sortlist.used):
12536 Don't truncate size to int.
12537 (record_overlay_string): Check for size-calculation overflow.
d6202519 12538 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 12539
d5a19415
JM
125402011-06-22 Jim Meyering <meyering@redhat.com>
12541
029529ac 12542 Don't leak an XBM-image-sized buffer
d5a19415
JM
12543 * image.c (xbm_load): Free the image buffer after using it.
12544
a9041e6c
PE
125452011-06-21 Paul Eggert <eggert@cs.ucla.edu>
12546
12547 Port to Sun C.
12548 * composite.c (find_automatic_composition): Omit needless 'return 0;'
12549 that Sun C diagnosed.
12550 * fns.c (secure_hash): Fix pointer signedness issue.
12551 * intervals.c (static_offset_intervals): New function.
12552 (offset_intervals): Use it.
12553
7f3f739f
LL
125542011-06-21 Leo Liu <sdl.web@gmail.com>
12555
12556 * deps.mk (fns.o):
12557 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
12558 sha512.h.
12559
12560 * fns.c (secure_hash): Rename from crypto_hash_function and change
12561 the first arg to accept symbols.
5b66d427 12562 (Fsecure_hash): New primitive.
7f3f739f
LL
12563 (syms_of_fns): New symbols.
12564
76147d94
DD
125652011-06-20 Deniz Dogan <deniz@dogan.se>
12566
12567 * process.c (Fset_process_buffer): Clarify return value in
12568 docstring.
12569
7d7d0045
CY
125702011-06-18 Chong Yidong <cyd@stupidchicken.com>
12571
12572 * dispnew.c (add_window_display_history): Use BVAR.
12573
12574 * xdisp.c (debug_method_add): Use BVAR.
12575 (check_window_end, dump_glyph_matrix, dump_glyph)
12576 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
12577
12578 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
12579 Likewise.
12580
12581 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
12582 check till after the cache is created in init_frame_faces.
12583
ff2bc410
SM
125842011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
12585
12586 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
12587
28177add
PE
125882011-06-16 Paul Eggert <eggert@cs.ucla.edu>
12589
dd3482fe
PE
12590 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
12591 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
12592 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
12593
393d71f3 12594 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
12595 * fileio.c (Finsert_file_contents):
12596 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
12597 Remove the old (too-loose) buffer overflow checks.
12598 They weren't needed, since make_gap checks for buffer overflow.
12599 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
12600 The old code merely checked for Emacs fixnum overflow, and relied
12601 on undefined (wraparound) behavior. The new code avoids undefined
12602 behavior, and also checks for ptrdiff_t and/or size_t overflow.
12603
2e6813b0 12604 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
12605 Tune. Don't use wider integers than needed. Don't use alloca.
12606 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 12607
599a9e4f
PE
12608 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
12609
99561444
PE
12610 * insdel.c, lisp.h (buffer_overflow): New function.
12611 (insert_from_buffer_1, replace_range, replace_range_2):
12612 * insdel.c (make_gap_larger):
12613 * editfns.c (Finsert_char):
12614 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
12615
28177add
PE
12616 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
12617
e69dafad
PE
126182011-06-15 Paul Eggert <eggert@cs.ucla.edu>
12619
4baa020d 12620 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 12621
b1c46f02
PE
12622 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
12623 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
12624
e69dafad
PE
12625 * fileio.c: Don't assume EMACS_INT fits in off_t.
12626 (emacs_lseek): New static function.
12627 (Finsert_file_contents, Fwrite_region): Use it.
12628 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
12629
566684ea
PE
12630 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
12631
e6966cd6
PE
12632 * fns.c: Don't overflow int when computing a list length.
12633 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
12634 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
12635 truncation on 64-bit hosts. Check for QUIT every
12636 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
12637 faster and is responsive enough.
12638 (Flength): Report an error instead of overflowing an integer.
12639 (Fsafe_length): Return a float if the value is not representable
12640 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 12641 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 12642 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 12643
dd0b0efb
PE
12644 * alloc.c: Check that resized vectors' lengths fit in fixnums.
12645 (header_size, word_size): New constants.
12646 (allocate_vectorlike): Don't check size overflow here.
12647 (allocate_vector): Check it here instead, since this is the only
12648 caller of allocate_vectorlike that could cause overflow.
12649 Check that the new vector's length is representable as a fixnum.
12650
86fe5cfe
PE
12651 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
12652 The previous code was bogus. For example, next_almost_prime (32)
12653 returned 39, which is undesirable as it is a multiple of 3; and
12654 next_almost_prime (24) returned 25, which is a multiple of 5 so
12655 why was the code bothering to check for multiples of 7?
12656
80e88859
PE
12657 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
12658
4a2f0ad6
PE
12659 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
12660
f66c7cf8
PE
12661 Variadic C functions now count arguments with ptrdiff_t.
12662 This partly undoes my 2011-03-30 change, which replaced int with size_t.
12663 Back then I didn't know that the Emacs coding style prefers signed int.
12664 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
12665 were being counted with int, which may truncate counts on 64-bit
12666 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
12667 * lisp.h (struct Lisp_Subr.function.aMANY)
12668 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
12669 Arg counts are now ptrdiff_t, not size_t.
12670 All variadic functions and their callers changed accordingly.
12671 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
12672 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
12673 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
12674 * callint.c (Fcall_interactively): Check arg count for overflow,
12675 to avoid potential buffer overrun. Use signed char, not 'int',
12676 for 'varies' array, so that we needn't bother to check its size
12677 calculation for overflow.
12678 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
12679 * eval.c (apply_lambda):
12680 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
12681 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
12682 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
12683
a1759b76
PE
12684 * callint.c (Fcall_interactively): Don't use index var as event count.
12685
d96be9fc
PE
12686 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
12687 * mem-limits.h (SIZE): Remove; no longer used.
12688
a690a978 12689 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 12690
578c21e6
PE
12691 Remove unnecessary casts.
12692 * xterm.c (x_term_init):
12693 * xfns.c (x_set_border_pixel):
12694 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
12695 These aren't needed now that we assume ANSI C.
12696
96f53c6c
PE
12697 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
12698 It's more likely to cause problems (due to unsigned overflow)
12699 than to cure them.
12700
83c77d31
PE
12701 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
12702
ee2079f1
PE
12703 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
12704
6da65536
PE
12705 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
12706
7147c4a4
PE
12707 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
12708
193e32d9
PE
12709 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
12710
e5533da6
PE
12711 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
12712
9910e595
PE
12713 GLYPH_CODE_FACE returns EMACS_INT, not int.
12714 * dispextern.h (merge_faces):
12715 * xfaces.c (merge_faces):
01103c44
PE
12716 * xdisp.c (get_next_display_element, next_element_from_display_vector):
12717 Don't assume EMACS_INT fits in int.
9910e595 12718
2638320e
PE
12719 * character.h (CHAR_VALID_P): Remove unused parameter.
12720 * fontset.c, lisp.h, xdisp.c: All uses changed.
12721
045eb8d9
PE
12722 * editfns.c (Ftranslate_region_internal): Omit redundant test.
12723
c1f134b5
PE
12724 * fns.c (concat): Minor tuning based on overflow analysis.
12725 This doesn't fix any bugs. Use int to hold character, instead
12726 of constantly refetching from Emacs object. Use XFASTINT, not
12727 XINT, for value known to be a character. Don't bother comparing
12728 a single byte to 0400, as it's always less.
12729
395fcb93 12730 * floatfns.c (Fexpt):
327eeec8
PE
12731 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
12732
abbd3d23
PE
12733 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
12734 for characters.
12735
684a03ef
PE
12736 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
12737
0fed43f3
PE
12738 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
12739 Without this fix, on a 64-bit host (aset S 0 4294967386) would
12740 incorrectly succeed when S was a string, because 4294967386 was
12741 truncated before it was used.
12742
8fd02eb7
PE
12743 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
12744 Otherwise, an out-of-range integer could cause undefined behavior
12745 on a 64-bit host.
12746
f8c86b69
PE
12747 * composite.c: Use int, not EMACS_INT, for characters.
12748 (fill_gstring_body, composition_compute_stop_pos): Use int, not
12749 EMACS_INT, for values that are known to be in character range.
12750 This doesn't fix any bugs but is the usual style inside Emacs and
12751 may generate better code on 32-bit machines.
12752
34206dd2
PE
12753 Make sure a 64-bit char is never passed to ENCODE_CHAR.
12754 This is for reasons similar to the recent CHAR_STRING fix.
12755 * charset.c (Fencode_char): Check that character arg is actually
12756 a character. Pass an int to ENCODE_CHAR.
12757 * charset.h (ENCODE_CHAR): Verify that the character argument is no
12758 wider than 'int', as a compile-time check to prevent future regressions
12759 in this area.
12760
c5958d4c 12761 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
12762
12763 Make sure a 64-bit char is never passed to CHAR_STRING.
12764 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
12765 by silently ignoring the top 32 bits, allowing some values
12766 that were far too large to be valid characters.
12767 * character.h: Include <verify.h>.
12768 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
12769 arguments are no wider than unsigned, as a compile-time check
12770 to prevent future regressions in this area.
12771 * data.c (Faset):
01103c44 12772 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
12773 (Fsubst_char_in_region):
12774 * fns.c (concat):
12775 * xdisp.c (decode_mode_spec_coding):
12776 Adjust to CHAR_STRING's new requirement.
12777 * editfns.c (Finsert_char, Fsubst_char_in_region):
12778 * fns.c (concat): Check that character args are actually
12779 characters. Without this test, these functions did the wrong
12780 thing with wildly out-of-range values on 64-bit hosts.
12781
d37ca623
PE
12782 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
12783 These casts should not be needed on 32-bit hosts, either.
12784 * keyboard.c (read_char):
12785 * lread.c (Fload): Remove casts to unsigned.
12786
ea204efb
PE
12787 * lisp.h (UNSIGNED_CMP): New macro.
12788 This fixes comparison bugs on 64-bit hosts.
12789 (ASCII_CHAR_P): Use it.
12790 * casefiddle.c (casify_object):
01103c44 12791 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
12792 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
12793 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
12794 * dispextern.h (FACE_FROM_ID):
12795 * keyboard.c (read_char): Use UNSIGNED_CMP.
12796
41cb286c
PE
12797 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
12798 not to EMACS_INT, to avoid GCC warning.
12799
4a1b9832
PE
12800 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
12801
55daad71
PE
12802 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
12803 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
12804 isn't needed on 32-bit machines.
8f95c75c 12805
01103c44
PE
12806 * buffer.c (Fgenerate_new_buffer_name):
12807 Use EMACS_INT for count, not int.
0ceccced 12808 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
12809
12810 * data.c (Qcompiled_function): Now static.
12811
c6f072e7
PE
12812 * window.c (window_body_lines): Now static.
12813
20ce5912
PE
12814 * image.c (gif_load): Rename local to avoid shadowing.
12815
9c4c5f81
PE
12816 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
12817 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
12818 * alloc.c (make_save_value): Integer argument is now of type
12819 ptrdiff_t, not int.
12820 (mark_object): Use ptrdiff_t, not int.
12821 * lisp.h (pD): New macro.
12822 * print.c (print_object): Use it.
12823
c0c5c8ae
PE
12824 * alloc.c: Use EMACS_INT, not int, to count objects.
12825 (total_conses, total_markers, total_symbols, total_vector_size)
12826 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
12827 (total_free_floats, total_floats, total_free_intervals)
12828 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
12829 Now EMACS_INT, not int. All uses changed.
12830 (Fgarbage_collect): Compute overall total using a double, so that
12831 integer overflow is less likely to be a problem. Check for overflow
12832 when converting back to an integer.
5a25e253
PE
12833 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
12834 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
12835 These were 'int' variables that could overflow on 64-bit hosts;
12836 they were never used, so remove them instead of repairing them.
211a0b2a 12837 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
12838 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
12839 Previously, this ceilinged at INT_MAX, but that doesn't work on
12840 64-bit machines.
e46bb31a 12841 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 12842
c78baabf 12843 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 12844 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
12845 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
12846 when a (possibly-narrower) signed value would do just as well.
12847 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 12848
c9d624c6
PE
12849 * alloc.c: Catch some string size overflows that we were missing.
12850 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
12851 for convenience in STRING_BYTES_MAX.
12852 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
12853 The definition here is exact; the one in lisp.h was approximate.
12854 (allocate_string_data): Check for string overflow. This catches
12855 some instances we weren't catching before. Also, it catches
12856 size_t overflow on (unusual) hosts where SIZE_MAX <= min
12857 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
12858 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 12859
c9d624c6
PE
12860 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
12861 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 12862 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 12863
353032ce
PE
12864 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
12865
2bccce07
PE
12866 * alloc.c (Fmake_string): Check for out-of-range init.
12867
0ac30604
SM
128682011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
12869
12870 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
12871
c195f2de
JD
128722011-06-14 Jan Djärv <jan.h.d@swipnet.se>
12873
12874 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
12875 xg_get_default_scrollbar_width.
12876
12877 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
12878 (int_gtk_range_get_value): Move to the scroll bar part of the file.
12879 (style_changed_cb): Call update_theme_scrollbar_width and call
12880 x_set_scroll_bar_default_width and xg_frame_set_char_size for
12881 all frames (Bug#8505).
12882 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
12883 Call gtk_window_set_resizable if HAVE_GTK3.
12884 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
12885 and height if HAVE_GTK3 (Bug#8505).
12886 (scroll_bar_width_for_theme): New variable.
12887 (update_theme_scrollbar_width): New function.
12888 (xg_get_default_scrollbar_width): Move code to
12889 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
12890 (xg_initialize): Call update_theme_scrollbar_width.
12891
12892 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
12893
12894 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
12895
e10ac9f1
MR
128962011-06-12 Martin Rudalics <rudalics@gmx.at>
12897
12898 * frame.c (make_frame): Call other_buffer_safely instead of
12899 other_buffer.
12900
12901 * window.c (temp_output_buffer_show): Call display_buffer with
12902 second argument Vtemp_buffer_show_specifiers and reset latter
12903 immediately after the call.
12904 (Vtemp_buffer_show_specifiers): New variable.
12905 (auto_window_vscroll_p, next_screen_context_lines)
12906 (Vscroll_preserve_screen_position): Remove leading asterisks from
12907 doc-strings.
12908
2d3c217e 129092011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 12910
7b7f97e8 12911 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
12912 * buffer.c (Qclone_number): Remove for now, as it's unused.
12913 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
12914 (record_buffer): Remove unused local.
12915 * frame.c (other_visible_frames, frame_buffer_list): Now static.
12916 (set_frame_buffer_list): Remove; unused.
12917 * frame.h (other_visible_frames): Remove decl.
12918 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
12919 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
12920 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
12921 if HAVE_GPM.
12922 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
12923 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
12924 Define only if HAVE_GPM.
12925 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
12926 (update_hints_inhibit): Remove; never set. All uses removed.
12927 * widgetprv.h (emacsFrameClassRec): Remove decl.
12928 * window.c (delete_deletable_window): Now returns void, since it
12929 wasn't returning anything.
12930 (compare_window_configurations): Remove unused locals.
12931 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
12932 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
12933 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
12934 the same widths as pointers. This follows up on the 2011-05-06 patch.
12935 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
12936 * xterm.h: Likewise.
12937 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
12938
1384b89e
JB
129392011-06-12 Juanma Barranquero <lekktu@gmail.com>
12940
12941 * makefile.w32-in: Update dependencies.
12942 (LISP_H): Add lib/intprops.h.
12943
1100a63c
CY
129442011-06-11 Chong Yidong <cyd@stupidchicken.com>
12945
12946 * image.c (gif_load): Add animation frame delay to the metadata.
12947 (syms_of_image): Use DEFSYM. New symbol `delay'.
12948
6198ccd0
MR
129492011-06-11 Martin Rudalics <rudalics@gmx.at>
12950
12951 * window.c (delete_deletable_window): Re-add.
12952 (Fset_window_configuration): Rewrite to handle dead buffers and
12953 consequently deletable windows.
12954 (window_tree, Fwindow_tree): Remove. Supply functionality in
12955 window.el.
12956 (compare_window_configurations): Simplify code.
12957
b6e3633c
AS
129582011-06-11 Andreas Schwab <schwab@linux-m68k.org>
12959
1ab0dee5
AS
12960 * image.c (imagemagick_load_image): Fix type mismatch.
12961 (Fimagemagick_types): Likewise.
12962
b6e3633c
AS
12963 * window.h (replace_buffer_in_windows): Declare.
12964
9397e56f
MR
129652011-06-11 Martin Rudalics <rudalics@gmx.at>
12966
12967 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
12968 Qclone_number. Remove external declaration of Qdelete_window.
12969 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
12970 code.
640c8776
SM
12971 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
12972 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
12973 (Fother_buffer): Rewrite doc-string. Major rewrite for new
12974 buffer list implementation.
12975 (other_buffer_safely): New function.
12976 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
12977 calls to replace_buffer_in_windows and
12978 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
12979 if allowed.
12980 (record_buffer): Inhibit quitting and rewrite using quittable
12981 functions. Run Qbuffer_list_update_hook if allowed.
12982 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
12983 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
12984 Move switch-to-buffer to window.el.
9397e56f
MR
12985 (bury-buffer): Move to window.el.
12986 (Vbuffer_list_update_hook): New variable.
12987
12988 * lisp.h (other_buffer_safely): Add prototype in buffer.c
12989 section.
12990
12991 * window.h (resize_frame_windows): Move up in code.
12992 (Fwindow_frame): Remove EXFUN.
12993 (replace_buffer_in_all_windows): Remove prototype.
12994 (replace_buffer_in_windows_safely): Add prototype.
12995
12996 * window.c: Declare Qdelete_window static again. Move down
12997 declaration of select_count.
12998 (Fnext_window, Fprevious_window): Rewrite doc-strings.
12999 (Fother_window): Move to window.el.
13000 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
13001 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
13002 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
13003 window.el.
13004 (replace_buffer_in_windows): Implement by calling
13005 Qreplace_buffer_in_windows.
13006 (replace_buffer_in_all_windows): Remove with some functionality
13007 moved into replace_buffer_in_windows_safely.
13008 (replace_buffer_in_windows_safely): New function.
13009 (select_window_norecord, select_frame_norecord): Move in front
13010 of run_window_configuration_change_hook. Remove now obsolete
13011 declarations.
640c8776
SM
13012 (Fset_window_buffer): Rewrite doc-string.
13013 Call Qrecord_window_buffer.
9397e56f
MR
13014 (keys_of_window): Move binding for other-window to window.el.
13015
b50691aa
CY
130162011-06-11 Chong Yidong <cyd@stupidchicken.com>
13017
13018 * dispextern.h (struct image): Replace data member, whose int_val
13019 and ptr_val fields were not used by anything, with a single
13020 lisp_val object.
13021
13022 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
13023 (gif_clear_image, gif_load, imagemagick_load_image)
13024 (gs_clear_image, gs_load): Callers changed.
13025
3f754b86
PE
130262011-06-10 Paul Eggert <eggert@cs.ucla.edu>
13027
cca69397
PE
13028 * buffer.h: Include <time.h>, for time_t.
13029 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
13030
109e28d0
PE
13031 Fix minor problems found by static checking.
13032
60737f02
PE
13033 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
13034
4b66faf3
PE
13035 Make identifiers static if they are not used in other modules.
13036 * data.c (Qcompiled_function, Qframe, Qvector):
13037 * image.c (QimageMagick, Qsvg):
13038 * minibuf.c (Qmetadata):
13039 * window.c (resize_window_check, resize_root_window): Now static.
13040 * window.h (resize_window_check, resize_root_window): Remove decls.
13041
109e28d0
PE
13042 * window.c (window_deletion_count, delete_deletable_window):
13043 Remove; unused.
46a4ce9e
PE
13044 (window_body_lines): Now static.
13045 (Fdelete_other_windows_internal): Mark vars as initialized.
13046 Make sure 'resize_failed' is initialized.
13047 (run_window_configuration_change_hook): Rename local to avoid shadowing.
13048 (resize_window_apply): Remove unused local.
13049 * window.h (delete_deletable_window): Remove decl.
13050
109e28d0 13051 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
13052 (imagemagick_load_image): Fix pointer signedness problem by changing
13053 last arg from unsigned char * to char *. All uses changed.
13054 Also, fix a local for similar reasons.
13055 Remove unused locals. Remove locals to avoid shadowing.
13056 (fn_rsvg_handle_free): Remove; unused.
13057 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 13058 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 13059
3f754b86
PE
13060 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
13061
2547adb1
CY
130622011-06-10 Chong Yidong <cyd@stupidchicken.com>
13063
13064 * image.c (gif_load): Fix omitted cast error introduced by
13065 2011-06-06 change.
13066
2c8e37d4
MR
130672011-06-10 Martin Rudalics <rudalics@gmx.at>
13068
13069 * window.h (resize_proportionally, orig_total_lines)
13070 (orig_top_line): Remove from window structure.
13071 (set_window_height, set_window_width, change_window_heights)
13072 (Fdelete_window): Remove prototypes.
13073 (resize_frame_windows): Remove duplicate declaration.
13074
440a42e3
EZ
130752011-06-10 Eli Zaretskii <eliz@gnu.org>
13076
13077 * window.h (resize_frame_windows, resize_window_check)
13078 (delete_deletable_window, resize_root_window)
13079 (resize_frame_windows): Declare prototypes.
13080
13081 * window.c (resize_window_apply): Make definition be "static" to
13082 match the prototype.
13083
562dd5e9
MR
130842011-06-10 Martin Rudalics <rudalics@gmx.at>
13085
13086 * window.c: Remove declarations of Qwindow_size_fixed,
13087 window_min_size_1, window_min_size_2, window_min_size,
13088 size_window, window_fixed_size_p, enlarge_window, delete_window.
13089 Remove static from declaration of Qdelete_window, it's
13090 temporarily needed by Fbury_buffer.
13091 (replace_window): Don't assign orig_top_line and
13092 orig_total_lines.
13093 (Fdelete_window, delete_window): Remove. Window deletion is
13094 handled by window.el.
640c8776
SM
13095 (window_loop): Remove DELETE_OTHER_WINDOWS case.
13096 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
13097 (Fdelete_other_windows): Remove. Deleting other windows is
13098 handled by window.el.
13099 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
13100 handled in window.el.
13101 (window_min_size_2, window_min_size_1, window_min_size): Remove.
13102 Window minimum sizes are handled in window.el.
13103 (shrink_windows, size_window, set_window_height)
13104 (set_window_width, change_window_heights, window_height)
13105 (window_width, CURBEG, CURSIZE, enlarge_window)
13106 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
13107 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
13108 handled in window.el.
13109 (make_dummy_parent): Rename to make_parent_window and give it a
13110 second argument horflag.
13111 (make_window): Don't set resize_proportionally any more.
13112 (Fsplit_window): Remove. Windows are split in window.el.
13113 (save_restore_action, save_restore_orig_size)
13114 (shrink_window_lowest_first, save_restore_orig_size): Remove.
13115 Resize mini windows in window.el.
13116 (grow_mini_window, shrink_mini_window): Implement by calling
13117 Qresize_root_window_vertically, resize_window_check and
13118 resize_window_apply.
640c8776
SM
13119 (saved_window, Fset_window_configuration, save_window_save):
13120 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
13121 resize_proportionally.
13122 (window_min_height, window_min_width): Move to window.el.
13123 (keys_of_window): Move bindings for delete-other-windows,
13124 split-window, delete-window and enlarge-window to window.el.
13125
13126 * buffer.c: Temporarily extern Qdelete_window.
13127 (Fbury_buffer): Temporarily call Qdelete_window instead of
13128 Fdelete_window (Fbury_buffer will move to window.el soon).
13129
13130 * frame.c (set_menu_bar_lines_1): Remove code handling
13131 orig_top_line and orig_total_lines.
13132
13133 * dispnew.c (adjust_frame_glyphs_initially): Don't use
13134 set_window_height but set heights directly.
13135 (change_frame_size_1): Use resize_frame_windows.
13136
13137 * xdisp.c (init_xdisp): Don't use set_window_height but set
13138 heights directly.
13139
640c8776
SM
13140 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
13141 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
13142 run_window_configuration_change_hook.
13143
13144 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
13145 instead of change_window_heights and run
13146 run_window_configuration_change_hook.
13147
1a13852e
MR
131482011-06-09 Martin Rudalics <rudalics@gmx.at>
13149
13150 * window.c (replace_window): Rename second argument REPLACEMENT to
13151 NEW. New third argument SETFLAG. Rewrite.
13152 (delete_window, make_dummy_parent): Call replace_window with
13153 third argument 1.
13154 (window_list_1): Move down in code.
13155 (run_window_configuration_change_hook): Move set_buffer part
13156 before select_frame_norecord part in order to unwind correctly.
13157 Rename count1 to count.
13158 (recombine_windows, delete_deletable_window, resize_root_window)
13159 (Fdelete_other_windows_internal)
13160 (Frun_window_configuration_change_hook, make_parent_window)
13161 (resize_window_check, resize_window_apply, Fresize_window_apply)
13162 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
13163 (Fdelete_window_internal, Fresize_mini_window_internal):
13164 New functions.
1a13852e
MR
13165 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
13166
f3d1777e
MR
131672011-06-08 Martin Rudalics <rudalics@gmx.at>
13168
496e208e
MR
13169 * window.h (window): Add some new members to window structure -
13170 normal_lines, normal_cols, new_total, new_normal, clone_number,
13171 splits, nest, prev_buffers, next_buffers.
13172 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 13173 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 13174
f3d1777e
MR
13175 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
13176 Remove.
496e208e
MR
13177 (make_dummy_parent): Set new members of windows structure.
13178 (make_window): Move down in code. Handle new members of window
13179 structure.
13180 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
13181 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
13182 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
13183 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
13184 (Fset_window_next_buffers, Fset_window_clone_number):
13185 New functions.
496e208e
MR
13186 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
13187 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
13188 Doc-string fixes.
13189 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
13190 Argument WINDOW can be now internal window too.
13191 (Fwindow_use_time): Move up in code.
13192 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
13193 Rewrite doc-string.
13194 (Fset_window_configuration, saved_window)
13195 (Fcurrent_window_configuration, save_window_save): Handle new
13196 members of window structure.
b9e809c2
MR
13197 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
13198 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
13199 (syms_of_window): New Lisp objects Qrecord_window_buffer,
13200 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
13201 Qget_mru_window, Qresize_root_window,
13202 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
13203 Qauto_buffer_name; staticpro them.
f3d1777e 13204
abde8f8c
MR
132052011-06-07 Martin Rudalics <rudalics@gmx.at>
13206
13207 * window.c (Fwindow_total_size, Fwindow_left_column)
13208 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
13209 (Fwindow_list_1): New functions.
13210 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
13211 (Fwindow_width, Fscroll_left, Fscroll_right):
13212 Use window_body_cols instead of window_box_text_cols.
13213 (delete_window, Fset_window_configuration):
13214 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
13215 (delete_all_subwindows): Take a window as argument and not a
13216 structure. Rewrite.
190b47e6
MR
13217 (window_loop): Remove handling of GET_LRU_WINDOW and
13218 GET_LARGEST_WINDOW.
13219 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
13220
13221 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
13222 window_box_text_cols. delete_all_subwindows now takes a
13223 Lisp_Object as argument.
abde8f8c 13224
640c8776
SM
13225 * indent.c (compute_motion, Fcompute_motion):
13226 Use window_body_cols instead of window_box_text_cols.
abde8f8c 13227
fa8a67e6
MR
13228 * frame.c (delete_frame): Call delete_all_subwindows with root
13229 window as argument.
13230
a54e3482
DC
132312011-06-07 Daniel Colascione <dan.colascione@gmail.com>
13232
13233 * fns.c (Fputhash): Document return value.
13234
60002bf5
CY
132352011-06-06 Chong Yidong <cyd@stupidchicken.com>
13236
13237 * image.c (gif_load): Implement gif89a spec "no disposal" method.
13238
0c671da6 132392011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 13240
b862a52a 13241 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 13242
be44ca6c
PE
13243 Check for overflow when converting integer to cons and back.
13244 * charset.c (Fdefine_charset_internal, Fdecode_char):
13245 Use cons_to_unsigned to catch overflow.
13246 (Fencode_char): Use INTEGER_TO_CONS.
13247 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
13248 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
13249 * data.c (long_to_cons, cons_to_long): Remove.
13250 (cons_to_unsigned, cons_to_signed): New functions.
13251 These signal an error for invalid or out-of-range values.
13252 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
13253 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
13254 * font.c (Ffont_variation_glyphs):
13255 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
13256 * lisp.h: Include <intprops.h>.
13257 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
13258 (cons_to_signed, cons_to_unsigned): New decls.
13259 (long_to_cons, cons_to_long): Remove decls.
13260 * undo.c (record_first_change): Use INTEGER_TO_CONS.
13261 (Fprimitive_undo): Use CONS_TO_INTEGER.
13262 * xfns.c (Fx_window_property): Likewise.
13263 * xselect.c: Include <limits.h>.
13264 (x_own_selection, selection_data_to_lisp_data):
13265 Use INTEGER_TO_CONS.
13266 (x_handle_selection_request, x_handle_selection_clear)
13267 (x_get_foreign_selection, Fx_disown_selection_internal)
13268 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
13269 (lisp_data_to_selection_data): Use cons_to_unsigned.
13270 (x_fill_property_data): Use cons_to_signed.
13271 Report values out of range.
13272
d1f3d2af
PE
13273 Check for buffer and string overflow more precisely.
13274 * buffer.h (BUF_BYTES_MAX): New macro.
13275 * lisp.h (STRING_BYTES_MAX): New macro.
13276 * alloc.c (Fmake_string):
13277 * character.c (string_escape_byte8):
13278 * coding.c (coding_alloc_by_realloc):
13279 * doprnt.c (doprnt):
13280 * editfns.c (Fformat):
13281 * eval.c (verror):
13282 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
13283 since they may not be the same number.
13284 * editfns.c (Finsert_char):
13285 * fileio.c (Finsert_file_contents):
13286 Likewise for BUF_BYTES_MAX.
13287
dd52fcea
PE
13288 * image.c: Use ptrdiff_t, not int, for sizes.
13289 (slurp_file): Switch from int to ptrdiff_t.
13290 All uses changed.
13291 (slurp_file): Check that file size fits in both size_t (for
13292 malloc) and ptrdiff_t (for sanity and safety).
13293
7f9bbdbb
PE
13294 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
13295 if b->modtime has its maximal value.
13296
dfe18f82
PE
13297 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
13298
84acfcf0
PE
13299 Don't assume time_t can fit into int.
13300 * buffer.h (struct buffer.modtime): Now time_t, not int.
13301 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
13302 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
13303
ccd9a01a
PE
13304 Minor fixes for signed vs unsigned integers.
13305 * character.h (MAYBE_UNIFY_CHAR):
13306 * charset.c (maybe_unify_char):
13307 * keyboard.c (read_char, reorder_modifiers):
13308 XINT -> XFASTINT, since the integer must be nonnegative.
13309 * ftfont.c (ftfont_spec_pattern):
13310 * keymap.c (access_keymap, silly_event_symbol_error):
13311 XUINT -> XFASTINT, since the integer must be nonnegative.
13312 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
13313 since it makes no difference and we prefer signed.
13314 * keyboard.c (record_char): Use XUINT when all the neighbors do.
13315 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
13316 nonnegative.
13317
d6d100dd
SM
133182011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
13319
13320 * window.h (Fwindow_frame): Declare.
13321
2b6148e4
PE
133222011-06-06 Paul Eggert <eggert@cs.ucla.edu>
13323
13324 * alloc.c: Simplify handling of large-request failures (Bug#8800).
13325 (SPARE_MEMORY): Always define.
13326 (LARGE_REQUEST): Remove.
13327 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
13328
f230ecc9
MR
133292011-06-06 Martin Rudalics <rudalics@gmx.at>
13330
727e958e
MR
13331 * lisp.h: Move EXFUNS for Fframe_root_window,
13332 Fframe_first_window and Fset_frame_selected_window to window.h.
13333
13334 * window.h: Move EXFUNS for Fframe_root_window,
13335 Fframe_first_window and Fset_frame_selected_window here from
13336 lisp.h.
13337
13338 * frame.c (Fwindow_frame, Fframe_first_window)
13339 (Fframe_root_window, Fframe_selected_window)
13340 (Fset_frame_selected_window): Move to window.c.
13341 (Factive_minibuffer_window): Move to minibuf.c.
13342 (Fother_visible_frames_p): New function.
13343
13344 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
13345
f230ecc9
MR
13346 * window.c (decode_window, decode_any_window): Move up in code.
13347 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
13348 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
13349 (Fwindow_buffer): Move up and rewrite doc-string.
13350 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
13351 (Fwindow_prev): New functions.
727e958e
MR
13352 (Fwindow_frame): Move here from frame.c. Accept any window as
13353 argument.
13354 (Fframe_root_window, Fframe_first_window)
13355 (Fframe_selected_window): Move here from frame.c. Accept frame
13356 or arbitrary window as argument. Update doc-strings.
13357 (Fminibuffer_window): Move up in code.
13358 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
13359 (Fset_frame_selected_window): Move here from frame.c.
13360 Marginal rewrite.
727e958e
MR
13361 (Fselected_window, select_window, Fselect_window): Move up in
13362 code. Minor doc-string fixes.
f230ecc9 13363
4d09bcf6
PE
133642011-06-06 Paul Eggert <eggert@cs.ucla.edu>
13365
13366 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
13367 Do not assume that spare memory exists; that assumption is valid
13368 only if SYSTEM_MALLOC.
13369 (LARGE_REQUEST): New macro, so that the issue of large requests
13370 is separated from the issue of spare memory.
13371
810928a2
AS
133722011-06-05 Andreas Schwab <schwab@linux-m68k.org>
13373
172418ad
AS
13374 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
13375 format. (Bug#8806)
13376
43f862f7
AS
13377 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
13378
810928a2
AS
13379 * xfns.c (x_set_scroll_bar_default_width): Move declarations
13380 before statements.
13381
a059fe24
JD
133822011-06-05 Jan Djärv <jan.h.d@swipnet.se>
13383
13384 * gtkutil.c (xg_get_default_scrollbar_width): New function.
13385
13386 * gtkutil.h: Declare xg_get_default_scrollbar_width.
13387
13388 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
13389 min width by calling x_set_scroll_bar_default_width (Bug#8505).
13390
989bf368
JB
133912011-06-05 Juanma Barranquero <lekktu@gmail.com>
13392
13393 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
13394
4b80f674
CY
133952011-06-04 Chong Yidong <cyd@stupidchicken.com>
13396
13397 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
13398 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
13399 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
13400 New error handlers.
4b80f674
CY
13401 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
13402 Obey Vx_select_enable_clipboard_manager. Catch errors in
13403 x_clipboard_manager_save (Bug#8779).
13404 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 13405 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 13406
99a33b77 134072011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
13408
13409 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
13410
99a33b77 134112011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
13412
13413 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
13414 in the current matrix if keep_current_p is non-zero.
13415
8264569d
EZ
134162011-06-04 Eli Zaretskii <eliz@gnu.org>
13417
13418 * bidi.c (bidi_level_of_next_char): Fix last change.
13419
57f97249
EZ
134202011-06-03 Eli Zaretskii <eliz@gnu.org>
13421
fec2107c 13422 Support bidi reordering of text covered by display properties.
57f97249 13423
fec2107c
EZ
13424 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
13425 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
13426 (bidi_cache_search, bidi_cache_iterator_state)
13427 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
13428 (bidi_level_of_next_char, bidi_move_to_visually_next):
13429 Support character positions inside a run of characters covered by a
fec2107c
EZ
13430 display string.
13431 (bidi_paragraph_init, bidi_resolve_explicit_1)
13432 (bidi_level_of_next_char): Call bidi_fetch_char and
13433 bidi_fetch_char_advance instead of FETCH_CHAR and
13434 FETCH_CHAR_ADVANCE.
13435 (bidi_init_it): Initialize new members.
13436 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
13437 definitions.
13438 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
13439 instead of using explicit *_CHAR codes.
d6d100dd
SM
13440 (bidi_resolve_explicit, bidi_resolve_weak):
13441 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
13442 bidirectional text is supported only in multibyte buffers.
13443 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
13444 it to initialize the frame_window_p member of struct bidi_it.
13445 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
13446 (bidi_resolve_explicit, bidi_resolve_weak)
13447 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
13448 bidi_it->nchars is non-positive.
13449 (bidi_level_of_next_char): Don't try to lookup the cache for the
13450 next/previous character if nothing is cached there yet, or if we
13451 were just reseat()'ed to a new position.
c40e2fb2 13452
0e14fe90
EZ
13453 * xdisp.c (set_cursor_from_row): Set start and stop points
13454 according to the row's direction when priming the loop that looks
13455 for the glyph on which to display cursor.
13456 (single_display_spec_intangible_p): Function deleted.
13457 (display_prop_intangible_p): Reimplement to call
13458 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
13459 Accept 3 additional arguments needed by handle_display_spec.
13460 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
13461 values: lists, `(when COND...)' forms, etc.
13462 (single_display_spec_string_p): Support property values that are
13463 lists with the argument STRING its top-level element.
13464 (display_prop_string_p): Fix the condition for processing a
13465 property that is a list to be consistent with handle_display_spec.
fec2107c 13466 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
13467 last portion of handle_display_prop.
13468 (compute_display_string_pos): Accept additional argument
13469 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
13470 value of a `display' property is a "replacing spec".
13471 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
13472 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
13473 the display property, but just return a value indicating whether
13474 the display property will replace the characters it covers.
13475 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
13476 frame_window_p members of struct bidi_it.
d6d100dd
SM
13477 (compute_display_string_pos, compute_display_string_end):
13478 New functions.
fec2107c
EZ
13479 (push_it): Accept second argument POSITION, where pop_it should
13480 jump to continue iteration.
13481 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 13482
fec2107c
EZ
13483 * keyboard.c (adjust_point_for_property): Adjust the call to
13484 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
13485
13486 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
13487 (bidi_init_it): Update prototypes.
13488 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
13489 (compute_display_string_pos, compute_display_string_end):
13490 Declare prototypes.
fec2107c
EZ
13491 (struct bidi_it): New members nchars and disp_pos. ch_len is now
13492 EMACS_INT.
fc6f18ce 13493
40087514 134942011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 13495
57f53182
PE
13496 Malloc failure behavior now depends on size of allocation.
13497 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
13498 * lisp.h: Change signatures accordingly.
13499 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
13500 All callers changed. (Bug#8762)
13501
13502 * gnutls.c: Use Emacs's memory allocators.
13503 Without this change, the gnutls library would invoke malloc etc.
13504 directly, which causes problems on non-SYNC_INPUT hosts, and which
13505 runs afoul of improving memory_full behavior. (Bug#8761)
13506 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
13507 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
13508 xfree instead of the default malloc, realloc, free.
13509 (Fgnutls_boot): No need to check for memory allocation failure,
13510 since xmalloc does that for us.
13511
ac32cd99 13512 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
13513 * category.c (hash_get_category_set):
13514 * ccl.c (ccl_driver):
13515 * charset.c (Fdefine_charset_internal):
13516 * charset.h (struct charset.hash_index):
13517 * composite.c (get_composition_id, gstring_lookup_cache)
13518 (composition_gstring_put_cache):
13519 * composite.h (struct composition.hash_index):
13520 * dispextern.h (struct image.hash):
13521 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
13522 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
13523 (hashfn_equal, hashfn_user_defined, make_hash_table)
13524 (maybe_resize_hash_table, hash_lookup, hash_put)
13525 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
13526 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
13527 (Fsxhash, Fgethash, Fputhash, Fmaphash):
13528 * image.c (make_image, search_image_cache, lookup_image)
13529 (xpm_put_color_table_h):
13530 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 13531 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 13532 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 13533 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
13534 * alloc.c (allocate_vectorlike):
13535 Check for overflow in vector size calculations.
13536 * ccl.c (ccl_driver):
13537 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
13538 * fns.c, image.c: Remove unnecessary static decls that would otherwise
13539 need to be updated by these changes.
40087514
PE
13540 * fns.c (make_hash_table, maybe_resize_hash_table):
13541 Check for integer overflow with large hash tables.
0de4bb68
PE
13542 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
13543 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
13544 (SXHASH_REDUCE): New macro.
13545 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
13546 Use it instead of discarding useful hash info with large hash values.
13547 (sxhash_float): New function.
13548 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
13549 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
13550 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
13551 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
13552 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
13553 Adjust signatures to match updated version of code.
13554 (consing_since_gc): Now EMACS_INT, since a single hash table can
13555 use more than INT_MAX bytes.
13556
698d32e2
DN
135572011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
13558
13559 Make it possible to build with GCC-4.6+ -O2 -flto.
13560
13561 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
13562
fd6fa53f
SM
135632011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
13564
13565 * minibuf.c (get_minibuffer, read_minibuf_unwind):
13566 Call minibuffer-inactive-mode.
13567
864db017
JB
135682011-05-31 Juanma Barranquero <lekktu@gmail.com>
13569
13570 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
13571 Update dependencies.
13572
2ad0baf4
DN
135732011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
13574
13575 * data.c (init_data): Remove code for UTS, this system is not
13576 supported anymore.
13577
4fcc2638
DN
135782011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
13579
13580 Don't force ./temacs to start in terminal mode.
13581
13582 * frame.c (make_initial_frame): Initialize faces in all cases, not
13583 only when CANNOT_DUMP is defined.
13584 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
13585
c56e0fd5
DN
135862011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
13587
13588 * dispnew.c (add_window_display_history): Use const for the string
13589 pointer. Remove declaration, not needed.
13590
333d54da 135912011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 13592
55d4c1b2 13593 Use 'inline', not 'INLINE'.
333d54da 13594 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
13595 * alloc.c, fontset.c (INLINE): Remove.
13596 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
13597 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
13598 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
13599 * gmalloc.c (register_heapinfo): Use inline unconditionally.
13600 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
13601
738db178
DN
136022011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
13603
13604 Make it possible to run ./temacs.
13605
13606 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
13607 syms_of_callproc does the same thing. Remove test for
13608 "initialized", do it in the caller.
13609 * emacs.c (main): Avoid calling set_initial_environment when dumping.
13610
620c53a6
SM
136112011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
13612
13613 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
13614 (read_minibuf): Use get_minibuffer.
13615 (syms_of_minibuf): Use DEFSYM.
13616 (Qmetadata): New var.
13617 * data.c (Qbuffer): Don't make it static.
13618 (syms_of_data): Use DEFSYM.
13619
e003a292
PE
136202011-05-31 Paul Eggert <eggert@cs.ucla.edu>
13621
13622 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
13623 (CCL_CODE_MIN): New macro.
13624
ed008a6d
PE
136252011-05-30 Paul Eggert <eggert@cs.ucla.edu>
13626
3687c2ef
PE
13627 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
13628
ed008a6d
PE
13629 * eval.c (Qdebug): Now static.
13630 * lisp.h (Qdebug): Remove decl. This reverts a part of the
13631 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
13632 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
13633
d66c4c7c
CY
136342011-05-29 Chong Yidong <cyd@stupidchicken.com>
13635
13636 * image.c: Various fixes to ImageMagick code comments.
13637 (Fimagemagick_types): Doc fix.
13638
5fbc2025
PE
136392011-05-29 Paul Eggert <eggert@cs.ucla.edu>
13640
0196f88a
PE
13641 Minor fixes prompted by GCC 4.6.0 warnings.
13642
13643 * xselect.c (converted_selections, conversion_fail_tag): Now static.
13644
5fbc2025
PE
13645 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
13646 (x_clipboard_manager_save_all): Move extern decl to ...
13647 * xterm.h: ... here, so that it can be checked for consistency.
13648
1dd3c2d9
CY
136492011-05-29 Chong Yidong <cyd@stupidchicken.com>
13650
13651 * xselect.c (x_clipboard_manager_save_frame)
13652 (x_clipboard_manager_save_all): New functions.
13653 (Fx_clipboard_manager_save): Lisp function deleted.
13654
13655 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
13656 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
13657
13658 * xterm.h: Update prototype.
13659
5ba6571d
WX
136602011-05-28 William Xu <william.xwl@gmail.com>
13661
13662 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
13663 exiting (Bug#8239).
13664
3eaff834
JM
136652011-05-28 Jim Meyering <meyering@redhat.com>
13666
e1900994 13667 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
13668 * fns.c (to_uchar): Define.
13669 (crypto_hash_function): Use it to convert some newly-signed
13670 variables to unsigned, to avoid sign-extension bugs. For example,
13671 without this change, (md5 "truc") would evaluate to
13672 45723a2aff78ff4fff7fff1114760e62 rather than the expected
13673 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 13674 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 13675
0f6990a7
PE
136762011-05-27 Paul Eggert <eggert@cs.ucla.edu>
13677
13678 Integer overflow fixes.
c8a9ca5a 13679
08686060
PE
13680 * dbusbind.c: Serial number integer overflow fixes.
13681 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
13682 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
13683 to hold a serial number that is too large for a fixnum.
13684 (Fdbus_method_return_internal, Fdbus_method_error_internal):
13685 Check for serial numbers out of range. Decode any serial number
59568bf0 13686 that was so large that it became a float. (Bug#8722)
08686060 13687
2d1fc3c7
PE
13688 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
13689 (Fdbus_call_method, Fdbus_call_method_asynchronously):
13690 Use XFASTINT rather than XUINT when numbers are nonnegative.
13691 (xd_append_arg, Fdbus_method_return_internal):
13692 (Fdbus_method_error_internal): Likewise. Also, for unsigned
13693 arguments, check that Lisp number is nonnegative, rather than
59568bf0 13694 silently wrapping negative numbers around. (Bug#8722)
30217ff0 13695 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 13696 (Bug#8722)
2d1fc3c7 13697
c8a9ca5a
PE
13698 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
13699
519e1d69
PE
13700 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
13701
6df6ae42 13702 ccl: Add integer overflow checks.
30569699
PE
13703 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
13704 (IN_INT_RANGE): New macros.
13705 (ccl_driver): Use them to check for integer overflow when
13706 decoding a CCL program. Many of the new checks are whether XINT (x)
13707 fits in int; it doesn't always, on 64-bit hosts. The new version
13708 doesn't catch all possible integer overflows, but it's an
847044ea 13709 improvement. (Bug#8719)
30569699 13710
c11285dc
PE
13711 * alloc.c (make_event_array): Use XINT, not XUINT.
13712 There's no need for unsigned here.
13713
fdccd48e
PE
13714 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
13715 This follows up to the 2011-05-06 change that substituted uintptr_t
13716 for EMACS_INT. This case wasn't caught back then.
13717
37910ab2
PE
13718 Rework Fformat to avoid integer overflow issues.
13719 * editfns.c: Include <float.h> unconditionally, as it's everywhere
13720 now (part of C89). Include <verify.h>.
13721 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
13722 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
13723 (Fformat): Avoid the prepass trying to compute sizes; it was only
13724 approximate and thus did not catch overflow reliably. Instead, walk
13725 through the format just once, formatting and computing sizes as we go,
13726 checking for integer overflow at every step, and allocating a larger
13727 buffer as needed. Keep track separately whether the format is
13728 multibyte. Keep only the most-recently calculated precision, rather
13729 than them all. Record whether each argument has been converted to
13730 string. Use EMACS_INT, not int, for byte and char and arg counts.
13731 Support field widths and precisions larger than INT_MAX. Avoid
13732 sprintf's undefined behavior with conversion specifications such as %#d
13733 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
13734 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
13735 formatting out-of-range floating point numbers with int
9173deec 13736 formats. (Bug#8668)
37910ab2 13737
2e6578fb
PE
13738 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
13739
0ae6bdee
PE
13740 * data.c: Avoid integer truncation in expressions involving floats.
13741 * data.c: Include <intprops.h>.
13742 (arith_driver): When there's an integer overflow in an expression
13743 involving floating point, convert the integers to floating point
13744 so that the resulting value does not suffer from catastrophic
13745 integer truncation. For example, on a 64-bit host (* 4
13746 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
13747 Do not rely on undefined behavior after integer overflow.
13748
de883a70
PE
13749 merge count_size_as_multibyte, parse_str_to_multibyte
13750 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 13751 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
13752 Check for integer overflow.
13753 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
13754 since it's now a duplicate of the other. This is more of
13755 a character than a buffer op, so better that it's in character.c.
13756 * fns.c, print.c: Adjust to above changes.
13757
2ff916cb
PE
137582011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
13759
13760 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
13761
f1b54466
PE
137622011-05-27 Paul Eggert <eggert@cs.ucla.edu>
13763
fb1ac845
PE
13764 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
13765 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
13766 (x_clipboard_manager_save): Now static.
13767 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
13768
f1b54466
PE
13769 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
13770 (crypto_hash_function): Now static.
13771 Fix pointer signedness problems. Avoid unnecessary initializations.
13772
a9f737ee
CY
137732011-05-27 Chong Yidong <cyd@stupidchicken.com>
13774
13775 * termhooks.h (Vselection_alist): Make it terminal-local.
13776
13777 * terminal.c (create_terminal): Initialize it.
13778
13779 * xselect.c: Support for clipboard managers.
13780 (Vselection_alist): Move to termhooks.h as terminal-local var.
13781 (LOCAL_SELECTION): New macro.
13782 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
13783 (symbol_to_x_atom): Remove gratuitous arg.
13784 (x_handle_selection_request, lisp_data_to_selection_data)
13785 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
13786 (x_own_selection, x_get_local_selection, x_convert_selection):
13787 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
13788 (some_frame_on_display): Delete unused function.
13789 (Fx_own_selection_internal, Fx_get_selection_internal)
13790 (Fx_disown_selection_internal, Fx_selection_owner_p)
13791 (Fx_selection_exists_p): New optional frame arg.
13792 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
13793 (x_handle_selection_clear): Don't treat other terminals with the
13794 same keyboard specially. Use the terminal-local Vselection_alist.
13795 (x_clear_frame_selections): Use Frun_hook_with_args.
13796
13797 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
13798
13799 * xterm.h: Add support for those atoms.
13800
e067f0c1
CY
138012011-05-26 Chong Yidong <cyd@stupidchicken.com>
13802
13803 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
13804 (converted_selections, conversion_fail_tag): New global variables.
13805 (x_selection_request_lisp_error): Free the above.
13806 (x_get_local_selection): Remove unnecessary code.
13807 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
13808 of converted selections stored in converted_selections.
13809 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
13810 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
13811 (x_convert_selection): New function.
13812 (x_handle_selection_event): Simplify.
13813 (x_get_foreign_selection): Don't ignore incoming requests while
13814 waiting for an answer; this will fail when we implement
13815 SAVE_TARGETS, and seems unnecessary anyway.
13816 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
13817 (Vx_sent_selection_functions): Doc fix.
13818
0f4aebc0
LL
138192011-05-26 Leo Liu <sdl.web@gmail.com>
13820
13821 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
13822
e61124cd
YM
138232011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
13824
13825 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
13826
13827 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
13828 for fringe update if it has periodic bitmap.
ac389d0c 13829 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
13830 and fringe_bitmap_periodic_p.
13831
13832 * fringe.c (get_fringe_bitmap_data): New function.
13833 (draw_fringe_bitmap_1, update_window_fringes): Use it.
13834 (update_window_fringes): Record periodicity of fringe bitmap in glyph
13835 row. Mark glyph row for fringe update if periodicity changed.
13836
13837 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
13838 for fringe update unless it has periodic bitmap.
13839
f16d9837
KH
138402011-05-25 Kenichi Handa <handa@m17n.org>
13841
13842 * xdisp.c (get_next_display_element): Set correct it->face_id for
13843 a static composition.
13844
e1b90ef6
LL
138452011-05-24 Leo Liu <sdl.web@gmail.com>
13846
13847 * deps.mk (fns.o):
13848 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
13849
13850 * fns.c (crypto_hash_function, Fsha1): New function.
13851 (Fmd5): Use crypto_hash_function.
13852 (syms_of_fns): Add Ssha1.
13853
7400048f
PE
138542011-05-22 Paul Eggert <eggert@cs.ucla.edu>
13855
13856 * gnutls.c: Remove unused macros.
13857 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
13858 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
13859 Remove macros that are defined and never used.
13860 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
13861
abb71cf4
CY
138622011-05-22 Chong Yidong <cyd@stupidchicken.com>
13863
13864 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
13865 (Fx_get_selection_internal): Minor cleanup.
13866 (Fx_own_selection_internal): Rename arguments for consistency with
13867 select.el.
13868
6307db39
PE
138692011-05-22 Paul Eggert <eggert@cs.ucla.edu>
13870
13871 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
13872
f3d4e0a4
CY
138732011-05-22 Chong Yidong <cyd@stupidchicken.com>
13874
13875 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
13876
4d8ade89
YM
138772011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
13878
13879 * dispnew.c (scrolling_window): Don't exclude the case that the
13880 last enabled row in the desired matrix touches the bottom boundary.
13881
32078c8d
GM
138822011-05-21 Glenn Morris <rgm@gnu.org>
13883
13884 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
13885 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
13886 and add some more files.
32078c8d 13887
7285dc67
EZ
138882011-05-20 Eli Zaretskii <eliz@gnu.org>
13889
13890 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
13891 report_file_error introduced by the change from 2011-05-07.
13892
89d1bd22
PE
138932011-05-20 Paul Eggert <eggert@cs.ucla.edu>
13894
13895 * systime.h (Time): Define only if emacs is defined.
13896 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
13897 where the include path doesn't have X11/X.h by default. See
13898 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
13899
cd394be1 139002011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
13901
13902 * composite.c (find_automatic_composition): Fix previous change.
13903
b9704ad9
GM
139042011-05-20 Glenn Morris <rgm@gnu.org>
13905
13906 * lisp.mk: New file, split from Makefile.in.
13907 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
13908 (shortlisp): Remove.
13909 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
13910
4a720484
GM
139112011-05-19 Glenn Morris <rgm@gnu.org>
13912
13913 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
13914 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
13915 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
13916 (lisp): Set the order to that of loadup.el.
13917 (shortlisp): Make it a copy of $lisp.
13918 (SOME_MACHINE_LISP): Remove.
13919 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
13920 Use just $shortlisp, not $SOME_MACHINE_LISP too.
13921
a28d4396
KH
139222011-05-18 Kenichi Handa <handa@m17n.org>
13923
13924 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
13925 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
13926 (find_automatic_composition): Mostly rewrite for efficiency.
13927
a2b1fa8e
JB
139282011-05-18 Juanma Barranquero <lekktu@gmail.com>
13929
13930 * makefile.w32-in: Update dependencies.
13931
8e1f5610
CS
139322011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
13933
13934 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 13935 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 13936
7025ee00 139372011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 13938
cdfa6eab
PE
13939 Fix some integer overflow issues, such as string length overflow.
13940
06d6db33
PE
13941 * insdel.c (count_size_as_multibyte): Check for string overflow.
13942
2b4560a8
PE
13943 * character.c (lisp_string_width): Check for string overflow.
13944 Use EMACS_INT, not int, for string indexes and lengths; in
13945 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
13946 the resulting string length overflows an EMACS_INT; instead,
13947 report a string overflow if no precision given. When checking for
13948 precision exhaustion, use a check that cannot possibly have
13949 integer overflow. (Bug#8675)
13950 * character.h (lisp_string_width): Adjust to new signature.
13951
cb93f9be
PE
13952 * alloc.c (string_overflow): New function.
13953 (Fmake_string): Use it. This doesn't change behavior, but saves
13954 a few bytes and will simplify future changes.
13955 * character.c (string_escape_byte8): Likewise.
13956 * lisp.h (string_overflow): New decl.
13957
1a1f3366
PE
13958 Fixups, following up to the user-interface timestamp change.
13959 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
13960 for UI timestamps, instead of unsigned long.
9fbd6841
PE
13961 * msdos.c (mouse_get_pos): Likewise.
13962 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
13963 * w32gui.h (Time): Define by including "systime.h" rather than by
13964 declaring it ourselves. (Bug#8664)
13965
d4e3e4d3
PE
13966 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
13967 * image.c (clear_image_cache): Likewise.
13968
f6a24d19
PE
13969 * term.c (term_mouse_position): Don't assume time_t wraparound.
13970
08dc5ae6
PE
13971 Be more systematic about user-interface timestamps.
13972 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
13973 and sometimes 'EMACS_UINT', to represent these timestamps.
13974 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
13975 This makes the code easier to follow, and makes it easier to catch
13976 integer overflow bugs such as Bug#8664.
13977 * frame.c (Fmouse_position, Fmouse_pixel_position):
13978 Use Time, not unsigned long, for user-interface timestamps.
13979 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
13980 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
13981 * keyboard.h (last_event_timestamp): Likewise.
13982 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
13983 * menu.h (xmenu_show): Likewise.
13984 * term.c (term_mouse_position): Likewise.
13985 * termhooks.h (struct input_event.timestamp): Likewise.
13986 (struct terminal.mouse_position_hook): Likewise.
13987 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
13988 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
13989 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
13990 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
13991 what it was before.
13992 * menu.h, termhooks.h: Include "systime.h", for Time.
13993
8e55734a
PE
13994 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
13995 Don't assume that the difference between two unsigned long values
13996 can fit into an integer. At this point, we know button_down_time
13997 <= event->timestamp, so the difference must be nonnegative, so
13998 there's no need to cast the result if double-click-time is
13999 nonnegative, as it should be; check that it's nonnegative, just in
14000 case. This bug is triggered when events are more than 2**31 ms
86db42d2 14001 apart (about 25 days). (Bug#8664)
8e55734a 14002
841f1b75 14003 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 14004 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 14005
3e26f69c
PE
14006 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
14007 that always fit in int. Use a sentinel instead of a counter, to
14008 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
14009 * frame.h (struct frame): Use int for menu_bar_items_used
14010 instead of EMACS_INT, since it always fits in int.
3e26f69c 14011
5cc152c0
PE
14012 * menu.c (grow_menu_items): Check for int overflow.
14013
d89eb65e
PE
14014 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
14015
5235bd3e
PE
14016 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
14017 Before, the code was not consistent. These values cannot exceed
14018 2**31 - 1 so there's no need to make them unsigned.
14019 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
14020 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
14021 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
14022 as modifiers.
14023 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
14024
bc827e23
PE
14025 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
14026 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
14027 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
14028 presumably because the widths might not match.
14029
78eb494e
PE
14030 * window.c (size_window): Avoid needless test at loop start.
14031
04f2d78b
CB
140322011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
14033
14034 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
14035
d2fc7e3d 140362011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
14037
14038 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
14039
d2fc7e3d 140402011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
14041
14042 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
14043 `width' to `bar_area_x' and `bar_area_width', respectively.
14044 (x_scroll_run): Take account of fringe background extension.
14045
04f2d78b
CB
14046 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
14047 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
14048 `bar_area_width', respectively.
14049 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
14050 background extension.
14051
79b70037
GM
140522011-05-10 Jim Meyering <meyering@redhat.com>
14053
14054 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
14055
2f142cc5
JB
140562011-05-10 Juanma Barranquero <lekktu@gmail.com>
14057
14058 * image.c (Finit_image_library): Return t for built-in image types,
14059 like pbm and xbm. (Bug#8640)
14060
57679c86
AS
140612011-05-09 Andreas Schwab <schwab@linux-m68k.org>
14062
14063 * w32menu.c (set_frame_menubar): Fix submenu allocation.
14064
888c9e86
EZ
140652011-05-07 Eli Zaretskii <eliz@gnu.org>
14066
b0512a1d
EZ
14067 * w32console.c (Fset_screen_color): Doc fix.
14068 (Fget_screen_color): New function.
14069 (syms_of_ntterm): Defsubr it.
14070
7285dc67
EZ
14071 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
14072 unlink the temporary file if Fcall_process didn't create it in the
14073 first place.
14074 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
14075 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
14076 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
14077 cue to call_process_cleanup not to close that handle.
14078
4d3fcc8e
BK
140792011-05-07 Ben Key <bkey76@gmail.com>
14080
14081 * makefile.w32-in: The bootstrap-temacs rule now makes use of
14082 one of two shell specific rules, either bootstrap-temacs-CMD or
14083 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
14084 to the previous implementation of the bootstrap-temacs rule.
14085 The bootstrap-temacs-CMD rule is similar to the previous
14086 implementation of the bootstrap-temacs rule except that it
14087 makes use of the ESC_CFLAGS variable instead of the CFLAGS
14088 variable.
14089
14090 These changes, along with some changes to nt/configure.bat,
14091 nt/gmake.defs, and nt/nmake.defs, are required to extend my
14092 earlier fix to add support for --cflags and --ldflags options
14093 that include quotes so that it works whether make uses cmd or
14094 sh as the shell.
14095
b4289b64
MA
140962011-05-06 Michael Albinus <michael.albinus@gmx.de>
14097
14098 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
14099 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
14100 is a constant.
14101 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
14102 a string. Handle both cases.
14103 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
14104 (Fdbus_register_method): Use Qinvalid_function.
14105
af4c0e28
JB
141062011-05-06 Juanma Barranquero <lekktu@gmail.com>
14107
14108 * makefile.w32-in: Update dependencies.
14109 (LISP_H): Add inttypes.h and stdin.h.
14110 (PROCESS_H): Add unistd.h.
14111
c51453d9
EZ
141122011-05-06 Eli Zaretskii <eliz@gnu.org>
14113
14114 * lread.c: Include limits.h (fixes the MS-Windows build broken by
14115 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
14116
8ff0ac3c 141172011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 14118
4c4b566b
PE
14119 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
14120
aab2b9b5
PE
14121 * term.c (vfatal): Remove stray call to va_end.
14122 It's not needed and the C Standard doesn't allow it here anyway.
14123
c378da0b
PE
14124 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
14125 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
14126
288b08c7
PE
14127 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
14128 bytes.
14129
e3601888
PE
14130 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
14131
db6c0e74
PE
14132 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
14133
dd5963ea
PE
14134 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
14135
88c9450f
PE
14136 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
14137
2f9442b8
PE
14138 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
14139
c032b5f8
PE
14140 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
14141 * charset.c (Fdefine_charset_internal): Don't initialize
14142 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 14143 32-bit int (Bug#8600).
a108c10b
PE
14144
14145 * lread.c (read_integer): Be more consistent with string-to-number.
14146 Use string_to_number to do the actual conversion; this avoids
14147 rounding errors and fixes some other screwups. Without this fix,
14148 for example, #x1fffffffffffffff was misread as -2305843009213693952.
14149 (digit_to_number): Move earlier, for benefit of read_integer.
14150 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 14151 not a digit in any supported base. (Bug#8602)
a108c10b 14152
ad5f9eea
PE
14153 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
14154
aec1708a
PE
14155 * dispnew.c (scrolling_window): Return 1 if we scrolled,
14156 to match comment at start of function. This also removes a
14157 GCC warning about overflow in a 32+64-bit port.
14158
47be4ab5
PE
14159 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
14160
371cac43
PE
14161 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
14162 Reported by Stefan Monnier in
14163 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
14164 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
14165 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 14166
d01a7826
PE
14167 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
14168 (EMACS_UINTPTR): Likewise, with uintptr_t.
14169
7fd47d5c
PE
14170 * lisp.h: Prefer 64-bit EMACS_INT if available.
14171 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
14172 on 32-bit hosts that have 64-bit int, so that they can access
14173 large files.
122b0c86
PE
14174 However, temporarily disable this change unless the temporary
14175 symbol WIDE_EMACS_INT is defined.
7fd47d5c 14176
8727937b
PE
14177 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
14178
8ac068ac
PE
14179 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
14180 This removes an assumption that EMACS_INT and long are the same
14181 width as pointers. The assumption is true for Emacs porting targets
14182 now, but we want to make other targets possible.
14183 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
14184 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
14185 In the rest of the code, change types of integers that hold casted
14186 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
14187 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
14188 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
14189 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
14190 No need to cast type when ORing.
14191 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
14192 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
14193 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
14194 assume EMACS_INT is the same width as char *.
14195 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
14196 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
14197 Remove no-longer-needed casts.
14198 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
14199 (xg_tool_bar_help_callback, xg_make_tool_item):
14200 Use EMACS_INTPTR to hold an integer
14201 that will be cast to void *; this can avoid a GCC warning
14202 if EMACS_INT is not the same width as void *.
14203 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
14204 * xdisp.c (display_echo_area_1, resize_mini_window_1):
14205 (current_message_1, set_message_1):
14206 Use a local to convert to proper width without a cast.
14207 * xmenu.c (dialog_selection_callback): Likewise.
14208
ede49d71
PE
14209 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
14210 Also, don't assume VALBITS / RAND_BITS is less than 5,
14211 and don't rely on undefined behavior when shifting a 1 left into
14212 the sign bit.
14213 * lisp.h (get_random): Change signature to match.
14214
2f30ecd0
PE
14215 * lread.c (hash_string): Use size_t, not int, for hash computation.
14216 Normally we prefer signed values; but hashing is special, because
14217 it's better to use unsigned division on hash table sizes so that
14218 the remainder is nonnegative. Also, size_t is the natural width
14219 for hashing into memory. The previous code used 'int', which doesn't
14220 retain enough info to hash well into very large tables.
14221 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
14222
2a866e7b
PE
14223 * dbusbind.c: Don't possibly lose pointer info when converting.
14224 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
14225 Use XPNTR rather than XHASH, so that the high-order bits of
14226 the pointer aren't lost when converting through void *.
14227
51639eac
PE
14228 * eval.c (Fautoload): Don't double-shift a pointer.
14229
92394119
PE
14230 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
14231
dbdb9a7c
JB
142322011-05-06 Juanma Barranquero <lekktu@gmail.com>
14233
14234 * gnutls.c (DEF_GNUTLS_FN):
14235 * image.c (DEF_IMGLIB_FN): Make function pointers static.
14236
db7a0b4f
AS
142372011-05-05 Andreas Schwab <schwab@linux-m68k.org>
14238
14239 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
14240 marker. (Bug#8610)
14241
cd394be1 142422011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
14243
14244 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
14245 New version that can reserve upto 2GB of heap space.
14246
f7ff1b0f 142472011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
14248
14249 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
14250
639c109b
TZ
142512011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
14252
14253 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
14254 `gnutls_certificate_set_x509_key_file'.
14255
d2127135
JB
142562011-05-05 Juanma Barranquero <lekktu@gmail.com>
14257
14258 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
14259 Update dependencies.
14260
e968f4f3
JB
142612011-05-04 Juanma Barranquero <lekktu@gmail.com>
14262
14263 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
14264 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
14265 Remove unused parameter `fildes'.
14266 * process.c (read_process_output, send_process): Don't pass it.
14267
84d358f0
JB
142682011-05-04 Juanma Barranquero <lekktu@gmail.com>
14269
14270 Fix previous change: the library cache is defined in w32.c.
14271 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
14272 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
14273
0898ca10
JB
142742011-05-04 Juanma Barranquero <lekktu@gmail.com>
14275
14276 Implement dynamic loading of GnuTLS on Windows.
14277
14278 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
14279 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
14280 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
14281 Declare.
14282
14283 * gnutls.c (Qgnutls_dll): Define.
14284 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
14285 (gnutls_*): Declare function pointers.
14286 (init_gnutls_functions): New function to initialize function pointers.
14287 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
14288 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
14289 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
14290 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
14291 (emacs_gnutls_write, emacs_gnutls_read)
14292 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
14293 (Fgnutls_available_p): New function.
14294 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
14295 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
14296 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
14297
14298 * image.c: Include w32.h.
14299 (Vimage_type_cache): Delete.
14300 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
14301 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
14302 (w32_delayed_load): Move to w32.c.
14303
14304 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
14305
14306 * w32.c (QCloaded_from, Vlibrary_cache): Define.
14307 (w32_delayed_load): Move from image.c. When loading a library, record
14308 its filename in the :loaded-from property of the library id.
14309 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
14310 Initialize and staticpro them.
14311 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
14312
14313 * process.c: Include lisp.h before w32.h, not after.
14314 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
14315 instead of gnutls_record_check_pending.
14316
14317 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
14318
ff4de4aa
TZ
143192011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
14320
14321 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
14322 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
14323 as passed in.
14324
abe95abb
JD
143252011-05-03 Jan Djärv <jan.h.d@swipnet.se>
14326
14327 * xterm.c (x_set_frame_alpha): Do not set property on anything
14328 else than FRAME_X_OUTER_WINDOW (Bug#8608).
14329
e16e55d4
JB
143302011-05-02 Juanma Barranquero <lekktu@gmail.com>
14331
14332 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
14333
bafcf6a5
JB
143342011-05-02 Juanma Barranquero <lekktu@gmail.com>
14335
14336 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
14337 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
14338 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
14339 (gnutls_global_initialized, Qgnutls_bootprop_priority)
14340 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
14341 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
14342 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
14343 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
14344 (Qgnutls_bootprop_callbacks_verify): Make static.
14345
e7a6747f
AS
143462011-05-01 Andreas Schwab <schwab@linux-m68k.org>
14347
19ed11ba
AS
14348 * callproc.c: Indentation fixup.
14349
e7a6747f 14350 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
14351 (wait_for_termination, interruptible_wait_for_termination):
14352 Move after wait_for_termination_1.
e7a6747f 14353
1ef14cb4
LMI
143542011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
14355
14356 * sysdep.c (interruptible_wait_for_termination): New function
14357 which is like wait_for_termination, but allows keyboard
14358 interruptions.
14359
14360 * callproc.c (Fcall_process): Add (:file "file") as an option for
14361 the STDOUT buffer.
14362 (Fcall_process_region): Ditto.
14363
330d880c
EZ
143642011-04-30 Eli Zaretskii <eliz@gnu.org>
14365
8db90b73
EZ
14366 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
14367 rather than `XVECTOR (FOO)->size'.
14368
330d880c
EZ
14369 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
14370 inttypes.h, as a gnulib replacement is used if it not available in
14371 system headers.
14372
15cbd324
EZ
143732011-04-21 Eli Zaretskii <eliz@gnu.org>
14374
14375 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
14376 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
14377 of MOST_POSITIVE_FIXNUM. (Bug#8528)
14378
14379 * coding.c (coding_alloc_by_realloc): Error out if destination
14380 will grow beyond MOST_POSITIVE_FIXNUM.
14381 (decode_coding_emacs_mule): Abort if there isn't enough place in
14382 charbuf for the composition carryover bytes. Reserve an extra
14383 space for up to 2 characters produced in a loop.
14384 (decode_coding_iso_2022): Abort if there isn't enough place in
14385 charbuf for the composition carryover bytes.
14386
143872011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 14388
ae940cca
EZ
14389 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
14390 aborting when %lld or %lll format is passed.
14391 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
14392 %llo or %llx format is passed. (Bug#8545)
14393
03ab8921
EZ
14394 * window.c (window_scroll_line_based): Use a marker instead of
14395 simple variables to record original value of point. (Bug#7952)
14396
afda1437
EZ
14397 * doprnt.c (doprnt): Fix the case where a multibyte sequence
14398 produced by %s or %c overflows available buffer space. (Bug#8545)
14399
f76dee0c
PE
144002011-04-28 Paul Eggert <eggert@cs.ucla.edu>
14401
14402 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 14403 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 14404
fdc5744d
JB
144052011-04-28 Juanma Barranquero <lekktu@gmail.com>
14406
14407 * w32.c (init_environment): Warn about defaulting HOME to C:\.
14408
638f053a
JB
144092011-04-28 Juanma Barranquero <lekktu@gmail.com>
14410
14411 * keyboard.c (Qdelayed_warnings_hook): Define.
14412 (command_loop_1): Run `delayed-warnings-hook'
14413 if Vdelayed_warnings_list is non-nil.
14414 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
14415 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
14416
d178f871
EZ
144172011-04-28 Eli Zaretskii <eliz@gnu.org>
14418
14419 * doprnt.c (doprnt): Don't return value smaller than the buffer
14420 size if the message was truncated. (Bug#8545).
14421
b124fd93
JB
144222011-04-28 Juanma Barranquero <lekktu@gmail.com>
14423
14424 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
14425 (Fx_window_property): #if-0 the whole functions, not just the bodies.
14426
e810457d
PE
144272011-04-27 Paul Eggert <eggert@cs.ucla.edu>
14428
14429 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
14430
ea51cceb
JB
144312011-04-27 Juanma Barranquero <lekktu@gmail.com>
14432
14433 * makefile.w32-in: Update dependencies.
14434
94dcfacf
EZ
144352011-04-27 Eli Zaretskii <eliz@gnu.org>
14436
14437 Improve `doprnt' and its usage. (Bug#8545)
14438 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
14439 `format_end'. Remove support for %l as a conversion specifier.
14440 Don't use xrealloc. Improve diagnostics when the %l size modifier
14441 is used. Update the commentary.
14442
14443 * eval.c (verror): Simplify calculation of size_t.
14444
14445 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
14446 messages.
14447
f61f41d7
PE
144482011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
14449
14450 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
14451 change.
14452
96fb4434
PE
144532011-04-27 Paul Eggert <eggert@cs.ucla.edu>
14454
14455 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
14456 This makes this file independent of the recent pseudovector change.
14457
671875da 144582011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 14459
69e9b5a3
PE
14460 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
14461
b5f869a7 14462 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 14463 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 14464 Remove unused local.
c8926152 14465 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 14466
841a1577 14467 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
14468 GCC 4.6.0 optimizes based on type-based alias analysis.
14469 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
14470 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
14471 != &v->size, and therefore "v->size = 1; b->size = 2; return
14472 v->size;" must therefore return 1. This assumption is incorrect
14473 for Emacs, since it type-puns struct Lisp_Vector * with many other
14474 types. To fix this problem, this patch adds a new type struct
f904488f 14475 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
14476 and pseudovectors, and helps optimizing compilers not get fooled
14477 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
14478 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
14479 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
14480 the size member.
eab3844f
PE
14481 (XSETPVECTYPE): Rewrite in terms of new macro.
14482 (XSETPVECTYPESIZE): New macro, specifying both type and size.
14483 This is a bit clearer, and further avoids the possibility of
14484 undesirable aliasing.
14485 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 14486 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
14487 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
14488 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
14489 (ASIZE): Now uses header.size rather than size.
14490 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
14491 to avoid the hassle of writing XVECTOR (foo)->header.size.
14492 (struct vectorlike_header): New type.
eab3844f
PE
14493 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
14494 object, to help avoid aliasing.
14495 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
14496 (SUBRP): Likewise, since Lisp_Subr is a special case.
14497 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
14498 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
14499 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 14500 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
14501 changed to be "header.size" and "header.next".
14502 * buffer.h (struct buffer): Likewise.
14503 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
14504 * frame.h (struct frame): Likewise.
14505 * process.h (struct Lisp_Process): Likewise.
14506 * termhooks.h (struct terminal): Likewise.
14507 * window.c (struct save_window_data, struct saved_window): Likewise.
14508 * window.h (struct window): Likewise.
14509 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
14510 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
14511 * buffer.c (init_buffer_once): Likewise.
14512 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
14513 special case.
14514 * process.c (Fformat_network_address): Use local var for size,
14515 for brevity.
14516
0df1eac5
PE
14517 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
14518
847ab9d1 14519 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
14520 * data.c (atof): Remove decl; no longer used or needed.
14521 (digit_to_number): Move to lread.c.
14522 (Fstring_to_number): Use new string_to_number function, to be
14523 consistent with how the Lisp reader treats infinities and NaNs.
14524 Do not assume that floating-point numbers represent EMACS_INT
14525 without losing information; this is not true on most 64-bit hosts.
14526 Avoid double-rounding errors, by insisting on integers when
14527 parsing non-base-10 numbers, as the documentation specifies.
14528 * lisp.h (string_to_number): New decl, replacing ...
14529 (isfloat_string): Remove.
bc0a5c13 14530 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 14531 (read1): Do not accept +. and -. as integers; this
452f4150
PE
14532 appears to have been a coding error. Similarly, do not accept
14533 strings like +-1e0 as floating point numbers. Do not report
14534 overflow for integer overflows unless the base is not 10 which
14535 means we have no simple and reliable way to continue.
14536 Break out the floating-point parsing into a new
14537 function string_to_number, so that Fstring_to_number parses
14538 floating point numbers consistently with the Lisp reader.
04f2d78b 14539 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
14540 (E_CHAR, EXP_INT): Remove, replacing with ...
14541 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
14542 (string_to_number): New function, replacing isfloat_string.
14543 This function checks for valid syntax and produces the resulting
14544 Lisp float number too. Rework it so that string-to-number
bc0a5c13 14545 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
14546 so that overflow for non-base-10 numbers is reported only when
14547 there's no portable and simple way to convert to floating point.
452f4150 14548
67769ffc
PE
14549 * textprop.c (set_text_properties_1): Rewrite for clarity,
14550 and to avoid GCC warning about integer overflow.
14551
c20db43f
PE
14552 * intervals.h (struct interval): Use EMACS_INT for members
14553 where EMACS_UINT might cause problems. See
14554 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
14555 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
14556 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
14557 All uses changed.
37aa2f85
PE
14558 (offset_intervals): Tell GCC not to worry about length overflow
14559 when negating a negative length.
c20db43f 14560
2538aa2f
PE
14561 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
14562 (overrun_check_free): Likewise.
14563
f2d3008d
PE
14564 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
14565 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
14566 word size.
14567
ec8df744
PE
14568 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
14569 (gnutls_make_error): Rename local to avoid shadowing.
14570 (gnutls_emacs_global_deinit): ifdef out; not used.
14571 (Fgnutls_boot): Use const for pointer to readonly storage.
14572 Comment out unused local. Fix pointer signedness problems.
14573
640ee02d
PE
14574 * lread.c (openp): Don't stuff size_t into an 'int'.
14575 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
14576 about possible signed overflow.
14577
6048fb2a
PE
14578 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
14579 (GDK_KEY_g): Don't define if already defined.
14580 (xg_prepare_tooltip): Avoid pointer signedness problem.
14581 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
14582
fa3c87e1
PE
14583 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
14584 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
14585
2172544b
PE
14586 * xfns.c (Fx_window_property): Simplify a bit,
14587 to make a bit faster and to avoid GCC 4.6.0 warning.
14588 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
14589
9b821a21
PE
14590 * fns.c (internal_equal): Don't assume size_t fits in int.
14591
3c616cfa
PE
14592 * alloc.c (compact_small_strings): Tighten assertion a little.
14593
c2982e87
PE
14594 Replace pEd with more-general pI, and fix some printf arg casts.
14595 * lisp.h (pI): New macro, generalizing old pEd macro to other
14596 conversion specifiers. For example, use "...%"pI"d..." rather
14597 than "...%"pEd"...".
14598 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 14599 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
14600 * alloc.c (check_pure_size): Don't overflow by converting size to int.
14601 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
14602 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
14603 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
14604 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
14605 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
14606 64-bit hosts.
14607 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
14608 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
14609 * print.c (safe_debug_print, print_object): Likewise.
14610 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
14611 to int.
6f04d126
PE
14612 Use pI instead of if-then-else-abort. Use %p to avoid casts,
14613 avoiding the 0 flag, which is not portable.
c2982e87
PE
14614 * process.c (Fmake_network_process): Use pI to avoid cast.
14615 * region-cache.c (pp_cache): Likewise.
14616 * xdisp.c (decode_mode_spec): Likewise.
14617 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
14618 behavior on 64-bit hosts with printf arg.
6f04d126 14619 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
14620 (x_stop_queuing_selection_requests): Likewise.
14621 (x_get_window_property): Don't truncate byte count to an 'int'
14622 when tracing.
0b432f21 14623
5e073ec7
PE
14624 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
14625 here, since it parses constructs like leading '-' and spaces,
14626 which are not wanted; and it overflows with large numbers.
14627 Instead, simply match F[0-9]+, which is what is wanted anyway.
14628
36372bf9
PE
14629 * alloc.c: Remove unportable assumptions about struct layout.
14630 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
14631 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
14632 (allocate_vectorlike, make_pure_vector): Use the new macros,
14633 plus offsetof, to remove unportable assumptions about struct layout.
14634 These assumptions hold on all porting targets that I know of, but
14635 they are not guaranteed, they're easy to remove, and removing them
14636 makes further changes easier.
14637
0b432f21
PE
14638 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
14639 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
14640 (string_overrun_cookie): Now const. Use initializers that
14641 don't formally overflow signed char, to avoid warnings.
000098c1
PE
14642 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
14643 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
14644 (allocate_buffer): Don't assume sizeof (struct buffer) is a
14645 multiple of sizeof (EMACS_INT); it need not be, if
14646 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 14647 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 14648
895009e1
JB
146492011-04-26 Juanma Barranquero <lekktu@gmail.com>
14650
14651 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
14652
6a7a1b0b
TZ
146532011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
14654
14655 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 14656 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
14657 Reported by Paul Eggert <eggert@cs.ucla.edu>.
14658
841a1577 146592011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
14660
14661 * lisp.h (Qdebug): List symbol.
895009e1 14662 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
14663 * keyboard.c (debug-on-event): New variable.
14664 (handle_user_signal): Break into debugger when debug-on-event
14665 matches the current signal symbol.
14666
f2d3ba6f
DN
146672011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
14668
14669 * alloc.c (check_sblock, check_string_bytes)
14670 (check_string_free_list): Convert to standard C.
14671
42ce4c63
TZ
146722011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
14673
14674 * w32.c (emacs_gnutls_push): Fix typo.
14675
825cd63c
EZ
146762011-04-25 Eli Zaretskii <eliz@gnu.org>
14677
fb11d64d
EZ
14678 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
14679 "cast to pointer from integer of different size".
14680
825cd63c
EZ
14681 Improve doprnt and its use in verror. (Bug#8545)
14682 * doprnt.c (doprnt): Document the set of format control sequences
14683 supported by the function. Use SAFE_ALLOCA instead of always
14684 using `alloca'.
14685
14686 * eval.c (verror): Don't limit the buffer size at size_max-1, that
14687 is one byte too soon. Don't use xrealloc; instead xfree and
14688 xmalloc anew.
14689
e061a11b
TZ
146902011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
14691
14692 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
14693 callbacks stage.
14694
14695 * gnutls.c: Renamed global_initialized to
14696 gnutls_global_initialized. Added internals for the
14697 :verify-hostname-error, :verify-error, and :verify-flags
14698 parameters of `gnutls-boot' and documented those parameters in the
14699 docstring. Start callback support.
9173deec
JB
14700 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
14701 unless a fatal error occurred. Call gnutls_alert_send_appropriate
14702 on error. Return error code.
e061a11b
TZ
14703 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
14704 (emacs_gnutls_read): Likewise.
14705 (Fgnutls_boot): Return handshake error code.
14706 (emacs_gnutls_handle_error): New function.
14707 (wsaerror_to_errno): Likewise.
14708
14709 * w32.h (emacs_gnutls_pull): Add prototype.
14710 (emacs_gnutls_push): Likewise.
14711
14712 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
14713 (emacs_gnutls_push): Likewise.
14714
147152011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
14716
14717 * process.c (wait_reading_process_output): Check if GnuTLS
14718 buffered some data internally if no FDs are set for TLS
14719 connections.
14720
14721 * makefile.w32-in (OBJ2): Add gnutls.$(O).
14722 (LIBS): Link to USER_LIBS.
14723 ($(BLD)/gnutls.$(0)): New target.
14724
fa6996bc
EZ
147252011-04-24 Eli Zaretskii <eliz@gnu.org>
14726
eb35682e
EZ
14727 * xdisp.c (handle_single_display_spec): Rename the
14728 display_replaced_before_p argument into display_replaced_p, to
14729 make it consistent with the commentary. Fix typos in the
14730 commentary.
14731
e2ad650c
EZ
14732 * textprop.c (syms_of_textprop): Remove dead code.
14733 (copy_text_properties): Delete obsolete commentary about an
14734 interface that was deleted long ago. Fix typos in the description
14735 of arguments.
14736
1b2de274
EZ
14737 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
14738 to changes in oldXMenu/XMenu.h from 2011-04-16.
14739 <menu_help_message, prev_menu_help_message>: Constify.
14740 (IT_menu_make_room): menu->help_text is now `const char **';
14741 adjust.
14742
14743 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
14744 to changes in oldXMenu/XMenu.h from 2011-04-16.
14745 (struct XMenu): Declare `help_text' `const char **'.
14746
14747 * xfaces.c <Qunspecified>: Make extern again.
14748
14749 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 14750 required by POSIX.
1b2de274 14751
762b15be
EZ
14752 * doc.c (get_doc_string): Improve the format passed to `error'.
14753
14754 * doprnt.c (doprnt): Improve commentary.
14755
14756 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
14757
14758 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
14759 them with etags.
14760
f1052e5d
EZ
14761 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
14762 changes in globals.h immediately force recompilation.
762b15be
EZ
14763 (TAGS): Depend on $(CURDIR)/m/intel386.h and
14764 $(CURDIR)/s/ms-w32.h.
14765 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 14766
fa6996bc
EZ
14767 * character.c (Fchar_direction): Function deleted.
14768 (syms_of_character): Don't defsubr it.
14769 <char-direction-table>: Deleted.
14770
e6c3da20
EZ
147712011-04-23 Eli Zaretskii <eliz@gnu.org>
14772
14773 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
14774 * doprnt.c: Include limits.h.
14775 (SIZE_MAX): New macro.
04f2d78b
CB
14776 (doprnt): Return a size_t value. 2nd arg is now size_t.
14777 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
14778 Improve overflow protection. Support `l' modifier for integer
14779 conversions. Support %l conversion. Don't assume an EMACS_INT
14780 argument for integer conversions and for %c.
14781
14782 * lisp.h (doprnt): Restore prototype.
14783
14784 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
14785 $(SRC)/character.h.
14786
14787 * Makefile.in (base_obj): Add back doprnt.o.
14788
14789 * deps.mk (doprnt.o): Add back prerequisites.
14790 (callint.o): Depend on character.h.
14791
14792 * eval.c (internal_lisp_condition_case): Include the handler
14793 representation in the error message.
14794 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
14795 when breaking from the loop.
14796
14797 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
14798
14799 * callint.c (Fcall_interactively): When displaying error message
14800 about invalid control letter, pass the character's codepoint, not
14801 a pointer to its multibyte form. Improve display of the character
14802 in octal and display also its hex code.
14803
14804 * character.c (char_string): Use %x to display the (unsigned)
14805 codepoint of an invalid character, to avoid displaying a bogus
14806 negative value.
14807
14808 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
14809 `error', not SYMBOL_NAME itself.
14810
14811 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
14812 character arguments to `error'.
14813
14814 * charset.c (check_iso_charset_parameter): Fix incorrect argument
14815 to `error' in error message about FINAL_CHAR argument. Make sure
14816 FINAL_CHAR is a character, and use %c when it is passed as
14817 argument to `error'.
14818
4ffd0d6b 148192011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
14820
14821 * s/ms-w32.h (localtime): Redirect to sys_localtime.
14822
14823 * w32.c: Include <time.h>.
14824 (sys_localtime): New function.
14825
4ffd0d6b 148262011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
14827
14828 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
14829
4ffd0d6b 14830 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 14831
4ffd0d6b 148322011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 14833
4ffd0d6b
GM
14834 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
14835 zombies (Bug#8467).
aac0c6e3 14836
04c56954
EZ
148372011-04-19 Eli Zaretskii <eliz@gnu.org>
14838
14839 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
14840 gl_state.e_property when gl_state.object is Qt.
14841
14842 * insdel.c (make_gap_larger): Remove limitation of buffer size
14843 to <= INT_MAX.
14844
16a43933
CY
148452011-04-18 Chong Yidong <cyd@stupidchicken.com>
14846
14847 * xdisp.c (lookup_glyphless_char_display)
14848 (produce_glyphless_glyph): Handle cons cell entry in
14849 glyphless-char-display.
14850 (Vglyphless_char_display): Document it.
14851
14852 * term.c (produce_glyphless_glyph): Handle cons cell entry in
14853 glyphless-char-display.
14854
4581706e
CY
148552011-04-17 Chong Yidong <cyd@stupidchicken.com>
14856
14857 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
14858
14859 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
14860
14861 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
14862 definition for no-X builds.
14863
4887c6e2 148642011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 14865
fd35b6f9
PE
14866 Static checks with GCC 4.6.0 and non-default toolkits.
14867
5c1ccb01
PE
14868 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
14869
006c5daa
PE
14870 * process.c (keyboard_bit_set): Define only if SIGIO.
14871 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
14872 (send_process): Repair possible setjmp clobbering.
14873
efc736d3
PE
14874 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
14875
4e2fe2e6
PE
14876 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
14877
f97334a2
PE
14878 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
14879
4e75f29d
PE
14880 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
14881 Define only if needed.
14882
90efadd1
PE
14883 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
14884 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 14885 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 14886
3c647824
PE
14887 * dispextern.h (struct redisplay_interface): Rename param
14888 to avoid shadowing.
e264f262 14889 * termhooks.h (struct terminal): Likewise.
761383f4 14890 * xterm.c (xembed_send_message): Likewise.
3c647824 14891
b58c5c4a
PE
14892 * insdel.c (make_gap_smaller): Define only if
14893 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
14894
cad59032
PE
14895 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
14896 it.
14897
c339dc2e
PE
14898 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
14899 so that we aren't warned about unused symbols.
14900
91a3e27b
PE
14901 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
14902
399c71d3 14903 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 14904
8ffc96f5
PE
14905 * xfns.c (x_real_positions): Mark locals as initialized.
14906
eef9bc79
PE
14907 * xmenu.c (xmenu_show): Don't use uninitialized vars.
14908
098db9dd
PE
14909 * xterm.c: Fix problems found by static analysis with other toolkits.
14910 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
14911 (x_dispatch_event): Declare static if USE_GTK, and
14912 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 14913 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 14914 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
14915 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
14916 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 14917
eb18f6cc
PE
14918 * xmenu.c (menu_help_callback): Pointer type fixes.
14919 Use const pointers when pointing at readonly data. Avoid pointer
14920 signedness clashes.
14921 (FALSE): Remove unused macro.
14922 (update_frame_menubar): Remove unused decl.
14923
1fe72bf8
PE
14924 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
14925
60d9e1db
PE
14926 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
14927 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
14928 (single_menu_item): Rename local to avoid shadowing.
14929
39261c26
PE
14930 * keyboard.c (make_lispy_event): Remove unused local var.
14931
018c5e19
PE
14932 * frame.c, frame.h (x_get_resource_string): Bring this back, but
14933 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
14934
63d2b86e
PE
14935 * bitmaps: Change bitmaps from unsigned char back to the X11
14936 compatible char. Avoid the old compiler warnings about
14937 out-of-range initializers by using, for example, '\xab' rather
14938 than 0xab.
14939
aefd87e1
PE
14940 * xgselect.c (xgselect_initialize): Check vs interface
14941 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
14942
bf501fb9
PE
14943 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
14944
e9829fdf
PE
14945 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
14946 to read-only memory.
14947
1086c095
PE
14948 * fns.c (vector): Remove; this old hack is no longer needed.
14949
2baccd04 14950 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 14951 Remove unused var.
dde42981 14952 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 14953
72391843 14954 * xrdb.c (x_load_resources): Omit unused local.
3565b346 14955
436c16df 14956 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 14957 (x_window): Rename locals to avoid shadowing.
dc5ddd85 14958 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 14959
92bb796d 14960 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 14961 (x_term_init): Remove local to avoid shadowing.
92bb796d 14962
764430a3 14963 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
14964
14965 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
14966 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
14967
d1dfb56c
EZ
149682011-04-16 Eli Zaretskii <eliz@gnu.org>
14969
c4354cb4
EZ
14970 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
14971
d1dfb56c
EZ
14972 Fix regex.c, syntax.c and friends for buffers > 2GB.
14973 * syntax.h (struct gl_state_s): Declare character position members
14974 EMACS_INT.
14975
14976 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
14977
04f2d78b
CB
14978 * textprop.c (verify_interval_modification, interval_of):
14979 Declare arguments EMACS_INT.
d1dfb56c
EZ
14980
14981 * intervals.c (adjust_intervals_for_insertion): Declare arguments
14982 EMACS_INT.
14983
14984 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
14985
14986 * indent.c (Fvertical_motion): Local variable it_start is now
14987 EMACS_INT.
14988
14989 * regex.c (re_match, re_match_2, re_match_2_internal)
14990 (bcmp_translate, regcomp, regexec, print_double_string)
14991 (group_in_compile_stack, re_search, re_search_2, regex_compile)
14992 (re_compile_pattern, re_exec): Declare arguments and local
14993 variables `size_t' and `ssize_t' and return values `regoff_t', as
14994 appropriate.
14995 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
14996 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
14997 <compile_stack_type>: `size' and `avail' are now `size_t'.
14998
14999 * regex.h <regoff_t>: Use ssize_t, not int.
15000 (re_search, re_search_2, re_match, re_match_2): Arguments that
15001 specify buffer/string position and length are now ssize_t and
15002 size_t. Return type is regoff_t.
15003
613052cd
BK
150042011-04-16 Ben Key <bkey76@gmail.com>
15005
15006 * nsfont.m: Fixed bugs in ns_get_family and
15007 ns_descriptor_to_entity that were caused by using free to
15008 deallocate memory blocks that were allocated by xmalloc (via
15009 xstrdup). This caused Emacs to crash when compiled with
15010 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
15011 --enable-checking=xmallocoverrun). xfree is now used to
15012 deallocate these memory blocks.
15013
4170f62f 150142011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 15015
71b41406
PE
15016 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
15017
9587a89d
PE
15018 emacs_write: Accept and return EMACS_INT for sizes.
15019 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
15020 et seq.
15021 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
15022 Accept and return EMACS_INT.
15023 (emacs_gnutls_write): Return the number of bytes written on
15024 partial writes.
15025 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
15026 (emacs_read, emacs_write): Remove check for negative size, as the
15027 Emacs source code has been audited now.
9587a89d
PE
15028 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
15029 (emacs_read, emacs_write): Use it.
273a5f82
PE
15030 * process.c (send_process): Adjust to the new signatures of
15031 emacs_write and emacs_gnutls_write. Do not attempt to store
15032 a byte offset into an 'int'; it might overflow.
9587a89d 15033 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 15034
3e047f51
PE
15035 * sound.c: Don't assume sizes fit in 'int'.
15036 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 15037 Return EMACS_INT, not int.
3e047f51 15038 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
15039 Accept EMACS_INT, not int.
15040 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
15041 record read return values.
15042
cc39a9db
BK
150432011-04-15 Ben Key <bkey76@gmail.com>
15044
c9d0ec6d
JB
15045 * keyboard.c (Qundefined): Don't declare static since it is used
15046 in nsfns.m.
15047 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
15048 static since they are used in nsfont.m.
cc39a9db 15049
6c60eb9f
SM
150502011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
15051
15052 * process.c (Qprocessp): Don't declare static.
15053 * lisp.h (Qprocessp): Declare again.
15054
7990b61a
JB
150552011-04-15 Juanma Barranquero <lekktu@gmail.com>
15056
15057 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
15058
5d4cb038
PE
150592011-04-14 Paul Eggert <eggert@cs.ucla.edu>
15060
8bd7b830 15061 Improve C-level modularity by making more things 'static'.
cd64ea1d 15062
e3b27b31
PE
15063 Don't publish debugger-only interfaces to other modules.
15064 * lisp.h (safe_debug_print, debug_output_compilation_hack):
15065 (verify_bytepos, count_markers): Move decls to the only modules
15066 that need them.
15067 * region-cache.h (pp_cache): Likewise.
15068 * window.h (check_all_windows): Likewise.
15069 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
15070
5d4cb038
PE
15071 * sysdep.c (croak): Now static, if
15072 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
15073 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
15074
15075 * alloc.c (refill_memory_reserve): Now static if
15076 !defined REL_ALLOC || defined SYSTEM_MALLOC.
15077 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 15078
e87b6180
PE
15079 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
15080 Define only if USE_LUCID.
15081
ac64929e
PE
15082 * xrdb.c (x_customization_string, x_rm_string): Now static.
15083
6f37259d
PE
15084 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
15085 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
15086
1683e3ab
PE
15087 * xdisp.c (draw_row_with_mouse_face): Now static.
15088 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
15089
de9c2632
PE
15090 * window.h (check_all_windows): Mark externally visible.
15091
2b96acb7
PE
15092 * window.c (window_deletion_count): Now static.
15093
15094 * undo.c: Make symbols static if they're not exported.
15095 (last_undo_buffer, last_boundary_position, pending_boundary):
15096 Now static.
15097
50436f33
PE
15098 * textprop.c (interval_insert_behind_hooks): Now static.
15099 (interval_insert_in_front_hooks): Likewise.
15100
64520e5c
PE
15101 * term.c: Make symbols static if they're not exported.
15102 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
15103 (max_frame_lines, tty_set_terminal_modes):
15104 (tty_reset_terminal_modes, tty_turn_off_highlight):
15105 (get_tty_terminal): Now static.
15106 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
15107 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 15108 HAVE_WINDOW_SYSTEM.
64520e5c
PE
15109 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
15110 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
15111
1fa53021
PE
15112 * sysdep.c: Make symbols static if they're not exported.
15113 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
15114 Now static.
15115 (sigprocmask_set, full_mask): Remove; unused.
15116 (wait_debugging): Mark as visible.
15117 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
15118 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
15119
d4b43b22
PE
15120 * syntax.c (syntax_temp): Define only if !__GNUC__.
15121
b7c513d0
PE
15122 * sound.c (current_sound_device, current_sound): Now static.
15123
989b29ad
PE
15124 * search.c (searchbufs, searchbuf_head): Now static.
15125
13a55a78
PE
15126 * scroll.c (scroll_cost): Remove; unused.
15127 * dispextern.h (scroll_cost): Remove decl.
15128
de68a1fc
PE
15129 * region-cache.h (pp_cache): Mark as externally visible.
15130
40ccffa6
PE
15131 * process.c: Make symbols static if they're not exported.
15132 (process_tick, update_tick, create_process, chan_process):
15133 (Vprocess_alist, proc_buffered_char, datagram_access):
15134 (fd_callback_data, send_process_frame, process_sent_to): Now static.
15135 (deactivate_process): Mark defn as static, as well as decl.
15136 * lisp.h (create_process): Remove decl.
15137 * process.h (chan_process, Vprocess_alist): Remove decls.
15138
ad64fc97
PE
15139 * print.c: Make symbols static if they're not exported.
15140 (print_depth, new_backquote_output, being_printed, print_buffer):
15141 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
15142 (print_interval, print_number_index, initial_stderr_stream):
15143 Now static.
15144 * lisp.h (Fprinc): Remove decl.
15145 (debug_output_compilation_hack): Mark as externally visible.
15146
adddb265
PE
15147 * sysdep.c (croak): Move decl from here to syssignal.h.
15148 * syssignal.h (croak): Put it here, so the API can be checked when
15149 'croak' is called from dissociate_if_controlling_tty.
15150
1717ede2
PE
15151 * minibuf.c: Make symbols static if they're not exported.
15152 (minibuf_save_list, choose_minibuf_frame): Now static.
15153 * lisp.h (choose_minibuf_frame): Remove decl.
15154
fa5fb2bc
PE
15155 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
15156
1e3890d1
PE
15157 * lread.c: Make symbols static if they're not exported.
15158 (read_objects, initial_obarray, oblookup_last_bucket_number):
15159 Now static.
15160 (make_symbol): Remove; unused.
15161 * lisp.h (initial_obarray, make_symbol): Remove decls.
15162
8a1414fa
PE
15163 * keyboard.c: Make symbols static if they're not exported.
15164 (single_kboard, recent_keys_index, total_keys, recent_keys):
15165 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
15166 (this_single_command_key_start, echoing, last_auto_save):
15167 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
15168 (command_loop, echo_now, keyboard_init_hook, help_char_p):
15169 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
15170 (Vlispy_mouse_stem, double_click_count):
15171 Now static.
15172 (force_auto_save_soon): Define only if SIGDANGER.
15173 (ignore_mouse_drag_p): Now static if
15174 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
15175 (print_help): Remove; unused.
15176 (stop_character, last_timer_event): Mark as externally visible.
15177 * keyboard.h (ignore_mouse_drag_p): Declare only if
15178 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
15179 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
15180 * lisp.h (echoing): Remove decl.
15181 (force_auto_save_soon): Declare only if SIGDANGER.
15182 * xdisp.c (redisplay_window): Simplify code, to make it more
15183 obvious that ignore_mouse_drag_p is not accessed if !defined
15184 USE_GTK && !defined HAVE_NS.
15185
93ea6e8f
PE
15186 * intervals.c: Make symbols static if they're not exported.
15187 (merge_properties_sticky, merge_interval_right, delete_interval):
15188 Now static.
15189 * intervals.h (merge_interval_right, delete_interval): Remove decls.
15190
77382fcc
PE
15191 * insdel.c: Make symbols static if they're not exported.
15192 However, leave prepare_to_modify_buffer alone. It's never
15193 called from outside this function, but that appears to be a bug.
15194 (combine_after_change_list, combine_after_change_buffer):
4889fc82 15195 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
15196 (adjust_after_replace_noundo): Remove; unused.
15197 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 15198 (signal_before_change): Remove decls.
77382fcc 15199
9306c32e
PE
15200 * indent.c (val_compute_motion, val_vmotion): Now static.
15201
cd44d2eb
PE
15202 * image.c: Make symbols static if they're not exported.
15203 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
15204 if USE_GTK.
15205 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
15206 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
15207
ad9a7a06
PE
15208 * fringe.c (standard_bitmaps): Now static.
15209 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
15210
81626931
PE
15211 * frame.c: Make symbols static if they're not exported.
15212 (x_report_frame_params, make_terminal_frame): Now static.
15213 (get_frame_param): Now static, unless HAVE_NS.
15214 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
15215 (x_get_resource_string): Remove; not used.
15216 * frame.h (make_terminal_frame, x_report_frame_params):
15217 (x_get_resource_string); Remove decls.
15218 (x_fullscreen_adjust): Declare only if WINDOWSNT.
15219 * lisp.h (get_frame_param): Declare only if HAVE_NS.
15220
239f9db9
PE
15221 * font.c, fontset.c: Make symbols static if they're not exported.
15222 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
15223 (FACE_SUITABLE_FOR_CHAR_P): Use it.
15224 * font.c (font_close_object): Now static.
15225 * font.h (font_close_object): Remove.
15226 * fontset.c (FONTSET_OBJLIST): Remove.
15227 (free_realized_fontset) #if-0 the body, which does nothing.
15228 (face_suitable_for_char_p): #if-0, as it's never called.
15229 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
15230 * xfaces.c (face_at_string_position):
15231 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
15232 since 0 is always ASCII.
15233
dfcf3579
PE
15234 * fns.c (weak_hash_tables): Now static.
15235
5045092b
PE
15236 * fileio.c: Make symbols static if they're not exported.
15237 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
15238 (Vwrite_region_annotation_buffers): Now static.
15239
57a96f5c
PE
15240 * eval.c: Make symbols static if they're not exported.
15241 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
15242 * lisp.h (backtrace_list): Remove decl.
15243
35f08c38
PE
15244 * emacs.c: Make symbols static if they're not exported.
15245 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
15246 (fatal_error_code, fatal_error_signal_hook, standard_args):
15247 Now static.
15248 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
15249 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
15250 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
15251 * lisp.h (fatal_error_signal_hook): Remove decl.
15252 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
15253
f44bd759
PE
15254 * editfns.c: Move a (normally-unused) function to its only use.
15255 * editfns.c, lisp.h (get_operating_system_release): Remove.
15256 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
15257 worth the hassle of breaking this out.
15258
b532497d
PE
15259 * xterm.c: Make symbols static if they're not exported.
15260 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
15261 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
15262 (x_destroy_window, x_delete_display):
15263 Now static.
15264 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
15265 (x_mouse_leave): Remove; unused.
15266 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
15267 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
15268 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
15269 Remove decls.
15270 (x_mouse_leave): Declare only if WINDOWSNT.
15271 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
15272 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
15273 USE_X_TOOLKIT.
15274
1675728f
PE
15275 * ftxfont.c: Make symbols static if they're not exported.
15276 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
15277 HAVE_FREETYPE.
15278 * font.h (ftxfont_driver): Likewise.
15279
e4cebfca
PE
15280 * xfns.c: Make symbols static if they're not exported.
15281 (x_last_font_name, x_display_info_for_name):
15282 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
15283 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
15284 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
15285 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
15286 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
15287 (last_show_tip_args): Now static.
15288 (xic_defaut_fontset, xic_create_fontsetname): Define only if
15289 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
15290 (x_screen_planes): Remove; unused.
15291 * dispextern.h (x_screen_planes): Remove decl.
15292
5bf46f05
PE
15293 * dispnew.c: Make symbols static if they're not exported.
15294 * dispextern.h (redraw_garbaged_frames, scrolling):
15295 (increment_row_positions): Remove.
15296 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
15297 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
15298 Now static.
15299 (redraw_garbaged_frames): Remove; unused.
15300
435f4c28
PE
15301 * xfaces.c: Make symbols static if they're not exported.
15302 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
15303 Remove decls.
15304 * xterm.h (defined_color): Remove decls.
15305 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
15306 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
15307 (menu_face_changed_default, defined_color, free_realized_face):
15308 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
15309 (ascii_face_of_lisp_face): Remove; unused.
15310
8524aef3
PE
15311 * xdisp.c: Make symbols static if they're not exported.
15312 * dispextern.h (scratch_glyph_row, window_box_edges):
15313 (glyph_to_pixel_coords, set_cursor_from_row):
15314 (get_next_display_element, set_iterator_to_next):
15315 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
15316 (show_mouse_face): Remove decls
15317 * frame.h (message_buf_print): Likewise.
15318 * lisp.h (pop_message, set_message, check_point_in_composition):
15319 Likewise.
15320 * xterm.h (set_vertical_scroll_bar): Likewise.
15321 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
15322 (message_buf_print, scratch_glyph_row, displayed_buffer):
15323 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
15324 (get_next_display_element, show_mouse_face, window_box_edges):
15325 (frame_to_window_pixel_xy, check_point_in_composition):
15326 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
15327 (glyph_to_pixel_coords): Remove; unused.
15328
16390cd2
PE
15329 * dired.c (file_name_completion): Now static.
15330
15331 * dbusbind.c (xd_in_read_queued_messages): Now static.
15332
a25f4dfa
PE
15333 * lisp.h (circular_list_error, FOREACH): Remove; unused.
15334 * data.c (circular_list_error): Remove.
15335
14a9c8df
PE
15336 * commands.h (last_point_position, last_point_position_buffer):
15337 (last_point_position_window): Remove decls.
15338 * keyboard.c: Make these variables static.
15339
04f2d78b
CB
15340 * coding.h (coding, code_convert_region, encode_coding_gap):
15341 Remove decls.
74ab6df5
PE
15342 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
15343 (iso_code_class, detect_coding, code_convert_region): Now static.
15344 (encode_coding_gap): Remove; unused.
15345
38dfbee1
PE
15346 * chartab.c (chartab_chars, chartab_bits): Now static.
15347
a2cb4e63
PE
15348 * charset.h (charset_iso_8859_1): Remove decl.
15349 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
15350 Now static.
15351
127198fd
PE
15352 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
15353 * ccl.c (Vccl_program_table): Now static.
15354 (check_ccl_update): Remove; unused.
15355
d85b608f
PE
15356 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
15357 * category.h: ... from here.
15358 * category.c (check_category_table, set_category_set): Now static.
15359
31cd66f3
PE
15360 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
15361 * lisp.h: Remove these decls.
15362
c358e587
PE
15363 * buffer.c (buffer_count): Remove unused var.
15364
e78aecca
PE
15365 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
15366 so that it's not optimized away.
15367 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
15368 * dispextern.h (bidi_dump_cached_states): Remove, since it's
15369 exported only to the debugger.
15370
e192d7d3 15371 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 15372 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 15373
92470028
PE
15374 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
15375 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
15376 was inaccessible from Lisp.
15377 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
15378 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
15379
244ed907
PE
15380 alloc.c: Import and export fewer symbols, and remove unused items.
15381 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
15382 is defined.
15383 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
15384 it's not optimized away by whole-program optimization.
15385 (message_enable_multibyte, free_misc): Remove.
15386 (catchlist, handlerlist, mark_backtrace):
15387 Declare only if BYTE_MARK_STACK.
15388 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
15389 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
15390 (message_enable_multibyte): Remove decl.
15391 (free_misc, interval_free_list, float_block, float_block_index):
15392 (n_float_blocks, float_free_list, cons_block, cons_block_index):
15393 (cons_free_list, last_marked_index):
15394 Now static.
15395 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
15396 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
15397 (mark_backtrace): Define only if BYTE_MARK_STACK.
15398 * xdisp.c (message_enable_multibyte): Now static.
15399
61c2b50e 15400 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
15401 This makes it easier for human readers (and static analyzers)
15402 to see whether these variables are used from other modules.
15403 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
15404 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
15405 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
15406 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
15407 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
15408 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
15409 * xmenu.c, xselect.c:
15410 Declare Q* vars static if they are not used in other modules.
15411 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
15412 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
15413 Remove decls of unexported vars.
15414 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
15415
95c82688
PE
15416 * lisp.h (DEFINE_FUNC): Make sname 'static'.
15417
16a97296
PE
15418 Make Emacs functions such as Fatom 'static' by default.
15419 This makes it easier for human readers (and static analyzers)
15420 to see whether these functions can be called from other modules.
15421 DEFUN now defines a static function. To make the function external
15422 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
15423 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
15424 (Finit_image_library):
16a97296
PE
15425 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
15426 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
15427 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
15428 Remove decls, since these functions are now static.
15429 (Funintern, Fget_internal_run_time): New decls, since these functions
15430 were already external.
95c82688 15431
16a97296
PE
15432 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
15433 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
15434 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
15435 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
15436 * keyboard.c, keymap.c, lread.c:
15437 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
15438 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
15439 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
15440 Mark functions with DEFUE instead of DEFUN,
15441 if they are used in other modules.
15442 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
15443 decls for now-static functions.
15444 * buffer.h (Fdelete_overlay): Remove decl.
15445 * callproc.c (Fgetenv_internal): Mark as internal.
15446 * composite.c (Fremove_list_of_text_properties): Remove decl.
15447 (Fcomposition_get_gstring): New forward static decl.
15448 * composite.h (Fcomposite_get_gstring): Remove decl.
15449 * dired.c (Ffile_attributes): New forward static decl.
15450 * doc.c (Fdocumntation_property): New forward static decl.
15451 * eval.c (Ffetch_bytecode): New forward static decl.
15452 (Funintern): Remove extern decl; now in .h file where it belongs.
15453 * fileio.c (Fmake_symbolic_link): New forward static decl.
15454 * image.c (Finit_image_library): New forward static decl.
15455 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
15456 * intervals.h (Fprevious_property_change):
15457 (Fremove_list_of_text_properties): Remove decls.
15458 * keyboard.c (Fthis_command_keys): Remove decl.
15459 (Fcommand_execute): New forward static decl.
15460 * keymap.c (Flookup_key): New forward static decl.
15461 (Fcopy_keymap): Now static.
15462 * keymap.h (Flookup_key): Remove decl.
15463 * process.c (Fget_process): New forward static decl.
15464 (Fprocess_datagram_address): Mark as internal.
15465 * syntax.c (Fsyntax_table_p): New forward static decl.
15466 (skip_chars): Remove duplicate decl.
15467 * textprop.c (Fprevious_property_change): New forward static decl.
15468 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
15469 Now internal.
15470 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
15471 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
15472
785bbd42
PE
15473 * editfns.c (Fformat): Remove unreachable code.
15474
8b913b57
AS
154752011-04-14 Andreas Schwab <schwab@linux-m68k.org>
15476
15477 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
15478 change. (Bug#8496)
15479
a6744a35
EZ
154802011-04-13 Eli Zaretskii <eliz@gnu.org>
15481
15482 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
15483 when at ZV. (Bug#8487)
15484
e7974947
AS
154852011-04-12 Andreas Schwab <schwab@linux-m68k.org>
15486
baad03f0
AS
15487 * charset.c (Fclear_charset_maps): Use xfree instead of free.
15488 (Bug#8437)
15489 * keyboard.c (parse_tool_bar_item): Likewise.
15490 * sound.c (sound_cleanup, alsa_close): Likewise.
15491 * termcap.c (tgetent): Likewise.
15492 * xfns.c (x_default_font_parameter): Likewise.
15493 * xsettings.c (read_and_apply_settings): Likewise.
15494
e7974947
AS
15495 * alloc.c (overrun_check_malloc, overrun_check_realloc)
15496 (overrun_check_free): Protoize.
15497
28272684
PE
154982011-04-12 Paul Eggert <eggert@cs.ucla.edu>
15499
15500 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
15501 since callers should never pass a negative size.
15502 Change the signature to match that of plain 'read' and 'write'; see
15503 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
15504 * lisp.h: Update prototypes of emacs_write and emacs_read.
15505
11997c76
EZ
155062011-04-11 Eli Zaretskii <eliz@gnu.org>
15507
15508 * xdisp.c (redisplay_window): Don't try to determine the character
15509 position of the scroll margin if the window start point w->startp
e896f03c 15510 is outside the buffer's accessible region. (Bug#8468)
11997c76 15511
8a2cbd72
EZ
155122011-04-10 Eli Zaretskii <eliz@gnu.org>
15513
15514 Fix write-region and its subroutines for buffers > 2GB.
15515 * fileio.c (a_write, e_write): Modify declaration of arguments and
15516 local variables to support buffers larger than 2GB.
15517 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
15518
15519 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
15520 argument, local variables, and return value.
15521
15522 * lisp.h: Update prototypes of emacs_write and emacs_read.
15523
15524 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
15525
4073e537 155262011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 15527
1ebfdcb6
PE
15528 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
15529
b2ded58d
PE
15530 Fix more problems found by GCC 4.6.0's static checks.
15531
7d66342c
PE
15532 * xdisp.c (vmessage): Use a better test for character truncation.
15533
bbf47d44
PE
15534 * charset.c (load_charset_map): <, not <=, for optimization,
15535 and to avoid potential problems with integer overflow.
9248994d 15536 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 15537 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 15538 * editfns.c (Fformat): Likewise.
1e69125e 15539 * syntax.c (skip_chars): Likewise.
3befa583 15540
e3019616
PE
15541 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
15542 This also lets GCC 4.6.0 generate slightly better loop code.
15543
becfa255
PE
15544 * callint.c (Fcall_interactively): <, not <=, for optimization.
15545 (Fcall_interactively): Count the number of arguments produced,
15546 not the number of arguments given. This is simpler and lets GCC
15547 4.6.0 generate slightly better code.
15548
dae0cd48
PE
15549 * ftfont.c: Distingish more carefully between FcChar8 and char.
15550 The previous code passed unsigned char * to a functions like
15551 strlen and xstrcasecmp that expect char *, which does not
15552 conform to the C standard.
15553 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
15554 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
15555 char * when the C standard requires it.
15556
76032d70
PE
15557 * keyboard.c (read_char): Remove unused var.
15558
eb3f1cc8
PE
15559 * eval.c: Port to Windows vsnprintf (Bug#8435).
15560 Include <limits.h>.
15561 (SIZE_MAX): Define if the headers do not.
15562 (verror): Do not give up if vsnprintf returns a negative count.
15563 Instead, grow the buffer. This ports to Windows vsnprintf, which
15564 does not conform to C99. Problem reported by Eli Zaretskii.
15565 Also, simplify the allocation scheme, by avoiding the need for
15566 calling realloc, and removing the ALLOCATED variable.
15567
70476b54
PE
15568 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
15569
12020a9e
PE
15570 Remove invocations of doprnt, as Emacs now uses vsnprintf.
15571 But keep the doprint source code for now, as we might revamp it
15572 and use it again (Bug#8435).
ea6c7ae6
PE
15573 * lisp.h (doprnt): Remove.
15574 * Makefile.in (base_obj): Remove doprnt.o.
15575 * deps.mk (doprnt.o): Remove.
15576
5fdb398c
PE
15577 error: Print 32- and 64-bit integers portably (Bug#8435).
15578 Without this change, on typical 64-bit hosts error ("...%d...", N)
15579 was used to print both 32- and 64-bit integers N, which relied on
15580 undefined behavior.
61bdb816 15581 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
15582 * lisp.h (error, verror): Mark as printf-like functions.
15583 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
15584 Report overflow in size calculations when allocating printf buffer.
15585 Do not truncate output string at its first null byte.
15586 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
15587 Truncate the output at a character boundary, since vsnprintf does not
15588 do that.
15589 * charset.c (check_iso_charset_parameter): Convert internal
15590 character to string before calling 'error', since %c now has the
15591 printf meaning.
15592 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
15593 overflow when computing char to be passed to 'error'. Do not
15594 pass Lisp_Object to 'error'; pass the integer instead.
15595 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
15596 formatted with plain %d.
15597
b189fa66
PE
15598 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
15599
bff87ef0
PE
15600 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
15601
7e2cac20
PE
15602 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
15603
ce4d90b5
PE
15604 * xterm.c (x_catch_errors): Remove duplicate declaration.
15605
266c9547
PE
15606 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
15607
79c49ad2
PE
15608 * xdisp.c, lisp.h (message_nolog): Remove; unused.
15609
368f4090
JM
156102011-04-10 Jim Meyering <meyering@redhat.com>
15611
15612 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
15613 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
15614 return ssize_t not "int", and use size_t as the buffer length.
15615 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
15616 * gnutls.h: Update declarations.
15617 * process.c (read_process_output): Use ssize_t, to match.
15618 (send_process): Likewise.
15619
a32d4040
CY
156202011-04-09 Chong Yidong <cyd@stupidchicken.com>
15621
15622 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
15623
8546720e 156242011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 15625
04f2d78b
CB
15626 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
15627 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 15628
8546720e
GM
15629 * xterm.c (handle_one_xevent):
15630 * xmenu.c (create_and_show_popup_menu):
15631 * xselect.c (x_decline_selection_request)
15632 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 15633
0a2f5c1a 156342011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
15635
15636 Fix some uses of `int' instead of EMACS_INT.
15637 * search.c (string_match_1, fast_string_match)
15638 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
15639 (scan_buffer, find_next_newline_no_quit)
15640 (find_before_next_newline, search_command, Freplace_match)
15641 (Fmatch_data): Make some `int' variables be EMACS_INT.
15642
15643 * xdisp.c (display_count_lines): 3rd argument and return value now
15644 EMACS_INT. All callers changed.
15645 (pint2hrstr): Last argument is now EMACS_INT.
15646
15647 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
15648 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
15649 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
15650 (decode_coding_utf_16, decode_coding_emacs_mule)
15651 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
15652 (decode_coding_ccl, decode_coding_charset)
15653 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
15654 (decode_coding_iso_2022, decode_coding_emacs_mule)
15655 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
15656 <char_offset, last_offset>: Declare EMACS_INT.
15657 (encode_coding_utf_8, encode_coding_utf_16)
15658 (encode_coding_emacs_mule, encode_invocation_designation)
15659 (encode_designation_at_bol, encode_coding_iso_2022)
15660 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
15661 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
15662 Declare EMACS_INT.
15663 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
15664 (encode_invocation_designation): Last argument P_NCHARS is now
15665 EMACS_INT.
15666 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
15667 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
15668
15669 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
15670 All users changed.
15671
15672 * ccl.c (Fccl_execute_on_string): Declare some variables
15673 EMACS_INT.
15674
8546720e 156752011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
15676
15677 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
15678
4e19a977
CS
156792011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
15680
15681 * process.c (Fformat_network_address): Doc fix.
15682
87302331
R
156832011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
15684
ee7683eb 15685 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 15686
cbb59342
CY
156872011-04-08 Chong Yidong <cyd@stupidchicken.com>
15688
15689 * keyboard.c (read_char): Call Lisp function help-form-show,
15690 instead of using internal_with_output_to_temp_buffer.
15691 (Qhelp_form_show): New var.
e0d38eeb 15692 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
15693
15694 * print.c (internal_with_output_to_temp_buffer): Function deleted.
15695
15696 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
15697
e67a13ab
CY
156982011-04-06 Chong Yidong <cyd@stupidchicken.com>
15699
04f2d78b
CB
15700 * process.c (Flist_processes): Remove to Lisp.
15701 (list_processes_1): Delete.
e67a13ab 15702
973f782d
EZ
157032011-04-06 Eli Zaretskii <eliz@gnu.org>
15704
7c106b1e
EZ
15705 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
15706
973f782d
EZ
15707 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
15708
41cf7d1a 157092011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 15710
ca23cc88
PE
15711 Fix more problems found by GCC 4.6.0's static checks.
15712
f390e2d5
PE
15713 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
15714
42eea0d0
PE
15715 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
15716
b69769da 15717 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 15718
f9541e84
PE
15719 * xdisp.c (vmessage): Mark as a printf-like function.
15720
13841b55
PE
15721 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
15722
c136c10f
PE
15723 * sound.c (sound_warning): Don't crash if arg contains a printf format.
15724
5e2d4a30
PE
15725 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
15726 printf-like functions.
15727 (tiff_load): Add casts to remove these marks before passing them
15728 to system-supplied API.
15729
583f48b9
PE
15730 * eval.c (Fsignal): Remove excess argument to 'fatal'.
15731
b25d760e
PE
15732 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
15733 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
15734 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
15735 directly, rather than having caller test rule sign. This avoids
15736 some unnecessary tests.
15737 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
15738 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
15739 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 15740
bc7b6697 15741 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 15742 (xfont_open): Avoid unnecessary tests.
bc7b6697 15743
27ccc379
PE
15744 * composite.c (composition_gstring_put_cache): Use unsigned integer.
15745
dcd5c89a
PE
15746 * composite.h, composite.c (composition_gstring_put_cache):
15747 Use EMACS_INT, not int, for length.
15748
b13a45c6
PE
15749 * composite.h (COMPOSITION_DECODE_REFS): New macro,
15750 breaking out part of COMPOSITION_DECODE_RULE.
15751 (COMPOSITION_DECODE_RULE): Use it.
15752 * composite.c (get_composition_id): Remove unused local vars,
15753 by using the new macro.
15754
1e792e4d
PE
15755 * textprop.c (set_text_properties_1): Change while to do-while,
15756 since the condition is always true at first.
15757
dc6c6455 15758 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
15759 (interval_deletion_adjustment): Return unsigned value.
15760 All uses changed.
dc6c6455 15761
aba7731a
PE
15762 * process.c (list_processes_1, create_pty, read_process_output):
15763 (exec_sentinel): Remove vars that were set but not used.
afd4052b 15764 (create_pty): Remove unnecessary "volatile"s.
bc57d757 15765 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 15766 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 15767 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 15768
fdfc4bf3
PE
15769 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
15770
fca8fe46 15771 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 15772 (update_syntax_table): Use unsigned instead of int.
fca8fe46 15773
06a0259a 15774 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 15775 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 15776 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 15777
e7b9e80f
PE
15778 * print.c (print_error_message): Avoid int overflow.
15779
56201685
PE
15780 * font.c (font_list_entities): Redo for clarity,
15781 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
15782
78834453 15783 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 15784 (font_score): Avoid potential overflow in diff calculation.
78834453 15785
0bc0b309 15786 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 15787 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 15788
e610eaca
PE
15789 * eval.c (funcall_lambda): Rename local to avoid shadowing.
15790
b895abce
PE
15791 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
15792 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
15793 can always succeed if overflow has undefined behavior.
15794
1f1d9321 15795 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 15796 (wordify): Omit three unnecessary tests.
1f1d9321 15797
c59478bc
PE
15798 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
15799 All callers changed. This avoids the need for an unused var.
15800
79b73827
PE
15801 * casefiddle.c (casify_region): Remove var that is set but not used.
15802
a4db5dfe
PE
15803 * dired.c (file_name_completion): Remove var that is set but not used.
15804
43aae36e
PE
15805 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
15806
2a47c44d 15807 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 15808 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 15809
a37c69bf
PE
15810 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
15811 Check for integer overflow on size calculations.
15812
328ab8e7
PE
15813 * buffer.c (Fprevious_overlay_change): Remove var that is set
15814 but not used.
15815
e5a2a5cb
PE
15816 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
15817 Remove vars that are set but not used.
8d84a6eb 15818 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 15819 (timer_check_2): Mark vars as initialized.
e5a2a5cb 15820
a60e5f68
PE
15821 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
15822
f661cb61 15823 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 15824 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 15825
f0397f5a
PE
15826 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
15827 that are set but not used.
15828
8664db06 15829 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 15830 if XCreateBitmapFromData fails (Bug#8410).
8664db06 15831
6abdaa4a
PE
15832 * xselect.c (x_get_local_selection, x_handle_property_notify):
15833 Remove vars that are set but not used.
15834
0ce7538d 15835 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 15836 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 15837
9ae848fc
PE
15838 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
15839 Remove var that is set but not used.
0b918413
PE
15840 (scroll_bar_windows_size): Now size_t, not int.
15841 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
15842 Check for overflow.
9ae848fc 15843
a5a62657
PE
15844 * xfaces.c (realize_named_face): Remove vars that are set but not used.
15845 (map_tty_color) [!defined MSDOS]: Likewise.
15846
5c5cdd39
PE
15847 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
15848
66ebf983
PE
15849 * coding.c: Remove vars that are set but not used.
15850 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
15851 All callers changed.
15852 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
15853 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
15854 (decode_coding_charset): Remove vars that are set but not used.
15855
1be4d761
PE
15856 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
15857 that is set but not used.
15858
47553fa8
PE
15859 * print.c (print_object): Remove var that is set but not used.
15860
1f7196bf 15861 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
15862 The gnulib version avoids calling malloc in the usual case,
15863 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
15864 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
15865 * filelock.c (current_lock_owner): Likewise.
15866 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
15867 * sysdep.c: Include allocator.h, careadlinkat.h.
15868 (emacs_no_realloc_allocator): New static constant.
15869 (emacs_readlink): New function.
fdb61804
PE
15870 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
15871 ../lib/careadlinkat.h.
d1fdcab7 15872
f84c17c7
SM
158732011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
15874
15875 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
15876 first non-nil return value).
15877
ef3862ad
JD
158782011-04-03 Jan Djärv <jan.h.d@swipnet.se>
15879
15880 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
15881 if not defined (Bug#8403).
15882
376a7006
JB
158832011-04-02 Juanma Barranquero <lekktu@gmail.com>
15884
15885 * xdisp.c (display_count_lines): Remove parameter `start',
15886 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
15887 (get_char_face_and_encoding): Remove parameter `multibyte_p',
15888 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
15889 (fill_stretch_glyph_string): Remove parameters `row' and `area',
15890 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
15891 and thereabouts. All callers changed.
15892 (get_per_char_metric): Remove parameter `f', unused since
15893 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
15894
6ca3801d
JM
158952011-04-02 Jim Meyering <meyering@redhat.com>
15896
15897 do not dereference NULL upon failed strdup
15898 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
15899 (ns_get_family): Likewise.
15900
d8e2b5ba
JB
159012011-04-02 Juanma Barranquero <lekktu@gmail.com>
15902
15903 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
15904
8c74fcbd
JD
159052011-04-02 Jan Djärv <jan.h.d@swipnet.se>
15906
15907 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
15908 later (Bug#8403).
15909
7200d79c
SM
159102011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
15911
03408648 15912 Add lexical binding.
7200d79c 15913
03408648
SM
15914 * window.c (Ftemp_output_buffer_show): New fun.
15915 (Fsave_window_excursion):
15916 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
15917
15918 * lread.c (lisp_file_lexically_bound_p): New function.
15919 (Fload): Bind Qlexical_binding.
15920 (readevalloop): Remove `evalfun' arg.
15921 Bind Qinternal_interpreter_environment.
15922 (Feval_buffer): Bind Qlexical_binding.
15923 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
15924 Mark as dynamic.
15925 (syms_of_lread): Declare `lexical-binding'.
15926
15927 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
15928
15929 * keyboard.c (eval_dyn): New fun.
15930 (menu_item_eval_property): Use it.
ca105506
SM
15931
15932 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 15933
03408648
SM
15934 * fns.c (concat, mapcar1): Accept byte-code-functions.
15935
15936 * eval.c (Fsetq): Handle lexical vars.
15937 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
15938 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
15939 (FletX, Flet): Obey lexical binding.
15940 (Fcommandp): Handle closures.
15941 (Feval): New `lexical' arg.
15942 (eval_sub): New function extracted from Feval. Use it almost
15943 everywhere where Feval was used. Look up vars in lexical env.
15944 Handle closures.
15945 (Ffunctionp): Move from subr.el.
15946 (Ffuncall): Handle closures.
15947 (apply_lambda): Remove `eval_flags'.
15948 (funcall_lambda): Handle closures and new byte-code-functions.
15949 (Fspecial_variable_p): New function.
15950 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
15951 but without exporting it to Lisp.
23aba0ea 15952
23aba0ea 15953 * doc.c (Fdocumentation, store_function_docstring):
03408648 15954 * data.c (Finteractive_form): Handle closures.
23aba0ea 15955
03408648
SM
15956 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
15957 interactive spec.
ba83908c 15958
04f2d78b
CB
15959 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
15960 New byte-codes.
03408648
SM
15961 (exec_byte_code): New function extracted from Fbyte_code to handle new
15962 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 15963
03408648 15964 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 15965
03408648 15966 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 15967
e2abce01
JB
159682011-03-31 Juanma Barranquero <lekktu@gmail.com>
15969
15970 * xdisp.c (redisplay_internal): Fix prototype.
15971
63696a73 159722011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 15973
63696a73 15974 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
15975 (try_scrolling): Use it when setting scroll_limit.
15976 Limit scrolling to 100 screen lines.
63696a73
EZ
15977 (redisplay_window): Even when falling back on "recentering",
15978 position point in the window according to scroll-conservatively,
15979 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
15980
15981 (try_scrolling): When point is above the window, allow searching
15982 as far as scroll_max, or one screenful, to compute vertical
15983 distance from PT to the scroll margin position. This prevents
15984 try_scrolling from unnecessarily failing when
15985 scroll-conservatively is set to a value slightly larger than the
15986 window height. Clean up the case of PT below the margin at bottom
15987 of window: scroll_max can no longer be INT_MAX. When aggressive
15988 scrolling is in use, don't let point enter the opposite scroll
15989 margin as result of the scroll.
15990 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
15991 threshold of 100 lines for never-recentering scrolling.
15992
e4cc2dfc
JB
159932011-03-31 Juanma Barranquero <lekktu@gmail.com>
15994
15995 * dispextern.h (move_it_by_lines):
15996 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
15997 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
15998 (message_log_check_duplicate): Remove parameters `prev_bol' and
15999 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
16000 (redisplay_internal): Remove parameter `preserve_echo_area',
16001 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
16002
16003 * indent.c (Fvertical_motion):
16004 * window.c (window_scroll_pixel_based, Frecenter):
16005 Don't pass `need_y_p' to `move_it_by_lines'.
16006
1c470562
SM
160072011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
16008
44f230aa
SM
16009 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
16010 steal a few bits to be more compact.
16011 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
16012 Remove unneeded casts.
16013
1c470562
SM
16014 * bytecode.c (Fbyte_code): CAR and CDR can GC.
16015
888adce9
ZK
160162011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
16017
16018 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
16019 binding" message (bug#7967).
16020
f838ed7b
PE
160212011-03-30 Paul Eggert <eggert@cs.ucla.edu>
16022
77861b95
PE
16023 Fix more problems found by GCC 4.6.0's static checks.
16024
de6dbc14
PE
16025 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
16026 Remove unused local var.
16027
f838ed7b
PE
16028 * editfns.c (Fmessage_box): Remove unused local var.
16029
792c7b2b
PE
16030 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
16031 (note_mode_line_or_margin_highlight, note_mouse_highlight):
16032 Omit unused local vars.
c499e557 16033 * window.c (shrink_windows): Omit unused local var.
b01a1c29 16034 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
16035 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
16036 Omit unused local var.
16037
ba0165e1
PE
16038 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
16039 Don't assume string length fits in int.
32ad8845 16040 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 16041 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 16042
3c59b4c9
PE
16043 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
16044 instead of alloca (Bug#8344).
16045
a3eed478 16046 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 16047 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 16048
eb4d412d
PE
16049 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
16050
1658b401
PE
16051 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
16052 concerns.
16053
16054 * term.c (produce_glyphless_glyph): Remove unnecessary test.
16055
16056 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 16057
9a2c6e05
PE
16058 * keyboard.c (syms_of_keyboard): Use the same style as later
16059 in this function when indexing through an array. This also
16060 works around GCC bug 48267.
16061
03d0a109
PE
16062 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
16063
44f730c8
PE
16064 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
16065
fe75f926
PE
16066 * chartab.c (sub_char_table_ref_and_range): Redo for slight
16067 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
16068
ffa8c828
PE
16069 * keyboard.c, keyboard.h (num_input_events): Now size_t.
16070 This avoids undefined behavior on integer overflow, and is a bit
16071 more convenient anyway since it is compared to a size_t variable.
16072
c5101a77
PE
16073 Variadic C functions now count arguments with size_t, not int.
16074 This avoids an unnecessary limitation on 64-bit machines, which
16075 caused (substring ...) to crash on large vectors (Bug#8344).
16076 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
16077 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 16078 All variadic functions and their callers changed accordingly.
c5101a77
PE
16079 (struct gcpro.nvars): Now size_t, not int. All uses changed.
16080 * data.c (arith_driver, float_arith_driver): Likewise.
16081 * editfns.c (general_insert_function): Likewise.
16082 * eval.c (struct backtrace.nargs, interactive_p)
16083 (internal_condition_case_n, run_hook_with_args, apply_lambda)
16084 (funcall_lambda, mark_backtrace): Likewise.
16085 * fns.c (concat): Likewise.
16086 * frame.c (x_set_frame_parameters): Likewise.
16087 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
16088 0 if not found, not -1. All callers changed.
16089
dd3f25f7
PE
16090 * alloc.c (garbage_collect): Don't assume stack size fits in int.
16091 (stack_copy_size): Now size_t, not int.
16092 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
16093
461c2ab9
JB
160942011-03-28 Juanma Barranquero <lekktu@gmail.com>
16095
16096 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
16097 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
16098 All callers changed.
16099
16100 * lisp.h (multibyte_char_to_unibyte):
16101 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
16102 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
16103 * character.h (CHAR_TO_BYTE8):
16104 * cmds.c (internal_self_insert):
16105 * editfns.c (general_insert_function):
16106 * keymap.c (push_key_description):
16107 * search.c (Freplace_match):
16108 * xdisp.c (message_dolog, set_message_1): All callers changed.
16109
f6d62986
SM
161102011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
16111
16112 * keyboard.c (safe_run_hook_funcall): New function.
16113 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
16114 don't set the hook to nil, but remove the offending function instead.
16115 (Qcommand_hook_internal): Remove, unused.
16116 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
16117 Vcommand_hook_internal.
16118
16119 * eval.c (enum run_hooks_condition): Remove.
16120 (funcall_nil, funcall_not): New functions.
16121 (run_hook_with_args): Call each function through a `funcall' argument.
16122 Remove `cond' argument, now redundant.
16123 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
16124 (Frun_hook_with_args_until_failure): Adjust accordingly.
16125 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
16126
1db5b1ad
JB
161272011-03-28 Juanma Barranquero <lekktu@gmail.com>
16128
16129 * dispextern.h (string_buffer_position): Remove declaration.
16130
16131 * print.c (strout): Remove parameter `multibyte', unused since
16132 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
16133
16134 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
16135 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
16136 All callers changed.
16137
16138 * w32.c (_wsa_errlist): Use braces for struct initializers.
16139
16140 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
16141 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
16142 All callers changed.
16143 (string_buffer_position): Likewise. Also, make static (it's never
16144 used outside xdisp.c).
16145 (cursor_row_p): Remove parameter `w', unused since
16146 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
16147 (decode_mode_spec): Remove parameter `precision', introduced during
16148 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
16149 All callers changed.
16150
5ffb62aa
JD
161512011-03-27 Jan Djärv <jan.h.d@swipnet.se>
16152
16153 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
16154
461c2ab9 161552011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
16156
16157 * nsterm.m (ns_menu_bar_is_hidden): New variable.
16158 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
16159 (ns_update_auto_hide_menu_bar): New functions.
16160 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
16161 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
16162 ns_constrain_all_frames.
16163 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
16164 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
16165
5c380ffb
JD
161662011-03-27 Jan Djärv <jan.h.d@swipnet.se>
16167
16168 * nsmenu.m (runDialogAt): Remove argument to timer_check.
16169
9af30bdf
GM
161702011-03-27 Glenn Morris <rgm@gnu.org>
16171
16172 * syssignal.h: Replace RETSIGTYPE with void.
16173 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
16174 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
16175 Replace SIGTYPE with void everywhere.
16176 * s/usg5-4-common.h (SIGTYPE): Remove definition.
16177 * s/template.h (SIGTYPE): Remove commented out definition.
16178
e2abce01
JB
161792011-03-26 Eli Zaretskii <eliz@gnu.org>
16180
16181 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
16182 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
16183
f868cd8a
JB
161842011-03-26 Juanma Barranquero <lekktu@gmail.com>
16185
59eb0929
JB
16186 * w32.c (read_unc_volume): Use parameter `henum', instead of
16187 global variable `wget_enum_handle'.
16188
16189 * keymap.c (describe_vector): Remove parameters `indices' and
16190 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
16191 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
16192
f868cd8a
JB
16193 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
16194
16195 * keyboard.c (timer_check): Remove parameter `do_it_now',
16196 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
16197 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
16198 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
16199
16200 * keyboard.c (read_char):
16201 * w32menu.c (w32_menu_display_help):
16202 * xmenu.c (show_help_event, menu_help_callback):
16203 Adjust calls to `show_help_echo'.
16204
16205 * gtkutil.c (xg_maybe_add_timer):
16206 * keyboard.c (readable_events):
16207 * process.c (wait_reading_process_output):
16208 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
16209
16210 * insdel.c (adjust_markers_gap_motion):
16211 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
16212 (gap_left, gap_right): Don't call it.
16213
2ecf6fdb
CY
162142011-03-25 Chong Yidong <cyd@stupidchicken.com>
16215
16216 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
16217 incurred during fontification.
16218
6b1f9ba4
JB
162192011-03-25 Juanma Barranquero <lekktu@gmail.com>
16220
16221 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
16222 (DEFVAR_PER_BUFFER): Don't pass it.
16223
16224 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
16225 (scrolling_window): Don't pass it.
16226
0f4a96b5
JB
162272011-03-25 Juanma Barranquero <lekktu@gmail.com>
16228
16229 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
16230
16231 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
16232 and `suffix'.
16233 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
16234 of variables specific to SELinux and computation of `encoded_absname'.
16235
16236 * image.c (XPutPixel): Remove unused variable `height'.
16237
16238 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
16239
16240 * unexw32.c (get_section_info): Remove unused variable `section'.
16241
16242 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
16243 (system_process_attributes): Remove unused variable `sess'.
16244 (sys_read): Remove unused variable `err'.
16245
16246 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
16247 (w32_wnd_proc): Remove unused variable `isdead'.
16248 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
16249 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
16250 (x_create_tip_frame): Remove unused variable `tem'.
16251
16252 * w32inevt.c (w32_console_read_socket):
16253 Remove unused variable `no_events'.
16254
16255 * w32term.c (x_draw_composite_glyph_string_foreground):
16256 Remove unused variable `width'.
16257
1149507c
JB
162582011-03-24 Juanma Barranquero <lekktu@gmail.com>
16259
16260 * w32term.c (x_set_glyph_string_clipping):
16261 Don't pass uninitialized region to CombineRgn.
16262
9c88f339
JB
162632011-03-23 Juanma Barranquero <lekktu@gmail.com>
16264
16265 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
16266 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
16267 (Fx_close_connection): Remove unused variable `i'.
16268
16269 * w32font.c (w32font_draw): Return number of glyphs.
16270 (w32font_open_internal): Remove unused variable `i'.
16271 (w32font_driver): Add missing initializer.
16272
16273 * w32menu.c (utf8to16): Remove unused variable `utf16'.
16274 (fill_in_menu): Remove unused variable `items_added'.
16275
16276 * w32term.c (last_mouse_press_frame): Remove static global variable.
16277 (w32_clip_to_row): Remove unused variable `f'.
16278 (x_delete_terminal): Remove unused variable `i'.
16279
16280 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
16281 (NOTHING): Remove unused static global variable.
16282 (uniscribe_check_otf): Remove unused variable `table'.
16283 (uniscribe_font_driver): Add missing initializers.
16284
dee091a3
JD
162852011-03-23 Julien Danjou <julien@danjou.info>
16286
16287 * term.c (Fsuspend_tty, Fresume_tty):
16288 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
16289 * window.c (temp_output_buffer_show):
16290 * insdel.c (signal_before_change):
16291 * frame.c (Fhandle_switch_frame):
16292 * fileio.c (Fdo_auto_save):
16293 * emacs.c (Fkill_emacs):
16294 * editfns.c (save_excursion_restore):
16295 * cmds.c (internal_self_insert):
16296 * callint.c (Fcall_interactively):
16297 * buffer.c (Fkill_all_local_variables):
16298 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
16299 Use Frun_hooks.
0f4a96b5 16300 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 16301 unconditionally since it does the check itself.
dee091a3 16302
2c520ab5 163032011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 16304
c9c49752
PE
16305 Fix more problems found by GCC 4.5.2's static checks.
16306
8abc3f12
PE
16307 * coding.c (encode_coding_raw_text): Avoid unnecessary test
16308 the first time through the loop, since we know p0 < p1 then.
16309 This also avoids a gcc -Wstrict-overflow warning.
16310
a2d26660
PE
16311 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
16312 leading to a memory leak, possible in functions like
16313 load_charset_map_from_file that can allocate an unbounded number
b12ef411 16314 of objects (Bug#8318).
a2d26660 16315
916c72e9
PE
16316 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
16317 that could (at least in theory) be that large.
16318
19ab8a18
PE
16319 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
16320 This is less likely to overflow, and avoids undefined behavior if
16321 overflow does occur. All callers changed. Use strtoul to scan
16322 for the unsigned long integer.
b7cbbd6f
PE
16323 (pint2hrstr): Simplify and tune code slightly.
16324 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 16325
f0641eff
PE
16326 * scroll.c (do_scrolling): Work around GCC bug 48228.
16327 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
16328
7f650bb9
PE
16329 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
16330 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
16331 (validate_x_resource_name): Simplify count usage.
16332 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 16333
37dd57d1
PE
16334 * fileio.c (Fcopy_file): Report error if fchown or fchmod
16335 fail (Bug#8306).
81e56e61 16336
699979fc 16337 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 16338
401bf9b4
PE
16339 * process.c (Fmake_network_process): Use socklen_t, not int,
16340 where POSIX says socklen_t is required in portable programs.
16341 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 16342 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
16343 (Fmake_network_process, server_accept_connection):
16344 (wait_reading_process_output, read_process_output):
16345 Likewise.
16346
b93aacde
PE
16347 * process.c: Rename or move locals to avoid shadowing.
16348 (list_processes_1, Fmake_network_process):
16349 (read_process_output_error_handler, exec_sentinel_error_handler):
16350 Rename or move locals.
4dc343ee 16351 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 16352 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 16353 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 16354 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 16355 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 16356
af8a867c 16357 Make tparam.h and terminfo.c consistent.
44f230aa
SM
16358 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
16359 Include tparam.h instead, since it declares them.
af8a867c
PE
16360 * cm.h (PC): Remove extern decl; tparam.h now does this.
16361 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
16362 * terminfo.c: Include tparam.h, to check interfaces.
16363 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
16364 (tparam): Adjust signature to match interface in tparam.h;
16365 this removes some undefined behavior. Check that outstring and len
16366 are zero, which they always are with Emacs.
16367 * tparam.h (PC, BC, UP): New extern decls.
16368
0248044d 16369 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 16370 (xftfont_open): Rename locals to avoid shadowing.
0248044d 16371
8ff096c1 16372 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
16373 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
16374 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 16375 (ftfont_list): Remove unused local.
49eaafba
PE
16376 (get_adstyle_property, ftfont_pattern_entity):
16377 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
16378 Rename locals to avoid shadowing.
8ff096c1 16379
e2be39f6
PE
16380 * xfont.c (xfont_list_family): Mark var as initialized.
16381
c9735e30
PE
16382 * xml.c (make_dom): Now static.
16383
8f5201ae
PE
16384 * composite.c (composition_compute_stop_pos): Rename local to
16385 avoid shadowing.
b246f932
PE
16386 (composition_reseat_it): Remove unused locals.
16387 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 16388 (composition_update_it): Mark var as initialized.
11b61122
PE
16389 (find_automatic_composition): Mark vars as initialized,
16390 with a FIXME (Bug#8290).
8f5201ae 16391
760fbc2c
PE
16392 character.h: Rename locals to avoid shadowing.
16393 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
16394 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
16395 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
16396 (BUF_DEC_POS): Be more systematic about renaming local temporaries
16397 to avoid shadowing.
16398
ff08eb85
PE
16399 * textprop.c (property_change_between_p): Remove; unused.
16400
fc7bf025
PE
16401 * intervals.c (interval_start_pos): Now static.
16402
235d7abc
PE
16403 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
16404
44f230aa
SM
16405 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
16406 Rename locals to avoid shadowing.
3e7d6594 16407
50060332
PE
16408 * sound.c (wav_play, au_play, Fplay_sound_internal):
16409 Fix pointer signedness.
d01f234b 16410 (alsa_choose_format): Remove unused local var.
c83b8872
PE
16411 (wav_play): Initialize a variable to 0, to prevent undefined
16412 behavior (Bug#8278).
50060332 16413
c4fc4e30
PE
16414 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
16415
918436ed
PE
16416 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
16417
c939f91b
PE
16418 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
16419 clobbering (Bug#8298).
b9c7f648
PE
16420 * sysdep.c (sys_subshell): Likewise.
16421 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 16422
6bd8c144
PE
16423 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
16424 This should get cleaned up, so that child_setup has the
16425 same signature on all platforms.
16426
7710357c 16427 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 16428 (relocate_fd): Rename locals to avoid shadowing.
7710357c 16429
c59da222
CY
164302011-03-22 Chong Yidong <cyd@stupidchicken.com>
16431
16432 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
16433 not to be necessary, and produces flickering.
16434
66b87493
GM
164352011-03-20 Glenn Morris <rgm@gnu.org>
16436
16437 * config.in: Remove file.
16438
45b6f6d5
JB
164392011-03-20 Juanma Barranquero <lekktu@gmail.com>
16440
16441 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
16442 are now in src/globals.h.
16443 (syms_of_minibuf): Remove spurious & from previous change.
16444
cd394be1 164452011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
16446
16447 * minibuf.c (completing-read-function): New variable.
16448 (completing-read-default): Rename from completing-read.
16449 (completing-read): Call completing-read-function.
16450
b14e3e21
CY
164512011-03-19 Juanma Barranquero <lekktu@gmail.com>
16452
16453 * xfaces.c (Fx_load_color_file):
16454 Read color file from absolute filename (bug#8250).
16455
f2b726e6
JB
164562011-03-19 Juanma Barranquero <lekktu@gmail.com>
16457
16458 * makefile.w32-in: Update dependencies.
16459
09f6ff02
EZ
164602011-03-17 Eli Zaretskii <eliz@gnu.org>
16461
16462 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
16463
29a6015a
PE
164642011-03-17 Paul Eggert <eggert@cs.ucla.edu>
16465
a3a6c54e
PE
16466 Fix more problems found by GCC 4.5.2's static checks.
16467
b766f867
PE
16468 * process.c (make_serial_process_unwind, send_process_trap):
16469 (sigchld_handler): Now static.
16470
be02381c
PE
16471 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
16472 That way, the code declares only the vars that it needs.
16473 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
16474 * s/cygwin.h (PTY_ITERATION): Likewise.
16475 * s/darwin.h (PTY_ITERATION): Likewise.
16476 * s/gnu-linux.h (PTY_ITERATION): Likewise.
16477
57048744
PE
16478 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
16479 * process.c (allocate_pty): Don't declare stb unless it's needed.
16480
7914961c 16481 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
16482 (CONSTANTLIM): Remove; unused.
16483 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
16484 Define only if needed.
7914961c 16485
b3967b18
PE
16486 * unexelf.c (unexec): Name an expression,
16487 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
16488 Use a different way to cause a compilation error if anyone uses
16489 n rather than nn, a way that does not involve shadowing.
73366a00 16490 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 16491
29a6015a
PE
16492 * deps.mk (unexalpha.o): Remove; unused.
16493
43cfc33e 16494 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 16495 * unexec.h: New file.
ce701a33
PE
16496 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
16497 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
16498 Depend on unexec.h.
16499 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
16500 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
16501 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 16502 Change as necessary to match prototype in unexec.h.
ce701a33 16503
01f44d5a
PE
16504 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
16505 shadowing.
4f63c6bb 16506 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 16507
a6670b0b
PE
16508 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
16509 Rename locals to avoid shadowing.
16510
cef2010d 16511 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 16512 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 16513
d4d7173a
PE
16514 * print.c (Fredirect_debugging_output): Fix pointer signedess.
16515
f08b802a
PE
16516 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
16517 warning when compiling print.c.
16518
3ddb0639
PE
16519 * font.c (font_unparse_fcname): Abort in an "impossible" situation
16520 instead of using an uninitialized var.
5ad03b97 16521 (font_sort_entities): Mark var as initialized.
3ddb0639 16522
170a2692
PE
16523 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
16524
e663c700
PE
16525 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
16526 pointers to constants.
89bc529a 16527 (font_parse_fcname): Remove unused vars.
7b81e2d0 16528 (font_delete_unmatched): Now static.
ea838e10 16529 (font_get_spec): Remove; unused.
13a547c6
PE
16530 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
16531 (font_update_drivers, Ffont_get_glyphs, font_add_log):
16532 Rename or move locals to avoid shadowing.
e663c700 16533
2a80c887 16534 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 16535 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 16536
1384fa33 16537 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 16538 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 16539
8b2c52e9
PE
16540 * alloc.c (mark_backtrace): Move decl from here ...
16541 * lisp.h: ... to here, so that it can be checked.
16542
475545b5 16543 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 16544 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
16545 (lisp_indirect_variable): Name an expression,
16546 to avoid gcc -Wbad-function-cast warning.
1faed8ae 16547 (Fdefvar): Rename locals to avoid shadowing.
475545b5 16548
b1349114 16549 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 16550 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 16551 Use const pointer when appropriate.
b1349114 16552
a2928364
PE
16553 * lisp.h (get_system_name, get_operating_system_release):
16554 Move decls here, to check interfaces.
16555 * process.c (get_operating_system_release): Move decl to lisp.h.
16556 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
16557 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
16558 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
16559 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
16560 (Fformat_time_string, Fencode_time, Finsert_char):
16561 (Ftranslate_region_internal, Fformat):
16562 Rename or remove local vars to avoid shadowing.
9710023e 16563 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 16564
a415e694
PE
16565 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
16566 avoid shadowing.
16567
8ef4622d
PE
16568 * lisp.h (eassert): Check that the argument compiles, even if
16569 ENABLE_CHECKING is not defined.
16570
946f9a5b
PE
16571 * data.c (Findirect_variable): Name an expression, to avoid
16572 gcc -Wbad-function-cast warning.
112396d6 16573 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 16574 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
16575 (Fmake_variable_buffer_local, Fmake_local_variable):
16576 Mark variables as initialized.
52746918 16577 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 16578
e5aab7e7 16579 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
16580 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
16581 Rename locals to avoid shadowing.
dff45157
PE
16582 (mark_stack): Move local variables into the #ifdef region where
16583 they're used.
7bc26fdb
PE
16584 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
16585 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
16586 needed otherwise.
16587 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
16588 (GC_STRING_CHARS): Remove; not used.
d40d4be1 16589 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 16590
e5aab7e7
PE
16591 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
16592 avoids undefined behavior in theory.
16593
4da60324
PE
16594 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
16595
88043301
PE
16596 Use functions, not macros, for up- and down-casing (Bug#8254).
16597 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
16598 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
16599 to use the following functions instead of these macros.
16600 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
16601 EMACS_INT, since callers assume the returned value fits in int.
16602 (upcase1): Likewise, for UPCASE_TABLE.
16603 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 16604 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 16605 the race-condition problem in the old DOWNCASE.
88043301 16606
19ed5445
PE
16607 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
16608 Rename locals to avoid shadowing.
16609 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
16610 (regex_compile, re_search_2, re_match_2_internal):
16611 Remove unused local vars.
952db0d7
PE
16612 (FREE_VAR): Rewrite so as not to use empty "else",
16613 which gcc can warn about.
da053e48 16614 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
16615 (RETALLOC_IF): Define only if needed.
16616 (WORDCHAR_P): Likewise. This one is never needed, but is used
16617 only in a comment talking about a compiler bug, so put inside
16618 the #if 0 of that comment.
16619 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
16620 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
16621 Remove; unused.
19ed5445 16622
1f3561e4 16623 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
16624 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
16625 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 16626
ded6f8f7
PE
16627 * search.c (simple_search): Remove unused var.
16628
dbd37a95
PE
16629 * dired.c (compile_pattern): Move decl from here ...
16630 * lisp.h: ... to here, so that it can be checked.
16631 (struct re_registers): New forward decl.
16632
7e47afad
PE
16633 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
16634
85f24f61
PE
16635 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
16636 All uses changed.
16637 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
16638 Rename locals to avoid shadowing.
5671df8f 16639 (Fvertical_motion): Mark locals as initialized.
85f24f61 16640
181aa2be 16641 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 16642 (casify_region): Mark local as initialized.
181aa2be 16643
930d429c
PE
16644 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
16645
7082eac6
PE
16646 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
16647 New macros, so that the caller can use some names other than
16648 gcpro1, gcpro2, etc.
16649 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
16650 of the new macros.
16651 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
16652 argument, for consistency with GCPRO2_VAR, etc: it is now the
16653 prefix of the variable, not the variable itself. All uses
16654 changed.
38b2c076
PE
16655 * dired.c (directory_files_internal, file_name_completion):
16656 Rename locals to avoid shadowing.
16657
15206ed9
PE
16658 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
16659 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
16660 dired.c's scmp function, had undefined behavior.
16661 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
16662 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
16663 * buffer.h: ... to here, because these macros use current_buffer,
16664 and the new implementation with inline functions needs to have
16665 current_buffer in scope now, rather than later when the macros
16666 are used.
16667 (downcase, upcase1): New static inline functions.
16668 (DOWNCASE, UPCASE1): Reimplement using these functions.
16669 This avoids undefined behavior in expressions like
16670 DOWNCASE (x) == DOWNCASE (y), which previously suffered
16671 from race conditions in accessing the global variables
16672 case_temp1 and case_temp2.
16673 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
16674 * lisp.h (case_temp1, case_temp2): Remove their decls.
16675 * character.h (ASCII_CHAR_P): Move from here ...
16676 * lisp.h: ... to here, so that the inline functions mentioned
16677 above can use them.
16678
4a6bea26
PE
16679 * dired.c (directory_files_internal_unwind): Now static.
16680
f14b7e14
PE
16681 * fileio.c (file_name_as_directory, directory_file_name):
16682 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
16683 Now static.
2893f146
PE
16684 (file_name_as_directory): Use const pointers when appropriate.
16685 (Fexpand_file_name): Likewise. In particular, newdir might
16686 point at constant storage, so make it a const pointer.
fd4ead52 16687 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
16688 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
16689 signedness issues.
f839df0c
PE
16690 (Fset_file_times, Finsert_file_contents, auto_save_error):
16691 Rename locals to avoid shadowing.
f14b7e14 16692
5716756e 16693 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
16694 (Ftry_completion, Fall_completions): Rename or remove locals
16695 to avoid shadowing.
5716756e 16696
b4c3046a
PE
16697 * marker.c (bytepos_to_charpos): Remove; unused.
16698
b45db522
PE
16699 * lisp.h (verify_bytepos, count_markers): New decls,
16700 so that gcc does not warn that these functions aren't declared.
16701
85876d07
PE
16702 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
16703 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 16704 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 16705 (copy_text): Remove unused local var.
85876d07 16706
03d78a21 16707 * filelock.c (within_one_second): Now static.
b3dd38ab 16708 (lock_file_1): Rename local to avoid shadowing.
03d78a21 16709
5df8f01b
PE
16710 * buffer.c (fix_overlays_before): Mark locals as initialized.
16711 (fix_start_end_in_overlays): Likewise. This function should be
16712 simplified by using pointers-to-pointers, but that's a different
16713 matter.
b1d876f1 16714 (switch_to_buffer_1): Now static.
8f54f30a
PE
16715 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
16716 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 16717
a70072c9 16718 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 16719 Fix pointer signedness issue.
edced198
PE
16720 (sys_subshell): Mark local as volatile if checking for lint,
16721 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 16722 (MAXPATHLEN): Define only if needed.
a70072c9 16723
a0977c44
PE
16724 * process.c (serial_open, serial_configure): Move decls from here ...
16725 * systty.h: ... to here, so that they can be checked.
16726
a884fdcc
PE
16727 * fns.c (get_random, seed_random): Move extern decls from here ...
16728 * lisp.h: ... to here, so that they can be checked.
16729
604efe86 16730 * sysdep.c (reset_io): Now static.
b8950c94 16731 (wait_for_termination_signal): Remove; unused.
604efe86 16732
38fc62d9
PE
16733 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
16734 (copy_keymap_item, append_key, push_text_char_description):
16735 Now static.
1004a21a 16736 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 16737 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
16738 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
16739 (describe_map_tree):
16740 Rename locals to avoid shadowing.
38fc62d9 16741
2f2650da
PE
16742 * keyboard.c: Declare functions static if they are not used elsewhere.
16743 (echo_char, echo_dash, cmd_error, top_level_2):
16744 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
16745 (read_char, kbd_buffer_get_event, make_lispy_position):
16746 (make_lispy_event, make_lispy_movement, apply_modifiers):
16747 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
16748 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
16749 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 16750 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 16751 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 16752
a053e86c 16753 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
16754 (mark_kboards): Move decl here ...
16755 * alloc.c (mark_kboards): ... from here.
a053e86c 16756
4752793e
PE
16757 * lisp.h (force_auto_save_soon): New decl.
16758
74f10ca7 16759 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
16760 (DEFINE_DUMMY_FUNCTION): New macro.
16761 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
16762 Use it.
c03cd23f
PE
16763 (main): Add casts to avoid warnings
16764 if GCC considers string literals to be constants.
74f10ca7 16765
022e70d4
PE
16766 * lisp.h (fatal_error_signal): Add decl, since it's exported.
16767
59d6fe83
PE
16768 * dbusbind.c: Pointer signedness fixes.
16769 (xd_signature, xd_append_arg, xd_initialize):
16770 (Fdbus_call_method, Fdbus_call_method_asynchronously):
16771 (Fdbus_method_return_internal, Fdbus_method_error_internal):
16772 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
16773 (Fdbus_register_signal): Use SSDATA when the context wants char *.
16774
78320123
PE
16775 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
16776 if GCC considers string literals to be constants.
49cebcca 16777 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 16778
35ac2a97
SM
167792011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
16780
fb103ca9
SM
16781 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
16782 (print_preprocess, print_object): New macro to fix last change.
16783
35ac2a97
SM
16784 * print.c (print_preprocess): Don't forget font objects.
16785
62973b41
JB
167862011-03-16 Juanma Barranquero <lekktu@gmail.com>
16787
16788 * emacs.c (USAGE3): Doc fixes.
16789
0e48bb22
AS
167902011-03-15 Andreas Schwab <schwab@linux-m68k.org>
16791
16792 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
16793 structure.
16794
7684e57b
JB
167952011-03-14 Juanma Barranquero <lekktu@gmail.com>
16796
16797 * lisp.h (VWindow_system, Qfile_name_history):
16798 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
16799 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
16800 (w32_system_caret_x, w32_system_caret_y): Declare extern.
16801
16802 * w32select.c: Don't #include "keyboard.h".
c96bbc66 16803 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
16804
16805 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
16806 * w32console.c (detect_input_pending, read_input_pending)
16807 (encode_terminal_code):
16808 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
16809 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
16810 (w32_system_caret_y, Qfile_name_history):
16811 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
16812 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
16813 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
16814 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
16815 * w32proc.c (Qlocal, report_file_error):
16816 * w32term.c (Vwindow_system, updating_frame):
16817 * w32uniscribe.c (initialized, uniscribe_font_driver):
16818 Remove unneeded extern declarations.
16819
2aa46d6c
CY
168202011-03-14 Chong Yidong <cyd@stupidchicken.com>
16821
c96bbc66 16822 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 16823
cffc6f3b
CY
168242011-03-13 Chong Yidong <cyd@stupidchicken.com>
16825
16826 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
16827 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
16828 These macros can no longer be used for assignment.
16829
44f230aa
SM
16830 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
16831 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
16832 (record_buffer_markers, fetch_buffer_markers): New functions for
16833 recording and fetching special buffer markers.
16834 (set_buffer_internal_1, set_buffer_temp): Use them.
16835
16836 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
16837
16838 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
16839
16840 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
16841 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
16842
16843 * xdisp.c (hscroll_window_tree):
16844 (reconsider_clip_changes): Use PT instead of BUF_PT.
16845
d251f04b
EZ
168462011-03-13 Eli Zaretskii <eliz@gnu.org>
16847
16848 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
16849 $(EMACS_ROOT)/lib/intprops.h.
16850
f0c77cd1
PE
168512011-03-13 Paul Eggert <eggert@cs.ucla.edu>
16852
3eca4629
PE
16853 Fix more problems found by GCC 4.5.2's static checks.
16854
7c86ee98
PE
16855 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
16856 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
16857 (xg_free_frame_widgets): Make it clear that a local variable is
16858 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
16859 (gdk_window_get_screen): Make it clear that this macro is needed
16860 only if USE_GTK_TOOLTIP.
1e5524e7
PE
16861 (int_gtk_range_get_value): New function, which avoids a diagnostic
16862 from gcc -Wbad-function-cast.
16863 (xg_set_toolkit_scroll_bar_thumb): Use it.
16864 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
16865 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
16866 (get_utf8_string, xg_get_file_with_chooser):
16867 Rename locals to avoid shadowing.
16868 (create_dialog): Move locals to avoid shadowing.
7c86ee98 16869
41729b81
PE
16870 * xgselect.c (xg_select): Remove unused var.
16871
f0c77cd1
PE
16872 * image.c (four_corners_best): Mark locals as initialized.
16873 (gif_load): Initialize transparent_p to zero (Bug#8238).
16874 Mark another local as initialized.
ec6cf4c6 16875 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 16876
ce0ad53d 16877 * image.c (clear_image_cache): Now static.
d5d5a617 16878 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 16879 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
16880 (x_edge_detection): Remove unnecessary cast that
16881 gcc -Wbad-function-cast diagnoses.
2037898d 16882 (gif_load): Fix pointer signedness.
6ae141d6
PE
16883 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
16884 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 16885
33383987 168862011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 16887
d32df629
PE
16888 Improve quality of tests for time stamp overflow.
16889 For example, without this patch (encode-time 0 0 0 1 1
16890 1152921504606846976) returns the obviously-bogus value (-948597
16891 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
16892 reports time overflow. See
16893 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
16894 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
16895 * editfns.c: Include limits.h and intprops.h.
16896 (TIME_T_MIN, TIME_T_MAX): New macros.
16897 (time_overflow): Move earlier, to before first use.
16898 (hi_time, lo_time): New functions, for an accurate test for
16899 out-of-range times.
16900 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
16901 (Fget_internal_run_time): Don't assume time_t fits in int.
16902 (make_time): Use list2 instead of Fcons twice.
16903 (Fdecode_time): More accurate test for out-of-range times.
16904 (check_tm_member): New function.
16905 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
16906 (lisp_time_argument): Don't rely on undefined left-shift and
16907 right-shift behavior when checking for time stamp overflow.
8be6f318 16908
fe31d94c
PE
16909 * editfns.c (time_overflow): New function, refactoring common code.
16910 (Fformat_time_string, Fdecode_time, Fencode_time):
16911 (Fcurrent_time_string): Use it.
16912
8be6f318
PE
16913 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
16914 * dired.c (make_time): Move to ...
16915 * editfns.c (make_time): ... here.
16916 * systime.h: Note the move.
16917
09d9db2c 169182011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 16919
126bc0dc
YM
16920 * fringe.c (update_window_fringes): Remove unused variables.
16921
c47cbdfd
YM
16922 * unexmacosx.c (copy_data_segment): Also copy __got section.
16923 (Bug#8223)
16924
7ac80be9
EZ
169252011-03-12 Eli Zaretskii <eliz@gnu.org>
16926
c96bbc66 16927 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
16928 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
16929 Constify `char *' arguments and their references according to
16930 prototypes in tparam.h.
16931
ecb0f94d 16932 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 16933
7ac80be9
EZ
16934 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
16935 Adapt all references accordingly.
16936
16937 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
16938
ef1fd07e
TT
169392011-03-11 Tom Tromey <tromey@redhat.com>
16940
16941 * buffer.c (syms_of_buffer): Remove obsolete comment.
16942
7ef4b50c
EZ
169432011-03-11 Eli Zaretskii <eliz@gnu.org>
16944
16945 * termhooks.h (encode_terminal_code): Declare prototype.
16946
16947 * msdos.c (encode_terminal_code): Don't declare prototype.
16948
16949 * term.c (encode_terminal_code): Now external again, used by
16950 w32console.c and msdos.c.
16951
44f230aa
SM
16952 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
16953 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 16954
4b1ec863 169552011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 16956
1714f52b 16957 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 16958
4b1ec863
PE
16959 * fringe.c (update_window_fringes): Mark locals as initialized
16960 (Bug#8227).
16961 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 16962
524c7aa6
PE
16963 * alloc.c (mark_fringe_data): Move decl from here ...
16964 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
16965 to check its interface.
16966 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
16967
a5c0af81 16968 * fontset.c (free_realized_fontset): Now static.
7519b8cd 16969 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 16970 (fontset_font): Mark local as initialized.
a9a06e0b 16971 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 16972
b4716021
PE
16973 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
16974
811e9bac 16975 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 16976 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
16977 (x_own_selection, Fx_disown_selection_internal): Rename locals
16978 to avoid shadowing.
16979 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 16980
7e3ab302
PE
16981 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
16982 so that the caller can use some name other than gcpro1.
16983 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
16984 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
16985 (Fx_backspace_delete_keys_p):
16986 Use them to avoid shadowing, and rename vars to avoid shadowing.
16987 (x_decode_color, x_set_name, x_window): Now static.
6b437900 16988 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 16989 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
16990 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
16991 Remove unused locals.
7e3ab302
PE
16992 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
16993 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
16994 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
16995 macros.
f78faa98 16996
e2b13473
PE
16997 * xterm.h (x_mouse_leave): New decl.
16998
77f23912
PE
16999 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
17000 Remove unused functions.
cdf4ba58
PE
17001 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
17002 (x_calc_absolute_position): Now static.
7411c686 17003 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 17004 Don't declare local "event" unless it's used.
ed7bf3a5
PE
17005 (x_iconify_frame, x_free_frame_resources): Don't declare locals
17006 unless they are used.
38d0b34a
PE
17007 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
17008 (x_fatal_error_signal): Remove; not used.
a6067996
PE
17009 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
17010 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
17011 (x_error_catcher, x_connection_closed, x_error_handler):
17012 (x_error_quitter, xembed_send_message, x_iconify_frame):
17013 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 17014 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 17015 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 17016
44f230aa
SM
17017 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
17018 Rename or move locals to avoid shadowing.
6b463e58 17019 (tty_defined_color, merge_face_heights): Now static.
5967d051 17020 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
17021 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
17022 does not deduce is never used uninitialized.
73719eba
PE
17023 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
17024 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 17025
426994c3 17026 * terminal.c (store_terminal_param): Now static.
5489860b 17027
032f1620 17028 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 17029 (set_frame_menubar): Remove unused local.
d4323972 17030 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
17031 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
17032 since they might point to immutable storage.
281585b0
PE
17033 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
17034 since it's unused otherwise.
032f1620 17035
367c19e5 17036 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 17037 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
17038 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
17039 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 17040 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
17041 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
17042 does not deduce are never used uninitialized.
70739cbe 17043
07b48fa9
PE
17044 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
17045
8868a238 17046 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
17047 * window.c (window_loop, size_window):
17048 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 17049
7e5cf297 17050 * window.c (display_buffer): Now static.
d6550a9f
PE
17051 (size_window): Mark variables that gcc -Wuninitialized
17052 does not deduce are never used uninitialized.
a586633d
PE
17053 * window.h (check_all_windows): New decl, to forestall
17054 gcc -Wmissing-prototypes diagnostic.
5b555da1 17055 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 17056
f6095868
PE
17057 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
17058 shadowing.
17059 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
17060 Include <limits.h>.
17061 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
17062 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
17063 (load_charset_map): Mark variables that gcc -Wuninitialized
17064 does not deduce are never used uninitialized.
53df7c11 17065 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 17066
f38b440c
PE
17067 * coding.c (coding_set_source, coding_set_destination):
17068 Use "else { /* comment */ }" rather than "else /* comment */;"
17069 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
17070 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
17071 a block, when the outer 'i' will do.
17072 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
17073 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
17074 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
17075 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
17076 (Fdecode_sjis_char, Fdefine_coding_system_internal):
17077 Rename locals to avoid shadowing.
17078 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
17079 * coding.c (emacs_mule_char, encode_invocation_designation):
17080 Now static, since they're not used elsewhere.
413bb2db 17081 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 17082 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
17083 (decode_coding_emacs_mule): Mark variables that gcc
17084 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
17085 (detect_coding_iso_2022): Initialize a local variable that might
17086 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 17087 this initialization is needed. (Bug#8211)
5f58e762
PE
17088 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
17089 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
17090 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
17091 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
17092 Remove unused macros.
f38b440c 17093
232b38b9 17094 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 17095 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 17096 * character.c (string_count_byte8): Likewise.
232b38b9 17097
fb90da1b
PE
17098 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
17099 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
17100
fb93dbc2
PE
17101 * chartab.c (copy_sub_char_table): Now static, since it's not used
17102 elsewhere.
5c156ace
PE
17103 (sub_char_table_ref_and_range, char_table_ref_and_range):
17104 Rename locals to avoid shadowing.
bbcd0949 17105 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 17106
7d3b3862 17107 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 17108 (BIDI_BOB): Remove unused macro.
7d3b3862 17109
6be7d3da
PE
17110 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
17111 deduce are never used uninitialized.
c2ed9c8b 17112 * term.c (encode_terminal_code): Likewise.
6be7d3da 17113
75f8807f 17114 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 17115
50938595
PE
17116 * tparam.h: New file.
17117 * term.c, tparam.h: Include it.
17118 * deps.mk (term.o, tparam.o): Depend on tparam.h.
17119 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
17120 Move these decls to tparam.h, and make them agree with what
17121 is actually in tparam.c. The previous trick of using incompatible
17122 decls in different modules does not conform to the C standard.
17123 All callers of tparam changed to use tparam's actual API.
17124 * tparam.c (tparam1, tparam, tgoto):
17125 Use const pointers where appropriate.
17126
fbceeba2
PE
17127 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
17128 * cm.h (struct cm): Likewise.
17129 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
17130 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
17131 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
17132 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
17133 (turn_on_face, init_tty): Likewise.
17134 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 17135
7f3f1250
PE
17136 * term.c (term_mouse_position): Rename local to avoid shadowing.
17137
e6ca6543
PE
17138 * alloc.c (mark_ttys): Move decl from here ...
17139 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
17140
c40f8d15
AS
171412011-03-11 Andreas Schwab <schwab@linux-m68k.org>
17142
17143 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
17144
cfe0661d
JB
171452011-03-09 Juanma Barranquero <lekktu@gmail.com>
17146
17147 * search.c (compile_pattern_1): Remove argument regp, unused since
17148 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
17149 (compile_pattern): Don't pass it.
17150
0afb4571
J
171512011-03-08 Jan Djärv <jan.h.d@swipnet.se>
17152
17153 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
17154 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
17155 for ! HAVE_GTK3.
17156 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
17157
17158 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
17159
17160 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
17161 gdk_window_get_screen, gdk_window_get_geometry,
17162 gdk_x11_window_lookup_for_display and GDK_KEY_g.
17163 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
17164 (xg_get_pixbuf_from_pixmap): New function.
17165 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
17166 to Pixmap, take frame as parameter, remove GdkColormap parameter.
17167 Call xg_get_pixbuf_from_pixmap instead of
17168 gdk_pixbuf_get_from_drawable.
17169 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
17170 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
17171 (xg_check_special_colors): Use GtkStyleContext and its functions
17172 for HAVE_GTK3.
17173 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
17174 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
17175 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
17176 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
17177 Call gtk_widget_get_preferred_size.
0afb4571
J
17178 (xg_frame_resized): gdk_window_get_geometry only takes 5
17179 parameters.
44f230aa
SM
17180 (xg_win_to_widget, xg_event_is_for_menubar):
17181 Call gdk_x11_window_lookup_for_display.
0afb4571
J
17182 (xg_set_widget_bg): New function.
17183 (delete_cb): New function.
895009e1 17184 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 17185 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
17186 (xg_set_background_color): Call xg_set_widget_bg.
17187 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
17188 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
17189 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
17190 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
17191 if ! HAVE_GTK3.
17192 (update_frame_tool_bar): Call gtk_widget_hide.
17193 (xg_initialize): Use GDK_KEY_g.
17194
17195 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
17196 if ! HAVE_GTK3
17197 (x_session_initialize): Call gdk_x11_set_sm_client_id.
17198
17199 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
17200 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
17201 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
17202
1c2cc4ef
JB
172032011-03-08 Juanma Barranquero <lekktu@gmail.com>
17204
17205 * w32xfns.c (select_palette): Check success of RealizePalette against
17206 GDI_ERROR, not zero.
17207
33383987 17208See ChangeLog.11 for earlier changes.
aac0c6e3
MR
17209
17210;; Local Variables:
17211;; coding: utf-8
aac0c6e3
MR
17212;; End:
17213
2f097256 17214 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
17215
17216 This file is part of GNU Emacs.
17217
17218 GNU Emacs is free software: you can redistribute it and/or modify
17219 it under the terms of the GNU General Public License as published by
17220 the Free Software Foundation, either version 3 of the License, or
17221 (at your option) any later version.
17222
17223 GNU Emacs is distributed in the hope that it will be useful,
17224 but WITHOUT ANY WARRANTY; without even the implied warranty of
17225 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
17226 GNU General Public License for more details.
17227
17228 You should have received a copy of the GNU General Public License
17229 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.