newsticker: automatically load html rendering packages.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
e3cbd34b
EZ
12011-09-24 Eli Zaretskii <eliz@gnu.org>
2
3 * indent.c (Fvertical_motion): Compute and apply the overshoot
4 logic when moving up, not only when moving down. Fix the
5 confusing name and values of the it_overshoot_expected variable;
6 logic changes accordingly. (Bug#9254) (Bug#9549)
7
8 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
9 CHARPOS is covered by a display string which includes newlines.
10 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
11 is covered by a display string with embedded newlines.
12
a3de0cbd
MA
132011-09-24 Michael Albinus <michael.albinus@gmx.de>
14
15 * dbusbind.c (Fdbus_register_signal): Add match rule to
16 Vdbus_registered_objects_table. (Bug#9581)
17 (Fdbus_register_method, Vdbus_registered_objects_table): Fix
18 docstring.
19
b260039d
JM
202011-09-24 Jim Meyering <meyering@redhat.com>
21
22 do not ignore write error for any output size
23 The previous change was incomplete.
24 While it makes emacs --batch detect the vast majority of stdout
25 write failures, errors were still ignored whenever the output size is
26 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
27 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
28 && echo FAIL: ignored write error
29 FAIL: ignored write error
30 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
31 && echo FAIL: ignored write error
32 FAIL: ignored write error
33 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
34
8eca8a7c
AS
352011-09-23 Andreas Schwab <schwab@linux-m68k.org>
36
37 * emacs.c (Fkill_emacs): In noninteractive mode exit
38 non-successfully if a write error occurred on stdout. (Bug#9574)
39
3341db62
EZ
402011-09-21 Eli Zaretskii <eliz@gnu.org>
41
42 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
43 the xassert test.
44
45 * dispextern.h (struct it): Update the comment documenting what
46 can it->OBJECT be.
47
8c203dbf
EZ
482011-09-20 Eli Zaretskii <eliz@gnu.org>
49
50 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
51 a display string, extend search for cursor position to end of row.
52 (find_row_edges): If the row ends in a newline from a display
53 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
54 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
55 (Fcurrent_bidi_paragraph_direction): Fix search for previous
56 non-empty line. Fixes confusing cursor motion with arrow keys at
57 the beginning of a line that starts with whitespace.
8c203dbf 58
a4824228
LMI
592011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
60
61 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
62 (bug#9493).
63
33ed493b
CY
642011-09-18 Chong Yidong <cyd@stupidchicken.com>
65
66 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
67 boolean (Bug#9154).
68
56cd55c8
EZ
692011-09-18 Eli Zaretskii <eliz@gnu.org>
70
71 * xdisp.c (display_line): Record maximum and minimum buffer
72 positions even if no glyphs were produced (e.g., by a zero-width
73 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
74 buffer positions that will be removed from the glyph row because
75 they don't fit.
c02dcedf
EZ
76 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
77 column is beyond frame width: don't subtract 1 "pixel" when
78 computing width of the stretch.
3e62b7e0
EZ
79 (reseat_at_next_visible_line_start): Undo the change made on
80 2011-09-17 that saved paragraph information and restored it after
81 the call to `reseat'. (Bug#9545)
56cd55c8 82
5ed99d36 832011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
84
85 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
86 and turn window cursor on if cleared (Bug#9415).
87
5ed99d36 882011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
89
90 * search.c (boyer_moore): Take unibyte characters from pattern
91 literally. (Bug#9458)
92
9bade7b2
EZ
932011-09-18 Eli Zaretskii <eliz@gnu.org>
94
95 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
96
e5e9d610
PE
972011-09-18 Paul Eggert <eggert@cs.ucla.edu>
98
87e4427a
PE
99 Fix minor problem found by static checking.
100 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
101 initialized, to pacify gcc -Wuninitialized.
102
e5e9d610
PE
103 * fileio.c: Report proper errno when syscall falls.
104 (Finsert_file_contents): Save and restore errno,
105 so that report_file_error outputs the correct diagnostic.
106 (Fwrite_region) [CLASH_DETECTION]: Likewise.
107
a1674f0b
EZ
1082011-09-18 Eli Zaretskii <eliz@gnu.org>
109
110 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
111
fbfb6dd4
EZ
1122011-09-17 Eli Zaretskii <eliz@gnu.org>
113
114 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
115 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
116
bb187662
EZ
1172011-09-17 Eli Zaretskii <eliz@gnu.org>
118
1137e8b8
EZ
119 * xdisp.c (reseat_at_next_visible_line_start): Keep information
120 about the current paragraph and restore it after the call to
121 reseat.
122
123 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
124 (bidi_find_paragraph_start): Search back for paragraph beginning
125 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
126 (bidi_move_to_visually_next): Only trigger paragraph-related
127 computations when the last character is a newline or at EOB, not
128 just any NEUTRAL_B. (Bug#9470)
129
bb187662
EZ
130 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
131 truncated lines if point is covered by a display string. (Bug#9524)
132
2e621251
PE
1332011-09-16 Paul Eggert <eggert@cs.ucla.edu>
134
135 * xselect.c: Relax test for outgoing X longs (Bug#9498).
136 (cons_to_x_long): New function.
137 (lisp_data_to_selection_data): Use it. Correct the test for
138 short-versus-long data; it was negated. Break out of vector
139 loop, for efficiency, when a long datum is discovered.
140
91a15bc6
SM
1412011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
142
143 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
144
b41c3a35
EZ
1452011-09-16 Eli Zaretskii <eliz@gnu.org>
146
147 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
148 GCC PR/17406) by declaring this function with external scope.
149
7812ba2d
PE
1502011-09-15 Paul Eggert <eggert@cs.ucla.edu>
151
152 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
153 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
154
cf7edc2a
AS
1552011-09-15 Andreas Schwab <schwab@linux-m68k.org>
156
157 * editfns.c (Fformat): Correctly handle text properties on "%%".
158
bd01620e
EZ
1592011-09-15 Eli Zaretskii <eliz@gnu.org>
160
161 * xterm.c (x_draw_composite_glyph_string_foreground):
162 * w32term.c (x_draw_composite_glyph_string_foreground):
163 * term.c (encode_terminal_code):
164 * composite.c (composition_update_it, get_composition_id):
165 * xdisp.c (get_next_display_element)
166 (fill_composite_glyph_string): Add comments about special meaning
167 of TAB characters in a composition.
168
a02719a3
PE
1692011-09-15 Paul Eggert <eggert@cs.ucla.edu>
170
171 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
172 This occurs when processing a multibyte format.
173 Problem reported by Wolfgang Jenker.
a02719a3 174
72589a3c
JB
1752011-09-15 Johan Bockgård <bojohan@gnu.org>
176
177 * xdisp.c (try_cursor_movement): Only check for exact match if
178 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
179
1c14176c
PE
1802011-09-14 Paul Eggert <eggert@cs.ucla.edu>
181
182 Remove unused external symbols.
183 * dispextern.h (calc_pixel_width_or_height): Remove decl.
184 * xdisp.c (calc_pixel_width_or_height): Now static.
185 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
186 * indent.c (check_display_width):
187 * w32term.c: Fix comment to match code.
188 * xterm.c, xterm.h (x_catching_errors): Remove.
189
d2eea5b5
PE
1902011-09-14 Paul Eggert <eggert@cs.ucla.edu>
191
192 * xselect.c: Use signed conversions more consistently (Bug#9498).
193 (selection_data_to_lisp_data): Assume incoming selection data are
194 signed integers, not unsigned. This is to be consistent with
195 outgoing selection data, which was modified to use signed integers
196 in as part of the fix to Bug#9196 in response to Jan D.'s comment
197 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
198 expects long, not unsigned long.
199
46888499
EZ
2002011-09-14 Eli Zaretskii <eliz@gnu.org>
201
202 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
203 computation of loop end. Reported by Johan Bockgård
204 <bojohan@gnu.org>.
205
ef8ef9fb
CY
2062011-09-13 Chong Yidong <cyd@stupidchicken.com>
207
208 * frame.c (Fother_visible_frames_p): Function deleted.
209
fa819fed
EZ
2102011-09-12 Eli Zaretskii <eliz@gnu.org>
211
212 * indent.c (compute_motion): Process display vector front to back
213 rather than the other way around. (Bug#2496)
214
2ba8e008
SM
2152011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
216
217 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
218
20f53c69
CY
2192011-09-11 Chong Yidong <cyd@stupidchicken.com>
220
221 * minibuf.c (Fread_from_minibuffer): Doc fix.
222
d562d7a4
EZ
2232011-09-11 Eli Zaretskii <eliz@gnu.org>
224
225 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
226 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
227
1c4d7f3d
LMI
2282011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
229
230 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
231 value for non-existent files.
232
b885bf36
EZ
2332011-09-11 Eli Zaretskii <eliz@gnu.org>
234
235 * fileio.c (Finsert_file_contents): If the file cannot be opened,
236 set its "size" to -1. This will set the modtime_size field of
237 the corresponding buffer to -1, which is what
238 verify-visited-file-modtime expects for files that do not exist.
239 (Bug#9139)
240
6612f0bf
PE
2412011-09-11 Paul Eggert <eggert@cs.ucla.edu>
242
243 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
244 here ...
245 * lisp.h: ... from here. push_key_description is no longer
246 defined in keyboard.c, so its declaration should not be in
247 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
248 logically belongs with push_key_description.
249
dfb3f755
PE
2502011-09-10 Paul Eggert <eggert@cs.ucla.edu>
251
252 * buffer.h: Include <sys/types.h> instead of <time.h>.
253 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
254 Problem reported by Herbert J. Skuhra.
255
3134906c
LMI
2562011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
257
258 * xml.c (parse_region): Make the parsing work for
259 non-comment-starting XML files again (bug#9144).
260
8d903f4e
AS
2612011-09-10 Andreas Schwab <schwab@linux-m68k.org>
262
263 * image.c (gif_load): Fix calculation of bottom and right corner.
264 (Bug#9468)
265
80ad64f4
EZ
2662011-09-10 Eli Zaretskii <eliz@gnu.org>
267
268 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
269 redisplay in small windows.
270
208a048d
EZ
2712011-09-09 Eli Zaretskii <eliz@gnu.org>
272
273 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
274
9b1c252e
MR
2752011-09-08 Martin Rudalics <rudalics@gmx.at>
276
277 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
278 Operate on live windows only.
279
2949f33b
JB
2802011-09-08 Juanma Barranquero <lekktu@gmail.com>
281
282 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
283
e08dcafd
EZ
2842011-09-07 Eli Zaretskii <eliz@gnu.org>
285
286 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
287 only under bidi iteration.
288
115b96bd
JD
2892011-09-07 Jan Djärv <jan.h.d@swipnet.se>
290
291 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
292
c8199d0f
PE
2932011-09-06 Paul Eggert <eggert@cs.ucla.edu>
294
295 isnan: Fix porting problem to Solaris 10 with bundled gcc.
296 Without this fix, the command to link temacs failed due to an
297 undefined symbol __builtin_isnan. This is because
298 /usr/include/iso/math_c99.h #defines isnan(x) to
299 __builtin_isnan(x), but the bundled gcc, which identifies itself
300 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
301 a __builtin_isnan.
302 * floatfns.c (isnan): #undef, and then #define to a clone of
303 what's in data.c.
304 (Fisnan): Always define, since it's always available now.
305 (syms_of_floatfns): Always define isnan at the Lisp level.
306
e39b275c 3072011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
308
309 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
310
b2db44d9 3112011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 312
f4af5137 313 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
314 The previous code assumed that file offsets (off_t values) fit in
315 EMACS_INT variables, which is not true on typical 32-bit hosts.
316 The code messed up by falsely reporting buffer overflow in cases
317 such as (insert-file-contents "big" nil 1 2) into an empty buffer
318 when "big" contains more than 2**29 bytes, even though this
319 inserts just one byte and does not overflow the buffer.
320 (Finsert_file_contents): Store file offsets as off_t
321 values, not as EMACS_INT values. Check for overflow when
322 converting between EMACS_INT and off_t. When checking for
323 buffer overflow or for overlap, take the offsets into account.
324 Don't use EMACS_INT for small values where int suffices.
325 When checking for overlap, fix a typo: ZV was used where
326 ZV_BYTE was intended.
327 (Fwrite_region): Don't assume off_t fits into 'long'.
328 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
329
ecfc0a49
MA
3302011-09-05 Michael Albinus <michael.albinus@gmx.de>
331
332 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
333
6511acf2 3342011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 335
0999621a 336 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
337
338 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 339 (esprintf, exprintf, evxprintf): New functions.
62f19c19
PE
340 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
341 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
342 (modify_event_symbol): Do not assume that the length of
343 name_alist_or_stem is safe to alloca and fits in int.
344 (Fexecute_extended_command): Likewise for function name and binding.
345 (Frecursion_depth): Wrap around reliably on integer overflow.
346 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
347 since some callers pass EMACS_INT values.
348 (Fsingle_key_description): Don't crash if symbol name contains more
349 than MAX_ALLOCA bytes.
350 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
351 (get_minibuffer): Arg is now EMACS_INT, not int.
352 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 353 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
354 * window.h (command_loop_level, minibuf_level): Reflect API changes.
355
2be7d702
PE
356 * dbusbind.c (signature_cat): New function.
357 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
358 Do not overrun buffer; instead, report string overflow.
359
9d1df220
PE
360 * dispnew.c (add_window_display_history): Don't overrun buffer.
361 Truncate instead; this is OK since it's just a log.
362
33ef5c64
PE
363 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
364 even if the time zone offset is outlandishly large.
365 Don't mishandle offset == INT_MIN.
366
66c6fdd5
PE
367 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
368 when creating daemon; the previous buffer-overflow check was incorrect.
369
d749b01b
PE
370 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
371 which has the guts of the old verror function.
372
b5cd1905
PE
373 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
374 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
375
6e1a67fb
PE
376 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
377 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 378 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 379 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
380 length of string rather than counting it via multiple sprintfs;
381 that's simpler and more reliable.
c21721cc
PE
382 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
383 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
384 sprintf, in case result does not fit in int.
385
c57b67fc
PE
386 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
387 (fontset_from_font): Print it.
388
8a401434
PE
389 * frame.c (tty_frame_count): Now printmax_t, not int.
390 (make_terminal_frame, set_term_frame_name): Print it.
391 (x_report_frame_params): In X, window IDs are unsigned long,
392 not signed long, so print them as unsigned.
393 (validate_x_resource_name): Check for implausibly long names,
394 and don't assume name length fits in 'int'.
395 (x_get_resource_string): Don't blindly alloca invocation name;
396 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
397 not fit in int.
398
6e1a67fb
PE
399 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
400 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
401 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
402
0df02bf3
PE
403 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
404 Use esprintf, not sprintf, in case result does not fit in int.
405
48e30793
PE
406 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
407 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
408 it as a large positive number.
409 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
410 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
411
a66ff6d8
PE
412 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
413 in case result does not fit in int.
414
aca216ff
PE
415 * print.c (float_to_string): Detect width overflow more reliably.
416 (print_object): Make sprintf buffer a bit bigger, to avoid potential
417 buffer overrun. Don't assume list length fits in 'int'. Treat
418 print length of 0 as 0, not as infinity; to be consistent with other
419 uses of print length in this function. Don't overflow print length
420 index. Don't assume hash table size fits in 'long', or that
421 vectorlike size fits in 'unsigned long'.
422
31c286f7
PE
423 * process.c (make_process): Use printmax_t, not int, to format
424 process-name gensyms.
425
55e5faa1
PE
426 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
427
80f2e268
PE
428 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
429 to avoid potential buffer overrun.
430
670741ab
PE
431 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
432 if X resource line is longer than 512 bytes.
433
b7163a50
PE
434 * xfns.c (x_window): Make sprintf buffer a bit bigger
435 to avoid potential buffer overrun.
436
ae58ff1f
PE
437 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
438
c43c8a6a
PE
439 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
440
3f8236f4
PE
4412011-09-04 Paul Eggert <eggert@cs.ucla.edu>
442
53e9fe90 443 Integer overflow fixes for scrolling, etc.
6511acf2
PE
444 Without these, Emacs silently mishandles large integers sometimes.
445 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
446 it were "C-u 1 M-x recenter" on a typical 64-bit host.
447
6511acf2
PE
448 * xdisp.c (try_window_id): Check Emacs fixnum range before
449 converting to 'int'.
806add1d 450
6511acf2 451 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
452 Check that an Emacs fixnum is in range before assigning it to 'int'.
453 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
454 values converted from Emacs fixnums.
455 (Frecenter): Don't wrap around a line count if it is out of 'int'
456 range; instead, treat it as an extreme value.
457 (Fset_window_configuration, compare_window_configurations):
458 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
459
6511acf2
PE
460 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
461 that can exceed INT_MAX. Check that EMACS_INT value is in range
462 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
463 (match_limit): Don't assume that a fixnum can fit in 'int'.
464
6511acf2 465 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
466 exceed INT_MAX.
467
6511acf2 468 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
469 (Fvertical_motion): Don't wrap around LINES values that don't fit
470 in 'int'. Instead, treat them as extreme values. This is good
471 enough for windows, which can't have more than INT_MAX lines anyway.
472
fcb901a7
LMI
4732011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
474
0f2f6b6d
LMI
475 * Require libxml/parser.h to avoid compilation warning.
476
fcb901a7
LMI
477 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
478
479 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
480 since this reportedly can destroy thread storage.
481
6e20a0d4
CY
4822011-08-30 Chong Yidong <cyd@stupidchicken.com>
483
484 * syntax.c (find_defun_start): Update all cache variables if
485 exiting early (Bug#9401).
486
148ae00e
EZ
4872011-08-30 Eli Zaretskii <eliz@gnu.org>
488
f6cfbd8f
EZ
489 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
490
148ae00e
EZ
491 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
492 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
493 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
494
495 * term.c (tty_append_glyph): New function.
496 (produce_stretch_glyph): Static function and its prototype deleted.
497
498 * dispextern.h (produce_stretch_glyph, tty_append_glyph): Add
499 prototypes.
500
c4a07a4c
PE
5012011-08-29 Paul Eggert <eggert@cs.ucla.edu>
502
503 * image.c (parse_image_spec): Check for nonnegative, not for positive,
504 when checking :margin (Bug#9390).
505 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
506 Renamed from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
507 so that the name doesn't mislead. All uses changed.
508
6bc8cd65
JB
5092011-08-28 Johan Bockgård <bojohan@gnu.org>
510
511 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
512 set_tty_hooks.
513
dca4927e
EZ
5142011-08-27 Eli Zaretskii <eliz@gnu.org>
515
516 * xdisp.c (move_it_to): Don't bail out early when reaching
517 position beyond to_charpos, if we are scanning backwards.
518 (move_it_vertically_backward): When DY == 0, make sure we get to
519 the first character in the line after the newline.
520
f2cad773
PE
5212011-08-27 Paul Eggert <eggert@cs.ucla.edu>
522
523 * ccl.c: Improve and simplify overflow checking (Bug#9196).
524 (ccl_driver): Do not generate an out-of-range pointer.
525 (Fccl_execute_on_string): Remove unnecessary check for
526 integer overflow, noted by Stefan Monnier in
527 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
528 Remove a FIXME that didn't need fixing.
529 Simplify the newly-introduced buffer reallocation code.
530
0cae2cdb
JB
5312011-08-27 Juanma Barranquero <lekktu@gmail.com>
532
533 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
534
5fc295a4 5352011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 536
70c60eb2 537 Integer and memory overflow issues (Bug#9196).
726e0ab1 538
d31850da
PE
539 * doc.c (get_doc_string): Rework so that
540 get_doc_string_buffer_size is the actual buffer size, rather than
541 being 1 less than the actual buffer size; this makes xpalloc more
542 convenient.
543
a69fbedb
PE
544 * image.c (x_allocate_bitmap_record, cache_image):
545 * xselect.c (Fx_register_dnd_atom):
546 Simplify previous changes by using xpalloc.
547
fe5c5d37
PE
548 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
549 since either will do and ptrdiff_t is convenient with xpalloc.
550
0065d054
PE
551 * charset.c (charset_table_size)
552 (struct charset_sort_data.priority): Now ptrdiff_t.
553 (charset_compare): Don't overflow if priorities differ greatly.
554 (Fsort_charsets): Don't assume list length fits in int.
555 Check for size-calculation overflow when allocating sort data.
556 (syms_of_charset): Allocate an initial charset table that is
557 just under 64 KiB, to avoid problems with glibc malloc and mmap.
558
559 * cmds.c (internal_self_insert): Check for size-calculation overflow.
560
561 * composite.h (struct composition.glyph_len): Now int, not unsigned.
562 The actual value is always <= INT_MAX, and leaving it unsigned made
563 overflow checking harder.
564
565 * dispextern.h (struct glyph_matrix.rows_allocated)
566 (struct face_cache.size): Now ptrdiff_t, for convenience in use
567 with xpalloc. The values are still always <= INT_MAX.
568
569 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
570
571 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
572 (SAFE_NALLOCA): New macro.
573
574 * region-cache.c (struct boundary.pos, find_cache_boundary)
575 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
576 (set_cache_region, invalidate_region_cache)
577 (revalidate_region_cache, know_region_cache, region_cache_forward)
578 (region_cache_backward, pp_cache):
579 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
580 so that ptrdiff_t * can be passed to xpalloc.
581 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
582 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
583 (pp_cache): Don't assume cache_len fits in int.
584 * region-cache.h: Adjust extern decls to match.
585
586 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
587 EMACS_INT, since either will do, for xpalloc.
588
589 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
590 (xnmalloc, xnrealloc, xpalloc): New functions.
591
726e0ab1
PE
592 * bidi.c (bidi_shelve_header_size): New constant.
593 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
594 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
595
51f30bc5 596 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
597 * buffer.c (overlays_at, overlays_in, record_overlay_string)
598 (overlay_strings):
599 Don't update size of array until after memory allocation succeeds,
600 because xmalloc/xrealloc may not return.
0065d054
PE
601 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
602 now that we have proper integer overflow checking.
603 (record_overlay_string, overlay_strings): Catch overflows when
604 calculating size of overlay_str_buf.
726e0ab1 605
0065d054
PE
606 * callproc.c (Fcall_process): Check for size overflow when
607 calculating size of args2.
608 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
609 Normally we prefer signed values, but sticking with ptrdiff_t would
610 require adding more-complicated checks.
726e0ab1
PE
611
612 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
613 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
614 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 615 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
616
617 * character.c (Fstring): Check for size-calculation overflow.
618
619 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
620 unnecessary integer overflow. Check for size overflow.
621 (encode_coding_object): Don't update size until xmalloc succeeds.
622
623 * composite.c (get_composition_id): Check for overflow in glyph
624 length calculations.
625
626 Integer and memory overflow fixes for display code.
627 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
628 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
629 (scrolling_window): Check for overflow in size calculations.
630 (line_draw_cost, realloc_glyph_pool, add_row_entry):
631 Don't assume glyph table len fits in int.
632 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
633 (row_table_size): Now ptrdiff_t, not int.
634 (scrolling_window): Avoid overflow in size calculations.
635 Don't update size until allocation succeeds.
636 * fns.c (concat): Check for overflow in size calculations.
637 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
638 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
639 (NEXT_ALMOST_PRIME_LIMIT): New constant.
640
641 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
642 (get_doc_string): Check for size calculation overflow.
643 Don't update size until allocation succeeds.
644 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
645 EMACS_INT, where ptrdiff_t will do.
646 (Fsubstitute_command_keys): Check for string overflow.
647
648 * editfns.c (set_time_zone_rule): Don't assume environment length
649 fits in int.
650 (message_length): Now ptrdiff_t, not int.
651 (Fmessage_box): Don't update size until allocation succeeds.
652 Don't assume message length fits in int.
653 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
654
0065d054
PE
655 * emacs.c (main): Do not reallocate argv, since there is a null at
656 the end that can be overwritten, and this way there's no need to
657 worry about size-calculation overflow.
658 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
659
660 * eval.c (init_eval_once, grow_specpdl): Don't update size until
661 alloc succeeds.
662 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
663
664 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
665 (x_set_scroll_bar_width, x_figure_window_size):
666 Check for integer overflow.
667 (x_set_alpha): Do not assume XINT fits in int.
668
669 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
670 This is for the members text_lines, text_cols, total_lines, total_cols,
671 where the system imposes an 'int' limit.
672
673 * fringe.c (Fdefine_fringe_bitmap):
674 Don't update size until alloc works.
675
676 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
677 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
678
679 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
680 Check for size-calculation overflow.
681 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
682 do, as we prefer signed integers.
683 (id_to_widget.max_size, id_to_widget.used)
684 (xg_store_widget_in_map, xg_remove_widget_from_map)
685 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
686 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
687 Use and return ptrdiff_t, not int.
688 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
689 * gtkutil.h: Change prototypes to match the above.
690
691 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
692 are duplicate now that they've been promoted to lisp.h.
693 (x_allocate_bitmap_record, x_alloc_image_color)
694 (make_image_cache, cache_image, xpm_load):
695 Don't update size until alloc is done.
696 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
697 (x_detect_edges):
3256efce 698 Check for size calculation overflow.
726e0ab1
PE
699 (ct_colors_allocated_max): New constant.
700 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
701 overflow.
3256efce 702
726e0ab1
PE
703 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
704 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
705 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
706 Use ptrdiff_t, not int, to count maps.
707 (read_char_minibuf_menu_prompt): Check for overflow in size
708 calculations. Don't update size until allocation succeeds. Redo
709 calculations to avoid overflow.
710 * keyboard.h: Change prototypes to match the above.
711
712 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
713 to count maps.
714 (current_minor_maps): Check for size calculation overflow.
715 * keymap.h: Change prototypes to match the above.
716
717 * lread.c (read1, init_obarray): Don't update size until alloc done.
718
719 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
720 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
721
726e0ab1
PE
722 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
723 Now ptrdiff_t, not int.
724 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
725 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
726
727 * process.c (Fnetwork_interface_list): Check for overflow
728 in size calculation.
729
730 * region-cache.c (move_cache_gap): Check for size calculation overflow.
731
732 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
733 overflow. Don't bother calling xmalloc when xrealloc will do.
734
735 * search.c (Freplace_match): Check for size calculation overflow.
736 (Fset_match_data): Don't assume list lengths fit in 'int'.
737
738 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
739 for command line length. Do not attempt to address one before the
740 beginning of an array, as that's not portable.
741
742 * term.c (max_frame_lines): Remove; unused.
743 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
744 not int.
745 (encode_terminal_code, calculate_costs): Check for size
746 calculation overflow.
747 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
748 table lengths and related sizes. Don't update size until alloc
749 done. Redo calculations to avoid overflow.
750 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
751
752 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
753 subtracting pointers.
754 (gobble_line): Check for overflow more carefully. Don't update size
755 until alloc done.
756
757 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
758 Don't update size until alloc done.
759 Redo size calculations to avoid overflow.
760 Check for size calculation overflow.
0065d054 761 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
762
763 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
764 Use ptrdiff_t, not int, for sizes.
765 (store_mode_line_noprop_char): Don't update size until alloc done.
766
0065d054
PE
767 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
768 Use ptrdiff_t, not int, for sizes.
769 (Finternal_make_lisp_face, cache_face):
770 Check for size calculation overflow.
771 (cache_face): Treat size calculation overflows as if they were
772 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
773
774 * xfns.c (x_encode_text, x_set_name_internal)
775 (Fx_change_window_property): Use ptrdiff_t, not int, to count
776 sizes, since they can exceed INT_MAX in size. Check for size
777 calculation overflow.
778
0065d054
PE
779 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
780 (xg_select): Check for size calculation overflow.
726e0ab1
PE
781 Don't update size until alloc done.
782
0065d054 783 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 784 as sprintf is limited to int lengths.
1d526e2f 785
252c5ee1
PE
786 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
787 (X_LONG_MIN): New macros.
864d7ce7
PE
788 Use them to make the following changes clearer.
789 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
790 This change doesn't affect the value now, but it may help remind
791 future maintainers not to raise the value too much later.
792 (SELECTION_QUANTUM): Remove, replacing with ...
793 (selection_quantum): ... new function, which avoids overflow.
794 All uses changed.
795 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
796 assumption that selection length fits in 'int'.
797 (x_reply_selection_request, x_handle_selection_request)
798 (x_get_window_property, receive_incremental_selection)
799 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
800 (lisp_data_to_selection_data, clean_local_selection_data):
801 Use ptrdiff_t, not int, to record length of selection.
802 (x_reply_selection_request, x_get_window_property)
803 (receive_incremental_selection, x_property_data_to_lisp):
804 Redo calculations to avoid overflow.
805 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 806 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
807 something.
808 (x_get_window_property, receive_incremental_selection)
809 (lisp_data_to_selection_data, x_property_data_to_lisp):
810 Check for size-calculation overflow.
811 (x_get_window_property, receive_incremental_selection)
812 (lisp_data_to_selection_data, Fx_register_dnd_atom):
813 Don't store size until memory allocation succeeds.
814 (x_get_window_property): Plug memory leak on memory exhaustion.
815 Don't double-block input; malloc is safe here. Don't assume 2**34
816 - 4 fits in unsigned long. Add an xassert to check
817 XGetWindowProperty overflow. Be more careful about overflow
818 calculations, and distinguish size from memory overflow better.
819 (receive_incremental_selection): When tracing, don't assume
820 unsigned int is less than INT_MAX.
821 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
822 harmful) conversions of unsigned short to int.
823 (lisp_data_to_selection_data): Don't assume that integers
824 in the range -65535 through -1 fit in an X unsigned short.
825 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
826 result parameters unless successful. Rely on cons_to_unsigned
827 to report problems with elements; the old code wasn't right anyway.
828 (x_check_property_data): Check for int overflow; we cannot use
829 a wider type due to X limits.
830 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
831
726e0ab1 832 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 833
0065d054
PE
834 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
835 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
836 (x_color_cells): Don't store size until memory allocation succeeds.
837 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 838 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
839 (x_term_init): Don't assume length fits in int (sprintf is limited
840 to int size).
bc18e09d 841
ebfa62c0
PE
842 Use ptrdiff_t for composition IDs.
843 * character.c (lisp_string_width):
844 * composite.c (composition_table_size, n_compositions)
845 (get_composition_id, composition_gstring_from_id):
846 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
847 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
848 * window.c (Frecenter):
849 Use ptrdiff_t, not int, for composition IDs.
850 * composite.c (get_composition_id): Check for integer overflow.
851 * composite.h: Adjust prototypes to match the above changes.
852
d3411f89
PE
853 Use ptrdiff_t for hash table indexes.
854 * category.c (hash_get_category_set):
855 * ccl.c (ccl_driver):
856 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
857 * coding.c (coding_system_charset_list, detect_coding_system):
858 * coding.h (struct coding_system.id):
859 * composite.c (get_composition_id, gstring_lookup_cache):
860 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
861 * image.c (xpm_get_color_table_h):
862 * lisp.h (hash_lookup, hash_put):
863 * minibuf.c (Ftest_completion):
864 Use ptrdiff_t for hash table indexes, not int (which is too
865 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
866 32-bit --with-wide-int hosts).
867
e097a6fa
PE
868 * charset.c (Fdefine_charset_internal): Check for integer overflow.
869 Add a FIXME comment about memory leaks.
870 (syms_of_charset): Don't assume xmalloc returns.
871
5637687f
PE
872 Don't assume that stated character widths fit in int.
873 * character.c (Fchar_width, c_string_width, lisp_string_width):
874 * character.h (CHAR_WIDTH):
875 * indent.c (MULTIBYTE_BYTES_WIDTH):
876 Use sanitize_char_width to avoid undefined and/or bad behavior
877 with outlandish widths.
878 * character.h (sanitize_tab_width): Renamed from sanitize_width,
879 now that we have two such functions. All uses changed.
880 (sanitize_char_width): New inline function.
881
a2271ba2
PE
882 Don't assume that tab-width fits in int.
883 * character.h (sanitize_width): New inline function.
884 (SANE_TAB_WIDTH): New macro.
885 (ASCII_CHAR_WIDTH): Use it.
886 * indent.c (sane_tab_width): Remove. All uses replaced by
887 SANE_TAB_WIDTH (current_buffer).
888 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
889
18c52557
PE
890 * fileio.c: Integer overflow issues with file modes.
891 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
892
caeeedc1
PE
893 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
894 Remove unreachable code.
895 (read_hex, load_charset_map_from_file): Check for integer overflow.
896
50849c52
PE
897 * xterm.c: don't go over XClientMessageEvent limit
898 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
899 (x_send_scroll_bar_event): Likewise. Check that the size does not
900 exceed limits imposed by XClientMessageEvent, as well as the usual
901 ptrdiff_t and size_t limits.
902
b13995db
PE
903 * keyboard.c: Overflow, signedness and related fixes.
904 (make_lispy_movement): Use same integer type in forward decl
905 that is used in the definition.
906 (read_key_sequence, keyremap_step):
907 Change bufsize argument back to int, undoing my 2011-03-30 change.
908 We prefer signed types, and int is wide enough here.
909 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
910 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
911 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
912 length, not size_t. Use ptrdiff_t for index, not int.
913 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
914 possibility of integer overflow.
915
13464394
PE
916 Overflow, signedness and related fixes for images.
917
918 * dispextern.h (struct it.stack[0].u.image.image_id)
919 (struct_it.image_id, struct image.id, struct image_cache.size)
920 (struct image_cache.used, struct image_cache.ref_count):
921 * gtkutil.c (update_frame_tool_bar):
922 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
923 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
924 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
925 * nsmenu.m (update_frame_tool_bar):
926 * xdisp.c (calc_pixel_width_or_height):
927 * xfns.c (image_cache_refcount):
928 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
929 on typical 64-bit hosts.
930
931 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
932 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
933 Omit unnecessary casts to int.
934 (parse_image_spec): Check that integers fall into 'int' range
935 when the callers expect that.
936 (image_ascent): Redo ascent calculation to avoid int overflow.
937 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
938 (lookup_image): Remove unnecessary tests.
939 (xbm_image_p): Locals are now of int, not EMACS_INT,
940 since parse_image_check makes sure they fit into int.
941 (png_load, gif_load, svg_load_image):
942 Prefer int to unsigned where either will do.
943 (tiff_handler): New function, combining the cores of the
944 old tiff_error_handler and tiff_warning_handler. This
945 function is rewritten to use vsnprintf and thereby avoid
946 stack buffer overflows. It uses only the features of vsnprintf
947 that are common to both POSIX and native Microsoft.
948 (tiff_error_handler, tiff_warning_handler): Use it.
949 (tiff_load, gif_load, imagemagick_load_image):
950 Don't assume :index value fits in 'int'.
951 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
952 (imagemagick_load_image): Check that crop parameters fit into
953 the integer types that MagickCropImage accepts. Don't assume
954 Vimagemagick_render_type has a nonnegative value. Don't assume
955 size_t fits in 'long'.
956 (gs_load): Use printmax_t to print the widest integers possible.
957 Check for integer overflow when computing image height and width.
958
c11821d4
EZ
9592011-08-26 Eli Zaretskii <eliz@gnu.org>
960
961 * xdisp.c (redisplay_window): Don't force window start if point
962 will be invisible in the resulting window. (Bug#9324)
963
0c95fcf7
EZ
9642011-08-25 Eli Zaretskii <eliz@gnu.org>
965
966 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
967 the display spec is of the form `(space ...)'.
968 (handle_display_spec): Return the value returned by
969 handle_single_display_spec, not just 1 or zero.
970 (handle_single_display_spec): If the display spec is of the form
971 `(space ...)', and specifies display in the text area, return 2
972 rather than 1.
fee65a97 973 (try_cursor_movement): Check for the need to scroll more
e25be792
EZ
974 accurately, and prefer exact match for point under bidi. Don't
975 advance `row' beyond the last row of the window.
0c95fcf7
EZ
976
977 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
978 into disp_prop; all users changed.
979
980 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
981 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
982 for the text covered by the display property.
983
e4ed06f1
CY
9842011-08-25 Chong Yidong <cyd@stupidchicken.com>
985
986 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
987 Change return value to nil.
988 (Frecord_buffer): Delete unused function.
989
f67cdd7f
EZ
9902011-08-24 Eli Zaretskii <eliz@gnu.org>
991
5980d4c6
EZ
992 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
993 buffers, return left-to-right.
8610fe8b
EZ
994 (set_cursor_from_row): Consider candidate row a win if its glyph
995 represents a newline and point is on that newline. Fixes cursor
996 positioning on the newline at EOL of R2L text within L2R
997 paragraph, and vice versa.
998 (try_cursor_movement): Check continued rows, in addition to
999 continuation rows. Fixes unwarranted scroll when point enters a
1000 continued line of R2L text within an L2R paragraph, or vice versa.
1001 (cursor_row_p): Consider the case of point being equal to
1002 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1003 from the end of a short line to the beginning of a continued line
1004 of R2L text within L2R paragraph.
1005 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1006 composed characters.
5980d4c6 1007
f67cdd7f
EZ
1008 * bidi.c (bidi_check_type): Use xassert.
1009 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1010 members.
1011
bca633fb
EZ
10122011-08-23 Eli Zaretskii <eliz@gnu.org>
1013
1014 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1015 a character.
1016
4a5885a7
CY
10172011-08-23 Chong Yidong <cyd@stupidchicken.com>
1018
1019 * nsfont.m (ns_otf_to_script): Fix typo.
1020
0902a04e
KH
10212011-08-22 Kenichi Handa <handa@m17n.org>
1022
1023 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1024 extra slot even if the purpose is char-code-property-table.
1025
1a2e6670
EZ
10262011-08-23 Eli Zaretskii <eliz@gnu.org>
1027
8ddde651
EZ
1028 * xdisp.c (redisplay_window): When computing centering_position,
1029 account for the height of the header line. (Bug#8874)
1030
425cc014
EZ
1031 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1032 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1033 candidate is selected by the mouse, and that candidate has a
1034 composed character under the mouse.
1035
1a2e6670
EZ
1036 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1037 coordinates reported by pos-visible-in-window-p for a composed
1038 character in column zero.
1039
8b76d6f8
SM
10402011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1041
1042 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1043
dac347dd
EZ
10442011-08-22 Eli Zaretskii <eliz@gnu.org>
1045
1046 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1047 consider it a hit if to_charpos is anywhere in the range of the
1048 composed buffer positions.
1049
e013fb34
CY
10502011-08-22 Chong Yidong <cyd@stupidchicken.com>
1051
1052 * image.c (gif_load): Don't assume that each subimage has the same
1053 dimensions as the base image. Handle disposal method that is
1054 "undefined" by the gif spec (Bug#9335).
1055
bd1ba3e8
CY
10562011-08-20 Chong Yidong <cyd@stupidchicken.com>
1057
1058 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 1059 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 1060
54a1215b
EZ
10612011-08-19 Eli Zaretskii <eliz@gnu.org>
1062
823564e5
EZ
1063 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1064 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1065 from an Org mode buffer to a Speedbar frame.
1066
54a1215b
EZ
1067 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1068 a composition, take its buffer position from IT->cmp_it.charpos.
1069 Fixes cursor positioning at the beginning of a line that begins
1070 with a composed character.
1071
9778ebcc
EZ
10722011-08-18 Eli Zaretskii <eliz@gnu.org>
1073
0be6ee06
EZ
1074 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1075 character bidirectional type, use STRONG_L instead. Fixes crashes
1076 in a buffer produced by `describe-categories'.
1077
9778ebcc
EZ
1078 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1079 members before the level stack, so they would be saved and
1080 restored when copying iterator state. Fixes incorrect reordering
1081 around TABs covered by display properties.
1082
156bffbe
AS
10832011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1084
1085 * process.c (Fnetwork_interface_list): Correctly determine buffer
1086 size.
1087
72ad093b
CY
10882011-08-17 Chong Yidong <cyd@stupidchicken.com>
1089
1090 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
1091 (internal_condition_case_2, internal_condition_case_n):
1092 Remove unnecessary aborts (Bug#9081).
72ad093b 1093
35774242
EZ
10942011-08-17 Eli Zaretskii <eliz@gnu.org>
1095
1096 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1097 has no `load' handler, try opening the file locally. (Bug#9311)
1098
db76dd85
KB
10992011-08-16 Ken Brown <kbrown@cornell.edu>
1100
1101 * gmalloc.c: Expand comment.
1102
b215eee5
EZ
11032011-08-16 Eli Zaretskii <eliz@gnu.org>
1104
1105 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1106 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1107
a4579d33
KB
11082011-08-16 Ken Brown <kbrown@cornell.edu>
1109
1110 Fix memory allocation problems in Cygwin build (Bug#9273).
1111
1112 * unexcw.c ( __malloc_initialized): Declare external variable.
1113 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1114
8b76d6f8
SM
1115 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1116 New variables.
a4579d33
KB
1117 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1118 dumped emacs.
1119 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1120 in the static heap.
1121 [CYGWIN] (special_realloc): New function.
1122 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1123 requests to realloc storage in the static heap.
1124
3ebec551
PE
11252011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1126
1127 * bidi.c (bidi_initialize): Remove unused local.
1128
9fd8be00
EZ
11292011-08-15 Eli Zaretskii <eliz@gnu.org>
1130
474a8465
EZ
1131 * biditype.h: File removed.
1132
1133 * bidimirror.h: File removed.
1134
1135 * deps.mk (bidi.o): Remove biditype.h and
1136 bidimirror.h.
1137
1138 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
1139 bidimirror.h.
1140
1141 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1142
1143 * chartab.c: Improve commentary for the uniprop_table API.
1144
32413314
EZ
1145 * bidi.c (bidi_paragraph_init): Support zero value of
1146 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
1147 (bidi_initialize): Use uniprop_table instead of including
1148 biditype.h and bidimirror.h.
32413314 1149
9fd8be00
EZ
1150 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1151 coordinates of the iterator when restoring from ppos_it.
1152 (Bug#9296)
1153
5cf2b69b
KH
11542011-08-14 Kenichi Handa <handa@m17n.org>
1155
1156 * process.c (create_process): Call setup_process_coding_systems
72ad093b 1157 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 1158
daf17d00
EZ
11592011-08-14 Eli Zaretskii <eliz@gnu.org>
1160
1161 * xdisp.c (move_it_in_display_line_to): Don't invoke
1162 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1163 ppos_it. Fixes vertical cursor motion when line beginning is
1164 covered by an image. (Bug#9296)
1165
08e3161a
JD
11662011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1167
1168 * nsterm.h (ns_run_ascript): Declare.
1169 (NSAPP_DATA2_RUNASSCRIPT): Define.
1170
1171 * nsfns.m (as_script, as_result, as_status): New static variables.
1172 (ns_run_ascript): New function.
5e617bc2 1173 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
1174 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1175 the event loop. Get status from as_status (Bug#7276).
1176
1177 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1178 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1179 the event loop (Bug#7276).
1180
a3720aa2
AS
11812011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1182
1183 * gnutls.c (QCgnutls_bootprop_priority)
1184 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1185 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1186 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1187 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1188 (QCgnutls_bootprop_verify_hostname_error)
1189 (QCgnutls_bootprop_callbacks_verify): Rename from
1190 Qgnutls_bootprop_..., all uses changed.
1191
1192 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1193 uses changed.
1194
0a0d27fb
PE
11952011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1196
19d5c50c
PE
1197 * xfaces.c (Qframe_set_background_mode): Now static.
1198 * dispextern.h (Qframe_set_background_mode): Remove decl.
1199
0a0d27fb
PE
1200 * process.c (Fnetwork_interface_info): Declare local only if needed.
1201
377538cb
JD
12022011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1203
1204 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1205 (Fnetwork_interface_list): Allocate in increments of bytes instead
1206 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1207 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1208 sockaddr.
1209 (struct ifflag_def): notrailers is smart on OSX.
1210 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1211 Get hardware address with getifaddrs if available.
1212
08fff70c
EZ
12132011-08-12 Eli Zaretskii <eliz@gnu.org>
1214
1215 * xdisp.c (iterate_out_of_display_property): xassert that
1216 IT->position is set to within IT->object's boundaries. Break from
1217 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
1218 when IT->position is set up wrongly due to some bug.
1219 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
1220 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1221 entry. Force push_it to save on the stack the current
1222 buffer/string position, to be restored by pop_it. Fix flags in
1223 the iterator structure wrt the object coming from a display
1224 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1225 properties. (Bug#9284)
1226
7be1c708 12272011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 1228
7be1c708
CY
1229 * fontset.c (fontset_get_font_group): Add proper type checks.
1230 (Bug#9172)
aac0c6e3 1231
7be1c708 12322011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 1233
7be1c708
CY
1234 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1235 and LC_VERSION_MIN_MACOSX.
1236 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1237 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 1238
97bb72a6
EZ
12392011-08-08 Eli Zaretskii <eliz@gnu.org>
1240
1241 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
1242 no-display-properties-and-no-overlays under bidi display.
1243 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 1244 properties and overlays.
97bb72a6 1245
d5617611
CY
12462011-08-08 Chong Yidong <cyd@stupidchicken.com>
1247
37e11a63
CY
1248 * editfns.c (Fset_time_zone_rule): Document relationship with the
1249 setenv function.
1250
d5617611
CY
1251 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1252 the font entity extracted from the cache (Bug#8109).
1253
58872834
CY
12542011-08-07 Chong Yidong <cyd@stupidchicken.com>
1255
1256 * composite.c (autocmp_chars): Don't reset point. That is done by
1257 restore_point_unwind (Bug#5984).
1258
75bfc667
JL
12592011-08-07 Juri Linkov <juri@jurta.org>
1260
1261 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1262 to show the arg `TIME' instead of `TIMEVAL'.
1263
d1410150
EZ
12642011-08-06 Eli Zaretskii <eliz@gnu.org>
1265
1266 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1267 display property strides EOL and includes a newline, as in
1268 longlines-mode. (Bug#9254)
75b771e4
EZ
1269 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1270 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
1271
1272 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1273 is non-zero, even if the data buffer is NULL. Fixes a crash in
1274 vertical-motion with longlines-mode. (Bug#9254)
1275
35928349
EZ
12762011-08-05 Eli Zaretskii <eliz@gnu.org>
1277
ec7cc85b
EZ
1278 * bidi.c <bidi_cache_total_alloc>: Now static.
1279 (bidi_initialize): Initialize bidi_cache_total_alloc.
1280
8b76d6f8 1281 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
1282 cache. (Bug#9221)
1283
1284 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1285 amount allocated this far in `bidi_cache_total_alloc'.
1286 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1287 non-zero, only free the data buffer without restoring the cache
1288 contents. All callers changed.
1289
1290 * dispextern.h (bidi_unshelve_cache): Update prototype.
1291
1292 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1293 (move_it_in_display_line, move_it_to)
1294 (move_it_vertically_backward, move_it_by_lines): Replace the call
1295 to xfree to an equivalent call to bidi_unshelve_cache.
1296 (move_it_in_display_line_to): Fix logic of returning
412b6358 1297 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 1298
e2e2423b
EZ
12992011-08-05 Eli Zaretskii <eliz@gnu.org>
1300
1301 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1302 came from a string character with a `cursor' property. (Bug#9229)
1303
ae9e757a
JD
13042011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1305
1306 * Makefile.in (LIB_PTHREAD): New variable.
1307 (LIBES): Add LIB_PTHREAD (Bug#9216).
1308
1309 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1310 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1311
213bd7f2
AS
13122011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1313
1314 * regex.c (re_iswctype): Remove some redundant boolean
1315 conversions.
1316
99aaf75f
JD
13172011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1318
1319 * xterm.c (x_find_topmost_parent): New function.
1320 (x_set_frame_alpha): Find topmost parent window with
1321 x_find_topmost_parent and set the property there also (bug#9181).
1322 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1323
c74e9d86
PE
13242011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1325
1326 * callproc.c (Fcall_process): Avoid vfork clobbering
1327 the local vars buffer, coding_systems, current_dir.
1328
640c8776
SM
13292011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1330
1331 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1332
f26d0e4c
PE
13332011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1334
8a10d76c
PE
1335 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1336 so that it is not optimized away.
1337
f26d0e4c
PE
1338 * xdisp.c (compute_display_string_pos): Remove unused local.
1339
55439c61
EZ
13402011-08-02 Eli Zaretskii <eliz@gnu.org>
1341
1342 Fix slow cursor motion and scrolling in large buffers with
1343 selective display, like Org Mode buffers. (Bug#9218)
1344
1345 * dispextern.h (struct bidi_it): New member disp_prop_p.
1346
1347 * xdisp.c: Remove one-slot cache of display string positions.
1348 (compute_display_string_pos): Accept an additional argument
5e617bc2 1349 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
1350 for a display string or property. If found, set DISP_PROP_P
1351 non-zero.
1352
1353 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
1354 DISP_PROP_P, and pass it to compute_display_string_pos.
1355 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
1356 non-zero. All callers of bidi_fetch_char changed.
1357
fb33fa43
SM
13582011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1359
1360 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1361
b099e063
DM
13622010-12-03 Don March <don@ohspite.net>
1363
1364 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1365 last character M-[char] is translated to ESC [char] (bug#7541).
1366
5cc7f7af
KH
13672011-08-02 Kenichi Handa <handa@m17n.org>
1368
d0fffa3f 1369 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
1370
1371 * chartab.c (uniprop_table): Make it non-static.
1372
525d5e6e
EZ
13732011-08-01 Eli Zaretskii <eliz@gnu.org>
1374
1375 * xdisp.c (forward_to_next_line_start): Accept additional argument
1376 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1377 on the newline.
1378 (reseat_at_next_visible_line_start): Use the bidi iterator state
1379 returned by forward_to_next_line_start to restore the state of
1380 it->bidi_it after backing up to previous newline. (Bug#9212)
1381
31011111
AS
13822011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1383
1384 * regex.c (re_comp): Protoize.
1385 (re_exec): Fix return type.
1386 (regexec): Fix type of `ret'. (Bug#9203)
1387
476371c4
PE
13882011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1389
e5d76069
PE
1390 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1391 This is needed if max-image-size is a floating-point number.
1392
9a79b20c
AS
13932011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1394
1395 * print.c (print_object): Print empty symbol as ##.
1396
1397 * lread.c (read1): Read ## as empty symbol.
1398
d8c2fa78
AA
13992011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1400
1401 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1402 setting frame foreground color (Bug#9175).
1403 (x_set_background_color): Likewise.
1404
ffe57a7a
AA
1405 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1406 contents (Bug#9176).
1407 (EmacsTooltip -init): Remove bezels and add shadows to
1408 tooltip windows.
1409
bf3492a5
AA
1410 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1411 or scroll bar (Bug#8470).
1412
d55e9c53
AA
1413 * nsfont.m (nsfont_open): Remove assignment to voffset and
1414 unnecessary vars hshink, expand, hd, full_height, min_height.
1415 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1416
1417 * nsterm.h (nsfont_info): Remove voffset field.
1418
d8c2fa78 14192011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
1420
1421 Implement strike-through and overline on NextStep (Bug#8863).
1422
1423 * nsfont.m (nsfont_open): Use underline position provided by font,
1424 instead of hard-coded value of 2.
1425 (nsfont_draw): Call ns_draw_text_decoration instead.
1426
1427 * nsterm.h: Add declaration for ns_draw_text_decoration.
1428
1429 * nsterm.m (ns_draw_text_decoration): New function for drawing
1430 underline, overline, and strike-through.
1431 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1432 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 1433 accommodate underlining, etc.
4843aac3 1434
4cc60b9b
EZ
14352011-07-28 Eli Zaretskii <eliz@gnu.org>
1436
bc7ece87
EZ
1437 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1438 default.
4cc60b9b 1439
476371c4
PE
14402011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1441
66606eea
PE
1442 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1443 Without this fix, if a signal arrives just after memory fills up,
1444 'malloc' might be invoked reentrantly.
1445
476371c4
PE
1446 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1447 In other words, assume that every image size is allowed, on non-X
1448 hosts. This assumption is probably wrong, but it lets Emacs compile.
1449
f3fcc40d
AS
14502011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1451
1452 * regex.c (re_iswctype): Convert return values to boolean.
1453
350c992f
EZ
14542011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1455
1456 * xdisp.c (compute_display_string_pos): Don't use cached display
1457 string position if the buffer had its restriction changed.
1458 (Bug#9184)
1459
5266b4bb
PE
14602011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1461
1462 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1463
2573a837 14642011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 1465
41f55ccd 1466 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 1467
39e378da
PE
1468 * bidi.c: Integer size and overflow fixes.
1469 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1470 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1471 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1472 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1473 (bidi_find_other_level_edge):
1474 Use ptrdiff_t instead of EMACS_INT where either will do.
1475 This works better on 32-bit hosts configured --with-wide-int.
1476 (bidi_cache_ensure_space): Check for size-calculation overflow.
1477 Use % rather than repeated addition, for better worst-case speed.
1478 Don't set bidi_cache_size until after xrealloc returns, because it
1479 might not return.
1480 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
1481 (bidi_cache_ensure_space): Also check that the bidi cache size
1482 does not exceed that of the largest Lisp string or buffer. See Eli
1483 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 1484
5e927815
PE
1485 * alloc.c (__malloc_size_t): Remove.
1486 All uses replaced by size_t. See Andreas Schwab's note
1487 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1488
ca4aa935
PE
1489 * image.c: Improve checking for integer overflow.
1490 (check_image_size): Assume that f is nonnull, since
1491 it is always nonnull in practice. This is one less thing to
1492 worry about when checking for integer overflow later.
1493 (x_check_image_size): New function, which checks for integer
1494 overflow issues inside X.
1495 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1496 This removes the need for a memory_full check.
1497 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1498 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1499 (xbm_read_bitmap_data): Change locals back to 'int', since
1500 their values must fit in 'int'.
1501 (xpm_load_image, png_load, tiff_load):
1502 Invoke x_create_x_image_and_pixmap earlier,
1503 to avoid much needless work if the image is too large.
1504 (tiff_load): Treat overly large images as if
1505 x_create_x_image_and_pixmap failed, not as malloc failures.
1506 (gs_load): Use x_check_image_size.
1507
5f8f9cc2
PE
1508 * gtkutil.c: Omit integer casts.
1509 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1510 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1511
5adf60bc
PE
1512 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1513
c8907a93
PE
1514 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1515 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1516 would wrongly return t on a 64-bit host.
1517
e3c25c68
PE
1518 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1519 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1520 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1521 and therefore cause GCC to emit a bogus diagnostic in some cases.
1522
3f791afe
PE
1523 * image.c: Integer signedness and overflow and related fixes.
1524 This is not an exhaustive set of fixes, but it's time to
1525 record what I've got.
1526 (lookup_pixel_color, check_image_size): Remove redundant decls.
1527 (check_image_size): Don't assume that arbitrary EMACS_INT values
1528 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1529 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1530 (tiff_load, imagemagick_load_image):
1531 Check for overflow in size calculations.
1532 (x_create_x_image_and_pixmap): Remove unnecessary test for
1533 xmalloc returning NULL; that can't happen.
1534 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1535 (xpm_color_bucket): Use better integer hashing function.
1536 (xpm_cache_color): Don't possibly over-allocate memory.
1537 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1538 (gif_memory_source):
1539 Use ptrdiff_t, not int or size_t, to record sizes.
1540 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1541 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1542 either works, as we prefer signed integers.
1543 (tiff_read_from_memory, tiff_write_from_memory):
1544 Return tsize_t, not size_t, since that's what the TIFF API wants.
1545 (tiff_read_from_memory): Don't fail simply because the read would
1546 go past EOF; instead, return a short read.
1547 (tiff_load): Omit no-longer-needed casts.
1548 (Fimagemagick_types): Don't assume size fits into 'int'.
1549
3cc5a532
PE
1550 Improve hashing quality when configured --with-wide-int.
1551 * fns.c (hash_string): New function, taken from sxhash_string.
1552 Do not discard information about ASCII character case; this
1553 discarding is no longer needed.
1554 (sxhash-string): Use it. Change sig to match it. Caller changed.
1555 * lisp.h: Declare it.
1556 * lread.c (hash_string): Remove, since we now use fns.c's version.
1557 The fns.c version returns a wider integer if --with-wide-int is
1558 specified, so this should help the quality of the hashing a bit.
1559
b312a492
PE
1560 * emacs.c: Integer overflow minor fix.
1561 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1562 Define only if GNU_LINUX.
1563 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1564
dfd153ae
PE
1565 * dispnew.c: Integer signedness and overflow fixes.
1566 Remove unnecessary forward decls, that were a maintenance hassle.
1567 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1568 All uses changed.
1569 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1570 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1571 (prepare_desired_row, line_draw_cost):
1572 Use int, not unsigned, where either works.
1573 (save_current_matrix, restore_current_matrix):
1574 Use ptrdiff_t, not size_t, where either works.
1575 (init_display): Check for overflow more accurately, and without
1576 relying on undefined behavior.
1577
a81d11a3
PE
1578 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1579 Remove, replacing with the new symbols in lisp.h. All uses changed.
1580 * fileio.c (make_temp_name):
1581 * filelock.c (lock_file_1, lock_file):
1582 * xdisp.c (message_dolog):
1583 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1584 Use pMd etc. instead.
1585 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1586 replacing the pWIDE etc. symbols removed from editfns.c.
1587
3300e6fd
PE
1588 * keyboard.h (num_input_events): Now uintmax_t.
1589 This is (very slightly) less likely to mess up due to wraparound.
1590 All uses changed.
1591
fd05c7e9
PE
1592 * buffer.c: Integer signedness fixes.
1593 (alloc_buffer_text, enlarge_buffer_text):
1594 Use ptrdiff_t rather than size_t when either will do, as we prefer
1595 signed integers.
1596
903fe15d
PE
1597 * alloc.c: Integer signedness and overflow fixes.
1598 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1599 (__malloc_size_t): Default to size_t, not to int.
1600 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1601 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1602 Prefer ptrdiff_t to size_t when either would do, as we prefer
1603 signed integers.
1604 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1605 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1606 Now const. Initialize with values that are in range even if char
1607 is signed.
1608 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1609 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1610 These functions do the right thing with sizes > 2**32.
1611 (check_depth): Now ptrdiff_t, not int.
1612 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1613 Adjust to new way of storing sizes. Check for size overflow bugs
1614 in rest of code.
1615 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1616 slightly wrong anyway, as it missed one instance of
1617 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1618 (refill_memory_reserve): Omit needless cast to size_t.
1619 (mark_object_loop_halt): Mark as externally visible.
1620
ac82cc6a
PE
1621 * xselect.c: Integer signedness and overflow fixes.
1622 (Fx_register_dnd_atom, x_handle_dnd_message):
1623 Use ptrdiff_t, not size_t, since we prefer signed.
1624 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1625 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1626 x_dnd_atoms_size and x_dnd_atoms_length.
1627
c2d1e36d
PE
1628 * doprnt.c: Prefer signed to unsigned when either works.
1629 * eval.c (verror):
1630 * doprnt.c (doprnt):
1631 * lisp.h (doprnt):
1632 * xdisp.c (vmessage):
1633 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1634 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1635 prefer signed arithmetic to avoid comparison confusion.
1636 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1637 but is a bit tricky.
1638
0e926e56
PE
1639 Assume freestanding C89 headers, string.h, stdlib.h.
1640 * data.c, doprnt.c, floatfns.c, print.c:
1641 Include float.h unconditionally.
1642 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1643 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1644 * regex.c: Likewise for stddef.h, string.h.
1645 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1646 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1647 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1648 (STDC_HEADERS): Remove obsolete defines.
1649 * sysdep.c: Include limits.h unconditionally.
1650
9cfdb3ec
PE
1651 Assume support for memcmp, memcpy, memmove, memset.
1652 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1653 * regex.c (memcmp, memcpy):
1654 Remove; we assume C89 now.
1655
1656 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1657 (__malloc_safe_bcopy): Remove; no longer needed.
1658
cf950e6b 1659 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
1660 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1661 well either way, and we prefer signed to unsigned.
1662
dbf38e02
LMI
16632011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1664
1665 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1666 closes the connection while we're reading (bug#9182).
1667
d6f0886c 16682011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 1669
d6f0886c
JD
1670 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1671 are specified (Bug#9168).
24e0f6b1 1672
2eb1f9e6
PE
16732011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1674
1675 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1676 Found by GCC static checking and --with-wide-int on a 32-bit host.
1677
22381272 16782011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
1679
1680 * xdisp.c (compute_display_string_pos): Fix logic of caching
1681 previous display string position. Initialize cached_prev_pos to
1682 -1. Fixes slow-down at the beginning of a buffer.
1683
f25e39b4
EZ
16842011-07-24 Eli Zaretskii <eliz@gnu.org>
1685
1686 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1687 for attrs[LFACE_FONTSET_INDEX].
1688
04c4b52e
PE
16892011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1690
1691 * xml.c (parse_region): Remove unused local
1692 that was recently introduced.
1693
c1734fbd
EZ
16942011-07-23 Eli Zaretskii <eliz@gnu.org>
1695
be18c5a5
EZ
1696 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1697 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1698
c1734fbd
EZ
1699 * xdisp.c (move_it_in_display_line_to): Record the best matching
1700 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
1701 exit if none of the characters scanned was an exact match.
1702 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
1703 when exact match is impossible due to invisible text, and the
1704 lines are truncated.
1705
a258d627
JD
17062011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1707
1708 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1709 for OSX >= 10.7.
1710
b6d5a689
EZ
17112011-07-22 Eli Zaretskii <eliz@gnu.org>
1712
0f74f785
EZ
1713 Fix a significant slow-down of cursor motion with C-n, C-p,
1714 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1715 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 1716 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
1717 (next_element_from_buffer): Call compute_stop_pos_backwards to
1718 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
1719 base_level_stop.
1720 (reseat): Don't look for prev_stop, as that could mean a very long
1721 run.
1722 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1723 <cached_disp_overlay_modiff>: Cache for last found display string
1724 position.
551918c1 1725 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
1726 about the same buffer in the same area of character positions, and
1727 the buffer wasn't changed since the time the display string
1728 position was cached.
551918c1 1729
b2d0c91a
EZ
17302011-07-22 Eli Zaretskii <eliz@gnu.org>
1731
1732 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1733 is an integer, which is important for empty lines. (Bug#9149)
1734
043604ee
CY
17352011-07-22 Chong Yidong <cyd@stupidchicken.com>
1736
1737 * frame.c (Fmodify_frame_parameters): In tty case, update the
1738 default face if necessary (Bug#4238).
1739
da4adb04
CY
17402011-07-21 Chong Yidong <cyd@stupidchicken.com>
1741
1742 * editfns.c (Fstring_to_char): No need to explain what a character
1743 is in the docstring (Bug#6576).
1744
9abd0532
LMI
17452011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1746
1747 * xml.c (parse_region): Make sure we always return a tree.
1748
36881d16
HK
17492011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1750
1751 * xml.c (parse_region): If a document contains only comments,
1752 return that, too.
1753
1e98674d
LMI
17542011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1755
1756 * xml.c (make_dom): Return comments, too.
1757
590bd467
PE
17582011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1759
1760 Port to OpenBSD.
1761 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1762 and the surrounding thread.
1763 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1764 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1765 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1766 timer goes off.
1767 * s/openbsd.h (BROKEN_SIGIO): Define.
1768 * unexelf.c (unexec) [__OpenBSD__]:
1769 Don't update the .mdebug section of the Alpha COFF symbol table.
1770
f41628b2
LMI
17712011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1772
1773 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1774 (bug#8460).
1775
b59b67c5
PE
17762011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1777
15e3a074
PE
1778 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1779 This fixes some race conditions on the permissions of any newly
1780 created file.
1781
41bed37d
PE
1782 * alloc.c (valid_pointer_p): Use pipe, not open.
1783 This fixes some permissions issues when debugging.
1784
b59b67c5
PE
1785 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1786 If fchown fails to set both uid and gid, try to set just gid,
1787 as that is sometimes allowed. Adjust the file's mode to eliminate
1788 setuid or setgid bits that are inappropriate if fchown fails.
1789
925a6be7
SM
17902011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1791
1792 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1793 to compare Lisp_Objects.
1794 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1795 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1796 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1797
52968808
AS
17982011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1799
0a6a104b
AS
1800 * lread.c (read_integer): Unread even EOF character.
1801 (read1): Likewise. Properly record start position of symbol.
1802
52968808
AS
1803 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1804 symbol character follows.
1805
9e381cdd
PE
18062011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1807
1808 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1809 This works around a problem with the previous change to Fcopy_file.
1810 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1811 and without this change, GCC might complain about discarding
1812 fchown's return value.
1813
b5641435
JB
18142011-07-16 Juanma Barranquero <lekktu@gmail.com>
1815
1816 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1817
a8031457
PE
18182011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1819
1820 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1821
dd889327
LMI
18222011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1823
750c33f7
LMI
1824 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1825 it's used from the C level.
1826
dd889327
LMI
1827 * process.c: Use the same condition for POLL_FOR_INPUT in both
1828 keyboard.c and process.c (bug#1858).
1829
87e86684
LM
18302011-07-09 Lawrence Mitchell <wence@gmx.li>
1831
1832 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1833 (Fgnutls_boot): Use it.
1834
64348f40
AS
18352011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1836
1837 * doc.c (Fsubstitute_command_keys): Revert last change.
1838
1d698799
LMI
18392011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1840
f863868c
LMI
1841 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1842 quotes the next character, and doesn't affect other longer
1843 sequences (bug#8935).
1844
1d698799
LMI
1845 * lread.c (syms_of_lread): Clarify that is isn't only
1846 `eval-buffer' and `eval-defun' that's affected by
1847 `lexical-binding' (bug#8460).
1848
aa4b6df6
EZ
18492011-07-15 Eli Zaretskii <eliz@gnu.org>
1850
1851 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1852 bidi redisplay when a line includes both an image and is
1853 truncated.
1854
5d856da6
PE
18552011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1856
ad6042bb
PE
1857 Fix minor problems found by static checking.
1858 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1859 (elsz): Now a signed constant, not a size_t var. We prefer signed
1860 types to unsigned, to avoid integer comparison confusion. Without
1861 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1862 "cannot optimize loop, the loop counter may overflow", a symptom
1863 of the confusion.
f00bbb22 1864 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
1865 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1866
6468f31c
LMI
18672011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1868
49080b10
LMI
1869 * search.c (Fre_search_backward): Mention `case-fold-search' in
1870 all the re_search_* functions (bug#8138).
1871
6468f31c
LMI
1872 * keyboard.c (Fopen_dribble_file): Document when the file is
1873 closed (bug#8056).
1874
c965adc5
EZ
18752011-07-14 Eli Zaretskii <eliz@gnu.org>
1876
df9733bf
EZ
1877 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1878 bidi_cache_idx.
1879
0bb23927
EZ
1880 Support bidi reordering of display and overlay strings.
1881 * xdisp.c (compute_display_string_pos)
1882 (compute_display_string_end): Accept additional argument STRING.
1883 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1884 (reseat_to_string): Initialize bidi_it->string.s and
1885 bidi_it->string.schars.
1886 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
1887 NULL (avoids a crash in bidi_paragraph_init).
1888 Initialize itb.string.lstring.
0bb23927
EZ
1889 (init_iterator): Call bidi_init_it only of a valid
1890 buffer position was specified. Initialize paragraph_embedding to
1891 L2R.
1892 (reseat_to_string): Initialize the bidi iterator.
1893 (display_string): If we need to ignore text properties of
1894 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1895 original value of -1 will not work with bidi.)
1896 (compute_display_string_pos): First arg is now struct
1897 `text_pos *'; all callers changed. Support display properties on
1898 Lisp strings.
1899 (compute_display_string_end): Support display properties on Lisp
1900 strings.
1901 (init_iterator, reseat_1, reseat_to_string): Initialize the
1902 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1903 when iterating on a string not from display properties).
640c8776
SM
1904 (compute_display_string_pos, compute_display_string_end):
1905 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
1906 arrow keys.
1907 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
1908 base_level_stop; instead, set base_level_stop to BEGV.
1909 Fixes crashes in vertical-motion.
0bb23927
EZ
1910 (next_element_from_buffer): Improve commentary for when
1911 the iterator is before prev_stop.
1912 (init_iterator): Initialize bidi_p from the default value of
1913 bidi-display-reordering, not from buffer-local value. Use the
1914 buffer-local value only if initializing for buffer iteration.
1915 (handle_invisible_prop): Support invisible properties on strings
1916 that are being bidi-reordered.
1917 (set_iterator_to_next): Support bidi reordering of C strings and
1918 Lisp strings.
1919 (next_element_from_string): Support bidi reordering of Lisp
1920 strings.
1921 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
1922 (display_string): Support display of R2L glyph rows.
1923 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
1924 (init_iterator): Don't initialize it->bidi_p for strings
1925 here.
1926 (reseat_to_string): Initialize it->bidi_p for strings here.
1927 (next_element_from_string, next_element_from_c_string)
1928 (next_element_from_buffer): Add xassert's for correspondence
1929 between IT's object being iterated and it->bidi_it.string
1930 structure.
1931 (face_before_or_after_it_pos): Support bidi iteration.
1932 (next_element_from_c_string): Handle the case of the first string
1933 character that is not the first one in the visual order.
1934 (get_visually_first_element): New function, refactored from common
1935 parts of next_element_from_buffer, next_element_from_string, and
1936 next_element_from_c_string.
1937 (tool_bar_lines_needed, redisplay_tool_bar)
1938 (display_menu_bar): Force left-to-right direction. Add a FIXME
1939 comment for making that be controlled by a user option.
1940 (push_it, pop_it): Save and restore the state of the
1941 bidi iterator. Save and restore the bidi_p flag.
1942 (pop_it): Iterate out of display property for string iteration as
1943 well.
1944 (iterate_out_of_display_property): Support iteration over strings.
1945 (handle_single_display_spec): Set up it->bidi_it for iteration
1946 over a display string, and call bidi_init_it.
1947 (handle_single_display_spec, next_overlay_string)
1948 (get_overlay_strings_1, push_display_prop): Set up the bidi
1949 iterator for displaying display or overlay strings.
1950 (forward_to_next_line_start): Don't use the shortcut if
1951 bidi-iterating.
1952 (back_to_previous_visible_line_start): If handle_display_prop
1953 pushed the iterator stack, restore the internal state of the bidi
1954 iterator by calling bidi_pop_it same number of times.
1955 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1956 and we are bidi-iterating, don't decrement the iterator position;
1957 instead, set the first_elt flag in the bidi iterator, to produce
1958 the same effect.
1959 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1960 (push_display_prop): xassert that we are iterating a buffer.
1961 (push_it, pop_it): Save and restore paragraph_embedding member.
1962 (handle_single_display_spec, next_overlay_string)
1963 (get_overlay_strings_1, reseat_1, reseat_to_string)
1964 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1965 correctly. Don't assume unibyte strings are not bidi-reordered.
1966 (compute_display_string_pos)
1967 (compute_display_string_end): Fix handling the case of C string.
1968 (push_it, pop_it): Save and restore from_disp_prop_p.
1969 (handle_single_display_spec, push_display_prop): Set the
1970 from_disp_prop_p flag.
1971 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1972 (pop_it): Call iterate_out_of_display_property only if we are
1973 popping after iteration over a string that came from a display
1974 property. Fix a typo in popping stretch info. Add an assertion
1975 for verifying that the iterator position is in sync with the bidi
1976 iterator.
1977 (handle_single_display_spec, get_overlay_strings_1)
1978 (push_display_prop): Fix initialization of paragraph direction for
1979 string when that of the parent object is not yet determined.
1980 (reseat_1): Call bidi_init_it to resync the bidi
1981 iterator with IT's position. (Bug#7616)
1982 (find_row_edges): If ROW->start.pos gives position
1983 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
1984 (handle_stop, back_to_previous_visible_line_start, reseat_1):
1985 Reset the from_disp_prop_p flag.
1986 (SAVE_IT, RESTORE_IT): New macros.
1987 (pos_visible_p, face_before_or_after_it_pos)
1988 (back_to_previous_visible_line_start)
1989 (move_it_in_display_line_to, move_it_in_display_line)
1990 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1991 (try_scrolling, redisplay_window, display_line): Use them when
1992 saving a temporary copy of the iterator and restoring it back.
1993 (back_to_previous_visible_line_start, reseat_1)
1994 (init_iterator): Empty the bidi cache "stack".
1995 (move_it_in_display_line_to): If iterator ended up at
1996 EOL, but we never saw any buffer positions smaller than
1997 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
1998 motion in bidi-reordered lines.
1999 (move_it_in_display_line_to): Record prev_method and prev_pos
2000 immediately before the call to set_iterator_to_next. Fixes cursor
2001 motion in bidi-reordered lines with stretch glyphs and strings
2002 displayed in margins. (Bug#8133) (Bug#8867)
2003 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2004 TO_CHARPOS.
640c8776
SM
2005 (pos_visible_p): Support positions in bidi-reordered lines.
2006 Save and restore bidi cache.
0bb23927
EZ
2007
2008 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2009 (bidi_paragraph_info): Delete unused struct.
2010 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2011 (bidi_cache_start): New variable.
2012 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2013 to zero.
2014 (bidi_cache_fetch_state, bidi_cache_search)
2015 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2016 (bidi_cache_find, bidi_peek_at_next_level)
2017 (bidi_level_of_next_char, bidi_find_other_level_edge)
2018 (bidi_move_to_visually_next): Compare cache index with
2019 bidi_cache_start rather than with zero.
2020 (bidi_fetch_char): Accept new argument STRING; all callers
2021 changed. Support iteration over a string. Support strings with
2022 display properties. Support unibyte strings. Fix the type of
2023 `len' according to what STRING_CHAR_AND_LENGTH expects.
2024 (bidi_paragraph_init, bidi_resolve_explicit_1)
2025 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
2026 (bidi_level_of_next_char, bidi_move_to_visually_next):
2027 Support iteration over a string.
0bb23927
EZ
2028 (bidi_set_sor_type, bidi_resolve_explicit_1)
2029 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2030 can now be zero (for strings); special values 0 and -1 were
2031 changed to -1 and -2, respectively.
2032 (bidi_char_at_pos): New function.
2033 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2034 Call it instead of FETCH_MULTIBYTE_CHAR.
2035 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2036 initialized to valid values.
2037 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2038 values.
2039 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2040 the test for valid cached positions. Fix the logic for looking up
2041 the sentinel state in the cache. GCPRO the Lisp string we are
2042 iterating.
2043 (bidi_push_it, bidi_pop_it): New functions.
2044 (bidi_initialize): Initialize the bidi cache start stack pointer.
2045 (bidi_cache_ensure_space): New function, refactored from part of
2046 bidi_cache_iterator_state. Don't assume the required size is just
2047 one BIDI_CACHE_CHUNK away.
2048 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2049 (bidi_count_bytes, bidi_char_at_pos): New functions.
2050 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2051 always valid if bidi_cache_idx is valid.
2052 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2053 is valid if it's going to be used.
2054 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2055 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
2056 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2057 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
2058 (bidi_find_other_level_edge, bidi_cache_start_stack):
2059 All variables related to cache indices are now EMACS_INT.
c965adc5 2060
0bb23927
EZ
2061 * dispextern.h (struct bidi_string_data): New structure.
2062 (struct bidi_it): New member `string'. Make flag members be 1-bit
2063 fields, and put them last in the struct.
640c8776
SM
2064 (compute_display_string_pos, compute_display_string_end):
2065 Update prototypes.
0bb23927
EZ
2066 (bidi_push_it, bidi_pop_it): Add prototypes.
2067 (struct iterator_stack_entry): New members bidi_p,
2068 paragraph_embedding, and from_disp_prop_p.
2069 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
2070 (bidi_shelve_cache, bidi_unshelve_cache):
2071 Declare prototypes.
0bb23927
EZ
2072
2073 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2074 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2075 and vector-like objects.
2076
2077 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2078 cache around display iteration.
2079
2080 * window.c (Fwindow_end, window_scroll_pixel_based)
2081 (displayed_window_lines, Frecenter): Save and restore the bidi
2082 cache around display iteration.
2083
3bbd2265
LMI
20842011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2085
2086 * editfns.c (Fdelete_region): Clarify the use of the named
2087 parameters (bug#6788).
2088
adc47434
MR
20892011-07-14 Martin Rudalics <rudalics@gmx.at>
2090
2091 * indent.c (Fvertical_motion): Set and restore w->pointm when
2092 saving and restoring the window's buffer (Bug#9006).
2093
837c31f8
LMI
20942011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2095
2096 * editfns.c (Fstring_to_char): Clarify just what is returned
2097 (bug#6576). Text by Eli Zaretskii.
2098
ac389d0c
JB
20992011-07-13 Juanma Barranquero <lekktu@gmail.com>
2100
2101 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2102
0be0ce47
EZ
21032011-07-13 Eli Zaretskii <eliz@gnu.org>
2104
2105 * buffer.c (mmap_find): Fix a typo.
2106
cd18e7e3
JB
21072011-07-13 Johan Bockgård <bojohan@gnu.org>
2108
2109 Fix execution of x selection hooks.
2110 * xselect.c (Qx_lost_selection_functions)
2111 (Qx_sent_selection_functions): New vars.
2112 (syms_of_xselect): DEFSYM them.
2113 (x_handle_selection_request): Pass Qx_sent_selection_functions
2114 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2115 (x_handle_selection_clear,x_clear_frame_selections):
2116 Pass Qx_lost_selection_functions rather than
2117 Vx_lost_selection_functions to Frun_hook_with_args.
2118
47ea7f44
PE
21192011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2120
ac389d0c 2121 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
2122 The old code sometimes used this field without initializing it.
2123
47ea7f44
PE
2124 * alloc.c (gc_sweep): Don't read past end of array.
2125 In theory, the old code could also have corrupted Emacs internals,
2126 though it'd be very unlikely.
2127
bc985c87
AS
21282011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2129
2130 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 2131 argument. (Bug#4026)
bc985c87 2132
0cf34688
LMI
21332011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2134
b3dadd76
LMI
2135 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2136 key" (bug#4257).
2137
0cf34688
LMI
2138 * window.c (Fset_window_start): Doc fix (bug#4199).
2139 (Fset_window_hscroll): Ditto.
2140
270768cd
PE
21412011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2142
077e3dda 2143 Fix minor new problems caught by GCC 4.6.1.
270768cd 2144 * term.c (init_tty): Remove unused local.
490011a6 2145 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 2146 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 2147 not used otherwise.
270768cd 2148
b1f58454
CY
21492011-07-12 Chong Yidong <cyd@stupidchicken.com>
2150
2151 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2152
22b9578d
LMI
21532011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2154
6e70ab07
LMI
2155 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2156 are the mini-buffer and the echo area (bug#3320).
2157
22b9578d
LMI
2158 * term.c (init_tty): Remove support for supdup, c10 and perq
2159 terminals, which are no longer supported (bug#1482).
2160
8974cc9f
JB
21612011-07-10 Johan Bockgård <bojohan@gnu.org>
2162
2163 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2164
a560d974
JD
21652011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2166
2167 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2168 for non-popups (Bug#3642).
2169
1dae0f0a
AS
21702011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2171
268c2c36 2172 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 2173 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
2174 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2175 * cm.c (losecursor): Likewise.
1dae0f0a
AS
2176 * data.c (fmod): Likewise.
2177 * dispnew.c (swap_glyphs_in_rows): Likewise.
2178 * emacs.c (memory_warning_signal): Likewise.
2179 * floatfns.c (float_error): Likewise.
2180 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2181 (otf_open, font_otf_capability, generate_otf_features)
2182 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2183 Likewise.
2184 * image.c (pbm_read_file): Likewise.
2185 * indent.c (string_display_width): Likewise.
2186 * intervals.c (check_for_interval, search_for_interval)
2187 (inc_interval_count, count_intervals, root_interval)
2188 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2189 * lread.c (defalias): Likewise.
268c2c36 2190 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
2191 * regex.c (set_image_of_range_1, set_image_of_range)
2192 (regex_grow_registers): Likewise.
2193 * sysdep.c (strerror): Likewise.
2194 * termcap.c (valid_filename_p, tprint, main): Likewise.
2195 * tparam.c (main): Likewise.
2196 * unexhp9k800.c (run_time_remap, save_data_space)
2197 (update_file_ptrs, read_header, write_header, calculate_checksum)
2198 (copy_file, copy_rest, display_header): Likewise.
2199 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2200 Likewise.
2201 * xdisp.c (check_it): Likewise.
2202 * xfaces.c (register_color, unregister_color, unregister_colors):
2203 Likewise.
2204 * xfns.c (print_fontset_result): Likewise.
2205 * xrdb.c (member, fatal, main): Likewise.
2206
99033785
PE
22072011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2208
2209 Fix minor problems found by static checking (Bug#9031).
2210 * chartab.c (char_table_set_range, map_sub_char_table):
2211 Remove unused locals.
2212 (uniprop_table): Now static.
2213 * composite.c (_work_char): Remove unused static var.
2214
9cb2ac56
JB
22152011-07-09 Juanma Barranquero <lekktu@gmail.com>
2216
2217 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2218
f25661f0
JD
22192011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2220
2221 * gtkutil.c (qttip_cb): Remove code without function.
2222
8278c4fe
EZ
22232011-07-09 Eli Zaretskii <eliz@gnu.org>
2224
2225 * w32.c (pthread_sigmask): New stub.
2226
1692ae2d 22272011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 2228
8a6ebd58 2229 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
2230 sigprocmask is portable only for single-threaded applications, and
2231 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
2232 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2233 (LIBES): Use it.
2234 * callproc.c (Fcall_process):
2235 * process.c (create_process):
2236 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2237 Use pthread_sigmask, not sigprocmask.
123403e4 2238
1b854618
JD
22392011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2240
2241 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2242 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2243 wrong (Bug#8591).
2244
3fe4b549
JD
22452011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2246
0ce7e563
JD
2247 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2248 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2249 (xg_hide_tooltip): Fix comment.
2250
3fe4b549
JD
2251 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2252 in registerServicesMenuSendTypes.
2253 (validRequestorForSendType): Don't check ns_return_types.
2254
2255 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2256 ns_return_type.
2257
5df75e47
JR
22582011-07-08 Jason Rumney <jasonr@gnu.org>
2259
2260 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2261 frame struct members of non-existent frames (Bug#6284).
2262
699c10bd
JD
22632011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2264
4393663b
JD
2265 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2266 variable firstTime not needed on OSX >= 10.6.
2267 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2268 >= 10.5. Use setKnobProportion, setDoubleValue.
2269
2270 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2271 (MAC_OS_X_VERSION_10_5): Define if not defined.
2272 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2273 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2274 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2275
2276 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2277 cString and lossyCString on OSX >= 10.4
2278
2279 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2280 sizeToFit on OSX >= 10.2.
2281
2282 * nsimage.m (allocInitFromFile): Don't use deprecated method
2283 bestRepresentationForDevice on OSX >= 10.6.
2284
2285 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2286 to avoid warning.
2287
2288 * emacs.c: Declare unexec_init_emacs_zone.
2289
a63e0781
JD
2290 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2291
699c10bd
JD
2292 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2293
2294 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2295 on svcsMenu (Bug#8842).
2296
2297 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2298 ns_return_types.
2299 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2300
2301 * nsterm.m (QUTF8_STRING): Declare.
2302 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2303 (validRequestorForSendType): Return type is (id).
2304 Change indexOfObjectIdenticalTo to indexOfObject.
2305 Check if we have local selection before returning self (Bug#8842).
2306 (writeSelectionToPasteboard): Put local selection into paste board
2307 if we have a local selection (Bug#8842).
2308 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2309
2310 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2311 (ns_get_local_selection): Declare.
2312
54e10184
LMI
23132011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2314
9888ff71
LMI
2315 * keymap.c (describe_map_tree): Don't insert a double newline at
2316 the end of the buffer (bug#1169) and return whether we inserted
2317 something.
2318
54e10184
LMI
2319 * callint.c (Fcall_interactively): Change "reading args" to
2320 "providing args" to try to clarify what it does (bug#1010).
2321
15fa4783
KH
23222011-07-07 Kenichi Handa <handa@m17n.org>
2323
2324 * composite.c (composition_compute_stop_pos): Ignore a static
2325 composition starting before CHARPOS (Bug#8915).
2326
2327 * xdisp.c (handle_composition_prop): Likewise.
2328
a8815b00
EZ
23292011-07-07 Eli Zaretskii <eliz@gnu.org>
2330
2331 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2332 (Bug#9015)
2333
ef7b981d 23342011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
2335
2336 * character.h (unicode_category_t): New enum type.
2337
2338 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2339 (Qchar_code_property_table): New variable.
2340 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2341 (UNIPROP_COMPRESSED_FORM_P): New macros.
2342 (char_table_ascii): Uncompress the compressed values.
2343 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2344 Uncompress the compressed values.
ac389d0c 2345 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
2346 (char_table_ref_and_range): Uncompress the compressed values.
2347 (sub_char_table_set): New arg is_uniprop. Callers changed.
2348 Uncompress the compressed values.
2349 (sub_char_table_set_range): Args changed. Callers changed.
2350 (char_table_set_range): Adjuted for the above change.
2351 (map_sub_char_table): Delete args default_val and parent. Add arg
2352 top. Give decoded values to a Lisp function.
640c8776 2353 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
2354 values to a Lisp function. Gcpro more variables.
2355 (uniprop_table_uncompress)
2356 (uniprop_decode_value_run_length): New functions.
2357 (uniprop_decoder, uniprop_decoder_count): New variables.
2358 (uniprop_get_decoder, uniprop_encode_value_character)
2359 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2360 New functions.
2361 (uniprop_encoder, uniprop_encoder_count): New variables.
2362 (uniprop_get_encoder, uniprop_table)
2363 (Funicode_property_table_internal, Fget_unicode_property_internal)
2364 (Fput_unicode_property_internal): New functions.
2365 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2366 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 2367 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
2368 char-code-property-alist.
2369
640c8776 2370 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
2371 Vunicode_category_table.
2372
640c8776 2373 * font.c (font_range): Adjust for the change of
c805dec0
KH
2374 Vunicode_category_table.
2375
76b397fb
DN
23762011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2377
2378 * m/iris4d.h: Remove file, move contents ...
2379 * s/irix6-5.h: ... here.
2380
22b4128e
PE
23812011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2382
2383 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
2384 * alloc.c (mark_buffer):
2385 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2386 (clone_per_buffer_values): Don't assume that
22b4128e
PE
2387 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2388 This isn't true in general, and it's particularly not true
2389 if Emacs is configured with --with-wide-int.
2390 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2391 New macros, used in the buffer.c change.
2392
869795d6
JD
23932011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2394
2395 * xsettings.c: Use both GConf and GSettings if both are available.
2396 (store_config_changed_event): Add comment.
2397 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2398 (store_tool_bar_style_changed): New functions.
5e617bc2 2399 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
2400 (struct xsettings): Move font inside HAVE_XFT.
2401 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 2402 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 2403 Move inside HAVE_XFT.
640c8776 2404 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
2405 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2406 also.
2407 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 2408 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 2409 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
2410 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2411 (parse_settings): Move check for font inside HAVE_XFT.
2412 (read_settings, apply_xft_settings): Add comment.
2413 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2414 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2415 call store_font_name_changed.
2416 (xft_settings_event): Add comment.
2417 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2418 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2419 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2420 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2421 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
2422 (xsettings_get_system_font, xsettings_get_system_normal_font):
2423 Add comment.
869795d6 2424
d8ed26bd
PE
24252011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2426
2427 Random fixes. E.g., (random) never returned negative values.
2428 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2429 subseconds part to the entropy, as that's a bit more random.
2430 Prefer signed to unsigned, since the signedness doesn't matter and
2431 in general we prefer signed. When given a limit, use a
2432 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2433 latter isn't right if USE_2_TAGS_FOR_INTS.
2434 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2435 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2436
cabf1cac
SM
24372011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2438
2439 * textprop.c (text_property_stickiness):
2440 Obey Vtext_property_default_nonsticky.
2441 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2442 * w32fns.c (syms_of_w32fns):
2443 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2444
6e9b2be9
PE
24452011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2446
2447 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2448 This is more efficient than Ffile_directory_p and avoids a minor race.
2449
90186c68
LMI
24502011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2451
7c301272
LMI
2452 * buffer.c (Foverlay_put): Say what the return value is
2453 (bug#7835).
2454
c4f2d8d4
LMI
2455 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2456 is a directory before asking whether to use the file name
2457 (bug#7564).
ad637907
LMI
2458 (barf_or_query_if_file_exists): Make the "File is a directory"
2459 error be more correct.
c4f2d8d4 2460
90186c68
LMI
2461 * fns.c (Frequire): Remove the mention of the .gz files, since
2462 that's installation-specific, but keep the mention of
2463 `get-load-suffixes'.
2464
da64016e
PE
24652011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2466
2467 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2468 Report string overflow if the output is too long.
2469
7d47b580
JB
24702011-07-04 Juanma Barranquero <lekktu@gmail.com>
2471
a555cb87
JB
2472 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2473 (syms_of_gnutls): Remove duplicate DEFSYM for
2474 Qgnutls_bootprop_verify_hostname_error, an error for
2475 Qgnutls_bootprop_verify_error (which is no longer used).
2476
7d47b580
JB
2477 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2478 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2479 Also (re)move comments that are misplaced or no longer relevant.
2480
1e49bfab
LMI
24812011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2482
2483 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2484
1485f4c0
CY
24852011-07-03 Chong Yidong <cyd@stupidchicken.com>
2486
2487 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2488 and background color parameters if they have been changed.
2489
a9ab721e
LMI
24902011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2491
2492 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2493
cf7cff57
PE
24942011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2495
2e13213d
PE
2496 * xsettings.c (SYSTEM_FONT): Define only when used.
2497 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2498
cf7cff57
PE
2499 * keymap.c (access_keymap_1): Now static.
2500
7a8e04f7
CY
25012011-07-02 Chong Yidong <cyd@stupidchicken.com>
2502
2503 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2504 leave any prefix arg for the up event (Bug#1586).
2505
61352f62
LMI
25062011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2507
69bb1ef7
LMI
2508 * lread.c (syms_of_lread): Mention single symbols defined by
2509 `defvar' or `defconst' (bug#7154).
2510
61352f62 2511 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 2512 (Frequire): Mention get-load-suffixes.
61352f62 2513
28545e04
MR
25142011-07-02 Martin Rudalics <rudalics@gmx.at>
2515
2516 * window.h (window): Remove clone_number slot.
2517 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2518 Remove.
2519 (make_parent_window, make_window, saved_window)
2520 (Fset_window_configuration, save_window_save): Don't deal with
2521 clone numbers.
2522 * buffer.c (Qclone_number): Remove declaration.
2523 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2524
3349e122
SM
25252011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2526
2527 Add multiple inheritance to keymaps.
2528 * keymap.c (Fmake_composed_keymap): New function.
2529 (Fset_keymap_parent): Simplify.
2530 (fix_submap_inheritance): Remove.
2531 (access_keymap_1): New function extracted from access_keymap to handle
2532 embedded parents and handle lists of maps.
2533 (access_keymap): Use it.
2534 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2535 (Fcopy_keymap): Handle embedded parents.
2536 (Fcommand_remapping, define_as_prefix): Simplify.
2537 (Fkey_binding): Simplify.
2538 (syms_of_keymap): Move minibuffer-local-completion-map,
2539 minibuffer-local-filename-completion-map,
2540 minibuffer-local-must-match-map, and
2541 minibuffer-local-filename-must-match-map to Elisp.
2542 (syms_of_keymap): Defsubr make-composed-keymap.
2543 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2544 (parse_menu_item): Trivial simplification.
2545
3279eb87
GM
25462011-07-01 Glenn Morris <rgm@gnu.org>
2547
2548 * Makefile.in (SETTINGS_LIBS): Fix typo.
2549
4550efdf
KI
25502011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2551
2552 * coding.c (Fencode_coding_string): Record the last coding system
2553 used, as the function doc string says (bug#8738).
2554
0949d2b6
JD
25552011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2556
2557 * xsettings.c (store_monospaced_changed): Take new font as arg and
2558 check for change against current_mono_font.
2559 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2560 (emacs_settings_constructor, emacs_settings_get_property)
2561 (emacs_settings_set_property, emacs_settings_class_init)
2562 (emacs_settings_init, gsettings_obj): Remove.
2563 (something_changedCB): New function for HAVE_GSETTINGS.
2564 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2565 with value as argument.
2566 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2567 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 2568 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
2569 "changed".
2570
2571 * xgselect.c: Add defined (HAVE_GSETTINGS).
2572 (xgselect_initialize): Ditto.
2573
2574 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2575 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2576 xg_select.
2577
bbc6b304
PE
25782011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2579
2580 * eval.c (struct backtrace): Simplify and port the data structure.
2581 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2582 signed bit field, as this assumption is not portable and it makes
2583 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2584 "char debug_on_exit : 1" as this is not portable either; instead,
2585 use the portable "unsigned int debug_on_exit : 1". Remove unused
2586 member evalargs. Remove obsolete comments about cc bombing out.
2587
9851bfc5
JD
25882011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2589
51bb811f 2590 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
2591 Let HAVE_GSETTINGS override HAVE_GCONF.
2592 (store_monospaced_changed): New function.
2593 (EMACS_SETTINGS): A new type derived from GObject to handle
2594 GSettings notifications.
2595 (emacs_settings_constructor, emacs_settings_get_property)
2596 (emacs_settings_set_property, emacs_settings_class_init):
2597 New functions.
2598 (gsettings_client, gsettings_obj): New variables.
2599 (GSETTINGS_SCHEMA): New define.
2600 (something_changedCB): Call store_monospaced_changed.
2601 (init_gsettings): New function.
2602 (xsettings_initialize): Call init_gsettings.
2603 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2604 to NULL.
2605
640c8776 2606 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
2607 GCONF_CFLAGS/LIBS.
2608
5386012d
MR
26092011-06-29 Martin Rudalics <rudalics@gmx.at>
2610
2611 * window.c (resize_root_window, grow_mini_window)
2612 (shrink_mini_window): Rename Qresize_root_window to
2613 Qwindow_resize_root_window and Qresize_root_window_vertically to
2614 Qwindow_resize_root_window_vertically.
2615
f13e0b08
PE
26162011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2617
2618 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2619
94515237
JB
26202011-06-27 Juanma Barranquero <lekktu@gmail.com>
2621
2622 * makefile.w32-in: Redesign dependencies so they reflect more
2623 clearly which files are directly included by each source file,
2624 and not through other includes.
2625
e43b6e43
MR
26262011-06-27 Martin Rudalics <rudalics@gmx.at>
2627
2628 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2629 (sort_overlays, overlay_strings): When an overlay's clone number
2630 matches the window's clone number process the overlay even if
2631 the overlay's window property doesn't match the current window.
2632
d68443dc
MR
2633 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2634 (Fwindow_hchild): Rename to Fwindow_left_child.
2635 (Fwindow_next): Rename to Fwindow_next_sibling.
2636 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
2637 (resize_window_check): Rename to window_resize_check.
2638 (resize_window_apply): Rename to window_resize_apply.
2639 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2640 (Fdelete_other_windows_internal, resize_frame_windows)
2641 (Fsplit_window_internal, Fdelete_window_internal)
2642 (grow_mini_window, shrink_mini_window)
2643 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 2644
c7e73be5
JD
26452011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2646
2647 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2648 (emacs_fixed_set_min_size): Remove.
2649 (emacs_fixed_new): Take frame as argument.
2650
2651 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2652 (_EmacsFixedPrivate): Remove minwidth/height.
2653 Add struct frame *f.
2654 (emacs_fixed_init): Initialize priv->f.
2655 (get_parent_class, emacs_fixed_set_min_size): Remove.
2656 (emacs_fixed_new): Set priv->f to argument.
2657 (emacs_fixed_get_preferred_width)
2658 (emacs_fixed_get_preferred_height): Use min_width/height from
2659 frames size_hint to set minimum and natural (Bug#8919).
2660 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2661 and use min_width/height from frames size_hint to set
2662 min_width/height (Bug#8919).
2663
2664 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
2665 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2666 Fix indentation.
c7e73be5 2667
cf99dcf8
EZ
26682011-06-26 Eli Zaretskii <eliz@gnu.org>
2669
2670 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2671 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2672 called at ZV.
2673
029529ac
CY
26742011-06-26 Chong Yidong <cyd@stupidchicken.com>
2675
2676 * process.c (wait_reading_process_output): Bypass select if
2677 waiting for a cell while ignoring keyboard input, and input is
2678 pending. Suggested by Jan Djärv (Bug#8869).
2679
7a7ef429
PE
26802011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2681
2682 Use gnulib's dup2 module instead of rolling our own.
2683 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2684
11fdef7d 26852011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
2686
2687 * dispnew.c (scrolling_window): Before scrolling, turn off a
2688 mouse-highlight in the window being scrolled.
2689
cd3520a4
JB
26902011-06-24 Juanma Barranquero <lekktu@gmail.com>
2691
2692 Move DEFSYM to lisp.h and use everywhere.
2693
2694 * character.h (DEFSYM): Move declaration...
2695 * lisp.h (DEFSYM): ...here.
2696
2697 * gnutls.c:
2698 * minibuf.c:
2699 * w32menu.c:
2700 * w32proc.c:
2701 * w32select.c: Don't include character.h.
2702
2703 * alloc.c (syms_of_alloc):
2704 * buffer.c (syms_of_buffer):
2705 * bytecode.c (syms_of_bytecode):
2706 * callint.c (syms_of_callint):
2707 * casefiddle.c (syms_of_casefiddle):
2708 * casetab.c (init_casetab_once):
2709 * category.c (init_category_once, syms_of_category):
2710 * ccl.c (syms_of_ccl):
2711 * cmds.c (syms_of_cmds):
2712 * composite.c (syms_of_composite):
2713 * dbusbind.c (syms_of_dbusbind):
2714 * dired.c (syms_of_dired):
2715 * dispnew.c (syms_of_display):
2716 * doc.c (syms_of_doc):
2717 * editfns.c (syms_of_editfns):
2718 * emacs.c (syms_of_emacs):
2719 * eval.c (syms_of_eval):
2720 * fileio.c (syms_of_fileio):
2721 * fns.c (syms_of_fns):
2722 * frame.c (syms_of_frame):
2723 * fringe.c (syms_of_fringe):
2724 * insdel.c (syms_of_insdel):
2725 * keymap.c (syms_of_keymap):
2726 * lread.c (init_obarray, syms_of_lread):
2727 * macros.c (syms_of_macros):
2728 * msdos.c (syms_of_msdos):
2729 * print.c (syms_of_print):
2730 * process.c (syms_of_process):
2731 * search.c (syms_of_search):
2732 * sound.c (syms_of_sound):
2733 * syntax.c (init_syntax_once, syms_of_syntax):
2734 * terminal.c (syms_of_terminal):
2735 * textprop.c (syms_of_textprop):
2736 * undo.c (syms_of_undo):
2737 * w32.c (globals_of_w32):
2738 * window.c (syms_of_window):
2739 * xdisp.c (syms_of_xdisp):
2740 * xfaces.c (syms_of_xfaces):
2741 * xfns.c (syms_of_xfns):
2742 * xmenu.c (syms_of_xmenu):
2743 * xsettings.c (syms_of_xsettings):
2744 * xterm.c (syms_of_xterm): Use DEFSYM.
2745
4228cf16
TZ
27462011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2747
cd3520a4 2748 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 2749
7fcccf1e
PE
27502011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2751
7efb4e0e
PE
2752 Integer and buffer overflow fixes (Bug#8873).
2753
ff5844ad
PE
2754 * print.c (printchar, strout): Check for string overflow.
2755 (PRINTPREPARE, printchar, strout):
2756 Don't set size unless allocation succeeds.
2757
90532f02
PE
2758 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2759 for sizes. Check for string overflow more accurately.
2760 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2761
6d84508d
PE
2762 * macros.c: Integer and buffer overflow fixes.
2763 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2764 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2765 Use ptrdiff_t, not int, for sizes.
2766 Don't increment bufsize until after realloc succeeds.
2767 Check for size-calculation overflow.
2768 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2769
437b2cb4
PE
2770 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2771
8b9ac8b4
PE
2772 * lread.c: Integer overflow fixes.
2773 (read_integer): Radix is now EMACS_INT, not int,
2774 to improve quality of diagnostics for out-of-range radices.
2775 Calculate buffer size correctly for out-of-range radices.
2776 (read1): Check for integer overflow in radices, and in
2777 read-circle numbers.
82cb60d3
PE
2778 (read_escape): Avoid int overflow.
2779 (Fload, openp, read_buffer_size, read1)
2780 (substitute_object_recurse, read_vector, read_list, map_obarray):
2781 Use ptrdiff_t, not int, for sizes.
2782 (read1): Use EMACS_INT, not int, for sizes.
20270765 2783 Check for size overflow.
8b9ac8b4 2784
7fcccf1e
PE
2785 * image.c (cache_image): Check for size arithmetic overflow.
2786
bfbbd7e7
PE
2787 * lread.c: Integer overflow issues.
2788 (saved_doc_string_size, saved_doc_string_length)
2789 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2790 Now ptrdiff_t, not int.
2791 (read1): Don't assume doc string length fits in int. Check for
2792 out-of-range doc string lengths.
2793 (read_list): Don't assume file position fits in int.
39019e54 2794 (read_escape): Check for hex character overflow.
bfbbd7e7 2795
4e323265
LL
27962011-06-22 Leo Liu <sdl.web@gmail.com>
2797
2798 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2799 Move to minibuffer.el.
2800
85fece3e
PE
28012011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2802
20b84ce9 2803 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
2804 The following patches are for when GLYPH_DEBUG && !XASSERT.
2805 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2806 * dispnew.c (flush_stdout):
2807 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2808 Mark as externally visible.
2809 * dispnew.c (check_window_matrix_pointers): Now static.
2810 * dispnew.c (window_to_frame_vpos):
2811 * xfns.c (unwind_create_frame):
2812 * xterm.c (x_check_font): Remove unused local.
2813 * scroll.c (CHECK_BOUNDS):
2814 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2815 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2816 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2817 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2818 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2819 Now static.
2820 (debug_method_add): Use va_list and vsprintf rather than relying
2821 on undefined behavior with wrong number of arguments.
2822 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2823 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2824 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2825 since we're not interested in debugging glyphs with old libraries.
2826 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2827 GCC 4.6.0's static checking.
2828
0766b489
PE
28292011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2830
31fd4b32
PE
2831 Integer overflow and signedness fixes (Bug#8873).
2832 A few related buffer overrun fixes, too.
2833
b79e8648
PE
2834 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2835
0766b489
PE
2836 * dispextern.h (struct face.stipple):
2837 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2838 (x_bitmap_mask, x_allocate_bitmap_record)
2839 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2840 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2841 (x_create_bitmap_from_xpm_data):
2842 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2843 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2844 (.bitmaps_last):
2845 * xfaces.c (load_pixmap):
2846 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2847 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2848 (.bitmaps_last, struct x_output.icon_bitmap):
2849 Use ptrdiff_t, not int, for bitmap indexes.
2850 (x_allocate_bitmap_record): Check for size overflow.
2851 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2852
b081724f
PE
2853 Use ptrdiff_t, not int, for overlay counts.
2854 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2855 * editfns.c (overlays_around, get_pos_property):
2856 * textprop.c (get_char_property_and_overlay):
2857 * xdisp.c (next_overlay_change, note_mouse_highlight):
2858 * xfaces.c (face_at_buffer_position):
21514da7
PE
2859 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2860 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2861 (Fnext_overlay_change, Fprevious_overlay_change)
2862 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 2863 Use ptrdiff_t, not int, for sizes.
21514da7 2864 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 2865
3de73e5e
PE
2866 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2867
2606c57b
PE
2868 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2869 (x_session_initialize): Do not assume string length fits in int.
2870
aaafe47a
PE
2871 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2872 This is unlikely, but can occur if DPI is outlandish.
2873
2674ddc8 2874 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
2875 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2876
28154962
PE
2877 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2878 * xrdb.c (magic_file_p, search_magic_path):
2879 Omit last arg SUFFIX; it was always 0. All callers changed.
2880 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2881
7de51af5
PE
2882 * xfont.c (xfont_match): Avoid need for strlen.
2883
25ed6cc3
PE
2884 * xfns.c: Don't assume strlen fits in int.
2885 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2886
4eab31dd
PE
2887 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2888 not unsigned long, as we prefer signed integers. All callers changed.
2889 Detect integer overflow in repeat count.
2890 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 2891 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 2892
171e2a58
PE
2893 * termcap.c: Don't assume sizes fit in int and never overflow.
2894 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2895 (gobble_line): Check for size-calculation overflow.
2896
ad39faca 2897 * minibuf.c (Fread_buffer):
6e5bb2dc 2898 * lread.c (intern, intern_c_string):
74ca2eb3
PE
2899 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2900 Don't assume string length fits in int.
2901
52c61c22 2902 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
2903 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2904
b5b8c9e5
PE
2905 * font.c: Don't assume string length fits in int.
2906 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2907 Use ptrdiff_t, not int.
ccd6111c
PE
2908 (font_intern_prop): Don't assume string length fits in int.
2909 Don't assume integer property fits in fixnum.
2910 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 2911
882f0d81 2912 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 2913 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
2914 Reformulate so as not to need the command string.
2915 Invoke gzip -cd rather than gunzip, as it's more portable.
2916 (lock_info_type, lock_file_1, lock_file):
2917 Don't assume pid_t and time_t fit in unsigned long.
2918 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2919 (current_lock_owner): Prefer signed type for sizes.
2920 Use memcpy, not strncpy, where memcpy is what is really wanted.
2921 Don't assume (via atoi) that time_t and pid_t fit in int.
2922 Check for time_t and/or pid_t out of range, e.g., via a network share.
2923 Don't alloca where an auto var works fine.
2924
93f4cf88
PE
2925 * fileio.c: Fix some integer overflow issues.
2926 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2927 Don't assume string length fits in int.
2928 (directory_file_name): Don't assume string length fits in long.
2929 (make_temp_name): Don't assume pid fits in int, or that its print
2930 length is less than 20.
2931
f3e92b69
PE
2932 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2933
1bfdaf10
PE
2934 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2935
35016e9a
PE
2936 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2937
3d1e65a1
PE
2938 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2939 We prefer signed integers, even for size calculations.
2940
0b963a93
PE
2941 * emacs.c: Don't assume string length fits in 'int'.
2942 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2943 (main): Don't invoke strlen when not needed.
2944
573f4b54
PE
2945 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2946 (XD_DEBUG_MESSAGE): Don't waste a byte.
2947
989f33ba
PE
2948 * callproc.c (getenv_internal_1, getenv_internal)
2949 (Fgetenv_internal):
965d34eb
PE
2950 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2951
e4d29b33
PE
2952 * lread.c (invalid_syntax): Omit length argument.
2953 All uses changed. This doesn't fix a bug, but it simplifies the
2954 code away from its former Hollerith-constant appearance, and it's
2955 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 2956 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 2957
eb49b136
PE
2958 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2959 This didn't break anything, but it didn't help either.
2960 It's confusing to put a bogus integer in a place where the actual
2961 value does not matter.
9f62aeb1 2962 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 2963 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 2964
15375a22
PE
2965 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2966 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2967 implementation.
b61cc01c
PE
2968 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2969 We prefer signed types, and the value cannot exceed the EMACS_INT
2970 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
2971 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2972 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2973 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 2974
53b2623d
PE
2975 * indent.c (sane_tab_width): New function.
2976 (current_column, scan_for_column, Findent_to, position_indentation)
2977 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 2978 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 2979
51cab52b 2980 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 2981
f2ed8a70
PE
2982 * lisp.h (lint_assume): New macro.
2983 * composite.c (composition_gstring_put_cache):
2984 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
2985
abe80cc6
PE
2986 * editfns.c, insdel.c:
2987 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 2988
b02c740e
PE
2989 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
2990
ebc96716
PE
2991 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
2992
b4e50fa0 2993 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 2994 Use much-faster test for byte-length change.
311d5d7c 2995 Don't assume string byte-length fits in 'int'.
a4cf38e4 2996 Check that character arg fits in 'int'.
85461888 2997 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 2998
c0c1ee9f
PE
2999 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3000
a498d7f4
PE
3001 * fns.c (concat): Catch string overflow earlier.
3002 Do not rely on integer wraparound.
3003
51cab52b
PE
3004 * dispextern.h (struct it.overlay_strings_charpos)
3005 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
3006 * xdisp.c (forward_to_next_line_start)
3007 (back_to_previous_visible_line_start)
3008 (reseat_at_next_visible_line_start, next_element_from_buffer):
3009 Don't arbitrarily truncate the value of 'selective' to int.
3010
76031fad
PE
3011 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3012
5eb55db9
PE
3013 * composite.c: Don't truncate sizes to 'int'.
3014 (composition_gstring_p, composition_reseat_it)
3015 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
3016 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3017 not EMACS_UINT, for indexes.
5eb55db9 3018
0703a717
PE
3019 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3020
d6202519
PE
3021 * buffer.c: Include <verify.h>.
3022 (struct sortvec.priority, struct sortstr.priority):
8961a454 3023 Now EMACS_INT, not int.
c20998a7 3024 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
3025 (struct sortstr.size, record_overlay_string)
3026 (struct sortstrlist.size, struct sortlist.used):
3027 Don't truncate size to int.
3028 (record_overlay_string): Check for size-calculation overflow.
d6202519 3029 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 3030
d5a19415
JM
30312011-06-22 Jim Meyering <meyering@redhat.com>
3032
029529ac 3033 Don't leak an XBM-image-sized buffer
d5a19415
JM
3034 * image.c (xbm_load): Free the image buffer after using it.
3035
a9041e6c
PE
30362011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3037
3038 Port to Sun C.
3039 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3040 that Sun C diagnosed.
3041 * fns.c (secure_hash): Fix pointer signedness issue.
3042 * intervals.c (static_offset_intervals): New function.
3043 (offset_intervals): Use it.
3044
7f3f739f
LL
30452011-06-21 Leo Liu <sdl.web@gmail.com>
3046
3047 * deps.mk (fns.o):
3048 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3049 sha512.h.
3050
3051 * fns.c (secure_hash): Rename from crypto_hash_function and change
3052 the first arg to accept symbols.
5b66d427 3053 (Fsecure_hash): New primitive.
7f3f739f
LL
3054 (syms_of_fns): New symbols.
3055
76147d94
DD
30562011-06-20 Deniz Dogan <deniz@dogan.se>
3057
3058 * process.c (Fset_process_buffer): Clarify return value in
3059 docstring.
3060
7d7d0045
CY
30612011-06-18 Chong Yidong <cyd@stupidchicken.com>
3062
3063 * dispnew.c (add_window_display_history): Use BVAR.
3064
3065 * xdisp.c (debug_method_add): Use BVAR.
3066 (check_window_end, dump_glyph_matrix, dump_glyph)
3067 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3068
3069 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3070 Likewise.
3071
3072 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3073 check till after the cache is created in init_frame_faces.
3074
ff2bc410
SM
30752011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3076
3077 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3078
28177add
PE
30792011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3080
dd3482fe
PE
3081 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3082 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3083 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3084
393d71f3 3085 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
3086 * fileio.c (Finsert_file_contents):
3087 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3088 Remove the old (too-loose) buffer overflow checks.
3089 They weren't needed, since make_gap checks for buffer overflow.
3090 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3091 The old code merely checked for Emacs fixnum overflow, and relied
3092 on undefined (wraparound) behavior. The new code avoids undefined
3093 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3094
2e6813b0 3095 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
3096 Tune. Don't use wider integers than needed. Don't use alloca.
3097 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 3098
599a9e4f
PE
3099 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3100
99561444
PE
3101 * insdel.c, lisp.h (buffer_overflow): New function.
3102 (insert_from_buffer_1, replace_range, replace_range_2):
3103 * insdel.c (make_gap_larger):
3104 * editfns.c (Finsert_char):
3105 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3106
28177add
PE
3107 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3108
e69dafad
PE
31092011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3110
a7af7fde 3111 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 3112
b1c46f02
PE
3113 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3114 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3115
e69dafad
PE
3116 * fileio.c: Don't assume EMACS_INT fits in off_t.
3117 (emacs_lseek): New static function.
3118 (Finsert_file_contents, Fwrite_region): Use it.
3119 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3120
566684ea
PE
3121 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3122
e6966cd6
PE
3123 * fns.c: Don't overflow int when computing a list length.
3124 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3125 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3126 truncation on 64-bit hosts. Check for QUIT every
3127 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3128 faster and is responsive enough.
3129 (Flength): Report an error instead of overflowing an integer.
3130 (Fsafe_length): Return a float if the value is not representable
3131 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 3132 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 3133 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 3134
dd0b0efb
PE
3135 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3136 (header_size, word_size): New constants.
3137 (allocate_vectorlike): Don't check size overflow here.
3138 (allocate_vector): Check it here instead, since this is the only
3139 caller of allocate_vectorlike that could cause overflow.
3140 Check that the new vector's length is representable as a fixnum.
3141
86fe5cfe
PE
3142 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3143 The previous code was bogus. For example, next_almost_prime (32)
3144 returned 39, which is undesirable as it is a multiple of 3; and
3145 next_almost_prime (24) returned 25, which is a multiple of 5 so
3146 why was the code bothering to check for multiples of 7?
3147
80e88859
PE
3148 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3149
4a2f0ad6
PE
3150 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3151
f66c7cf8
PE
3152 Variadic C functions now count arguments with ptrdiff_t.
3153 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3154 Back then I didn't know that the Emacs coding style prefers signed int.
3155 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
3156 were being counted with int, which may truncate counts on 64-bit
3157 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
3158 * lisp.h (struct Lisp_Subr.function.aMANY)
3159 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3160 Arg counts are now ptrdiff_t, not size_t.
3161 All variadic functions and their callers changed accordingly.
3162 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3163 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3164 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3165 * callint.c (Fcall_interactively): Check arg count for overflow,
3166 to avoid potential buffer overrun. Use signed char, not 'int',
3167 for 'varies' array, so that we needn't bother to check its size
3168 calculation for overflow.
3169 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3170 * eval.c (apply_lambda):
3171 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3172 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3173 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3174
a1759b76
PE
3175 * callint.c (Fcall_interactively): Don't use index var as event count.
3176
d96be9fc
PE
3177 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3178 * mem-limits.h (SIZE): Remove; no longer used.
3179
a690a978 3180 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 3181
578c21e6
PE
3182 Remove unnecessary casts.
3183 * xterm.c (x_term_init):
3184 * xfns.c (x_set_border_pixel):
3185 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3186 These aren't needed now that we assume ANSI C.
3187
96f53c6c
PE
3188 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3189 It's more likely to cause problems (due to unsigned overflow)
3190 than to cure them.
3191
83c77d31
PE
3192 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3193
ee2079f1
PE
3194 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3195
6da65536
PE
3196 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3197
7147c4a4
PE
3198 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3199
193e32d9
PE
3200 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3201
e5533da6
PE
3202 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3203
9910e595
PE
3204 GLYPH_CODE_FACE returns EMACS_INT, not int.
3205 * dispextern.h (merge_faces):
3206 * xfaces.c (merge_faces):
01103c44
PE
3207 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3208 Don't assume EMACS_INT fits in int.
9910e595 3209
2638320e
PE
3210 * character.h (CHAR_VALID_P): Remove unused parameter.
3211 * fontset.c, lisp.h, xdisp.c: All uses changed.
3212
045eb8d9
PE
3213 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3214
c1f134b5
PE
3215 * fns.c (concat): Minor tuning based on overflow analysis.
3216 This doesn't fix any bugs. Use int to hold character, instead
3217 of constantly refetching from Emacs object. Use XFASTINT, not
3218 XINT, for value known to be a character. Don't bother comparing
3219 a single byte to 0400, as it's always less.
3220
395fcb93 3221 * floatfns.c (Fexpt):
327eeec8
PE
3222 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3223
abbd3d23
PE
3224 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3225 for characters.
3226
684a03ef
PE
3227 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3228
0fed43f3
PE
3229 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3230 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3231 incorrectly succeed when S was a string, because 4294967386 was
3232 truncated before it was used.
3233
8fd02eb7
PE
3234 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3235 Otherwise, an out-of-range integer could cause undefined behavior
3236 on a 64-bit host.
3237
f8c86b69
PE
3238 * composite.c: Use int, not EMACS_INT, for characters.
3239 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3240 EMACS_INT, for values that are known to be in character range.
3241 This doesn't fix any bugs but is the usual style inside Emacs and
3242 may generate better code on 32-bit machines.
3243
34206dd2
PE
3244 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3245 This is for reasons similar to the recent CHAR_STRING fix.
3246 * charset.c (Fencode_char): Check that character arg is actually
3247 a character. Pass an int to ENCODE_CHAR.
3248 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3249 wider than 'int', as a compile-time check to prevent future regressions
3250 in this area.
3251
c5958d4c 3252 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
3253
3254 Make sure a 64-bit char is never passed to CHAR_STRING.
3255 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3256 by silently ignoring the top 32 bits, allowing some values
3257 that were far too large to be valid characters.
3258 * character.h: Include <verify.h>.
3259 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3260 arguments are no wider than unsigned, as a compile-time check
3261 to prevent future regressions in this area.
3262 * data.c (Faset):
01103c44 3263 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
3264 (Fsubst_char_in_region):
3265 * fns.c (concat):
3266 * xdisp.c (decode_mode_spec_coding):
3267 Adjust to CHAR_STRING's new requirement.
3268 * editfns.c (Finsert_char, Fsubst_char_in_region):
3269 * fns.c (concat): Check that character args are actually
3270 characters. Without this test, these functions did the wrong
3271 thing with wildly out-of-range values on 64-bit hosts.
3272
d37ca623
PE
3273 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3274 These casts should not be needed on 32-bit hosts, either.
3275 * keyboard.c (read_char):
3276 * lread.c (Fload): Remove casts to unsigned.
3277
ea204efb
PE
3278 * lisp.h (UNSIGNED_CMP): New macro.
3279 This fixes comparison bugs on 64-bit hosts.
3280 (ASCII_CHAR_P): Use it.
3281 * casefiddle.c (casify_object):
01103c44 3282 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
3283 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3284 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3285 * dispextern.h (FACE_FROM_ID):
3286 * keyboard.c (read_char): Use UNSIGNED_CMP.
3287
41cb286c
PE
3288 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3289 not to EMACS_INT, to avoid GCC warning.
3290
4a1b9832
PE
3291 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3292
55daad71
PE
3293 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3294 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3295 isn't needed on 32-bit machines.
8f95c75c 3296
01103c44
PE
3297 * buffer.c (Fgenerate_new_buffer_name):
3298 Use EMACS_INT for count, not int.
0ceccced 3299 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
3300
3301 * data.c (Qcompiled_function): Now static.
3302
c6f072e7
PE
3303 * window.c (window_body_lines): Now static.
3304
20ce5912
PE
3305 * image.c (gif_load): Rename local to avoid shadowing.
3306
9c4c5f81
PE
3307 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3308 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3309 * alloc.c (make_save_value): Integer argument is now of type
3310 ptrdiff_t, not int.
3311 (mark_object): Use ptrdiff_t, not int.
3312 * lisp.h (pD): New macro.
3313 * print.c (print_object): Use it.
3314
c0c5c8ae
PE
3315 * alloc.c: Use EMACS_INT, not int, to count objects.
3316 (total_conses, total_markers, total_symbols, total_vector_size)
3317 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
3318 (total_free_floats, total_floats, total_free_intervals)
3319 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
3320 Now EMACS_INT, not int. All uses changed.
3321 (Fgarbage_collect): Compute overall total using a double, so that
3322 integer overflow is less likely to be a problem. Check for overflow
3323 when converting back to an integer.
5a25e253
PE
3324 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3325 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3326 These were 'int' variables that could overflow on 64-bit hosts;
3327 they were never used, so remove them instead of repairing them.
211a0b2a 3328 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
3329 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3330 Previously, this ceilinged at INT_MAX, but that doesn't work on
3331 64-bit machines.
e46bb31a 3332 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 3333
c78baabf 3334 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 3335 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
3336 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3337 when a (possibly-narrower) signed value would do just as well.
3338 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 3339
c9d624c6
PE
3340 * alloc.c: Catch some string size overflows that we were missing.
3341 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3342 for convenience in STRING_BYTES_MAX.
3343 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3344 The definition here is exact; the one in lisp.h was approximate.
3345 (allocate_string_data): Check for string overflow. This catches
3346 some instances we weren't catching before. Also, it catches
3347 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3348 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3349 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 3350
c9d624c6
PE
3351 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3352 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 3353 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 3354
353032ce
PE
3355 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3356
2bccce07
PE
3357 * alloc.c (Fmake_string): Check for out-of-range init.
3358
0ac30604
SM
33592011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3360
3361 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3362
c195f2de
JD
33632011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3364
3365 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3366 xg_get_default_scrollbar_width.
3367
3368 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3369 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3370 (style_changed_cb): Call update_theme_scrollbar_width and call
3371 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3372 all frames (Bug#8505).
3373 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3374 Call gtk_window_set_resizable if HAVE_GTK3.
3375 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3376 and height if HAVE_GTK3 (Bug#8505).
3377 (scroll_bar_width_for_theme): New variable.
3378 (update_theme_scrollbar_width): New function.
3379 (xg_get_default_scrollbar_width): Move code to
3380 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3381 (xg_initialize): Call update_theme_scrollbar_width.
3382
3383 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3384
3385 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3386
e10ac9f1
MR
33872011-06-12 Martin Rudalics <rudalics@gmx.at>
3388
3389 * frame.c (make_frame): Call other_buffer_safely instead of
3390 other_buffer.
3391
3392 * window.c (temp_output_buffer_show): Call display_buffer with
3393 second argument Vtemp_buffer_show_specifiers and reset latter
3394 immediately after the call.
3395 (Vtemp_buffer_show_specifiers): New variable.
3396 (auto_window_vscroll_p, next_screen_context_lines)
3397 (Vscroll_preserve_screen_position): Remove leading asterisks from
3398 doc-strings.
3399
2d3c217e 34002011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 3401
7b7f97e8 3402 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
3403 * buffer.c (Qclone_number): Remove for now, as it's unused.
3404 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3405 (record_buffer): Remove unused local.
3406 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3407 (set_frame_buffer_list): Remove; unused.
3408 * frame.h (other_visible_frames): Remove decl.
3409 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3410 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3411 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3412 if HAVE_GPM.
3413 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3414 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3415 Define only if HAVE_GPM.
3416 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3417 (update_hints_inhibit): Remove; never set. All uses removed.
3418 * widgetprv.h (emacsFrameClassRec): Remove decl.
3419 * window.c (delete_deletable_window): Now returns void, since it
3420 wasn't returning anything.
3421 (compare_window_configurations): Remove unused locals.
3422 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3423 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
3424 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3425 the same widths as pointers. This follows up on the 2011-05-06 patch.
3426 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3427 * xterm.h: Likewise.
3428 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3429
1384b89e
JB
34302011-06-12 Juanma Barranquero <lekktu@gmail.com>
3431
3432 * makefile.w32-in: Update dependencies.
3433 (LISP_H): Add lib/intprops.h.
3434
1100a63c
CY
34352011-06-11 Chong Yidong <cyd@stupidchicken.com>
3436
3437 * image.c (gif_load): Add animation frame delay to the metadata.
3438 (syms_of_image): Use DEFSYM. New symbol `delay'.
3439
6198ccd0
MR
34402011-06-11 Martin Rudalics <rudalics@gmx.at>
3441
3442 * window.c (delete_deletable_window): Re-add.
3443 (Fset_window_configuration): Rewrite to handle dead buffers and
3444 consequently deletable windows.
3445 (window_tree, Fwindow_tree): Remove. Supply functionality in
3446 window.el.
3447 (compare_window_configurations): Simplify code.
3448
b6e3633c
AS
34492011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3450
1ab0dee5
AS
3451 * image.c (imagemagick_load_image): Fix type mismatch.
3452 (Fimagemagick_types): Likewise.
3453
b6e3633c
AS
3454 * window.h (replace_buffer_in_windows): Declare.
3455
9397e56f
MR
34562011-06-11 Martin Rudalics <rudalics@gmx.at>
3457
3458 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3459 Qclone_number. Remove external declaration of Qdelete_window.
3460 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3461 code.
640c8776
SM
3462 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3463 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
3464 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3465 buffer list implementation.
3466 (other_buffer_safely): New function.
3467 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3468 calls to replace_buffer_in_windows and
3469 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3470 if allowed.
3471 (record_buffer): Inhibit quitting and rewrite using quittable
3472 functions. Run Qbuffer_list_update_hook if allowed.
3473 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
3474 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3475 Move switch-to-buffer to window.el.
9397e56f
MR
3476 (bury-buffer): Move to window.el.
3477 (Vbuffer_list_update_hook): New variable.
3478
3479 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3480 section.
3481
3482 * window.h (resize_frame_windows): Move up in code.
3483 (Fwindow_frame): Remove EXFUN.
3484 (replace_buffer_in_all_windows): Remove prototype.
3485 (replace_buffer_in_windows_safely): Add prototype.
3486
3487 * window.c: Declare Qdelete_window static again. Move down
3488 declaration of select_count.
3489 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3490 (Fother_window): Move to window.el.
3491 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3492 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3493 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3494 window.el.
3495 (replace_buffer_in_windows): Implement by calling
3496 Qreplace_buffer_in_windows.
3497 (replace_buffer_in_all_windows): Remove with some functionality
3498 moved into replace_buffer_in_windows_safely.
3499 (replace_buffer_in_windows_safely): New function.
3500 (select_window_norecord, select_frame_norecord): Move in front
3501 of run_window_configuration_change_hook. Remove now obsolete
3502 declarations.
640c8776
SM
3503 (Fset_window_buffer): Rewrite doc-string.
3504 Call Qrecord_window_buffer.
9397e56f
MR
3505 (keys_of_window): Move binding for other-window to window.el.
3506
b50691aa
CY
35072011-06-11 Chong Yidong <cyd@stupidchicken.com>
3508
3509 * dispextern.h (struct image): Replace data member, whose int_val
3510 and ptr_val fields were not used by anything, with a single
3511 lisp_val object.
3512
3513 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3514 (gif_clear_image, gif_load, imagemagick_load_image)
3515 (gs_clear_image, gs_load): Callers changed.
3516
3f754b86
PE
35172011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3518
cca69397
PE
3519 * buffer.h: Include <time.h>, for time_t.
3520 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3521
109e28d0
PE
3522 Fix minor problems found by static checking.
3523
60737f02
PE
3524 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3525
4b66faf3
PE
3526 Make identifiers static if they are not used in other modules.
3527 * data.c (Qcompiled_function, Qframe, Qvector):
3528 * image.c (QimageMagick, Qsvg):
3529 * minibuf.c (Qmetadata):
3530 * window.c (resize_window_check, resize_root_window): Now static.
3531 * window.h (resize_window_check, resize_root_window): Remove decls.
3532
109e28d0
PE
3533 * window.c (window_deletion_count, delete_deletable_window):
3534 Remove; unused.
46a4ce9e
PE
3535 (window_body_lines): Now static.
3536 (Fdelete_other_windows_internal): Mark vars as initialized.
3537 Make sure 'resize_failed' is initialized.
3538 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3539 (resize_window_apply): Remove unused local.
3540 * window.h (delete_deletable_window): Remove decl.
3541
109e28d0 3542 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
3543 (imagemagick_load_image): Fix pointer signedness problem by changing
3544 last arg from unsigned char * to char *. All uses changed.
3545 Also, fix a local for similar reasons.
3546 Remove unused locals. Remove locals to avoid shadowing.
3547 (fn_rsvg_handle_free): Remove; unused.
3548 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 3549 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 3550
3f754b86
PE
3551 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3552
2547adb1
CY
35532011-06-10 Chong Yidong <cyd@stupidchicken.com>
3554
3555 * image.c (gif_load): Fix omitted cast error introduced by
3556 2011-06-06 change.
3557
2c8e37d4
MR
35582011-06-10 Martin Rudalics <rudalics@gmx.at>
3559
3560 * window.h (resize_proportionally, orig_total_lines)
3561 (orig_top_line): Remove from window structure.
3562 (set_window_height, set_window_width, change_window_heights)
3563 (Fdelete_window): Remove prototypes.
3564 (resize_frame_windows): Remove duplicate declaration.
3565
440a42e3
EZ
35662011-06-10 Eli Zaretskii <eliz@gnu.org>
3567
3568 * window.h (resize_frame_windows, resize_window_check)
3569 (delete_deletable_window, resize_root_window)
3570 (resize_frame_windows): Declare prototypes.
3571
3572 * window.c (resize_window_apply): Make definition be "static" to
3573 match the prototype.
3574
562dd5e9
MR
35752011-06-10 Martin Rudalics <rudalics@gmx.at>
3576
3577 * window.c: Remove declarations of Qwindow_size_fixed,
3578 window_min_size_1, window_min_size_2, window_min_size,
3579 size_window, window_fixed_size_p, enlarge_window, delete_window.
3580 Remove static from declaration of Qdelete_window, it's
3581 temporarily needed by Fbury_buffer.
3582 (replace_window): Don't assign orig_top_line and
3583 orig_total_lines.
3584 (Fdelete_window, delete_window): Remove. Window deletion is
3585 handled by window.el.
640c8776
SM
3586 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3587 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
3588 (Fdelete_other_windows): Remove. Deleting other windows is
3589 handled by window.el.
3590 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3591 handled in window.el.
3592 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3593 Window minimum sizes are handled in window.el.
3594 (shrink_windows, size_window, set_window_height)
3595 (set_window_width, change_window_heights, window_height)
3596 (window_width, CURBEG, CURSIZE, enlarge_window)
3597 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3598 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3599 handled in window.el.
3600 (make_dummy_parent): Rename to make_parent_window and give it a
3601 second argument horflag.
3602 (make_window): Don't set resize_proportionally any more.
3603 (Fsplit_window): Remove. Windows are split in window.el.
3604 (save_restore_action, save_restore_orig_size)
3605 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3606 Resize mini windows in window.el.
3607 (grow_mini_window, shrink_mini_window): Implement by calling
3608 Qresize_root_window_vertically, resize_window_check and
3609 resize_window_apply.
640c8776
SM
3610 (saved_window, Fset_window_configuration, save_window_save):
3611 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
3612 resize_proportionally.
3613 (window_min_height, window_min_width): Move to window.el.
3614 (keys_of_window): Move bindings for delete-other-windows,
3615 split-window, delete-window and enlarge-window to window.el.
3616
3617 * buffer.c: Temporarily extern Qdelete_window.
3618 (Fbury_buffer): Temporarily call Qdelete_window instead of
3619 Fdelete_window (Fbury_buffer will move to window.el soon).
3620
3621 * frame.c (set_menu_bar_lines_1): Remove code handling
3622 orig_top_line and orig_total_lines.
3623
3624 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3625 set_window_height but set heights directly.
3626 (change_frame_size_1): Use resize_frame_windows.
3627
3628 * xdisp.c (init_xdisp): Don't use set_window_height but set
3629 heights directly.
3630
640c8776
SM
3631 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3632 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
3633 run_window_configuration_change_hook.
3634
3635 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3636 instead of change_window_heights and run
3637 run_window_configuration_change_hook.
3638
1a13852e
MR
36392011-06-09 Martin Rudalics <rudalics@gmx.at>
3640
3641 * window.c (replace_window): Rename second argument REPLACEMENT to
3642 NEW. New third argument SETFLAG. Rewrite.
3643 (delete_window, make_dummy_parent): Call replace_window with
3644 third argument 1.
3645 (window_list_1): Move down in code.
3646 (run_window_configuration_change_hook): Move set_buffer part
3647 before select_frame_norecord part in order to unwind correctly.
3648 Rename count1 to count.
3649 (recombine_windows, delete_deletable_window, resize_root_window)
3650 (Fdelete_other_windows_internal)
3651 (Frun_window_configuration_change_hook, make_parent_window)
3652 (resize_window_check, resize_window_apply, Fresize_window_apply)
3653 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
3654 (Fdelete_window_internal, Fresize_mini_window_internal):
3655 New functions.
1a13852e
MR
3656 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3657
f3d1777e
MR
36582011-06-08 Martin Rudalics <rudalics@gmx.at>
3659
496e208e
MR
3660 * window.h (window): Add some new members to window structure -
3661 normal_lines, normal_cols, new_total, new_normal, clone_number,
3662 splits, nest, prev_buffers, next_buffers.
3663 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 3664 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 3665
f3d1777e
MR
3666 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3667 Remove.
496e208e
MR
3668 (make_dummy_parent): Set new members of windows structure.
3669 (make_window): Move down in code. Handle new members of window
3670 structure.
3671 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3672 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3673 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3674 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
3675 (Fset_window_next_buffers, Fset_window_clone_number):
3676 New functions.
496e208e
MR
3677 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3678 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3679 Doc-string fixes.
3680 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3681 Argument WINDOW can be now internal window too.
3682 (Fwindow_use_time): Move up in code.
3683 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3684 Rewrite doc-string.
3685 (Fset_window_configuration, saved_window)
3686 (Fcurrent_window_configuration, save_window_save): Handle new
3687 members of window structure.
b9e809c2
MR
3688 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3689 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3690 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3691 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3692 Qget_mru_window, Qresize_root_window,
3693 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3694 Qauto_buffer_name; staticpro them.
f3d1777e 3695
abde8f8c
MR
36962011-06-07 Martin Rudalics <rudalics@gmx.at>
3697
3698 * window.c (Fwindow_total_size, Fwindow_left_column)
3699 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3700 (Fwindow_list_1): New functions.
3701 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
3702 (Fwindow_width, Fscroll_left, Fscroll_right):
3703 Use window_body_cols instead of window_box_text_cols.
3704 (delete_window, Fset_window_configuration):
3705 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
3706 (delete_all_subwindows): Take a window as argument and not a
3707 structure. Rewrite.
190b47e6
MR
3708 (window_loop): Remove handling of GET_LRU_WINDOW and
3709 GET_LARGEST_WINDOW.
3710 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
3711
3712 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
3713 window_box_text_cols. delete_all_subwindows now takes a
3714 Lisp_Object as argument.
abde8f8c 3715
640c8776
SM
3716 * indent.c (compute_motion, Fcompute_motion):
3717 Use window_body_cols instead of window_box_text_cols.
abde8f8c 3718
fa8a67e6
MR
3719 * frame.c (delete_frame): Call delete_all_subwindows with root
3720 window as argument.
3721
a54e3482
DC
37222011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3723
3724 * fns.c (Fputhash): Document return value.
3725
60002bf5
CY
37262011-06-06 Chong Yidong <cyd@stupidchicken.com>
3727
3728 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3729
0c671da6 37302011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 3731
b862a52a 3732 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 3733
be44ca6c
PE
3734 Check for overflow when converting integer to cons and back.
3735 * charset.c (Fdefine_charset_internal, Fdecode_char):
3736 Use cons_to_unsigned to catch overflow.
3737 (Fencode_char): Use INTEGER_TO_CONS.
3738 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3739 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3740 * data.c (long_to_cons, cons_to_long): Remove.
3741 (cons_to_unsigned, cons_to_signed): New functions.
3742 These signal an error for invalid or out-of-range values.
3743 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3744 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3745 * font.c (Ffont_variation_glyphs):
3746 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3747 * lisp.h: Include <intprops.h>.
3748 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3749 (cons_to_signed, cons_to_unsigned): New decls.
3750 (long_to_cons, cons_to_long): Remove decls.
3751 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3752 (Fprimitive_undo): Use CONS_TO_INTEGER.
3753 * xfns.c (Fx_window_property): Likewise.
3754 * xselect.c: Include <limits.h>.
3755 (x_own_selection, selection_data_to_lisp_data):
3756 Use INTEGER_TO_CONS.
3757 (x_handle_selection_request, x_handle_selection_clear)
3758 (x_get_foreign_selection, Fx_disown_selection_internal)
3759 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3760 (lisp_data_to_selection_data): Use cons_to_unsigned.
3761 (x_fill_property_data): Use cons_to_signed.
3762 Report values out of range.
3763
d1f3d2af
PE
3764 Check for buffer and string overflow more precisely.
3765 * buffer.h (BUF_BYTES_MAX): New macro.
3766 * lisp.h (STRING_BYTES_MAX): New macro.
3767 * alloc.c (Fmake_string):
3768 * character.c (string_escape_byte8):
3769 * coding.c (coding_alloc_by_realloc):
3770 * doprnt.c (doprnt):
3771 * editfns.c (Fformat):
3772 * eval.c (verror):
3773 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3774 since they may not be the same number.
3775 * editfns.c (Finsert_char):
3776 * fileio.c (Finsert_file_contents):
3777 Likewise for BUF_BYTES_MAX.
3778
dd52fcea
PE
3779 * image.c: Use ptrdiff_t, not int, for sizes.
3780 (slurp_file): Switch from int to ptrdiff_t.
3781 All uses changed.
3782 (slurp_file): Check that file size fits in both size_t (for
3783 malloc) and ptrdiff_t (for sanity and safety).
3784
7f9bbdbb
PE
3785 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3786 if b->modtime has its maximal value.
3787
dfe18f82
PE
3788 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3789
84acfcf0
PE
3790 Don't assume time_t can fit into int.
3791 * buffer.h (struct buffer.modtime): Now time_t, not int.
3792 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3793 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3794
ccd9a01a
PE
3795 Minor fixes for signed vs unsigned integers.
3796 * character.h (MAYBE_UNIFY_CHAR):
3797 * charset.c (maybe_unify_char):
3798 * keyboard.c (read_char, reorder_modifiers):
3799 XINT -> XFASTINT, since the integer must be nonnegative.
3800 * ftfont.c (ftfont_spec_pattern):
3801 * keymap.c (access_keymap, silly_event_symbol_error):
3802 XUINT -> XFASTINT, since the integer must be nonnegative.
3803 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3804 since it makes no difference and we prefer signed.
3805 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3806 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3807 nonnegative.
3808
d6d100dd
SM
38092011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3810
3811 * window.h (Fwindow_frame): Declare.
3812
2b6148e4
PE
38132011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3814
3815 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3816 (SPARE_MEMORY): Always define.
3817 (LARGE_REQUEST): Remove.
3818 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3819
f230ecc9
MR
38202011-06-06 Martin Rudalics <rudalics@gmx.at>
3821
727e958e
MR
3822 * lisp.h: Move EXFUNS for Fframe_root_window,
3823 Fframe_first_window and Fset_frame_selected_window to window.h.
3824
3825 * window.h: Move EXFUNS for Fframe_root_window,
3826 Fframe_first_window and Fset_frame_selected_window here from
3827 lisp.h.
3828
3829 * frame.c (Fwindow_frame, Fframe_first_window)
3830 (Fframe_root_window, Fframe_selected_window)
3831 (Fset_frame_selected_window): Move to window.c.
3832 (Factive_minibuffer_window): Move to minibuf.c.
3833 (Fother_visible_frames_p): New function.
3834
3835 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3836
f230ecc9
MR
3837 * window.c (decode_window, decode_any_window): Move up in code.
3838 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3839 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
3840 (Fwindow_buffer): Move up and rewrite doc-string.
3841 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3842 (Fwindow_prev): New functions.
727e958e
MR
3843 (Fwindow_frame): Move here from frame.c. Accept any window as
3844 argument.
3845 (Fframe_root_window, Fframe_first_window)
3846 (Fframe_selected_window): Move here from frame.c. Accept frame
3847 or arbitrary window as argument. Update doc-strings.
3848 (Fminibuffer_window): Move up in code.
3849 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
3850 (Fset_frame_selected_window): Move here from frame.c.
3851 Marginal rewrite.
727e958e
MR
3852 (Fselected_window, select_window, Fselect_window): Move up in
3853 code. Minor doc-string fixes.
f230ecc9 3854
4d09bcf6
PE
38552011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3856
3857 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3858 Do not assume that spare memory exists; that assumption is valid
3859 only if SYSTEM_MALLOC.
3860 (LARGE_REQUEST): New macro, so that the issue of large requests
3861 is separated from the issue of spare memory.
3862
810928a2
AS
38632011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3864
172418ad
AS
3865 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3866 format. (Bug#8806)
3867
43f862f7
AS
3868 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3869
810928a2
AS
3870 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3871 before statements.
3872
a059fe24
JD
38732011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3874
3875 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3876
3877 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3878
3879 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3880 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3881
989bf368
JB
38822011-06-05 Juanma Barranquero <lekktu@gmail.com>
3883
3884 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3885
4b80f674
CY
38862011-06-04 Chong Yidong <cyd@stupidchicken.com>
3887
3888 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3889 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
3890 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3891 New error handlers.
4b80f674
CY
3892 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3893 Obey Vx_select_enable_clipboard_manager. Catch errors in
3894 x_clipboard_manager_save (Bug#8779).
3895 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 3896 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 3897
99a33b77 38982011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
3899
3900 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3901
99a33b77 39022011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
3903
3904 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3905 in the current matrix if keep_current_p is non-zero.
3906
8264569d
EZ
39072011-06-04 Eli Zaretskii <eliz@gnu.org>
3908
3909 * bidi.c (bidi_level_of_next_char): Fix last change.
3910
57f97249
EZ
39112011-06-03 Eli Zaretskii <eliz@gnu.org>
3912
fec2107c 3913 Support bidi reordering of text covered by display properties.
57f97249 3914
fec2107c
EZ
3915 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3916 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3917 (bidi_cache_search, bidi_cache_iterator_state)
3918 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
3919 (bidi_level_of_next_char, bidi_move_to_visually_next):
3920 Support character positions inside a run of characters covered by a
fec2107c
EZ
3921 display string.
3922 (bidi_paragraph_init, bidi_resolve_explicit_1)
3923 (bidi_level_of_next_char): Call bidi_fetch_char and
3924 bidi_fetch_char_advance instead of FETCH_CHAR and
3925 FETCH_CHAR_ADVANCE.
3926 (bidi_init_it): Initialize new members.
3927 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3928 definitions.
3929 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3930 instead of using explicit *_CHAR codes.
d6d100dd
SM
3931 (bidi_resolve_explicit, bidi_resolve_weak):
3932 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
3933 bidirectional text is supported only in multibyte buffers.
3934 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3935 it to initialize the frame_window_p member of struct bidi_it.
3936 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3937 (bidi_resolve_explicit, bidi_resolve_weak)
3938 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3939 bidi_it->nchars is non-positive.
3940 (bidi_level_of_next_char): Don't try to lookup the cache for the
3941 next/previous character if nothing is cached there yet, or if we
3942 were just reseat()'ed to a new position.
c40e2fb2 3943
0e14fe90
EZ
3944 * xdisp.c (set_cursor_from_row): Set start and stop points
3945 according to the row's direction when priming the loop that looks
3946 for the glyph on which to display cursor.
3947 (single_display_spec_intangible_p): Function deleted.
3948 (display_prop_intangible_p): Reimplement to call
3949 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
3950 Accept 3 additional arguments needed by handle_display_spec.
3951 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
3952 values: lists, `(when COND...)' forms, etc.
3953 (single_display_spec_string_p): Support property values that are
3954 lists with the argument STRING its top-level element.
3955 (display_prop_string_p): Fix the condition for processing a
3956 property that is a list to be consistent with handle_display_spec.
fec2107c 3957 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
3958 last portion of handle_display_prop.
3959 (compute_display_string_pos): Accept additional argument
3960 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3961 value of a `display' property is a "replacing spec".
3962 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3963 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3964 the display property, but just return a value indicating whether
3965 the display property will replace the characters it covers.
3966 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3967 frame_window_p members of struct bidi_it.
d6d100dd
SM
3968 (compute_display_string_pos, compute_display_string_end):
3969 New functions.
fec2107c
EZ
3970 (push_it): Accept second argument POSITION, where pop_it should
3971 jump to continue iteration.
3972 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 3973
fec2107c
EZ
3974 * keyboard.c (adjust_point_for_property): Adjust the call to
3975 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
3976
3977 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
3978 (bidi_init_it): Update prototypes.
3979 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
3980 (compute_display_string_pos, compute_display_string_end):
3981 Declare prototypes.
fec2107c
EZ
3982 (struct bidi_it): New members nchars and disp_pos. ch_len is now
3983 EMACS_INT.
fc6f18ce 3984
40087514 39852011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 3986
57f53182
PE
3987 Malloc failure behavior now depends on size of allocation.
3988 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
3989 * lisp.h: Change signatures accordingly.
3990 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
3991 All callers changed. (Bug#8762)
3992
3993 * gnutls.c: Use Emacs's memory allocators.
3994 Without this change, the gnutls library would invoke malloc etc.
3995 directly, which causes problems on non-SYNC_INPUT hosts, and which
3996 runs afoul of improving memory_full behavior. (Bug#8761)
3997 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
3998 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
3999 xfree instead of the default malloc, realloc, free.
4000 (Fgnutls_boot): No need to check for memory allocation failure,
4001 since xmalloc does that for us.
4002
ac32cd99 4003 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
4004 * category.c (hash_get_category_set):
4005 * ccl.c (ccl_driver):
4006 * charset.c (Fdefine_charset_internal):
4007 * charset.h (struct charset.hash_index):
4008 * composite.c (get_composition_id, gstring_lookup_cache)
4009 (composition_gstring_put_cache):
4010 * composite.h (struct composition.hash_index):
4011 * dispextern.h (struct image.hash):
4012 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4013 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4014 (hashfn_equal, hashfn_user_defined, make_hash_table)
4015 (maybe_resize_hash_table, hash_lookup, hash_put)
4016 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4017 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4018 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4019 * image.c (make_image, search_image_cache, lookup_image)
4020 (xpm_put_color_table_h):
4021 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 4022 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 4023 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 4024 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
4025 * alloc.c (allocate_vectorlike):
4026 Check for overflow in vector size calculations.
4027 * ccl.c (ccl_driver):
4028 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
4029 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4030 need to be updated by these changes.
40087514
PE
4031 * fns.c (make_hash_table, maybe_resize_hash_table):
4032 Check for integer overflow with large hash tables.
0de4bb68
PE
4033 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4034 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4035 (SXHASH_REDUCE): New macro.
4036 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4037 Use it instead of discarding useful hash info with large hash values.
4038 (sxhash_float): New function.
4039 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4040 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
4041 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4042 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
4043 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4044 Adjust signatures to match updated version of code.
4045 (consing_since_gc): Now EMACS_INT, since a single hash table can
4046 use more than INT_MAX bytes.
4047
698d32e2
DN
40482011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4049
4050 Make it possible to build with GCC-4.6+ -O2 -flto.
4051
4052 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4053
fd6fa53f
SM
40542011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4055
4056 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4057 Call minibuffer-inactive-mode.
4058
864db017
JB
40592011-05-31 Juanma Barranquero <lekktu@gmail.com>
4060
4061 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4062 Update dependencies.
4063
2ad0baf4
DN
40642011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4065
4066 * data.c (init_data): Remove code for UTS, this system is not
4067 supported anymore.
4068
4fcc2638
DN
40692011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4070
4071 Don't force ./temacs to start in terminal mode.
4072
4073 * frame.c (make_initial_frame): Initialize faces in all cases, not
4074 only when CANNOT_DUMP is defined.
4075 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4076
c56e0fd5
DN
40772011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4078
4079 * dispnew.c (add_window_display_history): Use const for the string
4080 pointer. Remove declaration, not needed.
4081
333d54da 40822011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 4083
55d4c1b2 4084 Use 'inline', not 'INLINE'.
333d54da 4085 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
4086 * alloc.c, fontset.c (INLINE): Remove.
4087 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4088 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4089 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4090 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4091 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4092
738db178
DN
40932011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4094
4095 Make it possible to run ./temacs.
4096
4097 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4098 syms_of_callproc does the same thing. Remove test for
4099 "initialized", do it in the caller.
4100 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4101
620c53a6
SM
41022011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4103
4104 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4105 (read_minibuf): Use get_minibuffer.
4106 (syms_of_minibuf): Use DEFSYM.
4107 (Qmetadata): New var.
4108 * data.c (Qbuffer): Don't make it static.
4109 (syms_of_data): Use DEFSYM.
4110
e003a292
PE
41112011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4112
4113 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4114 (CCL_CODE_MIN): New macro.
4115
ed008a6d
PE
41162011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4117
3687c2ef
PE
4118 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4119
ed008a6d
PE
4120 * eval.c (Qdebug): Now static.
4121 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4122 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4123 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4124
d66c4c7c
CY
41252011-05-29 Chong Yidong <cyd@stupidchicken.com>
4126
4127 * image.c: Various fixes to ImageMagick code comments.
4128 (Fimagemagick_types): Doc fix.
4129
5fbc2025
PE
41302011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4131
0196f88a
PE
4132 Minor fixes prompted by GCC 4.6.0 warnings.
4133
4134 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4135
5fbc2025
PE
4136 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4137 (x_clipboard_manager_save_all): Move extern decl to ...
4138 * xterm.h: ... here, so that it can be checked for consistency.
4139
1dd3c2d9
CY
41402011-05-29 Chong Yidong <cyd@stupidchicken.com>
4141
4142 * xselect.c (x_clipboard_manager_save_frame)
4143 (x_clipboard_manager_save_all): New functions.
4144 (Fx_clipboard_manager_save): Lisp function deleted.
4145
4146 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4147 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4148
4149 * xterm.h: Update prototype.
4150
5ba6571d
WX
41512011-05-28 William Xu <william.xwl@gmail.com>
4152
4153 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4154 exiting (Bug#8239).
4155
3eaff834
JM
41562011-05-28 Jim Meyering <meyering@redhat.com>
4157
e1900994 4158 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
4159 * fns.c (to_uchar): Define.
4160 (crypto_hash_function): Use it to convert some newly-signed
4161 variables to unsigned, to avoid sign-extension bugs. For example,
4162 without this change, (md5 "truc") would evaluate to
4163 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4164 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 4165 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 4166
0f6990a7
PE
41672011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4168
4169 Integer overflow fixes.
c8a9ca5a 4170
08686060
PE
4171 * dbusbind.c: Serial number integer overflow fixes.
4172 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
4173 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4174 to hold a serial number that is too large for a fixnum.
4175 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4176 Check for serial numbers out of range. Decode any serial number
59568bf0 4177 that was so large that it became a float. (Bug#8722)
08686060 4178
2d1fc3c7
PE
4179 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4180 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4181 Use XFASTINT rather than XUINT when numbers are nonnegative.
4182 (xd_append_arg, Fdbus_method_return_internal):
4183 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4184 arguments, check that Lisp number is nonnegative, rather than
59568bf0 4185 silently wrapping negative numbers around. (Bug#8722)
30217ff0 4186 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 4187 (Bug#8722)
2d1fc3c7 4188
c8a9ca5a
PE
4189 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4190
519e1d69
PE
4191 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4192
30569699
PE
4193 ccl: add integer overflow checks
4194 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4195 (IN_INT_RANGE): New macros.
4196 (ccl_driver): Use them to check for integer overflow when
4197 decoding a CCL program. Many of the new checks are whether XINT (x)
4198 fits in int; it doesn't always, on 64-bit hosts. The new version
4199 doesn't catch all possible integer overflows, but it's an
847044ea 4200 improvement. (Bug#8719)
30569699 4201
c11285dc
PE
4202 * alloc.c (make_event_array): Use XINT, not XUINT.
4203 There's no need for unsigned here.
4204
fdccd48e
PE
4205 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4206 This follows up to the 2011-05-06 change that substituted uintptr_t
4207 for EMACS_INT. This case wasn't caught back then.
4208
37910ab2
PE
4209 Rework Fformat to avoid integer overflow issues.
4210 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4211 now (part of C89). Include <verify.h>.
4212 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4213 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4214 (Fformat): Avoid the prepass trying to compute sizes; it was only
4215 approximate and thus did not catch overflow reliably. Instead, walk
4216 through the format just once, formatting and computing sizes as we go,
4217 checking for integer overflow at every step, and allocating a larger
4218 buffer as needed. Keep track separately whether the format is
4219 multibyte. Keep only the most-recently calculated precision, rather
4220 than them all. Record whether each argument has been converted to
4221 string. Use EMACS_INT, not int, for byte and char and arg counts.
4222 Support field widths and precisions larger than INT_MAX. Avoid
4223 sprintf's undefined behavior with conversion specifications such as %#d
4224 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4225 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4226 formatting out-of-range floating point numbers with int
9173deec 4227 formats. (Bug#8668)
37910ab2 4228
2e6578fb
PE
4229 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4230
0ae6bdee
PE
4231 * data.c: Avoid integer truncation in expressions involving floats.
4232 * data.c: Include <intprops.h>.
4233 (arith_driver): When there's an integer overflow in an expression
4234 involving floating point, convert the integers to floating point
4235 so that the resulting value does not suffer from catastrophic
4236 integer truncation. For example, on a 64-bit host (* 4
4237 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4238 Do not rely on undefined behavior after integer overflow.
4239
de883a70
PE
4240 merge count_size_as_multibyte, parse_str_to_multibyte
4241 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 4242 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
4243 Check for integer overflow.
4244 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4245 since it's now a duplicate of the other. This is more of
4246 a character than a buffer op, so better that it's in character.c.
4247 * fns.c, print.c: Adjust to above changes.
4248
2ff916cb
PE
42492011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4250
4251 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4252
f1b54466
PE
42532011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4254
fb1ac845
PE
4255 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4256 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4257 (x_clipboard_manager_save): Now static.
4258 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4259
f1b54466
PE
4260 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4261 (crypto_hash_function): Now static.
4262 Fix pointer signedness problems. Avoid unnecessary initializations.
4263
a9f737ee
CY
42642011-05-27 Chong Yidong <cyd@stupidchicken.com>
4265
4266 * termhooks.h (Vselection_alist): Make it terminal-local.
4267
4268 * terminal.c (create_terminal): Initialize it.
4269
4270 * xselect.c: Support for clipboard managers.
4271 (Vselection_alist): Move to termhooks.h as terminal-local var.
4272 (LOCAL_SELECTION): New macro.
4273 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4274 (symbol_to_x_atom): Remove gratuitous arg.
4275 (x_handle_selection_request, lisp_data_to_selection_data)
4276 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
4277 (x_own_selection, x_get_local_selection, x_convert_selection):
4278 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
4279 (some_frame_on_display): Delete unused function.
4280 (Fx_own_selection_internal, Fx_get_selection_internal)
4281 (Fx_disown_selection_internal, Fx_selection_owner_p)
4282 (Fx_selection_exists_p): New optional frame arg.
4283 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4284 (x_handle_selection_clear): Don't treat other terminals with the
4285 same keyboard specially. Use the terminal-local Vselection_alist.
4286 (x_clear_frame_selections): Use Frun_hook_with_args.
4287
4288 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4289
4290 * xterm.h: Add support for those atoms.
4291
e067f0c1
CY
42922011-05-26 Chong Yidong <cyd@stupidchicken.com>
4293
4294 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4295 (converted_selections, conversion_fail_tag): New global variables.
4296 (x_selection_request_lisp_error): Free the above.
4297 (x_get_local_selection): Remove unnecessary code.
4298 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
4299 of converted selections stored in converted_selections.
4300 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
4301 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4302 (x_convert_selection): New function.
4303 (x_handle_selection_event): Simplify.
4304 (x_get_foreign_selection): Don't ignore incoming requests while
4305 waiting for an answer; this will fail when we implement
4306 SAVE_TARGETS, and seems unnecessary anyway.
4307 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4308 (Vx_sent_selection_functions): Doc fix.
4309
0f4aebc0
LL
43102011-05-26 Leo Liu <sdl.web@gmail.com>
4311
4312 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4313
e61124cd
YM
43142011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4315
4316 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4317
4318 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4319 for fringe update if it has periodic bitmap.
ac389d0c 4320 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
4321 and fringe_bitmap_periodic_p.
4322
4323 * fringe.c (get_fringe_bitmap_data): New function.
4324 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4325 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4326 row. Mark glyph row for fringe update if periodicity changed.
4327
4328 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4329 for fringe update unless it has periodic bitmap.
4330
f16d9837
KH
43312011-05-25 Kenichi Handa <handa@m17n.org>
4332
4333 * xdisp.c (get_next_display_element): Set correct it->face_id for
4334 a static composition.
4335
e1b90ef6
LL
43362011-05-24 Leo Liu <sdl.web@gmail.com>
4337
4338 * deps.mk (fns.o):
4339 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4340
4341 * fns.c (crypto_hash_function, Fsha1): New function.
4342 (Fmd5): Use crypto_hash_function.
4343 (syms_of_fns): Add Ssha1.
4344
7400048f
PE
43452011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4346
4347 * gnutls.c: Remove unused macros.
4348 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4349 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4350 Remove macros that are defined and never used.
4351 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4352
abb71cf4
CY
43532011-05-22 Chong Yidong <cyd@stupidchicken.com>
4354
4355 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4356 (Fx_get_selection_internal): Minor cleanup.
4357 (Fx_own_selection_internal): Rename arguments for consistency with
4358 select.el.
4359
6307db39
PE
43602011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4361
4362 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4363
f3d4e0a4
CY
43642011-05-22 Chong Yidong <cyd@stupidchicken.com>
4365
4366 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4367
4d8ade89
YM
43682011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4369
4370 * dispnew.c (scrolling_window): Don't exclude the case that the
4371 last enabled row in the desired matrix touches the bottom boundary.
4372
32078c8d
GM
43732011-05-21 Glenn Morris <rgm@gnu.org>
4374
4375 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
4376 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4377 and add some more files.
32078c8d 4378
7285dc67
EZ
43792011-05-20 Eli Zaretskii <eliz@gnu.org>
4380
4381 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4382 report_file_error introduced by the change from 2011-05-07.
4383
89d1bd22
PE
43842011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4385
4386 * systime.h (Time): Define only if emacs is defined.
4387 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4388 where the include path doesn't have X11/X.h by default. See
4389 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4390
e23640bb 43912011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
4392
4393 * composite.c (find_automatic_composition): Fix previous change.
4394
b9704ad9
GM
43952011-05-20 Glenn Morris <rgm@gnu.org>
4396
4397 * lisp.mk: New file, split from Makefile.in.
4398 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4399 (shortlisp): Remove.
4400 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4401
4a720484
GM
44022011-05-19 Glenn Morris <rgm@gnu.org>
4403
4404 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4405 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4406 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4407 (lisp): Set the order to that of loadup.el.
4408 (shortlisp): Make it a copy of $lisp.
4409 (SOME_MACHINE_LISP): Remove.
4410 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4411 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4412
a28d4396
KH
44132011-05-18 Kenichi Handa <handa@m17n.org>
4414
4415 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4416 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4417 (find_automatic_composition): Mostly rewrite for efficiency.
4418
a2b1fa8e
JB
44192011-05-18 Juanma Barranquero <lekktu@gmail.com>
4420
4421 * makefile.w32-in: Update dependencies.
4422
8e1f5610
CS
44232011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4424
4425 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 4426 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 4427
7025ee00 44282011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 4429
cdfa6eab
PE
4430 Fix some integer overflow issues, such as string length overflow.
4431
06d6db33
PE
4432 * insdel.c (count_size_as_multibyte): Check for string overflow.
4433
2b4560a8
PE
4434 * character.c (lisp_string_width): Check for string overflow.
4435 Use EMACS_INT, not int, for string indexes and lengths; in
4436 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4437 the resulting string length overflows an EMACS_INT; instead,
4438 report a string overflow if no precision given. When checking for
4439 precision exhaustion, use a check that cannot possibly have
4440 integer overflow. (Bug#8675)
4441 * character.h (lisp_string_width): Adjust to new signature.
4442
cb93f9be
PE
4443 * alloc.c (string_overflow): New function.
4444 (Fmake_string): Use it. This doesn't change behavior, but saves
4445 a few bytes and will simplify future changes.
4446 * character.c (string_escape_byte8): Likewise.
4447 * lisp.h (string_overflow): New decl.
4448
1a1f3366
PE
4449 Fixups, following up to the user-interface timestamp change.
4450 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4451 for UI timestamps, instead of unsigned long.
9fbd6841
PE
4452 * msdos.c (mouse_get_pos): Likewise.
4453 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
4454 * w32gui.h (Time): Define by including "systime.h" rather than by
4455 declaring it ourselves. (Bug#8664)
4456
d4e3e4d3
PE
4457 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4458 * image.c (clear_image_cache): Likewise.
4459
f6a24d19
PE
4460 * term.c (term_mouse_position): Don't assume time_t wraparound.
4461
08dc5ae6
PE
4462 Be more systematic about user-interface timestamps.
4463 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
4464 and sometimes 'EMACS_UINT', to represent these timestamps.
4465 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
4466 This makes the code easier to follow, and makes it easier to catch
4467 integer overflow bugs such as Bug#8664.
4468 * frame.c (Fmouse_position, Fmouse_pixel_position):
4469 Use Time, not unsigned long, for user-interface timestamps.
4470 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4471 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4472 * keyboard.h (last_event_timestamp): Likewise.
4473 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4474 * menu.h (xmenu_show): Likewise.
4475 * term.c (term_mouse_position): Likewise.
4476 * termhooks.h (struct input_event.timestamp): Likewise.
4477 (struct terminal.mouse_position_hook): Likewise.
4478 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4479 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4480 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4481 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4482 what it was before.
4483 * menu.h, termhooks.h: Include "systime.h", for Time.
4484
8e55734a
PE
4485 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4486 Don't assume that the difference between two unsigned long values
4487 can fit into an integer. At this point, we know button_down_time
4488 <= event->timestamp, so the difference must be nonnegative, so
4489 there's no need to cast the result if double-click-time is
4490 nonnegative, as it should be; check that it's nonnegative, just in
4491 case. This bug is triggered when events are more than 2**31 ms
86db42d2 4492 apart (about 25 days). (Bug#8664)
8e55734a 4493
841f1b75 4494 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 4495 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 4496
3e26f69c
PE
4497 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4498 that always fit in int. Use a sentinel instead of a counter, to
4499 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
4500 * frame.h (struct frame): Use int for menu_bar_items_used
4501 instead of EMACS_INT, since it always fits in int.
3e26f69c 4502
5cc152c0
PE
4503 * menu.c (grow_menu_items): Check for int overflow.
4504
d89eb65e
PE
4505 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4506
5235bd3e
PE
4507 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4508 Before, the code was not consistent. These values cannot exceed
4509 2**31 - 1 so there's no need to make them unsigned.
4510 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4511 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4512 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4513 as modifiers.
4514 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4515
bc827e23
PE
4516 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4517 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4518 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4519 presumably because the widths might not match.
4520
78eb494e
PE
4521 * window.c (size_window): Avoid needless test at loop start.
4522
04f2d78b
CB
45232011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4524
4525 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4526
d2fc7e3d 45272011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
4528
4529 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4530
d2fc7e3d 45312011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
4532
4533 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4534 `width' to `bar_area_x' and `bar_area_width', respectively.
4535 (x_scroll_run): Take account of fringe background extension.
4536
04f2d78b
CB
4537 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4538 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
4539 `bar_area_width', respectively.
4540 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4541 background extension.
4542
79b70037
GM
45432011-05-10 Jim Meyering <meyering@redhat.com>
4544
4545 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4546
2f142cc5
JB
45472011-05-10 Juanma Barranquero <lekktu@gmail.com>
4548
4549 * image.c (Finit_image_library): Return t for built-in image types,
4550 like pbm and xbm. (Bug#8640)
4551
57679c86
AS
45522011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4553
4554 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4555
888c9e86
EZ
45562011-05-07 Eli Zaretskii <eliz@gnu.org>
4557
b0512a1d
EZ
4558 * w32console.c (Fset_screen_color): Doc fix.
4559 (Fget_screen_color): New function.
4560 (syms_of_ntterm): Defsubr it.
4561
7285dc67
EZ
4562 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4563 unlink the temporary file if Fcall_process didn't create it in the
4564 first place.
4565 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4566 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
4567 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4568 cue to call_process_cleanup not to close that handle.
4569
4d3fcc8e
BK
45702011-05-07 Ben Key <bkey76@gmail.com>
4571
4572 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4573 one of two shell specific rules, either bootstrap-temacs-CMD or
4574 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4575 to the previous implementation of the bootstrap-temacs rule.
4576 The bootstrap-temacs-CMD rule is similar to the previous
4577 implementation of the bootstrap-temacs rule except that it
4578 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4579 variable.
4580
4581 These changes, along with some changes to nt/configure.bat,
4582 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4583 earlier fix to add support for --cflags and --ldflags options
4584 that include quotes so that it works whether make uses cmd or
4585 sh as the shell.
4586
b4289b64
MA
45872011-05-06 Michael Albinus <michael.albinus@gmx.de>
4588
4589 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4590 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4591 is a constant.
4592 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4593 a string. Handle both cases.
4594 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4595 (Fdbus_register_method): Use Qinvalid_function.
4596
af4c0e28
JB
45972011-05-06 Juanma Barranquero <lekktu@gmail.com>
4598
4599 * makefile.w32-in: Update dependencies.
4600 (LISP_H): Add inttypes.h and stdin.h.
4601 (PROCESS_H): Add unistd.h.
4602
c51453d9
EZ
46032011-05-06 Eli Zaretskii <eliz@gnu.org>
4604
4605 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4606 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4607
8ff0ac3c 46082011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 4609
4c4b566b
PE
4610 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4611
aab2b9b5
PE
4612 * term.c (vfatal): Remove stray call to va_end.
4613 It's not needed and the C Standard doesn't allow it here anyway.
4614
c378da0b
PE
4615 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4616 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4617
288b08c7
PE
4618 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4619 bytes.
4620
e3601888
PE
4621 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4622
db6c0e74
PE
4623 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4624
dd5963ea
PE
4625 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4626
88c9450f
PE
4627 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4628
2f9442b8
PE
4629 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4630
c032b5f8
PE
4631 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4632 * charset.c (Fdefine_charset_internal): Don't initialize
4633 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 4634 32-bit int (Bug#8600).
a108c10b
PE
4635
4636 * lread.c (read_integer): Be more consistent with string-to-number.
4637 Use string_to_number to do the actual conversion; this avoids
4638 rounding errors and fixes some other screwups. Without this fix,
4639 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4640 (digit_to_number): Move earlier, for benefit of read_integer.
4641 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 4642 not a digit in any supported base. (Bug#8602)
a108c10b 4643
ad5f9eea
PE
4644 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4645
aec1708a
PE
4646 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4647 to match comment at start of function. This also removes a
4648 GCC warning about overflow in a 32+64-bit port.
4649
47be4ab5
PE
4650 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4651
371cac43
PE
4652 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4653 Reported by Stefan Monnier in
4654 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
4655 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4656 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 4657
d01a7826
PE
4658 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4659 (EMACS_UINTPTR): Likewise, with uintptr_t.
4660
7fd47d5c
PE
4661 * lisp.h: Prefer 64-bit EMACS_INT if available.
4662 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4663 on 32-bit hosts that have 64-bit int, so that they can access
4664 large files.
122b0c86
PE
4665 However, temporarily disable this change unless the temporary
4666 symbol WIDE_EMACS_INT is defined.
7fd47d5c 4667
8727937b
PE
4668 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4669
8ac068ac
PE
4670 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4671 This removes an assumption that EMACS_INT and long are the same
4672 width as pointers. The assumption is true for Emacs porting targets
4673 now, but we want to make other targets possible.
4674 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4675 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4676 In the rest of the code, change types of integers that hold casted
4677 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4678 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4679 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4680 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4681 No need to cast type when ORing.
4682 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4683 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4684 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4685 assume EMACS_INT is the same width as char *.
4686 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4687 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4688 Remove no-longer-needed casts.
4689 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4690 (xg_tool_bar_help_callback, xg_make_tool_item):
4691 Use EMACS_INTPTR to hold an integer
4692 that will be cast to void *; this can avoid a GCC warning
4693 if EMACS_INT is not the same width as void *.
4694 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4695 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4696 (current_message_1, set_message_1):
4697 Use a local to convert to proper width without a cast.
4698 * xmenu.c (dialog_selection_callback): Likewise.
4699
ede49d71
PE
4700 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4701 Also, don't assume VALBITS / RAND_BITS is less than 5,
4702 and don't rely on undefined behavior when shifting a 1 left into
4703 the sign bit.
4704 * lisp.h (get_random): Change signature to match.
4705
2f30ecd0
PE
4706 * lread.c (hash_string): Use size_t, not int, for hash computation.
4707 Normally we prefer signed values; but hashing is special, because
4708 it's better to use unsigned division on hash table sizes so that
4709 the remainder is nonnegative. Also, size_t is the natural width
4710 for hashing into memory. The previous code used 'int', which doesn't
4711 retain enough info to hash well into very large tables.
4712 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4713
2a866e7b
PE
4714 * dbusbind.c: Don't possibly lose pointer info when converting.
4715 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4716 Use XPNTR rather than XHASH, so that the high-order bits of
4717 the pointer aren't lost when converting through void *.
4718
51639eac
PE
4719 * eval.c (Fautoload): Don't double-shift a pointer.
4720
92394119
PE
4721 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4722
dbdb9a7c
JB
47232011-05-06 Juanma Barranquero <lekktu@gmail.com>
4724
4725 * gnutls.c (DEF_GNUTLS_FN):
4726 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4727
db7a0b4f
AS
47282011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4729
4730 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4731 marker. (Bug#8610)
4732
f7ff1b0f 47332011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
4734
4735 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4736 New version that can reserve upto 2GB of heap space.
4737
f7ff1b0f 47382011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
4739
4740 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4741
639c109b
TZ
47422011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4743
4744 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4745 `gnutls_certificate_set_x509_key_file'.
4746
d2127135
JB
47472011-05-05 Juanma Barranquero <lekktu@gmail.com>
4748
4749 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4750 Update dependencies.
4751
e968f4f3
JB
47522011-05-04 Juanma Barranquero <lekktu@gmail.com>
4753
4754 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4755 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4756 Remove unused parameter `fildes'.
4757 * process.c (read_process_output, send_process): Don't pass it.
4758
84d358f0
JB
47592011-05-04 Juanma Barranquero <lekktu@gmail.com>
4760
4761 Fix previous change: the library cache is defined in w32.c.
4762 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4763 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4764
0898ca10
JB
47652011-05-04 Juanma Barranquero <lekktu@gmail.com>
4766
4767 Implement dynamic loading of GnuTLS on Windows.
4768
4769 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4770 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4771 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4772 Declare.
4773
4774 * gnutls.c (Qgnutls_dll): Define.
4775 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4776 (gnutls_*): Declare function pointers.
4777 (init_gnutls_functions): New function to initialize function pointers.
4778 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4779 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4780 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4781 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4782 (emacs_gnutls_write, emacs_gnutls_read)
4783 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4784 (Fgnutls_available_p): New function.
4785 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4786 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4787 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4788
4789 * image.c: Include w32.h.
4790 (Vimage_type_cache): Delete.
4791 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4792 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4793 (w32_delayed_load): Move to w32.c.
4794
4795 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4796
4797 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4798 (w32_delayed_load): Move from image.c. When loading a library, record
4799 its filename in the :loaded-from property of the library id.
4800 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4801 Initialize and staticpro them.
4802 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4803
4804 * process.c: Include lisp.h before w32.h, not after.
4805 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4806 instead of gnutls_record_check_pending.
4807
4808 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4809
ff4de4aa
TZ
48102011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4811
4812 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4813 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4814 as passed in.
4815
abe95abb
JD
48162011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4817
4818 * xterm.c (x_set_frame_alpha): Do not set property on anything
4819 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4820
e16e55d4
JB
48212011-05-02 Juanma Barranquero <lekktu@gmail.com>
4822
4823 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4824
bafcf6a5
JB
48252011-05-02 Juanma Barranquero <lekktu@gmail.com>
4826
4827 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4828 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4829 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4830 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4831 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4832 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4833 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4834 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4835 (Qgnutls_bootprop_callbacks_verify): Make static.
4836
e7a6747f
AS
48372011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4838
19ed11ba
AS
4839 * callproc.c: Indentation fixup.
4840
e7a6747f 4841 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
4842 (wait_for_termination, interruptible_wait_for_termination):
4843 Move after wait_for_termination_1.
e7a6747f 4844
1ef14cb4
LMI
48452011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4846
4847 * sysdep.c (interruptible_wait_for_termination): New function
4848 which is like wait_for_termination, but allows keyboard
4849 interruptions.
4850
4851 * callproc.c (Fcall_process): Add (:file "file") as an option for
4852 the STDOUT buffer.
4853 (Fcall_process_region): Ditto.
4854
330d880c
EZ
48552011-04-30 Eli Zaretskii <eliz@gnu.org>
4856
8db90b73
EZ
4857 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4858 rather than `XVECTOR (FOO)->size'.
4859
330d880c
EZ
4860 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4861 inttypes.h, as a gnulib replacement is used if it not available in
4862 system headers.
4863
15cbd324
EZ
48642011-04-21 Eli Zaretskii <eliz@gnu.org>
4865
4866 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4867 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4868 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4869
4870 * coding.c (coding_alloc_by_realloc): Error out if destination
4871 will grow beyond MOST_POSITIVE_FIXNUM.
4872 (decode_coding_emacs_mule): Abort if there isn't enough place in
4873 charbuf for the composition carryover bytes. Reserve an extra
4874 space for up to 2 characters produced in a loop.
4875 (decode_coding_iso_2022): Abort if there isn't enough place in
4876 charbuf for the composition carryover bytes.
4877
48782011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 4879
ae940cca
EZ
4880 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4881 aborting when %lld or %lll format is passed.
4882 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4883 %llo or %llx format is passed. (Bug#8545)
4884
03ab8921
EZ
4885 * window.c (window_scroll_line_based): Use a marker instead of
4886 simple variables to record original value of point. (Bug#7952)
4887
afda1437
EZ
4888 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4889 produced by %s or %c overflows available buffer space. (Bug#8545)
4890
f76dee0c
PE
48912011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4892
4893 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 4894 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 4895
fdc5744d
JB
48962011-04-28 Juanma Barranquero <lekktu@gmail.com>
4897
4898 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4899
638f053a
JB
49002011-04-28 Juanma Barranquero <lekktu@gmail.com>
4901
4902 * keyboard.c (Qdelayed_warnings_hook): Define.
4903 (command_loop_1): Run `delayed-warnings-hook'
4904 if Vdelayed_warnings_list is non-nil.
4905 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4906 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4907
d178f871
EZ
49082011-04-28 Eli Zaretskii <eliz@gnu.org>
4909
4910 * doprnt.c (doprnt): Don't return value smaller than the buffer
4911 size if the message was truncated. (Bug#8545).
4912
b124fd93
JB
49132011-04-28 Juanma Barranquero <lekktu@gmail.com>
4914
4915 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4916 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4917
e810457d
PE
49182011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4919
4920 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4921
ea51cceb
JB
49222011-04-27 Juanma Barranquero <lekktu@gmail.com>
4923
4924 * makefile.w32-in: Update dependencies.
4925
94dcfacf
EZ
49262011-04-27 Eli Zaretskii <eliz@gnu.org>
4927
4928 Improve `doprnt' and its usage. (Bug#8545)
4929 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4930 `format_end'. Remove support for %l as a conversion specifier.
4931 Don't use xrealloc. Improve diagnostics when the %l size modifier
4932 is used. Update the commentary.
4933
4934 * eval.c (verror): Simplify calculation of size_t.
4935
4936 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4937 messages.
4938
f61f41d7
PE
49392011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4940
4941 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4942 change.
4943
96fb4434
PE
49442011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4945
4946 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4947 This makes this file independent of the recent pseudovector change.
4948
671875da 49492011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 4950
69e9b5a3
PE
4951 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4952
b5f869a7 4953 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 4954 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 4955 Remove unused local.
c8926152 4956 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 4957
841a1577 4958 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
4959 GCC 4.6.0 optimizes based on type-based alias analysis.
4960 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
4961 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4962 != &v->size, and therefore "v->size = 1; b->size = 2; return
4963 v->size;" must therefore return 1. This assumption is incorrect
4964 for Emacs, since it type-puns struct Lisp_Vector * with many other
4965 types. To fix this problem, this patch adds a new type struct
f904488f 4966 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
4967 and pseudovectors, and helps optimizing compilers not get fooled
4968 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4969 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
4970 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4971 the size member.
eab3844f
PE
4972 (XSETPVECTYPE): Rewrite in terms of new macro.
4973 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4974 This is a bit clearer, and further avoids the possibility of
4975 undesirable aliasing.
4976 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 4977 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
4978 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4979 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
4980 (ASIZE): Now uses header.size rather than size.
4981 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
4982 to avoid the hassle of writing XVECTOR (foo)->header.size.
4983 (struct vectorlike_header): New type.
eab3844f
PE
4984 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
4985 object, to help avoid aliasing.
4986 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
4987 (SUBRP): Likewise, since Lisp_Subr is a special case.
4988 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
4989 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
4990 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 4991 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
4992 changed to be "header.size" and "header.next".
4993 * buffer.h (struct buffer): Likewise.
4994 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
4995 * frame.h (struct frame): Likewise.
4996 * process.h (struct Lisp_Process): Likewise.
4997 * termhooks.h (struct terminal): Likewise.
4998 * window.c (struct save_window_data, struct saved_window): Likewise.
4999 * window.h (struct window): Likewise.
5000 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5001 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5002 * buffer.c (init_buffer_once): Likewise.
5003 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5004 special case.
5005 * process.c (Fformat_network_address): Use local var for size,
5006 for brevity.
5007
0df1eac5
PE
5008 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5009
847ab9d1 5010 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
5011 * data.c (atof): Remove decl; no longer used or needed.
5012 (digit_to_number): Move to lread.c.
5013 (Fstring_to_number): Use new string_to_number function, to be
5014 consistent with how the Lisp reader treats infinities and NaNs.
5015 Do not assume that floating-point numbers represent EMACS_INT
5016 without losing information; this is not true on most 64-bit hosts.
5017 Avoid double-rounding errors, by insisting on integers when
5018 parsing non-base-10 numbers, as the documentation specifies.
5019 * lisp.h (string_to_number): New decl, replacing ...
5020 (isfloat_string): Remove.
bc0a5c13 5021 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 5022 (read1): Do not accept +. and -. as integers; this
452f4150
PE
5023 appears to have been a coding error. Similarly, do not accept
5024 strings like +-1e0 as floating point numbers. Do not report
5025 overflow for integer overflows unless the base is not 10 which
5026 means we have no simple and reliable way to continue.
5027 Break out the floating-point parsing into a new
5028 function string_to_number, so that Fstring_to_number parses
5029 floating point numbers consistently with the Lisp reader.
04f2d78b 5030 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
5031 (E_CHAR, EXP_INT): Remove, replacing with ...
5032 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5033 (string_to_number): New function, replacing isfloat_string.
5034 This function checks for valid syntax and produces the resulting
5035 Lisp float number too. Rework it so that string-to-number
bc0a5c13 5036 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
5037 so that overflow for non-base-10 numbers is reported only when
5038 there's no portable and simple way to convert to floating point.
452f4150 5039
67769ffc
PE
5040 * textprop.c (set_text_properties_1): Rewrite for clarity,
5041 and to avoid GCC warning about integer overflow.
5042
c20db43f
PE
5043 * intervals.h (struct interval): Use EMACS_INT for members
5044 where EMACS_UINT might cause problems. See
5045 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5046 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5047 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5048 All uses changed.
37aa2f85
PE
5049 (offset_intervals): Tell GCC not to worry about length overflow
5050 when negating a negative length.
c20db43f 5051
2538aa2f
PE
5052 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5053 (overrun_check_free): Likewise.
5054
f2d3008d
PE
5055 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5056 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5057 word size.
5058
ec8df744
PE
5059 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5060 (gnutls_make_error): Rename local to avoid shadowing.
5061 (gnutls_emacs_global_deinit): ifdef out; not used.
5062 (Fgnutls_boot): Use const for pointer to readonly storage.
5063 Comment out unused local. Fix pointer signedness problems.
5064
640ee02d
PE
5065 * lread.c (openp): Don't stuff size_t into an 'int'.
5066 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5067 about possible signed overflow.
5068
6048fb2a
PE
5069 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5070 (GDK_KEY_g): Don't define if already defined.
5071 (xg_prepare_tooltip): Avoid pointer signedness problem.
5072 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5073
fa3c87e1
PE
5074 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5075 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5076
2172544b
PE
5077 * xfns.c (Fx_window_property): Simplify a bit,
5078 to make a bit faster and to avoid GCC 4.6.0 warning.
5079 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5080
9b821a21
PE
5081 * fns.c (internal_equal): Don't assume size_t fits in int.
5082
3c616cfa
PE
5083 * alloc.c (compact_small_strings): Tighten assertion a little.
5084
c2982e87
PE
5085 Replace pEd with more-general pI, and fix some printf arg casts.
5086 * lisp.h (pI): New macro, generalizing old pEd macro to other
5087 conversion specifiers. For example, use "...%"pI"d..." rather
5088 than "...%"pEd"...".
5089 (pEd): Remove. All uses replaced with similar uses of pI.
5090 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5091 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5092 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5093 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5094 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5095 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5096 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5097 64-bit hosts.
5098 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5099 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5100 * print.c (safe_debug_print, print_object): Likewise.
5101 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5102 to int.
6f04d126
PE
5103 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5104 avoiding the 0 flag, which is not portable.
c2982e87
PE
5105 * process.c (Fmake_network_process): Use pI to avoid cast.
5106 * region-cache.c (pp_cache): Likewise.
5107 * xdisp.c (decode_mode_spec): Likewise.
5108 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5109 behavior on 64-bit hosts with printf arg.
6f04d126 5110 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
5111 (x_stop_queuing_selection_requests): Likewise.
5112 (x_get_window_property): Don't truncate byte count to an 'int'
5113 when tracing.
0b432f21 5114
5e073ec7
PE
5115 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5116 here, since it parses constructs like leading '-' and spaces,
5117 which are not wanted; and it overflows with large numbers.
5118 Instead, simply match F[0-9]+, which is what is wanted anyway.
5119
36372bf9
PE
5120 * alloc.c: Remove unportable assumptions about struct layout.
5121 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5122 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5123 (allocate_vectorlike, make_pure_vector): Use the new macros,
5124 plus offsetof, to remove unportable assumptions about struct layout.
5125 These assumptions hold on all porting targets that I know of, but
5126 they are not guaranteed, they're easy to remove, and removing them
5127 makes further changes easier.
5128
0b432f21
PE
5129 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5130 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
5131 (string_overrun_cookie): Now const. Use initializers that
5132 don't formally overflow signed char, to avoid warnings.
000098c1
PE
5133 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5134 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
5135 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5136 multiple of sizeof (EMACS_INT); it need not be, if
5137 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 5138 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 5139
895009e1
JB
51402011-04-26 Juanma Barranquero <lekktu@gmail.com>
5141
5142 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5143
6a7a1b0b
TZ
51442011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5145
5146 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 5147 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
5148 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5149
841a1577 51502011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
5151
5152 * lisp.h (Qdebug): List symbol.
895009e1 5153 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
5154 * keyboard.c (debug-on-event): New variable.
5155 (handle_user_signal): Break into debugger when debug-on-event
5156 matches the current signal symbol.
5157
f2d3ba6f
DN
51582011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5159
5160 * alloc.c (check_sblock, check_string_bytes)
5161 (check_string_free_list): Convert to standard C.
5162
42ce4c63
TZ
51632011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5164
5165 * w32.c (emacs_gnutls_push): Fix typo.
5166
825cd63c
EZ
51672011-04-25 Eli Zaretskii <eliz@gnu.org>
5168
fb11d64d
EZ
5169 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5170 "cast to pointer from integer of different size".
5171
825cd63c
EZ
5172 Improve doprnt and its use in verror. (Bug#8545)
5173 * doprnt.c (doprnt): Document the set of format control sequences
5174 supported by the function. Use SAFE_ALLOCA instead of always
5175 using `alloca'.
5176
5177 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5178 is one byte too soon. Don't use xrealloc; instead xfree and
5179 xmalloc anew.
5180
e061a11b
TZ
51812011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5182
5183 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5184 callbacks stage.
5185
5186 * gnutls.c: Renamed global_initialized to
5187 gnutls_global_initialized. Added internals for the
5188 :verify-hostname-error, :verify-error, and :verify-flags
5189 parameters of `gnutls-boot' and documented those parameters in the
5190 docstring. Start callback support.
9173deec
JB
5191 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5192 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5193 on error. Return error code.
e061a11b
TZ
5194 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5195 (emacs_gnutls_read): Likewise.
5196 (Fgnutls_boot): Return handshake error code.
5197 (emacs_gnutls_handle_error): New function.
5198 (wsaerror_to_errno): Likewise.
5199
5200 * w32.h (emacs_gnutls_pull): Add prototype.
5201 (emacs_gnutls_push): Likewise.
5202
5203 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5204 (emacs_gnutls_push): Likewise.
5205
52062011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5207
5208 * process.c (wait_reading_process_output): Check if GnuTLS
5209 buffered some data internally if no FDs are set for TLS
5210 connections.
5211
5212 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5213 (LIBS): Link to USER_LIBS.
5214 ($(BLD)/gnutls.$(0)): New target.
5215
fa6996bc
EZ
52162011-04-24 Eli Zaretskii <eliz@gnu.org>
5217
eb35682e
EZ
5218 * xdisp.c (handle_single_display_spec): Rename the
5219 display_replaced_before_p argument into display_replaced_p, to
5220 make it consistent with the commentary. Fix typos in the
5221 commentary.
5222
e2ad650c
EZ
5223 * textprop.c (syms_of_textprop): Remove dead code.
5224 (copy_text_properties): Delete obsolete commentary about an
5225 interface that was deleted long ago. Fix typos in the description
5226 of arguments.
5227
1b2de274
EZ
5228 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5229 to changes in oldXMenu/XMenu.h from 2011-04-16.
5230 <menu_help_message, prev_menu_help_message>: Constify.
5231 (IT_menu_make_room): menu->help_text is now `const char **';
5232 adjust.
5233
5234 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5235 to changes in oldXMenu/XMenu.h from 2011-04-16.
5236 (struct XMenu): Declare `help_text' `const char **'.
5237
5238 * xfaces.c <Qunspecified>: Make extern again.
5239
5240 * syntax.c: Include sys/types.h before including regex.h, as
5241 required by Posix.
5242
762b15be
EZ
5243 * doc.c (get_doc_string): Improve the format passed to `error'.
5244
5245 * doprnt.c (doprnt): Improve commentary.
5246
5247 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5248
5249 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5250 them with etags.
5251
f1052e5d
EZ
5252 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5253 changes in globals.h immediately force recompilation.
762b15be
EZ
5254 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5255 $(CURDIR)/s/ms-w32.h.
5256 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 5257
fa6996bc
EZ
5258 * character.c (Fchar_direction): Function deleted.
5259 (syms_of_character): Don't defsubr it.
5260 <char-direction-table>: Deleted.
5261
e6c3da20
EZ
52622011-04-23 Eli Zaretskii <eliz@gnu.org>
5263
5264 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5265 * doprnt.c: Include limits.h.
5266 (SIZE_MAX): New macro.
04f2d78b
CB
5267 (doprnt): Return a size_t value. 2nd arg is now size_t.
5268 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
5269 Improve overflow protection. Support `l' modifier for integer
5270 conversions. Support %l conversion. Don't assume an EMACS_INT
5271 argument for integer conversions and for %c.
5272
5273 * lisp.h (doprnt): Restore prototype.
5274
5275 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5276 $(SRC)/character.h.
5277
5278 * Makefile.in (base_obj): Add back doprnt.o.
5279
5280 * deps.mk (doprnt.o): Add back prerequisites.
5281 (callint.o): Depend on character.h.
5282
5283 * eval.c (internal_lisp_condition_case): Include the handler
5284 representation in the error message.
5285 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5286 when breaking from the loop.
5287
5288 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5289
5290 * callint.c (Fcall_interactively): When displaying error message
5291 about invalid control letter, pass the character's codepoint, not
5292 a pointer to its multibyte form. Improve display of the character
5293 in octal and display also its hex code.
5294
5295 * character.c (char_string): Use %x to display the (unsigned)
5296 codepoint of an invalid character, to avoid displaying a bogus
5297 negative value.
5298
5299 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5300 `error', not SYMBOL_NAME itself.
5301
5302 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5303 character arguments to `error'.
5304
5305 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5306 to `error' in error message about FINAL_CHAR argument. Make sure
5307 FINAL_CHAR is a character, and use %c when it is passed as
5308 argument to `error'.
5309
4ffd0d6b 53102011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
5311
5312 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5313
5314 * w32.c: Include <time.h>.
5315 (sys_localtime): New function.
5316
4ffd0d6b 53172011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
5318
5319 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5320
4ffd0d6b 5321 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 5322
4ffd0d6b 53232011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 5324
4ffd0d6b
GM
5325 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5326 zombies (Bug#8467).
aac0c6e3 5327
04c56954
EZ
53282011-04-19 Eli Zaretskii <eliz@gnu.org>
5329
5330 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5331 gl_state.e_property when gl_state.object is Qt.
5332
5333 * insdel.c (make_gap_larger): Remove limitation of buffer size
5334 to <= INT_MAX.
5335
16a43933
CY
53362011-04-18 Chong Yidong <cyd@stupidchicken.com>
5337
5338 * xdisp.c (lookup_glyphless_char_display)
5339 (produce_glyphless_glyph): Handle cons cell entry in
5340 glyphless-char-display.
5341 (Vglyphless_char_display): Document it.
5342
5343 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5344 glyphless-char-display.
5345
4581706e
CY
53462011-04-17 Chong Yidong <cyd@stupidchicken.com>
5347
5348 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5349
5350 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5351
5352 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5353 definition for no-X builds.
5354
4887c6e2 53552011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 5356
fd35b6f9
PE
5357 Static checks with GCC 4.6.0 and non-default toolkits.
5358
5c1ccb01
PE
5359 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5360
006c5daa
PE
5361 * process.c (keyboard_bit_set): Define only if SIGIO.
5362 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5363 (send_process): Repair possible setjmp clobbering.
5364
efc736d3
PE
5365 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5366
4e2fe2e6
PE
5367 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5368
f97334a2
PE
5369 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5370
4e75f29d
PE
5371 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5372 Define only if needed.
5373
90efadd1
PE
5374 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5375 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 5376 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 5377
3c647824
PE
5378 * dispextern.h (struct redisplay_interface): Rename param
5379 to avoid shadowing.
e264f262 5380 * termhooks.h (struct terminal): Likewise.
761383f4 5381 * xterm.c (xembed_send_message): Likewise.
3c647824 5382
b58c5c4a
PE
5383 * insdel.c (make_gap_smaller): Define only if
5384 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5385
cad59032
PE
5386 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5387 it.
5388
c339dc2e
PE
5389 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5390 so that we aren't warned about unused symbols.
5391
91a3e27b
PE
5392 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5393
399c71d3 5394 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 5395
8ffc96f5
PE
5396 * xfns.c (x_real_positions): Mark locals as initialized.
5397
eef9bc79
PE
5398 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5399
098db9dd
PE
5400 * xterm.c: Fix problems found by static analysis with other toolkits.
5401 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
5402 (x_dispatch_event): Declare static if USE_GTK, and
5403 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 5404 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 5405 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
5406 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5407 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 5408
eb18f6cc
PE
5409 * xmenu.c (menu_help_callback): Pointer type fixes.
5410 Use const pointers when pointing at readonly data. Avoid pointer
5411 signedness clashes.
5412 (FALSE): Remove unused macro.
5413 (update_frame_menubar): Remove unused decl.
5414
1fe72bf8
PE
5415 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5416
60d9e1db
PE
5417 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5418 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5419 (single_menu_item): Rename local to avoid shadowing.
5420
39261c26
PE
5421 * keyboard.c (make_lispy_event): Remove unused local var.
5422
018c5e19
PE
5423 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5424 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5425
63d2b86e
PE
5426 * bitmaps: Change bitmaps from unsigned char back to the X11
5427 compatible char. Avoid the old compiler warnings about
5428 out-of-range initializers by using, for example, '\xab' rather
5429 than 0xab.
5430
aefd87e1
PE
5431 * xgselect.c (xgselect_initialize): Check vs interface
5432 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5433
bf501fb9
PE
5434 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5435
e9829fdf
PE
5436 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5437 to read-only memory.
5438
1086c095
PE
5439 * fns.c (vector): Remove; this old hack is no longer needed.
5440
2baccd04 5441 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 5442 Remove unused var.
dde42981 5443 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 5444
72391843 5445 * xrdb.c (x_load_resources): Omit unused local.
3565b346 5446
436c16df 5447 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 5448 (x_window): Rename locals to avoid shadowing.
dc5ddd85 5449 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 5450
92bb796d 5451 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 5452 (x_term_init): Remove local to avoid shadowing.
92bb796d 5453
764430a3 5454 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
5455
5456 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5457 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5458
d1dfb56c
EZ
54592011-04-16 Eli Zaretskii <eliz@gnu.org>
5460
c4354cb4
EZ
5461 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5462
d1dfb56c
EZ
5463 Fix regex.c, syntax.c and friends for buffers > 2GB.
5464 * syntax.h (struct gl_state_s): Declare character position members
5465 EMACS_INT.
5466
5467 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5468
04f2d78b
CB
5469 * textprop.c (verify_interval_modification, interval_of):
5470 Declare arguments EMACS_INT.
d1dfb56c
EZ
5471
5472 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5473 EMACS_INT.
5474
5475 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5476
5477 * indent.c (Fvertical_motion): Local variable it_start is now
5478 EMACS_INT.
5479
5480 * regex.c (re_match, re_match_2, re_match_2_internal)
5481 (bcmp_translate, regcomp, regexec, print_double_string)
5482 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5483 (re_compile_pattern, re_exec): Declare arguments and local
5484 variables `size_t' and `ssize_t' and return values `regoff_t', as
5485 appropriate.
5486 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5487 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5488 <compile_stack_type>: `size' and `avail' are now `size_t'.
5489
5490 * regex.h <regoff_t>: Use ssize_t, not int.
5491 (re_search, re_search_2, re_match, re_match_2): Arguments that
5492 specify buffer/string position and length are now ssize_t and
5493 size_t. Return type is regoff_t.
5494
613052cd
BK
54952011-04-16 Ben Key <bkey76@gmail.com>
5496
5497 * nsfont.m: Fixed bugs in ns_get_family and
5498 ns_descriptor_to_entity that were caused by using free to
5499 deallocate memory blocks that were allocated by xmalloc (via
5500 xstrdup). This caused Emacs to crash when compiled with
5501 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5502 --enable-checking=xmallocoverrun). xfree is now used to
5503 deallocate these memory blocks.
5504
4170f62f 55052011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 5506
71b41406
PE
5507 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5508
9587a89d
PE
5509 emacs_write: Accept and return EMACS_INT for sizes.
5510 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5511 et seq.
5512 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5513 Accept and return EMACS_INT.
5514 (emacs_gnutls_write): Return the number of bytes written on
5515 partial writes.
5516 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
5517 (emacs_read, emacs_write): Remove check for negative size, as the
5518 Emacs source code has been audited now.
9587a89d
PE
5519 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5520 (emacs_read, emacs_write): Use it.
273a5f82
PE
5521 * process.c (send_process): Adjust to the new signatures of
5522 emacs_write and emacs_gnutls_write. Do not attempt to store
5523 a byte offset into an 'int'; it might overflow.
9587a89d 5524 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 5525
3e047f51
PE
5526 * sound.c: Don't assume sizes fit in 'int'.
5527 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 5528 Return EMACS_INT, not int.
3e047f51 5529 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
5530 Accept EMACS_INT, not int.
5531 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
5532 record read return values.
5533
cc39a9db
BK
55342011-04-15 Ben Key <bkey76@gmail.com>
5535
c9d0ec6d
JB
5536 * keyboard.c (Qundefined): Don't declare static since it is used
5537 in nsfns.m.
5538 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5539 static since they are used in nsfont.m.
cc39a9db 5540
6c60eb9f
SM
55412011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5542
5543 * process.c (Qprocessp): Don't declare static.
5544 * lisp.h (Qprocessp): Declare again.
5545
7990b61a
JB
55462011-04-15 Juanma Barranquero <lekktu@gmail.com>
5547
5548 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5549
5d4cb038
PE
55502011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5551
8bd7b830 5552 Improve C-level modularity by making more things 'static'.
cd64ea1d 5553
e3b27b31
PE
5554 Don't publish debugger-only interfaces to other modules.
5555 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5556 (verify_bytepos, count_markers): Move decls to the only modules
5557 that need them.
5558 * region-cache.h (pp_cache): Likewise.
5559 * window.h (check_all_windows): Likewise.
5560 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5561
5d4cb038
PE
5562 * sysdep.c (croak): Now static, if
5563 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5564 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
5565
5566 * alloc.c (refill_memory_reserve): Now static if
5567 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5568 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 5569
e87b6180
PE
5570 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5571 Define only if USE_LUCID.
5572
ac64929e
PE
5573 * xrdb.c (x_customization_string, x_rm_string): Now static.
5574
6f37259d
PE
5575 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5576 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5577
1683e3ab
PE
5578 * xdisp.c (draw_row_with_mouse_face): Now static.
5579 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5580
de9c2632
PE
5581 * window.h (check_all_windows): Mark externally visible.
5582
2b96acb7
PE
5583 * window.c (window_deletion_count): Now static.
5584
5585 * undo.c: Make symbols static if they're not exported.
5586 (last_undo_buffer, last_boundary_position, pending_boundary):
5587 Now static.
5588
50436f33
PE
5589 * textprop.c (interval_insert_behind_hooks): Now static.
5590 (interval_insert_in_front_hooks): Likewise.
5591
64520e5c
PE
5592 * term.c: Make symbols static if they're not exported.
5593 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5594 (max_frame_lines, tty_set_terminal_modes):
5595 (tty_reset_terminal_modes, tty_turn_off_highlight):
5596 (get_tty_terminal): Now static.
5597 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5598 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 5599 HAVE_WINDOW_SYSTEM.
64520e5c
PE
5600 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5601 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5602
1fa53021
PE
5603 * sysdep.c: Make symbols static if they're not exported.
5604 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5605 Now static.
5606 (sigprocmask_set, full_mask): Remove; unused.
5607 (wait_debugging): Mark as visible.
5608 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5609 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5610
d4b43b22
PE
5611 * syntax.c (syntax_temp): Define only if !__GNUC__.
5612
b7c513d0
PE
5613 * sound.c (current_sound_device, current_sound): Now static.
5614
989b29ad
PE
5615 * search.c (searchbufs, searchbuf_head): Now static.
5616
13a55a78
PE
5617 * scroll.c (scroll_cost): Remove; unused.
5618 * dispextern.h (scroll_cost): Remove decl.
5619
de68a1fc
PE
5620 * region-cache.h (pp_cache): Mark as externally visible.
5621
40ccffa6
PE
5622 * process.c: Make symbols static if they're not exported.
5623 (process_tick, update_tick, create_process, chan_process):
5624 (Vprocess_alist, proc_buffered_char, datagram_access):
5625 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5626 (deactivate_process): Mark defn as static, as well as decl.
5627 * lisp.h (create_process): Remove decl.
5628 * process.h (chan_process, Vprocess_alist): Remove decls.
5629
ad64fc97
PE
5630 * print.c: Make symbols static if they're not exported.
5631 (print_depth, new_backquote_output, being_printed, print_buffer):
5632 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5633 (print_interval, print_number_index, initial_stderr_stream):
5634 Now static.
5635 * lisp.h (Fprinc): Remove decl.
5636 (debug_output_compilation_hack): Mark as externally visible.
5637
adddb265
PE
5638 * sysdep.c (croak): Move decl from here to syssignal.h.
5639 * syssignal.h (croak): Put it here, so the API can be checked when
5640 'croak' is called from dissociate_if_controlling_tty.
5641
1717ede2
PE
5642 * minibuf.c: Make symbols static if they're not exported.
5643 (minibuf_save_list, choose_minibuf_frame): Now static.
5644 * lisp.h (choose_minibuf_frame): Remove decl.
5645
fa5fb2bc
PE
5646 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5647
1e3890d1
PE
5648 * lread.c: Make symbols static if they're not exported.
5649 (read_objects, initial_obarray, oblookup_last_bucket_number):
5650 Now static.
5651 (make_symbol): Remove; unused.
5652 * lisp.h (initial_obarray, make_symbol): Remove decls.
5653
8a1414fa
PE
5654 * keyboard.c: Make symbols static if they're not exported.
5655 (single_kboard, recent_keys_index, total_keys, recent_keys):
5656 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5657 (this_single_command_key_start, echoing, last_auto_save):
5658 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5659 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5660 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5661 (Vlispy_mouse_stem, double_click_count):
5662 Now static.
5663 (force_auto_save_soon): Define only if SIGDANGER.
5664 (ignore_mouse_drag_p): Now static if
5665 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5666 (print_help): Remove; unused.
5667 (stop_character, last_timer_event): Mark as externally visible.
5668 * keyboard.h (ignore_mouse_drag_p): Declare only if
5669 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5670 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5671 * lisp.h (echoing): Remove decl.
5672 (force_auto_save_soon): Declare only if SIGDANGER.
5673 * xdisp.c (redisplay_window): Simplify code, to make it more
5674 obvious that ignore_mouse_drag_p is not accessed if !defined
5675 USE_GTK && !defined HAVE_NS.
5676
93ea6e8f
PE
5677 * intervals.c: Make symbols static if they're not exported.
5678 (merge_properties_sticky, merge_interval_right, delete_interval):
5679 Now static.
5680 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5681
77382fcc
PE
5682 * insdel.c: Make symbols static if they're not exported.
5683 However, leave prepare_to_modify_buffer alone. It's never
5684 called from outside this function, but that appears to be a bug.
5685 (combine_after_change_list, combine_after_change_buffer):
4889fc82 5686 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
5687 (adjust_after_replace_noundo): Remove; unused.
5688 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 5689 (signal_before_change): Remove decls.
77382fcc 5690
9306c32e
PE
5691 * indent.c (val_compute_motion, val_vmotion): Now static.
5692
cd44d2eb
PE
5693 * image.c: Make symbols static if they're not exported.
5694 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5695 if USE_GTK.
5696 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5697 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5698
ad9a7a06
PE
5699 * fringe.c (standard_bitmaps): Now static.
5700 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5701
81626931
PE
5702 * frame.c: Make symbols static if they're not exported.
5703 (x_report_frame_params, make_terminal_frame): Now static.
5704 (get_frame_param): Now static, unless HAVE_NS.
5705 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5706 (x_get_resource_string): Remove; not used.
5707 * frame.h (make_terminal_frame, x_report_frame_params):
5708 (x_get_resource_string); Remove decls.
5709 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5710 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5711
239f9db9
PE
5712 * font.c, fontset.c: Make symbols static if they're not exported.
5713 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5714 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5715 * font.c (font_close_object): Now static.
5716 * font.h (font_close_object): Remove.
5717 * fontset.c (FONTSET_OBJLIST): Remove.
5718 (free_realized_fontset) #if-0 the body, which does nothing.
5719 (face_suitable_for_char_p): #if-0, as it's never called.
5720 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
5721 * xfaces.c (face_at_string_position):
5722 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
5723 since 0 is always ASCII.
5724
dfcf3579
PE
5725 * fns.c (weak_hash_tables): Now static.
5726
5045092b
PE
5727 * fileio.c: Make symbols static if they're not exported.
5728 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5729 (Vwrite_region_annotation_buffers): Now static.
5730
57a96f5c
PE
5731 * eval.c: Make symbols static if they're not exported.
5732 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5733 * lisp.h (backtrace_list): Remove decl.
5734
35f08c38
PE
5735 * emacs.c: Make symbols static if they're not exported.
5736 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5737 (fatal_error_code, fatal_error_signal_hook, standard_args):
5738 Now static.
5739 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5740 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5741 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5742 * lisp.h (fatal_error_signal_hook): Remove decl.
5743 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5744
f44bd759
PE
5745 * editfns.c: Move a (normally-unused) function to its only use.
5746 * editfns.c, lisp.h (get_operating_system_release): Remove.
5747 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5748 worth the hassle of breaking this out.
5749
b532497d
PE
5750 * xterm.c: Make symbols static if they're not exported.
5751 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5752 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5753 (x_destroy_window, x_delete_display):
5754 Now static.
5755 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5756 (x_mouse_leave): Remove; unused.
5757 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5758 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5759 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5760 Remove decls.
5761 (x_mouse_leave): Declare only if WINDOWSNT.
5762 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5763 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5764 USE_X_TOOLKIT.
5765
1675728f
PE
5766 * ftxfont.c: Make symbols static if they're not exported.
5767 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5768 HAVE_FREETYPE.
5769 * font.h (ftxfont_driver): Likewise.
5770
e4cebfca
PE
5771 * xfns.c: Make symbols static if they're not exported.
5772 (x_last_font_name, x_display_info_for_name):
5773 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5774 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5775 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5776 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5777 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5778 (last_show_tip_args): Now static.
5779 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5780 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5781 (x_screen_planes): Remove; unused.
5782 * dispextern.h (x_screen_planes): Remove decl.
5783
5bf46f05
PE
5784 * dispnew.c: Make symbols static if they're not exported.
5785 * dispextern.h (redraw_garbaged_frames, scrolling):
5786 (increment_row_positions): Remove.
5787 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5788 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5789 Now static.
5790 (redraw_garbaged_frames): Remove; unused.
5791
435f4c28
PE
5792 * xfaces.c: Make symbols static if they're not exported.
5793 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5794 Remove decls.
5795 * xterm.h (defined_color): Remove decls.
5796 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5797 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5798 (menu_face_changed_default, defined_color, free_realized_face):
5799 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5800 (ascii_face_of_lisp_face): Remove; unused.
5801
8524aef3
PE
5802 * xdisp.c: Make symbols static if they're not exported.
5803 * dispextern.h (scratch_glyph_row, window_box_edges):
5804 (glyph_to_pixel_coords, set_cursor_from_row):
5805 (get_next_display_element, set_iterator_to_next):
5806 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5807 (show_mouse_face): Remove decls
5808 * frame.h (message_buf_print): Likewise.
5809 * lisp.h (pop_message, set_message, check_point_in_composition):
5810 Likewise.
5811 * xterm.h (set_vertical_scroll_bar): Likewise.
5812 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5813 (message_buf_print, scratch_glyph_row, displayed_buffer):
5814 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5815 (get_next_display_element, show_mouse_face, window_box_edges):
5816 (frame_to_window_pixel_xy, check_point_in_composition):
5817 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5818 (glyph_to_pixel_coords): Remove; unused.
5819
16390cd2
PE
5820 * dired.c (file_name_completion): Now static.
5821
5822 * dbusbind.c (xd_in_read_queued_messages): Now static.
5823
a25f4dfa
PE
5824 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5825 * data.c (circular_list_error): Remove.
5826
14a9c8df
PE
5827 * commands.h (last_point_position, last_point_position_buffer):
5828 (last_point_position_window): Remove decls.
5829 * keyboard.c: Make these variables static.
5830
04f2d78b
CB
5831 * coding.h (coding, code_convert_region, encode_coding_gap):
5832 Remove decls.
74ab6df5
PE
5833 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5834 (iso_code_class, detect_coding, code_convert_region): Now static.
5835 (encode_coding_gap): Remove; unused.
5836
38dfbee1
PE
5837 * chartab.c (chartab_chars, chartab_bits): Now static.
5838
a2cb4e63
PE
5839 * charset.h (charset_iso_8859_1): Remove decl.
5840 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5841 Now static.
5842
127198fd
PE
5843 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5844 * ccl.c (Vccl_program_table): Now static.
5845 (check_ccl_update): Remove; unused.
5846
d85b608f
PE
5847 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5848 * category.h: ... from here.
5849 * category.c (check_category_table, set_category_set): Now static.
5850
31cd66f3
PE
5851 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5852 * lisp.h: Remove these decls.
5853
c358e587
PE
5854 * buffer.c (buffer_count): Remove unused var.
5855
e78aecca
PE
5856 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5857 so that it's not optimized away.
5858 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5859 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5860 exported only to the debugger.
5861
e192d7d3 5862 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 5863 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 5864
92470028
PE
5865 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5866 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5867 was inaccessible from Lisp.
5868 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5869 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5870
244ed907
PE
5871 alloc.c: Import and export fewer symbols, and remove unused items.
5872 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5873 is defined.
5874 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5875 it's not optimized away by whole-program optimization.
5876 (message_enable_multibyte, free_misc): Remove.
5877 (catchlist, handlerlist, mark_backtrace):
5878 Declare only if BYTE_MARK_STACK.
5879 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5880 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5881 (message_enable_multibyte): Remove decl.
5882 (free_misc, interval_free_list, float_block, float_block_index):
5883 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5884 (cons_free_list, last_marked_index):
5885 Now static.
5886 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5887 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5888 (mark_backtrace): Define only if BYTE_MARK_STACK.
5889 * xdisp.c (message_enable_multibyte): Now static.
5890
61c2b50e 5891 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
5892 This makes it easier for human readers (and static analyzers)
5893 to see whether these variables are used from other modules.
5894 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5895 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5896 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5897 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5898 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5899 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5900 * xmenu.c, xselect.c:
5901 Declare Q* vars static if they are not used in other modules.
5902 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5903 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5904 Remove decls of unexported vars.
5905 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5906
95c82688
PE
5907 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5908
16a97296
PE
5909 Make Emacs functions such as Fatom 'static' by default.
5910 This makes it easier for human readers (and static analyzers)
5911 to see whether these functions can be called from other modules.
5912 DEFUN now defines a static function. To make the function external
5913 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
5914 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5915 (Finit_image_library):
16a97296
PE
5916 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5917 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5918 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5919 Remove decls, since these functions are now static.
5920 (Funintern, Fget_internal_run_time): New decls, since these functions
5921 were already external.
95c82688 5922
16a97296
PE
5923 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5924 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5925 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5926 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5927 * keyboard.c, keymap.c, lread.c:
5928 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5929 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5930 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5931 Mark functions with DEFUE instead of DEFUN,
5932 if they are used in other modules.
5933 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5934 decls for now-static functions.
5935 * buffer.h (Fdelete_overlay): Remove decl.
5936 * callproc.c (Fgetenv_internal): Mark as internal.
5937 * composite.c (Fremove_list_of_text_properties): Remove decl.
5938 (Fcomposition_get_gstring): New forward static decl.
5939 * composite.h (Fcomposite_get_gstring): Remove decl.
5940 * dired.c (Ffile_attributes): New forward static decl.
5941 * doc.c (Fdocumntation_property): New forward static decl.
5942 * eval.c (Ffetch_bytecode): New forward static decl.
5943 (Funintern): Remove extern decl; now in .h file where it belongs.
5944 * fileio.c (Fmake_symbolic_link): New forward static decl.
5945 * image.c (Finit_image_library): New forward static decl.
5946 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5947 * intervals.h (Fprevious_property_change):
5948 (Fremove_list_of_text_properties): Remove decls.
5949 * keyboard.c (Fthis_command_keys): Remove decl.
5950 (Fcommand_execute): New forward static decl.
5951 * keymap.c (Flookup_key): New forward static decl.
5952 (Fcopy_keymap): Now static.
5953 * keymap.h (Flookup_key): Remove decl.
5954 * process.c (Fget_process): New forward static decl.
5955 (Fprocess_datagram_address): Mark as internal.
5956 * syntax.c (Fsyntax_table_p): New forward static decl.
5957 (skip_chars): Remove duplicate decl.
5958 * textprop.c (Fprevious_property_change): New forward static decl.
5959 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5960 Now internal.
5961 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5962 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5963
785bbd42
PE
5964 * editfns.c (Fformat): Remove unreachable code.
5965
8b913b57
AS
59662011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5967
5968 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5969 change. (Bug#8496)
5970
a6744a35
EZ
59712011-04-13 Eli Zaretskii <eliz@gnu.org>
5972
5973 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5974 when at ZV. (Bug#8487)
5975
e7974947
AS
59762011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5977
baad03f0
AS
5978 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5979 (Bug#8437)
5980 * keyboard.c (parse_tool_bar_item): Likewise.
5981 * sound.c (sound_cleanup, alsa_close): Likewise.
5982 * termcap.c (tgetent): Likewise.
5983 * xfns.c (x_default_font_parameter): Likewise.
5984 * xsettings.c (read_and_apply_settings): Likewise.
5985
e7974947
AS
5986 * alloc.c (overrun_check_malloc, overrun_check_realloc)
5987 (overrun_check_free): Protoize.
5988
28272684
PE
59892011-04-12 Paul Eggert <eggert@cs.ucla.edu>
5990
5991 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
5992 since callers should never pass a negative size.
5993 Change the signature to match that of plain 'read' and 'write'; see
5994 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
5995 * lisp.h: Update prototypes of emacs_write and emacs_read.
5996
11997c76
EZ
59972011-04-11 Eli Zaretskii <eliz@gnu.org>
5998
5999 * xdisp.c (redisplay_window): Don't try to determine the character
6000 position of the scroll margin if the window start point w->startp
e896f03c 6001 is outside the buffer's accessible region. (Bug#8468)
11997c76 6002
8a2cbd72
EZ
60032011-04-10 Eli Zaretskii <eliz@gnu.org>
6004
6005 Fix write-region and its subroutines for buffers > 2GB.
6006 * fileio.c (a_write, e_write): Modify declaration of arguments and
6007 local variables to support buffers larger than 2GB.
6008 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6009
6010 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6011 argument, local variables, and return value.
6012
6013 * lisp.h: Update prototypes of emacs_write and emacs_read.
6014
6015 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6016
4073e537 60172011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 6018
1ebfdcb6
PE
6019 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6020
b2ded58d
PE
6021 Fix more problems found by GCC 4.6.0's static checks.
6022
7d66342c
PE
6023 * xdisp.c (vmessage): Use a better test for character truncation.
6024
bbf47d44
PE
6025 * charset.c (load_charset_map): <, not <=, for optimization,
6026 and to avoid potential problems with integer overflow.
9248994d 6027 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 6028 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 6029 * editfns.c (Fformat): Likewise.
1e69125e 6030 * syntax.c (skip_chars): Likewise.
3befa583 6031
e3019616
PE
6032 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6033 This also lets GCC 4.6.0 generate slightly better loop code.
6034
becfa255
PE
6035 * callint.c (Fcall_interactively): <, not <=, for optimization.
6036 (Fcall_interactively): Count the number of arguments produced,
6037 not the number of arguments given. This is simpler and lets GCC
6038 4.6.0 generate slightly better code.
6039
dae0cd48
PE
6040 * ftfont.c: Distingish more carefully between FcChar8 and char.
6041 The previous code passed unsigned char * to a functions like
6042 strlen and xstrcasecmp that expect char *, which does not
6043 conform to the C standard.
6044 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6045 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6046 char * when the C standard requires it.
6047
76032d70
PE
6048 * keyboard.c (read_char): Remove unused var.
6049
eb3f1cc8
PE
6050 * eval.c: Port to Windows vsnprintf (Bug#8435).
6051 Include <limits.h>.
6052 (SIZE_MAX): Define if the headers do not.
6053 (verror): Do not give up if vsnprintf returns a negative count.
6054 Instead, grow the buffer. This ports to Windows vsnprintf, which
6055 does not conform to C99. Problem reported by Eli Zaretskii.
6056 Also, simplify the allocation scheme, by avoiding the need for
6057 calling realloc, and removing the ALLOCATED variable.
6058
70476b54
PE
6059 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6060
12020a9e
PE
6061 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6062 But keep the doprint source code for now, as we might revamp it
6063 and use it again (Bug#8435).
ea6c7ae6
PE
6064 * lisp.h (doprnt): Remove.
6065 * Makefile.in (base_obj): Remove doprnt.o.
6066 * deps.mk (doprnt.o): Remove.
6067
5fdb398c
PE
6068 error: Print 32- and 64-bit integers portably (Bug#8435).
6069 Without this change, on typical 64-bit hosts error ("...%d...", N)
6070 was used to print both 32- and 64-bit integers N, which relied on
6071 undefined behavior.
6072 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6073 New macro.
6074 * lisp.h (error, verror): Mark as printf-like functions.
6075 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6076 Report overflow in size calculations when allocating printf buffer.
6077 Do not truncate output string at its first null byte.
6078 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6079 Truncate the output at a character boundary, since vsnprintf does not
6080 do that.
6081 * charset.c (check_iso_charset_parameter): Convert internal
6082 character to string before calling 'error', since %c now has the
6083 printf meaning.
6084 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6085 overflow when computing char to be passed to 'error'. Do not
6086 pass Lisp_Object to 'error'; pass the integer instead.
6087 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6088 formatted with plain %d.
6089
b189fa66
PE
6090 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6091
bff87ef0
PE
6092 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6093
7e2cac20
PE
6094 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6095
ce4d90b5
PE
6096 * xterm.c (x_catch_errors): Remove duplicate declaration.
6097
266c9547
PE
6098 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6099
79c49ad2
PE
6100 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6101
368f4090
JM
61022011-04-10 Jim Meyering <meyering@redhat.com>
6103
6104 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6105 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6106 return ssize_t not "int", and use size_t as the buffer length.
6107 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6108 * gnutls.h: Update declarations.
6109 * process.c (read_process_output): Use ssize_t, to match.
6110 (send_process): Likewise.
6111
a32d4040
CY
61122011-04-09 Chong Yidong <cyd@stupidchicken.com>
6113
6114 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6115
8546720e 61162011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 6117
04f2d78b
CB
6118 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6119 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 6120
8546720e
GM
6121 * xterm.c (handle_one_xevent):
6122 * xmenu.c (create_and_show_popup_menu):
6123 * xselect.c (x_decline_selection_request)
6124 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 6125
0a2f5c1a 61262011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
6127
6128 Fix some uses of `int' instead of EMACS_INT.
6129 * search.c (string_match_1, fast_string_match)
6130 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6131 (scan_buffer, find_next_newline_no_quit)
6132 (find_before_next_newline, search_command, Freplace_match)
6133 (Fmatch_data): Make some `int' variables be EMACS_INT.
6134
6135 * xdisp.c (display_count_lines): 3rd argument and return value now
6136 EMACS_INT. All callers changed.
6137 (pint2hrstr): Last argument is now EMACS_INT.
6138
6139 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6140 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6141 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6142 (decode_coding_utf_16, decode_coding_emacs_mule)
6143 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6144 (decode_coding_ccl, decode_coding_charset)
6145 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6146 (decode_coding_iso_2022, decode_coding_emacs_mule)
6147 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6148 <char_offset, last_offset>: Declare EMACS_INT.
6149 (encode_coding_utf_8, encode_coding_utf_16)
6150 (encode_coding_emacs_mule, encode_invocation_designation)
6151 (encode_designation_at_bol, encode_coding_iso_2022)
6152 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6153 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6154 Declare EMACS_INT.
6155 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6156 (encode_invocation_designation): Last argument P_NCHARS is now
6157 EMACS_INT.
6158 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6159 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6160
6161 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6162 All users changed.
6163
6164 * ccl.c (Fccl_execute_on_string): Declare some variables
6165 EMACS_INT.
6166
8546720e 61672011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
6168
6169 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6170
4e19a977
CS
61712011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6172
6173 * process.c (Fformat_network_address): Doc fix.
6174
87302331
R
61752011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6176
6177 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6178
cbb59342
CY
61792011-04-08 Chong Yidong <cyd@stupidchicken.com>
6180
6181 * keyboard.c (read_char): Call Lisp function help-form-show,
6182 instead of using internal_with_output_to_temp_buffer.
6183 (Qhelp_form_show): New var.
e0d38eeb 6184 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
6185
6186 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6187
6188 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6189
e67a13ab
CY
61902011-04-06 Chong Yidong <cyd@stupidchicken.com>
6191
04f2d78b
CB
6192 * process.c (Flist_processes): Remove to Lisp.
6193 (list_processes_1): Delete.
e67a13ab 6194
973f782d
EZ
61952011-04-06 Eli Zaretskii <eliz@gnu.org>
6196
7c106b1e
EZ
6197 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6198
973f782d
EZ
6199 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6200
41cf7d1a 62012011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 6202
ca23cc88
PE
6203 Fix more problems found by GCC 4.6.0's static checks.
6204
f390e2d5
PE
6205 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6206
42eea0d0
PE
6207 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6208
b69769da 6209 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 6210
f9541e84
PE
6211 * xdisp.c (vmessage): Mark as a printf-like function.
6212
13841b55
PE
6213 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6214
c136c10f
PE
6215 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6216
5e2d4a30
PE
6217 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6218 printf-like functions.
6219 (tiff_load): Add casts to remove these marks before passing them
6220 to system-supplied API.
6221
583f48b9
PE
6222 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6223
b25d760e
PE
6224 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6225 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
6226 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6227 directly, rather than having caller test rule sign. This avoids
6228 some unnecessary tests.
6229 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6230 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6231 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 6232
bc7b6697 6233 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 6234 (xfont_open): Avoid unnecessary tests.
bc7b6697 6235
27ccc379
PE
6236 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6237
dcd5c89a
PE
6238 * composite.h, composite.c (composition_gstring_put_cache):
6239 Use EMACS_INT, not int, for length.
6240
b13a45c6
PE
6241 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6242 breaking out part of COMPOSITION_DECODE_RULE.
6243 (COMPOSITION_DECODE_RULE): Use it.
6244 * composite.c (get_composition_id): Remove unused local vars,
6245 by using the new macro.
6246
1e792e4d
PE
6247 * textprop.c (set_text_properties_1): Change while to do-while,
6248 since the condition is always true at first.
6249
dc6c6455 6250 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
6251 (interval_deletion_adjustment): Return unsigned value.
6252 All uses changed.
dc6c6455 6253
aba7731a
PE
6254 * process.c (list_processes_1, create_pty, read_process_output):
6255 (exec_sentinel): Remove vars that were set but not used.
afd4052b 6256 (create_pty): Remove unnecessary "volatile"s.
bc57d757 6257 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 6258 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 6259 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 6260
fdfc4bf3
PE
6261 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6262
fca8fe46 6263 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 6264 (update_syntax_table): Use unsigned instead of int.
fca8fe46 6265
06a0259a 6266 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 6267 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 6268 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 6269
e7b9e80f
PE
6270 * print.c (print_error_message): Avoid int overflow.
6271
56201685
PE
6272 * font.c (font_list_entities): Redo for clarity,
6273 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6274
78834453 6275 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 6276 (font_score): Avoid potential overflow in diff calculation.
78834453 6277
0bc0b309 6278 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 6279 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 6280
e610eaca
PE
6281 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6282
b895abce
PE
6283 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6284 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6285 can always succeed if overflow has undefined behavior.
6286
1f1d9321 6287 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 6288 (wordify): Omit three unnecessary tests.
1f1d9321 6289
c59478bc
PE
6290 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6291 All callers changed. This avoids the need for an unused var.
6292
79b73827
PE
6293 * casefiddle.c (casify_region): Remove var that is set but not used.
6294
a4db5dfe
PE
6295 * dired.c (file_name_completion): Remove var that is set but not used.
6296
43aae36e
PE
6297 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6298
2a47c44d 6299 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 6300 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 6301
a37c69bf
PE
6302 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6303 Check for integer overflow on size calculations.
6304
328ab8e7
PE
6305 * buffer.c (Fprevious_overlay_change): Remove var that is set
6306 but not used.
6307
e5a2a5cb
PE
6308 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6309 Remove vars that are set but not used.
8d84a6eb 6310 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 6311 (timer_check_2): Mark vars as initialized.
e5a2a5cb 6312
a60e5f68
PE
6313 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6314
f661cb61 6315 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 6316 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 6317
f0397f5a
PE
6318 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6319 that are set but not used.
6320
8664db06 6321 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 6322 if XCreateBitmapFromData fails (Bug#8410).
8664db06 6323
6abdaa4a
PE
6324 * xselect.c (x_get_local_selection, x_handle_property_notify):
6325 Remove vars that are set but not used.
6326
0ce7538d 6327 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 6328 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 6329
9ae848fc
PE
6330 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6331 Remove var that is set but not used.
0b918413
PE
6332 (scroll_bar_windows_size): Now size_t, not int.
6333 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6334 Check for overflow.
9ae848fc 6335
a5a62657
PE
6336 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6337 (map_tty_color) [!defined MSDOS]: Likewise.
6338
5c5cdd39
PE
6339 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6340
66ebf983
PE
6341 * coding.c: Remove vars that are set but not used.
6342 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6343 All callers changed.
6344 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6345 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6346 (decode_coding_charset): Remove vars that are set but not used.
6347
1be4d761
PE
6348 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6349 that is set but not used.
6350
47553fa8
PE
6351 * print.c (print_object): Remove var that is set but not used.
6352
1f7196bf 6353 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
6354 The gnulib version avoids calling malloc in the usual case,
6355 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6356 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6357 * filelock.c (current_lock_owner): Likewise.
6358 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6359 * sysdep.c: Include allocator.h, careadlinkat.h.
6360 (emacs_no_realloc_allocator): New static constant.
6361 (emacs_readlink): New function.
fdb61804
PE
6362 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6363 ../lib/careadlinkat.h.
d1fdcab7 6364
f84c17c7
SM
63652011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6366
6367 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6368 first non-nil return value).
6369
ef3862ad
JD
63702011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6371
6372 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6373 if not defined (Bug#8403).
6374
376a7006
JB
63752011-04-02 Juanma Barranquero <lekktu@gmail.com>
6376
6377 * xdisp.c (display_count_lines): Remove parameter `start',
6378 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6379 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6380 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6381 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6382 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6383 and thereabouts. All callers changed.
6384 (get_per_char_metric): Remove parameter `f', unused since
6385 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6386
6ca3801d
JM
63872011-04-02 Jim Meyering <meyering@redhat.com>
6388
6389 do not dereference NULL upon failed strdup
6390 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6391 (ns_get_family): Likewise.
6392
d8e2b5ba
JB
63932011-04-02 Juanma Barranquero <lekktu@gmail.com>
6394
6395 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6396
8c74fcbd
JD
63972011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6398
6399 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6400 later (Bug#8403).
6401
7200d79c
SM
64022011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6403
03408648 6404 Add lexical binding.
7200d79c 6405
03408648
SM
6406 * window.c (Ftemp_output_buffer_show): New fun.
6407 (Fsave_window_excursion):
6408 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6409
6410 * lread.c (lisp_file_lexically_bound_p): New function.
6411 (Fload): Bind Qlexical_binding.
6412 (readevalloop): Remove `evalfun' arg.
6413 Bind Qinternal_interpreter_environment.
6414 (Feval_buffer): Bind Qlexical_binding.
6415 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6416 Mark as dynamic.
6417 (syms_of_lread): Declare `lexical-binding'.
6418
6419 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6420
6421 * keyboard.c (eval_dyn): New fun.
6422 (menu_item_eval_property): Use it.
ca105506
SM
6423
6424 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 6425
03408648
SM
6426 * fns.c (concat, mapcar1): Accept byte-code-functions.
6427
6428 * eval.c (Fsetq): Handle lexical vars.
6429 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6430 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6431 (FletX, Flet): Obey lexical binding.
6432 (Fcommandp): Handle closures.
6433 (Feval): New `lexical' arg.
6434 (eval_sub): New function extracted from Feval. Use it almost
6435 everywhere where Feval was used. Look up vars in lexical env.
6436 Handle closures.
6437 (Ffunctionp): Move from subr.el.
6438 (Ffuncall): Handle closures.
6439 (apply_lambda): Remove `eval_flags'.
6440 (funcall_lambda): Handle closures and new byte-code-functions.
6441 (Fspecial_variable_p): New function.
6442 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6443 but without exporting it to Lisp.
23aba0ea 6444
23aba0ea 6445 * doc.c (Fdocumentation, store_function_docstring):
03408648 6446 * data.c (Finteractive_form): Handle closures.
23aba0ea 6447
03408648
SM
6448 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6449 interactive spec.
ba83908c 6450
04f2d78b
CB
6451 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6452 New byte-codes.
03408648
SM
6453 (exec_byte_code): New function extracted from Fbyte_code to handle new
6454 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 6455
03408648 6456 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 6457
03408648 6458 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 6459
e2abce01
JB
64602011-03-31 Juanma Barranquero <lekktu@gmail.com>
6461
6462 * xdisp.c (redisplay_internal): Fix prototype.
6463
63696a73 64642011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 6465
63696a73 6466 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
6467 (try_scrolling): Use it when setting scroll_limit.
6468 Limit scrolling to 100 screen lines.
63696a73
EZ
6469 (redisplay_window): Even when falling back on "recentering",
6470 position point in the window according to scroll-conservatively,
6471 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6472
6473 (try_scrolling): When point is above the window, allow searching
6474 as far as scroll_max, or one screenful, to compute vertical
6475 distance from PT to the scroll margin position. This prevents
6476 try_scrolling from unnecessarily failing when
6477 scroll-conservatively is set to a value slightly larger than the
6478 window height. Clean up the case of PT below the margin at bottom
6479 of window: scroll_max can no longer be INT_MAX. When aggressive
6480 scrolling is in use, don't let point enter the opposite scroll
6481 margin as result of the scroll.
6482 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
6483 threshold of 100 lines for never-recentering scrolling.
6484
e4cc2dfc
JB
64852011-03-31 Juanma Barranquero <lekktu@gmail.com>
6486
6487 * dispextern.h (move_it_by_lines):
6488 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6489 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6490 (message_log_check_duplicate): Remove parameters `prev_bol' and
6491 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6492 (redisplay_internal): Remove parameter `preserve_echo_area',
6493 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6494
6495 * indent.c (Fvertical_motion):
6496 * window.c (window_scroll_pixel_based, Frecenter):
6497 Don't pass `need_y_p' to `move_it_by_lines'.
6498
1c470562
SM
64992011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6500
44f230aa
SM
6501 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6502 steal a few bits to be more compact.
6503 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6504 Remove unneeded casts.
6505
1c470562
SM
6506 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6507
888adce9
ZK
65082011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6509
6510 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6511 binding" message (bug#7967).
6512
f838ed7b
PE
65132011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6514
77861b95
PE
6515 Fix more problems found by GCC 4.6.0's static checks.
6516
de6dbc14
PE
6517 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6518 Remove unused local var.
6519
f838ed7b
PE
6520 * editfns.c (Fmessage_box): Remove unused local var.
6521
792c7b2b
PE
6522 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6523 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6524 Omit unused local vars.
c499e557 6525 * window.c (shrink_windows): Omit unused local var.
b01a1c29 6526 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
6527 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6528 Omit unused local var.
6529
ba0165e1
PE
6530 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6531 Don't assume string length fits in int.
32ad8845 6532 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 6533 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 6534
3c59b4c9
PE
6535 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6536 instead of alloca (Bug#8344).
6537
a3eed478 6538 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 6539 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 6540
eb4d412d
PE
6541 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6542
1658b401
PE
6543 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6544 concerns.
6545
6546 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6547
6548 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 6549
9a2c6e05
PE
6550 * keyboard.c (syms_of_keyboard): Use the same style as later
6551 in this function when indexing through an array. This also
6552 works around GCC bug 48267.
6553
03d0a109
PE
6554 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6555
44f730c8
PE
6556 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6557
fe75f926
PE
6558 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6559 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6560
ffa8c828
PE
6561 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6562 This avoids undefined behavior on integer overflow, and is a bit
6563 more convenient anyway since it is compared to a size_t variable.
6564
c5101a77
PE
6565 Variadic C functions now count arguments with size_t, not int.
6566 This avoids an unnecessary limitation on 64-bit machines, which
6567 caused (substring ...) to crash on large vectors (Bug#8344).
6568 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6569 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 6570 All variadic functions and their callers changed accordingly.
c5101a77
PE
6571 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6572 * data.c (arith_driver, float_arith_driver): Likewise.
6573 * editfns.c (general_insert_function): Likewise.
6574 * eval.c (struct backtrace.nargs, interactive_p)
6575 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6576 (funcall_lambda, mark_backtrace): Likewise.
6577 * fns.c (concat): Likewise.
6578 * frame.c (x_set_frame_parameters): Likewise.
6579 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6580 0 if not found, not -1. All callers changed.
6581
dd3f25f7
PE
6582 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6583 (stack_copy_size): Now size_t, not int.
6584 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6585
461c2ab9
JB
65862011-03-28 Juanma Barranquero <lekktu@gmail.com>
6587
6588 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6589 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6590 All callers changed.
6591
6592 * lisp.h (multibyte_char_to_unibyte):
6593 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6594 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6595 * character.h (CHAR_TO_BYTE8):
6596 * cmds.c (internal_self_insert):
6597 * editfns.c (general_insert_function):
6598 * keymap.c (push_key_description):
6599 * search.c (Freplace_match):
6600 * xdisp.c (message_dolog, set_message_1): All callers changed.
6601
f6d62986
SM
66022011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6603
6604 * keyboard.c (safe_run_hook_funcall): New function.
6605 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6606 don't set the hook to nil, but remove the offending function instead.
6607 (Qcommand_hook_internal): Remove, unused.
6608 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6609 Vcommand_hook_internal.
6610
6611 * eval.c (enum run_hooks_condition): Remove.
6612 (funcall_nil, funcall_not): New functions.
6613 (run_hook_with_args): Call each function through a `funcall' argument.
6614 Remove `cond' argument, now redundant.
6615 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6616 (Frun_hook_with_args_until_failure): Adjust accordingly.
6617 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6618
1db5b1ad
JB
66192011-03-28 Juanma Barranquero <lekktu@gmail.com>
6620
6621 * dispextern.h (string_buffer_position): Remove declaration.
6622
6623 * print.c (strout): Remove parameter `multibyte', unused since
6624 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6625
6626 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6627 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6628 All callers changed.
6629
6630 * w32.c (_wsa_errlist): Use braces for struct initializers.
6631
6632 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6633 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6634 All callers changed.
6635 (string_buffer_position): Likewise. Also, make static (it's never
6636 used outside xdisp.c).
6637 (cursor_row_p): Remove parameter `w', unused since
6638 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6639 (decode_mode_spec): Remove parameter `precision', introduced during
6640 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6641 All callers changed.
6642
5ffb62aa
JD
66432011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6644
6645 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6646
461c2ab9 66472011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
6648
6649 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6650 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6651 (ns_update_auto_hide_menu_bar): New functions.
6652 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6653 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6654 ns_constrain_all_frames.
6655 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6656 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6657
5c380ffb
JD
66582011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6659
6660 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6661
9af30bdf
GM
66622011-03-27 Glenn Morris <rgm@gnu.org>
6663
6664 * syssignal.h: Replace RETSIGTYPE with void.
6665 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6666 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6667 Replace SIGTYPE with void everywhere.
6668 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6669 * s/template.h (SIGTYPE): Remove commented out definition.
6670
e2abce01
JB
66712011-03-26 Eli Zaretskii <eliz@gnu.org>
6672
6673 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6674 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6675
f868cd8a
JB
66762011-03-26 Juanma Barranquero <lekktu@gmail.com>
6677
59eb0929
JB
6678 * w32.c (read_unc_volume): Use parameter `henum', instead of
6679 global variable `wget_enum_handle'.
6680
6681 * keymap.c (describe_vector): Remove parameters `indices' and
6682 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6683 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6684
f868cd8a
JB
6685 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6686
6687 * keyboard.c (timer_check): Remove parameter `do_it_now',
6688 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6689 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6690 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6691
6692 * keyboard.c (read_char):
6693 * w32menu.c (w32_menu_display_help):
6694 * xmenu.c (show_help_event, menu_help_callback):
6695 Adjust calls to `show_help_echo'.
6696
6697 * gtkutil.c (xg_maybe_add_timer):
6698 * keyboard.c (readable_events):
6699 * process.c (wait_reading_process_output):
6700 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6701
6702 * insdel.c (adjust_markers_gap_motion):
6703 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6704 (gap_left, gap_right): Don't call it.
6705
2ecf6fdb
CY
67062011-03-25 Chong Yidong <cyd@stupidchicken.com>
6707
6708 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6709 incurred during fontification.
6710
6b1f9ba4
JB
67112011-03-25 Juanma Barranquero <lekktu@gmail.com>
6712
6713 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6714 (DEFVAR_PER_BUFFER): Don't pass it.
6715
6716 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6717 (scrolling_window): Don't pass it.
6718
0f4a96b5
JB
67192011-03-25 Juanma Barranquero <lekktu@gmail.com>
6720
6721 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6722
6723 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6724 and `suffix'.
6725 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6726 of variables specific to SELinux and computation of `encoded_absname'.
6727
6728 * image.c (XPutPixel): Remove unused variable `height'.
6729
6730 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6731
6732 * unexw32.c (get_section_info): Remove unused variable `section'.
6733
6734 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6735 (system_process_attributes): Remove unused variable `sess'.
6736 (sys_read): Remove unused variable `err'.
6737
6738 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6739 (w32_wnd_proc): Remove unused variable `isdead'.
6740 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6741 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6742 (x_create_tip_frame): Remove unused variable `tem'.
6743
6744 * w32inevt.c (w32_console_read_socket):
6745 Remove unused variable `no_events'.
6746
6747 * w32term.c (x_draw_composite_glyph_string_foreground):
6748 Remove unused variable `width'.
6749
1149507c
JB
67502011-03-24 Juanma Barranquero <lekktu@gmail.com>
6751
6752 * w32term.c (x_set_glyph_string_clipping):
6753 Don't pass uninitialized region to CombineRgn.
6754
9c88f339
JB
67552011-03-23 Juanma Barranquero <lekktu@gmail.com>
6756
6757 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6758 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6759 (Fx_close_connection): Remove unused variable `i'.
6760
6761 * w32font.c (w32font_draw): Return number of glyphs.
6762 (w32font_open_internal): Remove unused variable `i'.
6763 (w32font_driver): Add missing initializer.
6764
6765 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6766 (fill_in_menu): Remove unused variable `items_added'.
6767
6768 * w32term.c (last_mouse_press_frame): Remove static global variable.
6769 (w32_clip_to_row): Remove unused variable `f'.
6770 (x_delete_terminal): Remove unused variable `i'.
6771
6772 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6773 (NOTHING): Remove unused static global variable.
6774 (uniscribe_check_otf): Remove unused variable `table'.
6775 (uniscribe_font_driver): Add missing initializers.
6776
dee091a3
JD
67772011-03-23 Julien Danjou <julien@danjou.info>
6778
6779 * term.c (Fsuspend_tty, Fresume_tty):
6780 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6781 * window.c (temp_output_buffer_show):
6782 * insdel.c (signal_before_change):
6783 * frame.c (Fhandle_switch_frame):
6784 * fileio.c (Fdo_auto_save):
6785 * emacs.c (Fkill_emacs):
6786 * editfns.c (save_excursion_restore):
6787 * cmds.c (internal_self_insert):
6788 * callint.c (Fcall_interactively):
6789 * buffer.c (Fkill_all_local_variables):
6790 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6791 Use Frun_hooks.
0f4a96b5 6792 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
6793 unconditionnaly since it does the check itself.
6794
2c520ab5 67952011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 6796
c9c49752
PE
6797 Fix more problems found by GCC 4.5.2's static checks.
6798
8abc3f12
PE
6799 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6800 the first time through the loop, since we know p0 < p1 then.
6801 This also avoids a gcc -Wstrict-overflow warning.
6802
a2d26660
PE
6803 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6804 leading to a memory leak, possible in functions like
6805 load_charset_map_from_file that can allocate an unbounded number
b12ef411 6806 of objects (Bug#8318).
a2d26660 6807
916c72e9
PE
6808 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6809 that could (at least in theory) be that large.
6810
19ab8a18
PE
6811 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6812 This is less likely to overflow, and avoids undefined behavior if
6813 overflow does occur. All callers changed. Use strtoul to scan
6814 for the unsigned long integer.
b7cbbd6f
PE
6815 (pint2hrstr): Simplify and tune code slightly.
6816 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 6817
f0641eff
PE
6818 * scroll.c (do_scrolling): Work around GCC bug 48228.
6819 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6820
7f650bb9
PE
6821 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6822 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
6823 (validate_x_resource_name): Simplify count usage.
6824 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 6825
37dd57d1
PE
6826 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6827 fail (Bug#8306).
81e56e61 6828
699979fc 6829 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 6830
401bf9b4
PE
6831 * process.c (Fmake_network_process): Use socklen_t, not int,
6832 where POSIX says socklen_t is required in portable programs.
6833 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 6834 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
6835 (Fmake_network_process, server_accept_connection):
6836 (wait_reading_process_output, read_process_output):
6837 Likewise.
6838
b93aacde
PE
6839 * process.c: Rename or move locals to avoid shadowing.
6840 (list_processes_1, Fmake_network_process):
6841 (read_process_output_error_handler, exec_sentinel_error_handler):
6842 Rename or move locals.
4dc343ee 6843 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 6844 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 6845 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 6846 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 6847 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 6848
af8a867c 6849 Make tparam.h and terminfo.c consistent.
44f230aa
SM
6850 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6851 Include tparam.h instead, since it declares them.
af8a867c
PE
6852 * cm.h (PC): Remove extern decl; tparam.h now does this.
6853 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6854 * terminfo.c: Include tparam.h, to check interfaces.
6855 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6856 (tparam): Adjust signature to match interface in tparam.h;
6857 this removes some undefined behavior. Check that outstring and len
6858 are zero, which they always are with Emacs.
6859 * tparam.h (PC, BC, UP): New extern decls.
6860
0248044d 6861 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 6862 (xftfont_open): Rename locals to avoid shadowing.
0248044d 6863
8ff096c1 6864 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
6865 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6866 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 6867 (ftfont_list): Remove unused local.
49eaafba
PE
6868 (get_adstyle_property, ftfont_pattern_entity):
6869 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6870 Rename locals to avoid shadowing.
8ff096c1 6871
e2be39f6
PE
6872 * xfont.c (xfont_list_family): Mark var as initialized.
6873
c9735e30
PE
6874 * xml.c (make_dom): Now static.
6875
8f5201ae
PE
6876 * composite.c (composition_compute_stop_pos): Rename local to
6877 avoid shadowing.
b246f932
PE
6878 (composition_reseat_it): Remove unused locals.
6879 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 6880 (composition_update_it): Mark var as initialized.
11b61122
PE
6881 (find_automatic_composition): Mark vars as initialized,
6882 with a FIXME (Bug#8290).
8f5201ae 6883
760fbc2c
PE
6884 character.h: Rename locals to avoid shadowing.
6885 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6886 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6887 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6888 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6889 to avoid shadowing.
6890
ff08eb85
PE
6891 * textprop.c (property_change_between_p): Remove; unused.
6892
fc7bf025
PE
6893 * intervals.c (interval_start_pos): Now static.
6894
235d7abc
PE
6895 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6896
44f230aa
SM
6897 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6898 Rename locals to avoid shadowing.
3e7d6594 6899
50060332
PE
6900 * sound.c (wav_play, au_play, Fplay_sound_internal):
6901 Fix pointer signedness.
d01f234b 6902 (alsa_choose_format): Remove unused local var.
c83b8872
PE
6903 (wav_play): Initialize a variable to 0, to prevent undefined
6904 behavior (Bug#8278).
50060332 6905
c4fc4e30
PE
6906 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6907
918436ed
PE
6908 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6909
c939f91b
PE
6910 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6911 clobbering (Bug#8298).
b9c7f648
PE
6912 * sysdep.c (sys_subshell): Likewise.
6913 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 6914
6bd8c144
PE
6915 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6916 This should get cleaned up, so that child_setup has the
6917 same signature on all platforms.
6918
7710357c 6919 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 6920 (relocate_fd): Rename locals to avoid shadowing.
7710357c 6921
c59da222
CY
69222011-03-22 Chong Yidong <cyd@stupidchicken.com>
6923
6924 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6925 not to be necessary, and produces flickering.
6926
66b87493
GM
69272011-03-20 Glenn Morris <rgm@gnu.org>
6928
6929 * config.in: Remove file.
6930
45b6f6d5
JB
69312011-03-20 Juanma Barranquero <lekktu@gmail.com>
6932
6933 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6934 are now in src/globals.h.
6935 (syms_of_minibuf): Remove spurious & from previous change.
6936
3ec03f7e
LL
69372011-03-20 Leo <sdl.web@gmail.com>
6938
6939 * minibuf.c (completing-read-function): New variable.
6940 (completing-read-default): Rename from completing-read.
6941 (completing-read): Call completing-read-function.
6942
b14e3e21
CY
69432011-03-19 Juanma Barranquero <lekktu@gmail.com>
6944
6945 * xfaces.c (Fx_load_color_file):
6946 Read color file from absolute filename (bug#8250).
6947
f2b726e6
JB
69482011-03-19 Juanma Barranquero <lekktu@gmail.com>
6949
6950 * makefile.w32-in: Update dependencies.
6951
09f6ff02
EZ
69522011-03-17 Eli Zaretskii <eliz@gnu.org>
6953
6954 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6955
29a6015a
PE
69562011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6957
a3a6c54e
PE
6958 Fix more problems found by GCC 4.5.2's static checks.
6959
b766f867
PE
6960 * process.c (make_serial_process_unwind, send_process_trap):
6961 (sigchld_handler): Now static.
6962
be02381c
PE
6963 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6964 That way, the code declares only the vars that it needs.
6965 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6966 * s/cygwin.h (PTY_ITERATION): Likewise.
6967 * s/darwin.h (PTY_ITERATION): Likewise.
6968 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6969
57048744
PE
6970 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6971 * process.c (allocate_pty): Don't declare stb unless it's needed.
6972
7914961c 6973 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
6974 (CONSTANTLIM): Remove; unused.
6975 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6976 Define only if needed.
7914961c 6977
b3967b18
PE
6978 * unexelf.c (unexec): Name an expression,
6979 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
6980 Use a different way to cause a compilation error if anyone uses
6981 n rather than nn, a way that does not involve shadowing.
73366a00 6982 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 6983
29a6015a
PE
6984 * deps.mk (unexalpha.o): Remove; unused.
6985
43cfc33e 6986 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 6987 * unexec.h: New file.
ce701a33
PE
6988 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
6989 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
6990 Depend on unexec.h.
6991 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
6992 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
6993 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 6994 Change as necessary to match prototype in unexec.h.
ce701a33 6995
01f44d5a
PE
6996 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
6997 shadowing.
4f63c6bb 6998 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 6999
a6670b0b
PE
7000 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7001 Rename locals to avoid shadowing.
7002
cef2010d 7003 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 7004 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 7005
d4d7173a
PE
7006 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7007
f08b802a
PE
7008 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7009 warning when compiling print.c.
7010
3ddb0639
PE
7011 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7012 instead of using an uninitialized var.
5ad03b97 7013 (font_sort_entities): Mark var as initialized.
3ddb0639 7014
170a2692
PE
7015 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7016
e663c700
PE
7017 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7018 pointers to constants.
89bc529a 7019 (font_parse_fcname): Remove unused vars.
7b81e2d0 7020 (font_delete_unmatched): Now static.
ea838e10 7021 (font_get_spec): Remove; unused.
13a547c6
PE
7022 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7023 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7024 Rename or move locals to avoid shadowing.
e663c700 7025
2a80c887 7026 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 7027 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 7028
1384fa33 7029 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 7030 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 7031
8b2c52e9
PE
7032 * alloc.c (mark_backtrace): Move decl from here ...
7033 * lisp.h: ... to here, so that it can be checked.
7034
475545b5 7035 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 7036 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
7037 (lisp_indirect_variable): Name an expression,
7038 to avoid gcc -Wbad-function-cast warning.
1faed8ae 7039 (Fdefvar): Rename locals to avoid shadowing.
475545b5 7040
b1349114 7041 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 7042 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 7043 Use const pointer when appropriate.
b1349114 7044
a2928364
PE
7045 * lisp.h (get_system_name, get_operating_system_release):
7046 Move decls here, to check interfaces.
7047 * process.c (get_operating_system_release): Move decl to lisp.h.
7048 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
7049 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7050 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7051 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
7052 (Fformat_time_string, Fencode_time, Finsert_char):
7053 (Ftranslate_region_internal, Fformat):
7054 Rename or remove local vars to avoid shadowing.
9710023e 7055 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 7056
a415e694
PE
7057 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7058 avoid shadowing.
7059
8ef4622d
PE
7060 * lisp.h (eassert): Check that the argument compiles, even if
7061 ENABLE_CHECKING is not defined.
7062
946f9a5b
PE
7063 * data.c (Findirect_variable): Name an expression, to avoid
7064 gcc -Wbad-function-cast warning.
112396d6 7065 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 7066 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
7067 (Fmake_variable_buffer_local, Fmake_local_variable):
7068 Mark variables as initialized.
52746918 7069 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 7070
e5aab7e7 7071 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
7072 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7073 Rename locals to avoid shadowing.
dff45157
PE
7074 (mark_stack): Move local variables into the #ifdef region where
7075 they're used.
7bc26fdb
PE
7076 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7077 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7078 needed otherwise.
7079 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7080 (GC_STRING_CHARS): Remove; not used.
d40d4be1 7081 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 7082
e5aab7e7
PE
7083 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7084 avoids undefined behavior in theory.
7085
4da60324
PE
7086 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7087
88043301
PE
7088 Use functions, not macros, for up- and down-casing (Bug#8254).
7089 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7090 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7091 to use the following functions instead of these macros.
7092 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7093 EMACS_INT, since callers assume the returned value fits in int.
7094 (upcase1): Likewise, for UPCASE_TABLE.
7095 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 7096 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 7097 the race-condition problem in the old DOWNCASE.
88043301 7098
19ed5445
PE
7099 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7100 Rename locals to avoid shadowing.
7101 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
7102 (regex_compile, re_search_2, re_match_2_internal):
7103 Remove unused local vars.
952db0d7
PE
7104 (FREE_VAR): Rewrite so as not to use empty "else",
7105 which gcc can warn about.
da053e48 7106 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
7107 (RETALLOC_IF): Define only if needed.
7108 (WORDCHAR_P): Likewise. This one is never needed, but is used
7109 only in a comment talking about a compiler bug, so put inside
7110 the #if 0 of that comment.
7111 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7112 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7113 Remove; unused.
19ed5445 7114
1f3561e4 7115 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
7116 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7117 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 7118
ded6f8f7
PE
7119 * search.c (simple_search): Remove unused var.
7120
dbd37a95
PE
7121 * dired.c (compile_pattern): Move decl from here ...
7122 * lisp.h: ... to here, so that it can be checked.
7123 (struct re_registers): New forward decl.
7124
7e47afad
PE
7125 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7126
85f24f61
PE
7127 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7128 All uses changed.
7129 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7130 Rename locals to avoid shadowing.
5671df8f 7131 (Fvertical_motion): Mark locals as initialized.
85f24f61 7132
181aa2be 7133 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 7134 (casify_region): Mark local as initialized.
181aa2be 7135
930d429c
PE
7136 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7137
7082eac6
PE
7138 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7139 New macros, so that the caller can use some names other than
7140 gcpro1, gcpro2, etc.
7141 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7142 of the new macros.
7143 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7144 argument, for consistency with GCPRO2_VAR, etc: it is now the
7145 prefix of the variable, not the variable itself. All uses
7146 changed.
38b2c076
PE
7147 * dired.c (directory_files_internal, file_name_completion):
7148 Rename locals to avoid shadowing.
7149
15206ed9
PE
7150 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7151 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7152 dired.c's scmp function, had undefined behavior.
7153 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7154 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7155 * buffer.h: ... to here, because these macros use current_buffer,
7156 and the new implementation with inline functions needs to have
7157 current_buffer in scope now, rather than later when the macros
7158 are used.
7159 (downcase, upcase1): New static inline functions.
7160 (DOWNCASE, UPCASE1): Reimplement using these functions.
7161 This avoids undefined behavior in expressions like
7162 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7163 from race conditions in accessing the global variables
7164 case_temp1 and case_temp2.
7165 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7166 * lisp.h (case_temp1, case_temp2): Remove their decls.
7167 * character.h (ASCII_CHAR_P): Move from here ...
7168 * lisp.h: ... to here, so that the inline functions mentioned
7169 above can use them.
7170
4a6bea26
PE
7171 * dired.c (directory_files_internal_unwind): Now static.
7172
f14b7e14
PE
7173 * fileio.c (file_name_as_directory, directory_file_name):
7174 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7175 Now static.
2893f146
PE
7176 (file_name_as_directory): Use const pointers when appropriate.
7177 (Fexpand_file_name): Likewise. In particular, newdir might
7178 point at constant storage, so make it a const pointer.
fd4ead52 7179 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
7180 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7181 signedness issues.
f839df0c
PE
7182 (Fset_file_times, Finsert_file_contents, auto_save_error):
7183 Rename locals to avoid shadowing.
f14b7e14 7184
5716756e 7185 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
7186 (Ftry_completion, Fall_completions): Rename or remove locals
7187 to avoid shadowing.
5716756e 7188
b4c3046a
PE
7189 * marker.c (bytepos_to_charpos): Remove; unused.
7190
b45db522
PE
7191 * lisp.h (verify_bytepos, count_markers): New decls,
7192 so that gcc does not warn that these functions aren't declared.
7193
85876d07
PE
7194 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7195 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 7196 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 7197 (copy_text): Remove unused local var.
85876d07 7198
03d78a21 7199 * filelock.c (within_one_second): Now static.
b3dd38ab 7200 (lock_file_1): Rename local to avoid shadowing.
03d78a21 7201
5df8f01b
PE
7202 * buffer.c (fix_overlays_before): Mark locals as initialized.
7203 (fix_start_end_in_overlays): Likewise. This function should be
7204 simplified by using pointers-to-pointers, but that's a different
7205 matter.
b1d876f1 7206 (switch_to_buffer_1): Now static.
8f54f30a
PE
7207 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7208 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 7209
a70072c9 7210 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 7211 Fix pointer signedness issue.
edced198
PE
7212 (sys_subshell): Mark local as volatile if checking for lint,
7213 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 7214 (MAXPATHLEN): Define only if needed.
a70072c9 7215
a0977c44
PE
7216 * process.c (serial_open, serial_configure): Move decls from here ...
7217 * systty.h: ... to here, so that they can be checked.
7218
a884fdcc
PE
7219 * fns.c (get_random, seed_random): Move extern decls from here ...
7220 * lisp.h: ... to here, so that they can be checked.
7221
604efe86 7222 * sysdep.c (reset_io): Now static.
b8950c94 7223 (wait_for_termination_signal): Remove; unused.
604efe86 7224
38fc62d9
PE
7225 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7226 (copy_keymap_item, append_key, push_text_char_description):
7227 Now static.
1004a21a 7228 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 7229 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
7230 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7231 (describe_map_tree):
7232 Rename locals to avoid shadowing.
38fc62d9 7233
2f2650da
PE
7234 * keyboard.c: Declare functions static if they are not used elsewhere.
7235 (echo_char, echo_dash, cmd_error, top_level_2):
7236 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
7237 (read_char, kbd_buffer_get_event, make_lispy_position):
7238 (make_lispy_event, make_lispy_movement, apply_modifiers):
7239 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7240 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7241 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 7242 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 7243 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 7244
a053e86c 7245 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
7246 (mark_kboards): Move decl here ...
7247 * alloc.c (mark_kboards): ... from here.
a053e86c 7248
4752793e
PE
7249 * lisp.h (force_auto_save_soon): New decl.
7250
74f10ca7 7251 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
7252 (DEFINE_DUMMY_FUNCTION): New macro.
7253 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7254 Use it.
c03cd23f
PE
7255 (main): Add casts to avoid warnings
7256 if GCC considers string literals to be constants.
74f10ca7 7257
022e70d4
PE
7258 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7259
59d6fe83
PE
7260 * dbusbind.c: Pointer signedness fixes.
7261 (xd_signature, xd_append_arg, xd_initialize):
7262 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7263 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7264 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7265 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7266
78320123
PE
7267 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7268 if GCC considers string literals to be constants.
49cebcca 7269 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 7270
35ac2a97
SM
72712011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7272
fb103ca9
SM
7273 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7274 (print_preprocess, print_object): New macro to fix last change.
7275
35ac2a97
SM
7276 * print.c (print_preprocess): Don't forget font objects.
7277
62973b41
JB
72782011-03-16 Juanma Barranquero <lekktu@gmail.com>
7279
7280 * emacs.c (USAGE3): Doc fixes.
7281
0e48bb22
AS
72822011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7283
7284 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7285 structure.
7286
7684e57b
JB
72872011-03-14 Juanma Barranquero <lekktu@gmail.com>
7288
7289 * lisp.h (VWindow_system, Qfile_name_history):
7290 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7291 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7292 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7293
7294 * w32select.c: Don't #include "keyboard.h".
c96bbc66 7295 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
7296
7297 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7298 * w32console.c (detect_input_pending, read_input_pending)
7299 (encode_terminal_code):
7300 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7301 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7302 (w32_system_caret_y, Qfile_name_history):
7303 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7304 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7305 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7306 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7307 * w32proc.c (Qlocal, report_file_error):
7308 * w32term.c (Vwindow_system, updating_frame):
7309 * w32uniscribe.c (initialized, uniscribe_font_driver):
7310 Remove unneeded extern declarations.
7311
2aa46d6c
CY
73122011-03-14 Chong Yidong <cyd@stupidchicken.com>
7313
c96bbc66 7314 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 7315
cffc6f3b
CY
73162011-03-13 Chong Yidong <cyd@stupidchicken.com>
7317
7318 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7319 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7320 These macros can no longer be used for assignment.
7321
44f230aa
SM
7322 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7323 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
7324 (record_buffer_markers, fetch_buffer_markers): New functions for
7325 recording and fetching special buffer markers.
7326 (set_buffer_internal_1, set_buffer_temp): Use them.
7327
7328 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7329
7330 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7331
7332 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7333 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7334
7335 * xdisp.c (hscroll_window_tree):
7336 (reconsider_clip_changes): Use PT instead of BUF_PT.
7337
d251f04b
EZ
73382011-03-13 Eli Zaretskii <eliz@gnu.org>
7339
7340 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7341 $(EMACS_ROOT)/lib/intprops.h.
7342
f0c77cd1
PE
73432011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7344
3eca4629
PE
7345 Fix more problems found by GCC 4.5.2's static checks.
7346
7c86ee98
PE
7347 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7348 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
7349 (xg_free_frame_widgets): Make it clear that a local variable is
7350 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
7351 (gdk_window_get_screen): Make it clear that this macro is needed
7352 only if USE_GTK_TOOLTIP.
1e5524e7
PE
7353 (int_gtk_range_get_value): New function, which avoids a diagnostic
7354 from gcc -Wbad-function-cast.
7355 (xg_set_toolkit_scroll_bar_thumb): Use it.
7356 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7357 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
7358 (get_utf8_string, xg_get_file_with_chooser):
7359 Rename locals to avoid shadowing.
7360 (create_dialog): Move locals to avoid shadowing.
7c86ee98 7361
41729b81
PE
7362 * xgselect.c (xg_select): Remove unused var.
7363
f0c77cd1
PE
7364 * image.c (four_corners_best): Mark locals as initialized.
7365 (gif_load): Initialize transparent_p to zero (Bug#8238).
7366 Mark another local as initialized.
ec6cf4c6 7367 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 7368
ce0ad53d 7369 * image.c (clear_image_cache): Now static.
d5d5a617 7370 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 7371 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
7372 (x_edge_detection): Remove unnecessary cast that
7373 gcc -Wbad-function-cast diagnoses.
2037898d 7374 (gif_load): Fix pointer signedness.
6ae141d6
PE
7375 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7376 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 7377
33383987 73782011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 7379
d32df629
PE
7380 Improve quality of tests for time stamp overflow.
7381 For example, without this patch (encode-time 0 0 0 1 1
7382 1152921504606846976) returns the obviously-bogus value (-948597
7383 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7384 reports time overflow. See
7385 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
7386 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7387 * editfns.c: Include limits.h and intprops.h.
7388 (TIME_T_MIN, TIME_T_MAX): New macros.
7389 (time_overflow): Move earlier, to before first use.
7390 (hi_time, lo_time): New functions, for an accurate test for
7391 out-of-range times.
7392 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7393 (Fget_internal_run_time): Don't assume time_t fits in int.
7394 (make_time): Use list2 instead of Fcons twice.
7395 (Fdecode_time): More accurate test for out-of-range times.
7396 (check_tm_member): New function.
7397 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
7398 (lisp_time_argument): Don't rely on undefined left-shift and
7399 right-shift behavior when checking for time stamp overflow.
8be6f318 7400
fe31d94c
PE
7401 * editfns.c (time_overflow): New function, refactoring common code.
7402 (Fformat_time_string, Fdecode_time, Fencode_time):
7403 (Fcurrent_time_string): Use it.
7404
8be6f318
PE
7405 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7406 * dired.c (make_time): Move to ...
7407 * editfns.c (make_time): ... here.
7408 * systime.h: Note the move.
7409
09d9db2c 74102011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 7411
126bc0dc
YM
7412 * fringe.c (update_window_fringes): Remove unused variables.
7413
c47cbdfd
YM
7414 * unexmacosx.c (copy_data_segment): Also copy __got section.
7415 (Bug#8223)
7416
7ac80be9
EZ
74172011-03-12 Eli Zaretskii <eliz@gnu.org>
7418
c96bbc66 7419 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
7420 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7421 Constify `char *' arguments and their references according to
7422 prototypes in tparam.h.
7423
ecb0f94d 7424 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 7425
7ac80be9
EZ
7426 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7427 Adapt all references accordingly.
7428
7429 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7430
ef1fd07e
TT
74312011-03-11 Tom Tromey <tromey@redhat.com>
7432
7433 * buffer.c (syms_of_buffer): Remove obsolete comment.
7434
7ef4b50c
EZ
74352011-03-11 Eli Zaretskii <eliz@gnu.org>
7436
7437 * termhooks.h (encode_terminal_code): Declare prototype.
7438
7439 * msdos.c (encode_terminal_code): Don't declare prototype.
7440
7441 * term.c (encode_terminal_code): Now external again, used by
7442 w32console.c and msdos.c.
7443
44f230aa
SM
7444 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7445 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 7446
4b1ec863 74472011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 7448
1714f52b 7449 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 7450
4b1ec863
PE
7451 * fringe.c (update_window_fringes): Mark locals as initialized
7452 (Bug#8227).
7453 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 7454
524c7aa6
PE
7455 * alloc.c (mark_fringe_data): Move decl from here ...
7456 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7457 to check its interface.
7458 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7459
a5c0af81 7460 * fontset.c (free_realized_fontset): Now static.
7519b8cd 7461 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 7462 (fontset_font): Mark local as initialized.
a9a06e0b 7463 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 7464
b4716021
PE
7465 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7466
811e9bac 7467 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 7468 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
7469 (x_own_selection, Fx_disown_selection_internal): Rename locals
7470 to avoid shadowing.
7471 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 7472
7e3ab302
PE
7473 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7474 so that the caller can use some name other than gcpro1.
7475 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
7476 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7477 (Fx_backspace_delete_keys_p):
7478 Use them to avoid shadowing, and rename vars to avoid shadowing.
7479 (x_decode_color, x_set_name, x_window): Now static.
6b437900 7480 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 7481 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
7482 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7483 Remove unused locals.
7e3ab302
PE
7484 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7485 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7486 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7487 macros.
f78faa98 7488
e2b13473
PE
7489 * xterm.h (x_mouse_leave): New decl.
7490
77f23912
PE
7491 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7492 Remove unused functions.
cdf4ba58
PE
7493 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7494 (x_calc_absolute_position): Now static.
7411c686 7495 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 7496 Don't declare local "event" unless it's used.
ed7bf3a5
PE
7497 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7498 unless they are used.
38d0b34a
PE
7499 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7500 (x_fatal_error_signal): Remove; not used.
a6067996
PE
7501 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7502 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7503 (x_error_catcher, x_connection_closed, x_error_handler):
7504 (x_error_quitter, xembed_send_message, x_iconify_frame):
7505 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 7506 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 7507 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 7508
44f230aa
SM
7509 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7510 Rename or move locals to avoid shadowing.
6b463e58 7511 (tty_defined_color, merge_face_heights): Now static.
5967d051 7512 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
7513 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7514 does not deduce is never used uninitialized.
73719eba
PE
7515 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7516 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 7517
426994c3 7518 * terminal.c (store_terminal_param): Now static.
5489860b 7519
032f1620 7520 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 7521 (set_frame_menubar): Remove unused local.
d4323972 7522 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
7523 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7524 since they might point to immutable storage.
281585b0
PE
7525 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7526 since it's unused otherwise.
032f1620 7527
367c19e5 7528 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 7529 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
7530 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7531 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 7532 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
7533 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7534 does not deduce are never used uninitialized.
70739cbe 7535
07b48fa9
PE
7536 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7537
8868a238 7538 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
7539 * window.c (window_loop, size_window):
7540 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 7541
7e5cf297 7542 * window.c (display_buffer): Now static.
d6550a9f
PE
7543 (size_window): Mark variables that gcc -Wuninitialized
7544 does not deduce are never used uninitialized.
a586633d
PE
7545 * window.h (check_all_windows): New decl, to forestall
7546 gcc -Wmissing-prototypes diagnostic.
5b555da1 7547 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 7548
f6095868
PE
7549 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7550 shadowing.
7551 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
7552 Include <limits.h>.
7553 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7554 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
7555 (load_charset_map): Mark variables that gcc -Wuninitialized
7556 does not deduce are never used uninitialized.
53df7c11 7557 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 7558
f38b440c
PE
7559 * coding.c (coding_set_source, coding_set_destination):
7560 Use "else { /* comment */ }" rather than "else /* comment */;"
7561 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
7562 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7563 a block, when the outer 'i' will do.
7564 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7565 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7566 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7567 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7568 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7569 Rename locals to avoid shadowing.
7570 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
7571 * coding.c (emacs_mule_char, encode_invocation_designation):
7572 Now static, since they're not used elsewhere.
413bb2db 7573 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 7574 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
7575 (decode_coding_emacs_mule): Mark variables that gcc
7576 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
7577 (detect_coding_iso_2022): Initialize a local variable that might
7578 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 7579 this initialization is needed. (Bug#8211)
5f58e762
PE
7580 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7581 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7582 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7583 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7584 Remove unused macros.
f38b440c 7585
232b38b9 7586 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 7587 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 7588 * character.c (string_count_byte8): Likewise.
232b38b9 7589
fb90da1b
PE
7590 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7591 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7592
fb93dbc2
PE
7593 * chartab.c (copy_sub_char_table): Now static, since it's not used
7594 elsewhere.
5c156ace
PE
7595 (sub_char_table_ref_and_range, char_table_ref_and_range):
7596 Rename locals to avoid shadowing.
bbcd0949 7597 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 7598
7d3b3862 7599 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 7600 (BIDI_BOB): Remove unused macro.
7d3b3862 7601
6be7d3da
PE
7602 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7603 deduce are never used uninitialized.
c2ed9c8b 7604 * term.c (encode_terminal_code): Likewise.
6be7d3da 7605
75f8807f 7606 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 7607
50938595
PE
7608 * tparam.h: New file.
7609 * term.c, tparam.h: Include it.
7610 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7611 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7612 Move these decls to tparam.h, and make them agree with what
7613 is actually in tparam.c. The previous trick of using incompatible
7614 decls in different modules does not conform to the C standard.
7615 All callers of tparam changed to use tparam's actual API.
7616 * tparam.c (tparam1, tparam, tgoto):
7617 Use const pointers where appropriate.
7618
fbceeba2
PE
7619 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7620 * cm.h (struct cm): Likewise.
7621 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7622 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7623 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7624 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7625 (turn_on_face, init_tty): Likewise.
7626 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 7627
7f3f1250
PE
7628 * term.c (term_mouse_position): Rename local to avoid shadowing.
7629
e6ca6543
PE
7630 * alloc.c (mark_ttys): Move decl from here ...
7631 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7632
c40f8d15
AS
76332011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7634
7635 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7636
cfe0661d
JB
76372011-03-09 Juanma Barranquero <lekktu@gmail.com>
7638
7639 * search.c (compile_pattern_1): Remove argument regp, unused since
7640 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7641 (compile_pattern): Don't pass it.
7642
0afb4571
J
76432011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7644
7645 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7646 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7647 for ! HAVE_GTK3.
7648 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7649
7650 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7651
7652 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7653 gdk_window_get_screen, gdk_window_get_geometry,
7654 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7655 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7656 (xg_get_pixbuf_from_pixmap): New function.
7657 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7658 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7659 Call xg_get_pixbuf_from_pixmap instead of
7660 gdk_pixbuf_get_from_drawable.
7661 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7662 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7663 (xg_check_special_colors): Use GtkStyleContext and its functions
7664 for HAVE_GTK3.
7665 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7666 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7667 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
7668 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7669 Call gtk_widget_get_preferred_size.
0afb4571
J
7670 (xg_frame_resized): gdk_window_get_geometry only takes 5
7671 parameters.
44f230aa
SM
7672 (xg_win_to_widget, xg_event_is_for_menubar):
7673 Call gdk_x11_window_lookup_for_display.
0afb4571
J
7674 (xg_set_widget_bg): New function.
7675 (delete_cb): New function.
895009e1 7676 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
7677 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7678 (xg_set_background_color): Call xg_set_widget_bg.
7679 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7680 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7681 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7682 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7683 if ! HAVE_GTK3.
7684 (update_frame_tool_bar): Call gtk_widget_hide.
7685 (xg_initialize): Use GDK_KEY_g.
7686
7687 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7688 if ! HAVE_GTK3
7689 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7690
7691 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7692 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7693 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7694
1c2cc4ef
JB
76952011-03-08 Juanma Barranquero <lekktu@gmail.com>
7696
7697 * w32xfns.c (select_palette): Check success of RealizePalette against
7698 GDI_ERROR, not zero.
7699
33383987 7700See ChangeLog.11 for earlier changes.
aac0c6e3
MR
7701
7702;; Local Variables:
7703;; coding: utf-8
aac0c6e3
MR
7704;; End:
7705
33383987 7706 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
7707
7708 This file is part of GNU Emacs.
7709
7710 GNU Emacs is free software: you can redistribute it and/or modify
7711 it under the terms of the GNU General Public License as published by
7712 the Free Software Foundation, either version 3 of the License, or
7713 (at your option) any later version.
7714
7715 GNU Emacs is distributed in the hope that it will be useful,
7716 but WITHOUT ANY WARRANTY; without even the implied warranty of
7717 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7718 GNU General Public License for more details.
7719
7720 You should have received a copy of the GNU General Public License
7721 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.