* bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
d96be9fc
PE
12011-06-14 Paul Eggert <eggert@cs.ucla.edu>
2
80e88859
PE
3 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4
4a2f0ad6
PE
5 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
6
f66c7cf8
PE
7 Variadic C functions now count arguments with ptrdiff_t.
8 This partly undoes my 2011-03-30 change, which replaced int with size_t.
9 Back then I didn't know that the Emacs coding style prefers signed int.
10 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
11 were being counted with int, which may truncate counts on 64-bit
12 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
13 * lisp.h (struct Lisp_Subr.function.aMANY)
14 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
15 Arg counts are now ptrdiff_t, not size_t.
16 All variadic functions and their callers changed accordingly.
17 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
18 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
19 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
20 * callint.c (Fcall_interactively): Check arg count for overflow,
21 to avoid potential buffer overrun. Use signed char, not 'int',
22 for 'varies' array, so that we needn't bother to check its size
23 calculation for overflow.
24 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
25 * eval.c (apply_lambda):
26 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
27 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
28 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
29
a1759b76
PE
30 * callint.c (Fcall_interactively): Don't use index var as event count.
31
d96be9fc
PE
32 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
33 * mem-limits.h (SIZE): Remove; no longer used.
34
13bdea59
PE
352011-06-13 Paul Eggert <eggert@cs.ucla.edu>
36
a690a978 37 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 38
578c21e6
PE
39 Remove unnecessary casts.
40 * xterm.c (x_term_init):
41 * xfns.c (x_set_border_pixel):
42 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
43 These aren't needed now that we assume ANSI C.
44
96f53c6c
PE
45 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
46 It's more likely to cause problems (due to unsigned overflow)
47 than to cure them.
48
83c77d31
PE
49 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
50
ee2079f1
PE
51 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
52
6da65536
PE
53 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
54
7147c4a4
PE
55 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
56
193e32d9
PE
57 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
58
e5533da6
PE
59 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
60
9910e595
PE
61 GLYPH_CODE_FACE returns EMACS_INT, not int.
62 * dispextern.h (merge_faces):
63 * xfaces.c (merge_faces):
01103c44
PE
64 * xdisp.c (get_next_display_element, next_element_from_display_vector):
65 Don't assume EMACS_INT fits in int.
9910e595 66
2638320e
PE
67 * character.h (CHAR_VALID_P): Remove unused parameter.
68 * fontset.c, lisp.h, xdisp.c: All uses changed.
69
045eb8d9
PE
70 * editfns.c (Ftranslate_region_internal): Omit redundant test.
71
c1f134b5
PE
72 * fns.c (concat): Minor tuning based on overflow analysis.
73 This doesn't fix any bugs. Use int to hold character, instead
74 of constantly refetching from Emacs object. Use XFASTINT, not
75 XINT, for value known to be a character. Don't bother comparing
76 a single byte to 0400, as it's always less.
77
395fcb93 78 * floatfns.c (Fexpt):
327eeec8
PE
79 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
80
abbd3d23
PE
81 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
82 for characters.
83
684a03ef
PE
84 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
85
0fed43f3
PE
86 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
87 Without this fix, on a 64-bit host (aset S 0 4294967386) would
88 incorrectly succeed when S was a string, because 4294967386 was
89 truncated before it was used.
90
8fd02eb7
PE
91 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
92 Otherwise, an out-of-range integer could cause undefined behavior
93 on a 64-bit host.
94
f8c86b69
PE
95 * composite.c: Use int, not EMACS_INT, for characters.
96 (fill_gstring_body, composition_compute_stop_pos): Use int, not
97 EMACS_INT, for values that are known to be in character range.
98 This doesn't fix any bugs but is the usual style inside Emacs and
99 may generate better code on 32-bit machines.
100
34206dd2
PE
101 Make sure a 64-bit char is never passed to ENCODE_CHAR.
102 This is for reasons similar to the recent CHAR_STRING fix.
103 * charset.c (Fencode_char): Check that character arg is actually
104 a character. Pass an int to ENCODE_CHAR.
105 * charset.h (ENCODE_CHAR): Verify that the character argument is no
106 wider than 'int', as a compile-time check to prevent future regressions
107 in this area.
108
c5958d4c 109 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
110
111 Make sure a 64-bit char is never passed to CHAR_STRING.
112 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
113 by silently ignoring the top 32 bits, allowing some values
114 that were far too large to be valid characters.
115 * character.h: Include <verify.h>.
116 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
117 arguments are no wider than unsigned, as a compile-time check
118 to prevent future regressions in this area.
119 * data.c (Faset):
01103c44 120 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
121 (Fsubst_char_in_region):
122 * fns.c (concat):
123 * xdisp.c (decode_mode_spec_coding):
124 Adjust to CHAR_STRING's new requirement.
125 * editfns.c (Finsert_char, Fsubst_char_in_region):
126 * fns.c (concat): Check that character args are actually
127 characters. Without this test, these functions did the wrong
128 thing with wildly out-of-range values on 64-bit hosts.
129
d37ca623
PE
130 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
131 These casts should not be needed on 32-bit hosts, either.
132 * keyboard.c (read_char):
133 * lread.c (Fload): Remove casts to unsigned.
134
ea204efb
PE
135 * lisp.h (UNSIGNED_CMP): New macro.
136 This fixes comparison bugs on 64-bit hosts.
137 (ASCII_CHAR_P): Use it.
138 * casefiddle.c (casify_object):
01103c44 139 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
140 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
141 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
142 * dispextern.h (FACE_FROM_ID):
143 * keyboard.c (read_char): Use UNSIGNED_CMP.
144
41cb286c
PE
145 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
146 not to EMACS_INT, to avoid GCC warning.
147
4a1b9832
PE
148 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
149
55daad71
PE
150 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
151 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
152 isn't needed on 32-bit machines.
8f95c75c 153
01103c44
PE
154 * buffer.c (Fgenerate_new_buffer_name):
155 Use EMACS_INT for count, not int.
0ceccced 156 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
157
158 * data.c (Qcompiled_function): Now static.
159
c6f072e7
PE
160 * window.c (window_body_lines): Now static.
161
20ce5912
PE
162 * image.c (gif_load): Rename local to avoid shadowing.
163
9c4c5f81
PE
164 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
165 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
166 * alloc.c (make_save_value): Integer argument is now of type
167 ptrdiff_t, not int.
168 (mark_object): Use ptrdiff_t, not int.
169 * lisp.h (pD): New macro.
170 * print.c (print_object): Use it.
171
c0c5c8ae
PE
172 * alloc.c: Use EMACS_INT, not int, to count objects.
173 (total_conses, total_markers, total_symbols, total_vector_size)
174 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
175 (total_free_floats, total_floats, total_free_intervals)
176 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
177 Now EMACS_INT, not int. All uses changed.
178 (Fgarbage_collect): Compute overall total using a double, so that
179 integer overflow is less likely to be a problem. Check for overflow
180 when converting back to an integer.
5a25e253
PE
181 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
182 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
183 These were 'int' variables that could overflow on 64-bit hosts;
184 they were never used, so remove them instead of repairing them.
211a0b2a 185 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
186 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
187 Previously, this ceilinged at INT_MAX, but that doesn't work on
188 64-bit machines.
e46bb31a 189 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 190
c78baabf 191 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 192 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
193 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
194 when a (possibly-narrower) signed value would do just as well.
195 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 196
c9d624c6
PE
197 * alloc.c: Catch some string size overflows that we were missing.
198 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
199 for convenience in STRING_BYTES_MAX.
200 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
201 The definition here is exact; the one in lisp.h was approximate.
202 (allocate_string_data): Check for string overflow. This catches
203 some instances we weren't catching before. Also, it catches
204 size_t overflow on (unusual) hosts where SIZE_MAX <= min
205 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
206 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 207
c9d624c6
PE
208 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
209 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
210 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
211
353032ce
PE
212 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
213
2bccce07
PE
214 * alloc.c (Fmake_string): Check for out-of-range init.
215
e10ac9f1
MR
2162011-06-12 Martin Rudalics <rudalics@gmx.at>
217
218 * frame.c (make_frame): Call other_buffer_safely instead of
219 other_buffer.
220
221 * window.c (temp_output_buffer_show): Call display_buffer with
222 second argument Vtemp_buffer_show_specifiers and reset latter
223 immediately after the call.
224 (Vtemp_buffer_show_specifiers): New variable.
225 (auto_window_vscroll_p, next_screen_context_lines)
226 (Vscroll_preserve_screen_position): Remove leading asterisks from
227 doc-strings.
228
2d3c217e 2292011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 230
7b7f97e8 231 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
232 * buffer.c (Qclone_number): Remove for now, as it's unused.
233 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
234 (record_buffer): Remove unused local.
235 * frame.c (other_visible_frames, frame_buffer_list): Now static.
236 (set_frame_buffer_list): Remove; unused.
237 * frame.h (other_visible_frames): Remove decl.
238 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
239 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
240 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
241 if HAVE_GPM.
242 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
243 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
244 Define only if HAVE_GPM.
245 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
246 (update_hints_inhibit): Remove; never set. All uses removed.
247 * widgetprv.h (emacsFrameClassRec): Remove decl.
248 * window.c (delete_deletable_window): Now returns void, since it
249 wasn't returning anything.
250 (compare_window_configurations): Remove unused locals.
251 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
252 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
253 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
254 the same widths as pointers. This follows up on the 2011-05-06 patch.
255 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
256 * xterm.h: Likewise.
257 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
258
1384b89e
JB
2592011-06-12 Juanma Barranquero <lekktu@gmail.com>
260
261 * makefile.w32-in: Update dependencies.
262 (LISP_H): Add lib/intprops.h.
263
1100a63c
CY
2642011-06-11 Chong Yidong <cyd@stupidchicken.com>
265
266 * image.c (gif_load): Add animation frame delay to the metadata.
267 (syms_of_image): Use DEFSYM. New symbol `delay'.
268
6198ccd0
MR
2692011-06-11 Martin Rudalics <rudalics@gmx.at>
270
271 * window.c (delete_deletable_window): Re-add.
272 (Fset_window_configuration): Rewrite to handle dead buffers and
273 consequently deletable windows.
274 (window_tree, Fwindow_tree): Remove. Supply functionality in
275 window.el.
276 (compare_window_configurations): Simplify code.
277
b6e3633c
AS
2782011-06-11 Andreas Schwab <schwab@linux-m68k.org>
279
1ab0dee5
AS
280 * image.c (imagemagick_load_image): Fix type mismatch.
281 (Fimagemagick_types): Likewise.
282
b6e3633c
AS
283 * window.h (replace_buffer_in_windows): Declare.
284
9397e56f
MR
2852011-06-11 Martin Rudalics <rudalics@gmx.at>
286
287 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
288 Qclone_number. Remove external declaration of Qdelete_window.
289 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
290 code.
291 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
292 Qbuffer_list_update_hook if allowed.
293 (Fother_buffer): Rewrite doc-string. Major rewrite for new
294 buffer list implementation.
295 (other_buffer_safely): New function.
296 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
297 calls to replace_buffer_in_windows and
298 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
299 if allowed.
300 (record_buffer): Inhibit quitting and rewrite using quittable
301 functions. Run Qbuffer_list_update_hook if allowed.
302 (Frecord_buffer, Funrecord_buffer): New functions.
303 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
304 switch-to-buffer to window.el.
305 (bury-buffer): Move to window.el.
306 (Vbuffer_list_update_hook): New variable.
307
308 * lisp.h (other_buffer_safely): Add prototype in buffer.c
309 section.
310
311 * window.h (resize_frame_windows): Move up in code.
312 (Fwindow_frame): Remove EXFUN.
313 (replace_buffer_in_all_windows): Remove prototype.
314 (replace_buffer_in_windows_safely): Add prototype.
315
316 * window.c: Declare Qdelete_window static again. Move down
317 declaration of select_count.
318 (Fnext_window, Fprevious_window): Rewrite doc-strings.
319 (Fother_window): Move to window.el.
320 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
321 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
322 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
323 window.el.
324 (replace_buffer_in_windows): Implement by calling
325 Qreplace_buffer_in_windows.
326 (replace_buffer_in_all_windows): Remove with some functionality
327 moved into replace_buffer_in_windows_safely.
328 (replace_buffer_in_windows_safely): New function.
329 (select_window_norecord, select_frame_norecord): Move in front
330 of run_window_configuration_change_hook. Remove now obsolete
331 declarations.
332 (Fset_window_buffer): Rewrite doc-string. Call
333 Qrecord_window_buffer.
334 (keys_of_window): Move binding for other-window to window.el.
335
b50691aa
CY
3362011-06-11 Chong Yidong <cyd@stupidchicken.com>
337
338 * dispextern.h (struct image): Replace data member, whose int_val
339 and ptr_val fields were not used by anything, with a single
340 lisp_val object.
341
342 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
343 (gif_clear_image, gif_load, imagemagick_load_image)
344 (gs_clear_image, gs_load): Callers changed.
345
3f754b86
PE
3462011-06-10 Paul Eggert <eggert@cs.ucla.edu>
347
cca69397
PE
348 * buffer.h: Include <time.h>, for time_t.
349 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
350
109e28d0
PE
351 Fix minor problems found by static checking.
352
60737f02
PE
353 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
354
4b66faf3
PE
355 Make identifiers static if they are not used in other modules.
356 * data.c (Qcompiled_function, Qframe, Qvector):
357 * image.c (QimageMagick, Qsvg):
358 * minibuf.c (Qmetadata):
359 * window.c (resize_window_check, resize_root_window): Now static.
360 * window.h (resize_window_check, resize_root_window): Remove decls.
361
109e28d0
PE
362 * window.c (window_deletion_count, delete_deletable_window):
363 Remove; unused.
46a4ce9e
PE
364 (window_body_lines): Now static.
365 (Fdelete_other_windows_internal): Mark vars as initialized.
366 Make sure 'resize_failed' is initialized.
367 (run_window_configuration_change_hook): Rename local to avoid shadowing.
368 (resize_window_apply): Remove unused local.
369 * window.h (delete_deletable_window): Remove decl.
370
109e28d0 371 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
372 (imagemagick_load_image): Fix pointer signedness problem by changing
373 last arg from unsigned char * to char *. All uses changed.
374 Also, fix a local for similar reasons.
375 Remove unused locals. Remove locals to avoid shadowing.
376 (fn_rsvg_handle_free): Remove; unused.
377 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 378 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 379
3f754b86
PE
380 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
381
2547adb1
CY
3822011-06-10 Chong Yidong <cyd@stupidchicken.com>
383
384 * image.c (gif_load): Fix omitted cast error introduced by
385 2011-06-06 change.
386
2c8e37d4
MR
3872011-06-10 Martin Rudalics <rudalics@gmx.at>
388
389 * window.h (resize_proportionally, orig_total_lines)
390 (orig_top_line): Remove from window structure.
391 (set_window_height, set_window_width, change_window_heights)
392 (Fdelete_window): Remove prototypes.
393 (resize_frame_windows): Remove duplicate declaration.
394
440a42e3
EZ
3952011-06-10 Eli Zaretskii <eliz@gnu.org>
396
397 * window.h (resize_frame_windows, resize_window_check)
398 (delete_deletable_window, resize_root_window)
399 (resize_frame_windows): Declare prototypes.
400
401 * window.c (resize_window_apply): Make definition be "static" to
402 match the prototype.
403
562dd5e9
MR
4042011-06-10 Martin Rudalics <rudalics@gmx.at>
405
406 * window.c: Remove declarations of Qwindow_size_fixed,
407 window_min_size_1, window_min_size_2, window_min_size,
408 size_window, window_fixed_size_p, enlarge_window, delete_window.
409 Remove static from declaration of Qdelete_window, it's
410 temporarily needed by Fbury_buffer.
411 (replace_window): Don't assign orig_top_line and
412 orig_total_lines.
413 (Fdelete_window, delete_window): Remove. Window deletion is
414 handled by window.el.
415 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
416 Fdelete_window calls with calls to Qdelete_window.
417 (Fdelete_other_windows): Remove. Deleting other windows is
418 handled by window.el.
419 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
420 handled in window.el.
421 (window_min_size_2, window_min_size_1, window_min_size): Remove.
422 Window minimum sizes are handled in window.el.
423 (shrink_windows, size_window, set_window_height)
424 (set_window_width, change_window_heights, window_height)
425 (window_width, CURBEG, CURSIZE, enlarge_window)
426 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
427 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
428 handled in window.el.
429 (make_dummy_parent): Rename to make_parent_window and give it a
430 second argument horflag.
431 (make_window): Don't set resize_proportionally any more.
432 (Fsplit_window): Remove. Windows are split in window.el.
433 (save_restore_action, save_restore_orig_size)
434 (shrink_window_lowest_first, save_restore_orig_size): Remove.
435 Resize mini windows in window.el.
436 (grow_mini_window, shrink_mini_window): Implement by calling
437 Qresize_root_window_vertically, resize_window_check and
438 resize_window_apply.
439 (saved_window, Fset_window_configuration, save_window_save): Do
440 not handle orig_top_line, orig_total_lines, and
441 resize_proportionally.
442 (window_min_height, window_min_width): Move to window.el.
443 (keys_of_window): Move bindings for delete-other-windows,
444 split-window, delete-window and enlarge-window to window.el.
445
446 * buffer.c: Temporarily extern Qdelete_window.
447 (Fbury_buffer): Temporarily call Qdelete_window instead of
448 Fdelete_window (Fbury_buffer will move to window.el soon).
449
450 * frame.c (set_menu_bar_lines_1): Remove code handling
451 orig_top_line and orig_total_lines.
452
453 * dispnew.c (adjust_frame_glyphs_initially): Don't use
454 set_window_height but set heights directly.
455 (change_frame_size_1): Use resize_frame_windows.
456
457 * xdisp.c (init_xdisp): Don't use set_window_height but set
458 heights directly.
459
460 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
461 resize_frame_windows instead of change_window_heights and run
462 run_window_configuration_change_hook.
463
464 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
465 instead of change_window_heights and run
466 run_window_configuration_change_hook.
467
1a13852e
MR
4682011-06-09 Martin Rudalics <rudalics@gmx.at>
469
470 * window.c (replace_window): Rename second argument REPLACEMENT to
471 NEW. New third argument SETFLAG. Rewrite.
472 (delete_window, make_dummy_parent): Call replace_window with
473 third argument 1.
474 (window_list_1): Move down in code.
475 (run_window_configuration_change_hook): Move set_buffer part
476 before select_frame_norecord part in order to unwind correctly.
477 Rename count1 to count.
478 (recombine_windows, delete_deletable_window, resize_root_window)
479 (Fdelete_other_windows_internal)
480 (Frun_window_configuration_change_hook, make_parent_window)
481 (resize_window_check, resize_window_apply, Fresize_window_apply)
482 (resize_frame_windows, Fsplit_window_internal)
483 (Fdelete_window_internal, Fresize_mini_window_internal): New
484 functions.
485 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
486
f3d1777e
MR
4872011-06-08 Martin Rudalics <rudalics@gmx.at>
488
496e208e
MR
489 * window.h (window): Add some new members to window structure -
490 normal_lines, normal_cols, new_total, new_normal, clone_number,
491 splits, nest, prev_buffers, next_buffers.
492 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 493 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 494
f3d1777e
MR
495 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
496 Remove.
496e208e
MR
497 (make_dummy_parent): Set new members of windows structure.
498 (make_window): Move down in code. Handle new members of window
499 structure.
500 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
501 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
502 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
503 (Fset_window_prev_buffers, Fwindow_next_buffers)
504 (Fset_window_next_buffers, Fset_window_clone_number): New
505 functions.
506 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
507 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
508 Doc-string fixes.
509 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
510 Argument WINDOW can be now internal window too.
511 (Fwindow_use_time): Move up in code.
512 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
513 Rewrite doc-string.
514 (Fset_window_configuration, saved_window)
515 (Fcurrent_window_configuration, save_window_save): Handle new
516 members of window structure.
b9e809c2
MR
517 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
518 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
519 (syms_of_window): New Lisp objects Qrecord_window_buffer,
520 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
521 Qget_mru_window, Qresize_root_window,
522 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
523 Qauto_buffer_name; staticpro them.
f3d1777e 524
abde8f8c
MR
5252011-06-07 Martin Rudalics <rudalics@gmx.at>
526
527 * window.c (Fwindow_total_size, Fwindow_left_column)
528 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
529 (Fwindow_list_1): New functions.
530 (window_box_text_cols): Replace with window_body_cols.
531 (Fwindow_width, Fscroll_left, Fscroll_right): Use
532 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
533 (delete_window, Fset_window_configuration): Call
534 delete_all_subwindows with window as argument.
535 (delete_all_subwindows): Take a window as argument and not a
536 structure. Rewrite.
190b47e6
MR
537 (window_loop): Remove handling of GET_LRU_WINDOW and
538 GET_LARGEST_WINDOW.
539 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
540
541 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
542 window_box_text_cols. delete_all_subwindows now takes a
543 Lisp_Object as argument.
abde8f8c
MR
544
545 * indent.c (compute_motion, Fcompute_motion): Use
546 window_body_cols instead of window_box_text_cols.
547
fa8a67e6
MR
548 * frame.c (delete_frame): Call delete_all_subwindows with root
549 window as argument.
550
a54e3482
DC
5512011-06-07 Daniel Colascione <dan.colascione@gmail.com>
552
553 * fns.c (Fputhash): Document return value.
554
60002bf5
CY
5552011-06-06 Chong Yidong <cyd@stupidchicken.com>
556
557 * image.c (gif_load): Implement gif89a spec "no disposal" method.
558
0c671da6 5592011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 560
b862a52a 561 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 562
be44ca6c
PE
563 Check for overflow when converting integer to cons and back.
564 * charset.c (Fdefine_charset_internal, Fdecode_char):
565 Use cons_to_unsigned to catch overflow.
566 (Fencode_char): Use INTEGER_TO_CONS.
567 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
568 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
569 * data.c (long_to_cons, cons_to_long): Remove.
570 (cons_to_unsigned, cons_to_signed): New functions.
571 These signal an error for invalid or out-of-range values.
572 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
573 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
574 * font.c (Ffont_variation_glyphs):
575 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
576 * lisp.h: Include <intprops.h>.
577 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
578 (cons_to_signed, cons_to_unsigned): New decls.
579 (long_to_cons, cons_to_long): Remove decls.
580 * undo.c (record_first_change): Use INTEGER_TO_CONS.
581 (Fprimitive_undo): Use CONS_TO_INTEGER.
582 * xfns.c (Fx_window_property): Likewise.
583 * xselect.c: Include <limits.h>.
584 (x_own_selection, selection_data_to_lisp_data):
585 Use INTEGER_TO_CONS.
586 (x_handle_selection_request, x_handle_selection_clear)
587 (x_get_foreign_selection, Fx_disown_selection_internal)
588 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
589 (lisp_data_to_selection_data): Use cons_to_unsigned.
590 (x_fill_property_data): Use cons_to_signed.
591 Report values out of range.
592
d1f3d2af
PE
593 Check for buffer and string overflow more precisely.
594 * buffer.h (BUF_BYTES_MAX): New macro.
595 * lisp.h (STRING_BYTES_MAX): New macro.
596 * alloc.c (Fmake_string):
597 * character.c (string_escape_byte8):
598 * coding.c (coding_alloc_by_realloc):
599 * doprnt.c (doprnt):
600 * editfns.c (Fformat):
601 * eval.c (verror):
602 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
603 since they may not be the same number.
604 * editfns.c (Finsert_char):
605 * fileio.c (Finsert_file_contents):
606 Likewise for BUF_BYTES_MAX.
607
dd52fcea
PE
608 * image.c: Use ptrdiff_t, not int, for sizes.
609 (slurp_file): Switch from int to ptrdiff_t.
610 All uses changed.
611 (slurp_file): Check that file size fits in both size_t (for
612 malloc) and ptrdiff_t (for sanity and safety).
613
7f9bbdbb
PE
614 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
615 if b->modtime has its maximal value.
616
dfe18f82
PE
617 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
618
84acfcf0
PE
619 Don't assume time_t can fit into int.
620 * buffer.h (struct buffer.modtime): Now time_t, not int.
621 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
622 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
623
ccd9a01a
PE
624 Minor fixes for signed vs unsigned integers.
625 * character.h (MAYBE_UNIFY_CHAR):
626 * charset.c (maybe_unify_char):
627 * keyboard.c (read_char, reorder_modifiers):
628 XINT -> XFASTINT, since the integer must be nonnegative.
629 * ftfont.c (ftfont_spec_pattern):
630 * keymap.c (access_keymap, silly_event_symbol_error):
631 XUINT -> XFASTINT, since the integer must be nonnegative.
632 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
633 since it makes no difference and we prefer signed.
634 * keyboard.c (record_char): Use XUINT when all the neighbors do.
635 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
636 nonnegative.
637
d6d100dd
SM
6382011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
639
640 * window.h (Fwindow_frame): Declare.
641
2b6148e4
PE
6422011-06-06 Paul Eggert <eggert@cs.ucla.edu>
643
644 * alloc.c: Simplify handling of large-request failures (Bug#8800).
645 (SPARE_MEMORY): Always define.
646 (LARGE_REQUEST): Remove.
647 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
648
f230ecc9
MR
6492011-06-06 Martin Rudalics <rudalics@gmx.at>
650
727e958e
MR
651 * lisp.h: Move EXFUNS for Fframe_root_window,
652 Fframe_first_window and Fset_frame_selected_window to window.h.
653
654 * window.h: Move EXFUNS for Fframe_root_window,
655 Fframe_first_window and Fset_frame_selected_window here from
656 lisp.h.
657
658 * frame.c (Fwindow_frame, Fframe_first_window)
659 (Fframe_root_window, Fframe_selected_window)
660 (Fset_frame_selected_window): Move to window.c.
661 (Factive_minibuffer_window): Move to minibuf.c.
662 (Fother_visible_frames_p): New function.
663
664 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
665
f230ecc9
MR
666 * window.c (decode_window, decode_any_window): Move up in code.
667 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
668 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
669 (Fwindow_buffer): Move up and rewrite doc-string.
670 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
671 (Fwindow_prev): New functions.
727e958e
MR
672 (Fwindow_frame): Move here from frame.c. Accept any window as
673 argument.
674 (Fframe_root_window, Fframe_first_window)
675 (Fframe_selected_window): Move here from frame.c. Accept frame
676 or arbitrary window as argument. Update doc-strings.
677 (Fminibuffer_window): Move up in code.
678 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
679 (Fset_frame_selected_window): Move here from frame.c.
680 Marginal rewrite.
727e958e
MR
681 (Fselected_window, select_window, Fselect_window): Move up in
682 code. Minor doc-string fixes.
f230ecc9 683
4d09bcf6
PE
6842011-06-06 Paul Eggert <eggert@cs.ucla.edu>
685
686 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
687 Do not assume that spare memory exists; that assumption is valid
688 only if SYSTEM_MALLOC.
689 (LARGE_REQUEST): New macro, so that the issue of large requests
690 is separated from the issue of spare memory.
691
810928a2
AS
6922011-06-05 Andreas Schwab <schwab@linux-m68k.org>
693
172418ad
AS
694 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
695 format. (Bug#8806)
696
43f862f7
AS
697 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
698
810928a2
AS
699 * xfns.c (x_set_scroll_bar_default_width): Move declarations
700 before statements.
701
a059fe24
JD
7022011-06-05 Jan Djärv <jan.h.d@swipnet.se>
703
704 * gtkutil.c (xg_get_default_scrollbar_width): New function.
705
706 * gtkutil.h: Declare xg_get_default_scrollbar_width.
707
708 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
709 min width by calling x_set_scroll_bar_default_width (Bug#8505).
710
989bf368
JB
7112011-06-05 Juanma Barranquero <lekktu@gmail.com>
712
713 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
714
4b80f674
CY
7152011-06-04 Chong Yidong <cyd@stupidchicken.com>
716
717 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
718 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
719 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
720 New error handlers.
4b80f674
CY
721 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
722 Obey Vx_select_enable_clipboard_manager. Catch errors in
723 x_clipboard_manager_save (Bug#8779).
724 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 725 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 726
99a33b77 7272011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
728
729 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
730
99a33b77 7312011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
732
733 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
734 in the current matrix if keep_current_p is non-zero.
735
8264569d
EZ
7362011-06-04 Eli Zaretskii <eliz@gnu.org>
737
738 * bidi.c (bidi_level_of_next_char): Fix last change.
739
57f97249
EZ
7402011-06-03 Eli Zaretskii <eliz@gnu.org>
741
fec2107c 742 Support bidi reordering of text covered by display properties.
57f97249 743
fec2107c
EZ
744 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
745 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
746 (bidi_cache_search, bidi_cache_iterator_state)
747 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
748 (bidi_level_of_next_char, bidi_move_to_visually_next):
749 Support character positions inside a run of characters covered by a
fec2107c
EZ
750 display string.
751 (bidi_paragraph_init, bidi_resolve_explicit_1)
752 (bidi_level_of_next_char): Call bidi_fetch_char and
753 bidi_fetch_char_advance instead of FETCH_CHAR and
754 FETCH_CHAR_ADVANCE.
755 (bidi_init_it): Initialize new members.
756 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
757 definitions.
758 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
759 instead of using explicit *_CHAR codes.
d6d100dd
SM
760 (bidi_resolve_explicit, bidi_resolve_weak):
761 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
762 bidirectional text is supported only in multibyte buffers.
763 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
764 it to initialize the frame_window_p member of struct bidi_it.
765 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
766 (bidi_resolve_explicit, bidi_resolve_weak)
767 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
768 bidi_it->nchars is non-positive.
769 (bidi_level_of_next_char): Don't try to lookup the cache for the
770 next/previous character if nothing is cached there yet, or if we
771 were just reseat()'ed to a new position.
c40e2fb2 772
0e14fe90
EZ
773 * xdisp.c (set_cursor_from_row): Set start and stop points
774 according to the row's direction when priming the loop that looks
775 for the glyph on which to display cursor.
776 (single_display_spec_intangible_p): Function deleted.
777 (display_prop_intangible_p): Reimplement to call
778 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
779 Accept 3 additional arguments needed by handle_display_spec.
780 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
781 values: lists, `(when COND...)' forms, etc.
782 (single_display_spec_string_p): Support property values that are
783 lists with the argument STRING its top-level element.
784 (display_prop_string_p): Fix the condition for processing a
785 property that is a list to be consistent with handle_display_spec.
fec2107c 786 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
787 last portion of handle_display_prop.
788 (compute_display_string_pos): Accept additional argument
789 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
790 value of a `display' property is a "replacing spec".
791 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
792 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
793 the display property, but just return a value indicating whether
794 the display property will replace the characters it covers.
795 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
796 frame_window_p members of struct bidi_it.
d6d100dd
SM
797 (compute_display_string_pos, compute_display_string_end):
798 New functions.
fec2107c
EZ
799 (push_it): Accept second argument POSITION, where pop_it should
800 jump to continue iteration.
801 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 802
fec2107c
EZ
803 * keyboard.c (adjust_point_for_property): Adjust the call to
804 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
805
806 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
807 (bidi_init_it): Update prototypes.
808 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
809 (compute_display_string_pos, compute_display_string_end):
810 Declare prototypes.
fec2107c
EZ
811 (struct bidi_it): New members nchars and disp_pos. ch_len is now
812 EMACS_INT.
fc6f18ce 813
40087514 8142011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 815
57f53182
PE
816 Malloc failure behavior now depends on size of allocation.
817 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
818 * lisp.h: Change signatures accordingly.
819 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
820 All callers changed. (Bug#8762)
821
822 * gnutls.c: Use Emacs's memory allocators.
823 Without this change, the gnutls library would invoke malloc etc.
824 directly, which causes problems on non-SYNC_INPUT hosts, and which
825 runs afoul of improving memory_full behavior. (Bug#8761)
826 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
827 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
828 xfree instead of the default malloc, realloc, free.
829 (Fgnutls_boot): No need to check for memory allocation failure,
830 since xmalloc does that for us.
831
ac32cd99 832 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
833 * category.c (hash_get_category_set):
834 * ccl.c (ccl_driver):
835 * charset.c (Fdefine_charset_internal):
836 * charset.h (struct charset.hash_index):
837 * composite.c (get_composition_id, gstring_lookup_cache)
838 (composition_gstring_put_cache):
839 * composite.h (struct composition.hash_index):
840 * dispextern.h (struct image.hash):
841 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
842 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
843 (hashfn_equal, hashfn_user_defined, make_hash_table)
844 (maybe_resize_hash_table, hash_lookup, hash_put)
845 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
846 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
847 (Fsxhash, Fgethash, Fputhash, Fmaphash):
848 * image.c (make_image, search_image_cache, lookup_image)
849 (xpm_put_color_table_h):
850 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 851 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
852 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
853 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
854 * alloc.c (allocate_vectorlike):
855 Check for overflow in vector size calculations.
856 * ccl.c (ccl_driver):
857 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
858 * fns.c, image.c: Remove unnecessary static decls that would otherwise
859 need to be updated by these changes.
40087514
PE
860 * fns.c (make_hash_table, maybe_resize_hash_table):
861 Check for integer overflow with large hash tables.
0de4bb68
PE
862 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
863 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
864 (SXHASH_REDUCE): New macro.
865 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
866 Use it instead of discarding useful hash info with large hash values.
867 (sxhash_float): New function.
868 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
869 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
870 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
871 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
872 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
873 Adjust signatures to match updated version of code.
874 (consing_since_gc): Now EMACS_INT, since a single hash table can
875 use more than INT_MAX bytes.
876
698d32e2
DN
8772011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
878
879 Make it possible to build with GCC-4.6+ -O2 -flto.
880
881 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
882
fd6fa53f
SM
8832011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
884
885 * minibuf.c (get_minibuffer, read_minibuf_unwind):
886 Call minibuffer-inactive-mode.
887
864db017
JB
8882011-05-31 Juanma Barranquero <lekktu@gmail.com>
889
890 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
891 Update dependencies.
892
2ad0baf4
DN
8932011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
894
895 * data.c (init_data): Remove code for UTS, this system is not
896 supported anymore.
897
4fcc2638
DN
8982011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
899
900 Don't force ./temacs to start in terminal mode.
901
902 * frame.c (make_initial_frame): Initialize faces in all cases, not
903 only when CANNOT_DUMP is defined.
904 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
905
c56e0fd5
DN
9062011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
907
908 * dispnew.c (add_window_display_history): Use const for the string
909 pointer. Remove declaration, not needed.
910
333d54da 9112011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 912
55d4c1b2 913 Use 'inline', not 'INLINE'.
333d54da 914 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
915 * alloc.c, fontset.c (INLINE): Remove.
916 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
917 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
918 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
919 * gmalloc.c (register_heapinfo): Use inline unconditionally.
920 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
921
738db178
DN
9222011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
923
924 Make it possible to run ./temacs.
925
926 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
927 syms_of_callproc does the same thing. Remove test for
928 "initialized", do it in the caller.
929 * emacs.c (main): Avoid calling set_initial_environment when dumping.
930
620c53a6
SM
9312011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
932
933 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
934 (read_minibuf): Use get_minibuffer.
935 (syms_of_minibuf): Use DEFSYM.
936 (Qmetadata): New var.
937 * data.c (Qbuffer): Don't make it static.
938 (syms_of_data): Use DEFSYM.
939
e003a292
PE
9402011-05-31 Paul Eggert <eggert@cs.ucla.edu>
941
942 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
943 (CCL_CODE_MIN): New macro.
944
ed008a6d
PE
9452011-05-30 Paul Eggert <eggert@cs.ucla.edu>
946
3687c2ef
PE
947 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
948
ed008a6d
PE
949 * eval.c (Qdebug): Now static.
950 * lisp.h (Qdebug): Remove decl. This reverts a part of the
951 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
952 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
953
d66c4c7c
CY
9542011-05-29 Chong Yidong <cyd@stupidchicken.com>
955
956 * image.c: Various fixes to ImageMagick code comments.
957 (Fimagemagick_types): Doc fix.
958
5fbc2025
PE
9592011-05-29 Paul Eggert <eggert@cs.ucla.edu>
960
0196f88a
PE
961 Minor fixes prompted by GCC 4.6.0 warnings.
962
963 * xselect.c (converted_selections, conversion_fail_tag): Now static.
964
5fbc2025
PE
965 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
966 (x_clipboard_manager_save_all): Move extern decl to ...
967 * xterm.h: ... here, so that it can be checked for consistency.
968
1dd3c2d9
CY
9692011-05-29 Chong Yidong <cyd@stupidchicken.com>
970
971 * xselect.c (x_clipboard_manager_save_frame)
972 (x_clipboard_manager_save_all): New functions.
973 (Fx_clipboard_manager_save): Lisp function deleted.
974
975 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
976 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
977
978 * xterm.h: Update prototype.
979
5ba6571d
WX
9802011-05-28 William Xu <william.xwl@gmail.com>
981
982 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
983 exiting (Bug#8239).
984
3eaff834
JM
9852011-05-28 Jim Meyering <meyering@redhat.com>
986
e1900994 987 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
988 * fns.c (to_uchar): Define.
989 (crypto_hash_function): Use it to convert some newly-signed
990 variables to unsigned, to avoid sign-extension bugs. For example,
991 without this change, (md5 "truc") would evaluate to
992 45723a2aff78ff4fff7fff1114760e62 rather than the expected
993 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 994 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 995
0f6990a7
PE
9962011-05-27 Paul Eggert <eggert@cs.ucla.edu>
997
998 Integer overflow fixes.
c8a9ca5a 999
08686060
PE
1000 * dbusbind.c: Serial number integer overflow fixes.
1001 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
1002 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1003 to hold a serial number that is too large for a fixnum.
1004 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1005 Check for serial numbers out of range. Decode any serial number
59568bf0 1006 that was so large that it became a float. (Bug#8722)
08686060 1007
2d1fc3c7
PE
1008 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1009 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1010 Use XFASTINT rather than XUINT when numbers are nonnegative.
1011 (xd_append_arg, Fdbus_method_return_internal):
1012 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1013 arguments, check that Lisp number is nonnegative, rather than
59568bf0 1014 silently wrapping negative numbers around. (Bug#8722)
30217ff0 1015 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 1016 (Bug#8722)
2d1fc3c7 1017
c8a9ca5a
PE
1018 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1019
519e1d69
PE
1020 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1021
30569699
PE
1022 ccl: add integer overflow checks
1023 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1024 (IN_INT_RANGE): New macros.
1025 (ccl_driver): Use them to check for integer overflow when
1026 decoding a CCL program. Many of the new checks are whether XINT (x)
1027 fits in int; it doesn't always, on 64-bit hosts. The new version
1028 doesn't catch all possible integer overflows, but it's an
847044ea 1029 improvement. (Bug#8719)
30569699 1030
c11285dc
PE
1031 * alloc.c (make_event_array): Use XINT, not XUINT.
1032 There's no need for unsigned here.
1033
fdccd48e
PE
1034 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1035 This follows up to the 2011-05-06 change that substituted uintptr_t
1036 for EMACS_INT. This case wasn't caught back then.
1037
37910ab2
PE
1038 Rework Fformat to avoid integer overflow issues.
1039 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1040 now (part of C89). Include <verify.h>.
1041 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1042 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1043 (Fformat): Avoid the prepass trying to compute sizes; it was only
1044 approximate and thus did not catch overflow reliably. Instead, walk
1045 through the format just once, formatting and computing sizes as we go,
1046 checking for integer overflow at every step, and allocating a larger
1047 buffer as needed. Keep track separately whether the format is
1048 multibyte. Keep only the most-recently calculated precision, rather
1049 than them all. Record whether each argument has been converted to
1050 string. Use EMACS_INT, not int, for byte and char and arg counts.
1051 Support field widths and precisions larger than INT_MAX. Avoid
1052 sprintf's undefined behavior with conversion specifications such as %#d
1053 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1054 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1055 formatting out-of-range floating point numbers with int
1056 formats. (Bug#8668)
1057
2e6578fb
PE
1058 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1059
0ae6bdee
PE
1060 * data.c: Avoid integer truncation in expressions involving floats.
1061 * data.c: Include <intprops.h>.
1062 (arith_driver): When there's an integer overflow in an expression
1063 involving floating point, convert the integers to floating point
1064 so that the resulting value does not suffer from catastrophic
1065 integer truncation. For example, on a 64-bit host (* 4
1066 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1067 Do not rely on undefined behavior after integer overflow.
1068
de883a70
PE
1069 merge count_size_as_multibyte, parse_str_to_multibyte
1070 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 1071 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
1072 Check for integer overflow.
1073 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1074 since it's now a duplicate of the other. This is more of
1075 a character than a buffer op, so better that it's in character.c.
1076 * fns.c, print.c: Adjust to above changes.
1077
2ff916cb
PE
10782011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1079
1080 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1081
f1b54466
PE
10822011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1083
fb1ac845
PE
1084 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1085 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1086 (x_clipboard_manager_save): Now static.
1087 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1088
f1b54466
PE
1089 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1090 (crypto_hash_function): Now static.
1091 Fix pointer signedness problems. Avoid unnecessary initializations.
1092
a9f737ee
CY
10932011-05-27 Chong Yidong <cyd@stupidchicken.com>
1094
1095 * termhooks.h (Vselection_alist): Make it terminal-local.
1096
1097 * terminal.c (create_terminal): Initialize it.
1098
1099 * xselect.c: Support for clipboard managers.
1100 (Vselection_alist): Move to termhooks.h as terminal-local var.
1101 (LOCAL_SELECTION): New macro.
1102 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1103 (symbol_to_x_atom): Remove gratuitous arg.
1104 (x_handle_selection_request, lisp_data_to_selection_data)
1105 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
1106 (x_own_selection, x_get_local_selection, x_convert_selection):
1107 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
1108 (some_frame_on_display): Delete unused function.
1109 (Fx_own_selection_internal, Fx_get_selection_internal)
1110 (Fx_disown_selection_internal, Fx_selection_owner_p)
1111 (Fx_selection_exists_p): New optional frame arg.
1112 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1113 (x_handle_selection_clear): Don't treat other terminals with the
1114 same keyboard specially. Use the terminal-local Vselection_alist.
1115 (x_clear_frame_selections): Use Frun_hook_with_args.
1116
1117 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1118
1119 * xterm.h: Add support for those atoms.
1120
e067f0c1
CY
11212011-05-26 Chong Yidong <cyd@stupidchicken.com>
1122
1123 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1124 (converted_selections, conversion_fail_tag): New global variables.
1125 (x_selection_request_lisp_error): Free the above.
1126 (x_get_local_selection): Remove unnecessary code.
1127 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
1128 of converted selections stored in converted_selections.
1129 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
1130 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1131 (x_convert_selection): New function.
1132 (x_handle_selection_event): Simplify.
1133 (x_get_foreign_selection): Don't ignore incoming requests while
1134 waiting for an answer; this will fail when we implement
1135 SAVE_TARGETS, and seems unnecessary anyway.
1136 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1137 (Vx_sent_selection_functions): Doc fix.
1138
0f4aebc0
LL
11392011-05-26 Leo Liu <sdl.web@gmail.com>
1140
1141 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1142
e61124cd
YM
11432011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1144
1145 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1146
1147 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1148 for fringe update if it has periodic bitmap.
1149 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1150 and fringe_bitmap_periodic_p.
1151
1152 * fringe.c (get_fringe_bitmap_data): New function.
1153 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1154 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1155 row. Mark glyph row for fringe update if periodicity changed.
1156
1157 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1158 for fringe update unless it has periodic bitmap.
1159
f16d9837
KH
11602011-05-25 Kenichi Handa <handa@m17n.org>
1161
1162 * xdisp.c (get_next_display_element): Set correct it->face_id for
1163 a static composition.
1164
e1b90ef6
LL
11652011-05-24 Leo Liu <sdl.web@gmail.com>
1166
1167 * deps.mk (fns.o):
1168 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1169
1170 * fns.c (crypto_hash_function, Fsha1): New function.
1171 (Fmd5): Use crypto_hash_function.
1172 (syms_of_fns): Add Ssha1.
1173
7400048f
PE
11742011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1175
1176 * gnutls.c: Remove unused macros.
1177 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1178 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1179 Remove macros that are defined and never used.
1180 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1181
abb71cf4
CY
11822011-05-22 Chong Yidong <cyd@stupidchicken.com>
1183
1184 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1185 (Fx_get_selection_internal): Minor cleanup.
1186 (Fx_own_selection_internal): Rename arguments for consistency with
1187 select.el.
1188
6307db39
PE
11892011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1190
1191 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1192
f3d4e0a4
CY
11932011-05-22 Chong Yidong <cyd@stupidchicken.com>
1194
1195 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1196
4d8ade89
YM
11972011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1198
1199 * dispnew.c (scrolling_window): Don't exclude the case that the
1200 last enabled row in the desired matrix touches the bottom boundary.
1201
32078c8d
GM
12022011-05-21 Glenn Morris <rgm@gnu.org>
1203
1204 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
1205 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1206 and add some more files.
32078c8d 1207
7285dc67
EZ
12082011-05-20 Eli Zaretskii <eliz@gnu.org>
1209
1210 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1211 report_file_error introduced by the change from 2011-05-07.
1212
89d1bd22
PE
12132011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1214
1215 * systime.h (Time): Define only if emacs is defined.
1216 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1217 where the include path doesn't have X11/X.h by default. See
1218 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1219
e23640bb 12202011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
1221
1222 * composite.c (find_automatic_composition): Fix previous change.
1223
b9704ad9
GM
12242011-05-20 Glenn Morris <rgm@gnu.org>
1225
1226 * lisp.mk: New file, split from Makefile.in.
1227 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1228 (shortlisp): Remove.
1229 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1230
4a720484
GM
12312011-05-19 Glenn Morris <rgm@gnu.org>
1232
1233 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1234 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1235 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1236 (lisp): Set the order to that of loadup.el.
1237 (shortlisp): Make it a copy of $lisp.
1238 (SOME_MACHINE_LISP): Remove.
1239 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1240 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1241
a28d4396
KH
12422011-05-18 Kenichi Handa <handa@m17n.org>
1243
1244 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1245 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1246 (find_automatic_composition): Mostly rewrite for efficiency.
1247
a2b1fa8e
JB
12482011-05-18 Juanma Barranquero <lekktu@gmail.com>
1249
1250 * makefile.w32-in: Update dependencies.
1251
8e1f5610
CS
12522011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1253
1254 * menu.c: Include limits.h (fixes the MS-Windows build broken by
1255 revision 104625).
1256
7025ee00 12572011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 1258
cdfa6eab
PE
1259 Fix some integer overflow issues, such as string length overflow.
1260
06d6db33
PE
1261 * insdel.c (count_size_as_multibyte): Check for string overflow.
1262
2b4560a8
PE
1263 * character.c (lisp_string_width): Check for string overflow.
1264 Use EMACS_INT, not int, for string indexes and lengths; in
1265 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1266 the resulting string length overflows an EMACS_INT; instead,
1267 report a string overflow if no precision given. When checking for
1268 precision exhaustion, use a check that cannot possibly have
1269 integer overflow. (Bug#8675)
1270 * character.h (lisp_string_width): Adjust to new signature.
1271
cb93f9be
PE
1272 * alloc.c (string_overflow): New function.
1273 (Fmake_string): Use it. This doesn't change behavior, but saves
1274 a few bytes and will simplify future changes.
1275 * character.c (string_escape_byte8): Likewise.
1276 * lisp.h (string_overflow): New decl.
1277
1a1f3366
PE
1278 Fixups, following up to the user-interface timestamp change.
1279 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1280 for UI timestamps, instead of unsigned long.
9fbd6841
PE
1281 * msdos.c (mouse_get_pos): Likewise.
1282 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
1283 * w32gui.h (Time): Define by including "systime.h" rather than by
1284 declaring it ourselves. (Bug#8664)
1285
d4e3e4d3
PE
1286 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1287 * image.c (clear_image_cache): Likewise.
1288
f6a24d19
PE
1289 * term.c (term_mouse_position): Don't assume time_t wraparound.
1290
08dc5ae6
PE
1291 Be more systematic about user-interface timestamps.
1292 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
1293 and sometimes 'EMACS_UINT', to represent these timestamps.
1294 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
1295 This makes the code easier to follow, and makes it easier to catch
1296 integer overflow bugs such as Bug#8664.
1297 * frame.c (Fmouse_position, Fmouse_pixel_position):
1298 Use Time, not unsigned long, for user-interface timestamps.
1299 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1300 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1301 * keyboard.h (last_event_timestamp): Likewise.
1302 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1303 * menu.h (xmenu_show): Likewise.
1304 * term.c (term_mouse_position): Likewise.
1305 * termhooks.h (struct input_event.timestamp): Likewise.
1306 (struct terminal.mouse_position_hook): Likewise.
1307 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1308 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1309 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1310 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1311 what it was before.
1312 * menu.h, termhooks.h: Include "systime.h", for Time.
1313
8e55734a
PE
1314 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1315 Don't assume that the difference between two unsigned long values
1316 can fit into an integer. At this point, we know button_down_time
1317 <= event->timestamp, so the difference must be nonnegative, so
1318 there's no need to cast the result if double-click-time is
1319 nonnegative, as it should be; check that it's nonnegative, just in
1320 case. This bug is triggered when events are more than 2**31 ms
86db42d2 1321 apart (about 25 days). (Bug#8664)
8e55734a 1322
841f1b75 1323 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 1324 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 1325
3e26f69c
PE
1326 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1327 that always fit in int. Use a sentinel instead of a counter, to
1328 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
1329 * frame.h (struct frame): Use int for menu_bar_items_used
1330 instead of EMACS_INT, since it always fits in int.
3e26f69c 1331
5cc152c0
PE
1332 * menu.c (grow_menu_items): Check for int overflow.
1333
d89eb65e
PE
1334 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1335
5235bd3e
PE
1336 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1337 Before, the code was not consistent. These values cannot exceed
1338 2**31 - 1 so there's no need to make them unsigned.
1339 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1340 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1341 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1342 as modifiers.
1343 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1344
bc827e23
PE
1345 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1346 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1347 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1348 presumably because the widths might not match.
1349
78eb494e
PE
1350 * window.c (size_window): Avoid needless test at loop start.
1351
04f2d78b
CB
13522011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1353
1354 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1355
d2fc7e3d 13562011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
1357
1358 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1359
d2fc7e3d 13602011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
1361
1362 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1363 `width' to `bar_area_x' and `bar_area_width', respectively.
1364 (x_scroll_run): Take account of fringe background extension.
1365
04f2d78b
CB
1366 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1367 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
1368 `bar_area_width', respectively.
1369 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1370 background extension.
1371
79b70037
GM
13722011-05-10 Jim Meyering <meyering@redhat.com>
1373
1374 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1375
2f142cc5
JB
13762011-05-10 Juanma Barranquero <lekktu@gmail.com>
1377
1378 * image.c (Finit_image_library): Return t for built-in image types,
1379 like pbm and xbm. (Bug#8640)
1380
57679c86
AS
13812011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1382
1383 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1384
888c9e86
EZ
13852011-05-07 Eli Zaretskii <eliz@gnu.org>
1386
b0512a1d
EZ
1387 * w32console.c (Fset_screen_color): Doc fix.
1388 (Fget_screen_color): New function.
1389 (syms_of_ntterm): Defsubr it.
1390
7285dc67
EZ
1391 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1392 unlink the temporary file if Fcall_process didn't create it in the
1393 first place.
1394 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1395 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
1396 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1397 cue to call_process_cleanup not to close that handle.
1398
4d3fcc8e
BK
13992011-05-07 Ben Key <bkey76@gmail.com>
1400
1401 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1402 one of two shell specific rules, either bootstrap-temacs-CMD or
1403 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1404 to the previous implementation of the bootstrap-temacs rule.
1405 The bootstrap-temacs-CMD rule is similar to the previous
1406 implementation of the bootstrap-temacs rule except that it
1407 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1408 variable.
1409
1410 These changes, along with some changes to nt/configure.bat,
1411 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1412 earlier fix to add support for --cflags and --ldflags options
1413 that include quotes so that it works whether make uses cmd or
1414 sh as the shell.
1415
b4289b64
MA
14162011-05-06 Michael Albinus <michael.albinus@gmx.de>
1417
1418 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1419 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1420 is a constant.
1421 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1422 a string. Handle both cases.
1423 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1424 (Fdbus_register_method): Use Qinvalid_function.
1425
af4c0e28
JB
14262011-05-06 Juanma Barranquero <lekktu@gmail.com>
1427
1428 * makefile.w32-in: Update dependencies.
1429 (LISP_H): Add inttypes.h and stdin.h.
1430 (PROCESS_H): Add unistd.h.
1431
c51453d9
EZ
14322011-05-06 Eli Zaretskii <eliz@gnu.org>
1433
1434 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1435 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1436
8ff0ac3c 14372011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 1438
4c4b566b
PE
1439 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1440
aab2b9b5
PE
1441 * term.c (vfatal): Remove stray call to va_end.
1442 It's not needed and the C Standard doesn't allow it here anyway.
1443
c378da0b
PE
1444 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1445 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1446
288b08c7
PE
1447 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1448 bytes.
1449
e3601888
PE
1450 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1451
db6c0e74
PE
1452 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1453
dd5963ea
PE
1454 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1455
88c9450f
PE
1456 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1457
2f9442b8
PE
1458 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1459
c032b5f8
PE
1460 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1461 * charset.c (Fdefine_charset_internal): Don't initialize
1462 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 1463 32-bit int (Bug#8600).
a108c10b
PE
1464
1465 * lread.c (read_integer): Be more consistent with string-to-number.
1466 Use string_to_number to do the actual conversion; this avoids
1467 rounding errors and fixes some other screwups. Without this fix,
1468 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1469 (digit_to_number): Move earlier, for benefit of read_integer.
1470 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 1471 not a digit in any supported base. (Bug#8602)
a108c10b 1472
ad5f9eea
PE
1473 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1474
aec1708a
PE
1475 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1476 to match comment at start of function. This also removes a
1477 GCC warning about overflow in a 32+64-bit port.
1478
47be4ab5
PE
1479 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1480
371cac43
PE
1481 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1482 Reported by Stefan Monnier in
1483 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
1484 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1485 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 1486
d01a7826
PE
1487 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1488 (EMACS_UINTPTR): Likewise, with uintptr_t.
1489
7fd47d5c
PE
1490 * lisp.h: Prefer 64-bit EMACS_INT if available.
1491 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1492 on 32-bit hosts that have 64-bit int, so that they can access
1493 large files.
122b0c86
PE
1494 However, temporarily disable this change unless the temporary
1495 symbol WIDE_EMACS_INT is defined.
7fd47d5c 1496
8727937b
PE
1497 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1498
8ac068ac
PE
1499 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1500 This removes an assumption that EMACS_INT and long are the same
1501 width as pointers. The assumption is true for Emacs porting targets
1502 now, but we want to make other targets possible.
1503 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1504 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1505 In the rest of the code, change types of integers that hold casted
1506 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1507 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1508 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1509 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1510 No need to cast type when ORing.
1511 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1512 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1513 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1514 assume EMACS_INT is the same width as char *.
1515 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1516 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1517 Remove no-longer-needed casts.
1518 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1519 (xg_tool_bar_help_callback, xg_make_tool_item):
1520 Use EMACS_INTPTR to hold an integer
1521 that will be cast to void *; this can avoid a GCC warning
1522 if EMACS_INT is not the same width as void *.
1523 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1524 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1525 (current_message_1, set_message_1):
1526 Use a local to convert to proper width without a cast.
1527 * xmenu.c (dialog_selection_callback): Likewise.
1528
ede49d71
PE
1529 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1530 Also, don't assume VALBITS / RAND_BITS is less than 5,
1531 and don't rely on undefined behavior when shifting a 1 left into
1532 the sign bit.
1533 * lisp.h (get_random): Change signature to match.
1534
2f30ecd0
PE
1535 * lread.c (hash_string): Use size_t, not int, for hash computation.
1536 Normally we prefer signed values; but hashing is special, because
1537 it's better to use unsigned division on hash table sizes so that
1538 the remainder is nonnegative. Also, size_t is the natural width
1539 for hashing into memory. The previous code used 'int', which doesn't
1540 retain enough info to hash well into very large tables.
1541 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1542
2a866e7b
PE
1543 * dbusbind.c: Don't possibly lose pointer info when converting.
1544 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1545 Use XPNTR rather than XHASH, so that the high-order bits of
1546 the pointer aren't lost when converting through void *.
1547
51639eac
PE
1548 * eval.c (Fautoload): Don't double-shift a pointer.
1549
92394119
PE
1550 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1551
dbdb9a7c
JB
15522011-05-06 Juanma Barranquero <lekktu@gmail.com>
1553
1554 * gnutls.c (DEF_GNUTLS_FN):
1555 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1556
db7a0b4f
AS
15572011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1558
1559 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1560 marker. (Bug#8610)
1561
f7ff1b0f 15622011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
1563
1564 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1565 New version that can reserve upto 2GB of heap space.
1566
f7ff1b0f 15672011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
1568
1569 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1570
639c109b
TZ
15712011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1572
1573 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1574 `gnutls_certificate_set_x509_key_file'.
1575
d2127135
JB
15762011-05-05 Juanma Barranquero <lekktu@gmail.com>
1577
1578 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1579 Update dependencies.
1580
e968f4f3
JB
15812011-05-04 Juanma Barranquero <lekktu@gmail.com>
1582
1583 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1584 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1585 Remove unused parameter `fildes'.
1586 * process.c (read_process_output, send_process): Don't pass it.
1587
84d358f0
JB
15882011-05-04 Juanma Barranquero <lekktu@gmail.com>
1589
1590 Fix previous change: the library cache is defined in w32.c.
1591 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1592 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1593
0898ca10
JB
15942011-05-04 Juanma Barranquero <lekktu@gmail.com>
1595
1596 Implement dynamic loading of GnuTLS on Windows.
1597
1598 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1599 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1600 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1601 Declare.
1602
1603 * gnutls.c (Qgnutls_dll): Define.
1604 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1605 (gnutls_*): Declare function pointers.
1606 (init_gnutls_functions): New function to initialize function pointers.
1607 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1608 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1609 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1610 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1611 (emacs_gnutls_write, emacs_gnutls_read)
1612 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1613 (Fgnutls_available_p): New function.
1614 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1615 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1616 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1617
1618 * image.c: Include w32.h.
1619 (Vimage_type_cache): Delete.
1620 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1621 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1622 (w32_delayed_load): Move to w32.c.
1623
1624 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1625
1626 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1627 (w32_delayed_load): Move from image.c. When loading a library, record
1628 its filename in the :loaded-from property of the library id.
1629 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1630 Initialize and staticpro them.
1631 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1632
1633 * process.c: Include lisp.h before w32.h, not after.
1634 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1635 instead of gnutls_record_check_pending.
1636
1637 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1638
ff4de4aa
TZ
16392011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1640
1641 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1642 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1643 as passed in.
1644
abe95abb
JD
16452011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1646
1647 * xterm.c (x_set_frame_alpha): Do not set property on anything
1648 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1649
e16e55d4
JB
16502011-05-02 Juanma Barranquero <lekktu@gmail.com>
1651
1652 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1653
bafcf6a5
JB
16542011-05-02 Juanma Barranquero <lekktu@gmail.com>
1655
1656 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1657 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1658 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1659 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1660 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1661 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1662 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1663 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1664 (Qgnutls_bootprop_callbacks_verify): Make static.
1665
e7a6747f
AS
16662011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1667
19ed11ba
AS
1668 * callproc.c: Indentation fixup.
1669
e7a6747f 1670 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
1671 (wait_for_termination, interruptible_wait_for_termination):
1672 Move after wait_for_termination_1.
e7a6747f 1673
1ef14cb4
LMI
16742011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1675
1676 * sysdep.c (interruptible_wait_for_termination): New function
1677 which is like wait_for_termination, but allows keyboard
1678 interruptions.
1679
1680 * callproc.c (Fcall_process): Add (:file "file") as an option for
1681 the STDOUT buffer.
1682 (Fcall_process_region): Ditto.
1683
330d880c
EZ
16842011-04-30 Eli Zaretskii <eliz@gnu.org>
1685
8db90b73
EZ
1686 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1687 rather than `XVECTOR (FOO)->size'.
1688
330d880c
EZ
1689 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1690 inttypes.h, as a gnulib replacement is used if it not available in
1691 system headers.
1692
15cbd324
EZ
16932011-04-21 Eli Zaretskii <eliz@gnu.org>
1694
1695 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1696 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1697 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1698
1699 * coding.c (coding_alloc_by_realloc): Error out if destination
1700 will grow beyond MOST_POSITIVE_FIXNUM.
1701 (decode_coding_emacs_mule): Abort if there isn't enough place in
1702 charbuf for the composition carryover bytes. Reserve an extra
1703 space for up to 2 characters produced in a loop.
1704 (decode_coding_iso_2022): Abort if there isn't enough place in
1705 charbuf for the composition carryover bytes.
1706
17072011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 1708
ae940cca
EZ
1709 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1710 aborting when %lld or %lll format is passed.
1711 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1712 %llo or %llx format is passed. (Bug#8545)
1713
03ab8921
EZ
1714 * window.c (window_scroll_line_based): Use a marker instead of
1715 simple variables to record original value of point. (Bug#7952)
1716
afda1437
EZ
1717 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1718 produced by %s or %c overflows available buffer space. (Bug#8545)
1719
f76dee0c
PE
17202011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1721
1722 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 1723 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 1724
fdc5744d
JB
17252011-04-28 Juanma Barranquero <lekktu@gmail.com>
1726
1727 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1728
638f053a
JB
17292011-04-28 Juanma Barranquero <lekktu@gmail.com>
1730
1731 * keyboard.c (Qdelayed_warnings_hook): Define.
1732 (command_loop_1): Run `delayed-warnings-hook'
1733 if Vdelayed_warnings_list is non-nil.
1734 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1735 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1736
d178f871
EZ
17372011-04-28 Eli Zaretskii <eliz@gnu.org>
1738
1739 * doprnt.c (doprnt): Don't return value smaller than the buffer
1740 size if the message was truncated. (Bug#8545).
1741
b124fd93
JB
17422011-04-28 Juanma Barranquero <lekktu@gmail.com>
1743
1744 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1745 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1746
e810457d
PE
17472011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1748
1749 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1750
ea51cceb
JB
17512011-04-27 Juanma Barranquero <lekktu@gmail.com>
1752
1753 * makefile.w32-in: Update dependencies.
1754
94dcfacf
EZ
17552011-04-27 Eli Zaretskii <eliz@gnu.org>
1756
1757 Improve `doprnt' and its usage. (Bug#8545)
1758 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1759 `format_end'. Remove support for %l as a conversion specifier.
1760 Don't use xrealloc. Improve diagnostics when the %l size modifier
1761 is used. Update the commentary.
1762
1763 * eval.c (verror): Simplify calculation of size_t.
1764
1765 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1766 messages.
1767
f61f41d7
PE
17682011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1769
1770 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1771 change.
1772
96fb4434
PE
17732011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1774
1775 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1776 This makes this file independent of the recent pseudovector change.
1777
671875da 17782011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 1779
69e9b5a3
PE
1780 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1781
b5f869a7 1782 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 1783 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 1784 Remove unused local.
c8926152 1785 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 1786
841a1577 1787 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
1788 GCC 4.6.0 optimizes based on type-based alias analysis.
1789 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
1790 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1791 != &v->size, and therefore "v->size = 1; b->size = 2; return
1792 v->size;" must therefore return 1. This assumption is incorrect
1793 for Emacs, since it type-puns struct Lisp_Vector * with many other
1794 types. To fix this problem, this patch adds a new type struct
f904488f 1795 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
1796 and pseudovectors, and helps optimizing compilers not get fooled
1797 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1798 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
1799 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1800 the size member.
eab3844f
PE
1801 (XSETPVECTYPE): Rewrite in terms of new macro.
1802 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1803 This is a bit clearer, and further avoids the possibility of
1804 undesirable aliasing.
1805 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 1806 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
1807 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1808 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
1809 (ASIZE): Now uses header.size rather than size.
1810 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
1811 to avoid the hassle of writing XVECTOR (foo)->header.size.
1812 (struct vectorlike_header): New type.
eab3844f
PE
1813 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1814 object, to help avoid aliasing.
1815 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1816 (SUBRP): Likewise, since Lisp_Subr is a special case.
1817 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1818 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1819 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 1820 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
1821 changed to be "header.size" and "header.next".
1822 * buffer.h (struct buffer): Likewise.
1823 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1824 * frame.h (struct frame): Likewise.
1825 * process.h (struct Lisp_Process): Likewise.
1826 * termhooks.h (struct terminal): Likewise.
1827 * window.c (struct save_window_data, struct saved_window): Likewise.
1828 * window.h (struct window): Likewise.
1829 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1830 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1831 * buffer.c (init_buffer_once): Likewise.
1832 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1833 special case.
1834 * process.c (Fformat_network_address): Use local var for size,
1835 for brevity.
1836
0df1eac5
PE
1837 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1838
847ab9d1 1839 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
1840 * data.c (atof): Remove decl; no longer used or needed.
1841 (digit_to_number): Move to lread.c.
1842 (Fstring_to_number): Use new string_to_number function, to be
1843 consistent with how the Lisp reader treats infinities and NaNs.
1844 Do not assume that floating-point numbers represent EMACS_INT
1845 without losing information; this is not true on most 64-bit hosts.
1846 Avoid double-rounding errors, by insisting on integers when
1847 parsing non-base-10 numbers, as the documentation specifies.
1848 * lisp.h (string_to_number): New decl, replacing ...
1849 (isfloat_string): Remove.
bc0a5c13 1850 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 1851 (read1): Do not accept +. and -. as integers; this
452f4150
PE
1852 appears to have been a coding error. Similarly, do not accept
1853 strings like +-1e0 as floating point numbers. Do not report
1854 overflow for integer overflows unless the base is not 10 which
1855 means we have no simple and reliable way to continue.
1856 Break out the floating-point parsing into a new
1857 function string_to_number, so that Fstring_to_number parses
1858 floating point numbers consistently with the Lisp reader.
04f2d78b 1859 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
1860 (E_CHAR, EXP_INT): Remove, replacing with ...
1861 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1862 (string_to_number): New function, replacing isfloat_string.
1863 This function checks for valid syntax and produces the resulting
1864 Lisp float number too. Rework it so that string-to-number
bc0a5c13 1865 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
1866 so that overflow for non-base-10 numbers is reported only when
1867 there's no portable and simple way to convert to floating point.
452f4150 1868
67769ffc
PE
1869 * textprop.c (set_text_properties_1): Rewrite for clarity,
1870 and to avoid GCC warning about integer overflow.
1871
c20db43f
PE
1872 * intervals.h (struct interval): Use EMACS_INT for members
1873 where EMACS_UINT might cause problems. See
1874 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1875 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1876 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1877 All uses changed.
37aa2f85
PE
1878 (offset_intervals): Tell GCC not to worry about length overflow
1879 when negating a negative length.
c20db43f 1880
2538aa2f
PE
1881 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1882 (overrun_check_free): Likewise.
1883
f2d3008d
PE
1884 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1885 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1886 word size.
1887
ec8df744
PE
1888 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1889 (gnutls_make_error): Rename local to avoid shadowing.
1890 (gnutls_emacs_global_deinit): ifdef out; not used.
1891 (Fgnutls_boot): Use const for pointer to readonly storage.
1892 Comment out unused local. Fix pointer signedness problems.
1893
640ee02d
PE
1894 * lread.c (openp): Don't stuff size_t into an 'int'.
1895 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1896 about possible signed overflow.
1897
6048fb2a
PE
1898 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1899 (GDK_KEY_g): Don't define if already defined.
1900 (xg_prepare_tooltip): Avoid pointer signedness problem.
1901 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1902
fa3c87e1
PE
1903 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1904 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1905
2172544b
PE
1906 * xfns.c (Fx_window_property): Simplify a bit,
1907 to make a bit faster and to avoid GCC 4.6.0 warning.
1908 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1909
9b821a21
PE
1910 * fns.c (internal_equal): Don't assume size_t fits in int.
1911
3c616cfa
PE
1912 * alloc.c (compact_small_strings): Tighten assertion a little.
1913
c2982e87
PE
1914 Replace pEd with more-general pI, and fix some printf arg casts.
1915 * lisp.h (pI): New macro, generalizing old pEd macro to other
1916 conversion specifiers. For example, use "...%"pI"d..." rather
1917 than "...%"pEd"...".
1918 (pEd): Remove. All uses replaced with similar uses of pI.
1919 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1920 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1921 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1922 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1923 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1924 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1925 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1926 64-bit hosts.
1927 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1928 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1929 * print.c (safe_debug_print, print_object): Likewise.
1930 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1931 to int.
6f04d126
PE
1932 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1933 avoiding the 0 flag, which is not portable.
c2982e87
PE
1934 * process.c (Fmake_network_process): Use pI to avoid cast.
1935 * region-cache.c (pp_cache): Likewise.
1936 * xdisp.c (decode_mode_spec): Likewise.
1937 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1938 behavior on 64-bit hosts with printf arg.
6f04d126 1939 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
1940 (x_stop_queuing_selection_requests): Likewise.
1941 (x_get_window_property): Don't truncate byte count to an 'int'
1942 when tracing.
0b432f21 1943
5e073ec7
PE
1944 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1945 here, since it parses constructs like leading '-' and spaces,
1946 which are not wanted; and it overflows with large numbers.
1947 Instead, simply match F[0-9]+, which is what is wanted anyway.
1948
36372bf9
PE
1949 * alloc.c: Remove unportable assumptions about struct layout.
1950 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1951 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1952 (allocate_vectorlike, make_pure_vector): Use the new macros,
1953 plus offsetof, to remove unportable assumptions about struct layout.
1954 These assumptions hold on all porting targets that I know of, but
1955 they are not guaranteed, they're easy to remove, and removing them
1956 makes further changes easier.
1957
0b432f21
PE
1958 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1959 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
1960 (string_overrun_cookie): Now const. Use initializers that
1961 don't formally overflow signed char, to avoid warnings.
000098c1
PE
1962 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1963 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
1964 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1965 multiple of sizeof (EMACS_INT); it need not be, if
1966 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 1967 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 1968
895009e1
JB
19692011-04-26 Juanma Barranquero <lekktu@gmail.com>
1970
1971 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1972
6a7a1b0b
TZ
19732011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1974
1975 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 1976 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
1977 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1978
841a1577 19792011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
1980
1981 * lisp.h (Qdebug): List symbol.
895009e1 1982 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
1983 * keyboard.c (debug-on-event): New variable.
1984 (handle_user_signal): Break into debugger when debug-on-event
1985 matches the current signal symbol.
1986
f2d3ba6f
DN
19872011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1988
1989 * alloc.c (check_sblock, check_string_bytes)
1990 (check_string_free_list): Convert to standard C.
1991
42ce4c63
TZ
19922011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1993
1994 * w32.c (emacs_gnutls_push): Fix typo.
1995
825cd63c
EZ
19962011-04-25 Eli Zaretskii <eliz@gnu.org>
1997
fb11d64d
EZ
1998 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1999 "cast to pointer from integer of different size".
2000
825cd63c
EZ
2001 Improve doprnt and its use in verror. (Bug#8545)
2002 * doprnt.c (doprnt): Document the set of format control sequences
2003 supported by the function. Use SAFE_ALLOCA instead of always
2004 using `alloca'.
2005
2006 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2007 is one byte too soon. Don't use xrealloc; instead xfree and
2008 xmalloc anew.
2009
e061a11b
TZ
20102011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2011
2012 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2013 callbacks stage.
2014
2015 * gnutls.c: Renamed global_initialized to
2016 gnutls_global_initialized. Added internals for the
2017 :verify-hostname-error, :verify-error, and :verify-flags
2018 parameters of `gnutls-boot' and documented those parameters in the
2019 docstring. Start callback support.
2020 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2021 unless a fatal error occured. Call gnutls_alert_send_appropriate
2022 on error. Return error code.
2023 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2024 (emacs_gnutls_read): Likewise.
2025 (Fgnutls_boot): Return handshake error code.
2026 (emacs_gnutls_handle_error): New function.
2027 (wsaerror_to_errno): Likewise.
2028
2029 * w32.h (emacs_gnutls_pull): Add prototype.
2030 (emacs_gnutls_push): Likewise.
2031
2032 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2033 (emacs_gnutls_push): Likewise.
2034
20352011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2036
2037 * process.c (wait_reading_process_output): Check if GnuTLS
2038 buffered some data internally if no FDs are set for TLS
2039 connections.
2040
2041 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2042 (LIBS): Link to USER_LIBS.
2043 ($(BLD)/gnutls.$(0)): New target.
2044
fa6996bc
EZ
20452011-04-24 Eli Zaretskii <eliz@gnu.org>
2046
eb35682e
EZ
2047 * xdisp.c (handle_single_display_spec): Rename the
2048 display_replaced_before_p argument into display_replaced_p, to
2049 make it consistent with the commentary. Fix typos in the
2050 commentary.
2051
e2ad650c
EZ
2052 * textprop.c (syms_of_textprop): Remove dead code.
2053 (copy_text_properties): Delete obsolete commentary about an
2054 interface that was deleted long ago. Fix typos in the description
2055 of arguments.
2056
1b2de274
EZ
2057 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2058 to changes in oldXMenu/XMenu.h from 2011-04-16.
2059 <menu_help_message, prev_menu_help_message>: Constify.
2060 (IT_menu_make_room): menu->help_text is now `const char **';
2061 adjust.
2062
2063 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2064 to changes in oldXMenu/XMenu.h from 2011-04-16.
2065 (struct XMenu): Declare `help_text' `const char **'.
2066
2067 * xfaces.c <Qunspecified>: Make extern again.
2068
2069 * syntax.c: Include sys/types.h before including regex.h, as
2070 required by Posix.
2071
762b15be
EZ
2072 * doc.c (get_doc_string): Improve the format passed to `error'.
2073
2074 * doprnt.c (doprnt): Improve commentary.
2075
2076 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2077
2078 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2079 them with etags.
2080
f1052e5d
EZ
2081 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2082 changes in globals.h immediately force recompilation.
762b15be
EZ
2083 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2084 $(CURDIR)/s/ms-w32.h.
2085 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 2086
fa6996bc
EZ
2087 * character.c (Fchar_direction): Function deleted.
2088 (syms_of_character): Don't defsubr it.
2089 <char-direction-table>: Deleted.
2090
e6c3da20
EZ
20912011-04-23 Eli Zaretskii <eliz@gnu.org>
2092
2093 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2094 * doprnt.c: Include limits.h.
2095 (SIZE_MAX): New macro.
04f2d78b
CB
2096 (doprnt): Return a size_t value. 2nd arg is now size_t.
2097 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
2098 Improve overflow protection. Support `l' modifier for integer
2099 conversions. Support %l conversion. Don't assume an EMACS_INT
2100 argument for integer conversions and for %c.
2101
2102 * lisp.h (doprnt): Restore prototype.
2103
2104 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2105 $(SRC)/character.h.
2106
2107 * Makefile.in (base_obj): Add back doprnt.o.
2108
2109 * deps.mk (doprnt.o): Add back prerequisites.
2110 (callint.o): Depend on character.h.
2111
2112 * eval.c (internal_lisp_condition_case): Include the handler
2113 representation in the error message.
2114 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2115 when breaking from the loop.
2116
2117 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2118
2119 * callint.c (Fcall_interactively): When displaying error message
2120 about invalid control letter, pass the character's codepoint, not
2121 a pointer to its multibyte form. Improve display of the character
2122 in octal and display also its hex code.
2123
2124 * character.c (char_string): Use %x to display the (unsigned)
2125 codepoint of an invalid character, to avoid displaying a bogus
2126 negative value.
2127
2128 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2129 `error', not SYMBOL_NAME itself.
2130
2131 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2132 character arguments to `error'.
2133
2134 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2135 to `error' in error message about FINAL_CHAR argument. Make sure
2136 FINAL_CHAR is a character, and use %c when it is passed as
2137 argument to `error'.
2138
4ffd0d6b 21392011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
2140
2141 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2142
2143 * w32.c: Include <time.h>.
2144 (sys_localtime): New function.
2145
4ffd0d6b 21462011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
2147
2148 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2149
4ffd0d6b 2150 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 2151
4ffd0d6b 21522011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 2153
4ffd0d6b
GM
2154 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2155 zombies (Bug#8467).
aac0c6e3 2156
04c56954
EZ
21572011-04-19 Eli Zaretskii <eliz@gnu.org>
2158
2159 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2160 gl_state.e_property when gl_state.object is Qt.
2161
2162 * insdel.c (make_gap_larger): Remove limitation of buffer size
2163 to <= INT_MAX.
2164
16a43933
CY
21652011-04-18 Chong Yidong <cyd@stupidchicken.com>
2166
2167 * xdisp.c (lookup_glyphless_char_display)
2168 (produce_glyphless_glyph): Handle cons cell entry in
2169 glyphless-char-display.
2170 (Vglyphless_char_display): Document it.
2171
2172 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2173 glyphless-char-display.
2174
4581706e
CY
21752011-04-17 Chong Yidong <cyd@stupidchicken.com>
2176
2177 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2178
2179 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2180
2181 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2182 definition for no-X builds.
2183
4887c6e2 21842011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 2185
fd35b6f9
PE
2186 Static checks with GCC 4.6.0 and non-default toolkits.
2187
5c1ccb01
PE
2188 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2189
006c5daa
PE
2190 * process.c (keyboard_bit_set): Define only if SIGIO.
2191 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2192 (send_process): Repair possible setjmp clobbering.
2193
efc736d3
PE
2194 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2195
4e2fe2e6
PE
2196 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2197
f97334a2
PE
2198 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2199
4e75f29d
PE
2200 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2201 Define only if needed.
2202
90efadd1
PE
2203 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2204 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 2205 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 2206
3c647824
PE
2207 * dispextern.h (struct redisplay_interface): Rename param
2208 to avoid shadowing.
e264f262 2209 * termhooks.h (struct terminal): Likewise.
761383f4 2210 * xterm.c (xembed_send_message): Likewise.
3c647824 2211
b58c5c4a
PE
2212 * insdel.c (make_gap_smaller): Define only if
2213 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2214
cad59032
PE
2215 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2216 it.
2217
c339dc2e
PE
2218 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2219 so that we aren't warned about unused symbols.
2220
91a3e27b
PE
2221 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2222
399c71d3 2223 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 2224
8ffc96f5
PE
2225 * xfns.c (x_real_positions): Mark locals as initialized.
2226
eef9bc79
PE
2227 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2228
098db9dd
PE
2229 * xterm.c: Fix problems found by static analysis with other toolkits.
2230 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
2231 (x_dispatch_event): Declare static if USE_GTK, and
2232 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 2233 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 2234 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
2235 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2236 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 2237
eb18f6cc
PE
2238 * xmenu.c (menu_help_callback): Pointer type fixes.
2239 Use const pointers when pointing at readonly data. Avoid pointer
2240 signedness clashes.
2241 (FALSE): Remove unused macro.
2242 (update_frame_menubar): Remove unused decl.
2243
1fe72bf8
PE
2244 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2245
60d9e1db
PE
2246 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2247 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2248 (single_menu_item): Rename local to avoid shadowing.
2249
39261c26
PE
2250 * keyboard.c (make_lispy_event): Remove unused local var.
2251
018c5e19
PE
2252 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2253 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2254
63d2b86e
PE
2255 * bitmaps: Change bitmaps from unsigned char back to the X11
2256 compatible char. Avoid the old compiler warnings about
2257 out-of-range initializers by using, for example, '\xab' rather
2258 than 0xab.
2259
aefd87e1
PE
2260 * xgselect.c (xgselect_initialize): Check vs interface
2261 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2262
bf501fb9
PE
2263 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2264
e9829fdf
PE
2265 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2266 to read-only memory.
2267
1086c095
PE
2268 * fns.c (vector): Remove; this old hack is no longer needed.
2269
2baccd04 2270 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 2271 Remove unused var.
dde42981 2272 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 2273
72391843 2274 * xrdb.c (x_load_resources): Omit unused local.
3565b346 2275
436c16df 2276 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 2277 (x_window): Rename locals to avoid shadowing.
dc5ddd85 2278 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 2279
92bb796d 2280 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 2281 (x_term_init): Remove local to avoid shadowing.
92bb796d 2282
764430a3 2283 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
2284
2285 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2286 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2287
d1dfb56c
EZ
22882011-04-16 Eli Zaretskii <eliz@gnu.org>
2289
c4354cb4
EZ
2290 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2291
d1dfb56c
EZ
2292 Fix regex.c, syntax.c and friends for buffers > 2GB.
2293 * syntax.h (struct gl_state_s): Declare character position members
2294 EMACS_INT.
2295
2296 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2297
04f2d78b
CB
2298 * textprop.c (verify_interval_modification, interval_of):
2299 Declare arguments EMACS_INT.
d1dfb56c
EZ
2300
2301 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2302 EMACS_INT.
2303
2304 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2305
2306 * indent.c (Fvertical_motion): Local variable it_start is now
2307 EMACS_INT.
2308
2309 * regex.c (re_match, re_match_2, re_match_2_internal)
2310 (bcmp_translate, regcomp, regexec, print_double_string)
2311 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2312 (re_compile_pattern, re_exec): Declare arguments and local
2313 variables `size_t' and `ssize_t' and return values `regoff_t', as
2314 appropriate.
2315 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2316 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2317 <compile_stack_type>: `size' and `avail' are now `size_t'.
2318
2319 * regex.h <regoff_t>: Use ssize_t, not int.
2320 (re_search, re_search_2, re_match, re_match_2): Arguments that
2321 specify buffer/string position and length are now ssize_t and
2322 size_t. Return type is regoff_t.
2323
613052cd
BK
23242011-04-16 Ben Key <bkey76@gmail.com>
2325
2326 * nsfont.m: Fixed bugs in ns_get_family and
2327 ns_descriptor_to_entity that were caused by using free to
2328 deallocate memory blocks that were allocated by xmalloc (via
2329 xstrdup). This caused Emacs to crash when compiled with
2330 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2331 --enable-checking=xmallocoverrun). xfree is now used to
2332 deallocate these memory blocks.
2333
4170f62f 23342011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 2335
71b41406
PE
2336 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2337
9587a89d
PE
2338 emacs_write: Accept and return EMACS_INT for sizes.
2339 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2340 et seq.
2341 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2342 Accept and return EMACS_INT.
2343 (emacs_gnutls_write): Return the number of bytes written on
2344 partial writes.
2345 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
2346 (emacs_read, emacs_write): Remove check for negative size, as the
2347 Emacs source code has been audited now.
9587a89d
PE
2348 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2349 (emacs_read, emacs_write): Use it.
273a5f82
PE
2350 * process.c (send_process): Adjust to the new signatures of
2351 emacs_write and emacs_gnutls_write. Do not attempt to store
2352 a byte offset into an 'int'; it might overflow.
9587a89d 2353 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 2354
3e047f51
PE
2355 * sound.c: Don't assume sizes fit in 'int'.
2356 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 2357 Return EMACS_INT, not int.
3e047f51 2358 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
2359 Accept EMACS_INT, not int.
2360 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
2361 record read return values.
2362
cc39a9db
BK
23632011-04-15 Ben Key <bkey76@gmail.com>
2364
c9d0ec6d
JB
2365 * keyboard.c (Qundefined): Don't declare static since it is used
2366 in nsfns.m.
2367 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2368 static since they are used in nsfont.m.
cc39a9db 2369
6c60eb9f
SM
23702011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2371
2372 * process.c (Qprocessp): Don't declare static.
2373 * lisp.h (Qprocessp): Declare again.
2374
7990b61a
JB
23752011-04-15 Juanma Barranquero <lekktu@gmail.com>
2376
2377 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2378
5d4cb038
PE
23792011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2380
8bd7b830 2381 Improve C-level modularity by making more things 'static'.
cd64ea1d 2382
e3b27b31
PE
2383 Don't publish debugger-only interfaces to other modules.
2384 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2385 (verify_bytepos, count_markers): Move decls to the only modules
2386 that need them.
2387 * region-cache.h (pp_cache): Likewise.
2388 * window.h (check_all_windows): Likewise.
2389 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2390
5d4cb038
PE
2391 * sysdep.c (croak): Now static, if
2392 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2393 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
2394
2395 * alloc.c (refill_memory_reserve): Now static if
2396 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2397 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 2398
e87b6180
PE
2399 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2400 Define only if USE_LUCID.
2401
ac64929e
PE
2402 * xrdb.c (x_customization_string, x_rm_string): Now static.
2403
6f37259d
PE
2404 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2405 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2406
1683e3ab
PE
2407 * xdisp.c (draw_row_with_mouse_face): Now static.
2408 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2409
de9c2632
PE
2410 * window.h (check_all_windows): Mark externally visible.
2411
2b96acb7
PE
2412 * window.c (window_deletion_count): Now static.
2413
2414 * undo.c: Make symbols static if they're not exported.
2415 (last_undo_buffer, last_boundary_position, pending_boundary):
2416 Now static.
2417
50436f33
PE
2418 * textprop.c (interval_insert_behind_hooks): Now static.
2419 (interval_insert_in_front_hooks): Likewise.
2420
64520e5c
PE
2421 * term.c: Make symbols static if they're not exported.
2422 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2423 (max_frame_lines, tty_set_terminal_modes):
2424 (tty_reset_terminal_modes, tty_turn_off_highlight):
2425 (get_tty_terminal): Now static.
2426 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2427 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 2428 HAVE_WINDOW_SYSTEM.
64520e5c
PE
2429 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2430 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2431
1fa53021
PE
2432 * sysdep.c: Make symbols static if they're not exported.
2433 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2434 Now static.
2435 (sigprocmask_set, full_mask): Remove; unused.
2436 (wait_debugging): Mark as visible.
2437 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2438 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2439
d4b43b22
PE
2440 * syntax.c (syntax_temp): Define only if !__GNUC__.
2441
b7c513d0
PE
2442 * sound.c (current_sound_device, current_sound): Now static.
2443
989b29ad
PE
2444 * search.c (searchbufs, searchbuf_head): Now static.
2445
13a55a78
PE
2446 * scroll.c (scroll_cost): Remove; unused.
2447 * dispextern.h (scroll_cost): Remove decl.
2448
de68a1fc
PE
2449 * region-cache.h (pp_cache): Mark as externally visible.
2450
40ccffa6
PE
2451 * process.c: Make symbols static if they're not exported.
2452 (process_tick, update_tick, create_process, chan_process):
2453 (Vprocess_alist, proc_buffered_char, datagram_access):
2454 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2455 (deactivate_process): Mark defn as static, as well as decl.
2456 * lisp.h (create_process): Remove decl.
2457 * process.h (chan_process, Vprocess_alist): Remove decls.
2458
ad64fc97
PE
2459 * print.c: Make symbols static if they're not exported.
2460 (print_depth, new_backquote_output, being_printed, print_buffer):
2461 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2462 (print_interval, print_number_index, initial_stderr_stream):
2463 Now static.
2464 * lisp.h (Fprinc): Remove decl.
2465 (debug_output_compilation_hack): Mark as externally visible.
2466
adddb265
PE
2467 * sysdep.c (croak): Move decl from here to syssignal.h.
2468 * syssignal.h (croak): Put it here, so the API can be checked when
2469 'croak' is called from dissociate_if_controlling_tty.
2470
1717ede2
PE
2471 * minibuf.c: Make symbols static if they're not exported.
2472 (minibuf_save_list, choose_minibuf_frame): Now static.
2473 * lisp.h (choose_minibuf_frame): Remove decl.
2474
fa5fb2bc
PE
2475 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2476
1e3890d1
PE
2477 * lread.c: Make symbols static if they're not exported.
2478 (read_objects, initial_obarray, oblookup_last_bucket_number):
2479 Now static.
2480 (make_symbol): Remove; unused.
2481 * lisp.h (initial_obarray, make_symbol): Remove decls.
2482
8a1414fa
PE
2483 * keyboard.c: Make symbols static if they're not exported.
2484 (single_kboard, recent_keys_index, total_keys, recent_keys):
2485 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2486 (this_single_command_key_start, echoing, last_auto_save):
2487 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2488 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2489 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2490 (Vlispy_mouse_stem, double_click_count):
2491 Now static.
2492 (force_auto_save_soon): Define only if SIGDANGER.
2493 (ignore_mouse_drag_p): Now static if
2494 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2495 (print_help): Remove; unused.
2496 (stop_character, last_timer_event): Mark as externally visible.
2497 * keyboard.h (ignore_mouse_drag_p): Declare only if
2498 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2499 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2500 * lisp.h (echoing): Remove decl.
2501 (force_auto_save_soon): Declare only if SIGDANGER.
2502 * xdisp.c (redisplay_window): Simplify code, to make it more
2503 obvious that ignore_mouse_drag_p is not accessed if !defined
2504 USE_GTK && !defined HAVE_NS.
2505
93ea6e8f
PE
2506 * intervals.c: Make symbols static if they're not exported.
2507 (merge_properties_sticky, merge_interval_right, delete_interval):
2508 Now static.
2509 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2510
77382fcc
PE
2511 * insdel.c: Make symbols static if they're not exported.
2512 However, leave prepare_to_modify_buffer alone. It's never
2513 called from outside this function, but that appears to be a bug.
2514 (combine_after_change_list, combine_after_change_buffer):
4889fc82 2515 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
2516 (adjust_after_replace_noundo): Remove; unused.
2517 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 2518 (signal_before_change): Remove decls.
77382fcc 2519
9306c32e
PE
2520 * indent.c (val_compute_motion, val_vmotion): Now static.
2521
cd44d2eb
PE
2522 * image.c: Make symbols static if they're not exported.
2523 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2524 if USE_GTK.
2525 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2526 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2527
ad9a7a06
PE
2528 * fringe.c (standard_bitmaps): Now static.
2529 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2530
81626931
PE
2531 * frame.c: Make symbols static if they're not exported.
2532 (x_report_frame_params, make_terminal_frame): Now static.
2533 (get_frame_param): Now static, unless HAVE_NS.
2534 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2535 (x_get_resource_string): Remove; not used.
2536 * frame.h (make_terminal_frame, x_report_frame_params):
2537 (x_get_resource_string); Remove decls.
2538 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2539 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2540
239f9db9
PE
2541 * font.c, fontset.c: Make symbols static if they're not exported.
2542 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2543 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2544 * font.c (font_close_object): Now static.
2545 * font.h (font_close_object): Remove.
2546 * fontset.c (FONTSET_OBJLIST): Remove.
2547 (free_realized_fontset) #if-0 the body, which does nothing.
2548 (face_suitable_for_char_p): #if-0, as it's never called.
2549 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
2550 * xfaces.c (face_at_string_position):
2551 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
2552 since 0 is always ASCII.
2553
dfcf3579
PE
2554 * fns.c (weak_hash_tables): Now static.
2555
5045092b
PE
2556 * fileio.c: Make symbols static if they're not exported.
2557 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2558 (Vwrite_region_annotation_buffers): Now static.
2559
57a96f5c
PE
2560 * eval.c: Make symbols static if they're not exported.
2561 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2562 * lisp.h (backtrace_list): Remove decl.
2563
35f08c38
PE
2564 * emacs.c: Make symbols static if they're not exported.
2565 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2566 (fatal_error_code, fatal_error_signal_hook, standard_args):
2567 Now static.
2568 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2569 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2570 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2571 * lisp.h (fatal_error_signal_hook): Remove decl.
2572 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2573
f44bd759
PE
2574 * editfns.c: Move a (normally-unused) function to its only use.
2575 * editfns.c, lisp.h (get_operating_system_release): Remove.
2576 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2577 worth the hassle of breaking this out.
2578
b532497d
PE
2579 * xterm.c: Make symbols static if they're not exported.
2580 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2581 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2582 (x_destroy_window, x_delete_display):
2583 Now static.
2584 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2585 (x_mouse_leave): Remove; unused.
2586 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2587 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2588 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2589 Remove decls.
2590 (x_mouse_leave): Declare only if WINDOWSNT.
2591 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2592 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2593 USE_X_TOOLKIT.
2594
1675728f
PE
2595 * ftxfont.c: Make symbols static if they're not exported.
2596 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2597 HAVE_FREETYPE.
2598 * font.h (ftxfont_driver): Likewise.
2599
e4cebfca
PE
2600 * xfns.c: Make symbols static if they're not exported.
2601 (x_last_font_name, x_display_info_for_name):
2602 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2603 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2604 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2605 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2606 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2607 (last_show_tip_args): Now static.
2608 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2609 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2610 (x_screen_planes): Remove; unused.
2611 * dispextern.h (x_screen_planes): Remove decl.
2612
5bf46f05
PE
2613 * dispnew.c: Make symbols static if they're not exported.
2614 * dispextern.h (redraw_garbaged_frames, scrolling):
2615 (increment_row_positions): Remove.
2616 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2617 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2618 Now static.
2619 (redraw_garbaged_frames): Remove; unused.
2620
435f4c28
PE
2621 * xfaces.c: Make symbols static if they're not exported.
2622 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2623 Remove decls.
2624 * xterm.h (defined_color): Remove decls.
2625 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2626 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2627 (menu_face_changed_default, defined_color, free_realized_face):
2628 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2629 (ascii_face_of_lisp_face): Remove; unused.
2630
8524aef3
PE
2631 * xdisp.c: Make symbols static if they're not exported.
2632 * dispextern.h (scratch_glyph_row, window_box_edges):
2633 (glyph_to_pixel_coords, set_cursor_from_row):
2634 (get_next_display_element, set_iterator_to_next):
2635 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2636 (show_mouse_face): Remove decls
2637 * frame.h (message_buf_print): Likewise.
2638 * lisp.h (pop_message, set_message, check_point_in_composition):
2639 Likewise.
2640 * xterm.h (set_vertical_scroll_bar): Likewise.
2641 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2642 (message_buf_print, scratch_glyph_row, displayed_buffer):
2643 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2644 (get_next_display_element, show_mouse_face, window_box_edges):
2645 (frame_to_window_pixel_xy, check_point_in_composition):
2646 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2647 (glyph_to_pixel_coords): Remove; unused.
2648
16390cd2
PE
2649 * dired.c (file_name_completion): Now static.
2650
2651 * dbusbind.c (xd_in_read_queued_messages): Now static.
2652
a25f4dfa
PE
2653 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2654 * data.c (circular_list_error): Remove.
2655
14a9c8df
PE
2656 * commands.h (last_point_position, last_point_position_buffer):
2657 (last_point_position_window): Remove decls.
2658 * keyboard.c: Make these variables static.
2659
04f2d78b
CB
2660 * coding.h (coding, code_convert_region, encode_coding_gap):
2661 Remove decls.
74ab6df5
PE
2662 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2663 (iso_code_class, detect_coding, code_convert_region): Now static.
2664 (encode_coding_gap): Remove; unused.
2665
38dfbee1
PE
2666 * chartab.c (chartab_chars, chartab_bits): Now static.
2667
a2cb4e63
PE
2668 * charset.h (charset_iso_8859_1): Remove decl.
2669 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2670 Now static.
2671
127198fd
PE
2672 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2673 * ccl.c (Vccl_program_table): Now static.
2674 (check_ccl_update): Remove; unused.
2675
d85b608f
PE
2676 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2677 * category.h: ... from here.
2678 * category.c (check_category_table, set_category_set): Now static.
2679
31cd66f3
PE
2680 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2681 * lisp.h: Remove these decls.
2682
c358e587
PE
2683 * buffer.c (buffer_count): Remove unused var.
2684
e78aecca
PE
2685 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2686 so that it's not optimized away.
2687 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2688 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2689 exported only to the debugger.
2690
e192d7d3 2691 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 2692 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 2693
92470028
PE
2694 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2695 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2696 was inaccessible from Lisp.
2697 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2698 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2699
244ed907
PE
2700 alloc.c: Import and export fewer symbols, and remove unused items.
2701 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2702 is defined.
2703 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2704 it's not optimized away by whole-program optimization.
2705 (message_enable_multibyte, free_misc): Remove.
2706 (catchlist, handlerlist, mark_backtrace):
2707 Declare only if BYTE_MARK_STACK.
2708 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2709 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2710 (message_enable_multibyte): Remove decl.
2711 (free_misc, interval_free_list, float_block, float_block_index):
2712 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2713 (cons_free_list, last_marked_index):
2714 Now static.
2715 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2716 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2717 (mark_backtrace): Define only if BYTE_MARK_STACK.
2718 * xdisp.c (message_enable_multibyte): Now static.
2719
61c2b50e 2720 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
2721 This makes it easier for human readers (and static analyzers)
2722 to see whether these variables are used from other modules.
2723 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2724 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2725 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2726 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2727 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2728 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2729 * xmenu.c, xselect.c:
2730 Declare Q* vars static if they are not used in other modules.
2731 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2732 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2733 Remove decls of unexported vars.
2734 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2735
95c82688
PE
2736 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2737
16a97296
PE
2738 Make Emacs functions such as Fatom 'static' by default.
2739 This makes it easier for human readers (and static analyzers)
2740 to see whether these functions can be called from other modules.
2741 DEFUN now defines a static function. To make the function external
2742 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
2743 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2744 (Finit_image_library):
16a97296
PE
2745 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2746 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2747 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2748 Remove decls, since these functions are now static.
2749 (Funintern, Fget_internal_run_time): New decls, since these functions
2750 were already external.
95c82688 2751
16a97296
PE
2752 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2753 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2754 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2755 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2756 * keyboard.c, keymap.c, lread.c:
2757 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2758 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2759 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2760 Mark functions with DEFUE instead of DEFUN,
2761 if they are used in other modules.
2762 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2763 decls for now-static functions.
2764 * buffer.h (Fdelete_overlay): Remove decl.
2765 * callproc.c (Fgetenv_internal): Mark as internal.
2766 * composite.c (Fremove_list_of_text_properties): Remove decl.
2767 (Fcomposition_get_gstring): New forward static decl.
2768 * composite.h (Fcomposite_get_gstring): Remove decl.
2769 * dired.c (Ffile_attributes): New forward static decl.
2770 * doc.c (Fdocumntation_property): New forward static decl.
2771 * eval.c (Ffetch_bytecode): New forward static decl.
2772 (Funintern): Remove extern decl; now in .h file where it belongs.
2773 * fileio.c (Fmake_symbolic_link): New forward static decl.
2774 * image.c (Finit_image_library): New forward static decl.
2775 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2776 * intervals.h (Fprevious_property_change):
2777 (Fremove_list_of_text_properties): Remove decls.
2778 * keyboard.c (Fthis_command_keys): Remove decl.
2779 (Fcommand_execute): New forward static decl.
2780 * keymap.c (Flookup_key): New forward static decl.
2781 (Fcopy_keymap): Now static.
2782 * keymap.h (Flookup_key): Remove decl.
2783 * process.c (Fget_process): New forward static decl.
2784 (Fprocess_datagram_address): Mark as internal.
2785 * syntax.c (Fsyntax_table_p): New forward static decl.
2786 (skip_chars): Remove duplicate decl.
2787 * textprop.c (Fprevious_property_change): New forward static decl.
2788 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2789 Now internal.
2790 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2791 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2792
785bbd42
PE
2793 * editfns.c (Fformat): Remove unreachable code.
2794
8b913b57
AS
27952011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2796
2797 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2798 change. (Bug#8496)
2799
a6744a35
EZ
28002011-04-13 Eli Zaretskii <eliz@gnu.org>
2801
2802 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2803 when at ZV. (Bug#8487)
2804
e7974947
AS
28052011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2806
baad03f0
AS
2807 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2808 (Bug#8437)
2809 * keyboard.c (parse_tool_bar_item): Likewise.
2810 * sound.c (sound_cleanup, alsa_close): Likewise.
2811 * termcap.c (tgetent): Likewise.
2812 * xfns.c (x_default_font_parameter): Likewise.
2813 * xsettings.c (read_and_apply_settings): Likewise.
2814
e7974947
AS
2815 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2816 (overrun_check_free): Protoize.
2817
28272684
PE
28182011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2819
2820 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2821 since callers should never pass a negative size.
2822 Change the signature to match that of plain 'read' and 'write'; see
2823 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2824 * lisp.h: Update prototypes of emacs_write and emacs_read.
2825
11997c76
EZ
28262011-04-11 Eli Zaretskii <eliz@gnu.org>
2827
2828 * xdisp.c (redisplay_window): Don't try to determine the character
2829 position of the scroll margin if the window start point w->startp
e896f03c 2830 is outside the buffer's accessible region. (Bug#8468)
11997c76 2831
8a2cbd72
EZ
28322011-04-10 Eli Zaretskii <eliz@gnu.org>
2833
2834 Fix write-region and its subroutines for buffers > 2GB.
2835 * fileio.c (a_write, e_write): Modify declaration of arguments and
2836 local variables to support buffers larger than 2GB.
2837 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2838
2839 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2840 argument, local variables, and return value.
2841
2842 * lisp.h: Update prototypes of emacs_write and emacs_read.
2843
2844 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2845
4073e537 28462011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 2847
1ebfdcb6
PE
2848 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2849
b2ded58d
PE
2850 Fix more problems found by GCC 4.6.0's static checks.
2851
7d66342c
PE
2852 * xdisp.c (vmessage): Use a better test for character truncation.
2853
bbf47d44
PE
2854 * charset.c (load_charset_map): <, not <=, for optimization,
2855 and to avoid potential problems with integer overflow.
9248994d 2856 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 2857 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 2858 * editfns.c (Fformat): Likewise.
1e69125e 2859 * syntax.c (skip_chars): Likewise.
3befa583 2860
e3019616
PE
2861 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2862 This also lets GCC 4.6.0 generate slightly better loop code.
2863
becfa255
PE
2864 * callint.c (Fcall_interactively): <, not <=, for optimization.
2865 (Fcall_interactively): Count the number of arguments produced,
2866 not the number of arguments given. This is simpler and lets GCC
2867 4.6.0 generate slightly better code.
2868
dae0cd48
PE
2869 * ftfont.c: Distingish more carefully between FcChar8 and char.
2870 The previous code passed unsigned char * to a functions like
2871 strlen and xstrcasecmp that expect char *, which does not
2872 conform to the C standard.
2873 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2874 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2875 char * when the C standard requires it.
2876
76032d70
PE
2877 * keyboard.c (read_char): Remove unused var.
2878
eb3f1cc8
PE
2879 * eval.c: Port to Windows vsnprintf (Bug#8435).
2880 Include <limits.h>.
2881 (SIZE_MAX): Define if the headers do not.
2882 (verror): Do not give up if vsnprintf returns a negative count.
2883 Instead, grow the buffer. This ports to Windows vsnprintf, which
2884 does not conform to C99. Problem reported by Eli Zaretskii.
2885 Also, simplify the allocation scheme, by avoiding the need for
2886 calling realloc, and removing the ALLOCATED variable.
2887
70476b54
PE
2888 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2889
12020a9e
PE
2890 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2891 But keep the doprint source code for now, as we might revamp it
2892 and use it again (Bug#8435).
ea6c7ae6
PE
2893 * lisp.h (doprnt): Remove.
2894 * Makefile.in (base_obj): Remove doprnt.o.
2895 * deps.mk (doprnt.o): Remove.
2896
5fdb398c
PE
2897 error: Print 32- and 64-bit integers portably (Bug#8435).
2898 Without this change, on typical 64-bit hosts error ("...%d...", N)
2899 was used to print both 32- and 64-bit integers N, which relied on
2900 undefined behavior.
2901 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2902 New macro.
2903 * lisp.h (error, verror): Mark as printf-like functions.
2904 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2905 Report overflow in size calculations when allocating printf buffer.
2906 Do not truncate output string at its first null byte.
2907 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2908 Truncate the output at a character boundary, since vsnprintf does not
2909 do that.
2910 * charset.c (check_iso_charset_parameter): Convert internal
2911 character to string before calling 'error', since %c now has the
2912 printf meaning.
2913 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2914 overflow when computing char to be passed to 'error'. Do not
2915 pass Lisp_Object to 'error'; pass the integer instead.
2916 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2917 formatted with plain %d.
2918
b189fa66
PE
2919 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2920
bff87ef0
PE
2921 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2922
7e2cac20
PE
2923 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2924
ce4d90b5
PE
2925 * xterm.c (x_catch_errors): Remove duplicate declaration.
2926
266c9547
PE
2927 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2928
79c49ad2
PE
2929 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2930
368f4090
JM
29312011-04-10 Jim Meyering <meyering@redhat.com>
2932
2933 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2934 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2935 return ssize_t not "int", and use size_t as the buffer length.
2936 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2937 * gnutls.h: Update declarations.
2938 * process.c (read_process_output): Use ssize_t, to match.
2939 (send_process): Likewise.
2940
a32d4040
CY
29412011-04-09 Chong Yidong <cyd@stupidchicken.com>
2942
2943 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2944
8546720e 29452011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 2946
04f2d78b
CB
2947 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
2948 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 2949
8546720e
GM
2950 * xterm.c (handle_one_xevent):
2951 * xmenu.c (create_and_show_popup_menu):
2952 * xselect.c (x_decline_selection_request)
2953 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 2954
0a2f5c1a 29552011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
2956
2957 Fix some uses of `int' instead of EMACS_INT.
2958 * search.c (string_match_1, fast_string_match)
2959 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2960 (scan_buffer, find_next_newline_no_quit)
2961 (find_before_next_newline, search_command, Freplace_match)
2962 (Fmatch_data): Make some `int' variables be EMACS_INT.
2963
2964 * xdisp.c (display_count_lines): 3rd argument and return value now
2965 EMACS_INT. All callers changed.
2966 (pint2hrstr): Last argument is now EMACS_INT.
2967
2968 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2969 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2970 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2971 (decode_coding_utf_16, decode_coding_emacs_mule)
2972 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2973 (decode_coding_ccl, decode_coding_charset)
2974 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2975 (decode_coding_iso_2022, decode_coding_emacs_mule)
2976 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2977 <char_offset, last_offset>: Declare EMACS_INT.
2978 (encode_coding_utf_8, encode_coding_utf_16)
2979 (encode_coding_emacs_mule, encode_invocation_designation)
2980 (encode_designation_at_bol, encode_coding_iso_2022)
2981 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2982 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2983 Declare EMACS_INT.
2984 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2985 (encode_invocation_designation): Last argument P_NCHARS is now
2986 EMACS_INT.
2987 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2988 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2989
2990 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2991 All users changed.
2992
2993 * ccl.c (Fccl_execute_on_string): Declare some variables
2994 EMACS_INT.
2995
8546720e 29962011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
2997
2998 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2999
4e19a977
CS
30002011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3001
3002 * process.c (Fformat_network_address): Doc fix.
3003
87302331
R
30042011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3005
3006 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3007
cbb59342
CY
30082011-04-08 Chong Yidong <cyd@stupidchicken.com>
3009
3010 * keyboard.c (read_char): Call Lisp function help-form-show,
3011 instead of using internal_with_output_to_temp_buffer.
3012 (Qhelp_form_show): New var.
e0d38eeb 3013 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
3014
3015 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3016
3017 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3018
e67a13ab
CY
30192011-04-06 Chong Yidong <cyd@stupidchicken.com>
3020
04f2d78b
CB
3021 * process.c (Flist_processes): Remove to Lisp.
3022 (list_processes_1): Delete.
e67a13ab 3023
973f782d
EZ
30242011-04-06 Eli Zaretskii <eliz@gnu.org>
3025
7c106b1e
EZ
3026 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3027
973f782d
EZ
3028 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3029
41cf7d1a 30302011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 3031
ca23cc88
PE
3032 Fix more problems found by GCC 4.6.0's static checks.
3033
f390e2d5
PE
3034 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3035
42eea0d0
PE
3036 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3037
b69769da 3038 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 3039
f9541e84
PE
3040 * xdisp.c (vmessage): Mark as a printf-like function.
3041
13841b55
PE
3042 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3043
c136c10f
PE
3044 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3045
5e2d4a30
PE
3046 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3047 printf-like functions.
3048 (tiff_load): Add casts to remove these marks before passing them
3049 to system-supplied API.
3050
583f48b9
PE
3051 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3052
b25d760e
PE
3053 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3054 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
3055 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3056 directly, rather than having caller test rule sign. This avoids
3057 some unnecessary tests.
3058 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3059 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3060 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 3061
bc7b6697 3062 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 3063 (xfont_open): Avoid unnecessary tests.
bc7b6697 3064
27ccc379
PE
3065 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3066
dcd5c89a
PE
3067 * composite.h, composite.c (composition_gstring_put_cache):
3068 Use EMACS_INT, not int, for length.
3069
b13a45c6
PE
3070 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3071 breaking out part of COMPOSITION_DECODE_RULE.
3072 (COMPOSITION_DECODE_RULE): Use it.
3073 * composite.c (get_composition_id): Remove unused local vars,
3074 by using the new macro.
3075
1e792e4d
PE
3076 * textprop.c (set_text_properties_1): Change while to do-while,
3077 since the condition is always true at first.
3078
dc6c6455 3079 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
3080 (interval_deletion_adjustment): Return unsigned value.
3081 All uses changed.
dc6c6455 3082
aba7731a
PE
3083 * process.c (list_processes_1, create_pty, read_process_output):
3084 (exec_sentinel): Remove vars that were set but not used.
afd4052b 3085 (create_pty): Remove unnecessary "volatile"s.
bc57d757 3086 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 3087 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 3088 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 3089
fdfc4bf3
PE
3090 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3091
fca8fe46 3092 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 3093 (update_syntax_table): Use unsigned instead of int.
fca8fe46 3094
06a0259a 3095 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 3096 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 3097 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 3098
e7b9e80f
PE
3099 * print.c (print_error_message): Avoid int overflow.
3100
56201685
PE
3101 * font.c (font_list_entities): Redo for clarity,
3102 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3103
78834453 3104 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 3105 (font_score): Avoid potential overflow in diff calculation.
78834453 3106
0bc0b309 3107 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 3108 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 3109
e610eaca
PE
3110 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3111
b895abce
PE
3112 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3113 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3114 can always succeed if overflow has undefined behavior.
3115
1f1d9321 3116 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 3117 (wordify): Omit three unnecessary tests.
1f1d9321 3118
c59478bc
PE
3119 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3120 All callers changed. This avoids the need for an unused var.
3121
79b73827
PE
3122 * casefiddle.c (casify_region): Remove var that is set but not used.
3123
a4db5dfe
PE
3124 * dired.c (file_name_completion): Remove var that is set but not used.
3125
43aae36e
PE
3126 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3127
2a47c44d 3128 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 3129 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 3130
a37c69bf
PE
3131 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3132 Check for integer overflow on size calculations.
3133
328ab8e7
PE
3134 * buffer.c (Fprevious_overlay_change): Remove var that is set
3135 but not used.
3136
e5a2a5cb
PE
3137 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3138 Remove vars that are set but not used.
8d84a6eb 3139 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 3140 (timer_check_2): Mark vars as initialized.
e5a2a5cb 3141
a60e5f68
PE
3142 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3143
f661cb61 3144 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 3145 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 3146
f0397f5a
PE
3147 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3148 that are set but not used.
3149
8664db06 3150 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 3151 if XCreateBitmapFromData fails (Bug#8410).
8664db06 3152
6abdaa4a
PE
3153 * xselect.c (x_get_local_selection, x_handle_property_notify):
3154 Remove vars that are set but not used.
3155
0ce7538d 3156 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 3157 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 3158
9ae848fc
PE
3159 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3160 Remove var that is set but not used.
0b918413
PE
3161 (scroll_bar_windows_size): Now size_t, not int.
3162 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3163 Check for overflow.
9ae848fc 3164
a5a62657
PE
3165 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3166 (map_tty_color) [!defined MSDOS]: Likewise.
3167
5c5cdd39
PE
3168 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3169
66ebf983
PE
3170 * coding.c: Remove vars that are set but not used.
3171 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3172 All callers changed.
3173 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3174 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3175 (decode_coding_charset): Remove vars that are set but not used.
3176
1be4d761
PE
3177 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3178 that is set but not used.
3179
47553fa8
PE
3180 * print.c (print_object): Remove var that is set but not used.
3181
1f7196bf 3182 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
3183 The gnulib version avoids calling malloc in the usual case,
3184 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3185 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3186 * filelock.c (current_lock_owner): Likewise.
3187 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3188 * sysdep.c: Include allocator.h, careadlinkat.h.
3189 (emacs_no_realloc_allocator): New static constant.
3190 (emacs_readlink): New function.
fdb61804
PE
3191 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3192 ../lib/careadlinkat.h.
d1fdcab7 3193
f84c17c7
SM
31942011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3195
3196 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3197 first non-nil return value).
3198
ef3862ad
JD
31992011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3200
3201 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3202 if not defined (Bug#8403).
3203
376a7006
JB
32042011-04-02 Juanma Barranquero <lekktu@gmail.com>
3205
3206 * xdisp.c (display_count_lines): Remove parameter `start',
3207 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3208 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3209 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3210 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3211 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3212 and thereabouts. All callers changed.
3213 (get_per_char_metric): Remove parameter `f', unused since
3214 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3215
6ca3801d
JM
32162011-04-02 Jim Meyering <meyering@redhat.com>
3217
3218 do not dereference NULL upon failed strdup
3219 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3220 (ns_get_family): Likewise.
3221
d8e2b5ba
JB
32222011-04-02 Juanma Barranquero <lekktu@gmail.com>
3223
3224 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3225
8c74fcbd
JD
32262011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3227
3228 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3229 later (Bug#8403).
3230
7200d79c
SM
32312011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3232
03408648 3233 Add lexical binding.
7200d79c 3234
03408648
SM
3235 * window.c (Ftemp_output_buffer_show): New fun.
3236 (Fsave_window_excursion):
3237 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3238
3239 * lread.c (lisp_file_lexically_bound_p): New function.
3240 (Fload): Bind Qlexical_binding.
3241 (readevalloop): Remove `evalfun' arg.
3242 Bind Qinternal_interpreter_environment.
3243 (Feval_buffer): Bind Qlexical_binding.
3244 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3245 Mark as dynamic.
3246 (syms_of_lread): Declare `lexical-binding'.
3247
3248 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3249
3250 * keyboard.c (eval_dyn): New fun.
3251 (menu_item_eval_property): Use it.
ca105506
SM
3252
3253 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 3254
03408648
SM
3255 * fns.c (concat, mapcar1): Accept byte-code-functions.
3256
3257 * eval.c (Fsetq): Handle lexical vars.
3258 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3259 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3260 (FletX, Flet): Obey lexical binding.
3261 (Fcommandp): Handle closures.
3262 (Feval): New `lexical' arg.
3263 (eval_sub): New function extracted from Feval. Use it almost
3264 everywhere where Feval was used. Look up vars in lexical env.
3265 Handle closures.
3266 (Ffunctionp): Move from subr.el.
3267 (Ffuncall): Handle closures.
3268 (apply_lambda): Remove `eval_flags'.
3269 (funcall_lambda): Handle closures and new byte-code-functions.
3270 (Fspecial_variable_p): New function.
3271 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3272 but without exporting it to Lisp.
23aba0ea 3273
23aba0ea 3274 * doc.c (Fdocumentation, store_function_docstring):
03408648 3275 * data.c (Finteractive_form): Handle closures.
23aba0ea 3276
03408648
SM
3277 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3278 interactive spec.
ba83908c 3279
04f2d78b
CB
3280 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3281 New byte-codes.
03408648
SM
3282 (exec_byte_code): New function extracted from Fbyte_code to handle new
3283 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 3284
03408648 3285 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 3286
03408648 3287 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 3288
e2abce01
JB
32892011-03-31 Juanma Barranquero <lekktu@gmail.com>
3290
3291 * xdisp.c (redisplay_internal): Fix prototype.
3292
63696a73 32932011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 3294
63696a73 3295 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
3296 (try_scrolling): Use it when setting scroll_limit.
3297 Limit scrolling to 100 screen lines.
63696a73
EZ
3298 (redisplay_window): Even when falling back on "recentering",
3299 position point in the window according to scroll-conservatively,
3300 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3301
3302 (try_scrolling): When point is above the window, allow searching
3303 as far as scroll_max, or one screenful, to compute vertical
3304 distance from PT to the scroll margin position. This prevents
3305 try_scrolling from unnecessarily failing when
3306 scroll-conservatively is set to a value slightly larger than the
3307 window height. Clean up the case of PT below the margin at bottom
3308 of window: scroll_max can no longer be INT_MAX. When aggressive
3309 scrolling is in use, don't let point enter the opposite scroll
3310 margin as result of the scroll.
3311 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
3312 threshold of 100 lines for never-recentering scrolling.
3313
e4cc2dfc
JB
33142011-03-31 Juanma Barranquero <lekktu@gmail.com>
3315
3316 * dispextern.h (move_it_by_lines):
3317 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3318 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3319 (message_log_check_duplicate): Remove parameters `prev_bol' and
3320 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3321 (redisplay_internal): Remove parameter `preserve_echo_area',
3322 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3323
3324 * indent.c (Fvertical_motion):
3325 * window.c (window_scroll_pixel_based, Frecenter):
3326 Don't pass `need_y_p' to `move_it_by_lines'.
3327
1c470562
SM
33282011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3329
44f230aa
SM
3330 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3331 steal a few bits to be more compact.
3332 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3333 Remove unneeded casts.
3334
1c470562
SM
3335 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3336
888adce9
ZK
33372011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3338
3339 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3340 binding" message (bug#7967).
3341
f838ed7b
PE
33422011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3343
77861b95
PE
3344 Fix more problems found by GCC 4.6.0's static checks.
3345
de6dbc14
PE
3346 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3347 Remove unused local var.
3348
f838ed7b
PE
3349 * editfns.c (Fmessage_box): Remove unused local var.
3350
792c7b2b
PE
3351 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3352 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3353 Omit unused local vars.
c499e557 3354 * window.c (shrink_windows): Omit unused local var.
b01a1c29 3355 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
3356 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3357 Omit unused local var.
3358
ba0165e1
PE
3359 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3360 Don't assume string length fits in int.
32ad8845 3361 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 3362 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 3363
3c59b4c9
PE
3364 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3365 instead of alloca (Bug#8344).
3366
a3eed478 3367 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 3368 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 3369
eb4d412d
PE
3370 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3371
1658b401
PE
3372 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3373 concerns.
3374
3375 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3376
3377 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 3378
9a2c6e05
PE
3379 * keyboard.c (syms_of_keyboard): Use the same style as later
3380 in this function when indexing through an array. This also
3381 works around GCC bug 48267.
3382
03d0a109
PE
3383 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3384
44f730c8
PE
3385 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3386
fe75f926
PE
3387 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3388 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3389
ffa8c828
PE
3390 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3391 This avoids undefined behavior on integer overflow, and is a bit
3392 more convenient anyway since it is compared to a size_t variable.
3393
c5101a77
PE
3394 Variadic C functions now count arguments with size_t, not int.
3395 This avoids an unnecessary limitation on 64-bit machines, which
3396 caused (substring ...) to crash on large vectors (Bug#8344).
3397 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3398 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 3399 All variadic functions and their callers changed accordingly.
c5101a77
PE
3400 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3401 * data.c (arith_driver, float_arith_driver): Likewise.
3402 * editfns.c (general_insert_function): Likewise.
3403 * eval.c (struct backtrace.nargs, interactive_p)
3404 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3405 (funcall_lambda, mark_backtrace): Likewise.
3406 * fns.c (concat): Likewise.
3407 * frame.c (x_set_frame_parameters): Likewise.
3408 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3409 0 if not found, not -1. All callers changed.
3410
dd3f25f7
PE
3411 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3412 (stack_copy_size): Now size_t, not int.
3413 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3414
461c2ab9
JB
34152011-03-28 Juanma Barranquero <lekktu@gmail.com>
3416
3417 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3418 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3419 All callers changed.
3420
3421 * lisp.h (multibyte_char_to_unibyte):
3422 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3423 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3424 * character.h (CHAR_TO_BYTE8):
3425 * cmds.c (internal_self_insert):
3426 * editfns.c (general_insert_function):
3427 * keymap.c (push_key_description):
3428 * search.c (Freplace_match):
3429 * xdisp.c (message_dolog, set_message_1): All callers changed.
3430
f6d62986
SM
34312011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3432
3433 * keyboard.c (safe_run_hook_funcall): New function.
3434 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3435 don't set the hook to nil, but remove the offending function instead.
3436 (Qcommand_hook_internal): Remove, unused.
3437 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3438 Vcommand_hook_internal.
3439
3440 * eval.c (enum run_hooks_condition): Remove.
3441 (funcall_nil, funcall_not): New functions.
3442 (run_hook_with_args): Call each function through a `funcall' argument.
3443 Remove `cond' argument, now redundant.
3444 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3445 (Frun_hook_with_args_until_failure): Adjust accordingly.
3446 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3447
1db5b1ad
JB
34482011-03-28 Juanma Barranquero <lekktu@gmail.com>
3449
3450 * dispextern.h (string_buffer_position): Remove declaration.
3451
3452 * print.c (strout): Remove parameter `multibyte', unused since
3453 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3454
3455 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3456 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3457 All callers changed.
3458
3459 * w32.c (_wsa_errlist): Use braces for struct initializers.
3460
3461 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3462 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3463 All callers changed.
3464 (string_buffer_position): Likewise. Also, make static (it's never
3465 used outside xdisp.c).
3466 (cursor_row_p): Remove parameter `w', unused since
3467 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3468 (decode_mode_spec): Remove parameter `precision', introduced during
3469 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3470 All callers changed.
3471
5ffb62aa
JD
34722011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3473
3474 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3475
461c2ab9 34762011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
3477
3478 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3479 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3480 (ns_update_auto_hide_menu_bar): New functions.
3481 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3482 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3483 ns_constrain_all_frames.
3484 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3485 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3486
5c380ffb
JD
34872011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3488
3489 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3490
9af30bdf
GM
34912011-03-27 Glenn Morris <rgm@gnu.org>
3492
3493 * syssignal.h: Replace RETSIGTYPE with void.
3494 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3495 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3496 Replace SIGTYPE with void everywhere.
3497 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3498 * s/template.h (SIGTYPE): Remove commented out definition.
3499
e2abce01
JB
35002011-03-26 Eli Zaretskii <eliz@gnu.org>
3501
3502 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3503 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3504
f868cd8a
JB
35052011-03-26 Juanma Barranquero <lekktu@gmail.com>
3506
59eb0929
JB
3507 * w32.c (read_unc_volume): Use parameter `henum', instead of
3508 global variable `wget_enum_handle'.
3509
3510 * keymap.c (describe_vector): Remove parameters `indices' and
3511 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3512 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3513
f868cd8a
JB
3514 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3515
3516 * keyboard.c (timer_check): Remove parameter `do_it_now',
3517 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3518 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3519 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3520
3521 * keyboard.c (read_char):
3522 * w32menu.c (w32_menu_display_help):
3523 * xmenu.c (show_help_event, menu_help_callback):
3524 Adjust calls to `show_help_echo'.
3525
3526 * gtkutil.c (xg_maybe_add_timer):
3527 * keyboard.c (readable_events):
3528 * process.c (wait_reading_process_output):
3529 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3530
3531 * insdel.c (adjust_markers_gap_motion):
3532 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3533 (gap_left, gap_right): Don't call it.
3534
2ecf6fdb
CY
35352011-03-25 Chong Yidong <cyd@stupidchicken.com>
3536
3537 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3538 incurred during fontification.
3539
6b1f9ba4
JB
35402011-03-25 Juanma Barranquero <lekktu@gmail.com>
3541
3542 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3543 (DEFVAR_PER_BUFFER): Don't pass it.
3544
3545 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3546 (scrolling_window): Don't pass it.
3547
0f4a96b5
JB
35482011-03-25 Juanma Barranquero <lekktu@gmail.com>
3549
3550 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3551
3552 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3553 and `suffix'.
3554 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3555 of variables specific to SELinux and computation of `encoded_absname'.
3556
3557 * image.c (XPutPixel): Remove unused variable `height'.
3558
3559 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3560
3561 * unexw32.c (get_section_info): Remove unused variable `section'.
3562
3563 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3564 (system_process_attributes): Remove unused variable `sess'.
3565 (sys_read): Remove unused variable `err'.
3566
3567 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3568 (w32_wnd_proc): Remove unused variable `isdead'.
3569 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3570 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3571 (x_create_tip_frame): Remove unused variable `tem'.
3572
3573 * w32inevt.c (w32_console_read_socket):
3574 Remove unused variable `no_events'.
3575
3576 * w32term.c (x_draw_composite_glyph_string_foreground):
3577 Remove unused variable `width'.
3578
1149507c
JB
35792011-03-24 Juanma Barranquero <lekktu@gmail.com>
3580
3581 * w32term.c (x_set_glyph_string_clipping):
3582 Don't pass uninitialized region to CombineRgn.
3583
9c88f339
JB
35842011-03-23 Juanma Barranquero <lekktu@gmail.com>
3585
3586 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3587 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3588 (Fx_close_connection): Remove unused variable `i'.
3589
3590 * w32font.c (w32font_draw): Return number of glyphs.
3591 (w32font_open_internal): Remove unused variable `i'.
3592 (w32font_driver): Add missing initializer.
3593
3594 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3595 (fill_in_menu): Remove unused variable `items_added'.
3596
3597 * w32term.c (last_mouse_press_frame): Remove static global variable.
3598 (w32_clip_to_row): Remove unused variable `f'.
3599 (x_delete_terminal): Remove unused variable `i'.
3600
3601 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3602 (NOTHING): Remove unused static global variable.
3603 (uniscribe_check_otf): Remove unused variable `table'.
3604 (uniscribe_font_driver): Add missing initializers.
3605
dee091a3
JD
36062011-03-23 Julien Danjou <julien@danjou.info>
3607
3608 * term.c (Fsuspend_tty, Fresume_tty):
3609 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3610 * window.c (temp_output_buffer_show):
3611 * insdel.c (signal_before_change):
3612 * frame.c (Fhandle_switch_frame):
3613 * fileio.c (Fdo_auto_save):
3614 * emacs.c (Fkill_emacs):
3615 * editfns.c (save_excursion_restore):
3616 * cmds.c (internal_self_insert):
3617 * callint.c (Fcall_interactively):
3618 * buffer.c (Fkill_all_local_variables):
3619 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3620 Use Frun_hooks.
0f4a96b5 3621 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
3622 unconditionnaly since it does the check itself.
3623
2c520ab5 36242011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 3625
c9c49752
PE
3626 Fix more problems found by GCC 4.5.2's static checks.
3627
8abc3f12
PE
3628 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3629 the first time through the loop, since we know p0 < p1 then.
3630 This also avoids a gcc -Wstrict-overflow warning.
3631
a2d26660
PE
3632 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3633 leading to a memory leak, possible in functions like
3634 load_charset_map_from_file that can allocate an unbounded number
b12ef411 3635 of objects (Bug#8318).
a2d26660 3636
916c72e9
PE
3637 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3638 that could (at least in theory) be that large.
3639
19ab8a18
PE
3640 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3641 This is less likely to overflow, and avoids undefined behavior if
3642 overflow does occur. All callers changed. Use strtoul to scan
3643 for the unsigned long integer.
b7cbbd6f
PE
3644 (pint2hrstr): Simplify and tune code slightly.
3645 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 3646
f0641eff
PE
3647 * scroll.c (do_scrolling): Work around GCC bug 48228.
3648 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3649
7f650bb9
PE
3650 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3651 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
3652 (validate_x_resource_name): Simplify count usage.
3653 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 3654
37dd57d1
PE
3655 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3656 fail (Bug#8306).
81e56e61 3657
699979fc 3658 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 3659
401bf9b4
PE
3660 * process.c (Fmake_network_process): Use socklen_t, not int,
3661 where POSIX says socklen_t is required in portable programs.
3662 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 3663 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
3664 (Fmake_network_process, server_accept_connection):
3665 (wait_reading_process_output, read_process_output):
3666 Likewise.
3667
b93aacde
PE
3668 * process.c: Rename or move locals to avoid shadowing.
3669 (list_processes_1, Fmake_network_process):
3670 (read_process_output_error_handler, exec_sentinel_error_handler):
3671 Rename or move locals.
4dc343ee 3672 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 3673 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 3674 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 3675 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 3676 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 3677
af8a867c 3678 Make tparam.h and terminfo.c consistent.
44f230aa
SM
3679 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3680 Include tparam.h instead, since it declares them.
af8a867c
PE
3681 * cm.h (PC): Remove extern decl; tparam.h now does this.
3682 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3683 * terminfo.c: Include tparam.h, to check interfaces.
3684 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3685 (tparam): Adjust signature to match interface in tparam.h;
3686 this removes some undefined behavior. Check that outstring and len
3687 are zero, which they always are with Emacs.
3688 * tparam.h (PC, BC, UP): New extern decls.
3689
0248044d 3690 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 3691 (xftfont_open): Rename locals to avoid shadowing.
0248044d 3692
8ff096c1 3693 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
3694 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3695 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 3696 (ftfont_list): Remove unused local.
49eaafba
PE
3697 (get_adstyle_property, ftfont_pattern_entity):
3698 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3699 Rename locals to avoid shadowing.
8ff096c1 3700
e2be39f6
PE
3701 * xfont.c (xfont_list_family): Mark var as initialized.
3702
c9735e30
PE
3703 * xml.c (make_dom): Now static.
3704
8f5201ae
PE
3705 * composite.c (composition_compute_stop_pos): Rename local to
3706 avoid shadowing.
b246f932
PE
3707 (composition_reseat_it): Remove unused locals.
3708 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 3709 (composition_update_it): Mark var as initialized.
11b61122
PE
3710 (find_automatic_composition): Mark vars as initialized,
3711 with a FIXME (Bug#8290).
8f5201ae 3712
760fbc2c
PE
3713 character.h: Rename locals to avoid shadowing.
3714 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3715 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3716 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3717 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3718 to avoid shadowing.
3719
ff08eb85
PE
3720 * textprop.c (property_change_between_p): Remove; unused.
3721
fc7bf025
PE
3722 * intervals.c (interval_start_pos): Now static.
3723
235d7abc
PE
3724 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3725
44f230aa
SM
3726 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3727 Rename locals to avoid shadowing.
3e7d6594 3728
50060332
PE
3729 * sound.c (wav_play, au_play, Fplay_sound_internal):
3730 Fix pointer signedness.
d01f234b 3731 (alsa_choose_format): Remove unused local var.
c83b8872
PE
3732 (wav_play): Initialize a variable to 0, to prevent undefined
3733 behavior (Bug#8278).
50060332 3734
c4fc4e30
PE
3735 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3736
918436ed
PE
3737 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3738
c939f91b
PE
3739 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3740 clobbering (Bug#8298).
b9c7f648
PE
3741 * sysdep.c (sys_subshell): Likewise.
3742 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 3743
6bd8c144
PE
3744 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3745 This should get cleaned up, so that child_setup has the
3746 same signature on all platforms.
3747
7710357c 3748 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 3749 (relocate_fd): Rename locals to avoid shadowing.
7710357c 3750
c59da222
CY
37512011-03-22 Chong Yidong <cyd@stupidchicken.com>
3752
3753 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3754 not to be necessary, and produces flickering.
3755
66b87493
GM
37562011-03-20 Glenn Morris <rgm@gnu.org>
3757
3758 * config.in: Remove file.
3759
45b6f6d5
JB
37602011-03-20 Juanma Barranquero <lekktu@gmail.com>
3761
3762 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3763 are now in src/globals.h.
3764 (syms_of_minibuf): Remove spurious & from previous change.
3765
3ec03f7e
LL
37662011-03-20 Leo <sdl.web@gmail.com>
3767
3768 * minibuf.c (completing-read-function): New variable.
3769 (completing-read-default): Rename from completing-read.
3770 (completing-read): Call completing-read-function.
3771
b14e3e21
CY
37722011-03-19 Juanma Barranquero <lekktu@gmail.com>
3773
3774 * xfaces.c (Fx_load_color_file):
3775 Read color file from absolute filename (bug#8250).
3776
f2b726e6
JB
37772011-03-19 Juanma Barranquero <lekktu@gmail.com>
3778
3779 * makefile.w32-in: Update dependencies.
3780
09f6ff02
EZ
37812011-03-17 Eli Zaretskii <eliz@gnu.org>
3782
3783 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3784
29a6015a
PE
37852011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3786
a3a6c54e
PE
3787 Fix more problems found by GCC 4.5.2's static checks.
3788
b766f867
PE
3789 * process.c (make_serial_process_unwind, send_process_trap):
3790 (sigchld_handler): Now static.
3791
be02381c
PE
3792 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3793 That way, the code declares only the vars that it needs.
3794 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3795 * s/cygwin.h (PTY_ITERATION): Likewise.
3796 * s/darwin.h (PTY_ITERATION): Likewise.
3797 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3798
57048744
PE
3799 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3800 * process.c (allocate_pty): Don't declare stb unless it's needed.
3801
7914961c 3802 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
3803 (CONSTANTLIM): Remove; unused.
3804 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3805 Define only if needed.
7914961c 3806
b3967b18
PE
3807 * unexelf.c (unexec): Name an expression,
3808 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
3809 Use a different way to cause a compilation error if anyone uses
3810 n rather than nn, a way that does not involve shadowing.
73366a00 3811 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 3812
29a6015a
PE
3813 * deps.mk (unexalpha.o): Remove; unused.
3814
43cfc33e 3815 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 3816 * unexec.h: New file.
ce701a33
PE
3817 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3818 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3819 Depend on unexec.h.
3820 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3821 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3822 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 3823 Change as necessary to match prototype in unexec.h.
ce701a33 3824
01f44d5a
PE
3825 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3826 shadowing.
4f63c6bb 3827 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 3828
a6670b0b
PE
3829 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3830 Rename locals to avoid shadowing.
3831
cef2010d 3832 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 3833 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 3834
d4d7173a
PE
3835 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3836
f08b802a
PE
3837 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3838 warning when compiling print.c.
3839
3ddb0639
PE
3840 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3841 instead of using an uninitialized var.
5ad03b97 3842 (font_sort_entities): Mark var as initialized.
3ddb0639 3843
170a2692
PE
3844 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3845
e663c700
PE
3846 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3847 pointers to constants.
89bc529a 3848 (font_parse_fcname): Remove unused vars.
7b81e2d0 3849 (font_delete_unmatched): Now static.
ea838e10 3850 (font_get_spec): Remove; unused.
13a547c6
PE
3851 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3852 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3853 Rename or move locals to avoid shadowing.
e663c700 3854
2a80c887 3855 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 3856 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 3857
1384fa33 3858 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 3859 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 3860
8b2c52e9
PE
3861 * alloc.c (mark_backtrace): Move decl from here ...
3862 * lisp.h: ... to here, so that it can be checked.
3863
475545b5 3864 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 3865 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
3866 (lisp_indirect_variable): Name an expression,
3867 to avoid gcc -Wbad-function-cast warning.
1faed8ae 3868 (Fdefvar): Rename locals to avoid shadowing.
475545b5 3869
b1349114 3870 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 3871 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 3872 Use const pointer when appropriate.
b1349114 3873
a2928364
PE
3874 * lisp.h (get_system_name, get_operating_system_release):
3875 Move decls here, to check interfaces.
3876 * process.c (get_operating_system_release): Move decl to lisp.h.
3877 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
3878 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3879 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3880 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
3881 (Fformat_time_string, Fencode_time, Finsert_char):
3882 (Ftranslate_region_internal, Fformat):
3883 Rename or remove local vars to avoid shadowing.
9710023e 3884 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 3885
a415e694
PE
3886 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3887 avoid shadowing.
3888
8ef4622d
PE
3889 * lisp.h (eassert): Check that the argument compiles, even if
3890 ENABLE_CHECKING is not defined.
3891
946f9a5b
PE
3892 * data.c (Findirect_variable): Name an expression, to avoid
3893 gcc -Wbad-function-cast warning.
112396d6 3894 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 3895 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
3896 (Fmake_variable_buffer_local, Fmake_local_variable):
3897 Mark variables as initialized.
52746918 3898 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 3899
e5aab7e7 3900 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
3901 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3902 Rename locals to avoid shadowing.
dff45157
PE
3903 (mark_stack): Move local variables into the #ifdef region where
3904 they're used.
7bc26fdb
PE
3905 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3906 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3907 needed otherwise.
3908 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3909 (GC_STRING_CHARS): Remove; not used.
d40d4be1 3910 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 3911
e5aab7e7
PE
3912 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3913 avoids undefined behavior in theory.
3914
4da60324
PE
3915 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3916
88043301
PE
3917 Use functions, not macros, for up- and down-casing (Bug#8254).
3918 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3919 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3920 to use the following functions instead of these macros.
3921 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3922 EMACS_INT, since callers assume the returned value fits in int.
3923 (upcase1): Likewise, for UPCASE_TABLE.
3924 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 3925 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 3926 the race-condition problem in the old DOWNCASE.
88043301 3927
19ed5445
PE
3928 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3929 Rename locals to avoid shadowing.
3930 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
3931 (regex_compile, re_search_2, re_match_2_internal):
3932 Remove unused local vars.
952db0d7
PE
3933 (FREE_VAR): Rewrite so as not to use empty "else",
3934 which gcc can warn about.
da053e48 3935 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
3936 (RETALLOC_IF): Define only if needed.
3937 (WORDCHAR_P): Likewise. This one is never needed, but is used
3938 only in a comment talking about a compiler bug, so put inside
3939 the #if 0 of that comment.
3940 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3941 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3942 Remove; unused.
19ed5445 3943
1f3561e4 3944 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
3945 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3946 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 3947
ded6f8f7
PE
3948 * search.c (simple_search): Remove unused var.
3949
dbd37a95
PE
3950 * dired.c (compile_pattern): Move decl from here ...
3951 * lisp.h: ... to here, so that it can be checked.
3952 (struct re_registers): New forward decl.
3953
7e47afad
PE
3954 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3955
85f24f61
PE
3956 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3957 All uses changed.
3958 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3959 Rename locals to avoid shadowing.
5671df8f 3960 (Fvertical_motion): Mark locals as initialized.
85f24f61 3961
181aa2be 3962 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 3963 (casify_region): Mark local as initialized.
181aa2be 3964
930d429c
PE
3965 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3966
7082eac6
PE
3967 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3968 New macros, so that the caller can use some names other than
3969 gcpro1, gcpro2, etc.
3970 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3971 of the new macros.
3972 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3973 argument, for consistency with GCPRO2_VAR, etc: it is now the
3974 prefix of the variable, not the variable itself. All uses
3975 changed.
38b2c076
PE
3976 * dired.c (directory_files_internal, file_name_completion):
3977 Rename locals to avoid shadowing.
3978
15206ed9
PE
3979 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3980 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3981 dired.c's scmp function, had undefined behavior.
3982 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3983 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3984 * buffer.h: ... to here, because these macros use current_buffer,
3985 and the new implementation with inline functions needs to have
3986 current_buffer in scope now, rather than later when the macros
3987 are used.
3988 (downcase, upcase1): New static inline functions.
3989 (DOWNCASE, UPCASE1): Reimplement using these functions.
3990 This avoids undefined behavior in expressions like
3991 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3992 from race conditions in accessing the global variables
3993 case_temp1 and case_temp2.
3994 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3995 * lisp.h (case_temp1, case_temp2): Remove their decls.
3996 * character.h (ASCII_CHAR_P): Move from here ...
3997 * lisp.h: ... to here, so that the inline functions mentioned
3998 above can use them.
3999
4a6bea26
PE
4000 * dired.c (directory_files_internal_unwind): Now static.
4001
f14b7e14
PE
4002 * fileio.c (file_name_as_directory, directory_file_name):
4003 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4004 Now static.
2893f146
PE
4005 (file_name_as_directory): Use const pointers when appropriate.
4006 (Fexpand_file_name): Likewise. In particular, newdir might
4007 point at constant storage, so make it a const pointer.
fd4ead52 4008 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
4009 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4010 signedness issues.
f839df0c
PE
4011 (Fset_file_times, Finsert_file_contents, auto_save_error):
4012 Rename locals to avoid shadowing.
f14b7e14 4013
5716756e 4014 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
4015 (Ftry_completion, Fall_completions): Rename or remove locals
4016 to avoid shadowing.
5716756e 4017
b4c3046a
PE
4018 * marker.c (bytepos_to_charpos): Remove; unused.
4019
b45db522
PE
4020 * lisp.h (verify_bytepos, count_markers): New decls,
4021 so that gcc does not warn that these functions aren't declared.
4022
85876d07
PE
4023 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4024 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 4025 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 4026 (copy_text): Remove unused local var.
85876d07 4027
03d78a21 4028 * filelock.c (within_one_second): Now static.
b3dd38ab 4029 (lock_file_1): Rename local to avoid shadowing.
03d78a21 4030
5df8f01b
PE
4031 * buffer.c (fix_overlays_before): Mark locals as initialized.
4032 (fix_start_end_in_overlays): Likewise. This function should be
4033 simplified by using pointers-to-pointers, but that's a different
4034 matter.
b1d876f1 4035 (switch_to_buffer_1): Now static.
8f54f30a
PE
4036 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4037 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 4038
a70072c9 4039 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 4040 Fix pointer signedness issue.
edced198
PE
4041 (sys_subshell): Mark local as volatile if checking for lint,
4042 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 4043 (MAXPATHLEN): Define only if needed.
a70072c9 4044
a0977c44
PE
4045 * process.c (serial_open, serial_configure): Move decls from here ...
4046 * systty.h: ... to here, so that they can be checked.
4047
a884fdcc
PE
4048 * fns.c (get_random, seed_random): Move extern decls from here ...
4049 * lisp.h: ... to here, so that they can be checked.
4050
604efe86 4051 * sysdep.c (reset_io): Now static.
b8950c94 4052 (wait_for_termination_signal): Remove; unused.
604efe86 4053
38fc62d9
PE
4054 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4055 (copy_keymap_item, append_key, push_text_char_description):
4056 Now static.
1004a21a 4057 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 4058 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
4059 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4060 (describe_map_tree):
4061 Rename locals to avoid shadowing.
38fc62d9 4062
2f2650da
PE
4063 * keyboard.c: Declare functions static if they are not used elsewhere.
4064 (echo_char, echo_dash, cmd_error, top_level_2):
4065 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
4066 (read_char, kbd_buffer_get_event, make_lispy_position):
4067 (make_lispy_event, make_lispy_movement, apply_modifiers):
4068 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4069 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4070 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 4071 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 4072 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 4073
a053e86c 4074 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
4075 (mark_kboards): Move decl here ...
4076 * alloc.c (mark_kboards): ... from here.
a053e86c 4077
4752793e
PE
4078 * lisp.h (force_auto_save_soon): New decl.
4079
74f10ca7 4080 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
4081 (DEFINE_DUMMY_FUNCTION): New macro.
4082 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4083 Use it.
c03cd23f
PE
4084 (main): Add casts to avoid warnings
4085 if GCC considers string literals to be constants.
74f10ca7 4086
022e70d4
PE
4087 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4088
59d6fe83
PE
4089 * dbusbind.c: Pointer signedness fixes.
4090 (xd_signature, xd_append_arg, xd_initialize):
4091 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4092 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4093 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4094 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4095
78320123
PE
4096 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4097 if GCC considers string literals to be constants.
49cebcca 4098 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 4099
35ac2a97
SM
41002011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4101
fb103ca9
SM
4102 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4103 (print_preprocess, print_object): New macro to fix last change.
4104
35ac2a97
SM
4105 * print.c (print_preprocess): Don't forget font objects.
4106
62973b41
JB
41072011-03-16 Juanma Barranquero <lekktu@gmail.com>
4108
4109 * emacs.c (USAGE3): Doc fixes.
4110
0e48bb22
AS
41112011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4112
4113 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4114 structure.
4115
7684e57b
JB
41162011-03-14 Juanma Barranquero <lekktu@gmail.com>
4117
4118 * lisp.h (VWindow_system, Qfile_name_history):
4119 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4120 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4121 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4122
4123 * w32select.c: Don't #include "keyboard.h".
c96bbc66 4124 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
4125
4126 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4127 * w32console.c (detect_input_pending, read_input_pending)
4128 (encode_terminal_code):
4129 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4130 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4131 (w32_system_caret_y, Qfile_name_history):
4132 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4133 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4134 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4135 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4136 * w32proc.c (Qlocal, report_file_error):
4137 * w32term.c (Vwindow_system, updating_frame):
4138 * w32uniscribe.c (initialized, uniscribe_font_driver):
4139 Remove unneeded extern declarations.
4140
2aa46d6c
CY
41412011-03-14 Chong Yidong <cyd@stupidchicken.com>
4142
c96bbc66 4143 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 4144
cffc6f3b
CY
41452011-03-13 Chong Yidong <cyd@stupidchicken.com>
4146
4147 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4148 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4149 These macros can no longer be used for assignment.
4150
44f230aa
SM
4151 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4152 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
4153 (record_buffer_markers, fetch_buffer_markers): New functions for
4154 recording and fetching special buffer markers.
4155 (set_buffer_internal_1, set_buffer_temp): Use them.
4156
4157 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4158
4159 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4160
4161 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4162 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4163
4164 * xdisp.c (hscroll_window_tree):
4165 (reconsider_clip_changes): Use PT instead of BUF_PT.
4166
d251f04b
EZ
41672011-03-13 Eli Zaretskii <eliz@gnu.org>
4168
4169 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4170 $(EMACS_ROOT)/lib/intprops.h.
4171
f0c77cd1
PE
41722011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4173
3eca4629
PE
4174 Fix more problems found by GCC 4.5.2's static checks.
4175
7c86ee98
PE
4176 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4177 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
4178 (xg_free_frame_widgets): Make it clear that a local variable is
4179 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
4180 (gdk_window_get_screen): Make it clear that this macro is needed
4181 only if USE_GTK_TOOLTIP.
1e5524e7
PE
4182 (int_gtk_range_get_value): New function, which avoids a diagnostic
4183 from gcc -Wbad-function-cast.
4184 (xg_set_toolkit_scroll_bar_thumb): Use it.
4185 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4186 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
4187 (get_utf8_string, xg_get_file_with_chooser):
4188 Rename locals to avoid shadowing.
4189 (create_dialog): Move locals to avoid shadowing.
7c86ee98 4190
41729b81
PE
4191 * xgselect.c (xg_select): Remove unused var.
4192
f0c77cd1
PE
4193 * image.c (four_corners_best): Mark locals as initialized.
4194 (gif_load): Initialize transparent_p to zero (Bug#8238).
4195 Mark another local as initialized.
ec6cf4c6 4196 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 4197
ce0ad53d 4198 * image.c (clear_image_cache): Now static.
d5d5a617 4199 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 4200 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
4201 (x_edge_detection): Remove unnecessary cast that
4202 gcc -Wbad-function-cast diagnoses.
2037898d 4203 (gif_load): Fix pointer signedness.
6ae141d6
PE
4204 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4205 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 4206
33383987 42072011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 4208
d32df629
PE
4209 Improve quality of tests for time stamp overflow.
4210 For example, without this patch (encode-time 0 0 0 1 1
4211 1152921504606846976) returns the obviously-bogus value (-948597
4212 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4213 reports time overflow. See
4214 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
4215 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4216 * editfns.c: Include limits.h and intprops.h.
4217 (TIME_T_MIN, TIME_T_MAX): New macros.
4218 (time_overflow): Move earlier, to before first use.
4219 (hi_time, lo_time): New functions, for an accurate test for
4220 out-of-range times.
4221 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4222 (Fget_internal_run_time): Don't assume time_t fits in int.
4223 (make_time): Use list2 instead of Fcons twice.
4224 (Fdecode_time): More accurate test for out-of-range times.
4225 (check_tm_member): New function.
4226 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
4227 (lisp_time_argument): Don't rely on undefined left-shift and
4228 right-shift behavior when checking for time stamp overflow.
8be6f318 4229
fe31d94c
PE
4230 * editfns.c (time_overflow): New function, refactoring common code.
4231 (Fformat_time_string, Fdecode_time, Fencode_time):
4232 (Fcurrent_time_string): Use it.
4233
8be6f318
PE
4234 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4235 * dired.c (make_time): Move to ...
4236 * editfns.c (make_time): ... here.
4237 * systime.h: Note the move.
4238
09d9db2c 42392011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 4240
126bc0dc
YM
4241 * fringe.c (update_window_fringes): Remove unused variables.
4242
c47cbdfd
YM
4243 * unexmacosx.c (copy_data_segment): Also copy __got section.
4244 (Bug#8223)
4245
7ac80be9
EZ
42462011-03-12 Eli Zaretskii <eliz@gnu.org>
4247
c96bbc66 4248 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
4249 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4250 Constify `char *' arguments and their references according to
4251 prototypes in tparam.h.
4252
ecb0f94d 4253 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 4254
7ac80be9
EZ
4255 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4256 Adapt all references accordingly.
4257
4258 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4259
ef1fd07e
TT
42602011-03-11 Tom Tromey <tromey@redhat.com>
4261
4262 * buffer.c (syms_of_buffer): Remove obsolete comment.
4263
7ef4b50c
EZ
42642011-03-11 Eli Zaretskii <eliz@gnu.org>
4265
4266 * termhooks.h (encode_terminal_code): Declare prototype.
4267
4268 * msdos.c (encode_terminal_code): Don't declare prototype.
4269
4270 * term.c (encode_terminal_code): Now external again, used by
4271 w32console.c and msdos.c.
4272
44f230aa
SM
4273 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4274 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 4275
4b1ec863 42762011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 4277
1714f52b 4278 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 4279
4b1ec863
PE
4280 * fringe.c (update_window_fringes): Mark locals as initialized
4281 (Bug#8227).
4282 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 4283
524c7aa6
PE
4284 * alloc.c (mark_fringe_data): Move decl from here ...
4285 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4286 to check its interface.
4287 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4288
a5c0af81 4289 * fontset.c (free_realized_fontset): Now static.
7519b8cd 4290 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 4291 (fontset_font): Mark local as initialized.
a9a06e0b 4292 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 4293
b4716021
PE
4294 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4295
811e9bac 4296 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 4297 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
4298 (x_own_selection, Fx_disown_selection_internal): Rename locals
4299 to avoid shadowing.
4300 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 4301
7e3ab302
PE
4302 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4303 so that the caller can use some name other than gcpro1.
4304 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
4305 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4306 (Fx_backspace_delete_keys_p):
4307 Use them to avoid shadowing, and rename vars to avoid shadowing.
4308 (x_decode_color, x_set_name, x_window): Now static.
6b437900 4309 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 4310 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
4311 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4312 Remove unused locals.
7e3ab302
PE
4313 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4314 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4315 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4316 macros.
f78faa98 4317
e2b13473
PE
4318 * xterm.h (x_mouse_leave): New decl.
4319
77f23912
PE
4320 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4321 Remove unused functions.
cdf4ba58
PE
4322 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4323 (x_calc_absolute_position): Now static.
7411c686 4324 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 4325 Don't declare local "event" unless it's used.
ed7bf3a5
PE
4326 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4327 unless they are used.
38d0b34a
PE
4328 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4329 (x_fatal_error_signal): Remove; not used.
a6067996
PE
4330 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4331 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4332 (x_error_catcher, x_connection_closed, x_error_handler):
4333 (x_error_quitter, xembed_send_message, x_iconify_frame):
4334 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 4335 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 4336 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 4337
44f230aa
SM
4338 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4339 Rename or move locals to avoid shadowing.
6b463e58 4340 (tty_defined_color, merge_face_heights): Now static.
5967d051 4341 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
4342 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4343 does not deduce is never used uninitialized.
73719eba
PE
4344 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4345 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 4346
426994c3 4347 * terminal.c (store_terminal_param): Now static.
5489860b 4348
032f1620 4349 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 4350 (set_frame_menubar): Remove unused local.
d4323972 4351 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
4352 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4353 since they might point to immutable storage.
281585b0
PE
4354 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4355 since it's unused otherwise.
032f1620 4356
367c19e5 4357 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 4358 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
4359 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4360 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 4361 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
4362 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4363 does not deduce are never used uninitialized.
70739cbe 4364
07b48fa9
PE
4365 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4366
8868a238 4367 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
4368 * window.c (window_loop, size_window):
4369 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 4370
7e5cf297 4371 * window.c (display_buffer): Now static.
d6550a9f
PE
4372 (size_window): Mark variables that gcc -Wuninitialized
4373 does not deduce are never used uninitialized.
a586633d
PE
4374 * window.h (check_all_windows): New decl, to forestall
4375 gcc -Wmissing-prototypes diagnostic.
5b555da1 4376 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 4377
f6095868
PE
4378 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4379 shadowing.
4380 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
4381 Include <limits.h>.
4382 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4383 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
4384 (load_charset_map): Mark variables that gcc -Wuninitialized
4385 does not deduce are never used uninitialized.
53df7c11 4386 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 4387
f38b440c
PE
4388 * coding.c (coding_set_source, coding_set_destination):
4389 Use "else { /* comment */ }" rather than "else /* comment */;"
4390 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
4391 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4392 a block, when the outer 'i' will do.
4393 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4394 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4395 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4396 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4397 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4398 Rename locals to avoid shadowing.
4399 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
4400 * coding.c (emacs_mule_char, encode_invocation_designation):
4401 Now static, since they're not used elsewhere.
413bb2db 4402 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 4403 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
4404 (decode_coding_emacs_mule): Mark variables that gcc
4405 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
4406 (detect_coding_iso_2022): Initialize a local variable that might
4407 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 4408 this initialization is needed. (Bug#8211)
5f58e762
PE
4409 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4410 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4411 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4412 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4413 Remove unused macros.
f38b440c 4414
232b38b9 4415 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 4416 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 4417 * character.c (string_count_byte8): Likewise.
232b38b9 4418
fb90da1b
PE
4419 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4420 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4421
fb93dbc2
PE
4422 * chartab.c (copy_sub_char_table): Now static, since it's not used
4423 elsewhere.
5c156ace
PE
4424 (sub_char_table_ref_and_range, char_table_ref_and_range):
4425 Rename locals to avoid shadowing.
bbcd0949 4426 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 4427
7d3b3862 4428 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 4429 (BIDI_BOB): Remove unused macro.
7d3b3862 4430
6be7d3da
PE
4431 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4432 deduce are never used uninitialized.
c2ed9c8b 4433 * term.c (encode_terminal_code): Likewise.
6be7d3da 4434
75f8807f 4435 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 4436
50938595
PE
4437 * tparam.h: New file.
4438 * term.c, tparam.h: Include it.
4439 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4440 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4441 Move these decls to tparam.h, and make them agree with what
4442 is actually in tparam.c. The previous trick of using incompatible
4443 decls in different modules does not conform to the C standard.
4444 All callers of tparam changed to use tparam's actual API.
4445 * tparam.c (tparam1, tparam, tgoto):
4446 Use const pointers where appropriate.
4447
fbceeba2
PE
4448 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4449 * cm.h (struct cm): Likewise.
4450 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4451 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4452 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4453 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4454 (turn_on_face, init_tty): Likewise.
4455 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 4456
7f3f1250
PE
4457 * term.c (term_mouse_position): Rename local to avoid shadowing.
4458
e6ca6543
PE
4459 * alloc.c (mark_ttys): Move decl from here ...
4460 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4461
c40f8d15
AS
44622011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4463
4464 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4465
cfe0661d
JB
44662011-03-09 Juanma Barranquero <lekktu@gmail.com>
4467
4468 * search.c (compile_pattern_1): Remove argument regp, unused since
4469 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4470 (compile_pattern): Don't pass it.
4471
0afb4571
J
44722011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4473
4474 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4475 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4476 for ! HAVE_GTK3.
4477 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4478
4479 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4480
4481 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4482 gdk_window_get_screen, gdk_window_get_geometry,
4483 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4484 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4485 (xg_get_pixbuf_from_pixmap): New function.
4486 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4487 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4488 Call xg_get_pixbuf_from_pixmap instead of
4489 gdk_pixbuf_get_from_drawable.
4490 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4491 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4492 (xg_check_special_colors): Use GtkStyleContext and its functions
4493 for HAVE_GTK3.
4494 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4495 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4496 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
4497 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4498 Call gtk_widget_get_preferred_size.
0afb4571
J
4499 (xg_frame_resized): gdk_window_get_geometry only takes 5
4500 parameters.
44f230aa
SM
4501 (xg_win_to_widget, xg_event_is_for_menubar):
4502 Call gdk_x11_window_lookup_for_display.
0afb4571
J
4503 (xg_set_widget_bg): New function.
4504 (delete_cb): New function.
895009e1 4505 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
4506 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4507 (xg_set_background_color): Call xg_set_widget_bg.
4508 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4509 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4510 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4511 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4512 if ! HAVE_GTK3.
4513 (update_frame_tool_bar): Call gtk_widget_hide.
4514 (xg_initialize): Use GDK_KEY_g.
4515
4516 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4517 if ! HAVE_GTK3
4518 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4519
4520 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4521 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4522 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4523
1c2cc4ef
JB
45242011-03-08 Juanma Barranquero <lekktu@gmail.com>
4525
4526 * w32xfns.c (select_palette): Check success of RealizePalette against
4527 GDI_ERROR, not zero.
4528
33383987 4529See ChangeLog.11 for earlier changes.
aac0c6e3
MR
4530
4531;; Local Variables:
4532;; coding: utf-8
aac0c6e3
MR
4533;; End:
4534
33383987 4535 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
4536
4537 This file is part of GNU Emacs.
4538
4539 GNU Emacs is free software: you can redistribute it and/or modify
4540 it under the terms of the GNU General Public License as published by
4541 the Free Software Foundation, either version 3 of the License, or
4542 (at your option) any later version.
4543
4544 GNU Emacs is distributed in the hope that it will be useful,
4545 but WITHOUT ANY WARRANTY; without even the implied warranty of
4546 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4547 GNU General Public License for more details.
4548
4549 You should have received a copy of the GNU General Public License
4550 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.