Fix bug #11405 with MSVC build of emacsclientw.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
a02ae4e5
EZ
12012-05-29 Eli Zaretskii <eliz@gnu.org>
2
3 * search.c (search_buffer): Remove calls to
4 r_alloc_inhibit_buffer_relocation, as it is now called by
5 maybe_unify_char, which was the cause of relocation of buffer text
6 in bug#11519.
7
291d430f
EZ
82012-05-23 Eli Zaretskii <eliz@gnu.org>
9
10 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
11 for the duration of call to load_charset, to avoid problems with
12 callers of maybe_unify_char that access buffer text through C
13 pointers.
14
15 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
16 decrement the inhibition flag, instead of just setting or
17 resetting it.
18
2f9b9adb
KB
192012-05-24 Ken Brown <kbrown@cornell.edu>
20
21 * callproc.c (Fcall_process): Restore a line that was accidentally
22 commented out in the 2011-02-13 change (bug#11547).
23
52c55cc7
EZ
242012-05-23 Eli Zaretskii <eliz@gnu.org>
25
26 * lisp.h [REL_ALLOC]: Add prototypes for external functions
27 defined on ralloc.c.
28
29 * buffer.c [REL_ALLOC]: Remove prototypes of
30 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
31 they are now on lisp.h.
32
33 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
34
35 * search.c (search_buffer): Use it to inhibit relocation of buffer
36 text while re_search_2 is doing its job, because re_search_2 is
37 passed C pointers to buffer text. (Bug#11519)
38
23415acf
EZ
392012-05-21 Eli Zaretskii <eliz@gnu.org>
40
41 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
42 Update value to 24.
43
44e27368
EZ
442012-05-19 Eli Zaretskii <eliz@gnu.org>
45
46 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
47 state after an additional call to move_it_in_display_line_to, keep
48 the values of it->max_ascent and it->max_descent found for the
49 entire line.
50 (pos_visible_p): Revert the comparison against bottom_y to what it
51 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
52 (Bug#11464)
53
ccbf309c
EZ
542012-05-15 Eli Zaretskii <eliz@gnu.org>
55
56 * xdisp.c (pos_visible_p): Fix last change. (Bug#11464)
57
ac268e67
EZ
582012-05-13 Eli Zaretskii <eliz@gnu.org>
59
60 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
61 already have overlays loaded.
62 (handle_single_display_spec): Before returning without displaying
63 fringe bitmap, synchronize the bidi iterator with the main display
64 iterator, by calling iterate_out_of_display_property.
65 (iterate_out_of_display_property): Detect buffer iteration by
66 testing that it->string is a Lisp string.
67 (get_next_display_element): When the current object is exhausted,
68 and there's something on it->stack, call set_iterator_to_next to
69 proceed with what's on the stack, instead of returning zero.
70 (set_iterator_to_next): If called at the end of a Lisp string,
71 proceed to consider_string_end without incrementing string
72 position. Don't increment display vector index past the end of
73 the display vector. (Bug#11417)
c8fb9dc6
EZ
74 (pos_visible_p): Don't report a position visible when move_it_to
75 stopped at the last line of window, which happens to be scanned
76 backwards by the bidi iteration. (Bug#11464)
ac268e67 77
82f9b393
EZ
782012-05-11 Eli Zaretskii <eliz@gnu.org>
79
80 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
81 and right-margin display specs even if the spec is invalid or we
82 are on a TTY, and thus unable to display on the fringes. That's
83 because the text with the property will not be displayed anyway,
84 so we need to signal to the caller that this is a "replacing"
85 display spec. This fixes display when the spec is invalid or we
86 are on a TTY.
87
297834cd
PE
882012-05-09 Paul Eggert <eggert@cs.ucla.edu>
89
90 * unexaix.c (make_hdr): Fix typo in prototype.
91 This bug broke the build on AIX. Problem reported by Gilles Pion.
92
0d887c7d
EZ
932012-05-05 Eli Zaretskii <eliz@gnu.org>
94
95 * w32proc.c (new_child): Force Windows to reserve only 64KB of
96 stack for each reader_thread, instead of defaulting to 8MB
97 determined by the linker. This avoids failures in creating
98 subprocesses on Windows 7, see the discussion in this thread:
99 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
100
bf98199c
JM
1012012-05-02 Jim Meyering <meyering@redhat.com>
102
103 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
104
2fa85638
EZ
1052012-04-29 Eli Zaretskii <eliz@gnu.org>
106
107 * xdisp.c (pos_visible_p): If already at a newline from the
108 display string before the 'while' loop, don't walk back the glyphs
109 from it3.glyph_row. Solves assertion violation when the display
110 string begins with a newline (egg.el). (Bug#11367)
111
9be2fd9b
CY
1122012-04-24 Chong Yidong <cyd@gnu.org>
113
114 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
115
f0ee99a0
EZ
1162012-04-23 Eli Zaretskii <eliz@gnu.org>
117
118 * xdisp.c (pos_visible_p): If the window start position is beyond
119 ZV, start the display from buffer beginning. Prevents assertion
120 violation in init_iterator when the minibuffer window is scrolled
121 via the scroll bar.
122
123 * window.c (window_scroll_pixel_based): Likewise.
124
9ec7751f
CY
1252012-04-23 Chong Yidong <cyd@gnu.org>
126
127 * keymap.c (where_is_internal): Doc fix (Bug#10872).
128
24c51a09
GM
1292012-04-20 Glenn Morris <rgm@gnu.org>
130
131 * fileio.c (Fcopy_file, Fset_file_selinux_context):
132 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
133
73055685
EZ
1342012-04-20 Eli Zaretskii <eliz@gnu.org>
135
136 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers): Don't
137 overrun array limits of glyph row's used[] array. (Bug#11288)
138
f30d612a
CY
1392012-04-20 Chong Yidong <cyd@gnu.org>
140
141 * process.c (wait_reading_process_output): If EIO occurs on a pty,
142 set the status to "failed" and ensure that sentinel is run.
143
016a35df
GM
1442012-04-18 Glenn Morris <rgm@gnu.org>
145
146 * process.c (Fset_process_inherit_coding_system_flag)
147 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 148 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 149
20a68157
EZ
1502012-04-17 Eli Zaretskii <eliz@gnu.org>
151
152 * xdisp.c (string_buffer_position_lim): Limit starting position to
153 BEGV.
154 (set_cursor_from_row): If called for a mode-line or header-line
155 row, return zero immediately.
156 (try_cursor_movement): If inside continuation line, don't back up
157 farther than the first row after the header line, if any. Don't
158 consider the header-line row as "partially visible", even if
159 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
160
ad3a2b41
AO
1612012-04-13 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
162
163 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n" (bug#11238).
164
e63c261b
CY
1652012-04-10 Teodor Zlatanov <tzz@lifelogs.com>
166
167 * process.c (make_process):
168 * process.h: Add integer `gnutls_handshakes_tried' member to
169 process struct.
170
ad3a2b41
AO
171 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
172 Add convenience `GNUTLS_LOG2i' macro.
e63c261b
CY
173
174 * gnutls.c (gnutls_log_function2i): Convenience log function.
175 (emacs_gnutls_read): Use new log functions,
176 `gnutls_handshakes_tried' process member, and
177 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
178 attempts per process (connection).
179
e53357c4
EZ
1802012-04-09 Eli Zaretskii <eliz@gnu.org>
181
182 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
183 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
184
aff67c82
JD
1852012-04-09 Jan Djärv <jan.h.d@swipnet.se>
186
187 * nsterm.m (constrainFrameRect): Always constrain when there is only
188 one screen (Bug#10962).
189
2f8e16b2
EZ
1902012-04-06 Eli Zaretskii <eliz@gnu.org>
191
192 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
193 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
194 about subtle differences between FETCH_CHAR* and STRING_CHAR*
195 macros related to unification of CJK characters. For the details,
196 see the discussion following the message here:
197 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
198
3d439cd1
CY
1992012-04-04 Chong Yidong <cyd@gnu.org>
200
201 * keyboard.c (Vdelayed_warnings_list): Doc fix.
202
8bc53d00
EZ
2032012-04-01 Eli Zaretskii <eliz@gnu.org>
204
205 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
206 instead of alloca. (Bug#11138)
207
3b0512a3
AS
2082012-04-01 Andreas Schwab <schwab@linux-m68k.org>
209
210 * w32menu.c (is_simple_dialog): Properly check lisp types.
211 (Bug#11141)
212
8427ddd2
EZ
2132012-03-31 Eli Zaretskii <eliz@gnu.org>
214
979022ef
EZ
215 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
216 position we get to after a call to move_it_to fails the
217 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
218 only if we wind up in a string from display property. (Bug#11063)
219
a6b1c7cc
EZ
220 * window.c (Fdelete_other_windows_internal): Invalidate the row
221 and column information about mouse highlight, so that redisplay
222 restores it after reallocating the glyph matrices. (Bug#7464)
223
8427ddd2
EZ
224 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
225 string comes from a `display' text property, use the buffer
226 position of that property as if we actually saw that position in
227 the row's glyphs.
697ba24b
EZ
228 (move_it_by_lines): Remove the assertion that
229 "it->current_x == 0 && it->hpos == 0" which can be legitimately
230 violated when there's a before-string at the beginning of a line.
231 (Bug#11063)
8427ddd2 232
65a0a738
EZ
2332012-03-30 Eli Zaretskii <eliz@gnu.org>
234
235 * xdisp.c (append_space_for_newline): If the default face was
236 remapped, use the remapped face for the appended newline.
237 (extend_face_to_end_of_line): Use the remapped default face for
238 extending the face to the end of the line.
239 (display_line): Call extend_face_to_end_of_line when the default
240 face was remapped. (Bug#11068)
241
581355cc
EZ
2422012-03-29 Eli Zaretskii <eliz@gnu.org>
243
244 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
245
e8fc049f
SM
2462012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
247
248 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
249
4fb9a543
GM
2502012-03-27 Glenn Morris <rgm@gnu.org>
251
252 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
253 Doc fixes.
254
679910f1
KH
2552012-03-26 Kenichi Handa <handa@m17n.org>
256
257 * dispextern.h (struct glyph): Fix previous change. Change the
258 bit length of glyphless.ch to 25 (Bug#11082).
259
90d49b7f
CY
2602012-03-26 Chong Yidong <cyd@gnu.org>
261
262 * keyboard.c (Vselection_inhibit_update_commands): New variable.
263 (command_loop_1): Use it; inhibit selection update for
264 handle-select-window too (Bug#8996).
265
f514f6f0
FP
2662012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
267
e8fc049f 268 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 269
bf43fa51
KH
2702012-03-25 Kenichi Handa <handa@m17n.org>
271
272 * dispextern.h (struct glyph): Change the bit length of
273 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
274
8a0c01dd
EZ
2752012-03-24 Eli Zaretskii <eliz@gnu.org>
276
277 * s/ms-w32.h (tzname): Include time.h before redirecting to
278 _tzname. Fixes the MSVC build. (Bug#9960)
279
7d1c3a76
AS
2802012-03-24 Andreas Schwab <schwab@linux-m68k.org>
281
8ed79523
AS
282 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
283 characters.
284
7d1c3a76
AS
285 * xterm.c (XTread_socket): Only modify handling_signal if
286 !SYNC_INPUT. (Bug#11080)
287
e99a9b8b
EZ
2882012-03-23 Eli Zaretskii <eliz@gnu.org>
289
290 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
291 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
292 when fetching a multibyte character consumes more bytes than
293 CHAR_BYTES returns, due to unification of CJK characters in
294 string_char. (Bug#11073)
295
5063c0e1
TN
2962012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
297
298 * process.c (wait_reading_process_output): Handle pty disconnect
299 by refraining from sending oneself a SIGCHLD (bug#10933).
300
9f851fbd
CY
3012012-03-22 Chong Yidong <cyd@gnu.org>
302
303 * dispextern.h (struct it): New member string_from_prefix_prop_p.
304
5063c0e1 305 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
306 Mark string as coming from a prefix property.
307 (handle_face_prop): Use default face for prefix strings (Bug#4281).
308 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
309
fb5b8aca
CY
3102012-03-21 Chong Yidong <cyd@gnu.org>
311
312 * xfaces.c (Vface_remapping_alist): Doc fix.
313
62356a1b
EZ
3142012-03-20 Eli Zaretskii <eliz@gnu.org>
315
316 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
317 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
318 Doc fixes.
62356a1b 319
025de85b
CY
3202012-03-20 Chong Yidong <cyd@gnu.org>
321
322 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
323 to reflect default non-nil value of redisplay-dont-pause.
324
4827f94e
KH
3252012-03-19 Kenichi Handa <handa@m17n.org>
326
327 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
328 it fit in a valid range (Bug#11003).
329
e50a24a2
EZ
3302012-03-18 Eli Zaretskii <eliz@gnu.org>
331
332 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
333 that is not from display property, accept the row as a "cursor
334 row" if one of the string's character has a non-nil `cursor'
335 property. Fixes cursor positioning when there are newlines in
336 overlay strings, e.g. in icomplete.el. (Bug#11035)
337
9af5ed87
PE
3382012-03-12 Paul Eggert <eggert@cs.ucla.edu>
339
340 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
341
d1f55f16
CY
3422012-03-12 Chong Yidong <cyd@gnu.org>
343
344 * eval.c (inhibit_lisp_code): Rename from
345 inhibit_window_configuration_change_hook; move from window.c.
346
347 * xfns.c (unwind_create_frame_1, Fx_create_frame):
348 * window.c (run_window_configuration_change_hook)
349 (syms_of_window): Callers changed.
350
66c5eebd
CY
3512012-03-11 Chong Yidong <cyd@gnu.org>
352
413df973
CY
353 * keymap.c (Fkey_description): Doc fix (Bug#9700).
354
66c5eebd
CY
355 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
356
1de11f56
CY
3572012-03-10 Chong Yidong <cyd@gnu.org>
358
359 * frame.c (other_visible_frames): Don't assume the selected frame
360 is visible (Bug#10955).
361
cae07000
SM
3622012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
363
364 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
365
89c94350
JD
3662012-03-08 Jan Djärv <jan.h.d@swipnet.se>
367
368 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
369 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
370 zero (Bug#10954).
371
999dd333
GM
3722012-03-03 Glenn Morris <rgm@gnu.org>
373
01a6dcc8 374 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 375
de0100f2
EZ
3762012-03-02 Eli Zaretskii <eliz@gnu.org>
377
378 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
379 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
380 (redisplay_window, next_element_from_string): Fix typos in
381 comments.
3e441275
EZ
382 (redisplay_window): Pass to move_it_vertically the margin in
383 pixels, not in screen lines.
de0100f2 384
96a72ee9
GM
3852012-03-02 Glenn Morris <rgm@gnu.org>
386
387 * buffer.c (buffer-list-update-hook): Doc fix.
388
312508d7
EZ
3892012-02-29 Eli Zaretskii <eliz@gnu.org>
390
391 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
392 push_it before setting up the iterator for the first overlay
393 string, even if we have an empty string loaded.
394 (next_overlay_string): If there's an empty string on the iterator
395 stack, pop the stack. (Bug#10903)
396
27f3c637
PE
3972012-02-25 Paul Eggert <eggert@cs.ucla.edu>
398
399 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
400 Suggested by Stefan Monnier in
401 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
402 * alloc.c (widen_to_Lisp_Object): New static function.
403 (mark_memory): Also mark Lisp_Objects by fetching pointer words
404 and widening them to Lisp_Objects. This would work even if
405 USE_LSB_TAG is defined and wide integers are used, which might
406 happen in a future version of Emacs.
407
3c9dfce6
CY
4082012-02-25 Chong Yidong <cyd@gnu.org>
409
fa74b241
CY
410 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
411 Doc fix.
412
3c9dfce6
CY
413 * xselect.c (Fx_selection_exists_p): Doc fix.
414 (x_clipboard_manager_save_all): Print an informative message
415 before saving to clipboard manager.
416
9486df08
CY
4172012-02-24 Chong Yidong <cyd@gnu.org>
418
419 * keyboard.c (process_special_events): Handle all X selection
420 requests in kbd_buffer, not just the next one (Bug#8869).
421
f01d3321
CY
4222012-02-23 Chong Yidong <cyd@gnu.org>
423
424 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
425 call when setting menu-bar-lines and tool-bar-lines parameters.
426 (unwind_create_frame_1): New helper function.
427
428 * window.c (inhibit_window_configuration_change_hook): New var.
429 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 430 (syms_of_window): Initialize it.
f01d3321 431
86b847b6
CY
4322012-02-22 Chong Yidong <cyd@gnu.org>
433
434 * xterm.c (x_draw_image_relief): Add missing type check for
435 Vtool_bar_button_margin (Bug#10743).
436
a59225b1
CY
4372012-02-21 Chong Yidong <cyd@gnu.org>
438
439 * fileio.c (Vfile_name_handler_alist): Doc fix.
440
441 * buffer.c (Fget_file_buffer): Protect against invalid file
442 handler return value.
443
310f5bd4
PE
4442012-02-20 Paul Eggert <eggert@cs.ucla.edu>
445
cb3a28cc
PE
446 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
447 when computing $valmask.
448
310f5bd4
PE
449 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
450 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
451 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
452 It's useless in that case, and it can cause problems on hosts
453 that allocate halves of EMACS_INT values separately.
454 Reported by Dan Horák. Diagnosed by Andreas Schwab in
455 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
456 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
457 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
458 it avoids undefined behavior on hosts where shifting right by more
459 than the word width has undefined behavior.
460
2375c96a
CY
4612012-02-19 Chong Yidong <cyd@gnu.org>
462
463 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
464 (Funhandled_file_name_directory, Ffile_name_as_directory)
465 (Fdirectory_file_name, Fexpand_file_name)
466 (Fsubstitute_in_file_name): Protect against invalid file handler
467 return values (Bug#10845).
468
3eb49e71
EZ
4692012-02-18 Eli Zaretskii <eliz@gnu.org>
470
471 * .gdbinit (pitx): Fix incorrect references to fields of the
472 iterator stack.
473
7b926f3f
CY
4742012-02-17 Chong Yidong <cyd@gnu.org>
475
476 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
477
11273115
PE
4782012-02-15 Paul Eggert <eggert@cs.ucla.edu>
479
480 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
481 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
482
c3a70e2b
CY
4832012-02-15 Chong Yidong <cyd@gnu.org>
484
485 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
486 marked as special. Also, starting docstrings with * is obsolete.
487
0ca43699
AS
4882012-02-13 Andreas Schwab <schwab@linux-m68k.org>
489
490 * gnutls.c (emacs_gnutls_write): Fix last change.
491
2e8f3c56
LI
4922012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
493
494 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
495 send_process.
496
af70074f
SM
4972012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
498
499 * keymap.c (Fsingle_key_description): Handle char ranges.
500
95986d52
CY
5012012-02-12 Chong Yidong <cyd@gnu.org>
502
afd83bd1
CY
503 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
504 as that creates a dangerous corner case.
505
95986d52
CY
506 * window.c (Fdelete_window_internal): Invalidate the mouse
507 highlight (Bug#9904).
508
bd7da63e
GM
5092012-02-12 Glenn Morris <rgm@gnu.org>
510
511 * xselect.c (Fx_own_selection_internal)
512 (Fx_get_selection_internal, Fx_disown_selection_internal)
513 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
514 * nsselect.m (Fx_own_selection_internal)
515 (Fx_disown_selection_internal, Fx_selection_exists_p)
516 (Fx_selection_owner_p, Fx_get_selection_internal):
517 Sync docs and argument specs with the xselect.c versions.
518
77abcbc2
LI
5192012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
520
521 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
522
90b671e2
EZ
5232012-02-11 Eli Zaretskii <eliz@gnu.org>
524
1c0ca0b7
EZ
525 * w32select.c (Fx_selection_exists_p): Sync doc string and
526 argument list with xselect.c. (Bug#10783)
527
528 * w16select.c (Fx_selection_exists_p): Sync doc string and
529 argument list with xselect.c. (Bug#10783)
90b671e2 530
49241268
GM
5312012-02-10 Glenn Morris <rgm@gnu.org>
532
533 * fns.c (Fsecure_hash): Doc fix.
534
f998bbe7 5352012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
536
537 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
538
0992bd9c
CY
5392012-02-07 Chong Yidong <cyd@gnu.org>
540
541 * buffer.c (Fbuffer_local_variables)
542 (buffer_lisp_local_variables): Handle unbound vars correctly;
543 don't let Qunbound leak into Lisp.
544
af008560
GM
5452012-02-07 Glenn Morris <rgm@gnu.org>
546
dd605cc4
GM
547 * image.c (Fimagemagick_types): Doc fix.
548
af008560
GM
549 * image.c (imagemagick-render-type): Change it from a lisp object
550 to an integer. Move the doc here from the lisp manual.
551 Treat all values not equal to 0 the same.
552
1449fa1d
CY
5532012-02-06 Chong Yidong <cyd@gnu.org>
554
555 * doc.c (store_function_docstring): Avoid applying docstring of
556 alias to base function (Bug#2603).
557
3723ec07
AS
5582012-02-04 Andreas Schwab <schwab@linux-m68k.org>
559
560 * .gdbinit (pp1, pv1): Remove redundant defines.
561 (pr): Use pp.
562
79c1cc1e
CY
5632012-02-04 Chong Yidong <cyd@gnu.org>
564
565 * nsterm.m: Declare a global (Bug#10694).
566
d7f29f8e
EZ
5672012-02-04 Eli Zaretskii <eliz@gnu.org>
568
cae07000
SM
569 * w32.c (get_emacs_configuration_options):
570 Include --enable-checking, if specified, in the return value.
d7f29f8e 571
3b95a6f9
MR
5722012-02-04 Martin Rudalics <rudalics@gmx.at>
573
574 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
575 after rounding frame sizes. (Bug#9723)
576
d6fa96a6
EZ
5772012-02-04 Eli Zaretskii <eliz@gnu.org>
578
579 * keyboard.c (adjust_point_for_property): Don't position point
580 before BEGV. (Bug#10696)
581
df0b2940
PE
5822012-02-03 Paul Eggert <eggert@cs.ucla.edu>
583
584 Handle overflow when computing char display width (Bug#9496).
585 * character.c (char_width): Return EMACS_INT, not int.
586 (char_width, c_string_width): Check for overflow when
587 computing the width; this is possible now that individual
588 characters can have unbounded width. Problem introduced
589 by merge from Emacs 23 on 2012-01-19.
590
6bee44d6
MA
5912012-02-02 Michael Albinus <michael.albinus@gmx.de>
592
593 * dbusbind.c (Fdbus_register_method): Mention the return value
594 :ignore in the docstring.
595
44f92739
GM
5962012-02-02 Glenn Morris <rgm@gnu.org>
597
1b9f60cc
GM
598 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
599
44f92739
GM
600 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
601 Unconditionally set to t. (Bug#10673)
602 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
603 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
604 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
605
c5d3843c
KH
6062012-02-02 Kenichi Handa <handa@m17n.org>
607
608 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
609 0, do not call append_composite_glyph.
610
159462d4 6112012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
612
613 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
614 NULL (Bug#6988).
615 (x_produce_glyphs): If the component of a composition is a null
616 string, set it->pixel_width to 1 to avoid zero-width glyph.
617
78cef877
EZ
6182012-02-01 Eli Zaretskii <eliz@gnu.org>
619
620 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
621 first 2 arguments are identical. This makes inserting large
622 output from a subprocess an order of magnitude faster on
623 MS-Windows, where all sbrk'ed memory is always contiguous.
624
97897668
GM
6252012-01-31 Glenn Morris <rgm@gnu.org>
626
627 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 628 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
629 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
630
31fd3586
GM
6312012-01-29 Glenn Morris <rgm@gnu.org>
632
633 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
634
0e24a8b2
CY
6352012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
636
637 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
638
cc0adcb0
CY
6392012-01-28 Chong Yidong <cyd@gnu.org>
640
641 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
642
acc28cb9
CY
6432012-01-26 Chong Yidong <cyd@gnu.org>
644
9c69cfb7
CY
645 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
646
acc28cb9
CY
647 * search.c (Fsearch_forward, Fsearch_backward): Document negative
648 repeat counts (Bug#10507).
649
48da7392
GM
6502012-01-26 Glenn Morris <rgm@gnu.org>
651
652 * lread.c (syms_of_lread): Doc fix.
653
14af5f7f
CY
6542012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
655
656 * coding.c (encode_designation_at_bol): Change return value to
657 EMACS_INT.
658
0b21c100
CY
6592012-01-25 Chong Yidong <cyd@gnu.org>
660
661 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
662
3c2907f7
CY
6632012-01-21 Chong Yidong <cyd@gnu.org>
664
665 * floatfns.c (Fcopysign): Make the second argument non-optional,
666 since nil is not allowed anyway.
667
959ad23f
AS
6682012-01-21 Andreas Schwab <schwab@linux-m68k.org>
669
670 * process.c (read_process_output): Use p instead of XPROCESS (proc).
671 (send_process): Likewise.
672
34a02f46
MR
6732012-01-19 Martin Rudalics <rudalics@gmx.at>
674
675 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
676 (Vwindow_persistent_parameters): Do not use Qstate.
677 Rewrite doc-strings.
34a02f46 678
1259009a 6792012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
680
681 * character.c (char_width): New function.
70d4fdf6
GM
682 (Fchar_width, c_string_width, lisp_string_width):
683 Use char_width (Bug#9496).
25ed9e61 684
6a6ee00d
MR
6852012-01-16 Martin Rudalics <rudalics@gmx.at>
686
687 * window.c (Vwindow_persistent_parameters): New variable.
688 (Fset_window_configuration, save_window_save): Handle persistent
689 window parameters.
690
c85efaf7
EZ
6912012-01-14 Eli Zaretskii <eliz@gnu.org>
692
693 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
694 thrashing the stack of the thread. (Bug#9087)
695
5944709e
PE
6962012-01-12 Paul Eggert <eggert@cs.ucla.edu>
697
698 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
699
e71f5d99
EZ
7002012-01-11 Eli Zaretskii <eliz@gnu.org>
701
702 * xdisp.c (rows_from_pos_range): Handle the case where the
703 highlight ends on a newline. (Bug#10464)
704 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
705 he end column for display of highlight that ends on a newline
706 before a R2L line.
707
ce316182
GM
7082012-01-11 Glenn Morris <rgm@gnu.org>
709
710 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
711 from load-path also when installation-directory is nil. (Bug#10208)
712
5b43da69
GM
7132012-01-10 Glenn Morris <rgm@gnu.org>
714
74cc8ff9
GM
715 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
716
7d8d6e4e
GM
717 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
718 Update template values to be closer to their typical values these days.
5b43da69 719
a0db8d43
EZ
7202012-01-09 Eli Zaretskii <eliz@gnu.org>
721
722 * xdisp.c (rows_from_pos_range): Accept additional argument
723 DISP_STRING, and accept any glyph in a row whose object is that
724 string as eligible for mouse highlight. Fixes mouse highlight of
725 display strings from overlays. (Bug#10464)
726
9a0115ab 7272012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 728
b9110d6a 729 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
730 * fileio.c (auto_saving_dir_umask): New static var.
731 (Fmake_directory_internal): Use it.
732 (do_auto_save_make_dir): Set it, instead of invoking chmod after
733 creating the directory. The old code temporarily assigns
734 too-generous permissions to the directory.
735 (do_auto_save_eh): Clear it.
b9110d6a 736 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
737 that the var is always cleared.
738
6c1bd3f3
EZ
7392012-01-07 Eli Zaretskii <eliz@gnu.org>
740
741 * search.c (scan_buffer): Pass character positions to
742 know_region_cache, not byte positions. (Bug#6540)
743
069d2b50
L
7442012-01-07 LynX <_LynX@bk.ru> (tiny change)
745
746 * w32.c (sys_rename): Report EXDEV when rename of a directory
747 fails because the target is on another logical disk. (Bug#10284)
748
75bf0d33
DB
7492012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
750
751 * xterm.c (x_embed_request_focus): New function.
752
753 * xterm.h: Add prototype.
754
755 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
756
1c6e5a32
GM
7572012-01-05 Glenn Morris <rgm@gnu.org>
758
759 * emacs.c (emacs_copyright): Update short copyright year to 2012.
760
651e947e
EZ
7612012-01-01 Eli Zaretskii <eliz@gnu.org>
762
763 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
764 Load gnutls_transport_set_lowat only if GnuTLS version is below
765 2.11.1.
766 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
767 GnuTLS versions below 2.11.1.
768
3778cdd8
AL
7692011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
770
771 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
772 to the doc string advising against its use for altering the way
773 windows are scrolled.
774
0e5317f7
KH
7752011-12-28 Kenichi Handa <handa@m17n.org>
776
777 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
778 coding-system ASCII compatible only when it does not produce BOM
779 on encoding (Bug#10383).
780
93d5ca1f
JD
7812011-12-26 Jan Djärv <jan.h.d@swipnet.se>
782
783 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
784 can scroll.
785 (create_and_show_popup_menu): Always use menu_position_func for
786 Gtk3 (Bug#10361).
787
ca22b785
AS
7882011-12-24 Andreas Schwab <schwab@linux-m68k.org>
789
790 * callint.c (Fcall_interactively): Don't truncate prompt string.
791
d048e1e6
EZ
7922011-12-23 Eli Zaretskii <eliz@gnu.org>
793
794 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
795 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 796 resumed from there (after widening). (Bug#10360)
d048e1e6 797
5ccaba1f
JD
7982011-12-22 Jan Djärv <jan.h.d@swipnet.se>
799
800 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
801
204ee57f
JD
8022011-12-21 Jan Djärv <jan.h.d@swipnet.se>
803
b81d40f0
JB
804 * nsterm.m (x_free_frame_resources):
805 Release f->output_data.ns->miniimage.
204ee57f
JD
806 (ns_index_color): Fix indentation. Do not retain
807 color_table->colors[i].
808
809 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
810 before returning.
811
812 * nsfns.m (x_set_background_color): Assign return value from
813 ns_index_color to face-background instead of NSColor*.
814 (ns_implicitly_set_icon_type): Fix indentation.
815 Change assignment in for loop to comparison.
816
817 * emacs.c (ns_pool): New variable.
818 (main): Assign ns_pool.
819 (Fkill_emacs): Call ns_release_autorelease_pool.
820
821 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
822 autorelease fdesc, release fdAttrs and tdict.
823 (ns_get_covering_families): Release charset.
824 (ns_findfonts): Release NSFontDescriptor created with new.
825 (ns_uni_to_glyphs): Fix indentation.
826 (setString): Release attrStr before assigning new value.
827
c803b2b7
JD
8282011-12-18 Jan Djärv <jan.h.d@swipnet.se>
829
678f4426
JD
830 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
831 and NS_IMPL_COCOA.
832 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
833 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
834
cd394be1 8352011-12-18 David Reitter <reitter@cmu.edu>
678f4426 836
5fecd5fc
JD
837 * nsterm.m (ns_term_init): Subscribe for notifications
838 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
839 to method trackingNotification in EmacsMenu.
840
841 * nsmenu.m (trackingMenu): New variable.
3771cb17 842 (trackingNotification): New method (from Aquamacs).
5fecd5fc 843 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 844 from Aquamacs (Bug#7030).
678f4426
JD
845
8462011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 847
c803b2b7
JD
848 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
849 (symbol_to_nsstring): Fix indentation.
850 (ns_symbol_to_pb): New function.
cae07000
SM
851 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
852 (Fns_rotate_cut_buffers_internal): Remove.
853 (Fns_store_selection_internal): Rename from
c803b2b7
JD
854 Fns_store_cut_buffer_internal.
855 (ns_get_foreign_selection, Fx_own_selection_internal)
856 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
857 (Fns_get_selection_internal, Fns_store_selection_internal):
858 Use ns_symbol_to_pb and check if return value is nil.
859 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
860 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
861 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
862 renamed to Sns_store_selection_internal.
863 (ns_handle_selection_request): Move code to Fx_own_selection_internal
864 and remove this function.
865 (ns_handle_selection_clear): Remove, never used.
866 (Fx_own_selection_internal): Move code from ns_handle_selection_request
867 here.
868
e1b01a3a
KB
8692011-12-17 Ken Brown <kbrown@cornell.edu>
870
871 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
872 GID is unknown (Bug#10257).
873
2adb6e85
PE
8742011-12-17 Paul Eggert <eggert@cs.ucla.edu>
875
876 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
877 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
878 which caused a build failure on GNU/Linux IA-64. This problem was
879 introduced by my 2011-10-07 patch.
880
d1d7b339
JL
8812011-12-15 Juri Linkov <juri@jurta.org>
882
883 * image.c (imagemagick_error): New function. (Bug#10112)
884 (imagemagick_load_image): Comment out `MagickSetResolution' call.
885 Use `imagemagick_error' where ImageMagick functions return
886 `MagickFalse'.
887 (Fimagemagick_types): Add `Fnreverse' to return the list in the
888 proper order.
889
100d5755
KH
8902011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
891
892 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
893 fill background (Bug#8992).
894
454592a6
MR
8952011-12-13 Martin Rudalics <rudalics@gmx.at>
896
897 * window.c (Vwindow_combination_resize)
898 (Vwindow_combination_limit): Use t instead of non-nil in
899 doc-strings.
61d4b438
MR
900 (Vrecenter_redisplay): Add first sentence of doc-string on
901 separate line.
53524d93 902 (Frecenter): Fix doc-string typo.
454592a6 903
3633e3aa
KH
9042011-12-11 Kenichi Handa <handa@m17n.org>
905
906 * coding.c (Funencodable_char_position): Pay attention to the
907 buffer text relocation (Bug#9389).
908
7b9d523a
JD
9092011-12-10 Jan Djärv <jan.h.d@swipnet.se>
910
911 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
912 gtk_init (Bug#10100).
913
b73189c6
EZ
9142011-12-10 Eli Zaretskii <eliz@gnu.org>
915
916 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
917 IT->string is nil. (Bug#10263)
918
f7dfe5d6
JD
9192011-12-10 Jan Djärv <jan.h.d@swipnet.se>
920
83faebb4
JD
921 * nsterm.h (x_free_frame_resources): Declare.
922
f7dfe5d6
JD
923 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
924 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
925
926 * nsterm.h (ns_get_defaults_value): Declare.
927
928 * nsterm.m (ns_default): Call ns_get_defaults_value.
929
7cd4e72c
EZ
9302011-12-09 Eli Zaretskii <eliz@gnu.org>
931
932 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
933 (Bug#10170)
934
b34d7317
YM
9352011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
936
937 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
938 that where the value of an _OBJC_* symbol points to is in the .bss
939 section (Bug#10240).
940
76470ad1
KH
9412011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
942
943 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 944 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 945
745fff94
KH
9462011-12-08 Kenichi Handa <handa@m17n.org>
947
948 * ftfont.c (get_adstyle_property): Fix previous change
949 (Bug#10233).
950
6e44397c
JB
9512011-12-07 Juanma Barranquero <lekktu@gmail.com>
952
953 * w32.c (init_environment): If no_site_lisp, remove site-lisp
954 dirs from the default value of EMACSLOADPATH (bug#10208).
955
7efa6272
GM
9562011-12-07 Glenn Morris <rgm@gnu.org>
957
958 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
959 installation and source directories as well. (Bug#10208)
960
f6fc4d87
CY
9612011-12-06 Chong Yidong <cyd@gnu.org>
962
963 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
964
2bf26180
GM
9652011-12-06 Glenn Morris <rgm@gnu.org>
966
967 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
968 as an error, not just -1. (Bug#10217)
969
3a6ad4f0
CY
9702011-12-05 Chong Yidong <cyd@gnu.org>
971
972 * keyboard.c (process_special_events): New function.
973 (swallow_events, Finput_pending_p): Use it (Bug#10195).
974
75a3b399
PE
9752011-12-05 Paul Eggert <eggert@cs.ucla.edu>
976
977 * coding.c (encode_designation_at_bol): Don't use uninitialized
978 local variable (Bug#9318).
979
c3c9e25e
KH
9802011-12-05 Kenichi Handa <handa@m17n.org>
981
982 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
983 return Qnil (Bug#8046, Bug#10193).
984
5eb05ea3
KH
9852011-12-05 Kenichi Handa <handa@m17n.org>
986
987 * coding.c (encode_designation_at_bol): New args charbuf_end and
988 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
989 (coding_set_source): Return how many bytes coding->source was
990 relocated.
991 (coding_set_destination): Return how many bytes
992 coding->destination was relocated.
993 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 994 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
995
9962011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
997
998 * coding.c (CODING_CHAR_CHARSET_P): New macro.
999 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
1000 macro (Bug#9318).
1001
10022011-12-05 Andreas Schwab <schwab@linux-m68k.org>
1003
1004 The following changes are to fix Bug#9318.
1005
a79703f5 1006 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
1007 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
1008 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 1009 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 1010
7dbda6df
JB
10112011-12-05 Juanma Barranquero <lekktu@gmail.com>
1012
1013 * lisp.h (process_quit_flag): Fix external declaration.
1014
6d5eb5b0
SM
10152011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
1016
1017 Don't macro-inline non-performance-critical code.
1018 * eval.c (process_quit_flag): New function.
1019 * lisp.h (QUIT): Use it.
1020
a0c3fad0
JD
10212011-12-04 Jan Djärv <jan.h.d@swipnet.se>
1022
1023 * nsfns.m (get_geometry_from_preferences): New function.
1024 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
1025
6c07aac2
AS
10262011-12-04 Andreas Schwab <schwab@linux-m68k.org>
1027
1028 * emacs.c (Qkill_emacs): Define.
1029 (syms_of_emacs): Initialize it.
1030 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
1031 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
1032 (quit_throw_to_read_char): Add parameter `from_signal'.
1033 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
1034 * lisp.h (QUIT): Call Fkill_emacs if requested.
1035
c052ead4
JD
10362011-12-03 Jan Djärv <jan.h.d@swipnet.se>
1037
1038 * widget.c (update_wm_hints): Return if wmshell is null.
1039 (widget_update_wm_size_hints): New function.
1040
1041 * widget.h (widget_update_wm_size_hints): Declare.
1042
1043 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1044 widget_update_wm_size_hints (Bug#10104).
1045
9e49252b
EZ
10462011-12-03 Eli Zaretskii <eliz@gnu.org>
1047
1048 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1049 before a newline, prepare the bidi iterator for consuming the
1050 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 1051 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 1052
02b16839
JL
10532011-12-02 Juri Linkov <juri@jurta.org>
1054
1055 * search.c (Fword_search_regexp): New Lisp function created from
1056 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1057 (Fword_search_backward, Fword_search_forward)
1058 (Fword_search_backward_lax, Fword_search_forward_lax):
1059 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1060 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1061
0068070e
SM
10622011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1063
1064 * fileio.c (Finsert_file_contents): Move after-change-function call
1065 to before the "handled:" label, since all "goto handled" appear in
1066 cases where the *-change-functions have already been properly called
1067 (bug#10117).
1068
3360a3fc
AS
10692011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1070
1071 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1072 waiting for input. (Bug#10169)
1073
73d6c093
EZ
10742011-11-30 Eli Zaretskii <eliz@gnu.org>
1075
1076 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1077 verifies glyph row's hash code--we have just reallocated the
1078 glyphs, so their contents can be complete garbage. (Bug#10164)
1079
febe6bea
JB
10802011-11-30 Juanma Barranquero <lekktu@gmail.com>
1081
1082 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1083
801a4313
EZ
10842011-11-30 Eli Zaretskii <eliz@gnu.org>
1085
1086 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1087 attributes are tested _before_ calling verify_row_hash, to protect
1088 against GCC re-ordering of the tests. (Bug#10164)
1089
2b56b87e
JD
10902011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1091
1092 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1093
1094 * xterm.c (handle_one_xevent): Only set async_visible and friends
1095 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 1096 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
1097 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1098
dbf31225
PE
10992011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1100
1101 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1102 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1103 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1104 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1105 All uses changed to use GCPRO1 etc.
1106 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1107 Revert to old implementation (i.e., before 2011-03-11).
1108
1305621b
YM
11092011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1110
1111 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1112 of scroll runs so as to avoid assigning disabled bogus rows and
1113 unnecessary graphics copy operations.
1114
8c9afb46
EZ
11152011-11-27 Eli Zaretskii <eliz@gnu.org>
1116
1117 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1118 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1119 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1120 (malloc, free, realloc, calloc): Redirect to e_* only when
1121 compiling Emacs.
1122
1123 * lisp.h (GCTYPEBITS): Move before first use.
1124 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1125 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1126 this macro definition.
1127
1128 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1129 _MSC_VER.
1130
54e9e3bf
JD
11312011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1132
6d5eb5b0
SM
1133 * gtkutil.c (xg_create_frame_widgets):
1134 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
1135 present with Gtk+ 2.0.
1136
83aca1cb
PE
11372011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1138
1139 * fileio.c (Finsert_file_contents): Undo previous change; see
1140 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1141
5b76caa4
PE
11422011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1143
1144 Rename locals to avoid shadowing.
1145 * fileio.c (Finsert_file_contents):
1146 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1147 * process.c (wait_reading_process_output):
1148 Rename inner 'proc' to 'p' to avoid shadowing.
1149 Indent for consistency with usual Emacs style.
1150
8c535114
EZ
11512011-11-25 Eli Zaretskii <eliz@gnu.org>
1152
1153 * xdisp.c (redisplay_window): If cursor row is not fully visible
1154 after recentering, and scroll-conservatively is set to a large
1155 number, scroll window by a few more lines to make the cursor fully
1156 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
1157 (start_display): Don't move to the next line if the display should
1158 start at a newline that is part of a display vector or an overlay
1159 string. (Bug#10119)
8c535114 1160
fa4fdb5c
JL
11612011-11-24 Juri Linkov <juri@jurta.org>
1162
1163 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1164 after the `MagickPingImage' call. (Bug#10112)
1165
90ec88df
CY
11662011-11-23 Chong Yidong <cyd@gnu.org>
1167
1168 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1169
56e2e794
MR
11702011-11-23 Martin Rudalics <rudalics@gmx.at>
1171
1172 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1173 making another buffer current. (Bug#10114)
1174
b6e64c41
GM
11752011-11-23 Glenn Morris <rgm@gnu.org>
1176
1177 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1178
6b21de18
CY
11792011-11-23 Chong Yidong <cyd@gnu.org>
1180
1181 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1182 using it (Bug#5984).
1183
b12cd789
EZ
11842011-11-22 Eli Zaretskii <eliz@gnu.org>
1185
1186 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1187 and header-lines, as they don't have one computed for them.
1188 (Bug#10098)
1189
1190 * .gdbinit (prow): Make displayed values more self-explaining.
1191 Add row's hash code.
1192
261b6fd4
LMI
11932011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1194
1195 * process.c (wait_reading_process_output): Fix asynchrounous
1196 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 1197 (wait_reading_process_output): Add comment and URL.
261b6fd4 1198
e7cfd277
JD
11992011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1200
1201 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1202
a9b9b7f5
CY
12032011-11-21 Chong Yidong <cyd@gnu.org>
1204
1205 * window.c (Fnext_window, Fprevious_window): Doc fix.
1206
b0d15b4f
SM
12072011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1208
1209 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1210
fe7a3057
JB
12112011-11-20 Juanma Barranquero <lekktu@gmail.com>
1212
1213 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1214
d2999b1a
MR
12152011-11-20 Martin Rudalics <rudalics@gmx.at>
1216
1217 * window.c (Fset_window_combination_limit): Rename argument
1218 STATUS to LIMIT.
1219 (Vwindow_combination_limit): Remove "status" from doc-string.
1220
d5ff9cd0
AS
12212011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1222
1223 * m/ibms390.h: Remove.
1224 * m/ibms390x.h: Don't include "ibms390.h".
1225
a5bb9bd3
SM
12262011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1227
1228 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1229 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1230
cd1181db
JB
12312011-11-20 Juanma Barranquero <lekktu@gmail.com>
1232
1233 * casetab.c (Fset_case_table):
1234 * charset.c (Fcharset_after): Fix typos.
1235
615a3b8d 12362011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 1237
17e845af
PE
1238 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1239 Otherwise, valgrind does not work on some platforms.
1240 Problem reported by Andreas Schwab in
6a0bf43d
PE
1241 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1242 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1243 is set, removing the need for VIRT_ADDRESS_VARIES.
1244 (PURE_P): Use a more-efficient implementation that needs just one
1245 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1246 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1247 to 4 (xorl, subq, cmpq, setbe).
1248 * alloc.c (pure): Always extern now, since that's the
1249 VIRT_ADDR_VARIES behavior.
1250 (PURE_POINTER_P): Use a single comparison, not two, for
1251 consistency with the new puresize.h.
1252 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1253 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1254 Remove VIRT_ADDR_VARIES no longer needed.
1255
f8fe6f96
EZ
12562011-11-19 Eli Zaretskii <eliz@gnu.org>
1257
1258 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1259 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1260 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1261 behave as if the cursor position were at the window margin.
1262
1263 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1264 and the cursor position is out of bounds, behave as if the cursor
1265 position were at the window margin. (Bug#10075)
1266
df05a53c
CY
12672011-11-18 Chong Yidong <cyd@gnu.org>
1268
1269 * window.c (Fwindow_combination_limit): Make first argument
1270 non-optional, since it is meaningless for live windows like the
1271 selected window.
1272
2071918e
DA
12732011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1274
1275 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1276
b50a28de
SM
12772011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1278
1279 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1280 (graft_intervals_into_buffer): Simplify.
1281
015137db
EZ
12822011-11-18 Eli Zaretskii <eliz@gnu.org>
1283
1284 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1285 hash values of the two rows.
1286 (copy_row_except_pointers): Preserve the used[] arrays and the
1287 hash values of the two rows. (Bug#10035)
68c95424 1288 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
1289
1290 * xdisp.c (row_hash): New function, body extracted from
1291 compute_line_metrics.
1292 (compute_line_metrics): Call row_hash, instead of computing the
1293 hash code inline.
1294
1295 * dispnew.c (verify_row_hash): Call row_hash for computing the
1296 hash code of a row, instead of duplicating code from xdisp.c.
1297
1298 * dispextern.h (row_hash): Add prototype.
1299
a2addb04
TH
13002011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1301
1302 * frame.c (delete_frame): Don't delete the terminal when the last
1303 X frame is closed if emacs is built with GTK toolkit.
1304
df85d315
JB
13052011-11-17 Juanma Barranquero <lekktu@gmail.com>
1306
1307 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1308
a0c2d0ae
MR
13092011-11-17 Martin Rudalics <rudalics@gmx.at>
1310
1311 * window.c (Vwindow_splits): Rename to
1312 Vwindow_combination_resize. Suggested by Juri Linkov.
1313 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1314 of Vwindow_splits.
1315
58179cce
JB
13162011-11-16 Juanma Barranquero <lekktu@gmail.com>
1317
7877f373
JB
1318 * nsfns.m (Fns_font_name):
1319 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 1320
b6f67890
MR
13212011-11-16 Martin Rudalics <rudalics@gmx.at>
1322
1323 * window.h (window): Rename slot "nest" to "combination_limit".
1324 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1325 (Fset_window_nest): Rename to Fset_window_combination_limit.
1326 (Vwindow_nest): Rename to Vwindow_combination_limit.
1327 (recombine_windows, make_parent_window, make_window)
1328 (Fsplit_window_internal, saved_window)
1329 (Fset_window_configuration, save_window_save): Rename all
1330 occurrences of window_nest to window_combination_limit.
1331
c7015153
JB
13322011-11-15 Juanma Barranquero <lekktu@gmail.com>
1333
1334 * image.c (imagemagick_load_image): Fix typo.
1335
322ad6ec
EZ
13362011-11-14 Eli Zaretskii <eliz@gnu.org>
1337
1338 * xdisp.c (display_line): Move the call to
1339 highlight_trailing_whitespace before the call to
1340 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
1341 faces of all the glyphs to compute ROW's hash value.
1342 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 1343
f067b8ec
JB
13442011-11-14 Juanma Barranquero <lekktu@gmail.com>
1345
1346 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1347 just return (bug#10044).
1348
1e5b2111
EZ
13492011-11-12 Eli Zaretskii <eliz@gnu.org>
1350
7ef3cbd5
EZ
1351 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1352 with user-defined heap size. Bump the default size of the temacs
1353 heap to 27MB, to avoid memory warning when running temacs.
1354 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1355
1e5b2111
EZ
1356 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1357 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
1358 (verify_row_hash) [XASSERTS]: New function.
1359 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1360 that the hash value of glyph rows is correct.
1e5b2111 1361
89d61221
MR
13622011-11-12 Martin Rudalics <rudalics@gmx.at>
1363
1364 * window.h (window): Remove splits slot.
1365 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1366 (Fdelete_other_windows_internal, make_parent_window)
1367 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1368 (Fset_window_configuration, save_window_save): Don't deal with
1369 split status of windows.
1370 (saved_window): Remove splits slot.
1371 (Vwindow_splits): Rewrite doc-string.
1372
97f18cc8
JD
13732011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1374
1375 * xfns.c (unwind_create_frame):
1376 * nsfns.m (unwind_create_frame):
1377 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1378 Vframe_list (Bug#9999).
1379
22a648b4
DA
13802011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1381
0b381c7e 1382 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 1383
659afede
KH
13842011-11-11 Kenichi Handa <handa@m17n.org>
1385
1386 * callproc.c (Fcall_process): Set the member dst_multibyte of
1387 process_coding.
1388
9ac0394b
KH
13892011-11-11 Johan Bockgård <bojohan@gnu.org>
1390
1391 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1392 avoid a crash (bug#9496).
1393
2fbdc249
CY
13942011-11-09 Chong Yidong <cyd@gnu.org>
1395
1396 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1397 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1398
ac6b1f81
PE
13992011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1400
1401 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1402
09db192c
PE
14032011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1404
1405 Avoid some portability problems by eschewing 'extern inline' functions.
1406 The trivial performance wins aren't worth the portability hassles; see
1407 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1408 et seq.
1409 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1410 (window_box_width, window_box_left, window_box_left_offset)
1411 (window_box_right, window_box_right_offset): Undo previous change,
1412 by removing the "extern"s.
1413 * intervals.c (adjust_intervals_for_insertion)
1414 (adjust_intervals_for_deletion): Undo previous change,
1415 making these static again.
1416 (offset_intervals, temp_set_point_both, temp_set_point)
1417 (copy_intervals_to_string): No longer inline.
1418 * xdisp.c (window_text_bottom_y, window_box_width)
1419 (window_box_height, window_box_left_offset)
1420 (window_box_right_offset, window_box_left, window_box_right)
1421 (window_box): No longer inline.
1422
105216ed
CY
14232011-11-08 Chong Yidong <cyd@gnu.org>
1424
1425 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
1426 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1427 Signal an error if not a live window.
105216ed
CY
1428 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1429 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1430
ae9e237f
JB
14312011-11-07 Juanma Barranquero <lekktu@gmail.com>
1432
1433 * lisp.h (syms_of_abbrev): Remove declaration.
1434 Reported by CHENG Gao <chenggao@royau.me>.
1435
c7aa8333
EZ
14362011-11-07 Eli Zaretskii <eliz@gnu.org>
1437
1438 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1439 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1440 of temacs in GUI mode.
1441
be7f5545
MR
14422011-11-07 Martin Rudalics <rudalics@gmx.at>
1443
1444 * window.h: Declare delete_all_child_windows instead of
1445 delete_all_subwindows.
1446 * window.c (Fwindow_nest, Fset_window_nest)
1447 (Fset_window_new_total, Fset_window_new_normal)
1448 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1449 (delete_all_subwindows): Rename to delete_all_child_windows.
1450 (Fdelete_other_windows_internal, Fset_window_configuration):
1451 Call delete_all_child_windows instead of delete_all_subwindows.
1452 * frame.c (delete_frame): Call delete_all_child_windows instead
1453 of delete_all_subwindows.
1454
ca78dc43
PE
14552011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1456
1457 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1458 This is also needed for porting to any host where GC_MARK_STACK is
1459 not GC_MAKE_GCPROS_NOOPS.
1460 (which_symbols): Use it.
1461
a0241d01
KH
14622011-11-07 Kenichi Handa <handa@m17n.org>
1463
1464 * coding.c (coding_set_destination): Check coding->src_pos only
1465 when coding->src_object is a buffer (bug#9910).
1466
1467 * process.c (send_process): Set the member src_multibyte of coding
1468 to 0 (bug#9911) when sending a unibyte text.
1469
1470 * callproc.c (Fcall_process): Set the member src_multibyte of
1471 process_coding to 0 (bug#9912).
1472
a64bfdfa 14732011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
1474
1475 * xmenu.c (cleanup_widget_value_tree): New function.
1476 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1477 calling free_menubar_widget_value_tree directly (Bug#9830).
1478
cb41b32a
PE
14792011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1480
1481 Fix some portability problems with 'inline'.
1482 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1483 (window_box_width, window_box_left, window_box_left_offset)
1484 (window_box_right, window_box_right_offset): Declare extern.
1485 Otherwise, these inline functions do not conform to C99 and
1486 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1487 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1488 * intervals.c (adjust_intervals_for_insertion)
1489 (adjust_intervals_for_deletion): Now extern, because otherwise the
1490 extern inline functions 'offset_intervals' couldn't refer to it.
1491 (static_offset_intervals): Remove.
1492 (offset_intervals): Rewrite using the old contents of
1493 static_offset_intervals. The old version didn't conform to C99
1494 because an extern inline function contained a reference to an
1495 identifier with static linkage.
1496
b7041366
AS
14972011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1498
1499 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1500 GC.
1501
88a37c4d
EZ
15022011-11-06 Eli Zaretskii <eliz@gnu.org>
1503
1504 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1505 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1506 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1507 return Qleft_to_right.
1508
49745b39
CY
15092011-11-06 Chong Yidong <cyd@gnu.org>
1510
1511 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1512 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1513 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1514 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1515 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1516 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1517 (Fwindow_vscroll): Doc fix.
1518 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1519 argument, since it makes no sense to pass a live window and for
1520 consistency with window-child.
1521
1f05cd82
CS
15222011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1523
1524 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1525 support MSVC.
1526
22610910
JR
15272011-11-05 Jason Rumney <jasonr@gnu.org>
1528
1529 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1530 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1531 fonts (Bug#6029).
1532 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1533 bitwise arithmetic preventing use of unicode-sip and non-truetype
1534 opentype fonts.
1535
a06776b2
EZ
15362011-11-05 Eli Zaretskii <eliz@gnu.org>
1537
3ad924ba
EZ
1538 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1539 "emacs"-only part.
1540
a06776b2
EZ
1541 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1542 initialization code to keep similarity to xfns.c after changes
1543 from 2011-11-05.
1544
c9e7db78
JD
15452011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1546
a97f8f3f
JD
1547 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1548 (unwind_create_frame): New function (Bug#9943).
1549 (Fx_create_frame): Restructure code to be more similar to the one in
1550 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1551 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1552 Move terminal->reference_count++ just before making the frame official
1553 (Bug#9943).
1554
1555 * nsterm.m (x_free_frame_resources): New function.
1556 (x_destroy_window): Move code to x_free_frame_resources.
1557
c9e7db78 1558 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
1559 (Fx_create_frame, x_create_tip_frame):
1560 Move terminal->reference_count++ just before making the frame
c9e7db78
JD
1561 official. Move initialization of image_cache_refcount and
1562 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1563
a6fc3b5c
EZ
15642011-11-05 Eli Zaretskii <eliz@gnu.org>
1565
1566 Support MSVC build with newer versions of Visual Studio.
1567 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1568 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1569 nt/gmake.defs.
1570
1571 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1572 which are not supported by MSVC.
1573 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1574 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1575 bitfields.
1576 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1577 types in bitfields.
1578 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1579
1580 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1581
58179cce 15822011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
1583
1584 Support MSVC build with newer versions of Visual Studio.
1585 * w32.c: Don't include w32api.h for MSVC.
1586 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1587
1588 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1589 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1590 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1591 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1592 e_* cousins.
1593 (alloca) [_MSC_VER]: Define to _alloca.
1594
1595 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1596
1597 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1598
a58c13ed
EZ
15992011-11-04 Eli Zaretskii <eliz@gnu.org>
1600
1601 * xdisp.c (note_mouse_highlight): If either of
1602 previous/next-single-property-change returns nil, treat that as
1603 the beginning or the end of the buffer. (Bug#9955)
1604
fe0b6370
JD
16052011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1606
a58c13ed 1607 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
1608 label is not null (Bug#9951).
1609 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1610 may be NULL.
1611
89bd5ee1
EZ
16122011-11-04 Eli Zaretskii <eliz@gnu.org>
1613
1614 * window.c (Fwindow_body_size): Mention in the doc string that the
1615 return value is in frame's canonical units. (Bug#9949)
1616
84c3edb9
EZ
16172011-11-03 Eli Zaretskii <eliz@gnu.org>
1618
4e2fb5c7
EZ
1619 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1620
84c3edb9 1621 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 1622 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 1623 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 1624
bc17a887
EZ
16252011-11-01 Eli Zaretskii <eliz@gnu.org>
1626
1627 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1628 Don't stop backward scan on the continuation glyph, even though
1629 its CHARPOS is positive.
6d5eb5b0
SM
1630 (mouse_face_from_buffer_pos, note_mouse_highlight):
1631 Rename cover_string to disp_string.
bc17a887 1632
4ee88440
MR
16332011-11-01 Martin Rudalics <rudalics@gmx.at>
1634
1635 * window.c (temp_output_buffer_show): Don't use
1636 Vtemp_buffer_show_specifiers.
1637 (Vtemp_buffer_show_specifiers): Remove unused variable.
1638
c2ff3c02
EZ
16392011-10-30 Eli Zaretskii <eliz@gnu.org>
1640
1641 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1642 past the beginning of the current glyph matrix.
1643
58179cce 16442011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
1645
1646 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1647 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1648 HAVE_GTK3 (Bug#9869).
b77a6a7f 1649
3b574623
JD
1650 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1651 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1652
b77a6a7f
JD
1653 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1654
1655 * xterm.c: Declare x_handle_net_wm_state to return int.
1656 (handle_one_xevent): Check if we are iconified but don't have
1657 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1658 (get_current_wm_state): Return non-zero if not hidden,
1659 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1660 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1661 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1662 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1663
196e41e4
PE
16642011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1665
1666 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1667 so that this new function doesn't get optimized away by a
1668 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1669
021f2e1a
AS
16702011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1671
1672 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1673
8b058d44
EZ
16742011-10-29 Eli Zaretskii <eliz@gnu.org>
1675
1676 Fix the `xbytecode' command.
1677 * .gdbinit (xprintbytestr): New command.
b50a28de 1678 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
1679 (xbytecode): Print the byte-code string as well.
1680
4452fb80
EZ
16812011-10-29 Kim Storm <storm@cua.dk>
1682
8b058d44
EZ
1683 * alloc.c (which_symbols): New function.
1684
21b72067
AS
16852011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1686
1687 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1688 line. (Bug#9903)
1689
83ed7b5c
GM
16902011-10-29 Glenn Morris <rgm@gnu.org>
1691
1692 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1693 Not clear what it was for, and it causes various bugs. (Bug#9839)
1694
5a7a728b
EZ
16952011-10-28 Eli Zaretskii <eliz@gnu.org>
1696
1697 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1698 possible random value that matches one of those tested as
1699 condition to clear the mouse face.
1700
d3d0842f
CY
17012011-10-28 Chong Yidong <cyd@gnu.org>
1702
1703 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1704
31b39d13
DN
17052011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1706
1707 * window.c (make_window): Initialize phys_cursor_on_p.
1708
9aba6043
SM
17092011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1710
1711 * lisp.h (struct Lisp_Symbol): Update comments.
1712
c20992f4
JB
17132011-10-28 Juanma Barranquero <lekktu@gmail.com>
1714
1715 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1716
db4f02f2
EZ
17172011-10-28 Eli Zaretskii <eliz@gnu.org>
1718
1719 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1720 <oslsachem@gmail.com> for helping to debug this.
1721
1722 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1723 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1724 (g_b_init_get_glyph_outline_w): New static variables.
1725 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1726 (GetGlyphOutlineW_Proc): New typedefs.
1727 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
1728 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1729 New functions.
1730 (w32font_open_internal, compute_metrics):
1731 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
1732 instead of calling the "wide" APIs directly.
1733
1734 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1735
1736 * w32.h (syms_of_w32font): Add prototype.
1737
87e68db4
JB
17382011-10-27 Juanma Barranquero <lekktu@gmail.com>
1739
1740 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1741 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1742 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1743 (Fmove_to_window_line): Doc fix.
1744
435c1d67
CY
17452011-10-27 Chong Yidong <cyd@gnu.org>
1746
1747 * process.c (make_process): Set gnutls_state to NULL.
1748
1749 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1750 non-NULL, regardless of GNUTLS_INITSTAGE.
1751 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1752 an error. Set process slots as soon as we allocate them.
1753
1754 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1755
9c6c6f49
CY
17562011-10-27 Chong Yidong <cyd@gnu.org>
1757
9aba6043
SM
1758 * gnutls.c (emacs_gnutls_deinit): New function.
1759 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
1760 (Fgnutls_deinit, Fgnutls_boot): Use it.
1761
1762 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1763 (deactivate_process): Call emacs_gnutls_deinit.
1764
657d08d3
JB
17652011-10-27 Juanma Barranquero <lekktu@gmail.com>
1766
1767 * image.c (x_create_x_image_and_pixmap):
1768 * w32.c (sys_rename, w32_delayed_load):
1769 * w32font.c (fill_in_logfont):
1770 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1771
5430d399
JB
17722011-10-26 Juanma Barranquero <lekktu@gmail.com>
1773
1774 * w32fns.c (w32_default_color_map): New function,
1775 extracted from Fw32_default_color_map.
a7ef684b 1776 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 1777
fe0055fa
PE
17782011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1779
1780 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1781
e6346438
SM
17822011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1783
1784 * keyboard.c (test_undefined): New function (bug#9751).
1785 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1786
e112cc37
ET
17872011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1788
1789 * sysdep.c (init_sys_modes): Fix the check for the controlling
1790 terminal (Bug#6649).
1791
7b5d6677
EZ
17922011-10-20 Eli Zaretskii <eliz@gnu.org>
1793
1794 * dispextern.h (struct bidi_it): New member next_en_type.
1795
1796 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1797 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1798 current character, check also for next_en_type being WEAK_EN.
1799 (bidi_resolve_weak): Don't enter the expensive loop if the current
1800 position is before next_en_pos. Record the bidi type of the first
1801 non-ET, non-BN character we find, in addition to its position.
1802 (bidi_level_of_next_char): Invalidate next_en_type when
1803 next_en_pos is over-stepped.
1804
7da0b018
PE
18052011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1806
1807 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1808 * editfns.c: Rewrite current-time-zone so that it invokes
1809 the equivalent of (format-time-string "%Z") to get the time zone name.
1810 This fixes a bug when the time zone name contains characters that
1811 need converting from the system time locale to Emacs internal format.
1812 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1813 that patch fixed format-time-string to do the conversion, but
1814 I forgot to fix current-time-zone.
1815 (format_time_string): New function, containing most of
1816 what Fformat_time_string used to contain.
1817 (Fformat_time_string): Rewrite in terms of format_time_string.
1818 This doesn't change this function's behavior.
1819 (current-time-zone): Rewrite to use format_time_string.
1820 This fixes the bug reported by Michael Schierl in
1821 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1822 Jason Rumney's 2007-06-07 change worked around this bug, but
1823 didn't fix it.
1824 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1825
8547b010
EZ
18262011-10-19 Eli Zaretskii <eliz@gnu.org>
1827
1828 * xdisp.c (start_display): If the character at POS is displayed
1829 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
1830 (try_window_reusing_current_matrix): If a line ends in a display
1831 vector or the next line starts in a display vector, continue
1832 redrawing the window even though the character position of
1833 start_row was reached.
8547b010
EZ
1834 (Bug#9771, part 2)
1835
4e948d15
CY
18362011-10-18 Chong Yidong <cyd@gnu.org>
1837
1838 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1839 with nobreak-char-display too.
1840
4787455f
EZ
18412011-10-18 Eli Zaretskii <eliz@gnu.org>
1842
1843 Fix part 3 of bug#9771.
1844 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1845 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1846 non-neutral characters if the current character is a paragraph
1847 separator (a.k.a. Newline). This avoids running the same
1848 expensive loop twice, once when we consume the preceding newline
1849 and the other time when the line actually needs to be displayed.
1850 Avoid the loop when we see neutrals on the base embedding level
1851 following a character whose directionality is the same as the
1852 paragraph's. This avoids running the expensive loop when a line
1853 ends in a long sequence of neutrals, like control characters.
1854 Add assertion against STRONG_AL type. Slightly rearrange code
1855 that determines the type of a neutral given the first non-neutral
1856 that follows it.
1857 (bidi_level_of_next_char): Set next_en_pos to zero when
1858 invalidating its info.
1859
2c91f553
EZ
18602011-10-17 Eli Zaretskii <eliz@gnu.org>
1861
1862 * xdisp.c (push_display_prop): Determine whether to record string
1863 or buffer position by IT->string, not by IT->method. Allow
1864 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
1865 (move_it_vertically_backward): Don't look for character position
1866 immediately after the newline when in a continuation line.
1867 (Bug#9771, part 1)
2c91f553 1868
c7b08b0d
MR
18692011-10-15 Martin Rudalics <rudalics@gmx.at>
1870
1871 * window.c (coordinates_in_window): Rewrite and delabelize
1872 vertical border check. (Bug#5357) (Bug#9618)
1873
6b02f655
SM
18742011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1875
1876 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1877 errors in XSetWindowBorder (bug#9310).
1878
81d40c92
DA
18792011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1880
1881 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1882 avoid crash when xmalloc overrun checking is enabled.
1883
d4172c3b
EZ
18842011-10-13 Eli Zaretskii <eliz@gnu.org>
1885
1886 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1887 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1888 cursor motion with <left> and <right> arrow keys.
1889
1890 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1891 some callers set that themselves.
1892
b00eea75
EZ
18932011-10-12 Eli Zaretskii <eliz@gnu.org>
1894
1895 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1896 display string and the previous row comes from the same string and
1897 is empty. (Bug#9739) (Bug#9738)
1898
8fe012c4
SM
18992011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1900
1901 * doc.c (get_doc_string): Encode file name (bug#9735).
1902
0074aef2
EZ
19032011-10-12 Eli Zaretskii <eliz@gnu.org>
1904
79beb178
EZ
1905 * bidi.c (bidi_level_of_next_char):
1906 * xdisp.c (get_visually_first_element): Remove old incorrect
1907 comments regarding the Unicode Line Separator character.
1908
0074aef2
EZ
1909 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1910
6e4b3fbe
DA
19112011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1912
1913 * alloc.c (Fgc_status): Do not access beyond zombies array
1914 boundary if nzombies > MAX_ZOMBIES.
1915 * alloc.c (dump_zombies): Add missing format specifier.
1916
0324f3af
PE
19172011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1918
b5525cac
PE
1919 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1920 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1921
0324f3af
PE
1922 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1923 Some packages use them to denote characters with modifiers.
1924
e9b5f888
AS
19252011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1926
1927 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1928 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1929 matching a pp-number. Rename parameter var to var1.
1930
127827c0
SM
19312011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1932
1933 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1934
c8fd3bd0
GM
19352011-10-08 Glenn Morris <rgm@gnu.org>
1936
1937 * callint.c (Fcall_interactively): Give a more explicit error for the
1938 'c' case with a non-character input. (Bug#8479)
1939
352ec8ff
EZ
19402011-10-08 Eli Zaretskii <eliz@gnu.org>
1941
03669ccb
EZ
1942 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1943 lines.
7061c986
EZ
1944 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1945 lines that are hscrolled on the left.
03669ccb 1946
352ec8ff
EZ
1947 * dispnew.c (buffer_posn_from_coords): Account for a possible
1948 presence of header-line. (Bug#4426)
1949
a66cfb1c
SM
19502011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1951
6b02f655
SM
1952 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1953 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 1954
7c5ee88e
PE
19552011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1956
1957 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1958 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1959 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1960 this makes Emacs dump core during garbage collection on rare
1961 occasions. sizeof is obviously inferior to offsetof here, so
1962 stick with offsetof.
1963 (GC_POINTER_ALIGNMENT): New macro.
1964 (mark_memory): Omit 3rd (offset) arg; caller changed.
1965 Don't assume EMACS_INT alignment is the same as pointer alignment.
1966
df1bbe5b
SM
19672011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1968
1969 * keyboard.c (read_key_sequence_remapped): New var.
1970 (read_key_sequence): Compute remapping in the right buffer.
1971 (command_loop_1): Use read_key_sequence's remapping directly.
1972
51553db6
SM
19732011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1974
32c1fffd
SM
1975 * dired.c (file_name_completion): Don't expand file name.
1976 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1977 before checking file name handler.
1978
51553db6
SM
1979 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1980 they've been requested explicitly (bug#9591).
1981
b6bd1599 19822011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
1983
1984 * keymap.c (Fsingle_key_description): Use make_specified_string
1985 instead of build_string to build string from push_key_description.
1986 (Bug#5193)
1987
f701dc2a
PE
19882011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1989
4222c55d
PE
1990 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1991 This fixes a Y2038 bug on 64-bit hosts.
1992 * buffer.c (reset_buffer):
1993 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1994 (Fclear_buffer_auto_save_failure):
1995 Use 0, not -1, to represent an unset failure time, since time_t
1996 might not be signed.
1997
f701dc2a
PE
1998 Remove dependency on glibc malloc internals.
1999 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2000 Move back here from lisp.h, but with their new implementations.
2001 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2002 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
2003 * charset.c (charset_table_init): New static var.
2004 (syms_of_charset): Use it instead of xmalloc. This removes a
2005 dependency on glibc malloc internals. See Eli Zaretskii's comment in
2006 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
2007 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2008 Move back to alloc.c.
2009 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2010 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
2011
9ceebf39
JD
20122011-09-30 Jan Djärv <jan.h.d@swipnet.se>
2013
2014 * nsterm.m (windowDidResize): Call x_set_window_size only when
2015 ns_in_resize is true. Otherwise set pixelwidth/height and
2016 call change_frame_size (Bug#9628).
2017
cb993c58
PE
20182011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2019
3930c88b
PE
2020 Port --enable-checking=all to Fedora 14 x86-64.
2021 * charset.c (syms_of_charset): Also account for glibc malloc's
2022 internal overhead when calculating the initial malloc maximum.
2023
cb993c58
PE
2024 Port --enable-checking=all to Fedora 14 x86.
2025 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2026 Move to lisp.h.
2027 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
2028 (overrun_check_realloc, overrun_check_free):
2029 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
2030 That way, xmalloc returns a properly-aligned pointer even if
2031 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
2032 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
2033 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
2034 into account when calculating the initial malloc maximum.
2035 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2036 Move here from alloc.c, so that charset.c can use it too.
2037 Properly align; the old code wasn't right for common 32-bit hosts
2038 when configured with --enable-checking=all.
2039 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2040 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2041
31bed486
EZ
20422011-09-29 Eli Zaretskii <eliz@gnu.org>
2043
04c70788 2044 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
2045 use EDOM.
2046
fbcaa2f3
EZ
20472011-09-28 Eli Zaretskii <eliz@gnu.org>
2048
2049 * xdisp.c (compute_display_string_end): If there's no display
2050 string at CHARPOS, return -1.
2051
2052 * bidi.c (bidi_fetch_char): When compute_display_string_end
2053 returns a negative value, treat the character as a normal
2054 character not covered by a display string. (Bug#9624)
2055
a239d4e9
JB
20562011-09-28 Juanma Barranquero <lekktu@gmail.com>
2057
2058 * lread.c (Fread_from_string): Fix typo in docstring.
2059
88652fd5
EZ
20602011-09-27 Eli Zaretskii <eliz@gnu.org>
2061
2062 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2063 newline, reseat the iterator instead of bidi-iterating there one
2064 character at a time. (Bug#9610)
32c1fffd
SM
2065 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2066 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 2067
ed497dd4
AS
20682011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2069
2070 * lread.c (readevalloop): Use correct code for NBSP.
2071 (read1): Likewise. (Bug#9608)
2072
b2bf61aa
MA
20732011-09-25 Michael Albinus <michael.albinus@gmx.de>
2074
2075 * dbusbind.c (Fdbus_register_signal): When service is not
2076 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2077
32bbb17c
GM
20782011-09-25 Glenn Morris <rgm@gnu.org>
2079
2080 * buffer.c (truncate-lines): Doc fix.
2081
94e0933e
CY
20822011-09-24 Chong Yidong <cyd@stupidchicken.com>
2083
2084 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2085 (Fset_window_next_buffers): Doc fix.
2086
cddde921
GM
20872011-09-24 Glenn Morris <rgm@gnu.org>
2088
2089 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2090
1260aef1
PE
20912011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2092
25b4bfa0
PE
2093 Fix minor problems found by static checking.
2094 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
2095 * indent.c (Fvertical_motion): Fix == vs = typo.
2096
e3cbd34b
EZ
20972011-09-24 Eli Zaretskii <eliz@gnu.org>
2098
a66cfb1c
SM
2099 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2100 Default value is now t. Doc fix.
6bf7006f 2101
e3cbd34b 2102 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 2103 logic when moving up, not only when moving down. Fix the
e3cbd34b 2104 confusing name and values of the it_overshoot_expected variable;
32c1fffd 2105 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
2106
2107 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2108 CHARPOS is covered by a display string which includes newlines.
2109 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2110 is covered by a display string with embedded newlines.
2111
a3de0cbd
MA
21122011-09-24 Michael Albinus <michael.albinus@gmx.de>
2113
2114 * dbusbind.c (Fdbus_register_signal): Add match rule to
2115 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
2116 (Fdbus_register_method, Vdbus_registered_objects_table):
2117 Fix docstring.
a3de0cbd 2118
b260039d
JM
21192011-09-24 Jim Meyering <meyering@redhat.com>
2120
32c1fffd 2121 do not ignore write error for any output size
b260039d
JM
2122 The previous change was incomplete.
2123 While it makes emacs --batch detect the vast majority of stdout
2124 write failures, errors were still ignored whenever the output size is
2125 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2126 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2127 && echo FAIL: ignored write error
2128 FAIL: ignored write error
2129 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2130 && echo FAIL: ignored write error
2131 FAIL: ignored write error
2132 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2133
8eca8a7c
AS
21342011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2135
2136 * emacs.c (Fkill_emacs): In noninteractive mode exit
2137 non-successfully if a write error occurred on stdout. (Bug#9574)
2138
3341db62
EZ
21392011-09-21 Eli Zaretskii <eliz@gnu.org>
2140
2141 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2142 the xassert test.
2143
2144 * dispextern.h (struct it): Update the comment documenting what
2145 can it->OBJECT be.
2146
8c203dbf
EZ
21472011-09-20 Eli Zaretskii <eliz@gnu.org>
2148
2149 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2150 a display string, extend search for cursor position to end of row.
2151 (find_row_edges): If the row ends in a newline from a display
2152 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2153 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
2154 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2155 non-empty line. Fixes confusing cursor motion with arrow keys at
2156 the beginning of a line that starts with whitespace.
8c203dbf 2157
a4824228
LMI
21582011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2159
2160 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2161 (bug#9493).
2162
33ed493b
CY
21632011-09-18 Chong Yidong <cyd@stupidchicken.com>
2164
2165 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2166 boolean (Bug#9154).
2167
56cd55c8
EZ
21682011-09-18 Eli Zaretskii <eliz@gnu.org>
2169
2170 * xdisp.c (display_line): Record maximum and minimum buffer
2171 positions even if no glyphs were produced (e.g., by a zero-width
2172 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2173 buffer positions that will be removed from the glyph row because
2174 they don't fit.
c02dcedf
EZ
2175 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2176 column is beyond frame width: don't subtract 1 "pixel" when
2177 computing width of the stretch.
3e62b7e0
EZ
2178 (reseat_at_next_visible_line_start): Undo the change made on
2179 2011-09-17 that saved paragraph information and restored it after
2180 the call to `reseat'. (Bug#9545)
56cd55c8 2181
5ed99d36 21822011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
2183
2184 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2185 and turn window cursor on if cleared (Bug#9415).
2186
5ed99d36 21872011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
2188
2189 * search.c (boyer_moore): Take unibyte characters from pattern
2190 literally. (Bug#9458)
2191
9bade7b2
EZ
21922011-09-18 Eli Zaretskii <eliz@gnu.org>
2193
2194 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2195
e5e9d610
PE
21962011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2197
87e4427a
PE
2198 Fix minor problem found by static checking.
2199 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2200 initialized, to pacify gcc -Wuninitialized.
2201
e5e9d610
PE
2202 * fileio.c: Report proper errno when syscall falls.
2203 (Finsert_file_contents): Save and restore errno,
2204 so that report_file_error outputs the correct diagnostic.
2205 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2206
a1674f0b
EZ
22072011-09-18 Eli Zaretskii <eliz@gnu.org>
2208
2209 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2210
fbfb6dd4
EZ
22112011-09-17 Eli Zaretskii <eliz@gnu.org>
2212
2213 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2214 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2215
bb187662
EZ
22162011-09-17 Eli Zaretskii <eliz@gnu.org>
2217
1137e8b8 2218 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 2219 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
2220
2221 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2222 (bidi_find_paragraph_start): Search back for paragraph beginning
2223 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2224 (bidi_move_to_visually_next): Only trigger paragraph-related
2225 computations when the last character is a newline or at EOB, not
2226 just any NEUTRAL_B. (Bug#9470)
2227
bb187662
EZ
2228 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2229 truncated lines if point is covered by a display string. (Bug#9524)
2230
2e621251
PE
22312011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2232
2233 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2234 (cons_to_x_long): New function.
2235 (lisp_data_to_selection_data): Use it. Correct the test for
2236 short-versus-long data; it was negated. Break out of vector
2237 loop, for efficiency, when a long datum is discovered.
2238
91a15bc6
SM
22392011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2240
2241 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2242
b41c3a35
EZ
22432011-09-16 Eli Zaretskii <eliz@gnu.org>
2244
2245 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2246 GCC PR/17406) by declaring this function with external scope.
2247
7812ba2d
PE
22482011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2249
2250 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2251 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2252
cf7edc2a
AS
22532011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2254
2255 * editfns.c (Fformat): Correctly handle text properties on "%%".
2256
bd01620e
EZ
22572011-09-15 Eli Zaretskii <eliz@gnu.org>
2258
2259 * xterm.c (x_draw_composite_glyph_string_foreground):
2260 * w32term.c (x_draw_composite_glyph_string_foreground):
2261 * term.c (encode_terminal_code):
2262 * composite.c (composition_update_it, get_composition_id):
2263 * xdisp.c (get_next_display_element)
2264 (fill_composite_glyph_string): Add comments about special meaning
2265 of TAB characters in a composition.
2266
a02719a3
PE
22672011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2268
2269 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
2270 This occurs when processing a multibyte format.
2271 Problem reported by Wolfgang Jenker.
a02719a3 2272
72589a3c
JB
22732011-09-15 Johan Bockgård <bojohan@gnu.org>
2274
2275 * xdisp.c (try_cursor_movement): Only check for exact match if
2276 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2277
1c14176c
PE
22782011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2279
2280 Remove unused external symbols.
2281 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2282 * xdisp.c (calc_pixel_width_or_height): Now static.
2283 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2284 * indent.c (check_display_width):
2285 * w32term.c: Fix comment to match code.
2286 * xterm.c, xterm.h (x_catching_errors): Remove.
2287
d2eea5b5
PE
22882011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2289
2290 * xselect.c: Use signed conversions more consistently (Bug#9498).
2291 (selection_data_to_lisp_data): Assume incoming selection data are
2292 signed integers, not unsigned. This is to be consistent with
2293 outgoing selection data, which was modified to use signed integers
2294 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2295 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2296 expects long, not unsigned long.
2297
46888499
EZ
22982011-09-14 Eli Zaretskii <eliz@gnu.org>
2299
2300 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2301 computation of loop end. Reported by Johan Bockgård
2302 <bojohan@gnu.org>.
2303
ef8ef9fb
CY
23042011-09-13 Chong Yidong <cyd@stupidchicken.com>
2305
2306 * frame.c (Fother_visible_frames_p): Function deleted.
2307
fa819fed
EZ
23082011-09-12 Eli Zaretskii <eliz@gnu.org>
2309
2310 * indent.c (compute_motion): Process display vector front to back
2311 rather than the other way around. (Bug#2496)
2312
2ba8e008
SM
23132011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2314
2315 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2316
20f53c69
CY
23172011-09-11 Chong Yidong <cyd@stupidchicken.com>
2318
2319 * minibuf.c (Fread_from_minibuffer): Doc fix.
2320
d562d7a4
EZ
23212011-09-11 Eli Zaretskii <eliz@gnu.org>
2322
2323 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2324 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2325
1c4d7f3d
LMI
23262011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2327
2328 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2329 value for non-existent files.
2330
b885bf36
EZ
23312011-09-11 Eli Zaretskii <eliz@gnu.org>
2332
2333 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2334 set its "size" to -1. This will set the modtime_size field of
2335 the corresponding buffer to -1, which is what
2336 verify-visited-file-modtime expects for files that do not exist.
2337 (Bug#9139)
2338
6612f0bf
PE
23392011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2340
2341 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2342 here ...
2343 * lisp.h: ... from here. push_key_description is no longer
2344 defined in keyboard.c, so its declaration should not be in
2345 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2346 logically belongs with push_key_description.
2347
dfb3f755
PE
23482011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2349
2350 * buffer.h: Include <sys/types.h> instead of <time.h>.
2351 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2352 Problem reported by Herbert J. Skuhra.
2353
3134906c
LMI
23542011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2355
2356 * xml.c (parse_region): Make the parsing work for
2357 non-comment-starting XML files again (bug#9144).
2358
8d903f4e
AS
23592011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2360
2361 * image.c (gif_load): Fix calculation of bottom and right corner.
2362 (Bug#9468)
2363
80ad64f4
EZ
23642011-09-10 Eli Zaretskii <eliz@gnu.org>
2365
2366 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2367 redisplay in small windows.
2368
208a048d
EZ
23692011-09-09 Eli Zaretskii <eliz@gnu.org>
2370
2371 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2372
9b1c252e
MR
23732011-09-08 Martin Rudalics <rudalics@gmx.at>
2374
2375 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2376 Operate on live windows only.
2377
2949f33b
JB
23782011-09-08 Juanma Barranquero <lekktu@gmail.com>
2379
2380 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2381
e08dcafd
EZ
23822011-09-07 Eli Zaretskii <eliz@gnu.org>
2383
2384 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2385 only under bidi iteration.
2386
115b96bd
JD
23872011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2388
2389 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2390
c8199d0f
PE
23912011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2392
2393 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2394 Without this fix, the command to link temacs failed due to an
2395 undefined symbol __builtin_isnan. This is because
2396 /usr/include/iso/math_c99.h #defines isnan(x) to
2397 __builtin_isnan(x), but the bundled gcc, which identifies itself
2398 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2399 a __builtin_isnan.
2400 * floatfns.c (isnan): #undef, and then #define to a clone of
2401 what's in data.c.
2402 (Fisnan): Always define, since it's always available now.
2403 (syms_of_floatfns): Always define isnan at the Lisp level.
2404
e39b275c 24052011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
2406
2407 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2408
b2db44d9 24092011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 2410
f4af5137 2411 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
2412 The previous code assumed that file offsets (off_t values) fit in
2413 EMACS_INT variables, which is not true on typical 32-bit hosts.
2414 The code messed up by falsely reporting buffer overflow in cases
2415 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2416 when "big" contains more than 2**29 bytes, even though this
2417 inserts just one byte and does not overflow the buffer.
2418 (Finsert_file_contents): Store file offsets as off_t
2419 values, not as EMACS_INT values. Check for overflow when
2420 converting between EMACS_INT and off_t. When checking for
2421 buffer overflow or for overlap, take the offsets into account.
2422 Don't use EMACS_INT for small values where int suffices.
2423 When checking for overlap, fix a typo: ZV was used where
2424 ZV_BYTE was intended.
2425 (Fwrite_region): Don't assume off_t fits into 'long'.
2426 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2427
ecfc0a49
MA
24282011-09-05 Michael Albinus <michael.albinus@gmx.de>
2429
2430 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2431
6511acf2 24322011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 2433
0999621a 2434 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
2435
2436 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 2437 (esprintf, exprintf, evxprintf): New functions.
62f19c19 2438 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 2439 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
2440 (modify_event_symbol): Do not assume that the length of
2441 name_alist_or_stem is safe to alloca and fits in int.
2442 (Fexecute_extended_command): Likewise for function name and binding.
2443 (Frecursion_depth): Wrap around reliably on integer overflow.
2444 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2445 since some callers pass EMACS_INT values.
2446 (Fsingle_key_description): Don't crash if symbol name contains more
2447 than MAX_ALLOCA bytes.
2448 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2449 (get_minibuffer): Arg is now EMACS_INT, not int.
2450 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 2451 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
2452 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2453
2be7d702
PE
2454 * dbusbind.c (signature_cat): New function.
2455 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
2456 Do not overrun buffer; instead, report string overflow.
2457
9d1df220
PE
2458 * dispnew.c (add_window_display_history): Don't overrun buffer.
2459 Truncate instead; this is OK since it's just a log.
2460
33ef5c64
PE
2461 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2462 even if the time zone offset is outlandishly large.
2463 Don't mishandle offset == INT_MIN.
2464
66c6fdd5
PE
2465 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2466 when creating daemon; the previous buffer-overflow check was incorrect.
2467
d749b01b
PE
2468 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2469 which has the guts of the old verror function.
2470
b5cd1905
PE
2471 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2472 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2473
6e1a67fb
PE
2474 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2475 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 2476 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 2477 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
2478 length of string rather than counting it via multiple sprintfs;
2479 that's simpler and more reliable.
c21721cc
PE
2480 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2481 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2482 sprintf, in case result does not fit in int.
2483
c57b67fc
PE
2484 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2485 (fontset_from_font): Print it.
2486
8a401434
PE
2487 * frame.c (tty_frame_count): Now printmax_t, not int.
2488 (make_terminal_frame, set_term_frame_name): Print it.
2489 (x_report_frame_params): In X, window IDs are unsigned long,
2490 not signed long, so print them as unsigned.
2491 (validate_x_resource_name): Check for implausibly long names,
2492 and don't assume name length fits in 'int'.
2493 (x_get_resource_string): Don't blindly alloca invocation name;
2494 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2495 not fit in int.
2496
6e1a67fb
PE
2497 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2498 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
2499 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2500
0df02bf3
PE
2501 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2502 Use esprintf, not sprintf, in case result does not fit in int.
2503
48e30793
PE
2504 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2505 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2506 it as a large positive number.
2507 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2508 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2509
a66ff6d8
PE
2510 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2511 in case result does not fit in int.
2512
aca216ff
PE
2513 * print.c (float_to_string): Detect width overflow more reliably.
2514 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2515 buffer overrun. Don't assume list length fits in 'int'. Treat
2516 print length of 0 as 0, not as infinity; to be consistent with other
2517 uses of print length in this function. Don't overflow print length
2518 index. Don't assume hash table size fits in 'long', or that
2519 vectorlike size fits in 'unsigned long'.
2520
31c286f7
PE
2521 * process.c (make_process): Use printmax_t, not int, to format
2522 process-name gensyms.
2523
55e5faa1
PE
2524 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2525
80f2e268
PE
2526 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2527 to avoid potential buffer overrun.
2528
670741ab
PE
2529 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2530 if X resource line is longer than 512 bytes.
2531
b7163a50
PE
2532 * xfns.c (x_window): Make sprintf buffer a bit bigger
2533 to avoid potential buffer overrun.
2534
ae58ff1f
PE
2535 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2536
c43c8a6a
PE
2537 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2538
3f8236f4
PE
25392011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2540
53e9fe90 2541 Integer overflow fixes for scrolling, etc.
6511acf2
PE
2542 Without these, Emacs silently mishandles large integers sometimes.
2543 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
2544 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2545
6511acf2
PE
2546 * xdisp.c (try_window_id): Check Emacs fixnum range before
2547 converting to 'int'.
806add1d 2548
6511acf2 2549 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
2550 Check that an Emacs fixnum is in range before assigning it to 'int'.
2551 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2552 values converted from Emacs fixnums.
2553 (Frecenter): Don't wrap around a line count if it is out of 'int'
2554 range; instead, treat it as an extreme value.
2555 (Fset_window_configuration, compare_window_configurations):
2556 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2557
6511acf2
PE
2558 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2559 that can exceed INT_MAX. Check that EMACS_INT value is in range
2560 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
2561 (match_limit): Don't assume that a fixnum can fit in 'int'.
2562
6511acf2 2563 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
2564 exceed INT_MAX.
2565
6511acf2 2566 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
2567 (Fvertical_motion): Don't wrap around LINES values that don't fit
2568 in 'int'. Instead, treat them as extreme values. This is good
2569 enough for windows, which can't have more than INT_MAX lines anyway.
2570
fcb901a7
LMI
25712011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2572
0f2f6b6d
LMI
2573 * Require libxml/parser.h to avoid compilation warning.
2574
fcb901a7
LMI
2575 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2576
2577 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2578 since this reportedly can destroy thread storage.
2579
6e20a0d4
CY
25802011-08-30 Chong Yidong <cyd@stupidchicken.com>
2581
2582 * syntax.c (find_defun_start): Update all cache variables if
2583 exiting early (Bug#9401).
2584
148ae00e
EZ
25852011-08-30 Eli Zaretskii <eliz@gnu.org>
2586
f6cfbd8f
EZ
2587 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2588
148ae00e
EZ
2589 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2590 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2591 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2592
2593 * term.c (tty_append_glyph): New function.
2594 (produce_stretch_glyph): Static function and its prototype deleted.
2595
a66cfb1c
SM
2596 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2597 Add prototypes.
148ae00e 2598
c4a07a4c
PE
25992011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2600
2601 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2602 when checking :margin (Bug#9390).
2603 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 2604 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
2605 so that the name doesn't mislead. All uses changed.
2606
6bc8cd65
JB
26072011-08-28 Johan Bockgård <bojohan@gnu.org>
2608
2609 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2610 set_tty_hooks.
2611
dca4927e
EZ
26122011-08-27 Eli Zaretskii <eliz@gnu.org>
2613
2614 * xdisp.c (move_it_to): Don't bail out early when reaching
2615 position beyond to_charpos, if we are scanning backwards.
2616 (move_it_vertically_backward): When DY == 0, make sure we get to
2617 the first character in the line after the newline.
2618
f2cad773
PE
26192011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2620
2621 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2622 (ccl_driver): Do not generate an out-of-range pointer.
2623 (Fccl_execute_on_string): Remove unnecessary check for
2624 integer overflow, noted by Stefan Monnier in
2625 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2626 Remove a FIXME that didn't need fixing.
2627 Simplify the newly-introduced buffer reallocation code.
2628
0cae2cdb
JB
26292011-08-27 Juanma Barranquero <lekktu@gmail.com>
2630
2631 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2632
5fc295a4 26332011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 2634
70c60eb2 2635 Integer and memory overflow issues (Bug#9196).
726e0ab1 2636
d31850da
PE
2637 * doc.c (get_doc_string): Rework so that
2638 get_doc_string_buffer_size is the actual buffer size, rather than
2639 being 1 less than the actual buffer size; this makes xpalloc more
2640 convenient.
2641
a69fbedb
PE
2642 * image.c (x_allocate_bitmap_record, cache_image):
2643 * xselect.c (Fx_register_dnd_atom):
2644 Simplify previous changes by using xpalloc.
2645
fe5c5d37
PE
2646 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2647 since either will do and ptrdiff_t is convenient with xpalloc.
2648
0065d054
PE
2649 * charset.c (charset_table_size)
2650 (struct charset_sort_data.priority): Now ptrdiff_t.
2651 (charset_compare): Don't overflow if priorities differ greatly.
2652 (Fsort_charsets): Don't assume list length fits in int.
2653 Check for size-calculation overflow when allocating sort data.
2654 (syms_of_charset): Allocate an initial charset table that is
2655 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2656
2657 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2658
2659 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2660 The actual value is always <= INT_MAX, and leaving it unsigned made
2661 overflow checking harder.
2662
2663 * dispextern.h (struct glyph_matrix.rows_allocated)
2664 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2665 with xpalloc. The values are still always <= INT_MAX.
2666
2667 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2668
2669 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2670 (SAFE_NALLOCA): New macro.
2671
2672 * region-cache.c (struct boundary.pos, find_cache_boundary)
2673 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2674 (set_cache_region, invalidate_region_cache)
2675 (revalidate_region_cache, know_region_cache, region_cache_forward)
2676 (region_cache_backward, pp_cache):
2677 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2678 so that ptrdiff_t * can be passed to xpalloc.
2679 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2680 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2681 (pp_cache): Don't assume cache_len fits in int.
2682 * region-cache.h: Adjust extern decls to match.
2683
2684 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2685 EMACS_INT, since either will do, for xpalloc.
2686
2687 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2688 (xnmalloc, xnrealloc, xpalloc): New functions.
2689
726e0ab1
PE
2690 * bidi.c (bidi_shelve_header_size): New constant.
2691 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2692 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2693
51f30bc5 2694 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
2695 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2696 (overlay_strings):
2697 Don't update size of array until after memory allocation succeeds,
2698 because xmalloc/xrealloc may not return.
0065d054
PE
2699 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2700 now that we have proper integer overflow checking.
2701 (record_overlay_string, overlay_strings): Catch overflows when
2702 calculating size of overlay_str_buf.
726e0ab1 2703
0065d054
PE
2704 * callproc.c (Fcall_process): Check for size overflow when
2705 calculating size of args2.
2706 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2707 Normally we prefer signed values, but sticking with ptrdiff_t would
2708 require adding more-complicated checks.
726e0ab1
PE
2709
2710 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2711 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2712 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 2713 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
2714
2715 * character.c (Fstring): Check for size-calculation overflow.
2716
2717 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2718 unnecessary integer overflow. Check for size overflow.
2719 (encode_coding_object): Don't update size until xmalloc succeeds.
2720
2721 * composite.c (get_composition_id): Check for overflow in glyph
2722 length calculations.
2723
2724 Integer and memory overflow fixes for display code.
2725 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2726 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2727 (scrolling_window): Check for overflow in size calculations.
2728 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2729 Don't assume glyph table len fits in int.
2730 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2731 (row_table_size): Now ptrdiff_t, not int.
2732 (scrolling_window): Avoid overflow in size calculations.
2733 Don't update size until allocation succeeds.
2734 * fns.c (concat): Check for overflow in size calculations.
2735 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2736 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2737 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2738
2739 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2740 (get_doc_string): Check for size calculation overflow.
2741 Don't update size until allocation succeeds.
2742 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2743 EMACS_INT, where ptrdiff_t will do.
2744 (Fsubstitute_command_keys): Check for string overflow.
2745
2746 * editfns.c (set_time_zone_rule): Don't assume environment length
2747 fits in int.
2748 (message_length): Now ptrdiff_t, not int.
2749 (Fmessage_box): Don't update size until allocation succeeds.
2750 Don't assume message length fits in int.
2751 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2752
0065d054
PE
2753 * emacs.c (main): Do not reallocate argv, since there is a null at
2754 the end that can be overwritten, and this way there's no need to
2755 worry about size-calculation overflow.
2756 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
2757
2758 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2759 alloc succeeds.
2760 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2761
2762 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2763 (x_set_scroll_bar_width, x_figure_window_size):
2764 Check for integer overflow.
2765 (x_set_alpha): Do not assume XINT fits in int.
2766
2767 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2768 This is for the members text_lines, text_cols, total_lines, total_cols,
2769 where the system imposes an 'int' limit.
2770
2771 * fringe.c (Fdefine_fringe_bitmap):
2772 Don't update size until alloc works.
2773
2774 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2775 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2776
2777 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2778 Check for size-calculation overflow.
2779 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2780 do, as we prefer signed integers.
2781 (id_to_widget.max_size, id_to_widget.used)
2782 (xg_store_widget_in_map, xg_remove_widget_from_map)
2783 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2784 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2785 Use and return ptrdiff_t, not int.
2786 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2787 * gtkutil.h: Change prototypes to match the above.
2788
2789 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2790 are duplicate now that they've been promoted to lisp.h.
2791 (x_allocate_bitmap_record, x_alloc_image_color)
2792 (make_image_cache, cache_image, xpm_load):
2793 Don't update size until alloc is done.
2794 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2795 (x_detect_edges):
3256efce 2796 Check for size calculation overflow.
726e0ab1
PE
2797 (ct_colors_allocated_max): New constant.
2798 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2799 overflow.
3256efce 2800
726e0ab1
PE
2801 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2802 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2803 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2804 Use ptrdiff_t, not int, to count maps.
2805 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
2806 calculations. Don't update size until allocation succeeds.
2807 Redo calculations to avoid overflow.
726e0ab1
PE
2808 * keyboard.h: Change prototypes to match the above.
2809
2810 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2811 to count maps.
2812 (current_minor_maps): Check for size calculation overflow.
2813 * keymap.h: Change prototypes to match the above.
2814
2815 * lread.c (read1, init_obarray): Don't update size until alloc done.
2816
2817 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2818 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2819
726e0ab1
PE
2820 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2821 Now ptrdiff_t, not int.
2822 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2823 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2824
2825 * process.c (Fnetwork_interface_list): Check for overflow
2826 in size calculation.
2827
2828 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2829
2830 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2831 overflow. Don't bother calling xmalloc when xrealloc will do.
2832
2833 * search.c (Freplace_match): Check for size calculation overflow.
2834 (Fset_match_data): Don't assume list lengths fit in 'int'.
2835
2836 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2837 for command line length. Do not attempt to address one before the
2838 beginning of an array, as that's not portable.
2839
2840 * term.c (max_frame_lines): Remove; unused.
2841 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2842 not int.
2843 (encode_terminal_code, calculate_costs): Check for size
2844 calculation overflow.
2845 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2846 table lengths and related sizes. Don't update size until alloc
2847 done. Redo calculations to avoid overflow.
2848 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2849
2850 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2851 subtracting pointers.
2852 (gobble_line): Check for overflow more carefully. Don't update size
2853 until alloc done.
2854
2855 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2856 Don't update size until alloc done.
2857 Redo size calculations to avoid overflow.
2858 Check for size calculation overflow.
0065d054 2859 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
2860
2861 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2862 Use ptrdiff_t, not int, for sizes.
2863 (store_mode_line_noprop_char): Don't update size until alloc done.
2864
0065d054
PE
2865 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2866 Use ptrdiff_t, not int, for sizes.
2867 (Finternal_make_lisp_face, cache_face):
2868 Check for size calculation overflow.
2869 (cache_face): Treat size calculation overflows as if they were
2870 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
2871
2872 * xfns.c (x_encode_text, x_set_name_internal)
2873 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2874 sizes, since they can exceed INT_MAX in size. Check for size
2875 calculation overflow.
2876
0065d054
PE
2877 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2878 (xg_select): Check for size calculation overflow.
726e0ab1
PE
2879 Don't update size until alloc done.
2880
0065d054 2881 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 2882 as sprintf is limited to int lengths.
1d526e2f 2883
252c5ee1
PE
2884 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2885 (X_LONG_MIN): New macros.
864d7ce7
PE
2886 Use them to make the following changes clearer.
2887 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2888 This change doesn't affect the value now, but it may help remind
2889 future maintainers not to raise the value too much later.
2890 (SELECTION_QUANTUM): Remove, replacing with ...
2891 (selection_quantum): ... new function, which avoids overflow.
2892 All uses changed.
2893 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2894 assumption that selection length fits in 'int'.
2895 (x_reply_selection_request, x_handle_selection_request)
2896 (x_get_window_property, receive_incremental_selection)
2897 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2898 (lisp_data_to_selection_data, clean_local_selection_data):
2899 Use ptrdiff_t, not int, to record length of selection.
2900 (x_reply_selection_request, x_get_window_property)
2901 (receive_incremental_selection, x_property_data_to_lisp):
2902 Redo calculations to avoid overflow.
2903 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 2904 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
2905 something.
2906 (x_get_window_property, receive_incremental_selection)
2907 (lisp_data_to_selection_data, x_property_data_to_lisp):
2908 Check for size-calculation overflow.
2909 (x_get_window_property, receive_incremental_selection)
2910 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2911 Don't store size until memory allocation succeeds.
2912 (x_get_window_property): Plug memory leak on memory exhaustion.
2913 Don't double-block input; malloc is safe here. Don't assume 2**34
2914 - 4 fits in unsigned long. Add an xassert to check
2915 XGetWindowProperty overflow. Be more careful about overflow
2916 calculations, and distinguish size from memory overflow better.
2917 (receive_incremental_selection): When tracing, don't assume
2918 unsigned int is less than INT_MAX.
2919 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2920 harmful) conversions of unsigned short to int.
2921 (lisp_data_to_selection_data): Don't assume that integers
2922 in the range -65535 through -1 fit in an X unsigned short.
2923 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2924 result parameters unless successful. Rely on cons_to_unsigned
2925 to report problems with elements; the old code wasn't right anyway.
2926 (x_check_property_data): Check for int overflow; we cannot use
2927 a wider type due to X limits.
2928 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2929
726e0ab1 2930 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 2931
0065d054
PE
2932 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2933 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
2934 (x_color_cells): Don't store size until memory allocation succeeds.
2935 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 2936 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
2937 (x_term_init): Don't assume length fits in int (sprintf is limited
2938 to int size).
bc18e09d 2939
ebfa62c0
PE
2940 Use ptrdiff_t for composition IDs.
2941 * character.c (lisp_string_width):
2942 * composite.c (composition_table_size, n_compositions)
2943 (get_composition_id, composition_gstring_from_id):
2944 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2945 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2946 * window.c (Frecenter):
2947 Use ptrdiff_t, not int, for composition IDs.
2948 * composite.c (get_composition_id): Check for integer overflow.
2949 * composite.h: Adjust prototypes to match the above changes.
2950
d3411f89
PE
2951 Use ptrdiff_t for hash table indexes.
2952 * category.c (hash_get_category_set):
2953 * ccl.c (ccl_driver):
2954 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2955 * coding.c (coding_system_charset_list, detect_coding_system):
2956 * coding.h (struct coding_system.id):
2957 * composite.c (get_composition_id, gstring_lookup_cache):
2958 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2959 * image.c (xpm_get_color_table_h):
2960 * lisp.h (hash_lookup, hash_put):
2961 * minibuf.c (Ftest_completion):
2962 Use ptrdiff_t for hash table indexes, not int (which is too
2963 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2964 32-bit --with-wide-int hosts).
2965
e097a6fa
PE
2966 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2967 Add a FIXME comment about memory leaks.
2968 (syms_of_charset): Don't assume xmalloc returns.
2969
5637687f
PE
2970 Don't assume that stated character widths fit in int.
2971 * character.c (Fchar_width, c_string_width, lisp_string_width):
2972 * character.h (CHAR_WIDTH):
2973 * indent.c (MULTIBYTE_BYTES_WIDTH):
2974 Use sanitize_char_width to avoid undefined and/or bad behavior
2975 with outlandish widths.
a66cfb1c 2976 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
2977 now that we have two such functions. All uses changed.
2978 (sanitize_char_width): New inline function.
2979
a2271ba2
PE
2980 Don't assume that tab-width fits in int.
2981 * character.h (sanitize_width): New inline function.
2982 (SANE_TAB_WIDTH): New macro.
2983 (ASCII_CHAR_WIDTH): Use it.
2984 * indent.c (sane_tab_width): Remove. All uses replaced by
2985 SANE_TAB_WIDTH (current_buffer).
2986 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2987
18c52557
PE
2988 * fileio.c: Integer overflow issues with file modes.
2989 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2990
caeeedc1
PE
2991 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2992 Remove unreachable code.
2993 (read_hex, load_charset_map_from_file): Check for integer overflow.
2994
6df6ae42 2995 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
2996 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2997 (x_send_scroll_bar_event): Likewise. Check that the size does not
2998 exceed limits imposed by XClientMessageEvent, as well as the usual
2999 ptrdiff_t and size_t limits.
3000
b13995db
PE
3001 * keyboard.c: Overflow, signedness and related fixes.
3002 (make_lispy_movement): Use same integer type in forward decl
3003 that is used in the definition.
3004 (read_key_sequence, keyremap_step):
3005 Change bufsize argument back to int, undoing my 2011-03-30 change.
3006 We prefer signed types, and int is wide enough here.
3007 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
3008 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
3009 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
3010 length, not size_t. Use ptrdiff_t for index, not int.
3011 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
3012 possibility of integer overflow.
3013
13464394
PE
3014 Overflow, signedness and related fixes for images.
3015
3016 * dispextern.h (struct it.stack[0].u.image.image_id)
3017 (struct_it.image_id, struct image.id, struct image_cache.size)
3018 (struct image_cache.used, struct image_cache.ref_count):
3019 * gtkutil.c (update_frame_tool_bar):
3020 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
3021 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
3022 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
3023 * nsmenu.m (update_frame_tool_bar):
3024 * xdisp.c (calc_pixel_width_or_height):
3025 * xfns.c (image_cache_refcount):
3026 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
3027 on typical 64-bit hosts.
3028
3029 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3030 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
3031 Omit unnecessary casts to int.
3032 (parse_image_spec): Check that integers fall into 'int' range
3033 when the callers expect that.
3034 (image_ascent): Redo ascent calculation to avoid int overflow.
3035 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
3036 (lookup_image): Remove unnecessary tests.
3037 (xbm_image_p): Locals are now of int, not EMACS_INT,
3038 since parse_image_check makes sure they fit into int.
3039 (png_load, gif_load, svg_load_image):
3040 Prefer int to unsigned where either will do.
3041 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
3042 old tiff_error_handler and tiff_warning_handler.
3043 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
3044 stack buffer overflows. It uses only the features of vsnprintf
3045 that are common to both POSIX and native Microsoft.
3046 (tiff_error_handler, tiff_warning_handler): Use it.
3047 (tiff_load, gif_load, imagemagick_load_image):
3048 Don't assume :index value fits in 'int'.
3049 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3050 (imagemagick_load_image): Check that crop parameters fit into
3051 the integer types that MagickCropImage accepts. Don't assume
3052 Vimagemagick_render_type has a nonnegative value. Don't assume
3053 size_t fits in 'long'.
3054 (gs_load): Use printmax_t to print the widest integers possible.
3055 Check for integer overflow when computing image height and width.
3056
c11821d4
EZ
30572011-08-26 Eli Zaretskii <eliz@gnu.org>
3058
3059 * xdisp.c (redisplay_window): Don't force window start if point
3060 will be invisible in the resulting window. (Bug#9324)
3061
0c95fcf7
EZ
30622011-08-25 Eli Zaretskii <eliz@gnu.org>
3063
3064 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3065 the display spec is of the form `(space ...)'.
3066 (handle_display_spec): Return the value returned by
3067 handle_single_display_spec, not just 1 or zero.
3068 (handle_single_display_spec): If the display spec is of the form
3069 `(space ...)', and specifies display in the text area, return 2
3070 rather than 1.
fee65a97 3071 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
3072 accurately, and prefer exact match for point under bidi.
3073 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
3074
3075 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3076 into disp_prop; all users changed.
3077
3078 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3079 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3080 for the text covered by the display property.
3081
e4ed06f1
CY
30822011-08-25 Chong Yidong <cyd@stupidchicken.com>
3083
3084 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3085 Change return value to nil.
3086 (Frecord_buffer): Delete unused function.
3087
f67cdd7f
EZ
30882011-08-24 Eli Zaretskii <eliz@gnu.org>
3089
5980d4c6
EZ
3090 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3091 buffers, return left-to-right.
8610fe8b
EZ
3092 (set_cursor_from_row): Consider candidate row a win if its glyph
3093 represents a newline and point is on that newline. Fixes cursor
3094 positioning on the newline at EOL of R2L text within L2R
3095 paragraph, and vice versa.
3096 (try_cursor_movement): Check continued rows, in addition to
3097 continuation rows. Fixes unwarranted scroll when point enters a
3098 continued line of R2L text within an L2R paragraph, or vice versa.
3099 (cursor_row_p): Consider the case of point being equal to
3100 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3101 from the end of a short line to the beginning of a continued line
3102 of R2L text within L2R paragraph.
3103 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3104 composed characters.
5980d4c6 3105
f67cdd7f
EZ
3106 * bidi.c (bidi_check_type): Use xassert.
3107 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3108 members.
3109
bca633fb
EZ
31102011-08-23 Eli Zaretskii <eliz@gnu.org>
3111
3112 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3113 a character.
3114
4a5885a7
CY
31152011-08-23 Chong Yidong <cyd@stupidchicken.com>
3116
3117 * nsfont.m (ns_otf_to_script): Fix typo.
3118
0902a04e
KH
31192011-08-22 Kenichi Handa <handa@m17n.org>
3120
3121 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3122 extra slot even if the purpose is char-code-property-table.
3123
1a2e6670
EZ
31242011-08-23 Eli Zaretskii <eliz@gnu.org>
3125
8ddde651
EZ
3126 * xdisp.c (redisplay_window): When computing centering_position,
3127 account for the height of the header line. (Bug#8874)
3128
425cc014
EZ
3129 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3130 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3131 candidate is selected by the mouse, and that candidate has a
3132 composed character under the mouse.
3133
1a2e6670
EZ
3134 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3135 coordinates reported by pos-visible-in-window-p for a composed
3136 character in column zero.
3137
8b76d6f8
SM
31382011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3139
3140 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3141
dac347dd
EZ
31422011-08-22 Eli Zaretskii <eliz@gnu.org>
3143
3144 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3145 consider it a hit if to_charpos is anywhere in the range of the
3146 composed buffer positions.
3147
e013fb34
CY
31482011-08-22 Chong Yidong <cyd@stupidchicken.com>
3149
3150 * image.c (gif_load): Don't assume that each subimage has the same
3151 dimensions as the base image. Handle disposal method that is
3152 "undefined" by the gif spec (Bug#9335).
3153
bd1ba3e8
CY
31542011-08-20 Chong Yidong <cyd@stupidchicken.com>
3155
3156 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 3157 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 3158
54a1215b
EZ
31592011-08-19 Eli Zaretskii <eliz@gnu.org>
3160
823564e5
EZ
3161 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3162 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3163 from an Org mode buffer to a Speedbar frame.
3164
54a1215b
EZ
3165 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3166 a composition, take its buffer position from IT->cmp_it.charpos.
3167 Fixes cursor positioning at the beginning of a line that begins
3168 with a composed character.
3169
9778ebcc
EZ
31702011-08-18 Eli Zaretskii <eliz@gnu.org>
3171
0be6ee06
EZ
3172 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3173 character bidirectional type, use STRONG_L instead. Fixes crashes
3174 in a buffer produced by `describe-categories'.
3175
9778ebcc
EZ
3176 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3177 members before the level stack, so they would be saved and
3178 restored when copying iterator state. Fixes incorrect reordering
3179 around TABs covered by display properties.
3180
156bffbe
AS
31812011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3182
6b02f655 3183 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 3184
72ad093b
CY
31852011-08-17 Chong Yidong <cyd@stupidchicken.com>
3186
3187 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
3188 (internal_condition_case_2, internal_condition_case_n):
3189 Remove unnecessary aborts (Bug#9081).
72ad093b 3190
35774242
EZ
31912011-08-17 Eli Zaretskii <eliz@gnu.org>
3192
3193 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3194 has no `load' handler, try opening the file locally. (Bug#9311)
3195
db76dd85
KB
31962011-08-16 Ken Brown <kbrown@cornell.edu>
3197
3198 * gmalloc.c: Expand comment.
3199
b215eee5
EZ
32002011-08-16 Eli Zaretskii <eliz@gnu.org>
3201
3202 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3203 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3204
a4579d33
KB
32052011-08-16 Ken Brown <kbrown@cornell.edu>
3206
3207 Fix memory allocation problems in Cygwin build (Bug#9273).
3208
3209 * unexcw.c ( __malloc_initialized): Declare external variable.
3210 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3211
8b76d6f8
SM
3212 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3213 New variables.
a4579d33
KB
3214 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3215 dumped emacs.
3216 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3217 in the static heap.
3218 [CYGWIN] (special_realloc): New function.
3219 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3220 requests to realloc storage in the static heap.
3221
3ebec551
PE
32222011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3223
3224 * bidi.c (bidi_initialize): Remove unused local.
3225
9fd8be00
EZ
32262011-08-15 Eli Zaretskii <eliz@gnu.org>
3227
6b02f655
SM
3228 * bidimirror.h:
3229 * biditype.h: Remove file.
3230 * makefile.w32-in ($(BLD)/bidi.$(O)):
3231 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
3232
3233 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3234
3235 * chartab.c: Improve commentary for the uniprop_table API.
3236
32413314
EZ
3237 * bidi.c (bidi_paragraph_init): Support zero value of
3238 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
3239 (bidi_initialize): Use uniprop_table instead of including
3240 biditype.h and bidimirror.h.
32413314 3241
9fd8be00
EZ
3242 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3243 coordinates of the iterator when restoring from ppos_it.
3244 (Bug#9296)
3245
5cf2b69b
KH
32462011-08-14 Kenichi Handa <handa@m17n.org>
3247
3248 * process.c (create_process): Call setup_process_coding_systems
72ad093b 3249 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 3250
daf17d00
EZ
32512011-08-14 Eli Zaretskii <eliz@gnu.org>
3252
3253 * xdisp.c (move_it_in_display_line_to): Don't invoke
3254 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3255 ppos_it. Fixes vertical cursor motion when line beginning is
3256 covered by an image. (Bug#9296)
3257
08e3161a
JD
32582011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3259
3260 * nsterm.h (ns_run_ascript): Declare.
3261 (NSAPP_DATA2_RUNASSCRIPT): Define.
3262
3263 * nsfns.m (as_script, as_result, as_status): New static variables.
3264 (ns_run_ascript): New function.
5e617bc2 3265 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
3266 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3267 the event loop. Get status from as_status (Bug#7276).
3268
3269 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3270 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3271 the event loop (Bug#7276).
3272
a3720aa2
AS
32732011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3274
3275 * gnutls.c (QCgnutls_bootprop_priority)
3276 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3277 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3278 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3279 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3280 (QCgnutls_bootprop_verify_hostname_error)
3281 (QCgnutls_bootprop_callbacks_verify): Rename from
3282 Qgnutls_bootprop_..., all uses changed.
3283
3284 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3285 uses changed.
3286
0a0d27fb
PE
32872011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3288
19d5c50c
PE
3289 * xfaces.c (Qframe_set_background_mode): Now static.
3290 * dispextern.h (Qframe_set_background_mode): Remove decl.
3291
0a0d27fb
PE
3292 * process.c (Fnetwork_interface_info): Declare local only if needed.
3293
377538cb
JD
32942011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3295
3296 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3297 (Fnetwork_interface_list): Allocate in increments of bytes instead
3298 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3299 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3300 sockaddr.
3301 (struct ifflag_def): notrailers is smart on OSX.
3302 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3303 Get hardware address with getifaddrs if available.
3304
08fff70c
EZ
33052011-08-12 Eli Zaretskii <eliz@gnu.org>
3306
3307 * xdisp.c (iterate_out_of_display_property): xassert that
3308 IT->position is set to within IT->object's boundaries. Break from
3309 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
3310 when IT->position is set up wrongly due to some bug.
3311 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
3312 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3313 entry. Force push_it to save on the stack the current
3314 buffer/string position, to be restored by pop_it. Fix flags in
3315 the iterator structure wrt the object coming from a display
3316 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3317 properties. (Bug#9284)
3318
7be1c708 33192011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 3320
7be1c708
CY
3321 * fontset.c (fontset_get_font_group): Add proper type checks.
3322 (Bug#9172)
aac0c6e3 3323
7be1c708 33242011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 3325
7be1c708
CY
3326 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3327 and LC_VERSION_MIN_MACOSX.
3328 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3329 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 3330
97bb72a6
EZ
33312011-08-08 Eli Zaretskii <eliz@gnu.org>
3332
3333 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
3334 no-display-properties-and-no-overlays under bidi display.
3335 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 3336 properties and overlays.
97bb72a6 3337
d5617611
CY
33382011-08-08 Chong Yidong <cyd@stupidchicken.com>
3339
37e11a63
CY
3340 * editfns.c (Fset_time_zone_rule): Document relationship with the
3341 setenv function.
3342
d5617611
CY
3343 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3344 the font entity extracted from the cache (Bug#8109).
3345
58872834
CY
33462011-08-07 Chong Yidong <cyd@stupidchicken.com>
3347
3348 * composite.c (autocmp_chars): Don't reset point. That is done by
3349 restore_point_unwind (Bug#5984).
3350
75bfc667
JL
33512011-08-07 Juri Linkov <juri@jurta.org>
3352
3353 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3354 to show the arg `TIME' instead of `TIMEVAL'.
3355
d1410150
EZ
33562011-08-06 Eli Zaretskii <eliz@gnu.org>
3357
3358 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3359 display property strides EOL and includes a newline, as in
3360 longlines-mode. (Bug#9254)
75b771e4
EZ
3361 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3362 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
3363
3364 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3365 is non-zero, even if the data buffer is NULL. Fixes a crash in
3366 vertical-motion with longlines-mode. (Bug#9254)
3367
35928349
EZ
33682011-08-05 Eli Zaretskii <eliz@gnu.org>
3369
ec7cc85b
EZ
3370 * bidi.c <bidi_cache_total_alloc>: Now static.
3371 (bidi_initialize): Initialize bidi_cache_total_alloc.
3372
8b76d6f8 3373 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
3374 cache. (Bug#9221)
3375
3376 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3377 amount allocated this far in `bidi_cache_total_alloc'.
3378 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3379 non-zero, only free the data buffer without restoring the cache
3380 contents. All callers changed.
3381
3382 * dispextern.h (bidi_unshelve_cache): Update prototype.
3383
3384 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3385 (move_it_in_display_line, move_it_to)
3386 (move_it_vertically_backward, move_it_by_lines): Replace the call
3387 to xfree to an equivalent call to bidi_unshelve_cache.
3388 (move_it_in_display_line_to): Fix logic of returning
412b6358 3389 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 3390
e2e2423b
EZ
33912011-08-05 Eli Zaretskii <eliz@gnu.org>
3392
3393 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3394 came from a string character with a `cursor' property. (Bug#9229)
3395
ae9e757a
JD
33962011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3397
3398 * Makefile.in (LIB_PTHREAD): New variable.
3399 (LIBES): Add LIB_PTHREAD (Bug#9216).
3400
3401 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3402 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3403
213bd7f2
AS
34042011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3405
6b02f655 3406 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 3407
99aaf75f
JD
34082011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3409
3410 * xterm.c (x_find_topmost_parent): New function.
3411 (x_set_frame_alpha): Find topmost parent window with
3412 x_find_topmost_parent and set the property there also (bug#9181).
3413 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3414
c74e9d86
PE
34152011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3416
3417 * callproc.c (Fcall_process): Avoid vfork clobbering
3418 the local vars buffer, coding_systems, current_dir.
3419
640c8776
SM
34202011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3421
3422 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3423
f26d0e4c
PE
34242011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3425
8a10d76c
PE
3426 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3427 so that it is not optimized away.
3428
f26d0e4c
PE
3429 * xdisp.c (compute_display_string_pos): Remove unused local.
3430
55439c61
EZ
34312011-08-02 Eli Zaretskii <eliz@gnu.org>
3432
3433 Fix slow cursor motion and scrolling in large buffers with
3434 selective display, like Org Mode buffers. (Bug#9218)
3435
3436 * dispextern.h (struct bidi_it): New member disp_prop_p.
3437
3438 * xdisp.c: Remove one-slot cache of display string positions.
3439 (compute_display_string_pos): Accept an additional argument
5e617bc2 3440 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
3441 for a display string or property. If found, set DISP_PROP_P
3442 non-zero.
3443
3444 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
3445 DISP_PROP_P, and pass it to compute_display_string_pos.
3446 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
3447 non-zero. All callers of bidi_fetch_char changed.
3448
fb33fa43
SM
34492011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3450
3451 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3452
b099e063
DM
34532010-12-03 Don March <don@ohspite.net>
3454
3455 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3456 last character M-[char] is translated to ESC [char] (bug#7541).
3457
5cc7f7af
KH
34582011-08-02 Kenichi Handa <handa@m17n.org>
3459
d0fffa3f 3460 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
3461
3462 * chartab.c (uniprop_table): Make it non-static.
3463
525d5e6e
EZ
34642011-08-01 Eli Zaretskii <eliz@gnu.org>
3465
3466 * xdisp.c (forward_to_next_line_start): Accept additional argument
3467 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3468 on the newline.
3469 (reseat_at_next_visible_line_start): Use the bidi iterator state
3470 returned by forward_to_next_line_start to restore the state of
3471 it->bidi_it after backing up to previous newline. (Bug#9212)
3472
31011111
AS
34732011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3474
3475 * regex.c (re_comp): Protoize.
3476 (re_exec): Fix return type.
3477 (regexec): Fix type of `ret'. (Bug#9203)
3478
476371c4
PE
34792011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3480
e5d76069
PE
3481 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3482 This is needed if max-image-size is a floating-point number.
3483
9a79b20c
AS
34842011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3485
3486 * print.c (print_object): Print empty symbol as ##.
3487
3488 * lread.c (read1): Read ## as empty symbol.
3489
d8c2fa78
AA
34902011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3491
3492 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3493 setting frame foreground color (Bug#9175).
3494 (x_set_background_color): Likewise.
3495
ffe57a7a
AA
3496 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3497 contents (Bug#9176).
3498 (EmacsTooltip -init): Remove bezels and add shadows to
3499 tooltip windows.
3500
bf3492a5
AA
3501 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3502 or scroll bar (Bug#8470).
3503
d55e9c53
AA
3504 * nsfont.m (nsfont_open): Remove assignment to voffset and
3505 unnecessary vars hshink, expand, hd, full_height, min_height.
3506 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3507
3508 * nsterm.h (nsfont_info): Remove voffset field.
3509
d8c2fa78 35102011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
3511
3512 Implement strike-through and overline on NextStep (Bug#8863).
3513
3514 * nsfont.m (nsfont_open): Use underline position provided by font,
3515 instead of hard-coded value of 2.
3516 (nsfont_draw): Call ns_draw_text_decoration instead.
3517
3518 * nsterm.h: Add declaration for ns_draw_text_decoration.
3519
3520 * nsterm.m (ns_draw_text_decoration): New function for drawing
3521 underline, overline, and strike-through.
3522 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3523 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 3524 accommodate underlining, etc.
4843aac3 3525
4cc60b9b
EZ
35262011-07-28 Eli Zaretskii <eliz@gnu.org>
3527
bc7ece87
EZ
3528 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3529 default.
4cc60b9b 3530
476371c4
PE
35312011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3532
66606eea
PE
3533 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3534 Without this fix, if a signal arrives just after memory fills up,
3535 'malloc' might be invoked reentrantly.
3536
476371c4
PE
3537 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3538 In other words, assume that every image size is allowed, on non-X
3539 hosts. This assumption is probably wrong, but it lets Emacs compile.
3540
f3fcc40d
AS
35412011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3542
3543 * regex.c (re_iswctype): Convert return values to boolean.
3544
350c992f
EZ
35452011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3546
3547 * xdisp.c (compute_display_string_pos): Don't use cached display
3548 string position if the buffer had its restriction changed.
3549 (Bug#9184)
3550
5266b4bb
PE
35512011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3552
3553 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3554
2573a837 35552011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 3556
41f55ccd 3557 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 3558
39e378da
PE
3559 * bidi.c: Integer size and overflow fixes.
3560 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3561 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3562 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3563 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3564 (bidi_find_other_level_edge):
3565 Use ptrdiff_t instead of EMACS_INT where either will do.
3566 This works better on 32-bit hosts configured --with-wide-int.
3567 (bidi_cache_ensure_space): Check for size-calculation overflow.
3568 Use % rather than repeated addition, for better worst-case speed.
3569 Don't set bidi_cache_size until after xrealloc returns, because it
3570 might not return.
3571 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
3572 (bidi_cache_ensure_space): Also check that the bidi cache size
3573 does not exceed that of the largest Lisp string or buffer. See Eli
3574 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 3575
5e927815
PE
3576 * alloc.c (__malloc_size_t): Remove.
3577 All uses replaced by size_t. See Andreas Schwab's note
3578 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3579
ca4aa935
PE
3580 * image.c: Improve checking for integer overflow.
3581 (check_image_size): Assume that f is nonnull, since
3582 it is always nonnull in practice. This is one less thing to
3583 worry about when checking for integer overflow later.
3584 (x_check_image_size): New function, which checks for integer
3585 overflow issues inside X.
3586 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3587 This removes the need for a memory_full check.
3588 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3589 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3590 (xbm_read_bitmap_data): Change locals back to 'int', since
3591 their values must fit in 'int'.
3592 (xpm_load_image, png_load, tiff_load):
3593 Invoke x_create_x_image_and_pixmap earlier,
3594 to avoid much needless work if the image is too large.
3595 (tiff_load): Treat overly large images as if
3596 x_create_x_image_and_pixmap failed, not as malloc failures.
3597 (gs_load): Use x_check_image_size.
3598
5f8f9cc2
PE
3599 * gtkutil.c: Omit integer casts.
3600 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3601 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3602
5adf60bc
PE
3603 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3604
c8907a93
PE
3605 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3606 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3607 would wrongly return t on a 64-bit host.
3608
e3c25c68
PE
3609 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3610 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3611 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3612 and therefore cause GCC to emit a bogus diagnostic in some cases.
3613
3f791afe
PE
3614 * image.c: Integer signedness and overflow and related fixes.
3615 This is not an exhaustive set of fixes, but it's time to
3616 record what I've got.
3617 (lookup_pixel_color, check_image_size): Remove redundant decls.
3618 (check_image_size): Don't assume that arbitrary EMACS_INT values
3619 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3620 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3621 (tiff_load, imagemagick_load_image):
3622 Check for overflow in size calculations.
3623 (x_create_x_image_and_pixmap): Remove unnecessary test for
3624 xmalloc returning NULL; that can't happen.
3625 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3626 (xpm_color_bucket): Use better integer hashing function.
3627 (xpm_cache_color): Don't possibly over-allocate memory.
3628 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3629 (gif_memory_source):
3630 Use ptrdiff_t, not int or size_t, to record sizes.
3631 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3632 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3633 either works, as we prefer signed integers.
3634 (tiff_read_from_memory, tiff_write_from_memory):
3635 Return tsize_t, not size_t, since that's what the TIFF API wants.
3636 (tiff_read_from_memory): Don't fail simply because the read would
3637 go past EOF; instead, return a short read.
3638 (tiff_load): Omit no-longer-needed casts.
3639 (Fimagemagick_types): Don't assume size fits into 'int'.
3640
3cc5a532
PE
3641 Improve hashing quality when configured --with-wide-int.
3642 * fns.c (hash_string): New function, taken from sxhash_string.
3643 Do not discard information about ASCII character case; this
3644 discarding is no longer needed.
3645 (sxhash-string): Use it. Change sig to match it. Caller changed.
3646 * lisp.h: Declare it.
3647 * lread.c (hash_string): Remove, since we now use fns.c's version.
3648 The fns.c version returns a wider integer if --with-wide-int is
3649 specified, so this should help the quality of the hashing a bit.
3650
b312a492
PE
3651 * emacs.c: Integer overflow minor fix.
3652 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3653 Define only if GNU_LINUX.
3654 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3655
dfd153ae
PE
3656 * dispnew.c: Integer signedness and overflow fixes.
3657 Remove unnecessary forward decls, that were a maintenance hassle.
3658 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3659 All uses changed.
3660 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3661 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3662 (prepare_desired_row, line_draw_cost):
3663 Use int, not unsigned, where either works.
3664 (save_current_matrix, restore_current_matrix):
3665 Use ptrdiff_t, not size_t, where either works.
3666 (init_display): Check for overflow more accurately, and without
3667 relying on undefined behavior.
3668
a81d11a3
PE
3669 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3670 Remove, replacing with the new symbols in lisp.h. All uses changed.
3671 * fileio.c (make_temp_name):
3672 * filelock.c (lock_file_1, lock_file):
3673 * xdisp.c (message_dolog):
3674 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3675 Use pMd etc. instead.
3676 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3677 replacing the pWIDE etc. symbols removed from editfns.c.
3678
3300e6fd
PE
3679 * keyboard.h (num_input_events): Now uintmax_t.
3680 This is (very slightly) less likely to mess up due to wraparound.
3681 All uses changed.
3682
fd05c7e9
PE
3683 * buffer.c: Integer signedness fixes.
3684 (alloc_buffer_text, enlarge_buffer_text):
3685 Use ptrdiff_t rather than size_t when either will do, as we prefer
3686 signed integers.
3687
903fe15d
PE
3688 * alloc.c: Integer signedness and overflow fixes.
3689 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3690 (__malloc_size_t): Default to size_t, not to int.
3691 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3692 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3693 Prefer ptrdiff_t to size_t when either would do, as we prefer
3694 signed integers.
3695 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3696 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3697 Now const. Initialize with values that are in range even if char
3698 is signed.
3699 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3700 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3701 These functions do the right thing with sizes > 2**32.
3702 (check_depth): Now ptrdiff_t, not int.
3703 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3704 Adjust to new way of storing sizes. Check for size overflow bugs
3705 in rest of code.
3706 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3707 slightly wrong anyway, as it missed one instance of
3708 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3709 (refill_memory_reserve): Omit needless cast to size_t.
3710 (mark_object_loop_halt): Mark as externally visible.
3711
ac82cc6a
PE
3712 * xselect.c: Integer signedness and overflow fixes.
3713 (Fx_register_dnd_atom, x_handle_dnd_message):
3714 Use ptrdiff_t, not size_t, since we prefer signed.
3715 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3716 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3717 x_dnd_atoms_size and x_dnd_atoms_length.
3718
c2d1e36d
PE
3719 * doprnt.c: Prefer signed to unsigned when either works.
3720 * eval.c (verror):
3721 * doprnt.c (doprnt):
3722 * lisp.h (doprnt):
3723 * xdisp.c (vmessage):
3724 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3725 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3726 prefer signed arithmetic to avoid comparison confusion.
3727 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3728 but is a bit tricky.
3729
0e926e56
PE
3730 Assume freestanding C89 headers, string.h, stdlib.h.
3731 * data.c, doprnt.c, floatfns.c, print.c:
3732 Include float.h unconditionally.
3733 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3734 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3735 * regex.c: Likewise for stddef.h, string.h.
3736 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3737 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3738 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3739 (STDC_HEADERS): Remove obsolete defines.
3740 * sysdep.c: Include limits.h unconditionally.
3741
9cfdb3ec
PE
3742 Assume support for memcmp, memcpy, memmove, memset.
3743 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3744 * regex.c (memcmp, memcpy):
3745 Remove; we assume C89 now.
3746
3747 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3748 (__malloc_safe_bcopy): Remove; no longer needed.
3749
cf950e6b 3750 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
3751 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3752 well either way, and we prefer signed to unsigned.
3753
dbf38e02
LMI
37542011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3755
3756 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3757 closes the connection while we're reading (bug#9182).
3758
d6f0886c 37592011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 3760
d6f0886c
JD
3761 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3762 are specified (Bug#9168).
24e0f6b1 3763
2eb1f9e6
PE
37642011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3765
3766 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3767 Found by GCC static checking and --with-wide-int on a 32-bit host.
3768
22381272 37692011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
3770
3771 * xdisp.c (compute_display_string_pos): Fix logic of caching
3772 previous display string position. Initialize cached_prev_pos to
3773 -1. Fixes slow-down at the beginning of a buffer.
3774
f25e39b4
EZ
37752011-07-24 Eli Zaretskii <eliz@gnu.org>
3776
3777 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3778 for attrs[LFACE_FONTSET_INDEX].
3779
04c4b52e
PE
37802011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3781
3782 * xml.c (parse_region): Remove unused local
3783 that was recently introduced.
3784
c1734fbd
EZ
37852011-07-23 Eli Zaretskii <eliz@gnu.org>
3786
be18c5a5
EZ
3787 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3788 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3789
c1734fbd
EZ
3790 * xdisp.c (move_it_in_display_line_to): Record the best matching
3791 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
3792 exit if none of the characters scanned was an exact match.
3793 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
3794 when exact match is impossible due to invisible text, and the
3795 lines are truncated.
3796
a258d627
JD
37972011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3798
3799 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3800 for OSX >= 10.7.
3801
b6d5a689
EZ
38022011-07-22 Eli Zaretskii <eliz@gnu.org>
3803
0f74f785
EZ
3804 Fix a significant slow-down of cursor motion with C-n, C-p,
3805 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3806 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 3807 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
3808 (next_element_from_buffer): Call compute_stop_pos_backwards to
3809 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
3810 base_level_stop.
3811 (reseat): Don't look for prev_stop, as that could mean a very long
3812 run.
3813 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3814 <cached_disp_overlay_modiff>: Cache for last found display string
3815 position.
551918c1 3816 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
3817 about the same buffer in the same area of character positions, and
3818 the buffer wasn't changed since the time the display string
3819 position was cached.
551918c1 3820
b2d0c91a
EZ
38212011-07-22 Eli Zaretskii <eliz@gnu.org>
3822
3823 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3824 is an integer, which is important for empty lines. (Bug#9149)
3825
043604ee
CY
38262011-07-22 Chong Yidong <cyd@stupidchicken.com>
3827
3828 * frame.c (Fmodify_frame_parameters): In tty case, update the
3829 default face if necessary (Bug#4238).
3830
da4adb04
CY
38312011-07-21 Chong Yidong <cyd@stupidchicken.com>
3832
3833 * editfns.c (Fstring_to_char): No need to explain what a character
3834 is in the docstring (Bug#6576).
3835
9abd0532
LMI
38362011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3837
3838 * xml.c (parse_region): Make sure we always return a tree.
3839
36881d16
HK
38402011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3841
3842 * xml.c (parse_region): If a document contains only comments,
3843 return that, too.
3844
1e98674d
LMI
38452011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3846
3847 * xml.c (make_dom): Return comments, too.
3848
590bd467
PE
38492011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3850
3851 Port to OpenBSD.
3852 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3853 and the surrounding thread.
3854 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3855 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3856 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3857 timer goes off.
3858 * s/openbsd.h (BROKEN_SIGIO): Define.
3859 * unexelf.c (unexec) [__OpenBSD__]:
3860 Don't update the .mdebug section of the Alpha COFF symbol table.
3861
f41628b2
LMI
38622011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3863
3864 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3865 (bug#8460).
3866
b59b67c5
PE
38672011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3868
15e3a074
PE
3869 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3870 This fixes some race conditions on the permissions of any newly
3871 created file.
3872
41bed37d
PE
3873 * alloc.c (valid_pointer_p): Use pipe, not open.
3874 This fixes some permissions issues when debugging.
3875
b59b67c5
PE
3876 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3877 If fchown fails to set both uid and gid, try to set just gid,
3878 as that is sometimes allowed. Adjust the file's mode to eliminate
3879 setuid or setgid bits that are inappropriate if fchown fails.
3880
925a6be7
SM
38812011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3882
3883 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3884 to compare Lisp_Objects.
3885 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3886 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3887 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3888
52968808
AS
38892011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3890
0a6a104b
AS
3891 * lread.c (read_integer): Unread even EOF character.
3892 (read1): Likewise. Properly record start position of symbol.
3893
52968808
AS
3894 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3895 symbol character follows.
3896
9e381cdd
PE
38972011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3898
3899 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3900 This works around a problem with the previous change to Fcopy_file.
3901 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3902 and without this change, GCC might complain about discarding
3903 fchown's return value.
3904
b5641435
JB
39052011-07-16 Juanma Barranquero <lekktu@gmail.com>
3906
3907 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3908
a8031457
PE
39092011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3910
3911 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3912
dd889327
LMI
39132011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3914
750c33f7
LMI
3915 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3916 it's used from the C level.
3917
dd889327
LMI
3918 * process.c: Use the same condition for POLL_FOR_INPUT in both
3919 keyboard.c and process.c (bug#1858).
3920
87e86684
LM
39212011-07-09 Lawrence Mitchell <wence@gmx.li>
3922
3923 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3924 (Fgnutls_boot): Use it.
3925
64348f40
AS
39262011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3927
3928 * doc.c (Fsubstitute_command_keys): Revert last change.
3929
1d698799
LMI
39302011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3931
f863868c
LMI
3932 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3933 quotes the next character, and doesn't affect other longer
3934 sequences (bug#8935).
3935
1d698799
LMI
3936 * lread.c (syms_of_lread): Clarify that is isn't only
3937 `eval-buffer' and `eval-defun' that's affected by
3938 `lexical-binding' (bug#8460).
3939
aa4b6df6
EZ
39402011-07-15 Eli Zaretskii <eliz@gnu.org>
3941
3942 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 3943 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 3944
5d856da6
PE
39452011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3946
ad6042bb
PE
3947 Fix minor problems found by static checking.
3948 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3949 (elsz): Now a signed constant, not a size_t var. We prefer signed
3950 types to unsigned, to avoid integer comparison confusion. Without
3951 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3952 "cannot optimize loop, the loop counter may overflow", a symptom
3953 of the confusion.
f00bbb22 3954 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
3955 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3956
6468f31c
LMI
39572011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3958
49080b10
LMI
3959 * search.c (Fre_search_backward): Mention `case-fold-search' in
3960 all the re_search_* functions (bug#8138).
3961
6468f31c
LMI
3962 * keyboard.c (Fopen_dribble_file): Document when the file is
3963 closed (bug#8056).
3964
c965adc5
EZ
39652011-07-14 Eli Zaretskii <eliz@gnu.org>
3966
df9733bf
EZ
3967 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3968 bidi_cache_idx.
3969
0bb23927
EZ
3970 Support bidi reordering of display and overlay strings.
3971 * xdisp.c (compute_display_string_pos)
3972 (compute_display_string_end): Accept additional argument STRING.
3973 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3974 (reseat_to_string): Initialize bidi_it->string.s and
3975 bidi_it->string.schars.
3976 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
3977 NULL (avoids a crash in bidi_paragraph_init).
3978 Initialize itb.string.lstring.
0bb23927
EZ
3979 (init_iterator): Call bidi_init_it only of a valid
3980 buffer position was specified. Initialize paragraph_embedding to
3981 L2R.
3982 (reseat_to_string): Initialize the bidi iterator.
3983 (display_string): If we need to ignore text properties of
3984 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3985 original value of -1 will not work with bidi.)
3986 (compute_display_string_pos): First arg is now struct
3987 `text_pos *'; all callers changed. Support display properties on
3988 Lisp strings.
3989 (compute_display_string_end): Support display properties on Lisp
3990 strings.
3991 (init_iterator, reseat_1, reseat_to_string): Initialize the
3992 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3993 when iterating on a string not from display properties).
640c8776
SM
3994 (compute_display_string_pos, compute_display_string_end):
3995 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
3996 arrow keys.
3997 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
3998 base_level_stop; instead, set base_level_stop to BEGV.
3999 Fixes crashes in vertical-motion.
0bb23927
EZ
4000 (next_element_from_buffer): Improve commentary for when
4001 the iterator is before prev_stop.
4002 (init_iterator): Initialize bidi_p from the default value of
4003 bidi-display-reordering, not from buffer-local value. Use the
4004 buffer-local value only if initializing for buffer iteration.
4005 (handle_invisible_prop): Support invisible properties on strings
4006 that are being bidi-reordered.
4007 (set_iterator_to_next): Support bidi reordering of C strings and
4008 Lisp strings.
4009 (next_element_from_string): Support bidi reordering of Lisp
4010 strings.
4011 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
4012 (display_string): Support display of R2L glyph rows.
4013 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
4014 (init_iterator): Don't initialize it->bidi_p for strings
4015 here.
4016 (reseat_to_string): Initialize it->bidi_p for strings here.
4017 (next_element_from_string, next_element_from_c_string)
4018 (next_element_from_buffer): Add xassert's for correspondence
4019 between IT's object being iterated and it->bidi_it.string
4020 structure.
4021 (face_before_or_after_it_pos): Support bidi iteration.
4022 (next_element_from_c_string): Handle the case of the first string
4023 character that is not the first one in the visual order.
4024 (get_visually_first_element): New function, refactored from common
4025 parts of next_element_from_buffer, next_element_from_string, and
4026 next_element_from_c_string.
4027 (tool_bar_lines_needed, redisplay_tool_bar)
4028 (display_menu_bar): Force left-to-right direction. Add a FIXME
4029 comment for making that be controlled by a user option.
4030 (push_it, pop_it): Save and restore the state of the
4031 bidi iterator. Save and restore the bidi_p flag.
4032 (pop_it): Iterate out of display property for string iteration as
4033 well.
4034 (iterate_out_of_display_property): Support iteration over strings.
4035 (handle_single_display_spec): Set up it->bidi_it for iteration
4036 over a display string, and call bidi_init_it.
4037 (handle_single_display_spec, next_overlay_string)
4038 (get_overlay_strings_1, push_display_prop): Set up the bidi
4039 iterator for displaying display or overlay strings.
4040 (forward_to_next_line_start): Don't use the shortcut if
4041 bidi-iterating.
4042 (back_to_previous_visible_line_start): If handle_display_prop
4043 pushed the iterator stack, restore the internal state of the bidi
4044 iterator by calling bidi_pop_it same number of times.
4045 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4046 and we are bidi-iterating, don't decrement the iterator position;
4047 instead, set the first_elt flag in the bidi iterator, to produce
4048 the same effect.
4049 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4050 (push_display_prop): xassert that we are iterating a buffer.
4051 (push_it, pop_it): Save and restore paragraph_embedding member.
4052 (handle_single_display_spec, next_overlay_string)
4053 (get_overlay_strings_1, reseat_1, reseat_to_string)
4054 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4055 correctly. Don't assume unibyte strings are not bidi-reordered.
4056 (compute_display_string_pos)
4057 (compute_display_string_end): Fix handling the case of C string.
4058 (push_it, pop_it): Save and restore from_disp_prop_p.
4059 (handle_single_display_spec, push_display_prop): Set the
4060 from_disp_prop_p flag.
4061 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4062 (pop_it): Call iterate_out_of_display_property only if we are
4063 popping after iteration over a string that came from a display
4064 property. Fix a typo in popping stretch info. Add an assertion
4065 for verifying that the iterator position is in sync with the bidi
4066 iterator.
4067 (handle_single_display_spec, get_overlay_strings_1)
4068 (push_display_prop): Fix initialization of paragraph direction for
4069 string when that of the parent object is not yet determined.
4070 (reseat_1): Call bidi_init_it to resync the bidi
4071 iterator with IT's position. (Bug#7616)
4072 (find_row_edges): If ROW->start.pos gives position
4073 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4074 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4075 Reset the from_disp_prop_p flag.
4076 (SAVE_IT, RESTORE_IT): New macros.
4077 (pos_visible_p, face_before_or_after_it_pos)
4078 (back_to_previous_visible_line_start)
4079 (move_it_in_display_line_to, move_it_in_display_line)
4080 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4081 (try_scrolling, redisplay_window, display_line): Use them when
4082 saving a temporary copy of the iterator and restoring it back.
4083 (back_to_previous_visible_line_start, reseat_1)
4084 (init_iterator): Empty the bidi cache "stack".
4085 (move_it_in_display_line_to): If iterator ended up at
4086 EOL, but we never saw any buffer positions smaller than
4087 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4088 motion in bidi-reordered lines.
4089 (move_it_in_display_line_to): Record prev_method and prev_pos
4090 immediately before the call to set_iterator_to_next. Fixes cursor
4091 motion in bidi-reordered lines with stretch glyphs and strings
4092 displayed in margins. (Bug#8133) (Bug#8867)
4093 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4094 TO_CHARPOS.
640c8776
SM
4095 (pos_visible_p): Support positions in bidi-reordered lines.
4096 Save and restore bidi cache.
0bb23927
EZ
4097
4098 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4099 (bidi_paragraph_info): Delete unused struct.
4100 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4101 (bidi_cache_start): New variable.
4102 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4103 to zero.
4104 (bidi_cache_fetch_state, bidi_cache_search)
4105 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4106 (bidi_cache_find, bidi_peek_at_next_level)
4107 (bidi_level_of_next_char, bidi_find_other_level_edge)
4108 (bidi_move_to_visually_next): Compare cache index with
4109 bidi_cache_start rather than with zero.
4110 (bidi_fetch_char): Accept new argument STRING; all callers
4111 changed. Support iteration over a string. Support strings with
4112 display properties. Support unibyte strings. Fix the type of
4113 `len' according to what STRING_CHAR_AND_LENGTH expects.
4114 (bidi_paragraph_init, bidi_resolve_explicit_1)
4115 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
4116 (bidi_level_of_next_char, bidi_move_to_visually_next):
4117 Support iteration over a string.
0bb23927
EZ
4118 (bidi_set_sor_type, bidi_resolve_explicit_1)
4119 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4120 can now be zero (for strings); special values 0 and -1 were
4121 changed to -1 and -2, respectively.
4122 (bidi_char_at_pos): New function.
4123 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4124 Call it instead of FETCH_MULTIBYTE_CHAR.
4125 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4126 initialized to valid values.
4127 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4128 values.
4129 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4130 the test for valid cached positions. Fix the logic for looking up
4131 the sentinel state in the cache. GCPRO the Lisp string we are
4132 iterating.
4133 (bidi_push_it, bidi_pop_it): New functions.
4134 (bidi_initialize): Initialize the bidi cache start stack pointer.
4135 (bidi_cache_ensure_space): New function, refactored from part of
4136 bidi_cache_iterator_state. Don't assume the required size is just
4137 one BIDI_CACHE_CHUNK away.
4138 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4139 (bidi_count_bytes, bidi_char_at_pos): New functions.
4140 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4141 always valid if bidi_cache_idx is valid.
4142 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4143 is valid if it's going to be used.
4144 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4145 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
4146 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4147 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
4148 (bidi_find_other_level_edge, bidi_cache_start_stack):
4149 All variables related to cache indices are now EMACS_INT.
c965adc5 4150
0bb23927
EZ
4151 * dispextern.h (struct bidi_string_data): New structure.
4152 (struct bidi_it): New member `string'. Make flag members be 1-bit
4153 fields, and put them last in the struct.
640c8776
SM
4154 (compute_display_string_pos, compute_display_string_end):
4155 Update prototypes.
0bb23927
EZ
4156 (bidi_push_it, bidi_pop_it): Add prototypes.
4157 (struct iterator_stack_entry): New members bidi_p,
4158 paragraph_embedding, and from_disp_prop_p.
4159 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
4160 (bidi_shelve_cache, bidi_unshelve_cache):
4161 Declare prototypes.
0bb23927
EZ
4162
4163 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4164 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4165 and vector-like objects.
4166
4167 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4168 cache around display iteration.
4169
4170 * window.c (Fwindow_end, window_scroll_pixel_based)
4171 (displayed_window_lines, Frecenter): Save and restore the bidi
4172 cache around display iteration.
4173
3bbd2265
LMI
41742011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4175
4176 * editfns.c (Fdelete_region): Clarify the use of the named
4177 parameters (bug#6788).
4178
adc47434
MR
41792011-07-14 Martin Rudalics <rudalics@gmx.at>
4180
4181 * indent.c (Fvertical_motion): Set and restore w->pointm when
4182 saving and restoring the window's buffer (Bug#9006).
4183
837c31f8
LMI
41842011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4185
4186 * editfns.c (Fstring_to_char): Clarify just what is returned
4187 (bug#6576). Text by Eli Zaretskii.
4188
ac389d0c
JB
41892011-07-13 Juanma Barranquero <lekktu@gmail.com>
4190
4191 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4192
0be0ce47
EZ
41932011-07-13 Eli Zaretskii <eliz@gnu.org>
4194
4195 * buffer.c (mmap_find): Fix a typo.
4196
cd18e7e3
JB
41972011-07-13 Johan Bockgård <bojohan@gnu.org>
4198
4199 Fix execution of x selection hooks.
4200 * xselect.c (Qx_lost_selection_functions)
4201 (Qx_sent_selection_functions): New vars.
4202 (syms_of_xselect): DEFSYM them.
4203 (x_handle_selection_request): Pass Qx_sent_selection_functions
4204 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4205 (x_handle_selection_clear,x_clear_frame_selections):
4206 Pass Qx_lost_selection_functions rather than
4207 Vx_lost_selection_functions to Frun_hook_with_args.
4208
47ea7f44
PE
42092011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4210
ac389d0c 4211 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
4212 The old code sometimes used this field without initializing it.
4213
47ea7f44
PE
4214 * alloc.c (gc_sweep): Don't read past end of array.
4215 In theory, the old code could also have corrupted Emacs internals,
4216 though it'd be very unlikely.
4217
bc985c87
AS
42182011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4219
4220 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 4221 argument. (Bug#4026)
bc985c87 4222
0cf34688
LMI
42232011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4224
b3dadd76
LMI
4225 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4226 key" (bug#4257).
4227
0cf34688
LMI
4228 * window.c (Fset_window_start): Doc fix (bug#4199).
4229 (Fset_window_hscroll): Ditto.
4230
270768cd
PE
42312011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4232
077e3dda 4233 Fix minor new problems caught by GCC 4.6.1.
270768cd 4234 * term.c (init_tty): Remove unused local.
490011a6 4235 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 4236 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 4237 not used otherwise.
270768cd 4238
b1f58454
CY
42392011-07-12 Chong Yidong <cyd@stupidchicken.com>
4240
4241 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4242
22b9578d
LMI
42432011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4244
6e70ab07
LMI
4245 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4246 are the mini-buffer and the echo area (bug#3320).
4247
22b9578d
LMI
4248 * term.c (init_tty): Remove support for supdup, c10 and perq
4249 terminals, which are no longer supported (bug#1482).
4250
8974cc9f
JB
42512011-07-10 Johan Bockgård <bojohan@gnu.org>
4252
4253 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4254
a560d974
JD
42552011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4256
4257 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4258 for non-popups (Bug#3642).
4259
1dae0f0a
AS
42602011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4261
268c2c36 4262 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 4263 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
4264 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4265 * cm.c (losecursor): Likewise.
1dae0f0a
AS
4266 * data.c (fmod): Likewise.
4267 * dispnew.c (swap_glyphs_in_rows): Likewise.
4268 * emacs.c (memory_warning_signal): Likewise.
4269 * floatfns.c (float_error): Likewise.
4270 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4271 (otf_open, font_otf_capability, generate_otf_features)
4272 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4273 Likewise.
4274 * image.c (pbm_read_file): Likewise.
4275 * indent.c (string_display_width): Likewise.
4276 * intervals.c (check_for_interval, search_for_interval)
4277 (inc_interval_count, count_intervals, root_interval)
4278 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4279 * lread.c (defalias): Likewise.
268c2c36 4280 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
4281 * regex.c (set_image_of_range_1, set_image_of_range)
4282 (regex_grow_registers): Likewise.
4283 * sysdep.c (strerror): Likewise.
4284 * termcap.c (valid_filename_p, tprint, main): Likewise.
4285 * tparam.c (main): Likewise.
4286 * unexhp9k800.c (run_time_remap, save_data_space)
4287 (update_file_ptrs, read_header, write_header, calculate_checksum)
4288 (copy_file, copy_rest, display_header): Likewise.
4289 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4290 Likewise.
4291 * xdisp.c (check_it): Likewise.
4292 * xfaces.c (register_color, unregister_color, unregister_colors):
4293 Likewise.
4294 * xfns.c (print_fontset_result): Likewise.
4295 * xrdb.c (member, fatal, main): Likewise.
4296
99033785
PE
42972011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4298
4299 Fix minor problems found by static checking (Bug#9031).
4300 * chartab.c (char_table_set_range, map_sub_char_table):
4301 Remove unused locals.
4302 (uniprop_table): Now static.
4303 * composite.c (_work_char): Remove unused static var.
4304
9cb2ac56
JB
43052011-07-09 Juanma Barranquero <lekktu@gmail.com>
4306
4307 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4308
f25661f0
JD
43092011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4310
4311 * gtkutil.c (qttip_cb): Remove code without function.
4312
8278c4fe
EZ
43132011-07-09 Eli Zaretskii <eliz@gnu.org>
4314
4315 * w32.c (pthread_sigmask): New stub.
4316
1692ae2d 43172011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 4318
8a6ebd58 4319 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
4320 sigprocmask is portable only for single-threaded applications, and
4321 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
4322 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4323 (LIBES): Use it.
4324 * callproc.c (Fcall_process):
4325 * process.c (create_process):
4326 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4327 Use pthread_sigmask, not sigprocmask.
123403e4 4328
1b854618
JD
43292011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4330
4331 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4332 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4333 wrong (Bug#8591).
4334
3fe4b549
JD
43352011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4336
0ce7e563
JD
4337 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4338 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4339 (xg_hide_tooltip): Fix comment.
4340
3fe4b549
JD
4341 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4342 in registerServicesMenuSendTypes.
4343 (validRequestorForSendType): Don't check ns_return_types.
4344
4345 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4346 ns_return_type.
4347
5df75e47
JR
43482011-07-08 Jason Rumney <jasonr@gnu.org>
4349
22610910
JR
4350 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4351 SH_SHOW for hidden windows (Bug#5482).
4352
5df75e47
JR
4353 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4354 frame struct members of non-existent frames (Bug#6284).
4355
699c10bd
JD
43562011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4357
4393663b
JD
4358 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4359 variable firstTime not needed on OSX >= 10.6.
4360 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4361 >= 10.5. Use setKnobProportion, setDoubleValue.
4362
4363 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4364 (MAC_OS_X_VERSION_10_5): Define if not defined.
4365 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4366 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4367 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4368
4369 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4370 cString and lossyCString on OSX >= 10.4
4371
58179cce 4372 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
4373 sizeToFit on OSX >= 10.2.
4374
4375 * nsimage.m (allocInitFromFile): Don't use deprecated method
4376 bestRepresentationForDevice on OSX >= 10.6.
4377
4378 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4379 to avoid warning.
4380
4381 * emacs.c: Declare unexec_init_emacs_zone.
4382
a63e0781
JD
4383 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4384
699c10bd
JD
4385 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4386
4387 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4388 on svcsMenu (Bug#8842).
4389
4390 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4391 ns_return_types.
4392 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4393
4394 * nsterm.m (QUTF8_STRING): Declare.
4395 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4396 (validRequestorForSendType): Return type is (id).
4397 Change indexOfObjectIdenticalTo to indexOfObject.
4398 Check if we have local selection before returning self (Bug#8842).
4399 (writeSelectionToPasteboard): Put local selection into paste board
4400 if we have a local selection (Bug#8842).
4401 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4402
4403 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4404 (ns_get_local_selection): Declare.
4405
54e10184
LMI
44062011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4407
9888ff71
LMI
4408 * keymap.c (describe_map_tree): Don't insert a double newline at
4409 the end of the buffer (bug#1169) and return whether we inserted
4410 something.
4411
54e10184
LMI
4412 * callint.c (Fcall_interactively): Change "reading args" to
4413 "providing args" to try to clarify what it does (bug#1010).
4414
15fa4783
KH
44152011-07-07 Kenichi Handa <handa@m17n.org>
4416
4417 * composite.c (composition_compute_stop_pos): Ignore a static
4418 composition starting before CHARPOS (Bug#8915).
4419
4420 * xdisp.c (handle_composition_prop): Likewise.
4421
a8815b00
EZ
44222011-07-07 Eli Zaretskii <eliz@gnu.org>
4423
4424 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4425 (Bug#9015)
4426
ef7b981d 44272011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
4428
4429 * character.h (unicode_category_t): New enum type.
4430
4431 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4432 (Qchar_code_property_table): New variable.
4433 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4434 (UNIPROP_COMPRESSED_FORM_P): New macros.
4435 (char_table_ascii): Uncompress the compressed values.
4436 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4437 Uncompress the compressed values.
ac389d0c 4438 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
4439 (char_table_ref_and_range): Uncompress the compressed values.
4440 (sub_char_table_set): New arg is_uniprop. Callers changed.
4441 Uncompress the compressed values.
4442 (sub_char_table_set_range): Args changed. Callers changed.
4443 (char_table_set_range): Adjuted for the above change.
4444 (map_sub_char_table): Delete args default_val and parent. Add arg
4445 top. Give decoded values to a Lisp function.
640c8776 4446 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
4447 values to a Lisp function. Gcpro more variables.
4448 (uniprop_table_uncompress)
4449 (uniprop_decode_value_run_length): New functions.
4450 (uniprop_decoder, uniprop_decoder_count): New variables.
4451 (uniprop_get_decoder, uniprop_encode_value_character)
4452 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4453 New functions.
4454 (uniprop_encoder, uniprop_encoder_count): New variables.
4455 (uniprop_get_encoder, uniprop_table)
4456 (Funicode_property_table_internal, Fget_unicode_property_internal)
4457 (Fput_unicode_property_internal): New functions.
4458 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4459 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 4460 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
4461 char-code-property-alist.
4462
640c8776 4463 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
4464 Vunicode_category_table.
4465
640c8776 4466 * font.c (font_range): Adjust for the change of
c805dec0
KH
4467 Vunicode_category_table.
4468
76b397fb
DN
44692011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4470
4471 * m/iris4d.h: Remove file, move contents ...
4472 * s/irix6-5.h: ... here.
4473
22b4128e
PE
44742011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4475
4476 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
4477 * alloc.c (mark_buffer):
4478 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4479 (clone_per_buffer_values): Don't assume that
22b4128e
PE
4480 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4481 This isn't true in general, and it's particularly not true
4482 if Emacs is configured with --with-wide-int.
4483 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4484 New macros, used in the buffer.c change.
4485
869795d6
JD
44862011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4487
4488 * xsettings.c: Use both GConf and GSettings if both are available.
4489 (store_config_changed_event): Add comment.
4490 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4491 (store_tool_bar_style_changed): New functions.
5e617bc2 4492 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
4493 (struct xsettings): Move font inside HAVE_XFT.
4494 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 4495 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 4496 Move inside HAVE_XFT.
640c8776 4497 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
4498 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4499 also.
4500 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 4501 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 4502 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
4503 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4504 (parse_settings): Move check for font inside HAVE_XFT.
4505 (read_settings, apply_xft_settings): Add comment.
4506 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4507 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4508 call store_font_name_changed.
4509 (xft_settings_event): Add comment.
4510 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4511 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4512 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4513 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4514 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
4515 (xsettings_get_system_font, xsettings_get_system_normal_font):
4516 Add comment.
869795d6 4517
d8ed26bd
PE
45182011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4519
4520 Random fixes. E.g., (random) never returned negative values.
4521 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4522 subseconds part to the entropy, as that's a bit more random.
4523 Prefer signed to unsigned, since the signedness doesn't matter and
4524 in general we prefer signed. When given a limit, use a
4525 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4526 latter isn't right if USE_2_TAGS_FOR_INTS.
4527 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4528 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4529
cabf1cac
SM
45302011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4531
4532 * textprop.c (text_property_stickiness):
4533 Obey Vtext_property_default_nonsticky.
4534 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4535 * w32fns.c (syms_of_w32fns):
4536 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4537
6e9b2be9
PE
45382011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4539
4540 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4541 This is more efficient than Ffile_directory_p and avoids a minor race.
4542
90186c68
LMI
45432011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4544
7c301272
LMI
4545 * buffer.c (Foverlay_put): Say what the return value is
4546 (bug#7835).
4547
c4f2d8d4
LMI
4548 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4549 is a directory before asking whether to use the file name
4550 (bug#7564).
ad637907
LMI
4551 (barf_or_query_if_file_exists): Make the "File is a directory"
4552 error be more correct.
c4f2d8d4 4553
90186c68
LMI
4554 * fns.c (Frequire): Remove the mention of the .gz files, since
4555 that's installation-specific, but keep the mention of
4556 `get-load-suffixes'.
4557
da64016e
PE
45582011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4559
4560 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4561 Report string overflow if the output is too long.
4562
7d47b580
JB
45632011-07-04 Juanma Barranquero <lekktu@gmail.com>
4564
a555cb87
JB
4565 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4566 (syms_of_gnutls): Remove duplicate DEFSYM for
4567 Qgnutls_bootprop_verify_hostname_error, an error for
4568 Qgnutls_bootprop_verify_error (which is no longer used).
4569
7d47b580
JB
4570 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4571 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4572 Also (re)move comments that are misplaced or no longer relevant.
4573
1e49bfab
LMI
45742011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4575
4576 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4577
1485f4c0
CY
45782011-07-03 Chong Yidong <cyd@stupidchicken.com>
4579
4580 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4581 and background color parameters if they have been changed.
4582
a9ab721e
LMI
45832011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4584
4585 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4586
cf7cff57
PE
45872011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4588
2e13213d
PE
4589 * xsettings.c (SYSTEM_FONT): Define only when used.
4590 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4591
cf7cff57
PE
4592 * keymap.c (access_keymap_1): Now static.
4593
7a8e04f7
CY
45942011-07-02 Chong Yidong <cyd@stupidchicken.com>
4595
4596 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4597 leave any prefix arg for the up event (Bug#1586).
4598
61352f62
LMI
45992011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4600
69bb1ef7
LMI
4601 * lread.c (syms_of_lread): Mention single symbols defined by
4602 `defvar' or `defconst' (bug#7154).
4603
61352f62 4604 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 4605 (Frequire): Mention get-load-suffixes.
61352f62 4606
28545e04
MR
46072011-07-02 Martin Rudalics <rudalics@gmx.at>
4608
4609 * window.h (window): Remove clone_number slot.
4610 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4611 Remove.
4612 (make_parent_window, make_window, saved_window)
4613 (Fset_window_configuration, save_window_save): Don't deal with
4614 clone numbers.
4615 * buffer.c (Qclone_number): Remove declaration.
4616 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4617
3349e122
SM
46182011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4619
4620 Add multiple inheritance to keymaps.
4621 * keymap.c (Fmake_composed_keymap): New function.
4622 (Fset_keymap_parent): Simplify.
4623 (fix_submap_inheritance): Remove.
4624 (access_keymap_1): New function extracted from access_keymap to handle
4625 embedded parents and handle lists of maps.
4626 (access_keymap): Use it.
4627 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4628 (Fcopy_keymap): Handle embedded parents.
4629 (Fcommand_remapping, define_as_prefix): Simplify.
4630 (Fkey_binding): Simplify.
4631 (syms_of_keymap): Move minibuffer-local-completion-map,
4632 minibuffer-local-filename-completion-map,
4633 minibuffer-local-must-match-map, and
4634 minibuffer-local-filename-must-match-map to Elisp.
4635 (syms_of_keymap): Defsubr make-composed-keymap.
4636 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4637 (parse_menu_item): Trivial simplification.
4638
3279eb87
GM
46392011-07-01 Glenn Morris <rgm@gnu.org>
4640
4641 * Makefile.in (SETTINGS_LIBS): Fix typo.
4642
4550efdf
KI
46432011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4644
4645 * coding.c (Fencode_coding_string): Record the last coding system
4646 used, as the function doc string says (bug#8738).
4647
0949d2b6
JD
46482011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4649
4650 * xsettings.c (store_monospaced_changed): Take new font as arg and
4651 check for change against current_mono_font.
4652 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4653 (emacs_settings_constructor, emacs_settings_get_property)
4654 (emacs_settings_set_property, emacs_settings_class_init)
4655 (emacs_settings_init, gsettings_obj): Remove.
4656 (something_changedCB): New function for HAVE_GSETTINGS.
4657 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4658 with value as argument.
4659 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4660 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 4661 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
4662 "changed".
4663
4664 * xgselect.c: Add defined (HAVE_GSETTINGS).
4665 (xgselect_initialize): Ditto.
4666
4667 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4668 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4669 xg_select.
4670
bbc6b304
PE
46712011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4672
4673 * eval.c (struct backtrace): Simplify and port the data structure.
4674 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4675 signed bit field, as this assumption is not portable and it makes
4676 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4677 "char debug_on_exit : 1" as this is not portable either; instead,
4678 use the portable "unsigned int debug_on_exit : 1". Remove unused
4679 member evalargs. Remove obsolete comments about cc bombing out.
4680
9851bfc5
JD
46812011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4682
51bb811f 4683 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
4684 Let HAVE_GSETTINGS override HAVE_GCONF.
4685 (store_monospaced_changed): New function.
4686 (EMACS_SETTINGS): A new type derived from GObject to handle
4687 GSettings notifications.
4688 (emacs_settings_constructor, emacs_settings_get_property)
4689 (emacs_settings_set_property, emacs_settings_class_init):
4690 New functions.
4691 (gsettings_client, gsettings_obj): New variables.
4692 (GSETTINGS_SCHEMA): New define.
4693 (something_changedCB): Call store_monospaced_changed.
4694 (init_gsettings): New function.
4695 (xsettings_initialize): Call init_gsettings.
4696 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4697 to NULL.
4698
640c8776 4699 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
4700 GCONF_CFLAGS/LIBS.
4701
5386012d
MR
47022011-06-29 Martin Rudalics <rudalics@gmx.at>
4703
4704 * window.c (resize_root_window, grow_mini_window)
4705 (shrink_mini_window): Rename Qresize_root_window to
4706 Qwindow_resize_root_window and Qresize_root_window_vertically to
4707 Qwindow_resize_root_window_vertically.
4708
f13e0b08
PE
47092011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4710
4711 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4712
94515237
JB
47132011-06-27 Juanma Barranquero <lekktu@gmail.com>
4714
4715 * makefile.w32-in: Redesign dependencies so they reflect more
4716 clearly which files are directly included by each source file,
4717 and not through other includes.
4718
e43b6e43
MR
47192011-06-27 Martin Rudalics <rudalics@gmx.at>
4720
4721 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4722 (sort_overlays, overlay_strings): When an overlay's clone number
4723 matches the window's clone number process the overlay even if
4724 the overlay's window property doesn't match the current window.
4725
d68443dc
MR
4726 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4727 (Fwindow_hchild): Rename to Fwindow_left_child.
4728 (Fwindow_next): Rename to Fwindow_next_sibling.
4729 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
4730 (resize_window_check): Rename to window_resize_check.
4731 (resize_window_apply): Rename to window_resize_apply.
4732 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4733 (Fdelete_other_windows_internal, resize_frame_windows)
4734 (Fsplit_window_internal, Fdelete_window_internal)
4735 (grow_mini_window, shrink_mini_window)
4736 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 4737
c7e73be5
JD
47382011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4739
4740 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4741 (emacs_fixed_set_min_size): Remove.
4742 (emacs_fixed_new): Take frame as argument.
4743
4744 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4745 (_EmacsFixedPrivate): Remove minwidth/height.
4746 Add struct frame *f.
4747 (emacs_fixed_init): Initialize priv->f.
4748 (get_parent_class, emacs_fixed_set_min_size): Remove.
4749 (emacs_fixed_new): Set priv->f to argument.
4750 (emacs_fixed_get_preferred_width)
4751 (emacs_fixed_get_preferred_height): Use min_width/height from
4752 frames size_hint to set minimum and natural (Bug#8919).
4753 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4754 and use min_width/height from frames size_hint to set
4755 min_width/height (Bug#8919).
4756
4757 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
4758 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4759 Fix indentation.
c7e73be5 4760
cf99dcf8
EZ
47612011-06-26 Eli Zaretskii <eliz@gnu.org>
4762
4763 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4764 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4765 called at ZV.
4766
029529ac
CY
47672011-06-26 Chong Yidong <cyd@stupidchicken.com>
4768
4769 * process.c (wait_reading_process_output): Bypass select if
4770 waiting for a cell while ignoring keyboard input, and input is
4771 pending. Suggested by Jan Djärv (Bug#8869).
4772
7a7ef429
PE
47732011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4774
4775 Use gnulib's dup2 module instead of rolling our own.
4776 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4777
11fdef7d 47782011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
4779
4780 * dispnew.c (scrolling_window): Before scrolling, turn off a
4781 mouse-highlight in the window being scrolled.
4782
cd3520a4
JB
47832011-06-24 Juanma Barranquero <lekktu@gmail.com>
4784
4785 Move DEFSYM to lisp.h and use everywhere.
4786
4787 * character.h (DEFSYM): Move declaration...
4788 * lisp.h (DEFSYM): ...here.
4789
4790 * gnutls.c:
4791 * minibuf.c:
4792 * w32menu.c:
4793 * w32proc.c:
4794 * w32select.c: Don't include character.h.
4795
4796 * alloc.c (syms_of_alloc):
4797 * buffer.c (syms_of_buffer):
4798 * bytecode.c (syms_of_bytecode):
4799 * callint.c (syms_of_callint):
4800 * casefiddle.c (syms_of_casefiddle):
4801 * casetab.c (init_casetab_once):
4802 * category.c (init_category_once, syms_of_category):
4803 * ccl.c (syms_of_ccl):
4804 * cmds.c (syms_of_cmds):
4805 * composite.c (syms_of_composite):
4806 * dbusbind.c (syms_of_dbusbind):
4807 * dired.c (syms_of_dired):
4808 * dispnew.c (syms_of_display):
4809 * doc.c (syms_of_doc):
4810 * editfns.c (syms_of_editfns):
4811 * emacs.c (syms_of_emacs):
4812 * eval.c (syms_of_eval):
4813 * fileio.c (syms_of_fileio):
4814 * fns.c (syms_of_fns):
4815 * frame.c (syms_of_frame):
4816 * fringe.c (syms_of_fringe):
4817 * insdel.c (syms_of_insdel):
4818 * keymap.c (syms_of_keymap):
4819 * lread.c (init_obarray, syms_of_lread):
4820 * macros.c (syms_of_macros):
4821 * msdos.c (syms_of_msdos):
4822 * print.c (syms_of_print):
4823 * process.c (syms_of_process):
4824 * search.c (syms_of_search):
4825 * sound.c (syms_of_sound):
4826 * syntax.c (init_syntax_once, syms_of_syntax):
4827 * terminal.c (syms_of_terminal):
4828 * textprop.c (syms_of_textprop):
4829 * undo.c (syms_of_undo):
4830 * w32.c (globals_of_w32):
4831 * window.c (syms_of_window):
4832 * xdisp.c (syms_of_xdisp):
4833 * xfaces.c (syms_of_xfaces):
4834 * xfns.c (syms_of_xfns):
4835 * xmenu.c (syms_of_xmenu):
4836 * xsettings.c (syms_of_xsettings):
4837 * xterm.c (syms_of_xterm): Use DEFSYM.
4838
4228cf16
TZ
48392011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4840
cd3520a4 4841 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 4842
7fcccf1e
PE
48432011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4844
7efb4e0e
PE
4845 Integer and buffer overflow fixes (Bug#8873).
4846
ff5844ad
PE
4847 * print.c (printchar, strout): Check for string overflow.
4848 (PRINTPREPARE, printchar, strout):
4849 Don't set size unless allocation succeeds.
4850
90532f02
PE
4851 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4852 for sizes. Check for string overflow more accurately.
4853 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4854
6d84508d
PE
4855 * macros.c: Integer and buffer overflow fixes.
4856 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4857 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4858 Use ptrdiff_t, not int, for sizes.
4859 Don't increment bufsize until after realloc succeeds.
4860 Check for size-calculation overflow.
4861 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4862
437b2cb4
PE
4863 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4864
8b9ac8b4
PE
4865 * lread.c: Integer overflow fixes.
4866 (read_integer): Radix is now EMACS_INT, not int,
4867 to improve quality of diagnostics for out-of-range radices.
4868 Calculate buffer size correctly for out-of-range radices.
4869 (read1): Check for integer overflow in radices, and in
4870 read-circle numbers.
82cb60d3
PE
4871 (read_escape): Avoid int overflow.
4872 (Fload, openp, read_buffer_size, read1)
4873 (substitute_object_recurse, read_vector, read_list, map_obarray):
4874 Use ptrdiff_t, not int, for sizes.
4875 (read1): Use EMACS_INT, not int, for sizes.
20270765 4876 Check for size overflow.
8b9ac8b4 4877
7fcccf1e
PE
4878 * image.c (cache_image): Check for size arithmetic overflow.
4879
bfbbd7e7
PE
4880 * lread.c: Integer overflow issues.
4881 (saved_doc_string_size, saved_doc_string_length)
4882 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4883 Now ptrdiff_t, not int.
4884 (read1): Don't assume doc string length fits in int. Check for
4885 out-of-range doc string lengths.
4886 (read_list): Don't assume file position fits in int.
39019e54 4887 (read_escape): Check for hex character overflow.
bfbbd7e7 4888
4e323265
LL
48892011-06-22 Leo Liu <sdl.web@gmail.com>
4890
4891 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4892 Move to minibuffer.el.
4893
85fece3e
PE
48942011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4895
20b84ce9 4896 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
4897 The following patches are for when GLYPH_DEBUG && !XASSERT.
4898 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4899 * dispnew.c (flush_stdout):
4900 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4901 Mark as externally visible.
4902 * dispnew.c (check_window_matrix_pointers): Now static.
4903 * dispnew.c (window_to_frame_vpos):
4904 * xfns.c (unwind_create_frame):
4905 * xterm.c (x_check_font): Remove unused local.
4906 * scroll.c (CHECK_BOUNDS):
4907 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4908 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4909 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4910 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4911 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4912 Now static.
4913 (debug_method_add): Use va_list and vsprintf rather than relying
4914 on undefined behavior with wrong number of arguments.
4915 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4916 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4917 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4918 since we're not interested in debugging glyphs with old libraries.
4919 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4920 GCC 4.6.0's static checking.
4921
0766b489
PE
49222011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4923
31fd4b32
PE
4924 Integer overflow and signedness fixes (Bug#8873).
4925 A few related buffer overrun fixes, too.
4926
b79e8648
PE
4927 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4928
0766b489
PE
4929 * dispextern.h (struct face.stipple):
4930 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4931 (x_bitmap_mask, x_allocate_bitmap_record)
4932 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4933 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4934 (x_create_bitmap_from_xpm_data):
4935 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4936 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4937 (.bitmaps_last):
4938 * xfaces.c (load_pixmap):
4939 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4940 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4941 (.bitmaps_last, struct x_output.icon_bitmap):
4942 Use ptrdiff_t, not int, for bitmap indexes.
4943 (x_allocate_bitmap_record): Check for size overflow.
4944 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4945
b081724f
PE
4946 Use ptrdiff_t, not int, for overlay counts.
4947 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4948 * editfns.c (overlays_around, get_pos_property):
4949 * textprop.c (get_char_property_and_overlay):
4950 * xdisp.c (next_overlay_change, note_mouse_highlight):
4951 * xfaces.c (face_at_buffer_position):
21514da7
PE
4952 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4953 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4954 (Fnext_overlay_change, Fprevious_overlay_change)
4955 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 4956 Use ptrdiff_t, not int, for sizes.
21514da7 4957 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 4958
3de73e5e
PE
4959 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4960
2606c57b
PE
4961 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4962 (x_session_initialize): Do not assume string length fits in int.
4963
aaafe47a
PE
4964 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4965 This is unlikely, but can occur if DPI is outlandish.
4966
2674ddc8 4967 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
4968 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4969
28154962
PE
4970 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4971 * xrdb.c (magic_file_p, search_magic_path):
4972 Omit last arg SUFFIX; it was always 0. All callers changed.
4973 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4974
7de51af5
PE
4975 * xfont.c (xfont_match): Avoid need for strlen.
4976
25ed6cc3
PE
4977 * xfns.c: Don't assume strlen fits in int.
4978 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4979
4eab31dd
PE
4980 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4981 not unsigned long, as we prefer signed integers. All callers changed.
4982 Detect integer overflow in repeat count.
4983 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 4984 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 4985
171e2a58
PE
4986 * termcap.c: Don't assume sizes fit in int and never overflow.
4987 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4988 (gobble_line): Check for size-calculation overflow.
4989
ad39faca 4990 * minibuf.c (Fread_buffer):
6e5bb2dc 4991 * lread.c (intern, intern_c_string):
74ca2eb3
PE
4992 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4993 Don't assume string length fits in int.
4994
52c61c22 4995 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
4996 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4997
b5b8c9e5
PE
4998 * font.c: Don't assume string length fits in int.
4999 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
5000 Use ptrdiff_t, not int.
ccd6111c
PE
5001 (font_intern_prop): Don't assume string length fits in int.
5002 Don't assume integer property fits in fixnum.
5003 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 5004
882f0d81 5005 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 5006 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
5007 Reformulate so as not to need the command string.
5008 Invoke gzip -cd rather than gunzip, as it's more portable.
5009 (lock_info_type, lock_file_1, lock_file):
5010 Don't assume pid_t and time_t fit in unsigned long.
5011 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
5012 (current_lock_owner): Prefer signed type for sizes.
5013 Use memcpy, not strncpy, where memcpy is what is really wanted.
5014 Don't assume (via atoi) that time_t and pid_t fit in int.
5015 Check for time_t and/or pid_t out of range, e.g., via a network share.
5016 Don't alloca where an auto var works fine.
5017
93f4cf88
PE
5018 * fileio.c: Fix some integer overflow issues.
5019 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
5020 Don't assume string length fits in int.
5021 (directory_file_name): Don't assume string length fits in long.
5022 (make_temp_name): Don't assume pid fits in int, or that its print
5023 length is less than 20.
5024
f3e92b69
PE
5025 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
5026
1bfdaf10
PE
5027 * coding.c (make_subsidiaries): Don't assume string length fits in int.
5028
35016e9a
PE
5029 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
5030
3d1e65a1
PE
5031 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
5032 We prefer signed integers, even for size calculations.
5033
0b963a93
PE
5034 * emacs.c: Don't assume string length fits in 'int'.
5035 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
5036 (main): Don't invoke strlen when not needed.
5037
573f4b54
PE
5038 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5039 (XD_DEBUG_MESSAGE): Don't waste a byte.
5040
989f33ba
PE
5041 * callproc.c (getenv_internal_1, getenv_internal)
5042 (Fgetenv_internal):
965d34eb
PE
5043 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5044
e4d29b33
PE
5045 * lread.c (invalid_syntax): Omit length argument.
5046 All uses changed. This doesn't fix a bug, but it simplifies the
5047 code away from its former Hollerith-constant appearance, and it's
5048 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 5049 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 5050
eb49b136
PE
5051 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5052 This didn't break anything, but it didn't help either.
5053 It's confusing to put a bogus integer in a place where the actual
5054 value does not matter.
9f62aeb1 5055 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 5056 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 5057
15375a22
PE
5058 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5059 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5060 implementation.
b61cc01c
PE
5061 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5062 We prefer signed types, and the value cannot exceed the EMACS_INT
5063 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
5064 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5065 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5066 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 5067
53b2623d
PE
5068 * indent.c (sane_tab_width): New function.
5069 (current_column, scan_for_column, Findent_to, position_indentation)
5070 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 5071 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 5072
51cab52b 5073 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 5074
f2ed8a70
PE
5075 * lisp.h (lint_assume): New macro.
5076 * composite.c (composition_gstring_put_cache):
5077 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5078
abe80cc6
PE
5079 * editfns.c, insdel.c:
5080 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 5081
b02c740e
PE
5082 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5083
ebc96716
PE
5084 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5085
b4e50fa0 5086 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 5087 Use much-faster test for byte-length change.
311d5d7c 5088 Don't assume string byte-length fits in 'int'.
a4cf38e4 5089 Check that character arg fits in 'int'.
85461888 5090 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 5091
c0c1ee9f
PE
5092 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5093
a498d7f4
PE
5094 * fns.c (concat): Catch string overflow earlier.
5095 Do not rely on integer wraparound.
5096
51cab52b
PE
5097 * dispextern.h (struct it.overlay_strings_charpos)
5098 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
5099 * xdisp.c (forward_to_next_line_start)
5100 (back_to_previous_visible_line_start)
5101 (reseat_at_next_visible_line_start, next_element_from_buffer):
5102 Don't arbitrarily truncate the value of 'selective' to int.
5103
76031fad
PE
5104 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5105
5eb55db9
PE
5106 * composite.c: Don't truncate sizes to 'int'.
5107 (composition_gstring_p, composition_reseat_it)
5108 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
5109 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5110 not EMACS_UINT, for indexes.
5eb55db9 5111
0703a717
PE
5112 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5113
d6202519
PE
5114 * buffer.c: Include <verify.h>.
5115 (struct sortvec.priority, struct sortstr.priority):
8961a454 5116 Now EMACS_INT, not int.
c20998a7 5117 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
5118 (struct sortstr.size, record_overlay_string)
5119 (struct sortstrlist.size, struct sortlist.used):
5120 Don't truncate size to int.
5121 (record_overlay_string): Check for size-calculation overflow.
d6202519 5122 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 5123
d5a19415
JM
51242011-06-22 Jim Meyering <meyering@redhat.com>
5125
029529ac 5126 Don't leak an XBM-image-sized buffer
d5a19415
JM
5127 * image.c (xbm_load): Free the image buffer after using it.
5128
a9041e6c
PE
51292011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5130
5131 Port to Sun C.
5132 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5133 that Sun C diagnosed.
5134 * fns.c (secure_hash): Fix pointer signedness issue.
5135 * intervals.c (static_offset_intervals): New function.
5136 (offset_intervals): Use it.
5137
7f3f739f
LL
51382011-06-21 Leo Liu <sdl.web@gmail.com>
5139
5140 * deps.mk (fns.o):
5141 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5142 sha512.h.
5143
5144 * fns.c (secure_hash): Rename from crypto_hash_function and change
5145 the first arg to accept symbols.
5b66d427 5146 (Fsecure_hash): New primitive.
7f3f739f
LL
5147 (syms_of_fns): New symbols.
5148
76147d94
DD
51492011-06-20 Deniz Dogan <deniz@dogan.se>
5150
5151 * process.c (Fset_process_buffer): Clarify return value in
5152 docstring.
5153
7d7d0045
CY
51542011-06-18 Chong Yidong <cyd@stupidchicken.com>
5155
5156 * dispnew.c (add_window_display_history): Use BVAR.
5157
5158 * xdisp.c (debug_method_add): Use BVAR.
5159 (check_window_end, dump_glyph_matrix, dump_glyph)
5160 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5161
5162 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5163 Likewise.
5164
5165 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5166 check till after the cache is created in init_frame_faces.
5167
ff2bc410
SM
51682011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5169
5170 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5171
28177add
PE
51722011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5173
dd3482fe
PE
5174 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5175 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5176 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5177
393d71f3 5178 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
5179 * fileio.c (Finsert_file_contents):
5180 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5181 Remove the old (too-loose) buffer overflow checks.
5182 They weren't needed, since make_gap checks for buffer overflow.
5183 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5184 The old code merely checked for Emacs fixnum overflow, and relied
5185 on undefined (wraparound) behavior. The new code avoids undefined
5186 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5187
2e6813b0 5188 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
5189 Tune. Don't use wider integers than needed. Don't use alloca.
5190 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 5191
599a9e4f
PE
5192 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5193
99561444
PE
5194 * insdel.c, lisp.h (buffer_overflow): New function.
5195 (insert_from_buffer_1, replace_range, replace_range_2):
5196 * insdel.c (make_gap_larger):
5197 * editfns.c (Finsert_char):
5198 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5199
28177add
PE
5200 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5201
e69dafad
PE
52022011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5203
4baa020d 5204 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 5205
b1c46f02
PE
5206 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5207 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5208
e69dafad
PE
5209 * fileio.c: Don't assume EMACS_INT fits in off_t.
5210 (emacs_lseek): New static function.
5211 (Finsert_file_contents, Fwrite_region): Use it.
5212 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5213
566684ea
PE
5214 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5215
e6966cd6
PE
5216 * fns.c: Don't overflow int when computing a list length.
5217 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5218 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5219 truncation on 64-bit hosts. Check for QUIT every
5220 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5221 faster and is responsive enough.
5222 (Flength): Report an error instead of overflowing an integer.
5223 (Fsafe_length): Return a float if the value is not representable
5224 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 5225 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 5226 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 5227
dd0b0efb
PE
5228 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5229 (header_size, word_size): New constants.
5230 (allocate_vectorlike): Don't check size overflow here.
5231 (allocate_vector): Check it here instead, since this is the only
5232 caller of allocate_vectorlike that could cause overflow.
5233 Check that the new vector's length is representable as a fixnum.
5234
86fe5cfe
PE
5235 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5236 The previous code was bogus. For example, next_almost_prime (32)
5237 returned 39, which is undesirable as it is a multiple of 3; and
5238 next_almost_prime (24) returned 25, which is a multiple of 5 so
5239 why was the code bothering to check for multiples of 7?
5240
80e88859
PE
5241 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5242
4a2f0ad6
PE
5243 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5244
f66c7cf8
PE
5245 Variadic C functions now count arguments with ptrdiff_t.
5246 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5247 Back then I didn't know that the Emacs coding style prefers signed int.
5248 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
5249 were being counted with int, which may truncate counts on 64-bit
5250 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
5251 * lisp.h (struct Lisp_Subr.function.aMANY)
5252 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5253 Arg counts are now ptrdiff_t, not size_t.
5254 All variadic functions and their callers changed accordingly.
5255 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5256 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5257 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5258 * callint.c (Fcall_interactively): Check arg count for overflow,
5259 to avoid potential buffer overrun. Use signed char, not 'int',
5260 for 'varies' array, so that we needn't bother to check its size
5261 calculation for overflow.
5262 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5263 * eval.c (apply_lambda):
5264 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5265 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5266 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5267
a1759b76
PE
5268 * callint.c (Fcall_interactively): Don't use index var as event count.
5269
d96be9fc
PE
5270 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5271 * mem-limits.h (SIZE): Remove; no longer used.
5272
a690a978 5273 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 5274
578c21e6
PE
5275 Remove unnecessary casts.
5276 * xterm.c (x_term_init):
5277 * xfns.c (x_set_border_pixel):
5278 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5279 These aren't needed now that we assume ANSI C.
5280
96f53c6c
PE
5281 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5282 It's more likely to cause problems (due to unsigned overflow)
5283 than to cure them.
5284
83c77d31
PE
5285 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5286
ee2079f1
PE
5287 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5288
6da65536
PE
5289 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5290
7147c4a4
PE
5291 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5292
193e32d9
PE
5293 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5294
e5533da6
PE
5295 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5296
9910e595
PE
5297 GLYPH_CODE_FACE returns EMACS_INT, not int.
5298 * dispextern.h (merge_faces):
5299 * xfaces.c (merge_faces):
01103c44
PE
5300 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5301 Don't assume EMACS_INT fits in int.
9910e595 5302
2638320e
PE
5303 * character.h (CHAR_VALID_P): Remove unused parameter.
5304 * fontset.c, lisp.h, xdisp.c: All uses changed.
5305
045eb8d9
PE
5306 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5307
c1f134b5
PE
5308 * fns.c (concat): Minor tuning based on overflow analysis.
5309 This doesn't fix any bugs. Use int to hold character, instead
5310 of constantly refetching from Emacs object. Use XFASTINT, not
5311 XINT, for value known to be a character. Don't bother comparing
5312 a single byte to 0400, as it's always less.
5313
395fcb93 5314 * floatfns.c (Fexpt):
327eeec8
PE
5315 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5316
abbd3d23
PE
5317 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5318 for characters.
5319
684a03ef
PE
5320 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5321
0fed43f3
PE
5322 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5323 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5324 incorrectly succeed when S was a string, because 4294967386 was
5325 truncated before it was used.
5326
8fd02eb7
PE
5327 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5328 Otherwise, an out-of-range integer could cause undefined behavior
5329 on a 64-bit host.
5330
f8c86b69
PE
5331 * composite.c: Use int, not EMACS_INT, for characters.
5332 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5333 EMACS_INT, for values that are known to be in character range.
5334 This doesn't fix any bugs but is the usual style inside Emacs and
5335 may generate better code on 32-bit machines.
5336
34206dd2
PE
5337 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5338 This is for reasons similar to the recent CHAR_STRING fix.
5339 * charset.c (Fencode_char): Check that character arg is actually
5340 a character. Pass an int to ENCODE_CHAR.
5341 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5342 wider than 'int', as a compile-time check to prevent future regressions
5343 in this area.
5344
c5958d4c 5345 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
5346
5347 Make sure a 64-bit char is never passed to CHAR_STRING.
5348 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5349 by silently ignoring the top 32 bits, allowing some values
5350 that were far too large to be valid characters.
5351 * character.h: Include <verify.h>.
5352 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5353 arguments are no wider than unsigned, as a compile-time check
5354 to prevent future regressions in this area.
5355 * data.c (Faset):
01103c44 5356 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
5357 (Fsubst_char_in_region):
5358 * fns.c (concat):
5359 * xdisp.c (decode_mode_spec_coding):
5360 Adjust to CHAR_STRING's new requirement.
5361 * editfns.c (Finsert_char, Fsubst_char_in_region):
5362 * fns.c (concat): Check that character args are actually
5363 characters. Without this test, these functions did the wrong
5364 thing with wildly out-of-range values on 64-bit hosts.
5365
d37ca623
PE
5366 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5367 These casts should not be needed on 32-bit hosts, either.
5368 * keyboard.c (read_char):
5369 * lread.c (Fload): Remove casts to unsigned.
5370
ea204efb
PE
5371 * lisp.h (UNSIGNED_CMP): New macro.
5372 This fixes comparison bugs on 64-bit hosts.
5373 (ASCII_CHAR_P): Use it.
5374 * casefiddle.c (casify_object):
01103c44 5375 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
5376 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5377 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5378 * dispextern.h (FACE_FROM_ID):
5379 * keyboard.c (read_char): Use UNSIGNED_CMP.
5380
41cb286c
PE
5381 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5382 not to EMACS_INT, to avoid GCC warning.
5383
4a1b9832
PE
5384 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5385
55daad71
PE
5386 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5387 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5388 isn't needed on 32-bit machines.
8f95c75c 5389
01103c44
PE
5390 * buffer.c (Fgenerate_new_buffer_name):
5391 Use EMACS_INT for count, not int.
0ceccced 5392 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
5393
5394 * data.c (Qcompiled_function): Now static.
5395
c6f072e7
PE
5396 * window.c (window_body_lines): Now static.
5397
20ce5912
PE
5398 * image.c (gif_load): Rename local to avoid shadowing.
5399
9c4c5f81
PE
5400 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5401 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5402 * alloc.c (make_save_value): Integer argument is now of type
5403 ptrdiff_t, not int.
5404 (mark_object): Use ptrdiff_t, not int.
5405 * lisp.h (pD): New macro.
5406 * print.c (print_object): Use it.
5407
c0c5c8ae
PE
5408 * alloc.c: Use EMACS_INT, not int, to count objects.
5409 (total_conses, total_markers, total_symbols, total_vector_size)
5410 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
5411 (total_free_floats, total_floats, total_free_intervals)
5412 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
5413 Now EMACS_INT, not int. All uses changed.
5414 (Fgarbage_collect): Compute overall total using a double, so that
5415 integer overflow is less likely to be a problem. Check for overflow
5416 when converting back to an integer.
5a25e253
PE
5417 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5418 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5419 These were 'int' variables that could overflow on 64-bit hosts;
5420 they were never used, so remove them instead of repairing them.
211a0b2a 5421 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
5422 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5423 Previously, this ceilinged at INT_MAX, but that doesn't work on
5424 64-bit machines.
e46bb31a 5425 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 5426
c78baabf 5427 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 5428 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
5429 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5430 when a (possibly-narrower) signed value would do just as well.
5431 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 5432
c9d624c6
PE
5433 * alloc.c: Catch some string size overflows that we were missing.
5434 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5435 for convenience in STRING_BYTES_MAX.
5436 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5437 The definition here is exact; the one in lisp.h was approximate.
5438 (allocate_string_data): Check for string overflow. This catches
5439 some instances we weren't catching before. Also, it catches
5440 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5441 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5442 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 5443
c9d624c6
PE
5444 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5445 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 5446 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 5447
353032ce
PE
5448 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5449
2bccce07
PE
5450 * alloc.c (Fmake_string): Check for out-of-range init.
5451
0ac30604
SM
54522011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5453
5454 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5455
c195f2de
JD
54562011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5457
5458 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5459 xg_get_default_scrollbar_width.
5460
5461 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5462 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5463 (style_changed_cb): Call update_theme_scrollbar_width and call
5464 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5465 all frames (Bug#8505).
5466 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5467 Call gtk_window_set_resizable if HAVE_GTK3.
5468 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5469 and height if HAVE_GTK3 (Bug#8505).
5470 (scroll_bar_width_for_theme): New variable.
5471 (update_theme_scrollbar_width): New function.
5472 (xg_get_default_scrollbar_width): Move code to
5473 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5474 (xg_initialize): Call update_theme_scrollbar_width.
5475
5476 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5477
5478 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5479
e10ac9f1
MR
54802011-06-12 Martin Rudalics <rudalics@gmx.at>
5481
5482 * frame.c (make_frame): Call other_buffer_safely instead of
5483 other_buffer.
5484
5485 * window.c (temp_output_buffer_show): Call display_buffer with
5486 second argument Vtemp_buffer_show_specifiers and reset latter
5487 immediately after the call.
5488 (Vtemp_buffer_show_specifiers): New variable.
5489 (auto_window_vscroll_p, next_screen_context_lines)
5490 (Vscroll_preserve_screen_position): Remove leading asterisks from
5491 doc-strings.
5492
2d3c217e 54932011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 5494
7b7f97e8 5495 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
5496 * buffer.c (Qclone_number): Remove for now, as it's unused.
5497 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5498 (record_buffer): Remove unused local.
5499 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5500 (set_frame_buffer_list): Remove; unused.
5501 * frame.h (other_visible_frames): Remove decl.
5502 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5503 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5504 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5505 if HAVE_GPM.
5506 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5507 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5508 Define only if HAVE_GPM.
5509 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5510 (update_hints_inhibit): Remove; never set. All uses removed.
5511 * widgetprv.h (emacsFrameClassRec): Remove decl.
5512 * window.c (delete_deletable_window): Now returns void, since it
5513 wasn't returning anything.
5514 (compare_window_configurations): Remove unused locals.
5515 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5516 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
5517 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5518 the same widths as pointers. This follows up on the 2011-05-06 patch.
5519 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5520 * xterm.h: Likewise.
5521 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5522
1384b89e
JB
55232011-06-12 Juanma Barranquero <lekktu@gmail.com>
5524
5525 * makefile.w32-in: Update dependencies.
5526 (LISP_H): Add lib/intprops.h.
5527
1100a63c
CY
55282011-06-11 Chong Yidong <cyd@stupidchicken.com>
5529
5530 * image.c (gif_load): Add animation frame delay to the metadata.
5531 (syms_of_image): Use DEFSYM. New symbol `delay'.
5532
6198ccd0
MR
55332011-06-11 Martin Rudalics <rudalics@gmx.at>
5534
5535 * window.c (delete_deletable_window): Re-add.
5536 (Fset_window_configuration): Rewrite to handle dead buffers and
5537 consequently deletable windows.
5538 (window_tree, Fwindow_tree): Remove. Supply functionality in
5539 window.el.
5540 (compare_window_configurations): Simplify code.
5541
b6e3633c
AS
55422011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5543
1ab0dee5
AS
5544 * image.c (imagemagick_load_image): Fix type mismatch.
5545 (Fimagemagick_types): Likewise.
5546
b6e3633c
AS
5547 * window.h (replace_buffer_in_windows): Declare.
5548
9397e56f
MR
55492011-06-11 Martin Rudalics <rudalics@gmx.at>
5550
5551 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5552 Qclone_number. Remove external declaration of Qdelete_window.
5553 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5554 code.
640c8776
SM
5555 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5556 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
5557 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5558 buffer list implementation.
5559 (other_buffer_safely): New function.
5560 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5561 calls to replace_buffer_in_windows and
5562 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5563 if allowed.
5564 (record_buffer): Inhibit quitting and rewrite using quittable
5565 functions. Run Qbuffer_list_update_hook if allowed.
5566 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
5567 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5568 Move switch-to-buffer to window.el.
9397e56f
MR
5569 (bury-buffer): Move to window.el.
5570 (Vbuffer_list_update_hook): New variable.
5571
5572 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5573 section.
5574
5575 * window.h (resize_frame_windows): Move up in code.
5576 (Fwindow_frame): Remove EXFUN.
5577 (replace_buffer_in_all_windows): Remove prototype.
5578 (replace_buffer_in_windows_safely): Add prototype.
5579
5580 * window.c: Declare Qdelete_window static again. Move down
5581 declaration of select_count.
5582 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5583 (Fother_window): Move to window.el.
5584 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5585 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5586 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5587 window.el.
5588 (replace_buffer_in_windows): Implement by calling
5589 Qreplace_buffer_in_windows.
5590 (replace_buffer_in_all_windows): Remove with some functionality
5591 moved into replace_buffer_in_windows_safely.
5592 (replace_buffer_in_windows_safely): New function.
5593 (select_window_norecord, select_frame_norecord): Move in front
5594 of run_window_configuration_change_hook. Remove now obsolete
5595 declarations.
640c8776
SM
5596 (Fset_window_buffer): Rewrite doc-string.
5597 Call Qrecord_window_buffer.
9397e56f
MR
5598 (keys_of_window): Move binding for other-window to window.el.
5599
b50691aa
CY
56002011-06-11 Chong Yidong <cyd@stupidchicken.com>
5601
5602 * dispextern.h (struct image): Replace data member, whose int_val
5603 and ptr_val fields were not used by anything, with a single
5604 lisp_val object.
5605
5606 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5607 (gif_clear_image, gif_load, imagemagick_load_image)
5608 (gs_clear_image, gs_load): Callers changed.
5609
3f754b86
PE
56102011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5611
cca69397
PE
5612 * buffer.h: Include <time.h>, for time_t.
5613 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5614
109e28d0
PE
5615 Fix minor problems found by static checking.
5616
60737f02
PE
5617 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5618
4b66faf3
PE
5619 Make identifiers static if they are not used in other modules.
5620 * data.c (Qcompiled_function, Qframe, Qvector):
5621 * image.c (QimageMagick, Qsvg):
5622 * minibuf.c (Qmetadata):
5623 * window.c (resize_window_check, resize_root_window): Now static.
5624 * window.h (resize_window_check, resize_root_window): Remove decls.
5625
109e28d0
PE
5626 * window.c (window_deletion_count, delete_deletable_window):
5627 Remove; unused.
46a4ce9e
PE
5628 (window_body_lines): Now static.
5629 (Fdelete_other_windows_internal): Mark vars as initialized.
5630 Make sure 'resize_failed' is initialized.
5631 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5632 (resize_window_apply): Remove unused local.
5633 * window.h (delete_deletable_window): Remove decl.
5634
109e28d0 5635 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
5636 (imagemagick_load_image): Fix pointer signedness problem by changing
5637 last arg from unsigned char * to char *. All uses changed.
5638 Also, fix a local for similar reasons.
5639 Remove unused locals. Remove locals to avoid shadowing.
5640 (fn_rsvg_handle_free): Remove; unused.
5641 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 5642 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 5643
3f754b86
PE
5644 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5645
2547adb1
CY
56462011-06-10 Chong Yidong <cyd@stupidchicken.com>
5647
5648 * image.c (gif_load): Fix omitted cast error introduced by
5649 2011-06-06 change.
5650
2c8e37d4
MR
56512011-06-10 Martin Rudalics <rudalics@gmx.at>
5652
5653 * window.h (resize_proportionally, orig_total_lines)
5654 (orig_top_line): Remove from window structure.
5655 (set_window_height, set_window_width, change_window_heights)
5656 (Fdelete_window): Remove prototypes.
5657 (resize_frame_windows): Remove duplicate declaration.
5658
440a42e3
EZ
56592011-06-10 Eli Zaretskii <eliz@gnu.org>
5660
5661 * window.h (resize_frame_windows, resize_window_check)
5662 (delete_deletable_window, resize_root_window)
5663 (resize_frame_windows): Declare prototypes.
5664
5665 * window.c (resize_window_apply): Make definition be "static" to
5666 match the prototype.
5667
562dd5e9
MR
56682011-06-10 Martin Rudalics <rudalics@gmx.at>
5669
5670 * window.c: Remove declarations of Qwindow_size_fixed,
5671 window_min_size_1, window_min_size_2, window_min_size,
5672 size_window, window_fixed_size_p, enlarge_window, delete_window.
5673 Remove static from declaration of Qdelete_window, it's
5674 temporarily needed by Fbury_buffer.
5675 (replace_window): Don't assign orig_top_line and
5676 orig_total_lines.
5677 (Fdelete_window, delete_window): Remove. Window deletion is
5678 handled by window.el.
640c8776
SM
5679 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5680 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
5681 (Fdelete_other_windows): Remove. Deleting other windows is
5682 handled by window.el.
5683 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5684 handled in window.el.
5685 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5686 Window minimum sizes are handled in window.el.
5687 (shrink_windows, size_window, set_window_height)
5688 (set_window_width, change_window_heights, window_height)
5689 (window_width, CURBEG, CURSIZE, enlarge_window)
5690 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5691 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5692 handled in window.el.
5693 (make_dummy_parent): Rename to make_parent_window and give it a
5694 second argument horflag.
5695 (make_window): Don't set resize_proportionally any more.
5696 (Fsplit_window): Remove. Windows are split in window.el.
5697 (save_restore_action, save_restore_orig_size)
5698 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5699 Resize mini windows in window.el.
5700 (grow_mini_window, shrink_mini_window): Implement by calling
5701 Qresize_root_window_vertically, resize_window_check and
5702 resize_window_apply.
640c8776
SM
5703 (saved_window, Fset_window_configuration, save_window_save):
5704 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
5705 resize_proportionally.
5706 (window_min_height, window_min_width): Move to window.el.
5707 (keys_of_window): Move bindings for delete-other-windows,
5708 split-window, delete-window and enlarge-window to window.el.
5709
5710 * buffer.c: Temporarily extern Qdelete_window.
5711 (Fbury_buffer): Temporarily call Qdelete_window instead of
5712 Fdelete_window (Fbury_buffer will move to window.el soon).
5713
5714 * frame.c (set_menu_bar_lines_1): Remove code handling
5715 orig_top_line and orig_total_lines.
5716
5717 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5718 set_window_height but set heights directly.
5719 (change_frame_size_1): Use resize_frame_windows.
5720
5721 * xdisp.c (init_xdisp): Don't use set_window_height but set
5722 heights directly.
5723
640c8776
SM
5724 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5725 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
5726 run_window_configuration_change_hook.
5727
5728 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5729 instead of change_window_heights and run
5730 run_window_configuration_change_hook.
5731
1a13852e
MR
57322011-06-09 Martin Rudalics <rudalics@gmx.at>
5733
5734 * window.c (replace_window): Rename second argument REPLACEMENT to
5735 NEW. New third argument SETFLAG. Rewrite.
5736 (delete_window, make_dummy_parent): Call replace_window with
5737 third argument 1.
5738 (window_list_1): Move down in code.
5739 (run_window_configuration_change_hook): Move set_buffer part
5740 before select_frame_norecord part in order to unwind correctly.
5741 Rename count1 to count.
5742 (recombine_windows, delete_deletable_window, resize_root_window)
5743 (Fdelete_other_windows_internal)
5744 (Frun_window_configuration_change_hook, make_parent_window)
5745 (resize_window_check, resize_window_apply, Fresize_window_apply)
5746 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
5747 (Fdelete_window_internal, Fresize_mini_window_internal):
5748 New functions.
1a13852e
MR
5749 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5750
f3d1777e
MR
57512011-06-08 Martin Rudalics <rudalics@gmx.at>
5752
496e208e
MR
5753 * window.h (window): Add some new members to window structure -
5754 normal_lines, normal_cols, new_total, new_normal, clone_number,
5755 splits, nest, prev_buffers, next_buffers.
5756 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 5757 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 5758
f3d1777e
MR
5759 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5760 Remove.
496e208e
MR
5761 (make_dummy_parent): Set new members of windows structure.
5762 (make_window): Move down in code. Handle new members of window
5763 structure.
5764 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5765 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5766 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5767 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
5768 (Fset_window_next_buffers, Fset_window_clone_number):
5769 New functions.
496e208e
MR
5770 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5771 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5772 Doc-string fixes.
5773 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5774 Argument WINDOW can be now internal window too.
5775 (Fwindow_use_time): Move up in code.
5776 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5777 Rewrite doc-string.
5778 (Fset_window_configuration, saved_window)
5779 (Fcurrent_window_configuration, save_window_save): Handle new
5780 members of window structure.
b9e809c2
MR
5781 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5782 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5783 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5784 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5785 Qget_mru_window, Qresize_root_window,
5786 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5787 Qauto_buffer_name; staticpro them.
f3d1777e 5788
abde8f8c
MR
57892011-06-07 Martin Rudalics <rudalics@gmx.at>
5790
5791 * window.c (Fwindow_total_size, Fwindow_left_column)
5792 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5793 (Fwindow_list_1): New functions.
5794 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
5795 (Fwindow_width, Fscroll_left, Fscroll_right):
5796 Use window_body_cols instead of window_box_text_cols.
5797 (delete_window, Fset_window_configuration):
5798 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
5799 (delete_all_subwindows): Take a window as argument and not a
5800 structure. Rewrite.
190b47e6
MR
5801 (window_loop): Remove handling of GET_LRU_WINDOW and
5802 GET_LARGEST_WINDOW.
5803 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
5804
5805 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
5806 window_box_text_cols. delete_all_subwindows now takes a
5807 Lisp_Object as argument.
abde8f8c 5808
640c8776
SM
5809 * indent.c (compute_motion, Fcompute_motion):
5810 Use window_body_cols instead of window_box_text_cols.
abde8f8c 5811
fa8a67e6
MR
5812 * frame.c (delete_frame): Call delete_all_subwindows with root
5813 window as argument.
5814
a54e3482
DC
58152011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5816
5817 * fns.c (Fputhash): Document return value.
5818
60002bf5
CY
58192011-06-06 Chong Yidong <cyd@stupidchicken.com>
5820
5821 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5822
0c671da6 58232011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 5824
b862a52a 5825 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 5826
be44ca6c
PE
5827 Check for overflow when converting integer to cons and back.
5828 * charset.c (Fdefine_charset_internal, Fdecode_char):
5829 Use cons_to_unsigned to catch overflow.
5830 (Fencode_char): Use INTEGER_TO_CONS.
5831 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5832 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5833 * data.c (long_to_cons, cons_to_long): Remove.
5834 (cons_to_unsigned, cons_to_signed): New functions.
5835 These signal an error for invalid or out-of-range values.
5836 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5837 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5838 * font.c (Ffont_variation_glyphs):
5839 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5840 * lisp.h: Include <intprops.h>.
5841 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5842 (cons_to_signed, cons_to_unsigned): New decls.
5843 (long_to_cons, cons_to_long): Remove decls.
5844 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5845 (Fprimitive_undo): Use CONS_TO_INTEGER.
5846 * xfns.c (Fx_window_property): Likewise.
5847 * xselect.c: Include <limits.h>.
5848 (x_own_selection, selection_data_to_lisp_data):
5849 Use INTEGER_TO_CONS.
5850 (x_handle_selection_request, x_handle_selection_clear)
5851 (x_get_foreign_selection, Fx_disown_selection_internal)
5852 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5853 (lisp_data_to_selection_data): Use cons_to_unsigned.
5854 (x_fill_property_data): Use cons_to_signed.
5855 Report values out of range.
5856
d1f3d2af
PE
5857 Check for buffer and string overflow more precisely.
5858 * buffer.h (BUF_BYTES_MAX): New macro.
5859 * lisp.h (STRING_BYTES_MAX): New macro.
5860 * alloc.c (Fmake_string):
5861 * character.c (string_escape_byte8):
5862 * coding.c (coding_alloc_by_realloc):
5863 * doprnt.c (doprnt):
5864 * editfns.c (Fformat):
5865 * eval.c (verror):
5866 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5867 since they may not be the same number.
5868 * editfns.c (Finsert_char):
5869 * fileio.c (Finsert_file_contents):
5870 Likewise for BUF_BYTES_MAX.
5871
dd52fcea
PE
5872 * image.c: Use ptrdiff_t, not int, for sizes.
5873 (slurp_file): Switch from int to ptrdiff_t.
5874 All uses changed.
5875 (slurp_file): Check that file size fits in both size_t (for
5876 malloc) and ptrdiff_t (for sanity and safety).
5877
7f9bbdbb
PE
5878 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5879 if b->modtime has its maximal value.
5880
dfe18f82
PE
5881 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5882
84acfcf0
PE
5883 Don't assume time_t can fit into int.
5884 * buffer.h (struct buffer.modtime): Now time_t, not int.
5885 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5886 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5887
ccd9a01a
PE
5888 Minor fixes for signed vs unsigned integers.
5889 * character.h (MAYBE_UNIFY_CHAR):
5890 * charset.c (maybe_unify_char):
5891 * keyboard.c (read_char, reorder_modifiers):
5892 XINT -> XFASTINT, since the integer must be nonnegative.
5893 * ftfont.c (ftfont_spec_pattern):
5894 * keymap.c (access_keymap, silly_event_symbol_error):
5895 XUINT -> XFASTINT, since the integer must be nonnegative.
5896 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5897 since it makes no difference and we prefer signed.
5898 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5899 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5900 nonnegative.
5901
d6d100dd
SM
59022011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5903
5904 * window.h (Fwindow_frame): Declare.
5905
2b6148e4
PE
59062011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5907
5908 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5909 (SPARE_MEMORY): Always define.
5910 (LARGE_REQUEST): Remove.
5911 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5912
f230ecc9
MR
59132011-06-06 Martin Rudalics <rudalics@gmx.at>
5914
727e958e
MR
5915 * lisp.h: Move EXFUNS for Fframe_root_window,
5916 Fframe_first_window and Fset_frame_selected_window to window.h.
5917
5918 * window.h: Move EXFUNS for Fframe_root_window,
5919 Fframe_first_window and Fset_frame_selected_window here from
5920 lisp.h.
5921
5922 * frame.c (Fwindow_frame, Fframe_first_window)
5923 (Fframe_root_window, Fframe_selected_window)
5924 (Fset_frame_selected_window): Move to window.c.
5925 (Factive_minibuffer_window): Move to minibuf.c.
5926 (Fother_visible_frames_p): New function.
5927
5928 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5929
f230ecc9
MR
5930 * window.c (decode_window, decode_any_window): Move up in code.
5931 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5932 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
5933 (Fwindow_buffer): Move up and rewrite doc-string.
5934 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5935 (Fwindow_prev): New functions.
727e958e
MR
5936 (Fwindow_frame): Move here from frame.c. Accept any window as
5937 argument.
5938 (Fframe_root_window, Fframe_first_window)
5939 (Fframe_selected_window): Move here from frame.c. Accept frame
5940 or arbitrary window as argument. Update doc-strings.
5941 (Fminibuffer_window): Move up in code.
5942 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
5943 (Fset_frame_selected_window): Move here from frame.c.
5944 Marginal rewrite.
727e958e
MR
5945 (Fselected_window, select_window, Fselect_window): Move up in
5946 code. Minor doc-string fixes.
f230ecc9 5947
4d09bcf6
PE
59482011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5949
5950 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5951 Do not assume that spare memory exists; that assumption is valid
5952 only if SYSTEM_MALLOC.
5953 (LARGE_REQUEST): New macro, so that the issue of large requests
5954 is separated from the issue of spare memory.
5955
810928a2
AS
59562011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5957
172418ad
AS
5958 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5959 format. (Bug#8806)
5960
43f862f7
AS
5961 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5962
810928a2
AS
5963 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5964 before statements.
5965
a059fe24
JD
59662011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5967
5968 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5969
5970 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5971
5972 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5973 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5974
989bf368
JB
59752011-06-05 Juanma Barranquero <lekktu@gmail.com>
5976
5977 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5978
4b80f674
CY
59792011-06-04 Chong Yidong <cyd@stupidchicken.com>
5980
5981 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5982 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
5983 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5984 New error handlers.
4b80f674
CY
5985 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5986 Obey Vx_select_enable_clipboard_manager. Catch errors in
5987 x_clipboard_manager_save (Bug#8779).
5988 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 5989 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 5990
99a33b77 59912011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
5992
5993 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5994
99a33b77 59952011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
5996
5997 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5998 in the current matrix if keep_current_p is non-zero.
5999
8264569d
EZ
60002011-06-04 Eli Zaretskii <eliz@gnu.org>
6001
6002 * bidi.c (bidi_level_of_next_char): Fix last change.
6003
57f97249
EZ
60042011-06-03 Eli Zaretskii <eliz@gnu.org>
6005
fec2107c 6006 Support bidi reordering of text covered by display properties.
57f97249 6007
fec2107c
EZ
6008 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
6009 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
6010 (bidi_cache_search, bidi_cache_iterator_state)
6011 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
6012 (bidi_level_of_next_char, bidi_move_to_visually_next):
6013 Support character positions inside a run of characters covered by a
fec2107c
EZ
6014 display string.
6015 (bidi_paragraph_init, bidi_resolve_explicit_1)
6016 (bidi_level_of_next_char): Call bidi_fetch_char and
6017 bidi_fetch_char_advance instead of FETCH_CHAR and
6018 FETCH_CHAR_ADVANCE.
6019 (bidi_init_it): Initialize new members.
6020 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
6021 definitions.
6022 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
6023 instead of using explicit *_CHAR codes.
d6d100dd
SM
6024 (bidi_resolve_explicit, bidi_resolve_weak):
6025 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
6026 bidirectional text is supported only in multibyte buffers.
6027 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
6028 it to initialize the frame_window_p member of struct bidi_it.
6029 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
6030 (bidi_resolve_explicit, bidi_resolve_weak)
6031 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
6032 bidi_it->nchars is non-positive.
6033 (bidi_level_of_next_char): Don't try to lookup the cache for the
6034 next/previous character if nothing is cached there yet, or if we
6035 were just reseat()'ed to a new position.
c40e2fb2 6036
0e14fe90
EZ
6037 * xdisp.c (set_cursor_from_row): Set start and stop points
6038 according to the row's direction when priming the loop that looks
6039 for the glyph on which to display cursor.
6040 (single_display_spec_intangible_p): Function deleted.
6041 (display_prop_intangible_p): Reimplement to call
6042 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
6043 Accept 3 additional arguments needed by handle_display_spec.
6044 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
6045 values: lists, `(when COND...)' forms, etc.
6046 (single_display_spec_string_p): Support property values that are
6047 lists with the argument STRING its top-level element.
6048 (display_prop_string_p): Fix the condition for processing a
6049 property that is a list to be consistent with handle_display_spec.
fec2107c 6050 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
6051 last portion of handle_display_prop.
6052 (compute_display_string_pos): Accept additional argument
6053 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6054 value of a `display' property is a "replacing spec".
6055 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6056 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6057 the display property, but just return a value indicating whether
6058 the display property will replace the characters it covers.
6059 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6060 frame_window_p members of struct bidi_it.
d6d100dd
SM
6061 (compute_display_string_pos, compute_display_string_end):
6062 New functions.
fec2107c
EZ
6063 (push_it): Accept second argument POSITION, where pop_it should
6064 jump to continue iteration.
6065 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 6066
fec2107c
EZ
6067 * keyboard.c (adjust_point_for_property): Adjust the call to
6068 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
6069
6070 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
6071 (bidi_init_it): Update prototypes.
6072 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
6073 (compute_display_string_pos, compute_display_string_end):
6074 Declare prototypes.
fec2107c
EZ
6075 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6076 EMACS_INT.
fc6f18ce 6077
40087514 60782011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 6079
57f53182
PE
6080 Malloc failure behavior now depends on size of allocation.
6081 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6082 * lisp.h: Change signatures accordingly.
6083 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6084 All callers changed. (Bug#8762)
6085
6086 * gnutls.c: Use Emacs's memory allocators.
6087 Without this change, the gnutls library would invoke malloc etc.
6088 directly, which causes problems on non-SYNC_INPUT hosts, and which
6089 runs afoul of improving memory_full behavior. (Bug#8761)
6090 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6091 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6092 xfree instead of the default malloc, realloc, free.
6093 (Fgnutls_boot): No need to check for memory allocation failure,
6094 since xmalloc does that for us.
6095
ac32cd99 6096 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
6097 * category.c (hash_get_category_set):
6098 * ccl.c (ccl_driver):
6099 * charset.c (Fdefine_charset_internal):
6100 * charset.h (struct charset.hash_index):
6101 * composite.c (get_composition_id, gstring_lookup_cache)
6102 (composition_gstring_put_cache):
6103 * composite.h (struct composition.hash_index):
6104 * dispextern.h (struct image.hash):
6105 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6106 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6107 (hashfn_equal, hashfn_user_defined, make_hash_table)
6108 (maybe_resize_hash_table, hash_lookup, hash_put)
6109 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6110 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6111 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6112 * image.c (make_image, search_image_cache, lookup_image)
6113 (xpm_put_color_table_h):
6114 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 6115 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 6116 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 6117 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
6118 * alloc.c (allocate_vectorlike):
6119 Check for overflow in vector size calculations.
6120 * ccl.c (ccl_driver):
6121 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
6122 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6123 need to be updated by these changes.
40087514
PE
6124 * fns.c (make_hash_table, maybe_resize_hash_table):
6125 Check for integer overflow with large hash tables.
0de4bb68
PE
6126 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6127 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6128 (SXHASH_REDUCE): New macro.
6129 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6130 Use it instead of discarding useful hash info with large hash values.
6131 (sxhash_float): New function.
6132 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6133 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
6134 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6135 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
6136 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6137 Adjust signatures to match updated version of code.
6138 (consing_since_gc): Now EMACS_INT, since a single hash table can
6139 use more than INT_MAX bytes.
6140
698d32e2
DN
61412011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6142
6143 Make it possible to build with GCC-4.6+ -O2 -flto.
6144
6145 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6146
fd6fa53f
SM
61472011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6148
6149 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6150 Call minibuffer-inactive-mode.
6151
864db017
JB
61522011-05-31 Juanma Barranquero <lekktu@gmail.com>
6153
6154 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6155 Update dependencies.
6156
2ad0baf4
DN
61572011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6158
6159 * data.c (init_data): Remove code for UTS, this system is not
6160 supported anymore.
6161
4fcc2638
DN
61622011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6163
6164 Don't force ./temacs to start in terminal mode.
6165
6166 * frame.c (make_initial_frame): Initialize faces in all cases, not
6167 only when CANNOT_DUMP is defined.
6168 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6169
c56e0fd5
DN
61702011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6171
6172 * dispnew.c (add_window_display_history): Use const for the string
6173 pointer. Remove declaration, not needed.
6174
333d54da 61752011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 6176
55d4c1b2 6177 Use 'inline', not 'INLINE'.
333d54da 6178 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
6179 * alloc.c, fontset.c (INLINE): Remove.
6180 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6181 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6182 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6183 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6184 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6185
738db178
DN
61862011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6187
6188 Make it possible to run ./temacs.
6189
6190 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6191 syms_of_callproc does the same thing. Remove test for
6192 "initialized", do it in the caller.
6193 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6194
620c53a6
SM
61952011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6196
6197 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6198 (read_minibuf): Use get_minibuffer.
6199 (syms_of_minibuf): Use DEFSYM.
6200 (Qmetadata): New var.
6201 * data.c (Qbuffer): Don't make it static.
6202 (syms_of_data): Use DEFSYM.
6203
e003a292
PE
62042011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6205
6206 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6207 (CCL_CODE_MIN): New macro.
6208
ed008a6d
PE
62092011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6210
3687c2ef
PE
6211 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6212
ed008a6d
PE
6213 * eval.c (Qdebug): Now static.
6214 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6215 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6216 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6217
d66c4c7c
CY
62182011-05-29 Chong Yidong <cyd@stupidchicken.com>
6219
6220 * image.c: Various fixes to ImageMagick code comments.
6221 (Fimagemagick_types): Doc fix.
6222
5fbc2025
PE
62232011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6224
0196f88a
PE
6225 Minor fixes prompted by GCC 4.6.0 warnings.
6226
6227 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6228
5fbc2025
PE
6229 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6230 (x_clipboard_manager_save_all): Move extern decl to ...
6231 * xterm.h: ... here, so that it can be checked for consistency.
6232
1dd3c2d9
CY
62332011-05-29 Chong Yidong <cyd@stupidchicken.com>
6234
6235 * xselect.c (x_clipboard_manager_save_frame)
6236 (x_clipboard_manager_save_all): New functions.
6237 (Fx_clipboard_manager_save): Lisp function deleted.
6238
6239 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6240 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6241
6242 * xterm.h: Update prototype.
6243
5ba6571d
WX
62442011-05-28 William Xu <william.xwl@gmail.com>
6245
6246 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6247 exiting (Bug#8239).
6248
3eaff834
JM
62492011-05-28 Jim Meyering <meyering@redhat.com>
6250
e1900994 6251 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
6252 * fns.c (to_uchar): Define.
6253 (crypto_hash_function): Use it to convert some newly-signed
6254 variables to unsigned, to avoid sign-extension bugs. For example,
6255 without this change, (md5 "truc") would evaluate to
6256 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6257 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 6258 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 6259
0f6990a7
PE
62602011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6261
6262 Integer overflow fixes.
c8a9ca5a 6263
08686060
PE
6264 * dbusbind.c: Serial number integer overflow fixes.
6265 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
6266 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6267 to hold a serial number that is too large for a fixnum.
6268 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6269 Check for serial numbers out of range. Decode any serial number
59568bf0 6270 that was so large that it became a float. (Bug#8722)
08686060 6271
2d1fc3c7
PE
6272 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6273 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6274 Use XFASTINT rather than XUINT when numbers are nonnegative.
6275 (xd_append_arg, Fdbus_method_return_internal):
6276 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6277 arguments, check that Lisp number is nonnegative, rather than
59568bf0 6278 silently wrapping negative numbers around. (Bug#8722)
30217ff0 6279 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 6280 (Bug#8722)
2d1fc3c7 6281
c8a9ca5a
PE
6282 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6283
519e1d69
PE
6284 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6285
6df6ae42 6286 ccl: Add integer overflow checks.
30569699
PE
6287 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6288 (IN_INT_RANGE): New macros.
6289 (ccl_driver): Use them to check for integer overflow when
6290 decoding a CCL program. Many of the new checks are whether XINT (x)
6291 fits in int; it doesn't always, on 64-bit hosts. The new version
6292 doesn't catch all possible integer overflows, but it's an
847044ea 6293 improvement. (Bug#8719)
30569699 6294
c11285dc
PE
6295 * alloc.c (make_event_array): Use XINT, not XUINT.
6296 There's no need for unsigned here.
6297
fdccd48e
PE
6298 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6299 This follows up to the 2011-05-06 change that substituted uintptr_t
6300 for EMACS_INT. This case wasn't caught back then.
6301
37910ab2
PE
6302 Rework Fformat to avoid integer overflow issues.
6303 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6304 now (part of C89). Include <verify.h>.
6305 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6306 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6307 (Fformat): Avoid the prepass trying to compute sizes; it was only
6308 approximate and thus did not catch overflow reliably. Instead, walk
6309 through the format just once, formatting and computing sizes as we go,
6310 checking for integer overflow at every step, and allocating a larger
6311 buffer as needed. Keep track separately whether the format is
6312 multibyte. Keep only the most-recently calculated precision, rather
6313 than them all. Record whether each argument has been converted to
6314 string. Use EMACS_INT, not int, for byte and char and arg counts.
6315 Support field widths and precisions larger than INT_MAX. Avoid
6316 sprintf's undefined behavior with conversion specifications such as %#d
6317 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6318 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6319 formatting out-of-range floating point numbers with int
9173deec 6320 formats. (Bug#8668)
37910ab2 6321
2e6578fb
PE
6322 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6323
0ae6bdee
PE
6324 * data.c: Avoid integer truncation in expressions involving floats.
6325 * data.c: Include <intprops.h>.
6326 (arith_driver): When there's an integer overflow in an expression
6327 involving floating point, convert the integers to floating point
6328 so that the resulting value does not suffer from catastrophic
6329 integer truncation. For example, on a 64-bit host (* 4
6330 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6331 Do not rely on undefined behavior after integer overflow.
6332
de883a70
PE
6333 merge count_size_as_multibyte, parse_str_to_multibyte
6334 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 6335 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
6336 Check for integer overflow.
6337 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6338 since it's now a duplicate of the other. This is more of
6339 a character than a buffer op, so better that it's in character.c.
6340 * fns.c, print.c: Adjust to above changes.
6341
2ff916cb
PE
63422011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6343
6344 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6345
f1b54466
PE
63462011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6347
fb1ac845
PE
6348 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6349 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6350 (x_clipboard_manager_save): Now static.
6351 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6352
f1b54466
PE
6353 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6354 (crypto_hash_function): Now static.
6355 Fix pointer signedness problems. Avoid unnecessary initializations.
6356
a9f737ee
CY
63572011-05-27 Chong Yidong <cyd@stupidchicken.com>
6358
6359 * termhooks.h (Vselection_alist): Make it terminal-local.
6360
6361 * terminal.c (create_terminal): Initialize it.
6362
6363 * xselect.c: Support for clipboard managers.
6364 (Vselection_alist): Move to termhooks.h as terminal-local var.
6365 (LOCAL_SELECTION): New macro.
6366 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6367 (symbol_to_x_atom): Remove gratuitous arg.
6368 (x_handle_selection_request, lisp_data_to_selection_data)
6369 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
6370 (x_own_selection, x_get_local_selection, x_convert_selection):
6371 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
6372 (some_frame_on_display): Delete unused function.
6373 (Fx_own_selection_internal, Fx_get_selection_internal)
6374 (Fx_disown_selection_internal, Fx_selection_owner_p)
6375 (Fx_selection_exists_p): New optional frame arg.
6376 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6377 (x_handle_selection_clear): Don't treat other terminals with the
6378 same keyboard specially. Use the terminal-local Vselection_alist.
6379 (x_clear_frame_selections): Use Frun_hook_with_args.
6380
6381 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6382
6383 * xterm.h: Add support for those atoms.
6384
e067f0c1
CY
63852011-05-26 Chong Yidong <cyd@stupidchicken.com>
6386
6387 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6388 (converted_selections, conversion_fail_tag): New global variables.
6389 (x_selection_request_lisp_error): Free the above.
6390 (x_get_local_selection): Remove unnecessary code.
6391 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
6392 of converted selections stored in converted_selections.
6393 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
6394 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6395 (x_convert_selection): New function.
6396 (x_handle_selection_event): Simplify.
6397 (x_get_foreign_selection): Don't ignore incoming requests while
6398 waiting for an answer; this will fail when we implement
6399 SAVE_TARGETS, and seems unnecessary anyway.
6400 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6401 (Vx_sent_selection_functions): Doc fix.
6402
0f4aebc0
LL
64032011-05-26 Leo Liu <sdl.web@gmail.com>
6404
6405 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6406
e61124cd
YM
64072011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6408
6409 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6410
6411 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6412 for fringe update if it has periodic bitmap.
ac389d0c 6413 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
6414 and fringe_bitmap_periodic_p.
6415
6416 * fringe.c (get_fringe_bitmap_data): New function.
6417 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6418 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6419 row. Mark glyph row for fringe update if periodicity changed.
6420
6421 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6422 for fringe update unless it has periodic bitmap.
6423
f16d9837
KH
64242011-05-25 Kenichi Handa <handa@m17n.org>
6425
6426 * xdisp.c (get_next_display_element): Set correct it->face_id for
6427 a static composition.
6428
e1b90ef6
LL
64292011-05-24 Leo Liu <sdl.web@gmail.com>
6430
6431 * deps.mk (fns.o):
6432 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6433
6434 * fns.c (crypto_hash_function, Fsha1): New function.
6435 (Fmd5): Use crypto_hash_function.
6436 (syms_of_fns): Add Ssha1.
6437
7400048f
PE
64382011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6439
6440 * gnutls.c: Remove unused macros.
6441 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6442 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6443 Remove macros that are defined and never used.
6444 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6445
abb71cf4
CY
64462011-05-22 Chong Yidong <cyd@stupidchicken.com>
6447
6448 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6449 (Fx_get_selection_internal): Minor cleanup.
6450 (Fx_own_selection_internal): Rename arguments for consistency with
6451 select.el.
6452
6307db39
PE
64532011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6454
6455 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6456
f3d4e0a4
CY
64572011-05-22 Chong Yidong <cyd@stupidchicken.com>
6458
6459 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6460
4d8ade89
YM
64612011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6462
6463 * dispnew.c (scrolling_window): Don't exclude the case that the
6464 last enabled row in the desired matrix touches the bottom boundary.
6465
32078c8d
GM
64662011-05-21 Glenn Morris <rgm@gnu.org>
6467
6468 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
6469 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6470 and add some more files.
32078c8d 6471
7285dc67
EZ
64722011-05-20 Eli Zaretskii <eliz@gnu.org>
6473
6474 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6475 report_file_error introduced by the change from 2011-05-07.
6476
89d1bd22
PE
64772011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6478
6479 * systime.h (Time): Define only if emacs is defined.
6480 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6481 where the include path doesn't have X11/X.h by default. See
6482 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6483
cd394be1 64842011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
6485
6486 * composite.c (find_automatic_composition): Fix previous change.
6487
b9704ad9
GM
64882011-05-20 Glenn Morris <rgm@gnu.org>
6489
6490 * lisp.mk: New file, split from Makefile.in.
6491 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6492 (shortlisp): Remove.
6493 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6494
4a720484
GM
64952011-05-19 Glenn Morris <rgm@gnu.org>
6496
6497 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6498 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6499 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6500 (lisp): Set the order to that of loadup.el.
6501 (shortlisp): Make it a copy of $lisp.
6502 (SOME_MACHINE_LISP): Remove.
6503 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6504 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6505
a28d4396
KH
65062011-05-18 Kenichi Handa <handa@m17n.org>
6507
6508 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6509 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6510 (find_automatic_composition): Mostly rewrite for efficiency.
6511
a2b1fa8e
JB
65122011-05-18 Juanma Barranquero <lekktu@gmail.com>
6513
6514 * makefile.w32-in: Update dependencies.
6515
8e1f5610
CS
65162011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6517
6518 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 6519 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 6520
7025ee00 65212011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 6522
cdfa6eab
PE
6523 Fix some integer overflow issues, such as string length overflow.
6524
06d6db33
PE
6525 * insdel.c (count_size_as_multibyte): Check for string overflow.
6526
2b4560a8
PE
6527 * character.c (lisp_string_width): Check for string overflow.
6528 Use EMACS_INT, not int, for string indexes and lengths; in
6529 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6530 the resulting string length overflows an EMACS_INT; instead,
6531 report a string overflow if no precision given. When checking for
6532 precision exhaustion, use a check that cannot possibly have
6533 integer overflow. (Bug#8675)
6534 * character.h (lisp_string_width): Adjust to new signature.
6535
cb93f9be
PE
6536 * alloc.c (string_overflow): New function.
6537 (Fmake_string): Use it. This doesn't change behavior, but saves
6538 a few bytes and will simplify future changes.
6539 * character.c (string_escape_byte8): Likewise.
6540 * lisp.h (string_overflow): New decl.
6541
1a1f3366
PE
6542 Fixups, following up to the user-interface timestamp change.
6543 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6544 for UI timestamps, instead of unsigned long.
9fbd6841
PE
6545 * msdos.c (mouse_get_pos): Likewise.
6546 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
6547 * w32gui.h (Time): Define by including "systime.h" rather than by
6548 declaring it ourselves. (Bug#8664)
6549
d4e3e4d3
PE
6550 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6551 * image.c (clear_image_cache): Likewise.
6552
f6a24d19
PE
6553 * term.c (term_mouse_position): Don't assume time_t wraparound.
6554
08dc5ae6
PE
6555 Be more systematic about user-interface timestamps.
6556 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
6557 and sometimes 'EMACS_UINT', to represent these timestamps.
6558 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
6559 This makes the code easier to follow, and makes it easier to catch
6560 integer overflow bugs such as Bug#8664.
6561 * frame.c (Fmouse_position, Fmouse_pixel_position):
6562 Use Time, not unsigned long, for user-interface timestamps.
6563 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6564 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6565 * keyboard.h (last_event_timestamp): Likewise.
6566 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6567 * menu.h (xmenu_show): Likewise.
6568 * term.c (term_mouse_position): Likewise.
6569 * termhooks.h (struct input_event.timestamp): Likewise.
6570 (struct terminal.mouse_position_hook): Likewise.
6571 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6572 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6573 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6574 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6575 what it was before.
6576 * menu.h, termhooks.h: Include "systime.h", for Time.
6577
8e55734a
PE
6578 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6579 Don't assume that the difference between two unsigned long values
6580 can fit into an integer. At this point, we know button_down_time
6581 <= event->timestamp, so the difference must be nonnegative, so
6582 there's no need to cast the result if double-click-time is
6583 nonnegative, as it should be; check that it's nonnegative, just in
6584 case. This bug is triggered when events are more than 2**31 ms
86db42d2 6585 apart (about 25 days). (Bug#8664)
8e55734a 6586
841f1b75 6587 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 6588 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 6589
3e26f69c
PE
6590 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6591 that always fit in int. Use a sentinel instead of a counter, to
6592 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
6593 * frame.h (struct frame): Use int for menu_bar_items_used
6594 instead of EMACS_INT, since it always fits in int.
3e26f69c 6595
5cc152c0
PE
6596 * menu.c (grow_menu_items): Check for int overflow.
6597
d89eb65e
PE
6598 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6599
5235bd3e
PE
6600 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6601 Before, the code was not consistent. These values cannot exceed
6602 2**31 - 1 so there's no need to make them unsigned.
6603 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6604 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6605 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6606 as modifiers.
6607 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6608
bc827e23
PE
6609 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6610 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6611 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6612 presumably because the widths might not match.
6613
78eb494e
PE
6614 * window.c (size_window): Avoid needless test at loop start.
6615
04f2d78b
CB
66162011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6617
6618 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6619
d2fc7e3d 66202011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
6621
6622 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6623
d2fc7e3d 66242011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
6625
6626 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6627 `width' to `bar_area_x' and `bar_area_width', respectively.
6628 (x_scroll_run): Take account of fringe background extension.
6629
04f2d78b
CB
6630 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6631 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
6632 `bar_area_width', respectively.
6633 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6634 background extension.
6635
79b70037
GM
66362011-05-10 Jim Meyering <meyering@redhat.com>
6637
6638 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6639
2f142cc5
JB
66402011-05-10 Juanma Barranquero <lekktu@gmail.com>
6641
6642 * image.c (Finit_image_library): Return t for built-in image types,
6643 like pbm and xbm. (Bug#8640)
6644
57679c86
AS
66452011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6646
6647 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6648
888c9e86
EZ
66492011-05-07 Eli Zaretskii <eliz@gnu.org>
6650
b0512a1d
EZ
6651 * w32console.c (Fset_screen_color): Doc fix.
6652 (Fget_screen_color): New function.
6653 (syms_of_ntterm): Defsubr it.
6654
7285dc67
EZ
6655 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6656 unlink the temporary file if Fcall_process didn't create it in the
6657 first place.
6658 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6659 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
6660 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6661 cue to call_process_cleanup not to close that handle.
6662
4d3fcc8e
BK
66632011-05-07 Ben Key <bkey76@gmail.com>
6664
6665 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6666 one of two shell specific rules, either bootstrap-temacs-CMD or
6667 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6668 to the previous implementation of the bootstrap-temacs rule.
6669 The bootstrap-temacs-CMD rule is similar to the previous
6670 implementation of the bootstrap-temacs rule except that it
6671 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6672 variable.
6673
6674 These changes, along with some changes to nt/configure.bat,
6675 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6676 earlier fix to add support for --cflags and --ldflags options
6677 that include quotes so that it works whether make uses cmd or
6678 sh as the shell.
6679
b4289b64
MA
66802011-05-06 Michael Albinus <michael.albinus@gmx.de>
6681
6682 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6683 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6684 is a constant.
6685 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6686 a string. Handle both cases.
6687 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6688 (Fdbus_register_method): Use Qinvalid_function.
6689
af4c0e28
JB
66902011-05-06 Juanma Barranquero <lekktu@gmail.com>
6691
6692 * makefile.w32-in: Update dependencies.
6693 (LISP_H): Add inttypes.h and stdin.h.
6694 (PROCESS_H): Add unistd.h.
6695
c51453d9
EZ
66962011-05-06 Eli Zaretskii <eliz@gnu.org>
6697
6698 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6699 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6700
8ff0ac3c 67012011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 6702
4c4b566b
PE
6703 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6704
aab2b9b5
PE
6705 * term.c (vfatal): Remove stray call to va_end.
6706 It's not needed and the C Standard doesn't allow it here anyway.
6707
c378da0b
PE
6708 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6709 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6710
288b08c7
PE
6711 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6712 bytes.
6713
e3601888
PE
6714 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6715
db6c0e74
PE
6716 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6717
dd5963ea
PE
6718 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6719
88c9450f
PE
6720 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6721
2f9442b8
PE
6722 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6723
c032b5f8
PE
6724 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6725 * charset.c (Fdefine_charset_internal): Don't initialize
6726 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 6727 32-bit int (Bug#8600).
a108c10b
PE
6728
6729 * lread.c (read_integer): Be more consistent with string-to-number.
6730 Use string_to_number to do the actual conversion; this avoids
6731 rounding errors and fixes some other screwups. Without this fix,
6732 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6733 (digit_to_number): Move earlier, for benefit of read_integer.
6734 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 6735 not a digit in any supported base. (Bug#8602)
a108c10b 6736
ad5f9eea
PE
6737 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6738
aec1708a
PE
6739 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6740 to match comment at start of function. This also removes a
6741 GCC warning about overflow in a 32+64-bit port.
6742
47be4ab5
PE
6743 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6744
371cac43
PE
6745 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6746 Reported by Stefan Monnier in
6747 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
6748 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6749 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 6750
d01a7826
PE
6751 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6752 (EMACS_UINTPTR): Likewise, with uintptr_t.
6753
7fd47d5c
PE
6754 * lisp.h: Prefer 64-bit EMACS_INT if available.
6755 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6756 on 32-bit hosts that have 64-bit int, so that they can access
6757 large files.
122b0c86
PE
6758 However, temporarily disable this change unless the temporary
6759 symbol WIDE_EMACS_INT is defined.
7fd47d5c 6760
8727937b
PE
6761 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6762
8ac068ac
PE
6763 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6764 This removes an assumption that EMACS_INT and long are the same
6765 width as pointers. The assumption is true for Emacs porting targets
6766 now, but we want to make other targets possible.
6767 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6768 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6769 In the rest of the code, change types of integers that hold casted
6770 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6771 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6772 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6773 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6774 No need to cast type when ORing.
6775 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6776 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6777 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6778 assume EMACS_INT is the same width as char *.
6779 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6780 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6781 Remove no-longer-needed casts.
6782 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6783 (xg_tool_bar_help_callback, xg_make_tool_item):
6784 Use EMACS_INTPTR to hold an integer
6785 that will be cast to void *; this can avoid a GCC warning
6786 if EMACS_INT is not the same width as void *.
6787 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6788 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6789 (current_message_1, set_message_1):
6790 Use a local to convert to proper width without a cast.
6791 * xmenu.c (dialog_selection_callback): Likewise.
6792
ede49d71
PE
6793 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6794 Also, don't assume VALBITS / RAND_BITS is less than 5,
6795 and don't rely on undefined behavior when shifting a 1 left into
6796 the sign bit.
6797 * lisp.h (get_random): Change signature to match.
6798
2f30ecd0
PE
6799 * lread.c (hash_string): Use size_t, not int, for hash computation.
6800 Normally we prefer signed values; but hashing is special, because
6801 it's better to use unsigned division on hash table sizes so that
6802 the remainder is nonnegative. Also, size_t is the natural width
6803 for hashing into memory. The previous code used 'int', which doesn't
6804 retain enough info to hash well into very large tables.
6805 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6806
2a866e7b
PE
6807 * dbusbind.c: Don't possibly lose pointer info when converting.
6808 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6809 Use XPNTR rather than XHASH, so that the high-order bits of
6810 the pointer aren't lost when converting through void *.
6811
51639eac
PE
6812 * eval.c (Fautoload): Don't double-shift a pointer.
6813
92394119
PE
6814 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6815
dbdb9a7c
JB
68162011-05-06 Juanma Barranquero <lekktu@gmail.com>
6817
6818 * gnutls.c (DEF_GNUTLS_FN):
6819 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6820
db7a0b4f
AS
68212011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6822
6823 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6824 marker. (Bug#8610)
6825
cd394be1 68262011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
6827
6828 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6829 New version that can reserve upto 2GB of heap space.
6830
f7ff1b0f 68312011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
6832
6833 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6834
639c109b
TZ
68352011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6836
6837 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6838 `gnutls_certificate_set_x509_key_file'.
6839
d2127135
JB
68402011-05-05 Juanma Barranquero <lekktu@gmail.com>
6841
6842 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6843 Update dependencies.
6844
e968f4f3
JB
68452011-05-04 Juanma Barranquero <lekktu@gmail.com>
6846
6847 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6848 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6849 Remove unused parameter `fildes'.
6850 * process.c (read_process_output, send_process): Don't pass it.
6851
84d358f0
JB
68522011-05-04 Juanma Barranquero <lekktu@gmail.com>
6853
6854 Fix previous change: the library cache is defined in w32.c.
6855 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6856 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6857
0898ca10
JB
68582011-05-04 Juanma Barranquero <lekktu@gmail.com>
6859
6860 Implement dynamic loading of GnuTLS on Windows.
6861
6862 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6863 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6864 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6865 Declare.
6866
6867 * gnutls.c (Qgnutls_dll): Define.
6868 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6869 (gnutls_*): Declare function pointers.
6870 (init_gnutls_functions): New function to initialize function pointers.
6871 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6872 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6873 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6874 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6875 (emacs_gnutls_write, emacs_gnutls_read)
6876 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6877 (Fgnutls_available_p): New function.
6878 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6879 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6880 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6881
6882 * image.c: Include w32.h.
6883 (Vimage_type_cache): Delete.
6884 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6885 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6886 (w32_delayed_load): Move to w32.c.
6887
6888 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6889
6890 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6891 (w32_delayed_load): Move from image.c. When loading a library, record
6892 its filename in the :loaded-from property of the library id.
6893 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6894 Initialize and staticpro them.
6895 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6896
6897 * process.c: Include lisp.h before w32.h, not after.
6898 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6899 instead of gnutls_record_check_pending.
6900
6901 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6902
ff4de4aa
TZ
69032011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6904
6905 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6906 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6907 as passed in.
6908
abe95abb
JD
69092011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6910
6911 * xterm.c (x_set_frame_alpha): Do not set property on anything
6912 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6913
e16e55d4
JB
69142011-05-02 Juanma Barranquero <lekktu@gmail.com>
6915
6916 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6917
bafcf6a5
JB
69182011-05-02 Juanma Barranquero <lekktu@gmail.com>
6919
6920 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6921 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6922 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6923 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6924 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6925 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6926 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6927 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6928 (Qgnutls_bootprop_callbacks_verify): Make static.
6929
e7a6747f
AS
69302011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6931
19ed11ba
AS
6932 * callproc.c: Indentation fixup.
6933
e7a6747f 6934 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
6935 (wait_for_termination, interruptible_wait_for_termination):
6936 Move after wait_for_termination_1.
e7a6747f 6937
1ef14cb4
LMI
69382011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6939
6940 * sysdep.c (interruptible_wait_for_termination): New function
6941 which is like wait_for_termination, but allows keyboard
6942 interruptions.
6943
6944 * callproc.c (Fcall_process): Add (:file "file") as an option for
6945 the STDOUT buffer.
6946 (Fcall_process_region): Ditto.
6947
330d880c
EZ
69482011-04-30 Eli Zaretskii <eliz@gnu.org>
6949
8db90b73
EZ
6950 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6951 rather than `XVECTOR (FOO)->size'.
6952
330d880c
EZ
6953 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6954 inttypes.h, as a gnulib replacement is used if it not available in
6955 system headers.
6956
15cbd324
EZ
69572011-04-21 Eli Zaretskii <eliz@gnu.org>
6958
6959 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6960 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6961 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6962
6963 * coding.c (coding_alloc_by_realloc): Error out if destination
6964 will grow beyond MOST_POSITIVE_FIXNUM.
6965 (decode_coding_emacs_mule): Abort if there isn't enough place in
6966 charbuf for the composition carryover bytes. Reserve an extra
6967 space for up to 2 characters produced in a loop.
6968 (decode_coding_iso_2022): Abort if there isn't enough place in
6969 charbuf for the composition carryover bytes.
6970
69712011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 6972
ae940cca
EZ
6973 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6974 aborting when %lld or %lll format is passed.
6975 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6976 %llo or %llx format is passed. (Bug#8545)
6977
03ab8921
EZ
6978 * window.c (window_scroll_line_based): Use a marker instead of
6979 simple variables to record original value of point. (Bug#7952)
6980
afda1437
EZ
6981 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6982 produced by %s or %c overflows available buffer space. (Bug#8545)
6983
f76dee0c
PE
69842011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6985
6986 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 6987 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 6988
fdc5744d
JB
69892011-04-28 Juanma Barranquero <lekktu@gmail.com>
6990
6991 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6992
638f053a
JB
69932011-04-28 Juanma Barranquero <lekktu@gmail.com>
6994
6995 * keyboard.c (Qdelayed_warnings_hook): Define.
6996 (command_loop_1): Run `delayed-warnings-hook'
6997 if Vdelayed_warnings_list is non-nil.
6998 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6999 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
7000
d178f871
EZ
70012011-04-28 Eli Zaretskii <eliz@gnu.org>
7002
7003 * doprnt.c (doprnt): Don't return value smaller than the buffer
7004 size if the message was truncated. (Bug#8545).
7005
b124fd93
JB
70062011-04-28 Juanma Barranquero <lekktu@gmail.com>
7007
7008 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
7009 (Fx_window_property): #if-0 the whole functions, not just the bodies.
7010
e810457d
PE
70112011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7012
7013 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
7014
ea51cceb
JB
70152011-04-27 Juanma Barranquero <lekktu@gmail.com>
7016
7017 * makefile.w32-in: Update dependencies.
7018
94dcfacf
EZ
70192011-04-27 Eli Zaretskii <eliz@gnu.org>
7020
7021 Improve `doprnt' and its usage. (Bug#8545)
7022 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
7023 `format_end'. Remove support for %l as a conversion specifier.
7024 Don't use xrealloc. Improve diagnostics when the %l size modifier
7025 is used. Update the commentary.
7026
7027 * eval.c (verror): Simplify calculation of size_t.
7028
7029 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
7030 messages.
7031
f61f41d7
PE
70322011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
7033
7034 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
7035 change.
7036
96fb4434
PE
70372011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7038
7039 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7040 This makes this file independent of the recent pseudovector change.
7041
671875da 70422011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 7043
69e9b5a3
PE
7044 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7045
b5f869a7 7046 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 7047 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 7048 Remove unused local.
c8926152 7049 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 7050
841a1577 7051 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
7052 GCC 4.6.0 optimizes based on type-based alias analysis.
7053 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
7054 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7055 != &v->size, and therefore "v->size = 1; b->size = 2; return
7056 v->size;" must therefore return 1. This assumption is incorrect
7057 for Emacs, since it type-puns struct Lisp_Vector * with many other
7058 types. To fix this problem, this patch adds a new type struct
f904488f 7059 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
7060 and pseudovectors, and helps optimizing compilers not get fooled
7061 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7062 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
7063 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7064 the size member.
eab3844f
PE
7065 (XSETPVECTYPE): Rewrite in terms of new macro.
7066 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7067 This is a bit clearer, and further avoids the possibility of
7068 undesirable aliasing.
7069 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 7070 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
7071 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7072 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
7073 (ASIZE): Now uses header.size rather than size.
7074 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
7075 to avoid the hassle of writing XVECTOR (foo)->header.size.
7076 (struct vectorlike_header): New type.
eab3844f
PE
7077 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7078 object, to help avoid aliasing.
7079 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7080 (SUBRP): Likewise, since Lisp_Subr is a special case.
7081 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7082 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7083 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 7084 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
7085 changed to be "header.size" and "header.next".
7086 * buffer.h (struct buffer): Likewise.
7087 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7088 * frame.h (struct frame): Likewise.
7089 * process.h (struct Lisp_Process): Likewise.
7090 * termhooks.h (struct terminal): Likewise.
7091 * window.c (struct save_window_data, struct saved_window): Likewise.
7092 * window.h (struct window): Likewise.
7093 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7094 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7095 * buffer.c (init_buffer_once): Likewise.
7096 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7097 special case.
7098 * process.c (Fformat_network_address): Use local var for size,
7099 for brevity.
7100
0df1eac5
PE
7101 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7102
847ab9d1 7103 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
7104 * data.c (atof): Remove decl; no longer used or needed.
7105 (digit_to_number): Move to lread.c.
7106 (Fstring_to_number): Use new string_to_number function, to be
7107 consistent with how the Lisp reader treats infinities and NaNs.
7108 Do not assume that floating-point numbers represent EMACS_INT
7109 without losing information; this is not true on most 64-bit hosts.
7110 Avoid double-rounding errors, by insisting on integers when
7111 parsing non-base-10 numbers, as the documentation specifies.
7112 * lisp.h (string_to_number): New decl, replacing ...
7113 (isfloat_string): Remove.
bc0a5c13 7114 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 7115 (read1): Do not accept +. and -. as integers; this
452f4150
PE
7116 appears to have been a coding error. Similarly, do not accept
7117 strings like +-1e0 as floating point numbers. Do not report
7118 overflow for integer overflows unless the base is not 10 which
7119 means we have no simple and reliable way to continue.
7120 Break out the floating-point parsing into a new
7121 function string_to_number, so that Fstring_to_number parses
7122 floating point numbers consistently with the Lisp reader.
04f2d78b 7123 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
7124 (E_CHAR, EXP_INT): Remove, replacing with ...
7125 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7126 (string_to_number): New function, replacing isfloat_string.
7127 This function checks for valid syntax and produces the resulting
7128 Lisp float number too. Rework it so that string-to-number
bc0a5c13 7129 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
7130 so that overflow for non-base-10 numbers is reported only when
7131 there's no portable and simple way to convert to floating point.
452f4150 7132
67769ffc
PE
7133 * textprop.c (set_text_properties_1): Rewrite for clarity,
7134 and to avoid GCC warning about integer overflow.
7135
c20db43f
PE
7136 * intervals.h (struct interval): Use EMACS_INT for members
7137 where EMACS_UINT might cause problems. See
7138 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7139 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7140 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7141 All uses changed.
37aa2f85
PE
7142 (offset_intervals): Tell GCC not to worry about length overflow
7143 when negating a negative length.
c20db43f 7144
2538aa2f
PE
7145 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7146 (overrun_check_free): Likewise.
7147
f2d3008d
PE
7148 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7149 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7150 word size.
7151
ec8df744
PE
7152 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7153 (gnutls_make_error): Rename local to avoid shadowing.
7154 (gnutls_emacs_global_deinit): ifdef out; not used.
7155 (Fgnutls_boot): Use const for pointer to readonly storage.
7156 Comment out unused local. Fix pointer signedness problems.
7157
640ee02d
PE
7158 * lread.c (openp): Don't stuff size_t into an 'int'.
7159 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7160 about possible signed overflow.
7161
6048fb2a
PE
7162 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7163 (GDK_KEY_g): Don't define if already defined.
7164 (xg_prepare_tooltip): Avoid pointer signedness problem.
7165 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7166
fa3c87e1
PE
7167 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7168 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7169
2172544b
PE
7170 * xfns.c (Fx_window_property): Simplify a bit,
7171 to make a bit faster and to avoid GCC 4.6.0 warning.
7172 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7173
9b821a21
PE
7174 * fns.c (internal_equal): Don't assume size_t fits in int.
7175
3c616cfa
PE
7176 * alloc.c (compact_small_strings): Tighten assertion a little.
7177
c2982e87
PE
7178 Replace pEd with more-general pI, and fix some printf arg casts.
7179 * lisp.h (pI): New macro, generalizing old pEd macro to other
7180 conversion specifiers. For example, use "...%"pI"d..." rather
7181 than "...%"pEd"...".
7182 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 7183 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
7184 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7185 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7186 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7187 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7188 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7189 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7190 64-bit hosts.
7191 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7192 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7193 * print.c (safe_debug_print, print_object): Likewise.
7194 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7195 to int.
6f04d126
PE
7196 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7197 avoiding the 0 flag, which is not portable.
c2982e87
PE
7198 * process.c (Fmake_network_process): Use pI to avoid cast.
7199 * region-cache.c (pp_cache): Likewise.
7200 * xdisp.c (decode_mode_spec): Likewise.
7201 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7202 behavior on 64-bit hosts with printf arg.
6f04d126 7203 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
7204 (x_stop_queuing_selection_requests): Likewise.
7205 (x_get_window_property): Don't truncate byte count to an 'int'
7206 when tracing.
0b432f21 7207
5e073ec7
PE
7208 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7209 here, since it parses constructs like leading '-' and spaces,
7210 which are not wanted; and it overflows with large numbers.
7211 Instead, simply match F[0-9]+, which is what is wanted anyway.
7212
36372bf9
PE
7213 * alloc.c: Remove unportable assumptions about struct layout.
7214 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7215 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7216 (allocate_vectorlike, make_pure_vector): Use the new macros,
7217 plus offsetof, to remove unportable assumptions about struct layout.
7218 These assumptions hold on all porting targets that I know of, but
7219 they are not guaranteed, they're easy to remove, and removing them
7220 makes further changes easier.
7221
0b432f21
PE
7222 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7223 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
7224 (string_overrun_cookie): Now const. Use initializers that
7225 don't formally overflow signed char, to avoid warnings.
000098c1
PE
7226 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7227 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
7228 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7229 multiple of sizeof (EMACS_INT); it need not be, if
7230 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 7231 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 7232
895009e1
JB
72332011-04-26 Juanma Barranquero <lekktu@gmail.com>
7234
7235 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7236
6a7a1b0b
TZ
72372011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7238
7239 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 7240 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
7241 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7242
841a1577 72432011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
7244
7245 * lisp.h (Qdebug): List symbol.
895009e1 7246 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
7247 * keyboard.c (debug-on-event): New variable.
7248 (handle_user_signal): Break into debugger when debug-on-event
7249 matches the current signal symbol.
7250
f2d3ba6f
DN
72512011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7252
7253 * alloc.c (check_sblock, check_string_bytes)
7254 (check_string_free_list): Convert to standard C.
7255
42ce4c63
TZ
72562011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7257
7258 * w32.c (emacs_gnutls_push): Fix typo.
7259
825cd63c
EZ
72602011-04-25 Eli Zaretskii <eliz@gnu.org>
7261
fb11d64d
EZ
7262 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7263 "cast to pointer from integer of different size".
7264
825cd63c
EZ
7265 Improve doprnt and its use in verror. (Bug#8545)
7266 * doprnt.c (doprnt): Document the set of format control sequences
7267 supported by the function. Use SAFE_ALLOCA instead of always
7268 using `alloca'.
7269
7270 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7271 is one byte too soon. Don't use xrealloc; instead xfree and
7272 xmalloc anew.
7273
e061a11b
TZ
72742011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7275
7276 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7277 callbacks stage.
7278
7279 * gnutls.c: Renamed global_initialized to
7280 gnutls_global_initialized. Added internals for the
7281 :verify-hostname-error, :verify-error, and :verify-flags
7282 parameters of `gnutls-boot' and documented those parameters in the
7283 docstring. Start callback support.
9173deec
JB
7284 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7285 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7286 on error. Return error code.
e061a11b
TZ
7287 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7288 (emacs_gnutls_read): Likewise.
7289 (Fgnutls_boot): Return handshake error code.
7290 (emacs_gnutls_handle_error): New function.
7291 (wsaerror_to_errno): Likewise.
7292
7293 * w32.h (emacs_gnutls_pull): Add prototype.
7294 (emacs_gnutls_push): Likewise.
7295
7296 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7297 (emacs_gnutls_push): Likewise.
7298
72992011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7300
7301 * process.c (wait_reading_process_output): Check if GnuTLS
7302 buffered some data internally if no FDs are set for TLS
7303 connections.
7304
7305 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7306 (LIBS): Link to USER_LIBS.
7307 ($(BLD)/gnutls.$(0)): New target.
7308
fa6996bc
EZ
73092011-04-24 Eli Zaretskii <eliz@gnu.org>
7310
eb35682e
EZ
7311 * xdisp.c (handle_single_display_spec): Rename the
7312 display_replaced_before_p argument into display_replaced_p, to
7313 make it consistent with the commentary. Fix typos in the
7314 commentary.
7315
e2ad650c
EZ
7316 * textprop.c (syms_of_textprop): Remove dead code.
7317 (copy_text_properties): Delete obsolete commentary about an
7318 interface that was deleted long ago. Fix typos in the description
7319 of arguments.
7320
1b2de274
EZ
7321 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7322 to changes in oldXMenu/XMenu.h from 2011-04-16.
7323 <menu_help_message, prev_menu_help_message>: Constify.
7324 (IT_menu_make_room): menu->help_text is now `const char **';
7325 adjust.
7326
7327 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7328 to changes in oldXMenu/XMenu.h from 2011-04-16.
7329 (struct XMenu): Declare `help_text' `const char **'.
7330
7331 * xfaces.c <Qunspecified>: Make extern again.
7332
7333 * syntax.c: Include sys/types.h before including regex.h, as
7334 required by Posix.
7335
762b15be
EZ
7336 * doc.c (get_doc_string): Improve the format passed to `error'.
7337
7338 * doprnt.c (doprnt): Improve commentary.
7339
7340 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7341
7342 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7343 them with etags.
7344
f1052e5d
EZ
7345 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7346 changes in globals.h immediately force recompilation.
762b15be
EZ
7347 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7348 $(CURDIR)/s/ms-w32.h.
7349 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 7350
fa6996bc
EZ
7351 * character.c (Fchar_direction): Function deleted.
7352 (syms_of_character): Don't defsubr it.
7353 <char-direction-table>: Deleted.
7354
e6c3da20
EZ
73552011-04-23 Eli Zaretskii <eliz@gnu.org>
7356
7357 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7358 * doprnt.c: Include limits.h.
7359 (SIZE_MAX): New macro.
04f2d78b
CB
7360 (doprnt): Return a size_t value. 2nd arg is now size_t.
7361 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
7362 Improve overflow protection. Support `l' modifier for integer
7363 conversions. Support %l conversion. Don't assume an EMACS_INT
7364 argument for integer conversions and for %c.
7365
7366 * lisp.h (doprnt): Restore prototype.
7367
7368 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7369 $(SRC)/character.h.
7370
7371 * Makefile.in (base_obj): Add back doprnt.o.
7372
7373 * deps.mk (doprnt.o): Add back prerequisites.
7374 (callint.o): Depend on character.h.
7375
7376 * eval.c (internal_lisp_condition_case): Include the handler
7377 representation in the error message.
7378 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7379 when breaking from the loop.
7380
7381 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7382
7383 * callint.c (Fcall_interactively): When displaying error message
7384 about invalid control letter, pass the character's codepoint, not
7385 a pointer to its multibyte form. Improve display of the character
7386 in octal and display also its hex code.
7387
7388 * character.c (char_string): Use %x to display the (unsigned)
7389 codepoint of an invalid character, to avoid displaying a bogus
7390 negative value.
7391
7392 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7393 `error', not SYMBOL_NAME itself.
7394
7395 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7396 character arguments to `error'.
7397
7398 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7399 to `error' in error message about FINAL_CHAR argument. Make sure
7400 FINAL_CHAR is a character, and use %c when it is passed as
7401 argument to `error'.
7402
4ffd0d6b 74032011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
7404
7405 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7406
7407 * w32.c: Include <time.h>.
7408 (sys_localtime): New function.
7409
4ffd0d6b 74102011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
7411
7412 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7413
4ffd0d6b 7414 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 7415
4ffd0d6b 74162011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 7417
4ffd0d6b
GM
7418 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7419 zombies (Bug#8467).
aac0c6e3 7420
04c56954
EZ
74212011-04-19 Eli Zaretskii <eliz@gnu.org>
7422
7423 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7424 gl_state.e_property when gl_state.object is Qt.
7425
7426 * insdel.c (make_gap_larger): Remove limitation of buffer size
7427 to <= INT_MAX.
7428
16a43933
CY
74292011-04-18 Chong Yidong <cyd@stupidchicken.com>
7430
7431 * xdisp.c (lookup_glyphless_char_display)
7432 (produce_glyphless_glyph): Handle cons cell entry in
7433 glyphless-char-display.
7434 (Vglyphless_char_display): Document it.
7435
7436 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7437 glyphless-char-display.
7438
4581706e
CY
74392011-04-17 Chong Yidong <cyd@stupidchicken.com>
7440
7441 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7442
7443 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7444
7445 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7446 definition for no-X builds.
7447
4887c6e2 74482011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 7449
fd35b6f9
PE
7450 Static checks with GCC 4.6.0 and non-default toolkits.
7451
5c1ccb01
PE
7452 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7453
006c5daa
PE
7454 * process.c (keyboard_bit_set): Define only if SIGIO.
7455 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7456 (send_process): Repair possible setjmp clobbering.
7457
efc736d3
PE
7458 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7459
4e2fe2e6
PE
7460 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7461
f97334a2
PE
7462 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7463
4e75f29d
PE
7464 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7465 Define only if needed.
7466
90efadd1
PE
7467 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7468 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 7469 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 7470
3c647824
PE
7471 * dispextern.h (struct redisplay_interface): Rename param
7472 to avoid shadowing.
e264f262 7473 * termhooks.h (struct terminal): Likewise.
761383f4 7474 * xterm.c (xembed_send_message): Likewise.
3c647824 7475
b58c5c4a
PE
7476 * insdel.c (make_gap_smaller): Define only if
7477 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7478
cad59032
PE
7479 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7480 it.
7481
c339dc2e
PE
7482 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7483 so that we aren't warned about unused symbols.
7484
91a3e27b
PE
7485 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7486
399c71d3 7487 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 7488
8ffc96f5
PE
7489 * xfns.c (x_real_positions): Mark locals as initialized.
7490
eef9bc79
PE
7491 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7492
098db9dd
PE
7493 * xterm.c: Fix problems found by static analysis with other toolkits.
7494 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
7495 (x_dispatch_event): Declare static if USE_GTK, and
7496 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 7497 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 7498 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
7499 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7500 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 7501
eb18f6cc
PE
7502 * xmenu.c (menu_help_callback): Pointer type fixes.
7503 Use const pointers when pointing at readonly data. Avoid pointer
7504 signedness clashes.
7505 (FALSE): Remove unused macro.
7506 (update_frame_menubar): Remove unused decl.
7507
1fe72bf8
PE
7508 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7509
60d9e1db
PE
7510 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7511 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7512 (single_menu_item): Rename local to avoid shadowing.
7513
39261c26
PE
7514 * keyboard.c (make_lispy_event): Remove unused local var.
7515
018c5e19
PE
7516 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7517 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7518
63d2b86e
PE
7519 * bitmaps: Change bitmaps from unsigned char back to the X11
7520 compatible char. Avoid the old compiler warnings about
7521 out-of-range initializers by using, for example, '\xab' rather
7522 than 0xab.
7523
aefd87e1
PE
7524 * xgselect.c (xgselect_initialize): Check vs interface
7525 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7526
bf501fb9
PE
7527 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7528
e9829fdf
PE
7529 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7530 to read-only memory.
7531
1086c095
PE
7532 * fns.c (vector): Remove; this old hack is no longer needed.
7533
2baccd04 7534 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 7535 Remove unused var.
dde42981 7536 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 7537
72391843 7538 * xrdb.c (x_load_resources): Omit unused local.
3565b346 7539
436c16df 7540 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 7541 (x_window): Rename locals to avoid shadowing.
dc5ddd85 7542 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 7543
92bb796d 7544 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 7545 (x_term_init): Remove local to avoid shadowing.
92bb796d 7546
764430a3 7547 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
7548
7549 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7550 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7551
d1dfb56c
EZ
75522011-04-16 Eli Zaretskii <eliz@gnu.org>
7553
c4354cb4
EZ
7554 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7555
d1dfb56c
EZ
7556 Fix regex.c, syntax.c and friends for buffers > 2GB.
7557 * syntax.h (struct gl_state_s): Declare character position members
7558 EMACS_INT.
7559
7560 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7561
04f2d78b
CB
7562 * textprop.c (verify_interval_modification, interval_of):
7563 Declare arguments EMACS_INT.
d1dfb56c
EZ
7564
7565 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7566 EMACS_INT.
7567
7568 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7569
7570 * indent.c (Fvertical_motion): Local variable it_start is now
7571 EMACS_INT.
7572
7573 * regex.c (re_match, re_match_2, re_match_2_internal)
7574 (bcmp_translate, regcomp, regexec, print_double_string)
7575 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7576 (re_compile_pattern, re_exec): Declare arguments and local
7577 variables `size_t' and `ssize_t' and return values `regoff_t', as
7578 appropriate.
7579 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7580 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7581 <compile_stack_type>: `size' and `avail' are now `size_t'.
7582
7583 * regex.h <regoff_t>: Use ssize_t, not int.
7584 (re_search, re_search_2, re_match, re_match_2): Arguments that
7585 specify buffer/string position and length are now ssize_t and
7586 size_t. Return type is regoff_t.
7587
613052cd
BK
75882011-04-16 Ben Key <bkey76@gmail.com>
7589
7590 * nsfont.m: Fixed bugs in ns_get_family and
7591 ns_descriptor_to_entity that were caused by using free to
7592 deallocate memory blocks that were allocated by xmalloc (via
7593 xstrdup). This caused Emacs to crash when compiled with
7594 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7595 --enable-checking=xmallocoverrun). xfree is now used to
7596 deallocate these memory blocks.
7597
4170f62f 75982011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 7599
71b41406
PE
7600 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7601
9587a89d
PE
7602 emacs_write: Accept and return EMACS_INT for sizes.
7603 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7604 et seq.
7605 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7606 Accept and return EMACS_INT.
7607 (emacs_gnutls_write): Return the number of bytes written on
7608 partial writes.
7609 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
7610 (emacs_read, emacs_write): Remove check for negative size, as the
7611 Emacs source code has been audited now.
9587a89d
PE
7612 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7613 (emacs_read, emacs_write): Use it.
273a5f82
PE
7614 * process.c (send_process): Adjust to the new signatures of
7615 emacs_write and emacs_gnutls_write. Do not attempt to store
7616 a byte offset into an 'int'; it might overflow.
9587a89d 7617 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 7618
3e047f51
PE
7619 * sound.c: Don't assume sizes fit in 'int'.
7620 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 7621 Return EMACS_INT, not int.
3e047f51 7622 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
7623 Accept EMACS_INT, not int.
7624 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
7625 record read return values.
7626
cc39a9db
BK
76272011-04-15 Ben Key <bkey76@gmail.com>
7628
c9d0ec6d
JB
7629 * keyboard.c (Qundefined): Don't declare static since it is used
7630 in nsfns.m.
7631 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7632 static since they are used in nsfont.m.
cc39a9db 7633
6c60eb9f
SM
76342011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7635
7636 * process.c (Qprocessp): Don't declare static.
7637 * lisp.h (Qprocessp): Declare again.
7638
7990b61a
JB
76392011-04-15 Juanma Barranquero <lekktu@gmail.com>
7640
7641 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7642
5d4cb038
PE
76432011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7644
8bd7b830 7645 Improve C-level modularity by making more things 'static'.
cd64ea1d 7646
e3b27b31
PE
7647 Don't publish debugger-only interfaces to other modules.
7648 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7649 (verify_bytepos, count_markers): Move decls to the only modules
7650 that need them.
7651 * region-cache.h (pp_cache): Likewise.
7652 * window.h (check_all_windows): Likewise.
7653 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7654
5d4cb038
PE
7655 * sysdep.c (croak): Now static, if
7656 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7657 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
7658
7659 * alloc.c (refill_memory_reserve): Now static if
7660 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7661 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 7662
e87b6180
PE
7663 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7664 Define only if USE_LUCID.
7665
ac64929e
PE
7666 * xrdb.c (x_customization_string, x_rm_string): Now static.
7667
6f37259d
PE
7668 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7669 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7670
1683e3ab
PE
7671 * xdisp.c (draw_row_with_mouse_face): Now static.
7672 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7673
de9c2632
PE
7674 * window.h (check_all_windows): Mark externally visible.
7675
2b96acb7
PE
7676 * window.c (window_deletion_count): Now static.
7677
7678 * undo.c: Make symbols static if they're not exported.
7679 (last_undo_buffer, last_boundary_position, pending_boundary):
7680 Now static.
7681
50436f33
PE
7682 * textprop.c (interval_insert_behind_hooks): Now static.
7683 (interval_insert_in_front_hooks): Likewise.
7684
64520e5c
PE
7685 * term.c: Make symbols static if they're not exported.
7686 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7687 (max_frame_lines, tty_set_terminal_modes):
7688 (tty_reset_terminal_modes, tty_turn_off_highlight):
7689 (get_tty_terminal): Now static.
7690 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7691 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 7692 HAVE_WINDOW_SYSTEM.
64520e5c
PE
7693 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7694 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7695
1fa53021
PE
7696 * sysdep.c: Make symbols static if they're not exported.
7697 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7698 Now static.
7699 (sigprocmask_set, full_mask): Remove; unused.
7700 (wait_debugging): Mark as visible.
7701 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7702 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7703
d4b43b22
PE
7704 * syntax.c (syntax_temp): Define only if !__GNUC__.
7705
b7c513d0
PE
7706 * sound.c (current_sound_device, current_sound): Now static.
7707
989b29ad
PE
7708 * search.c (searchbufs, searchbuf_head): Now static.
7709
13a55a78
PE
7710 * scroll.c (scroll_cost): Remove; unused.
7711 * dispextern.h (scroll_cost): Remove decl.
7712
de68a1fc
PE
7713 * region-cache.h (pp_cache): Mark as externally visible.
7714
40ccffa6
PE
7715 * process.c: Make symbols static if they're not exported.
7716 (process_tick, update_tick, create_process, chan_process):
7717 (Vprocess_alist, proc_buffered_char, datagram_access):
7718 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7719 (deactivate_process): Mark defn as static, as well as decl.
7720 * lisp.h (create_process): Remove decl.
7721 * process.h (chan_process, Vprocess_alist): Remove decls.
7722
ad64fc97
PE
7723 * print.c: Make symbols static if they're not exported.
7724 (print_depth, new_backquote_output, being_printed, print_buffer):
7725 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7726 (print_interval, print_number_index, initial_stderr_stream):
7727 Now static.
7728 * lisp.h (Fprinc): Remove decl.
7729 (debug_output_compilation_hack): Mark as externally visible.
7730
adddb265
PE
7731 * sysdep.c (croak): Move decl from here to syssignal.h.
7732 * syssignal.h (croak): Put it here, so the API can be checked when
7733 'croak' is called from dissociate_if_controlling_tty.
7734
1717ede2
PE
7735 * minibuf.c: Make symbols static if they're not exported.
7736 (minibuf_save_list, choose_minibuf_frame): Now static.
7737 * lisp.h (choose_minibuf_frame): Remove decl.
7738
fa5fb2bc
PE
7739 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7740
1e3890d1
PE
7741 * lread.c: Make symbols static if they're not exported.
7742 (read_objects, initial_obarray, oblookup_last_bucket_number):
7743 Now static.
7744 (make_symbol): Remove; unused.
7745 * lisp.h (initial_obarray, make_symbol): Remove decls.
7746
8a1414fa
PE
7747 * keyboard.c: Make symbols static if they're not exported.
7748 (single_kboard, recent_keys_index, total_keys, recent_keys):
7749 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7750 (this_single_command_key_start, echoing, last_auto_save):
7751 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7752 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7753 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7754 (Vlispy_mouse_stem, double_click_count):
7755 Now static.
7756 (force_auto_save_soon): Define only if SIGDANGER.
7757 (ignore_mouse_drag_p): Now static if
7758 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7759 (print_help): Remove; unused.
7760 (stop_character, last_timer_event): Mark as externally visible.
7761 * keyboard.h (ignore_mouse_drag_p): Declare only if
7762 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7763 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7764 * lisp.h (echoing): Remove decl.
7765 (force_auto_save_soon): Declare only if SIGDANGER.
7766 * xdisp.c (redisplay_window): Simplify code, to make it more
7767 obvious that ignore_mouse_drag_p is not accessed if !defined
7768 USE_GTK && !defined HAVE_NS.
7769
93ea6e8f
PE
7770 * intervals.c: Make symbols static if they're not exported.
7771 (merge_properties_sticky, merge_interval_right, delete_interval):
7772 Now static.
7773 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7774
77382fcc
PE
7775 * insdel.c: Make symbols static if they're not exported.
7776 However, leave prepare_to_modify_buffer alone. It's never
7777 called from outside this function, but that appears to be a bug.
7778 (combine_after_change_list, combine_after_change_buffer):
4889fc82 7779 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
7780 (adjust_after_replace_noundo): Remove; unused.
7781 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 7782 (signal_before_change): Remove decls.
77382fcc 7783
9306c32e
PE
7784 * indent.c (val_compute_motion, val_vmotion): Now static.
7785
cd44d2eb
PE
7786 * image.c: Make symbols static if they're not exported.
7787 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7788 if USE_GTK.
7789 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7790 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7791
ad9a7a06
PE
7792 * fringe.c (standard_bitmaps): Now static.
7793 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7794
81626931
PE
7795 * frame.c: Make symbols static if they're not exported.
7796 (x_report_frame_params, make_terminal_frame): Now static.
7797 (get_frame_param): Now static, unless HAVE_NS.
7798 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7799 (x_get_resource_string): Remove; not used.
7800 * frame.h (make_terminal_frame, x_report_frame_params):
7801 (x_get_resource_string); Remove decls.
7802 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7803 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7804
239f9db9
PE
7805 * font.c, fontset.c: Make symbols static if they're not exported.
7806 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7807 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7808 * font.c (font_close_object): Now static.
7809 * font.h (font_close_object): Remove.
7810 * fontset.c (FONTSET_OBJLIST): Remove.
7811 (free_realized_fontset) #if-0 the body, which does nothing.
7812 (face_suitable_for_char_p): #if-0, as it's never called.
7813 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
7814 * xfaces.c (face_at_string_position):
7815 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
7816 since 0 is always ASCII.
7817
dfcf3579
PE
7818 * fns.c (weak_hash_tables): Now static.
7819
5045092b
PE
7820 * fileio.c: Make symbols static if they're not exported.
7821 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7822 (Vwrite_region_annotation_buffers): Now static.
7823
57a96f5c
PE
7824 * eval.c: Make symbols static if they're not exported.
7825 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7826 * lisp.h (backtrace_list): Remove decl.
7827
35f08c38
PE
7828 * emacs.c: Make symbols static if they're not exported.
7829 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7830 (fatal_error_code, fatal_error_signal_hook, standard_args):
7831 Now static.
7832 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7833 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7834 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7835 * lisp.h (fatal_error_signal_hook): Remove decl.
7836 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7837
f44bd759
PE
7838 * editfns.c: Move a (normally-unused) function to its only use.
7839 * editfns.c, lisp.h (get_operating_system_release): Remove.
7840 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7841 worth the hassle of breaking this out.
7842
b532497d
PE
7843 * xterm.c: Make symbols static if they're not exported.
7844 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7845 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7846 (x_destroy_window, x_delete_display):
7847 Now static.
7848 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7849 (x_mouse_leave): Remove; unused.
7850 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7851 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7852 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7853 Remove decls.
7854 (x_mouse_leave): Declare only if WINDOWSNT.
7855 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7856 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7857 USE_X_TOOLKIT.
7858
1675728f
PE
7859 * ftxfont.c: Make symbols static if they're not exported.
7860 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7861 HAVE_FREETYPE.
7862 * font.h (ftxfont_driver): Likewise.
7863
e4cebfca
PE
7864 * xfns.c: Make symbols static if they're not exported.
7865 (x_last_font_name, x_display_info_for_name):
7866 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7867 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7868 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7869 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7870 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7871 (last_show_tip_args): Now static.
7872 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7873 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7874 (x_screen_planes): Remove; unused.
7875 * dispextern.h (x_screen_planes): Remove decl.
7876
5bf46f05
PE
7877 * dispnew.c: Make symbols static if they're not exported.
7878 * dispextern.h (redraw_garbaged_frames, scrolling):
7879 (increment_row_positions): Remove.
7880 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7881 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7882 Now static.
7883 (redraw_garbaged_frames): Remove; unused.
7884
435f4c28
PE
7885 * xfaces.c: Make symbols static if they're not exported.
7886 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7887 Remove decls.
7888 * xterm.h (defined_color): Remove decls.
7889 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7890 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7891 (menu_face_changed_default, defined_color, free_realized_face):
7892 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7893 (ascii_face_of_lisp_face): Remove; unused.
7894
8524aef3
PE
7895 * xdisp.c: Make symbols static if they're not exported.
7896 * dispextern.h (scratch_glyph_row, window_box_edges):
7897 (glyph_to_pixel_coords, set_cursor_from_row):
7898 (get_next_display_element, set_iterator_to_next):
7899 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7900 (show_mouse_face): Remove decls
7901 * frame.h (message_buf_print): Likewise.
7902 * lisp.h (pop_message, set_message, check_point_in_composition):
7903 Likewise.
7904 * xterm.h (set_vertical_scroll_bar): Likewise.
7905 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7906 (message_buf_print, scratch_glyph_row, displayed_buffer):
7907 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7908 (get_next_display_element, show_mouse_face, window_box_edges):
7909 (frame_to_window_pixel_xy, check_point_in_composition):
7910 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7911 (glyph_to_pixel_coords): Remove; unused.
7912
16390cd2
PE
7913 * dired.c (file_name_completion): Now static.
7914
7915 * dbusbind.c (xd_in_read_queued_messages): Now static.
7916
a25f4dfa
PE
7917 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7918 * data.c (circular_list_error): Remove.
7919
14a9c8df
PE
7920 * commands.h (last_point_position, last_point_position_buffer):
7921 (last_point_position_window): Remove decls.
7922 * keyboard.c: Make these variables static.
7923
04f2d78b
CB
7924 * coding.h (coding, code_convert_region, encode_coding_gap):
7925 Remove decls.
74ab6df5
PE
7926 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7927 (iso_code_class, detect_coding, code_convert_region): Now static.
7928 (encode_coding_gap): Remove; unused.
7929
38dfbee1
PE
7930 * chartab.c (chartab_chars, chartab_bits): Now static.
7931
a2cb4e63
PE
7932 * charset.h (charset_iso_8859_1): Remove decl.
7933 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7934 Now static.
7935
127198fd
PE
7936 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7937 * ccl.c (Vccl_program_table): Now static.
7938 (check_ccl_update): Remove; unused.
7939
d85b608f
PE
7940 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7941 * category.h: ... from here.
7942 * category.c (check_category_table, set_category_set): Now static.
7943
31cd66f3
PE
7944 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7945 * lisp.h: Remove these decls.
7946
c358e587
PE
7947 * buffer.c (buffer_count): Remove unused var.
7948
e78aecca
PE
7949 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7950 so that it's not optimized away.
7951 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7952 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7953 exported only to the debugger.
7954
e192d7d3 7955 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 7956 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 7957
92470028
PE
7958 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7959 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7960 was inaccessible from Lisp.
7961 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7962 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7963
244ed907
PE
7964 alloc.c: Import and export fewer symbols, and remove unused items.
7965 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7966 is defined.
7967 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7968 it's not optimized away by whole-program optimization.
7969 (message_enable_multibyte, free_misc): Remove.
7970 (catchlist, handlerlist, mark_backtrace):
7971 Declare only if BYTE_MARK_STACK.
7972 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7973 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7974 (message_enable_multibyte): Remove decl.
7975 (free_misc, interval_free_list, float_block, float_block_index):
7976 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7977 (cons_free_list, last_marked_index):
7978 Now static.
7979 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7980 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7981 (mark_backtrace): Define only if BYTE_MARK_STACK.
7982 * xdisp.c (message_enable_multibyte): Now static.
7983
61c2b50e 7984 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
7985 This makes it easier for human readers (and static analyzers)
7986 to see whether these variables are used from other modules.
7987 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7988 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7989 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7990 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7991 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7992 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7993 * xmenu.c, xselect.c:
7994 Declare Q* vars static if they are not used in other modules.
7995 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7996 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7997 Remove decls of unexported vars.
7998 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7999
95c82688
PE
8000 * lisp.h (DEFINE_FUNC): Make sname 'static'.
8001
16a97296
PE
8002 Make Emacs functions such as Fatom 'static' by default.
8003 This makes it easier for human readers (and static analyzers)
8004 to see whether these functions can be called from other modules.
8005 DEFUN now defines a static function. To make the function external
8006 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
8007 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
8008 (Finit_image_library):
16a97296
PE
8009 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
8010 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
8011 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
8012 Remove decls, since these functions are now static.
8013 (Funintern, Fget_internal_run_time): New decls, since these functions
8014 were already external.
95c82688 8015
16a97296
PE
8016 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
8017 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
8018 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
8019 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
8020 * keyboard.c, keymap.c, lread.c:
8021 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
8022 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
8023 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
8024 Mark functions with DEFUE instead of DEFUN,
8025 if they are used in other modules.
8026 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
8027 decls for now-static functions.
8028 * buffer.h (Fdelete_overlay): Remove decl.
8029 * callproc.c (Fgetenv_internal): Mark as internal.
8030 * composite.c (Fremove_list_of_text_properties): Remove decl.
8031 (Fcomposition_get_gstring): New forward static decl.
8032 * composite.h (Fcomposite_get_gstring): Remove decl.
8033 * dired.c (Ffile_attributes): New forward static decl.
8034 * doc.c (Fdocumntation_property): New forward static decl.
8035 * eval.c (Ffetch_bytecode): New forward static decl.
8036 (Funintern): Remove extern decl; now in .h file where it belongs.
8037 * fileio.c (Fmake_symbolic_link): New forward static decl.
8038 * image.c (Finit_image_library): New forward static decl.
8039 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8040 * intervals.h (Fprevious_property_change):
8041 (Fremove_list_of_text_properties): Remove decls.
8042 * keyboard.c (Fthis_command_keys): Remove decl.
8043 (Fcommand_execute): New forward static decl.
8044 * keymap.c (Flookup_key): New forward static decl.
8045 (Fcopy_keymap): Now static.
8046 * keymap.h (Flookup_key): Remove decl.
8047 * process.c (Fget_process): New forward static decl.
8048 (Fprocess_datagram_address): Mark as internal.
8049 * syntax.c (Fsyntax_table_p): New forward static decl.
8050 (skip_chars): Remove duplicate decl.
8051 * textprop.c (Fprevious_property_change): New forward static decl.
8052 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8053 Now internal.
8054 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8055 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8056
785bbd42
PE
8057 * editfns.c (Fformat): Remove unreachable code.
8058
8b913b57
AS
80592011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8060
8061 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8062 change. (Bug#8496)
8063
a6744a35
EZ
80642011-04-13 Eli Zaretskii <eliz@gnu.org>
8065
8066 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8067 when at ZV. (Bug#8487)
8068
e7974947
AS
80692011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8070
baad03f0
AS
8071 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8072 (Bug#8437)
8073 * keyboard.c (parse_tool_bar_item): Likewise.
8074 * sound.c (sound_cleanup, alsa_close): Likewise.
8075 * termcap.c (tgetent): Likewise.
8076 * xfns.c (x_default_font_parameter): Likewise.
8077 * xsettings.c (read_and_apply_settings): Likewise.
8078
e7974947
AS
8079 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8080 (overrun_check_free): Protoize.
8081
28272684
PE
80822011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8083
8084 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8085 since callers should never pass a negative size.
8086 Change the signature to match that of plain 'read' and 'write'; see
8087 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8088 * lisp.h: Update prototypes of emacs_write and emacs_read.
8089
11997c76
EZ
80902011-04-11 Eli Zaretskii <eliz@gnu.org>
8091
8092 * xdisp.c (redisplay_window): Don't try to determine the character
8093 position of the scroll margin if the window start point w->startp
e896f03c 8094 is outside the buffer's accessible region. (Bug#8468)
11997c76 8095
8a2cbd72
EZ
80962011-04-10 Eli Zaretskii <eliz@gnu.org>
8097
8098 Fix write-region and its subroutines for buffers > 2GB.
8099 * fileio.c (a_write, e_write): Modify declaration of arguments and
8100 local variables to support buffers larger than 2GB.
8101 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8102
8103 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8104 argument, local variables, and return value.
8105
8106 * lisp.h: Update prototypes of emacs_write and emacs_read.
8107
8108 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8109
4073e537 81102011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 8111
1ebfdcb6
PE
8112 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8113
b2ded58d
PE
8114 Fix more problems found by GCC 4.6.0's static checks.
8115
7d66342c
PE
8116 * xdisp.c (vmessage): Use a better test for character truncation.
8117
bbf47d44
PE
8118 * charset.c (load_charset_map): <, not <=, for optimization,
8119 and to avoid potential problems with integer overflow.
9248994d 8120 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 8121 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 8122 * editfns.c (Fformat): Likewise.
1e69125e 8123 * syntax.c (skip_chars): Likewise.
3befa583 8124
e3019616
PE
8125 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8126 This also lets GCC 4.6.0 generate slightly better loop code.
8127
becfa255
PE
8128 * callint.c (Fcall_interactively): <, not <=, for optimization.
8129 (Fcall_interactively): Count the number of arguments produced,
8130 not the number of arguments given. This is simpler and lets GCC
8131 4.6.0 generate slightly better code.
8132
dae0cd48
PE
8133 * ftfont.c: Distingish more carefully between FcChar8 and char.
8134 The previous code passed unsigned char * to a functions like
8135 strlen and xstrcasecmp that expect char *, which does not
8136 conform to the C standard.
8137 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8138 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8139 char * when the C standard requires it.
8140
76032d70
PE
8141 * keyboard.c (read_char): Remove unused var.
8142
eb3f1cc8
PE
8143 * eval.c: Port to Windows vsnprintf (Bug#8435).
8144 Include <limits.h>.
8145 (SIZE_MAX): Define if the headers do not.
8146 (verror): Do not give up if vsnprintf returns a negative count.
8147 Instead, grow the buffer. This ports to Windows vsnprintf, which
8148 does not conform to C99. Problem reported by Eli Zaretskii.
8149 Also, simplify the allocation scheme, by avoiding the need for
8150 calling realloc, and removing the ALLOCATED variable.
8151
70476b54
PE
8152 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8153
12020a9e
PE
8154 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8155 But keep the doprint source code for now, as we might revamp it
8156 and use it again (Bug#8435).
ea6c7ae6
PE
8157 * lisp.h (doprnt): Remove.
8158 * Makefile.in (base_obj): Remove doprnt.o.
8159 * deps.mk (doprnt.o): Remove.
8160
5fdb398c
PE
8161 error: Print 32- and 64-bit integers portably (Bug#8435).
8162 Without this change, on typical 64-bit hosts error ("...%d...", N)
8163 was used to print both 32- and 64-bit integers N, which relied on
8164 undefined behavior.
61bdb816 8165 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
8166 * lisp.h (error, verror): Mark as printf-like functions.
8167 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8168 Report overflow in size calculations when allocating printf buffer.
8169 Do not truncate output string at its first null byte.
8170 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8171 Truncate the output at a character boundary, since vsnprintf does not
8172 do that.
8173 * charset.c (check_iso_charset_parameter): Convert internal
8174 character to string before calling 'error', since %c now has the
8175 printf meaning.
8176 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8177 overflow when computing char to be passed to 'error'. Do not
8178 pass Lisp_Object to 'error'; pass the integer instead.
8179 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8180 formatted with plain %d.
8181
b189fa66
PE
8182 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8183
bff87ef0
PE
8184 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8185
7e2cac20
PE
8186 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8187
ce4d90b5
PE
8188 * xterm.c (x_catch_errors): Remove duplicate declaration.
8189
266c9547
PE
8190 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8191
79c49ad2
PE
8192 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8193
368f4090
JM
81942011-04-10 Jim Meyering <meyering@redhat.com>
8195
8196 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8197 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8198 return ssize_t not "int", and use size_t as the buffer length.
8199 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8200 * gnutls.h: Update declarations.
8201 * process.c (read_process_output): Use ssize_t, to match.
8202 (send_process): Likewise.
8203
a32d4040
CY
82042011-04-09 Chong Yidong <cyd@stupidchicken.com>
8205
8206 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8207
8546720e 82082011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 8209
04f2d78b
CB
8210 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8211 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 8212
8546720e
GM
8213 * xterm.c (handle_one_xevent):
8214 * xmenu.c (create_and_show_popup_menu):
8215 * xselect.c (x_decline_selection_request)
8216 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 8217
0a2f5c1a 82182011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
8219
8220 Fix some uses of `int' instead of EMACS_INT.
8221 * search.c (string_match_1, fast_string_match)
8222 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8223 (scan_buffer, find_next_newline_no_quit)
8224 (find_before_next_newline, search_command, Freplace_match)
8225 (Fmatch_data): Make some `int' variables be EMACS_INT.
8226
8227 * xdisp.c (display_count_lines): 3rd argument and return value now
8228 EMACS_INT. All callers changed.
8229 (pint2hrstr): Last argument is now EMACS_INT.
8230
8231 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8232 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8233 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8234 (decode_coding_utf_16, decode_coding_emacs_mule)
8235 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8236 (decode_coding_ccl, decode_coding_charset)
8237 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8238 (decode_coding_iso_2022, decode_coding_emacs_mule)
8239 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8240 <char_offset, last_offset>: Declare EMACS_INT.
8241 (encode_coding_utf_8, encode_coding_utf_16)
8242 (encode_coding_emacs_mule, encode_invocation_designation)
8243 (encode_designation_at_bol, encode_coding_iso_2022)
8244 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8245 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8246 Declare EMACS_INT.
8247 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8248 (encode_invocation_designation): Last argument P_NCHARS is now
8249 EMACS_INT.
8250 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8251 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8252
8253 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8254 All users changed.
8255
8256 * ccl.c (Fccl_execute_on_string): Declare some variables
8257 EMACS_INT.
8258
8546720e 82592011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
8260
8261 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8262
4e19a977
CS
82632011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8264
8265 * process.c (Fformat_network_address): Doc fix.
8266
87302331
R
82672011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8268
ee7683eb 8269 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 8270
cbb59342
CY
82712011-04-08 Chong Yidong <cyd@stupidchicken.com>
8272
8273 * keyboard.c (read_char): Call Lisp function help-form-show,
8274 instead of using internal_with_output_to_temp_buffer.
8275 (Qhelp_form_show): New var.
e0d38eeb 8276 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
8277
8278 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8279
8280 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8281
e67a13ab
CY
82822011-04-06 Chong Yidong <cyd@stupidchicken.com>
8283
04f2d78b
CB
8284 * process.c (Flist_processes): Remove to Lisp.
8285 (list_processes_1): Delete.
e67a13ab 8286
973f782d
EZ
82872011-04-06 Eli Zaretskii <eliz@gnu.org>
8288
7c106b1e
EZ
8289 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8290
973f782d
EZ
8291 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8292
41cf7d1a 82932011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 8294
ca23cc88
PE
8295 Fix more problems found by GCC 4.6.0's static checks.
8296
f390e2d5
PE
8297 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8298
42eea0d0
PE
8299 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8300
b69769da 8301 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 8302
f9541e84
PE
8303 * xdisp.c (vmessage): Mark as a printf-like function.
8304
13841b55
PE
8305 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8306
c136c10f
PE
8307 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8308
5e2d4a30
PE
8309 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8310 printf-like functions.
8311 (tiff_load): Add casts to remove these marks before passing them
8312 to system-supplied API.
8313
583f48b9
PE
8314 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8315
b25d760e
PE
8316 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8317 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
8318 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8319 directly, rather than having caller test rule sign. This avoids
8320 some unnecessary tests.
8321 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8322 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8323 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 8324
bc7b6697 8325 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 8326 (xfont_open): Avoid unnecessary tests.
bc7b6697 8327
27ccc379
PE
8328 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8329
dcd5c89a
PE
8330 * composite.h, composite.c (composition_gstring_put_cache):
8331 Use EMACS_INT, not int, for length.
8332
b13a45c6
PE
8333 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8334 breaking out part of COMPOSITION_DECODE_RULE.
8335 (COMPOSITION_DECODE_RULE): Use it.
8336 * composite.c (get_composition_id): Remove unused local vars,
8337 by using the new macro.
8338
1e792e4d
PE
8339 * textprop.c (set_text_properties_1): Change while to do-while,
8340 since the condition is always true at first.
8341
dc6c6455 8342 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
8343 (interval_deletion_adjustment): Return unsigned value.
8344 All uses changed.
dc6c6455 8345
aba7731a
PE
8346 * process.c (list_processes_1, create_pty, read_process_output):
8347 (exec_sentinel): Remove vars that were set but not used.
afd4052b 8348 (create_pty): Remove unnecessary "volatile"s.
bc57d757 8349 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 8350 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 8351 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 8352
fdfc4bf3
PE
8353 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8354
fca8fe46 8355 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 8356 (update_syntax_table): Use unsigned instead of int.
fca8fe46 8357
06a0259a 8358 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 8359 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 8360 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 8361
e7b9e80f
PE
8362 * print.c (print_error_message): Avoid int overflow.
8363
56201685
PE
8364 * font.c (font_list_entities): Redo for clarity,
8365 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8366
78834453 8367 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 8368 (font_score): Avoid potential overflow in diff calculation.
78834453 8369
0bc0b309 8370 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 8371 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 8372
e610eaca
PE
8373 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8374
b895abce
PE
8375 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8376 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8377 can always succeed if overflow has undefined behavior.
8378
1f1d9321 8379 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 8380 (wordify): Omit three unnecessary tests.
1f1d9321 8381
c59478bc
PE
8382 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8383 All callers changed. This avoids the need for an unused var.
8384
79b73827
PE
8385 * casefiddle.c (casify_region): Remove var that is set but not used.
8386
a4db5dfe
PE
8387 * dired.c (file_name_completion): Remove var that is set but not used.
8388
43aae36e
PE
8389 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8390
2a47c44d 8391 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 8392 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 8393
a37c69bf
PE
8394 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8395 Check for integer overflow on size calculations.
8396
328ab8e7
PE
8397 * buffer.c (Fprevious_overlay_change): Remove var that is set
8398 but not used.
8399
e5a2a5cb
PE
8400 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8401 Remove vars that are set but not used.
8d84a6eb 8402 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 8403 (timer_check_2): Mark vars as initialized.
e5a2a5cb 8404
a60e5f68
PE
8405 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8406
f661cb61 8407 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 8408 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 8409
f0397f5a
PE
8410 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8411 that are set but not used.
8412
8664db06 8413 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 8414 if XCreateBitmapFromData fails (Bug#8410).
8664db06 8415
6abdaa4a
PE
8416 * xselect.c (x_get_local_selection, x_handle_property_notify):
8417 Remove vars that are set but not used.
8418
0ce7538d 8419 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 8420 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 8421
9ae848fc
PE
8422 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8423 Remove var that is set but not used.
0b918413
PE
8424 (scroll_bar_windows_size): Now size_t, not int.
8425 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8426 Check for overflow.
9ae848fc 8427
a5a62657
PE
8428 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8429 (map_tty_color) [!defined MSDOS]: Likewise.
8430
5c5cdd39
PE
8431 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8432
66ebf983
PE
8433 * coding.c: Remove vars that are set but not used.
8434 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8435 All callers changed.
8436 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8437 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8438 (decode_coding_charset): Remove vars that are set but not used.
8439
1be4d761
PE
8440 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8441 that is set but not used.
8442
47553fa8
PE
8443 * print.c (print_object): Remove var that is set but not used.
8444
1f7196bf 8445 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
8446 The gnulib version avoids calling malloc in the usual case,
8447 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8448 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8449 * filelock.c (current_lock_owner): Likewise.
8450 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8451 * sysdep.c: Include allocator.h, careadlinkat.h.
8452 (emacs_no_realloc_allocator): New static constant.
8453 (emacs_readlink): New function.
fdb61804
PE
8454 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8455 ../lib/careadlinkat.h.
d1fdcab7 8456
f84c17c7
SM
84572011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8458
8459 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8460 first non-nil return value).
8461
ef3862ad
JD
84622011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8463
8464 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8465 if not defined (Bug#8403).
8466
376a7006
JB
84672011-04-02 Juanma Barranquero <lekktu@gmail.com>
8468
8469 * xdisp.c (display_count_lines): Remove parameter `start',
8470 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8471 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8472 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8473 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8474 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8475 and thereabouts. All callers changed.
8476 (get_per_char_metric): Remove parameter `f', unused since
8477 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8478
6ca3801d
JM
84792011-04-02 Jim Meyering <meyering@redhat.com>
8480
8481 do not dereference NULL upon failed strdup
8482 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8483 (ns_get_family): Likewise.
8484
d8e2b5ba
JB
84852011-04-02 Juanma Barranquero <lekktu@gmail.com>
8486
8487 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8488
8c74fcbd
JD
84892011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8490
8491 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8492 later (Bug#8403).
8493
7200d79c
SM
84942011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8495
03408648 8496 Add lexical binding.
7200d79c 8497
03408648
SM
8498 * window.c (Ftemp_output_buffer_show): New fun.
8499 (Fsave_window_excursion):
8500 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8501
8502 * lread.c (lisp_file_lexically_bound_p): New function.
8503 (Fload): Bind Qlexical_binding.
8504 (readevalloop): Remove `evalfun' arg.
8505 Bind Qinternal_interpreter_environment.
8506 (Feval_buffer): Bind Qlexical_binding.
8507 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8508 Mark as dynamic.
8509 (syms_of_lread): Declare `lexical-binding'.
8510
8511 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8512
8513 * keyboard.c (eval_dyn): New fun.
8514 (menu_item_eval_property): Use it.
ca105506
SM
8515
8516 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 8517
03408648
SM
8518 * fns.c (concat, mapcar1): Accept byte-code-functions.
8519
8520 * eval.c (Fsetq): Handle lexical vars.
8521 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8522 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8523 (FletX, Flet): Obey lexical binding.
8524 (Fcommandp): Handle closures.
8525 (Feval): New `lexical' arg.
8526 (eval_sub): New function extracted from Feval. Use it almost
8527 everywhere where Feval was used. Look up vars in lexical env.
8528 Handle closures.
8529 (Ffunctionp): Move from subr.el.
8530 (Ffuncall): Handle closures.
8531 (apply_lambda): Remove `eval_flags'.
8532 (funcall_lambda): Handle closures and new byte-code-functions.
8533 (Fspecial_variable_p): New function.
8534 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8535 but without exporting it to Lisp.
23aba0ea 8536
23aba0ea 8537 * doc.c (Fdocumentation, store_function_docstring):
03408648 8538 * data.c (Finteractive_form): Handle closures.
23aba0ea 8539
03408648
SM
8540 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8541 interactive spec.
ba83908c 8542
04f2d78b
CB
8543 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8544 New byte-codes.
03408648
SM
8545 (exec_byte_code): New function extracted from Fbyte_code to handle new
8546 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 8547
03408648 8548 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 8549
03408648 8550 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 8551
e2abce01
JB
85522011-03-31 Juanma Barranquero <lekktu@gmail.com>
8553
8554 * xdisp.c (redisplay_internal): Fix prototype.
8555
63696a73 85562011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 8557
63696a73 8558 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
8559 (try_scrolling): Use it when setting scroll_limit.
8560 Limit scrolling to 100 screen lines.
63696a73
EZ
8561 (redisplay_window): Even when falling back on "recentering",
8562 position point in the window according to scroll-conservatively,
8563 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8564
8565 (try_scrolling): When point is above the window, allow searching
8566 as far as scroll_max, or one screenful, to compute vertical
8567 distance from PT to the scroll margin position. This prevents
8568 try_scrolling from unnecessarily failing when
8569 scroll-conservatively is set to a value slightly larger than the
8570 window height. Clean up the case of PT below the margin at bottom
8571 of window: scroll_max can no longer be INT_MAX. When aggressive
8572 scrolling is in use, don't let point enter the opposite scroll
8573 margin as result of the scroll.
8574 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
8575 threshold of 100 lines for never-recentering scrolling.
8576
e4cc2dfc
JB
85772011-03-31 Juanma Barranquero <lekktu@gmail.com>
8578
8579 * dispextern.h (move_it_by_lines):
8580 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8581 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8582 (message_log_check_duplicate): Remove parameters `prev_bol' and
8583 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8584 (redisplay_internal): Remove parameter `preserve_echo_area',
8585 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8586
8587 * indent.c (Fvertical_motion):
8588 * window.c (window_scroll_pixel_based, Frecenter):
8589 Don't pass `need_y_p' to `move_it_by_lines'.
8590
1c470562
SM
85912011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8592
44f230aa
SM
8593 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8594 steal a few bits to be more compact.
8595 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8596 Remove unneeded casts.
8597
1c470562
SM
8598 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8599
888adce9
ZK
86002011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8601
8602 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8603 binding" message (bug#7967).
8604
f838ed7b
PE
86052011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8606
77861b95
PE
8607 Fix more problems found by GCC 4.6.0's static checks.
8608
de6dbc14
PE
8609 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8610 Remove unused local var.
8611
f838ed7b
PE
8612 * editfns.c (Fmessage_box): Remove unused local var.
8613
792c7b2b
PE
8614 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8615 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8616 Omit unused local vars.
c499e557 8617 * window.c (shrink_windows): Omit unused local var.
b01a1c29 8618 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
8619 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8620 Omit unused local var.
8621
ba0165e1
PE
8622 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8623 Don't assume string length fits in int.
32ad8845 8624 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 8625 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 8626
3c59b4c9
PE
8627 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8628 instead of alloca (Bug#8344).
8629
a3eed478 8630 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 8631 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 8632
eb4d412d
PE
8633 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8634
1658b401
PE
8635 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8636 concerns.
8637
8638 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8639
8640 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 8641
9a2c6e05
PE
8642 * keyboard.c (syms_of_keyboard): Use the same style as later
8643 in this function when indexing through an array. This also
8644 works around GCC bug 48267.
8645
03d0a109
PE
8646 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8647
44f730c8
PE
8648 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8649
fe75f926
PE
8650 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8651 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8652
ffa8c828
PE
8653 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8654 This avoids undefined behavior on integer overflow, and is a bit
8655 more convenient anyway since it is compared to a size_t variable.
8656
c5101a77
PE
8657 Variadic C functions now count arguments with size_t, not int.
8658 This avoids an unnecessary limitation on 64-bit machines, which
8659 caused (substring ...) to crash on large vectors (Bug#8344).
8660 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8661 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 8662 All variadic functions and their callers changed accordingly.
c5101a77
PE
8663 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8664 * data.c (arith_driver, float_arith_driver): Likewise.
8665 * editfns.c (general_insert_function): Likewise.
8666 * eval.c (struct backtrace.nargs, interactive_p)
8667 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8668 (funcall_lambda, mark_backtrace): Likewise.
8669 * fns.c (concat): Likewise.
8670 * frame.c (x_set_frame_parameters): Likewise.
8671 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8672 0 if not found, not -1. All callers changed.
8673
dd3f25f7
PE
8674 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8675 (stack_copy_size): Now size_t, not int.
8676 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8677
461c2ab9
JB
86782011-03-28 Juanma Barranquero <lekktu@gmail.com>
8679
8680 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8681 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8682 All callers changed.
8683
8684 * lisp.h (multibyte_char_to_unibyte):
8685 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8686 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8687 * character.h (CHAR_TO_BYTE8):
8688 * cmds.c (internal_self_insert):
8689 * editfns.c (general_insert_function):
8690 * keymap.c (push_key_description):
8691 * search.c (Freplace_match):
8692 * xdisp.c (message_dolog, set_message_1): All callers changed.
8693
f6d62986
SM
86942011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8695
8696 * keyboard.c (safe_run_hook_funcall): New function.
8697 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8698 don't set the hook to nil, but remove the offending function instead.
8699 (Qcommand_hook_internal): Remove, unused.
8700 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8701 Vcommand_hook_internal.
8702
8703 * eval.c (enum run_hooks_condition): Remove.
8704 (funcall_nil, funcall_not): New functions.
8705 (run_hook_with_args): Call each function through a `funcall' argument.
8706 Remove `cond' argument, now redundant.
8707 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8708 (Frun_hook_with_args_until_failure): Adjust accordingly.
8709 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8710
1db5b1ad
JB
87112011-03-28 Juanma Barranquero <lekktu@gmail.com>
8712
8713 * dispextern.h (string_buffer_position): Remove declaration.
8714
8715 * print.c (strout): Remove parameter `multibyte', unused since
8716 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8717
8718 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8719 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8720 All callers changed.
8721
8722 * w32.c (_wsa_errlist): Use braces for struct initializers.
8723
8724 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8725 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8726 All callers changed.
8727 (string_buffer_position): Likewise. Also, make static (it's never
8728 used outside xdisp.c).
8729 (cursor_row_p): Remove parameter `w', unused since
8730 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8731 (decode_mode_spec): Remove parameter `precision', introduced during
8732 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8733 All callers changed.
8734
5ffb62aa
JD
87352011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8736
8737 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8738
461c2ab9 87392011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
8740
8741 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8742 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8743 (ns_update_auto_hide_menu_bar): New functions.
8744 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8745 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8746 ns_constrain_all_frames.
8747 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8748 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8749
5c380ffb
JD
87502011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8751
8752 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8753
9af30bdf
GM
87542011-03-27 Glenn Morris <rgm@gnu.org>
8755
8756 * syssignal.h: Replace RETSIGTYPE with void.
8757 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8758 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8759 Replace SIGTYPE with void everywhere.
8760 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8761 * s/template.h (SIGTYPE): Remove commented out definition.
8762
e2abce01
JB
87632011-03-26 Eli Zaretskii <eliz@gnu.org>
8764
8765 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8766 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8767
f868cd8a
JB
87682011-03-26 Juanma Barranquero <lekktu@gmail.com>
8769
59eb0929
JB
8770 * w32.c (read_unc_volume): Use parameter `henum', instead of
8771 global variable `wget_enum_handle'.
8772
8773 * keymap.c (describe_vector): Remove parameters `indices' and
8774 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8775 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8776
f868cd8a
JB
8777 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8778
8779 * keyboard.c (timer_check): Remove parameter `do_it_now',
8780 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8781 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8782 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8783
8784 * keyboard.c (read_char):
8785 * w32menu.c (w32_menu_display_help):
8786 * xmenu.c (show_help_event, menu_help_callback):
8787 Adjust calls to `show_help_echo'.
8788
8789 * gtkutil.c (xg_maybe_add_timer):
8790 * keyboard.c (readable_events):
8791 * process.c (wait_reading_process_output):
8792 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8793
8794 * insdel.c (adjust_markers_gap_motion):
8795 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8796 (gap_left, gap_right): Don't call it.
8797
2ecf6fdb
CY
87982011-03-25 Chong Yidong <cyd@stupidchicken.com>
8799
8800 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8801 incurred during fontification.
8802
6b1f9ba4
JB
88032011-03-25 Juanma Barranquero <lekktu@gmail.com>
8804
8805 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8806 (DEFVAR_PER_BUFFER): Don't pass it.
8807
8808 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8809 (scrolling_window): Don't pass it.
8810
0f4a96b5
JB
88112011-03-25 Juanma Barranquero <lekktu@gmail.com>
8812
8813 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8814
8815 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8816 and `suffix'.
8817 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8818 of variables specific to SELinux and computation of `encoded_absname'.
8819
8820 * image.c (XPutPixel): Remove unused variable `height'.
8821
8822 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8823
8824 * unexw32.c (get_section_info): Remove unused variable `section'.
8825
8826 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8827 (system_process_attributes): Remove unused variable `sess'.
8828 (sys_read): Remove unused variable `err'.
8829
8830 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8831 (w32_wnd_proc): Remove unused variable `isdead'.
8832 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8833 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8834 (x_create_tip_frame): Remove unused variable `tem'.
8835
8836 * w32inevt.c (w32_console_read_socket):
8837 Remove unused variable `no_events'.
8838
8839 * w32term.c (x_draw_composite_glyph_string_foreground):
8840 Remove unused variable `width'.
8841
1149507c
JB
88422011-03-24 Juanma Barranquero <lekktu@gmail.com>
8843
8844 * w32term.c (x_set_glyph_string_clipping):
8845 Don't pass uninitialized region to CombineRgn.
8846
9c88f339
JB
88472011-03-23 Juanma Barranquero <lekktu@gmail.com>
8848
8849 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8850 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8851 (Fx_close_connection): Remove unused variable `i'.
8852
8853 * w32font.c (w32font_draw): Return number of glyphs.
8854 (w32font_open_internal): Remove unused variable `i'.
8855 (w32font_driver): Add missing initializer.
8856
8857 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8858 (fill_in_menu): Remove unused variable `items_added'.
8859
8860 * w32term.c (last_mouse_press_frame): Remove static global variable.
8861 (w32_clip_to_row): Remove unused variable `f'.
8862 (x_delete_terminal): Remove unused variable `i'.
8863
8864 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8865 (NOTHING): Remove unused static global variable.
8866 (uniscribe_check_otf): Remove unused variable `table'.
8867 (uniscribe_font_driver): Add missing initializers.
8868
dee091a3
JD
88692011-03-23 Julien Danjou <julien@danjou.info>
8870
8871 * term.c (Fsuspend_tty, Fresume_tty):
8872 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8873 * window.c (temp_output_buffer_show):
8874 * insdel.c (signal_before_change):
8875 * frame.c (Fhandle_switch_frame):
8876 * fileio.c (Fdo_auto_save):
8877 * emacs.c (Fkill_emacs):
8878 * editfns.c (save_excursion_restore):
8879 * cmds.c (internal_self_insert):
8880 * callint.c (Fcall_interactively):
8881 * buffer.c (Fkill_all_local_variables):
8882 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8883 Use Frun_hooks.
0f4a96b5 8884 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 8885 unconditionally since it does the check itself.
dee091a3 8886
2c520ab5 88872011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 8888
c9c49752
PE
8889 Fix more problems found by GCC 4.5.2's static checks.
8890
8abc3f12
PE
8891 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8892 the first time through the loop, since we know p0 < p1 then.
8893 This also avoids a gcc -Wstrict-overflow warning.
8894
a2d26660
PE
8895 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8896 leading to a memory leak, possible in functions like
8897 load_charset_map_from_file that can allocate an unbounded number
b12ef411 8898 of objects (Bug#8318).
a2d26660 8899
916c72e9
PE
8900 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8901 that could (at least in theory) be that large.
8902
19ab8a18
PE
8903 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8904 This is less likely to overflow, and avoids undefined behavior if
8905 overflow does occur. All callers changed. Use strtoul to scan
8906 for the unsigned long integer.
b7cbbd6f
PE
8907 (pint2hrstr): Simplify and tune code slightly.
8908 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 8909
f0641eff
PE
8910 * scroll.c (do_scrolling): Work around GCC bug 48228.
8911 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8912
7f650bb9
PE
8913 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8914 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
8915 (validate_x_resource_name): Simplify count usage.
8916 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 8917
37dd57d1
PE
8918 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8919 fail (Bug#8306).
81e56e61 8920
699979fc 8921 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 8922
401bf9b4
PE
8923 * process.c (Fmake_network_process): Use socklen_t, not int,
8924 where POSIX says socklen_t is required in portable programs.
8925 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 8926 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
8927 (Fmake_network_process, server_accept_connection):
8928 (wait_reading_process_output, read_process_output):
8929 Likewise.
8930
b93aacde
PE
8931 * process.c: Rename or move locals to avoid shadowing.
8932 (list_processes_1, Fmake_network_process):
8933 (read_process_output_error_handler, exec_sentinel_error_handler):
8934 Rename or move locals.
4dc343ee 8935 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 8936 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 8937 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 8938 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 8939 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 8940
af8a867c 8941 Make tparam.h and terminfo.c consistent.
44f230aa
SM
8942 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8943 Include tparam.h instead, since it declares them.
af8a867c
PE
8944 * cm.h (PC): Remove extern decl; tparam.h now does this.
8945 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8946 * terminfo.c: Include tparam.h, to check interfaces.
8947 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8948 (tparam): Adjust signature to match interface in tparam.h;
8949 this removes some undefined behavior. Check that outstring and len
8950 are zero, which they always are with Emacs.
8951 * tparam.h (PC, BC, UP): New extern decls.
8952
0248044d 8953 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 8954 (xftfont_open): Rename locals to avoid shadowing.
0248044d 8955
8ff096c1 8956 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
8957 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8958 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 8959 (ftfont_list): Remove unused local.
49eaafba
PE
8960 (get_adstyle_property, ftfont_pattern_entity):
8961 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8962 Rename locals to avoid shadowing.
8ff096c1 8963
e2be39f6
PE
8964 * xfont.c (xfont_list_family): Mark var as initialized.
8965
c9735e30
PE
8966 * xml.c (make_dom): Now static.
8967
8f5201ae
PE
8968 * composite.c (composition_compute_stop_pos): Rename local to
8969 avoid shadowing.
b246f932
PE
8970 (composition_reseat_it): Remove unused locals.
8971 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 8972 (composition_update_it): Mark var as initialized.
11b61122
PE
8973 (find_automatic_composition): Mark vars as initialized,
8974 with a FIXME (Bug#8290).
8f5201ae 8975
760fbc2c
PE
8976 character.h: Rename locals to avoid shadowing.
8977 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8978 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8979 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8980 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8981 to avoid shadowing.
8982
ff08eb85
PE
8983 * textprop.c (property_change_between_p): Remove; unused.
8984
fc7bf025
PE
8985 * intervals.c (interval_start_pos): Now static.
8986
235d7abc
PE
8987 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8988
44f230aa
SM
8989 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8990 Rename locals to avoid shadowing.
3e7d6594 8991
50060332
PE
8992 * sound.c (wav_play, au_play, Fplay_sound_internal):
8993 Fix pointer signedness.
d01f234b 8994 (alsa_choose_format): Remove unused local var.
c83b8872
PE
8995 (wav_play): Initialize a variable to 0, to prevent undefined
8996 behavior (Bug#8278).
50060332 8997
c4fc4e30
PE
8998 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8999
918436ed
PE
9000 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
9001
c939f91b
PE
9002 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
9003 clobbering (Bug#8298).
b9c7f648
PE
9004 * sysdep.c (sys_subshell): Likewise.
9005 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 9006
6bd8c144
PE
9007 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
9008 This should get cleaned up, so that child_setup has the
9009 same signature on all platforms.
9010
7710357c 9011 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 9012 (relocate_fd): Rename locals to avoid shadowing.
7710357c 9013
c59da222
CY
90142011-03-22 Chong Yidong <cyd@stupidchicken.com>
9015
9016 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
9017 not to be necessary, and produces flickering.
9018
66b87493
GM
90192011-03-20 Glenn Morris <rgm@gnu.org>
9020
9021 * config.in: Remove file.
9022
45b6f6d5
JB
90232011-03-20 Juanma Barranquero <lekktu@gmail.com>
9024
9025 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
9026 are now in src/globals.h.
9027 (syms_of_minibuf): Remove spurious & from previous change.
9028
cd394be1 90292011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
9030
9031 * minibuf.c (completing-read-function): New variable.
9032 (completing-read-default): Rename from completing-read.
9033 (completing-read): Call completing-read-function.
9034
b14e3e21
CY
90352011-03-19 Juanma Barranquero <lekktu@gmail.com>
9036
9037 * xfaces.c (Fx_load_color_file):
9038 Read color file from absolute filename (bug#8250).
9039
f2b726e6
JB
90402011-03-19 Juanma Barranquero <lekktu@gmail.com>
9041
9042 * makefile.w32-in: Update dependencies.
9043
09f6ff02
EZ
90442011-03-17 Eli Zaretskii <eliz@gnu.org>
9045
9046 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9047
29a6015a
PE
90482011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9049
a3a6c54e
PE
9050 Fix more problems found by GCC 4.5.2's static checks.
9051
b766f867
PE
9052 * process.c (make_serial_process_unwind, send_process_trap):
9053 (sigchld_handler): Now static.
9054
be02381c
PE
9055 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9056 That way, the code declares only the vars that it needs.
9057 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9058 * s/cygwin.h (PTY_ITERATION): Likewise.
9059 * s/darwin.h (PTY_ITERATION): Likewise.
9060 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9061
57048744
PE
9062 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9063 * process.c (allocate_pty): Don't declare stb unless it's needed.
9064
7914961c 9065 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
9066 (CONSTANTLIM): Remove; unused.
9067 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9068 Define only if needed.
7914961c 9069
b3967b18
PE
9070 * unexelf.c (unexec): Name an expression,
9071 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
9072 Use a different way to cause a compilation error if anyone uses
9073 n rather than nn, a way that does not involve shadowing.
73366a00 9074 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 9075
29a6015a
PE
9076 * deps.mk (unexalpha.o): Remove; unused.
9077
43cfc33e 9078 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 9079 * unexec.h: New file.
ce701a33
PE
9080 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9081 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9082 Depend on unexec.h.
9083 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9084 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9085 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 9086 Change as necessary to match prototype in unexec.h.
ce701a33 9087
01f44d5a
PE
9088 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9089 shadowing.
4f63c6bb 9090 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 9091
a6670b0b
PE
9092 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9093 Rename locals to avoid shadowing.
9094
cef2010d 9095 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 9096 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 9097
d4d7173a
PE
9098 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9099
f08b802a
PE
9100 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9101 warning when compiling print.c.
9102
3ddb0639
PE
9103 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9104 instead of using an uninitialized var.
5ad03b97 9105 (font_sort_entities): Mark var as initialized.
3ddb0639 9106
170a2692
PE
9107 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9108
e663c700
PE
9109 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9110 pointers to constants.
89bc529a 9111 (font_parse_fcname): Remove unused vars.
7b81e2d0 9112 (font_delete_unmatched): Now static.
ea838e10 9113 (font_get_spec): Remove; unused.
13a547c6
PE
9114 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9115 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9116 Rename or move locals to avoid shadowing.
e663c700 9117
2a80c887 9118 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 9119 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 9120
1384fa33 9121 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 9122 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 9123
8b2c52e9
PE
9124 * alloc.c (mark_backtrace): Move decl from here ...
9125 * lisp.h: ... to here, so that it can be checked.
9126
475545b5 9127 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 9128 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
9129 (lisp_indirect_variable): Name an expression,
9130 to avoid gcc -Wbad-function-cast warning.
1faed8ae 9131 (Fdefvar): Rename locals to avoid shadowing.
475545b5 9132
b1349114 9133 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 9134 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 9135 Use const pointer when appropriate.
b1349114 9136
a2928364
PE
9137 * lisp.h (get_system_name, get_operating_system_release):
9138 Move decls here, to check interfaces.
9139 * process.c (get_operating_system_release): Move decl to lisp.h.
9140 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
9141 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9142 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9143 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
9144 (Fformat_time_string, Fencode_time, Finsert_char):
9145 (Ftranslate_region_internal, Fformat):
9146 Rename or remove local vars to avoid shadowing.
9710023e 9147 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 9148
a415e694
PE
9149 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9150 avoid shadowing.
9151
8ef4622d
PE
9152 * lisp.h (eassert): Check that the argument compiles, even if
9153 ENABLE_CHECKING is not defined.
9154
946f9a5b
PE
9155 * data.c (Findirect_variable): Name an expression, to avoid
9156 gcc -Wbad-function-cast warning.
112396d6 9157 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 9158 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
9159 (Fmake_variable_buffer_local, Fmake_local_variable):
9160 Mark variables as initialized.
52746918 9161 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 9162
e5aab7e7 9163 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
9164 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9165 Rename locals to avoid shadowing.
dff45157
PE
9166 (mark_stack): Move local variables into the #ifdef region where
9167 they're used.
7bc26fdb
PE
9168 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9169 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9170 needed otherwise.
9171 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9172 (GC_STRING_CHARS): Remove; not used.
d40d4be1 9173 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 9174
e5aab7e7
PE
9175 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9176 avoids undefined behavior in theory.
9177
4da60324
PE
9178 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9179
88043301
PE
9180 Use functions, not macros, for up- and down-casing (Bug#8254).
9181 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9182 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9183 to use the following functions instead of these macros.
9184 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9185 EMACS_INT, since callers assume the returned value fits in int.
9186 (upcase1): Likewise, for UPCASE_TABLE.
9187 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 9188 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 9189 the race-condition problem in the old DOWNCASE.
88043301 9190
19ed5445
PE
9191 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9192 Rename locals to avoid shadowing.
9193 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
9194 (regex_compile, re_search_2, re_match_2_internal):
9195 Remove unused local vars.
952db0d7
PE
9196 (FREE_VAR): Rewrite so as not to use empty "else",
9197 which gcc can warn about.
da053e48 9198 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
9199 (RETALLOC_IF): Define only if needed.
9200 (WORDCHAR_P): Likewise. This one is never needed, but is used
9201 only in a comment talking about a compiler bug, so put inside
9202 the #if 0 of that comment.
9203 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9204 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9205 Remove; unused.
19ed5445 9206
1f3561e4 9207 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
9208 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9209 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 9210
ded6f8f7
PE
9211 * search.c (simple_search): Remove unused var.
9212
dbd37a95
PE
9213 * dired.c (compile_pattern): Move decl from here ...
9214 * lisp.h: ... to here, so that it can be checked.
9215 (struct re_registers): New forward decl.
9216
7e47afad
PE
9217 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9218
85f24f61
PE
9219 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9220 All uses changed.
9221 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9222 Rename locals to avoid shadowing.
5671df8f 9223 (Fvertical_motion): Mark locals as initialized.
85f24f61 9224
181aa2be 9225 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 9226 (casify_region): Mark local as initialized.
181aa2be 9227
930d429c
PE
9228 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9229
7082eac6
PE
9230 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9231 New macros, so that the caller can use some names other than
9232 gcpro1, gcpro2, etc.
9233 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9234 of the new macros.
9235 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9236 argument, for consistency with GCPRO2_VAR, etc: it is now the
9237 prefix of the variable, not the variable itself. All uses
9238 changed.
38b2c076
PE
9239 * dired.c (directory_files_internal, file_name_completion):
9240 Rename locals to avoid shadowing.
9241
15206ed9
PE
9242 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9243 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9244 dired.c's scmp function, had undefined behavior.
9245 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9246 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9247 * buffer.h: ... to here, because these macros use current_buffer,
9248 and the new implementation with inline functions needs to have
9249 current_buffer in scope now, rather than later when the macros
9250 are used.
9251 (downcase, upcase1): New static inline functions.
9252 (DOWNCASE, UPCASE1): Reimplement using these functions.
9253 This avoids undefined behavior in expressions like
9254 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9255 from race conditions in accessing the global variables
9256 case_temp1 and case_temp2.
9257 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9258 * lisp.h (case_temp1, case_temp2): Remove their decls.
9259 * character.h (ASCII_CHAR_P): Move from here ...
9260 * lisp.h: ... to here, so that the inline functions mentioned
9261 above can use them.
9262
4a6bea26
PE
9263 * dired.c (directory_files_internal_unwind): Now static.
9264
f14b7e14
PE
9265 * fileio.c (file_name_as_directory, directory_file_name):
9266 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9267 Now static.
2893f146
PE
9268 (file_name_as_directory): Use const pointers when appropriate.
9269 (Fexpand_file_name): Likewise. In particular, newdir might
9270 point at constant storage, so make it a const pointer.
fd4ead52 9271 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
9272 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9273 signedness issues.
f839df0c
PE
9274 (Fset_file_times, Finsert_file_contents, auto_save_error):
9275 Rename locals to avoid shadowing.
f14b7e14 9276
5716756e 9277 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
9278 (Ftry_completion, Fall_completions): Rename or remove locals
9279 to avoid shadowing.
5716756e 9280
b4c3046a
PE
9281 * marker.c (bytepos_to_charpos): Remove; unused.
9282
b45db522
PE
9283 * lisp.h (verify_bytepos, count_markers): New decls,
9284 so that gcc does not warn that these functions aren't declared.
9285
85876d07
PE
9286 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9287 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 9288 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 9289 (copy_text): Remove unused local var.
85876d07 9290
03d78a21 9291 * filelock.c (within_one_second): Now static.
b3dd38ab 9292 (lock_file_1): Rename local to avoid shadowing.
03d78a21 9293
5df8f01b
PE
9294 * buffer.c (fix_overlays_before): Mark locals as initialized.
9295 (fix_start_end_in_overlays): Likewise. This function should be
9296 simplified by using pointers-to-pointers, but that's a different
9297 matter.
b1d876f1 9298 (switch_to_buffer_1): Now static.
8f54f30a
PE
9299 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9300 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 9301
a70072c9 9302 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 9303 Fix pointer signedness issue.
edced198
PE
9304 (sys_subshell): Mark local as volatile if checking for lint,
9305 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 9306 (MAXPATHLEN): Define only if needed.
a70072c9 9307
a0977c44
PE
9308 * process.c (serial_open, serial_configure): Move decls from here ...
9309 * systty.h: ... to here, so that they can be checked.
9310
a884fdcc
PE
9311 * fns.c (get_random, seed_random): Move extern decls from here ...
9312 * lisp.h: ... to here, so that they can be checked.
9313
604efe86 9314 * sysdep.c (reset_io): Now static.
b8950c94 9315 (wait_for_termination_signal): Remove; unused.
604efe86 9316
38fc62d9
PE
9317 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9318 (copy_keymap_item, append_key, push_text_char_description):
9319 Now static.
1004a21a 9320 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 9321 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
9322 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9323 (describe_map_tree):
9324 Rename locals to avoid shadowing.
38fc62d9 9325
2f2650da
PE
9326 * keyboard.c: Declare functions static if they are not used elsewhere.
9327 (echo_char, echo_dash, cmd_error, top_level_2):
9328 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
9329 (read_char, kbd_buffer_get_event, make_lispy_position):
9330 (make_lispy_event, make_lispy_movement, apply_modifiers):
9331 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9332 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9333 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 9334 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 9335 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 9336
a053e86c 9337 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
9338 (mark_kboards): Move decl here ...
9339 * alloc.c (mark_kboards): ... from here.
a053e86c 9340
4752793e
PE
9341 * lisp.h (force_auto_save_soon): New decl.
9342
74f10ca7 9343 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
9344 (DEFINE_DUMMY_FUNCTION): New macro.
9345 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9346 Use it.
c03cd23f
PE
9347 (main): Add casts to avoid warnings
9348 if GCC considers string literals to be constants.
74f10ca7 9349
022e70d4
PE
9350 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9351
59d6fe83
PE
9352 * dbusbind.c: Pointer signedness fixes.
9353 (xd_signature, xd_append_arg, xd_initialize):
9354 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9355 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9356 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9357 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9358
78320123
PE
9359 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9360 if GCC considers string literals to be constants.
49cebcca 9361 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 9362
35ac2a97
SM
93632011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9364
fb103ca9
SM
9365 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9366 (print_preprocess, print_object): New macro to fix last change.
9367
35ac2a97
SM
9368 * print.c (print_preprocess): Don't forget font objects.
9369
62973b41
JB
93702011-03-16 Juanma Barranquero <lekktu@gmail.com>
9371
9372 * emacs.c (USAGE3): Doc fixes.
9373
0e48bb22
AS
93742011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9375
9376 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9377 structure.
9378
7684e57b
JB
93792011-03-14 Juanma Barranquero <lekktu@gmail.com>
9380
9381 * lisp.h (VWindow_system, Qfile_name_history):
9382 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9383 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9384 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9385
9386 * w32select.c: Don't #include "keyboard.h".
c96bbc66 9387 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
9388
9389 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9390 * w32console.c (detect_input_pending, read_input_pending)
9391 (encode_terminal_code):
9392 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9393 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9394 (w32_system_caret_y, Qfile_name_history):
9395 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9396 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9397 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9398 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9399 * w32proc.c (Qlocal, report_file_error):
9400 * w32term.c (Vwindow_system, updating_frame):
9401 * w32uniscribe.c (initialized, uniscribe_font_driver):
9402 Remove unneeded extern declarations.
9403
2aa46d6c
CY
94042011-03-14 Chong Yidong <cyd@stupidchicken.com>
9405
c96bbc66 9406 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 9407
cffc6f3b
CY
94082011-03-13 Chong Yidong <cyd@stupidchicken.com>
9409
9410 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9411 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9412 These macros can no longer be used for assignment.
9413
44f230aa
SM
9414 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9415 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
9416 (record_buffer_markers, fetch_buffer_markers): New functions for
9417 recording and fetching special buffer markers.
9418 (set_buffer_internal_1, set_buffer_temp): Use them.
9419
9420 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9421
9422 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9423
9424 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9425 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9426
9427 * xdisp.c (hscroll_window_tree):
9428 (reconsider_clip_changes): Use PT instead of BUF_PT.
9429
d251f04b
EZ
94302011-03-13 Eli Zaretskii <eliz@gnu.org>
9431
9432 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9433 $(EMACS_ROOT)/lib/intprops.h.
9434
f0c77cd1
PE
94352011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9436
3eca4629
PE
9437 Fix more problems found by GCC 4.5.2's static checks.
9438
7c86ee98
PE
9439 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9440 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
9441 (xg_free_frame_widgets): Make it clear that a local variable is
9442 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
9443 (gdk_window_get_screen): Make it clear that this macro is needed
9444 only if USE_GTK_TOOLTIP.
1e5524e7
PE
9445 (int_gtk_range_get_value): New function, which avoids a diagnostic
9446 from gcc -Wbad-function-cast.
9447 (xg_set_toolkit_scroll_bar_thumb): Use it.
9448 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9449 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
9450 (get_utf8_string, xg_get_file_with_chooser):
9451 Rename locals to avoid shadowing.
9452 (create_dialog): Move locals to avoid shadowing.
7c86ee98 9453
41729b81
PE
9454 * xgselect.c (xg_select): Remove unused var.
9455
f0c77cd1
PE
9456 * image.c (four_corners_best): Mark locals as initialized.
9457 (gif_load): Initialize transparent_p to zero (Bug#8238).
9458 Mark another local as initialized.
ec6cf4c6 9459 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 9460
ce0ad53d 9461 * image.c (clear_image_cache): Now static.
d5d5a617 9462 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 9463 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
9464 (x_edge_detection): Remove unnecessary cast that
9465 gcc -Wbad-function-cast diagnoses.
2037898d 9466 (gif_load): Fix pointer signedness.
6ae141d6
PE
9467 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9468 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 9469
33383987 94702011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 9471
d32df629
PE
9472 Improve quality of tests for time stamp overflow.
9473 For example, without this patch (encode-time 0 0 0 1 1
9474 1152921504606846976) returns the obviously-bogus value (-948597
9475 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9476 reports time overflow. See
9477 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
9478 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9479 * editfns.c: Include limits.h and intprops.h.
9480 (TIME_T_MIN, TIME_T_MAX): New macros.
9481 (time_overflow): Move earlier, to before first use.
9482 (hi_time, lo_time): New functions, for an accurate test for
9483 out-of-range times.
9484 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9485 (Fget_internal_run_time): Don't assume time_t fits in int.
9486 (make_time): Use list2 instead of Fcons twice.
9487 (Fdecode_time): More accurate test for out-of-range times.
9488 (check_tm_member): New function.
9489 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
9490 (lisp_time_argument): Don't rely on undefined left-shift and
9491 right-shift behavior when checking for time stamp overflow.
8be6f318 9492
fe31d94c
PE
9493 * editfns.c (time_overflow): New function, refactoring common code.
9494 (Fformat_time_string, Fdecode_time, Fencode_time):
9495 (Fcurrent_time_string): Use it.
9496
8be6f318
PE
9497 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9498 * dired.c (make_time): Move to ...
9499 * editfns.c (make_time): ... here.
9500 * systime.h: Note the move.
9501
09d9db2c 95022011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 9503
126bc0dc
YM
9504 * fringe.c (update_window_fringes): Remove unused variables.
9505
c47cbdfd
YM
9506 * unexmacosx.c (copy_data_segment): Also copy __got section.
9507 (Bug#8223)
9508
7ac80be9
EZ
95092011-03-12 Eli Zaretskii <eliz@gnu.org>
9510
c96bbc66 9511 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
9512 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9513 Constify `char *' arguments and their references according to
9514 prototypes in tparam.h.
9515
ecb0f94d 9516 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 9517
7ac80be9
EZ
9518 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9519 Adapt all references accordingly.
9520
9521 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9522
ef1fd07e
TT
95232011-03-11 Tom Tromey <tromey@redhat.com>
9524
9525 * buffer.c (syms_of_buffer): Remove obsolete comment.
9526
7ef4b50c
EZ
95272011-03-11 Eli Zaretskii <eliz@gnu.org>
9528
9529 * termhooks.h (encode_terminal_code): Declare prototype.
9530
9531 * msdos.c (encode_terminal_code): Don't declare prototype.
9532
9533 * term.c (encode_terminal_code): Now external again, used by
9534 w32console.c and msdos.c.
9535
44f230aa
SM
9536 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9537 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 9538
4b1ec863 95392011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 9540
1714f52b 9541 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 9542
4b1ec863
PE
9543 * fringe.c (update_window_fringes): Mark locals as initialized
9544 (Bug#8227).
9545 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 9546
524c7aa6
PE
9547 * alloc.c (mark_fringe_data): Move decl from here ...
9548 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9549 to check its interface.
9550 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9551
a5c0af81 9552 * fontset.c (free_realized_fontset): Now static.
7519b8cd 9553 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 9554 (fontset_font): Mark local as initialized.
a9a06e0b 9555 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 9556
b4716021
PE
9557 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9558
811e9bac 9559 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 9560 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
9561 (x_own_selection, Fx_disown_selection_internal): Rename locals
9562 to avoid shadowing.
9563 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 9564
7e3ab302
PE
9565 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9566 so that the caller can use some name other than gcpro1.
9567 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
9568 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9569 (Fx_backspace_delete_keys_p):
9570 Use them to avoid shadowing, and rename vars to avoid shadowing.
9571 (x_decode_color, x_set_name, x_window): Now static.
6b437900 9572 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 9573 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
9574 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9575 Remove unused locals.
7e3ab302
PE
9576 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9577 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9578 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9579 macros.
f78faa98 9580
e2b13473
PE
9581 * xterm.h (x_mouse_leave): New decl.
9582
77f23912
PE
9583 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9584 Remove unused functions.
cdf4ba58
PE
9585 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9586 (x_calc_absolute_position): Now static.
7411c686 9587 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 9588 Don't declare local "event" unless it's used.
ed7bf3a5
PE
9589 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9590 unless they are used.
38d0b34a
PE
9591 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9592 (x_fatal_error_signal): Remove; not used.
a6067996
PE
9593 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9594 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9595 (x_error_catcher, x_connection_closed, x_error_handler):
9596 (x_error_quitter, xembed_send_message, x_iconify_frame):
9597 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 9598 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 9599 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 9600
44f230aa
SM
9601 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9602 Rename or move locals to avoid shadowing.
6b463e58 9603 (tty_defined_color, merge_face_heights): Now static.
5967d051 9604 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
9605 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9606 does not deduce is never used uninitialized.
73719eba
PE
9607 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9608 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 9609
426994c3 9610 * terminal.c (store_terminal_param): Now static.
5489860b 9611
032f1620 9612 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 9613 (set_frame_menubar): Remove unused local.
d4323972 9614 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
9615 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9616 since they might point to immutable storage.
281585b0
PE
9617 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9618 since it's unused otherwise.
032f1620 9619
367c19e5 9620 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 9621 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
9622 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9623 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 9624 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
9625 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9626 does not deduce are never used uninitialized.
70739cbe 9627
07b48fa9
PE
9628 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9629
8868a238 9630 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
9631 * window.c (window_loop, size_window):
9632 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 9633
7e5cf297 9634 * window.c (display_buffer): Now static.
d6550a9f
PE
9635 (size_window): Mark variables that gcc -Wuninitialized
9636 does not deduce are never used uninitialized.
a586633d
PE
9637 * window.h (check_all_windows): New decl, to forestall
9638 gcc -Wmissing-prototypes diagnostic.
5b555da1 9639 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 9640
f6095868
PE
9641 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9642 shadowing.
9643 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
9644 Include <limits.h>.
9645 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9646 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
9647 (load_charset_map): Mark variables that gcc -Wuninitialized
9648 does not deduce are never used uninitialized.
53df7c11 9649 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 9650
f38b440c
PE
9651 * coding.c (coding_set_source, coding_set_destination):
9652 Use "else { /* comment */ }" rather than "else /* comment */;"
9653 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
9654 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9655 a block, when the outer 'i' will do.
9656 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9657 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9658 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9659 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9660 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9661 Rename locals to avoid shadowing.
9662 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
9663 * coding.c (emacs_mule_char, encode_invocation_designation):
9664 Now static, since they're not used elsewhere.
413bb2db 9665 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 9666 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
9667 (decode_coding_emacs_mule): Mark variables that gcc
9668 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
9669 (detect_coding_iso_2022): Initialize a local variable that might
9670 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 9671 this initialization is needed. (Bug#8211)
5f58e762
PE
9672 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9673 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9674 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9675 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9676 Remove unused macros.
f38b440c 9677
232b38b9 9678 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 9679 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 9680 * character.c (string_count_byte8): Likewise.
232b38b9 9681
fb90da1b
PE
9682 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9683 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9684
fb93dbc2
PE
9685 * chartab.c (copy_sub_char_table): Now static, since it's not used
9686 elsewhere.
5c156ace
PE
9687 (sub_char_table_ref_and_range, char_table_ref_and_range):
9688 Rename locals to avoid shadowing.
bbcd0949 9689 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 9690
7d3b3862 9691 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 9692 (BIDI_BOB): Remove unused macro.
7d3b3862 9693
6be7d3da
PE
9694 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9695 deduce are never used uninitialized.
c2ed9c8b 9696 * term.c (encode_terminal_code): Likewise.
6be7d3da 9697
75f8807f 9698 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 9699
50938595
PE
9700 * tparam.h: New file.
9701 * term.c, tparam.h: Include it.
9702 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9703 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9704 Move these decls to tparam.h, and make them agree with what
9705 is actually in tparam.c. The previous trick of using incompatible
9706 decls in different modules does not conform to the C standard.
9707 All callers of tparam changed to use tparam's actual API.
9708 * tparam.c (tparam1, tparam, tgoto):
9709 Use const pointers where appropriate.
9710
fbceeba2
PE
9711 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9712 * cm.h (struct cm): Likewise.
9713 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9714 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9715 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9716 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9717 (turn_on_face, init_tty): Likewise.
9718 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 9719
7f3f1250
PE
9720 * term.c (term_mouse_position): Rename local to avoid shadowing.
9721
e6ca6543
PE
9722 * alloc.c (mark_ttys): Move decl from here ...
9723 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9724
c40f8d15
AS
97252011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9726
9727 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9728
cfe0661d
JB
97292011-03-09 Juanma Barranquero <lekktu@gmail.com>
9730
9731 * search.c (compile_pattern_1): Remove argument regp, unused since
9732 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9733 (compile_pattern): Don't pass it.
9734
0afb4571
J
97352011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9736
9737 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9738 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9739 for ! HAVE_GTK3.
9740 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9741
9742 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9743
9744 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9745 gdk_window_get_screen, gdk_window_get_geometry,
9746 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9747 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9748 (xg_get_pixbuf_from_pixmap): New function.
9749 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9750 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9751 Call xg_get_pixbuf_from_pixmap instead of
9752 gdk_pixbuf_get_from_drawable.
9753 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9754 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9755 (xg_check_special_colors): Use GtkStyleContext and its functions
9756 for HAVE_GTK3.
9757 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9758 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9759 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
9760 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9761 Call gtk_widget_get_preferred_size.
0afb4571
J
9762 (xg_frame_resized): gdk_window_get_geometry only takes 5
9763 parameters.
44f230aa
SM
9764 (xg_win_to_widget, xg_event_is_for_menubar):
9765 Call gdk_x11_window_lookup_for_display.
0afb4571
J
9766 (xg_set_widget_bg): New function.
9767 (delete_cb): New function.
895009e1 9768 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 9769 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
9770 (xg_set_background_color): Call xg_set_widget_bg.
9771 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9772 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9773 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9774 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9775 if ! HAVE_GTK3.
9776 (update_frame_tool_bar): Call gtk_widget_hide.
9777 (xg_initialize): Use GDK_KEY_g.
9778
9779 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9780 if ! HAVE_GTK3
9781 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9782
9783 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9784 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9785 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9786
1c2cc4ef
JB
97872011-03-08 Juanma Barranquero <lekktu@gmail.com>
9788
9789 * w32xfns.c (select_palette): Check success of RealizePalette against
9790 GDI_ERROR, not zero.
9791
33383987 9792See ChangeLog.11 for earlier changes.
aac0c6e3
MR
9793
9794;; Local Variables:
9795;; coding: utf-8
aac0c6e3
MR
9796;; End:
9797
acaf905b 9798 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
9799
9800 This file is part of GNU Emacs.
9801
9802 GNU Emacs is free software: you can redistribute it and/or modify
9803 it under the terms of the GNU General Public License as published by
9804 the Free Software Foundation, either version 3 of the License, or
9805 (at your option) any later version.
9806
9807 GNU Emacs is distributed in the hope that it will be useful,
9808 but WITHOUT ANY WARRANTY; without even the implied warranty of
9809 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9810 GNU General Public License for more details.
9811
9812 You should have received a copy of the GNU General Public License
9813 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.