* xfns.c (free_frame_menubar, atof): Remove duplicate decls.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
4887c6e2 12011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 2
436c16df
PE
3 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
4
92bb796d 5 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 6 (x_term_init): Remove local to avoid shadowing.
92bb796d 7
764430a3 8 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
9
10 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
11 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
12
4170f62f 132011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 14
71b41406
PE
15 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
16
9587a89d
PE
17 emacs_write: Accept and return EMACS_INT for sizes.
18 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
19 et seq.
20 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
21 Accept and return EMACS_INT.
22 (emacs_gnutls_write): Return the number of bytes written on
23 partial writes.
24 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
25 (emacs_read, emacs_write): Remove check for negative size, as the
26 Emacs source code has been audited now.
9587a89d
PE
27 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
28 (emacs_read, emacs_write): Use it.
273a5f82
PE
29 * process.c (send_process): Adjust to the new signatures of
30 emacs_write and emacs_gnutls_write. Do not attempt to store
31 a byte offset into an 'int'; it might overflow.
9587a89d 32 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 33
3e047f51
PE
34 * sound.c: Don't assume sizes fit in 'int'.
35 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 36 Return EMACS_INT, not int.
3e047f51 37 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
38 Accept EMACS_INT, not int.
39 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
40 record read return values.
41
cc39a9db
BK
422011-04-15 Ben Key <bkey76@gmail.com>
43
44 * keyboard.c (Qundefined): Don't declare static since it is
45 used in nsfns.m.
46 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't
47 declare static since they are used in nsfont.m.
48
6c60eb9f
SM
492011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
50
51 * process.c (Qprocessp): Don't declare static.
52 * lisp.h (Qprocessp): Declare again.
53
7990b61a
JB
542011-04-15 Juanma Barranquero <lekktu@gmail.com>
55
56 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
57
5d4cb038
PE
582011-04-14 Paul Eggert <eggert@cs.ucla.edu>
59
8bd7b830 60 Improve C-level modularity by making more things 'static'.
cd64ea1d 61
e3b27b31
PE
62 Don't publish debugger-only interfaces to other modules.
63 * lisp.h (safe_debug_print, debug_output_compilation_hack):
64 (verify_bytepos, count_markers): Move decls to the only modules
65 that need them.
66 * region-cache.h (pp_cache): Likewise.
67 * window.h (check_all_windows): Likewise.
68 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
69
5d4cb038
PE
70 * sysdep.c (croak): Now static, if
71 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
72 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
73
74 * alloc.c (refill_memory_reserve): Now static if
75 !defined REL_ALLOC || defined SYSTEM_MALLOC.
76 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 77
e87b6180
PE
78 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
79 Define only if USE_LUCID.
80
ac64929e
PE
81 * xrdb.c (x_customization_string, x_rm_string): Now static.
82
6f37259d
PE
83 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
84 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
85
1683e3ab
PE
86 * xdisp.c (draw_row_with_mouse_face): Now static.
87 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
88
de9c2632
PE
89 * window.h (check_all_windows): Mark externally visible.
90
2b96acb7
PE
91 * window.c (window_deletion_count): Now static.
92
93 * undo.c: Make symbols static if they're not exported.
94 (last_undo_buffer, last_boundary_position, pending_boundary):
95 Now static.
96
50436f33
PE
97 * textprop.c (interval_insert_behind_hooks): Now static.
98 (interval_insert_in_front_hooks): Likewise.
99
64520e5c
PE
100 * term.c: Make symbols static if they're not exported.
101 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
102 (max_frame_lines, tty_set_terminal_modes):
103 (tty_reset_terminal_modes, tty_turn_off_highlight):
104 (get_tty_terminal): Now static.
105 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
106 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 107 HAVE_WINDOW_SYSTEM.
64520e5c
PE
108 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
109 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
110
1fa53021
PE
111 * sysdep.c: Make symbols static if they're not exported.
112 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
113 Now static.
114 (sigprocmask_set, full_mask): Remove; unused.
115 (wait_debugging): Mark as visible.
116 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
117 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
118
d4b43b22
PE
119 * syntax.c (syntax_temp): Define only if !__GNUC__.
120
b7c513d0
PE
121 * sound.c (current_sound_device, current_sound): Now static.
122
989b29ad
PE
123 * search.c (searchbufs, searchbuf_head): Now static.
124
13a55a78
PE
125 * scroll.c (scroll_cost): Remove; unused.
126 * dispextern.h (scroll_cost): Remove decl.
127
de68a1fc
PE
128 * region-cache.h (pp_cache): Mark as externally visible.
129
40ccffa6
PE
130 * process.c: Make symbols static if they're not exported.
131 (process_tick, update_tick, create_process, chan_process):
132 (Vprocess_alist, proc_buffered_char, datagram_access):
133 (fd_callback_data, send_process_frame, process_sent_to): Now static.
134 (deactivate_process): Mark defn as static, as well as decl.
135 * lisp.h (create_process): Remove decl.
136 * process.h (chan_process, Vprocess_alist): Remove decls.
137
ad64fc97
PE
138 * print.c: Make symbols static if they're not exported.
139 (print_depth, new_backquote_output, being_printed, print_buffer):
140 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
141 (print_interval, print_number_index, initial_stderr_stream):
142 Now static.
143 * lisp.h (Fprinc): Remove decl.
144 (debug_output_compilation_hack): Mark as externally visible.
145
adddb265
PE
146 * sysdep.c (croak): Move decl from here to syssignal.h.
147 * syssignal.h (croak): Put it here, so the API can be checked when
148 'croak' is called from dissociate_if_controlling_tty.
149
1717ede2
PE
150 * minibuf.c: Make symbols static if they're not exported.
151 (minibuf_save_list, choose_minibuf_frame): Now static.
152 * lisp.h (choose_minibuf_frame): Remove decl.
153
fa5fb2bc
PE
154 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
155
1e3890d1
PE
156 * lread.c: Make symbols static if they're not exported.
157 (read_objects, initial_obarray, oblookup_last_bucket_number):
158 Now static.
159 (make_symbol): Remove; unused.
160 * lisp.h (initial_obarray, make_symbol): Remove decls.
161
8a1414fa
PE
162 * keyboard.c: Make symbols static if they're not exported.
163 (single_kboard, recent_keys_index, total_keys, recent_keys):
164 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
165 (this_single_command_key_start, echoing, last_auto_save):
166 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
167 (command_loop, echo_now, keyboard_init_hook, help_char_p):
168 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
169 (Vlispy_mouse_stem, double_click_count):
170 Now static.
171 (force_auto_save_soon): Define only if SIGDANGER.
172 (ignore_mouse_drag_p): Now static if
173 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
174 (print_help): Remove; unused.
175 (stop_character, last_timer_event): Mark as externally visible.
176 * keyboard.h (ignore_mouse_drag_p): Declare only if
177 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
178 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
179 * lisp.h (echoing): Remove decl.
180 (force_auto_save_soon): Declare only if SIGDANGER.
181 * xdisp.c (redisplay_window): Simplify code, to make it more
182 obvious that ignore_mouse_drag_p is not accessed if !defined
183 USE_GTK && !defined HAVE_NS.
184
93ea6e8f
PE
185 * intervals.c: Make symbols static if they're not exported.
186 (merge_properties_sticky, merge_interval_right, delete_interval):
187 Now static.
188 * intervals.h (merge_interval_right, delete_interval): Remove decls.
189
77382fcc
PE
190 * insdel.c: Make symbols static if they're not exported.
191 However, leave prepare_to_modify_buffer alone. It's never
192 called from outside this function, but that appears to be a bug.
193 (combine_after_change_list, combine_after_change_buffer):
4889fc82 194 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
195 (adjust_after_replace_noundo): Remove; unused.
196 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 197 (signal_before_change): Remove decls.
77382fcc 198
9306c32e
PE
199 * indent.c (val_compute_motion, val_vmotion): Now static.
200
cd44d2eb
PE
201 * image.c: Make symbols static if they're not exported.
202 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
203 if USE_GTK.
204 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
205 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
206
ad9a7a06
PE
207 * fringe.c (standard_bitmaps): Now static.
208 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
209
81626931
PE
210 * frame.c: Make symbols static if they're not exported.
211 (x_report_frame_params, make_terminal_frame): Now static.
212 (get_frame_param): Now static, unless HAVE_NS.
213 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
214 (x_get_resource_string): Remove; not used.
215 * frame.h (make_terminal_frame, x_report_frame_params):
216 (x_get_resource_string); Remove decls.
217 (x_fullscreen_adjust): Declare only if WINDOWSNT.
218 * lisp.h (get_frame_param): Declare only if HAVE_NS.
219
239f9db9
PE
220 * font.c, fontset.c: Make symbols static if they're not exported.
221 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
222 (FACE_SUITABLE_FOR_CHAR_P): Use it.
223 * font.c (font_close_object): Now static.
224 * font.h (font_close_object): Remove.
225 * fontset.c (FONTSET_OBJLIST): Remove.
226 (free_realized_fontset) #if-0 the body, which does nothing.
227 (face_suitable_for_char_p): #if-0, as it's never called.
228 * fontset.h (face_suitable_for_char_p): Remove decl.
229 * xfaces.c (face_at_string_position): Use
230 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
231 since 0 is always ASCII.
232
dfcf3579
PE
233 * fns.c (weak_hash_tables): Now static.
234
5045092b
PE
235 * fileio.c: Make symbols static if they're not exported.
236 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
237 (Vwrite_region_annotation_buffers): Now static.
238
57a96f5c
PE
239 * eval.c: Make symbols static if they're not exported.
240 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
241 * lisp.h (backtrace_list): Remove decl.
242
35f08c38
PE
243 * emacs.c: Make symbols static if they're not exported.
244 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
245 (fatal_error_code, fatal_error_signal_hook, standard_args):
246 Now static.
247 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
248 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
249 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
250 * lisp.h (fatal_error_signal_hook): Remove decl.
251 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
252
f44bd759
PE
253 * editfns.c: Move a (normally-unused) function to its only use.
254 * editfns.c, lisp.h (get_operating_system_release): Remove.
255 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
256 worth the hassle of breaking this out.
257
b532497d
PE
258 * xterm.c: Make symbols static if they're not exported.
259 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
260 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
261 (x_destroy_window, x_delete_display):
262 Now static.
263 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
264 (x_mouse_leave): Remove; unused.
265 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
266 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
267 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
268 Remove decls.
269 (x_mouse_leave): Declare only if WINDOWSNT.
270 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
271 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
272 USE_X_TOOLKIT.
273
1675728f
PE
274 * ftxfont.c: Make symbols static if they're not exported.
275 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
276 HAVE_FREETYPE.
277 * font.h (ftxfont_driver): Likewise.
278
e4cebfca
PE
279 * xfns.c: Make symbols static if they're not exported.
280 (x_last_font_name, x_display_info_for_name):
281 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
282 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
283 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
284 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
285 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
286 (last_show_tip_args): Now static.
287 (xic_defaut_fontset, xic_create_fontsetname): Define only if
288 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
289 (x_screen_planes): Remove; unused.
290 * dispextern.h (x_screen_planes): Remove decl.
291
5bf46f05
PE
292 * dispnew.c: Make symbols static if they're not exported.
293 * dispextern.h (redraw_garbaged_frames, scrolling):
294 (increment_row_positions): Remove.
295 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
296 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
297 Now static.
298 (redraw_garbaged_frames): Remove; unused.
299
435f4c28
PE
300 * xfaces.c: Make symbols static if they're not exported.
301 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
302 Remove decls.
303 * xterm.h (defined_color): Remove decls.
304 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
305 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
306 (menu_face_changed_default, defined_color, free_realized_face):
307 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
308 (ascii_face_of_lisp_face): Remove; unused.
309
8524aef3
PE
310 * xdisp.c: Make symbols static if they're not exported.
311 * dispextern.h (scratch_glyph_row, window_box_edges):
312 (glyph_to_pixel_coords, set_cursor_from_row):
313 (get_next_display_element, set_iterator_to_next):
314 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
315 (show_mouse_face): Remove decls
316 * frame.h (message_buf_print): Likewise.
317 * lisp.h (pop_message, set_message, check_point_in_composition):
318 Likewise.
319 * xterm.h (set_vertical_scroll_bar): Likewise.
320 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
321 (message_buf_print, scratch_glyph_row, displayed_buffer):
322 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
323 (get_next_display_element, show_mouse_face, window_box_edges):
324 (frame_to_window_pixel_xy, check_point_in_composition):
325 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
326 (glyph_to_pixel_coords): Remove; unused.
327
16390cd2
PE
328 * dired.c (file_name_completion): Now static.
329
330 * dbusbind.c (xd_in_read_queued_messages): Now static.
331
a25f4dfa
PE
332 * lisp.h (circular_list_error, FOREACH): Remove; unused.
333 * data.c (circular_list_error): Remove.
334
14a9c8df
PE
335 * commands.h (last_point_position, last_point_position_buffer):
336 (last_point_position_window): Remove decls.
337 * keyboard.c: Make these variables static.
338
74ab6df5
PE
339 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
340 decls.
341 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
342 (iso_code_class, detect_coding, code_convert_region): Now static.
343 (encode_coding_gap): Remove; unused.
344
38dfbee1
PE
345 * chartab.c (chartab_chars, chartab_bits): Now static.
346
a2cb4e63
PE
347 * charset.h (charset_iso_8859_1): Remove decl.
348 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
349 Now static.
350
127198fd
PE
351 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
352 * ccl.c (Vccl_program_table): Now static.
353 (check_ccl_update): Remove; unused.
354
d85b608f
PE
355 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
356 * category.h: ... from here.
357 * category.c (check_category_table, set_category_set): Now static.
358
31cd66f3
PE
359 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
360 * lisp.h: Remove these decls.
361
c358e587
PE
362 * buffer.c (buffer_count): Remove unused var.
363
e78aecca
PE
364 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
365 so that it's not optimized away.
366 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
367 * dispextern.h (bidi_dump_cached_states): Remove, since it's
368 exported only to the debugger.
369
e192d7d3
PE
370 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
371 * atimer.h (run_all_atimers): Removed; not exported.
372
92470028
PE
373 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
374 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
375 was inaccessible from Lisp.
376 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
377 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
378
244ed907
PE
379 alloc.c: Import and export fewer symbols, and remove unused items.
380 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
381 is defined.
382 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
383 it's not optimized away by whole-program optimization.
384 (message_enable_multibyte, free_misc): Remove.
385 (catchlist, handlerlist, mark_backtrace):
386 Declare only if BYTE_MARK_STACK.
387 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
388 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
389 (message_enable_multibyte): Remove decl.
390 (free_misc, interval_free_list, float_block, float_block_index):
391 (n_float_blocks, float_free_list, cons_block, cons_block_index):
392 (cons_free_list, last_marked_index):
393 Now static.
394 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
395 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
396 (mark_backtrace): Define only if BYTE_MARK_STACK.
397 * xdisp.c (message_enable_multibyte): Now static.
398
955cbe7b
PE
399 Declare Lisp_Object Q* variables to be 'static' if not exproted.
400 This makes it easier for human readers (and static analyzers)
401 to see whether these variables are used from other modules.
402 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
403 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
404 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
405 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
406 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
407 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
408 * xmenu.c, xselect.c:
409 Declare Q* vars static if they are not used in other modules.
410 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
411 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
412 Remove decls of unexported vars.
413 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
414
95c82688
PE
415 * lisp.h (DEFINE_FUNC): Make sname 'static'.
416
16a97296
PE
417 Make Emacs functions such as Fatom 'static' by default.
418 This makes it easier for human readers (and static analyzers)
419 to see whether these functions can be called from other modules.
420 DEFUN now defines a static function. To make the function external
421 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
422 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
423 (Finit_image_library):
16a97296
PE
424 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
425 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
426 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
427 Remove decls, since these functions are now static.
428 (Funintern, Fget_internal_run_time): New decls, since these functions
429 were already external.
95c82688 430
16a97296
PE
431 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
432 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
433 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
434 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
435 * keyboard.c, keymap.c, lread.c:
436 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
437 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
438 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
439 Mark functions with DEFUE instead of DEFUN,
440 if they are used in other modules.
441 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
442 decls for now-static functions.
443 * buffer.h (Fdelete_overlay): Remove decl.
444 * callproc.c (Fgetenv_internal): Mark as internal.
445 * composite.c (Fremove_list_of_text_properties): Remove decl.
446 (Fcomposition_get_gstring): New forward static decl.
447 * composite.h (Fcomposite_get_gstring): Remove decl.
448 * dired.c (Ffile_attributes): New forward static decl.
449 * doc.c (Fdocumntation_property): New forward static decl.
450 * eval.c (Ffetch_bytecode): New forward static decl.
451 (Funintern): Remove extern decl; now in .h file where it belongs.
452 * fileio.c (Fmake_symbolic_link): New forward static decl.
453 * image.c (Finit_image_library): New forward static decl.
454 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
455 * intervals.h (Fprevious_property_change):
456 (Fremove_list_of_text_properties): Remove decls.
457 * keyboard.c (Fthis_command_keys): Remove decl.
458 (Fcommand_execute): New forward static decl.
459 * keymap.c (Flookup_key): New forward static decl.
460 (Fcopy_keymap): Now static.
461 * keymap.h (Flookup_key): Remove decl.
462 * process.c (Fget_process): New forward static decl.
463 (Fprocess_datagram_address): Mark as internal.
464 * syntax.c (Fsyntax_table_p): New forward static decl.
465 (skip_chars): Remove duplicate decl.
466 * textprop.c (Fprevious_property_change): New forward static decl.
467 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
468 Now internal.
469 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
470 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
471
785bbd42
PE
472 * editfns.c (Fformat): Remove unreachable code.
473
8b913b57
AS
4742011-04-14 Andreas Schwab <schwab@linux-m68k.org>
475
476 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
477 change. (Bug#8496)
478
a6744a35
EZ
4792011-04-13 Eli Zaretskii <eliz@gnu.org>
480
481 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
482 when at ZV. (Bug#8487)
483
e7974947
AS
4842011-04-12 Andreas Schwab <schwab@linux-m68k.org>
485
baad03f0
AS
486 * charset.c (Fclear_charset_maps): Use xfree instead of free.
487 (Bug#8437)
488 * keyboard.c (parse_tool_bar_item): Likewise.
489 * sound.c (sound_cleanup, alsa_close): Likewise.
490 * termcap.c (tgetent): Likewise.
491 * xfns.c (x_default_font_parameter): Likewise.
492 * xsettings.c (read_and_apply_settings): Likewise.
493
e7974947
AS
494 * alloc.c (overrun_check_malloc, overrun_check_realloc)
495 (overrun_check_free): Protoize.
496
28272684
PE
4972011-04-12 Paul Eggert <eggert@cs.ucla.edu>
498
499 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
500 since callers should never pass a negative size.
501 Change the signature to match that of plain 'read' and 'write'; see
502 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
503 * lisp.h: Update prototypes of emacs_write and emacs_read.
504
11997c76
EZ
5052011-04-11 Eli Zaretskii <eliz@gnu.org>
506
507 * xdisp.c (redisplay_window): Don't try to determine the character
508 position of the scroll margin if the window start point w->startp
e896f03c 509 is outside the buffer's accessible region. (Bug#8468)
11997c76 510
8a2cbd72
EZ
5112011-04-10 Eli Zaretskii <eliz@gnu.org>
512
513 Fix write-region and its subroutines for buffers > 2GB.
514 * fileio.c (a_write, e_write): Modify declaration of arguments and
515 local variables to support buffers larger than 2GB.
516 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
517
518 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
519 argument, local variables, and return value.
520
521 * lisp.h: Update prototypes of emacs_write and emacs_read.
522
523 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
524
4073e537 5252011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 526
1ebfdcb6
PE
527 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
528
b2ded58d
PE
529 Fix more problems found by GCC 4.6.0's static checks.
530
7d66342c
PE
531 * xdisp.c (vmessage): Use a better test for character truncation.
532
bbf47d44
PE
533 * charset.c (load_charset_map): <, not <=, for optimization,
534 and to avoid potential problems with integer overflow.
9248994d 535 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 536 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 537 * editfns.c (Fformat): Likewise.
1e69125e 538 * syntax.c (skip_chars): Likewise.
3befa583 539
e3019616
PE
540 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
541 This also lets GCC 4.6.0 generate slightly better loop code.
542
becfa255
PE
543 * callint.c (Fcall_interactively): <, not <=, for optimization.
544 (Fcall_interactively): Count the number of arguments produced,
545 not the number of arguments given. This is simpler and lets GCC
546 4.6.0 generate slightly better code.
547
dae0cd48
PE
548 * ftfont.c: Distingish more carefully between FcChar8 and char.
549 The previous code passed unsigned char * to a functions like
550 strlen and xstrcasecmp that expect char *, which does not
551 conform to the C standard.
552 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
553 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
554 char * when the C standard requires it.
555
76032d70
PE
556 * keyboard.c (read_char): Remove unused var.
557
eb3f1cc8
PE
558 * eval.c: Port to Windows vsnprintf (Bug#8435).
559 Include <limits.h>.
560 (SIZE_MAX): Define if the headers do not.
561 (verror): Do not give up if vsnprintf returns a negative count.
562 Instead, grow the buffer. This ports to Windows vsnprintf, which
563 does not conform to C99. Problem reported by Eli Zaretskii.
564 Also, simplify the allocation scheme, by avoiding the need for
565 calling realloc, and removing the ALLOCATED variable.
566
70476b54
PE
567 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
568
12020a9e
PE
569 Remove invocations of doprnt, as Emacs now uses vsnprintf.
570 But keep the doprint source code for now, as we might revamp it
571 and use it again (Bug#8435).
ea6c7ae6
PE
572 * lisp.h (doprnt): Remove.
573 * Makefile.in (base_obj): Remove doprnt.o.
574 * deps.mk (doprnt.o): Remove.
575
5fdb398c
PE
576 error: Print 32- and 64-bit integers portably (Bug#8435).
577 Without this change, on typical 64-bit hosts error ("...%d...", N)
578 was used to print both 32- and 64-bit integers N, which relied on
579 undefined behavior.
580 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
581 New macro.
582 * lisp.h (error, verror): Mark as printf-like functions.
583 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
584 Report overflow in size calculations when allocating printf buffer.
585 Do not truncate output string at its first null byte.
586 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
587 Truncate the output at a character boundary, since vsnprintf does not
588 do that.
589 * charset.c (check_iso_charset_parameter): Convert internal
590 character to string before calling 'error', since %c now has the
591 printf meaning.
592 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
593 overflow when computing char to be passed to 'error'. Do not
594 pass Lisp_Object to 'error'; pass the integer instead.
595 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
596 formatted with plain %d.
597
b189fa66
PE
598 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
599
bff87ef0
PE
600 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
601
7e2cac20
PE
602 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
603
ce4d90b5
PE
604 * xterm.c (x_catch_errors): Remove duplicate declaration.
605
266c9547
PE
606 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
607
79c49ad2
PE
608 * xdisp.c, lisp.h (message_nolog): Remove; unused.
609
368f4090
JM
6102011-04-10 Jim Meyering <meyering@redhat.com>
611
612 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
613 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
614 return ssize_t not "int", and use size_t as the buffer length.
615 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
616 * gnutls.h: Update declarations.
617 * process.c (read_process_output): Use ssize_t, to match.
618 (send_process): Likewise.
619
a32d4040
CY
6202011-04-09 Chong Yidong <cyd@stupidchicken.com>
621
622 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
623
8546720e 6242011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 625
8546720e
GM
626 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
627 unsigned char, to match FcChar8 type definition.
aac0c6e3 628
8546720e
GM
629 * xterm.c (handle_one_xevent):
630 * xmenu.c (create_and_show_popup_menu):
631 * xselect.c (x_decline_selection_request)
632 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 633
0a2f5c1a 6342011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
635
636 Fix some uses of `int' instead of EMACS_INT.
637 * search.c (string_match_1, fast_string_match)
638 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
639 (scan_buffer, find_next_newline_no_quit)
640 (find_before_next_newline, search_command, Freplace_match)
641 (Fmatch_data): Make some `int' variables be EMACS_INT.
642
643 * xdisp.c (display_count_lines): 3rd argument and return value now
644 EMACS_INT. All callers changed.
645 (pint2hrstr): Last argument is now EMACS_INT.
646
647 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
648 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
649 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
650 (decode_coding_utf_16, decode_coding_emacs_mule)
651 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
652 (decode_coding_ccl, decode_coding_charset)
653 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
654 (decode_coding_iso_2022, decode_coding_emacs_mule)
655 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
656 <char_offset, last_offset>: Declare EMACS_INT.
657 (encode_coding_utf_8, encode_coding_utf_16)
658 (encode_coding_emacs_mule, encode_invocation_designation)
659 (encode_designation_at_bol, encode_coding_iso_2022)
660 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
661 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
662 Declare EMACS_INT.
663 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
664 (encode_invocation_designation): Last argument P_NCHARS is now
665 EMACS_INT.
666 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
667 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
668
669 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
670 All users changed.
671
672 * ccl.c (Fccl_execute_on_string): Declare some variables
673 EMACS_INT.
674
8546720e 6752011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
676
677 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
678
4e19a977
CS
6792011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
680
681 * process.c (Fformat_network_address): Doc fix.
682
87302331
R
6832011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
684
685 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
686
cbb59342
CY
6872011-04-08 Chong Yidong <cyd@stupidchicken.com>
688
689 * keyboard.c (read_char): Call Lisp function help-form-show,
690 instead of using internal_with_output_to_temp_buffer.
691 (Qhelp_form_show): New var.
e0d38eeb 692 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
693
694 * print.c (internal_with_output_to_temp_buffer): Function deleted.
695
696 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
697
e67a13ab
CY
6982011-04-06 Chong Yidong <cyd@stupidchicken.com>
699
700 * process.c (Flist_processes): Removed to Lisp.
701 (list_processes_1): Deleted.
702
973f782d
EZ
7032011-04-06 Eli Zaretskii <eliz@gnu.org>
704
7c106b1e
EZ
705 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
706
973f782d
EZ
707 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
708
41cf7d1a 7092011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 710
ca23cc88
PE
711 Fix more problems found by GCC 4.6.0's static checks.
712
f390e2d5
PE
713 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
714
42eea0d0
PE
715 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
716
b69769da 717 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 718
f9541e84
PE
719 * xdisp.c (vmessage): Mark as a printf-like function.
720
13841b55
PE
721 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
722
c136c10f
PE
723 * sound.c (sound_warning): Don't crash if arg contains a printf format.
724
5e2d4a30
PE
725 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
726 printf-like functions.
727 (tiff_load): Add casts to remove these marks before passing them
728 to system-supplied API.
729
583f48b9
PE
730 * eval.c (Fsignal): Remove excess argument to 'fatal'.
731
b25d760e
PE
732 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
733 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
734 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
735 directly, rather than having caller test rule sign. This avoids
736 some unnecessary tests.
737 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
738 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
739 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 740
bc7b6697 741 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 742 (xfont_open): Avoid unnecessary tests.
bc7b6697 743
27ccc379
PE
744 * composite.c (composition_gstring_put_cache): Use unsigned integer.
745
dcd5c89a
PE
746 * composite.h, composite.c (composition_gstring_put_cache):
747 Use EMACS_INT, not int, for length.
748
b13a45c6
PE
749 * composite.h (COMPOSITION_DECODE_REFS): New macro,
750 breaking out part of COMPOSITION_DECODE_RULE.
751 (COMPOSITION_DECODE_RULE): Use it.
752 * composite.c (get_composition_id): Remove unused local vars,
753 by using the new macro.
754
1e792e4d
PE
755 * textprop.c (set_text_properties_1): Change while to do-while,
756 since the condition is always true at first.
757
dc6c6455 758 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
759 (interval_deletion_adjustment): Return unsigned value.
760 All uses changed.
dc6c6455 761
aba7731a
PE
762 * process.c (list_processes_1, create_pty, read_process_output):
763 (exec_sentinel): Remove vars that were set but not used.
afd4052b 764 (create_pty): Remove unnecessary "volatile"s.
bc57d757 765 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 766 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 767 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 768
fdfc4bf3
PE
769 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
770
fca8fe46 771 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 772 (update_syntax_table): Use unsigned instead of int.
fca8fe46 773
06a0259a 774 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 775 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 776 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 777
e7b9e80f
PE
778 * print.c (print_error_message): Avoid int overflow.
779
56201685
PE
780 * font.c (font_list_entities): Redo for clarity,
781 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
782
78834453 783 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 784 (font_score): Avoid potential overflow in diff calculation.
78834453 785
0bc0b309 786 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 787 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 788
e610eaca
PE
789 * eval.c (funcall_lambda): Rename local to avoid shadowing.
790
b895abce
PE
791 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
792 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
793 can always succeed if overflow has undefined behavior.
794
1f1d9321 795 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 796 (wordify): Omit three unnecessary tests.
1f1d9321 797
c59478bc
PE
798 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
799 All callers changed. This avoids the need for an unused var.
800
79b73827
PE
801 * casefiddle.c (casify_region): Remove var that is set but not used.
802
a4db5dfe
PE
803 * dired.c (file_name_completion): Remove var that is set but not used.
804
43aae36e
PE
805 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
806
2a47c44d 807 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 808 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 809
a37c69bf
PE
810 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
811 Check for integer overflow on size calculations.
812
328ab8e7
PE
813 * buffer.c (Fprevious_overlay_change): Remove var that is set
814 but not used.
815
e5a2a5cb
PE
816 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
817 Remove vars that are set but not used.
8d84a6eb 818 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 819 (timer_check_2): Mark vars as initialized.
e5a2a5cb 820
a60e5f68
PE
821 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
822
f661cb61 823 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 824 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 825
f0397f5a
PE
826 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
827 that are set but not used.
828
8664db06 829 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 830 if XCreateBitmapFromData fails (Bug#8410).
8664db06 831
6abdaa4a
PE
832 * xselect.c (x_get_local_selection, x_handle_property_notify):
833 Remove vars that are set but not used.
834
0ce7538d 835 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 836 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 837
9ae848fc
PE
838 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
839 Remove var that is set but not used.
0b918413
PE
840 (scroll_bar_windows_size): Now size_t, not int.
841 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
842 Check for overflow.
9ae848fc 843
a5a62657
PE
844 * xfaces.c (realize_named_face): Remove vars that are set but not used.
845 (map_tty_color) [!defined MSDOS]: Likewise.
846
5c5cdd39
PE
847 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
848
66ebf983
PE
849 * coding.c: Remove vars that are set but not used.
850 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
851 All callers changed.
852 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
853 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
854 (decode_coding_charset): Remove vars that are set but not used.
855
1be4d761
PE
856 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
857 that is set but not used.
858
47553fa8
PE
859 * print.c (print_object): Remove var that is set but not used.
860
1f7196bf 861 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
862 The gnulib version avoids calling malloc in the usual case,
863 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
864 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
865 * filelock.c (current_lock_owner): Likewise.
866 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
867 * sysdep.c: Include allocator.h, careadlinkat.h.
868 (emacs_no_realloc_allocator): New static constant.
869 (emacs_readlink): New function.
fdb61804
PE
870 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
871 ../lib/careadlinkat.h.
d1fdcab7 872
f84c17c7
SM
8732011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
874
875 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
876 first non-nil return value).
877
ef3862ad
JD
8782011-04-03 Jan Djärv <jan.h.d@swipnet.se>
879
880 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
881 if not defined (Bug#8403).
882
376a7006
JB
8832011-04-02 Juanma Barranquero <lekktu@gmail.com>
884
885 * xdisp.c (display_count_lines): Remove parameter `start',
886 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
887 (get_char_face_and_encoding): Remove parameter `multibyte_p',
888 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
889 (fill_stretch_glyph_string): Remove parameters `row' and `area',
890 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
891 and thereabouts. All callers changed.
892 (get_per_char_metric): Remove parameter `f', unused since
893 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
894
6ca3801d
JM
8952011-04-02 Jim Meyering <meyering@redhat.com>
896
897 do not dereference NULL upon failed strdup
898 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
899 (ns_get_family): Likewise.
900
d8e2b5ba
JB
9012011-04-02 Juanma Barranquero <lekktu@gmail.com>
902
903 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
904
8c74fcbd
JD
9052011-04-02 Jan Djärv <jan.h.d@swipnet.se>
906
907 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
908 later (Bug#8403).
909
7200d79c
SM
9102011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
911
03408648 912 Add lexical binding.
7200d79c 913
03408648
SM
914 * window.c (Ftemp_output_buffer_show): New fun.
915 (Fsave_window_excursion):
916 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
917
918 * lread.c (lisp_file_lexically_bound_p): New function.
919 (Fload): Bind Qlexical_binding.
920 (readevalloop): Remove `evalfun' arg.
921 Bind Qinternal_interpreter_environment.
922 (Feval_buffer): Bind Qlexical_binding.
923 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
924 Mark as dynamic.
925 (syms_of_lread): Declare `lexical-binding'.
926
927 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
928
929 * keyboard.c (eval_dyn): New fun.
930 (menu_item_eval_property): Use it.
ca105506
SM
931
932 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 933
03408648
SM
934 * fns.c (concat, mapcar1): Accept byte-code-functions.
935
936 * eval.c (Fsetq): Handle lexical vars.
937 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
938 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
939 (FletX, Flet): Obey lexical binding.
940 (Fcommandp): Handle closures.
941 (Feval): New `lexical' arg.
942 (eval_sub): New function extracted from Feval. Use it almost
943 everywhere where Feval was used. Look up vars in lexical env.
944 Handle closures.
945 (Ffunctionp): Move from subr.el.
946 (Ffuncall): Handle closures.
947 (apply_lambda): Remove `eval_flags'.
948 (funcall_lambda): Handle closures and new byte-code-functions.
949 (Fspecial_variable_p): New function.
950 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
951 but without exporting it to Lisp.
23aba0ea 952
23aba0ea 953 * doc.c (Fdocumentation, store_function_docstring):
03408648 954 * data.c (Finteractive_form): Handle closures.
23aba0ea 955
03408648
SM
956 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
957 interactive spec.
ba83908c 958
03408648
SM
959 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
960 byte-codes.
961 (exec_byte_code): New function extracted from Fbyte_code to handle new
962 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 963
03408648 964 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 965
03408648 966 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 967
e2abce01
JB
9682011-03-31 Juanma Barranquero <lekktu@gmail.com>
969
970 * xdisp.c (redisplay_internal): Fix prototype.
971
63696a73 9722011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 973
63696a73
EZ
974 * xdisp.c (SCROLL_LIMIT): New macro.
975 (try_scrolling): Use it when setting scroll_limit. Limit
976 scrolling to 100 screen lines.
977 (redisplay_window): Even when falling back on "recentering",
978 position point in the window according to scroll-conservatively,
979 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
980
981 (try_scrolling): When point is above the window, allow searching
982 as far as scroll_max, or one screenful, to compute vertical
983 distance from PT to the scroll margin position. This prevents
984 try_scrolling from unnecessarily failing when
985 scroll-conservatively is set to a value slightly larger than the
986 window height. Clean up the case of PT below the margin at bottom
987 of window: scroll_max can no longer be INT_MAX. When aggressive
988 scrolling is in use, don't let point enter the opposite scroll
989 margin as result of the scroll.
990 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
991 threshold of 100 lines for never-recentering scrolling.
992
e4cc2dfc
JB
9932011-03-31 Juanma Barranquero <lekktu@gmail.com>
994
995 * dispextern.h (move_it_by_lines):
996 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
997 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
998 (message_log_check_duplicate): Remove parameters `prev_bol' and
999 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1000 (redisplay_internal): Remove parameter `preserve_echo_area',
1001 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
1002
1003 * indent.c (Fvertical_motion):
1004 * window.c (window_scroll_pixel_based, Frecenter):
1005 Don't pass `need_y_p' to `move_it_by_lines'.
1006
1c470562
SM
10072011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
1008
44f230aa
SM
1009 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
1010 steal a few bits to be more compact.
1011 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
1012 Remove unneeded casts.
1013
1c470562
SM
1014 * bytecode.c (Fbyte_code): CAR and CDR can GC.
1015
888adce9
ZK
10162011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
1017
1018 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
1019 binding" message (bug#7967).
1020
f838ed7b
PE
10212011-03-30 Paul Eggert <eggert@cs.ucla.edu>
1022
77861b95
PE
1023 Fix more problems found by GCC 4.6.0's static checks.
1024
de6dbc14
PE
1025 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
1026 Remove unused local var.
1027
f838ed7b
PE
1028 * editfns.c (Fmessage_box): Remove unused local var.
1029
792c7b2b
PE
1030 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
1031 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1032 Omit unused local vars.
c499e557 1033 * window.c (shrink_windows): Omit unused local var.
b01a1c29 1034 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
1035 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
1036 Omit unused local var.
1037
ba0165e1
PE
1038 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
1039 Don't assume string length fits in int.
32ad8845 1040 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 1041 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 1042
3c59b4c9
PE
1043 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
1044 instead of alloca (Bug#8344).
1045
a3eed478 1046 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 1047 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 1048
eb4d412d
PE
1049 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
1050
1658b401
PE
1051 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
1052 concerns.
1053
1054 * term.c (produce_glyphless_glyph): Remove unnecessary test.
1055
1056 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 1057
9a2c6e05
PE
1058 * keyboard.c (syms_of_keyboard): Use the same style as later
1059 in this function when indexing through an array. This also
1060 works around GCC bug 48267.
1061
03d0a109
PE
1062 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
1063
44f730c8
PE
1064 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
1065
fe75f926
PE
1066 * chartab.c (sub_char_table_ref_and_range): Redo for slight
1067 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
1068
ffa8c828
PE
1069 * keyboard.c, keyboard.h (num_input_events): Now size_t.
1070 This avoids undefined behavior on integer overflow, and is a bit
1071 more convenient anyway since it is compared to a size_t variable.
1072
c5101a77
PE
1073 Variadic C functions now count arguments with size_t, not int.
1074 This avoids an unnecessary limitation on 64-bit machines, which
1075 caused (substring ...) to crash on large vectors (Bug#8344).
1076 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
1077 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 1078 All variadic functions and their callers changed accordingly.
c5101a77
PE
1079 (struct gcpro.nvars): Now size_t, not int. All uses changed.
1080 * data.c (arith_driver, float_arith_driver): Likewise.
1081 * editfns.c (general_insert_function): Likewise.
1082 * eval.c (struct backtrace.nargs, interactive_p)
1083 (internal_condition_case_n, run_hook_with_args, apply_lambda)
1084 (funcall_lambda, mark_backtrace): Likewise.
1085 * fns.c (concat): Likewise.
1086 * frame.c (x_set_frame_parameters): Likewise.
1087 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
1088 0 if not found, not -1. All callers changed.
1089
dd3f25f7
PE
1090 * alloc.c (garbage_collect): Don't assume stack size fits in int.
1091 (stack_copy_size): Now size_t, not int.
1092 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
1093
461c2ab9
JB
10942011-03-28 Juanma Barranquero <lekktu@gmail.com>
1095
1096 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
1097 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1098 All callers changed.
1099
1100 * lisp.h (multibyte_char_to_unibyte):
1101 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
1102 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1103 * character.h (CHAR_TO_BYTE8):
1104 * cmds.c (internal_self_insert):
1105 * editfns.c (general_insert_function):
1106 * keymap.c (push_key_description):
1107 * search.c (Freplace_match):
1108 * xdisp.c (message_dolog, set_message_1): All callers changed.
1109
f6d62986
SM
11102011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1111
1112 * keyboard.c (safe_run_hook_funcall): New function.
1113 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
1114 don't set the hook to nil, but remove the offending function instead.
1115 (Qcommand_hook_internal): Remove, unused.
1116 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
1117 Vcommand_hook_internal.
1118
1119 * eval.c (enum run_hooks_condition): Remove.
1120 (funcall_nil, funcall_not): New functions.
1121 (run_hook_with_args): Call each function through a `funcall' argument.
1122 Remove `cond' argument, now redundant.
1123 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
1124 (Frun_hook_with_args_until_failure): Adjust accordingly.
1125 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
1126
1db5b1ad
JB
11272011-03-28 Juanma Barranquero <lekktu@gmail.com>
1128
1129 * dispextern.h (string_buffer_position): Remove declaration.
1130
1131 * print.c (strout): Remove parameter `multibyte', unused since
1132 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
1133
1134 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
1135 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
1136 All callers changed.
1137
1138 * w32.c (_wsa_errlist): Use braces for struct initializers.
1139
1140 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
1141 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
1142 All callers changed.
1143 (string_buffer_position): Likewise. Also, make static (it's never
1144 used outside xdisp.c).
1145 (cursor_row_p): Remove parameter `w', unused since
1146 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
1147 (decode_mode_spec): Remove parameter `precision', introduced during
1148 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
1149 All callers changed.
1150
5ffb62aa
JD
11512011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1152
1153 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
1154
461c2ab9 11552011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
1156
1157 * nsterm.m (ns_menu_bar_is_hidden): New variable.
1158 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
1159 (ns_update_auto_hide_menu_bar): New functions.
1160 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
1161 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
1162 ns_constrain_all_frames.
1163 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
1164 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
1165
5c380ffb
JD
11662011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1167
1168 * nsmenu.m (runDialogAt): Remove argument to timer_check.
1169
9af30bdf
GM
11702011-03-27 Glenn Morris <rgm@gnu.org>
1171
1172 * syssignal.h: Replace RETSIGTYPE with void.
1173 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
1174 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
1175 Replace SIGTYPE with void everywhere.
1176 * s/usg5-4-common.h (SIGTYPE): Remove definition.
1177 * s/template.h (SIGTYPE): Remove commented out definition.
1178
e2abce01
JB
11792011-03-26 Eli Zaretskii <eliz@gnu.org>
1180
1181 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
1182 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
1183
f868cd8a
JB
11842011-03-26 Juanma Barranquero <lekktu@gmail.com>
1185
59eb0929
JB
1186 * w32.c (read_unc_volume): Use parameter `henum', instead of
1187 global variable `wget_enum_handle'.
1188
1189 * keymap.c (describe_vector): Remove parameters `indices' and
1190 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
1191 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
1192
f868cd8a
JB
1193 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
1194
1195 * keyboard.c (timer_check): Remove parameter `do_it_now',
1196 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
1197 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
1198 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
1199
1200 * keyboard.c (read_char):
1201 * w32menu.c (w32_menu_display_help):
1202 * xmenu.c (show_help_event, menu_help_callback):
1203 Adjust calls to `show_help_echo'.
1204
1205 * gtkutil.c (xg_maybe_add_timer):
1206 * keyboard.c (readable_events):
1207 * process.c (wait_reading_process_output):
1208 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
1209
1210 * insdel.c (adjust_markers_gap_motion):
1211 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
1212 (gap_left, gap_right): Don't call it.
1213
2ecf6fdb
CY
12142011-03-25 Chong Yidong <cyd@stupidchicken.com>
1215
1216 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
1217 incurred during fontification.
1218
6b1f9ba4
JB
12192011-03-25 Juanma Barranquero <lekktu@gmail.com>
1220
1221 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
1222 (DEFVAR_PER_BUFFER): Don't pass it.
1223
1224 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
1225 (scrolling_window): Don't pass it.
1226
0f4a96b5
JB
12272011-03-25 Juanma Barranquero <lekktu@gmail.com>
1228
1229 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
1230
1231 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
1232 and `suffix'.
1233 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
1234 of variables specific to SELinux and computation of `encoded_absname'.
1235
1236 * image.c (XPutPixel): Remove unused variable `height'.
1237
1238 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
1239
1240 * unexw32.c (get_section_info): Remove unused variable `section'.
1241
1242 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
1243 (system_process_attributes): Remove unused variable `sess'.
1244 (sys_read): Remove unused variable `err'.
1245
1246 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
1247 (w32_wnd_proc): Remove unused variable `isdead'.
1248 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
1249 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
1250 (x_create_tip_frame): Remove unused variable `tem'.
1251
1252 * w32inevt.c (w32_console_read_socket):
1253 Remove unused variable `no_events'.
1254
1255 * w32term.c (x_draw_composite_glyph_string_foreground):
1256 Remove unused variable `width'.
1257
1149507c
JB
12582011-03-24 Juanma Barranquero <lekktu@gmail.com>
1259
1260 * w32term.c (x_set_glyph_string_clipping):
1261 Don't pass uninitialized region to CombineRgn.
1262
9c88f339
JB
12632011-03-23 Juanma Barranquero <lekktu@gmail.com>
1264
1265 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
1266 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
1267 (Fx_close_connection): Remove unused variable `i'.
1268
1269 * w32font.c (w32font_draw): Return number of glyphs.
1270 (w32font_open_internal): Remove unused variable `i'.
1271 (w32font_driver): Add missing initializer.
1272
1273 * w32menu.c (utf8to16): Remove unused variable `utf16'.
1274 (fill_in_menu): Remove unused variable `items_added'.
1275
1276 * w32term.c (last_mouse_press_frame): Remove static global variable.
1277 (w32_clip_to_row): Remove unused variable `f'.
1278 (x_delete_terminal): Remove unused variable `i'.
1279
1280 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
1281 (NOTHING): Remove unused static global variable.
1282 (uniscribe_check_otf): Remove unused variable `table'.
1283 (uniscribe_font_driver): Add missing initializers.
1284
dee091a3
JD
12852011-03-23 Julien Danjou <julien@danjou.info>
1286
1287 * term.c (Fsuspend_tty, Fresume_tty):
1288 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
1289 * window.c (temp_output_buffer_show):
1290 * insdel.c (signal_before_change):
1291 * frame.c (Fhandle_switch_frame):
1292 * fileio.c (Fdo_auto_save):
1293 * emacs.c (Fkill_emacs):
1294 * editfns.c (save_excursion_restore):
1295 * cmds.c (internal_self_insert):
1296 * callint.c (Fcall_interactively):
1297 * buffer.c (Fkill_all_local_variables):
1298 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
1299 Use Frun_hooks.
0f4a96b5 1300 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
1301 unconditionnaly since it does the check itself.
1302
2c520ab5 13032011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 1304
c9c49752
PE
1305 Fix more problems found by GCC 4.5.2's static checks.
1306
8abc3f12
PE
1307 * coding.c (encode_coding_raw_text): Avoid unnecessary test
1308 the first time through the loop, since we know p0 < p1 then.
1309 This also avoids a gcc -Wstrict-overflow warning.
1310
a2d26660
PE
1311 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
1312 leading to a memory leak, possible in functions like
1313 load_charset_map_from_file that can allocate an unbounded number
b12ef411 1314 of objects (Bug#8318).
a2d26660 1315
916c72e9
PE
1316 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
1317 that could (at least in theory) be that large.
1318
19ab8a18
PE
1319 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
1320 This is less likely to overflow, and avoids undefined behavior if
1321 overflow does occur. All callers changed. Use strtoul to scan
1322 for the unsigned long integer.
b7cbbd6f
PE
1323 (pint2hrstr): Simplify and tune code slightly.
1324 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 1325
f0641eff
PE
1326 * scroll.c (do_scrolling): Work around GCC bug 48228.
1327 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
1328
7f650bb9
PE
1329 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
1330 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
1331 (validate_x_resource_name): Simplify count usage.
1332 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 1333
37dd57d1
PE
1334 * fileio.c (Fcopy_file): Report error if fchown or fchmod
1335 fail (Bug#8306).
81e56e61 1336
699979fc 1337 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 1338
401bf9b4
PE
1339 * process.c (Fmake_network_process): Use socklen_t, not int,
1340 where POSIX says socklen_t is required in portable programs.
1341 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 1342 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
1343 (Fmake_network_process, server_accept_connection):
1344 (wait_reading_process_output, read_process_output):
1345 Likewise.
1346
b93aacde
PE
1347 * process.c: Rename or move locals to avoid shadowing.
1348 (list_processes_1, Fmake_network_process):
1349 (read_process_output_error_handler, exec_sentinel_error_handler):
1350 Rename or move locals.
4dc343ee 1351 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 1352 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 1353 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 1354 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 1355 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 1356
af8a867c 1357 Make tparam.h and terminfo.c consistent.
44f230aa
SM
1358 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
1359 Include tparam.h instead, since it declares them.
af8a867c
PE
1360 * cm.h (PC): Remove extern decl; tparam.h now does this.
1361 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
1362 * terminfo.c: Include tparam.h, to check interfaces.
1363 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
1364 (tparam): Adjust signature to match interface in tparam.h;
1365 this removes some undefined behavior. Check that outstring and len
1366 are zero, which they always are with Emacs.
1367 * tparam.h (PC, BC, UP): New extern decls.
1368
0248044d 1369 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 1370 (xftfont_open): Rename locals to avoid shadowing.
0248044d 1371
8ff096c1 1372 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
1373 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
1374 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 1375 (ftfont_list): Remove unused local.
49eaafba
PE
1376 (get_adstyle_property, ftfont_pattern_entity):
1377 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
1378 Rename locals to avoid shadowing.
8ff096c1 1379
e2be39f6
PE
1380 * xfont.c (xfont_list_family): Mark var as initialized.
1381
c9735e30
PE
1382 * xml.c (make_dom): Now static.
1383
8f5201ae
PE
1384 * composite.c (composition_compute_stop_pos): Rename local to
1385 avoid shadowing.
b246f932
PE
1386 (composition_reseat_it): Remove unused locals.
1387 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 1388 (composition_update_it): Mark var as initialized.
11b61122
PE
1389 (find_automatic_composition): Mark vars as initialized,
1390 with a FIXME (Bug#8290).
8f5201ae 1391
760fbc2c
PE
1392 character.h: Rename locals to avoid shadowing.
1393 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
1394 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
1395 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
1396 (BUF_DEC_POS): Be more systematic about renaming local temporaries
1397 to avoid shadowing.
1398
ff08eb85
PE
1399 * textprop.c (property_change_between_p): Remove; unused.
1400
fc7bf025
PE
1401 * intervals.c (interval_start_pos): Now static.
1402
235d7abc
PE
1403 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
1404
44f230aa
SM
1405 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
1406 Rename locals to avoid shadowing.
3e7d6594 1407
50060332
PE
1408 * sound.c (wav_play, au_play, Fplay_sound_internal):
1409 Fix pointer signedness.
d01f234b 1410 (alsa_choose_format): Remove unused local var.
c83b8872
PE
1411 (wav_play): Initialize a variable to 0, to prevent undefined
1412 behavior (Bug#8278).
50060332 1413
c4fc4e30
PE
1414 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
1415
918436ed
PE
1416 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
1417
c939f91b
PE
1418 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
1419 clobbering (Bug#8298).
b9c7f648
PE
1420 * sysdep.c (sys_subshell): Likewise.
1421 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 1422
6bd8c144
PE
1423 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
1424 This should get cleaned up, so that child_setup has the
1425 same signature on all platforms.
1426
7710357c 1427 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 1428 (relocate_fd): Rename locals to avoid shadowing.
7710357c 1429
c59da222
CY
14302011-03-22 Chong Yidong <cyd@stupidchicken.com>
1431
1432 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
1433 not to be necessary, and produces flickering.
1434
66b87493
GM
14352011-03-20 Glenn Morris <rgm@gnu.org>
1436
1437 * config.in: Remove file.
1438
45b6f6d5
JB
14392011-03-20 Juanma Barranquero <lekktu@gmail.com>
1440
1441 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
1442 are now in src/globals.h.
1443 (syms_of_minibuf): Remove spurious & from previous change.
1444
3ec03f7e
LL
14452011-03-20 Leo <sdl.web@gmail.com>
1446
1447 * minibuf.c (completing-read-function): New variable.
1448 (completing-read-default): Rename from completing-read.
1449 (completing-read): Call completing-read-function.
1450
b14e3e21
CY
14512011-03-19 Juanma Barranquero <lekktu@gmail.com>
1452
1453 * xfaces.c (Fx_load_color_file):
1454 Read color file from absolute filename (bug#8250).
1455
f2b726e6
JB
14562011-03-19 Juanma Barranquero <lekktu@gmail.com>
1457
1458 * makefile.w32-in: Update dependencies.
1459
09f6ff02
EZ
14602011-03-17 Eli Zaretskii <eliz@gnu.org>
1461
1462 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
1463
29a6015a
PE
14642011-03-17 Paul Eggert <eggert@cs.ucla.edu>
1465
a3a6c54e
PE
1466 Fix more problems found by GCC 4.5.2's static checks.
1467
b766f867
PE
1468 * process.c (make_serial_process_unwind, send_process_trap):
1469 (sigchld_handler): Now static.
1470
be02381c
PE
1471 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
1472 That way, the code declares only the vars that it needs.
1473 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
1474 * s/cygwin.h (PTY_ITERATION): Likewise.
1475 * s/darwin.h (PTY_ITERATION): Likewise.
1476 * s/gnu-linux.h (PTY_ITERATION): Likewise.
1477
57048744
PE
1478 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
1479 * process.c (allocate_pty): Don't declare stb unless it's needed.
1480
7914961c 1481 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
1482 (CONSTANTLIM): Remove; unused.
1483 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
1484 Define only if needed.
7914961c 1485
b3967b18
PE
1486 * unexelf.c (unexec): Name an expression,
1487 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
1488 Use a different way to cause a compilation error if anyone uses
1489 n rather than nn, a way that does not involve shadowing.
73366a00 1490 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 1491
29a6015a
PE
1492 * deps.mk (unexalpha.o): Remove; unused.
1493
43cfc33e 1494 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 1495 * unexec.h: New file.
ce701a33
PE
1496 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
1497 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
1498 Depend on unexec.h.
1499 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
1500 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
1501 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 1502 Change as necessary to match prototype in unexec.h.
ce701a33 1503
01f44d5a
PE
1504 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
1505 shadowing.
4f63c6bb 1506 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 1507
a6670b0b
PE
1508 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
1509 Rename locals to avoid shadowing.
1510
cef2010d 1511 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 1512 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 1513
d4d7173a
PE
1514 * print.c (Fredirect_debugging_output): Fix pointer signedess.
1515
f08b802a
PE
1516 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
1517 warning when compiling print.c.
1518
3ddb0639
PE
1519 * font.c (font_unparse_fcname): Abort in an "impossible" situation
1520 instead of using an uninitialized var.
5ad03b97 1521 (font_sort_entities): Mark var as initialized.
3ddb0639 1522
170a2692
PE
1523 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
1524
e663c700
PE
1525 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
1526 pointers to constants.
89bc529a 1527 (font_parse_fcname): Remove unused vars.
7b81e2d0 1528 (font_delete_unmatched): Now static.
ea838e10 1529 (font_get_spec): Remove; unused.
13a547c6
PE
1530 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
1531 (font_update_drivers, Ffont_get_glyphs, font_add_log):
1532 Rename or move locals to avoid shadowing.
e663c700 1533
2a80c887 1534 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 1535 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 1536
1384fa33 1537 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 1538 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 1539
8b2c52e9
PE
1540 * alloc.c (mark_backtrace): Move decl from here ...
1541 * lisp.h: ... to here, so that it can be checked.
1542
475545b5 1543 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 1544 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
1545 (lisp_indirect_variable): Name an expression,
1546 to avoid gcc -Wbad-function-cast warning.
1faed8ae 1547 (Fdefvar): Rename locals to avoid shadowing.
475545b5 1548
b1349114 1549 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 1550 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 1551 Use const pointer when appropriate.
b1349114 1552
a2928364
PE
1553 * lisp.h (get_system_name, get_operating_system_release):
1554 Move decls here, to check interfaces.
1555 * process.c (get_operating_system_release): Move decl to lisp.h.
1556 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
1557 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
1558 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
1559 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
1560 (Fformat_time_string, Fencode_time, Finsert_char):
1561 (Ftranslate_region_internal, Fformat):
1562 Rename or remove local vars to avoid shadowing.
9710023e 1563 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 1564
a415e694
PE
1565 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
1566 avoid shadowing.
1567
8ef4622d
PE
1568 * lisp.h (eassert): Check that the argument compiles, even if
1569 ENABLE_CHECKING is not defined.
1570
946f9a5b
PE
1571 * data.c (Findirect_variable): Name an expression, to avoid
1572 gcc -Wbad-function-cast warning.
112396d6 1573 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 1574 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
1575 (Fmake_variable_buffer_local, Fmake_local_variable):
1576 Mark variables as initialized.
52746918 1577 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 1578
e5aab7e7 1579 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
1580 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
1581 Rename locals to avoid shadowing.
dff45157
PE
1582 (mark_stack): Move local variables into the #ifdef region where
1583 they're used.
7bc26fdb
PE
1584 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
1585 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
1586 needed otherwise.
1587 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
1588 (GC_STRING_CHARS): Remove; not used.
d40d4be1 1589 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 1590
e5aab7e7
PE
1591 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
1592 avoids undefined behavior in theory.
1593
4da60324
PE
1594 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
1595
88043301
PE
1596 Use functions, not macros, for up- and down-casing (Bug#8254).
1597 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1598 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
1599 to use the following functions instead of these macros.
1600 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
1601 EMACS_INT, since callers assume the returned value fits in int.
1602 (upcase1): Likewise, for UPCASE_TABLE.
1603 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 1604 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 1605 the race-condition problem in the old DOWNCASE.
88043301 1606
19ed5445
PE
1607 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
1608 Rename locals to avoid shadowing.
1609 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
1610 (regex_compile, re_search_2, re_match_2_internal):
1611 Remove unused local vars.
952db0d7
PE
1612 (FREE_VAR): Rewrite so as not to use empty "else",
1613 which gcc can warn about.
da053e48 1614 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
1615 (RETALLOC_IF): Define only if needed.
1616 (WORDCHAR_P): Likewise. This one is never needed, but is used
1617 only in a comment talking about a compiler bug, so put inside
1618 the #if 0 of that comment.
1619 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
1620 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
1621 Remove; unused.
19ed5445 1622
1f3561e4 1623 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
1624 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
1625 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 1626
ded6f8f7
PE
1627 * search.c (simple_search): Remove unused var.
1628
dbd37a95
PE
1629 * dired.c (compile_pattern): Move decl from here ...
1630 * lisp.h: ... to here, so that it can be checked.
1631 (struct re_registers): New forward decl.
1632
7e47afad
PE
1633 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
1634
85f24f61
PE
1635 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
1636 All uses changed.
1637 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
1638 Rename locals to avoid shadowing.
5671df8f 1639 (Fvertical_motion): Mark locals as initialized.
85f24f61 1640
181aa2be 1641 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 1642 (casify_region): Mark local as initialized.
181aa2be 1643
930d429c
PE
1644 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
1645
7082eac6
PE
1646 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
1647 New macros, so that the caller can use some names other than
1648 gcpro1, gcpro2, etc.
1649 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
1650 of the new macros.
1651 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
1652 argument, for consistency with GCPRO2_VAR, etc: it is now the
1653 prefix of the variable, not the variable itself. All uses
1654 changed.
38b2c076
PE
1655 * dired.c (directory_files_internal, file_name_completion):
1656 Rename locals to avoid shadowing.
1657
15206ed9
PE
1658 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
1659 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
1660 dired.c's scmp function, had undefined behavior.
1661 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1662 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
1663 * buffer.h: ... to here, because these macros use current_buffer,
1664 and the new implementation with inline functions needs to have
1665 current_buffer in scope now, rather than later when the macros
1666 are used.
1667 (downcase, upcase1): New static inline functions.
1668 (DOWNCASE, UPCASE1): Reimplement using these functions.
1669 This avoids undefined behavior in expressions like
1670 DOWNCASE (x) == DOWNCASE (y), which previously suffered
1671 from race conditions in accessing the global variables
1672 case_temp1 and case_temp2.
1673 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
1674 * lisp.h (case_temp1, case_temp2): Remove their decls.
1675 * character.h (ASCII_CHAR_P): Move from here ...
1676 * lisp.h: ... to here, so that the inline functions mentioned
1677 above can use them.
1678
4a6bea26
PE
1679 * dired.c (directory_files_internal_unwind): Now static.
1680
f14b7e14
PE
1681 * fileio.c (file_name_as_directory, directory_file_name):
1682 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
1683 Now static.
2893f146
PE
1684 (file_name_as_directory): Use const pointers when appropriate.
1685 (Fexpand_file_name): Likewise. In particular, newdir might
1686 point at constant storage, so make it a const pointer.
fd4ead52 1687 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
1688 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
1689 signedness issues.
f839df0c
PE
1690 (Fset_file_times, Finsert_file_contents, auto_save_error):
1691 Rename locals to avoid shadowing.
f14b7e14 1692
5716756e 1693 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
1694 (Ftry_completion, Fall_completions): Rename or remove locals
1695 to avoid shadowing.
5716756e 1696
b4c3046a
PE
1697 * marker.c (bytepos_to_charpos): Remove; unused.
1698
b45db522
PE
1699 * lisp.h (verify_bytepos, count_markers): New decls,
1700 so that gcc does not warn that these functions aren't declared.
1701
85876d07
PE
1702 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
1703 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 1704 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 1705 (copy_text): Remove unused local var.
85876d07 1706
03d78a21 1707 * filelock.c (within_one_second): Now static.
b3dd38ab 1708 (lock_file_1): Rename local to avoid shadowing.
03d78a21 1709
5df8f01b
PE
1710 * buffer.c (fix_overlays_before): Mark locals as initialized.
1711 (fix_start_end_in_overlays): Likewise. This function should be
1712 simplified by using pointers-to-pointers, but that's a different
1713 matter.
b1d876f1 1714 (switch_to_buffer_1): Now static.
8f54f30a
PE
1715 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
1716 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 1717
a70072c9 1718 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 1719 Fix pointer signedness issue.
edced198
PE
1720 (sys_subshell): Mark local as volatile if checking for lint,
1721 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 1722 (MAXPATHLEN): Define only if needed.
a70072c9 1723
a0977c44
PE
1724 * process.c (serial_open, serial_configure): Move decls from here ...
1725 * systty.h: ... to here, so that they can be checked.
1726
a884fdcc
PE
1727 * fns.c (get_random, seed_random): Move extern decls from here ...
1728 * lisp.h: ... to here, so that they can be checked.
1729
604efe86 1730 * sysdep.c (reset_io): Now static.
b8950c94 1731 (wait_for_termination_signal): Remove; unused.
604efe86 1732
38fc62d9
PE
1733 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
1734 (copy_keymap_item, append_key, push_text_char_description):
1735 Now static.
1004a21a 1736 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 1737 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
1738 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
1739 (describe_map_tree):
1740 Rename locals to avoid shadowing.
38fc62d9 1741
2f2650da
PE
1742 * keyboard.c: Declare functions static if they are not used elsewhere.
1743 (echo_char, echo_dash, cmd_error, top_level_2):
1744 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
1745 (read_char, kbd_buffer_get_event, make_lispy_position):
1746 (make_lispy_event, make_lispy_movement, apply_modifiers):
1747 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
1748 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
1749 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 1750 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 1751 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 1752
a053e86c 1753 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
1754 (mark_kboards): Move decl here ...
1755 * alloc.c (mark_kboards): ... from here.
a053e86c 1756
4752793e
PE
1757 * lisp.h (force_auto_save_soon): New decl.
1758
74f10ca7 1759 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
1760 (DEFINE_DUMMY_FUNCTION): New macro.
1761 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
1762 Use it.
c03cd23f
PE
1763 (main): Add casts to avoid warnings
1764 if GCC considers string literals to be constants.
74f10ca7 1765
022e70d4
PE
1766 * lisp.h (fatal_error_signal): Add decl, since it's exported.
1767
59d6fe83
PE
1768 * dbusbind.c: Pointer signedness fixes.
1769 (xd_signature, xd_append_arg, xd_initialize):
1770 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1771 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1772 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
1773 (Fdbus_register_signal): Use SSDATA when the context wants char *.
1774
78320123
PE
1775 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
1776 if GCC considers string literals to be constants.
49cebcca 1777 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 1778
35ac2a97
SM
17792011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
1780
fb103ca9
SM
1781 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
1782 (print_preprocess, print_object): New macro to fix last change.
1783
35ac2a97
SM
1784 * print.c (print_preprocess): Don't forget font objects.
1785
62973b41
JB
17862011-03-16 Juanma Barranquero <lekktu@gmail.com>
1787
1788 * emacs.c (USAGE3): Doc fixes.
1789
0e48bb22
AS
17902011-03-15 Andreas Schwab <schwab@linux-m68k.org>
1791
1792 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
1793 structure.
1794
7684e57b
JB
17952011-03-14 Juanma Barranquero <lekktu@gmail.com>
1796
1797 * lisp.h (VWindow_system, Qfile_name_history):
1798 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
1799 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
1800 (w32_system_caret_x, w32_system_caret_y): Declare extern.
1801
1802 * w32select.c: Don't #include "keyboard.h".
c96bbc66 1803 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
1804
1805 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
1806 * w32console.c (detect_input_pending, read_input_pending)
1807 (encode_terminal_code):
1808 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
1809 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
1810 (w32_system_caret_y, Qfile_name_history):
1811 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
1812 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
1813 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
1814 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
1815 * w32proc.c (Qlocal, report_file_error):
1816 * w32term.c (Vwindow_system, updating_frame):
1817 * w32uniscribe.c (initialized, uniscribe_font_driver):
1818 Remove unneeded extern declarations.
1819
2aa46d6c
CY
18202011-03-14 Chong Yidong <cyd@stupidchicken.com>
1821
c96bbc66 1822 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 1823
cffc6f3b
CY
18242011-03-13 Chong Yidong <cyd@stupidchicken.com>
1825
1826 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
1827 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
1828 These macros can no longer be used for assignment.
1829
44f230aa
SM
1830 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1831 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
1832 (record_buffer_markers, fetch_buffer_markers): New functions for
1833 recording and fetching special buffer markers.
1834 (set_buffer_internal_1, set_buffer_temp): Use them.
1835
1836 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
1837
1838 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
1839
1840 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
1841 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
1842
1843 * xdisp.c (hscroll_window_tree):
1844 (reconsider_clip_changes): Use PT instead of BUF_PT.
1845
d251f04b
EZ
18462011-03-13 Eli Zaretskii <eliz@gnu.org>
1847
1848 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
1849 $(EMACS_ROOT)/lib/intprops.h.
1850
f0c77cd1
PE
18512011-03-13 Paul Eggert <eggert@cs.ucla.edu>
1852
3eca4629
PE
1853 Fix more problems found by GCC 4.5.2's static checks.
1854
7c86ee98
PE
1855 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
1856 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
1857 (xg_free_frame_widgets): Make it clear that a local variable is
1858 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
1859 (gdk_window_get_screen): Make it clear that this macro is needed
1860 only if USE_GTK_TOOLTIP.
1e5524e7
PE
1861 (int_gtk_range_get_value): New function, which avoids a diagnostic
1862 from gcc -Wbad-function-cast.
1863 (xg_set_toolkit_scroll_bar_thumb): Use it.
1864 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
1865 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
1866 (get_utf8_string, xg_get_file_with_chooser):
1867 Rename locals to avoid shadowing.
1868 (create_dialog): Move locals to avoid shadowing.
7c86ee98 1869
41729b81
PE
1870 * xgselect.c (xg_select): Remove unused var.
1871
f0c77cd1
PE
1872 * image.c (four_corners_best): Mark locals as initialized.
1873 (gif_load): Initialize transparent_p to zero (Bug#8238).
1874 Mark another local as initialized.
ec6cf4c6 1875 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 1876
ce0ad53d 1877 * image.c (clear_image_cache): Now static.
d5d5a617 1878 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 1879 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
1880 (x_edge_detection): Remove unnecessary cast that
1881 gcc -Wbad-function-cast diagnoses.
2037898d 1882 (gif_load): Fix pointer signedness.
6ae141d6
PE
1883 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
1884 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 1885
33383987 18862011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 1887
d32df629
PE
1888 Improve quality of tests for time stamp overflow.
1889 For example, without this patch (encode-time 0 0 0 1 1
1890 1152921504606846976) returns the obviously-bogus value (-948597
1891 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
1892 reports time overflow. See
1893 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
1894 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
1895 * editfns.c: Include limits.h and intprops.h.
1896 (TIME_T_MIN, TIME_T_MAX): New macros.
1897 (time_overflow): Move earlier, to before first use.
1898 (hi_time, lo_time): New functions, for an accurate test for
1899 out-of-range times.
1900 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
1901 (Fget_internal_run_time): Don't assume time_t fits in int.
1902 (make_time): Use list2 instead of Fcons twice.
1903 (Fdecode_time): More accurate test for out-of-range times.
1904 (check_tm_member): New function.
1905 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
1906 (lisp_time_argument): Don't rely on undefined left-shift and
1907 right-shift behavior when checking for time stamp overflow.
8be6f318 1908
fe31d94c
PE
1909 * editfns.c (time_overflow): New function, refactoring common code.
1910 (Fformat_time_string, Fdecode_time, Fencode_time):
1911 (Fcurrent_time_string): Use it.
1912
8be6f318
PE
1913 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
1914 * dired.c (make_time): Move to ...
1915 * editfns.c (make_time): ... here.
1916 * systime.h: Note the move.
1917
09d9db2c 19182011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 1919
126bc0dc
YM
1920 * fringe.c (update_window_fringes): Remove unused variables.
1921
c47cbdfd
YM
1922 * unexmacosx.c (copy_data_segment): Also copy __got section.
1923 (Bug#8223)
1924
7ac80be9
EZ
19252011-03-12 Eli Zaretskii <eliz@gnu.org>
1926
c96bbc66 1927 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
1928 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
1929 Constify `char *' arguments and their references according to
1930 prototypes in tparam.h.
1931
ecb0f94d 1932 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 1933
7ac80be9
EZ
1934 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
1935 Adapt all references accordingly.
1936
1937 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
1938
ef1fd07e
TT
19392011-03-11 Tom Tromey <tromey@redhat.com>
1940
1941 * buffer.c (syms_of_buffer): Remove obsolete comment.
1942
7ef4b50c
EZ
19432011-03-11 Eli Zaretskii <eliz@gnu.org>
1944
1945 * termhooks.h (encode_terminal_code): Declare prototype.
1946
1947 * msdos.c (encode_terminal_code): Don't declare prototype.
1948
1949 * term.c (encode_terminal_code): Now external again, used by
1950 w32console.c and msdos.c.
1951
44f230aa
SM
1952 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
1953 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 1954
4b1ec863 19552011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 1956
1714f52b 1957 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 1958
4b1ec863
PE
1959 * fringe.c (update_window_fringes): Mark locals as initialized
1960 (Bug#8227).
1961 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 1962
524c7aa6
PE
1963 * alloc.c (mark_fringe_data): Move decl from here ...
1964 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
1965 to check its interface.
1966 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
1967
a5c0af81 1968 * fontset.c (free_realized_fontset): Now static.
7519b8cd 1969 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 1970 (fontset_font): Mark local as initialized.
a9a06e0b 1971 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 1972
b4716021
PE
1973 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
1974
811e9bac 1975 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 1976 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
1977 (x_own_selection, Fx_disown_selection_internal): Rename locals
1978 to avoid shadowing.
1979 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 1980
7e3ab302
PE
1981 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
1982 so that the caller can use some name other than gcpro1.
1983 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
1984 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1985 (Fx_backspace_delete_keys_p):
1986 Use them to avoid shadowing, and rename vars to avoid shadowing.
1987 (x_decode_color, x_set_name, x_window): Now static.
6b437900 1988 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 1989 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
1990 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
1991 Remove unused locals.
7e3ab302
PE
1992 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1993 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
1994 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
1995 macros.
f78faa98 1996
e2b13473
PE
1997 * xterm.h (x_mouse_leave): New decl.
1998
77f23912
PE
1999 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
2000 Remove unused functions.
cdf4ba58
PE
2001 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
2002 (x_calc_absolute_position): Now static.
7411c686 2003 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 2004 Don't declare local "event" unless it's used.
ed7bf3a5
PE
2005 (x_iconify_frame, x_free_frame_resources): Don't declare locals
2006 unless they are used.
38d0b34a
PE
2007 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
2008 (x_fatal_error_signal): Remove; not used.
a6067996
PE
2009 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
2010 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
2011 (x_error_catcher, x_connection_closed, x_error_handler):
2012 (x_error_quitter, xembed_send_message, x_iconify_frame):
2013 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 2014 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 2015 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 2016
44f230aa
SM
2017 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
2018 Rename or move locals to avoid shadowing.
6b463e58 2019 (tty_defined_color, merge_face_heights): Now static.
5967d051 2020 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
2021 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
2022 does not deduce is never used uninitialized.
73719eba
PE
2023 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
2024 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 2025
426994c3 2026 * terminal.c (store_terminal_param): Now static.
5489860b 2027
032f1620 2028 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 2029 (set_frame_menubar): Remove unused local.
d4323972 2030 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
2031 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
2032 since they might point to immutable storage.
281585b0
PE
2033 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
2034 since it's unused otherwise.
032f1620 2035
367c19e5 2036 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 2037 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
2038 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
2039 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 2040 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
2041 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
2042 does not deduce are never used uninitialized.
70739cbe 2043
07b48fa9
PE
2044 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
2045
8868a238 2046 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
2047 * window.c (window_loop, size_window):
2048 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 2049
7e5cf297 2050 * window.c (display_buffer): Now static.
d6550a9f
PE
2051 (size_window): Mark variables that gcc -Wuninitialized
2052 does not deduce are never used uninitialized.
a586633d
PE
2053 * window.h (check_all_windows): New decl, to forestall
2054 gcc -Wmissing-prototypes diagnostic.
5b555da1 2055 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 2056
f6095868
PE
2057 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
2058 shadowing.
2059 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
2060 Include <limits.h>.
2061 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
2062 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
2063 (load_charset_map): Mark variables that gcc -Wuninitialized
2064 does not deduce are never used uninitialized.
53df7c11 2065 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 2066
f38b440c
PE
2067 * coding.c (coding_set_source, coding_set_destination):
2068 Use "else { /* comment */ }" rather than "else /* comment */;"
2069 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
2070 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
2071 a block, when the outer 'i' will do.
2072 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
2073 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
2074 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
2075 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
2076 (Fdecode_sjis_char, Fdefine_coding_system_internal):
2077 Rename locals to avoid shadowing.
2078 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
2079 * coding.c (emacs_mule_char, encode_invocation_designation):
2080 Now static, since they're not used elsewhere.
413bb2db 2081 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 2082 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
2083 (decode_coding_emacs_mule): Mark variables that gcc
2084 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
2085 (detect_coding_iso_2022): Initialize a local variable that might
2086 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 2087 this initialization is needed. (Bug#8211)
5f58e762
PE
2088 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
2089 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
2090 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
2091 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
2092 Remove unused macros.
f38b440c 2093
232b38b9 2094 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 2095 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 2096 * character.c (string_count_byte8): Likewise.
232b38b9 2097
fb90da1b
PE
2098 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
2099 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
2100
fb93dbc2
PE
2101 * chartab.c (copy_sub_char_table): Now static, since it's not used
2102 elsewhere.
5c156ace
PE
2103 (sub_char_table_ref_and_range, char_table_ref_and_range):
2104 Rename locals to avoid shadowing.
bbcd0949 2105 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 2106
7d3b3862 2107 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 2108 (BIDI_BOB): Remove unused macro.
7d3b3862 2109
6be7d3da
PE
2110 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
2111 deduce are never used uninitialized.
c2ed9c8b 2112 * term.c (encode_terminal_code): Likewise.
6be7d3da 2113
75f8807f 2114 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 2115
50938595
PE
2116 * tparam.h: New file.
2117 * term.c, tparam.h: Include it.
2118 * deps.mk (term.o, tparam.o): Depend on tparam.h.
2119 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
2120 Move these decls to tparam.h, and make them agree with what
2121 is actually in tparam.c. The previous trick of using incompatible
2122 decls in different modules does not conform to the C standard.
2123 All callers of tparam changed to use tparam's actual API.
2124 * tparam.c (tparam1, tparam, tgoto):
2125 Use const pointers where appropriate.
2126
fbceeba2
PE
2127 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
2128 * cm.h (struct cm): Likewise.
2129 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
2130 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
2131 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
2132 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
2133 (turn_on_face, init_tty): Likewise.
2134 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 2135
7f3f1250
PE
2136 * term.c (term_mouse_position): Rename local to avoid shadowing.
2137
e6ca6543
PE
2138 * alloc.c (mark_ttys): Move decl from here ...
2139 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
2140
c40f8d15
AS
21412011-03-11 Andreas Schwab <schwab@linux-m68k.org>
2142
2143 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
2144
cfe0661d
JB
21452011-03-09 Juanma Barranquero <lekktu@gmail.com>
2146
2147 * search.c (compile_pattern_1): Remove argument regp, unused since
2148 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
2149 (compile_pattern): Don't pass it.
2150
0afb4571
J
21512011-03-08 Jan Djärv <jan.h.d@swipnet.se>
2152
2153 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
2154 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
2155 for ! HAVE_GTK3.
2156 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
2157
2158 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
2159
2160 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
2161 gdk_window_get_screen, gdk_window_get_geometry,
2162 gdk_x11_window_lookup_for_display and GDK_KEY_g.
2163 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
2164 (xg_get_pixbuf_from_pixmap): New function.
2165 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
2166 to Pixmap, take frame as parameter, remove GdkColormap parameter.
2167 Call xg_get_pixbuf_from_pixmap instead of
2168 gdk_pixbuf_get_from_drawable.
2169 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
2170 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
2171 (xg_check_special_colors): Use GtkStyleContext and its functions
2172 for HAVE_GTK3.
2173 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
2174 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
2175 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
2176 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
2177 Call gtk_widget_get_preferred_size.
0afb4571
J
2178 (xg_frame_resized): gdk_window_get_geometry only takes 5
2179 parameters.
44f230aa
SM
2180 (xg_win_to_widget, xg_event_is_for_menubar):
2181 Call gdk_x11_window_lookup_for_display.
0afb4571
J
2182 (xg_set_widget_bg): New function.
2183 (delete_cb): New function.
2184 (xg_create_frame_widgets): connect delete-event to delete_cb.
2185 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
2186 (xg_set_background_color): Call xg_set_widget_bg.
2187 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
2188 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
2189 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
2190 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
2191 if ! HAVE_GTK3.
2192 (update_frame_tool_bar): Call gtk_widget_hide.
2193 (xg_initialize): Use GDK_KEY_g.
2194
2195 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
2196 if ! HAVE_GTK3
2197 (x_session_initialize): Call gdk_x11_set_sm_client_id.
2198
2199 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
2200 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
2201 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
2202
1c2cc4ef
JB
22032011-03-08 Juanma Barranquero <lekktu@gmail.com>
2204
2205 * w32xfns.c (select_palette): Check success of RealizePalette against
2206 GDI_ERROR, not zero.
2207
33383987 2208See ChangeLog.11 for earlier changes.
aac0c6e3
MR
2209
2210;; Local Variables:
2211;; coding: utf-8
aac0c6e3
MR
2212;; End:
2213
33383987 2214 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
2215
2216 This file is part of GNU Emacs.
2217
2218 GNU Emacs is free software: you can redistribute it and/or modify
2219 it under the terms of the GNU General Public License as published by
2220 the Free Software Foundation, either version 3 of the License, or
2221 (at your option) any later version.
2222
2223 GNU Emacs is distributed in the hope that it will be useful,
2224 but WITHOUT ANY WARRANTY; without even the implied warranty of
2225 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
2226 GNU General Public License for more details.
2227
2228 You should have received a copy of the GNU General Public License
2229 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.