* src/process.c (Qprocessp): Don't declare static.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
6c60eb9f
SM
12011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2
3 * process.c (Qprocessp): Don't declare static.
4 * lisp.h (Qprocessp): Declare again.
5
5d4cb038
PE
62011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7
8bd7b830 8 Improve C-level modularity by making more things 'static'.
cd64ea1d 9
e3b27b31
PE
10 Don't publish debugger-only interfaces to other modules.
11 * lisp.h (safe_debug_print, debug_output_compilation_hack):
12 (verify_bytepos, count_markers): Move decls to the only modules
13 that need them.
14 * region-cache.h (pp_cache): Likewise.
15 * window.h (check_all_windows): Likewise.
16 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
17
5d4cb038
PE
18 * sysdep.c (croak): Now static, if
19 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
20 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
21
22 * alloc.c (refill_memory_reserve): Now static if
23 !defined REL_ALLOC || defined SYSTEM_MALLOC.
24 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 25
e87b6180
PE
26 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
27 Define only if USE_LUCID.
28
ac64929e
PE
29 * xrdb.c (x_customization_string, x_rm_string): Now static.
30
6f37259d
PE
31 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
32 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
33
1683e3ab
PE
34 * xdisp.c (draw_row_with_mouse_face): Now static.
35 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
36
de9c2632
PE
37 * window.h (check_all_windows): Mark externally visible.
38
2b96acb7
PE
39 * window.c (window_deletion_count): Now static.
40
41 * undo.c: Make symbols static if they're not exported.
42 (last_undo_buffer, last_boundary_position, pending_boundary):
43 Now static.
44
50436f33
PE
45 * textprop.c (interval_insert_behind_hooks): Now static.
46 (interval_insert_in_front_hooks): Likewise.
47
64520e5c
PE
48 * term.c: Make symbols static if they're not exported.
49 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
50 (max_frame_lines, tty_set_terminal_modes):
51 (tty_reset_terminal_modes, tty_turn_off_highlight):
52 (get_tty_terminal): Now static.
53 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
54 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 55 HAVE_WINDOW_SYSTEM.
64520e5c
PE
56 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
57 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
58
1fa53021
PE
59 * sysdep.c: Make symbols static if they're not exported.
60 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
61 Now static.
62 (sigprocmask_set, full_mask): Remove; unused.
63 (wait_debugging): Mark as visible.
64 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
65 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
66
d4b43b22
PE
67 * syntax.c (syntax_temp): Define only if !__GNUC__.
68
b7c513d0
PE
69 * sound.c (current_sound_device, current_sound): Now static.
70
989b29ad
PE
71 * search.c (searchbufs, searchbuf_head): Now static.
72
13a55a78
PE
73 * scroll.c (scroll_cost): Remove; unused.
74 * dispextern.h (scroll_cost): Remove decl.
75
de68a1fc
PE
76 * region-cache.h (pp_cache): Mark as externally visible.
77
40ccffa6
PE
78 * process.c: Make symbols static if they're not exported.
79 (process_tick, update_tick, create_process, chan_process):
80 (Vprocess_alist, proc_buffered_char, datagram_access):
81 (fd_callback_data, send_process_frame, process_sent_to): Now static.
82 (deactivate_process): Mark defn as static, as well as decl.
83 * lisp.h (create_process): Remove decl.
84 * process.h (chan_process, Vprocess_alist): Remove decls.
85
ad64fc97
PE
86 * print.c: Make symbols static if they're not exported.
87 (print_depth, new_backquote_output, being_printed, print_buffer):
88 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
89 (print_interval, print_number_index, initial_stderr_stream):
90 Now static.
91 * lisp.h (Fprinc): Remove decl.
92 (debug_output_compilation_hack): Mark as externally visible.
93
adddb265
PE
94 * sysdep.c (croak): Move decl from here to syssignal.h.
95 * syssignal.h (croak): Put it here, so the API can be checked when
96 'croak' is called from dissociate_if_controlling_tty.
97
1717ede2
PE
98 * minibuf.c: Make symbols static if they're not exported.
99 (minibuf_save_list, choose_minibuf_frame): Now static.
100 * lisp.h (choose_minibuf_frame): Remove decl.
101
fa5fb2bc
PE
102 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
103
1e3890d1
PE
104 * lread.c: Make symbols static if they're not exported.
105 (read_objects, initial_obarray, oblookup_last_bucket_number):
106 Now static.
107 (make_symbol): Remove; unused.
108 * lisp.h (initial_obarray, make_symbol): Remove decls.
109
8a1414fa
PE
110 * keyboard.c: Make symbols static if they're not exported.
111 (single_kboard, recent_keys_index, total_keys, recent_keys):
112 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
113 (this_single_command_key_start, echoing, last_auto_save):
114 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
115 (command_loop, echo_now, keyboard_init_hook, help_char_p):
116 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
117 (Vlispy_mouse_stem, double_click_count):
118 Now static.
119 (force_auto_save_soon): Define only if SIGDANGER.
120 (ignore_mouse_drag_p): Now static if
121 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
122 (print_help): Remove; unused.
123 (stop_character, last_timer_event): Mark as externally visible.
124 * keyboard.h (ignore_mouse_drag_p): Declare only if
125 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
126 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
127 * lisp.h (echoing): Remove decl.
128 (force_auto_save_soon): Declare only if SIGDANGER.
129 * xdisp.c (redisplay_window): Simplify code, to make it more
130 obvious that ignore_mouse_drag_p is not accessed if !defined
131 USE_GTK && !defined HAVE_NS.
132
93ea6e8f
PE
133 * intervals.c: Make symbols static if they're not exported.
134 (merge_properties_sticky, merge_interval_right, delete_interval):
135 Now static.
136 * intervals.h (merge_interval_right, delete_interval): Remove decls.
137
77382fcc
PE
138 * insdel.c: Make symbols static if they're not exported.
139 However, leave prepare_to_modify_buffer alone. It's never
140 called from outside this function, but that appears to be a bug.
141 (combine_after_change_list, combine_after_change_buffer):
4889fc82 142 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
143 (adjust_after_replace_noundo): Remove; unused.
144 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 145 (signal_before_change): Remove decls.
77382fcc 146
9306c32e
PE
147 * indent.c (val_compute_motion, val_vmotion): Now static.
148
cd44d2eb
PE
149 * image.c: Make symbols static if they're not exported.
150 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
151 if USE_GTK.
152 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
153 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
154
ad9a7a06
PE
155 * fringe.c (standard_bitmaps): Now static.
156 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
157
81626931
PE
158 * frame.c: Make symbols static if they're not exported.
159 (x_report_frame_params, make_terminal_frame): Now static.
160 (get_frame_param): Now static, unless HAVE_NS.
161 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
162 (x_get_resource_string): Remove; not used.
163 * frame.h (make_terminal_frame, x_report_frame_params):
164 (x_get_resource_string); Remove decls.
165 (x_fullscreen_adjust): Declare only if WINDOWSNT.
166 * lisp.h (get_frame_param): Declare only if HAVE_NS.
167
239f9db9
PE
168 * font.c, fontset.c: Make symbols static if they're not exported.
169 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
170 (FACE_SUITABLE_FOR_CHAR_P): Use it.
171 * font.c (font_close_object): Now static.
172 * font.h (font_close_object): Remove.
173 * fontset.c (FONTSET_OBJLIST): Remove.
174 (free_realized_fontset) #if-0 the body, which does nothing.
175 (face_suitable_for_char_p): #if-0, as it's never called.
176 * fontset.h (face_suitable_for_char_p): Remove decl.
177 * xfaces.c (face_at_string_position): Use
178 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
179 since 0 is always ASCII.
180
dfcf3579
PE
181 * fns.c (weak_hash_tables): Now static.
182
5045092b
PE
183 * fileio.c: Make symbols static if they're not exported.
184 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
185 (Vwrite_region_annotation_buffers): Now static.
186
57a96f5c
PE
187 * eval.c: Make symbols static if they're not exported.
188 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
189 * lisp.h (backtrace_list): Remove decl.
190
35f08c38
PE
191 * emacs.c: Make symbols static if they're not exported.
192 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
193 (fatal_error_code, fatal_error_signal_hook, standard_args):
194 Now static.
195 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
196 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
197 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
198 * lisp.h (fatal_error_signal_hook): Remove decl.
199 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
200
f44bd759
PE
201 * editfns.c: Move a (normally-unused) function to its only use.
202 * editfns.c, lisp.h (get_operating_system_release): Remove.
203 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
204 worth the hassle of breaking this out.
205
b532497d
PE
206 * xterm.c: Make symbols static if they're not exported.
207 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
208 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
209 (x_destroy_window, x_delete_display):
210 Now static.
211 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
212 (x_mouse_leave): Remove; unused.
213 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
214 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
215 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
216 Remove decls.
217 (x_mouse_leave): Declare only if WINDOWSNT.
218 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
219 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
220 USE_X_TOOLKIT.
221
1675728f
PE
222 * ftxfont.c: Make symbols static if they're not exported.
223 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
224 HAVE_FREETYPE.
225 * font.h (ftxfont_driver): Likewise.
226
e4cebfca
PE
227 * xfns.c: Make symbols static if they're not exported.
228 (x_last_font_name, x_display_info_for_name):
229 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
230 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
231 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
232 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
233 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
234 (last_show_tip_args): Now static.
235 (xic_defaut_fontset, xic_create_fontsetname): Define only if
236 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
237 (x_screen_planes): Remove; unused.
238 * dispextern.h (x_screen_planes): Remove decl.
239
5bf46f05
PE
240 * dispnew.c: Make symbols static if they're not exported.
241 * dispextern.h (redraw_garbaged_frames, scrolling):
242 (increment_row_positions): Remove.
243 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
244 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
245 Now static.
246 (redraw_garbaged_frames): Remove; unused.
247
435f4c28
PE
248 * xfaces.c: Make symbols static if they're not exported.
249 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
250 Remove decls.
251 * xterm.h (defined_color): Remove decls.
252 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
253 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
254 (menu_face_changed_default, defined_color, free_realized_face):
255 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
256 (ascii_face_of_lisp_face): Remove; unused.
257
8524aef3
PE
258 * xdisp.c: Make symbols static if they're not exported.
259 * dispextern.h (scratch_glyph_row, window_box_edges):
260 (glyph_to_pixel_coords, set_cursor_from_row):
261 (get_next_display_element, set_iterator_to_next):
262 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
263 (show_mouse_face): Remove decls
264 * frame.h (message_buf_print): Likewise.
265 * lisp.h (pop_message, set_message, check_point_in_composition):
266 Likewise.
267 * xterm.h (set_vertical_scroll_bar): Likewise.
268 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
269 (message_buf_print, scratch_glyph_row, displayed_buffer):
270 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
271 (get_next_display_element, show_mouse_face, window_box_edges):
272 (frame_to_window_pixel_xy, check_point_in_composition):
273 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
274 (glyph_to_pixel_coords): Remove; unused.
275
16390cd2
PE
276 * dired.c (file_name_completion): Now static.
277
278 * dbusbind.c (xd_in_read_queued_messages): Now static.
279
a25f4dfa
PE
280 * lisp.h (circular_list_error, FOREACH): Remove; unused.
281 * data.c (circular_list_error): Remove.
282
14a9c8df
PE
283 * commands.h (last_point_position, last_point_position_buffer):
284 (last_point_position_window): Remove decls.
285 * keyboard.c: Make these variables static.
286
74ab6df5
PE
287 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
288 decls.
289 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
290 (iso_code_class, detect_coding, code_convert_region): Now static.
291 (encode_coding_gap): Remove; unused.
292
38dfbee1
PE
293 * chartab.c (chartab_chars, chartab_bits): Now static.
294
a2cb4e63
PE
295 * charset.h (charset_iso_8859_1): Remove decl.
296 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
297 Now static.
298
127198fd
PE
299 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
300 * ccl.c (Vccl_program_table): Now static.
301 (check_ccl_update): Remove; unused.
302
d85b608f
PE
303 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
304 * category.h: ... from here.
305 * category.c (check_category_table, set_category_set): Now static.
306
31cd66f3
PE
307 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
308 * lisp.h: Remove these decls.
309
c358e587
PE
310 * buffer.c (buffer_count): Remove unused var.
311
e78aecca
PE
312 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
313 so that it's not optimized away.
314 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
315 * dispextern.h (bidi_dump_cached_states): Remove, since it's
316 exported only to the debugger.
317
e192d7d3
PE
318 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
319 * atimer.h (run_all_atimers): Removed; not exported.
320
92470028
PE
321 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
322 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
323 was inaccessible from Lisp.
324 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
325 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
326
244ed907
PE
327 alloc.c: Import and export fewer symbols, and remove unused items.
328 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
329 is defined.
330 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
331 it's not optimized away by whole-program optimization.
332 (message_enable_multibyte, free_misc): Remove.
333 (catchlist, handlerlist, mark_backtrace):
334 Declare only if BYTE_MARK_STACK.
335 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
336 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
337 (message_enable_multibyte): Remove decl.
338 (free_misc, interval_free_list, float_block, float_block_index):
339 (n_float_blocks, float_free_list, cons_block, cons_block_index):
340 (cons_free_list, last_marked_index):
341 Now static.
342 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
343 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
344 (mark_backtrace): Define only if BYTE_MARK_STACK.
345 * xdisp.c (message_enable_multibyte): Now static.
346
955cbe7b
PE
347 Declare Lisp_Object Q* variables to be 'static' if not exproted.
348 This makes it easier for human readers (and static analyzers)
349 to see whether these variables are used from other modules.
350 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
351 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
352 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
353 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
354 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
355 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
356 * xmenu.c, xselect.c:
357 Declare Q* vars static if they are not used in other modules.
358 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
359 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
360 Remove decls of unexported vars.
361 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
362
95c82688
PE
363 * lisp.h (DEFINE_FUNC): Make sname 'static'.
364
16a97296
PE
365 Make Emacs functions such as Fatom 'static' by default.
366 This makes it easier for human readers (and static analyzers)
367 to see whether these functions can be called from other modules.
368 DEFUN now defines a static function. To make the function external
369 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
370 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
371 (Finit_image_library):
16a97296
PE
372 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
373 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
374 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
375 Remove decls, since these functions are now static.
376 (Funintern, Fget_internal_run_time): New decls, since these functions
377 were already external.
95c82688 378
16a97296
PE
379 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
380 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
381 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
382 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
383 * keyboard.c, keymap.c, lread.c:
384 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
385 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
386 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
387 Mark functions with DEFUE instead of DEFUN,
388 if they are used in other modules.
389 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
390 decls for now-static functions.
391 * buffer.h (Fdelete_overlay): Remove decl.
392 * callproc.c (Fgetenv_internal): Mark as internal.
393 * composite.c (Fremove_list_of_text_properties): Remove decl.
394 (Fcomposition_get_gstring): New forward static decl.
395 * composite.h (Fcomposite_get_gstring): Remove decl.
396 * dired.c (Ffile_attributes): New forward static decl.
397 * doc.c (Fdocumntation_property): New forward static decl.
398 * eval.c (Ffetch_bytecode): New forward static decl.
399 (Funintern): Remove extern decl; now in .h file where it belongs.
400 * fileio.c (Fmake_symbolic_link): New forward static decl.
401 * image.c (Finit_image_library): New forward static decl.
402 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
403 * intervals.h (Fprevious_property_change):
404 (Fremove_list_of_text_properties): Remove decls.
405 * keyboard.c (Fthis_command_keys): Remove decl.
406 (Fcommand_execute): New forward static decl.
407 * keymap.c (Flookup_key): New forward static decl.
408 (Fcopy_keymap): Now static.
409 * keymap.h (Flookup_key): Remove decl.
410 * process.c (Fget_process): New forward static decl.
411 (Fprocess_datagram_address): Mark as internal.
412 * syntax.c (Fsyntax_table_p): New forward static decl.
413 (skip_chars): Remove duplicate decl.
414 * textprop.c (Fprevious_property_change): New forward static decl.
415 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
416 Now internal.
417 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
418 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
419
785bbd42
PE
420 * editfns.c (Fformat): Remove unreachable code.
421
8b913b57
AS
4222011-04-14 Andreas Schwab <schwab@linux-m68k.org>
423
424 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
425 change. (Bug#8496)
426
a6744a35
EZ
4272011-04-13 Eli Zaretskii <eliz@gnu.org>
428
429 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
430 when at ZV. (Bug#8487)
431
e7974947
AS
4322011-04-12 Andreas Schwab <schwab@linux-m68k.org>
433
baad03f0
AS
434 * charset.c (Fclear_charset_maps): Use xfree instead of free.
435 (Bug#8437)
436 * keyboard.c (parse_tool_bar_item): Likewise.
437 * sound.c (sound_cleanup, alsa_close): Likewise.
438 * termcap.c (tgetent): Likewise.
439 * xfns.c (x_default_font_parameter): Likewise.
440 * xsettings.c (read_and_apply_settings): Likewise.
441
e7974947
AS
442 * alloc.c (overrun_check_malloc, overrun_check_realloc)
443 (overrun_check_free): Protoize.
444
28272684
PE
4452011-04-12 Paul Eggert <eggert@cs.ucla.edu>
446
447 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
448 since callers should never pass a negative size.
449 Change the signature to match that of plain 'read' and 'write'; see
450 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
451 * lisp.h: Update prototypes of emacs_write and emacs_read.
452
11997c76
EZ
4532011-04-11 Eli Zaretskii <eliz@gnu.org>
454
455 * xdisp.c (redisplay_window): Don't try to determine the character
456 position of the scroll margin if the window start point w->startp
e896f03c 457 is outside the buffer's accessible region. (Bug#8468)
11997c76 458
8a2cbd72
EZ
4592011-04-10 Eli Zaretskii <eliz@gnu.org>
460
461 Fix write-region and its subroutines for buffers > 2GB.
462 * fileio.c (a_write, e_write): Modify declaration of arguments and
463 local variables to support buffers larger than 2GB.
464 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
465
466 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
467 argument, local variables, and return value.
468
469 * lisp.h: Update prototypes of emacs_write and emacs_read.
470
471 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
472
4073e537 4732011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 474
1ebfdcb6
PE
475 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
476
b2ded58d
PE
477 Fix more problems found by GCC 4.6.0's static checks.
478
7d66342c
PE
479 * xdisp.c (vmessage): Use a better test for character truncation.
480
bbf47d44
PE
481 * charset.c (load_charset_map): <, not <=, for optimization,
482 and to avoid potential problems with integer overflow.
9248994d 483 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 484 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 485 * editfns.c (Fformat): Likewise.
1e69125e 486 * syntax.c (skip_chars): Likewise.
3befa583 487
e3019616
PE
488 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
489 This also lets GCC 4.6.0 generate slightly better loop code.
490
becfa255
PE
491 * callint.c (Fcall_interactively): <, not <=, for optimization.
492 (Fcall_interactively): Count the number of arguments produced,
493 not the number of arguments given. This is simpler and lets GCC
494 4.6.0 generate slightly better code.
495
dae0cd48
PE
496 * ftfont.c: Distingish more carefully between FcChar8 and char.
497 The previous code passed unsigned char * to a functions like
498 strlen and xstrcasecmp that expect char *, which does not
499 conform to the C standard.
500 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
501 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
502 char * when the C standard requires it.
503
76032d70
PE
504 * keyboard.c (read_char): Remove unused var.
505
eb3f1cc8
PE
506 * eval.c: Port to Windows vsnprintf (Bug#8435).
507 Include <limits.h>.
508 (SIZE_MAX): Define if the headers do not.
509 (verror): Do not give up if vsnprintf returns a negative count.
510 Instead, grow the buffer. This ports to Windows vsnprintf, which
511 does not conform to C99. Problem reported by Eli Zaretskii.
512 Also, simplify the allocation scheme, by avoiding the need for
513 calling realloc, and removing the ALLOCATED variable.
514
70476b54
PE
515 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
516
12020a9e
PE
517 Remove invocations of doprnt, as Emacs now uses vsnprintf.
518 But keep the doprint source code for now, as we might revamp it
519 and use it again (Bug#8435).
ea6c7ae6
PE
520 * lisp.h (doprnt): Remove.
521 * Makefile.in (base_obj): Remove doprnt.o.
522 * deps.mk (doprnt.o): Remove.
523
5fdb398c
PE
524 error: Print 32- and 64-bit integers portably (Bug#8435).
525 Without this change, on typical 64-bit hosts error ("...%d...", N)
526 was used to print both 32- and 64-bit integers N, which relied on
527 undefined behavior.
528 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
529 New macro.
530 * lisp.h (error, verror): Mark as printf-like functions.
531 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
532 Report overflow in size calculations when allocating printf buffer.
533 Do not truncate output string at its first null byte.
534 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
535 Truncate the output at a character boundary, since vsnprintf does not
536 do that.
537 * charset.c (check_iso_charset_parameter): Convert internal
538 character to string before calling 'error', since %c now has the
539 printf meaning.
540 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
541 overflow when computing char to be passed to 'error'. Do not
542 pass Lisp_Object to 'error'; pass the integer instead.
543 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
544 formatted with plain %d.
545
b189fa66
PE
546 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
547
bff87ef0
PE
548 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
549
7e2cac20
PE
550 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
551
ce4d90b5
PE
552 * xterm.c (x_catch_errors): Remove duplicate declaration.
553
266c9547
PE
554 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
555
79c49ad2
PE
556 * xdisp.c, lisp.h (message_nolog): Remove; unused.
557
368f4090
JM
5582011-04-10 Jim Meyering <meyering@redhat.com>
559
560 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
561 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
562 return ssize_t not "int", and use size_t as the buffer length.
563 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
564 * gnutls.h: Update declarations.
565 * process.c (read_process_output): Use ssize_t, to match.
566 (send_process): Likewise.
567
a32d4040
CY
5682011-04-09 Chong Yidong <cyd@stupidchicken.com>
569
570 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
571
8546720e 5722011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 573
8546720e
GM
574 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
575 unsigned char, to match FcChar8 type definition.
aac0c6e3 576
8546720e
GM
577 * xterm.c (handle_one_xevent):
578 * xmenu.c (create_and_show_popup_menu):
579 * xselect.c (x_decline_selection_request)
580 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 581
0a2f5c1a 5822011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
583
584 Fix some uses of `int' instead of EMACS_INT.
585 * search.c (string_match_1, fast_string_match)
586 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
587 (scan_buffer, find_next_newline_no_quit)
588 (find_before_next_newline, search_command, Freplace_match)
589 (Fmatch_data): Make some `int' variables be EMACS_INT.
590
591 * xdisp.c (display_count_lines): 3rd argument and return value now
592 EMACS_INT. All callers changed.
593 (pint2hrstr): Last argument is now EMACS_INT.
594
595 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
596 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
597 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
598 (decode_coding_utf_16, decode_coding_emacs_mule)
599 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
600 (decode_coding_ccl, decode_coding_charset)
601 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
602 (decode_coding_iso_2022, decode_coding_emacs_mule)
603 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
604 <char_offset, last_offset>: Declare EMACS_INT.
605 (encode_coding_utf_8, encode_coding_utf_16)
606 (encode_coding_emacs_mule, encode_invocation_designation)
607 (encode_designation_at_bol, encode_coding_iso_2022)
608 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
609 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
610 Declare EMACS_INT.
611 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
612 (encode_invocation_designation): Last argument P_NCHARS is now
613 EMACS_INT.
614 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
615 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
616
617 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
618 All users changed.
619
620 * ccl.c (Fccl_execute_on_string): Declare some variables
621 EMACS_INT.
622
8546720e 6232011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
624
625 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
626
4e19a977
CS
6272011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
628
629 * process.c (Fformat_network_address): Doc fix.
630
87302331
R
6312011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
632
633 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
634
cbb59342
CY
6352011-04-08 Chong Yidong <cyd@stupidchicken.com>
636
637 * keyboard.c (read_char): Call Lisp function help-form-show,
638 instead of using internal_with_output_to_temp_buffer.
639 (Qhelp_form_show): New var.
e0d38eeb 640 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
641
642 * print.c (internal_with_output_to_temp_buffer): Function deleted.
643
644 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
645
e67a13ab
CY
6462011-04-06 Chong Yidong <cyd@stupidchicken.com>
647
648 * process.c (Flist_processes): Removed to Lisp.
649 (list_processes_1): Deleted.
650
973f782d
EZ
6512011-04-06 Eli Zaretskii <eliz@gnu.org>
652
7c106b1e
EZ
653 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
654
973f782d
EZ
655 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
656
41cf7d1a 6572011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 658
ca23cc88
PE
659 Fix more problems found by GCC 4.6.0's static checks.
660
f390e2d5
PE
661 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
662
42eea0d0
PE
663 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
664
b69769da 665 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 666
f9541e84
PE
667 * xdisp.c (vmessage): Mark as a printf-like function.
668
13841b55
PE
669 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
670
c136c10f
PE
671 * sound.c (sound_warning): Don't crash if arg contains a printf format.
672
5e2d4a30
PE
673 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
674 printf-like functions.
675 (tiff_load): Add casts to remove these marks before passing them
676 to system-supplied API.
677
583f48b9
PE
678 * eval.c (Fsignal): Remove excess argument to 'fatal'.
679
b25d760e
PE
680 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
681 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
682 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
683 directly, rather than having caller test rule sign. This avoids
684 some unnecessary tests.
685 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
686 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
687 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 688
bc7b6697 689 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 690 (xfont_open): Avoid unnecessary tests.
bc7b6697 691
27ccc379
PE
692 * composite.c (composition_gstring_put_cache): Use unsigned integer.
693
dcd5c89a
PE
694 * composite.h, composite.c (composition_gstring_put_cache):
695 Use EMACS_INT, not int, for length.
696
b13a45c6
PE
697 * composite.h (COMPOSITION_DECODE_REFS): New macro,
698 breaking out part of COMPOSITION_DECODE_RULE.
699 (COMPOSITION_DECODE_RULE): Use it.
700 * composite.c (get_composition_id): Remove unused local vars,
701 by using the new macro.
702
1e792e4d
PE
703 * textprop.c (set_text_properties_1): Change while to do-while,
704 since the condition is always true at first.
705
dc6c6455 706 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
707 (interval_deletion_adjustment): Return unsigned value.
708 All uses changed.
dc6c6455 709
aba7731a
PE
710 * process.c (list_processes_1, create_pty, read_process_output):
711 (exec_sentinel): Remove vars that were set but not used.
afd4052b 712 (create_pty): Remove unnecessary "volatile"s.
bc57d757 713 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 714 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 715 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 716
fdfc4bf3
PE
717 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
718
fca8fe46 719 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 720 (update_syntax_table): Use unsigned instead of int.
fca8fe46 721
06a0259a 722 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 723 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 724 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 725
e7b9e80f
PE
726 * print.c (print_error_message): Avoid int overflow.
727
56201685
PE
728 * font.c (font_list_entities): Redo for clarity,
729 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
730
78834453 731 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 732 (font_score): Avoid potential overflow in diff calculation.
78834453 733
0bc0b309 734 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 735 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 736
e610eaca
PE
737 * eval.c (funcall_lambda): Rename local to avoid shadowing.
738
b895abce
PE
739 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
740 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
741 can always succeed if overflow has undefined behavior.
742
1f1d9321 743 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 744 (wordify): Omit three unnecessary tests.
1f1d9321 745
c59478bc
PE
746 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
747 All callers changed. This avoids the need for an unused var.
748
79b73827
PE
749 * casefiddle.c (casify_region): Remove var that is set but not used.
750
a4db5dfe
PE
751 * dired.c (file_name_completion): Remove var that is set but not used.
752
43aae36e
PE
753 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
754
2a47c44d 755 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 756 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 757
a37c69bf
PE
758 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
759 Check for integer overflow on size calculations.
760
328ab8e7
PE
761 * buffer.c (Fprevious_overlay_change): Remove var that is set
762 but not used.
763
e5a2a5cb
PE
764 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
765 Remove vars that are set but not used.
8d84a6eb 766 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 767 (timer_check_2): Mark vars as initialized.
e5a2a5cb 768
a60e5f68
PE
769 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
770
f661cb61 771 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 772 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 773
f0397f5a
PE
774 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
775 that are set but not used.
776
8664db06 777 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 778 if XCreateBitmapFromData fails (Bug#8410).
8664db06 779
6abdaa4a
PE
780 * xselect.c (x_get_local_selection, x_handle_property_notify):
781 Remove vars that are set but not used.
782
0ce7538d 783 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 784 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 785
9ae848fc
PE
786 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
787 Remove var that is set but not used.
0b918413
PE
788 (scroll_bar_windows_size): Now size_t, not int.
789 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
790 Check for overflow.
9ae848fc 791
a5a62657
PE
792 * xfaces.c (realize_named_face): Remove vars that are set but not used.
793 (map_tty_color) [!defined MSDOS]: Likewise.
794
5c5cdd39
PE
795 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
796
66ebf983
PE
797 * coding.c: Remove vars that are set but not used.
798 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
799 All callers changed.
800 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
801 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
802 (decode_coding_charset): Remove vars that are set but not used.
803
1be4d761
PE
804 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
805 that is set but not used.
806
47553fa8
PE
807 * print.c (print_object): Remove var that is set but not used.
808
1f7196bf 809 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
810 The gnulib version avoids calling malloc in the usual case,
811 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
812 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
813 * filelock.c (current_lock_owner): Likewise.
814 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
815 * sysdep.c: Include allocator.h, careadlinkat.h.
816 (emacs_no_realloc_allocator): New static constant.
817 (emacs_readlink): New function.
fdb61804
PE
818 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
819 ../lib/careadlinkat.h.
d1fdcab7 820
f84c17c7
SM
8212011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
822
823 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
824 first non-nil return value).
825
ef3862ad
JD
8262011-04-03 Jan Djärv <jan.h.d@swipnet.se>
827
828 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
829 if not defined (Bug#8403).
830
376a7006
JB
8312011-04-02 Juanma Barranquero <lekktu@gmail.com>
832
833 * xdisp.c (display_count_lines): Remove parameter `start',
834 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
835 (get_char_face_and_encoding): Remove parameter `multibyte_p',
836 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
837 (fill_stretch_glyph_string): Remove parameters `row' and `area',
838 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
839 and thereabouts. All callers changed.
840 (get_per_char_metric): Remove parameter `f', unused since
841 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
842
6ca3801d
JM
8432011-04-02 Jim Meyering <meyering@redhat.com>
844
845 do not dereference NULL upon failed strdup
846 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
847 (ns_get_family): Likewise.
848
d8e2b5ba
JB
8492011-04-02 Juanma Barranquero <lekktu@gmail.com>
850
851 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
852
8c74fcbd
JD
8532011-04-02 Jan Djärv <jan.h.d@swipnet.se>
854
855 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
856 later (Bug#8403).
857
7200d79c
SM
8582011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
859
03408648 860 Add lexical binding.
7200d79c 861
03408648
SM
862 * window.c (Ftemp_output_buffer_show): New fun.
863 (Fsave_window_excursion):
864 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
865
866 * lread.c (lisp_file_lexically_bound_p): New function.
867 (Fload): Bind Qlexical_binding.
868 (readevalloop): Remove `evalfun' arg.
869 Bind Qinternal_interpreter_environment.
870 (Feval_buffer): Bind Qlexical_binding.
871 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
872 Mark as dynamic.
873 (syms_of_lread): Declare `lexical-binding'.
874
875 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
876
877 * keyboard.c (eval_dyn): New fun.
878 (menu_item_eval_property): Use it.
ca105506
SM
879
880 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 881
03408648
SM
882 * fns.c (concat, mapcar1): Accept byte-code-functions.
883
884 * eval.c (Fsetq): Handle lexical vars.
885 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
886 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
887 (FletX, Flet): Obey lexical binding.
888 (Fcommandp): Handle closures.
889 (Feval): New `lexical' arg.
890 (eval_sub): New function extracted from Feval. Use it almost
891 everywhere where Feval was used. Look up vars in lexical env.
892 Handle closures.
893 (Ffunctionp): Move from subr.el.
894 (Ffuncall): Handle closures.
895 (apply_lambda): Remove `eval_flags'.
896 (funcall_lambda): Handle closures and new byte-code-functions.
897 (Fspecial_variable_p): New function.
898 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
899 but without exporting it to Lisp.
23aba0ea 900
23aba0ea 901 * doc.c (Fdocumentation, store_function_docstring):
03408648 902 * data.c (Finteractive_form): Handle closures.
23aba0ea 903
03408648
SM
904 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
905 interactive spec.
ba83908c 906
03408648
SM
907 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
908 byte-codes.
909 (exec_byte_code): New function extracted from Fbyte_code to handle new
910 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 911
03408648 912 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 913
03408648 914 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 915
e2abce01
JB
9162011-03-31 Juanma Barranquero <lekktu@gmail.com>
917
918 * xdisp.c (redisplay_internal): Fix prototype.
919
63696a73 9202011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 921
63696a73
EZ
922 * xdisp.c (SCROLL_LIMIT): New macro.
923 (try_scrolling): Use it when setting scroll_limit. Limit
924 scrolling to 100 screen lines.
925 (redisplay_window): Even when falling back on "recentering",
926 position point in the window according to scroll-conservatively,
927 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
928
929 (try_scrolling): When point is above the window, allow searching
930 as far as scroll_max, or one screenful, to compute vertical
931 distance from PT to the scroll margin position. This prevents
932 try_scrolling from unnecessarily failing when
933 scroll-conservatively is set to a value slightly larger than the
934 window height. Clean up the case of PT below the margin at bottom
935 of window: scroll_max can no longer be INT_MAX. When aggressive
936 scrolling is in use, don't let point enter the opposite scroll
937 margin as result of the scroll.
938 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
939 threshold of 100 lines for never-recentering scrolling.
940
e4cc2dfc
JB
9412011-03-31 Juanma Barranquero <lekktu@gmail.com>
942
943 * dispextern.h (move_it_by_lines):
944 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
945 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
946 (message_log_check_duplicate): Remove parameters `prev_bol' and
947 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
948 (redisplay_internal): Remove parameter `preserve_echo_area',
949 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
950
951 * indent.c (Fvertical_motion):
952 * window.c (window_scroll_pixel_based, Frecenter):
953 Don't pass `need_y_p' to `move_it_by_lines'.
954
1c470562
SM
9552011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
956
44f230aa
SM
957 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
958 steal a few bits to be more compact.
959 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
960 Remove unneeded casts.
961
1c470562
SM
962 * bytecode.c (Fbyte_code): CAR and CDR can GC.
963
888adce9
ZK
9642011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
965
966 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
967 binding" message (bug#7967).
968
f838ed7b
PE
9692011-03-30 Paul Eggert <eggert@cs.ucla.edu>
970
77861b95
PE
971 Fix more problems found by GCC 4.6.0's static checks.
972
de6dbc14
PE
973 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
974 Remove unused local var.
975
f838ed7b
PE
976 * editfns.c (Fmessage_box): Remove unused local var.
977
792c7b2b
PE
978 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
979 (note_mode_line_or_margin_highlight, note_mouse_highlight):
980 Omit unused local vars.
c499e557 981 * window.c (shrink_windows): Omit unused local var.
b01a1c29 982 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
983 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
984 Omit unused local var.
985
ba0165e1
PE
986 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
987 Don't assume string length fits in int.
32ad8845 988 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 989 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 990
3c59b4c9
PE
991 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
992 instead of alloca (Bug#8344).
993
a3eed478 994 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 995 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 996
eb4d412d
PE
997 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
998
1658b401
PE
999 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
1000 concerns.
1001
1002 * term.c (produce_glyphless_glyph): Remove unnecessary test.
1003
1004 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 1005
9a2c6e05
PE
1006 * keyboard.c (syms_of_keyboard): Use the same style as later
1007 in this function when indexing through an array. This also
1008 works around GCC bug 48267.
1009
03d0a109
PE
1010 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
1011
44f730c8
PE
1012 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
1013
fe75f926
PE
1014 * chartab.c (sub_char_table_ref_and_range): Redo for slight
1015 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
1016
ffa8c828
PE
1017 * keyboard.c, keyboard.h (num_input_events): Now size_t.
1018 This avoids undefined behavior on integer overflow, and is a bit
1019 more convenient anyway since it is compared to a size_t variable.
1020
c5101a77
PE
1021 Variadic C functions now count arguments with size_t, not int.
1022 This avoids an unnecessary limitation on 64-bit machines, which
1023 caused (substring ...) to crash on large vectors (Bug#8344).
1024 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
1025 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 1026 All variadic functions and their callers changed accordingly.
c5101a77
PE
1027 (struct gcpro.nvars): Now size_t, not int. All uses changed.
1028 * data.c (arith_driver, float_arith_driver): Likewise.
1029 * editfns.c (general_insert_function): Likewise.
1030 * eval.c (struct backtrace.nargs, interactive_p)
1031 (internal_condition_case_n, run_hook_with_args, apply_lambda)
1032 (funcall_lambda, mark_backtrace): Likewise.
1033 * fns.c (concat): Likewise.
1034 * frame.c (x_set_frame_parameters): Likewise.
1035 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
1036 0 if not found, not -1. All callers changed.
1037
dd3f25f7
PE
1038 * alloc.c (garbage_collect): Don't assume stack size fits in int.
1039 (stack_copy_size): Now size_t, not int.
1040 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
1041
461c2ab9
JB
10422011-03-28 Juanma Barranquero <lekktu@gmail.com>
1043
1044 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
1045 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1046 All callers changed.
1047
1048 * lisp.h (multibyte_char_to_unibyte):
1049 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
1050 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1051 * character.h (CHAR_TO_BYTE8):
1052 * cmds.c (internal_self_insert):
1053 * editfns.c (general_insert_function):
1054 * keymap.c (push_key_description):
1055 * search.c (Freplace_match):
1056 * xdisp.c (message_dolog, set_message_1): All callers changed.
1057
f6d62986
SM
10582011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1059
1060 * keyboard.c (safe_run_hook_funcall): New function.
1061 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
1062 don't set the hook to nil, but remove the offending function instead.
1063 (Qcommand_hook_internal): Remove, unused.
1064 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
1065 Vcommand_hook_internal.
1066
1067 * eval.c (enum run_hooks_condition): Remove.
1068 (funcall_nil, funcall_not): New functions.
1069 (run_hook_with_args): Call each function through a `funcall' argument.
1070 Remove `cond' argument, now redundant.
1071 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
1072 (Frun_hook_with_args_until_failure): Adjust accordingly.
1073 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
1074
1db5b1ad
JB
10752011-03-28 Juanma Barranquero <lekktu@gmail.com>
1076
1077 * dispextern.h (string_buffer_position): Remove declaration.
1078
1079 * print.c (strout): Remove parameter `multibyte', unused since
1080 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
1081
1082 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
1083 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
1084 All callers changed.
1085
1086 * w32.c (_wsa_errlist): Use braces for struct initializers.
1087
1088 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
1089 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
1090 All callers changed.
1091 (string_buffer_position): Likewise. Also, make static (it's never
1092 used outside xdisp.c).
1093 (cursor_row_p): Remove parameter `w', unused since
1094 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
1095 (decode_mode_spec): Remove parameter `precision', introduced during
1096 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
1097 All callers changed.
1098
5ffb62aa
JD
10992011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1100
1101 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
1102
461c2ab9 11032011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
1104
1105 * nsterm.m (ns_menu_bar_is_hidden): New variable.
1106 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
1107 (ns_update_auto_hide_menu_bar): New functions.
1108 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
1109 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
1110 ns_constrain_all_frames.
1111 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
1112 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
1113
5c380ffb
JD
11142011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1115
1116 * nsmenu.m (runDialogAt): Remove argument to timer_check.
1117
9af30bdf
GM
11182011-03-27 Glenn Morris <rgm@gnu.org>
1119
1120 * syssignal.h: Replace RETSIGTYPE with void.
1121 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
1122 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
1123 Replace SIGTYPE with void everywhere.
1124 * s/usg5-4-common.h (SIGTYPE): Remove definition.
1125 * s/template.h (SIGTYPE): Remove commented out definition.
1126
e2abce01
JB
11272011-03-26 Eli Zaretskii <eliz@gnu.org>
1128
1129 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
1130 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
1131
f868cd8a
JB
11322011-03-26 Juanma Barranquero <lekktu@gmail.com>
1133
59eb0929
JB
1134 * w32.c (read_unc_volume): Use parameter `henum', instead of
1135 global variable `wget_enum_handle'.
1136
1137 * keymap.c (describe_vector): Remove parameters `indices' and
1138 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
1139 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
1140
f868cd8a
JB
1141 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
1142
1143 * keyboard.c (timer_check): Remove parameter `do_it_now',
1144 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
1145 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
1146 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
1147
1148 * keyboard.c (read_char):
1149 * w32menu.c (w32_menu_display_help):
1150 * xmenu.c (show_help_event, menu_help_callback):
1151 Adjust calls to `show_help_echo'.
1152
1153 * gtkutil.c (xg_maybe_add_timer):
1154 * keyboard.c (readable_events):
1155 * process.c (wait_reading_process_output):
1156 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
1157
1158 * insdel.c (adjust_markers_gap_motion):
1159 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
1160 (gap_left, gap_right): Don't call it.
1161
2ecf6fdb
CY
11622011-03-25 Chong Yidong <cyd@stupidchicken.com>
1163
1164 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
1165 incurred during fontification.
1166
6b1f9ba4
JB
11672011-03-25 Juanma Barranquero <lekktu@gmail.com>
1168
1169 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
1170 (DEFVAR_PER_BUFFER): Don't pass it.
1171
1172 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
1173 (scrolling_window): Don't pass it.
1174
0f4a96b5
JB
11752011-03-25 Juanma Barranquero <lekktu@gmail.com>
1176
1177 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
1178
1179 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
1180 and `suffix'.
1181 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
1182 of variables specific to SELinux and computation of `encoded_absname'.
1183
1184 * image.c (XPutPixel): Remove unused variable `height'.
1185
1186 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
1187
1188 * unexw32.c (get_section_info): Remove unused variable `section'.
1189
1190 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
1191 (system_process_attributes): Remove unused variable `sess'.
1192 (sys_read): Remove unused variable `err'.
1193
1194 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
1195 (w32_wnd_proc): Remove unused variable `isdead'.
1196 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
1197 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
1198 (x_create_tip_frame): Remove unused variable `tem'.
1199
1200 * w32inevt.c (w32_console_read_socket):
1201 Remove unused variable `no_events'.
1202
1203 * w32term.c (x_draw_composite_glyph_string_foreground):
1204 Remove unused variable `width'.
1205
1149507c
JB
12062011-03-24 Juanma Barranquero <lekktu@gmail.com>
1207
1208 * w32term.c (x_set_glyph_string_clipping):
1209 Don't pass uninitialized region to CombineRgn.
1210
9c88f339
JB
12112011-03-23 Juanma Barranquero <lekktu@gmail.com>
1212
1213 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
1214 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
1215 (Fx_close_connection): Remove unused variable `i'.
1216
1217 * w32font.c (w32font_draw): Return number of glyphs.
1218 (w32font_open_internal): Remove unused variable `i'.
1219 (w32font_driver): Add missing initializer.
1220
1221 * w32menu.c (utf8to16): Remove unused variable `utf16'.
1222 (fill_in_menu): Remove unused variable `items_added'.
1223
1224 * w32term.c (last_mouse_press_frame): Remove static global variable.
1225 (w32_clip_to_row): Remove unused variable `f'.
1226 (x_delete_terminal): Remove unused variable `i'.
1227
1228 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
1229 (NOTHING): Remove unused static global variable.
1230 (uniscribe_check_otf): Remove unused variable `table'.
1231 (uniscribe_font_driver): Add missing initializers.
1232
dee091a3
JD
12332011-03-23 Julien Danjou <julien@danjou.info>
1234
1235 * term.c (Fsuspend_tty, Fresume_tty):
1236 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
1237 * window.c (temp_output_buffer_show):
1238 * insdel.c (signal_before_change):
1239 * frame.c (Fhandle_switch_frame):
1240 * fileio.c (Fdo_auto_save):
1241 * emacs.c (Fkill_emacs):
1242 * editfns.c (save_excursion_restore):
1243 * cmds.c (internal_self_insert):
1244 * callint.c (Fcall_interactively):
1245 * buffer.c (Fkill_all_local_variables):
1246 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
1247 Use Frun_hooks.
0f4a96b5 1248 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
1249 unconditionnaly since it does the check itself.
1250
2c520ab5 12512011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 1252
c9c49752
PE
1253 Fix more problems found by GCC 4.5.2's static checks.
1254
8abc3f12
PE
1255 * coding.c (encode_coding_raw_text): Avoid unnecessary test
1256 the first time through the loop, since we know p0 < p1 then.
1257 This also avoids a gcc -Wstrict-overflow warning.
1258
a2d26660
PE
1259 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
1260 leading to a memory leak, possible in functions like
1261 load_charset_map_from_file that can allocate an unbounded number
b12ef411 1262 of objects (Bug#8318).
a2d26660 1263
916c72e9
PE
1264 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
1265 that could (at least in theory) be that large.
1266
19ab8a18
PE
1267 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
1268 This is less likely to overflow, and avoids undefined behavior if
1269 overflow does occur. All callers changed. Use strtoul to scan
1270 for the unsigned long integer.
b7cbbd6f
PE
1271 (pint2hrstr): Simplify and tune code slightly.
1272 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 1273
f0641eff
PE
1274 * scroll.c (do_scrolling): Work around GCC bug 48228.
1275 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
1276
7f650bb9
PE
1277 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
1278 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
1279 (validate_x_resource_name): Simplify count usage.
1280 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 1281
37dd57d1
PE
1282 * fileio.c (Fcopy_file): Report error if fchown or fchmod
1283 fail (Bug#8306).
81e56e61 1284
699979fc 1285 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 1286
401bf9b4
PE
1287 * process.c (Fmake_network_process): Use socklen_t, not int,
1288 where POSIX says socklen_t is required in portable programs.
1289 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 1290 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
1291 (Fmake_network_process, server_accept_connection):
1292 (wait_reading_process_output, read_process_output):
1293 Likewise.
1294
b93aacde
PE
1295 * process.c: Rename or move locals to avoid shadowing.
1296 (list_processes_1, Fmake_network_process):
1297 (read_process_output_error_handler, exec_sentinel_error_handler):
1298 Rename or move locals.
4dc343ee 1299 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 1300 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 1301 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 1302 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 1303 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 1304
af8a867c 1305 Make tparam.h and terminfo.c consistent.
44f230aa
SM
1306 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
1307 Include tparam.h instead, since it declares them.
af8a867c
PE
1308 * cm.h (PC): Remove extern decl; tparam.h now does this.
1309 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
1310 * terminfo.c: Include tparam.h, to check interfaces.
1311 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
1312 (tparam): Adjust signature to match interface in tparam.h;
1313 this removes some undefined behavior. Check that outstring and len
1314 are zero, which they always are with Emacs.
1315 * tparam.h (PC, BC, UP): New extern decls.
1316
0248044d 1317 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 1318 (xftfont_open): Rename locals to avoid shadowing.
0248044d 1319
8ff096c1 1320 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
1321 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
1322 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 1323 (ftfont_list): Remove unused local.
49eaafba
PE
1324 (get_adstyle_property, ftfont_pattern_entity):
1325 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
1326 Rename locals to avoid shadowing.
8ff096c1 1327
e2be39f6
PE
1328 * xfont.c (xfont_list_family): Mark var as initialized.
1329
c9735e30
PE
1330 * xml.c (make_dom): Now static.
1331
8f5201ae
PE
1332 * composite.c (composition_compute_stop_pos): Rename local to
1333 avoid shadowing.
b246f932
PE
1334 (composition_reseat_it): Remove unused locals.
1335 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 1336 (composition_update_it): Mark var as initialized.
11b61122
PE
1337 (find_automatic_composition): Mark vars as initialized,
1338 with a FIXME (Bug#8290).
8f5201ae 1339
760fbc2c
PE
1340 character.h: Rename locals to avoid shadowing.
1341 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
1342 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
1343 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
1344 (BUF_DEC_POS): Be more systematic about renaming local temporaries
1345 to avoid shadowing.
1346
ff08eb85
PE
1347 * textprop.c (property_change_between_p): Remove; unused.
1348
fc7bf025
PE
1349 * intervals.c (interval_start_pos): Now static.
1350
235d7abc
PE
1351 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
1352
44f230aa
SM
1353 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
1354 Rename locals to avoid shadowing.
3e7d6594 1355
50060332
PE
1356 * sound.c (wav_play, au_play, Fplay_sound_internal):
1357 Fix pointer signedness.
d01f234b 1358 (alsa_choose_format): Remove unused local var.
c83b8872
PE
1359 (wav_play): Initialize a variable to 0, to prevent undefined
1360 behavior (Bug#8278).
50060332 1361
c4fc4e30
PE
1362 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
1363
918436ed
PE
1364 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
1365
c939f91b
PE
1366 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
1367 clobbering (Bug#8298).
b9c7f648
PE
1368 * sysdep.c (sys_subshell): Likewise.
1369 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 1370
6bd8c144
PE
1371 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
1372 This should get cleaned up, so that child_setup has the
1373 same signature on all platforms.
1374
7710357c 1375 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 1376 (relocate_fd): Rename locals to avoid shadowing.
7710357c 1377
c59da222
CY
13782011-03-22 Chong Yidong <cyd@stupidchicken.com>
1379
1380 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
1381 not to be necessary, and produces flickering.
1382
66b87493
GM
13832011-03-20 Glenn Morris <rgm@gnu.org>
1384
1385 * config.in: Remove file.
1386
45b6f6d5
JB
13872011-03-20 Juanma Barranquero <lekktu@gmail.com>
1388
1389 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
1390 are now in src/globals.h.
1391 (syms_of_minibuf): Remove spurious & from previous change.
1392
3ec03f7e
LL
13932011-03-20 Leo <sdl.web@gmail.com>
1394
1395 * minibuf.c (completing-read-function): New variable.
1396 (completing-read-default): Rename from completing-read.
1397 (completing-read): Call completing-read-function.
1398
b14e3e21
CY
13992011-03-19 Juanma Barranquero <lekktu@gmail.com>
1400
1401 * xfaces.c (Fx_load_color_file):
1402 Read color file from absolute filename (bug#8250).
1403
f2b726e6
JB
14042011-03-19 Juanma Barranquero <lekktu@gmail.com>
1405
1406 * makefile.w32-in: Update dependencies.
1407
09f6ff02
EZ
14082011-03-17 Eli Zaretskii <eliz@gnu.org>
1409
1410 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
1411
29a6015a
PE
14122011-03-17 Paul Eggert <eggert@cs.ucla.edu>
1413
a3a6c54e
PE
1414 Fix more problems found by GCC 4.5.2's static checks.
1415
b766f867
PE
1416 * process.c (make_serial_process_unwind, send_process_trap):
1417 (sigchld_handler): Now static.
1418
be02381c
PE
1419 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
1420 That way, the code declares only the vars that it needs.
1421 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
1422 * s/cygwin.h (PTY_ITERATION): Likewise.
1423 * s/darwin.h (PTY_ITERATION): Likewise.
1424 * s/gnu-linux.h (PTY_ITERATION): Likewise.
1425
57048744
PE
1426 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
1427 * process.c (allocate_pty): Don't declare stb unless it's needed.
1428
7914961c 1429 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
1430 (CONSTANTLIM): Remove; unused.
1431 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
1432 Define only if needed.
7914961c 1433
b3967b18
PE
1434 * unexelf.c (unexec): Name an expression,
1435 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
1436 Use a different way to cause a compilation error if anyone uses
1437 n rather than nn, a way that does not involve shadowing.
73366a00 1438 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 1439
29a6015a
PE
1440 * deps.mk (unexalpha.o): Remove; unused.
1441
43cfc33e 1442 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 1443 * unexec.h: New file.
ce701a33
PE
1444 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
1445 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
1446 Depend on unexec.h.
1447 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
1448 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
1449 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 1450 Change as necessary to match prototype in unexec.h.
ce701a33 1451
01f44d5a
PE
1452 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
1453 shadowing.
4f63c6bb 1454 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 1455
a6670b0b
PE
1456 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
1457 Rename locals to avoid shadowing.
1458
cef2010d 1459 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 1460 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 1461
d4d7173a
PE
1462 * print.c (Fredirect_debugging_output): Fix pointer signedess.
1463
f08b802a
PE
1464 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
1465 warning when compiling print.c.
1466
3ddb0639
PE
1467 * font.c (font_unparse_fcname): Abort in an "impossible" situation
1468 instead of using an uninitialized var.
5ad03b97 1469 (font_sort_entities): Mark var as initialized.
3ddb0639 1470
170a2692
PE
1471 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
1472
e663c700
PE
1473 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
1474 pointers to constants.
89bc529a 1475 (font_parse_fcname): Remove unused vars.
7b81e2d0 1476 (font_delete_unmatched): Now static.
ea838e10 1477 (font_get_spec): Remove; unused.
13a547c6
PE
1478 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
1479 (font_update_drivers, Ffont_get_glyphs, font_add_log):
1480 Rename or move locals to avoid shadowing.
e663c700 1481
2a80c887 1482 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 1483 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 1484
1384fa33 1485 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 1486 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 1487
8b2c52e9
PE
1488 * alloc.c (mark_backtrace): Move decl from here ...
1489 * lisp.h: ... to here, so that it can be checked.
1490
475545b5 1491 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 1492 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
1493 (lisp_indirect_variable): Name an expression,
1494 to avoid gcc -Wbad-function-cast warning.
1faed8ae 1495 (Fdefvar): Rename locals to avoid shadowing.
475545b5 1496
b1349114 1497 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 1498 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 1499 Use const pointer when appropriate.
b1349114 1500
a2928364
PE
1501 * lisp.h (get_system_name, get_operating_system_release):
1502 Move decls here, to check interfaces.
1503 * process.c (get_operating_system_release): Move decl to lisp.h.
1504 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
1505 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
1506 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
1507 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
1508 (Fformat_time_string, Fencode_time, Finsert_char):
1509 (Ftranslate_region_internal, Fformat):
1510 Rename or remove local vars to avoid shadowing.
9710023e 1511 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 1512
a415e694
PE
1513 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
1514 avoid shadowing.
1515
8ef4622d
PE
1516 * lisp.h (eassert): Check that the argument compiles, even if
1517 ENABLE_CHECKING is not defined.
1518
946f9a5b
PE
1519 * data.c (Findirect_variable): Name an expression, to avoid
1520 gcc -Wbad-function-cast warning.
112396d6 1521 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 1522 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
1523 (Fmake_variable_buffer_local, Fmake_local_variable):
1524 Mark variables as initialized.
52746918 1525 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 1526
e5aab7e7 1527 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
1528 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
1529 Rename locals to avoid shadowing.
dff45157
PE
1530 (mark_stack): Move local variables into the #ifdef region where
1531 they're used.
7bc26fdb
PE
1532 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
1533 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
1534 needed otherwise.
1535 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
1536 (GC_STRING_CHARS): Remove; not used.
d40d4be1 1537 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 1538
e5aab7e7
PE
1539 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
1540 avoids undefined behavior in theory.
1541
4da60324
PE
1542 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
1543
88043301
PE
1544 Use functions, not macros, for up- and down-casing (Bug#8254).
1545 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1546 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
1547 to use the following functions instead of these macros.
1548 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
1549 EMACS_INT, since callers assume the returned value fits in int.
1550 (upcase1): Likewise, for UPCASE_TABLE.
1551 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 1552 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 1553 the race-condition problem in the old DOWNCASE.
88043301 1554
19ed5445
PE
1555 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
1556 Rename locals to avoid shadowing.
1557 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
1558 (regex_compile, re_search_2, re_match_2_internal):
1559 Remove unused local vars.
952db0d7
PE
1560 (FREE_VAR): Rewrite so as not to use empty "else",
1561 which gcc can warn about.
da053e48 1562 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
1563 (RETALLOC_IF): Define only if needed.
1564 (WORDCHAR_P): Likewise. This one is never needed, but is used
1565 only in a comment talking about a compiler bug, so put inside
1566 the #if 0 of that comment.
1567 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
1568 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
1569 Remove; unused.
19ed5445 1570
1f3561e4 1571 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
1572 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
1573 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 1574
ded6f8f7
PE
1575 * search.c (simple_search): Remove unused var.
1576
dbd37a95
PE
1577 * dired.c (compile_pattern): Move decl from here ...
1578 * lisp.h: ... to here, so that it can be checked.
1579 (struct re_registers): New forward decl.
1580
7e47afad
PE
1581 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
1582
85f24f61
PE
1583 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
1584 All uses changed.
1585 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
1586 Rename locals to avoid shadowing.
5671df8f 1587 (Fvertical_motion): Mark locals as initialized.
85f24f61 1588
181aa2be 1589 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 1590 (casify_region): Mark local as initialized.
181aa2be 1591
930d429c
PE
1592 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
1593
7082eac6
PE
1594 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
1595 New macros, so that the caller can use some names other than
1596 gcpro1, gcpro2, etc.
1597 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
1598 of the new macros.
1599 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
1600 argument, for consistency with GCPRO2_VAR, etc: it is now the
1601 prefix of the variable, not the variable itself. All uses
1602 changed.
38b2c076
PE
1603 * dired.c (directory_files_internal, file_name_completion):
1604 Rename locals to avoid shadowing.
1605
15206ed9
PE
1606 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
1607 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
1608 dired.c's scmp function, had undefined behavior.
1609 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1610 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
1611 * buffer.h: ... to here, because these macros use current_buffer,
1612 and the new implementation with inline functions needs to have
1613 current_buffer in scope now, rather than later when the macros
1614 are used.
1615 (downcase, upcase1): New static inline functions.
1616 (DOWNCASE, UPCASE1): Reimplement using these functions.
1617 This avoids undefined behavior in expressions like
1618 DOWNCASE (x) == DOWNCASE (y), which previously suffered
1619 from race conditions in accessing the global variables
1620 case_temp1 and case_temp2.
1621 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
1622 * lisp.h (case_temp1, case_temp2): Remove their decls.
1623 * character.h (ASCII_CHAR_P): Move from here ...
1624 * lisp.h: ... to here, so that the inline functions mentioned
1625 above can use them.
1626
4a6bea26
PE
1627 * dired.c (directory_files_internal_unwind): Now static.
1628
f14b7e14
PE
1629 * fileio.c (file_name_as_directory, directory_file_name):
1630 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
1631 Now static.
2893f146
PE
1632 (file_name_as_directory): Use const pointers when appropriate.
1633 (Fexpand_file_name): Likewise. In particular, newdir might
1634 point at constant storage, so make it a const pointer.
fd4ead52 1635 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
1636 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
1637 signedness issues.
f839df0c
PE
1638 (Fset_file_times, Finsert_file_contents, auto_save_error):
1639 Rename locals to avoid shadowing.
f14b7e14 1640
5716756e 1641 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
1642 (Ftry_completion, Fall_completions): Rename or remove locals
1643 to avoid shadowing.
5716756e 1644
b4c3046a
PE
1645 * marker.c (bytepos_to_charpos): Remove; unused.
1646
b45db522
PE
1647 * lisp.h (verify_bytepos, count_markers): New decls,
1648 so that gcc does not warn that these functions aren't declared.
1649
85876d07
PE
1650 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
1651 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 1652 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 1653 (copy_text): Remove unused local var.
85876d07 1654
03d78a21 1655 * filelock.c (within_one_second): Now static.
b3dd38ab 1656 (lock_file_1): Rename local to avoid shadowing.
03d78a21 1657
5df8f01b
PE
1658 * buffer.c (fix_overlays_before): Mark locals as initialized.
1659 (fix_start_end_in_overlays): Likewise. This function should be
1660 simplified by using pointers-to-pointers, but that's a different
1661 matter.
b1d876f1 1662 (switch_to_buffer_1): Now static.
8f54f30a
PE
1663 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
1664 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 1665
a70072c9 1666 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 1667 Fix pointer signedness issue.
edced198
PE
1668 (sys_subshell): Mark local as volatile if checking for lint,
1669 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 1670 (MAXPATHLEN): Define only if needed.
a70072c9 1671
a0977c44
PE
1672 * process.c (serial_open, serial_configure): Move decls from here ...
1673 * systty.h: ... to here, so that they can be checked.
1674
a884fdcc
PE
1675 * fns.c (get_random, seed_random): Move extern decls from here ...
1676 * lisp.h: ... to here, so that they can be checked.
1677
604efe86 1678 * sysdep.c (reset_io): Now static.
b8950c94 1679 (wait_for_termination_signal): Remove; unused.
604efe86 1680
38fc62d9
PE
1681 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
1682 (copy_keymap_item, append_key, push_text_char_description):
1683 Now static.
1004a21a 1684 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 1685 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
1686 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
1687 (describe_map_tree):
1688 Rename locals to avoid shadowing.
38fc62d9 1689
2f2650da
PE
1690 * keyboard.c: Declare functions static if they are not used elsewhere.
1691 (echo_char, echo_dash, cmd_error, top_level_2):
1692 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
1693 (read_char, kbd_buffer_get_event, make_lispy_position):
1694 (make_lispy_event, make_lispy_movement, apply_modifiers):
1695 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
1696 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
1697 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 1698 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 1699 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 1700
a053e86c 1701 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
1702 (mark_kboards): Move decl here ...
1703 * alloc.c (mark_kboards): ... from here.
a053e86c 1704
4752793e
PE
1705 * lisp.h (force_auto_save_soon): New decl.
1706
74f10ca7 1707 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
1708 (DEFINE_DUMMY_FUNCTION): New macro.
1709 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
1710 Use it.
c03cd23f
PE
1711 (main): Add casts to avoid warnings
1712 if GCC considers string literals to be constants.
74f10ca7 1713
022e70d4
PE
1714 * lisp.h (fatal_error_signal): Add decl, since it's exported.
1715
59d6fe83
PE
1716 * dbusbind.c: Pointer signedness fixes.
1717 (xd_signature, xd_append_arg, xd_initialize):
1718 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1719 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1720 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
1721 (Fdbus_register_signal): Use SSDATA when the context wants char *.
1722
78320123
PE
1723 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
1724 if GCC considers string literals to be constants.
49cebcca 1725 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 1726
35ac2a97
SM
17272011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
1728
fb103ca9
SM
1729 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
1730 (print_preprocess, print_object): New macro to fix last change.
1731
35ac2a97
SM
1732 * print.c (print_preprocess): Don't forget font objects.
1733
62973b41
JB
17342011-03-16 Juanma Barranquero <lekktu@gmail.com>
1735
1736 * emacs.c (USAGE3): Doc fixes.
1737
0e48bb22
AS
17382011-03-15 Andreas Schwab <schwab@linux-m68k.org>
1739
1740 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
1741 structure.
1742
7684e57b
JB
17432011-03-14 Juanma Barranquero <lekktu@gmail.com>
1744
1745 * lisp.h (VWindow_system, Qfile_name_history):
1746 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
1747 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
1748 (w32_system_caret_x, w32_system_caret_y): Declare extern.
1749
1750 * w32select.c: Don't #include "keyboard.h".
c96bbc66 1751 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
1752
1753 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
1754 * w32console.c (detect_input_pending, read_input_pending)
1755 (encode_terminal_code):
1756 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
1757 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
1758 (w32_system_caret_y, Qfile_name_history):
1759 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
1760 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
1761 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
1762 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
1763 * w32proc.c (Qlocal, report_file_error):
1764 * w32term.c (Vwindow_system, updating_frame):
1765 * w32uniscribe.c (initialized, uniscribe_font_driver):
1766 Remove unneeded extern declarations.
1767
2aa46d6c
CY
17682011-03-14 Chong Yidong <cyd@stupidchicken.com>
1769
c96bbc66 1770 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 1771
cffc6f3b
CY
17722011-03-13 Chong Yidong <cyd@stupidchicken.com>
1773
1774 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
1775 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
1776 These macros can no longer be used for assignment.
1777
44f230aa
SM
1778 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1779 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
1780 (record_buffer_markers, fetch_buffer_markers): New functions for
1781 recording and fetching special buffer markers.
1782 (set_buffer_internal_1, set_buffer_temp): Use them.
1783
1784 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
1785
1786 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
1787
1788 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
1789 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
1790
1791 * xdisp.c (hscroll_window_tree):
1792 (reconsider_clip_changes): Use PT instead of BUF_PT.
1793
d251f04b
EZ
17942011-03-13 Eli Zaretskii <eliz@gnu.org>
1795
1796 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
1797 $(EMACS_ROOT)/lib/intprops.h.
1798
f0c77cd1
PE
17992011-03-13 Paul Eggert <eggert@cs.ucla.edu>
1800
3eca4629
PE
1801 Fix more problems found by GCC 4.5.2's static checks.
1802
7c86ee98
PE
1803 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
1804 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
1805 (xg_free_frame_widgets): Make it clear that a local variable is
1806 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
1807 (gdk_window_get_screen): Make it clear that this macro is needed
1808 only if USE_GTK_TOOLTIP.
1e5524e7
PE
1809 (int_gtk_range_get_value): New function, which avoids a diagnostic
1810 from gcc -Wbad-function-cast.
1811 (xg_set_toolkit_scroll_bar_thumb): Use it.
1812 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
1813 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
1814 (get_utf8_string, xg_get_file_with_chooser):
1815 Rename locals to avoid shadowing.
1816 (create_dialog): Move locals to avoid shadowing.
7c86ee98 1817
41729b81
PE
1818 * xgselect.c (xg_select): Remove unused var.
1819
f0c77cd1
PE
1820 * image.c (four_corners_best): Mark locals as initialized.
1821 (gif_load): Initialize transparent_p to zero (Bug#8238).
1822 Mark another local as initialized.
ec6cf4c6 1823 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 1824
ce0ad53d 1825 * image.c (clear_image_cache): Now static.
d5d5a617 1826 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 1827 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
1828 (x_edge_detection): Remove unnecessary cast that
1829 gcc -Wbad-function-cast diagnoses.
2037898d 1830 (gif_load): Fix pointer signedness.
6ae141d6
PE
1831 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
1832 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 1833
33383987 18342011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 1835
d32df629
PE
1836 Improve quality of tests for time stamp overflow.
1837 For example, without this patch (encode-time 0 0 0 1 1
1838 1152921504606846976) returns the obviously-bogus value (-948597
1839 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
1840 reports time overflow. See
1841 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
1842 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
1843 * editfns.c: Include limits.h and intprops.h.
1844 (TIME_T_MIN, TIME_T_MAX): New macros.
1845 (time_overflow): Move earlier, to before first use.
1846 (hi_time, lo_time): New functions, for an accurate test for
1847 out-of-range times.
1848 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
1849 (Fget_internal_run_time): Don't assume time_t fits in int.
1850 (make_time): Use list2 instead of Fcons twice.
1851 (Fdecode_time): More accurate test for out-of-range times.
1852 (check_tm_member): New function.
1853 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
1854 (lisp_time_argument): Don't rely on undefined left-shift and
1855 right-shift behavior when checking for time stamp overflow.
8be6f318 1856
fe31d94c
PE
1857 * editfns.c (time_overflow): New function, refactoring common code.
1858 (Fformat_time_string, Fdecode_time, Fencode_time):
1859 (Fcurrent_time_string): Use it.
1860
8be6f318
PE
1861 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
1862 * dired.c (make_time): Move to ...
1863 * editfns.c (make_time): ... here.
1864 * systime.h: Note the move.
1865
09d9db2c 18662011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 1867
126bc0dc
YM
1868 * fringe.c (update_window_fringes): Remove unused variables.
1869
c47cbdfd
YM
1870 * unexmacosx.c (copy_data_segment): Also copy __got section.
1871 (Bug#8223)
1872
7ac80be9
EZ
18732011-03-12 Eli Zaretskii <eliz@gnu.org>
1874
c96bbc66 1875 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
1876 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
1877 Constify `char *' arguments and their references according to
1878 prototypes in tparam.h.
1879
ecb0f94d 1880 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 1881
7ac80be9
EZ
1882 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
1883 Adapt all references accordingly.
1884
1885 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
1886
ef1fd07e
TT
18872011-03-11 Tom Tromey <tromey@redhat.com>
1888
1889 * buffer.c (syms_of_buffer): Remove obsolete comment.
1890
7ef4b50c
EZ
18912011-03-11 Eli Zaretskii <eliz@gnu.org>
1892
1893 * termhooks.h (encode_terminal_code): Declare prototype.
1894
1895 * msdos.c (encode_terminal_code): Don't declare prototype.
1896
1897 * term.c (encode_terminal_code): Now external again, used by
1898 w32console.c and msdos.c.
1899
44f230aa
SM
1900 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
1901 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 1902
4b1ec863 19032011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 1904
1714f52b 1905 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 1906
4b1ec863
PE
1907 * fringe.c (update_window_fringes): Mark locals as initialized
1908 (Bug#8227).
1909 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 1910
524c7aa6
PE
1911 * alloc.c (mark_fringe_data): Move decl from here ...
1912 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
1913 to check its interface.
1914 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
1915
a5c0af81 1916 * fontset.c (free_realized_fontset): Now static.
7519b8cd 1917 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 1918 (fontset_font): Mark local as initialized.
a9a06e0b 1919 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 1920
b4716021
PE
1921 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
1922
811e9bac 1923 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 1924 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
1925 (x_own_selection, Fx_disown_selection_internal): Rename locals
1926 to avoid shadowing.
1927 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 1928
7e3ab302
PE
1929 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
1930 so that the caller can use some name other than gcpro1.
1931 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
1932 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1933 (Fx_backspace_delete_keys_p):
1934 Use them to avoid shadowing, and rename vars to avoid shadowing.
1935 (x_decode_color, x_set_name, x_window): Now static.
6b437900 1936 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 1937 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
1938 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
1939 Remove unused locals.
7e3ab302
PE
1940 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1941 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
1942 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
1943 macros.
f78faa98 1944
e2b13473
PE
1945 * xterm.h (x_mouse_leave): New decl.
1946
77f23912
PE
1947 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
1948 Remove unused functions.
cdf4ba58
PE
1949 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
1950 (x_calc_absolute_position): Now static.
7411c686 1951 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 1952 Don't declare local "event" unless it's used.
ed7bf3a5
PE
1953 (x_iconify_frame, x_free_frame_resources): Don't declare locals
1954 unless they are used.
38d0b34a
PE
1955 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
1956 (x_fatal_error_signal): Remove; not used.
a6067996
PE
1957 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
1958 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
1959 (x_error_catcher, x_connection_closed, x_error_handler):
1960 (x_error_quitter, xembed_send_message, x_iconify_frame):
1961 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 1962 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 1963 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 1964
44f230aa
SM
1965 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
1966 Rename or move locals to avoid shadowing.
6b463e58 1967 (tty_defined_color, merge_face_heights): Now static.
5967d051 1968 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
1969 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
1970 does not deduce is never used uninitialized.
73719eba
PE
1971 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
1972 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 1973
426994c3 1974 * terminal.c (store_terminal_param): Now static.
5489860b 1975
032f1620 1976 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 1977 (set_frame_menubar): Remove unused local.
d4323972 1978 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
1979 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
1980 since they might point to immutable storage.
281585b0
PE
1981 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
1982 since it's unused otherwise.
032f1620 1983
367c19e5 1984 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 1985 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
1986 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
1987 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 1988 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
1989 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
1990 does not deduce are never used uninitialized.
70739cbe 1991
07b48fa9
PE
1992 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
1993
8868a238 1994 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
1995 * window.c (window_loop, size_window):
1996 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 1997
7e5cf297 1998 * window.c (display_buffer): Now static.
d6550a9f
PE
1999 (size_window): Mark variables that gcc -Wuninitialized
2000 does not deduce are never used uninitialized.
a586633d
PE
2001 * window.h (check_all_windows): New decl, to forestall
2002 gcc -Wmissing-prototypes diagnostic.
5b555da1 2003 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 2004
f6095868
PE
2005 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
2006 shadowing.
2007 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
2008 Include <limits.h>.
2009 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
2010 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
2011 (load_charset_map): Mark variables that gcc -Wuninitialized
2012 does not deduce are never used uninitialized.
53df7c11 2013 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 2014
f38b440c
PE
2015 * coding.c (coding_set_source, coding_set_destination):
2016 Use "else { /* comment */ }" rather than "else /* comment */;"
2017 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
2018 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
2019 a block, when the outer 'i' will do.
2020 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
2021 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
2022 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
2023 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
2024 (Fdecode_sjis_char, Fdefine_coding_system_internal):
2025 Rename locals to avoid shadowing.
2026 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
2027 * coding.c (emacs_mule_char, encode_invocation_designation):
2028 Now static, since they're not used elsewhere.
413bb2db 2029 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 2030 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
2031 (decode_coding_emacs_mule): Mark variables that gcc
2032 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
2033 (detect_coding_iso_2022): Initialize a local variable that might
2034 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 2035 this initialization is needed. (Bug#8211)
5f58e762
PE
2036 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
2037 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
2038 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
2039 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
2040 Remove unused macros.
f38b440c 2041
232b38b9 2042 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 2043 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 2044 * character.c (string_count_byte8): Likewise.
232b38b9 2045
fb90da1b
PE
2046 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
2047 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
2048
fb93dbc2
PE
2049 * chartab.c (copy_sub_char_table): Now static, since it's not used
2050 elsewhere.
5c156ace
PE
2051 (sub_char_table_ref_and_range, char_table_ref_and_range):
2052 Rename locals to avoid shadowing.
bbcd0949 2053 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 2054
7d3b3862 2055 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 2056 (BIDI_BOB): Remove unused macro.
7d3b3862 2057
6be7d3da
PE
2058 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
2059 deduce are never used uninitialized.
c2ed9c8b 2060 * term.c (encode_terminal_code): Likewise.
6be7d3da 2061
75f8807f 2062 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 2063
50938595
PE
2064 * tparam.h: New file.
2065 * term.c, tparam.h: Include it.
2066 * deps.mk (term.o, tparam.o): Depend on tparam.h.
2067 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
2068 Move these decls to tparam.h, and make them agree with what
2069 is actually in tparam.c. The previous trick of using incompatible
2070 decls in different modules does not conform to the C standard.
2071 All callers of tparam changed to use tparam's actual API.
2072 * tparam.c (tparam1, tparam, tgoto):
2073 Use const pointers where appropriate.
2074
fbceeba2
PE
2075 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
2076 * cm.h (struct cm): Likewise.
2077 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
2078 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
2079 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
2080 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
2081 (turn_on_face, init_tty): Likewise.
2082 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 2083
7f3f1250
PE
2084 * term.c (term_mouse_position): Rename local to avoid shadowing.
2085
e6ca6543
PE
2086 * alloc.c (mark_ttys): Move decl from here ...
2087 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
2088
c40f8d15
AS
20892011-03-11 Andreas Schwab <schwab@linux-m68k.org>
2090
2091 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
2092
cfe0661d
JB
20932011-03-09 Juanma Barranquero <lekktu@gmail.com>
2094
2095 * search.c (compile_pattern_1): Remove argument regp, unused since
2096 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
2097 (compile_pattern): Don't pass it.
2098
0afb4571
J
20992011-03-08 Jan Djärv <jan.h.d@swipnet.se>
2100
2101 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
2102 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
2103 for ! HAVE_GTK3.
2104 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
2105
2106 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
2107
2108 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
2109 gdk_window_get_screen, gdk_window_get_geometry,
2110 gdk_x11_window_lookup_for_display and GDK_KEY_g.
2111 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
2112 (xg_get_pixbuf_from_pixmap): New function.
2113 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
2114 to Pixmap, take frame as parameter, remove GdkColormap parameter.
2115 Call xg_get_pixbuf_from_pixmap instead of
2116 gdk_pixbuf_get_from_drawable.
2117 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
2118 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
2119 (xg_check_special_colors): Use GtkStyleContext and its functions
2120 for HAVE_GTK3.
2121 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
2122 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
2123 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
2124 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
2125 Call gtk_widget_get_preferred_size.
0afb4571
J
2126 (xg_frame_resized): gdk_window_get_geometry only takes 5
2127 parameters.
44f230aa
SM
2128 (xg_win_to_widget, xg_event_is_for_menubar):
2129 Call gdk_x11_window_lookup_for_display.
0afb4571
J
2130 (xg_set_widget_bg): New function.
2131 (delete_cb): New function.
2132 (xg_create_frame_widgets): connect delete-event to delete_cb.
2133 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
2134 (xg_set_background_color): Call xg_set_widget_bg.
2135 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
2136 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
2137 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
2138 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
2139 if ! HAVE_GTK3.
2140 (update_frame_tool_bar): Call gtk_widget_hide.
2141 (xg_initialize): Use GDK_KEY_g.
2142
2143 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
2144 if ! HAVE_GTK3
2145 (x_session_initialize): Call gdk_x11_set_sm_client_id.
2146
2147 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
2148 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
2149 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
2150
1c2cc4ef
JB
21512011-03-08 Juanma Barranquero <lekktu@gmail.com>
2152
2153 * w32xfns.c (select_palette): Check success of RealizePalette against
2154 GDI_ERROR, not zero.
2155
33383987 2156See ChangeLog.11 for earlier changes.
aac0c6e3
MR
2157
2158;; Local Variables:
2159;; coding: utf-8
aac0c6e3
MR
2160;; End:
2161
33383987 2162 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
2163
2164 This file is part of GNU Emacs.
2165
2166 GNU Emacs is free software: you can redistribute it and/or modify
2167 it under the terms of the GNU General Public License as published by
2168 the Free Software Foundation, either version 3 of the License, or
2169 (at your option) any later version.
2170
2171 GNU Emacs is distributed in the hope that it will be useful,
2172 but WITHOUT ANY WARRANTY; without even the implied warranty of
2173 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
2174 GNU General Public License for more details.
2175
2176 You should have received a copy of the GNU General Public License
2177 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.