Fix the build after leim-related changes.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
6114eb15
AS
12012-04-21 Andreas Schwab <schwab@linux-m68k.org>
2
3 * lisp.mk (lisp): Update.
4
2f38dff7
PE
52012-04-20 Paul Eggert <eggert@cs.ucla.edu>
6
7 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
8 It is never used otherwise.
9
4ae29f89
SM
102012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
11
12 * print.c (print_preprocess): Only check print_depth if print-circle
13 is nil.
14 (print_object): Check for cycles even when print-circle is nil and
15 print-gensym is t, but only check print_depth if print-circle is nil.
16
f30d612a
CY
172012-04-20 Chong Yidong <cyd@gnu.org>
18
19 * process.c (wait_reading_process_output): If EIO occurs on a pty,
20 set the status to "failed" and ensure that sentinel is run.
21
c07a4c0b 222012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
23
24 * process.c (Fset_process_inherit_coding_system_flag)
25 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 26 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 27
c07a4c0b 282012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
29
30 * xdisp.c (string_buffer_position_lim): Limit starting position to
31 BEGV.
32 (set_cursor_from_row): If called for a mode-line or header-line
33 row, return zero immediately.
34 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
35 farther than the first row after the header line, if any.
36 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
37 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
38
c07a4c0b 392012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 40
4ae29f89
SM
41 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
42 (bug#11238).
ad3a2b41 43
c07a4c0b 442012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 452012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
46
47 configure: new option --enable-gcc-warnings (Bug#11207)
48 * Makefile.in (C_WARNINGS_SWITCH): Remove.
49 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
50 (ALL_CFLAGS): Use new macros rather than old.
51 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
52 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
53 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
54 -Wunused-result, -Wunused-variable. This should go away once
55 the Emacs and Gnulib regex code is merged.
56 (xmalloc, xrealloc): Now static.
57
aba027e8
PE
582012-04-17 Paul Eggert <eggert@cs.ucla.edu>
59
60 * dired.c (Fsystem_groups): Remove unused local.
61
e5a36063
GM
622012-04-17 Glenn Morris <rgm@gnu.org>
63
64 * dired.c (Fsystem_users): Doc fix.
65
316411f0
DA
662012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
67
68 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
69 (syms_of_dired): Add them.
70
9426aba4
PE
712012-04-16 Paul Eggert <eggert@cs.ucla.edu>
72
b62a57be
PE
73 Fix minor alloc.c problems found by static checking.
74 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
75 New extern decls, to avoid calling undeclared functions.
76 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
77 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
78 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
79 (NEED_MEM_INSERT): New macro.
80 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 81 Remove one incorrect comment and fix another.
b62a57be 82
3539f31f
PE
83 Fix minor ralloc.c problems found by static checking.
84 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
85 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
86 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
87 (r_alloc_sbrk): Now static.
88
a041960a
PE
89 Improve ralloc.c interface checking.
90 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
91 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
92 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
93 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
94 [REL_ALLOC]: ... to here, to check interface.
95 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
96 Remove decls. This fixes an "It stinks!".
97
9426aba4
PE
98 * alloc.c (which_symbols): Fix alignment issue / type clash.
99
d55c12ed
AS
1002012-04-15 Andreas Schwab <schwab@linux-m68k.org>
101
102 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
103 (struct Lisp_Misc_Any): Likewise.
104 (struct Lisp_Free): Likewise.
105 * alloc.c (union aligned_Lisp_Symbol): Define.
106 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
107 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
108 (union aligned_Lisp_Misc): Define.
109 (MARKER_BLOCK_SIZE, struct marker_block): Use union
110 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 111 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 112
b948ce8b
PE
1132012-04-14 Paul Eggert <eggert@cs.ucla.edu>
114
115 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
116 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
117 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
118 * s/netbsd.h, s/sol2-6.h:
119 Remove definition of GC_MARK_STACK, since the default now works.
120 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
121 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
122 no longer the default.
123 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
124
35dc09a1 1252012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 126
35dc09a1
GM
127 * lread.c (lisp_file_lexically_bound_p):
128 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 129
35dc09a1
GM
1302012-04-14 Eli Zaretskii <eliz@gnu.org>
131
132 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
133 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
134
1352012-04-14 Jan Djärv <jan.h.d@swipnet.se>
136
137 * nsterm.m (constrainFrameRect): Always constrain when there is only
138 one screen (Bug#10962).
139
bcd86815
KB
1402012-04-13 Ken Brown <kbrown@cornell.edu>
141
142 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
143
c25df26e
RT
1442012-04-13 Reuben Thomas <rrt@sc3d.org>
145
146 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
147
0fc59f1e
DC
1482012-04-11 Daniel Colascione <dancol@dancol.org>
149
150 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
151 against is gone. It's better to use vfork now so that when Cygwin
152 gains a new, working vfork, we use it automatically (bug#10398).
153
de8c03dc
SM
1542012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
155
156 * window.c (save_window_save): Obey window-point-insertion-type.
157
2f097256
GM
1582012-04-11 Glenn Morris <rgm@gnu.org>
159
160 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
161
453b951e
SM
1622012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
163
164 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
165
75f1671a 1662012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
167
168 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
169 (force_quit_count): New var.
170 (handle_interrupt): Use it.
171
2a8ce227
JB
1722012-04-10 Juanma Barranquero <lekktu@gmail.com>
173
174 * w32.c (w32_delayed_load): Record the full path of the library
175 being loaded (bug#10424).
176
935396c0
GM
1772012-04-09 Glenn Morris <rgm@gnu.org>
178
05920a43
GM
179 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
180 not just in the obarray, before snarfing them. (Bug#11036)
181
935396c0
GM
182 * Makefile.in ($(leimdir)/leim-list.el):
183 Pass EMACS rather than BUILT_EMACS.
184
a18ecafa
TZ
1852012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
186
187 * process.c (make_process):
188 * process.h: Add integer `gnutls_handshakes_tried' member to
189 process struct.
190
6bbef4e5
JC
191 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
192 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
193
194 * gnutls.c (gnutls_log_function2i): Convenience log function.
195 (emacs_gnutls_read): Use new log functions,
196 `gnutls_handshakes_tried' process member, and
197 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
198 attempts per process (connection).
199
b4d3bc10
CY
2002012-04-09 Chong Yidong <cyd@gnu.org>
201
202 * eval.c (Fuser_variable_p, user_variable_p_eh)
203 (lisp_indirect_variable): Functions deleted.
204 (Fdefvar): Caller changed.
205
206 * callint.c (Finteractive, Fcall_interactively):
207 * minibuf.c (Fread_variable): Callers changed.
208
70f4d973
EZ
2092012-04-09 Eli Zaretskii <eliz@gnu.org>
210
211 * xdisp.c (set_cursor_from_row): If the display string appears in
212 the buffer at position that is closer to point than the position
213 after the display string, display the cursor on the first glyph of
214 the display string. Fixes cursor display when a 'display' text
215 property immediately follows invisible text. (Bug#11094)
216
cb3c2e3e
PE
2172012-04-09 Paul Eggert <eggert@cs.ucla.edu>
218
219 composite.c: use 'double' consistently
220 * composite.c (get_composition_id): Use 'double' consistently
221 instead of converting 'float' to 'double' and vice versa; this is
222 easier to understand and avoids a GCC warning.
223
fd06db5d
GM
2242012-04-09 Glenn Morris <rgm@gnu.org>
225
50fe702a
GM
226 * Makefile.in: Generate leim-list with bootstrap-emacs, in
227 preparation for dumping it with emacs. (Bug#4789)
228 (leimdir): New variable.
229 ($(leimdir)/leim-list.el): New rule.
230 (emacs$(EXEEXT)): Depend on leim-list.el.
231
fd06db5d
GM
232 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
233 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
234 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
235
55c131ee
AS
2362012-04-08 Andreas Schwab <schwab@linux-m68k.org>
237
238 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
239 proper alignment.
240
9209588f
JB
2412012-04-07 Juanma Barranquero <lekktu@gmail.com>
242
243 * xml.c (init_libxml2_functions) [WINDOWSNT]:
244 Remove unused local variable.
245
e3fb2efb
PE
2462012-04-07 Paul Eggert <eggert@cs.ucla.edu>
247
248 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
249 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
250 (mark_memory): Mark Lisp_Objects only if pointers might hide in
251 objects, as mark_maybe_pointer will catch them otherwise.
252 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
253 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
254
b5385551
PE
2552012-04-07 Paul Eggert <eggert@cs.ucla.edu>
256
257 Fix typo that broke non-Windows builds.
258 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
259
9078ead6
EZ
2602012-04-07 Eli Zaretskii <eliz@gnu.org>
261
262 Support building on MS-Windows with libxml2.
263
264 * makefile.w32-in (OBJ2): Add xml.$(O).
265 (GLOBAL_SOURCES): Add xml.c.
266 ($(BLD)/xml.$(O)): New dependency list.
267
268 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
269 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
270 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
271 [!WINDOWSNT]: New macros.
272 (init_libxml2_functions, libxml2_loaded_p): New functions.
273 (parse_region): Call fn_xmlCheckVersion instead of using the macro
274 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
275 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
276 Calls xmlCleanupParser only if libxml2 was loaded (or statically
277 linked in).
6bbef4e5
JC
278 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
279 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
280 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
281
282 * emacs.c: Don't include libxml/parser.h.
283 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
284 xmlCleanupParser directly.
285
286 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
287
3811fdf3
EZ
2882012-04-07 Eli Zaretskii <eliz@gnu.org>
289
290 * indent.c (Fvertical_motion): If there is a display string at
291 point, use it.vpos to compute how many lines to backtrack after
292 move_it_to point. (Bug#11133)
293
2f8e16b2
EZ
2942012-04-06 Eli Zaretskii <eliz@gnu.org>
295
296 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
297 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
298 about subtle differences between FETCH_CHAR* and STRING_CHAR*
299 macros related to unification of CJK characters. For the details,
300 see the discussion following the message here:
301 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
302
3d439cd1
CY
3032012-04-04 Chong Yidong <cyd@gnu.org>
304
305 * keyboard.c (Vdelayed_warnings_list): Doc fix.
306
8bc53d00
EZ
3072012-04-01 Eli Zaretskii <eliz@gnu.org>
308
309 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
310 instead of alloca. (Bug#11138)
311
3b0512a3
AS
3122012-04-01 Andreas Schwab <schwab@linux-m68k.org>
313
314 * w32menu.c (is_simple_dialog): Properly check lisp types.
315 (Bug#11141)
316
8427ddd2
EZ
3172012-03-31 Eli Zaretskii <eliz@gnu.org>
318
979022ef
EZ
319 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
320 position we get to after a call to move_it_to fails the
321 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
322 only if we wind up in a string from display property. (Bug#11063)
323
a6b1c7cc
EZ
324 * window.c (Fdelete_other_windows_internal): Invalidate the row
325 and column information about mouse highlight, so that redisplay
326 restores it after reallocating the glyph matrices. (Bug#7464)
327
8427ddd2
EZ
328 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
329 string comes from a `display' text property, use the buffer
330 position of that property as if we actually saw that position in
331 the row's glyphs.
697ba24b
EZ
332 (move_it_by_lines): Remove the assertion that
333 "it->current_x == 0 && it->hpos == 0" which can be legitimately
334 violated when there's a before-string at the beginning of a line.
335 (Bug#11063)
8427ddd2 336
65a0a738
EZ
3372012-03-30 Eli Zaretskii <eliz@gnu.org>
338
339 * xdisp.c (append_space_for_newline): If the default face was
340 remapped, use the remapped face for the appended newline.
341 (extend_face_to_end_of_line): Use the remapped default face for
342 extending the face to the end of the line.
343 (display_line): Call extend_face_to_end_of_line when the default
344 face was remapped. (Bug#11068)
345
581355cc
EZ
3462012-03-29 Eli Zaretskii <eliz@gnu.org>
347
348 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
349
e8fc049f
SM
3502012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
351
352 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
353
4fb9a543
GM
3542012-03-27 Glenn Morris <rgm@gnu.org>
355
356 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
357 Doc fixes.
358
679910f1
KH
3592012-03-26 Kenichi Handa <handa@m17n.org>
360
361 * dispextern.h (struct glyph): Fix previous change. Change the
362 bit length of glyphless.ch to 25 (Bug#11082).
363
90d49b7f
CY
3642012-03-26 Chong Yidong <cyd@gnu.org>
365
366 * keyboard.c (Vselection_inhibit_update_commands): New variable.
367 (command_loop_1): Use it; inhibit selection update for
368 handle-select-window too (Bug#8996).
369
f514f6f0
FP
3702012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
371
e8fc049f 372 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 373
bf43fa51
KH
3742012-03-25 Kenichi Handa <handa@m17n.org>
375
376 * dispextern.h (struct glyph): Change the bit length of
377 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
378
8a0c01dd
EZ
3792012-03-24 Eli Zaretskii <eliz@gnu.org>
380
381 * s/ms-w32.h (tzname): Include time.h before redirecting to
382 _tzname. Fixes the MSVC build. (Bug#9960)
383
7d1c3a76
AS
3842012-03-24 Andreas Schwab <schwab@linux-m68k.org>
385
8ed79523
AS
386 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
387 characters.
388
7d1c3a76
AS
389 * xterm.c (XTread_socket): Only modify handling_signal if
390 !SYNC_INPUT. (Bug#11080)
391
e99a9b8b
EZ
3922012-03-23 Eli Zaretskii <eliz@gnu.org>
393
394 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
395 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
396 when fetching a multibyte character consumes more bytes than
397 CHAR_BYTES returns, due to unification of CJK characters in
398 string_char. (Bug#11073)
399
5063c0e1
TN
4002012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
401
402 * process.c (wait_reading_process_output): Handle pty disconnect
403 by refraining from sending oneself a SIGCHLD (bug#10933).
404
9f851fbd
CY
4052012-03-22 Chong Yidong <cyd@gnu.org>
406
407 * dispextern.h (struct it): New member string_from_prefix_prop_p.
408
5063c0e1 409 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
410 Mark string as coming from a prefix property.
411 (handle_face_prop): Use default face for prefix strings (Bug#4281).
412 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
413
fb5b8aca
CY
4142012-03-21 Chong Yidong <cyd@gnu.org>
415
416 * xfaces.c (Vface_remapping_alist): Doc fix.
417
62356a1b
EZ
4182012-03-20 Eli Zaretskii <eliz@gnu.org>
419
420 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
421 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
422 Doc fixes.
62356a1b 423
025de85b
CY
4242012-03-20 Chong Yidong <cyd@gnu.org>
425
426 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
427 to reflect default non-nil value of redisplay-dont-pause.
428
4827f94e
KH
4292012-03-19 Kenichi Handa <handa@m17n.org>
430
431 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
432 it fit in a valid range (Bug#11003).
433
e50a24a2
EZ
4342012-03-18 Eli Zaretskii <eliz@gnu.org>
435
436 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
437 that is not from display property, accept the row as a "cursor
438 row" if one of the string's character has a non-nil `cursor'
439 property. Fixes cursor positioning when there are newlines in
440 overlay strings, e.g. in icomplete.el. (Bug#11035)
441
9af5ed87
PE
4422012-03-12 Paul Eggert <eggert@cs.ucla.edu>
443
444 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
445
d1f55f16
CY
4462012-03-12 Chong Yidong <cyd@gnu.org>
447
448 * eval.c (inhibit_lisp_code): Rename from
449 inhibit_window_configuration_change_hook; move from window.c.
450
451 * xfns.c (unwind_create_frame_1, Fx_create_frame):
452 * window.c (run_window_configuration_change_hook)
453 (syms_of_window): Callers changed.
454
66c5eebd
CY
4552012-03-11 Chong Yidong <cyd@gnu.org>
456
413df973
CY
457 * keymap.c (Fkey_description): Doc fix (Bug#9700).
458
66c5eebd
CY
459 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
460
1de11f56
CY
4612012-03-10 Chong Yidong <cyd@gnu.org>
462
463 * frame.c (other_visible_frames): Don't assume the selected frame
464 is visible (Bug#10955).
465
cae07000
SM
4662012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
467
468 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
469
89c94350
JD
4702012-03-08 Jan Djärv <jan.h.d@swipnet.se>
471
472 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
473 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
474 zero (Bug#10954).
475
999dd333
GM
4762012-03-03 Glenn Morris <rgm@gnu.org>
477
01a6dcc8 478 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 479
de0100f2
EZ
4802012-03-02 Eli Zaretskii <eliz@gnu.org>
481
482 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
483 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
484 (redisplay_window, next_element_from_string): Fix typos in
485 comments.
3e441275
EZ
486 (redisplay_window): Pass to move_it_vertically the margin in
487 pixels, not in screen lines.
de0100f2 488
96a72ee9
GM
4892012-03-02 Glenn Morris <rgm@gnu.org>
490
491 * buffer.c (buffer-list-update-hook): Doc fix.
492
312508d7
EZ
4932012-02-29 Eli Zaretskii <eliz@gnu.org>
494
495 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
496 push_it before setting up the iterator for the first overlay
497 string, even if we have an empty string loaded.
498 (next_overlay_string): If there's an empty string on the iterator
499 stack, pop the stack. (Bug#10903)
500
27f3c637
PE
5012012-02-25 Paul Eggert <eggert@cs.ucla.edu>
502
503 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
504 Suggested by Stefan Monnier in
505 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
506 * alloc.c (widen_to_Lisp_Object): New static function.
507 (mark_memory): Also mark Lisp_Objects by fetching pointer words
508 and widening them to Lisp_Objects. This would work even if
509 USE_LSB_TAG is defined and wide integers are used, which might
510 happen in a future version of Emacs.
511
3c9dfce6
CY
5122012-02-25 Chong Yidong <cyd@gnu.org>
513
fa74b241
CY
514 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
515 Doc fix.
516
3c9dfce6
CY
517 * xselect.c (Fx_selection_exists_p): Doc fix.
518 (x_clipboard_manager_save_all): Print an informative message
519 before saving to clipboard manager.
520
9486df08
CY
5212012-02-24 Chong Yidong <cyd@gnu.org>
522
523 * keyboard.c (process_special_events): Handle all X selection
524 requests in kbd_buffer, not just the next one (Bug#8869).
525
f01d3321
CY
5262012-02-23 Chong Yidong <cyd@gnu.org>
527
528 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
529 call when setting menu-bar-lines and tool-bar-lines parameters.
530 (unwind_create_frame_1): New helper function.
531
532 * window.c (inhibit_window_configuration_change_hook): New var.
533 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 534 (syms_of_window): Initialize it.
f01d3321 535
86b847b6
CY
5362012-02-22 Chong Yidong <cyd@gnu.org>
537
538 * xterm.c (x_draw_image_relief): Add missing type check for
539 Vtool_bar_button_margin (Bug#10743).
540
a59225b1
CY
5412012-02-21 Chong Yidong <cyd@gnu.org>
542
543 * fileio.c (Vfile_name_handler_alist): Doc fix.
544
545 * buffer.c (Fget_file_buffer): Protect against invalid file
546 handler return value.
547
310f5bd4
PE
5482012-02-20 Paul Eggert <eggert@cs.ucla.edu>
549
cb3a28cc
PE
550 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
551 when computing $valmask.
552
310f5bd4
PE
553 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
554 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
555 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
556 It's useless in that case, and it can cause problems on hosts
557 that allocate halves of EMACS_INT values separately.
558 Reported by Dan Horák. Diagnosed by Andreas Schwab in
559 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
560 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
561 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
562 it avoids undefined behavior on hosts where shifting right by more
563 than the word width has undefined behavior.
564
2375c96a
CY
5652012-02-19 Chong Yidong <cyd@gnu.org>
566
567 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
568 (Funhandled_file_name_directory, Ffile_name_as_directory)
569 (Fdirectory_file_name, Fexpand_file_name)
570 (Fsubstitute_in_file_name): Protect against invalid file handler
571 return values (Bug#10845).
572
3eb49e71
EZ
5732012-02-18 Eli Zaretskii <eliz@gnu.org>
574
575 * .gdbinit (pitx): Fix incorrect references to fields of the
576 iterator stack.
577
7b926f3f
CY
5782012-02-17 Chong Yidong <cyd@gnu.org>
579
580 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
581
11273115
PE
5822012-02-15 Paul Eggert <eggert@cs.ucla.edu>
583
584 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
585 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
586
c3a70e2b
CY
5872012-02-15 Chong Yidong <cyd@gnu.org>
588
589 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
590 marked as special. Also, starting docstrings with * is obsolete.
591
0ca43699
AS
5922012-02-13 Andreas Schwab <schwab@linux-m68k.org>
593
594 * gnutls.c (emacs_gnutls_write): Fix last change.
595
2e8f3c56
LI
5962012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
597
598 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
599 send_process.
600
af70074f
SM
6012012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
602
603 * keymap.c (Fsingle_key_description): Handle char ranges.
604
95986d52
CY
6052012-02-12 Chong Yidong <cyd@gnu.org>
606
afd83bd1
CY
607 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
608 as that creates a dangerous corner case.
609
95986d52
CY
610 * window.c (Fdelete_window_internal): Invalidate the mouse
611 highlight (Bug#9904).
612
bd7da63e
GM
6132012-02-12 Glenn Morris <rgm@gnu.org>
614
615 * xselect.c (Fx_own_selection_internal)
616 (Fx_get_selection_internal, Fx_disown_selection_internal)
617 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
618 * nsselect.m (Fx_own_selection_internal)
619 (Fx_disown_selection_internal, Fx_selection_exists_p)
620 (Fx_selection_owner_p, Fx_get_selection_internal):
621 Sync docs and argument specs with the xselect.c versions.
622
77abcbc2
LI
6232012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
624
625 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
626
90b671e2
EZ
6272012-02-11 Eli Zaretskii <eliz@gnu.org>
628
1c0ca0b7
EZ
629 * w32select.c (Fx_selection_exists_p): Sync doc string and
630 argument list with xselect.c. (Bug#10783)
631
632 * w16select.c (Fx_selection_exists_p): Sync doc string and
633 argument list with xselect.c. (Bug#10783)
90b671e2 634
49241268
GM
6352012-02-10 Glenn Morris <rgm@gnu.org>
636
637 * fns.c (Fsecure_hash): Doc fix.
638
f998bbe7 6392012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
640
641 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
642
0992bd9c
CY
6432012-02-07 Chong Yidong <cyd@gnu.org>
644
645 * buffer.c (Fbuffer_local_variables)
646 (buffer_lisp_local_variables): Handle unbound vars correctly;
647 don't let Qunbound leak into Lisp.
648
af008560
GM
6492012-02-07 Glenn Morris <rgm@gnu.org>
650
dd605cc4
GM
651 * image.c (Fimagemagick_types): Doc fix.
652
af008560
GM
653 * image.c (imagemagick-render-type): Change it from a lisp object
654 to an integer. Move the doc here from the lisp manual.
655 Treat all values not equal to 0 the same.
656
1449fa1d
CY
6572012-02-06 Chong Yidong <cyd@gnu.org>
658
659 * doc.c (store_function_docstring): Avoid applying docstring of
660 alias to base function (Bug#2603).
661
3723ec07
AS
6622012-02-04 Andreas Schwab <schwab@linux-m68k.org>
663
664 * .gdbinit (pp1, pv1): Remove redundant defines.
665 (pr): Use pp.
666
79c1cc1e
CY
6672012-02-04 Chong Yidong <cyd@gnu.org>
668
669 * nsterm.m: Declare a global (Bug#10694).
670
d7f29f8e
EZ
6712012-02-04 Eli Zaretskii <eliz@gnu.org>
672
cae07000
SM
673 * w32.c (get_emacs_configuration_options):
674 Include --enable-checking, if specified, in the return value.
d7f29f8e 675
3b95a6f9
MR
6762012-02-04 Martin Rudalics <rudalics@gmx.at>
677
678 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
679 after rounding frame sizes. (Bug#9723)
680
d6fa96a6
EZ
6812012-02-04 Eli Zaretskii <eliz@gnu.org>
682
683 * keyboard.c (adjust_point_for_property): Don't position point
684 before BEGV. (Bug#10696)
685
df0b2940
PE
6862012-02-03 Paul Eggert <eggert@cs.ucla.edu>
687
688 Handle overflow when computing char display width (Bug#9496).
689 * character.c (char_width): Return EMACS_INT, not int.
690 (char_width, c_string_width): Check for overflow when
691 computing the width; this is possible now that individual
692 characters can have unbounded width. Problem introduced
693 by merge from Emacs 23 on 2012-01-19.
694
6bee44d6
MA
6952012-02-02 Michael Albinus <michael.albinus@gmx.de>
696
697 * dbusbind.c (Fdbus_register_method): Mention the return value
698 :ignore in the docstring.
699
44f92739
GM
7002012-02-02 Glenn Morris <rgm@gnu.org>
701
1b9f60cc
GM
702 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
703
44f92739
GM
704 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
705 Unconditionally set to t. (Bug#10673)
706 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
707 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
708 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
709
c5d3843c
KH
7102012-02-02 Kenichi Handa <handa@m17n.org>
711
712 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
713 0, do not call append_composite_glyph.
714
159462d4 7152012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
716
717 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
718 NULL (Bug#6988).
719 (x_produce_glyphs): If the component of a composition is a null
720 string, set it->pixel_width to 1 to avoid zero-width glyph.
721
78cef877
EZ
7222012-02-01 Eli Zaretskii <eliz@gnu.org>
723
724 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
725 first 2 arguments are identical. This makes inserting large
726 output from a subprocess an order of magnitude faster on
727 MS-Windows, where all sbrk'ed memory is always contiguous.
728
97897668
GM
7292012-01-31 Glenn Morris <rgm@gnu.org>
730
731 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 732 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
733 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
734
31fd3586
GM
7352012-01-29 Glenn Morris <rgm@gnu.org>
736
737 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
738
0e24a8b2
CY
7392012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
740
741 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
742
cc0adcb0
CY
7432012-01-28 Chong Yidong <cyd@gnu.org>
744
745 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
746
acc28cb9
CY
7472012-01-26 Chong Yidong <cyd@gnu.org>
748
9c69cfb7
CY
749 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
750
acc28cb9
CY
751 * search.c (Fsearch_forward, Fsearch_backward): Document negative
752 repeat counts (Bug#10507).
753
48da7392
GM
7542012-01-26 Glenn Morris <rgm@gnu.org>
755
756 * lread.c (syms_of_lread): Doc fix.
757
14af5f7f
CY
7582012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
759
760 * coding.c (encode_designation_at_bol): Change return value to
761 EMACS_INT.
762
0b21c100
CY
7632012-01-25 Chong Yidong <cyd@gnu.org>
764
765 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
766
3c2907f7
CY
7672012-01-21 Chong Yidong <cyd@gnu.org>
768
769 * floatfns.c (Fcopysign): Make the second argument non-optional,
770 since nil is not allowed anyway.
771
959ad23f
AS
7722012-01-21 Andreas Schwab <schwab@linux-m68k.org>
773
774 * process.c (read_process_output): Use p instead of XPROCESS (proc).
775 (send_process): Likewise.
776
34a02f46
MR
7772012-01-19 Martin Rudalics <rudalics@gmx.at>
778
779 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
780 (Vwindow_persistent_parameters): Do not use Qstate.
781 Rewrite doc-strings.
34a02f46 782
1259009a 7832012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
784
785 * character.c (char_width): New function.
70d4fdf6
GM
786 (Fchar_width, c_string_width, lisp_string_width):
787 Use char_width (Bug#9496).
25ed9e61 788
6a6ee00d
MR
7892012-01-16 Martin Rudalics <rudalics@gmx.at>
790
791 * window.c (Vwindow_persistent_parameters): New variable.
792 (Fset_window_configuration, save_window_save): Handle persistent
793 window parameters.
794
c85efaf7
EZ
7952012-01-14 Eli Zaretskii <eliz@gnu.org>
796
797 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
798 thrashing the stack of the thread. (Bug#9087)
799
5944709e
PE
8002012-01-12 Paul Eggert <eggert@cs.ucla.edu>
801
802 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
803
e71f5d99
EZ
8042012-01-11 Eli Zaretskii <eliz@gnu.org>
805
806 * xdisp.c (rows_from_pos_range): Handle the case where the
807 highlight ends on a newline. (Bug#10464)
808 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
809 he end column for display of highlight that ends on a newline
810 before a R2L line.
811
ce316182
GM
8122012-01-11 Glenn Morris <rgm@gnu.org>
813
814 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
815 from load-path also when installation-directory is nil. (Bug#10208)
816
5b43da69
GM
8172012-01-10 Glenn Morris <rgm@gnu.org>
818
74cc8ff9
GM
819 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
820
7d8d6e4e
GM
821 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
822 Update template values to be closer to their typical values these days.
5b43da69 823
a0db8d43
EZ
8242012-01-09 Eli Zaretskii <eliz@gnu.org>
825
826 * xdisp.c (rows_from_pos_range): Accept additional argument
827 DISP_STRING, and accept any glyph in a row whose object is that
828 string as eligible for mouse highlight. Fixes mouse highlight of
829 display strings from overlays. (Bug#10464)
830
9a0115ab 8312012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 832
b9110d6a 833 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
834 * fileio.c (auto_saving_dir_umask): New static var.
835 (Fmake_directory_internal): Use it.
836 (do_auto_save_make_dir): Set it, instead of invoking chmod after
837 creating the directory. The old code temporarily assigns
838 too-generous permissions to the directory.
839 (do_auto_save_eh): Clear it.
b9110d6a 840 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
841 that the var is always cleared.
842
6c1bd3f3
EZ
8432012-01-07 Eli Zaretskii <eliz@gnu.org>
844
845 * search.c (scan_buffer): Pass character positions to
846 know_region_cache, not byte positions. (Bug#6540)
847
069d2b50
L
8482012-01-07 LynX <_LynX@bk.ru> (tiny change)
849
850 * w32.c (sys_rename): Report EXDEV when rename of a directory
851 fails because the target is on another logical disk. (Bug#10284)
852
75bf0d33
DB
8532012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
854
855 * xterm.c (x_embed_request_focus): New function.
856
857 * xterm.h: Add prototype.
858
859 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
860
1c6e5a32
GM
8612012-01-05 Glenn Morris <rgm@gnu.org>
862
863 * emacs.c (emacs_copyright): Update short copyright year to 2012.
864
651e947e
EZ
8652012-01-01 Eli Zaretskii <eliz@gnu.org>
866
867 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
868 Load gnutls_transport_set_lowat only if GnuTLS version is below
869 2.11.1.
870 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
871 GnuTLS versions below 2.11.1.
872
3778cdd8
AL
8732011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
874
875 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
876 to the doc string advising against its use for altering the way
877 windows are scrolled.
878
0e5317f7
KH
8792011-12-28 Kenichi Handa <handa@m17n.org>
880
881 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
882 coding-system ASCII compatible only when it does not produce BOM
883 on encoding (Bug#10383).
884
93d5ca1f
JD
8852011-12-26 Jan Djärv <jan.h.d@swipnet.se>
886
887 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
888 can scroll.
889 (create_and_show_popup_menu): Always use menu_position_func for
890 Gtk3 (Bug#10361).
891
ca22b785
AS
8922011-12-24 Andreas Schwab <schwab@linux-m68k.org>
893
894 * callint.c (Fcall_interactively): Don't truncate prompt string.
895
d048e1e6
EZ
8962011-12-23 Eli Zaretskii <eliz@gnu.org>
897
898 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
899 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 900 resumed from there (after widening). (Bug#10360)
d048e1e6 901
5ccaba1f
JD
9022011-12-22 Jan Djärv <jan.h.d@swipnet.se>
903
904 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
905
204ee57f
JD
9062011-12-21 Jan Djärv <jan.h.d@swipnet.se>
907
b81d40f0
JB
908 * nsterm.m (x_free_frame_resources):
909 Release f->output_data.ns->miniimage.
204ee57f
JD
910 (ns_index_color): Fix indentation. Do not retain
911 color_table->colors[i].
912
913 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
914 before returning.
915
916 * nsfns.m (x_set_background_color): Assign return value from
917 ns_index_color to face-background instead of NSColor*.
918 (ns_implicitly_set_icon_type): Fix indentation.
919 Change assignment in for loop to comparison.
920
921 * emacs.c (ns_pool): New variable.
922 (main): Assign ns_pool.
923 (Fkill_emacs): Call ns_release_autorelease_pool.
924
925 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
926 autorelease fdesc, release fdAttrs and tdict.
927 (ns_get_covering_families): Release charset.
928 (ns_findfonts): Release NSFontDescriptor created with new.
929 (ns_uni_to_glyphs): Fix indentation.
930 (setString): Release attrStr before assigning new value.
931
c803b2b7
JD
9322011-12-18 Jan Djärv <jan.h.d@swipnet.se>
933
678f4426
JD
934 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
935 and NS_IMPL_COCOA.
936 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
937 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
938
cd394be1 9392011-12-18 David Reitter <reitter@cmu.edu>
678f4426 940
5fecd5fc
JD
941 * nsterm.m (ns_term_init): Subscribe for notifications
942 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
943 to method trackingNotification in EmacsMenu.
944
945 * nsmenu.m (trackingMenu): New variable.
3771cb17 946 (trackingNotification): New method (from Aquamacs).
5fecd5fc 947 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 948 from Aquamacs (Bug#7030).
678f4426
JD
949
9502011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 951
c803b2b7
JD
952 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
953 (symbol_to_nsstring): Fix indentation.
954 (ns_symbol_to_pb): New function.
cae07000
SM
955 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
956 (Fns_rotate_cut_buffers_internal): Remove.
957 (Fns_store_selection_internal): Rename from
c803b2b7
JD
958 Fns_store_cut_buffer_internal.
959 (ns_get_foreign_selection, Fx_own_selection_internal)
960 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
961 (Fns_get_selection_internal, Fns_store_selection_internal):
962 Use ns_symbol_to_pb and check if return value is nil.
963 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
964 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
965 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
966 renamed to Sns_store_selection_internal.
967 (ns_handle_selection_request): Move code to Fx_own_selection_internal
968 and remove this function.
969 (ns_handle_selection_clear): Remove, never used.
970 (Fx_own_selection_internal): Move code from ns_handle_selection_request
971 here.
972
e1b01a3a
KB
9732011-12-17 Ken Brown <kbrown@cornell.edu>
974
975 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
976 GID is unknown (Bug#10257).
977
2adb6e85
PE
9782011-12-17 Paul Eggert <eggert@cs.ucla.edu>
979
980 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
981 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
982 which caused a build failure on GNU/Linux IA-64. This problem was
983 introduced by my 2011-10-07 patch.
984
d1d7b339
JL
9852011-12-15 Juri Linkov <juri@jurta.org>
986
987 * image.c (imagemagick_error): New function. (Bug#10112)
988 (imagemagick_load_image): Comment out `MagickSetResolution' call.
989 Use `imagemagick_error' where ImageMagick functions return
990 `MagickFalse'.
991 (Fimagemagick_types): Add `Fnreverse' to return the list in the
992 proper order.
993
100d5755
KH
9942011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
995
996 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
997 fill background (Bug#8992).
998
454592a6
MR
9992011-12-13 Martin Rudalics <rudalics@gmx.at>
1000
1001 * window.c (Vwindow_combination_resize)
1002 (Vwindow_combination_limit): Use t instead of non-nil in
1003 doc-strings.
61d4b438
MR
1004 (Vrecenter_redisplay): Add first sentence of doc-string on
1005 separate line.
53524d93 1006 (Frecenter): Fix doc-string typo.
454592a6 1007
3633e3aa
KH
10082011-12-11 Kenichi Handa <handa@m17n.org>
1009
1010 * coding.c (Funencodable_char_position): Pay attention to the
1011 buffer text relocation (Bug#9389).
1012
7b9d523a
JD
10132011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1014
1015 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
1016 gtk_init (Bug#10100).
1017
b73189c6
EZ
10182011-12-10 Eli Zaretskii <eliz@gnu.org>
1019
1020 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
1021 IT->string is nil. (Bug#10263)
1022
f7dfe5d6
JD
10232011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1024
83faebb4
JD
1025 * nsterm.h (x_free_frame_resources): Declare.
1026
f7dfe5d6
JD
1027 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
1028 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
1029
1030 * nsterm.h (ns_get_defaults_value): Declare.
1031
1032 * nsterm.m (ns_default): Call ns_get_defaults_value.
1033
7cd4e72c
EZ
10342011-12-09 Eli Zaretskii <eliz@gnu.org>
1035
1036 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
1037 (Bug#10170)
1038
b34d7317
YM
10392011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1040
1041 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
1042 that where the value of an _OBJC_* symbol points to is in the .bss
1043 section (Bug#10240).
1044
76470ad1
KH
10452011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1046
1047 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 1048 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 1049
745fff94
KH
10502011-12-08 Kenichi Handa <handa@m17n.org>
1051
1052 * ftfont.c (get_adstyle_property): Fix previous change
1053 (Bug#10233).
1054
6e44397c
JB
10552011-12-07 Juanma Barranquero <lekktu@gmail.com>
1056
1057 * w32.c (init_environment): If no_site_lisp, remove site-lisp
1058 dirs from the default value of EMACSLOADPATH (bug#10208).
1059
7efa6272
GM
10602011-12-07 Glenn Morris <rgm@gnu.org>
1061
1062 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
1063 installation and source directories as well. (Bug#10208)
1064
f6fc4d87
CY
10652011-12-06 Chong Yidong <cyd@gnu.org>
1066
1067 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
1068
2bf26180
GM
10692011-12-06 Glenn Morris <rgm@gnu.org>
1070
1071 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
1072 as an error, not just -1. (Bug#10217)
1073
3a6ad4f0
CY
10742011-12-05 Chong Yidong <cyd@gnu.org>
1075
1076 * keyboard.c (process_special_events): New function.
1077 (swallow_events, Finput_pending_p): Use it (Bug#10195).
1078
75a3b399
PE
10792011-12-05 Paul Eggert <eggert@cs.ucla.edu>
1080
1081 * coding.c (encode_designation_at_bol): Don't use uninitialized
1082 local variable (Bug#9318).
1083
c3c9e25e
KH
10842011-12-05 Kenichi Handa <handa@m17n.org>
1085
1086 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
1087 return Qnil (Bug#8046, Bug#10193).
1088
5eb05ea3
KH
10892011-12-05 Kenichi Handa <handa@m17n.org>
1090
1091 * coding.c (encode_designation_at_bol): New args charbuf_end and
1092 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
1093 (coding_set_source): Return how many bytes coding->source was
1094 relocated.
1095 (coding_set_destination): Return how many bytes
1096 coding->destination was relocated.
1097 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 1098 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
1099
11002011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1101
1102 * coding.c (CODING_CHAR_CHARSET_P): New macro.
1103 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
1104 macro (Bug#9318).
1105
11062011-12-05 Andreas Schwab <schwab@linux-m68k.org>
1107
1108 The following changes are to fix Bug#9318.
1109
a79703f5 1110 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
1111 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
1112 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 1113 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 1114
7dbda6df
JB
11152011-12-05 Juanma Barranquero <lekktu@gmail.com>
1116
1117 * lisp.h (process_quit_flag): Fix external declaration.
1118
6d5eb5b0
SM
11192011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
1120
1121 Don't macro-inline non-performance-critical code.
1122 * eval.c (process_quit_flag): New function.
1123 * lisp.h (QUIT): Use it.
1124
a0c3fad0
JD
11252011-12-04 Jan Djärv <jan.h.d@swipnet.se>
1126
1127 * nsfns.m (get_geometry_from_preferences): New function.
1128 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
1129
6c07aac2
AS
11302011-12-04 Andreas Schwab <schwab@linux-m68k.org>
1131
1132 * emacs.c (Qkill_emacs): Define.
1133 (syms_of_emacs): Initialize it.
1134 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
1135 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
1136 (quit_throw_to_read_char): Add parameter `from_signal'.
1137 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
1138 * lisp.h (QUIT): Call Fkill_emacs if requested.
1139
c052ead4
JD
11402011-12-03 Jan Djärv <jan.h.d@swipnet.se>
1141
1142 * widget.c (update_wm_hints): Return if wmshell is null.
1143 (widget_update_wm_size_hints): New function.
1144
1145 * widget.h (widget_update_wm_size_hints): Declare.
1146
1147 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1148 widget_update_wm_size_hints (Bug#10104).
1149
9e49252b
EZ
11502011-12-03 Eli Zaretskii <eliz@gnu.org>
1151
1152 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1153 before a newline, prepare the bidi iterator for consuming the
1154 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 1155 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 1156
02b16839
JL
11572011-12-02 Juri Linkov <juri@jurta.org>
1158
1159 * search.c (Fword_search_regexp): New Lisp function created from
1160 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1161 (Fword_search_backward, Fword_search_forward)
1162 (Fword_search_backward_lax, Fword_search_forward_lax):
1163 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1164 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1165
0068070e
SM
11662011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1167
1168 * fileio.c (Finsert_file_contents): Move after-change-function call
1169 to before the "handled:" label, since all "goto handled" appear in
1170 cases where the *-change-functions have already been properly called
1171 (bug#10117).
1172
3360a3fc
AS
11732011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1174
1175 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1176 waiting for input. (Bug#10169)
1177
73d6c093
EZ
11782011-11-30 Eli Zaretskii <eliz@gnu.org>
1179
1180 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1181 verifies glyph row's hash code--we have just reallocated the
1182 glyphs, so their contents can be complete garbage. (Bug#10164)
1183
febe6bea
JB
11842011-11-30 Juanma Barranquero <lekktu@gmail.com>
1185
1186 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1187
801a4313
EZ
11882011-11-30 Eli Zaretskii <eliz@gnu.org>
1189
1190 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1191 attributes are tested _before_ calling verify_row_hash, to protect
1192 against GCC re-ordering of the tests. (Bug#10164)
1193
2b56b87e
JD
11942011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1195
1196 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1197
1198 * xterm.c (handle_one_xevent): Only set async_visible and friends
1199 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 1200 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
1201 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1202
dbf31225
PE
12032011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1204
1205 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1206 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1207 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1208 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1209 All uses changed to use GCPRO1 etc.
1210 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1211 Revert to old implementation (i.e., before 2011-03-11).
1212
1305621b
YM
12132011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1214
1215 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1216 of scroll runs so as to avoid assigning disabled bogus rows and
1217 unnecessary graphics copy operations.
1218
8c9afb46
EZ
12192011-11-27 Eli Zaretskii <eliz@gnu.org>
1220
1221 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1222 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1223 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1224 (malloc, free, realloc, calloc): Redirect to e_* only when
1225 compiling Emacs.
1226
1227 * lisp.h (GCTYPEBITS): Move before first use.
1228 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1229 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1230 this macro definition.
1231
1232 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1233 _MSC_VER.
1234
54e9e3bf
JD
12352011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1236
6d5eb5b0
SM
1237 * gtkutil.c (xg_create_frame_widgets):
1238 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
1239 present with Gtk+ 2.0.
1240
83aca1cb
PE
12412011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1242
1243 * fileio.c (Finsert_file_contents): Undo previous change; see
1244 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1245
5b76caa4
PE
12462011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1247
1248 Rename locals to avoid shadowing.
1249 * fileio.c (Finsert_file_contents):
1250 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1251 * process.c (wait_reading_process_output):
1252 Rename inner 'proc' to 'p' to avoid shadowing.
1253 Indent for consistency with usual Emacs style.
1254
8c535114
EZ
12552011-11-25 Eli Zaretskii <eliz@gnu.org>
1256
1257 * xdisp.c (redisplay_window): If cursor row is not fully visible
1258 after recentering, and scroll-conservatively is set to a large
1259 number, scroll window by a few more lines to make the cursor fully
1260 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
1261 (start_display): Don't move to the next line if the display should
1262 start at a newline that is part of a display vector or an overlay
1263 string. (Bug#10119)
8c535114 1264
fa4fdb5c
JL
12652011-11-24 Juri Linkov <juri@jurta.org>
1266
1267 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1268 after the `MagickPingImage' call. (Bug#10112)
1269
90ec88df
CY
12702011-11-23 Chong Yidong <cyd@gnu.org>
1271
1272 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1273
56e2e794
MR
12742011-11-23 Martin Rudalics <rudalics@gmx.at>
1275
1276 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1277 making another buffer current. (Bug#10114)
1278
b6e64c41
GM
12792011-11-23 Glenn Morris <rgm@gnu.org>
1280
1281 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1282
6b21de18
CY
12832011-11-23 Chong Yidong <cyd@gnu.org>
1284
1285 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1286 using it (Bug#5984).
1287
b12cd789
EZ
12882011-11-22 Eli Zaretskii <eliz@gnu.org>
1289
1290 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1291 and header-lines, as they don't have one computed for them.
1292 (Bug#10098)
1293
1294 * .gdbinit (prow): Make displayed values more self-explaining.
1295 Add row's hash code.
1296
261b6fd4
LMI
12972011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1298
1299 * process.c (wait_reading_process_output): Fix asynchrounous
1300 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 1301 (wait_reading_process_output): Add comment and URL.
261b6fd4 1302
e7cfd277
JD
13032011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1304
1305 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1306
a9b9b7f5
CY
13072011-11-21 Chong Yidong <cyd@gnu.org>
1308
1309 * window.c (Fnext_window, Fprevious_window): Doc fix.
1310
b0d15b4f
SM
13112011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1312
1313 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1314
fe7a3057
JB
13152011-11-20 Juanma Barranquero <lekktu@gmail.com>
1316
1317 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1318
d2999b1a
MR
13192011-11-20 Martin Rudalics <rudalics@gmx.at>
1320
1321 * window.c (Fset_window_combination_limit): Rename argument
1322 STATUS to LIMIT.
1323 (Vwindow_combination_limit): Remove "status" from doc-string.
1324
d5ff9cd0
AS
13252011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1326
1327 * m/ibms390.h: Remove.
1328 * m/ibms390x.h: Don't include "ibms390.h".
1329
a5bb9bd3
SM
13302011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1331
1332 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1333 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1334
cd1181db
JB
13352011-11-20 Juanma Barranquero <lekktu@gmail.com>
1336
1337 * casetab.c (Fset_case_table):
1338 * charset.c (Fcharset_after): Fix typos.
1339
615a3b8d 13402011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 1341
17e845af
PE
1342 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1343 Otherwise, valgrind does not work on some platforms.
1344 Problem reported by Andreas Schwab in
6a0bf43d
PE
1345 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1346 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1347 is set, removing the need for VIRT_ADDRESS_VARIES.
1348 (PURE_P): Use a more-efficient implementation that needs just one
1349 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1350 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1351 to 4 (xorl, subq, cmpq, setbe).
1352 * alloc.c (pure): Always extern now, since that's the
1353 VIRT_ADDR_VARIES behavior.
1354 (PURE_POINTER_P): Use a single comparison, not two, for
1355 consistency with the new puresize.h.
1356 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1357 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1358 Remove VIRT_ADDR_VARIES no longer needed.
1359
f8fe6f96
EZ
13602011-11-19 Eli Zaretskii <eliz@gnu.org>
1361
1362 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1363 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1364 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1365 behave as if the cursor position were at the window margin.
1366
1367 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1368 and the cursor position is out of bounds, behave as if the cursor
1369 position were at the window margin. (Bug#10075)
1370
df05a53c
CY
13712011-11-18 Chong Yidong <cyd@gnu.org>
1372
1373 * window.c (Fwindow_combination_limit): Make first argument
1374 non-optional, since it is meaningless for live windows like the
1375 selected window.
1376
2071918e
DA
13772011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1378
1379 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1380
b50a28de
SM
13812011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1382
1383 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1384 (graft_intervals_into_buffer): Simplify.
1385
015137db
EZ
13862011-11-18 Eli Zaretskii <eliz@gnu.org>
1387
1388 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1389 hash values of the two rows.
1390 (copy_row_except_pointers): Preserve the used[] arrays and the
1391 hash values of the two rows. (Bug#10035)
68c95424 1392 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
1393
1394 * xdisp.c (row_hash): New function, body extracted from
1395 compute_line_metrics.
1396 (compute_line_metrics): Call row_hash, instead of computing the
1397 hash code inline.
1398
1399 * dispnew.c (verify_row_hash): Call row_hash for computing the
1400 hash code of a row, instead of duplicating code from xdisp.c.
1401
1402 * dispextern.h (row_hash): Add prototype.
1403
a2addb04
TH
14042011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1405
1406 * frame.c (delete_frame): Don't delete the terminal when the last
1407 X frame is closed if emacs is built with GTK toolkit.
1408
df85d315
JB
14092011-11-17 Juanma Barranquero <lekktu@gmail.com>
1410
1411 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1412
a0c2d0ae
MR
14132011-11-17 Martin Rudalics <rudalics@gmx.at>
1414
1415 * window.c (Vwindow_splits): Rename to
1416 Vwindow_combination_resize. Suggested by Juri Linkov.
1417 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1418 of Vwindow_splits.
1419
58179cce
JB
14202011-11-16 Juanma Barranquero <lekktu@gmail.com>
1421
7877f373
JB
1422 * nsfns.m (Fns_font_name):
1423 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 1424
b6f67890
MR
14252011-11-16 Martin Rudalics <rudalics@gmx.at>
1426
1427 * window.h (window): Rename slot "nest" to "combination_limit".
1428 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1429 (Fset_window_nest): Rename to Fset_window_combination_limit.
1430 (Vwindow_nest): Rename to Vwindow_combination_limit.
1431 (recombine_windows, make_parent_window, make_window)
1432 (Fsplit_window_internal, saved_window)
1433 (Fset_window_configuration, save_window_save): Rename all
1434 occurrences of window_nest to window_combination_limit.
1435
c7015153
JB
14362011-11-15 Juanma Barranquero <lekktu@gmail.com>
1437
1438 * image.c (imagemagick_load_image): Fix typo.
1439
322ad6ec
EZ
14402011-11-14 Eli Zaretskii <eliz@gnu.org>
1441
1442 * xdisp.c (display_line): Move the call to
1443 highlight_trailing_whitespace before the call to
1444 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
1445 faces of all the glyphs to compute ROW's hash value.
1446 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 1447
f067b8ec
JB
14482011-11-14 Juanma Barranquero <lekktu@gmail.com>
1449
1450 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1451 just return (bug#10044).
1452
1e5b2111
EZ
14532011-11-12 Eli Zaretskii <eliz@gnu.org>
1454
7ef3cbd5
EZ
1455 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1456 with user-defined heap size. Bump the default size of the temacs
1457 heap to 27MB, to avoid memory warning when running temacs.
1458 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1459
1e5b2111
EZ
1460 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1461 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
1462 (verify_row_hash) [XASSERTS]: New function.
1463 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1464 that the hash value of glyph rows is correct.
1e5b2111 1465
89d61221
MR
14662011-11-12 Martin Rudalics <rudalics@gmx.at>
1467
1468 * window.h (window): Remove splits slot.
1469 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1470 (Fdelete_other_windows_internal, make_parent_window)
1471 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1472 (Fset_window_configuration, save_window_save): Don't deal with
1473 split status of windows.
1474 (saved_window): Remove splits slot.
1475 (Vwindow_splits): Rewrite doc-string.
1476
97f18cc8
JD
14772011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1478
1479 * xfns.c (unwind_create_frame):
1480 * nsfns.m (unwind_create_frame):
1481 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1482 Vframe_list (Bug#9999).
1483
22a648b4
DA
14842011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1485
0b381c7e 1486 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 1487
659afede
KH
14882011-11-11 Kenichi Handa <handa@m17n.org>
1489
1490 * callproc.c (Fcall_process): Set the member dst_multibyte of
1491 process_coding.
1492
9ac0394b
KH
14932011-11-11 Johan Bockgård <bojohan@gnu.org>
1494
1495 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1496 avoid a crash (bug#9496).
1497
2fbdc249
CY
14982011-11-09 Chong Yidong <cyd@gnu.org>
1499
1500 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1501 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1502
ac6b1f81
PE
15032011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1504
1505 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1506
09db192c
PE
15072011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1508
1509 Avoid some portability problems by eschewing 'extern inline' functions.
1510 The trivial performance wins aren't worth the portability hassles; see
1511 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1512 et seq.
1513 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1514 (window_box_width, window_box_left, window_box_left_offset)
1515 (window_box_right, window_box_right_offset): Undo previous change,
1516 by removing the "extern"s.
1517 * intervals.c (adjust_intervals_for_insertion)
1518 (adjust_intervals_for_deletion): Undo previous change,
1519 making these static again.
1520 (offset_intervals, temp_set_point_both, temp_set_point)
1521 (copy_intervals_to_string): No longer inline.
1522 * xdisp.c (window_text_bottom_y, window_box_width)
1523 (window_box_height, window_box_left_offset)
1524 (window_box_right_offset, window_box_left, window_box_right)
1525 (window_box): No longer inline.
1526
105216ed
CY
15272011-11-08 Chong Yidong <cyd@gnu.org>
1528
1529 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
1530 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1531 Signal an error if not a live window.
105216ed
CY
1532 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1533 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1534
ae9e237f
JB
15352011-11-07 Juanma Barranquero <lekktu@gmail.com>
1536
1537 * lisp.h (syms_of_abbrev): Remove declaration.
1538 Reported by CHENG Gao <chenggao@royau.me>.
1539
c7aa8333
EZ
15402011-11-07 Eli Zaretskii <eliz@gnu.org>
1541
1542 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1543 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1544 of temacs in GUI mode.
1545
be7f5545
MR
15462011-11-07 Martin Rudalics <rudalics@gmx.at>
1547
1548 * window.h: Declare delete_all_child_windows instead of
1549 delete_all_subwindows.
1550 * window.c (Fwindow_nest, Fset_window_nest)
1551 (Fset_window_new_total, Fset_window_new_normal)
1552 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1553 (delete_all_subwindows): Rename to delete_all_child_windows.
1554 (Fdelete_other_windows_internal, Fset_window_configuration):
1555 Call delete_all_child_windows instead of delete_all_subwindows.
1556 * frame.c (delete_frame): Call delete_all_child_windows instead
1557 of delete_all_subwindows.
1558
ca78dc43
PE
15592011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1560
1561 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1562 This is also needed for porting to any host where GC_MARK_STACK is
1563 not GC_MAKE_GCPROS_NOOPS.
1564 (which_symbols): Use it.
1565
a0241d01
KH
15662011-11-07 Kenichi Handa <handa@m17n.org>
1567
1568 * coding.c (coding_set_destination): Check coding->src_pos only
1569 when coding->src_object is a buffer (bug#9910).
1570
1571 * process.c (send_process): Set the member src_multibyte of coding
1572 to 0 (bug#9911) when sending a unibyte text.
1573
1574 * callproc.c (Fcall_process): Set the member src_multibyte of
1575 process_coding to 0 (bug#9912).
1576
a64bfdfa 15772011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
1578
1579 * xmenu.c (cleanup_widget_value_tree): New function.
1580 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1581 calling free_menubar_widget_value_tree directly (Bug#9830).
1582
cb41b32a
PE
15832011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1584
1585 Fix some portability problems with 'inline'.
1586 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1587 (window_box_width, window_box_left, window_box_left_offset)
1588 (window_box_right, window_box_right_offset): Declare extern.
1589 Otherwise, these inline functions do not conform to C99 and
1590 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1591 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1592 * intervals.c (adjust_intervals_for_insertion)
1593 (adjust_intervals_for_deletion): Now extern, because otherwise the
1594 extern inline functions 'offset_intervals' couldn't refer to it.
1595 (static_offset_intervals): Remove.
1596 (offset_intervals): Rewrite using the old contents of
1597 static_offset_intervals. The old version didn't conform to C99
1598 because an extern inline function contained a reference to an
1599 identifier with static linkage.
1600
b7041366
AS
16012011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1602
1603 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1604 GC.
1605
88a37c4d
EZ
16062011-11-06 Eli Zaretskii <eliz@gnu.org>
1607
1608 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1609 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1610 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1611 return Qleft_to_right.
1612
49745b39
CY
16132011-11-06 Chong Yidong <cyd@gnu.org>
1614
1615 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1616 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1617 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1618 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1619 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1620 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1621 (Fwindow_vscroll): Doc fix.
1622 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1623 argument, since it makes no sense to pass a live window and for
1624 consistency with window-child.
1625
1f05cd82
CS
16262011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1627
1628 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1629 support MSVC.
1630
22610910
JR
16312011-11-05 Jason Rumney <jasonr@gnu.org>
1632
1633 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1634 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1635 fonts (Bug#6029).
1636 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1637 bitwise arithmetic preventing use of unicode-sip and non-truetype
1638 opentype fonts.
1639
a06776b2
EZ
16402011-11-05 Eli Zaretskii <eliz@gnu.org>
1641
3ad924ba
EZ
1642 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1643 "emacs"-only part.
1644
a06776b2
EZ
1645 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1646 initialization code to keep similarity to xfns.c after changes
1647 from 2011-11-05.
1648
c9e7db78
JD
16492011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1650
a97f8f3f
JD
1651 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1652 (unwind_create_frame): New function (Bug#9943).
1653 (Fx_create_frame): Restructure code to be more similar to the one in
1654 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1655 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1656 Move terminal->reference_count++ just before making the frame official
1657 (Bug#9943).
1658
1659 * nsterm.m (x_free_frame_resources): New function.
1660 (x_destroy_window): Move code to x_free_frame_resources.
1661
c9e7db78 1662 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
1663 (Fx_create_frame, x_create_tip_frame):
1664 Move terminal->reference_count++ just before making the frame
75f1671a 1665 official. Move initialization of image_cache_refcount and
c9e7db78
JD
1666 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1667
a6fc3b5c
EZ
16682011-11-05 Eli Zaretskii <eliz@gnu.org>
1669
1670 Support MSVC build with newer versions of Visual Studio.
1671 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1672 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1673 nt/gmake.defs.
1674
1675 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1676 which are not supported by MSVC.
1677 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1678 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1679 bitfields.
1680 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1681 types in bitfields.
1682 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1683
1684 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1685
58179cce 16862011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
1687
1688 Support MSVC build with newer versions of Visual Studio.
1689 * w32.c: Don't include w32api.h for MSVC.
1690 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1691
1692 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1693 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1694 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1695 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1696 e_* cousins.
1697 (alloca) [_MSC_VER]: Define to _alloca.
1698
1699 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1700
1701 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1702
a58c13ed
EZ
17032011-11-04 Eli Zaretskii <eliz@gnu.org>
1704
1705 * xdisp.c (note_mouse_highlight): If either of
1706 previous/next-single-property-change returns nil, treat that as
1707 the beginning or the end of the buffer. (Bug#9955)
1708
fe0b6370
JD
17092011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1710
a58c13ed 1711 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
1712 label is not null (Bug#9951).
1713 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1714 may be NULL.
1715
89bd5ee1
EZ
17162011-11-04 Eli Zaretskii <eliz@gnu.org>
1717
1718 * window.c (Fwindow_body_size): Mention in the doc string that the
1719 return value is in frame's canonical units. (Bug#9949)
1720
84c3edb9
EZ
17212011-11-03 Eli Zaretskii <eliz@gnu.org>
1722
4e2fb5c7
EZ
1723 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1724
84c3edb9 1725 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 1726 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 1727 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 1728
bc17a887
EZ
17292011-11-01 Eli Zaretskii <eliz@gnu.org>
1730
1731 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1732 Don't stop backward scan on the continuation glyph, even though
1733 its CHARPOS is positive.
6d5eb5b0
SM
1734 (mouse_face_from_buffer_pos, note_mouse_highlight):
1735 Rename cover_string to disp_string.
bc17a887 1736
4ee88440
MR
17372011-11-01 Martin Rudalics <rudalics@gmx.at>
1738
1739 * window.c (temp_output_buffer_show): Don't use
1740 Vtemp_buffer_show_specifiers.
1741 (Vtemp_buffer_show_specifiers): Remove unused variable.
1742
c2ff3c02
EZ
17432011-10-30 Eli Zaretskii <eliz@gnu.org>
1744
1745 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1746 past the beginning of the current glyph matrix.
1747
58179cce 17482011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
1749
1750 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1751 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1752 HAVE_GTK3 (Bug#9869).
b77a6a7f 1753
3b574623
JD
1754 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1755 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1756
b77a6a7f
JD
1757 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1758
1759 * xterm.c: Declare x_handle_net_wm_state to return int.
1760 (handle_one_xevent): Check if we are iconified but don't have
1761 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1762 (get_current_wm_state): Return non-zero if not hidden,
1763 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1764 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1765 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1766 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1767
196e41e4
PE
17682011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1769
1770 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1771 so that this new function doesn't get optimized away by a
1772 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1773
021f2e1a
AS
17742011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1775
1776 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1777
8b058d44
EZ
17782011-10-29 Eli Zaretskii <eliz@gnu.org>
1779
1780 Fix the `xbytecode' command.
1781 * .gdbinit (xprintbytestr): New command.
b50a28de 1782 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
1783 (xbytecode): Print the byte-code string as well.
1784
4452fb80
EZ
17852011-10-29 Kim Storm <storm@cua.dk>
1786
8b058d44
EZ
1787 * alloc.c (which_symbols): New function.
1788
21b72067
AS
17892011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1790
1791 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1792 line. (Bug#9903)
1793
83ed7b5c
GM
17942011-10-29 Glenn Morris <rgm@gnu.org>
1795
1796 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1797 Not clear what it was for, and it causes various bugs. (Bug#9839)
1798
5a7a728b
EZ
17992011-10-28 Eli Zaretskii <eliz@gnu.org>
1800
1801 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1802 possible random value that matches one of those tested as
1803 condition to clear the mouse face.
1804
d3d0842f
CY
18052011-10-28 Chong Yidong <cyd@gnu.org>
1806
1807 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1808
31b39d13
DN
18092011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1810
1811 * window.c (make_window): Initialize phys_cursor_on_p.
1812
9aba6043
SM
18132011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1814
1815 * lisp.h (struct Lisp_Symbol): Update comments.
1816
c20992f4
JB
18172011-10-28 Juanma Barranquero <lekktu@gmail.com>
1818
1819 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1820
db4f02f2
EZ
18212011-10-28 Eli Zaretskii <eliz@gnu.org>
1822
1823 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1824 <oslsachem@gmail.com> for helping to debug this.
1825
1826 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1827 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1828 (g_b_init_get_glyph_outline_w): New static variables.
1829 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1830 (GetGlyphOutlineW_Proc): New typedefs.
1831 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
1832 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1833 New functions.
1834 (w32font_open_internal, compute_metrics):
1835 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
1836 instead of calling the "wide" APIs directly.
1837
1838 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1839
1840 * w32.h (syms_of_w32font): Add prototype.
1841
87e68db4
JB
18422011-10-27 Juanma Barranquero <lekktu@gmail.com>
1843
1844 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1845 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1846 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1847 (Fmove_to_window_line): Doc fix.
1848
435c1d67
CY
18492011-10-27 Chong Yidong <cyd@gnu.org>
1850
1851 * process.c (make_process): Set gnutls_state to NULL.
1852
1853 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1854 non-NULL, regardless of GNUTLS_INITSTAGE.
1855 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1856 an error. Set process slots as soon as we allocate them.
1857
1858 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1859
9c6c6f49
CY
18602011-10-27 Chong Yidong <cyd@gnu.org>
1861
9aba6043
SM
1862 * gnutls.c (emacs_gnutls_deinit): New function.
1863 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
1864 (Fgnutls_deinit, Fgnutls_boot): Use it.
1865
1866 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1867 (deactivate_process): Call emacs_gnutls_deinit.
1868
657d08d3
JB
18692011-10-27 Juanma Barranquero <lekktu@gmail.com>
1870
1871 * image.c (x_create_x_image_and_pixmap):
1872 * w32.c (sys_rename, w32_delayed_load):
1873 * w32font.c (fill_in_logfont):
1874 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1875
5430d399
JB
18762011-10-26 Juanma Barranquero <lekktu@gmail.com>
1877
1878 * w32fns.c (w32_default_color_map): New function,
1879 extracted from Fw32_default_color_map.
a7ef684b 1880 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 1881
fe0055fa
PE
18822011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1883
1884 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1885
e6346438
SM
18862011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1887
1888 * keyboard.c (test_undefined): New function (bug#9751).
1889 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1890
e112cc37
ET
18912011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1892
1893 * sysdep.c (init_sys_modes): Fix the check for the controlling
1894 terminal (Bug#6649).
1895
7b5d6677
EZ
18962011-10-20 Eli Zaretskii <eliz@gnu.org>
1897
1898 * dispextern.h (struct bidi_it): New member next_en_type.
1899
1900 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1901 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1902 current character, check also for next_en_type being WEAK_EN.
1903 (bidi_resolve_weak): Don't enter the expensive loop if the current
1904 position is before next_en_pos. Record the bidi type of the first
1905 non-ET, non-BN character we find, in addition to its position.
1906 (bidi_level_of_next_char): Invalidate next_en_type when
1907 next_en_pos is over-stepped.
1908
7da0b018
PE
19092011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1910
1911 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1912 * editfns.c: Rewrite current-time-zone so that it invokes
1913 the equivalent of (format-time-string "%Z") to get the time zone name.
1914 This fixes a bug when the time zone name contains characters that
1915 need converting from the system time locale to Emacs internal format.
1916 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1917 that patch fixed format-time-string to do the conversion, but
1918 I forgot to fix current-time-zone.
1919 (format_time_string): New function, containing most of
1920 what Fformat_time_string used to contain.
1921 (Fformat_time_string): Rewrite in terms of format_time_string.
1922 This doesn't change this function's behavior.
1923 (current-time-zone): Rewrite to use format_time_string.
1924 This fixes the bug reported by Michael Schierl in
1925 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1926 Jason Rumney's 2007-06-07 change worked around this bug, but
1927 didn't fix it.
1928 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1929
8547b010
EZ
19302011-10-19 Eli Zaretskii <eliz@gnu.org>
1931
1932 * xdisp.c (start_display): If the character at POS is displayed
1933 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
1934 (try_window_reusing_current_matrix): If a line ends in a display
1935 vector or the next line starts in a display vector, continue
1936 redrawing the window even though the character position of
1937 start_row was reached.
8547b010
EZ
1938 (Bug#9771, part 2)
1939
4e948d15
CY
19402011-10-18 Chong Yidong <cyd@gnu.org>
1941
1942 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1943 with nobreak-char-display too.
1944
4787455f
EZ
19452011-10-18 Eli Zaretskii <eliz@gnu.org>
1946
1947 Fix part 3 of bug#9771.
1948 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1949 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1950 non-neutral characters if the current character is a paragraph
1951 separator (a.k.a. Newline). This avoids running the same
1952 expensive loop twice, once when we consume the preceding newline
1953 and the other time when the line actually needs to be displayed.
1954 Avoid the loop when we see neutrals on the base embedding level
1955 following a character whose directionality is the same as the
1956 paragraph's. This avoids running the expensive loop when a line
1957 ends in a long sequence of neutrals, like control characters.
1958 Add assertion against STRONG_AL type. Slightly rearrange code
1959 that determines the type of a neutral given the first non-neutral
1960 that follows it.
1961 (bidi_level_of_next_char): Set next_en_pos to zero when
1962 invalidating its info.
1963
2c91f553
EZ
19642011-10-17 Eli Zaretskii <eliz@gnu.org>
1965
1966 * xdisp.c (push_display_prop): Determine whether to record string
1967 or buffer position by IT->string, not by IT->method. Allow
1968 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
1969 (move_it_vertically_backward): Don't look for character position
1970 immediately after the newline when in a continuation line.
1971 (Bug#9771, part 1)
2c91f553 1972
c7b08b0d
MR
19732011-10-15 Martin Rudalics <rudalics@gmx.at>
1974
1975 * window.c (coordinates_in_window): Rewrite and delabelize
1976 vertical border check. (Bug#5357) (Bug#9618)
1977
6b02f655
SM
19782011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1979
1980 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1981 errors in XSetWindowBorder (bug#9310).
1982
81d40c92
DA
19832011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1984
1985 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1986 avoid crash when xmalloc overrun checking is enabled.
1987
d4172c3b
EZ
19882011-10-13 Eli Zaretskii <eliz@gnu.org>
1989
1990 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1991 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1992 cursor motion with <left> and <right> arrow keys.
1993
1994 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1995 some callers set that themselves.
1996
b00eea75
EZ
19972011-10-12 Eli Zaretskii <eliz@gnu.org>
1998
1999 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
2000 display string and the previous row comes from the same string and
2001 is empty. (Bug#9739) (Bug#9738)
2002
8fe012c4
SM
20032011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
2004
2005 * doc.c (get_doc_string): Encode file name (bug#9735).
2006
0074aef2
EZ
20072011-10-12 Eli Zaretskii <eliz@gnu.org>
2008
79beb178
EZ
2009 * bidi.c (bidi_level_of_next_char):
2010 * xdisp.c (get_visually_first_element): Remove old incorrect
2011 comments regarding the Unicode Line Separator character.
2012
0074aef2
EZ
2013 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
2014
6e4b3fbe
DA
20152011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
2016
2017 * alloc.c (Fgc_status): Do not access beyond zombies array
2018 boundary if nzombies > MAX_ZOMBIES.
2019 * alloc.c (dump_zombies): Add missing format specifier.
2020
0324f3af
PE
20212011-10-12 Paul Eggert <eggert@cs.ucla.edu>
2022
b5525cac
PE
2023 * xdisp.c (set_cursor_from_row): Simplify conditionals,
2024 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
2025
0324f3af
PE
2026 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
2027 Some packages use them to denote characters with modifiers.
2028
e9b5f888
AS
20292011-10-11 Andreas Schwab <schwab@linux-m68k.org>
2030
2031 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
2032 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
2033 matching a pp-number. Rename parameter var to var1.
2034
127827c0
SM
20352011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
2036
2037 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
2038
c8fd3bd0
GM
20392011-10-08 Glenn Morris <rgm@gnu.org>
2040
2041 * callint.c (Fcall_interactively): Give a more explicit error for the
2042 'c' case with a non-character input. (Bug#8479)
2043
352ec8ff
EZ
20442011-10-08 Eli Zaretskii <eliz@gnu.org>
2045
03669ccb
EZ
2046 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
2047 lines.
7061c986
EZ
2048 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
2049 lines that are hscrolled on the left.
03669ccb 2050
352ec8ff
EZ
2051 * dispnew.c (buffer_posn_from_coords): Account for a possible
2052 presence of header-line. (Bug#4426)
2053
a66cfb1c
SM
20542011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
2055
6b02f655
SM
2056 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
2057 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 2058
7c5ee88e
PE
20592011-10-07 Paul Eggert <eggert@cs.ucla.edu>
2060
2061 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
2062 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
2063 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
2064 this makes Emacs dump core during garbage collection on rare
2065 occasions. sizeof is obviously inferior to offsetof here, so
2066 stick with offsetof.
2067 (GC_POINTER_ALIGNMENT): New macro.
2068 (mark_memory): Omit 3rd (offset) arg; caller changed.
2069 Don't assume EMACS_INT alignment is the same as pointer alignment.
2070
df1bbe5b
SM
20712011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
2072
2073 * keyboard.c (read_key_sequence_remapped): New var.
2074 (read_key_sequence): Compute remapping in the right buffer.
2075 (command_loop_1): Use read_key_sequence's remapping directly.
2076
51553db6
SM
20772011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
2078
32c1fffd
SM
2079 * dired.c (file_name_completion): Don't expand file name.
2080 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
2081 before checking file name handler.
2082
51553db6
SM
2083 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
2084 they've been requested explicitly (bug#9591).
2085
b6bd1599 20862011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
2087
2088 * keymap.c (Fsingle_key_description): Use make_specified_string
2089 instead of build_string to build string from push_key_description.
2090 (Bug#5193)
2091
f701dc2a
PE
20922011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2093
4222c55d
PE
2094 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
2095 This fixes a Y2038 bug on 64-bit hosts.
2096 * buffer.c (reset_buffer):
2097 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
2098 (Fclear_buffer_auto_save_failure):
2099 Use 0, not -1, to represent an unset failure time, since time_t
2100 might not be signed.
2101
f701dc2a
PE
2102 Remove dependency on glibc malloc internals.
2103 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2104 Move back here from lisp.h, but with their new implementations.
2105 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2106 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
2107 * charset.c (charset_table_init): New static var.
2108 (syms_of_charset): Use it instead of xmalloc. This removes a
2109 dependency on glibc malloc internals. See Eli Zaretskii's comment in
2110 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
2111 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2112 Move back to alloc.c.
2113 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2114 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
2115
9ceebf39
JD
21162011-09-30 Jan Djärv <jan.h.d@swipnet.se>
2117
2118 * nsterm.m (windowDidResize): Call x_set_window_size only when
2119 ns_in_resize is true. Otherwise set pixelwidth/height and
2120 call change_frame_size (Bug#9628).
2121
cb993c58
PE
21222011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2123
3930c88b
PE
2124 Port --enable-checking=all to Fedora 14 x86-64.
2125 * charset.c (syms_of_charset): Also account for glibc malloc's
2126 internal overhead when calculating the initial malloc maximum.
2127
cb993c58
PE
2128 Port --enable-checking=all to Fedora 14 x86.
2129 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2130 Move to lisp.h.
2131 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
2132 (overrun_check_realloc, overrun_check_free):
2133 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
2134 That way, xmalloc returns a properly-aligned pointer even if
2135 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
2136 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
2137 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
2138 into account when calculating the initial malloc maximum.
2139 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2140 Move here from alloc.c, so that charset.c can use it too.
2141 Properly align; the old code wasn't right for common 32-bit hosts
2142 when configured with --enable-checking=all.
2143 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2144 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2145
31bed486
EZ
21462011-09-29 Eli Zaretskii <eliz@gnu.org>
2147
04c70788 2148 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
2149 use EDOM.
2150
fbcaa2f3
EZ
21512011-09-28 Eli Zaretskii <eliz@gnu.org>
2152
2153 * xdisp.c (compute_display_string_end): If there's no display
2154 string at CHARPOS, return -1.
2155
2156 * bidi.c (bidi_fetch_char): When compute_display_string_end
2157 returns a negative value, treat the character as a normal
2158 character not covered by a display string. (Bug#9624)
2159
a239d4e9
JB
21602011-09-28 Juanma Barranquero <lekktu@gmail.com>
2161
2162 * lread.c (Fread_from_string): Fix typo in docstring.
2163
88652fd5
EZ
21642011-09-27 Eli Zaretskii <eliz@gnu.org>
2165
2166 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2167 newline, reseat the iterator instead of bidi-iterating there one
2168 character at a time. (Bug#9610)
32c1fffd
SM
2169 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2170 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 2171
ed497dd4
AS
21722011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2173
2174 * lread.c (readevalloop): Use correct code for NBSP.
2175 (read1): Likewise. (Bug#9608)
2176
b2bf61aa
MA
21772011-09-25 Michael Albinus <michael.albinus@gmx.de>
2178
2179 * dbusbind.c (Fdbus_register_signal): When service is not
2180 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2181
32bbb17c
GM
21822011-09-25 Glenn Morris <rgm@gnu.org>
2183
2184 * buffer.c (truncate-lines): Doc fix.
2185
94e0933e
CY
21862011-09-24 Chong Yidong <cyd@stupidchicken.com>
2187
2188 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2189 (Fset_window_next_buffers): Doc fix.
2190
cddde921
GM
21912011-09-24 Glenn Morris <rgm@gnu.org>
2192
2193 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2194
1260aef1
PE
21952011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2196
25b4bfa0
PE
2197 Fix minor problems found by static checking.
2198 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
2199 * indent.c (Fvertical_motion): Fix == vs = typo.
2200
e3cbd34b
EZ
22012011-09-24 Eli Zaretskii <eliz@gnu.org>
2202
a66cfb1c
SM
2203 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2204 Default value is now t. Doc fix.
6bf7006f 2205
e3cbd34b 2206 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 2207 logic when moving up, not only when moving down. Fix the
e3cbd34b 2208 confusing name and values of the it_overshoot_expected variable;
32c1fffd 2209 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
2210
2211 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2212 CHARPOS is covered by a display string which includes newlines.
2213 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2214 is covered by a display string with embedded newlines.
2215
a3de0cbd
MA
22162011-09-24 Michael Albinus <michael.albinus@gmx.de>
2217
2218 * dbusbind.c (Fdbus_register_signal): Add match rule to
2219 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
2220 (Fdbus_register_method, Vdbus_registered_objects_table):
2221 Fix docstring.
a3de0cbd 2222
b260039d
JM
22232011-09-24 Jim Meyering <meyering@redhat.com>
2224
32c1fffd 2225 do not ignore write error for any output size
b260039d
JM
2226 The previous change was incomplete.
2227 While it makes emacs --batch detect the vast majority of stdout
2228 write failures, errors were still ignored whenever the output size is
2229 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2230 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2231 && echo FAIL: ignored write error
2232 FAIL: ignored write error
2233 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2234 && echo FAIL: ignored write error
2235 FAIL: ignored write error
2236 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2237
8eca8a7c
AS
22382011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2239
2240 * emacs.c (Fkill_emacs): In noninteractive mode exit
2241 non-successfully if a write error occurred on stdout. (Bug#9574)
2242
3341db62
EZ
22432011-09-21 Eli Zaretskii <eliz@gnu.org>
2244
2245 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2246 the xassert test.
2247
2248 * dispextern.h (struct it): Update the comment documenting what
2249 can it->OBJECT be.
2250
8c203dbf
EZ
22512011-09-20 Eli Zaretskii <eliz@gnu.org>
2252
2253 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2254 a display string, extend search for cursor position to end of row.
2255 (find_row_edges): If the row ends in a newline from a display
2256 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2257 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
2258 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2259 non-empty line. Fixes confusing cursor motion with arrow keys at
2260 the beginning of a line that starts with whitespace.
8c203dbf 2261
a4824228
LMI
22622011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2263
2264 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2265 (bug#9493).
2266
33ed493b
CY
22672011-09-18 Chong Yidong <cyd@stupidchicken.com>
2268
2269 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2270 boolean (Bug#9154).
2271
56cd55c8
EZ
22722011-09-18 Eli Zaretskii <eliz@gnu.org>
2273
2274 * xdisp.c (display_line): Record maximum and minimum buffer
2275 positions even if no glyphs were produced (e.g., by a zero-width
2276 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2277 buffer positions that will be removed from the glyph row because
2278 they don't fit.
c02dcedf
EZ
2279 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2280 column is beyond frame width: don't subtract 1 "pixel" when
2281 computing width of the stretch.
3e62b7e0
EZ
2282 (reseat_at_next_visible_line_start): Undo the change made on
2283 2011-09-17 that saved paragraph information and restored it after
2284 the call to `reseat'. (Bug#9545)
56cd55c8 2285
5ed99d36 22862011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
2287
2288 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2289 and turn window cursor on if cleared (Bug#9415).
2290
5ed99d36 22912011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
2292
2293 * search.c (boyer_moore): Take unibyte characters from pattern
2294 literally. (Bug#9458)
2295
9bade7b2
EZ
22962011-09-18 Eli Zaretskii <eliz@gnu.org>
2297
2298 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2299
e5e9d610
PE
23002011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2301
87e4427a
PE
2302 Fix minor problem found by static checking.
2303 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2304 initialized, to pacify gcc -Wuninitialized.
2305
e5e9d610
PE
2306 * fileio.c: Report proper errno when syscall falls.
2307 (Finsert_file_contents): Save and restore errno,
2308 so that report_file_error outputs the correct diagnostic.
2309 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2310
a1674f0b
EZ
23112011-09-18 Eli Zaretskii <eliz@gnu.org>
2312
2313 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2314
fbfb6dd4
EZ
23152011-09-17 Eli Zaretskii <eliz@gnu.org>
2316
2317 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2318 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2319
bb187662
EZ
23202011-09-17 Eli Zaretskii <eliz@gnu.org>
2321
1137e8b8 2322 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 2323 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
2324
2325 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2326 (bidi_find_paragraph_start): Search back for paragraph beginning
2327 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2328 (bidi_move_to_visually_next): Only trigger paragraph-related
2329 computations when the last character is a newline or at EOB, not
2330 just any NEUTRAL_B. (Bug#9470)
2331
bb187662
EZ
2332 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2333 truncated lines if point is covered by a display string. (Bug#9524)
2334
2e621251
PE
23352011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2336
2337 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2338 (cons_to_x_long): New function.
2339 (lisp_data_to_selection_data): Use it. Correct the test for
2340 short-versus-long data; it was negated. Break out of vector
2341 loop, for efficiency, when a long datum is discovered.
2342
91a15bc6
SM
23432011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2344
2345 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2346
b41c3a35
EZ
23472011-09-16 Eli Zaretskii <eliz@gnu.org>
2348
2349 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2350 GCC PR/17406) by declaring this function with external scope.
2351
7812ba2d
PE
23522011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2353
2354 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2355 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2356
cf7edc2a
AS
23572011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2358
2359 * editfns.c (Fformat): Correctly handle text properties on "%%".
2360
bd01620e
EZ
23612011-09-15 Eli Zaretskii <eliz@gnu.org>
2362
2363 * xterm.c (x_draw_composite_glyph_string_foreground):
2364 * w32term.c (x_draw_composite_glyph_string_foreground):
2365 * term.c (encode_terminal_code):
2366 * composite.c (composition_update_it, get_composition_id):
2367 * xdisp.c (get_next_display_element)
2368 (fill_composite_glyph_string): Add comments about special meaning
2369 of TAB characters in a composition.
2370
a02719a3
PE
23712011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2372
2373 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
2374 This occurs when processing a multibyte format.
2375 Problem reported by Wolfgang Jenker.
a02719a3 2376
72589a3c
JB
23772011-09-15 Johan Bockgård <bojohan@gnu.org>
2378
2379 * xdisp.c (try_cursor_movement): Only check for exact match if
2380 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2381
1c14176c
PE
23822011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2383
2384 Remove unused external symbols.
2385 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2386 * xdisp.c (calc_pixel_width_or_height): Now static.
2387 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2388 * indent.c (check_display_width):
2389 * w32term.c: Fix comment to match code.
2390 * xterm.c, xterm.h (x_catching_errors): Remove.
2391
d2eea5b5
PE
23922011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2393
2394 * xselect.c: Use signed conversions more consistently (Bug#9498).
2395 (selection_data_to_lisp_data): Assume incoming selection data are
2396 signed integers, not unsigned. This is to be consistent with
2397 outgoing selection data, which was modified to use signed integers
2398 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2399 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2400 expects long, not unsigned long.
2401
46888499
EZ
24022011-09-14 Eli Zaretskii <eliz@gnu.org>
2403
2404 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2405 computation of loop end. Reported by Johan Bockgård
2406 <bojohan@gnu.org>.
2407
ef8ef9fb
CY
24082011-09-13 Chong Yidong <cyd@stupidchicken.com>
2409
2410 * frame.c (Fother_visible_frames_p): Function deleted.
2411
fa819fed
EZ
24122011-09-12 Eli Zaretskii <eliz@gnu.org>
2413
2414 * indent.c (compute_motion): Process display vector front to back
2415 rather than the other way around. (Bug#2496)
2416
2ba8e008
SM
24172011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2418
2419 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2420
20f53c69
CY
24212011-09-11 Chong Yidong <cyd@stupidchicken.com>
2422
2423 * minibuf.c (Fread_from_minibuffer): Doc fix.
2424
d562d7a4
EZ
24252011-09-11 Eli Zaretskii <eliz@gnu.org>
2426
2427 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2428 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2429
1c4d7f3d
LMI
24302011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2431
2432 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2433 value for non-existent files.
2434
b885bf36
EZ
24352011-09-11 Eli Zaretskii <eliz@gnu.org>
2436
2437 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2438 set its "size" to -1. This will set the modtime_size field of
2439 the corresponding buffer to -1, which is what
2440 verify-visited-file-modtime expects for files that do not exist.
2441 (Bug#9139)
2442
6612f0bf
PE
24432011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2444
2445 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2446 here ...
2447 * lisp.h: ... from here. push_key_description is no longer
2448 defined in keyboard.c, so its declaration should not be in
2449 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2450 logically belongs with push_key_description.
2451
dfb3f755
PE
24522011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2453
2454 * buffer.h: Include <sys/types.h> instead of <time.h>.
2455 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2456 Problem reported by Herbert J. Skuhra.
2457
3134906c
LMI
24582011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2459
2460 * xml.c (parse_region): Make the parsing work for
2461 non-comment-starting XML files again (bug#9144).
2462
8d903f4e
AS
24632011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2464
2465 * image.c (gif_load): Fix calculation of bottom and right corner.
2466 (Bug#9468)
2467
80ad64f4
EZ
24682011-09-10 Eli Zaretskii <eliz@gnu.org>
2469
2470 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2471 redisplay in small windows.
2472
208a048d
EZ
24732011-09-09 Eli Zaretskii <eliz@gnu.org>
2474
2475 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2476
9b1c252e
MR
24772011-09-08 Martin Rudalics <rudalics@gmx.at>
2478
2479 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2480 Operate on live windows only.
2481
2949f33b
JB
24822011-09-08 Juanma Barranquero <lekktu@gmail.com>
2483
2484 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2485
e08dcafd
EZ
24862011-09-07 Eli Zaretskii <eliz@gnu.org>
2487
2488 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2489 only under bidi iteration.
2490
115b96bd
JD
24912011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2492
2493 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2494
c8199d0f
PE
24952011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2496
2497 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2498 Without this fix, the command to link temacs failed due to an
2499 undefined symbol __builtin_isnan. This is because
2500 /usr/include/iso/math_c99.h #defines isnan(x) to
2501 __builtin_isnan(x), but the bundled gcc, which identifies itself
2502 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2503 a __builtin_isnan.
2504 * floatfns.c (isnan): #undef, and then #define to a clone of
2505 what's in data.c.
2506 (Fisnan): Always define, since it's always available now.
2507 (syms_of_floatfns): Always define isnan at the Lisp level.
2508
e39b275c 25092011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
2510
2511 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2512
b2db44d9 25132011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 2514
f4af5137 2515 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
2516 The previous code assumed that file offsets (off_t values) fit in
2517 EMACS_INT variables, which is not true on typical 32-bit hosts.
2518 The code messed up by falsely reporting buffer overflow in cases
2519 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2520 when "big" contains more than 2**29 bytes, even though this
2521 inserts just one byte and does not overflow the buffer.
2522 (Finsert_file_contents): Store file offsets as off_t
2523 values, not as EMACS_INT values. Check for overflow when
2524 converting between EMACS_INT and off_t. When checking for
2525 buffer overflow or for overlap, take the offsets into account.
2526 Don't use EMACS_INT for small values where int suffices.
2527 When checking for overlap, fix a typo: ZV was used where
2528 ZV_BYTE was intended.
2529 (Fwrite_region): Don't assume off_t fits into 'long'.
2530 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2531
ecfc0a49
MA
25322011-09-05 Michael Albinus <michael.albinus@gmx.de>
2533
2534 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2535
6511acf2 25362011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 2537
0999621a 2538 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
2539
2540 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 2541 (esprintf, exprintf, evxprintf): New functions.
62f19c19 2542 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 2543 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
2544 (modify_event_symbol): Do not assume that the length of
2545 name_alist_or_stem is safe to alloca and fits in int.
2546 (Fexecute_extended_command): Likewise for function name and binding.
2547 (Frecursion_depth): Wrap around reliably on integer overflow.
2548 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2549 since some callers pass EMACS_INT values.
2550 (Fsingle_key_description): Don't crash if symbol name contains more
2551 than MAX_ALLOCA bytes.
2552 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2553 (get_minibuffer): Arg is now EMACS_INT, not int.
2554 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 2555 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
2556 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2557
2be7d702
PE
2558 * dbusbind.c (signature_cat): New function.
2559 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
2560 Do not overrun buffer; instead, report string overflow.
2561
9d1df220
PE
2562 * dispnew.c (add_window_display_history): Don't overrun buffer.
2563 Truncate instead; this is OK since it's just a log.
2564
33ef5c64
PE
2565 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2566 even if the time zone offset is outlandishly large.
2567 Don't mishandle offset == INT_MIN.
2568
66c6fdd5
PE
2569 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2570 when creating daemon; the previous buffer-overflow check was incorrect.
2571
d749b01b
PE
2572 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2573 which has the guts of the old verror function.
2574
b5cd1905
PE
2575 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2576 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2577
6e1a67fb
PE
2578 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2579 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 2580 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 2581 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
2582 length of string rather than counting it via multiple sprintfs;
2583 that's simpler and more reliable.
c21721cc
PE
2584 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2585 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2586 sprintf, in case result does not fit in int.
2587
c57b67fc
PE
2588 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2589 (fontset_from_font): Print it.
2590
8a401434
PE
2591 * frame.c (tty_frame_count): Now printmax_t, not int.
2592 (make_terminal_frame, set_term_frame_name): Print it.
2593 (x_report_frame_params): In X, window IDs are unsigned long,
2594 not signed long, so print them as unsigned.
2595 (validate_x_resource_name): Check for implausibly long names,
2596 and don't assume name length fits in 'int'.
2597 (x_get_resource_string): Don't blindly alloca invocation name;
2598 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2599 not fit in int.
2600
6e1a67fb
PE
2601 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2602 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
2603 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2604
0df02bf3
PE
2605 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2606 Use esprintf, not sprintf, in case result does not fit in int.
2607
48e30793
PE
2608 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2609 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2610 it as a large positive number.
2611 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2612 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2613
a66ff6d8
PE
2614 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2615 in case result does not fit in int.
2616
aca216ff
PE
2617 * print.c (float_to_string): Detect width overflow more reliably.
2618 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2619 buffer overrun. Don't assume list length fits in 'int'. Treat
2620 print length of 0 as 0, not as infinity; to be consistent with other
2621 uses of print length in this function. Don't overflow print length
2622 index. Don't assume hash table size fits in 'long', or that
2623 vectorlike size fits in 'unsigned long'.
2624
31c286f7
PE
2625 * process.c (make_process): Use printmax_t, not int, to format
2626 process-name gensyms.
2627
55e5faa1
PE
2628 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2629
80f2e268
PE
2630 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2631 to avoid potential buffer overrun.
2632
670741ab
PE
2633 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2634 if X resource line is longer than 512 bytes.
2635
b7163a50
PE
2636 * xfns.c (x_window): Make sprintf buffer a bit bigger
2637 to avoid potential buffer overrun.
2638
ae58ff1f
PE
2639 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2640
c43c8a6a
PE
2641 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2642
3f8236f4
PE
26432011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2644
53e9fe90 2645 Integer overflow fixes for scrolling, etc.
6511acf2
PE
2646 Without these, Emacs silently mishandles large integers sometimes.
2647 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
2648 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2649
6511acf2
PE
2650 * xdisp.c (try_window_id): Check Emacs fixnum range before
2651 converting to 'int'.
806add1d 2652
6511acf2 2653 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
2654 Check that an Emacs fixnum is in range before assigning it to 'int'.
2655 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2656 values converted from Emacs fixnums.
2657 (Frecenter): Don't wrap around a line count if it is out of 'int'
2658 range; instead, treat it as an extreme value.
2659 (Fset_window_configuration, compare_window_configurations):
2660 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2661
6511acf2
PE
2662 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2663 that can exceed INT_MAX. Check that EMACS_INT value is in range
2664 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
2665 (match_limit): Don't assume that a fixnum can fit in 'int'.
2666
6511acf2 2667 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
2668 exceed INT_MAX.
2669
6511acf2 2670 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
2671 (Fvertical_motion): Don't wrap around LINES values that don't fit
2672 in 'int'. Instead, treat them as extreme values. This is good
2673 enough for windows, which can't have more than INT_MAX lines anyway.
2674
fcb901a7
LMI
26752011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2676
0f2f6b6d
LMI
2677 * Require libxml/parser.h to avoid compilation warning.
2678
fcb901a7
LMI
2679 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2680
2681 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2682 since this reportedly can destroy thread storage.
2683
6e20a0d4
CY
26842011-08-30 Chong Yidong <cyd@stupidchicken.com>
2685
2686 * syntax.c (find_defun_start): Update all cache variables if
2687 exiting early (Bug#9401).
2688
148ae00e
EZ
26892011-08-30 Eli Zaretskii <eliz@gnu.org>
2690
f6cfbd8f
EZ
2691 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2692
148ae00e
EZ
2693 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2694 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2695 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2696
2697 * term.c (tty_append_glyph): New function.
2698 (produce_stretch_glyph): Static function and its prototype deleted.
2699
a66cfb1c
SM
2700 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2701 Add prototypes.
148ae00e 2702
c4a07a4c
PE
27032011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2704
2705 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2706 when checking :margin (Bug#9390).
2707 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 2708 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
2709 so that the name doesn't mislead. All uses changed.
2710
6bc8cd65
JB
27112011-08-28 Johan Bockgård <bojohan@gnu.org>
2712
2713 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2714 set_tty_hooks.
2715
dca4927e
EZ
27162011-08-27 Eli Zaretskii <eliz@gnu.org>
2717
2718 * xdisp.c (move_it_to): Don't bail out early when reaching
2719 position beyond to_charpos, if we are scanning backwards.
2720 (move_it_vertically_backward): When DY == 0, make sure we get to
2721 the first character in the line after the newline.
2722
f2cad773
PE
27232011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2724
2725 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2726 (ccl_driver): Do not generate an out-of-range pointer.
2727 (Fccl_execute_on_string): Remove unnecessary check for
2728 integer overflow, noted by Stefan Monnier in
2729 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2730 Remove a FIXME that didn't need fixing.
2731 Simplify the newly-introduced buffer reallocation code.
2732
0cae2cdb
JB
27332011-08-27 Juanma Barranquero <lekktu@gmail.com>
2734
2735 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2736
5fc295a4 27372011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 2738
70c60eb2 2739 Integer and memory overflow issues (Bug#9196).
726e0ab1 2740
d31850da
PE
2741 * doc.c (get_doc_string): Rework so that
2742 get_doc_string_buffer_size is the actual buffer size, rather than
2743 being 1 less than the actual buffer size; this makes xpalloc more
2744 convenient.
2745
a69fbedb
PE
2746 * image.c (x_allocate_bitmap_record, cache_image):
2747 * xselect.c (Fx_register_dnd_atom):
2748 Simplify previous changes by using xpalloc.
2749
fe5c5d37
PE
2750 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2751 since either will do and ptrdiff_t is convenient with xpalloc.
2752
0065d054
PE
2753 * charset.c (charset_table_size)
2754 (struct charset_sort_data.priority): Now ptrdiff_t.
2755 (charset_compare): Don't overflow if priorities differ greatly.
2756 (Fsort_charsets): Don't assume list length fits in int.
2757 Check for size-calculation overflow when allocating sort data.
2758 (syms_of_charset): Allocate an initial charset table that is
2759 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2760
2761 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2762
2763 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2764 The actual value is always <= INT_MAX, and leaving it unsigned made
2765 overflow checking harder.
2766
2767 * dispextern.h (struct glyph_matrix.rows_allocated)
2768 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2769 with xpalloc. The values are still always <= INT_MAX.
2770
2771 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2772
2773 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2774 (SAFE_NALLOCA): New macro.
2775
2776 * region-cache.c (struct boundary.pos, find_cache_boundary)
2777 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2778 (set_cache_region, invalidate_region_cache)
2779 (revalidate_region_cache, know_region_cache, region_cache_forward)
2780 (region_cache_backward, pp_cache):
2781 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2782 so that ptrdiff_t * can be passed to xpalloc.
2783 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2784 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2785 (pp_cache): Don't assume cache_len fits in int.
2786 * region-cache.h: Adjust extern decls to match.
2787
2788 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2789 EMACS_INT, since either will do, for xpalloc.
2790
2791 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2792 (xnmalloc, xnrealloc, xpalloc): New functions.
2793
726e0ab1
PE
2794 * bidi.c (bidi_shelve_header_size): New constant.
2795 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2796 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2797
51f30bc5 2798 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
2799 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2800 (overlay_strings):
2801 Don't update size of array until after memory allocation succeeds,
2802 because xmalloc/xrealloc may not return.
0065d054
PE
2803 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2804 now that we have proper integer overflow checking.
2805 (record_overlay_string, overlay_strings): Catch overflows when
2806 calculating size of overlay_str_buf.
726e0ab1 2807
0065d054
PE
2808 * callproc.c (Fcall_process): Check for size overflow when
2809 calculating size of args2.
2810 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2811 Normally we prefer signed values, but sticking with ptrdiff_t would
2812 require adding more-complicated checks.
726e0ab1
PE
2813
2814 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2815 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2816 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 2817 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
2818
2819 * character.c (Fstring): Check for size-calculation overflow.
2820
2821 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2822 unnecessary integer overflow. Check for size overflow.
2823 (encode_coding_object): Don't update size until xmalloc succeeds.
2824
2825 * composite.c (get_composition_id): Check for overflow in glyph
2826 length calculations.
2827
2828 Integer and memory overflow fixes for display code.
2829 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2830 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2831 (scrolling_window): Check for overflow in size calculations.
2832 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2833 Don't assume glyph table len fits in int.
2834 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2835 (row_table_size): Now ptrdiff_t, not int.
2836 (scrolling_window): Avoid overflow in size calculations.
2837 Don't update size until allocation succeeds.
2838 * fns.c (concat): Check for overflow in size calculations.
2839 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2840 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2841 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2842
2843 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2844 (get_doc_string): Check for size calculation overflow.
2845 Don't update size until allocation succeeds.
2846 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2847 EMACS_INT, where ptrdiff_t will do.
2848 (Fsubstitute_command_keys): Check for string overflow.
2849
2850 * editfns.c (set_time_zone_rule): Don't assume environment length
2851 fits in int.
2852 (message_length): Now ptrdiff_t, not int.
2853 (Fmessage_box): Don't update size until allocation succeeds.
2854 Don't assume message length fits in int.
2855 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2856
0065d054
PE
2857 * emacs.c (main): Do not reallocate argv, since there is a null at
2858 the end that can be overwritten, and this way there's no need to
2859 worry about size-calculation overflow.
2860 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
2861
2862 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2863 alloc succeeds.
2864 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2865
2866 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2867 (x_set_scroll_bar_width, x_figure_window_size):
2868 Check for integer overflow.
2869 (x_set_alpha): Do not assume XINT fits in int.
2870
2871 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2872 This is for the members text_lines, text_cols, total_lines, total_cols,
2873 where the system imposes an 'int' limit.
2874
2875 * fringe.c (Fdefine_fringe_bitmap):
2876 Don't update size until alloc works.
2877
2878 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2879 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2880
2881 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2882 Check for size-calculation overflow.
2883 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2884 do, as we prefer signed integers.
2885 (id_to_widget.max_size, id_to_widget.used)
2886 (xg_store_widget_in_map, xg_remove_widget_from_map)
2887 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2888 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2889 Use and return ptrdiff_t, not int.
2890 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2891 * gtkutil.h: Change prototypes to match the above.
2892
2893 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2894 are duplicate now that they've been promoted to lisp.h.
2895 (x_allocate_bitmap_record, x_alloc_image_color)
2896 (make_image_cache, cache_image, xpm_load):
2897 Don't update size until alloc is done.
2898 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2899 (x_detect_edges):
3256efce 2900 Check for size calculation overflow.
726e0ab1
PE
2901 (ct_colors_allocated_max): New constant.
2902 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2903 overflow.
3256efce 2904
726e0ab1
PE
2905 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2906 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2907 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2908 Use ptrdiff_t, not int, to count maps.
2909 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
2910 calculations. Don't update size until allocation succeeds.
2911 Redo calculations to avoid overflow.
726e0ab1
PE
2912 * keyboard.h: Change prototypes to match the above.
2913
2914 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2915 to count maps.
2916 (current_minor_maps): Check for size calculation overflow.
2917 * keymap.h: Change prototypes to match the above.
2918
2919 * lread.c (read1, init_obarray): Don't update size until alloc done.
2920
2921 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2922 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2923
726e0ab1
PE
2924 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2925 Now ptrdiff_t, not int.
2926 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2927 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2928
2929 * process.c (Fnetwork_interface_list): Check for overflow
2930 in size calculation.
2931
2932 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2933
2934 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2935 overflow. Don't bother calling xmalloc when xrealloc will do.
2936
2937 * search.c (Freplace_match): Check for size calculation overflow.
2938 (Fset_match_data): Don't assume list lengths fit in 'int'.
2939
2940 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2941 for command line length. Do not attempt to address one before the
2942 beginning of an array, as that's not portable.
2943
2944 * term.c (max_frame_lines): Remove; unused.
2945 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2946 not int.
2947 (encode_terminal_code, calculate_costs): Check for size
2948 calculation overflow.
2949 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2950 table lengths and related sizes. Don't update size until alloc
2951 done. Redo calculations to avoid overflow.
2952 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2953
2954 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2955 subtracting pointers.
2956 (gobble_line): Check for overflow more carefully. Don't update size
2957 until alloc done.
2958
2959 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2960 Don't update size until alloc done.
2961 Redo size calculations to avoid overflow.
2962 Check for size calculation overflow.
0065d054 2963 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
2964
2965 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2966 Use ptrdiff_t, not int, for sizes.
2967 (store_mode_line_noprop_char): Don't update size until alloc done.
2968
0065d054
PE
2969 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2970 Use ptrdiff_t, not int, for sizes.
2971 (Finternal_make_lisp_face, cache_face):
2972 Check for size calculation overflow.
2973 (cache_face): Treat size calculation overflows as if they were
2974 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
2975
2976 * xfns.c (x_encode_text, x_set_name_internal)
2977 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2978 sizes, since they can exceed INT_MAX in size. Check for size
2979 calculation overflow.
2980
0065d054
PE
2981 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2982 (xg_select): Check for size calculation overflow.
726e0ab1
PE
2983 Don't update size until alloc done.
2984
0065d054 2985 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 2986 as sprintf is limited to int lengths.
1d526e2f 2987
252c5ee1
PE
2988 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2989 (X_LONG_MIN): New macros.
864d7ce7
PE
2990 Use them to make the following changes clearer.
2991 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2992 This change doesn't affect the value now, but it may help remind
2993 future maintainers not to raise the value too much later.
2994 (SELECTION_QUANTUM): Remove, replacing with ...
2995 (selection_quantum): ... new function, which avoids overflow.
2996 All uses changed.
2997 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2998 assumption that selection length fits in 'int'.
2999 (x_reply_selection_request, x_handle_selection_request)
3000 (x_get_window_property, receive_incremental_selection)
3001 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
3002 (lisp_data_to_selection_data, clean_local_selection_data):
3003 Use ptrdiff_t, not int, to record length of selection.
3004 (x_reply_selection_request, x_get_window_property)
3005 (receive_incremental_selection, x_property_data_to_lisp):
3006 Redo calculations to avoid overflow.
3007 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 3008 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
3009 something.
3010 (x_get_window_property, receive_incremental_selection)
3011 (lisp_data_to_selection_data, x_property_data_to_lisp):
3012 Check for size-calculation overflow.
3013 (x_get_window_property, receive_incremental_selection)
3014 (lisp_data_to_selection_data, Fx_register_dnd_atom):
3015 Don't store size until memory allocation succeeds.
3016 (x_get_window_property): Plug memory leak on memory exhaustion.
3017 Don't double-block input; malloc is safe here. Don't assume 2**34
3018 - 4 fits in unsigned long. Add an xassert to check
3019 XGetWindowProperty overflow. Be more careful about overflow
3020 calculations, and distinguish size from memory overflow better.
3021 (receive_incremental_selection): When tracing, don't assume
3022 unsigned int is less than INT_MAX.
3023 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
3024 harmful) conversions of unsigned short to int.
3025 (lisp_data_to_selection_data): Don't assume that integers
3026 in the range -65535 through -1 fit in an X unsigned short.
3027 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
3028 result parameters unless successful. Rely on cons_to_unsigned
3029 to report problems with elements; the old code wasn't right anyway.
3030 (x_check_property_data): Check for int overflow; we cannot use
3031 a wider type due to X limits.
3032 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
3033
726e0ab1 3034 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 3035
0065d054
PE
3036 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
3037 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
3038 (x_color_cells): Don't store size until memory allocation succeeds.
3039 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 3040 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
3041 (x_term_init): Don't assume length fits in int (sprintf is limited
3042 to int size).
bc18e09d 3043
ebfa62c0
PE
3044 Use ptrdiff_t for composition IDs.
3045 * character.c (lisp_string_width):
3046 * composite.c (composition_table_size, n_compositions)
3047 (get_composition_id, composition_gstring_from_id):
3048 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
3049 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
3050 * window.c (Frecenter):
3051 Use ptrdiff_t, not int, for composition IDs.
3052 * composite.c (get_composition_id): Check for integer overflow.
3053 * composite.h: Adjust prototypes to match the above changes.
3054
d3411f89
PE
3055 Use ptrdiff_t for hash table indexes.
3056 * category.c (hash_get_category_set):
3057 * ccl.c (ccl_driver):
3058 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
3059 * coding.c (coding_system_charset_list, detect_coding_system):
3060 * coding.h (struct coding_system.id):
3061 * composite.c (get_composition_id, gstring_lookup_cache):
3062 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
3063 * image.c (xpm_get_color_table_h):
3064 * lisp.h (hash_lookup, hash_put):
3065 * minibuf.c (Ftest_completion):
3066 Use ptrdiff_t for hash table indexes, not int (which is too
3067 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
3068 32-bit --with-wide-int hosts).
3069
e097a6fa
PE
3070 * charset.c (Fdefine_charset_internal): Check for integer overflow.
3071 Add a FIXME comment about memory leaks.
3072 (syms_of_charset): Don't assume xmalloc returns.
3073
5637687f
PE
3074 Don't assume that stated character widths fit in int.
3075 * character.c (Fchar_width, c_string_width, lisp_string_width):
3076 * character.h (CHAR_WIDTH):
3077 * indent.c (MULTIBYTE_BYTES_WIDTH):
3078 Use sanitize_char_width to avoid undefined and/or bad behavior
3079 with outlandish widths.
a66cfb1c 3080 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
3081 now that we have two such functions. All uses changed.
3082 (sanitize_char_width): New inline function.
3083
a2271ba2
PE
3084 Don't assume that tab-width fits in int.
3085 * character.h (sanitize_width): New inline function.
3086 (SANE_TAB_WIDTH): New macro.
3087 (ASCII_CHAR_WIDTH): Use it.
3088 * indent.c (sane_tab_width): Remove. All uses replaced by
3089 SANE_TAB_WIDTH (current_buffer).
3090 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
3091
18c52557
PE
3092 * fileio.c: Integer overflow issues with file modes.
3093 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
3094
caeeedc1
PE
3095 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
3096 Remove unreachable code.
3097 (read_hex, load_charset_map_from_file): Check for integer overflow.
3098
6df6ae42 3099 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
3100 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
3101 (x_send_scroll_bar_event): Likewise. Check that the size does not
3102 exceed limits imposed by XClientMessageEvent, as well as the usual
3103 ptrdiff_t and size_t limits.
3104
b13995db
PE
3105 * keyboard.c: Overflow, signedness and related fixes.
3106 (make_lispy_movement): Use same integer type in forward decl
3107 that is used in the definition.
3108 (read_key_sequence, keyremap_step):
3109 Change bufsize argument back to int, undoing my 2011-03-30 change.
3110 We prefer signed types, and int is wide enough here.
3111 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
3112 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
3113 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
3114 length, not size_t. Use ptrdiff_t for index, not int.
3115 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
3116 possibility of integer overflow.
3117
13464394
PE
3118 Overflow, signedness and related fixes for images.
3119
3120 * dispextern.h (struct it.stack[0].u.image.image_id)
3121 (struct_it.image_id, struct image.id, struct image_cache.size)
3122 (struct image_cache.used, struct image_cache.ref_count):
3123 * gtkutil.c (update_frame_tool_bar):
3124 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
3125 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
3126 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
3127 * nsmenu.m (update_frame_tool_bar):
3128 * xdisp.c (calc_pixel_width_or_height):
3129 * xfns.c (image_cache_refcount):
3130 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
3131 on typical 64-bit hosts.
3132
3133 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3134 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
3135 Omit unnecessary casts to int.
3136 (parse_image_spec): Check that integers fall into 'int' range
3137 when the callers expect that.
3138 (image_ascent): Redo ascent calculation to avoid int overflow.
3139 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
3140 (lookup_image): Remove unnecessary tests.
3141 (xbm_image_p): Locals are now of int, not EMACS_INT,
3142 since parse_image_check makes sure they fit into int.
3143 (png_load, gif_load, svg_load_image):
3144 Prefer int to unsigned where either will do.
3145 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
3146 old tiff_error_handler and tiff_warning_handler.
3147 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
3148 stack buffer overflows. It uses only the features of vsnprintf
3149 that are common to both POSIX and native Microsoft.
3150 (tiff_error_handler, tiff_warning_handler): Use it.
3151 (tiff_load, gif_load, imagemagick_load_image):
3152 Don't assume :index value fits in 'int'.
3153 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3154 (imagemagick_load_image): Check that crop parameters fit into
3155 the integer types that MagickCropImage accepts. Don't assume
3156 Vimagemagick_render_type has a nonnegative value. Don't assume
3157 size_t fits in 'long'.
3158 (gs_load): Use printmax_t to print the widest integers possible.
3159 Check for integer overflow when computing image height and width.
3160
c11821d4
EZ
31612011-08-26 Eli Zaretskii <eliz@gnu.org>
3162
3163 * xdisp.c (redisplay_window): Don't force window start if point
3164 will be invisible in the resulting window. (Bug#9324)
3165
0c95fcf7
EZ
31662011-08-25 Eli Zaretskii <eliz@gnu.org>
3167
3168 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3169 the display spec is of the form `(space ...)'.
3170 (handle_display_spec): Return the value returned by
3171 handle_single_display_spec, not just 1 or zero.
3172 (handle_single_display_spec): If the display spec is of the form
3173 `(space ...)', and specifies display in the text area, return 2
3174 rather than 1.
fee65a97 3175 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
3176 accurately, and prefer exact match for point under bidi.
3177 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
3178
3179 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3180 into disp_prop; all users changed.
3181
3182 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3183 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3184 for the text covered by the display property.
3185
e4ed06f1
CY
31862011-08-25 Chong Yidong <cyd@stupidchicken.com>
3187
3188 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3189 Change return value to nil.
3190 (Frecord_buffer): Delete unused function.
3191
f67cdd7f
EZ
31922011-08-24 Eli Zaretskii <eliz@gnu.org>
3193
5980d4c6
EZ
3194 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3195 buffers, return left-to-right.
8610fe8b
EZ
3196 (set_cursor_from_row): Consider candidate row a win if its glyph
3197 represents a newline and point is on that newline. Fixes cursor
3198 positioning on the newline at EOL of R2L text within L2R
3199 paragraph, and vice versa.
3200 (try_cursor_movement): Check continued rows, in addition to
3201 continuation rows. Fixes unwarranted scroll when point enters a
3202 continued line of R2L text within an L2R paragraph, or vice versa.
3203 (cursor_row_p): Consider the case of point being equal to
3204 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3205 from the end of a short line to the beginning of a continued line
3206 of R2L text within L2R paragraph.
3207 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3208 composed characters.
5980d4c6 3209
f67cdd7f
EZ
3210 * bidi.c (bidi_check_type): Use xassert.
3211 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3212 members.
3213
bca633fb
EZ
32142011-08-23 Eli Zaretskii <eliz@gnu.org>
3215
3216 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3217 a character.
3218
4a5885a7
CY
32192011-08-23 Chong Yidong <cyd@stupidchicken.com>
3220
3221 * nsfont.m (ns_otf_to_script): Fix typo.
3222
0902a04e
KH
32232011-08-22 Kenichi Handa <handa@m17n.org>
3224
3225 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3226 extra slot even if the purpose is char-code-property-table.
3227
1a2e6670
EZ
32282011-08-23 Eli Zaretskii <eliz@gnu.org>
3229
8ddde651
EZ
3230 * xdisp.c (redisplay_window): When computing centering_position,
3231 account for the height of the header line. (Bug#8874)
3232
425cc014
EZ
3233 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3234 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3235 candidate is selected by the mouse, and that candidate has a
3236 composed character under the mouse.
3237
1a2e6670
EZ
3238 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3239 coordinates reported by pos-visible-in-window-p for a composed
3240 character in column zero.
3241
8b76d6f8
SM
32422011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3243
3244 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3245
dac347dd
EZ
32462011-08-22 Eli Zaretskii <eliz@gnu.org>
3247
3248 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3249 consider it a hit if to_charpos is anywhere in the range of the
3250 composed buffer positions.
3251
e013fb34
CY
32522011-08-22 Chong Yidong <cyd@stupidchicken.com>
3253
3254 * image.c (gif_load): Don't assume that each subimage has the same
3255 dimensions as the base image. Handle disposal method that is
3256 "undefined" by the gif spec (Bug#9335).
3257
bd1ba3e8
CY
32582011-08-20 Chong Yidong <cyd@stupidchicken.com>
3259
3260 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 3261 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 3262
54a1215b
EZ
32632011-08-19 Eli Zaretskii <eliz@gnu.org>
3264
823564e5
EZ
3265 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3266 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3267 from an Org mode buffer to a Speedbar frame.
3268
54a1215b
EZ
3269 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3270 a composition, take its buffer position from IT->cmp_it.charpos.
3271 Fixes cursor positioning at the beginning of a line that begins
3272 with a composed character.
3273
9778ebcc
EZ
32742011-08-18 Eli Zaretskii <eliz@gnu.org>
3275
0be6ee06
EZ
3276 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3277 character bidirectional type, use STRONG_L instead. Fixes crashes
3278 in a buffer produced by `describe-categories'.
3279
9778ebcc
EZ
3280 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3281 members before the level stack, so they would be saved and
3282 restored when copying iterator state. Fixes incorrect reordering
3283 around TABs covered by display properties.
3284
156bffbe
AS
32852011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3286
6b02f655 3287 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 3288
72ad093b
CY
32892011-08-17 Chong Yidong <cyd@stupidchicken.com>
3290
3291 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
3292 (internal_condition_case_2, internal_condition_case_n):
3293 Remove unnecessary aborts (Bug#9081).
72ad093b 3294
35774242
EZ
32952011-08-17 Eli Zaretskii <eliz@gnu.org>
3296
3297 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3298 has no `load' handler, try opening the file locally. (Bug#9311)
3299
db76dd85
KB
33002011-08-16 Ken Brown <kbrown@cornell.edu>
3301
3302 * gmalloc.c: Expand comment.
3303
b215eee5
EZ
33042011-08-16 Eli Zaretskii <eliz@gnu.org>
3305
3306 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3307 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3308
a4579d33
KB
33092011-08-16 Ken Brown <kbrown@cornell.edu>
3310
3311 Fix memory allocation problems in Cygwin build (Bug#9273).
3312
3313 * unexcw.c ( __malloc_initialized): Declare external variable.
3314 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3315
8b76d6f8
SM
3316 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3317 New variables.
a4579d33
KB
3318 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3319 dumped emacs.
3320 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3321 in the static heap.
3322 [CYGWIN] (special_realloc): New function.
3323 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3324 requests to realloc storage in the static heap.
3325
3ebec551
PE
33262011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3327
3328 * bidi.c (bidi_initialize): Remove unused local.
3329
9fd8be00
EZ
33302011-08-15 Eli Zaretskii <eliz@gnu.org>
3331
6b02f655
SM
3332 * bidimirror.h:
3333 * biditype.h: Remove file.
3334 * makefile.w32-in ($(BLD)/bidi.$(O)):
3335 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
3336
3337 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3338
3339 * chartab.c: Improve commentary for the uniprop_table API.
3340
32413314
EZ
3341 * bidi.c (bidi_paragraph_init): Support zero value of
3342 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
3343 (bidi_initialize): Use uniprop_table instead of including
3344 biditype.h and bidimirror.h.
32413314 3345
9fd8be00
EZ
3346 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3347 coordinates of the iterator when restoring from ppos_it.
3348 (Bug#9296)
3349
5cf2b69b
KH
33502011-08-14 Kenichi Handa <handa@m17n.org>
3351
3352 * process.c (create_process): Call setup_process_coding_systems
72ad093b 3353 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 3354
daf17d00
EZ
33552011-08-14 Eli Zaretskii <eliz@gnu.org>
3356
3357 * xdisp.c (move_it_in_display_line_to): Don't invoke
3358 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3359 ppos_it. Fixes vertical cursor motion when line beginning is
3360 covered by an image. (Bug#9296)
3361
08e3161a
JD
33622011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3363
3364 * nsterm.h (ns_run_ascript): Declare.
3365 (NSAPP_DATA2_RUNASSCRIPT): Define.
3366
3367 * nsfns.m (as_script, as_result, as_status): New static variables.
3368 (ns_run_ascript): New function.
5e617bc2 3369 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
3370 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3371 the event loop. Get status from as_status (Bug#7276).
3372
3373 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3374 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3375 the event loop (Bug#7276).
3376
a3720aa2
AS
33772011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3378
3379 * gnutls.c (QCgnutls_bootprop_priority)
3380 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3381 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3382 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3383 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3384 (QCgnutls_bootprop_verify_hostname_error)
3385 (QCgnutls_bootprop_callbacks_verify): Rename from
3386 Qgnutls_bootprop_..., all uses changed.
3387
3388 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3389 uses changed.
3390
0a0d27fb
PE
33912011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3392
19d5c50c
PE
3393 * xfaces.c (Qframe_set_background_mode): Now static.
3394 * dispextern.h (Qframe_set_background_mode): Remove decl.
3395
0a0d27fb
PE
3396 * process.c (Fnetwork_interface_info): Declare local only if needed.
3397
377538cb
JD
33982011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3399
3400 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3401 (Fnetwork_interface_list): Allocate in increments of bytes instead
3402 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3403 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3404 sockaddr.
3405 (struct ifflag_def): notrailers is smart on OSX.
3406 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3407 Get hardware address with getifaddrs if available.
3408
08fff70c
EZ
34092011-08-12 Eli Zaretskii <eliz@gnu.org>
3410
3411 * xdisp.c (iterate_out_of_display_property): xassert that
3412 IT->position is set to within IT->object's boundaries. Break from
3413 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
3414 when IT->position is set up wrongly due to some bug.
3415 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
3416 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3417 entry. Force push_it to save on the stack the current
3418 buffer/string position, to be restored by pop_it. Fix flags in
3419 the iterator structure wrt the object coming from a display
3420 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3421 properties. (Bug#9284)
3422
7be1c708 34232011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 3424
7be1c708
CY
3425 * fontset.c (fontset_get_font_group): Add proper type checks.
3426 (Bug#9172)
aac0c6e3 3427
7be1c708 34282011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 3429
7be1c708
CY
3430 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3431 and LC_VERSION_MIN_MACOSX.
3432 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3433 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 3434
97bb72a6
EZ
34352011-08-08 Eli Zaretskii <eliz@gnu.org>
3436
3437 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
3438 no-display-properties-and-no-overlays under bidi display.
3439 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 3440 properties and overlays.
97bb72a6 3441
d5617611
CY
34422011-08-08 Chong Yidong <cyd@stupidchicken.com>
3443
37e11a63
CY
3444 * editfns.c (Fset_time_zone_rule): Document relationship with the
3445 setenv function.
3446
d5617611
CY
3447 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3448 the font entity extracted from the cache (Bug#8109).
3449
58872834
CY
34502011-08-07 Chong Yidong <cyd@stupidchicken.com>
3451
3452 * composite.c (autocmp_chars): Don't reset point. That is done by
3453 restore_point_unwind (Bug#5984).
3454
75bfc667
JL
34552011-08-07 Juri Linkov <juri@jurta.org>
3456
3457 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3458 to show the arg `TIME' instead of `TIMEVAL'.
3459
d1410150
EZ
34602011-08-06 Eli Zaretskii <eliz@gnu.org>
3461
3462 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3463 display property strides EOL and includes a newline, as in
3464 longlines-mode. (Bug#9254)
75b771e4
EZ
3465 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3466 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
3467
3468 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3469 is non-zero, even if the data buffer is NULL. Fixes a crash in
3470 vertical-motion with longlines-mode. (Bug#9254)
3471
35928349
EZ
34722011-08-05 Eli Zaretskii <eliz@gnu.org>
3473
ec7cc85b
EZ
3474 * bidi.c <bidi_cache_total_alloc>: Now static.
3475 (bidi_initialize): Initialize bidi_cache_total_alloc.
3476
8b76d6f8 3477 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
3478 cache. (Bug#9221)
3479
3480 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3481 amount allocated this far in `bidi_cache_total_alloc'.
3482 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3483 non-zero, only free the data buffer without restoring the cache
3484 contents. All callers changed.
3485
3486 * dispextern.h (bidi_unshelve_cache): Update prototype.
3487
3488 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3489 (move_it_in_display_line, move_it_to)
3490 (move_it_vertically_backward, move_it_by_lines): Replace the call
3491 to xfree to an equivalent call to bidi_unshelve_cache.
3492 (move_it_in_display_line_to): Fix logic of returning
412b6358 3493 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 3494
e2e2423b
EZ
34952011-08-05 Eli Zaretskii <eliz@gnu.org>
3496
3497 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3498 came from a string character with a `cursor' property. (Bug#9229)
3499
ae9e757a
JD
35002011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3501
3502 * Makefile.in (LIB_PTHREAD): New variable.
3503 (LIBES): Add LIB_PTHREAD (Bug#9216).
3504
3505 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3506 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3507
213bd7f2
AS
35082011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3509
6b02f655 3510 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 3511
99aaf75f
JD
35122011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3513
3514 * xterm.c (x_find_topmost_parent): New function.
3515 (x_set_frame_alpha): Find topmost parent window with
3516 x_find_topmost_parent and set the property there also (bug#9181).
3517 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3518
c74e9d86
PE
35192011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3520
3521 * callproc.c (Fcall_process): Avoid vfork clobbering
3522 the local vars buffer, coding_systems, current_dir.
3523
640c8776
SM
35242011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3525
3526 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3527
f26d0e4c
PE
35282011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3529
8a10d76c
PE
3530 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3531 so that it is not optimized away.
3532
f26d0e4c
PE
3533 * xdisp.c (compute_display_string_pos): Remove unused local.
3534
55439c61
EZ
35352011-08-02 Eli Zaretskii <eliz@gnu.org>
3536
3537 Fix slow cursor motion and scrolling in large buffers with
3538 selective display, like Org Mode buffers. (Bug#9218)
3539
3540 * dispextern.h (struct bidi_it): New member disp_prop_p.
3541
3542 * xdisp.c: Remove one-slot cache of display string positions.
3543 (compute_display_string_pos): Accept an additional argument
5e617bc2 3544 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
3545 for a display string or property. If found, set DISP_PROP_P
3546 non-zero.
3547
3548 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
3549 DISP_PROP_P, and pass it to compute_display_string_pos.
3550 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
3551 non-zero. All callers of bidi_fetch_char changed.
3552
fb33fa43
SM
35532011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3554
3555 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3556
b099e063
DM
35572010-12-03 Don March <don@ohspite.net>
3558
3559 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3560 last character M-[char] is translated to ESC [char] (bug#7541).
3561
5cc7f7af
KH
35622011-08-02 Kenichi Handa <handa@m17n.org>
3563
d0fffa3f 3564 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
3565
3566 * chartab.c (uniprop_table): Make it non-static.
3567
525d5e6e
EZ
35682011-08-01 Eli Zaretskii <eliz@gnu.org>
3569
3570 * xdisp.c (forward_to_next_line_start): Accept additional argument
3571 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3572 on the newline.
3573 (reseat_at_next_visible_line_start): Use the bidi iterator state
3574 returned by forward_to_next_line_start to restore the state of
3575 it->bidi_it after backing up to previous newline. (Bug#9212)
3576
31011111
AS
35772011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3578
3579 * regex.c (re_comp): Protoize.
3580 (re_exec): Fix return type.
3581 (regexec): Fix type of `ret'. (Bug#9203)
3582
476371c4
PE
35832011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3584
e5d76069
PE
3585 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3586 This is needed if max-image-size is a floating-point number.
3587
9a79b20c
AS
35882011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3589
3590 * print.c (print_object): Print empty symbol as ##.
3591
3592 * lread.c (read1): Read ## as empty symbol.
3593
d8c2fa78
AA
35942011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3595
3596 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3597 setting frame foreground color (Bug#9175).
3598 (x_set_background_color): Likewise.
3599
ffe57a7a
AA
3600 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3601 contents (Bug#9176).
3602 (EmacsTooltip -init): Remove bezels and add shadows to
3603 tooltip windows.
3604
bf3492a5
AA
3605 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3606 or scroll bar (Bug#8470).
3607
d55e9c53
AA
3608 * nsfont.m (nsfont_open): Remove assignment to voffset and
3609 unnecessary vars hshink, expand, hd, full_height, min_height.
3610 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3611
3612 * nsterm.h (nsfont_info): Remove voffset field.
3613
d8c2fa78 36142011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
3615
3616 Implement strike-through and overline on NextStep (Bug#8863).
3617
3618 * nsfont.m (nsfont_open): Use underline position provided by font,
3619 instead of hard-coded value of 2.
3620 (nsfont_draw): Call ns_draw_text_decoration instead.
3621
3622 * nsterm.h: Add declaration for ns_draw_text_decoration.
3623
3624 * nsterm.m (ns_draw_text_decoration): New function for drawing
3625 underline, overline, and strike-through.
3626 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3627 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 3628 accommodate underlining, etc.
4843aac3 3629
4cc60b9b
EZ
36302011-07-28 Eli Zaretskii <eliz@gnu.org>
3631
bc7ece87
EZ
3632 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3633 default.
4cc60b9b 3634
476371c4
PE
36352011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3636
66606eea
PE
3637 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3638 Without this fix, if a signal arrives just after memory fills up,
3639 'malloc' might be invoked reentrantly.
3640
476371c4
PE
3641 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3642 In other words, assume that every image size is allowed, on non-X
3643 hosts. This assumption is probably wrong, but it lets Emacs compile.
3644
f3fcc40d
AS
36452011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3646
3647 * regex.c (re_iswctype): Convert return values to boolean.
3648
350c992f
EZ
36492011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3650
3651 * xdisp.c (compute_display_string_pos): Don't use cached display
3652 string position if the buffer had its restriction changed.
3653 (Bug#9184)
3654
5266b4bb
PE
36552011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3656
3657 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3658
2573a837 36592011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 3660
41f55ccd 3661 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 3662
39e378da
PE
3663 * bidi.c: Integer size and overflow fixes.
3664 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3665 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3666 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3667 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3668 (bidi_find_other_level_edge):
3669 Use ptrdiff_t instead of EMACS_INT where either will do.
3670 This works better on 32-bit hosts configured --with-wide-int.
3671 (bidi_cache_ensure_space): Check for size-calculation overflow.
3672 Use % rather than repeated addition, for better worst-case speed.
3673 Don't set bidi_cache_size until after xrealloc returns, because it
3674 might not return.
3675 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
3676 (bidi_cache_ensure_space): Also check that the bidi cache size
3677 does not exceed that of the largest Lisp string or buffer. See Eli
3678 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 3679
5e927815
PE
3680 * alloc.c (__malloc_size_t): Remove.
3681 All uses replaced by size_t. See Andreas Schwab's note
3682 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3683
ca4aa935
PE
3684 * image.c: Improve checking for integer overflow.
3685 (check_image_size): Assume that f is nonnull, since
3686 it is always nonnull in practice. This is one less thing to
3687 worry about when checking for integer overflow later.
3688 (x_check_image_size): New function, which checks for integer
3689 overflow issues inside X.
3690 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3691 This removes the need for a memory_full check.
3692 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3693 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3694 (xbm_read_bitmap_data): Change locals back to 'int', since
3695 their values must fit in 'int'.
3696 (xpm_load_image, png_load, tiff_load):
3697 Invoke x_create_x_image_and_pixmap earlier,
3698 to avoid much needless work if the image is too large.
3699 (tiff_load): Treat overly large images as if
3700 x_create_x_image_and_pixmap failed, not as malloc failures.
3701 (gs_load): Use x_check_image_size.
3702
5f8f9cc2
PE
3703 * gtkutil.c: Omit integer casts.
3704 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3705 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3706
5adf60bc
PE
3707 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3708
c8907a93
PE
3709 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3710 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3711 would wrongly return t on a 64-bit host.
3712
e3c25c68
PE
3713 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3714 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3715 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3716 and therefore cause GCC to emit a bogus diagnostic in some cases.
3717
3f791afe
PE
3718 * image.c: Integer signedness and overflow and related fixes.
3719 This is not an exhaustive set of fixes, but it's time to
3720 record what I've got.
3721 (lookup_pixel_color, check_image_size): Remove redundant decls.
3722 (check_image_size): Don't assume that arbitrary EMACS_INT values
3723 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3724 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3725 (tiff_load, imagemagick_load_image):
3726 Check for overflow in size calculations.
3727 (x_create_x_image_and_pixmap): Remove unnecessary test for
3728 xmalloc returning NULL; that can't happen.
3729 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3730 (xpm_color_bucket): Use better integer hashing function.
3731 (xpm_cache_color): Don't possibly over-allocate memory.
3732 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3733 (gif_memory_source):
3734 Use ptrdiff_t, not int or size_t, to record sizes.
3735 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3736 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3737 either works, as we prefer signed integers.
3738 (tiff_read_from_memory, tiff_write_from_memory):
3739 Return tsize_t, not size_t, since that's what the TIFF API wants.
3740 (tiff_read_from_memory): Don't fail simply because the read would
3741 go past EOF; instead, return a short read.
3742 (tiff_load): Omit no-longer-needed casts.
3743 (Fimagemagick_types): Don't assume size fits into 'int'.
3744
3cc5a532
PE
3745 Improve hashing quality when configured --with-wide-int.
3746 * fns.c (hash_string): New function, taken from sxhash_string.
3747 Do not discard information about ASCII character case; this
3748 discarding is no longer needed.
3749 (sxhash-string): Use it. Change sig to match it. Caller changed.
3750 * lisp.h: Declare it.
3751 * lread.c (hash_string): Remove, since we now use fns.c's version.
3752 The fns.c version returns a wider integer if --with-wide-int is
3753 specified, so this should help the quality of the hashing a bit.
3754
b312a492
PE
3755 * emacs.c: Integer overflow minor fix.
3756 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3757 Define only if GNU_LINUX.
3758 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3759
dfd153ae
PE
3760 * dispnew.c: Integer signedness and overflow fixes.
3761 Remove unnecessary forward decls, that were a maintenance hassle.
3762 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3763 All uses changed.
3764 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3765 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3766 (prepare_desired_row, line_draw_cost):
3767 Use int, not unsigned, where either works.
3768 (save_current_matrix, restore_current_matrix):
3769 Use ptrdiff_t, not size_t, where either works.
3770 (init_display): Check for overflow more accurately, and without
3771 relying on undefined behavior.
3772
a81d11a3
PE
3773 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3774 Remove, replacing with the new symbols in lisp.h. All uses changed.
3775 * fileio.c (make_temp_name):
3776 * filelock.c (lock_file_1, lock_file):
3777 * xdisp.c (message_dolog):
3778 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3779 Use pMd etc. instead.
3780 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3781 replacing the pWIDE etc. symbols removed from editfns.c.
3782
3300e6fd
PE
3783 * keyboard.h (num_input_events): Now uintmax_t.
3784 This is (very slightly) less likely to mess up due to wraparound.
3785 All uses changed.
3786
fd05c7e9
PE
3787 * buffer.c: Integer signedness fixes.
3788 (alloc_buffer_text, enlarge_buffer_text):
3789 Use ptrdiff_t rather than size_t when either will do, as we prefer
3790 signed integers.
3791
903fe15d
PE
3792 * alloc.c: Integer signedness and overflow fixes.
3793 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3794 (__malloc_size_t): Default to size_t, not to int.
3795 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3796 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3797 Prefer ptrdiff_t to size_t when either would do, as we prefer
3798 signed integers.
3799 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3800 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3801 Now const. Initialize with values that are in range even if char
3802 is signed.
3803 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3804 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3805 These functions do the right thing with sizes > 2**32.
3806 (check_depth): Now ptrdiff_t, not int.
3807 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3808 Adjust to new way of storing sizes. Check for size overflow bugs
3809 in rest of code.
3810 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3811 slightly wrong anyway, as it missed one instance of
3812 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3813 (refill_memory_reserve): Omit needless cast to size_t.
3814 (mark_object_loop_halt): Mark as externally visible.
3815
ac82cc6a
PE
3816 * xselect.c: Integer signedness and overflow fixes.
3817 (Fx_register_dnd_atom, x_handle_dnd_message):
3818 Use ptrdiff_t, not size_t, since we prefer signed.
3819 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3820 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3821 x_dnd_atoms_size and x_dnd_atoms_length.
3822
c2d1e36d
PE
3823 * doprnt.c: Prefer signed to unsigned when either works.
3824 * eval.c (verror):
3825 * doprnt.c (doprnt):
3826 * lisp.h (doprnt):
3827 * xdisp.c (vmessage):
3828 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3829 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3830 prefer signed arithmetic to avoid comparison confusion.
3831 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3832 but is a bit tricky.
3833
0e926e56
PE
3834 Assume freestanding C89 headers, string.h, stdlib.h.
3835 * data.c, doprnt.c, floatfns.c, print.c:
3836 Include float.h unconditionally.
3837 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3838 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3839 * regex.c: Likewise for stddef.h, string.h.
3840 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3841 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3842 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3843 (STDC_HEADERS): Remove obsolete defines.
3844 * sysdep.c: Include limits.h unconditionally.
3845
9cfdb3ec
PE
3846 Assume support for memcmp, memcpy, memmove, memset.
3847 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3848 * regex.c (memcmp, memcpy):
3849 Remove; we assume C89 now.
3850
3851 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3852 (__malloc_safe_bcopy): Remove; no longer needed.
3853
cf950e6b 3854 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
3855 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3856 well either way, and we prefer signed to unsigned.
3857
dbf38e02
LMI
38582011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3859
3860 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3861 closes the connection while we're reading (bug#9182).
3862
d6f0886c 38632011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 3864
d6f0886c
JD
3865 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3866 are specified (Bug#9168).
24e0f6b1 3867
2eb1f9e6
PE
38682011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3869
3870 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3871 Found by GCC static checking and --with-wide-int on a 32-bit host.
3872
22381272 38732011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
3874
3875 * xdisp.c (compute_display_string_pos): Fix logic of caching
3876 previous display string position. Initialize cached_prev_pos to
3877 -1. Fixes slow-down at the beginning of a buffer.
3878
f25e39b4
EZ
38792011-07-24 Eli Zaretskii <eliz@gnu.org>
3880
3881 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3882 for attrs[LFACE_FONTSET_INDEX].
3883
04c4b52e
PE
38842011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3885
3886 * xml.c (parse_region): Remove unused local
3887 that was recently introduced.
3888
c1734fbd
EZ
38892011-07-23 Eli Zaretskii <eliz@gnu.org>
3890
be18c5a5
EZ
3891 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3892 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3893
c1734fbd
EZ
3894 * xdisp.c (move_it_in_display_line_to): Record the best matching
3895 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
3896 exit if none of the characters scanned was an exact match.
3897 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
3898 when exact match is impossible due to invisible text, and the
3899 lines are truncated.
3900
a258d627
JD
39012011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3902
3903 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3904 for OSX >= 10.7.
3905
b6d5a689
EZ
39062011-07-22 Eli Zaretskii <eliz@gnu.org>
3907
0f74f785
EZ
3908 Fix a significant slow-down of cursor motion with C-n, C-p,
3909 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3910 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 3911 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
3912 (next_element_from_buffer): Call compute_stop_pos_backwards to
3913 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
3914 base_level_stop.
3915 (reseat): Don't look for prev_stop, as that could mean a very long
3916 run.
3917 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3918 <cached_disp_overlay_modiff>: Cache for last found display string
3919 position.
551918c1 3920 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
3921 about the same buffer in the same area of character positions, and
3922 the buffer wasn't changed since the time the display string
3923 position was cached.
551918c1 3924
b2d0c91a
EZ
39252011-07-22 Eli Zaretskii <eliz@gnu.org>
3926
3927 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3928 is an integer, which is important for empty lines. (Bug#9149)
3929
043604ee
CY
39302011-07-22 Chong Yidong <cyd@stupidchicken.com>
3931
3932 * frame.c (Fmodify_frame_parameters): In tty case, update the
3933 default face if necessary (Bug#4238).
3934
da4adb04
CY
39352011-07-21 Chong Yidong <cyd@stupidchicken.com>
3936
3937 * editfns.c (Fstring_to_char): No need to explain what a character
3938 is in the docstring (Bug#6576).
3939
9abd0532
LMI
39402011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3941
3942 * xml.c (parse_region): Make sure we always return a tree.
3943
36881d16
HK
39442011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3945
3946 * xml.c (parse_region): If a document contains only comments,
3947 return that, too.
3948
1e98674d
LMI
39492011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3950
3951 * xml.c (make_dom): Return comments, too.
3952
590bd467
PE
39532011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3954
3955 Port to OpenBSD.
3956 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3957 and the surrounding thread.
3958 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3959 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3960 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3961 timer goes off.
3962 * s/openbsd.h (BROKEN_SIGIO): Define.
3963 * unexelf.c (unexec) [__OpenBSD__]:
3964 Don't update the .mdebug section of the Alpha COFF symbol table.
3965
f41628b2
LMI
39662011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3967
3968 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3969 (bug#8460).
3970
b59b67c5
PE
39712011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3972
15e3a074
PE
3973 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3974 This fixes some race conditions on the permissions of any newly
3975 created file.
3976
41bed37d
PE
3977 * alloc.c (valid_pointer_p): Use pipe, not open.
3978 This fixes some permissions issues when debugging.
3979
b59b67c5
PE
3980 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3981 If fchown fails to set both uid and gid, try to set just gid,
3982 as that is sometimes allowed. Adjust the file's mode to eliminate
3983 setuid or setgid bits that are inappropriate if fchown fails.
3984
925a6be7
SM
39852011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3986
3987 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3988 to compare Lisp_Objects.
3989 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3990 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3991 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3992
52968808
AS
39932011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3994
0a6a104b
AS
3995 * lread.c (read_integer): Unread even EOF character.
3996 (read1): Likewise. Properly record start position of symbol.
3997
52968808
AS
3998 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3999 symbol character follows.
4000
9e381cdd
PE
40012011-07-17 Paul Eggert <eggert@cs.ucla.edu>
4002
4003 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
4004 This works around a problem with the previous change to Fcopy_file.
4005 Recent glibc declares fchown with __attribute__((warn_unused_result)),
4006 and without this change, GCC might complain about discarding
4007 fchown's return value.
4008
b5641435
JB
40092011-07-16 Juanma Barranquero <lekktu@gmail.com>
4010
4011 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
4012
a8031457
PE
40132011-07-16 Paul Eggert <eggert@cs.ucla.edu>
4014
4015 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
4016
dd889327
LMI
40172011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
4018
750c33f7
LMI
4019 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
4020 it's used from the C level.
4021
dd889327
LMI
4022 * process.c: Use the same condition for POLL_FOR_INPUT in both
4023 keyboard.c and process.c (bug#1858).
4024
87e86684
LM
40252011-07-09 Lawrence Mitchell <wence@gmx.li>
4026
4027 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
4028 (Fgnutls_boot): Use it.
4029
64348f40
AS
40302011-07-15 Andreas Schwab <schwab@linux-m68k.org>
4031
4032 * doc.c (Fsubstitute_command_keys): Revert last change.
4033
1d698799
LMI
40342011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
4035
f863868c
LMI
4036 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
4037 quotes the next character, and doesn't affect other longer
4038 sequences (bug#8935).
4039
1d698799
LMI
4040 * lread.c (syms_of_lread): Clarify that is isn't only
4041 `eval-buffer' and `eval-defun' that's affected by
4042 `lexical-binding' (bug#8460).
4043
aa4b6df6
EZ
40442011-07-15 Eli Zaretskii <eliz@gnu.org>
4045
4046 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 4047 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 4048
5d856da6
PE
40492011-07-14 Paul Eggert <eggert@cs.ucla.edu>
4050
ad6042bb
PE
4051 Fix minor problems found by static checking.
4052 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
4053 (elsz): Now a signed constant, not a size_t var. We prefer signed
4054 types to unsigned, to avoid integer comparison confusion. Without
4055 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
4056 "cannot optimize loop, the loop counter may overflow", a symptom
4057 of the confusion.
f00bbb22 4058 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
4059 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
4060
6468f31c
LMI
40612011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4062
49080b10
LMI
4063 * search.c (Fre_search_backward): Mention `case-fold-search' in
4064 all the re_search_* functions (bug#8138).
4065
6468f31c
LMI
4066 * keyboard.c (Fopen_dribble_file): Document when the file is
4067 closed (bug#8056).
4068
c965adc5
EZ
40692011-07-14 Eli Zaretskii <eliz@gnu.org>
4070
df9733bf
EZ
4071 * bidi.c (bidi_dump_cached_states): Fix format of displaying
4072 bidi_cache_idx.
4073
0bb23927
EZ
4074 Support bidi reordering of display and overlay strings.
4075 * xdisp.c (compute_display_string_pos)
4076 (compute_display_string_end): Accept additional argument STRING.
4077 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
4078 (reseat_to_string): Initialize bidi_it->string.s and
4079 bidi_it->string.schars.
4080 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
4081 NULL (avoids a crash in bidi_paragraph_init).
4082 Initialize itb.string.lstring.
0bb23927
EZ
4083 (init_iterator): Call bidi_init_it only of a valid
4084 buffer position was specified. Initialize paragraph_embedding to
4085 L2R.
4086 (reseat_to_string): Initialize the bidi iterator.
4087 (display_string): If we need to ignore text properties of
4088 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
4089 original value of -1 will not work with bidi.)
4090 (compute_display_string_pos): First arg is now struct
4091 `text_pos *'; all callers changed. Support display properties on
4092 Lisp strings.
4093 (compute_display_string_end): Support display properties on Lisp
4094 strings.
4095 (init_iterator, reseat_1, reseat_to_string): Initialize the
4096 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
4097 when iterating on a string not from display properties).
640c8776
SM
4098 (compute_display_string_pos, compute_display_string_end):
4099 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
4100 arrow keys.
4101 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
4102 base_level_stop; instead, set base_level_stop to BEGV.
4103 Fixes crashes in vertical-motion.
0bb23927
EZ
4104 (next_element_from_buffer): Improve commentary for when
4105 the iterator is before prev_stop.
4106 (init_iterator): Initialize bidi_p from the default value of
4107 bidi-display-reordering, not from buffer-local value. Use the
4108 buffer-local value only if initializing for buffer iteration.
4109 (handle_invisible_prop): Support invisible properties on strings
4110 that are being bidi-reordered.
4111 (set_iterator_to_next): Support bidi reordering of C strings and
4112 Lisp strings.
4113 (next_element_from_string): Support bidi reordering of Lisp
4114 strings.
4115 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
4116 (display_string): Support display of R2L glyph rows.
4117 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
4118 (init_iterator): Don't initialize it->bidi_p for strings
4119 here.
4120 (reseat_to_string): Initialize it->bidi_p for strings here.
4121 (next_element_from_string, next_element_from_c_string)
4122 (next_element_from_buffer): Add xassert's for correspondence
4123 between IT's object being iterated and it->bidi_it.string
4124 structure.
4125 (face_before_or_after_it_pos): Support bidi iteration.
4126 (next_element_from_c_string): Handle the case of the first string
4127 character that is not the first one in the visual order.
4128 (get_visually_first_element): New function, refactored from common
4129 parts of next_element_from_buffer, next_element_from_string, and
4130 next_element_from_c_string.
4131 (tool_bar_lines_needed, redisplay_tool_bar)
4132 (display_menu_bar): Force left-to-right direction. Add a FIXME
4133 comment for making that be controlled by a user option.
4134 (push_it, pop_it): Save and restore the state of the
4135 bidi iterator. Save and restore the bidi_p flag.
4136 (pop_it): Iterate out of display property for string iteration as
4137 well.
4138 (iterate_out_of_display_property): Support iteration over strings.
4139 (handle_single_display_spec): Set up it->bidi_it for iteration
4140 over a display string, and call bidi_init_it.
4141 (handle_single_display_spec, next_overlay_string)
4142 (get_overlay_strings_1, push_display_prop): Set up the bidi
4143 iterator for displaying display or overlay strings.
4144 (forward_to_next_line_start): Don't use the shortcut if
4145 bidi-iterating.
4146 (back_to_previous_visible_line_start): If handle_display_prop
4147 pushed the iterator stack, restore the internal state of the bidi
4148 iterator by calling bidi_pop_it same number of times.
4149 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4150 and we are bidi-iterating, don't decrement the iterator position;
4151 instead, set the first_elt flag in the bidi iterator, to produce
4152 the same effect.
4153 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4154 (push_display_prop): xassert that we are iterating a buffer.
4155 (push_it, pop_it): Save and restore paragraph_embedding member.
4156 (handle_single_display_spec, next_overlay_string)
4157 (get_overlay_strings_1, reseat_1, reseat_to_string)
4158 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4159 correctly. Don't assume unibyte strings are not bidi-reordered.
4160 (compute_display_string_pos)
4161 (compute_display_string_end): Fix handling the case of C string.
4162 (push_it, pop_it): Save and restore from_disp_prop_p.
4163 (handle_single_display_spec, push_display_prop): Set the
4164 from_disp_prop_p flag.
4165 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4166 (pop_it): Call iterate_out_of_display_property only if we are
4167 popping after iteration over a string that came from a display
4168 property. Fix a typo in popping stretch info. Add an assertion
4169 for verifying that the iterator position is in sync with the bidi
4170 iterator.
4171 (handle_single_display_spec, get_overlay_strings_1)
4172 (push_display_prop): Fix initialization of paragraph direction for
4173 string when that of the parent object is not yet determined.
4174 (reseat_1): Call bidi_init_it to resync the bidi
4175 iterator with IT's position. (Bug#7616)
4176 (find_row_edges): If ROW->start.pos gives position
4177 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4178 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4179 Reset the from_disp_prop_p flag.
4180 (SAVE_IT, RESTORE_IT): New macros.
4181 (pos_visible_p, face_before_or_after_it_pos)
4182 (back_to_previous_visible_line_start)
4183 (move_it_in_display_line_to, move_it_in_display_line)
4184 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4185 (try_scrolling, redisplay_window, display_line): Use them when
4186 saving a temporary copy of the iterator and restoring it back.
4187 (back_to_previous_visible_line_start, reseat_1)
4188 (init_iterator): Empty the bidi cache "stack".
4189 (move_it_in_display_line_to): If iterator ended up at
4190 EOL, but we never saw any buffer positions smaller than
4191 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4192 motion in bidi-reordered lines.
4193 (move_it_in_display_line_to): Record prev_method and prev_pos
4194 immediately before the call to set_iterator_to_next. Fixes cursor
4195 motion in bidi-reordered lines with stretch glyphs and strings
4196 displayed in margins. (Bug#8133) (Bug#8867)
4197 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4198 TO_CHARPOS.
640c8776
SM
4199 (pos_visible_p): Support positions in bidi-reordered lines.
4200 Save and restore bidi cache.
0bb23927
EZ
4201
4202 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4203 (bidi_paragraph_info): Delete unused struct.
4204 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4205 (bidi_cache_start): New variable.
4206 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4207 to zero.
4208 (bidi_cache_fetch_state, bidi_cache_search)
4209 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4210 (bidi_cache_find, bidi_peek_at_next_level)
4211 (bidi_level_of_next_char, bidi_find_other_level_edge)
4212 (bidi_move_to_visually_next): Compare cache index with
4213 bidi_cache_start rather than with zero.
4214 (bidi_fetch_char): Accept new argument STRING; all callers
4215 changed. Support iteration over a string. Support strings with
4216 display properties. Support unibyte strings. Fix the type of
4217 `len' according to what STRING_CHAR_AND_LENGTH expects.
4218 (bidi_paragraph_init, bidi_resolve_explicit_1)
4219 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
4220 (bidi_level_of_next_char, bidi_move_to_visually_next):
4221 Support iteration over a string.
0bb23927
EZ
4222 (bidi_set_sor_type, bidi_resolve_explicit_1)
4223 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4224 can now be zero (for strings); special values 0 and -1 were
4225 changed to -1 and -2, respectively.
4226 (bidi_char_at_pos): New function.
4227 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4228 Call it instead of FETCH_MULTIBYTE_CHAR.
4229 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4230 initialized to valid values.
4231 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4232 values.
4233 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4234 the test for valid cached positions. Fix the logic for looking up
4235 the sentinel state in the cache. GCPRO the Lisp string we are
4236 iterating.
4237 (bidi_push_it, bidi_pop_it): New functions.
4238 (bidi_initialize): Initialize the bidi cache start stack pointer.
4239 (bidi_cache_ensure_space): New function, refactored from part of
4240 bidi_cache_iterator_state. Don't assume the required size is just
4241 one BIDI_CACHE_CHUNK away.
4242 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4243 (bidi_count_bytes, bidi_char_at_pos): New functions.
4244 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4245 always valid if bidi_cache_idx is valid.
4246 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4247 is valid if it's going to be used.
4248 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4249 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
4250 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4251 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
4252 (bidi_find_other_level_edge, bidi_cache_start_stack):
4253 All variables related to cache indices are now EMACS_INT.
c965adc5 4254
0bb23927
EZ
4255 * dispextern.h (struct bidi_string_data): New structure.
4256 (struct bidi_it): New member `string'. Make flag members be 1-bit
4257 fields, and put them last in the struct.
640c8776
SM
4258 (compute_display_string_pos, compute_display_string_end):
4259 Update prototypes.
0bb23927
EZ
4260 (bidi_push_it, bidi_pop_it): Add prototypes.
4261 (struct iterator_stack_entry): New members bidi_p,
4262 paragraph_embedding, and from_disp_prop_p.
4263 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
4264 (bidi_shelve_cache, bidi_unshelve_cache):
4265 Declare prototypes.
0bb23927
EZ
4266
4267 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4268 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4269 and vector-like objects.
4270
4271 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4272 cache around display iteration.
4273
4274 * window.c (Fwindow_end, window_scroll_pixel_based)
4275 (displayed_window_lines, Frecenter): Save and restore the bidi
4276 cache around display iteration.
4277
3bbd2265
LMI
42782011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4279
4280 * editfns.c (Fdelete_region): Clarify the use of the named
4281 parameters (bug#6788).
4282
adc47434
MR
42832011-07-14 Martin Rudalics <rudalics@gmx.at>
4284
4285 * indent.c (Fvertical_motion): Set and restore w->pointm when
4286 saving and restoring the window's buffer (Bug#9006).
4287
837c31f8
LMI
42882011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4289
4290 * editfns.c (Fstring_to_char): Clarify just what is returned
4291 (bug#6576). Text by Eli Zaretskii.
4292
ac389d0c
JB
42932011-07-13 Juanma Barranquero <lekktu@gmail.com>
4294
4295 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4296
0be0ce47
EZ
42972011-07-13 Eli Zaretskii <eliz@gnu.org>
4298
4299 * buffer.c (mmap_find): Fix a typo.
4300
cd18e7e3
JB
43012011-07-13 Johan Bockgård <bojohan@gnu.org>
4302
4303 Fix execution of x selection hooks.
4304 * xselect.c (Qx_lost_selection_functions)
4305 (Qx_sent_selection_functions): New vars.
4306 (syms_of_xselect): DEFSYM them.
4307 (x_handle_selection_request): Pass Qx_sent_selection_functions
4308 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4309 (x_handle_selection_clear,x_clear_frame_selections):
4310 Pass Qx_lost_selection_functions rather than
4311 Vx_lost_selection_functions to Frun_hook_with_args.
4312
47ea7f44
PE
43132011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4314
ac389d0c 4315 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
4316 The old code sometimes used this field without initializing it.
4317
47ea7f44
PE
4318 * alloc.c (gc_sweep): Don't read past end of array.
4319 In theory, the old code could also have corrupted Emacs internals,
4320 though it'd be very unlikely.
4321
bc985c87
AS
43222011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4323
4324 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 4325 argument. (Bug#4026)
bc985c87 4326
0cf34688
LMI
43272011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4328
b3dadd76
LMI
4329 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4330 key" (bug#4257).
4331
0cf34688
LMI
4332 * window.c (Fset_window_start): Doc fix (bug#4199).
4333 (Fset_window_hscroll): Ditto.
4334
270768cd
PE
43352011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4336
077e3dda 4337 Fix minor new problems caught by GCC 4.6.1.
270768cd 4338 * term.c (init_tty): Remove unused local.
490011a6 4339 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 4340 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 4341 not used otherwise.
270768cd 4342
b1f58454
CY
43432011-07-12 Chong Yidong <cyd@stupidchicken.com>
4344
4345 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4346
22b9578d
LMI
43472011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4348
6e70ab07
LMI
4349 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4350 are the mini-buffer and the echo area (bug#3320).
4351
22b9578d
LMI
4352 * term.c (init_tty): Remove support for supdup, c10 and perq
4353 terminals, which are no longer supported (bug#1482).
4354
8974cc9f
JB
43552011-07-10 Johan Bockgård <bojohan@gnu.org>
4356
4357 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4358
a560d974
JD
43592011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4360
4361 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4362 for non-popups (Bug#3642).
4363
1dae0f0a
AS
43642011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4365
268c2c36 4366 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 4367 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
4368 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4369 * cm.c (losecursor): Likewise.
1dae0f0a
AS
4370 * data.c (fmod): Likewise.
4371 * dispnew.c (swap_glyphs_in_rows): Likewise.
4372 * emacs.c (memory_warning_signal): Likewise.
4373 * floatfns.c (float_error): Likewise.
4374 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4375 (otf_open, font_otf_capability, generate_otf_features)
4376 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4377 Likewise.
4378 * image.c (pbm_read_file): Likewise.
4379 * indent.c (string_display_width): Likewise.
4380 * intervals.c (check_for_interval, search_for_interval)
4381 (inc_interval_count, count_intervals, root_interval)
4382 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4383 * lread.c (defalias): Likewise.
268c2c36 4384 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
4385 * regex.c (set_image_of_range_1, set_image_of_range)
4386 (regex_grow_registers): Likewise.
4387 * sysdep.c (strerror): Likewise.
4388 * termcap.c (valid_filename_p, tprint, main): Likewise.
4389 * tparam.c (main): Likewise.
4390 * unexhp9k800.c (run_time_remap, save_data_space)
4391 (update_file_ptrs, read_header, write_header, calculate_checksum)
4392 (copy_file, copy_rest, display_header): Likewise.
4393 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4394 Likewise.
4395 * xdisp.c (check_it): Likewise.
4396 * xfaces.c (register_color, unregister_color, unregister_colors):
4397 Likewise.
4398 * xfns.c (print_fontset_result): Likewise.
4399 * xrdb.c (member, fatal, main): Likewise.
4400
99033785
PE
44012011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4402
4403 Fix minor problems found by static checking (Bug#9031).
4404 * chartab.c (char_table_set_range, map_sub_char_table):
4405 Remove unused locals.
4406 (uniprop_table): Now static.
4407 * composite.c (_work_char): Remove unused static var.
4408
9cb2ac56
JB
44092011-07-09 Juanma Barranquero <lekktu@gmail.com>
4410
4411 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4412
f25661f0
JD
44132011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4414
4415 * gtkutil.c (qttip_cb): Remove code without function.
4416
8278c4fe
EZ
44172011-07-09 Eli Zaretskii <eliz@gnu.org>
4418
4419 * w32.c (pthread_sigmask): New stub.
4420
1692ae2d 44212011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 4422
8a6ebd58 4423 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
4424 sigprocmask is portable only for single-threaded applications, and
4425 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
4426 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4427 (LIBES): Use it.
4428 * callproc.c (Fcall_process):
4429 * process.c (create_process):
4430 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4431 Use pthread_sigmask, not sigprocmask.
123403e4 4432
1b854618
JD
44332011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4434
4435 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4436 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4437 wrong (Bug#8591).
4438
3fe4b549
JD
44392011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4440
0ce7e563
JD
4441 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4442 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4443 (xg_hide_tooltip): Fix comment.
4444
3fe4b549
JD
4445 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4446 in registerServicesMenuSendTypes.
4447 (validRequestorForSendType): Don't check ns_return_types.
4448
4449 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4450 ns_return_type.
4451
5df75e47
JR
44522011-07-08 Jason Rumney <jasonr@gnu.org>
4453
22610910
JR
4454 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4455 SH_SHOW for hidden windows (Bug#5482).
4456
5df75e47
JR
4457 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4458 frame struct members of non-existent frames (Bug#6284).
4459
699c10bd
JD
44602011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4461
4393663b
JD
4462 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4463 variable firstTime not needed on OSX >= 10.6.
4464 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4465 >= 10.5. Use setKnobProportion, setDoubleValue.
4466
4467 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4468 (MAC_OS_X_VERSION_10_5): Define if not defined.
4469 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4470 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4471 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4472
4473 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4474 cString and lossyCString on OSX >= 10.4
4475
58179cce 4476 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
4477 sizeToFit on OSX >= 10.2.
4478
4479 * nsimage.m (allocInitFromFile): Don't use deprecated method
4480 bestRepresentationForDevice on OSX >= 10.6.
4481
4482 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4483 to avoid warning.
4484
4485 * emacs.c: Declare unexec_init_emacs_zone.
4486
a63e0781
JD
4487 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4488
699c10bd
JD
4489 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4490
4491 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4492 on svcsMenu (Bug#8842).
4493
4494 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4495 ns_return_types.
4496 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4497
4498 * nsterm.m (QUTF8_STRING): Declare.
4499 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4500 (validRequestorForSendType): Return type is (id).
4501 Change indexOfObjectIdenticalTo to indexOfObject.
4502 Check if we have local selection before returning self (Bug#8842).
4503 (writeSelectionToPasteboard): Put local selection into paste board
4504 if we have a local selection (Bug#8842).
4505 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4506
4507 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4508 (ns_get_local_selection): Declare.
4509
54e10184
LMI
45102011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4511
9888ff71
LMI
4512 * keymap.c (describe_map_tree): Don't insert a double newline at
4513 the end of the buffer (bug#1169) and return whether we inserted
4514 something.
4515
54e10184
LMI
4516 * callint.c (Fcall_interactively): Change "reading args" to
4517 "providing args" to try to clarify what it does (bug#1010).
4518
15fa4783
KH
45192011-07-07 Kenichi Handa <handa@m17n.org>
4520
4521 * composite.c (composition_compute_stop_pos): Ignore a static
4522 composition starting before CHARPOS (Bug#8915).
4523
4524 * xdisp.c (handle_composition_prop): Likewise.
4525
a8815b00
EZ
45262011-07-07 Eli Zaretskii <eliz@gnu.org>
4527
4528 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4529 (Bug#9015)
4530
ef7b981d 45312011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
4532
4533 * character.h (unicode_category_t): New enum type.
4534
4535 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4536 (Qchar_code_property_table): New variable.
4537 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4538 (UNIPROP_COMPRESSED_FORM_P): New macros.
4539 (char_table_ascii): Uncompress the compressed values.
4540 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4541 Uncompress the compressed values.
ac389d0c 4542 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
4543 (char_table_ref_and_range): Uncompress the compressed values.
4544 (sub_char_table_set): New arg is_uniprop. Callers changed.
4545 Uncompress the compressed values.
4546 (sub_char_table_set_range): Args changed. Callers changed.
4547 (char_table_set_range): Adjuted for the above change.
4548 (map_sub_char_table): Delete args default_val and parent. Add arg
4549 top. Give decoded values to a Lisp function.
640c8776 4550 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
4551 values to a Lisp function. Gcpro more variables.
4552 (uniprop_table_uncompress)
4553 (uniprop_decode_value_run_length): New functions.
4554 (uniprop_decoder, uniprop_decoder_count): New variables.
4555 (uniprop_get_decoder, uniprop_encode_value_character)
4556 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4557 New functions.
4558 (uniprop_encoder, uniprop_encoder_count): New variables.
4559 (uniprop_get_encoder, uniprop_table)
4560 (Funicode_property_table_internal, Fget_unicode_property_internal)
4561 (Fput_unicode_property_internal): New functions.
4562 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4563 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 4564 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
4565 char-code-property-alist.
4566
640c8776 4567 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
4568 Vunicode_category_table.
4569
640c8776 4570 * font.c (font_range): Adjust for the change of
c805dec0
KH
4571 Vunicode_category_table.
4572
76b397fb
DN
45732011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4574
4575 * m/iris4d.h: Remove file, move contents ...
4576 * s/irix6-5.h: ... here.
4577
22b4128e
PE
45782011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4579
4580 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
4581 * alloc.c (mark_buffer):
4582 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4583 (clone_per_buffer_values): Don't assume that
22b4128e
PE
4584 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4585 This isn't true in general, and it's particularly not true
4586 if Emacs is configured with --with-wide-int.
4587 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4588 New macros, used in the buffer.c change.
4589
869795d6
JD
45902011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4591
4592 * xsettings.c: Use both GConf and GSettings if both are available.
4593 (store_config_changed_event): Add comment.
4594 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4595 (store_tool_bar_style_changed): New functions.
5e617bc2 4596 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
4597 (struct xsettings): Move font inside HAVE_XFT.
4598 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 4599 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 4600 Move inside HAVE_XFT.
640c8776 4601 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
4602 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4603 also.
4604 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 4605 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 4606 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
4607 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4608 (parse_settings): Move check for font inside HAVE_XFT.
4609 (read_settings, apply_xft_settings): Add comment.
4610 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4611 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4612 call store_font_name_changed.
4613 (xft_settings_event): Add comment.
4614 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4615 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4616 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4617 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4618 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
4619 (xsettings_get_system_font, xsettings_get_system_normal_font):
4620 Add comment.
869795d6 4621
d8ed26bd
PE
46222011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4623
4624 Random fixes. E.g., (random) never returned negative values.
4625 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4626 subseconds part to the entropy, as that's a bit more random.
4627 Prefer signed to unsigned, since the signedness doesn't matter and
4628 in general we prefer signed. When given a limit, use a
4629 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4630 latter isn't right if USE_2_TAGS_FOR_INTS.
4631 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4632 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4633
cabf1cac
SM
46342011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4635
4636 * textprop.c (text_property_stickiness):
4637 Obey Vtext_property_default_nonsticky.
4638 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4639 * w32fns.c (syms_of_w32fns):
4640 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4641
6e9b2be9
PE
46422011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4643
4644 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4645 This is more efficient than Ffile_directory_p and avoids a minor race.
4646
90186c68
LMI
46472011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4648
7c301272
LMI
4649 * buffer.c (Foverlay_put): Say what the return value is
4650 (bug#7835).
4651
c4f2d8d4
LMI
4652 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4653 is a directory before asking whether to use the file name
4654 (bug#7564).
ad637907
LMI
4655 (barf_or_query_if_file_exists): Make the "File is a directory"
4656 error be more correct.
c4f2d8d4 4657
90186c68
LMI
4658 * fns.c (Frequire): Remove the mention of the .gz files, since
4659 that's installation-specific, but keep the mention of
4660 `get-load-suffixes'.
4661
da64016e
PE
46622011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4663
4664 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4665 Report string overflow if the output is too long.
4666
7d47b580
JB
46672011-07-04 Juanma Barranquero <lekktu@gmail.com>
4668
a555cb87
JB
4669 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4670 (syms_of_gnutls): Remove duplicate DEFSYM for
4671 Qgnutls_bootprop_verify_hostname_error, an error for
4672 Qgnutls_bootprop_verify_error (which is no longer used).
4673
7d47b580
JB
4674 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4675 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4676 Also (re)move comments that are misplaced or no longer relevant.
4677
1e49bfab
LMI
46782011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4679
4680 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4681
1485f4c0
CY
46822011-07-03 Chong Yidong <cyd@stupidchicken.com>
4683
4684 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4685 and background color parameters if they have been changed.
4686
a9ab721e
LMI
46872011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4688
4689 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4690
cf7cff57
PE
46912011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4692
2e13213d
PE
4693 * xsettings.c (SYSTEM_FONT): Define only when used.
4694 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4695
cf7cff57
PE
4696 * keymap.c (access_keymap_1): Now static.
4697
7a8e04f7
CY
46982011-07-02 Chong Yidong <cyd@stupidchicken.com>
4699
4700 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4701 leave any prefix arg for the up event (Bug#1586).
4702
61352f62
LMI
47032011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4704
69bb1ef7
LMI
4705 * lread.c (syms_of_lread): Mention single symbols defined by
4706 `defvar' or `defconst' (bug#7154).
4707
61352f62 4708 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 4709 (Frequire): Mention get-load-suffixes.
61352f62 4710
28545e04
MR
47112011-07-02 Martin Rudalics <rudalics@gmx.at>
4712
4713 * window.h (window): Remove clone_number slot.
4714 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4715 Remove.
4716 (make_parent_window, make_window, saved_window)
4717 (Fset_window_configuration, save_window_save): Don't deal with
4718 clone numbers.
4719 * buffer.c (Qclone_number): Remove declaration.
4720 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4721
3349e122
SM
47222011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4723
4724 Add multiple inheritance to keymaps.
4725 * keymap.c (Fmake_composed_keymap): New function.
4726 (Fset_keymap_parent): Simplify.
4727 (fix_submap_inheritance): Remove.
4728 (access_keymap_1): New function extracted from access_keymap to handle
4729 embedded parents and handle lists of maps.
4730 (access_keymap): Use it.
4731 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4732 (Fcopy_keymap): Handle embedded parents.
4733 (Fcommand_remapping, define_as_prefix): Simplify.
4734 (Fkey_binding): Simplify.
4735 (syms_of_keymap): Move minibuffer-local-completion-map,
4736 minibuffer-local-filename-completion-map,
4737 minibuffer-local-must-match-map, and
4738 minibuffer-local-filename-must-match-map to Elisp.
4739 (syms_of_keymap): Defsubr make-composed-keymap.
4740 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4741 (parse_menu_item): Trivial simplification.
4742
3279eb87
GM
47432011-07-01 Glenn Morris <rgm@gnu.org>
4744
4745 * Makefile.in (SETTINGS_LIBS): Fix typo.
4746
4550efdf
KI
47472011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4748
4749 * coding.c (Fencode_coding_string): Record the last coding system
4750 used, as the function doc string says (bug#8738).
4751
0949d2b6
JD
47522011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4753
4754 * xsettings.c (store_monospaced_changed): Take new font as arg and
4755 check for change against current_mono_font.
4756 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4757 (emacs_settings_constructor, emacs_settings_get_property)
4758 (emacs_settings_set_property, emacs_settings_class_init)
4759 (emacs_settings_init, gsettings_obj): Remove.
4760 (something_changedCB): New function for HAVE_GSETTINGS.
4761 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4762 with value as argument.
4763 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4764 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 4765 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
4766 "changed".
4767
4768 * xgselect.c: Add defined (HAVE_GSETTINGS).
4769 (xgselect_initialize): Ditto.
4770
4771 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4772 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4773 xg_select.
4774
bbc6b304
PE
47752011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4776
4777 * eval.c (struct backtrace): Simplify and port the data structure.
4778 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4779 signed bit field, as this assumption is not portable and it makes
4780 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4781 "char debug_on_exit : 1" as this is not portable either; instead,
4782 use the portable "unsigned int debug_on_exit : 1". Remove unused
4783 member evalargs. Remove obsolete comments about cc bombing out.
4784
9851bfc5
JD
47852011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4786
51bb811f 4787 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
4788 Let HAVE_GSETTINGS override HAVE_GCONF.
4789 (store_monospaced_changed): New function.
4790 (EMACS_SETTINGS): A new type derived from GObject to handle
4791 GSettings notifications.
4792 (emacs_settings_constructor, emacs_settings_get_property)
4793 (emacs_settings_set_property, emacs_settings_class_init):
4794 New functions.
4795 (gsettings_client, gsettings_obj): New variables.
4796 (GSETTINGS_SCHEMA): New define.
4797 (something_changedCB): Call store_monospaced_changed.
4798 (init_gsettings): New function.
4799 (xsettings_initialize): Call init_gsettings.
4800 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4801 to NULL.
4802
640c8776 4803 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
4804 GCONF_CFLAGS/LIBS.
4805
5386012d
MR
48062011-06-29 Martin Rudalics <rudalics@gmx.at>
4807
4808 * window.c (resize_root_window, grow_mini_window)
4809 (shrink_mini_window): Rename Qresize_root_window to
4810 Qwindow_resize_root_window and Qresize_root_window_vertically to
4811 Qwindow_resize_root_window_vertically.
4812
f13e0b08
PE
48132011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4814
4815 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4816
94515237
JB
48172011-06-27 Juanma Barranquero <lekktu@gmail.com>
4818
4819 * makefile.w32-in: Redesign dependencies so they reflect more
4820 clearly which files are directly included by each source file,
4821 and not through other includes.
4822
e43b6e43
MR
48232011-06-27 Martin Rudalics <rudalics@gmx.at>
4824
4825 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4826 (sort_overlays, overlay_strings): When an overlay's clone number
4827 matches the window's clone number process the overlay even if
4828 the overlay's window property doesn't match the current window.
4829
d68443dc
MR
4830 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4831 (Fwindow_hchild): Rename to Fwindow_left_child.
4832 (Fwindow_next): Rename to Fwindow_next_sibling.
4833 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
4834 (resize_window_check): Rename to window_resize_check.
4835 (resize_window_apply): Rename to window_resize_apply.
4836 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4837 (Fdelete_other_windows_internal, resize_frame_windows)
4838 (Fsplit_window_internal, Fdelete_window_internal)
4839 (grow_mini_window, shrink_mini_window)
4840 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 4841
c7e73be5
JD
48422011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4843
4844 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4845 (emacs_fixed_set_min_size): Remove.
4846 (emacs_fixed_new): Take frame as argument.
4847
4848 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4849 (_EmacsFixedPrivate): Remove minwidth/height.
4850 Add struct frame *f.
4851 (emacs_fixed_init): Initialize priv->f.
4852 (get_parent_class, emacs_fixed_set_min_size): Remove.
4853 (emacs_fixed_new): Set priv->f to argument.
4854 (emacs_fixed_get_preferred_width)
4855 (emacs_fixed_get_preferred_height): Use min_width/height from
4856 frames size_hint to set minimum and natural (Bug#8919).
4857 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4858 and use min_width/height from frames size_hint to set
4859 min_width/height (Bug#8919).
4860
4861 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
4862 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4863 Fix indentation.
c7e73be5 4864
cf99dcf8
EZ
48652011-06-26 Eli Zaretskii <eliz@gnu.org>
4866
4867 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4868 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4869 called at ZV.
4870
029529ac
CY
48712011-06-26 Chong Yidong <cyd@stupidchicken.com>
4872
4873 * process.c (wait_reading_process_output): Bypass select if
4874 waiting for a cell while ignoring keyboard input, and input is
4875 pending. Suggested by Jan Djärv (Bug#8869).
4876
7a7ef429
PE
48772011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4878
4879 Use gnulib's dup2 module instead of rolling our own.
4880 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4881
11fdef7d 48822011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
4883
4884 * dispnew.c (scrolling_window): Before scrolling, turn off a
4885 mouse-highlight in the window being scrolled.
4886
cd3520a4
JB
48872011-06-24 Juanma Barranquero <lekktu@gmail.com>
4888
4889 Move DEFSYM to lisp.h and use everywhere.
4890
4891 * character.h (DEFSYM): Move declaration...
4892 * lisp.h (DEFSYM): ...here.
4893
4894 * gnutls.c:
4895 * minibuf.c:
4896 * w32menu.c:
4897 * w32proc.c:
4898 * w32select.c: Don't include character.h.
4899
4900 * alloc.c (syms_of_alloc):
4901 * buffer.c (syms_of_buffer):
4902 * bytecode.c (syms_of_bytecode):
4903 * callint.c (syms_of_callint):
4904 * casefiddle.c (syms_of_casefiddle):
4905 * casetab.c (init_casetab_once):
4906 * category.c (init_category_once, syms_of_category):
4907 * ccl.c (syms_of_ccl):
4908 * cmds.c (syms_of_cmds):
4909 * composite.c (syms_of_composite):
4910 * dbusbind.c (syms_of_dbusbind):
4911 * dired.c (syms_of_dired):
4912 * dispnew.c (syms_of_display):
4913 * doc.c (syms_of_doc):
4914 * editfns.c (syms_of_editfns):
4915 * emacs.c (syms_of_emacs):
4916 * eval.c (syms_of_eval):
4917 * fileio.c (syms_of_fileio):
4918 * fns.c (syms_of_fns):
4919 * frame.c (syms_of_frame):
4920 * fringe.c (syms_of_fringe):
4921 * insdel.c (syms_of_insdel):
4922 * keymap.c (syms_of_keymap):
4923 * lread.c (init_obarray, syms_of_lread):
4924 * macros.c (syms_of_macros):
4925 * msdos.c (syms_of_msdos):
4926 * print.c (syms_of_print):
4927 * process.c (syms_of_process):
4928 * search.c (syms_of_search):
4929 * sound.c (syms_of_sound):
4930 * syntax.c (init_syntax_once, syms_of_syntax):
4931 * terminal.c (syms_of_terminal):
4932 * textprop.c (syms_of_textprop):
4933 * undo.c (syms_of_undo):
4934 * w32.c (globals_of_w32):
4935 * window.c (syms_of_window):
4936 * xdisp.c (syms_of_xdisp):
4937 * xfaces.c (syms_of_xfaces):
4938 * xfns.c (syms_of_xfns):
4939 * xmenu.c (syms_of_xmenu):
4940 * xsettings.c (syms_of_xsettings):
4941 * xterm.c (syms_of_xterm): Use DEFSYM.
4942
4228cf16
TZ
49432011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4944
cd3520a4 4945 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 4946
7fcccf1e
PE
49472011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4948
7efb4e0e
PE
4949 Integer and buffer overflow fixes (Bug#8873).
4950
ff5844ad
PE
4951 * print.c (printchar, strout): Check for string overflow.
4952 (PRINTPREPARE, printchar, strout):
4953 Don't set size unless allocation succeeds.
4954
90532f02
PE
4955 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4956 for sizes. Check for string overflow more accurately.
4957 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4958
6d84508d
PE
4959 * macros.c: Integer and buffer overflow fixes.
4960 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4961 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4962 Use ptrdiff_t, not int, for sizes.
4963 Don't increment bufsize until after realloc succeeds.
4964 Check for size-calculation overflow.
4965 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4966
437b2cb4
PE
4967 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4968
8b9ac8b4
PE
4969 * lread.c: Integer overflow fixes.
4970 (read_integer): Radix is now EMACS_INT, not int,
4971 to improve quality of diagnostics for out-of-range radices.
4972 Calculate buffer size correctly for out-of-range radices.
4973 (read1): Check for integer overflow in radices, and in
4974 read-circle numbers.
82cb60d3
PE
4975 (read_escape): Avoid int overflow.
4976 (Fload, openp, read_buffer_size, read1)
4977 (substitute_object_recurse, read_vector, read_list, map_obarray):
4978 Use ptrdiff_t, not int, for sizes.
4979 (read1): Use EMACS_INT, not int, for sizes.
20270765 4980 Check for size overflow.
8b9ac8b4 4981
7fcccf1e
PE
4982 * image.c (cache_image): Check for size arithmetic overflow.
4983
bfbbd7e7
PE
4984 * lread.c: Integer overflow issues.
4985 (saved_doc_string_size, saved_doc_string_length)
4986 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4987 Now ptrdiff_t, not int.
4988 (read1): Don't assume doc string length fits in int. Check for
4989 out-of-range doc string lengths.
4990 (read_list): Don't assume file position fits in int.
39019e54 4991 (read_escape): Check for hex character overflow.
bfbbd7e7 4992
4e323265
LL
49932011-06-22 Leo Liu <sdl.web@gmail.com>
4994
4995 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4996 Move to minibuffer.el.
4997
85fece3e
PE
49982011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4999
20b84ce9 5000 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
5001 The following patches are for when GLYPH_DEBUG && !XASSERT.
5002 * dispextern.h (trace_redisplay_p, dump_glyph_string):
5003 * dispnew.c (flush_stdout):
5004 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
5005 Mark as externally visible.
5006 * dispnew.c (check_window_matrix_pointers): Now static.
5007 * dispnew.c (window_to_frame_vpos):
5008 * xfns.c (unwind_create_frame):
5009 * xterm.c (x_check_font): Remove unused local.
5010 * scroll.c (CHECK_BOUNDS):
5011 * xfaces.c (cache_fache): Rename local to avoid shadowing.
5012 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
5013 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
5014 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
5015 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
5016 Now static.
5017 (debug_method_add): Use va_list and vsprintf rather than relying
5018 on undefined behavior with wrong number of arguments.
5019 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
5020 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
5021 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
5022 since we're not interested in debugging glyphs with old libraries.
5023 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
5024 GCC 4.6.0's static checking.
5025
0766b489
PE
50262011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5027
31fd4b32
PE
5028 Integer overflow and signedness fixes (Bug#8873).
5029 A few related buffer overrun fixes, too.
5030
b79e8648
PE
5031 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
5032
0766b489
PE
5033 * dispextern.h (struct face.stipple):
5034 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
5035 (x_bitmap_mask, x_allocate_bitmap_record)
5036 (x_create_bitmap_from_data, x_create_bitmap_from_file)
5037 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
5038 (x_create_bitmap_from_xpm_data):
5039 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
5040 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
5041 (.bitmaps_last):
5042 * xfaces.c (load_pixmap):
5043 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
5044 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
5045 (.bitmaps_last, struct x_output.icon_bitmap):
5046 Use ptrdiff_t, not int, for bitmap indexes.
5047 (x_allocate_bitmap_record): Check for size overflow.
5048 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
5049
b081724f
PE
5050 Use ptrdiff_t, not int, for overlay counts.
5051 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
5052 * editfns.c (overlays_around, get_pos_property):
5053 * textprop.c (get_char_property_and_overlay):
5054 * xdisp.c (next_overlay_change, note_mouse_highlight):
5055 * xfaces.c (face_at_buffer_position):
21514da7
PE
5056 * buffer.c (OVERLAY_COUNT_MAX): New macro.
5057 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
5058 (Fnext_overlay_change, Fprevious_overlay_change)
5059 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 5060 Use ptrdiff_t, not int, for sizes.
21514da7 5061 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 5062
3de73e5e
PE
5063 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
5064
2606c57b
PE
5065 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
5066 (x_session_initialize): Do not assume string length fits in int.
5067
aaafe47a
PE
5068 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
5069 This is unlikely, but can occur if DPI is outlandish.
5070
2674ddc8 5071 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
5072 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
5073
28154962
PE
5074 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
5075 * xrdb.c (magic_file_p, search_magic_path):
5076 Omit last arg SUFFIX; it was always 0. All callers changed.
5077 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
5078
7de51af5
PE
5079 * xfont.c (xfont_match): Avoid need for strlen.
5080
25ed6cc3
PE
5081 * xfns.c: Don't assume strlen fits in int.
5082 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
5083
4eab31dd
PE
5084 * xdisp.c (message_log_check_duplicate): Return intmax_t,
5085 not unsigned long, as we prefer signed integers. All callers changed.
5086 Detect integer overflow in repeat count.
5087 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 5088 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 5089
171e2a58
PE
5090 * termcap.c: Don't assume sizes fit in int and never overflow.
5091 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
5092 (gobble_line): Check for size-calculation overflow.
5093
ad39faca 5094 * minibuf.c (Fread_buffer):
6e5bb2dc 5095 * lread.c (intern, intern_c_string):
74ca2eb3
PE
5096 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
5097 Don't assume string length fits in int.
5098
52c61c22 5099 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
5100 * gtkutil.c (style_changed_cb): Avoid need for strlen.
5101
b5b8c9e5
PE
5102 * font.c: Don't assume string length fits in int.
5103 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
5104 Use ptrdiff_t, not int.
ccd6111c
PE
5105 (font_intern_prop): Don't assume string length fits in int.
5106 Don't assume integer property fits in fixnum.
5107 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 5108
882f0d81 5109 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 5110 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
5111 Reformulate so as not to need the command string.
5112 Invoke gzip -cd rather than gunzip, as it's more portable.
5113 (lock_info_type, lock_file_1, lock_file):
5114 Don't assume pid_t and time_t fit in unsigned long.
5115 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
5116 (current_lock_owner): Prefer signed type for sizes.
5117 Use memcpy, not strncpy, where memcpy is what is really wanted.
5118 Don't assume (via atoi) that time_t and pid_t fit in int.
5119 Check for time_t and/or pid_t out of range, e.g., via a network share.
5120 Don't alloca where an auto var works fine.
5121
93f4cf88
PE
5122 * fileio.c: Fix some integer overflow issues.
5123 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
5124 Don't assume string length fits in int.
5125 (directory_file_name): Don't assume string length fits in long.
5126 (make_temp_name): Don't assume pid fits in int, or that its print
5127 length is less than 20.
5128
f3e92b69
PE
5129 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
5130
1bfdaf10
PE
5131 * coding.c (make_subsidiaries): Don't assume string length fits in int.
5132
35016e9a
PE
5133 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
5134
3d1e65a1
PE
5135 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
5136 We prefer signed integers, even for size calculations.
5137
0b963a93
PE
5138 * emacs.c: Don't assume string length fits in 'int'.
5139 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
5140 (main): Don't invoke strlen when not needed.
5141
573f4b54
PE
5142 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5143 (XD_DEBUG_MESSAGE): Don't waste a byte.
5144
989f33ba
PE
5145 * callproc.c (getenv_internal_1, getenv_internal)
5146 (Fgetenv_internal):
965d34eb
PE
5147 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5148
e4d29b33
PE
5149 * lread.c (invalid_syntax): Omit length argument.
5150 All uses changed. This doesn't fix a bug, but it simplifies the
5151 code away from its former Hollerith-constant appearance, and it's
5152 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 5153 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 5154
eb49b136
PE
5155 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5156 This didn't break anything, but it didn't help either.
5157 It's confusing to put a bogus integer in a place where the actual
5158 value does not matter.
9f62aeb1 5159 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 5160 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 5161
15375a22
PE
5162 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5163 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5164 implementation.
b61cc01c
PE
5165 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5166 We prefer signed types, and the value cannot exceed the EMACS_INT
5167 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
5168 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5169 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5170 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 5171
53b2623d
PE
5172 * indent.c (sane_tab_width): New function.
5173 (current_column, scan_for_column, Findent_to, position_indentation)
5174 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 5175 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 5176
51cab52b 5177 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 5178
f2ed8a70
PE
5179 * lisp.h (lint_assume): New macro.
5180 * composite.c (composition_gstring_put_cache):
5181 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5182
abe80cc6
PE
5183 * editfns.c, insdel.c:
5184 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 5185
b02c740e
PE
5186 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5187
ebc96716
PE
5188 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5189
b4e50fa0 5190 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 5191 Use much-faster test for byte-length change.
311d5d7c 5192 Don't assume string byte-length fits in 'int'.
a4cf38e4 5193 Check that character arg fits in 'int'.
85461888 5194 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 5195
c0c1ee9f
PE
5196 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5197
a498d7f4
PE
5198 * fns.c (concat): Catch string overflow earlier.
5199 Do not rely on integer wraparound.
5200
51cab52b
PE
5201 * dispextern.h (struct it.overlay_strings_charpos)
5202 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
5203 * xdisp.c (forward_to_next_line_start)
5204 (back_to_previous_visible_line_start)
5205 (reseat_at_next_visible_line_start, next_element_from_buffer):
5206 Don't arbitrarily truncate the value of 'selective' to int.
5207
76031fad
PE
5208 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5209
5eb55db9
PE
5210 * composite.c: Don't truncate sizes to 'int'.
5211 (composition_gstring_p, composition_reseat_it)
5212 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
5213 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5214 not EMACS_UINT, for indexes.
5eb55db9 5215
0703a717
PE
5216 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5217
d6202519
PE
5218 * buffer.c: Include <verify.h>.
5219 (struct sortvec.priority, struct sortstr.priority):
8961a454 5220 Now EMACS_INT, not int.
c20998a7 5221 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
5222 (struct sortstr.size, record_overlay_string)
5223 (struct sortstrlist.size, struct sortlist.used):
5224 Don't truncate size to int.
5225 (record_overlay_string): Check for size-calculation overflow.
d6202519 5226 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 5227
d5a19415
JM
52282011-06-22 Jim Meyering <meyering@redhat.com>
5229
029529ac 5230 Don't leak an XBM-image-sized buffer
d5a19415
JM
5231 * image.c (xbm_load): Free the image buffer after using it.
5232
a9041e6c
PE
52332011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5234
5235 Port to Sun C.
5236 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5237 that Sun C diagnosed.
5238 * fns.c (secure_hash): Fix pointer signedness issue.
5239 * intervals.c (static_offset_intervals): New function.
5240 (offset_intervals): Use it.
5241
7f3f739f
LL
52422011-06-21 Leo Liu <sdl.web@gmail.com>
5243
5244 * deps.mk (fns.o):
5245 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5246 sha512.h.
5247
5248 * fns.c (secure_hash): Rename from crypto_hash_function and change
5249 the first arg to accept symbols.
5b66d427 5250 (Fsecure_hash): New primitive.
7f3f739f
LL
5251 (syms_of_fns): New symbols.
5252
76147d94
DD
52532011-06-20 Deniz Dogan <deniz@dogan.se>
5254
5255 * process.c (Fset_process_buffer): Clarify return value in
5256 docstring.
5257
7d7d0045
CY
52582011-06-18 Chong Yidong <cyd@stupidchicken.com>
5259
5260 * dispnew.c (add_window_display_history): Use BVAR.
5261
5262 * xdisp.c (debug_method_add): Use BVAR.
5263 (check_window_end, dump_glyph_matrix, dump_glyph)
5264 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5265
5266 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5267 Likewise.
5268
5269 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5270 check till after the cache is created in init_frame_faces.
5271
ff2bc410
SM
52722011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5273
5274 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5275
28177add
PE
52762011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5277
dd3482fe
PE
5278 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5279 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5280 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5281
393d71f3 5282 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
5283 * fileio.c (Finsert_file_contents):
5284 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5285 Remove the old (too-loose) buffer overflow checks.
5286 They weren't needed, since make_gap checks for buffer overflow.
5287 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5288 The old code merely checked for Emacs fixnum overflow, and relied
5289 on undefined (wraparound) behavior. The new code avoids undefined
5290 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5291
2e6813b0 5292 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
5293 Tune. Don't use wider integers than needed. Don't use alloca.
5294 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 5295
599a9e4f
PE
5296 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5297
99561444
PE
5298 * insdel.c, lisp.h (buffer_overflow): New function.
5299 (insert_from_buffer_1, replace_range, replace_range_2):
5300 * insdel.c (make_gap_larger):
5301 * editfns.c (Finsert_char):
5302 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5303
28177add
PE
5304 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5305
e69dafad
PE
53062011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5307
4baa020d 5308 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 5309
b1c46f02
PE
5310 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5311 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5312
e69dafad
PE
5313 * fileio.c: Don't assume EMACS_INT fits in off_t.
5314 (emacs_lseek): New static function.
5315 (Finsert_file_contents, Fwrite_region): Use it.
5316 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5317
566684ea
PE
5318 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5319
e6966cd6
PE
5320 * fns.c: Don't overflow int when computing a list length.
5321 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5322 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5323 truncation on 64-bit hosts. Check for QUIT every
5324 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5325 faster and is responsive enough.
5326 (Flength): Report an error instead of overflowing an integer.
5327 (Fsafe_length): Return a float if the value is not representable
5328 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 5329 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 5330 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 5331
dd0b0efb
PE
5332 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5333 (header_size, word_size): New constants.
5334 (allocate_vectorlike): Don't check size overflow here.
5335 (allocate_vector): Check it here instead, since this is the only
5336 caller of allocate_vectorlike that could cause overflow.
5337 Check that the new vector's length is representable as a fixnum.
5338
86fe5cfe
PE
5339 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5340 The previous code was bogus. For example, next_almost_prime (32)
5341 returned 39, which is undesirable as it is a multiple of 3; and
5342 next_almost_prime (24) returned 25, which is a multiple of 5 so
5343 why was the code bothering to check for multiples of 7?
5344
80e88859
PE
5345 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5346
4a2f0ad6
PE
5347 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5348
f66c7cf8
PE
5349 Variadic C functions now count arguments with ptrdiff_t.
5350 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5351 Back then I didn't know that the Emacs coding style prefers signed int.
5352 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
5353 were being counted with int, which may truncate counts on 64-bit
5354 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
5355 * lisp.h (struct Lisp_Subr.function.aMANY)
5356 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5357 Arg counts are now ptrdiff_t, not size_t.
5358 All variadic functions and their callers changed accordingly.
5359 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5360 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5361 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5362 * callint.c (Fcall_interactively): Check arg count for overflow,
5363 to avoid potential buffer overrun. Use signed char, not 'int',
5364 for 'varies' array, so that we needn't bother to check its size
5365 calculation for overflow.
5366 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5367 * eval.c (apply_lambda):
5368 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5369 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5370 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5371
a1759b76
PE
5372 * callint.c (Fcall_interactively): Don't use index var as event count.
5373
d96be9fc
PE
5374 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5375 * mem-limits.h (SIZE): Remove; no longer used.
5376
a690a978 5377 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 5378
578c21e6
PE
5379 Remove unnecessary casts.
5380 * xterm.c (x_term_init):
5381 * xfns.c (x_set_border_pixel):
5382 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5383 These aren't needed now that we assume ANSI C.
5384
96f53c6c
PE
5385 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5386 It's more likely to cause problems (due to unsigned overflow)
5387 than to cure them.
5388
83c77d31
PE
5389 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5390
ee2079f1
PE
5391 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5392
6da65536
PE
5393 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5394
7147c4a4
PE
5395 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5396
193e32d9
PE
5397 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5398
e5533da6
PE
5399 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5400
9910e595
PE
5401 GLYPH_CODE_FACE returns EMACS_INT, not int.
5402 * dispextern.h (merge_faces):
5403 * xfaces.c (merge_faces):
01103c44
PE
5404 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5405 Don't assume EMACS_INT fits in int.
9910e595 5406
2638320e
PE
5407 * character.h (CHAR_VALID_P): Remove unused parameter.
5408 * fontset.c, lisp.h, xdisp.c: All uses changed.
5409
045eb8d9
PE
5410 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5411
c1f134b5
PE
5412 * fns.c (concat): Minor tuning based on overflow analysis.
5413 This doesn't fix any bugs. Use int to hold character, instead
5414 of constantly refetching from Emacs object. Use XFASTINT, not
5415 XINT, for value known to be a character. Don't bother comparing
5416 a single byte to 0400, as it's always less.
5417
395fcb93 5418 * floatfns.c (Fexpt):
327eeec8
PE
5419 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5420
abbd3d23
PE
5421 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5422 for characters.
5423
684a03ef
PE
5424 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5425
0fed43f3
PE
5426 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5427 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5428 incorrectly succeed when S was a string, because 4294967386 was
5429 truncated before it was used.
5430
8fd02eb7
PE
5431 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5432 Otherwise, an out-of-range integer could cause undefined behavior
5433 on a 64-bit host.
5434
f8c86b69
PE
5435 * composite.c: Use int, not EMACS_INT, for characters.
5436 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5437 EMACS_INT, for values that are known to be in character range.
5438 This doesn't fix any bugs but is the usual style inside Emacs and
5439 may generate better code on 32-bit machines.
5440
34206dd2
PE
5441 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5442 This is for reasons similar to the recent CHAR_STRING fix.
5443 * charset.c (Fencode_char): Check that character arg is actually
5444 a character. Pass an int to ENCODE_CHAR.
5445 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5446 wider than 'int', as a compile-time check to prevent future regressions
5447 in this area.
5448
c5958d4c 5449 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
5450
5451 Make sure a 64-bit char is never passed to CHAR_STRING.
5452 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5453 by silently ignoring the top 32 bits, allowing some values
5454 that were far too large to be valid characters.
5455 * character.h: Include <verify.h>.
5456 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5457 arguments are no wider than unsigned, as a compile-time check
5458 to prevent future regressions in this area.
5459 * data.c (Faset):
01103c44 5460 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
5461 (Fsubst_char_in_region):
5462 * fns.c (concat):
5463 * xdisp.c (decode_mode_spec_coding):
5464 Adjust to CHAR_STRING's new requirement.
5465 * editfns.c (Finsert_char, Fsubst_char_in_region):
5466 * fns.c (concat): Check that character args are actually
5467 characters. Without this test, these functions did the wrong
5468 thing with wildly out-of-range values on 64-bit hosts.
5469
d37ca623
PE
5470 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5471 These casts should not be needed on 32-bit hosts, either.
5472 * keyboard.c (read_char):
5473 * lread.c (Fload): Remove casts to unsigned.
5474
ea204efb
PE
5475 * lisp.h (UNSIGNED_CMP): New macro.
5476 This fixes comparison bugs on 64-bit hosts.
5477 (ASCII_CHAR_P): Use it.
5478 * casefiddle.c (casify_object):
01103c44 5479 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
5480 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5481 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5482 * dispextern.h (FACE_FROM_ID):
5483 * keyboard.c (read_char): Use UNSIGNED_CMP.
5484
41cb286c
PE
5485 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5486 not to EMACS_INT, to avoid GCC warning.
5487
4a1b9832
PE
5488 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5489
55daad71
PE
5490 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5491 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5492 isn't needed on 32-bit machines.
8f95c75c 5493
01103c44
PE
5494 * buffer.c (Fgenerate_new_buffer_name):
5495 Use EMACS_INT for count, not int.
0ceccced 5496 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
5497
5498 * data.c (Qcompiled_function): Now static.
5499
c6f072e7
PE
5500 * window.c (window_body_lines): Now static.
5501
20ce5912
PE
5502 * image.c (gif_load): Rename local to avoid shadowing.
5503
9c4c5f81
PE
5504 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5505 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5506 * alloc.c (make_save_value): Integer argument is now of type
5507 ptrdiff_t, not int.
5508 (mark_object): Use ptrdiff_t, not int.
5509 * lisp.h (pD): New macro.
5510 * print.c (print_object): Use it.
5511
c0c5c8ae
PE
5512 * alloc.c: Use EMACS_INT, not int, to count objects.
5513 (total_conses, total_markers, total_symbols, total_vector_size)
5514 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
5515 (total_free_floats, total_floats, total_free_intervals)
5516 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
5517 Now EMACS_INT, not int. All uses changed.
5518 (Fgarbage_collect): Compute overall total using a double, so that
5519 integer overflow is less likely to be a problem. Check for overflow
5520 when converting back to an integer.
5a25e253
PE
5521 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5522 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5523 These were 'int' variables that could overflow on 64-bit hosts;
5524 they were never used, so remove them instead of repairing them.
211a0b2a 5525 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
5526 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5527 Previously, this ceilinged at INT_MAX, but that doesn't work on
5528 64-bit machines.
e46bb31a 5529 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 5530
c78baabf 5531 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 5532 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
5533 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5534 when a (possibly-narrower) signed value would do just as well.
5535 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 5536
c9d624c6
PE
5537 * alloc.c: Catch some string size overflows that we were missing.
5538 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5539 for convenience in STRING_BYTES_MAX.
5540 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5541 The definition here is exact; the one in lisp.h was approximate.
5542 (allocate_string_data): Check for string overflow. This catches
5543 some instances we weren't catching before. Also, it catches
5544 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5545 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5546 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 5547
c9d624c6
PE
5548 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5549 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 5550 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 5551
353032ce
PE
5552 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5553
2bccce07
PE
5554 * alloc.c (Fmake_string): Check for out-of-range init.
5555
0ac30604
SM
55562011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5557
5558 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5559
c195f2de
JD
55602011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5561
5562 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5563 xg_get_default_scrollbar_width.
5564
5565 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5566 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5567 (style_changed_cb): Call update_theme_scrollbar_width and call
5568 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5569 all frames (Bug#8505).
5570 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5571 Call gtk_window_set_resizable if HAVE_GTK3.
5572 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5573 and height if HAVE_GTK3 (Bug#8505).
5574 (scroll_bar_width_for_theme): New variable.
5575 (update_theme_scrollbar_width): New function.
5576 (xg_get_default_scrollbar_width): Move code to
5577 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5578 (xg_initialize): Call update_theme_scrollbar_width.
5579
5580 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5581
5582 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5583
e10ac9f1
MR
55842011-06-12 Martin Rudalics <rudalics@gmx.at>
5585
5586 * frame.c (make_frame): Call other_buffer_safely instead of
5587 other_buffer.
5588
5589 * window.c (temp_output_buffer_show): Call display_buffer with
5590 second argument Vtemp_buffer_show_specifiers and reset latter
5591 immediately after the call.
5592 (Vtemp_buffer_show_specifiers): New variable.
5593 (auto_window_vscroll_p, next_screen_context_lines)
5594 (Vscroll_preserve_screen_position): Remove leading asterisks from
5595 doc-strings.
5596
2d3c217e 55972011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 5598
7b7f97e8 5599 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
5600 * buffer.c (Qclone_number): Remove for now, as it's unused.
5601 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5602 (record_buffer): Remove unused local.
5603 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5604 (set_frame_buffer_list): Remove; unused.
5605 * frame.h (other_visible_frames): Remove decl.
5606 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5607 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5608 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5609 if HAVE_GPM.
5610 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5611 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5612 Define only if HAVE_GPM.
5613 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5614 (update_hints_inhibit): Remove; never set. All uses removed.
5615 * widgetprv.h (emacsFrameClassRec): Remove decl.
5616 * window.c (delete_deletable_window): Now returns void, since it
5617 wasn't returning anything.
5618 (compare_window_configurations): Remove unused locals.
5619 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5620 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
5621 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5622 the same widths as pointers. This follows up on the 2011-05-06 patch.
5623 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5624 * xterm.h: Likewise.
5625 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5626
1384b89e
JB
56272011-06-12 Juanma Barranquero <lekktu@gmail.com>
5628
5629 * makefile.w32-in: Update dependencies.
5630 (LISP_H): Add lib/intprops.h.
5631
1100a63c
CY
56322011-06-11 Chong Yidong <cyd@stupidchicken.com>
5633
5634 * image.c (gif_load): Add animation frame delay to the metadata.
5635 (syms_of_image): Use DEFSYM. New symbol `delay'.
5636
6198ccd0
MR
56372011-06-11 Martin Rudalics <rudalics@gmx.at>
5638
5639 * window.c (delete_deletable_window): Re-add.
5640 (Fset_window_configuration): Rewrite to handle dead buffers and
5641 consequently deletable windows.
5642 (window_tree, Fwindow_tree): Remove. Supply functionality in
5643 window.el.
5644 (compare_window_configurations): Simplify code.
5645
b6e3633c
AS
56462011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5647
1ab0dee5
AS
5648 * image.c (imagemagick_load_image): Fix type mismatch.
5649 (Fimagemagick_types): Likewise.
5650
b6e3633c
AS
5651 * window.h (replace_buffer_in_windows): Declare.
5652
9397e56f
MR
56532011-06-11 Martin Rudalics <rudalics@gmx.at>
5654
5655 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5656 Qclone_number. Remove external declaration of Qdelete_window.
5657 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5658 code.
640c8776
SM
5659 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5660 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
5661 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5662 buffer list implementation.
5663 (other_buffer_safely): New function.
5664 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5665 calls to replace_buffer_in_windows and
5666 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5667 if allowed.
5668 (record_buffer): Inhibit quitting and rewrite using quittable
5669 functions. Run Qbuffer_list_update_hook if allowed.
5670 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
5671 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5672 Move switch-to-buffer to window.el.
9397e56f
MR
5673 (bury-buffer): Move to window.el.
5674 (Vbuffer_list_update_hook): New variable.
5675
5676 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5677 section.
5678
5679 * window.h (resize_frame_windows): Move up in code.
5680 (Fwindow_frame): Remove EXFUN.
5681 (replace_buffer_in_all_windows): Remove prototype.
5682 (replace_buffer_in_windows_safely): Add prototype.
5683
5684 * window.c: Declare Qdelete_window static again. Move down
5685 declaration of select_count.
5686 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5687 (Fother_window): Move to window.el.
5688 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5689 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5690 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5691 window.el.
5692 (replace_buffer_in_windows): Implement by calling
5693 Qreplace_buffer_in_windows.
5694 (replace_buffer_in_all_windows): Remove with some functionality
5695 moved into replace_buffer_in_windows_safely.
5696 (replace_buffer_in_windows_safely): New function.
5697 (select_window_norecord, select_frame_norecord): Move in front
5698 of run_window_configuration_change_hook. Remove now obsolete
5699 declarations.
640c8776
SM
5700 (Fset_window_buffer): Rewrite doc-string.
5701 Call Qrecord_window_buffer.
9397e56f
MR
5702 (keys_of_window): Move binding for other-window to window.el.
5703
b50691aa
CY
57042011-06-11 Chong Yidong <cyd@stupidchicken.com>
5705
5706 * dispextern.h (struct image): Replace data member, whose int_val
5707 and ptr_val fields were not used by anything, with a single
5708 lisp_val object.
5709
5710 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5711 (gif_clear_image, gif_load, imagemagick_load_image)
5712 (gs_clear_image, gs_load): Callers changed.
5713
3f754b86
PE
57142011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5715
cca69397
PE
5716 * buffer.h: Include <time.h>, for time_t.
5717 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5718
109e28d0
PE
5719 Fix minor problems found by static checking.
5720
60737f02
PE
5721 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5722
4b66faf3
PE
5723 Make identifiers static if they are not used in other modules.
5724 * data.c (Qcompiled_function, Qframe, Qvector):
5725 * image.c (QimageMagick, Qsvg):
5726 * minibuf.c (Qmetadata):
5727 * window.c (resize_window_check, resize_root_window): Now static.
5728 * window.h (resize_window_check, resize_root_window): Remove decls.
5729
109e28d0
PE
5730 * window.c (window_deletion_count, delete_deletable_window):
5731 Remove; unused.
46a4ce9e
PE
5732 (window_body_lines): Now static.
5733 (Fdelete_other_windows_internal): Mark vars as initialized.
5734 Make sure 'resize_failed' is initialized.
5735 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5736 (resize_window_apply): Remove unused local.
5737 * window.h (delete_deletable_window): Remove decl.
5738
109e28d0 5739 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
5740 (imagemagick_load_image): Fix pointer signedness problem by changing
5741 last arg from unsigned char * to char *. All uses changed.
5742 Also, fix a local for similar reasons.
5743 Remove unused locals. Remove locals to avoid shadowing.
5744 (fn_rsvg_handle_free): Remove; unused.
5745 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 5746 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 5747
3f754b86
PE
5748 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5749
2547adb1
CY
57502011-06-10 Chong Yidong <cyd@stupidchicken.com>
5751
5752 * image.c (gif_load): Fix omitted cast error introduced by
5753 2011-06-06 change.
5754
2c8e37d4
MR
57552011-06-10 Martin Rudalics <rudalics@gmx.at>
5756
5757 * window.h (resize_proportionally, orig_total_lines)
5758 (orig_top_line): Remove from window structure.
5759 (set_window_height, set_window_width, change_window_heights)
5760 (Fdelete_window): Remove prototypes.
5761 (resize_frame_windows): Remove duplicate declaration.
5762
440a42e3
EZ
57632011-06-10 Eli Zaretskii <eliz@gnu.org>
5764
5765 * window.h (resize_frame_windows, resize_window_check)
5766 (delete_deletable_window, resize_root_window)
5767 (resize_frame_windows): Declare prototypes.
5768
5769 * window.c (resize_window_apply): Make definition be "static" to
5770 match the prototype.
5771
562dd5e9
MR
57722011-06-10 Martin Rudalics <rudalics@gmx.at>
5773
5774 * window.c: Remove declarations of Qwindow_size_fixed,
5775 window_min_size_1, window_min_size_2, window_min_size,
5776 size_window, window_fixed_size_p, enlarge_window, delete_window.
5777 Remove static from declaration of Qdelete_window, it's
5778 temporarily needed by Fbury_buffer.
5779 (replace_window): Don't assign orig_top_line and
5780 orig_total_lines.
5781 (Fdelete_window, delete_window): Remove. Window deletion is
5782 handled by window.el.
640c8776
SM
5783 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5784 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
5785 (Fdelete_other_windows): Remove. Deleting other windows is
5786 handled by window.el.
5787 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5788 handled in window.el.
5789 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5790 Window minimum sizes are handled in window.el.
5791 (shrink_windows, size_window, set_window_height)
5792 (set_window_width, change_window_heights, window_height)
5793 (window_width, CURBEG, CURSIZE, enlarge_window)
5794 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5795 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5796 handled in window.el.
5797 (make_dummy_parent): Rename to make_parent_window and give it a
5798 second argument horflag.
5799 (make_window): Don't set resize_proportionally any more.
5800 (Fsplit_window): Remove. Windows are split in window.el.
5801 (save_restore_action, save_restore_orig_size)
5802 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5803 Resize mini windows in window.el.
5804 (grow_mini_window, shrink_mini_window): Implement by calling
5805 Qresize_root_window_vertically, resize_window_check and
5806 resize_window_apply.
640c8776
SM
5807 (saved_window, Fset_window_configuration, save_window_save):
5808 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
5809 resize_proportionally.
5810 (window_min_height, window_min_width): Move to window.el.
5811 (keys_of_window): Move bindings for delete-other-windows,
5812 split-window, delete-window and enlarge-window to window.el.
5813
5814 * buffer.c: Temporarily extern Qdelete_window.
5815 (Fbury_buffer): Temporarily call Qdelete_window instead of
5816 Fdelete_window (Fbury_buffer will move to window.el soon).
5817
5818 * frame.c (set_menu_bar_lines_1): Remove code handling
5819 orig_top_line and orig_total_lines.
5820
5821 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5822 set_window_height but set heights directly.
5823 (change_frame_size_1): Use resize_frame_windows.
5824
5825 * xdisp.c (init_xdisp): Don't use set_window_height but set
5826 heights directly.
5827
640c8776
SM
5828 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5829 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
5830 run_window_configuration_change_hook.
5831
5832 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5833 instead of change_window_heights and run
5834 run_window_configuration_change_hook.
5835
1a13852e
MR
58362011-06-09 Martin Rudalics <rudalics@gmx.at>
5837
5838 * window.c (replace_window): Rename second argument REPLACEMENT to
5839 NEW. New third argument SETFLAG. Rewrite.
5840 (delete_window, make_dummy_parent): Call replace_window with
5841 third argument 1.
5842 (window_list_1): Move down in code.
5843 (run_window_configuration_change_hook): Move set_buffer part
5844 before select_frame_norecord part in order to unwind correctly.
5845 Rename count1 to count.
5846 (recombine_windows, delete_deletable_window, resize_root_window)
5847 (Fdelete_other_windows_internal)
5848 (Frun_window_configuration_change_hook, make_parent_window)
5849 (resize_window_check, resize_window_apply, Fresize_window_apply)
5850 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
5851 (Fdelete_window_internal, Fresize_mini_window_internal):
5852 New functions.
1a13852e
MR
5853 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5854
f3d1777e
MR
58552011-06-08 Martin Rudalics <rudalics@gmx.at>
5856
496e208e
MR
5857 * window.h (window): Add some new members to window structure -
5858 normal_lines, normal_cols, new_total, new_normal, clone_number,
5859 splits, nest, prev_buffers, next_buffers.
5860 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 5861 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 5862
f3d1777e
MR
5863 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5864 Remove.
496e208e
MR
5865 (make_dummy_parent): Set new members of windows structure.
5866 (make_window): Move down in code. Handle new members of window
5867 structure.
5868 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5869 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5870 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5871 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
5872 (Fset_window_next_buffers, Fset_window_clone_number):
5873 New functions.
496e208e
MR
5874 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5875 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5876 Doc-string fixes.
5877 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5878 Argument WINDOW can be now internal window too.
5879 (Fwindow_use_time): Move up in code.
5880 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5881 Rewrite doc-string.
5882 (Fset_window_configuration, saved_window)
5883 (Fcurrent_window_configuration, save_window_save): Handle new
5884 members of window structure.
b9e809c2
MR
5885 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5886 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5887 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5888 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5889 Qget_mru_window, Qresize_root_window,
5890 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5891 Qauto_buffer_name; staticpro them.
f3d1777e 5892
abde8f8c
MR
58932011-06-07 Martin Rudalics <rudalics@gmx.at>
5894
5895 * window.c (Fwindow_total_size, Fwindow_left_column)
5896 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5897 (Fwindow_list_1): New functions.
5898 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
5899 (Fwindow_width, Fscroll_left, Fscroll_right):
5900 Use window_body_cols instead of window_box_text_cols.
5901 (delete_window, Fset_window_configuration):
5902 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
5903 (delete_all_subwindows): Take a window as argument and not a
5904 structure. Rewrite.
190b47e6
MR
5905 (window_loop): Remove handling of GET_LRU_WINDOW and
5906 GET_LARGEST_WINDOW.
5907 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
5908
5909 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
5910 window_box_text_cols. delete_all_subwindows now takes a
5911 Lisp_Object as argument.
abde8f8c 5912
640c8776
SM
5913 * indent.c (compute_motion, Fcompute_motion):
5914 Use window_body_cols instead of window_box_text_cols.
abde8f8c 5915
fa8a67e6
MR
5916 * frame.c (delete_frame): Call delete_all_subwindows with root
5917 window as argument.
5918
a54e3482
DC
59192011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5920
5921 * fns.c (Fputhash): Document return value.
5922
60002bf5
CY
59232011-06-06 Chong Yidong <cyd@stupidchicken.com>
5924
5925 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5926
0c671da6 59272011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 5928
b862a52a 5929 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 5930
be44ca6c
PE
5931 Check for overflow when converting integer to cons and back.
5932 * charset.c (Fdefine_charset_internal, Fdecode_char):
5933 Use cons_to_unsigned to catch overflow.
5934 (Fencode_char): Use INTEGER_TO_CONS.
5935 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5936 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5937 * data.c (long_to_cons, cons_to_long): Remove.
5938 (cons_to_unsigned, cons_to_signed): New functions.
5939 These signal an error for invalid or out-of-range values.
5940 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5941 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5942 * font.c (Ffont_variation_glyphs):
5943 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5944 * lisp.h: Include <intprops.h>.
5945 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5946 (cons_to_signed, cons_to_unsigned): New decls.
5947 (long_to_cons, cons_to_long): Remove decls.
5948 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5949 (Fprimitive_undo): Use CONS_TO_INTEGER.
5950 * xfns.c (Fx_window_property): Likewise.
5951 * xselect.c: Include <limits.h>.
5952 (x_own_selection, selection_data_to_lisp_data):
5953 Use INTEGER_TO_CONS.
5954 (x_handle_selection_request, x_handle_selection_clear)
5955 (x_get_foreign_selection, Fx_disown_selection_internal)
5956 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5957 (lisp_data_to_selection_data): Use cons_to_unsigned.
5958 (x_fill_property_data): Use cons_to_signed.
5959 Report values out of range.
5960
d1f3d2af
PE
5961 Check for buffer and string overflow more precisely.
5962 * buffer.h (BUF_BYTES_MAX): New macro.
5963 * lisp.h (STRING_BYTES_MAX): New macro.
5964 * alloc.c (Fmake_string):
5965 * character.c (string_escape_byte8):
5966 * coding.c (coding_alloc_by_realloc):
5967 * doprnt.c (doprnt):
5968 * editfns.c (Fformat):
5969 * eval.c (verror):
5970 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5971 since they may not be the same number.
5972 * editfns.c (Finsert_char):
5973 * fileio.c (Finsert_file_contents):
5974 Likewise for BUF_BYTES_MAX.
5975
dd52fcea
PE
5976 * image.c: Use ptrdiff_t, not int, for sizes.
5977 (slurp_file): Switch from int to ptrdiff_t.
5978 All uses changed.
5979 (slurp_file): Check that file size fits in both size_t (for
5980 malloc) and ptrdiff_t (for sanity and safety).
5981
7f9bbdbb
PE
5982 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5983 if b->modtime has its maximal value.
5984
dfe18f82
PE
5985 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5986
84acfcf0
PE
5987 Don't assume time_t can fit into int.
5988 * buffer.h (struct buffer.modtime): Now time_t, not int.
5989 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5990 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5991
ccd9a01a
PE
5992 Minor fixes for signed vs unsigned integers.
5993 * character.h (MAYBE_UNIFY_CHAR):
5994 * charset.c (maybe_unify_char):
5995 * keyboard.c (read_char, reorder_modifiers):
5996 XINT -> XFASTINT, since the integer must be nonnegative.
5997 * ftfont.c (ftfont_spec_pattern):
5998 * keymap.c (access_keymap, silly_event_symbol_error):
5999 XUINT -> XFASTINT, since the integer must be nonnegative.
6000 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
6001 since it makes no difference and we prefer signed.
6002 * keyboard.c (record_char): Use XUINT when all the neighbors do.
6003 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
6004 nonnegative.
6005
d6d100dd
SM
60062011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
6007
6008 * window.h (Fwindow_frame): Declare.
6009
2b6148e4
PE
60102011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6011
6012 * alloc.c: Simplify handling of large-request failures (Bug#8800).
6013 (SPARE_MEMORY): Always define.
6014 (LARGE_REQUEST): Remove.
6015 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
6016
f230ecc9
MR
60172011-06-06 Martin Rudalics <rudalics@gmx.at>
6018
727e958e
MR
6019 * lisp.h: Move EXFUNS for Fframe_root_window,
6020 Fframe_first_window and Fset_frame_selected_window to window.h.
6021
6022 * window.h: Move EXFUNS for Fframe_root_window,
6023 Fframe_first_window and Fset_frame_selected_window here from
6024 lisp.h.
6025
6026 * frame.c (Fwindow_frame, Fframe_first_window)
6027 (Fframe_root_window, Fframe_selected_window)
6028 (Fset_frame_selected_window): Move to window.c.
6029 (Factive_minibuffer_window): Move to minibuf.c.
6030 (Fother_visible_frames_p): New function.
6031
6032 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
6033
f230ecc9
MR
6034 * window.c (decode_window, decode_any_window): Move up in code.
6035 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
6036 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
6037 (Fwindow_buffer): Move up and rewrite doc-string.
6038 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
6039 (Fwindow_prev): New functions.
727e958e
MR
6040 (Fwindow_frame): Move here from frame.c. Accept any window as
6041 argument.
6042 (Fframe_root_window, Fframe_first_window)
6043 (Fframe_selected_window): Move here from frame.c. Accept frame
6044 or arbitrary window as argument. Update doc-strings.
6045 (Fminibuffer_window): Move up in code.
6046 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
6047 (Fset_frame_selected_window): Move here from frame.c.
6048 Marginal rewrite.
727e958e
MR
6049 (Fselected_window, select_window, Fselect_window): Move up in
6050 code. Minor doc-string fixes.
f230ecc9 6051
4d09bcf6
PE
60522011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6053
6054 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
6055 Do not assume that spare memory exists; that assumption is valid
6056 only if SYSTEM_MALLOC.
6057 (LARGE_REQUEST): New macro, so that the issue of large requests
6058 is separated from the issue of spare memory.
6059
810928a2
AS
60602011-06-05 Andreas Schwab <schwab@linux-m68k.org>
6061
172418ad
AS
6062 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
6063 format. (Bug#8806)
6064
43f862f7
AS
6065 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
6066
810928a2
AS
6067 * xfns.c (x_set_scroll_bar_default_width): Move declarations
6068 before statements.
6069
a059fe24
JD
60702011-06-05 Jan Djärv <jan.h.d@swipnet.se>
6071
6072 * gtkutil.c (xg_get_default_scrollbar_width): New function.
6073
6074 * gtkutil.h: Declare xg_get_default_scrollbar_width.
6075
6076 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
6077 min width by calling x_set_scroll_bar_default_width (Bug#8505).
6078
989bf368
JB
60792011-06-05 Juanma Barranquero <lekktu@gmail.com>
6080
6081 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
6082
4b80f674
CY
60832011-06-04 Chong Yidong <cyd@stupidchicken.com>
6084
6085 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
6086 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
6087 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
6088 New error handlers.
4b80f674
CY
6089 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
6090 Obey Vx_select_enable_clipboard_manager. Catch errors in
6091 x_clipboard_manager_save (Bug#8779).
6092 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 6093 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 6094
99a33b77 60952011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
6096
6097 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
6098
99a33b77 60992011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
6100
6101 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
6102 in the current matrix if keep_current_p is non-zero.
6103
8264569d
EZ
61042011-06-04 Eli Zaretskii <eliz@gnu.org>
6105
6106 * bidi.c (bidi_level_of_next_char): Fix last change.
6107
57f97249
EZ
61082011-06-03 Eli Zaretskii <eliz@gnu.org>
6109
fec2107c 6110 Support bidi reordering of text covered by display properties.
57f97249 6111
fec2107c
EZ
6112 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
6113 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
6114 (bidi_cache_search, bidi_cache_iterator_state)
6115 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
6116 (bidi_level_of_next_char, bidi_move_to_visually_next):
6117 Support character positions inside a run of characters covered by a
fec2107c
EZ
6118 display string.
6119 (bidi_paragraph_init, bidi_resolve_explicit_1)
6120 (bidi_level_of_next_char): Call bidi_fetch_char and
6121 bidi_fetch_char_advance instead of FETCH_CHAR and
6122 FETCH_CHAR_ADVANCE.
6123 (bidi_init_it): Initialize new members.
6124 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
6125 definitions.
6126 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
6127 instead of using explicit *_CHAR codes.
d6d100dd
SM
6128 (bidi_resolve_explicit, bidi_resolve_weak):
6129 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
6130 bidirectional text is supported only in multibyte buffers.
6131 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
6132 it to initialize the frame_window_p member of struct bidi_it.
6133 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
6134 (bidi_resolve_explicit, bidi_resolve_weak)
6135 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
6136 bidi_it->nchars is non-positive.
6137 (bidi_level_of_next_char): Don't try to lookup the cache for the
6138 next/previous character if nothing is cached there yet, or if we
6139 were just reseat()'ed to a new position.
c40e2fb2 6140
0e14fe90
EZ
6141 * xdisp.c (set_cursor_from_row): Set start and stop points
6142 according to the row's direction when priming the loop that looks
6143 for the glyph on which to display cursor.
6144 (single_display_spec_intangible_p): Function deleted.
6145 (display_prop_intangible_p): Reimplement to call
6146 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
6147 Accept 3 additional arguments needed by handle_display_spec.
6148 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
6149 values: lists, `(when COND...)' forms, etc.
6150 (single_display_spec_string_p): Support property values that are
6151 lists with the argument STRING its top-level element.
6152 (display_prop_string_p): Fix the condition for processing a
6153 property that is a list to be consistent with handle_display_spec.
fec2107c 6154 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
6155 last portion of handle_display_prop.
6156 (compute_display_string_pos): Accept additional argument
6157 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6158 value of a `display' property is a "replacing spec".
6159 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6160 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6161 the display property, but just return a value indicating whether
6162 the display property will replace the characters it covers.
6163 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6164 frame_window_p members of struct bidi_it.
d6d100dd
SM
6165 (compute_display_string_pos, compute_display_string_end):
6166 New functions.
fec2107c
EZ
6167 (push_it): Accept second argument POSITION, where pop_it should
6168 jump to continue iteration.
6169 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 6170
fec2107c
EZ
6171 * keyboard.c (adjust_point_for_property): Adjust the call to
6172 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
6173
6174 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
6175 (bidi_init_it): Update prototypes.
6176 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
6177 (compute_display_string_pos, compute_display_string_end):
6178 Declare prototypes.
fec2107c
EZ
6179 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6180 EMACS_INT.
fc6f18ce 6181
40087514 61822011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 6183
57f53182
PE
6184 Malloc failure behavior now depends on size of allocation.
6185 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6186 * lisp.h: Change signatures accordingly.
6187 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6188 All callers changed. (Bug#8762)
6189
6190 * gnutls.c: Use Emacs's memory allocators.
6191 Without this change, the gnutls library would invoke malloc etc.
6192 directly, which causes problems on non-SYNC_INPUT hosts, and which
6193 runs afoul of improving memory_full behavior. (Bug#8761)
6194 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6195 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6196 xfree instead of the default malloc, realloc, free.
6197 (Fgnutls_boot): No need to check for memory allocation failure,
6198 since xmalloc does that for us.
6199
ac32cd99 6200 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
6201 * category.c (hash_get_category_set):
6202 * ccl.c (ccl_driver):
6203 * charset.c (Fdefine_charset_internal):
6204 * charset.h (struct charset.hash_index):
6205 * composite.c (get_composition_id, gstring_lookup_cache)
6206 (composition_gstring_put_cache):
6207 * composite.h (struct composition.hash_index):
6208 * dispextern.h (struct image.hash):
6209 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6210 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6211 (hashfn_equal, hashfn_user_defined, make_hash_table)
6212 (maybe_resize_hash_table, hash_lookup, hash_put)
6213 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6214 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6215 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6216 * image.c (make_image, search_image_cache, lookup_image)
6217 (xpm_put_color_table_h):
6218 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 6219 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 6220 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 6221 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
6222 * alloc.c (allocate_vectorlike):
6223 Check for overflow in vector size calculations.
6224 * ccl.c (ccl_driver):
6225 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
6226 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6227 need to be updated by these changes.
40087514
PE
6228 * fns.c (make_hash_table, maybe_resize_hash_table):
6229 Check for integer overflow with large hash tables.
0de4bb68
PE
6230 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6231 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6232 (SXHASH_REDUCE): New macro.
6233 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6234 Use it instead of discarding useful hash info with large hash values.
6235 (sxhash_float): New function.
6236 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6237 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
6238 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6239 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
6240 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6241 Adjust signatures to match updated version of code.
6242 (consing_since_gc): Now EMACS_INT, since a single hash table can
6243 use more than INT_MAX bytes.
6244
698d32e2
DN
62452011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6246
6247 Make it possible to build with GCC-4.6+ -O2 -flto.
6248
6249 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6250
fd6fa53f
SM
62512011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6252
6253 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6254 Call minibuffer-inactive-mode.
6255
864db017
JB
62562011-05-31 Juanma Barranquero <lekktu@gmail.com>
6257
6258 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6259 Update dependencies.
6260
2ad0baf4
DN
62612011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6262
6263 * data.c (init_data): Remove code for UTS, this system is not
6264 supported anymore.
6265
4fcc2638
DN
62662011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6267
6268 Don't force ./temacs to start in terminal mode.
6269
6270 * frame.c (make_initial_frame): Initialize faces in all cases, not
6271 only when CANNOT_DUMP is defined.
6272 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6273
c56e0fd5
DN
62742011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6275
6276 * dispnew.c (add_window_display_history): Use const for the string
6277 pointer. Remove declaration, not needed.
6278
333d54da 62792011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 6280
55d4c1b2 6281 Use 'inline', not 'INLINE'.
333d54da 6282 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
6283 * alloc.c, fontset.c (INLINE): Remove.
6284 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6285 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6286 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6287 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6288 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6289
738db178
DN
62902011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6291
6292 Make it possible to run ./temacs.
6293
6294 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6295 syms_of_callproc does the same thing. Remove test for
6296 "initialized", do it in the caller.
6297 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6298
620c53a6
SM
62992011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6300
6301 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6302 (read_minibuf): Use get_minibuffer.
6303 (syms_of_minibuf): Use DEFSYM.
6304 (Qmetadata): New var.
6305 * data.c (Qbuffer): Don't make it static.
6306 (syms_of_data): Use DEFSYM.
6307
e003a292
PE
63082011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6309
6310 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6311 (CCL_CODE_MIN): New macro.
6312
ed008a6d
PE
63132011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6314
3687c2ef
PE
6315 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6316
ed008a6d
PE
6317 * eval.c (Qdebug): Now static.
6318 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6319 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6320 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6321
d66c4c7c
CY
63222011-05-29 Chong Yidong <cyd@stupidchicken.com>
6323
6324 * image.c: Various fixes to ImageMagick code comments.
6325 (Fimagemagick_types): Doc fix.
6326
5fbc2025
PE
63272011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6328
0196f88a
PE
6329 Minor fixes prompted by GCC 4.6.0 warnings.
6330
6331 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6332
5fbc2025
PE
6333 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6334 (x_clipboard_manager_save_all): Move extern decl to ...
6335 * xterm.h: ... here, so that it can be checked for consistency.
6336
1dd3c2d9
CY
63372011-05-29 Chong Yidong <cyd@stupidchicken.com>
6338
6339 * xselect.c (x_clipboard_manager_save_frame)
6340 (x_clipboard_manager_save_all): New functions.
6341 (Fx_clipboard_manager_save): Lisp function deleted.
6342
6343 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6344 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6345
6346 * xterm.h: Update prototype.
6347
5ba6571d
WX
63482011-05-28 William Xu <william.xwl@gmail.com>
6349
6350 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6351 exiting (Bug#8239).
6352
3eaff834
JM
63532011-05-28 Jim Meyering <meyering@redhat.com>
6354
e1900994 6355 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
6356 * fns.c (to_uchar): Define.
6357 (crypto_hash_function): Use it to convert some newly-signed
6358 variables to unsigned, to avoid sign-extension bugs. For example,
6359 without this change, (md5 "truc") would evaluate to
6360 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6361 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 6362 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 6363
0f6990a7
PE
63642011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6365
6366 Integer overflow fixes.
c8a9ca5a 6367
08686060
PE
6368 * dbusbind.c: Serial number integer overflow fixes.
6369 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
6370 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6371 to hold a serial number that is too large for a fixnum.
6372 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6373 Check for serial numbers out of range. Decode any serial number
59568bf0 6374 that was so large that it became a float. (Bug#8722)
08686060 6375
2d1fc3c7
PE
6376 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6377 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6378 Use XFASTINT rather than XUINT when numbers are nonnegative.
6379 (xd_append_arg, Fdbus_method_return_internal):
6380 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6381 arguments, check that Lisp number is nonnegative, rather than
59568bf0 6382 silently wrapping negative numbers around. (Bug#8722)
30217ff0 6383 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 6384 (Bug#8722)
2d1fc3c7 6385
c8a9ca5a
PE
6386 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6387
519e1d69
PE
6388 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6389
6df6ae42 6390 ccl: Add integer overflow checks.
30569699
PE
6391 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6392 (IN_INT_RANGE): New macros.
6393 (ccl_driver): Use them to check for integer overflow when
6394 decoding a CCL program. Many of the new checks are whether XINT (x)
6395 fits in int; it doesn't always, on 64-bit hosts. The new version
6396 doesn't catch all possible integer overflows, but it's an
847044ea 6397 improvement. (Bug#8719)
30569699 6398
c11285dc
PE
6399 * alloc.c (make_event_array): Use XINT, not XUINT.
6400 There's no need for unsigned here.
6401
fdccd48e
PE
6402 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6403 This follows up to the 2011-05-06 change that substituted uintptr_t
6404 for EMACS_INT. This case wasn't caught back then.
6405
37910ab2
PE
6406 Rework Fformat to avoid integer overflow issues.
6407 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6408 now (part of C89). Include <verify.h>.
6409 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6410 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6411 (Fformat): Avoid the prepass trying to compute sizes; it was only
6412 approximate and thus did not catch overflow reliably. Instead, walk
6413 through the format just once, formatting and computing sizes as we go,
6414 checking for integer overflow at every step, and allocating a larger
6415 buffer as needed. Keep track separately whether the format is
6416 multibyte. Keep only the most-recently calculated precision, rather
6417 than them all. Record whether each argument has been converted to
6418 string. Use EMACS_INT, not int, for byte and char and arg counts.
6419 Support field widths and precisions larger than INT_MAX. Avoid
6420 sprintf's undefined behavior with conversion specifications such as %#d
6421 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6422 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6423 formatting out-of-range floating point numbers with int
9173deec 6424 formats. (Bug#8668)
37910ab2 6425
2e6578fb
PE
6426 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6427
0ae6bdee
PE
6428 * data.c: Avoid integer truncation in expressions involving floats.
6429 * data.c: Include <intprops.h>.
6430 (arith_driver): When there's an integer overflow in an expression
6431 involving floating point, convert the integers to floating point
6432 so that the resulting value does not suffer from catastrophic
6433 integer truncation. For example, on a 64-bit host (* 4
6434 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6435 Do not rely on undefined behavior after integer overflow.
6436
de883a70
PE
6437 merge count_size_as_multibyte, parse_str_to_multibyte
6438 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 6439 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
6440 Check for integer overflow.
6441 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6442 since it's now a duplicate of the other. This is more of
6443 a character than a buffer op, so better that it's in character.c.
6444 * fns.c, print.c: Adjust to above changes.
6445
2ff916cb
PE
64462011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6447
6448 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6449
f1b54466
PE
64502011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6451
fb1ac845
PE
6452 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6453 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6454 (x_clipboard_manager_save): Now static.
6455 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6456
f1b54466
PE
6457 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6458 (crypto_hash_function): Now static.
6459 Fix pointer signedness problems. Avoid unnecessary initializations.
6460
a9f737ee
CY
64612011-05-27 Chong Yidong <cyd@stupidchicken.com>
6462
6463 * termhooks.h (Vselection_alist): Make it terminal-local.
6464
6465 * terminal.c (create_terminal): Initialize it.
6466
6467 * xselect.c: Support for clipboard managers.
6468 (Vselection_alist): Move to termhooks.h as terminal-local var.
6469 (LOCAL_SELECTION): New macro.
6470 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6471 (symbol_to_x_atom): Remove gratuitous arg.
6472 (x_handle_selection_request, lisp_data_to_selection_data)
6473 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
6474 (x_own_selection, x_get_local_selection, x_convert_selection):
6475 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
6476 (some_frame_on_display): Delete unused function.
6477 (Fx_own_selection_internal, Fx_get_selection_internal)
6478 (Fx_disown_selection_internal, Fx_selection_owner_p)
6479 (Fx_selection_exists_p): New optional frame arg.
6480 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6481 (x_handle_selection_clear): Don't treat other terminals with the
6482 same keyboard specially. Use the terminal-local Vselection_alist.
6483 (x_clear_frame_selections): Use Frun_hook_with_args.
6484
6485 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6486
6487 * xterm.h: Add support for those atoms.
6488
e067f0c1
CY
64892011-05-26 Chong Yidong <cyd@stupidchicken.com>
6490
6491 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6492 (converted_selections, conversion_fail_tag): New global variables.
6493 (x_selection_request_lisp_error): Free the above.
6494 (x_get_local_selection): Remove unnecessary code.
6495 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
6496 of converted selections stored in converted_selections.
6497 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
6498 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6499 (x_convert_selection): New function.
6500 (x_handle_selection_event): Simplify.
6501 (x_get_foreign_selection): Don't ignore incoming requests while
6502 waiting for an answer; this will fail when we implement
6503 SAVE_TARGETS, and seems unnecessary anyway.
6504 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6505 (Vx_sent_selection_functions): Doc fix.
6506
0f4aebc0
LL
65072011-05-26 Leo Liu <sdl.web@gmail.com>
6508
6509 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6510
e61124cd
YM
65112011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6512
6513 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6514
6515 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6516 for fringe update if it has periodic bitmap.
ac389d0c 6517 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
6518 and fringe_bitmap_periodic_p.
6519
6520 * fringe.c (get_fringe_bitmap_data): New function.
6521 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6522 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6523 row. Mark glyph row for fringe update if periodicity changed.
6524
6525 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6526 for fringe update unless it has periodic bitmap.
6527
f16d9837
KH
65282011-05-25 Kenichi Handa <handa@m17n.org>
6529
6530 * xdisp.c (get_next_display_element): Set correct it->face_id for
6531 a static composition.
6532
e1b90ef6
LL
65332011-05-24 Leo Liu <sdl.web@gmail.com>
6534
6535 * deps.mk (fns.o):
6536 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6537
6538 * fns.c (crypto_hash_function, Fsha1): New function.
6539 (Fmd5): Use crypto_hash_function.
6540 (syms_of_fns): Add Ssha1.
6541
7400048f
PE
65422011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6543
6544 * gnutls.c: Remove unused macros.
6545 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6546 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6547 Remove macros that are defined and never used.
6548 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6549
abb71cf4
CY
65502011-05-22 Chong Yidong <cyd@stupidchicken.com>
6551
6552 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6553 (Fx_get_selection_internal): Minor cleanup.
6554 (Fx_own_selection_internal): Rename arguments for consistency with
6555 select.el.
6556
6307db39
PE
65572011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6558
6559 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6560
f3d4e0a4
CY
65612011-05-22 Chong Yidong <cyd@stupidchicken.com>
6562
6563 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6564
4d8ade89
YM
65652011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6566
6567 * dispnew.c (scrolling_window): Don't exclude the case that the
6568 last enabled row in the desired matrix touches the bottom boundary.
6569
32078c8d
GM
65702011-05-21 Glenn Morris <rgm@gnu.org>
6571
6572 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
6573 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6574 and add some more files.
32078c8d 6575
7285dc67
EZ
65762011-05-20 Eli Zaretskii <eliz@gnu.org>
6577
6578 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6579 report_file_error introduced by the change from 2011-05-07.
6580
89d1bd22
PE
65812011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6582
6583 * systime.h (Time): Define only if emacs is defined.
6584 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6585 where the include path doesn't have X11/X.h by default. See
6586 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6587
cd394be1 65882011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
6589
6590 * composite.c (find_automatic_composition): Fix previous change.
6591
b9704ad9
GM
65922011-05-20 Glenn Morris <rgm@gnu.org>
6593
6594 * lisp.mk: New file, split from Makefile.in.
6595 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6596 (shortlisp): Remove.
6597 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6598
4a720484
GM
65992011-05-19 Glenn Morris <rgm@gnu.org>
6600
6601 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6602 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6603 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6604 (lisp): Set the order to that of loadup.el.
6605 (shortlisp): Make it a copy of $lisp.
6606 (SOME_MACHINE_LISP): Remove.
6607 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6608 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6609
a28d4396
KH
66102011-05-18 Kenichi Handa <handa@m17n.org>
6611
6612 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6613 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6614 (find_automatic_composition): Mostly rewrite for efficiency.
6615
a2b1fa8e
JB
66162011-05-18 Juanma Barranquero <lekktu@gmail.com>
6617
6618 * makefile.w32-in: Update dependencies.
6619
8e1f5610
CS
66202011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6621
6622 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 6623 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 6624
7025ee00 66252011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 6626
cdfa6eab
PE
6627 Fix some integer overflow issues, such as string length overflow.
6628
06d6db33
PE
6629 * insdel.c (count_size_as_multibyte): Check for string overflow.
6630
2b4560a8
PE
6631 * character.c (lisp_string_width): Check for string overflow.
6632 Use EMACS_INT, not int, for string indexes and lengths; in
6633 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6634 the resulting string length overflows an EMACS_INT; instead,
6635 report a string overflow if no precision given. When checking for
6636 precision exhaustion, use a check that cannot possibly have
6637 integer overflow. (Bug#8675)
6638 * character.h (lisp_string_width): Adjust to new signature.
6639
cb93f9be
PE
6640 * alloc.c (string_overflow): New function.
6641 (Fmake_string): Use it. This doesn't change behavior, but saves
6642 a few bytes and will simplify future changes.
6643 * character.c (string_escape_byte8): Likewise.
6644 * lisp.h (string_overflow): New decl.
6645
1a1f3366
PE
6646 Fixups, following up to the user-interface timestamp change.
6647 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6648 for UI timestamps, instead of unsigned long.
9fbd6841
PE
6649 * msdos.c (mouse_get_pos): Likewise.
6650 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
6651 * w32gui.h (Time): Define by including "systime.h" rather than by
6652 declaring it ourselves. (Bug#8664)
6653
d4e3e4d3
PE
6654 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6655 * image.c (clear_image_cache): Likewise.
6656
f6a24d19
PE
6657 * term.c (term_mouse_position): Don't assume time_t wraparound.
6658
08dc5ae6
PE
6659 Be more systematic about user-interface timestamps.
6660 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
6661 and sometimes 'EMACS_UINT', to represent these timestamps.
6662 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
6663 This makes the code easier to follow, and makes it easier to catch
6664 integer overflow bugs such as Bug#8664.
6665 * frame.c (Fmouse_position, Fmouse_pixel_position):
6666 Use Time, not unsigned long, for user-interface timestamps.
6667 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6668 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6669 * keyboard.h (last_event_timestamp): Likewise.
6670 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6671 * menu.h (xmenu_show): Likewise.
6672 * term.c (term_mouse_position): Likewise.
6673 * termhooks.h (struct input_event.timestamp): Likewise.
6674 (struct terminal.mouse_position_hook): Likewise.
6675 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6676 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6677 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6678 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6679 what it was before.
6680 * menu.h, termhooks.h: Include "systime.h", for Time.
6681
8e55734a
PE
6682 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6683 Don't assume that the difference between two unsigned long values
6684 can fit into an integer. At this point, we know button_down_time
6685 <= event->timestamp, so the difference must be nonnegative, so
6686 there's no need to cast the result if double-click-time is
6687 nonnegative, as it should be; check that it's nonnegative, just in
6688 case. This bug is triggered when events are more than 2**31 ms
86db42d2 6689 apart (about 25 days). (Bug#8664)
8e55734a 6690
841f1b75 6691 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 6692 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 6693
3e26f69c
PE
6694 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6695 that always fit in int. Use a sentinel instead of a counter, to
6696 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
6697 * frame.h (struct frame): Use int for menu_bar_items_used
6698 instead of EMACS_INT, since it always fits in int.
3e26f69c 6699
5cc152c0
PE
6700 * menu.c (grow_menu_items): Check for int overflow.
6701
d89eb65e
PE
6702 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6703
5235bd3e
PE
6704 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6705 Before, the code was not consistent. These values cannot exceed
6706 2**31 - 1 so there's no need to make them unsigned.
6707 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6708 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6709 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6710 as modifiers.
6711 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6712
bc827e23
PE
6713 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6714 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6715 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6716 presumably because the widths might not match.
6717
78eb494e
PE
6718 * window.c (size_window): Avoid needless test at loop start.
6719
04f2d78b
CB
67202011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6721
6722 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6723
d2fc7e3d 67242011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
6725
6726 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6727
d2fc7e3d 67282011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
6729
6730 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6731 `width' to `bar_area_x' and `bar_area_width', respectively.
6732 (x_scroll_run): Take account of fringe background extension.
6733
04f2d78b
CB
6734 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6735 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
6736 `bar_area_width', respectively.
6737 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6738 background extension.
6739
79b70037
GM
67402011-05-10 Jim Meyering <meyering@redhat.com>
6741
6742 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6743
2f142cc5
JB
67442011-05-10 Juanma Barranquero <lekktu@gmail.com>
6745
6746 * image.c (Finit_image_library): Return t for built-in image types,
6747 like pbm and xbm. (Bug#8640)
6748
57679c86
AS
67492011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6750
6751 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6752
888c9e86
EZ
67532011-05-07 Eli Zaretskii <eliz@gnu.org>
6754
b0512a1d
EZ
6755 * w32console.c (Fset_screen_color): Doc fix.
6756 (Fget_screen_color): New function.
6757 (syms_of_ntterm): Defsubr it.
6758
7285dc67
EZ
6759 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6760 unlink the temporary file if Fcall_process didn't create it in the
6761 first place.
6762 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6763 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
6764 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6765 cue to call_process_cleanup not to close that handle.
6766
4d3fcc8e
BK
67672011-05-07 Ben Key <bkey76@gmail.com>
6768
6769 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6770 one of two shell specific rules, either bootstrap-temacs-CMD or
6771 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6772 to the previous implementation of the bootstrap-temacs rule.
6773 The bootstrap-temacs-CMD rule is similar to the previous
6774 implementation of the bootstrap-temacs rule except that it
6775 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6776 variable.
6777
6778 These changes, along with some changes to nt/configure.bat,
6779 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6780 earlier fix to add support for --cflags and --ldflags options
6781 that include quotes so that it works whether make uses cmd or
6782 sh as the shell.
6783
b4289b64
MA
67842011-05-06 Michael Albinus <michael.albinus@gmx.de>
6785
6786 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6787 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6788 is a constant.
6789 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6790 a string. Handle both cases.
6791 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6792 (Fdbus_register_method): Use Qinvalid_function.
6793
af4c0e28
JB
67942011-05-06 Juanma Barranquero <lekktu@gmail.com>
6795
6796 * makefile.w32-in: Update dependencies.
6797 (LISP_H): Add inttypes.h and stdin.h.
6798 (PROCESS_H): Add unistd.h.
6799
c51453d9
EZ
68002011-05-06 Eli Zaretskii <eliz@gnu.org>
6801
6802 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6803 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6804
8ff0ac3c 68052011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 6806
4c4b566b
PE
6807 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6808
aab2b9b5
PE
6809 * term.c (vfatal): Remove stray call to va_end.
6810 It's not needed and the C Standard doesn't allow it here anyway.
6811
c378da0b
PE
6812 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6813 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6814
288b08c7
PE
6815 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6816 bytes.
6817
e3601888
PE
6818 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6819
db6c0e74
PE
6820 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6821
dd5963ea
PE
6822 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6823
88c9450f
PE
6824 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6825
2f9442b8
PE
6826 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6827
c032b5f8
PE
6828 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6829 * charset.c (Fdefine_charset_internal): Don't initialize
6830 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 6831 32-bit int (Bug#8600).
a108c10b
PE
6832
6833 * lread.c (read_integer): Be more consistent with string-to-number.
6834 Use string_to_number to do the actual conversion; this avoids
6835 rounding errors and fixes some other screwups. Without this fix,
6836 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6837 (digit_to_number): Move earlier, for benefit of read_integer.
6838 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 6839 not a digit in any supported base. (Bug#8602)
a108c10b 6840
ad5f9eea
PE
6841 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6842
aec1708a
PE
6843 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6844 to match comment at start of function. This also removes a
6845 GCC warning about overflow in a 32+64-bit port.
6846
47be4ab5
PE
6847 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6848
371cac43
PE
6849 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6850 Reported by Stefan Monnier in
6851 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
6852 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6853 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 6854
d01a7826
PE
6855 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6856 (EMACS_UINTPTR): Likewise, with uintptr_t.
6857
7fd47d5c
PE
6858 * lisp.h: Prefer 64-bit EMACS_INT if available.
6859 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6860 on 32-bit hosts that have 64-bit int, so that they can access
6861 large files.
122b0c86
PE
6862 However, temporarily disable this change unless the temporary
6863 symbol WIDE_EMACS_INT is defined.
7fd47d5c 6864
8727937b
PE
6865 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6866
8ac068ac
PE
6867 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6868 This removes an assumption that EMACS_INT and long are the same
6869 width as pointers. The assumption is true for Emacs porting targets
6870 now, but we want to make other targets possible.
6871 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6872 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6873 In the rest of the code, change types of integers that hold casted
6874 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6875 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6876 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6877 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6878 No need to cast type when ORing.
6879 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6880 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6881 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6882 assume EMACS_INT is the same width as char *.
6883 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6884 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6885 Remove no-longer-needed casts.
6886 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6887 (xg_tool_bar_help_callback, xg_make_tool_item):
6888 Use EMACS_INTPTR to hold an integer
6889 that will be cast to void *; this can avoid a GCC warning
6890 if EMACS_INT is not the same width as void *.
6891 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6892 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6893 (current_message_1, set_message_1):
6894 Use a local to convert to proper width without a cast.
6895 * xmenu.c (dialog_selection_callback): Likewise.
6896
ede49d71
PE
6897 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6898 Also, don't assume VALBITS / RAND_BITS is less than 5,
6899 and don't rely on undefined behavior when shifting a 1 left into
6900 the sign bit.
6901 * lisp.h (get_random): Change signature to match.
6902
2f30ecd0
PE
6903 * lread.c (hash_string): Use size_t, not int, for hash computation.
6904 Normally we prefer signed values; but hashing is special, because
6905 it's better to use unsigned division on hash table sizes so that
6906 the remainder is nonnegative. Also, size_t is the natural width
6907 for hashing into memory. The previous code used 'int', which doesn't
6908 retain enough info to hash well into very large tables.
6909 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6910
2a866e7b
PE
6911 * dbusbind.c: Don't possibly lose pointer info when converting.
6912 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6913 Use XPNTR rather than XHASH, so that the high-order bits of
6914 the pointer aren't lost when converting through void *.
6915
51639eac
PE
6916 * eval.c (Fautoload): Don't double-shift a pointer.
6917
92394119
PE
6918 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6919
dbdb9a7c
JB
69202011-05-06 Juanma Barranquero <lekktu@gmail.com>
6921
6922 * gnutls.c (DEF_GNUTLS_FN):
6923 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6924
db7a0b4f
AS
69252011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6926
6927 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6928 marker. (Bug#8610)
6929
cd394be1 69302011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
6931
6932 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6933 New version that can reserve upto 2GB of heap space.
6934
f7ff1b0f 69352011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
6936
6937 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6938
639c109b
TZ
69392011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6940
6941 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6942 `gnutls_certificate_set_x509_key_file'.
6943
d2127135
JB
69442011-05-05 Juanma Barranquero <lekktu@gmail.com>
6945
6946 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6947 Update dependencies.
6948
e968f4f3
JB
69492011-05-04 Juanma Barranquero <lekktu@gmail.com>
6950
6951 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6952 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6953 Remove unused parameter `fildes'.
6954 * process.c (read_process_output, send_process): Don't pass it.
6955
84d358f0
JB
69562011-05-04 Juanma Barranquero <lekktu@gmail.com>
6957
6958 Fix previous change: the library cache is defined in w32.c.
6959 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6960 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6961
0898ca10
JB
69622011-05-04 Juanma Barranquero <lekktu@gmail.com>
6963
6964 Implement dynamic loading of GnuTLS on Windows.
6965
6966 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6967 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6968 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6969 Declare.
6970
6971 * gnutls.c (Qgnutls_dll): Define.
6972 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6973 (gnutls_*): Declare function pointers.
6974 (init_gnutls_functions): New function to initialize function pointers.
6975 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6976 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6977 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6978 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6979 (emacs_gnutls_write, emacs_gnutls_read)
6980 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6981 (Fgnutls_available_p): New function.
6982 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6983 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6984 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6985
6986 * image.c: Include w32.h.
6987 (Vimage_type_cache): Delete.
6988 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6989 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6990 (w32_delayed_load): Move to w32.c.
6991
6992 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6993
6994 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6995 (w32_delayed_load): Move from image.c. When loading a library, record
6996 its filename in the :loaded-from property of the library id.
6997 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6998 Initialize and staticpro them.
6999 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
7000
7001 * process.c: Include lisp.h before w32.h, not after.
7002 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
7003 instead of gnutls_record_check_pending.
7004
7005 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
7006
ff4de4aa
TZ
70072011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
7008
7009 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
7010 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
7011 as passed in.
7012
abe95abb
JD
70132011-05-03 Jan Djärv <jan.h.d@swipnet.se>
7014
7015 * xterm.c (x_set_frame_alpha): Do not set property on anything
7016 else than FRAME_X_OUTER_WINDOW (Bug#8608).
7017
e16e55d4
JB
70182011-05-02 Juanma Barranquero <lekktu@gmail.com>
7019
7020 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
7021
bafcf6a5
JB
70222011-05-02 Juanma Barranquero <lekktu@gmail.com>
7023
7024 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
7025 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
7026 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
7027 (gnutls_global_initialized, Qgnutls_bootprop_priority)
7028 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
7029 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
7030 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
7031 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
7032 (Qgnutls_bootprop_callbacks_verify): Make static.
7033
e7a6747f
AS
70342011-05-01 Andreas Schwab <schwab@linux-m68k.org>
7035
19ed11ba
AS
7036 * callproc.c: Indentation fixup.
7037
e7a6747f 7038 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
7039 (wait_for_termination, interruptible_wait_for_termination):
7040 Move after wait_for_termination_1.
e7a6747f 7041
1ef14cb4
LMI
70422011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
7043
7044 * sysdep.c (interruptible_wait_for_termination): New function
7045 which is like wait_for_termination, but allows keyboard
7046 interruptions.
7047
7048 * callproc.c (Fcall_process): Add (:file "file") as an option for
7049 the STDOUT buffer.
7050 (Fcall_process_region): Ditto.
7051
330d880c
EZ
70522011-04-30 Eli Zaretskii <eliz@gnu.org>
7053
8db90b73
EZ
7054 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
7055 rather than `XVECTOR (FOO)->size'.
7056
330d880c
EZ
7057 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
7058 inttypes.h, as a gnulib replacement is used if it not available in
7059 system headers.
7060
15cbd324
EZ
70612011-04-21 Eli Zaretskii <eliz@gnu.org>
7062
7063 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
7064 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
7065 of MOST_POSITIVE_FIXNUM. (Bug#8528)
7066
7067 * coding.c (coding_alloc_by_realloc): Error out if destination
7068 will grow beyond MOST_POSITIVE_FIXNUM.
7069 (decode_coding_emacs_mule): Abort if there isn't enough place in
7070 charbuf for the composition carryover bytes. Reserve an extra
7071 space for up to 2 characters produced in a loop.
7072 (decode_coding_iso_2022): Abort if there isn't enough place in
7073 charbuf for the composition carryover bytes.
7074
70752011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 7076
ae940cca
EZ
7077 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
7078 aborting when %lld or %lll format is passed.
7079 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
7080 %llo or %llx format is passed. (Bug#8545)
7081
03ab8921
EZ
7082 * window.c (window_scroll_line_based): Use a marker instead of
7083 simple variables to record original value of point. (Bug#7952)
7084
afda1437
EZ
7085 * doprnt.c (doprnt): Fix the case where a multibyte sequence
7086 produced by %s or %c overflows available buffer space. (Bug#8545)
7087
f76dee0c
PE
70882011-04-28 Paul Eggert <eggert@cs.ucla.edu>
7089
7090 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 7091 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 7092
fdc5744d
JB
70932011-04-28 Juanma Barranquero <lekktu@gmail.com>
7094
7095 * w32.c (init_environment): Warn about defaulting HOME to C:\.
7096
638f053a
JB
70972011-04-28 Juanma Barranquero <lekktu@gmail.com>
7098
7099 * keyboard.c (Qdelayed_warnings_hook): Define.
7100 (command_loop_1): Run `delayed-warnings-hook'
7101 if Vdelayed_warnings_list is non-nil.
7102 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
7103 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
7104
d178f871
EZ
71052011-04-28 Eli Zaretskii <eliz@gnu.org>
7106
7107 * doprnt.c (doprnt): Don't return value smaller than the buffer
7108 size if the message was truncated. (Bug#8545).
7109
b124fd93
JB
71102011-04-28 Juanma Barranquero <lekktu@gmail.com>
7111
7112 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
7113 (Fx_window_property): #if-0 the whole functions, not just the bodies.
7114
e810457d
PE
71152011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7116
7117 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
7118
ea51cceb
JB
71192011-04-27 Juanma Barranquero <lekktu@gmail.com>
7120
7121 * makefile.w32-in: Update dependencies.
7122
94dcfacf
EZ
71232011-04-27 Eli Zaretskii <eliz@gnu.org>
7124
7125 Improve `doprnt' and its usage. (Bug#8545)
7126 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
7127 `format_end'. Remove support for %l as a conversion specifier.
7128 Don't use xrealloc. Improve diagnostics when the %l size modifier
7129 is used. Update the commentary.
7130
7131 * eval.c (verror): Simplify calculation of size_t.
7132
7133 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
7134 messages.
7135
f61f41d7
PE
71362011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
7137
7138 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
7139 change.
7140
96fb4434
PE
71412011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7142
7143 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7144 This makes this file independent of the recent pseudovector change.
7145
671875da 71462011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 7147
69e9b5a3
PE
7148 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7149
b5f869a7 7150 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 7151 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 7152 Remove unused local.
c8926152 7153 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 7154
841a1577 7155 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
7156 GCC 4.6.0 optimizes based on type-based alias analysis.
7157 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
7158 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7159 != &v->size, and therefore "v->size = 1; b->size = 2; return
7160 v->size;" must therefore return 1. This assumption is incorrect
7161 for Emacs, since it type-puns struct Lisp_Vector * with many other
7162 types. To fix this problem, this patch adds a new type struct
f904488f 7163 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
7164 and pseudovectors, and helps optimizing compilers not get fooled
7165 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7166 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
7167 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7168 the size member.
eab3844f
PE
7169 (XSETPVECTYPE): Rewrite in terms of new macro.
7170 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7171 This is a bit clearer, and further avoids the possibility of
7172 undesirable aliasing.
7173 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 7174 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
7175 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7176 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
7177 (ASIZE): Now uses header.size rather than size.
7178 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
7179 to avoid the hassle of writing XVECTOR (foo)->header.size.
7180 (struct vectorlike_header): New type.
eab3844f
PE
7181 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7182 object, to help avoid aliasing.
7183 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7184 (SUBRP): Likewise, since Lisp_Subr is a special case.
7185 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7186 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7187 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 7188 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
7189 changed to be "header.size" and "header.next".
7190 * buffer.h (struct buffer): Likewise.
7191 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7192 * frame.h (struct frame): Likewise.
7193 * process.h (struct Lisp_Process): Likewise.
7194 * termhooks.h (struct terminal): Likewise.
7195 * window.c (struct save_window_data, struct saved_window): Likewise.
7196 * window.h (struct window): Likewise.
7197 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7198 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7199 * buffer.c (init_buffer_once): Likewise.
7200 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7201 special case.
7202 * process.c (Fformat_network_address): Use local var for size,
7203 for brevity.
7204
0df1eac5
PE
7205 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7206
847ab9d1 7207 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
7208 * data.c (atof): Remove decl; no longer used or needed.
7209 (digit_to_number): Move to lread.c.
7210 (Fstring_to_number): Use new string_to_number function, to be
7211 consistent with how the Lisp reader treats infinities and NaNs.
7212 Do not assume that floating-point numbers represent EMACS_INT
7213 without losing information; this is not true on most 64-bit hosts.
7214 Avoid double-rounding errors, by insisting on integers when
7215 parsing non-base-10 numbers, as the documentation specifies.
7216 * lisp.h (string_to_number): New decl, replacing ...
7217 (isfloat_string): Remove.
bc0a5c13 7218 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 7219 (read1): Do not accept +. and -. as integers; this
452f4150
PE
7220 appears to have been a coding error. Similarly, do not accept
7221 strings like +-1e0 as floating point numbers. Do not report
7222 overflow for integer overflows unless the base is not 10 which
7223 means we have no simple and reliable way to continue.
7224 Break out the floating-point parsing into a new
7225 function string_to_number, so that Fstring_to_number parses
7226 floating point numbers consistently with the Lisp reader.
04f2d78b 7227 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
7228 (E_CHAR, EXP_INT): Remove, replacing with ...
7229 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7230 (string_to_number): New function, replacing isfloat_string.
7231 This function checks for valid syntax and produces the resulting
7232 Lisp float number too. Rework it so that string-to-number
bc0a5c13 7233 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
7234 so that overflow for non-base-10 numbers is reported only when
7235 there's no portable and simple way to convert to floating point.
452f4150 7236
67769ffc
PE
7237 * textprop.c (set_text_properties_1): Rewrite for clarity,
7238 and to avoid GCC warning about integer overflow.
7239
c20db43f
PE
7240 * intervals.h (struct interval): Use EMACS_INT for members
7241 where EMACS_UINT might cause problems. See
7242 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7243 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7244 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7245 All uses changed.
37aa2f85
PE
7246 (offset_intervals): Tell GCC not to worry about length overflow
7247 when negating a negative length.
c20db43f 7248
2538aa2f
PE
7249 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7250 (overrun_check_free): Likewise.
7251
f2d3008d
PE
7252 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7253 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7254 word size.
7255
ec8df744
PE
7256 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7257 (gnutls_make_error): Rename local to avoid shadowing.
7258 (gnutls_emacs_global_deinit): ifdef out; not used.
7259 (Fgnutls_boot): Use const for pointer to readonly storage.
7260 Comment out unused local. Fix pointer signedness problems.
7261
640ee02d
PE
7262 * lread.c (openp): Don't stuff size_t into an 'int'.
7263 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7264 about possible signed overflow.
7265
6048fb2a
PE
7266 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7267 (GDK_KEY_g): Don't define if already defined.
7268 (xg_prepare_tooltip): Avoid pointer signedness problem.
7269 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7270
fa3c87e1
PE
7271 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7272 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7273
2172544b
PE
7274 * xfns.c (Fx_window_property): Simplify a bit,
7275 to make a bit faster and to avoid GCC 4.6.0 warning.
7276 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7277
9b821a21
PE
7278 * fns.c (internal_equal): Don't assume size_t fits in int.
7279
3c616cfa
PE
7280 * alloc.c (compact_small_strings): Tighten assertion a little.
7281
c2982e87
PE
7282 Replace pEd with more-general pI, and fix some printf arg casts.
7283 * lisp.h (pI): New macro, generalizing old pEd macro to other
7284 conversion specifiers. For example, use "...%"pI"d..." rather
7285 than "...%"pEd"...".
7286 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 7287 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
7288 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7289 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7290 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7291 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7292 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7293 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7294 64-bit hosts.
7295 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7296 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7297 * print.c (safe_debug_print, print_object): Likewise.
7298 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7299 to int.
6f04d126
PE
7300 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7301 avoiding the 0 flag, which is not portable.
c2982e87
PE
7302 * process.c (Fmake_network_process): Use pI to avoid cast.
7303 * region-cache.c (pp_cache): Likewise.
7304 * xdisp.c (decode_mode_spec): Likewise.
7305 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7306 behavior on 64-bit hosts with printf arg.
6f04d126 7307 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
7308 (x_stop_queuing_selection_requests): Likewise.
7309 (x_get_window_property): Don't truncate byte count to an 'int'
7310 when tracing.
0b432f21 7311
5e073ec7
PE
7312 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7313 here, since it parses constructs like leading '-' and spaces,
7314 which are not wanted; and it overflows with large numbers.
7315 Instead, simply match F[0-9]+, which is what is wanted anyway.
7316
36372bf9
PE
7317 * alloc.c: Remove unportable assumptions about struct layout.
7318 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7319 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7320 (allocate_vectorlike, make_pure_vector): Use the new macros,
7321 plus offsetof, to remove unportable assumptions about struct layout.
7322 These assumptions hold on all porting targets that I know of, but
7323 they are not guaranteed, they're easy to remove, and removing them
7324 makes further changes easier.
7325
0b432f21
PE
7326 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7327 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
7328 (string_overrun_cookie): Now const. Use initializers that
7329 don't formally overflow signed char, to avoid warnings.
000098c1
PE
7330 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7331 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
7332 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7333 multiple of sizeof (EMACS_INT); it need not be, if
7334 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 7335 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 7336
895009e1
JB
73372011-04-26 Juanma Barranquero <lekktu@gmail.com>
7338
7339 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7340
6a7a1b0b
TZ
73412011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7342
7343 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 7344 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
7345 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7346
841a1577 73472011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
7348
7349 * lisp.h (Qdebug): List symbol.
895009e1 7350 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
7351 * keyboard.c (debug-on-event): New variable.
7352 (handle_user_signal): Break into debugger when debug-on-event
7353 matches the current signal symbol.
7354
f2d3ba6f
DN
73552011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7356
7357 * alloc.c (check_sblock, check_string_bytes)
7358 (check_string_free_list): Convert to standard C.
7359
42ce4c63
TZ
73602011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7361
7362 * w32.c (emacs_gnutls_push): Fix typo.
7363
825cd63c
EZ
73642011-04-25 Eli Zaretskii <eliz@gnu.org>
7365
fb11d64d
EZ
7366 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7367 "cast to pointer from integer of different size".
7368
825cd63c
EZ
7369 Improve doprnt and its use in verror. (Bug#8545)
7370 * doprnt.c (doprnt): Document the set of format control sequences
7371 supported by the function. Use SAFE_ALLOCA instead of always
7372 using `alloca'.
7373
7374 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7375 is one byte too soon. Don't use xrealloc; instead xfree and
7376 xmalloc anew.
7377
e061a11b
TZ
73782011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7379
7380 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7381 callbacks stage.
7382
7383 * gnutls.c: Renamed global_initialized to
7384 gnutls_global_initialized. Added internals for the
7385 :verify-hostname-error, :verify-error, and :verify-flags
7386 parameters of `gnutls-boot' and documented those parameters in the
7387 docstring. Start callback support.
9173deec
JB
7388 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7389 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7390 on error. Return error code.
e061a11b
TZ
7391 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7392 (emacs_gnutls_read): Likewise.
7393 (Fgnutls_boot): Return handshake error code.
7394 (emacs_gnutls_handle_error): New function.
7395 (wsaerror_to_errno): Likewise.
7396
7397 * w32.h (emacs_gnutls_pull): Add prototype.
7398 (emacs_gnutls_push): Likewise.
7399
7400 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7401 (emacs_gnutls_push): Likewise.
7402
74032011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7404
7405 * process.c (wait_reading_process_output): Check if GnuTLS
7406 buffered some data internally if no FDs are set for TLS
7407 connections.
7408
7409 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7410 (LIBS): Link to USER_LIBS.
7411 ($(BLD)/gnutls.$(0)): New target.
7412
fa6996bc
EZ
74132011-04-24 Eli Zaretskii <eliz@gnu.org>
7414
eb35682e
EZ
7415 * xdisp.c (handle_single_display_spec): Rename the
7416 display_replaced_before_p argument into display_replaced_p, to
7417 make it consistent with the commentary. Fix typos in the
7418 commentary.
7419
e2ad650c
EZ
7420 * textprop.c (syms_of_textprop): Remove dead code.
7421 (copy_text_properties): Delete obsolete commentary about an
7422 interface that was deleted long ago. Fix typos in the description
7423 of arguments.
7424
1b2de274
EZ
7425 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7426 to changes in oldXMenu/XMenu.h from 2011-04-16.
7427 <menu_help_message, prev_menu_help_message>: Constify.
7428 (IT_menu_make_room): menu->help_text is now `const char **';
7429 adjust.
7430
7431 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7432 to changes in oldXMenu/XMenu.h from 2011-04-16.
7433 (struct XMenu): Declare `help_text' `const char **'.
7434
7435 * xfaces.c <Qunspecified>: Make extern again.
7436
7437 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 7438 required by POSIX.
1b2de274 7439
762b15be
EZ
7440 * doc.c (get_doc_string): Improve the format passed to `error'.
7441
7442 * doprnt.c (doprnt): Improve commentary.
7443
7444 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7445
7446 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7447 them with etags.
7448
f1052e5d
EZ
7449 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7450 changes in globals.h immediately force recompilation.
762b15be
EZ
7451 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7452 $(CURDIR)/s/ms-w32.h.
7453 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 7454
fa6996bc
EZ
7455 * character.c (Fchar_direction): Function deleted.
7456 (syms_of_character): Don't defsubr it.
7457 <char-direction-table>: Deleted.
7458
e6c3da20
EZ
74592011-04-23 Eli Zaretskii <eliz@gnu.org>
7460
7461 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7462 * doprnt.c: Include limits.h.
7463 (SIZE_MAX): New macro.
04f2d78b
CB
7464 (doprnt): Return a size_t value. 2nd arg is now size_t.
7465 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
7466 Improve overflow protection. Support `l' modifier for integer
7467 conversions. Support %l conversion. Don't assume an EMACS_INT
7468 argument for integer conversions and for %c.
7469
7470 * lisp.h (doprnt): Restore prototype.
7471
7472 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7473 $(SRC)/character.h.
7474
7475 * Makefile.in (base_obj): Add back doprnt.o.
7476
7477 * deps.mk (doprnt.o): Add back prerequisites.
7478 (callint.o): Depend on character.h.
7479
7480 * eval.c (internal_lisp_condition_case): Include the handler
7481 representation in the error message.
7482 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7483 when breaking from the loop.
7484
7485 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7486
7487 * callint.c (Fcall_interactively): When displaying error message
7488 about invalid control letter, pass the character's codepoint, not
7489 a pointer to its multibyte form. Improve display of the character
7490 in octal and display also its hex code.
7491
7492 * character.c (char_string): Use %x to display the (unsigned)
7493 codepoint of an invalid character, to avoid displaying a bogus
7494 negative value.
7495
7496 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7497 `error', not SYMBOL_NAME itself.
7498
7499 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7500 character arguments to `error'.
7501
7502 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7503 to `error' in error message about FINAL_CHAR argument. Make sure
7504 FINAL_CHAR is a character, and use %c when it is passed as
7505 argument to `error'.
7506
4ffd0d6b 75072011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
7508
7509 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7510
7511 * w32.c: Include <time.h>.
7512 (sys_localtime): New function.
7513
4ffd0d6b 75142011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
7515
7516 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7517
4ffd0d6b 7518 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 7519
4ffd0d6b 75202011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 7521
4ffd0d6b
GM
7522 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7523 zombies (Bug#8467).
aac0c6e3 7524
04c56954
EZ
75252011-04-19 Eli Zaretskii <eliz@gnu.org>
7526
7527 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7528 gl_state.e_property when gl_state.object is Qt.
7529
7530 * insdel.c (make_gap_larger): Remove limitation of buffer size
7531 to <= INT_MAX.
7532
16a43933
CY
75332011-04-18 Chong Yidong <cyd@stupidchicken.com>
7534
7535 * xdisp.c (lookup_glyphless_char_display)
7536 (produce_glyphless_glyph): Handle cons cell entry in
7537 glyphless-char-display.
7538 (Vglyphless_char_display): Document it.
7539
7540 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7541 glyphless-char-display.
7542
4581706e
CY
75432011-04-17 Chong Yidong <cyd@stupidchicken.com>
7544
7545 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7546
7547 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7548
7549 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7550 definition for no-X builds.
7551
4887c6e2 75522011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 7553
fd35b6f9
PE
7554 Static checks with GCC 4.6.0 and non-default toolkits.
7555
5c1ccb01
PE
7556 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7557
006c5daa
PE
7558 * process.c (keyboard_bit_set): Define only if SIGIO.
7559 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7560 (send_process): Repair possible setjmp clobbering.
7561
efc736d3
PE
7562 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7563
4e2fe2e6
PE
7564 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7565
f97334a2
PE
7566 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7567
4e75f29d
PE
7568 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7569 Define only if needed.
7570
90efadd1
PE
7571 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7572 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 7573 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 7574
3c647824
PE
7575 * dispextern.h (struct redisplay_interface): Rename param
7576 to avoid shadowing.
e264f262 7577 * termhooks.h (struct terminal): Likewise.
761383f4 7578 * xterm.c (xembed_send_message): Likewise.
3c647824 7579
b58c5c4a
PE
7580 * insdel.c (make_gap_smaller): Define only if
7581 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7582
cad59032
PE
7583 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7584 it.
7585
c339dc2e
PE
7586 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7587 so that we aren't warned about unused symbols.
7588
91a3e27b
PE
7589 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7590
399c71d3 7591 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 7592
8ffc96f5
PE
7593 * xfns.c (x_real_positions): Mark locals as initialized.
7594
eef9bc79
PE
7595 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7596
098db9dd
PE
7597 * xterm.c: Fix problems found by static analysis with other toolkits.
7598 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
7599 (x_dispatch_event): Declare static if USE_GTK, and
7600 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 7601 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 7602 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
7603 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7604 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 7605
eb18f6cc
PE
7606 * xmenu.c (menu_help_callback): Pointer type fixes.
7607 Use const pointers when pointing at readonly data. Avoid pointer
7608 signedness clashes.
7609 (FALSE): Remove unused macro.
7610 (update_frame_menubar): Remove unused decl.
7611
1fe72bf8
PE
7612 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7613
60d9e1db
PE
7614 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7615 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7616 (single_menu_item): Rename local to avoid shadowing.
7617
39261c26
PE
7618 * keyboard.c (make_lispy_event): Remove unused local var.
7619
018c5e19
PE
7620 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7621 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7622
63d2b86e
PE
7623 * bitmaps: Change bitmaps from unsigned char back to the X11
7624 compatible char. Avoid the old compiler warnings about
7625 out-of-range initializers by using, for example, '\xab' rather
7626 than 0xab.
7627
aefd87e1
PE
7628 * xgselect.c (xgselect_initialize): Check vs interface
7629 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7630
bf501fb9
PE
7631 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7632
e9829fdf
PE
7633 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7634 to read-only memory.
7635
1086c095
PE
7636 * fns.c (vector): Remove; this old hack is no longer needed.
7637
2baccd04 7638 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 7639 Remove unused var.
dde42981 7640 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 7641
72391843 7642 * xrdb.c (x_load_resources): Omit unused local.
3565b346 7643
436c16df 7644 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 7645 (x_window): Rename locals to avoid shadowing.
dc5ddd85 7646 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 7647
92bb796d 7648 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 7649 (x_term_init): Remove local to avoid shadowing.
92bb796d 7650
764430a3 7651 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
7652
7653 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7654 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7655
d1dfb56c
EZ
76562011-04-16 Eli Zaretskii <eliz@gnu.org>
7657
c4354cb4
EZ
7658 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7659
d1dfb56c
EZ
7660 Fix regex.c, syntax.c and friends for buffers > 2GB.
7661 * syntax.h (struct gl_state_s): Declare character position members
7662 EMACS_INT.
7663
7664 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7665
04f2d78b
CB
7666 * textprop.c (verify_interval_modification, interval_of):
7667 Declare arguments EMACS_INT.
d1dfb56c
EZ
7668
7669 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7670 EMACS_INT.
7671
7672 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7673
7674 * indent.c (Fvertical_motion): Local variable it_start is now
7675 EMACS_INT.
7676
7677 * regex.c (re_match, re_match_2, re_match_2_internal)
7678 (bcmp_translate, regcomp, regexec, print_double_string)
7679 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7680 (re_compile_pattern, re_exec): Declare arguments and local
7681 variables `size_t' and `ssize_t' and return values `regoff_t', as
7682 appropriate.
7683 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7684 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7685 <compile_stack_type>: `size' and `avail' are now `size_t'.
7686
7687 * regex.h <regoff_t>: Use ssize_t, not int.
7688 (re_search, re_search_2, re_match, re_match_2): Arguments that
7689 specify buffer/string position and length are now ssize_t and
7690 size_t. Return type is regoff_t.
7691
613052cd
BK
76922011-04-16 Ben Key <bkey76@gmail.com>
7693
7694 * nsfont.m: Fixed bugs in ns_get_family and
7695 ns_descriptor_to_entity that were caused by using free to
7696 deallocate memory blocks that were allocated by xmalloc (via
7697 xstrdup). This caused Emacs to crash when compiled with
7698 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7699 --enable-checking=xmallocoverrun). xfree is now used to
7700 deallocate these memory blocks.
7701
4170f62f 77022011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 7703
71b41406
PE
7704 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7705
9587a89d
PE
7706 emacs_write: Accept and return EMACS_INT for sizes.
7707 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7708 et seq.
7709 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7710 Accept and return EMACS_INT.
7711 (emacs_gnutls_write): Return the number of bytes written on
7712 partial writes.
7713 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
7714 (emacs_read, emacs_write): Remove check for negative size, as the
7715 Emacs source code has been audited now.
9587a89d
PE
7716 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7717 (emacs_read, emacs_write): Use it.
273a5f82
PE
7718 * process.c (send_process): Adjust to the new signatures of
7719 emacs_write and emacs_gnutls_write. Do not attempt to store
7720 a byte offset into an 'int'; it might overflow.
9587a89d 7721 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 7722
3e047f51
PE
7723 * sound.c: Don't assume sizes fit in 'int'.
7724 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 7725 Return EMACS_INT, not int.
3e047f51 7726 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
7727 Accept EMACS_INT, not int.
7728 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
7729 record read return values.
7730
cc39a9db
BK
77312011-04-15 Ben Key <bkey76@gmail.com>
7732
c9d0ec6d
JB
7733 * keyboard.c (Qundefined): Don't declare static since it is used
7734 in nsfns.m.
7735 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7736 static since they are used in nsfont.m.
cc39a9db 7737
6c60eb9f
SM
77382011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7739
7740 * process.c (Qprocessp): Don't declare static.
7741 * lisp.h (Qprocessp): Declare again.
7742
7990b61a
JB
77432011-04-15 Juanma Barranquero <lekktu@gmail.com>
7744
7745 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7746
5d4cb038
PE
77472011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7748
8bd7b830 7749 Improve C-level modularity by making more things 'static'.
cd64ea1d 7750
e3b27b31
PE
7751 Don't publish debugger-only interfaces to other modules.
7752 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7753 (verify_bytepos, count_markers): Move decls to the only modules
7754 that need them.
7755 * region-cache.h (pp_cache): Likewise.
7756 * window.h (check_all_windows): Likewise.
7757 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7758
5d4cb038
PE
7759 * sysdep.c (croak): Now static, if
7760 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7761 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
7762
7763 * alloc.c (refill_memory_reserve): Now static if
7764 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7765 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 7766
e87b6180
PE
7767 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7768 Define only if USE_LUCID.
7769
ac64929e
PE
7770 * xrdb.c (x_customization_string, x_rm_string): Now static.
7771
6f37259d
PE
7772 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7773 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7774
1683e3ab
PE
7775 * xdisp.c (draw_row_with_mouse_face): Now static.
7776 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7777
de9c2632
PE
7778 * window.h (check_all_windows): Mark externally visible.
7779
2b96acb7
PE
7780 * window.c (window_deletion_count): Now static.
7781
7782 * undo.c: Make symbols static if they're not exported.
7783 (last_undo_buffer, last_boundary_position, pending_boundary):
7784 Now static.
7785
50436f33
PE
7786 * textprop.c (interval_insert_behind_hooks): Now static.
7787 (interval_insert_in_front_hooks): Likewise.
7788
64520e5c
PE
7789 * term.c: Make symbols static if they're not exported.
7790 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7791 (max_frame_lines, tty_set_terminal_modes):
7792 (tty_reset_terminal_modes, tty_turn_off_highlight):
7793 (get_tty_terminal): Now static.
7794 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7795 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 7796 HAVE_WINDOW_SYSTEM.
64520e5c
PE
7797 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7798 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7799
1fa53021
PE
7800 * sysdep.c: Make symbols static if they're not exported.
7801 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7802 Now static.
7803 (sigprocmask_set, full_mask): Remove; unused.
7804 (wait_debugging): Mark as visible.
7805 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7806 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7807
d4b43b22
PE
7808 * syntax.c (syntax_temp): Define only if !__GNUC__.
7809
b7c513d0
PE
7810 * sound.c (current_sound_device, current_sound): Now static.
7811
989b29ad
PE
7812 * search.c (searchbufs, searchbuf_head): Now static.
7813
13a55a78
PE
7814 * scroll.c (scroll_cost): Remove; unused.
7815 * dispextern.h (scroll_cost): Remove decl.
7816
de68a1fc
PE
7817 * region-cache.h (pp_cache): Mark as externally visible.
7818
40ccffa6
PE
7819 * process.c: Make symbols static if they're not exported.
7820 (process_tick, update_tick, create_process, chan_process):
7821 (Vprocess_alist, proc_buffered_char, datagram_access):
7822 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7823 (deactivate_process): Mark defn as static, as well as decl.
7824 * lisp.h (create_process): Remove decl.
7825 * process.h (chan_process, Vprocess_alist): Remove decls.
7826
ad64fc97
PE
7827 * print.c: Make symbols static if they're not exported.
7828 (print_depth, new_backquote_output, being_printed, print_buffer):
7829 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7830 (print_interval, print_number_index, initial_stderr_stream):
7831 Now static.
7832 * lisp.h (Fprinc): Remove decl.
7833 (debug_output_compilation_hack): Mark as externally visible.
7834
adddb265
PE
7835 * sysdep.c (croak): Move decl from here to syssignal.h.
7836 * syssignal.h (croak): Put it here, so the API can be checked when
7837 'croak' is called from dissociate_if_controlling_tty.
7838
1717ede2
PE
7839 * minibuf.c: Make symbols static if they're not exported.
7840 (minibuf_save_list, choose_minibuf_frame): Now static.
7841 * lisp.h (choose_minibuf_frame): Remove decl.
7842
fa5fb2bc
PE
7843 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7844
1e3890d1
PE
7845 * lread.c: Make symbols static if they're not exported.
7846 (read_objects, initial_obarray, oblookup_last_bucket_number):
7847 Now static.
7848 (make_symbol): Remove; unused.
7849 * lisp.h (initial_obarray, make_symbol): Remove decls.
7850
8a1414fa
PE
7851 * keyboard.c: Make symbols static if they're not exported.
7852 (single_kboard, recent_keys_index, total_keys, recent_keys):
7853 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7854 (this_single_command_key_start, echoing, last_auto_save):
7855 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7856 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7857 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7858 (Vlispy_mouse_stem, double_click_count):
7859 Now static.
7860 (force_auto_save_soon): Define only if SIGDANGER.
7861 (ignore_mouse_drag_p): Now static if
7862 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7863 (print_help): Remove; unused.
7864 (stop_character, last_timer_event): Mark as externally visible.
7865 * keyboard.h (ignore_mouse_drag_p): Declare only if
7866 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7867 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7868 * lisp.h (echoing): Remove decl.
7869 (force_auto_save_soon): Declare only if SIGDANGER.
7870 * xdisp.c (redisplay_window): Simplify code, to make it more
7871 obvious that ignore_mouse_drag_p is not accessed if !defined
7872 USE_GTK && !defined HAVE_NS.
7873
93ea6e8f
PE
7874 * intervals.c: Make symbols static if they're not exported.
7875 (merge_properties_sticky, merge_interval_right, delete_interval):
7876 Now static.
7877 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7878
77382fcc
PE
7879 * insdel.c: Make symbols static if they're not exported.
7880 However, leave prepare_to_modify_buffer alone. It's never
7881 called from outside this function, but that appears to be a bug.
7882 (combine_after_change_list, combine_after_change_buffer):
4889fc82 7883 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
7884 (adjust_after_replace_noundo): Remove; unused.
7885 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 7886 (signal_before_change): Remove decls.
77382fcc 7887
9306c32e
PE
7888 * indent.c (val_compute_motion, val_vmotion): Now static.
7889
cd44d2eb
PE
7890 * image.c: Make symbols static if they're not exported.
7891 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7892 if USE_GTK.
7893 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7894 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7895
ad9a7a06
PE
7896 * fringe.c (standard_bitmaps): Now static.
7897 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7898
81626931
PE
7899 * frame.c: Make symbols static if they're not exported.
7900 (x_report_frame_params, make_terminal_frame): Now static.
7901 (get_frame_param): Now static, unless HAVE_NS.
7902 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7903 (x_get_resource_string): Remove; not used.
7904 * frame.h (make_terminal_frame, x_report_frame_params):
7905 (x_get_resource_string); Remove decls.
7906 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7907 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7908
239f9db9
PE
7909 * font.c, fontset.c: Make symbols static if they're not exported.
7910 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7911 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7912 * font.c (font_close_object): Now static.
7913 * font.h (font_close_object): Remove.
7914 * fontset.c (FONTSET_OBJLIST): Remove.
7915 (free_realized_fontset) #if-0 the body, which does nothing.
7916 (face_suitable_for_char_p): #if-0, as it's never called.
7917 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
7918 * xfaces.c (face_at_string_position):
7919 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
7920 since 0 is always ASCII.
7921
dfcf3579
PE
7922 * fns.c (weak_hash_tables): Now static.
7923
5045092b
PE
7924 * fileio.c: Make symbols static if they're not exported.
7925 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7926 (Vwrite_region_annotation_buffers): Now static.
7927
57a96f5c
PE
7928 * eval.c: Make symbols static if they're not exported.
7929 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7930 * lisp.h (backtrace_list): Remove decl.
7931
35f08c38
PE
7932 * emacs.c: Make symbols static if they're not exported.
7933 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7934 (fatal_error_code, fatal_error_signal_hook, standard_args):
7935 Now static.
7936 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7937 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7938 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7939 * lisp.h (fatal_error_signal_hook): Remove decl.
7940 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7941
f44bd759
PE
7942 * editfns.c: Move a (normally-unused) function to its only use.
7943 * editfns.c, lisp.h (get_operating_system_release): Remove.
7944 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7945 worth the hassle of breaking this out.
7946
b532497d
PE
7947 * xterm.c: Make symbols static if they're not exported.
7948 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7949 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7950 (x_destroy_window, x_delete_display):
7951 Now static.
7952 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7953 (x_mouse_leave): Remove; unused.
7954 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7955 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7956 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7957 Remove decls.
7958 (x_mouse_leave): Declare only if WINDOWSNT.
7959 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7960 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7961 USE_X_TOOLKIT.
7962
1675728f
PE
7963 * ftxfont.c: Make symbols static if they're not exported.
7964 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7965 HAVE_FREETYPE.
7966 * font.h (ftxfont_driver): Likewise.
7967
e4cebfca
PE
7968 * xfns.c: Make symbols static if they're not exported.
7969 (x_last_font_name, x_display_info_for_name):
7970 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7971 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7972 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7973 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7974 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7975 (last_show_tip_args): Now static.
7976 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7977 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7978 (x_screen_planes): Remove; unused.
7979 * dispextern.h (x_screen_planes): Remove decl.
7980
5bf46f05
PE
7981 * dispnew.c: Make symbols static if they're not exported.
7982 * dispextern.h (redraw_garbaged_frames, scrolling):
7983 (increment_row_positions): Remove.
7984 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7985 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7986 Now static.
7987 (redraw_garbaged_frames): Remove; unused.
7988
435f4c28
PE
7989 * xfaces.c: Make symbols static if they're not exported.
7990 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7991 Remove decls.
7992 * xterm.h (defined_color): Remove decls.
7993 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7994 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7995 (menu_face_changed_default, defined_color, free_realized_face):
7996 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7997 (ascii_face_of_lisp_face): Remove; unused.
7998
8524aef3
PE
7999 * xdisp.c: Make symbols static if they're not exported.
8000 * dispextern.h (scratch_glyph_row, window_box_edges):
8001 (glyph_to_pixel_coords, set_cursor_from_row):
8002 (get_next_display_element, set_iterator_to_next):
8003 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
8004 (show_mouse_face): Remove decls
8005 * frame.h (message_buf_print): Likewise.
8006 * lisp.h (pop_message, set_message, check_point_in_composition):
8007 Likewise.
8008 * xterm.h (set_vertical_scroll_bar): Likewise.
8009 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
8010 (message_buf_print, scratch_glyph_row, displayed_buffer):
8011 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
8012 (get_next_display_element, show_mouse_face, window_box_edges):
8013 (frame_to_window_pixel_xy, check_point_in_composition):
8014 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
8015 (glyph_to_pixel_coords): Remove; unused.
8016
16390cd2
PE
8017 * dired.c (file_name_completion): Now static.
8018
8019 * dbusbind.c (xd_in_read_queued_messages): Now static.
8020
a25f4dfa
PE
8021 * lisp.h (circular_list_error, FOREACH): Remove; unused.
8022 * data.c (circular_list_error): Remove.
8023
14a9c8df
PE
8024 * commands.h (last_point_position, last_point_position_buffer):
8025 (last_point_position_window): Remove decls.
8026 * keyboard.c: Make these variables static.
8027
04f2d78b
CB
8028 * coding.h (coding, code_convert_region, encode_coding_gap):
8029 Remove decls.
74ab6df5
PE
8030 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
8031 (iso_code_class, detect_coding, code_convert_region): Now static.
8032 (encode_coding_gap): Remove; unused.
8033
38dfbee1
PE
8034 * chartab.c (chartab_chars, chartab_bits): Now static.
8035
a2cb4e63
PE
8036 * charset.h (charset_iso_8859_1): Remove decl.
8037 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
8038 Now static.
8039
127198fd
PE
8040 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
8041 * ccl.c (Vccl_program_table): Now static.
8042 (check_ccl_update): Remove; unused.
8043
d85b608f
PE
8044 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
8045 * category.h: ... from here.
8046 * category.c (check_category_table, set_category_set): Now static.
8047
31cd66f3
PE
8048 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
8049 * lisp.h: Remove these decls.
8050
c358e587
PE
8051 * buffer.c (buffer_count): Remove unused var.
8052
e78aecca
PE
8053 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
8054 so that it's not optimized away.
8055 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
8056 * dispextern.h (bidi_dump_cached_states): Remove, since it's
8057 exported only to the debugger.
8058
e192d7d3 8059 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 8060 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 8061
92470028
PE
8062 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
8063 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
8064 was inaccessible from Lisp.
8065 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
8066 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
8067
244ed907
PE
8068 alloc.c: Import and export fewer symbols, and remove unused items.
8069 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
8070 is defined.
8071 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
8072 it's not optimized away by whole-program optimization.
8073 (message_enable_multibyte, free_misc): Remove.
8074 (catchlist, handlerlist, mark_backtrace):
8075 Declare only if BYTE_MARK_STACK.
8076 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
8077 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
8078 (message_enable_multibyte): Remove decl.
8079 (free_misc, interval_free_list, float_block, float_block_index):
8080 (n_float_blocks, float_free_list, cons_block, cons_block_index):
8081 (cons_free_list, last_marked_index):
8082 Now static.
8083 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
8084 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
8085 (mark_backtrace): Define only if BYTE_MARK_STACK.
8086 * xdisp.c (message_enable_multibyte): Now static.
8087
61c2b50e 8088 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
8089 This makes it easier for human readers (and static analyzers)
8090 to see whether these variables are used from other modules.
8091 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
8092 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
8093 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
8094 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
8095 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
8096 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
8097 * xmenu.c, xselect.c:
8098 Declare Q* vars static if they are not used in other modules.
8099 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
8100 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
8101 Remove decls of unexported vars.
8102 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
8103
95c82688
PE
8104 * lisp.h (DEFINE_FUNC): Make sname 'static'.
8105
16a97296
PE
8106 Make Emacs functions such as Fatom 'static' by default.
8107 This makes it easier for human readers (and static analyzers)
8108 to see whether these functions can be called from other modules.
8109 DEFUN now defines a static function. To make the function external
8110 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
8111 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
8112 (Finit_image_library):
16a97296
PE
8113 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
8114 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
8115 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
8116 Remove decls, since these functions are now static.
8117 (Funintern, Fget_internal_run_time): New decls, since these functions
8118 were already external.
95c82688 8119
16a97296
PE
8120 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
8121 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
8122 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
8123 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
8124 * keyboard.c, keymap.c, lread.c:
8125 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
8126 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
8127 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
8128 Mark functions with DEFUE instead of DEFUN,
8129 if they are used in other modules.
8130 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
8131 decls for now-static functions.
8132 * buffer.h (Fdelete_overlay): Remove decl.
8133 * callproc.c (Fgetenv_internal): Mark as internal.
8134 * composite.c (Fremove_list_of_text_properties): Remove decl.
8135 (Fcomposition_get_gstring): New forward static decl.
8136 * composite.h (Fcomposite_get_gstring): Remove decl.
8137 * dired.c (Ffile_attributes): New forward static decl.
8138 * doc.c (Fdocumntation_property): New forward static decl.
8139 * eval.c (Ffetch_bytecode): New forward static decl.
8140 (Funintern): Remove extern decl; now in .h file where it belongs.
8141 * fileio.c (Fmake_symbolic_link): New forward static decl.
8142 * image.c (Finit_image_library): New forward static decl.
8143 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8144 * intervals.h (Fprevious_property_change):
8145 (Fremove_list_of_text_properties): Remove decls.
8146 * keyboard.c (Fthis_command_keys): Remove decl.
8147 (Fcommand_execute): New forward static decl.
8148 * keymap.c (Flookup_key): New forward static decl.
8149 (Fcopy_keymap): Now static.
8150 * keymap.h (Flookup_key): Remove decl.
8151 * process.c (Fget_process): New forward static decl.
8152 (Fprocess_datagram_address): Mark as internal.
8153 * syntax.c (Fsyntax_table_p): New forward static decl.
8154 (skip_chars): Remove duplicate decl.
8155 * textprop.c (Fprevious_property_change): New forward static decl.
8156 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8157 Now internal.
8158 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8159 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8160
785bbd42
PE
8161 * editfns.c (Fformat): Remove unreachable code.
8162
8b913b57
AS
81632011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8164
8165 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8166 change. (Bug#8496)
8167
a6744a35
EZ
81682011-04-13 Eli Zaretskii <eliz@gnu.org>
8169
8170 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8171 when at ZV. (Bug#8487)
8172
e7974947
AS
81732011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8174
baad03f0
AS
8175 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8176 (Bug#8437)
8177 * keyboard.c (parse_tool_bar_item): Likewise.
8178 * sound.c (sound_cleanup, alsa_close): Likewise.
8179 * termcap.c (tgetent): Likewise.
8180 * xfns.c (x_default_font_parameter): Likewise.
8181 * xsettings.c (read_and_apply_settings): Likewise.
8182
e7974947
AS
8183 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8184 (overrun_check_free): Protoize.
8185
28272684
PE
81862011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8187
8188 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8189 since callers should never pass a negative size.
8190 Change the signature to match that of plain 'read' and 'write'; see
8191 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8192 * lisp.h: Update prototypes of emacs_write and emacs_read.
8193
11997c76
EZ
81942011-04-11 Eli Zaretskii <eliz@gnu.org>
8195
8196 * xdisp.c (redisplay_window): Don't try to determine the character
8197 position of the scroll margin if the window start point w->startp
e896f03c 8198 is outside the buffer's accessible region. (Bug#8468)
11997c76 8199
8a2cbd72
EZ
82002011-04-10 Eli Zaretskii <eliz@gnu.org>
8201
8202 Fix write-region and its subroutines for buffers > 2GB.
8203 * fileio.c (a_write, e_write): Modify declaration of arguments and
8204 local variables to support buffers larger than 2GB.
8205 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8206
8207 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8208 argument, local variables, and return value.
8209
8210 * lisp.h: Update prototypes of emacs_write and emacs_read.
8211
8212 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8213
4073e537 82142011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 8215
1ebfdcb6
PE
8216 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8217
b2ded58d
PE
8218 Fix more problems found by GCC 4.6.0's static checks.
8219
7d66342c
PE
8220 * xdisp.c (vmessage): Use a better test for character truncation.
8221
bbf47d44
PE
8222 * charset.c (load_charset_map): <, not <=, for optimization,
8223 and to avoid potential problems with integer overflow.
9248994d 8224 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 8225 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 8226 * editfns.c (Fformat): Likewise.
1e69125e 8227 * syntax.c (skip_chars): Likewise.
3befa583 8228
e3019616
PE
8229 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8230 This also lets GCC 4.6.0 generate slightly better loop code.
8231
becfa255
PE
8232 * callint.c (Fcall_interactively): <, not <=, for optimization.
8233 (Fcall_interactively): Count the number of arguments produced,
8234 not the number of arguments given. This is simpler and lets GCC
8235 4.6.0 generate slightly better code.
8236
dae0cd48
PE
8237 * ftfont.c: Distingish more carefully between FcChar8 and char.
8238 The previous code passed unsigned char * to a functions like
8239 strlen and xstrcasecmp that expect char *, which does not
8240 conform to the C standard.
8241 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8242 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8243 char * when the C standard requires it.
8244
76032d70
PE
8245 * keyboard.c (read_char): Remove unused var.
8246
eb3f1cc8
PE
8247 * eval.c: Port to Windows vsnprintf (Bug#8435).
8248 Include <limits.h>.
8249 (SIZE_MAX): Define if the headers do not.
8250 (verror): Do not give up if vsnprintf returns a negative count.
8251 Instead, grow the buffer. This ports to Windows vsnprintf, which
8252 does not conform to C99. Problem reported by Eli Zaretskii.
8253 Also, simplify the allocation scheme, by avoiding the need for
8254 calling realloc, and removing the ALLOCATED variable.
8255
70476b54
PE
8256 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8257
12020a9e
PE
8258 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8259 But keep the doprint source code for now, as we might revamp it
8260 and use it again (Bug#8435).
ea6c7ae6
PE
8261 * lisp.h (doprnt): Remove.
8262 * Makefile.in (base_obj): Remove doprnt.o.
8263 * deps.mk (doprnt.o): Remove.
8264
5fdb398c
PE
8265 error: Print 32- and 64-bit integers portably (Bug#8435).
8266 Without this change, on typical 64-bit hosts error ("...%d...", N)
8267 was used to print both 32- and 64-bit integers N, which relied on
8268 undefined behavior.
61bdb816 8269 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
8270 * lisp.h (error, verror): Mark as printf-like functions.
8271 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8272 Report overflow in size calculations when allocating printf buffer.
8273 Do not truncate output string at its first null byte.
8274 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8275 Truncate the output at a character boundary, since vsnprintf does not
8276 do that.
8277 * charset.c (check_iso_charset_parameter): Convert internal
8278 character to string before calling 'error', since %c now has the
8279 printf meaning.
8280 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8281 overflow when computing char to be passed to 'error'. Do not
8282 pass Lisp_Object to 'error'; pass the integer instead.
8283 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8284 formatted with plain %d.
8285
b189fa66
PE
8286 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8287
bff87ef0
PE
8288 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8289
7e2cac20
PE
8290 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8291
ce4d90b5
PE
8292 * xterm.c (x_catch_errors): Remove duplicate declaration.
8293
266c9547
PE
8294 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8295
79c49ad2
PE
8296 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8297
368f4090
JM
82982011-04-10 Jim Meyering <meyering@redhat.com>
8299
8300 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8301 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8302 return ssize_t not "int", and use size_t as the buffer length.
8303 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8304 * gnutls.h: Update declarations.
8305 * process.c (read_process_output): Use ssize_t, to match.
8306 (send_process): Likewise.
8307
a32d4040
CY
83082011-04-09 Chong Yidong <cyd@stupidchicken.com>
8309
8310 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8311
8546720e 83122011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 8313
04f2d78b
CB
8314 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8315 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 8316
8546720e
GM
8317 * xterm.c (handle_one_xevent):
8318 * xmenu.c (create_and_show_popup_menu):
8319 * xselect.c (x_decline_selection_request)
8320 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 8321
0a2f5c1a 83222011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
8323
8324 Fix some uses of `int' instead of EMACS_INT.
8325 * search.c (string_match_1, fast_string_match)
8326 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8327 (scan_buffer, find_next_newline_no_quit)
8328 (find_before_next_newline, search_command, Freplace_match)
8329 (Fmatch_data): Make some `int' variables be EMACS_INT.
8330
8331 * xdisp.c (display_count_lines): 3rd argument and return value now
8332 EMACS_INT. All callers changed.
8333 (pint2hrstr): Last argument is now EMACS_INT.
8334
8335 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8336 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8337 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8338 (decode_coding_utf_16, decode_coding_emacs_mule)
8339 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8340 (decode_coding_ccl, decode_coding_charset)
8341 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8342 (decode_coding_iso_2022, decode_coding_emacs_mule)
8343 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8344 <char_offset, last_offset>: Declare EMACS_INT.
8345 (encode_coding_utf_8, encode_coding_utf_16)
8346 (encode_coding_emacs_mule, encode_invocation_designation)
8347 (encode_designation_at_bol, encode_coding_iso_2022)
8348 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8349 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8350 Declare EMACS_INT.
8351 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8352 (encode_invocation_designation): Last argument P_NCHARS is now
8353 EMACS_INT.
8354 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8355 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8356
8357 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8358 All users changed.
8359
8360 * ccl.c (Fccl_execute_on_string): Declare some variables
8361 EMACS_INT.
8362
8546720e 83632011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
8364
8365 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8366
4e19a977
CS
83672011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8368
8369 * process.c (Fformat_network_address): Doc fix.
8370
87302331
R
83712011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8372
ee7683eb 8373 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 8374
cbb59342
CY
83752011-04-08 Chong Yidong <cyd@stupidchicken.com>
8376
8377 * keyboard.c (read_char): Call Lisp function help-form-show,
8378 instead of using internal_with_output_to_temp_buffer.
8379 (Qhelp_form_show): New var.
e0d38eeb 8380 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
8381
8382 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8383
8384 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8385
e67a13ab
CY
83862011-04-06 Chong Yidong <cyd@stupidchicken.com>
8387
04f2d78b
CB
8388 * process.c (Flist_processes): Remove to Lisp.
8389 (list_processes_1): Delete.
e67a13ab 8390
973f782d
EZ
83912011-04-06 Eli Zaretskii <eliz@gnu.org>
8392
7c106b1e
EZ
8393 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8394
973f782d
EZ
8395 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8396
41cf7d1a 83972011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 8398
ca23cc88
PE
8399 Fix more problems found by GCC 4.6.0's static checks.
8400
f390e2d5
PE
8401 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8402
42eea0d0
PE
8403 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8404
b69769da 8405 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 8406
f9541e84
PE
8407 * xdisp.c (vmessage): Mark as a printf-like function.
8408
13841b55
PE
8409 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8410
c136c10f
PE
8411 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8412
5e2d4a30
PE
8413 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8414 printf-like functions.
8415 (tiff_load): Add casts to remove these marks before passing them
8416 to system-supplied API.
8417
583f48b9
PE
8418 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8419
b25d760e
PE
8420 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8421 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
8422 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8423 directly, rather than having caller test rule sign. This avoids
8424 some unnecessary tests.
8425 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8426 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8427 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 8428
bc7b6697 8429 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 8430 (xfont_open): Avoid unnecessary tests.
bc7b6697 8431
27ccc379
PE
8432 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8433
dcd5c89a
PE
8434 * composite.h, composite.c (composition_gstring_put_cache):
8435 Use EMACS_INT, not int, for length.
8436
b13a45c6
PE
8437 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8438 breaking out part of COMPOSITION_DECODE_RULE.
8439 (COMPOSITION_DECODE_RULE): Use it.
8440 * composite.c (get_composition_id): Remove unused local vars,
8441 by using the new macro.
8442
1e792e4d
PE
8443 * textprop.c (set_text_properties_1): Change while to do-while,
8444 since the condition is always true at first.
8445
dc6c6455 8446 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
8447 (interval_deletion_adjustment): Return unsigned value.
8448 All uses changed.
dc6c6455 8449
aba7731a
PE
8450 * process.c (list_processes_1, create_pty, read_process_output):
8451 (exec_sentinel): Remove vars that were set but not used.
afd4052b 8452 (create_pty): Remove unnecessary "volatile"s.
bc57d757 8453 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 8454 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 8455 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 8456
fdfc4bf3
PE
8457 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8458
fca8fe46 8459 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 8460 (update_syntax_table): Use unsigned instead of int.
fca8fe46 8461
06a0259a 8462 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 8463 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 8464 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 8465
e7b9e80f
PE
8466 * print.c (print_error_message): Avoid int overflow.
8467
56201685
PE
8468 * font.c (font_list_entities): Redo for clarity,
8469 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8470
78834453 8471 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 8472 (font_score): Avoid potential overflow in diff calculation.
78834453 8473
0bc0b309 8474 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 8475 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 8476
e610eaca
PE
8477 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8478
b895abce
PE
8479 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8480 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8481 can always succeed if overflow has undefined behavior.
8482
1f1d9321 8483 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 8484 (wordify): Omit three unnecessary tests.
1f1d9321 8485
c59478bc
PE
8486 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8487 All callers changed. This avoids the need for an unused var.
8488
79b73827
PE
8489 * casefiddle.c (casify_region): Remove var that is set but not used.
8490
a4db5dfe
PE
8491 * dired.c (file_name_completion): Remove var that is set but not used.
8492
43aae36e
PE
8493 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8494
2a47c44d 8495 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 8496 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 8497
a37c69bf
PE
8498 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8499 Check for integer overflow on size calculations.
8500
328ab8e7
PE
8501 * buffer.c (Fprevious_overlay_change): Remove var that is set
8502 but not used.
8503
e5a2a5cb
PE
8504 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8505 Remove vars that are set but not used.
8d84a6eb 8506 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 8507 (timer_check_2): Mark vars as initialized.
e5a2a5cb 8508
a60e5f68
PE
8509 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8510
f661cb61 8511 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 8512 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 8513
f0397f5a
PE
8514 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8515 that are set but not used.
8516
8664db06 8517 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 8518 if XCreateBitmapFromData fails (Bug#8410).
8664db06 8519
6abdaa4a
PE
8520 * xselect.c (x_get_local_selection, x_handle_property_notify):
8521 Remove vars that are set but not used.
8522
0ce7538d 8523 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 8524 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 8525
9ae848fc
PE
8526 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8527 Remove var that is set but not used.
0b918413
PE
8528 (scroll_bar_windows_size): Now size_t, not int.
8529 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8530 Check for overflow.
9ae848fc 8531
a5a62657
PE
8532 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8533 (map_tty_color) [!defined MSDOS]: Likewise.
8534
5c5cdd39
PE
8535 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8536
66ebf983
PE
8537 * coding.c: Remove vars that are set but not used.
8538 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8539 All callers changed.
8540 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8541 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8542 (decode_coding_charset): Remove vars that are set but not used.
8543
1be4d761
PE
8544 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8545 that is set but not used.
8546
47553fa8
PE
8547 * print.c (print_object): Remove var that is set but not used.
8548
1f7196bf 8549 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
8550 The gnulib version avoids calling malloc in the usual case,
8551 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8552 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8553 * filelock.c (current_lock_owner): Likewise.
8554 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8555 * sysdep.c: Include allocator.h, careadlinkat.h.
8556 (emacs_no_realloc_allocator): New static constant.
8557 (emacs_readlink): New function.
fdb61804
PE
8558 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8559 ../lib/careadlinkat.h.
d1fdcab7 8560
f84c17c7
SM
85612011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8562
8563 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8564 first non-nil return value).
8565
ef3862ad
JD
85662011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8567
8568 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8569 if not defined (Bug#8403).
8570
376a7006
JB
85712011-04-02 Juanma Barranquero <lekktu@gmail.com>
8572
8573 * xdisp.c (display_count_lines): Remove parameter `start',
8574 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8575 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8576 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8577 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8578 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8579 and thereabouts. All callers changed.
8580 (get_per_char_metric): Remove parameter `f', unused since
8581 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8582
6ca3801d
JM
85832011-04-02 Jim Meyering <meyering@redhat.com>
8584
8585 do not dereference NULL upon failed strdup
8586 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8587 (ns_get_family): Likewise.
8588
d8e2b5ba
JB
85892011-04-02 Juanma Barranquero <lekktu@gmail.com>
8590
8591 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8592
8c74fcbd
JD
85932011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8594
8595 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8596 later (Bug#8403).
8597
7200d79c
SM
85982011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8599
03408648 8600 Add lexical binding.
7200d79c 8601
03408648
SM
8602 * window.c (Ftemp_output_buffer_show): New fun.
8603 (Fsave_window_excursion):
8604 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8605
8606 * lread.c (lisp_file_lexically_bound_p): New function.
8607 (Fload): Bind Qlexical_binding.
8608 (readevalloop): Remove `evalfun' arg.
8609 Bind Qinternal_interpreter_environment.
8610 (Feval_buffer): Bind Qlexical_binding.
8611 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8612 Mark as dynamic.
8613 (syms_of_lread): Declare `lexical-binding'.
8614
8615 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8616
8617 * keyboard.c (eval_dyn): New fun.
8618 (menu_item_eval_property): Use it.
ca105506
SM
8619
8620 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 8621
03408648
SM
8622 * fns.c (concat, mapcar1): Accept byte-code-functions.
8623
8624 * eval.c (Fsetq): Handle lexical vars.
8625 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8626 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8627 (FletX, Flet): Obey lexical binding.
8628 (Fcommandp): Handle closures.
8629 (Feval): New `lexical' arg.
8630 (eval_sub): New function extracted from Feval. Use it almost
8631 everywhere where Feval was used. Look up vars in lexical env.
8632 Handle closures.
8633 (Ffunctionp): Move from subr.el.
8634 (Ffuncall): Handle closures.
8635 (apply_lambda): Remove `eval_flags'.
8636 (funcall_lambda): Handle closures and new byte-code-functions.
8637 (Fspecial_variable_p): New function.
8638 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8639 but without exporting it to Lisp.
23aba0ea 8640
23aba0ea 8641 * doc.c (Fdocumentation, store_function_docstring):
03408648 8642 * data.c (Finteractive_form): Handle closures.
23aba0ea 8643
03408648
SM
8644 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8645 interactive spec.
ba83908c 8646
04f2d78b
CB
8647 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8648 New byte-codes.
03408648
SM
8649 (exec_byte_code): New function extracted from Fbyte_code to handle new
8650 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 8651
03408648 8652 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 8653
03408648 8654 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 8655
e2abce01
JB
86562011-03-31 Juanma Barranquero <lekktu@gmail.com>
8657
8658 * xdisp.c (redisplay_internal): Fix prototype.
8659
63696a73 86602011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 8661
63696a73 8662 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
8663 (try_scrolling): Use it when setting scroll_limit.
8664 Limit scrolling to 100 screen lines.
63696a73
EZ
8665 (redisplay_window): Even when falling back on "recentering",
8666 position point in the window according to scroll-conservatively,
8667 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8668
8669 (try_scrolling): When point is above the window, allow searching
8670 as far as scroll_max, or one screenful, to compute vertical
8671 distance from PT to the scroll margin position. This prevents
8672 try_scrolling from unnecessarily failing when
8673 scroll-conservatively is set to a value slightly larger than the
8674 window height. Clean up the case of PT below the margin at bottom
8675 of window: scroll_max can no longer be INT_MAX. When aggressive
8676 scrolling is in use, don't let point enter the opposite scroll
8677 margin as result of the scroll.
8678 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
8679 threshold of 100 lines for never-recentering scrolling.
8680
e4cc2dfc
JB
86812011-03-31 Juanma Barranquero <lekktu@gmail.com>
8682
8683 * dispextern.h (move_it_by_lines):
8684 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8685 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8686 (message_log_check_duplicate): Remove parameters `prev_bol' and
8687 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8688 (redisplay_internal): Remove parameter `preserve_echo_area',
8689 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8690
8691 * indent.c (Fvertical_motion):
8692 * window.c (window_scroll_pixel_based, Frecenter):
8693 Don't pass `need_y_p' to `move_it_by_lines'.
8694
1c470562
SM
86952011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8696
44f230aa
SM
8697 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8698 steal a few bits to be more compact.
8699 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8700 Remove unneeded casts.
8701
1c470562
SM
8702 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8703
888adce9
ZK
87042011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8705
8706 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8707 binding" message (bug#7967).
8708
f838ed7b
PE
87092011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8710
77861b95
PE
8711 Fix more problems found by GCC 4.6.0's static checks.
8712
de6dbc14
PE
8713 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8714 Remove unused local var.
8715
f838ed7b
PE
8716 * editfns.c (Fmessage_box): Remove unused local var.
8717
792c7b2b
PE
8718 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8719 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8720 Omit unused local vars.
c499e557 8721 * window.c (shrink_windows): Omit unused local var.
b01a1c29 8722 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
8723 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8724 Omit unused local var.
8725
ba0165e1
PE
8726 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8727 Don't assume string length fits in int.
32ad8845 8728 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 8729 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 8730
3c59b4c9
PE
8731 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8732 instead of alloca (Bug#8344).
8733
a3eed478 8734 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 8735 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 8736
eb4d412d
PE
8737 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8738
1658b401
PE
8739 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8740 concerns.
8741
8742 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8743
8744 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 8745
9a2c6e05
PE
8746 * keyboard.c (syms_of_keyboard): Use the same style as later
8747 in this function when indexing through an array. This also
8748 works around GCC bug 48267.
8749
03d0a109
PE
8750 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8751
44f730c8
PE
8752 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8753
fe75f926
PE
8754 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8755 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8756
ffa8c828
PE
8757 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8758 This avoids undefined behavior on integer overflow, and is a bit
8759 more convenient anyway since it is compared to a size_t variable.
8760
c5101a77
PE
8761 Variadic C functions now count arguments with size_t, not int.
8762 This avoids an unnecessary limitation on 64-bit machines, which
8763 caused (substring ...) to crash on large vectors (Bug#8344).
8764 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8765 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 8766 All variadic functions and their callers changed accordingly.
c5101a77
PE
8767 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8768 * data.c (arith_driver, float_arith_driver): Likewise.
8769 * editfns.c (general_insert_function): Likewise.
8770 * eval.c (struct backtrace.nargs, interactive_p)
8771 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8772 (funcall_lambda, mark_backtrace): Likewise.
8773 * fns.c (concat): Likewise.
8774 * frame.c (x_set_frame_parameters): Likewise.
8775 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8776 0 if not found, not -1. All callers changed.
8777
dd3f25f7
PE
8778 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8779 (stack_copy_size): Now size_t, not int.
8780 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8781
461c2ab9
JB
87822011-03-28 Juanma Barranquero <lekktu@gmail.com>
8783
8784 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8785 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8786 All callers changed.
8787
8788 * lisp.h (multibyte_char_to_unibyte):
8789 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8790 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8791 * character.h (CHAR_TO_BYTE8):
8792 * cmds.c (internal_self_insert):
8793 * editfns.c (general_insert_function):
8794 * keymap.c (push_key_description):
8795 * search.c (Freplace_match):
8796 * xdisp.c (message_dolog, set_message_1): All callers changed.
8797
f6d62986
SM
87982011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8799
8800 * keyboard.c (safe_run_hook_funcall): New function.
8801 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8802 don't set the hook to nil, but remove the offending function instead.
8803 (Qcommand_hook_internal): Remove, unused.
8804 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8805 Vcommand_hook_internal.
8806
8807 * eval.c (enum run_hooks_condition): Remove.
8808 (funcall_nil, funcall_not): New functions.
8809 (run_hook_with_args): Call each function through a `funcall' argument.
8810 Remove `cond' argument, now redundant.
8811 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8812 (Frun_hook_with_args_until_failure): Adjust accordingly.
8813 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8814
1db5b1ad
JB
88152011-03-28 Juanma Barranquero <lekktu@gmail.com>
8816
8817 * dispextern.h (string_buffer_position): Remove declaration.
8818
8819 * print.c (strout): Remove parameter `multibyte', unused since
8820 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8821
8822 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8823 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8824 All callers changed.
8825
8826 * w32.c (_wsa_errlist): Use braces for struct initializers.
8827
8828 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8829 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8830 All callers changed.
8831 (string_buffer_position): Likewise. Also, make static (it's never
8832 used outside xdisp.c).
8833 (cursor_row_p): Remove parameter `w', unused since
8834 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8835 (decode_mode_spec): Remove parameter `precision', introduced during
8836 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8837 All callers changed.
8838
5ffb62aa
JD
88392011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8840
8841 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8842
461c2ab9 88432011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
8844
8845 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8846 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8847 (ns_update_auto_hide_menu_bar): New functions.
8848 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8849 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8850 ns_constrain_all_frames.
8851 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8852 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8853
5c380ffb
JD
88542011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8855
8856 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8857
9af30bdf
GM
88582011-03-27 Glenn Morris <rgm@gnu.org>
8859
8860 * syssignal.h: Replace RETSIGTYPE with void.
8861 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8862 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8863 Replace SIGTYPE with void everywhere.
8864 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8865 * s/template.h (SIGTYPE): Remove commented out definition.
8866
e2abce01
JB
88672011-03-26 Eli Zaretskii <eliz@gnu.org>
8868
8869 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8870 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8871
f868cd8a
JB
88722011-03-26 Juanma Barranquero <lekktu@gmail.com>
8873
59eb0929
JB
8874 * w32.c (read_unc_volume): Use parameter `henum', instead of
8875 global variable `wget_enum_handle'.
8876
8877 * keymap.c (describe_vector): Remove parameters `indices' and
8878 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8879 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8880
f868cd8a
JB
8881 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8882
8883 * keyboard.c (timer_check): Remove parameter `do_it_now',
8884 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8885 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8886 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8887
8888 * keyboard.c (read_char):
8889 * w32menu.c (w32_menu_display_help):
8890 * xmenu.c (show_help_event, menu_help_callback):
8891 Adjust calls to `show_help_echo'.
8892
8893 * gtkutil.c (xg_maybe_add_timer):
8894 * keyboard.c (readable_events):
8895 * process.c (wait_reading_process_output):
8896 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8897
8898 * insdel.c (adjust_markers_gap_motion):
8899 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8900 (gap_left, gap_right): Don't call it.
8901
2ecf6fdb
CY
89022011-03-25 Chong Yidong <cyd@stupidchicken.com>
8903
8904 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8905 incurred during fontification.
8906
6b1f9ba4
JB
89072011-03-25 Juanma Barranquero <lekktu@gmail.com>
8908
8909 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8910 (DEFVAR_PER_BUFFER): Don't pass it.
8911
8912 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8913 (scrolling_window): Don't pass it.
8914
0f4a96b5
JB
89152011-03-25 Juanma Barranquero <lekktu@gmail.com>
8916
8917 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8918
8919 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8920 and `suffix'.
8921 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8922 of variables specific to SELinux and computation of `encoded_absname'.
8923
8924 * image.c (XPutPixel): Remove unused variable `height'.
8925
8926 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8927
8928 * unexw32.c (get_section_info): Remove unused variable `section'.
8929
8930 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8931 (system_process_attributes): Remove unused variable `sess'.
8932 (sys_read): Remove unused variable `err'.
8933
8934 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8935 (w32_wnd_proc): Remove unused variable `isdead'.
8936 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8937 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8938 (x_create_tip_frame): Remove unused variable `tem'.
8939
8940 * w32inevt.c (w32_console_read_socket):
8941 Remove unused variable `no_events'.
8942
8943 * w32term.c (x_draw_composite_glyph_string_foreground):
8944 Remove unused variable `width'.
8945
1149507c
JB
89462011-03-24 Juanma Barranquero <lekktu@gmail.com>
8947
8948 * w32term.c (x_set_glyph_string_clipping):
8949 Don't pass uninitialized region to CombineRgn.
8950
9c88f339
JB
89512011-03-23 Juanma Barranquero <lekktu@gmail.com>
8952
8953 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8954 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8955 (Fx_close_connection): Remove unused variable `i'.
8956
8957 * w32font.c (w32font_draw): Return number of glyphs.
8958 (w32font_open_internal): Remove unused variable `i'.
8959 (w32font_driver): Add missing initializer.
8960
8961 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8962 (fill_in_menu): Remove unused variable `items_added'.
8963
8964 * w32term.c (last_mouse_press_frame): Remove static global variable.
8965 (w32_clip_to_row): Remove unused variable `f'.
8966 (x_delete_terminal): Remove unused variable `i'.
8967
8968 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8969 (NOTHING): Remove unused static global variable.
8970 (uniscribe_check_otf): Remove unused variable `table'.
8971 (uniscribe_font_driver): Add missing initializers.
8972
dee091a3
JD
89732011-03-23 Julien Danjou <julien@danjou.info>
8974
8975 * term.c (Fsuspend_tty, Fresume_tty):
8976 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8977 * window.c (temp_output_buffer_show):
8978 * insdel.c (signal_before_change):
8979 * frame.c (Fhandle_switch_frame):
8980 * fileio.c (Fdo_auto_save):
8981 * emacs.c (Fkill_emacs):
8982 * editfns.c (save_excursion_restore):
8983 * cmds.c (internal_self_insert):
8984 * callint.c (Fcall_interactively):
8985 * buffer.c (Fkill_all_local_variables):
8986 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8987 Use Frun_hooks.
0f4a96b5 8988 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 8989 unconditionally since it does the check itself.
dee091a3 8990
2c520ab5 89912011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 8992
c9c49752
PE
8993 Fix more problems found by GCC 4.5.2's static checks.
8994
8abc3f12
PE
8995 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8996 the first time through the loop, since we know p0 < p1 then.
8997 This also avoids a gcc -Wstrict-overflow warning.
8998
a2d26660
PE
8999 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
9000 leading to a memory leak, possible in functions like
9001 load_charset_map_from_file that can allocate an unbounded number
b12ef411 9002 of objects (Bug#8318).
a2d26660 9003
916c72e9
PE
9004 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
9005 that could (at least in theory) be that large.
9006
19ab8a18
PE
9007 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
9008 This is less likely to overflow, and avoids undefined behavior if
9009 overflow does occur. All callers changed. Use strtoul to scan
9010 for the unsigned long integer.
b7cbbd6f
PE
9011 (pint2hrstr): Simplify and tune code slightly.
9012 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 9013
f0641eff
PE
9014 * scroll.c (do_scrolling): Work around GCC bug 48228.
9015 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
9016
7f650bb9
PE
9017 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
9018 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
9019 (validate_x_resource_name): Simplify count usage.
9020 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 9021
37dd57d1
PE
9022 * fileio.c (Fcopy_file): Report error if fchown or fchmod
9023 fail (Bug#8306).
81e56e61 9024
699979fc 9025 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 9026
401bf9b4
PE
9027 * process.c (Fmake_network_process): Use socklen_t, not int,
9028 where POSIX says socklen_t is required in portable programs.
9029 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 9030 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
9031 (Fmake_network_process, server_accept_connection):
9032 (wait_reading_process_output, read_process_output):
9033 Likewise.
9034
b93aacde
PE
9035 * process.c: Rename or move locals to avoid shadowing.
9036 (list_processes_1, Fmake_network_process):
9037 (read_process_output_error_handler, exec_sentinel_error_handler):
9038 Rename or move locals.
4dc343ee 9039 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 9040 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 9041 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 9042 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 9043 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 9044
af8a867c 9045 Make tparam.h and terminfo.c consistent.
44f230aa
SM
9046 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
9047 Include tparam.h instead, since it declares them.
af8a867c
PE
9048 * cm.h (PC): Remove extern decl; tparam.h now does this.
9049 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
9050 * terminfo.c: Include tparam.h, to check interfaces.
9051 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
9052 (tparam): Adjust signature to match interface in tparam.h;
9053 this removes some undefined behavior. Check that outstring and len
9054 are zero, which they always are with Emacs.
9055 * tparam.h (PC, BC, UP): New extern decls.
9056
0248044d 9057 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 9058 (xftfont_open): Rename locals to avoid shadowing.
0248044d 9059
8ff096c1 9060 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
9061 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
9062 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 9063 (ftfont_list): Remove unused local.
49eaafba
PE
9064 (get_adstyle_property, ftfont_pattern_entity):
9065 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
9066 Rename locals to avoid shadowing.
8ff096c1 9067
e2be39f6
PE
9068 * xfont.c (xfont_list_family): Mark var as initialized.
9069
c9735e30
PE
9070 * xml.c (make_dom): Now static.
9071
8f5201ae
PE
9072 * composite.c (composition_compute_stop_pos): Rename local to
9073 avoid shadowing.
b246f932
PE
9074 (composition_reseat_it): Remove unused locals.
9075 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 9076 (composition_update_it): Mark var as initialized.
11b61122
PE
9077 (find_automatic_composition): Mark vars as initialized,
9078 with a FIXME (Bug#8290).
8f5201ae 9079
760fbc2c
PE
9080 character.h: Rename locals to avoid shadowing.
9081 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
9082 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
9083 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
9084 (BUF_DEC_POS): Be more systematic about renaming local temporaries
9085 to avoid shadowing.
9086
ff08eb85
PE
9087 * textprop.c (property_change_between_p): Remove; unused.
9088
fc7bf025
PE
9089 * intervals.c (interval_start_pos): Now static.
9090
235d7abc
PE
9091 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
9092
44f230aa
SM
9093 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
9094 Rename locals to avoid shadowing.
3e7d6594 9095
50060332
PE
9096 * sound.c (wav_play, au_play, Fplay_sound_internal):
9097 Fix pointer signedness.
d01f234b 9098 (alsa_choose_format): Remove unused local var.
c83b8872
PE
9099 (wav_play): Initialize a variable to 0, to prevent undefined
9100 behavior (Bug#8278).
50060332 9101
c4fc4e30
PE
9102 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
9103
918436ed
PE
9104 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
9105
c939f91b
PE
9106 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
9107 clobbering (Bug#8298).
b9c7f648
PE
9108 * sysdep.c (sys_subshell): Likewise.
9109 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 9110
6bd8c144
PE
9111 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
9112 This should get cleaned up, so that child_setup has the
9113 same signature on all platforms.
9114
7710357c 9115 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 9116 (relocate_fd): Rename locals to avoid shadowing.
7710357c 9117
c59da222
CY
91182011-03-22 Chong Yidong <cyd@stupidchicken.com>
9119
9120 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
9121 not to be necessary, and produces flickering.
9122
66b87493
GM
91232011-03-20 Glenn Morris <rgm@gnu.org>
9124
9125 * config.in: Remove file.
9126
45b6f6d5
JB
91272011-03-20 Juanma Barranquero <lekktu@gmail.com>
9128
9129 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
9130 are now in src/globals.h.
9131 (syms_of_minibuf): Remove spurious & from previous change.
9132
cd394be1 91332011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
9134
9135 * minibuf.c (completing-read-function): New variable.
9136 (completing-read-default): Rename from completing-read.
9137 (completing-read): Call completing-read-function.
9138
b14e3e21
CY
91392011-03-19 Juanma Barranquero <lekktu@gmail.com>
9140
9141 * xfaces.c (Fx_load_color_file):
9142 Read color file from absolute filename (bug#8250).
9143
f2b726e6
JB
91442011-03-19 Juanma Barranquero <lekktu@gmail.com>
9145
9146 * makefile.w32-in: Update dependencies.
9147
09f6ff02
EZ
91482011-03-17 Eli Zaretskii <eliz@gnu.org>
9149
9150 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9151
29a6015a
PE
91522011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9153
a3a6c54e
PE
9154 Fix more problems found by GCC 4.5.2's static checks.
9155
b766f867
PE
9156 * process.c (make_serial_process_unwind, send_process_trap):
9157 (sigchld_handler): Now static.
9158
be02381c
PE
9159 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9160 That way, the code declares only the vars that it needs.
9161 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9162 * s/cygwin.h (PTY_ITERATION): Likewise.
9163 * s/darwin.h (PTY_ITERATION): Likewise.
9164 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9165
57048744
PE
9166 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9167 * process.c (allocate_pty): Don't declare stb unless it's needed.
9168
7914961c 9169 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
9170 (CONSTANTLIM): Remove; unused.
9171 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9172 Define only if needed.
7914961c 9173
b3967b18
PE
9174 * unexelf.c (unexec): Name an expression,
9175 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
9176 Use a different way to cause a compilation error if anyone uses
9177 n rather than nn, a way that does not involve shadowing.
73366a00 9178 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 9179
29a6015a
PE
9180 * deps.mk (unexalpha.o): Remove; unused.
9181
43cfc33e 9182 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 9183 * unexec.h: New file.
ce701a33
PE
9184 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9185 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9186 Depend on unexec.h.
9187 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9188 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9189 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 9190 Change as necessary to match prototype in unexec.h.
ce701a33 9191
01f44d5a
PE
9192 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9193 shadowing.
4f63c6bb 9194 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 9195
a6670b0b
PE
9196 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9197 Rename locals to avoid shadowing.
9198
cef2010d 9199 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 9200 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 9201
d4d7173a
PE
9202 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9203
f08b802a
PE
9204 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9205 warning when compiling print.c.
9206
3ddb0639
PE
9207 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9208 instead of using an uninitialized var.
5ad03b97 9209 (font_sort_entities): Mark var as initialized.
3ddb0639 9210
170a2692
PE
9211 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9212
e663c700
PE
9213 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9214 pointers to constants.
89bc529a 9215 (font_parse_fcname): Remove unused vars.
7b81e2d0 9216 (font_delete_unmatched): Now static.
ea838e10 9217 (font_get_spec): Remove; unused.
13a547c6
PE
9218 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9219 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9220 Rename or move locals to avoid shadowing.
e663c700 9221
2a80c887 9222 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 9223 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 9224
1384fa33 9225 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 9226 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 9227
8b2c52e9
PE
9228 * alloc.c (mark_backtrace): Move decl from here ...
9229 * lisp.h: ... to here, so that it can be checked.
9230
475545b5 9231 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 9232 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
9233 (lisp_indirect_variable): Name an expression,
9234 to avoid gcc -Wbad-function-cast warning.
1faed8ae 9235 (Fdefvar): Rename locals to avoid shadowing.
475545b5 9236
b1349114 9237 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 9238 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 9239 Use const pointer when appropriate.
b1349114 9240
a2928364
PE
9241 * lisp.h (get_system_name, get_operating_system_release):
9242 Move decls here, to check interfaces.
9243 * process.c (get_operating_system_release): Move decl to lisp.h.
9244 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
9245 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9246 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9247 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
9248 (Fformat_time_string, Fencode_time, Finsert_char):
9249 (Ftranslate_region_internal, Fformat):
9250 Rename or remove local vars to avoid shadowing.
9710023e 9251 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 9252
a415e694
PE
9253 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9254 avoid shadowing.
9255
8ef4622d
PE
9256 * lisp.h (eassert): Check that the argument compiles, even if
9257 ENABLE_CHECKING is not defined.
9258
946f9a5b
PE
9259 * data.c (Findirect_variable): Name an expression, to avoid
9260 gcc -Wbad-function-cast warning.
112396d6 9261 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 9262 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
9263 (Fmake_variable_buffer_local, Fmake_local_variable):
9264 Mark variables as initialized.
52746918 9265 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 9266
e5aab7e7 9267 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
9268 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9269 Rename locals to avoid shadowing.
dff45157
PE
9270 (mark_stack): Move local variables into the #ifdef region where
9271 they're used.
7bc26fdb
PE
9272 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9273 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9274 needed otherwise.
9275 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9276 (GC_STRING_CHARS): Remove; not used.
d40d4be1 9277 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 9278
e5aab7e7
PE
9279 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9280 avoids undefined behavior in theory.
9281
4da60324
PE
9282 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9283
88043301
PE
9284 Use functions, not macros, for up- and down-casing (Bug#8254).
9285 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9286 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9287 to use the following functions instead of these macros.
9288 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9289 EMACS_INT, since callers assume the returned value fits in int.
9290 (upcase1): Likewise, for UPCASE_TABLE.
9291 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 9292 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 9293 the race-condition problem in the old DOWNCASE.
88043301 9294
19ed5445
PE
9295 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9296 Rename locals to avoid shadowing.
9297 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
9298 (regex_compile, re_search_2, re_match_2_internal):
9299 Remove unused local vars.
952db0d7
PE
9300 (FREE_VAR): Rewrite so as not to use empty "else",
9301 which gcc can warn about.
da053e48 9302 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
9303 (RETALLOC_IF): Define only if needed.
9304 (WORDCHAR_P): Likewise. This one is never needed, but is used
9305 only in a comment talking about a compiler bug, so put inside
9306 the #if 0 of that comment.
9307 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9308 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9309 Remove; unused.
19ed5445 9310
1f3561e4 9311 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
9312 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9313 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 9314
ded6f8f7
PE
9315 * search.c (simple_search): Remove unused var.
9316
dbd37a95
PE
9317 * dired.c (compile_pattern): Move decl from here ...
9318 * lisp.h: ... to here, so that it can be checked.
9319 (struct re_registers): New forward decl.
9320
7e47afad
PE
9321 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9322
85f24f61
PE
9323 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9324 All uses changed.
9325 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9326 Rename locals to avoid shadowing.
5671df8f 9327 (Fvertical_motion): Mark locals as initialized.
85f24f61 9328
181aa2be 9329 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 9330 (casify_region): Mark local as initialized.
181aa2be 9331
930d429c
PE
9332 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9333
7082eac6
PE
9334 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9335 New macros, so that the caller can use some names other than
9336 gcpro1, gcpro2, etc.
9337 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9338 of the new macros.
9339 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9340 argument, for consistency with GCPRO2_VAR, etc: it is now the
9341 prefix of the variable, not the variable itself. All uses
9342 changed.
38b2c076
PE
9343 * dired.c (directory_files_internal, file_name_completion):
9344 Rename locals to avoid shadowing.
9345
15206ed9
PE
9346 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9347 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9348 dired.c's scmp function, had undefined behavior.
9349 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9350 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9351 * buffer.h: ... to here, because these macros use current_buffer,
9352 and the new implementation with inline functions needs to have
9353 current_buffer in scope now, rather than later when the macros
9354 are used.
9355 (downcase, upcase1): New static inline functions.
9356 (DOWNCASE, UPCASE1): Reimplement using these functions.
9357 This avoids undefined behavior in expressions like
9358 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9359 from race conditions in accessing the global variables
9360 case_temp1 and case_temp2.
9361 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9362 * lisp.h (case_temp1, case_temp2): Remove their decls.
9363 * character.h (ASCII_CHAR_P): Move from here ...
9364 * lisp.h: ... to here, so that the inline functions mentioned
9365 above can use them.
9366
4a6bea26
PE
9367 * dired.c (directory_files_internal_unwind): Now static.
9368
f14b7e14
PE
9369 * fileio.c (file_name_as_directory, directory_file_name):
9370 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9371 Now static.
2893f146
PE
9372 (file_name_as_directory): Use const pointers when appropriate.
9373 (Fexpand_file_name): Likewise. In particular, newdir might
9374 point at constant storage, so make it a const pointer.
fd4ead52 9375 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
9376 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9377 signedness issues.
f839df0c
PE
9378 (Fset_file_times, Finsert_file_contents, auto_save_error):
9379 Rename locals to avoid shadowing.
f14b7e14 9380
5716756e 9381 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
9382 (Ftry_completion, Fall_completions): Rename or remove locals
9383 to avoid shadowing.
5716756e 9384
b4c3046a
PE
9385 * marker.c (bytepos_to_charpos): Remove; unused.
9386
b45db522
PE
9387 * lisp.h (verify_bytepos, count_markers): New decls,
9388 so that gcc does not warn that these functions aren't declared.
9389
85876d07
PE
9390 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9391 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 9392 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 9393 (copy_text): Remove unused local var.
85876d07 9394
03d78a21 9395 * filelock.c (within_one_second): Now static.
b3dd38ab 9396 (lock_file_1): Rename local to avoid shadowing.
03d78a21 9397
5df8f01b
PE
9398 * buffer.c (fix_overlays_before): Mark locals as initialized.
9399 (fix_start_end_in_overlays): Likewise. This function should be
9400 simplified by using pointers-to-pointers, but that's a different
9401 matter.
b1d876f1 9402 (switch_to_buffer_1): Now static.
8f54f30a
PE
9403 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9404 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 9405
a70072c9 9406 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 9407 Fix pointer signedness issue.
edced198
PE
9408 (sys_subshell): Mark local as volatile if checking for lint,
9409 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 9410 (MAXPATHLEN): Define only if needed.
a70072c9 9411
a0977c44
PE
9412 * process.c (serial_open, serial_configure): Move decls from here ...
9413 * systty.h: ... to here, so that they can be checked.
9414
a884fdcc
PE
9415 * fns.c (get_random, seed_random): Move extern decls from here ...
9416 * lisp.h: ... to here, so that they can be checked.
9417
604efe86 9418 * sysdep.c (reset_io): Now static.
b8950c94 9419 (wait_for_termination_signal): Remove; unused.
604efe86 9420
38fc62d9
PE
9421 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9422 (copy_keymap_item, append_key, push_text_char_description):
9423 Now static.
1004a21a 9424 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 9425 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
9426 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9427 (describe_map_tree):
9428 Rename locals to avoid shadowing.
38fc62d9 9429
2f2650da
PE
9430 * keyboard.c: Declare functions static if they are not used elsewhere.
9431 (echo_char, echo_dash, cmd_error, top_level_2):
9432 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
9433 (read_char, kbd_buffer_get_event, make_lispy_position):
9434 (make_lispy_event, make_lispy_movement, apply_modifiers):
9435 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9436 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9437 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 9438 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 9439 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 9440
a053e86c 9441 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
9442 (mark_kboards): Move decl here ...
9443 * alloc.c (mark_kboards): ... from here.
a053e86c 9444
4752793e
PE
9445 * lisp.h (force_auto_save_soon): New decl.
9446
74f10ca7 9447 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
9448 (DEFINE_DUMMY_FUNCTION): New macro.
9449 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9450 Use it.
c03cd23f
PE
9451 (main): Add casts to avoid warnings
9452 if GCC considers string literals to be constants.
74f10ca7 9453
022e70d4
PE
9454 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9455
59d6fe83
PE
9456 * dbusbind.c: Pointer signedness fixes.
9457 (xd_signature, xd_append_arg, xd_initialize):
9458 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9459 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9460 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9461 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9462
78320123
PE
9463 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9464 if GCC considers string literals to be constants.
49cebcca 9465 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 9466
35ac2a97
SM
94672011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9468
fb103ca9
SM
9469 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9470 (print_preprocess, print_object): New macro to fix last change.
9471
35ac2a97
SM
9472 * print.c (print_preprocess): Don't forget font objects.
9473
62973b41
JB
94742011-03-16 Juanma Barranquero <lekktu@gmail.com>
9475
9476 * emacs.c (USAGE3): Doc fixes.
9477
0e48bb22
AS
94782011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9479
9480 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9481 structure.
9482
7684e57b
JB
94832011-03-14 Juanma Barranquero <lekktu@gmail.com>
9484
9485 * lisp.h (VWindow_system, Qfile_name_history):
9486 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9487 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9488 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9489
9490 * w32select.c: Don't #include "keyboard.h".
c96bbc66 9491 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
9492
9493 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9494 * w32console.c (detect_input_pending, read_input_pending)
9495 (encode_terminal_code):
9496 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9497 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9498 (w32_system_caret_y, Qfile_name_history):
9499 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9500 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9501 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9502 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9503 * w32proc.c (Qlocal, report_file_error):
9504 * w32term.c (Vwindow_system, updating_frame):
9505 * w32uniscribe.c (initialized, uniscribe_font_driver):
9506 Remove unneeded extern declarations.
9507
2aa46d6c
CY
95082011-03-14 Chong Yidong <cyd@stupidchicken.com>
9509
c96bbc66 9510 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 9511
cffc6f3b
CY
95122011-03-13 Chong Yidong <cyd@stupidchicken.com>
9513
9514 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9515 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9516 These macros can no longer be used for assignment.
9517
44f230aa
SM
9518 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9519 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
9520 (record_buffer_markers, fetch_buffer_markers): New functions for
9521 recording and fetching special buffer markers.
9522 (set_buffer_internal_1, set_buffer_temp): Use them.
9523
9524 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9525
9526 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9527
9528 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9529 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9530
9531 * xdisp.c (hscroll_window_tree):
9532 (reconsider_clip_changes): Use PT instead of BUF_PT.
9533
d251f04b
EZ
95342011-03-13 Eli Zaretskii <eliz@gnu.org>
9535
9536 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9537 $(EMACS_ROOT)/lib/intprops.h.
9538
f0c77cd1
PE
95392011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9540
3eca4629
PE
9541 Fix more problems found by GCC 4.5.2's static checks.
9542
7c86ee98
PE
9543 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9544 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
9545 (xg_free_frame_widgets): Make it clear that a local variable is
9546 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
9547 (gdk_window_get_screen): Make it clear that this macro is needed
9548 only if USE_GTK_TOOLTIP.
1e5524e7
PE
9549 (int_gtk_range_get_value): New function, which avoids a diagnostic
9550 from gcc -Wbad-function-cast.
9551 (xg_set_toolkit_scroll_bar_thumb): Use it.
9552 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9553 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
9554 (get_utf8_string, xg_get_file_with_chooser):
9555 Rename locals to avoid shadowing.
9556 (create_dialog): Move locals to avoid shadowing.
7c86ee98 9557
41729b81
PE
9558 * xgselect.c (xg_select): Remove unused var.
9559
f0c77cd1
PE
9560 * image.c (four_corners_best): Mark locals as initialized.
9561 (gif_load): Initialize transparent_p to zero (Bug#8238).
9562 Mark another local as initialized.
ec6cf4c6 9563 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 9564
ce0ad53d 9565 * image.c (clear_image_cache): Now static.
d5d5a617 9566 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 9567 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
9568 (x_edge_detection): Remove unnecessary cast that
9569 gcc -Wbad-function-cast diagnoses.
2037898d 9570 (gif_load): Fix pointer signedness.
6ae141d6
PE
9571 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9572 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 9573
33383987 95742011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 9575
d32df629
PE
9576 Improve quality of tests for time stamp overflow.
9577 For example, without this patch (encode-time 0 0 0 1 1
9578 1152921504606846976) returns the obviously-bogus value (-948597
9579 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9580 reports time overflow. See
9581 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
9582 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9583 * editfns.c: Include limits.h and intprops.h.
9584 (TIME_T_MIN, TIME_T_MAX): New macros.
9585 (time_overflow): Move earlier, to before first use.
9586 (hi_time, lo_time): New functions, for an accurate test for
9587 out-of-range times.
9588 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9589 (Fget_internal_run_time): Don't assume time_t fits in int.
9590 (make_time): Use list2 instead of Fcons twice.
9591 (Fdecode_time): More accurate test for out-of-range times.
9592 (check_tm_member): New function.
9593 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
9594 (lisp_time_argument): Don't rely on undefined left-shift and
9595 right-shift behavior when checking for time stamp overflow.
8be6f318 9596
fe31d94c
PE
9597 * editfns.c (time_overflow): New function, refactoring common code.
9598 (Fformat_time_string, Fdecode_time, Fencode_time):
9599 (Fcurrent_time_string): Use it.
9600
8be6f318
PE
9601 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9602 * dired.c (make_time): Move to ...
9603 * editfns.c (make_time): ... here.
9604 * systime.h: Note the move.
9605
09d9db2c 96062011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 9607
126bc0dc
YM
9608 * fringe.c (update_window_fringes): Remove unused variables.
9609
c47cbdfd
YM
9610 * unexmacosx.c (copy_data_segment): Also copy __got section.
9611 (Bug#8223)
9612
7ac80be9
EZ
96132011-03-12 Eli Zaretskii <eliz@gnu.org>
9614
c96bbc66 9615 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
9616 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9617 Constify `char *' arguments and their references according to
9618 prototypes in tparam.h.
9619
ecb0f94d 9620 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 9621
7ac80be9
EZ
9622 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9623 Adapt all references accordingly.
9624
9625 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9626
ef1fd07e
TT
96272011-03-11 Tom Tromey <tromey@redhat.com>
9628
9629 * buffer.c (syms_of_buffer): Remove obsolete comment.
9630
7ef4b50c
EZ
96312011-03-11 Eli Zaretskii <eliz@gnu.org>
9632
9633 * termhooks.h (encode_terminal_code): Declare prototype.
9634
9635 * msdos.c (encode_terminal_code): Don't declare prototype.
9636
9637 * term.c (encode_terminal_code): Now external again, used by
9638 w32console.c and msdos.c.
9639
44f230aa
SM
9640 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9641 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 9642
4b1ec863 96432011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 9644
1714f52b 9645 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 9646
4b1ec863
PE
9647 * fringe.c (update_window_fringes): Mark locals as initialized
9648 (Bug#8227).
9649 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 9650
524c7aa6
PE
9651 * alloc.c (mark_fringe_data): Move decl from here ...
9652 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9653 to check its interface.
9654 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9655
a5c0af81 9656 * fontset.c (free_realized_fontset): Now static.
7519b8cd 9657 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 9658 (fontset_font): Mark local as initialized.
a9a06e0b 9659 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 9660
b4716021
PE
9661 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9662
811e9bac 9663 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 9664 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
9665 (x_own_selection, Fx_disown_selection_internal): Rename locals
9666 to avoid shadowing.
9667 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 9668
7e3ab302
PE
9669 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9670 so that the caller can use some name other than gcpro1.
9671 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
9672 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9673 (Fx_backspace_delete_keys_p):
9674 Use them to avoid shadowing, and rename vars to avoid shadowing.
9675 (x_decode_color, x_set_name, x_window): Now static.
6b437900 9676 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 9677 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
9678 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9679 Remove unused locals.
7e3ab302
PE
9680 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9681 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9682 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9683 macros.
f78faa98 9684
e2b13473
PE
9685 * xterm.h (x_mouse_leave): New decl.
9686
77f23912
PE
9687 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9688 Remove unused functions.
cdf4ba58
PE
9689 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9690 (x_calc_absolute_position): Now static.
7411c686 9691 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 9692 Don't declare local "event" unless it's used.
ed7bf3a5
PE
9693 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9694 unless they are used.
38d0b34a
PE
9695 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9696 (x_fatal_error_signal): Remove; not used.
a6067996
PE
9697 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9698 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9699 (x_error_catcher, x_connection_closed, x_error_handler):
9700 (x_error_quitter, xembed_send_message, x_iconify_frame):
9701 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 9702 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 9703 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 9704
44f230aa
SM
9705 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9706 Rename or move locals to avoid shadowing.
6b463e58 9707 (tty_defined_color, merge_face_heights): Now static.
5967d051 9708 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
9709 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9710 does not deduce is never used uninitialized.
73719eba
PE
9711 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9712 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 9713
426994c3 9714 * terminal.c (store_terminal_param): Now static.
5489860b 9715
032f1620 9716 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 9717 (set_frame_menubar): Remove unused local.
d4323972 9718 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
9719 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9720 since they might point to immutable storage.
281585b0
PE
9721 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9722 since it's unused otherwise.
032f1620 9723
367c19e5 9724 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 9725 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
9726 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9727 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 9728 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
9729 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9730 does not deduce are never used uninitialized.
70739cbe 9731
07b48fa9
PE
9732 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9733
8868a238 9734 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
9735 * window.c (window_loop, size_window):
9736 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 9737
7e5cf297 9738 * window.c (display_buffer): Now static.
d6550a9f
PE
9739 (size_window): Mark variables that gcc -Wuninitialized
9740 does not deduce are never used uninitialized.
a586633d
PE
9741 * window.h (check_all_windows): New decl, to forestall
9742 gcc -Wmissing-prototypes diagnostic.
5b555da1 9743 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 9744
f6095868
PE
9745 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9746 shadowing.
9747 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
9748 Include <limits.h>.
9749 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9750 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
9751 (load_charset_map): Mark variables that gcc -Wuninitialized
9752 does not deduce are never used uninitialized.
53df7c11 9753 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 9754
f38b440c
PE
9755 * coding.c (coding_set_source, coding_set_destination):
9756 Use "else { /* comment */ }" rather than "else /* comment */;"
9757 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
9758 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9759 a block, when the outer 'i' will do.
9760 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9761 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9762 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9763 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9764 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9765 Rename locals to avoid shadowing.
9766 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
9767 * coding.c (emacs_mule_char, encode_invocation_designation):
9768 Now static, since they're not used elsewhere.
413bb2db 9769 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 9770 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
9771 (decode_coding_emacs_mule): Mark variables that gcc
9772 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
9773 (detect_coding_iso_2022): Initialize a local variable that might
9774 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 9775 this initialization is needed. (Bug#8211)
5f58e762
PE
9776 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9777 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9778 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9779 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9780 Remove unused macros.
f38b440c 9781
232b38b9 9782 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 9783 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 9784 * character.c (string_count_byte8): Likewise.
232b38b9 9785
fb90da1b
PE
9786 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9787 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9788
fb93dbc2
PE
9789 * chartab.c (copy_sub_char_table): Now static, since it's not used
9790 elsewhere.
5c156ace
PE
9791 (sub_char_table_ref_and_range, char_table_ref_and_range):
9792 Rename locals to avoid shadowing.
bbcd0949 9793 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 9794
7d3b3862 9795 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 9796 (BIDI_BOB): Remove unused macro.
7d3b3862 9797
6be7d3da
PE
9798 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9799 deduce are never used uninitialized.
c2ed9c8b 9800 * term.c (encode_terminal_code): Likewise.
6be7d3da 9801
75f8807f 9802 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 9803
50938595
PE
9804 * tparam.h: New file.
9805 * term.c, tparam.h: Include it.
9806 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9807 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9808 Move these decls to tparam.h, and make them agree with what
9809 is actually in tparam.c. The previous trick of using incompatible
9810 decls in different modules does not conform to the C standard.
9811 All callers of tparam changed to use tparam's actual API.
9812 * tparam.c (tparam1, tparam, tgoto):
9813 Use const pointers where appropriate.
9814
fbceeba2
PE
9815 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9816 * cm.h (struct cm): Likewise.
9817 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9818 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9819 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9820 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9821 (turn_on_face, init_tty): Likewise.
9822 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 9823
7f3f1250
PE
9824 * term.c (term_mouse_position): Rename local to avoid shadowing.
9825
e6ca6543
PE
9826 * alloc.c (mark_ttys): Move decl from here ...
9827 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9828
c40f8d15
AS
98292011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9830
9831 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9832
cfe0661d
JB
98332011-03-09 Juanma Barranquero <lekktu@gmail.com>
9834
9835 * search.c (compile_pattern_1): Remove argument regp, unused since
9836 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9837 (compile_pattern): Don't pass it.
9838
0afb4571
J
98392011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9840
9841 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9842 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9843 for ! HAVE_GTK3.
9844 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9845
9846 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9847
9848 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9849 gdk_window_get_screen, gdk_window_get_geometry,
9850 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9851 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9852 (xg_get_pixbuf_from_pixmap): New function.
9853 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9854 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9855 Call xg_get_pixbuf_from_pixmap instead of
9856 gdk_pixbuf_get_from_drawable.
9857 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9858 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9859 (xg_check_special_colors): Use GtkStyleContext and its functions
9860 for HAVE_GTK3.
9861 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9862 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9863 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
9864 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9865 Call gtk_widget_get_preferred_size.
0afb4571
J
9866 (xg_frame_resized): gdk_window_get_geometry only takes 5
9867 parameters.
44f230aa
SM
9868 (xg_win_to_widget, xg_event_is_for_menubar):
9869 Call gdk_x11_window_lookup_for_display.
0afb4571
J
9870 (xg_set_widget_bg): New function.
9871 (delete_cb): New function.
895009e1 9872 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 9873 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
9874 (xg_set_background_color): Call xg_set_widget_bg.
9875 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9876 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9877 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9878 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9879 if ! HAVE_GTK3.
9880 (update_frame_tool_bar): Call gtk_widget_hide.
9881 (xg_initialize): Use GDK_KEY_g.
9882
9883 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9884 if ! HAVE_GTK3
9885 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9886
9887 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9888 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9889 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9890
1c2cc4ef
JB
98912011-03-08 Juanma Barranquero <lekktu@gmail.com>
9892
9893 * w32xfns.c (select_palette): Check success of RealizePalette against
9894 GDI_ERROR, not zero.
9895
33383987 9896See ChangeLog.11 for earlier changes.
aac0c6e3
MR
9897
9898;; Local Variables:
9899;; coding: utf-8
aac0c6e3
MR
9900;; End:
9901
2f097256 9902 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
9903
9904 This file is part of GNU Emacs.
9905
9906 GNU Emacs is free software: you can redistribute it and/or modify
9907 it under the terms of the GNU General Public License as published by
9908 the Free Software Foundation, either version 3 of the License, or
9909 (at your option) any later version.
9910
9911 GNU Emacs is distributed in the hope that it will be useful,
9912 but WITHOUT ANY WARRANTY; without even the implied warranty of
9913 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9914 GNU General Public License for more details.
9915
9916 You should have received a copy of the GNU General Public License
9917 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.