Improve fringe documentation in Lisp manual.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
90b671e2
EZ
12012-02-11 Eli Zaretskii <eliz@gnu.org>
2
1c0ca0b7
EZ
3 * w32select.c (Fx_selection_exists_p): Sync doc string and
4 argument list with xselect.c. (Bug#10783)
5
6 * w16select.c (Fx_selection_exists_p): Sync doc string and
7 argument list with xselect.c. (Bug#10783)
90b671e2 8
49241268
GM
92012-02-10 Glenn Morris <rgm@gnu.org>
10
11 * fns.c (Fsecure_hash): Doc fix.
12
f998bbe7 132012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
14
15 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
16
0992bd9c
CY
172012-02-07 Chong Yidong <cyd@gnu.org>
18
19 * buffer.c (Fbuffer_local_variables)
20 (buffer_lisp_local_variables): Handle unbound vars correctly;
21 don't let Qunbound leak into Lisp.
22
af008560
GM
232012-02-07 Glenn Morris <rgm@gnu.org>
24
dd605cc4
GM
25 * image.c (Fimagemagick_types): Doc fix.
26
af008560
GM
27 * image.c (imagemagick-render-type): Change it from a lisp object
28 to an integer. Move the doc here from the lisp manual.
29 Treat all values not equal to 0 the same.
30
1449fa1d
CY
312012-02-06 Chong Yidong <cyd@gnu.org>
32
33 * doc.c (store_function_docstring): Avoid applying docstring of
34 alias to base function (Bug#2603).
35
3723ec07
AS
362012-02-04 Andreas Schwab <schwab@linux-m68k.org>
37
38 * .gdbinit (pp1, pv1): Remove redundant defines.
39 (pr): Use pp.
40
79c1cc1e
CY
412012-02-04 Chong Yidong <cyd@gnu.org>
42
43 * nsterm.m: Declare a global (Bug#10694).
44
d7f29f8e
EZ
452012-02-04 Eli Zaretskii <eliz@gnu.org>
46
47 * w32.c (get_emacs_configuration_options): Include
48 --enable-checking, if specified, in the return value.
49
3b95a6f9
MR
502012-02-04 Martin Rudalics <rudalics@gmx.at>
51
52 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
53 after rounding frame sizes. (Bug#9723)
54
d6fa96a6
EZ
552012-02-04 Eli Zaretskii <eliz@gnu.org>
56
57 * keyboard.c (adjust_point_for_property): Don't position point
58 before BEGV. (Bug#10696)
59
df0b2940
PE
602012-02-03 Paul Eggert <eggert@cs.ucla.edu>
61
62 Handle overflow when computing char display width (Bug#9496).
63 * character.c (char_width): Return EMACS_INT, not int.
64 (char_width, c_string_width): Check for overflow when
65 computing the width; this is possible now that individual
66 characters can have unbounded width. Problem introduced
67 by merge from Emacs 23 on 2012-01-19.
68
6bee44d6
MA
692012-02-02 Michael Albinus <michael.albinus@gmx.de>
70
71 * dbusbind.c (Fdbus_register_method): Mention the return value
72 :ignore in the docstring.
73
44f92739
GM
742012-02-02 Glenn Morris <rgm@gnu.org>
75
1b9f60cc
GM
76 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
77
44f92739
GM
78 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
79 Unconditionally set to t. (Bug#10673)
80 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
81 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
82 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
83
c5d3843c
KH
842012-02-02 Kenichi Handa <handa@m17n.org>
85
86 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
87 0, do not call append_composite_glyph.
88
159462d4 892012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
90
91 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
92 NULL (Bug#6988).
93 (x_produce_glyphs): If the component of a composition is a null
94 string, set it->pixel_width to 1 to avoid zero-width glyph.
95
78cef877
EZ
962012-02-01 Eli Zaretskii <eliz@gnu.org>
97
98 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
99 first 2 arguments are identical. This makes inserting large
100 output from a subprocess an order of magnitude faster on
101 MS-Windows, where all sbrk'ed memory is always contiguous.
102
97897668
GM
1032012-01-31 Glenn Morris <rgm@gnu.org>
104
105 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 106 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
107 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
108
31fd3586
GM
1092012-01-29 Glenn Morris <rgm@gnu.org>
110
111 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
112
0e24a8b2
CY
1132012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
114
115 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
116
cc0adcb0
CY
1172012-01-28 Chong Yidong <cyd@gnu.org>
118
119 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
120
acc28cb9
CY
1212012-01-26 Chong Yidong <cyd@gnu.org>
122
9c69cfb7
CY
123 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
124
acc28cb9
CY
125 * search.c (Fsearch_forward, Fsearch_backward): Document negative
126 repeat counts (Bug#10507).
127
48da7392
GM
1282012-01-26 Glenn Morris <rgm@gnu.org>
129
130 * lread.c (syms_of_lread): Doc fix.
131
14af5f7f
CY
1322012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
133
134 * coding.c (encode_designation_at_bol): Change return value to
135 EMACS_INT.
136
0b21c100
CY
1372012-01-25 Chong Yidong <cyd@gnu.org>
138
139 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
140
3c2907f7
CY
1412012-01-21 Chong Yidong <cyd@gnu.org>
142
143 * floatfns.c (Fcopysign): Make the second argument non-optional,
144 since nil is not allowed anyway.
145
959ad23f
AS
1462012-01-21 Andreas Schwab <schwab@linux-m68k.org>
147
148 * process.c (read_process_output): Use p instead of XPROCESS (proc).
149 (send_process): Likewise.
150
34a02f46
MR
1512012-01-19 Martin Rudalics <rudalics@gmx.at>
152
153 * window.c (save_window_save, Fcurrent_window_configuration)
154 (Vwindow_persistent_parameters): Do not use Qstate. Rewrite
155 doc-strings.
156
1259009a 1572012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
158
159 * character.c (char_width): New function.
70d4fdf6
GM
160 (Fchar_width, c_string_width, lisp_string_width):
161 Use char_width (Bug#9496).
25ed9e61 162
6a6ee00d
MR
1632012-01-16 Martin Rudalics <rudalics@gmx.at>
164
165 * window.c (Vwindow_persistent_parameters): New variable.
166 (Fset_window_configuration, save_window_save): Handle persistent
167 window parameters.
168
c85efaf7
EZ
1692012-01-14 Eli Zaretskii <eliz@gnu.org>
170
171 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
172 thrashing the stack of the thread. (Bug#9087)
173
5944709e
PE
1742012-01-12 Paul Eggert <eggert@cs.ucla.edu>
175
176 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
177
e71f5d99
EZ
1782012-01-11 Eli Zaretskii <eliz@gnu.org>
179
180 * xdisp.c (rows_from_pos_range): Handle the case where the
181 highlight ends on a newline. (Bug#10464)
182 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
183 he end column for display of highlight that ends on a newline
184 before a R2L line.
185
ce316182
GM
1862012-01-11 Glenn Morris <rgm@gnu.org>
187
188 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
189 from load-path also when installation-directory is nil. (Bug#10208)
190
5b43da69
GM
1912012-01-10 Glenn Morris <rgm@gnu.org>
192
74cc8ff9
GM
193 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
194
7d8d6e4e
GM
195 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
196 Update template values to be closer to their typical values these days.
5b43da69 197
a0db8d43
EZ
1982012-01-09 Eli Zaretskii <eliz@gnu.org>
199
200 * xdisp.c (rows_from_pos_range): Accept additional argument
201 DISP_STRING, and accept any glyph in a row whose object is that
202 string as eligible for mouse highlight. Fixes mouse highlight of
203 display strings from overlays. (Bug#10464)
204
9a0115ab 2052012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 206
b9110d6a 207 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
208 * fileio.c (auto_saving_dir_umask): New static var.
209 (Fmake_directory_internal): Use it.
210 (do_auto_save_make_dir): Set it, instead of invoking chmod after
211 creating the directory. The old code temporarily assigns
212 too-generous permissions to the directory.
213 (do_auto_save_eh): Clear it.
b9110d6a 214 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
215 that the var is always cleared.
216
6c1bd3f3
EZ
2172012-01-07 Eli Zaretskii <eliz@gnu.org>
218
219 * search.c (scan_buffer): Pass character positions to
220 know_region_cache, not byte positions. (Bug#6540)
221
069d2b50
L
2222012-01-07 LynX <_LynX@bk.ru> (tiny change)
223
224 * w32.c (sys_rename): Report EXDEV when rename of a directory
225 fails because the target is on another logical disk. (Bug#10284)
226
75bf0d33
DB
2272012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
228
229 * xterm.c (x_embed_request_focus): New function.
230
231 * xterm.h: Add prototype.
232
233 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
234
1c6e5a32
GM
2352012-01-05 Glenn Morris <rgm@gnu.org>
236
237 * emacs.c (emacs_copyright): Update short copyright year to 2012.
238
651e947e
EZ
2392012-01-01 Eli Zaretskii <eliz@gnu.org>
240
241 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
242 Load gnutls_transport_set_lowat only if GnuTLS version is below
243 2.11.1.
244 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
245 GnuTLS versions below 2.11.1.
246
3778cdd8
AL
2472011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
248
249 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
250 to the doc string advising against its use for altering the way
251 windows are scrolled.
252
0e5317f7
KH
2532011-12-28 Kenichi Handa <handa@m17n.org>
254
255 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
256 coding-system ASCII compatible only when it does not produce BOM
257 on encoding (Bug#10383).
258
93d5ca1f
JD
2592011-12-26 Jan Djärv <jan.h.d@swipnet.se>
260
261 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
262 can scroll.
263 (create_and_show_popup_menu): Always use menu_position_func for
264 Gtk3 (Bug#10361).
265
ca22b785
AS
2662011-12-24 Andreas Schwab <schwab@linux-m68k.org>
267
268 * callint.c (Fcall_interactively): Don't truncate prompt string.
269
d048e1e6
EZ
2702011-12-23 Eli Zaretskii <eliz@gnu.org>
271
272 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
273 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 274 resumed from there (after widening). (Bug#10360)
d048e1e6 275
5ccaba1f
JD
2762011-12-22 Jan Djärv <jan.h.d@swipnet.se>
277
278 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
279
204ee57f
JD
2802011-12-21 Jan Djärv <jan.h.d@swipnet.se>
281
b81d40f0
JB
282 * nsterm.m (x_free_frame_resources):
283 Release f->output_data.ns->miniimage.
204ee57f
JD
284 (ns_index_color): Fix indentation. Do not retain
285 color_table->colors[i].
286
287 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
288 before returning.
289
290 * nsfns.m (x_set_background_color): Assign return value from
291 ns_index_color to face-background instead of NSColor*.
292 (ns_implicitly_set_icon_type): Fix indentation.
293 Change assignment in for loop to comparison.
294
295 * emacs.c (ns_pool): New variable.
296 (main): Assign ns_pool.
297 (Fkill_emacs): Call ns_release_autorelease_pool.
298
299 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
300 autorelease fdesc, release fdAttrs and tdict.
301 (ns_get_covering_families): Release charset.
302 (ns_findfonts): Release NSFontDescriptor created with new.
303 (ns_uni_to_glyphs): Fix indentation.
304 (setString): Release attrStr before assigning new value.
305
c803b2b7
JD
3062011-12-18 Jan Djärv <jan.h.d@swipnet.se>
307
678f4426
JD
308 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
309 and NS_IMPL_COCOA.
310 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
311 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
312
cd394be1 3132011-12-18 David Reitter <reitter@cmu.edu>
678f4426 314
5fecd5fc
JD
315 * nsterm.m (ns_term_init): Subscribe for notifications
316 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
317 to method trackingNotification in EmacsMenu.
318
319 * nsmenu.m (trackingMenu): New variable.
3771cb17 320 (trackingNotification): New method (from Aquamacs).
5fecd5fc 321 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 322 from Aquamacs (Bug#7030).
678f4426
JD
323
3242011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 325
c803b2b7
JD
326 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
327 (symbol_to_nsstring): Fix indentation.
328 (ns_symbol_to_pb): New function.
329 (Fns_get_selection_internal): Renamed from Fns_get_cut_buffer_internal.
330 (Fns_rotate_cut_buffers_internal): Removed.
331 (Fns_store_selection_internal): Renamed from
332 Fns_store_cut_buffer_internal.
333 (ns_get_foreign_selection, Fx_own_selection_internal)
334 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
335 (Fns_get_selection_internal, Fns_store_selection_internal):
336 Use ns_symbol_to_pb and check if return value is nil.
337 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
338 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
339 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
340 renamed to Sns_store_selection_internal.
341 (ns_handle_selection_request): Move code to Fx_own_selection_internal
342 and remove this function.
343 (ns_handle_selection_clear): Remove, never used.
344 (Fx_own_selection_internal): Move code from ns_handle_selection_request
345 here.
346
e1b01a3a
KB
3472011-12-17 Ken Brown <kbrown@cornell.edu>
348
349 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
350 GID is unknown (Bug#10257).
351
2adb6e85
PE
3522011-12-17 Paul Eggert <eggert@cs.ucla.edu>
353
354 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
355 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
356 which caused a build failure on GNU/Linux IA-64. This problem was
357 introduced by my 2011-10-07 patch.
358
d1d7b339
JL
3592011-12-15 Juri Linkov <juri@jurta.org>
360
361 * image.c (imagemagick_error): New function. (Bug#10112)
362 (imagemagick_load_image): Comment out `MagickSetResolution' call.
363 Use `imagemagick_error' where ImageMagick functions return
364 `MagickFalse'.
365 (Fimagemagick_types): Add `Fnreverse' to return the list in the
366 proper order.
367
100d5755
KH
3682011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
369
370 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
371 fill background (Bug#8992).
372
454592a6
MR
3732011-12-13 Martin Rudalics <rudalics@gmx.at>
374
375 * window.c (Vwindow_combination_resize)
376 (Vwindow_combination_limit): Use t instead of non-nil in
377 doc-strings.
61d4b438
MR
378 (Vrecenter_redisplay): Add first sentence of doc-string on
379 separate line.
53524d93 380 (Frecenter): Fix doc-string typo.
454592a6 381
3633e3aa
KH
3822011-12-11 Kenichi Handa <handa@m17n.org>
383
384 * coding.c (Funencodable_char_position): Pay attention to the
385 buffer text relocation (Bug#9389).
386
7b9d523a
JD
3872011-12-10 Jan Djärv <jan.h.d@swipnet.se>
388
389 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
390 gtk_init (Bug#10100).
391
b73189c6
EZ
3922011-12-10 Eli Zaretskii <eliz@gnu.org>
393
394 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
395 IT->string is nil. (Bug#10263)
396
f7dfe5d6
JD
3972011-12-10 Jan Djärv <jan.h.d@swipnet.se>
398
83faebb4
JD
399 * nsterm.h (x_free_frame_resources): Declare.
400
f7dfe5d6
JD
401 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
402 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
403
404 * nsterm.h (ns_get_defaults_value): Declare.
405
406 * nsterm.m (ns_default): Call ns_get_defaults_value.
407
7cd4e72c
EZ
4082011-12-09 Eli Zaretskii <eliz@gnu.org>
409
410 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
411 (Bug#10170)
412
b34d7317
YM
4132011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
414
415 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
416 that where the value of an _OBJC_* symbol points to is in the .bss
417 section (Bug#10240).
418
76470ad1
KH
4192011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
420
421 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 422 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 423
745fff94
KH
4242011-12-08 Kenichi Handa <handa@m17n.org>
425
426 * ftfont.c (get_adstyle_property): Fix previous change
427 (Bug#10233).
428
6e44397c
JB
4292011-12-07 Juanma Barranquero <lekktu@gmail.com>
430
431 * w32.c (init_environment): If no_site_lisp, remove site-lisp
432 dirs from the default value of EMACSLOADPATH (bug#10208).
433
7efa6272
GM
4342011-12-07 Glenn Morris <rgm@gnu.org>
435
436 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
437 installation and source directories as well. (Bug#10208)
438
f6fc4d87
CY
4392011-12-06 Chong Yidong <cyd@gnu.org>
440
441 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
442
2bf26180
GM
4432011-12-06 Glenn Morris <rgm@gnu.org>
444
445 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
446 as an error, not just -1. (Bug#10217)
447
3a6ad4f0
CY
4482011-12-05 Chong Yidong <cyd@gnu.org>
449
450 * keyboard.c (process_special_events): New function.
451 (swallow_events, Finput_pending_p): Use it (Bug#10195).
452
75a3b399
PE
4532011-12-05 Paul Eggert <eggert@cs.ucla.edu>
454
455 * coding.c (encode_designation_at_bol): Don't use uninitialized
456 local variable (Bug#9318).
457
c3c9e25e
KH
4582011-12-05 Kenichi Handa <handa@m17n.org>
459
460 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
461 return Qnil (Bug#8046, Bug#10193).
462
5eb05ea3
KH
4632011-12-05 Kenichi Handa <handa@m17n.org>
464
465 * coding.c (encode_designation_at_bol): New args charbuf_end and
466 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
467 (coding_set_source): Return how many bytes coding->source was
468 relocated.
469 (coding_set_destination): Return how many bytes
470 coding->destination was relocated.
471 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
472 (CODING_CHAR_CHARSET_P): Adjusted for the avove changes.
5eb05ea3
KH
473
4742011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
475
476 * coding.c (CODING_CHAR_CHARSET_P): New macro.
477 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
478 macro (Bug#9318).
479
4802011-12-05 Andreas Schwab <schwab@linux-m68k.org>
481
482 The following changes are to fix Bug#9318.
483
a79703f5 484 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
485 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
486 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 487 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 488
7dbda6df
JB
4892011-12-05 Juanma Barranquero <lekktu@gmail.com>
490
491 * lisp.h (process_quit_flag): Fix external declaration.
492
6d5eb5b0
SM
4932011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
494
495 Don't macro-inline non-performance-critical code.
496 * eval.c (process_quit_flag): New function.
497 * lisp.h (QUIT): Use it.
498
a0c3fad0
JD
4992011-12-04 Jan Djärv <jan.h.d@swipnet.se>
500
501 * nsfns.m (get_geometry_from_preferences): New function.
502 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
503
6c07aac2
AS
5042011-12-04 Andreas Schwab <schwab@linux-m68k.org>
505
506 * emacs.c (Qkill_emacs): Define.
507 (syms_of_emacs): Initialize it.
508 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
509 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
510 (quit_throw_to_read_char): Add parameter `from_signal'.
511 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
512 * lisp.h (QUIT): Call Fkill_emacs if requested.
513
c052ead4
JD
5142011-12-03 Jan Djärv <jan.h.d@swipnet.se>
515
516 * widget.c (update_wm_hints): Return if wmshell is null.
517 (widget_update_wm_size_hints): New function.
518
519 * widget.h (widget_update_wm_size_hints): Declare.
520
521 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
522 widget_update_wm_size_hints (Bug#10104).
523
9e49252b
EZ
5242011-12-03 Eli Zaretskii <eliz@gnu.org>
525
526 * xdisp.c (handle_invisible_prop): If the invisible text ends just
527 before a newline, prepare the bidi iterator for consuming the
528 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 529 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 530
02b16839
JL
5312011-12-02 Juri Linkov <juri@jurta.org>
532
533 * search.c (Fword_search_regexp): New Lisp function created from
534 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
535 (Fword_search_backward, Fword_search_forward)
536 (Fword_search_backward_lax, Fword_search_forward_lax):
537 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
538 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
539
0068070e
SM
5402011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
541
542 * fileio.c (Finsert_file_contents): Move after-change-function call
543 to before the "handled:" label, since all "goto handled" appear in
544 cases where the *-change-functions have already been properly called
545 (bug#10117).
546
3360a3fc
AS
5472011-12-01 Andreas Schwab <schwab@linux-m68k.org>
548
549 * keyboard.c (interrupt_signal): Don't call kill-emacs when
550 waiting for input. (Bug#10169)
551
73d6c093
EZ
5522011-11-30 Eli Zaretskii <eliz@gnu.org>
553
554 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
555 verifies glyph row's hash code--we have just reallocated the
556 glyphs, so their contents can be complete garbage. (Bug#10164)
557
febe6bea
JB
5582011-11-30 Juanma Barranquero <lekktu@gmail.com>
559
560 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
561
801a4313
EZ
5622011-11-30 Eli Zaretskii <eliz@gnu.org>
563
564 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
565 attributes are tested _before_ calling verify_row_hash, to protect
566 against GCC re-ordering of the tests. (Bug#10164)
567
2b56b87e
JD
5682011-11-29 Jan Djärv <jan.h.d@swipnet.se>
569
570 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
571
572 * xterm.c (handle_one_xevent): Only set async_visible and friends
573 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 574 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
575 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
576
dbf31225
PE
5772011-11-28 Paul Eggert <eggert@cs.ucla.edu>
578
579 Remove GCPRO-related macros that exist only to avoid shadowing locals.
580 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
581 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
582 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
583 All uses changed to use GCPRO1 etc.
584 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
585 Revert to old implementation (i.e., before 2011-03-11).
586
1305621b
YM
5872011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
588
589 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
590 of scroll runs so as to avoid assigning disabled bogus rows and
591 unnecessary graphics copy operations.
592
8c9afb46
EZ
5932011-11-27 Eli Zaretskii <eliz@gnu.org>
594
595 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
596 (snprintf) [_MSC_VER]: Redirect to _snprintf.
597 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
598 (malloc, free, realloc, calloc): Redirect to e_* only when
599 compiling Emacs.
600
601 * lisp.h (GCTYPEBITS): Move before first use.
602 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
603 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
604 this macro definition.
605
606 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
607 _MSC_VER.
608
54e9e3bf
JD
6092011-11-27 Jan Djärv <jan.h.d@swipnet.se>
610
6d5eb5b0
SM
611 * gtkutil.c (xg_create_frame_widgets):
612 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
613 present with Gtk+ 2.0.
614
83aca1cb
PE
6152011-11-26 Paul Eggert <eggert@cs.ucla.edu>
616
617 * fileio.c (Finsert_file_contents): Undo previous change; see
618 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
619
5b76caa4
PE
6202011-11-26 Paul Eggert <eggert@cs.ucla.edu>
621
622 Rename locals to avoid shadowing.
623 * fileio.c (Finsert_file_contents):
624 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
625 * process.c (wait_reading_process_output):
626 Rename inner 'proc' to 'p' to avoid shadowing.
627 Indent for consistency with usual Emacs style.
628
8c535114
EZ
6292011-11-25 Eli Zaretskii <eliz@gnu.org>
630
631 * xdisp.c (redisplay_window): If cursor row is not fully visible
632 after recentering, and scroll-conservatively is set to a large
633 number, scroll window by a few more lines to make the cursor fully
634 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
635 (start_display): Don't move to the next line if the display should
636 start at a newline that is part of a display vector or an overlay
637 string. (Bug#10119)
8c535114 638
fa4fdb5c
JL
6392011-11-24 Juri Linkov <juri@jurta.org>
640
641 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
642 after the `MagickPingImage' call. (Bug#10112)
643
90ec88df
CY
6442011-11-23 Chong Yidong <cyd@gnu.org>
645
646 * window.c (Fcoordinates_in_window_p): Accept only live windows.
647
56e2e794
MR
6482011-11-23 Martin Rudalics <rudalics@gmx.at>
649
650 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
651 making another buffer current. (Bug#10114)
652
b6e64c41
GM
6532011-11-23 Glenn Morris <rgm@gnu.org>
654
655 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
656
6b21de18
CY
6572011-11-23 Chong Yidong <cyd@gnu.org>
658
659 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
660 using it (Bug#5984).
661
b12cd789
EZ
6622011-11-22 Eli Zaretskii <eliz@gnu.org>
663
664 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
665 and header-lines, as they don't have one computed for them.
666 (Bug#10098)
667
668 * .gdbinit (prow): Make displayed values more self-explaining.
669 Add row's hash code.
670
261b6fd4
LMI
6712011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
672
673 * process.c (wait_reading_process_output): Fix asynchrounous
674 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 675 (wait_reading_process_output): Add comment and URL.
261b6fd4 676
e7cfd277
JD
6772011-11-21 Jan Djärv <jan.h.d@swipnet.se>
678
679 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
680
a9b9b7f5
CY
6812011-11-21 Chong Yidong <cyd@gnu.org>
682
683 * window.c (Fnext_window, Fprevious_window): Doc fix.
684
b0d15b4f
SM
6852011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
686
687 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
688
fe7a3057
JB
6892011-11-20 Juanma Barranquero <lekktu@gmail.com>
690
691 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
692
d2999b1a
MR
6932011-11-20 Martin Rudalics <rudalics@gmx.at>
694
695 * window.c (Fset_window_combination_limit): Rename argument
696 STATUS to LIMIT.
697 (Vwindow_combination_limit): Remove "status" from doc-string.
698
d5ff9cd0
AS
6992011-11-20 Andreas Schwab <schwab@linux-m68k.org>
700
701 * m/ibms390.h: Remove.
702 * m/ibms390x.h: Don't include "ibms390.h".
703
a5bb9bd3
SM
7042011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
705
706 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
707 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
708
cd1181db
JB
7092011-11-20 Juanma Barranquero <lekktu@gmail.com>
710
711 * casetab.c (Fset_case_table):
712 * charset.c (Fcharset_after): Fix typos.
713
615a3b8d 7142011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 715
17e845af
PE
716 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
717 Otherwise, valgrind does not work on some platforms.
718 Problem reported by Andreas Schwab in
6a0bf43d
PE
719 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
720 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
721 is set, removing the need for VIRT_ADDRESS_VARIES.
722 (PURE_P): Use a more-efficient implementation that needs just one
723 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
724 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
725 to 4 (xorl, subq, cmpq, setbe).
726 * alloc.c (pure): Always extern now, since that's the
727 VIRT_ADDR_VARIES behavior.
728 (PURE_POINTER_P): Use a single comparison, not two, for
729 consistency with the new puresize.h.
730 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
731 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
732 Remove VIRT_ADDR_VARIES no longer needed.
733
f8fe6f96
EZ
7342011-11-19 Eli Zaretskii <eliz@gnu.org>
735
736 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
737 (erase_phys_cursor, update_window_cursor, show_mouse_face)
738 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
739 behave as if the cursor position were at the window margin.
740
741 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
742 and the cursor position is out of bounds, behave as if the cursor
743 position were at the window margin. (Bug#10075)
744
df05a53c
CY
7452011-11-18 Chong Yidong <cyd@gnu.org>
746
747 * window.c (Fwindow_combination_limit): Make first argument
748 non-optional, since it is meaningless for live windows like the
749 selected window.
750
2071918e
DA
7512011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
752
753 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
754
b50a28de
SM
7552011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
756
757 * intervals.c: Fix grafting over the whole buffer (bug#10071).
758 (graft_intervals_into_buffer): Simplify.
759
015137db
EZ
7602011-11-18 Eli Zaretskii <eliz@gnu.org>
761
762 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
763 hash values of the two rows.
764 (copy_row_except_pointers): Preserve the used[] arrays and the
765 hash values of the two rows. (Bug#10035)
68c95424 766 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
767
768 * xdisp.c (row_hash): New function, body extracted from
769 compute_line_metrics.
770 (compute_line_metrics): Call row_hash, instead of computing the
771 hash code inline.
772
773 * dispnew.c (verify_row_hash): Call row_hash for computing the
774 hash code of a row, instead of duplicating code from xdisp.c.
775
776 * dispextern.h (row_hash): Add prototype.
777
a2addb04
TH
7782011-11-18 Tassilo Horn <tassilo@member.fsf.org>
779
780 * frame.c (delete_frame): Don't delete the terminal when the last
781 X frame is closed if emacs is built with GTK toolkit.
782
df85d315
JB
7832011-11-17 Juanma Barranquero <lekktu@gmail.com>
784
785 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
786
a0c2d0ae
MR
7872011-11-17 Martin Rudalics <rudalics@gmx.at>
788
789 * window.c (Vwindow_splits): Rename to
790 Vwindow_combination_resize. Suggested by Juri Linkov.
791 (Fsplit_window_internal): Use Vwindow_combination_resize instead
792 of Vwindow_splits.
793
58179cce
JB
7942011-11-16 Juanma Barranquero <lekktu@gmail.com>
795
7877f373
JB
796 * nsfns.m (Fns_font_name):
797 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 798
b6f67890
MR
7992011-11-16 Martin Rudalics <rudalics@gmx.at>
800
801 * window.h (window): Rename slot "nest" to "combination_limit".
802 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
803 (Fset_window_nest): Rename to Fset_window_combination_limit.
804 (Vwindow_nest): Rename to Vwindow_combination_limit.
805 (recombine_windows, make_parent_window, make_window)
806 (Fsplit_window_internal, saved_window)
807 (Fset_window_configuration, save_window_save): Rename all
808 occurrences of window_nest to window_combination_limit.
809
c7015153
JB
8102011-11-15 Juanma Barranquero <lekktu@gmail.com>
811
812 * image.c (imagemagick_load_image): Fix typo.
813
322ad6ec
EZ
8142011-11-14 Eli Zaretskii <eliz@gnu.org>
815
816 * xdisp.c (display_line): Move the call to
817 highlight_trailing_whitespace before the call to
818 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
819 faces of all the glyphs to compute ROW's hash value.
820 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 821
f067b8ec
JB
8222011-11-14 Juanma Barranquero <lekktu@gmail.com>
823
824 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
825 just return (bug#10044).
826
1e5b2111
EZ
8272011-11-12 Eli Zaretskii <eliz@gnu.org>
828
7ef3cbd5
EZ
829 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
830 with user-defined heap size. Bump the default size of the temacs
831 heap to 27MB, to avoid memory warning when running temacs.
832 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
833
1e5b2111
EZ
834 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
835 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
836 (verify_row_hash) [XASSERTS]: New function.
837 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
838 that the hash value of glyph rows is correct.
1e5b2111 839
89d61221
MR
8402011-11-12 Martin Rudalics <rudalics@gmx.at>
841
842 * window.h (window): Remove splits slot.
843 * window.c (Fwindow_splits, Fset_window_splits): Remove.
844 (Fdelete_other_windows_internal, make_parent_window)
845 (make_window, Fsplit_window_internal, Fdelete_window_internal)
846 (Fset_window_configuration, save_window_save): Don't deal with
847 split status of windows.
848 (saved_window): Remove splits slot.
849 (Vwindow_splits): Rewrite doc-string.
850
97f18cc8
JD
8512011-11-11 Jan Djärv <jan.h.d@swipnet.se>
852
853 * xfns.c (unwind_create_frame):
854 * nsfns.m (unwind_create_frame):
855 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
856 Vframe_list (Bug#9999).
857
22a648b4
DA
8582011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
859
0b381c7e 860 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 861
659afede
KH
8622011-11-11 Kenichi Handa <handa@m17n.org>
863
864 * callproc.c (Fcall_process): Set the member dst_multibyte of
865 process_coding.
866
9ac0394b
KH
8672011-11-11 Johan Bockgård <bojohan@gnu.org>
868
869 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
870 avoid a crash (bug#9496).
871
2fbdc249
CY
8722011-11-09 Chong Yidong <cyd@gnu.org>
873
874 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
875 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
876
ac6b1f81
PE
8772011-11-08 Paul Eggert <eggert@cs.ucla.edu>
878
879 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
880
09db192c
PE
8812011-11-08 Paul Eggert <eggert@cs.ucla.edu>
882
883 Avoid some portability problems by eschewing 'extern inline' functions.
884 The trivial performance wins aren't worth the portability hassles; see
885 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
886 et seq.
887 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
888 (window_box_width, window_box_left, window_box_left_offset)
889 (window_box_right, window_box_right_offset): Undo previous change,
890 by removing the "extern"s.
891 * intervals.c (adjust_intervals_for_insertion)
892 (adjust_intervals_for_deletion): Undo previous change,
893 making these static again.
894 (offset_intervals, temp_set_point_both, temp_set_point)
895 (copy_intervals_to_string): No longer inline.
896 * xdisp.c (window_text_bottom_y, window_box_width)
897 (window_box_height, window_box_left_offset)
898 (window_box_right_offset, window_box_left, window_box_right)
899 (window_box): No longer inline.
900
105216ed
CY
9012011-11-08 Chong Yidong <cyd@gnu.org>
902
903 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
904 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
905 Signal an error if not a live window.
105216ed
CY
906 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
907 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
908
ae9e237f
JB
9092011-11-07 Juanma Barranquero <lekktu@gmail.com>
910
911 * lisp.h (syms_of_abbrev): Remove declaration.
912 Reported by CHENG Gao <chenggao@royau.me>.
913
c7aa8333
EZ
9142011-11-07 Eli Zaretskii <eliz@gnu.org>
915
916 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
917 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
918 of temacs in GUI mode.
919
be7f5545
MR
9202011-11-07 Martin Rudalics <rudalics@gmx.at>
921
922 * window.h: Declare delete_all_child_windows instead of
923 delete_all_subwindows.
924 * window.c (Fwindow_nest, Fset_window_nest)
925 (Fset_window_new_total, Fset_window_new_normal)
926 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
927 (delete_all_subwindows): Rename to delete_all_child_windows.
928 (Fdelete_other_windows_internal, Fset_window_configuration):
929 Call delete_all_child_windows instead of delete_all_subwindows.
930 * frame.c (delete_frame): Call delete_all_child_windows instead
931 of delete_all_subwindows.
932
ca78dc43
PE
9332011-11-07 Paul Eggert <eggert@cs.ucla.edu>
934
935 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
936 This is also needed for porting to any host where GC_MARK_STACK is
937 not GC_MAKE_GCPROS_NOOPS.
938 (which_symbols): Use it.
939
a0241d01
KH
9402011-11-07 Kenichi Handa <handa@m17n.org>
941
942 * coding.c (coding_set_destination): Check coding->src_pos only
943 when coding->src_object is a buffer (bug#9910).
944
945 * process.c (send_process): Set the member src_multibyte of coding
946 to 0 (bug#9911) when sending a unibyte text.
947
948 * callproc.c (Fcall_process): Set the member src_multibyte of
949 process_coding to 0 (bug#9912).
950
a64bfdfa 9512011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
952
953 * xmenu.c (cleanup_widget_value_tree): New function.
954 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
955 calling free_menubar_widget_value_tree directly (Bug#9830).
956
cb41b32a
PE
9572011-11-06 Paul Eggert <eggert@cs.ucla.edu>
958
959 Fix some portability problems with 'inline'.
960 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
961 (window_box_width, window_box_left, window_box_left_offset)
962 (window_box_right, window_box_right_offset): Declare extern.
963 Otherwise, these inline functions do not conform to C99 and
964 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
965 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
966 * intervals.c (adjust_intervals_for_insertion)
967 (adjust_intervals_for_deletion): Now extern, because otherwise the
968 extern inline functions 'offset_intervals' couldn't refer to it.
969 (static_offset_intervals): Remove.
970 (offset_intervals): Rewrite using the old contents of
971 static_offset_intervals. The old version didn't conform to C99
972 because an extern inline function contained a reference to an
973 identifier with static linkage.
974
b7041366
AS
9752011-11-06 Andreas Schwab <schwab@linux-m68k.org>
976
977 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
978 GC.
979
88a37c4d
EZ
9802011-11-06 Eli Zaretskii <eliz@gnu.org>
981
982 * xdisp.c (init_iterator, reseat_to_string): Don't set the
983 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
984 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
985 return Qleft_to_right.
986
49745b39
CY
9872011-11-06 Chong Yidong <cyd@gnu.org>
988
989 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
990 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
991 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
992 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
993 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
994 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
995 (Fwindow_vscroll): Doc fix.
996 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
997 argument, since it makes no sense to pass a live window and for
998 consistency with window-child.
999
1f05cd82
CS
10002011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1001
1002 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1003 support MSVC.
1004
22610910
JR
10052011-11-05 Jason Rumney <jasonr@gnu.org>
1006
1007 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1008 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1009 fonts (Bug#6029).
1010 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1011 bitwise arithmetic preventing use of unicode-sip and non-truetype
1012 opentype fonts.
1013
a06776b2
EZ
10142011-11-05 Eli Zaretskii <eliz@gnu.org>
1015
3ad924ba
EZ
1016 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1017 "emacs"-only part.
1018
a06776b2
EZ
1019 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1020 initialization code to keep similarity to xfns.c after changes
1021 from 2011-11-05.
1022
c9e7db78
JD
10232011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1024
a97f8f3f
JD
1025 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1026 (unwind_create_frame): New function (Bug#9943).
1027 (Fx_create_frame): Restructure code to be more similar to the one in
1028 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1029 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1030 Move terminal->reference_count++ just before making the frame official
1031 (Bug#9943).
1032
1033 * nsterm.m (x_free_frame_resources): New function.
1034 (x_destroy_window): Move code to x_free_frame_resources.
1035
c9e7db78 1036 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
1037 (Fx_create_frame, x_create_tip_frame):
1038 Move terminal->reference_count++ just before making the frame
c9e7db78
JD
1039 official. Move initialization of image_cache_refcount and
1040 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1041
a6fc3b5c
EZ
10422011-11-05 Eli Zaretskii <eliz@gnu.org>
1043
1044 Support MSVC build with newer versions of Visual Studio.
1045 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1046 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1047 nt/gmake.defs.
1048
1049 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1050 which are not supported by MSVC.
1051 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1052 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1053 bitfields.
1054 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1055 types in bitfields.
1056 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1057
1058 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1059
58179cce 10602011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
1061
1062 Support MSVC build with newer versions of Visual Studio.
1063 * w32.c: Don't include w32api.h for MSVC.
1064 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1065
1066 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1067 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1068 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1069 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1070 e_* cousins.
1071 (alloca) [_MSC_VER]: Define to _alloca.
1072
1073 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1074
1075 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1076
a58c13ed
EZ
10772011-11-04 Eli Zaretskii <eliz@gnu.org>
1078
1079 * xdisp.c (note_mouse_highlight): If either of
1080 previous/next-single-property-change returns nil, treat that as
1081 the beginning or the end of the buffer. (Bug#9955)
1082
fe0b6370
JD
10832011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1084
a58c13ed 1085 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
1086 label is not null (Bug#9951).
1087 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1088 may be NULL.
1089
89bd5ee1
EZ
10902011-11-04 Eli Zaretskii <eliz@gnu.org>
1091
1092 * window.c (Fwindow_body_size): Mention in the doc string that the
1093 return value is in frame's canonical units. (Bug#9949)
1094
84c3edb9
EZ
10952011-11-03 Eli Zaretskii <eliz@gnu.org>
1096
4e2fb5c7
EZ
1097 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1098
84c3edb9 1099 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 1100 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 1101 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 1102
bc17a887
EZ
11032011-11-01 Eli Zaretskii <eliz@gnu.org>
1104
1105 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1106 Don't stop backward scan on the continuation glyph, even though
1107 its CHARPOS is positive.
6d5eb5b0
SM
1108 (mouse_face_from_buffer_pos, note_mouse_highlight):
1109 Rename cover_string to disp_string.
bc17a887 1110
4ee88440
MR
11112011-11-01 Martin Rudalics <rudalics@gmx.at>
1112
1113 * window.c (temp_output_buffer_show): Don't use
1114 Vtemp_buffer_show_specifiers.
1115 (Vtemp_buffer_show_specifiers): Remove unused variable.
1116
c2ff3c02
EZ
11172011-10-30 Eli Zaretskii <eliz@gnu.org>
1118
1119 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1120 past the beginning of the current glyph matrix.
1121
58179cce 11222011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
1123
1124 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1125 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1126 HAVE_GTK3 (Bug#9869).
b77a6a7f 1127
3b574623
JD
1128 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1129 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1130
b77a6a7f
JD
1131 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1132
1133 * xterm.c: Declare x_handle_net_wm_state to return int.
1134 (handle_one_xevent): Check if we are iconified but don't have
1135 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1136 (get_current_wm_state): Return non-zero if not hidden,
1137 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1138 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1139 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1140 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1141
196e41e4
PE
11422011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1143
1144 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1145 so that this new function doesn't get optimized away by a
1146 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1147
021f2e1a
AS
11482011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1149
1150 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1151
8b058d44
EZ
11522011-10-29 Eli Zaretskii <eliz@gnu.org>
1153
1154 Fix the `xbytecode' command.
1155 * .gdbinit (xprintbytestr): New command.
b50a28de 1156 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
1157 (xbytecode): Print the byte-code string as well.
1158
4452fb80
EZ
11592011-10-29 Kim Storm <storm@cua.dk>
1160
8b058d44
EZ
1161 * alloc.c (which_symbols): New function.
1162
21b72067
AS
11632011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1164
1165 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1166 line. (Bug#9903)
1167
83ed7b5c
GM
11682011-10-29 Glenn Morris <rgm@gnu.org>
1169
1170 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1171 Not clear what it was for, and it causes various bugs. (Bug#9839)
1172
5a7a728b
EZ
11732011-10-28 Eli Zaretskii <eliz@gnu.org>
1174
1175 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1176 possible random value that matches one of those tested as
1177 condition to clear the mouse face.
1178
d3d0842f
CY
11792011-10-28 Chong Yidong <cyd@gnu.org>
1180
1181 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1182
31b39d13
DN
11832011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1184
1185 * window.c (make_window): Initialize phys_cursor_on_p.
1186
9aba6043
SM
11872011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1188
1189 * lisp.h (struct Lisp_Symbol): Update comments.
1190
c20992f4
JB
11912011-10-28 Juanma Barranquero <lekktu@gmail.com>
1192
1193 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1194
db4f02f2
EZ
11952011-10-28 Eli Zaretskii <eliz@gnu.org>
1196
1197 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1198 <oslsachem@gmail.com> for helping to debug this.
1199
1200 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1201 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1202 (g_b_init_get_glyph_outline_w): New static variables.
1203 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1204 (GetGlyphOutlineW_Proc): New typedefs.
1205 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
1206 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1207 New functions.
1208 (w32font_open_internal, compute_metrics):
1209 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
1210 instead of calling the "wide" APIs directly.
1211
1212 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1213
1214 * w32.h (syms_of_w32font): Add prototype.
1215
87e68db4
JB
12162011-10-27 Juanma Barranquero <lekktu@gmail.com>
1217
1218 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1219 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1220 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1221 (Fmove_to_window_line): Doc fix.
1222
435c1d67
CY
12232011-10-27 Chong Yidong <cyd@gnu.org>
1224
1225 * process.c (make_process): Set gnutls_state to NULL.
1226
1227 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1228 non-NULL, regardless of GNUTLS_INITSTAGE.
1229 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1230 an error. Set process slots as soon as we allocate them.
1231
1232 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1233
9c6c6f49
CY
12342011-10-27 Chong Yidong <cyd@gnu.org>
1235
9aba6043
SM
1236 * gnutls.c (emacs_gnutls_deinit): New function.
1237 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
1238 (Fgnutls_deinit, Fgnutls_boot): Use it.
1239
1240 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1241 (deactivate_process): Call emacs_gnutls_deinit.
1242
657d08d3
JB
12432011-10-27 Juanma Barranquero <lekktu@gmail.com>
1244
1245 * image.c (x_create_x_image_and_pixmap):
1246 * w32.c (sys_rename, w32_delayed_load):
1247 * w32font.c (fill_in_logfont):
1248 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1249
5430d399
JB
12502011-10-26 Juanma Barranquero <lekktu@gmail.com>
1251
1252 * w32fns.c (w32_default_color_map): New function,
1253 extracted from Fw32_default_color_map.
a7ef684b 1254 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 1255
fe0055fa
PE
12562011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1257
1258 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1259
e6346438
SM
12602011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1261
1262 * keyboard.c (test_undefined): New function (bug#9751).
1263 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1264
e112cc37
ET
12652011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1266
1267 * sysdep.c (init_sys_modes): Fix the check for the controlling
1268 terminal (Bug#6649).
1269
7b5d6677
EZ
12702011-10-20 Eli Zaretskii <eliz@gnu.org>
1271
1272 * dispextern.h (struct bidi_it): New member next_en_type.
1273
1274 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1275 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1276 current character, check also for next_en_type being WEAK_EN.
1277 (bidi_resolve_weak): Don't enter the expensive loop if the current
1278 position is before next_en_pos. Record the bidi type of the first
1279 non-ET, non-BN character we find, in addition to its position.
1280 (bidi_level_of_next_char): Invalidate next_en_type when
1281 next_en_pos is over-stepped.
1282
7da0b018
PE
12832011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1284
1285 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1286 * editfns.c: Rewrite current-time-zone so that it invokes
1287 the equivalent of (format-time-string "%Z") to get the time zone name.
1288 This fixes a bug when the time zone name contains characters that
1289 need converting from the system time locale to Emacs internal format.
1290 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1291 that patch fixed format-time-string to do the conversion, but
1292 I forgot to fix current-time-zone.
1293 (format_time_string): New function, containing most of
1294 what Fformat_time_string used to contain.
1295 (Fformat_time_string): Rewrite in terms of format_time_string.
1296 This doesn't change this function's behavior.
1297 (current-time-zone): Rewrite to use format_time_string.
1298 This fixes the bug reported by Michael Schierl in
1299 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1300 Jason Rumney's 2007-06-07 change worked around this bug, but
1301 didn't fix it.
1302 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1303
8547b010
EZ
13042011-10-19 Eli Zaretskii <eliz@gnu.org>
1305
1306 * xdisp.c (start_display): If the character at POS is displayed
1307 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
1308 (try_window_reusing_current_matrix): If a line ends in a display
1309 vector or the next line starts in a display vector, continue
1310 redrawing the window even though the character position of
1311 start_row was reached.
8547b010
EZ
1312 (Bug#9771, part 2)
1313
4e948d15
CY
13142011-10-18 Chong Yidong <cyd@gnu.org>
1315
1316 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1317 with nobreak-char-display too.
1318
4787455f
EZ
13192011-10-18 Eli Zaretskii <eliz@gnu.org>
1320
1321 Fix part 3 of bug#9771.
1322 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1323 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1324 non-neutral characters if the current character is a paragraph
1325 separator (a.k.a. Newline). This avoids running the same
1326 expensive loop twice, once when we consume the preceding newline
1327 and the other time when the line actually needs to be displayed.
1328 Avoid the loop when we see neutrals on the base embedding level
1329 following a character whose directionality is the same as the
1330 paragraph's. This avoids running the expensive loop when a line
1331 ends in a long sequence of neutrals, like control characters.
1332 Add assertion against STRONG_AL type. Slightly rearrange code
1333 that determines the type of a neutral given the first non-neutral
1334 that follows it.
1335 (bidi_level_of_next_char): Set next_en_pos to zero when
1336 invalidating its info.
1337
2c91f553
EZ
13382011-10-17 Eli Zaretskii <eliz@gnu.org>
1339
1340 * xdisp.c (push_display_prop): Determine whether to record string
1341 or buffer position by IT->string, not by IT->method. Allow
1342 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
1343 (move_it_vertically_backward): Don't look for character position
1344 immediately after the newline when in a continuation line.
1345 (Bug#9771, part 1)
2c91f553 1346
c7b08b0d
MR
13472011-10-15 Martin Rudalics <rudalics@gmx.at>
1348
1349 * window.c (coordinates_in_window): Rewrite and delabelize
1350 vertical border check. (Bug#5357) (Bug#9618)
1351
6b02f655
SM
13522011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1353
1354 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1355 errors in XSetWindowBorder (bug#9310).
1356
81d40c92
DA
13572011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1358
1359 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1360 avoid crash when xmalloc overrun checking is enabled.
1361
d4172c3b
EZ
13622011-10-13 Eli Zaretskii <eliz@gnu.org>
1363
1364 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1365 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1366 cursor motion with <left> and <right> arrow keys.
1367
1368 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1369 some callers set that themselves.
1370
b00eea75
EZ
13712011-10-12 Eli Zaretskii <eliz@gnu.org>
1372
1373 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1374 display string and the previous row comes from the same string and
1375 is empty. (Bug#9739) (Bug#9738)
1376
8fe012c4
SM
13772011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1378
1379 * doc.c (get_doc_string): Encode file name (bug#9735).
1380
0074aef2
EZ
13812011-10-12 Eli Zaretskii <eliz@gnu.org>
1382
79beb178
EZ
1383 * bidi.c (bidi_level_of_next_char):
1384 * xdisp.c (get_visually_first_element): Remove old incorrect
1385 comments regarding the Unicode Line Separator character.
1386
0074aef2
EZ
1387 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1388
6e4b3fbe
DA
13892011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1390
1391 * alloc.c (Fgc_status): Do not access beyond zombies array
1392 boundary if nzombies > MAX_ZOMBIES.
1393 * alloc.c (dump_zombies): Add missing format specifier.
1394
0324f3af
PE
13952011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1396
b5525cac
PE
1397 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1398 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1399
0324f3af
PE
1400 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1401 Some packages use them to denote characters with modifiers.
1402
e9b5f888
AS
14032011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1404
1405 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1406 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1407 matching a pp-number. Rename parameter var to var1.
1408
127827c0
SM
14092011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1410
1411 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1412
c8fd3bd0
GM
14132011-10-08 Glenn Morris <rgm@gnu.org>
1414
1415 * callint.c (Fcall_interactively): Give a more explicit error for the
1416 'c' case with a non-character input. (Bug#8479)
1417
352ec8ff
EZ
14182011-10-08 Eli Zaretskii <eliz@gnu.org>
1419
03669ccb
EZ
1420 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1421 lines.
7061c986
EZ
1422 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1423 lines that are hscrolled on the left.
03669ccb 1424
352ec8ff
EZ
1425 * dispnew.c (buffer_posn_from_coords): Account for a possible
1426 presence of header-line. (Bug#4426)
1427
a66cfb1c
SM
14282011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1429
6b02f655
SM
1430 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1431 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 1432
7c5ee88e
PE
14332011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1434
1435 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1436 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1437 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1438 this makes Emacs dump core during garbage collection on rare
1439 occasions. sizeof is obviously inferior to offsetof here, so
1440 stick with offsetof.
1441 (GC_POINTER_ALIGNMENT): New macro.
1442 (mark_memory): Omit 3rd (offset) arg; caller changed.
1443 Don't assume EMACS_INT alignment is the same as pointer alignment.
1444
df1bbe5b
SM
14452011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1446
1447 * keyboard.c (read_key_sequence_remapped): New var.
1448 (read_key_sequence): Compute remapping in the right buffer.
1449 (command_loop_1): Use read_key_sequence's remapping directly.
1450
51553db6
SM
14512011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1452
32c1fffd
SM
1453 * dired.c (file_name_completion): Don't expand file name.
1454 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1455 before checking file name handler.
1456
51553db6
SM
1457 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1458 they've been requested explicitly (bug#9591).
1459
b6bd1599 14602011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
1461
1462 * keymap.c (Fsingle_key_description): Use make_specified_string
1463 instead of build_string to build string from push_key_description.
1464 (Bug#5193)
1465
f701dc2a
PE
14662011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1467
4222c55d
PE
1468 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1469 This fixes a Y2038 bug on 64-bit hosts.
1470 * buffer.c (reset_buffer):
1471 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1472 (Fclear_buffer_auto_save_failure):
1473 Use 0, not -1, to represent an unset failure time, since time_t
1474 might not be signed.
1475
f701dc2a
PE
1476 Remove dependency on glibc malloc internals.
1477 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1478 Move back here from lisp.h, but with their new implementations.
1479 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1480 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1481 * charset.c (charset_table_init): New static var.
1482 (syms_of_charset): Use it instead of xmalloc. This removes a
1483 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1484 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1485 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1486 Move back to alloc.c.
1487 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1488 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1489
9ceebf39
JD
14902011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1491
1492 * nsterm.m (windowDidResize): Call x_set_window_size only when
1493 ns_in_resize is true. Otherwise set pixelwidth/height and
1494 call change_frame_size (Bug#9628).
1495
cb993c58
PE
14962011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1497
3930c88b
PE
1498 Port --enable-checking=all to Fedora 14 x86-64.
1499 * charset.c (syms_of_charset): Also account for glibc malloc's
1500 internal overhead when calculating the initial malloc maximum.
1501
cb993c58
PE
1502 Port --enable-checking=all to Fedora 14 x86.
1503 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1504 Move to lisp.h.
1505 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1506 (overrun_check_realloc, overrun_check_free):
1507 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1508 That way, xmalloc returns a properly-aligned pointer even if
1509 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1510 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1511 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1512 into account when calculating the initial malloc maximum.
1513 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1514 Move here from alloc.c, so that charset.c can use it too.
1515 Properly align; the old code wasn't right for common 32-bit hosts
1516 when configured with --enable-checking=all.
1517 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1518 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1519
31bed486
EZ
15202011-09-29 Eli Zaretskii <eliz@gnu.org>
1521
04c70788 1522 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
1523 use EDOM.
1524
fbcaa2f3
EZ
15252011-09-28 Eli Zaretskii <eliz@gnu.org>
1526
1527 * xdisp.c (compute_display_string_end): If there's no display
1528 string at CHARPOS, return -1.
1529
1530 * bidi.c (bidi_fetch_char): When compute_display_string_end
1531 returns a negative value, treat the character as a normal
1532 character not covered by a display string. (Bug#9624)
1533
a239d4e9
JB
15342011-09-28 Juanma Barranquero <lekktu@gmail.com>
1535
1536 * lread.c (Fread_from_string): Fix typo in docstring.
1537
88652fd5
EZ
15382011-09-27 Eli Zaretskii <eliz@gnu.org>
1539
1540 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1541 newline, reseat the iterator instead of bidi-iterating there one
1542 character at a time. (Bug#9610)
32c1fffd
SM
1543 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1544 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 1545
ed497dd4
AS
15462011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1547
1548 * lread.c (readevalloop): Use correct code for NBSP.
1549 (read1): Likewise. (Bug#9608)
1550
b2bf61aa
MA
15512011-09-25 Michael Albinus <michael.albinus@gmx.de>
1552
1553 * dbusbind.c (Fdbus_register_signal): When service is not
1554 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1555
32bbb17c
GM
15562011-09-25 Glenn Morris <rgm@gnu.org>
1557
1558 * buffer.c (truncate-lines): Doc fix.
1559
94e0933e
CY
15602011-09-24 Chong Yidong <cyd@stupidchicken.com>
1561
1562 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1563 (Fset_window_next_buffers): Doc fix.
1564
cddde921
GM
15652011-09-24 Glenn Morris <rgm@gnu.org>
1566
1567 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1568
1260aef1
PE
15692011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1570
25b4bfa0
PE
1571 Fix minor problems found by static checking.
1572 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
1573 * indent.c (Fvertical_motion): Fix == vs = typo.
1574
e3cbd34b
EZ
15752011-09-24 Eli Zaretskii <eliz@gnu.org>
1576
a66cfb1c
SM
1577 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1578 Default value is now t. Doc fix.
6bf7006f 1579
e3cbd34b 1580 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 1581 logic when moving up, not only when moving down. Fix the
e3cbd34b 1582 confusing name and values of the it_overshoot_expected variable;
32c1fffd 1583 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
1584
1585 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1586 CHARPOS is covered by a display string which includes newlines.
1587 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1588 is covered by a display string with embedded newlines.
1589
a3de0cbd
MA
15902011-09-24 Michael Albinus <michael.albinus@gmx.de>
1591
1592 * dbusbind.c (Fdbus_register_signal): Add match rule to
1593 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
1594 (Fdbus_register_method, Vdbus_registered_objects_table):
1595 Fix docstring.
a3de0cbd 1596
b260039d
JM
15972011-09-24 Jim Meyering <meyering@redhat.com>
1598
32c1fffd 1599 do not ignore write error for any output size
b260039d
JM
1600 The previous change was incomplete.
1601 While it makes emacs --batch detect the vast majority of stdout
1602 write failures, errors were still ignored whenever the output size is
1603 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1604 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1605 && echo FAIL: ignored write error
1606 FAIL: ignored write error
1607 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1608 && echo FAIL: ignored write error
1609 FAIL: ignored write error
1610 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1611
8eca8a7c
AS
16122011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1613
1614 * emacs.c (Fkill_emacs): In noninteractive mode exit
1615 non-successfully if a write error occurred on stdout. (Bug#9574)
1616
3341db62
EZ
16172011-09-21 Eli Zaretskii <eliz@gnu.org>
1618
1619 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1620 the xassert test.
1621
1622 * dispextern.h (struct it): Update the comment documenting what
1623 can it->OBJECT be.
1624
8c203dbf
EZ
16252011-09-20 Eli Zaretskii <eliz@gnu.org>
1626
1627 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1628 a display string, extend search for cursor position to end of row.
1629 (find_row_edges): If the row ends in a newline from a display
1630 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1631 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
1632 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1633 non-empty line. Fixes confusing cursor motion with arrow keys at
1634 the beginning of a line that starts with whitespace.
8c203dbf 1635
a4824228
LMI
16362011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1637
1638 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1639 (bug#9493).
1640
33ed493b
CY
16412011-09-18 Chong Yidong <cyd@stupidchicken.com>
1642
1643 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1644 boolean (Bug#9154).
1645
56cd55c8
EZ
16462011-09-18 Eli Zaretskii <eliz@gnu.org>
1647
1648 * xdisp.c (display_line): Record maximum and minimum buffer
1649 positions even if no glyphs were produced (e.g., by a zero-width
1650 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1651 buffer positions that will be removed from the glyph row because
1652 they don't fit.
c02dcedf
EZ
1653 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1654 column is beyond frame width: don't subtract 1 "pixel" when
1655 computing width of the stretch.
3e62b7e0
EZ
1656 (reseat_at_next_visible_line_start): Undo the change made on
1657 2011-09-17 that saved paragraph information and restored it after
1658 the call to `reseat'. (Bug#9545)
56cd55c8 1659
5ed99d36 16602011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
1661
1662 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1663 and turn window cursor on if cleared (Bug#9415).
1664
5ed99d36 16652011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
1666
1667 * search.c (boyer_moore): Take unibyte characters from pattern
1668 literally. (Bug#9458)
1669
9bade7b2
EZ
16702011-09-18 Eli Zaretskii <eliz@gnu.org>
1671
1672 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1673
e5e9d610
PE
16742011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1675
87e4427a
PE
1676 Fix minor problem found by static checking.
1677 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1678 initialized, to pacify gcc -Wuninitialized.
1679
e5e9d610
PE
1680 * fileio.c: Report proper errno when syscall falls.
1681 (Finsert_file_contents): Save and restore errno,
1682 so that report_file_error outputs the correct diagnostic.
1683 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1684
a1674f0b
EZ
16852011-09-18 Eli Zaretskii <eliz@gnu.org>
1686
1687 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1688
fbfb6dd4
EZ
16892011-09-17 Eli Zaretskii <eliz@gnu.org>
1690
1691 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1692 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1693
bb187662
EZ
16942011-09-17 Eli Zaretskii <eliz@gnu.org>
1695
1137e8b8 1696 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 1697 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
1698
1699 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1700 (bidi_find_paragraph_start): Search back for paragraph beginning
1701 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1702 (bidi_move_to_visually_next): Only trigger paragraph-related
1703 computations when the last character is a newline or at EOB, not
1704 just any NEUTRAL_B. (Bug#9470)
1705
bb187662
EZ
1706 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1707 truncated lines if point is covered by a display string. (Bug#9524)
1708
2e621251
PE
17092011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1710
1711 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1712 (cons_to_x_long): New function.
1713 (lisp_data_to_selection_data): Use it. Correct the test for
1714 short-versus-long data; it was negated. Break out of vector
1715 loop, for efficiency, when a long datum is discovered.
1716
91a15bc6
SM
17172011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1718
1719 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1720
b41c3a35
EZ
17212011-09-16 Eli Zaretskii <eliz@gnu.org>
1722
1723 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1724 GCC PR/17406) by declaring this function with external scope.
1725
7812ba2d
PE
17262011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1727
1728 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1729 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1730
cf7edc2a
AS
17312011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1732
1733 * editfns.c (Fformat): Correctly handle text properties on "%%".
1734
bd01620e
EZ
17352011-09-15 Eli Zaretskii <eliz@gnu.org>
1736
1737 * xterm.c (x_draw_composite_glyph_string_foreground):
1738 * w32term.c (x_draw_composite_glyph_string_foreground):
1739 * term.c (encode_terminal_code):
1740 * composite.c (composition_update_it, get_composition_id):
1741 * xdisp.c (get_next_display_element)
1742 (fill_composite_glyph_string): Add comments about special meaning
1743 of TAB characters in a composition.
1744
a02719a3
PE
17452011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1746
1747 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
1748 This occurs when processing a multibyte format.
1749 Problem reported by Wolfgang Jenker.
a02719a3 1750
72589a3c
JB
17512011-09-15 Johan Bockgård <bojohan@gnu.org>
1752
1753 * xdisp.c (try_cursor_movement): Only check for exact match if
1754 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1755
1c14176c
PE
17562011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1757
1758 Remove unused external symbols.
1759 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1760 * xdisp.c (calc_pixel_width_or_height): Now static.
1761 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1762 * indent.c (check_display_width):
1763 * w32term.c: Fix comment to match code.
1764 * xterm.c, xterm.h (x_catching_errors): Remove.
1765
d2eea5b5
PE
17662011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1767
1768 * xselect.c: Use signed conversions more consistently (Bug#9498).
1769 (selection_data_to_lisp_data): Assume incoming selection data are
1770 signed integers, not unsigned. This is to be consistent with
1771 outgoing selection data, which was modified to use signed integers
1772 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1773 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1774 expects long, not unsigned long.
1775
46888499
EZ
17762011-09-14 Eli Zaretskii <eliz@gnu.org>
1777
1778 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1779 computation of loop end. Reported by Johan Bockgård
1780 <bojohan@gnu.org>.
1781
ef8ef9fb
CY
17822011-09-13 Chong Yidong <cyd@stupidchicken.com>
1783
1784 * frame.c (Fother_visible_frames_p): Function deleted.
1785
fa819fed
EZ
17862011-09-12 Eli Zaretskii <eliz@gnu.org>
1787
1788 * indent.c (compute_motion): Process display vector front to back
1789 rather than the other way around. (Bug#2496)
1790
2ba8e008
SM
17912011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1792
1793 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1794
20f53c69
CY
17952011-09-11 Chong Yidong <cyd@stupidchicken.com>
1796
1797 * minibuf.c (Fread_from_minibuffer): Doc fix.
1798
d562d7a4
EZ
17992011-09-11 Eli Zaretskii <eliz@gnu.org>
1800
1801 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1802 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1803
1c4d7f3d
LMI
18042011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1805
1806 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1807 value for non-existent files.
1808
b885bf36
EZ
18092011-09-11 Eli Zaretskii <eliz@gnu.org>
1810
1811 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1812 set its "size" to -1. This will set the modtime_size field of
1813 the corresponding buffer to -1, which is what
1814 verify-visited-file-modtime expects for files that do not exist.
1815 (Bug#9139)
1816
6612f0bf
PE
18172011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1818
1819 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1820 here ...
1821 * lisp.h: ... from here. push_key_description is no longer
1822 defined in keyboard.c, so its declaration should not be in
1823 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1824 logically belongs with push_key_description.
1825
dfb3f755
PE
18262011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1827
1828 * buffer.h: Include <sys/types.h> instead of <time.h>.
1829 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1830 Problem reported by Herbert J. Skuhra.
1831
3134906c
LMI
18322011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1833
1834 * xml.c (parse_region): Make the parsing work for
1835 non-comment-starting XML files again (bug#9144).
1836
8d903f4e
AS
18372011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1838
1839 * image.c (gif_load): Fix calculation of bottom and right corner.
1840 (Bug#9468)
1841
80ad64f4
EZ
18422011-09-10 Eli Zaretskii <eliz@gnu.org>
1843
1844 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1845 redisplay in small windows.
1846
208a048d
EZ
18472011-09-09 Eli Zaretskii <eliz@gnu.org>
1848
1849 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1850
9b1c252e
MR
18512011-09-08 Martin Rudalics <rudalics@gmx.at>
1852
1853 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1854 Operate on live windows only.
1855
2949f33b
JB
18562011-09-08 Juanma Barranquero <lekktu@gmail.com>
1857
1858 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1859
e08dcafd
EZ
18602011-09-07 Eli Zaretskii <eliz@gnu.org>
1861
1862 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1863 only under bidi iteration.
1864
115b96bd
JD
18652011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1866
1867 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1868
c8199d0f
PE
18692011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1870
1871 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1872 Without this fix, the command to link temacs failed due to an
1873 undefined symbol __builtin_isnan. This is because
1874 /usr/include/iso/math_c99.h #defines isnan(x) to
1875 __builtin_isnan(x), but the bundled gcc, which identifies itself
1876 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1877 a __builtin_isnan.
1878 * floatfns.c (isnan): #undef, and then #define to a clone of
1879 what's in data.c.
1880 (Fisnan): Always define, since it's always available now.
1881 (syms_of_floatfns): Always define isnan at the Lisp level.
1882
e39b275c 18832011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
1884
1885 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1886
b2db44d9 18872011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 1888
f4af5137 1889 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
1890 The previous code assumed that file offsets (off_t values) fit in
1891 EMACS_INT variables, which is not true on typical 32-bit hosts.
1892 The code messed up by falsely reporting buffer overflow in cases
1893 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1894 when "big" contains more than 2**29 bytes, even though this
1895 inserts just one byte and does not overflow the buffer.
1896 (Finsert_file_contents): Store file offsets as off_t
1897 values, not as EMACS_INT values. Check for overflow when
1898 converting between EMACS_INT and off_t. When checking for
1899 buffer overflow or for overlap, take the offsets into account.
1900 Don't use EMACS_INT for small values where int suffices.
1901 When checking for overlap, fix a typo: ZV was used where
1902 ZV_BYTE was intended.
1903 (Fwrite_region): Don't assume off_t fits into 'long'.
1904 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1905
ecfc0a49
MA
19062011-09-05 Michael Albinus <michael.albinus@gmx.de>
1907
1908 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1909
6511acf2 19102011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 1911
0999621a 1912 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
1913
1914 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 1915 (esprintf, exprintf, evxprintf): New functions.
62f19c19 1916 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 1917 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
1918 (modify_event_symbol): Do not assume that the length of
1919 name_alist_or_stem is safe to alloca and fits in int.
1920 (Fexecute_extended_command): Likewise for function name and binding.
1921 (Frecursion_depth): Wrap around reliably on integer overflow.
1922 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1923 since some callers pass EMACS_INT values.
1924 (Fsingle_key_description): Don't crash if symbol name contains more
1925 than MAX_ALLOCA bytes.
1926 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1927 (get_minibuffer): Arg is now EMACS_INT, not int.
1928 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 1929 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
1930 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1931
2be7d702
PE
1932 * dbusbind.c (signature_cat): New function.
1933 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
1934 Do not overrun buffer; instead, report string overflow.
1935
9d1df220
PE
1936 * dispnew.c (add_window_display_history): Don't overrun buffer.
1937 Truncate instead; this is OK since it's just a log.
1938
33ef5c64
PE
1939 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1940 even if the time zone offset is outlandishly large.
1941 Don't mishandle offset == INT_MIN.
1942
66c6fdd5
PE
1943 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1944 when creating daemon; the previous buffer-overflow check was incorrect.
1945
d749b01b
PE
1946 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1947 which has the guts of the old verror function.
1948
b5cd1905
PE
1949 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1950 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1951
6e1a67fb
PE
1952 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1953 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 1954 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 1955 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
1956 length of string rather than counting it via multiple sprintfs;
1957 that's simpler and more reliable.
c21721cc
PE
1958 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1959 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1960 sprintf, in case result does not fit in int.
1961
c57b67fc
PE
1962 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1963 (fontset_from_font): Print it.
1964
8a401434
PE
1965 * frame.c (tty_frame_count): Now printmax_t, not int.
1966 (make_terminal_frame, set_term_frame_name): Print it.
1967 (x_report_frame_params): In X, window IDs are unsigned long,
1968 not signed long, so print them as unsigned.
1969 (validate_x_resource_name): Check for implausibly long names,
1970 and don't assume name length fits in 'int'.
1971 (x_get_resource_string): Don't blindly alloca invocation name;
1972 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1973 not fit in int.
1974
6e1a67fb
PE
1975 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1976 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
1977 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1978
0df02bf3
PE
1979 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1980 Use esprintf, not sprintf, in case result does not fit in int.
1981
48e30793
PE
1982 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1983 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1984 it as a large positive number.
1985 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1986 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1987
a66ff6d8
PE
1988 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1989 in case result does not fit in int.
1990
aca216ff
PE
1991 * print.c (float_to_string): Detect width overflow more reliably.
1992 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1993 buffer overrun. Don't assume list length fits in 'int'. Treat
1994 print length of 0 as 0, not as infinity; to be consistent with other
1995 uses of print length in this function. Don't overflow print length
1996 index. Don't assume hash table size fits in 'long', or that
1997 vectorlike size fits in 'unsigned long'.
1998
31c286f7
PE
1999 * process.c (make_process): Use printmax_t, not int, to format
2000 process-name gensyms.
2001
55e5faa1
PE
2002 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2003
80f2e268
PE
2004 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2005 to avoid potential buffer overrun.
2006
670741ab
PE
2007 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2008 if X resource line is longer than 512 bytes.
2009
b7163a50
PE
2010 * xfns.c (x_window): Make sprintf buffer a bit bigger
2011 to avoid potential buffer overrun.
2012
ae58ff1f
PE
2013 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2014
c43c8a6a
PE
2015 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2016
3f8236f4
PE
20172011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2018
53e9fe90 2019 Integer overflow fixes for scrolling, etc.
6511acf2
PE
2020 Without these, Emacs silently mishandles large integers sometimes.
2021 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
2022 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2023
6511acf2
PE
2024 * xdisp.c (try_window_id): Check Emacs fixnum range before
2025 converting to 'int'.
806add1d 2026
6511acf2 2027 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
2028 Check that an Emacs fixnum is in range before assigning it to 'int'.
2029 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2030 values converted from Emacs fixnums.
2031 (Frecenter): Don't wrap around a line count if it is out of 'int'
2032 range; instead, treat it as an extreme value.
2033 (Fset_window_configuration, compare_window_configurations):
2034 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2035
6511acf2
PE
2036 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2037 that can exceed INT_MAX. Check that EMACS_INT value is in range
2038 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
2039 (match_limit): Don't assume that a fixnum can fit in 'int'.
2040
6511acf2 2041 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
2042 exceed INT_MAX.
2043
6511acf2 2044 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
2045 (Fvertical_motion): Don't wrap around LINES values that don't fit
2046 in 'int'. Instead, treat them as extreme values. This is good
2047 enough for windows, which can't have more than INT_MAX lines anyway.
2048
fcb901a7
LMI
20492011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2050
0f2f6b6d
LMI
2051 * Require libxml/parser.h to avoid compilation warning.
2052
fcb901a7
LMI
2053 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2054
2055 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2056 since this reportedly can destroy thread storage.
2057
6e20a0d4
CY
20582011-08-30 Chong Yidong <cyd@stupidchicken.com>
2059
2060 * syntax.c (find_defun_start): Update all cache variables if
2061 exiting early (Bug#9401).
2062
148ae00e
EZ
20632011-08-30 Eli Zaretskii <eliz@gnu.org>
2064
f6cfbd8f
EZ
2065 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2066
148ae00e
EZ
2067 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2068 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2069 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2070
2071 * term.c (tty_append_glyph): New function.
2072 (produce_stretch_glyph): Static function and its prototype deleted.
2073
a66cfb1c
SM
2074 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2075 Add prototypes.
148ae00e 2076
c4a07a4c
PE
20772011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2078
2079 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2080 when checking :margin (Bug#9390).
2081 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 2082 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
2083 so that the name doesn't mislead. All uses changed.
2084
6bc8cd65
JB
20852011-08-28 Johan Bockgård <bojohan@gnu.org>
2086
2087 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2088 set_tty_hooks.
2089
dca4927e
EZ
20902011-08-27 Eli Zaretskii <eliz@gnu.org>
2091
2092 * xdisp.c (move_it_to): Don't bail out early when reaching
2093 position beyond to_charpos, if we are scanning backwards.
2094 (move_it_vertically_backward): When DY == 0, make sure we get to
2095 the first character in the line after the newline.
2096
f2cad773
PE
20972011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2098
2099 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2100 (ccl_driver): Do not generate an out-of-range pointer.
2101 (Fccl_execute_on_string): Remove unnecessary check for
2102 integer overflow, noted by Stefan Monnier in
2103 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2104 Remove a FIXME that didn't need fixing.
2105 Simplify the newly-introduced buffer reallocation code.
2106
0cae2cdb
JB
21072011-08-27 Juanma Barranquero <lekktu@gmail.com>
2108
2109 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2110
5fc295a4 21112011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 2112
70c60eb2 2113 Integer and memory overflow issues (Bug#9196).
726e0ab1 2114
d31850da
PE
2115 * doc.c (get_doc_string): Rework so that
2116 get_doc_string_buffer_size is the actual buffer size, rather than
2117 being 1 less than the actual buffer size; this makes xpalloc more
2118 convenient.
2119
a69fbedb
PE
2120 * image.c (x_allocate_bitmap_record, cache_image):
2121 * xselect.c (Fx_register_dnd_atom):
2122 Simplify previous changes by using xpalloc.
2123
fe5c5d37
PE
2124 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2125 since either will do and ptrdiff_t is convenient with xpalloc.
2126
0065d054
PE
2127 * charset.c (charset_table_size)
2128 (struct charset_sort_data.priority): Now ptrdiff_t.
2129 (charset_compare): Don't overflow if priorities differ greatly.
2130 (Fsort_charsets): Don't assume list length fits in int.
2131 Check for size-calculation overflow when allocating sort data.
2132 (syms_of_charset): Allocate an initial charset table that is
2133 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2134
2135 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2136
2137 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2138 The actual value is always <= INT_MAX, and leaving it unsigned made
2139 overflow checking harder.
2140
2141 * dispextern.h (struct glyph_matrix.rows_allocated)
2142 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2143 with xpalloc. The values are still always <= INT_MAX.
2144
2145 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2146
2147 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2148 (SAFE_NALLOCA): New macro.
2149
2150 * region-cache.c (struct boundary.pos, find_cache_boundary)
2151 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2152 (set_cache_region, invalidate_region_cache)
2153 (revalidate_region_cache, know_region_cache, region_cache_forward)
2154 (region_cache_backward, pp_cache):
2155 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2156 so that ptrdiff_t * can be passed to xpalloc.
2157 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2158 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2159 (pp_cache): Don't assume cache_len fits in int.
2160 * region-cache.h: Adjust extern decls to match.
2161
2162 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2163 EMACS_INT, since either will do, for xpalloc.
2164
2165 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2166 (xnmalloc, xnrealloc, xpalloc): New functions.
2167
726e0ab1
PE
2168 * bidi.c (bidi_shelve_header_size): New constant.
2169 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2170 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2171
51f30bc5 2172 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
2173 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2174 (overlay_strings):
2175 Don't update size of array until after memory allocation succeeds,
2176 because xmalloc/xrealloc may not return.
0065d054
PE
2177 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2178 now that we have proper integer overflow checking.
2179 (record_overlay_string, overlay_strings): Catch overflows when
2180 calculating size of overlay_str_buf.
726e0ab1 2181
0065d054
PE
2182 * callproc.c (Fcall_process): Check for size overflow when
2183 calculating size of args2.
2184 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2185 Normally we prefer signed values, but sticking with ptrdiff_t would
2186 require adding more-complicated checks.
726e0ab1
PE
2187
2188 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2189 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2190 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 2191 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
2192
2193 * character.c (Fstring): Check for size-calculation overflow.
2194
2195 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2196 unnecessary integer overflow. Check for size overflow.
2197 (encode_coding_object): Don't update size until xmalloc succeeds.
2198
2199 * composite.c (get_composition_id): Check for overflow in glyph
2200 length calculations.
2201
2202 Integer and memory overflow fixes for display code.
2203 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2204 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2205 (scrolling_window): Check for overflow in size calculations.
2206 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2207 Don't assume glyph table len fits in int.
2208 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2209 (row_table_size): Now ptrdiff_t, not int.
2210 (scrolling_window): Avoid overflow in size calculations.
2211 Don't update size until allocation succeeds.
2212 * fns.c (concat): Check for overflow in size calculations.
2213 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2214 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2215 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2216
2217 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2218 (get_doc_string): Check for size calculation overflow.
2219 Don't update size until allocation succeeds.
2220 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2221 EMACS_INT, where ptrdiff_t will do.
2222 (Fsubstitute_command_keys): Check for string overflow.
2223
2224 * editfns.c (set_time_zone_rule): Don't assume environment length
2225 fits in int.
2226 (message_length): Now ptrdiff_t, not int.
2227 (Fmessage_box): Don't update size until allocation succeeds.
2228 Don't assume message length fits in int.
2229 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2230
0065d054
PE
2231 * emacs.c (main): Do not reallocate argv, since there is a null at
2232 the end that can be overwritten, and this way there's no need to
2233 worry about size-calculation overflow.
2234 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
2235
2236 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2237 alloc succeeds.
2238 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2239
2240 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2241 (x_set_scroll_bar_width, x_figure_window_size):
2242 Check for integer overflow.
2243 (x_set_alpha): Do not assume XINT fits in int.
2244
2245 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2246 This is for the members text_lines, text_cols, total_lines, total_cols,
2247 where the system imposes an 'int' limit.
2248
2249 * fringe.c (Fdefine_fringe_bitmap):
2250 Don't update size until alloc works.
2251
2252 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2253 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2254
2255 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2256 Check for size-calculation overflow.
2257 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2258 do, as we prefer signed integers.
2259 (id_to_widget.max_size, id_to_widget.used)
2260 (xg_store_widget_in_map, xg_remove_widget_from_map)
2261 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2262 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2263 Use and return ptrdiff_t, not int.
2264 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2265 * gtkutil.h: Change prototypes to match the above.
2266
2267 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2268 are duplicate now that they've been promoted to lisp.h.
2269 (x_allocate_bitmap_record, x_alloc_image_color)
2270 (make_image_cache, cache_image, xpm_load):
2271 Don't update size until alloc is done.
2272 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2273 (x_detect_edges):
3256efce 2274 Check for size calculation overflow.
726e0ab1
PE
2275 (ct_colors_allocated_max): New constant.
2276 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2277 overflow.
3256efce 2278
726e0ab1
PE
2279 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2280 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2281 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2282 Use ptrdiff_t, not int, to count maps.
2283 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
2284 calculations. Don't update size until allocation succeeds.
2285 Redo calculations to avoid overflow.
726e0ab1
PE
2286 * keyboard.h: Change prototypes to match the above.
2287
2288 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2289 to count maps.
2290 (current_minor_maps): Check for size calculation overflow.
2291 * keymap.h: Change prototypes to match the above.
2292
2293 * lread.c (read1, init_obarray): Don't update size until alloc done.
2294
2295 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2296 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2297
726e0ab1
PE
2298 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2299 Now ptrdiff_t, not int.
2300 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2301 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2302
2303 * process.c (Fnetwork_interface_list): Check for overflow
2304 in size calculation.
2305
2306 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2307
2308 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2309 overflow. Don't bother calling xmalloc when xrealloc will do.
2310
2311 * search.c (Freplace_match): Check for size calculation overflow.
2312 (Fset_match_data): Don't assume list lengths fit in 'int'.
2313
2314 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2315 for command line length. Do not attempt to address one before the
2316 beginning of an array, as that's not portable.
2317
2318 * term.c (max_frame_lines): Remove; unused.
2319 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2320 not int.
2321 (encode_terminal_code, calculate_costs): Check for size
2322 calculation overflow.
2323 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2324 table lengths and related sizes. Don't update size until alloc
2325 done. Redo calculations to avoid overflow.
2326 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2327
2328 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2329 subtracting pointers.
2330 (gobble_line): Check for overflow more carefully. Don't update size
2331 until alloc done.
2332
2333 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2334 Don't update size until alloc done.
2335 Redo size calculations to avoid overflow.
2336 Check for size calculation overflow.
0065d054 2337 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
2338
2339 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2340 Use ptrdiff_t, not int, for sizes.
2341 (store_mode_line_noprop_char): Don't update size until alloc done.
2342
0065d054
PE
2343 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2344 Use ptrdiff_t, not int, for sizes.
2345 (Finternal_make_lisp_face, cache_face):
2346 Check for size calculation overflow.
2347 (cache_face): Treat size calculation overflows as if they were
2348 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
2349
2350 * xfns.c (x_encode_text, x_set_name_internal)
2351 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2352 sizes, since they can exceed INT_MAX in size. Check for size
2353 calculation overflow.
2354
0065d054
PE
2355 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2356 (xg_select): Check for size calculation overflow.
726e0ab1
PE
2357 Don't update size until alloc done.
2358
0065d054 2359 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 2360 as sprintf is limited to int lengths.
1d526e2f 2361
252c5ee1
PE
2362 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2363 (X_LONG_MIN): New macros.
864d7ce7
PE
2364 Use them to make the following changes clearer.
2365 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2366 This change doesn't affect the value now, but it may help remind
2367 future maintainers not to raise the value too much later.
2368 (SELECTION_QUANTUM): Remove, replacing with ...
2369 (selection_quantum): ... new function, which avoids overflow.
2370 All uses changed.
2371 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2372 assumption that selection length fits in 'int'.
2373 (x_reply_selection_request, x_handle_selection_request)
2374 (x_get_window_property, receive_incremental_selection)
2375 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2376 (lisp_data_to_selection_data, clean_local_selection_data):
2377 Use ptrdiff_t, not int, to record length of selection.
2378 (x_reply_selection_request, x_get_window_property)
2379 (receive_incremental_selection, x_property_data_to_lisp):
2380 Redo calculations to avoid overflow.
2381 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 2382 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
2383 something.
2384 (x_get_window_property, receive_incremental_selection)
2385 (lisp_data_to_selection_data, x_property_data_to_lisp):
2386 Check for size-calculation overflow.
2387 (x_get_window_property, receive_incremental_selection)
2388 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2389 Don't store size until memory allocation succeeds.
2390 (x_get_window_property): Plug memory leak on memory exhaustion.
2391 Don't double-block input; malloc is safe here. Don't assume 2**34
2392 - 4 fits in unsigned long. Add an xassert to check
2393 XGetWindowProperty overflow. Be more careful about overflow
2394 calculations, and distinguish size from memory overflow better.
2395 (receive_incremental_selection): When tracing, don't assume
2396 unsigned int is less than INT_MAX.
2397 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2398 harmful) conversions of unsigned short to int.
2399 (lisp_data_to_selection_data): Don't assume that integers
2400 in the range -65535 through -1 fit in an X unsigned short.
2401 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2402 result parameters unless successful. Rely on cons_to_unsigned
2403 to report problems with elements; the old code wasn't right anyway.
2404 (x_check_property_data): Check for int overflow; we cannot use
2405 a wider type due to X limits.
2406 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2407
726e0ab1 2408 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 2409
0065d054
PE
2410 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2411 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
2412 (x_color_cells): Don't store size until memory allocation succeeds.
2413 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 2414 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
2415 (x_term_init): Don't assume length fits in int (sprintf is limited
2416 to int size).
bc18e09d 2417
ebfa62c0
PE
2418 Use ptrdiff_t for composition IDs.
2419 * character.c (lisp_string_width):
2420 * composite.c (composition_table_size, n_compositions)
2421 (get_composition_id, composition_gstring_from_id):
2422 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2423 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2424 * window.c (Frecenter):
2425 Use ptrdiff_t, not int, for composition IDs.
2426 * composite.c (get_composition_id): Check for integer overflow.
2427 * composite.h: Adjust prototypes to match the above changes.
2428
d3411f89
PE
2429 Use ptrdiff_t for hash table indexes.
2430 * category.c (hash_get_category_set):
2431 * ccl.c (ccl_driver):
2432 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2433 * coding.c (coding_system_charset_list, detect_coding_system):
2434 * coding.h (struct coding_system.id):
2435 * composite.c (get_composition_id, gstring_lookup_cache):
2436 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2437 * image.c (xpm_get_color_table_h):
2438 * lisp.h (hash_lookup, hash_put):
2439 * minibuf.c (Ftest_completion):
2440 Use ptrdiff_t for hash table indexes, not int (which is too
2441 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2442 32-bit --with-wide-int hosts).
2443
e097a6fa
PE
2444 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2445 Add a FIXME comment about memory leaks.
2446 (syms_of_charset): Don't assume xmalloc returns.
2447
5637687f
PE
2448 Don't assume that stated character widths fit in int.
2449 * character.c (Fchar_width, c_string_width, lisp_string_width):
2450 * character.h (CHAR_WIDTH):
2451 * indent.c (MULTIBYTE_BYTES_WIDTH):
2452 Use sanitize_char_width to avoid undefined and/or bad behavior
2453 with outlandish widths.
a66cfb1c 2454 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
2455 now that we have two such functions. All uses changed.
2456 (sanitize_char_width): New inline function.
2457
a2271ba2
PE
2458 Don't assume that tab-width fits in int.
2459 * character.h (sanitize_width): New inline function.
2460 (SANE_TAB_WIDTH): New macro.
2461 (ASCII_CHAR_WIDTH): Use it.
2462 * indent.c (sane_tab_width): Remove. All uses replaced by
2463 SANE_TAB_WIDTH (current_buffer).
2464 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2465
18c52557
PE
2466 * fileio.c: Integer overflow issues with file modes.
2467 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2468
caeeedc1
PE
2469 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2470 Remove unreachable code.
2471 (read_hex, load_charset_map_from_file): Check for integer overflow.
2472
6df6ae42 2473 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
2474 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2475 (x_send_scroll_bar_event): Likewise. Check that the size does not
2476 exceed limits imposed by XClientMessageEvent, as well as the usual
2477 ptrdiff_t and size_t limits.
2478
b13995db
PE
2479 * keyboard.c: Overflow, signedness and related fixes.
2480 (make_lispy_movement): Use same integer type in forward decl
2481 that is used in the definition.
2482 (read_key_sequence, keyremap_step):
2483 Change bufsize argument back to int, undoing my 2011-03-30 change.
2484 We prefer signed types, and int is wide enough here.
2485 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2486 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2487 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2488 length, not size_t. Use ptrdiff_t for index, not int.
2489 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2490 possibility of integer overflow.
2491
13464394
PE
2492 Overflow, signedness and related fixes for images.
2493
2494 * dispextern.h (struct it.stack[0].u.image.image_id)
2495 (struct_it.image_id, struct image.id, struct image_cache.size)
2496 (struct image_cache.used, struct image_cache.ref_count):
2497 * gtkutil.c (update_frame_tool_bar):
2498 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2499 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2500 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2501 * nsmenu.m (update_frame_tool_bar):
2502 * xdisp.c (calc_pixel_width_or_height):
2503 * xfns.c (image_cache_refcount):
2504 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2505 on typical 64-bit hosts.
2506
2507 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2508 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2509 Omit unnecessary casts to int.
2510 (parse_image_spec): Check that integers fall into 'int' range
2511 when the callers expect that.
2512 (image_ascent): Redo ascent calculation to avoid int overflow.
2513 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2514 (lookup_image): Remove unnecessary tests.
2515 (xbm_image_p): Locals are now of int, not EMACS_INT,
2516 since parse_image_check makes sure they fit into int.
2517 (png_load, gif_load, svg_load_image):
2518 Prefer int to unsigned where either will do.
2519 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
2520 old tiff_error_handler and tiff_warning_handler.
2521 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
2522 stack buffer overflows. It uses only the features of vsnprintf
2523 that are common to both POSIX and native Microsoft.
2524 (tiff_error_handler, tiff_warning_handler): Use it.
2525 (tiff_load, gif_load, imagemagick_load_image):
2526 Don't assume :index value fits in 'int'.
2527 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2528 (imagemagick_load_image): Check that crop parameters fit into
2529 the integer types that MagickCropImage accepts. Don't assume
2530 Vimagemagick_render_type has a nonnegative value. Don't assume
2531 size_t fits in 'long'.
2532 (gs_load): Use printmax_t to print the widest integers possible.
2533 Check for integer overflow when computing image height and width.
2534
c11821d4
EZ
25352011-08-26 Eli Zaretskii <eliz@gnu.org>
2536
2537 * xdisp.c (redisplay_window): Don't force window start if point
2538 will be invisible in the resulting window. (Bug#9324)
2539
0c95fcf7
EZ
25402011-08-25 Eli Zaretskii <eliz@gnu.org>
2541
2542 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2543 the display spec is of the form `(space ...)'.
2544 (handle_display_spec): Return the value returned by
2545 handle_single_display_spec, not just 1 or zero.
2546 (handle_single_display_spec): If the display spec is of the form
2547 `(space ...)', and specifies display in the text area, return 2
2548 rather than 1.
fee65a97 2549 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
2550 accurately, and prefer exact match for point under bidi.
2551 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
2552
2553 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2554 into disp_prop; all users changed.
2555
2556 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2557 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2558 for the text covered by the display property.
2559
e4ed06f1
CY
25602011-08-25 Chong Yidong <cyd@stupidchicken.com>
2561
2562 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2563 Change return value to nil.
2564 (Frecord_buffer): Delete unused function.
2565
f67cdd7f
EZ
25662011-08-24 Eli Zaretskii <eliz@gnu.org>
2567
5980d4c6
EZ
2568 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2569 buffers, return left-to-right.
8610fe8b
EZ
2570 (set_cursor_from_row): Consider candidate row a win if its glyph
2571 represents a newline and point is on that newline. Fixes cursor
2572 positioning on the newline at EOL of R2L text within L2R
2573 paragraph, and vice versa.
2574 (try_cursor_movement): Check continued rows, in addition to
2575 continuation rows. Fixes unwarranted scroll when point enters a
2576 continued line of R2L text within an L2R paragraph, or vice versa.
2577 (cursor_row_p): Consider the case of point being equal to
2578 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2579 from the end of a short line to the beginning of a continued line
2580 of R2L text within L2R paragraph.
2581 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2582 composed characters.
5980d4c6 2583
f67cdd7f
EZ
2584 * bidi.c (bidi_check_type): Use xassert.
2585 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2586 members.
2587
bca633fb
EZ
25882011-08-23 Eli Zaretskii <eliz@gnu.org>
2589
2590 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2591 a character.
2592
4a5885a7
CY
25932011-08-23 Chong Yidong <cyd@stupidchicken.com>
2594
2595 * nsfont.m (ns_otf_to_script): Fix typo.
2596
0902a04e
KH
25972011-08-22 Kenichi Handa <handa@m17n.org>
2598
2599 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2600 extra slot even if the purpose is char-code-property-table.
2601
1a2e6670
EZ
26022011-08-23 Eli Zaretskii <eliz@gnu.org>
2603
8ddde651
EZ
2604 * xdisp.c (redisplay_window): When computing centering_position,
2605 account for the height of the header line. (Bug#8874)
2606
425cc014
EZ
2607 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2608 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2609 candidate is selected by the mouse, and that candidate has a
2610 composed character under the mouse.
2611
1a2e6670
EZ
2612 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2613 coordinates reported by pos-visible-in-window-p for a composed
2614 character in column zero.
2615
8b76d6f8
SM
26162011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2617
2618 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2619
dac347dd
EZ
26202011-08-22 Eli Zaretskii <eliz@gnu.org>
2621
2622 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2623 consider it a hit if to_charpos is anywhere in the range of the
2624 composed buffer positions.
2625
e013fb34
CY
26262011-08-22 Chong Yidong <cyd@stupidchicken.com>
2627
2628 * image.c (gif_load): Don't assume that each subimage has the same
2629 dimensions as the base image. Handle disposal method that is
2630 "undefined" by the gif spec (Bug#9335).
2631
bd1ba3e8
CY
26322011-08-20 Chong Yidong <cyd@stupidchicken.com>
2633
2634 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 2635 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 2636
54a1215b
EZ
26372011-08-19 Eli Zaretskii <eliz@gnu.org>
2638
823564e5
EZ
2639 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2640 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2641 from an Org mode buffer to a Speedbar frame.
2642
54a1215b
EZ
2643 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2644 a composition, take its buffer position from IT->cmp_it.charpos.
2645 Fixes cursor positioning at the beginning of a line that begins
2646 with a composed character.
2647
9778ebcc
EZ
26482011-08-18 Eli Zaretskii <eliz@gnu.org>
2649
0be6ee06
EZ
2650 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2651 character bidirectional type, use STRONG_L instead. Fixes crashes
2652 in a buffer produced by `describe-categories'.
2653
9778ebcc
EZ
2654 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2655 members before the level stack, so they would be saved and
2656 restored when copying iterator state. Fixes incorrect reordering
2657 around TABs covered by display properties.
2658
156bffbe
AS
26592011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2660
6b02f655 2661 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 2662
72ad093b
CY
26632011-08-17 Chong Yidong <cyd@stupidchicken.com>
2664
2665 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
2666 (internal_condition_case_2, internal_condition_case_n):
2667 Remove unnecessary aborts (Bug#9081).
72ad093b 2668
35774242
EZ
26692011-08-17 Eli Zaretskii <eliz@gnu.org>
2670
2671 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2672 has no `load' handler, try opening the file locally. (Bug#9311)
2673
db76dd85
KB
26742011-08-16 Ken Brown <kbrown@cornell.edu>
2675
2676 * gmalloc.c: Expand comment.
2677
b215eee5
EZ
26782011-08-16 Eli Zaretskii <eliz@gnu.org>
2679
2680 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2681 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2682
a4579d33
KB
26832011-08-16 Ken Brown <kbrown@cornell.edu>
2684
2685 Fix memory allocation problems in Cygwin build (Bug#9273).
2686
2687 * unexcw.c ( __malloc_initialized): Declare external variable.
2688 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2689
8b76d6f8
SM
2690 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2691 New variables.
a4579d33
KB
2692 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2693 dumped emacs.
2694 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2695 in the static heap.
2696 [CYGWIN] (special_realloc): New function.
2697 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2698 requests to realloc storage in the static heap.
2699
3ebec551
PE
27002011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2701
2702 * bidi.c (bidi_initialize): Remove unused local.
2703
9fd8be00
EZ
27042011-08-15 Eli Zaretskii <eliz@gnu.org>
2705
6b02f655
SM
2706 * bidimirror.h:
2707 * biditype.h: Remove file.
2708 * makefile.w32-in ($(BLD)/bidi.$(O)):
2709 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
2710
2711 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2712
2713 * chartab.c: Improve commentary for the uniprop_table API.
2714
32413314
EZ
2715 * bidi.c (bidi_paragraph_init): Support zero value of
2716 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
2717 (bidi_initialize): Use uniprop_table instead of including
2718 biditype.h and bidimirror.h.
32413314 2719
9fd8be00
EZ
2720 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2721 coordinates of the iterator when restoring from ppos_it.
2722 (Bug#9296)
2723
5cf2b69b
KH
27242011-08-14 Kenichi Handa <handa@m17n.org>
2725
2726 * process.c (create_process): Call setup_process_coding_systems
72ad093b 2727 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 2728
daf17d00
EZ
27292011-08-14 Eli Zaretskii <eliz@gnu.org>
2730
2731 * xdisp.c (move_it_in_display_line_to): Don't invoke
2732 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2733 ppos_it. Fixes vertical cursor motion when line beginning is
2734 covered by an image. (Bug#9296)
2735
08e3161a
JD
27362011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2737
2738 * nsterm.h (ns_run_ascript): Declare.
2739 (NSAPP_DATA2_RUNASSCRIPT): Define.
2740
2741 * nsfns.m (as_script, as_result, as_status): New static variables.
2742 (ns_run_ascript): New function.
5e617bc2 2743 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
2744 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2745 the event loop. Get status from as_status (Bug#7276).
2746
2747 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2748 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2749 the event loop (Bug#7276).
2750
a3720aa2
AS
27512011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2752
2753 * gnutls.c (QCgnutls_bootprop_priority)
2754 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2755 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2756 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2757 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2758 (QCgnutls_bootprop_verify_hostname_error)
2759 (QCgnutls_bootprop_callbacks_verify): Rename from
2760 Qgnutls_bootprop_..., all uses changed.
2761
2762 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2763 uses changed.
2764
0a0d27fb
PE
27652011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2766
19d5c50c
PE
2767 * xfaces.c (Qframe_set_background_mode): Now static.
2768 * dispextern.h (Qframe_set_background_mode): Remove decl.
2769
0a0d27fb
PE
2770 * process.c (Fnetwork_interface_info): Declare local only if needed.
2771
377538cb
JD
27722011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2773
2774 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2775 (Fnetwork_interface_list): Allocate in increments of bytes instead
2776 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2777 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2778 sockaddr.
2779 (struct ifflag_def): notrailers is smart on OSX.
2780 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2781 Get hardware address with getifaddrs if available.
2782
08fff70c
EZ
27832011-08-12 Eli Zaretskii <eliz@gnu.org>
2784
2785 * xdisp.c (iterate_out_of_display_property): xassert that
2786 IT->position is set to within IT->object's boundaries. Break from
2787 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
2788 when IT->position is set up wrongly due to some bug.
2789 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
2790 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2791 entry. Force push_it to save on the stack the current
2792 buffer/string position, to be restored by pop_it. Fix flags in
2793 the iterator structure wrt the object coming from a display
2794 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2795 properties. (Bug#9284)
2796
7be1c708 27972011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 2798
7be1c708
CY
2799 * fontset.c (fontset_get_font_group): Add proper type checks.
2800 (Bug#9172)
aac0c6e3 2801
7be1c708 28022011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 2803
7be1c708
CY
2804 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2805 and LC_VERSION_MIN_MACOSX.
2806 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2807 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 2808
97bb72a6
EZ
28092011-08-08 Eli Zaretskii <eliz@gnu.org>
2810
2811 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
2812 no-display-properties-and-no-overlays under bidi display.
2813 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 2814 properties and overlays.
97bb72a6 2815
d5617611
CY
28162011-08-08 Chong Yidong <cyd@stupidchicken.com>
2817
37e11a63
CY
2818 * editfns.c (Fset_time_zone_rule): Document relationship with the
2819 setenv function.
2820
d5617611
CY
2821 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2822 the font entity extracted from the cache (Bug#8109).
2823
58872834
CY
28242011-08-07 Chong Yidong <cyd@stupidchicken.com>
2825
2826 * composite.c (autocmp_chars): Don't reset point. That is done by
2827 restore_point_unwind (Bug#5984).
2828
75bfc667
JL
28292011-08-07 Juri Linkov <juri@jurta.org>
2830
2831 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2832 to show the arg `TIME' instead of `TIMEVAL'.
2833
d1410150
EZ
28342011-08-06 Eli Zaretskii <eliz@gnu.org>
2835
2836 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2837 display property strides EOL and includes a newline, as in
2838 longlines-mode. (Bug#9254)
75b771e4
EZ
2839 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2840 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
2841
2842 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2843 is non-zero, even if the data buffer is NULL. Fixes a crash in
2844 vertical-motion with longlines-mode. (Bug#9254)
2845
35928349
EZ
28462011-08-05 Eli Zaretskii <eliz@gnu.org>
2847
ec7cc85b
EZ
2848 * bidi.c <bidi_cache_total_alloc>: Now static.
2849 (bidi_initialize): Initialize bidi_cache_total_alloc.
2850
8b76d6f8 2851 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
2852 cache. (Bug#9221)
2853
2854 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2855 amount allocated this far in `bidi_cache_total_alloc'.
2856 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2857 non-zero, only free the data buffer without restoring the cache
2858 contents. All callers changed.
2859
2860 * dispextern.h (bidi_unshelve_cache): Update prototype.
2861
2862 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2863 (move_it_in_display_line, move_it_to)
2864 (move_it_vertically_backward, move_it_by_lines): Replace the call
2865 to xfree to an equivalent call to bidi_unshelve_cache.
2866 (move_it_in_display_line_to): Fix logic of returning
412b6358 2867 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 2868
e2e2423b
EZ
28692011-08-05 Eli Zaretskii <eliz@gnu.org>
2870
2871 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2872 came from a string character with a `cursor' property. (Bug#9229)
2873
ae9e757a
JD
28742011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2875
2876 * Makefile.in (LIB_PTHREAD): New variable.
2877 (LIBES): Add LIB_PTHREAD (Bug#9216).
2878
2879 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2880 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2881
213bd7f2
AS
28822011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2883
6b02f655 2884 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 2885
99aaf75f
JD
28862011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2887
2888 * xterm.c (x_find_topmost_parent): New function.
2889 (x_set_frame_alpha): Find topmost parent window with
2890 x_find_topmost_parent and set the property there also (bug#9181).
2891 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2892
c74e9d86
PE
28932011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2894
2895 * callproc.c (Fcall_process): Avoid vfork clobbering
2896 the local vars buffer, coding_systems, current_dir.
2897
640c8776
SM
28982011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2899
2900 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2901
f26d0e4c
PE
29022011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2903
8a10d76c
PE
2904 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2905 so that it is not optimized away.
2906
f26d0e4c
PE
2907 * xdisp.c (compute_display_string_pos): Remove unused local.
2908
55439c61
EZ
29092011-08-02 Eli Zaretskii <eliz@gnu.org>
2910
2911 Fix slow cursor motion and scrolling in large buffers with
2912 selective display, like Org Mode buffers. (Bug#9218)
2913
2914 * dispextern.h (struct bidi_it): New member disp_prop_p.
2915
2916 * xdisp.c: Remove one-slot cache of display string positions.
2917 (compute_display_string_pos): Accept an additional argument
5e617bc2 2918 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
2919 for a display string or property. If found, set DISP_PROP_P
2920 non-zero.
2921
2922 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
2923 DISP_PROP_P, and pass it to compute_display_string_pos.
2924 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
2925 non-zero. All callers of bidi_fetch_char changed.
2926
fb33fa43
SM
29272011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2928
2929 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2930
b099e063
DM
29312010-12-03 Don March <don@ohspite.net>
2932
2933 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2934 last character M-[char] is translated to ESC [char] (bug#7541).
2935
5cc7f7af
KH
29362011-08-02 Kenichi Handa <handa@m17n.org>
2937
d0fffa3f 2938 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
2939
2940 * chartab.c (uniprop_table): Make it non-static.
2941
525d5e6e
EZ
29422011-08-01 Eli Zaretskii <eliz@gnu.org>
2943
2944 * xdisp.c (forward_to_next_line_start): Accept additional argument
2945 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2946 on the newline.
2947 (reseat_at_next_visible_line_start): Use the bidi iterator state
2948 returned by forward_to_next_line_start to restore the state of
2949 it->bidi_it after backing up to previous newline. (Bug#9212)
2950
31011111
AS
29512011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2952
2953 * regex.c (re_comp): Protoize.
2954 (re_exec): Fix return type.
2955 (regexec): Fix type of `ret'. (Bug#9203)
2956
476371c4
PE
29572011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2958
e5d76069
PE
2959 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2960 This is needed if max-image-size is a floating-point number.
2961
9a79b20c
AS
29622011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2963
2964 * print.c (print_object): Print empty symbol as ##.
2965
2966 * lread.c (read1): Read ## as empty symbol.
2967
d8c2fa78
AA
29682011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2969
2970 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2971 setting frame foreground color (Bug#9175).
2972 (x_set_background_color): Likewise.
2973
ffe57a7a
AA
2974 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2975 contents (Bug#9176).
2976 (EmacsTooltip -init): Remove bezels and add shadows to
2977 tooltip windows.
2978
bf3492a5
AA
2979 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2980 or scroll bar (Bug#8470).
2981
d55e9c53
AA
2982 * nsfont.m (nsfont_open): Remove assignment to voffset and
2983 unnecessary vars hshink, expand, hd, full_height, min_height.
2984 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2985
2986 * nsterm.h (nsfont_info): Remove voffset field.
2987
d8c2fa78 29882011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
2989
2990 Implement strike-through and overline on NextStep (Bug#8863).
2991
2992 * nsfont.m (nsfont_open): Use underline position provided by font,
2993 instead of hard-coded value of 2.
2994 (nsfont_draw): Call ns_draw_text_decoration instead.
2995
2996 * nsterm.h: Add declaration for ns_draw_text_decoration.
2997
2998 * nsterm.m (ns_draw_text_decoration): New function for drawing
2999 underline, overline, and strike-through.
3000 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3001 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 3002 accommodate underlining, etc.
4843aac3 3003
4cc60b9b
EZ
30042011-07-28 Eli Zaretskii <eliz@gnu.org>
3005
bc7ece87
EZ
3006 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3007 default.
4cc60b9b 3008
476371c4
PE
30092011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3010
66606eea
PE
3011 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3012 Without this fix, if a signal arrives just after memory fills up,
3013 'malloc' might be invoked reentrantly.
3014
476371c4
PE
3015 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3016 In other words, assume that every image size is allowed, on non-X
3017 hosts. This assumption is probably wrong, but it lets Emacs compile.
3018
f3fcc40d
AS
30192011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3020
3021 * regex.c (re_iswctype): Convert return values to boolean.
3022
350c992f
EZ
30232011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3024
3025 * xdisp.c (compute_display_string_pos): Don't use cached display
3026 string position if the buffer had its restriction changed.
3027 (Bug#9184)
3028
5266b4bb
PE
30292011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3030
3031 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3032
2573a837 30332011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 3034
41f55ccd 3035 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 3036
39e378da
PE
3037 * bidi.c: Integer size and overflow fixes.
3038 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3039 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3040 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3041 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3042 (bidi_find_other_level_edge):
3043 Use ptrdiff_t instead of EMACS_INT where either will do.
3044 This works better on 32-bit hosts configured --with-wide-int.
3045 (bidi_cache_ensure_space): Check for size-calculation overflow.
3046 Use % rather than repeated addition, for better worst-case speed.
3047 Don't set bidi_cache_size until after xrealloc returns, because it
3048 might not return.
3049 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
3050 (bidi_cache_ensure_space): Also check that the bidi cache size
3051 does not exceed that of the largest Lisp string or buffer. See Eli
3052 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 3053
5e927815
PE
3054 * alloc.c (__malloc_size_t): Remove.
3055 All uses replaced by size_t. See Andreas Schwab's note
3056 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3057
ca4aa935
PE
3058 * image.c: Improve checking for integer overflow.
3059 (check_image_size): Assume that f is nonnull, since
3060 it is always nonnull in practice. This is one less thing to
3061 worry about when checking for integer overflow later.
3062 (x_check_image_size): New function, which checks for integer
3063 overflow issues inside X.
3064 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3065 This removes the need for a memory_full check.
3066 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3067 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3068 (xbm_read_bitmap_data): Change locals back to 'int', since
3069 their values must fit in 'int'.
3070 (xpm_load_image, png_load, tiff_load):
3071 Invoke x_create_x_image_and_pixmap earlier,
3072 to avoid much needless work if the image is too large.
3073 (tiff_load): Treat overly large images as if
3074 x_create_x_image_and_pixmap failed, not as malloc failures.
3075 (gs_load): Use x_check_image_size.
3076
5f8f9cc2
PE
3077 * gtkutil.c: Omit integer casts.
3078 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3079 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3080
5adf60bc
PE
3081 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3082
c8907a93
PE
3083 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3084 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3085 would wrongly return t on a 64-bit host.
3086
e3c25c68
PE
3087 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3088 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3089 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3090 and therefore cause GCC to emit a bogus diagnostic in some cases.
3091
3f791afe
PE
3092 * image.c: Integer signedness and overflow and related fixes.
3093 This is not an exhaustive set of fixes, but it's time to
3094 record what I've got.
3095 (lookup_pixel_color, check_image_size): Remove redundant decls.
3096 (check_image_size): Don't assume that arbitrary EMACS_INT values
3097 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3098 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3099 (tiff_load, imagemagick_load_image):
3100 Check for overflow in size calculations.
3101 (x_create_x_image_and_pixmap): Remove unnecessary test for
3102 xmalloc returning NULL; that can't happen.
3103 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3104 (xpm_color_bucket): Use better integer hashing function.
3105 (xpm_cache_color): Don't possibly over-allocate memory.
3106 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3107 (gif_memory_source):
3108 Use ptrdiff_t, not int or size_t, to record sizes.
3109 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3110 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3111 either works, as we prefer signed integers.
3112 (tiff_read_from_memory, tiff_write_from_memory):
3113 Return tsize_t, not size_t, since that's what the TIFF API wants.
3114 (tiff_read_from_memory): Don't fail simply because the read would
3115 go past EOF; instead, return a short read.
3116 (tiff_load): Omit no-longer-needed casts.
3117 (Fimagemagick_types): Don't assume size fits into 'int'.
3118
3cc5a532
PE
3119 Improve hashing quality when configured --with-wide-int.
3120 * fns.c (hash_string): New function, taken from sxhash_string.
3121 Do not discard information about ASCII character case; this
3122 discarding is no longer needed.
3123 (sxhash-string): Use it. Change sig to match it. Caller changed.
3124 * lisp.h: Declare it.
3125 * lread.c (hash_string): Remove, since we now use fns.c's version.
3126 The fns.c version returns a wider integer if --with-wide-int is
3127 specified, so this should help the quality of the hashing a bit.
3128
b312a492
PE
3129 * emacs.c: Integer overflow minor fix.
3130 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3131 Define only if GNU_LINUX.
3132 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3133
dfd153ae
PE
3134 * dispnew.c: Integer signedness and overflow fixes.
3135 Remove unnecessary forward decls, that were a maintenance hassle.
3136 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3137 All uses changed.
3138 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3139 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3140 (prepare_desired_row, line_draw_cost):
3141 Use int, not unsigned, where either works.
3142 (save_current_matrix, restore_current_matrix):
3143 Use ptrdiff_t, not size_t, where either works.
3144 (init_display): Check for overflow more accurately, and without
3145 relying on undefined behavior.
3146
a81d11a3
PE
3147 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3148 Remove, replacing with the new symbols in lisp.h. All uses changed.
3149 * fileio.c (make_temp_name):
3150 * filelock.c (lock_file_1, lock_file):
3151 * xdisp.c (message_dolog):
3152 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3153 Use pMd etc. instead.
3154 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3155 replacing the pWIDE etc. symbols removed from editfns.c.
3156
3300e6fd
PE
3157 * keyboard.h (num_input_events): Now uintmax_t.
3158 This is (very slightly) less likely to mess up due to wraparound.
3159 All uses changed.
3160
fd05c7e9
PE
3161 * buffer.c: Integer signedness fixes.
3162 (alloc_buffer_text, enlarge_buffer_text):
3163 Use ptrdiff_t rather than size_t when either will do, as we prefer
3164 signed integers.
3165
903fe15d
PE
3166 * alloc.c: Integer signedness and overflow fixes.
3167 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3168 (__malloc_size_t): Default to size_t, not to int.
3169 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3170 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3171 Prefer ptrdiff_t to size_t when either would do, as we prefer
3172 signed integers.
3173 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3174 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3175 Now const. Initialize with values that are in range even if char
3176 is signed.
3177 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3178 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3179 These functions do the right thing with sizes > 2**32.
3180 (check_depth): Now ptrdiff_t, not int.
3181 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3182 Adjust to new way of storing sizes. Check for size overflow bugs
3183 in rest of code.
3184 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3185 slightly wrong anyway, as it missed one instance of
3186 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3187 (refill_memory_reserve): Omit needless cast to size_t.
3188 (mark_object_loop_halt): Mark as externally visible.
3189
ac82cc6a
PE
3190 * xselect.c: Integer signedness and overflow fixes.
3191 (Fx_register_dnd_atom, x_handle_dnd_message):
3192 Use ptrdiff_t, not size_t, since we prefer signed.
3193 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3194 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3195 x_dnd_atoms_size and x_dnd_atoms_length.
3196
c2d1e36d
PE
3197 * doprnt.c: Prefer signed to unsigned when either works.
3198 * eval.c (verror):
3199 * doprnt.c (doprnt):
3200 * lisp.h (doprnt):
3201 * xdisp.c (vmessage):
3202 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3203 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3204 prefer signed arithmetic to avoid comparison confusion.
3205 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3206 but is a bit tricky.
3207
0e926e56
PE
3208 Assume freestanding C89 headers, string.h, stdlib.h.
3209 * data.c, doprnt.c, floatfns.c, print.c:
3210 Include float.h unconditionally.
3211 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3212 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3213 * regex.c: Likewise for stddef.h, string.h.
3214 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3215 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3216 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3217 (STDC_HEADERS): Remove obsolete defines.
3218 * sysdep.c: Include limits.h unconditionally.
3219
9cfdb3ec
PE
3220 Assume support for memcmp, memcpy, memmove, memset.
3221 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3222 * regex.c (memcmp, memcpy):
3223 Remove; we assume C89 now.
3224
3225 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3226 (__malloc_safe_bcopy): Remove; no longer needed.
3227
cf950e6b 3228 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
3229 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3230 well either way, and we prefer signed to unsigned.
3231
dbf38e02
LMI
32322011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3233
3234 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3235 closes the connection while we're reading (bug#9182).
3236
d6f0886c 32372011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 3238
d6f0886c
JD
3239 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3240 are specified (Bug#9168).
24e0f6b1 3241
2eb1f9e6
PE
32422011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3243
3244 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3245 Found by GCC static checking and --with-wide-int on a 32-bit host.
3246
22381272 32472011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
3248
3249 * xdisp.c (compute_display_string_pos): Fix logic of caching
3250 previous display string position. Initialize cached_prev_pos to
3251 -1. Fixes slow-down at the beginning of a buffer.
3252
f25e39b4
EZ
32532011-07-24 Eli Zaretskii <eliz@gnu.org>
3254
3255 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3256 for attrs[LFACE_FONTSET_INDEX].
3257
04c4b52e
PE
32582011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3259
3260 * xml.c (parse_region): Remove unused local
3261 that was recently introduced.
3262
c1734fbd
EZ
32632011-07-23 Eli Zaretskii <eliz@gnu.org>
3264
be18c5a5
EZ
3265 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3266 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3267
c1734fbd
EZ
3268 * xdisp.c (move_it_in_display_line_to): Record the best matching
3269 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
3270 exit if none of the characters scanned was an exact match.
3271 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
3272 when exact match is impossible due to invisible text, and the
3273 lines are truncated.
3274
a258d627
JD
32752011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3276
3277 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3278 for OSX >= 10.7.
3279
b6d5a689
EZ
32802011-07-22 Eli Zaretskii <eliz@gnu.org>
3281
0f74f785
EZ
3282 Fix a significant slow-down of cursor motion with C-n, C-p,
3283 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3284 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 3285 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
3286 (next_element_from_buffer): Call compute_stop_pos_backwards to
3287 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
3288 base_level_stop.
3289 (reseat): Don't look for prev_stop, as that could mean a very long
3290 run.
3291 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3292 <cached_disp_overlay_modiff>: Cache for last found display string
3293 position.
551918c1 3294 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
3295 about the same buffer in the same area of character positions, and
3296 the buffer wasn't changed since the time the display string
3297 position was cached.
551918c1 3298
b2d0c91a
EZ
32992011-07-22 Eli Zaretskii <eliz@gnu.org>
3300
3301 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3302 is an integer, which is important for empty lines. (Bug#9149)
3303
043604ee
CY
33042011-07-22 Chong Yidong <cyd@stupidchicken.com>
3305
3306 * frame.c (Fmodify_frame_parameters): In tty case, update the
3307 default face if necessary (Bug#4238).
3308
da4adb04
CY
33092011-07-21 Chong Yidong <cyd@stupidchicken.com>
3310
3311 * editfns.c (Fstring_to_char): No need to explain what a character
3312 is in the docstring (Bug#6576).
3313
9abd0532
LMI
33142011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3315
3316 * xml.c (parse_region): Make sure we always return a tree.
3317
36881d16
HK
33182011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3319
3320 * xml.c (parse_region): If a document contains only comments,
3321 return that, too.
3322
1e98674d
LMI
33232011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3324
3325 * xml.c (make_dom): Return comments, too.
3326
590bd467
PE
33272011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3328
3329 Port to OpenBSD.
3330 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3331 and the surrounding thread.
3332 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3333 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3334 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3335 timer goes off.
3336 * s/openbsd.h (BROKEN_SIGIO): Define.
3337 * unexelf.c (unexec) [__OpenBSD__]:
3338 Don't update the .mdebug section of the Alpha COFF symbol table.
3339
f41628b2
LMI
33402011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3341
3342 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3343 (bug#8460).
3344
b59b67c5
PE
33452011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3346
15e3a074
PE
3347 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3348 This fixes some race conditions on the permissions of any newly
3349 created file.
3350
41bed37d
PE
3351 * alloc.c (valid_pointer_p): Use pipe, not open.
3352 This fixes some permissions issues when debugging.
3353
b59b67c5
PE
3354 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3355 If fchown fails to set both uid and gid, try to set just gid,
3356 as that is sometimes allowed. Adjust the file's mode to eliminate
3357 setuid or setgid bits that are inappropriate if fchown fails.
3358
925a6be7
SM
33592011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3360
3361 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3362 to compare Lisp_Objects.
3363 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3364 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3365 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3366
52968808
AS
33672011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3368
0a6a104b
AS
3369 * lread.c (read_integer): Unread even EOF character.
3370 (read1): Likewise. Properly record start position of symbol.
3371
52968808
AS
3372 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3373 symbol character follows.
3374
9e381cdd
PE
33752011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3376
3377 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3378 This works around a problem with the previous change to Fcopy_file.
3379 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3380 and without this change, GCC might complain about discarding
3381 fchown's return value.
3382
b5641435
JB
33832011-07-16 Juanma Barranquero <lekktu@gmail.com>
3384
3385 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3386
a8031457
PE
33872011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3388
3389 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3390
dd889327
LMI
33912011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3392
750c33f7
LMI
3393 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3394 it's used from the C level.
3395
dd889327
LMI
3396 * process.c: Use the same condition for POLL_FOR_INPUT in both
3397 keyboard.c and process.c (bug#1858).
3398
87e86684
LM
33992011-07-09 Lawrence Mitchell <wence@gmx.li>
3400
3401 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3402 (Fgnutls_boot): Use it.
3403
64348f40
AS
34042011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3405
3406 * doc.c (Fsubstitute_command_keys): Revert last change.
3407
1d698799
LMI
34082011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3409
f863868c
LMI
3410 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3411 quotes the next character, and doesn't affect other longer
3412 sequences (bug#8935).
3413
1d698799
LMI
3414 * lread.c (syms_of_lread): Clarify that is isn't only
3415 `eval-buffer' and `eval-defun' that's affected by
3416 `lexical-binding' (bug#8460).
3417
aa4b6df6
EZ
34182011-07-15 Eli Zaretskii <eliz@gnu.org>
3419
3420 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 3421 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 3422
5d856da6
PE
34232011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3424
ad6042bb
PE
3425 Fix minor problems found by static checking.
3426 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3427 (elsz): Now a signed constant, not a size_t var. We prefer signed
3428 types to unsigned, to avoid integer comparison confusion. Without
3429 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3430 "cannot optimize loop, the loop counter may overflow", a symptom
3431 of the confusion.
f00bbb22 3432 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
3433 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3434
6468f31c
LMI
34352011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3436
49080b10
LMI
3437 * search.c (Fre_search_backward): Mention `case-fold-search' in
3438 all the re_search_* functions (bug#8138).
3439
6468f31c
LMI
3440 * keyboard.c (Fopen_dribble_file): Document when the file is
3441 closed (bug#8056).
3442
c965adc5
EZ
34432011-07-14 Eli Zaretskii <eliz@gnu.org>
3444
df9733bf
EZ
3445 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3446 bidi_cache_idx.
3447
0bb23927
EZ
3448 Support bidi reordering of display and overlay strings.
3449 * xdisp.c (compute_display_string_pos)
3450 (compute_display_string_end): Accept additional argument STRING.
3451 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3452 (reseat_to_string): Initialize bidi_it->string.s and
3453 bidi_it->string.schars.
3454 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
3455 NULL (avoids a crash in bidi_paragraph_init).
3456 Initialize itb.string.lstring.
0bb23927
EZ
3457 (init_iterator): Call bidi_init_it only of a valid
3458 buffer position was specified. Initialize paragraph_embedding to
3459 L2R.
3460 (reseat_to_string): Initialize the bidi iterator.
3461 (display_string): If we need to ignore text properties of
3462 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3463 original value of -1 will not work with bidi.)
3464 (compute_display_string_pos): First arg is now struct
3465 `text_pos *'; all callers changed. Support display properties on
3466 Lisp strings.
3467 (compute_display_string_end): Support display properties on Lisp
3468 strings.
3469 (init_iterator, reseat_1, reseat_to_string): Initialize the
3470 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3471 when iterating on a string not from display properties).
640c8776
SM
3472 (compute_display_string_pos, compute_display_string_end):
3473 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
3474 arrow keys.
3475 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
3476 base_level_stop; instead, set base_level_stop to BEGV.
3477 Fixes crashes in vertical-motion.
0bb23927
EZ
3478 (next_element_from_buffer): Improve commentary for when
3479 the iterator is before prev_stop.
3480 (init_iterator): Initialize bidi_p from the default value of
3481 bidi-display-reordering, not from buffer-local value. Use the
3482 buffer-local value only if initializing for buffer iteration.
3483 (handle_invisible_prop): Support invisible properties on strings
3484 that are being bidi-reordered.
3485 (set_iterator_to_next): Support bidi reordering of C strings and
3486 Lisp strings.
3487 (next_element_from_string): Support bidi reordering of Lisp
3488 strings.
3489 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
3490 (display_string): Support display of R2L glyph rows.
3491 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
3492 (init_iterator): Don't initialize it->bidi_p for strings
3493 here.
3494 (reseat_to_string): Initialize it->bidi_p for strings here.
3495 (next_element_from_string, next_element_from_c_string)
3496 (next_element_from_buffer): Add xassert's for correspondence
3497 between IT's object being iterated and it->bidi_it.string
3498 structure.
3499 (face_before_or_after_it_pos): Support bidi iteration.
3500 (next_element_from_c_string): Handle the case of the first string
3501 character that is not the first one in the visual order.
3502 (get_visually_first_element): New function, refactored from common
3503 parts of next_element_from_buffer, next_element_from_string, and
3504 next_element_from_c_string.
3505 (tool_bar_lines_needed, redisplay_tool_bar)
3506 (display_menu_bar): Force left-to-right direction. Add a FIXME
3507 comment for making that be controlled by a user option.
3508 (push_it, pop_it): Save and restore the state of the
3509 bidi iterator. Save and restore the bidi_p flag.
3510 (pop_it): Iterate out of display property for string iteration as
3511 well.
3512 (iterate_out_of_display_property): Support iteration over strings.
3513 (handle_single_display_spec): Set up it->bidi_it for iteration
3514 over a display string, and call bidi_init_it.
3515 (handle_single_display_spec, next_overlay_string)
3516 (get_overlay_strings_1, push_display_prop): Set up the bidi
3517 iterator for displaying display or overlay strings.
3518 (forward_to_next_line_start): Don't use the shortcut if
3519 bidi-iterating.
3520 (back_to_previous_visible_line_start): If handle_display_prop
3521 pushed the iterator stack, restore the internal state of the bidi
3522 iterator by calling bidi_pop_it same number of times.
3523 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3524 and we are bidi-iterating, don't decrement the iterator position;
3525 instead, set the first_elt flag in the bidi iterator, to produce
3526 the same effect.
3527 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3528 (push_display_prop): xassert that we are iterating a buffer.
3529 (push_it, pop_it): Save and restore paragraph_embedding member.
3530 (handle_single_display_spec, next_overlay_string)
3531 (get_overlay_strings_1, reseat_1, reseat_to_string)
3532 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3533 correctly. Don't assume unibyte strings are not bidi-reordered.
3534 (compute_display_string_pos)
3535 (compute_display_string_end): Fix handling the case of C string.
3536 (push_it, pop_it): Save and restore from_disp_prop_p.
3537 (handle_single_display_spec, push_display_prop): Set the
3538 from_disp_prop_p flag.
3539 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3540 (pop_it): Call iterate_out_of_display_property only if we are
3541 popping after iteration over a string that came from a display
3542 property. Fix a typo in popping stretch info. Add an assertion
3543 for verifying that the iterator position is in sync with the bidi
3544 iterator.
3545 (handle_single_display_spec, get_overlay_strings_1)
3546 (push_display_prop): Fix initialization of paragraph direction for
3547 string when that of the parent object is not yet determined.
3548 (reseat_1): Call bidi_init_it to resync the bidi
3549 iterator with IT's position. (Bug#7616)
3550 (find_row_edges): If ROW->start.pos gives position
3551 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3552 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3553 Reset the from_disp_prop_p flag.
3554 (SAVE_IT, RESTORE_IT): New macros.
3555 (pos_visible_p, face_before_or_after_it_pos)
3556 (back_to_previous_visible_line_start)
3557 (move_it_in_display_line_to, move_it_in_display_line)
3558 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3559 (try_scrolling, redisplay_window, display_line): Use them when
3560 saving a temporary copy of the iterator and restoring it back.
3561 (back_to_previous_visible_line_start, reseat_1)
3562 (init_iterator): Empty the bidi cache "stack".
3563 (move_it_in_display_line_to): If iterator ended up at
3564 EOL, but we never saw any buffer positions smaller than
3565 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3566 motion in bidi-reordered lines.
3567 (move_it_in_display_line_to): Record prev_method and prev_pos
3568 immediately before the call to set_iterator_to_next. Fixes cursor
3569 motion in bidi-reordered lines with stretch glyphs and strings
3570 displayed in margins. (Bug#8133) (Bug#8867)
3571 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3572 TO_CHARPOS.
640c8776
SM
3573 (pos_visible_p): Support positions in bidi-reordered lines.
3574 Save and restore bidi cache.
0bb23927
EZ
3575
3576 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3577 (bidi_paragraph_info): Delete unused struct.
3578 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3579 (bidi_cache_start): New variable.
3580 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3581 to zero.
3582 (bidi_cache_fetch_state, bidi_cache_search)
3583 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3584 (bidi_cache_find, bidi_peek_at_next_level)
3585 (bidi_level_of_next_char, bidi_find_other_level_edge)
3586 (bidi_move_to_visually_next): Compare cache index with
3587 bidi_cache_start rather than with zero.
3588 (bidi_fetch_char): Accept new argument STRING; all callers
3589 changed. Support iteration over a string. Support strings with
3590 display properties. Support unibyte strings. Fix the type of
3591 `len' according to what STRING_CHAR_AND_LENGTH expects.
3592 (bidi_paragraph_init, bidi_resolve_explicit_1)
3593 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
3594 (bidi_level_of_next_char, bidi_move_to_visually_next):
3595 Support iteration over a string.
0bb23927
EZ
3596 (bidi_set_sor_type, bidi_resolve_explicit_1)
3597 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3598 can now be zero (for strings); special values 0 and -1 were
3599 changed to -1 and -2, respectively.
3600 (bidi_char_at_pos): New function.
3601 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3602 Call it instead of FETCH_MULTIBYTE_CHAR.
3603 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3604 initialized to valid values.
3605 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3606 values.
3607 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3608 the test for valid cached positions. Fix the logic for looking up
3609 the sentinel state in the cache. GCPRO the Lisp string we are
3610 iterating.
3611 (bidi_push_it, bidi_pop_it): New functions.
3612 (bidi_initialize): Initialize the bidi cache start stack pointer.
3613 (bidi_cache_ensure_space): New function, refactored from part of
3614 bidi_cache_iterator_state. Don't assume the required size is just
3615 one BIDI_CACHE_CHUNK away.
3616 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3617 (bidi_count_bytes, bidi_char_at_pos): New functions.
3618 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3619 always valid if bidi_cache_idx is valid.
3620 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3621 is valid if it's going to be used.
3622 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3623 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
3624 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3625 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
3626 (bidi_find_other_level_edge, bidi_cache_start_stack):
3627 All variables related to cache indices are now EMACS_INT.
c965adc5 3628
0bb23927
EZ
3629 * dispextern.h (struct bidi_string_data): New structure.
3630 (struct bidi_it): New member `string'. Make flag members be 1-bit
3631 fields, and put them last in the struct.
640c8776
SM
3632 (compute_display_string_pos, compute_display_string_end):
3633 Update prototypes.
0bb23927
EZ
3634 (bidi_push_it, bidi_pop_it): Add prototypes.
3635 (struct iterator_stack_entry): New members bidi_p,
3636 paragraph_embedding, and from_disp_prop_p.
3637 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
3638 (bidi_shelve_cache, bidi_unshelve_cache):
3639 Declare prototypes.
0bb23927
EZ
3640
3641 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3642 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3643 and vector-like objects.
3644
3645 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3646 cache around display iteration.
3647
3648 * window.c (Fwindow_end, window_scroll_pixel_based)
3649 (displayed_window_lines, Frecenter): Save and restore the bidi
3650 cache around display iteration.
3651
3bbd2265
LMI
36522011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3653
3654 * editfns.c (Fdelete_region): Clarify the use of the named
3655 parameters (bug#6788).
3656
adc47434
MR
36572011-07-14 Martin Rudalics <rudalics@gmx.at>
3658
3659 * indent.c (Fvertical_motion): Set and restore w->pointm when
3660 saving and restoring the window's buffer (Bug#9006).
3661
837c31f8
LMI
36622011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3663
3664 * editfns.c (Fstring_to_char): Clarify just what is returned
3665 (bug#6576). Text by Eli Zaretskii.
3666
ac389d0c
JB
36672011-07-13 Juanma Barranquero <lekktu@gmail.com>
3668
3669 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3670
0be0ce47
EZ
36712011-07-13 Eli Zaretskii <eliz@gnu.org>
3672
3673 * buffer.c (mmap_find): Fix a typo.
3674
cd18e7e3
JB
36752011-07-13 Johan Bockgård <bojohan@gnu.org>
3676
3677 Fix execution of x selection hooks.
3678 * xselect.c (Qx_lost_selection_functions)
3679 (Qx_sent_selection_functions): New vars.
3680 (syms_of_xselect): DEFSYM them.
3681 (x_handle_selection_request): Pass Qx_sent_selection_functions
3682 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3683 (x_handle_selection_clear,x_clear_frame_selections):
3684 Pass Qx_lost_selection_functions rather than
3685 Vx_lost_selection_functions to Frun_hook_with_args.
3686
47ea7f44
PE
36872011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3688
ac389d0c 3689 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
3690 The old code sometimes used this field without initializing it.
3691
47ea7f44
PE
3692 * alloc.c (gc_sweep): Don't read past end of array.
3693 In theory, the old code could also have corrupted Emacs internals,
3694 though it'd be very unlikely.
3695
bc985c87
AS
36962011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3697
3698 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 3699 argument. (Bug#4026)
bc985c87 3700
0cf34688
LMI
37012011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3702
b3dadd76
LMI
3703 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3704 key" (bug#4257).
3705
0cf34688
LMI
3706 * window.c (Fset_window_start): Doc fix (bug#4199).
3707 (Fset_window_hscroll): Ditto.
3708
270768cd
PE
37092011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3710
077e3dda 3711 Fix minor new problems caught by GCC 4.6.1.
270768cd 3712 * term.c (init_tty): Remove unused local.
490011a6 3713 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 3714 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 3715 not used otherwise.
270768cd 3716
b1f58454
CY
37172011-07-12 Chong Yidong <cyd@stupidchicken.com>
3718
3719 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3720
22b9578d
LMI
37212011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3722
6e70ab07
LMI
3723 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3724 are the mini-buffer and the echo area (bug#3320).
3725
22b9578d
LMI
3726 * term.c (init_tty): Remove support for supdup, c10 and perq
3727 terminals, which are no longer supported (bug#1482).
3728
8974cc9f
JB
37292011-07-10 Johan Bockgård <bojohan@gnu.org>
3730
3731 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3732
a560d974
JD
37332011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3734
3735 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3736 for non-popups (Bug#3642).
3737
1dae0f0a
AS
37382011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3739
268c2c36 3740 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 3741 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
3742 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3743 * cm.c (losecursor): Likewise.
1dae0f0a
AS
3744 * data.c (fmod): Likewise.
3745 * dispnew.c (swap_glyphs_in_rows): Likewise.
3746 * emacs.c (memory_warning_signal): Likewise.
3747 * floatfns.c (float_error): Likewise.
3748 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3749 (otf_open, font_otf_capability, generate_otf_features)
3750 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3751 Likewise.
3752 * image.c (pbm_read_file): Likewise.
3753 * indent.c (string_display_width): Likewise.
3754 * intervals.c (check_for_interval, search_for_interval)
3755 (inc_interval_count, count_intervals, root_interval)
3756 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3757 * lread.c (defalias): Likewise.
268c2c36 3758 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
3759 * regex.c (set_image_of_range_1, set_image_of_range)
3760 (regex_grow_registers): Likewise.
3761 * sysdep.c (strerror): Likewise.
3762 * termcap.c (valid_filename_p, tprint, main): Likewise.
3763 * tparam.c (main): Likewise.
3764 * unexhp9k800.c (run_time_remap, save_data_space)
3765 (update_file_ptrs, read_header, write_header, calculate_checksum)
3766 (copy_file, copy_rest, display_header): Likewise.
3767 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3768 Likewise.
3769 * xdisp.c (check_it): Likewise.
3770 * xfaces.c (register_color, unregister_color, unregister_colors):
3771 Likewise.
3772 * xfns.c (print_fontset_result): Likewise.
3773 * xrdb.c (member, fatal, main): Likewise.
3774
99033785
PE
37752011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3776
3777 Fix minor problems found by static checking (Bug#9031).
3778 * chartab.c (char_table_set_range, map_sub_char_table):
3779 Remove unused locals.
3780 (uniprop_table): Now static.
3781 * composite.c (_work_char): Remove unused static var.
3782
9cb2ac56
JB
37832011-07-09 Juanma Barranquero <lekktu@gmail.com>
3784
3785 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3786
f25661f0
JD
37872011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3788
3789 * gtkutil.c (qttip_cb): Remove code without function.
3790
8278c4fe
EZ
37912011-07-09 Eli Zaretskii <eliz@gnu.org>
3792
3793 * w32.c (pthread_sigmask): New stub.
3794
1692ae2d 37952011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 3796
8a6ebd58 3797 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
3798 sigprocmask is portable only for single-threaded applications, and
3799 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
3800 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3801 (LIBES): Use it.
3802 * callproc.c (Fcall_process):
3803 * process.c (create_process):
3804 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3805 Use pthread_sigmask, not sigprocmask.
123403e4 3806
1b854618
JD
38072011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3808
3809 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3810 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3811 wrong (Bug#8591).
3812
3fe4b549
JD
38132011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3814
0ce7e563
JD
3815 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3816 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3817 (xg_hide_tooltip): Fix comment.
3818
3fe4b549
JD
3819 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3820 in registerServicesMenuSendTypes.
3821 (validRequestorForSendType): Don't check ns_return_types.
3822
3823 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3824 ns_return_type.
3825
5df75e47
JR
38262011-07-08 Jason Rumney <jasonr@gnu.org>
3827
22610910
JR
3828 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3829 SH_SHOW for hidden windows (Bug#5482).
3830
5df75e47
JR
3831 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3832 frame struct members of non-existent frames (Bug#6284).
3833
699c10bd
JD
38342011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3835
4393663b
JD
3836 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3837 variable firstTime not needed on OSX >= 10.6.
3838 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3839 >= 10.5. Use setKnobProportion, setDoubleValue.
3840
3841 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3842 (MAC_OS_X_VERSION_10_5): Define if not defined.
3843 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3844 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3845 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3846
3847 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3848 cString and lossyCString on OSX >= 10.4
3849
58179cce 3850 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
3851 sizeToFit on OSX >= 10.2.
3852
3853 * nsimage.m (allocInitFromFile): Don't use deprecated method
3854 bestRepresentationForDevice on OSX >= 10.6.
3855
3856 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3857 to avoid warning.
3858
3859 * emacs.c: Declare unexec_init_emacs_zone.
3860
a63e0781
JD
3861 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3862
699c10bd
JD
3863 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3864
3865 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3866 on svcsMenu (Bug#8842).
3867
3868 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3869 ns_return_types.
3870 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3871
3872 * nsterm.m (QUTF8_STRING): Declare.
3873 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3874 (validRequestorForSendType): Return type is (id).
3875 Change indexOfObjectIdenticalTo to indexOfObject.
3876 Check if we have local selection before returning self (Bug#8842).
3877 (writeSelectionToPasteboard): Put local selection into paste board
3878 if we have a local selection (Bug#8842).
3879 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3880
3881 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3882 (ns_get_local_selection): Declare.
3883
54e10184
LMI
38842011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3885
9888ff71
LMI
3886 * keymap.c (describe_map_tree): Don't insert a double newline at
3887 the end of the buffer (bug#1169) and return whether we inserted
3888 something.
3889
54e10184
LMI
3890 * callint.c (Fcall_interactively): Change "reading args" to
3891 "providing args" to try to clarify what it does (bug#1010).
3892
15fa4783
KH
38932011-07-07 Kenichi Handa <handa@m17n.org>
3894
3895 * composite.c (composition_compute_stop_pos): Ignore a static
3896 composition starting before CHARPOS (Bug#8915).
3897
3898 * xdisp.c (handle_composition_prop): Likewise.
3899
a8815b00
EZ
39002011-07-07 Eli Zaretskii <eliz@gnu.org>
3901
3902 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3903 (Bug#9015)
3904
ef7b981d 39052011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
3906
3907 * character.h (unicode_category_t): New enum type.
3908
3909 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3910 (Qchar_code_property_table): New variable.
3911 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3912 (UNIPROP_COMPRESSED_FORM_P): New macros.
3913 (char_table_ascii): Uncompress the compressed values.
3914 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3915 Uncompress the compressed values.
ac389d0c 3916 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
3917 (char_table_ref_and_range): Uncompress the compressed values.
3918 (sub_char_table_set): New arg is_uniprop. Callers changed.
3919 Uncompress the compressed values.
3920 (sub_char_table_set_range): Args changed. Callers changed.
3921 (char_table_set_range): Adjuted for the above change.
3922 (map_sub_char_table): Delete args default_val and parent. Add arg
3923 top. Give decoded values to a Lisp function.
640c8776 3924 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
3925 values to a Lisp function. Gcpro more variables.
3926 (uniprop_table_uncompress)
3927 (uniprop_decode_value_run_length): New functions.
3928 (uniprop_decoder, uniprop_decoder_count): New variables.
3929 (uniprop_get_decoder, uniprop_encode_value_character)
3930 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3931 New functions.
3932 (uniprop_encoder, uniprop_encoder_count): New variables.
3933 (uniprop_get_encoder, uniprop_table)
3934 (Funicode_property_table_internal, Fget_unicode_property_internal)
3935 (Fput_unicode_property_internal): New functions.
3936 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3937 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 3938 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
3939 char-code-property-alist.
3940
640c8776 3941 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
3942 Vunicode_category_table.
3943
640c8776 3944 * font.c (font_range): Adjust for the change of
c805dec0
KH
3945 Vunicode_category_table.
3946
76b397fb
DN
39472011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3948
3949 * m/iris4d.h: Remove file, move contents ...
3950 * s/irix6-5.h: ... here.
3951
22b4128e
PE
39522011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3953
3954 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
3955 * alloc.c (mark_buffer):
3956 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3957 (clone_per_buffer_values): Don't assume that
22b4128e
PE
3958 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3959 This isn't true in general, and it's particularly not true
3960 if Emacs is configured with --with-wide-int.
3961 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3962 New macros, used in the buffer.c change.
3963
869795d6
JD
39642011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3965
3966 * xsettings.c: Use both GConf and GSettings if both are available.
3967 (store_config_changed_event): Add comment.
3968 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3969 (store_tool_bar_style_changed): New functions.
5e617bc2 3970 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
3971 (struct xsettings): Move font inside HAVE_XFT.
3972 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 3973 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 3974 Move inside HAVE_XFT.
640c8776 3975 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
3976 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3977 also.
3978 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 3979 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 3980 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
3981 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3982 (parse_settings): Move check for font inside HAVE_XFT.
3983 (read_settings, apply_xft_settings): Add comment.
3984 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3985 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3986 call store_font_name_changed.
3987 (xft_settings_event): Add comment.
3988 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3989 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3990 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3991 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3992 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
3993 (xsettings_get_system_font, xsettings_get_system_normal_font):
3994 Add comment.
869795d6 3995
d8ed26bd
PE
39962011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3997
3998 Random fixes. E.g., (random) never returned negative values.
3999 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4000 subseconds part to the entropy, as that's a bit more random.
4001 Prefer signed to unsigned, since the signedness doesn't matter and
4002 in general we prefer signed. When given a limit, use a
4003 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4004 latter isn't right if USE_2_TAGS_FOR_INTS.
4005 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4006 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4007
cabf1cac
SM
40082011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4009
4010 * textprop.c (text_property_stickiness):
4011 Obey Vtext_property_default_nonsticky.
4012 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4013 * w32fns.c (syms_of_w32fns):
4014 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4015
6e9b2be9
PE
40162011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4017
4018 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4019 This is more efficient than Ffile_directory_p and avoids a minor race.
4020
90186c68
LMI
40212011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4022
7c301272
LMI
4023 * buffer.c (Foverlay_put): Say what the return value is
4024 (bug#7835).
4025
c4f2d8d4
LMI
4026 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4027 is a directory before asking whether to use the file name
4028 (bug#7564).
ad637907
LMI
4029 (barf_or_query_if_file_exists): Make the "File is a directory"
4030 error be more correct.
c4f2d8d4 4031
90186c68
LMI
4032 * fns.c (Frequire): Remove the mention of the .gz files, since
4033 that's installation-specific, but keep the mention of
4034 `get-load-suffixes'.
4035
da64016e
PE
40362011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4037
4038 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4039 Report string overflow if the output is too long.
4040
7d47b580
JB
40412011-07-04 Juanma Barranquero <lekktu@gmail.com>
4042
a555cb87
JB
4043 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4044 (syms_of_gnutls): Remove duplicate DEFSYM for
4045 Qgnutls_bootprop_verify_hostname_error, an error for
4046 Qgnutls_bootprop_verify_error (which is no longer used).
4047
7d47b580
JB
4048 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4049 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4050 Also (re)move comments that are misplaced or no longer relevant.
4051
1e49bfab
LMI
40522011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4053
4054 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4055
1485f4c0
CY
40562011-07-03 Chong Yidong <cyd@stupidchicken.com>
4057
4058 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4059 and background color parameters if they have been changed.
4060
a9ab721e
LMI
40612011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4062
4063 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4064
cf7cff57
PE
40652011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4066
2e13213d
PE
4067 * xsettings.c (SYSTEM_FONT): Define only when used.
4068 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4069
cf7cff57
PE
4070 * keymap.c (access_keymap_1): Now static.
4071
7a8e04f7
CY
40722011-07-02 Chong Yidong <cyd@stupidchicken.com>
4073
4074 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4075 leave any prefix arg for the up event (Bug#1586).
4076
61352f62
LMI
40772011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4078
69bb1ef7
LMI
4079 * lread.c (syms_of_lread): Mention single symbols defined by
4080 `defvar' or `defconst' (bug#7154).
4081
61352f62 4082 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 4083 (Frequire): Mention get-load-suffixes.
61352f62 4084
28545e04
MR
40852011-07-02 Martin Rudalics <rudalics@gmx.at>
4086
4087 * window.h (window): Remove clone_number slot.
4088 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4089 Remove.
4090 (make_parent_window, make_window, saved_window)
4091 (Fset_window_configuration, save_window_save): Don't deal with
4092 clone numbers.
4093 * buffer.c (Qclone_number): Remove declaration.
4094 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4095
3349e122
SM
40962011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4097
4098 Add multiple inheritance to keymaps.
4099 * keymap.c (Fmake_composed_keymap): New function.
4100 (Fset_keymap_parent): Simplify.
4101 (fix_submap_inheritance): Remove.
4102 (access_keymap_1): New function extracted from access_keymap to handle
4103 embedded parents and handle lists of maps.
4104 (access_keymap): Use it.
4105 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4106 (Fcopy_keymap): Handle embedded parents.
4107 (Fcommand_remapping, define_as_prefix): Simplify.
4108 (Fkey_binding): Simplify.
4109 (syms_of_keymap): Move minibuffer-local-completion-map,
4110 minibuffer-local-filename-completion-map,
4111 minibuffer-local-must-match-map, and
4112 minibuffer-local-filename-must-match-map to Elisp.
4113 (syms_of_keymap): Defsubr make-composed-keymap.
4114 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4115 (parse_menu_item): Trivial simplification.
4116
3279eb87
GM
41172011-07-01 Glenn Morris <rgm@gnu.org>
4118
4119 * Makefile.in (SETTINGS_LIBS): Fix typo.
4120
4550efdf
KI
41212011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4122
4123 * coding.c (Fencode_coding_string): Record the last coding system
4124 used, as the function doc string says (bug#8738).
4125
0949d2b6
JD
41262011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4127
4128 * xsettings.c (store_monospaced_changed): Take new font as arg and
4129 check for change against current_mono_font.
4130 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4131 (emacs_settings_constructor, emacs_settings_get_property)
4132 (emacs_settings_set_property, emacs_settings_class_init)
4133 (emacs_settings_init, gsettings_obj): Remove.
4134 (something_changedCB): New function for HAVE_GSETTINGS.
4135 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4136 with value as argument.
4137 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4138 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 4139 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
4140 "changed".
4141
4142 * xgselect.c: Add defined (HAVE_GSETTINGS).
4143 (xgselect_initialize): Ditto.
4144
4145 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4146 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4147 xg_select.
4148
bbc6b304
PE
41492011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4150
4151 * eval.c (struct backtrace): Simplify and port the data structure.
4152 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4153 signed bit field, as this assumption is not portable and it makes
4154 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4155 "char debug_on_exit : 1" as this is not portable either; instead,
4156 use the portable "unsigned int debug_on_exit : 1". Remove unused
4157 member evalargs. Remove obsolete comments about cc bombing out.
4158
9851bfc5
JD
41592011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4160
51bb811f 4161 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
4162 Let HAVE_GSETTINGS override HAVE_GCONF.
4163 (store_monospaced_changed): New function.
4164 (EMACS_SETTINGS): A new type derived from GObject to handle
4165 GSettings notifications.
4166 (emacs_settings_constructor, emacs_settings_get_property)
4167 (emacs_settings_set_property, emacs_settings_class_init):
4168 New functions.
4169 (gsettings_client, gsettings_obj): New variables.
4170 (GSETTINGS_SCHEMA): New define.
4171 (something_changedCB): Call store_monospaced_changed.
4172 (init_gsettings): New function.
4173 (xsettings_initialize): Call init_gsettings.
4174 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4175 to NULL.
4176
640c8776 4177 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
4178 GCONF_CFLAGS/LIBS.
4179
5386012d
MR
41802011-06-29 Martin Rudalics <rudalics@gmx.at>
4181
4182 * window.c (resize_root_window, grow_mini_window)
4183 (shrink_mini_window): Rename Qresize_root_window to
4184 Qwindow_resize_root_window and Qresize_root_window_vertically to
4185 Qwindow_resize_root_window_vertically.
4186
f13e0b08
PE
41872011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4188
4189 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4190
94515237
JB
41912011-06-27 Juanma Barranquero <lekktu@gmail.com>
4192
4193 * makefile.w32-in: Redesign dependencies so they reflect more
4194 clearly which files are directly included by each source file,
4195 and not through other includes.
4196
e43b6e43
MR
41972011-06-27 Martin Rudalics <rudalics@gmx.at>
4198
4199 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4200 (sort_overlays, overlay_strings): When an overlay's clone number
4201 matches the window's clone number process the overlay even if
4202 the overlay's window property doesn't match the current window.
4203
d68443dc
MR
4204 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4205 (Fwindow_hchild): Rename to Fwindow_left_child.
4206 (Fwindow_next): Rename to Fwindow_next_sibling.
4207 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
4208 (resize_window_check): Rename to window_resize_check.
4209 (resize_window_apply): Rename to window_resize_apply.
4210 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4211 (Fdelete_other_windows_internal, resize_frame_windows)
4212 (Fsplit_window_internal, Fdelete_window_internal)
4213 (grow_mini_window, shrink_mini_window)
4214 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 4215
c7e73be5
JD
42162011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4217
4218 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4219 (emacs_fixed_set_min_size): Remove.
4220 (emacs_fixed_new): Take frame as argument.
4221
4222 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4223 (_EmacsFixedPrivate): Remove minwidth/height.
4224 Add struct frame *f.
4225 (emacs_fixed_init): Initialize priv->f.
4226 (get_parent_class, emacs_fixed_set_min_size): Remove.
4227 (emacs_fixed_new): Set priv->f to argument.
4228 (emacs_fixed_get_preferred_width)
4229 (emacs_fixed_get_preferred_height): Use min_width/height from
4230 frames size_hint to set minimum and natural (Bug#8919).
4231 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4232 and use min_width/height from frames size_hint to set
4233 min_width/height (Bug#8919).
4234
4235 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
4236 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4237 Fix indentation.
c7e73be5 4238
cf99dcf8
EZ
42392011-06-26 Eli Zaretskii <eliz@gnu.org>
4240
4241 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4242 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4243 called at ZV.
4244
029529ac
CY
42452011-06-26 Chong Yidong <cyd@stupidchicken.com>
4246
4247 * process.c (wait_reading_process_output): Bypass select if
4248 waiting for a cell while ignoring keyboard input, and input is
4249 pending. Suggested by Jan Djärv (Bug#8869).
4250
7a7ef429
PE
42512011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4252
4253 Use gnulib's dup2 module instead of rolling our own.
4254 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4255
11fdef7d 42562011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
4257
4258 * dispnew.c (scrolling_window): Before scrolling, turn off a
4259 mouse-highlight in the window being scrolled.
4260
cd3520a4
JB
42612011-06-24 Juanma Barranquero <lekktu@gmail.com>
4262
4263 Move DEFSYM to lisp.h and use everywhere.
4264
4265 * character.h (DEFSYM): Move declaration...
4266 * lisp.h (DEFSYM): ...here.
4267
4268 * gnutls.c:
4269 * minibuf.c:
4270 * w32menu.c:
4271 * w32proc.c:
4272 * w32select.c: Don't include character.h.
4273
4274 * alloc.c (syms_of_alloc):
4275 * buffer.c (syms_of_buffer):
4276 * bytecode.c (syms_of_bytecode):
4277 * callint.c (syms_of_callint):
4278 * casefiddle.c (syms_of_casefiddle):
4279 * casetab.c (init_casetab_once):
4280 * category.c (init_category_once, syms_of_category):
4281 * ccl.c (syms_of_ccl):
4282 * cmds.c (syms_of_cmds):
4283 * composite.c (syms_of_composite):
4284 * dbusbind.c (syms_of_dbusbind):
4285 * dired.c (syms_of_dired):
4286 * dispnew.c (syms_of_display):
4287 * doc.c (syms_of_doc):
4288 * editfns.c (syms_of_editfns):
4289 * emacs.c (syms_of_emacs):
4290 * eval.c (syms_of_eval):
4291 * fileio.c (syms_of_fileio):
4292 * fns.c (syms_of_fns):
4293 * frame.c (syms_of_frame):
4294 * fringe.c (syms_of_fringe):
4295 * insdel.c (syms_of_insdel):
4296 * keymap.c (syms_of_keymap):
4297 * lread.c (init_obarray, syms_of_lread):
4298 * macros.c (syms_of_macros):
4299 * msdos.c (syms_of_msdos):
4300 * print.c (syms_of_print):
4301 * process.c (syms_of_process):
4302 * search.c (syms_of_search):
4303 * sound.c (syms_of_sound):
4304 * syntax.c (init_syntax_once, syms_of_syntax):
4305 * terminal.c (syms_of_terminal):
4306 * textprop.c (syms_of_textprop):
4307 * undo.c (syms_of_undo):
4308 * w32.c (globals_of_w32):
4309 * window.c (syms_of_window):
4310 * xdisp.c (syms_of_xdisp):
4311 * xfaces.c (syms_of_xfaces):
4312 * xfns.c (syms_of_xfns):
4313 * xmenu.c (syms_of_xmenu):
4314 * xsettings.c (syms_of_xsettings):
4315 * xterm.c (syms_of_xterm): Use DEFSYM.
4316
4228cf16
TZ
43172011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4318
cd3520a4 4319 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 4320
7fcccf1e
PE
43212011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4322
7efb4e0e
PE
4323 Integer and buffer overflow fixes (Bug#8873).
4324
ff5844ad
PE
4325 * print.c (printchar, strout): Check for string overflow.
4326 (PRINTPREPARE, printchar, strout):
4327 Don't set size unless allocation succeeds.
4328
90532f02
PE
4329 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4330 for sizes. Check for string overflow more accurately.
4331 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4332
6d84508d
PE
4333 * macros.c: Integer and buffer overflow fixes.
4334 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4335 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4336 Use ptrdiff_t, not int, for sizes.
4337 Don't increment bufsize until after realloc succeeds.
4338 Check for size-calculation overflow.
4339 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4340
437b2cb4
PE
4341 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4342
8b9ac8b4
PE
4343 * lread.c: Integer overflow fixes.
4344 (read_integer): Radix is now EMACS_INT, not int,
4345 to improve quality of diagnostics for out-of-range radices.
4346 Calculate buffer size correctly for out-of-range radices.
4347 (read1): Check for integer overflow in radices, and in
4348 read-circle numbers.
82cb60d3
PE
4349 (read_escape): Avoid int overflow.
4350 (Fload, openp, read_buffer_size, read1)
4351 (substitute_object_recurse, read_vector, read_list, map_obarray):
4352 Use ptrdiff_t, not int, for sizes.
4353 (read1): Use EMACS_INT, not int, for sizes.
20270765 4354 Check for size overflow.
8b9ac8b4 4355
7fcccf1e
PE
4356 * image.c (cache_image): Check for size arithmetic overflow.
4357
bfbbd7e7
PE
4358 * lread.c: Integer overflow issues.
4359 (saved_doc_string_size, saved_doc_string_length)
4360 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4361 Now ptrdiff_t, not int.
4362 (read1): Don't assume doc string length fits in int. Check for
4363 out-of-range doc string lengths.
4364 (read_list): Don't assume file position fits in int.
39019e54 4365 (read_escape): Check for hex character overflow.
bfbbd7e7 4366
4e323265
LL
43672011-06-22 Leo Liu <sdl.web@gmail.com>
4368
4369 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4370 Move to minibuffer.el.
4371
85fece3e
PE
43722011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4373
20b84ce9 4374 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
4375 The following patches are for when GLYPH_DEBUG && !XASSERT.
4376 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4377 * dispnew.c (flush_stdout):
4378 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4379 Mark as externally visible.
4380 * dispnew.c (check_window_matrix_pointers): Now static.
4381 * dispnew.c (window_to_frame_vpos):
4382 * xfns.c (unwind_create_frame):
4383 * xterm.c (x_check_font): Remove unused local.
4384 * scroll.c (CHECK_BOUNDS):
4385 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4386 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4387 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4388 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4389 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4390 Now static.
4391 (debug_method_add): Use va_list and vsprintf rather than relying
4392 on undefined behavior with wrong number of arguments.
4393 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4394 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4395 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4396 since we're not interested in debugging glyphs with old libraries.
4397 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4398 GCC 4.6.0's static checking.
4399
0766b489
PE
44002011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4401
31fd4b32
PE
4402 Integer overflow and signedness fixes (Bug#8873).
4403 A few related buffer overrun fixes, too.
4404
b79e8648
PE
4405 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4406
0766b489
PE
4407 * dispextern.h (struct face.stipple):
4408 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4409 (x_bitmap_mask, x_allocate_bitmap_record)
4410 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4411 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4412 (x_create_bitmap_from_xpm_data):
4413 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4414 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4415 (.bitmaps_last):
4416 * xfaces.c (load_pixmap):
4417 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4418 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4419 (.bitmaps_last, struct x_output.icon_bitmap):
4420 Use ptrdiff_t, not int, for bitmap indexes.
4421 (x_allocate_bitmap_record): Check for size overflow.
4422 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4423
b081724f
PE
4424 Use ptrdiff_t, not int, for overlay counts.
4425 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4426 * editfns.c (overlays_around, get_pos_property):
4427 * textprop.c (get_char_property_and_overlay):
4428 * xdisp.c (next_overlay_change, note_mouse_highlight):
4429 * xfaces.c (face_at_buffer_position):
21514da7
PE
4430 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4431 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4432 (Fnext_overlay_change, Fprevious_overlay_change)
4433 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 4434 Use ptrdiff_t, not int, for sizes.
21514da7 4435 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 4436
3de73e5e
PE
4437 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4438
2606c57b
PE
4439 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4440 (x_session_initialize): Do not assume string length fits in int.
4441
aaafe47a
PE
4442 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4443 This is unlikely, but can occur if DPI is outlandish.
4444
2674ddc8 4445 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
4446 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4447
28154962
PE
4448 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4449 * xrdb.c (magic_file_p, search_magic_path):
4450 Omit last arg SUFFIX; it was always 0. All callers changed.
4451 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4452
7de51af5
PE
4453 * xfont.c (xfont_match): Avoid need for strlen.
4454
25ed6cc3
PE
4455 * xfns.c: Don't assume strlen fits in int.
4456 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4457
4eab31dd
PE
4458 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4459 not unsigned long, as we prefer signed integers. All callers changed.
4460 Detect integer overflow in repeat count.
4461 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 4462 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 4463
171e2a58
PE
4464 * termcap.c: Don't assume sizes fit in int and never overflow.
4465 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4466 (gobble_line): Check for size-calculation overflow.
4467
ad39faca 4468 * minibuf.c (Fread_buffer):
6e5bb2dc 4469 * lread.c (intern, intern_c_string):
74ca2eb3
PE
4470 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4471 Don't assume string length fits in int.
4472
52c61c22 4473 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
4474 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4475
b5b8c9e5
PE
4476 * font.c: Don't assume string length fits in int.
4477 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4478 Use ptrdiff_t, not int.
ccd6111c
PE
4479 (font_intern_prop): Don't assume string length fits in int.
4480 Don't assume integer property fits in fixnum.
4481 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 4482
882f0d81 4483 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 4484 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
4485 Reformulate so as not to need the command string.
4486 Invoke gzip -cd rather than gunzip, as it's more portable.
4487 (lock_info_type, lock_file_1, lock_file):
4488 Don't assume pid_t and time_t fit in unsigned long.
4489 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4490 (current_lock_owner): Prefer signed type for sizes.
4491 Use memcpy, not strncpy, where memcpy is what is really wanted.
4492 Don't assume (via atoi) that time_t and pid_t fit in int.
4493 Check for time_t and/or pid_t out of range, e.g., via a network share.
4494 Don't alloca where an auto var works fine.
4495
93f4cf88
PE
4496 * fileio.c: Fix some integer overflow issues.
4497 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4498 Don't assume string length fits in int.
4499 (directory_file_name): Don't assume string length fits in long.
4500 (make_temp_name): Don't assume pid fits in int, or that its print
4501 length is less than 20.
4502
f3e92b69
PE
4503 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4504
1bfdaf10
PE
4505 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4506
35016e9a
PE
4507 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4508
3d1e65a1
PE
4509 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4510 We prefer signed integers, even for size calculations.
4511
0b963a93
PE
4512 * emacs.c: Don't assume string length fits in 'int'.
4513 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4514 (main): Don't invoke strlen when not needed.
4515
573f4b54
PE
4516 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4517 (XD_DEBUG_MESSAGE): Don't waste a byte.
4518
989f33ba
PE
4519 * callproc.c (getenv_internal_1, getenv_internal)
4520 (Fgetenv_internal):
965d34eb
PE
4521 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4522
e4d29b33
PE
4523 * lread.c (invalid_syntax): Omit length argument.
4524 All uses changed. This doesn't fix a bug, but it simplifies the
4525 code away from its former Hollerith-constant appearance, and it's
4526 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 4527 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 4528
eb49b136
PE
4529 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4530 This didn't break anything, but it didn't help either.
4531 It's confusing to put a bogus integer in a place where the actual
4532 value does not matter.
9f62aeb1 4533 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 4534 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 4535
15375a22
PE
4536 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4537 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4538 implementation.
b61cc01c
PE
4539 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4540 We prefer signed types, and the value cannot exceed the EMACS_INT
4541 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
4542 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4543 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4544 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 4545
53b2623d
PE
4546 * indent.c (sane_tab_width): New function.
4547 (current_column, scan_for_column, Findent_to, position_indentation)
4548 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 4549 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 4550
51cab52b 4551 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 4552
f2ed8a70
PE
4553 * lisp.h (lint_assume): New macro.
4554 * composite.c (composition_gstring_put_cache):
4555 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4556
abe80cc6
PE
4557 * editfns.c, insdel.c:
4558 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 4559
b02c740e
PE
4560 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4561
ebc96716
PE
4562 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4563
b4e50fa0 4564 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 4565 Use much-faster test for byte-length change.
311d5d7c 4566 Don't assume string byte-length fits in 'int'.
a4cf38e4 4567 Check that character arg fits in 'int'.
85461888 4568 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 4569
c0c1ee9f
PE
4570 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4571
a498d7f4
PE
4572 * fns.c (concat): Catch string overflow earlier.
4573 Do not rely on integer wraparound.
4574
51cab52b
PE
4575 * dispextern.h (struct it.overlay_strings_charpos)
4576 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
4577 * xdisp.c (forward_to_next_line_start)
4578 (back_to_previous_visible_line_start)
4579 (reseat_at_next_visible_line_start, next_element_from_buffer):
4580 Don't arbitrarily truncate the value of 'selective' to int.
4581
76031fad
PE
4582 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4583
5eb55db9
PE
4584 * composite.c: Don't truncate sizes to 'int'.
4585 (composition_gstring_p, composition_reseat_it)
4586 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
4587 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4588 not EMACS_UINT, for indexes.
5eb55db9 4589
0703a717
PE
4590 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4591
d6202519
PE
4592 * buffer.c: Include <verify.h>.
4593 (struct sortvec.priority, struct sortstr.priority):
8961a454 4594 Now EMACS_INT, not int.
c20998a7 4595 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
4596 (struct sortstr.size, record_overlay_string)
4597 (struct sortstrlist.size, struct sortlist.used):
4598 Don't truncate size to int.
4599 (record_overlay_string): Check for size-calculation overflow.
d6202519 4600 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 4601
d5a19415
JM
46022011-06-22 Jim Meyering <meyering@redhat.com>
4603
029529ac 4604 Don't leak an XBM-image-sized buffer
d5a19415
JM
4605 * image.c (xbm_load): Free the image buffer after using it.
4606
a9041e6c
PE
46072011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4608
4609 Port to Sun C.
4610 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4611 that Sun C diagnosed.
4612 * fns.c (secure_hash): Fix pointer signedness issue.
4613 * intervals.c (static_offset_intervals): New function.
4614 (offset_intervals): Use it.
4615
7f3f739f
LL
46162011-06-21 Leo Liu <sdl.web@gmail.com>
4617
4618 * deps.mk (fns.o):
4619 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4620 sha512.h.
4621
4622 * fns.c (secure_hash): Rename from crypto_hash_function and change
4623 the first arg to accept symbols.
5b66d427 4624 (Fsecure_hash): New primitive.
7f3f739f
LL
4625 (syms_of_fns): New symbols.
4626
76147d94
DD
46272011-06-20 Deniz Dogan <deniz@dogan.se>
4628
4629 * process.c (Fset_process_buffer): Clarify return value in
4630 docstring.
4631
7d7d0045
CY
46322011-06-18 Chong Yidong <cyd@stupidchicken.com>
4633
4634 * dispnew.c (add_window_display_history): Use BVAR.
4635
4636 * xdisp.c (debug_method_add): Use BVAR.
4637 (check_window_end, dump_glyph_matrix, dump_glyph)
4638 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4639
4640 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4641 Likewise.
4642
4643 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4644 check till after the cache is created in init_frame_faces.
4645
ff2bc410
SM
46462011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4647
4648 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4649
28177add
PE
46502011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4651
dd3482fe
PE
4652 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4653 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4654 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4655
393d71f3 4656 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
4657 * fileio.c (Finsert_file_contents):
4658 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4659 Remove the old (too-loose) buffer overflow checks.
4660 They weren't needed, since make_gap checks for buffer overflow.
4661 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4662 The old code merely checked for Emacs fixnum overflow, and relied
4663 on undefined (wraparound) behavior. The new code avoids undefined
4664 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4665
2e6813b0 4666 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
4667 Tune. Don't use wider integers than needed. Don't use alloca.
4668 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 4669
599a9e4f
PE
4670 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4671
99561444
PE
4672 * insdel.c, lisp.h (buffer_overflow): New function.
4673 (insert_from_buffer_1, replace_range, replace_range_2):
4674 * insdel.c (make_gap_larger):
4675 * editfns.c (Finsert_char):
4676 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4677
28177add
PE
4678 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4679
e69dafad
PE
46802011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4681
4baa020d 4682 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 4683
b1c46f02
PE
4684 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4685 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4686
e69dafad
PE
4687 * fileio.c: Don't assume EMACS_INT fits in off_t.
4688 (emacs_lseek): New static function.
4689 (Finsert_file_contents, Fwrite_region): Use it.
4690 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4691
566684ea
PE
4692 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4693
e6966cd6
PE
4694 * fns.c: Don't overflow int when computing a list length.
4695 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4696 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4697 truncation on 64-bit hosts. Check for QUIT every
4698 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4699 faster and is responsive enough.
4700 (Flength): Report an error instead of overflowing an integer.
4701 (Fsafe_length): Return a float if the value is not representable
4702 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 4703 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 4704 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 4705
dd0b0efb
PE
4706 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4707 (header_size, word_size): New constants.
4708 (allocate_vectorlike): Don't check size overflow here.
4709 (allocate_vector): Check it here instead, since this is the only
4710 caller of allocate_vectorlike that could cause overflow.
4711 Check that the new vector's length is representable as a fixnum.
4712
86fe5cfe
PE
4713 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4714 The previous code was bogus. For example, next_almost_prime (32)
4715 returned 39, which is undesirable as it is a multiple of 3; and
4716 next_almost_prime (24) returned 25, which is a multiple of 5 so
4717 why was the code bothering to check for multiples of 7?
4718
80e88859
PE
4719 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4720
4a2f0ad6
PE
4721 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4722
f66c7cf8
PE
4723 Variadic C functions now count arguments with ptrdiff_t.
4724 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4725 Back then I didn't know that the Emacs coding style prefers signed int.
4726 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
4727 were being counted with int, which may truncate counts on 64-bit
4728 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
4729 * lisp.h (struct Lisp_Subr.function.aMANY)
4730 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4731 Arg counts are now ptrdiff_t, not size_t.
4732 All variadic functions and their callers changed accordingly.
4733 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4734 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4735 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4736 * callint.c (Fcall_interactively): Check arg count for overflow,
4737 to avoid potential buffer overrun. Use signed char, not 'int',
4738 for 'varies' array, so that we needn't bother to check its size
4739 calculation for overflow.
4740 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4741 * eval.c (apply_lambda):
4742 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4743 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4744 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4745
a1759b76
PE
4746 * callint.c (Fcall_interactively): Don't use index var as event count.
4747
d96be9fc
PE
4748 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4749 * mem-limits.h (SIZE): Remove; no longer used.
4750
a690a978 4751 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 4752
578c21e6
PE
4753 Remove unnecessary casts.
4754 * xterm.c (x_term_init):
4755 * xfns.c (x_set_border_pixel):
4756 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4757 These aren't needed now that we assume ANSI C.
4758
96f53c6c
PE
4759 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4760 It's more likely to cause problems (due to unsigned overflow)
4761 than to cure them.
4762
83c77d31
PE
4763 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4764
ee2079f1
PE
4765 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4766
6da65536
PE
4767 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4768
7147c4a4
PE
4769 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4770
193e32d9
PE
4771 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4772
e5533da6
PE
4773 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4774
9910e595
PE
4775 GLYPH_CODE_FACE returns EMACS_INT, not int.
4776 * dispextern.h (merge_faces):
4777 * xfaces.c (merge_faces):
01103c44
PE
4778 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4779 Don't assume EMACS_INT fits in int.
9910e595 4780
2638320e
PE
4781 * character.h (CHAR_VALID_P): Remove unused parameter.
4782 * fontset.c, lisp.h, xdisp.c: All uses changed.
4783
045eb8d9
PE
4784 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4785
c1f134b5
PE
4786 * fns.c (concat): Minor tuning based on overflow analysis.
4787 This doesn't fix any bugs. Use int to hold character, instead
4788 of constantly refetching from Emacs object. Use XFASTINT, not
4789 XINT, for value known to be a character. Don't bother comparing
4790 a single byte to 0400, as it's always less.
4791
395fcb93 4792 * floatfns.c (Fexpt):
327eeec8
PE
4793 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4794
abbd3d23
PE
4795 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4796 for characters.
4797
684a03ef
PE
4798 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4799
0fed43f3
PE
4800 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4801 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4802 incorrectly succeed when S was a string, because 4294967386 was
4803 truncated before it was used.
4804
8fd02eb7
PE
4805 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4806 Otherwise, an out-of-range integer could cause undefined behavior
4807 on a 64-bit host.
4808
f8c86b69
PE
4809 * composite.c: Use int, not EMACS_INT, for characters.
4810 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4811 EMACS_INT, for values that are known to be in character range.
4812 This doesn't fix any bugs but is the usual style inside Emacs and
4813 may generate better code on 32-bit machines.
4814
34206dd2
PE
4815 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4816 This is for reasons similar to the recent CHAR_STRING fix.
4817 * charset.c (Fencode_char): Check that character arg is actually
4818 a character. Pass an int to ENCODE_CHAR.
4819 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4820 wider than 'int', as a compile-time check to prevent future regressions
4821 in this area.
4822
c5958d4c 4823 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
4824
4825 Make sure a 64-bit char is never passed to CHAR_STRING.
4826 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4827 by silently ignoring the top 32 bits, allowing some values
4828 that were far too large to be valid characters.
4829 * character.h: Include <verify.h>.
4830 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4831 arguments are no wider than unsigned, as a compile-time check
4832 to prevent future regressions in this area.
4833 * data.c (Faset):
01103c44 4834 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
4835 (Fsubst_char_in_region):
4836 * fns.c (concat):
4837 * xdisp.c (decode_mode_spec_coding):
4838 Adjust to CHAR_STRING's new requirement.
4839 * editfns.c (Finsert_char, Fsubst_char_in_region):
4840 * fns.c (concat): Check that character args are actually
4841 characters. Without this test, these functions did the wrong
4842 thing with wildly out-of-range values on 64-bit hosts.
4843
d37ca623
PE
4844 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4845 These casts should not be needed on 32-bit hosts, either.
4846 * keyboard.c (read_char):
4847 * lread.c (Fload): Remove casts to unsigned.
4848
ea204efb
PE
4849 * lisp.h (UNSIGNED_CMP): New macro.
4850 This fixes comparison bugs on 64-bit hosts.
4851 (ASCII_CHAR_P): Use it.
4852 * casefiddle.c (casify_object):
01103c44 4853 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
4854 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4855 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4856 * dispextern.h (FACE_FROM_ID):
4857 * keyboard.c (read_char): Use UNSIGNED_CMP.
4858
41cb286c
PE
4859 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4860 not to EMACS_INT, to avoid GCC warning.
4861
4a1b9832
PE
4862 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4863
55daad71
PE
4864 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4865 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4866 isn't needed on 32-bit machines.
8f95c75c 4867
01103c44
PE
4868 * buffer.c (Fgenerate_new_buffer_name):
4869 Use EMACS_INT for count, not int.
0ceccced 4870 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
4871
4872 * data.c (Qcompiled_function): Now static.
4873
c6f072e7
PE
4874 * window.c (window_body_lines): Now static.
4875
20ce5912
PE
4876 * image.c (gif_load): Rename local to avoid shadowing.
4877
9c4c5f81
PE
4878 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4879 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4880 * alloc.c (make_save_value): Integer argument is now of type
4881 ptrdiff_t, not int.
4882 (mark_object): Use ptrdiff_t, not int.
4883 * lisp.h (pD): New macro.
4884 * print.c (print_object): Use it.
4885
c0c5c8ae
PE
4886 * alloc.c: Use EMACS_INT, not int, to count objects.
4887 (total_conses, total_markers, total_symbols, total_vector_size)
4888 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
4889 (total_free_floats, total_floats, total_free_intervals)
4890 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
4891 Now EMACS_INT, not int. All uses changed.
4892 (Fgarbage_collect): Compute overall total using a double, so that
4893 integer overflow is less likely to be a problem. Check for overflow
4894 when converting back to an integer.
5a25e253
PE
4895 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4896 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4897 These were 'int' variables that could overflow on 64-bit hosts;
4898 they were never used, so remove them instead of repairing them.
211a0b2a 4899 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
4900 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4901 Previously, this ceilinged at INT_MAX, but that doesn't work on
4902 64-bit machines.
e46bb31a 4903 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 4904
c78baabf 4905 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 4906 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
4907 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4908 when a (possibly-narrower) signed value would do just as well.
4909 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 4910
c9d624c6
PE
4911 * alloc.c: Catch some string size overflows that we were missing.
4912 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4913 for convenience in STRING_BYTES_MAX.
4914 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4915 The definition here is exact; the one in lisp.h was approximate.
4916 (allocate_string_data): Check for string overflow. This catches
4917 some instances we weren't catching before. Also, it catches
4918 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4919 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4920 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 4921
c9d624c6
PE
4922 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4923 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 4924 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 4925
353032ce
PE
4926 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4927
2bccce07
PE
4928 * alloc.c (Fmake_string): Check for out-of-range init.
4929
0ac30604
SM
49302011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4931
4932 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4933
c195f2de
JD
49342011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4935
4936 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4937 xg_get_default_scrollbar_width.
4938
4939 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4940 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4941 (style_changed_cb): Call update_theme_scrollbar_width and call
4942 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4943 all frames (Bug#8505).
4944 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4945 Call gtk_window_set_resizable if HAVE_GTK3.
4946 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4947 and height if HAVE_GTK3 (Bug#8505).
4948 (scroll_bar_width_for_theme): New variable.
4949 (update_theme_scrollbar_width): New function.
4950 (xg_get_default_scrollbar_width): Move code to
4951 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4952 (xg_initialize): Call update_theme_scrollbar_width.
4953
4954 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4955
4956 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4957
e10ac9f1
MR
49582011-06-12 Martin Rudalics <rudalics@gmx.at>
4959
4960 * frame.c (make_frame): Call other_buffer_safely instead of
4961 other_buffer.
4962
4963 * window.c (temp_output_buffer_show): Call display_buffer with
4964 second argument Vtemp_buffer_show_specifiers and reset latter
4965 immediately after the call.
4966 (Vtemp_buffer_show_specifiers): New variable.
4967 (auto_window_vscroll_p, next_screen_context_lines)
4968 (Vscroll_preserve_screen_position): Remove leading asterisks from
4969 doc-strings.
4970
2d3c217e 49712011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 4972
7b7f97e8 4973 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
4974 * buffer.c (Qclone_number): Remove for now, as it's unused.
4975 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4976 (record_buffer): Remove unused local.
4977 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4978 (set_frame_buffer_list): Remove; unused.
4979 * frame.h (other_visible_frames): Remove decl.
4980 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4981 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4982 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4983 if HAVE_GPM.
4984 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4985 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4986 Define only if HAVE_GPM.
4987 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4988 (update_hints_inhibit): Remove; never set. All uses removed.
4989 * widgetprv.h (emacsFrameClassRec): Remove decl.
4990 * window.c (delete_deletable_window): Now returns void, since it
4991 wasn't returning anything.
4992 (compare_window_configurations): Remove unused locals.
4993 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4994 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
4995 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4996 the same widths as pointers. This follows up on the 2011-05-06 patch.
4997 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4998 * xterm.h: Likewise.
4999 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5000
1384b89e
JB
50012011-06-12 Juanma Barranquero <lekktu@gmail.com>
5002
5003 * makefile.w32-in: Update dependencies.
5004 (LISP_H): Add lib/intprops.h.
5005
1100a63c
CY
50062011-06-11 Chong Yidong <cyd@stupidchicken.com>
5007
5008 * image.c (gif_load): Add animation frame delay to the metadata.
5009 (syms_of_image): Use DEFSYM. New symbol `delay'.
5010
6198ccd0
MR
50112011-06-11 Martin Rudalics <rudalics@gmx.at>
5012
5013 * window.c (delete_deletable_window): Re-add.
5014 (Fset_window_configuration): Rewrite to handle dead buffers and
5015 consequently deletable windows.
5016 (window_tree, Fwindow_tree): Remove. Supply functionality in
5017 window.el.
5018 (compare_window_configurations): Simplify code.
5019
b6e3633c
AS
50202011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5021
1ab0dee5
AS
5022 * image.c (imagemagick_load_image): Fix type mismatch.
5023 (Fimagemagick_types): Likewise.
5024
b6e3633c
AS
5025 * window.h (replace_buffer_in_windows): Declare.
5026
9397e56f
MR
50272011-06-11 Martin Rudalics <rudalics@gmx.at>
5028
5029 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5030 Qclone_number. Remove external declaration of Qdelete_window.
5031 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5032 code.
640c8776
SM
5033 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5034 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
5035 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5036 buffer list implementation.
5037 (other_buffer_safely): New function.
5038 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5039 calls to replace_buffer_in_windows and
5040 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5041 if allowed.
5042 (record_buffer): Inhibit quitting and rewrite using quittable
5043 functions. Run Qbuffer_list_update_hook if allowed.
5044 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
5045 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5046 Move switch-to-buffer to window.el.
9397e56f
MR
5047 (bury-buffer): Move to window.el.
5048 (Vbuffer_list_update_hook): New variable.
5049
5050 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5051 section.
5052
5053 * window.h (resize_frame_windows): Move up in code.
5054 (Fwindow_frame): Remove EXFUN.
5055 (replace_buffer_in_all_windows): Remove prototype.
5056 (replace_buffer_in_windows_safely): Add prototype.
5057
5058 * window.c: Declare Qdelete_window static again. Move down
5059 declaration of select_count.
5060 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5061 (Fother_window): Move to window.el.
5062 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5063 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5064 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5065 window.el.
5066 (replace_buffer_in_windows): Implement by calling
5067 Qreplace_buffer_in_windows.
5068 (replace_buffer_in_all_windows): Remove with some functionality
5069 moved into replace_buffer_in_windows_safely.
5070 (replace_buffer_in_windows_safely): New function.
5071 (select_window_norecord, select_frame_norecord): Move in front
5072 of run_window_configuration_change_hook. Remove now obsolete
5073 declarations.
640c8776
SM
5074 (Fset_window_buffer): Rewrite doc-string.
5075 Call Qrecord_window_buffer.
9397e56f
MR
5076 (keys_of_window): Move binding for other-window to window.el.
5077
b50691aa
CY
50782011-06-11 Chong Yidong <cyd@stupidchicken.com>
5079
5080 * dispextern.h (struct image): Replace data member, whose int_val
5081 and ptr_val fields were not used by anything, with a single
5082 lisp_val object.
5083
5084 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5085 (gif_clear_image, gif_load, imagemagick_load_image)
5086 (gs_clear_image, gs_load): Callers changed.
5087
3f754b86
PE
50882011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5089
cca69397
PE
5090 * buffer.h: Include <time.h>, for time_t.
5091 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5092
109e28d0
PE
5093 Fix minor problems found by static checking.
5094
60737f02
PE
5095 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5096
4b66faf3
PE
5097 Make identifiers static if they are not used in other modules.
5098 * data.c (Qcompiled_function, Qframe, Qvector):
5099 * image.c (QimageMagick, Qsvg):
5100 * minibuf.c (Qmetadata):
5101 * window.c (resize_window_check, resize_root_window): Now static.
5102 * window.h (resize_window_check, resize_root_window): Remove decls.
5103
109e28d0
PE
5104 * window.c (window_deletion_count, delete_deletable_window):
5105 Remove; unused.
46a4ce9e
PE
5106 (window_body_lines): Now static.
5107 (Fdelete_other_windows_internal): Mark vars as initialized.
5108 Make sure 'resize_failed' is initialized.
5109 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5110 (resize_window_apply): Remove unused local.
5111 * window.h (delete_deletable_window): Remove decl.
5112
109e28d0 5113 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
5114 (imagemagick_load_image): Fix pointer signedness problem by changing
5115 last arg from unsigned char * to char *. All uses changed.
5116 Also, fix a local for similar reasons.
5117 Remove unused locals. Remove locals to avoid shadowing.
5118 (fn_rsvg_handle_free): Remove; unused.
5119 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 5120 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 5121
3f754b86
PE
5122 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5123
2547adb1
CY
51242011-06-10 Chong Yidong <cyd@stupidchicken.com>
5125
5126 * image.c (gif_load): Fix omitted cast error introduced by
5127 2011-06-06 change.
5128
2c8e37d4
MR
51292011-06-10 Martin Rudalics <rudalics@gmx.at>
5130
5131 * window.h (resize_proportionally, orig_total_lines)
5132 (orig_top_line): Remove from window structure.
5133 (set_window_height, set_window_width, change_window_heights)
5134 (Fdelete_window): Remove prototypes.
5135 (resize_frame_windows): Remove duplicate declaration.
5136
440a42e3
EZ
51372011-06-10 Eli Zaretskii <eliz@gnu.org>
5138
5139 * window.h (resize_frame_windows, resize_window_check)
5140 (delete_deletable_window, resize_root_window)
5141 (resize_frame_windows): Declare prototypes.
5142
5143 * window.c (resize_window_apply): Make definition be "static" to
5144 match the prototype.
5145
562dd5e9
MR
51462011-06-10 Martin Rudalics <rudalics@gmx.at>
5147
5148 * window.c: Remove declarations of Qwindow_size_fixed,
5149 window_min_size_1, window_min_size_2, window_min_size,
5150 size_window, window_fixed_size_p, enlarge_window, delete_window.
5151 Remove static from declaration of Qdelete_window, it's
5152 temporarily needed by Fbury_buffer.
5153 (replace_window): Don't assign orig_top_line and
5154 orig_total_lines.
5155 (Fdelete_window, delete_window): Remove. Window deletion is
5156 handled by window.el.
640c8776
SM
5157 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5158 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
5159 (Fdelete_other_windows): Remove. Deleting other windows is
5160 handled by window.el.
5161 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5162 handled in window.el.
5163 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5164 Window minimum sizes are handled in window.el.
5165 (shrink_windows, size_window, set_window_height)
5166 (set_window_width, change_window_heights, window_height)
5167 (window_width, CURBEG, CURSIZE, enlarge_window)
5168 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5169 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5170 handled in window.el.
5171 (make_dummy_parent): Rename to make_parent_window and give it a
5172 second argument horflag.
5173 (make_window): Don't set resize_proportionally any more.
5174 (Fsplit_window): Remove. Windows are split in window.el.
5175 (save_restore_action, save_restore_orig_size)
5176 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5177 Resize mini windows in window.el.
5178 (grow_mini_window, shrink_mini_window): Implement by calling
5179 Qresize_root_window_vertically, resize_window_check and
5180 resize_window_apply.
640c8776
SM
5181 (saved_window, Fset_window_configuration, save_window_save):
5182 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
5183 resize_proportionally.
5184 (window_min_height, window_min_width): Move to window.el.
5185 (keys_of_window): Move bindings for delete-other-windows,
5186 split-window, delete-window and enlarge-window to window.el.
5187
5188 * buffer.c: Temporarily extern Qdelete_window.
5189 (Fbury_buffer): Temporarily call Qdelete_window instead of
5190 Fdelete_window (Fbury_buffer will move to window.el soon).
5191
5192 * frame.c (set_menu_bar_lines_1): Remove code handling
5193 orig_top_line and orig_total_lines.
5194
5195 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5196 set_window_height but set heights directly.
5197 (change_frame_size_1): Use resize_frame_windows.
5198
5199 * xdisp.c (init_xdisp): Don't use set_window_height but set
5200 heights directly.
5201
640c8776
SM
5202 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5203 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
5204 run_window_configuration_change_hook.
5205
5206 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5207 instead of change_window_heights and run
5208 run_window_configuration_change_hook.
5209
1a13852e
MR
52102011-06-09 Martin Rudalics <rudalics@gmx.at>
5211
5212 * window.c (replace_window): Rename second argument REPLACEMENT to
5213 NEW. New third argument SETFLAG. Rewrite.
5214 (delete_window, make_dummy_parent): Call replace_window with
5215 third argument 1.
5216 (window_list_1): Move down in code.
5217 (run_window_configuration_change_hook): Move set_buffer part
5218 before select_frame_norecord part in order to unwind correctly.
5219 Rename count1 to count.
5220 (recombine_windows, delete_deletable_window, resize_root_window)
5221 (Fdelete_other_windows_internal)
5222 (Frun_window_configuration_change_hook, make_parent_window)
5223 (resize_window_check, resize_window_apply, Fresize_window_apply)
5224 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
5225 (Fdelete_window_internal, Fresize_mini_window_internal):
5226 New functions.
1a13852e
MR
5227 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5228
f3d1777e
MR
52292011-06-08 Martin Rudalics <rudalics@gmx.at>
5230
496e208e
MR
5231 * window.h (window): Add some new members to window structure -
5232 normal_lines, normal_cols, new_total, new_normal, clone_number,
5233 splits, nest, prev_buffers, next_buffers.
5234 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 5235 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 5236
f3d1777e
MR
5237 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5238 Remove.
496e208e
MR
5239 (make_dummy_parent): Set new members of windows structure.
5240 (make_window): Move down in code. Handle new members of window
5241 structure.
5242 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5243 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5244 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5245 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
5246 (Fset_window_next_buffers, Fset_window_clone_number):
5247 New functions.
496e208e
MR
5248 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5249 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5250 Doc-string fixes.
5251 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5252 Argument WINDOW can be now internal window too.
5253 (Fwindow_use_time): Move up in code.
5254 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5255 Rewrite doc-string.
5256 (Fset_window_configuration, saved_window)
5257 (Fcurrent_window_configuration, save_window_save): Handle new
5258 members of window structure.
b9e809c2
MR
5259 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5260 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5261 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5262 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5263 Qget_mru_window, Qresize_root_window,
5264 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5265 Qauto_buffer_name; staticpro them.
f3d1777e 5266
abde8f8c
MR
52672011-06-07 Martin Rudalics <rudalics@gmx.at>
5268
5269 * window.c (Fwindow_total_size, Fwindow_left_column)
5270 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5271 (Fwindow_list_1): New functions.
5272 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
5273 (Fwindow_width, Fscroll_left, Fscroll_right):
5274 Use window_body_cols instead of window_box_text_cols.
5275 (delete_window, Fset_window_configuration):
5276 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
5277 (delete_all_subwindows): Take a window as argument and not a
5278 structure. Rewrite.
190b47e6
MR
5279 (window_loop): Remove handling of GET_LRU_WINDOW and
5280 GET_LARGEST_WINDOW.
5281 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
5282
5283 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
5284 window_box_text_cols. delete_all_subwindows now takes a
5285 Lisp_Object as argument.
abde8f8c 5286
640c8776
SM
5287 * indent.c (compute_motion, Fcompute_motion):
5288 Use window_body_cols instead of window_box_text_cols.
abde8f8c 5289
fa8a67e6
MR
5290 * frame.c (delete_frame): Call delete_all_subwindows with root
5291 window as argument.
5292
a54e3482
DC
52932011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5294
5295 * fns.c (Fputhash): Document return value.
5296
60002bf5
CY
52972011-06-06 Chong Yidong <cyd@stupidchicken.com>
5298
5299 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5300
0c671da6 53012011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 5302
b862a52a 5303 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 5304
be44ca6c
PE
5305 Check for overflow when converting integer to cons and back.
5306 * charset.c (Fdefine_charset_internal, Fdecode_char):
5307 Use cons_to_unsigned to catch overflow.
5308 (Fencode_char): Use INTEGER_TO_CONS.
5309 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5310 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5311 * data.c (long_to_cons, cons_to_long): Remove.
5312 (cons_to_unsigned, cons_to_signed): New functions.
5313 These signal an error for invalid or out-of-range values.
5314 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5315 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5316 * font.c (Ffont_variation_glyphs):
5317 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5318 * lisp.h: Include <intprops.h>.
5319 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5320 (cons_to_signed, cons_to_unsigned): New decls.
5321 (long_to_cons, cons_to_long): Remove decls.
5322 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5323 (Fprimitive_undo): Use CONS_TO_INTEGER.
5324 * xfns.c (Fx_window_property): Likewise.
5325 * xselect.c: Include <limits.h>.
5326 (x_own_selection, selection_data_to_lisp_data):
5327 Use INTEGER_TO_CONS.
5328 (x_handle_selection_request, x_handle_selection_clear)
5329 (x_get_foreign_selection, Fx_disown_selection_internal)
5330 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5331 (lisp_data_to_selection_data): Use cons_to_unsigned.
5332 (x_fill_property_data): Use cons_to_signed.
5333 Report values out of range.
5334
d1f3d2af
PE
5335 Check for buffer and string overflow more precisely.
5336 * buffer.h (BUF_BYTES_MAX): New macro.
5337 * lisp.h (STRING_BYTES_MAX): New macro.
5338 * alloc.c (Fmake_string):
5339 * character.c (string_escape_byte8):
5340 * coding.c (coding_alloc_by_realloc):
5341 * doprnt.c (doprnt):
5342 * editfns.c (Fformat):
5343 * eval.c (verror):
5344 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5345 since they may not be the same number.
5346 * editfns.c (Finsert_char):
5347 * fileio.c (Finsert_file_contents):
5348 Likewise for BUF_BYTES_MAX.
5349
dd52fcea
PE
5350 * image.c: Use ptrdiff_t, not int, for sizes.
5351 (slurp_file): Switch from int to ptrdiff_t.
5352 All uses changed.
5353 (slurp_file): Check that file size fits in both size_t (for
5354 malloc) and ptrdiff_t (for sanity and safety).
5355
7f9bbdbb
PE
5356 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5357 if b->modtime has its maximal value.
5358
dfe18f82
PE
5359 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5360
84acfcf0
PE
5361 Don't assume time_t can fit into int.
5362 * buffer.h (struct buffer.modtime): Now time_t, not int.
5363 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5364 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5365
ccd9a01a
PE
5366 Minor fixes for signed vs unsigned integers.
5367 * character.h (MAYBE_UNIFY_CHAR):
5368 * charset.c (maybe_unify_char):
5369 * keyboard.c (read_char, reorder_modifiers):
5370 XINT -> XFASTINT, since the integer must be nonnegative.
5371 * ftfont.c (ftfont_spec_pattern):
5372 * keymap.c (access_keymap, silly_event_symbol_error):
5373 XUINT -> XFASTINT, since the integer must be nonnegative.
5374 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5375 since it makes no difference and we prefer signed.
5376 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5377 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5378 nonnegative.
5379
d6d100dd
SM
53802011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5381
5382 * window.h (Fwindow_frame): Declare.
5383
2b6148e4
PE
53842011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5385
5386 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5387 (SPARE_MEMORY): Always define.
5388 (LARGE_REQUEST): Remove.
5389 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5390
f230ecc9
MR
53912011-06-06 Martin Rudalics <rudalics@gmx.at>
5392
727e958e
MR
5393 * lisp.h: Move EXFUNS for Fframe_root_window,
5394 Fframe_first_window and Fset_frame_selected_window to window.h.
5395
5396 * window.h: Move EXFUNS for Fframe_root_window,
5397 Fframe_first_window and Fset_frame_selected_window here from
5398 lisp.h.
5399
5400 * frame.c (Fwindow_frame, Fframe_first_window)
5401 (Fframe_root_window, Fframe_selected_window)
5402 (Fset_frame_selected_window): Move to window.c.
5403 (Factive_minibuffer_window): Move to minibuf.c.
5404 (Fother_visible_frames_p): New function.
5405
5406 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5407
f230ecc9
MR
5408 * window.c (decode_window, decode_any_window): Move up in code.
5409 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5410 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
5411 (Fwindow_buffer): Move up and rewrite doc-string.
5412 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5413 (Fwindow_prev): New functions.
727e958e
MR
5414 (Fwindow_frame): Move here from frame.c. Accept any window as
5415 argument.
5416 (Fframe_root_window, Fframe_first_window)
5417 (Fframe_selected_window): Move here from frame.c. Accept frame
5418 or arbitrary window as argument. Update doc-strings.
5419 (Fminibuffer_window): Move up in code.
5420 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
5421 (Fset_frame_selected_window): Move here from frame.c.
5422 Marginal rewrite.
727e958e
MR
5423 (Fselected_window, select_window, Fselect_window): Move up in
5424 code. Minor doc-string fixes.
f230ecc9 5425
4d09bcf6
PE
54262011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5427
5428 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5429 Do not assume that spare memory exists; that assumption is valid
5430 only if SYSTEM_MALLOC.
5431 (LARGE_REQUEST): New macro, so that the issue of large requests
5432 is separated from the issue of spare memory.
5433
810928a2
AS
54342011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5435
172418ad
AS
5436 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5437 format. (Bug#8806)
5438
43f862f7
AS
5439 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5440
810928a2
AS
5441 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5442 before statements.
5443
a059fe24
JD
54442011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5445
5446 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5447
5448 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5449
5450 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5451 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5452
989bf368
JB
54532011-06-05 Juanma Barranquero <lekktu@gmail.com>
5454
5455 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5456
4b80f674
CY
54572011-06-04 Chong Yidong <cyd@stupidchicken.com>
5458
5459 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5460 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
5461 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5462 New error handlers.
4b80f674
CY
5463 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5464 Obey Vx_select_enable_clipboard_manager. Catch errors in
5465 x_clipboard_manager_save (Bug#8779).
5466 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 5467 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 5468
99a33b77 54692011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
5470
5471 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5472
99a33b77 54732011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
5474
5475 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5476 in the current matrix if keep_current_p is non-zero.
5477
8264569d
EZ
54782011-06-04 Eli Zaretskii <eliz@gnu.org>
5479
5480 * bidi.c (bidi_level_of_next_char): Fix last change.
5481
57f97249
EZ
54822011-06-03 Eli Zaretskii <eliz@gnu.org>
5483
fec2107c 5484 Support bidi reordering of text covered by display properties.
57f97249 5485
fec2107c
EZ
5486 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5487 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5488 (bidi_cache_search, bidi_cache_iterator_state)
5489 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
5490 (bidi_level_of_next_char, bidi_move_to_visually_next):
5491 Support character positions inside a run of characters covered by a
fec2107c
EZ
5492 display string.
5493 (bidi_paragraph_init, bidi_resolve_explicit_1)
5494 (bidi_level_of_next_char): Call bidi_fetch_char and
5495 bidi_fetch_char_advance instead of FETCH_CHAR and
5496 FETCH_CHAR_ADVANCE.
5497 (bidi_init_it): Initialize new members.
5498 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5499 definitions.
5500 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5501 instead of using explicit *_CHAR codes.
d6d100dd
SM
5502 (bidi_resolve_explicit, bidi_resolve_weak):
5503 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
5504 bidirectional text is supported only in multibyte buffers.
5505 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5506 it to initialize the frame_window_p member of struct bidi_it.
5507 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5508 (bidi_resolve_explicit, bidi_resolve_weak)
5509 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5510 bidi_it->nchars is non-positive.
5511 (bidi_level_of_next_char): Don't try to lookup the cache for the
5512 next/previous character if nothing is cached there yet, or if we
5513 were just reseat()'ed to a new position.
c40e2fb2 5514
0e14fe90
EZ
5515 * xdisp.c (set_cursor_from_row): Set start and stop points
5516 according to the row's direction when priming the loop that looks
5517 for the glyph on which to display cursor.
5518 (single_display_spec_intangible_p): Function deleted.
5519 (display_prop_intangible_p): Reimplement to call
5520 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
5521 Accept 3 additional arguments needed by handle_display_spec.
5522 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
5523 values: lists, `(when COND...)' forms, etc.
5524 (single_display_spec_string_p): Support property values that are
5525 lists with the argument STRING its top-level element.
5526 (display_prop_string_p): Fix the condition for processing a
5527 property that is a list to be consistent with handle_display_spec.
fec2107c 5528 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
5529 last portion of handle_display_prop.
5530 (compute_display_string_pos): Accept additional argument
5531 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5532 value of a `display' property is a "replacing spec".
5533 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5534 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5535 the display property, but just return a value indicating whether
5536 the display property will replace the characters it covers.
5537 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5538 frame_window_p members of struct bidi_it.
d6d100dd
SM
5539 (compute_display_string_pos, compute_display_string_end):
5540 New functions.
fec2107c
EZ
5541 (push_it): Accept second argument POSITION, where pop_it should
5542 jump to continue iteration.
5543 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 5544
fec2107c
EZ
5545 * keyboard.c (adjust_point_for_property): Adjust the call to
5546 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
5547
5548 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
5549 (bidi_init_it): Update prototypes.
5550 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
5551 (compute_display_string_pos, compute_display_string_end):
5552 Declare prototypes.
fec2107c
EZ
5553 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5554 EMACS_INT.
fc6f18ce 5555
40087514 55562011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 5557
57f53182
PE
5558 Malloc failure behavior now depends on size of allocation.
5559 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5560 * lisp.h: Change signatures accordingly.
5561 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5562 All callers changed. (Bug#8762)
5563
5564 * gnutls.c: Use Emacs's memory allocators.
5565 Without this change, the gnutls library would invoke malloc etc.
5566 directly, which causes problems on non-SYNC_INPUT hosts, and which
5567 runs afoul of improving memory_full behavior. (Bug#8761)
5568 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5569 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5570 xfree instead of the default malloc, realloc, free.
5571 (Fgnutls_boot): No need to check for memory allocation failure,
5572 since xmalloc does that for us.
5573
ac32cd99 5574 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
5575 * category.c (hash_get_category_set):
5576 * ccl.c (ccl_driver):
5577 * charset.c (Fdefine_charset_internal):
5578 * charset.h (struct charset.hash_index):
5579 * composite.c (get_composition_id, gstring_lookup_cache)
5580 (composition_gstring_put_cache):
5581 * composite.h (struct composition.hash_index):
5582 * dispextern.h (struct image.hash):
5583 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5584 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5585 (hashfn_equal, hashfn_user_defined, make_hash_table)
5586 (maybe_resize_hash_table, hash_lookup, hash_put)
5587 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5588 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5589 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5590 * image.c (make_image, search_image_cache, lookup_image)
5591 (xpm_put_color_table_h):
5592 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 5593 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 5594 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 5595 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
5596 * alloc.c (allocate_vectorlike):
5597 Check for overflow in vector size calculations.
5598 * ccl.c (ccl_driver):
5599 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
5600 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5601 need to be updated by these changes.
40087514
PE
5602 * fns.c (make_hash_table, maybe_resize_hash_table):
5603 Check for integer overflow with large hash tables.
0de4bb68
PE
5604 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5605 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5606 (SXHASH_REDUCE): New macro.
5607 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5608 Use it instead of discarding useful hash info with large hash values.
5609 (sxhash_float): New function.
5610 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5611 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
5612 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5613 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
5614 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5615 Adjust signatures to match updated version of code.
5616 (consing_since_gc): Now EMACS_INT, since a single hash table can
5617 use more than INT_MAX bytes.
5618
698d32e2
DN
56192011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5620
5621 Make it possible to build with GCC-4.6+ -O2 -flto.
5622
5623 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5624
fd6fa53f
SM
56252011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5626
5627 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5628 Call minibuffer-inactive-mode.
5629
864db017
JB
56302011-05-31 Juanma Barranquero <lekktu@gmail.com>
5631
5632 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5633 Update dependencies.
5634
2ad0baf4
DN
56352011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5636
5637 * data.c (init_data): Remove code for UTS, this system is not
5638 supported anymore.
5639
4fcc2638
DN
56402011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5641
5642 Don't force ./temacs to start in terminal mode.
5643
5644 * frame.c (make_initial_frame): Initialize faces in all cases, not
5645 only when CANNOT_DUMP is defined.
5646 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5647
c56e0fd5
DN
56482011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5649
5650 * dispnew.c (add_window_display_history): Use const for the string
5651 pointer. Remove declaration, not needed.
5652
333d54da 56532011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 5654
55d4c1b2 5655 Use 'inline', not 'INLINE'.
333d54da 5656 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
5657 * alloc.c, fontset.c (INLINE): Remove.
5658 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5659 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5660 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5661 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5662 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5663
738db178
DN
56642011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5665
5666 Make it possible to run ./temacs.
5667
5668 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5669 syms_of_callproc does the same thing. Remove test for
5670 "initialized", do it in the caller.
5671 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5672
620c53a6
SM
56732011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5674
5675 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5676 (read_minibuf): Use get_minibuffer.
5677 (syms_of_minibuf): Use DEFSYM.
5678 (Qmetadata): New var.
5679 * data.c (Qbuffer): Don't make it static.
5680 (syms_of_data): Use DEFSYM.
5681
e003a292
PE
56822011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5683
5684 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5685 (CCL_CODE_MIN): New macro.
5686
ed008a6d
PE
56872011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5688
3687c2ef
PE
5689 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5690
ed008a6d
PE
5691 * eval.c (Qdebug): Now static.
5692 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5693 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5694 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5695
d66c4c7c
CY
56962011-05-29 Chong Yidong <cyd@stupidchicken.com>
5697
5698 * image.c: Various fixes to ImageMagick code comments.
5699 (Fimagemagick_types): Doc fix.
5700
5fbc2025
PE
57012011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5702
0196f88a
PE
5703 Minor fixes prompted by GCC 4.6.0 warnings.
5704
5705 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5706
5fbc2025
PE
5707 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5708 (x_clipboard_manager_save_all): Move extern decl to ...
5709 * xterm.h: ... here, so that it can be checked for consistency.
5710
1dd3c2d9
CY
57112011-05-29 Chong Yidong <cyd@stupidchicken.com>
5712
5713 * xselect.c (x_clipboard_manager_save_frame)
5714 (x_clipboard_manager_save_all): New functions.
5715 (Fx_clipboard_manager_save): Lisp function deleted.
5716
5717 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5718 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5719
5720 * xterm.h: Update prototype.
5721
5ba6571d
WX
57222011-05-28 William Xu <william.xwl@gmail.com>
5723
5724 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5725 exiting (Bug#8239).
5726
3eaff834
JM
57272011-05-28 Jim Meyering <meyering@redhat.com>
5728
e1900994 5729 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
5730 * fns.c (to_uchar): Define.
5731 (crypto_hash_function): Use it to convert some newly-signed
5732 variables to unsigned, to avoid sign-extension bugs. For example,
5733 without this change, (md5 "truc") would evaluate to
5734 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5735 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 5736 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 5737
0f6990a7
PE
57382011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5739
5740 Integer overflow fixes.
c8a9ca5a 5741
08686060
PE
5742 * dbusbind.c: Serial number integer overflow fixes.
5743 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
5744 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5745 to hold a serial number that is too large for a fixnum.
5746 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5747 Check for serial numbers out of range. Decode any serial number
59568bf0 5748 that was so large that it became a float. (Bug#8722)
08686060 5749
2d1fc3c7
PE
5750 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5751 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5752 Use XFASTINT rather than XUINT when numbers are nonnegative.
5753 (xd_append_arg, Fdbus_method_return_internal):
5754 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5755 arguments, check that Lisp number is nonnegative, rather than
59568bf0 5756 silently wrapping negative numbers around. (Bug#8722)
30217ff0 5757 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 5758 (Bug#8722)
2d1fc3c7 5759
c8a9ca5a
PE
5760 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5761
519e1d69
PE
5762 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5763
6df6ae42 5764 ccl: Add integer overflow checks.
30569699
PE
5765 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5766 (IN_INT_RANGE): New macros.
5767 (ccl_driver): Use them to check for integer overflow when
5768 decoding a CCL program. Many of the new checks are whether XINT (x)
5769 fits in int; it doesn't always, on 64-bit hosts. The new version
5770 doesn't catch all possible integer overflows, but it's an
847044ea 5771 improvement. (Bug#8719)
30569699 5772
c11285dc
PE
5773 * alloc.c (make_event_array): Use XINT, not XUINT.
5774 There's no need for unsigned here.
5775
fdccd48e
PE
5776 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5777 This follows up to the 2011-05-06 change that substituted uintptr_t
5778 for EMACS_INT. This case wasn't caught back then.
5779
37910ab2
PE
5780 Rework Fformat to avoid integer overflow issues.
5781 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5782 now (part of C89). Include <verify.h>.
5783 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5784 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5785 (Fformat): Avoid the prepass trying to compute sizes; it was only
5786 approximate and thus did not catch overflow reliably. Instead, walk
5787 through the format just once, formatting and computing sizes as we go,
5788 checking for integer overflow at every step, and allocating a larger
5789 buffer as needed. Keep track separately whether the format is
5790 multibyte. Keep only the most-recently calculated precision, rather
5791 than them all. Record whether each argument has been converted to
5792 string. Use EMACS_INT, not int, for byte and char and arg counts.
5793 Support field widths and precisions larger than INT_MAX. Avoid
5794 sprintf's undefined behavior with conversion specifications such as %#d
5795 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5796 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5797 formatting out-of-range floating point numbers with int
9173deec 5798 formats. (Bug#8668)
37910ab2 5799
2e6578fb
PE
5800 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5801
0ae6bdee
PE
5802 * data.c: Avoid integer truncation in expressions involving floats.
5803 * data.c: Include <intprops.h>.
5804 (arith_driver): When there's an integer overflow in an expression
5805 involving floating point, convert the integers to floating point
5806 so that the resulting value does not suffer from catastrophic
5807 integer truncation. For example, on a 64-bit host (* 4
5808 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5809 Do not rely on undefined behavior after integer overflow.
5810
de883a70
PE
5811 merge count_size_as_multibyte, parse_str_to_multibyte
5812 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 5813 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
5814 Check for integer overflow.
5815 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5816 since it's now a duplicate of the other. This is more of
5817 a character than a buffer op, so better that it's in character.c.
5818 * fns.c, print.c: Adjust to above changes.
5819
2ff916cb
PE
58202011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5821
5822 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5823
f1b54466
PE
58242011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5825
fb1ac845
PE
5826 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5827 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5828 (x_clipboard_manager_save): Now static.
5829 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5830
f1b54466
PE
5831 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5832 (crypto_hash_function): Now static.
5833 Fix pointer signedness problems. Avoid unnecessary initializations.
5834
a9f737ee
CY
58352011-05-27 Chong Yidong <cyd@stupidchicken.com>
5836
5837 * termhooks.h (Vselection_alist): Make it terminal-local.
5838
5839 * terminal.c (create_terminal): Initialize it.
5840
5841 * xselect.c: Support for clipboard managers.
5842 (Vselection_alist): Move to termhooks.h as terminal-local var.
5843 (LOCAL_SELECTION): New macro.
5844 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5845 (symbol_to_x_atom): Remove gratuitous arg.
5846 (x_handle_selection_request, lisp_data_to_selection_data)
5847 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
5848 (x_own_selection, x_get_local_selection, x_convert_selection):
5849 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
5850 (some_frame_on_display): Delete unused function.
5851 (Fx_own_selection_internal, Fx_get_selection_internal)
5852 (Fx_disown_selection_internal, Fx_selection_owner_p)
5853 (Fx_selection_exists_p): New optional frame arg.
5854 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5855 (x_handle_selection_clear): Don't treat other terminals with the
5856 same keyboard specially. Use the terminal-local Vselection_alist.
5857 (x_clear_frame_selections): Use Frun_hook_with_args.
5858
5859 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5860
5861 * xterm.h: Add support for those atoms.
5862
e067f0c1
CY
58632011-05-26 Chong Yidong <cyd@stupidchicken.com>
5864
5865 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5866 (converted_selections, conversion_fail_tag): New global variables.
5867 (x_selection_request_lisp_error): Free the above.
5868 (x_get_local_selection): Remove unnecessary code.
5869 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
5870 of converted selections stored in converted_selections.
5871 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
5872 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5873 (x_convert_selection): New function.
5874 (x_handle_selection_event): Simplify.
5875 (x_get_foreign_selection): Don't ignore incoming requests while
5876 waiting for an answer; this will fail when we implement
5877 SAVE_TARGETS, and seems unnecessary anyway.
5878 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5879 (Vx_sent_selection_functions): Doc fix.
5880
0f4aebc0
LL
58812011-05-26 Leo Liu <sdl.web@gmail.com>
5882
5883 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5884
e61124cd
YM
58852011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5886
5887 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5888
5889 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5890 for fringe update if it has periodic bitmap.
ac389d0c 5891 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
5892 and fringe_bitmap_periodic_p.
5893
5894 * fringe.c (get_fringe_bitmap_data): New function.
5895 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5896 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5897 row. Mark glyph row for fringe update if periodicity changed.
5898
5899 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5900 for fringe update unless it has periodic bitmap.
5901
f16d9837
KH
59022011-05-25 Kenichi Handa <handa@m17n.org>
5903
5904 * xdisp.c (get_next_display_element): Set correct it->face_id for
5905 a static composition.
5906
e1b90ef6
LL
59072011-05-24 Leo Liu <sdl.web@gmail.com>
5908
5909 * deps.mk (fns.o):
5910 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5911
5912 * fns.c (crypto_hash_function, Fsha1): New function.
5913 (Fmd5): Use crypto_hash_function.
5914 (syms_of_fns): Add Ssha1.
5915
7400048f
PE
59162011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5917
5918 * gnutls.c: Remove unused macros.
5919 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5920 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5921 Remove macros that are defined and never used.
5922 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5923
abb71cf4
CY
59242011-05-22 Chong Yidong <cyd@stupidchicken.com>
5925
5926 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5927 (Fx_get_selection_internal): Minor cleanup.
5928 (Fx_own_selection_internal): Rename arguments for consistency with
5929 select.el.
5930
6307db39
PE
59312011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5932
5933 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5934
f3d4e0a4
CY
59352011-05-22 Chong Yidong <cyd@stupidchicken.com>
5936
5937 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5938
4d8ade89
YM
59392011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5940
5941 * dispnew.c (scrolling_window): Don't exclude the case that the
5942 last enabled row in the desired matrix touches the bottom boundary.
5943
32078c8d
GM
59442011-05-21 Glenn Morris <rgm@gnu.org>
5945
5946 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
5947 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5948 and add some more files.
32078c8d 5949
7285dc67
EZ
59502011-05-20 Eli Zaretskii <eliz@gnu.org>
5951
5952 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5953 report_file_error introduced by the change from 2011-05-07.
5954
89d1bd22
PE
59552011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5956
5957 * systime.h (Time): Define only if emacs is defined.
5958 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5959 where the include path doesn't have X11/X.h by default. See
5960 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5961
cd394be1 59622011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
5963
5964 * composite.c (find_automatic_composition): Fix previous change.
5965
b9704ad9
GM
59662011-05-20 Glenn Morris <rgm@gnu.org>
5967
5968 * lisp.mk: New file, split from Makefile.in.
5969 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5970 (shortlisp): Remove.
5971 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5972
4a720484
GM
59732011-05-19 Glenn Morris <rgm@gnu.org>
5974
5975 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5976 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5977 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5978 (lisp): Set the order to that of loadup.el.
5979 (shortlisp): Make it a copy of $lisp.
5980 (SOME_MACHINE_LISP): Remove.
5981 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5982 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5983
a28d4396
KH
59842011-05-18 Kenichi Handa <handa@m17n.org>
5985
5986 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5987 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5988 (find_automatic_composition): Mostly rewrite for efficiency.
5989
a2b1fa8e
JB
59902011-05-18 Juanma Barranquero <lekktu@gmail.com>
5991
5992 * makefile.w32-in: Update dependencies.
5993
8e1f5610
CS
59942011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5995
5996 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 5997 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 5998
7025ee00 59992011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 6000
cdfa6eab
PE
6001 Fix some integer overflow issues, such as string length overflow.
6002
06d6db33
PE
6003 * insdel.c (count_size_as_multibyte): Check for string overflow.
6004
2b4560a8
PE
6005 * character.c (lisp_string_width): Check for string overflow.
6006 Use EMACS_INT, not int, for string indexes and lengths; in
6007 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6008 the resulting string length overflows an EMACS_INT; instead,
6009 report a string overflow if no precision given. When checking for
6010 precision exhaustion, use a check that cannot possibly have
6011 integer overflow. (Bug#8675)
6012 * character.h (lisp_string_width): Adjust to new signature.
6013
cb93f9be
PE
6014 * alloc.c (string_overflow): New function.
6015 (Fmake_string): Use it. This doesn't change behavior, but saves
6016 a few bytes and will simplify future changes.
6017 * character.c (string_escape_byte8): Likewise.
6018 * lisp.h (string_overflow): New decl.
6019
1a1f3366
PE
6020 Fixups, following up to the user-interface timestamp change.
6021 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6022 for UI timestamps, instead of unsigned long.
9fbd6841
PE
6023 * msdos.c (mouse_get_pos): Likewise.
6024 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
6025 * w32gui.h (Time): Define by including "systime.h" rather than by
6026 declaring it ourselves. (Bug#8664)
6027
d4e3e4d3
PE
6028 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6029 * image.c (clear_image_cache): Likewise.
6030
f6a24d19
PE
6031 * term.c (term_mouse_position): Don't assume time_t wraparound.
6032
08dc5ae6
PE
6033 Be more systematic about user-interface timestamps.
6034 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
6035 and sometimes 'EMACS_UINT', to represent these timestamps.
6036 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
6037 This makes the code easier to follow, and makes it easier to catch
6038 integer overflow bugs such as Bug#8664.
6039 * frame.c (Fmouse_position, Fmouse_pixel_position):
6040 Use Time, not unsigned long, for user-interface timestamps.
6041 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6042 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6043 * keyboard.h (last_event_timestamp): Likewise.
6044 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6045 * menu.h (xmenu_show): Likewise.
6046 * term.c (term_mouse_position): Likewise.
6047 * termhooks.h (struct input_event.timestamp): Likewise.
6048 (struct terminal.mouse_position_hook): Likewise.
6049 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6050 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6051 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6052 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6053 what it was before.
6054 * menu.h, termhooks.h: Include "systime.h", for Time.
6055
8e55734a
PE
6056 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6057 Don't assume that the difference between two unsigned long values
6058 can fit into an integer. At this point, we know button_down_time
6059 <= event->timestamp, so the difference must be nonnegative, so
6060 there's no need to cast the result if double-click-time is
6061 nonnegative, as it should be; check that it's nonnegative, just in
6062 case. This bug is triggered when events are more than 2**31 ms
86db42d2 6063 apart (about 25 days). (Bug#8664)
8e55734a 6064
841f1b75 6065 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 6066 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 6067
3e26f69c
PE
6068 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6069 that always fit in int. Use a sentinel instead of a counter, to
6070 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
6071 * frame.h (struct frame): Use int for menu_bar_items_used
6072 instead of EMACS_INT, since it always fits in int.
3e26f69c 6073
5cc152c0
PE
6074 * menu.c (grow_menu_items): Check for int overflow.
6075
d89eb65e
PE
6076 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6077
5235bd3e
PE
6078 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6079 Before, the code was not consistent. These values cannot exceed
6080 2**31 - 1 so there's no need to make them unsigned.
6081 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6082 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6083 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6084 as modifiers.
6085 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6086
bc827e23
PE
6087 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6088 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6089 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6090 presumably because the widths might not match.
6091
78eb494e
PE
6092 * window.c (size_window): Avoid needless test at loop start.
6093
04f2d78b
CB
60942011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6095
6096 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6097
d2fc7e3d 60982011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
6099
6100 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6101
d2fc7e3d 61022011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
6103
6104 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6105 `width' to `bar_area_x' and `bar_area_width', respectively.
6106 (x_scroll_run): Take account of fringe background extension.
6107
04f2d78b
CB
6108 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6109 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
6110 `bar_area_width', respectively.
6111 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6112 background extension.
6113
79b70037
GM
61142011-05-10 Jim Meyering <meyering@redhat.com>
6115
6116 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6117
2f142cc5
JB
61182011-05-10 Juanma Barranquero <lekktu@gmail.com>
6119
6120 * image.c (Finit_image_library): Return t for built-in image types,
6121 like pbm and xbm. (Bug#8640)
6122
57679c86
AS
61232011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6124
6125 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6126
888c9e86
EZ
61272011-05-07 Eli Zaretskii <eliz@gnu.org>
6128
b0512a1d
EZ
6129 * w32console.c (Fset_screen_color): Doc fix.
6130 (Fget_screen_color): New function.
6131 (syms_of_ntterm): Defsubr it.
6132
7285dc67
EZ
6133 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6134 unlink the temporary file if Fcall_process didn't create it in the
6135 first place.
6136 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6137 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
6138 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6139 cue to call_process_cleanup not to close that handle.
6140
4d3fcc8e
BK
61412011-05-07 Ben Key <bkey76@gmail.com>
6142
6143 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6144 one of two shell specific rules, either bootstrap-temacs-CMD or
6145 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6146 to the previous implementation of the bootstrap-temacs rule.
6147 The bootstrap-temacs-CMD rule is similar to the previous
6148 implementation of the bootstrap-temacs rule except that it
6149 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6150 variable.
6151
6152 These changes, along with some changes to nt/configure.bat,
6153 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6154 earlier fix to add support for --cflags and --ldflags options
6155 that include quotes so that it works whether make uses cmd or
6156 sh as the shell.
6157
b4289b64
MA
61582011-05-06 Michael Albinus <michael.albinus@gmx.de>
6159
6160 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6161 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6162 is a constant.
6163 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6164 a string. Handle both cases.
6165 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6166 (Fdbus_register_method): Use Qinvalid_function.
6167
af4c0e28
JB
61682011-05-06 Juanma Barranquero <lekktu@gmail.com>
6169
6170 * makefile.w32-in: Update dependencies.
6171 (LISP_H): Add inttypes.h and stdin.h.
6172 (PROCESS_H): Add unistd.h.
6173
c51453d9
EZ
61742011-05-06 Eli Zaretskii <eliz@gnu.org>
6175
6176 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6177 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6178
8ff0ac3c 61792011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 6180
4c4b566b
PE
6181 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6182
aab2b9b5
PE
6183 * term.c (vfatal): Remove stray call to va_end.
6184 It's not needed and the C Standard doesn't allow it here anyway.
6185
c378da0b
PE
6186 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6187 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6188
288b08c7
PE
6189 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6190 bytes.
6191
e3601888
PE
6192 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6193
db6c0e74
PE
6194 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6195
dd5963ea
PE
6196 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6197
88c9450f
PE
6198 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6199
2f9442b8
PE
6200 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6201
c032b5f8
PE
6202 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6203 * charset.c (Fdefine_charset_internal): Don't initialize
6204 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 6205 32-bit int (Bug#8600).
a108c10b
PE
6206
6207 * lread.c (read_integer): Be more consistent with string-to-number.
6208 Use string_to_number to do the actual conversion; this avoids
6209 rounding errors and fixes some other screwups. Without this fix,
6210 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6211 (digit_to_number): Move earlier, for benefit of read_integer.
6212 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 6213 not a digit in any supported base. (Bug#8602)
a108c10b 6214
ad5f9eea
PE
6215 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6216
aec1708a
PE
6217 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6218 to match comment at start of function. This also removes a
6219 GCC warning about overflow in a 32+64-bit port.
6220
47be4ab5
PE
6221 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6222
371cac43
PE
6223 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6224 Reported by Stefan Monnier in
6225 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
6226 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6227 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 6228
d01a7826
PE
6229 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6230 (EMACS_UINTPTR): Likewise, with uintptr_t.
6231
7fd47d5c
PE
6232 * lisp.h: Prefer 64-bit EMACS_INT if available.
6233 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6234 on 32-bit hosts that have 64-bit int, so that they can access
6235 large files.
122b0c86
PE
6236 However, temporarily disable this change unless the temporary
6237 symbol WIDE_EMACS_INT is defined.
7fd47d5c 6238
8727937b
PE
6239 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6240
8ac068ac
PE
6241 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6242 This removes an assumption that EMACS_INT and long are the same
6243 width as pointers. The assumption is true for Emacs porting targets
6244 now, but we want to make other targets possible.
6245 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6246 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6247 In the rest of the code, change types of integers that hold casted
6248 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6249 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6250 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6251 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6252 No need to cast type when ORing.
6253 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6254 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6255 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6256 assume EMACS_INT is the same width as char *.
6257 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6258 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6259 Remove no-longer-needed casts.
6260 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6261 (xg_tool_bar_help_callback, xg_make_tool_item):
6262 Use EMACS_INTPTR to hold an integer
6263 that will be cast to void *; this can avoid a GCC warning
6264 if EMACS_INT is not the same width as void *.
6265 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6266 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6267 (current_message_1, set_message_1):
6268 Use a local to convert to proper width without a cast.
6269 * xmenu.c (dialog_selection_callback): Likewise.
6270
ede49d71
PE
6271 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6272 Also, don't assume VALBITS / RAND_BITS is less than 5,
6273 and don't rely on undefined behavior when shifting a 1 left into
6274 the sign bit.
6275 * lisp.h (get_random): Change signature to match.
6276
2f30ecd0
PE
6277 * lread.c (hash_string): Use size_t, not int, for hash computation.
6278 Normally we prefer signed values; but hashing is special, because
6279 it's better to use unsigned division on hash table sizes so that
6280 the remainder is nonnegative. Also, size_t is the natural width
6281 for hashing into memory. The previous code used 'int', which doesn't
6282 retain enough info to hash well into very large tables.
6283 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6284
2a866e7b
PE
6285 * dbusbind.c: Don't possibly lose pointer info when converting.
6286 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6287 Use XPNTR rather than XHASH, so that the high-order bits of
6288 the pointer aren't lost when converting through void *.
6289
51639eac
PE
6290 * eval.c (Fautoload): Don't double-shift a pointer.
6291
92394119
PE
6292 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6293
dbdb9a7c
JB
62942011-05-06 Juanma Barranquero <lekktu@gmail.com>
6295
6296 * gnutls.c (DEF_GNUTLS_FN):
6297 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6298
db7a0b4f
AS
62992011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6300
6301 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6302 marker. (Bug#8610)
6303
cd394be1 63042011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
6305
6306 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6307 New version that can reserve upto 2GB of heap space.
6308
f7ff1b0f 63092011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
6310
6311 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6312
639c109b
TZ
63132011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6314
6315 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6316 `gnutls_certificate_set_x509_key_file'.
6317
d2127135
JB
63182011-05-05 Juanma Barranquero <lekktu@gmail.com>
6319
6320 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6321 Update dependencies.
6322
e968f4f3
JB
63232011-05-04 Juanma Barranquero <lekktu@gmail.com>
6324
6325 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6326 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6327 Remove unused parameter `fildes'.
6328 * process.c (read_process_output, send_process): Don't pass it.
6329
84d358f0
JB
63302011-05-04 Juanma Barranquero <lekktu@gmail.com>
6331
6332 Fix previous change: the library cache is defined in w32.c.
6333 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6334 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6335
0898ca10
JB
63362011-05-04 Juanma Barranquero <lekktu@gmail.com>
6337
6338 Implement dynamic loading of GnuTLS on Windows.
6339
6340 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6341 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6342 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6343 Declare.
6344
6345 * gnutls.c (Qgnutls_dll): Define.
6346 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6347 (gnutls_*): Declare function pointers.
6348 (init_gnutls_functions): New function to initialize function pointers.
6349 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6350 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6351 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6352 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6353 (emacs_gnutls_write, emacs_gnutls_read)
6354 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6355 (Fgnutls_available_p): New function.
6356 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6357 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6358 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6359
6360 * image.c: Include w32.h.
6361 (Vimage_type_cache): Delete.
6362 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6363 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6364 (w32_delayed_load): Move to w32.c.
6365
6366 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6367
6368 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6369 (w32_delayed_load): Move from image.c. When loading a library, record
6370 its filename in the :loaded-from property of the library id.
6371 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6372 Initialize and staticpro them.
6373 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6374
6375 * process.c: Include lisp.h before w32.h, not after.
6376 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6377 instead of gnutls_record_check_pending.
6378
6379 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6380
ff4de4aa
TZ
63812011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6382
6383 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6384 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6385 as passed in.
6386
abe95abb
JD
63872011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6388
6389 * xterm.c (x_set_frame_alpha): Do not set property on anything
6390 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6391
e16e55d4
JB
63922011-05-02 Juanma Barranquero <lekktu@gmail.com>
6393
6394 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6395
bafcf6a5
JB
63962011-05-02 Juanma Barranquero <lekktu@gmail.com>
6397
6398 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6399 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6400 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6401 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6402 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6403 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6404 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6405 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6406 (Qgnutls_bootprop_callbacks_verify): Make static.
6407
e7a6747f
AS
64082011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6409
19ed11ba
AS
6410 * callproc.c: Indentation fixup.
6411
e7a6747f 6412 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
6413 (wait_for_termination, interruptible_wait_for_termination):
6414 Move after wait_for_termination_1.
e7a6747f 6415
1ef14cb4
LMI
64162011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6417
6418 * sysdep.c (interruptible_wait_for_termination): New function
6419 which is like wait_for_termination, but allows keyboard
6420 interruptions.
6421
6422 * callproc.c (Fcall_process): Add (:file "file") as an option for
6423 the STDOUT buffer.
6424 (Fcall_process_region): Ditto.
6425
330d880c
EZ
64262011-04-30 Eli Zaretskii <eliz@gnu.org>
6427
8db90b73
EZ
6428 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6429 rather than `XVECTOR (FOO)->size'.
6430
330d880c
EZ
6431 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6432 inttypes.h, as a gnulib replacement is used if it not available in
6433 system headers.
6434
15cbd324
EZ
64352011-04-21 Eli Zaretskii <eliz@gnu.org>
6436
6437 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6438 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6439 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6440
6441 * coding.c (coding_alloc_by_realloc): Error out if destination
6442 will grow beyond MOST_POSITIVE_FIXNUM.
6443 (decode_coding_emacs_mule): Abort if there isn't enough place in
6444 charbuf for the composition carryover bytes. Reserve an extra
6445 space for up to 2 characters produced in a loop.
6446 (decode_coding_iso_2022): Abort if there isn't enough place in
6447 charbuf for the composition carryover bytes.
6448
64492011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 6450
ae940cca
EZ
6451 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6452 aborting when %lld or %lll format is passed.
6453 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6454 %llo or %llx format is passed. (Bug#8545)
6455
03ab8921
EZ
6456 * window.c (window_scroll_line_based): Use a marker instead of
6457 simple variables to record original value of point. (Bug#7952)
6458
afda1437
EZ
6459 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6460 produced by %s or %c overflows available buffer space. (Bug#8545)
6461
f76dee0c
PE
64622011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6463
6464 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 6465 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 6466
fdc5744d
JB
64672011-04-28 Juanma Barranquero <lekktu@gmail.com>
6468
6469 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6470
638f053a
JB
64712011-04-28 Juanma Barranquero <lekktu@gmail.com>
6472
6473 * keyboard.c (Qdelayed_warnings_hook): Define.
6474 (command_loop_1): Run `delayed-warnings-hook'
6475 if Vdelayed_warnings_list is non-nil.
6476 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6477 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6478
d178f871
EZ
64792011-04-28 Eli Zaretskii <eliz@gnu.org>
6480
6481 * doprnt.c (doprnt): Don't return value smaller than the buffer
6482 size if the message was truncated. (Bug#8545).
6483
b124fd93
JB
64842011-04-28 Juanma Barranquero <lekktu@gmail.com>
6485
6486 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6487 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6488
e810457d
PE
64892011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6490
6491 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6492
ea51cceb
JB
64932011-04-27 Juanma Barranquero <lekktu@gmail.com>
6494
6495 * makefile.w32-in: Update dependencies.
6496
94dcfacf
EZ
64972011-04-27 Eli Zaretskii <eliz@gnu.org>
6498
6499 Improve `doprnt' and its usage. (Bug#8545)
6500 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6501 `format_end'. Remove support for %l as a conversion specifier.
6502 Don't use xrealloc. Improve diagnostics when the %l size modifier
6503 is used. Update the commentary.
6504
6505 * eval.c (verror): Simplify calculation of size_t.
6506
6507 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6508 messages.
6509
f61f41d7
PE
65102011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6511
6512 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6513 change.
6514
96fb4434
PE
65152011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6516
6517 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6518 This makes this file independent of the recent pseudovector change.
6519
671875da 65202011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 6521
69e9b5a3
PE
6522 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6523
b5f869a7 6524 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 6525 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 6526 Remove unused local.
c8926152 6527 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 6528
841a1577 6529 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
6530 GCC 4.6.0 optimizes based on type-based alias analysis.
6531 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
6532 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6533 != &v->size, and therefore "v->size = 1; b->size = 2; return
6534 v->size;" must therefore return 1. This assumption is incorrect
6535 for Emacs, since it type-puns struct Lisp_Vector * with many other
6536 types. To fix this problem, this patch adds a new type struct
f904488f 6537 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
6538 and pseudovectors, and helps optimizing compilers not get fooled
6539 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6540 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
6541 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6542 the size member.
eab3844f
PE
6543 (XSETPVECTYPE): Rewrite in terms of new macro.
6544 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6545 This is a bit clearer, and further avoids the possibility of
6546 undesirable aliasing.
6547 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 6548 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
6549 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6550 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
6551 (ASIZE): Now uses header.size rather than size.
6552 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
6553 to avoid the hassle of writing XVECTOR (foo)->header.size.
6554 (struct vectorlike_header): New type.
eab3844f
PE
6555 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6556 object, to help avoid aliasing.
6557 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6558 (SUBRP): Likewise, since Lisp_Subr is a special case.
6559 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6560 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6561 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 6562 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
6563 changed to be "header.size" and "header.next".
6564 * buffer.h (struct buffer): Likewise.
6565 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6566 * frame.h (struct frame): Likewise.
6567 * process.h (struct Lisp_Process): Likewise.
6568 * termhooks.h (struct terminal): Likewise.
6569 * window.c (struct save_window_data, struct saved_window): Likewise.
6570 * window.h (struct window): Likewise.
6571 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6572 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6573 * buffer.c (init_buffer_once): Likewise.
6574 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6575 special case.
6576 * process.c (Fformat_network_address): Use local var for size,
6577 for brevity.
6578
0df1eac5
PE
6579 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6580
847ab9d1 6581 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
6582 * data.c (atof): Remove decl; no longer used or needed.
6583 (digit_to_number): Move to lread.c.
6584 (Fstring_to_number): Use new string_to_number function, to be
6585 consistent with how the Lisp reader treats infinities and NaNs.
6586 Do not assume that floating-point numbers represent EMACS_INT
6587 without losing information; this is not true on most 64-bit hosts.
6588 Avoid double-rounding errors, by insisting on integers when
6589 parsing non-base-10 numbers, as the documentation specifies.
6590 * lisp.h (string_to_number): New decl, replacing ...
6591 (isfloat_string): Remove.
bc0a5c13 6592 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 6593 (read1): Do not accept +. and -. as integers; this
452f4150
PE
6594 appears to have been a coding error. Similarly, do not accept
6595 strings like +-1e0 as floating point numbers. Do not report
6596 overflow for integer overflows unless the base is not 10 which
6597 means we have no simple and reliable way to continue.
6598 Break out the floating-point parsing into a new
6599 function string_to_number, so that Fstring_to_number parses
6600 floating point numbers consistently with the Lisp reader.
04f2d78b 6601 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
6602 (E_CHAR, EXP_INT): Remove, replacing with ...
6603 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6604 (string_to_number): New function, replacing isfloat_string.
6605 This function checks for valid syntax and produces the resulting
6606 Lisp float number too. Rework it so that string-to-number
bc0a5c13 6607 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
6608 so that overflow for non-base-10 numbers is reported only when
6609 there's no portable and simple way to convert to floating point.
452f4150 6610
67769ffc
PE
6611 * textprop.c (set_text_properties_1): Rewrite for clarity,
6612 and to avoid GCC warning about integer overflow.
6613
c20db43f
PE
6614 * intervals.h (struct interval): Use EMACS_INT for members
6615 where EMACS_UINT might cause problems. See
6616 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6617 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6618 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6619 All uses changed.
37aa2f85
PE
6620 (offset_intervals): Tell GCC not to worry about length overflow
6621 when negating a negative length.
c20db43f 6622
2538aa2f
PE
6623 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6624 (overrun_check_free): Likewise.
6625
f2d3008d
PE
6626 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6627 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6628 word size.
6629
ec8df744
PE
6630 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6631 (gnutls_make_error): Rename local to avoid shadowing.
6632 (gnutls_emacs_global_deinit): ifdef out; not used.
6633 (Fgnutls_boot): Use const for pointer to readonly storage.
6634 Comment out unused local. Fix pointer signedness problems.
6635
640ee02d
PE
6636 * lread.c (openp): Don't stuff size_t into an 'int'.
6637 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6638 about possible signed overflow.
6639
6048fb2a
PE
6640 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6641 (GDK_KEY_g): Don't define if already defined.
6642 (xg_prepare_tooltip): Avoid pointer signedness problem.
6643 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6644
fa3c87e1
PE
6645 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6646 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6647
2172544b
PE
6648 * xfns.c (Fx_window_property): Simplify a bit,
6649 to make a bit faster and to avoid GCC 4.6.0 warning.
6650 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6651
9b821a21
PE
6652 * fns.c (internal_equal): Don't assume size_t fits in int.
6653
3c616cfa
PE
6654 * alloc.c (compact_small_strings): Tighten assertion a little.
6655
c2982e87
PE
6656 Replace pEd with more-general pI, and fix some printf arg casts.
6657 * lisp.h (pI): New macro, generalizing old pEd macro to other
6658 conversion specifiers. For example, use "...%"pI"d..." rather
6659 than "...%"pEd"...".
6660 (pEd): Remove. All uses replaced with similar uses of pI.
6661 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6662 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6663 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6664 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6665 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6666 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6667 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6668 64-bit hosts.
6669 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6670 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6671 * print.c (safe_debug_print, print_object): Likewise.
6672 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6673 to int.
6f04d126
PE
6674 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6675 avoiding the 0 flag, which is not portable.
c2982e87
PE
6676 * process.c (Fmake_network_process): Use pI to avoid cast.
6677 * region-cache.c (pp_cache): Likewise.
6678 * xdisp.c (decode_mode_spec): Likewise.
6679 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6680 behavior on 64-bit hosts with printf arg.
6f04d126 6681 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
6682 (x_stop_queuing_selection_requests): Likewise.
6683 (x_get_window_property): Don't truncate byte count to an 'int'
6684 when tracing.
0b432f21 6685
5e073ec7
PE
6686 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6687 here, since it parses constructs like leading '-' and spaces,
6688 which are not wanted; and it overflows with large numbers.
6689 Instead, simply match F[0-9]+, which is what is wanted anyway.
6690
36372bf9
PE
6691 * alloc.c: Remove unportable assumptions about struct layout.
6692 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6693 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6694 (allocate_vectorlike, make_pure_vector): Use the new macros,
6695 plus offsetof, to remove unportable assumptions about struct layout.
6696 These assumptions hold on all porting targets that I know of, but
6697 they are not guaranteed, they're easy to remove, and removing them
6698 makes further changes easier.
6699
0b432f21
PE
6700 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6701 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
6702 (string_overrun_cookie): Now const. Use initializers that
6703 don't formally overflow signed char, to avoid warnings.
000098c1
PE
6704 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6705 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
6706 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6707 multiple of sizeof (EMACS_INT); it need not be, if
6708 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 6709 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 6710
895009e1
JB
67112011-04-26 Juanma Barranquero <lekktu@gmail.com>
6712
6713 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6714
6a7a1b0b
TZ
67152011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6716
6717 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 6718 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
6719 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6720
841a1577 67212011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
6722
6723 * lisp.h (Qdebug): List symbol.
895009e1 6724 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
6725 * keyboard.c (debug-on-event): New variable.
6726 (handle_user_signal): Break into debugger when debug-on-event
6727 matches the current signal symbol.
6728
f2d3ba6f
DN
67292011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6730
6731 * alloc.c (check_sblock, check_string_bytes)
6732 (check_string_free_list): Convert to standard C.
6733
42ce4c63
TZ
67342011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6735
6736 * w32.c (emacs_gnutls_push): Fix typo.
6737
825cd63c
EZ
67382011-04-25 Eli Zaretskii <eliz@gnu.org>
6739
fb11d64d
EZ
6740 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6741 "cast to pointer from integer of different size".
6742
825cd63c
EZ
6743 Improve doprnt and its use in verror. (Bug#8545)
6744 * doprnt.c (doprnt): Document the set of format control sequences
6745 supported by the function. Use SAFE_ALLOCA instead of always
6746 using `alloca'.
6747
6748 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6749 is one byte too soon. Don't use xrealloc; instead xfree and
6750 xmalloc anew.
6751
e061a11b
TZ
67522011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6753
6754 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6755 callbacks stage.
6756
6757 * gnutls.c: Renamed global_initialized to
6758 gnutls_global_initialized. Added internals for the
6759 :verify-hostname-error, :verify-error, and :verify-flags
6760 parameters of `gnutls-boot' and documented those parameters in the
6761 docstring. Start callback support.
9173deec
JB
6762 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6763 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6764 on error. Return error code.
e061a11b
TZ
6765 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6766 (emacs_gnutls_read): Likewise.
6767 (Fgnutls_boot): Return handshake error code.
6768 (emacs_gnutls_handle_error): New function.
6769 (wsaerror_to_errno): Likewise.
6770
6771 * w32.h (emacs_gnutls_pull): Add prototype.
6772 (emacs_gnutls_push): Likewise.
6773
6774 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6775 (emacs_gnutls_push): Likewise.
6776
67772011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6778
6779 * process.c (wait_reading_process_output): Check if GnuTLS
6780 buffered some data internally if no FDs are set for TLS
6781 connections.
6782
6783 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6784 (LIBS): Link to USER_LIBS.
6785 ($(BLD)/gnutls.$(0)): New target.
6786
fa6996bc
EZ
67872011-04-24 Eli Zaretskii <eliz@gnu.org>
6788
eb35682e
EZ
6789 * xdisp.c (handle_single_display_spec): Rename the
6790 display_replaced_before_p argument into display_replaced_p, to
6791 make it consistent with the commentary. Fix typos in the
6792 commentary.
6793
e2ad650c
EZ
6794 * textprop.c (syms_of_textprop): Remove dead code.
6795 (copy_text_properties): Delete obsolete commentary about an
6796 interface that was deleted long ago. Fix typos in the description
6797 of arguments.
6798
1b2de274
EZ
6799 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6800 to changes in oldXMenu/XMenu.h from 2011-04-16.
6801 <menu_help_message, prev_menu_help_message>: Constify.
6802 (IT_menu_make_room): menu->help_text is now `const char **';
6803 adjust.
6804
6805 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6806 to changes in oldXMenu/XMenu.h from 2011-04-16.
6807 (struct XMenu): Declare `help_text' `const char **'.
6808
6809 * xfaces.c <Qunspecified>: Make extern again.
6810
6811 * syntax.c: Include sys/types.h before including regex.h, as
6812 required by Posix.
6813
762b15be
EZ
6814 * doc.c (get_doc_string): Improve the format passed to `error'.
6815
6816 * doprnt.c (doprnt): Improve commentary.
6817
6818 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6819
6820 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6821 them with etags.
6822
f1052e5d
EZ
6823 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6824 changes in globals.h immediately force recompilation.
762b15be
EZ
6825 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6826 $(CURDIR)/s/ms-w32.h.
6827 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 6828
fa6996bc
EZ
6829 * character.c (Fchar_direction): Function deleted.
6830 (syms_of_character): Don't defsubr it.
6831 <char-direction-table>: Deleted.
6832
e6c3da20
EZ
68332011-04-23 Eli Zaretskii <eliz@gnu.org>
6834
6835 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6836 * doprnt.c: Include limits.h.
6837 (SIZE_MAX): New macro.
04f2d78b
CB
6838 (doprnt): Return a size_t value. 2nd arg is now size_t.
6839 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
6840 Improve overflow protection. Support `l' modifier for integer
6841 conversions. Support %l conversion. Don't assume an EMACS_INT
6842 argument for integer conversions and for %c.
6843
6844 * lisp.h (doprnt): Restore prototype.
6845
6846 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6847 $(SRC)/character.h.
6848
6849 * Makefile.in (base_obj): Add back doprnt.o.
6850
6851 * deps.mk (doprnt.o): Add back prerequisites.
6852 (callint.o): Depend on character.h.
6853
6854 * eval.c (internal_lisp_condition_case): Include the handler
6855 representation in the error message.
6856 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6857 when breaking from the loop.
6858
6859 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6860
6861 * callint.c (Fcall_interactively): When displaying error message
6862 about invalid control letter, pass the character's codepoint, not
6863 a pointer to its multibyte form. Improve display of the character
6864 in octal and display also its hex code.
6865
6866 * character.c (char_string): Use %x to display the (unsigned)
6867 codepoint of an invalid character, to avoid displaying a bogus
6868 negative value.
6869
6870 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6871 `error', not SYMBOL_NAME itself.
6872
6873 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6874 character arguments to `error'.
6875
6876 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6877 to `error' in error message about FINAL_CHAR argument. Make sure
6878 FINAL_CHAR is a character, and use %c when it is passed as
6879 argument to `error'.
6880
4ffd0d6b 68812011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
6882
6883 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6884
6885 * w32.c: Include <time.h>.
6886 (sys_localtime): New function.
6887
4ffd0d6b 68882011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
6889
6890 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6891
4ffd0d6b 6892 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 6893
4ffd0d6b 68942011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 6895
4ffd0d6b
GM
6896 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6897 zombies (Bug#8467).
aac0c6e3 6898
04c56954
EZ
68992011-04-19 Eli Zaretskii <eliz@gnu.org>
6900
6901 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6902 gl_state.e_property when gl_state.object is Qt.
6903
6904 * insdel.c (make_gap_larger): Remove limitation of buffer size
6905 to <= INT_MAX.
6906
16a43933
CY
69072011-04-18 Chong Yidong <cyd@stupidchicken.com>
6908
6909 * xdisp.c (lookup_glyphless_char_display)
6910 (produce_glyphless_glyph): Handle cons cell entry in
6911 glyphless-char-display.
6912 (Vglyphless_char_display): Document it.
6913
6914 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6915 glyphless-char-display.
6916
4581706e
CY
69172011-04-17 Chong Yidong <cyd@stupidchicken.com>
6918
6919 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6920
6921 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6922
6923 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6924 definition for no-X builds.
6925
4887c6e2 69262011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 6927
fd35b6f9
PE
6928 Static checks with GCC 4.6.0 and non-default toolkits.
6929
5c1ccb01
PE
6930 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6931
006c5daa
PE
6932 * process.c (keyboard_bit_set): Define only if SIGIO.
6933 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6934 (send_process): Repair possible setjmp clobbering.
6935
efc736d3
PE
6936 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6937
4e2fe2e6
PE
6938 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6939
f97334a2
PE
6940 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6941
4e75f29d
PE
6942 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6943 Define only if needed.
6944
90efadd1
PE
6945 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6946 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 6947 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 6948
3c647824
PE
6949 * dispextern.h (struct redisplay_interface): Rename param
6950 to avoid shadowing.
e264f262 6951 * termhooks.h (struct terminal): Likewise.
761383f4 6952 * xterm.c (xembed_send_message): Likewise.
3c647824 6953
b58c5c4a
PE
6954 * insdel.c (make_gap_smaller): Define only if
6955 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6956
cad59032
PE
6957 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6958 it.
6959
c339dc2e
PE
6960 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6961 so that we aren't warned about unused symbols.
6962
91a3e27b
PE
6963 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6964
399c71d3 6965 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 6966
8ffc96f5
PE
6967 * xfns.c (x_real_positions): Mark locals as initialized.
6968
eef9bc79
PE
6969 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6970
098db9dd
PE
6971 * xterm.c: Fix problems found by static analysis with other toolkits.
6972 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
6973 (x_dispatch_event): Declare static if USE_GTK, and
6974 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 6975 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 6976 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
6977 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6978 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 6979
eb18f6cc
PE
6980 * xmenu.c (menu_help_callback): Pointer type fixes.
6981 Use const pointers when pointing at readonly data. Avoid pointer
6982 signedness clashes.
6983 (FALSE): Remove unused macro.
6984 (update_frame_menubar): Remove unused decl.
6985
1fe72bf8
PE
6986 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6987
60d9e1db
PE
6988 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6989 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6990 (single_menu_item): Rename local to avoid shadowing.
6991
39261c26
PE
6992 * keyboard.c (make_lispy_event): Remove unused local var.
6993
018c5e19
PE
6994 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6995 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6996
63d2b86e
PE
6997 * bitmaps: Change bitmaps from unsigned char back to the X11
6998 compatible char. Avoid the old compiler warnings about
6999 out-of-range initializers by using, for example, '\xab' rather
7000 than 0xab.
7001
aefd87e1
PE
7002 * xgselect.c (xgselect_initialize): Check vs interface
7003 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7004
bf501fb9
PE
7005 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7006
e9829fdf
PE
7007 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7008 to read-only memory.
7009
1086c095
PE
7010 * fns.c (vector): Remove; this old hack is no longer needed.
7011
2baccd04 7012 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 7013 Remove unused var.
dde42981 7014 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 7015
72391843 7016 * xrdb.c (x_load_resources): Omit unused local.
3565b346 7017
436c16df 7018 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 7019 (x_window): Rename locals to avoid shadowing.
dc5ddd85 7020 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 7021
92bb796d 7022 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 7023 (x_term_init): Remove local to avoid shadowing.
92bb796d 7024
764430a3 7025 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
7026
7027 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7028 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7029
d1dfb56c
EZ
70302011-04-16 Eli Zaretskii <eliz@gnu.org>
7031
c4354cb4
EZ
7032 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7033
d1dfb56c
EZ
7034 Fix regex.c, syntax.c and friends for buffers > 2GB.
7035 * syntax.h (struct gl_state_s): Declare character position members
7036 EMACS_INT.
7037
7038 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7039
04f2d78b
CB
7040 * textprop.c (verify_interval_modification, interval_of):
7041 Declare arguments EMACS_INT.
d1dfb56c
EZ
7042
7043 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7044 EMACS_INT.
7045
7046 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7047
7048 * indent.c (Fvertical_motion): Local variable it_start is now
7049 EMACS_INT.
7050
7051 * regex.c (re_match, re_match_2, re_match_2_internal)
7052 (bcmp_translate, regcomp, regexec, print_double_string)
7053 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7054 (re_compile_pattern, re_exec): Declare arguments and local
7055 variables `size_t' and `ssize_t' and return values `regoff_t', as
7056 appropriate.
7057 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7058 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7059 <compile_stack_type>: `size' and `avail' are now `size_t'.
7060
7061 * regex.h <regoff_t>: Use ssize_t, not int.
7062 (re_search, re_search_2, re_match, re_match_2): Arguments that
7063 specify buffer/string position and length are now ssize_t and
7064 size_t. Return type is regoff_t.
7065
613052cd
BK
70662011-04-16 Ben Key <bkey76@gmail.com>
7067
7068 * nsfont.m: Fixed bugs in ns_get_family and
7069 ns_descriptor_to_entity that were caused by using free to
7070 deallocate memory blocks that were allocated by xmalloc (via
7071 xstrdup). This caused Emacs to crash when compiled with
7072 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7073 --enable-checking=xmallocoverrun). xfree is now used to
7074 deallocate these memory blocks.
7075
4170f62f 70762011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 7077
71b41406
PE
7078 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7079
9587a89d
PE
7080 emacs_write: Accept and return EMACS_INT for sizes.
7081 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7082 et seq.
7083 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7084 Accept and return EMACS_INT.
7085 (emacs_gnutls_write): Return the number of bytes written on
7086 partial writes.
7087 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
7088 (emacs_read, emacs_write): Remove check for negative size, as the
7089 Emacs source code has been audited now.
9587a89d
PE
7090 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7091 (emacs_read, emacs_write): Use it.
273a5f82
PE
7092 * process.c (send_process): Adjust to the new signatures of
7093 emacs_write and emacs_gnutls_write. Do not attempt to store
7094 a byte offset into an 'int'; it might overflow.
9587a89d 7095 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 7096
3e047f51
PE
7097 * sound.c: Don't assume sizes fit in 'int'.
7098 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 7099 Return EMACS_INT, not int.
3e047f51 7100 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
7101 Accept EMACS_INT, not int.
7102 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
7103 record read return values.
7104
cc39a9db
BK
71052011-04-15 Ben Key <bkey76@gmail.com>
7106
c9d0ec6d
JB
7107 * keyboard.c (Qundefined): Don't declare static since it is used
7108 in nsfns.m.
7109 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7110 static since they are used in nsfont.m.
cc39a9db 7111
6c60eb9f
SM
71122011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7113
7114 * process.c (Qprocessp): Don't declare static.
7115 * lisp.h (Qprocessp): Declare again.
7116
7990b61a
JB
71172011-04-15 Juanma Barranquero <lekktu@gmail.com>
7118
7119 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7120
5d4cb038
PE
71212011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7122
8bd7b830 7123 Improve C-level modularity by making more things 'static'.
cd64ea1d 7124
e3b27b31
PE
7125 Don't publish debugger-only interfaces to other modules.
7126 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7127 (verify_bytepos, count_markers): Move decls to the only modules
7128 that need them.
7129 * region-cache.h (pp_cache): Likewise.
7130 * window.h (check_all_windows): Likewise.
7131 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7132
5d4cb038
PE
7133 * sysdep.c (croak): Now static, if
7134 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7135 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
7136
7137 * alloc.c (refill_memory_reserve): Now static if
7138 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7139 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 7140
e87b6180
PE
7141 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7142 Define only if USE_LUCID.
7143
ac64929e
PE
7144 * xrdb.c (x_customization_string, x_rm_string): Now static.
7145
6f37259d
PE
7146 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7147 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7148
1683e3ab
PE
7149 * xdisp.c (draw_row_with_mouse_face): Now static.
7150 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7151
de9c2632
PE
7152 * window.h (check_all_windows): Mark externally visible.
7153
2b96acb7
PE
7154 * window.c (window_deletion_count): Now static.
7155
7156 * undo.c: Make symbols static if they're not exported.
7157 (last_undo_buffer, last_boundary_position, pending_boundary):
7158 Now static.
7159
50436f33
PE
7160 * textprop.c (interval_insert_behind_hooks): Now static.
7161 (interval_insert_in_front_hooks): Likewise.
7162
64520e5c
PE
7163 * term.c: Make symbols static if they're not exported.
7164 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7165 (max_frame_lines, tty_set_terminal_modes):
7166 (tty_reset_terminal_modes, tty_turn_off_highlight):
7167 (get_tty_terminal): Now static.
7168 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7169 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 7170 HAVE_WINDOW_SYSTEM.
64520e5c
PE
7171 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7172 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7173
1fa53021
PE
7174 * sysdep.c: Make symbols static if they're not exported.
7175 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7176 Now static.
7177 (sigprocmask_set, full_mask): Remove; unused.
7178 (wait_debugging): Mark as visible.
7179 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7180 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7181
d4b43b22
PE
7182 * syntax.c (syntax_temp): Define only if !__GNUC__.
7183
b7c513d0
PE
7184 * sound.c (current_sound_device, current_sound): Now static.
7185
989b29ad
PE
7186 * search.c (searchbufs, searchbuf_head): Now static.
7187
13a55a78
PE
7188 * scroll.c (scroll_cost): Remove; unused.
7189 * dispextern.h (scroll_cost): Remove decl.
7190
de68a1fc
PE
7191 * region-cache.h (pp_cache): Mark as externally visible.
7192
40ccffa6
PE
7193 * process.c: Make symbols static if they're not exported.
7194 (process_tick, update_tick, create_process, chan_process):
7195 (Vprocess_alist, proc_buffered_char, datagram_access):
7196 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7197 (deactivate_process): Mark defn as static, as well as decl.
7198 * lisp.h (create_process): Remove decl.
7199 * process.h (chan_process, Vprocess_alist): Remove decls.
7200
ad64fc97
PE
7201 * print.c: Make symbols static if they're not exported.
7202 (print_depth, new_backquote_output, being_printed, print_buffer):
7203 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7204 (print_interval, print_number_index, initial_stderr_stream):
7205 Now static.
7206 * lisp.h (Fprinc): Remove decl.
7207 (debug_output_compilation_hack): Mark as externally visible.
7208
adddb265
PE
7209 * sysdep.c (croak): Move decl from here to syssignal.h.
7210 * syssignal.h (croak): Put it here, so the API can be checked when
7211 'croak' is called from dissociate_if_controlling_tty.
7212
1717ede2
PE
7213 * minibuf.c: Make symbols static if they're not exported.
7214 (minibuf_save_list, choose_minibuf_frame): Now static.
7215 * lisp.h (choose_minibuf_frame): Remove decl.
7216
fa5fb2bc
PE
7217 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7218
1e3890d1
PE
7219 * lread.c: Make symbols static if they're not exported.
7220 (read_objects, initial_obarray, oblookup_last_bucket_number):
7221 Now static.
7222 (make_symbol): Remove; unused.
7223 * lisp.h (initial_obarray, make_symbol): Remove decls.
7224
8a1414fa
PE
7225 * keyboard.c: Make symbols static if they're not exported.
7226 (single_kboard, recent_keys_index, total_keys, recent_keys):
7227 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7228 (this_single_command_key_start, echoing, last_auto_save):
7229 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7230 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7231 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7232 (Vlispy_mouse_stem, double_click_count):
7233 Now static.
7234 (force_auto_save_soon): Define only if SIGDANGER.
7235 (ignore_mouse_drag_p): Now static if
7236 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7237 (print_help): Remove; unused.
7238 (stop_character, last_timer_event): Mark as externally visible.
7239 * keyboard.h (ignore_mouse_drag_p): Declare only if
7240 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7241 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7242 * lisp.h (echoing): Remove decl.
7243 (force_auto_save_soon): Declare only if SIGDANGER.
7244 * xdisp.c (redisplay_window): Simplify code, to make it more
7245 obvious that ignore_mouse_drag_p is not accessed if !defined
7246 USE_GTK && !defined HAVE_NS.
7247
93ea6e8f
PE
7248 * intervals.c: Make symbols static if they're not exported.
7249 (merge_properties_sticky, merge_interval_right, delete_interval):
7250 Now static.
7251 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7252
77382fcc
PE
7253 * insdel.c: Make symbols static if they're not exported.
7254 However, leave prepare_to_modify_buffer alone. It's never
7255 called from outside this function, but that appears to be a bug.
7256 (combine_after_change_list, combine_after_change_buffer):
4889fc82 7257 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
7258 (adjust_after_replace_noundo): Remove; unused.
7259 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 7260 (signal_before_change): Remove decls.
77382fcc 7261
9306c32e
PE
7262 * indent.c (val_compute_motion, val_vmotion): Now static.
7263
cd44d2eb
PE
7264 * image.c: Make symbols static if they're not exported.
7265 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7266 if USE_GTK.
7267 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7268 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7269
ad9a7a06
PE
7270 * fringe.c (standard_bitmaps): Now static.
7271 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7272
81626931
PE
7273 * frame.c: Make symbols static if they're not exported.
7274 (x_report_frame_params, make_terminal_frame): Now static.
7275 (get_frame_param): Now static, unless HAVE_NS.
7276 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7277 (x_get_resource_string): Remove; not used.
7278 * frame.h (make_terminal_frame, x_report_frame_params):
7279 (x_get_resource_string); Remove decls.
7280 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7281 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7282
239f9db9
PE
7283 * font.c, fontset.c: Make symbols static if they're not exported.
7284 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7285 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7286 * font.c (font_close_object): Now static.
7287 * font.h (font_close_object): Remove.
7288 * fontset.c (FONTSET_OBJLIST): Remove.
7289 (free_realized_fontset) #if-0 the body, which does nothing.
7290 (face_suitable_for_char_p): #if-0, as it's never called.
7291 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
7292 * xfaces.c (face_at_string_position):
7293 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
7294 since 0 is always ASCII.
7295
dfcf3579
PE
7296 * fns.c (weak_hash_tables): Now static.
7297
5045092b
PE
7298 * fileio.c: Make symbols static if they're not exported.
7299 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7300 (Vwrite_region_annotation_buffers): Now static.
7301
57a96f5c
PE
7302 * eval.c: Make symbols static if they're not exported.
7303 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7304 * lisp.h (backtrace_list): Remove decl.
7305
35f08c38
PE
7306 * emacs.c: Make symbols static if they're not exported.
7307 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7308 (fatal_error_code, fatal_error_signal_hook, standard_args):
7309 Now static.
7310 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7311 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7312 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7313 * lisp.h (fatal_error_signal_hook): Remove decl.
7314 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7315
f44bd759
PE
7316 * editfns.c: Move a (normally-unused) function to its only use.
7317 * editfns.c, lisp.h (get_operating_system_release): Remove.
7318 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7319 worth the hassle of breaking this out.
7320
b532497d
PE
7321 * xterm.c: Make symbols static if they're not exported.
7322 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7323 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7324 (x_destroy_window, x_delete_display):
7325 Now static.
7326 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7327 (x_mouse_leave): Remove; unused.
7328 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7329 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7330 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7331 Remove decls.
7332 (x_mouse_leave): Declare only if WINDOWSNT.
7333 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7334 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7335 USE_X_TOOLKIT.
7336
1675728f
PE
7337 * ftxfont.c: Make symbols static if they're not exported.
7338 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7339 HAVE_FREETYPE.
7340 * font.h (ftxfont_driver): Likewise.
7341
e4cebfca
PE
7342 * xfns.c: Make symbols static if they're not exported.
7343 (x_last_font_name, x_display_info_for_name):
7344 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7345 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7346 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7347 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7348 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7349 (last_show_tip_args): Now static.
7350 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7351 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7352 (x_screen_planes): Remove; unused.
7353 * dispextern.h (x_screen_planes): Remove decl.
7354
5bf46f05
PE
7355 * dispnew.c: Make symbols static if they're not exported.
7356 * dispextern.h (redraw_garbaged_frames, scrolling):
7357 (increment_row_positions): Remove.
7358 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7359 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7360 Now static.
7361 (redraw_garbaged_frames): Remove; unused.
7362
435f4c28
PE
7363 * xfaces.c: Make symbols static if they're not exported.
7364 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7365 Remove decls.
7366 * xterm.h (defined_color): Remove decls.
7367 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7368 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7369 (menu_face_changed_default, defined_color, free_realized_face):
7370 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7371 (ascii_face_of_lisp_face): Remove; unused.
7372
8524aef3
PE
7373 * xdisp.c: Make symbols static if they're not exported.
7374 * dispextern.h (scratch_glyph_row, window_box_edges):
7375 (glyph_to_pixel_coords, set_cursor_from_row):
7376 (get_next_display_element, set_iterator_to_next):
7377 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7378 (show_mouse_face): Remove decls
7379 * frame.h (message_buf_print): Likewise.
7380 * lisp.h (pop_message, set_message, check_point_in_composition):
7381 Likewise.
7382 * xterm.h (set_vertical_scroll_bar): Likewise.
7383 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7384 (message_buf_print, scratch_glyph_row, displayed_buffer):
7385 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7386 (get_next_display_element, show_mouse_face, window_box_edges):
7387 (frame_to_window_pixel_xy, check_point_in_composition):
7388 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7389 (glyph_to_pixel_coords): Remove; unused.
7390
16390cd2
PE
7391 * dired.c (file_name_completion): Now static.
7392
7393 * dbusbind.c (xd_in_read_queued_messages): Now static.
7394
a25f4dfa
PE
7395 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7396 * data.c (circular_list_error): Remove.
7397
14a9c8df
PE
7398 * commands.h (last_point_position, last_point_position_buffer):
7399 (last_point_position_window): Remove decls.
7400 * keyboard.c: Make these variables static.
7401
04f2d78b
CB
7402 * coding.h (coding, code_convert_region, encode_coding_gap):
7403 Remove decls.
74ab6df5
PE
7404 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7405 (iso_code_class, detect_coding, code_convert_region): Now static.
7406 (encode_coding_gap): Remove; unused.
7407
38dfbee1
PE
7408 * chartab.c (chartab_chars, chartab_bits): Now static.
7409
a2cb4e63
PE
7410 * charset.h (charset_iso_8859_1): Remove decl.
7411 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7412 Now static.
7413
127198fd
PE
7414 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7415 * ccl.c (Vccl_program_table): Now static.
7416 (check_ccl_update): Remove; unused.
7417
d85b608f
PE
7418 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7419 * category.h: ... from here.
7420 * category.c (check_category_table, set_category_set): Now static.
7421
31cd66f3
PE
7422 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7423 * lisp.h: Remove these decls.
7424
c358e587
PE
7425 * buffer.c (buffer_count): Remove unused var.
7426
e78aecca
PE
7427 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7428 so that it's not optimized away.
7429 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7430 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7431 exported only to the debugger.
7432
e192d7d3 7433 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 7434 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 7435
92470028
PE
7436 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7437 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7438 was inaccessible from Lisp.
7439 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7440 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7441
244ed907
PE
7442 alloc.c: Import and export fewer symbols, and remove unused items.
7443 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7444 is defined.
7445 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7446 it's not optimized away by whole-program optimization.
7447 (message_enable_multibyte, free_misc): Remove.
7448 (catchlist, handlerlist, mark_backtrace):
7449 Declare only if BYTE_MARK_STACK.
7450 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7451 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7452 (message_enable_multibyte): Remove decl.
7453 (free_misc, interval_free_list, float_block, float_block_index):
7454 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7455 (cons_free_list, last_marked_index):
7456 Now static.
7457 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7458 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7459 (mark_backtrace): Define only if BYTE_MARK_STACK.
7460 * xdisp.c (message_enable_multibyte): Now static.
7461
61c2b50e 7462 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
7463 This makes it easier for human readers (and static analyzers)
7464 to see whether these variables are used from other modules.
7465 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7466 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7467 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7468 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7469 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7470 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7471 * xmenu.c, xselect.c:
7472 Declare Q* vars static if they are not used in other modules.
7473 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7474 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7475 Remove decls of unexported vars.
7476 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7477
95c82688
PE
7478 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7479
16a97296
PE
7480 Make Emacs functions such as Fatom 'static' by default.
7481 This makes it easier for human readers (and static analyzers)
7482 to see whether these functions can be called from other modules.
7483 DEFUN now defines a static function. To make the function external
7484 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
7485 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7486 (Finit_image_library):
16a97296
PE
7487 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7488 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7489 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7490 Remove decls, since these functions are now static.
7491 (Funintern, Fget_internal_run_time): New decls, since these functions
7492 were already external.
95c82688 7493
16a97296
PE
7494 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7495 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7496 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7497 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7498 * keyboard.c, keymap.c, lread.c:
7499 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7500 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7501 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7502 Mark functions with DEFUE instead of DEFUN,
7503 if they are used in other modules.
7504 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7505 decls for now-static functions.
7506 * buffer.h (Fdelete_overlay): Remove decl.
7507 * callproc.c (Fgetenv_internal): Mark as internal.
7508 * composite.c (Fremove_list_of_text_properties): Remove decl.
7509 (Fcomposition_get_gstring): New forward static decl.
7510 * composite.h (Fcomposite_get_gstring): Remove decl.
7511 * dired.c (Ffile_attributes): New forward static decl.
7512 * doc.c (Fdocumntation_property): New forward static decl.
7513 * eval.c (Ffetch_bytecode): New forward static decl.
7514 (Funintern): Remove extern decl; now in .h file where it belongs.
7515 * fileio.c (Fmake_symbolic_link): New forward static decl.
7516 * image.c (Finit_image_library): New forward static decl.
7517 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7518 * intervals.h (Fprevious_property_change):
7519 (Fremove_list_of_text_properties): Remove decls.
7520 * keyboard.c (Fthis_command_keys): Remove decl.
7521 (Fcommand_execute): New forward static decl.
7522 * keymap.c (Flookup_key): New forward static decl.
7523 (Fcopy_keymap): Now static.
7524 * keymap.h (Flookup_key): Remove decl.
7525 * process.c (Fget_process): New forward static decl.
7526 (Fprocess_datagram_address): Mark as internal.
7527 * syntax.c (Fsyntax_table_p): New forward static decl.
7528 (skip_chars): Remove duplicate decl.
7529 * textprop.c (Fprevious_property_change): New forward static decl.
7530 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7531 Now internal.
7532 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7533 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7534
785bbd42
PE
7535 * editfns.c (Fformat): Remove unreachable code.
7536
8b913b57
AS
75372011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7538
7539 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7540 change. (Bug#8496)
7541
a6744a35
EZ
75422011-04-13 Eli Zaretskii <eliz@gnu.org>
7543
7544 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7545 when at ZV. (Bug#8487)
7546
e7974947
AS
75472011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7548
baad03f0
AS
7549 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7550 (Bug#8437)
7551 * keyboard.c (parse_tool_bar_item): Likewise.
7552 * sound.c (sound_cleanup, alsa_close): Likewise.
7553 * termcap.c (tgetent): Likewise.
7554 * xfns.c (x_default_font_parameter): Likewise.
7555 * xsettings.c (read_and_apply_settings): Likewise.
7556
e7974947
AS
7557 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7558 (overrun_check_free): Protoize.
7559
28272684
PE
75602011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7561
7562 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7563 since callers should never pass a negative size.
7564 Change the signature to match that of plain 'read' and 'write'; see
7565 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7566 * lisp.h: Update prototypes of emacs_write and emacs_read.
7567
11997c76
EZ
75682011-04-11 Eli Zaretskii <eliz@gnu.org>
7569
7570 * xdisp.c (redisplay_window): Don't try to determine the character
7571 position of the scroll margin if the window start point w->startp
e896f03c 7572 is outside the buffer's accessible region. (Bug#8468)
11997c76 7573
8a2cbd72
EZ
75742011-04-10 Eli Zaretskii <eliz@gnu.org>
7575
7576 Fix write-region and its subroutines for buffers > 2GB.
7577 * fileio.c (a_write, e_write): Modify declaration of arguments and
7578 local variables to support buffers larger than 2GB.
7579 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7580
7581 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7582 argument, local variables, and return value.
7583
7584 * lisp.h: Update prototypes of emacs_write and emacs_read.
7585
7586 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7587
4073e537 75882011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 7589
1ebfdcb6
PE
7590 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7591
b2ded58d
PE
7592 Fix more problems found by GCC 4.6.0's static checks.
7593
7d66342c
PE
7594 * xdisp.c (vmessage): Use a better test for character truncation.
7595
bbf47d44
PE
7596 * charset.c (load_charset_map): <, not <=, for optimization,
7597 and to avoid potential problems with integer overflow.
9248994d 7598 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 7599 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 7600 * editfns.c (Fformat): Likewise.
1e69125e 7601 * syntax.c (skip_chars): Likewise.
3befa583 7602
e3019616
PE
7603 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7604 This also lets GCC 4.6.0 generate slightly better loop code.
7605
becfa255
PE
7606 * callint.c (Fcall_interactively): <, not <=, for optimization.
7607 (Fcall_interactively): Count the number of arguments produced,
7608 not the number of arguments given. This is simpler and lets GCC
7609 4.6.0 generate slightly better code.
7610
dae0cd48
PE
7611 * ftfont.c: Distingish more carefully between FcChar8 and char.
7612 The previous code passed unsigned char * to a functions like
7613 strlen and xstrcasecmp that expect char *, which does not
7614 conform to the C standard.
7615 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7616 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7617 char * when the C standard requires it.
7618
76032d70
PE
7619 * keyboard.c (read_char): Remove unused var.
7620
eb3f1cc8
PE
7621 * eval.c: Port to Windows vsnprintf (Bug#8435).
7622 Include <limits.h>.
7623 (SIZE_MAX): Define if the headers do not.
7624 (verror): Do not give up if vsnprintf returns a negative count.
7625 Instead, grow the buffer. This ports to Windows vsnprintf, which
7626 does not conform to C99. Problem reported by Eli Zaretskii.
7627 Also, simplify the allocation scheme, by avoiding the need for
7628 calling realloc, and removing the ALLOCATED variable.
7629
70476b54
PE
7630 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7631
12020a9e
PE
7632 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7633 But keep the doprint source code for now, as we might revamp it
7634 and use it again (Bug#8435).
ea6c7ae6
PE
7635 * lisp.h (doprnt): Remove.
7636 * Makefile.in (base_obj): Remove doprnt.o.
7637 * deps.mk (doprnt.o): Remove.
7638
5fdb398c
PE
7639 error: Print 32- and 64-bit integers portably (Bug#8435).
7640 Without this change, on typical 64-bit hosts error ("...%d...", N)
7641 was used to print both 32- and 64-bit integers N, which relied on
7642 undefined behavior.
7643 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7644 New macro.
7645 * lisp.h (error, verror): Mark as printf-like functions.
7646 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7647 Report overflow in size calculations when allocating printf buffer.
7648 Do not truncate output string at its first null byte.
7649 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7650 Truncate the output at a character boundary, since vsnprintf does not
7651 do that.
7652 * charset.c (check_iso_charset_parameter): Convert internal
7653 character to string before calling 'error', since %c now has the
7654 printf meaning.
7655 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7656 overflow when computing char to be passed to 'error'. Do not
7657 pass Lisp_Object to 'error'; pass the integer instead.
7658 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7659 formatted with plain %d.
7660
b189fa66
PE
7661 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7662
bff87ef0
PE
7663 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7664
7e2cac20
PE
7665 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7666
ce4d90b5
PE
7667 * xterm.c (x_catch_errors): Remove duplicate declaration.
7668
266c9547
PE
7669 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7670
79c49ad2
PE
7671 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7672
368f4090
JM
76732011-04-10 Jim Meyering <meyering@redhat.com>
7674
7675 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7676 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7677 return ssize_t not "int", and use size_t as the buffer length.
7678 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7679 * gnutls.h: Update declarations.
7680 * process.c (read_process_output): Use ssize_t, to match.
7681 (send_process): Likewise.
7682
a32d4040
CY
76832011-04-09 Chong Yidong <cyd@stupidchicken.com>
7684
7685 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7686
8546720e 76872011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 7688
04f2d78b
CB
7689 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7690 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 7691
8546720e
GM
7692 * xterm.c (handle_one_xevent):
7693 * xmenu.c (create_and_show_popup_menu):
7694 * xselect.c (x_decline_selection_request)
7695 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 7696
0a2f5c1a 76972011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
7698
7699 Fix some uses of `int' instead of EMACS_INT.
7700 * search.c (string_match_1, fast_string_match)
7701 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7702 (scan_buffer, find_next_newline_no_quit)
7703 (find_before_next_newline, search_command, Freplace_match)
7704 (Fmatch_data): Make some `int' variables be EMACS_INT.
7705
7706 * xdisp.c (display_count_lines): 3rd argument and return value now
7707 EMACS_INT. All callers changed.
7708 (pint2hrstr): Last argument is now EMACS_INT.
7709
7710 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7711 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7712 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7713 (decode_coding_utf_16, decode_coding_emacs_mule)
7714 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7715 (decode_coding_ccl, decode_coding_charset)
7716 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7717 (decode_coding_iso_2022, decode_coding_emacs_mule)
7718 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7719 <char_offset, last_offset>: Declare EMACS_INT.
7720 (encode_coding_utf_8, encode_coding_utf_16)
7721 (encode_coding_emacs_mule, encode_invocation_designation)
7722 (encode_designation_at_bol, encode_coding_iso_2022)
7723 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7724 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7725 Declare EMACS_INT.
7726 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7727 (encode_invocation_designation): Last argument P_NCHARS is now
7728 EMACS_INT.
7729 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7730 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7731
7732 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7733 All users changed.
7734
7735 * ccl.c (Fccl_execute_on_string): Declare some variables
7736 EMACS_INT.
7737
8546720e 77382011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
7739
7740 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7741
4e19a977
CS
77422011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7743
7744 * process.c (Fformat_network_address): Doc fix.
7745
87302331
R
77462011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7747
ee7683eb 7748 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 7749
cbb59342
CY
77502011-04-08 Chong Yidong <cyd@stupidchicken.com>
7751
7752 * keyboard.c (read_char): Call Lisp function help-form-show,
7753 instead of using internal_with_output_to_temp_buffer.
7754 (Qhelp_form_show): New var.
e0d38eeb 7755 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
7756
7757 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7758
7759 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7760
e67a13ab
CY
77612011-04-06 Chong Yidong <cyd@stupidchicken.com>
7762
04f2d78b
CB
7763 * process.c (Flist_processes): Remove to Lisp.
7764 (list_processes_1): Delete.
e67a13ab 7765
973f782d
EZ
77662011-04-06 Eli Zaretskii <eliz@gnu.org>
7767
7c106b1e
EZ
7768 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7769
973f782d
EZ
7770 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7771
41cf7d1a 77722011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 7773
ca23cc88
PE
7774 Fix more problems found by GCC 4.6.0's static checks.
7775
f390e2d5
PE
7776 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7777
42eea0d0
PE
7778 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7779
b69769da 7780 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 7781
f9541e84
PE
7782 * xdisp.c (vmessage): Mark as a printf-like function.
7783
13841b55
PE
7784 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7785
c136c10f
PE
7786 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7787
5e2d4a30
PE
7788 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7789 printf-like functions.
7790 (tiff_load): Add casts to remove these marks before passing them
7791 to system-supplied API.
7792
583f48b9
PE
7793 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7794
b25d760e
PE
7795 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7796 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
7797 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7798 directly, rather than having caller test rule sign. This avoids
7799 some unnecessary tests.
7800 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7801 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7802 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 7803
bc7b6697 7804 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 7805 (xfont_open): Avoid unnecessary tests.
bc7b6697 7806
27ccc379
PE
7807 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7808
dcd5c89a
PE
7809 * composite.h, composite.c (composition_gstring_put_cache):
7810 Use EMACS_INT, not int, for length.
7811
b13a45c6
PE
7812 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7813 breaking out part of COMPOSITION_DECODE_RULE.
7814 (COMPOSITION_DECODE_RULE): Use it.
7815 * composite.c (get_composition_id): Remove unused local vars,
7816 by using the new macro.
7817
1e792e4d
PE
7818 * textprop.c (set_text_properties_1): Change while to do-while,
7819 since the condition is always true at first.
7820
dc6c6455 7821 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
7822 (interval_deletion_adjustment): Return unsigned value.
7823 All uses changed.
dc6c6455 7824
aba7731a
PE
7825 * process.c (list_processes_1, create_pty, read_process_output):
7826 (exec_sentinel): Remove vars that were set but not used.
afd4052b 7827 (create_pty): Remove unnecessary "volatile"s.
bc57d757 7828 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 7829 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 7830 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 7831
fdfc4bf3
PE
7832 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7833
fca8fe46 7834 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 7835 (update_syntax_table): Use unsigned instead of int.
fca8fe46 7836
06a0259a 7837 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 7838 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 7839 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 7840
e7b9e80f
PE
7841 * print.c (print_error_message): Avoid int overflow.
7842
56201685
PE
7843 * font.c (font_list_entities): Redo for clarity,
7844 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7845
78834453 7846 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 7847 (font_score): Avoid potential overflow in diff calculation.
78834453 7848
0bc0b309 7849 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 7850 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 7851
e610eaca
PE
7852 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7853
b895abce
PE
7854 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7855 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7856 can always succeed if overflow has undefined behavior.
7857
1f1d9321 7858 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 7859 (wordify): Omit three unnecessary tests.
1f1d9321 7860
c59478bc
PE
7861 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7862 All callers changed. This avoids the need for an unused var.
7863
79b73827
PE
7864 * casefiddle.c (casify_region): Remove var that is set but not used.
7865
a4db5dfe
PE
7866 * dired.c (file_name_completion): Remove var that is set but not used.
7867
43aae36e
PE
7868 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7869
2a47c44d 7870 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 7871 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 7872
a37c69bf
PE
7873 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7874 Check for integer overflow on size calculations.
7875
328ab8e7
PE
7876 * buffer.c (Fprevious_overlay_change): Remove var that is set
7877 but not used.
7878
e5a2a5cb
PE
7879 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7880 Remove vars that are set but not used.
8d84a6eb 7881 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 7882 (timer_check_2): Mark vars as initialized.
e5a2a5cb 7883
a60e5f68
PE
7884 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7885
f661cb61 7886 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 7887 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 7888
f0397f5a
PE
7889 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7890 that are set but not used.
7891
8664db06 7892 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 7893 if XCreateBitmapFromData fails (Bug#8410).
8664db06 7894
6abdaa4a
PE
7895 * xselect.c (x_get_local_selection, x_handle_property_notify):
7896 Remove vars that are set but not used.
7897
0ce7538d 7898 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 7899 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 7900
9ae848fc
PE
7901 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7902 Remove var that is set but not used.
0b918413
PE
7903 (scroll_bar_windows_size): Now size_t, not int.
7904 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7905 Check for overflow.
9ae848fc 7906
a5a62657
PE
7907 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7908 (map_tty_color) [!defined MSDOS]: Likewise.
7909
5c5cdd39
PE
7910 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7911
66ebf983
PE
7912 * coding.c: Remove vars that are set but not used.
7913 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7914 All callers changed.
7915 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7916 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7917 (decode_coding_charset): Remove vars that are set but not used.
7918
1be4d761
PE
7919 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7920 that is set but not used.
7921
47553fa8
PE
7922 * print.c (print_object): Remove var that is set but not used.
7923
1f7196bf 7924 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
7925 The gnulib version avoids calling malloc in the usual case,
7926 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7927 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7928 * filelock.c (current_lock_owner): Likewise.
7929 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7930 * sysdep.c: Include allocator.h, careadlinkat.h.
7931 (emacs_no_realloc_allocator): New static constant.
7932 (emacs_readlink): New function.
fdb61804
PE
7933 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7934 ../lib/careadlinkat.h.
d1fdcab7 7935
f84c17c7
SM
79362011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7937
7938 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7939 first non-nil return value).
7940
ef3862ad
JD
79412011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7942
7943 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7944 if not defined (Bug#8403).
7945
376a7006
JB
79462011-04-02 Juanma Barranquero <lekktu@gmail.com>
7947
7948 * xdisp.c (display_count_lines): Remove parameter `start',
7949 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7950 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7951 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7952 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7953 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7954 and thereabouts. All callers changed.
7955 (get_per_char_metric): Remove parameter `f', unused since
7956 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7957
6ca3801d
JM
79582011-04-02 Jim Meyering <meyering@redhat.com>
7959
7960 do not dereference NULL upon failed strdup
7961 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7962 (ns_get_family): Likewise.
7963
d8e2b5ba
JB
79642011-04-02 Juanma Barranquero <lekktu@gmail.com>
7965
7966 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7967
8c74fcbd
JD
79682011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7969
7970 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7971 later (Bug#8403).
7972
7200d79c
SM
79732011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7974
03408648 7975 Add lexical binding.
7200d79c 7976
03408648
SM
7977 * window.c (Ftemp_output_buffer_show): New fun.
7978 (Fsave_window_excursion):
7979 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7980
7981 * lread.c (lisp_file_lexically_bound_p): New function.
7982 (Fload): Bind Qlexical_binding.
7983 (readevalloop): Remove `evalfun' arg.
7984 Bind Qinternal_interpreter_environment.
7985 (Feval_buffer): Bind Qlexical_binding.
7986 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7987 Mark as dynamic.
7988 (syms_of_lread): Declare `lexical-binding'.
7989
7990 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7991
7992 * keyboard.c (eval_dyn): New fun.
7993 (menu_item_eval_property): Use it.
ca105506
SM
7994
7995 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 7996
03408648
SM
7997 * fns.c (concat, mapcar1): Accept byte-code-functions.
7998
7999 * eval.c (Fsetq): Handle lexical vars.
8000 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8001 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8002 (FletX, Flet): Obey lexical binding.
8003 (Fcommandp): Handle closures.
8004 (Feval): New `lexical' arg.
8005 (eval_sub): New function extracted from Feval. Use it almost
8006 everywhere where Feval was used. Look up vars in lexical env.
8007 Handle closures.
8008 (Ffunctionp): Move from subr.el.
8009 (Ffuncall): Handle closures.
8010 (apply_lambda): Remove `eval_flags'.
8011 (funcall_lambda): Handle closures and new byte-code-functions.
8012 (Fspecial_variable_p): New function.
8013 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8014 but without exporting it to Lisp.
23aba0ea 8015
23aba0ea 8016 * doc.c (Fdocumentation, store_function_docstring):
03408648 8017 * data.c (Finteractive_form): Handle closures.
23aba0ea 8018
03408648
SM
8019 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8020 interactive spec.
ba83908c 8021
04f2d78b
CB
8022 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8023 New byte-codes.
03408648
SM
8024 (exec_byte_code): New function extracted from Fbyte_code to handle new
8025 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 8026
03408648 8027 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 8028
03408648 8029 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 8030
e2abce01
JB
80312011-03-31 Juanma Barranquero <lekktu@gmail.com>
8032
8033 * xdisp.c (redisplay_internal): Fix prototype.
8034
63696a73 80352011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 8036
63696a73 8037 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
8038 (try_scrolling): Use it when setting scroll_limit.
8039 Limit scrolling to 100 screen lines.
63696a73
EZ
8040 (redisplay_window): Even when falling back on "recentering",
8041 position point in the window according to scroll-conservatively,
8042 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8043
8044 (try_scrolling): When point is above the window, allow searching
8045 as far as scroll_max, or one screenful, to compute vertical
8046 distance from PT to the scroll margin position. This prevents
8047 try_scrolling from unnecessarily failing when
8048 scroll-conservatively is set to a value slightly larger than the
8049 window height. Clean up the case of PT below the margin at bottom
8050 of window: scroll_max can no longer be INT_MAX. When aggressive
8051 scrolling is in use, don't let point enter the opposite scroll
8052 margin as result of the scroll.
8053 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
8054 threshold of 100 lines for never-recentering scrolling.
8055
e4cc2dfc
JB
80562011-03-31 Juanma Barranquero <lekktu@gmail.com>
8057
8058 * dispextern.h (move_it_by_lines):
8059 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8060 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8061 (message_log_check_duplicate): Remove parameters `prev_bol' and
8062 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8063 (redisplay_internal): Remove parameter `preserve_echo_area',
8064 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8065
8066 * indent.c (Fvertical_motion):
8067 * window.c (window_scroll_pixel_based, Frecenter):
8068 Don't pass `need_y_p' to `move_it_by_lines'.
8069
1c470562
SM
80702011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8071
44f230aa
SM
8072 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8073 steal a few bits to be more compact.
8074 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8075 Remove unneeded casts.
8076
1c470562
SM
8077 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8078
888adce9
ZK
80792011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8080
8081 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8082 binding" message (bug#7967).
8083
f838ed7b
PE
80842011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8085
77861b95
PE
8086 Fix more problems found by GCC 4.6.0's static checks.
8087
de6dbc14
PE
8088 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8089 Remove unused local var.
8090
f838ed7b
PE
8091 * editfns.c (Fmessage_box): Remove unused local var.
8092
792c7b2b
PE
8093 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8094 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8095 Omit unused local vars.
c499e557 8096 * window.c (shrink_windows): Omit unused local var.
b01a1c29 8097 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
8098 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8099 Omit unused local var.
8100
ba0165e1
PE
8101 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8102 Don't assume string length fits in int.
32ad8845 8103 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 8104 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 8105
3c59b4c9
PE
8106 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8107 instead of alloca (Bug#8344).
8108
a3eed478 8109 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 8110 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 8111
eb4d412d
PE
8112 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8113
1658b401
PE
8114 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8115 concerns.
8116
8117 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8118
8119 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 8120
9a2c6e05
PE
8121 * keyboard.c (syms_of_keyboard): Use the same style as later
8122 in this function when indexing through an array. This also
8123 works around GCC bug 48267.
8124
03d0a109
PE
8125 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8126
44f730c8
PE
8127 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8128
fe75f926
PE
8129 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8130 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8131
ffa8c828
PE
8132 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8133 This avoids undefined behavior on integer overflow, and is a bit
8134 more convenient anyway since it is compared to a size_t variable.
8135
c5101a77
PE
8136 Variadic C functions now count arguments with size_t, not int.
8137 This avoids an unnecessary limitation on 64-bit machines, which
8138 caused (substring ...) to crash on large vectors (Bug#8344).
8139 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8140 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 8141 All variadic functions and their callers changed accordingly.
c5101a77
PE
8142 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8143 * data.c (arith_driver, float_arith_driver): Likewise.
8144 * editfns.c (general_insert_function): Likewise.
8145 * eval.c (struct backtrace.nargs, interactive_p)
8146 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8147 (funcall_lambda, mark_backtrace): Likewise.
8148 * fns.c (concat): Likewise.
8149 * frame.c (x_set_frame_parameters): Likewise.
8150 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8151 0 if not found, not -1. All callers changed.
8152
dd3f25f7
PE
8153 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8154 (stack_copy_size): Now size_t, not int.
8155 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8156
461c2ab9
JB
81572011-03-28 Juanma Barranquero <lekktu@gmail.com>
8158
8159 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8160 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8161 All callers changed.
8162
8163 * lisp.h (multibyte_char_to_unibyte):
8164 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8165 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8166 * character.h (CHAR_TO_BYTE8):
8167 * cmds.c (internal_self_insert):
8168 * editfns.c (general_insert_function):
8169 * keymap.c (push_key_description):
8170 * search.c (Freplace_match):
8171 * xdisp.c (message_dolog, set_message_1): All callers changed.
8172
f6d62986
SM
81732011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8174
8175 * keyboard.c (safe_run_hook_funcall): New function.
8176 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8177 don't set the hook to nil, but remove the offending function instead.
8178 (Qcommand_hook_internal): Remove, unused.
8179 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8180 Vcommand_hook_internal.
8181
8182 * eval.c (enum run_hooks_condition): Remove.
8183 (funcall_nil, funcall_not): New functions.
8184 (run_hook_with_args): Call each function through a `funcall' argument.
8185 Remove `cond' argument, now redundant.
8186 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8187 (Frun_hook_with_args_until_failure): Adjust accordingly.
8188 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8189
1db5b1ad
JB
81902011-03-28 Juanma Barranquero <lekktu@gmail.com>
8191
8192 * dispextern.h (string_buffer_position): Remove declaration.
8193
8194 * print.c (strout): Remove parameter `multibyte', unused since
8195 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8196
8197 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8198 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8199 All callers changed.
8200
8201 * w32.c (_wsa_errlist): Use braces for struct initializers.
8202
8203 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8204 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8205 All callers changed.
8206 (string_buffer_position): Likewise. Also, make static (it's never
8207 used outside xdisp.c).
8208 (cursor_row_p): Remove parameter `w', unused since
8209 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8210 (decode_mode_spec): Remove parameter `precision', introduced during
8211 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8212 All callers changed.
8213
5ffb62aa
JD
82142011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8215
8216 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8217
461c2ab9 82182011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
8219
8220 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8221 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8222 (ns_update_auto_hide_menu_bar): New functions.
8223 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8224 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8225 ns_constrain_all_frames.
8226 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8227 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8228
5c380ffb
JD
82292011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8230
8231 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8232
9af30bdf
GM
82332011-03-27 Glenn Morris <rgm@gnu.org>
8234
8235 * syssignal.h: Replace RETSIGTYPE with void.
8236 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8237 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8238 Replace SIGTYPE with void everywhere.
8239 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8240 * s/template.h (SIGTYPE): Remove commented out definition.
8241
e2abce01
JB
82422011-03-26 Eli Zaretskii <eliz@gnu.org>
8243
8244 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8245 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8246
f868cd8a
JB
82472011-03-26 Juanma Barranquero <lekktu@gmail.com>
8248
59eb0929
JB
8249 * w32.c (read_unc_volume): Use parameter `henum', instead of
8250 global variable `wget_enum_handle'.
8251
8252 * keymap.c (describe_vector): Remove parameters `indices' and
8253 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8254 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8255
f868cd8a
JB
8256 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8257
8258 * keyboard.c (timer_check): Remove parameter `do_it_now',
8259 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8260 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8261 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8262
8263 * keyboard.c (read_char):
8264 * w32menu.c (w32_menu_display_help):
8265 * xmenu.c (show_help_event, menu_help_callback):
8266 Adjust calls to `show_help_echo'.
8267
8268 * gtkutil.c (xg_maybe_add_timer):
8269 * keyboard.c (readable_events):
8270 * process.c (wait_reading_process_output):
8271 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8272
8273 * insdel.c (adjust_markers_gap_motion):
8274 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8275 (gap_left, gap_right): Don't call it.
8276
2ecf6fdb
CY
82772011-03-25 Chong Yidong <cyd@stupidchicken.com>
8278
8279 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8280 incurred during fontification.
8281
6b1f9ba4
JB
82822011-03-25 Juanma Barranquero <lekktu@gmail.com>
8283
8284 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8285 (DEFVAR_PER_BUFFER): Don't pass it.
8286
8287 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8288 (scrolling_window): Don't pass it.
8289
0f4a96b5
JB
82902011-03-25 Juanma Barranquero <lekktu@gmail.com>
8291
8292 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8293
8294 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8295 and `suffix'.
8296 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8297 of variables specific to SELinux and computation of `encoded_absname'.
8298
8299 * image.c (XPutPixel): Remove unused variable `height'.
8300
8301 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8302
8303 * unexw32.c (get_section_info): Remove unused variable `section'.
8304
8305 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8306 (system_process_attributes): Remove unused variable `sess'.
8307 (sys_read): Remove unused variable `err'.
8308
8309 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8310 (w32_wnd_proc): Remove unused variable `isdead'.
8311 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8312 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8313 (x_create_tip_frame): Remove unused variable `tem'.
8314
8315 * w32inevt.c (w32_console_read_socket):
8316 Remove unused variable `no_events'.
8317
8318 * w32term.c (x_draw_composite_glyph_string_foreground):
8319 Remove unused variable `width'.
8320
1149507c
JB
83212011-03-24 Juanma Barranquero <lekktu@gmail.com>
8322
8323 * w32term.c (x_set_glyph_string_clipping):
8324 Don't pass uninitialized region to CombineRgn.
8325
9c88f339
JB
83262011-03-23 Juanma Barranquero <lekktu@gmail.com>
8327
8328 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8329 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8330 (Fx_close_connection): Remove unused variable `i'.
8331
8332 * w32font.c (w32font_draw): Return number of glyphs.
8333 (w32font_open_internal): Remove unused variable `i'.
8334 (w32font_driver): Add missing initializer.
8335
8336 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8337 (fill_in_menu): Remove unused variable `items_added'.
8338
8339 * w32term.c (last_mouse_press_frame): Remove static global variable.
8340 (w32_clip_to_row): Remove unused variable `f'.
8341 (x_delete_terminal): Remove unused variable `i'.
8342
8343 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8344 (NOTHING): Remove unused static global variable.
8345 (uniscribe_check_otf): Remove unused variable `table'.
8346 (uniscribe_font_driver): Add missing initializers.
8347
dee091a3
JD
83482011-03-23 Julien Danjou <julien@danjou.info>
8349
8350 * term.c (Fsuspend_tty, Fresume_tty):
8351 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8352 * window.c (temp_output_buffer_show):
8353 * insdel.c (signal_before_change):
8354 * frame.c (Fhandle_switch_frame):
8355 * fileio.c (Fdo_auto_save):
8356 * emacs.c (Fkill_emacs):
8357 * editfns.c (save_excursion_restore):
8358 * cmds.c (internal_self_insert):
8359 * callint.c (Fcall_interactively):
8360 * buffer.c (Fkill_all_local_variables):
8361 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8362 Use Frun_hooks.
0f4a96b5 8363 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 8364 unconditionally since it does the check itself.
dee091a3 8365
2c520ab5 83662011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 8367
c9c49752
PE
8368 Fix more problems found by GCC 4.5.2's static checks.
8369
8abc3f12
PE
8370 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8371 the first time through the loop, since we know p0 < p1 then.
8372 This also avoids a gcc -Wstrict-overflow warning.
8373
a2d26660
PE
8374 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8375 leading to a memory leak, possible in functions like
8376 load_charset_map_from_file that can allocate an unbounded number
b12ef411 8377 of objects (Bug#8318).
a2d26660 8378
916c72e9
PE
8379 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8380 that could (at least in theory) be that large.
8381
19ab8a18
PE
8382 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8383 This is less likely to overflow, and avoids undefined behavior if
8384 overflow does occur. All callers changed. Use strtoul to scan
8385 for the unsigned long integer.
b7cbbd6f
PE
8386 (pint2hrstr): Simplify and tune code slightly.
8387 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 8388
f0641eff
PE
8389 * scroll.c (do_scrolling): Work around GCC bug 48228.
8390 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8391
7f650bb9
PE
8392 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8393 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
8394 (validate_x_resource_name): Simplify count usage.
8395 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 8396
37dd57d1
PE
8397 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8398 fail (Bug#8306).
81e56e61 8399
699979fc 8400 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 8401
401bf9b4
PE
8402 * process.c (Fmake_network_process): Use socklen_t, not int,
8403 where POSIX says socklen_t is required in portable programs.
8404 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 8405 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
8406 (Fmake_network_process, server_accept_connection):
8407 (wait_reading_process_output, read_process_output):
8408 Likewise.
8409
b93aacde
PE
8410 * process.c: Rename or move locals to avoid shadowing.
8411 (list_processes_1, Fmake_network_process):
8412 (read_process_output_error_handler, exec_sentinel_error_handler):
8413 Rename or move locals.
4dc343ee 8414 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 8415 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 8416 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 8417 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 8418 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 8419
af8a867c 8420 Make tparam.h and terminfo.c consistent.
44f230aa
SM
8421 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8422 Include tparam.h instead, since it declares them.
af8a867c
PE
8423 * cm.h (PC): Remove extern decl; tparam.h now does this.
8424 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8425 * terminfo.c: Include tparam.h, to check interfaces.
8426 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8427 (tparam): Adjust signature to match interface in tparam.h;
8428 this removes some undefined behavior. Check that outstring and len
8429 are zero, which they always are with Emacs.
8430 * tparam.h (PC, BC, UP): New extern decls.
8431
0248044d 8432 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 8433 (xftfont_open): Rename locals to avoid shadowing.
0248044d 8434
8ff096c1 8435 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
8436 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8437 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 8438 (ftfont_list): Remove unused local.
49eaafba
PE
8439 (get_adstyle_property, ftfont_pattern_entity):
8440 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8441 Rename locals to avoid shadowing.
8ff096c1 8442
e2be39f6
PE
8443 * xfont.c (xfont_list_family): Mark var as initialized.
8444
c9735e30
PE
8445 * xml.c (make_dom): Now static.
8446
8f5201ae
PE
8447 * composite.c (composition_compute_stop_pos): Rename local to
8448 avoid shadowing.
b246f932
PE
8449 (composition_reseat_it): Remove unused locals.
8450 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 8451 (composition_update_it): Mark var as initialized.
11b61122
PE
8452 (find_automatic_composition): Mark vars as initialized,
8453 with a FIXME (Bug#8290).
8f5201ae 8454
760fbc2c
PE
8455 character.h: Rename locals to avoid shadowing.
8456 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8457 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8458 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8459 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8460 to avoid shadowing.
8461
ff08eb85
PE
8462 * textprop.c (property_change_between_p): Remove; unused.
8463
fc7bf025
PE
8464 * intervals.c (interval_start_pos): Now static.
8465
235d7abc
PE
8466 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8467
44f230aa
SM
8468 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8469 Rename locals to avoid shadowing.
3e7d6594 8470
50060332
PE
8471 * sound.c (wav_play, au_play, Fplay_sound_internal):
8472 Fix pointer signedness.
d01f234b 8473 (alsa_choose_format): Remove unused local var.
c83b8872
PE
8474 (wav_play): Initialize a variable to 0, to prevent undefined
8475 behavior (Bug#8278).
50060332 8476
c4fc4e30
PE
8477 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8478
918436ed
PE
8479 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8480
c939f91b
PE
8481 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8482 clobbering (Bug#8298).
b9c7f648
PE
8483 * sysdep.c (sys_subshell): Likewise.
8484 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 8485
6bd8c144
PE
8486 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8487 This should get cleaned up, so that child_setup has the
8488 same signature on all platforms.
8489
7710357c 8490 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 8491 (relocate_fd): Rename locals to avoid shadowing.
7710357c 8492
c59da222
CY
84932011-03-22 Chong Yidong <cyd@stupidchicken.com>
8494
8495 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8496 not to be necessary, and produces flickering.
8497
66b87493
GM
84982011-03-20 Glenn Morris <rgm@gnu.org>
8499
8500 * config.in: Remove file.
8501
45b6f6d5
JB
85022011-03-20 Juanma Barranquero <lekktu@gmail.com>
8503
8504 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8505 are now in src/globals.h.
8506 (syms_of_minibuf): Remove spurious & from previous change.
8507
cd394be1 85082011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
8509
8510 * minibuf.c (completing-read-function): New variable.
8511 (completing-read-default): Rename from completing-read.
8512 (completing-read): Call completing-read-function.
8513
b14e3e21
CY
85142011-03-19 Juanma Barranquero <lekktu@gmail.com>
8515
8516 * xfaces.c (Fx_load_color_file):
8517 Read color file from absolute filename (bug#8250).
8518
f2b726e6
JB
85192011-03-19 Juanma Barranquero <lekktu@gmail.com>
8520
8521 * makefile.w32-in: Update dependencies.
8522
09f6ff02
EZ
85232011-03-17 Eli Zaretskii <eliz@gnu.org>
8524
8525 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8526
29a6015a
PE
85272011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8528
a3a6c54e
PE
8529 Fix more problems found by GCC 4.5.2's static checks.
8530
b766f867
PE
8531 * process.c (make_serial_process_unwind, send_process_trap):
8532 (sigchld_handler): Now static.
8533
be02381c
PE
8534 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8535 That way, the code declares only the vars that it needs.
8536 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8537 * s/cygwin.h (PTY_ITERATION): Likewise.
8538 * s/darwin.h (PTY_ITERATION): Likewise.
8539 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8540
57048744
PE
8541 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8542 * process.c (allocate_pty): Don't declare stb unless it's needed.
8543
7914961c 8544 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
8545 (CONSTANTLIM): Remove; unused.
8546 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8547 Define only if needed.
7914961c 8548
b3967b18
PE
8549 * unexelf.c (unexec): Name an expression,
8550 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
8551 Use a different way to cause a compilation error if anyone uses
8552 n rather than nn, a way that does not involve shadowing.
73366a00 8553 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 8554
29a6015a
PE
8555 * deps.mk (unexalpha.o): Remove; unused.
8556
43cfc33e 8557 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 8558 * unexec.h: New file.
ce701a33
PE
8559 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8560 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8561 Depend on unexec.h.
8562 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8563 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8564 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 8565 Change as necessary to match prototype in unexec.h.
ce701a33 8566
01f44d5a
PE
8567 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8568 shadowing.
4f63c6bb 8569 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 8570
a6670b0b
PE
8571 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8572 Rename locals to avoid shadowing.
8573
cef2010d 8574 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 8575 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 8576
d4d7173a
PE
8577 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8578
f08b802a
PE
8579 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8580 warning when compiling print.c.
8581
3ddb0639
PE
8582 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8583 instead of using an uninitialized var.
5ad03b97 8584 (font_sort_entities): Mark var as initialized.
3ddb0639 8585
170a2692
PE
8586 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8587
e663c700
PE
8588 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8589 pointers to constants.
89bc529a 8590 (font_parse_fcname): Remove unused vars.
7b81e2d0 8591 (font_delete_unmatched): Now static.
ea838e10 8592 (font_get_spec): Remove; unused.
13a547c6
PE
8593 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8594 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8595 Rename or move locals to avoid shadowing.
e663c700 8596
2a80c887 8597 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 8598 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 8599
1384fa33 8600 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 8601 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 8602
8b2c52e9
PE
8603 * alloc.c (mark_backtrace): Move decl from here ...
8604 * lisp.h: ... to here, so that it can be checked.
8605
475545b5 8606 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 8607 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
8608 (lisp_indirect_variable): Name an expression,
8609 to avoid gcc -Wbad-function-cast warning.
1faed8ae 8610 (Fdefvar): Rename locals to avoid shadowing.
475545b5 8611
b1349114 8612 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 8613 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 8614 Use const pointer when appropriate.
b1349114 8615
a2928364
PE
8616 * lisp.h (get_system_name, get_operating_system_release):
8617 Move decls here, to check interfaces.
8618 * process.c (get_operating_system_release): Move decl to lisp.h.
8619 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
8620 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8621 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8622 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
8623 (Fformat_time_string, Fencode_time, Finsert_char):
8624 (Ftranslate_region_internal, Fformat):
8625 Rename or remove local vars to avoid shadowing.
9710023e 8626 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 8627
a415e694
PE
8628 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8629 avoid shadowing.
8630
8ef4622d
PE
8631 * lisp.h (eassert): Check that the argument compiles, even if
8632 ENABLE_CHECKING is not defined.
8633
946f9a5b
PE
8634 * data.c (Findirect_variable): Name an expression, to avoid
8635 gcc -Wbad-function-cast warning.
112396d6 8636 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 8637 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
8638 (Fmake_variable_buffer_local, Fmake_local_variable):
8639 Mark variables as initialized.
52746918 8640 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 8641
e5aab7e7 8642 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
8643 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8644 Rename locals to avoid shadowing.
dff45157
PE
8645 (mark_stack): Move local variables into the #ifdef region where
8646 they're used.
7bc26fdb
PE
8647 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8648 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8649 needed otherwise.
8650 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8651 (GC_STRING_CHARS): Remove; not used.
d40d4be1 8652 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 8653
e5aab7e7
PE
8654 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8655 avoids undefined behavior in theory.
8656
4da60324
PE
8657 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8658
88043301
PE
8659 Use functions, not macros, for up- and down-casing (Bug#8254).
8660 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8661 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8662 to use the following functions instead of these macros.
8663 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8664 EMACS_INT, since callers assume the returned value fits in int.
8665 (upcase1): Likewise, for UPCASE_TABLE.
8666 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 8667 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 8668 the race-condition problem in the old DOWNCASE.
88043301 8669
19ed5445
PE
8670 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8671 Rename locals to avoid shadowing.
8672 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
8673 (regex_compile, re_search_2, re_match_2_internal):
8674 Remove unused local vars.
952db0d7
PE
8675 (FREE_VAR): Rewrite so as not to use empty "else",
8676 which gcc can warn about.
da053e48 8677 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
8678 (RETALLOC_IF): Define only if needed.
8679 (WORDCHAR_P): Likewise. This one is never needed, but is used
8680 only in a comment talking about a compiler bug, so put inside
8681 the #if 0 of that comment.
8682 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8683 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8684 Remove; unused.
19ed5445 8685
1f3561e4 8686 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
8687 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8688 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 8689
ded6f8f7
PE
8690 * search.c (simple_search): Remove unused var.
8691
dbd37a95
PE
8692 * dired.c (compile_pattern): Move decl from here ...
8693 * lisp.h: ... to here, so that it can be checked.
8694 (struct re_registers): New forward decl.
8695
7e47afad
PE
8696 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8697
85f24f61
PE
8698 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8699 All uses changed.
8700 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8701 Rename locals to avoid shadowing.
5671df8f 8702 (Fvertical_motion): Mark locals as initialized.
85f24f61 8703
181aa2be 8704 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 8705 (casify_region): Mark local as initialized.
181aa2be 8706
930d429c
PE
8707 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8708
7082eac6
PE
8709 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8710 New macros, so that the caller can use some names other than
8711 gcpro1, gcpro2, etc.
8712 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8713 of the new macros.
8714 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8715 argument, for consistency with GCPRO2_VAR, etc: it is now the
8716 prefix of the variable, not the variable itself. All uses
8717 changed.
38b2c076
PE
8718 * dired.c (directory_files_internal, file_name_completion):
8719 Rename locals to avoid shadowing.
8720
15206ed9
PE
8721 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8722 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8723 dired.c's scmp function, had undefined behavior.
8724 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8725 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8726 * buffer.h: ... to here, because these macros use current_buffer,
8727 and the new implementation with inline functions needs to have
8728 current_buffer in scope now, rather than later when the macros
8729 are used.
8730 (downcase, upcase1): New static inline functions.
8731 (DOWNCASE, UPCASE1): Reimplement using these functions.
8732 This avoids undefined behavior in expressions like
8733 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8734 from race conditions in accessing the global variables
8735 case_temp1 and case_temp2.
8736 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8737 * lisp.h (case_temp1, case_temp2): Remove their decls.
8738 * character.h (ASCII_CHAR_P): Move from here ...
8739 * lisp.h: ... to here, so that the inline functions mentioned
8740 above can use them.
8741
4a6bea26
PE
8742 * dired.c (directory_files_internal_unwind): Now static.
8743
f14b7e14
PE
8744 * fileio.c (file_name_as_directory, directory_file_name):
8745 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8746 Now static.
2893f146
PE
8747 (file_name_as_directory): Use const pointers when appropriate.
8748 (Fexpand_file_name): Likewise. In particular, newdir might
8749 point at constant storage, so make it a const pointer.
fd4ead52 8750 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
8751 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8752 signedness issues.
f839df0c
PE
8753 (Fset_file_times, Finsert_file_contents, auto_save_error):
8754 Rename locals to avoid shadowing.
f14b7e14 8755
5716756e 8756 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
8757 (Ftry_completion, Fall_completions): Rename or remove locals
8758 to avoid shadowing.
5716756e 8759
b4c3046a
PE
8760 * marker.c (bytepos_to_charpos): Remove; unused.
8761
b45db522
PE
8762 * lisp.h (verify_bytepos, count_markers): New decls,
8763 so that gcc does not warn that these functions aren't declared.
8764
85876d07
PE
8765 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8766 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 8767 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 8768 (copy_text): Remove unused local var.
85876d07 8769
03d78a21 8770 * filelock.c (within_one_second): Now static.
b3dd38ab 8771 (lock_file_1): Rename local to avoid shadowing.
03d78a21 8772
5df8f01b
PE
8773 * buffer.c (fix_overlays_before): Mark locals as initialized.
8774 (fix_start_end_in_overlays): Likewise. This function should be
8775 simplified by using pointers-to-pointers, but that's a different
8776 matter.
b1d876f1 8777 (switch_to_buffer_1): Now static.
8f54f30a
PE
8778 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8779 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 8780
a70072c9 8781 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 8782 Fix pointer signedness issue.
edced198
PE
8783 (sys_subshell): Mark local as volatile if checking for lint,
8784 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 8785 (MAXPATHLEN): Define only if needed.
a70072c9 8786
a0977c44
PE
8787 * process.c (serial_open, serial_configure): Move decls from here ...
8788 * systty.h: ... to here, so that they can be checked.
8789
a884fdcc
PE
8790 * fns.c (get_random, seed_random): Move extern decls from here ...
8791 * lisp.h: ... to here, so that they can be checked.
8792
604efe86 8793 * sysdep.c (reset_io): Now static.
b8950c94 8794 (wait_for_termination_signal): Remove; unused.
604efe86 8795
38fc62d9
PE
8796 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8797 (copy_keymap_item, append_key, push_text_char_description):
8798 Now static.
1004a21a 8799 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 8800 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
8801 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8802 (describe_map_tree):
8803 Rename locals to avoid shadowing.
38fc62d9 8804
2f2650da
PE
8805 * keyboard.c: Declare functions static if they are not used elsewhere.
8806 (echo_char, echo_dash, cmd_error, top_level_2):
8807 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
8808 (read_char, kbd_buffer_get_event, make_lispy_position):
8809 (make_lispy_event, make_lispy_movement, apply_modifiers):
8810 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8811 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8812 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 8813 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 8814 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 8815
a053e86c 8816 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
8817 (mark_kboards): Move decl here ...
8818 * alloc.c (mark_kboards): ... from here.
a053e86c 8819
4752793e
PE
8820 * lisp.h (force_auto_save_soon): New decl.
8821
74f10ca7 8822 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
8823 (DEFINE_DUMMY_FUNCTION): New macro.
8824 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8825 Use it.
c03cd23f
PE
8826 (main): Add casts to avoid warnings
8827 if GCC considers string literals to be constants.
74f10ca7 8828
022e70d4
PE
8829 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8830
59d6fe83
PE
8831 * dbusbind.c: Pointer signedness fixes.
8832 (xd_signature, xd_append_arg, xd_initialize):
8833 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8834 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8835 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8836 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8837
78320123
PE
8838 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8839 if GCC considers string literals to be constants.
49cebcca 8840 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 8841
35ac2a97
SM
88422011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8843
fb103ca9
SM
8844 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8845 (print_preprocess, print_object): New macro to fix last change.
8846
35ac2a97
SM
8847 * print.c (print_preprocess): Don't forget font objects.
8848
62973b41
JB
88492011-03-16 Juanma Barranquero <lekktu@gmail.com>
8850
8851 * emacs.c (USAGE3): Doc fixes.
8852
0e48bb22
AS
88532011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8854
8855 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8856 structure.
8857
7684e57b
JB
88582011-03-14 Juanma Barranquero <lekktu@gmail.com>
8859
8860 * lisp.h (VWindow_system, Qfile_name_history):
8861 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8862 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8863 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8864
8865 * w32select.c: Don't #include "keyboard.h".
c96bbc66 8866 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
8867
8868 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8869 * w32console.c (detect_input_pending, read_input_pending)
8870 (encode_terminal_code):
8871 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8872 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8873 (w32_system_caret_y, Qfile_name_history):
8874 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8875 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8876 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8877 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8878 * w32proc.c (Qlocal, report_file_error):
8879 * w32term.c (Vwindow_system, updating_frame):
8880 * w32uniscribe.c (initialized, uniscribe_font_driver):
8881 Remove unneeded extern declarations.
8882
2aa46d6c
CY
88832011-03-14 Chong Yidong <cyd@stupidchicken.com>
8884
c96bbc66 8885 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 8886
cffc6f3b
CY
88872011-03-13 Chong Yidong <cyd@stupidchicken.com>
8888
8889 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8890 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8891 These macros can no longer be used for assignment.
8892
44f230aa
SM
8893 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8894 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
8895 (record_buffer_markers, fetch_buffer_markers): New functions for
8896 recording and fetching special buffer markers.
8897 (set_buffer_internal_1, set_buffer_temp): Use them.
8898
8899 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8900
8901 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8902
8903 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8904 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8905
8906 * xdisp.c (hscroll_window_tree):
8907 (reconsider_clip_changes): Use PT instead of BUF_PT.
8908
d251f04b
EZ
89092011-03-13 Eli Zaretskii <eliz@gnu.org>
8910
8911 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8912 $(EMACS_ROOT)/lib/intprops.h.
8913
f0c77cd1
PE
89142011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8915
3eca4629
PE
8916 Fix more problems found by GCC 4.5.2's static checks.
8917
7c86ee98
PE
8918 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8919 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
8920 (xg_free_frame_widgets): Make it clear that a local variable is
8921 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
8922 (gdk_window_get_screen): Make it clear that this macro is needed
8923 only if USE_GTK_TOOLTIP.
1e5524e7
PE
8924 (int_gtk_range_get_value): New function, which avoids a diagnostic
8925 from gcc -Wbad-function-cast.
8926 (xg_set_toolkit_scroll_bar_thumb): Use it.
8927 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8928 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
8929 (get_utf8_string, xg_get_file_with_chooser):
8930 Rename locals to avoid shadowing.
8931 (create_dialog): Move locals to avoid shadowing.
7c86ee98 8932
41729b81
PE
8933 * xgselect.c (xg_select): Remove unused var.
8934
f0c77cd1
PE
8935 * image.c (four_corners_best): Mark locals as initialized.
8936 (gif_load): Initialize transparent_p to zero (Bug#8238).
8937 Mark another local as initialized.
ec6cf4c6 8938 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 8939
ce0ad53d 8940 * image.c (clear_image_cache): Now static.
d5d5a617 8941 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 8942 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
8943 (x_edge_detection): Remove unnecessary cast that
8944 gcc -Wbad-function-cast diagnoses.
2037898d 8945 (gif_load): Fix pointer signedness.
6ae141d6
PE
8946 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8947 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 8948
33383987 89492011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 8950
d32df629
PE
8951 Improve quality of tests for time stamp overflow.
8952 For example, without this patch (encode-time 0 0 0 1 1
8953 1152921504606846976) returns the obviously-bogus value (-948597
8954 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8955 reports time overflow. See
8956 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
8957 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8958 * editfns.c: Include limits.h and intprops.h.
8959 (TIME_T_MIN, TIME_T_MAX): New macros.
8960 (time_overflow): Move earlier, to before first use.
8961 (hi_time, lo_time): New functions, for an accurate test for
8962 out-of-range times.
8963 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8964 (Fget_internal_run_time): Don't assume time_t fits in int.
8965 (make_time): Use list2 instead of Fcons twice.
8966 (Fdecode_time): More accurate test for out-of-range times.
8967 (check_tm_member): New function.
8968 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
8969 (lisp_time_argument): Don't rely on undefined left-shift and
8970 right-shift behavior when checking for time stamp overflow.
8be6f318 8971
fe31d94c
PE
8972 * editfns.c (time_overflow): New function, refactoring common code.
8973 (Fformat_time_string, Fdecode_time, Fencode_time):
8974 (Fcurrent_time_string): Use it.
8975
8be6f318
PE
8976 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8977 * dired.c (make_time): Move to ...
8978 * editfns.c (make_time): ... here.
8979 * systime.h: Note the move.
8980
09d9db2c 89812011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 8982
126bc0dc
YM
8983 * fringe.c (update_window_fringes): Remove unused variables.
8984
c47cbdfd
YM
8985 * unexmacosx.c (copy_data_segment): Also copy __got section.
8986 (Bug#8223)
8987
7ac80be9
EZ
89882011-03-12 Eli Zaretskii <eliz@gnu.org>
8989
c96bbc66 8990 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
8991 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8992 Constify `char *' arguments and their references according to
8993 prototypes in tparam.h.
8994
ecb0f94d 8995 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 8996
7ac80be9
EZ
8997 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8998 Adapt all references accordingly.
8999
9000 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9001
ef1fd07e
TT
90022011-03-11 Tom Tromey <tromey@redhat.com>
9003
9004 * buffer.c (syms_of_buffer): Remove obsolete comment.
9005
7ef4b50c
EZ
90062011-03-11 Eli Zaretskii <eliz@gnu.org>
9007
9008 * termhooks.h (encode_terminal_code): Declare prototype.
9009
9010 * msdos.c (encode_terminal_code): Don't declare prototype.
9011
9012 * term.c (encode_terminal_code): Now external again, used by
9013 w32console.c and msdos.c.
9014
44f230aa
SM
9015 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9016 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 9017
4b1ec863 90182011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 9019
1714f52b 9020 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 9021
4b1ec863
PE
9022 * fringe.c (update_window_fringes): Mark locals as initialized
9023 (Bug#8227).
9024 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 9025
524c7aa6
PE
9026 * alloc.c (mark_fringe_data): Move decl from here ...
9027 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9028 to check its interface.
9029 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9030
a5c0af81 9031 * fontset.c (free_realized_fontset): Now static.
7519b8cd 9032 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 9033 (fontset_font): Mark local as initialized.
a9a06e0b 9034 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 9035
b4716021
PE
9036 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9037
811e9bac 9038 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 9039 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
9040 (x_own_selection, Fx_disown_selection_internal): Rename locals
9041 to avoid shadowing.
9042 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 9043
7e3ab302
PE
9044 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9045 so that the caller can use some name other than gcpro1.
9046 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
9047 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9048 (Fx_backspace_delete_keys_p):
9049 Use them to avoid shadowing, and rename vars to avoid shadowing.
9050 (x_decode_color, x_set_name, x_window): Now static.
6b437900 9051 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 9052 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
9053 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9054 Remove unused locals.
7e3ab302
PE
9055 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9056 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9057 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9058 macros.
f78faa98 9059
e2b13473
PE
9060 * xterm.h (x_mouse_leave): New decl.
9061
77f23912
PE
9062 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9063 Remove unused functions.
cdf4ba58
PE
9064 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9065 (x_calc_absolute_position): Now static.
7411c686 9066 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 9067 Don't declare local "event" unless it's used.
ed7bf3a5
PE
9068 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9069 unless they are used.
38d0b34a
PE
9070 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9071 (x_fatal_error_signal): Remove; not used.
a6067996
PE
9072 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9073 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9074 (x_error_catcher, x_connection_closed, x_error_handler):
9075 (x_error_quitter, xembed_send_message, x_iconify_frame):
9076 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 9077 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 9078 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 9079
44f230aa
SM
9080 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9081 Rename or move locals to avoid shadowing.
6b463e58 9082 (tty_defined_color, merge_face_heights): Now static.
5967d051 9083 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
9084 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9085 does not deduce is never used uninitialized.
73719eba
PE
9086 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9087 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 9088
426994c3 9089 * terminal.c (store_terminal_param): Now static.
5489860b 9090
032f1620 9091 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 9092 (set_frame_menubar): Remove unused local.
d4323972 9093 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
9094 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9095 since they might point to immutable storage.
281585b0
PE
9096 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9097 since it's unused otherwise.
032f1620 9098
367c19e5 9099 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 9100 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
9101 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9102 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 9103 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
9104 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9105 does not deduce are never used uninitialized.
70739cbe 9106
07b48fa9
PE
9107 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9108
8868a238 9109 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
9110 * window.c (window_loop, size_window):
9111 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 9112
7e5cf297 9113 * window.c (display_buffer): Now static.
d6550a9f
PE
9114 (size_window): Mark variables that gcc -Wuninitialized
9115 does not deduce are never used uninitialized.
a586633d
PE
9116 * window.h (check_all_windows): New decl, to forestall
9117 gcc -Wmissing-prototypes diagnostic.
5b555da1 9118 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 9119
f6095868
PE
9120 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9121 shadowing.
9122 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
9123 Include <limits.h>.
9124 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9125 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
9126 (load_charset_map): Mark variables that gcc -Wuninitialized
9127 does not deduce are never used uninitialized.
53df7c11 9128 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 9129
f38b440c
PE
9130 * coding.c (coding_set_source, coding_set_destination):
9131 Use "else { /* comment */ }" rather than "else /* comment */;"
9132 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
9133 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9134 a block, when the outer 'i' will do.
9135 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9136 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9137 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9138 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9139 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9140 Rename locals to avoid shadowing.
9141 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
9142 * coding.c (emacs_mule_char, encode_invocation_designation):
9143 Now static, since they're not used elsewhere.
413bb2db 9144 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 9145 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
9146 (decode_coding_emacs_mule): Mark variables that gcc
9147 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
9148 (detect_coding_iso_2022): Initialize a local variable that might
9149 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 9150 this initialization is needed. (Bug#8211)
5f58e762
PE
9151 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9152 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9153 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9154 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9155 Remove unused macros.
f38b440c 9156
232b38b9 9157 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 9158 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 9159 * character.c (string_count_byte8): Likewise.
232b38b9 9160
fb90da1b
PE
9161 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9162 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9163
fb93dbc2
PE
9164 * chartab.c (copy_sub_char_table): Now static, since it's not used
9165 elsewhere.
5c156ace
PE
9166 (sub_char_table_ref_and_range, char_table_ref_and_range):
9167 Rename locals to avoid shadowing.
bbcd0949 9168 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 9169
7d3b3862 9170 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 9171 (BIDI_BOB): Remove unused macro.
7d3b3862 9172
6be7d3da
PE
9173 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9174 deduce are never used uninitialized.
c2ed9c8b 9175 * term.c (encode_terminal_code): Likewise.
6be7d3da 9176
75f8807f 9177 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 9178
50938595
PE
9179 * tparam.h: New file.
9180 * term.c, tparam.h: Include it.
9181 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9182 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9183 Move these decls to tparam.h, and make them agree with what
9184 is actually in tparam.c. The previous trick of using incompatible
9185 decls in different modules does not conform to the C standard.
9186 All callers of tparam changed to use tparam's actual API.
9187 * tparam.c (tparam1, tparam, tgoto):
9188 Use const pointers where appropriate.
9189
fbceeba2
PE
9190 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9191 * cm.h (struct cm): Likewise.
9192 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9193 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9194 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9195 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9196 (turn_on_face, init_tty): Likewise.
9197 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 9198
7f3f1250
PE
9199 * term.c (term_mouse_position): Rename local to avoid shadowing.
9200
e6ca6543
PE
9201 * alloc.c (mark_ttys): Move decl from here ...
9202 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9203
c40f8d15
AS
92042011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9205
9206 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9207
cfe0661d
JB
92082011-03-09 Juanma Barranquero <lekktu@gmail.com>
9209
9210 * search.c (compile_pattern_1): Remove argument regp, unused since
9211 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9212 (compile_pattern): Don't pass it.
9213
0afb4571
J
92142011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9215
9216 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9217 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9218 for ! HAVE_GTK3.
9219 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9220
9221 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9222
9223 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9224 gdk_window_get_screen, gdk_window_get_geometry,
9225 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9226 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9227 (xg_get_pixbuf_from_pixmap): New function.
9228 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9229 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9230 Call xg_get_pixbuf_from_pixmap instead of
9231 gdk_pixbuf_get_from_drawable.
9232 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9233 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9234 (xg_check_special_colors): Use GtkStyleContext and its functions
9235 for HAVE_GTK3.
9236 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9237 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9238 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
9239 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9240 Call gtk_widget_get_preferred_size.
0afb4571
J
9241 (xg_frame_resized): gdk_window_get_geometry only takes 5
9242 parameters.
44f230aa
SM
9243 (xg_win_to_widget, xg_event_is_for_menubar):
9244 Call gdk_x11_window_lookup_for_display.
0afb4571
J
9245 (xg_set_widget_bg): New function.
9246 (delete_cb): New function.
895009e1 9247 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 9248 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
9249 (xg_set_background_color): Call xg_set_widget_bg.
9250 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9251 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9252 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9253 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9254 if ! HAVE_GTK3.
9255 (update_frame_tool_bar): Call gtk_widget_hide.
9256 (xg_initialize): Use GDK_KEY_g.
9257
9258 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9259 if ! HAVE_GTK3
9260 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9261
9262 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9263 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9264 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9265
1c2cc4ef
JB
92662011-03-08 Juanma Barranquero <lekktu@gmail.com>
9267
9268 * w32xfns.c (select_palette): Check success of RealizePalette against
9269 GDI_ERROR, not zero.
9270
33383987 9271See ChangeLog.11 for earlier changes.
aac0c6e3
MR
9272
9273;; Local Variables:
9274;; coding: utf-8
aac0c6e3
MR
9275;; End:
9276
acaf905b 9277 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
9278
9279 This file is part of GNU Emacs.
9280
9281 GNU Emacs is free software: you can redistribute it and/or modify
9282 it under the terms of the GNU General Public License as published by
9283 the Free Software Foundation, either version 3 of the License, or
9284 (at your option) any later version.
9285
9286 GNU Emacs is distributed in the hope that it will be useful,
9287 but WITHOUT ANY WARRANTY; without even the implied warranty of
9288 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9289 GNU General Public License for more details.
9290
9291 You should have received a copy of the GNU General Public License
9292 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.