Fix bug #11073 with bidi-related crashes displaying some byte sequences.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
e99a9b8b
EZ
12012-03-23 Eli Zaretskii <eliz@gnu.org>
2
3 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
4 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
5 when fetching a multibyte character consumes more bytes than
6 CHAR_BYTES returns, due to unification of CJK characters in
7 string_char. (Bug#11073)
8
5063c0e1
TN
92012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
10
11 * process.c (wait_reading_process_output): Handle pty disconnect
12 by refraining from sending oneself a SIGCHLD (bug#10933).
13
9f851fbd
CY
142012-03-22 Chong Yidong <cyd@gnu.org>
15
16 * dispextern.h (struct it): New member string_from_prefix_prop_p.
17
5063c0e1 18 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
19 Mark string as coming from a prefix property.
20 (handle_face_prop): Use default face for prefix strings (Bug#4281).
21 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
22
fb5b8aca
CY
232012-03-21 Chong Yidong <cyd@gnu.org>
24
25 * xfaces.c (Vface_remapping_alist): Doc fix.
26
62356a1b
EZ
272012-03-20 Eli Zaretskii <eliz@gnu.org>
28
29 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
30 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
31 Doc fixes.
62356a1b 32
025de85b
CY
332012-03-20 Chong Yidong <cyd@gnu.org>
34
35 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
36 to reflect default non-nil value of redisplay-dont-pause.
37
4827f94e
KH
382012-03-19 Kenichi Handa <handa@m17n.org>
39
40 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
41 it fit in a valid range (Bug#11003).
42
e50a24a2
EZ
432012-03-18 Eli Zaretskii <eliz@gnu.org>
44
45 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
46 that is not from display property, accept the row as a "cursor
47 row" if one of the string's character has a non-nil `cursor'
48 property. Fixes cursor positioning when there are newlines in
49 overlay strings, e.g. in icomplete.el. (Bug#11035)
50
9af5ed87
PE
512012-03-12 Paul Eggert <eggert@cs.ucla.edu>
52
53 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
54
d1f55f16
CY
552012-03-12 Chong Yidong <cyd@gnu.org>
56
57 * eval.c (inhibit_lisp_code): Rename from
58 inhibit_window_configuration_change_hook; move from window.c.
59
60 * xfns.c (unwind_create_frame_1, Fx_create_frame):
61 * window.c (run_window_configuration_change_hook)
62 (syms_of_window): Callers changed.
63
66c5eebd
CY
642012-03-11 Chong Yidong <cyd@gnu.org>
65
413df973
CY
66 * keymap.c (Fkey_description): Doc fix (Bug#9700).
67
66c5eebd
CY
68 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
69
1de11f56
CY
702012-03-10 Chong Yidong <cyd@gnu.org>
71
72 * frame.c (other_visible_frames): Don't assume the selected frame
73 is visible (Bug#10955).
74
cae07000
SM
752012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
76
77 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
78
89c94350
JD
792012-03-08 Jan Djärv <jan.h.d@swipnet.se>
80
81 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
82 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
83 zero (Bug#10954).
84
999dd333
GM
852012-03-03 Glenn Morris <rgm@gnu.org>
86
01a6dcc8 87 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 88
de0100f2
EZ
892012-03-02 Eli Zaretskii <eliz@gnu.org>
90
91 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
92 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
93 (redisplay_window, next_element_from_string): Fix typos in
94 comments.
3e441275
EZ
95 (redisplay_window): Pass to move_it_vertically the margin in
96 pixels, not in screen lines.
de0100f2 97
96a72ee9
GM
982012-03-02 Glenn Morris <rgm@gnu.org>
99
100 * buffer.c (buffer-list-update-hook): Doc fix.
101
312508d7
EZ
1022012-02-29 Eli Zaretskii <eliz@gnu.org>
103
104 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
105 push_it before setting up the iterator for the first overlay
106 string, even if we have an empty string loaded.
107 (next_overlay_string): If there's an empty string on the iterator
108 stack, pop the stack. (Bug#10903)
109
27f3c637
PE
1102012-02-25 Paul Eggert <eggert@cs.ucla.edu>
111
112 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
113 Suggested by Stefan Monnier in
114 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
115 * alloc.c (widen_to_Lisp_Object): New static function.
116 (mark_memory): Also mark Lisp_Objects by fetching pointer words
117 and widening them to Lisp_Objects. This would work even if
118 USE_LSB_TAG is defined and wide integers are used, which might
119 happen in a future version of Emacs.
120
3c9dfce6
CY
1212012-02-25 Chong Yidong <cyd@gnu.org>
122
fa74b241
CY
123 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
124 Doc fix.
125
3c9dfce6
CY
126 * xselect.c (Fx_selection_exists_p): Doc fix.
127 (x_clipboard_manager_save_all): Print an informative message
128 before saving to clipboard manager.
129
9486df08
CY
1302012-02-24 Chong Yidong <cyd@gnu.org>
131
132 * keyboard.c (process_special_events): Handle all X selection
133 requests in kbd_buffer, not just the next one (Bug#8869).
134
f01d3321
CY
1352012-02-23 Chong Yidong <cyd@gnu.org>
136
137 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
138 call when setting menu-bar-lines and tool-bar-lines parameters.
139 (unwind_create_frame_1): New helper function.
140
141 * window.c (inhibit_window_configuration_change_hook): New var.
142 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 143 (syms_of_window): Initialize it.
f01d3321 144
86b847b6
CY
1452012-02-22 Chong Yidong <cyd@gnu.org>
146
147 * xterm.c (x_draw_image_relief): Add missing type check for
148 Vtool_bar_button_margin (Bug#10743).
149
a59225b1
CY
1502012-02-21 Chong Yidong <cyd@gnu.org>
151
152 * fileio.c (Vfile_name_handler_alist): Doc fix.
153
154 * buffer.c (Fget_file_buffer): Protect against invalid file
155 handler return value.
156
310f5bd4
PE
1572012-02-20 Paul Eggert <eggert@cs.ucla.edu>
158
cb3a28cc
PE
159 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
160 when computing $valmask.
161
310f5bd4
PE
162 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
163 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
164 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
165 It's useless in that case, and it can cause problems on hosts
166 that allocate halves of EMACS_INT values separately.
167 Reported by Dan Horák. Diagnosed by Andreas Schwab in
168 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
169 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
170 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
171 it avoids undefined behavior on hosts where shifting right by more
172 than the word width has undefined behavior.
173
2375c96a
CY
1742012-02-19 Chong Yidong <cyd@gnu.org>
175
176 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
177 (Funhandled_file_name_directory, Ffile_name_as_directory)
178 (Fdirectory_file_name, Fexpand_file_name)
179 (Fsubstitute_in_file_name): Protect against invalid file handler
180 return values (Bug#10845).
181
3eb49e71
EZ
1822012-02-18 Eli Zaretskii <eliz@gnu.org>
183
184 * .gdbinit (pitx): Fix incorrect references to fields of the
185 iterator stack.
186
7b926f3f
CY
1872012-02-17 Chong Yidong <cyd@gnu.org>
188
189 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
190
11273115
PE
1912012-02-15 Paul Eggert <eggert@cs.ucla.edu>
192
193 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
194 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
195
c3a70e2b
CY
1962012-02-15 Chong Yidong <cyd@gnu.org>
197
198 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
199 marked as special. Also, starting docstrings with * is obsolete.
200
0ca43699
AS
2012012-02-13 Andreas Schwab <schwab@linux-m68k.org>
202
203 * gnutls.c (emacs_gnutls_write): Fix last change.
204
2e8f3c56
LI
2052012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
206
207 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
208 send_process.
209
af70074f
SM
2102012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
211
212 * keymap.c (Fsingle_key_description): Handle char ranges.
213
95986d52
CY
2142012-02-12 Chong Yidong <cyd@gnu.org>
215
afd83bd1
CY
216 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
217 as that creates a dangerous corner case.
218
95986d52
CY
219 * window.c (Fdelete_window_internal): Invalidate the mouse
220 highlight (Bug#9904).
221
bd7da63e
GM
2222012-02-12 Glenn Morris <rgm@gnu.org>
223
224 * xselect.c (Fx_own_selection_internal)
225 (Fx_get_selection_internal, Fx_disown_selection_internal)
226 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
227 * nsselect.m (Fx_own_selection_internal)
228 (Fx_disown_selection_internal, Fx_selection_exists_p)
229 (Fx_selection_owner_p, Fx_get_selection_internal):
230 Sync docs and argument specs with the xselect.c versions.
231
77abcbc2
LI
2322012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
233
234 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
235
90b671e2
EZ
2362012-02-11 Eli Zaretskii <eliz@gnu.org>
237
1c0ca0b7
EZ
238 * w32select.c (Fx_selection_exists_p): Sync doc string and
239 argument list with xselect.c. (Bug#10783)
240
241 * w16select.c (Fx_selection_exists_p): Sync doc string and
242 argument list with xselect.c. (Bug#10783)
90b671e2 243
49241268
GM
2442012-02-10 Glenn Morris <rgm@gnu.org>
245
246 * fns.c (Fsecure_hash): Doc fix.
247
f998bbe7 2482012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
249
250 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
251
0992bd9c
CY
2522012-02-07 Chong Yidong <cyd@gnu.org>
253
254 * buffer.c (Fbuffer_local_variables)
255 (buffer_lisp_local_variables): Handle unbound vars correctly;
256 don't let Qunbound leak into Lisp.
257
af008560
GM
2582012-02-07 Glenn Morris <rgm@gnu.org>
259
dd605cc4
GM
260 * image.c (Fimagemagick_types): Doc fix.
261
af008560
GM
262 * image.c (imagemagick-render-type): Change it from a lisp object
263 to an integer. Move the doc here from the lisp manual.
264 Treat all values not equal to 0 the same.
265
1449fa1d
CY
2662012-02-06 Chong Yidong <cyd@gnu.org>
267
268 * doc.c (store_function_docstring): Avoid applying docstring of
269 alias to base function (Bug#2603).
270
3723ec07
AS
2712012-02-04 Andreas Schwab <schwab@linux-m68k.org>
272
273 * .gdbinit (pp1, pv1): Remove redundant defines.
274 (pr): Use pp.
275
79c1cc1e
CY
2762012-02-04 Chong Yidong <cyd@gnu.org>
277
278 * nsterm.m: Declare a global (Bug#10694).
279
d7f29f8e
EZ
2802012-02-04 Eli Zaretskii <eliz@gnu.org>
281
cae07000
SM
282 * w32.c (get_emacs_configuration_options):
283 Include --enable-checking, if specified, in the return value.
d7f29f8e 284
3b95a6f9
MR
2852012-02-04 Martin Rudalics <rudalics@gmx.at>
286
287 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
288 after rounding frame sizes. (Bug#9723)
289
d6fa96a6
EZ
2902012-02-04 Eli Zaretskii <eliz@gnu.org>
291
292 * keyboard.c (adjust_point_for_property): Don't position point
293 before BEGV. (Bug#10696)
294
df0b2940
PE
2952012-02-03 Paul Eggert <eggert@cs.ucla.edu>
296
297 Handle overflow when computing char display width (Bug#9496).
298 * character.c (char_width): Return EMACS_INT, not int.
299 (char_width, c_string_width): Check for overflow when
300 computing the width; this is possible now that individual
301 characters can have unbounded width. Problem introduced
302 by merge from Emacs 23 on 2012-01-19.
303
6bee44d6
MA
3042012-02-02 Michael Albinus <michael.albinus@gmx.de>
305
306 * dbusbind.c (Fdbus_register_method): Mention the return value
307 :ignore in the docstring.
308
44f92739
GM
3092012-02-02 Glenn Morris <rgm@gnu.org>
310
1b9f60cc
GM
311 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
312
44f92739
GM
313 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
314 Unconditionally set to t. (Bug#10673)
315 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
316 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
317 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
318
c5d3843c
KH
3192012-02-02 Kenichi Handa <handa@m17n.org>
320
321 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
322 0, do not call append_composite_glyph.
323
159462d4 3242012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
325
326 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
327 NULL (Bug#6988).
328 (x_produce_glyphs): If the component of a composition is a null
329 string, set it->pixel_width to 1 to avoid zero-width glyph.
330
78cef877
EZ
3312012-02-01 Eli Zaretskii <eliz@gnu.org>
332
333 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
334 first 2 arguments are identical. This makes inserting large
335 output from a subprocess an order of magnitude faster on
336 MS-Windows, where all sbrk'ed memory is always contiguous.
337
97897668
GM
3382012-01-31 Glenn Morris <rgm@gnu.org>
339
340 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 341 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
342 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
343
31fd3586
GM
3442012-01-29 Glenn Morris <rgm@gnu.org>
345
346 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
347
0e24a8b2
CY
3482012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
349
350 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
351
cc0adcb0
CY
3522012-01-28 Chong Yidong <cyd@gnu.org>
353
354 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
355
acc28cb9
CY
3562012-01-26 Chong Yidong <cyd@gnu.org>
357
9c69cfb7
CY
358 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
359
acc28cb9
CY
360 * search.c (Fsearch_forward, Fsearch_backward): Document negative
361 repeat counts (Bug#10507).
362
48da7392
GM
3632012-01-26 Glenn Morris <rgm@gnu.org>
364
365 * lread.c (syms_of_lread): Doc fix.
366
14af5f7f
CY
3672012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
368
369 * coding.c (encode_designation_at_bol): Change return value to
370 EMACS_INT.
371
0b21c100
CY
3722012-01-25 Chong Yidong <cyd@gnu.org>
373
374 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
375
3c2907f7
CY
3762012-01-21 Chong Yidong <cyd@gnu.org>
377
378 * floatfns.c (Fcopysign): Make the second argument non-optional,
379 since nil is not allowed anyway.
380
959ad23f
AS
3812012-01-21 Andreas Schwab <schwab@linux-m68k.org>
382
383 * process.c (read_process_output): Use p instead of XPROCESS (proc).
384 (send_process): Likewise.
385
34a02f46
MR
3862012-01-19 Martin Rudalics <rudalics@gmx.at>
387
388 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
389 (Vwindow_persistent_parameters): Do not use Qstate.
390 Rewrite doc-strings.
34a02f46 391
1259009a 3922012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
393
394 * character.c (char_width): New function.
70d4fdf6
GM
395 (Fchar_width, c_string_width, lisp_string_width):
396 Use char_width (Bug#9496).
25ed9e61 397
6a6ee00d
MR
3982012-01-16 Martin Rudalics <rudalics@gmx.at>
399
400 * window.c (Vwindow_persistent_parameters): New variable.
401 (Fset_window_configuration, save_window_save): Handle persistent
402 window parameters.
403
c85efaf7
EZ
4042012-01-14 Eli Zaretskii <eliz@gnu.org>
405
406 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
407 thrashing the stack of the thread. (Bug#9087)
408
5944709e
PE
4092012-01-12 Paul Eggert <eggert@cs.ucla.edu>
410
411 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
412
e71f5d99
EZ
4132012-01-11 Eli Zaretskii <eliz@gnu.org>
414
415 * xdisp.c (rows_from_pos_range): Handle the case where the
416 highlight ends on a newline. (Bug#10464)
417 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
418 he end column for display of highlight that ends on a newline
419 before a R2L line.
420
ce316182
GM
4212012-01-11 Glenn Morris <rgm@gnu.org>
422
423 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
424 from load-path also when installation-directory is nil. (Bug#10208)
425
5b43da69
GM
4262012-01-10 Glenn Morris <rgm@gnu.org>
427
74cc8ff9
GM
428 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
429
7d8d6e4e
GM
430 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
431 Update template values to be closer to their typical values these days.
5b43da69 432
a0db8d43
EZ
4332012-01-09 Eli Zaretskii <eliz@gnu.org>
434
435 * xdisp.c (rows_from_pos_range): Accept additional argument
436 DISP_STRING, and accept any glyph in a row whose object is that
437 string as eligible for mouse highlight. Fixes mouse highlight of
438 display strings from overlays. (Bug#10464)
439
9a0115ab 4402012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 441
b9110d6a 442 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
443 * fileio.c (auto_saving_dir_umask): New static var.
444 (Fmake_directory_internal): Use it.
445 (do_auto_save_make_dir): Set it, instead of invoking chmod after
446 creating the directory. The old code temporarily assigns
447 too-generous permissions to the directory.
448 (do_auto_save_eh): Clear it.
b9110d6a 449 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
450 that the var is always cleared.
451
6c1bd3f3
EZ
4522012-01-07 Eli Zaretskii <eliz@gnu.org>
453
454 * search.c (scan_buffer): Pass character positions to
455 know_region_cache, not byte positions. (Bug#6540)
456
069d2b50
L
4572012-01-07 LynX <_LynX@bk.ru> (tiny change)
458
459 * w32.c (sys_rename): Report EXDEV when rename of a directory
460 fails because the target is on another logical disk. (Bug#10284)
461
75bf0d33
DB
4622012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
463
464 * xterm.c (x_embed_request_focus): New function.
465
466 * xterm.h: Add prototype.
467
468 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
469
1c6e5a32
GM
4702012-01-05 Glenn Morris <rgm@gnu.org>
471
472 * emacs.c (emacs_copyright): Update short copyright year to 2012.
473
651e947e
EZ
4742012-01-01 Eli Zaretskii <eliz@gnu.org>
475
476 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
477 Load gnutls_transport_set_lowat only if GnuTLS version is below
478 2.11.1.
479 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
480 GnuTLS versions below 2.11.1.
481
3778cdd8
AL
4822011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
483
484 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
485 to the doc string advising against its use for altering the way
486 windows are scrolled.
487
0e5317f7
KH
4882011-12-28 Kenichi Handa <handa@m17n.org>
489
490 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
491 coding-system ASCII compatible only when it does not produce BOM
492 on encoding (Bug#10383).
493
93d5ca1f
JD
4942011-12-26 Jan Djärv <jan.h.d@swipnet.se>
495
496 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
497 can scroll.
498 (create_and_show_popup_menu): Always use menu_position_func for
499 Gtk3 (Bug#10361).
500
ca22b785
AS
5012011-12-24 Andreas Schwab <schwab@linux-m68k.org>
502
503 * callint.c (Fcall_interactively): Don't truncate prompt string.
504
d048e1e6
EZ
5052011-12-23 Eli Zaretskii <eliz@gnu.org>
506
507 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
508 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 509 resumed from there (after widening). (Bug#10360)
d048e1e6 510
5ccaba1f
JD
5112011-12-22 Jan Djärv <jan.h.d@swipnet.se>
512
513 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
514
204ee57f
JD
5152011-12-21 Jan Djärv <jan.h.d@swipnet.se>
516
b81d40f0
JB
517 * nsterm.m (x_free_frame_resources):
518 Release f->output_data.ns->miniimage.
204ee57f
JD
519 (ns_index_color): Fix indentation. Do not retain
520 color_table->colors[i].
521
522 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
523 before returning.
524
525 * nsfns.m (x_set_background_color): Assign return value from
526 ns_index_color to face-background instead of NSColor*.
527 (ns_implicitly_set_icon_type): Fix indentation.
528 Change assignment in for loop to comparison.
529
530 * emacs.c (ns_pool): New variable.
531 (main): Assign ns_pool.
532 (Fkill_emacs): Call ns_release_autorelease_pool.
533
534 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
535 autorelease fdesc, release fdAttrs and tdict.
536 (ns_get_covering_families): Release charset.
537 (ns_findfonts): Release NSFontDescriptor created with new.
538 (ns_uni_to_glyphs): Fix indentation.
539 (setString): Release attrStr before assigning new value.
540
c803b2b7
JD
5412011-12-18 Jan Djärv <jan.h.d@swipnet.se>
542
678f4426
JD
543 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
544 and NS_IMPL_COCOA.
545 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
546 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
547
cd394be1 5482011-12-18 David Reitter <reitter@cmu.edu>
678f4426 549
5fecd5fc
JD
550 * nsterm.m (ns_term_init): Subscribe for notifications
551 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
552 to method trackingNotification in EmacsMenu.
553
554 * nsmenu.m (trackingMenu): New variable.
3771cb17 555 (trackingNotification): New method (from Aquamacs).
5fecd5fc 556 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 557 from Aquamacs (Bug#7030).
678f4426
JD
558
5592011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 560
c803b2b7
JD
561 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
562 (symbol_to_nsstring): Fix indentation.
563 (ns_symbol_to_pb): New function.
cae07000
SM
564 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
565 (Fns_rotate_cut_buffers_internal): Remove.
566 (Fns_store_selection_internal): Rename from
c803b2b7
JD
567 Fns_store_cut_buffer_internal.
568 (ns_get_foreign_selection, Fx_own_selection_internal)
569 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
570 (Fns_get_selection_internal, Fns_store_selection_internal):
571 Use ns_symbol_to_pb and check if return value is nil.
572 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
573 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
574 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
575 renamed to Sns_store_selection_internal.
576 (ns_handle_selection_request): Move code to Fx_own_selection_internal
577 and remove this function.
578 (ns_handle_selection_clear): Remove, never used.
579 (Fx_own_selection_internal): Move code from ns_handle_selection_request
580 here.
581
e1b01a3a
KB
5822011-12-17 Ken Brown <kbrown@cornell.edu>
583
584 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
585 GID is unknown (Bug#10257).
586
2adb6e85
PE
5872011-12-17 Paul Eggert <eggert@cs.ucla.edu>
588
589 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
590 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
591 which caused a build failure on GNU/Linux IA-64. This problem was
592 introduced by my 2011-10-07 patch.
593
d1d7b339
JL
5942011-12-15 Juri Linkov <juri@jurta.org>
595
596 * image.c (imagemagick_error): New function. (Bug#10112)
597 (imagemagick_load_image): Comment out `MagickSetResolution' call.
598 Use `imagemagick_error' where ImageMagick functions return
599 `MagickFalse'.
600 (Fimagemagick_types): Add `Fnreverse' to return the list in the
601 proper order.
602
100d5755
KH
6032011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
604
605 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
606 fill background (Bug#8992).
607
454592a6
MR
6082011-12-13 Martin Rudalics <rudalics@gmx.at>
609
610 * window.c (Vwindow_combination_resize)
611 (Vwindow_combination_limit): Use t instead of non-nil in
612 doc-strings.
61d4b438
MR
613 (Vrecenter_redisplay): Add first sentence of doc-string on
614 separate line.
53524d93 615 (Frecenter): Fix doc-string typo.
454592a6 616
3633e3aa
KH
6172011-12-11 Kenichi Handa <handa@m17n.org>
618
619 * coding.c (Funencodable_char_position): Pay attention to the
620 buffer text relocation (Bug#9389).
621
7b9d523a
JD
6222011-12-10 Jan Djärv <jan.h.d@swipnet.se>
623
624 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
625 gtk_init (Bug#10100).
626
b73189c6
EZ
6272011-12-10 Eli Zaretskii <eliz@gnu.org>
628
629 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
630 IT->string is nil. (Bug#10263)
631
f7dfe5d6
JD
6322011-12-10 Jan Djärv <jan.h.d@swipnet.se>
633
83faebb4
JD
634 * nsterm.h (x_free_frame_resources): Declare.
635
f7dfe5d6
JD
636 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
637 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
638
639 * nsterm.h (ns_get_defaults_value): Declare.
640
641 * nsterm.m (ns_default): Call ns_get_defaults_value.
642
7cd4e72c
EZ
6432011-12-09 Eli Zaretskii <eliz@gnu.org>
644
645 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
646 (Bug#10170)
647
b34d7317
YM
6482011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
649
650 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
651 that where the value of an _OBJC_* symbol points to is in the .bss
652 section (Bug#10240).
653
76470ad1
KH
6542011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
655
656 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 657 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 658
745fff94
KH
6592011-12-08 Kenichi Handa <handa@m17n.org>
660
661 * ftfont.c (get_adstyle_property): Fix previous change
662 (Bug#10233).
663
6e44397c
JB
6642011-12-07 Juanma Barranquero <lekktu@gmail.com>
665
666 * w32.c (init_environment): If no_site_lisp, remove site-lisp
667 dirs from the default value of EMACSLOADPATH (bug#10208).
668
7efa6272
GM
6692011-12-07 Glenn Morris <rgm@gnu.org>
670
671 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
672 installation and source directories as well. (Bug#10208)
673
f6fc4d87
CY
6742011-12-06 Chong Yidong <cyd@gnu.org>
675
676 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
677
2bf26180
GM
6782011-12-06 Glenn Morris <rgm@gnu.org>
679
680 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
681 as an error, not just -1. (Bug#10217)
682
3a6ad4f0
CY
6832011-12-05 Chong Yidong <cyd@gnu.org>
684
685 * keyboard.c (process_special_events): New function.
686 (swallow_events, Finput_pending_p): Use it (Bug#10195).
687
75a3b399
PE
6882011-12-05 Paul Eggert <eggert@cs.ucla.edu>
689
690 * coding.c (encode_designation_at_bol): Don't use uninitialized
691 local variable (Bug#9318).
692
c3c9e25e
KH
6932011-12-05 Kenichi Handa <handa@m17n.org>
694
695 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
696 return Qnil (Bug#8046, Bug#10193).
697
5eb05ea3
KH
6982011-12-05 Kenichi Handa <handa@m17n.org>
699
700 * coding.c (encode_designation_at_bol): New args charbuf_end and
701 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
702 (coding_set_source): Return how many bytes coding->source was
703 relocated.
704 (coding_set_destination): Return how many bytes
705 coding->destination was relocated.
706 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 707 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
708
7092011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
710
711 * coding.c (CODING_CHAR_CHARSET_P): New macro.
712 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
713 macro (Bug#9318).
714
7152011-12-05 Andreas Schwab <schwab@linux-m68k.org>
716
717 The following changes are to fix Bug#9318.
718
a79703f5 719 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
720 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
721 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 722 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 723
7dbda6df
JB
7242011-12-05 Juanma Barranquero <lekktu@gmail.com>
725
726 * lisp.h (process_quit_flag): Fix external declaration.
727
6d5eb5b0
SM
7282011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
729
730 Don't macro-inline non-performance-critical code.
731 * eval.c (process_quit_flag): New function.
732 * lisp.h (QUIT): Use it.
733
a0c3fad0
JD
7342011-12-04 Jan Djärv <jan.h.d@swipnet.se>
735
736 * nsfns.m (get_geometry_from_preferences): New function.
737 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
738
6c07aac2
AS
7392011-12-04 Andreas Schwab <schwab@linux-m68k.org>
740
741 * emacs.c (Qkill_emacs): Define.
742 (syms_of_emacs): Initialize it.
743 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
744 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
745 (quit_throw_to_read_char): Add parameter `from_signal'.
746 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
747 * lisp.h (QUIT): Call Fkill_emacs if requested.
748
c052ead4
JD
7492011-12-03 Jan Djärv <jan.h.d@swipnet.se>
750
751 * widget.c (update_wm_hints): Return if wmshell is null.
752 (widget_update_wm_size_hints): New function.
753
754 * widget.h (widget_update_wm_size_hints): Declare.
755
756 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
757 widget_update_wm_size_hints (Bug#10104).
758
9e49252b
EZ
7592011-12-03 Eli Zaretskii <eliz@gnu.org>
760
761 * xdisp.c (handle_invisible_prop): If the invisible text ends just
762 before a newline, prepare the bidi iterator for consuming the
763 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 764 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 765
02b16839
JL
7662011-12-02 Juri Linkov <juri@jurta.org>
767
768 * search.c (Fword_search_regexp): New Lisp function created from
769 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
770 (Fword_search_backward, Fword_search_forward)
771 (Fword_search_backward_lax, Fword_search_forward_lax):
772 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
773 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
774
0068070e
SM
7752011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
776
777 * fileio.c (Finsert_file_contents): Move after-change-function call
778 to before the "handled:" label, since all "goto handled" appear in
779 cases where the *-change-functions have already been properly called
780 (bug#10117).
781
3360a3fc
AS
7822011-12-01 Andreas Schwab <schwab@linux-m68k.org>
783
784 * keyboard.c (interrupt_signal): Don't call kill-emacs when
785 waiting for input. (Bug#10169)
786
73d6c093
EZ
7872011-11-30 Eli Zaretskii <eliz@gnu.org>
788
789 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
790 verifies glyph row's hash code--we have just reallocated the
791 glyphs, so their contents can be complete garbage. (Bug#10164)
792
febe6bea
JB
7932011-11-30 Juanma Barranquero <lekktu@gmail.com>
794
795 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
796
801a4313
EZ
7972011-11-30 Eli Zaretskii <eliz@gnu.org>
798
799 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
800 attributes are tested _before_ calling verify_row_hash, to protect
801 against GCC re-ordering of the tests. (Bug#10164)
802
2b56b87e
JD
8032011-11-29 Jan Djärv <jan.h.d@swipnet.se>
804
805 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
806
807 * xterm.c (handle_one_xevent): Only set async_visible and friends
808 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 809 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
810 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
811
dbf31225
PE
8122011-11-28 Paul Eggert <eggert@cs.ucla.edu>
813
814 Remove GCPRO-related macros that exist only to avoid shadowing locals.
815 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
816 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
817 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
818 All uses changed to use GCPRO1 etc.
819 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
820 Revert to old implementation (i.e., before 2011-03-11).
821
1305621b
YM
8222011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
823
824 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
825 of scroll runs so as to avoid assigning disabled bogus rows and
826 unnecessary graphics copy operations.
827
8c9afb46
EZ
8282011-11-27 Eli Zaretskii <eliz@gnu.org>
829
830 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
831 (snprintf) [_MSC_VER]: Redirect to _snprintf.
832 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
833 (malloc, free, realloc, calloc): Redirect to e_* only when
834 compiling Emacs.
835
836 * lisp.h (GCTYPEBITS): Move before first use.
837 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
838 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
839 this macro definition.
840
841 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
842 _MSC_VER.
843
54e9e3bf
JD
8442011-11-27 Jan Djärv <jan.h.d@swipnet.se>
845
6d5eb5b0
SM
846 * gtkutil.c (xg_create_frame_widgets):
847 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
848 present with Gtk+ 2.0.
849
83aca1cb
PE
8502011-11-26 Paul Eggert <eggert@cs.ucla.edu>
851
852 * fileio.c (Finsert_file_contents): Undo previous change; see
853 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
854
5b76caa4
PE
8552011-11-26 Paul Eggert <eggert@cs.ucla.edu>
856
857 Rename locals to avoid shadowing.
858 * fileio.c (Finsert_file_contents):
859 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
860 * process.c (wait_reading_process_output):
861 Rename inner 'proc' to 'p' to avoid shadowing.
862 Indent for consistency with usual Emacs style.
863
8c535114
EZ
8642011-11-25 Eli Zaretskii <eliz@gnu.org>
865
866 * xdisp.c (redisplay_window): If cursor row is not fully visible
867 after recentering, and scroll-conservatively is set to a large
868 number, scroll window by a few more lines to make the cursor fully
869 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
870 (start_display): Don't move to the next line if the display should
871 start at a newline that is part of a display vector or an overlay
872 string. (Bug#10119)
8c535114 873
fa4fdb5c
JL
8742011-11-24 Juri Linkov <juri@jurta.org>
875
876 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
877 after the `MagickPingImage' call. (Bug#10112)
878
90ec88df
CY
8792011-11-23 Chong Yidong <cyd@gnu.org>
880
881 * window.c (Fcoordinates_in_window_p): Accept only live windows.
882
56e2e794
MR
8832011-11-23 Martin Rudalics <rudalics@gmx.at>
884
885 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
886 making another buffer current. (Bug#10114)
887
b6e64c41
GM
8882011-11-23 Glenn Morris <rgm@gnu.org>
889
890 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
891
6b21de18
CY
8922011-11-23 Chong Yidong <cyd@gnu.org>
893
894 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
895 using it (Bug#5984).
896
b12cd789
EZ
8972011-11-22 Eli Zaretskii <eliz@gnu.org>
898
899 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
900 and header-lines, as they don't have one computed for them.
901 (Bug#10098)
902
903 * .gdbinit (prow): Make displayed values more self-explaining.
904 Add row's hash code.
905
261b6fd4
LMI
9062011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
907
908 * process.c (wait_reading_process_output): Fix asynchrounous
909 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 910 (wait_reading_process_output): Add comment and URL.
261b6fd4 911
e7cfd277
JD
9122011-11-21 Jan Djärv <jan.h.d@swipnet.se>
913
914 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
915
a9b9b7f5
CY
9162011-11-21 Chong Yidong <cyd@gnu.org>
917
918 * window.c (Fnext_window, Fprevious_window): Doc fix.
919
b0d15b4f
SM
9202011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
921
922 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
923
fe7a3057
JB
9242011-11-20 Juanma Barranquero <lekktu@gmail.com>
925
926 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
927
d2999b1a
MR
9282011-11-20 Martin Rudalics <rudalics@gmx.at>
929
930 * window.c (Fset_window_combination_limit): Rename argument
931 STATUS to LIMIT.
932 (Vwindow_combination_limit): Remove "status" from doc-string.
933
d5ff9cd0
AS
9342011-11-20 Andreas Schwab <schwab@linux-m68k.org>
935
936 * m/ibms390.h: Remove.
937 * m/ibms390x.h: Don't include "ibms390.h".
938
a5bb9bd3
SM
9392011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
940
941 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
942 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
943
cd1181db
JB
9442011-11-20 Juanma Barranquero <lekktu@gmail.com>
945
946 * casetab.c (Fset_case_table):
947 * charset.c (Fcharset_after): Fix typos.
948
615a3b8d 9492011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 950
17e845af
PE
951 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
952 Otherwise, valgrind does not work on some platforms.
953 Problem reported by Andreas Schwab in
6a0bf43d
PE
954 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
955 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
956 is set, removing the need for VIRT_ADDRESS_VARIES.
957 (PURE_P): Use a more-efficient implementation that needs just one
958 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
959 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
960 to 4 (xorl, subq, cmpq, setbe).
961 * alloc.c (pure): Always extern now, since that's the
962 VIRT_ADDR_VARIES behavior.
963 (PURE_POINTER_P): Use a single comparison, not two, for
964 consistency with the new puresize.h.
965 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
966 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
967 Remove VIRT_ADDR_VARIES no longer needed.
968
f8fe6f96
EZ
9692011-11-19 Eli Zaretskii <eliz@gnu.org>
970
971 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
972 (erase_phys_cursor, update_window_cursor, show_mouse_face)
973 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
974 behave as if the cursor position were at the window margin.
975
976 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
977 and the cursor position is out of bounds, behave as if the cursor
978 position were at the window margin. (Bug#10075)
979
df05a53c
CY
9802011-11-18 Chong Yidong <cyd@gnu.org>
981
982 * window.c (Fwindow_combination_limit): Make first argument
983 non-optional, since it is meaningless for live windows like the
984 selected window.
985
2071918e
DA
9862011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
987
988 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
989
b50a28de
SM
9902011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
991
992 * intervals.c: Fix grafting over the whole buffer (bug#10071).
993 (graft_intervals_into_buffer): Simplify.
994
015137db
EZ
9952011-11-18 Eli Zaretskii <eliz@gnu.org>
996
997 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
998 hash values of the two rows.
999 (copy_row_except_pointers): Preserve the used[] arrays and the
1000 hash values of the two rows. (Bug#10035)
68c95424 1001 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
1002
1003 * xdisp.c (row_hash): New function, body extracted from
1004 compute_line_metrics.
1005 (compute_line_metrics): Call row_hash, instead of computing the
1006 hash code inline.
1007
1008 * dispnew.c (verify_row_hash): Call row_hash for computing the
1009 hash code of a row, instead of duplicating code from xdisp.c.
1010
1011 * dispextern.h (row_hash): Add prototype.
1012
a2addb04
TH
10132011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1014
1015 * frame.c (delete_frame): Don't delete the terminal when the last
1016 X frame is closed if emacs is built with GTK toolkit.
1017
df85d315
JB
10182011-11-17 Juanma Barranquero <lekktu@gmail.com>
1019
1020 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1021
a0c2d0ae
MR
10222011-11-17 Martin Rudalics <rudalics@gmx.at>
1023
1024 * window.c (Vwindow_splits): Rename to
1025 Vwindow_combination_resize. Suggested by Juri Linkov.
1026 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1027 of Vwindow_splits.
1028
58179cce
JB
10292011-11-16 Juanma Barranquero <lekktu@gmail.com>
1030
7877f373
JB
1031 * nsfns.m (Fns_font_name):
1032 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 1033
b6f67890
MR
10342011-11-16 Martin Rudalics <rudalics@gmx.at>
1035
1036 * window.h (window): Rename slot "nest" to "combination_limit".
1037 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1038 (Fset_window_nest): Rename to Fset_window_combination_limit.
1039 (Vwindow_nest): Rename to Vwindow_combination_limit.
1040 (recombine_windows, make_parent_window, make_window)
1041 (Fsplit_window_internal, saved_window)
1042 (Fset_window_configuration, save_window_save): Rename all
1043 occurrences of window_nest to window_combination_limit.
1044
c7015153
JB
10452011-11-15 Juanma Barranquero <lekktu@gmail.com>
1046
1047 * image.c (imagemagick_load_image): Fix typo.
1048
322ad6ec
EZ
10492011-11-14 Eli Zaretskii <eliz@gnu.org>
1050
1051 * xdisp.c (display_line): Move the call to
1052 highlight_trailing_whitespace before the call to
1053 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
1054 faces of all the glyphs to compute ROW's hash value.
1055 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 1056
f067b8ec
JB
10572011-11-14 Juanma Barranquero <lekktu@gmail.com>
1058
1059 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1060 just return (bug#10044).
1061
1e5b2111
EZ
10622011-11-12 Eli Zaretskii <eliz@gnu.org>
1063
7ef3cbd5
EZ
1064 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1065 with user-defined heap size. Bump the default size of the temacs
1066 heap to 27MB, to avoid memory warning when running temacs.
1067 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1068
1e5b2111
EZ
1069 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1070 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
1071 (verify_row_hash) [XASSERTS]: New function.
1072 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1073 that the hash value of glyph rows is correct.
1e5b2111 1074
89d61221
MR
10752011-11-12 Martin Rudalics <rudalics@gmx.at>
1076
1077 * window.h (window): Remove splits slot.
1078 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1079 (Fdelete_other_windows_internal, make_parent_window)
1080 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1081 (Fset_window_configuration, save_window_save): Don't deal with
1082 split status of windows.
1083 (saved_window): Remove splits slot.
1084 (Vwindow_splits): Rewrite doc-string.
1085
97f18cc8
JD
10862011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1087
1088 * xfns.c (unwind_create_frame):
1089 * nsfns.m (unwind_create_frame):
1090 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1091 Vframe_list (Bug#9999).
1092
22a648b4
DA
10932011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1094
0b381c7e 1095 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 1096
659afede
KH
10972011-11-11 Kenichi Handa <handa@m17n.org>
1098
1099 * callproc.c (Fcall_process): Set the member dst_multibyte of
1100 process_coding.
1101
9ac0394b
KH
11022011-11-11 Johan Bockgård <bojohan@gnu.org>
1103
1104 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1105 avoid a crash (bug#9496).
1106
2fbdc249
CY
11072011-11-09 Chong Yidong <cyd@gnu.org>
1108
1109 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1110 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1111
ac6b1f81
PE
11122011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1113
1114 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1115
09db192c
PE
11162011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1117
1118 Avoid some portability problems by eschewing 'extern inline' functions.
1119 The trivial performance wins aren't worth the portability hassles; see
1120 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1121 et seq.
1122 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1123 (window_box_width, window_box_left, window_box_left_offset)
1124 (window_box_right, window_box_right_offset): Undo previous change,
1125 by removing the "extern"s.
1126 * intervals.c (adjust_intervals_for_insertion)
1127 (adjust_intervals_for_deletion): Undo previous change,
1128 making these static again.
1129 (offset_intervals, temp_set_point_both, temp_set_point)
1130 (copy_intervals_to_string): No longer inline.
1131 * xdisp.c (window_text_bottom_y, window_box_width)
1132 (window_box_height, window_box_left_offset)
1133 (window_box_right_offset, window_box_left, window_box_right)
1134 (window_box): No longer inline.
1135
105216ed
CY
11362011-11-08 Chong Yidong <cyd@gnu.org>
1137
1138 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
1139 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1140 Signal an error if not a live window.
105216ed
CY
1141 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1142 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1143
ae9e237f
JB
11442011-11-07 Juanma Barranquero <lekktu@gmail.com>
1145
1146 * lisp.h (syms_of_abbrev): Remove declaration.
1147 Reported by CHENG Gao <chenggao@royau.me>.
1148
c7aa8333
EZ
11492011-11-07 Eli Zaretskii <eliz@gnu.org>
1150
1151 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1152 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1153 of temacs in GUI mode.
1154
be7f5545
MR
11552011-11-07 Martin Rudalics <rudalics@gmx.at>
1156
1157 * window.h: Declare delete_all_child_windows instead of
1158 delete_all_subwindows.
1159 * window.c (Fwindow_nest, Fset_window_nest)
1160 (Fset_window_new_total, Fset_window_new_normal)
1161 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1162 (delete_all_subwindows): Rename to delete_all_child_windows.
1163 (Fdelete_other_windows_internal, Fset_window_configuration):
1164 Call delete_all_child_windows instead of delete_all_subwindows.
1165 * frame.c (delete_frame): Call delete_all_child_windows instead
1166 of delete_all_subwindows.
1167
ca78dc43
PE
11682011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1169
1170 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1171 This is also needed for porting to any host where GC_MARK_STACK is
1172 not GC_MAKE_GCPROS_NOOPS.
1173 (which_symbols): Use it.
1174
a0241d01
KH
11752011-11-07 Kenichi Handa <handa@m17n.org>
1176
1177 * coding.c (coding_set_destination): Check coding->src_pos only
1178 when coding->src_object is a buffer (bug#9910).
1179
1180 * process.c (send_process): Set the member src_multibyte of coding
1181 to 0 (bug#9911) when sending a unibyte text.
1182
1183 * callproc.c (Fcall_process): Set the member src_multibyte of
1184 process_coding to 0 (bug#9912).
1185
a64bfdfa 11862011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
1187
1188 * xmenu.c (cleanup_widget_value_tree): New function.
1189 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1190 calling free_menubar_widget_value_tree directly (Bug#9830).
1191
cb41b32a
PE
11922011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1193
1194 Fix some portability problems with 'inline'.
1195 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1196 (window_box_width, window_box_left, window_box_left_offset)
1197 (window_box_right, window_box_right_offset): Declare extern.
1198 Otherwise, these inline functions do not conform to C99 and
1199 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1200 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1201 * intervals.c (adjust_intervals_for_insertion)
1202 (adjust_intervals_for_deletion): Now extern, because otherwise the
1203 extern inline functions 'offset_intervals' couldn't refer to it.
1204 (static_offset_intervals): Remove.
1205 (offset_intervals): Rewrite using the old contents of
1206 static_offset_intervals. The old version didn't conform to C99
1207 because an extern inline function contained a reference to an
1208 identifier with static linkage.
1209
b7041366
AS
12102011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1211
1212 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1213 GC.
1214
88a37c4d
EZ
12152011-11-06 Eli Zaretskii <eliz@gnu.org>
1216
1217 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1218 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1219 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1220 return Qleft_to_right.
1221
49745b39
CY
12222011-11-06 Chong Yidong <cyd@gnu.org>
1223
1224 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1225 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1226 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1227 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1228 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1229 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1230 (Fwindow_vscroll): Doc fix.
1231 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1232 argument, since it makes no sense to pass a live window and for
1233 consistency with window-child.
1234
1f05cd82
CS
12352011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1236
1237 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1238 support MSVC.
1239
22610910
JR
12402011-11-05 Jason Rumney <jasonr@gnu.org>
1241
1242 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1243 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1244 fonts (Bug#6029).
1245 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1246 bitwise arithmetic preventing use of unicode-sip and non-truetype
1247 opentype fonts.
1248
a06776b2
EZ
12492011-11-05 Eli Zaretskii <eliz@gnu.org>
1250
3ad924ba
EZ
1251 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1252 "emacs"-only part.
1253
a06776b2
EZ
1254 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1255 initialization code to keep similarity to xfns.c after changes
1256 from 2011-11-05.
1257
c9e7db78
JD
12582011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1259
a97f8f3f
JD
1260 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1261 (unwind_create_frame): New function (Bug#9943).
1262 (Fx_create_frame): Restructure code to be more similar to the one in
1263 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1264 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1265 Move terminal->reference_count++ just before making the frame official
1266 (Bug#9943).
1267
1268 * nsterm.m (x_free_frame_resources): New function.
1269 (x_destroy_window): Move code to x_free_frame_resources.
1270
c9e7db78 1271 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
1272 (Fx_create_frame, x_create_tip_frame):
1273 Move terminal->reference_count++ just before making the frame
c9e7db78
JD
1274 official. Move initialization of image_cache_refcount and
1275 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1276
a6fc3b5c
EZ
12772011-11-05 Eli Zaretskii <eliz@gnu.org>
1278
1279 Support MSVC build with newer versions of Visual Studio.
1280 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1281 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1282 nt/gmake.defs.
1283
1284 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1285 which are not supported by MSVC.
1286 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1287 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1288 bitfields.
1289 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1290 types in bitfields.
1291 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1292
1293 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1294
58179cce 12952011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
1296
1297 Support MSVC build with newer versions of Visual Studio.
1298 * w32.c: Don't include w32api.h for MSVC.
1299 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1300
1301 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1302 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1303 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1304 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1305 e_* cousins.
1306 (alloca) [_MSC_VER]: Define to _alloca.
1307
1308 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1309
1310 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1311
a58c13ed
EZ
13122011-11-04 Eli Zaretskii <eliz@gnu.org>
1313
1314 * xdisp.c (note_mouse_highlight): If either of
1315 previous/next-single-property-change returns nil, treat that as
1316 the beginning or the end of the buffer. (Bug#9955)
1317
fe0b6370
JD
13182011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1319
a58c13ed 1320 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
1321 label is not null (Bug#9951).
1322 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1323 may be NULL.
1324
89bd5ee1
EZ
13252011-11-04 Eli Zaretskii <eliz@gnu.org>
1326
1327 * window.c (Fwindow_body_size): Mention in the doc string that the
1328 return value is in frame's canonical units. (Bug#9949)
1329
84c3edb9
EZ
13302011-11-03 Eli Zaretskii <eliz@gnu.org>
1331
4e2fb5c7
EZ
1332 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1333
84c3edb9 1334 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 1335 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 1336 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 1337
bc17a887
EZ
13382011-11-01 Eli Zaretskii <eliz@gnu.org>
1339
1340 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1341 Don't stop backward scan on the continuation glyph, even though
1342 its CHARPOS is positive.
6d5eb5b0
SM
1343 (mouse_face_from_buffer_pos, note_mouse_highlight):
1344 Rename cover_string to disp_string.
bc17a887 1345
4ee88440
MR
13462011-11-01 Martin Rudalics <rudalics@gmx.at>
1347
1348 * window.c (temp_output_buffer_show): Don't use
1349 Vtemp_buffer_show_specifiers.
1350 (Vtemp_buffer_show_specifiers): Remove unused variable.
1351
c2ff3c02
EZ
13522011-10-30 Eli Zaretskii <eliz@gnu.org>
1353
1354 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1355 past the beginning of the current glyph matrix.
1356
58179cce 13572011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
1358
1359 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1360 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1361 HAVE_GTK3 (Bug#9869).
b77a6a7f 1362
3b574623
JD
1363 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1364 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1365
b77a6a7f
JD
1366 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1367
1368 * xterm.c: Declare x_handle_net_wm_state to return int.
1369 (handle_one_xevent): Check if we are iconified but don't have
1370 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1371 (get_current_wm_state): Return non-zero if not hidden,
1372 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1373 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1374 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1375 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1376
196e41e4
PE
13772011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1378
1379 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1380 so that this new function doesn't get optimized away by a
1381 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1382
021f2e1a
AS
13832011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1384
1385 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1386
8b058d44
EZ
13872011-10-29 Eli Zaretskii <eliz@gnu.org>
1388
1389 Fix the `xbytecode' command.
1390 * .gdbinit (xprintbytestr): New command.
b50a28de 1391 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
1392 (xbytecode): Print the byte-code string as well.
1393
4452fb80
EZ
13942011-10-29 Kim Storm <storm@cua.dk>
1395
8b058d44
EZ
1396 * alloc.c (which_symbols): New function.
1397
21b72067
AS
13982011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1399
1400 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1401 line. (Bug#9903)
1402
83ed7b5c
GM
14032011-10-29 Glenn Morris <rgm@gnu.org>
1404
1405 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1406 Not clear what it was for, and it causes various bugs. (Bug#9839)
1407
5a7a728b
EZ
14082011-10-28 Eli Zaretskii <eliz@gnu.org>
1409
1410 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1411 possible random value that matches one of those tested as
1412 condition to clear the mouse face.
1413
d3d0842f
CY
14142011-10-28 Chong Yidong <cyd@gnu.org>
1415
1416 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1417
31b39d13
DN
14182011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1419
1420 * window.c (make_window): Initialize phys_cursor_on_p.
1421
9aba6043
SM
14222011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1423
1424 * lisp.h (struct Lisp_Symbol): Update comments.
1425
c20992f4
JB
14262011-10-28 Juanma Barranquero <lekktu@gmail.com>
1427
1428 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1429
db4f02f2
EZ
14302011-10-28 Eli Zaretskii <eliz@gnu.org>
1431
1432 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1433 <oslsachem@gmail.com> for helping to debug this.
1434
1435 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1436 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1437 (g_b_init_get_glyph_outline_w): New static variables.
1438 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1439 (GetGlyphOutlineW_Proc): New typedefs.
1440 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
1441 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1442 New functions.
1443 (w32font_open_internal, compute_metrics):
1444 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
1445 instead of calling the "wide" APIs directly.
1446
1447 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1448
1449 * w32.h (syms_of_w32font): Add prototype.
1450
87e68db4
JB
14512011-10-27 Juanma Barranquero <lekktu@gmail.com>
1452
1453 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1454 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1455 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1456 (Fmove_to_window_line): Doc fix.
1457
435c1d67
CY
14582011-10-27 Chong Yidong <cyd@gnu.org>
1459
1460 * process.c (make_process): Set gnutls_state to NULL.
1461
1462 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1463 non-NULL, regardless of GNUTLS_INITSTAGE.
1464 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1465 an error. Set process slots as soon as we allocate them.
1466
1467 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1468
9c6c6f49
CY
14692011-10-27 Chong Yidong <cyd@gnu.org>
1470
9aba6043
SM
1471 * gnutls.c (emacs_gnutls_deinit): New function.
1472 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
1473 (Fgnutls_deinit, Fgnutls_boot): Use it.
1474
1475 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1476 (deactivate_process): Call emacs_gnutls_deinit.
1477
657d08d3
JB
14782011-10-27 Juanma Barranquero <lekktu@gmail.com>
1479
1480 * image.c (x_create_x_image_and_pixmap):
1481 * w32.c (sys_rename, w32_delayed_load):
1482 * w32font.c (fill_in_logfont):
1483 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1484
5430d399
JB
14852011-10-26 Juanma Barranquero <lekktu@gmail.com>
1486
1487 * w32fns.c (w32_default_color_map): New function,
1488 extracted from Fw32_default_color_map.
a7ef684b 1489 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 1490
fe0055fa
PE
14912011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1492
1493 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1494
e6346438
SM
14952011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1496
1497 * keyboard.c (test_undefined): New function (bug#9751).
1498 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1499
e112cc37
ET
15002011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1501
1502 * sysdep.c (init_sys_modes): Fix the check for the controlling
1503 terminal (Bug#6649).
1504
7b5d6677
EZ
15052011-10-20 Eli Zaretskii <eliz@gnu.org>
1506
1507 * dispextern.h (struct bidi_it): New member next_en_type.
1508
1509 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1510 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1511 current character, check also for next_en_type being WEAK_EN.
1512 (bidi_resolve_weak): Don't enter the expensive loop if the current
1513 position is before next_en_pos. Record the bidi type of the first
1514 non-ET, non-BN character we find, in addition to its position.
1515 (bidi_level_of_next_char): Invalidate next_en_type when
1516 next_en_pos is over-stepped.
1517
7da0b018
PE
15182011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1519
1520 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1521 * editfns.c: Rewrite current-time-zone so that it invokes
1522 the equivalent of (format-time-string "%Z") to get the time zone name.
1523 This fixes a bug when the time zone name contains characters that
1524 need converting from the system time locale to Emacs internal format.
1525 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1526 that patch fixed format-time-string to do the conversion, but
1527 I forgot to fix current-time-zone.
1528 (format_time_string): New function, containing most of
1529 what Fformat_time_string used to contain.
1530 (Fformat_time_string): Rewrite in terms of format_time_string.
1531 This doesn't change this function's behavior.
1532 (current-time-zone): Rewrite to use format_time_string.
1533 This fixes the bug reported by Michael Schierl in
1534 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1535 Jason Rumney's 2007-06-07 change worked around this bug, but
1536 didn't fix it.
1537 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1538
8547b010
EZ
15392011-10-19 Eli Zaretskii <eliz@gnu.org>
1540
1541 * xdisp.c (start_display): If the character at POS is displayed
1542 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
1543 (try_window_reusing_current_matrix): If a line ends in a display
1544 vector or the next line starts in a display vector, continue
1545 redrawing the window even though the character position of
1546 start_row was reached.
8547b010
EZ
1547 (Bug#9771, part 2)
1548
4e948d15
CY
15492011-10-18 Chong Yidong <cyd@gnu.org>
1550
1551 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1552 with nobreak-char-display too.
1553
4787455f
EZ
15542011-10-18 Eli Zaretskii <eliz@gnu.org>
1555
1556 Fix part 3 of bug#9771.
1557 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1558 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1559 non-neutral characters if the current character is a paragraph
1560 separator (a.k.a. Newline). This avoids running the same
1561 expensive loop twice, once when we consume the preceding newline
1562 and the other time when the line actually needs to be displayed.
1563 Avoid the loop when we see neutrals on the base embedding level
1564 following a character whose directionality is the same as the
1565 paragraph's. This avoids running the expensive loop when a line
1566 ends in a long sequence of neutrals, like control characters.
1567 Add assertion against STRONG_AL type. Slightly rearrange code
1568 that determines the type of a neutral given the first non-neutral
1569 that follows it.
1570 (bidi_level_of_next_char): Set next_en_pos to zero when
1571 invalidating its info.
1572
2c91f553
EZ
15732011-10-17 Eli Zaretskii <eliz@gnu.org>
1574
1575 * xdisp.c (push_display_prop): Determine whether to record string
1576 or buffer position by IT->string, not by IT->method. Allow
1577 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
1578 (move_it_vertically_backward): Don't look for character position
1579 immediately after the newline when in a continuation line.
1580 (Bug#9771, part 1)
2c91f553 1581
c7b08b0d
MR
15822011-10-15 Martin Rudalics <rudalics@gmx.at>
1583
1584 * window.c (coordinates_in_window): Rewrite and delabelize
1585 vertical border check. (Bug#5357) (Bug#9618)
1586
6b02f655
SM
15872011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1588
1589 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1590 errors in XSetWindowBorder (bug#9310).
1591
81d40c92
DA
15922011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1593
1594 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1595 avoid crash when xmalloc overrun checking is enabled.
1596
d4172c3b
EZ
15972011-10-13 Eli Zaretskii <eliz@gnu.org>
1598
1599 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1600 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1601 cursor motion with <left> and <right> arrow keys.
1602
1603 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1604 some callers set that themselves.
1605
b00eea75
EZ
16062011-10-12 Eli Zaretskii <eliz@gnu.org>
1607
1608 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1609 display string and the previous row comes from the same string and
1610 is empty. (Bug#9739) (Bug#9738)
1611
8fe012c4
SM
16122011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1613
1614 * doc.c (get_doc_string): Encode file name (bug#9735).
1615
0074aef2
EZ
16162011-10-12 Eli Zaretskii <eliz@gnu.org>
1617
79beb178
EZ
1618 * bidi.c (bidi_level_of_next_char):
1619 * xdisp.c (get_visually_first_element): Remove old incorrect
1620 comments regarding the Unicode Line Separator character.
1621
0074aef2
EZ
1622 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1623
6e4b3fbe
DA
16242011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1625
1626 * alloc.c (Fgc_status): Do not access beyond zombies array
1627 boundary if nzombies > MAX_ZOMBIES.
1628 * alloc.c (dump_zombies): Add missing format specifier.
1629
0324f3af
PE
16302011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1631
b5525cac
PE
1632 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1633 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1634
0324f3af
PE
1635 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1636 Some packages use them to denote characters with modifiers.
1637
e9b5f888
AS
16382011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1639
1640 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1641 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1642 matching a pp-number. Rename parameter var to var1.
1643
127827c0
SM
16442011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1645
1646 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1647
c8fd3bd0
GM
16482011-10-08 Glenn Morris <rgm@gnu.org>
1649
1650 * callint.c (Fcall_interactively): Give a more explicit error for the
1651 'c' case with a non-character input. (Bug#8479)
1652
352ec8ff
EZ
16532011-10-08 Eli Zaretskii <eliz@gnu.org>
1654
03669ccb
EZ
1655 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1656 lines.
7061c986
EZ
1657 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1658 lines that are hscrolled on the left.
03669ccb 1659
352ec8ff
EZ
1660 * dispnew.c (buffer_posn_from_coords): Account for a possible
1661 presence of header-line. (Bug#4426)
1662
a66cfb1c
SM
16632011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1664
6b02f655
SM
1665 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1666 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 1667
7c5ee88e
PE
16682011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1669
1670 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1671 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1672 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1673 this makes Emacs dump core during garbage collection on rare
1674 occasions. sizeof is obviously inferior to offsetof here, so
1675 stick with offsetof.
1676 (GC_POINTER_ALIGNMENT): New macro.
1677 (mark_memory): Omit 3rd (offset) arg; caller changed.
1678 Don't assume EMACS_INT alignment is the same as pointer alignment.
1679
df1bbe5b
SM
16802011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1681
1682 * keyboard.c (read_key_sequence_remapped): New var.
1683 (read_key_sequence): Compute remapping in the right buffer.
1684 (command_loop_1): Use read_key_sequence's remapping directly.
1685
51553db6
SM
16862011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1687
32c1fffd
SM
1688 * dired.c (file_name_completion): Don't expand file name.
1689 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1690 before checking file name handler.
1691
51553db6
SM
1692 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1693 they've been requested explicitly (bug#9591).
1694
b6bd1599 16952011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
1696
1697 * keymap.c (Fsingle_key_description): Use make_specified_string
1698 instead of build_string to build string from push_key_description.
1699 (Bug#5193)
1700
f701dc2a
PE
17012011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1702
4222c55d
PE
1703 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1704 This fixes a Y2038 bug on 64-bit hosts.
1705 * buffer.c (reset_buffer):
1706 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1707 (Fclear_buffer_auto_save_failure):
1708 Use 0, not -1, to represent an unset failure time, since time_t
1709 might not be signed.
1710
f701dc2a
PE
1711 Remove dependency on glibc malloc internals.
1712 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1713 Move back here from lisp.h, but with their new implementations.
1714 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1715 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1716 * charset.c (charset_table_init): New static var.
1717 (syms_of_charset): Use it instead of xmalloc. This removes a
1718 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1719 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1720 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1721 Move back to alloc.c.
1722 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1723 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1724
9ceebf39
JD
17252011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1726
1727 * nsterm.m (windowDidResize): Call x_set_window_size only when
1728 ns_in_resize is true. Otherwise set pixelwidth/height and
1729 call change_frame_size (Bug#9628).
1730
cb993c58
PE
17312011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1732
3930c88b
PE
1733 Port --enable-checking=all to Fedora 14 x86-64.
1734 * charset.c (syms_of_charset): Also account for glibc malloc's
1735 internal overhead when calculating the initial malloc maximum.
1736
cb993c58
PE
1737 Port --enable-checking=all to Fedora 14 x86.
1738 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1739 Move to lisp.h.
1740 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1741 (overrun_check_realloc, overrun_check_free):
1742 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1743 That way, xmalloc returns a properly-aligned pointer even if
1744 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1745 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1746 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1747 into account when calculating the initial malloc maximum.
1748 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1749 Move here from alloc.c, so that charset.c can use it too.
1750 Properly align; the old code wasn't right for common 32-bit hosts
1751 when configured with --enable-checking=all.
1752 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1753 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1754
31bed486
EZ
17552011-09-29 Eli Zaretskii <eliz@gnu.org>
1756
04c70788 1757 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
1758 use EDOM.
1759
fbcaa2f3
EZ
17602011-09-28 Eli Zaretskii <eliz@gnu.org>
1761
1762 * xdisp.c (compute_display_string_end): If there's no display
1763 string at CHARPOS, return -1.
1764
1765 * bidi.c (bidi_fetch_char): When compute_display_string_end
1766 returns a negative value, treat the character as a normal
1767 character not covered by a display string. (Bug#9624)
1768
a239d4e9
JB
17692011-09-28 Juanma Barranquero <lekktu@gmail.com>
1770
1771 * lread.c (Fread_from_string): Fix typo in docstring.
1772
88652fd5
EZ
17732011-09-27 Eli Zaretskii <eliz@gnu.org>
1774
1775 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1776 newline, reseat the iterator instead of bidi-iterating there one
1777 character at a time. (Bug#9610)
32c1fffd
SM
1778 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1779 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 1780
ed497dd4
AS
17812011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1782
1783 * lread.c (readevalloop): Use correct code for NBSP.
1784 (read1): Likewise. (Bug#9608)
1785
b2bf61aa
MA
17862011-09-25 Michael Albinus <michael.albinus@gmx.de>
1787
1788 * dbusbind.c (Fdbus_register_signal): When service is not
1789 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1790
32bbb17c
GM
17912011-09-25 Glenn Morris <rgm@gnu.org>
1792
1793 * buffer.c (truncate-lines): Doc fix.
1794
94e0933e
CY
17952011-09-24 Chong Yidong <cyd@stupidchicken.com>
1796
1797 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1798 (Fset_window_next_buffers): Doc fix.
1799
cddde921
GM
18002011-09-24 Glenn Morris <rgm@gnu.org>
1801
1802 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1803
1260aef1
PE
18042011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1805
25b4bfa0
PE
1806 Fix minor problems found by static checking.
1807 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
1808 * indent.c (Fvertical_motion): Fix == vs = typo.
1809
e3cbd34b
EZ
18102011-09-24 Eli Zaretskii <eliz@gnu.org>
1811
a66cfb1c
SM
1812 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1813 Default value is now t. Doc fix.
6bf7006f 1814
e3cbd34b 1815 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 1816 logic when moving up, not only when moving down. Fix the
e3cbd34b 1817 confusing name and values of the it_overshoot_expected variable;
32c1fffd 1818 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
1819
1820 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1821 CHARPOS is covered by a display string which includes newlines.
1822 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1823 is covered by a display string with embedded newlines.
1824
a3de0cbd
MA
18252011-09-24 Michael Albinus <michael.albinus@gmx.de>
1826
1827 * dbusbind.c (Fdbus_register_signal): Add match rule to
1828 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
1829 (Fdbus_register_method, Vdbus_registered_objects_table):
1830 Fix docstring.
a3de0cbd 1831
b260039d
JM
18322011-09-24 Jim Meyering <meyering@redhat.com>
1833
32c1fffd 1834 do not ignore write error for any output size
b260039d
JM
1835 The previous change was incomplete.
1836 While it makes emacs --batch detect the vast majority of stdout
1837 write failures, errors were still ignored whenever the output size is
1838 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1839 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1840 && echo FAIL: ignored write error
1841 FAIL: ignored write error
1842 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1843 && echo FAIL: ignored write error
1844 FAIL: ignored write error
1845 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1846
8eca8a7c
AS
18472011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1848
1849 * emacs.c (Fkill_emacs): In noninteractive mode exit
1850 non-successfully if a write error occurred on stdout. (Bug#9574)
1851
3341db62
EZ
18522011-09-21 Eli Zaretskii <eliz@gnu.org>
1853
1854 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1855 the xassert test.
1856
1857 * dispextern.h (struct it): Update the comment documenting what
1858 can it->OBJECT be.
1859
8c203dbf
EZ
18602011-09-20 Eli Zaretskii <eliz@gnu.org>
1861
1862 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1863 a display string, extend search for cursor position to end of row.
1864 (find_row_edges): If the row ends in a newline from a display
1865 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1866 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
1867 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1868 non-empty line. Fixes confusing cursor motion with arrow keys at
1869 the beginning of a line that starts with whitespace.
8c203dbf 1870
a4824228
LMI
18712011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1872
1873 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1874 (bug#9493).
1875
33ed493b
CY
18762011-09-18 Chong Yidong <cyd@stupidchicken.com>
1877
1878 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1879 boolean (Bug#9154).
1880
56cd55c8
EZ
18812011-09-18 Eli Zaretskii <eliz@gnu.org>
1882
1883 * xdisp.c (display_line): Record maximum and minimum buffer
1884 positions even if no glyphs were produced (e.g., by a zero-width
1885 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1886 buffer positions that will be removed from the glyph row because
1887 they don't fit.
c02dcedf
EZ
1888 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1889 column is beyond frame width: don't subtract 1 "pixel" when
1890 computing width of the stretch.
3e62b7e0
EZ
1891 (reseat_at_next_visible_line_start): Undo the change made on
1892 2011-09-17 that saved paragraph information and restored it after
1893 the call to `reseat'. (Bug#9545)
56cd55c8 1894
5ed99d36 18952011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
1896
1897 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1898 and turn window cursor on if cleared (Bug#9415).
1899
5ed99d36 19002011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
1901
1902 * search.c (boyer_moore): Take unibyte characters from pattern
1903 literally. (Bug#9458)
1904
9bade7b2
EZ
19052011-09-18 Eli Zaretskii <eliz@gnu.org>
1906
1907 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1908
e5e9d610
PE
19092011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1910
87e4427a
PE
1911 Fix minor problem found by static checking.
1912 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1913 initialized, to pacify gcc -Wuninitialized.
1914
e5e9d610
PE
1915 * fileio.c: Report proper errno when syscall falls.
1916 (Finsert_file_contents): Save and restore errno,
1917 so that report_file_error outputs the correct diagnostic.
1918 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1919
a1674f0b
EZ
19202011-09-18 Eli Zaretskii <eliz@gnu.org>
1921
1922 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1923
fbfb6dd4
EZ
19242011-09-17 Eli Zaretskii <eliz@gnu.org>
1925
1926 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1927 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1928
bb187662
EZ
19292011-09-17 Eli Zaretskii <eliz@gnu.org>
1930
1137e8b8 1931 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 1932 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
1933
1934 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1935 (bidi_find_paragraph_start): Search back for paragraph beginning
1936 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1937 (bidi_move_to_visually_next): Only trigger paragraph-related
1938 computations when the last character is a newline or at EOB, not
1939 just any NEUTRAL_B. (Bug#9470)
1940
bb187662
EZ
1941 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1942 truncated lines if point is covered by a display string. (Bug#9524)
1943
2e621251
PE
19442011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1945
1946 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1947 (cons_to_x_long): New function.
1948 (lisp_data_to_selection_data): Use it. Correct the test for
1949 short-versus-long data; it was negated. Break out of vector
1950 loop, for efficiency, when a long datum is discovered.
1951
91a15bc6
SM
19522011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1953
1954 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1955
b41c3a35
EZ
19562011-09-16 Eli Zaretskii <eliz@gnu.org>
1957
1958 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1959 GCC PR/17406) by declaring this function with external scope.
1960
7812ba2d
PE
19612011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1962
1963 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1964 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1965
cf7edc2a
AS
19662011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1967
1968 * editfns.c (Fformat): Correctly handle text properties on "%%".
1969
bd01620e
EZ
19702011-09-15 Eli Zaretskii <eliz@gnu.org>
1971
1972 * xterm.c (x_draw_composite_glyph_string_foreground):
1973 * w32term.c (x_draw_composite_glyph_string_foreground):
1974 * term.c (encode_terminal_code):
1975 * composite.c (composition_update_it, get_composition_id):
1976 * xdisp.c (get_next_display_element)
1977 (fill_composite_glyph_string): Add comments about special meaning
1978 of TAB characters in a composition.
1979
a02719a3
PE
19802011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1981
1982 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
1983 This occurs when processing a multibyte format.
1984 Problem reported by Wolfgang Jenker.
a02719a3 1985
72589a3c
JB
19862011-09-15 Johan Bockgård <bojohan@gnu.org>
1987
1988 * xdisp.c (try_cursor_movement): Only check for exact match if
1989 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1990
1c14176c
PE
19912011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1992
1993 Remove unused external symbols.
1994 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1995 * xdisp.c (calc_pixel_width_or_height): Now static.
1996 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1997 * indent.c (check_display_width):
1998 * w32term.c: Fix comment to match code.
1999 * xterm.c, xterm.h (x_catching_errors): Remove.
2000
d2eea5b5
PE
20012011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2002
2003 * xselect.c: Use signed conversions more consistently (Bug#9498).
2004 (selection_data_to_lisp_data): Assume incoming selection data are
2005 signed integers, not unsigned. This is to be consistent with
2006 outgoing selection data, which was modified to use signed integers
2007 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2008 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2009 expects long, not unsigned long.
2010
46888499
EZ
20112011-09-14 Eli Zaretskii <eliz@gnu.org>
2012
2013 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2014 computation of loop end. Reported by Johan Bockgård
2015 <bojohan@gnu.org>.
2016
ef8ef9fb
CY
20172011-09-13 Chong Yidong <cyd@stupidchicken.com>
2018
2019 * frame.c (Fother_visible_frames_p): Function deleted.
2020
fa819fed
EZ
20212011-09-12 Eli Zaretskii <eliz@gnu.org>
2022
2023 * indent.c (compute_motion): Process display vector front to back
2024 rather than the other way around. (Bug#2496)
2025
2ba8e008
SM
20262011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2027
2028 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2029
20f53c69
CY
20302011-09-11 Chong Yidong <cyd@stupidchicken.com>
2031
2032 * minibuf.c (Fread_from_minibuffer): Doc fix.
2033
d562d7a4
EZ
20342011-09-11 Eli Zaretskii <eliz@gnu.org>
2035
2036 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2037 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2038
1c4d7f3d
LMI
20392011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2040
2041 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2042 value for non-existent files.
2043
b885bf36
EZ
20442011-09-11 Eli Zaretskii <eliz@gnu.org>
2045
2046 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2047 set its "size" to -1. This will set the modtime_size field of
2048 the corresponding buffer to -1, which is what
2049 verify-visited-file-modtime expects for files that do not exist.
2050 (Bug#9139)
2051
6612f0bf
PE
20522011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2053
2054 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2055 here ...
2056 * lisp.h: ... from here. push_key_description is no longer
2057 defined in keyboard.c, so its declaration should not be in
2058 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2059 logically belongs with push_key_description.
2060
dfb3f755
PE
20612011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2062
2063 * buffer.h: Include <sys/types.h> instead of <time.h>.
2064 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2065 Problem reported by Herbert J. Skuhra.
2066
3134906c
LMI
20672011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2068
2069 * xml.c (parse_region): Make the parsing work for
2070 non-comment-starting XML files again (bug#9144).
2071
8d903f4e
AS
20722011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2073
2074 * image.c (gif_load): Fix calculation of bottom and right corner.
2075 (Bug#9468)
2076
80ad64f4
EZ
20772011-09-10 Eli Zaretskii <eliz@gnu.org>
2078
2079 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2080 redisplay in small windows.
2081
208a048d
EZ
20822011-09-09 Eli Zaretskii <eliz@gnu.org>
2083
2084 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2085
9b1c252e
MR
20862011-09-08 Martin Rudalics <rudalics@gmx.at>
2087
2088 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2089 Operate on live windows only.
2090
2949f33b
JB
20912011-09-08 Juanma Barranquero <lekktu@gmail.com>
2092
2093 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2094
e08dcafd
EZ
20952011-09-07 Eli Zaretskii <eliz@gnu.org>
2096
2097 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2098 only under bidi iteration.
2099
115b96bd
JD
21002011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2101
2102 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2103
c8199d0f
PE
21042011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2105
2106 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2107 Without this fix, the command to link temacs failed due to an
2108 undefined symbol __builtin_isnan. This is because
2109 /usr/include/iso/math_c99.h #defines isnan(x) to
2110 __builtin_isnan(x), but the bundled gcc, which identifies itself
2111 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2112 a __builtin_isnan.
2113 * floatfns.c (isnan): #undef, and then #define to a clone of
2114 what's in data.c.
2115 (Fisnan): Always define, since it's always available now.
2116 (syms_of_floatfns): Always define isnan at the Lisp level.
2117
e39b275c 21182011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
2119
2120 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2121
b2db44d9 21222011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 2123
f4af5137 2124 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
2125 The previous code assumed that file offsets (off_t values) fit in
2126 EMACS_INT variables, which is not true on typical 32-bit hosts.
2127 The code messed up by falsely reporting buffer overflow in cases
2128 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2129 when "big" contains more than 2**29 bytes, even though this
2130 inserts just one byte and does not overflow the buffer.
2131 (Finsert_file_contents): Store file offsets as off_t
2132 values, not as EMACS_INT values. Check for overflow when
2133 converting between EMACS_INT and off_t. When checking for
2134 buffer overflow or for overlap, take the offsets into account.
2135 Don't use EMACS_INT for small values where int suffices.
2136 When checking for overlap, fix a typo: ZV was used where
2137 ZV_BYTE was intended.
2138 (Fwrite_region): Don't assume off_t fits into 'long'.
2139 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2140
ecfc0a49
MA
21412011-09-05 Michael Albinus <michael.albinus@gmx.de>
2142
2143 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2144
6511acf2 21452011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 2146
0999621a 2147 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
2148
2149 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 2150 (esprintf, exprintf, evxprintf): New functions.
62f19c19 2151 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 2152 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
2153 (modify_event_symbol): Do not assume that the length of
2154 name_alist_or_stem is safe to alloca and fits in int.
2155 (Fexecute_extended_command): Likewise for function name and binding.
2156 (Frecursion_depth): Wrap around reliably on integer overflow.
2157 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2158 since some callers pass EMACS_INT values.
2159 (Fsingle_key_description): Don't crash if symbol name contains more
2160 than MAX_ALLOCA bytes.
2161 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2162 (get_minibuffer): Arg is now EMACS_INT, not int.
2163 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 2164 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
2165 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2166
2be7d702
PE
2167 * dbusbind.c (signature_cat): New function.
2168 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
2169 Do not overrun buffer; instead, report string overflow.
2170
9d1df220
PE
2171 * dispnew.c (add_window_display_history): Don't overrun buffer.
2172 Truncate instead; this is OK since it's just a log.
2173
33ef5c64
PE
2174 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2175 even if the time zone offset is outlandishly large.
2176 Don't mishandle offset == INT_MIN.
2177
66c6fdd5
PE
2178 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2179 when creating daemon; the previous buffer-overflow check was incorrect.
2180
d749b01b
PE
2181 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2182 which has the guts of the old verror function.
2183
b5cd1905
PE
2184 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2185 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2186
6e1a67fb
PE
2187 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2188 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 2189 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 2190 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
2191 length of string rather than counting it via multiple sprintfs;
2192 that's simpler and more reliable.
c21721cc
PE
2193 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2194 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2195 sprintf, in case result does not fit in int.
2196
c57b67fc
PE
2197 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2198 (fontset_from_font): Print it.
2199
8a401434
PE
2200 * frame.c (tty_frame_count): Now printmax_t, not int.
2201 (make_terminal_frame, set_term_frame_name): Print it.
2202 (x_report_frame_params): In X, window IDs are unsigned long,
2203 not signed long, so print them as unsigned.
2204 (validate_x_resource_name): Check for implausibly long names,
2205 and don't assume name length fits in 'int'.
2206 (x_get_resource_string): Don't blindly alloca invocation name;
2207 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2208 not fit in int.
2209
6e1a67fb
PE
2210 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2211 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
2212 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2213
0df02bf3
PE
2214 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2215 Use esprintf, not sprintf, in case result does not fit in int.
2216
48e30793
PE
2217 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2218 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2219 it as a large positive number.
2220 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2221 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2222
a66ff6d8
PE
2223 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2224 in case result does not fit in int.
2225
aca216ff
PE
2226 * print.c (float_to_string): Detect width overflow more reliably.
2227 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2228 buffer overrun. Don't assume list length fits in 'int'. Treat
2229 print length of 0 as 0, not as infinity; to be consistent with other
2230 uses of print length in this function. Don't overflow print length
2231 index. Don't assume hash table size fits in 'long', or that
2232 vectorlike size fits in 'unsigned long'.
2233
31c286f7
PE
2234 * process.c (make_process): Use printmax_t, not int, to format
2235 process-name gensyms.
2236
55e5faa1
PE
2237 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2238
80f2e268
PE
2239 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2240 to avoid potential buffer overrun.
2241
670741ab
PE
2242 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2243 if X resource line is longer than 512 bytes.
2244
b7163a50
PE
2245 * xfns.c (x_window): Make sprintf buffer a bit bigger
2246 to avoid potential buffer overrun.
2247
ae58ff1f
PE
2248 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2249
c43c8a6a
PE
2250 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2251
3f8236f4
PE
22522011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2253
53e9fe90 2254 Integer overflow fixes for scrolling, etc.
6511acf2
PE
2255 Without these, Emacs silently mishandles large integers sometimes.
2256 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
2257 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2258
6511acf2
PE
2259 * xdisp.c (try_window_id): Check Emacs fixnum range before
2260 converting to 'int'.
806add1d 2261
6511acf2 2262 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
2263 Check that an Emacs fixnum is in range before assigning it to 'int'.
2264 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2265 values converted from Emacs fixnums.
2266 (Frecenter): Don't wrap around a line count if it is out of 'int'
2267 range; instead, treat it as an extreme value.
2268 (Fset_window_configuration, compare_window_configurations):
2269 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2270
6511acf2
PE
2271 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2272 that can exceed INT_MAX. Check that EMACS_INT value is in range
2273 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
2274 (match_limit): Don't assume that a fixnum can fit in 'int'.
2275
6511acf2 2276 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
2277 exceed INT_MAX.
2278
6511acf2 2279 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
2280 (Fvertical_motion): Don't wrap around LINES values that don't fit
2281 in 'int'. Instead, treat them as extreme values. This is good
2282 enough for windows, which can't have more than INT_MAX lines anyway.
2283
fcb901a7
LMI
22842011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2285
0f2f6b6d
LMI
2286 * Require libxml/parser.h to avoid compilation warning.
2287
fcb901a7
LMI
2288 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2289
2290 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2291 since this reportedly can destroy thread storage.
2292
6e20a0d4
CY
22932011-08-30 Chong Yidong <cyd@stupidchicken.com>
2294
2295 * syntax.c (find_defun_start): Update all cache variables if
2296 exiting early (Bug#9401).
2297
148ae00e
EZ
22982011-08-30 Eli Zaretskii <eliz@gnu.org>
2299
f6cfbd8f
EZ
2300 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2301
148ae00e
EZ
2302 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2303 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2304 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2305
2306 * term.c (tty_append_glyph): New function.
2307 (produce_stretch_glyph): Static function and its prototype deleted.
2308
a66cfb1c
SM
2309 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2310 Add prototypes.
148ae00e 2311
c4a07a4c
PE
23122011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2313
2314 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2315 when checking :margin (Bug#9390).
2316 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 2317 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
2318 so that the name doesn't mislead. All uses changed.
2319
6bc8cd65
JB
23202011-08-28 Johan Bockgård <bojohan@gnu.org>
2321
2322 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2323 set_tty_hooks.
2324
dca4927e
EZ
23252011-08-27 Eli Zaretskii <eliz@gnu.org>
2326
2327 * xdisp.c (move_it_to): Don't bail out early when reaching
2328 position beyond to_charpos, if we are scanning backwards.
2329 (move_it_vertically_backward): When DY == 0, make sure we get to
2330 the first character in the line after the newline.
2331
f2cad773
PE
23322011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2333
2334 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2335 (ccl_driver): Do not generate an out-of-range pointer.
2336 (Fccl_execute_on_string): Remove unnecessary check for
2337 integer overflow, noted by Stefan Monnier in
2338 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2339 Remove a FIXME that didn't need fixing.
2340 Simplify the newly-introduced buffer reallocation code.
2341
0cae2cdb
JB
23422011-08-27 Juanma Barranquero <lekktu@gmail.com>
2343
2344 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2345
5fc295a4 23462011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 2347
70c60eb2 2348 Integer and memory overflow issues (Bug#9196).
726e0ab1 2349
d31850da
PE
2350 * doc.c (get_doc_string): Rework so that
2351 get_doc_string_buffer_size is the actual buffer size, rather than
2352 being 1 less than the actual buffer size; this makes xpalloc more
2353 convenient.
2354
a69fbedb
PE
2355 * image.c (x_allocate_bitmap_record, cache_image):
2356 * xselect.c (Fx_register_dnd_atom):
2357 Simplify previous changes by using xpalloc.
2358
fe5c5d37
PE
2359 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2360 since either will do and ptrdiff_t is convenient with xpalloc.
2361
0065d054
PE
2362 * charset.c (charset_table_size)
2363 (struct charset_sort_data.priority): Now ptrdiff_t.
2364 (charset_compare): Don't overflow if priorities differ greatly.
2365 (Fsort_charsets): Don't assume list length fits in int.
2366 Check for size-calculation overflow when allocating sort data.
2367 (syms_of_charset): Allocate an initial charset table that is
2368 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2369
2370 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2371
2372 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2373 The actual value is always <= INT_MAX, and leaving it unsigned made
2374 overflow checking harder.
2375
2376 * dispextern.h (struct glyph_matrix.rows_allocated)
2377 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2378 with xpalloc. The values are still always <= INT_MAX.
2379
2380 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2381
2382 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2383 (SAFE_NALLOCA): New macro.
2384
2385 * region-cache.c (struct boundary.pos, find_cache_boundary)
2386 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2387 (set_cache_region, invalidate_region_cache)
2388 (revalidate_region_cache, know_region_cache, region_cache_forward)
2389 (region_cache_backward, pp_cache):
2390 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2391 so that ptrdiff_t * can be passed to xpalloc.
2392 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2393 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2394 (pp_cache): Don't assume cache_len fits in int.
2395 * region-cache.h: Adjust extern decls to match.
2396
2397 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2398 EMACS_INT, since either will do, for xpalloc.
2399
2400 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2401 (xnmalloc, xnrealloc, xpalloc): New functions.
2402
726e0ab1
PE
2403 * bidi.c (bidi_shelve_header_size): New constant.
2404 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2405 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2406
51f30bc5 2407 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
2408 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2409 (overlay_strings):
2410 Don't update size of array until after memory allocation succeeds,
2411 because xmalloc/xrealloc may not return.
0065d054
PE
2412 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2413 now that we have proper integer overflow checking.
2414 (record_overlay_string, overlay_strings): Catch overflows when
2415 calculating size of overlay_str_buf.
726e0ab1 2416
0065d054
PE
2417 * callproc.c (Fcall_process): Check for size overflow when
2418 calculating size of args2.
2419 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2420 Normally we prefer signed values, but sticking with ptrdiff_t would
2421 require adding more-complicated checks.
726e0ab1
PE
2422
2423 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2424 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2425 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 2426 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
2427
2428 * character.c (Fstring): Check for size-calculation overflow.
2429
2430 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2431 unnecessary integer overflow. Check for size overflow.
2432 (encode_coding_object): Don't update size until xmalloc succeeds.
2433
2434 * composite.c (get_composition_id): Check for overflow in glyph
2435 length calculations.
2436
2437 Integer and memory overflow fixes for display code.
2438 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2439 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2440 (scrolling_window): Check for overflow in size calculations.
2441 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2442 Don't assume glyph table len fits in int.
2443 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2444 (row_table_size): Now ptrdiff_t, not int.
2445 (scrolling_window): Avoid overflow in size calculations.
2446 Don't update size until allocation succeeds.
2447 * fns.c (concat): Check for overflow in size calculations.
2448 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2449 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2450 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2451
2452 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2453 (get_doc_string): Check for size calculation overflow.
2454 Don't update size until allocation succeeds.
2455 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2456 EMACS_INT, where ptrdiff_t will do.
2457 (Fsubstitute_command_keys): Check for string overflow.
2458
2459 * editfns.c (set_time_zone_rule): Don't assume environment length
2460 fits in int.
2461 (message_length): Now ptrdiff_t, not int.
2462 (Fmessage_box): Don't update size until allocation succeeds.
2463 Don't assume message length fits in int.
2464 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2465
0065d054
PE
2466 * emacs.c (main): Do not reallocate argv, since there is a null at
2467 the end that can be overwritten, and this way there's no need to
2468 worry about size-calculation overflow.
2469 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
2470
2471 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2472 alloc succeeds.
2473 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2474
2475 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2476 (x_set_scroll_bar_width, x_figure_window_size):
2477 Check for integer overflow.
2478 (x_set_alpha): Do not assume XINT fits in int.
2479
2480 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2481 This is for the members text_lines, text_cols, total_lines, total_cols,
2482 where the system imposes an 'int' limit.
2483
2484 * fringe.c (Fdefine_fringe_bitmap):
2485 Don't update size until alloc works.
2486
2487 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2488 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2489
2490 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2491 Check for size-calculation overflow.
2492 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2493 do, as we prefer signed integers.
2494 (id_to_widget.max_size, id_to_widget.used)
2495 (xg_store_widget_in_map, xg_remove_widget_from_map)
2496 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2497 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2498 Use and return ptrdiff_t, not int.
2499 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2500 * gtkutil.h: Change prototypes to match the above.
2501
2502 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2503 are duplicate now that they've been promoted to lisp.h.
2504 (x_allocate_bitmap_record, x_alloc_image_color)
2505 (make_image_cache, cache_image, xpm_load):
2506 Don't update size until alloc is done.
2507 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2508 (x_detect_edges):
3256efce 2509 Check for size calculation overflow.
726e0ab1
PE
2510 (ct_colors_allocated_max): New constant.
2511 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2512 overflow.
3256efce 2513
726e0ab1
PE
2514 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2515 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2516 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2517 Use ptrdiff_t, not int, to count maps.
2518 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
2519 calculations. Don't update size until allocation succeeds.
2520 Redo calculations to avoid overflow.
726e0ab1
PE
2521 * keyboard.h: Change prototypes to match the above.
2522
2523 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2524 to count maps.
2525 (current_minor_maps): Check for size calculation overflow.
2526 * keymap.h: Change prototypes to match the above.
2527
2528 * lread.c (read1, init_obarray): Don't update size until alloc done.
2529
2530 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2531 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2532
726e0ab1
PE
2533 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2534 Now ptrdiff_t, not int.
2535 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2536 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2537
2538 * process.c (Fnetwork_interface_list): Check for overflow
2539 in size calculation.
2540
2541 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2542
2543 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2544 overflow. Don't bother calling xmalloc when xrealloc will do.
2545
2546 * search.c (Freplace_match): Check for size calculation overflow.
2547 (Fset_match_data): Don't assume list lengths fit in 'int'.
2548
2549 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2550 for command line length. Do not attempt to address one before the
2551 beginning of an array, as that's not portable.
2552
2553 * term.c (max_frame_lines): Remove; unused.
2554 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2555 not int.
2556 (encode_terminal_code, calculate_costs): Check for size
2557 calculation overflow.
2558 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2559 table lengths and related sizes. Don't update size until alloc
2560 done. Redo calculations to avoid overflow.
2561 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2562
2563 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2564 subtracting pointers.
2565 (gobble_line): Check for overflow more carefully. Don't update size
2566 until alloc done.
2567
2568 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2569 Don't update size until alloc done.
2570 Redo size calculations to avoid overflow.
2571 Check for size calculation overflow.
0065d054 2572 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
2573
2574 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2575 Use ptrdiff_t, not int, for sizes.
2576 (store_mode_line_noprop_char): Don't update size until alloc done.
2577
0065d054
PE
2578 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2579 Use ptrdiff_t, not int, for sizes.
2580 (Finternal_make_lisp_face, cache_face):
2581 Check for size calculation overflow.
2582 (cache_face): Treat size calculation overflows as if they were
2583 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
2584
2585 * xfns.c (x_encode_text, x_set_name_internal)
2586 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2587 sizes, since they can exceed INT_MAX in size. Check for size
2588 calculation overflow.
2589
0065d054
PE
2590 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2591 (xg_select): Check for size calculation overflow.
726e0ab1
PE
2592 Don't update size until alloc done.
2593
0065d054 2594 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 2595 as sprintf is limited to int lengths.
1d526e2f 2596
252c5ee1
PE
2597 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2598 (X_LONG_MIN): New macros.
864d7ce7
PE
2599 Use them to make the following changes clearer.
2600 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2601 This change doesn't affect the value now, but it may help remind
2602 future maintainers not to raise the value too much later.
2603 (SELECTION_QUANTUM): Remove, replacing with ...
2604 (selection_quantum): ... new function, which avoids overflow.
2605 All uses changed.
2606 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2607 assumption that selection length fits in 'int'.
2608 (x_reply_selection_request, x_handle_selection_request)
2609 (x_get_window_property, receive_incremental_selection)
2610 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2611 (lisp_data_to_selection_data, clean_local_selection_data):
2612 Use ptrdiff_t, not int, to record length of selection.
2613 (x_reply_selection_request, x_get_window_property)
2614 (receive_incremental_selection, x_property_data_to_lisp):
2615 Redo calculations to avoid overflow.
2616 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 2617 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
2618 something.
2619 (x_get_window_property, receive_incremental_selection)
2620 (lisp_data_to_selection_data, x_property_data_to_lisp):
2621 Check for size-calculation overflow.
2622 (x_get_window_property, receive_incremental_selection)
2623 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2624 Don't store size until memory allocation succeeds.
2625 (x_get_window_property): Plug memory leak on memory exhaustion.
2626 Don't double-block input; malloc is safe here. Don't assume 2**34
2627 - 4 fits in unsigned long. Add an xassert to check
2628 XGetWindowProperty overflow. Be more careful about overflow
2629 calculations, and distinguish size from memory overflow better.
2630 (receive_incremental_selection): When tracing, don't assume
2631 unsigned int is less than INT_MAX.
2632 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2633 harmful) conversions of unsigned short to int.
2634 (lisp_data_to_selection_data): Don't assume that integers
2635 in the range -65535 through -1 fit in an X unsigned short.
2636 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2637 result parameters unless successful. Rely on cons_to_unsigned
2638 to report problems with elements; the old code wasn't right anyway.
2639 (x_check_property_data): Check for int overflow; we cannot use
2640 a wider type due to X limits.
2641 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2642
726e0ab1 2643 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 2644
0065d054
PE
2645 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2646 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
2647 (x_color_cells): Don't store size until memory allocation succeeds.
2648 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 2649 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
2650 (x_term_init): Don't assume length fits in int (sprintf is limited
2651 to int size).
bc18e09d 2652
ebfa62c0
PE
2653 Use ptrdiff_t for composition IDs.
2654 * character.c (lisp_string_width):
2655 * composite.c (composition_table_size, n_compositions)
2656 (get_composition_id, composition_gstring_from_id):
2657 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2658 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2659 * window.c (Frecenter):
2660 Use ptrdiff_t, not int, for composition IDs.
2661 * composite.c (get_composition_id): Check for integer overflow.
2662 * composite.h: Adjust prototypes to match the above changes.
2663
d3411f89
PE
2664 Use ptrdiff_t for hash table indexes.
2665 * category.c (hash_get_category_set):
2666 * ccl.c (ccl_driver):
2667 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2668 * coding.c (coding_system_charset_list, detect_coding_system):
2669 * coding.h (struct coding_system.id):
2670 * composite.c (get_composition_id, gstring_lookup_cache):
2671 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2672 * image.c (xpm_get_color_table_h):
2673 * lisp.h (hash_lookup, hash_put):
2674 * minibuf.c (Ftest_completion):
2675 Use ptrdiff_t for hash table indexes, not int (which is too
2676 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2677 32-bit --with-wide-int hosts).
2678
e097a6fa
PE
2679 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2680 Add a FIXME comment about memory leaks.
2681 (syms_of_charset): Don't assume xmalloc returns.
2682
5637687f
PE
2683 Don't assume that stated character widths fit in int.
2684 * character.c (Fchar_width, c_string_width, lisp_string_width):
2685 * character.h (CHAR_WIDTH):
2686 * indent.c (MULTIBYTE_BYTES_WIDTH):
2687 Use sanitize_char_width to avoid undefined and/or bad behavior
2688 with outlandish widths.
a66cfb1c 2689 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
2690 now that we have two such functions. All uses changed.
2691 (sanitize_char_width): New inline function.
2692
a2271ba2
PE
2693 Don't assume that tab-width fits in int.
2694 * character.h (sanitize_width): New inline function.
2695 (SANE_TAB_WIDTH): New macro.
2696 (ASCII_CHAR_WIDTH): Use it.
2697 * indent.c (sane_tab_width): Remove. All uses replaced by
2698 SANE_TAB_WIDTH (current_buffer).
2699 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2700
18c52557
PE
2701 * fileio.c: Integer overflow issues with file modes.
2702 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2703
caeeedc1
PE
2704 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2705 Remove unreachable code.
2706 (read_hex, load_charset_map_from_file): Check for integer overflow.
2707
6df6ae42 2708 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
2709 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2710 (x_send_scroll_bar_event): Likewise. Check that the size does not
2711 exceed limits imposed by XClientMessageEvent, as well as the usual
2712 ptrdiff_t and size_t limits.
2713
b13995db
PE
2714 * keyboard.c: Overflow, signedness and related fixes.
2715 (make_lispy_movement): Use same integer type in forward decl
2716 that is used in the definition.
2717 (read_key_sequence, keyremap_step):
2718 Change bufsize argument back to int, undoing my 2011-03-30 change.
2719 We prefer signed types, and int is wide enough here.
2720 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2721 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2722 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2723 length, not size_t. Use ptrdiff_t for index, not int.
2724 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2725 possibility of integer overflow.
2726
13464394
PE
2727 Overflow, signedness and related fixes for images.
2728
2729 * dispextern.h (struct it.stack[0].u.image.image_id)
2730 (struct_it.image_id, struct image.id, struct image_cache.size)
2731 (struct image_cache.used, struct image_cache.ref_count):
2732 * gtkutil.c (update_frame_tool_bar):
2733 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2734 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2735 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2736 * nsmenu.m (update_frame_tool_bar):
2737 * xdisp.c (calc_pixel_width_or_height):
2738 * xfns.c (image_cache_refcount):
2739 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2740 on typical 64-bit hosts.
2741
2742 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2743 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2744 Omit unnecessary casts to int.
2745 (parse_image_spec): Check that integers fall into 'int' range
2746 when the callers expect that.
2747 (image_ascent): Redo ascent calculation to avoid int overflow.
2748 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2749 (lookup_image): Remove unnecessary tests.
2750 (xbm_image_p): Locals are now of int, not EMACS_INT,
2751 since parse_image_check makes sure they fit into int.
2752 (png_load, gif_load, svg_load_image):
2753 Prefer int to unsigned where either will do.
2754 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
2755 old tiff_error_handler and tiff_warning_handler.
2756 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
2757 stack buffer overflows. It uses only the features of vsnprintf
2758 that are common to both POSIX and native Microsoft.
2759 (tiff_error_handler, tiff_warning_handler): Use it.
2760 (tiff_load, gif_load, imagemagick_load_image):
2761 Don't assume :index value fits in 'int'.
2762 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2763 (imagemagick_load_image): Check that crop parameters fit into
2764 the integer types that MagickCropImage accepts. Don't assume
2765 Vimagemagick_render_type has a nonnegative value. Don't assume
2766 size_t fits in 'long'.
2767 (gs_load): Use printmax_t to print the widest integers possible.
2768 Check for integer overflow when computing image height and width.
2769
c11821d4
EZ
27702011-08-26 Eli Zaretskii <eliz@gnu.org>
2771
2772 * xdisp.c (redisplay_window): Don't force window start if point
2773 will be invisible in the resulting window. (Bug#9324)
2774
0c95fcf7
EZ
27752011-08-25 Eli Zaretskii <eliz@gnu.org>
2776
2777 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2778 the display spec is of the form `(space ...)'.
2779 (handle_display_spec): Return the value returned by
2780 handle_single_display_spec, not just 1 or zero.
2781 (handle_single_display_spec): If the display spec is of the form
2782 `(space ...)', and specifies display in the text area, return 2
2783 rather than 1.
fee65a97 2784 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
2785 accurately, and prefer exact match for point under bidi.
2786 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
2787
2788 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2789 into disp_prop; all users changed.
2790
2791 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2792 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2793 for the text covered by the display property.
2794
e4ed06f1
CY
27952011-08-25 Chong Yidong <cyd@stupidchicken.com>
2796
2797 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2798 Change return value to nil.
2799 (Frecord_buffer): Delete unused function.
2800
f67cdd7f
EZ
28012011-08-24 Eli Zaretskii <eliz@gnu.org>
2802
5980d4c6
EZ
2803 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2804 buffers, return left-to-right.
8610fe8b
EZ
2805 (set_cursor_from_row): Consider candidate row a win if its glyph
2806 represents a newline and point is on that newline. Fixes cursor
2807 positioning on the newline at EOL of R2L text within L2R
2808 paragraph, and vice versa.
2809 (try_cursor_movement): Check continued rows, in addition to
2810 continuation rows. Fixes unwarranted scroll when point enters a
2811 continued line of R2L text within an L2R paragraph, or vice versa.
2812 (cursor_row_p): Consider the case of point being equal to
2813 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2814 from the end of a short line to the beginning of a continued line
2815 of R2L text within L2R paragraph.
2816 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2817 composed characters.
5980d4c6 2818
f67cdd7f
EZ
2819 * bidi.c (bidi_check_type): Use xassert.
2820 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2821 members.
2822
bca633fb
EZ
28232011-08-23 Eli Zaretskii <eliz@gnu.org>
2824
2825 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2826 a character.
2827
4a5885a7
CY
28282011-08-23 Chong Yidong <cyd@stupidchicken.com>
2829
2830 * nsfont.m (ns_otf_to_script): Fix typo.
2831
0902a04e
KH
28322011-08-22 Kenichi Handa <handa@m17n.org>
2833
2834 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2835 extra slot even if the purpose is char-code-property-table.
2836
1a2e6670
EZ
28372011-08-23 Eli Zaretskii <eliz@gnu.org>
2838
8ddde651
EZ
2839 * xdisp.c (redisplay_window): When computing centering_position,
2840 account for the height of the header line. (Bug#8874)
2841
425cc014
EZ
2842 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2843 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2844 candidate is selected by the mouse, and that candidate has a
2845 composed character under the mouse.
2846
1a2e6670
EZ
2847 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2848 coordinates reported by pos-visible-in-window-p for a composed
2849 character in column zero.
2850
8b76d6f8
SM
28512011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2852
2853 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2854
dac347dd
EZ
28552011-08-22 Eli Zaretskii <eliz@gnu.org>
2856
2857 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2858 consider it a hit if to_charpos is anywhere in the range of the
2859 composed buffer positions.
2860
e013fb34
CY
28612011-08-22 Chong Yidong <cyd@stupidchicken.com>
2862
2863 * image.c (gif_load): Don't assume that each subimage has the same
2864 dimensions as the base image. Handle disposal method that is
2865 "undefined" by the gif spec (Bug#9335).
2866
bd1ba3e8
CY
28672011-08-20 Chong Yidong <cyd@stupidchicken.com>
2868
2869 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 2870 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 2871
54a1215b
EZ
28722011-08-19 Eli Zaretskii <eliz@gnu.org>
2873
823564e5
EZ
2874 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2875 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2876 from an Org mode buffer to a Speedbar frame.
2877
54a1215b
EZ
2878 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2879 a composition, take its buffer position from IT->cmp_it.charpos.
2880 Fixes cursor positioning at the beginning of a line that begins
2881 with a composed character.
2882
9778ebcc
EZ
28832011-08-18 Eli Zaretskii <eliz@gnu.org>
2884
0be6ee06
EZ
2885 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2886 character bidirectional type, use STRONG_L instead. Fixes crashes
2887 in a buffer produced by `describe-categories'.
2888
9778ebcc
EZ
2889 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2890 members before the level stack, so they would be saved and
2891 restored when copying iterator state. Fixes incorrect reordering
2892 around TABs covered by display properties.
2893
156bffbe
AS
28942011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2895
6b02f655 2896 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 2897
72ad093b
CY
28982011-08-17 Chong Yidong <cyd@stupidchicken.com>
2899
2900 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
2901 (internal_condition_case_2, internal_condition_case_n):
2902 Remove unnecessary aborts (Bug#9081).
72ad093b 2903
35774242
EZ
29042011-08-17 Eli Zaretskii <eliz@gnu.org>
2905
2906 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2907 has no `load' handler, try opening the file locally. (Bug#9311)
2908
db76dd85
KB
29092011-08-16 Ken Brown <kbrown@cornell.edu>
2910
2911 * gmalloc.c: Expand comment.
2912
b215eee5
EZ
29132011-08-16 Eli Zaretskii <eliz@gnu.org>
2914
2915 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2916 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2917
a4579d33
KB
29182011-08-16 Ken Brown <kbrown@cornell.edu>
2919
2920 Fix memory allocation problems in Cygwin build (Bug#9273).
2921
2922 * unexcw.c ( __malloc_initialized): Declare external variable.
2923 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2924
8b76d6f8
SM
2925 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2926 New variables.
a4579d33
KB
2927 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2928 dumped emacs.
2929 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2930 in the static heap.
2931 [CYGWIN] (special_realloc): New function.
2932 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2933 requests to realloc storage in the static heap.
2934
3ebec551
PE
29352011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2936
2937 * bidi.c (bidi_initialize): Remove unused local.
2938
9fd8be00
EZ
29392011-08-15 Eli Zaretskii <eliz@gnu.org>
2940
6b02f655
SM
2941 * bidimirror.h:
2942 * biditype.h: Remove file.
2943 * makefile.w32-in ($(BLD)/bidi.$(O)):
2944 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
2945
2946 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2947
2948 * chartab.c: Improve commentary for the uniprop_table API.
2949
32413314
EZ
2950 * bidi.c (bidi_paragraph_init): Support zero value of
2951 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
2952 (bidi_initialize): Use uniprop_table instead of including
2953 biditype.h and bidimirror.h.
32413314 2954
9fd8be00
EZ
2955 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2956 coordinates of the iterator when restoring from ppos_it.
2957 (Bug#9296)
2958
5cf2b69b
KH
29592011-08-14 Kenichi Handa <handa@m17n.org>
2960
2961 * process.c (create_process): Call setup_process_coding_systems
72ad093b 2962 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 2963
daf17d00
EZ
29642011-08-14 Eli Zaretskii <eliz@gnu.org>
2965
2966 * xdisp.c (move_it_in_display_line_to): Don't invoke
2967 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2968 ppos_it. Fixes vertical cursor motion when line beginning is
2969 covered by an image. (Bug#9296)
2970
08e3161a
JD
29712011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2972
2973 * nsterm.h (ns_run_ascript): Declare.
2974 (NSAPP_DATA2_RUNASSCRIPT): Define.
2975
2976 * nsfns.m (as_script, as_result, as_status): New static variables.
2977 (ns_run_ascript): New function.
5e617bc2 2978 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
2979 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2980 the event loop. Get status from as_status (Bug#7276).
2981
2982 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2983 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2984 the event loop (Bug#7276).
2985
a3720aa2
AS
29862011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2987
2988 * gnutls.c (QCgnutls_bootprop_priority)
2989 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2990 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2991 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2992 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2993 (QCgnutls_bootprop_verify_hostname_error)
2994 (QCgnutls_bootprop_callbacks_verify): Rename from
2995 Qgnutls_bootprop_..., all uses changed.
2996
2997 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2998 uses changed.
2999
0a0d27fb
PE
30002011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3001
19d5c50c
PE
3002 * xfaces.c (Qframe_set_background_mode): Now static.
3003 * dispextern.h (Qframe_set_background_mode): Remove decl.
3004
0a0d27fb
PE
3005 * process.c (Fnetwork_interface_info): Declare local only if needed.
3006
377538cb
JD
30072011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3008
3009 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3010 (Fnetwork_interface_list): Allocate in increments of bytes instead
3011 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3012 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3013 sockaddr.
3014 (struct ifflag_def): notrailers is smart on OSX.
3015 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3016 Get hardware address with getifaddrs if available.
3017
08fff70c
EZ
30182011-08-12 Eli Zaretskii <eliz@gnu.org>
3019
3020 * xdisp.c (iterate_out_of_display_property): xassert that
3021 IT->position is set to within IT->object's boundaries. Break from
3022 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
3023 when IT->position is set up wrongly due to some bug.
3024 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
3025 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3026 entry. Force push_it to save on the stack the current
3027 buffer/string position, to be restored by pop_it. Fix flags in
3028 the iterator structure wrt the object coming from a display
3029 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3030 properties. (Bug#9284)
3031
7be1c708 30322011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 3033
7be1c708
CY
3034 * fontset.c (fontset_get_font_group): Add proper type checks.
3035 (Bug#9172)
aac0c6e3 3036
7be1c708 30372011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 3038
7be1c708
CY
3039 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3040 and LC_VERSION_MIN_MACOSX.
3041 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3042 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 3043
97bb72a6
EZ
30442011-08-08 Eli Zaretskii <eliz@gnu.org>
3045
3046 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
3047 no-display-properties-and-no-overlays under bidi display.
3048 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 3049 properties and overlays.
97bb72a6 3050
d5617611
CY
30512011-08-08 Chong Yidong <cyd@stupidchicken.com>
3052
37e11a63
CY
3053 * editfns.c (Fset_time_zone_rule): Document relationship with the
3054 setenv function.
3055
d5617611
CY
3056 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3057 the font entity extracted from the cache (Bug#8109).
3058
58872834
CY
30592011-08-07 Chong Yidong <cyd@stupidchicken.com>
3060
3061 * composite.c (autocmp_chars): Don't reset point. That is done by
3062 restore_point_unwind (Bug#5984).
3063
75bfc667
JL
30642011-08-07 Juri Linkov <juri@jurta.org>
3065
3066 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3067 to show the arg `TIME' instead of `TIMEVAL'.
3068
d1410150
EZ
30692011-08-06 Eli Zaretskii <eliz@gnu.org>
3070
3071 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3072 display property strides EOL and includes a newline, as in
3073 longlines-mode. (Bug#9254)
75b771e4
EZ
3074 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3075 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
3076
3077 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3078 is non-zero, even if the data buffer is NULL. Fixes a crash in
3079 vertical-motion with longlines-mode. (Bug#9254)
3080
35928349
EZ
30812011-08-05 Eli Zaretskii <eliz@gnu.org>
3082
ec7cc85b
EZ
3083 * bidi.c <bidi_cache_total_alloc>: Now static.
3084 (bidi_initialize): Initialize bidi_cache_total_alloc.
3085
8b76d6f8 3086 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
3087 cache. (Bug#9221)
3088
3089 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3090 amount allocated this far in `bidi_cache_total_alloc'.
3091 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3092 non-zero, only free the data buffer without restoring the cache
3093 contents. All callers changed.
3094
3095 * dispextern.h (bidi_unshelve_cache): Update prototype.
3096
3097 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3098 (move_it_in_display_line, move_it_to)
3099 (move_it_vertically_backward, move_it_by_lines): Replace the call
3100 to xfree to an equivalent call to bidi_unshelve_cache.
3101 (move_it_in_display_line_to): Fix logic of returning
412b6358 3102 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 3103
e2e2423b
EZ
31042011-08-05 Eli Zaretskii <eliz@gnu.org>
3105
3106 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3107 came from a string character with a `cursor' property. (Bug#9229)
3108
ae9e757a
JD
31092011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3110
3111 * Makefile.in (LIB_PTHREAD): New variable.
3112 (LIBES): Add LIB_PTHREAD (Bug#9216).
3113
3114 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3115 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3116
213bd7f2
AS
31172011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3118
6b02f655 3119 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 3120
99aaf75f
JD
31212011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3122
3123 * xterm.c (x_find_topmost_parent): New function.
3124 (x_set_frame_alpha): Find topmost parent window with
3125 x_find_topmost_parent and set the property there also (bug#9181).
3126 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3127
c74e9d86
PE
31282011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3129
3130 * callproc.c (Fcall_process): Avoid vfork clobbering
3131 the local vars buffer, coding_systems, current_dir.
3132
640c8776
SM
31332011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3134
3135 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3136
f26d0e4c
PE
31372011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3138
8a10d76c
PE
3139 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3140 so that it is not optimized away.
3141
f26d0e4c
PE
3142 * xdisp.c (compute_display_string_pos): Remove unused local.
3143
55439c61
EZ
31442011-08-02 Eli Zaretskii <eliz@gnu.org>
3145
3146 Fix slow cursor motion and scrolling in large buffers with
3147 selective display, like Org Mode buffers. (Bug#9218)
3148
3149 * dispextern.h (struct bidi_it): New member disp_prop_p.
3150
3151 * xdisp.c: Remove one-slot cache of display string positions.
3152 (compute_display_string_pos): Accept an additional argument
5e617bc2 3153 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
3154 for a display string or property. If found, set DISP_PROP_P
3155 non-zero.
3156
3157 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
3158 DISP_PROP_P, and pass it to compute_display_string_pos.
3159 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
3160 non-zero. All callers of bidi_fetch_char changed.
3161
fb33fa43
SM
31622011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3163
3164 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3165
b099e063
DM
31662010-12-03 Don March <don@ohspite.net>
3167
3168 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3169 last character M-[char] is translated to ESC [char] (bug#7541).
3170
5cc7f7af
KH
31712011-08-02 Kenichi Handa <handa@m17n.org>
3172
d0fffa3f 3173 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
3174
3175 * chartab.c (uniprop_table): Make it non-static.
3176
525d5e6e
EZ
31772011-08-01 Eli Zaretskii <eliz@gnu.org>
3178
3179 * xdisp.c (forward_to_next_line_start): Accept additional argument
3180 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3181 on the newline.
3182 (reseat_at_next_visible_line_start): Use the bidi iterator state
3183 returned by forward_to_next_line_start to restore the state of
3184 it->bidi_it after backing up to previous newline. (Bug#9212)
3185
31011111
AS
31862011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3187
3188 * regex.c (re_comp): Protoize.
3189 (re_exec): Fix return type.
3190 (regexec): Fix type of `ret'. (Bug#9203)
3191
476371c4
PE
31922011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3193
e5d76069
PE
3194 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3195 This is needed if max-image-size is a floating-point number.
3196
9a79b20c
AS
31972011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3198
3199 * print.c (print_object): Print empty symbol as ##.
3200
3201 * lread.c (read1): Read ## as empty symbol.
3202
d8c2fa78
AA
32032011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3204
3205 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3206 setting frame foreground color (Bug#9175).
3207 (x_set_background_color): Likewise.
3208
ffe57a7a
AA
3209 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3210 contents (Bug#9176).
3211 (EmacsTooltip -init): Remove bezels and add shadows to
3212 tooltip windows.
3213
bf3492a5
AA
3214 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3215 or scroll bar (Bug#8470).
3216
d55e9c53
AA
3217 * nsfont.m (nsfont_open): Remove assignment to voffset and
3218 unnecessary vars hshink, expand, hd, full_height, min_height.
3219 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3220
3221 * nsterm.h (nsfont_info): Remove voffset field.
3222
d8c2fa78 32232011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
3224
3225 Implement strike-through and overline on NextStep (Bug#8863).
3226
3227 * nsfont.m (nsfont_open): Use underline position provided by font,
3228 instead of hard-coded value of 2.
3229 (nsfont_draw): Call ns_draw_text_decoration instead.
3230
3231 * nsterm.h: Add declaration for ns_draw_text_decoration.
3232
3233 * nsterm.m (ns_draw_text_decoration): New function for drawing
3234 underline, overline, and strike-through.
3235 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3236 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 3237 accommodate underlining, etc.
4843aac3 3238
4cc60b9b
EZ
32392011-07-28 Eli Zaretskii <eliz@gnu.org>
3240
bc7ece87
EZ
3241 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3242 default.
4cc60b9b 3243
476371c4
PE
32442011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3245
66606eea
PE
3246 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3247 Without this fix, if a signal arrives just after memory fills up,
3248 'malloc' might be invoked reentrantly.
3249
476371c4
PE
3250 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3251 In other words, assume that every image size is allowed, on non-X
3252 hosts. This assumption is probably wrong, but it lets Emacs compile.
3253
f3fcc40d
AS
32542011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3255
3256 * regex.c (re_iswctype): Convert return values to boolean.
3257
350c992f
EZ
32582011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3259
3260 * xdisp.c (compute_display_string_pos): Don't use cached display
3261 string position if the buffer had its restriction changed.
3262 (Bug#9184)
3263
5266b4bb
PE
32642011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3265
3266 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3267
2573a837 32682011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 3269
41f55ccd 3270 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 3271
39e378da
PE
3272 * bidi.c: Integer size and overflow fixes.
3273 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3274 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3275 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3276 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3277 (bidi_find_other_level_edge):
3278 Use ptrdiff_t instead of EMACS_INT where either will do.
3279 This works better on 32-bit hosts configured --with-wide-int.
3280 (bidi_cache_ensure_space): Check for size-calculation overflow.
3281 Use % rather than repeated addition, for better worst-case speed.
3282 Don't set bidi_cache_size until after xrealloc returns, because it
3283 might not return.
3284 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
3285 (bidi_cache_ensure_space): Also check that the bidi cache size
3286 does not exceed that of the largest Lisp string or buffer. See Eli
3287 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 3288
5e927815
PE
3289 * alloc.c (__malloc_size_t): Remove.
3290 All uses replaced by size_t. See Andreas Schwab's note
3291 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3292
ca4aa935
PE
3293 * image.c: Improve checking for integer overflow.
3294 (check_image_size): Assume that f is nonnull, since
3295 it is always nonnull in practice. This is one less thing to
3296 worry about when checking for integer overflow later.
3297 (x_check_image_size): New function, which checks for integer
3298 overflow issues inside X.
3299 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3300 This removes the need for a memory_full check.
3301 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3302 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3303 (xbm_read_bitmap_data): Change locals back to 'int', since
3304 their values must fit in 'int'.
3305 (xpm_load_image, png_load, tiff_load):
3306 Invoke x_create_x_image_and_pixmap earlier,
3307 to avoid much needless work if the image is too large.
3308 (tiff_load): Treat overly large images as if
3309 x_create_x_image_and_pixmap failed, not as malloc failures.
3310 (gs_load): Use x_check_image_size.
3311
5f8f9cc2
PE
3312 * gtkutil.c: Omit integer casts.
3313 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3314 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3315
5adf60bc
PE
3316 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3317
c8907a93
PE
3318 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3319 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3320 would wrongly return t on a 64-bit host.
3321
e3c25c68
PE
3322 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3323 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3324 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3325 and therefore cause GCC to emit a bogus diagnostic in some cases.
3326
3f791afe
PE
3327 * image.c: Integer signedness and overflow and related fixes.
3328 This is not an exhaustive set of fixes, but it's time to
3329 record what I've got.
3330 (lookup_pixel_color, check_image_size): Remove redundant decls.
3331 (check_image_size): Don't assume that arbitrary EMACS_INT values
3332 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3333 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3334 (tiff_load, imagemagick_load_image):
3335 Check for overflow in size calculations.
3336 (x_create_x_image_and_pixmap): Remove unnecessary test for
3337 xmalloc returning NULL; that can't happen.
3338 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3339 (xpm_color_bucket): Use better integer hashing function.
3340 (xpm_cache_color): Don't possibly over-allocate memory.
3341 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3342 (gif_memory_source):
3343 Use ptrdiff_t, not int or size_t, to record sizes.
3344 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3345 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3346 either works, as we prefer signed integers.
3347 (tiff_read_from_memory, tiff_write_from_memory):
3348 Return tsize_t, not size_t, since that's what the TIFF API wants.
3349 (tiff_read_from_memory): Don't fail simply because the read would
3350 go past EOF; instead, return a short read.
3351 (tiff_load): Omit no-longer-needed casts.
3352 (Fimagemagick_types): Don't assume size fits into 'int'.
3353
3cc5a532
PE
3354 Improve hashing quality when configured --with-wide-int.
3355 * fns.c (hash_string): New function, taken from sxhash_string.
3356 Do not discard information about ASCII character case; this
3357 discarding is no longer needed.
3358 (sxhash-string): Use it. Change sig to match it. Caller changed.
3359 * lisp.h: Declare it.
3360 * lread.c (hash_string): Remove, since we now use fns.c's version.
3361 The fns.c version returns a wider integer if --with-wide-int is
3362 specified, so this should help the quality of the hashing a bit.
3363
b312a492
PE
3364 * emacs.c: Integer overflow minor fix.
3365 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3366 Define only if GNU_LINUX.
3367 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3368
dfd153ae
PE
3369 * dispnew.c: Integer signedness and overflow fixes.
3370 Remove unnecessary forward decls, that were a maintenance hassle.
3371 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3372 All uses changed.
3373 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3374 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3375 (prepare_desired_row, line_draw_cost):
3376 Use int, not unsigned, where either works.
3377 (save_current_matrix, restore_current_matrix):
3378 Use ptrdiff_t, not size_t, where either works.
3379 (init_display): Check for overflow more accurately, and without
3380 relying on undefined behavior.
3381
a81d11a3
PE
3382 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3383 Remove, replacing with the new symbols in lisp.h. All uses changed.
3384 * fileio.c (make_temp_name):
3385 * filelock.c (lock_file_1, lock_file):
3386 * xdisp.c (message_dolog):
3387 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3388 Use pMd etc. instead.
3389 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3390 replacing the pWIDE etc. symbols removed from editfns.c.
3391
3300e6fd
PE
3392 * keyboard.h (num_input_events): Now uintmax_t.
3393 This is (very slightly) less likely to mess up due to wraparound.
3394 All uses changed.
3395
fd05c7e9
PE
3396 * buffer.c: Integer signedness fixes.
3397 (alloc_buffer_text, enlarge_buffer_text):
3398 Use ptrdiff_t rather than size_t when either will do, as we prefer
3399 signed integers.
3400
903fe15d
PE
3401 * alloc.c: Integer signedness and overflow fixes.
3402 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3403 (__malloc_size_t): Default to size_t, not to int.
3404 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3405 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3406 Prefer ptrdiff_t to size_t when either would do, as we prefer
3407 signed integers.
3408 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3409 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3410 Now const. Initialize with values that are in range even if char
3411 is signed.
3412 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3413 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3414 These functions do the right thing with sizes > 2**32.
3415 (check_depth): Now ptrdiff_t, not int.
3416 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3417 Adjust to new way of storing sizes. Check for size overflow bugs
3418 in rest of code.
3419 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3420 slightly wrong anyway, as it missed one instance of
3421 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3422 (refill_memory_reserve): Omit needless cast to size_t.
3423 (mark_object_loop_halt): Mark as externally visible.
3424
ac82cc6a
PE
3425 * xselect.c: Integer signedness and overflow fixes.
3426 (Fx_register_dnd_atom, x_handle_dnd_message):
3427 Use ptrdiff_t, not size_t, since we prefer signed.
3428 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3429 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3430 x_dnd_atoms_size and x_dnd_atoms_length.
3431
c2d1e36d
PE
3432 * doprnt.c: Prefer signed to unsigned when either works.
3433 * eval.c (verror):
3434 * doprnt.c (doprnt):
3435 * lisp.h (doprnt):
3436 * xdisp.c (vmessage):
3437 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3438 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3439 prefer signed arithmetic to avoid comparison confusion.
3440 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3441 but is a bit tricky.
3442
0e926e56
PE
3443 Assume freestanding C89 headers, string.h, stdlib.h.
3444 * data.c, doprnt.c, floatfns.c, print.c:
3445 Include float.h unconditionally.
3446 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3447 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3448 * regex.c: Likewise for stddef.h, string.h.
3449 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3450 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3451 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3452 (STDC_HEADERS): Remove obsolete defines.
3453 * sysdep.c: Include limits.h unconditionally.
3454
9cfdb3ec
PE
3455 Assume support for memcmp, memcpy, memmove, memset.
3456 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3457 * regex.c (memcmp, memcpy):
3458 Remove; we assume C89 now.
3459
3460 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3461 (__malloc_safe_bcopy): Remove; no longer needed.
3462
cf950e6b 3463 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
3464 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3465 well either way, and we prefer signed to unsigned.
3466
dbf38e02
LMI
34672011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3468
3469 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3470 closes the connection while we're reading (bug#9182).
3471
d6f0886c 34722011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 3473
d6f0886c
JD
3474 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3475 are specified (Bug#9168).
24e0f6b1 3476
2eb1f9e6
PE
34772011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3478
3479 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3480 Found by GCC static checking and --with-wide-int on a 32-bit host.
3481
22381272 34822011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
3483
3484 * xdisp.c (compute_display_string_pos): Fix logic of caching
3485 previous display string position. Initialize cached_prev_pos to
3486 -1. Fixes slow-down at the beginning of a buffer.
3487
f25e39b4
EZ
34882011-07-24 Eli Zaretskii <eliz@gnu.org>
3489
3490 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3491 for attrs[LFACE_FONTSET_INDEX].
3492
04c4b52e
PE
34932011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3494
3495 * xml.c (parse_region): Remove unused local
3496 that was recently introduced.
3497
c1734fbd
EZ
34982011-07-23 Eli Zaretskii <eliz@gnu.org>
3499
be18c5a5
EZ
3500 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3501 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3502
c1734fbd
EZ
3503 * xdisp.c (move_it_in_display_line_to): Record the best matching
3504 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
3505 exit if none of the characters scanned was an exact match.
3506 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
3507 when exact match is impossible due to invisible text, and the
3508 lines are truncated.
3509
a258d627
JD
35102011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3511
3512 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3513 for OSX >= 10.7.
3514
b6d5a689
EZ
35152011-07-22 Eli Zaretskii <eliz@gnu.org>
3516
0f74f785
EZ
3517 Fix a significant slow-down of cursor motion with C-n, C-p,
3518 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3519 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 3520 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
3521 (next_element_from_buffer): Call compute_stop_pos_backwards to
3522 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
3523 base_level_stop.
3524 (reseat): Don't look for prev_stop, as that could mean a very long
3525 run.
3526 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3527 <cached_disp_overlay_modiff>: Cache for last found display string
3528 position.
551918c1 3529 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
3530 about the same buffer in the same area of character positions, and
3531 the buffer wasn't changed since the time the display string
3532 position was cached.
551918c1 3533
b2d0c91a
EZ
35342011-07-22 Eli Zaretskii <eliz@gnu.org>
3535
3536 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3537 is an integer, which is important for empty lines. (Bug#9149)
3538
043604ee
CY
35392011-07-22 Chong Yidong <cyd@stupidchicken.com>
3540
3541 * frame.c (Fmodify_frame_parameters): In tty case, update the
3542 default face if necessary (Bug#4238).
3543
da4adb04
CY
35442011-07-21 Chong Yidong <cyd@stupidchicken.com>
3545
3546 * editfns.c (Fstring_to_char): No need to explain what a character
3547 is in the docstring (Bug#6576).
3548
9abd0532
LMI
35492011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3550
3551 * xml.c (parse_region): Make sure we always return a tree.
3552
36881d16
HK
35532011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3554
3555 * xml.c (parse_region): If a document contains only comments,
3556 return that, too.
3557
1e98674d
LMI
35582011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3559
3560 * xml.c (make_dom): Return comments, too.
3561
590bd467
PE
35622011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3563
3564 Port to OpenBSD.
3565 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3566 and the surrounding thread.
3567 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3568 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3569 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3570 timer goes off.
3571 * s/openbsd.h (BROKEN_SIGIO): Define.
3572 * unexelf.c (unexec) [__OpenBSD__]:
3573 Don't update the .mdebug section of the Alpha COFF symbol table.
3574
f41628b2
LMI
35752011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3576
3577 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3578 (bug#8460).
3579
b59b67c5
PE
35802011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3581
15e3a074
PE
3582 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3583 This fixes some race conditions on the permissions of any newly
3584 created file.
3585
41bed37d
PE
3586 * alloc.c (valid_pointer_p): Use pipe, not open.
3587 This fixes some permissions issues when debugging.
3588
b59b67c5
PE
3589 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3590 If fchown fails to set both uid and gid, try to set just gid,
3591 as that is sometimes allowed. Adjust the file's mode to eliminate
3592 setuid or setgid bits that are inappropriate if fchown fails.
3593
925a6be7
SM
35942011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3595
3596 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3597 to compare Lisp_Objects.
3598 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3599 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3600 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3601
52968808
AS
36022011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3603
0a6a104b
AS
3604 * lread.c (read_integer): Unread even EOF character.
3605 (read1): Likewise. Properly record start position of symbol.
3606
52968808
AS
3607 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3608 symbol character follows.
3609
9e381cdd
PE
36102011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3611
3612 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3613 This works around a problem with the previous change to Fcopy_file.
3614 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3615 and without this change, GCC might complain about discarding
3616 fchown's return value.
3617
b5641435
JB
36182011-07-16 Juanma Barranquero <lekktu@gmail.com>
3619
3620 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3621
a8031457
PE
36222011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3623
3624 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3625
dd889327
LMI
36262011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3627
750c33f7
LMI
3628 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3629 it's used from the C level.
3630
dd889327
LMI
3631 * process.c: Use the same condition for POLL_FOR_INPUT in both
3632 keyboard.c and process.c (bug#1858).
3633
87e86684
LM
36342011-07-09 Lawrence Mitchell <wence@gmx.li>
3635
3636 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3637 (Fgnutls_boot): Use it.
3638
64348f40
AS
36392011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3640
3641 * doc.c (Fsubstitute_command_keys): Revert last change.
3642
1d698799
LMI
36432011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3644
f863868c
LMI
3645 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3646 quotes the next character, and doesn't affect other longer
3647 sequences (bug#8935).
3648
1d698799
LMI
3649 * lread.c (syms_of_lread): Clarify that is isn't only
3650 `eval-buffer' and `eval-defun' that's affected by
3651 `lexical-binding' (bug#8460).
3652
aa4b6df6
EZ
36532011-07-15 Eli Zaretskii <eliz@gnu.org>
3654
3655 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 3656 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 3657
5d856da6
PE
36582011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3659
ad6042bb
PE
3660 Fix minor problems found by static checking.
3661 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3662 (elsz): Now a signed constant, not a size_t var. We prefer signed
3663 types to unsigned, to avoid integer comparison confusion. Without
3664 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3665 "cannot optimize loop, the loop counter may overflow", a symptom
3666 of the confusion.
f00bbb22 3667 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
3668 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3669
6468f31c
LMI
36702011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3671
49080b10
LMI
3672 * search.c (Fre_search_backward): Mention `case-fold-search' in
3673 all the re_search_* functions (bug#8138).
3674
6468f31c
LMI
3675 * keyboard.c (Fopen_dribble_file): Document when the file is
3676 closed (bug#8056).
3677
c965adc5
EZ
36782011-07-14 Eli Zaretskii <eliz@gnu.org>
3679
df9733bf
EZ
3680 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3681 bidi_cache_idx.
3682
0bb23927
EZ
3683 Support bidi reordering of display and overlay strings.
3684 * xdisp.c (compute_display_string_pos)
3685 (compute_display_string_end): Accept additional argument STRING.
3686 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3687 (reseat_to_string): Initialize bidi_it->string.s and
3688 bidi_it->string.schars.
3689 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
3690 NULL (avoids a crash in bidi_paragraph_init).
3691 Initialize itb.string.lstring.
0bb23927
EZ
3692 (init_iterator): Call bidi_init_it only of a valid
3693 buffer position was specified. Initialize paragraph_embedding to
3694 L2R.
3695 (reseat_to_string): Initialize the bidi iterator.
3696 (display_string): If we need to ignore text properties of
3697 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3698 original value of -1 will not work with bidi.)
3699 (compute_display_string_pos): First arg is now struct
3700 `text_pos *'; all callers changed. Support display properties on
3701 Lisp strings.
3702 (compute_display_string_end): Support display properties on Lisp
3703 strings.
3704 (init_iterator, reseat_1, reseat_to_string): Initialize the
3705 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3706 when iterating on a string not from display properties).
640c8776
SM
3707 (compute_display_string_pos, compute_display_string_end):
3708 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
3709 arrow keys.
3710 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
3711 base_level_stop; instead, set base_level_stop to BEGV.
3712 Fixes crashes in vertical-motion.
0bb23927
EZ
3713 (next_element_from_buffer): Improve commentary for when
3714 the iterator is before prev_stop.
3715 (init_iterator): Initialize bidi_p from the default value of
3716 bidi-display-reordering, not from buffer-local value. Use the
3717 buffer-local value only if initializing for buffer iteration.
3718 (handle_invisible_prop): Support invisible properties on strings
3719 that are being bidi-reordered.
3720 (set_iterator_to_next): Support bidi reordering of C strings and
3721 Lisp strings.
3722 (next_element_from_string): Support bidi reordering of Lisp
3723 strings.
3724 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
3725 (display_string): Support display of R2L glyph rows.
3726 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
3727 (init_iterator): Don't initialize it->bidi_p for strings
3728 here.
3729 (reseat_to_string): Initialize it->bidi_p for strings here.
3730 (next_element_from_string, next_element_from_c_string)
3731 (next_element_from_buffer): Add xassert's for correspondence
3732 between IT's object being iterated and it->bidi_it.string
3733 structure.
3734 (face_before_or_after_it_pos): Support bidi iteration.
3735 (next_element_from_c_string): Handle the case of the first string
3736 character that is not the first one in the visual order.
3737 (get_visually_first_element): New function, refactored from common
3738 parts of next_element_from_buffer, next_element_from_string, and
3739 next_element_from_c_string.
3740 (tool_bar_lines_needed, redisplay_tool_bar)
3741 (display_menu_bar): Force left-to-right direction. Add a FIXME
3742 comment for making that be controlled by a user option.
3743 (push_it, pop_it): Save and restore the state of the
3744 bidi iterator. Save and restore the bidi_p flag.
3745 (pop_it): Iterate out of display property for string iteration as
3746 well.
3747 (iterate_out_of_display_property): Support iteration over strings.
3748 (handle_single_display_spec): Set up it->bidi_it for iteration
3749 over a display string, and call bidi_init_it.
3750 (handle_single_display_spec, next_overlay_string)
3751 (get_overlay_strings_1, push_display_prop): Set up the bidi
3752 iterator for displaying display or overlay strings.
3753 (forward_to_next_line_start): Don't use the shortcut if
3754 bidi-iterating.
3755 (back_to_previous_visible_line_start): If handle_display_prop
3756 pushed the iterator stack, restore the internal state of the bidi
3757 iterator by calling bidi_pop_it same number of times.
3758 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3759 and we are bidi-iterating, don't decrement the iterator position;
3760 instead, set the first_elt flag in the bidi iterator, to produce
3761 the same effect.
3762 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3763 (push_display_prop): xassert that we are iterating a buffer.
3764 (push_it, pop_it): Save and restore paragraph_embedding member.
3765 (handle_single_display_spec, next_overlay_string)
3766 (get_overlay_strings_1, reseat_1, reseat_to_string)
3767 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3768 correctly. Don't assume unibyte strings are not bidi-reordered.
3769 (compute_display_string_pos)
3770 (compute_display_string_end): Fix handling the case of C string.
3771 (push_it, pop_it): Save and restore from_disp_prop_p.
3772 (handle_single_display_spec, push_display_prop): Set the
3773 from_disp_prop_p flag.
3774 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3775 (pop_it): Call iterate_out_of_display_property only if we are
3776 popping after iteration over a string that came from a display
3777 property. Fix a typo in popping stretch info. Add an assertion
3778 for verifying that the iterator position is in sync with the bidi
3779 iterator.
3780 (handle_single_display_spec, get_overlay_strings_1)
3781 (push_display_prop): Fix initialization of paragraph direction for
3782 string when that of the parent object is not yet determined.
3783 (reseat_1): Call bidi_init_it to resync the bidi
3784 iterator with IT's position. (Bug#7616)
3785 (find_row_edges): If ROW->start.pos gives position
3786 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3787 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3788 Reset the from_disp_prop_p flag.
3789 (SAVE_IT, RESTORE_IT): New macros.
3790 (pos_visible_p, face_before_or_after_it_pos)
3791 (back_to_previous_visible_line_start)
3792 (move_it_in_display_line_to, move_it_in_display_line)
3793 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3794 (try_scrolling, redisplay_window, display_line): Use them when
3795 saving a temporary copy of the iterator and restoring it back.
3796 (back_to_previous_visible_line_start, reseat_1)
3797 (init_iterator): Empty the bidi cache "stack".
3798 (move_it_in_display_line_to): If iterator ended up at
3799 EOL, but we never saw any buffer positions smaller than
3800 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3801 motion in bidi-reordered lines.
3802 (move_it_in_display_line_to): Record prev_method and prev_pos
3803 immediately before the call to set_iterator_to_next. Fixes cursor
3804 motion in bidi-reordered lines with stretch glyphs and strings
3805 displayed in margins. (Bug#8133) (Bug#8867)
3806 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3807 TO_CHARPOS.
640c8776
SM
3808 (pos_visible_p): Support positions in bidi-reordered lines.
3809 Save and restore bidi cache.
0bb23927
EZ
3810
3811 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3812 (bidi_paragraph_info): Delete unused struct.
3813 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3814 (bidi_cache_start): New variable.
3815 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3816 to zero.
3817 (bidi_cache_fetch_state, bidi_cache_search)
3818 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3819 (bidi_cache_find, bidi_peek_at_next_level)
3820 (bidi_level_of_next_char, bidi_find_other_level_edge)
3821 (bidi_move_to_visually_next): Compare cache index with
3822 bidi_cache_start rather than with zero.
3823 (bidi_fetch_char): Accept new argument STRING; all callers
3824 changed. Support iteration over a string. Support strings with
3825 display properties. Support unibyte strings. Fix the type of
3826 `len' according to what STRING_CHAR_AND_LENGTH expects.
3827 (bidi_paragraph_init, bidi_resolve_explicit_1)
3828 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
3829 (bidi_level_of_next_char, bidi_move_to_visually_next):
3830 Support iteration over a string.
0bb23927
EZ
3831 (bidi_set_sor_type, bidi_resolve_explicit_1)
3832 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3833 can now be zero (for strings); special values 0 and -1 were
3834 changed to -1 and -2, respectively.
3835 (bidi_char_at_pos): New function.
3836 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3837 Call it instead of FETCH_MULTIBYTE_CHAR.
3838 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3839 initialized to valid values.
3840 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3841 values.
3842 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3843 the test for valid cached positions. Fix the logic for looking up
3844 the sentinel state in the cache. GCPRO the Lisp string we are
3845 iterating.
3846 (bidi_push_it, bidi_pop_it): New functions.
3847 (bidi_initialize): Initialize the bidi cache start stack pointer.
3848 (bidi_cache_ensure_space): New function, refactored from part of
3849 bidi_cache_iterator_state. Don't assume the required size is just
3850 one BIDI_CACHE_CHUNK away.
3851 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3852 (bidi_count_bytes, bidi_char_at_pos): New functions.
3853 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3854 always valid if bidi_cache_idx is valid.
3855 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3856 is valid if it's going to be used.
3857 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3858 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
3859 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3860 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
3861 (bidi_find_other_level_edge, bidi_cache_start_stack):
3862 All variables related to cache indices are now EMACS_INT.
c965adc5 3863
0bb23927
EZ
3864 * dispextern.h (struct bidi_string_data): New structure.
3865 (struct bidi_it): New member `string'. Make flag members be 1-bit
3866 fields, and put them last in the struct.
640c8776
SM
3867 (compute_display_string_pos, compute_display_string_end):
3868 Update prototypes.
0bb23927
EZ
3869 (bidi_push_it, bidi_pop_it): Add prototypes.
3870 (struct iterator_stack_entry): New members bidi_p,
3871 paragraph_embedding, and from_disp_prop_p.
3872 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
3873 (bidi_shelve_cache, bidi_unshelve_cache):
3874 Declare prototypes.
0bb23927
EZ
3875
3876 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3877 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3878 and vector-like objects.
3879
3880 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3881 cache around display iteration.
3882
3883 * window.c (Fwindow_end, window_scroll_pixel_based)
3884 (displayed_window_lines, Frecenter): Save and restore the bidi
3885 cache around display iteration.
3886
3bbd2265
LMI
38872011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3888
3889 * editfns.c (Fdelete_region): Clarify the use of the named
3890 parameters (bug#6788).
3891
adc47434
MR
38922011-07-14 Martin Rudalics <rudalics@gmx.at>
3893
3894 * indent.c (Fvertical_motion): Set and restore w->pointm when
3895 saving and restoring the window's buffer (Bug#9006).
3896
837c31f8
LMI
38972011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3898
3899 * editfns.c (Fstring_to_char): Clarify just what is returned
3900 (bug#6576). Text by Eli Zaretskii.
3901
ac389d0c
JB
39022011-07-13 Juanma Barranquero <lekktu@gmail.com>
3903
3904 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3905
0be0ce47
EZ
39062011-07-13 Eli Zaretskii <eliz@gnu.org>
3907
3908 * buffer.c (mmap_find): Fix a typo.
3909
cd18e7e3
JB
39102011-07-13 Johan Bockgård <bojohan@gnu.org>
3911
3912 Fix execution of x selection hooks.
3913 * xselect.c (Qx_lost_selection_functions)
3914 (Qx_sent_selection_functions): New vars.
3915 (syms_of_xselect): DEFSYM them.
3916 (x_handle_selection_request): Pass Qx_sent_selection_functions
3917 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3918 (x_handle_selection_clear,x_clear_frame_selections):
3919 Pass Qx_lost_selection_functions rather than
3920 Vx_lost_selection_functions to Frun_hook_with_args.
3921
47ea7f44
PE
39222011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3923
ac389d0c 3924 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
3925 The old code sometimes used this field without initializing it.
3926
47ea7f44
PE
3927 * alloc.c (gc_sweep): Don't read past end of array.
3928 In theory, the old code could also have corrupted Emacs internals,
3929 though it'd be very unlikely.
3930
bc985c87
AS
39312011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3932
3933 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 3934 argument. (Bug#4026)
bc985c87 3935
0cf34688
LMI
39362011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3937
b3dadd76
LMI
3938 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3939 key" (bug#4257).
3940
0cf34688
LMI
3941 * window.c (Fset_window_start): Doc fix (bug#4199).
3942 (Fset_window_hscroll): Ditto.
3943
270768cd
PE
39442011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3945
077e3dda 3946 Fix minor new problems caught by GCC 4.6.1.
270768cd 3947 * term.c (init_tty): Remove unused local.
490011a6 3948 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 3949 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 3950 not used otherwise.
270768cd 3951
b1f58454
CY
39522011-07-12 Chong Yidong <cyd@stupidchicken.com>
3953
3954 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3955
22b9578d
LMI
39562011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3957
6e70ab07
LMI
3958 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3959 are the mini-buffer and the echo area (bug#3320).
3960
22b9578d
LMI
3961 * term.c (init_tty): Remove support for supdup, c10 and perq
3962 terminals, which are no longer supported (bug#1482).
3963
8974cc9f
JB
39642011-07-10 Johan Bockgård <bojohan@gnu.org>
3965
3966 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3967
a560d974
JD
39682011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3969
3970 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3971 for non-popups (Bug#3642).
3972
1dae0f0a
AS
39732011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3974
268c2c36 3975 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 3976 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
3977 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3978 * cm.c (losecursor): Likewise.
1dae0f0a
AS
3979 * data.c (fmod): Likewise.
3980 * dispnew.c (swap_glyphs_in_rows): Likewise.
3981 * emacs.c (memory_warning_signal): Likewise.
3982 * floatfns.c (float_error): Likewise.
3983 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3984 (otf_open, font_otf_capability, generate_otf_features)
3985 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3986 Likewise.
3987 * image.c (pbm_read_file): Likewise.
3988 * indent.c (string_display_width): Likewise.
3989 * intervals.c (check_for_interval, search_for_interval)
3990 (inc_interval_count, count_intervals, root_interval)
3991 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3992 * lread.c (defalias): Likewise.
268c2c36 3993 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
3994 * regex.c (set_image_of_range_1, set_image_of_range)
3995 (regex_grow_registers): Likewise.
3996 * sysdep.c (strerror): Likewise.
3997 * termcap.c (valid_filename_p, tprint, main): Likewise.
3998 * tparam.c (main): Likewise.
3999 * unexhp9k800.c (run_time_remap, save_data_space)
4000 (update_file_ptrs, read_header, write_header, calculate_checksum)
4001 (copy_file, copy_rest, display_header): Likewise.
4002 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4003 Likewise.
4004 * xdisp.c (check_it): Likewise.
4005 * xfaces.c (register_color, unregister_color, unregister_colors):
4006 Likewise.
4007 * xfns.c (print_fontset_result): Likewise.
4008 * xrdb.c (member, fatal, main): Likewise.
4009
99033785
PE
40102011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4011
4012 Fix minor problems found by static checking (Bug#9031).
4013 * chartab.c (char_table_set_range, map_sub_char_table):
4014 Remove unused locals.
4015 (uniprop_table): Now static.
4016 * composite.c (_work_char): Remove unused static var.
4017
9cb2ac56
JB
40182011-07-09 Juanma Barranquero <lekktu@gmail.com>
4019
4020 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4021
f25661f0
JD
40222011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4023
4024 * gtkutil.c (qttip_cb): Remove code without function.
4025
8278c4fe
EZ
40262011-07-09 Eli Zaretskii <eliz@gnu.org>
4027
4028 * w32.c (pthread_sigmask): New stub.
4029
1692ae2d 40302011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 4031
8a6ebd58 4032 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
4033 sigprocmask is portable only for single-threaded applications, and
4034 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
4035 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4036 (LIBES): Use it.
4037 * callproc.c (Fcall_process):
4038 * process.c (create_process):
4039 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4040 Use pthread_sigmask, not sigprocmask.
123403e4 4041
1b854618
JD
40422011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4043
4044 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4045 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4046 wrong (Bug#8591).
4047
3fe4b549
JD
40482011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4049
0ce7e563
JD
4050 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4051 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4052 (xg_hide_tooltip): Fix comment.
4053
3fe4b549
JD
4054 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4055 in registerServicesMenuSendTypes.
4056 (validRequestorForSendType): Don't check ns_return_types.
4057
4058 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4059 ns_return_type.
4060
5df75e47
JR
40612011-07-08 Jason Rumney <jasonr@gnu.org>
4062
22610910
JR
4063 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4064 SH_SHOW for hidden windows (Bug#5482).
4065
5df75e47
JR
4066 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4067 frame struct members of non-existent frames (Bug#6284).
4068
699c10bd
JD
40692011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4070
4393663b
JD
4071 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4072 variable firstTime not needed on OSX >= 10.6.
4073 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4074 >= 10.5. Use setKnobProportion, setDoubleValue.
4075
4076 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4077 (MAC_OS_X_VERSION_10_5): Define if not defined.
4078 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4079 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4080 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4081
4082 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4083 cString and lossyCString on OSX >= 10.4
4084
58179cce 4085 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
4086 sizeToFit on OSX >= 10.2.
4087
4088 * nsimage.m (allocInitFromFile): Don't use deprecated method
4089 bestRepresentationForDevice on OSX >= 10.6.
4090
4091 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4092 to avoid warning.
4093
4094 * emacs.c: Declare unexec_init_emacs_zone.
4095
a63e0781
JD
4096 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4097
699c10bd
JD
4098 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4099
4100 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4101 on svcsMenu (Bug#8842).
4102
4103 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4104 ns_return_types.
4105 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4106
4107 * nsterm.m (QUTF8_STRING): Declare.
4108 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4109 (validRequestorForSendType): Return type is (id).
4110 Change indexOfObjectIdenticalTo to indexOfObject.
4111 Check if we have local selection before returning self (Bug#8842).
4112 (writeSelectionToPasteboard): Put local selection into paste board
4113 if we have a local selection (Bug#8842).
4114 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4115
4116 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4117 (ns_get_local_selection): Declare.
4118
54e10184
LMI
41192011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4120
9888ff71
LMI
4121 * keymap.c (describe_map_tree): Don't insert a double newline at
4122 the end of the buffer (bug#1169) and return whether we inserted
4123 something.
4124
54e10184
LMI
4125 * callint.c (Fcall_interactively): Change "reading args" to
4126 "providing args" to try to clarify what it does (bug#1010).
4127
15fa4783
KH
41282011-07-07 Kenichi Handa <handa@m17n.org>
4129
4130 * composite.c (composition_compute_stop_pos): Ignore a static
4131 composition starting before CHARPOS (Bug#8915).
4132
4133 * xdisp.c (handle_composition_prop): Likewise.
4134
a8815b00
EZ
41352011-07-07 Eli Zaretskii <eliz@gnu.org>
4136
4137 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4138 (Bug#9015)
4139
ef7b981d 41402011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
4141
4142 * character.h (unicode_category_t): New enum type.
4143
4144 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4145 (Qchar_code_property_table): New variable.
4146 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4147 (UNIPROP_COMPRESSED_FORM_P): New macros.
4148 (char_table_ascii): Uncompress the compressed values.
4149 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4150 Uncompress the compressed values.
ac389d0c 4151 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
4152 (char_table_ref_and_range): Uncompress the compressed values.
4153 (sub_char_table_set): New arg is_uniprop. Callers changed.
4154 Uncompress the compressed values.
4155 (sub_char_table_set_range): Args changed. Callers changed.
4156 (char_table_set_range): Adjuted for the above change.
4157 (map_sub_char_table): Delete args default_val and parent. Add arg
4158 top. Give decoded values to a Lisp function.
640c8776 4159 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
4160 values to a Lisp function. Gcpro more variables.
4161 (uniprop_table_uncompress)
4162 (uniprop_decode_value_run_length): New functions.
4163 (uniprop_decoder, uniprop_decoder_count): New variables.
4164 (uniprop_get_decoder, uniprop_encode_value_character)
4165 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4166 New functions.
4167 (uniprop_encoder, uniprop_encoder_count): New variables.
4168 (uniprop_get_encoder, uniprop_table)
4169 (Funicode_property_table_internal, Fget_unicode_property_internal)
4170 (Fput_unicode_property_internal): New functions.
4171 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4172 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 4173 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
4174 char-code-property-alist.
4175
640c8776 4176 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
4177 Vunicode_category_table.
4178
640c8776 4179 * font.c (font_range): Adjust for the change of
c805dec0
KH
4180 Vunicode_category_table.
4181
76b397fb
DN
41822011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4183
4184 * m/iris4d.h: Remove file, move contents ...
4185 * s/irix6-5.h: ... here.
4186
22b4128e
PE
41872011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4188
4189 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
4190 * alloc.c (mark_buffer):
4191 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4192 (clone_per_buffer_values): Don't assume that
22b4128e
PE
4193 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4194 This isn't true in general, and it's particularly not true
4195 if Emacs is configured with --with-wide-int.
4196 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4197 New macros, used in the buffer.c change.
4198
869795d6
JD
41992011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4200
4201 * xsettings.c: Use both GConf and GSettings if both are available.
4202 (store_config_changed_event): Add comment.
4203 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4204 (store_tool_bar_style_changed): New functions.
5e617bc2 4205 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
4206 (struct xsettings): Move font inside HAVE_XFT.
4207 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 4208 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 4209 Move inside HAVE_XFT.
640c8776 4210 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
4211 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4212 also.
4213 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 4214 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 4215 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
4216 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4217 (parse_settings): Move check for font inside HAVE_XFT.
4218 (read_settings, apply_xft_settings): Add comment.
4219 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4220 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4221 call store_font_name_changed.
4222 (xft_settings_event): Add comment.
4223 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4224 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4225 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4226 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4227 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
4228 (xsettings_get_system_font, xsettings_get_system_normal_font):
4229 Add comment.
869795d6 4230
d8ed26bd
PE
42312011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4232
4233 Random fixes. E.g., (random) never returned negative values.
4234 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4235 subseconds part to the entropy, as that's a bit more random.
4236 Prefer signed to unsigned, since the signedness doesn't matter and
4237 in general we prefer signed. When given a limit, use a
4238 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4239 latter isn't right if USE_2_TAGS_FOR_INTS.
4240 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4241 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4242
cabf1cac
SM
42432011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4244
4245 * textprop.c (text_property_stickiness):
4246 Obey Vtext_property_default_nonsticky.
4247 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4248 * w32fns.c (syms_of_w32fns):
4249 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4250
6e9b2be9
PE
42512011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4252
4253 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4254 This is more efficient than Ffile_directory_p and avoids a minor race.
4255
90186c68
LMI
42562011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4257
7c301272
LMI
4258 * buffer.c (Foverlay_put): Say what the return value is
4259 (bug#7835).
4260
c4f2d8d4
LMI
4261 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4262 is a directory before asking whether to use the file name
4263 (bug#7564).
ad637907
LMI
4264 (barf_or_query_if_file_exists): Make the "File is a directory"
4265 error be more correct.
c4f2d8d4 4266
90186c68
LMI
4267 * fns.c (Frequire): Remove the mention of the .gz files, since
4268 that's installation-specific, but keep the mention of
4269 `get-load-suffixes'.
4270
da64016e
PE
42712011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4272
4273 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4274 Report string overflow if the output is too long.
4275
7d47b580
JB
42762011-07-04 Juanma Barranquero <lekktu@gmail.com>
4277
a555cb87
JB
4278 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4279 (syms_of_gnutls): Remove duplicate DEFSYM for
4280 Qgnutls_bootprop_verify_hostname_error, an error for
4281 Qgnutls_bootprop_verify_error (which is no longer used).
4282
7d47b580
JB
4283 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4284 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4285 Also (re)move comments that are misplaced or no longer relevant.
4286
1e49bfab
LMI
42872011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4288
4289 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4290
1485f4c0
CY
42912011-07-03 Chong Yidong <cyd@stupidchicken.com>
4292
4293 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4294 and background color parameters if they have been changed.
4295
a9ab721e
LMI
42962011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4297
4298 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4299
cf7cff57
PE
43002011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4301
2e13213d
PE
4302 * xsettings.c (SYSTEM_FONT): Define only when used.
4303 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4304
cf7cff57
PE
4305 * keymap.c (access_keymap_1): Now static.
4306
7a8e04f7
CY
43072011-07-02 Chong Yidong <cyd@stupidchicken.com>
4308
4309 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4310 leave any prefix arg for the up event (Bug#1586).
4311
61352f62
LMI
43122011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4313
69bb1ef7
LMI
4314 * lread.c (syms_of_lread): Mention single symbols defined by
4315 `defvar' or `defconst' (bug#7154).
4316
61352f62 4317 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 4318 (Frequire): Mention get-load-suffixes.
61352f62 4319
28545e04
MR
43202011-07-02 Martin Rudalics <rudalics@gmx.at>
4321
4322 * window.h (window): Remove clone_number slot.
4323 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4324 Remove.
4325 (make_parent_window, make_window, saved_window)
4326 (Fset_window_configuration, save_window_save): Don't deal with
4327 clone numbers.
4328 * buffer.c (Qclone_number): Remove declaration.
4329 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4330
3349e122
SM
43312011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4332
4333 Add multiple inheritance to keymaps.
4334 * keymap.c (Fmake_composed_keymap): New function.
4335 (Fset_keymap_parent): Simplify.
4336 (fix_submap_inheritance): Remove.
4337 (access_keymap_1): New function extracted from access_keymap to handle
4338 embedded parents and handle lists of maps.
4339 (access_keymap): Use it.
4340 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4341 (Fcopy_keymap): Handle embedded parents.
4342 (Fcommand_remapping, define_as_prefix): Simplify.
4343 (Fkey_binding): Simplify.
4344 (syms_of_keymap): Move minibuffer-local-completion-map,
4345 minibuffer-local-filename-completion-map,
4346 minibuffer-local-must-match-map, and
4347 minibuffer-local-filename-must-match-map to Elisp.
4348 (syms_of_keymap): Defsubr make-composed-keymap.
4349 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4350 (parse_menu_item): Trivial simplification.
4351
3279eb87
GM
43522011-07-01 Glenn Morris <rgm@gnu.org>
4353
4354 * Makefile.in (SETTINGS_LIBS): Fix typo.
4355
4550efdf
KI
43562011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4357
4358 * coding.c (Fencode_coding_string): Record the last coding system
4359 used, as the function doc string says (bug#8738).
4360
0949d2b6
JD
43612011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4362
4363 * xsettings.c (store_monospaced_changed): Take new font as arg and
4364 check for change against current_mono_font.
4365 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4366 (emacs_settings_constructor, emacs_settings_get_property)
4367 (emacs_settings_set_property, emacs_settings_class_init)
4368 (emacs_settings_init, gsettings_obj): Remove.
4369 (something_changedCB): New function for HAVE_GSETTINGS.
4370 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4371 with value as argument.
4372 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4373 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 4374 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
4375 "changed".
4376
4377 * xgselect.c: Add defined (HAVE_GSETTINGS).
4378 (xgselect_initialize): Ditto.
4379
4380 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4381 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4382 xg_select.
4383
bbc6b304
PE
43842011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4385
4386 * eval.c (struct backtrace): Simplify and port the data structure.
4387 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4388 signed bit field, as this assumption is not portable and it makes
4389 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4390 "char debug_on_exit : 1" as this is not portable either; instead,
4391 use the portable "unsigned int debug_on_exit : 1". Remove unused
4392 member evalargs. Remove obsolete comments about cc bombing out.
4393
9851bfc5
JD
43942011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4395
51bb811f 4396 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
4397 Let HAVE_GSETTINGS override HAVE_GCONF.
4398 (store_monospaced_changed): New function.
4399 (EMACS_SETTINGS): A new type derived from GObject to handle
4400 GSettings notifications.
4401 (emacs_settings_constructor, emacs_settings_get_property)
4402 (emacs_settings_set_property, emacs_settings_class_init):
4403 New functions.
4404 (gsettings_client, gsettings_obj): New variables.
4405 (GSETTINGS_SCHEMA): New define.
4406 (something_changedCB): Call store_monospaced_changed.
4407 (init_gsettings): New function.
4408 (xsettings_initialize): Call init_gsettings.
4409 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4410 to NULL.
4411
640c8776 4412 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
4413 GCONF_CFLAGS/LIBS.
4414
5386012d
MR
44152011-06-29 Martin Rudalics <rudalics@gmx.at>
4416
4417 * window.c (resize_root_window, grow_mini_window)
4418 (shrink_mini_window): Rename Qresize_root_window to
4419 Qwindow_resize_root_window and Qresize_root_window_vertically to
4420 Qwindow_resize_root_window_vertically.
4421
f13e0b08
PE
44222011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4423
4424 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4425
94515237
JB
44262011-06-27 Juanma Barranquero <lekktu@gmail.com>
4427
4428 * makefile.w32-in: Redesign dependencies so they reflect more
4429 clearly which files are directly included by each source file,
4430 and not through other includes.
4431
e43b6e43
MR
44322011-06-27 Martin Rudalics <rudalics@gmx.at>
4433
4434 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4435 (sort_overlays, overlay_strings): When an overlay's clone number
4436 matches the window's clone number process the overlay even if
4437 the overlay's window property doesn't match the current window.
4438
d68443dc
MR
4439 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4440 (Fwindow_hchild): Rename to Fwindow_left_child.
4441 (Fwindow_next): Rename to Fwindow_next_sibling.
4442 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
4443 (resize_window_check): Rename to window_resize_check.
4444 (resize_window_apply): Rename to window_resize_apply.
4445 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4446 (Fdelete_other_windows_internal, resize_frame_windows)
4447 (Fsplit_window_internal, Fdelete_window_internal)
4448 (grow_mini_window, shrink_mini_window)
4449 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 4450
c7e73be5
JD
44512011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4452
4453 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4454 (emacs_fixed_set_min_size): Remove.
4455 (emacs_fixed_new): Take frame as argument.
4456
4457 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4458 (_EmacsFixedPrivate): Remove minwidth/height.
4459 Add struct frame *f.
4460 (emacs_fixed_init): Initialize priv->f.
4461 (get_parent_class, emacs_fixed_set_min_size): Remove.
4462 (emacs_fixed_new): Set priv->f to argument.
4463 (emacs_fixed_get_preferred_width)
4464 (emacs_fixed_get_preferred_height): Use min_width/height from
4465 frames size_hint to set minimum and natural (Bug#8919).
4466 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4467 and use min_width/height from frames size_hint to set
4468 min_width/height (Bug#8919).
4469
4470 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
4471 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4472 Fix indentation.
c7e73be5 4473
cf99dcf8
EZ
44742011-06-26 Eli Zaretskii <eliz@gnu.org>
4475
4476 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4477 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4478 called at ZV.
4479
029529ac
CY
44802011-06-26 Chong Yidong <cyd@stupidchicken.com>
4481
4482 * process.c (wait_reading_process_output): Bypass select if
4483 waiting for a cell while ignoring keyboard input, and input is
4484 pending. Suggested by Jan Djärv (Bug#8869).
4485
7a7ef429
PE
44862011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4487
4488 Use gnulib's dup2 module instead of rolling our own.
4489 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4490
11fdef7d 44912011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
4492
4493 * dispnew.c (scrolling_window): Before scrolling, turn off a
4494 mouse-highlight in the window being scrolled.
4495
cd3520a4
JB
44962011-06-24 Juanma Barranquero <lekktu@gmail.com>
4497
4498 Move DEFSYM to lisp.h and use everywhere.
4499
4500 * character.h (DEFSYM): Move declaration...
4501 * lisp.h (DEFSYM): ...here.
4502
4503 * gnutls.c:
4504 * minibuf.c:
4505 * w32menu.c:
4506 * w32proc.c:
4507 * w32select.c: Don't include character.h.
4508
4509 * alloc.c (syms_of_alloc):
4510 * buffer.c (syms_of_buffer):
4511 * bytecode.c (syms_of_bytecode):
4512 * callint.c (syms_of_callint):
4513 * casefiddle.c (syms_of_casefiddle):
4514 * casetab.c (init_casetab_once):
4515 * category.c (init_category_once, syms_of_category):
4516 * ccl.c (syms_of_ccl):
4517 * cmds.c (syms_of_cmds):
4518 * composite.c (syms_of_composite):
4519 * dbusbind.c (syms_of_dbusbind):
4520 * dired.c (syms_of_dired):
4521 * dispnew.c (syms_of_display):
4522 * doc.c (syms_of_doc):
4523 * editfns.c (syms_of_editfns):
4524 * emacs.c (syms_of_emacs):
4525 * eval.c (syms_of_eval):
4526 * fileio.c (syms_of_fileio):
4527 * fns.c (syms_of_fns):
4528 * frame.c (syms_of_frame):
4529 * fringe.c (syms_of_fringe):
4530 * insdel.c (syms_of_insdel):
4531 * keymap.c (syms_of_keymap):
4532 * lread.c (init_obarray, syms_of_lread):
4533 * macros.c (syms_of_macros):
4534 * msdos.c (syms_of_msdos):
4535 * print.c (syms_of_print):
4536 * process.c (syms_of_process):
4537 * search.c (syms_of_search):
4538 * sound.c (syms_of_sound):
4539 * syntax.c (init_syntax_once, syms_of_syntax):
4540 * terminal.c (syms_of_terminal):
4541 * textprop.c (syms_of_textprop):
4542 * undo.c (syms_of_undo):
4543 * w32.c (globals_of_w32):
4544 * window.c (syms_of_window):
4545 * xdisp.c (syms_of_xdisp):
4546 * xfaces.c (syms_of_xfaces):
4547 * xfns.c (syms_of_xfns):
4548 * xmenu.c (syms_of_xmenu):
4549 * xsettings.c (syms_of_xsettings):
4550 * xterm.c (syms_of_xterm): Use DEFSYM.
4551
4228cf16
TZ
45522011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4553
cd3520a4 4554 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 4555
7fcccf1e
PE
45562011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4557
7efb4e0e
PE
4558 Integer and buffer overflow fixes (Bug#8873).
4559
ff5844ad
PE
4560 * print.c (printchar, strout): Check for string overflow.
4561 (PRINTPREPARE, printchar, strout):
4562 Don't set size unless allocation succeeds.
4563
90532f02
PE
4564 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4565 for sizes. Check for string overflow more accurately.
4566 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4567
6d84508d
PE
4568 * macros.c: Integer and buffer overflow fixes.
4569 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4570 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4571 Use ptrdiff_t, not int, for sizes.
4572 Don't increment bufsize until after realloc succeeds.
4573 Check for size-calculation overflow.
4574 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4575
437b2cb4
PE
4576 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4577
8b9ac8b4
PE
4578 * lread.c: Integer overflow fixes.
4579 (read_integer): Radix is now EMACS_INT, not int,
4580 to improve quality of diagnostics for out-of-range radices.
4581 Calculate buffer size correctly for out-of-range radices.
4582 (read1): Check for integer overflow in radices, and in
4583 read-circle numbers.
82cb60d3
PE
4584 (read_escape): Avoid int overflow.
4585 (Fload, openp, read_buffer_size, read1)
4586 (substitute_object_recurse, read_vector, read_list, map_obarray):
4587 Use ptrdiff_t, not int, for sizes.
4588 (read1): Use EMACS_INT, not int, for sizes.
20270765 4589 Check for size overflow.
8b9ac8b4 4590
7fcccf1e
PE
4591 * image.c (cache_image): Check for size arithmetic overflow.
4592
bfbbd7e7
PE
4593 * lread.c: Integer overflow issues.
4594 (saved_doc_string_size, saved_doc_string_length)
4595 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4596 Now ptrdiff_t, not int.
4597 (read1): Don't assume doc string length fits in int. Check for
4598 out-of-range doc string lengths.
4599 (read_list): Don't assume file position fits in int.
39019e54 4600 (read_escape): Check for hex character overflow.
bfbbd7e7 4601
4e323265
LL
46022011-06-22 Leo Liu <sdl.web@gmail.com>
4603
4604 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4605 Move to minibuffer.el.
4606
85fece3e
PE
46072011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4608
20b84ce9 4609 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
4610 The following patches are for when GLYPH_DEBUG && !XASSERT.
4611 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4612 * dispnew.c (flush_stdout):
4613 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4614 Mark as externally visible.
4615 * dispnew.c (check_window_matrix_pointers): Now static.
4616 * dispnew.c (window_to_frame_vpos):
4617 * xfns.c (unwind_create_frame):
4618 * xterm.c (x_check_font): Remove unused local.
4619 * scroll.c (CHECK_BOUNDS):
4620 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4621 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4622 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4623 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4624 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4625 Now static.
4626 (debug_method_add): Use va_list and vsprintf rather than relying
4627 on undefined behavior with wrong number of arguments.
4628 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4629 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4630 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4631 since we're not interested in debugging glyphs with old libraries.
4632 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4633 GCC 4.6.0's static checking.
4634
0766b489
PE
46352011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4636
31fd4b32
PE
4637 Integer overflow and signedness fixes (Bug#8873).
4638 A few related buffer overrun fixes, too.
4639
b79e8648
PE
4640 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4641
0766b489
PE
4642 * dispextern.h (struct face.stipple):
4643 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4644 (x_bitmap_mask, x_allocate_bitmap_record)
4645 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4646 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4647 (x_create_bitmap_from_xpm_data):
4648 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4649 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4650 (.bitmaps_last):
4651 * xfaces.c (load_pixmap):
4652 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4653 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4654 (.bitmaps_last, struct x_output.icon_bitmap):
4655 Use ptrdiff_t, not int, for bitmap indexes.
4656 (x_allocate_bitmap_record): Check for size overflow.
4657 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4658
b081724f
PE
4659 Use ptrdiff_t, not int, for overlay counts.
4660 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4661 * editfns.c (overlays_around, get_pos_property):
4662 * textprop.c (get_char_property_and_overlay):
4663 * xdisp.c (next_overlay_change, note_mouse_highlight):
4664 * xfaces.c (face_at_buffer_position):
21514da7
PE
4665 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4666 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4667 (Fnext_overlay_change, Fprevious_overlay_change)
4668 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 4669 Use ptrdiff_t, not int, for sizes.
21514da7 4670 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 4671
3de73e5e
PE
4672 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4673
2606c57b
PE
4674 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4675 (x_session_initialize): Do not assume string length fits in int.
4676
aaafe47a
PE
4677 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4678 This is unlikely, but can occur if DPI is outlandish.
4679
2674ddc8 4680 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
4681 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4682
28154962
PE
4683 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4684 * xrdb.c (magic_file_p, search_magic_path):
4685 Omit last arg SUFFIX; it was always 0. All callers changed.
4686 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4687
7de51af5
PE
4688 * xfont.c (xfont_match): Avoid need for strlen.
4689
25ed6cc3
PE
4690 * xfns.c: Don't assume strlen fits in int.
4691 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4692
4eab31dd
PE
4693 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4694 not unsigned long, as we prefer signed integers. All callers changed.
4695 Detect integer overflow in repeat count.
4696 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 4697 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 4698
171e2a58
PE
4699 * termcap.c: Don't assume sizes fit in int and never overflow.
4700 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4701 (gobble_line): Check for size-calculation overflow.
4702
ad39faca 4703 * minibuf.c (Fread_buffer):
6e5bb2dc 4704 * lread.c (intern, intern_c_string):
74ca2eb3
PE
4705 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4706 Don't assume string length fits in int.
4707
52c61c22 4708 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
4709 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4710
b5b8c9e5
PE
4711 * font.c: Don't assume string length fits in int.
4712 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4713 Use ptrdiff_t, not int.
ccd6111c
PE
4714 (font_intern_prop): Don't assume string length fits in int.
4715 Don't assume integer property fits in fixnum.
4716 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 4717
882f0d81 4718 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 4719 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
4720 Reformulate so as not to need the command string.
4721 Invoke gzip -cd rather than gunzip, as it's more portable.
4722 (lock_info_type, lock_file_1, lock_file):
4723 Don't assume pid_t and time_t fit in unsigned long.
4724 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4725 (current_lock_owner): Prefer signed type for sizes.
4726 Use memcpy, not strncpy, where memcpy is what is really wanted.
4727 Don't assume (via atoi) that time_t and pid_t fit in int.
4728 Check for time_t and/or pid_t out of range, e.g., via a network share.
4729 Don't alloca where an auto var works fine.
4730
93f4cf88
PE
4731 * fileio.c: Fix some integer overflow issues.
4732 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4733 Don't assume string length fits in int.
4734 (directory_file_name): Don't assume string length fits in long.
4735 (make_temp_name): Don't assume pid fits in int, or that its print
4736 length is less than 20.
4737
f3e92b69
PE
4738 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4739
1bfdaf10
PE
4740 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4741
35016e9a
PE
4742 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4743
3d1e65a1
PE
4744 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4745 We prefer signed integers, even for size calculations.
4746
0b963a93
PE
4747 * emacs.c: Don't assume string length fits in 'int'.
4748 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4749 (main): Don't invoke strlen when not needed.
4750
573f4b54
PE
4751 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4752 (XD_DEBUG_MESSAGE): Don't waste a byte.
4753
989f33ba
PE
4754 * callproc.c (getenv_internal_1, getenv_internal)
4755 (Fgetenv_internal):
965d34eb
PE
4756 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4757
e4d29b33
PE
4758 * lread.c (invalid_syntax): Omit length argument.
4759 All uses changed. This doesn't fix a bug, but it simplifies the
4760 code away from its former Hollerith-constant appearance, and it's
4761 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 4762 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 4763
eb49b136
PE
4764 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4765 This didn't break anything, but it didn't help either.
4766 It's confusing to put a bogus integer in a place where the actual
4767 value does not matter.
9f62aeb1 4768 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 4769 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 4770
15375a22
PE
4771 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4772 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4773 implementation.
b61cc01c
PE
4774 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4775 We prefer signed types, and the value cannot exceed the EMACS_INT
4776 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
4777 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4778 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4779 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 4780
53b2623d
PE
4781 * indent.c (sane_tab_width): New function.
4782 (current_column, scan_for_column, Findent_to, position_indentation)
4783 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 4784 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 4785
51cab52b 4786 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 4787
f2ed8a70
PE
4788 * lisp.h (lint_assume): New macro.
4789 * composite.c (composition_gstring_put_cache):
4790 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4791
abe80cc6
PE
4792 * editfns.c, insdel.c:
4793 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 4794
b02c740e
PE
4795 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4796
ebc96716
PE
4797 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4798
b4e50fa0 4799 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 4800 Use much-faster test for byte-length change.
311d5d7c 4801 Don't assume string byte-length fits in 'int'.
a4cf38e4 4802 Check that character arg fits in 'int'.
85461888 4803 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 4804
c0c1ee9f
PE
4805 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4806
a498d7f4
PE
4807 * fns.c (concat): Catch string overflow earlier.
4808 Do not rely on integer wraparound.
4809
51cab52b
PE
4810 * dispextern.h (struct it.overlay_strings_charpos)
4811 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
4812 * xdisp.c (forward_to_next_line_start)
4813 (back_to_previous_visible_line_start)
4814 (reseat_at_next_visible_line_start, next_element_from_buffer):
4815 Don't arbitrarily truncate the value of 'selective' to int.
4816
76031fad
PE
4817 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4818
5eb55db9
PE
4819 * composite.c: Don't truncate sizes to 'int'.
4820 (composition_gstring_p, composition_reseat_it)
4821 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
4822 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4823 not EMACS_UINT, for indexes.
5eb55db9 4824
0703a717
PE
4825 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4826
d6202519
PE
4827 * buffer.c: Include <verify.h>.
4828 (struct sortvec.priority, struct sortstr.priority):
8961a454 4829 Now EMACS_INT, not int.
c20998a7 4830 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
4831 (struct sortstr.size, record_overlay_string)
4832 (struct sortstrlist.size, struct sortlist.used):
4833 Don't truncate size to int.
4834 (record_overlay_string): Check for size-calculation overflow.
d6202519 4835 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 4836
d5a19415
JM
48372011-06-22 Jim Meyering <meyering@redhat.com>
4838
029529ac 4839 Don't leak an XBM-image-sized buffer
d5a19415
JM
4840 * image.c (xbm_load): Free the image buffer after using it.
4841
a9041e6c
PE
48422011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4843
4844 Port to Sun C.
4845 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4846 that Sun C diagnosed.
4847 * fns.c (secure_hash): Fix pointer signedness issue.
4848 * intervals.c (static_offset_intervals): New function.
4849 (offset_intervals): Use it.
4850
7f3f739f
LL
48512011-06-21 Leo Liu <sdl.web@gmail.com>
4852
4853 * deps.mk (fns.o):
4854 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4855 sha512.h.
4856
4857 * fns.c (secure_hash): Rename from crypto_hash_function and change
4858 the first arg to accept symbols.
5b66d427 4859 (Fsecure_hash): New primitive.
7f3f739f
LL
4860 (syms_of_fns): New symbols.
4861
76147d94
DD
48622011-06-20 Deniz Dogan <deniz@dogan.se>
4863
4864 * process.c (Fset_process_buffer): Clarify return value in
4865 docstring.
4866
7d7d0045
CY
48672011-06-18 Chong Yidong <cyd@stupidchicken.com>
4868
4869 * dispnew.c (add_window_display_history): Use BVAR.
4870
4871 * xdisp.c (debug_method_add): Use BVAR.
4872 (check_window_end, dump_glyph_matrix, dump_glyph)
4873 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4874
4875 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4876 Likewise.
4877
4878 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4879 check till after the cache is created in init_frame_faces.
4880
ff2bc410
SM
48812011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4882
4883 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4884
28177add
PE
48852011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4886
dd3482fe
PE
4887 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4888 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4889 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4890
393d71f3 4891 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
4892 * fileio.c (Finsert_file_contents):
4893 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4894 Remove the old (too-loose) buffer overflow checks.
4895 They weren't needed, since make_gap checks for buffer overflow.
4896 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4897 The old code merely checked for Emacs fixnum overflow, and relied
4898 on undefined (wraparound) behavior. The new code avoids undefined
4899 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4900
2e6813b0 4901 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
4902 Tune. Don't use wider integers than needed. Don't use alloca.
4903 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 4904
599a9e4f
PE
4905 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4906
99561444
PE
4907 * insdel.c, lisp.h (buffer_overflow): New function.
4908 (insert_from_buffer_1, replace_range, replace_range_2):
4909 * insdel.c (make_gap_larger):
4910 * editfns.c (Finsert_char):
4911 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4912
28177add
PE
4913 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4914
e69dafad
PE
49152011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4916
4baa020d 4917 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 4918
b1c46f02
PE
4919 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4920 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4921
e69dafad
PE
4922 * fileio.c: Don't assume EMACS_INT fits in off_t.
4923 (emacs_lseek): New static function.
4924 (Finsert_file_contents, Fwrite_region): Use it.
4925 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4926
566684ea
PE
4927 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4928
e6966cd6
PE
4929 * fns.c: Don't overflow int when computing a list length.
4930 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4931 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4932 truncation on 64-bit hosts. Check for QUIT every
4933 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4934 faster and is responsive enough.
4935 (Flength): Report an error instead of overflowing an integer.
4936 (Fsafe_length): Return a float if the value is not representable
4937 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 4938 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 4939 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 4940
dd0b0efb
PE
4941 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4942 (header_size, word_size): New constants.
4943 (allocate_vectorlike): Don't check size overflow here.
4944 (allocate_vector): Check it here instead, since this is the only
4945 caller of allocate_vectorlike that could cause overflow.
4946 Check that the new vector's length is representable as a fixnum.
4947
86fe5cfe
PE
4948 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4949 The previous code was bogus. For example, next_almost_prime (32)
4950 returned 39, which is undesirable as it is a multiple of 3; and
4951 next_almost_prime (24) returned 25, which is a multiple of 5 so
4952 why was the code bothering to check for multiples of 7?
4953
80e88859
PE
4954 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4955
4a2f0ad6
PE
4956 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4957
f66c7cf8
PE
4958 Variadic C functions now count arguments with ptrdiff_t.
4959 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4960 Back then I didn't know that the Emacs coding style prefers signed int.
4961 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
4962 were being counted with int, which may truncate counts on 64-bit
4963 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
4964 * lisp.h (struct Lisp_Subr.function.aMANY)
4965 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4966 Arg counts are now ptrdiff_t, not size_t.
4967 All variadic functions and their callers changed accordingly.
4968 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4969 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4970 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4971 * callint.c (Fcall_interactively): Check arg count for overflow,
4972 to avoid potential buffer overrun. Use signed char, not 'int',
4973 for 'varies' array, so that we needn't bother to check its size
4974 calculation for overflow.
4975 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4976 * eval.c (apply_lambda):
4977 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4978 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4979 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4980
a1759b76
PE
4981 * callint.c (Fcall_interactively): Don't use index var as event count.
4982
d96be9fc
PE
4983 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4984 * mem-limits.h (SIZE): Remove; no longer used.
4985
a690a978 4986 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 4987
578c21e6
PE
4988 Remove unnecessary casts.
4989 * xterm.c (x_term_init):
4990 * xfns.c (x_set_border_pixel):
4991 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4992 These aren't needed now that we assume ANSI C.
4993
96f53c6c
PE
4994 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4995 It's more likely to cause problems (due to unsigned overflow)
4996 than to cure them.
4997
83c77d31
PE
4998 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4999
ee2079f1
PE
5000 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5001
6da65536
PE
5002 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5003
7147c4a4
PE
5004 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5005
193e32d9
PE
5006 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5007
e5533da6
PE
5008 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5009
9910e595
PE
5010 GLYPH_CODE_FACE returns EMACS_INT, not int.
5011 * dispextern.h (merge_faces):
5012 * xfaces.c (merge_faces):
01103c44
PE
5013 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5014 Don't assume EMACS_INT fits in int.
9910e595 5015
2638320e
PE
5016 * character.h (CHAR_VALID_P): Remove unused parameter.
5017 * fontset.c, lisp.h, xdisp.c: All uses changed.
5018
045eb8d9
PE
5019 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5020
c1f134b5
PE
5021 * fns.c (concat): Minor tuning based on overflow analysis.
5022 This doesn't fix any bugs. Use int to hold character, instead
5023 of constantly refetching from Emacs object. Use XFASTINT, not
5024 XINT, for value known to be a character. Don't bother comparing
5025 a single byte to 0400, as it's always less.
5026
395fcb93 5027 * floatfns.c (Fexpt):
327eeec8
PE
5028 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5029
abbd3d23
PE
5030 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5031 for characters.
5032
684a03ef
PE
5033 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5034
0fed43f3
PE
5035 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5036 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5037 incorrectly succeed when S was a string, because 4294967386 was
5038 truncated before it was used.
5039
8fd02eb7
PE
5040 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5041 Otherwise, an out-of-range integer could cause undefined behavior
5042 on a 64-bit host.
5043
f8c86b69
PE
5044 * composite.c: Use int, not EMACS_INT, for characters.
5045 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5046 EMACS_INT, for values that are known to be in character range.
5047 This doesn't fix any bugs but is the usual style inside Emacs and
5048 may generate better code on 32-bit machines.
5049
34206dd2
PE
5050 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5051 This is for reasons similar to the recent CHAR_STRING fix.
5052 * charset.c (Fencode_char): Check that character arg is actually
5053 a character. Pass an int to ENCODE_CHAR.
5054 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5055 wider than 'int', as a compile-time check to prevent future regressions
5056 in this area.
5057
c5958d4c 5058 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
5059
5060 Make sure a 64-bit char is never passed to CHAR_STRING.
5061 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5062 by silently ignoring the top 32 bits, allowing some values
5063 that were far too large to be valid characters.
5064 * character.h: Include <verify.h>.
5065 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5066 arguments are no wider than unsigned, as a compile-time check
5067 to prevent future regressions in this area.
5068 * data.c (Faset):
01103c44 5069 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
5070 (Fsubst_char_in_region):
5071 * fns.c (concat):
5072 * xdisp.c (decode_mode_spec_coding):
5073 Adjust to CHAR_STRING's new requirement.
5074 * editfns.c (Finsert_char, Fsubst_char_in_region):
5075 * fns.c (concat): Check that character args are actually
5076 characters. Without this test, these functions did the wrong
5077 thing with wildly out-of-range values on 64-bit hosts.
5078
d37ca623
PE
5079 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5080 These casts should not be needed on 32-bit hosts, either.
5081 * keyboard.c (read_char):
5082 * lread.c (Fload): Remove casts to unsigned.
5083
ea204efb
PE
5084 * lisp.h (UNSIGNED_CMP): New macro.
5085 This fixes comparison bugs on 64-bit hosts.
5086 (ASCII_CHAR_P): Use it.
5087 * casefiddle.c (casify_object):
01103c44 5088 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
5089 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5090 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5091 * dispextern.h (FACE_FROM_ID):
5092 * keyboard.c (read_char): Use UNSIGNED_CMP.
5093
41cb286c
PE
5094 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5095 not to EMACS_INT, to avoid GCC warning.
5096
4a1b9832
PE
5097 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5098
55daad71
PE
5099 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5100 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5101 isn't needed on 32-bit machines.
8f95c75c 5102
01103c44
PE
5103 * buffer.c (Fgenerate_new_buffer_name):
5104 Use EMACS_INT for count, not int.
0ceccced 5105 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
5106
5107 * data.c (Qcompiled_function): Now static.
5108
c6f072e7
PE
5109 * window.c (window_body_lines): Now static.
5110
20ce5912
PE
5111 * image.c (gif_load): Rename local to avoid shadowing.
5112
9c4c5f81
PE
5113 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5114 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5115 * alloc.c (make_save_value): Integer argument is now of type
5116 ptrdiff_t, not int.
5117 (mark_object): Use ptrdiff_t, not int.
5118 * lisp.h (pD): New macro.
5119 * print.c (print_object): Use it.
5120
c0c5c8ae
PE
5121 * alloc.c: Use EMACS_INT, not int, to count objects.
5122 (total_conses, total_markers, total_symbols, total_vector_size)
5123 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
5124 (total_free_floats, total_floats, total_free_intervals)
5125 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
5126 Now EMACS_INT, not int. All uses changed.
5127 (Fgarbage_collect): Compute overall total using a double, so that
5128 integer overflow is less likely to be a problem. Check for overflow
5129 when converting back to an integer.
5a25e253
PE
5130 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5131 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5132 These were 'int' variables that could overflow on 64-bit hosts;
5133 they were never used, so remove them instead of repairing them.
211a0b2a 5134 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
5135 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5136 Previously, this ceilinged at INT_MAX, but that doesn't work on
5137 64-bit machines.
e46bb31a 5138 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 5139
c78baabf 5140 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 5141 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
5142 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5143 when a (possibly-narrower) signed value would do just as well.
5144 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 5145
c9d624c6
PE
5146 * alloc.c: Catch some string size overflows that we were missing.
5147 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5148 for convenience in STRING_BYTES_MAX.
5149 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5150 The definition here is exact; the one in lisp.h was approximate.
5151 (allocate_string_data): Check for string overflow. This catches
5152 some instances we weren't catching before. Also, it catches
5153 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5154 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5155 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 5156
c9d624c6
PE
5157 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5158 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 5159 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 5160
353032ce
PE
5161 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5162
2bccce07
PE
5163 * alloc.c (Fmake_string): Check for out-of-range init.
5164
0ac30604
SM
51652011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5166
5167 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5168
c195f2de
JD
51692011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5170
5171 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5172 xg_get_default_scrollbar_width.
5173
5174 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5175 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5176 (style_changed_cb): Call update_theme_scrollbar_width and call
5177 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5178 all frames (Bug#8505).
5179 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5180 Call gtk_window_set_resizable if HAVE_GTK3.
5181 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5182 and height if HAVE_GTK3 (Bug#8505).
5183 (scroll_bar_width_for_theme): New variable.
5184 (update_theme_scrollbar_width): New function.
5185 (xg_get_default_scrollbar_width): Move code to
5186 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5187 (xg_initialize): Call update_theme_scrollbar_width.
5188
5189 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5190
5191 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5192
e10ac9f1
MR
51932011-06-12 Martin Rudalics <rudalics@gmx.at>
5194
5195 * frame.c (make_frame): Call other_buffer_safely instead of
5196 other_buffer.
5197
5198 * window.c (temp_output_buffer_show): Call display_buffer with
5199 second argument Vtemp_buffer_show_specifiers and reset latter
5200 immediately after the call.
5201 (Vtemp_buffer_show_specifiers): New variable.
5202 (auto_window_vscroll_p, next_screen_context_lines)
5203 (Vscroll_preserve_screen_position): Remove leading asterisks from
5204 doc-strings.
5205
2d3c217e 52062011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 5207
7b7f97e8 5208 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
5209 * buffer.c (Qclone_number): Remove for now, as it's unused.
5210 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5211 (record_buffer): Remove unused local.
5212 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5213 (set_frame_buffer_list): Remove; unused.
5214 * frame.h (other_visible_frames): Remove decl.
5215 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5216 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5217 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5218 if HAVE_GPM.
5219 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5220 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5221 Define only if HAVE_GPM.
5222 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5223 (update_hints_inhibit): Remove; never set. All uses removed.
5224 * widgetprv.h (emacsFrameClassRec): Remove decl.
5225 * window.c (delete_deletable_window): Now returns void, since it
5226 wasn't returning anything.
5227 (compare_window_configurations): Remove unused locals.
5228 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5229 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
5230 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5231 the same widths as pointers. This follows up on the 2011-05-06 patch.
5232 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5233 * xterm.h: Likewise.
5234 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5235
1384b89e
JB
52362011-06-12 Juanma Barranquero <lekktu@gmail.com>
5237
5238 * makefile.w32-in: Update dependencies.
5239 (LISP_H): Add lib/intprops.h.
5240
1100a63c
CY
52412011-06-11 Chong Yidong <cyd@stupidchicken.com>
5242
5243 * image.c (gif_load): Add animation frame delay to the metadata.
5244 (syms_of_image): Use DEFSYM. New symbol `delay'.
5245
6198ccd0
MR
52462011-06-11 Martin Rudalics <rudalics@gmx.at>
5247
5248 * window.c (delete_deletable_window): Re-add.
5249 (Fset_window_configuration): Rewrite to handle dead buffers and
5250 consequently deletable windows.
5251 (window_tree, Fwindow_tree): Remove. Supply functionality in
5252 window.el.
5253 (compare_window_configurations): Simplify code.
5254
b6e3633c
AS
52552011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5256
1ab0dee5
AS
5257 * image.c (imagemagick_load_image): Fix type mismatch.
5258 (Fimagemagick_types): Likewise.
5259
b6e3633c
AS
5260 * window.h (replace_buffer_in_windows): Declare.
5261
9397e56f
MR
52622011-06-11 Martin Rudalics <rudalics@gmx.at>
5263
5264 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5265 Qclone_number. Remove external declaration of Qdelete_window.
5266 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5267 code.
640c8776
SM
5268 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5269 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
5270 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5271 buffer list implementation.
5272 (other_buffer_safely): New function.
5273 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5274 calls to replace_buffer_in_windows and
5275 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5276 if allowed.
5277 (record_buffer): Inhibit quitting and rewrite using quittable
5278 functions. Run Qbuffer_list_update_hook if allowed.
5279 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
5280 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5281 Move switch-to-buffer to window.el.
9397e56f
MR
5282 (bury-buffer): Move to window.el.
5283 (Vbuffer_list_update_hook): New variable.
5284
5285 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5286 section.
5287
5288 * window.h (resize_frame_windows): Move up in code.
5289 (Fwindow_frame): Remove EXFUN.
5290 (replace_buffer_in_all_windows): Remove prototype.
5291 (replace_buffer_in_windows_safely): Add prototype.
5292
5293 * window.c: Declare Qdelete_window static again. Move down
5294 declaration of select_count.
5295 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5296 (Fother_window): Move to window.el.
5297 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5298 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5299 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5300 window.el.
5301 (replace_buffer_in_windows): Implement by calling
5302 Qreplace_buffer_in_windows.
5303 (replace_buffer_in_all_windows): Remove with some functionality
5304 moved into replace_buffer_in_windows_safely.
5305 (replace_buffer_in_windows_safely): New function.
5306 (select_window_norecord, select_frame_norecord): Move in front
5307 of run_window_configuration_change_hook. Remove now obsolete
5308 declarations.
640c8776
SM
5309 (Fset_window_buffer): Rewrite doc-string.
5310 Call Qrecord_window_buffer.
9397e56f
MR
5311 (keys_of_window): Move binding for other-window to window.el.
5312
b50691aa
CY
53132011-06-11 Chong Yidong <cyd@stupidchicken.com>
5314
5315 * dispextern.h (struct image): Replace data member, whose int_val
5316 and ptr_val fields were not used by anything, with a single
5317 lisp_val object.
5318
5319 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5320 (gif_clear_image, gif_load, imagemagick_load_image)
5321 (gs_clear_image, gs_load): Callers changed.
5322
3f754b86
PE
53232011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5324
cca69397
PE
5325 * buffer.h: Include <time.h>, for time_t.
5326 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5327
109e28d0
PE
5328 Fix minor problems found by static checking.
5329
60737f02
PE
5330 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5331
4b66faf3
PE
5332 Make identifiers static if they are not used in other modules.
5333 * data.c (Qcompiled_function, Qframe, Qvector):
5334 * image.c (QimageMagick, Qsvg):
5335 * minibuf.c (Qmetadata):
5336 * window.c (resize_window_check, resize_root_window): Now static.
5337 * window.h (resize_window_check, resize_root_window): Remove decls.
5338
109e28d0
PE
5339 * window.c (window_deletion_count, delete_deletable_window):
5340 Remove; unused.
46a4ce9e
PE
5341 (window_body_lines): Now static.
5342 (Fdelete_other_windows_internal): Mark vars as initialized.
5343 Make sure 'resize_failed' is initialized.
5344 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5345 (resize_window_apply): Remove unused local.
5346 * window.h (delete_deletable_window): Remove decl.
5347
109e28d0 5348 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
5349 (imagemagick_load_image): Fix pointer signedness problem by changing
5350 last arg from unsigned char * to char *. All uses changed.
5351 Also, fix a local for similar reasons.
5352 Remove unused locals. Remove locals to avoid shadowing.
5353 (fn_rsvg_handle_free): Remove; unused.
5354 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 5355 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 5356
3f754b86
PE
5357 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5358
2547adb1
CY
53592011-06-10 Chong Yidong <cyd@stupidchicken.com>
5360
5361 * image.c (gif_load): Fix omitted cast error introduced by
5362 2011-06-06 change.
5363
2c8e37d4
MR
53642011-06-10 Martin Rudalics <rudalics@gmx.at>
5365
5366 * window.h (resize_proportionally, orig_total_lines)
5367 (orig_top_line): Remove from window structure.
5368 (set_window_height, set_window_width, change_window_heights)
5369 (Fdelete_window): Remove prototypes.
5370 (resize_frame_windows): Remove duplicate declaration.
5371
440a42e3
EZ
53722011-06-10 Eli Zaretskii <eliz@gnu.org>
5373
5374 * window.h (resize_frame_windows, resize_window_check)
5375 (delete_deletable_window, resize_root_window)
5376 (resize_frame_windows): Declare prototypes.
5377
5378 * window.c (resize_window_apply): Make definition be "static" to
5379 match the prototype.
5380
562dd5e9
MR
53812011-06-10 Martin Rudalics <rudalics@gmx.at>
5382
5383 * window.c: Remove declarations of Qwindow_size_fixed,
5384 window_min_size_1, window_min_size_2, window_min_size,
5385 size_window, window_fixed_size_p, enlarge_window, delete_window.
5386 Remove static from declaration of Qdelete_window, it's
5387 temporarily needed by Fbury_buffer.
5388 (replace_window): Don't assign orig_top_line and
5389 orig_total_lines.
5390 (Fdelete_window, delete_window): Remove. Window deletion is
5391 handled by window.el.
640c8776
SM
5392 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5393 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
5394 (Fdelete_other_windows): Remove. Deleting other windows is
5395 handled by window.el.
5396 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5397 handled in window.el.
5398 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5399 Window minimum sizes are handled in window.el.
5400 (shrink_windows, size_window, set_window_height)
5401 (set_window_width, change_window_heights, window_height)
5402 (window_width, CURBEG, CURSIZE, enlarge_window)
5403 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5404 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5405 handled in window.el.
5406 (make_dummy_parent): Rename to make_parent_window and give it a
5407 second argument horflag.
5408 (make_window): Don't set resize_proportionally any more.
5409 (Fsplit_window): Remove. Windows are split in window.el.
5410 (save_restore_action, save_restore_orig_size)
5411 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5412 Resize mini windows in window.el.
5413 (grow_mini_window, shrink_mini_window): Implement by calling
5414 Qresize_root_window_vertically, resize_window_check and
5415 resize_window_apply.
640c8776
SM
5416 (saved_window, Fset_window_configuration, save_window_save):
5417 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
5418 resize_proportionally.
5419 (window_min_height, window_min_width): Move to window.el.
5420 (keys_of_window): Move bindings for delete-other-windows,
5421 split-window, delete-window and enlarge-window to window.el.
5422
5423 * buffer.c: Temporarily extern Qdelete_window.
5424 (Fbury_buffer): Temporarily call Qdelete_window instead of
5425 Fdelete_window (Fbury_buffer will move to window.el soon).
5426
5427 * frame.c (set_menu_bar_lines_1): Remove code handling
5428 orig_top_line and orig_total_lines.
5429
5430 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5431 set_window_height but set heights directly.
5432 (change_frame_size_1): Use resize_frame_windows.
5433
5434 * xdisp.c (init_xdisp): Don't use set_window_height but set
5435 heights directly.
5436
640c8776
SM
5437 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5438 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
5439 run_window_configuration_change_hook.
5440
5441 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5442 instead of change_window_heights and run
5443 run_window_configuration_change_hook.
5444
1a13852e
MR
54452011-06-09 Martin Rudalics <rudalics@gmx.at>
5446
5447 * window.c (replace_window): Rename second argument REPLACEMENT to
5448 NEW. New third argument SETFLAG. Rewrite.
5449 (delete_window, make_dummy_parent): Call replace_window with
5450 third argument 1.
5451 (window_list_1): Move down in code.
5452 (run_window_configuration_change_hook): Move set_buffer part
5453 before select_frame_norecord part in order to unwind correctly.
5454 Rename count1 to count.
5455 (recombine_windows, delete_deletable_window, resize_root_window)
5456 (Fdelete_other_windows_internal)
5457 (Frun_window_configuration_change_hook, make_parent_window)
5458 (resize_window_check, resize_window_apply, Fresize_window_apply)
5459 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
5460 (Fdelete_window_internal, Fresize_mini_window_internal):
5461 New functions.
1a13852e
MR
5462 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5463
f3d1777e
MR
54642011-06-08 Martin Rudalics <rudalics@gmx.at>
5465
496e208e
MR
5466 * window.h (window): Add some new members to window structure -
5467 normal_lines, normal_cols, new_total, new_normal, clone_number,
5468 splits, nest, prev_buffers, next_buffers.
5469 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 5470 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 5471
f3d1777e
MR
5472 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5473 Remove.
496e208e
MR
5474 (make_dummy_parent): Set new members of windows structure.
5475 (make_window): Move down in code. Handle new members of window
5476 structure.
5477 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5478 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5479 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5480 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
5481 (Fset_window_next_buffers, Fset_window_clone_number):
5482 New functions.
496e208e
MR
5483 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5484 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5485 Doc-string fixes.
5486 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5487 Argument WINDOW can be now internal window too.
5488 (Fwindow_use_time): Move up in code.
5489 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5490 Rewrite doc-string.
5491 (Fset_window_configuration, saved_window)
5492 (Fcurrent_window_configuration, save_window_save): Handle new
5493 members of window structure.
b9e809c2
MR
5494 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5495 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5496 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5497 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5498 Qget_mru_window, Qresize_root_window,
5499 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5500 Qauto_buffer_name; staticpro them.
f3d1777e 5501
abde8f8c
MR
55022011-06-07 Martin Rudalics <rudalics@gmx.at>
5503
5504 * window.c (Fwindow_total_size, Fwindow_left_column)
5505 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5506 (Fwindow_list_1): New functions.
5507 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
5508 (Fwindow_width, Fscroll_left, Fscroll_right):
5509 Use window_body_cols instead of window_box_text_cols.
5510 (delete_window, Fset_window_configuration):
5511 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
5512 (delete_all_subwindows): Take a window as argument and not a
5513 structure. Rewrite.
190b47e6
MR
5514 (window_loop): Remove handling of GET_LRU_WINDOW and
5515 GET_LARGEST_WINDOW.
5516 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
5517
5518 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
5519 window_box_text_cols. delete_all_subwindows now takes a
5520 Lisp_Object as argument.
abde8f8c 5521
640c8776
SM
5522 * indent.c (compute_motion, Fcompute_motion):
5523 Use window_body_cols instead of window_box_text_cols.
abde8f8c 5524
fa8a67e6
MR
5525 * frame.c (delete_frame): Call delete_all_subwindows with root
5526 window as argument.
5527
a54e3482
DC
55282011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5529
5530 * fns.c (Fputhash): Document return value.
5531
60002bf5
CY
55322011-06-06 Chong Yidong <cyd@stupidchicken.com>
5533
5534 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5535
0c671da6 55362011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 5537
b862a52a 5538 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 5539
be44ca6c
PE
5540 Check for overflow when converting integer to cons and back.
5541 * charset.c (Fdefine_charset_internal, Fdecode_char):
5542 Use cons_to_unsigned to catch overflow.
5543 (Fencode_char): Use INTEGER_TO_CONS.
5544 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5545 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5546 * data.c (long_to_cons, cons_to_long): Remove.
5547 (cons_to_unsigned, cons_to_signed): New functions.
5548 These signal an error for invalid or out-of-range values.
5549 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5550 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5551 * font.c (Ffont_variation_glyphs):
5552 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5553 * lisp.h: Include <intprops.h>.
5554 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5555 (cons_to_signed, cons_to_unsigned): New decls.
5556 (long_to_cons, cons_to_long): Remove decls.
5557 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5558 (Fprimitive_undo): Use CONS_TO_INTEGER.
5559 * xfns.c (Fx_window_property): Likewise.
5560 * xselect.c: Include <limits.h>.
5561 (x_own_selection, selection_data_to_lisp_data):
5562 Use INTEGER_TO_CONS.
5563 (x_handle_selection_request, x_handle_selection_clear)
5564 (x_get_foreign_selection, Fx_disown_selection_internal)
5565 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5566 (lisp_data_to_selection_data): Use cons_to_unsigned.
5567 (x_fill_property_data): Use cons_to_signed.
5568 Report values out of range.
5569
d1f3d2af
PE
5570 Check for buffer and string overflow more precisely.
5571 * buffer.h (BUF_BYTES_MAX): New macro.
5572 * lisp.h (STRING_BYTES_MAX): New macro.
5573 * alloc.c (Fmake_string):
5574 * character.c (string_escape_byte8):
5575 * coding.c (coding_alloc_by_realloc):
5576 * doprnt.c (doprnt):
5577 * editfns.c (Fformat):
5578 * eval.c (verror):
5579 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5580 since they may not be the same number.
5581 * editfns.c (Finsert_char):
5582 * fileio.c (Finsert_file_contents):
5583 Likewise for BUF_BYTES_MAX.
5584
dd52fcea
PE
5585 * image.c: Use ptrdiff_t, not int, for sizes.
5586 (slurp_file): Switch from int to ptrdiff_t.
5587 All uses changed.
5588 (slurp_file): Check that file size fits in both size_t (for
5589 malloc) and ptrdiff_t (for sanity and safety).
5590
7f9bbdbb
PE
5591 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5592 if b->modtime has its maximal value.
5593
dfe18f82
PE
5594 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5595
84acfcf0
PE
5596 Don't assume time_t can fit into int.
5597 * buffer.h (struct buffer.modtime): Now time_t, not int.
5598 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5599 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5600
ccd9a01a
PE
5601 Minor fixes for signed vs unsigned integers.
5602 * character.h (MAYBE_UNIFY_CHAR):
5603 * charset.c (maybe_unify_char):
5604 * keyboard.c (read_char, reorder_modifiers):
5605 XINT -> XFASTINT, since the integer must be nonnegative.
5606 * ftfont.c (ftfont_spec_pattern):
5607 * keymap.c (access_keymap, silly_event_symbol_error):
5608 XUINT -> XFASTINT, since the integer must be nonnegative.
5609 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5610 since it makes no difference and we prefer signed.
5611 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5612 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5613 nonnegative.
5614
d6d100dd
SM
56152011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5616
5617 * window.h (Fwindow_frame): Declare.
5618
2b6148e4
PE
56192011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5620
5621 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5622 (SPARE_MEMORY): Always define.
5623 (LARGE_REQUEST): Remove.
5624 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5625
f230ecc9
MR
56262011-06-06 Martin Rudalics <rudalics@gmx.at>
5627
727e958e
MR
5628 * lisp.h: Move EXFUNS for Fframe_root_window,
5629 Fframe_first_window and Fset_frame_selected_window to window.h.
5630
5631 * window.h: Move EXFUNS for Fframe_root_window,
5632 Fframe_first_window and Fset_frame_selected_window here from
5633 lisp.h.
5634
5635 * frame.c (Fwindow_frame, Fframe_first_window)
5636 (Fframe_root_window, Fframe_selected_window)
5637 (Fset_frame_selected_window): Move to window.c.
5638 (Factive_minibuffer_window): Move to minibuf.c.
5639 (Fother_visible_frames_p): New function.
5640
5641 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5642
f230ecc9
MR
5643 * window.c (decode_window, decode_any_window): Move up in code.
5644 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5645 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
5646 (Fwindow_buffer): Move up and rewrite doc-string.
5647 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5648 (Fwindow_prev): New functions.
727e958e
MR
5649 (Fwindow_frame): Move here from frame.c. Accept any window as
5650 argument.
5651 (Fframe_root_window, Fframe_first_window)
5652 (Fframe_selected_window): Move here from frame.c. Accept frame
5653 or arbitrary window as argument. Update doc-strings.
5654 (Fminibuffer_window): Move up in code.
5655 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
5656 (Fset_frame_selected_window): Move here from frame.c.
5657 Marginal rewrite.
727e958e
MR
5658 (Fselected_window, select_window, Fselect_window): Move up in
5659 code. Minor doc-string fixes.
f230ecc9 5660
4d09bcf6
PE
56612011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5662
5663 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5664 Do not assume that spare memory exists; that assumption is valid
5665 only if SYSTEM_MALLOC.
5666 (LARGE_REQUEST): New macro, so that the issue of large requests
5667 is separated from the issue of spare memory.
5668
810928a2
AS
56692011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5670
172418ad
AS
5671 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5672 format. (Bug#8806)
5673
43f862f7
AS
5674 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5675
810928a2
AS
5676 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5677 before statements.
5678
a059fe24
JD
56792011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5680
5681 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5682
5683 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5684
5685 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5686 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5687
989bf368
JB
56882011-06-05 Juanma Barranquero <lekktu@gmail.com>
5689
5690 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5691
4b80f674
CY
56922011-06-04 Chong Yidong <cyd@stupidchicken.com>
5693
5694 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5695 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
5696 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5697 New error handlers.
4b80f674
CY
5698 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5699 Obey Vx_select_enable_clipboard_manager. Catch errors in
5700 x_clipboard_manager_save (Bug#8779).
5701 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 5702 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 5703
99a33b77 57042011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
5705
5706 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5707
99a33b77 57082011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
5709
5710 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5711 in the current matrix if keep_current_p is non-zero.
5712
8264569d
EZ
57132011-06-04 Eli Zaretskii <eliz@gnu.org>
5714
5715 * bidi.c (bidi_level_of_next_char): Fix last change.
5716
57f97249
EZ
57172011-06-03 Eli Zaretskii <eliz@gnu.org>
5718
fec2107c 5719 Support bidi reordering of text covered by display properties.
57f97249 5720
fec2107c
EZ
5721 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5722 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5723 (bidi_cache_search, bidi_cache_iterator_state)
5724 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
5725 (bidi_level_of_next_char, bidi_move_to_visually_next):
5726 Support character positions inside a run of characters covered by a
fec2107c
EZ
5727 display string.
5728 (bidi_paragraph_init, bidi_resolve_explicit_1)
5729 (bidi_level_of_next_char): Call bidi_fetch_char and
5730 bidi_fetch_char_advance instead of FETCH_CHAR and
5731 FETCH_CHAR_ADVANCE.
5732 (bidi_init_it): Initialize new members.
5733 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5734 definitions.
5735 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5736 instead of using explicit *_CHAR codes.
d6d100dd
SM
5737 (bidi_resolve_explicit, bidi_resolve_weak):
5738 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
5739 bidirectional text is supported only in multibyte buffers.
5740 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5741 it to initialize the frame_window_p member of struct bidi_it.
5742 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5743 (bidi_resolve_explicit, bidi_resolve_weak)
5744 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5745 bidi_it->nchars is non-positive.
5746 (bidi_level_of_next_char): Don't try to lookup the cache for the
5747 next/previous character if nothing is cached there yet, or if we
5748 were just reseat()'ed to a new position.
c40e2fb2 5749
0e14fe90
EZ
5750 * xdisp.c (set_cursor_from_row): Set start and stop points
5751 according to the row's direction when priming the loop that looks
5752 for the glyph on which to display cursor.
5753 (single_display_spec_intangible_p): Function deleted.
5754 (display_prop_intangible_p): Reimplement to call
5755 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
5756 Accept 3 additional arguments needed by handle_display_spec.
5757 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
5758 values: lists, `(when COND...)' forms, etc.
5759 (single_display_spec_string_p): Support property values that are
5760 lists with the argument STRING its top-level element.
5761 (display_prop_string_p): Fix the condition for processing a
5762 property that is a list to be consistent with handle_display_spec.
fec2107c 5763 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
5764 last portion of handle_display_prop.
5765 (compute_display_string_pos): Accept additional argument
5766 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5767 value of a `display' property is a "replacing spec".
5768 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5769 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5770 the display property, but just return a value indicating whether
5771 the display property will replace the characters it covers.
5772 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5773 frame_window_p members of struct bidi_it.
d6d100dd
SM
5774 (compute_display_string_pos, compute_display_string_end):
5775 New functions.
fec2107c
EZ
5776 (push_it): Accept second argument POSITION, where pop_it should
5777 jump to continue iteration.
5778 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 5779
fec2107c
EZ
5780 * keyboard.c (adjust_point_for_property): Adjust the call to
5781 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
5782
5783 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
5784 (bidi_init_it): Update prototypes.
5785 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
5786 (compute_display_string_pos, compute_display_string_end):
5787 Declare prototypes.
fec2107c
EZ
5788 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5789 EMACS_INT.
fc6f18ce 5790
40087514 57912011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 5792
57f53182
PE
5793 Malloc failure behavior now depends on size of allocation.
5794 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5795 * lisp.h: Change signatures accordingly.
5796 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5797 All callers changed. (Bug#8762)
5798
5799 * gnutls.c: Use Emacs's memory allocators.
5800 Without this change, the gnutls library would invoke malloc etc.
5801 directly, which causes problems on non-SYNC_INPUT hosts, and which
5802 runs afoul of improving memory_full behavior. (Bug#8761)
5803 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5804 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5805 xfree instead of the default malloc, realloc, free.
5806 (Fgnutls_boot): No need to check for memory allocation failure,
5807 since xmalloc does that for us.
5808
ac32cd99 5809 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
5810 * category.c (hash_get_category_set):
5811 * ccl.c (ccl_driver):
5812 * charset.c (Fdefine_charset_internal):
5813 * charset.h (struct charset.hash_index):
5814 * composite.c (get_composition_id, gstring_lookup_cache)
5815 (composition_gstring_put_cache):
5816 * composite.h (struct composition.hash_index):
5817 * dispextern.h (struct image.hash):
5818 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5819 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5820 (hashfn_equal, hashfn_user_defined, make_hash_table)
5821 (maybe_resize_hash_table, hash_lookup, hash_put)
5822 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5823 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5824 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5825 * image.c (make_image, search_image_cache, lookup_image)
5826 (xpm_put_color_table_h):
5827 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 5828 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 5829 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 5830 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
5831 * alloc.c (allocate_vectorlike):
5832 Check for overflow in vector size calculations.
5833 * ccl.c (ccl_driver):
5834 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
5835 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5836 need to be updated by these changes.
40087514
PE
5837 * fns.c (make_hash_table, maybe_resize_hash_table):
5838 Check for integer overflow with large hash tables.
0de4bb68
PE
5839 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5840 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5841 (SXHASH_REDUCE): New macro.
5842 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5843 Use it instead of discarding useful hash info with large hash values.
5844 (sxhash_float): New function.
5845 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5846 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
5847 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5848 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
5849 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5850 Adjust signatures to match updated version of code.
5851 (consing_since_gc): Now EMACS_INT, since a single hash table can
5852 use more than INT_MAX bytes.
5853
698d32e2
DN
58542011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5855
5856 Make it possible to build with GCC-4.6+ -O2 -flto.
5857
5858 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5859
fd6fa53f
SM
58602011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5861
5862 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5863 Call minibuffer-inactive-mode.
5864
864db017
JB
58652011-05-31 Juanma Barranquero <lekktu@gmail.com>
5866
5867 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5868 Update dependencies.
5869
2ad0baf4
DN
58702011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5871
5872 * data.c (init_data): Remove code for UTS, this system is not
5873 supported anymore.
5874
4fcc2638
DN
58752011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5876
5877 Don't force ./temacs to start in terminal mode.
5878
5879 * frame.c (make_initial_frame): Initialize faces in all cases, not
5880 only when CANNOT_DUMP is defined.
5881 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5882
c56e0fd5
DN
58832011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5884
5885 * dispnew.c (add_window_display_history): Use const for the string
5886 pointer. Remove declaration, not needed.
5887
333d54da 58882011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 5889
55d4c1b2 5890 Use 'inline', not 'INLINE'.
333d54da 5891 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
5892 * alloc.c, fontset.c (INLINE): Remove.
5893 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5894 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5895 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5896 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5897 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5898
738db178
DN
58992011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5900
5901 Make it possible to run ./temacs.
5902
5903 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5904 syms_of_callproc does the same thing. Remove test for
5905 "initialized", do it in the caller.
5906 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5907
620c53a6
SM
59082011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5909
5910 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5911 (read_minibuf): Use get_minibuffer.
5912 (syms_of_minibuf): Use DEFSYM.
5913 (Qmetadata): New var.
5914 * data.c (Qbuffer): Don't make it static.
5915 (syms_of_data): Use DEFSYM.
5916
e003a292
PE
59172011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5918
5919 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5920 (CCL_CODE_MIN): New macro.
5921
ed008a6d
PE
59222011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5923
3687c2ef
PE
5924 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5925
ed008a6d
PE
5926 * eval.c (Qdebug): Now static.
5927 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5928 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5929 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5930
d66c4c7c
CY
59312011-05-29 Chong Yidong <cyd@stupidchicken.com>
5932
5933 * image.c: Various fixes to ImageMagick code comments.
5934 (Fimagemagick_types): Doc fix.
5935
5fbc2025
PE
59362011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5937
0196f88a
PE
5938 Minor fixes prompted by GCC 4.6.0 warnings.
5939
5940 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5941
5fbc2025
PE
5942 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5943 (x_clipboard_manager_save_all): Move extern decl to ...
5944 * xterm.h: ... here, so that it can be checked for consistency.
5945
1dd3c2d9
CY
59462011-05-29 Chong Yidong <cyd@stupidchicken.com>
5947
5948 * xselect.c (x_clipboard_manager_save_frame)
5949 (x_clipboard_manager_save_all): New functions.
5950 (Fx_clipboard_manager_save): Lisp function deleted.
5951
5952 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5953 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5954
5955 * xterm.h: Update prototype.
5956
5ba6571d
WX
59572011-05-28 William Xu <william.xwl@gmail.com>
5958
5959 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5960 exiting (Bug#8239).
5961
3eaff834
JM
59622011-05-28 Jim Meyering <meyering@redhat.com>
5963
e1900994 5964 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
5965 * fns.c (to_uchar): Define.
5966 (crypto_hash_function): Use it to convert some newly-signed
5967 variables to unsigned, to avoid sign-extension bugs. For example,
5968 without this change, (md5 "truc") would evaluate to
5969 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5970 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 5971 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 5972
0f6990a7
PE
59732011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5974
5975 Integer overflow fixes.
c8a9ca5a 5976
08686060
PE
5977 * dbusbind.c: Serial number integer overflow fixes.
5978 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
5979 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5980 to hold a serial number that is too large for a fixnum.
5981 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5982 Check for serial numbers out of range. Decode any serial number
59568bf0 5983 that was so large that it became a float. (Bug#8722)
08686060 5984
2d1fc3c7
PE
5985 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5986 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5987 Use XFASTINT rather than XUINT when numbers are nonnegative.
5988 (xd_append_arg, Fdbus_method_return_internal):
5989 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5990 arguments, check that Lisp number is nonnegative, rather than
59568bf0 5991 silently wrapping negative numbers around. (Bug#8722)
30217ff0 5992 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 5993 (Bug#8722)
2d1fc3c7 5994
c8a9ca5a
PE
5995 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5996
519e1d69
PE
5997 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5998
6df6ae42 5999 ccl: Add integer overflow checks.
30569699
PE
6000 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6001 (IN_INT_RANGE): New macros.
6002 (ccl_driver): Use them to check for integer overflow when
6003 decoding a CCL program. Many of the new checks are whether XINT (x)
6004 fits in int; it doesn't always, on 64-bit hosts. The new version
6005 doesn't catch all possible integer overflows, but it's an
847044ea 6006 improvement. (Bug#8719)
30569699 6007
c11285dc
PE
6008 * alloc.c (make_event_array): Use XINT, not XUINT.
6009 There's no need for unsigned here.
6010
fdccd48e
PE
6011 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6012 This follows up to the 2011-05-06 change that substituted uintptr_t
6013 for EMACS_INT. This case wasn't caught back then.
6014
37910ab2
PE
6015 Rework Fformat to avoid integer overflow issues.
6016 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6017 now (part of C89). Include <verify.h>.
6018 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6019 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6020 (Fformat): Avoid the prepass trying to compute sizes; it was only
6021 approximate and thus did not catch overflow reliably. Instead, walk
6022 through the format just once, formatting and computing sizes as we go,
6023 checking for integer overflow at every step, and allocating a larger
6024 buffer as needed. Keep track separately whether the format is
6025 multibyte. Keep only the most-recently calculated precision, rather
6026 than them all. Record whether each argument has been converted to
6027 string. Use EMACS_INT, not int, for byte and char and arg counts.
6028 Support field widths and precisions larger than INT_MAX. Avoid
6029 sprintf's undefined behavior with conversion specifications such as %#d
6030 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6031 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6032 formatting out-of-range floating point numbers with int
9173deec 6033 formats. (Bug#8668)
37910ab2 6034
2e6578fb
PE
6035 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6036
0ae6bdee
PE
6037 * data.c: Avoid integer truncation in expressions involving floats.
6038 * data.c: Include <intprops.h>.
6039 (arith_driver): When there's an integer overflow in an expression
6040 involving floating point, convert the integers to floating point
6041 so that the resulting value does not suffer from catastrophic
6042 integer truncation. For example, on a 64-bit host (* 4
6043 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6044 Do not rely on undefined behavior after integer overflow.
6045
de883a70
PE
6046 merge count_size_as_multibyte, parse_str_to_multibyte
6047 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 6048 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
6049 Check for integer overflow.
6050 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6051 since it's now a duplicate of the other. This is more of
6052 a character than a buffer op, so better that it's in character.c.
6053 * fns.c, print.c: Adjust to above changes.
6054
2ff916cb
PE
60552011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6056
6057 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6058
f1b54466
PE
60592011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6060
fb1ac845
PE
6061 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6062 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6063 (x_clipboard_manager_save): Now static.
6064 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6065
f1b54466
PE
6066 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6067 (crypto_hash_function): Now static.
6068 Fix pointer signedness problems. Avoid unnecessary initializations.
6069
a9f737ee
CY
60702011-05-27 Chong Yidong <cyd@stupidchicken.com>
6071
6072 * termhooks.h (Vselection_alist): Make it terminal-local.
6073
6074 * terminal.c (create_terminal): Initialize it.
6075
6076 * xselect.c: Support for clipboard managers.
6077 (Vselection_alist): Move to termhooks.h as terminal-local var.
6078 (LOCAL_SELECTION): New macro.
6079 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6080 (symbol_to_x_atom): Remove gratuitous arg.
6081 (x_handle_selection_request, lisp_data_to_selection_data)
6082 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
6083 (x_own_selection, x_get_local_selection, x_convert_selection):
6084 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
6085 (some_frame_on_display): Delete unused function.
6086 (Fx_own_selection_internal, Fx_get_selection_internal)
6087 (Fx_disown_selection_internal, Fx_selection_owner_p)
6088 (Fx_selection_exists_p): New optional frame arg.
6089 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6090 (x_handle_selection_clear): Don't treat other terminals with the
6091 same keyboard specially. Use the terminal-local Vselection_alist.
6092 (x_clear_frame_selections): Use Frun_hook_with_args.
6093
6094 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6095
6096 * xterm.h: Add support for those atoms.
6097
e067f0c1
CY
60982011-05-26 Chong Yidong <cyd@stupidchicken.com>
6099
6100 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6101 (converted_selections, conversion_fail_tag): New global variables.
6102 (x_selection_request_lisp_error): Free the above.
6103 (x_get_local_selection): Remove unnecessary code.
6104 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
6105 of converted selections stored in converted_selections.
6106 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
6107 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6108 (x_convert_selection): New function.
6109 (x_handle_selection_event): Simplify.
6110 (x_get_foreign_selection): Don't ignore incoming requests while
6111 waiting for an answer; this will fail when we implement
6112 SAVE_TARGETS, and seems unnecessary anyway.
6113 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6114 (Vx_sent_selection_functions): Doc fix.
6115
0f4aebc0
LL
61162011-05-26 Leo Liu <sdl.web@gmail.com>
6117
6118 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6119
e61124cd
YM
61202011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6121
6122 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6123
6124 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6125 for fringe update if it has periodic bitmap.
ac389d0c 6126 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
6127 and fringe_bitmap_periodic_p.
6128
6129 * fringe.c (get_fringe_bitmap_data): New function.
6130 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6131 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6132 row. Mark glyph row for fringe update if periodicity changed.
6133
6134 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6135 for fringe update unless it has periodic bitmap.
6136
f16d9837
KH
61372011-05-25 Kenichi Handa <handa@m17n.org>
6138
6139 * xdisp.c (get_next_display_element): Set correct it->face_id for
6140 a static composition.
6141
e1b90ef6
LL
61422011-05-24 Leo Liu <sdl.web@gmail.com>
6143
6144 * deps.mk (fns.o):
6145 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6146
6147 * fns.c (crypto_hash_function, Fsha1): New function.
6148 (Fmd5): Use crypto_hash_function.
6149 (syms_of_fns): Add Ssha1.
6150
7400048f
PE
61512011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6152
6153 * gnutls.c: Remove unused macros.
6154 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6155 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6156 Remove macros that are defined and never used.
6157 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6158
abb71cf4
CY
61592011-05-22 Chong Yidong <cyd@stupidchicken.com>
6160
6161 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6162 (Fx_get_selection_internal): Minor cleanup.
6163 (Fx_own_selection_internal): Rename arguments for consistency with
6164 select.el.
6165
6307db39
PE
61662011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6167
6168 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6169
f3d4e0a4
CY
61702011-05-22 Chong Yidong <cyd@stupidchicken.com>
6171
6172 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6173
4d8ade89
YM
61742011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6175
6176 * dispnew.c (scrolling_window): Don't exclude the case that the
6177 last enabled row in the desired matrix touches the bottom boundary.
6178
32078c8d
GM
61792011-05-21 Glenn Morris <rgm@gnu.org>
6180
6181 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
6182 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6183 and add some more files.
32078c8d 6184
7285dc67
EZ
61852011-05-20 Eli Zaretskii <eliz@gnu.org>
6186
6187 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6188 report_file_error introduced by the change from 2011-05-07.
6189
89d1bd22
PE
61902011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6191
6192 * systime.h (Time): Define only if emacs is defined.
6193 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6194 where the include path doesn't have X11/X.h by default. See
6195 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6196
cd394be1 61972011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
6198
6199 * composite.c (find_automatic_composition): Fix previous change.
6200
b9704ad9
GM
62012011-05-20 Glenn Morris <rgm@gnu.org>
6202
6203 * lisp.mk: New file, split from Makefile.in.
6204 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6205 (shortlisp): Remove.
6206 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6207
4a720484
GM
62082011-05-19 Glenn Morris <rgm@gnu.org>
6209
6210 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6211 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6212 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6213 (lisp): Set the order to that of loadup.el.
6214 (shortlisp): Make it a copy of $lisp.
6215 (SOME_MACHINE_LISP): Remove.
6216 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6217 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6218
a28d4396
KH
62192011-05-18 Kenichi Handa <handa@m17n.org>
6220
6221 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6222 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6223 (find_automatic_composition): Mostly rewrite for efficiency.
6224
a2b1fa8e
JB
62252011-05-18 Juanma Barranquero <lekktu@gmail.com>
6226
6227 * makefile.w32-in: Update dependencies.
6228
8e1f5610
CS
62292011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6230
6231 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 6232 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 6233
7025ee00 62342011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 6235
cdfa6eab
PE
6236 Fix some integer overflow issues, such as string length overflow.
6237
06d6db33
PE
6238 * insdel.c (count_size_as_multibyte): Check for string overflow.
6239
2b4560a8
PE
6240 * character.c (lisp_string_width): Check for string overflow.
6241 Use EMACS_INT, not int, for string indexes and lengths; in
6242 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6243 the resulting string length overflows an EMACS_INT; instead,
6244 report a string overflow if no precision given. When checking for
6245 precision exhaustion, use a check that cannot possibly have
6246 integer overflow. (Bug#8675)
6247 * character.h (lisp_string_width): Adjust to new signature.
6248
cb93f9be
PE
6249 * alloc.c (string_overflow): New function.
6250 (Fmake_string): Use it. This doesn't change behavior, but saves
6251 a few bytes and will simplify future changes.
6252 * character.c (string_escape_byte8): Likewise.
6253 * lisp.h (string_overflow): New decl.
6254
1a1f3366
PE
6255 Fixups, following up to the user-interface timestamp change.
6256 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6257 for UI timestamps, instead of unsigned long.
9fbd6841
PE
6258 * msdos.c (mouse_get_pos): Likewise.
6259 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
6260 * w32gui.h (Time): Define by including "systime.h" rather than by
6261 declaring it ourselves. (Bug#8664)
6262
d4e3e4d3
PE
6263 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6264 * image.c (clear_image_cache): Likewise.
6265
f6a24d19
PE
6266 * term.c (term_mouse_position): Don't assume time_t wraparound.
6267
08dc5ae6
PE
6268 Be more systematic about user-interface timestamps.
6269 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
6270 and sometimes 'EMACS_UINT', to represent these timestamps.
6271 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
6272 This makes the code easier to follow, and makes it easier to catch
6273 integer overflow bugs such as Bug#8664.
6274 * frame.c (Fmouse_position, Fmouse_pixel_position):
6275 Use Time, not unsigned long, for user-interface timestamps.
6276 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6277 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6278 * keyboard.h (last_event_timestamp): Likewise.
6279 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6280 * menu.h (xmenu_show): Likewise.
6281 * term.c (term_mouse_position): Likewise.
6282 * termhooks.h (struct input_event.timestamp): Likewise.
6283 (struct terminal.mouse_position_hook): Likewise.
6284 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6285 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6286 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6287 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6288 what it was before.
6289 * menu.h, termhooks.h: Include "systime.h", for Time.
6290
8e55734a
PE
6291 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6292 Don't assume that the difference between two unsigned long values
6293 can fit into an integer. At this point, we know button_down_time
6294 <= event->timestamp, so the difference must be nonnegative, so
6295 there's no need to cast the result if double-click-time is
6296 nonnegative, as it should be; check that it's nonnegative, just in
6297 case. This bug is triggered when events are more than 2**31 ms
86db42d2 6298 apart (about 25 days). (Bug#8664)
8e55734a 6299
841f1b75 6300 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 6301 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 6302
3e26f69c
PE
6303 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6304 that always fit in int. Use a sentinel instead of a counter, to
6305 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
6306 * frame.h (struct frame): Use int for menu_bar_items_used
6307 instead of EMACS_INT, since it always fits in int.
3e26f69c 6308
5cc152c0
PE
6309 * menu.c (grow_menu_items): Check for int overflow.
6310
d89eb65e
PE
6311 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6312
5235bd3e
PE
6313 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6314 Before, the code was not consistent. These values cannot exceed
6315 2**31 - 1 so there's no need to make them unsigned.
6316 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6317 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6318 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6319 as modifiers.
6320 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6321
bc827e23
PE
6322 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6323 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6324 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6325 presumably because the widths might not match.
6326
78eb494e
PE
6327 * window.c (size_window): Avoid needless test at loop start.
6328
04f2d78b
CB
63292011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6330
6331 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6332
d2fc7e3d 63332011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
6334
6335 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6336
d2fc7e3d 63372011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
6338
6339 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6340 `width' to `bar_area_x' and `bar_area_width', respectively.
6341 (x_scroll_run): Take account of fringe background extension.
6342
04f2d78b
CB
6343 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6344 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
6345 `bar_area_width', respectively.
6346 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6347 background extension.
6348
79b70037
GM
63492011-05-10 Jim Meyering <meyering@redhat.com>
6350
6351 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6352
2f142cc5
JB
63532011-05-10 Juanma Barranquero <lekktu@gmail.com>
6354
6355 * image.c (Finit_image_library): Return t for built-in image types,
6356 like pbm and xbm. (Bug#8640)
6357
57679c86
AS
63582011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6359
6360 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6361
888c9e86
EZ
63622011-05-07 Eli Zaretskii <eliz@gnu.org>
6363
b0512a1d
EZ
6364 * w32console.c (Fset_screen_color): Doc fix.
6365 (Fget_screen_color): New function.
6366 (syms_of_ntterm): Defsubr it.
6367
7285dc67
EZ
6368 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6369 unlink the temporary file if Fcall_process didn't create it in the
6370 first place.
6371 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6372 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
6373 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6374 cue to call_process_cleanup not to close that handle.
6375
4d3fcc8e
BK
63762011-05-07 Ben Key <bkey76@gmail.com>
6377
6378 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6379 one of two shell specific rules, either bootstrap-temacs-CMD or
6380 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6381 to the previous implementation of the bootstrap-temacs rule.
6382 The bootstrap-temacs-CMD rule is similar to the previous
6383 implementation of the bootstrap-temacs rule except that it
6384 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6385 variable.
6386
6387 These changes, along with some changes to nt/configure.bat,
6388 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6389 earlier fix to add support for --cflags and --ldflags options
6390 that include quotes so that it works whether make uses cmd or
6391 sh as the shell.
6392
b4289b64
MA
63932011-05-06 Michael Albinus <michael.albinus@gmx.de>
6394
6395 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6396 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6397 is a constant.
6398 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6399 a string. Handle both cases.
6400 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6401 (Fdbus_register_method): Use Qinvalid_function.
6402
af4c0e28
JB
64032011-05-06 Juanma Barranquero <lekktu@gmail.com>
6404
6405 * makefile.w32-in: Update dependencies.
6406 (LISP_H): Add inttypes.h and stdin.h.
6407 (PROCESS_H): Add unistd.h.
6408
c51453d9
EZ
64092011-05-06 Eli Zaretskii <eliz@gnu.org>
6410
6411 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6412 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6413
8ff0ac3c 64142011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 6415
4c4b566b
PE
6416 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6417
aab2b9b5
PE
6418 * term.c (vfatal): Remove stray call to va_end.
6419 It's not needed and the C Standard doesn't allow it here anyway.
6420
c378da0b
PE
6421 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6422 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6423
288b08c7
PE
6424 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6425 bytes.
6426
e3601888
PE
6427 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6428
db6c0e74
PE
6429 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6430
dd5963ea
PE
6431 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6432
88c9450f
PE
6433 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6434
2f9442b8
PE
6435 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6436
c032b5f8
PE
6437 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6438 * charset.c (Fdefine_charset_internal): Don't initialize
6439 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 6440 32-bit int (Bug#8600).
a108c10b
PE
6441
6442 * lread.c (read_integer): Be more consistent with string-to-number.
6443 Use string_to_number to do the actual conversion; this avoids
6444 rounding errors and fixes some other screwups. Without this fix,
6445 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6446 (digit_to_number): Move earlier, for benefit of read_integer.
6447 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 6448 not a digit in any supported base. (Bug#8602)
a108c10b 6449
ad5f9eea
PE
6450 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6451
aec1708a
PE
6452 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6453 to match comment at start of function. This also removes a
6454 GCC warning about overflow in a 32+64-bit port.
6455
47be4ab5
PE
6456 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6457
371cac43
PE
6458 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6459 Reported by Stefan Monnier in
6460 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
6461 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6462 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 6463
d01a7826
PE
6464 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6465 (EMACS_UINTPTR): Likewise, with uintptr_t.
6466
7fd47d5c
PE
6467 * lisp.h: Prefer 64-bit EMACS_INT if available.
6468 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6469 on 32-bit hosts that have 64-bit int, so that they can access
6470 large files.
122b0c86
PE
6471 However, temporarily disable this change unless the temporary
6472 symbol WIDE_EMACS_INT is defined.
7fd47d5c 6473
8727937b
PE
6474 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6475
8ac068ac
PE
6476 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6477 This removes an assumption that EMACS_INT and long are the same
6478 width as pointers. The assumption is true for Emacs porting targets
6479 now, but we want to make other targets possible.
6480 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6481 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6482 In the rest of the code, change types of integers that hold casted
6483 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6484 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6485 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6486 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6487 No need to cast type when ORing.
6488 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6489 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6490 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6491 assume EMACS_INT is the same width as char *.
6492 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6493 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6494 Remove no-longer-needed casts.
6495 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6496 (xg_tool_bar_help_callback, xg_make_tool_item):
6497 Use EMACS_INTPTR to hold an integer
6498 that will be cast to void *; this can avoid a GCC warning
6499 if EMACS_INT is not the same width as void *.
6500 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6501 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6502 (current_message_1, set_message_1):
6503 Use a local to convert to proper width without a cast.
6504 * xmenu.c (dialog_selection_callback): Likewise.
6505
ede49d71
PE
6506 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6507 Also, don't assume VALBITS / RAND_BITS is less than 5,
6508 and don't rely on undefined behavior when shifting a 1 left into
6509 the sign bit.
6510 * lisp.h (get_random): Change signature to match.
6511
2f30ecd0
PE
6512 * lread.c (hash_string): Use size_t, not int, for hash computation.
6513 Normally we prefer signed values; but hashing is special, because
6514 it's better to use unsigned division on hash table sizes so that
6515 the remainder is nonnegative. Also, size_t is the natural width
6516 for hashing into memory. The previous code used 'int', which doesn't
6517 retain enough info to hash well into very large tables.
6518 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6519
2a866e7b
PE
6520 * dbusbind.c: Don't possibly lose pointer info when converting.
6521 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6522 Use XPNTR rather than XHASH, so that the high-order bits of
6523 the pointer aren't lost when converting through void *.
6524
51639eac
PE
6525 * eval.c (Fautoload): Don't double-shift a pointer.
6526
92394119
PE
6527 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6528
dbdb9a7c
JB
65292011-05-06 Juanma Barranquero <lekktu@gmail.com>
6530
6531 * gnutls.c (DEF_GNUTLS_FN):
6532 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6533
db7a0b4f
AS
65342011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6535
6536 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6537 marker. (Bug#8610)
6538
cd394be1 65392011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
6540
6541 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6542 New version that can reserve upto 2GB of heap space.
6543
f7ff1b0f 65442011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
6545
6546 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6547
639c109b
TZ
65482011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6549
6550 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6551 `gnutls_certificate_set_x509_key_file'.
6552
d2127135
JB
65532011-05-05 Juanma Barranquero <lekktu@gmail.com>
6554
6555 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6556 Update dependencies.
6557
e968f4f3
JB
65582011-05-04 Juanma Barranquero <lekktu@gmail.com>
6559
6560 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6561 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6562 Remove unused parameter `fildes'.
6563 * process.c (read_process_output, send_process): Don't pass it.
6564
84d358f0
JB
65652011-05-04 Juanma Barranquero <lekktu@gmail.com>
6566
6567 Fix previous change: the library cache is defined in w32.c.
6568 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6569 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6570
0898ca10
JB
65712011-05-04 Juanma Barranquero <lekktu@gmail.com>
6572
6573 Implement dynamic loading of GnuTLS on Windows.
6574
6575 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6576 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6577 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6578 Declare.
6579
6580 * gnutls.c (Qgnutls_dll): Define.
6581 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6582 (gnutls_*): Declare function pointers.
6583 (init_gnutls_functions): New function to initialize function pointers.
6584 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6585 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6586 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6587 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6588 (emacs_gnutls_write, emacs_gnutls_read)
6589 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6590 (Fgnutls_available_p): New function.
6591 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6592 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6593 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6594
6595 * image.c: Include w32.h.
6596 (Vimage_type_cache): Delete.
6597 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6598 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6599 (w32_delayed_load): Move to w32.c.
6600
6601 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6602
6603 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6604 (w32_delayed_load): Move from image.c. When loading a library, record
6605 its filename in the :loaded-from property of the library id.
6606 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6607 Initialize and staticpro them.
6608 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6609
6610 * process.c: Include lisp.h before w32.h, not after.
6611 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6612 instead of gnutls_record_check_pending.
6613
6614 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6615
ff4de4aa
TZ
66162011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6617
6618 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6619 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6620 as passed in.
6621
abe95abb
JD
66222011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6623
6624 * xterm.c (x_set_frame_alpha): Do not set property on anything
6625 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6626
e16e55d4
JB
66272011-05-02 Juanma Barranquero <lekktu@gmail.com>
6628
6629 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6630
bafcf6a5
JB
66312011-05-02 Juanma Barranquero <lekktu@gmail.com>
6632
6633 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6634 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6635 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6636 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6637 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6638 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6639 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6640 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6641 (Qgnutls_bootprop_callbacks_verify): Make static.
6642
e7a6747f
AS
66432011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6644
19ed11ba
AS
6645 * callproc.c: Indentation fixup.
6646
e7a6747f 6647 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
6648 (wait_for_termination, interruptible_wait_for_termination):
6649 Move after wait_for_termination_1.
e7a6747f 6650
1ef14cb4
LMI
66512011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6652
6653 * sysdep.c (interruptible_wait_for_termination): New function
6654 which is like wait_for_termination, but allows keyboard
6655 interruptions.
6656
6657 * callproc.c (Fcall_process): Add (:file "file") as an option for
6658 the STDOUT buffer.
6659 (Fcall_process_region): Ditto.
6660
330d880c
EZ
66612011-04-30 Eli Zaretskii <eliz@gnu.org>
6662
8db90b73
EZ
6663 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6664 rather than `XVECTOR (FOO)->size'.
6665
330d880c
EZ
6666 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6667 inttypes.h, as a gnulib replacement is used if it not available in
6668 system headers.
6669
15cbd324
EZ
66702011-04-21 Eli Zaretskii <eliz@gnu.org>
6671
6672 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6673 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6674 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6675
6676 * coding.c (coding_alloc_by_realloc): Error out if destination
6677 will grow beyond MOST_POSITIVE_FIXNUM.
6678 (decode_coding_emacs_mule): Abort if there isn't enough place in
6679 charbuf for the composition carryover bytes. Reserve an extra
6680 space for up to 2 characters produced in a loop.
6681 (decode_coding_iso_2022): Abort if there isn't enough place in
6682 charbuf for the composition carryover bytes.
6683
66842011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 6685
ae940cca
EZ
6686 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6687 aborting when %lld or %lll format is passed.
6688 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6689 %llo or %llx format is passed. (Bug#8545)
6690
03ab8921
EZ
6691 * window.c (window_scroll_line_based): Use a marker instead of
6692 simple variables to record original value of point. (Bug#7952)
6693
afda1437
EZ
6694 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6695 produced by %s or %c overflows available buffer space. (Bug#8545)
6696
f76dee0c
PE
66972011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6698
6699 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 6700 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 6701
fdc5744d
JB
67022011-04-28 Juanma Barranquero <lekktu@gmail.com>
6703
6704 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6705
638f053a
JB
67062011-04-28 Juanma Barranquero <lekktu@gmail.com>
6707
6708 * keyboard.c (Qdelayed_warnings_hook): Define.
6709 (command_loop_1): Run `delayed-warnings-hook'
6710 if Vdelayed_warnings_list is non-nil.
6711 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6712 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6713
d178f871
EZ
67142011-04-28 Eli Zaretskii <eliz@gnu.org>
6715
6716 * doprnt.c (doprnt): Don't return value smaller than the buffer
6717 size if the message was truncated. (Bug#8545).
6718
b124fd93
JB
67192011-04-28 Juanma Barranquero <lekktu@gmail.com>
6720
6721 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6722 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6723
e810457d
PE
67242011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6725
6726 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6727
ea51cceb
JB
67282011-04-27 Juanma Barranquero <lekktu@gmail.com>
6729
6730 * makefile.w32-in: Update dependencies.
6731
94dcfacf
EZ
67322011-04-27 Eli Zaretskii <eliz@gnu.org>
6733
6734 Improve `doprnt' and its usage. (Bug#8545)
6735 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6736 `format_end'. Remove support for %l as a conversion specifier.
6737 Don't use xrealloc. Improve diagnostics when the %l size modifier
6738 is used. Update the commentary.
6739
6740 * eval.c (verror): Simplify calculation of size_t.
6741
6742 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6743 messages.
6744
f61f41d7
PE
67452011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6746
6747 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6748 change.
6749
96fb4434
PE
67502011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6751
6752 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6753 This makes this file independent of the recent pseudovector change.
6754
671875da 67552011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 6756
69e9b5a3
PE
6757 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6758
b5f869a7 6759 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 6760 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 6761 Remove unused local.
c8926152 6762 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 6763
841a1577 6764 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
6765 GCC 4.6.0 optimizes based on type-based alias analysis.
6766 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
6767 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6768 != &v->size, and therefore "v->size = 1; b->size = 2; return
6769 v->size;" must therefore return 1. This assumption is incorrect
6770 for Emacs, since it type-puns struct Lisp_Vector * with many other
6771 types. To fix this problem, this patch adds a new type struct
f904488f 6772 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
6773 and pseudovectors, and helps optimizing compilers not get fooled
6774 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6775 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
6776 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6777 the size member.
eab3844f
PE
6778 (XSETPVECTYPE): Rewrite in terms of new macro.
6779 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6780 This is a bit clearer, and further avoids the possibility of
6781 undesirable aliasing.
6782 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 6783 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
6784 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6785 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
6786 (ASIZE): Now uses header.size rather than size.
6787 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
6788 to avoid the hassle of writing XVECTOR (foo)->header.size.
6789 (struct vectorlike_header): New type.
eab3844f
PE
6790 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6791 object, to help avoid aliasing.
6792 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6793 (SUBRP): Likewise, since Lisp_Subr is a special case.
6794 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6795 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6796 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 6797 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
6798 changed to be "header.size" and "header.next".
6799 * buffer.h (struct buffer): Likewise.
6800 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6801 * frame.h (struct frame): Likewise.
6802 * process.h (struct Lisp_Process): Likewise.
6803 * termhooks.h (struct terminal): Likewise.
6804 * window.c (struct save_window_data, struct saved_window): Likewise.
6805 * window.h (struct window): Likewise.
6806 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6807 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6808 * buffer.c (init_buffer_once): Likewise.
6809 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6810 special case.
6811 * process.c (Fformat_network_address): Use local var for size,
6812 for brevity.
6813
0df1eac5
PE
6814 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6815
847ab9d1 6816 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
6817 * data.c (atof): Remove decl; no longer used or needed.
6818 (digit_to_number): Move to lread.c.
6819 (Fstring_to_number): Use new string_to_number function, to be
6820 consistent with how the Lisp reader treats infinities and NaNs.
6821 Do not assume that floating-point numbers represent EMACS_INT
6822 without losing information; this is not true on most 64-bit hosts.
6823 Avoid double-rounding errors, by insisting on integers when
6824 parsing non-base-10 numbers, as the documentation specifies.
6825 * lisp.h (string_to_number): New decl, replacing ...
6826 (isfloat_string): Remove.
bc0a5c13 6827 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 6828 (read1): Do not accept +. and -. as integers; this
452f4150
PE
6829 appears to have been a coding error. Similarly, do not accept
6830 strings like +-1e0 as floating point numbers. Do not report
6831 overflow for integer overflows unless the base is not 10 which
6832 means we have no simple and reliable way to continue.
6833 Break out the floating-point parsing into a new
6834 function string_to_number, so that Fstring_to_number parses
6835 floating point numbers consistently with the Lisp reader.
04f2d78b 6836 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
6837 (E_CHAR, EXP_INT): Remove, replacing with ...
6838 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6839 (string_to_number): New function, replacing isfloat_string.
6840 This function checks for valid syntax and produces the resulting
6841 Lisp float number too. Rework it so that string-to-number
bc0a5c13 6842 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
6843 so that overflow for non-base-10 numbers is reported only when
6844 there's no portable and simple way to convert to floating point.
452f4150 6845
67769ffc
PE
6846 * textprop.c (set_text_properties_1): Rewrite for clarity,
6847 and to avoid GCC warning about integer overflow.
6848
c20db43f
PE
6849 * intervals.h (struct interval): Use EMACS_INT for members
6850 where EMACS_UINT might cause problems. See
6851 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6852 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6853 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6854 All uses changed.
37aa2f85
PE
6855 (offset_intervals): Tell GCC not to worry about length overflow
6856 when negating a negative length.
c20db43f 6857
2538aa2f
PE
6858 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6859 (overrun_check_free): Likewise.
6860
f2d3008d
PE
6861 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6862 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6863 word size.
6864
ec8df744
PE
6865 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6866 (gnutls_make_error): Rename local to avoid shadowing.
6867 (gnutls_emacs_global_deinit): ifdef out; not used.
6868 (Fgnutls_boot): Use const for pointer to readonly storage.
6869 Comment out unused local. Fix pointer signedness problems.
6870
640ee02d
PE
6871 * lread.c (openp): Don't stuff size_t into an 'int'.
6872 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6873 about possible signed overflow.
6874
6048fb2a
PE
6875 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6876 (GDK_KEY_g): Don't define if already defined.
6877 (xg_prepare_tooltip): Avoid pointer signedness problem.
6878 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6879
fa3c87e1
PE
6880 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6881 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6882
2172544b
PE
6883 * xfns.c (Fx_window_property): Simplify a bit,
6884 to make a bit faster and to avoid GCC 4.6.0 warning.
6885 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6886
9b821a21
PE
6887 * fns.c (internal_equal): Don't assume size_t fits in int.
6888
3c616cfa
PE
6889 * alloc.c (compact_small_strings): Tighten assertion a little.
6890
c2982e87
PE
6891 Replace pEd with more-general pI, and fix some printf arg casts.
6892 * lisp.h (pI): New macro, generalizing old pEd macro to other
6893 conversion specifiers. For example, use "...%"pI"d..." rather
6894 than "...%"pEd"...".
6895 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 6896 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
6897 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6898 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6899 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6900 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6901 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6902 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6903 64-bit hosts.
6904 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6905 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6906 * print.c (safe_debug_print, print_object): Likewise.
6907 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6908 to int.
6f04d126
PE
6909 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6910 avoiding the 0 flag, which is not portable.
c2982e87
PE
6911 * process.c (Fmake_network_process): Use pI to avoid cast.
6912 * region-cache.c (pp_cache): Likewise.
6913 * xdisp.c (decode_mode_spec): Likewise.
6914 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6915 behavior on 64-bit hosts with printf arg.
6f04d126 6916 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
6917 (x_stop_queuing_selection_requests): Likewise.
6918 (x_get_window_property): Don't truncate byte count to an 'int'
6919 when tracing.
0b432f21 6920
5e073ec7
PE
6921 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6922 here, since it parses constructs like leading '-' and spaces,
6923 which are not wanted; and it overflows with large numbers.
6924 Instead, simply match F[0-9]+, which is what is wanted anyway.
6925
36372bf9
PE
6926 * alloc.c: Remove unportable assumptions about struct layout.
6927 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6928 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6929 (allocate_vectorlike, make_pure_vector): Use the new macros,
6930 plus offsetof, to remove unportable assumptions about struct layout.
6931 These assumptions hold on all porting targets that I know of, but
6932 they are not guaranteed, they're easy to remove, and removing them
6933 makes further changes easier.
6934
0b432f21
PE
6935 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6936 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
6937 (string_overrun_cookie): Now const. Use initializers that
6938 don't formally overflow signed char, to avoid warnings.
000098c1
PE
6939 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6940 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
6941 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6942 multiple of sizeof (EMACS_INT); it need not be, if
6943 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 6944 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 6945
895009e1
JB
69462011-04-26 Juanma Barranquero <lekktu@gmail.com>
6947
6948 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6949
6a7a1b0b
TZ
69502011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6951
6952 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 6953 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
6954 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6955
841a1577 69562011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
6957
6958 * lisp.h (Qdebug): List symbol.
895009e1 6959 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
6960 * keyboard.c (debug-on-event): New variable.
6961 (handle_user_signal): Break into debugger when debug-on-event
6962 matches the current signal symbol.
6963
f2d3ba6f
DN
69642011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6965
6966 * alloc.c (check_sblock, check_string_bytes)
6967 (check_string_free_list): Convert to standard C.
6968
42ce4c63
TZ
69692011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6970
6971 * w32.c (emacs_gnutls_push): Fix typo.
6972
825cd63c
EZ
69732011-04-25 Eli Zaretskii <eliz@gnu.org>
6974
fb11d64d
EZ
6975 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6976 "cast to pointer from integer of different size".
6977
825cd63c
EZ
6978 Improve doprnt and its use in verror. (Bug#8545)
6979 * doprnt.c (doprnt): Document the set of format control sequences
6980 supported by the function. Use SAFE_ALLOCA instead of always
6981 using `alloca'.
6982
6983 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6984 is one byte too soon. Don't use xrealloc; instead xfree and
6985 xmalloc anew.
6986
e061a11b
TZ
69872011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6988
6989 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6990 callbacks stage.
6991
6992 * gnutls.c: Renamed global_initialized to
6993 gnutls_global_initialized. Added internals for the
6994 :verify-hostname-error, :verify-error, and :verify-flags
6995 parameters of `gnutls-boot' and documented those parameters in the
6996 docstring. Start callback support.
9173deec
JB
6997 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6998 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6999 on error. Return error code.
e061a11b
TZ
7000 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7001 (emacs_gnutls_read): Likewise.
7002 (Fgnutls_boot): Return handshake error code.
7003 (emacs_gnutls_handle_error): New function.
7004 (wsaerror_to_errno): Likewise.
7005
7006 * w32.h (emacs_gnutls_pull): Add prototype.
7007 (emacs_gnutls_push): Likewise.
7008
7009 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7010 (emacs_gnutls_push): Likewise.
7011
70122011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7013
7014 * process.c (wait_reading_process_output): Check if GnuTLS
7015 buffered some data internally if no FDs are set for TLS
7016 connections.
7017
7018 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7019 (LIBS): Link to USER_LIBS.
7020 ($(BLD)/gnutls.$(0)): New target.
7021
fa6996bc
EZ
70222011-04-24 Eli Zaretskii <eliz@gnu.org>
7023
eb35682e
EZ
7024 * xdisp.c (handle_single_display_spec): Rename the
7025 display_replaced_before_p argument into display_replaced_p, to
7026 make it consistent with the commentary. Fix typos in the
7027 commentary.
7028
e2ad650c
EZ
7029 * textprop.c (syms_of_textprop): Remove dead code.
7030 (copy_text_properties): Delete obsolete commentary about an
7031 interface that was deleted long ago. Fix typos in the description
7032 of arguments.
7033
1b2de274
EZ
7034 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7035 to changes in oldXMenu/XMenu.h from 2011-04-16.
7036 <menu_help_message, prev_menu_help_message>: Constify.
7037 (IT_menu_make_room): menu->help_text is now `const char **';
7038 adjust.
7039
7040 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7041 to changes in oldXMenu/XMenu.h from 2011-04-16.
7042 (struct XMenu): Declare `help_text' `const char **'.
7043
7044 * xfaces.c <Qunspecified>: Make extern again.
7045
7046 * syntax.c: Include sys/types.h before including regex.h, as
7047 required by Posix.
7048
762b15be
EZ
7049 * doc.c (get_doc_string): Improve the format passed to `error'.
7050
7051 * doprnt.c (doprnt): Improve commentary.
7052
7053 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7054
7055 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7056 them with etags.
7057
f1052e5d
EZ
7058 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7059 changes in globals.h immediately force recompilation.
762b15be
EZ
7060 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7061 $(CURDIR)/s/ms-w32.h.
7062 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 7063
fa6996bc
EZ
7064 * character.c (Fchar_direction): Function deleted.
7065 (syms_of_character): Don't defsubr it.
7066 <char-direction-table>: Deleted.
7067
e6c3da20
EZ
70682011-04-23 Eli Zaretskii <eliz@gnu.org>
7069
7070 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7071 * doprnt.c: Include limits.h.
7072 (SIZE_MAX): New macro.
04f2d78b
CB
7073 (doprnt): Return a size_t value. 2nd arg is now size_t.
7074 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
7075 Improve overflow protection. Support `l' modifier for integer
7076 conversions. Support %l conversion. Don't assume an EMACS_INT
7077 argument for integer conversions and for %c.
7078
7079 * lisp.h (doprnt): Restore prototype.
7080
7081 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7082 $(SRC)/character.h.
7083
7084 * Makefile.in (base_obj): Add back doprnt.o.
7085
7086 * deps.mk (doprnt.o): Add back prerequisites.
7087 (callint.o): Depend on character.h.
7088
7089 * eval.c (internal_lisp_condition_case): Include the handler
7090 representation in the error message.
7091 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7092 when breaking from the loop.
7093
7094 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7095
7096 * callint.c (Fcall_interactively): When displaying error message
7097 about invalid control letter, pass the character's codepoint, not
7098 a pointer to its multibyte form. Improve display of the character
7099 in octal and display also its hex code.
7100
7101 * character.c (char_string): Use %x to display the (unsigned)
7102 codepoint of an invalid character, to avoid displaying a bogus
7103 negative value.
7104
7105 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7106 `error', not SYMBOL_NAME itself.
7107
7108 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7109 character arguments to `error'.
7110
7111 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7112 to `error' in error message about FINAL_CHAR argument. Make sure
7113 FINAL_CHAR is a character, and use %c when it is passed as
7114 argument to `error'.
7115
4ffd0d6b 71162011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
7117
7118 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7119
7120 * w32.c: Include <time.h>.
7121 (sys_localtime): New function.
7122
4ffd0d6b 71232011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
7124
7125 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7126
4ffd0d6b 7127 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 7128
4ffd0d6b 71292011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 7130
4ffd0d6b
GM
7131 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7132 zombies (Bug#8467).
aac0c6e3 7133
04c56954
EZ
71342011-04-19 Eli Zaretskii <eliz@gnu.org>
7135
7136 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7137 gl_state.e_property when gl_state.object is Qt.
7138
7139 * insdel.c (make_gap_larger): Remove limitation of buffer size
7140 to <= INT_MAX.
7141
16a43933
CY
71422011-04-18 Chong Yidong <cyd@stupidchicken.com>
7143
7144 * xdisp.c (lookup_glyphless_char_display)
7145 (produce_glyphless_glyph): Handle cons cell entry in
7146 glyphless-char-display.
7147 (Vglyphless_char_display): Document it.
7148
7149 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7150 glyphless-char-display.
7151
4581706e
CY
71522011-04-17 Chong Yidong <cyd@stupidchicken.com>
7153
7154 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7155
7156 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7157
7158 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7159 definition for no-X builds.
7160
4887c6e2 71612011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 7162
fd35b6f9
PE
7163 Static checks with GCC 4.6.0 and non-default toolkits.
7164
5c1ccb01
PE
7165 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7166
006c5daa
PE
7167 * process.c (keyboard_bit_set): Define only if SIGIO.
7168 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7169 (send_process): Repair possible setjmp clobbering.
7170
efc736d3
PE
7171 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7172
4e2fe2e6
PE
7173 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7174
f97334a2
PE
7175 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7176
4e75f29d
PE
7177 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7178 Define only if needed.
7179
90efadd1
PE
7180 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7181 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 7182 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 7183
3c647824
PE
7184 * dispextern.h (struct redisplay_interface): Rename param
7185 to avoid shadowing.
e264f262 7186 * termhooks.h (struct terminal): Likewise.
761383f4 7187 * xterm.c (xembed_send_message): Likewise.
3c647824 7188
b58c5c4a
PE
7189 * insdel.c (make_gap_smaller): Define only if
7190 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7191
cad59032
PE
7192 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7193 it.
7194
c339dc2e
PE
7195 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7196 so that we aren't warned about unused symbols.
7197
91a3e27b
PE
7198 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7199
399c71d3 7200 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 7201
8ffc96f5
PE
7202 * xfns.c (x_real_positions): Mark locals as initialized.
7203
eef9bc79
PE
7204 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7205
098db9dd
PE
7206 * xterm.c: Fix problems found by static analysis with other toolkits.
7207 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
7208 (x_dispatch_event): Declare static if USE_GTK, and
7209 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 7210 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 7211 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
7212 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7213 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 7214
eb18f6cc
PE
7215 * xmenu.c (menu_help_callback): Pointer type fixes.
7216 Use const pointers when pointing at readonly data. Avoid pointer
7217 signedness clashes.
7218 (FALSE): Remove unused macro.
7219 (update_frame_menubar): Remove unused decl.
7220
1fe72bf8
PE
7221 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7222
60d9e1db
PE
7223 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7224 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7225 (single_menu_item): Rename local to avoid shadowing.
7226
39261c26
PE
7227 * keyboard.c (make_lispy_event): Remove unused local var.
7228
018c5e19
PE
7229 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7230 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7231
63d2b86e
PE
7232 * bitmaps: Change bitmaps from unsigned char back to the X11
7233 compatible char. Avoid the old compiler warnings about
7234 out-of-range initializers by using, for example, '\xab' rather
7235 than 0xab.
7236
aefd87e1
PE
7237 * xgselect.c (xgselect_initialize): Check vs interface
7238 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7239
bf501fb9
PE
7240 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7241
e9829fdf
PE
7242 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7243 to read-only memory.
7244
1086c095
PE
7245 * fns.c (vector): Remove; this old hack is no longer needed.
7246
2baccd04 7247 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 7248 Remove unused var.
dde42981 7249 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 7250
72391843 7251 * xrdb.c (x_load_resources): Omit unused local.
3565b346 7252
436c16df 7253 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 7254 (x_window): Rename locals to avoid shadowing.
dc5ddd85 7255 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 7256
92bb796d 7257 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 7258 (x_term_init): Remove local to avoid shadowing.
92bb796d 7259
764430a3 7260 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
7261
7262 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7263 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7264
d1dfb56c
EZ
72652011-04-16 Eli Zaretskii <eliz@gnu.org>
7266
c4354cb4
EZ
7267 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7268
d1dfb56c
EZ
7269 Fix regex.c, syntax.c and friends for buffers > 2GB.
7270 * syntax.h (struct gl_state_s): Declare character position members
7271 EMACS_INT.
7272
7273 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7274
04f2d78b
CB
7275 * textprop.c (verify_interval_modification, interval_of):
7276 Declare arguments EMACS_INT.
d1dfb56c
EZ
7277
7278 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7279 EMACS_INT.
7280
7281 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7282
7283 * indent.c (Fvertical_motion): Local variable it_start is now
7284 EMACS_INT.
7285
7286 * regex.c (re_match, re_match_2, re_match_2_internal)
7287 (bcmp_translate, regcomp, regexec, print_double_string)
7288 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7289 (re_compile_pattern, re_exec): Declare arguments and local
7290 variables `size_t' and `ssize_t' and return values `regoff_t', as
7291 appropriate.
7292 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7293 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7294 <compile_stack_type>: `size' and `avail' are now `size_t'.
7295
7296 * regex.h <regoff_t>: Use ssize_t, not int.
7297 (re_search, re_search_2, re_match, re_match_2): Arguments that
7298 specify buffer/string position and length are now ssize_t and
7299 size_t. Return type is regoff_t.
7300
613052cd
BK
73012011-04-16 Ben Key <bkey76@gmail.com>
7302
7303 * nsfont.m: Fixed bugs in ns_get_family and
7304 ns_descriptor_to_entity that were caused by using free to
7305 deallocate memory blocks that were allocated by xmalloc (via
7306 xstrdup). This caused Emacs to crash when compiled with
7307 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7308 --enable-checking=xmallocoverrun). xfree is now used to
7309 deallocate these memory blocks.
7310
4170f62f 73112011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 7312
71b41406
PE
7313 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7314
9587a89d
PE
7315 emacs_write: Accept and return EMACS_INT for sizes.
7316 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7317 et seq.
7318 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7319 Accept and return EMACS_INT.
7320 (emacs_gnutls_write): Return the number of bytes written on
7321 partial writes.
7322 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
7323 (emacs_read, emacs_write): Remove check for negative size, as the
7324 Emacs source code has been audited now.
9587a89d
PE
7325 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7326 (emacs_read, emacs_write): Use it.
273a5f82
PE
7327 * process.c (send_process): Adjust to the new signatures of
7328 emacs_write and emacs_gnutls_write. Do not attempt to store
7329 a byte offset into an 'int'; it might overflow.
9587a89d 7330 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 7331
3e047f51
PE
7332 * sound.c: Don't assume sizes fit in 'int'.
7333 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 7334 Return EMACS_INT, not int.
3e047f51 7335 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
7336 Accept EMACS_INT, not int.
7337 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
7338 record read return values.
7339
cc39a9db
BK
73402011-04-15 Ben Key <bkey76@gmail.com>
7341
c9d0ec6d
JB
7342 * keyboard.c (Qundefined): Don't declare static since it is used
7343 in nsfns.m.
7344 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7345 static since they are used in nsfont.m.
cc39a9db 7346
6c60eb9f
SM
73472011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7348
7349 * process.c (Qprocessp): Don't declare static.
7350 * lisp.h (Qprocessp): Declare again.
7351
7990b61a
JB
73522011-04-15 Juanma Barranquero <lekktu@gmail.com>
7353
7354 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7355
5d4cb038
PE
73562011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7357
8bd7b830 7358 Improve C-level modularity by making more things 'static'.
cd64ea1d 7359
e3b27b31
PE
7360 Don't publish debugger-only interfaces to other modules.
7361 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7362 (verify_bytepos, count_markers): Move decls to the only modules
7363 that need them.
7364 * region-cache.h (pp_cache): Likewise.
7365 * window.h (check_all_windows): Likewise.
7366 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7367
5d4cb038
PE
7368 * sysdep.c (croak): Now static, if
7369 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7370 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
7371
7372 * alloc.c (refill_memory_reserve): Now static if
7373 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7374 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 7375
e87b6180
PE
7376 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7377 Define only if USE_LUCID.
7378
ac64929e
PE
7379 * xrdb.c (x_customization_string, x_rm_string): Now static.
7380
6f37259d
PE
7381 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7382 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7383
1683e3ab
PE
7384 * xdisp.c (draw_row_with_mouse_face): Now static.
7385 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7386
de9c2632
PE
7387 * window.h (check_all_windows): Mark externally visible.
7388
2b96acb7
PE
7389 * window.c (window_deletion_count): Now static.
7390
7391 * undo.c: Make symbols static if they're not exported.
7392 (last_undo_buffer, last_boundary_position, pending_boundary):
7393 Now static.
7394
50436f33
PE
7395 * textprop.c (interval_insert_behind_hooks): Now static.
7396 (interval_insert_in_front_hooks): Likewise.
7397
64520e5c
PE
7398 * term.c: Make symbols static if they're not exported.
7399 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7400 (max_frame_lines, tty_set_terminal_modes):
7401 (tty_reset_terminal_modes, tty_turn_off_highlight):
7402 (get_tty_terminal): Now static.
7403 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7404 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 7405 HAVE_WINDOW_SYSTEM.
64520e5c
PE
7406 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7407 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7408
1fa53021
PE
7409 * sysdep.c: Make symbols static if they're not exported.
7410 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7411 Now static.
7412 (sigprocmask_set, full_mask): Remove; unused.
7413 (wait_debugging): Mark as visible.
7414 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7415 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7416
d4b43b22
PE
7417 * syntax.c (syntax_temp): Define only if !__GNUC__.
7418
b7c513d0
PE
7419 * sound.c (current_sound_device, current_sound): Now static.
7420
989b29ad
PE
7421 * search.c (searchbufs, searchbuf_head): Now static.
7422
13a55a78
PE
7423 * scroll.c (scroll_cost): Remove; unused.
7424 * dispextern.h (scroll_cost): Remove decl.
7425
de68a1fc
PE
7426 * region-cache.h (pp_cache): Mark as externally visible.
7427
40ccffa6
PE
7428 * process.c: Make symbols static if they're not exported.
7429 (process_tick, update_tick, create_process, chan_process):
7430 (Vprocess_alist, proc_buffered_char, datagram_access):
7431 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7432 (deactivate_process): Mark defn as static, as well as decl.
7433 * lisp.h (create_process): Remove decl.
7434 * process.h (chan_process, Vprocess_alist): Remove decls.
7435
ad64fc97
PE
7436 * print.c: Make symbols static if they're not exported.
7437 (print_depth, new_backquote_output, being_printed, print_buffer):
7438 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7439 (print_interval, print_number_index, initial_stderr_stream):
7440 Now static.
7441 * lisp.h (Fprinc): Remove decl.
7442 (debug_output_compilation_hack): Mark as externally visible.
7443
adddb265
PE
7444 * sysdep.c (croak): Move decl from here to syssignal.h.
7445 * syssignal.h (croak): Put it here, so the API can be checked when
7446 'croak' is called from dissociate_if_controlling_tty.
7447
1717ede2
PE
7448 * minibuf.c: Make symbols static if they're not exported.
7449 (minibuf_save_list, choose_minibuf_frame): Now static.
7450 * lisp.h (choose_minibuf_frame): Remove decl.
7451
fa5fb2bc
PE
7452 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7453
1e3890d1
PE
7454 * lread.c: Make symbols static if they're not exported.
7455 (read_objects, initial_obarray, oblookup_last_bucket_number):
7456 Now static.
7457 (make_symbol): Remove; unused.
7458 * lisp.h (initial_obarray, make_symbol): Remove decls.
7459
8a1414fa
PE
7460 * keyboard.c: Make symbols static if they're not exported.
7461 (single_kboard, recent_keys_index, total_keys, recent_keys):
7462 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7463 (this_single_command_key_start, echoing, last_auto_save):
7464 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7465 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7466 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7467 (Vlispy_mouse_stem, double_click_count):
7468 Now static.
7469 (force_auto_save_soon): Define only if SIGDANGER.
7470 (ignore_mouse_drag_p): Now static if
7471 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7472 (print_help): Remove; unused.
7473 (stop_character, last_timer_event): Mark as externally visible.
7474 * keyboard.h (ignore_mouse_drag_p): Declare only if
7475 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7476 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7477 * lisp.h (echoing): Remove decl.
7478 (force_auto_save_soon): Declare only if SIGDANGER.
7479 * xdisp.c (redisplay_window): Simplify code, to make it more
7480 obvious that ignore_mouse_drag_p is not accessed if !defined
7481 USE_GTK && !defined HAVE_NS.
7482
93ea6e8f
PE
7483 * intervals.c: Make symbols static if they're not exported.
7484 (merge_properties_sticky, merge_interval_right, delete_interval):
7485 Now static.
7486 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7487
77382fcc
PE
7488 * insdel.c: Make symbols static if they're not exported.
7489 However, leave prepare_to_modify_buffer alone. It's never
7490 called from outside this function, but that appears to be a bug.
7491 (combine_after_change_list, combine_after_change_buffer):
4889fc82 7492 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
7493 (adjust_after_replace_noundo): Remove; unused.
7494 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 7495 (signal_before_change): Remove decls.
77382fcc 7496
9306c32e
PE
7497 * indent.c (val_compute_motion, val_vmotion): Now static.
7498
cd44d2eb
PE
7499 * image.c: Make symbols static if they're not exported.
7500 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7501 if USE_GTK.
7502 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7503 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7504
ad9a7a06
PE
7505 * fringe.c (standard_bitmaps): Now static.
7506 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7507
81626931
PE
7508 * frame.c: Make symbols static if they're not exported.
7509 (x_report_frame_params, make_terminal_frame): Now static.
7510 (get_frame_param): Now static, unless HAVE_NS.
7511 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7512 (x_get_resource_string): Remove; not used.
7513 * frame.h (make_terminal_frame, x_report_frame_params):
7514 (x_get_resource_string); Remove decls.
7515 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7516 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7517
239f9db9
PE
7518 * font.c, fontset.c: Make symbols static if they're not exported.
7519 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7520 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7521 * font.c (font_close_object): Now static.
7522 * font.h (font_close_object): Remove.
7523 * fontset.c (FONTSET_OBJLIST): Remove.
7524 (free_realized_fontset) #if-0 the body, which does nothing.
7525 (face_suitable_for_char_p): #if-0, as it's never called.
7526 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
7527 * xfaces.c (face_at_string_position):
7528 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
7529 since 0 is always ASCII.
7530
dfcf3579
PE
7531 * fns.c (weak_hash_tables): Now static.
7532
5045092b
PE
7533 * fileio.c: Make symbols static if they're not exported.
7534 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7535 (Vwrite_region_annotation_buffers): Now static.
7536
57a96f5c
PE
7537 * eval.c: Make symbols static if they're not exported.
7538 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7539 * lisp.h (backtrace_list): Remove decl.
7540
35f08c38
PE
7541 * emacs.c: Make symbols static if they're not exported.
7542 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7543 (fatal_error_code, fatal_error_signal_hook, standard_args):
7544 Now static.
7545 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7546 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7547 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7548 * lisp.h (fatal_error_signal_hook): Remove decl.
7549 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7550
f44bd759
PE
7551 * editfns.c: Move a (normally-unused) function to its only use.
7552 * editfns.c, lisp.h (get_operating_system_release): Remove.
7553 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7554 worth the hassle of breaking this out.
7555
b532497d
PE
7556 * xterm.c: Make symbols static if they're not exported.
7557 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7558 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7559 (x_destroy_window, x_delete_display):
7560 Now static.
7561 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7562 (x_mouse_leave): Remove; unused.
7563 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7564 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7565 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7566 Remove decls.
7567 (x_mouse_leave): Declare only if WINDOWSNT.
7568 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7569 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7570 USE_X_TOOLKIT.
7571
1675728f
PE
7572 * ftxfont.c: Make symbols static if they're not exported.
7573 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7574 HAVE_FREETYPE.
7575 * font.h (ftxfont_driver): Likewise.
7576
e4cebfca
PE
7577 * xfns.c: Make symbols static if they're not exported.
7578 (x_last_font_name, x_display_info_for_name):
7579 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7580 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7581 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7582 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7583 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7584 (last_show_tip_args): Now static.
7585 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7586 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7587 (x_screen_planes): Remove; unused.
7588 * dispextern.h (x_screen_planes): Remove decl.
7589
5bf46f05
PE
7590 * dispnew.c: Make symbols static if they're not exported.
7591 * dispextern.h (redraw_garbaged_frames, scrolling):
7592 (increment_row_positions): Remove.
7593 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7594 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7595 Now static.
7596 (redraw_garbaged_frames): Remove; unused.
7597
435f4c28
PE
7598 * xfaces.c: Make symbols static if they're not exported.
7599 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7600 Remove decls.
7601 * xterm.h (defined_color): Remove decls.
7602 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7603 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7604 (menu_face_changed_default, defined_color, free_realized_face):
7605 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7606 (ascii_face_of_lisp_face): Remove; unused.
7607
8524aef3
PE
7608 * xdisp.c: Make symbols static if they're not exported.
7609 * dispextern.h (scratch_glyph_row, window_box_edges):
7610 (glyph_to_pixel_coords, set_cursor_from_row):
7611 (get_next_display_element, set_iterator_to_next):
7612 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7613 (show_mouse_face): Remove decls
7614 * frame.h (message_buf_print): Likewise.
7615 * lisp.h (pop_message, set_message, check_point_in_composition):
7616 Likewise.
7617 * xterm.h (set_vertical_scroll_bar): Likewise.
7618 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7619 (message_buf_print, scratch_glyph_row, displayed_buffer):
7620 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7621 (get_next_display_element, show_mouse_face, window_box_edges):
7622 (frame_to_window_pixel_xy, check_point_in_composition):
7623 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7624 (glyph_to_pixel_coords): Remove; unused.
7625
16390cd2
PE
7626 * dired.c (file_name_completion): Now static.
7627
7628 * dbusbind.c (xd_in_read_queued_messages): Now static.
7629
a25f4dfa
PE
7630 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7631 * data.c (circular_list_error): Remove.
7632
14a9c8df
PE
7633 * commands.h (last_point_position, last_point_position_buffer):
7634 (last_point_position_window): Remove decls.
7635 * keyboard.c: Make these variables static.
7636
04f2d78b
CB
7637 * coding.h (coding, code_convert_region, encode_coding_gap):
7638 Remove decls.
74ab6df5
PE
7639 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7640 (iso_code_class, detect_coding, code_convert_region): Now static.
7641 (encode_coding_gap): Remove; unused.
7642
38dfbee1
PE
7643 * chartab.c (chartab_chars, chartab_bits): Now static.
7644
a2cb4e63
PE
7645 * charset.h (charset_iso_8859_1): Remove decl.
7646 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7647 Now static.
7648
127198fd
PE
7649 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7650 * ccl.c (Vccl_program_table): Now static.
7651 (check_ccl_update): Remove; unused.
7652
d85b608f
PE
7653 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7654 * category.h: ... from here.
7655 * category.c (check_category_table, set_category_set): Now static.
7656
31cd66f3
PE
7657 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7658 * lisp.h: Remove these decls.
7659
c358e587
PE
7660 * buffer.c (buffer_count): Remove unused var.
7661
e78aecca
PE
7662 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7663 so that it's not optimized away.
7664 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7665 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7666 exported only to the debugger.
7667
e192d7d3 7668 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 7669 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 7670
92470028
PE
7671 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7672 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7673 was inaccessible from Lisp.
7674 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7675 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7676
244ed907
PE
7677 alloc.c: Import and export fewer symbols, and remove unused items.
7678 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7679 is defined.
7680 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7681 it's not optimized away by whole-program optimization.
7682 (message_enable_multibyte, free_misc): Remove.
7683 (catchlist, handlerlist, mark_backtrace):
7684 Declare only if BYTE_MARK_STACK.
7685 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7686 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7687 (message_enable_multibyte): Remove decl.
7688 (free_misc, interval_free_list, float_block, float_block_index):
7689 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7690 (cons_free_list, last_marked_index):
7691 Now static.
7692 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7693 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7694 (mark_backtrace): Define only if BYTE_MARK_STACK.
7695 * xdisp.c (message_enable_multibyte): Now static.
7696
61c2b50e 7697 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
7698 This makes it easier for human readers (and static analyzers)
7699 to see whether these variables are used from other modules.
7700 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7701 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7702 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7703 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7704 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7705 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7706 * xmenu.c, xselect.c:
7707 Declare Q* vars static if they are not used in other modules.
7708 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7709 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7710 Remove decls of unexported vars.
7711 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7712
95c82688
PE
7713 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7714
16a97296
PE
7715 Make Emacs functions such as Fatom 'static' by default.
7716 This makes it easier for human readers (and static analyzers)
7717 to see whether these functions can be called from other modules.
7718 DEFUN now defines a static function. To make the function external
7719 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
7720 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7721 (Finit_image_library):
16a97296
PE
7722 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7723 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7724 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7725 Remove decls, since these functions are now static.
7726 (Funintern, Fget_internal_run_time): New decls, since these functions
7727 were already external.
95c82688 7728
16a97296
PE
7729 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7730 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7731 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7732 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7733 * keyboard.c, keymap.c, lread.c:
7734 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7735 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7736 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7737 Mark functions with DEFUE instead of DEFUN,
7738 if they are used in other modules.
7739 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7740 decls for now-static functions.
7741 * buffer.h (Fdelete_overlay): Remove decl.
7742 * callproc.c (Fgetenv_internal): Mark as internal.
7743 * composite.c (Fremove_list_of_text_properties): Remove decl.
7744 (Fcomposition_get_gstring): New forward static decl.
7745 * composite.h (Fcomposite_get_gstring): Remove decl.
7746 * dired.c (Ffile_attributes): New forward static decl.
7747 * doc.c (Fdocumntation_property): New forward static decl.
7748 * eval.c (Ffetch_bytecode): New forward static decl.
7749 (Funintern): Remove extern decl; now in .h file where it belongs.
7750 * fileio.c (Fmake_symbolic_link): New forward static decl.
7751 * image.c (Finit_image_library): New forward static decl.
7752 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7753 * intervals.h (Fprevious_property_change):
7754 (Fremove_list_of_text_properties): Remove decls.
7755 * keyboard.c (Fthis_command_keys): Remove decl.
7756 (Fcommand_execute): New forward static decl.
7757 * keymap.c (Flookup_key): New forward static decl.
7758 (Fcopy_keymap): Now static.
7759 * keymap.h (Flookup_key): Remove decl.
7760 * process.c (Fget_process): New forward static decl.
7761 (Fprocess_datagram_address): Mark as internal.
7762 * syntax.c (Fsyntax_table_p): New forward static decl.
7763 (skip_chars): Remove duplicate decl.
7764 * textprop.c (Fprevious_property_change): New forward static decl.
7765 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7766 Now internal.
7767 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7768 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7769
785bbd42
PE
7770 * editfns.c (Fformat): Remove unreachable code.
7771
8b913b57
AS
77722011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7773
7774 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7775 change. (Bug#8496)
7776
a6744a35
EZ
77772011-04-13 Eli Zaretskii <eliz@gnu.org>
7778
7779 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7780 when at ZV. (Bug#8487)
7781
e7974947
AS
77822011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7783
baad03f0
AS
7784 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7785 (Bug#8437)
7786 * keyboard.c (parse_tool_bar_item): Likewise.
7787 * sound.c (sound_cleanup, alsa_close): Likewise.
7788 * termcap.c (tgetent): Likewise.
7789 * xfns.c (x_default_font_parameter): Likewise.
7790 * xsettings.c (read_and_apply_settings): Likewise.
7791
e7974947
AS
7792 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7793 (overrun_check_free): Protoize.
7794
28272684
PE
77952011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7796
7797 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7798 since callers should never pass a negative size.
7799 Change the signature to match that of plain 'read' and 'write'; see
7800 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7801 * lisp.h: Update prototypes of emacs_write and emacs_read.
7802
11997c76
EZ
78032011-04-11 Eli Zaretskii <eliz@gnu.org>
7804
7805 * xdisp.c (redisplay_window): Don't try to determine the character
7806 position of the scroll margin if the window start point w->startp
e896f03c 7807 is outside the buffer's accessible region. (Bug#8468)
11997c76 7808
8a2cbd72
EZ
78092011-04-10 Eli Zaretskii <eliz@gnu.org>
7810
7811 Fix write-region and its subroutines for buffers > 2GB.
7812 * fileio.c (a_write, e_write): Modify declaration of arguments and
7813 local variables to support buffers larger than 2GB.
7814 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7815
7816 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7817 argument, local variables, and return value.
7818
7819 * lisp.h: Update prototypes of emacs_write and emacs_read.
7820
7821 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7822
4073e537 78232011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 7824
1ebfdcb6
PE
7825 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7826
b2ded58d
PE
7827 Fix more problems found by GCC 4.6.0's static checks.
7828
7d66342c
PE
7829 * xdisp.c (vmessage): Use a better test for character truncation.
7830
bbf47d44
PE
7831 * charset.c (load_charset_map): <, not <=, for optimization,
7832 and to avoid potential problems with integer overflow.
9248994d 7833 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 7834 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 7835 * editfns.c (Fformat): Likewise.
1e69125e 7836 * syntax.c (skip_chars): Likewise.
3befa583 7837
e3019616
PE
7838 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7839 This also lets GCC 4.6.0 generate slightly better loop code.
7840
becfa255
PE
7841 * callint.c (Fcall_interactively): <, not <=, for optimization.
7842 (Fcall_interactively): Count the number of arguments produced,
7843 not the number of arguments given. This is simpler and lets GCC
7844 4.6.0 generate slightly better code.
7845
dae0cd48
PE
7846 * ftfont.c: Distingish more carefully between FcChar8 and char.
7847 The previous code passed unsigned char * to a functions like
7848 strlen and xstrcasecmp that expect char *, which does not
7849 conform to the C standard.
7850 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7851 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7852 char * when the C standard requires it.
7853
76032d70
PE
7854 * keyboard.c (read_char): Remove unused var.
7855
eb3f1cc8
PE
7856 * eval.c: Port to Windows vsnprintf (Bug#8435).
7857 Include <limits.h>.
7858 (SIZE_MAX): Define if the headers do not.
7859 (verror): Do not give up if vsnprintf returns a negative count.
7860 Instead, grow the buffer. This ports to Windows vsnprintf, which
7861 does not conform to C99. Problem reported by Eli Zaretskii.
7862 Also, simplify the allocation scheme, by avoiding the need for
7863 calling realloc, and removing the ALLOCATED variable.
7864
70476b54
PE
7865 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7866
12020a9e
PE
7867 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7868 But keep the doprint source code for now, as we might revamp it
7869 and use it again (Bug#8435).
ea6c7ae6
PE
7870 * lisp.h (doprnt): Remove.
7871 * Makefile.in (base_obj): Remove doprnt.o.
7872 * deps.mk (doprnt.o): Remove.
7873
5fdb398c
PE
7874 error: Print 32- and 64-bit integers portably (Bug#8435).
7875 Without this change, on typical 64-bit hosts error ("...%d...", N)
7876 was used to print both 32- and 64-bit integers N, which relied on
7877 undefined behavior.
61bdb816 7878 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
7879 * lisp.h (error, verror): Mark as printf-like functions.
7880 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7881 Report overflow in size calculations when allocating printf buffer.
7882 Do not truncate output string at its first null byte.
7883 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7884 Truncate the output at a character boundary, since vsnprintf does not
7885 do that.
7886 * charset.c (check_iso_charset_parameter): Convert internal
7887 character to string before calling 'error', since %c now has the
7888 printf meaning.
7889 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7890 overflow when computing char to be passed to 'error'. Do not
7891 pass Lisp_Object to 'error'; pass the integer instead.
7892 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7893 formatted with plain %d.
7894
b189fa66
PE
7895 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7896
bff87ef0
PE
7897 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7898
7e2cac20
PE
7899 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7900
ce4d90b5
PE
7901 * xterm.c (x_catch_errors): Remove duplicate declaration.
7902
266c9547
PE
7903 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7904
79c49ad2
PE
7905 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7906
368f4090
JM
79072011-04-10 Jim Meyering <meyering@redhat.com>
7908
7909 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7910 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7911 return ssize_t not "int", and use size_t as the buffer length.
7912 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7913 * gnutls.h: Update declarations.
7914 * process.c (read_process_output): Use ssize_t, to match.
7915 (send_process): Likewise.
7916
a32d4040
CY
79172011-04-09 Chong Yidong <cyd@stupidchicken.com>
7918
7919 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7920
8546720e 79212011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 7922
04f2d78b
CB
7923 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7924 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 7925
8546720e
GM
7926 * xterm.c (handle_one_xevent):
7927 * xmenu.c (create_and_show_popup_menu):
7928 * xselect.c (x_decline_selection_request)
7929 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 7930
0a2f5c1a 79312011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
7932
7933 Fix some uses of `int' instead of EMACS_INT.
7934 * search.c (string_match_1, fast_string_match)
7935 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7936 (scan_buffer, find_next_newline_no_quit)
7937 (find_before_next_newline, search_command, Freplace_match)
7938 (Fmatch_data): Make some `int' variables be EMACS_INT.
7939
7940 * xdisp.c (display_count_lines): 3rd argument and return value now
7941 EMACS_INT. All callers changed.
7942 (pint2hrstr): Last argument is now EMACS_INT.
7943
7944 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7945 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7946 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7947 (decode_coding_utf_16, decode_coding_emacs_mule)
7948 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7949 (decode_coding_ccl, decode_coding_charset)
7950 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7951 (decode_coding_iso_2022, decode_coding_emacs_mule)
7952 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7953 <char_offset, last_offset>: Declare EMACS_INT.
7954 (encode_coding_utf_8, encode_coding_utf_16)
7955 (encode_coding_emacs_mule, encode_invocation_designation)
7956 (encode_designation_at_bol, encode_coding_iso_2022)
7957 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7958 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7959 Declare EMACS_INT.
7960 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7961 (encode_invocation_designation): Last argument P_NCHARS is now
7962 EMACS_INT.
7963 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7964 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7965
7966 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7967 All users changed.
7968
7969 * ccl.c (Fccl_execute_on_string): Declare some variables
7970 EMACS_INT.
7971
8546720e 79722011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
7973
7974 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7975
4e19a977
CS
79762011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7977
7978 * process.c (Fformat_network_address): Doc fix.
7979
87302331
R
79802011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7981
ee7683eb 7982 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 7983
cbb59342
CY
79842011-04-08 Chong Yidong <cyd@stupidchicken.com>
7985
7986 * keyboard.c (read_char): Call Lisp function help-form-show,
7987 instead of using internal_with_output_to_temp_buffer.
7988 (Qhelp_form_show): New var.
e0d38eeb 7989 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
7990
7991 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7992
7993 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7994
e67a13ab
CY
79952011-04-06 Chong Yidong <cyd@stupidchicken.com>
7996
04f2d78b
CB
7997 * process.c (Flist_processes): Remove to Lisp.
7998 (list_processes_1): Delete.
e67a13ab 7999
973f782d
EZ
80002011-04-06 Eli Zaretskii <eliz@gnu.org>
8001
7c106b1e
EZ
8002 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8003
973f782d
EZ
8004 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8005
41cf7d1a 80062011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 8007
ca23cc88
PE
8008 Fix more problems found by GCC 4.6.0's static checks.
8009
f390e2d5
PE
8010 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8011
42eea0d0
PE
8012 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8013
b69769da 8014 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 8015
f9541e84
PE
8016 * xdisp.c (vmessage): Mark as a printf-like function.
8017
13841b55
PE
8018 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8019
c136c10f
PE
8020 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8021
5e2d4a30
PE
8022 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8023 printf-like functions.
8024 (tiff_load): Add casts to remove these marks before passing them
8025 to system-supplied API.
8026
583f48b9
PE
8027 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8028
b25d760e
PE
8029 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8030 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
8031 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8032 directly, rather than having caller test rule sign. This avoids
8033 some unnecessary tests.
8034 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8035 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8036 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 8037
bc7b6697 8038 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 8039 (xfont_open): Avoid unnecessary tests.
bc7b6697 8040
27ccc379
PE
8041 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8042
dcd5c89a
PE
8043 * composite.h, composite.c (composition_gstring_put_cache):
8044 Use EMACS_INT, not int, for length.
8045
b13a45c6
PE
8046 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8047 breaking out part of COMPOSITION_DECODE_RULE.
8048 (COMPOSITION_DECODE_RULE): Use it.
8049 * composite.c (get_composition_id): Remove unused local vars,
8050 by using the new macro.
8051
1e792e4d
PE
8052 * textprop.c (set_text_properties_1): Change while to do-while,
8053 since the condition is always true at first.
8054
dc6c6455 8055 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
8056 (interval_deletion_adjustment): Return unsigned value.
8057 All uses changed.
dc6c6455 8058
aba7731a
PE
8059 * process.c (list_processes_1, create_pty, read_process_output):
8060 (exec_sentinel): Remove vars that were set but not used.
afd4052b 8061 (create_pty): Remove unnecessary "volatile"s.
bc57d757 8062 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 8063 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 8064 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 8065
fdfc4bf3
PE
8066 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8067
fca8fe46 8068 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 8069 (update_syntax_table): Use unsigned instead of int.
fca8fe46 8070
06a0259a 8071 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 8072 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 8073 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 8074
e7b9e80f
PE
8075 * print.c (print_error_message): Avoid int overflow.
8076
56201685
PE
8077 * font.c (font_list_entities): Redo for clarity,
8078 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8079
78834453 8080 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 8081 (font_score): Avoid potential overflow in diff calculation.
78834453 8082
0bc0b309 8083 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 8084 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 8085
e610eaca
PE
8086 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8087
b895abce
PE
8088 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8089 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8090 can always succeed if overflow has undefined behavior.
8091
1f1d9321 8092 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 8093 (wordify): Omit three unnecessary tests.
1f1d9321 8094
c59478bc
PE
8095 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8096 All callers changed. This avoids the need for an unused var.
8097
79b73827
PE
8098 * casefiddle.c (casify_region): Remove var that is set but not used.
8099
a4db5dfe
PE
8100 * dired.c (file_name_completion): Remove var that is set but not used.
8101
43aae36e
PE
8102 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8103
2a47c44d 8104 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 8105 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 8106
a37c69bf
PE
8107 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8108 Check for integer overflow on size calculations.
8109
328ab8e7
PE
8110 * buffer.c (Fprevious_overlay_change): Remove var that is set
8111 but not used.
8112
e5a2a5cb
PE
8113 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8114 Remove vars that are set but not used.
8d84a6eb 8115 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 8116 (timer_check_2): Mark vars as initialized.
e5a2a5cb 8117
a60e5f68
PE
8118 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8119
f661cb61 8120 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 8121 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 8122
f0397f5a
PE
8123 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8124 that are set but not used.
8125
8664db06 8126 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 8127 if XCreateBitmapFromData fails (Bug#8410).
8664db06 8128
6abdaa4a
PE
8129 * xselect.c (x_get_local_selection, x_handle_property_notify):
8130 Remove vars that are set but not used.
8131
0ce7538d 8132 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 8133 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 8134
9ae848fc
PE
8135 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8136 Remove var that is set but not used.
0b918413
PE
8137 (scroll_bar_windows_size): Now size_t, not int.
8138 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8139 Check for overflow.
9ae848fc 8140
a5a62657
PE
8141 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8142 (map_tty_color) [!defined MSDOS]: Likewise.
8143
5c5cdd39
PE
8144 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8145
66ebf983
PE
8146 * coding.c: Remove vars that are set but not used.
8147 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8148 All callers changed.
8149 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8150 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8151 (decode_coding_charset): Remove vars that are set but not used.
8152
1be4d761
PE
8153 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8154 that is set but not used.
8155
47553fa8
PE
8156 * print.c (print_object): Remove var that is set but not used.
8157
1f7196bf 8158 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
8159 The gnulib version avoids calling malloc in the usual case,
8160 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8161 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8162 * filelock.c (current_lock_owner): Likewise.
8163 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8164 * sysdep.c: Include allocator.h, careadlinkat.h.
8165 (emacs_no_realloc_allocator): New static constant.
8166 (emacs_readlink): New function.
fdb61804
PE
8167 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8168 ../lib/careadlinkat.h.
d1fdcab7 8169
f84c17c7
SM
81702011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8171
8172 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8173 first non-nil return value).
8174
ef3862ad
JD
81752011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8176
8177 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8178 if not defined (Bug#8403).
8179
376a7006
JB
81802011-04-02 Juanma Barranquero <lekktu@gmail.com>
8181
8182 * xdisp.c (display_count_lines): Remove parameter `start',
8183 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8184 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8185 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8186 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8187 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8188 and thereabouts. All callers changed.
8189 (get_per_char_metric): Remove parameter `f', unused since
8190 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8191
6ca3801d
JM
81922011-04-02 Jim Meyering <meyering@redhat.com>
8193
8194 do not dereference NULL upon failed strdup
8195 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8196 (ns_get_family): Likewise.
8197
d8e2b5ba
JB
81982011-04-02 Juanma Barranquero <lekktu@gmail.com>
8199
8200 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8201
8c74fcbd
JD
82022011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8203
8204 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8205 later (Bug#8403).
8206
7200d79c
SM
82072011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8208
03408648 8209 Add lexical binding.
7200d79c 8210
03408648
SM
8211 * window.c (Ftemp_output_buffer_show): New fun.
8212 (Fsave_window_excursion):
8213 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8214
8215 * lread.c (lisp_file_lexically_bound_p): New function.
8216 (Fload): Bind Qlexical_binding.
8217 (readevalloop): Remove `evalfun' arg.
8218 Bind Qinternal_interpreter_environment.
8219 (Feval_buffer): Bind Qlexical_binding.
8220 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8221 Mark as dynamic.
8222 (syms_of_lread): Declare `lexical-binding'.
8223
8224 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8225
8226 * keyboard.c (eval_dyn): New fun.
8227 (menu_item_eval_property): Use it.
ca105506
SM
8228
8229 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 8230
03408648
SM
8231 * fns.c (concat, mapcar1): Accept byte-code-functions.
8232
8233 * eval.c (Fsetq): Handle lexical vars.
8234 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8235 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8236 (FletX, Flet): Obey lexical binding.
8237 (Fcommandp): Handle closures.
8238 (Feval): New `lexical' arg.
8239 (eval_sub): New function extracted from Feval. Use it almost
8240 everywhere where Feval was used. Look up vars in lexical env.
8241 Handle closures.
8242 (Ffunctionp): Move from subr.el.
8243 (Ffuncall): Handle closures.
8244 (apply_lambda): Remove `eval_flags'.
8245 (funcall_lambda): Handle closures and new byte-code-functions.
8246 (Fspecial_variable_p): New function.
8247 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8248 but without exporting it to Lisp.
23aba0ea 8249
23aba0ea 8250 * doc.c (Fdocumentation, store_function_docstring):
03408648 8251 * data.c (Finteractive_form): Handle closures.
23aba0ea 8252
03408648
SM
8253 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8254 interactive spec.
ba83908c 8255
04f2d78b
CB
8256 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8257 New byte-codes.
03408648
SM
8258 (exec_byte_code): New function extracted from Fbyte_code to handle new
8259 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 8260
03408648 8261 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 8262
03408648 8263 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 8264
e2abce01
JB
82652011-03-31 Juanma Barranquero <lekktu@gmail.com>
8266
8267 * xdisp.c (redisplay_internal): Fix prototype.
8268
63696a73 82692011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 8270
63696a73 8271 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
8272 (try_scrolling): Use it when setting scroll_limit.
8273 Limit scrolling to 100 screen lines.
63696a73
EZ
8274 (redisplay_window): Even when falling back on "recentering",
8275 position point in the window according to scroll-conservatively,
8276 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8277
8278 (try_scrolling): When point is above the window, allow searching
8279 as far as scroll_max, or one screenful, to compute vertical
8280 distance from PT to the scroll margin position. This prevents
8281 try_scrolling from unnecessarily failing when
8282 scroll-conservatively is set to a value slightly larger than the
8283 window height. Clean up the case of PT below the margin at bottom
8284 of window: scroll_max can no longer be INT_MAX. When aggressive
8285 scrolling is in use, don't let point enter the opposite scroll
8286 margin as result of the scroll.
8287 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
8288 threshold of 100 lines for never-recentering scrolling.
8289
e4cc2dfc
JB
82902011-03-31 Juanma Barranquero <lekktu@gmail.com>
8291
8292 * dispextern.h (move_it_by_lines):
8293 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8294 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8295 (message_log_check_duplicate): Remove parameters `prev_bol' and
8296 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8297 (redisplay_internal): Remove parameter `preserve_echo_area',
8298 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8299
8300 * indent.c (Fvertical_motion):
8301 * window.c (window_scroll_pixel_based, Frecenter):
8302 Don't pass `need_y_p' to `move_it_by_lines'.
8303
1c470562
SM
83042011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8305
44f230aa
SM
8306 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8307 steal a few bits to be more compact.
8308 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8309 Remove unneeded casts.
8310
1c470562
SM
8311 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8312
888adce9
ZK
83132011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8314
8315 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8316 binding" message (bug#7967).
8317
f838ed7b
PE
83182011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8319
77861b95
PE
8320 Fix more problems found by GCC 4.6.0's static checks.
8321
de6dbc14
PE
8322 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8323 Remove unused local var.
8324
f838ed7b
PE
8325 * editfns.c (Fmessage_box): Remove unused local var.
8326
792c7b2b
PE
8327 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8328 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8329 Omit unused local vars.
c499e557 8330 * window.c (shrink_windows): Omit unused local var.
b01a1c29 8331 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
8332 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8333 Omit unused local var.
8334
ba0165e1
PE
8335 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8336 Don't assume string length fits in int.
32ad8845 8337 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 8338 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 8339
3c59b4c9
PE
8340 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8341 instead of alloca (Bug#8344).
8342
a3eed478 8343 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 8344 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 8345
eb4d412d
PE
8346 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8347
1658b401
PE
8348 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8349 concerns.
8350
8351 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8352
8353 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 8354
9a2c6e05
PE
8355 * keyboard.c (syms_of_keyboard): Use the same style as later
8356 in this function when indexing through an array. This also
8357 works around GCC bug 48267.
8358
03d0a109
PE
8359 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8360
44f730c8
PE
8361 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8362
fe75f926
PE
8363 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8364 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8365
ffa8c828
PE
8366 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8367 This avoids undefined behavior on integer overflow, and is a bit
8368 more convenient anyway since it is compared to a size_t variable.
8369
c5101a77
PE
8370 Variadic C functions now count arguments with size_t, not int.
8371 This avoids an unnecessary limitation on 64-bit machines, which
8372 caused (substring ...) to crash on large vectors (Bug#8344).
8373 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8374 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 8375 All variadic functions and their callers changed accordingly.
c5101a77
PE
8376 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8377 * data.c (arith_driver, float_arith_driver): Likewise.
8378 * editfns.c (general_insert_function): Likewise.
8379 * eval.c (struct backtrace.nargs, interactive_p)
8380 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8381 (funcall_lambda, mark_backtrace): Likewise.
8382 * fns.c (concat): Likewise.
8383 * frame.c (x_set_frame_parameters): Likewise.
8384 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8385 0 if not found, not -1. All callers changed.
8386
dd3f25f7
PE
8387 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8388 (stack_copy_size): Now size_t, not int.
8389 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8390
461c2ab9
JB
83912011-03-28 Juanma Barranquero <lekktu@gmail.com>
8392
8393 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8394 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8395 All callers changed.
8396
8397 * lisp.h (multibyte_char_to_unibyte):
8398 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8399 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8400 * character.h (CHAR_TO_BYTE8):
8401 * cmds.c (internal_self_insert):
8402 * editfns.c (general_insert_function):
8403 * keymap.c (push_key_description):
8404 * search.c (Freplace_match):
8405 * xdisp.c (message_dolog, set_message_1): All callers changed.
8406
f6d62986
SM
84072011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8408
8409 * keyboard.c (safe_run_hook_funcall): New function.
8410 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8411 don't set the hook to nil, but remove the offending function instead.
8412 (Qcommand_hook_internal): Remove, unused.
8413 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8414 Vcommand_hook_internal.
8415
8416 * eval.c (enum run_hooks_condition): Remove.
8417 (funcall_nil, funcall_not): New functions.
8418 (run_hook_with_args): Call each function through a `funcall' argument.
8419 Remove `cond' argument, now redundant.
8420 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8421 (Frun_hook_with_args_until_failure): Adjust accordingly.
8422 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8423
1db5b1ad
JB
84242011-03-28 Juanma Barranquero <lekktu@gmail.com>
8425
8426 * dispextern.h (string_buffer_position): Remove declaration.
8427
8428 * print.c (strout): Remove parameter `multibyte', unused since
8429 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8430
8431 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8432 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8433 All callers changed.
8434
8435 * w32.c (_wsa_errlist): Use braces for struct initializers.
8436
8437 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8438 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8439 All callers changed.
8440 (string_buffer_position): Likewise. Also, make static (it's never
8441 used outside xdisp.c).
8442 (cursor_row_p): Remove parameter `w', unused since
8443 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8444 (decode_mode_spec): Remove parameter `precision', introduced during
8445 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8446 All callers changed.
8447
5ffb62aa
JD
84482011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8449
8450 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8451
461c2ab9 84522011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
8453
8454 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8455 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8456 (ns_update_auto_hide_menu_bar): New functions.
8457 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8458 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8459 ns_constrain_all_frames.
8460 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8461 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8462
5c380ffb
JD
84632011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8464
8465 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8466
9af30bdf
GM
84672011-03-27 Glenn Morris <rgm@gnu.org>
8468
8469 * syssignal.h: Replace RETSIGTYPE with void.
8470 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8471 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8472 Replace SIGTYPE with void everywhere.
8473 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8474 * s/template.h (SIGTYPE): Remove commented out definition.
8475
e2abce01
JB
84762011-03-26 Eli Zaretskii <eliz@gnu.org>
8477
8478 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8479 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8480
f868cd8a
JB
84812011-03-26 Juanma Barranquero <lekktu@gmail.com>
8482
59eb0929
JB
8483 * w32.c (read_unc_volume): Use parameter `henum', instead of
8484 global variable `wget_enum_handle'.
8485
8486 * keymap.c (describe_vector): Remove parameters `indices' and
8487 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8488 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8489
f868cd8a
JB
8490 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8491
8492 * keyboard.c (timer_check): Remove parameter `do_it_now',
8493 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8494 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8495 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8496
8497 * keyboard.c (read_char):
8498 * w32menu.c (w32_menu_display_help):
8499 * xmenu.c (show_help_event, menu_help_callback):
8500 Adjust calls to `show_help_echo'.
8501
8502 * gtkutil.c (xg_maybe_add_timer):
8503 * keyboard.c (readable_events):
8504 * process.c (wait_reading_process_output):
8505 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8506
8507 * insdel.c (adjust_markers_gap_motion):
8508 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8509 (gap_left, gap_right): Don't call it.
8510
2ecf6fdb
CY
85112011-03-25 Chong Yidong <cyd@stupidchicken.com>
8512
8513 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8514 incurred during fontification.
8515
6b1f9ba4
JB
85162011-03-25 Juanma Barranquero <lekktu@gmail.com>
8517
8518 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8519 (DEFVAR_PER_BUFFER): Don't pass it.
8520
8521 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8522 (scrolling_window): Don't pass it.
8523
0f4a96b5
JB
85242011-03-25 Juanma Barranquero <lekktu@gmail.com>
8525
8526 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8527
8528 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8529 and `suffix'.
8530 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8531 of variables specific to SELinux and computation of `encoded_absname'.
8532
8533 * image.c (XPutPixel): Remove unused variable `height'.
8534
8535 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8536
8537 * unexw32.c (get_section_info): Remove unused variable `section'.
8538
8539 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8540 (system_process_attributes): Remove unused variable `sess'.
8541 (sys_read): Remove unused variable `err'.
8542
8543 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8544 (w32_wnd_proc): Remove unused variable `isdead'.
8545 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8546 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8547 (x_create_tip_frame): Remove unused variable `tem'.
8548
8549 * w32inevt.c (w32_console_read_socket):
8550 Remove unused variable `no_events'.
8551
8552 * w32term.c (x_draw_composite_glyph_string_foreground):
8553 Remove unused variable `width'.
8554
1149507c
JB
85552011-03-24 Juanma Barranquero <lekktu@gmail.com>
8556
8557 * w32term.c (x_set_glyph_string_clipping):
8558 Don't pass uninitialized region to CombineRgn.
8559
9c88f339
JB
85602011-03-23 Juanma Barranquero <lekktu@gmail.com>
8561
8562 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8563 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8564 (Fx_close_connection): Remove unused variable `i'.
8565
8566 * w32font.c (w32font_draw): Return number of glyphs.
8567 (w32font_open_internal): Remove unused variable `i'.
8568 (w32font_driver): Add missing initializer.
8569
8570 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8571 (fill_in_menu): Remove unused variable `items_added'.
8572
8573 * w32term.c (last_mouse_press_frame): Remove static global variable.
8574 (w32_clip_to_row): Remove unused variable `f'.
8575 (x_delete_terminal): Remove unused variable `i'.
8576
8577 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8578 (NOTHING): Remove unused static global variable.
8579 (uniscribe_check_otf): Remove unused variable `table'.
8580 (uniscribe_font_driver): Add missing initializers.
8581
dee091a3
JD
85822011-03-23 Julien Danjou <julien@danjou.info>
8583
8584 * term.c (Fsuspend_tty, Fresume_tty):
8585 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8586 * window.c (temp_output_buffer_show):
8587 * insdel.c (signal_before_change):
8588 * frame.c (Fhandle_switch_frame):
8589 * fileio.c (Fdo_auto_save):
8590 * emacs.c (Fkill_emacs):
8591 * editfns.c (save_excursion_restore):
8592 * cmds.c (internal_self_insert):
8593 * callint.c (Fcall_interactively):
8594 * buffer.c (Fkill_all_local_variables):
8595 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8596 Use Frun_hooks.
0f4a96b5 8597 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 8598 unconditionally since it does the check itself.
dee091a3 8599
2c520ab5 86002011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 8601
c9c49752
PE
8602 Fix more problems found by GCC 4.5.2's static checks.
8603
8abc3f12
PE
8604 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8605 the first time through the loop, since we know p0 < p1 then.
8606 This also avoids a gcc -Wstrict-overflow warning.
8607
a2d26660
PE
8608 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8609 leading to a memory leak, possible in functions like
8610 load_charset_map_from_file that can allocate an unbounded number
b12ef411 8611 of objects (Bug#8318).
a2d26660 8612
916c72e9
PE
8613 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8614 that could (at least in theory) be that large.
8615
19ab8a18
PE
8616 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8617 This is less likely to overflow, and avoids undefined behavior if
8618 overflow does occur. All callers changed. Use strtoul to scan
8619 for the unsigned long integer.
b7cbbd6f
PE
8620 (pint2hrstr): Simplify and tune code slightly.
8621 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 8622
f0641eff
PE
8623 * scroll.c (do_scrolling): Work around GCC bug 48228.
8624 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8625
7f650bb9
PE
8626 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8627 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
8628 (validate_x_resource_name): Simplify count usage.
8629 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 8630
37dd57d1
PE
8631 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8632 fail (Bug#8306).
81e56e61 8633
699979fc 8634 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 8635
401bf9b4
PE
8636 * process.c (Fmake_network_process): Use socklen_t, not int,
8637 where POSIX says socklen_t is required in portable programs.
8638 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 8639 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
8640 (Fmake_network_process, server_accept_connection):
8641 (wait_reading_process_output, read_process_output):
8642 Likewise.
8643
b93aacde
PE
8644 * process.c: Rename or move locals to avoid shadowing.
8645 (list_processes_1, Fmake_network_process):
8646 (read_process_output_error_handler, exec_sentinel_error_handler):
8647 Rename or move locals.
4dc343ee 8648 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 8649 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 8650 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 8651 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 8652 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 8653
af8a867c 8654 Make tparam.h and terminfo.c consistent.
44f230aa
SM
8655 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8656 Include tparam.h instead, since it declares them.
af8a867c
PE
8657 * cm.h (PC): Remove extern decl; tparam.h now does this.
8658 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8659 * terminfo.c: Include tparam.h, to check interfaces.
8660 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8661 (tparam): Adjust signature to match interface in tparam.h;
8662 this removes some undefined behavior. Check that outstring and len
8663 are zero, which they always are with Emacs.
8664 * tparam.h (PC, BC, UP): New extern decls.
8665
0248044d 8666 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 8667 (xftfont_open): Rename locals to avoid shadowing.
0248044d 8668
8ff096c1 8669 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
8670 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8671 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 8672 (ftfont_list): Remove unused local.
49eaafba
PE
8673 (get_adstyle_property, ftfont_pattern_entity):
8674 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8675 Rename locals to avoid shadowing.
8ff096c1 8676
e2be39f6
PE
8677 * xfont.c (xfont_list_family): Mark var as initialized.
8678
c9735e30
PE
8679 * xml.c (make_dom): Now static.
8680
8f5201ae
PE
8681 * composite.c (composition_compute_stop_pos): Rename local to
8682 avoid shadowing.
b246f932
PE
8683 (composition_reseat_it): Remove unused locals.
8684 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 8685 (composition_update_it): Mark var as initialized.
11b61122
PE
8686 (find_automatic_composition): Mark vars as initialized,
8687 with a FIXME (Bug#8290).
8f5201ae 8688
760fbc2c
PE
8689 character.h: Rename locals to avoid shadowing.
8690 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8691 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8692 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8693 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8694 to avoid shadowing.
8695
ff08eb85
PE
8696 * textprop.c (property_change_between_p): Remove; unused.
8697
fc7bf025
PE
8698 * intervals.c (interval_start_pos): Now static.
8699
235d7abc
PE
8700 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8701
44f230aa
SM
8702 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8703 Rename locals to avoid shadowing.
3e7d6594 8704
50060332
PE
8705 * sound.c (wav_play, au_play, Fplay_sound_internal):
8706 Fix pointer signedness.
d01f234b 8707 (alsa_choose_format): Remove unused local var.
c83b8872
PE
8708 (wav_play): Initialize a variable to 0, to prevent undefined
8709 behavior (Bug#8278).
50060332 8710
c4fc4e30
PE
8711 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8712
918436ed
PE
8713 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8714
c939f91b
PE
8715 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8716 clobbering (Bug#8298).
b9c7f648
PE
8717 * sysdep.c (sys_subshell): Likewise.
8718 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 8719
6bd8c144
PE
8720 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8721 This should get cleaned up, so that child_setup has the
8722 same signature on all platforms.
8723
7710357c 8724 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 8725 (relocate_fd): Rename locals to avoid shadowing.
7710357c 8726
c59da222
CY
87272011-03-22 Chong Yidong <cyd@stupidchicken.com>
8728
8729 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8730 not to be necessary, and produces flickering.
8731
66b87493
GM
87322011-03-20 Glenn Morris <rgm@gnu.org>
8733
8734 * config.in: Remove file.
8735
45b6f6d5
JB
87362011-03-20 Juanma Barranquero <lekktu@gmail.com>
8737
8738 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8739 are now in src/globals.h.
8740 (syms_of_minibuf): Remove spurious & from previous change.
8741
cd394be1 87422011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
8743
8744 * minibuf.c (completing-read-function): New variable.
8745 (completing-read-default): Rename from completing-read.
8746 (completing-read): Call completing-read-function.
8747
b14e3e21
CY
87482011-03-19 Juanma Barranquero <lekktu@gmail.com>
8749
8750 * xfaces.c (Fx_load_color_file):
8751 Read color file from absolute filename (bug#8250).
8752
f2b726e6
JB
87532011-03-19 Juanma Barranquero <lekktu@gmail.com>
8754
8755 * makefile.w32-in: Update dependencies.
8756
09f6ff02
EZ
87572011-03-17 Eli Zaretskii <eliz@gnu.org>
8758
8759 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8760
29a6015a
PE
87612011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8762
a3a6c54e
PE
8763 Fix more problems found by GCC 4.5.2's static checks.
8764
b766f867
PE
8765 * process.c (make_serial_process_unwind, send_process_trap):
8766 (sigchld_handler): Now static.
8767
be02381c
PE
8768 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8769 That way, the code declares only the vars that it needs.
8770 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8771 * s/cygwin.h (PTY_ITERATION): Likewise.
8772 * s/darwin.h (PTY_ITERATION): Likewise.
8773 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8774
57048744
PE
8775 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8776 * process.c (allocate_pty): Don't declare stb unless it's needed.
8777
7914961c 8778 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
8779 (CONSTANTLIM): Remove; unused.
8780 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8781 Define only if needed.
7914961c 8782
b3967b18
PE
8783 * unexelf.c (unexec): Name an expression,
8784 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
8785 Use a different way to cause a compilation error if anyone uses
8786 n rather than nn, a way that does not involve shadowing.
73366a00 8787 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 8788
29a6015a
PE
8789 * deps.mk (unexalpha.o): Remove; unused.
8790
43cfc33e 8791 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 8792 * unexec.h: New file.
ce701a33
PE
8793 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8794 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8795 Depend on unexec.h.
8796 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8797 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8798 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 8799 Change as necessary to match prototype in unexec.h.
ce701a33 8800
01f44d5a
PE
8801 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8802 shadowing.
4f63c6bb 8803 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 8804
a6670b0b
PE
8805 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8806 Rename locals to avoid shadowing.
8807
cef2010d 8808 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 8809 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 8810
d4d7173a
PE
8811 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8812
f08b802a
PE
8813 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8814 warning when compiling print.c.
8815
3ddb0639
PE
8816 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8817 instead of using an uninitialized var.
5ad03b97 8818 (font_sort_entities): Mark var as initialized.
3ddb0639 8819
170a2692
PE
8820 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8821
e663c700
PE
8822 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8823 pointers to constants.
89bc529a 8824 (font_parse_fcname): Remove unused vars.
7b81e2d0 8825 (font_delete_unmatched): Now static.
ea838e10 8826 (font_get_spec): Remove; unused.
13a547c6
PE
8827 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8828 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8829 Rename or move locals to avoid shadowing.
e663c700 8830
2a80c887 8831 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 8832 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 8833
1384fa33 8834 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 8835 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 8836
8b2c52e9
PE
8837 * alloc.c (mark_backtrace): Move decl from here ...
8838 * lisp.h: ... to here, so that it can be checked.
8839
475545b5 8840 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 8841 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
8842 (lisp_indirect_variable): Name an expression,
8843 to avoid gcc -Wbad-function-cast warning.
1faed8ae 8844 (Fdefvar): Rename locals to avoid shadowing.
475545b5 8845
b1349114 8846 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 8847 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 8848 Use const pointer when appropriate.
b1349114 8849
a2928364
PE
8850 * lisp.h (get_system_name, get_operating_system_release):
8851 Move decls here, to check interfaces.
8852 * process.c (get_operating_system_release): Move decl to lisp.h.
8853 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
8854 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8855 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8856 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
8857 (Fformat_time_string, Fencode_time, Finsert_char):
8858 (Ftranslate_region_internal, Fformat):
8859 Rename or remove local vars to avoid shadowing.
9710023e 8860 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 8861
a415e694
PE
8862 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8863 avoid shadowing.
8864
8ef4622d
PE
8865 * lisp.h (eassert): Check that the argument compiles, even if
8866 ENABLE_CHECKING is not defined.
8867
946f9a5b
PE
8868 * data.c (Findirect_variable): Name an expression, to avoid
8869 gcc -Wbad-function-cast warning.
112396d6 8870 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 8871 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
8872 (Fmake_variable_buffer_local, Fmake_local_variable):
8873 Mark variables as initialized.
52746918 8874 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 8875
e5aab7e7 8876 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
8877 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8878 Rename locals to avoid shadowing.
dff45157
PE
8879 (mark_stack): Move local variables into the #ifdef region where
8880 they're used.
7bc26fdb
PE
8881 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8882 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8883 needed otherwise.
8884 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8885 (GC_STRING_CHARS): Remove; not used.
d40d4be1 8886 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 8887
e5aab7e7
PE
8888 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8889 avoids undefined behavior in theory.
8890
4da60324
PE
8891 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8892
88043301
PE
8893 Use functions, not macros, for up- and down-casing (Bug#8254).
8894 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8895 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8896 to use the following functions instead of these macros.
8897 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8898 EMACS_INT, since callers assume the returned value fits in int.
8899 (upcase1): Likewise, for UPCASE_TABLE.
8900 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 8901 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 8902 the race-condition problem in the old DOWNCASE.
88043301 8903
19ed5445
PE
8904 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8905 Rename locals to avoid shadowing.
8906 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
8907 (regex_compile, re_search_2, re_match_2_internal):
8908 Remove unused local vars.
952db0d7
PE
8909 (FREE_VAR): Rewrite so as not to use empty "else",
8910 which gcc can warn about.
da053e48 8911 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
8912 (RETALLOC_IF): Define only if needed.
8913 (WORDCHAR_P): Likewise. This one is never needed, but is used
8914 only in a comment talking about a compiler bug, so put inside
8915 the #if 0 of that comment.
8916 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8917 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8918 Remove; unused.
19ed5445 8919
1f3561e4 8920 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
8921 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8922 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 8923
ded6f8f7
PE
8924 * search.c (simple_search): Remove unused var.
8925
dbd37a95
PE
8926 * dired.c (compile_pattern): Move decl from here ...
8927 * lisp.h: ... to here, so that it can be checked.
8928 (struct re_registers): New forward decl.
8929
7e47afad
PE
8930 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8931
85f24f61
PE
8932 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8933 All uses changed.
8934 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8935 Rename locals to avoid shadowing.
5671df8f 8936 (Fvertical_motion): Mark locals as initialized.
85f24f61 8937
181aa2be 8938 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 8939 (casify_region): Mark local as initialized.
181aa2be 8940
930d429c
PE
8941 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8942
7082eac6
PE
8943 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8944 New macros, so that the caller can use some names other than
8945 gcpro1, gcpro2, etc.
8946 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8947 of the new macros.
8948 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8949 argument, for consistency with GCPRO2_VAR, etc: it is now the
8950 prefix of the variable, not the variable itself. All uses
8951 changed.
38b2c076
PE
8952 * dired.c (directory_files_internal, file_name_completion):
8953 Rename locals to avoid shadowing.
8954
15206ed9
PE
8955 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8956 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8957 dired.c's scmp function, had undefined behavior.
8958 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8959 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8960 * buffer.h: ... to here, because these macros use current_buffer,
8961 and the new implementation with inline functions needs to have
8962 current_buffer in scope now, rather than later when the macros
8963 are used.
8964 (downcase, upcase1): New static inline functions.
8965 (DOWNCASE, UPCASE1): Reimplement using these functions.
8966 This avoids undefined behavior in expressions like
8967 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8968 from race conditions in accessing the global variables
8969 case_temp1 and case_temp2.
8970 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8971 * lisp.h (case_temp1, case_temp2): Remove their decls.
8972 * character.h (ASCII_CHAR_P): Move from here ...
8973 * lisp.h: ... to here, so that the inline functions mentioned
8974 above can use them.
8975
4a6bea26
PE
8976 * dired.c (directory_files_internal_unwind): Now static.
8977
f14b7e14
PE
8978 * fileio.c (file_name_as_directory, directory_file_name):
8979 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8980 Now static.
2893f146
PE
8981 (file_name_as_directory): Use const pointers when appropriate.
8982 (Fexpand_file_name): Likewise. In particular, newdir might
8983 point at constant storage, so make it a const pointer.
fd4ead52 8984 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
8985 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8986 signedness issues.
f839df0c
PE
8987 (Fset_file_times, Finsert_file_contents, auto_save_error):
8988 Rename locals to avoid shadowing.
f14b7e14 8989
5716756e 8990 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
8991 (Ftry_completion, Fall_completions): Rename or remove locals
8992 to avoid shadowing.
5716756e 8993
b4c3046a
PE
8994 * marker.c (bytepos_to_charpos): Remove; unused.
8995
b45db522
PE
8996 * lisp.h (verify_bytepos, count_markers): New decls,
8997 so that gcc does not warn that these functions aren't declared.
8998
85876d07
PE
8999 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9000 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 9001 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 9002 (copy_text): Remove unused local var.
85876d07 9003
03d78a21 9004 * filelock.c (within_one_second): Now static.
b3dd38ab 9005 (lock_file_1): Rename local to avoid shadowing.
03d78a21 9006
5df8f01b
PE
9007 * buffer.c (fix_overlays_before): Mark locals as initialized.
9008 (fix_start_end_in_overlays): Likewise. This function should be
9009 simplified by using pointers-to-pointers, but that's a different
9010 matter.
b1d876f1 9011 (switch_to_buffer_1): Now static.
8f54f30a
PE
9012 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9013 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 9014
a70072c9 9015 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 9016 Fix pointer signedness issue.
edced198
PE
9017 (sys_subshell): Mark local as volatile if checking for lint,
9018 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 9019 (MAXPATHLEN): Define only if needed.
a70072c9 9020
a0977c44
PE
9021 * process.c (serial_open, serial_configure): Move decls from here ...
9022 * systty.h: ... to here, so that they can be checked.
9023
a884fdcc
PE
9024 * fns.c (get_random, seed_random): Move extern decls from here ...
9025 * lisp.h: ... to here, so that they can be checked.
9026
604efe86 9027 * sysdep.c (reset_io): Now static.
b8950c94 9028 (wait_for_termination_signal): Remove; unused.
604efe86 9029
38fc62d9
PE
9030 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9031 (copy_keymap_item, append_key, push_text_char_description):
9032 Now static.
1004a21a 9033 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 9034 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
9035 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9036 (describe_map_tree):
9037 Rename locals to avoid shadowing.
38fc62d9 9038
2f2650da
PE
9039 * keyboard.c: Declare functions static if they are not used elsewhere.
9040 (echo_char, echo_dash, cmd_error, top_level_2):
9041 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
9042 (read_char, kbd_buffer_get_event, make_lispy_position):
9043 (make_lispy_event, make_lispy_movement, apply_modifiers):
9044 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9045 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9046 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 9047 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 9048 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 9049
a053e86c 9050 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
9051 (mark_kboards): Move decl here ...
9052 * alloc.c (mark_kboards): ... from here.
a053e86c 9053
4752793e
PE
9054 * lisp.h (force_auto_save_soon): New decl.
9055
74f10ca7 9056 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
9057 (DEFINE_DUMMY_FUNCTION): New macro.
9058 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9059 Use it.
c03cd23f
PE
9060 (main): Add casts to avoid warnings
9061 if GCC considers string literals to be constants.
74f10ca7 9062
022e70d4
PE
9063 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9064
59d6fe83
PE
9065 * dbusbind.c: Pointer signedness fixes.
9066 (xd_signature, xd_append_arg, xd_initialize):
9067 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9068 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9069 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9070 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9071
78320123
PE
9072 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9073 if GCC considers string literals to be constants.
49cebcca 9074 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 9075
35ac2a97
SM
90762011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9077
fb103ca9
SM
9078 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9079 (print_preprocess, print_object): New macro to fix last change.
9080
35ac2a97
SM
9081 * print.c (print_preprocess): Don't forget font objects.
9082
62973b41
JB
90832011-03-16 Juanma Barranquero <lekktu@gmail.com>
9084
9085 * emacs.c (USAGE3): Doc fixes.
9086
0e48bb22
AS
90872011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9088
9089 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9090 structure.
9091
7684e57b
JB
90922011-03-14 Juanma Barranquero <lekktu@gmail.com>
9093
9094 * lisp.h (VWindow_system, Qfile_name_history):
9095 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9096 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9097 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9098
9099 * w32select.c: Don't #include "keyboard.h".
c96bbc66 9100 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
9101
9102 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9103 * w32console.c (detect_input_pending, read_input_pending)
9104 (encode_terminal_code):
9105 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9106 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9107 (w32_system_caret_y, Qfile_name_history):
9108 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9109 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9110 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9111 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9112 * w32proc.c (Qlocal, report_file_error):
9113 * w32term.c (Vwindow_system, updating_frame):
9114 * w32uniscribe.c (initialized, uniscribe_font_driver):
9115 Remove unneeded extern declarations.
9116
2aa46d6c
CY
91172011-03-14 Chong Yidong <cyd@stupidchicken.com>
9118
c96bbc66 9119 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 9120
cffc6f3b
CY
91212011-03-13 Chong Yidong <cyd@stupidchicken.com>
9122
9123 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9124 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9125 These macros can no longer be used for assignment.
9126
44f230aa
SM
9127 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9128 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
9129 (record_buffer_markers, fetch_buffer_markers): New functions for
9130 recording and fetching special buffer markers.
9131 (set_buffer_internal_1, set_buffer_temp): Use them.
9132
9133 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9134
9135 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9136
9137 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9138 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9139
9140 * xdisp.c (hscroll_window_tree):
9141 (reconsider_clip_changes): Use PT instead of BUF_PT.
9142
d251f04b
EZ
91432011-03-13 Eli Zaretskii <eliz@gnu.org>
9144
9145 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9146 $(EMACS_ROOT)/lib/intprops.h.
9147
f0c77cd1
PE
91482011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9149
3eca4629
PE
9150 Fix more problems found by GCC 4.5.2's static checks.
9151
7c86ee98
PE
9152 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9153 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
9154 (xg_free_frame_widgets): Make it clear that a local variable is
9155 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
9156 (gdk_window_get_screen): Make it clear that this macro is needed
9157 only if USE_GTK_TOOLTIP.
1e5524e7
PE
9158 (int_gtk_range_get_value): New function, which avoids a diagnostic
9159 from gcc -Wbad-function-cast.
9160 (xg_set_toolkit_scroll_bar_thumb): Use it.
9161 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9162 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
9163 (get_utf8_string, xg_get_file_with_chooser):
9164 Rename locals to avoid shadowing.
9165 (create_dialog): Move locals to avoid shadowing.
7c86ee98 9166
41729b81
PE
9167 * xgselect.c (xg_select): Remove unused var.
9168
f0c77cd1
PE
9169 * image.c (four_corners_best): Mark locals as initialized.
9170 (gif_load): Initialize transparent_p to zero (Bug#8238).
9171 Mark another local as initialized.
ec6cf4c6 9172 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 9173
ce0ad53d 9174 * image.c (clear_image_cache): Now static.
d5d5a617 9175 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 9176 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
9177 (x_edge_detection): Remove unnecessary cast that
9178 gcc -Wbad-function-cast diagnoses.
2037898d 9179 (gif_load): Fix pointer signedness.
6ae141d6
PE
9180 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9181 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 9182
33383987 91832011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 9184
d32df629
PE
9185 Improve quality of tests for time stamp overflow.
9186 For example, without this patch (encode-time 0 0 0 1 1
9187 1152921504606846976) returns the obviously-bogus value (-948597
9188 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9189 reports time overflow. See
9190 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
9191 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9192 * editfns.c: Include limits.h and intprops.h.
9193 (TIME_T_MIN, TIME_T_MAX): New macros.
9194 (time_overflow): Move earlier, to before first use.
9195 (hi_time, lo_time): New functions, for an accurate test for
9196 out-of-range times.
9197 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9198 (Fget_internal_run_time): Don't assume time_t fits in int.
9199 (make_time): Use list2 instead of Fcons twice.
9200 (Fdecode_time): More accurate test for out-of-range times.
9201 (check_tm_member): New function.
9202 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
9203 (lisp_time_argument): Don't rely on undefined left-shift and
9204 right-shift behavior when checking for time stamp overflow.
8be6f318 9205
fe31d94c
PE
9206 * editfns.c (time_overflow): New function, refactoring common code.
9207 (Fformat_time_string, Fdecode_time, Fencode_time):
9208 (Fcurrent_time_string): Use it.
9209
8be6f318
PE
9210 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9211 * dired.c (make_time): Move to ...
9212 * editfns.c (make_time): ... here.
9213 * systime.h: Note the move.
9214
09d9db2c 92152011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 9216
126bc0dc
YM
9217 * fringe.c (update_window_fringes): Remove unused variables.
9218
c47cbdfd
YM
9219 * unexmacosx.c (copy_data_segment): Also copy __got section.
9220 (Bug#8223)
9221
7ac80be9
EZ
92222011-03-12 Eli Zaretskii <eliz@gnu.org>
9223
c96bbc66 9224 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
9225 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9226 Constify `char *' arguments and their references according to
9227 prototypes in tparam.h.
9228
ecb0f94d 9229 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 9230
7ac80be9
EZ
9231 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9232 Adapt all references accordingly.
9233
9234 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9235
ef1fd07e
TT
92362011-03-11 Tom Tromey <tromey@redhat.com>
9237
9238 * buffer.c (syms_of_buffer): Remove obsolete comment.
9239
7ef4b50c
EZ
92402011-03-11 Eli Zaretskii <eliz@gnu.org>
9241
9242 * termhooks.h (encode_terminal_code): Declare prototype.
9243
9244 * msdos.c (encode_terminal_code): Don't declare prototype.
9245
9246 * term.c (encode_terminal_code): Now external again, used by
9247 w32console.c and msdos.c.
9248
44f230aa
SM
9249 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9250 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 9251
4b1ec863 92522011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 9253
1714f52b 9254 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 9255
4b1ec863
PE
9256 * fringe.c (update_window_fringes): Mark locals as initialized
9257 (Bug#8227).
9258 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 9259
524c7aa6
PE
9260 * alloc.c (mark_fringe_data): Move decl from here ...
9261 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9262 to check its interface.
9263 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9264
a5c0af81 9265 * fontset.c (free_realized_fontset): Now static.
7519b8cd 9266 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 9267 (fontset_font): Mark local as initialized.
a9a06e0b 9268 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 9269
b4716021
PE
9270 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9271
811e9bac 9272 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 9273 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
9274 (x_own_selection, Fx_disown_selection_internal): Rename locals
9275 to avoid shadowing.
9276 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 9277
7e3ab302
PE
9278 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9279 so that the caller can use some name other than gcpro1.
9280 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
9281 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9282 (Fx_backspace_delete_keys_p):
9283 Use them to avoid shadowing, and rename vars to avoid shadowing.
9284 (x_decode_color, x_set_name, x_window): Now static.
6b437900 9285 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 9286 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
9287 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9288 Remove unused locals.
7e3ab302
PE
9289 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9290 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9291 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9292 macros.
f78faa98 9293
e2b13473
PE
9294 * xterm.h (x_mouse_leave): New decl.
9295
77f23912
PE
9296 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9297 Remove unused functions.
cdf4ba58
PE
9298 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9299 (x_calc_absolute_position): Now static.
7411c686 9300 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 9301 Don't declare local "event" unless it's used.
ed7bf3a5
PE
9302 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9303 unless they are used.
38d0b34a
PE
9304 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9305 (x_fatal_error_signal): Remove; not used.
a6067996
PE
9306 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9307 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9308 (x_error_catcher, x_connection_closed, x_error_handler):
9309 (x_error_quitter, xembed_send_message, x_iconify_frame):
9310 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 9311 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 9312 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 9313
44f230aa
SM
9314 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9315 Rename or move locals to avoid shadowing.
6b463e58 9316 (tty_defined_color, merge_face_heights): Now static.
5967d051 9317 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
9318 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9319 does not deduce is never used uninitialized.
73719eba
PE
9320 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9321 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 9322
426994c3 9323 * terminal.c (store_terminal_param): Now static.
5489860b 9324
032f1620 9325 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 9326 (set_frame_menubar): Remove unused local.
d4323972 9327 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
9328 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9329 since they might point to immutable storage.
281585b0
PE
9330 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9331 since it's unused otherwise.
032f1620 9332
367c19e5 9333 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 9334 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
9335 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9336 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 9337 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
9338 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9339 does not deduce are never used uninitialized.
70739cbe 9340
07b48fa9
PE
9341 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9342
8868a238 9343 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
9344 * window.c (window_loop, size_window):
9345 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 9346
7e5cf297 9347 * window.c (display_buffer): Now static.
d6550a9f
PE
9348 (size_window): Mark variables that gcc -Wuninitialized
9349 does not deduce are never used uninitialized.
a586633d
PE
9350 * window.h (check_all_windows): New decl, to forestall
9351 gcc -Wmissing-prototypes diagnostic.
5b555da1 9352 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 9353
f6095868
PE
9354 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9355 shadowing.
9356 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
9357 Include <limits.h>.
9358 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9359 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
9360 (load_charset_map): Mark variables that gcc -Wuninitialized
9361 does not deduce are never used uninitialized.
53df7c11 9362 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 9363
f38b440c
PE
9364 * coding.c (coding_set_source, coding_set_destination):
9365 Use "else { /* comment */ }" rather than "else /* comment */;"
9366 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
9367 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9368 a block, when the outer 'i' will do.
9369 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9370 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9371 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9372 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9373 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9374 Rename locals to avoid shadowing.
9375 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
9376 * coding.c (emacs_mule_char, encode_invocation_designation):
9377 Now static, since they're not used elsewhere.
413bb2db 9378 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 9379 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
9380 (decode_coding_emacs_mule): Mark variables that gcc
9381 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
9382 (detect_coding_iso_2022): Initialize a local variable that might
9383 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 9384 this initialization is needed. (Bug#8211)
5f58e762
PE
9385 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9386 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9387 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9388 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9389 Remove unused macros.
f38b440c 9390
232b38b9 9391 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 9392 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 9393 * character.c (string_count_byte8): Likewise.
232b38b9 9394
fb90da1b
PE
9395 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9396 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9397
fb93dbc2
PE
9398 * chartab.c (copy_sub_char_table): Now static, since it's not used
9399 elsewhere.
5c156ace
PE
9400 (sub_char_table_ref_and_range, char_table_ref_and_range):
9401 Rename locals to avoid shadowing.
bbcd0949 9402 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 9403
7d3b3862 9404 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 9405 (BIDI_BOB): Remove unused macro.
7d3b3862 9406
6be7d3da
PE
9407 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9408 deduce are never used uninitialized.
c2ed9c8b 9409 * term.c (encode_terminal_code): Likewise.
6be7d3da 9410
75f8807f 9411 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 9412
50938595
PE
9413 * tparam.h: New file.
9414 * term.c, tparam.h: Include it.
9415 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9416 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9417 Move these decls to tparam.h, and make them agree with what
9418 is actually in tparam.c. The previous trick of using incompatible
9419 decls in different modules does not conform to the C standard.
9420 All callers of tparam changed to use tparam's actual API.
9421 * tparam.c (tparam1, tparam, tgoto):
9422 Use const pointers where appropriate.
9423
fbceeba2
PE
9424 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9425 * cm.h (struct cm): Likewise.
9426 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9427 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9428 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9429 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9430 (turn_on_face, init_tty): Likewise.
9431 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 9432
7f3f1250
PE
9433 * term.c (term_mouse_position): Rename local to avoid shadowing.
9434
e6ca6543
PE
9435 * alloc.c (mark_ttys): Move decl from here ...
9436 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9437
c40f8d15
AS
94382011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9439
9440 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9441
cfe0661d
JB
94422011-03-09 Juanma Barranquero <lekktu@gmail.com>
9443
9444 * search.c (compile_pattern_1): Remove argument regp, unused since
9445 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9446 (compile_pattern): Don't pass it.
9447
0afb4571
J
94482011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9449
9450 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9451 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9452 for ! HAVE_GTK3.
9453 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9454
9455 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9456
9457 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9458 gdk_window_get_screen, gdk_window_get_geometry,
9459 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9460 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9461 (xg_get_pixbuf_from_pixmap): New function.
9462 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9463 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9464 Call xg_get_pixbuf_from_pixmap instead of
9465 gdk_pixbuf_get_from_drawable.
9466 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9467 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9468 (xg_check_special_colors): Use GtkStyleContext and its functions
9469 for HAVE_GTK3.
9470 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9471 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9472 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
9473 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9474 Call gtk_widget_get_preferred_size.
0afb4571
J
9475 (xg_frame_resized): gdk_window_get_geometry only takes 5
9476 parameters.
44f230aa
SM
9477 (xg_win_to_widget, xg_event_is_for_menubar):
9478 Call gdk_x11_window_lookup_for_display.
0afb4571
J
9479 (xg_set_widget_bg): New function.
9480 (delete_cb): New function.
895009e1 9481 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 9482 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
9483 (xg_set_background_color): Call xg_set_widget_bg.
9484 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9485 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9486 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9487 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9488 if ! HAVE_GTK3.
9489 (update_frame_tool_bar): Call gtk_widget_hide.
9490 (xg_initialize): Use GDK_KEY_g.
9491
9492 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9493 if ! HAVE_GTK3
9494 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9495
9496 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9497 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9498 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9499
1c2cc4ef
JB
95002011-03-08 Juanma Barranquero <lekktu@gmail.com>
9501
9502 * w32xfns.c (select_palette): Check success of RealizePalette against
9503 GDI_ERROR, not zero.
9504
33383987 9505See ChangeLog.11 for earlier changes.
aac0c6e3
MR
9506
9507;; Local Variables:
9508;; coding: utf-8
aac0c6e3
MR
9509;; End:
9510
acaf905b 9511 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
9512
9513 This file is part of GNU Emacs.
9514
9515 GNU Emacs is free software: you can redistribute it and/or modify
9516 it under the terms of the GNU General Public License as published by
9517 the Free Software Foundation, either version 3 of the License, or
9518 (at your option) any later version.
9519
9520 GNU Emacs is distributed in the hope that it will be useful,
9521 but WITHOUT ANY WARRANTY; without even the implied warranty of
9522 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9523 GNU General Public License for more details.
9524
9525 You should have received a copy of the GNU General Public License
9526 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.