Explicitly free restriction data that are not needed anymore.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
3628596a
DA
12012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
2
3 Explicitly free restriction data that are not needed anymore.
4 * editfns.c (save_restriction_restore): Free restriction data.
5
7abaf5cc
SM
62012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
7
8 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
9 add argument, tune behavior, and adjust all callers.
10
71f88e00
PE
112012-07-25 Paul Eggert <eggert@cs.ucla.edu>
12
13 Use typedef for EMACS_INT, EMACS_UINT.
14 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
15 than macros. This simplifies debugging in the usual case, since
16 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
17 and it allows expressions involving EMACS_INT casts.
18 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
19
57ec3034
JD
202012-07-25 Jan Djärv <jan.h.d@swipnet.se>
21
22 * nsterm.m (ns_read_socket): Return early if there is a modal
23 window (Bug#12043).
24
8137e7b3
MR
252012-07-25 Martin Rudalics <rudalics@gmx.at>
26
27 * frame.c (Fredirect_frame_focus): In doc-string don't mention
28 that FOCUS-FRAME can be omitted.
29
04e9897c
DA
302012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
31
32 Adjust buffer text indirection counters at the end of Fkill_buffer.
33 * buffer.c (Fkill_buffer): Adjust indirection counters when the
34 buffer is definitely dead. This should really fix an issue reported
35 by Christoph Scholtes again. (Bug#12007).
36 (init_buffer_once): Initialize indirection counters of
37 buffer_defaults and buffer_local_symbols (for sanity and safety).
38
8a0484e1
EZ
392012-07-24 Eli Zaretskii <eliz@gnu.org>
40
41 * xdisp.c (init_iterator): Don't compute dimensions of truncation
42 and continuation glyphs on tooltip frames, leave them at zero.
43 Avoids continued lines in tooltips. (Bug#11832)
44
fa691a83
DA
452012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
46
47 Simplify copy_overlay.
04e9897c 48 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
49 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
50
436bc8e0
EZ
512012-07-23 Eli Zaretskii <eliz@gnu.org>
52
53 * print.c (print_object): Don't crash when a frame's name is nil
54 or invalid. (Bug#12025)
55
56 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
57 it signals an error when a tooltip frame is being created.
58
d7a7fda3
DA
592012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
60
61 Cleanup miscellaneous objects allocation and initialization.
62 * alloc.c (allocate_misc): Change to static. Add argument to
63 specify the subtype. Adjust comment and users.
64 (build_overlay): New function.
65 * buffer.c (copy_overlays, Fmake_overlay): Use it.
66 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
67 (allocate_misc): Remove prototype.
68 (build_overlay): Add prototype.
69
702012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
71
72 Swap buffer text indirection counters in Fbuffer_swap_text.
73 * buffer.c (Fbuffer_swap_text): Swap indirections too.
74 This avoids crash reported by Christoph Scholtes at
75 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
76
9d7fa573
JD
772012-07-22 Jan Djärv <jan.h.d@swipnet.se>
78
79 * nsmenu.m (Popdown_data): New struct.
80 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
81 free Popdown_data.
82 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
83 (initWithContentRect): Make imgView and contentView non-static
84 and autorelease them. Also autorelease img and matrix (Bug#12005).
85 (dealloc): Remove (Bug#12005).
86
0dd6d66d
DA
872012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
88
89 Adjust consing_since_gc when objects are explicitly freed.
90 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
91 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
92 (free_cons, free_misc): Subtract object size from consing_since_gc.
93
d36d71df
DA
942012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
95
96 Simplify and cleanup markers positioning code.
97 * marker.c (attach_marker): More useful eassert.
98 (live_buffer, set_marker_internal): New function.
99 (Fset_marker, set_marker_restricted): Use set_marker_internal.
100 (set_marker_both, set_marker_restricted_both): Use live_buffer.
101
fb9ea40f
PE
1022012-07-22 Paul Eggert <eggert@cs.ucla.edu>
103
104 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
105 as it's limited by the amount of memory, not by INT_MAX.
106
2d5c5f7d
EZ
1072012-07-21 Eli Zaretskii <eliz@gnu.org>
108
07fb592e
EZ
109 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
110 in special-event-map. See the discussion at
111 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
112 for the reasons.
113
37a9eac8 114 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
2d5c5f7d
EZ
115 info.dwItemData. Fixes crashes on 64-bit Windows. Suggested by
116 Fabrice Popineau <fabrice.popineau@supelec.fr>.
117
c4328746
JD
1182012-07-21 Jan Djärv <jan.h.d@swipnet.se>
119
120 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 121 (conversationIdentifier): Return value is NSInteger.
784051c4 122 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 123
6e5d1c12
CY
1242012-07-21 Chong Yidong <cyd@gnu.org>
125
126 * window.c (decode_any_window): Signal an error if the window is
127 on a dead frame (Bug#11984).
128
9928463d
DA
1292012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
130
131 Add indirection counting to speed up Fkill_buffer.
132 * buffer.h (struct buffer): New member.
133 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
134 (Fmake_indirect_buffer): Set indirection counter to -1, increment
135 base buffer indirection counter.
136 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
137 (Fkill_buffer): Adjust indirection counters as needed, don't walk
138 through buffer list if indirection counter is 0.
139
f8643a6b
DA
1402012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
141
142 Extend the value returned by Fgarbage_collect with heap statistics.
143 * alloc.c (Qheap): New symbol.
144 (syms_of_alloc): DEFSYM it.
145 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
146 (Fmemory_free): Remove.
147 (syms_of_alloc): Don't defsubr it.
148 * buffer.c (Fcompact_buffer): Remove.
149 (syms_of_buffer): Don't defsubr it.
150
dac616ff
DA
1512012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
152
153 Make maybe_gc inline.
154 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
155 * lisp.h (consing_since_gc, gc_relative_threshold)
156 (memory_full_cons_threshold): Revert declaration.
157 (maybe_gc): Remove prototype, define as inline.
158 * alloc.c: Remove old commented-out code.
159 (consing_since_gc, gc_relative_threshold)
160 (memory_full_cons_threshold): Revert to global.
161 (maybe_gc): Remove.
162
d7ea76b4
DA
1632012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
164
165 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
166 * lisp.h (build_unibyte_string): New function.
167 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
168 * sysdep.c, w32fns.c, xfns.c: Use it.
169 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
170 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
171 Adjust users accordingly.
172 * font.h (font_open_by_name): Adjust prototype.
173
765e61e3
DA
1742012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
175
176 Cleanup calls to Fgarbage_collect.
177 * lisp.h (maybe_gc): New prototype.
178 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
179 Remove declarations.
180 * alloc.c (maybe_gc): New function.
181 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
182 Make them static.
183 * bytecode.c (MAYBE_GC): Use maybe_gc.
184 * eval.c (eval_sub, Ffuncall): Likewise.
185 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
186 to avoid dependency from auto-save feature.
187
52b852c7
PE
1882012-07-19 Paul Eggert <eggert@cs.ucla.edu>
189
190 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
191 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
192 'for_each_per_buffer_object_at'.
193 All uses changed. It's better to use upper-case for macros that
194 cannot be implemented as functions, to give the reader a clue
195 that they're special.
196
5db81e33
SM
1972012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
198
199 * alloc.c (Fgarbage_collect): Tweak docstring.
200
5b835e1d
DA
2012012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
202
203 Tweak the value returned from Fgarbage_collect again.
204 * alloc.c (Fgarbage_collect): New return value, as confirmed in
205 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
206 Adjust documentation.
207 (total_vector_bytes): Rename to total_vector_slots, adjust
208 accounting.
209 (total_free_vector_bytes): Rename to total_free_vector_slots,
210 adjust accounting.
211 (Qstring_bytes, Qvector_slots): New symbols.
212 (syms_of_alloc): DEFSYM them.
213
9cd47b72
DA
2142012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
215
216 Buffer compaction primitive which may be used from Lisp.
217 * buffer.c (compact_buffer, Fcompact_buffer): New function.
218 (syms_of_buffer): Register Fcompact_buffer.
219 * alloc.c (Fgarbage_collect): Use compact_buffer.
220 * buffer.h (compact_buffer): New prototype.
221 (struct buffer_text): New member.
222
d17337e5
DA
2232012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
224
225 New macro to iterate over all buffers, miscellaneous cleanups.
226 * lisp.h (all_buffers): Remove declaration.
227 * buffer.h (all_buffers): Add declaration, with comment.
228 (for_each_buffer): New macro.
229 * alloc.c (Fgarbage_collect, mark_object): Use it.
230 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
231 (init_buffer): Likewise.
232 * data.c (Fset_default): Likewise.
233 * coding.c (code_conversion_restore): Remove redundant check
234 for dead buffer.
235 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
236
60cfd278
AS
2372012-07-18 Andreas Schwab <schwab@linux-m68k.org>
238
239 Fix bug that created negative-length intervals.
240 * intervals.c (merge_interval_right, merge_interval_left):
241 Do not zero out this interval if it is absorbed by its children,
242 as this interval's total length doesn't change in that case. See
243 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
244
d06714cb
PE
2452012-07-18 Paul Eggert <eggert@cs.ucla.edu>
246
83713154
PE
247 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
248 when invoking (make-bool-vector N t) and N is a positive
249 multiple of 8 -- the last 8 bits were mistakenly cleared.
250
d06714cb
PE
251 Remove some struct layout assumptions in bool vectors.
252 * alloc.c (bool_header_size): New constant.
253 (header_size, word_size): Move earlier, as they're now used earlier.
254 Use 'word_size' in a few more places, where it's appropriate.
255 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
256 padding before the data member of a bool vector.
257 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
258 than doing the check by hand with an abort ().
259
464d5a5e
SM
2602012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
261
5fbc0409
SM
262 * eval.c (Fdefvar): Don't check constants since we only set the var if
263 it's not yet defined anyway (bug#11904).
264
464d5a5e
SM
265 * lisp.h (last_undo_boundary): Declare new var.
266 * keyboard.c (command_loop_1): Set it.
267 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
268 were auto-added by the command loop (bug#11774).
269
8dc2e44a
AS
2702012-07-18 Andreas Schwab <schwab@linux-m68k.org>
271
272 * w32font.c (Qsymbol): Remove local definition.
273 (syms_of_w32font): Don't DEFSYM it.
274
169925ec
DA
2752012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
276
277 Fix sweep_vectors to handle large bool vectors correctly.
278 * alloc.c (sweep_vectors): Account total_vector_bytes for
279 bool vectors larger than VBLOCK_BYTES_MAX.
280
5fbfb018
CY
2812012-07-18 Chong Yidong <cyd@gnu.org>
282
283 * frame.c (x_set_frame_parameters): Revert bogus change introduced
284 in 2012-05-25 commit by Paul Eggert (Bug#11738).
285
3ab6e069
DA
2862012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
287
288 Return more descriptive data from Fgarbage_collect.
289 Suggested by Stefan Monnier in
290 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
291 * alloc.c (bounded_number): New function.
292 (total_buffers, total_vectors): New variable.
293 (total_string_size): Rename to total_string_bytes, adjust users.
294 (total_vector_size): Rename to total_vector_bytes, adjust users.
295 (sweep_vectors): Account total_vectors and total_vector_bytes.
296 (Fgarbage_collect): New return value. Adjust documentation.
297 (gc_sweep): Account total_buffers.
298 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
299 (VECTOR_SIZE): Remove.
300 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
301 (Qinterval, Qmisc): New symbols.
302 (syms_of_data): Initialize them.
303 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
304 (Qcons, Qbuffer): New declarations.
305
6d02fe5b
PE
3062012-07-17 Paul Eggert <eggert@cs.ucla.edu>
307
308 * alloc.c (Fmemory_free): Account for memory-free's own storage.
309 Round up, not down. Improve doc.
310
b7ffe040
DA
3112012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
312
313 Restore old code in allocate_string_data to avoid Faset breakage.
314 Reported by Julien Danjou <julien@danjou.info> in
315 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
316 * alloc.c (allocate_string_data): Restore old code with minor
317 adjustments, fix comment to explain this subtle issue.
318
4dc7c8d5
SM
3192012-07-17 Eli Zaretskii <eliz@gnu.org>
320
321 Remove FILE_SYSTEM_CASE.
322 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
323
324 * fileio.c (FILE_SYSTEM_CASE): Don't define.
325 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
326 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
327 call-process-region passes it through expand-file-name.
328
329 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
330
3312012-07-17 Andreas Schwab <schwab@linux-m68k.org>
332
333 Fix crash when creating indirect buffer (Bug#11917)
334 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
335 Don't handle unbound variables specially if non-zero.
336 (Fbuffer_local_variables): Pass zero.
337 (clone_per_buffer_values): Pass non-zero.
338
3392012-07-17 Andreas Schwab <schwab@linux-m68k.org>
340
341 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
342 to make the loop interruptible.
343
3442012-07-17 Andreas Schwab <schwab@linux-m68k.org>
345
346 * gnutls.c (emacs_gnutls_handshake): Only retry if
347 GNUTLS_E_INTERRUPTED.
348
cce7fefc
DA
3492012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
350
351 Cleanup and convert miscellaneous checks to eassert.
352 * alloc.c (mark_interval): Fix comment, partially rephrase
353 old comment from intervals.h (see below).
354 * intervals.c (find_interval, adjust_intervals_for_insertion)
355 (delete_interval, adjust_intervals_for_deletion)
356 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
357 Convert to eassert.
358 (adjust_intervals_for_insertion, make_new_interval):
359 Remove obsolete and unused code.
360 * intervals.h (struct interval): Remove obsolete comment.
361 * textprotp.c (erase_properties): Remove unused code.
362 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
363 (Fremove_list_of_text_properties): Convert to eassert.
364
9ea10cc3
CY
3652012-07-17 Chong Yidong <cyd@gnu.org>
366
367 * editfns.c (Finsert_char): Doc fix.
368
3900d5de
DA
3692012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
370
371 Fix previous change to make Fmemory_free always accurate.
372 * alloc.c (make_interval): Update total_free_intervals.
373 (make_float): Likewise for total_free_floats.
374 (free_cons, Fcons): Likewise for total_free_conses.
375 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
376 Likewise for total_free_vector_bytes.
377 (Fmake_symbol): Likewise for total_free_symbols.
378 (bytes_free): Remove.
379
7098646f
DA
3802012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
381
382 Simple free memory accounting feature.
383 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
384 (sweep_vectors): Accumulate size of free vectors.
385 (Fgarbage_collect): Setup bytes_free.
386 (Fmemory_free): New function.
387 (syms_of_alloc): Register it.
388
22657b40
DA
3892012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
390
391 Cleanup overlays checking.
392 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
393 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
394 eassert and OVERLAYP.
395 (sort_overlays): Change to use OVERLAYP.
396
ddfc8813
RK
3972012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
398
399 * editfns.c (Finsert_char): Make it interactive, and make the
400 second arg optional. Copy interactive spec and docstring from
401 ucs-insert.
402
7c26cf3c
PE
4032012-07-17 Paul Eggert <eggert@cs.ucla.edu>
404
405 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
406 Unlike the other wrapped functions, fabs has an unspecified
407 effect on errno.
408
5d127af9
JD
4092012-07-16 Jan Djärv <jan.h.d@swipnet.se>
410
411 * nsterm.m (keyDown): Interpret flags without left/right bits
412 as the left key (Bug#11670).
413
6a0dd1d7
DA
4142012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
415
416 Remove empty and useless init functions.
417 * lisp.h (init_character_once, init_fns, init_image)
418 (init_filelock, init_sound): Remove prototype.
419 * character.c (init_character_once): Remove.
420 * filelock.c (init_filelock): Likewise.
421 * fns.c (init_fns): Likewise.
422 * image.c (init_image): Likewise.
423 * sound.c (init_sound): Likewise.
424 * emacs.c (main): Adjust accordingly.
425
7a6136fd
DA
4262012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
427
428 * gtkutil.h: Tiny cleanups.
429 (use_old_gtk_file_dialog): Remove useless declaration.
430 (xg_uses_old_file_dialog): Add suggested const attribute.
431
ce811ad9
EZ
4322012-07-15 Eli Zaretskii <eliz@gnu.org>
433
434 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
435 (bidi_paragraph_init): Use it to limit search forward for a strong
436 directional character in abnormally large paragraphs full of
437 neutral or weak characters. (Bug#11943)
438
c9adfeaa
SF
4392012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
440
441 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
442 the toolbar (Bug#9451).
443 (xg_make_tool_item): Give the widget event box a transparent
444 background.
445
fff62aa9
DA
4462012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
447
448 Cleanup basic allocation variables and functions.
449 * alloc.c (ignore_warnings, init_intervals, init_float)
450 (init_cons, init_symbol, init_marker): Remove.
451 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
452 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
453 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
454 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
455 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
456 (staticidx, init_alloc_once, init_strings, free_ablock):
457 Remove redundant initialization.
458 * fns.c (init_weak_hash_tables): Remove.
459 * lisp.h (init_weak_hash_tables): Remove prototype.
460
9730daca
DA
4612012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
462
463 Use zero_vector where appropriate.
464 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
465 accordingly.
466 * lisp.h (zero_vector): New declaration.
467 * font.c (null_vector): Remove.
468 (syms_of_font): Remove initialization and staticpro.
469 (font_list_entities, font_find_for_lface): Change to use zero_vector.
470 * keymap.c (Faccessible_keymaps): Likewise.
471
2e2d2a13
LL
4722012-07-15 Leo Liu <sdl.web@gmail.com>
473
474 * fringe.c: Fix typo in comments.
475
cd276f6e
LL
4762012-07-14 Leo Liu <sdl.web@gmail.com>
477
478 * fringe.c: Add a new bitmap exclamation-mark.
479
5a1131d9
EZ
4802012-07-14 Eli Zaretskii <eliz@gnu.org>
481
482 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
483
484 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
485 (HAVE_MENUS): Don't define, defined by editing config.in with
486 msdos/sed2v2.inp.
487 (GMALLOC_INHIBIT_VALLOC): Don't define.
488 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
489
22e983b7
JB
4902012-07-14 Juanma Barranquero <lekktu@gmail.com>
491
492 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
493
5b3f250f
GM
4942012-07-14 Glenn Morris <rgm@gnu.org>
495
496 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
497 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
498 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
499
33d63ff4
GM
5002012-07-13 Glenn Morris <rgm@gnu.org>
501
5b633342
GM
502 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
503
33d63ff4
GM
504 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
505 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
506
b55b9f85
JD
5072012-07-13 Jan Djärv <jan.h.d@swipnet.se>
508
0dc8cf50
JD
509 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
510 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
511 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
512 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
513 where appropriate.
514 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
515 as boolean expression.
516 (x_set_window_size): Remove unused variable toolbar.
517 (ns_get_color_default, ns_mod_to_lisp): Remove.
518 (ns_mouse_position): Remove unused variables xchar and ychar.
519 (ns_compute_glyph_string_overhangs): Remove unused variable face.
520 (ns_set_vertical_scroll_bar): Remove unused variable count.
521 (ns_delete_terminal): Remove unused variable i.
522 (ns_term_init): Remove unused variables r, g and b.
523 (mouseDown): Remove unused variable window.
524 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
525 (initFrameFromEmacs): Remove unused variable vbextra.
526 (mouseEntered): Remove unused variables p and dpyinfo.
527 (mouseExited): Remove unused variables p and r.
528 (ns_define_frame_cursor, ns_clear_frame_area)
529 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
530 (menuDown): Assign [sender tag] to variable and cast the variable.
531
532 * nsterm.h (menuDown): Add id as type to argument sender.
533 (ns_display_info_for_name): Add Lisp_Object argument.
534 (ns_term_init): Add Lisp_Object argument.
535 (ns_map_event_to_object): Add void argument.
536 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
537 prototype with arguments and only declare if __OBJC__.
538 (nxatoms_of_nsselect): Add void argument.
539 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
540 (ns_alloc_autorelease_pool): Add void argument.
541 (ns_release_autorelease_pool): Add void* argument.
542 (ns_get_defaults_value): Add const char* argument.
543
544 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
545 (initFromContents): Use SSDATA where appropriate.
546 (ns_update_menubar): Add braces to ambigous if-else.
547 (initWithTitle): Put () around assignment in if statement.
548 (ns_menu_show): Remove unused variables window and keymap.
549 (update_frame_tool_bar): Remove unused variable selected_p.
550 (initWithContentRect): Remove unused variable this_cmd_name.
551
552 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
553 appropriate.
554 (setXBMColor): Remove unused variable len.
555 (setPixmapData): Put () around assignment in loop statement.
556
557 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
558 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
559 where appropriate.
560 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
561 around assignment in loop statement.
562 (nsfont_open): Remove unused variable i.
563 (nsfont_open): Remove unused variable len.
564 (nsfont_draw): Remove unused variable cs.
565
566 * nsfns.m (x_set_icon_name, ns_set_name_internal)
567 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
568 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
569 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
570 (Fns_font_name, Fns_perform_service)
571 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
572 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
573 (ns_set_name): Remove unused variable view.
574 (x_set_menu_bar_lines): Remove unused variable olines.
575 (x_set_tool_bar_lines): Remove unused variable root_window.
576 (Fns_list_colors): Put () around assignment in while statement.
577 (Fns_perform_service): Remove unused variable len.
578 (Fns_display_usable_bounds): Remove unused variable top.
579 (syms_of_nsfns): Remove unused variable i.
580
b55b9f85
JD
581 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
582 memcpy (Bug#11907).
583
ed9265fc 5842012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
585
586 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
587 and free it with DestroyExceptionInfo (Bug#11558).
588
ef099b57
JB
5892012-07-13 Juanma Barranquero <lekktu@gmail.com>
590
591 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
592 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
593 Set here, not in nt/config.nt.
594
ea814a5d
EZ
5952012-07-13 Eli Zaretskii <eliz@gnu.org>
596
597 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
598 cursor overflow into the last glyph on display line when the right
599 fringe is off. (Bug#11832)
600
1a952767
PE
6012012-07-13 Paul Eggert <eggert@cs.ucla.edu>
602
603 * xdisp.c (produce_special_glyphs): Now static.
604 * dispextern.h (produce_special_glyphs): Remove decl.
605
983188fd
GM
6062012-07-13 Glenn Morris <rgm@gnu.org>
607
32fb4bb6
GM
608 * s/bsd-common, s/cygwin.h: Remove empty files.
609 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
610
983188fd
GM
611 * s/usg5-4-common.h (USG, USG5):
612 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
613 * s/sol2-6.h (SOLARIS2):
614 * s/irix6-5.h (IRIX6_5):
615 * s/hpux10-20.h (USG, USG5, HPUX):
616 * s/gnu-linux.h (USG, GNU_LINUX):
617 * s/freebsd.h (BSD_SYSTEM):
618 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
619 * s/cygwin.h (CYGWIN):
620 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
621 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
622
d1e68667 6232012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
624
625 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 626
6de0e799
GM
6272012-07-13 Glenn Morris <rgm@gnu.org>
628
739ae010
GM
629 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
630
dbee5793
GM
631 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
632
6de0e799
GM
633 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
634 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
635
b82da769
GM
6362012-07-12 Glenn Morris <rgm@gnu.org>
637
4fae5a7a 638 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
639
640 * process.c (init_process_emacs): Rename from init_process.
641 The old name is also the name of a Mach system call.
642 * lisp.h, emacs.c: Update for this name change.
643 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
644 longer needed.
645
5a979817
EZ
6462012-07-12 Eli Zaretskii <eliz@gnu.org>
647
648 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
649 memmove call that removes glyphs covered by the left truncation
650 glyph. Improve commentary.
651 (display_line): Fix display of continuation glyphs on GUI frames
652 when the right fringe is turned off and variable-size fonts are
653 used in the window. Move the code that appends a stretch glyph to
654 produce_special_glyphs, so that it could be used for truncation
655 and continuation glyphs alike.
656 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
657 glyph of a suitably computed width, to align the special glyphs at
658 the window margin. Code moved from display_line. (Bug#11832)
659
3e91a053
GM
6602012-07-12 Glenn Morris <rgm@gnu.org>
661
ba9e4b84
GM
662 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
663
664 * s/gnu-linux.h, s/hpux10-20.h:
665 Do not unconditionally define HAVE_XRMSETDATABASE.
666
3e91a053
GM
667 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
668
b300b1f4
PE
6692012-07-12 Paul Eggert <eggert@cs.ucla.edu>
670
671 Fix typos that broke OS X build.
672 Reported by Randal L. Schwartz in
673 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
674 * nsterm.m (ns_timeout): Add missing local decl.
675 (ns_get_color): snprintf -> sprintf, to fix typo.
676
6e777848
GM
6772012-07-12 Glenn Morris <rgm@gnu.org>
678
3f922c37
GM
679 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
680 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
681 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
682 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
683
0ab7b23a
GM
684 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
685 Move PTY_OPEN to configure.
686
6e777848
GM
687 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
688 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
689 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
690
4a7edc24
DA
6912012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
692
693 Use empty_unibyte_string where applicable.
694 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
695 * lread.c (read1): Likewise.
696 * xsettings.c (syms_of_xsettings): Likewise.
697
308aab79
GM
6982012-07-12 Glenn Morris <rgm@gnu.org>
699
42bd1719
GM
700 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
701 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
702 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
703 * s/hpux10-20.h (RUN_TIME_REMAP):
704 * s/bsd-common.h (TABDLY): Move to configure.
705
706 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
707
708 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
709
ea0bbd17 710 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 711 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
712
713 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 714
308aab79
GM
715 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
716 * s/template.h: Move NARROWPROTO to configure.
717
ee1cf5cf
GM
7182012-07-11 Glenn Morris <rgm@gnu.org>
719
30fe9bf4
GM
720 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
721 unused since 2011-01-17 change to systty.h.
722
ee1cf5cf
GM
723 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
724 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
725 Move HAVE_PTYS and HAVE_SOCKETS to configure.
726
63e47e07
PE
7272012-07-11 Paul Eggert <eggert@cs.ucla.edu>
728
729 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
730
c43fb4c3
GM
7312012-07-11 Glenn Morris <rgm@gnu.org>
732
733 * s/darwin.h, s/gnu-linux.h, s/template.h:
734 Move INTERRUPT_INPUT to configure.
735
e8df9267
DA
7362012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
737
738 Minor adjustments to interning code.
739 * lisp.h (intern, intern_c_string): Redefine as static inline
740 wrappers for intern_1 and intern_c_string_1, respectively.
741 (intern_1, intern_c_string_1): Rename prototypes.
2bce5643
DA
742 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
743 Vobarray checking.
e8df9267
DA
744 * font.c (font_intern_prop): Likewise. Adjust comment.
745 * w32font.c (intern_font_name): Likewise.
746
34348bd4
AS
7472012-07-11 Andreas Schwab <schwab@linux-m68k.org>
748
d96a1e0c
AS
749 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
750
34348bd4
AS
751 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
752 of Fcar/Fcdr if possible.
753 * font.c (check_otf_features): Likewise.
754 * fontset.c (Fnew_fontset): Likewise.
755 * gnutls.c (Fgnutls_boot): Likewise.
756 * minibuf.c (read_minibuf): Likewise.
757 * msdos.c (IT_set_frame_parameters): Likewise.
758 * xmenu.c (Fx_popup_dialog): Likewise.
759 * w32menu.c (Fx_popup_dialog): Likewise.
760
c8add24e
GM
7612012-07-11 Glenn Morris <rgm@gnu.org>
762
4b575b3c
GM
763 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
764 since nothing has defined it on these platforms.
765
09f4e3b0
GM
766 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
767 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
768
172bedef
GM
769 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
770 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
771 Move CLASH_DETECTION to configure.
772
249685df
GM
773 * s/gnu.h: Remove file, which is now empty.
774
c8add24e
GM
775 * s/gnu.h, s/gnu-linux.h:
776 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
777
b41253a3
JW
7782012-07-11 John Wiegley <johnw@newartisans.com>
779
780 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
781 function attribute, so we only use it if it exists in the
782 compiler.
783
d923b542
DA
7842012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
785
786 Avoid call to strlen in fast_c_string_match_ignore_case.
787 * search.c (fast_c_string_match_ignore_case): Change to use
788 length argument. Adjust users accordingly.
789 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
790
5ebbef1d
PE
7912012-07-11 Paul Eggert <eggert@cs.ucla.edu>
792
bb352260
PE
793 Assume mkdir, rmdir.
794 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
795 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
796
57054ddd
PE
797 Assume rename.
798 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
799
b747d3f7
PE
800 Assume perror.
801 * s/hpux10-20.h (HAVE_PERROR): Remove.
802 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
803 Remove dummy definition, as this problem was obsolete long ago.
804
5ebbef1d
PE
805 Assume strerror.
806 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
807
984e7f30
DA
8082012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
809
810 Avoid calls to strlen in font processing functions.
811 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
d923b542 812 (font_open_by_name): Change to use length argument. Adjust
984e7f30 813 users accordingly.
d923b542
DA
814 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
815 Adjust prototypes.
816 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
817 Change to return ptrdiff_t.
984e7f30
DA
818 (xfont_list_pattern, xfont_match): Use length returned by
819 xfont_decode_coding_xlfd.
820 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
821
20e94fdd
GM
8222012-07-11 Glenn Morris <rgm@gnu.org>
823
9d596af3
GM
824 * s/darwin.h, s/freebsd.h, s/netbsd.h:
825 Move DONT_REOPEN_PTY to configure.
826
20e94fdd
GM
827 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
828 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
829
e99a530f
PE
8302012-07-10 Paul Eggert <eggert@cs.ucla.edu>
831
22ffb973
PE
832 Remove "#define unix" that is no longer needed (Bug#11905).
833 * s/aix4-2.h (unix): Remove; no longer needed.
834
e9a9ae03
PE
835 EMACS_TIME simplification (Bug#11875).
836 This replaces macros (which typically do not work in GDB)
837 with functions, typedefs and enums, making the code easier to debug.
838 The functional style also makes code easier to read and maintain.
839 * systime.h: Include <sys/time.h> on all hosts, not just if
840 WINDOWSNT, since 'struct timeval' is needed in general.
841 (EMACS_TIME): Now a typedef, not a macro.
842 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
843 not macros.
844 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
845 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
846 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
847 (EMACS_TIME_LE): Now functions, not macros.
848 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
849 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
850 which are not functions. All uses rewritten to use:
851 (make_emacs_time): New function.
852 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
853 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
854 not functions. All uses rewritten to use the following, respectively:
855 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
856 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 857 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
858 * fileio.c (Fcopy_file):
859 * xterm.c (XTflash): Get the current time closer to when it's used.
860 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
861
ffacb126
PE
862 * bytecode.c (targets): Suppress -Woverride-init warnings.
863
e99a530f
PE
864 Simplify by avoiding confusing use of strncpy etc.
865 * doc.c (Fsnarf_documentation):
866 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
867 * frame.c (Fmake_terminal_frame):
868 * gtkutil.c (get_utf8_string):
869 * lread.c (openp):
870 * nsmenu.m (ns_update_menubar):
871 * regex.c (regerror):
872 Prefer memcpy to strncpy and strncat when either will do.
873 * fileio.c (Fsubstitute_in_file_name):
874 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
875 (menu_separator_name_p):
876 * nsmenu.m (ns_update_menubar):
877 Prefer memcmp to strncmp when either will do.
878 * nsterm.m: Include <ftoastr.h>.
879 (ns_get_color):
880 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
881 Prefer snprintf to strncpy.
882 * nsterm.m (ns_term_init):
883 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
884 * nsterm.m (ns_term_init):
885 Avoid the need for strncpy, by using build_string or
886 make_unibyte_string directly. Use dtoastr, not snprintf.
887 * process.c (Fmake_network_process): Diagnose service names that
888 are too long, rather than silently truncating them or creating
889 non-null-terminated names.
890 (Fnetwork_interface_info): Likewise, for interface names.
891 * sysdep.c (system_process_attributes) [GNU_LINUX]:
892 Prefer sprintf to strncat.
893 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
894 Prefer vsnprintf to vsprintf + strncpy.
895
c59592b3
GM
8962012-07-10 Glenn Morris <rgm@gnu.org>
897
898 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
899 Clarify fallback case.
900
7d7bbefd
DA
9012012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
902
903 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
904 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
905 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 906 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
907 where argument type is known to be a Lisp_Cons.
908
3a4c8000
TT
9092012-07-10 Tom Tromey <tromey@redhat.com>
910
911 * bytecode.c (BYTE_CODE_THREADED): New macro.
912 (BYTE_CODES): New macro. Replaces all old byte-code defines.
913 (enum byte_code_op): New type.
914 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
915 (exec_byte_code): Use them. Use token threading when applicable.
916
2a0213a6
DA
9172012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
918
919 Optimize pure C strings initialization.
920 * lisp.h (make_pure_string): Fix prototype.
921 (build_pure_c_string): New function, defined as static inline. This
922 provides a better opportunity to optimize away calls to strlen when
923 the function is called with compile-time constant argument.
924 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
925 argument, adjust users accordingly. Use build_pure_c_string where
926 appropriate.
927 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
928 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
929 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
930
cb1caeaf
DA
9312012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
932
933 Avoid calls to strlen in miscellaneous functions.
934 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
935 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
936 * lread.c (openp): Likewise.
937
c293e30c
DA
9382012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
939
940 Avoid calls to strlen in path processing functions.
941 * fileio.c (file_name_as_directory): Add comment. Change to add
942 srclen argument and return the length of result. Adjust users
943 accordingly.
944 (directory_file_name): Fix comment. Change to add srclen argument,
cb1caeaf 945 swap 1st and 2nd arguments to obey the common convention. Adjust
c293e30c
DA
946 users accordingly.
947 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
948
9e059e3f
GM
9492012-07-10 Glenn Morris <rgm@gnu.org>
950
d02eb359
GM
951 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
952 Move PENDING_OUTPUT_COUNT definition to configure.
953
882cf227
GM
954 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
955 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
956 * s/gnu.h (DATA_START): Move definitions to configure.
957
af6e839f
GM
958 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
959 We include usg5-4-common.h, which defines them both.
960
40289a12
GM
961 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
962 O_RDONLY already includes it).
963
9e059e3f
GM
964 Stop ns builds setting the EMACSLOADPATH environment variable.
965 * nsterm.m (ns_load_path): Rename from ns_init_paths.
966 Now it does not set EMACSLOADPATH, just returns the load-path string.
967 * nsterm.h: Update accordingly.
968 * lread.c [HAVE_NS]: Include nsterm.h.
969 (init_lread) [HAVE_NS]: Use ns_load_path.
970 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
971
7c4e8ec0
GM
9722012-07-09 Glenn Morris <rgm@gnu.org>
973
d4f600ff
GM
974 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
975 since the included bsd-common.h does so.
976
cbb31951
GM
977 Stop ns builds setting the EMACSPATH environment variable.
978 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
979 (ns_init_paths): Do not set EMACSPATH.
980 * nsterm.h (ns_exec_path): Add it.
981 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
982 Use ns_exec_path.
983
7c4e8ec0
GM
984 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
985
26bccfae
PE
9862012-07-09 Paul Eggert <eggert@cs.ucla.edu>
987
a0bee46f
PE
988 * process.c (wait_reading_process_output): 'waitchannels' was unset
989 when read_kbd || !NILP (wait_for_cell); fix this.
990
5994c183
PE
991 Add GCC-style 'const' attribute to functions that can use it.
992 * character.h (char_resolve_modifier_mask):
993 * keyboard.h (make_ctrl_char):
994 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
995 (init_character_once, next_almost_prime, init_fns, init_image)
996 (flush_pending_output, init_sound):
997 * mem-limits.h (start_of_data):
998 * menu.h (finish_menu_items):
999 Add ATTRIBUTE_CONST.
1000 * emacs.c (DEFINE_DUMMY_FUNCTION):
1001 Declare the dummy function with ATTRIBUTE_CONST.
1002 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
1003 Add decls with ATTRIBUTE_CONST.
1004
26bccfae
PE
1005 Minor improvements to make_formatted_string.
1006 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
1007 where int is good enough, as vsprintf returns an int.
1008 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
1009
a8290ec3
DA
10102012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1011
1012 Use make_formatted_string to avoid double length calculation.
1013 * lisp.h (make_formatted_string): New prototype.
1014 * alloc.c (make_formatted_string): New function.
1015 * buffer.c (Fgenerate_new_buffer_name): Use it.
1016 * dbus.c (syms_of_dbusbind): Likewise.
1017 * editfns.c (Fcurrent_time_zone): Likewise.
1018 * filelock.c (get_boot_time): Likewise.
1019 * frame.c (make_terminal_frame, set_term_frame_name)
1020 (x_report_frame_params): Likewise.
1021 * image.c (gs_load): Likewise.
1022 * minibuf.c (get_minibuffer): Likewise.
1023 * msdos.c (dos_set_window_size): Likewise.
1024 * process.c (make_process): Likewise.
1025 * xdisp.c (ensure_echo_area_buffers): Likewise.
1026 * xsettings.c (apply_xft_settings): Likewise.
1027
d01ba2f1
GM
10282012-07-09 Glenn Morris <rgm@gnu.org>
1029
1030 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
1031 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
1032 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
1033 * nsterm.h (ns_etc_directory): Add it.
1034 * callproc.c [HAVE_NS]: Include nsterm.h.
1035 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
1036
f1f924b6
DA
10372012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1038
1039 Move marker debugging code under MARKER_DEBUG.
1040 * marker.c (MARKER_DEBUG): Move marker debugging code under
1041 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
1042 for bootstrap with --enable-checking (~3x slowdown reported
1043 by Juanma Barranquero <lekktu@gmail.com>).
1044 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
1045
ab531b66
PE
10462012-07-08 Paul Eggert <eggert@cs.ucla.edu>
1047
1048 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
1049 See <http://bugs.gnu.org/11825#29>.
1050
c4b3bc8a
EZ
10512012-07-08 Eli Zaretskii <eliz@gnu.org>
1052
1053 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
1054 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
1055 (display_line): Add commentary about displaying truncation glyphs
1056 on GUI frames.
1057 (produce_special_glyphs): Move here from term.c.
1058
1059 * term.c (produce_special_glyphs): Move to xdisp.c.
1060
1061 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
1062 section.
c4b3bc8a 1063
b676b881
AS
10642012-07-07 Andreas Schwab <schwab@linux-m68k.org>
1065
f17c5273
AS
1066 * xdisp.c (display_line): Avoid warning about implicit declaration
1067 of FRAME_FONT.
1068
298819b9
AS
1069 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
1070
b676b881
AS
1071 * lisp.h: Remove empty conditional.
1072
6045c4fd
PE
10732012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1074
b3350bf9
PE
1075 * lread.c (load_path_check): Now static.
1076
6045c4fd
PE
1077 Fix some minor --with-ns problems found by static checking.
1078 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
1079 (x_set_font) [!HAVE_X_WINDOWS]:
1080 * image.c (xpm_load_image) [HAVE_NS]:
1081 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
1082 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
1083 Remove unused local.
1084 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
1085 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
1086 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
1087 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
1088 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
1089 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
1090 Fix pointer signedness problem.
1091 * xfaces.c (FRAME_X_FONT_TABLE):
1092 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
1093
929e7845
GM
10942012-07-07 Glenn Morris <rgm@gnu.org>
1095
1096 * lread.c (load_path_check): New function, split from init_lread.
1097 (init_lread): Reorganize. Motivation:
1098 If EMACSLOADPATH is set, check/warn about that rather than the
1099 defaults, which we are not going to use. Hence we can remove
1100 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
1101 Don't warn if site-lisp directories are missing.
1102 If not installed, start from a blank load-path, since
1103 PATH_LOADSEARCH refers to the eventual installation directories.
1104
58dd0aa4
EZ
11052012-07-07 Eli Zaretskii <eliz@gnu.org>
1106
1107 Support truncation and continuation glyphs on GUI frames, when
1108 fringes are disabled. (Bug#11832)
1109 * xdisp.c (init_iterator): Get dimensions of truncation and
1110 continuation glyphs even if on GUI frames. Adjust
1111 it->last_visible_x on GUI frames when the left or right fringes,
1112 or both, are absent.
1113 (start_display, move_it_in_display_line_to): Handle the case of a
1114 GUI frame without a fringe to display continuation or truncation
1115 glyphs.
1116 (insert_left_trunc_glyphs): Support GUI frames: make sure
1117 truncation glyphs overwrite enough glyphs from the current line to
1118 have sufficient space in pixels.
1119 (display_line): Support truncation and continuation glyphs on GUI
1120 frames. If some spare pixels are left on the line after inserting
1121 the truncation glyphs, fill that space with a stretch glyph of a
1122 suitably computed width.
1123
1124 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
1125 produce_glyphs, to support GUI sessions.
1126
31571fd7
PE
11272012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1128
5a16b9bc
PE
1129 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
1130
f3047c75
PE
1131 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
1132
31571fd7
PE
1133 Do not require float-time's arg to fit in time_t (Bug#11825).
1134 This works better on hosts where time_t is unsigned, and where
1135 float-time is applied to the (negative) difference between two times.
1136 * editfns.c (decode_time_components): Last arg is now double *,
1137 not int *, and means to store all the result as a double, without
1138 worrying about whether the seconds part fits in time_t.
1139 All callers changed.
1140 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
1141 All callers changed.
1142 (Ffloat_time): Do not fail merely because the specified time falls
1143 outside of time_t range.
1144
4516fbef
GM
11452012-07-07 Glenn Morris <rgm@gnu.org>
1146
1147 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
1148 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
1149 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
1150
07adc2c6
JB
11512012-07-07 Juanma Barranquero <lekktu@gmail.com>
1152
1153 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
1154 Update dependencies.
1155
1156 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
1157
fd573f31
PE
11582012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1159
fee5959d
PE
1160 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
1161 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
1162 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
1163 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
1164 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
1165 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
1166
fd573f31
PE
1167 * xfont.c (compare_font_names): Redo to omit the need for casts.
1168
ddadbc0e
AS
11692012-07-06 Andreas Schwab <schwab@linux-m68k.org>
1170
fca8d6b6
AS
1171 * xfns.c (Fx_change_window_property): Doc fix.
1172 * w32fns.c (Fx_change_window_property): Doc fix.
1173
ddadbc0e
AS
1174 * w32fns.c (Fx_window_property): Accept the same arguments as the
1175 X Windows version. Doc fix.
1176 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
1177
ed9265fc 11782012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
1179 Eli Zaretskii <eliz@gnu.org>
1180
1181 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
1182 Windows-specific code from nt/config.nt moved here.
1183 Obsolete settings removed.
1184
216ee680
PE
11852012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1186
1187 * process.c: Avoid unnecessary calls to gettime.
1188 (wait_reading_process_output): Don't get the time of day
1189 when gobbling data immediately and not waiting, as there's no need
1190 for it in that case. This removes a FIXME.
1191
bdd091e4
JD
11922012-07-06 Jan Djärv <jan.h.d@swipnet.se>
1193
1194 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
1195 is defined (Bug#11768).
1196
9d44f8ce
DA
11972012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1198
1199 Fix marker debugging code.
1200 * marker.c (byte_char_debug_check): Do not perform the check
1201 if buffer is not multibyte.
090bd7cb
JB
1202 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1203 Call byte_char_debug_check with correct arguments.
9d44f8ce 1204
90fc4786
DA
12052012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1206
1207 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
1208 * marker.c (byte_char_debug_check, count_markers):
1209 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
1210 (byte_debug_flag): Remove.
1211 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1212 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
1213
7b7ae965
DA
12142012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1215
4e57b342
DA
1216 Avoid code repetition in marker-related functions.
1217 * marker.c (attach_marker): New function.
1218 (Fset_marker, set_marker_restricted, set_marker_both)
1219 (set_marker_restricted_both): Use it.
1220 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
1221 Consistently rename charno to charpos.
1222 (marker_position): Add eassert.
1223 (marker_byte_position): Convert to eassert.
1224
12252012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1226
1227 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 1228 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 1229 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 1230
657924ff
DA
12312012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1232
1233 Introduce fast path for the widely used marker operation.
1234 * alloc.c (build_marker): New function.
1235 * lisp.h (build_marker): New prototype.
1236 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
1237 * composite.c (autocmp_chars): Likewise.
1238 * editfns.c (buildmark): Remove.
1239 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
1240 (save_restriction_save): Use build_marker.
1241 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
1242 * window.c (save_window_save): Likewise.
1243
041a49a6
DA
12442012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1245
1246 Do not use Fdelete_overlay in delete_all_overlays
1247 to avoid redundant calls to unchain_overlay.
1248 * buffer.c (drop_overlay): New function.
1249 (delete_all_overlays, Fdelete_overlay): Use it.
1250 * minibuf.c (get_minibuffer): Fix comment.
1251
7dca65a4
PE
12522012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1253
1254 Port to OpenBSD 5.1 amd64.
1255 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
1256 This is needed for OpenBSD, and should be harmless on all BSD systems.
1257 Also, include <sys/sysctl.h>, as it should be available on all
1258 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
1259 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
1260 use p_pid member, not kp_proc.pid.
1261
8eb876e2
GM
12622012-07-06 Glenn Morris <rgm@gnu.org>
1263
1264 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
1265
38182d90
PE
12662012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1267
1268 More xmalloc and related cleanup.
1269 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
1270 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
1271 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
1272 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
1273 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
1274 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
1275 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
1276 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
1277 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
1278 * xterm.c:
1279 Omit needless casts involving void * pointers and allocation.
1280 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
1281 as the former is more robust if P's type is changed.
1282 Prefer xzalloc to xmalloc + memset 0.
1283 Simplify malloc-or-realloc to realloc.
1284 Don't worry about xmalloc returning a null pointer.
1285 Prefer xstrdup to xmalloc + strcpy.
1286 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
1287 growing it.
1288 * keyboard.c (apply_modifiers_uncached): Prefer local array to
1289 alloca of a constant.
1290
6dd5a677
EZ
12912012-07-05 Eli Zaretskii <eliz@gnu.org>
1292
1293 * xdisp.c (display_line): Fix horizontal pixel coordinates when
1294 hscroll is larger than the line width. Fixes long and futile
1295 looping inside extend_face_to_end_of_line (on a TTY) producing
1296 glyphs that are not needed and thrown away.
1297
6b312f0f
DA
12982012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1299
1300 * marker.c (set_marker_restricted_both): Simplify by using
1301 clip_to_bounds.
1302
f520ef9b
PE
13032012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1304
1305 * editfns.c (region_limit): Simplify by using clip_to_bounds.
1306
383b7c95
JD
13072012-07-05 Jan Djärv <jan.h.d@swipnet.se>
1308
1309 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
1310 not defined (Bug#11768).
1311 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
1312 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
1313 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
1314 followed by gtk_box_set_homogeneous (Bug#11768).
1315 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
1316 (update_theme_scrollbar_width, xg_create_scroll_bar):
1317 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
1318 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
1319 (is_box_type): New function (Bug#11768).
1320 (xg_tool_item_stale_p): Call is_box_type.
5293d758 1321 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
1322 with default display (Bug#11768).
1323
d6e7bf45
EZ
13242012-07-05 Eli Zaretskii <eliz@gnu.org>
1325
1326 * xdisp.c (window_hscroll_limited): New function.
1327 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
1328 coordinates when window's hscroll is set to insanely large
1329 values. (Bug#11857)
1330
431391ec
JB
13312012-07-05 Juanma Barranquero <lekktu@gmail.com>
1332
1333 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
1334 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
1335
23f86fce
DA
13362012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1337
1338 Cleanup xmalloc.
1339 * lisp.h (xzalloc): New prototype. Omit needless casts.
1340 * alloc.c (xzalloc): New function. Omit needless casts.
1341 * charset.c: Omit needless casts. Convert all calls to
1342 xmalloc with following memset to xzalloc.
1343 * dispnew.c: Likewise.
1344 * fringe.c: Likewise.
1345 * image.c: Likewise.
1346 * sound.c: Likewise.
1347 * term.c: Likewise.
1348 * w32fns.c: Likewise.
1349 * w32font.c: Likewise.
1350 * w32term.c: Likewise.
1351 * xfaces.c: Likewise.
1352 * xfns.c: Likewise.
1353 * xterm.c: Likewise.
1354 * atimer.c: Omit needless casts.
1355 * buffer.c: Likewise.
1356 * callproc.c: Likewise.
1357 * ccl.c: Likewise.
1358 * coding.c: Likewise.
1359 * composite.c: Likewise.
1360 * doc.c: Likewise.
1361 * doprnt.c: Likewise.
1362 * editfns.c: Likewise.
1363 * emacs.c: Likewise.
1364 * eval.c: Likewise.
1365 * filelock.c: Likewise.
1366 * fns.c: Likewise.
1367 * gtkutil.c: Likewise.
1368 * keyboard.c: Likewise.
1369 * lisp.h: Likewise.
1370 * lread.c: Likewise.
1371 * minibuf.c: Likewise.
1372 * msdos.c: Likewise.
1373 * print.c: Likewise.
1374 * process.c: Likewise.
1375 * region-cache.c: Likewise.
1376 * search.c: Likewise.
1377 * sysdep.c: Likewise.
1378 * termcap.c: Likewise.
1379 * terminal.c: Likewise.
1380 * tparam.c: Likewise.
1381 * w16select.c: Likewise.
1382 * w32.c: Likewise.
1383 * w32reg.c: Likewise.
1384 * w32select.c: Likewise.
1385 * w32uniscribe.c: Likewise.
1386 * widget.c: Likewise.
1387 * xdisp.c: Likewise.
1388 * xmenu.c: Likewise.
1389 * xrdb.c: Likewise.
1390 * xselect.c: Likewise.
1391
0497dc44
PE
13922012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1393
1394 * fileio.c (time_error_value): Check the right error number.
1395 Problem reported by Troels Nielsen in
1396 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
1397
356e7178
PE
13982012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1399
4e71fd89
PE
1400 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
1401 This should be fixed in a better way; see Eli Zaretskii in
1402 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
1403 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
1404
f0941253
PE
1405 * fileio.c (time_error_value): Rename from special_mtime.
1406 The old name's problems were noted by Eli Zaretskii in
1407 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
1408
065c9eb4
PE
1409 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
1410 This variable's comment says Emacs needs at least one GDB-visible
1411 symbol of type enum pvec_type, to work around GDB problems.
1412 The symbol's value doesn't matter.
1413
356e7178
PE
1414 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
1415 that causes compilation to fail on pre-C99 compilers.
1416
ed9265fc 14172012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
1418
1419 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
1420 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
1421
3884d954
DA
14222012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1423
d209e2fb 1424 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
1425 headers for buffer_defaults and buffer_local_symbols.
1426 Reported by Juanma Barranquero <lekktu@gmail.com>.
1427
ee28be33
SM
14282012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1429
1430 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
1431 * lisp.h (enum pvec_type): Use fewer bits.
1432 (PSEUDOVECTOR_SIZE_BITS): New constant.
1433 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
1434 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
1435 change in pvec_type.
1436 (PSEUDOVECTOR_TYPEP): New macro.
1437 (TYPED_PSEUDOVECTORP): Use it.
1438 * fns.c (internal_equal): Adapt code to extract pvectype.
1439 * emacs.c (gdb_pvec_type): Update type.
1440 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
1441 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
1442 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
1443 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
1444 (sweep_vectors): Use it. Use local var `total_bytes' instead of
1445 abusing vector->header.next.nbytes.
1446 (live_vector_p): Use PVEC_TYPE.
1447 (mark_object): Adapt code to extract pvectype. Use switch.
1448
c7f2cd7f
PE
14492012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1450
1451 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
1452 Tighten new eassert a bit.
1453
8ce70ed2
DA
14542012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1455
1456 Fix compilation with --enable-gcc-warnings and -O1
1457 optimization level.
1458 * doprnt.c (doprnt): Change type of tem to int, initialize
1459 to avoid compiler warning. Add eassert.
1460 * search.c (simple_search): Initialize match_byte to avoid
1461 compiler warning. Add eassert.
1462
dea7f1e5
PE
14632012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1464
24a212eb
PE
1465 Avoid weird behavior with large horizontal scrolls.
1466 Without this change, for example, large hscroll values would
1467 mess up Emacs's display on Fedora 15 x86, presumably due to
1468 overflows in int calculations in the display code.
1469 Also, if buffers had long lines, Emacs would freeze.
1470 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
1471 (set_window_hscroll): New function, containing the old guts of
1472 Fset_window_hscroll. Return the clipped value.
1473 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
1474 This avoids the need to check against PTRDIFF_MAX.
1475
dea7f1e5
PE
1476 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
1477
76046526
DA
14782012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1479
1480 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
1481
39adff0d
PE
14822012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1483
63807d47
PE
1484 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
1485 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
1486 since GCC 4.4.6 issues a bogus warning for them.
1487
39adff0d
PE
1488 Fix bugs in file timestamp newness comparisons.
1489 * fileio.c (Ffile_newer_than_file_p):
1490 * lread.c (Fload): Use full timestamp resolution of files,
1491 not just the 1-second resolution, so that files that are only
1492 slightly newer still count as newer.
1493 * fileio.c (Ffile_newer_than_file_p): Don't assume file
1494 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
1495
dbeed9a6
PE
14962012-07-03 Paul Eggert <eggert@cs.ucla.edu>
1497
1498 * fileio.c: Improve handling of file time marker. (Bug#11852)
1499 (special_mtime): New function.
1500 (Finsert_file_contents, Fverify_visited_file_modtime):
1501 Use it to set special mtime values consistently.
1502
636334d6
AS
15032012-07-03 Andreas Schwab <schwab@linux-m68k.org>
1504
1505 * fileio.c (Finsert_file_contents): Properly handle st_mtime
1506 marker for non-existing file. (Bug#11852)
1507
e2017fe2
GM
15082012-07-03 Glenn Morris <rgm@gnu.org>
1509
1510 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
1511 and did not make it into globals.h).
1512
404dbd37
TT
15132012-07-03 Tom Tromey <tromey@redhat.com>
1514
1515 * window.c (Fset_window_margins, Fset_window_fringes)
1516 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
1517 * textprop.c (Fprevious_property_change): No longer static.
1518 * syntax.c (Fsyntax_table_p): No longer static.
1519 * process.c (Fget_process, Fprocess_datagram_address): No longer
1520 static.
1521 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
1522 * keyboard.c (Fcommand_execute): No longer static.
1523 Remove EXFUN.
1524 * insdel.c (Fcombine_after_change_execute): No longer static.
1525 * image.c (Finit_image_library): No longer static.
1526 * fileio.c (Fmake_symbolic_link): No longer static.
1527 * eval.c (Ffetch_bytecode): No longer static.
1528 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
1529 * doc.c (Fdocumentation_property, Fsnarf_documentation):
1530 No longer static.
404dbd37
TT
1531 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
1532 static.
1533 * dired.c (Ffile_attributes): No longer static.
1534 * composite.c (Fcomposition_get_gstring): No longer static.
1535 * callproc.c (Fgetenv_internal): No longer static.
1536
1537 * ccl.h: Remove EXFUNs.
1538 * buffer.h: Remove EXFUNs.
1539 * dispextern.h: Remove EXFUNs.
1540 * intervals.h: Remove EXFUNs.
1541 * fontset.h: Remove EXFUN.
1542 * font.h: Remove EXFUNs.
1543 * dosfns.c (system_process_attributes): Remove EXFUN.
1544 * keymap.h: Remove EXFUNs.
1545 * lisp.h: Remove EXFUNs.
1546 * w32term.h: Remove EXFUNs.
1547 * window.h: Remove EXFUNs.
1548 * xsettings.h: Remove EXFUN.
1549 * xterm.h: Remove EXFUN.
1550
8e4fd1e1
GM
15512012-07-03 Glenn Morris <rgm@gnu.org>
1552
1553 * lisp.h (Frandom): Make it visible to C.
1554 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
1555 buffer for invisible buffers. (Bug#1229)
1556
ca95b3eb
DA
15572012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1558
1559 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
1560 values which aren't power of 2.
1561 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
1562 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
1563 accordingly.
1564
7555c33f
SM
15652012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
1566
1567 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
1568
1569 * alloc.c (mark_object): Revert part of last patch to use `switch'.
1570
d12e8f5a
DA
15712012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1572
1573 * alloc.c (allocate_vector_block): Remove redundant
1574 calls to mallopt if DOUG_LEA_MALLOC is defined.
1575 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
1576 avoid calls to mallopt if zero_vector is returned.
1577
296094c3
DA
15782012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1579
1580 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
1581 is enabled, avoid dereferencing NULL current_sblock if
1582 running undumped.
1583
36429c89
DA
15842012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1585
1586 Cleanup basic buffer management.
1587 * buffer.h (struct buffer): Change layout to use generic vector
1588 marking code. Fix some comments. Change type of 'clip_changed'
1589 to bitfield. Remove unused #ifndef old.
1590 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
1591 (GET_OVERLAYS_AT): Fix indentation.
1592 (for_each_per_buffer_object_at): New macro.
1593 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
1594 (Fbuffer_local_variables): Use it.
1595 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
1596 * alloc.c (allocate_buffer): Adjust to match new layout of
1597 struct buffer. Fix comment.
1598 (mark_overlay): New function.
1599 (mark_buffer): Use it. Use mark_vectorlike to mark normal
1600 Lisp area of struct buffer.
1601 (mark_object): Use it. Adjust marking of misc objects
1602 and related comments.
1603
3b3e4cac
PE
16042012-07-02 Paul Eggert <eggert@cs.ucla.edu>
1605
1606 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
1607 wrapper that is not needed because the wrapped code is a no-op (zero
1608 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
1609 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
1610
cf5c0175
DA
16112012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
1612
1613 * alloc.c (mark_buffer): Simplify. Remove prototype.
1614 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 1615 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
1616 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
1617 redundant calls to mark_vectorlike for bool vectors.
1618
ca26824c
GM
16192012-06-30 Glenn Morris <rgm@gnu.org>
1620
2e4c5312
GM
1621 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
1622
ca26824c
GM
1623 * epaths.in (PATH_SITELOADSEARCH): New.
1624 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
1625 This is rather than relying on --enable-locallisppath elements
1626 having "site-lisp" in their names. (Bug#10208#25, 11658)
1627
0d23c240
EZ
16282012-06-30 Eli Zaretskii <eliz@gnu.org>
1629
c9240d7a
EZ
1630 * w32proc.c (sys_select): Accept and ignore one more argument.
1631
1632 * w32.c (emacs_gnutls_pull): Call select with one more argument.
1633
0d23c240 1634 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 1635 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
1636
1637 * sysdep.c: Don't include dos.h and dosfns.h.
1638
1639 * process.c (sys_select):
1640 * msdos.c (sys_select): Accept one more argument and ignore it.
1641
1642 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
1643 adapt data types and code to that.
1644
1645 * dosfns.c:
1646 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
1647 which clashes with the gnulib function of the same name.
1648
af5a5a98
AS
16492012-06-30 Andreas Schwab <schwab@linux-m68k.org>
1650
c5e4379c
AS
1651 * font.c (font_style_to_value, font_style_symbolic)
1652 (font_prop_validate_style): Add type checks for values in
1653 font_style_table.
1654
af5a5a98
AS
1655 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
1656 argument.
1657 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
1658 uses.
1659
8d38f461
EZ
16602012-06-29 Eli Zaretskii <eliz@gnu.org>
1661
2e5a6631
EZ
1662 * xdisp.c (try_window_id): Undo last change.
1663
8d38f461
EZ
1664 * w32.c (getwd): Adjust commentary about startup_dir.
1665 (init_environment): Always call sys_access, even in non-MSVC
1666 builds. Don't chdir to the directory of the Emacs executable.
1667 This undoes code from 1997 which was justified by the need to
1668 "avoid conflicts when removing and renaming directories". But its
1669 downside was that every relative file name was being interpreted
1670 relative to the directory of the Emacs executable, which can never
1671 be TRT. In particular, it broke sys_access when called with
1672 relative file names.
1673 (sys_access): Map GetLastError to errno.
1674
2af3565e
DA
16752012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1676
1677 * window.h (struct window): Change type of 'fringes_outside_margins'
1678 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 1679 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
1680 Adjust comment.
1681 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
1682 to ptrdiff_t.
1683
c8d3a25c 16842012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 1685
c8d3a25c
GM
1686 * gnutls.c (emacs_gnutls_handshake):
1687 Add QUIT to make the loop interruptible.
57570cd3 1688
c8d3a25c 16892012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 1690
c8d3a25c
GM
1691 * charset.c (init_charset): Make lack of etc/charsets fatal.
1692
3e984ee8
DA
16932012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1694
1695 * editfns.c (region_limit): Fix type mismatch.
1696
ef884f23
DA
16972012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1698
1699 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
1700 undefined. Convert from xassert to eassert.
1701 * nsmenu.m: Convert from xassert to eassert.
1702 * nsterm.m: Likewise.
1703
7d7e0027
SM
17042012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
1705
1706 * editfns.c (region_limit): Clip to narrowing (bug#11770).
1707
aa754e6a
PE
17082012-06-28 Paul Eggert <eggert@cs.ucla.edu>
1709
1710 Avoid integer overflow on scroll-left and scroll-right.
1711 * window.c (HSCROLL_MAX): New macro.
1712 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
1713 overflow when requested scroll falls outside ptrdiff_t range.
1714
80b00b08
DA
17152012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1716
1717 * window.h (struct window): Change type of 'hscroll',
1718 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
1719 'last_modified' and 'last_overlay_modified' to EMACS_INT.
1720 Adjust users accordingly.
1721 * xdisp.c (try_cursor_movement): Replace type check with eassert.
1722 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
1723 from EMACS_INT to ptrdiff_t.
1724 (make_window): Omit redundant initialization.
1725
62b2bcf6
JB
17262012-06-28 Juanma Barranquero <lekktu@gmail.com>
1727
1728 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
1729
45942c7d
DA
17302012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1731
1732 * window.h (struct window): Change type of 'use_time' and
1733 'sequence_number' from Lisp_Object to int.
1734 * frame.c (make_frame): Adjust users accordingly.
1735 * print.c (print_object): Likewise.
1736 * window.c (select_window, Fwindow_use_time, make_parent_window)
1737 (make_window): Likewise.
1738
e509cfa6
DA
17392012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1740
1741 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
1742 enabled with --enable-checking=[all,glyphs] configure option.
1743 Fix GLYPH_DEBUG usage assuming that it may be undefined,
1744 adjust comments accordingly.
1745 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
1746 undefined, adjust comments accordingly.
1747 * image.c: Likewise.
1748 * scroll.c: Likewise.
1749 * w32fns.c: Likewise.
1750 * w32term.c: Likewise.
1751 * xdisp.c: Likewise.
1752 * xfaces.c: Likewise.
1753 * xfns.c: Likewise.
1754 * xterm.c: Likewise.
1755
a54e2c05
DA
17562012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1757
1758 Generalize run-time debugging checks.
1759 * dispextern.h (XASSERTS): Remove.
1760 * fontset.c (xassert): Remove.
1761 Convert from xassert to eassert.
1762 * alloc.c: Convert from xassert to eassert.
1763 * bidi.c: Likewise.
1764 * dispnew.c: Likewise.
1765 * fns.c: Likewise.
1766 * fringe.c: Likewise.
1767 * ftfont.c: Likewise.
1768 * gtkutil.c: Likewise.
1769 * image.c: Likewise.
1770 * keyboard.c: Likewise.
1771 * menu.c: Likewise.
1772 * process.c: Likewise.
1773 * scroll.c: Likewise.
1774 * sound.c: Likewise.
1775 * term.c: Likewise.
1776 * w32console.c: Likewise.
1777 * w32fns.c: Likewise.
1778 * w32term.c: Likewise.
1779 * window.c: Likewise.
1780 * xdisp.c: Likewise.
1781 * xfaces.c: Likewise.
1782 * xfns.c: Likewise.
1783 * xselect.c: Likewise.
1784 * xterm.c: Likewise.
1785
1ec4b7b2
SM
17862012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
1787
1788 * fns.c (maybe_resize_hash_table): Output message when growing the
1789 purify-hashtable.
1790
2014308a
DA
17912012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1792
1793 * alloc.c (allocate_string_data): Remove dead code.
1794 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
1795 avoid GCC warning about unused macro.
1796
246155eb
DA
17972012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1798
1799 * alloc.c (allocate_string): Omit intervals initialization.
1800 * alloc.c (make_uninit_multibyte_string): Initialize intervals
1801 as in make_pure_string and make_pure_c_string.
1802
43184b7b
DA
18032012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1804
d209e2fb 1805 * alloc.c (allocate_string): Fix last change.
43184b7b 1806
3fe6dd74
DA
18072012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1808
d209e2fb 1809 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
1810 to memset, add explicit initialization where appropriate.
1811
1ba6038a
GM
18122012-06-27 Glenn Morris <rgm@gnu.org>
1813
1814 * lisp.mk (lisp): Remove paths.elc.
1815
c89926a5
CY
18162012-06-27 Chong Yidong <cyd@gnu.org>
1817
1818 * doc.c (Fsubstitute_command_keys): Fix punctuation.
1819
ed6b3510
JW
18202012-06-26 John Wiegley <johnw@newartisans.com>
1821
1ec4b7b2 1822 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
1823 on Mac OS X Lion: __mod_init_func and __mod_term_func.
1824
ed6b3510
JW
1825 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
1826 when building with Clang.
1827
8edd4a2b
SM
18282012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
1829
1830 * eval.c (Fapply): Allow calling it with a single argument.
1831
f6f62d1b
EZ
18322012-06-26 Eli Zaretskii <eliz@gnu.org>
1833
1834 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
1835 _stricmp and _strnicmp.
1836 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
1837
62efea5e
DA
18382012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1839
1840 * alloc.c (allocate_window): Zero out non-Lisp part of newly
1841 allocated window.
1842 (allocate_process): Likewise for new process.
8edd4a2b 1843 (allocate_terminal): Change to use offsetof.
62efea5e
DA
1844 (allocate_frame): Likewise.
1845 * frame.c (make_frame): Omit redundant initialization.
1846 * window.c (make_parent_window): Use memset.
1847 (make_window): Omit redundant initialization.
1848 * process.c (make_process): Omit redundant initialization.
1849 * terminal.c (create_terminal): Likewise.
1850
42997f4d
DA
18512012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1852
1853 * term.c (delete_tty): Remove redundant call to memset.
1854
1130ecfc
DA
18552012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1856
1857 * alloc.c: Remove build_string.
1858 * lisp.h: Define build_string as static inline. This provides
1859 a better opportunity to optimize away calls to strlen when the
1860 function is called with compile-time constant argument.
1861 * image.c (imagemagick_error): Convert to build_string.
1862 * w32proc.c (sys_spawnve): Likewise.
1863 * xterm.c (x_term_init): Likewise.
1864
cf38a720
PE
18652012-06-26 Paul Eggert <eggert@cs.ucla.edu>
1866
99027bdd
PE
1867 Use sprintf return value instead of invoking strlen on result.
1868 In the old days this wasn't portable, since some sprintf
1869 implementations returned char *. But they died out years ago and
1870 Emacs already assumes sprintf returns int.
1871 Similarly for float_to_string.
1872 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
1873 * ccl.c (ccl_driver):
1874 * character.c (string_escape_byte8):
1875 * data.c (Fnumber_to_string):
1876 * doprnt.c (doprnt):
1877 * print.c (print_object):
1878 * xdisp.c (message_dolog):
1879 * xfns.c (syms_of_xfns):
1880 Use sprintf or float_to_string result to avoid need to call strlen.
1881 * data.c (Fnumber_to_string):
1882 Use make_unibyte_string, since the string must be ASCII.
1883 * lisp.h, print.c (float_to_string): Now returns int length.
1884 * term.c (produce_glyphless_glyph):
1885 Use sprintf result rather than recomputing it.
1886
cf38a720
PE
1887 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
1888 * Makefile.in (ALL_CFLAGS):
1889 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
1890 * gmalloc.c, regex.c: Include <config.h> unconditionally.
1891
3511c784
DA
18922012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1893
0a08eb21 1894 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
1895 strcasecmp if available.
1896 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
1897
fb7da12e
AS
18982012-06-25 Andreas Schwab <schwab@linux-m68k.org>
1899
1900 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
1901 Avoid comma operator.
1902 * menu.c (push_submenu_start, push_submenu_end)
1903 (push_left_right_boundary, push_menu_pane): Likewise.
1904 * msdos.c (dos_rawgetc): Likewise.
1905
afa2ffd8
DA
19062012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1907
1908 * xfns.c (xic_create_fontsetname): Remove redundant calls
1909 to memset.
1910
b3b4476b
PE
19112012-06-25 Paul Eggert <eggert@cs.ucla.edu>
1912
4495ff38
PE
1913 * gtkutil.c (get_utf8_string): Remove redundant assignment.
1914 sprintf already null-terminates its output.
1915
b3b4476b
PE
1916 * xfns.c (x_window): Remove redundant cast.
1917
b00876c9
DA
19182012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1919
1920 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
1921 `const char *' to `char *' to avoid compiler warning.
1922
d188e26b
PE
19232012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1924
885d1d74
PE
1925 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
1926 instead of truncating it to 63 (admittedly a generous limit).
1927
d188e26b
PE
1928 * process.c: Fix spelling and caps in comments.
1929
e2f560b1
DN
19302012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
1931
e86db54b 1932 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
1933 * sysdep.c (setpgrp): Remove definition, not used in this file.
1934
7583a3a1
JB
19352012-06-24 Juanma Barranquero <lekktu@gmail.com>
1936
1937 * makefile.w32-in: Update dependencies.
1938
696056c2
EZ
19392012-06-24 Eli Zaretskii <eliz@gnu.org>
1940
1941 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
1942 (SYSTIME_H): Add nt/inc/sys/time.h.
1943
1944 * systime.h [WINDOWSNT]: Include sys/time.h.
1945
1946 * s/ms-w32.h (struct timespec): Definition moved from
1947 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
1948
845ca893
PE
19492012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1950
1951 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
1952 * buffer.h (buffer_slot_type_mismatch):
1953 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1954 * eval.c (unwind_to_catch):
1955 * image.c (my_png_error, my_error_exit):
1956 * keyboard.c (quit_throw_to_read_char, user_error)
1957 (Fexit_recursive_edit, Fabort_recursive_edit):
1958 * lisp.h (die, args_out_of_range, args_out_of_range_3)
1959 (wrong_type_argument, buffer_overflow, __executable_start)
1960 (memory_full, buffer_memory_full, string_overflow, Fthrow)
1961 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
1962 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
1963 (fatal):
1964 (child_setup) [!DOS_NT]:
1965 * lread.c (end_of_file_error, invalid_syntax):
1966 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1967 * puresize.h (pure_write_error):
1968 * search.c (matcher_overflow):
1969 * sound.c (sound_perror, alsa_sound_perror):
1970 * sysdep.c, syssignal.h (croak):
1971 * term.c (maybe_fatal, vfatal):
1972 * textprop.c (text_read_only):
1973 * undo.c (user_error):
1974 * unexmacosx.c (unexec_error):
1975 * xterm.c (x_ins_del_lines, x_delete_glyphs):
1976 Use _Noreturn rather than NO_RETURN.
1977 No need for separate decl merely because of _Noreturn.
1978 * sound.c (sound_warning, parse_sound):
1979 Remove unnecessary forward decls.
1980
f1dd8073
PE
19812012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1982
1983 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
1984 * lisp.h (WAIT_READING_MAX): New macro.
1985 * dispnew.c (Fsleep_for, sit_for):
1986 * keyboard.c (kbd_buffer_get_event):
1987 * process.c (Faccept_process_output):
1988 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
1989 This improves on the previous patch, which introduced a bug
1990 when time_t is unsigned and as wide as intmax_t.
1991 See <http://bugs.gnu.org/9000#51>.
1992
b82c1755
EZ
19932012-06-23 Eli Zaretskii <eliz@gnu.org>
1994
1995 * dispnew.c (sit_for, Fsleep_for):
1996 * keyboard.c (kbd_buffer_get_event):
1997 * process.c (Faccept_process_output): Avoid compiler warnings when
1998 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
1999
ca300656
JB
20002012-06-23 Juanma Barranquero <lekktu@gmail.com>
2001
049ec95b
JB
2002 * makefile.w32-in: Update dependencies.
2003
ca300656
JB
2004 * w32.c (ltime): Add return type and declare static.
2005 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
2006
db7b8d06
PE
20072012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2008
2009 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
2010 Privately reported by Herbert J. Skuhra.
2011 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
2012 All uses changed.
2013 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
2014 not make_lisp_timeval, when the argument is of type EMACS_TIME.
2015
0bd8297f
EZ
20162012-06-23 Eli Zaretskii <eliz@gnu.org>
2017
96512555
EZ
2018 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
2019 last argument of make_unibyte_string.
2020
0bd8297f
EZ
2021 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
2022 language ID in the event parameters.
2023
2024 * w32term.c (w32_read_socket): Put the new keyboard codepage into
2025 event.code, not the obscure "character set ID".
2026
63def6b6
CY
20272012-06-23 Chong Yidong <cyd@gnu.org>
2028
2029 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
2030
e8a02204
EZ
20312012-06-23 Eli Zaretskii <eliz@gnu.org>
2032
388cdec0
EZ
2033 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
2034 * w32.c (fdutimens): New function.
2035
2036 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
2037
2038 * s/ms-w32.h (pselect): Redirect to sys_select.
2039
2040 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
2041
e8a02204
EZ
2042 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
2043 in the logic of incrementing and decrementing the value of
2044 use_relocatable_buffers.
2045
d054f3fb
PE
20462012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2047
2048 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
2049 Privately reported by Herbert J. Skuhra.
2050 [__FreeBSD__]: Remove "*/" typo after "#include".
2051 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
2052 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
2053 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
2054 Don't assume EMACS_TIME and struct timeval are the same type.
2055
d35af63c
PE
20562012-06-22 Paul Eggert <eggert@cs.ucla.edu>
2057
2058 Support higher-resolution time stamps (Bug#9000).
2059 The time stamps are only nanosecond-resolution at the C level,
2060 since that's the best that any real-world system supports now.
2061 But they are picosecond-resolution at the Lisp level, as that's
2062 easy, and leaves room for future OS improvements.
2063
2064 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
2065 (LIBES): Use it.
2066
2067 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
2068 Don't get current time unless it's needed.
2069
2070 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
2071 now provides it if it's absent.
2072 (start_atimer): Port to higher-res time stamps.
2073 Check for time stamp overflow. Don't get current time more
2074 often than is needed.
2075
2076 * buffer.h (struct buffer): Buffer modtime now has high resolution.
2077 Include systime.h, not time.h.
2078 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
2079
2080 * dired.c: Include stat-time.h.
2081 (Ffile-attributes): File times now have higher resolution.
2082
2083 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
2084 (struct image): Timestamp now has higher resolution.
2085
2086 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
2087 has at least microseconds now. All uses removed.
2088 (update_frame, update_single_window, update_window, update_frame_1)
2089 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
2090
2091 * editfns.c (time_overflow): Now extern.
2092 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
2093 (float-time, Fformat_time_string, Fcurrent_time_string)
2094 (Fcurrent_time_zone): Accept and generate higher-resolution
2095 time stamps.
2096 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
2097 (decode_time_components, lisp_seconds_argument): New functions.
2098 (make_time): Now static.
2099 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
2100 Report an error if the time is invalid, rather than having the caller
2101 do that.
2102
2103 * fileio.c: Include <stat-time.h>
2104 (Fcopy_file): Copy higher-resolution time stamps.
2105 Prefer to set the time stamp via a file descriptor if that works.
2106 (Fset_file_times, Finsert_file_contents, Fwrite_region)
2107 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
2108 (Fvisited_file_modtime, Fset_visited_file_modtime):
2109 Support higher-resolution time stamps.
2110
2111 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
2112
2113 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
2114
2115 * image.c (prepare_image_for_display, clear_image_cache)
2116 (lookup_image): Port to higer-resolution time stamps.
2117
2118 * keyboard.c (start_polling, bind_polling_period):
2119 Check for time stamp overflow.
2120 (read_char, kbd_buffer_get_event, timer_start_idle)
2121 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
2122 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
2123 Port to higher-resolution time stamps. Do not assume time_t is signed.
2124 (decode_timer): New function. Timers are now vectors of length 9,
2125 not 8, to accommodate the picosecond component.
2126 (timer_check_2): Use it.
2127
2128 * nsterm.m (select_timeout, timeval_subtract): Remove.
2129 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
2130 as they're a bit more accurate and handle overflow better.
2131 (ns_select): Change prototype to be compatible with pselect.
2132 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
2133 * nsterm.h (ns_select): Adjust prototype.
2134
2135 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
2136 us-resolution time stamps.
2137 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
2138
2139 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
2140
2141 * lisp.h (time_overflow): New decl.
2142 (wait_reading_process_output): First arg is now intmax_t, not int,
2143 to accommodate larger waits.
2144
2145 * process.h (struct Lisp_Process.read_output_delay):
2146 Now counts nanoseconds, not microseconds.
2147 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
2148 EMACS_HAS_USECS.
2149 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
2150 (wait_reading_process_output):
2151 Port to ns-resolution time stamps.
2152 (Faccept_process_output, wait_reading_process_output):
2153 Check for time stamp overflow. Do not assume time_t is signed.
2154 (select_wrapper): Remove; we now use pselect.
2155 (Fprocess_attributes): Now generates ns-resolution time stamps.
2156
2157 * sysdep.c: Include utimens.h. Don't include utime.h
2158 or worry about struct utimbuf; gnulib does that for us now.
2159 (gettimeofday): Remove; gnulib provides a substitute.
2160 (make_timeval): New function.
2161 (set_file_times): Now sets ns-resolution time stamps.
2162 New arg FD; all uses changed.
2163 (time_from_jiffies, ltime_from_jiffies, get_up_time)
2164 (system_process_attributes):
2165 Now returns ns-resolution time stamp. All uses changed.
2166 Check for time stamp overflow.
2167
2168 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
2169 provides a substitute now.
2170
2171 * systime.h: Include timespec.h rather than sys/time.h and time.h,
2172 since it guarantees struct timespec.
2173 (EMACS_TIME): Now struct timespec, so that we can support
2174 ns-resolution time stamps.
2175 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
2176 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
2177 (EMACS_USECS): Remove.
2178 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
2179 so multiply the arg by 1000 before storing it.
2180 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
2181 New macros.
2182 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
2183 Port to ns-resolution time stamps.
2184 (EMACS_TIME_NEG_P): Remove; replaced by....
2185 (EMACS_TIME_SIGN): New macro.
2186 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
2187 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
2188 (set_file_times, make_time, lisp_time_argument): Adjust signature.
2189 (make_timeval, make_lisp_time, decode_time_components): New decls.
2190 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
2191 that it mishandled time_t overflow. You can't compare by subtracting!
2192 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
2193 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
2194
2195 * term.c: Include <sys/time.h>.
2196 (timeval_to_Time): New function, for proper overflow wraparound.
2197 (term_mouse_position, term_mouse_click): Use it.
2198
2199 * undo.c (record_first_change): Support higher-resolution time stamps
2200 in the undo buffer.
2201 (Fprimitive_undo): Use them when restoring time stamps.
2202
2203 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
2204 (w32_get_internal_run_time):
2205 Port to higher-resolution Emacs time stamps.
2206 (ltime): Now accepts single 64-bit integer, as that's more convenient
2207 for callers.
2208
2209 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
2210
2211 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
2212 for compatibility with pselect. Support ns-resolution time stamps.
2213
2214 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
2215
2216 * xselect.c (wait_for_property_change, x_get_foreign_selection):
2217 Check for time stamp overflow, and support ns-resolution time stamps.
2218
2219 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
2220 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
2221 (timeval_subtract): Remove; no longer needed.
2222 (XTflash, XTring_bell, x_wait_for_event):
2223 Port to ns-resolution time stamps. Don't assume time_t is signed.
2224
b6a92dfe
CY
22252012-06-22 Chong Yidong <cyd@gnu.org>
2226
2227 * xdisp.c (x_consider_frame_title): Revert last change.
2228
d251c37c
EZ
22292012-06-22 Eli Zaretskii <eliz@gnu.org>
2230
2231 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
2232 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
2233 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
2234 staticidx goes up to 1597 out of 1600 = 0x640.)
2235
f10deafb
PE
22362012-06-20 Paul Eggert <eggert@cs.ucla.edu>
2237
2238 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
2239 Otherwise, the umask might be mistakenly 0 while handling input signals.
2240
ec6de1e2
SM
22412012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
2242
2243 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
2244
28be1ada
DA
22452012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
2246
2247 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
2248 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
2249 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
2250 access to `contents' member of Lisp_Vector objects with AREF and ASET
2251 where appropriate.
2252
c6bf3022
CY
22532012-06-19 Chong Yidong <cyd@gnu.org>
2254
2255 * frame.c (delete_frame): When selecting a frame on a different
2256 text terminal, do not alter the terminal's top-frame.
2257
2258 * xdisp.c (format_mode_line_unwind_data): Record the target
2259 frame's selected window and its terminal's top-frame.
2260 (unwind_format_mode_line): Restore them.
2261 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
2262 Callers changed.
2263 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
2264 since tty frames can be explicitly named.
2265 (prepare_menu_bars): Likewise.
2266
2267 * term.c (Ftty_top_frame): New function.
2268
defd4196
PE
22692012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2270
2271 Port byte-code-meter to modern targets.
2272 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
2273 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 2274 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
2275 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
2276 (METER_1, METER_2): Simplify.
2277
1053a871
SM
22782012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
2279
2280 * data.c (Fdefalias): Return `symbol' (bug#11686).
2281
b7e8d081
MR
22822012-06-18 Martin Rudalics <rudalics@gmx.at>
2283
2284 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
2285 gets killed during executing of this function (Bug#11665).
2286 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
2287 (Vkill_buffer_query_functions): In doc-string say that functions
2288 run by this hook should not change the current buffer.
2289
7ea2b339
PE
22902012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2291
2292 Fix recently-introduced process.c problems found by static checking.
2293 * process.c (write_queue_push, write_queue_pop, send_process):
2294 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
2295 (write_queue_pop): Fix pointer signedness problem.
2296 (send_process): Remove unused local.
2297
96a313a1
CY
22982012-06-17 Chong Yidong <cyd@gnu.org>
2299
2300 * xdisp.c (redisplay_internal): No need to redisplay terminal
2301 frames that are not on top.
2302
20ca2e94
TN
23032012-06-17 Troels Nielsen <bn.troels@gmail.com>
2304
2305 * process.c (make_process): Initialize write_queue.
2306 (write_queue_push, write_queue_pop): New functions.
2307 (send_process): Use them to maintain correct ordering of process
2308 writes (Bug#10815).
2309
9a900ca9
PE
23102012-06-17 Paul Eggert <eggert@cs.ucla.edu>
2311
310fbfa8
PE
2312 * lisp.h (eassert): Assume C89 or later.
2313 This removes the need for CHECK.
2314 (CHECK): Remove. Its comments about always evaluating its
2315 argument were confusing, as 'eassert' typically does not evaluate
2316 its argument.
2317
27bb1ca4
PE
2318 * coding.c (produce_chars): Use ptrdiff_t, not int.
2319
9a900ca9
PE
2320 * xterm.c (x_draw_underwave): Check for integer overflow.
2321 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
2322
41b7f8bc 23232012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
2324
2325 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
2326 referenced (Bug#11583).
2327
9b0e3eba
AA
23282012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
2329
2330 Implement wave-style variant of underlining.
2331 * dispextern.h (face_underline_type): New enum.
2332 (face): Add field for underline type.
2333 * nsterm.m (ns_draw_underwave): New function.
2334 (ns_draw_text_decoration): Use it.
2335 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
2336 New functions.
2337 (x_draw_glyph_string): Use them.
2338 * xfaces.c (Qline, Qwave): New Lisp objects.
2339 (check_lface_attrs, merge_face_ref)
1053a871
SM
2340 (Finternal_set_lisp_face_attribute, realize_x_face):
2341 Handle wave-style underline face attributes.
9b0e3eba
AA
2342 * xterm.c (x_draw_underwave): New function.
2343 (x_draw_glyph_string): Use it.
2344
0fb52f11
JB
23452012-06-16 Juanma Barranquero <lekktu@gmail.com>
2346
2347 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
2348 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
2349 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
2350 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
2351 ($(BLD)/w32select.$(O)): Update dependencies.
2352
e5560ff7
AS
23532012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2354
2355 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
2356 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
2357 * character.c (_fetch_multibyte_char_p): Remove.
2358 * alloc.c: Include "character.h" before "buffer.h".
2359 * bidi.c: Likewise.
2360 * buffer.c: Likewise.
2361 * bytecode.c: Likewise.
2362 * callint.c: Likewise.
2363 * callproc.c: Likewise.
2364 * casefiddle.c: Likewise.
2365 * casetab.c: Likewise.
2366 * category.c: Likewise.
2367 * cmds.c: Likewise.
2368 * coding.c: Likewise.
2369 * composite.c: Likewise.
2370 * dired.c: Likewise.
2371 * dispnew.c: Likewise.
2372 * doc.c: Likewise.
2373 * dosfns.c: Likewise.
2374 * editfns.c: Likewise.
2375 * emacs.c: Likewise.
2376 * fileio.c: Likewise.
2377 * filelock.c: Likewise.
2378 * font.c: Likewise.
2379 * fontset.c: Likewise.
2380 * fringe.c: Likewise.
2381 * indent.c: Likewise.
2382 * insdel.c: Likewise.
2383 * intervals.c: Likewise.
2384 * keyboard.c: Likewise.
2385 * keymap.c: Likewise.
2386 * lread.c: Likewise.
2387 * macros.c: Likewise.
2388 * marker.c: Likewise.
2389 * minibuf.c: Likewise.
2390 * nsfns.m: Likewise.
2391 * nsmenu.m: Likewise.
2392 * print.c: Likewise.
2393 * process.c: Likewise.
2394 * regex.c: Likewise.
2395 * region-cache.c: Likewise.
2396 * search.c: Likewise.
2397 * syntax.c: Likewise.
2398 * term.c: Likewise.
2399 * textprop.c: Likewise.
2400 * undo.c: Likewise.
2401 * unexsol.c: Likewise.
2402 * w16select.c: Likewise.
2403 * w32fns.c: Likewise.
2404 * w32menu.c: Likewise.
2405 * window.c: Likewise.
2406 * xdisp.c: Likewise.
2407 * xfns.c: Likewise.
2408 * xmenu.c: Likewise.
2409 * xml.c: Likewise.
2410 * xselect.c: Likewise.
2411
2f07e6af
EZ
24122012-06-16 Eli Zaretskii <eliz@gnu.org>
2413
1053a871
SM
2414 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
2415 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 2416 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
2417 row.
2418 (handle_face_prop): Use chunk-relative overlay string index when
2419 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
2420 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
2421 the rightmost. (Bug#11720)
2f07e6af 2422
29b83cec
AS
24232012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2424
2425 * category.h (CHAR_HAS_CATEGORY): Define as inline.
2426 (CATEGORY_MEMBER): Enforce 1/0 value.
2427 * category.c (_temp_category_set): Remove.
2428
4c5501e9
EZ
24292012-06-16 Eli Zaretskii <eliz@gnu.org>
2430
2431 * window.c (Fdelete_other_windows_internal)
2432 (Fdelete_window_internal): Don't access frame's mouse highlight
2433 info of the initial frame. (Bug#11677)
2434
2b570124
PE
24352012-06-14 Paul Eggert <eggert@cs.ucla.edu>
2436
e93864f9
PE
2437 * .gdbinit (xgetint): Fix recently-introduced paren typo.
2438 Assume USE_2_TAGS_FOR_INTS.
2439 (xreload): Adjust $tagmask width to match recent lisp.h change.
2440
2b570124
PE
2441 Simplify lisp.h in minor ways that should not affect code.
2442 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
2443 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
2444 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
2445 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
2446 (INTTYPEBITS): New macro, for clarity.
2447 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
2448 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
2449 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
2450 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
2451 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
2452
81755f69
JB
24532012-06-13 Juanma Barranquero <lekktu@gmail.com>
2454
2455 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
2456
16192a57
GM
24572012-06-13 Glenn Morris <rgm@gnu.org>
2458
2459 * s/bsd-common.h (BSD4_3):
2460 * s/usg5-4-common.h (USG5_4): No longer define; unused.
2461
646b5f55
AS
24622012-06-13 Andreas Schwab <schwab@linux-m68k.org>
2463
2464 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
2465 instead of union.
2466 (XLI, XIL): Define.
1053a871
SM
2467 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
2468 Use them.
2469 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 2470 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 2471 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
2472 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
2473 * frame.c (delete_frame): Remove outdated comment.
2474 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
2475 USE_LISP_UNION_TYPE.
2476 (Fw32_unregister_hot_key): Likewise.
2477 (Fw32_toggle_lock_key): Likewise.
2478 * w32menu.c (add_menu_item): Likewise.
2479 (w32_menu_display_help): Use XIL instead of checking
2480 USE_LISP_UNION_TYPE.
2481 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
2482 (init_heap): Likewise.
2483 * w32term.c (w32_read_socket): Update comment.
2484
1d3823c9
GM
24852012-06-13 Glenn Morris <rgm@gnu.org>
2486
c62ff706
GM
2487 * s/usg5-4-common.h, src/s/unixware.h:
2488 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
2489
1d3823c9
GM
2490 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
2491
bfe3e0a2
PE
24922012-06-13 Paul Eggert <eggert@cs.ucla.edu>
2493
2494 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
2495 * alloc.c (make_number) [!defined make_number]:
2496 Remove, as lisp.h always defines this now.
2497 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
2498 (roundup_size): Verify that it is a power of 2.
2499 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
2500 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
2501 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
2502 -DUSE_LSB_TAG=0, to override the automatically-selected default.
2503 USE_LSB_TAG now is always defined to be either 0 or 1.
2504 All uses changed.
2505 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
2506 code works fine either way, and efficiency is not a concern here,
2507 as the union type is for debugging, not for production.
2508 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
2509 Use an inline function on all platforms when using the union type,
2510 since this is simpler and 'static inline' can be used portably
2511 within Emacs now.
2512 (LISP_INITIALLY_ZERO): New macro.
2513 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
2514 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
2515
45fa9c0f
GM
25162012-06-12 Glenn Morris <rgm@gnu.org>
2517
b4492cba
GM
2518 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
2519
2520 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 2521
45fa9c0f
GM
2522 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
2523 Move BROKEN_SIGIO to configure.
2524
2525 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
2526 Move NO_TERMIO to configure.
2527
0e25d334
CY
25282012-06-12 Chong Yidong <cyd@gnu.org>
2529
2530 * image.c (imagemagick_load_image): Use MagickFlattenImage if
2531 MagickMergeImageLayers is undefined. Use pixel pusher loop if
2532 MagickExportImagePixels is undefined.
2533
43682bb6
PE
25342012-06-12 Paul Eggert <eggert@cs.ucla.edu>
2535
2536 * image.c (imagemagick_load_image): Remove unused label.
2537
a9be7d2b
GM
25382012-06-11 Glenn Morris <rgm@gnu.org>
2539
2540 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
2541 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
2542 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
2543 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
2544
3017f87f
SM
25452012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
2546
2547 * alloc.c (make_byte_code): New function.
2548 (Fmake_byte_code): Use it. Don't purify here.
2549 * lread.c (read1): Use it as well to avoid extra allocation.
2550
1b9b4cf4
CY
25512012-06-11 Chong Yidong <cyd@gnu.org>
2552
2553 * image.c (imagemagick_load_image): Implement transparency.
2554
95988fcf
AS
25552012-06-10 Andreas Schwab <schwab@linux-m68k.org>
2556
2557 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
2558 account for preceding backslashes. (Bug#11663)
2559
cd4eb164
CY
25602012-06-09 Chong Yidong <cyd@gnu.org>
2561
2562 * term.c: Support italics in capable terminals (Bug#9652).
2563 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
2564 (turn_on_face): Output using TS_enter_italic_mode if available.
2565 Don't handle unused blinking and alt-charset cases.
2566 (turn_off_face): Handle italic case; discard unused tty_blinking_p
2567 and tty_alt_charset_p cases.
2568 (tty_capable_p, init_tty): Support italics.
2569
2570 * termchar.h (struct tty_display_info): Add field for italics.
2571 Remove unused blink field.
2572
2573 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
2574 Handle slant.
2575
2576 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
2577 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
2578 tty_alt_charset_p. Add tty_italic_p.
2579
ff88beb8
MA
25802012-06-09 Michael Albinus <michael.albinus@gmx.de>
2581
2582 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
2583 dbus_type_is_basic if available.
2584 (xd_extract_signed, xd_extract_unsigned): Rename from
2585 extract_signed and extract_unsigned, respectively. Adapt callers.
2586
44286096
CY
25872012-06-09 Chong Yidong <cyd@gnu.org>
2588
1682701f
CY
2589 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
2590
44286096
CY
2591 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
2592 case (Bug#9752).
2593
d86feb17
PE
25942012-06-08 Paul Eggert <eggert@cs.ucla.edu>
2595
2596 * xdisp.c (vmessage): Treat frame message as multibyte.
2597 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
2598 would generate the diagnostic "Making \302\247 buffer-local while
2599 let-bound!".
2600
d5c20fe8
EZ
26012012-06-08 Eli Zaretskii <eliz@gnu.org>
2602
2603 * dispnew.c (showing_window_margins_p): Undo last change, which
2604 was done due to an inadvertent commit.
2605 (adjust_frame_glyphs_for_frame_redisplay): Do call
2606 showing_window_margins_p.
2607
513749ee
SM
26082012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2609
2610 * eval.c (Fmake_var_non_special): New primitive.
2611 (syms_of_eval): Defsubr it.
2612 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
2613
d4a8f5c1
JB
26142012-06-08 Juanma Barranquero <lekktu@gmail.com>
2615
2616 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
2617 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
2618
8bbbc977
EZ
26192012-06-08 Eli Zaretskii <eliz@gnu.org>
2620
2621 * alloc.c (allocate_vectorlike): Fix last change.
2622
f3372c87
DA
26232012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
2624
2625 Block-based vector allocation of small vectors.
2626 * lisp.h (struct vectorlike_header): New field `nbytes',
2627 adjust comment accordingly.
2628 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
2629 to denote vector blocks. Adjust users (live_vector_p,
2630 mark_maybe_pointer, valid_lisp_object_p) accordingly.
2631 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
2632 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
2633 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
2634 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
2635 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
2636 (roundup_size): New constant.
2637 (struct vector_block): New data type.
2638 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 2639 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
2640 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
2641 (sweep_vectors): New functions.
2642 (allocate_vectorlike): Return `zero_vector' as the only vector of
2643 0 items. Allocate new vector from block if vector size is less than
2644 or equal to VBLOCK_BYTES_MAX.
2645 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
2646 (init_alloc_once): Add call to init_vectors.
2647
4f18a4ed
SM
26482012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2649
2650 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
2651
86f158bc
PE
26522012-06-07 Paul Eggert <eggert@cs.ucla.edu>
2653
2654 * doprnt.c (doprnt): Truncate multibyte char correctly.
2655 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
2656 would mishandle a string argument "Xc" if X was a multibyte
2657 character of length 2: it would truncate after X's first byte
2658 rather than including all of X.
2659
c5cfcbe0
CY
26602012-06-06 Chong Yidong <cyd@gnu.org>
2661
2662 * buffer.c (word_wrap): Doc fix.
2663
c05cf390
PE
26642012-06-04 Paul Eggert <eggert@cs.ucla.edu>
2665
2666 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
2667
0c3461de
GM
26682012-06-03 Glenn Morris <rgm@gnu.org>
2669
2670 * xdisp.c (tool-bar-style): Doc fix.
2671
c71232db
UM
26722012-06-03 Ulrich Müller <ulm@gentoo.org>
2673
2674 * Makefile.in (PAXCTL): Define.
2675 (temacs$(EXEEXT)): Disable memory randomization for the temacs
2676 binary via PaX flags if the paxctl utility is available.
2677 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
2678 Restore PaX flags to their default. (Bug#11398)
2679
383f7350
CY
26802012-06-03 Chong Yidong <cyd@gnu.org>
2681
2682 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
2683 buffer (Bug#11226).
2684
5f2c76c6
CY
26852012-06-03 Chong Yidong <cyd@gnu.org>
2686
2687 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
2688 (note_mode_line_or_margin_highlight): If there is no help echo,
2689 use mode-line-default-help-echo. Handle the case where the mouse
2690 position is past the end of the mode line string.
2691
2692 * buffer.c (buffer_local_value_1): New function, split from
2693 Fbuffer_local_value; can return Qunbound.
2694 (Fbuffer_local_value): Use it.
2695 (Vmode_line_format): Docstring tweaks.
2696
773d47f6
PE
26972012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2698
2699 * sysdep.c (system_process_attributes): Improve comment.
2700
f2d6a3df
SM
27012012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
2702
2703 * keyboard.c: Export real-this-command to Elisp.
2704 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
2705 and DEFVAR it. Update all users.
2706
63810350
PE
27072012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2708
7bd5c1f4
PE
2709 * minibuf.c (Fassoc_string): Remove duplicate declaration.
2710
63810350
PE
2711 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
2712 Convert pctcpu and pctmem to Lisp float properly.
2713 Let the compiler fold better, as 100.0/0x8000 is exact.
2714
a2821611
AS
27152012-06-02 Andreas Schwab <schwab@linux-m68k.org>
2716
2717 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
2718 cons_block.
2719
5fceba1d
PE
27202012-06-01 Paul Eggert <eggert@cs.ucla.edu>
2721
2722 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
2723
c98ff5dd
DA
27242012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
2725
2726 For a 'struct window', replace some Lisp_Object fields to
2727 bitfields where appropriate, remove unused fields.
2728 * window.h (struct window): Remove unused 'last_mark_x' and
2729 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
2730 change it's type from Lisp_Object to bitfield.
2731 Change type of 'force_start', 'optional_new_start',
2732 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
2733 fields from Lisp_Object to bitfield. Adjust users accordingly.
2734
ca34e0be
PE
27352012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2736
2737 Pacify gcc -Wdouble-precision when using Xaw.
2738 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
2739 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
2740 Use 'float' consistently, rather than 'float' in most places
2741 and 'double' in a couple of places.
2742
efc00ab1 27432012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
2744
2745 * xdisp.c (handle_stop): Detect whether we have overlay strings
2746 loaded by testing it->current.overlay_string_index to be
2747 non-negative, instead of checking whether n_overlay_strings is
2748 positive. (Bug#11587)
2749
efc00ab1 27502012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
2751
2752 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
2753
2754 * doc.c (Fsubstitute_command_keys): Doc fix.
2755
efc00ab1 27562012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
2757
2758 * search.c (search_buffer): Remove calls to
2759 r_alloc_inhibit_buffer_relocation, as it is now called by
2760 maybe_unify_char, which was the cause of relocation of buffer text
2761 in bug#11519.
2762
efc00ab1 27632012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
2764
2765 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
2766 for the duration of call to load_charset, to avoid problems with
2767 callers of maybe_unify_char that access buffer text through C
2768 pointers.
2769
2770 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
2771 decrement the inhibition flag, instead of just setting or
2772 resetting it.
2773
ba93a187
PE
27742012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2775
2776 Remove obsolete '#define static' cruft.
2777 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
2778 This #undef was "temporary" in 2000; it is no longer needed
2779 now that '#define static' has gone away.
2780 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
2781 (gray_bitmap_bits): Remove; no longer needed.
2782 All uses replaced with definiens.
2783 * xterm.c: Include "bitmaps/gray.xbm".
2784
9e4bf381
PE
27852012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2786
2787 Clean up __executable_start, monstartup when --enable-profiling.
2788 The following changes affect the code only when profiling.
2789 * dispnew.c (__executable_start): Rename from safe_bcopy.
2790 Define only on platforms that need it.
2791 * emacs.c: Include <sys/gmon.h> when profiling.
2792 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
2793 (__executable_start): Remove decl, since lisp.h does it now.
2794 (safe_bcopy): Remove decl; no longer has that name.
2795 (main): Coalesce #if into single bit of code, for simplicity.
2796 Cast pointers to uintptr_t, since standard libraries want integers
2797 and not pointers.
2798 * lisp.h (__executable_start): New decl.
2799
32d72c2f
GM
28002012-05-31 Glenn Morris <rgm@gnu.org>
2801
2802 * image.c (Fimagemagick_types): Doc fix.
2803
baac5bc7
JM
28042012-05-30 Jim Meyering <meyering@redhat.com>
2805
2806 * callproc.c (Fcall_process_region): Include directory component
2807 in mkstemp error message (Bug#11586).
2808
72cb32cf
PE
28092012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2810
2811 * alloc.c, lisp.h (make_pure_vector): Now static.
2812
61b108cc
SM
28132012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
2814
2815 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
2816 Move to byte-run.el.
2817 (Fautoload): Do the hash-doc more carefully.
2818 * data.c (Fdefalias): Purify definition, except for keymaps.
2819 (Qdefun): Move from eval.c.
2820 * lisp.h (Qdefun): Remove.
2821 * lread.c (read1): Tiny simplification.
2822
471fe23d
TN
28232012-05-29 Troels Nielsen <bn.troels@gmail.com>
2824
934f3f58 2825 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
2826 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
2827 Bug#9642, but explicitly check that the buffer the overlay would
2828 be moved to is live and rearrange lines to make sure that errors
2829 will not put the overlay in an inconsistent state.
2830 (Fdelete_overlay): Cosmetics.
2831
85d0efd1
EZ
28322012-05-28 Eli Zaretskii <eliz@gnu.org>
2833
2834 * w32term.c (my_bring_window_to_top): New function.
2835 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
2836 could be different from the original one.
2837 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
2838 (Bug#11513)
2839
2840 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
2841 by calling BringWindowToTop.
2842
2843 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
2844 (WM_EMACS_END): Increase by one.
2845
da92a98c
PE
28462012-05-28 Paul Eggert <eggert@cs.ucla.edu>
2847
2848 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
2849 This avoids undefined behavior that might cause the eassert
2850 to not catch an out-of-range value.
2851
74d1f848
JB
28522012-05-28 Juanma Barranquero <lekktu@gmail.com>
2853
2854 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
2855 Update dependencies.
2856
9e1a06fc
EZ
28572012-05-27 Eli Zaretskii <eliz@gnu.org>
2858
2859 * bidi.c (bidi_mirror_char): Fix last change.
2860
f3dd7312
AS
28612012-05-27 Andreas Schwab <schwab@linux-m68k.org>
2862
2863 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
2864 when referring to sectname field in printf format.
2865
81899c91
PE
28662012-05-27 Paul Eggert <eggert@cs.ucla.edu>
2867
57b81a9f
PE
2868 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
2869 Only r_alloc_inhibit_buffer_relocation needed to be added;
2870 the others were already declared.
2871
81899c91
PE
2872 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
2873 before checking whether it's out of range. Put the check inside
2874 eassert. See
2875 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
2876
33017faf 28772012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
2878
2879 * callproc.c (Fcall_process): Restore a line that was accidentally
2880 commented out in the 2011-02-13 change (bug#11547).
2881
33017faf 28822012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
2883
2884 * lisp.h [REL_ALLOC]: Add prototypes for external functions
2885 defined on ralloc.c.
2886
2887 * buffer.c [REL_ALLOC]: Remove prototypes of
2888 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
2889 they are now on lisp.h.
2890
2891 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
2892
2893 * search.c (search_buffer): Use it to inhibit relocation of buffer
2894 text while re_search_2 is doing its job, because re_search_2 is
2895 passed C pointers to buffer text. (Bug#11519)
2896
23415acf
EZ
2897 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
2898 Update value to 24.
2899
44e27368
EZ
2900 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
2901 state after an additional call to move_it_in_display_line_to, keep
2902 the values of it->max_ascent and it->max_descent found for the
2903 entire line.
2904 (pos_visible_p): Revert the comparison against bottom_y to what it
2905 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
2906 (Bug#11464)
2907
c1892f11
PE
29082012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2909
2910 Fix coding-related core dumps with gcc -ftrapv.
2911 The code was computing A - B, where A and B are pointers, and B is
2912 random garbage. This can lead to core dumps on platforms that
2913 have special pointer registers, and it also leads to core dumps on
2914 x86-64 when compiled with gcc -ftrapv. The fix is to compute
2915 A - B only when B is initialized properly.
2916 * coding.c (coding_set_source, coding_set_destination): Return void.
2917 (coding_change_source, coding_change_destinations): New functions,
2918 with the old behaviors of coding_set_source and coding_set_destination.
2919 All callers that need an offset changed to use these new functions.
2920
eb7afdad
GM
29212012-05-26 Glenn Morris <rgm@gnu.org>
2922
2923 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
2924
f12fdf02
EZ
29252012-05-26 Eli Zaretskii <eliz@gnu.org>
2926
53a63be6 2927 Extend mouse support on W32 text-mode console.
61b108cc
SM
2928 * xdisp.c (draw_row_with_mouse_face):
2929 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 2930
eb3f6f01 2931 * w32console.c: Include window.h.
61b108cc
SM
2932 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
2933 New functions.
eb3f6f01
EZ
2934 (initialize_w32_display): Initialize mouse-highlight data.
2935
53a63be6
EZ
2936 * w32inevt.c: Include termchar.h and window.h.
2937 (do_mouse_event): Support mouse-autoselect-window. When the mouse
2938 moves, call note_mouse_highlight. If help_echo changed, call
2939 gen_help_event to produce help-echo message in the echo area.
2940 Call clear_mouse_face if mouse_face_hidden is set in the mouse
2941 highlight info.
2942
4cfd81f6
PE
29432012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2944
2945 * lread.c (read1): Simplify slightly to avoid an overflow warning
2946 with GCC 4.7.0 on x86-64.
2947
4446092a
EZ
29482012-05-26 Eli Zaretskii <eliz@gnu.org>
2949
2950 * bidi.c (bidi_mirror_char): Revert last change: an int is
2951 definitely wide enough here.
2952
42b2a986 29532012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 2954
42b2a986 2955 Fix integer width and related bugs (Bug#9874).
eb106a49 2956 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
2957 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
2958 (string_bytes, check_sblock, allocate_string_data):
2959 (compact_small_strings, Fmake_bool_vector, make_string)
2960 (make_unibyte_string, make_multibyte_string)
2961 (make_string_from_bytes, make_specified_string)
2962 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
2963 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
2964 (mark_vectorlike):
2965 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2966 (allocate_pseudovector):
2967 Use int, not EMACS_INT, where int is wide enough.
2968 (inhibit_garbage_collection, Fgarbage_collect):
2969 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2970 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
2971 int might not be wide enough.
2972 (bidi_cache_search, bidi_cache_find, bidi_init_it)
2973 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
2974 (bidi_at_paragraph_end, bidi_find_paragraph_start)
2975 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2976 (bidi_level_of_next_char, bidi_move_to_visually_next):
2977 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2978 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
2979 (Fkill_buffer, Fset_buffer_major_mode)
2980 (advance_to_char_boundary, Fbuffer_swap_text)
2981 (Fset_buffer_multibyte, overlays_at, overlays_in)
2982 (overlay_touches_p, struct sortvec, record_overlay_string)
2983 (overlay_strings, recenter_overlay_lists)
2984 (adjust_overlays_for_insert, adjust_overlays_for_delete)
2985 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
2986 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
2987 (Foverlay_recenter, last_overlay_modification_hooks_used)
2988 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
2989 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
2990 (validate_region): Omit unnecessary test for b <= e,
2991 since that's guaranteed by the previous test.
d311d28c
PE
2992 (adjust_overlays_for_delete): Avoid pos + length overflow.
2993 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
2994 (report_overlay_modification):
2995 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2996 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
2997 Omit pointer cast, which isn't needed anyway, and doesn't work
2998 after the EMACS_INT -> ptrdiff_t change.
02481186 2999 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
3000 * buffer.h: Adjust decls to match defn changes elsewhere.
3001 (struct buffer_text, struct buffer):
3002 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3003 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
3004 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
3005 not int, to avoid needless 32-bit limit on 64-bit hosts.
3006 (exec_byte_code): Use tighter memory-full test, one that checks
3007 for alloca overflow. Don't compute the address of the object just
3008 before an array, as that's not portable. Use EMACS_INT, not
3009 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
3010 * callint.c (Fcall_interactively):
3011 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3012 * callproc.c (call_process_kill, Fcall_process):
3013 Don't assume pid_t fits into an Emacs fixnum.
3014 (call_process_cleanup, Fcall_process, child_setup):
3015 Don't assume pid_t fits into int.
3016 (call_process_cleanup, Fcall_process, delete_temp_file)
3017 (Fcall_process_region):
3018 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3019 (Fcall_process): Simplify handling of volatile integers.
3020 Use int, not EMACS_INT, where int will do.
3021 * casefiddle.c (casify_object, casify_region, operate_on_word)
3022 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
3023 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3024 (casify_object): Avoid integer overflow when overallocating buffer.
3025 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 3026 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
3027 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
3028 * category.h (CATEGORYP): Don't assume arg is nonnegative.
3029 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
3030 integers are now checked earlier. All uses replaced with XINT.
3031 (ccl_driver):
3032 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3033 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
3034 (ccl_driver, Fregister_code_conversion_map):
3035 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
3036 (resolve_symbol_ccl_program): Check that vector header is in range.
3037 Always copy the vector, so that we can check its contents reliably
3038 now rather than having to recheck each instruction as it's being
3039 executed. Check that vector words fit in 'int'.
3040 (ccl_get_compiled_code, Fregister_ccl_program)
3041 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
3042 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
3043 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
3044 contents are in range.
3045 (Fccl_execute_on_string): Check that status is in range.
3046 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
3047 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
3048 Accept and return EMACS_INT, not int, because callers can pass values
3049 out of 'int' range.
3050 (c_string_width, strwidth, lisp_string_width, chars_in_text)
3051 (multibyte_chars_in_text, parse_str_as_multibyte)
3052 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
3053 (str_as_unibyte, str_to_unibyte, string_count_byte8)
3054 (string_escape_byte8, Fget_byte):
3055 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 3056 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
3057 avoid mishandling large integers.
3058 * character.h: Adjust decls to match defn changes elsewhere.
3059 * charset.c (load_charset_map_from_file, find_charsets_in_text)
3060 (Ffind_charset_region):
3061 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3062 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
3063 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 3064 Don't assume fixnum fits in int.
d311d28c
PE
3065 (load_charset_map_from_vector, Fmap_charset_chars):
3066 Remove now-unnecessary CHECK_NATNUMs.
3067 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
3068 Don't rely on undefined behavior with signed left shift overflow.
3069 Don't assume unsigned int fits into fixnum, or that fixnum fits
3070 into unsigned int. Don't require max_code to be a valid fixnum;
3071 that's not true for gb10830 4-byte on a 32-bit host. Allow
3072 invalid_code to be a cons, for the same reason. Require code_offset
3073 to be a character. Avoid int overflow if max_char is close
3074 to INT_MAX.
3075 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
3076 this is intended anyway and avoids some undefined behavior.
3077 (load_charset_map): Pass unsigned, not int, as 2nd arg of
3078 INDEX_TO_CODE_POINT, as that's what it expects.
3079 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
3080 * charset.h (DECODE_CHAR): Return int, not unsigned;
3081 this is what was intended anyway, and it avoids undefined behavior.
3082 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
3083 integer-overflow issues.
3084 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
3085 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
3086 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
3087 * chartab.c (Fmake_char_table, Fset_char_table_range)
3088 (uniprop_get_decoder, uniprop_get_encoder):
3089 Don't assume fixnum fits in int.
3090 * cmds.c (move_point): New function, that does the gist of
3091 Fforward_char and Fbackward_char, but does so while checking
3092 for integer overflow more accurately.
c96e5d6a 3093 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
3094 (Fforward_line, Fend_of_line, internal_self_insert)
3095 (internal_self_insert):
3096 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3097 Fix a FIXME, by checking for integer overflow when calculating
3098 target_clm and actual_clm.
3099 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 3100 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
3101 (ASSURE_DESTINATION, coding_alloc_by_realloc)
3102 (coding_alloc_by_making_gap, alloc_destination)
3103 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
3104 (encode_coding_utf_16, detect_coding_emacs_mule)
3105 (decode_coding_emacs_mule, encode_coding_emacs_mule)
3106 (detect_coding_iso_2022, decode_coding_iso_2022)
3107 (encode_invocation_designation, encode_designation_at_bol)
3108 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3109 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
3110 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
3111 (encode_coding_ccl, encode_coding_raw_text)
3112 (detect_coding_charset, decode_coding_charset)
3113 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
3114 (produce_composition, produce_charset, produce_annotation)
3115 (decode_coding, handle_composition_annotation)
3116 (handle_charset_annotation, consume_chars, decode_coding_gap)
3117 (decode_coding_object, encode_coding_object, detect_coding_system)
3118 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
3119 (code_convert_region, code_convert_string)
8f50130c
PE
3120 (Fdefine_coding_system_internal)
3121 (coding_set_source, coding_set_destination):
d311d28c
PE
3122 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3123 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
3124 (Fdefine_coding_system_internal):
3125 Don't assume fixnums fit in int.
3126 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 3127 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
3128 (Funencodable_char_position, Fcheck_coding_systems_region)
3129 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 3130 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 3131 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 3132 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 3133 Don't access memory outside of the args array.
d311d28c 3134 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
3135 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
3136 result of ENCODE_CHAR.
d311d28c
PE
3137 * coding.h: Adjust decls to match defn changes elsewhere.
3138 (struct coding_system):
3139 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3140 * composite.c (get_composition_id, find_composition)
3141 (run_composition_function, update_compositions)
3142 (compose_text, composition_gstring_put_cache)
3143 (composition_gstring_p, composition_gstring_width)
3144 (fill_gstring_header, fill_gstring_body, autocmp_chars)
3145 (composition_compute_stop_pos, composition_reseat_it)
3146 (composition_update_it, struct position_record)
3147 (find_automatic_composition, composition_adjust_point)
3148 (Fcomposition_get_gstring, Ffind_composition_internal):
3149 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3150 (update_compositions):
3151 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3152 * composite.h: Adjust decls to match defn changes elsewhere.
3153 (struct composition):
3154 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3155 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
3156 Do not attempt to compute the address of the object just before a
3157 buffer; this is not portable.
3158 (Faref, Faset):
3159 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3160 (Faset): Use int, not EMACS_INT, where int is wide enough.
3161 (Fstring_to_number): Don't assume fixnums fit in int.
3162 (Frem): Don't assume arg is nonnegative.
3163 * dbusbind.c (xd_append_arg): Check for integers out of range.
3164 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 3165 (extract_signed, extract_unsigned): New functions.
243e0530
PE
3166 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
3167 (xd_get_connection_references): Return ptrdiff_t, not int.
3168 All uses changed.
3169 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
3170 (xd_read_message_1):
3171 Use int, not unsigned, where the dbus API uses int.
3172 (Fdbus_message_internal): Don't overflow mtype.
3173 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
3174 * dired.c (directory_files_internal, file_name_completion, scmp)
3175 (file_name_completion_stat):
3176 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3177 (file_name_completion): Don't overflow matchcount.
3178 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
3179 * dispextern.h: Adjust decls to match defn changes elsewhere.
3180 (struct text_pos, struct glyph, struct bidi_saved_info)
3181 (struct bidi_string_data, struct bidi_it, struct composition_it)
3182 (struct it):
3183 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3184 (struct display_pos, struct composition_it, struct it):
3185 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3186 * dispnew.c (increment_matrix_positions)
3187 (increment_row_positions, mode_line_string)
3188 (marginal_area_string):
3189 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 3190 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
3191 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3192 (duration_to_sec_usec): New function, to check for overflow better.
3193 (Fsleep_for, sit_for): Use it.
3194 * doc.c (get_doc_string, store_function_docstring):
3195 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3196 (get_doc_string, Fsnarf_documentation):
3197 Use int, not EMACS_INT, where int is wide enough.
3198 (get_doc_string):
3199 Use SAFE_ALLOCA, not alloca.
3200 Check for overflow when converting EMACS_INT to off_t.
3201 * doprnt.c (doprnt):
3202 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3203 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
3204 Don't assume uid_t fits into fixnum.
3205 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
3206 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
3207 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
3208 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
3209 (general_insert_function)
3210 (Finsert_char, make_buffer_string, make_buffer_string_both)
3211 (update_buffer_properties, Fbuffer_substring)
3212 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
3213 (Fsubst_char_in_region, check_translation)
3214 (Ftranslate_region_internal, save_restriction_restore, Fformat)
3215 (transpose_markers, Ftranspose_regions):
3216 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3217 (clip_to_bounds): Move to lisp.h as an inline function).
3218 (Fconstrain_to_field): Don't assume integers are nonnegative.
3219 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
3220 (Fsubst_char_in_region, Fsave_restriction):
3221 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3222 (Femacs_pid): Don't assume pid_t fits into fixnum.
3223 (lo_time): Use int, not EMACS_INT, when int suffices.
3224 (lisp_time_argument): Check for usec out of range.
3225 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
3226 (Fuser_login_name, Fuser_full_name): Signal an error
3227 if a uid argument is out of range, rather than relying on
3228 undefined behavior.
c8d5c857
PE
3229 (Fformat_time_string): Remove now-unnecessary check.
3230 lisp_time_argument checks for out-of-range usec now.
243e0530 3231 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
3232 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
3233 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
3234 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
3235 (init_cmdargs, Fdump_emacs):
3236 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3237 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
3238 the bottom (typically) 32 bits of the fixnum.
3239 * eval.c (specpdl_size, call_debugger):
3240 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3241 (when_entered_debugger, Fbacktrace_debug):
3242 Don't assume fixnum can fit in int.
3243 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
3244 the object just before a buffer; this is not portable.
3245 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
3246 (grow_specpdl, unbind_to):
3247 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3248 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
3249 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 3250 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
3251 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
3252 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
3253 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3254 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
3255 (a_write, e_write):
3256 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3257 (Fcopy_file, non_regular_nbytes, read_non_regular)
3258 (Finsert_file_contents):
3259 Use int, not EMACS_INT, where int is wide enough.
3260 (READ_BUF_SIZE): Verify that it fits in int.
3261 (Finsert_file_contents): Check that counts are in proper range,
3262 rather than assuming fixnums fit into ptrdiff_t etc.
3263 Don't assume fixnums fit into int.
125b3835 3264 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
3265 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
3266 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
3267 (string_char_to_byte, string_byte_to_char)
3268 (string_make_multibyte, string_to_multibyte)
3269 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
3270 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
3271 (substring_both, Fdelete, internal_equal, Ffillarray)
3272 (Fclear_string, mapcar1)
3273 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
3274 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
3275 (larger_vector, make_hash_table, maybe_resize_hash_table)
3276 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
3277 (Fmaphash, secure_hash):
3278 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3279 (concat): Check for string index and length overflow.
3280 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
3281 (Frequire):
3282 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3283 (larger_vector): New API (vec, incr_min, size_max) replaces old
3284 one (vec, new_size, init). This catches size overflow.
3285 INIT was removed because it was always Qnil.
3286 All callers changed.
3287 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
3288 the upper bound on a hash table index size.
3289 (make_hash_table, maybe_resize_hash_table): Use it.
3290 (secure_hash): Computer start_byte and end_byte only after
3291 they're known to be in ptrdiff_t range.
3292 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
3293 (Ffont_get_glyphs, Ffont_at):
3294 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3295 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
3296 (Flist_fonts, Fopen_font):
3297 Don't assume fixnum can fit in int.
3298 (check_gstring): Don't assume index can fit in int.
3299 (font_match_p): Check that fixnum is a character, not a nonnegative
3300 fixnum, since the later code needs to stuff it into an int.
3301 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
3302 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
3303 conversion overflow issues.
3304 (Fopen_font): Check for integer out of range.
3305 (Ffont_get_glyphs): Don't assume index can fit in int.
3306 * font.h: Adjust decls to match defn changes elsewhere.
3307 * fontset.c (reorder_font_vector): Redo score calculation to avoid
3308 integer overflow.
3309 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
3310 printmax_t, where ptrdiff_t is wide enough.
3311 (Finternal_char_font):
3312 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3313 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
3314 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
3315 (Fset_frame_position, x_set_frame_parameters)
3316 (x_set_line_spacing, x_set_border_width)
3317 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
3318 Check that fixnums are in proper range for system types.
3319 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
3320 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3321 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
3322 Use SAFE_ALLOCA_LISP, not alloca.
3323 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
3324 intptr_t is wide enough.
3325 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
3326 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
3327 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
3328 Check for fixnum out of range.
3329 * ftfont.c (ftfont_list): Don't assume index fits in int.
3330 Check that fixnums are in proper range for system types.
3331 (ftfont_shape_by_flt):
3332 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
3333 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3334 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3335 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
3336 Check that fixnums are in proper range for system types.
3337 * gnutls.h: Adjust decls to match defn changes elsewhere.
3338 * gtkutil.c (xg_dialog_run):
3339 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3340 (update_frame_tool_bar):
3341 Check that fixnums are in proper range for system types.
3342 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 3343 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
3344 * indent.c (last_known_column, last_known_column_point):
3345 (current_column_bol_cache):
3346 (skip_invisible, current_column, check_display_width):
3347 (check_display_width, scan_for_column, current_column_1)
3348 (Findent_to, Fcurrent_indentation, position_indentation)
3349 (indented_beyond_p, Fmove_to_column, compute_motion):
3350 (Fcompute_motion, Fvertical_motion):
3351 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3352 (last_known_column_modified): Use EMACS_INT, not int.
3353 (check_display_width):
3354 (Fcompute_motion):
3355 Check that fixnums and floats are in proper range for system types.
3356 (compute_motion): Don't assume index or fixnum fits in int.
3357 (compute_motion, Fcompute_motion):
3358 Use int, not EMACS_INT, when it is wide enough.
3359 (vmotion): Omit local var start_hpos that is always 0; that way
3360 we don't need to worry about overflow in expressions involving it.
3361 * indent.h: Adjust decls to match defn changes elsewhere.
3362 (struct position):
3363 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3364 Use int, not EMACS_INT, where int is wide enough.
3365 Remove unused members ovstring_chars_done and tab_offset;
3366 all uses removed.
3367 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
3368 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
3369 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
3370 (make_gap, copy_text, insert, insert_and_inherit)
3371 (insert_before_markers, insert_before_markers_and_inherit)
3372 (insert_1, count_combining_before, count_combining_after)
3373 (insert_1_both, insert_from_string)
3374 (insert_from_string_before_markers, insert_from_string_1)
3375 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
3376 (adjust_after_replace, adjust_after_insert, replace_range)
3377 (replace_range_2, del_range, del_range_1, del_range_byte)
3378 (del_range_both, del_range_2, modify_region)
3379 (prepare_to_modify_buffer, signal_before_change)
3380 (signal_after_change, Fcombine_after_change_execute):
3381 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3382 * intervals.c (traverse_intervals, rotate_right, rotate_left)
3383 (balance_an_interval, split_interval_right, split_interval_left)
3384 (find_interval, next_interval, update_interval)
3385 (adjust_intervals_for_insertion, delete_node, delete_interval)
3386 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3387 (static_offset_intervals, offset_intervals)
3388 (merge_interval_right, merge_interval_left, make_new_interval)
3389 (graft_intervals_into_buffer, temp_set_point_both)
3390 (temp_set_point, set_point, adjust_for_invis_intang)
3391 (set_point_both, move_if_not_intangible, get_property_and_range)
3392 (get_local_map, copy_intervals, copy_intervals_to_string)
3393 (compare_string_intervals, set_intervals_multibyte_1):
3394 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3395 * intervals.h: Adjust decls to match defn changes elsewhere.
3396 (struct interval):
3397 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3398 * keyboard.c (this_command_key_count, this_single_command_key_start)
3399 (before_command_key_count, before_command_echo_length, echo_now)
3400 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
3401 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
3402 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
3403 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
3404 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3405 (last_non_minibuf_size, last_point_position, echo_truncate)
3406 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
3407 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
3408 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
3409 (stuff_buffered_input):
3410 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3411 (last_auto_save, command_loop_1, read_char):
3412 Use EMACS_INT, not int, to avoid integer overflow.
3413 (record_char): Avoid overflow in total_keys computation.
3414 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
3415 * keyboard.h: Adjust decls to match defn changes elsewhere.
3416 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
3417 (Fkey_description, Fdescribe_vector, Flookup_key):
3418 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3419 (click_position): New function, to check that positions are in range.
3420 (Fcurrent_active_maps):
3421 (describe_command):
3422 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3423 (Faccessible_keymaps, Fkey_description):
3424 (preferred_sequence_p):
3425 Don't assume fixnum can fit into int.
3426 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
3427 Check for integer overflow in size calculations.
3428 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
3429 avoid mishandling large integers.
3430 * lisp.h: Adjust decls to match defn changes elsewhere.
3431 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
3432 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
3433 (struct Lisp_Marker):
3434 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3435 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
3436 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
3437 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
3438 All callers changed.
3439 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
3440 Assume the arg has valid form, since it always does.
3441 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
3442 unsigned integer system type.
3443 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
3444 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
3445 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3446 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
3447 (duration_to_sec_usec): New decl.
3448 * lread.c (read_from_string_index, read_from_string_index_byte)
3449 (read_from_string_limit, readchar, unreadchar, openp)
3450 (read_internal_start, read1, oblookup):
3451 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3452 (Fload, readevalloop, Feval_buffer, Feval_region):
3453 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3454 (openp): Check for out-of-range argument to 'access'.
3455 (read1): Use int, not EMACS_INT, where int is wide enough.
3456 Don't assume fixnum fits into int.
6efdadfd 3457 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
3458 (read_filtered_event): Use duration_to_sec_usec
3459 to do proper overflow checking on durations.
d311d28c
PE
3460 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
3461 in size calculation.
3462 (Fexecute_kbd_macro):
3463 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3464 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
3465 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
3466 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
3467 (set_marker_both, set_marker_restricted_both, marker_position)
3468 (marker_byte_position, Fbuffer_has_markers_at):
3469 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3470 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 3471 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
3472 It now merely ensures that the menu is large enough, without
3473 necessarily growing it, as this avoids some integer overflow issues.
3474 All callers changed.
3475 (keymap_panes, parse_single_submenu, Fx_popup_menu):
3476 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3477 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
3478 Use SAFE_ALLOCA_LISP, not alloca.
3479 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
3480 to EMACS_INT. Check that fixnums are in proper range for system types.
3481 * minibuf.c (minibuf_prompt_width, string_to_object)
3482 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
3483 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
3484 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3485 (get_minibuffer, read_minibuf_unwind):
3486 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3487 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
3488 this simplifies overflow checking. All callers changed.
3489 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
3490 (Ftest_completion):
3491 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3492 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
3493 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
3494 Check that fixnums are in proper range for system types.
3495 (Fx_create_frame, Fx_show_tip):
3496 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3497 * nsfont.m (ns_findfonts, nsfont_list_family):
3498 Don't assume fixnum fits in long.
3499 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
3500 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3501 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
3502 wide enough.
17fdb222 3503 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
3504 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3505 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
3506 (PRINTDECLARE, PRINTPREPARE):
3507 (strout, print_string):
3508 (print, print_preprocess, print_check_string_charset_prop)
3509 (print_object):
3510 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3511 (PRINTDECLARE):
3512 (temp_output_buffer_setup, Fprin1_to_string, print_object):
3513 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3514 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 3515 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 3516 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
3517 (print_error_message): Use SAFE_ALLOCA, not alloca.
3518 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
3519 (print_depth, new_backquote_output, print_number_index):
3520 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
3521 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
3522 (Fset_process_window_size, Fformat_network_address)
3523 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 3524 (sigchld_handler):
d311d28c 3525 Check that fixnums are in proper range for system types.
d44287d4 3526 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
3527 Check for process-ids out of pid_t range rather than relying on
3528 undefined behavior.
e4d81efc 3529 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
3530 (Fformat_network_address, read_process_output, send_process)
3531 (Fprocess_send_region, status_notify):
3532 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3533 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
3534 (wait_reading_process_output, read_process_output, exec_sentinel):
3535 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3536 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
3537 (Faccept_process_output): Use duration_to_sec_usec to do proper
3538 overflow checking on durations.
dde14581
PE
3539 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
3540 Don't assume pid_t fits in int.
02481186
PE
3541 * process.h (struct Lisp_Process): Members tick and update_tick
3542 are now of type EMACS_INT, not int.
b62b53e8
PE
3543 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
3544 configured --with-wide-int.
d311d28c
PE
3545 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
3546 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
3547 * search.c (looking_at_1, string_match_1):
3548 (fast_string_match, fast_c_string_match_ignore_case)
3549 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
3550 (scan_newline, find_before_next_newline, search_command)
3551 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
3552 (set_search_regs, wordify):
3553 (Freplace_match):
3554 (Fmatch_data):
3555 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3556 (string_match_1, search_buffer, set_search_regs):
3557 (Fmatch_data):
3558 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3559 (wordify): Check for overflow in size calculation.
3560 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
3561 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
3562 Check that fixnums are in proper range for system types.
3563 * sound.c (struct sound_device)
3564 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
3565 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3566 (Fplay_sound_internal):
3567 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 3568 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
3569 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
3570 (Fparse_partial_sexp):
3571 Don't assume fixnums can fit in int.
3572 (struct lisp_parse_state, find_start_pos, find_start_value)
3573 (find_start_value_byte, find_start_begv)
3574 (update_syntax_table, char_quoted, dec_bytepos)
3575 (find_defun_start, prev_char_comend_first, back_comment):
3576 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
3577 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
3578 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3579 (Finternal_describe_syntax_value): Check that match_lisp is a
3580 character, not an integer, since the code stuffs it into int.
3581 (scan_words, scan_sexps_forward):
3582 Check that fixnums are in proper range for system types.
3583 (Fforward_word):
3584 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3585 (scan_sexps_forward):
3586 Use CHARACTERP, not INTEGERP, since the value must fit into int.
3587 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
3588 * syntax.h: Adjust decls to match defn changes elsewhere.
3589 (struct gl_state_s):
3590 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
3591 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
3592 MOST_POSITIVE_FIXNUM.
d311d28c
PE
3593 * sysdep.c (wait_for_termination_1, wait_for_termination)
3594 (interruptible_wait_for_termination, mkdir):
3595 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
3596 (emacs_read, emacs_write):
3597 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
3598 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
3599 and double all fit in int.
d311d28c
PE
3600 * term.c (set_tty_color_mode):
3601 Check that fixnums are in proper range for system types.
3602 * termhooks.h (struct input_event):
3603 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3604 * textprop.c (validate_interval_range, interval_of)
3605 (Fadd_text_properties, set_text_properties_1)
3606 (Fremove_text_properties, Fremove_list_of_text_properties)
3607 (Ftext_property_any, Ftext_property_not_all)
3608 (copy_text_properties, text_property_list, extend_property_ranges)
3609 (verify_interval_modification):
3610 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3611 (Fnext_single_char_property_change)
3612 (Fprevious_single_char_property_change):
3613 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
3614 (copy_text_properties):
3615 Check for integer overflow in index calculation.
d311d28c
PE
3616 * undo.c (last_boundary_position, record_point, record_insert)
3617 (record_delete, record_marker_adjustment, record_change)
3618 (record_property_change):
3619 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3620 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
3621 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3622 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3623 (Fx_hide_tip, Fx_file_dialog):
3624 * w32menu.c (set_frame_menubar):
3625 Use ptrdiff_t, not int, for consistency with rest of code.
3626 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
3627 (select_window, Fdelete_other_windows_internal)
3628 (window_scroll_pixel_based, window_scroll_line_based)
3629 (Frecenter, Fset_window_configuration):
3630 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3631 (Fset_window_hscroll, run_window_configuration_change_hook)
3632 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 3633 (Fscroll_other_window, Frecenter):
d311d28c
PE
3634 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3635 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
3636 Don't assume fixnum fits in int.
3637 (Fset_window_scroll_bars):
3638 Check that fixnums are in proper range for system types.
3639 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
3640 (string_pos, c_string_pos, number_of_chars, init_iterator)
3641 (in_ellipses_for_invisible_text_p, init_from_display_pos)
3642 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
3643 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
3644 (face_before_or_after_it_pos, handle_invisible_prop)
3645 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
3646 (display_prop_intangible_p, string_buffer_position_lim)
3647 (string_buffer_position, handle_composition_prop, load_overlay_strings)
3648 (get_overlay_strings_1, get_overlay_strings)
3649 (iterate_out_of_display_property, forward_to_next_line_start)
3650 (back_to_previous_visible_line_start, reseat, reseat_to_string)
3651 (get_next_display_element, set_iterator_to_next)
3652 (get_visually_first_element, compute_stop_pos_backwards)
3653 (handle_stop_backwards, next_element_from_buffer)
3654 (move_it_in_display_line_to, move_it_in_display_line)
3655 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3656 (add_to_log, message_dolog, message_log_check_duplicate)
3657 (message2, message2_nolog, message3, message3_nolog
3658 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
3659 (current_message_1, truncate_echo_area, truncate_message_1)
3660 (set_message, set_message_1, store_mode_line_noprop)
3661 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
3662 (text_outside_line_unchanged_p, check_point_in_composition)
3663 (reconsider_clip_changes)
3664 (redisplay_internal, set_cursor_from_row, try_scrolling)
3665 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
3666 (redisplay_window, find_last_unchanged_at_beg_row)
3667 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
3668 (trailing_whitespace_p, find_row_edges, display_line)
3669 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
3670 (display_mode_element, store_mode_line_string)
3671 (pint2str, pint2hrstr, decode_mode_spec)
3672 (display_count_lines, display_string, draw_glyphs)
3673 (x_produce_glyphs, x_insert_glyphs)
3674 (rows_from_pos_range, mouse_face_from_buffer_pos)
3675 (fast_find_string_pos, mouse_face_from_string_pos)
3676 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3677 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3678 (safe_call, init_from_display_pos, handle_fontified_prop)
3679 (handle_single_display_spec, load_overlay_strings)
3680 (with_echo_area_buffer, setup_echo_area_for_printing)
3681 (display_echo_area, echo_area_display)
3682 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
3683 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
3684 (redisplay_window, dump_glyph_row, display_mode_line)
3685 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 3686 (handle_display_spec, display_prop_string_p):
d311d28c
PE
3687 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3688 (handle_single_display_spec, build_desired_tool_bar_string)
3689 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
3690 (get_specified_cursor_type):
3691 Check that fixnums are in proper range for system types.
3692 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
3693 (Flookup_image_map):
3694 Don't assume fixnums fit in int.
3695 (compare_overlay_entries):
3696 Avoid mishandling comparisons due to subtraction overflow.
3697 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
3698 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
3699 (handle_tool_bar_click):
3700 Use int, not unsigned, since we prefer signed and the signedness
3701 doesn't matter here.
3702 (get_next_display_element, next_element_from_display_vector):
3703 Use int, not EMACS_INT, when int is wide enough.
3704 (start_hourglass): Use duration_to_sec_usec to do proper
3705 overflow checking on durations.
3706 * xfaces.c (Fbitmap_spec_p):
3707 Check that fixnums are in proper range for system types.
3708 (compare_fonts_by_sort_order):
3709 Avoid mishandling comparisons due to subtraction overflow.
3710 (Fx_family_fonts, realize_basic_faces):
3711 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3712 (Fx_family_fonts):
3713 Don't assume fixnum fits in int.
3714 Use SAFE_ALLOCA_LISP, not alloca.
3715 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
3716 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
3717 (face_at_buffer_position, face_for_overlay_string)
3718 (face_at_string_position):
3719 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3720 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
3721 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
3722 (Fx_show_tip):
3723 Check that fixnums are in proper range for system types.
3724 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3725 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
3726 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3727 (Fx_change_window_property): Don't assume fixnums fit in int.
3728 * xfont.c (xfont_chars_supported):
3729 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3730 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
3731 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
3732 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3733 * xml.c (parse_region):
3734 * xrdb.c (magic_file_p):
3735 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3736 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
3737 (x_get_local_selection, x_reply_selection_request)
3738 (x_handle_selection_request, wait_for_property_change):
3739 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3740 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
3741 short is wide enough.
3742 (x_send_client_event): Don't assume fixnum fits in int.
3743 * xterm.c (x_x_to_emacs_modifiers):
3744 Don't assume EMACS_INT overflows nicely into int.
3745 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
3746 may come from Lisp.
3747 (handle_one_xevent): NATNUMP can eval its arg twice.
3748 (x_connection_closed):
3749 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3750 * xterm.h: Adjust decls to match defn changes elsewhere.
3751 (struct scroll_bar): Use struct vectorlike_header
3752 rather than rolling our own approximation.
3753 (SCROLL_BAR_VEC_SIZE): Remove; not used.
3754
c6574eb5
GM
37552012-05-25 Glenn Morris <rgm@gnu.org>
3756
3757 * lisp.mk (lisp): Update for more files being compiled now.
3758
e8d32c7e
SM
37592012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
3760
48def666
SM
3761 * lread.c: Remove `read_pure' which makes no difference.
3762 (read_pure): Remove var.
3763 (unreadpure): Remove function.
3764 (readevalloop): Don't call read_list with -1 flag.
3765 (read1, read_vector): Don't test read_pure any more.
3766 (read_list): Simplify.
3767
e8d32c7e
SM
3768 * fileio.c, character.h: Minor style tweaks.
3769
4b2addb7
DA
37702012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
3771
3772 * window.h (clip_changed): Remove useless declaration.
3773
584461b2
JB
37742012-05-22 Juanma Barranquero <lekktu@gmail.com>
3775
3776 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
3777 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
3778
34374650
PE
37792012-05-22 Paul Eggert <eggert@cs.ucla.edu>
3780
3781 Remove src/m/*.
3782 This directory predates autoconf and is no longer needed nowadays.
3783 Move its few remaining bits of functionality to where they're needed.
3784 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
3785 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
3786 * m/template.h: Remove.
3787 * Makefile.in (M_FILE): Remove. All uses removed.
3788 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
3789 * lisp.h (USE_LSB_TAG):
3790 * mem-limits.h (EXCEEDS_LISP_PTR):
3791 Use VAL_MAX, not VALBITS, in #if.
3792 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
3793 (EMACS_UINT): Define unconditionally now.
3794 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
3795 (BITS_PER_EMACS_INT): New constants, replacing
3796 what used to be in config.h, but not useful in #if.
3797 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
3798 define them any more.
3799 (VAL_MAX): New macro.
3800 (VALMASK): Use it.
3801 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
3802 BITS_PER_EMACS_INT, in #if.
3803 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
3804 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
3805 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
3806 * s/ms-w32.h (DATA_START):
3807 Move here from removed file m/intel386.h.
3808 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
3809 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
3810
261cb4bb
PE
38112012-05-21 Paul Eggert <eggert@cs.ucla.edu>
3812
3813 Assume C89 or later.
3814 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
3815 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
3816 (xrealloc):
3817 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
3818 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
3819 * textprop.c, tparam.c (NULL): Remove.
3820 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
3821 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
3822 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
3823 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
3824 * xterm.c (input_signal_count): Assume volatile works.
3825
ff23cd9f
KB
38262012-05-21 Ken Brown <kbrown@cornell.edu>
3827
3828 * xgselect.c (xg_select): Fix first argument in call to 'select'
3829 (bug#11508).
3830
1b170bc6
KB
38312012-05-20 Ken Brown <kbrown@cornell.edu>
3832
3833 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 3834 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 3835
b2f4d39f
KB
38362012-05-19 Ken Brown <kbrown@cornell.edu>
3837
3838 * xfns.c (x_in_use): Remove `static' qualifier.
3839 * xterm.h (x_in_use): Declare.
3840 * xgselect.c: Include xterm.h.
3841 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
3842 and `display_arg' (bug#9754).
3843
003fdae2
PE
38442012-05-19 Paul Eggert <eggert@cs.ucla.edu>
3845
9232a6d9
PE
3846 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
3847
003fdae2
PE
3848 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
3849 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
3850
784b56e2
EZ
38512012-05-18 Eli Zaretskii <eliz@gnu.org>
3852
3853 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
3854
3855 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 3856 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
3857
3858 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
3859 reference to image_cache->refcount.
3860 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
3861
a0a79cde
JL
38622012-05-17 Juri Linkov <juri@jurta.org>
3863
3864 * search.c (Fword_search_regexp, Fword_search_backward)
3865 (Fword_search_forward, Fword_search_backward_lax)
3866 (Fword_search_forward_lax): Move functions to isearch.el
3867 (bug#10145, bug#11381).
3868
b0572523
PE
38692012-05-16 Paul Eggert <eggert@cs.ucla.edu>
3870
3871 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
3872
9660f5fc
SM
38732012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3874
3875 * lread.c (init_obarray): Declare Qt and Qnil as special.
3876
4374de83
GM
38772012-05-14 Glenn Morris <rgm@gnu.org>
3878
3879 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 3880 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 3881
dc44c39a
PE
38822012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3883
078c97cb
PE
3884 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
3885
dc44c39a
PE
3886 * unexaix.c: Port to more-recent AIX compilers.
3887 (report_error, report_error_1, make_hdr, copy_sym)
3888 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
3889 Make arguments const char *, not char *, to avoid violations of C
3890 standard and to fix some AIX warnings reported by Gilles Pion.
3891
e18afed7 38922012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
3893
3894 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
3895 already have overlays loaded.
3896 (handle_single_display_spec): Before returning without displaying
3897 fringe bitmap, synchronize the bidi iterator with the main display
3898 iterator, by calling iterate_out_of_display_property.
3899 (iterate_out_of_display_property): Detect buffer iteration by
3900 testing that it->string is a Lisp string.
3901 (get_next_display_element): When the current object is exhausted,
3902 and there's something on it->stack, call set_iterator_to_next to
3903 proceed with what's on the stack, instead of returning zero.
3904 (set_iterator_to_next): If called at the end of a Lisp string,
3905 proceed to consider_string_end without incrementing string
3906 position. Don't increment display vector index past the end of
3907 the display vector. (Bug#11417)
c8fb9dc6
EZ
3908 (pos_visible_p): Don't report a position visible when move_it_to
3909 stopped at the last line of window, which happens to be scanned
3910 backwards by the bidi iteration. (Bug#11464)
ac268e67 3911
e18afed7 39122012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
3913
3914 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
3915 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
3916 are on a TTY, and thus unable to display on the fringes.
3917 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
3918 so we need to signal to the caller that this is a "replacing"
3919 display spec. This fixes display when the spec is invalid or we
3920 are on a TTY.
3921
e18afed7 39222012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
3923
3924 * unexaix.c (make_hdr): Fix typo in prototype.
3925 This bug broke the build on AIX. Problem reported by Gilles Pion.
3926
9d0a235a
MA
39272012-05-14 Michael Albinus <michael.albinus@gmx.de>
3928
3929 * keyboard.c (kbd_buffer_get_event): Read special events also in
3930 batch mode. (Bug#11415)
3931
9e6b06ed
GM
39322012-05-12 Glenn Morris <rgm@gnu.org>
3933
3934 * ns.mk: Update for ns_appbindir no longer having trailing "/".
3935
c1a1d7a3
EZ
39362012-05-12 Eli Zaretskii <eliz@gnu.org>
3937
3938 * lisp.mk (lisp): Add newcomment.elc.
3939
3fe7cdc8
GM
39402012-05-12 Glenn Morris <rgm@gnu.org>
3941
3942 * Makefile.in (MKDIR_P): New, set by configure.
3943 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
3944
53f7d2c0
PE
39452012-05-11 Paul Eggert <eggert@cs.ucla.edu>
3946
3947 Remove unused function hourglass_started.
3948 * dispextern.h (hourglass_started):
3949 * w32fns.c (hourglass_started):
3950 * xdisp.c (hourglass_started): Remove.
3951
75aafb17
JB
39522012-05-10 Juanma Barranquero <lekktu@gmail.com>
3953
3954 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
3955 Update dependencies.
3956
12959e8e
PE
39572012-05-10 Paul Eggert <eggert@cs.ucla.edu>
3958
97107e2e
PE
3959 * xgselect.c (xg_select): Put maxfds+1 into a var.
3960 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
3961
12959e8e
PE
3962 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
3963
836d29b3
DA
39642012-05-10 Dave Abrahams <dave@boostpro.com>
3965
3966 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
3967 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
3968
5cb67954
MA
39692012-05-09 Michael Albinus <michael.albinus@gmx.de>
3970
3971 * dbusbind.c (xd_registered_buses): New internal Lisp object.
3972 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
3973 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
3974 Initialize xd_registered_buses.
3975
3478ec45
PE
39762012-05-09 Paul Eggert <eggert@cs.ucla.edu>
3977
b263a6b0
PE
3978 Untag more efficiently if USE_LSB_TAG.
3979 This is based on a proposal by YAMAMOTO Mitsuharu in
3980 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
3981 For an admittedly artificial (nth 8000 longlist) benchmark on
3982 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
3983 Emacs's overall text size by 1%.
3984 * lisp.h (XUNTAG): New macro.
3985 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
3986 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
3987 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
3988 * eval.c (Fautoload):
3989 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
3990 * frame.h (XFRAME): Use XUNTAG.
3991
3478ec45
PE
3992 Port recent dbusbind.c changes to 32-bit --with-wide-int.
3993 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
3994 Remove unportable assumptions about print widths of types like
3995 dbus_uint32_t.
3996 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
3997 intptr_t when converting between pointer and integer, to avoid GCC
3998 warnings about wrong width.
3999
666b903b 40002012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
4001
4002 * w32proc.c (new_child): Force Windows to reserve only 64KB of
4003 stack for each reader_thread, instead of defaulting to 8MB
4004 determined by the linker. This avoids failures in creating
4005 subprocesses on Windows 7, see the discussion in this thread:
4006 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
4007
b120cc17
JC
40082012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
4009
4010 Fix up display of the *Minibuf-0* buffer in the mini window.
4011 * keyboard.c (read_char): Don't clear the echo area if there's no
4012 message to clear.
4013 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 4014 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 4015
9a4b36f8
MA
40162012-05-07 Michael Albinus <michael.albinus@gmx.de>
4017
4018 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
4019 batch mode.
4020
e5f9458f
CY
40212012-05-06 Chong Yidong <cyd@gnu.org>
4022
4023 * lisp.mk (lisp): Update.
4024
eceeb5fc 40252012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
4026
4027 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
4028
71873e2b
SM
40292012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
4030
4031 * data.c (PUT_ERROR): New macro.
4032 (syms_of_data): Use it. Add new error type `user-error'.
4033 * undo.c (user_error): New function.
4034 (Fprimitive_undo): Use it.
4035 * print.c (print_error_message): Adjust print style for `user-error'.
4036 * keyboard.c (user_error): New function.
4037 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
4038
ab0fa4e4
PE
40392012-05-03 Paul Eggert <eggert@cs.ucla.edu>
4040
4041 Do not limit current-time-string to years 1000..9999.
4042 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
4043 (Fcurrent_time_string): Support any year that is supported by the
4044 underlying localtime representation. Don't use asctime, as it
4045 has undefined behavior for years outside the range -999..9999.
4046
7ed806a7
PE
40472012-05-02 Paul Eggert <eggert@cs.ucla.edu>
4048
4049 Fix race conditions involving setenv, gmtime, localtime, asctime.
4050 Without this fix, interrupts could mess up code that uses these
4051 nonreentrant functions, since setting TZ invalidates existing
4052 tm_zone or tzname values, and since most of these functions return
4053 pointers to static storage.
4054 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
4055 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
4056 Grow the critical sections to include not just invoking
4057 localtime/gmtime, but also accessing these functions' results
4058 including their tm_zone values if any, and any related TZ setting.
4059 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
4060 so that the struct tm is saved in the critical section.
4061 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
4062 motivated by the fact that memory allocation needs to be outside
4063 the critical section.
4064
0c16dfed
DA
40652012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
4066
4067 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
4068 with RESET_INTERVAL.
4069
4070 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4071 Remove duplicated buffer name initialization.
4072
3f83ace8
JM
40732012-05-02 Jim Meyering <jim@meyering.net>
4074
4075 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
4076
c7b8541e
JM
4077 * xfns.c (x_window): Use xstrdup (Bug#11375).
4078
90207a15 40792012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
4080
4081 * xdisp.c (pos_visible_p): If already at a newline from the
4082 display string before the 'while' loop, don't walk back the glyphs
4083 from it3.glyph_row. Solves assertion violation when the display
4084 string begins with a newline (egg.el). (Bug#11367)
4085
b593d6a9
AH
40862012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
4087
4088 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
4089 Move to simple.el.
4090
4737362e
GM
40912012-05-01 Glenn Morris <rgm@gnu.org>
4092
99cf43f9
GM
4093 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
4094 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
4095 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
4096 All were removed before 23.1.
4097
9311dcff
GM
4098 * dispnew.c: Remove HAVE_LIBNCURSES test;
4099 it is always true on relevant platforms.
4100
4d5c6349
GM
4101 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
4102 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
4103
4737362e
GM
4104 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
4105
74dd3a6b
AS
41062012-04-30 Andreas Schwab <schwab@linux-m68k.org>
4107
4108 * .gdbinit (xpr): Remove checks for no longer existing misc types.
4109 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
4110 Remove.
4111
13c379ee
PE
41122012-04-28 Paul Eggert <eggert@cs.ucla.edu>
4113
4114 Do not avoid creating empty evaporating overlays (Bug#9642).
4115 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
4116 That is, do not delete an evaporating overlay if it becomes
4117 empty after its bounds are adjusted to fit within its buffer.
4118 This fix caused other problems, and I'm reverting it until we get
4119 to the bottom of them.
4120
a8e7d6d7 41212012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
4122
4123 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
4124
a8e7d6d7 41252012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
4126
4127 * xdisp.c (pos_visible_p): If the window start position is beyond
4128 ZV, start the display from buffer beginning. Prevents assertion
4129 violation in init_iterator when the minibuffer window is scrolled
4130 via the scroll bar.
4131
4132 * window.c (window_scroll_pixel_based): Likewise.
4133
a8e7d6d7 41342012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
4135
4136 * keymap.c (where_is_internal): Doc fix (Bug#10872).
4137
a8e7d6d7 41382012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
4139
4140 * fileio.c (Fcopy_file, Fset_file_selinux_context):
4141 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
4142
a8e7d6d7 41432012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 4144
b593d6a9
AH
4145 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
4146 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 4147
1c6900d9
EZ
41482012-04-26 Eli Zaretskii <eliz@gnu.org>
4149
4c3fa1d9
EZ
4150 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
4151 display element, check also the underlying string or buffer
4152 character. (Bug#11341)
4153
1c6900d9
EZ
4154 * w32menu.c: Include w32heap.h.
4155 (add_menu_item): If the call to AppendMenuW (via
4156 unicode_append_menu) fails, disable Unicode menus only if we are
4157 running on Windows 9X/Me.
4158
42bf8205
AS
41592012-04-24 Andreas Schwab <schwab@linux-m68k.org>
4160
4161 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
4162 (xgetint): Add missing shift for LSB tags.
4163
b1bac16e
MR
41642012-04-24 Martin Rudalics <rudalics@gmx.at>
4165
4166 * keyboard.c (read_char): Don't wipe echo area for select window
4167 events: These might get delayed via `mouse-autoselect-window'
4168 (Bug#11304).
4169
d69621cc
JB
41702012-04-24 Juanma Barranquero <lekktu@gmail.com>
4171
4172 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
4173 manipulation of :loaded-from data.
4174
02fd101b
JB
41752012-04-23 Juanma Barranquero <lekktu@gmail.com>
4176
4177 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
4178 now a cons (bug#11311).
4179
888bec30
PE
41802012-04-23 Paul Eggert <eggert@cs.ucla.edu>
4181
89a438bd
PE
4182 Do not create empty overlays with the evaporate property (Bug#9642).
4183 * buffer.c (Fmove_overlay): Delete an evaporating overlay
4184 if it becomes empty after its bounds are adjusted to fit within
4185 its buffer. Without this fix, in a nonempty buffer (let ((o
4186 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
4187 yields an empty overlay that has the evaporate property, which is
4188 not supposed to happen.
4189
1068fe4d
PE
4190 Fix minor GTK3 problems found by static checking.
4191 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4192 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4193 (struct _EmacsFixedClass, emacs_fixed_get_type):
4194 Move decls here from emacsgtkfixed.h, since they needn't be public.
4195 (emacs_fixed_get_type): Now static.
4196 (emacs_fixed_class_init): Omit unused local.
4197 (emacs_fixed_child_type): Remove; unused.
4198 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4199 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4200 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
4201 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
4202 (EMACS_FIXED_GET_CLASS): Remove; unused.
4203 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
4204
888bec30
PE
4205 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
4206 Problem reported by Juanma Barranquero for Windows -Wunused-function.
4207
de85e130
PE
42082012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4209
d0baac98 4210 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 4211 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
4212 (__malloc_size_t, __malloc_ptrdiff_t):
4213 Remove. All uses removed, replaced by the definiens if needed,
4214 since we can assume C89 or better now.
4215 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
4216 (protect_malloc_state, align, get_contiguous_space)
4217 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
4218 (malloc_atfork_handler_child, malloc_enable_thread)
4219 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
4220 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
4221 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
4222 (special_realloc, _realloc_internal_nolock, _realloc_internal)
4223 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
4224 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
4225 Define using prototypes, not old style.
4226 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
4227 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
4228 (align): Don't assume that signed integer overflow wraps around.
4229 Omit unused local var.
4230 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
4231 (_free_internal_nolock, memalign, mallochook, reallochook):
4232 Omit no-longer-needed casts.
4233 (valloc): Use getpagesize, not __getpagesize.
4234 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
4235 (struct hdr): The 'magic' member is now size_t, not unsigned long.
4236
de85e130
PE
4237 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
4238
dcbf5805
MA
42392012-04-22 Michael Albinus <michael.albinus@gmx.de>
4240
4241 Move functions from C to Lisp. Make non-blocking method calls
4242 the default. Implement further D-Bus standard interfaces.
4243
4244 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
4245 (QCdbus_request_name_allow_replacement)
4246 (QCdbus_request_name_replace_existing)
4247 (QCdbus_request_name_do_not_queue)
4248 (QCdbus_request_name_reply_primary_owner)
4249 (QCdbus_request_name_reply_in_queue)
4250 (QCdbus_request_name_reply_exists)
4251 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
4252 (QCdbus_registered_serial, QCdbus_registered_method)
4253 (QCdbus_registered_signal): New Lisp objects.
4254 (XD_DEBUG_MESSAGE): Use sizeof.
4255 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
4256 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
4257 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
4258 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
4259 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
4260 (xd_signature, xd_append_arg): Allow float for integer types.
4261 (xd_get_connection_references): New function.
b593d6a9
AH
4262 (xd_get_connection_address): Rename from xd_initialize.
4263 Return cached address.
dcbf5805
MA
4264 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
4265 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
4266 level.
4267 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 4268 Return number of refcounts.
dcbf5805
MA
4269 (Fdbus_get_unique_name): Make stronger parameter check.
4270 (Fdbus_message_internal): New defun.
4271 (Fdbus_call_method, Fdbus_call_method_asynchronously)
4272 (Fdbus_method_return_internal, Fdbus_method_error_internal)
4273 (Fdbus_send_signal, Fdbus_register_service)
4274 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
4275 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
4276 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
4277 (Vdbus_compiled_version, Vdbus_runtime_version)
4278 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
4279 (Vdbus_message_type_method_return, Vdbus_message_type_error)
4280 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
4281 (Vdbus_registered_buses, Vdbus_registered_objects_table):
4282 Adapt docstring.
dcbf5805 4283
52828e02
PE
42842012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4285
da05bc4c
PE
4286 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
4287 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
4288 Do not assume ptrdiff_t is the same width as 'int'.
4289
52828e02
PE
4290 * alloc.c: Handle unusual debugging option combinations.
4291 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
4292 since the two debugging options are incompatible.
4293 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
4294 is defined.
4295 (mem_init, mem_insert, mem_insert_fixup):
4296 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
4297 (NEED_MEM_INSERT): Remove; no longer needed.
4298
f01769f9
LL
42992012-04-22 Leo Liu <sdl.web@gmail.com>
4300
4301 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
4302
5790543d
PE
43032012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4304
4305 * sysdep.c [__FreeBSD__]: Minor cleanups.
4306 (list_system_processes, system_process_attributes) [__FreeBSD__]:
4307 Use Emacs indenting style more consistently. Avoid some casts.
4308 Use 'double' consistently rather than mixing 'float' and 'double'.
4309
b91b7e4d
EW
43102012-04-21 Eduard Wiebe <usenet@pusto.de>
4311
b593d6a9
AH
4312 * sysdep.c (list_system_processes, system_process_attributes):
4313 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 4314
6114eb15
AS
43152012-04-21 Andreas Schwab <schwab@linux-m68k.org>
4316
4317 * lisp.mk (lisp): Update.
4318
2f38dff7
PE
43192012-04-20 Paul Eggert <eggert@cs.ucla.edu>
4320
4321 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
4322 It is never used otherwise.
4323
4ae29f89
SM
43242012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
4325
4326 * print.c (print_preprocess): Only check print_depth if print-circle
4327 is nil.
4328 (print_object): Check for cycles even when print-circle is nil and
4329 print-gensym is t, but only check print_depth if print-circle is nil.
4330
f30d612a
CY
43312012-04-20 Chong Yidong <cyd@gnu.org>
4332
4333 * process.c (wait_reading_process_output): If EIO occurs on a pty,
4334 set the status to "failed" and ensure that sentinel is run.
4335
c07a4c0b 43362012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
4337
4338 * process.c (Fset_process_inherit_coding_system_flag)
4339 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 4340 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 4341
c07a4c0b 43422012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
4343
4344 * xdisp.c (string_buffer_position_lim): Limit starting position to
4345 BEGV.
4346 (set_cursor_from_row): If called for a mode-line or header-line
4347 row, return zero immediately.
4348 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
4349 farther than the first row after the header line, if any.
4350 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
4351 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
4352
c07a4c0b 43532012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 4354
4ae29f89
SM
4355 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
4356 (bug#11238).
ad3a2b41 4357
c07a4c0b 43582012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 43592012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
4360
4361 configure: new option --enable-gcc-warnings (Bug#11207)
4362 * Makefile.in (C_WARNINGS_SWITCH): Remove.
4363 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
4364 (ALL_CFLAGS): Use new macros rather than old.
4365 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
4366 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
4367 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
4368 -Wunused-result, -Wunused-variable. This should go away once
4369 the Emacs and Gnulib regex code is merged.
4370 (xmalloc, xrealloc): Now static.
4371
aba027e8
PE
43722012-04-17 Paul Eggert <eggert@cs.ucla.edu>
4373
4374 * dired.c (Fsystem_groups): Remove unused local.
4375
e5a36063
GM
43762012-04-17 Glenn Morris <rgm@gnu.org>
4377
4378 * dired.c (Fsystem_users): Doc fix.
4379
316411f0
DA
43802012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
4381
4382 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
4383 (syms_of_dired): Add them.
4384
9426aba4
PE
43852012-04-16 Paul Eggert <eggert@cs.ucla.edu>
4386
b62a57be
PE
4387 Fix minor alloc.c problems found by static checking.
4388 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
4389 New extern decls, to avoid calling undeclared functions.
4390 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
4391 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
4392 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
4393 (NEED_MEM_INSERT): New macro.
4394 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 4395 Remove one incorrect comment and fix another.
b62a57be 4396
3539f31f
PE
4397 Fix minor ralloc.c problems found by static checking.
4398 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4399 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
4400 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
4401 (r_alloc_sbrk): Now static.
4402
a041960a
PE
4403 Improve ralloc.c interface checking.
4404 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4405 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
4406 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
4407 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
4408 [REL_ALLOC]: ... to here, to check interface.
4409 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
4410 Remove decls. This fixes an "It stinks!".
4411
9426aba4
PE
4412 * alloc.c (which_symbols): Fix alignment issue / type clash.
4413
d55c12ed
AS
44142012-04-15 Andreas Schwab <schwab@linux-m68k.org>
4415
4416 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
4417 (struct Lisp_Misc_Any): Likewise.
4418 (struct Lisp_Free): Likewise.
4419 * alloc.c (union aligned_Lisp_Symbol): Define.
4420 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
4421 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
4422 (union aligned_Lisp_Misc): Define.
4423 (MARKER_BLOCK_SIZE, struct marker_block): Use union
4424 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 4425 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 4426
b948ce8b
PE
44272012-04-14 Paul Eggert <eggert@cs.ucla.edu>
4428
4429 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
4430 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
4431 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
4432 * s/netbsd.h, s/sol2-6.h:
4433 Remove definition of GC_MARK_STACK, since the default now works.
4434 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
4435 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
4436 no longer the default.
4437 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
4438
35dc09a1 44392012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 4440
35dc09a1
GM
4441 * lread.c (lisp_file_lexically_bound_p):
4442 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 4443
35dc09a1
GM
44442012-04-14 Eli Zaretskii <eliz@gnu.org>
4445
4446 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
4447 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
4448
44492012-04-14 Jan Djärv <jan.h.d@swipnet.se>
4450
4451 * nsterm.m (constrainFrameRect): Always constrain when there is only
4452 one screen (Bug#10962).
4453
bcd86815
KB
44542012-04-13 Ken Brown <kbrown@cornell.edu>
4455
4456 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
4457
c25df26e
RT
44582012-04-13 Reuben Thomas <rrt@sc3d.org>
4459
4460 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
4461
0fc59f1e
DC
44622012-04-11 Daniel Colascione <dancol@dancol.org>
4463
4464 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
4465 against is gone. It's better to use vfork now so that when Cygwin
4466 gains a new, working vfork, we use it automatically (bug#10398).
4467
de8c03dc
SM
44682012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4469
4470 * window.c (save_window_save): Obey window-point-insertion-type.
4471
2f097256
GM
44722012-04-11 Glenn Morris <rgm@gnu.org>
4473
4474 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
4475
453b951e
SM
44762012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4477
4478 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
4479
75f1671a 44802012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
4481
4482 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
4483 (force_quit_count): New var.
4484 (handle_interrupt): Use it.
4485
2a8ce227
JB
44862012-04-10 Juanma Barranquero <lekktu@gmail.com>
4487
4488 * w32.c (w32_delayed_load): Record the full path of the library
4489 being loaded (bug#10424).
4490
935396c0
GM
44912012-04-09 Glenn Morris <rgm@gnu.org>
4492
05920a43
GM
4493 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
4494 not just in the obarray, before snarfing them. (Bug#11036)
4495
935396c0
GM
4496 * Makefile.in ($(leimdir)/leim-list.el):
4497 Pass EMACS rather than BUILT_EMACS.
4498
a18ecafa
TZ
44992012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
4500
4501 * process.c (make_process):
4502 * process.h: Add integer `gnutls_handshakes_tried' member to
4503 process struct.
4504
6bbef4e5
JC
4505 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
4506 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
4507
4508 * gnutls.c (gnutls_log_function2i): Convenience log function.
4509 (emacs_gnutls_read): Use new log functions,
4510 `gnutls_handshakes_tried' process member, and
4511 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
4512 attempts per process (connection).
4513
b4d3bc10
CY
45142012-04-09 Chong Yidong <cyd@gnu.org>
4515
4516 * eval.c (Fuser_variable_p, user_variable_p_eh)
4517 (lisp_indirect_variable): Functions deleted.
4518 (Fdefvar): Caller changed.
4519
4520 * callint.c (Finteractive, Fcall_interactively):
4521 * minibuf.c (Fread_variable): Callers changed.
4522
70f4d973
EZ
45232012-04-09 Eli Zaretskii <eliz@gnu.org>
4524
4525 * xdisp.c (set_cursor_from_row): If the display string appears in
4526 the buffer at position that is closer to point than the position
4527 after the display string, display the cursor on the first glyph of
4528 the display string. Fixes cursor display when a 'display' text
4529 property immediately follows invisible text. (Bug#11094)
4530
cb3c2e3e
PE
45312012-04-09 Paul Eggert <eggert@cs.ucla.edu>
4532
4533 composite.c: use 'double' consistently
4534 * composite.c (get_composition_id): Use 'double' consistently
4535 instead of converting 'float' to 'double' and vice versa; this is
4536 easier to understand and avoids a GCC warning.
4537
fd06db5d
GM
45382012-04-09 Glenn Morris <rgm@gnu.org>
4539
50fe702a
GM
4540 * Makefile.in: Generate leim-list with bootstrap-emacs, in
4541 preparation for dumping it with emacs. (Bug#4789)
4542 (leimdir): New variable.
4543 ($(leimdir)/leim-list.el): New rule.
4544 (emacs$(EXEEXT)): Depend on leim-list.el.
4545
fd06db5d
GM
4546 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
4547 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
4548 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
4549
55c131ee
AS
45502012-04-08 Andreas Schwab <schwab@linux-m68k.org>
4551
4552 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
4553 proper alignment.
4554
9209588f
JB
45552012-04-07 Juanma Barranquero <lekktu@gmail.com>
4556
4557 * xml.c (init_libxml2_functions) [WINDOWSNT]:
4558 Remove unused local variable.
4559
e3fb2efb
PE
45602012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4561
4562 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
4563 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
4564 (mark_memory): Mark Lisp_Objects only if pointers might hide in
4565 objects, as mark_maybe_pointer will catch them otherwise.
4566 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
4567 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
4568
b5385551
PE
45692012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4570
4571 Fix typo that broke non-Windows builds.
4572 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
4573
9078ead6
EZ
45742012-04-07 Eli Zaretskii <eliz@gnu.org>
4575
4576 Support building on MS-Windows with libxml2.
4577
4578 * makefile.w32-in (OBJ2): Add xml.$(O).
4579 (GLOBAL_SOURCES): Add xml.c.
4580 ($(BLD)/xml.$(O)): New dependency list.
4581
4582 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
4583 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
4584 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
4585 [!WINDOWSNT]: New macros.
4586 (init_libxml2_functions, libxml2_loaded_p): New functions.
4587 (parse_region): Call fn_xmlCheckVersion instead of using the macro
4588 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
4589 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
4590 Calls xmlCleanupParser only if libxml2 was loaded (or statically
4591 linked in).
6bbef4e5
JC
4592 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
4593 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
4594 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
4595
4596 * emacs.c: Don't include libxml/parser.h.
4597 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
4598 xmlCleanupParser directly.
4599
4600 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
4601
3811fdf3
EZ
46022012-04-07 Eli Zaretskii <eliz@gnu.org>
4603
4604 * indent.c (Fvertical_motion): If there is a display string at
4605 point, use it.vpos to compute how many lines to backtrack after
4606 move_it_to point. (Bug#11133)
4607
2f8e16b2
EZ
46082012-04-06 Eli Zaretskii <eliz@gnu.org>
4609
4610 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
4611 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
4612 about subtle differences between FETCH_CHAR* and STRING_CHAR*
4613 macros related to unification of CJK characters. For the details,
4614 see the discussion following the message here:
4615 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
4616
3d439cd1
CY
46172012-04-04 Chong Yidong <cyd@gnu.org>
4618
4619 * keyboard.c (Vdelayed_warnings_list): Doc fix.
4620
8bc53d00
EZ
46212012-04-01 Eli Zaretskii <eliz@gnu.org>
4622
4623 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
4624 instead of alloca. (Bug#11138)
4625
3b0512a3
AS
46262012-04-01 Andreas Schwab <schwab@linux-m68k.org>
4627
4628 * w32menu.c (is_simple_dialog): Properly check lisp types.
4629 (Bug#11141)
4630
8427ddd2
EZ
46312012-03-31 Eli Zaretskii <eliz@gnu.org>
4632
979022ef
EZ
4633 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
4634 position we get to after a call to move_it_to fails the
4635 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
4636 only if we wind up in a string from display property. (Bug#11063)
4637
a6b1c7cc
EZ
4638 * window.c (Fdelete_other_windows_internal): Invalidate the row
4639 and column information about mouse highlight, so that redisplay
4640 restores it after reallocating the glyph matrices. (Bug#7464)
4641
8427ddd2
EZ
4642 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
4643 string comes from a `display' text property, use the buffer
4644 position of that property as if we actually saw that position in
4645 the row's glyphs.
697ba24b
EZ
4646 (move_it_by_lines): Remove the assertion that
4647 "it->current_x == 0 && it->hpos == 0" which can be legitimately
4648 violated when there's a before-string at the beginning of a line.
4649 (Bug#11063)
8427ddd2 4650
65a0a738
EZ
46512012-03-30 Eli Zaretskii <eliz@gnu.org>
4652
4653 * xdisp.c (append_space_for_newline): If the default face was
4654 remapped, use the remapped face for the appended newline.
4655 (extend_face_to_end_of_line): Use the remapped default face for
4656 extending the face to the end of the line.
4657 (display_line): Call extend_face_to_end_of_line when the default
4658 face was remapped. (Bug#11068)
4659
581355cc
EZ
46602012-03-29 Eli Zaretskii <eliz@gnu.org>
4661
4662 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
4663
e8fc049f
SM
46642012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4665
4666 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
4667
4fb9a543
GM
46682012-03-27 Glenn Morris <rgm@gnu.org>
4669
4670 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
4671 Doc fixes.
4672
679910f1
KH
46732012-03-26 Kenichi Handa <handa@m17n.org>
4674
4675 * dispextern.h (struct glyph): Fix previous change. Change the
4676 bit length of glyphless.ch to 25 (Bug#11082).
4677
90d49b7f
CY
46782012-03-26 Chong Yidong <cyd@gnu.org>
4679
4680 * keyboard.c (Vselection_inhibit_update_commands): New variable.
4681 (command_loop_1): Use it; inhibit selection update for
4682 handle-select-window too (Bug#8996).
4683
f514f6f0
FP
46842012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
4685
e8fc049f 4686 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 4687
bf43fa51
KH
46882012-03-25 Kenichi Handa <handa@m17n.org>
4689
4690 * dispextern.h (struct glyph): Change the bit length of
4691 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
4692
8a0c01dd
EZ
46932012-03-24 Eli Zaretskii <eliz@gnu.org>
4694
4695 * s/ms-w32.h (tzname): Include time.h before redirecting to
4696 _tzname. Fixes the MSVC build. (Bug#9960)
4697
7d1c3a76
AS
46982012-03-24 Andreas Schwab <schwab@linux-m68k.org>
4699
8ed79523
AS
4700 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
4701 characters.
4702
7d1c3a76
AS
4703 * xterm.c (XTread_socket): Only modify handling_signal if
4704 !SYNC_INPUT. (Bug#11080)
4705
e99a9b8b
EZ
47062012-03-23 Eli Zaretskii <eliz@gnu.org>
4707
4708 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
4709 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
4710 when fetching a multibyte character consumes more bytes than
4711 CHAR_BYTES returns, due to unification of CJK characters in
4712 string_char. (Bug#11073)
4713
5063c0e1
TN
47142012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
4715
4716 * process.c (wait_reading_process_output): Handle pty disconnect
4717 by refraining from sending oneself a SIGCHLD (bug#10933).
4718
9f851fbd
CY
47192012-03-22 Chong Yidong <cyd@gnu.org>
4720
4721 * dispextern.h (struct it): New member string_from_prefix_prop_p.
4722
5063c0e1 4723 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
4724 Mark string as coming from a prefix property.
4725 (handle_face_prop): Use default face for prefix strings (Bug#4281).
4726 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
4727
fb5b8aca
CY
47282012-03-21 Chong Yidong <cyd@gnu.org>
4729
4730 * xfaces.c (Vface_remapping_alist): Doc fix.
4731
62356a1b
EZ
47322012-03-20 Eli Zaretskii <eliz@gnu.org>
4733
4734 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
4735 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
4736 Doc fixes.
62356a1b 4737
025de85b
CY
47382012-03-20 Chong Yidong <cyd@gnu.org>
4739
4740 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
4741 to reflect default non-nil value of redisplay-dont-pause.
4742
4827f94e
KH
47432012-03-19 Kenichi Handa <handa@m17n.org>
4744
4745 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
4746 it fit in a valid range (Bug#11003).
4747
e50a24a2
EZ
47482012-03-18 Eli Zaretskii <eliz@gnu.org>
4749
4750 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
4751 that is not from display property, accept the row as a "cursor
4752 row" if one of the string's character has a non-nil `cursor'
4753 property. Fixes cursor positioning when there are newlines in
4754 overlay strings, e.g. in icomplete.el. (Bug#11035)
4755
9af5ed87
PE
47562012-03-12 Paul Eggert <eggert@cs.ucla.edu>
4757
4758 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
4759
d1f55f16
CY
47602012-03-12 Chong Yidong <cyd@gnu.org>
4761
4762 * eval.c (inhibit_lisp_code): Rename from
4763 inhibit_window_configuration_change_hook; move from window.c.
4764
4765 * xfns.c (unwind_create_frame_1, Fx_create_frame):
4766 * window.c (run_window_configuration_change_hook)
4767 (syms_of_window): Callers changed.
4768
66c5eebd
CY
47692012-03-11 Chong Yidong <cyd@gnu.org>
4770
413df973
CY
4771 * keymap.c (Fkey_description): Doc fix (Bug#9700).
4772
66c5eebd
CY
4773 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
4774
1de11f56
CY
47752012-03-10 Chong Yidong <cyd@gnu.org>
4776
4777 * frame.c (other_visible_frames): Don't assume the selected frame
4778 is visible (Bug#10955).
4779
cae07000
SM
47802012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
4781
4782 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
4783
89c94350
JD
47842012-03-08 Jan Djärv <jan.h.d@swipnet.se>
4785
4786 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
4787 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
4788 zero (Bug#10954).
4789
999dd333
GM
47902012-03-03 Glenn Morris <rgm@gnu.org>
4791
01a6dcc8 4792 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 4793
de0100f2
EZ
47942012-03-02 Eli Zaretskii <eliz@gnu.org>
4795
4796 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
4797 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
4798 (redisplay_window, next_element_from_string): Fix typos in
4799 comments.
3e441275
EZ
4800 (redisplay_window): Pass to move_it_vertically the margin in
4801 pixels, not in screen lines.
de0100f2 4802
96a72ee9
GM
48032012-03-02 Glenn Morris <rgm@gnu.org>
4804
4805 * buffer.c (buffer-list-update-hook): Doc fix.
4806
312508d7
EZ
48072012-02-29 Eli Zaretskii <eliz@gnu.org>
4808
4809 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
4810 push_it before setting up the iterator for the first overlay
4811 string, even if we have an empty string loaded.
4812 (next_overlay_string): If there's an empty string on the iterator
4813 stack, pop the stack. (Bug#10903)
4814
27f3c637
PE
48152012-02-25 Paul Eggert <eggert@cs.ucla.edu>
4816
4817 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
4818 Suggested by Stefan Monnier in
4819 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
4820 * alloc.c (widen_to_Lisp_Object): New static function.
4821 (mark_memory): Also mark Lisp_Objects by fetching pointer words
4822 and widening them to Lisp_Objects. This would work even if
4823 USE_LSB_TAG is defined and wide integers are used, which might
4824 happen in a future version of Emacs.
4825
3c9dfce6
CY
48262012-02-25 Chong Yidong <cyd@gnu.org>
4827
fa74b241
CY
4828 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
4829 Doc fix.
4830
3c9dfce6
CY
4831 * xselect.c (Fx_selection_exists_p): Doc fix.
4832 (x_clipboard_manager_save_all): Print an informative message
4833 before saving to clipboard manager.
4834
9486df08
CY
48352012-02-24 Chong Yidong <cyd@gnu.org>
4836
4837 * keyboard.c (process_special_events): Handle all X selection
4838 requests in kbd_buffer, not just the next one (Bug#8869).
4839
f01d3321
CY
48402012-02-23 Chong Yidong <cyd@gnu.org>
4841
4842 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
4843 call when setting menu-bar-lines and tool-bar-lines parameters.
4844 (unwind_create_frame_1): New helper function.
4845
4846 * window.c (inhibit_window_configuration_change_hook): New var.
4847 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 4848 (syms_of_window): Initialize it.
f01d3321 4849
86b847b6
CY
48502012-02-22 Chong Yidong <cyd@gnu.org>
4851
4852 * xterm.c (x_draw_image_relief): Add missing type check for
4853 Vtool_bar_button_margin (Bug#10743).
4854
a59225b1
CY
48552012-02-21 Chong Yidong <cyd@gnu.org>
4856
4857 * fileio.c (Vfile_name_handler_alist): Doc fix.
4858
4859 * buffer.c (Fget_file_buffer): Protect against invalid file
4860 handler return value.
4861
310f5bd4
PE
48622012-02-20 Paul Eggert <eggert@cs.ucla.edu>
4863
cb3a28cc
PE
4864 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
4865 when computing $valmask.
4866
310f5bd4
PE
4867 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
4868 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
4869 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
4870 It's useless in that case, and it can cause problems on hosts
4871 that allocate halves of EMACS_INT values separately.
4872 Reported by Dan Horák. Diagnosed by Andreas Schwab in
4873 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
4874 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
4875 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
4876 it avoids undefined behavior on hosts where shifting right by more
4877 than the word width has undefined behavior.
4878
2375c96a
CY
48792012-02-19 Chong Yidong <cyd@gnu.org>
4880
4881 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
4882 (Funhandled_file_name_directory, Ffile_name_as_directory)
4883 (Fdirectory_file_name, Fexpand_file_name)
4884 (Fsubstitute_in_file_name): Protect against invalid file handler
4885 return values (Bug#10845).
4886
3eb49e71
EZ
48872012-02-18 Eli Zaretskii <eliz@gnu.org>
4888
4889 * .gdbinit (pitx): Fix incorrect references to fields of the
4890 iterator stack.
4891
7b926f3f
CY
48922012-02-17 Chong Yidong <cyd@gnu.org>
4893
4894 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
4895
11273115
PE
48962012-02-15 Paul Eggert <eggert@cs.ucla.edu>
4897
4898 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
4899 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
4900
c3a70e2b
CY
49012012-02-15 Chong Yidong <cyd@gnu.org>
4902
4903 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
4904 marked as special. Also, starting docstrings with * is obsolete.
4905
0ca43699
AS
49062012-02-13 Andreas Schwab <schwab@linux-m68k.org>
4907
4908 * gnutls.c (emacs_gnutls_write): Fix last change.
4909
2e8f3c56
LI
49102012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
4911
4912 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
4913 send_process.
4914
af70074f
SM
49152012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
4916
4917 * keymap.c (Fsingle_key_description): Handle char ranges.
4918
95986d52
CY
49192012-02-12 Chong Yidong <cyd@gnu.org>
4920
afd83bd1
CY
4921 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
4922 as that creates a dangerous corner case.
4923
95986d52
CY
4924 * window.c (Fdelete_window_internal): Invalidate the mouse
4925 highlight (Bug#9904).
4926
bd7da63e
GM
49272012-02-12 Glenn Morris <rgm@gnu.org>
4928
4929 * xselect.c (Fx_own_selection_internal)
4930 (Fx_get_selection_internal, Fx_disown_selection_internal)
4931 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
4932 * nsselect.m (Fx_own_selection_internal)
4933 (Fx_disown_selection_internal, Fx_selection_exists_p)
4934 (Fx_selection_owner_p, Fx_get_selection_internal):
4935 Sync docs and argument specs with the xselect.c versions.
4936
77abcbc2
LI
49372012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
4938
4939 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
4940
90b671e2
EZ
49412012-02-11 Eli Zaretskii <eliz@gnu.org>
4942
1c0ca0b7
EZ
4943 * w32select.c (Fx_selection_exists_p): Sync doc string and
4944 argument list with xselect.c. (Bug#10783)
4945
4946 * w16select.c (Fx_selection_exists_p): Sync doc string and
4947 argument list with xselect.c. (Bug#10783)
90b671e2 4948
49241268
GM
49492012-02-10 Glenn Morris <rgm@gnu.org>
4950
4951 * fns.c (Fsecure_hash): Doc fix.
4952
f998bbe7 49532012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
4954
4955 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
4956
0992bd9c
CY
49572012-02-07 Chong Yidong <cyd@gnu.org>
4958
4959 * buffer.c (Fbuffer_local_variables)
4960 (buffer_lisp_local_variables): Handle unbound vars correctly;
4961 don't let Qunbound leak into Lisp.
4962
af008560
GM
49632012-02-07 Glenn Morris <rgm@gnu.org>
4964
dd605cc4
GM
4965 * image.c (Fimagemagick_types): Doc fix.
4966
af008560
GM
4967 * image.c (imagemagick-render-type): Change it from a lisp object
4968 to an integer. Move the doc here from the lisp manual.
4969 Treat all values not equal to 0 the same.
4970
1449fa1d
CY
49712012-02-06 Chong Yidong <cyd@gnu.org>
4972
4973 * doc.c (store_function_docstring): Avoid applying docstring of
4974 alias to base function (Bug#2603).
4975
3723ec07
AS
49762012-02-04 Andreas Schwab <schwab@linux-m68k.org>
4977
4978 * .gdbinit (pp1, pv1): Remove redundant defines.
4979 (pr): Use pp.
4980
79c1cc1e
CY
49812012-02-04 Chong Yidong <cyd@gnu.org>
4982
4983 * nsterm.m: Declare a global (Bug#10694).
4984
d7f29f8e
EZ
49852012-02-04 Eli Zaretskii <eliz@gnu.org>
4986
cae07000
SM
4987 * w32.c (get_emacs_configuration_options):
4988 Include --enable-checking, if specified, in the return value.
d7f29f8e 4989
3b95a6f9
MR
49902012-02-04 Martin Rudalics <rudalics@gmx.at>
4991
4992 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
4993 after rounding frame sizes. (Bug#9723)
4994
d6fa96a6
EZ
49952012-02-04 Eli Zaretskii <eliz@gnu.org>
4996
4997 * keyboard.c (adjust_point_for_property): Don't position point
4998 before BEGV. (Bug#10696)
4999
df0b2940
PE
50002012-02-03 Paul Eggert <eggert@cs.ucla.edu>
5001
5002 Handle overflow when computing char display width (Bug#9496).
5003 * character.c (char_width): Return EMACS_INT, not int.
5004 (char_width, c_string_width): Check for overflow when
5005 computing the width; this is possible now that individual
5006 characters can have unbounded width. Problem introduced
5007 by merge from Emacs 23 on 2012-01-19.
5008
6bee44d6
MA
50092012-02-02 Michael Albinus <michael.albinus@gmx.de>
5010
5011 * dbusbind.c (Fdbus_register_method): Mention the return value
5012 :ignore in the docstring.
5013
44f92739
GM
50142012-02-02 Glenn Morris <rgm@gnu.org>
5015
1b9f60cc
GM
5016 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
5017
44f92739
GM
5018 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5019 Unconditionally set to t. (Bug#10673)
5020 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5021 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
5022 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
5023
c5d3843c
KH
50242012-02-02 Kenichi Handa <handa@m17n.org>
5025
5026 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
5027 0, do not call append_composite_glyph.
5028
159462d4 50292012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
5030
5031 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
5032 NULL (Bug#6988).
5033 (x_produce_glyphs): If the component of a composition is a null
5034 string, set it->pixel_width to 1 to avoid zero-width glyph.
5035
78cef877
EZ
50362012-02-01 Eli Zaretskii <eliz@gnu.org>
5037
5038 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
5039 first 2 arguments are identical. This makes inserting large
5040 output from a subprocess an order of magnitude faster on
5041 MS-Windows, where all sbrk'ed memory is always contiguous.
5042
97897668
GM
50432012-01-31 Glenn Morris <rgm@gnu.org>
5044
5045 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 5046 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
5047 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
5048
31fd3586
GM
50492012-01-29 Glenn Morris <rgm@gnu.org>
5050
5051 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
5052
0e24a8b2
CY
50532012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
5054
5055 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
5056
cc0adcb0
CY
50572012-01-28 Chong Yidong <cyd@gnu.org>
5058
5059 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
5060
acc28cb9
CY
50612012-01-26 Chong Yidong <cyd@gnu.org>
5062
9c69cfb7
CY
5063 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
5064
acc28cb9
CY
5065 * search.c (Fsearch_forward, Fsearch_backward): Document negative
5066 repeat counts (Bug#10507).
5067
48da7392
GM
50682012-01-26 Glenn Morris <rgm@gnu.org>
5069
5070 * lread.c (syms_of_lread): Doc fix.
5071
14af5f7f
CY
50722012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
5073
5074 * coding.c (encode_designation_at_bol): Change return value to
5075 EMACS_INT.
5076
0b21c100
CY
50772012-01-25 Chong Yidong <cyd@gnu.org>
5078
5079 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
5080
3c2907f7
CY
50812012-01-21 Chong Yidong <cyd@gnu.org>
5082
5083 * floatfns.c (Fcopysign): Make the second argument non-optional,
5084 since nil is not allowed anyway.
5085
959ad23f
AS
50862012-01-21 Andreas Schwab <schwab@linux-m68k.org>
5087
5088 * process.c (read_process_output): Use p instead of XPROCESS (proc).
5089 (send_process): Likewise.
5090
34a02f46
MR
50912012-01-19 Martin Rudalics <rudalics@gmx.at>
5092
5093 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
5094 (Vwindow_persistent_parameters): Do not use Qstate.
5095 Rewrite doc-strings.
34a02f46 5096
1259009a 50972012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
5098
5099 * character.c (char_width): New function.
70d4fdf6
GM
5100 (Fchar_width, c_string_width, lisp_string_width):
5101 Use char_width (Bug#9496).
25ed9e61 5102
6a6ee00d
MR
51032012-01-16 Martin Rudalics <rudalics@gmx.at>
5104
5105 * window.c (Vwindow_persistent_parameters): New variable.
5106 (Fset_window_configuration, save_window_save): Handle persistent
5107 window parameters.
5108
c85efaf7
EZ
51092012-01-14 Eli Zaretskii <eliz@gnu.org>
5110
5111 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
5112 thrashing the stack of the thread. (Bug#9087)
5113
5944709e
PE
51142012-01-12 Paul Eggert <eggert@cs.ucla.edu>
5115
5116 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
5117
e71f5d99
EZ
51182012-01-11 Eli Zaretskii <eliz@gnu.org>
5119
5120 * xdisp.c (rows_from_pos_range): Handle the case where the
5121 highlight ends on a newline. (Bug#10464)
5122 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
5123 he end column for display of highlight that ends on a newline
5124 before a R2L line.
5125
ce316182
GM
51262012-01-11 Glenn Morris <rgm@gnu.org>
5127
5128 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
5129 from load-path also when installation-directory is nil. (Bug#10208)
5130
5b43da69
GM
51312012-01-10 Glenn Morris <rgm@gnu.org>
5132
74cc8ff9
GM
5133 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
5134
7d8d6e4e
GM
5135 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
5136 Update template values to be closer to their typical values these days.
5b43da69 5137
a0db8d43
EZ
51382012-01-09 Eli Zaretskii <eliz@gnu.org>
5139
5140 * xdisp.c (rows_from_pos_range): Accept additional argument
5141 DISP_STRING, and accept any glyph in a row whose object is that
5142 string as eligible for mouse highlight. Fixes mouse highlight of
5143 display strings from overlays. (Bug#10464)
5144
9a0115ab 51452012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 5146
b9110d6a 5147 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
5148 * fileio.c (auto_saving_dir_umask): New static var.
5149 (Fmake_directory_internal): Use it.
5150 (do_auto_save_make_dir): Set it, instead of invoking chmod after
5151 creating the directory. The old code temporarily assigns
5152 too-generous permissions to the directory.
5153 (do_auto_save_eh): Clear it.
b9110d6a 5154 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
5155 that the var is always cleared.
5156
6c1bd3f3
EZ
51572012-01-07 Eli Zaretskii <eliz@gnu.org>
5158
5159 * search.c (scan_buffer): Pass character positions to
5160 know_region_cache, not byte positions. (Bug#6540)
5161
069d2b50
L
51622012-01-07 LynX <_LynX@bk.ru> (tiny change)
5163
5164 * w32.c (sys_rename): Report EXDEV when rename of a directory
5165 fails because the target is on another logical disk. (Bug#10284)
5166
75bf0d33
DB
51672012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
5168
5169 * xterm.c (x_embed_request_focus): New function.
5170
5171 * xterm.h: Add prototype.
5172
5173 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
5174
1c6e5a32
GM
51752012-01-05 Glenn Morris <rgm@gnu.org>
5176
5177 * emacs.c (emacs_copyright): Update short copyright year to 2012.
5178
651e947e
EZ
51792012-01-01 Eli Zaretskii <eliz@gnu.org>
5180
5181 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
5182 Load gnutls_transport_set_lowat only if GnuTLS version is below
5183 2.11.1.
5184 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
5185 GnuTLS versions below 2.11.1.
5186
3778cdd8
AL
51872011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
5188
5189 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
5190 to the doc string advising against its use for altering the way
5191 windows are scrolled.
5192
0e5317f7
KH
51932011-12-28 Kenichi Handa <handa@m17n.org>
5194
5195 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
5196 coding-system ASCII compatible only when it does not produce BOM
5197 on encoding (Bug#10383).
5198
93d5ca1f
JD
51992011-12-26 Jan Djärv <jan.h.d@swipnet.se>
5200
5201 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
5202 can scroll.
5203 (create_and_show_popup_menu): Always use menu_position_func for
5204 Gtk3 (Bug#10361).
5205
ca22b785
AS
52062011-12-24 Andreas Schwab <schwab@linux-m68k.org>
5207
5208 * callint.c (Fcall_interactively): Don't truncate prompt string.
5209
d048e1e6
EZ
52102011-12-23 Eli Zaretskii <eliz@gnu.org>
5211
5212 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
5213 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 5214 resumed from there (after widening). (Bug#10360)
d048e1e6 5215
5ccaba1f
JD
52162011-12-22 Jan Djärv <jan.h.d@swipnet.se>
5217
5218 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
5219
204ee57f
JD
52202011-12-21 Jan Djärv <jan.h.d@swipnet.se>
5221
b81d40f0
JB
5222 * nsterm.m (x_free_frame_resources):
5223 Release f->output_data.ns->miniimage.
204ee57f
JD
5224 (ns_index_color): Fix indentation. Do not retain
5225 color_table->colors[i].
5226
5227 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
5228 before returning.
5229
5230 * nsfns.m (x_set_background_color): Assign return value from
5231 ns_index_color to face-background instead of NSColor*.
5232 (ns_implicitly_set_icon_type): Fix indentation.
5233 Change assignment in for loop to comparison.
5234
5235 * emacs.c (ns_pool): New variable.
5236 (main): Assign ns_pool.
5237 (Fkill_emacs): Call ns_release_autorelease_pool.
5238
5239 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
5240 autorelease fdesc, release fdAttrs and tdict.
5241 (ns_get_covering_families): Release charset.
5242 (ns_findfonts): Release NSFontDescriptor created with new.
5243 (ns_uni_to_glyphs): Fix indentation.
5244 (setString): Release attrStr before assigning new value.
5245
c803b2b7
JD
52462011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5247
678f4426
JD
5248 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
5249 and NS_IMPL_COCOA.
5250 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
5251 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
5252
cd394be1 52532011-12-18 David Reitter <reitter@cmu.edu>
678f4426 5254
5fecd5fc
JD
5255 * nsterm.m (ns_term_init): Subscribe for notifications
5256 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
5257 to method trackingNotification in EmacsMenu.
5258
5259 * nsmenu.m (trackingMenu): New variable.
3771cb17 5260 (trackingNotification): New method (from Aquamacs).
5fecd5fc 5261 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 5262 from Aquamacs (Bug#7030).
678f4426
JD
5263
52642011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 5265
c803b2b7
JD
5266 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
5267 (symbol_to_nsstring): Fix indentation.
5268 (ns_symbol_to_pb): New function.
cae07000
SM
5269 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
5270 (Fns_rotate_cut_buffers_internal): Remove.
5271 (Fns_store_selection_internal): Rename from
c803b2b7
JD
5272 Fns_store_cut_buffer_internal.
5273 (ns_get_foreign_selection, Fx_own_selection_internal)
5274 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
5275 (Fns_get_selection_internal, Fns_store_selection_internal):
5276 Use ns_symbol_to_pb and check if return value is nil.
5277 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
5278 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
5279 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
5280 renamed to Sns_store_selection_internal.
5281 (ns_handle_selection_request): Move code to Fx_own_selection_internal
5282 and remove this function.
5283 (ns_handle_selection_clear): Remove, never used.
5284 (Fx_own_selection_internal): Move code from ns_handle_selection_request
5285 here.
5286
e1b01a3a
KB
52872011-12-17 Ken Brown <kbrown@cornell.edu>
5288
5289 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
5290 GID is unknown (Bug#10257).
5291
2adb6e85
PE
52922011-12-17 Paul Eggert <eggert@cs.ucla.edu>
5293
5294 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
5295 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
5296 which caused a build failure on GNU/Linux IA-64. This problem was
5297 introduced by my 2011-10-07 patch.
5298
d1d7b339
JL
52992011-12-15 Juri Linkov <juri@jurta.org>
5300
5301 * image.c (imagemagick_error): New function. (Bug#10112)
5302 (imagemagick_load_image): Comment out `MagickSetResolution' call.
5303 Use `imagemagick_error' where ImageMagick functions return
5304 `MagickFalse'.
5305 (Fimagemagick_types): Add `Fnreverse' to return the list in the
5306 proper order.
5307
100d5755
KH
53082011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5309
5310 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
5311 fill background (Bug#8992).
5312
454592a6
MR
53132011-12-13 Martin Rudalics <rudalics@gmx.at>
5314
5315 * window.c (Vwindow_combination_resize)
5316 (Vwindow_combination_limit): Use t instead of non-nil in
5317 doc-strings.
61d4b438
MR
5318 (Vrecenter_redisplay): Add first sentence of doc-string on
5319 separate line.
53524d93 5320 (Frecenter): Fix doc-string typo.
454592a6 5321
3633e3aa
KH
53222011-12-11 Kenichi Handa <handa@m17n.org>
5323
5324 * coding.c (Funencodable_char_position): Pay attention to the
5325 buffer text relocation (Bug#9389).
5326
7b9d523a 53272011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 5328
7b9d523a
JD
5329 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
5330 gtk_init (Bug#10100).
5331
b73189c6
EZ
53322011-12-10 Eli Zaretskii <eliz@gnu.org>
5333
5334 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
5335 IT->string is nil. (Bug#10263)
5336
f7dfe5d6
JD
53372011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5338
83faebb4
JD
5339 * nsterm.h (x_free_frame_resources): Declare.
5340
f7dfe5d6
JD
5341 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
5342 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
5343
5344 * nsterm.h (ns_get_defaults_value): Declare.
5345
5346 * nsterm.m (ns_default): Call ns_get_defaults_value.
5347
7cd4e72c
EZ
53482011-12-09 Eli Zaretskii <eliz@gnu.org>
5349
5350 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
5351 (Bug#10170)
5352
b34d7317
YM
53532011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5354
5355 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
5356 that where the value of an _OBJC_* symbol points to is in the .bss
5357 section (Bug#10240).
5358
76470ad1
KH
53592011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5360
5361 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 5362 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 5363
745fff94
KH
53642011-12-08 Kenichi Handa <handa@m17n.org>
5365
5366 * ftfont.c (get_adstyle_property): Fix previous change
5367 (Bug#10233).
5368
6e44397c
JB
53692011-12-07 Juanma Barranquero <lekktu@gmail.com>
5370
5371 * w32.c (init_environment): If no_site_lisp, remove site-lisp
5372 dirs from the default value of EMACSLOADPATH (bug#10208).
5373
7efa6272
GM
53742011-12-07 Glenn Morris <rgm@gnu.org>
5375
5376 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
5377 installation and source directories as well. (Bug#10208)
5378
f6fc4d87
CY
53792011-12-06 Chong Yidong <cyd@gnu.org>
5380
5381 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
5382
2bf26180
GM
53832011-12-06 Glenn Morris <rgm@gnu.org>
5384
5385 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
5386 as an error, not just -1. (Bug#10217)
5387
3a6ad4f0
CY
53882011-12-05 Chong Yidong <cyd@gnu.org>
5389
5390 * keyboard.c (process_special_events): New function.
5391 (swallow_events, Finput_pending_p): Use it (Bug#10195).
5392
75a3b399
PE
53932011-12-05 Paul Eggert <eggert@cs.ucla.edu>
5394
5395 * coding.c (encode_designation_at_bol): Don't use uninitialized
5396 local variable (Bug#9318).
5397
c3c9e25e
KH
53982011-12-05 Kenichi Handa <handa@m17n.org>
5399
5400 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
5401 return Qnil (Bug#8046, Bug#10193).
5402
5eb05ea3
KH
54032011-12-05 Kenichi Handa <handa@m17n.org>
5404
5405 * coding.c (encode_designation_at_bol): New args charbuf_end and
5406 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
5407 (coding_set_source): Return how many bytes coding->source was
5408 relocated.
5409 (coding_set_destination): Return how many bytes
5410 coding->destination was relocated.
5411 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 5412 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
5413
54142011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5415
5416 * coding.c (CODING_CHAR_CHARSET_P): New macro.
5417 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
5418 macro (Bug#9318).
5419
54202011-12-05 Andreas Schwab <schwab@linux-m68k.org>
5421
5422 The following changes are to fix Bug#9318.
5423
a79703f5 5424 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
5425 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
5426 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 5427 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 5428
7dbda6df
JB
54292011-12-05 Juanma Barranquero <lekktu@gmail.com>
5430
5431 * lisp.h (process_quit_flag): Fix external declaration.
5432
6d5eb5b0
SM
54332011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
5434
5435 Don't macro-inline non-performance-critical code.
5436 * eval.c (process_quit_flag): New function.
5437 * lisp.h (QUIT): Use it.
5438
a0c3fad0
JD
54392011-12-04 Jan Djärv <jan.h.d@swipnet.se>
5440
5441 * nsfns.m (get_geometry_from_preferences): New function.
5442 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
5443
6c07aac2
AS
54442011-12-04 Andreas Schwab <schwab@linux-m68k.org>
5445
5446 * emacs.c (Qkill_emacs): Define.
5447 (syms_of_emacs): Initialize it.
5448 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
5449 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
5450 (quit_throw_to_read_char): Add parameter `from_signal'.
5451 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
5452 * lisp.h (QUIT): Call Fkill_emacs if requested.
5453
c052ead4
JD
54542011-12-03 Jan Djärv <jan.h.d@swipnet.se>
5455
5456 * widget.c (update_wm_hints): Return if wmshell is null.
5457 (widget_update_wm_size_hints): New function.
5458
5459 * widget.h (widget_update_wm_size_hints): Declare.
5460
5461 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
5462 widget_update_wm_size_hints (Bug#10104).
5463
9e49252b
EZ
54642011-12-03 Eli Zaretskii <eliz@gnu.org>
5465
5466 * xdisp.c (handle_invisible_prop): If the invisible text ends just
5467 before a newline, prepare the bidi iterator for consuming the
5468 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 5469 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 5470
02b16839
JL
54712011-12-02 Juri Linkov <juri@jurta.org>
5472
5473 * search.c (Fword_search_regexp): New Lisp function created from
5474 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
5475 (Fword_search_backward, Fword_search_forward)
5476 (Fword_search_backward_lax, Fword_search_forward_lax):
5477 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
5478 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
5479
0068070e
SM
54802011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
5481
5482 * fileio.c (Finsert_file_contents): Move after-change-function call
5483 to before the "handled:" label, since all "goto handled" appear in
5484 cases where the *-change-functions have already been properly called
5485 (bug#10117).
5486
3360a3fc
AS
54872011-12-01 Andreas Schwab <schwab@linux-m68k.org>
5488
5489 * keyboard.c (interrupt_signal): Don't call kill-emacs when
5490 waiting for input. (Bug#10169)
5491
73d6c093
EZ
54922011-11-30 Eli Zaretskii <eliz@gnu.org>
5493
5494 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
5495 verifies glyph row's hash code--we have just reallocated the
5496 glyphs, so their contents can be complete garbage. (Bug#10164)
5497
febe6bea
JB
54982011-11-30 Juanma Barranquero <lekktu@gmail.com>
5499
5500 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
5501
801a4313
EZ
55022011-11-30 Eli Zaretskii <eliz@gnu.org>
5503
5504 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
5505 attributes are tested _before_ calling verify_row_hash, to protect
5506 against GCC re-ordering of the tests. (Bug#10164)
5507
2b56b87e
JD
55082011-11-29 Jan Djärv <jan.h.d@swipnet.se>
5509
5510 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
5511
5512 * xterm.c (handle_one_xevent): Only set async_visible and friends
5513 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 5514 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
5515 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
5516
dbf31225
PE
55172011-11-28 Paul Eggert <eggert@cs.ucla.edu>
5518
5519 Remove GCPRO-related macros that exist only to avoid shadowing locals.
5520 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
5521 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
5522 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5523 All uses changed to use GCPRO1 etc.
5524 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
5525 Revert to old implementation (i.e., before 2011-03-11).
5526
1305621b
YM
55272011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5528
5529 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
5530 of scroll runs so as to avoid assigning disabled bogus rows and
5531 unnecessary graphics copy operations.
5532
8c9afb46
EZ
55332011-11-27 Eli Zaretskii <eliz@gnu.org>
5534
5535 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
5536 (snprintf) [_MSC_VER]: Redirect to _snprintf.
5537 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
5538 (malloc, free, realloc, calloc): Redirect to e_* only when
5539 compiling Emacs.
5540
5541 * lisp.h (GCTYPEBITS): Move before first use.
5542 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
5543 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
5544 this macro definition.
5545
5546 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
5547 _MSC_VER.
5548
54e9e3bf
JD
55492011-11-27 Jan Djärv <jan.h.d@swipnet.se>
5550
6d5eb5b0
SM
5551 * gtkutil.c (xg_create_frame_widgets):
5552 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
5553 present with Gtk+ 2.0.
5554
83aca1cb
PE
55552011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5556
5557 * fileio.c (Finsert_file_contents): Undo previous change; see
5558 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5559
5b76caa4
PE
55602011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5561
5562 Rename locals to avoid shadowing.
5563 * fileio.c (Finsert_file_contents):
5564 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
5565 * process.c (wait_reading_process_output):
5566 Rename inner 'proc' to 'p' to avoid shadowing.
5567 Indent for consistency with usual Emacs style.
5568
8c535114
EZ
55692011-11-25 Eli Zaretskii <eliz@gnu.org>
5570
5571 * xdisp.c (redisplay_window): If cursor row is not fully visible
5572 after recentering, and scroll-conservatively is set to a large
5573 number, scroll window by a few more lines to make the cursor fully
5574 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
5575 (start_display): Don't move to the next line if the display should
5576 start at a newline that is part of a display vector or an overlay
5577 string. (Bug#10119)
8c535114 5578
fa4fdb5c
JL
55792011-11-24 Juri Linkov <juri@jurta.org>
5580
5581 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
5582 after the `MagickPingImage' call. (Bug#10112)
5583
90ec88df
CY
55842011-11-23 Chong Yidong <cyd@gnu.org>
5585
5586 * window.c (Fcoordinates_in_window_p): Accept only live windows.
5587
56e2e794
MR
55882011-11-23 Martin Rudalics <rudalics@gmx.at>
5589
5590 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
5591 making another buffer current. (Bug#10114)
5592
b6e64c41
GM
55932011-11-23 Glenn Morris <rgm@gnu.org>
5594
5595 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
5596
6b21de18
CY
55972011-11-23 Chong Yidong <cyd@gnu.org>
5598
5599 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
5600 using it (Bug#5984).
5601
b12cd789
EZ
56022011-11-22 Eli Zaretskii <eliz@gnu.org>
5603
5604 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
5605 and header-lines, as they don't have one computed for them.
5606 (Bug#10098)
5607
5608 * .gdbinit (prow): Make displayed values more self-explaining.
5609 Add row's hash code.
5610
261b6fd4
LMI
56112011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
5612
5613 * process.c (wait_reading_process_output): Fix asynchrounous
5614 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 5615 (wait_reading_process_output): Add comment and URL.
261b6fd4 5616
e7cfd277
JD
56172011-11-21 Jan Djärv <jan.h.d@swipnet.se>
5618
5619 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
5620
a9b9b7f5
CY
56212011-11-21 Chong Yidong <cyd@gnu.org>
5622
5623 * window.c (Fnext_window, Fprevious_window): Doc fix.
5624
b0d15b4f
SM
56252011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5626
5627 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
5628
fe7a3057
JB
56292011-11-20 Juanma Barranquero <lekktu@gmail.com>
5630
5631 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
5632
d2999b1a
MR
56332011-11-20 Martin Rudalics <rudalics@gmx.at>
5634
5635 * window.c (Fset_window_combination_limit): Rename argument
5636 STATUS to LIMIT.
5637 (Vwindow_combination_limit): Remove "status" from doc-string.
5638
d5ff9cd0
AS
56392011-11-20 Andreas Schwab <schwab@linux-m68k.org>
5640
5641 * m/ibms390.h: Remove.
5642 * m/ibms390x.h: Don't include "ibms390.h".
5643
a5bb9bd3
SM
56442011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5645
5646 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
5647 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
5648
cd1181db
JB
56492011-11-20 Juanma Barranquero <lekktu@gmail.com>
5650
5651 * casetab.c (Fset_case_table):
5652 * charset.c (Fcharset_after): Fix typos.
5653
615a3b8d 56542011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 5655
17e845af
PE
5656 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
5657 Otherwise, valgrind does not work on some platforms.
5658 Problem reported by Andreas Schwab in
6a0bf43d
PE
5659 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
5660 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
5661 is set, removing the need for VIRT_ADDRESS_VARIES.
5662 (PURE_P): Use a more-efficient implementation that needs just one
5663 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
5664 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
5665 to 4 (xorl, subq, cmpq, setbe).
5666 * alloc.c (pure): Always extern now, since that's the
5667 VIRT_ADDR_VARIES behavior.
5668 (PURE_POINTER_P): Use a single comparison, not two, for
5669 consistency with the new puresize.h.
5670 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
5671 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
5672 Remove VIRT_ADDR_VARIES no longer needed.
5673
f8fe6f96
EZ
56742011-11-19 Eli Zaretskii <eliz@gnu.org>
5675
5676 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
5677 (erase_phys_cursor, update_window_cursor, show_mouse_face)
5678 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
5679 behave as if the cursor position were at the window margin.
5680
5681 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
5682 and the cursor position is out of bounds, behave as if the cursor
5683 position were at the window margin. (Bug#10075)
5684
df05a53c
CY
56852011-11-18 Chong Yidong <cyd@gnu.org>
5686
5687 * window.c (Fwindow_combination_limit): Make first argument
5688 non-optional, since it is meaningless for live windows like the
5689 selected window.
61ccba97 5690
2071918e
DA
56912011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
5692
5693 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
5694
b50a28de
SM
56952011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
5696
5697 * intervals.c: Fix grafting over the whole buffer (bug#10071).
5698 (graft_intervals_into_buffer): Simplify.
5699
015137db
EZ
57002011-11-18 Eli Zaretskii <eliz@gnu.org>
5701
5702 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
5703 hash values of the two rows.
5704 (copy_row_except_pointers): Preserve the used[] arrays and the
5705 hash values of the two rows. (Bug#10035)
68c95424 5706 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
5707
5708 * xdisp.c (row_hash): New function, body extracted from
5709 compute_line_metrics.
5710 (compute_line_metrics): Call row_hash, instead of computing the
5711 hash code inline.
5712
5713 * dispnew.c (verify_row_hash): Call row_hash for computing the
5714 hash code of a row, instead of duplicating code from xdisp.c.
5715
5716 * dispextern.h (row_hash): Add prototype.
5717
a2addb04
TH
57182011-11-18 Tassilo Horn <tassilo@member.fsf.org>
5719
5720 * frame.c (delete_frame): Don't delete the terminal when the last
5721 X frame is closed if emacs is built with GTK toolkit.
5722
df85d315
JB
57232011-11-17 Juanma Barranquero <lekktu@gmail.com>
5724
5725 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
5726
a0c2d0ae
MR
57272011-11-17 Martin Rudalics <rudalics@gmx.at>
5728
5729 * window.c (Vwindow_splits): Rename to
5730 Vwindow_combination_resize. Suggested by Juri Linkov.
5731 (Fsplit_window_internal): Use Vwindow_combination_resize instead
5732 of Vwindow_splits.
5733
58179cce
JB
57342011-11-16 Juanma Barranquero <lekktu@gmail.com>
5735
7877f373
JB
5736 * nsfns.m (Fns_font_name):
5737 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 5738
b6f67890
MR
57392011-11-16 Martin Rudalics <rudalics@gmx.at>
5740
5741 * window.h (window): Rename slot "nest" to "combination_limit".
5742 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
5743 (Fset_window_nest): Rename to Fset_window_combination_limit.
5744 (Vwindow_nest): Rename to Vwindow_combination_limit.
5745 (recombine_windows, make_parent_window, make_window)
5746 (Fsplit_window_internal, saved_window)
5747 (Fset_window_configuration, save_window_save): Rename all
5748 occurrences of window_nest to window_combination_limit.
5749
c7015153
JB
57502011-11-15 Juanma Barranquero <lekktu@gmail.com>
5751
5752 * image.c (imagemagick_load_image): Fix typo.
5753
322ad6ec
EZ
57542011-11-14 Eli Zaretskii <eliz@gnu.org>
5755
5756 * xdisp.c (display_line): Move the call to
5757 highlight_trailing_whitespace before the call to
5758 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
5759 faces of all the glyphs to compute ROW's hash value.
5760 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 5761
f067b8ec
JB
57622011-11-14 Juanma Barranquero <lekktu@gmail.com>
5763
5764 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
5765 just return (bug#10044).
5766
1e5b2111
EZ
57672011-11-12 Eli Zaretskii <eliz@gnu.org>
5768
7ef3cbd5
EZ
5769 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
5770 with user-defined heap size. Bump the default size of the temacs
5771 heap to 27MB, to avoid memory warning when running temacs.
5772 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
5773
1e5b2111
EZ
5774 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
5775 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
5776 (verify_row_hash) [XASSERTS]: New function.
5777 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
5778 that the hash value of glyph rows is correct.
1e5b2111 5779
89d61221
MR
57802011-11-12 Martin Rudalics <rudalics@gmx.at>
5781
5782 * window.h (window): Remove splits slot.
5783 * window.c (Fwindow_splits, Fset_window_splits): Remove.
5784 (Fdelete_other_windows_internal, make_parent_window)
5785 (make_window, Fsplit_window_internal, Fdelete_window_internal)
5786 (Fset_window_configuration, save_window_save): Don't deal with
5787 split status of windows.
5788 (saved_window): Remove splits slot.
5789 (Vwindow_splits): Rewrite doc-string.
5790
97f18cc8
JD
57912011-11-11 Jan Djärv <jan.h.d@swipnet.se>
5792
5793 * xfns.c (unwind_create_frame):
5794 * nsfns.m (unwind_create_frame):
5795 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
5796 Vframe_list (Bug#9999).
5797
22a648b4
DA
57982011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
5799
0b381c7e 5800 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 5801
659afede
KH
58022011-11-11 Kenichi Handa <handa@m17n.org>
5803
5804 * callproc.c (Fcall_process): Set the member dst_multibyte of
5805 process_coding.
5806
9ac0394b
KH
58072011-11-11 Johan Bockgård <bojohan@gnu.org>
5808
5809 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
5810 avoid a crash (bug#9496).
5811
2fbdc249
CY
58122011-11-09 Chong Yidong <cyd@gnu.org>
5813
5814 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
5815 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
5816
ac6b1f81
PE
58172011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5818
5819 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
5820
09db192c
PE
58212011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5822
5823 Avoid some portability problems by eschewing 'extern inline' functions.
5824 The trivial performance wins aren't worth the portability hassles; see
5825 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
5826 et seq.
5827 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5828 (window_box_width, window_box_left, window_box_left_offset)
5829 (window_box_right, window_box_right_offset): Undo previous change,
5830 by removing the "extern"s.
5831 * intervals.c (adjust_intervals_for_insertion)
5832 (adjust_intervals_for_deletion): Undo previous change,
5833 making these static again.
5834 (offset_intervals, temp_set_point_both, temp_set_point)
5835 (copy_intervals_to_string): No longer inline.
5836 * xdisp.c (window_text_bottom_y, window_box_width)
5837 (window_box_height, window_box_left_offset)
5838 (window_box_right_offset, window_box_left, window_box_right)
5839 (window_box): No longer inline.
5840
105216ed
CY
58412011-11-08 Chong Yidong <cyd@gnu.org>
5842
5843 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
5844 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
5845 Signal an error if not a live window.
105216ed
CY
5846 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
5847 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
5848
ae9e237f
JB
58492011-11-07 Juanma Barranquero <lekktu@gmail.com>
5850
5851 * lisp.h (syms_of_abbrev): Remove declaration.
5852 Reported by CHENG Gao <chenggao@royau.me>.
5853
c7aa8333
EZ
58542011-11-07 Eli Zaretskii <eliz@gnu.org>
5855
5856 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
5857 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
5858 of temacs in GUI mode.
5859
be7f5545
MR
58602011-11-07 Martin Rudalics <rudalics@gmx.at>
5861
5862 * window.h: Declare delete_all_child_windows instead of
5863 delete_all_subwindows.
5864 * window.c (Fwindow_nest, Fset_window_nest)
5865 (Fset_window_new_total, Fset_window_new_normal)
5866 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
5867 (delete_all_subwindows): Rename to delete_all_child_windows.
5868 (Fdelete_other_windows_internal, Fset_window_configuration):
5869 Call delete_all_child_windows instead of delete_all_subwindows.
5870 * frame.c (delete_frame): Call delete_all_child_windows instead
5871 of delete_all_subwindows.
5872
ca78dc43
PE
58732011-11-07 Paul Eggert <eggert@cs.ucla.edu>
5874
5875 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
5876 This is also needed for porting to any host where GC_MARK_STACK is
5877 not GC_MAKE_GCPROS_NOOPS.
5878 (which_symbols): Use it.
5879
a0241d01
KH
58802011-11-07 Kenichi Handa <handa@m17n.org>
5881
5882 * coding.c (coding_set_destination): Check coding->src_pos only
5883 when coding->src_object is a buffer (bug#9910).
5884
5885 * process.c (send_process): Set the member src_multibyte of coding
5886 to 0 (bug#9911) when sending a unibyte text.
5887
5888 * callproc.c (Fcall_process): Set the member src_multibyte of
5889 process_coding to 0 (bug#9912).
5890
a64bfdfa 58912011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
5892
5893 * xmenu.c (cleanup_widget_value_tree): New function.
5894 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
5895 calling free_menubar_widget_value_tree directly (Bug#9830).
5896
cb41b32a
PE
58972011-11-06 Paul Eggert <eggert@cs.ucla.edu>
5898
5899 Fix some portability problems with 'inline'.
5900 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5901 (window_box_width, window_box_left, window_box_left_offset)
5902 (window_box_right, window_box_right_offset): Declare extern.
5903 Otherwise, these inline functions do not conform to C99 and
5904 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
5905 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
5906 * intervals.c (adjust_intervals_for_insertion)
5907 (adjust_intervals_for_deletion): Now extern, because otherwise the
5908 extern inline functions 'offset_intervals' couldn't refer to it.
5909 (static_offset_intervals): Remove.
5910 (offset_intervals): Rewrite using the old contents of
5911 static_offset_intervals. The old version didn't conform to C99
5912 because an extern inline function contained a reference to an
5913 identifier with static linkage.
5914
b7041366
AS
59152011-11-06 Andreas Schwab <schwab@linux-m68k.org>
5916
5917 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
5918 GC.
5919
88a37c4d
EZ
59202011-11-06 Eli Zaretskii <eliz@gnu.org>
5921
5922 * xdisp.c (init_iterator, reseat_to_string): Don't set the
5923 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
5924 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
5925 return Qleft_to_right.
5926
49745b39
CY
59272011-11-06 Chong Yidong <cyd@gnu.org>
5928
5929 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
5930 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
5931 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
5932 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
5933 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
5934 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
5935 (Fwindow_vscroll): Doc fix.
5936 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
5937 argument, since it makes no sense to pass a live window and for
5938 consistency with window-child.
5939
1f05cd82
CS
59402011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
5941
5942 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
5943 support MSVC.
5944
22610910
JR
59452011-11-05 Jason Rumney <jasonr@gnu.org>
5946
5947 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
5948 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
5949 fonts (Bug#6029).
5950 (add_font_entity_to_list): Fix logic errors in mixed boolean and
5951 bitwise arithmetic preventing use of unicode-sip and non-truetype
5952 opentype fonts.
5953
a06776b2
EZ
59542011-11-05 Eli Zaretskii <eliz@gnu.org>
5955
3ad924ba
EZ
5956 * s/ms-w32.h (fstat, stat, utime): Move redirections to
5957 "emacs"-only part.
5958
a06776b2
EZ
5959 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
5960 initialization code to keep similarity to xfns.c after changes
5961 from 2011-11-05.
5962
c9e7db78
JD
59632011-11-05 Jan Djärv <jan.h.d@swipnet.se>
5964
a97f8f3f
JD
5965 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
5966 (unwind_create_frame): New function (Bug#9943).
5967 (Fx_create_frame): Restructure code to be more similar to the one in
5968 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
5969 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
5970 Move terminal->reference_count++ just before making the frame official
5971 (Bug#9943).
5972
5973 * nsterm.m (x_free_frame_resources): New function.
5974 (x_destroy_window): Move code to x_free_frame_resources.
5975
c9e7db78 5976 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
5977 (Fx_create_frame, x_create_tip_frame):
5978 Move terminal->reference_count++ just before making the frame
75f1671a 5979 official. Move initialization of image_cache_refcount and
c9e7db78
JD
5980 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
5981
a6fc3b5c
EZ
59822011-11-05 Eli Zaretskii <eliz@gnu.org>
5983
5984 Support MSVC build with newer versions of Visual Studio.
5985 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
5986 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
5987 nt/gmake.defs.
5988
5989 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
5990 which are not supported by MSVC.
5991 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
5992 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
5993 bitfields.
5994 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
5995 types in bitfields.
5996 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
5997
5998 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
5999
58179cce 60002011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
6001
6002 Support MSVC build with newer versions of Visual Studio.
6003 * w32.c: Don't include w32api.h for MSVC.
6004 (init_environment) [_MSC_VER]: Call sys_access, not _access.
6005
6006 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
6007 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
6008 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
6009 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
6010 e_* cousins.
6011 (alloca) [_MSC_VER]: Define to _alloca.
6012
6013 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
6014
6015 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
6016
a58c13ed
EZ
60172011-11-04 Eli Zaretskii <eliz@gnu.org>
6018
6019 * xdisp.c (note_mouse_highlight): If either of
6020 previous/next-single-property-change returns nil, treat that as
6021 the beginning or the end of the buffer. (Bug#9955)
6022
fe0b6370
JD
60232011-11-04 Jan Djärv <jan.h.d@swipnet.se>
6024
a58c13ed 6025 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
6026 label is not null (Bug#9951).
6027 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
6028 may be NULL.
6029
89bd5ee1
EZ
60302011-11-04 Eli Zaretskii <eliz@gnu.org>
6031
6032 * window.c (Fwindow_body_size): Mention in the doc string that the
6033 return value is in frame's canonical units. (Bug#9949)
6034
84c3edb9
EZ
60352011-11-03 Eli Zaretskii <eliz@gnu.org>
6036
4e2fb5c7
EZ
6037 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
6038
84c3edb9 6039 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 6040 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 6041 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 6042
bc17a887
EZ
60432011-11-01 Eli Zaretskii <eliz@gnu.org>
6044
6045 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
6046 Don't stop backward scan on the continuation glyph, even though
6047 its CHARPOS is positive.
6d5eb5b0
SM
6048 (mouse_face_from_buffer_pos, note_mouse_highlight):
6049 Rename cover_string to disp_string.
bc17a887 6050
4ee88440
MR
60512011-11-01 Martin Rudalics <rudalics@gmx.at>
6052
6053 * window.c (temp_output_buffer_show): Don't use
6054 Vtemp_buffer_show_specifiers.
6055 (Vtemp_buffer_show_specifiers): Remove unused variable.
6056
c2ff3c02
EZ
60572011-10-30 Eli Zaretskii <eliz@gnu.org>
6058
6059 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
6060 past the beginning of the current glyph matrix.
6061
58179cce 60622011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
6063
6064 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
6065 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
6066 HAVE_GTK3 (Bug#9869).
b77a6a7f 6067
3b574623
JD
6068 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
6069 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
6070
b77a6a7f
JD
6071 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
6072
6073 * xterm.c: Declare x_handle_net_wm_state to return int.
6074 (handle_one_xevent): Check if we are iconified but don't have
6075 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
6076 (get_current_wm_state): Return non-zero if not hidden,
6077 check for _NET_WM_STATE_HIDDEN (Bug#9893).
6078 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
6079 (x_handle_net_wm_state): Return what get_current_wm_state returns.
6080 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
6081
196e41e4
PE
60822011-10-29 Paul Eggert <eggert@cs.ucla.edu>
6083
6084 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
6085 so that this new function doesn't get optimized away by a
6086 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
6087
021f2e1a
AS
60882011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6089
6090 * frame.h (MOUSE_HL_INFO): Remove excess parens.
6091
8b058d44
EZ
60922011-10-29 Eli Zaretskii <eliz@gnu.org>
6093
6094 Fix the `xbytecode' command.
6095 * .gdbinit (xprintbytestr): New command.
b50a28de 6096 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
6097 (xbytecode): Print the byte-code string as well.
6098
4452fb80
EZ
60992011-10-29 Kim Storm <storm@cua.dk>
6100
8b058d44
EZ
6101 * alloc.c (which_symbols): New function.
6102
21b72067
AS
61032011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6104
6105 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
6106 line. (Bug#9903)
6107
83ed7b5c
GM
61082011-10-29 Glenn Morris <rgm@gnu.org>
6109
6110 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
6111 Not clear what it was for, and it causes various bugs. (Bug#9839)
6112
5a7a728b
EZ
61132011-10-28 Eli Zaretskii <eliz@gnu.org>
6114
6115 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
6116 possible random value that matches one of those tested as
6117 condition to clear the mouse face.
6118
d3d0842f
CY
61192011-10-28 Chong Yidong <cyd@gnu.org>
6120
6121 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
6122
31b39d13
DN
61232011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
6124
6125 * window.c (make_window): Initialize phys_cursor_on_p.
6126
9aba6043
SM
61272011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
6128
6129 * lisp.h (struct Lisp_Symbol): Update comments.
6130
c20992f4
JB
61312011-10-28 Juanma Barranquero <lekktu@gmail.com>
6132
6133 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
6134
db4f02f2
EZ
61352011-10-28 Eli Zaretskii <eliz@gnu.org>
6136
6137 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
6138 <oslsachem@gmail.com> for helping to debug this.
6139
6140 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
6141 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
6142 (g_b_init_get_glyph_outline_w): New static variables.
6143 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
6144 (GetGlyphOutlineW_Proc): New typedefs.
6145 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
6146 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
6147 New functions.
6148 (w32font_open_internal, compute_metrics):
6149 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
6150 instead of calling the "wide" APIs directly.
6151
6152 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
6153
6154 * w32.h (syms_of_w32font): Add prototype.
6155
87e68db4
JB
61562011-10-27 Juanma Barranquero <lekktu@gmail.com>
6157
6158 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
6159 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
6160 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
6161 (Fmove_to_window_line): Doc fix.
6162
435c1d67
CY
61632011-10-27 Chong Yidong <cyd@gnu.org>
6164
6165 * process.c (make_process): Set gnutls_state to NULL.
6166
6167 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
6168 non-NULL, regardless of GNUTLS_INITSTAGE.
6169 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
6170 an error. Set process slots as soon as we allocate them.
6171
6172 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
6173
9c6c6f49
CY
61742011-10-27 Chong Yidong <cyd@gnu.org>
6175
9aba6043
SM
6176 * gnutls.c (emacs_gnutls_deinit): New function.
6177 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
6178 (Fgnutls_deinit, Fgnutls_boot): Use it.
6179
6180 * process.c (make_process): Initialize GnuTLS credentials to NULL.
6181 (deactivate_process): Call emacs_gnutls_deinit.
6182
657d08d3
JB
61832011-10-27 Juanma Barranquero <lekktu@gmail.com>
6184
6185 * image.c (x_create_x_image_and_pixmap):
6186 * w32.c (sys_rename, w32_delayed_load):
6187 * w32font.c (fill_in_logfont):
6188 * w32reg.c (x_get_string_resource): Silence compiler warnings.
6189
5430d399
JB
61902011-10-26 Juanma Barranquero <lekktu@gmail.com>
6191
6192 * w32fns.c (w32_default_color_map): New function,
6193 extracted from Fw32_default_color_map.
a7ef684b 6194 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 6195
fe0055fa
PE
61962011-10-25 Paul Eggert <eggert@cs.ucla.edu>
6197
6198 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
6199
e6346438
SM
62002011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
6201
6202 * keyboard.c (test_undefined): New function (bug#9751).
6203 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
6204
e112cc37
ET
62052011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
6206
6207 * sysdep.c (init_sys_modes): Fix the check for the controlling
6208 terminal (Bug#6649).
6209
7b5d6677
EZ
62102011-10-20 Eli Zaretskii <eliz@gnu.org>
6211
6212 * dispextern.h (struct bidi_it): New member next_en_type.
6213
6214 * bidi.c (bidi_line_init): Initialize the next_en_type member.
6215 (bidi_resolve_explicit_1): When next_en_pos is valid for the
6216 current character, check also for next_en_type being WEAK_EN.
6217 (bidi_resolve_weak): Don't enter the expensive loop if the current
6218 position is before next_en_pos. Record the bidi type of the first
6219 non-ET, non-BN character we find, in addition to its position.
6220 (bidi_level_of_next_char): Invalidate next_en_type when
6221 next_en_pos is over-stepped.
6222
7da0b018
PE
62232011-10-20 Paul Eggert <eggert@cs.ucla.edu>
6224
6225 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
6226 * editfns.c: Rewrite current-time-zone so that it invokes
6227 the equivalent of (format-time-string "%Z") to get the time zone name.
6228 This fixes a bug when the time zone name contains characters that
6229 need converting from the system time locale to Emacs internal format.
6230 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
6231 that patch fixed format-time-string to do the conversion, but
6232 I forgot to fix current-time-zone.
6233 (format_time_string): New function, containing most of
6234 what Fformat_time_string used to contain.
6235 (Fformat_time_string): Rewrite in terms of format_time_string.
6236 This doesn't change this function's behavior.
6237 (current-time-zone): Rewrite to use format_time_string.
6238 This fixes the bug reported by Michael Schierl in
6239 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
6240 Jason Rumney's 2007-06-07 change worked around this bug, but
6241 didn't fix it.
6242 * systime.h (tzname, timezone): Remove no-longer-used declarations.
6243
8547b010
EZ
62442011-10-19 Eli Zaretskii <eliz@gnu.org>
6245
6246 * xdisp.c (start_display): If the character at POS is displayed
6247 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
6248 (try_window_reusing_current_matrix): If a line ends in a display
6249 vector or the next line starts in a display vector, continue
6250 redrawing the window even though the character position of
6251 start_row was reached.
8547b010
EZ
6252 (Bug#9771, part 2)
6253
4e948d15
CY
62542011-10-18 Chong Yidong <cyd@gnu.org>
6255
6256 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
6257 with nobreak-char-display too.
6258
4787455f
EZ
62592011-10-18 Eli Zaretskii <eliz@gnu.org>
6260
6261 Fix part 3 of bug#9771.
6262 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
6263 (bidi_resolve_neutral): Don't enter the expensive loop looking for
6264 non-neutral characters if the current character is a paragraph
6265 separator (a.k.a. Newline). This avoids running the same
6266 expensive loop twice, once when we consume the preceding newline
6267 and the other time when the line actually needs to be displayed.
6268 Avoid the loop when we see neutrals on the base embedding level
6269 following a character whose directionality is the same as the
6270 paragraph's. This avoids running the expensive loop when a line
6271 ends in a long sequence of neutrals, like control characters.
6272 Add assertion against STRONG_AL type. Slightly rearrange code
6273 that determines the type of a neutral given the first non-neutral
6274 that follows it.
6275 (bidi_level_of_next_char): Set next_en_pos to zero when
6276 invalidating its info.
6277
2c91f553
EZ
62782011-10-17 Eli Zaretskii <eliz@gnu.org>
6279
6280 * xdisp.c (push_display_prop): Determine whether to record string
6281 or buffer position by IT->string, not by IT->method. Allow
6282 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
6283 (move_it_vertically_backward): Don't look for character position
6284 immediately after the newline when in a continuation line.
6285 (Bug#9771, part 1)
2c91f553 6286
c7b08b0d
MR
62872011-10-15 Martin Rudalics <rudalics@gmx.at>
6288
6289 * window.c (coordinates_in_window): Rewrite and delabelize
6290 vertical border check. (Bug#5357) (Bug#9618)
6291
6b02f655
SM
62922011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
6293
6294 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
6295 errors in XSetWindowBorder (bug#9310).
6296
81d40c92
DA
62972011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
6298
6299 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
6300 avoid crash when xmalloc overrun checking is enabled.
6301
d4172c3b
EZ
63022011-10-13 Eli Zaretskii <eliz@gnu.org>
6303
6304 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
6305 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
6306 cursor motion with <left> and <right> arrow keys.
6307
6308 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
6309 some callers set that themselves.
6310
b00eea75
EZ
63112011-10-12 Eli Zaretskii <eliz@gnu.org>
6312
6313 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
6314 display string and the previous row comes from the same string and
6315 is empty. (Bug#9739) (Bug#9738)
6316
8fe012c4
SM
63172011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
6318
6319 * doc.c (get_doc_string): Encode file name (bug#9735).
6320
0074aef2
EZ
63212011-10-12 Eli Zaretskii <eliz@gnu.org>
6322
79beb178
EZ
6323 * bidi.c (bidi_level_of_next_char):
6324 * xdisp.c (get_visually_first_element): Remove old incorrect
6325 comments regarding the Unicode Line Separator character.
6326
0074aef2
EZ
6327 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
6328
6e4b3fbe
DA
63292011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
6330
6331 * alloc.c (Fgc_status): Do not access beyond zombies array
6332 boundary if nzombies > MAX_ZOMBIES.
6333 * alloc.c (dump_zombies): Add missing format specifier.
6334
0324f3af
PE
63352011-10-12 Paul Eggert <eggert@cs.ucla.edu>
6336
b5525cac
PE
6337 * xdisp.c (set_cursor_from_row): Simplify conditionals,
6338 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
6339
0324f3af
PE
6340 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
6341 Some packages use them to denote characters with modifiers.
6342
e9b5f888
AS
63432011-10-11 Andreas Schwab <schwab@linux-m68k.org>
6344
6345 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
6346 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
6347 matching a pp-number. Rename parameter var to var1.
6348
127827c0
SM
63492011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
6350
6351 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
6352
c8fd3bd0
GM
63532011-10-08 Glenn Morris <rgm@gnu.org>
6354
6355 * callint.c (Fcall_interactively): Give a more explicit error for the
6356 'c' case with a non-character input. (Bug#8479)
6357
352ec8ff
EZ
63582011-10-08 Eli Zaretskii <eliz@gnu.org>
6359
03669ccb
EZ
6360 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
6361 lines.
7061c986
EZ
6362 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
6363 lines that are hscrolled on the left.
03669ccb 6364
352ec8ff
EZ
6365 * dispnew.c (buffer_posn_from_coords): Account for a possible
6366 presence of header-line. (Bug#4426)
6367
a66cfb1c
SM
63682011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
6369
6b02f655
SM
6370 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
6371 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 6372
7c5ee88e
PE
63732011-10-07 Paul Eggert <eggert@cs.ucla.edu>
6374
6375 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
6376 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
6377 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
6378 this makes Emacs dump core during garbage collection on rare
6379 occasions. sizeof is obviously inferior to offsetof here, so
6380 stick with offsetof.
6381 (GC_POINTER_ALIGNMENT): New macro.
6382 (mark_memory): Omit 3rd (offset) arg; caller changed.
6383 Don't assume EMACS_INT alignment is the same as pointer alignment.
6384
df1bbe5b
SM
63852011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
6386
6387 * keyboard.c (read_key_sequence_remapped): New var.
6388 (read_key_sequence): Compute remapping in the right buffer.
6389 (command_loop_1): Use read_key_sequence's remapping directly.
6390
51553db6
SM
63912011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
6392
32c1fffd
SM
6393 * dired.c (file_name_completion): Don't expand file name.
6394 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
6395 before checking file name handler.
6396
51553db6
SM
6397 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
6398 they've been requested explicitly (bug#9591).
6399
b6bd1599 64002011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
6401
6402 * keymap.c (Fsingle_key_description): Use make_specified_string
6403 instead of build_string to build string from push_key_description.
6404 (Bug#5193)
6405
f701dc2a
PE
64062011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6407
4222c55d
PE
6408 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
6409 This fixes a Y2038 bug on 64-bit hosts.
6410 * buffer.c (reset_buffer):
6411 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
6412 (Fclear_buffer_auto_save_failure):
6413 Use 0, not -1, to represent an unset failure time, since time_t
6414 might not be signed.
6415
f701dc2a
PE
6416 Remove dependency on glibc malloc internals.
6417 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6418 Move back here from lisp.h, but with their new implementations.
6419 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6420 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
6421 * charset.c (charset_table_init): New static var.
6422 (syms_of_charset): Use it instead of xmalloc. This removes a
6423 dependency on glibc malloc internals. See Eli Zaretskii's comment in
6424 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
6425 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6426 Move back to alloc.c.
6427 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6428 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
6429
9ceebf39
JD
64302011-09-30 Jan Djärv <jan.h.d@swipnet.se>
6431
6432 * nsterm.m (windowDidResize): Call x_set_window_size only when
6433 ns_in_resize is true. Otherwise set pixelwidth/height and
6434 call change_frame_size (Bug#9628).
6435
cb993c58
PE
64362011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6437
3930c88b
PE
6438 Port --enable-checking=all to Fedora 14 x86-64.
6439 * charset.c (syms_of_charset): Also account for glibc malloc's
6440 internal overhead when calculating the initial malloc maximum.
6441
cb993c58
PE
6442 Port --enable-checking=all to Fedora 14 x86.
6443 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6444 Move to lisp.h.
6445 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
6446 (overrun_check_realloc, overrun_check_free):
6447 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
6448 That way, xmalloc returns a properly-aligned pointer even if
6449 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
6450 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
6451 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
6452 into account when calculating the initial malloc maximum.
6453 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6454 Move here from alloc.c, so that charset.c can use it too.
6455 Properly align; the old code wasn't right for common 32-bit hosts
6456 when configured with --enable-checking=all.
6457 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6458 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
6459
31bed486
EZ
64602011-09-29 Eli Zaretskii <eliz@gnu.org>
6461
04c70788 6462 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
6463 use EDOM.
6464
fbcaa2f3
EZ
64652011-09-28 Eli Zaretskii <eliz@gnu.org>
6466
6467 * xdisp.c (compute_display_string_end): If there's no display
6468 string at CHARPOS, return -1.
6469
6470 * bidi.c (bidi_fetch_char): When compute_display_string_end
6471 returns a negative value, treat the character as a normal
6472 character not covered by a display string. (Bug#9624)
6473
a239d4e9
JB
64742011-09-28 Juanma Barranquero <lekktu@gmail.com>
6475
6476 * lread.c (Fread_from_string): Fix typo in docstring.
6477
88652fd5
EZ
64782011-09-27 Eli Zaretskii <eliz@gnu.org>
6479
6480 * xdisp.c (handle_invisible_prop): If invisible text ends on a
6481 newline, reseat the iterator instead of bidi-iterating there one
6482 character at a time. (Bug#9610)
32c1fffd
SM
6483 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
6484 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 6485
ed497dd4
AS
64862011-09-27 Andreas Schwab <schwab@linux-m68k.org>
6487
6488 * lread.c (readevalloop): Use correct code for NBSP.
6489 (read1): Likewise. (Bug#9608)
6490
b2bf61aa
MA
64912011-09-25 Michael Albinus <michael.albinus@gmx.de>
6492
6493 * dbusbind.c (Fdbus_register_signal): When service is not
6494 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
6495
32bbb17c
GM
64962011-09-25 Glenn Morris <rgm@gnu.org>
6497
6498 * buffer.c (truncate-lines): Doc fix.
6499
94e0933e
CY
65002011-09-24 Chong Yidong <cyd@stupidchicken.com>
6501
6502 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
6503 (Fset_window_next_buffers): Doc fix.
6504
cddde921
GM
65052011-09-24 Glenn Morris <rgm@gnu.org>
6506
6507 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
6508
1260aef1
PE
65092011-09-24 Paul Eggert <eggert@cs.ucla.edu>
6510
25b4bfa0
PE
6511 Fix minor problems found by static checking.
6512 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
6513 * indent.c (Fvertical_motion): Fix == vs = typo.
6514
e3cbd34b
EZ
65152011-09-24 Eli Zaretskii <eliz@gnu.org>
6516
a66cfb1c
SM
6517 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
6518 Default value is now t. Doc fix.
6bf7006f 6519
e3cbd34b 6520 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 6521 logic when moving up, not only when moving down. Fix the
e3cbd34b 6522 confusing name and values of the it_overshoot_expected variable;
32c1fffd 6523 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
6524
6525 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
6526 CHARPOS is covered by a display string which includes newlines.
6527 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
6528 is covered by a display string with embedded newlines.
6529
a3de0cbd
MA
65302011-09-24 Michael Albinus <michael.albinus@gmx.de>
6531
6532 * dbusbind.c (Fdbus_register_signal): Add match rule to
6533 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
6534 (Fdbus_register_method, Vdbus_registered_objects_table):
6535 Fix docstring.
a3de0cbd 6536
b260039d
JM
65372011-09-24 Jim Meyering <meyering@redhat.com>
6538
32c1fffd 6539 do not ignore write error for any output size
b260039d
JM
6540 The previous change was incomplete.
6541 While it makes emacs --batch detect the vast majority of stdout
6542 write failures, errors were still ignored whenever the output size is
6543 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
6544 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
6545 && echo FAIL: ignored write error
6546 FAIL: ignored write error
6547 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
6548 && echo FAIL: ignored write error
6549 FAIL: ignored write error
6550 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
6551
8eca8a7c
AS
65522011-09-23 Andreas Schwab <schwab@linux-m68k.org>
6553
6554 * emacs.c (Fkill_emacs): In noninteractive mode exit
6555 non-successfully if a write error occurred on stdout. (Bug#9574)
6556
3341db62
EZ
65572011-09-21 Eli Zaretskii <eliz@gnu.org>
6558
6559 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
6560 the xassert test.
6561
6562 * dispextern.h (struct it): Update the comment documenting what
6563 can it->OBJECT be.
6564
8c203dbf
EZ
65652011-09-20 Eli Zaretskii <eliz@gnu.org>
6566
6567 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
6568 a display string, extend search for cursor position to end of row.
6569 (find_row_edges): If the row ends in a newline from a display
6570 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
6571 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
6572 (Fcurrent_bidi_paragraph_direction): Fix search for previous
6573 non-empty line. Fixes confusing cursor motion with arrow keys at
6574 the beginning of a line that starts with whitespace.
8c203dbf 6575
a4824228
LMI
65762011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6577
6578 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
6579 (bug#9493).
6580
33ed493b
CY
65812011-09-18 Chong Yidong <cyd@stupidchicken.com>
6582
6583 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
6584 boolean (Bug#9154).
6585
56cd55c8
EZ
65862011-09-18 Eli Zaretskii <eliz@gnu.org>
6587
6588 * xdisp.c (display_line): Record maximum and minimum buffer
6589 positions even if no glyphs were produced (e.g., by a zero-width
6590 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
6591 buffer positions that will be removed from the glyph row because
6592 they don't fit.
c02dcedf
EZ
6593 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
6594 column is beyond frame width: don't subtract 1 "pixel" when
6595 computing width of the stretch.
3e62b7e0
EZ
6596 (reseat_at_next_visible_line_start): Undo the change made on
6597 2011-09-17 that saved paragraph information and restored it after
6598 the call to `reseat'. (Bug#9545)
56cd55c8 6599
5ed99d36 66002011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
6601
6602 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
6603 and turn window cursor on if cleared (Bug#9415).
6604
5ed99d36 66052011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
6606
6607 * search.c (boyer_moore): Take unibyte characters from pattern
6608 literally. (Bug#9458)
6609
9bade7b2
EZ
66102011-09-18 Eli Zaretskii <eliz@gnu.org>
6611
6612 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
6613
e5e9d610
PE
66142011-09-18 Paul Eggert <eggert@cs.ucla.edu>
6615
87e4427a
PE
6616 Fix minor problem found by static checking.
6617 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
6618 initialized, to pacify gcc -Wuninitialized.
6619
e5e9d610
PE
6620 * fileio.c: Report proper errno when syscall falls.
6621 (Finsert_file_contents): Save and restore errno,
6622 so that report_file_error outputs the correct diagnostic.
6623 (Fwrite_region) [CLASH_DETECTION]: Likewise.
6624
a1674f0b
EZ
66252011-09-18 Eli Zaretskii <eliz@gnu.org>
6626
6627 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
6628
fbfb6dd4
EZ
66292011-09-17 Eli Zaretskii <eliz@gnu.org>
6630
6631 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
6632 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
6633
bb187662
EZ
66342011-09-17 Eli Zaretskii <eliz@gnu.org>
6635
1137e8b8 6636 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 6637 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
6638
6639 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
6640 (bidi_find_paragraph_start): Search back for paragraph beginning
6641 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
6642 (bidi_move_to_visually_next): Only trigger paragraph-related
6643 computations when the last character is a newline or at EOB, not
6644 just any NEUTRAL_B. (Bug#9470)
6645
bb187662
EZ
6646 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
6647 truncated lines if point is covered by a display string. (Bug#9524)
6648
2e621251
PE
66492011-09-16 Paul Eggert <eggert@cs.ucla.edu>
6650
6651 * xselect.c: Relax test for outgoing X longs (Bug#9498).
6652 (cons_to_x_long): New function.
6653 (lisp_data_to_selection_data): Use it. Correct the test for
6654 short-versus-long data; it was negated. Break out of vector
6655 loop, for efficiency, when a long datum is discovered.
6656
91a15bc6
SM
66572011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
6658
6659 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
6660
b41c3a35
EZ
66612011-09-16 Eli Zaretskii <eliz@gnu.org>
6662
6663 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
6664 GCC PR/17406) by declaring this function with external scope.
6665
7812ba2d
PE
66662011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6667
6668 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
6669 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
6670
cf7edc2a
AS
66712011-09-15 Andreas Schwab <schwab@linux-m68k.org>
6672
6673 * editfns.c (Fformat): Correctly handle text properties on "%%".
6674
bd01620e
EZ
66752011-09-15 Eli Zaretskii <eliz@gnu.org>
6676
6677 * xterm.c (x_draw_composite_glyph_string_foreground):
6678 * w32term.c (x_draw_composite_glyph_string_foreground):
6679 * term.c (encode_terminal_code):
6680 * composite.c (composition_update_it, get_composition_id):
6681 * xdisp.c (get_next_display_element)
6682 (fill_composite_glyph_string): Add comments about special meaning
6683 of TAB characters in a composition.
6684
a02719a3
PE
66852011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6686
6687 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
6688 This occurs when processing a multibyte format.
6689 Problem reported by Wolfgang Jenker.
a02719a3 6690
72589a3c
JB
66912011-09-15 Johan Bockgård <bojohan@gnu.org>
6692
6693 * xdisp.c (try_cursor_movement): Only check for exact match if
6694 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
6695
1c14176c
PE
66962011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6697
6698 Remove unused external symbols.
6699 * dispextern.h (calc_pixel_width_or_height): Remove decl.
6700 * xdisp.c (calc_pixel_width_or_height): Now static.
6701 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
6702 * indent.c (check_display_width):
6703 * w32term.c: Fix comment to match code.
6704 * xterm.c, xterm.h (x_catching_errors): Remove.
6705
d2eea5b5
PE
67062011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6707
6708 * xselect.c: Use signed conversions more consistently (Bug#9498).
6709 (selection_data_to_lisp_data): Assume incoming selection data are
6710 signed integers, not unsigned. This is to be consistent with
6711 outgoing selection data, which was modified to use signed integers
6712 in as part of the fix to Bug#9196 in response to Jan D.'s comment
6713 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
6714 expects long, not unsigned long.
6715
46888499
EZ
67162011-09-14 Eli Zaretskii <eliz@gnu.org>
6717
6718 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
6719 computation of loop end. Reported by Johan Bockgård
6720 <bojohan@gnu.org>.
6721
ef8ef9fb
CY
67222011-09-13 Chong Yidong <cyd@stupidchicken.com>
6723
6724 * frame.c (Fother_visible_frames_p): Function deleted.
6725
fa819fed
EZ
67262011-09-12 Eli Zaretskii <eliz@gnu.org>
6727
6728 * indent.c (compute_motion): Process display vector front to back
6729 rather than the other way around. (Bug#2496)
6730
2ba8e008
SM
67312011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
6732
6733 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
6734
20f53c69
CY
67352011-09-11 Chong Yidong <cyd@stupidchicken.com>
6736
6737 * minibuf.c (Fread_from_minibuffer): Doc fix.
6738
d562d7a4
EZ
67392011-09-11 Eli Zaretskii <eliz@gnu.org>
6740
6741 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
6742 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
6743
1c4d7f3d
LMI
67442011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6745
6746 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
6747 value for non-existent files.
6748
b885bf36
EZ
67492011-09-11 Eli Zaretskii <eliz@gnu.org>
6750
6751 * fileio.c (Finsert_file_contents): If the file cannot be opened,
6752 set its "size" to -1. This will set the modtime_size field of
6753 the corresponding buffer to -1, which is what
6754 verify-visited-file-modtime expects for files that do not exist.
6755 (Bug#9139)
6756
6612f0bf
PE
67572011-09-11 Paul Eggert <eggert@cs.ucla.edu>
6758
6759 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
6760 here ...
6761 * lisp.h: ... from here. push_key_description is no longer
6762 defined in keyboard.c, so its declaration should not be in
6763 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
6764 logically belongs with push_key_description.
6765
dfb3f755
PE
67662011-09-10 Paul Eggert <eggert@cs.ucla.edu>
6767
6768 * buffer.h: Include <sys/types.h> instead of <time.h>.
6769 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
6770 Problem reported by Herbert J. Skuhra.
6771
3134906c
LMI
67722011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
6773
6774 * xml.c (parse_region): Make the parsing work for
6775 non-comment-starting XML files again (bug#9144).
6776
8d903f4e
AS
67772011-09-10 Andreas Schwab <schwab@linux-m68k.org>
6778
6779 * image.c (gif_load): Fix calculation of bottom and right corner.
6780 (Bug#9468)
6781
80ad64f4
EZ
67822011-09-10 Eli Zaretskii <eliz@gnu.org>
6783
6784 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
6785 redisplay in small windows.
6786
208a048d
EZ
67872011-09-09 Eli Zaretskii <eliz@gnu.org>
6788
6789 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
6790
9b1c252e
MR
67912011-09-08 Martin Rudalics <rudalics@gmx.at>
6792
6793 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
6794 Operate on live windows only.
6795
2949f33b
JB
67962011-09-08 Juanma Barranquero <lekktu@gmail.com>
6797
6798 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
6799
e08dcafd
EZ
68002011-09-07 Eli Zaretskii <eliz@gnu.org>
6801
6802 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
6803 only under bidi iteration.
6804
115b96bd
JD
68052011-09-07 Jan Djärv <jan.h.d@swipnet.se>
6806
6807 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
6808
c8199d0f
PE
68092011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6810
6811 isnan: Fix porting problem to Solaris 10 with bundled gcc.
6812 Without this fix, the command to link temacs failed due to an
6813 undefined symbol __builtin_isnan. This is because
6814 /usr/include/iso/math_c99.h #defines isnan(x) to
6815 __builtin_isnan(x), but the bundled gcc, which identifies itself
6816 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
6817 a __builtin_isnan.
6818 * floatfns.c (isnan): #undef, and then #define to a clone of
6819 what's in data.c.
6820 (Fisnan): Always define, since it's always available now.
6821 (syms_of_floatfns): Always define isnan at the Lisp level.
6822
e39b275c 68232011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
6824
6825 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
6826
b2db44d9 68272011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 6828
f4af5137 6829 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
6830 The previous code assumed that file offsets (off_t values) fit in
6831 EMACS_INT variables, which is not true on typical 32-bit hosts.
6832 The code messed up by falsely reporting buffer overflow in cases
6833 such as (insert-file-contents "big" nil 1 2) into an empty buffer
6834 when "big" contains more than 2**29 bytes, even though this
6835 inserts just one byte and does not overflow the buffer.
6836 (Finsert_file_contents): Store file offsets as off_t
6837 values, not as EMACS_INT values. Check for overflow when
6838 converting between EMACS_INT and off_t. When checking for
6839 buffer overflow or for overlap, take the offsets into account.
6840 Don't use EMACS_INT for small values where int suffices.
6841 When checking for overlap, fix a typo: ZV was used where
6842 ZV_BYTE was intended.
6843 (Fwrite_region): Don't assume off_t fits into 'long'.
6844 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
6845
ecfc0a49
MA
68462011-09-05 Michael Albinus <michael.albinus@gmx.de>
6847
6848 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
6849
6511acf2 68502011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 6851
0999621a 6852 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
6853
6854 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 6855 (esprintf, exprintf, evxprintf): New functions.
62f19c19 6856 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 6857 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
6858 (modify_event_symbol): Do not assume that the length of
6859 name_alist_or_stem is safe to alloca and fits in int.
6860 (Fexecute_extended_command): Likewise for function name and binding.
6861 (Frecursion_depth): Wrap around reliably on integer overflow.
6862 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
6863 since some callers pass EMACS_INT values.
6864 (Fsingle_key_description): Don't crash if symbol name contains more
6865 than MAX_ALLOCA bytes.
6866 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
6867 (get_minibuffer): Arg is now EMACS_INT, not int.
6868 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 6869 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
6870 * window.h (command_loop_level, minibuf_level): Reflect API changes.
6871
2be7d702
PE
6872 * dbusbind.c (signature_cat): New function.
6873 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
6874 Do not overrun buffer; instead, report string overflow.
6875
9d1df220
PE
6876 * dispnew.c (add_window_display_history): Don't overrun buffer.
6877 Truncate instead; this is OK since it's just a log.
6878
33ef5c64
PE
6879 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
6880 even if the time zone offset is outlandishly large.
6881 Don't mishandle offset == INT_MIN.
6882
66c6fdd5
PE
6883 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
6884 when creating daemon; the previous buffer-overflow check was incorrect.
6885
d749b01b
PE
6886 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
6887 which has the guts of the old verror function.
6888
b5cd1905
PE
6889 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
6890 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
6891
6e1a67fb
PE
6892 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
6893 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 6894 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 6895 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
6896 length of string rather than counting it via multiple sprintfs;
6897 that's simpler and more reliable.
c21721cc
PE
6898 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
6899 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
6900 sprintf, in case result does not fit in int.
6901
c57b67fc
PE
6902 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
6903 (fontset_from_font): Print it.
6904
8a401434
PE
6905 * frame.c (tty_frame_count): Now printmax_t, not int.
6906 (make_terminal_frame, set_term_frame_name): Print it.
6907 (x_report_frame_params): In X, window IDs are unsigned long,
6908 not signed long, so print them as unsigned.
6909 (validate_x_resource_name): Check for implausibly long names,
6910 and don't assume name length fits in 'int'.
6911 (x_get_resource_string): Don't blindly alloca invocation name;
6912 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
6913 not fit in int.
6914
6e1a67fb
PE
6915 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
6916 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
6917 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
6918
0df02bf3
PE
6919 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
6920 Use esprintf, not sprintf, in case result does not fit in int.
6921
48e30793
PE
6922 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6923 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
6924 it as a large positive number.
6925 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
6926 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6927
a66ff6d8
PE
6928 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
6929 in case result does not fit in int.
6930
aca216ff
PE
6931 * print.c (float_to_string): Detect width overflow more reliably.
6932 (print_object): Make sprintf buffer a bit bigger, to avoid potential
6933 buffer overrun. Don't assume list length fits in 'int'. Treat
6934 print length of 0 as 0, not as infinity; to be consistent with other
6935 uses of print length in this function. Don't overflow print length
6936 index. Don't assume hash table size fits in 'long', or that
6937 vectorlike size fits in 'unsigned long'.
6938
31c286f7
PE
6939 * process.c (make_process): Use printmax_t, not int, to format
6940 process-name gensyms.
6941
55e5faa1
PE
6942 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
6943
80f2e268
PE
6944 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
6945 to avoid potential buffer overrun.
6946
670741ab
PE
6947 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
6948 if X resource line is longer than 512 bytes.
6949
b7163a50
PE
6950 * xfns.c (x_window): Make sprintf buffer a bit bigger
6951 to avoid potential buffer overrun.
6952
ae58ff1f
PE
6953 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
6954
c43c8a6a
PE
6955 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
6956
3f8236f4
PE
69572011-09-04 Paul Eggert <eggert@cs.ucla.edu>
6958
53e9fe90 6959 Integer overflow fixes for scrolling, etc.
6511acf2
PE
6960 Without these, Emacs silently mishandles large integers sometimes.
6961 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
6962 it were "C-u 1 M-x recenter" on a typical 64-bit host.
6963
6511acf2
PE
6964 * xdisp.c (try_window_id): Check Emacs fixnum range before
6965 converting to 'int'.
806add1d 6966
6511acf2 6967 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
6968 Check that an Emacs fixnum is in range before assigning it to 'int'.
6969 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
6970 values converted from Emacs fixnums.
6971 (Frecenter): Don't wrap around a line count if it is out of 'int'
6972 range; instead, treat it as an extreme value.
6973 (Fset_window_configuration, compare_window_configurations):
6974 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
6975
6511acf2
PE
6976 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
6977 that can exceed INT_MAX. Check that EMACS_INT value is in range
6978 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
6979 (match_limit): Don't assume that a fixnum can fit in 'int'.
6980
6511acf2 6981 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
6982 exceed INT_MAX.
6983
6511acf2 6984 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
6985 (Fvertical_motion): Don't wrap around LINES values that don't fit
6986 in 'int'. Instead, treat them as extreme values. This is good
6987 enough for windows, which can't have more than INT_MAX lines anyway.
6988
fcb901a7
LMI
69892011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6990
0f2f6b6d
LMI
6991 * Require libxml/parser.h to avoid compilation warning.
6992
fcb901a7
LMI
6993 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
6994
6995 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
6996 since this reportedly can destroy thread storage.
6997
6e20a0d4
CY
69982011-08-30 Chong Yidong <cyd@stupidchicken.com>
6999
7000 * syntax.c (find_defun_start): Update all cache variables if
7001 exiting early (Bug#9401).
7002
148ae00e
EZ
70032011-08-30 Eli Zaretskii <eliz@gnu.org>
7004
f6cfbd8f
EZ
7005 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
7006
148ae00e
EZ
7007 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
7008 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
7009 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
7010
7011 * term.c (tty_append_glyph): New function.
7012 (produce_stretch_glyph): Static function and its prototype deleted.
7013
a66cfb1c
SM
7014 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
7015 Add prototypes.
148ae00e 7016
c4a07a4c
PE
70172011-08-29 Paul Eggert <eggert@cs.ucla.edu>
7018
7019 * image.c (parse_image_spec): Check for nonnegative, not for positive,
7020 when checking :margin (Bug#9390).
7021 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 7022 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
7023 so that the name doesn't mislead. All uses changed.
7024
6bc8cd65
JB
70252011-08-28 Johan Bockgård <bojohan@gnu.org>
7026
7027 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
7028 set_tty_hooks.
7029
dca4927e
EZ
70302011-08-27 Eli Zaretskii <eliz@gnu.org>
7031
7032 * xdisp.c (move_it_to): Don't bail out early when reaching
7033 position beyond to_charpos, if we are scanning backwards.
7034 (move_it_vertically_backward): When DY == 0, make sure we get to
7035 the first character in the line after the newline.
7036
f2cad773
PE
70372011-08-27 Paul Eggert <eggert@cs.ucla.edu>
7038
7039 * ccl.c: Improve and simplify overflow checking (Bug#9196).
7040 (ccl_driver): Do not generate an out-of-range pointer.
7041 (Fccl_execute_on_string): Remove unnecessary check for
7042 integer overflow, noted by Stefan Monnier in
7043 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
7044 Remove a FIXME that didn't need fixing.
7045 Simplify the newly-introduced buffer reallocation code.
7046
0cae2cdb
JB
70472011-08-27 Juanma Barranquero <lekktu@gmail.com>
7048
7049 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
7050
5fc295a4 70512011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 7052
70c60eb2 7053 Integer and memory overflow issues (Bug#9196).
726e0ab1 7054
d31850da
PE
7055 * doc.c (get_doc_string): Rework so that
7056 get_doc_string_buffer_size is the actual buffer size, rather than
7057 being 1 less than the actual buffer size; this makes xpalloc more
7058 convenient.
7059
a69fbedb
PE
7060 * image.c (x_allocate_bitmap_record, cache_image):
7061 * xselect.c (Fx_register_dnd_atom):
7062 Simplify previous changes by using xpalloc.
7063
fe5c5d37
PE
7064 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
7065 since either will do and ptrdiff_t is convenient with xpalloc.
7066
0065d054
PE
7067 * charset.c (charset_table_size)
7068 (struct charset_sort_data.priority): Now ptrdiff_t.
7069 (charset_compare): Don't overflow if priorities differ greatly.
7070 (Fsort_charsets): Don't assume list length fits in int.
7071 Check for size-calculation overflow when allocating sort data.
7072 (syms_of_charset): Allocate an initial charset table that is
7073 just under 64 KiB, to avoid problems with glibc malloc and mmap.
7074
7075 * cmds.c (internal_self_insert): Check for size-calculation overflow.
7076
7077 * composite.h (struct composition.glyph_len): Now int, not unsigned.
7078 The actual value is always <= INT_MAX, and leaving it unsigned made
7079 overflow checking harder.
7080
7081 * dispextern.h (struct glyph_matrix.rows_allocated)
7082 (struct face_cache.size): Now ptrdiff_t, for convenience in use
7083 with xpalloc. The values are still always <= INT_MAX.
7084
7085 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
7086
7087 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
7088 (SAFE_NALLOCA): New macro.
7089
7090 * region-cache.c (struct boundary.pos, find_cache_boundary)
7091 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
7092 (set_cache_region, invalidate_region_cache)
7093 (revalidate_region_cache, know_region_cache, region_cache_forward)
7094 (region_cache_backward, pp_cache):
7095 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
7096 so that ptrdiff_t * can be passed to xpalloc.
7097 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
7098 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
7099 (pp_cache): Don't assume cache_len fits in int.
7100 * region-cache.h: Adjust extern decls to match.
7101
7102 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
7103 EMACS_INT, since either will do, for xpalloc.
7104
7105 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
7106 (xnmalloc, xnrealloc, xpalloc): New functions.
7107
726e0ab1
PE
7108 * bidi.c (bidi_shelve_header_size): New constant.
7109 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
7110 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
7111
51f30bc5 7112 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
7113 * buffer.c (overlays_at, overlays_in, record_overlay_string)
7114 (overlay_strings):
7115 Don't update size of array until after memory allocation succeeds,
7116 because xmalloc/xrealloc may not return.
0065d054
PE
7117 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
7118 now that we have proper integer overflow checking.
7119 (record_overlay_string, overlay_strings): Catch overflows when
7120 calculating size of overlay_str_buf.
726e0ab1 7121
0065d054
PE
7122 * callproc.c (Fcall_process): Check for size overflow when
7123 calculating size of args2.
7124 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
7125 Normally we prefer signed values, but sticking with ptrdiff_t would
7126 require adding more-complicated checks.
726e0ab1
PE
7127
7128 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
7129 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
7130 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 7131 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
7132
7133 * character.c (Fstring): Check for size-calculation overflow.
7134
7135 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
7136 unnecessary integer overflow. Check for size overflow.
7137 (encode_coding_object): Don't update size until xmalloc succeeds.
7138
7139 * composite.c (get_composition_id): Check for overflow in glyph
7140 length calculations.
7141
7142 Integer and memory overflow fixes for display code.
7143 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
7144 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
7145 (scrolling_window): Check for overflow in size calculations.
7146 (line_draw_cost, realloc_glyph_pool, add_row_entry):
7147 Don't assume glyph table len fits in int.
7148 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
7149 (row_table_size): Now ptrdiff_t, not int.
7150 (scrolling_window): Avoid overflow in size calculations.
7151 Don't update size until allocation succeeds.
7152 * fns.c (concat): Check for overflow in size calculations.
7153 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
7154 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7155 (NEXT_ALMOST_PRIME_LIMIT): New constant.
7156
7157 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
7158 (get_doc_string): Check for size calculation overflow.
7159 Don't update size until allocation succeeds.
7160 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
7161 EMACS_INT, where ptrdiff_t will do.
7162 (Fsubstitute_command_keys): Check for string overflow.
7163
7164 * editfns.c (set_time_zone_rule): Don't assume environment length
7165 fits in int.
7166 (message_length): Now ptrdiff_t, not int.
7167 (Fmessage_box): Don't update size until allocation succeeds.
7168 Don't assume message length fits in int.
7169 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
7170
0065d054
PE
7171 * emacs.c (main): Do not reallocate argv, since there is a null at
7172 the end that can be overwritten, and this way there's no need to
7173 worry about size-calculation overflow.
7174 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
7175
7176 * eval.c (init_eval_once, grow_specpdl): Don't update size until
7177 alloc succeeds.
7178 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
7179
7180 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
7181 (x_set_scroll_bar_width, x_figure_window_size):
7182 Check for integer overflow.
7183 (x_set_alpha): Do not assume XINT fits in int.
7184
7185 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
7186 This is for the members text_lines, text_cols, total_lines, total_cols,
7187 where the system imposes an 'int' limit.
7188
7189 * fringe.c (Fdefine_fringe_bitmap):
7190 Don't update size until alloc works.
7191
7192 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
7193 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
7194
7195 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
7196 Check for size-calculation overflow.
7197 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
7198 do, as we prefer signed integers.
7199 (id_to_widget.max_size, id_to_widget.used)
7200 (xg_store_widget_in_map, xg_remove_widget_from_map)
7201 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
7202 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
7203 Use and return ptrdiff_t, not int.
7204 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
7205 * gtkutil.h: Change prototypes to match the above.
7206
7207 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
7208 are duplicate now that they've been promoted to lisp.h.
7209 (x_allocate_bitmap_record, x_alloc_image_color)
7210 (make_image_cache, cache_image, xpm_load):
7211 Don't update size until alloc is done.
7212 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
7213 (x_detect_edges):
3256efce 7214 Check for size calculation overflow.
726e0ab1
PE
7215 (ct_colors_allocated_max): New constant.
7216 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
7217 overflow.
3256efce 7218
726e0ab1
PE
7219 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
7220 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
7221 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
7222 Use ptrdiff_t, not int, to count maps.
7223 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
7224 calculations. Don't update size until allocation succeeds.
7225 Redo calculations to avoid overflow.
726e0ab1
PE
7226 * keyboard.h: Change prototypes to match the above.
7227
7228 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
7229 to count maps.
7230 (current_minor_maps): Check for size calculation overflow.
7231 * keymap.h: Change prototypes to match the above.
7232
7233 * lread.c (read1, init_obarray): Don't update size until alloc done.
7234
7235 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
7236 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
7237
726e0ab1
PE
7238 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
7239 Now ptrdiff_t, not int.
7240 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
7241 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
7242
7243 * process.c (Fnetwork_interface_list): Check for overflow
7244 in size calculation.
7245
7246 * region-cache.c (move_cache_gap): Check for size calculation overflow.
7247
7248 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
7249 overflow. Don't bother calling xmalloc when xrealloc will do.
7250
7251 * search.c (Freplace_match): Check for size calculation overflow.
7252 (Fset_match_data): Don't assume list lengths fit in 'int'.
7253
7254 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
7255 for command line length. Do not attempt to address one before the
7256 beginning of an array, as that's not portable.
7257
7258 * term.c (max_frame_lines): Remove; unused.
7259 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
7260 not int.
7261 (encode_terminal_code, calculate_costs): Check for size
7262 calculation overflow.
7263 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
7264 table lengths and related sizes. Don't update size until alloc
7265 done. Redo calculations to avoid overflow.
7266 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
7267
7268 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
7269 subtracting pointers.
7270 (gobble_line): Check for overflow more carefully. Don't update size
7271 until alloc done.
7272
7273 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
7274 Don't update size until alloc done.
7275 Redo size calculations to avoid overflow.
7276 Check for size calculation overflow.
0065d054 7277 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
7278
7279 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
7280 Use ptrdiff_t, not int, for sizes.
7281 (store_mode_line_noprop_char): Don't update size until alloc done.
7282
0065d054
PE
7283 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
7284 Use ptrdiff_t, not int, for sizes.
7285 (Finternal_make_lisp_face, cache_face):
7286 Check for size calculation overflow.
7287 (cache_face): Treat size calculation overflows as if they were
7288 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
7289
7290 * xfns.c (x_encode_text, x_set_name_internal)
7291 (Fx_change_window_property): Use ptrdiff_t, not int, to count
7292 sizes, since they can exceed INT_MAX in size. Check for size
7293 calculation overflow.
7294
0065d054
PE
7295 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
7296 (xg_select): Check for size calculation overflow.
726e0ab1
PE
7297 Don't update size until alloc done.
7298
0065d054 7299 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 7300 as sprintf is limited to int lengths.
1d526e2f 7301
252c5ee1
PE
7302 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
7303 (X_LONG_MIN): New macros.
864d7ce7
PE
7304 Use them to make the following changes clearer.
7305 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
7306 This change doesn't affect the value now, but it may help remind
7307 future maintainers not to raise the value too much later.
7308 (SELECTION_QUANTUM): Remove, replacing with ...
7309 (selection_quantum): ... new function, which avoids overflow.
7310 All uses changed.
7311 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
7312 assumption that selection length fits in 'int'.
7313 (x_reply_selection_request, x_handle_selection_request)
7314 (x_get_window_property, receive_incremental_selection)
7315 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
7316 (lisp_data_to_selection_data, clean_local_selection_data):
7317 Use ptrdiff_t, not int, to record length of selection.
7318 (x_reply_selection_request, x_get_window_property)
7319 (receive_incremental_selection, x_property_data_to_lisp):
7320 Redo calculations to avoid overflow.
7321 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 7322 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
7323 something.
7324 (x_get_window_property, receive_incremental_selection)
7325 (lisp_data_to_selection_data, x_property_data_to_lisp):
7326 Check for size-calculation overflow.
7327 (x_get_window_property, receive_incremental_selection)
7328 (lisp_data_to_selection_data, Fx_register_dnd_atom):
7329 Don't store size until memory allocation succeeds.
7330 (x_get_window_property): Plug memory leak on memory exhaustion.
7331 Don't double-block input; malloc is safe here. Don't assume 2**34
7332 - 4 fits in unsigned long. Add an xassert to check
7333 XGetWindowProperty overflow. Be more careful about overflow
7334 calculations, and distinguish size from memory overflow better.
7335 (receive_incremental_selection): When tracing, don't assume
7336 unsigned int is less than INT_MAX.
7337 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
7338 harmful) conversions of unsigned short to int.
7339 (lisp_data_to_selection_data): Don't assume that integers
7340 in the range -65535 through -1 fit in an X unsigned short.
7341 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
7342 result parameters unless successful. Rely on cons_to_unsigned
7343 to report problems with elements; the old code wasn't right anyway.
7344 (x_check_property_data): Check for int overflow; we cannot use
7345 a wider type due to X limits.
7346 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
7347
726e0ab1 7348 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 7349
0065d054
PE
7350 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
7351 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
7352 (x_color_cells): Don't store size until memory allocation succeeds.
7353 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 7354 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
7355 (x_term_init): Don't assume length fits in int (sprintf is limited
7356 to int size).
bc18e09d 7357
ebfa62c0
PE
7358 Use ptrdiff_t for composition IDs.
7359 * character.c (lisp_string_width):
7360 * composite.c (composition_table_size, n_compositions)
7361 (get_composition_id, composition_gstring_from_id):
7362 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
7363 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
7364 * window.c (Frecenter):
7365 Use ptrdiff_t, not int, for composition IDs.
7366 * composite.c (get_composition_id): Check for integer overflow.
7367 * composite.h: Adjust prototypes to match the above changes.
7368
d3411f89
PE
7369 Use ptrdiff_t for hash table indexes.
7370 * category.c (hash_get_category_set):
7371 * ccl.c (ccl_driver):
7372 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
7373 * coding.c (coding_system_charset_list, detect_coding_system):
7374 * coding.h (struct coding_system.id):
7375 * composite.c (get_composition_id, gstring_lookup_cache):
7376 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
7377 * image.c (xpm_get_color_table_h):
7378 * lisp.h (hash_lookup, hash_put):
7379 * minibuf.c (Ftest_completion):
7380 Use ptrdiff_t for hash table indexes, not int (which is too
7381 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
7382 32-bit --with-wide-int hosts).
7383
e097a6fa
PE
7384 * charset.c (Fdefine_charset_internal): Check for integer overflow.
7385 Add a FIXME comment about memory leaks.
7386 (syms_of_charset): Don't assume xmalloc returns.
7387
5637687f
PE
7388 Don't assume that stated character widths fit in int.
7389 * character.c (Fchar_width, c_string_width, lisp_string_width):
7390 * character.h (CHAR_WIDTH):
7391 * indent.c (MULTIBYTE_BYTES_WIDTH):
7392 Use sanitize_char_width to avoid undefined and/or bad behavior
7393 with outlandish widths.
a66cfb1c 7394 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
7395 now that we have two such functions. All uses changed.
7396 (sanitize_char_width): New inline function.
7397
a2271ba2
PE
7398 Don't assume that tab-width fits in int.
7399 * character.h (sanitize_width): New inline function.
7400 (SANE_TAB_WIDTH): New macro.
7401 (ASCII_CHAR_WIDTH): Use it.
7402 * indent.c (sane_tab_width): Remove. All uses replaced by
7403 SANE_TAB_WIDTH (current_buffer).
7404 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
7405
18c52557
PE
7406 * fileio.c: Integer overflow issues with file modes.
7407 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
7408
caeeedc1
PE
7409 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
7410 Remove unreachable code.
7411 (read_hex, load_charset_map_from_file): Check for integer overflow.
7412
6df6ae42 7413 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
7414 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
7415 (x_send_scroll_bar_event): Likewise. Check that the size does not
7416 exceed limits imposed by XClientMessageEvent, as well as the usual
7417 ptrdiff_t and size_t limits.
7418
b13995db
PE
7419 * keyboard.c: Overflow, signedness and related fixes.
7420 (make_lispy_movement): Use same integer type in forward decl
7421 that is used in the definition.
7422 (read_key_sequence, keyremap_step):
7423 Change bufsize argument back to int, undoing my 2011-03-30 change.
7424 We prefer signed types, and int is wide enough here.
7425 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
7426 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
7427 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
7428 length, not size_t. Use ptrdiff_t for index, not int.
7429 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
7430 possibility of integer overflow.
7431
13464394
PE
7432 Overflow, signedness and related fixes for images.
7433
7434 * dispextern.h (struct it.stack[0].u.image.image_id)
7435 (struct_it.image_id, struct image.id, struct image_cache.size)
7436 (struct image_cache.used, struct image_cache.ref_count):
7437 * gtkutil.c (update_frame_tool_bar):
7438 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
7439 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
7440 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
7441 * nsmenu.m (update_frame_tool_bar):
7442 * xdisp.c (calc_pixel_width_or_height):
7443 * xfns.c (image_cache_refcount):
7444 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
7445 on typical 64-bit hosts.
7446
7447 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7448 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
7449 Omit unnecessary casts to int.
7450 (parse_image_spec): Check that integers fall into 'int' range
7451 when the callers expect that.
7452 (image_ascent): Redo ascent calculation to avoid int overflow.
7453 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
7454 (lookup_image): Remove unnecessary tests.
7455 (xbm_image_p): Locals are now of int, not EMACS_INT,
7456 since parse_image_check makes sure they fit into int.
7457 (png_load, gif_load, svg_load_image):
7458 Prefer int to unsigned where either will do.
7459 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
7460 old tiff_error_handler and tiff_warning_handler.
7461 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
7462 stack buffer overflows. It uses only the features of vsnprintf
7463 that are common to both POSIX and native Microsoft.
7464 (tiff_error_handler, tiff_warning_handler): Use it.
7465 (tiff_load, gif_load, imagemagick_load_image):
7466 Don't assume :index value fits in 'int'.
7467 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
7468 (imagemagick_load_image): Check that crop parameters fit into
7469 the integer types that MagickCropImage accepts. Don't assume
7470 Vimagemagick_render_type has a nonnegative value. Don't assume
7471 size_t fits in 'long'.
7472 (gs_load): Use printmax_t to print the widest integers possible.
7473 Check for integer overflow when computing image height and width.
7474
c11821d4
EZ
74752011-08-26 Eli Zaretskii <eliz@gnu.org>
7476
7477 * xdisp.c (redisplay_window): Don't force window start if point
7478 will be invisible in the resulting window. (Bug#9324)
7479
0c95fcf7
EZ
74802011-08-25 Eli Zaretskii <eliz@gnu.org>
7481
7482 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
7483 the display spec is of the form `(space ...)'.
7484 (handle_display_spec): Return the value returned by
7485 handle_single_display_spec, not just 1 or zero.
7486 (handle_single_display_spec): If the display spec is of the form
7487 `(space ...)', and specifies display in the text area, return 2
7488 rather than 1.
fee65a97 7489 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
7490 accurately, and prefer exact match for point under bidi.
7491 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
7492
7493 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
7494 into disp_prop; all users changed.
7495
7496 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
7497 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
7498 for the text covered by the display property.
7499
e4ed06f1
CY
75002011-08-25 Chong Yidong <cyd@stupidchicken.com>
7501
7502 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
7503 Change return value to nil.
7504 (Frecord_buffer): Delete unused function.
7505
f67cdd7f
EZ
75062011-08-24 Eli Zaretskii <eliz@gnu.org>
7507
5980d4c6
EZ
7508 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
7509 buffers, return left-to-right.
8610fe8b
EZ
7510 (set_cursor_from_row): Consider candidate row a win if its glyph
7511 represents a newline and point is on that newline. Fixes cursor
7512 positioning on the newline at EOL of R2L text within L2R
7513 paragraph, and vice versa.
7514 (try_cursor_movement): Check continued rows, in addition to
7515 continuation rows. Fixes unwarranted scroll when point enters a
7516 continued line of R2L text within an L2R paragraph, or vice versa.
7517 (cursor_row_p): Consider the case of point being equal to
7518 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
7519 from the end of a short line to the beginning of a continued line
7520 of R2L text within L2R paragraph.
7521 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
7522 composed characters.
5980d4c6 7523
f67cdd7f
EZ
7524 * bidi.c (bidi_check_type): Use xassert.
7525 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
7526 members.
7527
bca633fb
EZ
75282011-08-23 Eli Zaretskii <eliz@gnu.org>
7529
7530 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
7531 a character.
7532
4a5885a7
CY
75332011-08-23 Chong Yidong <cyd@stupidchicken.com>
7534
7535 * nsfont.m (ns_otf_to_script): Fix typo.
7536
0902a04e
KH
75372011-08-22 Kenichi Handa <handa@m17n.org>
7538
7539 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
7540 extra slot even if the purpose is char-code-property-table.
7541
1a2e6670
EZ
75422011-08-23 Eli Zaretskii <eliz@gnu.org>
7543
8ddde651
EZ
7544 * xdisp.c (redisplay_window): When computing centering_position,
7545 account for the height of the header line. (Bug#8874)
7546
425cc014
EZ
7547 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
7548 instead of CHAR_TO_BYTE. Fixes a crash when a completion
7549 candidate is selected by the mouse, and that candidate has a
7550 composed character under the mouse.
7551
1a2e6670
EZ
7552 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
7553 coordinates reported by pos-visible-in-window-p for a composed
7554 character in column zero.
7555
8b76d6f8
SM
75562011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
7557
7558 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
7559
dac347dd
EZ
75602011-08-22 Eli Zaretskii <eliz@gnu.org>
7561
7562 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
7563 consider it a hit if to_charpos is anywhere in the range of the
7564 composed buffer positions.
7565
e013fb34
CY
75662011-08-22 Chong Yidong <cyd@stupidchicken.com>
7567
7568 * image.c (gif_load): Don't assume that each subimage has the same
7569 dimensions as the base image. Handle disposal method that is
7570 "undefined" by the gif spec (Bug#9335).
7571
bd1ba3e8
CY
75722011-08-20 Chong Yidong <cyd@stupidchicken.com>
7573
7574 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 7575 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 7576
54a1215b
EZ
75772011-08-19 Eli Zaretskii <eliz@gnu.org>
7578
823564e5
EZ
7579 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
7580 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
7581 from an Org mode buffer to a Speedbar frame.
7582
54a1215b
EZ
7583 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
7584 a composition, take its buffer position from IT->cmp_it.charpos.
7585 Fixes cursor positioning at the beginning of a line that begins
7586 with a composed character.
7587
9778ebcc
EZ
75882011-08-18 Eli Zaretskii <eliz@gnu.org>
7589
0be6ee06
EZ
7590 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
7591 character bidirectional type, use STRONG_L instead. Fixes crashes
7592 in a buffer produced by `describe-categories'.
7593
9778ebcc
EZ
7594 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
7595 members before the level stack, so they would be saved and
7596 restored when copying iterator state. Fixes incorrect reordering
7597 around TABs covered by display properties.
7598
156bffbe
AS
75992011-08-18 Andreas Schwab <schwab@linux-m68k.org>
7600
6b02f655 7601 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 7602
72ad093b
CY
76032011-08-17 Chong Yidong <cyd@stupidchicken.com>
7604
7605 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
7606 (internal_condition_case_2, internal_condition_case_n):
7607 Remove unnecessary aborts (Bug#9081).
72ad093b 7608
35774242
EZ
76092011-08-17 Eli Zaretskii <eliz@gnu.org>
7610
7611 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
7612 has no `load' handler, try opening the file locally. (Bug#9311)
7613
db76dd85
KB
76142011-08-16 Ken Brown <kbrown@cornell.edu>
7615
7616 * gmalloc.c: Expand comment.
7617
b215eee5
EZ
76182011-08-16 Eli Zaretskii <eliz@gnu.org>
7619
7620 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
7621 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
7622
a4579d33
KB
76232011-08-16 Ken Brown <kbrown@cornell.edu>
7624
7625 Fix memory allocation problems in Cygwin build (Bug#9273).
7626
7627 * unexcw.c ( __malloc_initialized): Declare external variable.
7628 (fixup_executable): Force the dumped emacs to reinitialize malloc.
7629
8b76d6f8
SM
7630 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
7631 New variables.
a4579d33
KB
7632 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
7633 dumped emacs.
7634 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
7635 in the static heap.
7636 [CYGWIN] (special_realloc): New function.
7637 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
7638 requests to realloc storage in the static heap.
7639
3ebec551
PE
76402011-08-15 Paul Eggert <eggert@cs.ucla.edu>
7641
7642 * bidi.c (bidi_initialize): Remove unused local.
7643
9fd8be00
EZ
76442011-08-15 Eli Zaretskii <eliz@gnu.org>
7645
6b02f655
SM
7646 * bidimirror.h:
7647 * biditype.h: Remove file.
7648 * makefile.w32-in ($(BLD)/bidi.$(O)):
7649 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
7650
7651 * dispextern.h: Fix a typo in the comment to bidi_type_t.
7652
7653 * chartab.c: Improve commentary for the uniprop_table API.
7654
32413314
EZ
7655 * bidi.c (bidi_paragraph_init): Support zero value of
7656 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
7657 (bidi_initialize): Use uniprop_table instead of including
7658 biditype.h and bidimirror.h.
32413314 7659
9fd8be00
EZ
7660 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
7661 coordinates of the iterator when restoring from ppos_it.
7662 (Bug#9296)
7663
5cf2b69b
KH
76642011-08-14 Kenichi Handa <handa@m17n.org>
7665
7666 * process.c (create_process): Call setup_process_coding_systems
72ad093b 7667 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 7668
daf17d00
EZ
76692011-08-14 Eli Zaretskii <eliz@gnu.org>
7670
7671 * xdisp.c (move_it_in_display_line_to): Don't invoke
7672 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
7673 ppos_it. Fixes vertical cursor motion when line beginning is
7674 covered by an image. (Bug#9296)
7675
08e3161a
JD
76762011-08-14 Jan Djärv <jan.h.d@swipnet.se>
7677
7678 * nsterm.h (ns_run_ascript): Declare.
7679 (NSAPP_DATA2_RUNASSCRIPT): Define.
7680
7681 * nsfns.m (as_script, as_result, as_status): New static variables.
7682 (ns_run_ascript): New function.
5e617bc2 7683 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
7684 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
7685 the event loop. Get status from as_status (Bug#7276).
7686
7687 * nsterm.m (sendEvent): If event is NSApplicationDefined and
7688 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
7689 the event loop (Bug#7276).
7690
a3720aa2
AS
76912011-08-14 Andreas Schwab <schwab@linux-m68k.org>
7692
7693 * gnutls.c (QCgnutls_bootprop_priority)
7694 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
7695 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
7696 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
7697 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
7698 (QCgnutls_bootprop_verify_hostname_error)
7699 (QCgnutls_bootprop_callbacks_verify): Rename from
7700 Qgnutls_bootprop_..., all uses changed.
7701
7702 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
7703 uses changed.
7704
0a0d27fb
PE
77052011-08-14 Paul Eggert <eggert@cs.ucla.edu>
7706
19d5c50c
PE
7707 * xfaces.c (Qframe_set_background_mode): Now static.
7708 * dispextern.h (Qframe_set_background_mode): Remove decl.
7709
0a0d27fb
PE
7710 * process.c (Fnetwork_interface_info): Declare local only if needed.
7711
377538cb
JD
77122011-08-13 Jan Djärv <jan.h.d@swipnet.se>
7713
7714 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
7715 (Fnetwork_interface_list): Allocate in increments of bytes instead
7716 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
7717 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
7718 sockaddr.
7719 (struct ifflag_def): notrailers is smart on OSX.
7720 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
7721 Get hardware address with getifaddrs if available.
7722
08fff70c
EZ
77232011-08-12 Eli Zaretskii <eliz@gnu.org>
7724
7725 * xdisp.c (iterate_out_of_display_property): xassert that
7726 IT->position is set to within IT->object's boundaries. Break from
7727 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
7728 when IT->position is set up wrongly due to some bug.
7729 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
7730 (push_display_prop): Allow GET_FROM_STRING as IT->method on
7731 entry. Force push_it to save on the stack the current
7732 buffer/string position, to be restored by pop_it. Fix flags in
7733 the iterator structure wrt the object coming from a display
7734 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
7735 properties. (Bug#9284)
7736
7be1c708 77372011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 7738
7be1c708
CY
7739 * fontset.c (fontset_get_font_group): Add proper type checks.
7740 (Bug#9172)
aac0c6e3 7741
7be1c708 77422011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 7743
7be1c708
CY
7744 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
7745 and LC_VERSION_MIN_MACOSX.
7746 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
7747 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 7748
97bb72a6
EZ
77492011-08-08 Eli Zaretskii <eliz@gnu.org>
7750
7751 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
7752 no-display-properties-and-no-overlays under bidi display.
7753 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 7754 properties and overlays.
97bb72a6 7755
d5617611
CY
77562011-08-08 Chong Yidong <cyd@stupidchicken.com>
7757
37e11a63
CY
7758 * editfns.c (Fset_time_zone_rule): Document relationship with the
7759 setenv function.
7760
d5617611
CY
7761 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
7762 the font entity extracted from the cache (Bug#8109).
7763
58872834
CY
77642011-08-07 Chong Yidong <cyd@stupidchicken.com>
7765
7766 * composite.c (autocmp_chars): Don't reset point. That is done by
7767 restore_point_unwind (Bug#5984).
7768
75bfc667
JL
77692011-08-07 Juri Linkov <juri@jurta.org>
7770
7771 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
7772 to show the arg `TIME' instead of `TIMEVAL'.
7773
d1410150
EZ
77742011-08-06 Eli Zaretskii <eliz@gnu.org>
7775
7776 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
7777 display property strides EOL and includes a newline, as in
7778 longlines-mode. (Bug#9254)
75b771e4
EZ
7779 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
7780 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
7781
7782 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
7783 is non-zero, even if the data buffer is NULL. Fixes a crash in
7784 vertical-motion with longlines-mode. (Bug#9254)
7785
35928349
EZ
77862011-08-05 Eli Zaretskii <eliz@gnu.org>
7787
ec7cc85b
EZ
7788 * bidi.c <bidi_cache_total_alloc>: Now static.
7789 (bidi_initialize): Initialize bidi_cache_total_alloc.
7790
8b76d6f8 7791 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
7792 cache. (Bug#9221)
7793
7794 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
7795 amount allocated this far in `bidi_cache_total_alloc'.
7796 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
7797 non-zero, only free the data buffer without restoring the cache
7798 contents. All callers changed.
7799
7800 * dispextern.h (bidi_unshelve_cache): Update prototype.
7801
7802 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
7803 (move_it_in_display_line, move_it_to)
7804 (move_it_vertically_backward, move_it_by_lines): Replace the call
7805 to xfree to an equivalent call to bidi_unshelve_cache.
7806 (move_it_in_display_line_to): Fix logic of returning
412b6358 7807 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 7808
e2e2423b
EZ
78092011-08-05 Eli Zaretskii <eliz@gnu.org>
7810
7811 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
7812 came from a string character with a `cursor' property. (Bug#9229)
7813
ae9e757a
JD
78142011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7815
7816 * Makefile.in (LIB_PTHREAD): New variable.
7817 (LIBES): Add LIB_PTHREAD (Bug#9216).
7818
7819 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
7820 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
7821
213bd7f2
AS
78222011-08-04 Andreas Schwab <schwab@linux-m68k.org>
7823
6b02f655 7824 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 7825
99aaf75f
JD
78262011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7827
7828 * xterm.c (x_find_topmost_parent): New function.
7829 (x_set_frame_alpha): Find topmost parent window with
7830 x_find_topmost_parent and set the property there also (bug#9181).
7831 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
7832
c74e9d86
PE
78332011-08-04 Paul Eggert <eggert@cs.ucla.edu>
7834
7835 * callproc.c (Fcall_process): Avoid vfork clobbering
7836 the local vars buffer, coding_systems, current_dir.
7837
640c8776
SM
78382011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
7839
7840 * keymap.c (Fmake_composed_keymap): Move to subr.el.
7841
f26d0e4c
PE
78422011-08-03 Paul Eggert <eggert@cs.ucla.edu>
7843
8a10d76c
PE
7844 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
7845 so that it is not optimized away.
7846
f26d0e4c
PE
7847 * xdisp.c (compute_display_string_pos): Remove unused local.
7848
55439c61
EZ
78492011-08-02 Eli Zaretskii <eliz@gnu.org>
7850
7851 Fix slow cursor motion and scrolling in large buffers with
7852 selective display, like Org Mode buffers. (Bug#9218)
7853
7854 * dispextern.h (struct bidi_it): New member disp_prop_p.
7855
7856 * xdisp.c: Remove one-slot cache of display string positions.
7857 (compute_display_string_pos): Accept an additional argument
5e617bc2 7858 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
7859 for a display string or property. If found, set DISP_PROP_P
7860 non-zero.
7861
7862 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
7863 DISP_PROP_P, and pass it to compute_display_string_pos.
7864 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
7865 non-zero. All callers of bidi_fetch_char changed.
7866
fb33fa43
SM
78672011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
7868
7869 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
7870
b099e063
DM
78712010-12-03 Don March <don@ohspite.net>
7872
7873 * keymap.c (Fdefine_key): Fix non-prefix key error message when
7874 last character M-[char] is translated to ESC [char] (bug#7541).
7875
5cc7f7af
KH
78762011-08-02 Kenichi Handa <handa@m17n.org>
7877
d0fffa3f 7878 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
7879
7880 * chartab.c (uniprop_table): Make it non-static.
7881
525d5e6e
EZ
78822011-08-01 Eli Zaretskii <eliz@gnu.org>
7883
7884 * xdisp.c (forward_to_next_line_start): Accept additional argument
7885 BIDI_IT_PREV, and store into it the state of the bidi iterator had
7886 on the newline.
7887 (reseat_at_next_visible_line_start): Use the bidi iterator state
7888 returned by forward_to_next_line_start to restore the state of
7889 it->bidi_it after backing up to previous newline. (Bug#9212)
7890
31011111
AS
78912011-07-30 Andreas Schwab <schwab@linux-m68k.org>
7892
7893 * regex.c (re_comp): Protoize.
7894 (re_exec): Fix return type.
7895 (regexec): Fix type of `ret'. (Bug#9203)
7896
476371c4
PE
78972011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7898
e5d76069
PE
7899 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
7900 This is needed if max-image-size is a floating-point number.
7901
9a79b20c
AS
79022011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7903
7904 * print.c (print_object): Print empty symbol as ##.
7905
7906 * lread.c (read1): Read ## as empty symbol.
7907
d8c2fa78
AA
79082011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7909
7910 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
7911 setting frame foreground color (Bug#9175).
7912 (x_set_background_color): Likewise.
7913
ffe57a7a
AA
7914 * nsmenu.m (-setText): Size tooltip dimensions precisely to
7915 contents (Bug#9176).
7916 (EmacsTooltip -init): Remove bezels and add shadows to
7917 tooltip windows.
7918
bf3492a5
AA
7919 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
7920 or scroll bar (Bug#8470).
7921
d55e9c53
AA
7922 * nsfont.m (nsfont_open): Remove assignment to voffset and
7923 unnecessary vars hshink, expand, hd, full_height, min_height.
7924 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
7925
7926 * nsterm.h (nsfont_info): Remove voffset field.
7927
d8c2fa78 79282011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
7929
7930 Implement strike-through and overline on NextStep (Bug#8863).
7931
7932 * nsfont.m (nsfont_open): Use underline position provided by font,
7933 instead of hard-coded value of 2.
7934 (nsfont_draw): Call ns_draw_text_decoration instead.
7935
7936 * nsterm.h: Add declaration for ns_draw_text_decoration.
7937
7938 * nsterm.m (ns_draw_text_decoration): New function for drawing
7939 underline, overline, and strike-through.
7940 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
7941 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 7942 accommodate underlining, etc.
4843aac3 7943
4cc60b9b
EZ
79442011-07-28 Eli Zaretskii <eliz@gnu.org>
7945
bc7ece87
EZ
7946 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
7947 default.
4cc60b9b 7948
476371c4
PE
79492011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7950
66606eea
PE
7951 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
7952 Without this fix, if a signal arrives just after memory fills up,
7953 'malloc' might be invoked reentrantly.
7954
476371c4
PE
7955 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
7956 In other words, assume that every image size is allowed, on non-X
7957 hosts. This assumption is probably wrong, but it lets Emacs compile.
7958
f3fcc40d
AS
79592011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7960
7961 * regex.c (re_iswctype): Convert return values to boolean.
7962
350c992f
EZ
79632011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
7964
7965 * xdisp.c (compute_display_string_pos): Don't use cached display
7966 string position if the buffer had its restriction changed.
7967 (Bug#9184)
7968
5266b4bb
PE
79692011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7970
7971 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7972
2573a837 79732011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 7974
41f55ccd 7975 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 7976
39e378da
PE
7977 * bidi.c: Integer size and overflow fixes.
7978 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
7979 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
7980 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7981 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
7982 (bidi_find_other_level_edge):
7983 Use ptrdiff_t instead of EMACS_INT where either will do.
7984 This works better on 32-bit hosts configured --with-wide-int.
7985 (bidi_cache_ensure_space): Check for size-calculation overflow.
7986 Use % rather than repeated addition, for better worst-case speed.
7987 Don't set bidi_cache_size until after xrealloc returns, because it
7988 might not return.
7989 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
7990 (bidi_cache_ensure_space): Also check that the bidi cache size
7991 does not exceed that of the largest Lisp string or buffer. See Eli
7992 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 7993
5e927815
PE
7994 * alloc.c (__malloc_size_t): Remove.
7995 All uses replaced by size_t. See Andreas Schwab's note
7996 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
7997
ca4aa935
PE
7998 * image.c: Improve checking for integer overflow.
7999 (check_image_size): Assume that f is nonnull, since
8000 it is always nonnull in practice. This is one less thing to
8001 worry about when checking for integer overflow later.
8002 (x_check_image_size): New function, which checks for integer
8003 overflow issues inside X.
8004 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
8005 This removes the need for a memory_full check.
8006 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
8007 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
8008 (xbm_read_bitmap_data): Change locals back to 'int', since
8009 their values must fit in 'int'.
8010 (xpm_load_image, png_load, tiff_load):
8011 Invoke x_create_x_image_and_pixmap earlier,
8012 to avoid much needless work if the image is too large.
8013 (tiff_load): Treat overly large images as if
8014 x_create_x_image_and_pixmap failed, not as malloc failures.
8015 (gs_load): Use x_check_image_size.
8016
5f8f9cc2
PE
8017 * gtkutil.c: Omit integer casts.
8018 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
8019 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
8020
5adf60bc
PE
8021 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
8022
c8907a93
PE
8023 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
8024 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
8025 would wrongly return t on a 64-bit host.
8026
e3c25c68
PE
8027 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
8028 The plain *_OVERFLOW macros run afoul of GCC bug 49705
8029 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
8030 and therefore cause GCC to emit a bogus diagnostic in some cases.
8031
3f791afe
PE
8032 * image.c: Integer signedness and overflow and related fixes.
8033 This is not an exhaustive set of fixes, but it's time to
8034 record what I've got.
8035 (lookup_pixel_color, check_image_size): Remove redundant decls.
8036 (check_image_size): Don't assume that arbitrary EMACS_INT values
8037 fit in 'int', or that arbitrary 'double' values fit in 'int'.
8038 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
8039 (tiff_load, imagemagick_load_image):
8040 Check for overflow in size calculations.
8041 (x_create_x_image_and_pixmap): Remove unnecessary test for
8042 xmalloc returning NULL; that can't happen.
8043 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
8044 (xpm_color_bucket): Use better integer hashing function.
8045 (xpm_cache_color): Don't possibly over-allocate memory.
8046 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
8047 (gif_memory_source):
8048 Use ptrdiff_t, not int or size_t, to record sizes.
8049 (png_load): Don't assume values greater than 2**31 fit in 'int'.
8050 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
8051 either works, as we prefer signed integers.
8052 (tiff_read_from_memory, tiff_write_from_memory):
8053 Return tsize_t, not size_t, since that's what the TIFF API wants.
8054 (tiff_read_from_memory): Don't fail simply because the read would
8055 go past EOF; instead, return a short read.
8056 (tiff_load): Omit no-longer-needed casts.
8057 (Fimagemagick_types): Don't assume size fits into 'int'.
8058
3cc5a532
PE
8059 Improve hashing quality when configured --with-wide-int.
8060 * fns.c (hash_string): New function, taken from sxhash_string.
8061 Do not discard information about ASCII character case; this
8062 discarding is no longer needed.
8063 (sxhash-string): Use it. Change sig to match it. Caller changed.
8064 * lisp.h: Declare it.
8065 * lread.c (hash_string): Remove, since we now use fns.c's version.
8066 The fns.c version returns a wider integer if --with-wide-int is
8067 specified, so this should help the quality of the hashing a bit.
8068
b312a492
PE
8069 * emacs.c: Integer overflow minor fix.
8070 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
8071 Define only if GNU_LINUX.
8072 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
8073
dfd153ae
PE
8074 * dispnew.c: Integer signedness and overflow fixes.
8075 Remove unnecessary forward decls, that were a maintenance hassle.
8076 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
8077 All uses changed.
8078 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
8079 (scrolling_window): Use ptrdiff_t, not int, for byte count.
8080 (prepare_desired_row, line_draw_cost):
8081 Use int, not unsigned, where either works.
8082 (save_current_matrix, restore_current_matrix):
8083 Use ptrdiff_t, not size_t, where either works.
8084 (init_display): Check for overflow more accurately, and without
8085 relying on undefined behavior.
8086
a81d11a3
PE
8087 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
8088 Remove, replacing with the new symbols in lisp.h. All uses changed.
8089 * fileio.c (make_temp_name):
8090 * filelock.c (lock_file_1, lock_file):
8091 * xdisp.c (message_dolog):
8092 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
8093 Use pMd etc. instead.
8094 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
8095 replacing the pWIDE etc. symbols removed from editfns.c.
8096
3300e6fd
PE
8097 * keyboard.h (num_input_events): Now uintmax_t.
8098 This is (very slightly) less likely to mess up due to wraparound.
8099 All uses changed.
8100
fd05c7e9
PE
8101 * buffer.c: Integer signedness fixes.
8102 (alloc_buffer_text, enlarge_buffer_text):
8103 Use ptrdiff_t rather than size_t when either will do, as we prefer
8104 signed integers.
8105
903fe15d
PE
8106 * alloc.c: Integer signedness and overflow fixes.
8107 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
8108 (__malloc_size_t): Default to size_t, not to int.
8109 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
8110 (Fgarbage_collect, mark_object_loop_halt, mark_object):
8111 Prefer ptrdiff_t to size_t when either would do, as we prefer
8112 signed integers.
8113 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
8114 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
8115 Now const. Initialize with values that are in range even if char
8116 is signed.
8117 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
8118 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
8119 These functions do the right thing with sizes > 2**32.
8120 (check_depth): Now ptrdiff_t, not int.
8121 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
8122 Adjust to new way of storing sizes. Check for size overflow bugs
8123 in rest of code.
8124 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
8125 slightly wrong anyway, as it missed one instance of
8126 XMALLOC_OVERRUN_CHECK_OVERHEAD.
8127 (refill_memory_reserve): Omit needless cast to size_t.
8128 (mark_object_loop_halt): Mark as externally visible.
8129
ac82cc6a
PE
8130 * xselect.c: Integer signedness and overflow fixes.
8131 (Fx_register_dnd_atom, x_handle_dnd_message):
8132 Use ptrdiff_t, not size_t, since we prefer signed.
8133 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
8134 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
8135 x_dnd_atoms_size and x_dnd_atoms_length.
8136
c2d1e36d
PE
8137 * doprnt.c: Prefer signed to unsigned when either works.
8138 * eval.c (verror):
8139 * doprnt.c (doprnt):
8140 * lisp.h (doprnt):
8141 * xdisp.c (vmessage):
8142 Use ptrdiff_t, not size_t, when using or implementing doprnt,
8143 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
8144 prefer signed arithmetic to avoid comparison confusion.
8145 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
8146 but is a bit tricky.
8147
0e926e56
PE
8148 Assume freestanding C89 headers, string.h, stdlib.h.
8149 * data.c, doprnt.c, floatfns.c, print.c:
8150 Include float.h unconditionally.
8151 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
8152 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
8153 * regex.c: Likewise for stddef.h, string.h.
8154 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
8155 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
8156 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
8157 (STDC_HEADERS): Remove obsolete defines.
8158 * sysdep.c: Include limits.h unconditionally.
8159
9cfdb3ec
PE
8160 Assume support for memcmp, memcpy, memmove, memset.
8161 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
8162 * regex.c (memcmp, memcpy):
8163 Remove; we assume C89 now.
8164
8165 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
8166 (__malloc_safe_bcopy): Remove; no longer needed.
8167
cf950e6b 8168 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
8169 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
8170 well either way, and we prefer signed to unsigned.
8171
dbf38e02
LMI
81722011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
8173
8174 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
8175 closes the connection while we're reading (bug#9182).
8176
d6f0886c 81772011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 8178
d6f0886c
JD
8179 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
8180 are specified (Bug#9168).
24e0f6b1 8181
2eb1f9e6
PE
81822011-07-25 Paul Eggert <eggert@cs.ucla.edu>
8183
8184 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
8185 Found by GCC static checking and --with-wide-int on a 32-bit host.
8186
22381272 81872011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
8188
8189 * xdisp.c (compute_display_string_pos): Fix logic of caching
8190 previous display string position. Initialize cached_prev_pos to
8191 -1. Fixes slow-down at the beginning of a buffer.
8192
f25e39b4
EZ
81932011-07-24 Eli Zaretskii <eliz@gnu.org>
8194
8195 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
8196 for attrs[LFACE_FONTSET_INDEX].
8197
04c4b52e
PE
81982011-07-23 Paul Eggert <eggert@cs.ucla.edu>
8199
8200 * xml.c (parse_region): Remove unused local
8201 that was recently introduced.
8202
c1734fbd
EZ
82032011-07-23 Eli Zaretskii <eliz@gnu.org>
8204
be18c5a5
EZ
8205 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
8206 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
8207
c1734fbd
EZ
8208 * xdisp.c (move_it_in_display_line_to): Record the best matching
8209 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
8210 exit if none of the characters scanned was an exact match.
8211 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
8212 when exact match is impossible due to invisible text, and the
8213 lines are truncated.
8214
a258d627
JD
82152011-07-23 Jan Djärv <jan.h.d@swipnet.se>
8216
8217 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
8218 for OSX >= 10.7.
8219
b6d5a689
EZ
82202011-07-22 Eli Zaretskii <eliz@gnu.org>
8221
0f74f785
EZ
8222 Fix a significant slow-down of cursor motion with C-n, C-p,
8223 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
8224 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 8225 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
8226 (next_element_from_buffer): Call compute_stop_pos_backwards to
8227 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
8228 base_level_stop.
8229 (reseat): Don't look for prev_stop, as that could mean a very long
8230 run.
8231 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
8232 <cached_disp_overlay_modiff>: Cache for last found display string
8233 position.
551918c1 8234 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
8235 about the same buffer in the same area of character positions, and
8236 the buffer wasn't changed since the time the display string
8237 position was cached.
551918c1 8238
b2d0c91a
EZ
82392011-07-22 Eli Zaretskii <eliz@gnu.org>
8240
8241 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
8242 is an integer, which is important for empty lines. (Bug#9149)
8243
043604ee
CY
82442011-07-22 Chong Yidong <cyd@stupidchicken.com>
8245
8246 * frame.c (Fmodify_frame_parameters): In tty case, update the
8247 default face if necessary (Bug#4238).
8248
da4adb04
CY
82492011-07-21 Chong Yidong <cyd@stupidchicken.com>
8250
8251 * editfns.c (Fstring_to_char): No need to explain what a character
8252 is in the docstring (Bug#6576).
8253
9abd0532
LMI
82542011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8255
8256 * xml.c (parse_region): Make sure we always return a tree.
8257
36881d16
HK
82582011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
8259
8260 * xml.c (parse_region): If a document contains only comments,
8261 return that, too.
8262
1e98674d
LMI
82632011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8264
8265 * xml.c (make_dom): Return comments, too.
8266
590bd467
PE
82672011-07-19 Paul Eggert <eggert@cs.ucla.edu>
8268
8269 Port to OpenBSD.
8270 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
8271 and the surrounding thread.
8272 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
8273 rather than fgets, and retry after EINTR. Otherwise, 'emacs
8274 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
8275 timer goes off.
8276 * s/openbsd.h (BROKEN_SIGIO): Define.
8277 * unexelf.c (unexec) [__OpenBSD__]:
8278 Don't update the .mdebug section of the Alpha COFF symbol table.
8279
f41628b2
LMI
82802011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
8281
8282 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
8283 (bug#8460).
8284
b59b67c5
PE
82852011-07-18 Paul Eggert <eggert@cs.ucla.edu>
8286
15e3a074
PE
8287 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
8288 This fixes some race conditions on the permissions of any newly
8289 created file.
8290
41bed37d
PE
8291 * alloc.c (valid_pointer_p): Use pipe, not open.
8292 This fixes some permissions issues when debugging.
8293
b59b67c5
PE
8294 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
8295 If fchown fails to set both uid and gid, try to set just gid,
8296 as that is sometimes allowed. Adjust the file's mode to eliminate
8297 setuid or setgid bits that are inappropriate if fchown fails.
8298
925a6be7
SM
82992011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
8300
8301 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
8302 to compare Lisp_Objects.
8303 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
8304 global_gnutls_log_level, don't mistake it for a Lisp_Object.
8305 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
8306
52968808
AS
83072011-07-17 Andreas Schwab <schwab@linux-m68k.org>
8308
0a6a104b
AS
8309 * lread.c (read_integer): Unread even EOF character.
8310 (read1): Likewise. Properly record start position of symbol.
8311
52968808
AS
8312 * lread.c (read1): Read `#:' as empty uninterned symbol if no
8313 symbol character follows.
8314
9e381cdd
PE
83152011-07-17 Paul Eggert <eggert@cs.ucla.edu>
8316
8317 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
8318 This works around a problem with the previous change to Fcopy_file.
8319 Recent glibc declares fchown with __attribute__((warn_unused_result)),
8320 and without this change, GCC might complain about discarding
8321 fchown's return value.
8322
b5641435
JB
83232011-07-16 Juanma Barranquero <lekktu@gmail.com>
8324
8325 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
8326
a8031457
PE
83272011-07-16 Paul Eggert <eggert@cs.ucla.edu>
8328
8329 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
8330
dd889327
LMI
83312011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
8332
750c33f7
LMI
8333 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
8334 it's used from the C level.
8335
dd889327
LMI
8336 * process.c: Use the same condition for POLL_FOR_INPUT in both
8337 keyboard.c and process.c (bug#1858).
8338
87e86684
LM
83392011-07-09 Lawrence Mitchell <wence@gmx.li>
8340
8341 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
8342 (Fgnutls_boot): Use it.
8343
64348f40
AS
83442011-07-15 Andreas Schwab <schwab@linux-m68k.org>
8345
8346 * doc.c (Fsubstitute_command_keys): Revert last change.
8347
1d698799
LMI
83482011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
8349
f863868c
LMI
8350 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
8351 quotes the next character, and doesn't affect other longer
8352 sequences (bug#8935).
8353
1d698799
LMI
8354 * lread.c (syms_of_lread): Clarify that is isn't only
8355 `eval-buffer' and `eval-defun' that's affected by
8356 `lexical-binding' (bug#8460).
8357
aa4b6df6
EZ
83582011-07-15 Eli Zaretskii <eliz@gnu.org>
8359
8360 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 8361 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 8362
5d856da6
PE
83632011-07-14 Paul Eggert <eggert@cs.ucla.edu>
8364
ad6042bb
PE
8365 Fix minor problems found by static checking.
8366 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
8367 (elsz): Now a signed constant, not a size_t var. We prefer signed
8368 types to unsigned, to avoid integer comparison confusion. Without
8369 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
8370 "cannot optimize loop, the loop counter may overflow", a symptom
8371 of the confusion.
f00bbb22 8372 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
8373 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
8374
6468f31c
LMI
83752011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8376
49080b10
LMI
8377 * search.c (Fre_search_backward): Mention `case-fold-search' in
8378 all the re_search_* functions (bug#8138).
8379
6468f31c
LMI
8380 * keyboard.c (Fopen_dribble_file): Document when the file is
8381 closed (bug#8056).
8382
c965adc5
EZ
83832011-07-14 Eli Zaretskii <eliz@gnu.org>
8384
df9733bf
EZ
8385 * bidi.c (bidi_dump_cached_states): Fix format of displaying
8386 bidi_cache_idx.
8387
0bb23927
EZ
8388 Support bidi reordering of display and overlay strings.
8389 * xdisp.c (compute_display_string_pos)
8390 (compute_display_string_end): Accept additional argument STRING.
8391 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
8392 (reseat_to_string): Initialize bidi_it->string.s and
8393 bidi_it->string.schars.
8394 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
8395 NULL (avoids a crash in bidi_paragraph_init).
8396 Initialize itb.string.lstring.
0bb23927
EZ
8397 (init_iterator): Call bidi_init_it only of a valid
8398 buffer position was specified. Initialize paragraph_embedding to
8399 L2R.
8400 (reseat_to_string): Initialize the bidi iterator.
8401 (display_string): If we need to ignore text properties of
8402 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
8403 original value of -1 will not work with bidi.)
8404 (compute_display_string_pos): First arg is now struct
8405 `text_pos *'; all callers changed. Support display properties on
8406 Lisp strings.
8407 (compute_display_string_end): Support display properties on Lisp
8408 strings.
8409 (init_iterator, reseat_1, reseat_to_string): Initialize the
8410 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
8411 when iterating on a string not from display properties).
640c8776
SM
8412 (compute_display_string_pos, compute_display_string_end):
8413 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
8414 arrow keys.
8415 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
8416 base_level_stop; instead, set base_level_stop to BEGV.
8417 Fixes crashes in vertical-motion.
0bb23927
EZ
8418 (next_element_from_buffer): Improve commentary for when
8419 the iterator is before prev_stop.
8420 (init_iterator): Initialize bidi_p from the default value of
8421 bidi-display-reordering, not from buffer-local value. Use the
8422 buffer-local value only if initializing for buffer iteration.
8423 (handle_invisible_prop): Support invisible properties on strings
8424 that are being bidi-reordered.
8425 (set_iterator_to_next): Support bidi reordering of C strings and
8426 Lisp strings.
8427 (next_element_from_string): Support bidi reordering of Lisp
8428 strings.
8429 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
8430 (display_string): Support display of R2L glyph rows.
8431 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
8432 (init_iterator): Don't initialize it->bidi_p for strings
8433 here.
8434 (reseat_to_string): Initialize it->bidi_p for strings here.
8435 (next_element_from_string, next_element_from_c_string)
8436 (next_element_from_buffer): Add xassert's for correspondence
8437 between IT's object being iterated and it->bidi_it.string
8438 structure.
8439 (face_before_or_after_it_pos): Support bidi iteration.
8440 (next_element_from_c_string): Handle the case of the first string
8441 character that is not the first one in the visual order.
8442 (get_visually_first_element): New function, refactored from common
8443 parts of next_element_from_buffer, next_element_from_string, and
8444 next_element_from_c_string.
8445 (tool_bar_lines_needed, redisplay_tool_bar)
8446 (display_menu_bar): Force left-to-right direction. Add a FIXME
8447 comment for making that be controlled by a user option.
8448 (push_it, pop_it): Save and restore the state of the
8449 bidi iterator. Save and restore the bidi_p flag.
8450 (pop_it): Iterate out of display property for string iteration as
8451 well.
8452 (iterate_out_of_display_property): Support iteration over strings.
8453 (handle_single_display_spec): Set up it->bidi_it for iteration
8454 over a display string, and call bidi_init_it.
8455 (handle_single_display_spec, next_overlay_string)
8456 (get_overlay_strings_1, push_display_prop): Set up the bidi
8457 iterator for displaying display or overlay strings.
8458 (forward_to_next_line_start): Don't use the shortcut if
8459 bidi-iterating.
8460 (back_to_previous_visible_line_start): If handle_display_prop
8461 pushed the iterator stack, restore the internal state of the bidi
8462 iterator by calling bidi_pop_it same number of times.
8463 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
8464 and we are bidi-iterating, don't decrement the iterator position;
8465 instead, set the first_elt flag in the bidi iterator, to produce
8466 the same effect.
8467 (reseat_1): Remove redundant setting of string_from_display_prop_p.
8468 (push_display_prop): xassert that we are iterating a buffer.
8469 (push_it, pop_it): Save and restore paragraph_embedding member.
8470 (handle_single_display_spec, next_overlay_string)
8471 (get_overlay_strings_1, reseat_1, reseat_to_string)
8472 (push_display_prop): Set up the `unibyte' member of bidi_it.string
8473 correctly. Don't assume unibyte strings are not bidi-reordered.
8474 (compute_display_string_pos)
8475 (compute_display_string_end): Fix handling the case of C string.
8476 (push_it, pop_it): Save and restore from_disp_prop_p.
8477 (handle_single_display_spec, push_display_prop): Set the
8478 from_disp_prop_p flag.
8479 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
8480 (pop_it): Call iterate_out_of_display_property only if we are
8481 popping after iteration over a string that came from a display
8482 property. Fix a typo in popping stretch info. Add an assertion
8483 for verifying that the iterator position is in sync with the bidi
8484 iterator.
8485 (handle_single_display_spec, get_overlay_strings_1)
8486 (push_display_prop): Fix initialization of paragraph direction for
8487 string when that of the parent object is not yet determined.
8488 (reseat_1): Call bidi_init_it to resync the bidi
8489 iterator with IT's position. (Bug#7616)
8490 (find_row_edges): If ROW->start.pos gives position
8491 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
8492 (handle_stop, back_to_previous_visible_line_start, reseat_1):
8493 Reset the from_disp_prop_p flag.
8494 (SAVE_IT, RESTORE_IT): New macros.
8495 (pos_visible_p, face_before_or_after_it_pos)
8496 (back_to_previous_visible_line_start)
8497 (move_it_in_display_line_to, move_it_in_display_line)
8498 (move_it_to, move_it_vertically_backward, move_it_by_lines)
8499 (try_scrolling, redisplay_window, display_line): Use them when
8500 saving a temporary copy of the iterator and restoring it back.
8501 (back_to_previous_visible_line_start, reseat_1)
8502 (init_iterator): Empty the bidi cache "stack".
8503 (move_it_in_display_line_to): If iterator ended up at
8504 EOL, but we never saw any buffer positions smaller than
8505 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
8506 motion in bidi-reordered lines.
8507 (move_it_in_display_line_to): Record prev_method and prev_pos
8508 immediately before the call to set_iterator_to_next. Fixes cursor
8509 motion in bidi-reordered lines with stretch glyphs and strings
8510 displayed in margins. (Bug#8133) (Bug#8867)
8511 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
8512 TO_CHARPOS.
640c8776
SM
8513 (pos_visible_p): Support positions in bidi-reordered lines.
8514 Save and restore bidi cache.
0bb23927
EZ
8515
8516 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
8517 (bidi_paragraph_info): Delete unused struct.
8518 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
8519 (bidi_cache_start): New variable.
8520 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
8521 to zero.
8522 (bidi_cache_fetch_state, bidi_cache_search)
8523 (bidi_cache_find_level_change, bidi_cache_iterator_state)
8524 (bidi_cache_find, bidi_peek_at_next_level)
8525 (bidi_level_of_next_char, bidi_find_other_level_edge)
8526 (bidi_move_to_visually_next): Compare cache index with
8527 bidi_cache_start rather than with zero.
8528 (bidi_fetch_char): Accept new argument STRING; all callers
8529 changed. Support iteration over a string. Support strings with
8530 display properties. Support unibyte strings. Fix the type of
8531 `len' according to what STRING_CHAR_AND_LENGTH expects.
8532 (bidi_paragraph_init, bidi_resolve_explicit_1)
8533 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
8534 (bidi_level_of_next_char, bidi_move_to_visually_next):
8535 Support iteration over a string.
0bb23927
EZ
8536 (bidi_set_sor_type, bidi_resolve_explicit_1)
8537 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
8538 can now be zero (for strings); special values 0 and -1 were
8539 changed to -1 and -2, respectively.
8540 (bidi_char_at_pos): New function.
8541 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
8542 Call it instead of FETCH_MULTIBYTE_CHAR.
8543 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
8544 initialized to valid values.
8545 (bidi_init_it): Don't initialize charpos and bytepos with invalid
8546 values.
8547 (bidi_level_of_next_char): Allow the sentinel "position" to pass
8548 the test for valid cached positions. Fix the logic for looking up
8549 the sentinel state in the cache. GCPRO the Lisp string we are
8550 iterating.
8551 (bidi_push_it, bidi_pop_it): New functions.
8552 (bidi_initialize): Initialize the bidi cache start stack pointer.
8553 (bidi_cache_ensure_space): New function, refactored from part of
8554 bidi_cache_iterator_state. Don't assume the required size is just
8555 one BIDI_CACHE_CHUNK away.
8556 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
8557 (bidi_count_bytes, bidi_char_at_pos): New functions.
8558 (bidi_cache_search): Don't assume bidi_cache_last_idx is
8559 always valid if bidi_cache_idx is valid.
8560 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
8561 is valid if it's going to be used.
8562 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
8563 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
8564 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8565 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
8566 (bidi_find_other_level_edge, bidi_cache_start_stack):
8567 All variables related to cache indices are now EMACS_INT.
c965adc5 8568
0bb23927
EZ
8569 * dispextern.h (struct bidi_string_data): New structure.
8570 (struct bidi_it): New member `string'. Make flag members be 1-bit
8571 fields, and put them last in the struct.
640c8776
SM
8572 (compute_display_string_pos, compute_display_string_end):
8573 Update prototypes.
0bb23927
EZ
8574 (bidi_push_it, bidi_pop_it): Add prototypes.
8575 (struct iterator_stack_entry): New members bidi_p,
8576 paragraph_embedding, and from_disp_prop_p.
8577 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
8578 (bidi_shelve_cache, bidi_unshelve_cache):
8579 Declare prototypes.
0bb23927
EZ
8580
8581 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
8582 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
8583 and vector-like objects.
8584
8585 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
8586 cache around display iteration.
8587
8588 * window.c (Fwindow_end, window_scroll_pixel_based)
8589 (displayed_window_lines, Frecenter): Save and restore the bidi
8590 cache around display iteration.
8591
3bbd2265
LMI
85922011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8593
8594 * editfns.c (Fdelete_region): Clarify the use of the named
8595 parameters (bug#6788).
8596
adc47434
MR
85972011-07-14 Martin Rudalics <rudalics@gmx.at>
8598
8599 * indent.c (Fvertical_motion): Set and restore w->pointm when
8600 saving and restoring the window's buffer (Bug#9006).
8601
837c31f8
LMI
86022011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
8603
8604 * editfns.c (Fstring_to_char): Clarify just what is returned
8605 (bug#6576). Text by Eli Zaretskii.
8606
ac389d0c
JB
86072011-07-13 Juanma Barranquero <lekktu@gmail.com>
8608
8609 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
8610
0be0ce47
EZ
86112011-07-13 Eli Zaretskii <eliz@gnu.org>
8612
8613 * buffer.c (mmap_find): Fix a typo.
8614
cd18e7e3
JB
86152011-07-13 Johan Bockgård <bojohan@gnu.org>
8616
8617 Fix execution of x selection hooks.
8618 * xselect.c (Qx_lost_selection_functions)
8619 (Qx_sent_selection_functions): New vars.
8620 (syms_of_xselect): DEFSYM them.
8621 (x_handle_selection_request): Pass Qx_sent_selection_functions
8622 rather than Vx_sent_selection_functions to Frun_hook_with_args.
8623 (x_handle_selection_clear,x_clear_frame_selections):
8624 Pass Qx_lost_selection_functions rather than
8625 Vx_lost_selection_functions to Frun_hook_with_args.
8626
47ea7f44
PE
86272011-07-13 Paul Eggert <eggert@cs.ucla.edu>
8628
ac389d0c 8629 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
8630 The old code sometimes used this field without initializing it.
8631
47ea7f44
PE
8632 * alloc.c (gc_sweep): Don't read past end of array.
8633 In theory, the old code could also have corrupted Emacs internals,
8634 though it'd be very unlikely.
8635
bc985c87
AS
86362011-07-12 Andreas Schwab <schwab@linux-m68k.org>
8637
8638 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 8639 argument. (Bug#4026)
bc985c87 8640
0cf34688
LMI
86412011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
8642
b3dadd76
LMI
8643 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
8644 key" (bug#4257).
8645
0cf34688
LMI
8646 * window.c (Fset_window_start): Doc fix (bug#4199).
8647 (Fset_window_hscroll): Ditto.
8648
270768cd
PE
86492011-07-12 Paul Eggert <eggert@cs.ucla.edu>
8650
077e3dda 8651 Fix minor new problems caught by GCC 4.6.1.
270768cd 8652 * term.c (init_tty): Remove unused local.
490011a6 8653 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 8654 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 8655 not used otherwise.
270768cd 8656
b1f58454
CY
86572011-07-12 Chong Yidong <cyd@stupidchicken.com>
8658
8659 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
8660
22b9578d
LMI
86612011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
8662
6e70ab07
LMI
8663 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
8664 are the mini-buffer and the echo area (bug#3320).
8665
22b9578d
LMI
8666 * term.c (init_tty): Remove support for supdup, c10 and perq
8667 terminals, which are no longer supported (bug#1482).
8668
8974cc9f
JB
86692011-07-10 Johan Bockgård <bojohan@gnu.org>
8670
8671 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
8672
a560d974
JD
86732011-07-10 Jan Djärv <jan.h.d@swipnet.se>
8674
8675 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
8676 for non-popups (Bug#3642).
8677
1dae0f0a
AS
86782011-07-10 Andreas Schwab <schwab@linux-m68k.org>
8679
268c2c36 8680 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 8681 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
8682 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
8683 * cm.c (losecursor): Likewise.
1dae0f0a
AS
8684 * data.c (fmod): Likewise.
8685 * dispnew.c (swap_glyphs_in_rows): Likewise.
8686 * emacs.c (memory_warning_signal): Likewise.
8687 * floatfns.c (float_error): Likewise.
8688 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
8689 (otf_open, font_otf_capability, generate_otf_features)
8690 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
8691 Likewise.
8692 * image.c (pbm_read_file): Likewise.
8693 * indent.c (string_display_width): Likewise.
8694 * intervals.c (check_for_interval, search_for_interval)
8695 (inc_interval_count, count_intervals, root_interval)
8696 (adjust_intervals_for_insertion, make_new_interval): Likewise.
8697 * lread.c (defalias): Likewise.
268c2c36 8698 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
8699 * regex.c (set_image_of_range_1, set_image_of_range)
8700 (regex_grow_registers): Likewise.
8701 * sysdep.c (strerror): Likewise.
8702 * termcap.c (valid_filename_p, tprint, main): Likewise.
8703 * tparam.c (main): Likewise.
8704 * unexhp9k800.c (run_time_remap, save_data_space)
8705 (update_file_ptrs, read_header, write_header, calculate_checksum)
8706 (copy_file, copy_rest, display_header): Likewise.
8707 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
8708 Likewise.
8709 * xdisp.c (check_it): Likewise.
8710 * xfaces.c (register_color, unregister_color, unregister_colors):
8711 Likewise.
8712 * xfns.c (print_fontset_result): Likewise.
8713 * xrdb.c (member, fatal, main): Likewise.
8714
99033785
PE
87152011-07-10 Paul Eggert <eggert@cs.ucla.edu>
8716
8717 Fix minor problems found by static checking (Bug#9031).
8718 * chartab.c (char_table_set_range, map_sub_char_table):
8719 Remove unused locals.
8720 (uniprop_table): Now static.
8721 * composite.c (_work_char): Remove unused static var.
8722
9cb2ac56
JB
87232011-07-09 Juanma Barranquero <lekktu@gmail.com>
8724
8725 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
8726
f25661f0
JD
87272011-07-09 Jan Djärv <jan.h.d@swipnet.se>
8728
8729 * gtkutil.c (qttip_cb): Remove code without function.
8730
8278c4fe
EZ
87312011-07-09 Eli Zaretskii <eliz@gnu.org>
8732
8733 * w32.c (pthread_sigmask): New stub.
8734
1692ae2d 87352011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 8736
8a6ebd58 8737 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
8738 sigprocmask is portable only for single-threaded applications, and
8739 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
8740 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
8741 (LIBES): Use it.
8742 * callproc.c (Fcall_process):
8743 * process.c (create_process):
8744 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
8745 Use pthread_sigmask, not sigprocmask.
123403e4 8746
1b854618
JD
87472011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8748
8749 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
8750 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
8751 wrong (Bug#8591).
8752
3fe4b549
JD
87532011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8754
0ce7e563
JD
8755 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
8756 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
8757 (xg_hide_tooltip): Fix comment.
8758
3fe4b549
JD
8759 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
8760 in registerServicesMenuSendTypes.
8761 (validRequestorForSendType): Don't check ns_return_types.
8762
8763 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
8764 ns_return_type.
8765
5df75e47
JR
87662011-07-08 Jason Rumney <jasonr@gnu.org>
8767
22610910
JR
8768 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
8769 SH_SHOW for hidden windows (Bug#5482).
8770
5df75e47
JR
8771 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
8772 frame struct members of non-existent frames (Bug#6284).
8773
699c10bd
JD
87742011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8775
4393663b
JD
8776 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
8777 variable firstTime not needed on OSX >= 10.6.
8778 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
8779 >= 10.5. Use setKnobProportion, setDoubleValue.
8780
8781 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
8782 (MAC_OS_X_VERSION_10_5): Define if not defined.
8783 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
8784 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
8785 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
8786
8787 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 8788 cString and lossyCString on OSX >= 10.4.
4393663b 8789
58179cce 8790 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
8791 sizeToFit on OSX >= 10.2.
8792
8793 * nsimage.m (allocInitFromFile): Don't use deprecated method
8794 bestRepresentationForDevice on OSX >= 10.6.
8795
8796 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
8797 to avoid warning.
8798
8799 * emacs.c: Declare unexec_init_emacs_zone.
8800
a63e0781
JD
8801 * nsgui.h: Fix compiler warning about gnulib redefining verify.
8802
699c10bd
JD
8803 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
8804
8805 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
8806 on svcsMenu (Bug#8842).
8807
8808 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
8809 ns_return_types.
8810 (Fns_list_services): Just return Qnil on 10.6, code not working there.
8811
8812 * nsterm.m (QUTF8_STRING): Declare.
8813 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
8814 (validRequestorForSendType): Return type is (id).
8815 Change indexOfObjectIdenticalTo to indexOfObject.
8816 Check if we have local selection before returning self (Bug#8842).
8817 (writeSelectionToPasteboard): Put local selection into paste board
8818 if we have a local selection (Bug#8842).
8819 (syms_of_nsterm): DEFSYM QUTF8_STRING.
8820
8821 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
8822 (ns_get_local_selection): Declare.
8823
54e10184
LMI
88242011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
8825
9888ff71
LMI
8826 * keymap.c (describe_map_tree): Don't insert a double newline at
8827 the end of the buffer (bug#1169) and return whether we inserted
8828 something.
8829
54e10184
LMI
8830 * callint.c (Fcall_interactively): Change "reading args" to
8831 "providing args" to try to clarify what it does (bug#1010).
8832
15fa4783
KH
88332011-07-07 Kenichi Handa <handa@m17n.org>
8834
8835 * composite.c (composition_compute_stop_pos): Ignore a static
8836 composition starting before CHARPOS (Bug#8915).
8837
8838 * xdisp.c (handle_composition_prop): Likewise.
8839
a8815b00
EZ
88402011-07-07 Eli Zaretskii <eliz@gnu.org>
8841
8842 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
8843 (Bug#9015)
8844
ef7b981d 88452011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
8846
8847 * character.h (unicode_category_t): New enum type.
8848
8849 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
8850 (Qchar_code_property_table): New variable.
8851 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
8852 (UNIPROP_COMPRESSED_FORM_P): New macros.
8853 (char_table_ascii): Uncompress the compressed values.
8854 (sub_char_table_ref): New arg is_uniprop. Callers changed.
8855 Uncompress the compressed values.
ac389d0c 8856 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
8857 (char_table_ref_and_range): Uncompress the compressed values.
8858 (sub_char_table_set): New arg is_uniprop. Callers changed.
8859 Uncompress the compressed values.
8860 (sub_char_table_set_range): Args changed. Callers changed.
8861 (char_table_set_range): Adjuted for the above change.
8862 (map_sub_char_table): Delete args default_val and parent. Add arg
8863 top. Give decoded values to a Lisp function.
640c8776 8864 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
8865 values to a Lisp function. Gcpro more variables.
8866 (uniprop_table_uncompress)
8867 (uniprop_decode_value_run_length): New functions.
8868 (uniprop_decoder, uniprop_decoder_count): New variables.
8869 (uniprop_get_decoder, uniprop_encode_value_character)
8870 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
8871 New functions.
8872 (uniprop_encoder, uniprop_encoder_count): New variables.
8873 (uniprop_get_encoder, uniprop_table)
8874 (Funicode_property_table_internal, Fget_unicode_property_internal)
8875 (Fput_unicode_property_internal): New functions.
8876 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
8877 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 8878 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
8879 char-code-property-alist.
8880
640c8776 8881 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
8882 Vunicode_category_table.
8883
640c8776 8884 * font.c (font_range): Adjust for the change of
c805dec0
KH
8885 Vunicode_category_table.
8886
76b397fb
DN
88872011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
8888
8889 * m/iris4d.h: Remove file, move contents ...
8890 * s/irix6-5.h: ... here.
8891
22b4128e
PE
88922011-07-06 Paul Eggert <eggert@cs.ucla.edu>
8893
8894 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
8895 * alloc.c (mark_buffer):
8896 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
8897 (clone_per_buffer_values): Don't assume that
22b4128e
PE
8898 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
8899 This isn't true in general, and it's particularly not true
8900 if Emacs is configured with --with-wide-int.
8901 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
8902 New macros, used in the buffer.c change.
8903
869795d6
JD
89042011-07-05 Jan Djärv <jan.h.d@swipnet.se>
8905
8906 * xsettings.c: Use both GConf and GSettings if both are available.
8907 (store_config_changed_event): Add comment.
8908 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
8909 (store_tool_bar_style_changed): New functions.
5e617bc2 8910 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
8911 (struct xsettings): Move font inside HAVE_XFT.
8912 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 8913 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 8914 Move inside HAVE_XFT.
640c8776 8915 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
8916 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
8917 also.
8918 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 8919 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 8920 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
8921 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
8922 (parse_settings): Move check for font inside HAVE_XFT.
8923 (read_settings, apply_xft_settings): Add comment.
8924 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
8925 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
8926 call store_font_name_changed.
8927 (xft_settings_event): Add comment.
8928 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
8929 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
8930 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
8931 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
8932 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
8933 (xsettings_get_system_font, xsettings_get_system_normal_font):
8934 Add comment.
869795d6 8935
d8ed26bd
PE
89362011-07-05 Paul Eggert <eggert@cs.ucla.edu>
8937
8938 Random fixes. E.g., (random) never returned negative values.
8939 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
8940 subseconds part to the entropy, as that's a bit more random.
8941 Prefer signed to unsigned, since the signedness doesn't matter and
8942 in general we prefer signed. When given a limit, use a
8943 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
8944 latter isn't right if USE_2_TAGS_FOR_INTS.
8945 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
8946 not 0..VALMASK. Don't discard "excess" bits that random () returns.
8947
cabf1cac
SM
89482011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
8949
8950 * textprop.c (text_property_stickiness):
8951 Obey Vtext_property_default_nonsticky.
8952 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
8953 * w32fns.c (syms_of_w32fns):
8954 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
8955
6e9b2be9
PE
89562011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8957
8958 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
8959 This is more efficient than Ffile_directory_p and avoids a minor race.
8960
90186c68
LMI
89612011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
8962
7c301272
LMI
8963 * buffer.c (Foverlay_put): Say what the return value is
8964 (bug#7835).
8965
c4f2d8d4
LMI
8966 * fileio.c (barf_or_query_if_file_exists): Check first if the file
8967 is a directory before asking whether to use the file name
8968 (bug#7564).
ad637907
LMI
8969 (barf_or_query_if_file_exists): Make the "File is a directory"
8970 error be more correct.
c4f2d8d4 8971
90186c68
LMI
8972 * fns.c (Frequire): Remove the mention of the .gz files, since
8973 that's installation-specific, but keep the mention of
8974 `get-load-suffixes'.
8975
da64016e
PE
89762011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8977
8978 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
8979 Report string overflow if the output is too long.
8980
7d47b580
JB
89812011-07-04 Juanma Barranquero <lekktu@gmail.com>
8982
a555cb87
JB
8983 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
8984 (syms_of_gnutls): Remove duplicate DEFSYM for
8985 Qgnutls_bootprop_verify_hostname_error, an error for
8986 Qgnutls_bootprop_verify_error (which is no longer used).
8987
7d47b580
JB
8988 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
8989 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
8990 Also (re)move comments that are misplaced or no longer relevant.
8991
1e49bfab
LMI
89922011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8993
8994 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
8995
1485f4c0
CY
89962011-07-03 Chong Yidong <cyd@stupidchicken.com>
8997
8998 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
8999 and background color parameters if they have been changed.
9000
a9ab721e
LMI
90012011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9002
9003 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
9004
cf7cff57
PE
90052011-07-03 Paul Eggert <eggert@cs.ucla.edu>
9006
2e13213d
PE
9007 * xsettings.c (SYSTEM_FONT): Define only when used.
9008 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
9009
cf7cff57
PE
9010 * keymap.c (access_keymap_1): Now static.
9011
7a8e04f7
CY
90122011-07-02 Chong Yidong <cyd@stupidchicken.com>
9013
9014 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
9015 leave any prefix arg for the up event (Bug#1586).
9016
61352f62
LMI
90172011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
9018
69bb1ef7
LMI
9019 * lread.c (syms_of_lread): Mention single symbols defined by
9020 `defvar' or `defconst' (bug#7154).
9021
61352f62 9022 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 9023 (Frequire): Mention get-load-suffixes.
61352f62 9024
28545e04
MR
90252011-07-02 Martin Rudalics <rudalics@gmx.at>
9026
9027 * window.h (window): Remove clone_number slot.
9028 * window.c (Fwindow_clone_number, Fset_window_clone_number):
9029 Remove.
9030 (make_parent_window, make_window, saved_window)
9031 (Fset_window_configuration, save_window_save): Don't deal with
9032 clone numbers.
9033 * buffer.c (Qclone_number): Remove declaration.
9034 (sort_overlays, overlay_strings): Don't deal with clone numbers.
9035
3349e122
SM
90362011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
9037
9038 Add multiple inheritance to keymaps.
9039 * keymap.c (Fmake_composed_keymap): New function.
9040 (Fset_keymap_parent): Simplify.
9041 (fix_submap_inheritance): Remove.
9042 (access_keymap_1): New function extracted from access_keymap to handle
9043 embedded parents and handle lists of maps.
9044 (access_keymap): Use it.
9045 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
9046 (Fcopy_keymap): Handle embedded parents.
9047 (Fcommand_remapping, define_as_prefix): Simplify.
9048 (Fkey_binding): Simplify.
9049 (syms_of_keymap): Move minibuffer-local-completion-map,
9050 minibuffer-local-filename-completion-map,
9051 minibuffer-local-must-match-map, and
9052 minibuffer-local-filename-must-match-map to Elisp.
9053 (syms_of_keymap): Defsubr make-composed-keymap.
9054 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
9055 (parse_menu_item): Trivial simplification.
9056
3279eb87
GM
90572011-07-01 Glenn Morris <rgm@gnu.org>
9058
9059 * Makefile.in (SETTINGS_LIBS): Fix typo.
9060
4550efdf
KI
90612011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
9062
9063 * coding.c (Fencode_coding_string): Record the last coding system
9064 used, as the function doc string says (bug#8738).
9065
0949d2b6
JD
90662011-07-01 Jan Djärv <jan.h.d@swipnet.se>
9067
9068 * xsettings.c (store_monospaced_changed): Take new font as arg and
9069 check for change against current_mono_font.
9070 (EMACS_TYPE_SETTINGS): Remove this and related defines.
9071 (emacs_settings_constructor, emacs_settings_get_property)
9072 (emacs_settings_set_property, emacs_settings_class_init)
9073 (emacs_settings_init, gsettings_obj): Remove.
9074 (something_changedCB): New function for HAVE_GSETTINGS.
9075 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
9076 with value as argument.
9077 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
9078 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 9079 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
9080 "changed".
9081
9082 * xgselect.c: Add defined (HAVE_GSETTINGS).
9083 (xgselect_initialize): Ditto.
9084
9085 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
9086 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
9087 xg_select.
9088
bbc6b304
PE
90892011-07-01 Paul Eggert <eggert@cs.ucla.edu>
9090
9091 * eval.c (struct backtrace): Simplify and port the data structure.
9092 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
9093 signed bit field, as this assumption is not portable and it makes
9094 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
9095 "char debug_on_exit : 1" as this is not portable either; instead,
9096 use the portable "unsigned int debug_on_exit : 1". Remove unused
9097 member evalargs. Remove obsolete comments about cc bombing out.
9098
9851bfc5
JD
90992011-06-30 Jan Djärv <jan.h.d@swipnet.se>
9100
51bb811f 9101 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
9102 Let HAVE_GSETTINGS override HAVE_GCONF.
9103 (store_monospaced_changed): New function.
9104 (EMACS_SETTINGS): A new type derived from GObject to handle
9105 GSettings notifications.
9106 (emacs_settings_constructor, emacs_settings_get_property)
9107 (emacs_settings_set_property, emacs_settings_class_init):
9108 New functions.
9109 (gsettings_client, gsettings_obj): New variables.
9110 (GSETTINGS_SCHEMA): New define.
9111 (something_changedCB): Call store_monospaced_changed.
9112 (init_gsettings): New function.
9113 (xsettings_initialize): Call init_gsettings.
9114 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
9115 to NULL.
9116
640c8776 9117 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
9118 GCONF_CFLAGS/LIBS.
9119
5386012d
MR
91202011-06-29 Martin Rudalics <rudalics@gmx.at>
9121
9122 * window.c (resize_root_window, grow_mini_window)
9123 (shrink_mini_window): Rename Qresize_root_window to
9124 Qwindow_resize_root_window and Qresize_root_window_vertically to
9125 Qwindow_resize_root_window_vertically.
9126
f13e0b08
PE
91272011-06-28 Paul Eggert <eggert@cs.ucla.edu>
9128
9129 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
9130
94515237
JB
91312011-06-27 Juanma Barranquero <lekktu@gmail.com>
9132
9133 * makefile.w32-in: Redesign dependencies so they reflect more
9134 clearly which files are directly included by each source file,
9135 and not through other includes.
9136
e43b6e43
MR
91372011-06-27 Martin Rudalics <rudalics@gmx.at>
9138
9139 * buffer.c (Qclone_number): Declare static and DEFSYM it.
9140 (sort_overlays, overlay_strings): When an overlay's clone number
9141 matches the window's clone number process the overlay even if
9142 the overlay's window property doesn't match the current window.
9143
d68443dc
MR
9144 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
9145 (Fwindow_hchild): Rename to Fwindow_left_child.
9146 (Fwindow_next): Rename to Fwindow_next_sibling.
9147 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
9148 (resize_window_check): Rename to window_resize_check.
9149 (resize_window_apply): Rename to window_resize_apply.
9150 (Fresize_window_apply): Rename to Fwindow_resize_apply.
9151 (Fdelete_other_windows_internal, resize_frame_windows)
9152 (Fsplit_window_internal, Fdelete_window_internal)
9153 (grow_mini_window, shrink_mini_window)
9154 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 9155
c7e73be5
JD
91562011-06-26 Jan Djärv <jan.h.d@swipnet.se>
9157
9158 * emacsgtkfixed.h: State that this is only used with Gtk+3.
9159 (emacs_fixed_set_min_size): Remove.
9160 (emacs_fixed_new): Take frame as argument.
9161
9162 * emacsgtkfixed.c: State that this is only used with Gtk+3.
9163 (_EmacsFixedPrivate): Remove minwidth/height.
9164 Add struct frame *f.
9165 (emacs_fixed_init): Initialize priv->f.
9166 (get_parent_class, emacs_fixed_set_min_size): Remove.
9167 (emacs_fixed_new): Set priv->f to argument.
9168 (emacs_fixed_get_preferred_width)
9169 (emacs_fixed_get_preferred_height): Use min_width/height from
9170 frames size_hint to set minimum and natural (Bug#8919).
9171 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
9172 and use min_width/height from frames size_hint to set
9173 min_width/height (Bug#8919).
9174
9175 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
9176 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
9177 Fix indentation.
c7e73be5 9178
cf99dcf8
EZ
91792011-06-26 Eli Zaretskii <eliz@gnu.org>
9180
9181 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
9182 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
9183 called at ZV.
9184
029529ac
CY
91852011-06-26 Chong Yidong <cyd@stupidchicken.com>
9186
9187 * process.c (wait_reading_process_output): Bypass select if
9188 waiting for a cell while ignoring keyboard input, and input is
9189 pending. Suggested by Jan Djärv (Bug#8869).
9190
7a7ef429
PE
91912011-06-25 Paul Eggert <eggert@cs.ucla.edu>
9192
9193 Use gnulib's dup2 module instead of rolling our own.
9194 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
9195
11fdef7d 91962011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
9197
9198 * dispnew.c (scrolling_window): Before scrolling, turn off a
9199 mouse-highlight in the window being scrolled.
9200
cd3520a4
JB
92012011-06-24 Juanma Barranquero <lekktu@gmail.com>
9202
9203 Move DEFSYM to lisp.h and use everywhere.
9204
9205 * character.h (DEFSYM): Move declaration...
9206 * lisp.h (DEFSYM): ...here.
9207
9208 * gnutls.c:
9209 * minibuf.c:
9210 * w32menu.c:
9211 * w32proc.c:
9212 * w32select.c: Don't include character.h.
9213
9214 * alloc.c (syms_of_alloc):
9215 * buffer.c (syms_of_buffer):
9216 * bytecode.c (syms_of_bytecode):
9217 * callint.c (syms_of_callint):
9218 * casefiddle.c (syms_of_casefiddle):
9219 * casetab.c (init_casetab_once):
9220 * category.c (init_category_once, syms_of_category):
9221 * ccl.c (syms_of_ccl):
9222 * cmds.c (syms_of_cmds):
9223 * composite.c (syms_of_composite):
9224 * dbusbind.c (syms_of_dbusbind):
9225 * dired.c (syms_of_dired):
9226 * dispnew.c (syms_of_display):
9227 * doc.c (syms_of_doc):
9228 * editfns.c (syms_of_editfns):
9229 * emacs.c (syms_of_emacs):
9230 * eval.c (syms_of_eval):
9231 * fileio.c (syms_of_fileio):
9232 * fns.c (syms_of_fns):
9233 * frame.c (syms_of_frame):
9234 * fringe.c (syms_of_fringe):
9235 * insdel.c (syms_of_insdel):
9236 * keymap.c (syms_of_keymap):
9237 * lread.c (init_obarray, syms_of_lread):
9238 * macros.c (syms_of_macros):
9239 * msdos.c (syms_of_msdos):
9240 * print.c (syms_of_print):
9241 * process.c (syms_of_process):
9242 * search.c (syms_of_search):
9243 * sound.c (syms_of_sound):
9244 * syntax.c (init_syntax_once, syms_of_syntax):
9245 * terminal.c (syms_of_terminal):
9246 * textprop.c (syms_of_textprop):
9247 * undo.c (syms_of_undo):
9248 * w32.c (globals_of_w32):
9249 * window.c (syms_of_window):
9250 * xdisp.c (syms_of_xdisp):
9251 * xfaces.c (syms_of_xfaces):
9252 * xfns.c (syms_of_xfns):
9253 * xmenu.c (syms_of_xmenu):
9254 * xsettings.c (syms_of_xsettings):
9255 * xterm.c (syms_of_xterm): Use DEFSYM.
9256
4228cf16
TZ
92572011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
9258
cd3520a4 9259 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 9260
7fcccf1e
PE
92612011-06-23 Paul Eggert <eggert@cs.ucla.edu>
9262
7efb4e0e
PE
9263 Integer and buffer overflow fixes (Bug#8873).
9264
ff5844ad
PE
9265 * print.c (printchar, strout): Check for string overflow.
9266 (PRINTPREPARE, printchar, strout):
9267 Don't set size unless allocation succeeds.
9268
90532f02
PE
9269 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
9270 for sizes. Check for string overflow more accurately.
9271 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
9272
6d84508d
PE
9273 * macros.c: Integer and buffer overflow fixes.
9274 * keyboard.h (struct keyboard.kbd_macro_bufsize):
9275 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
9276 Use ptrdiff_t, not int, for sizes.
9277 Don't increment bufsize until after realloc succeeds.
9278 Check for size-calculation overflow.
9279 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
9280
437b2cb4
PE
9281 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
9282
8b9ac8b4
PE
9283 * lread.c: Integer overflow fixes.
9284 (read_integer): Radix is now EMACS_INT, not int,
9285 to improve quality of diagnostics for out-of-range radices.
9286 Calculate buffer size correctly for out-of-range radices.
9287 (read1): Check for integer overflow in radices, and in
9288 read-circle numbers.
82cb60d3
PE
9289 (read_escape): Avoid int overflow.
9290 (Fload, openp, read_buffer_size, read1)
9291 (substitute_object_recurse, read_vector, read_list, map_obarray):
9292 Use ptrdiff_t, not int, for sizes.
9293 (read1): Use EMACS_INT, not int, for sizes.
20270765 9294 Check for size overflow.
8b9ac8b4 9295
7fcccf1e
PE
9296 * image.c (cache_image): Check for size arithmetic overflow.
9297
bfbbd7e7
PE
9298 * lread.c: Integer overflow issues.
9299 (saved_doc_string_size, saved_doc_string_length)
9300 (prev_saved_doc_string_size, prev_saved_doc_string_length):
9301 Now ptrdiff_t, not int.
9302 (read1): Don't assume doc string length fits in int. Check for
9303 out-of-range doc string lengths.
9304 (read_list): Don't assume file position fits in int.
39019e54 9305 (read_escape): Check for hex character overflow.
bfbbd7e7 9306
4e323265
LL
93072011-06-22 Leo Liu <sdl.web@gmail.com>
9308
9309 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
9310 Move to minibuffer.el.
9311
85fece3e
PE
93122011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9313
20b84ce9 9314 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
9315 The following patches are for when GLYPH_DEBUG && !XASSERT.
9316 * dispextern.h (trace_redisplay_p, dump_glyph_string):
9317 * dispnew.c (flush_stdout):
9318 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
9319 Mark as externally visible.
9320 * dispnew.c (check_window_matrix_pointers): Now static.
9321 * dispnew.c (window_to_frame_vpos):
9322 * xfns.c (unwind_create_frame):
9323 * xterm.c (x_check_font): Remove unused local.
9324 * scroll.c (CHECK_BOUNDS):
9325 * xfaces.c (cache_fache): Rename local to avoid shadowing.
9326 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
9327 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
9328 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
9329 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
9330 Now static.
9331 (debug_method_add): Use va_list and vsprintf rather than relying
9332 on undefined behavior with wrong number of arguments.
9333 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
9334 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
9335 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
9336 since we're not interested in debugging glyphs with old libraries.
9337 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
9338 GCC 4.6.0's static checking.
9339
0766b489
PE
93402011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9341
31fd4b32
PE
9342 Integer overflow and signedness fixes (Bug#8873).
9343 A few related buffer overrun fixes, too.
9344
b79e8648
PE
9345 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
9346
0766b489
PE
9347 * dispextern.h (struct face.stipple):
9348 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
9349 (x_bitmap_mask, x_allocate_bitmap_record)
9350 (x_create_bitmap_from_data, x_create_bitmap_from_file)
9351 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
9352 (x_create_bitmap_from_xpm_data):
9353 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
9354 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
9355 (.bitmaps_last):
9356 * xfaces.c (load_pixmap):
9357 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
9358 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
9359 (.bitmaps_last, struct x_output.icon_bitmap):
9360 Use ptrdiff_t, not int, for bitmap indexes.
9361 (x_allocate_bitmap_record): Check for size overflow.
9362 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
9363
b081724f
PE
9364 Use ptrdiff_t, not int, for overlay counts.
9365 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
9366 * editfns.c (overlays_around, get_pos_property):
9367 * textprop.c (get_char_property_and_overlay):
9368 * xdisp.c (next_overlay_change, note_mouse_highlight):
9369 * xfaces.c (face_at_buffer_position):
21514da7
PE
9370 * buffer.c (OVERLAY_COUNT_MAX): New macro.
9371 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
9372 (Fnext_overlay_change, Fprevious_overlay_change)
9373 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 9374 Use ptrdiff_t, not int, for sizes.
21514da7 9375 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 9376
3de73e5e
PE
9377 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
9378
2606c57b
PE
9379 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
9380 (x_session_initialize): Do not assume string length fits in int.
9381
aaafe47a
PE
9382 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
9383 This is unlikely, but can occur if DPI is outlandish.
9384
2674ddc8 9385 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
9386 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
9387
28154962
PE
9388 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
9389 * xrdb.c (magic_file_p, search_magic_path):
9390 Omit last arg SUFFIX; it was always 0. All callers changed.
9391 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
9392
7de51af5
PE
9393 * xfont.c (xfont_match): Avoid need for strlen.
9394
25ed6cc3
PE
9395 * xfns.c: Don't assume strlen fits in int.
9396 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
9397
4eab31dd
PE
9398 * xdisp.c (message_log_check_duplicate): Return intmax_t,
9399 not unsigned long, as we prefer signed integers. All callers changed.
9400 Detect integer overflow in repeat count.
9401 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 9402 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 9403
171e2a58
PE
9404 * termcap.c: Don't assume sizes fit in int and never overflow.
9405 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
9406 (gobble_line): Check for size-calculation overflow.
9407
ad39faca 9408 * minibuf.c (Fread_buffer):
6e5bb2dc 9409 * lread.c (intern, intern_c_string):
74ca2eb3
PE
9410 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
9411 Don't assume string length fits in int.
9412
52c61c22 9413 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
9414 * gtkutil.c (style_changed_cb): Avoid need for strlen.
9415
b5b8c9e5
PE
9416 * font.c: Don't assume string length fits in int.
9417 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
9418 Use ptrdiff_t, not int.
ccd6111c
PE
9419 (font_intern_prop): Don't assume string length fits in int.
9420 Don't assume integer property fits in fixnum.
9421 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 9422
882f0d81 9423 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 9424 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
9425 Reformulate so as not to need the command string.
9426 Invoke gzip -cd rather than gunzip, as it's more portable.
9427 (lock_info_type, lock_file_1, lock_file):
9428 Don't assume pid_t and time_t fit in unsigned long.
9429 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
9430 (current_lock_owner): Prefer signed type for sizes.
9431 Use memcpy, not strncpy, where memcpy is what is really wanted.
9432 Don't assume (via atoi) that time_t and pid_t fit in int.
9433 Check for time_t and/or pid_t out of range, e.g., via a network share.
9434 Don't alloca where an auto var works fine.
9435
93f4cf88
PE
9436 * fileio.c: Fix some integer overflow issues.
9437 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
9438 Don't assume string length fits in int.
9439 (directory_file_name): Don't assume string length fits in long.
9440 (make_temp_name): Don't assume pid fits in int, or that its print
9441 length is less than 20.
9442
f3e92b69
PE
9443 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
9444
1bfdaf10
PE
9445 * coding.c (make_subsidiaries): Don't assume string length fits in int.
9446
35016e9a
PE
9447 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
9448
3d1e65a1
PE
9449 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
9450 We prefer signed integers, even for size calculations.
9451
0b963a93
PE
9452 * emacs.c: Don't assume string length fits in 'int'.
9453 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
9454 (main): Don't invoke strlen when not needed.
9455
573f4b54
PE
9456 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
9457 (XD_DEBUG_MESSAGE): Don't waste a byte.
9458
989f33ba
PE
9459 * callproc.c (getenv_internal_1, getenv_internal)
9460 (Fgetenv_internal):
965d34eb
PE
9461 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
9462
e4d29b33
PE
9463 * lread.c (invalid_syntax): Omit length argument.
9464 All uses changed. This doesn't fix a bug, but it simplifies the
9465 code away from its former Hollerith-constant appearance, and it's
9466 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 9467 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 9468
eb49b136
PE
9469 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
9470 This didn't break anything, but it didn't help either.
9471 It's confusing to put a bogus integer in a place where the actual
9472 value does not matter.
9f62aeb1 9473 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 9474 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 9475
15375a22
PE
9476 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
9477 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
9478 implementation.
b61cc01c
PE
9479 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
9480 We prefer signed types, and the value cannot exceed the EMACS_INT
9481 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
9482 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
9483 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
9484 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 9485
53b2623d
PE
9486 * indent.c (sane_tab_width): New function.
9487 (current_column, scan_for_column, Findent_to, position_indentation)
9488 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 9489 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 9490
51cab52b 9491 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 9492
f2ed8a70
PE
9493 * lisp.h (lint_assume): New macro.
9494 * composite.c (composition_gstring_put_cache):
9495 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
9496
abe80cc6
PE
9497 * editfns.c, insdel.c:
9498 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 9499
b02c740e
PE
9500 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
9501
ebc96716
PE
9502 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
9503
b4e50fa0 9504 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 9505 Use much-faster test for byte-length change.
311d5d7c 9506 Don't assume string byte-length fits in 'int'.
a4cf38e4 9507 Check that character arg fits in 'int'.
85461888 9508 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 9509
c0c1ee9f
PE
9510 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
9511
a498d7f4
PE
9512 * fns.c (concat): Catch string overflow earlier.
9513 Do not rely on integer wraparound.
9514
51cab52b
PE
9515 * dispextern.h (struct it.overlay_strings_charpos)
9516 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
9517 * xdisp.c (forward_to_next_line_start)
9518 (back_to_previous_visible_line_start)
9519 (reseat_at_next_visible_line_start, next_element_from_buffer):
9520 Don't arbitrarily truncate the value of 'selective' to int.
9521
76031fad
PE
9522 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
9523
5eb55db9
PE
9524 * composite.c: Don't truncate sizes to 'int'.
9525 (composition_gstring_p, composition_reseat_it)
9526 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
9527 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
9528 not EMACS_UINT, for indexes.
5eb55db9 9529
0703a717
PE
9530 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
9531
d6202519
PE
9532 * buffer.c: Include <verify.h>.
9533 (struct sortvec.priority, struct sortstr.priority):
8961a454 9534 Now EMACS_INT, not int.
c20998a7 9535 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
9536 (struct sortstr.size, record_overlay_string)
9537 (struct sortstrlist.size, struct sortlist.used):
9538 Don't truncate size to int.
9539 (record_overlay_string): Check for size-calculation overflow.
d6202519 9540 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 9541
d5a19415
JM
95422011-06-22 Jim Meyering <meyering@redhat.com>
9543
029529ac 9544 Don't leak an XBM-image-sized buffer
d5a19415
JM
9545 * image.c (xbm_load): Free the image buffer after using it.
9546
a9041e6c
PE
95472011-06-21 Paul Eggert <eggert@cs.ucla.edu>
9548
9549 Port to Sun C.
9550 * composite.c (find_automatic_composition): Omit needless 'return 0;'
9551 that Sun C diagnosed.
9552 * fns.c (secure_hash): Fix pointer signedness issue.
9553 * intervals.c (static_offset_intervals): New function.
9554 (offset_intervals): Use it.
9555
7f3f739f
LL
95562011-06-21 Leo Liu <sdl.web@gmail.com>
9557
9558 * deps.mk (fns.o):
9559 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
9560 sha512.h.
9561
9562 * fns.c (secure_hash): Rename from crypto_hash_function and change
9563 the first arg to accept symbols.
5b66d427 9564 (Fsecure_hash): New primitive.
7f3f739f
LL
9565 (syms_of_fns): New symbols.
9566
76147d94
DD
95672011-06-20 Deniz Dogan <deniz@dogan.se>
9568
9569 * process.c (Fset_process_buffer): Clarify return value in
9570 docstring.
9571
7d7d0045
CY
95722011-06-18 Chong Yidong <cyd@stupidchicken.com>
9573
9574 * dispnew.c (add_window_display_history): Use BVAR.
9575
9576 * xdisp.c (debug_method_add): Use BVAR.
9577 (check_window_end, dump_glyph_matrix, dump_glyph)
9578 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
9579
9580 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
9581 Likewise.
9582
9583 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
9584 check till after the cache is created in init_frame_faces.
9585
ff2bc410
SM
95862011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
9587
9588 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
9589
28177add
PE
95902011-06-16 Paul Eggert <eggert@cs.ucla.edu>
9591
dd3482fe
PE
9592 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
9593 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
9594 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
9595
393d71f3 9596 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
9597 * fileio.c (Finsert_file_contents):
9598 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
9599 Remove the old (too-loose) buffer overflow checks.
9600 They weren't needed, since make_gap checks for buffer overflow.
9601 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
9602 The old code merely checked for Emacs fixnum overflow, and relied
9603 on undefined (wraparound) behavior. The new code avoids undefined
9604 behavior, and also checks for ptrdiff_t and/or size_t overflow.
9605
2e6813b0 9606 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
9607 Tune. Don't use wider integers than needed. Don't use alloca.
9608 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 9609
599a9e4f
PE
9610 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
9611
99561444
PE
9612 * insdel.c, lisp.h (buffer_overflow): New function.
9613 (insert_from_buffer_1, replace_range, replace_range_2):
9614 * insdel.c (make_gap_larger):
9615 * editfns.c (Finsert_char):
9616 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
9617
28177add
PE
9618 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
9619
e69dafad
PE
96202011-06-15 Paul Eggert <eggert@cs.ucla.edu>
9621
4baa020d 9622 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 9623
b1c46f02
PE
9624 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
9625 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
9626
e69dafad
PE
9627 * fileio.c: Don't assume EMACS_INT fits in off_t.
9628 (emacs_lseek): New static function.
9629 (Finsert_file_contents, Fwrite_region): Use it.
9630 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
9631
566684ea
PE
9632 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
9633
e6966cd6
PE
9634 * fns.c: Don't overflow int when computing a list length.
9635 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
9636 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
9637 truncation on 64-bit hosts. Check for QUIT every
9638 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
9639 faster and is responsive enough.
9640 (Flength): Report an error instead of overflowing an integer.
9641 (Fsafe_length): Return a float if the value is not representable
9642 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 9643 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 9644 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 9645
dd0b0efb
PE
9646 * alloc.c: Check that resized vectors' lengths fit in fixnums.
9647 (header_size, word_size): New constants.
9648 (allocate_vectorlike): Don't check size overflow here.
9649 (allocate_vector): Check it here instead, since this is the only
9650 caller of allocate_vectorlike that could cause overflow.
9651 Check that the new vector's length is representable as a fixnum.
9652
86fe5cfe
PE
9653 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
9654 The previous code was bogus. For example, next_almost_prime (32)
9655 returned 39, which is undesirable as it is a multiple of 3; and
9656 next_almost_prime (24) returned 25, which is a multiple of 5 so
9657 why was the code bothering to check for multiples of 7?
9658
80e88859
PE
9659 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
9660
4a2f0ad6
PE
9661 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
9662
f66c7cf8
PE
9663 Variadic C functions now count arguments with ptrdiff_t.
9664 This partly undoes my 2011-03-30 change, which replaced int with size_t.
9665 Back then I didn't know that the Emacs coding style prefers signed int.
9666 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
9667 were being counted with int, which may truncate counts on 64-bit
9668 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
9669 * lisp.h (struct Lisp_Subr.function.aMANY)
9670 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
9671 Arg counts are now ptrdiff_t, not size_t.
9672 All variadic functions and their callers changed accordingly.
9673 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
9674 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
9675 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
9676 * callint.c (Fcall_interactively): Check arg count for overflow,
9677 to avoid potential buffer overrun. Use signed char, not 'int',
9678 for 'varies' array, so that we needn't bother to check its size
9679 calculation for overflow.
9680 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
9681 * eval.c (apply_lambda):
9682 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
9683 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
9684 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
9685
a1759b76
PE
9686 * callint.c (Fcall_interactively): Don't use index var as event count.
9687
d96be9fc
PE
9688 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
9689 * mem-limits.h (SIZE): Remove; no longer used.
9690
a690a978 9691 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 9692
578c21e6
PE
9693 Remove unnecessary casts.
9694 * xterm.c (x_term_init):
9695 * xfns.c (x_set_border_pixel):
9696 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
9697 These aren't needed now that we assume ANSI C.
9698
96f53c6c
PE
9699 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
9700 It's more likely to cause problems (due to unsigned overflow)
9701 than to cure them.
9702
83c77d31
PE
9703 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
9704
ee2079f1
PE
9705 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
9706
6da65536
PE
9707 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
9708
7147c4a4
PE
9709 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
9710
193e32d9
PE
9711 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
9712
e5533da6
PE
9713 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
9714
9910e595
PE
9715 GLYPH_CODE_FACE returns EMACS_INT, not int.
9716 * dispextern.h (merge_faces):
9717 * xfaces.c (merge_faces):
01103c44
PE
9718 * xdisp.c (get_next_display_element, next_element_from_display_vector):
9719 Don't assume EMACS_INT fits in int.
9910e595 9720
2638320e
PE
9721 * character.h (CHAR_VALID_P): Remove unused parameter.
9722 * fontset.c, lisp.h, xdisp.c: All uses changed.
9723
045eb8d9
PE
9724 * editfns.c (Ftranslate_region_internal): Omit redundant test.
9725
c1f134b5
PE
9726 * fns.c (concat): Minor tuning based on overflow analysis.
9727 This doesn't fix any bugs. Use int to hold character, instead
9728 of constantly refetching from Emacs object. Use XFASTINT, not
9729 XINT, for value known to be a character. Don't bother comparing
9730 a single byte to 0400, as it's always less.
9731
395fcb93 9732 * floatfns.c (Fexpt):
327eeec8
PE
9733 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
9734
abbd3d23
PE
9735 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
9736 for characters.
9737
684a03ef
PE
9738 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
9739
0fed43f3
PE
9740 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
9741 Without this fix, on a 64-bit host (aset S 0 4294967386) would
9742 incorrectly succeed when S was a string, because 4294967386 was
9743 truncated before it was used.
9744
8fd02eb7
PE
9745 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
9746 Otherwise, an out-of-range integer could cause undefined behavior
9747 on a 64-bit host.
9748
f8c86b69
PE
9749 * composite.c: Use int, not EMACS_INT, for characters.
9750 (fill_gstring_body, composition_compute_stop_pos): Use int, not
9751 EMACS_INT, for values that are known to be in character range.
9752 This doesn't fix any bugs but is the usual style inside Emacs and
9753 may generate better code on 32-bit machines.
9754
34206dd2
PE
9755 Make sure a 64-bit char is never passed to ENCODE_CHAR.
9756 This is for reasons similar to the recent CHAR_STRING fix.
9757 * charset.c (Fencode_char): Check that character arg is actually
9758 a character. Pass an int to ENCODE_CHAR.
9759 * charset.h (ENCODE_CHAR): Verify that the character argument is no
9760 wider than 'int', as a compile-time check to prevent future regressions
9761 in this area.
9762
c5958d4c 9763 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
9764
9765 Make sure a 64-bit char is never passed to CHAR_STRING.
9766 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
9767 by silently ignoring the top 32 bits, allowing some values
9768 that were far too large to be valid characters.
9769 * character.h: Include <verify.h>.
9770 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
9771 arguments are no wider than unsigned, as a compile-time check
9772 to prevent future regressions in this area.
9773 * data.c (Faset):
01103c44 9774 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
9775 (Fsubst_char_in_region):
9776 * fns.c (concat):
9777 * xdisp.c (decode_mode_spec_coding):
9778 Adjust to CHAR_STRING's new requirement.
9779 * editfns.c (Finsert_char, Fsubst_char_in_region):
9780 * fns.c (concat): Check that character args are actually
9781 characters. Without this test, these functions did the wrong
9782 thing with wildly out-of-range values on 64-bit hosts.
9783
d37ca623
PE
9784 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
9785 These casts should not be needed on 32-bit hosts, either.
9786 * keyboard.c (read_char):
9787 * lread.c (Fload): Remove casts to unsigned.
9788
ea204efb
PE
9789 * lisp.h (UNSIGNED_CMP): New macro.
9790 This fixes comparison bugs on 64-bit hosts.
9791 (ASCII_CHAR_P): Use it.
9792 * casefiddle.c (casify_object):
01103c44 9793 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
9794 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
9795 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
9796 * dispextern.h (FACE_FROM_ID):
9797 * keyboard.c (read_char): Use UNSIGNED_CMP.
9798
41cb286c
PE
9799 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
9800 not to EMACS_INT, to avoid GCC warning.
9801
4a1b9832
PE
9802 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
9803
55daad71
PE
9804 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
9805 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
9806 isn't needed on 32-bit machines.
8f95c75c 9807
01103c44
PE
9808 * buffer.c (Fgenerate_new_buffer_name):
9809 Use EMACS_INT for count, not int.
0ceccced 9810 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
9811
9812 * data.c (Qcompiled_function): Now static.
9813
c6f072e7
PE
9814 * window.c (window_body_lines): Now static.
9815
20ce5912
PE
9816 * image.c (gif_load): Rename local to avoid shadowing.
9817
9c4c5f81
PE
9818 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
9819 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
9820 * alloc.c (make_save_value): Integer argument is now of type
9821 ptrdiff_t, not int.
9822 (mark_object): Use ptrdiff_t, not int.
9823 * lisp.h (pD): New macro.
9824 * print.c (print_object): Use it.
9825
c0c5c8ae
PE
9826 * alloc.c: Use EMACS_INT, not int, to count objects.
9827 (total_conses, total_markers, total_symbols, total_vector_size)
9828 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
9829 (total_free_floats, total_floats, total_free_intervals)
9830 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
9831 Now EMACS_INT, not int. All uses changed.
9832 (Fgarbage_collect): Compute overall total using a double, so that
9833 integer overflow is less likely to be a problem. Check for overflow
9834 when converting back to an integer.
5a25e253
PE
9835 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
9836 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
9837 These were 'int' variables that could overflow on 64-bit hosts;
9838 they were never used, so remove them instead of repairing them.
211a0b2a 9839 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
9840 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
9841 Previously, this ceilinged at INT_MAX, but that doesn't work on
9842 64-bit machines.
e46bb31a 9843 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 9844
c78baabf 9845 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 9846 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
9847 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
9848 when a (possibly-narrower) signed value would do just as well.
9849 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 9850
c9d624c6
PE
9851 * alloc.c: Catch some string size overflows that we were missing.
9852 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
9853 for convenience in STRING_BYTES_MAX.
9854 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
9855 The definition here is exact; the one in lisp.h was approximate.
9856 (allocate_string_data): Check for string overflow. This catches
9857 some instances we weren't catching before. Also, it catches
9858 size_t overflow on (unusual) hosts where SIZE_MAX <= min
9859 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
9860 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 9861
c9d624c6
PE
9862 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
9863 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 9864 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 9865
353032ce
PE
9866 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
9867
2bccce07
PE
9868 * alloc.c (Fmake_string): Check for out-of-range init.
9869
0ac30604
SM
98702011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
9871
9872 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
9873
c195f2de
JD
98742011-06-14 Jan Djärv <jan.h.d@swipnet.se>
9875
9876 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
9877 xg_get_default_scrollbar_width.
9878
9879 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
9880 (int_gtk_range_get_value): Move to the scroll bar part of the file.
9881 (style_changed_cb): Call update_theme_scrollbar_width and call
9882 x_set_scroll_bar_default_width and xg_frame_set_char_size for
9883 all frames (Bug#8505).
9884 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
9885 Call gtk_window_set_resizable if HAVE_GTK3.
9886 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
9887 and height if HAVE_GTK3 (Bug#8505).
9888 (scroll_bar_width_for_theme): New variable.
9889 (update_theme_scrollbar_width): New function.
9890 (xg_get_default_scrollbar_width): Move code to
9891 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
9892 (xg_initialize): Call update_theme_scrollbar_width.
9893
9894 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
9895
9896 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
9897
e10ac9f1
MR
98982011-06-12 Martin Rudalics <rudalics@gmx.at>
9899
9900 * frame.c (make_frame): Call other_buffer_safely instead of
9901 other_buffer.
9902
9903 * window.c (temp_output_buffer_show): Call display_buffer with
9904 second argument Vtemp_buffer_show_specifiers and reset latter
9905 immediately after the call.
9906 (Vtemp_buffer_show_specifiers): New variable.
9907 (auto_window_vscroll_p, next_screen_context_lines)
9908 (Vscroll_preserve_screen_position): Remove leading asterisks from
9909 doc-strings.
9910
2d3c217e 99112011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 9912
7b7f97e8 9913 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
9914 * buffer.c (Qclone_number): Remove for now, as it's unused.
9915 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
9916 (record_buffer): Remove unused local.
9917 * frame.c (other_visible_frames, frame_buffer_list): Now static.
9918 (set_frame_buffer_list): Remove; unused.
9919 * frame.h (other_visible_frames): Remove decl.
9920 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
9921 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
9922 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
9923 if HAVE_GPM.
9924 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
9925 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
9926 Define only if HAVE_GPM.
9927 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
9928 (update_hints_inhibit): Remove; never set. All uses removed.
9929 * widgetprv.h (emacsFrameClassRec): Remove decl.
9930 * window.c (delete_deletable_window): Now returns void, since it
9931 wasn't returning anything.
9932 (compare_window_configurations): Remove unused locals.
9933 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
9934 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
9935 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
9936 the same widths as pointers. This follows up on the 2011-05-06 patch.
9937 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
9938 * xterm.h: Likewise.
9939 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
9940
1384b89e
JB
99412011-06-12 Juanma Barranquero <lekktu@gmail.com>
9942
9943 * makefile.w32-in: Update dependencies.
9944 (LISP_H): Add lib/intprops.h.
9945
1100a63c
CY
99462011-06-11 Chong Yidong <cyd@stupidchicken.com>
9947
9948 * image.c (gif_load): Add animation frame delay to the metadata.
9949 (syms_of_image): Use DEFSYM. New symbol `delay'.
9950
6198ccd0
MR
99512011-06-11 Martin Rudalics <rudalics@gmx.at>
9952
9953 * window.c (delete_deletable_window): Re-add.
9954 (Fset_window_configuration): Rewrite to handle dead buffers and
9955 consequently deletable windows.
9956 (window_tree, Fwindow_tree): Remove. Supply functionality in
9957 window.el.
9958 (compare_window_configurations): Simplify code.
9959
b6e3633c
AS
99602011-06-11 Andreas Schwab <schwab@linux-m68k.org>
9961
1ab0dee5
AS
9962 * image.c (imagemagick_load_image): Fix type mismatch.
9963 (Fimagemagick_types): Likewise.
9964
b6e3633c
AS
9965 * window.h (replace_buffer_in_windows): Declare.
9966
9397e56f
MR
99672011-06-11 Martin Rudalics <rudalics@gmx.at>
9968
9969 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
9970 Qclone_number. Remove external declaration of Qdelete_window.
9971 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
9972 code.
640c8776
SM
9973 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
9974 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
9975 (Fother_buffer): Rewrite doc-string. Major rewrite for new
9976 buffer list implementation.
9977 (other_buffer_safely): New function.
9978 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
9979 calls to replace_buffer_in_windows and
9980 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
9981 if allowed.
9982 (record_buffer): Inhibit quitting and rewrite using quittable
9983 functions. Run Qbuffer_list_update_hook if allowed.
9984 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
9985 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
9986 Move switch-to-buffer to window.el.
9397e56f
MR
9987 (bury-buffer): Move to window.el.
9988 (Vbuffer_list_update_hook): New variable.
9989
9990 * lisp.h (other_buffer_safely): Add prototype in buffer.c
9991 section.
9992
9993 * window.h (resize_frame_windows): Move up in code.
9994 (Fwindow_frame): Remove EXFUN.
9995 (replace_buffer_in_all_windows): Remove prototype.
9996 (replace_buffer_in_windows_safely): Add prototype.
9997
9998 * window.c: Declare Qdelete_window static again. Move down
9999 declaration of select_count.
10000 (Fnext_window, Fprevious_window): Rewrite doc-strings.
10001 (Fother_window): Move to window.el.
10002 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
10003 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
10004 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
10005 window.el.
10006 (replace_buffer_in_windows): Implement by calling
10007 Qreplace_buffer_in_windows.
10008 (replace_buffer_in_all_windows): Remove with some functionality
10009 moved into replace_buffer_in_windows_safely.
10010 (replace_buffer_in_windows_safely): New function.
10011 (select_window_norecord, select_frame_norecord): Move in front
10012 of run_window_configuration_change_hook. Remove now obsolete
10013 declarations.
640c8776
SM
10014 (Fset_window_buffer): Rewrite doc-string.
10015 Call Qrecord_window_buffer.
9397e56f
MR
10016 (keys_of_window): Move binding for other-window to window.el.
10017
b50691aa
CY
100182011-06-11 Chong Yidong <cyd@stupidchicken.com>
10019
10020 * dispextern.h (struct image): Replace data member, whose int_val
10021 and ptr_val fields were not used by anything, with a single
10022 lisp_val object.
10023
10024 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
10025 (gif_clear_image, gif_load, imagemagick_load_image)
10026 (gs_clear_image, gs_load): Callers changed.
10027
3f754b86
PE
100282011-06-10 Paul Eggert <eggert@cs.ucla.edu>
10029
cca69397
PE
10030 * buffer.h: Include <time.h>, for time_t.
10031 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
10032
109e28d0
PE
10033 Fix minor problems found by static checking.
10034
60737f02
PE
10035 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
10036
4b66faf3
PE
10037 Make identifiers static if they are not used in other modules.
10038 * data.c (Qcompiled_function, Qframe, Qvector):
10039 * image.c (QimageMagick, Qsvg):
10040 * minibuf.c (Qmetadata):
10041 * window.c (resize_window_check, resize_root_window): Now static.
10042 * window.h (resize_window_check, resize_root_window): Remove decls.
10043
109e28d0
PE
10044 * window.c (window_deletion_count, delete_deletable_window):
10045 Remove; unused.
46a4ce9e
PE
10046 (window_body_lines): Now static.
10047 (Fdelete_other_windows_internal): Mark vars as initialized.
10048 Make sure 'resize_failed' is initialized.
10049 (run_window_configuration_change_hook): Rename local to avoid shadowing.
10050 (resize_window_apply): Remove unused local.
10051 * window.h (delete_deletable_window): Remove decl.
10052
109e28d0 10053 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
10054 (imagemagick_load_image): Fix pointer signedness problem by changing
10055 last arg from unsigned char * to char *. All uses changed.
10056 Also, fix a local for similar reasons.
10057 Remove unused locals. Remove locals to avoid shadowing.
10058 (fn_rsvg_handle_free): Remove; unused.
10059 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 10060 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 10061
3f754b86
PE
10062 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
10063
2547adb1
CY
100642011-06-10 Chong Yidong <cyd@stupidchicken.com>
10065
10066 * image.c (gif_load): Fix omitted cast error introduced by
10067 2011-06-06 change.
10068
2c8e37d4
MR
100692011-06-10 Martin Rudalics <rudalics@gmx.at>
10070
10071 * window.h (resize_proportionally, orig_total_lines)
10072 (orig_top_line): Remove from window structure.
10073 (set_window_height, set_window_width, change_window_heights)
10074 (Fdelete_window): Remove prototypes.
10075 (resize_frame_windows): Remove duplicate declaration.
10076
440a42e3
EZ
100772011-06-10 Eli Zaretskii <eliz@gnu.org>
10078
10079 * window.h (resize_frame_windows, resize_window_check)
10080 (delete_deletable_window, resize_root_window)
10081 (resize_frame_windows): Declare prototypes.
10082
10083 * window.c (resize_window_apply): Make definition be "static" to
10084 match the prototype.
10085
562dd5e9
MR
100862011-06-10 Martin Rudalics <rudalics@gmx.at>
10087
10088 * window.c: Remove declarations of Qwindow_size_fixed,
10089 window_min_size_1, window_min_size_2, window_min_size,
10090 size_window, window_fixed_size_p, enlarge_window, delete_window.
10091 Remove static from declaration of Qdelete_window, it's
10092 temporarily needed by Fbury_buffer.
10093 (replace_window): Don't assign orig_top_line and
10094 orig_total_lines.
10095 (Fdelete_window, delete_window): Remove. Window deletion is
10096 handled by window.el.
640c8776
SM
10097 (window_loop): Remove DELETE_OTHER_WINDOWS case.
10098 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
10099 (Fdelete_other_windows): Remove. Deleting other windows is
10100 handled by window.el.
10101 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
10102 handled in window.el.
10103 (window_min_size_2, window_min_size_1, window_min_size): Remove.
10104 Window minimum sizes are handled in window.el.
10105 (shrink_windows, size_window, set_window_height)
10106 (set_window_width, change_window_heights, window_height)
10107 (window_width, CURBEG, CURSIZE, enlarge_window)
10108 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
10109 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
10110 handled in window.el.
10111 (make_dummy_parent): Rename to make_parent_window and give it a
10112 second argument horflag.
10113 (make_window): Don't set resize_proportionally any more.
10114 (Fsplit_window): Remove. Windows are split in window.el.
10115 (save_restore_action, save_restore_orig_size)
10116 (shrink_window_lowest_first, save_restore_orig_size): Remove.
10117 Resize mini windows in window.el.
10118 (grow_mini_window, shrink_mini_window): Implement by calling
10119 Qresize_root_window_vertically, resize_window_check and
10120 resize_window_apply.
640c8776
SM
10121 (saved_window, Fset_window_configuration, save_window_save):
10122 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
10123 resize_proportionally.
10124 (window_min_height, window_min_width): Move to window.el.
10125 (keys_of_window): Move bindings for delete-other-windows,
10126 split-window, delete-window and enlarge-window to window.el.
10127
10128 * buffer.c: Temporarily extern Qdelete_window.
10129 (Fbury_buffer): Temporarily call Qdelete_window instead of
10130 Fdelete_window (Fbury_buffer will move to window.el soon).
10131
10132 * frame.c (set_menu_bar_lines_1): Remove code handling
10133 orig_top_line and orig_total_lines.
10134
10135 * dispnew.c (adjust_frame_glyphs_initially): Don't use
10136 set_window_height but set heights directly.
10137 (change_frame_size_1): Use resize_frame_windows.
10138
10139 * xdisp.c (init_xdisp): Don't use set_window_height but set
10140 heights directly.
10141
640c8776
SM
10142 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
10143 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
10144 run_window_configuration_change_hook.
10145
10146 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
10147 instead of change_window_heights and run
10148 run_window_configuration_change_hook.
10149
1a13852e
MR
101502011-06-09 Martin Rudalics <rudalics@gmx.at>
10151
10152 * window.c (replace_window): Rename second argument REPLACEMENT to
10153 NEW. New third argument SETFLAG. Rewrite.
10154 (delete_window, make_dummy_parent): Call replace_window with
10155 third argument 1.
10156 (window_list_1): Move down in code.
10157 (run_window_configuration_change_hook): Move set_buffer part
10158 before select_frame_norecord part in order to unwind correctly.
10159 Rename count1 to count.
10160 (recombine_windows, delete_deletable_window, resize_root_window)
10161 (Fdelete_other_windows_internal)
10162 (Frun_window_configuration_change_hook, make_parent_window)
10163 (resize_window_check, resize_window_apply, Fresize_window_apply)
10164 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
10165 (Fdelete_window_internal, Fresize_mini_window_internal):
10166 New functions.
1a13852e
MR
10167 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
10168
f3d1777e
MR
101692011-06-08 Martin Rudalics <rudalics@gmx.at>
10170
496e208e
MR
10171 * window.h (window): Add some new members to window structure -
10172 normal_lines, normal_cols, new_total, new_normal, clone_number,
10173 splits, nest, prev_buffers, next_buffers.
10174 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 10175 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 10176
f3d1777e
MR
10177 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
10178 Remove.
496e208e
MR
10179 (make_dummy_parent): Set new members of windows structure.
10180 (make_window): Move down in code. Handle new members of window
10181 structure.
10182 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
10183 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
10184 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
10185 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
10186 (Fset_window_next_buffers, Fset_window_clone_number):
10187 New functions.
496e208e
MR
10188 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
10189 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
10190 Doc-string fixes.
10191 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
10192 Argument WINDOW can be now internal window too.
10193 (Fwindow_use_time): Move up in code.
10194 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
10195 Rewrite doc-string.
10196 (Fset_window_configuration, saved_window)
10197 (Fcurrent_window_configuration, save_window_save): Handle new
10198 members of window structure.
b9e809c2
MR
10199 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
10200 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
10201 (syms_of_window): New Lisp objects Qrecord_window_buffer,
10202 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
10203 Qget_mru_window, Qresize_root_window,
10204 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
10205 Qauto_buffer_name; staticpro them.
f3d1777e 10206
abde8f8c
MR
102072011-06-07 Martin Rudalics <rudalics@gmx.at>
10208
10209 * window.c (Fwindow_total_size, Fwindow_left_column)
10210 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
10211 (Fwindow_list_1): New functions.
10212 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
10213 (Fwindow_width, Fscroll_left, Fscroll_right):
10214 Use window_body_cols instead of window_box_text_cols.
10215 (delete_window, Fset_window_configuration):
10216 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
10217 (delete_all_subwindows): Take a window as argument and not a
10218 structure. Rewrite.
190b47e6
MR
10219 (window_loop): Remove handling of GET_LRU_WINDOW and
10220 GET_LARGEST_WINDOW.
10221 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
10222
10223 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
10224 window_box_text_cols. delete_all_subwindows now takes a
10225 Lisp_Object as argument.
abde8f8c 10226
640c8776
SM
10227 * indent.c (compute_motion, Fcompute_motion):
10228 Use window_body_cols instead of window_box_text_cols.
abde8f8c 10229
fa8a67e6
MR
10230 * frame.c (delete_frame): Call delete_all_subwindows with root
10231 window as argument.
10232
a54e3482
DC
102332011-06-07 Daniel Colascione <dan.colascione@gmail.com>
10234
10235 * fns.c (Fputhash): Document return value.
10236
60002bf5
CY
102372011-06-06 Chong Yidong <cyd@stupidchicken.com>
10238
10239 * image.c (gif_load): Implement gif89a spec "no disposal" method.
10240
0c671da6 102412011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 10242
b862a52a 10243 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 10244
be44ca6c
PE
10245 Check for overflow when converting integer to cons and back.
10246 * charset.c (Fdefine_charset_internal, Fdecode_char):
10247 Use cons_to_unsigned to catch overflow.
10248 (Fencode_char): Use INTEGER_TO_CONS.
10249 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
10250 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
10251 * data.c (long_to_cons, cons_to_long): Remove.
10252 (cons_to_unsigned, cons_to_signed): New functions.
10253 These signal an error for invalid or out-of-range values.
10254 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
10255 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
10256 * font.c (Ffont_variation_glyphs):
10257 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
10258 * lisp.h: Include <intprops.h>.
10259 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
10260 (cons_to_signed, cons_to_unsigned): New decls.
10261 (long_to_cons, cons_to_long): Remove decls.
10262 * undo.c (record_first_change): Use INTEGER_TO_CONS.
10263 (Fprimitive_undo): Use CONS_TO_INTEGER.
10264 * xfns.c (Fx_window_property): Likewise.
10265 * xselect.c: Include <limits.h>.
10266 (x_own_selection, selection_data_to_lisp_data):
10267 Use INTEGER_TO_CONS.
10268 (x_handle_selection_request, x_handle_selection_clear)
10269 (x_get_foreign_selection, Fx_disown_selection_internal)
10270 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
10271 (lisp_data_to_selection_data): Use cons_to_unsigned.
10272 (x_fill_property_data): Use cons_to_signed.
10273 Report values out of range.
10274
d1f3d2af
PE
10275 Check for buffer and string overflow more precisely.
10276 * buffer.h (BUF_BYTES_MAX): New macro.
10277 * lisp.h (STRING_BYTES_MAX): New macro.
10278 * alloc.c (Fmake_string):
10279 * character.c (string_escape_byte8):
10280 * coding.c (coding_alloc_by_realloc):
10281 * doprnt.c (doprnt):
10282 * editfns.c (Fformat):
10283 * eval.c (verror):
10284 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
10285 since they may not be the same number.
10286 * editfns.c (Finsert_char):
10287 * fileio.c (Finsert_file_contents):
10288 Likewise for BUF_BYTES_MAX.
10289
dd52fcea
PE
10290 * image.c: Use ptrdiff_t, not int, for sizes.
10291 (slurp_file): Switch from int to ptrdiff_t.
10292 All uses changed.
10293 (slurp_file): Check that file size fits in both size_t (for
10294 malloc) and ptrdiff_t (for sanity and safety).
10295
7f9bbdbb
PE
10296 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
10297 if b->modtime has its maximal value.
10298
dfe18f82
PE
10299 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
10300
84acfcf0
PE
10301 Don't assume time_t can fit into int.
10302 * buffer.h (struct buffer.modtime): Now time_t, not int.
10303 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
10304 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
10305
ccd9a01a
PE
10306 Minor fixes for signed vs unsigned integers.
10307 * character.h (MAYBE_UNIFY_CHAR):
10308 * charset.c (maybe_unify_char):
10309 * keyboard.c (read_char, reorder_modifiers):
10310 XINT -> XFASTINT, since the integer must be nonnegative.
10311 * ftfont.c (ftfont_spec_pattern):
10312 * keymap.c (access_keymap, silly_event_symbol_error):
10313 XUINT -> XFASTINT, since the integer must be nonnegative.
10314 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
10315 since it makes no difference and we prefer signed.
10316 * keyboard.c (record_char): Use XUINT when all the neighbors do.
10317 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
10318 nonnegative.
10319
d6d100dd
SM
103202011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
10321
10322 * window.h (Fwindow_frame): Declare.
10323
2b6148e4
PE
103242011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10325
10326 * alloc.c: Simplify handling of large-request failures (Bug#8800).
10327 (SPARE_MEMORY): Always define.
10328 (LARGE_REQUEST): Remove.
10329 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
10330
f230ecc9
MR
103312011-06-06 Martin Rudalics <rudalics@gmx.at>
10332
727e958e
MR
10333 * lisp.h: Move EXFUNS for Fframe_root_window,
10334 Fframe_first_window and Fset_frame_selected_window to window.h.
10335
10336 * window.h: Move EXFUNS for Fframe_root_window,
10337 Fframe_first_window and Fset_frame_selected_window here from
10338 lisp.h.
10339
10340 * frame.c (Fwindow_frame, Fframe_first_window)
10341 (Fframe_root_window, Fframe_selected_window)
10342 (Fset_frame_selected_window): Move to window.c.
10343 (Factive_minibuffer_window): Move to minibuf.c.
10344 (Fother_visible_frames_p): New function.
10345
10346 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
10347
f230ecc9
MR
10348 * window.c (decode_window, decode_any_window): Move up in code.
10349 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
10350 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
10351 (Fwindow_buffer): Move up and rewrite doc-string.
10352 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
10353 (Fwindow_prev): New functions.
727e958e
MR
10354 (Fwindow_frame): Move here from frame.c. Accept any window as
10355 argument.
10356 (Fframe_root_window, Fframe_first_window)
10357 (Fframe_selected_window): Move here from frame.c. Accept frame
10358 or arbitrary window as argument. Update doc-strings.
10359 (Fminibuffer_window): Move up in code.
10360 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
10361 (Fset_frame_selected_window): Move here from frame.c.
10362 Marginal rewrite.
727e958e
MR
10363 (Fselected_window, select_window, Fselect_window): Move up in
10364 code. Minor doc-string fixes.
f230ecc9 10365
4d09bcf6
PE
103662011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10367
10368 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
10369 Do not assume that spare memory exists; that assumption is valid
10370 only if SYSTEM_MALLOC.
10371 (LARGE_REQUEST): New macro, so that the issue of large requests
10372 is separated from the issue of spare memory.
10373
810928a2
AS
103742011-06-05 Andreas Schwab <schwab@linux-m68k.org>
10375
172418ad
AS
10376 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
10377 format. (Bug#8806)
10378
43f862f7
AS
10379 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
10380
810928a2
AS
10381 * xfns.c (x_set_scroll_bar_default_width): Move declarations
10382 before statements.
10383
a059fe24
JD
103842011-06-05 Jan Djärv <jan.h.d@swipnet.se>
10385
10386 * gtkutil.c (xg_get_default_scrollbar_width): New function.
10387
10388 * gtkutil.h: Declare xg_get_default_scrollbar_width.
10389
10390 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
10391 min width by calling x_set_scroll_bar_default_width (Bug#8505).
10392
989bf368
JB
103932011-06-05 Juanma Barranquero <lekktu@gmail.com>
10394
10395 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
10396
4b80f674
CY
103972011-06-04 Chong Yidong <cyd@stupidchicken.com>
10398
10399 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
10400 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
10401 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
10402 New error handlers.
4b80f674
CY
10403 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
10404 Obey Vx_select_enable_clipboard_manager. Catch errors in
10405 x_clipboard_manager_save (Bug#8779).
10406 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 10407 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 10408
99a33b77 104092011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
10410
10411 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
10412
99a33b77 104132011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
10414
10415 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
10416 in the current matrix if keep_current_p is non-zero.
10417
8264569d
EZ
104182011-06-04 Eli Zaretskii <eliz@gnu.org>
10419
10420 * bidi.c (bidi_level_of_next_char): Fix last change.
10421
57f97249
EZ
104222011-06-03 Eli Zaretskii <eliz@gnu.org>
10423
fec2107c 10424 Support bidi reordering of text covered by display properties.
57f97249 10425
fec2107c
EZ
10426 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
10427 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
10428 (bidi_cache_search, bidi_cache_iterator_state)
10429 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
10430 (bidi_level_of_next_char, bidi_move_to_visually_next):
10431 Support character positions inside a run of characters covered by a
fec2107c
EZ
10432 display string.
10433 (bidi_paragraph_init, bidi_resolve_explicit_1)
10434 (bidi_level_of_next_char): Call bidi_fetch_char and
10435 bidi_fetch_char_advance instead of FETCH_CHAR and
10436 FETCH_CHAR_ADVANCE.
10437 (bidi_init_it): Initialize new members.
10438 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
10439 definitions.
10440 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
10441 instead of using explicit *_CHAR codes.
d6d100dd
SM
10442 (bidi_resolve_explicit, bidi_resolve_weak):
10443 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
10444 bidirectional text is supported only in multibyte buffers.
10445 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
10446 it to initialize the frame_window_p member of struct bidi_it.
10447 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
10448 (bidi_resolve_explicit, bidi_resolve_weak)
10449 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
10450 bidi_it->nchars is non-positive.
10451 (bidi_level_of_next_char): Don't try to lookup the cache for the
10452 next/previous character if nothing is cached there yet, or if we
10453 were just reseat()'ed to a new position.
c40e2fb2 10454
0e14fe90
EZ
10455 * xdisp.c (set_cursor_from_row): Set start and stop points
10456 according to the row's direction when priming the loop that looks
10457 for the glyph on which to display cursor.
10458 (single_display_spec_intangible_p): Function deleted.
10459 (display_prop_intangible_p): Reimplement to call
10460 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
10461 Accept 3 additional arguments needed by handle_display_spec.
10462 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
10463 values: lists, `(when COND...)' forms, etc.
10464 (single_display_spec_string_p): Support property values that are
10465 lists with the argument STRING its top-level element.
10466 (display_prop_string_p): Fix the condition for processing a
10467 property that is a list to be consistent with handle_display_spec.
fec2107c 10468 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
10469 last portion of handle_display_prop.
10470 (compute_display_string_pos): Accept additional argument
10471 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
10472 value of a `display' property is a "replacing spec".
10473 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
10474 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
10475 the display property, but just return a value indicating whether
10476 the display property will replace the characters it covers.
10477 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
10478 frame_window_p members of struct bidi_it.
d6d100dd
SM
10479 (compute_display_string_pos, compute_display_string_end):
10480 New functions.
fec2107c
EZ
10481 (push_it): Accept second argument POSITION, where pop_it should
10482 jump to continue iteration.
10483 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 10484
fec2107c
EZ
10485 * keyboard.c (adjust_point_for_property): Adjust the call to
10486 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
10487
10488 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
10489 (bidi_init_it): Update prototypes.
10490 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
10491 (compute_display_string_pos, compute_display_string_end):
10492 Declare prototypes.
fec2107c
EZ
10493 (struct bidi_it): New members nchars and disp_pos. ch_len is now
10494 EMACS_INT.
fc6f18ce 10495
40087514 104962011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 10497
57f53182
PE
10498 Malloc failure behavior now depends on size of allocation.
10499 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
10500 * lisp.h: Change signatures accordingly.
10501 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
10502 All callers changed. (Bug#8762)
10503
10504 * gnutls.c: Use Emacs's memory allocators.
10505 Without this change, the gnutls library would invoke malloc etc.
10506 directly, which causes problems on non-SYNC_INPUT hosts, and which
10507 runs afoul of improving memory_full behavior. (Bug#8761)
10508 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
10509 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
10510 xfree instead of the default malloc, realloc, free.
10511 (Fgnutls_boot): No need to check for memory allocation failure,
10512 since xmalloc does that for us.
10513
ac32cd99 10514 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
10515 * category.c (hash_get_category_set):
10516 * ccl.c (ccl_driver):
10517 * charset.c (Fdefine_charset_internal):
10518 * charset.h (struct charset.hash_index):
10519 * composite.c (get_composition_id, gstring_lookup_cache)
10520 (composition_gstring_put_cache):
10521 * composite.h (struct composition.hash_index):
10522 * dispextern.h (struct image.hash):
10523 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
10524 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
10525 (hashfn_equal, hashfn_user_defined, make_hash_table)
10526 (maybe_resize_hash_table, hash_lookup, hash_put)
10527 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
10528 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
10529 (Fsxhash, Fgethash, Fputhash, Fmaphash):
10530 * image.c (make_image, search_image_cache, lookup_image)
10531 (xpm_put_color_table_h):
10532 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 10533 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 10534 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 10535 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
10536 * alloc.c (allocate_vectorlike):
10537 Check for overflow in vector size calculations.
10538 * ccl.c (ccl_driver):
10539 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
10540 * fns.c, image.c: Remove unnecessary static decls that would otherwise
10541 need to be updated by these changes.
40087514
PE
10542 * fns.c (make_hash_table, maybe_resize_hash_table):
10543 Check for integer overflow with large hash tables.
0de4bb68
PE
10544 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
10545 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
10546 (SXHASH_REDUCE): New macro.
10547 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
10548 Use it instead of discarding useful hash info with large hash values.
10549 (sxhash_float): New function.
10550 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
10551 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
10552 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
10553 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
10554 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
10555 Adjust signatures to match updated version of code.
10556 (consing_since_gc): Now EMACS_INT, since a single hash table can
10557 use more than INT_MAX bytes.
10558
698d32e2
DN
105592011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
10560
10561 Make it possible to build with GCC-4.6+ -O2 -flto.
10562
10563 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
10564
fd6fa53f
SM
105652011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
10566
10567 * minibuf.c (get_minibuffer, read_minibuf_unwind):
10568 Call minibuffer-inactive-mode.
10569
864db017
JB
105702011-05-31 Juanma Barranquero <lekktu@gmail.com>
10571
10572 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
10573 Update dependencies.
10574
2ad0baf4
DN
105752011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10576
10577 * data.c (init_data): Remove code for UTS, this system is not
10578 supported anymore.
10579
4fcc2638
DN
105802011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10581
10582 Don't force ./temacs to start in terminal mode.
10583
10584 * frame.c (make_initial_frame): Initialize faces in all cases, not
10585 only when CANNOT_DUMP is defined.
10586 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
10587
c56e0fd5
DN
105882011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10589
10590 * dispnew.c (add_window_display_history): Use const for the string
10591 pointer. Remove declaration, not needed.
10592
333d54da 105932011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 10594
55d4c1b2 10595 Use 'inline', not 'INLINE'.
333d54da 10596 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
10597 * alloc.c, fontset.c (INLINE): Remove.
10598 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
10599 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
10600 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
10601 * gmalloc.c (register_heapinfo): Use inline unconditionally.
10602 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
10603
738db178
DN
106042011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10605
10606 Make it possible to run ./temacs.
10607
10608 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
10609 syms_of_callproc does the same thing. Remove test for
10610 "initialized", do it in the caller.
10611 * emacs.c (main): Avoid calling set_initial_environment when dumping.
10612
620c53a6
SM
106132011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
10614
10615 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
10616 (read_minibuf): Use get_minibuffer.
10617 (syms_of_minibuf): Use DEFSYM.
10618 (Qmetadata): New var.
10619 * data.c (Qbuffer): Don't make it static.
10620 (syms_of_data): Use DEFSYM.
10621
e003a292
PE
106222011-05-31 Paul Eggert <eggert@cs.ucla.edu>
10623
10624 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
10625 (CCL_CODE_MIN): New macro.
10626
ed008a6d
PE
106272011-05-30 Paul Eggert <eggert@cs.ucla.edu>
10628
3687c2ef
PE
10629 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
10630
ed008a6d
PE
10631 * eval.c (Qdebug): Now static.
10632 * lisp.h (Qdebug): Remove decl. This reverts a part of the
10633 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
10634 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
10635
d66c4c7c
CY
106362011-05-29 Chong Yidong <cyd@stupidchicken.com>
10637
10638 * image.c: Various fixes to ImageMagick code comments.
10639 (Fimagemagick_types): Doc fix.
10640
5fbc2025
PE
106412011-05-29 Paul Eggert <eggert@cs.ucla.edu>
10642
0196f88a
PE
10643 Minor fixes prompted by GCC 4.6.0 warnings.
10644
10645 * xselect.c (converted_selections, conversion_fail_tag): Now static.
10646
5fbc2025
PE
10647 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
10648 (x_clipboard_manager_save_all): Move extern decl to ...
10649 * xterm.h: ... here, so that it can be checked for consistency.
10650
1dd3c2d9
CY
106512011-05-29 Chong Yidong <cyd@stupidchicken.com>
10652
10653 * xselect.c (x_clipboard_manager_save_frame)
10654 (x_clipboard_manager_save_all): New functions.
10655 (Fx_clipboard_manager_save): Lisp function deleted.
10656
10657 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
10658 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
10659
10660 * xterm.h: Update prototype.
10661
5ba6571d
WX
106622011-05-28 William Xu <william.xwl@gmail.com>
10663
10664 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
10665 exiting (Bug#8239).
10666
3eaff834
JM
106672011-05-28 Jim Meyering <meyering@redhat.com>
10668
e1900994 10669 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
10670 * fns.c (to_uchar): Define.
10671 (crypto_hash_function): Use it to convert some newly-signed
10672 variables to unsigned, to avoid sign-extension bugs. For example,
10673 without this change, (md5 "truc") would evaluate to
10674 45723a2aff78ff4fff7fff1114760e62 rather than the expected
10675 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 10676 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 10677
0f6990a7
PE
106782011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10679
10680 Integer overflow fixes.
c8a9ca5a 10681
08686060
PE
10682 * dbusbind.c: Serial number integer overflow fixes.
10683 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
10684 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
10685 to hold a serial number that is too large for a fixnum.
10686 (Fdbus_method_return_internal, Fdbus_method_error_internal):
10687 Check for serial numbers out of range. Decode any serial number
59568bf0 10688 that was so large that it became a float. (Bug#8722)
08686060 10689
2d1fc3c7
PE
10690 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
10691 (Fdbus_call_method, Fdbus_call_method_asynchronously):
10692 Use XFASTINT rather than XUINT when numbers are nonnegative.
10693 (xd_append_arg, Fdbus_method_return_internal):
10694 (Fdbus_method_error_internal): Likewise. Also, for unsigned
10695 arguments, check that Lisp number is nonnegative, rather than
59568bf0 10696 silently wrapping negative numbers around. (Bug#8722)
30217ff0 10697 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 10698 (Bug#8722)
2d1fc3c7 10699
c8a9ca5a
PE
10700 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
10701
519e1d69
PE
10702 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
10703
6df6ae42 10704 ccl: Add integer overflow checks.
30569699
PE
10705 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
10706 (IN_INT_RANGE): New macros.
10707 (ccl_driver): Use them to check for integer overflow when
10708 decoding a CCL program. Many of the new checks are whether XINT (x)
10709 fits in int; it doesn't always, on 64-bit hosts. The new version
10710 doesn't catch all possible integer overflows, but it's an
847044ea 10711 improvement. (Bug#8719)
30569699 10712
c11285dc
PE
10713 * alloc.c (make_event_array): Use XINT, not XUINT.
10714 There's no need for unsigned here.
10715
fdccd48e
PE
10716 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
10717 This follows up to the 2011-05-06 change that substituted uintptr_t
10718 for EMACS_INT. This case wasn't caught back then.
10719
37910ab2
PE
10720 Rework Fformat to avoid integer overflow issues.
10721 * editfns.c: Include <float.h> unconditionally, as it's everywhere
10722 now (part of C89). Include <verify.h>.
10723 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
10724 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
10725 (Fformat): Avoid the prepass trying to compute sizes; it was only
10726 approximate and thus did not catch overflow reliably. Instead, walk
10727 through the format just once, formatting and computing sizes as we go,
10728 checking for integer overflow at every step, and allocating a larger
10729 buffer as needed. Keep track separately whether the format is
10730 multibyte. Keep only the most-recently calculated precision, rather
10731 than them all. Record whether each argument has been converted to
10732 string. Use EMACS_INT, not int, for byte and char and arg counts.
10733 Support field widths and precisions larger than INT_MAX. Avoid
10734 sprintf's undefined behavior with conversion specifications such as %#d
10735 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
10736 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
10737 formatting out-of-range floating point numbers with int
9173deec 10738 formats. (Bug#8668)
37910ab2 10739
2e6578fb
PE
10740 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
10741
0ae6bdee
PE
10742 * data.c: Avoid integer truncation in expressions involving floats.
10743 * data.c: Include <intprops.h>.
10744 (arith_driver): When there's an integer overflow in an expression
10745 involving floating point, convert the integers to floating point
10746 so that the resulting value does not suffer from catastrophic
10747 integer truncation. For example, on a 64-bit host (* 4
10748 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
10749 Do not rely on undefined behavior after integer overflow.
10750
de883a70
PE
10751 merge count_size_as_multibyte, parse_str_to_multibyte
10752 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 10753 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
10754 Check for integer overflow.
10755 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
10756 since it's now a duplicate of the other. This is more of
10757 a character than a buffer op, so better that it's in character.c.
10758 * fns.c, print.c: Adjust to above changes.
10759
2ff916cb
PE
107602011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
10761
10762 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
10763
f1b54466
PE
107642011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10765
fb1ac845
PE
10766 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10767 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
10768 (x_clipboard_manager_save): Now static.
10769 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
10770
f1b54466
PE
10771 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10772 (crypto_hash_function): Now static.
10773 Fix pointer signedness problems. Avoid unnecessary initializations.
10774
a9f737ee
CY
107752011-05-27 Chong Yidong <cyd@stupidchicken.com>
10776
10777 * termhooks.h (Vselection_alist): Make it terminal-local.
10778
10779 * terminal.c (create_terminal): Initialize it.
10780
10781 * xselect.c: Support for clipboard managers.
10782 (Vselection_alist): Move to termhooks.h as terminal-local var.
10783 (LOCAL_SELECTION): New macro.
10784 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
10785 (symbol_to_x_atom): Remove gratuitous arg.
10786 (x_handle_selection_request, lisp_data_to_selection_data)
10787 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
10788 (x_own_selection, x_get_local_selection, x_convert_selection):
10789 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
10790 (some_frame_on_display): Delete unused function.
10791 (Fx_own_selection_internal, Fx_get_selection_internal)
10792 (Fx_disown_selection_internal, Fx_selection_owner_p)
10793 (Fx_selection_exists_p): New optional frame arg.
10794 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
10795 (x_handle_selection_clear): Don't treat other terminals with the
10796 same keyboard specially. Use the terminal-local Vselection_alist.
10797 (x_clear_frame_selections): Use Frun_hook_with_args.
10798
10799 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
10800
10801 * xterm.h: Add support for those atoms.
10802
e067f0c1
CY
108032011-05-26 Chong Yidong <cyd@stupidchicken.com>
10804
10805 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
10806 (converted_selections, conversion_fail_tag): New global variables.
10807 (x_selection_request_lisp_error): Free the above.
10808 (x_get_local_selection): Remove unnecessary code.
10809 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
10810 of converted selections stored in converted_selections.
10811 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
10812 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
10813 (x_convert_selection): New function.
10814 (x_handle_selection_event): Simplify.
10815 (x_get_foreign_selection): Don't ignore incoming requests while
10816 waiting for an answer; this will fail when we implement
10817 SAVE_TARGETS, and seems unnecessary anyway.
10818 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
10819 (Vx_sent_selection_functions): Doc fix.
10820
0f4aebc0
LL
108212011-05-26 Leo Liu <sdl.web@gmail.com>
10822
10823 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
10824
e61124cd
YM
108252011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10826
10827 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
10828
10829 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
10830 for fringe update if it has periodic bitmap.
ac389d0c 10831 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
10832 and fringe_bitmap_periodic_p.
10833
10834 * fringe.c (get_fringe_bitmap_data): New function.
10835 (draw_fringe_bitmap_1, update_window_fringes): Use it.
10836 (update_window_fringes): Record periodicity of fringe bitmap in glyph
10837 row. Mark glyph row for fringe update if periodicity changed.
10838
10839 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
10840 for fringe update unless it has periodic bitmap.
10841
f16d9837
KH
108422011-05-25 Kenichi Handa <handa@m17n.org>
10843
10844 * xdisp.c (get_next_display_element): Set correct it->face_id for
10845 a static composition.
10846
e1b90ef6
LL
108472011-05-24 Leo Liu <sdl.web@gmail.com>
10848
10849 * deps.mk (fns.o):
10850 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
10851
10852 * fns.c (crypto_hash_function, Fsha1): New function.
10853 (Fmd5): Use crypto_hash_function.
10854 (syms_of_fns): Add Ssha1.
10855
7400048f
PE
108562011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10857
10858 * gnutls.c: Remove unused macros.
10859 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
10860 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
10861 Remove macros that are defined and never used.
10862 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
10863
abb71cf4
CY
108642011-05-22 Chong Yidong <cyd@stupidchicken.com>
10865
10866 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
10867 (Fx_get_selection_internal): Minor cleanup.
10868 (Fx_own_selection_internal): Rename arguments for consistency with
10869 select.el.
10870
6307db39
PE
108712011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10872
10873 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
10874
f3d4e0a4
CY
108752011-05-22 Chong Yidong <cyd@stupidchicken.com>
10876
10877 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
10878
4d8ade89
YM
108792011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10880
10881 * dispnew.c (scrolling_window): Don't exclude the case that the
10882 last enabled row in the desired matrix touches the bottom boundary.
10883
32078c8d
GM
108842011-05-21 Glenn Morris <rgm@gnu.org>
10885
10886 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
10887 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
10888 and add some more files.
32078c8d 10889
7285dc67
EZ
108902011-05-20 Eli Zaretskii <eliz@gnu.org>
10891
10892 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
10893 report_file_error introduced by the change from 2011-05-07.
10894
89d1bd22
PE
108952011-05-20 Paul Eggert <eggert@cs.ucla.edu>
10896
10897 * systime.h (Time): Define only if emacs is defined.
10898 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
10899 where the include path doesn't have X11/X.h by default. See
10900 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
10901
cd394be1 109022011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
10903
10904 * composite.c (find_automatic_composition): Fix previous change.
10905
b9704ad9
GM
109062011-05-20 Glenn Morris <rgm@gnu.org>
10907
10908 * lisp.mk: New file, split from Makefile.in.
10909 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
10910 (shortlisp): Remove.
10911 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
10912
4a720484
GM
109132011-05-19 Glenn Morris <rgm@gnu.org>
10914
10915 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
10916 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
10917 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
10918 (lisp): Set the order to that of loadup.el.
10919 (shortlisp): Make it a copy of $lisp.
10920 (SOME_MACHINE_LISP): Remove.
10921 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
10922 Use just $shortlisp, not $SOME_MACHINE_LISP too.
10923
a28d4396
KH
109242011-05-18 Kenichi Handa <handa@m17n.org>
10925
10926 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
10927 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
10928 (find_automatic_composition): Mostly rewrite for efficiency.
10929
a2b1fa8e
JB
109302011-05-18 Juanma Barranquero <lekktu@gmail.com>
10931
10932 * makefile.w32-in: Update dependencies.
10933
8e1f5610
CS
109342011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
10935
10936 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 10937 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 10938
7025ee00 109392011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 10940
cdfa6eab
PE
10941 Fix some integer overflow issues, such as string length overflow.
10942
06d6db33
PE
10943 * insdel.c (count_size_as_multibyte): Check for string overflow.
10944
2b4560a8
PE
10945 * character.c (lisp_string_width): Check for string overflow.
10946 Use EMACS_INT, not int, for string indexes and lengths; in
10947 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
10948 the resulting string length overflows an EMACS_INT; instead,
10949 report a string overflow if no precision given. When checking for
10950 precision exhaustion, use a check that cannot possibly have
10951 integer overflow. (Bug#8675)
10952 * character.h (lisp_string_width): Adjust to new signature.
10953
cb93f9be
PE
10954 * alloc.c (string_overflow): New function.
10955 (Fmake_string): Use it. This doesn't change behavior, but saves
10956 a few bytes and will simplify future changes.
10957 * character.c (string_escape_byte8): Likewise.
10958 * lisp.h (string_overflow): New decl.
10959
1a1f3366
PE
10960 Fixups, following up to the user-interface timestamp change.
10961 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
10962 for UI timestamps, instead of unsigned long.
9fbd6841
PE
10963 * msdos.c (mouse_get_pos): Likewise.
10964 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
10965 * w32gui.h (Time): Define by including "systime.h" rather than by
10966 declaring it ourselves. (Bug#8664)
10967
d4e3e4d3
PE
10968 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
10969 * image.c (clear_image_cache): Likewise.
10970
f6a24d19
PE
10971 * term.c (term_mouse_position): Don't assume time_t wraparound.
10972
08dc5ae6
PE
10973 Be more systematic about user-interface timestamps.
10974 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
10975 and sometimes 'EMACS_UINT', to represent these timestamps.
10976 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
10977 This makes the code easier to follow, and makes it easier to catch
10978 integer overflow bugs such as Bug#8664.
10979 * frame.c (Fmouse_position, Fmouse_pixel_position):
10980 Use Time, not unsigned long, for user-interface timestamps.
10981 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
10982 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
10983 * keyboard.h (last_event_timestamp): Likewise.
10984 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
10985 * menu.h (xmenu_show): Likewise.
10986 * term.c (term_mouse_position): Likewise.
10987 * termhooks.h (struct input_event.timestamp): Likewise.
10988 (struct terminal.mouse_position_hook): Likewise.
10989 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
10990 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
10991 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
10992 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
10993 what it was before.
10994 * menu.h, termhooks.h: Include "systime.h", for Time.
10995
8e55734a
PE
10996 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
10997 Don't assume that the difference between two unsigned long values
10998 can fit into an integer. At this point, we know button_down_time
10999 <= event->timestamp, so the difference must be nonnegative, so
11000 there's no need to cast the result if double-click-time is
11001 nonnegative, as it should be; check that it's nonnegative, just in
11002 case. This bug is triggered when events are more than 2**31 ms
86db42d2 11003 apart (about 25 days). (Bug#8664)
8e55734a 11004
841f1b75 11005 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 11006 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 11007
3e26f69c
PE
11008 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
11009 that always fit in int. Use a sentinel instead of a counter, to
11010 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
11011 * frame.h (struct frame): Use int for menu_bar_items_used
11012 instead of EMACS_INT, since it always fits in int.
3e26f69c 11013
5cc152c0
PE
11014 * menu.c (grow_menu_items): Check for int overflow.
11015
d89eb65e
PE
11016 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
11017
5235bd3e
PE
11018 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
11019 Before, the code was not consistent. These values cannot exceed
11020 2**31 - 1 so there's no need to make them unsigned.
11021 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
11022 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
11023 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
11024 as modifiers.
11025 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
11026
bc827e23
PE
11027 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
11028 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
11029 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
11030 presumably because the widths might not match.
11031
78eb494e
PE
11032 * window.c (size_window): Avoid needless test at loop start.
11033
04f2d78b
CB
110342011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
11035
11036 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
11037
d2fc7e3d 110382011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
11039
11040 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
11041
d2fc7e3d 110422011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
11043
11044 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
11045 `width' to `bar_area_x' and `bar_area_width', respectively.
11046 (x_scroll_run): Take account of fringe background extension.
11047
04f2d78b
CB
11048 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
11049 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
11050 `bar_area_width', respectively.
11051 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
11052 background extension.
11053
79b70037
GM
110542011-05-10 Jim Meyering <meyering@redhat.com>
11055
11056 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
11057
2f142cc5
JB
110582011-05-10 Juanma Barranquero <lekktu@gmail.com>
11059
11060 * image.c (Finit_image_library): Return t for built-in image types,
11061 like pbm and xbm. (Bug#8640)
11062
57679c86
AS
110632011-05-09 Andreas Schwab <schwab@linux-m68k.org>
11064
11065 * w32menu.c (set_frame_menubar): Fix submenu allocation.
11066
888c9e86
EZ
110672011-05-07 Eli Zaretskii <eliz@gnu.org>
11068
b0512a1d
EZ
11069 * w32console.c (Fset_screen_color): Doc fix.
11070 (Fget_screen_color): New function.
11071 (syms_of_ntterm): Defsubr it.
11072
7285dc67
EZ
11073 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
11074 unlink the temporary file if Fcall_process didn't create it in the
11075 first place.
11076 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
11077 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
11078 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
11079 cue to call_process_cleanup not to close that handle.
11080
4d3fcc8e
BK
110812011-05-07 Ben Key <bkey76@gmail.com>
11082
11083 * makefile.w32-in: The bootstrap-temacs rule now makes use of
11084 one of two shell specific rules, either bootstrap-temacs-CMD or
11085 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
11086 to the previous implementation of the bootstrap-temacs rule.
11087 The bootstrap-temacs-CMD rule is similar to the previous
11088 implementation of the bootstrap-temacs rule except that it
11089 makes use of the ESC_CFLAGS variable instead of the CFLAGS
11090 variable.
11091
11092 These changes, along with some changes to nt/configure.bat,
11093 nt/gmake.defs, and nt/nmake.defs, are required to extend my
11094 earlier fix to add support for --cflags and --ldflags options
11095 that include quotes so that it works whether make uses cmd or
11096 sh as the shell.
11097
b4289b64
MA
110982011-05-06 Michael Albinus <michael.albinus@gmx.de>
11099
11100 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
11101 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
11102 is a constant.
11103 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
11104 a string. Handle both cases.
11105 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
11106 (Fdbus_register_method): Use Qinvalid_function.
11107
af4c0e28
JB
111082011-05-06 Juanma Barranquero <lekktu@gmail.com>
11109
11110 * makefile.w32-in: Update dependencies.
11111 (LISP_H): Add inttypes.h and stdin.h.
11112 (PROCESS_H): Add unistd.h.
11113
c51453d9
EZ
111142011-05-06 Eli Zaretskii <eliz@gnu.org>
11115
11116 * lread.c: Include limits.h (fixes the MS-Windows build broken by
11117 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
11118
8ff0ac3c 111192011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 11120
4c4b566b
PE
11121 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
11122
aab2b9b5
PE
11123 * term.c (vfatal): Remove stray call to va_end.
11124 It's not needed and the C Standard doesn't allow it here anyway.
11125
c378da0b
PE
11126 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
11127 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
11128
288b08c7
PE
11129 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
11130 bytes.
11131
e3601888
PE
11132 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
11133
db6c0e74
PE
11134 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
11135
dd5963ea
PE
11136 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
11137
88c9450f
PE
11138 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
11139
2f9442b8
PE
11140 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
11141
c032b5f8
PE
11142 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
11143 * charset.c (Fdefine_charset_internal): Don't initialize
11144 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 11145 32-bit int (Bug#8600).
a108c10b
PE
11146
11147 * lread.c (read_integer): Be more consistent with string-to-number.
11148 Use string_to_number to do the actual conversion; this avoids
11149 rounding errors and fixes some other screwups. Without this fix,
11150 for example, #x1fffffffffffffff was misread as -2305843009213693952.
11151 (digit_to_number): Move earlier, for benefit of read_integer.
11152 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 11153 not a digit in any supported base. (Bug#8602)
a108c10b 11154
ad5f9eea
PE
11155 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
11156
aec1708a
PE
11157 * dispnew.c (scrolling_window): Return 1 if we scrolled,
11158 to match comment at start of function. This also removes a
11159 GCC warning about overflow in a 32+64-bit port.
11160
47be4ab5
PE
11161 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
11162
371cac43
PE
11163 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
11164 Reported by Stefan Monnier in
11165 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
11166 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11167 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 11168
d01a7826
PE
11169 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
11170 (EMACS_UINTPTR): Likewise, with uintptr_t.
11171
7fd47d5c
PE
11172 * lisp.h: Prefer 64-bit EMACS_INT if available.
11173 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
11174 on 32-bit hosts that have 64-bit int, so that they can access
11175 large files.
122b0c86
PE
11176 However, temporarily disable this change unless the temporary
11177 symbol WIDE_EMACS_INT is defined.
7fd47d5c 11178
8727937b
PE
11179 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
11180
8ac068ac
PE
11181 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
11182 This removes an assumption that EMACS_INT and long are the same
11183 width as pointers. The assumption is true for Emacs porting targets
11184 now, but we want to make other targets possible.
11185 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
11186 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
11187 In the rest of the code, change types of integers that hold casted
11188 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
11189 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
11190 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
11191 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
11192 No need to cast type when ORing.
11193 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
11194 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
11195 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
11196 assume EMACS_INT is the same width as char *.
11197 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
11198 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
11199 Remove no-longer-needed casts.
11200 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
11201 (xg_tool_bar_help_callback, xg_make_tool_item):
11202 Use EMACS_INTPTR to hold an integer
11203 that will be cast to void *; this can avoid a GCC warning
11204 if EMACS_INT is not the same width as void *.
11205 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
11206 * xdisp.c (display_echo_area_1, resize_mini_window_1):
11207 (current_message_1, set_message_1):
11208 Use a local to convert to proper width without a cast.
11209 * xmenu.c (dialog_selection_callback): Likewise.
11210
ede49d71
PE
11211 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
11212 Also, don't assume VALBITS / RAND_BITS is less than 5,
11213 and don't rely on undefined behavior when shifting a 1 left into
11214 the sign bit.
11215 * lisp.h (get_random): Change signature to match.
11216
2f30ecd0
PE
11217 * lread.c (hash_string): Use size_t, not int, for hash computation.
11218 Normally we prefer signed values; but hashing is special, because
11219 it's better to use unsigned division on hash table sizes so that
11220 the remainder is nonnegative. Also, size_t is the natural width
11221 for hashing into memory. The previous code used 'int', which doesn't
11222 retain enough info to hash well into very large tables.
11223 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
11224
2a866e7b
PE
11225 * dbusbind.c: Don't possibly lose pointer info when converting.
11226 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11227 Use XPNTR rather than XHASH, so that the high-order bits of
11228 the pointer aren't lost when converting through void *.
11229
51639eac
PE
11230 * eval.c (Fautoload): Don't double-shift a pointer.
11231
92394119
PE
11232 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
11233
dbdb9a7c
JB
112342011-05-06 Juanma Barranquero <lekktu@gmail.com>
11235
11236 * gnutls.c (DEF_GNUTLS_FN):
11237 * image.c (DEF_IMGLIB_FN): Make function pointers static.
11238
db7a0b4f
AS
112392011-05-05 Andreas Schwab <schwab@linux-m68k.org>
11240
11241 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
11242 marker. (Bug#8610)
11243
cd394be1 112442011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
11245
11246 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
11247 New version that can reserve upto 2GB of heap space.
11248
f7ff1b0f 112492011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
11250
11251 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
11252
639c109b
TZ
112532011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
11254
11255 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
11256 `gnutls_certificate_set_x509_key_file'.
11257
d2127135
JB
112582011-05-05 Juanma Barranquero <lekktu@gmail.com>
11259
11260 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
11261 Update dependencies.
11262
e968f4f3
JB
112632011-05-04 Juanma Barranquero <lekktu@gmail.com>
11264
11265 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
11266 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
11267 Remove unused parameter `fildes'.
11268 * process.c (read_process_output, send_process): Don't pass it.
11269
84d358f0
JB
112702011-05-04 Juanma Barranquero <lekktu@gmail.com>
11271
11272 Fix previous change: the library cache is defined in w32.c.
11273 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
11274 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
11275
0898ca10
JB
112762011-05-04 Juanma Barranquero <lekktu@gmail.com>
11277
11278 Implement dynamic loading of GnuTLS on Windows.
11279
11280 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
11281 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
11282 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11283 Declare.
11284
11285 * gnutls.c (Qgnutls_dll): Define.
11286 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
11287 (gnutls_*): Declare function pointers.
11288 (init_gnutls_functions): New function to initialize function pointers.
11289 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
11290 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
11291 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11292 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
11293 (emacs_gnutls_write, emacs_gnutls_read)
11294 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
11295 (Fgnutls_available_p): New function.
11296 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
11297 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
11298 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
11299
11300 * image.c: Include w32.h.
11301 (Vimage_type_cache): Delete.
11302 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
11303 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
11304 (w32_delayed_load): Move to w32.c.
11305
11306 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
11307
11308 * w32.c (QCloaded_from, Vlibrary_cache): Define.
11309 (w32_delayed_load): Move from image.c. When loading a library, record
11310 its filename in the :loaded-from property of the library id.
11311 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
11312 Initialize and staticpro them.
11313 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
11314
11315 * process.c: Include lisp.h before w32.h, not after.
11316 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
11317 instead of gnutls_record_check_pending.
11318
11319 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
11320
ff4de4aa
TZ
113212011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
11322
11323 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
11324 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
11325 as passed in.
11326
abe95abb
JD
113272011-05-03 Jan Djärv <jan.h.d@swipnet.se>
11328
11329 * xterm.c (x_set_frame_alpha): Do not set property on anything
11330 else than FRAME_X_OUTER_WINDOW (Bug#8608).
11331
e16e55d4
JB
113322011-05-02 Juanma Barranquero <lekktu@gmail.com>
11333
11334 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
11335
bafcf6a5
JB
113362011-05-02 Juanma Barranquero <lekktu@gmail.com>
11337
11338 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
11339 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
11340 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
11341 (gnutls_global_initialized, Qgnutls_bootprop_priority)
11342 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
11343 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
11344 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
11345 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
11346 (Qgnutls_bootprop_callbacks_verify): Make static.
11347
e7a6747f
AS
113482011-05-01 Andreas Schwab <schwab@linux-m68k.org>
11349
19ed11ba
AS
11350 * callproc.c: Indentation fixup.
11351
e7a6747f 11352 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
11353 (wait_for_termination, interruptible_wait_for_termination):
11354 Move after wait_for_termination_1.
e7a6747f 11355
1ef14cb4
LMI
113562011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
11357
11358 * sysdep.c (interruptible_wait_for_termination): New function
11359 which is like wait_for_termination, but allows keyboard
11360 interruptions.
11361
11362 * callproc.c (Fcall_process): Add (:file "file") as an option for
11363 the STDOUT buffer.
11364 (Fcall_process_region): Ditto.
11365
330d880c
EZ
113662011-04-30 Eli Zaretskii <eliz@gnu.org>
11367
8db90b73
EZ
11368 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
11369 rather than `XVECTOR (FOO)->size'.
11370
330d880c
EZ
11371 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
11372 inttypes.h, as a gnulib replacement is used if it not available in
11373 system headers.
11374
15cbd324
EZ
113752011-04-21 Eli Zaretskii <eliz@gnu.org>
11376
11377 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
11378 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
11379 of MOST_POSITIVE_FIXNUM. (Bug#8528)
11380
11381 * coding.c (coding_alloc_by_realloc): Error out if destination
11382 will grow beyond MOST_POSITIVE_FIXNUM.
11383 (decode_coding_emacs_mule): Abort if there isn't enough place in
11384 charbuf for the composition carryover bytes. Reserve an extra
11385 space for up to 2 characters produced in a loop.
11386 (decode_coding_iso_2022): Abort if there isn't enough place in
11387 charbuf for the composition carryover bytes.
11388
113892011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 11390
ae940cca
EZ
11391 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
11392 aborting when %lld or %lll format is passed.
11393 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
11394 %llo or %llx format is passed. (Bug#8545)
11395
03ab8921
EZ
11396 * window.c (window_scroll_line_based): Use a marker instead of
11397 simple variables to record original value of point. (Bug#7952)
11398
afda1437
EZ
11399 * doprnt.c (doprnt): Fix the case where a multibyte sequence
11400 produced by %s or %c overflows available buffer space. (Bug#8545)
11401
f76dee0c
PE
114022011-04-28 Paul Eggert <eggert@cs.ucla.edu>
11403
11404 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 11405 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 11406
fdc5744d
JB
114072011-04-28 Juanma Barranquero <lekktu@gmail.com>
11408
11409 * w32.c (init_environment): Warn about defaulting HOME to C:\.
11410
638f053a
JB
114112011-04-28 Juanma Barranquero <lekktu@gmail.com>
11412
11413 * keyboard.c (Qdelayed_warnings_hook): Define.
11414 (command_loop_1): Run `delayed-warnings-hook'
11415 if Vdelayed_warnings_list is non-nil.
11416 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
11417 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
11418
d178f871
EZ
114192011-04-28 Eli Zaretskii <eliz@gnu.org>
11420
11421 * doprnt.c (doprnt): Don't return value smaller than the buffer
11422 size if the message was truncated. (Bug#8545).
11423
b124fd93
JB
114242011-04-28 Juanma Barranquero <lekktu@gmail.com>
11425
11426 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
11427 (Fx_window_property): #if-0 the whole functions, not just the bodies.
11428
e810457d
PE
114292011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11430
11431 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
11432
ea51cceb
JB
114332011-04-27 Juanma Barranquero <lekktu@gmail.com>
11434
11435 * makefile.w32-in: Update dependencies.
11436
94dcfacf
EZ
114372011-04-27 Eli Zaretskii <eliz@gnu.org>
11438
11439 Improve `doprnt' and its usage. (Bug#8545)
11440 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
11441 `format_end'. Remove support for %l as a conversion specifier.
11442 Don't use xrealloc. Improve diagnostics when the %l size modifier
11443 is used. Update the commentary.
11444
11445 * eval.c (verror): Simplify calculation of size_t.
11446
11447 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
11448 messages.
11449
f61f41d7
PE
114502011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
11451
11452 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
11453 change.
11454
96fb4434
PE
114552011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11456
11457 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
11458 This makes this file independent of the recent pseudovector change.
11459
671875da 114602011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 11461
69e9b5a3
PE
11462 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
11463
b5f869a7 11464 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 11465 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 11466 Remove unused local.
c8926152 11467 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 11468
841a1577 11469 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
11470 GCC 4.6.0 optimizes based on type-based alias analysis.
11471 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
11472 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
11473 != &v->size, and therefore "v->size = 1; b->size = 2; return
11474 v->size;" must therefore return 1. This assumption is incorrect
11475 for Emacs, since it type-puns struct Lisp_Vector * with many other
11476 types. To fix this problem, this patch adds a new type struct
f904488f 11477 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
11478 and pseudovectors, and helps optimizing compilers not get fooled
11479 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
11480 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
11481 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
11482 the size member.
eab3844f
PE
11483 (XSETPVECTYPE): Rewrite in terms of new macro.
11484 (XSETPVECTYPESIZE): New macro, specifying both type and size.
11485 This is a bit clearer, and further avoids the possibility of
11486 undesirable aliasing.
11487 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 11488 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
11489 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
11490 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
11491 (ASIZE): Now uses header.size rather than size.
11492 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
11493 to avoid the hassle of writing XVECTOR (foo)->header.size.
11494 (struct vectorlike_header): New type.
eab3844f
PE
11495 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
11496 object, to help avoid aliasing.
11497 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
11498 (SUBRP): Likewise, since Lisp_Subr is a special case.
11499 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
11500 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
11501 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 11502 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
11503 changed to be "header.size" and "header.next".
11504 * buffer.h (struct buffer): Likewise.
11505 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
11506 * frame.h (struct frame): Likewise.
11507 * process.h (struct Lisp_Process): Likewise.
11508 * termhooks.h (struct terminal): Likewise.
11509 * window.c (struct save_window_data, struct saved_window): Likewise.
11510 * window.h (struct window): Likewise.
11511 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
11512 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
11513 * buffer.c (init_buffer_once): Likewise.
11514 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
11515 special case.
11516 * process.c (Fformat_network_address): Use local var for size,
11517 for brevity.
11518
0df1eac5
PE
11519 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
11520
847ab9d1 11521 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
11522 * data.c (atof): Remove decl; no longer used or needed.
11523 (digit_to_number): Move to lread.c.
11524 (Fstring_to_number): Use new string_to_number function, to be
11525 consistent with how the Lisp reader treats infinities and NaNs.
11526 Do not assume that floating-point numbers represent EMACS_INT
11527 without losing information; this is not true on most 64-bit hosts.
11528 Avoid double-rounding errors, by insisting on integers when
11529 parsing non-base-10 numbers, as the documentation specifies.
11530 * lisp.h (string_to_number): New decl, replacing ...
11531 (isfloat_string): Remove.
bc0a5c13 11532 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 11533 (read1): Do not accept +. and -. as integers; this
452f4150
PE
11534 appears to have been a coding error. Similarly, do not accept
11535 strings like +-1e0 as floating point numbers. Do not report
11536 overflow for integer overflows unless the base is not 10 which
11537 means we have no simple and reliable way to continue.
11538 Break out the floating-point parsing into a new
11539 function string_to_number, so that Fstring_to_number parses
11540 floating point numbers consistently with the Lisp reader.
04f2d78b 11541 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
11542 (E_CHAR, EXP_INT): Remove, replacing with ...
11543 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
11544 (string_to_number): New function, replacing isfloat_string.
11545 This function checks for valid syntax and produces the resulting
11546 Lisp float number too. Rework it so that string-to-number
bc0a5c13 11547 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
11548 so that overflow for non-base-10 numbers is reported only when
11549 there's no portable and simple way to convert to floating point.
452f4150 11550
67769ffc
PE
11551 * textprop.c (set_text_properties_1): Rewrite for clarity,
11552 and to avoid GCC warning about integer overflow.
11553
c20db43f
PE
11554 * intervals.h (struct interval): Use EMACS_INT for members
11555 where EMACS_UINT might cause problems. See
11556 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
11557 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
11558 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
11559 All uses changed.
37aa2f85
PE
11560 (offset_intervals): Tell GCC not to worry about length overflow
11561 when negating a negative length.
c20db43f 11562
2538aa2f
PE
11563 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
11564 (overrun_check_free): Likewise.
11565
f2d3008d
PE
11566 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
11567 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
11568 word size.
11569
ec8df744
PE
11570 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11571 (gnutls_make_error): Rename local to avoid shadowing.
11572 (gnutls_emacs_global_deinit): ifdef out; not used.
11573 (Fgnutls_boot): Use const for pointer to readonly storage.
11574 Comment out unused local. Fix pointer signedness problems.
11575
640ee02d
PE
11576 * lread.c (openp): Don't stuff size_t into an 'int'.
11577 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
11578 about possible signed overflow.
11579
6048fb2a
PE
11580 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11581 (GDK_KEY_g): Don't define if already defined.
11582 (xg_prepare_tooltip): Avoid pointer signedness problem.
11583 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
11584
fa3c87e1
PE
11585 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
11586 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
11587
2172544b
PE
11588 * xfns.c (Fx_window_property): Simplify a bit,
11589 to make a bit faster and to avoid GCC 4.6.0 warning.
11590 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
11591
9b821a21
PE
11592 * fns.c (internal_equal): Don't assume size_t fits in int.
11593
3c616cfa
PE
11594 * alloc.c (compact_small_strings): Tighten assertion a little.
11595
c2982e87
PE
11596 Replace pEd with more-general pI, and fix some printf arg casts.
11597 * lisp.h (pI): New macro, generalizing old pEd macro to other
11598 conversion specifiers. For example, use "...%"pI"d..." rather
11599 than "...%"pEd"...".
11600 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 11601 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
11602 * alloc.c (check_pure_size): Don't overflow by converting size to int.
11603 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
11604 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
11605 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
11606 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
11607 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
11608 64-bit hosts.
11609 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
11610 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
11611 * print.c (safe_debug_print, print_object): Likewise.
11612 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
11613 to int.
6f04d126
PE
11614 Use pI instead of if-then-else-abort. Use %p to avoid casts,
11615 avoiding the 0 flag, which is not portable.
c2982e87
PE
11616 * process.c (Fmake_network_process): Use pI to avoid cast.
11617 * region-cache.c (pp_cache): Likewise.
11618 * xdisp.c (decode_mode_spec): Likewise.
11619 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
11620 behavior on 64-bit hosts with printf arg.
6f04d126 11621 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
11622 (x_stop_queuing_selection_requests): Likewise.
11623 (x_get_window_property): Don't truncate byte count to an 'int'
11624 when tracing.
0b432f21 11625
5e073ec7
PE
11626 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
11627 here, since it parses constructs like leading '-' and spaces,
11628 which are not wanted; and it overflows with large numbers.
11629 Instead, simply match F[0-9]+, which is what is wanted anyway.
11630
36372bf9
PE
11631 * alloc.c: Remove unportable assumptions about struct layout.
11632 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
11633 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
11634 (allocate_vectorlike, make_pure_vector): Use the new macros,
11635 plus offsetof, to remove unportable assumptions about struct layout.
11636 These assumptions hold on all porting targets that I know of, but
11637 they are not guaranteed, they're easy to remove, and removing them
11638 makes further changes easier.
11639
0b432f21
PE
11640 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
11641 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
11642 (string_overrun_cookie): Now const. Use initializers that
11643 don't formally overflow signed char, to avoid warnings.
000098c1
PE
11644 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
11645 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
11646 (allocate_buffer): Don't assume sizeof (struct buffer) is a
11647 multiple of sizeof (EMACS_INT); it need not be, if
11648 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 11649 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 11650
895009e1
JB
116512011-04-26 Juanma Barranquero <lekktu@gmail.com>
11652
11653 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
11654
6a7a1b0b
TZ
116552011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
11656
11657 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 11658 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
11659 Reported by Paul Eggert <eggert@cs.ucla.edu>.
11660
841a1577 116612011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
11662
11663 * lisp.h (Qdebug): List symbol.
895009e1 11664 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
11665 * keyboard.c (debug-on-event): New variable.
11666 (handle_user_signal): Break into debugger when debug-on-event
11667 matches the current signal symbol.
11668
f2d3ba6f
DN
116692011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
11670
11671 * alloc.c (check_sblock, check_string_bytes)
11672 (check_string_free_list): Convert to standard C.
11673
42ce4c63
TZ
116742011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
11675
11676 * w32.c (emacs_gnutls_push): Fix typo.
11677
825cd63c
EZ
116782011-04-25 Eli Zaretskii <eliz@gnu.org>
11679
fb11d64d
EZ
11680 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
11681 "cast to pointer from integer of different size".
11682
825cd63c
EZ
11683 Improve doprnt and its use in verror. (Bug#8545)
11684 * doprnt.c (doprnt): Document the set of format control sequences
11685 supported by the function. Use SAFE_ALLOCA instead of always
11686 using `alloca'.
11687
11688 * eval.c (verror): Don't limit the buffer size at size_max-1, that
11689 is one byte too soon. Don't use xrealloc; instead xfree and
11690 xmalloc anew.
11691
e061a11b
TZ
116922011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
11693
11694 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
11695 callbacks stage.
11696
11697 * gnutls.c: Renamed global_initialized to
11698 gnutls_global_initialized. Added internals for the
11699 :verify-hostname-error, :verify-error, and :verify-flags
11700 parameters of `gnutls-boot' and documented those parameters in the
11701 docstring. Start callback support.
9173deec
JB
11702 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
11703 unless a fatal error occurred. Call gnutls_alert_send_appropriate
11704 on error. Return error code.
e061a11b
TZ
11705 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
11706 (emacs_gnutls_read): Likewise.
11707 (Fgnutls_boot): Return handshake error code.
11708 (emacs_gnutls_handle_error): New function.
11709 (wsaerror_to_errno): Likewise.
11710
11711 * w32.h (emacs_gnutls_pull): Add prototype.
11712 (emacs_gnutls_push): Likewise.
11713
11714 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
11715 (emacs_gnutls_push): Likewise.
11716
117172011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
11718
11719 * process.c (wait_reading_process_output): Check if GnuTLS
11720 buffered some data internally if no FDs are set for TLS
11721 connections.
11722
11723 * makefile.w32-in (OBJ2): Add gnutls.$(O).
11724 (LIBS): Link to USER_LIBS.
11725 ($(BLD)/gnutls.$(0)): New target.
11726
fa6996bc
EZ
117272011-04-24 Eli Zaretskii <eliz@gnu.org>
11728
eb35682e
EZ
11729 * xdisp.c (handle_single_display_spec): Rename the
11730 display_replaced_before_p argument into display_replaced_p, to
11731 make it consistent with the commentary. Fix typos in the
11732 commentary.
11733
e2ad650c
EZ
11734 * textprop.c (syms_of_textprop): Remove dead code.
11735 (copy_text_properties): Delete obsolete commentary about an
11736 interface that was deleted long ago. Fix typos in the description
11737 of arguments.
11738
1b2de274
EZ
11739 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
11740 to changes in oldXMenu/XMenu.h from 2011-04-16.
11741 <menu_help_message, prev_menu_help_message>: Constify.
11742 (IT_menu_make_room): menu->help_text is now `const char **';
11743 adjust.
11744
11745 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
11746 to changes in oldXMenu/XMenu.h from 2011-04-16.
11747 (struct XMenu): Declare `help_text' `const char **'.
11748
11749 * xfaces.c <Qunspecified>: Make extern again.
11750
11751 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 11752 required by POSIX.
1b2de274 11753
762b15be
EZ
11754 * doc.c (get_doc_string): Improve the format passed to `error'.
11755
11756 * doprnt.c (doprnt): Improve commentary.
11757
11758 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
11759
11760 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
11761 them with etags.
11762
f1052e5d
EZ
11763 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
11764 changes in globals.h immediately force recompilation.
762b15be
EZ
11765 (TAGS): Depend on $(CURDIR)/m/intel386.h and
11766 $(CURDIR)/s/ms-w32.h.
11767 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 11768
fa6996bc
EZ
11769 * character.c (Fchar_direction): Function deleted.
11770 (syms_of_character): Don't defsubr it.
11771 <char-direction-table>: Deleted.
11772
e6c3da20
EZ
117732011-04-23 Eli Zaretskii <eliz@gnu.org>
11774
11775 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
11776 * doprnt.c: Include limits.h.
11777 (SIZE_MAX): New macro.
04f2d78b
CB
11778 (doprnt): Return a size_t value. 2nd arg is now size_t.
11779 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
11780 Improve overflow protection. Support `l' modifier for integer
11781 conversions. Support %l conversion. Don't assume an EMACS_INT
11782 argument for integer conversions and for %c.
11783
11784 * lisp.h (doprnt): Restore prototype.
11785
11786 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
11787 $(SRC)/character.h.
11788
11789 * Makefile.in (base_obj): Add back doprnt.o.
11790
11791 * deps.mk (doprnt.o): Add back prerequisites.
11792 (callint.o): Depend on character.h.
11793
11794 * eval.c (internal_lisp_condition_case): Include the handler
11795 representation in the error message.
11796 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
11797 when breaking from the loop.
11798
11799 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
11800
11801 * callint.c (Fcall_interactively): When displaying error message
11802 about invalid control letter, pass the character's codepoint, not
11803 a pointer to its multibyte form. Improve display of the character
11804 in octal and display also its hex code.
11805
11806 * character.c (char_string): Use %x to display the (unsigned)
11807 codepoint of an invalid character, to avoid displaying a bogus
11808 negative value.
11809
11810 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
11811 `error', not SYMBOL_NAME itself.
11812
11813 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
11814 character arguments to `error'.
11815
11816 * charset.c (check_iso_charset_parameter): Fix incorrect argument
11817 to `error' in error message about FINAL_CHAR argument. Make sure
11818 FINAL_CHAR is a character, and use %c when it is passed as
11819 argument to `error'.
11820
4ffd0d6b 118212011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
11822
11823 * s/ms-w32.h (localtime): Redirect to sys_localtime.
11824
11825 * w32.c: Include <time.h>.
11826 (sys_localtime): New function.
11827
4ffd0d6b 118282011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
11829
11830 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
11831
4ffd0d6b 11832 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 11833
4ffd0d6b 118342011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 11835
4ffd0d6b
GM
11836 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
11837 zombies (Bug#8467).
aac0c6e3 11838
04c56954
EZ
118392011-04-19 Eli Zaretskii <eliz@gnu.org>
11840
11841 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
11842 gl_state.e_property when gl_state.object is Qt.
11843
11844 * insdel.c (make_gap_larger): Remove limitation of buffer size
11845 to <= INT_MAX.
11846
16a43933
CY
118472011-04-18 Chong Yidong <cyd@stupidchicken.com>
11848
11849 * xdisp.c (lookup_glyphless_char_display)
11850 (produce_glyphless_glyph): Handle cons cell entry in
11851 glyphless-char-display.
11852 (Vglyphless_char_display): Document it.
11853
11854 * term.c (produce_glyphless_glyph): Handle cons cell entry in
11855 glyphless-char-display.
11856
4581706e
CY
118572011-04-17 Chong Yidong <cyd@stupidchicken.com>
11858
11859 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
11860
11861 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
11862
11863 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
11864 definition for no-X builds.
11865
4887c6e2 118662011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 11867
fd35b6f9
PE
11868 Static checks with GCC 4.6.0 and non-default toolkits.
11869
5c1ccb01
PE
11870 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
11871
006c5daa
PE
11872 * process.c (keyboard_bit_set): Define only if SIGIO.
11873 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
11874 (send_process): Repair possible setjmp clobbering.
11875
efc736d3
PE
11876 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
11877
4e2fe2e6
PE
11878 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
11879
f97334a2
PE
11880 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
11881
4e75f29d
PE
11882 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
11883 Define only if needed.
11884
90efadd1
PE
11885 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
11886 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 11887 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 11888
3c647824
PE
11889 * dispextern.h (struct redisplay_interface): Rename param
11890 to avoid shadowing.
e264f262 11891 * termhooks.h (struct terminal): Likewise.
761383f4 11892 * xterm.c (xembed_send_message): Likewise.
3c647824 11893
b58c5c4a
PE
11894 * insdel.c (make_gap_smaller): Define only if
11895 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
11896
cad59032
PE
11897 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
11898 it.
11899
c339dc2e
PE
11900 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
11901 so that we aren't warned about unused symbols.
11902
91a3e27b
PE
11903 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
11904
399c71d3 11905 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 11906
8ffc96f5
PE
11907 * xfns.c (x_real_positions): Mark locals as initialized.
11908
eef9bc79
PE
11909 * xmenu.c (xmenu_show): Don't use uninitialized vars.
11910
098db9dd
PE
11911 * xterm.c: Fix problems found by static analysis with other toolkits.
11912 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
11913 (x_dispatch_event): Declare static if USE_GTK, and
11914 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 11915 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 11916 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
11917 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
11918 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 11919
eb18f6cc
PE
11920 * xmenu.c (menu_help_callback): Pointer type fixes.
11921 Use const pointers when pointing at readonly data. Avoid pointer
11922 signedness clashes.
11923 (FALSE): Remove unused macro.
11924 (update_frame_menubar): Remove unused decl.
11925
1fe72bf8
PE
11926 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
11927
60d9e1db
PE
11928 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
11929 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
11930 (single_menu_item): Rename local to avoid shadowing.
11931
39261c26
PE
11932 * keyboard.c (make_lispy_event): Remove unused local var.
11933
018c5e19
PE
11934 * frame.c, frame.h (x_get_resource_string): Bring this back, but
11935 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
11936
63d2b86e
PE
11937 * bitmaps: Change bitmaps from unsigned char back to the X11
11938 compatible char. Avoid the old compiler warnings about
11939 out-of-range initializers by using, for example, '\xab' rather
11940 than 0xab.
11941
aefd87e1
PE
11942 * xgselect.c (xgselect_initialize): Check vs interface
11943 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
11944
bf501fb9
PE
11945 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
11946
e9829fdf
PE
11947 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
11948 to read-only memory.
11949
1086c095
PE
11950 * fns.c (vector): Remove; this old hack is no longer needed.
11951
2baccd04 11952 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 11953 Remove unused var.
dde42981 11954 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 11955
72391843 11956 * xrdb.c (x_load_resources): Omit unused local.
3565b346 11957
436c16df 11958 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 11959 (x_window): Rename locals to avoid shadowing.
dc5ddd85 11960 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 11961
92bb796d 11962 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 11963 (x_term_init): Remove local to avoid shadowing.
92bb796d 11964
764430a3 11965 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
11966
11967 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
11968 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
11969
d1dfb56c
EZ
119702011-04-16 Eli Zaretskii <eliz@gnu.org>
11971
c4354cb4
EZ
11972 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
11973
d1dfb56c
EZ
11974 Fix regex.c, syntax.c and friends for buffers > 2GB.
11975 * syntax.h (struct gl_state_s): Declare character position members
11976 EMACS_INT.
11977
11978 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
11979
04f2d78b
CB
11980 * textprop.c (verify_interval_modification, interval_of):
11981 Declare arguments EMACS_INT.
d1dfb56c
EZ
11982
11983 * intervals.c (adjust_intervals_for_insertion): Declare arguments
11984 EMACS_INT.
11985
11986 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
11987
11988 * indent.c (Fvertical_motion): Local variable it_start is now
11989 EMACS_INT.
11990
11991 * regex.c (re_match, re_match_2, re_match_2_internal)
11992 (bcmp_translate, regcomp, regexec, print_double_string)
11993 (group_in_compile_stack, re_search, re_search_2, regex_compile)
11994 (re_compile_pattern, re_exec): Declare arguments and local
11995 variables `size_t' and `ssize_t' and return values `regoff_t', as
11996 appropriate.
11997 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
11998 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
11999 <compile_stack_type>: `size' and `avail' are now `size_t'.
12000
12001 * regex.h <regoff_t>: Use ssize_t, not int.
12002 (re_search, re_search_2, re_match, re_match_2): Arguments that
12003 specify buffer/string position and length are now ssize_t and
12004 size_t. Return type is regoff_t.
12005
613052cd
BK
120062011-04-16 Ben Key <bkey76@gmail.com>
12007
12008 * nsfont.m: Fixed bugs in ns_get_family and
12009 ns_descriptor_to_entity that were caused by using free to
12010 deallocate memory blocks that were allocated by xmalloc (via
12011 xstrdup). This caused Emacs to crash when compiled with
12012 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
12013 --enable-checking=xmallocoverrun). xfree is now used to
12014 deallocate these memory blocks.
12015
4170f62f 120162011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 12017
71b41406
PE
12018 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
12019
9587a89d
PE
12020 emacs_write: Accept and return EMACS_INT for sizes.
12021 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
12022 et seq.
12023 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
12024 Accept and return EMACS_INT.
12025 (emacs_gnutls_write): Return the number of bytes written on
12026 partial writes.
12027 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
12028 (emacs_read, emacs_write): Remove check for negative size, as the
12029 Emacs source code has been audited now.
9587a89d
PE
12030 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
12031 (emacs_read, emacs_write): Use it.
273a5f82
PE
12032 * process.c (send_process): Adjust to the new signatures of
12033 emacs_write and emacs_gnutls_write. Do not attempt to store
12034 a byte offset into an 'int'; it might overflow.
9587a89d 12035 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 12036
3e047f51
PE
12037 * sound.c: Don't assume sizes fit in 'int'.
12038 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 12039 Return EMACS_INT, not int.
3e047f51 12040 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
12041 Accept EMACS_INT, not int.
12042 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
12043 record read return values.
12044
cc39a9db
BK
120452011-04-15 Ben Key <bkey76@gmail.com>
12046
c9d0ec6d
JB
12047 * keyboard.c (Qundefined): Don't declare static since it is used
12048 in nsfns.m.
12049 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
12050 static since they are used in nsfont.m.
cc39a9db 12051
6c60eb9f
SM
120522011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
12053
12054 * process.c (Qprocessp): Don't declare static.
12055 * lisp.h (Qprocessp): Declare again.
12056
7990b61a
JB
120572011-04-15 Juanma Barranquero <lekktu@gmail.com>
12058
12059 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
12060
5d4cb038
PE
120612011-04-14 Paul Eggert <eggert@cs.ucla.edu>
12062
8bd7b830 12063 Improve C-level modularity by making more things 'static'.
cd64ea1d 12064
e3b27b31
PE
12065 Don't publish debugger-only interfaces to other modules.
12066 * lisp.h (safe_debug_print, debug_output_compilation_hack):
12067 (verify_bytepos, count_markers): Move decls to the only modules
12068 that need them.
12069 * region-cache.h (pp_cache): Likewise.
12070 * window.h (check_all_windows): Likewise.
12071 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
12072
5d4cb038
PE
12073 * sysdep.c (croak): Now static, if
12074 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
12075 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
12076
12077 * alloc.c (refill_memory_reserve): Now static if
12078 !defined REL_ALLOC || defined SYSTEM_MALLOC.
12079 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 12080
e87b6180
PE
12081 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
12082 Define only if USE_LUCID.
12083
ac64929e
PE
12084 * xrdb.c (x_customization_string, x_rm_string): Now static.
12085
6f37259d
PE
12086 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
12087 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
12088
1683e3ab
PE
12089 * xdisp.c (draw_row_with_mouse_face): Now static.
12090 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
12091
de9c2632
PE
12092 * window.h (check_all_windows): Mark externally visible.
12093
2b96acb7
PE
12094 * window.c (window_deletion_count): Now static.
12095
12096 * undo.c: Make symbols static if they're not exported.
12097 (last_undo_buffer, last_boundary_position, pending_boundary):
12098 Now static.
12099
50436f33
PE
12100 * textprop.c (interval_insert_behind_hooks): Now static.
12101 (interval_insert_in_front_hooks): Likewise.
12102
64520e5c
PE
12103 * term.c: Make symbols static if they're not exported.
12104 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
12105 (max_frame_lines, tty_set_terminal_modes):
12106 (tty_reset_terminal_modes, tty_turn_off_highlight):
12107 (get_tty_terminal): Now static.
12108 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
12109 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 12110 HAVE_WINDOW_SYSTEM.
64520e5c
PE
12111 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
12112 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
12113
1fa53021
PE
12114 * sysdep.c: Make symbols static if they're not exported.
12115 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
12116 Now static.
12117 (sigprocmask_set, full_mask): Remove; unused.
12118 (wait_debugging): Mark as visible.
12119 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
12120 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
12121
d4b43b22
PE
12122 * syntax.c (syntax_temp): Define only if !__GNUC__.
12123
b7c513d0
PE
12124 * sound.c (current_sound_device, current_sound): Now static.
12125
989b29ad
PE
12126 * search.c (searchbufs, searchbuf_head): Now static.
12127
13a55a78
PE
12128 * scroll.c (scroll_cost): Remove; unused.
12129 * dispextern.h (scroll_cost): Remove decl.
12130
de68a1fc
PE
12131 * region-cache.h (pp_cache): Mark as externally visible.
12132
40ccffa6
PE
12133 * process.c: Make symbols static if they're not exported.
12134 (process_tick, update_tick, create_process, chan_process):
12135 (Vprocess_alist, proc_buffered_char, datagram_access):
12136 (fd_callback_data, send_process_frame, process_sent_to): Now static.
12137 (deactivate_process): Mark defn as static, as well as decl.
12138 * lisp.h (create_process): Remove decl.
12139 * process.h (chan_process, Vprocess_alist): Remove decls.
12140
ad64fc97
PE
12141 * print.c: Make symbols static if they're not exported.
12142 (print_depth, new_backquote_output, being_printed, print_buffer):
12143 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
12144 (print_interval, print_number_index, initial_stderr_stream):
12145 Now static.
12146 * lisp.h (Fprinc): Remove decl.
12147 (debug_output_compilation_hack): Mark as externally visible.
12148
adddb265
PE
12149 * sysdep.c (croak): Move decl from here to syssignal.h.
12150 * syssignal.h (croak): Put it here, so the API can be checked when
12151 'croak' is called from dissociate_if_controlling_tty.
12152
1717ede2
PE
12153 * minibuf.c: Make symbols static if they're not exported.
12154 (minibuf_save_list, choose_minibuf_frame): Now static.
12155 * lisp.h (choose_minibuf_frame): Remove decl.
12156
fa5fb2bc
PE
12157 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
12158
1e3890d1
PE
12159 * lread.c: Make symbols static if they're not exported.
12160 (read_objects, initial_obarray, oblookup_last_bucket_number):
12161 Now static.
12162 (make_symbol): Remove; unused.
12163 * lisp.h (initial_obarray, make_symbol): Remove decls.
12164
8a1414fa
PE
12165 * keyboard.c: Make symbols static if they're not exported.
12166 (single_kboard, recent_keys_index, total_keys, recent_keys):
12167 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
12168 (this_single_command_key_start, echoing, last_auto_save):
12169 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
12170 (command_loop, echo_now, keyboard_init_hook, help_char_p):
12171 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
12172 (Vlispy_mouse_stem, double_click_count):
12173 Now static.
12174 (force_auto_save_soon): Define only if SIGDANGER.
12175 (ignore_mouse_drag_p): Now static if
12176 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
12177 (print_help): Remove; unused.
12178 (stop_character, last_timer_event): Mark as externally visible.
12179 * keyboard.h (ignore_mouse_drag_p): Declare only if
12180 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
12181 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
12182 * lisp.h (echoing): Remove decl.
12183 (force_auto_save_soon): Declare only if SIGDANGER.
12184 * xdisp.c (redisplay_window): Simplify code, to make it more
12185 obvious that ignore_mouse_drag_p is not accessed if !defined
12186 USE_GTK && !defined HAVE_NS.
12187
93ea6e8f
PE
12188 * intervals.c: Make symbols static if they're not exported.
12189 (merge_properties_sticky, merge_interval_right, delete_interval):
12190 Now static.
12191 * intervals.h (merge_interval_right, delete_interval): Remove decls.
12192
77382fcc
PE
12193 * insdel.c: Make symbols static if they're not exported.
12194 However, leave prepare_to_modify_buffer alone. It's never
12195 called from outside this function, but that appears to be a bug.
12196 (combine_after_change_list, combine_after_change_buffer):
4889fc82 12197 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
12198 (adjust_after_replace_noundo): Remove; unused.
12199 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 12200 (signal_before_change): Remove decls.
77382fcc 12201
9306c32e
PE
12202 * indent.c (val_compute_motion, val_vmotion): Now static.
12203
cd44d2eb
PE
12204 * image.c: Make symbols static if they're not exported.
12205 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
12206 if USE_GTK.
12207 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
12208 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
12209
ad9a7a06
PE
12210 * fringe.c (standard_bitmaps): Now static.
12211 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
12212
81626931
PE
12213 * frame.c: Make symbols static if they're not exported.
12214 (x_report_frame_params, make_terminal_frame): Now static.
12215 (get_frame_param): Now static, unless HAVE_NS.
12216 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
12217 (x_get_resource_string): Remove; not used.
12218 * frame.h (make_terminal_frame, x_report_frame_params):
12219 (x_get_resource_string); Remove decls.
12220 (x_fullscreen_adjust): Declare only if WINDOWSNT.
12221 * lisp.h (get_frame_param): Declare only if HAVE_NS.
12222
239f9db9
PE
12223 * font.c, fontset.c: Make symbols static if they're not exported.
12224 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
12225 (FACE_SUITABLE_FOR_CHAR_P): Use it.
12226 * font.c (font_close_object): Now static.
12227 * font.h (font_close_object): Remove.
12228 * fontset.c (FONTSET_OBJLIST): Remove.
12229 (free_realized_fontset) #if-0 the body, which does nothing.
12230 (face_suitable_for_char_p): #if-0, as it's never called.
12231 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
12232 * xfaces.c (face_at_string_position):
12233 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
12234 since 0 is always ASCII.
12235
dfcf3579
PE
12236 * fns.c (weak_hash_tables): Now static.
12237
5045092b
PE
12238 * fileio.c: Make symbols static if they're not exported.
12239 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
12240 (Vwrite_region_annotation_buffers): Now static.
12241
57a96f5c
PE
12242 * eval.c: Make symbols static if they're not exported.
12243 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
12244 * lisp.h (backtrace_list): Remove decl.
12245
35f08c38
PE
12246 * emacs.c: Make symbols static if they're not exported.
12247 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
12248 (fatal_error_code, fatal_error_signal_hook, standard_args):
12249 Now static.
12250 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
12251 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
12252 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
12253 * lisp.h (fatal_error_signal_hook): Remove decl.
12254 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
12255
f44bd759
PE
12256 * editfns.c: Move a (normally-unused) function to its only use.
12257 * editfns.c, lisp.h (get_operating_system_release): Remove.
12258 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
12259 worth the hassle of breaking this out.
12260
b532497d
PE
12261 * xterm.c: Make symbols static if they're not exported.
12262 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
12263 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
12264 (x_destroy_window, x_delete_display):
12265 Now static.
12266 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
12267 (x_mouse_leave): Remove; unused.
12268 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
12269 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
12270 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
12271 Remove decls.
12272 (x_mouse_leave): Declare only if WINDOWSNT.
12273 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
12274 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
12275 USE_X_TOOLKIT.
12276
1675728f
PE
12277 * ftxfont.c: Make symbols static if they're not exported.
12278 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
12279 HAVE_FREETYPE.
12280 * font.h (ftxfont_driver): Likewise.
12281
e4cebfca
PE
12282 * xfns.c: Make symbols static if they're not exported.
12283 (x_last_font_name, x_display_info_for_name):
12284 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
12285 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
12286 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
12287 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
12288 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
12289 (last_show_tip_args): Now static.
12290 (xic_defaut_fontset, xic_create_fontsetname): Define only if
12291 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
12292 (x_screen_planes): Remove; unused.
12293 * dispextern.h (x_screen_planes): Remove decl.
12294
5bf46f05
PE
12295 * dispnew.c: Make symbols static if they're not exported.
12296 * dispextern.h (redraw_garbaged_frames, scrolling):
12297 (increment_row_positions): Remove.
12298 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
12299 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
12300 Now static.
12301 (redraw_garbaged_frames): Remove; unused.
12302
435f4c28
PE
12303 * xfaces.c: Make symbols static if they're not exported.
12304 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
12305 Remove decls.
12306 * xterm.h (defined_color): Remove decls.
12307 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
12308 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
12309 (menu_face_changed_default, defined_color, free_realized_face):
12310 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
12311 (ascii_face_of_lisp_face): Remove; unused.
12312
8524aef3
PE
12313 * xdisp.c: Make symbols static if they're not exported.
12314 * dispextern.h (scratch_glyph_row, window_box_edges):
12315 (glyph_to_pixel_coords, set_cursor_from_row):
12316 (get_next_display_element, set_iterator_to_next):
12317 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
12318 (show_mouse_face): Remove decls
12319 * frame.h (message_buf_print): Likewise.
12320 * lisp.h (pop_message, set_message, check_point_in_composition):
12321 Likewise.
12322 * xterm.h (set_vertical_scroll_bar): Likewise.
12323 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
12324 (message_buf_print, scratch_glyph_row, displayed_buffer):
12325 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
12326 (get_next_display_element, show_mouse_face, window_box_edges):
12327 (frame_to_window_pixel_xy, check_point_in_composition):
12328 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
12329 (glyph_to_pixel_coords): Remove; unused.
12330
16390cd2
PE
12331 * dired.c (file_name_completion): Now static.
12332
12333 * dbusbind.c (xd_in_read_queued_messages): Now static.
12334
a25f4dfa
PE
12335 * lisp.h (circular_list_error, FOREACH): Remove; unused.
12336 * data.c (circular_list_error): Remove.
12337
14a9c8df
PE
12338 * commands.h (last_point_position, last_point_position_buffer):
12339 (last_point_position_window): Remove decls.
12340 * keyboard.c: Make these variables static.
12341
04f2d78b
CB
12342 * coding.h (coding, code_convert_region, encode_coding_gap):
12343 Remove decls.
74ab6df5
PE
12344 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
12345 (iso_code_class, detect_coding, code_convert_region): Now static.
12346 (encode_coding_gap): Remove; unused.
12347
38dfbee1
PE
12348 * chartab.c (chartab_chars, chartab_bits): Now static.
12349
a2cb4e63
PE
12350 * charset.h (charset_iso_8859_1): Remove decl.
12351 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
12352 Now static.
12353
127198fd
PE
12354 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
12355 * ccl.c (Vccl_program_table): Now static.
12356 (check_ccl_update): Remove; unused.
12357
d85b608f
PE
12358 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
12359 * category.h: ... from here.
12360 * category.c (check_category_table, set_category_set): Now static.
12361
31cd66f3
PE
12362 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
12363 * lisp.h: Remove these decls.
12364
c358e587
PE
12365 * buffer.c (buffer_count): Remove unused var.
12366
e78aecca
PE
12367 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
12368 so that it's not optimized away.
12369 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
12370 * dispextern.h (bidi_dump_cached_states): Remove, since it's
12371 exported only to the debugger.
12372
e192d7d3 12373 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 12374 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 12375
92470028
PE
12376 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
12377 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
12378 was inaccessible from Lisp.
12379 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
12380 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
12381
244ed907
PE
12382 alloc.c: Import and export fewer symbols, and remove unused items.
12383 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
12384 is defined.
12385 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
12386 it's not optimized away by whole-program optimization.
12387 (message_enable_multibyte, free_misc): Remove.
12388 (catchlist, handlerlist, mark_backtrace):
12389 Declare only if BYTE_MARK_STACK.
12390 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
12391 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
12392 (message_enable_multibyte): Remove decl.
12393 (free_misc, interval_free_list, float_block, float_block_index):
12394 (n_float_blocks, float_free_list, cons_block, cons_block_index):
12395 (cons_free_list, last_marked_index):
12396 Now static.
12397 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
12398 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
12399 (mark_backtrace): Define only if BYTE_MARK_STACK.
12400 * xdisp.c (message_enable_multibyte): Now static.
12401
61c2b50e 12402 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
12403 This makes it easier for human readers (and static analyzers)
12404 to see whether these variables are used from other modules.
12405 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
12406 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
12407 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
12408 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
12409 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
12410 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
12411 * xmenu.c, xselect.c:
12412 Declare Q* vars static if they are not used in other modules.
12413 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
12414 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
12415 Remove decls of unexported vars.
12416 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
12417
95c82688
PE
12418 * lisp.h (DEFINE_FUNC): Make sname 'static'.
12419
16a97296
PE
12420 Make Emacs functions such as Fatom 'static' by default.
12421 This makes it easier for human readers (and static analyzers)
12422 to see whether these functions can be called from other modules.
12423 DEFUN now defines a static function. To make the function external
12424 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
12425 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
12426 (Finit_image_library):
16a97296
PE
12427 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
12428 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
12429 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
12430 Remove decls, since these functions are now static.
12431 (Funintern, Fget_internal_run_time): New decls, since these functions
12432 were already external.
95c82688 12433
16a97296
PE
12434 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
12435 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
12436 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
12437 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
12438 * keyboard.c, keymap.c, lread.c:
12439 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
12440 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
12441 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
12442 Mark functions with DEFUE instead of DEFUN,
12443 if they are used in other modules.
12444 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
12445 decls for now-static functions.
12446 * buffer.h (Fdelete_overlay): Remove decl.
12447 * callproc.c (Fgetenv_internal): Mark as internal.
12448 * composite.c (Fremove_list_of_text_properties): Remove decl.
12449 (Fcomposition_get_gstring): New forward static decl.
12450 * composite.h (Fcomposite_get_gstring): Remove decl.
12451 * dired.c (Ffile_attributes): New forward static decl.
12452 * doc.c (Fdocumntation_property): New forward static decl.
12453 * eval.c (Ffetch_bytecode): New forward static decl.
12454 (Funintern): Remove extern decl; now in .h file where it belongs.
12455 * fileio.c (Fmake_symbolic_link): New forward static decl.
12456 * image.c (Finit_image_library): New forward static decl.
12457 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
12458 * intervals.h (Fprevious_property_change):
12459 (Fremove_list_of_text_properties): Remove decls.
12460 * keyboard.c (Fthis_command_keys): Remove decl.
12461 (Fcommand_execute): New forward static decl.
12462 * keymap.c (Flookup_key): New forward static decl.
12463 (Fcopy_keymap): Now static.
12464 * keymap.h (Flookup_key): Remove decl.
12465 * process.c (Fget_process): New forward static decl.
12466 (Fprocess_datagram_address): Mark as internal.
12467 * syntax.c (Fsyntax_table_p): New forward static decl.
12468 (skip_chars): Remove duplicate decl.
12469 * textprop.c (Fprevious_property_change): New forward static decl.
12470 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
12471 Now internal.
12472 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
12473 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
12474
785bbd42
PE
12475 * editfns.c (Fformat): Remove unreachable code.
12476
8b913b57
AS
124772011-04-14 Andreas Schwab <schwab@linux-m68k.org>
12478
12479 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
12480 change. (Bug#8496)
12481
a6744a35
EZ
124822011-04-13 Eli Zaretskii <eliz@gnu.org>
12483
12484 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
12485 when at ZV. (Bug#8487)
12486
e7974947
AS
124872011-04-12 Andreas Schwab <schwab@linux-m68k.org>
12488
baad03f0
AS
12489 * charset.c (Fclear_charset_maps): Use xfree instead of free.
12490 (Bug#8437)
12491 * keyboard.c (parse_tool_bar_item): Likewise.
12492 * sound.c (sound_cleanup, alsa_close): Likewise.
12493 * termcap.c (tgetent): Likewise.
12494 * xfns.c (x_default_font_parameter): Likewise.
12495 * xsettings.c (read_and_apply_settings): Likewise.
12496
e7974947
AS
12497 * alloc.c (overrun_check_malloc, overrun_check_realloc)
12498 (overrun_check_free): Protoize.
12499
28272684
PE
125002011-04-12 Paul Eggert <eggert@cs.ucla.edu>
12501
12502 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
12503 since callers should never pass a negative size.
12504 Change the signature to match that of plain 'read' and 'write'; see
12505 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
12506 * lisp.h: Update prototypes of emacs_write and emacs_read.
12507
11997c76
EZ
125082011-04-11 Eli Zaretskii <eliz@gnu.org>
12509
12510 * xdisp.c (redisplay_window): Don't try to determine the character
12511 position of the scroll margin if the window start point w->startp
e896f03c 12512 is outside the buffer's accessible region. (Bug#8468)
11997c76 12513
8a2cbd72
EZ
125142011-04-10 Eli Zaretskii <eliz@gnu.org>
12515
12516 Fix write-region and its subroutines for buffers > 2GB.
12517 * fileio.c (a_write, e_write): Modify declaration of arguments and
12518 local variables to support buffers larger than 2GB.
12519 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
12520
12521 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
12522 argument, local variables, and return value.
12523
12524 * lisp.h: Update prototypes of emacs_write and emacs_read.
12525
12526 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
12527
4073e537 125282011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 12529
1ebfdcb6
PE
12530 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
12531
b2ded58d
PE
12532 Fix more problems found by GCC 4.6.0's static checks.
12533
7d66342c
PE
12534 * xdisp.c (vmessage): Use a better test for character truncation.
12535
bbf47d44
PE
12536 * charset.c (load_charset_map): <, not <=, for optimization,
12537 and to avoid potential problems with integer overflow.
9248994d 12538 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 12539 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 12540 * editfns.c (Fformat): Likewise.
1e69125e 12541 * syntax.c (skip_chars): Likewise.
3befa583 12542
e3019616
PE
12543 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
12544 This also lets GCC 4.6.0 generate slightly better loop code.
12545
becfa255
PE
12546 * callint.c (Fcall_interactively): <, not <=, for optimization.
12547 (Fcall_interactively): Count the number of arguments produced,
12548 not the number of arguments given. This is simpler and lets GCC
12549 4.6.0 generate slightly better code.
12550
dae0cd48
PE
12551 * ftfont.c: Distingish more carefully between FcChar8 and char.
12552 The previous code passed unsigned char * to a functions like
12553 strlen and xstrcasecmp that expect char *, which does not
12554 conform to the C standard.
12555 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
12556 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
12557 char * when the C standard requires it.
12558
76032d70
PE
12559 * keyboard.c (read_char): Remove unused var.
12560
eb3f1cc8
PE
12561 * eval.c: Port to Windows vsnprintf (Bug#8435).
12562 Include <limits.h>.
12563 (SIZE_MAX): Define if the headers do not.
12564 (verror): Do not give up if vsnprintf returns a negative count.
12565 Instead, grow the buffer. This ports to Windows vsnprintf, which
12566 does not conform to C99. Problem reported by Eli Zaretskii.
12567 Also, simplify the allocation scheme, by avoiding the need for
12568 calling realloc, and removing the ALLOCATED variable.
12569
70476b54
PE
12570 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
12571
12020a9e
PE
12572 Remove invocations of doprnt, as Emacs now uses vsnprintf.
12573 But keep the doprint source code for now, as we might revamp it
12574 and use it again (Bug#8435).
ea6c7ae6
PE
12575 * lisp.h (doprnt): Remove.
12576 * Makefile.in (base_obj): Remove doprnt.o.
12577 * deps.mk (doprnt.o): Remove.
12578
5fdb398c
PE
12579 error: Print 32- and 64-bit integers portably (Bug#8435).
12580 Without this change, on typical 64-bit hosts error ("...%d...", N)
12581 was used to print both 32- and 64-bit integers N, which relied on
12582 undefined behavior.
61bdb816 12583 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
12584 * lisp.h (error, verror): Mark as printf-like functions.
12585 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
12586 Report overflow in size calculations when allocating printf buffer.
12587 Do not truncate output string at its first null byte.
12588 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
12589 Truncate the output at a character boundary, since vsnprintf does not
12590 do that.
12591 * charset.c (check_iso_charset_parameter): Convert internal
12592 character to string before calling 'error', since %c now has the
12593 printf meaning.
12594 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
12595 overflow when computing char to be passed to 'error'. Do not
12596 pass Lisp_Object to 'error'; pass the integer instead.
12597 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
12598 formatted with plain %d.
12599
b189fa66
PE
12600 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
12601
bff87ef0
PE
12602 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
12603
7e2cac20
PE
12604 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
12605
ce4d90b5
PE
12606 * xterm.c (x_catch_errors): Remove duplicate declaration.
12607
266c9547
PE
12608 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
12609
79c49ad2
PE
12610 * xdisp.c, lisp.h (message_nolog): Remove; unused.
12611
368f4090
JM
126122011-04-10 Jim Meyering <meyering@redhat.com>
12613
12614 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
12615 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
12616 return ssize_t not "int", and use size_t as the buffer length.
12617 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
12618 * gnutls.h: Update declarations.
12619 * process.c (read_process_output): Use ssize_t, to match.
12620 (send_process): Likewise.
12621
a32d4040
CY
126222011-04-09 Chong Yidong <cyd@stupidchicken.com>
12623
12624 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
12625
8546720e 126262011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 12627
04f2d78b
CB
12628 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
12629 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 12630
8546720e
GM
12631 * xterm.c (handle_one_xevent):
12632 * xmenu.c (create_and_show_popup_menu):
12633 * xselect.c (x_decline_selection_request)
12634 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 12635
0a2f5c1a 126362011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
12637
12638 Fix some uses of `int' instead of EMACS_INT.
12639 * search.c (string_match_1, fast_string_match)
12640 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
12641 (scan_buffer, find_next_newline_no_quit)
12642 (find_before_next_newline, search_command, Freplace_match)
12643 (Fmatch_data): Make some `int' variables be EMACS_INT.
12644
12645 * xdisp.c (display_count_lines): 3rd argument and return value now
12646 EMACS_INT. All callers changed.
12647 (pint2hrstr): Last argument is now EMACS_INT.
12648
12649 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
12650 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
12651 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
12652 (decode_coding_utf_16, decode_coding_emacs_mule)
12653 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
12654 (decode_coding_ccl, decode_coding_charset)
12655 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
12656 (decode_coding_iso_2022, decode_coding_emacs_mule)
12657 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
12658 <char_offset, last_offset>: Declare EMACS_INT.
12659 (encode_coding_utf_8, encode_coding_utf_16)
12660 (encode_coding_emacs_mule, encode_invocation_designation)
12661 (encode_designation_at_bol, encode_coding_iso_2022)
12662 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
12663 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
12664 Declare EMACS_INT.
12665 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
12666 (encode_invocation_designation): Last argument P_NCHARS is now
12667 EMACS_INT.
12668 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
12669 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
12670
12671 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
12672 All users changed.
12673
12674 * ccl.c (Fccl_execute_on_string): Declare some variables
12675 EMACS_INT.
12676
8546720e 126772011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
12678
12679 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
12680
4e19a977
CS
126812011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
12682
12683 * process.c (Fformat_network_address): Doc fix.
12684
87302331
R
126852011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
12686
ee7683eb 12687 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 12688
cbb59342
CY
126892011-04-08 Chong Yidong <cyd@stupidchicken.com>
12690
12691 * keyboard.c (read_char): Call Lisp function help-form-show,
12692 instead of using internal_with_output_to_temp_buffer.
12693 (Qhelp_form_show): New var.
e0d38eeb 12694 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
12695
12696 * print.c (internal_with_output_to_temp_buffer): Function deleted.
12697
12698 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
12699
e67a13ab
CY
127002011-04-06 Chong Yidong <cyd@stupidchicken.com>
12701
04f2d78b
CB
12702 * process.c (Flist_processes): Remove to Lisp.
12703 (list_processes_1): Delete.
e67a13ab 12704
973f782d
EZ
127052011-04-06 Eli Zaretskii <eliz@gnu.org>
12706
7c106b1e
EZ
12707 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
12708
973f782d
EZ
12709 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
12710
41cf7d1a 127112011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 12712
ca23cc88
PE
12713 Fix more problems found by GCC 4.6.0's static checks.
12714
f390e2d5
PE
12715 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
12716
42eea0d0
PE
12717 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
12718
b69769da 12719 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 12720
f9541e84
PE
12721 * xdisp.c (vmessage): Mark as a printf-like function.
12722
13841b55
PE
12723 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
12724
c136c10f
PE
12725 * sound.c (sound_warning): Don't crash if arg contains a printf format.
12726
5e2d4a30
PE
12727 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
12728 printf-like functions.
12729 (tiff_load): Add casts to remove these marks before passing them
12730 to system-supplied API.
12731
583f48b9
PE
12732 * eval.c (Fsignal): Remove excess argument to 'fatal'.
12733
b25d760e
PE
12734 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
12735 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
12736 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
12737 directly, rather than having caller test rule sign. This avoids
12738 some unnecessary tests.
12739 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
12740 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
12741 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 12742
bc7b6697 12743 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 12744 (xfont_open): Avoid unnecessary tests.
bc7b6697 12745
27ccc379
PE
12746 * composite.c (composition_gstring_put_cache): Use unsigned integer.
12747
dcd5c89a
PE
12748 * composite.h, composite.c (composition_gstring_put_cache):
12749 Use EMACS_INT, not int, for length.
12750
b13a45c6
PE
12751 * composite.h (COMPOSITION_DECODE_REFS): New macro,
12752 breaking out part of COMPOSITION_DECODE_RULE.
12753 (COMPOSITION_DECODE_RULE): Use it.
12754 * composite.c (get_composition_id): Remove unused local vars,
12755 by using the new macro.
12756
1e792e4d
PE
12757 * textprop.c (set_text_properties_1): Change while to do-while,
12758 since the condition is always true at first.
12759
dc6c6455 12760 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
12761 (interval_deletion_adjustment): Return unsigned value.
12762 All uses changed.
dc6c6455 12763
aba7731a
PE
12764 * process.c (list_processes_1, create_pty, read_process_output):
12765 (exec_sentinel): Remove vars that were set but not used.
afd4052b 12766 (create_pty): Remove unnecessary "volatile"s.
bc57d757 12767 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 12768 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 12769 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 12770
fdfc4bf3
PE
12771 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
12772
fca8fe46 12773 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 12774 (update_syntax_table): Use unsigned instead of int.
fca8fe46 12775
06a0259a 12776 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 12777 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 12778 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 12779
e7b9e80f
PE
12780 * print.c (print_error_message): Avoid int overflow.
12781
56201685
PE
12782 * font.c (font_list_entities): Redo for clarity,
12783 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
12784
78834453 12785 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 12786 (font_score): Avoid potential overflow in diff calculation.
78834453 12787
0bc0b309 12788 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 12789 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 12790
e610eaca
PE
12791 * eval.c (funcall_lambda): Rename local to avoid shadowing.
12792
b895abce
PE
12793 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
12794 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
12795 can always succeed if overflow has undefined behavior.
12796
1f1d9321 12797 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 12798 (wordify): Omit three unnecessary tests.
1f1d9321 12799
c59478bc
PE
12800 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
12801 All callers changed. This avoids the need for an unused var.
12802
79b73827
PE
12803 * casefiddle.c (casify_region): Remove var that is set but not used.
12804
a4db5dfe
PE
12805 * dired.c (file_name_completion): Remove var that is set but not used.
12806
43aae36e
PE
12807 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
12808
2a47c44d 12809 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 12810 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 12811
a37c69bf
PE
12812 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
12813 Check for integer overflow on size calculations.
12814
328ab8e7
PE
12815 * buffer.c (Fprevious_overlay_change): Remove var that is set
12816 but not used.
12817
e5a2a5cb
PE
12818 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
12819 Remove vars that are set but not used.
8d84a6eb 12820 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 12821 (timer_check_2): Mark vars as initialized.
e5a2a5cb 12822
a60e5f68
PE
12823 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
12824
f661cb61 12825 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 12826 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 12827
f0397f5a
PE
12828 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
12829 that are set but not used.
12830
8664db06 12831 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 12832 if XCreateBitmapFromData fails (Bug#8410).
8664db06 12833
6abdaa4a
PE
12834 * xselect.c (x_get_local_selection, x_handle_property_notify):
12835 Remove vars that are set but not used.
12836
0ce7538d 12837 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 12838 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 12839
9ae848fc
PE
12840 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
12841 Remove var that is set but not used.
0b918413
PE
12842 (scroll_bar_windows_size): Now size_t, not int.
12843 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
12844 Check for overflow.
9ae848fc 12845
a5a62657
PE
12846 * xfaces.c (realize_named_face): Remove vars that are set but not used.
12847 (map_tty_color) [!defined MSDOS]: Likewise.
12848
5c5cdd39
PE
12849 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
12850
66ebf983
PE
12851 * coding.c: Remove vars that are set but not used.
12852 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
12853 All callers changed.
12854 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
12855 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
12856 (decode_coding_charset): Remove vars that are set but not used.
12857
1be4d761
PE
12858 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
12859 that is set but not used.
12860
47553fa8
PE
12861 * print.c (print_object): Remove var that is set but not used.
12862
1f7196bf 12863 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
12864 The gnulib version avoids calling malloc in the usual case,
12865 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
12866 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
12867 * filelock.c (current_lock_owner): Likewise.
12868 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
12869 * sysdep.c: Include allocator.h, careadlinkat.h.
12870 (emacs_no_realloc_allocator): New static constant.
12871 (emacs_readlink): New function.
fdb61804
PE
12872 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
12873 ../lib/careadlinkat.h.
d1fdcab7 12874
f84c17c7
SM
128752011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
12876
12877 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
12878 first non-nil return value).
12879
ef3862ad
JD
128802011-04-03 Jan Djärv <jan.h.d@swipnet.se>
12881
12882 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
12883 if not defined (Bug#8403).
12884
376a7006
JB
128852011-04-02 Juanma Barranquero <lekktu@gmail.com>
12886
12887 * xdisp.c (display_count_lines): Remove parameter `start',
12888 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12889 (get_char_face_and_encoding): Remove parameter `multibyte_p',
12890 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12891 (fill_stretch_glyph_string): Remove parameters `row' and `area',
12892 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
12893 and thereabouts. All callers changed.
12894 (get_per_char_metric): Remove parameter `f', unused since
12895 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12896
6ca3801d
JM
128972011-04-02 Jim Meyering <meyering@redhat.com>
12898
12899 do not dereference NULL upon failed strdup
12900 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
12901 (ns_get_family): Likewise.
12902
d8e2b5ba
JB
129032011-04-02 Juanma Barranquero <lekktu@gmail.com>
12904
12905 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
12906
8c74fcbd
JD
129072011-04-02 Jan Djärv <jan.h.d@swipnet.se>
12908
12909 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
12910 later (Bug#8403).
12911
7200d79c
SM
129122011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
12913
03408648 12914 Add lexical binding.
7200d79c 12915
03408648
SM
12916 * window.c (Ftemp_output_buffer_show): New fun.
12917 (Fsave_window_excursion):
12918 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
12919
12920 * lread.c (lisp_file_lexically_bound_p): New function.
12921 (Fload): Bind Qlexical_binding.
12922 (readevalloop): Remove `evalfun' arg.
12923 Bind Qinternal_interpreter_environment.
12924 (Feval_buffer): Bind Qlexical_binding.
12925 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
12926 Mark as dynamic.
12927 (syms_of_lread): Declare `lexical-binding'.
12928
12929 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
12930
12931 * keyboard.c (eval_dyn): New fun.
12932 (menu_item_eval_property): Use it.
ca105506
SM
12933
12934 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 12935
03408648
SM
12936 * fns.c (concat, mapcar1): Accept byte-code-functions.
12937
12938 * eval.c (Fsetq): Handle lexical vars.
12939 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
12940 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
12941 (FletX, Flet): Obey lexical binding.
12942 (Fcommandp): Handle closures.
12943 (Feval): New `lexical' arg.
12944 (eval_sub): New function extracted from Feval. Use it almost
12945 everywhere where Feval was used. Look up vars in lexical env.
12946 Handle closures.
12947 (Ffunctionp): Move from subr.el.
12948 (Ffuncall): Handle closures.
12949 (apply_lambda): Remove `eval_flags'.
12950 (funcall_lambda): Handle closures and new byte-code-functions.
12951 (Fspecial_variable_p): New function.
12952 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
12953 but without exporting it to Lisp.
23aba0ea 12954
23aba0ea 12955 * doc.c (Fdocumentation, store_function_docstring):
03408648 12956 * data.c (Finteractive_form): Handle closures.
23aba0ea 12957
03408648
SM
12958 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
12959 interactive spec.
ba83908c 12960
04f2d78b
CB
12961 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
12962 New byte-codes.
03408648
SM
12963 (exec_byte_code): New function extracted from Fbyte_code to handle new
12964 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 12965
03408648 12966 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 12967
03408648 12968 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 12969
e2abce01
JB
129702011-03-31 Juanma Barranquero <lekktu@gmail.com>
12971
12972 * xdisp.c (redisplay_internal): Fix prototype.
12973
63696a73 129742011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 12975
63696a73 12976 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
12977 (try_scrolling): Use it when setting scroll_limit.
12978 Limit scrolling to 100 screen lines.
63696a73
EZ
12979 (redisplay_window): Even when falling back on "recentering",
12980 position point in the window according to scroll-conservatively,
12981 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
12982
12983 (try_scrolling): When point is above the window, allow searching
12984 as far as scroll_max, or one screenful, to compute vertical
12985 distance from PT to the scroll margin position. This prevents
12986 try_scrolling from unnecessarily failing when
12987 scroll-conservatively is set to a value slightly larger than the
12988 window height. Clean up the case of PT below the margin at bottom
12989 of window: scroll_max can no longer be INT_MAX. When aggressive
12990 scrolling is in use, don't let point enter the opposite scroll
12991 margin as result of the scroll.
12992 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
12993 threshold of 100 lines for never-recentering scrolling.
12994
e4cc2dfc
JB
129952011-03-31 Juanma Barranquero <lekktu@gmail.com>
12996
12997 * dispextern.h (move_it_by_lines):
12998 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
12999 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
13000 (message_log_check_duplicate): Remove parameters `prev_bol' and
13001 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13002 (redisplay_internal): Remove parameter `preserve_echo_area',
13003 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
13004
13005 * indent.c (Fvertical_motion):
13006 * window.c (window_scroll_pixel_based, Frecenter):
13007 Don't pass `need_y_p' to `move_it_by_lines'.
13008
1c470562
SM
130092011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
13010
44f230aa
SM
13011 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
13012 steal a few bits to be more compact.
13013 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
13014 Remove unneeded casts.
13015
1c470562
SM
13016 * bytecode.c (Fbyte_code): CAR and CDR can GC.
13017
888adce9
ZK
130182011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
13019
13020 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
13021 binding" message (bug#7967).
13022
f838ed7b
PE
130232011-03-30 Paul Eggert <eggert@cs.ucla.edu>
13024
77861b95
PE
13025 Fix more problems found by GCC 4.6.0's static checks.
13026
de6dbc14
PE
13027 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
13028 Remove unused local var.
13029
f838ed7b
PE
13030 * editfns.c (Fmessage_box): Remove unused local var.
13031
792c7b2b
PE
13032 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
13033 (note_mode_line_or_margin_highlight, note_mouse_highlight):
13034 Omit unused local vars.
c499e557 13035 * window.c (shrink_windows): Omit unused local var.
b01a1c29 13036 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
13037 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
13038 Omit unused local var.
13039
ba0165e1
PE
13040 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
13041 Don't assume string length fits in int.
32ad8845 13042 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 13043 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 13044
3c59b4c9
PE
13045 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
13046 instead of alloca (Bug#8344).
13047
a3eed478 13048 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 13049 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 13050
eb4d412d
PE
13051 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
13052
1658b401
PE
13053 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
13054 concerns.
13055
13056 * term.c (produce_glyphless_glyph): Remove unnecessary test.
13057
13058 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 13059
9a2c6e05
PE
13060 * keyboard.c (syms_of_keyboard): Use the same style as later
13061 in this function when indexing through an array. This also
13062 works around GCC bug 48267.
13063
03d0a109
PE
13064 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
13065
44f730c8
PE
13066 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
13067
fe75f926
PE
13068 * chartab.c (sub_char_table_ref_and_range): Redo for slight
13069 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
13070
ffa8c828
PE
13071 * keyboard.c, keyboard.h (num_input_events): Now size_t.
13072 This avoids undefined behavior on integer overflow, and is a bit
13073 more convenient anyway since it is compared to a size_t variable.
13074
c5101a77
PE
13075 Variadic C functions now count arguments with size_t, not int.
13076 This avoids an unnecessary limitation on 64-bit machines, which
13077 caused (substring ...) to crash on large vectors (Bug#8344).
13078 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
13079 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 13080 All variadic functions and their callers changed accordingly.
c5101a77
PE
13081 (struct gcpro.nvars): Now size_t, not int. All uses changed.
13082 * data.c (arith_driver, float_arith_driver): Likewise.
13083 * editfns.c (general_insert_function): Likewise.
13084 * eval.c (struct backtrace.nargs, interactive_p)
13085 (internal_condition_case_n, run_hook_with_args, apply_lambda)
13086 (funcall_lambda, mark_backtrace): Likewise.
13087 * fns.c (concat): Likewise.
13088 * frame.c (x_set_frame_parameters): Likewise.
13089 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
13090 0 if not found, not -1. All callers changed.
13091
dd3f25f7
PE
13092 * alloc.c (garbage_collect): Don't assume stack size fits in int.
13093 (stack_copy_size): Now size_t, not int.
13094 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
13095
461c2ab9
JB
130962011-03-28 Juanma Barranquero <lekktu@gmail.com>
13097
13098 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
13099 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13100 All callers changed.
13101
13102 * lisp.h (multibyte_char_to_unibyte):
13103 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
13104 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13105 * character.h (CHAR_TO_BYTE8):
13106 * cmds.c (internal_self_insert):
13107 * editfns.c (general_insert_function):
13108 * keymap.c (push_key_description):
13109 * search.c (Freplace_match):
13110 * xdisp.c (message_dolog, set_message_1): All callers changed.
13111
f6d62986
SM
131122011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
13113
13114 * keyboard.c (safe_run_hook_funcall): New function.
13115 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
13116 don't set the hook to nil, but remove the offending function instead.
13117 (Qcommand_hook_internal): Remove, unused.
13118 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
13119 Vcommand_hook_internal.
13120
13121 * eval.c (enum run_hooks_condition): Remove.
13122 (funcall_nil, funcall_not): New functions.
13123 (run_hook_with_args): Call each function through a `funcall' argument.
13124 Remove `cond' argument, now redundant.
13125 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
13126 (Frun_hook_with_args_until_failure): Adjust accordingly.
13127 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
13128
1db5b1ad
JB
131292011-03-28 Juanma Barranquero <lekktu@gmail.com>
13130
13131 * dispextern.h (string_buffer_position): Remove declaration.
13132
13133 * print.c (strout): Remove parameter `multibyte', unused since
13134 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
13135
13136 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
13137 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
13138 All callers changed.
13139
13140 * w32.c (_wsa_errlist): Use braces for struct initializers.
13141
13142 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
13143 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
13144 All callers changed.
13145 (string_buffer_position): Likewise. Also, make static (it's never
13146 used outside xdisp.c).
13147 (cursor_row_p): Remove parameter `w', unused since
13148 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
13149 (decode_mode_spec): Remove parameter `precision', introduced during
13150 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
13151 All callers changed.
13152
5ffb62aa
JD
131532011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13154
13155 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
13156
461c2ab9 131572011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
13158
13159 * nsterm.m (ns_menu_bar_is_hidden): New variable.
13160 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
13161 (ns_update_auto_hide_menu_bar): New functions.
13162 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
13163 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
13164 ns_constrain_all_frames.
13165 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
13166 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
13167
5c380ffb
JD
131682011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13169
13170 * nsmenu.m (runDialogAt): Remove argument to timer_check.
13171
9af30bdf
GM
131722011-03-27 Glenn Morris <rgm@gnu.org>
13173
13174 * syssignal.h: Replace RETSIGTYPE with void.
13175 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
13176 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
13177 Replace SIGTYPE with void everywhere.
13178 * s/usg5-4-common.h (SIGTYPE): Remove definition.
13179 * s/template.h (SIGTYPE): Remove commented out definition.
13180
e2abce01
JB
131812011-03-26 Eli Zaretskii <eliz@gnu.org>
13182
13183 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
13184 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
13185
f868cd8a
JB
131862011-03-26 Juanma Barranquero <lekktu@gmail.com>
13187
59eb0929
JB
13188 * w32.c (read_unc_volume): Use parameter `henum', instead of
13189 global variable `wget_enum_handle'.
13190
13191 * keymap.c (describe_vector): Remove parameters `indices' and
13192 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
13193 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
13194
f868cd8a
JB
13195 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
13196
13197 * keyboard.c (timer_check): Remove parameter `do_it_now',
13198 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
13199 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
13200 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
13201
13202 * keyboard.c (read_char):
13203 * w32menu.c (w32_menu_display_help):
13204 * xmenu.c (show_help_event, menu_help_callback):
13205 Adjust calls to `show_help_echo'.
13206
13207 * gtkutil.c (xg_maybe_add_timer):
13208 * keyboard.c (readable_events):
13209 * process.c (wait_reading_process_output):
13210 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
13211
13212 * insdel.c (adjust_markers_gap_motion):
13213 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
13214 (gap_left, gap_right): Don't call it.
13215
2ecf6fdb
CY
132162011-03-25 Chong Yidong <cyd@stupidchicken.com>
13217
13218 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
13219 incurred during fontification.
13220
6b1f9ba4
JB
132212011-03-25 Juanma Barranquero <lekktu@gmail.com>
13222
13223 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
13224 (DEFVAR_PER_BUFFER): Don't pass it.
13225
13226 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
13227 (scrolling_window): Don't pass it.
13228
0f4a96b5
JB
132292011-03-25 Juanma Barranquero <lekktu@gmail.com>
13230
13231 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
13232
13233 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
13234 and `suffix'.
13235 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
13236 of variables specific to SELinux and computation of `encoded_absname'.
13237
13238 * image.c (XPutPixel): Remove unused variable `height'.
13239
13240 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
13241
13242 * unexw32.c (get_section_info): Remove unused variable `section'.
13243
13244 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
13245 (system_process_attributes): Remove unused variable `sess'.
13246 (sys_read): Remove unused variable `err'.
13247
13248 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
13249 (w32_wnd_proc): Remove unused variable `isdead'.
13250 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
13251 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
13252 (x_create_tip_frame): Remove unused variable `tem'.
13253
13254 * w32inevt.c (w32_console_read_socket):
13255 Remove unused variable `no_events'.
13256
13257 * w32term.c (x_draw_composite_glyph_string_foreground):
13258 Remove unused variable `width'.
13259
1149507c
JB
132602011-03-24 Juanma Barranquero <lekktu@gmail.com>
13261
13262 * w32term.c (x_set_glyph_string_clipping):
13263 Don't pass uninitialized region to CombineRgn.
13264
9c88f339
JB
132652011-03-23 Juanma Barranquero <lekktu@gmail.com>
13266
13267 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
13268 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
13269 (Fx_close_connection): Remove unused variable `i'.
13270
13271 * w32font.c (w32font_draw): Return number of glyphs.
13272 (w32font_open_internal): Remove unused variable `i'.
13273 (w32font_driver): Add missing initializer.
13274
13275 * w32menu.c (utf8to16): Remove unused variable `utf16'.
13276 (fill_in_menu): Remove unused variable `items_added'.
13277
13278 * w32term.c (last_mouse_press_frame): Remove static global variable.
13279 (w32_clip_to_row): Remove unused variable `f'.
13280 (x_delete_terminal): Remove unused variable `i'.
13281
13282 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
13283 (NOTHING): Remove unused static global variable.
13284 (uniscribe_check_otf): Remove unused variable `table'.
13285 (uniscribe_font_driver): Add missing initializers.
13286
dee091a3
JD
132872011-03-23 Julien Danjou <julien@danjou.info>
13288
13289 * term.c (Fsuspend_tty, Fresume_tty):
13290 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
13291 * window.c (temp_output_buffer_show):
13292 * insdel.c (signal_before_change):
13293 * frame.c (Fhandle_switch_frame):
13294 * fileio.c (Fdo_auto_save):
13295 * emacs.c (Fkill_emacs):
13296 * editfns.c (save_excursion_restore):
13297 * cmds.c (internal_self_insert):
13298 * callint.c (Fcall_interactively):
13299 * buffer.c (Fkill_all_local_variables):
13300 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
13301 Use Frun_hooks.
0f4a96b5 13302 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 13303 unconditionally since it does the check itself.
dee091a3 13304
2c520ab5 133052011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 13306
c9c49752
PE
13307 Fix more problems found by GCC 4.5.2's static checks.
13308
8abc3f12
PE
13309 * coding.c (encode_coding_raw_text): Avoid unnecessary test
13310 the first time through the loop, since we know p0 < p1 then.
13311 This also avoids a gcc -Wstrict-overflow warning.
13312
a2d26660
PE
13313 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
13314 leading to a memory leak, possible in functions like
13315 load_charset_map_from_file that can allocate an unbounded number
b12ef411 13316 of objects (Bug#8318).
a2d26660 13317
916c72e9
PE
13318 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
13319 that could (at least in theory) be that large.
13320
19ab8a18
PE
13321 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
13322 This is less likely to overflow, and avoids undefined behavior if
13323 overflow does occur. All callers changed. Use strtoul to scan
13324 for the unsigned long integer.
b7cbbd6f
PE
13325 (pint2hrstr): Simplify and tune code slightly.
13326 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 13327
f0641eff
PE
13328 * scroll.c (do_scrolling): Work around GCC bug 48228.
13329 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
13330
7f650bb9
PE
13331 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
13332 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
13333 (validate_x_resource_name): Simplify count usage.
13334 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 13335
37dd57d1
PE
13336 * fileio.c (Fcopy_file): Report error if fchown or fchmod
13337 fail (Bug#8306).
81e56e61 13338
699979fc 13339 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 13340
401bf9b4
PE
13341 * process.c (Fmake_network_process): Use socklen_t, not int,
13342 where POSIX says socklen_t is required in portable programs.
13343 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 13344 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
13345 (Fmake_network_process, server_accept_connection):
13346 (wait_reading_process_output, read_process_output):
13347 Likewise.
13348
b93aacde
PE
13349 * process.c: Rename or move locals to avoid shadowing.
13350 (list_processes_1, Fmake_network_process):
13351 (read_process_output_error_handler, exec_sentinel_error_handler):
13352 Rename or move locals.
4dc343ee 13353 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 13354 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 13355 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 13356 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 13357 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 13358
af8a867c 13359 Make tparam.h and terminfo.c consistent.
44f230aa
SM
13360 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
13361 Include tparam.h instead, since it declares them.
af8a867c
PE
13362 * cm.h (PC): Remove extern decl; tparam.h now does this.
13363 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
13364 * terminfo.c: Include tparam.h, to check interfaces.
13365 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
13366 (tparam): Adjust signature to match interface in tparam.h;
13367 this removes some undefined behavior. Check that outstring and len
13368 are zero, which they always are with Emacs.
13369 * tparam.h (PC, BC, UP): New extern decls.
13370
0248044d 13371 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 13372 (xftfont_open): Rename locals to avoid shadowing.
0248044d 13373
8ff096c1 13374 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
13375 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
13376 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 13377 (ftfont_list): Remove unused local.
49eaafba
PE
13378 (get_adstyle_property, ftfont_pattern_entity):
13379 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
13380 Rename locals to avoid shadowing.
8ff096c1 13381
e2be39f6
PE
13382 * xfont.c (xfont_list_family): Mark var as initialized.
13383
c9735e30
PE
13384 * xml.c (make_dom): Now static.
13385
8f5201ae
PE
13386 * composite.c (composition_compute_stop_pos): Rename local to
13387 avoid shadowing.
b246f932
PE
13388 (composition_reseat_it): Remove unused locals.
13389 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 13390 (composition_update_it): Mark var as initialized.
11b61122
PE
13391 (find_automatic_composition): Mark vars as initialized,
13392 with a FIXME (Bug#8290).
8f5201ae 13393
760fbc2c
PE
13394 character.h: Rename locals to avoid shadowing.
13395 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
13396 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
13397 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
13398 (BUF_DEC_POS): Be more systematic about renaming local temporaries
13399 to avoid shadowing.
13400
ff08eb85
PE
13401 * textprop.c (property_change_between_p): Remove; unused.
13402
fc7bf025
PE
13403 * intervals.c (interval_start_pos): Now static.
13404
235d7abc
PE
13405 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
13406
44f230aa
SM
13407 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
13408 Rename locals to avoid shadowing.
3e7d6594 13409
50060332
PE
13410 * sound.c (wav_play, au_play, Fplay_sound_internal):
13411 Fix pointer signedness.
d01f234b 13412 (alsa_choose_format): Remove unused local var.
c83b8872
PE
13413 (wav_play): Initialize a variable to 0, to prevent undefined
13414 behavior (Bug#8278).
50060332 13415
c4fc4e30
PE
13416 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
13417
918436ed
PE
13418 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
13419
c939f91b
PE
13420 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
13421 clobbering (Bug#8298).
b9c7f648
PE
13422 * sysdep.c (sys_subshell): Likewise.
13423 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 13424
6bd8c144
PE
13425 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
13426 This should get cleaned up, so that child_setup has the
13427 same signature on all platforms.
13428
7710357c 13429 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 13430 (relocate_fd): Rename locals to avoid shadowing.
7710357c 13431
c59da222
CY
134322011-03-22 Chong Yidong <cyd@stupidchicken.com>
13433
13434 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
13435 not to be necessary, and produces flickering.
13436
66b87493
GM
134372011-03-20 Glenn Morris <rgm@gnu.org>
13438
13439 * config.in: Remove file.
13440
45b6f6d5
JB
134412011-03-20 Juanma Barranquero <lekktu@gmail.com>
13442
13443 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
13444 are now in src/globals.h.
13445 (syms_of_minibuf): Remove spurious & from previous change.
13446
cd394be1 134472011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
13448
13449 * minibuf.c (completing-read-function): New variable.
13450 (completing-read-default): Rename from completing-read.
13451 (completing-read): Call completing-read-function.
13452
b14e3e21
CY
134532011-03-19 Juanma Barranquero <lekktu@gmail.com>
13454
13455 * xfaces.c (Fx_load_color_file):
13456 Read color file from absolute filename (bug#8250).
13457
f2b726e6
JB
134582011-03-19 Juanma Barranquero <lekktu@gmail.com>
13459
13460 * makefile.w32-in: Update dependencies.
13461
09f6ff02
EZ
134622011-03-17 Eli Zaretskii <eliz@gnu.org>
13463
13464 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
13465
29a6015a
PE
134662011-03-17 Paul Eggert <eggert@cs.ucla.edu>
13467
a3a6c54e
PE
13468 Fix more problems found by GCC 4.5.2's static checks.
13469
b766f867
PE
13470 * process.c (make_serial_process_unwind, send_process_trap):
13471 (sigchld_handler): Now static.
13472
be02381c
PE
13473 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
13474 That way, the code declares only the vars that it needs.
13475 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
13476 * s/cygwin.h (PTY_ITERATION): Likewise.
13477 * s/darwin.h (PTY_ITERATION): Likewise.
13478 * s/gnu-linux.h (PTY_ITERATION): Likewise.
13479
57048744
PE
13480 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
13481 * process.c (allocate_pty): Don't declare stb unless it's needed.
13482
7914961c 13483 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
13484 (CONSTANTLIM): Remove; unused.
13485 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
13486 Define only if needed.
7914961c 13487
b3967b18
PE
13488 * unexelf.c (unexec): Name an expression,
13489 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
13490 Use a different way to cause a compilation error if anyone uses
13491 n rather than nn, a way that does not involve shadowing.
73366a00 13492 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 13493
29a6015a
PE
13494 * deps.mk (unexalpha.o): Remove; unused.
13495
43cfc33e 13496 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 13497 * unexec.h: New file.
ce701a33
PE
13498 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
13499 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
13500 Depend on unexec.h.
13501 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
13502 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
13503 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 13504 Change as necessary to match prototype in unexec.h.
ce701a33 13505
01f44d5a
PE
13506 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
13507 shadowing.
4f63c6bb 13508 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 13509
a6670b0b
PE
13510 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
13511 Rename locals to avoid shadowing.
13512
cef2010d 13513 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 13514 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 13515
d4d7173a
PE
13516 * print.c (Fredirect_debugging_output): Fix pointer signedess.
13517
f08b802a
PE
13518 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
13519 warning when compiling print.c.
13520
3ddb0639
PE
13521 * font.c (font_unparse_fcname): Abort in an "impossible" situation
13522 instead of using an uninitialized var.
5ad03b97 13523 (font_sort_entities): Mark var as initialized.
3ddb0639 13524
170a2692
PE
13525 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
13526
e663c700
PE
13527 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
13528 pointers to constants.
89bc529a 13529 (font_parse_fcname): Remove unused vars.
7b81e2d0 13530 (font_delete_unmatched): Now static.
ea838e10 13531 (font_get_spec): Remove; unused.
13a547c6
PE
13532 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
13533 (font_update_drivers, Ffont_get_glyphs, font_add_log):
13534 Rename or move locals to avoid shadowing.
e663c700 13535
2a80c887 13536 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 13537 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 13538
1384fa33 13539 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 13540 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 13541
8b2c52e9
PE
13542 * alloc.c (mark_backtrace): Move decl from here ...
13543 * lisp.h: ... to here, so that it can be checked.
13544
475545b5 13545 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 13546 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
13547 (lisp_indirect_variable): Name an expression,
13548 to avoid gcc -Wbad-function-cast warning.
1faed8ae 13549 (Fdefvar): Rename locals to avoid shadowing.
475545b5 13550
b1349114 13551 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 13552 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 13553 Use const pointer when appropriate.
b1349114 13554
a2928364
PE
13555 * lisp.h (get_system_name, get_operating_system_release):
13556 Move decls here, to check interfaces.
13557 * process.c (get_operating_system_release): Move decl to lisp.h.
13558 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
13559 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
13560 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
13561 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
13562 (Fformat_time_string, Fencode_time, Finsert_char):
13563 (Ftranslate_region_internal, Fformat):
13564 Rename or remove local vars to avoid shadowing.
9710023e 13565 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 13566
a415e694
PE
13567 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
13568 avoid shadowing.
13569
8ef4622d
PE
13570 * lisp.h (eassert): Check that the argument compiles, even if
13571 ENABLE_CHECKING is not defined.
13572
946f9a5b
PE
13573 * data.c (Findirect_variable): Name an expression, to avoid
13574 gcc -Wbad-function-cast warning.
112396d6 13575 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 13576 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
13577 (Fmake_variable_buffer_local, Fmake_local_variable):
13578 Mark variables as initialized.
52746918 13579 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 13580
e5aab7e7 13581 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
13582 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
13583 Rename locals to avoid shadowing.
dff45157
PE
13584 (mark_stack): Move local variables into the #ifdef region where
13585 they're used.
7bc26fdb
PE
13586 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
13587 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
13588 needed otherwise.
13589 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
13590 (GC_STRING_CHARS): Remove; not used.
d40d4be1 13591 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 13592
e5aab7e7
PE
13593 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
13594 avoids undefined behavior in theory.
13595
4da60324
PE
13596 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
13597
88043301
PE
13598 Use functions, not macros, for up- and down-casing (Bug#8254).
13599 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13600 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
13601 to use the following functions instead of these macros.
13602 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
13603 EMACS_INT, since callers assume the returned value fits in int.
13604 (upcase1): Likewise, for UPCASE_TABLE.
13605 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 13606 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 13607 the race-condition problem in the old DOWNCASE.
88043301 13608
19ed5445
PE
13609 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
13610 Rename locals to avoid shadowing.
13611 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
13612 (regex_compile, re_search_2, re_match_2_internal):
13613 Remove unused local vars.
952db0d7
PE
13614 (FREE_VAR): Rewrite so as not to use empty "else",
13615 which gcc can warn about.
da053e48 13616 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
13617 (RETALLOC_IF): Define only if needed.
13618 (WORDCHAR_P): Likewise. This one is never needed, but is used
13619 only in a comment talking about a compiler bug, so put inside
13620 the #if 0 of that comment.
13621 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
13622 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
13623 Remove; unused.
19ed5445 13624
1f3561e4 13625 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
13626 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
13627 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 13628
ded6f8f7
PE
13629 * search.c (simple_search): Remove unused var.
13630
dbd37a95
PE
13631 * dired.c (compile_pattern): Move decl from here ...
13632 * lisp.h: ... to here, so that it can be checked.
13633 (struct re_registers): New forward decl.
13634
7e47afad
PE
13635 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
13636
85f24f61
PE
13637 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
13638 All uses changed.
13639 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
13640 Rename locals to avoid shadowing.
5671df8f 13641 (Fvertical_motion): Mark locals as initialized.
85f24f61 13642
181aa2be 13643 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 13644 (casify_region): Mark local as initialized.
181aa2be 13645
930d429c
PE
13646 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
13647
7082eac6
PE
13648 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
13649 New macros, so that the caller can use some names other than
13650 gcpro1, gcpro2, etc.
13651 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
13652 of the new macros.
13653 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
13654 argument, for consistency with GCPRO2_VAR, etc: it is now the
13655 prefix of the variable, not the variable itself. All uses
13656 changed.
38b2c076
PE
13657 * dired.c (directory_files_internal, file_name_completion):
13658 Rename locals to avoid shadowing.
13659
15206ed9
PE
13660 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
13661 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
13662 dired.c's scmp function, had undefined behavior.
13663 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13664 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
13665 * buffer.h: ... to here, because these macros use current_buffer,
13666 and the new implementation with inline functions needs to have
13667 current_buffer in scope now, rather than later when the macros
13668 are used.
13669 (downcase, upcase1): New static inline functions.
13670 (DOWNCASE, UPCASE1): Reimplement using these functions.
13671 This avoids undefined behavior in expressions like
13672 DOWNCASE (x) == DOWNCASE (y), which previously suffered
13673 from race conditions in accessing the global variables
13674 case_temp1 and case_temp2.
13675 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
13676 * lisp.h (case_temp1, case_temp2): Remove their decls.
13677 * character.h (ASCII_CHAR_P): Move from here ...
13678 * lisp.h: ... to here, so that the inline functions mentioned
13679 above can use them.
13680
4a6bea26
PE
13681 * dired.c (directory_files_internal_unwind): Now static.
13682
f14b7e14
PE
13683 * fileio.c (file_name_as_directory, directory_file_name):
13684 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
13685 Now static.
2893f146
PE
13686 (file_name_as_directory): Use const pointers when appropriate.
13687 (Fexpand_file_name): Likewise. In particular, newdir might
13688 point at constant storage, so make it a const pointer.
fd4ead52 13689 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
13690 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
13691 signedness issues.
f839df0c
PE
13692 (Fset_file_times, Finsert_file_contents, auto_save_error):
13693 Rename locals to avoid shadowing.
f14b7e14 13694
5716756e 13695 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
13696 (Ftry_completion, Fall_completions): Rename or remove locals
13697 to avoid shadowing.
5716756e 13698
b4c3046a
PE
13699 * marker.c (bytepos_to_charpos): Remove; unused.
13700
b45db522
PE
13701 * lisp.h (verify_bytepos, count_markers): New decls,
13702 so that gcc does not warn that these functions aren't declared.
13703
85876d07
PE
13704 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
13705 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 13706 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 13707 (copy_text): Remove unused local var.
85876d07 13708
03d78a21 13709 * filelock.c (within_one_second): Now static.
b3dd38ab 13710 (lock_file_1): Rename local to avoid shadowing.
03d78a21 13711
5df8f01b
PE
13712 * buffer.c (fix_overlays_before): Mark locals as initialized.
13713 (fix_start_end_in_overlays): Likewise. This function should be
13714 simplified by using pointers-to-pointers, but that's a different
13715 matter.
b1d876f1 13716 (switch_to_buffer_1): Now static.
8f54f30a
PE
13717 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
13718 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 13719
a70072c9 13720 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 13721 Fix pointer signedness issue.
edced198
PE
13722 (sys_subshell): Mark local as volatile if checking for lint,
13723 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 13724 (MAXPATHLEN): Define only if needed.
a70072c9 13725
a0977c44
PE
13726 * process.c (serial_open, serial_configure): Move decls from here ...
13727 * systty.h: ... to here, so that they can be checked.
13728
a884fdcc
PE
13729 * fns.c (get_random, seed_random): Move extern decls from here ...
13730 * lisp.h: ... to here, so that they can be checked.
13731
604efe86 13732 * sysdep.c (reset_io): Now static.
b8950c94 13733 (wait_for_termination_signal): Remove; unused.
604efe86 13734
38fc62d9
PE
13735 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
13736 (copy_keymap_item, append_key, push_text_char_description):
13737 Now static.
1004a21a 13738 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 13739 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
13740 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
13741 (describe_map_tree):
13742 Rename locals to avoid shadowing.
38fc62d9 13743
2f2650da
PE
13744 * keyboard.c: Declare functions static if they are not used elsewhere.
13745 (echo_char, echo_dash, cmd_error, top_level_2):
13746 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
13747 (read_char, kbd_buffer_get_event, make_lispy_position):
13748 (make_lispy_event, make_lispy_movement, apply_modifiers):
13749 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
13750 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
13751 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 13752 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 13753 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 13754
a053e86c 13755 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
13756 (mark_kboards): Move decl here ...
13757 * alloc.c (mark_kboards): ... from here.
a053e86c 13758
4752793e
PE
13759 * lisp.h (force_auto_save_soon): New decl.
13760
74f10ca7 13761 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
13762 (DEFINE_DUMMY_FUNCTION): New macro.
13763 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
13764 Use it.
c03cd23f
PE
13765 (main): Add casts to avoid warnings
13766 if GCC considers string literals to be constants.
74f10ca7 13767
022e70d4
PE
13768 * lisp.h (fatal_error_signal): Add decl, since it's exported.
13769
59d6fe83
PE
13770 * dbusbind.c: Pointer signedness fixes.
13771 (xd_signature, xd_append_arg, xd_initialize):
13772 (Fdbus_call_method, Fdbus_call_method_asynchronously):
13773 (Fdbus_method_return_internal, Fdbus_method_error_internal):
13774 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
13775 (Fdbus_register_signal): Use SSDATA when the context wants char *.
13776
78320123
PE
13777 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
13778 if GCC considers string literals to be constants.
49cebcca 13779 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 13780
35ac2a97
SM
137812011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
13782
fb103ca9
SM
13783 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
13784 (print_preprocess, print_object): New macro to fix last change.
13785
35ac2a97
SM
13786 * print.c (print_preprocess): Don't forget font objects.
13787
62973b41
JB
137882011-03-16 Juanma Barranquero <lekktu@gmail.com>
13789
13790 * emacs.c (USAGE3): Doc fixes.
13791
0e48bb22
AS
137922011-03-15 Andreas Schwab <schwab@linux-m68k.org>
13793
13794 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
13795 structure.
13796
7684e57b
JB
137972011-03-14 Juanma Barranquero <lekktu@gmail.com>
13798
13799 * lisp.h (VWindow_system, Qfile_name_history):
13800 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
13801 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
13802 (w32_system_caret_x, w32_system_caret_y): Declare extern.
13803
13804 * w32select.c: Don't #include "keyboard.h".
c96bbc66 13805 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
13806
13807 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
13808 * w32console.c (detect_input_pending, read_input_pending)
13809 (encode_terminal_code):
13810 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
13811 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
13812 (w32_system_caret_y, Qfile_name_history):
13813 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
13814 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
13815 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
13816 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
13817 * w32proc.c (Qlocal, report_file_error):
13818 * w32term.c (Vwindow_system, updating_frame):
13819 * w32uniscribe.c (initialized, uniscribe_font_driver):
13820 Remove unneeded extern declarations.
13821
2aa46d6c
CY
138222011-03-14 Chong Yidong <cyd@stupidchicken.com>
13823
c96bbc66 13824 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 13825
cffc6f3b
CY
138262011-03-13 Chong Yidong <cyd@stupidchicken.com>
13827
13828 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
13829 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
13830 These macros can no longer be used for assignment.
13831
44f230aa
SM
13832 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
13833 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
13834 (record_buffer_markers, fetch_buffer_markers): New functions for
13835 recording and fetching special buffer markers.
13836 (set_buffer_internal_1, set_buffer_temp): Use them.
13837
13838 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
13839
13840 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
13841
13842 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
13843 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
13844
13845 * xdisp.c (hscroll_window_tree):
13846 (reconsider_clip_changes): Use PT instead of BUF_PT.
13847
d251f04b
EZ
138482011-03-13 Eli Zaretskii <eliz@gnu.org>
13849
13850 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
13851 $(EMACS_ROOT)/lib/intprops.h.
13852
f0c77cd1
PE
138532011-03-13 Paul Eggert <eggert@cs.ucla.edu>
13854
3eca4629
PE
13855 Fix more problems found by GCC 4.5.2's static checks.
13856
7c86ee98
PE
13857 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
13858 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
13859 (xg_free_frame_widgets): Make it clear that a local variable is
13860 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
13861 (gdk_window_get_screen): Make it clear that this macro is needed
13862 only if USE_GTK_TOOLTIP.
1e5524e7
PE
13863 (int_gtk_range_get_value): New function, which avoids a diagnostic
13864 from gcc -Wbad-function-cast.
13865 (xg_set_toolkit_scroll_bar_thumb): Use it.
13866 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
13867 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
13868 (get_utf8_string, xg_get_file_with_chooser):
13869 Rename locals to avoid shadowing.
13870 (create_dialog): Move locals to avoid shadowing.
7c86ee98 13871
41729b81
PE
13872 * xgselect.c (xg_select): Remove unused var.
13873
f0c77cd1
PE
13874 * image.c (four_corners_best): Mark locals as initialized.
13875 (gif_load): Initialize transparent_p to zero (Bug#8238).
13876 Mark another local as initialized.
ec6cf4c6 13877 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 13878
ce0ad53d 13879 * image.c (clear_image_cache): Now static.
d5d5a617 13880 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 13881 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
13882 (x_edge_detection): Remove unnecessary cast that
13883 gcc -Wbad-function-cast diagnoses.
2037898d 13884 (gif_load): Fix pointer signedness.
6ae141d6
PE
13885 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
13886 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 13887
33383987 138882011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 13889
d32df629
PE
13890 Improve quality of tests for time stamp overflow.
13891 For example, without this patch (encode-time 0 0 0 1 1
13892 1152921504606846976) returns the obviously-bogus value (-948597
13893 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
13894 reports time overflow. See
13895 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
13896 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
13897 * editfns.c: Include limits.h and intprops.h.
13898 (TIME_T_MIN, TIME_T_MAX): New macros.
13899 (time_overflow): Move earlier, to before first use.
13900 (hi_time, lo_time): New functions, for an accurate test for
13901 out-of-range times.
13902 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
13903 (Fget_internal_run_time): Don't assume time_t fits in int.
13904 (make_time): Use list2 instead of Fcons twice.
13905 (Fdecode_time): More accurate test for out-of-range times.
13906 (check_tm_member): New function.
13907 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
13908 (lisp_time_argument): Don't rely on undefined left-shift and
13909 right-shift behavior when checking for time stamp overflow.
8be6f318 13910
fe31d94c
PE
13911 * editfns.c (time_overflow): New function, refactoring common code.
13912 (Fformat_time_string, Fdecode_time, Fencode_time):
13913 (Fcurrent_time_string): Use it.
13914
8be6f318
PE
13915 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
13916 * dired.c (make_time): Move to ...
13917 * editfns.c (make_time): ... here.
13918 * systime.h: Note the move.
13919
09d9db2c 139202011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 13921
126bc0dc
YM
13922 * fringe.c (update_window_fringes): Remove unused variables.
13923
c47cbdfd
YM
13924 * unexmacosx.c (copy_data_segment): Also copy __got section.
13925 (Bug#8223)
13926
7ac80be9
EZ
139272011-03-12 Eli Zaretskii <eliz@gnu.org>
13928
c96bbc66 13929 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
13930 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
13931 Constify `char *' arguments and their references according to
13932 prototypes in tparam.h.
13933
ecb0f94d 13934 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 13935
7ac80be9
EZ
13936 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
13937 Adapt all references accordingly.
13938
13939 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
13940
ef1fd07e
TT
139412011-03-11 Tom Tromey <tromey@redhat.com>
13942
13943 * buffer.c (syms_of_buffer): Remove obsolete comment.
13944
7ef4b50c
EZ
139452011-03-11 Eli Zaretskii <eliz@gnu.org>
13946
13947 * termhooks.h (encode_terminal_code): Declare prototype.
13948
13949 * msdos.c (encode_terminal_code): Don't declare prototype.
13950
13951 * term.c (encode_terminal_code): Now external again, used by
13952 w32console.c and msdos.c.
13953
44f230aa
SM
13954 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
13955 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 13956
4b1ec863 139572011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 13958
1714f52b 13959 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 13960
4b1ec863
PE
13961 * fringe.c (update_window_fringes): Mark locals as initialized
13962 (Bug#8227).
13963 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 13964
524c7aa6
PE
13965 * alloc.c (mark_fringe_data): Move decl from here ...
13966 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
13967 to check its interface.
13968 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
13969
a5c0af81 13970 * fontset.c (free_realized_fontset): Now static.
7519b8cd 13971 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 13972 (fontset_font): Mark local as initialized.
a9a06e0b 13973 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 13974
b4716021
PE
13975 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
13976
811e9bac 13977 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 13978 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
13979 (x_own_selection, Fx_disown_selection_internal): Rename locals
13980 to avoid shadowing.
13981 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 13982
7e3ab302
PE
13983 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
13984 so that the caller can use some name other than gcpro1.
13985 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
13986 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13987 (Fx_backspace_delete_keys_p):
13988 Use them to avoid shadowing, and rename vars to avoid shadowing.
13989 (x_decode_color, x_set_name, x_window): Now static.
6b437900 13990 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 13991 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
13992 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
13993 Remove unused locals.
7e3ab302
PE
13994 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13995 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
13996 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
13997 macros.
f78faa98 13998
e2b13473
PE
13999 * xterm.h (x_mouse_leave): New decl.
14000
77f23912
PE
14001 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
14002 Remove unused functions.
cdf4ba58
PE
14003 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
14004 (x_calc_absolute_position): Now static.
7411c686 14005 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 14006 Don't declare local "event" unless it's used.
ed7bf3a5
PE
14007 (x_iconify_frame, x_free_frame_resources): Don't declare locals
14008 unless they are used.
38d0b34a
PE
14009 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
14010 (x_fatal_error_signal): Remove; not used.
a6067996
PE
14011 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
14012 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
14013 (x_error_catcher, x_connection_closed, x_error_handler):
14014 (x_error_quitter, xembed_send_message, x_iconify_frame):
14015 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 14016 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 14017 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 14018
44f230aa
SM
14019 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
14020 Rename or move locals to avoid shadowing.
6b463e58 14021 (tty_defined_color, merge_face_heights): Now static.
5967d051 14022 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
14023 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
14024 does not deduce is never used uninitialized.
73719eba
PE
14025 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
14026 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 14027
426994c3 14028 * terminal.c (store_terminal_param): Now static.
5489860b 14029
032f1620 14030 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 14031 (set_frame_menubar): Remove unused local.
d4323972 14032 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
14033 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
14034 since they might point to immutable storage.
281585b0
PE
14035 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
14036 since it's unused otherwise.
032f1620 14037
367c19e5 14038 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 14039 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
14040 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
14041 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 14042 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
14043 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
14044 does not deduce are never used uninitialized.
70739cbe 14045
07b48fa9
PE
14046 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
14047
8868a238 14048 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
14049 * window.c (window_loop, size_window):
14050 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 14051
7e5cf297 14052 * window.c (display_buffer): Now static.
d6550a9f
PE
14053 (size_window): Mark variables that gcc -Wuninitialized
14054 does not deduce are never used uninitialized.
a586633d
PE
14055 * window.h (check_all_windows): New decl, to forestall
14056 gcc -Wmissing-prototypes diagnostic.
5b555da1 14057 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 14058
f6095868
PE
14059 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
14060 shadowing.
14061 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
14062 Include <limits.h>.
14063 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
14064 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
14065 (load_charset_map): Mark variables that gcc -Wuninitialized
14066 does not deduce are never used uninitialized.
53df7c11 14067 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 14068
f38b440c
PE
14069 * coding.c (coding_set_source, coding_set_destination):
14070 Use "else { /* comment */ }" rather than "else /* comment */;"
14071 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
14072 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
14073 a block, when the outer 'i' will do.
14074 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
14075 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
14076 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
14077 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
14078 (Fdecode_sjis_char, Fdefine_coding_system_internal):
14079 Rename locals to avoid shadowing.
14080 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
14081 * coding.c (emacs_mule_char, encode_invocation_designation):
14082 Now static, since they're not used elsewhere.
413bb2db 14083 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 14084 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
14085 (decode_coding_emacs_mule): Mark variables that gcc
14086 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
14087 (detect_coding_iso_2022): Initialize a local variable that might
14088 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 14089 this initialization is needed. (Bug#8211)
5f58e762
PE
14090 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
14091 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
14092 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
14093 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
14094 Remove unused macros.
f38b440c 14095
232b38b9 14096 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 14097 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 14098 * character.c (string_count_byte8): Likewise.
232b38b9 14099
fb90da1b
PE
14100 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
14101 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
14102
fb93dbc2
PE
14103 * chartab.c (copy_sub_char_table): Now static, since it's not used
14104 elsewhere.
5c156ace
PE
14105 (sub_char_table_ref_and_range, char_table_ref_and_range):
14106 Rename locals to avoid shadowing.
bbcd0949 14107 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 14108
7d3b3862 14109 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 14110 (BIDI_BOB): Remove unused macro.
7d3b3862 14111
6be7d3da
PE
14112 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
14113 deduce are never used uninitialized.
c2ed9c8b 14114 * term.c (encode_terminal_code): Likewise.
6be7d3da 14115
75f8807f 14116 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 14117
50938595
PE
14118 * tparam.h: New file.
14119 * term.c, tparam.h: Include it.
14120 * deps.mk (term.o, tparam.o): Depend on tparam.h.
14121 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
14122 Move these decls to tparam.h, and make them agree with what
14123 is actually in tparam.c. The previous trick of using incompatible
14124 decls in different modules does not conform to the C standard.
14125 All callers of tparam changed to use tparam's actual API.
14126 * tparam.c (tparam1, tparam, tgoto):
14127 Use const pointers where appropriate.
14128
fbceeba2
PE
14129 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
14130 * cm.h (struct cm): Likewise.
14131 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
14132 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
14133 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
14134 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
14135 (turn_on_face, init_tty): Likewise.
14136 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 14137
7f3f1250
PE
14138 * term.c (term_mouse_position): Rename local to avoid shadowing.
14139
e6ca6543
PE
14140 * alloc.c (mark_ttys): Move decl from here ...
14141 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
14142
c40f8d15
AS
141432011-03-11 Andreas Schwab <schwab@linux-m68k.org>
14144
14145 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
14146
cfe0661d
JB
141472011-03-09 Juanma Barranquero <lekktu@gmail.com>
14148
14149 * search.c (compile_pattern_1): Remove argument regp, unused since
14150 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
14151 (compile_pattern): Don't pass it.
14152
0afb4571
J
141532011-03-08 Jan Djärv <jan.h.d@swipnet.se>
14154
14155 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
14156 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
14157 for ! HAVE_GTK3.
14158 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
14159
14160 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
14161
14162 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
14163 gdk_window_get_screen, gdk_window_get_geometry,
14164 gdk_x11_window_lookup_for_display and GDK_KEY_g.
14165 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
14166 (xg_get_pixbuf_from_pixmap): New function.
14167 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
14168 to Pixmap, take frame as parameter, remove GdkColormap parameter.
14169 Call xg_get_pixbuf_from_pixmap instead of
14170 gdk_pixbuf_get_from_drawable.
14171 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
14172 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
14173 (xg_check_special_colors): Use GtkStyleContext and its functions
14174 for HAVE_GTK3.
14175 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
14176 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
14177 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
14178 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
14179 Call gtk_widget_get_preferred_size.
0afb4571
J
14180 (xg_frame_resized): gdk_window_get_geometry only takes 5
14181 parameters.
44f230aa
SM
14182 (xg_win_to_widget, xg_event_is_for_menubar):
14183 Call gdk_x11_window_lookup_for_display.
0afb4571
J
14184 (xg_set_widget_bg): New function.
14185 (delete_cb): New function.
895009e1 14186 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 14187 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
14188 (xg_set_background_color): Call xg_set_widget_bg.
14189 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
14190 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
14191 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
14192 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
14193 if ! HAVE_GTK3.
14194 (update_frame_tool_bar): Call gtk_widget_hide.
14195 (xg_initialize): Use GDK_KEY_g.
14196
14197 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
14198 if ! HAVE_GTK3
14199 (x_session_initialize): Call gdk_x11_set_sm_client_id.
14200
14201 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
14202 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
14203 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
14204
1c2cc4ef
JB
142052011-03-08 Juanma Barranquero <lekktu@gmail.com>
14206
14207 * w32xfns.c (select_palette): Check success of RealizePalette against
14208 GDI_ERROR, not zero.
14209
33383987 14210See ChangeLog.11 for earlier changes.
aac0c6e3
MR
14211
14212;; Local Variables:
14213;; coding: utf-8
aac0c6e3
MR
14214;; End:
14215
2f097256 14216 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
14217
14218 This file is part of GNU Emacs.
14219
14220 GNU Emacs is free software: you can redistribute it and/or modify
14221 it under the terms of the GNU General Public License as published by
14222 the Free Software Foundation, either version 3 of the License, or
14223 (at your option) any later version.
14224
14225 GNU Emacs is distributed in the hope that it will be useful,
14226 but WITHOUT ANY WARRANTY; without even the implied warranty of
14227 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14228 GNU General Public License for more details.
14229
14230 You should have received a copy of the GNU General Public License
14231 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.