Random fixes. E.g., (random) never returned negative values.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
d8ed26bd
PE
12011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2
3 Random fixes. E.g., (random) never returned negative values.
4 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
5 subseconds part to the entropy, as that's a bit more random.
6 Prefer signed to unsigned, since the signedness doesn't matter and
7 in general we prefer signed. When given a limit, use a
8 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
9 latter isn't right if USE_2_TAGS_FOR_INTS.
10 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
11 not 0..VALMASK. Don't discard "excess" bits that random () returns.
12
cabf1cac
SM
132011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
14
15 * textprop.c (text_property_stickiness):
16 Obey Vtext_property_default_nonsticky.
17 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
18 * w32fns.c (syms_of_w32fns):
19 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
20
6e9b2be9
PE
212011-07-04 Paul Eggert <eggert@cs.ucla.edu>
22
23 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
24 This is more efficient than Ffile_directory_p and avoids a minor race.
25
90186c68
LMI
262011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
27
7c301272
LMI
28 * buffer.c (Foverlay_put): Say what the return value is
29 (bug#7835).
30
c4f2d8d4
LMI
31 * fileio.c (barf_or_query_if_file_exists): Check first if the file
32 is a directory before asking whether to use the file name
33 (bug#7564).
ad637907
LMI
34 (barf_or_query_if_file_exists): Make the "File is a directory"
35 error be more correct.
c4f2d8d4 36
90186c68
LMI
37 * fns.c (Frequire): Remove the mention of the .gz files, since
38 that's installation-specific, but keep the mention of
39 `get-load-suffixes'.
40
da64016e
PE
412011-07-04 Paul Eggert <eggert@cs.ucla.edu>
42
43 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
44 Report string overflow if the output is too long.
45
7d47b580
JB
462011-07-04 Juanma Barranquero <lekktu@gmail.com>
47
a555cb87
JB
48 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
49 (syms_of_gnutls): Remove duplicate DEFSYM for
50 Qgnutls_bootprop_verify_hostname_error, an error for
51 Qgnutls_bootprop_verify_error (which is no longer used).
52
7d47b580
JB
53 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
54 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
55 Also (re)move comments that are misplaced or no longer relevant.
56
1e49bfab
LMI
572011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
58
59 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
60
1485f4c0
CY
612011-07-03 Chong Yidong <cyd@stupidchicken.com>
62
63 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
64 and background color parameters if they have been changed.
65
a9ab721e
LMI
662011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
67
68 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
69
cf7cff57
PE
702011-07-03 Paul Eggert <eggert@cs.ucla.edu>
71
2e13213d
PE
72 * xsettings.c (SYSTEM_FONT): Define only when used.
73 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
74
cf7cff57
PE
75 * keymap.c (access_keymap_1): Now static.
76
7a8e04f7
CY
772011-07-02 Chong Yidong <cyd@stupidchicken.com>
78
79 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
80 leave any prefix arg for the up event (Bug#1586).
81
61352f62
LMI
822011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
83
69bb1ef7
LMI
84 * lread.c (syms_of_lread): Mention single symbols defined by
85 `defvar' or `defconst' (bug#7154).
86
61352f62 87 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 88 (Frequire): Mention get-load-suffixes.
61352f62 89
28545e04
MR
902011-07-02 Martin Rudalics <rudalics@gmx.at>
91
92 * window.h (window): Remove clone_number slot.
93 * window.c (Fwindow_clone_number, Fset_window_clone_number):
94 Remove.
95 (make_parent_window, make_window, saved_window)
96 (Fset_window_configuration, save_window_save): Don't deal with
97 clone numbers.
98 * buffer.c (Qclone_number): Remove declaration.
99 (sort_overlays, overlay_strings): Don't deal with clone numbers.
100
3349e122
SM
1012011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
102
103 Add multiple inheritance to keymaps.
104 * keymap.c (Fmake_composed_keymap): New function.
105 (Fset_keymap_parent): Simplify.
106 (fix_submap_inheritance): Remove.
107 (access_keymap_1): New function extracted from access_keymap to handle
108 embedded parents and handle lists of maps.
109 (access_keymap): Use it.
110 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
111 (Fcopy_keymap): Handle embedded parents.
112 (Fcommand_remapping, define_as_prefix): Simplify.
113 (Fkey_binding): Simplify.
114 (syms_of_keymap): Move minibuffer-local-completion-map,
115 minibuffer-local-filename-completion-map,
116 minibuffer-local-must-match-map, and
117 minibuffer-local-filename-must-match-map to Elisp.
118 (syms_of_keymap): Defsubr make-composed-keymap.
119 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
120 (parse_menu_item): Trivial simplification.
121
3279eb87
GM
1222011-07-01 Glenn Morris <rgm@gnu.org>
123
124 * Makefile.in (SETTINGS_LIBS): Fix typo.
125
4550efdf
KI
1262011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
127
128 * coding.c (Fencode_coding_string): Record the last coding system
129 used, as the function doc string says (bug#8738).
130
0949d2b6
JD
1312011-07-01 Jan Djärv <jan.h.d@swipnet.se>
132
133 * xsettings.c (store_monospaced_changed): Take new font as arg and
134 check for change against current_mono_font.
135 (EMACS_TYPE_SETTINGS): Remove this and related defines.
136 (emacs_settings_constructor, emacs_settings_get_property)
137 (emacs_settings_set_property, emacs_settings_class_init)
138 (emacs_settings_init, gsettings_obj): Remove.
139 (something_changedCB): New function for HAVE_GSETTINGS.
140 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
141 with value as argument.
142 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
143 g_settings_new (Bug#8967). Do not create gsettings_obj.
144 Remove calls to g_settings_bind. Connect something_changedCB to
145 "changed".
146
147 * xgselect.c: Add defined (HAVE_GSETTINGS).
148 (xgselect_initialize): Ditto.
149
150 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
151 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
152 xg_select.
153
bbc6b304
PE
1542011-07-01 Paul Eggert <eggert@cs.ucla.edu>
155
156 * eval.c (struct backtrace): Simplify and port the data structure.
157 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
158 signed bit field, as this assumption is not portable and it makes
159 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
160 "char debug_on_exit : 1" as this is not portable either; instead,
161 use the portable "unsigned int debug_on_exit : 1". Remove unused
162 member evalargs. Remove obsolete comments about cc bombing out.
163
9851bfc5
JD
1642011-06-30 Jan Djärv <jan.h.d@swipnet.se>
165
51bb811f 166 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
167 Let HAVE_GSETTINGS override HAVE_GCONF.
168 (store_monospaced_changed): New function.
169 (EMACS_SETTINGS): A new type derived from GObject to handle
170 GSettings notifications.
171 (emacs_settings_constructor, emacs_settings_get_property)
172 (emacs_settings_set_property, emacs_settings_class_init):
173 New functions.
174 (gsettings_client, gsettings_obj): New variables.
175 (GSETTINGS_SCHEMA): New define.
176 (something_changedCB): Call store_monospaced_changed.
177 (init_gsettings): New function.
178 (xsettings_initialize): Call init_gsettings.
179 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
180 to NULL.
181
182 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
183 GCONF_CFLAGS/LIBS.
184
5386012d
MR
1852011-06-29 Martin Rudalics <rudalics@gmx.at>
186
187 * window.c (resize_root_window, grow_mini_window)
188 (shrink_mini_window): Rename Qresize_root_window to
189 Qwindow_resize_root_window and Qresize_root_window_vertically to
190 Qwindow_resize_root_window_vertically.
191
f13e0b08
PE
1922011-06-28 Paul Eggert <eggert@cs.ucla.edu>
193
194 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
195
94515237
JB
1962011-06-27 Juanma Barranquero <lekktu@gmail.com>
197
198 * makefile.w32-in: Redesign dependencies so they reflect more
199 clearly which files are directly included by each source file,
200 and not through other includes.
201
e43b6e43
MR
2022011-06-27 Martin Rudalics <rudalics@gmx.at>
203
204 * buffer.c (Qclone_number): Declare static and DEFSYM it.
205 (sort_overlays, overlay_strings): When an overlay's clone number
206 matches the window's clone number process the overlay even if
207 the overlay's window property doesn't match the current window.
208
d68443dc
MR
209 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
210 (Fwindow_hchild): Rename to Fwindow_left_child.
211 (Fwindow_next): Rename to Fwindow_next_sibling.
212 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
213 (resize_window_check): Rename to window_resize_check.
214 (resize_window_apply): Rename to window_resize_apply.
215 (Fresize_window_apply): Rename to Fwindow_resize_apply.
216 (Fdelete_other_windows_internal, resize_frame_windows)
217 (Fsplit_window_internal, Fdelete_window_internal)
218 (grow_mini_window, shrink_mini_window)
219 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 220
c7e73be5
JD
2212011-06-26 Jan Djärv <jan.h.d@swipnet.se>
222
223 * emacsgtkfixed.h: State that this is only used with Gtk+3.
224 (emacs_fixed_set_min_size): Remove.
225 (emacs_fixed_new): Take frame as argument.
226
227 * emacsgtkfixed.c: State that this is only used with Gtk+3.
228 (_EmacsFixedPrivate): Remove minwidth/height.
229 Add struct frame *f.
230 (emacs_fixed_init): Initialize priv->f.
231 (get_parent_class, emacs_fixed_set_min_size): Remove.
232 (emacs_fixed_new): Set priv->f to argument.
233 (emacs_fixed_get_preferred_width)
234 (emacs_fixed_get_preferred_height): Use min_width/height from
235 frames size_hint to set minimum and natural (Bug#8919).
236 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
237 and use min_width/height from frames size_hint to set
238 min_width/height (Bug#8919).
239
240 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
241 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size. Fix
242 indentation.
243
cf99dcf8
EZ
2442011-06-26 Eli Zaretskii <eliz@gnu.org>
245
246 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
247 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
248 called at ZV.
249
029529ac
CY
2502011-06-26 Chong Yidong <cyd@stupidchicken.com>
251
252 * process.c (wait_reading_process_output): Bypass select if
253 waiting for a cell while ignoring keyboard input, and input is
254 pending. Suggested by Jan Djärv (Bug#8869).
255
7a7ef429
PE
2562011-06-25 Paul Eggert <eggert@cs.ucla.edu>
257
258 Use gnulib's dup2 module instead of rolling our own.
259 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
260
11fdef7d 2612011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
262
263 * dispnew.c (scrolling_window): Before scrolling, turn off a
264 mouse-highlight in the window being scrolled.
265
cd3520a4
JB
2662011-06-24 Juanma Barranquero <lekktu@gmail.com>
267
268 Move DEFSYM to lisp.h and use everywhere.
269
270 * character.h (DEFSYM): Move declaration...
271 * lisp.h (DEFSYM): ...here.
272
273 * gnutls.c:
274 * minibuf.c:
275 * w32menu.c:
276 * w32proc.c:
277 * w32select.c: Don't include character.h.
278
279 * alloc.c (syms_of_alloc):
280 * buffer.c (syms_of_buffer):
281 * bytecode.c (syms_of_bytecode):
282 * callint.c (syms_of_callint):
283 * casefiddle.c (syms_of_casefiddle):
284 * casetab.c (init_casetab_once):
285 * category.c (init_category_once, syms_of_category):
286 * ccl.c (syms_of_ccl):
287 * cmds.c (syms_of_cmds):
288 * composite.c (syms_of_composite):
289 * dbusbind.c (syms_of_dbusbind):
290 * dired.c (syms_of_dired):
291 * dispnew.c (syms_of_display):
292 * doc.c (syms_of_doc):
293 * editfns.c (syms_of_editfns):
294 * emacs.c (syms_of_emacs):
295 * eval.c (syms_of_eval):
296 * fileio.c (syms_of_fileio):
297 * fns.c (syms_of_fns):
298 * frame.c (syms_of_frame):
299 * fringe.c (syms_of_fringe):
300 * insdel.c (syms_of_insdel):
301 * keymap.c (syms_of_keymap):
302 * lread.c (init_obarray, syms_of_lread):
303 * macros.c (syms_of_macros):
304 * msdos.c (syms_of_msdos):
305 * print.c (syms_of_print):
306 * process.c (syms_of_process):
307 * search.c (syms_of_search):
308 * sound.c (syms_of_sound):
309 * syntax.c (init_syntax_once, syms_of_syntax):
310 * terminal.c (syms_of_terminal):
311 * textprop.c (syms_of_textprop):
312 * undo.c (syms_of_undo):
313 * w32.c (globals_of_w32):
314 * window.c (syms_of_window):
315 * xdisp.c (syms_of_xdisp):
316 * xfaces.c (syms_of_xfaces):
317 * xfns.c (syms_of_xfns):
318 * xmenu.c (syms_of_xmenu):
319 * xsettings.c (syms_of_xsettings):
320 * xterm.c (syms_of_xterm): Use DEFSYM.
321
4228cf16
TZ
3222011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
323
cd3520a4 324 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 325
7fcccf1e
PE
3262011-06-23 Paul Eggert <eggert@cs.ucla.edu>
327
7efb4e0e
PE
328 Integer and buffer overflow fixes (Bug#8873).
329
ff5844ad
PE
330 * print.c (printchar, strout): Check for string overflow.
331 (PRINTPREPARE, printchar, strout):
332 Don't set size unless allocation succeeds.
333
90532f02
PE
334 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
335 for sizes. Check for string overflow more accurately.
336 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
337
6d84508d
PE
338 * macros.c: Integer and buffer overflow fixes.
339 * keyboard.h (struct keyboard.kbd_macro_bufsize):
340 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
341 Use ptrdiff_t, not int, for sizes.
342 Don't increment bufsize until after realloc succeeds.
343 Check for size-calculation overflow.
344 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
345
437b2cb4
PE
346 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
347
8b9ac8b4
PE
348 * lread.c: Integer overflow fixes.
349 (read_integer): Radix is now EMACS_INT, not int,
350 to improve quality of diagnostics for out-of-range radices.
351 Calculate buffer size correctly for out-of-range radices.
352 (read1): Check for integer overflow in radices, and in
353 read-circle numbers.
82cb60d3
PE
354 (read_escape): Avoid int overflow.
355 (Fload, openp, read_buffer_size, read1)
356 (substitute_object_recurse, read_vector, read_list, map_obarray):
357 Use ptrdiff_t, not int, for sizes.
358 (read1): Use EMACS_INT, not int, for sizes.
20270765 359 Check for size overflow.
8b9ac8b4 360
7fcccf1e
PE
361 * image.c (cache_image): Check for size arithmetic overflow.
362
bfbbd7e7
PE
363 * lread.c: Integer overflow issues.
364 (saved_doc_string_size, saved_doc_string_length)
365 (prev_saved_doc_string_size, prev_saved_doc_string_length):
366 Now ptrdiff_t, not int.
367 (read1): Don't assume doc string length fits in int. Check for
368 out-of-range doc string lengths.
369 (read_list): Don't assume file position fits in int.
39019e54 370 (read_escape): Check for hex character overflow.
bfbbd7e7 371
4e323265
LL
3722011-06-22 Leo Liu <sdl.web@gmail.com>
373
374 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
375 Move to minibuffer.el.
376
85fece3e
PE
3772011-06-22 Paul Eggert <eggert@cs.ucla.edu>
378
20b84ce9 379 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
380 The following patches are for when GLYPH_DEBUG && !XASSERT.
381 * dispextern.h (trace_redisplay_p, dump_glyph_string):
382 * dispnew.c (flush_stdout):
383 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
384 Mark as externally visible.
385 * dispnew.c (check_window_matrix_pointers): Now static.
386 * dispnew.c (window_to_frame_vpos):
387 * xfns.c (unwind_create_frame):
388 * xterm.c (x_check_font): Remove unused local.
389 * scroll.c (CHECK_BOUNDS):
390 * xfaces.c (cache_fache): Rename local to avoid shadowing.
391 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
392 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
393 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
394 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
395 Now static.
396 (debug_method_add): Use va_list and vsprintf rather than relying
397 on undefined behavior with wrong number of arguments.
398 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
399 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
400 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
401 since we're not interested in debugging glyphs with old libraries.
402 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
403 GCC 4.6.0's static checking.
404
0766b489
PE
4052011-06-22 Paul Eggert <eggert@cs.ucla.edu>
406
31fd4b32
PE
407 Integer overflow and signedness fixes (Bug#8873).
408 A few related buffer overrun fixes, too.
409
b79e8648
PE
410 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
411
0766b489
PE
412 * dispextern.h (struct face.stipple):
413 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
414 (x_bitmap_mask, x_allocate_bitmap_record)
415 (x_create_bitmap_from_data, x_create_bitmap_from_file)
416 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
417 (x_create_bitmap_from_xpm_data):
418 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
419 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
420 (.bitmaps_last):
421 * xfaces.c (load_pixmap):
422 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
423 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
424 (.bitmaps_last, struct x_output.icon_bitmap):
425 Use ptrdiff_t, not int, for bitmap indexes.
426 (x_allocate_bitmap_record): Check for size overflow.
427 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
428
b081724f
PE
429 Use ptrdiff_t, not int, for overlay counts.
430 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
431 * editfns.c (overlays_around, get_pos_property):
432 * textprop.c (get_char_property_and_overlay):
433 * xdisp.c (next_overlay_change, note_mouse_highlight):
434 * xfaces.c (face_at_buffer_position):
21514da7
PE
435 * buffer.c (OVERLAY_COUNT_MAX): New macro.
436 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
437 (Fnext_overlay_change, Fprevious_overlay_change)
438 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 439 Use ptrdiff_t, not int, for sizes.
21514da7 440 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 441
3de73e5e
PE
442 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
443
2606c57b
PE
444 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
445 (x_session_initialize): Do not assume string length fits in int.
446
aaafe47a
PE
447 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
448 This is unlikely, but can occur if DPI is outlandish.
449
2674ddc8 450 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
451 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
452
28154962
PE
453 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
454 * xrdb.c (magic_file_p, search_magic_path):
455 Omit last arg SUFFIX; it was always 0. All callers changed.
456 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
457
7de51af5
PE
458 * xfont.c (xfont_match): Avoid need for strlen.
459
25ed6cc3
PE
460 * xfns.c: Don't assume strlen fits in int.
461 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
462
4eab31dd
PE
463 * xdisp.c (message_log_check_duplicate): Return intmax_t,
464 not unsigned long, as we prefer signed integers. All callers changed.
465 Detect integer overflow in repeat count.
466 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 467 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 468
171e2a58
PE
469 * termcap.c: Don't assume sizes fit in int and never overflow.
470 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
471 (gobble_line): Check for size-calculation overflow.
472
ad39faca 473 * minibuf.c (Fread_buffer):
6e5bb2dc 474 * lread.c (intern, intern_c_string):
74ca2eb3
PE
475 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
476 Don't assume string length fits in int.
477
52c61c22 478 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
479 * gtkutil.c (style_changed_cb): Avoid need for strlen.
480
b5b8c9e5
PE
481 * font.c: Don't assume string length fits in int.
482 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
483 Use ptrdiff_t, not int.
ccd6111c
PE
484 (font_intern_prop): Don't assume string length fits in int.
485 Don't assume integer property fits in fixnum.
486 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 487
882f0d81 488 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 489 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
490 Reformulate so as not to need the command string.
491 Invoke gzip -cd rather than gunzip, as it's more portable.
492 (lock_info_type, lock_file_1, lock_file):
493 Don't assume pid_t and time_t fit in unsigned long.
494 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
495 (current_lock_owner): Prefer signed type for sizes.
496 Use memcpy, not strncpy, where memcpy is what is really wanted.
497 Don't assume (via atoi) that time_t and pid_t fit in int.
498 Check for time_t and/or pid_t out of range, e.g., via a network share.
499 Don't alloca where an auto var works fine.
500
93f4cf88
PE
501 * fileio.c: Fix some integer overflow issues.
502 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
503 Don't assume string length fits in int.
504 (directory_file_name): Don't assume string length fits in long.
505 (make_temp_name): Don't assume pid fits in int, or that its print
506 length is less than 20.
507
f3e92b69
PE
508 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
509
1bfdaf10
PE
510 * coding.c (make_subsidiaries): Don't assume string length fits in int.
511
35016e9a
PE
512 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
513
3d1e65a1
PE
514 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
515 We prefer signed integers, even for size calculations.
516
0b963a93
PE
517 * emacs.c: Don't assume string length fits in 'int'.
518 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
519 (main): Don't invoke strlen when not needed.
520
573f4b54
PE
521 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
522 (XD_DEBUG_MESSAGE): Don't waste a byte.
523
989f33ba
PE
524 * callproc.c (getenv_internal_1, getenv_internal)
525 (Fgetenv_internal):
965d34eb
PE
526 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
527
e4d29b33
PE
528 * lread.c (invalid_syntax): Omit length argument.
529 All uses changed. This doesn't fix a bug, but it simplifies the
530 code away from its former Hollerith-constant appearance, and it's
531 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 532 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 533
eb49b136
PE
534 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
535 This didn't break anything, but it didn't help either.
536 It's confusing to put a bogus integer in a place where the actual
537 value does not matter.
9f62aeb1 538 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 539 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 540
15375a22
PE
541 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
542 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
543 implementation.
b61cc01c
PE
544 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
545 We prefer signed types, and the value cannot exceed the EMACS_INT
546 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
547 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
548 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
549 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 550
53b2623d
PE
551 * indent.c (sane_tab_width): New function.
552 (current_column, scan_for_column, Findent_to, position_indentation)
553 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 554 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 555
51cab52b 556 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 557
f2ed8a70
PE
558 * lisp.h (lint_assume): New macro.
559 * composite.c (composition_gstring_put_cache):
560 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
561
abe80cc6
PE
562 * editfns.c, insdel.c:
563 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 564
b02c740e
PE
565 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
566
ebc96716
PE
567 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
568
b4e50fa0 569 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 570 Use much-faster test for byte-length change.
311d5d7c 571 Don't assume string byte-length fits in 'int'.
a4cf38e4 572 Check that character arg fits in 'int'.
85461888 573 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 574
c0c1ee9f
PE
575 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
576
a498d7f4
PE
577 * fns.c (concat): Catch string overflow earlier.
578 Do not rely on integer wraparound.
579
51cab52b
PE
580 * dispextern.h (struct it.overlay_strings_charpos)
581 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
582 * xdisp.c (forward_to_next_line_start)
583 (back_to_previous_visible_line_start)
584 (reseat_at_next_visible_line_start, next_element_from_buffer):
585 Don't arbitrarily truncate the value of 'selective' to int.
586
76031fad
PE
587 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
588
5eb55db9
PE
589 * composite.c: Don't truncate sizes to 'int'.
590 (composition_gstring_p, composition_reseat_it)
591 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
592 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
593 not EMACS_UINT, for indexes.
5eb55db9 594
0703a717
PE
595 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
596
d6202519
PE
597 * buffer.c: Include <verify.h>.
598 (struct sortvec.priority, struct sortstr.priority):
8961a454 599 Now EMACS_INT, not int.
c20998a7 600 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
601 (struct sortstr.size, record_overlay_string)
602 (struct sortstrlist.size, struct sortlist.used):
603 Don't truncate size to int.
604 (record_overlay_string): Check for size-calculation overflow.
d6202519 605 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 606
d5a19415
JM
6072011-06-22 Jim Meyering <meyering@redhat.com>
608
029529ac 609 Don't leak an XBM-image-sized buffer
d5a19415
JM
610 * image.c (xbm_load): Free the image buffer after using it.
611
a9041e6c
PE
6122011-06-21 Paul Eggert <eggert@cs.ucla.edu>
613
614 Port to Sun C.
615 * composite.c (find_automatic_composition): Omit needless 'return 0;'
616 that Sun C diagnosed.
617 * fns.c (secure_hash): Fix pointer signedness issue.
618 * intervals.c (static_offset_intervals): New function.
619 (offset_intervals): Use it.
620
7f3f739f
LL
6212011-06-21 Leo Liu <sdl.web@gmail.com>
622
623 * deps.mk (fns.o):
624 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
625 sha512.h.
626
627 * fns.c (secure_hash): Rename from crypto_hash_function and change
628 the first arg to accept symbols.
5b66d427 629 (Fsecure_hash): New primitive.
7f3f739f
LL
630 (syms_of_fns): New symbols.
631
76147d94
DD
6322011-06-20 Deniz Dogan <deniz@dogan.se>
633
634 * process.c (Fset_process_buffer): Clarify return value in
635 docstring.
636
7d7d0045
CY
6372011-06-18 Chong Yidong <cyd@stupidchicken.com>
638
639 * dispnew.c (add_window_display_history): Use BVAR.
640
641 * xdisp.c (debug_method_add): Use BVAR.
642 (check_window_end, dump_glyph_matrix, dump_glyph)
643 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
644
645 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
646 Likewise.
647
648 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
649 check till after the cache is created in init_frame_faces.
650
ff2bc410
SM
6512011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
652
653 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
654
28177add
PE
6552011-06-16 Paul Eggert <eggert@cs.ucla.edu>
656
dd3482fe
PE
657 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
658 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
659 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
660
393d71f3 661 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
662 * fileio.c (Finsert_file_contents):
663 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
664 Remove the old (too-loose) buffer overflow checks.
665 They weren't needed, since make_gap checks for buffer overflow.
666 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
667 The old code merely checked for Emacs fixnum overflow, and relied
668 on undefined (wraparound) behavior. The new code avoids undefined
669 behavior, and also checks for ptrdiff_t and/or size_t overflow.
670
2e6813b0 671 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
672 Tune. Don't use wider integers than needed. Don't use alloca.
673 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 674
599a9e4f
PE
675 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
676
99561444
PE
677 * insdel.c, lisp.h (buffer_overflow): New function.
678 (insert_from_buffer_1, replace_range, replace_range_2):
679 * insdel.c (make_gap_larger):
680 * editfns.c (Finsert_char):
681 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
682
28177add
PE
683 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
684
e69dafad
PE
6852011-06-15 Paul Eggert <eggert@cs.ucla.edu>
686
a7af7fde 687 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 688
b1c46f02
PE
689 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
690 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
691
e69dafad
PE
692 * fileio.c: Don't assume EMACS_INT fits in off_t.
693 (emacs_lseek): New static function.
694 (Finsert_file_contents, Fwrite_region): Use it.
695 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
696
566684ea
PE
697 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
698
e6966cd6
PE
699 * fns.c: Don't overflow int when computing a list length.
700 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
701 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
702 truncation on 64-bit hosts. Check for QUIT every
703 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
704 faster and is responsive enough.
705 (Flength): Report an error instead of overflowing an integer.
706 (Fsafe_length): Return a float if the value is not representable
707 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 708 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 709 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 710
dd0b0efb
PE
711 * alloc.c: Check that resized vectors' lengths fit in fixnums.
712 (header_size, word_size): New constants.
713 (allocate_vectorlike): Don't check size overflow here.
714 (allocate_vector): Check it here instead, since this is the only
715 caller of allocate_vectorlike that could cause overflow.
716 Check that the new vector's length is representable as a fixnum.
717
86fe5cfe
PE
718 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
719 The previous code was bogus. For example, next_almost_prime (32)
720 returned 39, which is undesirable as it is a multiple of 3; and
721 next_almost_prime (24) returned 25, which is a multiple of 5 so
722 why was the code bothering to check for multiples of 7?
723
80e88859
PE
724 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
725
4a2f0ad6
PE
726 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
727
f66c7cf8
PE
728 Variadic C functions now count arguments with ptrdiff_t.
729 This partly undoes my 2011-03-30 change, which replaced int with size_t.
730 Back then I didn't know that the Emacs coding style prefers signed int.
731 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
732 were being counted with int, which may truncate counts on 64-bit
733 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
734 * lisp.h (struct Lisp_Subr.function.aMANY)
735 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
736 Arg counts are now ptrdiff_t, not size_t.
737 All variadic functions and their callers changed accordingly.
738 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
739 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
740 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
741 * callint.c (Fcall_interactively): Check arg count for overflow,
742 to avoid potential buffer overrun. Use signed char, not 'int',
743 for 'varies' array, so that we needn't bother to check its size
744 calculation for overflow.
745 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
746 * eval.c (apply_lambda):
747 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
748 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
749 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
750
a1759b76
PE
751 * callint.c (Fcall_interactively): Don't use index var as event count.
752
d96be9fc
PE
753 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
754 * mem-limits.h (SIZE): Remove; no longer used.
755
a690a978 756 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 757
578c21e6
PE
758 Remove unnecessary casts.
759 * xterm.c (x_term_init):
760 * xfns.c (x_set_border_pixel):
761 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
762 These aren't needed now that we assume ANSI C.
763
96f53c6c
PE
764 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
765 It's more likely to cause problems (due to unsigned overflow)
766 than to cure them.
767
83c77d31
PE
768 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
769
ee2079f1
PE
770 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
771
6da65536
PE
772 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
773
7147c4a4
PE
774 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
775
193e32d9
PE
776 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
777
e5533da6
PE
778 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
779
9910e595
PE
780 GLYPH_CODE_FACE returns EMACS_INT, not int.
781 * dispextern.h (merge_faces):
782 * xfaces.c (merge_faces):
01103c44
PE
783 * xdisp.c (get_next_display_element, next_element_from_display_vector):
784 Don't assume EMACS_INT fits in int.
9910e595 785
2638320e
PE
786 * character.h (CHAR_VALID_P): Remove unused parameter.
787 * fontset.c, lisp.h, xdisp.c: All uses changed.
788
045eb8d9
PE
789 * editfns.c (Ftranslate_region_internal): Omit redundant test.
790
c1f134b5
PE
791 * fns.c (concat): Minor tuning based on overflow analysis.
792 This doesn't fix any bugs. Use int to hold character, instead
793 of constantly refetching from Emacs object. Use XFASTINT, not
794 XINT, for value known to be a character. Don't bother comparing
795 a single byte to 0400, as it's always less.
796
395fcb93 797 * floatfns.c (Fexpt):
327eeec8
PE
798 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
799
abbd3d23
PE
800 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
801 for characters.
802
684a03ef
PE
803 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
804
0fed43f3
PE
805 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
806 Without this fix, on a 64-bit host (aset S 0 4294967386) would
807 incorrectly succeed when S was a string, because 4294967386 was
808 truncated before it was used.
809
8fd02eb7
PE
810 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
811 Otherwise, an out-of-range integer could cause undefined behavior
812 on a 64-bit host.
813
f8c86b69
PE
814 * composite.c: Use int, not EMACS_INT, for characters.
815 (fill_gstring_body, composition_compute_stop_pos): Use int, not
816 EMACS_INT, for values that are known to be in character range.
817 This doesn't fix any bugs but is the usual style inside Emacs and
818 may generate better code on 32-bit machines.
819
34206dd2
PE
820 Make sure a 64-bit char is never passed to ENCODE_CHAR.
821 This is for reasons similar to the recent CHAR_STRING fix.
822 * charset.c (Fencode_char): Check that character arg is actually
823 a character. Pass an int to ENCODE_CHAR.
824 * charset.h (ENCODE_CHAR): Verify that the character argument is no
825 wider than 'int', as a compile-time check to prevent future regressions
826 in this area.
827
c5958d4c 828 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
829
830 Make sure a 64-bit char is never passed to CHAR_STRING.
831 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
832 by silently ignoring the top 32 bits, allowing some values
833 that were far too large to be valid characters.
834 * character.h: Include <verify.h>.
835 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
836 arguments are no wider than unsigned, as a compile-time check
837 to prevent future regressions in this area.
838 * data.c (Faset):
01103c44 839 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
840 (Fsubst_char_in_region):
841 * fns.c (concat):
842 * xdisp.c (decode_mode_spec_coding):
843 Adjust to CHAR_STRING's new requirement.
844 * editfns.c (Finsert_char, Fsubst_char_in_region):
845 * fns.c (concat): Check that character args are actually
846 characters. Without this test, these functions did the wrong
847 thing with wildly out-of-range values on 64-bit hosts.
848
d37ca623
PE
849 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
850 These casts should not be needed on 32-bit hosts, either.
851 * keyboard.c (read_char):
852 * lread.c (Fload): Remove casts to unsigned.
853
ea204efb
PE
854 * lisp.h (UNSIGNED_CMP): New macro.
855 This fixes comparison bugs on 64-bit hosts.
856 (ASCII_CHAR_P): Use it.
857 * casefiddle.c (casify_object):
01103c44 858 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
859 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
860 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
861 * dispextern.h (FACE_FROM_ID):
862 * keyboard.c (read_char): Use UNSIGNED_CMP.
863
41cb286c
PE
864 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
865 not to EMACS_INT, to avoid GCC warning.
866
4a1b9832
PE
867 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
868
55daad71
PE
869 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
870 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
871 isn't needed on 32-bit machines.
8f95c75c 872
01103c44
PE
873 * buffer.c (Fgenerate_new_buffer_name):
874 Use EMACS_INT for count, not int.
0ceccced 875 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
876
877 * data.c (Qcompiled_function): Now static.
878
c6f072e7
PE
879 * window.c (window_body_lines): Now static.
880
20ce5912
PE
881 * image.c (gif_load): Rename local to avoid shadowing.
882
9c4c5f81
PE
883 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
884 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
885 * alloc.c (make_save_value): Integer argument is now of type
886 ptrdiff_t, not int.
887 (mark_object): Use ptrdiff_t, not int.
888 * lisp.h (pD): New macro.
889 * print.c (print_object): Use it.
890
c0c5c8ae
PE
891 * alloc.c: Use EMACS_INT, not int, to count objects.
892 (total_conses, total_markers, total_symbols, total_vector_size)
893 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
894 (total_free_floats, total_floats, total_free_intervals)
895 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
896 Now EMACS_INT, not int. All uses changed.
897 (Fgarbage_collect): Compute overall total using a double, so that
898 integer overflow is less likely to be a problem. Check for overflow
899 when converting back to an integer.
5a25e253
PE
900 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
901 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
902 These were 'int' variables that could overflow on 64-bit hosts;
903 they were never used, so remove them instead of repairing them.
211a0b2a 904 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
905 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
906 Previously, this ceilinged at INT_MAX, but that doesn't work on
907 64-bit machines.
e46bb31a 908 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 909
c78baabf 910 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 911 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
912 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
913 when a (possibly-narrower) signed value would do just as well.
914 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 915
c9d624c6
PE
916 * alloc.c: Catch some string size overflows that we were missing.
917 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
918 for convenience in STRING_BYTES_MAX.
919 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
920 The definition here is exact; the one in lisp.h was approximate.
921 (allocate_string_data): Check for string overflow. This catches
922 some instances we weren't catching before. Also, it catches
923 size_t overflow on (unusual) hosts where SIZE_MAX <= min
924 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
925 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 926
c9d624c6
PE
927 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
928 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
929 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
930
353032ce
PE
931 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
932
2bccce07
PE
933 * alloc.c (Fmake_string): Check for out-of-range init.
934
0ac30604
SM
9352011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
936
937 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
938
c195f2de
JD
9392011-06-14 Jan Djärv <jan.h.d@swipnet.se>
940
941 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
942 xg_get_default_scrollbar_width.
943
944 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
945 (int_gtk_range_get_value): Move to the scroll bar part of the file.
946 (style_changed_cb): Call update_theme_scrollbar_width and call
947 x_set_scroll_bar_default_width and xg_frame_set_char_size for
948 all frames (Bug#8505).
949 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
950 Call gtk_window_set_resizable if HAVE_GTK3.
951 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
952 and height if HAVE_GTK3 (Bug#8505).
953 (scroll_bar_width_for_theme): New variable.
954 (update_theme_scrollbar_width): New function.
955 (xg_get_default_scrollbar_width): Move code to
956 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
957 (xg_initialize): Call update_theme_scrollbar_width.
958
959 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
960
961 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
962
e10ac9f1
MR
9632011-06-12 Martin Rudalics <rudalics@gmx.at>
964
965 * frame.c (make_frame): Call other_buffer_safely instead of
966 other_buffer.
967
968 * window.c (temp_output_buffer_show): Call display_buffer with
969 second argument Vtemp_buffer_show_specifiers and reset latter
970 immediately after the call.
971 (Vtemp_buffer_show_specifiers): New variable.
972 (auto_window_vscroll_p, next_screen_context_lines)
973 (Vscroll_preserve_screen_position): Remove leading asterisks from
974 doc-strings.
975
2d3c217e 9762011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 977
7b7f97e8 978 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
979 * buffer.c (Qclone_number): Remove for now, as it's unused.
980 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
981 (record_buffer): Remove unused local.
982 * frame.c (other_visible_frames, frame_buffer_list): Now static.
983 (set_frame_buffer_list): Remove; unused.
984 * frame.h (other_visible_frames): Remove decl.
985 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
986 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
987 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
988 if HAVE_GPM.
989 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
990 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
991 Define only if HAVE_GPM.
992 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
993 (update_hints_inhibit): Remove; never set. All uses removed.
994 * widgetprv.h (emacsFrameClassRec): Remove decl.
995 * window.c (delete_deletable_window): Now returns void, since it
996 wasn't returning anything.
997 (compare_window_configurations): Remove unused locals.
998 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
999 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
1000 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
1001 the same widths as pointers. This follows up on the 2011-05-06 patch.
1002 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
1003 * xterm.h: Likewise.
1004 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
1005
1384b89e
JB
10062011-06-12 Juanma Barranquero <lekktu@gmail.com>
1007
1008 * makefile.w32-in: Update dependencies.
1009 (LISP_H): Add lib/intprops.h.
1010
1100a63c
CY
10112011-06-11 Chong Yidong <cyd@stupidchicken.com>
1012
1013 * image.c (gif_load): Add animation frame delay to the metadata.
1014 (syms_of_image): Use DEFSYM. New symbol `delay'.
1015
6198ccd0
MR
10162011-06-11 Martin Rudalics <rudalics@gmx.at>
1017
1018 * window.c (delete_deletable_window): Re-add.
1019 (Fset_window_configuration): Rewrite to handle dead buffers and
1020 consequently deletable windows.
1021 (window_tree, Fwindow_tree): Remove. Supply functionality in
1022 window.el.
1023 (compare_window_configurations): Simplify code.
1024
b6e3633c
AS
10252011-06-11 Andreas Schwab <schwab@linux-m68k.org>
1026
1ab0dee5
AS
1027 * image.c (imagemagick_load_image): Fix type mismatch.
1028 (Fimagemagick_types): Likewise.
1029
b6e3633c
AS
1030 * window.h (replace_buffer_in_windows): Declare.
1031
9397e56f
MR
10322011-06-11 Martin Rudalics <rudalics@gmx.at>
1033
1034 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
1035 Qclone_number. Remove external declaration of Qdelete_window.
1036 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
1037 code.
1038 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
1039 Qbuffer_list_update_hook if allowed.
1040 (Fother_buffer): Rewrite doc-string. Major rewrite for new
1041 buffer list implementation.
1042 (other_buffer_safely): New function.
1043 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
1044 calls to replace_buffer_in_windows and
1045 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
1046 if allowed.
1047 (record_buffer): Inhibit quitting and rewrite using quittable
1048 functions. Run Qbuffer_list_update_hook if allowed.
1049 (Frecord_buffer, Funrecord_buffer): New functions.
1050 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
1051 switch-to-buffer to window.el.
1052 (bury-buffer): Move to window.el.
1053 (Vbuffer_list_update_hook): New variable.
1054
1055 * lisp.h (other_buffer_safely): Add prototype in buffer.c
1056 section.
1057
1058 * window.h (resize_frame_windows): Move up in code.
1059 (Fwindow_frame): Remove EXFUN.
1060 (replace_buffer_in_all_windows): Remove prototype.
1061 (replace_buffer_in_windows_safely): Add prototype.
1062
1063 * window.c: Declare Qdelete_window static again. Move down
1064 declaration of select_count.
1065 (Fnext_window, Fprevious_window): Rewrite doc-strings.
1066 (Fother_window): Move to window.el.
1067 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
1068 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
1069 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
1070 window.el.
1071 (replace_buffer_in_windows): Implement by calling
1072 Qreplace_buffer_in_windows.
1073 (replace_buffer_in_all_windows): Remove with some functionality
1074 moved into replace_buffer_in_windows_safely.
1075 (replace_buffer_in_windows_safely): New function.
1076 (select_window_norecord, select_frame_norecord): Move in front
1077 of run_window_configuration_change_hook. Remove now obsolete
1078 declarations.
1079 (Fset_window_buffer): Rewrite doc-string. Call
1080 Qrecord_window_buffer.
1081 (keys_of_window): Move binding for other-window to window.el.
1082
b50691aa
CY
10832011-06-11 Chong Yidong <cyd@stupidchicken.com>
1084
1085 * dispextern.h (struct image): Replace data member, whose int_val
1086 and ptr_val fields were not used by anything, with a single
1087 lisp_val object.
1088
1089 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
1090 (gif_clear_image, gif_load, imagemagick_load_image)
1091 (gs_clear_image, gs_load): Callers changed.
1092
3f754b86
PE
10932011-06-10 Paul Eggert <eggert@cs.ucla.edu>
1094
cca69397
PE
1095 * buffer.h: Include <time.h>, for time_t.
1096 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
1097
109e28d0
PE
1098 Fix minor problems found by static checking.
1099
60737f02
PE
1100 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
1101
4b66faf3
PE
1102 Make identifiers static if they are not used in other modules.
1103 * data.c (Qcompiled_function, Qframe, Qvector):
1104 * image.c (QimageMagick, Qsvg):
1105 * minibuf.c (Qmetadata):
1106 * window.c (resize_window_check, resize_root_window): Now static.
1107 * window.h (resize_window_check, resize_root_window): Remove decls.
1108
109e28d0
PE
1109 * window.c (window_deletion_count, delete_deletable_window):
1110 Remove; unused.
46a4ce9e
PE
1111 (window_body_lines): Now static.
1112 (Fdelete_other_windows_internal): Mark vars as initialized.
1113 Make sure 'resize_failed' is initialized.
1114 (run_window_configuration_change_hook): Rename local to avoid shadowing.
1115 (resize_window_apply): Remove unused local.
1116 * window.h (delete_deletable_window): Remove decl.
1117
109e28d0 1118 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
1119 (imagemagick_load_image): Fix pointer signedness problem by changing
1120 last arg from unsigned char * to char *. All uses changed.
1121 Also, fix a local for similar reasons.
1122 Remove unused locals. Remove locals to avoid shadowing.
1123 (fn_rsvg_handle_free): Remove; unused.
1124 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 1125 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 1126
3f754b86
PE
1127 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
1128
2547adb1
CY
11292011-06-10 Chong Yidong <cyd@stupidchicken.com>
1130
1131 * image.c (gif_load): Fix omitted cast error introduced by
1132 2011-06-06 change.
1133
2c8e37d4
MR
11342011-06-10 Martin Rudalics <rudalics@gmx.at>
1135
1136 * window.h (resize_proportionally, orig_total_lines)
1137 (orig_top_line): Remove from window structure.
1138 (set_window_height, set_window_width, change_window_heights)
1139 (Fdelete_window): Remove prototypes.
1140 (resize_frame_windows): Remove duplicate declaration.
1141
440a42e3
EZ
11422011-06-10 Eli Zaretskii <eliz@gnu.org>
1143
1144 * window.h (resize_frame_windows, resize_window_check)
1145 (delete_deletable_window, resize_root_window)
1146 (resize_frame_windows): Declare prototypes.
1147
1148 * window.c (resize_window_apply): Make definition be "static" to
1149 match the prototype.
1150
562dd5e9
MR
11512011-06-10 Martin Rudalics <rudalics@gmx.at>
1152
1153 * window.c: Remove declarations of Qwindow_size_fixed,
1154 window_min_size_1, window_min_size_2, window_min_size,
1155 size_window, window_fixed_size_p, enlarge_window, delete_window.
1156 Remove static from declaration of Qdelete_window, it's
1157 temporarily needed by Fbury_buffer.
1158 (replace_window): Don't assign orig_top_line and
1159 orig_total_lines.
1160 (Fdelete_window, delete_window): Remove. Window deletion is
1161 handled by window.el.
1162 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
1163 Fdelete_window calls with calls to Qdelete_window.
1164 (Fdelete_other_windows): Remove. Deleting other windows is
1165 handled by window.el.
1166 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
1167 handled in window.el.
1168 (window_min_size_2, window_min_size_1, window_min_size): Remove.
1169 Window minimum sizes are handled in window.el.
1170 (shrink_windows, size_window, set_window_height)
1171 (set_window_width, change_window_heights, window_height)
1172 (window_width, CURBEG, CURSIZE, enlarge_window)
1173 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
1174 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
1175 handled in window.el.
1176 (make_dummy_parent): Rename to make_parent_window and give it a
1177 second argument horflag.
1178 (make_window): Don't set resize_proportionally any more.
1179 (Fsplit_window): Remove. Windows are split in window.el.
1180 (save_restore_action, save_restore_orig_size)
1181 (shrink_window_lowest_first, save_restore_orig_size): Remove.
1182 Resize mini windows in window.el.
1183 (grow_mini_window, shrink_mini_window): Implement by calling
1184 Qresize_root_window_vertically, resize_window_check and
1185 resize_window_apply.
1186 (saved_window, Fset_window_configuration, save_window_save): Do
1187 not handle orig_top_line, orig_total_lines, and
1188 resize_proportionally.
1189 (window_min_height, window_min_width): Move to window.el.
1190 (keys_of_window): Move bindings for delete-other-windows,
1191 split-window, delete-window and enlarge-window to window.el.
1192
1193 * buffer.c: Temporarily extern Qdelete_window.
1194 (Fbury_buffer): Temporarily call Qdelete_window instead of
1195 Fdelete_window (Fbury_buffer will move to window.el soon).
1196
1197 * frame.c (set_menu_bar_lines_1): Remove code handling
1198 orig_top_line and orig_total_lines.
1199
1200 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1201 set_window_height but set heights directly.
1202 (change_frame_size_1): Use resize_frame_windows.
1203
1204 * xdisp.c (init_xdisp): Don't use set_window_height but set
1205 heights directly.
1206
1207 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1208 resize_frame_windows instead of change_window_heights and run
1209 run_window_configuration_change_hook.
1210
1211 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1212 instead of change_window_heights and run
1213 run_window_configuration_change_hook.
1214
1a13852e
MR
12152011-06-09 Martin Rudalics <rudalics@gmx.at>
1216
1217 * window.c (replace_window): Rename second argument REPLACEMENT to
1218 NEW. New third argument SETFLAG. Rewrite.
1219 (delete_window, make_dummy_parent): Call replace_window with
1220 third argument 1.
1221 (window_list_1): Move down in code.
1222 (run_window_configuration_change_hook): Move set_buffer part
1223 before select_frame_norecord part in order to unwind correctly.
1224 Rename count1 to count.
1225 (recombine_windows, delete_deletable_window, resize_root_window)
1226 (Fdelete_other_windows_internal)
1227 (Frun_window_configuration_change_hook, make_parent_window)
1228 (resize_window_check, resize_window_apply, Fresize_window_apply)
1229 (resize_frame_windows, Fsplit_window_internal)
1230 (Fdelete_window_internal, Fresize_mini_window_internal): New
1231 functions.
1232 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1233
f3d1777e
MR
12342011-06-08 Martin Rudalics <rudalics@gmx.at>
1235
496e208e
MR
1236 * window.h (window): Add some new members to window structure -
1237 normal_lines, normal_cols, new_total, new_normal, clone_number,
1238 splits, nest, prev_buffers, next_buffers.
1239 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 1240 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 1241
f3d1777e
MR
1242 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1243 Remove.
496e208e
MR
1244 (make_dummy_parent): Set new members of windows structure.
1245 (make_window): Move down in code. Handle new members of window
1246 structure.
1247 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
1248 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1249 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1250 (Fset_window_prev_buffers, Fwindow_next_buffers)
1251 (Fset_window_next_buffers, Fset_window_clone_number): New
1252 functions.
1253 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
1254 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
1255 Doc-string fixes.
1256 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
1257 Argument WINDOW can be now internal window too.
1258 (Fwindow_use_time): Move up in code.
1259 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
1260 Rewrite doc-string.
1261 (Fset_window_configuration, saved_window)
1262 (Fcurrent_window_configuration, save_window_save): Handle new
1263 members of window structure.
b9e809c2
MR
1264 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1265 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1266 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1267 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1268 Qget_mru_window, Qresize_root_window,
1269 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
1270 Qauto_buffer_name; staticpro them.
f3d1777e 1271
abde8f8c
MR
12722011-06-07 Martin Rudalics <rudalics@gmx.at>
1273
1274 * window.c (Fwindow_total_size, Fwindow_left_column)
1275 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
1276 (Fwindow_list_1): New functions.
1277 (window_box_text_cols): Replace with window_body_cols.
1278 (Fwindow_width, Fscroll_left, Fscroll_right): Use
1279 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
1280 (delete_window, Fset_window_configuration): Call
1281 delete_all_subwindows with window as argument.
1282 (delete_all_subwindows): Take a window as argument and not a
1283 structure. Rewrite.
190b47e6
MR
1284 (window_loop): Remove handling of GET_LRU_WINDOW and
1285 GET_LARGEST_WINDOW.
1286 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
1287
1288 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
1289 window_box_text_cols. delete_all_subwindows now takes a
1290 Lisp_Object as argument.
abde8f8c
MR
1291
1292 * indent.c (compute_motion, Fcompute_motion): Use
1293 window_body_cols instead of window_box_text_cols.
1294
fa8a67e6
MR
1295 * frame.c (delete_frame): Call delete_all_subwindows with root
1296 window as argument.
1297
a54e3482
DC
12982011-06-07 Daniel Colascione <dan.colascione@gmail.com>
1299
1300 * fns.c (Fputhash): Document return value.
1301
60002bf5
CY
13022011-06-06 Chong Yidong <cyd@stupidchicken.com>
1303
1304 * image.c (gif_load): Implement gif89a spec "no disposal" method.
1305
0c671da6 13062011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 1307
b862a52a 1308 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 1309
be44ca6c
PE
1310 Check for overflow when converting integer to cons and back.
1311 * charset.c (Fdefine_charset_internal, Fdecode_char):
1312 Use cons_to_unsigned to catch overflow.
1313 (Fencode_char): Use INTEGER_TO_CONS.
1314 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
1315 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
1316 * data.c (long_to_cons, cons_to_long): Remove.
1317 (cons_to_unsigned, cons_to_signed): New functions.
1318 These signal an error for invalid or out-of-range values.
1319 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
1320 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
1321 * font.c (Ffont_variation_glyphs):
1322 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
1323 * lisp.h: Include <intprops.h>.
1324 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
1325 (cons_to_signed, cons_to_unsigned): New decls.
1326 (long_to_cons, cons_to_long): Remove decls.
1327 * undo.c (record_first_change): Use INTEGER_TO_CONS.
1328 (Fprimitive_undo): Use CONS_TO_INTEGER.
1329 * xfns.c (Fx_window_property): Likewise.
1330 * xselect.c: Include <limits.h>.
1331 (x_own_selection, selection_data_to_lisp_data):
1332 Use INTEGER_TO_CONS.
1333 (x_handle_selection_request, x_handle_selection_clear)
1334 (x_get_foreign_selection, Fx_disown_selection_internal)
1335 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
1336 (lisp_data_to_selection_data): Use cons_to_unsigned.
1337 (x_fill_property_data): Use cons_to_signed.
1338 Report values out of range.
1339
d1f3d2af
PE
1340 Check for buffer and string overflow more precisely.
1341 * buffer.h (BUF_BYTES_MAX): New macro.
1342 * lisp.h (STRING_BYTES_MAX): New macro.
1343 * alloc.c (Fmake_string):
1344 * character.c (string_escape_byte8):
1345 * coding.c (coding_alloc_by_realloc):
1346 * doprnt.c (doprnt):
1347 * editfns.c (Fformat):
1348 * eval.c (verror):
1349 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
1350 since they may not be the same number.
1351 * editfns.c (Finsert_char):
1352 * fileio.c (Finsert_file_contents):
1353 Likewise for BUF_BYTES_MAX.
1354
dd52fcea
PE
1355 * image.c: Use ptrdiff_t, not int, for sizes.
1356 (slurp_file): Switch from int to ptrdiff_t.
1357 All uses changed.
1358 (slurp_file): Check that file size fits in both size_t (for
1359 malloc) and ptrdiff_t (for sanity and safety).
1360
7f9bbdbb
PE
1361 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
1362 if b->modtime has its maximal value.
1363
dfe18f82
PE
1364 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
1365
84acfcf0
PE
1366 Don't assume time_t can fit into int.
1367 * buffer.h (struct buffer.modtime): Now time_t, not int.
1368 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
1369 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
1370
ccd9a01a
PE
1371 Minor fixes for signed vs unsigned integers.
1372 * character.h (MAYBE_UNIFY_CHAR):
1373 * charset.c (maybe_unify_char):
1374 * keyboard.c (read_char, reorder_modifiers):
1375 XINT -> XFASTINT, since the integer must be nonnegative.
1376 * ftfont.c (ftfont_spec_pattern):
1377 * keymap.c (access_keymap, silly_event_symbol_error):
1378 XUINT -> XFASTINT, since the integer must be nonnegative.
1379 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
1380 since it makes no difference and we prefer signed.
1381 * keyboard.c (record_char): Use XUINT when all the neighbors do.
1382 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
1383 nonnegative.
1384
d6d100dd
SM
13852011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
1386
1387 * window.h (Fwindow_frame): Declare.
1388
2b6148e4
PE
13892011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1390
1391 * alloc.c: Simplify handling of large-request failures (Bug#8800).
1392 (SPARE_MEMORY): Always define.
1393 (LARGE_REQUEST): Remove.
1394 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
1395
f230ecc9
MR
13962011-06-06 Martin Rudalics <rudalics@gmx.at>
1397
727e958e
MR
1398 * lisp.h: Move EXFUNS for Fframe_root_window,
1399 Fframe_first_window and Fset_frame_selected_window to window.h.
1400
1401 * window.h: Move EXFUNS for Fframe_root_window,
1402 Fframe_first_window and Fset_frame_selected_window here from
1403 lisp.h.
1404
1405 * frame.c (Fwindow_frame, Fframe_first_window)
1406 (Fframe_root_window, Fframe_selected_window)
1407 (Fset_frame_selected_window): Move to window.c.
1408 (Factive_minibuffer_window): Move to minibuf.c.
1409 (Fother_visible_frames_p): New function.
1410
1411 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
1412
f230ecc9
MR
1413 * window.c (decode_window, decode_any_window): Move up in code.
1414 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
1415 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
1416 (Fwindow_buffer): Move up and rewrite doc-string.
1417 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
1418 (Fwindow_prev): New functions.
727e958e
MR
1419 (Fwindow_frame): Move here from frame.c. Accept any window as
1420 argument.
1421 (Fframe_root_window, Fframe_first_window)
1422 (Fframe_selected_window): Move here from frame.c. Accept frame
1423 or arbitrary window as argument. Update doc-strings.
1424 (Fminibuffer_window): Move up in code.
1425 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
1426 (Fset_frame_selected_window): Move here from frame.c.
1427 Marginal rewrite.
727e958e
MR
1428 (Fselected_window, select_window, Fselect_window): Move up in
1429 code. Minor doc-string fixes.
f230ecc9 1430
4d09bcf6
PE
14312011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1432
1433 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
1434 Do not assume that spare memory exists; that assumption is valid
1435 only if SYSTEM_MALLOC.
1436 (LARGE_REQUEST): New macro, so that the issue of large requests
1437 is separated from the issue of spare memory.
1438
810928a2
AS
14392011-06-05 Andreas Schwab <schwab@linux-m68k.org>
1440
172418ad
AS
1441 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
1442 format. (Bug#8806)
1443
43f862f7
AS
1444 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
1445
810928a2
AS
1446 * xfns.c (x_set_scroll_bar_default_width): Move declarations
1447 before statements.
1448
a059fe24
JD
14492011-06-05 Jan Djärv <jan.h.d@swipnet.se>
1450
1451 * gtkutil.c (xg_get_default_scrollbar_width): New function.
1452
1453 * gtkutil.h: Declare xg_get_default_scrollbar_width.
1454
1455 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
1456 min width by calling x_set_scroll_bar_default_width (Bug#8505).
1457
989bf368
JB
14582011-06-05 Juanma Barranquero <lekktu@gmail.com>
1459
1460 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
1461
4b80f674
CY
14622011-06-04 Chong Yidong <cyd@stupidchicken.com>
1463
1464 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
1465 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
1466 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
1467 New error handlers.
4b80f674
CY
1468 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
1469 Obey Vx_select_enable_clipboard_manager. Catch errors in
1470 x_clipboard_manager_save (Bug#8779).
1471 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 1472 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 1473
99a33b77 14742011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
1475
1476 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
1477
99a33b77 14782011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
1479
1480 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
1481 in the current matrix if keep_current_p is non-zero.
1482
8264569d
EZ
14832011-06-04 Eli Zaretskii <eliz@gnu.org>
1484
1485 * bidi.c (bidi_level_of_next_char): Fix last change.
1486
57f97249
EZ
14872011-06-03 Eli Zaretskii <eliz@gnu.org>
1488
fec2107c 1489 Support bidi reordering of text covered by display properties.
57f97249 1490
fec2107c
EZ
1491 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
1492 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
1493 (bidi_cache_search, bidi_cache_iterator_state)
1494 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
1495 (bidi_level_of_next_char, bidi_move_to_visually_next):
1496 Support character positions inside a run of characters covered by a
fec2107c
EZ
1497 display string.
1498 (bidi_paragraph_init, bidi_resolve_explicit_1)
1499 (bidi_level_of_next_char): Call bidi_fetch_char and
1500 bidi_fetch_char_advance instead of FETCH_CHAR and
1501 FETCH_CHAR_ADVANCE.
1502 (bidi_init_it): Initialize new members.
1503 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
1504 definitions.
1505 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
1506 instead of using explicit *_CHAR codes.
d6d100dd
SM
1507 (bidi_resolve_explicit, bidi_resolve_weak):
1508 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
1509 bidirectional text is supported only in multibyte buffers.
1510 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
1511 it to initialize the frame_window_p member of struct bidi_it.
1512 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
1513 (bidi_resolve_explicit, bidi_resolve_weak)
1514 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
1515 bidi_it->nchars is non-positive.
1516 (bidi_level_of_next_char): Don't try to lookup the cache for the
1517 next/previous character if nothing is cached there yet, or if we
1518 were just reseat()'ed to a new position.
c40e2fb2 1519
0e14fe90
EZ
1520 * xdisp.c (set_cursor_from_row): Set start and stop points
1521 according to the row's direction when priming the loop that looks
1522 for the glyph on which to display cursor.
1523 (single_display_spec_intangible_p): Function deleted.
1524 (display_prop_intangible_p): Reimplement to call
1525 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
1526 Accept 3 additional arguments needed by handle_display_spec.
1527 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
1528 values: lists, `(when COND...)' forms, etc.
1529 (single_display_spec_string_p): Support property values that are
1530 lists with the argument STRING its top-level element.
1531 (display_prop_string_p): Fix the condition for processing a
1532 property that is a list to be consistent with handle_display_spec.
fec2107c 1533 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
1534 last portion of handle_display_prop.
1535 (compute_display_string_pos): Accept additional argument
1536 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1537 value of a `display' property is a "replacing spec".
1538 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1539 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1540 the display property, but just return a value indicating whether
1541 the display property will replace the characters it covers.
1542 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1543 frame_window_p members of struct bidi_it.
d6d100dd
SM
1544 (compute_display_string_pos, compute_display_string_end):
1545 New functions.
fec2107c
EZ
1546 (push_it): Accept second argument POSITION, where pop_it should
1547 jump to continue iteration.
1548 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 1549
fec2107c
EZ
1550 * keyboard.c (adjust_point_for_property): Adjust the call to
1551 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
1552
1553 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
1554 (bidi_init_it): Update prototypes.
1555 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
1556 (compute_display_string_pos, compute_display_string_end):
1557 Declare prototypes.
fec2107c
EZ
1558 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1559 EMACS_INT.
fc6f18ce 1560
40087514 15612011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 1562
57f53182
PE
1563 Malloc failure behavior now depends on size of allocation.
1564 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1565 * lisp.h: Change signatures accordingly.
1566 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1567 All callers changed. (Bug#8762)
1568
1569 * gnutls.c: Use Emacs's memory allocators.
1570 Without this change, the gnutls library would invoke malloc etc.
1571 directly, which causes problems on non-SYNC_INPUT hosts, and which
1572 runs afoul of improving memory_full behavior. (Bug#8761)
1573 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1574 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1575 xfree instead of the default malloc, realloc, free.
1576 (Fgnutls_boot): No need to check for memory allocation failure,
1577 since xmalloc does that for us.
1578
ac32cd99 1579 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
1580 * category.c (hash_get_category_set):
1581 * ccl.c (ccl_driver):
1582 * charset.c (Fdefine_charset_internal):
1583 * charset.h (struct charset.hash_index):
1584 * composite.c (get_composition_id, gstring_lookup_cache)
1585 (composition_gstring_put_cache):
1586 * composite.h (struct composition.hash_index):
1587 * dispextern.h (struct image.hash):
1588 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1589 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1590 (hashfn_equal, hashfn_user_defined, make_hash_table)
1591 (maybe_resize_hash_table, hash_lookup, hash_put)
1592 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1593 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1594 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1595 * image.c (make_image, search_image_cache, lookup_image)
1596 (xpm_put_color_table_h):
1597 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 1598 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
1599 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1600 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
1601 * alloc.c (allocate_vectorlike):
1602 Check for overflow in vector size calculations.
1603 * ccl.c (ccl_driver):
1604 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
1605 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1606 need to be updated by these changes.
40087514
PE
1607 * fns.c (make_hash_table, maybe_resize_hash_table):
1608 Check for integer overflow with large hash tables.
0de4bb68
PE
1609 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1610 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1611 (SXHASH_REDUCE): New macro.
1612 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1613 Use it instead of discarding useful hash info with large hash values.
1614 (sxhash_float): New function.
1615 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1616 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
1617 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1618 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
1619 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1620 Adjust signatures to match updated version of code.
1621 (consing_since_gc): Now EMACS_INT, since a single hash table can
1622 use more than INT_MAX bytes.
1623
698d32e2
DN
16242011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1625
1626 Make it possible to build with GCC-4.6+ -O2 -flto.
1627
1628 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1629
fd6fa53f
SM
16302011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1631
1632 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1633 Call minibuffer-inactive-mode.
1634
864db017
JB
16352011-05-31 Juanma Barranquero <lekktu@gmail.com>
1636
1637 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1638 Update dependencies.
1639
2ad0baf4
DN
16402011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1641
1642 * data.c (init_data): Remove code for UTS, this system is not
1643 supported anymore.
1644
4fcc2638
DN
16452011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1646
1647 Don't force ./temacs to start in terminal mode.
1648
1649 * frame.c (make_initial_frame): Initialize faces in all cases, not
1650 only when CANNOT_DUMP is defined.
1651 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1652
c56e0fd5
DN
16532011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1654
1655 * dispnew.c (add_window_display_history): Use const for the string
1656 pointer. Remove declaration, not needed.
1657
333d54da 16582011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 1659
55d4c1b2 1660 Use 'inline', not 'INLINE'.
333d54da 1661 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
1662 * alloc.c, fontset.c (INLINE): Remove.
1663 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1664 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1665 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1666 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1667 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1668
738db178
DN
16692011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1670
1671 Make it possible to run ./temacs.
1672
1673 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1674 syms_of_callproc does the same thing. Remove test for
1675 "initialized", do it in the caller.
1676 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1677
620c53a6
SM
16782011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1679
1680 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1681 (read_minibuf): Use get_minibuffer.
1682 (syms_of_minibuf): Use DEFSYM.
1683 (Qmetadata): New var.
1684 * data.c (Qbuffer): Don't make it static.
1685 (syms_of_data): Use DEFSYM.
1686
e003a292
PE
16872011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1688
1689 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1690 (CCL_CODE_MIN): New macro.
1691
ed008a6d
PE
16922011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1693
3687c2ef
PE
1694 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1695
ed008a6d
PE
1696 * eval.c (Qdebug): Now static.
1697 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1698 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1699 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1700
d66c4c7c
CY
17012011-05-29 Chong Yidong <cyd@stupidchicken.com>
1702
1703 * image.c: Various fixes to ImageMagick code comments.
1704 (Fimagemagick_types): Doc fix.
1705
5fbc2025
PE
17062011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1707
0196f88a
PE
1708 Minor fixes prompted by GCC 4.6.0 warnings.
1709
1710 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1711
5fbc2025
PE
1712 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1713 (x_clipboard_manager_save_all): Move extern decl to ...
1714 * xterm.h: ... here, so that it can be checked for consistency.
1715
1dd3c2d9
CY
17162011-05-29 Chong Yidong <cyd@stupidchicken.com>
1717
1718 * xselect.c (x_clipboard_manager_save_frame)
1719 (x_clipboard_manager_save_all): New functions.
1720 (Fx_clipboard_manager_save): Lisp function deleted.
1721
1722 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1723 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1724
1725 * xterm.h: Update prototype.
1726
5ba6571d
WX
17272011-05-28 William Xu <william.xwl@gmail.com>
1728
1729 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1730 exiting (Bug#8239).
1731
3eaff834
JM
17322011-05-28 Jim Meyering <meyering@redhat.com>
1733
e1900994 1734 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
1735 * fns.c (to_uchar): Define.
1736 (crypto_hash_function): Use it to convert some newly-signed
1737 variables to unsigned, to avoid sign-extension bugs. For example,
1738 without this change, (md5 "truc") would evaluate to
1739 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1740 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 1741 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 1742
0f6990a7
PE
17432011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1744
1745 Integer overflow fixes.
c8a9ca5a 1746
08686060
PE
1747 * dbusbind.c: Serial number integer overflow fixes.
1748 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
1749 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1750 to hold a serial number that is too large for a fixnum.
1751 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1752 Check for serial numbers out of range. Decode any serial number
59568bf0 1753 that was so large that it became a float. (Bug#8722)
08686060 1754
2d1fc3c7
PE
1755 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1756 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1757 Use XFASTINT rather than XUINT when numbers are nonnegative.
1758 (xd_append_arg, Fdbus_method_return_internal):
1759 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1760 arguments, check that Lisp number is nonnegative, rather than
59568bf0 1761 silently wrapping negative numbers around. (Bug#8722)
30217ff0 1762 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 1763 (Bug#8722)
2d1fc3c7 1764
c8a9ca5a
PE
1765 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1766
519e1d69
PE
1767 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1768
30569699
PE
1769 ccl: add integer overflow checks
1770 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1771 (IN_INT_RANGE): New macros.
1772 (ccl_driver): Use them to check for integer overflow when
1773 decoding a CCL program. Many of the new checks are whether XINT (x)
1774 fits in int; it doesn't always, on 64-bit hosts. The new version
1775 doesn't catch all possible integer overflows, but it's an
847044ea 1776 improvement. (Bug#8719)
30569699 1777
c11285dc
PE
1778 * alloc.c (make_event_array): Use XINT, not XUINT.
1779 There's no need for unsigned here.
1780
fdccd48e
PE
1781 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1782 This follows up to the 2011-05-06 change that substituted uintptr_t
1783 for EMACS_INT. This case wasn't caught back then.
1784
37910ab2
PE
1785 Rework Fformat to avoid integer overflow issues.
1786 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1787 now (part of C89). Include <verify.h>.
1788 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1789 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1790 (Fformat): Avoid the prepass trying to compute sizes; it was only
1791 approximate and thus did not catch overflow reliably. Instead, walk
1792 through the format just once, formatting and computing sizes as we go,
1793 checking for integer overflow at every step, and allocating a larger
1794 buffer as needed. Keep track separately whether the format is
1795 multibyte. Keep only the most-recently calculated precision, rather
1796 than them all. Record whether each argument has been converted to
1797 string. Use EMACS_INT, not int, for byte and char and arg counts.
1798 Support field widths and precisions larger than INT_MAX. Avoid
1799 sprintf's undefined behavior with conversion specifications such as %#d
1800 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1801 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1802 formatting out-of-range floating point numbers with int
1803 formats. (Bug#8668)
1804
2e6578fb
PE
1805 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1806
0ae6bdee
PE
1807 * data.c: Avoid integer truncation in expressions involving floats.
1808 * data.c: Include <intprops.h>.
1809 (arith_driver): When there's an integer overflow in an expression
1810 involving floating point, convert the integers to floating point
1811 so that the resulting value does not suffer from catastrophic
1812 integer truncation. For example, on a 64-bit host (* 4
1813 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1814 Do not rely on undefined behavior after integer overflow.
1815
de883a70
PE
1816 merge count_size_as_multibyte, parse_str_to_multibyte
1817 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 1818 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
1819 Check for integer overflow.
1820 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1821 since it's now a duplicate of the other. This is more of
1822 a character than a buffer op, so better that it's in character.c.
1823 * fns.c, print.c: Adjust to above changes.
1824
2ff916cb
PE
18252011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1826
1827 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1828
f1b54466
PE
18292011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1830
fb1ac845
PE
1831 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1832 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1833 (x_clipboard_manager_save): Now static.
1834 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1835
f1b54466
PE
1836 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1837 (crypto_hash_function): Now static.
1838 Fix pointer signedness problems. Avoid unnecessary initializations.
1839
a9f737ee
CY
18402011-05-27 Chong Yidong <cyd@stupidchicken.com>
1841
1842 * termhooks.h (Vselection_alist): Make it terminal-local.
1843
1844 * terminal.c (create_terminal): Initialize it.
1845
1846 * xselect.c: Support for clipboard managers.
1847 (Vselection_alist): Move to termhooks.h as terminal-local var.
1848 (LOCAL_SELECTION): New macro.
1849 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1850 (symbol_to_x_atom): Remove gratuitous arg.
1851 (x_handle_selection_request, lisp_data_to_selection_data)
1852 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
1853 (x_own_selection, x_get_local_selection, x_convert_selection):
1854 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
1855 (some_frame_on_display): Delete unused function.
1856 (Fx_own_selection_internal, Fx_get_selection_internal)
1857 (Fx_disown_selection_internal, Fx_selection_owner_p)
1858 (Fx_selection_exists_p): New optional frame arg.
1859 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1860 (x_handle_selection_clear): Don't treat other terminals with the
1861 same keyboard specially. Use the terminal-local Vselection_alist.
1862 (x_clear_frame_selections): Use Frun_hook_with_args.
1863
1864 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1865
1866 * xterm.h: Add support for those atoms.
1867
e067f0c1
CY
18682011-05-26 Chong Yidong <cyd@stupidchicken.com>
1869
1870 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1871 (converted_selections, conversion_fail_tag): New global variables.
1872 (x_selection_request_lisp_error): Free the above.
1873 (x_get_local_selection): Remove unnecessary code.
1874 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
1875 of converted selections stored in converted_selections.
1876 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
1877 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1878 (x_convert_selection): New function.
1879 (x_handle_selection_event): Simplify.
1880 (x_get_foreign_selection): Don't ignore incoming requests while
1881 waiting for an answer; this will fail when we implement
1882 SAVE_TARGETS, and seems unnecessary anyway.
1883 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1884 (Vx_sent_selection_functions): Doc fix.
1885
0f4aebc0
LL
18862011-05-26 Leo Liu <sdl.web@gmail.com>
1887
1888 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1889
e61124cd
YM
18902011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1891
1892 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1893
1894 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1895 for fringe update if it has periodic bitmap.
1896 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1897 and fringe_bitmap_periodic_p.
1898
1899 * fringe.c (get_fringe_bitmap_data): New function.
1900 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1901 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1902 row. Mark glyph row for fringe update if periodicity changed.
1903
1904 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1905 for fringe update unless it has periodic bitmap.
1906
f16d9837
KH
19072011-05-25 Kenichi Handa <handa@m17n.org>
1908
1909 * xdisp.c (get_next_display_element): Set correct it->face_id for
1910 a static composition.
1911
e1b90ef6
LL
19122011-05-24 Leo Liu <sdl.web@gmail.com>
1913
1914 * deps.mk (fns.o):
1915 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1916
1917 * fns.c (crypto_hash_function, Fsha1): New function.
1918 (Fmd5): Use crypto_hash_function.
1919 (syms_of_fns): Add Ssha1.
1920
7400048f
PE
19212011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1922
1923 * gnutls.c: Remove unused macros.
1924 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1925 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1926 Remove macros that are defined and never used.
1927 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1928
abb71cf4
CY
19292011-05-22 Chong Yidong <cyd@stupidchicken.com>
1930
1931 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1932 (Fx_get_selection_internal): Minor cleanup.
1933 (Fx_own_selection_internal): Rename arguments for consistency with
1934 select.el.
1935
6307db39
PE
19362011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1937
1938 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1939
f3d4e0a4
CY
19402011-05-22 Chong Yidong <cyd@stupidchicken.com>
1941
1942 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1943
4d8ade89
YM
19442011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1945
1946 * dispnew.c (scrolling_window): Don't exclude the case that the
1947 last enabled row in the desired matrix touches the bottom boundary.
1948
32078c8d
GM
19492011-05-21 Glenn Morris <rgm@gnu.org>
1950
1951 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
1952 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1953 and add some more files.
32078c8d 1954
7285dc67
EZ
19552011-05-20 Eli Zaretskii <eliz@gnu.org>
1956
1957 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1958 report_file_error introduced by the change from 2011-05-07.
1959
89d1bd22
PE
19602011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1961
1962 * systime.h (Time): Define only if emacs is defined.
1963 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1964 where the include path doesn't have X11/X.h by default. See
1965 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1966
e23640bb 19672011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
1968
1969 * composite.c (find_automatic_composition): Fix previous change.
1970
b9704ad9
GM
19712011-05-20 Glenn Morris <rgm@gnu.org>
1972
1973 * lisp.mk: New file, split from Makefile.in.
1974 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1975 (shortlisp): Remove.
1976 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1977
4a720484
GM
19782011-05-19 Glenn Morris <rgm@gnu.org>
1979
1980 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1981 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1982 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1983 (lisp): Set the order to that of loadup.el.
1984 (shortlisp): Make it a copy of $lisp.
1985 (SOME_MACHINE_LISP): Remove.
1986 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1987 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1988
a28d4396
KH
19892011-05-18 Kenichi Handa <handa@m17n.org>
1990
1991 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1992 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1993 (find_automatic_composition): Mostly rewrite for efficiency.
1994
a2b1fa8e
JB
19952011-05-18 Juanma Barranquero <lekktu@gmail.com>
1996
1997 * makefile.w32-in: Update dependencies.
1998
8e1f5610
CS
19992011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
2000
2001 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 2002 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 2003
7025ee00 20042011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 2005
cdfa6eab
PE
2006 Fix some integer overflow issues, such as string length overflow.
2007
06d6db33
PE
2008 * insdel.c (count_size_as_multibyte): Check for string overflow.
2009
2b4560a8
PE
2010 * character.c (lisp_string_width): Check for string overflow.
2011 Use EMACS_INT, not int, for string indexes and lengths; in
2012 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
2013 the resulting string length overflows an EMACS_INT; instead,
2014 report a string overflow if no precision given. When checking for
2015 precision exhaustion, use a check that cannot possibly have
2016 integer overflow. (Bug#8675)
2017 * character.h (lisp_string_width): Adjust to new signature.
2018
cb93f9be
PE
2019 * alloc.c (string_overflow): New function.
2020 (Fmake_string): Use it. This doesn't change behavior, but saves
2021 a few bytes and will simplify future changes.
2022 * character.c (string_escape_byte8): Likewise.
2023 * lisp.h (string_overflow): New decl.
2024
1a1f3366
PE
2025 Fixups, following up to the user-interface timestamp change.
2026 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
2027 for UI timestamps, instead of unsigned long.
9fbd6841
PE
2028 * msdos.c (mouse_get_pos): Likewise.
2029 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
2030 * w32gui.h (Time): Define by including "systime.h" rather than by
2031 declaring it ourselves. (Bug#8664)
2032
d4e3e4d3
PE
2033 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
2034 * image.c (clear_image_cache): Likewise.
2035
f6a24d19
PE
2036 * term.c (term_mouse_position): Don't assume time_t wraparound.
2037
08dc5ae6
PE
2038 Be more systematic about user-interface timestamps.
2039 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
2040 and sometimes 'EMACS_UINT', to represent these timestamps.
2041 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
2042 This makes the code easier to follow, and makes it easier to catch
2043 integer overflow bugs such as Bug#8664.
2044 * frame.c (Fmouse_position, Fmouse_pixel_position):
2045 Use Time, not unsigned long, for user-interface timestamps.
2046 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
2047 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
2048 * keyboard.h (last_event_timestamp): Likewise.
2049 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
2050 * menu.h (xmenu_show): Likewise.
2051 * term.c (term_mouse_position): Likewise.
2052 * termhooks.h (struct input_event.timestamp): Likewise.
2053 (struct terminal.mouse_position_hook): Likewise.
2054 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
2055 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
2056 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
2057 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
2058 what it was before.
2059 * menu.h, termhooks.h: Include "systime.h", for Time.
2060
8e55734a
PE
2061 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
2062 Don't assume that the difference between two unsigned long values
2063 can fit into an integer. At this point, we know button_down_time
2064 <= event->timestamp, so the difference must be nonnegative, so
2065 there's no need to cast the result if double-click-time is
2066 nonnegative, as it should be; check that it's nonnegative, just in
2067 case. This bug is triggered when events are more than 2**31 ms
86db42d2 2068 apart (about 25 days). (Bug#8664)
8e55734a 2069
841f1b75 2070 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 2071 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 2072
3e26f69c
PE
2073 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
2074 that always fit in int. Use a sentinel instead of a counter, to
2075 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
2076 * frame.h (struct frame): Use int for menu_bar_items_used
2077 instead of EMACS_INT, since it always fits in int.
3e26f69c 2078
5cc152c0
PE
2079 * menu.c (grow_menu_items): Check for int overflow.
2080
d89eb65e
PE
2081 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
2082
5235bd3e
PE
2083 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
2084 Before, the code was not consistent. These values cannot exceed
2085 2**31 - 1 so there's no need to make them unsigned.
2086 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
2087 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
2088 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
2089 as modifiers.
2090 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
2091
bc827e23
PE
2092 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
2093 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
2094 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
2095 presumably because the widths might not match.
2096
78eb494e
PE
2097 * window.c (size_window): Avoid needless test at loop start.
2098
04f2d78b
CB
20992011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
2100
2101 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
2102
d2fc7e3d 21032011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
2104
2105 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
2106
d2fc7e3d 21072011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
2108
2109 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
2110 `width' to `bar_area_x' and `bar_area_width', respectively.
2111 (x_scroll_run): Take account of fringe background extension.
2112
04f2d78b
CB
2113 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
2114 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
2115 `bar_area_width', respectively.
2116 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
2117 background extension.
2118
79b70037
GM
21192011-05-10 Jim Meyering <meyering@redhat.com>
2120
2121 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
2122
2f142cc5
JB
21232011-05-10 Juanma Barranquero <lekktu@gmail.com>
2124
2125 * image.c (Finit_image_library): Return t for built-in image types,
2126 like pbm and xbm. (Bug#8640)
2127
57679c86
AS
21282011-05-09 Andreas Schwab <schwab@linux-m68k.org>
2129
2130 * w32menu.c (set_frame_menubar): Fix submenu allocation.
2131
888c9e86
EZ
21322011-05-07 Eli Zaretskii <eliz@gnu.org>
2133
b0512a1d
EZ
2134 * w32console.c (Fset_screen_color): Doc fix.
2135 (Fget_screen_color): New function.
2136 (syms_of_ntterm): Defsubr it.
2137
7285dc67
EZ
2138 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
2139 unlink the temporary file if Fcall_process didn't create it in the
2140 first place.
2141 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
2142 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
2143 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
2144 cue to call_process_cleanup not to close that handle.
2145
4d3fcc8e
BK
21462011-05-07 Ben Key <bkey76@gmail.com>
2147
2148 * makefile.w32-in: The bootstrap-temacs rule now makes use of
2149 one of two shell specific rules, either bootstrap-temacs-CMD or
2150 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
2151 to the previous implementation of the bootstrap-temacs rule.
2152 The bootstrap-temacs-CMD rule is similar to the previous
2153 implementation of the bootstrap-temacs rule except that it
2154 makes use of the ESC_CFLAGS variable instead of the CFLAGS
2155 variable.
2156
2157 These changes, along with some changes to nt/configure.bat,
2158 nt/gmake.defs, and nt/nmake.defs, are required to extend my
2159 earlier fix to add support for --cflags and --ldflags options
2160 that include quotes so that it works whether make uses cmd or
2161 sh as the shell.
2162
b4289b64
MA
21632011-05-06 Michael Albinus <michael.albinus@gmx.de>
2164
2165 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
2166 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
2167 is a constant.
2168 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
2169 a string. Handle both cases.
2170 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
2171 (Fdbus_register_method): Use Qinvalid_function.
2172
af4c0e28
JB
21732011-05-06 Juanma Barranquero <lekktu@gmail.com>
2174
2175 * makefile.w32-in: Update dependencies.
2176 (LISP_H): Add inttypes.h and stdin.h.
2177 (PROCESS_H): Add unistd.h.
2178
c51453d9
EZ
21792011-05-06 Eli Zaretskii <eliz@gnu.org>
2180
2181 * lread.c: Include limits.h (fixes the MS-Windows build broken by
2182 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
2183
8ff0ac3c 21842011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 2185
4c4b566b
PE
2186 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
2187
aab2b9b5
PE
2188 * term.c (vfatal): Remove stray call to va_end.
2189 It's not needed and the C Standard doesn't allow it here anyway.
2190
c378da0b
PE
2191 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
2192 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
2193
288b08c7
PE
2194 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2195 bytes.
2196
e3601888
PE
2197 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2198
db6c0e74
PE
2199 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2200
dd5963ea
PE
2201 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2202
88c9450f
PE
2203 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2204
2f9442b8
PE
2205 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2206
c032b5f8
PE
2207 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2208 * charset.c (Fdefine_charset_internal): Don't initialize
2209 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 2210 32-bit int (Bug#8600).
a108c10b
PE
2211
2212 * lread.c (read_integer): Be more consistent with string-to-number.
2213 Use string_to_number to do the actual conversion; this avoids
2214 rounding errors and fixes some other screwups. Without this fix,
2215 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2216 (digit_to_number): Move earlier, for benefit of read_integer.
2217 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 2218 not a digit in any supported base. (Bug#8602)
a108c10b 2219
ad5f9eea
PE
2220 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2221
aec1708a
PE
2222 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2223 to match comment at start of function. This also removes a
2224 GCC warning about overflow in a 32+64-bit port.
2225
47be4ab5
PE
2226 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2227
371cac43
PE
2228 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2229 Reported by Stefan Monnier in
2230 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
2231 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2232 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 2233
d01a7826
PE
2234 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2235 (EMACS_UINTPTR): Likewise, with uintptr_t.
2236
7fd47d5c
PE
2237 * lisp.h: Prefer 64-bit EMACS_INT if available.
2238 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2239 on 32-bit hosts that have 64-bit int, so that they can access
2240 large files.
122b0c86
PE
2241 However, temporarily disable this change unless the temporary
2242 symbol WIDE_EMACS_INT is defined.
7fd47d5c 2243
8727937b
PE
2244 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
2245
8ac068ac
PE
2246 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
2247 This removes an assumption that EMACS_INT and long are the same
2248 width as pointers. The assumption is true for Emacs porting targets
2249 now, but we want to make other targets possible.
2250 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2251 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2252 In the rest of the code, change types of integers that hold casted
2253 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
2254 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
2255 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
2256 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
2257 No need to cast type when ORing.
2258 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
2259 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
2260 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
2261 assume EMACS_INT is the same width as char *.
2262 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
2263 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
2264 Remove no-longer-needed casts.
2265 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2266 (xg_tool_bar_help_callback, xg_make_tool_item):
2267 Use EMACS_INTPTR to hold an integer
2268 that will be cast to void *; this can avoid a GCC warning
2269 if EMACS_INT is not the same width as void *.
2270 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
2271 * xdisp.c (display_echo_area_1, resize_mini_window_1):
2272 (current_message_1, set_message_1):
2273 Use a local to convert to proper width without a cast.
2274 * xmenu.c (dialog_selection_callback): Likewise.
2275
ede49d71
PE
2276 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
2277 Also, don't assume VALBITS / RAND_BITS is less than 5,
2278 and don't rely on undefined behavior when shifting a 1 left into
2279 the sign bit.
2280 * lisp.h (get_random): Change signature to match.
2281
2f30ecd0
PE
2282 * lread.c (hash_string): Use size_t, not int, for hash computation.
2283 Normally we prefer signed values; but hashing is special, because
2284 it's better to use unsigned division on hash table sizes so that
2285 the remainder is nonnegative. Also, size_t is the natural width
2286 for hashing into memory. The previous code used 'int', which doesn't
2287 retain enough info to hash well into very large tables.
2288 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
2289
2a866e7b
PE
2290 * dbusbind.c: Don't possibly lose pointer info when converting.
2291 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2292 Use XPNTR rather than XHASH, so that the high-order bits of
2293 the pointer aren't lost when converting through void *.
2294
51639eac
PE
2295 * eval.c (Fautoload): Don't double-shift a pointer.
2296
92394119
PE
2297 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
2298
dbdb9a7c
JB
22992011-05-06 Juanma Barranquero <lekktu@gmail.com>
2300
2301 * gnutls.c (DEF_GNUTLS_FN):
2302 * image.c (DEF_IMGLIB_FN): Make function pointers static.
2303
db7a0b4f
AS
23042011-05-05 Andreas Schwab <schwab@linux-m68k.org>
2305
2306 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
2307 marker. (Bug#8610)
2308
f7ff1b0f 23092011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
2310
2311 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
2312 New version that can reserve upto 2GB of heap space.
2313
f7ff1b0f 23142011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
2315
2316 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
2317
639c109b
TZ
23182011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
2319
2320 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
2321 `gnutls_certificate_set_x509_key_file'.
2322
d2127135
JB
23232011-05-05 Juanma Barranquero <lekktu@gmail.com>
2324
2325 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
2326 Update dependencies.
2327
e968f4f3
JB
23282011-05-04 Juanma Barranquero <lekktu@gmail.com>
2329
2330 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
2331 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2332 Remove unused parameter `fildes'.
2333 * process.c (read_process_output, send_process): Don't pass it.
2334
84d358f0
JB
23352011-05-04 Juanma Barranquero <lekktu@gmail.com>
2336
2337 Fix previous change: the library cache is defined in w32.c.
2338 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
2339 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
2340
0898ca10
JB
23412011-05-04 Juanma Barranquero <lekktu@gmail.com>
2342
2343 Implement dynamic loading of GnuTLS on Windows.
2344
2345 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
2346 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
2347 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2348 Declare.
2349
2350 * gnutls.c (Qgnutls_dll): Define.
2351 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
2352 (gnutls_*): Declare function pointers.
2353 (init_gnutls_functions): New function to initialize function pointers.
2354 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
2355 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
2356 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2357 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
2358 (emacs_gnutls_write, emacs_gnutls_read)
2359 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
2360 (Fgnutls_available_p): New function.
2361 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
2362 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
2363 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
2364
2365 * image.c: Include w32.h.
2366 (Vimage_type_cache): Delete.
2367 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
2368 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
2369 (w32_delayed_load): Move to w32.c.
2370
2371 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
2372
2373 * w32.c (QCloaded_from, Vlibrary_cache): Define.
2374 (w32_delayed_load): Move from image.c. When loading a library, record
2375 its filename in the :loaded-from property of the library id.
2376 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
2377 Initialize and staticpro them.
2378 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
2379
2380 * process.c: Include lisp.h before w32.h, not after.
2381 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
2382 instead of gnutls_record_check_pending.
2383
2384 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
2385
ff4de4aa
TZ
23862011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
2387
2388 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
2389 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
2390 as passed in.
2391
abe95abb
JD
23922011-05-03 Jan Djärv <jan.h.d@swipnet.se>
2393
2394 * xterm.c (x_set_frame_alpha): Do not set property on anything
2395 else than FRAME_X_OUTER_WINDOW (Bug#8608).
2396
e16e55d4
JB
23972011-05-02 Juanma Barranquero <lekktu@gmail.com>
2398
2399 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
2400
bafcf6a5
JB
24012011-05-02 Juanma Barranquero <lekktu@gmail.com>
2402
2403 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
2404 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
2405 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
2406 (gnutls_global_initialized, Qgnutls_bootprop_priority)
2407 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
2408 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
2409 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
2410 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
2411 (Qgnutls_bootprop_callbacks_verify): Make static.
2412
e7a6747f
AS
24132011-05-01 Andreas Schwab <schwab@linux-m68k.org>
2414
19ed11ba
AS
2415 * callproc.c: Indentation fixup.
2416
e7a6747f 2417 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
2418 (wait_for_termination, interruptible_wait_for_termination):
2419 Move after wait_for_termination_1.
e7a6747f 2420
1ef14cb4
LMI
24212011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
2422
2423 * sysdep.c (interruptible_wait_for_termination): New function
2424 which is like wait_for_termination, but allows keyboard
2425 interruptions.
2426
2427 * callproc.c (Fcall_process): Add (:file "file") as an option for
2428 the STDOUT buffer.
2429 (Fcall_process_region): Ditto.
2430
330d880c
EZ
24312011-04-30 Eli Zaretskii <eliz@gnu.org>
2432
8db90b73
EZ
2433 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
2434 rather than `XVECTOR (FOO)->size'.
2435
330d880c
EZ
2436 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
2437 inttypes.h, as a gnulib replacement is used if it not available in
2438 system headers.
2439
15cbd324
EZ
24402011-04-21 Eli Zaretskii <eliz@gnu.org>
2441
2442 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
2443 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
2444 of MOST_POSITIVE_FIXNUM. (Bug#8528)
2445
2446 * coding.c (coding_alloc_by_realloc): Error out if destination
2447 will grow beyond MOST_POSITIVE_FIXNUM.
2448 (decode_coding_emacs_mule): Abort if there isn't enough place in
2449 charbuf for the composition carryover bytes. Reserve an extra
2450 space for up to 2 characters produced in a loop.
2451 (decode_coding_iso_2022): Abort if there isn't enough place in
2452 charbuf for the composition carryover bytes.
2453
24542011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 2455
ae940cca
EZ
2456 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
2457 aborting when %lld or %lll format is passed.
2458 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
2459 %llo or %llx format is passed. (Bug#8545)
2460
03ab8921
EZ
2461 * window.c (window_scroll_line_based): Use a marker instead of
2462 simple variables to record original value of point. (Bug#7952)
2463
afda1437
EZ
2464 * doprnt.c (doprnt): Fix the case where a multibyte sequence
2465 produced by %s or %c overflows available buffer space. (Bug#8545)
2466
f76dee0c
PE
24672011-04-28 Paul Eggert <eggert@cs.ucla.edu>
2468
2469 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 2470 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 2471
fdc5744d
JB
24722011-04-28 Juanma Barranquero <lekktu@gmail.com>
2473
2474 * w32.c (init_environment): Warn about defaulting HOME to C:\.
2475
638f053a
JB
24762011-04-28 Juanma Barranquero <lekktu@gmail.com>
2477
2478 * keyboard.c (Qdelayed_warnings_hook): Define.
2479 (command_loop_1): Run `delayed-warnings-hook'
2480 if Vdelayed_warnings_list is non-nil.
2481 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
2482 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
2483
d178f871
EZ
24842011-04-28 Eli Zaretskii <eliz@gnu.org>
2485
2486 * doprnt.c (doprnt): Don't return value smaller than the buffer
2487 size if the message was truncated. (Bug#8545).
2488
b124fd93
JB
24892011-04-28 Juanma Barranquero <lekktu@gmail.com>
2490
2491 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
2492 (Fx_window_property): #if-0 the whole functions, not just the bodies.
2493
e810457d
PE
24942011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2495
2496 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
2497
ea51cceb
JB
24982011-04-27 Juanma Barranquero <lekktu@gmail.com>
2499
2500 * makefile.w32-in: Update dependencies.
2501
94dcfacf
EZ
25022011-04-27 Eli Zaretskii <eliz@gnu.org>
2503
2504 Improve `doprnt' and its usage. (Bug#8545)
2505 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
2506 `format_end'. Remove support for %l as a conversion specifier.
2507 Don't use xrealloc. Improve diagnostics when the %l size modifier
2508 is used. Update the commentary.
2509
2510 * eval.c (verror): Simplify calculation of size_t.
2511
2512 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
2513 messages.
2514
f61f41d7
PE
25152011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
2516
2517 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
2518 change.
2519
96fb4434
PE
25202011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2521
2522 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2523 This makes this file independent of the recent pseudovector change.
2524
671875da 25252011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 2526
69e9b5a3
PE
2527 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2528
b5f869a7 2529 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 2530 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 2531 Remove unused local.
c8926152 2532 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 2533
841a1577 2534 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
2535 GCC 4.6.0 optimizes based on type-based alias analysis.
2536 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
2537 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2538 != &v->size, and therefore "v->size = 1; b->size = 2; return
2539 v->size;" must therefore return 1. This assumption is incorrect
2540 for Emacs, since it type-puns struct Lisp_Vector * with many other
2541 types. To fix this problem, this patch adds a new type struct
f904488f 2542 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
2543 and pseudovectors, and helps optimizing compilers not get fooled
2544 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2545 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
2546 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2547 the size member.
eab3844f
PE
2548 (XSETPVECTYPE): Rewrite in terms of new macro.
2549 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2550 This is a bit clearer, and further avoids the possibility of
2551 undesirable aliasing.
2552 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 2553 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
2554 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2555 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
2556 (ASIZE): Now uses header.size rather than size.
2557 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
2558 to avoid the hassle of writing XVECTOR (foo)->header.size.
2559 (struct vectorlike_header): New type.
eab3844f
PE
2560 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2561 object, to help avoid aliasing.
2562 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2563 (SUBRP): Likewise, since Lisp_Subr is a special case.
2564 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2565 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2566 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 2567 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
2568 changed to be "header.size" and "header.next".
2569 * buffer.h (struct buffer): Likewise.
2570 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2571 * frame.h (struct frame): Likewise.
2572 * process.h (struct Lisp_Process): Likewise.
2573 * termhooks.h (struct terminal): Likewise.
2574 * window.c (struct save_window_data, struct saved_window): Likewise.
2575 * window.h (struct window): Likewise.
2576 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2577 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2578 * buffer.c (init_buffer_once): Likewise.
2579 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2580 special case.
2581 * process.c (Fformat_network_address): Use local var for size,
2582 for brevity.
2583
0df1eac5
PE
2584 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2585
847ab9d1 2586 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
2587 * data.c (atof): Remove decl; no longer used or needed.
2588 (digit_to_number): Move to lread.c.
2589 (Fstring_to_number): Use new string_to_number function, to be
2590 consistent with how the Lisp reader treats infinities and NaNs.
2591 Do not assume that floating-point numbers represent EMACS_INT
2592 without losing information; this is not true on most 64-bit hosts.
2593 Avoid double-rounding errors, by insisting on integers when
2594 parsing non-base-10 numbers, as the documentation specifies.
2595 * lisp.h (string_to_number): New decl, replacing ...
2596 (isfloat_string): Remove.
bc0a5c13 2597 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 2598 (read1): Do not accept +. and -. as integers; this
452f4150
PE
2599 appears to have been a coding error. Similarly, do not accept
2600 strings like +-1e0 as floating point numbers. Do not report
2601 overflow for integer overflows unless the base is not 10 which
2602 means we have no simple and reliable way to continue.
2603 Break out the floating-point parsing into a new
2604 function string_to_number, so that Fstring_to_number parses
2605 floating point numbers consistently with the Lisp reader.
04f2d78b 2606 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
2607 (E_CHAR, EXP_INT): Remove, replacing with ...
2608 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2609 (string_to_number): New function, replacing isfloat_string.
2610 This function checks for valid syntax and produces the resulting
2611 Lisp float number too. Rework it so that string-to-number
bc0a5c13 2612 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
2613 so that overflow for non-base-10 numbers is reported only when
2614 there's no portable and simple way to convert to floating point.
452f4150 2615
67769ffc
PE
2616 * textprop.c (set_text_properties_1): Rewrite for clarity,
2617 and to avoid GCC warning about integer overflow.
2618
c20db43f
PE
2619 * intervals.h (struct interval): Use EMACS_INT for members
2620 where EMACS_UINT might cause problems. See
2621 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2622 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2623 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2624 All uses changed.
37aa2f85
PE
2625 (offset_intervals): Tell GCC not to worry about length overflow
2626 when negating a negative length.
c20db43f 2627
2538aa2f
PE
2628 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2629 (overrun_check_free): Likewise.
2630
f2d3008d
PE
2631 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2632 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2633 word size.
2634
ec8df744
PE
2635 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2636 (gnutls_make_error): Rename local to avoid shadowing.
2637 (gnutls_emacs_global_deinit): ifdef out; not used.
2638 (Fgnutls_boot): Use const for pointer to readonly storage.
2639 Comment out unused local. Fix pointer signedness problems.
2640
640ee02d
PE
2641 * lread.c (openp): Don't stuff size_t into an 'int'.
2642 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2643 about possible signed overflow.
2644
6048fb2a
PE
2645 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2646 (GDK_KEY_g): Don't define if already defined.
2647 (xg_prepare_tooltip): Avoid pointer signedness problem.
2648 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2649
fa3c87e1
PE
2650 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2651 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2652
2172544b
PE
2653 * xfns.c (Fx_window_property): Simplify a bit,
2654 to make a bit faster and to avoid GCC 4.6.0 warning.
2655 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2656
9b821a21
PE
2657 * fns.c (internal_equal): Don't assume size_t fits in int.
2658
3c616cfa
PE
2659 * alloc.c (compact_small_strings): Tighten assertion a little.
2660
c2982e87
PE
2661 Replace pEd with more-general pI, and fix some printf arg casts.
2662 * lisp.h (pI): New macro, generalizing old pEd macro to other
2663 conversion specifiers. For example, use "...%"pI"d..." rather
2664 than "...%"pEd"...".
2665 (pEd): Remove. All uses replaced with similar uses of pI.
2666 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2667 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2668 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2669 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2670 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2671 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2672 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2673 64-bit hosts.
2674 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2675 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2676 * print.c (safe_debug_print, print_object): Likewise.
2677 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2678 to int.
6f04d126
PE
2679 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2680 avoiding the 0 flag, which is not portable.
c2982e87
PE
2681 * process.c (Fmake_network_process): Use pI to avoid cast.
2682 * region-cache.c (pp_cache): Likewise.
2683 * xdisp.c (decode_mode_spec): Likewise.
2684 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2685 behavior on 64-bit hosts with printf arg.
6f04d126 2686 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
2687 (x_stop_queuing_selection_requests): Likewise.
2688 (x_get_window_property): Don't truncate byte count to an 'int'
2689 when tracing.
0b432f21 2690
5e073ec7
PE
2691 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2692 here, since it parses constructs like leading '-' and spaces,
2693 which are not wanted; and it overflows with large numbers.
2694 Instead, simply match F[0-9]+, which is what is wanted anyway.
2695
36372bf9
PE
2696 * alloc.c: Remove unportable assumptions about struct layout.
2697 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2698 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2699 (allocate_vectorlike, make_pure_vector): Use the new macros,
2700 plus offsetof, to remove unportable assumptions about struct layout.
2701 These assumptions hold on all porting targets that I know of, but
2702 they are not guaranteed, they're easy to remove, and removing them
2703 makes further changes easier.
2704
0b432f21
PE
2705 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2706 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
2707 (string_overrun_cookie): Now const. Use initializers that
2708 don't formally overflow signed char, to avoid warnings.
000098c1
PE
2709 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2710 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
2711 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2712 multiple of sizeof (EMACS_INT); it need not be, if
2713 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 2714 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 2715
895009e1
JB
27162011-04-26 Juanma Barranquero <lekktu@gmail.com>
2717
2718 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2719
6a7a1b0b
TZ
27202011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2721
2722 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 2723 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
2724 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2725
841a1577 27262011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
2727
2728 * lisp.h (Qdebug): List symbol.
895009e1 2729 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
2730 * keyboard.c (debug-on-event): New variable.
2731 (handle_user_signal): Break into debugger when debug-on-event
2732 matches the current signal symbol.
2733
f2d3ba6f
DN
27342011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2735
2736 * alloc.c (check_sblock, check_string_bytes)
2737 (check_string_free_list): Convert to standard C.
2738
42ce4c63
TZ
27392011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2740
2741 * w32.c (emacs_gnutls_push): Fix typo.
2742
825cd63c
EZ
27432011-04-25 Eli Zaretskii <eliz@gnu.org>
2744
fb11d64d
EZ
2745 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2746 "cast to pointer from integer of different size".
2747
825cd63c
EZ
2748 Improve doprnt and its use in verror. (Bug#8545)
2749 * doprnt.c (doprnt): Document the set of format control sequences
2750 supported by the function. Use SAFE_ALLOCA instead of always
2751 using `alloca'.
2752
2753 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2754 is one byte too soon. Don't use xrealloc; instead xfree and
2755 xmalloc anew.
2756
e061a11b
TZ
27572011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2758
2759 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2760 callbacks stage.
2761
2762 * gnutls.c: Renamed global_initialized to
2763 gnutls_global_initialized. Added internals for the
2764 :verify-hostname-error, :verify-error, and :verify-flags
2765 parameters of `gnutls-boot' and documented those parameters in the
2766 docstring. Start callback support.
2767 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2768 unless a fatal error occured. Call gnutls_alert_send_appropriate
2769 on error. Return error code.
2770 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2771 (emacs_gnutls_read): Likewise.
2772 (Fgnutls_boot): Return handshake error code.
2773 (emacs_gnutls_handle_error): New function.
2774 (wsaerror_to_errno): Likewise.
2775
2776 * w32.h (emacs_gnutls_pull): Add prototype.
2777 (emacs_gnutls_push): Likewise.
2778
2779 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2780 (emacs_gnutls_push): Likewise.
2781
27822011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2783
2784 * process.c (wait_reading_process_output): Check if GnuTLS
2785 buffered some data internally if no FDs are set for TLS
2786 connections.
2787
2788 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2789 (LIBS): Link to USER_LIBS.
2790 ($(BLD)/gnutls.$(0)): New target.
2791
fa6996bc
EZ
27922011-04-24 Eli Zaretskii <eliz@gnu.org>
2793
eb35682e
EZ
2794 * xdisp.c (handle_single_display_spec): Rename the
2795 display_replaced_before_p argument into display_replaced_p, to
2796 make it consistent with the commentary. Fix typos in the
2797 commentary.
2798
e2ad650c
EZ
2799 * textprop.c (syms_of_textprop): Remove dead code.
2800 (copy_text_properties): Delete obsolete commentary about an
2801 interface that was deleted long ago. Fix typos in the description
2802 of arguments.
2803
1b2de274
EZ
2804 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2805 to changes in oldXMenu/XMenu.h from 2011-04-16.
2806 <menu_help_message, prev_menu_help_message>: Constify.
2807 (IT_menu_make_room): menu->help_text is now `const char **';
2808 adjust.
2809
2810 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2811 to changes in oldXMenu/XMenu.h from 2011-04-16.
2812 (struct XMenu): Declare `help_text' `const char **'.
2813
2814 * xfaces.c <Qunspecified>: Make extern again.
2815
2816 * syntax.c: Include sys/types.h before including regex.h, as
2817 required by Posix.
2818
762b15be
EZ
2819 * doc.c (get_doc_string): Improve the format passed to `error'.
2820
2821 * doprnt.c (doprnt): Improve commentary.
2822
2823 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2824
2825 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2826 them with etags.
2827
f1052e5d
EZ
2828 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2829 changes in globals.h immediately force recompilation.
762b15be
EZ
2830 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2831 $(CURDIR)/s/ms-w32.h.
2832 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 2833
fa6996bc
EZ
2834 * character.c (Fchar_direction): Function deleted.
2835 (syms_of_character): Don't defsubr it.
2836 <char-direction-table>: Deleted.
2837
e6c3da20
EZ
28382011-04-23 Eli Zaretskii <eliz@gnu.org>
2839
2840 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2841 * doprnt.c: Include limits.h.
2842 (SIZE_MAX): New macro.
04f2d78b
CB
2843 (doprnt): Return a size_t value. 2nd arg is now size_t.
2844 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
2845 Improve overflow protection. Support `l' modifier for integer
2846 conversions. Support %l conversion. Don't assume an EMACS_INT
2847 argument for integer conversions and for %c.
2848
2849 * lisp.h (doprnt): Restore prototype.
2850
2851 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2852 $(SRC)/character.h.
2853
2854 * Makefile.in (base_obj): Add back doprnt.o.
2855
2856 * deps.mk (doprnt.o): Add back prerequisites.
2857 (callint.o): Depend on character.h.
2858
2859 * eval.c (internal_lisp_condition_case): Include the handler
2860 representation in the error message.
2861 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2862 when breaking from the loop.
2863
2864 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2865
2866 * callint.c (Fcall_interactively): When displaying error message
2867 about invalid control letter, pass the character's codepoint, not
2868 a pointer to its multibyte form. Improve display of the character
2869 in octal and display also its hex code.
2870
2871 * character.c (char_string): Use %x to display the (unsigned)
2872 codepoint of an invalid character, to avoid displaying a bogus
2873 negative value.
2874
2875 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2876 `error', not SYMBOL_NAME itself.
2877
2878 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2879 character arguments to `error'.
2880
2881 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2882 to `error' in error message about FINAL_CHAR argument. Make sure
2883 FINAL_CHAR is a character, and use %c when it is passed as
2884 argument to `error'.
2885
4ffd0d6b 28862011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
2887
2888 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2889
2890 * w32.c: Include <time.h>.
2891 (sys_localtime): New function.
2892
4ffd0d6b 28932011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
2894
2895 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2896
4ffd0d6b 2897 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 2898
4ffd0d6b 28992011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 2900
4ffd0d6b
GM
2901 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2902 zombies (Bug#8467).
aac0c6e3 2903
04c56954
EZ
29042011-04-19 Eli Zaretskii <eliz@gnu.org>
2905
2906 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2907 gl_state.e_property when gl_state.object is Qt.
2908
2909 * insdel.c (make_gap_larger): Remove limitation of buffer size
2910 to <= INT_MAX.
2911
16a43933
CY
29122011-04-18 Chong Yidong <cyd@stupidchicken.com>
2913
2914 * xdisp.c (lookup_glyphless_char_display)
2915 (produce_glyphless_glyph): Handle cons cell entry in
2916 glyphless-char-display.
2917 (Vglyphless_char_display): Document it.
2918
2919 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2920 glyphless-char-display.
2921
4581706e
CY
29222011-04-17 Chong Yidong <cyd@stupidchicken.com>
2923
2924 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2925
2926 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2927
2928 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2929 definition for no-X builds.
2930
4887c6e2 29312011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 2932
fd35b6f9
PE
2933 Static checks with GCC 4.6.0 and non-default toolkits.
2934
5c1ccb01
PE
2935 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2936
006c5daa
PE
2937 * process.c (keyboard_bit_set): Define only if SIGIO.
2938 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2939 (send_process): Repair possible setjmp clobbering.
2940
efc736d3
PE
2941 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2942
4e2fe2e6
PE
2943 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2944
f97334a2
PE
2945 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2946
4e75f29d
PE
2947 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2948 Define only if needed.
2949
90efadd1
PE
2950 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2951 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 2952 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 2953
3c647824
PE
2954 * dispextern.h (struct redisplay_interface): Rename param
2955 to avoid shadowing.
e264f262 2956 * termhooks.h (struct terminal): Likewise.
761383f4 2957 * xterm.c (xembed_send_message): Likewise.
3c647824 2958
b58c5c4a
PE
2959 * insdel.c (make_gap_smaller): Define only if
2960 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2961
cad59032
PE
2962 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2963 it.
2964
c339dc2e
PE
2965 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2966 so that we aren't warned about unused symbols.
2967
91a3e27b
PE
2968 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2969
399c71d3 2970 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 2971
8ffc96f5
PE
2972 * xfns.c (x_real_positions): Mark locals as initialized.
2973
eef9bc79
PE
2974 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2975
098db9dd
PE
2976 * xterm.c: Fix problems found by static analysis with other toolkits.
2977 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
2978 (x_dispatch_event): Declare static if USE_GTK, and
2979 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 2980 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 2981 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
2982 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2983 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 2984
eb18f6cc
PE
2985 * xmenu.c (menu_help_callback): Pointer type fixes.
2986 Use const pointers when pointing at readonly data. Avoid pointer
2987 signedness clashes.
2988 (FALSE): Remove unused macro.
2989 (update_frame_menubar): Remove unused decl.
2990
1fe72bf8
PE
2991 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2992
60d9e1db
PE
2993 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2994 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2995 (single_menu_item): Rename local to avoid shadowing.
2996
39261c26
PE
2997 * keyboard.c (make_lispy_event): Remove unused local var.
2998
018c5e19
PE
2999 * frame.c, frame.h (x_get_resource_string): Bring this back, but
3000 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
3001
63d2b86e
PE
3002 * bitmaps: Change bitmaps from unsigned char back to the X11
3003 compatible char. Avoid the old compiler warnings about
3004 out-of-range initializers by using, for example, '\xab' rather
3005 than 0xab.
3006
aefd87e1
PE
3007 * xgselect.c (xgselect_initialize): Check vs interface
3008 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
3009
bf501fb9
PE
3010 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
3011
e9829fdf
PE
3012 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
3013 to read-only memory.
3014
1086c095
PE
3015 * fns.c (vector): Remove; this old hack is no longer needed.
3016
2baccd04 3017 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 3018 Remove unused var.
dde42981 3019 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 3020
72391843 3021 * xrdb.c (x_load_resources): Omit unused local.
3565b346 3022
436c16df 3023 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 3024 (x_window): Rename locals to avoid shadowing.
dc5ddd85 3025 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 3026
92bb796d 3027 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 3028 (x_term_init): Remove local to avoid shadowing.
92bb796d 3029
764430a3 3030 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
3031
3032 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
3033 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
3034
d1dfb56c
EZ
30352011-04-16 Eli Zaretskii <eliz@gnu.org>
3036
c4354cb4
EZ
3037 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
3038
d1dfb56c
EZ
3039 Fix regex.c, syntax.c and friends for buffers > 2GB.
3040 * syntax.h (struct gl_state_s): Declare character position members
3041 EMACS_INT.
3042
3043 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
3044
04f2d78b
CB
3045 * textprop.c (verify_interval_modification, interval_of):
3046 Declare arguments EMACS_INT.
d1dfb56c
EZ
3047
3048 * intervals.c (adjust_intervals_for_insertion): Declare arguments
3049 EMACS_INT.
3050
3051 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
3052
3053 * indent.c (Fvertical_motion): Local variable it_start is now
3054 EMACS_INT.
3055
3056 * regex.c (re_match, re_match_2, re_match_2_internal)
3057 (bcmp_translate, regcomp, regexec, print_double_string)
3058 (group_in_compile_stack, re_search, re_search_2, regex_compile)
3059 (re_compile_pattern, re_exec): Declare arguments and local
3060 variables `size_t' and `ssize_t' and return values `regoff_t', as
3061 appropriate.
3062 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
3063 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
3064 <compile_stack_type>: `size' and `avail' are now `size_t'.
3065
3066 * regex.h <regoff_t>: Use ssize_t, not int.
3067 (re_search, re_search_2, re_match, re_match_2): Arguments that
3068 specify buffer/string position and length are now ssize_t and
3069 size_t. Return type is regoff_t.
3070
613052cd
BK
30712011-04-16 Ben Key <bkey76@gmail.com>
3072
3073 * nsfont.m: Fixed bugs in ns_get_family and
3074 ns_descriptor_to_entity that were caused by using free to
3075 deallocate memory blocks that were allocated by xmalloc (via
3076 xstrdup). This caused Emacs to crash when compiled with
3077 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
3078 --enable-checking=xmallocoverrun). xfree is now used to
3079 deallocate these memory blocks.
3080
4170f62f 30812011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 3082
71b41406
PE
3083 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
3084
9587a89d
PE
3085 emacs_write: Accept and return EMACS_INT for sizes.
3086 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
3087 et seq.
3088 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
3089 Accept and return EMACS_INT.
3090 (emacs_gnutls_write): Return the number of bytes written on
3091 partial writes.
3092 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
3093 (emacs_read, emacs_write): Remove check for negative size, as the
3094 Emacs source code has been audited now.
9587a89d
PE
3095 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
3096 (emacs_read, emacs_write): Use it.
273a5f82
PE
3097 * process.c (send_process): Adjust to the new signatures of
3098 emacs_write and emacs_gnutls_write. Do not attempt to store
3099 a byte offset into an 'int'; it might overflow.
9587a89d 3100 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 3101
3e047f51
PE
3102 * sound.c: Don't assume sizes fit in 'int'.
3103 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 3104 Return EMACS_INT, not int.
3e047f51 3105 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
3106 Accept EMACS_INT, not int.
3107 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
3108 record read return values.
3109
cc39a9db
BK
31102011-04-15 Ben Key <bkey76@gmail.com>
3111
c9d0ec6d
JB
3112 * keyboard.c (Qundefined): Don't declare static since it is used
3113 in nsfns.m.
3114 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
3115 static since they are used in nsfont.m.
cc39a9db 3116
6c60eb9f
SM
31172011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
3118
3119 * process.c (Qprocessp): Don't declare static.
3120 * lisp.h (Qprocessp): Declare again.
3121
7990b61a
JB
31222011-04-15 Juanma Barranquero <lekktu@gmail.com>
3123
3124 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
3125
5d4cb038
PE
31262011-04-14 Paul Eggert <eggert@cs.ucla.edu>
3127
8bd7b830 3128 Improve C-level modularity by making more things 'static'.
cd64ea1d 3129
e3b27b31
PE
3130 Don't publish debugger-only interfaces to other modules.
3131 * lisp.h (safe_debug_print, debug_output_compilation_hack):
3132 (verify_bytepos, count_markers): Move decls to the only modules
3133 that need them.
3134 * region-cache.h (pp_cache): Likewise.
3135 * window.h (check_all_windows): Likewise.
3136 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
3137
5d4cb038
PE
3138 * sysdep.c (croak): Now static, if
3139 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
3140 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
3141
3142 * alloc.c (refill_memory_reserve): Now static if
3143 !defined REL_ALLOC || defined SYSTEM_MALLOC.
3144 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 3145
e87b6180
PE
3146 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
3147 Define only if USE_LUCID.
3148
ac64929e
PE
3149 * xrdb.c (x_customization_string, x_rm_string): Now static.
3150
6f37259d
PE
3151 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
3152 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
3153
1683e3ab
PE
3154 * xdisp.c (draw_row_with_mouse_face): Now static.
3155 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
3156
de9c2632
PE
3157 * window.h (check_all_windows): Mark externally visible.
3158
2b96acb7
PE
3159 * window.c (window_deletion_count): Now static.
3160
3161 * undo.c: Make symbols static if they're not exported.
3162 (last_undo_buffer, last_boundary_position, pending_boundary):
3163 Now static.
3164
50436f33
PE
3165 * textprop.c (interval_insert_behind_hooks): Now static.
3166 (interval_insert_in_front_hooks): Likewise.
3167
64520e5c
PE
3168 * term.c: Make symbols static if they're not exported.
3169 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
3170 (max_frame_lines, tty_set_terminal_modes):
3171 (tty_reset_terminal_modes, tty_turn_off_highlight):
3172 (get_tty_terminal): Now static.
3173 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
3174 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 3175 HAVE_WINDOW_SYSTEM.
64520e5c
PE
3176 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
3177 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
3178
1fa53021
PE
3179 * sysdep.c: Make symbols static if they're not exported.
3180 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
3181 Now static.
3182 (sigprocmask_set, full_mask): Remove; unused.
3183 (wait_debugging): Mark as visible.
3184 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
3185 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
3186
d4b43b22
PE
3187 * syntax.c (syntax_temp): Define only if !__GNUC__.
3188
b7c513d0
PE
3189 * sound.c (current_sound_device, current_sound): Now static.
3190
989b29ad
PE
3191 * search.c (searchbufs, searchbuf_head): Now static.
3192
13a55a78
PE
3193 * scroll.c (scroll_cost): Remove; unused.
3194 * dispextern.h (scroll_cost): Remove decl.
3195
de68a1fc
PE
3196 * region-cache.h (pp_cache): Mark as externally visible.
3197
40ccffa6
PE
3198 * process.c: Make symbols static if they're not exported.
3199 (process_tick, update_tick, create_process, chan_process):
3200 (Vprocess_alist, proc_buffered_char, datagram_access):
3201 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3202 (deactivate_process): Mark defn as static, as well as decl.
3203 * lisp.h (create_process): Remove decl.
3204 * process.h (chan_process, Vprocess_alist): Remove decls.
3205
ad64fc97
PE
3206 * print.c: Make symbols static if they're not exported.
3207 (print_depth, new_backquote_output, being_printed, print_buffer):
3208 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3209 (print_interval, print_number_index, initial_stderr_stream):
3210 Now static.
3211 * lisp.h (Fprinc): Remove decl.
3212 (debug_output_compilation_hack): Mark as externally visible.
3213
adddb265
PE
3214 * sysdep.c (croak): Move decl from here to syssignal.h.
3215 * syssignal.h (croak): Put it here, so the API can be checked when
3216 'croak' is called from dissociate_if_controlling_tty.
3217
1717ede2
PE
3218 * minibuf.c: Make symbols static if they're not exported.
3219 (minibuf_save_list, choose_minibuf_frame): Now static.
3220 * lisp.h (choose_minibuf_frame): Remove decl.
3221
fa5fb2bc
PE
3222 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3223
1e3890d1
PE
3224 * lread.c: Make symbols static if they're not exported.
3225 (read_objects, initial_obarray, oblookup_last_bucket_number):
3226 Now static.
3227 (make_symbol): Remove; unused.
3228 * lisp.h (initial_obarray, make_symbol): Remove decls.
3229
8a1414fa
PE
3230 * keyboard.c: Make symbols static if they're not exported.
3231 (single_kboard, recent_keys_index, total_keys, recent_keys):
3232 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3233 (this_single_command_key_start, echoing, last_auto_save):
3234 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3235 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3236 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3237 (Vlispy_mouse_stem, double_click_count):
3238 Now static.
3239 (force_auto_save_soon): Define only if SIGDANGER.
3240 (ignore_mouse_drag_p): Now static if
3241 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3242 (print_help): Remove; unused.
3243 (stop_character, last_timer_event): Mark as externally visible.
3244 * keyboard.h (ignore_mouse_drag_p): Declare only if
3245 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
3246 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
3247 * lisp.h (echoing): Remove decl.
3248 (force_auto_save_soon): Declare only if SIGDANGER.
3249 * xdisp.c (redisplay_window): Simplify code, to make it more
3250 obvious that ignore_mouse_drag_p is not accessed if !defined
3251 USE_GTK && !defined HAVE_NS.
3252
93ea6e8f
PE
3253 * intervals.c: Make symbols static if they're not exported.
3254 (merge_properties_sticky, merge_interval_right, delete_interval):
3255 Now static.
3256 * intervals.h (merge_interval_right, delete_interval): Remove decls.
3257
77382fcc
PE
3258 * insdel.c: Make symbols static if they're not exported.
3259 However, leave prepare_to_modify_buffer alone. It's never
3260 called from outside this function, but that appears to be a bug.
3261 (combine_after_change_list, combine_after_change_buffer):
4889fc82 3262 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
3263 (adjust_after_replace_noundo): Remove; unused.
3264 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 3265 (signal_before_change): Remove decls.
77382fcc 3266
9306c32e
PE
3267 * indent.c (val_compute_motion, val_vmotion): Now static.
3268
cd44d2eb
PE
3269 * image.c: Make symbols static if they're not exported.
3270 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
3271 if USE_GTK.
3272 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
3273 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
3274
ad9a7a06
PE
3275 * fringe.c (standard_bitmaps): Now static.
3276 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
3277
81626931
PE
3278 * frame.c: Make symbols static if they're not exported.
3279 (x_report_frame_params, make_terminal_frame): Now static.
3280 (get_frame_param): Now static, unless HAVE_NS.
3281 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
3282 (x_get_resource_string): Remove; not used.
3283 * frame.h (make_terminal_frame, x_report_frame_params):
3284 (x_get_resource_string); Remove decls.
3285 (x_fullscreen_adjust): Declare only if WINDOWSNT.
3286 * lisp.h (get_frame_param): Declare only if HAVE_NS.
3287
239f9db9
PE
3288 * font.c, fontset.c: Make symbols static if they're not exported.
3289 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
3290 (FACE_SUITABLE_FOR_CHAR_P): Use it.
3291 * font.c (font_close_object): Now static.
3292 * font.h (font_close_object): Remove.
3293 * fontset.c (FONTSET_OBJLIST): Remove.
3294 (free_realized_fontset) #if-0 the body, which does nothing.
3295 (face_suitable_for_char_p): #if-0, as it's never called.
3296 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
3297 * xfaces.c (face_at_string_position):
3298 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
3299 since 0 is always ASCII.
3300
dfcf3579
PE
3301 * fns.c (weak_hash_tables): Now static.
3302
5045092b
PE
3303 * fileio.c: Make symbols static if they're not exported.
3304 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
3305 (Vwrite_region_annotation_buffers): Now static.
3306
57a96f5c
PE
3307 * eval.c: Make symbols static if they're not exported.
3308 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
3309 * lisp.h (backtrace_list): Remove decl.
3310
35f08c38
PE
3311 * emacs.c: Make symbols static if they're not exported.
3312 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
3313 (fatal_error_code, fatal_error_signal_hook, standard_args):
3314 Now static.
3315 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
3316 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
3317 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
3318 * lisp.h (fatal_error_signal_hook): Remove decl.
3319 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
3320
f44bd759
PE
3321 * editfns.c: Move a (normally-unused) function to its only use.
3322 * editfns.c, lisp.h (get_operating_system_release): Remove.
3323 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
3324 worth the hassle of breaking this out.
3325
b532497d
PE
3326 * xterm.c: Make symbols static if they're not exported.
3327 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
3328 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
3329 (x_destroy_window, x_delete_display):
3330 Now static.
3331 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
3332 (x_mouse_leave): Remove; unused.
3333 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
3334 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
3335 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
3336 Remove decls.
3337 (x_mouse_leave): Declare only if WINDOWSNT.
3338 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
3339 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
3340 USE_X_TOOLKIT.
3341
1675728f
PE
3342 * ftxfont.c: Make symbols static if they're not exported.
3343 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
3344 HAVE_FREETYPE.
3345 * font.h (ftxfont_driver): Likewise.
3346
e4cebfca
PE
3347 * xfns.c: Make symbols static if they're not exported.
3348 (x_last_font_name, x_display_info_for_name):
3349 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
3350 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
3351 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
3352 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
3353 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
3354 (last_show_tip_args): Now static.
3355 (xic_defaut_fontset, xic_create_fontsetname): Define only if
3356 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
3357 (x_screen_planes): Remove; unused.
3358 * dispextern.h (x_screen_planes): Remove decl.
3359
5bf46f05
PE
3360 * dispnew.c: Make symbols static if they're not exported.
3361 * dispextern.h (redraw_garbaged_frames, scrolling):
3362 (increment_row_positions): Remove.
3363 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
3364 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
3365 Now static.
3366 (redraw_garbaged_frames): Remove; unused.
3367
435f4c28
PE
3368 * xfaces.c: Make symbols static if they're not exported.
3369 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
3370 Remove decls.
3371 * xterm.h (defined_color): Remove decls.
3372 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
3373 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
3374 (menu_face_changed_default, defined_color, free_realized_face):
3375 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
3376 (ascii_face_of_lisp_face): Remove; unused.
3377
8524aef3
PE
3378 * xdisp.c: Make symbols static if they're not exported.
3379 * dispextern.h (scratch_glyph_row, window_box_edges):
3380 (glyph_to_pixel_coords, set_cursor_from_row):
3381 (get_next_display_element, set_iterator_to_next):
3382 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
3383 (show_mouse_face): Remove decls
3384 * frame.h (message_buf_print): Likewise.
3385 * lisp.h (pop_message, set_message, check_point_in_composition):
3386 Likewise.
3387 * xterm.h (set_vertical_scroll_bar): Likewise.
3388 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
3389 (message_buf_print, scratch_glyph_row, displayed_buffer):
3390 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
3391 (get_next_display_element, show_mouse_face, window_box_edges):
3392 (frame_to_window_pixel_xy, check_point_in_composition):
3393 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
3394 (glyph_to_pixel_coords): Remove; unused.
3395
16390cd2
PE
3396 * dired.c (file_name_completion): Now static.
3397
3398 * dbusbind.c (xd_in_read_queued_messages): Now static.
3399
a25f4dfa
PE
3400 * lisp.h (circular_list_error, FOREACH): Remove; unused.
3401 * data.c (circular_list_error): Remove.
3402
14a9c8df
PE
3403 * commands.h (last_point_position, last_point_position_buffer):
3404 (last_point_position_window): Remove decls.
3405 * keyboard.c: Make these variables static.
3406
04f2d78b
CB
3407 * coding.h (coding, code_convert_region, encode_coding_gap):
3408 Remove decls.
74ab6df5
PE
3409 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
3410 (iso_code_class, detect_coding, code_convert_region): Now static.
3411 (encode_coding_gap): Remove; unused.
3412
38dfbee1
PE
3413 * chartab.c (chartab_chars, chartab_bits): Now static.
3414
a2cb4e63
PE
3415 * charset.h (charset_iso_8859_1): Remove decl.
3416 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
3417 Now static.
3418
127198fd
PE
3419 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
3420 * ccl.c (Vccl_program_table): Now static.
3421 (check_ccl_update): Remove; unused.
3422
d85b608f
PE
3423 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
3424 * category.h: ... from here.
3425 * category.c (check_category_table, set_category_set): Now static.
3426
31cd66f3
PE
3427 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
3428 * lisp.h: Remove these decls.
3429
c358e587
PE
3430 * buffer.c (buffer_count): Remove unused var.
3431
e78aecca
PE
3432 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
3433 so that it's not optimized away.
3434 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
3435 * dispextern.h (bidi_dump_cached_states): Remove, since it's
3436 exported only to the debugger.
3437
e192d7d3 3438 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 3439 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 3440
92470028
PE
3441 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
3442 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
3443 was inaccessible from Lisp.
3444 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
3445 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
3446
244ed907
PE
3447 alloc.c: Import and export fewer symbols, and remove unused items.
3448 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
3449 is defined.
3450 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
3451 it's not optimized away by whole-program optimization.
3452 (message_enable_multibyte, free_misc): Remove.
3453 (catchlist, handlerlist, mark_backtrace):
3454 Declare only if BYTE_MARK_STACK.
3455 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
3456 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
3457 (message_enable_multibyte): Remove decl.
3458 (free_misc, interval_free_list, float_block, float_block_index):
3459 (n_float_blocks, float_free_list, cons_block, cons_block_index):
3460 (cons_free_list, last_marked_index):
3461 Now static.
3462 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
3463 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
3464 (mark_backtrace): Define only if BYTE_MARK_STACK.
3465 * xdisp.c (message_enable_multibyte): Now static.
3466
61c2b50e 3467 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
3468 This makes it easier for human readers (and static analyzers)
3469 to see whether these variables are used from other modules.
3470 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
3471 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
3472 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
3473 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
3474 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
3475 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
3476 * xmenu.c, xselect.c:
3477 Declare Q* vars static if they are not used in other modules.
3478 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
3479 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
3480 Remove decls of unexported vars.
3481 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
3482
95c82688
PE
3483 * lisp.h (DEFINE_FUNC): Make sname 'static'.
3484
16a97296
PE
3485 Make Emacs functions such as Fatom 'static' by default.
3486 This makes it easier for human readers (and static analyzers)
3487 to see whether these functions can be called from other modules.
3488 DEFUN now defines a static function. To make the function external
3489 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
3490 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
3491 (Finit_image_library):
16a97296
PE
3492 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
3493 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
3494 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
3495 Remove decls, since these functions are now static.
3496 (Funintern, Fget_internal_run_time): New decls, since these functions
3497 were already external.
95c82688 3498
16a97296
PE
3499 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
3500 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
3501 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
3502 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
3503 * keyboard.c, keymap.c, lread.c:
3504 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
3505 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
3506 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
3507 Mark functions with DEFUE instead of DEFUN,
3508 if they are used in other modules.
3509 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
3510 decls for now-static functions.
3511 * buffer.h (Fdelete_overlay): Remove decl.
3512 * callproc.c (Fgetenv_internal): Mark as internal.
3513 * composite.c (Fremove_list_of_text_properties): Remove decl.
3514 (Fcomposition_get_gstring): New forward static decl.
3515 * composite.h (Fcomposite_get_gstring): Remove decl.
3516 * dired.c (Ffile_attributes): New forward static decl.
3517 * doc.c (Fdocumntation_property): New forward static decl.
3518 * eval.c (Ffetch_bytecode): New forward static decl.
3519 (Funintern): Remove extern decl; now in .h file where it belongs.
3520 * fileio.c (Fmake_symbolic_link): New forward static decl.
3521 * image.c (Finit_image_library): New forward static decl.
3522 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3523 * intervals.h (Fprevious_property_change):
3524 (Fremove_list_of_text_properties): Remove decls.
3525 * keyboard.c (Fthis_command_keys): Remove decl.
3526 (Fcommand_execute): New forward static decl.
3527 * keymap.c (Flookup_key): New forward static decl.
3528 (Fcopy_keymap): Now static.
3529 * keymap.h (Flookup_key): Remove decl.
3530 * process.c (Fget_process): New forward static decl.
3531 (Fprocess_datagram_address): Mark as internal.
3532 * syntax.c (Fsyntax_table_p): New forward static decl.
3533 (skip_chars): Remove duplicate decl.
3534 * textprop.c (Fprevious_property_change): New forward static decl.
3535 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3536 Now internal.
3537 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3538 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3539
785bbd42
PE
3540 * editfns.c (Fformat): Remove unreachable code.
3541
8b913b57
AS
35422011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3543
3544 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3545 change. (Bug#8496)
3546
a6744a35
EZ
35472011-04-13 Eli Zaretskii <eliz@gnu.org>
3548
3549 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3550 when at ZV. (Bug#8487)
3551
e7974947
AS
35522011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3553
baad03f0
AS
3554 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3555 (Bug#8437)
3556 * keyboard.c (parse_tool_bar_item): Likewise.
3557 * sound.c (sound_cleanup, alsa_close): Likewise.
3558 * termcap.c (tgetent): Likewise.
3559 * xfns.c (x_default_font_parameter): Likewise.
3560 * xsettings.c (read_and_apply_settings): Likewise.
3561
e7974947
AS
3562 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3563 (overrun_check_free): Protoize.
3564
28272684
PE
35652011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3566
3567 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3568 since callers should never pass a negative size.
3569 Change the signature to match that of plain 'read' and 'write'; see
3570 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3571 * lisp.h: Update prototypes of emacs_write and emacs_read.
3572
11997c76
EZ
35732011-04-11 Eli Zaretskii <eliz@gnu.org>
3574
3575 * xdisp.c (redisplay_window): Don't try to determine the character
3576 position of the scroll margin if the window start point w->startp
e896f03c 3577 is outside the buffer's accessible region. (Bug#8468)
11997c76 3578
8a2cbd72
EZ
35792011-04-10 Eli Zaretskii <eliz@gnu.org>
3580
3581 Fix write-region and its subroutines for buffers > 2GB.
3582 * fileio.c (a_write, e_write): Modify declaration of arguments and
3583 local variables to support buffers larger than 2GB.
3584 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3585
3586 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3587 argument, local variables, and return value.
3588
3589 * lisp.h: Update prototypes of emacs_write and emacs_read.
3590
3591 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3592
4073e537 35932011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 3594
1ebfdcb6
PE
3595 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3596
b2ded58d
PE
3597 Fix more problems found by GCC 4.6.0's static checks.
3598
7d66342c
PE
3599 * xdisp.c (vmessage): Use a better test for character truncation.
3600
bbf47d44
PE
3601 * charset.c (load_charset_map): <, not <=, for optimization,
3602 and to avoid potential problems with integer overflow.
9248994d 3603 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 3604 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 3605 * editfns.c (Fformat): Likewise.
1e69125e 3606 * syntax.c (skip_chars): Likewise.
3befa583 3607
e3019616
PE
3608 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3609 This also lets GCC 4.6.0 generate slightly better loop code.
3610
becfa255
PE
3611 * callint.c (Fcall_interactively): <, not <=, for optimization.
3612 (Fcall_interactively): Count the number of arguments produced,
3613 not the number of arguments given. This is simpler and lets GCC
3614 4.6.0 generate slightly better code.
3615
dae0cd48
PE
3616 * ftfont.c: Distingish more carefully between FcChar8 and char.
3617 The previous code passed unsigned char * to a functions like
3618 strlen and xstrcasecmp that expect char *, which does not
3619 conform to the C standard.
3620 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3621 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3622 char * when the C standard requires it.
3623
76032d70
PE
3624 * keyboard.c (read_char): Remove unused var.
3625
eb3f1cc8
PE
3626 * eval.c: Port to Windows vsnprintf (Bug#8435).
3627 Include <limits.h>.
3628 (SIZE_MAX): Define if the headers do not.
3629 (verror): Do not give up if vsnprintf returns a negative count.
3630 Instead, grow the buffer. This ports to Windows vsnprintf, which
3631 does not conform to C99. Problem reported by Eli Zaretskii.
3632 Also, simplify the allocation scheme, by avoiding the need for
3633 calling realloc, and removing the ALLOCATED variable.
3634
70476b54
PE
3635 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3636
12020a9e
PE
3637 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3638 But keep the doprint source code for now, as we might revamp it
3639 and use it again (Bug#8435).
ea6c7ae6
PE
3640 * lisp.h (doprnt): Remove.
3641 * Makefile.in (base_obj): Remove doprnt.o.
3642 * deps.mk (doprnt.o): Remove.
3643
5fdb398c
PE
3644 error: Print 32- and 64-bit integers portably (Bug#8435).
3645 Without this change, on typical 64-bit hosts error ("...%d...", N)
3646 was used to print both 32- and 64-bit integers N, which relied on
3647 undefined behavior.
3648 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3649 New macro.
3650 * lisp.h (error, verror): Mark as printf-like functions.
3651 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3652 Report overflow in size calculations when allocating printf buffer.
3653 Do not truncate output string at its first null byte.
3654 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3655 Truncate the output at a character boundary, since vsnprintf does not
3656 do that.
3657 * charset.c (check_iso_charset_parameter): Convert internal
3658 character to string before calling 'error', since %c now has the
3659 printf meaning.
3660 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3661 overflow when computing char to be passed to 'error'. Do not
3662 pass Lisp_Object to 'error'; pass the integer instead.
3663 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3664 formatted with plain %d.
3665
b189fa66
PE
3666 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3667
bff87ef0
PE
3668 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3669
7e2cac20
PE
3670 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3671
ce4d90b5
PE
3672 * xterm.c (x_catch_errors): Remove duplicate declaration.
3673
266c9547
PE
3674 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3675
79c49ad2
PE
3676 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3677
368f4090
JM
36782011-04-10 Jim Meyering <meyering@redhat.com>
3679
3680 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3681 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3682 return ssize_t not "int", and use size_t as the buffer length.
3683 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3684 * gnutls.h: Update declarations.
3685 * process.c (read_process_output): Use ssize_t, to match.
3686 (send_process): Likewise.
3687
a32d4040
CY
36882011-04-09 Chong Yidong <cyd@stupidchicken.com>
3689
3690 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3691
8546720e 36922011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 3693
04f2d78b
CB
3694 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3695 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 3696
8546720e
GM
3697 * xterm.c (handle_one_xevent):
3698 * xmenu.c (create_and_show_popup_menu):
3699 * xselect.c (x_decline_selection_request)
3700 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 3701
0a2f5c1a 37022011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
3703
3704 Fix some uses of `int' instead of EMACS_INT.
3705 * search.c (string_match_1, fast_string_match)
3706 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3707 (scan_buffer, find_next_newline_no_quit)
3708 (find_before_next_newline, search_command, Freplace_match)
3709 (Fmatch_data): Make some `int' variables be EMACS_INT.
3710
3711 * xdisp.c (display_count_lines): 3rd argument and return value now
3712 EMACS_INT. All callers changed.
3713 (pint2hrstr): Last argument is now EMACS_INT.
3714
3715 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3716 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3717 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3718 (decode_coding_utf_16, decode_coding_emacs_mule)
3719 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3720 (decode_coding_ccl, decode_coding_charset)
3721 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3722 (decode_coding_iso_2022, decode_coding_emacs_mule)
3723 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3724 <char_offset, last_offset>: Declare EMACS_INT.
3725 (encode_coding_utf_8, encode_coding_utf_16)
3726 (encode_coding_emacs_mule, encode_invocation_designation)
3727 (encode_designation_at_bol, encode_coding_iso_2022)
3728 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3729 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3730 Declare EMACS_INT.
3731 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3732 (encode_invocation_designation): Last argument P_NCHARS is now
3733 EMACS_INT.
3734 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3735 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3736
3737 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3738 All users changed.
3739
3740 * ccl.c (Fccl_execute_on_string): Declare some variables
3741 EMACS_INT.
3742
8546720e 37432011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
3744
3745 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3746
4e19a977
CS
37472011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3748
3749 * process.c (Fformat_network_address): Doc fix.
3750
87302331
R
37512011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3752
3753 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3754
cbb59342
CY
37552011-04-08 Chong Yidong <cyd@stupidchicken.com>
3756
3757 * keyboard.c (read_char): Call Lisp function help-form-show,
3758 instead of using internal_with_output_to_temp_buffer.
3759 (Qhelp_form_show): New var.
e0d38eeb 3760 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
3761
3762 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3763
3764 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3765
e67a13ab
CY
37662011-04-06 Chong Yidong <cyd@stupidchicken.com>
3767
04f2d78b
CB
3768 * process.c (Flist_processes): Remove to Lisp.
3769 (list_processes_1): Delete.
e67a13ab 3770
973f782d
EZ
37712011-04-06 Eli Zaretskii <eliz@gnu.org>
3772
7c106b1e
EZ
3773 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3774
973f782d
EZ
3775 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3776
41cf7d1a 37772011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 3778
ca23cc88
PE
3779 Fix more problems found by GCC 4.6.0's static checks.
3780
f390e2d5
PE
3781 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3782
42eea0d0
PE
3783 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3784
b69769da 3785 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 3786
f9541e84
PE
3787 * xdisp.c (vmessage): Mark as a printf-like function.
3788
13841b55
PE
3789 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3790
c136c10f
PE
3791 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3792
5e2d4a30
PE
3793 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3794 printf-like functions.
3795 (tiff_load): Add casts to remove these marks before passing them
3796 to system-supplied API.
3797
583f48b9
PE
3798 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3799
b25d760e
PE
3800 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3801 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
3802 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3803 directly, rather than having caller test rule sign. This avoids
3804 some unnecessary tests.
3805 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3806 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3807 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 3808
bc7b6697 3809 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 3810 (xfont_open): Avoid unnecessary tests.
bc7b6697 3811
27ccc379
PE
3812 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3813
dcd5c89a
PE
3814 * composite.h, composite.c (composition_gstring_put_cache):
3815 Use EMACS_INT, not int, for length.
3816
b13a45c6
PE
3817 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3818 breaking out part of COMPOSITION_DECODE_RULE.
3819 (COMPOSITION_DECODE_RULE): Use it.
3820 * composite.c (get_composition_id): Remove unused local vars,
3821 by using the new macro.
3822
1e792e4d
PE
3823 * textprop.c (set_text_properties_1): Change while to do-while,
3824 since the condition is always true at first.
3825
dc6c6455 3826 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
3827 (interval_deletion_adjustment): Return unsigned value.
3828 All uses changed.
dc6c6455 3829
aba7731a
PE
3830 * process.c (list_processes_1, create_pty, read_process_output):
3831 (exec_sentinel): Remove vars that were set but not used.
afd4052b 3832 (create_pty): Remove unnecessary "volatile"s.
bc57d757 3833 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 3834 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 3835 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 3836
fdfc4bf3
PE
3837 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3838
fca8fe46 3839 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 3840 (update_syntax_table): Use unsigned instead of int.
fca8fe46 3841
06a0259a 3842 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 3843 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 3844 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 3845
e7b9e80f
PE
3846 * print.c (print_error_message): Avoid int overflow.
3847
56201685
PE
3848 * font.c (font_list_entities): Redo for clarity,
3849 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3850
78834453 3851 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 3852 (font_score): Avoid potential overflow in diff calculation.
78834453 3853
0bc0b309 3854 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 3855 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 3856
e610eaca
PE
3857 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3858
b895abce
PE
3859 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3860 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3861 can always succeed if overflow has undefined behavior.
3862
1f1d9321 3863 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 3864 (wordify): Omit three unnecessary tests.
1f1d9321 3865
c59478bc
PE
3866 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3867 All callers changed. This avoids the need for an unused var.
3868
79b73827
PE
3869 * casefiddle.c (casify_region): Remove var that is set but not used.
3870
a4db5dfe
PE
3871 * dired.c (file_name_completion): Remove var that is set but not used.
3872
43aae36e
PE
3873 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3874
2a47c44d 3875 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 3876 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 3877
a37c69bf
PE
3878 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3879 Check for integer overflow on size calculations.
3880
328ab8e7
PE
3881 * buffer.c (Fprevious_overlay_change): Remove var that is set
3882 but not used.
3883
e5a2a5cb
PE
3884 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3885 Remove vars that are set but not used.
8d84a6eb 3886 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 3887 (timer_check_2): Mark vars as initialized.
e5a2a5cb 3888
a60e5f68
PE
3889 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3890
f661cb61 3891 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 3892 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 3893
f0397f5a
PE
3894 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3895 that are set but not used.
3896
8664db06 3897 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 3898 if XCreateBitmapFromData fails (Bug#8410).
8664db06 3899
6abdaa4a
PE
3900 * xselect.c (x_get_local_selection, x_handle_property_notify):
3901 Remove vars that are set but not used.
3902
0ce7538d 3903 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 3904 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 3905
9ae848fc
PE
3906 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3907 Remove var that is set but not used.
0b918413
PE
3908 (scroll_bar_windows_size): Now size_t, not int.
3909 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3910 Check for overflow.
9ae848fc 3911
a5a62657
PE
3912 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3913 (map_tty_color) [!defined MSDOS]: Likewise.
3914
5c5cdd39
PE
3915 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3916
66ebf983
PE
3917 * coding.c: Remove vars that are set but not used.
3918 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3919 All callers changed.
3920 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3921 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3922 (decode_coding_charset): Remove vars that are set but not used.
3923
1be4d761
PE
3924 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3925 that is set but not used.
3926
47553fa8
PE
3927 * print.c (print_object): Remove var that is set but not used.
3928
1f7196bf 3929 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
3930 The gnulib version avoids calling malloc in the usual case,
3931 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3932 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3933 * filelock.c (current_lock_owner): Likewise.
3934 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3935 * sysdep.c: Include allocator.h, careadlinkat.h.
3936 (emacs_no_realloc_allocator): New static constant.
3937 (emacs_readlink): New function.
fdb61804
PE
3938 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3939 ../lib/careadlinkat.h.
d1fdcab7 3940
f84c17c7
SM
39412011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3942
3943 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3944 first non-nil return value).
3945
ef3862ad
JD
39462011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3947
3948 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3949 if not defined (Bug#8403).
3950
376a7006
JB
39512011-04-02 Juanma Barranquero <lekktu@gmail.com>
3952
3953 * xdisp.c (display_count_lines): Remove parameter `start',
3954 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3955 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3956 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3957 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3958 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3959 and thereabouts. All callers changed.
3960 (get_per_char_metric): Remove parameter `f', unused since
3961 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3962
6ca3801d
JM
39632011-04-02 Jim Meyering <meyering@redhat.com>
3964
3965 do not dereference NULL upon failed strdup
3966 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3967 (ns_get_family): Likewise.
3968
d8e2b5ba
JB
39692011-04-02 Juanma Barranquero <lekktu@gmail.com>
3970
3971 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3972
8c74fcbd
JD
39732011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3974
3975 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3976 later (Bug#8403).
3977
7200d79c
SM
39782011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3979
03408648 3980 Add lexical binding.
7200d79c 3981
03408648
SM
3982 * window.c (Ftemp_output_buffer_show): New fun.
3983 (Fsave_window_excursion):
3984 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3985
3986 * lread.c (lisp_file_lexically_bound_p): New function.
3987 (Fload): Bind Qlexical_binding.
3988 (readevalloop): Remove `evalfun' arg.
3989 Bind Qinternal_interpreter_environment.
3990 (Feval_buffer): Bind Qlexical_binding.
3991 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3992 Mark as dynamic.
3993 (syms_of_lread): Declare `lexical-binding'.
3994
3995 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3996
3997 * keyboard.c (eval_dyn): New fun.
3998 (menu_item_eval_property): Use it.
ca105506
SM
3999
4000 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 4001
03408648
SM
4002 * fns.c (concat, mapcar1): Accept byte-code-functions.
4003
4004 * eval.c (Fsetq): Handle lexical vars.
4005 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
4006 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
4007 (FletX, Flet): Obey lexical binding.
4008 (Fcommandp): Handle closures.
4009 (Feval): New `lexical' arg.
4010 (eval_sub): New function extracted from Feval. Use it almost
4011 everywhere where Feval was used. Look up vars in lexical env.
4012 Handle closures.
4013 (Ffunctionp): Move from subr.el.
4014 (Ffuncall): Handle closures.
4015 (apply_lambda): Remove `eval_flags'.
4016 (funcall_lambda): Handle closures and new byte-code-functions.
4017 (Fspecial_variable_p): New function.
4018 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
4019 but without exporting it to Lisp.
23aba0ea 4020
23aba0ea 4021 * doc.c (Fdocumentation, store_function_docstring):
03408648 4022 * data.c (Finteractive_form): Handle closures.
23aba0ea 4023
03408648
SM
4024 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
4025 interactive spec.
ba83908c 4026
04f2d78b
CB
4027 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
4028 New byte-codes.
03408648
SM
4029 (exec_byte_code): New function extracted from Fbyte_code to handle new
4030 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 4031
03408648 4032 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 4033
03408648 4034 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 4035
e2abce01
JB
40362011-03-31 Juanma Barranquero <lekktu@gmail.com>
4037
4038 * xdisp.c (redisplay_internal): Fix prototype.
4039
63696a73 40402011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 4041
63696a73 4042 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
4043 (try_scrolling): Use it when setting scroll_limit.
4044 Limit scrolling to 100 screen lines.
63696a73
EZ
4045 (redisplay_window): Even when falling back on "recentering",
4046 position point in the window according to scroll-conservatively,
4047 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
4048
4049 (try_scrolling): When point is above the window, allow searching
4050 as far as scroll_max, or one screenful, to compute vertical
4051 distance from PT to the scroll margin position. This prevents
4052 try_scrolling from unnecessarily failing when
4053 scroll-conservatively is set to a value slightly larger than the
4054 window height. Clean up the case of PT below the margin at bottom
4055 of window: scroll_max can no longer be INT_MAX. When aggressive
4056 scrolling is in use, don't let point enter the opposite scroll
4057 margin as result of the scroll.
4058 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
4059 threshold of 100 lines for never-recentering scrolling.
4060
e4cc2dfc
JB
40612011-03-31 Juanma Barranquero <lekktu@gmail.com>
4062
4063 * dispextern.h (move_it_by_lines):
4064 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
4065 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
4066 (message_log_check_duplicate): Remove parameters `prev_bol' and
4067 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4068 (redisplay_internal): Remove parameter `preserve_echo_area',
4069 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
4070
4071 * indent.c (Fvertical_motion):
4072 * window.c (window_scroll_pixel_based, Frecenter):
4073 Don't pass `need_y_p' to `move_it_by_lines'.
4074
1c470562
SM
40752011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
4076
44f230aa
SM
4077 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
4078 steal a few bits to be more compact.
4079 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
4080 Remove unneeded casts.
4081
1c470562
SM
4082 * bytecode.c (Fbyte_code): CAR and CDR can GC.
4083
888adce9
ZK
40842011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
4085
4086 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
4087 binding" message (bug#7967).
4088
f838ed7b
PE
40892011-03-30 Paul Eggert <eggert@cs.ucla.edu>
4090
77861b95
PE
4091 Fix more problems found by GCC 4.6.0's static checks.
4092
de6dbc14
PE
4093 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
4094 Remove unused local var.
4095
f838ed7b
PE
4096 * editfns.c (Fmessage_box): Remove unused local var.
4097
792c7b2b
PE
4098 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
4099 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4100 Omit unused local vars.
c499e557 4101 * window.c (shrink_windows): Omit unused local var.
b01a1c29 4102 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
4103 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
4104 Omit unused local var.
4105
ba0165e1
PE
4106 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
4107 Don't assume string length fits in int.
32ad8845 4108 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 4109 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 4110
3c59b4c9
PE
4111 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
4112 instead of alloca (Bug#8344).
4113
a3eed478 4114 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 4115 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 4116
eb4d412d
PE
4117 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
4118
1658b401
PE
4119 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
4120 concerns.
4121
4122 * term.c (produce_glyphless_glyph): Remove unnecessary test.
4123
4124 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 4125
9a2c6e05
PE
4126 * keyboard.c (syms_of_keyboard): Use the same style as later
4127 in this function when indexing through an array. This also
4128 works around GCC bug 48267.
4129
03d0a109
PE
4130 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
4131
44f730c8
PE
4132 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
4133
fe75f926
PE
4134 * chartab.c (sub_char_table_ref_and_range): Redo for slight
4135 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
4136
ffa8c828
PE
4137 * keyboard.c, keyboard.h (num_input_events): Now size_t.
4138 This avoids undefined behavior on integer overflow, and is a bit
4139 more convenient anyway since it is compared to a size_t variable.
4140
c5101a77
PE
4141 Variadic C functions now count arguments with size_t, not int.
4142 This avoids an unnecessary limitation on 64-bit machines, which
4143 caused (substring ...) to crash on large vectors (Bug#8344).
4144 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
4145 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 4146 All variadic functions and their callers changed accordingly.
c5101a77
PE
4147 (struct gcpro.nvars): Now size_t, not int. All uses changed.
4148 * data.c (arith_driver, float_arith_driver): Likewise.
4149 * editfns.c (general_insert_function): Likewise.
4150 * eval.c (struct backtrace.nargs, interactive_p)
4151 (internal_condition_case_n, run_hook_with_args, apply_lambda)
4152 (funcall_lambda, mark_backtrace): Likewise.
4153 * fns.c (concat): Likewise.
4154 * frame.c (x_set_frame_parameters): Likewise.
4155 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
4156 0 if not found, not -1. All callers changed.
4157
dd3f25f7
PE
4158 * alloc.c (garbage_collect): Don't assume stack size fits in int.
4159 (stack_copy_size): Now size_t, not int.
4160 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
4161
461c2ab9
JB
41622011-03-28 Juanma Barranquero <lekktu@gmail.com>
4163
4164 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
4165 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4166 All callers changed.
4167
4168 * lisp.h (multibyte_char_to_unibyte):
4169 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
4170 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4171 * character.h (CHAR_TO_BYTE8):
4172 * cmds.c (internal_self_insert):
4173 * editfns.c (general_insert_function):
4174 * keymap.c (push_key_description):
4175 * search.c (Freplace_match):
4176 * xdisp.c (message_dolog, set_message_1): All callers changed.
4177
f6d62986
SM
41782011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4179
4180 * keyboard.c (safe_run_hook_funcall): New function.
4181 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
4182 don't set the hook to nil, but remove the offending function instead.
4183 (Qcommand_hook_internal): Remove, unused.
4184 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
4185 Vcommand_hook_internal.
4186
4187 * eval.c (enum run_hooks_condition): Remove.
4188 (funcall_nil, funcall_not): New functions.
4189 (run_hook_with_args): Call each function through a `funcall' argument.
4190 Remove `cond' argument, now redundant.
4191 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
4192 (Frun_hook_with_args_until_failure): Adjust accordingly.
4193 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4194
1db5b1ad
JB
41952011-03-28 Juanma Barranquero <lekktu@gmail.com>
4196
4197 * dispextern.h (string_buffer_position): Remove declaration.
4198
4199 * print.c (strout): Remove parameter `multibyte', unused since
4200 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4201
4202 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4203 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4204 All callers changed.
4205
4206 * w32.c (_wsa_errlist): Use braces for struct initializers.
4207
4208 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4209 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4210 All callers changed.
4211 (string_buffer_position): Likewise. Also, make static (it's never
4212 used outside xdisp.c).
4213 (cursor_row_p): Remove parameter `w', unused since
4214 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4215 (decode_mode_spec): Remove parameter `precision', introduced during
4216 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4217 All callers changed.
4218
5ffb62aa
JD
42192011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4220
4221 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4222
461c2ab9 42232011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
4224
4225 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4226 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4227 (ns_update_auto_hide_menu_bar): New functions.
4228 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4229 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4230 ns_constrain_all_frames.
4231 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4232 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4233
5c380ffb
JD
42342011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4235
4236 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4237
9af30bdf
GM
42382011-03-27 Glenn Morris <rgm@gnu.org>
4239
4240 * syssignal.h: Replace RETSIGTYPE with void.
4241 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4242 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4243 Replace SIGTYPE with void everywhere.
4244 * s/usg5-4-common.h (SIGTYPE): Remove definition.
4245 * s/template.h (SIGTYPE): Remove commented out definition.
4246
e2abce01
JB
42472011-03-26 Eli Zaretskii <eliz@gnu.org>
4248
4249 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4250 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4251
f868cd8a
JB
42522011-03-26 Juanma Barranquero <lekktu@gmail.com>
4253
59eb0929
JB
4254 * w32.c (read_unc_volume): Use parameter `henum', instead of
4255 global variable `wget_enum_handle'.
4256
4257 * keymap.c (describe_vector): Remove parameters `indices' and
4258 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
4259 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
4260
f868cd8a
JB
4261 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
4262
4263 * keyboard.c (timer_check): Remove parameter `do_it_now',
4264 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4265 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4266 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4267
4268 * keyboard.c (read_char):
4269 * w32menu.c (w32_menu_display_help):
4270 * xmenu.c (show_help_event, menu_help_callback):
4271 Adjust calls to `show_help_echo'.
4272
4273 * gtkutil.c (xg_maybe_add_timer):
4274 * keyboard.c (readable_events):
4275 * process.c (wait_reading_process_output):
4276 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
4277
4278 * insdel.c (adjust_markers_gap_motion):
4279 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
4280 (gap_left, gap_right): Don't call it.
4281
2ecf6fdb
CY
42822011-03-25 Chong Yidong <cyd@stupidchicken.com>
4283
4284 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
4285 incurred during fontification.
4286
6b1f9ba4
JB
42872011-03-25 Juanma Barranquero <lekktu@gmail.com>
4288
4289 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
4290 (DEFVAR_PER_BUFFER): Don't pass it.
4291
4292 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
4293 (scrolling_window): Don't pass it.
4294
0f4a96b5
JB
42952011-03-25 Juanma Barranquero <lekktu@gmail.com>
4296
4297 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
4298
4299 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
4300 and `suffix'.
4301 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
4302 of variables specific to SELinux and computation of `encoded_absname'.
4303
4304 * image.c (XPutPixel): Remove unused variable `height'.
4305
4306 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
4307
4308 * unexw32.c (get_section_info): Remove unused variable `section'.
4309
4310 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
4311 (system_process_attributes): Remove unused variable `sess'.
4312 (sys_read): Remove unused variable `err'.
4313
4314 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
4315 (w32_wnd_proc): Remove unused variable `isdead'.
4316 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
4317 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
4318 (x_create_tip_frame): Remove unused variable `tem'.
4319
4320 * w32inevt.c (w32_console_read_socket):
4321 Remove unused variable `no_events'.
4322
4323 * w32term.c (x_draw_composite_glyph_string_foreground):
4324 Remove unused variable `width'.
4325
1149507c
JB
43262011-03-24 Juanma Barranquero <lekktu@gmail.com>
4327
4328 * w32term.c (x_set_glyph_string_clipping):
4329 Don't pass uninitialized region to CombineRgn.
4330
9c88f339
JB
43312011-03-23 Juanma Barranquero <lekktu@gmail.com>
4332
4333 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
4334 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
4335 (Fx_close_connection): Remove unused variable `i'.
4336
4337 * w32font.c (w32font_draw): Return number of glyphs.
4338 (w32font_open_internal): Remove unused variable `i'.
4339 (w32font_driver): Add missing initializer.
4340
4341 * w32menu.c (utf8to16): Remove unused variable `utf16'.
4342 (fill_in_menu): Remove unused variable `items_added'.
4343
4344 * w32term.c (last_mouse_press_frame): Remove static global variable.
4345 (w32_clip_to_row): Remove unused variable `f'.
4346 (x_delete_terminal): Remove unused variable `i'.
4347
4348 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
4349 (NOTHING): Remove unused static global variable.
4350 (uniscribe_check_otf): Remove unused variable `table'.
4351 (uniscribe_font_driver): Add missing initializers.
4352
dee091a3
JD
43532011-03-23 Julien Danjou <julien@danjou.info>
4354
4355 * term.c (Fsuspend_tty, Fresume_tty):
4356 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
4357 * window.c (temp_output_buffer_show):
4358 * insdel.c (signal_before_change):
4359 * frame.c (Fhandle_switch_frame):
4360 * fileio.c (Fdo_auto_save):
4361 * emacs.c (Fkill_emacs):
4362 * editfns.c (save_excursion_restore):
4363 * cmds.c (internal_self_insert):
4364 * callint.c (Fcall_interactively):
4365 * buffer.c (Fkill_all_local_variables):
4366 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
4367 Use Frun_hooks.
0f4a96b5 4368 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
4369 unconditionnaly since it does the check itself.
4370
2c520ab5 43712011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 4372
c9c49752
PE
4373 Fix more problems found by GCC 4.5.2's static checks.
4374
8abc3f12
PE
4375 * coding.c (encode_coding_raw_text): Avoid unnecessary test
4376 the first time through the loop, since we know p0 < p1 then.
4377 This also avoids a gcc -Wstrict-overflow warning.
4378
a2d26660
PE
4379 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
4380 leading to a memory leak, possible in functions like
4381 load_charset_map_from_file that can allocate an unbounded number
b12ef411 4382 of objects (Bug#8318).
a2d26660 4383
916c72e9
PE
4384 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
4385 that could (at least in theory) be that large.
4386
19ab8a18
PE
4387 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
4388 This is less likely to overflow, and avoids undefined behavior if
4389 overflow does occur. All callers changed. Use strtoul to scan
4390 for the unsigned long integer.
b7cbbd6f
PE
4391 (pint2hrstr): Simplify and tune code slightly.
4392 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 4393
f0641eff
PE
4394 * scroll.c (do_scrolling): Work around GCC bug 48228.
4395 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
4396
7f650bb9
PE
4397 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
4398 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
4399 (validate_x_resource_name): Simplify count usage.
4400 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 4401
37dd57d1
PE
4402 * fileio.c (Fcopy_file): Report error if fchown or fchmod
4403 fail (Bug#8306).
81e56e61 4404
699979fc 4405 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 4406
401bf9b4
PE
4407 * process.c (Fmake_network_process): Use socklen_t, not int,
4408 where POSIX says socklen_t is required in portable programs.
4409 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 4410 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
4411 (Fmake_network_process, server_accept_connection):
4412 (wait_reading_process_output, read_process_output):
4413 Likewise.
4414
b93aacde
PE
4415 * process.c: Rename or move locals to avoid shadowing.
4416 (list_processes_1, Fmake_network_process):
4417 (read_process_output_error_handler, exec_sentinel_error_handler):
4418 Rename or move locals.
4dc343ee 4419 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 4420 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 4421 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 4422 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 4423 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 4424
af8a867c 4425 Make tparam.h and terminfo.c consistent.
44f230aa
SM
4426 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
4427 Include tparam.h instead, since it declares them.
af8a867c
PE
4428 * cm.h (PC): Remove extern decl; tparam.h now does this.
4429 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
4430 * terminfo.c: Include tparam.h, to check interfaces.
4431 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
4432 (tparam): Adjust signature to match interface in tparam.h;
4433 this removes some undefined behavior. Check that outstring and len
4434 are zero, which they always are with Emacs.
4435 * tparam.h (PC, BC, UP): New extern decls.
4436
0248044d 4437 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 4438 (xftfont_open): Rename locals to avoid shadowing.
0248044d 4439
8ff096c1 4440 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
4441 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
4442 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 4443 (ftfont_list): Remove unused local.
49eaafba
PE
4444 (get_adstyle_property, ftfont_pattern_entity):
4445 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
4446 Rename locals to avoid shadowing.
8ff096c1 4447
e2be39f6
PE
4448 * xfont.c (xfont_list_family): Mark var as initialized.
4449
c9735e30
PE
4450 * xml.c (make_dom): Now static.
4451
8f5201ae
PE
4452 * composite.c (composition_compute_stop_pos): Rename local to
4453 avoid shadowing.
b246f932
PE
4454 (composition_reseat_it): Remove unused locals.
4455 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 4456 (composition_update_it): Mark var as initialized.
11b61122
PE
4457 (find_automatic_composition): Mark vars as initialized,
4458 with a FIXME (Bug#8290).
8f5201ae 4459
760fbc2c
PE
4460 character.h: Rename locals to avoid shadowing.
4461 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
4462 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
4463 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
4464 (BUF_DEC_POS): Be more systematic about renaming local temporaries
4465 to avoid shadowing.
4466
ff08eb85
PE
4467 * textprop.c (property_change_between_p): Remove; unused.
4468
fc7bf025
PE
4469 * intervals.c (interval_start_pos): Now static.
4470
235d7abc
PE
4471 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
4472
44f230aa
SM
4473 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
4474 Rename locals to avoid shadowing.
3e7d6594 4475
50060332
PE
4476 * sound.c (wav_play, au_play, Fplay_sound_internal):
4477 Fix pointer signedness.
d01f234b 4478 (alsa_choose_format): Remove unused local var.
c83b8872
PE
4479 (wav_play): Initialize a variable to 0, to prevent undefined
4480 behavior (Bug#8278).
50060332 4481
c4fc4e30
PE
4482 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
4483
918436ed
PE
4484 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
4485
c939f91b
PE
4486 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
4487 clobbering (Bug#8298).
b9c7f648
PE
4488 * sysdep.c (sys_subshell): Likewise.
4489 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 4490
6bd8c144
PE
4491 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
4492 This should get cleaned up, so that child_setup has the
4493 same signature on all platforms.
4494
7710357c 4495 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 4496 (relocate_fd): Rename locals to avoid shadowing.
7710357c 4497
c59da222
CY
44982011-03-22 Chong Yidong <cyd@stupidchicken.com>
4499
4500 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
4501 not to be necessary, and produces flickering.
4502
66b87493
GM
45032011-03-20 Glenn Morris <rgm@gnu.org>
4504
4505 * config.in: Remove file.
4506
45b6f6d5
JB
45072011-03-20 Juanma Barranquero <lekktu@gmail.com>
4508
4509 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
4510 are now in src/globals.h.
4511 (syms_of_minibuf): Remove spurious & from previous change.
4512
3ec03f7e
LL
45132011-03-20 Leo <sdl.web@gmail.com>
4514
4515 * minibuf.c (completing-read-function): New variable.
4516 (completing-read-default): Rename from completing-read.
4517 (completing-read): Call completing-read-function.
4518
b14e3e21
CY
45192011-03-19 Juanma Barranquero <lekktu@gmail.com>
4520
4521 * xfaces.c (Fx_load_color_file):
4522 Read color file from absolute filename (bug#8250).
4523
f2b726e6
JB
45242011-03-19 Juanma Barranquero <lekktu@gmail.com>
4525
4526 * makefile.w32-in: Update dependencies.
4527
09f6ff02
EZ
45282011-03-17 Eli Zaretskii <eliz@gnu.org>
4529
4530 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4531
29a6015a
PE
45322011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4533
a3a6c54e
PE
4534 Fix more problems found by GCC 4.5.2's static checks.
4535
b766f867
PE
4536 * process.c (make_serial_process_unwind, send_process_trap):
4537 (sigchld_handler): Now static.
4538
be02381c
PE
4539 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4540 That way, the code declares only the vars that it needs.
4541 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4542 * s/cygwin.h (PTY_ITERATION): Likewise.
4543 * s/darwin.h (PTY_ITERATION): Likewise.
4544 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4545
57048744
PE
4546 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4547 * process.c (allocate_pty): Don't declare stb unless it's needed.
4548
7914961c 4549 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
4550 (CONSTANTLIM): Remove; unused.
4551 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4552 Define only if needed.
7914961c 4553
b3967b18
PE
4554 * unexelf.c (unexec): Name an expression,
4555 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
4556 Use a different way to cause a compilation error if anyone uses
4557 n rather than nn, a way that does not involve shadowing.
73366a00 4558 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 4559
29a6015a
PE
4560 * deps.mk (unexalpha.o): Remove; unused.
4561
43cfc33e 4562 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 4563 * unexec.h: New file.
ce701a33
PE
4564 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4565 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4566 Depend on unexec.h.
4567 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4568 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4569 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 4570 Change as necessary to match prototype in unexec.h.
ce701a33 4571
01f44d5a
PE
4572 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4573 shadowing.
4f63c6bb 4574 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 4575
a6670b0b
PE
4576 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4577 Rename locals to avoid shadowing.
4578
cef2010d 4579 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 4580 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 4581
d4d7173a
PE
4582 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4583
f08b802a
PE
4584 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4585 warning when compiling print.c.
4586
3ddb0639
PE
4587 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4588 instead of using an uninitialized var.
5ad03b97 4589 (font_sort_entities): Mark var as initialized.
3ddb0639 4590
170a2692
PE
4591 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4592
e663c700
PE
4593 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4594 pointers to constants.
89bc529a 4595 (font_parse_fcname): Remove unused vars.
7b81e2d0 4596 (font_delete_unmatched): Now static.
ea838e10 4597 (font_get_spec): Remove; unused.
13a547c6
PE
4598 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4599 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4600 Rename or move locals to avoid shadowing.
e663c700 4601
2a80c887 4602 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 4603 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 4604
1384fa33 4605 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 4606 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 4607
8b2c52e9
PE
4608 * alloc.c (mark_backtrace): Move decl from here ...
4609 * lisp.h: ... to here, so that it can be checked.
4610
475545b5 4611 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 4612 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
4613 (lisp_indirect_variable): Name an expression,
4614 to avoid gcc -Wbad-function-cast warning.
1faed8ae 4615 (Fdefvar): Rename locals to avoid shadowing.
475545b5 4616
b1349114 4617 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 4618 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 4619 Use const pointer when appropriate.
b1349114 4620
a2928364
PE
4621 * lisp.h (get_system_name, get_operating_system_release):
4622 Move decls here, to check interfaces.
4623 * process.c (get_operating_system_release): Move decl to lisp.h.
4624 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
4625 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4626 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4627 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
4628 (Fformat_time_string, Fencode_time, Finsert_char):
4629 (Ftranslate_region_internal, Fformat):
4630 Rename or remove local vars to avoid shadowing.
9710023e 4631 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 4632
a415e694
PE
4633 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4634 avoid shadowing.
4635
8ef4622d
PE
4636 * lisp.h (eassert): Check that the argument compiles, even if
4637 ENABLE_CHECKING is not defined.
4638
946f9a5b
PE
4639 * data.c (Findirect_variable): Name an expression, to avoid
4640 gcc -Wbad-function-cast warning.
112396d6 4641 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 4642 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
4643 (Fmake_variable_buffer_local, Fmake_local_variable):
4644 Mark variables as initialized.
52746918 4645 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 4646
e5aab7e7 4647 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
4648 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4649 Rename locals to avoid shadowing.
dff45157
PE
4650 (mark_stack): Move local variables into the #ifdef region where
4651 they're used.
7bc26fdb
PE
4652 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4653 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4654 needed otherwise.
4655 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4656 (GC_STRING_CHARS): Remove; not used.
d40d4be1 4657 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 4658
e5aab7e7
PE
4659 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4660 avoids undefined behavior in theory.
4661
4da60324
PE
4662 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4663
88043301
PE
4664 Use functions, not macros, for up- and down-casing (Bug#8254).
4665 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4666 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4667 to use the following functions instead of these macros.
4668 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4669 EMACS_INT, since callers assume the returned value fits in int.
4670 (upcase1): Likewise, for UPCASE_TABLE.
4671 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 4672 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 4673 the race-condition problem in the old DOWNCASE.
88043301 4674
19ed5445
PE
4675 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4676 Rename locals to avoid shadowing.
4677 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
4678 (regex_compile, re_search_2, re_match_2_internal):
4679 Remove unused local vars.
952db0d7
PE
4680 (FREE_VAR): Rewrite so as not to use empty "else",
4681 which gcc can warn about.
da053e48 4682 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
4683 (RETALLOC_IF): Define only if needed.
4684 (WORDCHAR_P): Likewise. This one is never needed, but is used
4685 only in a comment talking about a compiler bug, so put inside
4686 the #if 0 of that comment.
4687 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4688 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4689 Remove; unused.
19ed5445 4690
1f3561e4 4691 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
4692 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4693 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 4694
ded6f8f7
PE
4695 * search.c (simple_search): Remove unused var.
4696
dbd37a95
PE
4697 * dired.c (compile_pattern): Move decl from here ...
4698 * lisp.h: ... to here, so that it can be checked.
4699 (struct re_registers): New forward decl.
4700
7e47afad
PE
4701 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4702
85f24f61
PE
4703 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4704 All uses changed.
4705 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4706 Rename locals to avoid shadowing.
5671df8f 4707 (Fvertical_motion): Mark locals as initialized.
85f24f61 4708
181aa2be 4709 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 4710 (casify_region): Mark local as initialized.
181aa2be 4711
930d429c
PE
4712 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4713
7082eac6
PE
4714 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4715 New macros, so that the caller can use some names other than
4716 gcpro1, gcpro2, etc.
4717 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4718 of the new macros.
4719 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4720 argument, for consistency with GCPRO2_VAR, etc: it is now the
4721 prefix of the variable, not the variable itself. All uses
4722 changed.
38b2c076
PE
4723 * dired.c (directory_files_internal, file_name_completion):
4724 Rename locals to avoid shadowing.
4725
15206ed9
PE
4726 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4727 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4728 dired.c's scmp function, had undefined behavior.
4729 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4730 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4731 * buffer.h: ... to here, because these macros use current_buffer,
4732 and the new implementation with inline functions needs to have
4733 current_buffer in scope now, rather than later when the macros
4734 are used.
4735 (downcase, upcase1): New static inline functions.
4736 (DOWNCASE, UPCASE1): Reimplement using these functions.
4737 This avoids undefined behavior in expressions like
4738 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4739 from race conditions in accessing the global variables
4740 case_temp1 and case_temp2.
4741 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4742 * lisp.h (case_temp1, case_temp2): Remove their decls.
4743 * character.h (ASCII_CHAR_P): Move from here ...
4744 * lisp.h: ... to here, so that the inline functions mentioned
4745 above can use them.
4746
4a6bea26
PE
4747 * dired.c (directory_files_internal_unwind): Now static.
4748
f14b7e14
PE
4749 * fileio.c (file_name_as_directory, directory_file_name):
4750 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4751 Now static.
2893f146
PE
4752 (file_name_as_directory): Use const pointers when appropriate.
4753 (Fexpand_file_name): Likewise. In particular, newdir might
4754 point at constant storage, so make it a const pointer.
fd4ead52 4755 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
4756 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4757 signedness issues.
f839df0c
PE
4758 (Fset_file_times, Finsert_file_contents, auto_save_error):
4759 Rename locals to avoid shadowing.
f14b7e14 4760
5716756e 4761 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
4762 (Ftry_completion, Fall_completions): Rename or remove locals
4763 to avoid shadowing.
5716756e 4764
b4c3046a
PE
4765 * marker.c (bytepos_to_charpos): Remove; unused.
4766
b45db522
PE
4767 * lisp.h (verify_bytepos, count_markers): New decls,
4768 so that gcc does not warn that these functions aren't declared.
4769
85876d07
PE
4770 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4771 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 4772 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 4773 (copy_text): Remove unused local var.
85876d07 4774
03d78a21 4775 * filelock.c (within_one_second): Now static.
b3dd38ab 4776 (lock_file_1): Rename local to avoid shadowing.
03d78a21 4777
5df8f01b
PE
4778 * buffer.c (fix_overlays_before): Mark locals as initialized.
4779 (fix_start_end_in_overlays): Likewise. This function should be
4780 simplified by using pointers-to-pointers, but that's a different
4781 matter.
b1d876f1 4782 (switch_to_buffer_1): Now static.
8f54f30a
PE
4783 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4784 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 4785
a70072c9 4786 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 4787 Fix pointer signedness issue.
edced198
PE
4788 (sys_subshell): Mark local as volatile if checking for lint,
4789 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 4790 (MAXPATHLEN): Define only if needed.
a70072c9 4791
a0977c44
PE
4792 * process.c (serial_open, serial_configure): Move decls from here ...
4793 * systty.h: ... to here, so that they can be checked.
4794
a884fdcc
PE
4795 * fns.c (get_random, seed_random): Move extern decls from here ...
4796 * lisp.h: ... to here, so that they can be checked.
4797
604efe86 4798 * sysdep.c (reset_io): Now static.
b8950c94 4799 (wait_for_termination_signal): Remove; unused.
604efe86 4800
38fc62d9
PE
4801 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4802 (copy_keymap_item, append_key, push_text_char_description):
4803 Now static.
1004a21a 4804 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 4805 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
4806 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4807 (describe_map_tree):
4808 Rename locals to avoid shadowing.
38fc62d9 4809
2f2650da
PE
4810 * keyboard.c: Declare functions static if they are not used elsewhere.
4811 (echo_char, echo_dash, cmd_error, top_level_2):
4812 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
4813 (read_char, kbd_buffer_get_event, make_lispy_position):
4814 (make_lispy_event, make_lispy_movement, apply_modifiers):
4815 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4816 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4817 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 4818 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 4819 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 4820
a053e86c 4821 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
4822 (mark_kboards): Move decl here ...
4823 * alloc.c (mark_kboards): ... from here.
a053e86c 4824
4752793e
PE
4825 * lisp.h (force_auto_save_soon): New decl.
4826
74f10ca7 4827 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
4828 (DEFINE_DUMMY_FUNCTION): New macro.
4829 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4830 Use it.
c03cd23f
PE
4831 (main): Add casts to avoid warnings
4832 if GCC considers string literals to be constants.
74f10ca7 4833
022e70d4
PE
4834 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4835
59d6fe83
PE
4836 * dbusbind.c: Pointer signedness fixes.
4837 (xd_signature, xd_append_arg, xd_initialize):
4838 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4839 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4840 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4841 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4842
78320123
PE
4843 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4844 if GCC considers string literals to be constants.
49cebcca 4845 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 4846
35ac2a97
SM
48472011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4848
fb103ca9
SM
4849 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4850 (print_preprocess, print_object): New macro to fix last change.
4851
35ac2a97
SM
4852 * print.c (print_preprocess): Don't forget font objects.
4853
62973b41
JB
48542011-03-16 Juanma Barranquero <lekktu@gmail.com>
4855
4856 * emacs.c (USAGE3): Doc fixes.
4857
0e48bb22
AS
48582011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4859
4860 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4861 structure.
4862
7684e57b
JB
48632011-03-14 Juanma Barranquero <lekktu@gmail.com>
4864
4865 * lisp.h (VWindow_system, Qfile_name_history):
4866 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4867 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4868 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4869
4870 * w32select.c: Don't #include "keyboard.h".
c96bbc66 4871 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
4872
4873 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4874 * w32console.c (detect_input_pending, read_input_pending)
4875 (encode_terminal_code):
4876 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4877 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4878 (w32_system_caret_y, Qfile_name_history):
4879 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4880 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4881 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4882 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4883 * w32proc.c (Qlocal, report_file_error):
4884 * w32term.c (Vwindow_system, updating_frame):
4885 * w32uniscribe.c (initialized, uniscribe_font_driver):
4886 Remove unneeded extern declarations.
4887
2aa46d6c
CY
48882011-03-14 Chong Yidong <cyd@stupidchicken.com>
4889
c96bbc66 4890 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 4891
cffc6f3b
CY
48922011-03-13 Chong Yidong <cyd@stupidchicken.com>
4893
4894 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4895 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4896 These macros can no longer be used for assignment.
4897
44f230aa
SM
4898 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4899 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
4900 (record_buffer_markers, fetch_buffer_markers): New functions for
4901 recording and fetching special buffer markers.
4902 (set_buffer_internal_1, set_buffer_temp): Use them.
4903
4904 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4905
4906 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4907
4908 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4909 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4910
4911 * xdisp.c (hscroll_window_tree):
4912 (reconsider_clip_changes): Use PT instead of BUF_PT.
4913
d251f04b
EZ
49142011-03-13 Eli Zaretskii <eliz@gnu.org>
4915
4916 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4917 $(EMACS_ROOT)/lib/intprops.h.
4918
f0c77cd1
PE
49192011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4920
3eca4629
PE
4921 Fix more problems found by GCC 4.5.2's static checks.
4922
7c86ee98
PE
4923 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4924 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
4925 (xg_free_frame_widgets): Make it clear that a local variable is
4926 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
4927 (gdk_window_get_screen): Make it clear that this macro is needed
4928 only if USE_GTK_TOOLTIP.
1e5524e7
PE
4929 (int_gtk_range_get_value): New function, which avoids a diagnostic
4930 from gcc -Wbad-function-cast.
4931 (xg_set_toolkit_scroll_bar_thumb): Use it.
4932 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4933 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
4934 (get_utf8_string, xg_get_file_with_chooser):
4935 Rename locals to avoid shadowing.
4936 (create_dialog): Move locals to avoid shadowing.
7c86ee98 4937
41729b81
PE
4938 * xgselect.c (xg_select): Remove unused var.
4939
f0c77cd1
PE
4940 * image.c (four_corners_best): Mark locals as initialized.
4941 (gif_load): Initialize transparent_p to zero (Bug#8238).
4942 Mark another local as initialized.
ec6cf4c6 4943 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 4944
ce0ad53d 4945 * image.c (clear_image_cache): Now static.
d5d5a617 4946 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 4947 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
4948 (x_edge_detection): Remove unnecessary cast that
4949 gcc -Wbad-function-cast diagnoses.
2037898d 4950 (gif_load): Fix pointer signedness.
6ae141d6
PE
4951 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4952 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 4953
33383987 49542011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 4955
d32df629
PE
4956 Improve quality of tests for time stamp overflow.
4957 For example, without this patch (encode-time 0 0 0 1 1
4958 1152921504606846976) returns the obviously-bogus value (-948597
4959 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4960 reports time overflow. See
4961 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
4962 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4963 * editfns.c: Include limits.h and intprops.h.
4964 (TIME_T_MIN, TIME_T_MAX): New macros.
4965 (time_overflow): Move earlier, to before first use.
4966 (hi_time, lo_time): New functions, for an accurate test for
4967 out-of-range times.
4968 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4969 (Fget_internal_run_time): Don't assume time_t fits in int.
4970 (make_time): Use list2 instead of Fcons twice.
4971 (Fdecode_time): More accurate test for out-of-range times.
4972 (check_tm_member): New function.
4973 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
4974 (lisp_time_argument): Don't rely on undefined left-shift and
4975 right-shift behavior when checking for time stamp overflow.
8be6f318 4976
fe31d94c
PE
4977 * editfns.c (time_overflow): New function, refactoring common code.
4978 (Fformat_time_string, Fdecode_time, Fencode_time):
4979 (Fcurrent_time_string): Use it.
4980
8be6f318
PE
4981 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4982 * dired.c (make_time): Move to ...
4983 * editfns.c (make_time): ... here.
4984 * systime.h: Note the move.
4985
09d9db2c 49862011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 4987
126bc0dc
YM
4988 * fringe.c (update_window_fringes): Remove unused variables.
4989
c47cbdfd
YM
4990 * unexmacosx.c (copy_data_segment): Also copy __got section.
4991 (Bug#8223)
4992
7ac80be9
EZ
49932011-03-12 Eli Zaretskii <eliz@gnu.org>
4994
c96bbc66 4995 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
4996 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4997 Constify `char *' arguments and their references according to
4998 prototypes in tparam.h.
4999
ecb0f94d 5000 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 5001
7ac80be9
EZ
5002 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
5003 Adapt all references accordingly.
5004
5005 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
5006
ef1fd07e
TT
50072011-03-11 Tom Tromey <tromey@redhat.com>
5008
5009 * buffer.c (syms_of_buffer): Remove obsolete comment.
5010
7ef4b50c
EZ
50112011-03-11 Eli Zaretskii <eliz@gnu.org>
5012
5013 * termhooks.h (encode_terminal_code): Declare prototype.
5014
5015 * msdos.c (encode_terminal_code): Don't declare prototype.
5016
5017 * term.c (encode_terminal_code): Now external again, used by
5018 w32console.c and msdos.c.
5019
44f230aa
SM
5020 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
5021 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 5022
4b1ec863 50232011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 5024
1714f52b 5025 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 5026
4b1ec863
PE
5027 * fringe.c (update_window_fringes): Mark locals as initialized
5028 (Bug#8227).
5029 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 5030
524c7aa6
PE
5031 * alloc.c (mark_fringe_data): Move decl from here ...
5032 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
5033 to check its interface.
5034 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
5035
a5c0af81 5036 * fontset.c (free_realized_fontset): Now static.
7519b8cd 5037 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 5038 (fontset_font): Mark local as initialized.
a9a06e0b 5039 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 5040
b4716021
PE
5041 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
5042
811e9bac 5043 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 5044 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
5045 (x_own_selection, Fx_disown_selection_internal): Rename locals
5046 to avoid shadowing.
5047 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 5048
7e3ab302
PE
5049 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
5050 so that the caller can use some name other than gcpro1.
5051 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
5052 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5053 (Fx_backspace_delete_keys_p):
5054 Use them to avoid shadowing, and rename vars to avoid shadowing.
5055 (x_decode_color, x_set_name, x_window): Now static.
6b437900 5056 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 5057 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
5058 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
5059 Remove unused locals.
7e3ab302
PE
5060 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5061 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
5062 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
5063 macros.
f78faa98 5064
e2b13473
PE
5065 * xterm.h (x_mouse_leave): New decl.
5066
77f23912
PE
5067 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
5068 Remove unused functions.
cdf4ba58
PE
5069 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
5070 (x_calc_absolute_position): Now static.
7411c686 5071 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 5072 Don't declare local "event" unless it's used.
ed7bf3a5
PE
5073 (x_iconify_frame, x_free_frame_resources): Don't declare locals
5074 unless they are used.
38d0b34a
PE
5075 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
5076 (x_fatal_error_signal): Remove; not used.
a6067996
PE
5077 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
5078 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
5079 (x_error_catcher, x_connection_closed, x_error_handler):
5080 (x_error_quitter, xembed_send_message, x_iconify_frame):
5081 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 5082 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 5083 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 5084
44f230aa
SM
5085 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
5086 Rename or move locals to avoid shadowing.
6b463e58 5087 (tty_defined_color, merge_face_heights): Now static.
5967d051 5088 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
5089 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
5090 does not deduce is never used uninitialized.
73719eba
PE
5091 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
5092 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 5093
426994c3 5094 * terminal.c (store_terminal_param): Now static.
5489860b 5095
032f1620 5096 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 5097 (set_frame_menubar): Remove unused local.
d4323972 5098 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
5099 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
5100 since they might point to immutable storage.
281585b0
PE
5101 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
5102 since it's unused otherwise.
032f1620 5103
367c19e5 5104 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 5105 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
5106 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
5107 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 5108 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
5109 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
5110 does not deduce are never used uninitialized.
70739cbe 5111
07b48fa9
PE
5112 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
5113
8868a238 5114 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
5115 * window.c (window_loop, size_window):
5116 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 5117
7e5cf297 5118 * window.c (display_buffer): Now static.
d6550a9f
PE
5119 (size_window): Mark variables that gcc -Wuninitialized
5120 does not deduce are never used uninitialized.
a586633d
PE
5121 * window.h (check_all_windows): New decl, to forestall
5122 gcc -Wmissing-prototypes diagnostic.
5b555da1 5123 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 5124
f6095868
PE
5125 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
5126 shadowing.
5127 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
5128 Include <limits.h>.
5129 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
5130 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
5131 (load_charset_map): Mark variables that gcc -Wuninitialized
5132 does not deduce are never used uninitialized.
53df7c11 5133 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 5134
f38b440c
PE
5135 * coding.c (coding_set_source, coding_set_destination):
5136 Use "else { /* comment */ }" rather than "else /* comment */;"
5137 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
5138 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
5139 a block, when the outer 'i' will do.
5140 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
5141 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
5142 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
5143 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
5144 (Fdecode_sjis_char, Fdefine_coding_system_internal):
5145 Rename locals to avoid shadowing.
5146 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
5147 * coding.c (emacs_mule_char, encode_invocation_designation):
5148 Now static, since they're not used elsewhere.
413bb2db 5149 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 5150 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
5151 (decode_coding_emacs_mule): Mark variables that gcc
5152 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
5153 (detect_coding_iso_2022): Initialize a local variable that might
5154 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 5155 this initialization is needed. (Bug#8211)
5f58e762
PE
5156 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
5157 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
5158 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
5159 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
5160 Remove unused macros.
f38b440c 5161
232b38b9 5162 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 5163 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 5164 * character.c (string_count_byte8): Likewise.
232b38b9 5165
fb90da1b
PE
5166 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
5167 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
5168
fb93dbc2
PE
5169 * chartab.c (copy_sub_char_table): Now static, since it's not used
5170 elsewhere.
5c156ace
PE
5171 (sub_char_table_ref_and_range, char_table_ref_and_range):
5172 Rename locals to avoid shadowing.
bbcd0949 5173 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 5174
7d3b3862 5175 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 5176 (BIDI_BOB): Remove unused macro.
7d3b3862 5177
6be7d3da
PE
5178 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
5179 deduce are never used uninitialized.
c2ed9c8b 5180 * term.c (encode_terminal_code): Likewise.
6be7d3da 5181
75f8807f 5182 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 5183
50938595
PE
5184 * tparam.h: New file.
5185 * term.c, tparam.h: Include it.
5186 * deps.mk (term.o, tparam.o): Depend on tparam.h.
5187 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
5188 Move these decls to tparam.h, and make them agree with what
5189 is actually in tparam.c. The previous trick of using incompatible
5190 decls in different modules does not conform to the C standard.
5191 All callers of tparam changed to use tparam's actual API.
5192 * tparam.c (tparam1, tparam, tgoto):
5193 Use const pointers where appropriate.
5194
fbceeba2
PE
5195 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5196 * cm.h (struct cm): Likewise.
5197 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5198 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5199 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5200 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5201 (turn_on_face, init_tty): Likewise.
5202 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 5203
7f3f1250
PE
5204 * term.c (term_mouse_position): Rename local to avoid shadowing.
5205
e6ca6543
PE
5206 * alloc.c (mark_ttys): Move decl from here ...
5207 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5208
c40f8d15
AS
52092011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5210
5211 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5212
cfe0661d
JB
52132011-03-09 Juanma Barranquero <lekktu@gmail.com>
5214
5215 * search.c (compile_pattern_1): Remove argument regp, unused since
5216 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5217 (compile_pattern): Don't pass it.
5218
0afb4571
J
52192011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5220
5221 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5222 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5223 for ! HAVE_GTK3.
5224 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5225
5226 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5227
5228 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5229 gdk_window_get_screen, gdk_window_get_geometry,
5230 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5231 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5232 (xg_get_pixbuf_from_pixmap): New function.
5233 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5234 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5235 Call xg_get_pixbuf_from_pixmap instead of
5236 gdk_pixbuf_get_from_drawable.
5237 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5238 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5239 (xg_check_special_colors): Use GtkStyleContext and its functions
5240 for HAVE_GTK3.
5241 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5242 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5243 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
5244 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
5245 Call gtk_widget_get_preferred_size.
0afb4571
J
5246 (xg_frame_resized): gdk_window_get_geometry only takes 5
5247 parameters.
44f230aa
SM
5248 (xg_win_to_widget, xg_event_is_for_menubar):
5249 Call gdk_x11_window_lookup_for_display.
0afb4571
J
5250 (xg_set_widget_bg): New function.
5251 (delete_cb): New function.
895009e1 5252 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
5253 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
5254 (xg_set_background_color): Call xg_set_widget_bg.
5255 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
5256 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
5257 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
5258 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
5259 if ! HAVE_GTK3.
5260 (update_frame_tool_bar): Call gtk_widget_hide.
5261 (xg_initialize): Use GDK_KEY_g.
5262
5263 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
5264 if ! HAVE_GTK3
5265 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5266
5267 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5268 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
5269 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
5270
1c2cc4ef
JB
52712011-03-08 Juanma Barranquero <lekktu@gmail.com>
5272
5273 * w32xfns.c (select_palette): Check success of RealizePalette against
5274 GDI_ERROR, not zero.
5275
33383987 5276See ChangeLog.11 for earlier changes.
aac0c6e3
MR
5277
5278;; Local Variables:
5279;; coding: utf-8
aac0c6e3
MR
5280;; End:
5281
33383987 5282 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
5283
5284 This file is part of GNU Emacs.
5285
5286 GNU Emacs is free software: you can redistribute it and/or modify
5287 it under the terms of the GNU General Public License as published by
5288 the Free Software Foundation, either version 3 of the License, or
5289 (at your option) any later version.
5290
5291 GNU Emacs is distributed in the hope that it will be useful,
5292 but WITHOUT ANY WARRANTY; without even the implied warranty of
5293 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5294 GNU General Public License for more details.
5295
5296 You should have received a copy of the GNU General Public License
5297 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.