gnus-sum.el (gnus-summary-hide-thread): Fix bug where moving to hide the thread moves...
[bpt/emacs.git] / src / ChangeLog
CommitLineData
e23640bb 12011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
2
3 * composite.c (find_automatic_composition): Fix previous change.
4
b9704ad9
GM
52011-05-20 Glenn Morris <rgm@gnu.org>
6
7 * lisp.mk: New file, split from Makefile.in.
8 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
9 (shortlisp): Remove.
10 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
11
4a720484
GM
122011-05-19 Glenn Morris <rgm@gnu.org>
13
14 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
15 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
16 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
17 (lisp): Set the order to that of loadup.el.
18 (shortlisp): Make it a copy of $lisp.
19 (SOME_MACHINE_LISP): Remove.
20 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
21 Use just $shortlisp, not $SOME_MACHINE_LISP too.
22
a28d4396
KH
232011-05-18 Kenichi Handa <handa@m17n.org>
24
25 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
26 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
27 (find_automatic_composition): Mostly rewrite for efficiency.
28
a2b1fa8e
JB
292011-05-18 Juanma Barranquero <lekktu@gmail.com>
30
31 * makefile.w32-in: Update dependencies.
32
8e1f5610
CS
332011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
34
35 * menu.c: Include limits.h (fixes the MS-Windows build broken by
36 revision 104625).
37
7025ee00 382011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 39
cdfa6eab
PE
40 Fix some integer overflow issues, such as string length overflow.
41
06d6db33
PE
42 * insdel.c (count_size_as_multibyte): Check for string overflow.
43
2b4560a8
PE
44 * character.c (lisp_string_width): Check for string overflow.
45 Use EMACS_INT, not int, for string indexes and lengths; in
46 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
47 the resulting string length overflows an EMACS_INT; instead,
48 report a string overflow if no precision given. When checking for
49 precision exhaustion, use a check that cannot possibly have
50 integer overflow. (Bug#8675)
51 * character.h (lisp_string_width): Adjust to new signature.
52
cb93f9be
PE
53 * alloc.c (string_overflow): New function.
54 (Fmake_string): Use it. This doesn't change behavior, but saves
55 a few bytes and will simplify future changes.
56 * character.c (string_escape_byte8): Likewise.
57 * lisp.h (string_overflow): New decl.
58
1a1f3366
PE
59 Fixups, following up to the user-interface timestamp change.
60 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
61 for UI timestamps, instead of unsigned long.
9fbd6841
PE
62 * msdos.c (mouse_get_pos): Likewise.
63 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
64 * w32gui.h (Time): Define by including "systime.h" rather than by
65 declaring it ourselves. (Bug#8664)
66
d4e3e4d3
PE
67 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
68 * image.c (clear_image_cache): Likewise.
69
f6a24d19
PE
70 * term.c (term_mouse_position): Don't assume time_t wraparound.
71
08dc5ae6
PE
72 Be more systematic about user-interface timestamps.
73 Before, the code sometimes used 'Time', sometimes 'unsigned long',
74 and sometimes 'EMACS_UINT', to represent these timestamps. This
75 change causes it to use 'Time' uniformly, as that's what X uses.
76 This makes the code easier to follow, and makes it easier to catch
77 integer overflow bugs such as Bug#8664.
78 * frame.c (Fmouse_position, Fmouse_pixel_position):
79 Use Time, not unsigned long, for user-interface timestamps.
80 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
81 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
82 * keyboard.h (last_event_timestamp): Likewise.
83 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
84 * menu.h (xmenu_show): Likewise.
85 * term.c (term_mouse_position): Likewise.
86 * termhooks.h (struct input_event.timestamp): Likewise.
87 (struct terminal.mouse_position_hook): Likewise.
88 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
89 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
90 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
91 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
92 what it was before.
93 * menu.h, termhooks.h: Include "systime.h", for Time.
94
8e55734a
PE
95 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
96 Don't assume that the difference between two unsigned long values
97 can fit into an integer. At this point, we know button_down_time
98 <= event->timestamp, so the difference must be nonnegative, so
99 there's no need to cast the result if double-click-time is
100 nonnegative, as it should be; check that it's nonnegative, just in
101 case. This bug is triggered when events are more than 2**31 ms
86db42d2 102 apart (about 25 days). (Bug#8664)
8e55734a 103
841f1b75 104 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 105 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 106
3e26f69c
PE
107 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
108 that always fit in int. Use a sentinel instead of a counter, to
109 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
110 * frame.h (struct frame): Use int for menu_bar_items_used
111 instead of EMACS_INT, since it always fits in int.
3e26f69c 112
5cc152c0
PE
113 * menu.c (grow_menu_items): Check for int overflow.
114
d89eb65e
PE
115 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
116
5235bd3e
PE
117 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
118 Before, the code was not consistent. These values cannot exceed
119 2**31 - 1 so there's no need to make them unsigned.
120 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
121 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
122 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
123 as modifiers.
124 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
125
bc827e23
PE
126 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
127 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
128 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
129 presumably because the widths might not match.
130
78eb494e
PE
131 * window.c (size_window): Avoid needless test at loop start.
132
04f2d78b
CB
1332011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
134
135 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
136
d2fc7e3d 1372011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
138
139 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
140
d2fc7e3d 1412011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
142
143 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
144 `width' to `bar_area_x' and `bar_area_width', respectively.
145 (x_scroll_run): Take account of fringe background extension.
146
04f2d78b
CB
147 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
148 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
149 `bar_area_width', respectively.
150 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
151 background extension.
152
79b70037
GM
1532011-05-10 Jim Meyering <meyering@redhat.com>
154
155 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
156
2f142cc5
JB
1572011-05-10 Juanma Barranquero <lekktu@gmail.com>
158
159 * image.c (Finit_image_library): Return t for built-in image types,
160 like pbm and xbm. (Bug#8640)
161
57679c86
AS
1622011-05-09 Andreas Schwab <schwab@linux-m68k.org>
163
164 * w32menu.c (set_frame_menubar): Fix submenu allocation.
165
888c9e86
EZ
1662011-05-07 Eli Zaretskii <eliz@gnu.org>
167
b0512a1d
EZ
168 * w32console.c (Fset_screen_color): Doc fix.
169 (Fget_screen_color): New function.
170 (syms_of_ntterm): Defsubr it.
171
888c9e86
EZ
172 * callproc.c (call_process_cleanup): Don't close and unlink the
173 temporary file if Fcall_process didn't create it in the first
174 place.
175 (Fcall_process): Don't create tempfile if stdout of the child
176 process will be redirected to a file specified with `:file'.
177 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
178 cue to call_process_cleanup not to close that handle.
179
4d3fcc8e
BK
1802011-05-07 Ben Key <bkey76@gmail.com>
181
182 * makefile.w32-in: The bootstrap-temacs rule now makes use of
183 one of two shell specific rules, either bootstrap-temacs-CMD or
184 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
185 to the previous implementation of the bootstrap-temacs rule.
186 The bootstrap-temacs-CMD rule is similar to the previous
187 implementation of the bootstrap-temacs rule except that it
188 makes use of the ESC_CFLAGS variable instead of the CFLAGS
189 variable.
190
191 These changes, along with some changes to nt/configure.bat,
192 nt/gmake.defs, and nt/nmake.defs, are required to extend my
193 earlier fix to add support for --cflags and --ldflags options
194 that include quotes so that it works whether make uses cmd or
195 sh as the shell.
196
b4289b64
MA
1972011-05-06 Michael Albinus <michael.albinus@gmx.de>
198
199 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
200 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
201 is a constant.
202 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
203 a string. Handle both cases.
204 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
205 (Fdbus_register_method): Use Qinvalid_function.
206
af4c0e28
JB
2072011-05-06 Juanma Barranquero <lekktu@gmail.com>
208
209 * makefile.w32-in: Update dependencies.
210 (LISP_H): Add inttypes.h and stdin.h.
211 (PROCESS_H): Add unistd.h.
212
c51453d9
EZ
2132011-05-06 Eli Zaretskii <eliz@gnu.org>
214
215 * lread.c: Include limits.h (fixes the MS-Windows build broken by
216 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
217
8ff0ac3c 2182011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 219
4c4b566b
PE
220 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
221
aab2b9b5
PE
222 * term.c (vfatal): Remove stray call to va_end.
223 It's not needed and the C Standard doesn't allow it here anyway.
224
c378da0b
PE
225 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
226 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
227
288b08c7
PE
228 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
229 bytes.
230
e3601888
PE
231 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
232
db6c0e74
PE
233 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
234
dd5963ea
PE
235 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
236
88c9450f
PE
237 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
238
2f9442b8
PE
239 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
240
c032b5f8
PE
241 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
242 * charset.c (Fdefine_charset_internal): Don't initialize
243 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 244 32-bit int (Bug#8600).
a108c10b
PE
245
246 * lread.c (read_integer): Be more consistent with string-to-number.
247 Use string_to_number to do the actual conversion; this avoids
248 rounding errors and fixes some other screwups. Without this fix,
249 for example, #x1fffffffffffffff was misread as -2305843009213693952.
250 (digit_to_number): Move earlier, for benefit of read_integer.
251 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 252 not a digit in any supported base. (Bug#8602)
a108c10b 253
ad5f9eea
PE
254 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
255
aec1708a
PE
256 * dispnew.c (scrolling_window): Return 1 if we scrolled,
257 to match comment at start of function. This also removes a
258 GCC warning about overflow in a 32+64-bit port.
259
47be4ab5
PE
260 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
261
371cac43
PE
262 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
263 Reported by Stefan Monnier in
264 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
265 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
266 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 267
d01a7826
PE
268 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
269 (EMACS_UINTPTR): Likewise, with uintptr_t.
270
7fd47d5c
PE
271 * lisp.h: Prefer 64-bit EMACS_INT if available.
272 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
273 on 32-bit hosts that have 64-bit int, so that they can access
274 large files.
122b0c86
PE
275 However, temporarily disable this change unless the temporary
276 symbol WIDE_EMACS_INT is defined.
7fd47d5c 277
8727937b
PE
278 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
279
8ac068ac
PE
280 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
281 This removes an assumption that EMACS_INT and long are the same
282 width as pointers. The assumption is true for Emacs porting targets
283 now, but we want to make other targets possible.
284 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
285 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
286 In the rest of the code, change types of integers that hold casted
287 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
288 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
289 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
290 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
291 No need to cast type when ORing.
292 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
293 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
294 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
295 assume EMACS_INT is the same width as char *.
296 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
297 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
298 Remove no-longer-needed casts.
299 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
300 (xg_tool_bar_help_callback, xg_make_tool_item):
301 Use EMACS_INTPTR to hold an integer
302 that will be cast to void *; this can avoid a GCC warning
303 if EMACS_INT is not the same width as void *.
304 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
305 * xdisp.c (display_echo_area_1, resize_mini_window_1):
306 (current_message_1, set_message_1):
307 Use a local to convert to proper width without a cast.
308 * xmenu.c (dialog_selection_callback): Likewise.
309
ede49d71
PE
310 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
311 Also, don't assume VALBITS / RAND_BITS is less than 5,
312 and don't rely on undefined behavior when shifting a 1 left into
313 the sign bit.
314 * lisp.h (get_random): Change signature to match.
315
2f30ecd0
PE
316 * lread.c (hash_string): Use size_t, not int, for hash computation.
317 Normally we prefer signed values; but hashing is special, because
318 it's better to use unsigned division on hash table sizes so that
319 the remainder is nonnegative. Also, size_t is the natural width
320 for hashing into memory. The previous code used 'int', which doesn't
321 retain enough info to hash well into very large tables.
322 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
323
2a866e7b
PE
324 * dbusbind.c: Don't possibly lose pointer info when converting.
325 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
326 Use XPNTR rather than XHASH, so that the high-order bits of
327 the pointer aren't lost when converting through void *.
328
51639eac
PE
329 * eval.c (Fautoload): Don't double-shift a pointer.
330
92394119
PE
331 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
332
dbdb9a7c
JB
3332011-05-06 Juanma Barranquero <lekktu@gmail.com>
334
335 * gnutls.c (DEF_GNUTLS_FN):
336 * image.c (DEF_IMGLIB_FN): Make function pointers static.
337
db7a0b4f
AS
3382011-05-05 Andreas Schwab <schwab@linux-m68k.org>
339
340 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
341 marker. (Bug#8610)
342
f7ff1b0f 3432011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
344
345 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
346 New version that can reserve upto 2GB of heap space.
347
f7ff1b0f 3482011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
349
350 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
351
639c109b
TZ
3522011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
353
354 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
355 `gnutls_certificate_set_x509_key_file'.
356
d2127135
JB
3572011-05-05 Juanma Barranquero <lekktu@gmail.com>
358
359 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
360 Update dependencies.
361
e968f4f3
JB
3622011-05-04 Juanma Barranquero <lekktu@gmail.com>
363
364 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
365 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
366 Remove unused parameter `fildes'.
367 * process.c (read_process_output, send_process): Don't pass it.
368
84d358f0
JB
3692011-05-04 Juanma Barranquero <lekktu@gmail.com>
370
371 Fix previous change: the library cache is defined in w32.c.
372 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
373 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
374
0898ca10
JB
3752011-05-04 Juanma Barranquero <lekktu@gmail.com>
376
377 Implement dynamic loading of GnuTLS on Windows.
378
379 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
380 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
381 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
382 Declare.
383
384 * gnutls.c (Qgnutls_dll): Define.
385 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
386 (gnutls_*): Declare function pointers.
387 (init_gnutls_functions): New function to initialize function pointers.
388 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
389 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
390 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
391 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
392 (emacs_gnutls_write, emacs_gnutls_read)
393 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
394 (Fgnutls_available_p): New function.
395 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
396 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
397 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
398
399 * image.c: Include w32.h.
400 (Vimage_type_cache): Delete.
401 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
402 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
403 (w32_delayed_load): Move to w32.c.
404
405 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
406
407 * w32.c (QCloaded_from, Vlibrary_cache): Define.
408 (w32_delayed_load): Move from image.c. When loading a library, record
409 its filename in the :loaded-from property of the library id.
410 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
411 Initialize and staticpro them.
412 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
413
414 * process.c: Include lisp.h before w32.h, not after.
415 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
416 instead of gnutls_record_check_pending.
417
418 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
419
ff4de4aa
TZ
4202011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
421
422 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
423 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
424 as passed in.
425
abe95abb
JD
4262011-05-03 Jan Djärv <jan.h.d@swipnet.se>
427
428 * xterm.c (x_set_frame_alpha): Do not set property on anything
429 else than FRAME_X_OUTER_WINDOW (Bug#8608).
430
e16e55d4
JB
4312011-05-02 Juanma Barranquero <lekktu@gmail.com>
432
433 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
434
bafcf6a5
JB
4352011-05-02 Juanma Barranquero <lekktu@gmail.com>
436
437 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
438 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
439 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
440 (gnutls_global_initialized, Qgnutls_bootprop_priority)
441 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
442 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
443 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
444 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
445 (Qgnutls_bootprop_callbacks_verify): Make static.
446
e7a6747f
AS
4472011-05-01 Andreas Schwab <schwab@linux-m68k.org>
448
19ed11ba
AS
449 * callproc.c: Indentation fixup.
450
e7a6747f 451 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
452 (wait_for_termination, interruptible_wait_for_termination):
453 Move after wait_for_termination_1.
e7a6747f 454
1ef14cb4
LMI
4552011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
456
457 * sysdep.c (interruptible_wait_for_termination): New function
458 which is like wait_for_termination, but allows keyboard
459 interruptions.
460
461 * callproc.c (Fcall_process): Add (:file "file") as an option for
462 the STDOUT buffer.
463 (Fcall_process_region): Ditto.
464
330d880c
EZ
4652011-04-30 Eli Zaretskii <eliz@gnu.org>
466
8db90b73
EZ
467 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
468 rather than `XVECTOR (FOO)->size'.
469
330d880c
EZ
470 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
471 inttypes.h, as a gnulib replacement is used if it not available in
472 system headers.
473
15cbd324
EZ
4742011-04-21 Eli Zaretskii <eliz@gnu.org>
475
476 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
477 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
478 of MOST_POSITIVE_FIXNUM. (Bug#8528)
479
480 * coding.c (coding_alloc_by_realloc): Error out if destination
481 will grow beyond MOST_POSITIVE_FIXNUM.
482 (decode_coding_emacs_mule): Abort if there isn't enough place in
483 charbuf for the composition carryover bytes. Reserve an extra
484 space for up to 2 characters produced in a loop.
485 (decode_coding_iso_2022): Abort if there isn't enough place in
486 charbuf for the composition carryover bytes.
487
4882011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 489
ae940cca
EZ
490 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
491 aborting when %lld or %lll format is passed.
492 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
493 %llo or %llx format is passed. (Bug#8545)
494
03ab8921
EZ
495 * window.c (window_scroll_line_based): Use a marker instead of
496 simple variables to record original value of point. (Bug#7952)
497
afda1437
EZ
498 * doprnt.c (doprnt): Fix the case where a multibyte sequence
499 produced by %s or %c overflows available buffer space. (Bug#8545)
500
f76dee0c
PE
5012011-04-28 Paul Eggert <eggert@cs.ucla.edu>
502
503 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 504 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 505
fdc5744d
JB
5062011-04-28 Juanma Barranquero <lekktu@gmail.com>
507
508 * w32.c (init_environment): Warn about defaulting HOME to C:\.
509
638f053a
JB
5102011-04-28 Juanma Barranquero <lekktu@gmail.com>
511
512 * keyboard.c (Qdelayed_warnings_hook): Define.
513 (command_loop_1): Run `delayed-warnings-hook'
514 if Vdelayed_warnings_list is non-nil.
515 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
516 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
517
d178f871
EZ
5182011-04-28 Eli Zaretskii <eliz@gnu.org>
519
520 * doprnt.c (doprnt): Don't return value smaller than the buffer
521 size if the message was truncated. (Bug#8545).
522
b124fd93
JB
5232011-04-28 Juanma Barranquero <lekktu@gmail.com>
524
525 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
526 (Fx_window_property): #if-0 the whole functions, not just the bodies.
527
e810457d
PE
5282011-04-27 Paul Eggert <eggert@cs.ucla.edu>
529
530 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
531
ea51cceb
JB
5322011-04-27 Juanma Barranquero <lekktu@gmail.com>
533
534 * makefile.w32-in: Update dependencies.
535
94dcfacf
EZ
5362011-04-27 Eli Zaretskii <eliz@gnu.org>
537
538 Improve `doprnt' and its usage. (Bug#8545)
539 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
540 `format_end'. Remove support for %l as a conversion specifier.
541 Don't use xrealloc. Improve diagnostics when the %l size modifier
542 is used. Update the commentary.
543
544 * eval.c (verror): Simplify calculation of size_t.
545
546 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
547 messages.
548
f61f41d7
PE
5492011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
550
551 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
552 change.
553
96fb4434
PE
5542011-04-27 Paul Eggert <eggert@cs.ucla.edu>
555
556 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
557 This makes this file independent of the recent pseudovector change.
558
671875da 5592011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 560
69e9b5a3
PE
561 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
562
b5f869a7 563 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 564 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 565 Remove unused local.
c8926152 566 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 567
841a1577 568 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
569 GCC 4.6.0 optimizes based on type-based alias analysis.
570 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
571 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
572 != &v->size, and therefore "v->size = 1; b->size = 2; return
573 v->size;" must therefore return 1. This assumption is incorrect
574 for Emacs, since it type-puns struct Lisp_Vector * with many other
575 types. To fix this problem, this patch adds a new type struct
f904488f 576 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
577 and pseudovectors, and helps optimizing compilers not get fooled
578 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
579 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
580 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
581 the size member.
eab3844f
PE
582 (XSETPVECTYPE): Rewrite in terms of new macro.
583 (XSETPVECTYPESIZE): New macro, specifying both type and size.
584 This is a bit clearer, and further avoids the possibility of
585 undesirable aliasing.
586 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 587 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
588 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
589 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
590 (ASIZE): Now uses header.size rather than size.
591 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
592 to avoid the hassle of writing XVECTOR (foo)->header.size.
593 (struct vectorlike_header): New type.
eab3844f
PE
594 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
595 object, to help avoid aliasing.
596 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
597 (SUBRP): Likewise, since Lisp_Subr is a special case.
598 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
599 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
600 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 601 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
602 changed to be "header.size" and "header.next".
603 * buffer.h (struct buffer): Likewise.
604 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
605 * frame.h (struct frame): Likewise.
606 * process.h (struct Lisp_Process): Likewise.
607 * termhooks.h (struct terminal): Likewise.
608 * window.c (struct save_window_data, struct saved_window): Likewise.
609 * window.h (struct window): Likewise.
610 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
611 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
612 * buffer.c (init_buffer_once): Likewise.
613 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
614 special case.
615 * process.c (Fformat_network_address): Use local var for size,
616 for brevity.
617
0df1eac5
PE
618 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
619
847ab9d1 620 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
621 * data.c (atof): Remove decl; no longer used or needed.
622 (digit_to_number): Move to lread.c.
623 (Fstring_to_number): Use new string_to_number function, to be
624 consistent with how the Lisp reader treats infinities and NaNs.
625 Do not assume that floating-point numbers represent EMACS_INT
626 without losing information; this is not true on most 64-bit hosts.
627 Avoid double-rounding errors, by insisting on integers when
628 parsing non-base-10 numbers, as the documentation specifies.
629 * lisp.h (string_to_number): New decl, replacing ...
630 (isfloat_string): Remove.
bc0a5c13 631 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 632 (read1): Do not accept +. and -. as integers; this
452f4150
PE
633 appears to have been a coding error. Similarly, do not accept
634 strings like +-1e0 as floating point numbers. Do not report
635 overflow for integer overflows unless the base is not 10 which
636 means we have no simple and reliable way to continue.
637 Break out the floating-point parsing into a new
638 function string_to_number, so that Fstring_to_number parses
639 floating point numbers consistently with the Lisp reader.
04f2d78b 640 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
641 (E_CHAR, EXP_INT): Remove, replacing with ...
642 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
643 (string_to_number): New function, replacing isfloat_string.
644 This function checks for valid syntax and produces the resulting
645 Lisp float number too. Rework it so that string-to-number
bc0a5c13 646 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
647 so that overflow for non-base-10 numbers is reported only when
648 there's no portable and simple way to convert to floating point.
452f4150 649
67769ffc
PE
650 * textprop.c (set_text_properties_1): Rewrite for clarity,
651 and to avoid GCC warning about integer overflow.
652
c20db43f
PE
653 * intervals.h (struct interval): Use EMACS_INT for members
654 where EMACS_UINT might cause problems. See
655 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
656 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
657 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
658 All uses changed.
37aa2f85
PE
659 (offset_intervals): Tell GCC not to worry about length overflow
660 when negating a negative length.
c20db43f 661
2538aa2f
PE
662 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
663 (overrun_check_free): Likewise.
664
f2d3008d
PE
665 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
666 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
667 word size.
668
ec8df744
PE
669 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
670 (gnutls_make_error): Rename local to avoid shadowing.
671 (gnutls_emacs_global_deinit): ifdef out; not used.
672 (Fgnutls_boot): Use const for pointer to readonly storage.
673 Comment out unused local. Fix pointer signedness problems.
674
640ee02d
PE
675 * lread.c (openp): Don't stuff size_t into an 'int'.
676 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
677 about possible signed overflow.
678
6048fb2a
PE
679 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
680 (GDK_KEY_g): Don't define if already defined.
681 (xg_prepare_tooltip): Avoid pointer signedness problem.
682 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
683
fa3c87e1
PE
684 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
685 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
686
2172544b
PE
687 * xfns.c (Fx_window_property): Simplify a bit,
688 to make a bit faster and to avoid GCC 4.6.0 warning.
689 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
690
9b821a21
PE
691 * fns.c (internal_equal): Don't assume size_t fits in int.
692
3c616cfa
PE
693 * alloc.c (compact_small_strings): Tighten assertion a little.
694
c2982e87
PE
695 Replace pEd with more-general pI, and fix some printf arg casts.
696 * lisp.h (pI): New macro, generalizing old pEd macro to other
697 conversion specifiers. For example, use "...%"pI"d..." rather
698 than "...%"pEd"...".
699 (pEd): Remove. All uses replaced with similar uses of pI.
700 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
701 * alloc.c (check_pure_size): Don't overflow by converting size to int.
702 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
703 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
704 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
705 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
706 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
707 64-bit hosts.
708 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
709 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
710 * print.c (safe_debug_print, print_object): Likewise.
711 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
712 to int.
6f04d126
PE
713 Use pI instead of if-then-else-abort. Use %p to avoid casts,
714 avoiding the 0 flag, which is not portable.
c2982e87
PE
715 * process.c (Fmake_network_process): Use pI to avoid cast.
716 * region-cache.c (pp_cache): Likewise.
717 * xdisp.c (decode_mode_spec): Likewise.
718 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
719 behavior on 64-bit hosts with printf arg.
6f04d126 720 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
721 (x_stop_queuing_selection_requests): Likewise.
722 (x_get_window_property): Don't truncate byte count to an 'int'
723 when tracing.
0b432f21 724
5e073ec7
PE
725 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
726 here, since it parses constructs like leading '-' and spaces,
727 which are not wanted; and it overflows with large numbers.
728 Instead, simply match F[0-9]+, which is what is wanted anyway.
729
36372bf9
PE
730 * alloc.c: Remove unportable assumptions about struct layout.
731 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
732 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
733 (allocate_vectorlike, make_pure_vector): Use the new macros,
734 plus offsetof, to remove unportable assumptions about struct layout.
735 These assumptions hold on all porting targets that I know of, but
736 they are not guaranteed, they're easy to remove, and removing them
737 makes further changes easier.
738
0b432f21
PE
739 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
740 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
741 (string_overrun_cookie): Now const. Use initializers that
742 don't formally overflow signed char, to avoid warnings.
000098c1
PE
743 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
744 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
745 (allocate_buffer): Don't assume sizeof (struct buffer) is a
746 multiple of sizeof (EMACS_INT); it need not be, if
747 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 748 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 749
895009e1
JB
7502011-04-26 Juanma Barranquero <lekktu@gmail.com>
751
752 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
753
6a7a1b0b
TZ
7542011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
755
756 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 757 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
758 Reported by Paul Eggert <eggert@cs.ucla.edu>.
759
841a1577 7602011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
761
762 * lisp.h (Qdebug): List symbol.
895009e1 763 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
764 * keyboard.c (debug-on-event): New variable.
765 (handle_user_signal): Break into debugger when debug-on-event
766 matches the current signal symbol.
767
f2d3ba6f
DN
7682011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
769
770 * alloc.c (check_sblock, check_string_bytes)
771 (check_string_free_list): Convert to standard C.
772
42ce4c63
TZ
7732011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
774
775 * w32.c (emacs_gnutls_push): Fix typo.
776
825cd63c
EZ
7772011-04-25 Eli Zaretskii <eliz@gnu.org>
778
fb11d64d
EZ
779 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
780 "cast to pointer from integer of different size".
781
825cd63c
EZ
782 Improve doprnt and its use in verror. (Bug#8545)
783 * doprnt.c (doprnt): Document the set of format control sequences
784 supported by the function. Use SAFE_ALLOCA instead of always
785 using `alloca'.
786
787 * eval.c (verror): Don't limit the buffer size at size_max-1, that
788 is one byte too soon. Don't use xrealloc; instead xfree and
789 xmalloc anew.
790
e061a11b
TZ
7912011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
792
793 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
794 callbacks stage.
795
796 * gnutls.c: Renamed global_initialized to
797 gnutls_global_initialized. Added internals for the
798 :verify-hostname-error, :verify-error, and :verify-flags
799 parameters of `gnutls-boot' and documented those parameters in the
800 docstring. Start callback support.
801 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
802 unless a fatal error occured. Call gnutls_alert_send_appropriate
803 on error. Return error code.
804 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
805 (emacs_gnutls_read): Likewise.
806 (Fgnutls_boot): Return handshake error code.
807 (emacs_gnutls_handle_error): New function.
808 (wsaerror_to_errno): Likewise.
809
810 * w32.h (emacs_gnutls_pull): Add prototype.
811 (emacs_gnutls_push): Likewise.
812
813 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
814 (emacs_gnutls_push): Likewise.
815
8162011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
817
818 * process.c (wait_reading_process_output): Check if GnuTLS
819 buffered some data internally if no FDs are set for TLS
820 connections.
821
822 * makefile.w32-in (OBJ2): Add gnutls.$(O).
823 (LIBS): Link to USER_LIBS.
824 ($(BLD)/gnutls.$(0)): New target.
825
fa6996bc
EZ
8262011-04-24 Eli Zaretskii <eliz@gnu.org>
827
eb35682e
EZ
828 * xdisp.c (handle_single_display_spec): Rename the
829 display_replaced_before_p argument into display_replaced_p, to
830 make it consistent with the commentary. Fix typos in the
831 commentary.
832
e2ad650c
EZ
833 * textprop.c (syms_of_textprop): Remove dead code.
834 (copy_text_properties): Delete obsolete commentary about an
835 interface that was deleted long ago. Fix typos in the description
836 of arguments.
837
1b2de274
EZ
838 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
839 to changes in oldXMenu/XMenu.h from 2011-04-16.
840 <menu_help_message, prev_menu_help_message>: Constify.
841 (IT_menu_make_room): menu->help_text is now `const char **';
842 adjust.
843
844 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
845 to changes in oldXMenu/XMenu.h from 2011-04-16.
846 (struct XMenu): Declare `help_text' `const char **'.
847
848 * xfaces.c <Qunspecified>: Make extern again.
849
850 * syntax.c: Include sys/types.h before including regex.h, as
851 required by Posix.
852
762b15be
EZ
853 * doc.c (get_doc_string): Improve the format passed to `error'.
854
855 * doprnt.c (doprnt): Improve commentary.
856
857 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
858
859 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
860 them with etags.
861
f1052e5d
EZ
862 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
863 changes in globals.h immediately force recompilation.
762b15be
EZ
864 (TAGS): Depend on $(CURDIR)/m/intel386.h and
865 $(CURDIR)/s/ms-w32.h.
866 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 867
fa6996bc
EZ
868 * character.c (Fchar_direction): Function deleted.
869 (syms_of_character): Don't defsubr it.
870 <char-direction-table>: Deleted.
871
e6c3da20
EZ
8722011-04-23 Eli Zaretskii <eliz@gnu.org>
873
874 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
875 * doprnt.c: Include limits.h.
876 (SIZE_MAX): New macro.
04f2d78b
CB
877 (doprnt): Return a size_t value. 2nd arg is now size_t.
878 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
879 Improve overflow protection. Support `l' modifier for integer
880 conversions. Support %l conversion. Don't assume an EMACS_INT
881 argument for integer conversions and for %c.
882
883 * lisp.h (doprnt): Restore prototype.
884
885 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
886 $(SRC)/character.h.
887
888 * Makefile.in (base_obj): Add back doprnt.o.
889
890 * deps.mk (doprnt.o): Add back prerequisites.
891 (callint.o): Depend on character.h.
892
893 * eval.c (internal_lisp_condition_case): Include the handler
894 representation in the error message.
895 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
896 when breaking from the loop.
897
898 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
899
900 * callint.c (Fcall_interactively): When displaying error message
901 about invalid control letter, pass the character's codepoint, not
902 a pointer to its multibyte form. Improve display of the character
903 in octal and display also its hex code.
904
905 * character.c (char_string): Use %x to display the (unsigned)
906 codepoint of an invalid character, to avoid displaying a bogus
907 negative value.
908
909 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
910 `error', not SYMBOL_NAME itself.
911
912 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
913 character arguments to `error'.
914
915 * charset.c (check_iso_charset_parameter): Fix incorrect argument
916 to `error' in error message about FINAL_CHAR argument. Make sure
917 FINAL_CHAR is a character, and use %c when it is passed as
918 argument to `error'.
919
4ffd0d6b 9202011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
921
922 * s/ms-w32.h (localtime): Redirect to sys_localtime.
923
924 * w32.c: Include <time.h>.
925 (sys_localtime): New function.
926
4ffd0d6b 9272011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
928
929 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
930
4ffd0d6b 931 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 932
4ffd0d6b 9332011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 934
4ffd0d6b
GM
935 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
936 zombies (Bug#8467).
aac0c6e3 937
04c56954
EZ
9382011-04-19 Eli Zaretskii <eliz@gnu.org>
939
940 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
941 gl_state.e_property when gl_state.object is Qt.
942
943 * insdel.c (make_gap_larger): Remove limitation of buffer size
944 to <= INT_MAX.
945
16a43933
CY
9462011-04-18 Chong Yidong <cyd@stupidchicken.com>
947
948 * xdisp.c (lookup_glyphless_char_display)
949 (produce_glyphless_glyph): Handle cons cell entry in
950 glyphless-char-display.
951 (Vglyphless_char_display): Document it.
952
953 * term.c (produce_glyphless_glyph): Handle cons cell entry in
954 glyphless-char-display.
955
4581706e
CY
9562011-04-17 Chong Yidong <cyd@stupidchicken.com>
957
958 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
959
960 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
961
962 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
963 definition for no-X builds.
964
4887c6e2 9652011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 966
fd35b6f9
PE
967 Static checks with GCC 4.6.0 and non-default toolkits.
968
5c1ccb01
PE
969 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
970
006c5daa
PE
971 * process.c (keyboard_bit_set): Define only if SIGIO.
972 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
973 (send_process): Repair possible setjmp clobbering.
974
efc736d3
PE
975 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
976
4e2fe2e6
PE
977 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
978
f97334a2
PE
979 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
980
4e75f29d
PE
981 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
982 Define only if needed.
983
90efadd1
PE
984 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
985 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 986 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 987
3c647824
PE
988 * dispextern.h (struct redisplay_interface): Rename param
989 to avoid shadowing.
e264f262 990 * termhooks.h (struct terminal): Likewise.
761383f4 991 * xterm.c (xembed_send_message): Likewise.
3c647824 992
b58c5c4a
PE
993 * insdel.c (make_gap_smaller): Define only if
994 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
995
cad59032
PE
996 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
997 it.
998
c339dc2e
PE
999 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1000 so that we aren't warned about unused symbols.
1001
91a3e27b
PE
1002 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1003
399c71d3 1004 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 1005
8ffc96f5
PE
1006 * xfns.c (x_real_positions): Mark locals as initialized.
1007
eef9bc79
PE
1008 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1009
098db9dd
PE
1010 * xterm.c: Fix problems found by static analysis with other toolkits.
1011 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
1012 (x_dispatch_event): Declare static if USE_GTK, and
1013 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 1014 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 1015 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
1016 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1017 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 1018
eb18f6cc
PE
1019 * xmenu.c (menu_help_callback): Pointer type fixes.
1020 Use const pointers when pointing at readonly data. Avoid pointer
1021 signedness clashes.
1022 (FALSE): Remove unused macro.
1023 (update_frame_menubar): Remove unused decl.
1024
1fe72bf8
PE
1025 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1026
60d9e1db
PE
1027 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1028 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1029 (single_menu_item): Rename local to avoid shadowing.
1030
39261c26
PE
1031 * keyboard.c (make_lispy_event): Remove unused local var.
1032
018c5e19
PE
1033 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1034 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1035
63d2b86e
PE
1036 * bitmaps: Change bitmaps from unsigned char back to the X11
1037 compatible char. Avoid the old compiler warnings about
1038 out-of-range initializers by using, for example, '\xab' rather
1039 than 0xab.
1040
aefd87e1
PE
1041 * xgselect.c (xgselect_initialize): Check vs interface
1042 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1043
bf501fb9
PE
1044 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1045
e9829fdf
PE
1046 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1047 to read-only memory.
1048
1086c095
PE
1049 * fns.c (vector): Remove; this old hack is no longer needed.
1050
2baccd04 1051 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 1052 Remove unused var.
dde42981 1053 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 1054
72391843 1055 * xrdb.c (x_load_resources): Omit unused local.
3565b346 1056
436c16df 1057 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 1058 (x_window): Rename locals to avoid shadowing.
dc5ddd85 1059 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 1060
92bb796d 1061 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 1062 (x_term_init): Remove local to avoid shadowing.
92bb796d 1063
764430a3 1064 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
1065
1066 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1067 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1068
d1dfb56c
EZ
10692011-04-16 Eli Zaretskii <eliz@gnu.org>
1070
c4354cb4
EZ
1071 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1072
d1dfb56c
EZ
1073 Fix regex.c, syntax.c and friends for buffers > 2GB.
1074 * syntax.h (struct gl_state_s): Declare character position members
1075 EMACS_INT.
1076
1077 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1078
04f2d78b
CB
1079 * textprop.c (verify_interval_modification, interval_of):
1080 Declare arguments EMACS_INT.
d1dfb56c
EZ
1081
1082 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1083 EMACS_INT.
1084
1085 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1086
1087 * indent.c (Fvertical_motion): Local variable it_start is now
1088 EMACS_INT.
1089
1090 * regex.c (re_match, re_match_2, re_match_2_internal)
1091 (bcmp_translate, regcomp, regexec, print_double_string)
1092 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1093 (re_compile_pattern, re_exec): Declare arguments and local
1094 variables `size_t' and `ssize_t' and return values `regoff_t', as
1095 appropriate.
1096 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1097 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1098 <compile_stack_type>: `size' and `avail' are now `size_t'.
1099
1100 * regex.h <regoff_t>: Use ssize_t, not int.
1101 (re_search, re_search_2, re_match, re_match_2): Arguments that
1102 specify buffer/string position and length are now ssize_t and
1103 size_t. Return type is regoff_t.
1104
613052cd
BK
11052011-04-16 Ben Key <bkey76@gmail.com>
1106
1107 * nsfont.m: Fixed bugs in ns_get_family and
1108 ns_descriptor_to_entity that were caused by using free to
1109 deallocate memory blocks that were allocated by xmalloc (via
1110 xstrdup). This caused Emacs to crash when compiled with
1111 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1112 --enable-checking=xmallocoverrun). xfree is now used to
1113 deallocate these memory blocks.
1114
4170f62f 11152011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 1116
71b41406
PE
1117 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1118
9587a89d
PE
1119 emacs_write: Accept and return EMACS_INT for sizes.
1120 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1121 et seq.
1122 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1123 Accept and return EMACS_INT.
1124 (emacs_gnutls_write): Return the number of bytes written on
1125 partial writes.
1126 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
1127 (emacs_read, emacs_write): Remove check for negative size, as the
1128 Emacs source code has been audited now.
9587a89d
PE
1129 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1130 (emacs_read, emacs_write): Use it.
273a5f82
PE
1131 * process.c (send_process): Adjust to the new signatures of
1132 emacs_write and emacs_gnutls_write. Do not attempt to store
1133 a byte offset into an 'int'; it might overflow.
9587a89d 1134 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 1135
3e047f51
PE
1136 * sound.c: Don't assume sizes fit in 'int'.
1137 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 1138 Return EMACS_INT, not int.
3e047f51 1139 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
1140 Accept EMACS_INT, not int.
1141 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
1142 record read return values.
1143
cc39a9db
BK
11442011-04-15 Ben Key <bkey76@gmail.com>
1145
c9d0ec6d
JB
1146 * keyboard.c (Qundefined): Don't declare static since it is used
1147 in nsfns.m.
1148 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1149 static since they are used in nsfont.m.
cc39a9db 1150
6c60eb9f
SM
11512011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1152
1153 * process.c (Qprocessp): Don't declare static.
1154 * lisp.h (Qprocessp): Declare again.
1155
7990b61a
JB
11562011-04-15 Juanma Barranquero <lekktu@gmail.com>
1157
1158 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1159
5d4cb038
PE
11602011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1161
8bd7b830 1162 Improve C-level modularity by making more things 'static'.
cd64ea1d 1163
e3b27b31
PE
1164 Don't publish debugger-only interfaces to other modules.
1165 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1166 (verify_bytepos, count_markers): Move decls to the only modules
1167 that need them.
1168 * region-cache.h (pp_cache): Likewise.
1169 * window.h (check_all_windows): Likewise.
1170 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1171
5d4cb038
PE
1172 * sysdep.c (croak): Now static, if
1173 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1174 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
1175
1176 * alloc.c (refill_memory_reserve): Now static if
1177 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1178 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 1179
e87b6180
PE
1180 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1181 Define only if USE_LUCID.
1182
ac64929e
PE
1183 * xrdb.c (x_customization_string, x_rm_string): Now static.
1184
6f37259d
PE
1185 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1186 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1187
1683e3ab
PE
1188 * xdisp.c (draw_row_with_mouse_face): Now static.
1189 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1190
de9c2632
PE
1191 * window.h (check_all_windows): Mark externally visible.
1192
2b96acb7
PE
1193 * window.c (window_deletion_count): Now static.
1194
1195 * undo.c: Make symbols static if they're not exported.
1196 (last_undo_buffer, last_boundary_position, pending_boundary):
1197 Now static.
1198
50436f33
PE
1199 * textprop.c (interval_insert_behind_hooks): Now static.
1200 (interval_insert_in_front_hooks): Likewise.
1201
64520e5c
PE
1202 * term.c: Make symbols static if they're not exported.
1203 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1204 (max_frame_lines, tty_set_terminal_modes):
1205 (tty_reset_terminal_modes, tty_turn_off_highlight):
1206 (get_tty_terminal): Now static.
1207 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1208 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 1209 HAVE_WINDOW_SYSTEM.
64520e5c
PE
1210 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1211 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1212
1fa53021
PE
1213 * sysdep.c: Make symbols static if they're not exported.
1214 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1215 Now static.
1216 (sigprocmask_set, full_mask): Remove; unused.
1217 (wait_debugging): Mark as visible.
1218 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1219 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1220
d4b43b22
PE
1221 * syntax.c (syntax_temp): Define only if !__GNUC__.
1222
b7c513d0
PE
1223 * sound.c (current_sound_device, current_sound): Now static.
1224
989b29ad
PE
1225 * search.c (searchbufs, searchbuf_head): Now static.
1226
13a55a78
PE
1227 * scroll.c (scroll_cost): Remove; unused.
1228 * dispextern.h (scroll_cost): Remove decl.
1229
de68a1fc
PE
1230 * region-cache.h (pp_cache): Mark as externally visible.
1231
40ccffa6
PE
1232 * process.c: Make symbols static if they're not exported.
1233 (process_tick, update_tick, create_process, chan_process):
1234 (Vprocess_alist, proc_buffered_char, datagram_access):
1235 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1236 (deactivate_process): Mark defn as static, as well as decl.
1237 * lisp.h (create_process): Remove decl.
1238 * process.h (chan_process, Vprocess_alist): Remove decls.
1239
ad64fc97
PE
1240 * print.c: Make symbols static if they're not exported.
1241 (print_depth, new_backquote_output, being_printed, print_buffer):
1242 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1243 (print_interval, print_number_index, initial_stderr_stream):
1244 Now static.
1245 * lisp.h (Fprinc): Remove decl.
1246 (debug_output_compilation_hack): Mark as externally visible.
1247
adddb265
PE
1248 * sysdep.c (croak): Move decl from here to syssignal.h.
1249 * syssignal.h (croak): Put it here, so the API can be checked when
1250 'croak' is called from dissociate_if_controlling_tty.
1251
1717ede2
PE
1252 * minibuf.c: Make symbols static if they're not exported.
1253 (minibuf_save_list, choose_minibuf_frame): Now static.
1254 * lisp.h (choose_minibuf_frame): Remove decl.
1255
fa5fb2bc
PE
1256 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1257
1e3890d1
PE
1258 * lread.c: Make symbols static if they're not exported.
1259 (read_objects, initial_obarray, oblookup_last_bucket_number):
1260 Now static.
1261 (make_symbol): Remove; unused.
1262 * lisp.h (initial_obarray, make_symbol): Remove decls.
1263
8a1414fa
PE
1264 * keyboard.c: Make symbols static if they're not exported.
1265 (single_kboard, recent_keys_index, total_keys, recent_keys):
1266 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1267 (this_single_command_key_start, echoing, last_auto_save):
1268 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1269 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1270 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1271 (Vlispy_mouse_stem, double_click_count):
1272 Now static.
1273 (force_auto_save_soon): Define only if SIGDANGER.
1274 (ignore_mouse_drag_p): Now static if
1275 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1276 (print_help): Remove; unused.
1277 (stop_character, last_timer_event): Mark as externally visible.
1278 * keyboard.h (ignore_mouse_drag_p): Declare only if
1279 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1280 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1281 * lisp.h (echoing): Remove decl.
1282 (force_auto_save_soon): Declare only if SIGDANGER.
1283 * xdisp.c (redisplay_window): Simplify code, to make it more
1284 obvious that ignore_mouse_drag_p is not accessed if !defined
1285 USE_GTK && !defined HAVE_NS.
1286
93ea6e8f
PE
1287 * intervals.c: Make symbols static if they're not exported.
1288 (merge_properties_sticky, merge_interval_right, delete_interval):
1289 Now static.
1290 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1291
77382fcc
PE
1292 * insdel.c: Make symbols static if they're not exported.
1293 However, leave prepare_to_modify_buffer alone. It's never
1294 called from outside this function, but that appears to be a bug.
1295 (combine_after_change_list, combine_after_change_buffer):
4889fc82 1296 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
1297 (adjust_after_replace_noundo): Remove; unused.
1298 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 1299 (signal_before_change): Remove decls.
77382fcc 1300
9306c32e
PE
1301 * indent.c (val_compute_motion, val_vmotion): Now static.
1302
cd44d2eb
PE
1303 * image.c: Make symbols static if they're not exported.
1304 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
1305 if USE_GTK.
1306 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
1307 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
1308
ad9a7a06
PE
1309 * fringe.c (standard_bitmaps): Now static.
1310 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
1311
81626931
PE
1312 * frame.c: Make symbols static if they're not exported.
1313 (x_report_frame_params, make_terminal_frame): Now static.
1314 (get_frame_param): Now static, unless HAVE_NS.
1315 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
1316 (x_get_resource_string): Remove; not used.
1317 * frame.h (make_terminal_frame, x_report_frame_params):
1318 (x_get_resource_string); Remove decls.
1319 (x_fullscreen_adjust): Declare only if WINDOWSNT.
1320 * lisp.h (get_frame_param): Declare only if HAVE_NS.
1321
239f9db9
PE
1322 * font.c, fontset.c: Make symbols static if they're not exported.
1323 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
1324 (FACE_SUITABLE_FOR_CHAR_P): Use it.
1325 * font.c (font_close_object): Now static.
1326 * font.h (font_close_object): Remove.
1327 * fontset.c (FONTSET_OBJLIST): Remove.
1328 (free_realized_fontset) #if-0 the body, which does nothing.
1329 (face_suitable_for_char_p): #if-0, as it's never called.
1330 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
1331 * xfaces.c (face_at_string_position):
1332 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
1333 since 0 is always ASCII.
1334
dfcf3579
PE
1335 * fns.c (weak_hash_tables): Now static.
1336
5045092b
PE
1337 * fileio.c: Make symbols static if they're not exported.
1338 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
1339 (Vwrite_region_annotation_buffers): Now static.
1340
57a96f5c
PE
1341 * eval.c: Make symbols static if they're not exported.
1342 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1343 * lisp.h (backtrace_list): Remove decl.
1344
35f08c38
PE
1345 * emacs.c: Make symbols static if they're not exported.
1346 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1347 (fatal_error_code, fatal_error_signal_hook, standard_args):
1348 Now static.
1349 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1350 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1351 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1352 * lisp.h (fatal_error_signal_hook): Remove decl.
1353 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1354
f44bd759
PE
1355 * editfns.c: Move a (normally-unused) function to its only use.
1356 * editfns.c, lisp.h (get_operating_system_release): Remove.
1357 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1358 worth the hassle of breaking this out.
1359
b532497d
PE
1360 * xterm.c: Make symbols static if they're not exported.
1361 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1362 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1363 (x_destroy_window, x_delete_display):
1364 Now static.
1365 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1366 (x_mouse_leave): Remove; unused.
1367 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1368 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1369 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1370 Remove decls.
1371 (x_mouse_leave): Declare only if WINDOWSNT.
1372 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1373 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1374 USE_X_TOOLKIT.
1375
1675728f
PE
1376 * ftxfont.c: Make symbols static if they're not exported.
1377 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1378 HAVE_FREETYPE.
1379 * font.h (ftxfont_driver): Likewise.
1380
e4cebfca
PE
1381 * xfns.c: Make symbols static if they're not exported.
1382 (x_last_font_name, x_display_info_for_name):
1383 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1384 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1385 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1386 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1387 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1388 (last_show_tip_args): Now static.
1389 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1390 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1391 (x_screen_planes): Remove; unused.
1392 * dispextern.h (x_screen_planes): Remove decl.
1393
5bf46f05
PE
1394 * dispnew.c: Make symbols static if they're not exported.
1395 * dispextern.h (redraw_garbaged_frames, scrolling):
1396 (increment_row_positions): Remove.
1397 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1398 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1399 Now static.
1400 (redraw_garbaged_frames): Remove; unused.
1401
435f4c28
PE
1402 * xfaces.c: Make symbols static if they're not exported.
1403 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1404 Remove decls.
1405 * xterm.h (defined_color): Remove decls.
1406 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1407 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1408 (menu_face_changed_default, defined_color, free_realized_face):
1409 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1410 (ascii_face_of_lisp_face): Remove; unused.
1411
8524aef3
PE
1412 * xdisp.c: Make symbols static if they're not exported.
1413 * dispextern.h (scratch_glyph_row, window_box_edges):
1414 (glyph_to_pixel_coords, set_cursor_from_row):
1415 (get_next_display_element, set_iterator_to_next):
1416 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1417 (show_mouse_face): Remove decls
1418 * frame.h (message_buf_print): Likewise.
1419 * lisp.h (pop_message, set_message, check_point_in_composition):
1420 Likewise.
1421 * xterm.h (set_vertical_scroll_bar): Likewise.
1422 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1423 (message_buf_print, scratch_glyph_row, displayed_buffer):
1424 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1425 (get_next_display_element, show_mouse_face, window_box_edges):
1426 (frame_to_window_pixel_xy, check_point_in_composition):
1427 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1428 (glyph_to_pixel_coords): Remove; unused.
1429
16390cd2
PE
1430 * dired.c (file_name_completion): Now static.
1431
1432 * dbusbind.c (xd_in_read_queued_messages): Now static.
1433
a25f4dfa
PE
1434 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1435 * data.c (circular_list_error): Remove.
1436
14a9c8df
PE
1437 * commands.h (last_point_position, last_point_position_buffer):
1438 (last_point_position_window): Remove decls.
1439 * keyboard.c: Make these variables static.
1440
04f2d78b
CB
1441 * coding.h (coding, code_convert_region, encode_coding_gap):
1442 Remove decls.
74ab6df5
PE
1443 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1444 (iso_code_class, detect_coding, code_convert_region): Now static.
1445 (encode_coding_gap): Remove; unused.
1446
38dfbee1
PE
1447 * chartab.c (chartab_chars, chartab_bits): Now static.
1448
a2cb4e63
PE
1449 * charset.h (charset_iso_8859_1): Remove decl.
1450 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1451 Now static.
1452
127198fd
PE
1453 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1454 * ccl.c (Vccl_program_table): Now static.
1455 (check_ccl_update): Remove; unused.
1456
d85b608f
PE
1457 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1458 * category.h: ... from here.
1459 * category.c (check_category_table, set_category_set): Now static.
1460
31cd66f3
PE
1461 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1462 * lisp.h: Remove these decls.
1463
c358e587
PE
1464 * buffer.c (buffer_count): Remove unused var.
1465
e78aecca
PE
1466 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1467 so that it's not optimized away.
1468 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1469 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1470 exported only to the debugger.
1471
e192d7d3 1472 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 1473 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 1474
92470028
PE
1475 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
1476 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
1477 was inaccessible from Lisp.
1478 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
1479 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
1480
244ed907
PE
1481 alloc.c: Import and export fewer symbols, and remove unused items.
1482 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
1483 is defined.
1484 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
1485 it's not optimized away by whole-program optimization.
1486 (message_enable_multibyte, free_misc): Remove.
1487 (catchlist, handlerlist, mark_backtrace):
1488 Declare only if BYTE_MARK_STACK.
1489 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
1490 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
1491 (message_enable_multibyte): Remove decl.
1492 (free_misc, interval_free_list, float_block, float_block_index):
1493 (n_float_blocks, float_free_list, cons_block, cons_block_index):
1494 (cons_free_list, last_marked_index):
1495 Now static.
1496 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
1497 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
1498 (mark_backtrace): Define only if BYTE_MARK_STACK.
1499 * xdisp.c (message_enable_multibyte): Now static.
1500
61c2b50e 1501 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
1502 This makes it easier for human readers (and static analyzers)
1503 to see whether these variables are used from other modules.
1504 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
1505 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
1506 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
1507 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
1508 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
1509 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
1510 * xmenu.c, xselect.c:
1511 Declare Q* vars static if they are not used in other modules.
1512 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
1513 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
1514 Remove decls of unexported vars.
1515 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
1516
95c82688
PE
1517 * lisp.h (DEFINE_FUNC): Make sname 'static'.
1518
16a97296
PE
1519 Make Emacs functions such as Fatom 'static' by default.
1520 This makes it easier for human readers (and static analyzers)
1521 to see whether these functions can be called from other modules.
1522 DEFUN now defines a static function. To make the function external
1523 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
1524 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
1525 (Finit_image_library):
16a97296
PE
1526 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
1527 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
1528 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
1529 Remove decls, since these functions are now static.
1530 (Funintern, Fget_internal_run_time): New decls, since these functions
1531 were already external.
95c82688 1532
16a97296
PE
1533 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
1534 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
1535 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
1536 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
1537 * keyboard.c, keymap.c, lread.c:
1538 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
1539 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
1540 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
1541 Mark functions with DEFUE instead of DEFUN,
1542 if they are used in other modules.
1543 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
1544 decls for now-static functions.
1545 * buffer.h (Fdelete_overlay): Remove decl.
1546 * callproc.c (Fgetenv_internal): Mark as internal.
1547 * composite.c (Fremove_list_of_text_properties): Remove decl.
1548 (Fcomposition_get_gstring): New forward static decl.
1549 * composite.h (Fcomposite_get_gstring): Remove decl.
1550 * dired.c (Ffile_attributes): New forward static decl.
1551 * doc.c (Fdocumntation_property): New forward static decl.
1552 * eval.c (Ffetch_bytecode): New forward static decl.
1553 (Funintern): Remove extern decl; now in .h file where it belongs.
1554 * fileio.c (Fmake_symbolic_link): New forward static decl.
1555 * image.c (Finit_image_library): New forward static decl.
1556 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
1557 * intervals.h (Fprevious_property_change):
1558 (Fremove_list_of_text_properties): Remove decls.
1559 * keyboard.c (Fthis_command_keys): Remove decl.
1560 (Fcommand_execute): New forward static decl.
1561 * keymap.c (Flookup_key): New forward static decl.
1562 (Fcopy_keymap): Now static.
1563 * keymap.h (Flookup_key): Remove decl.
1564 * process.c (Fget_process): New forward static decl.
1565 (Fprocess_datagram_address): Mark as internal.
1566 * syntax.c (Fsyntax_table_p): New forward static decl.
1567 (skip_chars): Remove duplicate decl.
1568 * textprop.c (Fprevious_property_change): New forward static decl.
1569 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
1570 Now internal.
1571 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
1572 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
1573
785bbd42
PE
1574 * editfns.c (Fformat): Remove unreachable code.
1575
8b913b57
AS
15762011-04-14 Andreas Schwab <schwab@linux-m68k.org>
1577
1578 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
1579 change. (Bug#8496)
1580
a6744a35
EZ
15812011-04-13 Eli Zaretskii <eliz@gnu.org>
1582
1583 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1584 when at ZV. (Bug#8487)
1585
e7974947
AS
15862011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1587
baad03f0
AS
1588 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1589 (Bug#8437)
1590 * keyboard.c (parse_tool_bar_item): Likewise.
1591 * sound.c (sound_cleanup, alsa_close): Likewise.
1592 * termcap.c (tgetent): Likewise.
1593 * xfns.c (x_default_font_parameter): Likewise.
1594 * xsettings.c (read_and_apply_settings): Likewise.
1595
e7974947
AS
1596 * alloc.c (overrun_check_malloc, overrun_check_realloc)
1597 (overrun_check_free): Protoize.
1598
28272684
PE
15992011-04-12 Paul Eggert <eggert@cs.ucla.edu>
1600
1601 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
1602 since callers should never pass a negative size.
1603 Change the signature to match that of plain 'read' and 'write'; see
1604 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
1605 * lisp.h: Update prototypes of emacs_write and emacs_read.
1606
11997c76
EZ
16072011-04-11 Eli Zaretskii <eliz@gnu.org>
1608
1609 * xdisp.c (redisplay_window): Don't try to determine the character
1610 position of the scroll margin if the window start point w->startp
e896f03c 1611 is outside the buffer's accessible region. (Bug#8468)
11997c76 1612
8a2cbd72
EZ
16132011-04-10 Eli Zaretskii <eliz@gnu.org>
1614
1615 Fix write-region and its subroutines for buffers > 2GB.
1616 * fileio.c (a_write, e_write): Modify declaration of arguments and
1617 local variables to support buffers larger than 2GB.
1618 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
1619
1620 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
1621 argument, local variables, and return value.
1622
1623 * lisp.h: Update prototypes of emacs_write and emacs_read.
1624
1625 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
1626
4073e537 16272011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 1628
1ebfdcb6
PE
1629 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
1630
b2ded58d
PE
1631 Fix more problems found by GCC 4.6.0's static checks.
1632
7d66342c
PE
1633 * xdisp.c (vmessage): Use a better test for character truncation.
1634
bbf47d44
PE
1635 * charset.c (load_charset_map): <, not <=, for optimization,
1636 and to avoid potential problems with integer overflow.
9248994d 1637 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 1638 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 1639 * editfns.c (Fformat): Likewise.
1e69125e 1640 * syntax.c (skip_chars): Likewise.
3befa583 1641
e3019616
PE
1642 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
1643 This also lets GCC 4.6.0 generate slightly better loop code.
1644
becfa255
PE
1645 * callint.c (Fcall_interactively): <, not <=, for optimization.
1646 (Fcall_interactively): Count the number of arguments produced,
1647 not the number of arguments given. This is simpler and lets GCC
1648 4.6.0 generate slightly better code.
1649
dae0cd48
PE
1650 * ftfont.c: Distingish more carefully between FcChar8 and char.
1651 The previous code passed unsigned char * to a functions like
1652 strlen and xstrcasecmp that expect char *, which does not
1653 conform to the C standard.
1654 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
1655 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
1656 char * when the C standard requires it.
1657
76032d70
PE
1658 * keyboard.c (read_char): Remove unused var.
1659
eb3f1cc8
PE
1660 * eval.c: Port to Windows vsnprintf (Bug#8435).
1661 Include <limits.h>.
1662 (SIZE_MAX): Define if the headers do not.
1663 (verror): Do not give up if vsnprintf returns a negative count.
1664 Instead, grow the buffer. This ports to Windows vsnprintf, which
1665 does not conform to C99. Problem reported by Eli Zaretskii.
1666 Also, simplify the allocation scheme, by avoiding the need for
1667 calling realloc, and removing the ALLOCATED variable.
1668
70476b54
PE
1669 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
1670
12020a9e
PE
1671 Remove invocations of doprnt, as Emacs now uses vsnprintf.
1672 But keep the doprint source code for now, as we might revamp it
1673 and use it again (Bug#8435).
ea6c7ae6
PE
1674 * lisp.h (doprnt): Remove.
1675 * Makefile.in (base_obj): Remove doprnt.o.
1676 * deps.mk (doprnt.o): Remove.
1677
5fdb398c
PE
1678 error: Print 32- and 64-bit integers portably (Bug#8435).
1679 Without this change, on typical 64-bit hosts error ("...%d...", N)
1680 was used to print both 32- and 64-bit integers N, which relied on
1681 undefined behavior.
1682 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
1683 New macro.
1684 * lisp.h (error, verror): Mark as printf-like functions.
1685 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
1686 Report overflow in size calculations when allocating printf buffer.
1687 Do not truncate output string at its first null byte.
1688 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
1689 Truncate the output at a character boundary, since vsnprintf does not
1690 do that.
1691 * charset.c (check_iso_charset_parameter): Convert internal
1692 character to string before calling 'error', since %c now has the
1693 printf meaning.
1694 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
1695 overflow when computing char to be passed to 'error'. Do not
1696 pass Lisp_Object to 'error'; pass the integer instead.
1697 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
1698 formatted with plain %d.
1699
b189fa66
PE
1700 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
1701
bff87ef0
PE
1702 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
1703
7e2cac20
PE
1704 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
1705
ce4d90b5
PE
1706 * xterm.c (x_catch_errors): Remove duplicate declaration.
1707
266c9547
PE
1708 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
1709
79c49ad2
PE
1710 * xdisp.c, lisp.h (message_nolog): Remove; unused.
1711
368f4090
JM
17122011-04-10 Jim Meyering <meyering@redhat.com>
1713
1714 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
1715 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
1716 return ssize_t not "int", and use size_t as the buffer length.
1717 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
1718 * gnutls.h: Update declarations.
1719 * process.c (read_process_output): Use ssize_t, to match.
1720 (send_process): Likewise.
1721
a32d4040
CY
17222011-04-09 Chong Yidong <cyd@stupidchicken.com>
1723
1724 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
1725
8546720e 17262011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 1727
04f2d78b
CB
1728 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
1729 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 1730
8546720e
GM
1731 * xterm.c (handle_one_xevent):
1732 * xmenu.c (create_and_show_popup_menu):
1733 * xselect.c (x_decline_selection_request)
1734 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 1735
0a2f5c1a 17362011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
1737
1738 Fix some uses of `int' instead of EMACS_INT.
1739 * search.c (string_match_1, fast_string_match)
1740 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
1741 (scan_buffer, find_next_newline_no_quit)
1742 (find_before_next_newline, search_command, Freplace_match)
1743 (Fmatch_data): Make some `int' variables be EMACS_INT.
1744
1745 * xdisp.c (display_count_lines): 3rd argument and return value now
1746 EMACS_INT. All callers changed.
1747 (pint2hrstr): Last argument is now EMACS_INT.
1748
1749 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
1750 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1751 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
1752 (decode_coding_utf_16, decode_coding_emacs_mule)
1753 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
1754 (decode_coding_ccl, decode_coding_charset)
1755 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
1756 (decode_coding_iso_2022, decode_coding_emacs_mule)
1757 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
1758 <char_offset, last_offset>: Declare EMACS_INT.
1759 (encode_coding_utf_8, encode_coding_utf_16)
1760 (encode_coding_emacs_mule, encode_invocation_designation)
1761 (encode_designation_at_bol, encode_coding_iso_2022)
1762 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
1763 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
1764 Declare EMACS_INT.
1765 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
1766 (encode_invocation_designation): Last argument P_NCHARS is now
1767 EMACS_INT.
1768 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
1769 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
1770
1771 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
1772 All users changed.
1773
1774 * ccl.c (Fccl_execute_on_string): Declare some variables
1775 EMACS_INT.
1776
8546720e 17772011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
1778
1779 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
1780
4e19a977
CS
17812011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
1782
1783 * process.c (Fformat_network_address): Doc fix.
1784
87302331
R
17852011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
1786
1787 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
1788
cbb59342
CY
17892011-04-08 Chong Yidong <cyd@stupidchicken.com>
1790
1791 * keyboard.c (read_char): Call Lisp function help-form-show,
1792 instead of using internal_with_output_to_temp_buffer.
1793 (Qhelp_form_show): New var.
e0d38eeb 1794 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
1795
1796 * print.c (internal_with_output_to_temp_buffer): Function deleted.
1797
1798 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
1799
e67a13ab
CY
18002011-04-06 Chong Yidong <cyd@stupidchicken.com>
1801
04f2d78b
CB
1802 * process.c (Flist_processes): Remove to Lisp.
1803 (list_processes_1): Delete.
e67a13ab 1804
973f782d
EZ
18052011-04-06 Eli Zaretskii <eliz@gnu.org>
1806
7c106b1e
EZ
1807 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
1808
973f782d
EZ
1809 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
1810
41cf7d1a 18112011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 1812
ca23cc88
PE
1813 Fix more problems found by GCC 4.6.0's static checks.
1814
f390e2d5
PE
1815 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
1816
42eea0d0
PE
1817 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
1818
b69769da 1819 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 1820
f9541e84
PE
1821 * xdisp.c (vmessage): Mark as a printf-like function.
1822
13841b55
PE
1823 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
1824
c136c10f
PE
1825 * sound.c (sound_warning): Don't crash if arg contains a printf format.
1826
5e2d4a30
PE
1827 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
1828 printf-like functions.
1829 (tiff_load): Add casts to remove these marks before passing them
1830 to system-supplied API.
1831
583f48b9
PE
1832 * eval.c (Fsignal): Remove excess argument to 'fatal'.
1833
b25d760e
PE
1834 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
1835 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
1836 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
1837 directly, rather than having caller test rule sign. This avoids
1838 some unnecessary tests.
1839 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
1840 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
1841 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 1842
bc7b6697 1843 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 1844 (xfont_open): Avoid unnecessary tests.
bc7b6697 1845
27ccc379
PE
1846 * composite.c (composition_gstring_put_cache): Use unsigned integer.
1847
dcd5c89a
PE
1848 * composite.h, composite.c (composition_gstring_put_cache):
1849 Use EMACS_INT, not int, for length.
1850
b13a45c6
PE
1851 * composite.h (COMPOSITION_DECODE_REFS): New macro,
1852 breaking out part of COMPOSITION_DECODE_RULE.
1853 (COMPOSITION_DECODE_RULE): Use it.
1854 * composite.c (get_composition_id): Remove unused local vars,
1855 by using the new macro.
1856
1e792e4d
PE
1857 * textprop.c (set_text_properties_1): Change while to do-while,
1858 since the condition is always true at first.
1859
dc6c6455 1860 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
1861 (interval_deletion_adjustment): Return unsigned value.
1862 All uses changed.
dc6c6455 1863
aba7731a
PE
1864 * process.c (list_processes_1, create_pty, read_process_output):
1865 (exec_sentinel): Remove vars that were set but not used.
afd4052b 1866 (create_pty): Remove unnecessary "volatile"s.
bc57d757 1867 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 1868 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 1869 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 1870
fdfc4bf3
PE
1871 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
1872
fca8fe46 1873 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 1874 (update_syntax_table): Use unsigned instead of int.
fca8fe46 1875
06a0259a 1876 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 1877 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 1878 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 1879
e7b9e80f
PE
1880 * print.c (print_error_message): Avoid int overflow.
1881
56201685
PE
1882 * font.c (font_list_entities): Redo for clarity,
1883 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
1884
78834453 1885 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 1886 (font_score): Avoid potential overflow in diff calculation.
78834453 1887
0bc0b309 1888 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 1889 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 1890
e610eaca
PE
1891 * eval.c (funcall_lambda): Rename local to avoid shadowing.
1892
b895abce
PE
1893 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
1894 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
1895 can always succeed if overflow has undefined behavior.
1896
1f1d9321 1897 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 1898 (wordify): Omit three unnecessary tests.
1f1d9321 1899
c59478bc
PE
1900 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
1901 All callers changed. This avoids the need for an unused var.
1902
79b73827
PE
1903 * casefiddle.c (casify_region): Remove var that is set but not used.
1904
a4db5dfe
PE
1905 * dired.c (file_name_completion): Remove var that is set but not used.
1906
43aae36e
PE
1907 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
1908
2a47c44d 1909 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 1910 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 1911
a37c69bf
PE
1912 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
1913 Check for integer overflow on size calculations.
1914
328ab8e7
PE
1915 * buffer.c (Fprevious_overlay_change): Remove var that is set
1916 but not used.
1917
e5a2a5cb
PE
1918 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
1919 Remove vars that are set but not used.
8d84a6eb 1920 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 1921 (timer_check_2): Mark vars as initialized.
e5a2a5cb 1922
a60e5f68
PE
1923 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
1924
f661cb61 1925 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 1926 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 1927
f0397f5a
PE
1928 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
1929 that are set but not used.
1930
8664db06 1931 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 1932 if XCreateBitmapFromData fails (Bug#8410).
8664db06 1933
6abdaa4a
PE
1934 * xselect.c (x_get_local_selection, x_handle_property_notify):
1935 Remove vars that are set but not used.
1936
0ce7538d 1937 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 1938 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 1939
9ae848fc
PE
1940 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
1941 Remove var that is set but not used.
0b918413
PE
1942 (scroll_bar_windows_size): Now size_t, not int.
1943 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
1944 Check for overflow.
9ae848fc 1945
a5a62657
PE
1946 * xfaces.c (realize_named_face): Remove vars that are set but not used.
1947 (map_tty_color) [!defined MSDOS]: Likewise.
1948
5c5cdd39
PE
1949 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
1950
66ebf983
PE
1951 * coding.c: Remove vars that are set but not used.
1952 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
1953 All callers changed.
1954 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
1955 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
1956 (decode_coding_charset): Remove vars that are set but not used.
1957
1be4d761
PE
1958 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
1959 that is set but not used.
1960
47553fa8
PE
1961 * print.c (print_object): Remove var that is set but not used.
1962
1f7196bf 1963 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
1964 The gnulib version avoids calling malloc in the usual case,
1965 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
1966 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
1967 * filelock.c (current_lock_owner): Likewise.
1968 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
1969 * sysdep.c: Include allocator.h, careadlinkat.h.
1970 (emacs_no_realloc_allocator): New static constant.
1971 (emacs_readlink): New function.
fdb61804
PE
1972 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
1973 ../lib/careadlinkat.h.
d1fdcab7 1974
f84c17c7
SM
19752011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
1976
1977 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
1978 first non-nil return value).
1979
ef3862ad
JD
19802011-04-03 Jan Djärv <jan.h.d@swipnet.se>
1981
1982 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
1983 if not defined (Bug#8403).
1984
376a7006
JB
19852011-04-02 Juanma Barranquero <lekktu@gmail.com>
1986
1987 * xdisp.c (display_count_lines): Remove parameter `start',
1988 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1989 (get_char_face_and_encoding): Remove parameter `multibyte_p',
1990 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1991 (fill_stretch_glyph_string): Remove parameters `row' and `area',
1992 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
1993 and thereabouts. All callers changed.
1994 (get_per_char_metric): Remove parameter `f', unused since
1995 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1996
6ca3801d
JM
19972011-04-02 Jim Meyering <meyering@redhat.com>
1998
1999 do not dereference NULL upon failed strdup
2000 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2001 (ns_get_family): Likewise.
2002
d8e2b5ba
JB
20032011-04-02 Juanma Barranquero <lekktu@gmail.com>
2004
2005 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2006
8c74fcbd
JD
20072011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2008
2009 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2010 later (Bug#8403).
2011
7200d79c
SM
20122011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2013
03408648 2014 Add lexical binding.
7200d79c 2015
03408648
SM
2016 * window.c (Ftemp_output_buffer_show): New fun.
2017 (Fsave_window_excursion):
2018 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2019
2020 * lread.c (lisp_file_lexically_bound_p): New function.
2021 (Fload): Bind Qlexical_binding.
2022 (readevalloop): Remove `evalfun' arg.
2023 Bind Qinternal_interpreter_environment.
2024 (Feval_buffer): Bind Qlexical_binding.
2025 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2026 Mark as dynamic.
2027 (syms_of_lread): Declare `lexical-binding'.
2028
2029 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2030
2031 * keyboard.c (eval_dyn): New fun.
2032 (menu_item_eval_property): Use it.
ca105506
SM
2033
2034 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 2035
03408648
SM
2036 * fns.c (concat, mapcar1): Accept byte-code-functions.
2037
2038 * eval.c (Fsetq): Handle lexical vars.
2039 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2040 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2041 (FletX, Flet): Obey lexical binding.
2042 (Fcommandp): Handle closures.
2043 (Feval): New `lexical' arg.
2044 (eval_sub): New function extracted from Feval. Use it almost
2045 everywhere where Feval was used. Look up vars in lexical env.
2046 Handle closures.
2047 (Ffunctionp): Move from subr.el.
2048 (Ffuncall): Handle closures.
2049 (apply_lambda): Remove `eval_flags'.
2050 (funcall_lambda): Handle closures and new byte-code-functions.
2051 (Fspecial_variable_p): New function.
2052 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2053 but without exporting it to Lisp.
23aba0ea 2054
23aba0ea 2055 * doc.c (Fdocumentation, store_function_docstring):
03408648 2056 * data.c (Finteractive_form): Handle closures.
23aba0ea 2057
03408648
SM
2058 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2059 interactive spec.
ba83908c 2060
04f2d78b
CB
2061 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
2062 New byte-codes.
03408648
SM
2063 (exec_byte_code): New function extracted from Fbyte_code to handle new
2064 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 2065
03408648 2066 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 2067
03408648 2068 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 2069
e2abce01
JB
20702011-03-31 Juanma Barranquero <lekktu@gmail.com>
2071
2072 * xdisp.c (redisplay_internal): Fix prototype.
2073
63696a73 20742011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 2075
63696a73 2076 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
2077 (try_scrolling): Use it when setting scroll_limit.
2078 Limit scrolling to 100 screen lines.
63696a73
EZ
2079 (redisplay_window): Even when falling back on "recentering",
2080 position point in the window according to scroll-conservatively,
2081 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2082
2083 (try_scrolling): When point is above the window, allow searching
2084 as far as scroll_max, or one screenful, to compute vertical
2085 distance from PT to the scroll margin position. This prevents
2086 try_scrolling from unnecessarily failing when
2087 scroll-conservatively is set to a value slightly larger than the
2088 window height. Clean up the case of PT below the margin at bottom
2089 of window: scroll_max can no longer be INT_MAX. When aggressive
2090 scrolling is in use, don't let point enter the opposite scroll
2091 margin as result of the scroll.
2092 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
2093 threshold of 100 lines for never-recentering scrolling.
2094
e4cc2dfc
JB
20952011-03-31 Juanma Barranquero <lekktu@gmail.com>
2096
2097 * dispextern.h (move_it_by_lines):
2098 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2099 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2100 (message_log_check_duplicate): Remove parameters `prev_bol' and
2101 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2102 (redisplay_internal): Remove parameter `preserve_echo_area',
2103 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2104
2105 * indent.c (Fvertical_motion):
2106 * window.c (window_scroll_pixel_based, Frecenter):
2107 Don't pass `need_y_p' to `move_it_by_lines'.
2108
1c470562
SM
21092011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2110
44f230aa
SM
2111 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2112 steal a few bits to be more compact.
2113 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2114 Remove unneeded casts.
2115
1c470562
SM
2116 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2117
888adce9
ZK
21182011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2119
2120 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2121 binding" message (bug#7967).
2122
f838ed7b
PE
21232011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2124
77861b95
PE
2125 Fix more problems found by GCC 4.6.0's static checks.
2126
de6dbc14
PE
2127 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2128 Remove unused local var.
2129
f838ed7b
PE
2130 * editfns.c (Fmessage_box): Remove unused local var.
2131
792c7b2b
PE
2132 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2133 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2134 Omit unused local vars.
c499e557 2135 * window.c (shrink_windows): Omit unused local var.
b01a1c29 2136 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
2137 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2138 Omit unused local var.
2139
ba0165e1
PE
2140 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2141 Don't assume string length fits in int.
32ad8845 2142 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 2143 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 2144
3c59b4c9
PE
2145 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2146 instead of alloca (Bug#8344).
2147
a3eed478 2148 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 2149 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 2150
eb4d412d
PE
2151 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2152
1658b401
PE
2153 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2154 concerns.
2155
2156 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2157
2158 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 2159
9a2c6e05
PE
2160 * keyboard.c (syms_of_keyboard): Use the same style as later
2161 in this function when indexing through an array. This also
2162 works around GCC bug 48267.
2163
03d0a109
PE
2164 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2165
44f730c8
PE
2166 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2167
fe75f926
PE
2168 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2169 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2170
ffa8c828
PE
2171 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2172 This avoids undefined behavior on integer overflow, and is a bit
2173 more convenient anyway since it is compared to a size_t variable.
2174
c5101a77
PE
2175 Variadic C functions now count arguments with size_t, not int.
2176 This avoids an unnecessary limitation on 64-bit machines, which
2177 caused (substring ...) to crash on large vectors (Bug#8344).
2178 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2179 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 2180 All variadic functions and their callers changed accordingly.
c5101a77
PE
2181 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2182 * data.c (arith_driver, float_arith_driver): Likewise.
2183 * editfns.c (general_insert_function): Likewise.
2184 * eval.c (struct backtrace.nargs, interactive_p)
2185 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2186 (funcall_lambda, mark_backtrace): Likewise.
2187 * fns.c (concat): Likewise.
2188 * frame.c (x_set_frame_parameters): Likewise.
2189 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2190 0 if not found, not -1. All callers changed.
2191
dd3f25f7
PE
2192 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2193 (stack_copy_size): Now size_t, not int.
2194 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2195
461c2ab9
JB
21962011-03-28 Juanma Barranquero <lekktu@gmail.com>
2197
2198 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2199 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2200 All callers changed.
2201
2202 * lisp.h (multibyte_char_to_unibyte):
2203 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2204 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2205 * character.h (CHAR_TO_BYTE8):
2206 * cmds.c (internal_self_insert):
2207 * editfns.c (general_insert_function):
2208 * keymap.c (push_key_description):
2209 * search.c (Freplace_match):
2210 * xdisp.c (message_dolog, set_message_1): All callers changed.
2211
f6d62986
SM
22122011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2213
2214 * keyboard.c (safe_run_hook_funcall): New function.
2215 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2216 don't set the hook to nil, but remove the offending function instead.
2217 (Qcommand_hook_internal): Remove, unused.
2218 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2219 Vcommand_hook_internal.
2220
2221 * eval.c (enum run_hooks_condition): Remove.
2222 (funcall_nil, funcall_not): New functions.
2223 (run_hook_with_args): Call each function through a `funcall' argument.
2224 Remove `cond' argument, now redundant.
2225 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2226 (Frun_hook_with_args_until_failure): Adjust accordingly.
2227 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2228
1db5b1ad
JB
22292011-03-28 Juanma Barranquero <lekktu@gmail.com>
2230
2231 * dispextern.h (string_buffer_position): Remove declaration.
2232
2233 * print.c (strout): Remove parameter `multibyte', unused since
2234 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2235
2236 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2237 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2238 All callers changed.
2239
2240 * w32.c (_wsa_errlist): Use braces for struct initializers.
2241
2242 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2243 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2244 All callers changed.
2245 (string_buffer_position): Likewise. Also, make static (it's never
2246 used outside xdisp.c).
2247 (cursor_row_p): Remove parameter `w', unused since
2248 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2249 (decode_mode_spec): Remove parameter `precision', introduced during
2250 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2251 All callers changed.
2252
5ffb62aa
JD
22532011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2254
2255 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2256
461c2ab9 22572011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
2258
2259 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2260 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2261 (ns_update_auto_hide_menu_bar): New functions.
2262 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2263 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2264 ns_constrain_all_frames.
2265 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2266 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2267
5c380ffb
JD
22682011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2269
2270 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2271
9af30bdf
GM
22722011-03-27 Glenn Morris <rgm@gnu.org>
2273
2274 * syssignal.h: Replace RETSIGTYPE with void.
2275 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2276 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2277 Replace SIGTYPE with void everywhere.
2278 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2279 * s/template.h (SIGTYPE): Remove commented out definition.
2280
e2abce01
JB
22812011-03-26 Eli Zaretskii <eliz@gnu.org>
2282
2283 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2284 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2285
f868cd8a
JB
22862011-03-26 Juanma Barranquero <lekktu@gmail.com>
2287
59eb0929
JB
2288 * w32.c (read_unc_volume): Use parameter `henum', instead of
2289 global variable `wget_enum_handle'.
2290
2291 * keymap.c (describe_vector): Remove parameters `indices' and
2292 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2293 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2294
f868cd8a
JB
2295 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2296
2297 * keyboard.c (timer_check): Remove parameter `do_it_now',
2298 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2299 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
2300 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
2301
2302 * keyboard.c (read_char):
2303 * w32menu.c (w32_menu_display_help):
2304 * xmenu.c (show_help_event, menu_help_callback):
2305 Adjust calls to `show_help_echo'.
2306
2307 * gtkutil.c (xg_maybe_add_timer):
2308 * keyboard.c (readable_events):
2309 * process.c (wait_reading_process_output):
2310 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
2311
2312 * insdel.c (adjust_markers_gap_motion):
2313 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
2314 (gap_left, gap_right): Don't call it.
2315
2ecf6fdb
CY
23162011-03-25 Chong Yidong <cyd@stupidchicken.com>
2317
2318 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
2319 incurred during fontification.
2320
6b1f9ba4
JB
23212011-03-25 Juanma Barranquero <lekktu@gmail.com>
2322
2323 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
2324 (DEFVAR_PER_BUFFER): Don't pass it.
2325
2326 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
2327 (scrolling_window): Don't pass it.
2328
0f4a96b5
JB
23292011-03-25 Juanma Barranquero <lekktu@gmail.com>
2330
2331 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
2332
2333 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
2334 and `suffix'.
2335 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2336 of variables specific to SELinux and computation of `encoded_absname'.
2337
2338 * image.c (XPutPixel): Remove unused variable `height'.
2339
2340 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
2341
2342 * unexw32.c (get_section_info): Remove unused variable `section'.
2343
2344 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2345 (system_process_attributes): Remove unused variable `sess'.
2346 (sys_read): Remove unused variable `err'.
2347
2348 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2349 (w32_wnd_proc): Remove unused variable `isdead'.
2350 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2351 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2352 (x_create_tip_frame): Remove unused variable `tem'.
2353
2354 * w32inevt.c (w32_console_read_socket):
2355 Remove unused variable `no_events'.
2356
2357 * w32term.c (x_draw_composite_glyph_string_foreground):
2358 Remove unused variable `width'.
2359
1149507c
JB
23602011-03-24 Juanma Barranquero <lekktu@gmail.com>
2361
2362 * w32term.c (x_set_glyph_string_clipping):
2363 Don't pass uninitialized region to CombineRgn.
2364
9c88f339
JB
23652011-03-23 Juanma Barranquero <lekktu@gmail.com>
2366
2367 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2368 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2369 (Fx_close_connection): Remove unused variable `i'.
2370
2371 * w32font.c (w32font_draw): Return number of glyphs.
2372 (w32font_open_internal): Remove unused variable `i'.
2373 (w32font_driver): Add missing initializer.
2374
2375 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2376 (fill_in_menu): Remove unused variable `items_added'.
2377
2378 * w32term.c (last_mouse_press_frame): Remove static global variable.
2379 (w32_clip_to_row): Remove unused variable `f'.
2380 (x_delete_terminal): Remove unused variable `i'.
2381
2382 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2383 (NOTHING): Remove unused static global variable.
2384 (uniscribe_check_otf): Remove unused variable `table'.
2385 (uniscribe_font_driver): Add missing initializers.
2386
dee091a3
JD
23872011-03-23 Julien Danjou <julien@danjou.info>
2388
2389 * term.c (Fsuspend_tty, Fresume_tty):
2390 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2391 * window.c (temp_output_buffer_show):
2392 * insdel.c (signal_before_change):
2393 * frame.c (Fhandle_switch_frame):
2394 * fileio.c (Fdo_auto_save):
2395 * emacs.c (Fkill_emacs):
2396 * editfns.c (save_excursion_restore):
2397 * cmds.c (internal_self_insert):
2398 * callint.c (Fcall_interactively):
2399 * buffer.c (Fkill_all_local_variables):
2400 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2401 Use Frun_hooks.
0f4a96b5 2402 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
2403 unconditionnaly since it does the check itself.
2404
2c520ab5 24052011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 2406
c9c49752
PE
2407 Fix more problems found by GCC 4.5.2's static checks.
2408
8abc3f12
PE
2409 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2410 the first time through the loop, since we know p0 < p1 then.
2411 This also avoids a gcc -Wstrict-overflow warning.
2412
a2d26660
PE
2413 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2414 leading to a memory leak, possible in functions like
2415 load_charset_map_from_file that can allocate an unbounded number
b12ef411 2416 of objects (Bug#8318).
a2d26660 2417
916c72e9
PE
2418 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2419 that could (at least in theory) be that large.
2420
19ab8a18
PE
2421 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2422 This is less likely to overflow, and avoids undefined behavior if
2423 overflow does occur. All callers changed. Use strtoul to scan
2424 for the unsigned long integer.
b7cbbd6f
PE
2425 (pint2hrstr): Simplify and tune code slightly.
2426 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 2427
f0641eff
PE
2428 * scroll.c (do_scrolling): Work around GCC bug 48228.
2429 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2430
7f650bb9
PE
2431 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2432 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
2433 (validate_x_resource_name): Simplify count usage.
2434 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 2435
37dd57d1
PE
2436 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2437 fail (Bug#8306).
81e56e61 2438
699979fc 2439 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 2440
401bf9b4
PE
2441 * process.c (Fmake_network_process): Use socklen_t, not int,
2442 where POSIX says socklen_t is required in portable programs.
2443 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 2444 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
2445 (Fmake_network_process, server_accept_connection):
2446 (wait_reading_process_output, read_process_output):
2447 Likewise.
2448
b93aacde
PE
2449 * process.c: Rename or move locals to avoid shadowing.
2450 (list_processes_1, Fmake_network_process):
2451 (read_process_output_error_handler, exec_sentinel_error_handler):
2452 Rename or move locals.
4dc343ee 2453 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 2454 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 2455 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 2456 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 2457 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 2458
af8a867c 2459 Make tparam.h and terminfo.c consistent.
44f230aa
SM
2460 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2461 Include tparam.h instead, since it declares them.
af8a867c
PE
2462 * cm.h (PC): Remove extern decl; tparam.h now does this.
2463 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2464 * terminfo.c: Include tparam.h, to check interfaces.
2465 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2466 (tparam): Adjust signature to match interface in tparam.h;
2467 this removes some undefined behavior. Check that outstring and len
2468 are zero, which they always are with Emacs.
2469 * tparam.h (PC, BC, UP): New extern decls.
2470
0248044d 2471 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 2472 (xftfont_open): Rename locals to avoid shadowing.
0248044d 2473
8ff096c1 2474 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
2475 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
2476 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 2477 (ftfont_list): Remove unused local.
49eaafba
PE
2478 (get_adstyle_property, ftfont_pattern_entity):
2479 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
2480 Rename locals to avoid shadowing.
8ff096c1 2481
e2be39f6
PE
2482 * xfont.c (xfont_list_family): Mark var as initialized.
2483
c9735e30
PE
2484 * xml.c (make_dom): Now static.
2485
8f5201ae
PE
2486 * composite.c (composition_compute_stop_pos): Rename local to
2487 avoid shadowing.
b246f932
PE
2488 (composition_reseat_it): Remove unused locals.
2489 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 2490 (composition_update_it): Mark var as initialized.
11b61122
PE
2491 (find_automatic_composition): Mark vars as initialized,
2492 with a FIXME (Bug#8290).
8f5201ae 2493
760fbc2c
PE
2494 character.h: Rename locals to avoid shadowing.
2495 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
2496 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
2497 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
2498 (BUF_DEC_POS): Be more systematic about renaming local temporaries
2499 to avoid shadowing.
2500
ff08eb85
PE
2501 * textprop.c (property_change_between_p): Remove; unused.
2502
fc7bf025
PE
2503 * intervals.c (interval_start_pos): Now static.
2504
235d7abc
PE
2505 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
2506
44f230aa
SM
2507 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
2508 Rename locals to avoid shadowing.
3e7d6594 2509
50060332
PE
2510 * sound.c (wav_play, au_play, Fplay_sound_internal):
2511 Fix pointer signedness.
d01f234b 2512 (alsa_choose_format): Remove unused local var.
c83b8872
PE
2513 (wav_play): Initialize a variable to 0, to prevent undefined
2514 behavior (Bug#8278).
50060332 2515
c4fc4e30
PE
2516 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
2517
918436ed
PE
2518 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
2519
c939f91b
PE
2520 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
2521 clobbering (Bug#8298).
b9c7f648
PE
2522 * sysdep.c (sys_subshell): Likewise.
2523 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 2524
6bd8c144
PE
2525 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
2526 This should get cleaned up, so that child_setup has the
2527 same signature on all platforms.
2528
7710357c 2529 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 2530 (relocate_fd): Rename locals to avoid shadowing.
7710357c 2531
c59da222
CY
25322011-03-22 Chong Yidong <cyd@stupidchicken.com>
2533
2534 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
2535 not to be necessary, and produces flickering.
2536
66b87493
GM
25372011-03-20 Glenn Morris <rgm@gnu.org>
2538
2539 * config.in: Remove file.
2540
45b6f6d5
JB
25412011-03-20 Juanma Barranquero <lekktu@gmail.com>
2542
2543 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
2544 are now in src/globals.h.
2545 (syms_of_minibuf): Remove spurious & from previous change.
2546
3ec03f7e
LL
25472011-03-20 Leo <sdl.web@gmail.com>
2548
2549 * minibuf.c (completing-read-function): New variable.
2550 (completing-read-default): Rename from completing-read.
2551 (completing-read): Call completing-read-function.
2552
b14e3e21
CY
25532011-03-19 Juanma Barranquero <lekktu@gmail.com>
2554
2555 * xfaces.c (Fx_load_color_file):
2556 Read color file from absolute filename (bug#8250).
2557
f2b726e6
JB
25582011-03-19 Juanma Barranquero <lekktu@gmail.com>
2559
2560 * makefile.w32-in: Update dependencies.
2561
09f6ff02
EZ
25622011-03-17 Eli Zaretskii <eliz@gnu.org>
2563
2564 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
2565
29a6015a
PE
25662011-03-17 Paul Eggert <eggert@cs.ucla.edu>
2567
a3a6c54e
PE
2568 Fix more problems found by GCC 4.5.2's static checks.
2569
b766f867
PE
2570 * process.c (make_serial_process_unwind, send_process_trap):
2571 (sigchld_handler): Now static.
2572
be02381c
PE
2573 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
2574 That way, the code declares only the vars that it needs.
2575 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2576 * s/cygwin.h (PTY_ITERATION): Likewise.
2577 * s/darwin.h (PTY_ITERATION): Likewise.
2578 * s/gnu-linux.h (PTY_ITERATION): Likewise.
2579
57048744
PE
2580 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
2581 * process.c (allocate_pty): Don't declare stb unless it's needed.
2582
7914961c 2583 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
2584 (CONSTANTLIM): Remove; unused.
2585 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2586 Define only if needed.
7914961c 2587
b3967b18
PE
2588 * unexelf.c (unexec): Name an expression,
2589 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
2590 Use a different way to cause a compilation error if anyone uses
2591 n rather than nn, a way that does not involve shadowing.
73366a00 2592 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 2593
29a6015a
PE
2594 * deps.mk (unexalpha.o): Remove; unused.
2595
43cfc33e 2596 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 2597 * unexec.h: New file.
ce701a33
PE
2598 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
2599 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
2600 Depend on unexec.h.
2601 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
2602 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
2603 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 2604 Change as necessary to match prototype in unexec.h.
ce701a33 2605
01f44d5a
PE
2606 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
2607 shadowing.
4f63c6bb 2608 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 2609
a6670b0b
PE
2610 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
2611 Rename locals to avoid shadowing.
2612
cef2010d 2613 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 2614 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 2615
d4d7173a
PE
2616 * print.c (Fredirect_debugging_output): Fix pointer signedess.
2617
f08b802a
PE
2618 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
2619 warning when compiling print.c.
2620
3ddb0639
PE
2621 * font.c (font_unparse_fcname): Abort in an "impossible" situation
2622 instead of using an uninitialized var.
5ad03b97 2623 (font_sort_entities): Mark var as initialized.
3ddb0639 2624
170a2692
PE
2625 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
2626
e663c700
PE
2627 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
2628 pointers to constants.
89bc529a 2629 (font_parse_fcname): Remove unused vars.
7b81e2d0 2630 (font_delete_unmatched): Now static.
ea838e10 2631 (font_get_spec): Remove; unused.
13a547c6
PE
2632 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
2633 (font_update_drivers, Ffont_get_glyphs, font_add_log):
2634 Rename or move locals to avoid shadowing.
e663c700 2635
2a80c887 2636 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 2637 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 2638
1384fa33 2639 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 2640 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 2641
8b2c52e9
PE
2642 * alloc.c (mark_backtrace): Move decl from here ...
2643 * lisp.h: ... to here, so that it can be checked.
2644
475545b5 2645 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 2646 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
2647 (lisp_indirect_variable): Name an expression,
2648 to avoid gcc -Wbad-function-cast warning.
1faed8ae 2649 (Fdefvar): Rename locals to avoid shadowing.
475545b5 2650
b1349114 2651 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 2652 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 2653 Use const pointer when appropriate.
b1349114 2654
a2928364
PE
2655 * lisp.h (get_system_name, get_operating_system_release):
2656 Move decls here, to check interfaces.
2657 * process.c (get_operating_system_release): Move decl to lisp.h.
2658 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
2659 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
2660 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
2661 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
2662 (Fformat_time_string, Fencode_time, Finsert_char):
2663 (Ftranslate_region_internal, Fformat):
2664 Rename or remove local vars to avoid shadowing.
9710023e 2665 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 2666
a415e694
PE
2667 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
2668 avoid shadowing.
2669
8ef4622d
PE
2670 * lisp.h (eassert): Check that the argument compiles, even if
2671 ENABLE_CHECKING is not defined.
2672
946f9a5b
PE
2673 * data.c (Findirect_variable): Name an expression, to avoid
2674 gcc -Wbad-function-cast warning.
112396d6 2675 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 2676 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
2677 (Fmake_variable_buffer_local, Fmake_local_variable):
2678 Mark variables as initialized.
52746918 2679 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 2680
e5aab7e7 2681 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
2682 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
2683 Rename locals to avoid shadowing.
dff45157
PE
2684 (mark_stack): Move local variables into the #ifdef region where
2685 they're used.
7bc26fdb
PE
2686 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
2687 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
2688 needed otherwise.
2689 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
2690 (GC_STRING_CHARS): Remove; not used.
d40d4be1 2691 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 2692
e5aab7e7
PE
2693 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
2694 avoids undefined behavior in theory.
2695
4da60324
PE
2696 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
2697
88043301
PE
2698 Use functions, not macros, for up- and down-casing (Bug#8254).
2699 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2700 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
2701 to use the following functions instead of these macros.
2702 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
2703 EMACS_INT, since callers assume the returned value fits in int.
2704 (upcase1): Likewise, for UPCASE_TABLE.
2705 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 2706 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 2707 the race-condition problem in the old DOWNCASE.
88043301 2708
19ed5445
PE
2709 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
2710 Rename locals to avoid shadowing.
2711 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
2712 (regex_compile, re_search_2, re_match_2_internal):
2713 Remove unused local vars.
952db0d7
PE
2714 (FREE_VAR): Rewrite so as not to use empty "else",
2715 which gcc can warn about.
da053e48 2716 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
2717 (RETALLOC_IF): Define only if needed.
2718 (WORDCHAR_P): Likewise. This one is never needed, but is used
2719 only in a comment talking about a compiler bug, so put inside
2720 the #if 0 of that comment.
2721 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
2722 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
2723 Remove; unused.
19ed5445 2724
1f3561e4 2725 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
2726 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
2727 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 2728
ded6f8f7
PE
2729 * search.c (simple_search): Remove unused var.
2730
dbd37a95
PE
2731 * dired.c (compile_pattern): Move decl from here ...
2732 * lisp.h: ... to here, so that it can be checked.
2733 (struct re_registers): New forward decl.
2734
7e47afad
PE
2735 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
2736
85f24f61
PE
2737 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
2738 All uses changed.
2739 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
2740 Rename locals to avoid shadowing.
5671df8f 2741 (Fvertical_motion): Mark locals as initialized.
85f24f61 2742
181aa2be 2743 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 2744 (casify_region): Mark local as initialized.
181aa2be 2745
930d429c
PE
2746 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
2747
7082eac6
PE
2748 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
2749 New macros, so that the caller can use some names other than
2750 gcpro1, gcpro2, etc.
2751 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
2752 of the new macros.
2753 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
2754 argument, for consistency with GCPRO2_VAR, etc: it is now the
2755 prefix of the variable, not the variable itself. All uses
2756 changed.
38b2c076
PE
2757 * dired.c (directory_files_internal, file_name_completion):
2758 Rename locals to avoid shadowing.
2759
15206ed9
PE
2760 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
2761 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
2762 dired.c's scmp function, had undefined behavior.
2763 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2764 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
2765 * buffer.h: ... to here, because these macros use current_buffer,
2766 and the new implementation with inline functions needs to have
2767 current_buffer in scope now, rather than later when the macros
2768 are used.
2769 (downcase, upcase1): New static inline functions.
2770 (DOWNCASE, UPCASE1): Reimplement using these functions.
2771 This avoids undefined behavior in expressions like
2772 DOWNCASE (x) == DOWNCASE (y), which previously suffered
2773 from race conditions in accessing the global variables
2774 case_temp1 and case_temp2.
2775 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
2776 * lisp.h (case_temp1, case_temp2): Remove their decls.
2777 * character.h (ASCII_CHAR_P): Move from here ...
2778 * lisp.h: ... to here, so that the inline functions mentioned
2779 above can use them.
2780
4a6bea26
PE
2781 * dired.c (directory_files_internal_unwind): Now static.
2782
f14b7e14
PE
2783 * fileio.c (file_name_as_directory, directory_file_name):
2784 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
2785 Now static.
2893f146
PE
2786 (file_name_as_directory): Use const pointers when appropriate.
2787 (Fexpand_file_name): Likewise. In particular, newdir might
2788 point at constant storage, so make it a const pointer.
fd4ead52 2789 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
2790 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
2791 signedness issues.
f839df0c
PE
2792 (Fset_file_times, Finsert_file_contents, auto_save_error):
2793 Rename locals to avoid shadowing.
f14b7e14 2794
5716756e 2795 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
2796 (Ftry_completion, Fall_completions): Rename or remove locals
2797 to avoid shadowing.
5716756e 2798
b4c3046a
PE
2799 * marker.c (bytepos_to_charpos): Remove; unused.
2800
b45db522
PE
2801 * lisp.h (verify_bytepos, count_markers): New decls,
2802 so that gcc does not warn that these functions aren't declared.
2803
85876d07
PE
2804 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
2805 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 2806 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 2807 (copy_text): Remove unused local var.
85876d07 2808
03d78a21 2809 * filelock.c (within_one_second): Now static.
b3dd38ab 2810 (lock_file_1): Rename local to avoid shadowing.
03d78a21 2811
5df8f01b
PE
2812 * buffer.c (fix_overlays_before): Mark locals as initialized.
2813 (fix_start_end_in_overlays): Likewise. This function should be
2814 simplified by using pointers-to-pointers, but that's a different
2815 matter.
b1d876f1 2816 (switch_to_buffer_1): Now static.
8f54f30a
PE
2817 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
2818 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 2819
a70072c9 2820 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 2821 Fix pointer signedness issue.
edced198
PE
2822 (sys_subshell): Mark local as volatile if checking for lint,
2823 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 2824 (MAXPATHLEN): Define only if needed.
a70072c9 2825
a0977c44
PE
2826 * process.c (serial_open, serial_configure): Move decls from here ...
2827 * systty.h: ... to here, so that they can be checked.
2828
a884fdcc
PE
2829 * fns.c (get_random, seed_random): Move extern decls from here ...
2830 * lisp.h: ... to here, so that they can be checked.
2831
604efe86 2832 * sysdep.c (reset_io): Now static.
b8950c94 2833 (wait_for_termination_signal): Remove; unused.
604efe86 2834
38fc62d9
PE
2835 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
2836 (copy_keymap_item, append_key, push_text_char_description):
2837 Now static.
1004a21a 2838 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 2839 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
2840 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
2841 (describe_map_tree):
2842 Rename locals to avoid shadowing.
38fc62d9 2843
2f2650da
PE
2844 * keyboard.c: Declare functions static if they are not used elsewhere.
2845 (echo_char, echo_dash, cmd_error, top_level_2):
2846 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
2847 (read_char, kbd_buffer_get_event, make_lispy_position):
2848 (make_lispy_event, make_lispy_movement, apply_modifiers):
2849 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
2850 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
2851 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 2852 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 2853 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 2854
a053e86c 2855 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
2856 (mark_kboards): Move decl here ...
2857 * alloc.c (mark_kboards): ... from here.
a053e86c 2858
4752793e
PE
2859 * lisp.h (force_auto_save_soon): New decl.
2860
74f10ca7 2861 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
2862 (DEFINE_DUMMY_FUNCTION): New macro.
2863 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
2864 Use it.
c03cd23f
PE
2865 (main): Add casts to avoid warnings
2866 if GCC considers string literals to be constants.
74f10ca7 2867
022e70d4
PE
2868 * lisp.h (fatal_error_signal): Add decl, since it's exported.
2869
59d6fe83
PE
2870 * dbusbind.c: Pointer signedness fixes.
2871 (xd_signature, xd_append_arg, xd_initialize):
2872 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2873 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2874 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
2875 (Fdbus_register_signal): Use SSDATA when the context wants char *.
2876
78320123
PE
2877 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
2878 if GCC considers string literals to be constants.
49cebcca 2879 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 2880
35ac2a97
SM
28812011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
2882
fb103ca9
SM
2883 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
2884 (print_preprocess, print_object): New macro to fix last change.
2885
35ac2a97
SM
2886 * print.c (print_preprocess): Don't forget font objects.
2887
62973b41
JB
28882011-03-16 Juanma Barranquero <lekktu@gmail.com>
2889
2890 * emacs.c (USAGE3): Doc fixes.
2891
0e48bb22
AS
28922011-03-15 Andreas Schwab <schwab@linux-m68k.org>
2893
2894 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
2895 structure.
2896
7684e57b
JB
28972011-03-14 Juanma Barranquero <lekktu@gmail.com>
2898
2899 * lisp.h (VWindow_system, Qfile_name_history):
2900 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
2901 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
2902 (w32_system_caret_x, w32_system_caret_y): Declare extern.
2903
2904 * w32select.c: Don't #include "keyboard.h".
c96bbc66 2905 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
2906
2907 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
2908 * w32console.c (detect_input_pending, read_input_pending)
2909 (encode_terminal_code):
2910 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
2911 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
2912 (w32_system_caret_y, Qfile_name_history):
2913 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
2914 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
2915 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
2916 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
2917 * w32proc.c (Qlocal, report_file_error):
2918 * w32term.c (Vwindow_system, updating_frame):
2919 * w32uniscribe.c (initialized, uniscribe_font_driver):
2920 Remove unneeded extern declarations.
2921
2aa46d6c
CY
29222011-03-14 Chong Yidong <cyd@stupidchicken.com>
2923
c96bbc66 2924 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 2925
cffc6f3b
CY
29262011-03-13 Chong Yidong <cyd@stupidchicken.com>
2927
2928 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
2929 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
2930 These macros can no longer be used for assignment.
2931
44f230aa
SM
2932 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2933 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
2934 (record_buffer_markers, fetch_buffer_markers): New functions for
2935 recording and fetching special buffer markers.
2936 (set_buffer_internal_1, set_buffer_temp): Use them.
2937
2938 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
2939
2940 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
2941
2942 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
2943 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
2944
2945 * xdisp.c (hscroll_window_tree):
2946 (reconsider_clip_changes): Use PT instead of BUF_PT.
2947
d251f04b
EZ
29482011-03-13 Eli Zaretskii <eliz@gnu.org>
2949
2950 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
2951 $(EMACS_ROOT)/lib/intprops.h.
2952
f0c77cd1
PE
29532011-03-13 Paul Eggert <eggert@cs.ucla.edu>
2954
3eca4629
PE
2955 Fix more problems found by GCC 4.5.2's static checks.
2956
7c86ee98
PE
2957 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
2958 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
2959 (xg_free_frame_widgets): Make it clear that a local variable is
2960 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
2961 (gdk_window_get_screen): Make it clear that this macro is needed
2962 only if USE_GTK_TOOLTIP.
1e5524e7
PE
2963 (int_gtk_range_get_value): New function, which avoids a diagnostic
2964 from gcc -Wbad-function-cast.
2965 (xg_set_toolkit_scroll_bar_thumb): Use it.
2966 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
2967 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
2968 (get_utf8_string, xg_get_file_with_chooser):
2969 Rename locals to avoid shadowing.
2970 (create_dialog): Move locals to avoid shadowing.
7c86ee98 2971
41729b81
PE
2972 * xgselect.c (xg_select): Remove unused var.
2973
f0c77cd1
PE
2974 * image.c (four_corners_best): Mark locals as initialized.
2975 (gif_load): Initialize transparent_p to zero (Bug#8238).
2976 Mark another local as initialized.
ec6cf4c6 2977 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 2978
ce0ad53d 2979 * image.c (clear_image_cache): Now static.
d5d5a617 2980 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 2981 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
2982 (x_edge_detection): Remove unnecessary cast that
2983 gcc -Wbad-function-cast diagnoses.
2037898d 2984 (gif_load): Fix pointer signedness.
6ae141d6
PE
2985 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
2986 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 2987
33383987 29882011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 2989
d32df629
PE
2990 Improve quality of tests for time stamp overflow.
2991 For example, without this patch (encode-time 0 0 0 1 1
2992 1152921504606846976) returns the obviously-bogus value (-948597
2993 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
2994 reports time overflow. See
2995 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
2996 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
2997 * editfns.c: Include limits.h and intprops.h.
2998 (TIME_T_MIN, TIME_T_MAX): New macros.
2999 (time_overflow): Move earlier, to before first use.
3000 (hi_time, lo_time): New functions, for an accurate test for
3001 out-of-range times.
3002 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3003 (Fget_internal_run_time): Don't assume time_t fits in int.
3004 (make_time): Use list2 instead of Fcons twice.
3005 (Fdecode_time): More accurate test for out-of-range times.
3006 (check_tm_member): New function.
3007 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
3008 (lisp_time_argument): Don't rely on undefined left-shift and
3009 right-shift behavior when checking for time stamp overflow.
8be6f318 3010
fe31d94c
PE
3011 * editfns.c (time_overflow): New function, refactoring common code.
3012 (Fformat_time_string, Fdecode_time, Fencode_time):
3013 (Fcurrent_time_string): Use it.
3014
8be6f318
PE
3015 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3016 * dired.c (make_time): Move to ...
3017 * editfns.c (make_time): ... here.
3018 * systime.h: Note the move.
3019
09d9db2c 30202011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 3021
126bc0dc
YM
3022 * fringe.c (update_window_fringes): Remove unused variables.
3023
c47cbdfd
YM
3024 * unexmacosx.c (copy_data_segment): Also copy __got section.
3025 (Bug#8223)
3026
7ac80be9
EZ
30272011-03-12 Eli Zaretskii <eliz@gnu.org>
3028
c96bbc66 3029 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
3030 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3031 Constify `char *' arguments and their references according to
3032 prototypes in tparam.h.
3033
ecb0f94d 3034 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 3035
7ac80be9
EZ
3036 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3037 Adapt all references accordingly.
3038
3039 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3040
ef1fd07e
TT
30412011-03-11 Tom Tromey <tromey@redhat.com>
3042
3043 * buffer.c (syms_of_buffer): Remove obsolete comment.
3044
7ef4b50c
EZ
30452011-03-11 Eli Zaretskii <eliz@gnu.org>
3046
3047 * termhooks.h (encode_terminal_code): Declare prototype.
3048
3049 * msdos.c (encode_terminal_code): Don't declare prototype.
3050
3051 * term.c (encode_terminal_code): Now external again, used by
3052 w32console.c and msdos.c.
3053
44f230aa
SM
3054 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3055 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 3056
4b1ec863 30572011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 3058
1714f52b 3059 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 3060
4b1ec863
PE
3061 * fringe.c (update_window_fringes): Mark locals as initialized
3062 (Bug#8227).
3063 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 3064
524c7aa6
PE
3065 * alloc.c (mark_fringe_data): Move decl from here ...
3066 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3067 to check its interface.
3068 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3069
a5c0af81 3070 * fontset.c (free_realized_fontset): Now static.
7519b8cd 3071 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 3072 (fontset_font): Mark local as initialized.
a9a06e0b 3073 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 3074
b4716021
PE
3075 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3076
811e9bac 3077 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 3078 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
3079 (x_own_selection, Fx_disown_selection_internal): Rename locals
3080 to avoid shadowing.
3081 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 3082
7e3ab302
PE
3083 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3084 so that the caller can use some name other than gcpro1.
3085 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
3086 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3087 (Fx_backspace_delete_keys_p):
3088 Use them to avoid shadowing, and rename vars to avoid shadowing.
3089 (x_decode_color, x_set_name, x_window): Now static.
6b437900 3090 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 3091 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
3092 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3093 Remove unused locals.
7e3ab302
PE
3094 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3095 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3096 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3097 macros.
f78faa98 3098
e2b13473
PE
3099 * xterm.h (x_mouse_leave): New decl.
3100
77f23912
PE
3101 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3102 Remove unused functions.
cdf4ba58
PE
3103 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3104 (x_calc_absolute_position): Now static.
7411c686 3105 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 3106 Don't declare local "event" unless it's used.
ed7bf3a5
PE
3107 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3108 unless they are used.
38d0b34a
PE
3109 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3110 (x_fatal_error_signal): Remove; not used.
a6067996
PE
3111 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3112 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3113 (x_error_catcher, x_connection_closed, x_error_handler):
3114 (x_error_quitter, xembed_send_message, x_iconify_frame):
3115 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 3116 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 3117 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 3118
44f230aa
SM
3119 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3120 Rename or move locals to avoid shadowing.
6b463e58 3121 (tty_defined_color, merge_face_heights): Now static.
5967d051 3122 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
3123 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3124 does not deduce is never used uninitialized.
73719eba
PE
3125 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3126 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 3127
426994c3 3128 * terminal.c (store_terminal_param): Now static.
5489860b 3129
032f1620 3130 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 3131 (set_frame_menubar): Remove unused local.
d4323972 3132 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
3133 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3134 since they might point to immutable storage.
281585b0
PE
3135 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3136 since it's unused otherwise.
032f1620 3137
367c19e5 3138 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 3139 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
3140 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3141 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 3142 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
3143 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3144 does not deduce are never used uninitialized.
70739cbe 3145
07b48fa9
PE
3146 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3147
8868a238 3148 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
3149 * window.c (window_loop, size_window):
3150 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 3151
7e5cf297 3152 * window.c (display_buffer): Now static.
d6550a9f
PE
3153 (size_window): Mark variables that gcc -Wuninitialized
3154 does not deduce are never used uninitialized.
a586633d
PE
3155 * window.h (check_all_windows): New decl, to forestall
3156 gcc -Wmissing-prototypes diagnostic.
5b555da1 3157 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 3158
f6095868
PE
3159 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3160 shadowing.
3161 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
3162 Include <limits.h>.
3163 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3164 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
3165 (load_charset_map): Mark variables that gcc -Wuninitialized
3166 does not deduce are never used uninitialized.
53df7c11 3167 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 3168
f38b440c
PE
3169 * coding.c (coding_set_source, coding_set_destination):
3170 Use "else { /* comment */ }" rather than "else /* comment */;"
3171 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
3172 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3173 a block, when the outer 'i' will do.
3174 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3175 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3176 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3177 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3178 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3179 Rename locals to avoid shadowing.
3180 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
3181 * coding.c (emacs_mule_char, encode_invocation_designation):
3182 Now static, since they're not used elsewhere.
413bb2db 3183 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 3184 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
3185 (decode_coding_emacs_mule): Mark variables that gcc
3186 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
3187 (detect_coding_iso_2022): Initialize a local variable that might
3188 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 3189 this initialization is needed. (Bug#8211)
5f58e762
PE
3190 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3191 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3192 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3193 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3194 Remove unused macros.
f38b440c 3195
232b38b9 3196 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 3197 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 3198 * character.c (string_count_byte8): Likewise.
232b38b9 3199
fb90da1b
PE
3200 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3201 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3202
fb93dbc2
PE
3203 * chartab.c (copy_sub_char_table): Now static, since it's not used
3204 elsewhere.
5c156ace
PE
3205 (sub_char_table_ref_and_range, char_table_ref_and_range):
3206 Rename locals to avoid shadowing.
bbcd0949 3207 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 3208
7d3b3862 3209 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 3210 (BIDI_BOB): Remove unused macro.
7d3b3862 3211
6be7d3da
PE
3212 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3213 deduce are never used uninitialized.
c2ed9c8b 3214 * term.c (encode_terminal_code): Likewise.
6be7d3da 3215
75f8807f 3216 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 3217
50938595
PE
3218 * tparam.h: New file.
3219 * term.c, tparam.h: Include it.
3220 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3221 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3222 Move these decls to tparam.h, and make them agree with what
3223 is actually in tparam.c. The previous trick of using incompatible
3224 decls in different modules does not conform to the C standard.
3225 All callers of tparam changed to use tparam's actual API.
3226 * tparam.c (tparam1, tparam, tgoto):
3227 Use const pointers where appropriate.
3228
fbceeba2
PE
3229 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3230 * cm.h (struct cm): Likewise.
3231 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3232 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3233 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3234 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3235 (turn_on_face, init_tty): Likewise.
3236 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 3237
7f3f1250
PE
3238 * term.c (term_mouse_position): Rename local to avoid shadowing.
3239
e6ca6543
PE
3240 * alloc.c (mark_ttys): Move decl from here ...
3241 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3242
c40f8d15
AS
32432011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3244
3245 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3246
cfe0661d
JB
32472011-03-09 Juanma Barranquero <lekktu@gmail.com>
3248
3249 * search.c (compile_pattern_1): Remove argument regp, unused since
3250 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3251 (compile_pattern): Don't pass it.
3252
0afb4571
J
32532011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3254
3255 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3256 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3257 for ! HAVE_GTK3.
3258 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3259
3260 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3261
3262 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3263 gdk_window_get_screen, gdk_window_get_geometry,
3264 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3265 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3266 (xg_get_pixbuf_from_pixmap): New function.
3267 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3268 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3269 Call xg_get_pixbuf_from_pixmap instead of
3270 gdk_pixbuf_get_from_drawable.
3271 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3272 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3273 (xg_check_special_colors): Use GtkStyleContext and its functions
3274 for HAVE_GTK3.
3275 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3276 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3277 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
3278 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3279 Call gtk_widget_get_preferred_size.
0afb4571
J
3280 (xg_frame_resized): gdk_window_get_geometry only takes 5
3281 parameters.
44f230aa
SM
3282 (xg_win_to_widget, xg_event_is_for_menubar):
3283 Call gdk_x11_window_lookup_for_display.
0afb4571
J
3284 (xg_set_widget_bg): New function.
3285 (delete_cb): New function.
895009e1 3286 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
3287 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3288 (xg_set_background_color): Call xg_set_widget_bg.
3289 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3290 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3291 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3292 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3293 if ! HAVE_GTK3.
3294 (update_frame_tool_bar): Call gtk_widget_hide.
3295 (xg_initialize): Use GDK_KEY_g.
3296
3297 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3298 if ! HAVE_GTK3
3299 (x_session_initialize): Call gdk_x11_set_sm_client_id.
3300
3301 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
3302 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
3303 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
3304
1c2cc4ef
JB
33052011-03-08 Juanma Barranquero <lekktu@gmail.com>
3306
3307 * w32xfns.c (select_palette): Check success of RealizePalette against
3308 GDI_ERROR, not zero.
3309
33383987 3310See ChangeLog.11 for earlier changes.
aac0c6e3
MR
3311
3312;; Local Variables:
3313;; coding: utf-8
aac0c6e3
MR
3314;; End:
3315
33383987 3316 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
3317
3318 This file is part of GNU Emacs.
3319
3320 GNU Emacs is free software: you can redistribute it and/or modify
3321 it under the terms of the GNU General Public License as published by
3322 the Free Software Foundation, either version 3 of the License, or
3323 (at your option) any later version.
3324
3325 GNU Emacs is distributed in the hope that it will be useful,
3326 but WITHOUT ANY WARRANTY; without even the implied warranty of
3327 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3328 GNU General Public License for more details.
3329
3330 You should have received a copy of the GNU General Public License
3331 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.