* xmenu.c (xmenu_show, xdialog_show): Explicit cast from
[bpt/emacs.git] / src / ChangeLog
CommitLineData
b00876c9
DA
12012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2
3 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
4 `const char *' to `char *' to avoid compiler warning.
5
d188e26b
PE
62012-06-24 Paul Eggert <eggert@cs.ucla.edu>
7
885d1d74
PE
8 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
9 instead of truncating it to 63 (admittedly a generous limit).
10
d188e26b
PE
11 * process.c: Fix spelling and caps in comments.
12
e2f560b1
DN
132012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
14
e86db54b 15 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
16 * sysdep.c (setpgrp): Remove definition, not used in this file.
17
7583a3a1
JB
182012-06-24 Juanma Barranquero <lekktu@gmail.com>
19
20 * makefile.w32-in: Update dependencies.
21
696056c2
EZ
222012-06-24 Eli Zaretskii <eliz@gnu.org>
23
24 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
25 (SYSTIME_H): Add nt/inc/sys/time.h.
26
27 * systime.h [WINDOWSNT]: Include sys/time.h.
28
29 * s/ms-w32.h (struct timespec): Definition moved from
30 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
31
845ca893
PE
322012-06-24 Paul Eggert <eggert@cs.ucla.edu>
33
34 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
35 * buffer.h (buffer_slot_type_mismatch):
36 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
37 * eval.c (unwind_to_catch):
38 * image.c (my_png_error, my_error_exit):
39 * keyboard.c (quit_throw_to_read_char, user_error)
40 (Fexit_recursive_edit, Fabort_recursive_edit):
41 * lisp.h (die, args_out_of_range, args_out_of_range_3)
42 (wrong_type_argument, buffer_overflow, __executable_start)
43 (memory_full, buffer_memory_full, string_overflow, Fthrow)
44 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
45 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
46 (fatal):
47 (child_setup) [!DOS_NT]:
48 * lread.c (end_of_file_error, invalid_syntax):
49 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
50 * puresize.h (pure_write_error):
51 * search.c (matcher_overflow):
52 * sound.c (sound_perror, alsa_sound_perror):
53 * sysdep.c, syssignal.h (croak):
54 * term.c (maybe_fatal, vfatal):
55 * textprop.c (text_read_only):
56 * undo.c (user_error):
57 * unexmacosx.c (unexec_error):
58 * xterm.c (x_ins_del_lines, x_delete_glyphs):
59 Use _Noreturn rather than NO_RETURN.
60 No need for separate decl merely because of _Noreturn.
61 * sound.c (sound_warning, parse_sound):
62 Remove unnecessary forward decls.
63
f1dd8073
PE
642012-06-24 Paul Eggert <eggert@cs.ucla.edu>
65
66 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
67 * lisp.h (WAIT_READING_MAX): New macro.
68 * dispnew.c (Fsleep_for, sit_for):
69 * keyboard.c (kbd_buffer_get_event):
70 * process.c (Faccept_process_output):
71 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
72 This improves on the previous patch, which introduced a bug
73 when time_t is unsigned and as wide as intmax_t.
74 See <http://bugs.gnu.org/9000#51>.
75
b82c1755
EZ
762012-06-23 Eli Zaretskii <eliz@gnu.org>
77
78 * dispnew.c (sit_for, Fsleep_for):
79 * keyboard.c (kbd_buffer_get_event):
80 * process.c (Faccept_process_output): Avoid compiler warnings when
81 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
82
ca300656
JB
832012-06-23 Juanma Barranquero <lekktu@gmail.com>
84
049ec95b
JB
85 * makefile.w32-in: Update dependencies.
86
ca300656
JB
87 * w32.c (ltime): Add return type and declare static.
88 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
89
db7b8d06
PE
902012-06-23 Paul Eggert <eggert@cs.ucla.edu>
91
92 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
93 Privately reported by Herbert J. Skuhra.
94 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
95 All uses changed.
96 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
97 not make_lisp_timeval, when the argument is of type EMACS_TIME.
98
0bd8297f
EZ
992012-06-23 Eli Zaretskii <eliz@gnu.org>
100
96512555
EZ
101 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
102 last argument of make_unibyte_string.
103
0bd8297f
EZ
104 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
105 language ID in the event parameters.
106
107 * w32term.c (w32_read_socket): Put the new keyboard codepage into
108 event.code, not the obscure "character set ID".
109
63def6b6
CY
1102012-06-23 Chong Yidong <cyd@gnu.org>
111
112 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
113
e8a02204
EZ
1142012-06-23 Eli Zaretskii <eliz@gnu.org>
115
388cdec0
EZ
116 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
117 * w32.c (fdutimens): New function.
118
119 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
120
121 * s/ms-w32.h (pselect): Redirect to sys_select.
122
123 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
124
e8a02204
EZ
125 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
126 in the logic of incrementing and decrementing the value of
127 use_relocatable_buffers.
128
d054f3fb
PE
1292012-06-23 Paul Eggert <eggert@cs.ucla.edu>
130
131 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
132 Privately reported by Herbert J. Skuhra.
133 [__FreeBSD__]: Remove "*/" typo after "#include".
134 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
135 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
136 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
137 Don't assume EMACS_TIME and struct timeval are the same type.
138
d35af63c
PE
1392012-06-22 Paul Eggert <eggert@cs.ucla.edu>
140
141 Support higher-resolution time stamps (Bug#9000).
142 The time stamps are only nanosecond-resolution at the C level,
143 since that's the best that any real-world system supports now.
144 But they are picosecond-resolution at the Lisp level, as that's
145 easy, and leaves room for future OS improvements.
146
147 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
148 (LIBES): Use it.
149
150 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
151 Don't get current time unless it's needed.
152
153 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
154 now provides it if it's absent.
155 (start_atimer): Port to higher-res time stamps.
156 Check for time stamp overflow. Don't get current time more
157 often than is needed.
158
159 * buffer.h (struct buffer): Buffer modtime now has high resolution.
160 Include systime.h, not time.h.
161 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
162
163 * dired.c: Include stat-time.h.
164 (Ffile-attributes): File times now have higher resolution.
165
166 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
167 (struct image): Timestamp now has higher resolution.
168
169 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
170 has at least microseconds now. All uses removed.
171 (update_frame, update_single_window, update_window, update_frame_1)
172 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
173
174 * editfns.c (time_overflow): Now extern.
175 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
176 (float-time, Fformat_time_string, Fcurrent_time_string)
177 (Fcurrent_time_zone): Accept and generate higher-resolution
178 time stamps.
179 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
180 (decode_time_components, lisp_seconds_argument): New functions.
181 (make_time): Now static.
182 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
183 Report an error if the time is invalid, rather than having the caller
184 do that.
185
186 * fileio.c: Include <stat-time.h>
187 (Fcopy_file): Copy higher-resolution time stamps.
188 Prefer to set the time stamp via a file descriptor if that works.
189 (Fset_file_times, Finsert_file_contents, Fwrite_region)
190 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
191 (Fvisited_file_modtime, Fset_visited_file_modtime):
192 Support higher-resolution time stamps.
193
194 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
195
196 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
197
198 * image.c (prepare_image_for_display, clear_image_cache)
199 (lookup_image): Port to higer-resolution time stamps.
200
201 * keyboard.c (start_polling, bind_polling_period):
202 Check for time stamp overflow.
203 (read_char, kbd_buffer_get_event, timer_start_idle)
204 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
205 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
206 Port to higher-resolution time stamps. Do not assume time_t is signed.
207 (decode_timer): New function. Timers are now vectors of length 9,
208 not 8, to accommodate the picosecond component.
209 (timer_check_2): Use it.
210
211 * nsterm.m (select_timeout, timeval_subtract): Remove.
212 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
213 as they're a bit more accurate and handle overflow better.
214 (ns_select): Change prototype to be compatible with pselect.
215 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
216 * nsterm.h (ns_select): Adjust prototype.
217
218 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
219 us-resolution time stamps.
220 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
221
222 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
223
224 * lisp.h (time_overflow): New decl.
225 (wait_reading_process_output): First arg is now intmax_t, not int,
226 to accommodate larger waits.
227
228 * process.h (struct Lisp_Process.read_output_delay):
229 Now counts nanoseconds, not microseconds.
230 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
231 EMACS_HAS_USECS.
232 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
233 (wait_reading_process_output):
234 Port to ns-resolution time stamps.
235 (Faccept_process_output, wait_reading_process_output):
236 Check for time stamp overflow. Do not assume time_t is signed.
237 (select_wrapper): Remove; we now use pselect.
238 (Fprocess_attributes): Now generates ns-resolution time stamps.
239
240 * sysdep.c: Include utimens.h. Don't include utime.h
241 or worry about struct utimbuf; gnulib does that for us now.
242 (gettimeofday): Remove; gnulib provides a substitute.
243 (make_timeval): New function.
244 (set_file_times): Now sets ns-resolution time stamps.
245 New arg FD; all uses changed.
246 (time_from_jiffies, ltime_from_jiffies, get_up_time)
247 (system_process_attributes):
248 Now returns ns-resolution time stamp. All uses changed.
249 Check for time stamp overflow.
250
251 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
252 provides a substitute now.
253
254 * systime.h: Include timespec.h rather than sys/time.h and time.h,
255 since it guarantees struct timespec.
256 (EMACS_TIME): Now struct timespec, so that we can support
257 ns-resolution time stamps.
258 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
259 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
260 (EMACS_USECS): Remove.
261 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
262 so multiply the arg by 1000 before storing it.
263 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
264 New macros.
265 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
266 Port to ns-resolution time stamps.
267 (EMACS_TIME_NEG_P): Remove; replaced by....
268 (EMACS_TIME_SIGN): New macro.
269 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
270 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
271 (set_file_times, make_time, lisp_time_argument): Adjust signature.
272 (make_timeval, make_lisp_time, decode_time_components): New decls.
273 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
274 that it mishandled time_t overflow. You can't compare by subtracting!
275 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
276 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
277
278 * term.c: Include <sys/time.h>.
279 (timeval_to_Time): New function, for proper overflow wraparound.
280 (term_mouse_position, term_mouse_click): Use it.
281
282 * undo.c (record_first_change): Support higher-resolution time stamps
283 in the undo buffer.
284 (Fprimitive_undo): Use them when restoring time stamps.
285
286 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
287 (w32_get_internal_run_time):
288 Port to higher-resolution Emacs time stamps.
289 (ltime): Now accepts single 64-bit integer, as that's more convenient
290 for callers.
291
292 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
293
294 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
295 for compatibility with pselect. Support ns-resolution time stamps.
296
297 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
298
299 * xselect.c (wait_for_property_change, x_get_foreign_selection):
300 Check for time stamp overflow, and support ns-resolution time stamps.
301
302 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
303 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
304 (timeval_subtract): Remove; no longer needed.
305 (XTflash, XTring_bell, x_wait_for_event):
306 Port to ns-resolution time stamps. Don't assume time_t is signed.
307
b6a92dfe
CY
3082012-06-22 Chong Yidong <cyd@gnu.org>
309
310 * xdisp.c (x_consider_frame_title): Revert last change.
311
d251c37c
EZ
3122012-06-22 Eli Zaretskii <eliz@gnu.org>
313
314 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
315 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
316 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
317 staticidx goes up to 1597 out of 1600 = 0x640.)
318
f10deafb
PE
3192012-06-20 Paul Eggert <eggert@cs.ucla.edu>
320
321 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
322 Otherwise, the umask might be mistakenly 0 while handling input signals.
323
ec6de1e2
SM
3242012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
325
326 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
327
28be1ada
DA
3282012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
329
330 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
331 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
332 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
333 access to `contents' member of Lisp_Vector objects with AREF and ASET
334 where appropriate.
335
c6bf3022
CY
3362012-06-19 Chong Yidong <cyd@gnu.org>
337
338 * frame.c (delete_frame): When selecting a frame on a different
339 text terminal, do not alter the terminal's top-frame.
340
341 * xdisp.c (format_mode_line_unwind_data): Record the target
342 frame's selected window and its terminal's top-frame.
343 (unwind_format_mode_line): Restore them.
344 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
345 Callers changed.
346 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
347 since tty frames can be explicitly named.
348 (prepare_menu_bars): Likewise.
349
350 * term.c (Ftty_top_frame): New function.
351
defd4196
PE
3522012-06-18 Paul Eggert <eggert@cs.ucla.edu>
353
354 Port byte-code-meter to modern targets.
355 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
356 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 357 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
358 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
359 (METER_1, METER_2): Simplify.
360
1053a871
SM
3612012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
362
363 * data.c (Fdefalias): Return `symbol' (bug#11686).
364
b7e8d081
MR
3652012-06-18 Martin Rudalics <rudalics@gmx.at>
366
367 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
368 gets killed during executing of this function (Bug#11665).
369 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
370 (Vkill_buffer_query_functions): In doc-string say that functions
371 run by this hook should not change the current buffer.
372
7ea2b339
PE
3732012-06-18 Paul Eggert <eggert@cs.ucla.edu>
374
375 Fix recently-introduced process.c problems found by static checking.
376 * process.c (write_queue_push, write_queue_pop, send_process):
377 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
378 (write_queue_pop): Fix pointer signedness problem.
379 (send_process): Remove unused local.
380
96a313a1
CY
3812012-06-17 Chong Yidong <cyd@gnu.org>
382
383 * xdisp.c (redisplay_internal): No need to redisplay terminal
384 frames that are not on top.
385
20ca2e94
TN
3862012-06-17 Troels Nielsen <bn.troels@gmail.com>
387
388 * process.c (make_process): Initialize write_queue.
389 (write_queue_push, write_queue_pop): New functions.
390 (send_process): Use them to maintain correct ordering of process
391 writes (Bug#10815).
392
9a900ca9
PE
3932012-06-17 Paul Eggert <eggert@cs.ucla.edu>
394
310fbfa8
PE
395 * lisp.h (eassert): Assume C89 or later.
396 This removes the need for CHECK.
397 (CHECK): Remove. Its comments about always evaluating its
398 argument were confusing, as 'eassert' typically does not evaluate
399 its argument.
400
27bb1ca4
PE
401 * coding.c (produce_chars): Use ptrdiff_t, not int.
402
9a900ca9
PE
403 * xterm.c (x_draw_underwave): Check for integer overflow.
404 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
405
41b7f8bc 4062012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
407
408 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
409 referenced (Bug#11583).
410
9b0e3eba
AA
4112012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
412
413 Implement wave-style variant of underlining.
414 * dispextern.h (face_underline_type): New enum.
415 (face): Add field for underline type.
416 * nsterm.m (ns_draw_underwave): New function.
417 (ns_draw_text_decoration): Use it.
418 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
419 New functions.
420 (x_draw_glyph_string): Use them.
421 * xfaces.c (Qline, Qwave): New Lisp objects.
422 (check_lface_attrs, merge_face_ref)
1053a871
SM
423 (Finternal_set_lisp_face_attribute, realize_x_face):
424 Handle wave-style underline face attributes.
9b0e3eba
AA
425 * xterm.c (x_draw_underwave): New function.
426 (x_draw_glyph_string): Use it.
427
0fb52f11
JB
4282012-06-16 Juanma Barranquero <lekktu@gmail.com>
429
430 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
431 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
432 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
433 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
434 ($(BLD)/w32select.$(O)): Update dependencies.
435
e5560ff7
AS
4362012-06-16 Andreas Schwab <schwab@linux-m68k.org>
437
438 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
439 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
440 * character.c (_fetch_multibyte_char_p): Remove.
441 * alloc.c: Include "character.h" before "buffer.h".
442 * bidi.c: Likewise.
443 * buffer.c: Likewise.
444 * bytecode.c: Likewise.
445 * callint.c: Likewise.
446 * callproc.c: Likewise.
447 * casefiddle.c: Likewise.
448 * casetab.c: Likewise.
449 * category.c: Likewise.
450 * cmds.c: Likewise.
451 * coding.c: Likewise.
452 * composite.c: Likewise.
453 * dired.c: Likewise.
454 * dispnew.c: Likewise.
455 * doc.c: Likewise.
456 * dosfns.c: Likewise.
457 * editfns.c: Likewise.
458 * emacs.c: Likewise.
459 * fileio.c: Likewise.
460 * filelock.c: Likewise.
461 * font.c: Likewise.
462 * fontset.c: Likewise.
463 * fringe.c: Likewise.
464 * indent.c: Likewise.
465 * insdel.c: Likewise.
466 * intervals.c: Likewise.
467 * keyboard.c: Likewise.
468 * keymap.c: Likewise.
469 * lread.c: Likewise.
470 * macros.c: Likewise.
471 * marker.c: Likewise.
472 * minibuf.c: Likewise.
473 * nsfns.m: Likewise.
474 * nsmenu.m: Likewise.
475 * print.c: Likewise.
476 * process.c: Likewise.
477 * regex.c: Likewise.
478 * region-cache.c: Likewise.
479 * search.c: Likewise.
480 * syntax.c: Likewise.
481 * term.c: Likewise.
482 * textprop.c: Likewise.
483 * undo.c: Likewise.
484 * unexsol.c: Likewise.
485 * w16select.c: Likewise.
486 * w32fns.c: Likewise.
487 * w32menu.c: Likewise.
488 * window.c: Likewise.
489 * xdisp.c: Likewise.
490 * xfns.c: Likewise.
491 * xmenu.c: Likewise.
492 * xml.c: Likewise.
493 * xselect.c: Likewise.
494
2f07e6af
EZ
4952012-06-16 Eli Zaretskii <eliz@gnu.org>
496
1053a871
SM
497 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
498 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 499 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
500 row.
501 (handle_face_prop): Use chunk-relative overlay string index when
502 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
503 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
504 the rightmost. (Bug#11720)
2f07e6af 505
29b83cec
AS
5062012-06-16 Andreas Schwab <schwab@linux-m68k.org>
507
508 * category.h (CHAR_HAS_CATEGORY): Define as inline.
509 (CATEGORY_MEMBER): Enforce 1/0 value.
510 * category.c (_temp_category_set): Remove.
511
4c5501e9
EZ
5122012-06-16 Eli Zaretskii <eliz@gnu.org>
513
514 * window.c (Fdelete_other_windows_internal)
515 (Fdelete_window_internal): Don't access frame's mouse highlight
516 info of the initial frame. (Bug#11677)
517
2b570124
PE
5182012-06-14 Paul Eggert <eggert@cs.ucla.edu>
519
e93864f9
PE
520 * .gdbinit (xgetint): Fix recently-introduced paren typo.
521 Assume USE_2_TAGS_FOR_INTS.
522 (xreload): Adjust $tagmask width to match recent lisp.h change.
523
2b570124
PE
524 Simplify lisp.h in minor ways that should not affect code.
525 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
526 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
527 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
528 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
529 (INTTYPEBITS): New macro, for clarity.
530 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
531 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
532 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
533 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
534 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
535
81755f69
JB
5362012-06-13 Juanma Barranquero <lekktu@gmail.com>
537
538 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
539
16192a57
GM
5402012-06-13 Glenn Morris <rgm@gnu.org>
541
542 * s/bsd-common.h (BSD4_3):
543 * s/usg5-4-common.h (USG5_4): No longer define; unused.
544
646b5f55
AS
5452012-06-13 Andreas Schwab <schwab@linux-m68k.org>
546
547 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
548 instead of union.
549 (XLI, XIL): Define.
1053a871
SM
550 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
551 Use them.
552 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 553 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 554 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
555 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
556 * frame.c (delete_frame): Remove outdated comment.
557 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
558 USE_LISP_UNION_TYPE.
559 (Fw32_unregister_hot_key): Likewise.
560 (Fw32_toggle_lock_key): Likewise.
561 * w32menu.c (add_menu_item): Likewise.
562 (w32_menu_display_help): Use XIL instead of checking
563 USE_LISP_UNION_TYPE.
564 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
565 (init_heap): Likewise.
566 * w32term.c (w32_read_socket): Update comment.
567
1d3823c9
GM
5682012-06-13 Glenn Morris <rgm@gnu.org>
569
c62ff706
GM
570 * s/usg5-4-common.h, src/s/unixware.h:
571 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
572
1d3823c9
GM
573 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
574
bfe3e0a2
PE
5752012-06-13 Paul Eggert <eggert@cs.ucla.edu>
576
577 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
578 * alloc.c (make_number) [!defined make_number]:
579 Remove, as lisp.h always defines this now.
580 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
581 (roundup_size): Verify that it is a power of 2.
582 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
583 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
584 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
585 -DUSE_LSB_TAG=0, to override the automatically-selected default.
586 USE_LSB_TAG now is always defined to be either 0 or 1.
587 All uses changed.
588 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
589 code works fine either way, and efficiency is not a concern here,
590 as the union type is for debugging, not for production.
591 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
592 Use an inline function on all platforms when using the union type,
593 since this is simpler and 'static inline' can be used portably
594 within Emacs now.
595 (LISP_INITIALLY_ZERO): New macro.
596 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
597 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
598
45fa9c0f
GM
5992012-06-12 Glenn Morris <rgm@gnu.org>
600
b4492cba
GM
601 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
602
603 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 604
45fa9c0f
GM
605 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
606 Move BROKEN_SIGIO to configure.
607
608 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
609 Move NO_TERMIO to configure.
610
0e25d334
CY
6112012-06-12 Chong Yidong <cyd@gnu.org>
612
613 * image.c (imagemagick_load_image): Use MagickFlattenImage if
614 MagickMergeImageLayers is undefined. Use pixel pusher loop if
615 MagickExportImagePixels is undefined.
616
43682bb6
PE
6172012-06-12 Paul Eggert <eggert@cs.ucla.edu>
618
619 * image.c (imagemagick_load_image): Remove unused label.
620
a9be7d2b
GM
6212012-06-11 Glenn Morris <rgm@gnu.org>
622
623 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
624 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
625 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
626 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
627
3017f87f
SM
6282012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
629
630 * alloc.c (make_byte_code): New function.
631 (Fmake_byte_code): Use it. Don't purify here.
632 * lread.c (read1): Use it as well to avoid extra allocation.
633
1b9b4cf4
CY
6342012-06-11 Chong Yidong <cyd@gnu.org>
635
636 * image.c (imagemagick_load_image): Implement transparency.
637
95988fcf
AS
6382012-06-10 Andreas Schwab <schwab@linux-m68k.org>
639
640 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
641 account for preceding backslashes. (Bug#11663)
642
cd4eb164
CY
6432012-06-09 Chong Yidong <cyd@gnu.org>
644
645 * term.c: Support italics in capable terminals (Bug#9652).
646 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
647 (turn_on_face): Output using TS_enter_italic_mode if available.
648 Don't handle unused blinking and alt-charset cases.
649 (turn_off_face): Handle italic case; discard unused tty_blinking_p
650 and tty_alt_charset_p cases.
651 (tty_capable_p, init_tty): Support italics.
652
653 * termchar.h (struct tty_display_info): Add field for italics.
654 Remove unused blink field.
655
656 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
657 Handle slant.
658
659 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
660 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
661 tty_alt_charset_p. Add tty_italic_p.
662
ff88beb8
MA
6632012-06-09 Michael Albinus <michael.albinus@gmx.de>
664
665 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
666 dbus_type_is_basic if available.
667 (xd_extract_signed, xd_extract_unsigned): Rename from
668 extract_signed and extract_unsigned, respectively. Adapt callers.
669
44286096
CY
6702012-06-09 Chong Yidong <cyd@gnu.org>
671
1682701f
CY
672 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
673
44286096
CY
674 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
675 case (Bug#9752).
676
d86feb17
PE
6772012-06-08 Paul Eggert <eggert@cs.ucla.edu>
678
679 * xdisp.c (vmessage): Treat frame message as multibyte.
680 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
681 would generate the diagnostic "Making \302\247 buffer-local while
682 let-bound!".
683
d5c20fe8
EZ
6842012-06-08 Eli Zaretskii <eliz@gnu.org>
685
686 * dispnew.c (showing_window_margins_p): Undo last change, which
687 was done due to an inadvertent commit.
688 (adjust_frame_glyphs_for_frame_redisplay): Do call
689 showing_window_margins_p.
690
513749ee
SM
6912012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
692
693 * eval.c (Fmake_var_non_special): New primitive.
694 (syms_of_eval): Defsubr it.
695 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
696
d4a8f5c1
JB
6972012-06-08 Juanma Barranquero <lekktu@gmail.com>
698
699 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
700 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
701
8bbbc977
EZ
7022012-06-08 Eli Zaretskii <eliz@gnu.org>
703
704 * alloc.c (allocate_vectorlike): Fix last change.
705
f3372c87
DA
7062012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
707
708 Block-based vector allocation of small vectors.
709 * lisp.h (struct vectorlike_header): New field `nbytes',
710 adjust comment accordingly.
711 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
712 to denote vector blocks. Adjust users (live_vector_p,
713 mark_maybe_pointer, valid_lisp_object_p) accordingly.
714 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
715 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
716 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
717 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
718 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
719 (roundup_size): New constant.
720 (struct vector_block): New data type.
721 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 722 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
723 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
724 (sweep_vectors): New functions.
725 (allocate_vectorlike): Return `zero_vector' as the only vector of
726 0 items. Allocate new vector from block if vector size is less than
727 or equal to VBLOCK_BYTES_MAX.
728 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
729 (init_alloc_once): Add call to init_vectors.
730
4f18a4ed
SM
7312012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
732
733 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
734
86f158bc
PE
7352012-06-07 Paul Eggert <eggert@cs.ucla.edu>
736
737 * doprnt.c (doprnt): Truncate multibyte char correctly.
738 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
739 would mishandle a string argument "Xc" if X was a multibyte
740 character of length 2: it would truncate after X's first byte
741 rather than including all of X.
742
c5cfcbe0
CY
7432012-06-06 Chong Yidong <cyd@gnu.org>
744
745 * buffer.c (word_wrap): Doc fix.
746
c05cf390
PE
7472012-06-04 Paul Eggert <eggert@cs.ucla.edu>
748
749 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
750
0c3461de
GM
7512012-06-03 Glenn Morris <rgm@gnu.org>
752
753 * xdisp.c (tool-bar-style): Doc fix.
754
c71232db
UM
7552012-06-03 Ulrich Müller <ulm@gentoo.org>
756
757 * Makefile.in (PAXCTL): Define.
758 (temacs$(EXEEXT)): Disable memory randomization for the temacs
759 binary via PaX flags if the paxctl utility is available.
760 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
761 Restore PaX flags to their default. (Bug#11398)
762
383f7350
CY
7632012-06-03 Chong Yidong <cyd@gnu.org>
764
765 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
766 buffer (Bug#11226).
767
5f2c76c6
CY
7682012-06-03 Chong Yidong <cyd@gnu.org>
769
770 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
771 (note_mode_line_or_margin_highlight): If there is no help echo,
772 use mode-line-default-help-echo. Handle the case where the mouse
773 position is past the end of the mode line string.
774
775 * buffer.c (buffer_local_value_1): New function, split from
776 Fbuffer_local_value; can return Qunbound.
777 (Fbuffer_local_value): Use it.
778 (Vmode_line_format): Docstring tweaks.
779
773d47f6
PE
7802012-06-02 Paul Eggert <eggert@cs.ucla.edu>
781
782 * sysdep.c (system_process_attributes): Improve comment.
783
f2d6a3df
SM
7842012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
785
786 * keyboard.c: Export real-this-command to Elisp.
787 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
788 and DEFVAR it. Update all users.
789
63810350
PE
7902012-06-02 Paul Eggert <eggert@cs.ucla.edu>
791
7bd5c1f4
PE
792 * minibuf.c (Fassoc_string): Remove duplicate declaration.
793
63810350
PE
794 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
795 Convert pctcpu and pctmem to Lisp float properly.
796 Let the compiler fold better, as 100.0/0x8000 is exact.
797
a2821611
AS
7982012-06-02 Andreas Schwab <schwab@linux-m68k.org>
799
800 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
801 cons_block.
802
5fceba1d
PE
8032012-06-01 Paul Eggert <eggert@cs.ucla.edu>
804
805 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
806
c98ff5dd
DA
8072012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
808
809 For a 'struct window', replace some Lisp_Object fields to
810 bitfields where appropriate, remove unused fields.
811 * window.h (struct window): Remove unused 'last_mark_x' and
812 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
813 change it's type from Lisp_Object to bitfield.
814 Change type of 'force_start', 'optional_new_start',
815 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
816 fields from Lisp_Object to bitfield. Adjust users accordingly.
817
ca34e0be
PE
8182012-05-31 Paul Eggert <eggert@cs.ucla.edu>
819
820 Pacify gcc -Wdouble-precision when using Xaw.
821 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
822 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
823 Use 'float' consistently, rather than 'float' in most places
824 and 'double' in a couple of places.
825
efc00ab1 8262012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
827
828 * xdisp.c (handle_stop): Detect whether we have overlay strings
829 loaded by testing it->current.overlay_string_index to be
830 non-negative, instead of checking whether n_overlay_strings is
831 positive. (Bug#11587)
832
efc00ab1 8332012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
834
835 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
836
837 * doc.c (Fsubstitute_command_keys): Doc fix.
838
efc00ab1 8392012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
840
841 * search.c (search_buffer): Remove calls to
842 r_alloc_inhibit_buffer_relocation, as it is now called by
843 maybe_unify_char, which was the cause of relocation of buffer text
844 in bug#11519.
845
efc00ab1 8462012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
847
848 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
849 for the duration of call to load_charset, to avoid problems with
850 callers of maybe_unify_char that access buffer text through C
851 pointers.
852
853 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
854 decrement the inhibition flag, instead of just setting or
855 resetting it.
856
ba93a187
PE
8572012-05-31 Paul Eggert <eggert@cs.ucla.edu>
858
859 Remove obsolete '#define static' cruft.
860 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
861 This #undef was "temporary" in 2000; it is no longer needed
862 now that '#define static' has gone away.
863 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
864 (gray_bitmap_bits): Remove; no longer needed.
865 All uses replaced with definiens.
866 * xterm.c: Include "bitmaps/gray.xbm".
867
9e4bf381
PE
8682012-05-30 Paul Eggert <eggert@cs.ucla.edu>
869
870 Clean up __executable_start, monstartup when --enable-profiling.
871 The following changes affect the code only when profiling.
872 * dispnew.c (__executable_start): Rename from safe_bcopy.
873 Define only on platforms that need it.
874 * emacs.c: Include <sys/gmon.h> when profiling.
875 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
876 (__executable_start): Remove decl, since lisp.h does it now.
877 (safe_bcopy): Remove decl; no longer has that name.
878 (main): Coalesce #if into single bit of code, for simplicity.
879 Cast pointers to uintptr_t, since standard libraries want integers
880 and not pointers.
881 * lisp.h (__executable_start): New decl.
882
32d72c2f
GM
8832012-05-31 Glenn Morris <rgm@gnu.org>
884
885 * image.c (Fimagemagick_types): Doc fix.
886
baac5bc7
JM
8872012-05-30 Jim Meyering <meyering@redhat.com>
888
889 * callproc.c (Fcall_process_region): Include directory component
890 in mkstemp error message (Bug#11586).
891
72cb32cf
PE
8922012-05-30 Paul Eggert <eggert@cs.ucla.edu>
893
894 * alloc.c, lisp.h (make_pure_vector): Now static.
895
61b108cc
SM
8962012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
897
898 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
899 Move to byte-run.el.
900 (Fautoload): Do the hash-doc more carefully.
901 * data.c (Fdefalias): Purify definition, except for keymaps.
902 (Qdefun): Move from eval.c.
903 * lisp.h (Qdefun): Remove.
904 * lread.c (read1): Tiny simplification.
905
471fe23d
TN
9062012-05-29 Troels Nielsen <bn.troels@gmail.com>
907
934f3f58 908 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
909 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
910 Bug#9642, but explicitly check that the buffer the overlay would
911 be moved to is live and rearrange lines to make sure that errors
912 will not put the overlay in an inconsistent state.
913 (Fdelete_overlay): Cosmetics.
914
85d0efd1
EZ
9152012-05-28 Eli Zaretskii <eliz@gnu.org>
916
917 * w32term.c (my_bring_window_to_top): New function.
918 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
919 could be different from the original one.
920 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
921 (Bug#11513)
922
923 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
924 by calling BringWindowToTop.
925
926 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
927 (WM_EMACS_END): Increase by one.
928
da92a98c
PE
9292012-05-28 Paul Eggert <eggert@cs.ucla.edu>
930
931 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
932 This avoids undefined behavior that might cause the eassert
933 to not catch an out-of-range value.
934
74d1f848
JB
9352012-05-28 Juanma Barranquero <lekktu@gmail.com>
936
937 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
938 Update dependencies.
939
9e1a06fc
EZ
9402012-05-27 Eli Zaretskii <eliz@gnu.org>
941
942 * bidi.c (bidi_mirror_char): Fix last change.
943
f3dd7312
AS
9442012-05-27 Andreas Schwab <schwab@linux-m68k.org>
945
946 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
947 when referring to sectname field in printf format.
948
81899c91
PE
9492012-05-27 Paul Eggert <eggert@cs.ucla.edu>
950
57b81a9f
PE
951 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
952 Only r_alloc_inhibit_buffer_relocation needed to be added;
953 the others were already declared.
954
81899c91
PE
955 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
956 before checking whether it's out of range. Put the check inside
957 eassert. See
958 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
959
33017faf 9602012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
961
962 * callproc.c (Fcall_process): Restore a line that was accidentally
963 commented out in the 2011-02-13 change (bug#11547).
964
33017faf 9652012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
966
967 * lisp.h [REL_ALLOC]: Add prototypes for external functions
968 defined on ralloc.c.
969
970 * buffer.c [REL_ALLOC]: Remove prototypes of
971 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
972 they are now on lisp.h.
973
974 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
975
976 * search.c (search_buffer): Use it to inhibit relocation of buffer
977 text while re_search_2 is doing its job, because re_search_2 is
978 passed C pointers to buffer text. (Bug#11519)
979
23415acf
EZ
980 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
981 Update value to 24.
982
44e27368
EZ
983 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
984 state after an additional call to move_it_in_display_line_to, keep
985 the values of it->max_ascent and it->max_descent found for the
986 entire line.
987 (pos_visible_p): Revert the comparison against bottom_y to what it
988 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
989 (Bug#11464)
990
c1892f11
PE
9912012-05-26 Paul Eggert <eggert@cs.ucla.edu>
992
993 Fix coding-related core dumps with gcc -ftrapv.
994 The code was computing A - B, where A and B are pointers, and B is
995 random garbage. This can lead to core dumps on platforms that
996 have special pointer registers, and it also leads to core dumps on
997 x86-64 when compiled with gcc -ftrapv. The fix is to compute
998 A - B only when B is initialized properly.
999 * coding.c (coding_set_source, coding_set_destination): Return void.
1000 (coding_change_source, coding_change_destinations): New functions,
1001 with the old behaviors of coding_set_source and coding_set_destination.
1002 All callers that need an offset changed to use these new functions.
1003
eb7afdad
GM
10042012-05-26 Glenn Morris <rgm@gnu.org>
1005
1006 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
1007
f12fdf02
EZ
10082012-05-26 Eli Zaretskii <eliz@gnu.org>
1009
53a63be6 1010 Extend mouse support on W32 text-mode console.
61b108cc
SM
1011 * xdisp.c (draw_row_with_mouse_face):
1012 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 1013
eb3f6f01 1014 * w32console.c: Include window.h.
61b108cc
SM
1015 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
1016 New functions.
eb3f6f01
EZ
1017 (initialize_w32_display): Initialize mouse-highlight data.
1018
53a63be6
EZ
1019 * w32inevt.c: Include termchar.h and window.h.
1020 (do_mouse_event): Support mouse-autoselect-window. When the mouse
1021 moves, call note_mouse_highlight. If help_echo changed, call
1022 gen_help_event to produce help-echo message in the echo area.
1023 Call clear_mouse_face if mouse_face_hidden is set in the mouse
1024 highlight info.
1025
4cfd81f6
PE
10262012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1027
1028 * lread.c (read1): Simplify slightly to avoid an overflow warning
1029 with GCC 4.7.0 on x86-64.
1030
4446092a
EZ
10312012-05-26 Eli Zaretskii <eliz@gnu.org>
1032
1033 * bidi.c (bidi_mirror_char): Revert last change: an int is
1034 definitely wide enough here.
1035
42b2a986 10362012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 1037
42b2a986 1038 Fix integer width and related bugs (Bug#9874).
eb106a49 1039 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
1040 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
1041 (string_bytes, check_sblock, allocate_string_data):
1042 (compact_small_strings, Fmake_bool_vector, make_string)
1043 (make_unibyte_string, make_multibyte_string)
1044 (make_string_from_bytes, make_specified_string)
1045 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
1046 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
1047 (mark_vectorlike):
1048 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1049 (allocate_pseudovector):
1050 Use int, not EMACS_INT, where int is wide enough.
1051 (inhibit_garbage_collection, Fgarbage_collect):
1052 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1053 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
1054 int might not be wide enough.
1055 (bidi_cache_search, bidi_cache_find, bidi_init_it)
1056 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
1057 (bidi_at_paragraph_end, bidi_find_paragraph_start)
1058 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1059 (bidi_level_of_next_char, bidi_move_to_visually_next):
1060 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1061 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
1062 (Fkill_buffer, Fset_buffer_major_mode)
1063 (advance_to_char_boundary, Fbuffer_swap_text)
1064 (Fset_buffer_multibyte, overlays_at, overlays_in)
1065 (overlay_touches_p, struct sortvec, record_overlay_string)
1066 (overlay_strings, recenter_overlay_lists)
1067 (adjust_overlays_for_insert, adjust_overlays_for_delete)
1068 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
1069 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
1070 (Foverlay_recenter, last_overlay_modification_hooks_used)
1071 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
1072 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
1073 (validate_region): Omit unnecessary test for b <= e,
1074 since that's guaranteed by the previous test.
d311d28c
PE
1075 (adjust_overlays_for_delete): Avoid pos + length overflow.
1076 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
1077 (report_overlay_modification):
1078 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1079 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
1080 Omit pointer cast, which isn't needed anyway, and doesn't work
1081 after the EMACS_INT -> ptrdiff_t change.
02481186 1082 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
1083 * buffer.h: Adjust decls to match defn changes elsewhere.
1084 (struct buffer_text, struct buffer):
1085 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1086 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
1087 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
1088 not int, to avoid needless 32-bit limit on 64-bit hosts.
1089 (exec_byte_code): Use tighter memory-full test, one that checks
1090 for alloca overflow. Don't compute the address of the object just
1091 before an array, as that's not portable. Use EMACS_INT, not
1092 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
1093 * callint.c (Fcall_interactively):
1094 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1095 * callproc.c (call_process_kill, Fcall_process):
1096 Don't assume pid_t fits into an Emacs fixnum.
1097 (call_process_cleanup, Fcall_process, child_setup):
1098 Don't assume pid_t fits into int.
1099 (call_process_cleanup, Fcall_process, delete_temp_file)
1100 (Fcall_process_region):
1101 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1102 (Fcall_process): Simplify handling of volatile integers.
1103 Use int, not EMACS_INT, where int will do.
1104 * casefiddle.c (casify_object, casify_region, operate_on_word)
1105 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
1106 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1107 (casify_object): Avoid integer overflow when overallocating buffer.
1108 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 1109 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
1110 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
1111 * category.h (CATEGORYP): Don't assume arg is nonnegative.
1112 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
1113 integers are now checked earlier. All uses replaced with XINT.
1114 (ccl_driver):
1115 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1116 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
1117 (ccl_driver, Fregister_code_conversion_map):
1118 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
1119 (resolve_symbol_ccl_program): Check that vector header is in range.
1120 Always copy the vector, so that we can check its contents reliably
1121 now rather than having to recheck each instruction as it's being
1122 executed. Check that vector words fit in 'int'.
1123 (ccl_get_compiled_code, Fregister_ccl_program)
1124 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
1125 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
1126 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
1127 contents are in range.
1128 (Fccl_execute_on_string): Check that status is in range.
1129 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
1130 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
1131 Accept and return EMACS_INT, not int, because callers can pass values
1132 out of 'int' range.
1133 (c_string_width, strwidth, lisp_string_width, chars_in_text)
1134 (multibyte_chars_in_text, parse_str_as_multibyte)
1135 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
1136 (str_as_unibyte, str_to_unibyte, string_count_byte8)
1137 (string_escape_byte8, Fget_byte):
1138 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 1139 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
1140 avoid mishandling large integers.
1141 * character.h: Adjust decls to match defn changes elsewhere.
1142 * charset.c (load_charset_map_from_file, find_charsets_in_text)
1143 (Ffind_charset_region):
1144 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1145 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
1146 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 1147 Don't assume fixnum fits in int.
d311d28c
PE
1148 (load_charset_map_from_vector, Fmap_charset_chars):
1149 Remove now-unnecessary CHECK_NATNUMs.
1150 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
1151 Don't rely on undefined behavior with signed left shift overflow.
1152 Don't assume unsigned int fits into fixnum, or that fixnum fits
1153 into unsigned int. Don't require max_code to be a valid fixnum;
1154 that's not true for gb10830 4-byte on a 32-bit host. Allow
1155 invalid_code to be a cons, for the same reason. Require code_offset
1156 to be a character. Avoid int overflow if max_char is close
1157 to INT_MAX.
1158 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
1159 this is intended anyway and avoids some undefined behavior.
1160 (load_charset_map): Pass unsigned, not int, as 2nd arg of
1161 INDEX_TO_CODE_POINT, as that's what it expects.
1162 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
1163 * charset.h (DECODE_CHAR): Return int, not unsigned;
1164 this is what was intended anyway, and it avoids undefined behavior.
1165 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
1166 integer-overflow issues.
1167 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
1168 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
1169 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
1170 * chartab.c (Fmake_char_table, Fset_char_table_range)
1171 (uniprop_get_decoder, uniprop_get_encoder):
1172 Don't assume fixnum fits in int.
1173 * cmds.c (move_point): New function, that does the gist of
1174 Fforward_char and Fbackward_char, but does so while checking
1175 for integer overflow more accurately.
c96e5d6a 1176 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
1177 (Fforward_line, Fend_of_line, internal_self_insert)
1178 (internal_self_insert):
1179 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1180 Fix a FIXME, by checking for integer overflow when calculating
1181 target_clm and actual_clm.
1182 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 1183 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
1184 (ASSURE_DESTINATION, coding_alloc_by_realloc)
1185 (coding_alloc_by_making_gap, alloc_destination)
1186 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
1187 (encode_coding_utf_16, detect_coding_emacs_mule)
1188 (decode_coding_emacs_mule, encode_coding_emacs_mule)
1189 (detect_coding_iso_2022, decode_coding_iso_2022)
1190 (encode_invocation_designation, encode_designation_at_bol)
1191 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1192 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
1193 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
1194 (encode_coding_ccl, encode_coding_raw_text)
1195 (detect_coding_charset, decode_coding_charset)
1196 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
1197 (produce_composition, produce_charset, produce_annotation)
1198 (decode_coding, handle_composition_annotation)
1199 (handle_charset_annotation, consume_chars, decode_coding_gap)
1200 (decode_coding_object, encode_coding_object, detect_coding_system)
1201 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
1202 (code_convert_region, code_convert_string)
8f50130c
PE
1203 (Fdefine_coding_system_internal)
1204 (coding_set_source, coding_set_destination):
d311d28c
PE
1205 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1206 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
1207 (Fdefine_coding_system_internal):
1208 Don't assume fixnums fit in int.
1209 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 1210 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
1211 (Funencodable_char_position, Fcheck_coding_systems_region)
1212 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 1213 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 1214 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 1215 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 1216 Don't access memory outside of the args array.
d311d28c 1217 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
1218 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
1219 result of ENCODE_CHAR.
d311d28c
PE
1220 * coding.h: Adjust decls to match defn changes elsewhere.
1221 (struct coding_system):
1222 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1223 * composite.c (get_composition_id, find_composition)
1224 (run_composition_function, update_compositions)
1225 (compose_text, composition_gstring_put_cache)
1226 (composition_gstring_p, composition_gstring_width)
1227 (fill_gstring_header, fill_gstring_body, autocmp_chars)
1228 (composition_compute_stop_pos, composition_reseat_it)
1229 (composition_update_it, struct position_record)
1230 (find_automatic_composition, composition_adjust_point)
1231 (Fcomposition_get_gstring, Ffind_composition_internal):
1232 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1233 (update_compositions):
1234 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1235 * composite.h: Adjust decls to match defn changes elsewhere.
1236 (struct composition):
1237 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1238 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
1239 Do not attempt to compute the address of the object just before a
1240 buffer; this is not portable.
1241 (Faref, Faset):
1242 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1243 (Faset): Use int, not EMACS_INT, where int is wide enough.
1244 (Fstring_to_number): Don't assume fixnums fit in int.
1245 (Frem): Don't assume arg is nonnegative.
1246 * dbusbind.c (xd_append_arg): Check for integers out of range.
1247 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 1248 (extract_signed, extract_unsigned): New functions.
243e0530
PE
1249 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
1250 (xd_get_connection_references): Return ptrdiff_t, not int.
1251 All uses changed.
1252 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
1253 (xd_read_message_1):
1254 Use int, not unsigned, where the dbus API uses int.
1255 (Fdbus_message_internal): Don't overflow mtype.
1256 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
1257 * dired.c (directory_files_internal, file_name_completion, scmp)
1258 (file_name_completion_stat):
1259 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1260 (file_name_completion): Don't overflow matchcount.
1261 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
1262 * dispextern.h: Adjust decls to match defn changes elsewhere.
1263 (struct text_pos, struct glyph, struct bidi_saved_info)
1264 (struct bidi_string_data, struct bidi_it, struct composition_it)
1265 (struct it):
1266 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1267 (struct display_pos, struct composition_it, struct it):
1268 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1269 * dispnew.c (increment_matrix_positions)
1270 (increment_row_positions, mode_line_string)
1271 (marginal_area_string):
1272 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 1273 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
1274 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1275 (duration_to_sec_usec): New function, to check for overflow better.
1276 (Fsleep_for, sit_for): Use it.
1277 * doc.c (get_doc_string, store_function_docstring):
1278 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1279 (get_doc_string, Fsnarf_documentation):
1280 Use int, not EMACS_INT, where int is wide enough.
1281 (get_doc_string):
1282 Use SAFE_ALLOCA, not alloca.
1283 Check for overflow when converting EMACS_INT to off_t.
1284 * doprnt.c (doprnt):
1285 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1286 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
1287 Don't assume uid_t fits into fixnum.
1288 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
1289 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
1290 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
1291 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
1292 (general_insert_function)
1293 (Finsert_char, make_buffer_string, make_buffer_string_both)
1294 (update_buffer_properties, Fbuffer_substring)
1295 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
1296 (Fsubst_char_in_region, check_translation)
1297 (Ftranslate_region_internal, save_restriction_restore, Fformat)
1298 (transpose_markers, Ftranspose_regions):
1299 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1300 (clip_to_bounds): Move to lisp.h as an inline function).
1301 (Fconstrain_to_field): Don't assume integers are nonnegative.
1302 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
1303 (Fsubst_char_in_region, Fsave_restriction):
1304 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1305 (Femacs_pid): Don't assume pid_t fits into fixnum.
1306 (lo_time): Use int, not EMACS_INT, when int suffices.
1307 (lisp_time_argument): Check for usec out of range.
1308 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
1309 (Fuser_login_name, Fuser_full_name): Signal an error
1310 if a uid argument is out of range, rather than relying on
1311 undefined behavior.
c8d5c857
PE
1312 (Fformat_time_string): Remove now-unnecessary check.
1313 lisp_time_argument checks for out-of-range usec now.
243e0530 1314 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
1315 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
1316 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
1317 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
1318 (init_cmdargs, Fdump_emacs):
1319 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1320 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
1321 the bottom (typically) 32 bits of the fixnum.
1322 * eval.c (specpdl_size, call_debugger):
1323 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1324 (when_entered_debugger, Fbacktrace_debug):
1325 Don't assume fixnum can fit in int.
1326 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
1327 the object just before a buffer; this is not portable.
1328 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
1329 (grow_specpdl, unbind_to):
1330 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1331 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
1332 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 1333 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
1334 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
1335 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
1336 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1337 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
1338 (a_write, e_write):
1339 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1340 (Fcopy_file, non_regular_nbytes, read_non_regular)
1341 (Finsert_file_contents):
1342 Use int, not EMACS_INT, where int is wide enough.
1343 (READ_BUF_SIZE): Verify that it fits in int.
1344 (Finsert_file_contents): Check that counts are in proper range,
1345 rather than assuming fixnums fit into ptrdiff_t etc.
1346 Don't assume fixnums fit into int.
125b3835 1347 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
1348 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
1349 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
1350 (string_char_to_byte, string_byte_to_char)
1351 (string_make_multibyte, string_to_multibyte)
1352 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
1353 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
1354 (substring_both, Fdelete, internal_equal, Ffillarray)
1355 (Fclear_string, mapcar1)
1356 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
1357 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
1358 (larger_vector, make_hash_table, maybe_resize_hash_table)
1359 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
1360 (Fmaphash, secure_hash):
1361 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1362 (concat): Check for string index and length overflow.
1363 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
1364 (Frequire):
1365 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1366 (larger_vector): New API (vec, incr_min, size_max) replaces old
1367 one (vec, new_size, init). This catches size overflow.
1368 INIT was removed because it was always Qnil.
1369 All callers changed.
1370 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
1371 the upper bound on a hash table index size.
1372 (make_hash_table, maybe_resize_hash_table): Use it.
1373 (secure_hash): Computer start_byte and end_byte only after
1374 they're known to be in ptrdiff_t range.
1375 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
1376 (Ffont_get_glyphs, Ffont_at):
1377 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1378 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
1379 (Flist_fonts, Fopen_font):
1380 Don't assume fixnum can fit in int.
1381 (check_gstring): Don't assume index can fit in int.
1382 (font_match_p): Check that fixnum is a character, not a nonnegative
1383 fixnum, since the later code needs to stuff it into an int.
1384 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
1385 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
1386 conversion overflow issues.
1387 (Fopen_font): Check for integer out of range.
1388 (Ffont_get_glyphs): Don't assume index can fit in int.
1389 * font.h: Adjust decls to match defn changes elsewhere.
1390 * fontset.c (reorder_font_vector): Redo score calculation to avoid
1391 integer overflow.
1392 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
1393 printmax_t, where ptrdiff_t is wide enough.
1394 (Finternal_char_font):
1395 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1396 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
1397 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
1398 (Fset_frame_position, x_set_frame_parameters)
1399 (x_set_line_spacing, x_set_border_width)
1400 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
1401 Check that fixnums are in proper range for system types.
1402 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
1403 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1404 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
1405 Use SAFE_ALLOCA_LISP, not alloca.
1406 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
1407 intptr_t is wide enough.
1408 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
1409 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
1410 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
1411 Check for fixnum out of range.
1412 * ftfont.c (ftfont_list): Don't assume index fits in int.
1413 Check that fixnums are in proper range for system types.
1414 (ftfont_shape_by_flt):
1415 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
1416 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1417 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1418 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
1419 Check that fixnums are in proper range for system types.
1420 * gnutls.h: Adjust decls to match defn changes elsewhere.
1421 * gtkutil.c (xg_dialog_run):
1422 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1423 (update_frame_tool_bar):
1424 Check that fixnums are in proper range for system types.
1425 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 1426 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
1427 * indent.c (last_known_column, last_known_column_point):
1428 (current_column_bol_cache):
1429 (skip_invisible, current_column, check_display_width):
1430 (check_display_width, scan_for_column, current_column_1)
1431 (Findent_to, Fcurrent_indentation, position_indentation)
1432 (indented_beyond_p, Fmove_to_column, compute_motion):
1433 (Fcompute_motion, Fvertical_motion):
1434 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1435 (last_known_column_modified): Use EMACS_INT, not int.
1436 (check_display_width):
1437 (Fcompute_motion):
1438 Check that fixnums and floats are in proper range for system types.
1439 (compute_motion): Don't assume index or fixnum fits in int.
1440 (compute_motion, Fcompute_motion):
1441 Use int, not EMACS_INT, when it is wide enough.
1442 (vmotion): Omit local var start_hpos that is always 0; that way
1443 we don't need to worry about overflow in expressions involving it.
1444 * indent.h: Adjust decls to match defn changes elsewhere.
1445 (struct position):
1446 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1447 Use int, not EMACS_INT, where int is wide enough.
1448 Remove unused members ovstring_chars_done and tab_offset;
1449 all uses removed.
1450 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
1451 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
1452 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
1453 (make_gap, copy_text, insert, insert_and_inherit)
1454 (insert_before_markers, insert_before_markers_and_inherit)
1455 (insert_1, count_combining_before, count_combining_after)
1456 (insert_1_both, insert_from_string)
1457 (insert_from_string_before_markers, insert_from_string_1)
1458 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
1459 (adjust_after_replace, adjust_after_insert, replace_range)
1460 (replace_range_2, del_range, del_range_1, del_range_byte)
1461 (del_range_both, del_range_2, modify_region)
1462 (prepare_to_modify_buffer, signal_before_change)
1463 (signal_after_change, Fcombine_after_change_execute):
1464 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1465 * intervals.c (traverse_intervals, rotate_right, rotate_left)
1466 (balance_an_interval, split_interval_right, split_interval_left)
1467 (find_interval, next_interval, update_interval)
1468 (adjust_intervals_for_insertion, delete_node, delete_interval)
1469 (interval_deletion_adjustment, adjust_intervals_for_deletion)
1470 (static_offset_intervals, offset_intervals)
1471 (merge_interval_right, merge_interval_left, make_new_interval)
1472 (graft_intervals_into_buffer, temp_set_point_both)
1473 (temp_set_point, set_point, adjust_for_invis_intang)
1474 (set_point_both, move_if_not_intangible, get_property_and_range)
1475 (get_local_map, copy_intervals, copy_intervals_to_string)
1476 (compare_string_intervals, set_intervals_multibyte_1):
1477 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1478 * intervals.h: Adjust decls to match defn changes elsewhere.
1479 (struct interval):
1480 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1481 * keyboard.c (this_command_key_count, this_single_command_key_start)
1482 (before_command_key_count, before_command_echo_length, echo_now)
1483 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
1484 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
1485 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
1486 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
1487 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1488 (last_non_minibuf_size, last_point_position, echo_truncate)
1489 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
1490 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
1491 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
1492 (stuff_buffered_input):
1493 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1494 (last_auto_save, command_loop_1, read_char):
1495 Use EMACS_INT, not int, to avoid integer overflow.
1496 (record_char): Avoid overflow in total_keys computation.
1497 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
1498 * keyboard.h: Adjust decls to match defn changes elsewhere.
1499 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
1500 (Fkey_description, Fdescribe_vector, Flookup_key):
1501 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1502 (click_position): New function, to check that positions are in range.
1503 (Fcurrent_active_maps):
1504 (describe_command):
1505 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1506 (Faccessible_keymaps, Fkey_description):
1507 (preferred_sequence_p):
1508 Don't assume fixnum can fit into int.
1509 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
1510 Check for integer overflow in size calculations.
1511 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
1512 avoid mishandling large integers.
1513 * lisp.h: Adjust decls to match defn changes elsewhere.
1514 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
1515 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
1516 (struct Lisp_Marker):
1517 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1518 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
1519 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
1520 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
1521 All callers changed.
1522 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
1523 Assume the arg has valid form, since it always does.
1524 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
1525 unsigned integer system type.
1526 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
1527 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
1528 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1529 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
1530 (duration_to_sec_usec): New decl.
1531 * lread.c (read_from_string_index, read_from_string_index_byte)
1532 (read_from_string_limit, readchar, unreadchar, openp)
1533 (read_internal_start, read1, oblookup):
1534 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1535 (Fload, readevalloop, Feval_buffer, Feval_region):
1536 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1537 (openp): Check for out-of-range argument to 'access'.
1538 (read1): Use int, not EMACS_INT, where int is wide enough.
1539 Don't assume fixnum fits into int.
6efdadfd 1540 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
1541 (read_filtered_event): Use duration_to_sec_usec
1542 to do proper overflow checking on durations.
d311d28c
PE
1543 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
1544 in size calculation.
1545 (Fexecute_kbd_macro):
1546 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1547 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
1548 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
1549 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
1550 (set_marker_both, set_marker_restricted_both, marker_position)
1551 (marker_byte_position, Fbuffer_has_markers_at):
1552 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1553 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 1554 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
1555 It now merely ensures that the menu is large enough, without
1556 necessarily growing it, as this avoids some integer overflow issues.
1557 All callers changed.
1558 (keymap_panes, parse_single_submenu, Fx_popup_menu):
1559 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1560 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
1561 Use SAFE_ALLOCA_LISP, not alloca.
1562 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
1563 to EMACS_INT. Check that fixnums are in proper range for system types.
1564 * minibuf.c (minibuf_prompt_width, string_to_object)
1565 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
1566 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
1567 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1568 (get_minibuffer, read_minibuf_unwind):
1569 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1570 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
1571 this simplifies overflow checking. All callers changed.
1572 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
1573 (Ftest_completion):
1574 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1575 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
1576 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
1577 Check that fixnums are in proper range for system types.
1578 (Fx_create_frame, Fx_show_tip):
1579 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1580 * nsfont.m (ns_findfonts, nsfont_list_family):
1581 Don't assume fixnum fits in long.
1582 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
1583 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1584 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
1585 wide enough.
17fdb222 1586 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
1587 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1588 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
1589 (PRINTDECLARE, PRINTPREPARE):
1590 (strout, print_string):
1591 (print, print_preprocess, print_check_string_charset_prop)
1592 (print_object):
1593 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1594 (PRINTDECLARE):
1595 (temp_output_buffer_setup, Fprin1_to_string, print_object):
1596 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1597 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 1598 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 1599 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
1600 (print_error_message): Use SAFE_ALLOCA, not alloca.
1601 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
1602 (print_depth, new_backquote_output, print_number_index):
1603 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
1604 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
1605 (Fset_process_window_size, Fformat_network_address)
1606 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 1607 (sigchld_handler):
d311d28c 1608 Check that fixnums are in proper range for system types.
d44287d4 1609 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
1610 Check for process-ids out of pid_t range rather than relying on
1611 undefined behavior.
e4d81efc 1612 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
1613 (Fformat_network_address, read_process_output, send_process)
1614 (Fprocess_send_region, status_notify):
1615 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1616 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
1617 (wait_reading_process_output, read_process_output, exec_sentinel):
1618 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1619 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
1620 (Faccept_process_output): Use duration_to_sec_usec to do proper
1621 overflow checking on durations.
dde14581
PE
1622 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
1623 Don't assume pid_t fits in int.
02481186
PE
1624 * process.h (struct Lisp_Process): Members tick and update_tick
1625 are now of type EMACS_INT, not int.
b62b53e8
PE
1626 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
1627 configured --with-wide-int.
d311d28c
PE
1628 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
1629 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
1630 * search.c (looking_at_1, string_match_1):
1631 (fast_string_match, fast_c_string_match_ignore_case)
1632 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
1633 (scan_newline, find_before_next_newline, search_command)
1634 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
1635 (set_search_regs, wordify):
1636 (Freplace_match):
1637 (Fmatch_data):
1638 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1639 (string_match_1, search_buffer, set_search_regs):
1640 (Fmatch_data):
1641 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1642 (wordify): Check for overflow in size calculation.
1643 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
1644 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
1645 Check that fixnums are in proper range for system types.
1646 * sound.c (struct sound_device)
1647 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
1648 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1649 (Fplay_sound_internal):
1650 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 1651 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
1652 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
1653 (Fparse_partial_sexp):
1654 Don't assume fixnums can fit in int.
1655 (struct lisp_parse_state, find_start_pos, find_start_value)
1656 (find_start_value_byte, find_start_begv)
1657 (update_syntax_table, char_quoted, dec_bytepos)
1658 (find_defun_start, prev_char_comend_first, back_comment):
1659 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
1660 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
1661 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1662 (Finternal_describe_syntax_value): Check that match_lisp is a
1663 character, not an integer, since the code stuffs it into int.
1664 (scan_words, scan_sexps_forward):
1665 Check that fixnums are in proper range for system types.
1666 (Fforward_word):
1667 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1668 (scan_sexps_forward):
1669 Use CHARACTERP, not INTEGERP, since the value must fit into int.
1670 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
1671 * syntax.h: Adjust decls to match defn changes elsewhere.
1672 (struct gl_state_s):
1673 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
1674 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
1675 MOST_POSITIVE_FIXNUM.
d311d28c
PE
1676 * sysdep.c (wait_for_termination_1, wait_for_termination)
1677 (interruptible_wait_for_termination, mkdir):
1678 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
1679 (emacs_read, emacs_write):
1680 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
1681 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
1682 and double all fit in int.
d311d28c
PE
1683 * term.c (set_tty_color_mode):
1684 Check that fixnums are in proper range for system types.
1685 * termhooks.h (struct input_event):
1686 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1687 * textprop.c (validate_interval_range, interval_of)
1688 (Fadd_text_properties, set_text_properties_1)
1689 (Fremove_text_properties, Fremove_list_of_text_properties)
1690 (Ftext_property_any, Ftext_property_not_all)
1691 (copy_text_properties, text_property_list, extend_property_ranges)
1692 (verify_interval_modification):
1693 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1694 (Fnext_single_char_property_change)
1695 (Fprevious_single_char_property_change):
1696 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
1697 (copy_text_properties):
1698 Check for integer overflow in index calculation.
d311d28c
PE
1699 * undo.c (last_boundary_position, record_point, record_insert)
1700 (record_delete, record_marker_adjustment, record_change)
1701 (record_property_change):
1702 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1703 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
1704 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1705 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1706 (Fx_hide_tip, Fx_file_dialog):
1707 * w32menu.c (set_frame_menubar):
1708 Use ptrdiff_t, not int, for consistency with rest of code.
1709 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
1710 (select_window, Fdelete_other_windows_internal)
1711 (window_scroll_pixel_based, window_scroll_line_based)
1712 (Frecenter, Fset_window_configuration):
1713 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1714 (Fset_window_hscroll, run_window_configuration_change_hook)
1715 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 1716 (Fscroll_other_window, Frecenter):
d311d28c
PE
1717 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1718 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
1719 Don't assume fixnum fits in int.
1720 (Fset_window_scroll_bars):
1721 Check that fixnums are in proper range for system types.
1722 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
1723 (string_pos, c_string_pos, number_of_chars, init_iterator)
1724 (in_ellipses_for_invisible_text_p, init_from_display_pos)
1725 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
1726 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
1727 (face_before_or_after_it_pos, handle_invisible_prop)
1728 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
1729 (display_prop_intangible_p, string_buffer_position_lim)
1730 (string_buffer_position, handle_composition_prop, load_overlay_strings)
1731 (get_overlay_strings_1, get_overlay_strings)
1732 (iterate_out_of_display_property, forward_to_next_line_start)
1733 (back_to_previous_visible_line_start, reseat, reseat_to_string)
1734 (get_next_display_element, set_iterator_to_next)
1735 (get_visually_first_element, compute_stop_pos_backwards)
1736 (handle_stop_backwards, next_element_from_buffer)
1737 (move_it_in_display_line_to, move_it_in_display_line)
1738 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1739 (add_to_log, message_dolog, message_log_check_duplicate)
1740 (message2, message2_nolog, message3, message3_nolog
1741 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
1742 (current_message_1, truncate_echo_area, truncate_message_1)
1743 (set_message, set_message_1, store_mode_line_noprop)
1744 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
1745 (text_outside_line_unchanged_p, check_point_in_composition)
1746 (reconsider_clip_changes)
1747 (redisplay_internal, set_cursor_from_row, try_scrolling)
1748 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
1749 (redisplay_window, find_last_unchanged_at_beg_row)
1750 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
1751 (trailing_whitespace_p, find_row_edges, display_line)
1752 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
1753 (display_mode_element, store_mode_line_string)
1754 (pint2str, pint2hrstr, decode_mode_spec)
1755 (display_count_lines, display_string, draw_glyphs)
1756 (x_produce_glyphs, x_insert_glyphs)
1757 (rows_from_pos_range, mouse_face_from_buffer_pos)
1758 (fast_find_string_pos, mouse_face_from_string_pos)
1759 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1760 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1761 (safe_call, init_from_display_pos, handle_fontified_prop)
1762 (handle_single_display_spec, load_overlay_strings)
1763 (with_echo_area_buffer, setup_echo_area_for_printing)
1764 (display_echo_area, echo_area_display)
1765 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
1766 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
1767 (redisplay_window, dump_glyph_row, display_mode_line)
1768 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 1769 (handle_display_spec, display_prop_string_p):
d311d28c
PE
1770 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1771 (handle_single_display_spec, build_desired_tool_bar_string)
1772 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
1773 (get_specified_cursor_type):
1774 Check that fixnums are in proper range for system types.
1775 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
1776 (Flookup_image_map):
1777 Don't assume fixnums fit in int.
1778 (compare_overlay_entries):
1779 Avoid mishandling comparisons due to subtraction overflow.
1780 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
1781 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
1782 (handle_tool_bar_click):
1783 Use int, not unsigned, since we prefer signed and the signedness
1784 doesn't matter here.
1785 (get_next_display_element, next_element_from_display_vector):
1786 Use int, not EMACS_INT, when int is wide enough.
1787 (start_hourglass): Use duration_to_sec_usec to do proper
1788 overflow checking on durations.
1789 * xfaces.c (Fbitmap_spec_p):
1790 Check that fixnums are in proper range for system types.
1791 (compare_fonts_by_sort_order):
1792 Avoid mishandling comparisons due to subtraction overflow.
1793 (Fx_family_fonts, realize_basic_faces):
1794 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1795 (Fx_family_fonts):
1796 Don't assume fixnum fits in int.
1797 Use SAFE_ALLOCA_LISP, not alloca.
1798 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
1799 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
1800 (face_at_buffer_position, face_for_overlay_string)
1801 (face_at_string_position):
1802 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1803 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
1804 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
1805 (Fx_show_tip):
1806 Check that fixnums are in proper range for system types.
1807 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1808 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
1809 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1810 (Fx_change_window_property): Don't assume fixnums fit in int.
1811 * xfont.c (xfont_chars_supported):
1812 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1813 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
1814 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
1815 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1816 * xml.c (parse_region):
1817 * xrdb.c (magic_file_p):
1818 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1819 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
1820 (x_get_local_selection, x_reply_selection_request)
1821 (x_handle_selection_request, wait_for_property_change):
1822 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1823 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
1824 short is wide enough.
1825 (x_send_client_event): Don't assume fixnum fits in int.
1826 * xterm.c (x_x_to_emacs_modifiers):
1827 Don't assume EMACS_INT overflows nicely into int.
1828 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
1829 may come from Lisp.
1830 (handle_one_xevent): NATNUMP can eval its arg twice.
1831 (x_connection_closed):
1832 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1833 * xterm.h: Adjust decls to match defn changes elsewhere.
1834 (struct scroll_bar): Use struct vectorlike_header
1835 rather than rolling our own approximation.
1836 (SCROLL_BAR_VEC_SIZE): Remove; not used.
1837
c6574eb5
GM
18382012-05-25 Glenn Morris <rgm@gnu.org>
1839
1840 * lisp.mk (lisp): Update for more files being compiled now.
1841
e8d32c7e
SM
18422012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
1843
48def666
SM
1844 * lread.c: Remove `read_pure' which makes no difference.
1845 (read_pure): Remove var.
1846 (unreadpure): Remove function.
1847 (readevalloop): Don't call read_list with -1 flag.
1848 (read1, read_vector): Don't test read_pure any more.
1849 (read_list): Simplify.
1850
e8d32c7e
SM
1851 * fileio.c, character.h: Minor style tweaks.
1852
4b2addb7
DA
18532012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
1854
1855 * window.h (clip_changed): Remove useless declaration.
1856
584461b2
JB
18572012-05-22 Juanma Barranquero <lekktu@gmail.com>
1858
1859 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
1860 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
1861
34374650
PE
18622012-05-22 Paul Eggert <eggert@cs.ucla.edu>
1863
1864 Remove src/m/*.
1865 This directory predates autoconf and is no longer needed nowadays.
1866 Move its few remaining bits of functionality to where they're needed.
1867 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
1868 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
1869 * m/template.h: Remove.
1870 * Makefile.in (M_FILE): Remove. All uses removed.
1871 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
1872 * lisp.h (USE_LSB_TAG):
1873 * mem-limits.h (EXCEEDS_LISP_PTR):
1874 Use VAL_MAX, not VALBITS, in #if.
1875 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
1876 (EMACS_UINT): Define unconditionally now.
1877 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
1878 (BITS_PER_EMACS_INT): New constants, replacing
1879 what used to be in config.h, but not useful in #if.
1880 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
1881 define them any more.
1882 (VAL_MAX): New macro.
1883 (VALMASK): Use it.
1884 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
1885 BITS_PER_EMACS_INT, in #if.
1886 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1887 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
1888 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
1889 * s/ms-w32.h (DATA_START):
1890 Move here from removed file m/intel386.h.
1891 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
1892 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
1893
261cb4bb
PE
18942012-05-21 Paul Eggert <eggert@cs.ucla.edu>
1895
1896 Assume C89 or later.
1897 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
1898 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
1899 (xrealloc):
1900 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
1901 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
1902 * textprop.c, tparam.c (NULL): Remove.
1903 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
1904 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
1905 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
1906 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
1907 * xterm.c (input_signal_count): Assume volatile works.
1908
ff23cd9f
KB
19092012-05-21 Ken Brown <kbrown@cornell.edu>
1910
1911 * xgselect.c (xg_select): Fix first argument in call to 'select'
1912 (bug#11508).
1913
1b170bc6
KB
19142012-05-20 Ken Brown <kbrown@cornell.edu>
1915
1916 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 1917 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 1918
b2f4d39f
KB
19192012-05-19 Ken Brown <kbrown@cornell.edu>
1920
1921 * xfns.c (x_in_use): Remove `static' qualifier.
1922 * xterm.h (x_in_use): Declare.
1923 * xgselect.c: Include xterm.h.
1924 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
1925 and `display_arg' (bug#9754).
1926
003fdae2
PE
19272012-05-19 Paul Eggert <eggert@cs.ucla.edu>
1928
9232a6d9
PE
1929 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
1930
003fdae2
PE
1931 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
1932 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
1933
784b56e2
EZ
19342012-05-18 Eli Zaretskii <eliz@gnu.org>
1935
1936 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
1937
1938 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
1939 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
1940
1941 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
1942 reference to image_cache->refcount.
1943 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
1944
a0a79cde
JL
19452012-05-17 Juri Linkov <juri@jurta.org>
1946
1947 * search.c (Fword_search_regexp, Fword_search_backward)
1948 (Fword_search_forward, Fword_search_backward_lax)
1949 (Fword_search_forward_lax): Move functions to isearch.el
1950 (bug#10145, bug#11381).
1951
b0572523
PE
19522012-05-16 Paul Eggert <eggert@cs.ucla.edu>
1953
1954 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
1955
9660f5fc
SM
19562012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
1957
1958 * lread.c (init_obarray): Declare Qt and Qnil as special.
1959
4374de83
GM
19602012-05-14 Glenn Morris <rgm@gnu.org>
1961
1962 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 1963 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 1964
dc44c39a
PE
19652012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1966
078c97cb
PE
1967 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
1968
dc44c39a
PE
1969 * unexaix.c: Port to more-recent AIX compilers.
1970 (report_error, report_error_1, make_hdr, copy_sym)
1971 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
1972 Make arguments const char *, not char *, to avoid violations of C
1973 standard and to fix some AIX warnings reported by Gilles Pion.
1974
e18afed7 19752012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
1976
1977 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
1978 already have overlays loaded.
1979 (handle_single_display_spec): Before returning without displaying
1980 fringe bitmap, synchronize the bidi iterator with the main display
1981 iterator, by calling iterate_out_of_display_property.
1982 (iterate_out_of_display_property): Detect buffer iteration by
1983 testing that it->string is a Lisp string.
1984 (get_next_display_element): When the current object is exhausted,
1985 and there's something on it->stack, call set_iterator_to_next to
1986 proceed with what's on the stack, instead of returning zero.
1987 (set_iterator_to_next): If called at the end of a Lisp string,
1988 proceed to consider_string_end without incrementing string
1989 position. Don't increment display vector index past the end of
1990 the display vector. (Bug#11417)
c8fb9dc6
EZ
1991 (pos_visible_p): Don't report a position visible when move_it_to
1992 stopped at the last line of window, which happens to be scanned
1993 backwards by the bidi iteration. (Bug#11464)
ac268e67 1994
e18afed7 19952012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
1996
1997 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
1998 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
1999 are on a TTY, and thus unable to display on the fringes.
2000 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
2001 so we need to signal to the caller that this is a "replacing"
2002 display spec. This fixes display when the spec is invalid or we
2003 are on a TTY.
2004
e18afed7 20052012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
2006
2007 * unexaix.c (make_hdr): Fix typo in prototype.
2008 This bug broke the build on AIX. Problem reported by Gilles Pion.
2009
9d0a235a
MA
20102012-05-14 Michael Albinus <michael.albinus@gmx.de>
2011
2012 * keyboard.c (kbd_buffer_get_event): Read special events also in
2013 batch mode. (Bug#11415)
2014
9e6b06ed
GM
20152012-05-12 Glenn Morris <rgm@gnu.org>
2016
2017 * ns.mk: Update for ns_appbindir no longer having trailing "/".
2018
c1a1d7a3
EZ
20192012-05-12 Eli Zaretskii <eliz@gnu.org>
2020
2021 * lisp.mk (lisp): Add newcomment.elc.
2022
3fe7cdc8
GM
20232012-05-12 Glenn Morris <rgm@gnu.org>
2024
2025 * Makefile.in (MKDIR_P): New, set by configure.
2026 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
2027
53f7d2c0
PE
20282012-05-11 Paul Eggert <eggert@cs.ucla.edu>
2029
2030 Remove unused function hourglass_started.
2031 * dispextern.h (hourglass_started):
2032 * w32fns.c (hourglass_started):
2033 * xdisp.c (hourglass_started): Remove.
2034
75aafb17
JB
20352012-05-10 Juanma Barranquero <lekktu@gmail.com>
2036
2037 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
2038 Update dependencies.
2039
12959e8e
PE
20402012-05-10 Paul Eggert <eggert@cs.ucla.edu>
2041
97107e2e
PE
2042 * xgselect.c (xg_select): Put maxfds+1 into a var.
2043 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
2044
12959e8e
PE
2045 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
2046
836d29b3
DA
20472012-05-10 Dave Abrahams <dave@boostpro.com>
2048
2049 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
2050 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
2051
5cb67954
MA
20522012-05-09 Michael Albinus <michael.albinus@gmx.de>
2053
2054 * dbusbind.c (xd_registered_buses): New internal Lisp object.
2055 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
2056 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
2057 Initialize xd_registered_buses.
2058
3478ec45
PE
20592012-05-09 Paul Eggert <eggert@cs.ucla.edu>
2060
b263a6b0
PE
2061 Untag more efficiently if USE_LSB_TAG.
2062 This is based on a proposal by YAMAMOTO Mitsuharu in
2063 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
2064 For an admittedly artificial (nth 8000 longlist) benchmark on
2065 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
2066 Emacs's overall text size by 1%.
2067 * lisp.h (XUNTAG): New macro.
2068 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
2069 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
2070 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
2071 * eval.c (Fautoload):
2072 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
2073 * frame.h (XFRAME): Use XUNTAG.
2074
3478ec45
PE
2075 Port recent dbusbind.c changes to 32-bit --with-wide-int.
2076 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
2077 Remove unportable assumptions about print widths of types like
2078 dbus_uint32_t.
2079 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
2080 intptr_t when converting between pointer and integer, to avoid GCC
2081 warnings about wrong width.
2082
666b903b 20832012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
2084
2085 * w32proc.c (new_child): Force Windows to reserve only 64KB of
2086 stack for each reader_thread, instead of defaulting to 8MB
2087 determined by the linker. This avoids failures in creating
2088 subprocesses on Windows 7, see the discussion in this thread:
2089 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
2090
b120cc17
JC
20912012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
2092
2093 Fix up display of the *Minibuf-0* buffer in the mini window.
2094 * keyboard.c (read_char): Don't clear the echo area if there's no
2095 message to clear.
2096 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 2097 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 2098
9a4b36f8
MA
20992012-05-07 Michael Albinus <michael.albinus@gmx.de>
2100
2101 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
2102 batch mode.
2103
e5f9458f
CY
21042012-05-06 Chong Yidong <cyd@gnu.org>
2105
2106 * lisp.mk (lisp): Update.
2107
eceeb5fc 21082012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
2109
2110 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
2111
71873e2b
SM
21122012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
2113
2114 * data.c (PUT_ERROR): New macro.
2115 (syms_of_data): Use it. Add new error type `user-error'.
2116 * undo.c (user_error): New function.
2117 (Fprimitive_undo): Use it.
2118 * print.c (print_error_message): Adjust print style for `user-error'.
2119 * keyboard.c (user_error): New function.
2120 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
2121
ab0fa4e4
PE
21222012-05-03 Paul Eggert <eggert@cs.ucla.edu>
2123
2124 Do not limit current-time-string to years 1000..9999.
2125 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
2126 (Fcurrent_time_string): Support any year that is supported by the
2127 underlying localtime representation. Don't use asctime, as it
2128 has undefined behavior for years outside the range -999..9999.
2129
7ed806a7
PE
21302012-05-02 Paul Eggert <eggert@cs.ucla.edu>
2131
2132 Fix race conditions involving setenv, gmtime, localtime, asctime.
2133 Without this fix, interrupts could mess up code that uses these
2134 nonreentrant functions, since setting TZ invalidates existing
2135 tm_zone or tzname values, and since most of these functions return
2136 pointers to static storage.
2137 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
2138 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
2139 Grow the critical sections to include not just invoking
2140 localtime/gmtime, but also accessing these functions' results
2141 including their tm_zone values if any, and any related TZ setting.
2142 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
2143 so that the struct tm is saved in the critical section.
2144 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
2145 motivated by the fact that memory allocation needs to be outside
2146 the critical section.
2147
0c16dfed
DA
21482012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
2149
2150 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
2151 with RESET_INTERVAL.
2152
2153 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2154 Remove duplicated buffer name initialization.
2155
3f83ace8
JM
21562012-05-02 Jim Meyering <jim@meyering.net>
2157
2158 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
2159
c7b8541e
JM
2160 * xfns.c (x_window): Use xstrdup (Bug#11375).
2161
90207a15 21622012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
2163
2164 * xdisp.c (pos_visible_p): If already at a newline from the
2165 display string before the 'while' loop, don't walk back the glyphs
2166 from it3.glyph_row. Solves assertion violation when the display
2167 string begins with a newline (egg.el). (Bug#11367)
2168
b593d6a9
AH
21692012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
2170
2171 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
2172 Move to simple.el.
2173
4737362e
GM
21742012-05-01 Glenn Morris <rgm@gnu.org>
2175
99cf43f9
GM
2176 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
2177 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
2178 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
2179 All were removed before 23.1.
2180
9311dcff
GM
2181 * dispnew.c: Remove HAVE_LIBNCURSES test;
2182 it is always true on relevant platforms.
2183
4d5c6349
GM
2184 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
2185 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
2186
4737362e
GM
2187 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
2188
74dd3a6b
AS
21892012-04-30 Andreas Schwab <schwab@linux-m68k.org>
2190
2191 * .gdbinit (xpr): Remove checks for no longer existing misc types.
2192 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
2193 Remove.
2194
13c379ee
PE
21952012-04-28 Paul Eggert <eggert@cs.ucla.edu>
2196
2197 Do not avoid creating empty evaporating overlays (Bug#9642).
2198 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
2199 That is, do not delete an evaporating overlay if it becomes
2200 empty after its bounds are adjusted to fit within its buffer.
2201 This fix caused other problems, and I'm reverting it until we get
2202 to the bottom of them.
2203
a8e7d6d7 22042012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
2205
2206 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
2207
a8e7d6d7 22082012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
2209
2210 * xdisp.c (pos_visible_p): If the window start position is beyond
2211 ZV, start the display from buffer beginning. Prevents assertion
2212 violation in init_iterator when the minibuffer window is scrolled
2213 via the scroll bar.
2214
2215 * window.c (window_scroll_pixel_based): Likewise.
2216
a8e7d6d7 22172012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
2218
2219 * keymap.c (where_is_internal): Doc fix (Bug#10872).
2220
a8e7d6d7 22212012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
2222
2223 * fileio.c (Fcopy_file, Fset_file_selinux_context):
2224 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
2225
a8e7d6d7 22262012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 2227
b593d6a9
AH
2228 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
2229 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 2230
1c6900d9
EZ
22312012-04-26 Eli Zaretskii <eliz@gnu.org>
2232
4c3fa1d9
EZ
2233 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
2234 display element, check also the underlying string or buffer
2235 character. (Bug#11341)
2236
1c6900d9
EZ
2237 * w32menu.c: Include w32heap.h.
2238 (add_menu_item): If the call to AppendMenuW (via
2239 unicode_append_menu) fails, disable Unicode menus only if we are
2240 running on Windows 9X/Me.
2241
42bf8205
AS
22422012-04-24 Andreas Schwab <schwab@linux-m68k.org>
2243
2244 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
2245 (xgetint): Add missing shift for LSB tags.
2246
b1bac16e
MR
22472012-04-24 Martin Rudalics <rudalics@gmx.at>
2248
2249 * keyboard.c (read_char): Don't wipe echo area for select window
2250 events: These might get delayed via `mouse-autoselect-window'
2251 (Bug#11304).
2252
d69621cc
JB
22532012-04-24 Juanma Barranquero <lekktu@gmail.com>
2254
2255 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
2256 manipulation of :loaded-from data.
2257
02fd101b
JB
22582012-04-23 Juanma Barranquero <lekktu@gmail.com>
2259
2260 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
2261 now a cons (bug#11311).
2262
888bec30
PE
22632012-04-23 Paul Eggert <eggert@cs.ucla.edu>
2264
89a438bd
PE
2265 Do not create empty overlays with the evaporate property (Bug#9642).
2266 * buffer.c (Fmove_overlay): Delete an evaporating overlay
2267 if it becomes empty after its bounds are adjusted to fit within
2268 its buffer. Without this fix, in a nonempty buffer (let ((o
2269 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
2270 yields an empty overlay that has the evaporate property, which is
2271 not supposed to happen.
2272
1068fe4d
PE
2273 Fix minor GTK3 problems found by static checking.
2274 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2275 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2276 (struct _EmacsFixedClass, emacs_fixed_get_type):
2277 Move decls here from emacsgtkfixed.h, since they needn't be public.
2278 (emacs_fixed_get_type): Now static.
2279 (emacs_fixed_class_init): Omit unused local.
2280 (emacs_fixed_child_type): Remove; unused.
2281 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2282 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2283 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
2284 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
2285 (EMACS_FIXED_GET_CLASS): Remove; unused.
2286 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
2287
888bec30
PE
2288 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
2289 Problem reported by Juanma Barranquero for Windows -Wunused-function.
2290
de85e130
PE
22912012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2292
d0baac98 2293 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 2294 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
2295 (__malloc_size_t, __malloc_ptrdiff_t):
2296 Remove. All uses removed, replaced by the definiens if needed,
2297 since we can assume C89 or better now.
2298 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
2299 (protect_malloc_state, align, get_contiguous_space)
2300 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
2301 (malloc_atfork_handler_child, malloc_enable_thread)
2302 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
2303 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
2304 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
2305 (special_realloc, _realloc_internal_nolock, _realloc_internal)
2306 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
2307 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
2308 Define using prototypes, not old style.
2309 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
2310 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
2311 (align): Don't assume that signed integer overflow wraps around.
2312 Omit unused local var.
2313 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
2314 (_free_internal_nolock, memalign, mallochook, reallochook):
2315 Omit no-longer-needed casts.
2316 (valloc): Use getpagesize, not __getpagesize.
2317 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
2318 (struct hdr): The 'magic' member is now size_t, not unsigned long.
2319
de85e130
PE
2320 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
2321
dcbf5805
MA
23222012-04-22 Michael Albinus <michael.albinus@gmx.de>
2323
2324 Move functions from C to Lisp. Make non-blocking method calls
2325 the default. Implement further D-Bus standard interfaces.
2326
2327 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
2328 (QCdbus_request_name_allow_replacement)
2329 (QCdbus_request_name_replace_existing)
2330 (QCdbus_request_name_do_not_queue)
2331 (QCdbus_request_name_reply_primary_owner)
2332 (QCdbus_request_name_reply_in_queue)
2333 (QCdbus_request_name_reply_exists)
2334 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
2335 (QCdbus_registered_serial, QCdbus_registered_method)
2336 (QCdbus_registered_signal): New Lisp objects.
2337 (XD_DEBUG_MESSAGE): Use sizeof.
2338 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
2339 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
2340 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
2341 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
2342 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
2343 (xd_signature, xd_append_arg): Allow float for integer types.
2344 (xd_get_connection_references): New function.
b593d6a9
AH
2345 (xd_get_connection_address): Rename from xd_initialize.
2346 Return cached address.
dcbf5805
MA
2347 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
2348 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
2349 level.
2350 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 2351 Return number of refcounts.
dcbf5805
MA
2352 (Fdbus_get_unique_name): Make stronger parameter check.
2353 (Fdbus_message_internal): New defun.
2354 (Fdbus_call_method, Fdbus_call_method_asynchronously)
2355 (Fdbus_method_return_internal, Fdbus_method_error_internal)
2356 (Fdbus_send_signal, Fdbus_register_service)
2357 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
2358 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
2359 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
2360 (Vdbus_compiled_version, Vdbus_runtime_version)
2361 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
2362 (Vdbus_message_type_method_return, Vdbus_message_type_error)
2363 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
2364 (Vdbus_registered_buses, Vdbus_registered_objects_table):
2365 Adapt docstring.
dcbf5805 2366
52828e02
PE
23672012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2368
da05bc4c
PE
2369 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
2370 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
2371 Do not assume ptrdiff_t is the same width as 'int'.
2372
52828e02
PE
2373 * alloc.c: Handle unusual debugging option combinations.
2374 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
2375 since the two debugging options are incompatible.
2376 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
2377 is defined.
2378 (mem_init, mem_insert, mem_insert_fixup):
2379 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
2380 (NEED_MEM_INSERT): Remove; no longer needed.
2381
f01769f9
LL
23822012-04-22 Leo Liu <sdl.web@gmail.com>
2383
2384 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
2385
5790543d
PE
23862012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2387
2388 * sysdep.c [__FreeBSD__]: Minor cleanups.
2389 (list_system_processes, system_process_attributes) [__FreeBSD__]:
2390 Use Emacs indenting style more consistently. Avoid some casts.
2391 Use 'double' consistently rather than mixing 'float' and 'double'.
2392
b91b7e4d
EW
23932012-04-21 Eduard Wiebe <usenet@pusto.de>
2394
b593d6a9
AH
2395 * sysdep.c (list_system_processes, system_process_attributes):
2396 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 2397
6114eb15
AS
23982012-04-21 Andreas Schwab <schwab@linux-m68k.org>
2399
2400 * lisp.mk (lisp): Update.
2401
2f38dff7
PE
24022012-04-20 Paul Eggert <eggert@cs.ucla.edu>
2403
2404 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
2405 It is never used otherwise.
2406
4ae29f89
SM
24072012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
2408
2409 * print.c (print_preprocess): Only check print_depth if print-circle
2410 is nil.
2411 (print_object): Check for cycles even when print-circle is nil and
2412 print-gensym is t, but only check print_depth if print-circle is nil.
2413
f30d612a
CY
24142012-04-20 Chong Yidong <cyd@gnu.org>
2415
2416 * process.c (wait_reading_process_output): If EIO occurs on a pty,
2417 set the status to "failed" and ensure that sentinel is run.
2418
c07a4c0b 24192012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
2420
2421 * process.c (Fset_process_inherit_coding_system_flag)
2422 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 2423 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 2424
c07a4c0b 24252012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
2426
2427 * xdisp.c (string_buffer_position_lim): Limit starting position to
2428 BEGV.
2429 (set_cursor_from_row): If called for a mode-line or header-line
2430 row, return zero immediately.
2431 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
2432 farther than the first row after the header line, if any.
2433 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
2434 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
2435
c07a4c0b 24362012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 2437
4ae29f89
SM
2438 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
2439 (bug#11238).
ad3a2b41 2440
c07a4c0b 24412012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 24422012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
2443
2444 configure: new option --enable-gcc-warnings (Bug#11207)
2445 * Makefile.in (C_WARNINGS_SWITCH): Remove.
2446 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
2447 (ALL_CFLAGS): Use new macros rather than old.
2448 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
2449 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
2450 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
2451 -Wunused-result, -Wunused-variable. This should go away once
2452 the Emacs and Gnulib regex code is merged.
2453 (xmalloc, xrealloc): Now static.
2454
aba027e8
PE
24552012-04-17 Paul Eggert <eggert@cs.ucla.edu>
2456
2457 * dired.c (Fsystem_groups): Remove unused local.
2458
e5a36063
GM
24592012-04-17 Glenn Morris <rgm@gnu.org>
2460
2461 * dired.c (Fsystem_users): Doc fix.
2462
316411f0
DA
24632012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
2464
2465 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
2466 (syms_of_dired): Add them.
2467
9426aba4
PE
24682012-04-16 Paul Eggert <eggert@cs.ucla.edu>
2469
b62a57be
PE
2470 Fix minor alloc.c problems found by static checking.
2471 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
2472 New extern decls, to avoid calling undeclared functions.
2473 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
2474 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
2475 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
2476 (NEED_MEM_INSERT): New macro.
2477 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 2478 Remove one incorrect comment and fix another.
b62a57be 2479
3539f31f
PE
2480 Fix minor ralloc.c problems found by static checking.
2481 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2482 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
2483 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
2484 (r_alloc_sbrk): Now static.
2485
a041960a
PE
2486 Improve ralloc.c interface checking.
2487 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2488 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
2489 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
2490 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
2491 [REL_ALLOC]: ... to here, to check interface.
2492 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
2493 Remove decls. This fixes an "It stinks!".
2494
9426aba4
PE
2495 * alloc.c (which_symbols): Fix alignment issue / type clash.
2496
d55c12ed
AS
24972012-04-15 Andreas Schwab <schwab@linux-m68k.org>
2498
2499 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
2500 (struct Lisp_Misc_Any): Likewise.
2501 (struct Lisp_Free): Likewise.
2502 * alloc.c (union aligned_Lisp_Symbol): Define.
2503 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
2504 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
2505 (union aligned_Lisp_Misc): Define.
2506 (MARKER_BLOCK_SIZE, struct marker_block): Use union
2507 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 2508 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 2509
b948ce8b
PE
25102012-04-14 Paul Eggert <eggert@cs.ucla.edu>
2511
2512 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
2513 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
2514 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
2515 * s/netbsd.h, s/sol2-6.h:
2516 Remove definition of GC_MARK_STACK, since the default now works.
2517 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
2518 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
2519 no longer the default.
2520 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
2521
35dc09a1 25222012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 2523
35dc09a1
GM
2524 * lread.c (lisp_file_lexically_bound_p):
2525 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 2526
35dc09a1
GM
25272012-04-14 Eli Zaretskii <eliz@gnu.org>
2528
2529 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
2530 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
2531
25322012-04-14 Jan Djärv <jan.h.d@swipnet.se>
2533
2534 * nsterm.m (constrainFrameRect): Always constrain when there is only
2535 one screen (Bug#10962).
2536
bcd86815
KB
25372012-04-13 Ken Brown <kbrown@cornell.edu>
2538
2539 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
2540
c25df26e
RT
25412012-04-13 Reuben Thomas <rrt@sc3d.org>
2542
2543 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
2544
0fc59f1e
DC
25452012-04-11 Daniel Colascione <dancol@dancol.org>
2546
2547 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
2548 against is gone. It's better to use vfork now so that when Cygwin
2549 gains a new, working vfork, we use it automatically (bug#10398).
2550
de8c03dc
SM
25512012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2552
2553 * window.c (save_window_save): Obey window-point-insertion-type.
2554
2f097256
GM
25552012-04-11 Glenn Morris <rgm@gnu.org>
2556
2557 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
2558
453b951e
SM
25592012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2560
2561 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
2562
75f1671a 25632012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
2564
2565 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
2566 (force_quit_count): New var.
2567 (handle_interrupt): Use it.
2568
2a8ce227
JB
25692012-04-10 Juanma Barranquero <lekktu@gmail.com>
2570
2571 * w32.c (w32_delayed_load): Record the full path of the library
2572 being loaded (bug#10424).
2573
935396c0
GM
25742012-04-09 Glenn Morris <rgm@gnu.org>
2575
05920a43
GM
2576 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
2577 not just in the obarray, before snarfing them. (Bug#11036)
2578
935396c0
GM
2579 * Makefile.in ($(leimdir)/leim-list.el):
2580 Pass EMACS rather than BUILT_EMACS.
2581
a18ecafa
TZ
25822012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
2583
2584 * process.c (make_process):
2585 * process.h: Add integer `gnutls_handshakes_tried' member to
2586 process struct.
2587
6bbef4e5
JC
2588 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
2589 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
2590
2591 * gnutls.c (gnutls_log_function2i): Convenience log function.
2592 (emacs_gnutls_read): Use new log functions,
2593 `gnutls_handshakes_tried' process member, and
2594 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
2595 attempts per process (connection).
2596
b4d3bc10
CY
25972012-04-09 Chong Yidong <cyd@gnu.org>
2598
2599 * eval.c (Fuser_variable_p, user_variable_p_eh)
2600 (lisp_indirect_variable): Functions deleted.
2601 (Fdefvar): Caller changed.
2602
2603 * callint.c (Finteractive, Fcall_interactively):
2604 * minibuf.c (Fread_variable): Callers changed.
2605
70f4d973
EZ
26062012-04-09 Eli Zaretskii <eliz@gnu.org>
2607
2608 * xdisp.c (set_cursor_from_row): If the display string appears in
2609 the buffer at position that is closer to point than the position
2610 after the display string, display the cursor on the first glyph of
2611 the display string. Fixes cursor display when a 'display' text
2612 property immediately follows invisible text. (Bug#11094)
2613
cb3c2e3e
PE
26142012-04-09 Paul Eggert <eggert@cs.ucla.edu>
2615
2616 composite.c: use 'double' consistently
2617 * composite.c (get_composition_id): Use 'double' consistently
2618 instead of converting 'float' to 'double' and vice versa; this is
2619 easier to understand and avoids a GCC warning.
2620
fd06db5d
GM
26212012-04-09 Glenn Morris <rgm@gnu.org>
2622
50fe702a
GM
2623 * Makefile.in: Generate leim-list with bootstrap-emacs, in
2624 preparation for dumping it with emacs. (Bug#4789)
2625 (leimdir): New variable.
2626 ($(leimdir)/leim-list.el): New rule.
2627 (emacs$(EXEEXT)): Depend on leim-list.el.
2628
fd06db5d
GM
2629 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
2630 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
2631 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
2632
55c131ee
AS
26332012-04-08 Andreas Schwab <schwab@linux-m68k.org>
2634
2635 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
2636 proper alignment.
2637
9209588f
JB
26382012-04-07 Juanma Barranquero <lekktu@gmail.com>
2639
2640 * xml.c (init_libxml2_functions) [WINDOWSNT]:
2641 Remove unused local variable.
2642
e3fb2efb
PE
26432012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2644
2645 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
2646 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
2647 (mark_memory): Mark Lisp_Objects only if pointers might hide in
2648 objects, as mark_maybe_pointer will catch them otherwise.
2649 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
2650 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
2651
b5385551
PE
26522012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2653
2654 Fix typo that broke non-Windows builds.
2655 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
2656
9078ead6
EZ
26572012-04-07 Eli Zaretskii <eliz@gnu.org>
2658
2659 Support building on MS-Windows with libxml2.
2660
2661 * makefile.w32-in (OBJ2): Add xml.$(O).
2662 (GLOBAL_SOURCES): Add xml.c.
2663 ($(BLD)/xml.$(O)): New dependency list.
2664
2665 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
2666 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
2667 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
2668 [!WINDOWSNT]: New macros.
2669 (init_libxml2_functions, libxml2_loaded_p): New functions.
2670 (parse_region): Call fn_xmlCheckVersion instead of using the macro
2671 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
2672 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
2673 Calls xmlCleanupParser only if libxml2 was loaded (or statically
2674 linked in).
6bbef4e5
JC
2675 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
2676 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
2677 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
2678
2679 * emacs.c: Don't include libxml/parser.h.
2680 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
2681 xmlCleanupParser directly.
2682
2683 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
2684
3811fdf3
EZ
26852012-04-07 Eli Zaretskii <eliz@gnu.org>
2686
2687 * indent.c (Fvertical_motion): If there is a display string at
2688 point, use it.vpos to compute how many lines to backtrack after
2689 move_it_to point. (Bug#11133)
2690
2f8e16b2
EZ
26912012-04-06 Eli Zaretskii <eliz@gnu.org>
2692
2693 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
2694 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
2695 about subtle differences between FETCH_CHAR* and STRING_CHAR*
2696 macros related to unification of CJK characters. For the details,
2697 see the discussion following the message here:
2698 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
2699
3d439cd1
CY
27002012-04-04 Chong Yidong <cyd@gnu.org>
2701
2702 * keyboard.c (Vdelayed_warnings_list): Doc fix.
2703
8bc53d00
EZ
27042012-04-01 Eli Zaretskii <eliz@gnu.org>
2705
2706 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
2707 instead of alloca. (Bug#11138)
2708
3b0512a3
AS
27092012-04-01 Andreas Schwab <schwab@linux-m68k.org>
2710
2711 * w32menu.c (is_simple_dialog): Properly check lisp types.
2712 (Bug#11141)
2713
8427ddd2
EZ
27142012-03-31 Eli Zaretskii <eliz@gnu.org>
2715
979022ef
EZ
2716 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
2717 position we get to after a call to move_it_to fails the
2718 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
2719 only if we wind up in a string from display property. (Bug#11063)
2720
a6b1c7cc
EZ
2721 * window.c (Fdelete_other_windows_internal): Invalidate the row
2722 and column information about mouse highlight, so that redisplay
2723 restores it after reallocating the glyph matrices. (Bug#7464)
2724
8427ddd2
EZ
2725 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
2726 string comes from a `display' text property, use the buffer
2727 position of that property as if we actually saw that position in
2728 the row's glyphs.
697ba24b
EZ
2729 (move_it_by_lines): Remove the assertion that
2730 "it->current_x == 0 && it->hpos == 0" which can be legitimately
2731 violated when there's a before-string at the beginning of a line.
2732 (Bug#11063)
8427ddd2 2733
65a0a738
EZ
27342012-03-30 Eli Zaretskii <eliz@gnu.org>
2735
2736 * xdisp.c (append_space_for_newline): If the default face was
2737 remapped, use the remapped face for the appended newline.
2738 (extend_face_to_end_of_line): Use the remapped default face for
2739 extending the face to the end of the line.
2740 (display_line): Call extend_face_to_end_of_line when the default
2741 face was remapped. (Bug#11068)
2742
581355cc
EZ
27432012-03-29 Eli Zaretskii <eliz@gnu.org>
2744
2745 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
2746
e8fc049f
SM
27472012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2748
2749 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
2750
4fb9a543
GM
27512012-03-27 Glenn Morris <rgm@gnu.org>
2752
2753 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
2754 Doc fixes.
2755
679910f1
KH
27562012-03-26 Kenichi Handa <handa@m17n.org>
2757
2758 * dispextern.h (struct glyph): Fix previous change. Change the
2759 bit length of glyphless.ch to 25 (Bug#11082).
2760
90d49b7f
CY
27612012-03-26 Chong Yidong <cyd@gnu.org>
2762
2763 * keyboard.c (Vselection_inhibit_update_commands): New variable.
2764 (command_loop_1): Use it; inhibit selection update for
2765 handle-select-window too (Bug#8996).
2766
f514f6f0
FP
27672012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
2768
e8fc049f 2769 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 2770
bf43fa51
KH
27712012-03-25 Kenichi Handa <handa@m17n.org>
2772
2773 * dispextern.h (struct glyph): Change the bit length of
2774 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
2775
8a0c01dd
EZ
27762012-03-24 Eli Zaretskii <eliz@gnu.org>
2777
2778 * s/ms-w32.h (tzname): Include time.h before redirecting to
2779 _tzname. Fixes the MSVC build. (Bug#9960)
2780
7d1c3a76
AS
27812012-03-24 Andreas Schwab <schwab@linux-m68k.org>
2782
8ed79523
AS
2783 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
2784 characters.
2785
7d1c3a76
AS
2786 * xterm.c (XTread_socket): Only modify handling_signal if
2787 !SYNC_INPUT. (Bug#11080)
2788
e99a9b8b
EZ
27892012-03-23 Eli Zaretskii <eliz@gnu.org>
2790
2791 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
2792 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
2793 when fetching a multibyte character consumes more bytes than
2794 CHAR_BYTES returns, due to unification of CJK characters in
2795 string_char. (Bug#11073)
2796
5063c0e1
TN
27972012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
2798
2799 * process.c (wait_reading_process_output): Handle pty disconnect
2800 by refraining from sending oneself a SIGCHLD (bug#10933).
2801
9f851fbd
CY
28022012-03-22 Chong Yidong <cyd@gnu.org>
2803
2804 * dispextern.h (struct it): New member string_from_prefix_prop_p.
2805
5063c0e1 2806 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
2807 Mark string as coming from a prefix property.
2808 (handle_face_prop): Use default face for prefix strings (Bug#4281).
2809 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
2810
fb5b8aca
CY
28112012-03-21 Chong Yidong <cyd@gnu.org>
2812
2813 * xfaces.c (Vface_remapping_alist): Doc fix.
2814
62356a1b
EZ
28152012-03-20 Eli Zaretskii <eliz@gnu.org>
2816
2817 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
2818 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
2819 Doc fixes.
62356a1b 2820
025de85b
CY
28212012-03-20 Chong Yidong <cyd@gnu.org>
2822
2823 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
2824 to reflect default non-nil value of redisplay-dont-pause.
2825
4827f94e
KH
28262012-03-19 Kenichi Handa <handa@m17n.org>
2827
2828 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
2829 it fit in a valid range (Bug#11003).
2830
e50a24a2
EZ
28312012-03-18 Eli Zaretskii <eliz@gnu.org>
2832
2833 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
2834 that is not from display property, accept the row as a "cursor
2835 row" if one of the string's character has a non-nil `cursor'
2836 property. Fixes cursor positioning when there are newlines in
2837 overlay strings, e.g. in icomplete.el. (Bug#11035)
2838
9af5ed87
PE
28392012-03-12 Paul Eggert <eggert@cs.ucla.edu>
2840
2841 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
2842
d1f55f16
CY
28432012-03-12 Chong Yidong <cyd@gnu.org>
2844
2845 * eval.c (inhibit_lisp_code): Rename from
2846 inhibit_window_configuration_change_hook; move from window.c.
2847
2848 * xfns.c (unwind_create_frame_1, Fx_create_frame):
2849 * window.c (run_window_configuration_change_hook)
2850 (syms_of_window): Callers changed.
2851
66c5eebd
CY
28522012-03-11 Chong Yidong <cyd@gnu.org>
2853
413df973
CY
2854 * keymap.c (Fkey_description): Doc fix (Bug#9700).
2855
66c5eebd
CY
2856 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
2857
1de11f56
CY
28582012-03-10 Chong Yidong <cyd@gnu.org>
2859
2860 * frame.c (other_visible_frames): Don't assume the selected frame
2861 is visible (Bug#10955).
2862
cae07000
SM
28632012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
2864
2865 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
2866
89c94350
JD
28672012-03-08 Jan Djärv <jan.h.d@swipnet.se>
2868
2869 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
2870 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
2871 zero (Bug#10954).
2872
999dd333
GM
28732012-03-03 Glenn Morris <rgm@gnu.org>
2874
01a6dcc8 2875 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 2876
de0100f2
EZ
28772012-03-02 Eli Zaretskii <eliz@gnu.org>
2878
2879 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
2880 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
2881 (redisplay_window, next_element_from_string): Fix typos in
2882 comments.
3e441275
EZ
2883 (redisplay_window): Pass to move_it_vertically the margin in
2884 pixels, not in screen lines.
de0100f2 2885
96a72ee9
GM
28862012-03-02 Glenn Morris <rgm@gnu.org>
2887
2888 * buffer.c (buffer-list-update-hook): Doc fix.
2889
312508d7
EZ
28902012-02-29 Eli Zaretskii <eliz@gnu.org>
2891
2892 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
2893 push_it before setting up the iterator for the first overlay
2894 string, even if we have an empty string loaded.
2895 (next_overlay_string): If there's an empty string on the iterator
2896 stack, pop the stack. (Bug#10903)
2897
27f3c637
PE
28982012-02-25 Paul Eggert <eggert@cs.ucla.edu>
2899
2900 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
2901 Suggested by Stefan Monnier in
2902 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
2903 * alloc.c (widen_to_Lisp_Object): New static function.
2904 (mark_memory): Also mark Lisp_Objects by fetching pointer words
2905 and widening them to Lisp_Objects. This would work even if
2906 USE_LSB_TAG is defined and wide integers are used, which might
2907 happen in a future version of Emacs.
2908
3c9dfce6
CY
29092012-02-25 Chong Yidong <cyd@gnu.org>
2910
fa74b241
CY
2911 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
2912 Doc fix.
2913
3c9dfce6
CY
2914 * xselect.c (Fx_selection_exists_p): Doc fix.
2915 (x_clipboard_manager_save_all): Print an informative message
2916 before saving to clipboard manager.
2917
9486df08
CY
29182012-02-24 Chong Yidong <cyd@gnu.org>
2919
2920 * keyboard.c (process_special_events): Handle all X selection
2921 requests in kbd_buffer, not just the next one (Bug#8869).
2922
f01d3321
CY
29232012-02-23 Chong Yidong <cyd@gnu.org>
2924
2925 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
2926 call when setting menu-bar-lines and tool-bar-lines parameters.
2927 (unwind_create_frame_1): New helper function.
2928
2929 * window.c (inhibit_window_configuration_change_hook): New var.
2930 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 2931 (syms_of_window): Initialize it.
f01d3321 2932
86b847b6
CY
29332012-02-22 Chong Yidong <cyd@gnu.org>
2934
2935 * xterm.c (x_draw_image_relief): Add missing type check for
2936 Vtool_bar_button_margin (Bug#10743).
2937
a59225b1
CY
29382012-02-21 Chong Yidong <cyd@gnu.org>
2939
2940 * fileio.c (Vfile_name_handler_alist): Doc fix.
2941
2942 * buffer.c (Fget_file_buffer): Protect against invalid file
2943 handler return value.
2944
310f5bd4
PE
29452012-02-20 Paul Eggert <eggert@cs.ucla.edu>
2946
cb3a28cc
PE
2947 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
2948 when computing $valmask.
2949
310f5bd4
PE
2950 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
2951 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
2952 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
2953 It's useless in that case, and it can cause problems on hosts
2954 that allocate halves of EMACS_INT values separately.
2955 Reported by Dan Horák. Diagnosed by Andreas Schwab in
2956 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
2957 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
2958 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
2959 it avoids undefined behavior on hosts where shifting right by more
2960 than the word width has undefined behavior.
2961
2375c96a
CY
29622012-02-19 Chong Yidong <cyd@gnu.org>
2963
2964 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
2965 (Funhandled_file_name_directory, Ffile_name_as_directory)
2966 (Fdirectory_file_name, Fexpand_file_name)
2967 (Fsubstitute_in_file_name): Protect against invalid file handler
2968 return values (Bug#10845).
2969
3eb49e71
EZ
29702012-02-18 Eli Zaretskii <eliz@gnu.org>
2971
2972 * .gdbinit (pitx): Fix incorrect references to fields of the
2973 iterator stack.
2974
7b926f3f
CY
29752012-02-17 Chong Yidong <cyd@gnu.org>
2976
2977 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
2978
11273115
PE
29792012-02-15 Paul Eggert <eggert@cs.ucla.edu>
2980
2981 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
2982 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
2983
c3a70e2b
CY
29842012-02-15 Chong Yidong <cyd@gnu.org>
2985
2986 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
2987 marked as special. Also, starting docstrings with * is obsolete.
2988
0ca43699
AS
29892012-02-13 Andreas Schwab <schwab@linux-m68k.org>
2990
2991 * gnutls.c (emacs_gnutls_write): Fix last change.
2992
2e8f3c56
LI
29932012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
2994
2995 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
2996 send_process.
2997
af70074f
SM
29982012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
2999
3000 * keymap.c (Fsingle_key_description): Handle char ranges.
3001
95986d52
CY
30022012-02-12 Chong Yidong <cyd@gnu.org>
3003
afd83bd1
CY
3004 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
3005 as that creates a dangerous corner case.
3006
95986d52
CY
3007 * window.c (Fdelete_window_internal): Invalidate the mouse
3008 highlight (Bug#9904).
3009
bd7da63e
GM
30102012-02-12 Glenn Morris <rgm@gnu.org>
3011
3012 * xselect.c (Fx_own_selection_internal)
3013 (Fx_get_selection_internal, Fx_disown_selection_internal)
3014 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
3015 * nsselect.m (Fx_own_selection_internal)
3016 (Fx_disown_selection_internal, Fx_selection_exists_p)
3017 (Fx_selection_owner_p, Fx_get_selection_internal):
3018 Sync docs and argument specs with the xselect.c versions.
3019
77abcbc2
LI
30202012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
3021
3022 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
3023
90b671e2
EZ
30242012-02-11 Eli Zaretskii <eliz@gnu.org>
3025
1c0ca0b7
EZ
3026 * w32select.c (Fx_selection_exists_p): Sync doc string and
3027 argument list with xselect.c. (Bug#10783)
3028
3029 * w16select.c (Fx_selection_exists_p): Sync doc string and
3030 argument list with xselect.c. (Bug#10783)
90b671e2 3031
49241268
GM
30322012-02-10 Glenn Morris <rgm@gnu.org>
3033
3034 * fns.c (Fsecure_hash): Doc fix.
3035
f998bbe7 30362012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
3037
3038 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
3039
0992bd9c
CY
30402012-02-07 Chong Yidong <cyd@gnu.org>
3041
3042 * buffer.c (Fbuffer_local_variables)
3043 (buffer_lisp_local_variables): Handle unbound vars correctly;
3044 don't let Qunbound leak into Lisp.
3045
af008560
GM
30462012-02-07 Glenn Morris <rgm@gnu.org>
3047
dd605cc4
GM
3048 * image.c (Fimagemagick_types): Doc fix.
3049
af008560
GM
3050 * image.c (imagemagick-render-type): Change it from a lisp object
3051 to an integer. Move the doc here from the lisp manual.
3052 Treat all values not equal to 0 the same.
3053
1449fa1d
CY
30542012-02-06 Chong Yidong <cyd@gnu.org>
3055
3056 * doc.c (store_function_docstring): Avoid applying docstring of
3057 alias to base function (Bug#2603).
3058
3723ec07
AS
30592012-02-04 Andreas Schwab <schwab@linux-m68k.org>
3060
3061 * .gdbinit (pp1, pv1): Remove redundant defines.
3062 (pr): Use pp.
3063
79c1cc1e
CY
30642012-02-04 Chong Yidong <cyd@gnu.org>
3065
3066 * nsterm.m: Declare a global (Bug#10694).
3067
d7f29f8e
EZ
30682012-02-04 Eli Zaretskii <eliz@gnu.org>
3069
cae07000
SM
3070 * w32.c (get_emacs_configuration_options):
3071 Include --enable-checking, if specified, in the return value.
d7f29f8e 3072
3b95a6f9
MR
30732012-02-04 Martin Rudalics <rudalics@gmx.at>
3074
3075 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
3076 after rounding frame sizes. (Bug#9723)
3077
d6fa96a6
EZ
30782012-02-04 Eli Zaretskii <eliz@gnu.org>
3079
3080 * keyboard.c (adjust_point_for_property): Don't position point
3081 before BEGV. (Bug#10696)
3082
df0b2940
PE
30832012-02-03 Paul Eggert <eggert@cs.ucla.edu>
3084
3085 Handle overflow when computing char display width (Bug#9496).
3086 * character.c (char_width): Return EMACS_INT, not int.
3087 (char_width, c_string_width): Check for overflow when
3088 computing the width; this is possible now that individual
3089 characters can have unbounded width. Problem introduced
3090 by merge from Emacs 23 on 2012-01-19.
3091
6bee44d6
MA
30922012-02-02 Michael Albinus <michael.albinus@gmx.de>
3093
3094 * dbusbind.c (Fdbus_register_method): Mention the return value
3095 :ignore in the docstring.
3096
44f92739
GM
30972012-02-02 Glenn Morris <rgm@gnu.org>
3098
1b9f60cc
GM
3099 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
3100
44f92739
GM
3101 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3102 Unconditionally set to t. (Bug#10673)
3103 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3104 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3105 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
3106
c5d3843c
KH
31072012-02-02 Kenichi Handa <handa@m17n.org>
3108
3109 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
3110 0, do not call append_composite_glyph.
3111
159462d4 31122012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
3113
3114 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
3115 NULL (Bug#6988).
3116 (x_produce_glyphs): If the component of a composition is a null
3117 string, set it->pixel_width to 1 to avoid zero-width glyph.
3118
78cef877
EZ
31192012-02-01 Eli Zaretskii <eliz@gnu.org>
3120
3121 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
3122 first 2 arguments are identical. This makes inserting large
3123 output from a subprocess an order of magnitude faster on
3124 MS-Windows, where all sbrk'ed memory is always contiguous.
3125
97897668
GM
31262012-01-31 Glenn Morris <rgm@gnu.org>
3127
3128 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 3129 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
3130 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
3131
31fd3586
GM
31322012-01-29 Glenn Morris <rgm@gnu.org>
3133
3134 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
3135
0e24a8b2
CY
31362012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
3137
3138 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
3139
cc0adcb0
CY
31402012-01-28 Chong Yidong <cyd@gnu.org>
3141
3142 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
3143
acc28cb9
CY
31442012-01-26 Chong Yidong <cyd@gnu.org>
3145
9c69cfb7
CY
3146 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
3147
acc28cb9
CY
3148 * search.c (Fsearch_forward, Fsearch_backward): Document negative
3149 repeat counts (Bug#10507).
3150
48da7392
GM
31512012-01-26 Glenn Morris <rgm@gnu.org>
3152
3153 * lread.c (syms_of_lread): Doc fix.
3154
14af5f7f
CY
31552012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
3156
3157 * coding.c (encode_designation_at_bol): Change return value to
3158 EMACS_INT.
3159
0b21c100
CY
31602012-01-25 Chong Yidong <cyd@gnu.org>
3161
3162 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
3163
3c2907f7
CY
31642012-01-21 Chong Yidong <cyd@gnu.org>
3165
3166 * floatfns.c (Fcopysign): Make the second argument non-optional,
3167 since nil is not allowed anyway.
3168
959ad23f
AS
31692012-01-21 Andreas Schwab <schwab@linux-m68k.org>
3170
3171 * process.c (read_process_output): Use p instead of XPROCESS (proc).
3172 (send_process): Likewise.
3173
34a02f46
MR
31742012-01-19 Martin Rudalics <rudalics@gmx.at>
3175
3176 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
3177 (Vwindow_persistent_parameters): Do not use Qstate.
3178 Rewrite doc-strings.
34a02f46 3179
1259009a 31802012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
3181
3182 * character.c (char_width): New function.
70d4fdf6
GM
3183 (Fchar_width, c_string_width, lisp_string_width):
3184 Use char_width (Bug#9496).
25ed9e61 3185
6a6ee00d
MR
31862012-01-16 Martin Rudalics <rudalics@gmx.at>
3187
3188 * window.c (Vwindow_persistent_parameters): New variable.
3189 (Fset_window_configuration, save_window_save): Handle persistent
3190 window parameters.
3191
c85efaf7
EZ
31922012-01-14 Eli Zaretskii <eliz@gnu.org>
3193
3194 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
3195 thrashing the stack of the thread. (Bug#9087)
3196
5944709e
PE
31972012-01-12 Paul Eggert <eggert@cs.ucla.edu>
3198
3199 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
3200
e71f5d99
EZ
32012012-01-11 Eli Zaretskii <eliz@gnu.org>
3202
3203 * xdisp.c (rows_from_pos_range): Handle the case where the
3204 highlight ends on a newline. (Bug#10464)
3205 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
3206 he end column for display of highlight that ends on a newline
3207 before a R2L line.
3208
ce316182
GM
32092012-01-11 Glenn Morris <rgm@gnu.org>
3210
3211 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
3212 from load-path also when installation-directory is nil. (Bug#10208)
3213
5b43da69
GM
32142012-01-10 Glenn Morris <rgm@gnu.org>
3215
74cc8ff9
GM
3216 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
3217
7d8d6e4e
GM
3218 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
3219 Update template values to be closer to their typical values these days.
5b43da69 3220
a0db8d43
EZ
32212012-01-09 Eli Zaretskii <eliz@gnu.org>
3222
3223 * xdisp.c (rows_from_pos_range): Accept additional argument
3224 DISP_STRING, and accept any glyph in a row whose object is that
3225 string as eligible for mouse highlight. Fixes mouse highlight of
3226 display strings from overlays. (Bug#10464)
3227
9a0115ab 32282012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 3229
b9110d6a 3230 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
3231 * fileio.c (auto_saving_dir_umask): New static var.
3232 (Fmake_directory_internal): Use it.
3233 (do_auto_save_make_dir): Set it, instead of invoking chmod after
3234 creating the directory. The old code temporarily assigns
3235 too-generous permissions to the directory.
3236 (do_auto_save_eh): Clear it.
b9110d6a 3237 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
3238 that the var is always cleared.
3239
6c1bd3f3
EZ
32402012-01-07 Eli Zaretskii <eliz@gnu.org>
3241
3242 * search.c (scan_buffer): Pass character positions to
3243 know_region_cache, not byte positions. (Bug#6540)
3244
069d2b50
L
32452012-01-07 LynX <_LynX@bk.ru> (tiny change)
3246
3247 * w32.c (sys_rename): Report EXDEV when rename of a directory
3248 fails because the target is on another logical disk. (Bug#10284)
3249
75bf0d33
DB
32502012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
3251
3252 * xterm.c (x_embed_request_focus): New function.
3253
3254 * xterm.h: Add prototype.
3255
3256 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
3257
1c6e5a32
GM
32582012-01-05 Glenn Morris <rgm@gnu.org>
3259
3260 * emacs.c (emacs_copyright): Update short copyright year to 2012.
3261
651e947e
EZ
32622012-01-01 Eli Zaretskii <eliz@gnu.org>
3263
3264 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
3265 Load gnutls_transport_set_lowat only if GnuTLS version is below
3266 2.11.1.
3267 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
3268 GnuTLS versions below 2.11.1.
3269
3778cdd8
AL
32702011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
3271
3272 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
3273 to the doc string advising against its use for altering the way
3274 windows are scrolled.
3275
0e5317f7
KH
32762011-12-28 Kenichi Handa <handa@m17n.org>
3277
3278 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
3279 coding-system ASCII compatible only when it does not produce BOM
3280 on encoding (Bug#10383).
3281
93d5ca1f
JD
32822011-12-26 Jan Djärv <jan.h.d@swipnet.se>
3283
3284 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
3285 can scroll.
3286 (create_and_show_popup_menu): Always use menu_position_func for
3287 Gtk3 (Bug#10361).
3288
ca22b785
AS
32892011-12-24 Andreas Schwab <schwab@linux-m68k.org>
3290
3291 * callint.c (Fcall_interactively): Don't truncate prompt string.
3292
d048e1e6
EZ
32932011-12-23 Eli Zaretskii <eliz@gnu.org>
3294
3295 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
3296 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 3297 resumed from there (after widening). (Bug#10360)
d048e1e6 3298
5ccaba1f
JD
32992011-12-22 Jan Djärv <jan.h.d@swipnet.se>
3300
3301 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
3302
204ee57f
JD
33032011-12-21 Jan Djärv <jan.h.d@swipnet.se>
3304
b81d40f0
JB
3305 * nsterm.m (x_free_frame_resources):
3306 Release f->output_data.ns->miniimage.
204ee57f
JD
3307 (ns_index_color): Fix indentation. Do not retain
3308 color_table->colors[i].
3309
3310 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
3311 before returning.
3312
3313 * nsfns.m (x_set_background_color): Assign return value from
3314 ns_index_color to face-background instead of NSColor*.
3315 (ns_implicitly_set_icon_type): Fix indentation.
3316 Change assignment in for loop to comparison.
3317
3318 * emacs.c (ns_pool): New variable.
3319 (main): Assign ns_pool.
3320 (Fkill_emacs): Call ns_release_autorelease_pool.
3321
3322 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
3323 autorelease fdesc, release fdAttrs and tdict.
3324 (ns_get_covering_families): Release charset.
3325 (ns_findfonts): Release NSFontDescriptor created with new.
3326 (ns_uni_to_glyphs): Fix indentation.
3327 (setString): Release attrStr before assigning new value.
3328
c803b2b7
JD
33292011-12-18 Jan Djärv <jan.h.d@swipnet.se>
3330
678f4426
JD
3331 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
3332 and NS_IMPL_COCOA.
3333 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
3334 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
3335
cd394be1 33362011-12-18 David Reitter <reitter@cmu.edu>
678f4426 3337
5fecd5fc
JD
3338 * nsterm.m (ns_term_init): Subscribe for notifications
3339 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
3340 to method trackingNotification in EmacsMenu.
3341
3342 * nsmenu.m (trackingMenu): New variable.
3771cb17 3343 (trackingNotification): New method (from Aquamacs).
5fecd5fc 3344 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 3345 from Aquamacs (Bug#7030).
678f4426
JD
3346
33472011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 3348
c803b2b7
JD
3349 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
3350 (symbol_to_nsstring): Fix indentation.
3351 (ns_symbol_to_pb): New function.
cae07000
SM
3352 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
3353 (Fns_rotate_cut_buffers_internal): Remove.
3354 (Fns_store_selection_internal): Rename from
c803b2b7
JD
3355 Fns_store_cut_buffer_internal.
3356 (ns_get_foreign_selection, Fx_own_selection_internal)
3357 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
3358 (Fns_get_selection_internal, Fns_store_selection_internal):
3359 Use ns_symbol_to_pb and check if return value is nil.
3360 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
3361 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
3362 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
3363 renamed to Sns_store_selection_internal.
3364 (ns_handle_selection_request): Move code to Fx_own_selection_internal
3365 and remove this function.
3366 (ns_handle_selection_clear): Remove, never used.
3367 (Fx_own_selection_internal): Move code from ns_handle_selection_request
3368 here.
3369
e1b01a3a
KB
33702011-12-17 Ken Brown <kbrown@cornell.edu>
3371
3372 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
3373 GID is unknown (Bug#10257).
3374
2adb6e85
PE
33752011-12-17 Paul Eggert <eggert@cs.ucla.edu>
3376
3377 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
3378 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
3379 which caused a build failure on GNU/Linux IA-64. This problem was
3380 introduced by my 2011-10-07 patch.
3381
d1d7b339
JL
33822011-12-15 Juri Linkov <juri@jurta.org>
3383
3384 * image.c (imagemagick_error): New function. (Bug#10112)
3385 (imagemagick_load_image): Comment out `MagickSetResolution' call.
3386 Use `imagemagick_error' where ImageMagick functions return
3387 `MagickFalse'.
3388 (Fimagemagick_types): Add `Fnreverse' to return the list in the
3389 proper order.
3390
100d5755
KH
33912011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3392
3393 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
3394 fill background (Bug#8992).
3395
454592a6
MR
33962011-12-13 Martin Rudalics <rudalics@gmx.at>
3397
3398 * window.c (Vwindow_combination_resize)
3399 (Vwindow_combination_limit): Use t instead of non-nil in
3400 doc-strings.
61d4b438
MR
3401 (Vrecenter_redisplay): Add first sentence of doc-string on
3402 separate line.
53524d93 3403 (Frecenter): Fix doc-string typo.
454592a6 3404
3633e3aa
KH
34052011-12-11 Kenichi Handa <handa@m17n.org>
3406
3407 * coding.c (Funencodable_char_position): Pay attention to the
3408 buffer text relocation (Bug#9389).
3409
7b9d523a 34102011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 3411
7b9d523a
JD
3412 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
3413 gtk_init (Bug#10100).
3414
b73189c6
EZ
34152011-12-10 Eli Zaretskii <eliz@gnu.org>
3416
3417 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
3418 IT->string is nil. (Bug#10263)
3419
f7dfe5d6
JD
34202011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3421
83faebb4
JD
3422 * nsterm.h (x_free_frame_resources): Declare.
3423
f7dfe5d6
JD
3424 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
3425 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
3426
3427 * nsterm.h (ns_get_defaults_value): Declare.
3428
3429 * nsterm.m (ns_default): Call ns_get_defaults_value.
3430
7cd4e72c
EZ
34312011-12-09 Eli Zaretskii <eliz@gnu.org>
3432
3433 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
3434 (Bug#10170)
3435
b34d7317
YM
34362011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3437
3438 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
3439 that where the value of an _OBJC_* symbol points to is in the .bss
3440 section (Bug#10240).
3441
76470ad1
KH
34422011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3443
3444 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 3445 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 3446
745fff94
KH
34472011-12-08 Kenichi Handa <handa@m17n.org>
3448
3449 * ftfont.c (get_adstyle_property): Fix previous change
3450 (Bug#10233).
3451
6e44397c
JB
34522011-12-07 Juanma Barranquero <lekktu@gmail.com>
3453
3454 * w32.c (init_environment): If no_site_lisp, remove site-lisp
3455 dirs from the default value of EMACSLOADPATH (bug#10208).
3456
7efa6272
GM
34572011-12-07 Glenn Morris <rgm@gnu.org>
3458
3459 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
3460 installation and source directories as well. (Bug#10208)
3461
f6fc4d87
CY
34622011-12-06 Chong Yidong <cyd@gnu.org>
3463
3464 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
3465
2bf26180
GM
34662011-12-06 Glenn Morris <rgm@gnu.org>
3467
3468 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
3469 as an error, not just -1. (Bug#10217)
3470
3a6ad4f0
CY
34712011-12-05 Chong Yidong <cyd@gnu.org>
3472
3473 * keyboard.c (process_special_events): New function.
3474 (swallow_events, Finput_pending_p): Use it (Bug#10195).
3475
75a3b399
PE
34762011-12-05 Paul Eggert <eggert@cs.ucla.edu>
3477
3478 * coding.c (encode_designation_at_bol): Don't use uninitialized
3479 local variable (Bug#9318).
3480
c3c9e25e
KH
34812011-12-05 Kenichi Handa <handa@m17n.org>
3482
3483 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
3484 return Qnil (Bug#8046, Bug#10193).
3485
5eb05ea3
KH
34862011-12-05 Kenichi Handa <handa@m17n.org>
3487
3488 * coding.c (encode_designation_at_bol): New args charbuf_end and
3489 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
3490 (coding_set_source): Return how many bytes coding->source was
3491 relocated.
3492 (coding_set_destination): Return how many bytes
3493 coding->destination was relocated.
3494 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 3495 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
3496
34972011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3498
3499 * coding.c (CODING_CHAR_CHARSET_P): New macro.
3500 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
3501 macro (Bug#9318).
3502
35032011-12-05 Andreas Schwab <schwab@linux-m68k.org>
3504
3505 The following changes are to fix Bug#9318.
3506
a79703f5 3507 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
3508 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
3509 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 3510 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 3511
7dbda6df
JB
35122011-12-05 Juanma Barranquero <lekktu@gmail.com>
3513
3514 * lisp.h (process_quit_flag): Fix external declaration.
3515
6d5eb5b0
SM
35162011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
3517
3518 Don't macro-inline non-performance-critical code.
3519 * eval.c (process_quit_flag): New function.
3520 * lisp.h (QUIT): Use it.
3521
a0c3fad0
JD
35222011-12-04 Jan Djärv <jan.h.d@swipnet.se>
3523
3524 * nsfns.m (get_geometry_from_preferences): New function.
3525 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
3526
6c07aac2
AS
35272011-12-04 Andreas Schwab <schwab@linux-m68k.org>
3528
3529 * emacs.c (Qkill_emacs): Define.
3530 (syms_of_emacs): Initialize it.
3531 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
3532 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
3533 (quit_throw_to_read_char): Add parameter `from_signal'.
3534 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
3535 * lisp.h (QUIT): Call Fkill_emacs if requested.
3536
c052ead4
JD
35372011-12-03 Jan Djärv <jan.h.d@swipnet.se>
3538
3539 * widget.c (update_wm_hints): Return if wmshell is null.
3540 (widget_update_wm_size_hints): New function.
3541
3542 * widget.h (widget_update_wm_size_hints): Declare.
3543
3544 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
3545 widget_update_wm_size_hints (Bug#10104).
3546
9e49252b
EZ
35472011-12-03 Eli Zaretskii <eliz@gnu.org>
3548
3549 * xdisp.c (handle_invisible_prop): If the invisible text ends just
3550 before a newline, prepare the bidi iterator for consuming the
3551 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 3552 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 3553
02b16839
JL
35542011-12-02 Juri Linkov <juri@jurta.org>
3555
3556 * search.c (Fword_search_regexp): New Lisp function created from
3557 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
3558 (Fword_search_backward, Fword_search_forward)
3559 (Fword_search_backward_lax, Fword_search_forward_lax):
3560 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
3561 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
3562
0068070e
SM
35632011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
3564
3565 * fileio.c (Finsert_file_contents): Move after-change-function call
3566 to before the "handled:" label, since all "goto handled" appear in
3567 cases where the *-change-functions have already been properly called
3568 (bug#10117).
3569
3360a3fc
AS
35702011-12-01 Andreas Schwab <schwab@linux-m68k.org>
3571
3572 * keyboard.c (interrupt_signal): Don't call kill-emacs when
3573 waiting for input. (Bug#10169)
3574
73d6c093
EZ
35752011-11-30 Eli Zaretskii <eliz@gnu.org>
3576
3577 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
3578 verifies glyph row's hash code--we have just reallocated the
3579 glyphs, so their contents can be complete garbage. (Bug#10164)
3580
febe6bea
JB
35812011-11-30 Juanma Barranquero <lekktu@gmail.com>
3582
3583 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
3584
801a4313
EZ
35852011-11-30 Eli Zaretskii <eliz@gnu.org>
3586
3587 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
3588 attributes are tested _before_ calling verify_row_hash, to protect
3589 against GCC re-ordering of the tests. (Bug#10164)
3590
2b56b87e
JD
35912011-11-29 Jan Djärv <jan.h.d@swipnet.se>
3592
3593 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
3594
3595 * xterm.c (handle_one_xevent): Only set async_visible and friends
3596 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 3597 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
3598 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
3599
dbf31225
PE
36002011-11-28 Paul Eggert <eggert@cs.ucla.edu>
3601
3602 Remove GCPRO-related macros that exist only to avoid shadowing locals.
3603 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
3604 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
3605 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3606 All uses changed to use GCPRO1 etc.
3607 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
3608 Revert to old implementation (i.e., before 2011-03-11).
3609
1305621b
YM
36102011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3611
3612 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
3613 of scroll runs so as to avoid assigning disabled bogus rows and
3614 unnecessary graphics copy operations.
3615
8c9afb46
EZ
36162011-11-27 Eli Zaretskii <eliz@gnu.org>
3617
3618 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
3619 (snprintf) [_MSC_VER]: Redirect to _snprintf.
3620 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
3621 (malloc, free, realloc, calloc): Redirect to e_* only when
3622 compiling Emacs.
3623
3624 * lisp.h (GCTYPEBITS): Move before first use.
3625 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
3626 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
3627 this macro definition.
3628
3629 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
3630 _MSC_VER.
3631
54e9e3bf
JD
36322011-11-27 Jan Djärv <jan.h.d@swipnet.se>
3633
6d5eb5b0
SM
3634 * gtkutil.c (xg_create_frame_widgets):
3635 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
3636 present with Gtk+ 2.0.
3637
83aca1cb
PE
36382011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3639
3640 * fileio.c (Finsert_file_contents): Undo previous change; see
3641 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3642
5b76caa4
PE
36432011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3644
3645 Rename locals to avoid shadowing.
3646 * fileio.c (Finsert_file_contents):
3647 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
3648 * process.c (wait_reading_process_output):
3649 Rename inner 'proc' to 'p' to avoid shadowing.
3650 Indent for consistency with usual Emacs style.
3651
8c535114
EZ
36522011-11-25 Eli Zaretskii <eliz@gnu.org>
3653
3654 * xdisp.c (redisplay_window): If cursor row is not fully visible
3655 after recentering, and scroll-conservatively is set to a large
3656 number, scroll window by a few more lines to make the cursor fully
3657 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
3658 (start_display): Don't move to the next line if the display should
3659 start at a newline that is part of a display vector or an overlay
3660 string. (Bug#10119)
8c535114 3661
fa4fdb5c
JL
36622011-11-24 Juri Linkov <juri@jurta.org>
3663
3664 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
3665 after the `MagickPingImage' call. (Bug#10112)
3666
90ec88df
CY
36672011-11-23 Chong Yidong <cyd@gnu.org>
3668
3669 * window.c (Fcoordinates_in_window_p): Accept only live windows.
3670
56e2e794
MR
36712011-11-23 Martin Rudalics <rudalics@gmx.at>
3672
3673 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
3674 making another buffer current. (Bug#10114)
3675
b6e64c41
GM
36762011-11-23 Glenn Morris <rgm@gnu.org>
3677
3678 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
3679
6b21de18
CY
36802011-11-23 Chong Yidong <cyd@gnu.org>
3681
3682 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
3683 using it (Bug#5984).
3684
b12cd789
EZ
36852011-11-22 Eli Zaretskii <eliz@gnu.org>
3686
3687 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
3688 and header-lines, as they don't have one computed for them.
3689 (Bug#10098)
3690
3691 * .gdbinit (prow): Make displayed values more self-explaining.
3692 Add row's hash code.
3693
261b6fd4
LMI
36942011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
3695
3696 * process.c (wait_reading_process_output): Fix asynchrounous
3697 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 3698 (wait_reading_process_output): Add comment and URL.
261b6fd4 3699
e7cfd277
JD
37002011-11-21 Jan Djärv <jan.h.d@swipnet.se>
3701
3702 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
3703
a9b9b7f5
CY
37042011-11-21 Chong Yidong <cyd@gnu.org>
3705
3706 * window.c (Fnext_window, Fprevious_window): Doc fix.
3707
b0d15b4f
SM
37082011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3709
3710 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
3711
fe7a3057
JB
37122011-11-20 Juanma Barranquero <lekktu@gmail.com>
3713
3714 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
3715
d2999b1a
MR
37162011-11-20 Martin Rudalics <rudalics@gmx.at>
3717
3718 * window.c (Fset_window_combination_limit): Rename argument
3719 STATUS to LIMIT.
3720 (Vwindow_combination_limit): Remove "status" from doc-string.
3721
d5ff9cd0
AS
37222011-11-20 Andreas Schwab <schwab@linux-m68k.org>
3723
3724 * m/ibms390.h: Remove.
3725 * m/ibms390x.h: Don't include "ibms390.h".
3726
a5bb9bd3
SM
37272011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3728
3729 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
3730 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
3731
cd1181db
JB
37322011-11-20 Juanma Barranquero <lekktu@gmail.com>
3733
3734 * casetab.c (Fset_case_table):
3735 * charset.c (Fcharset_after): Fix typos.
3736
615a3b8d 37372011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 3738
17e845af
PE
3739 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
3740 Otherwise, valgrind does not work on some platforms.
3741 Problem reported by Andreas Schwab in
6a0bf43d
PE
3742 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
3743 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
3744 is set, removing the need for VIRT_ADDRESS_VARIES.
3745 (PURE_P): Use a more-efficient implementation that needs just one
3746 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
3747 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
3748 to 4 (xorl, subq, cmpq, setbe).
3749 * alloc.c (pure): Always extern now, since that's the
3750 VIRT_ADDR_VARIES behavior.
3751 (PURE_POINTER_P): Use a single comparison, not two, for
3752 consistency with the new puresize.h.
3753 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
3754 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
3755 Remove VIRT_ADDR_VARIES no longer needed.
3756
f8fe6f96
EZ
37572011-11-19 Eli Zaretskii <eliz@gnu.org>
3758
3759 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
3760 (erase_phys_cursor, update_window_cursor, show_mouse_face)
3761 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
3762 behave as if the cursor position were at the window margin.
3763
3764 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
3765 and the cursor position is out of bounds, behave as if the cursor
3766 position were at the window margin. (Bug#10075)
3767
df05a53c
CY
37682011-11-18 Chong Yidong <cyd@gnu.org>
3769
3770 * window.c (Fwindow_combination_limit): Make first argument
3771 non-optional, since it is meaningless for live windows like the
3772 selected window.
61ccba97 3773
2071918e
DA
37742011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
3775
3776 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
3777
b50a28de
SM
37782011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
3779
3780 * intervals.c: Fix grafting over the whole buffer (bug#10071).
3781 (graft_intervals_into_buffer): Simplify.
3782
015137db
EZ
37832011-11-18 Eli Zaretskii <eliz@gnu.org>
3784
3785 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
3786 hash values of the two rows.
3787 (copy_row_except_pointers): Preserve the used[] arrays and the
3788 hash values of the two rows. (Bug#10035)
68c95424 3789 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
3790
3791 * xdisp.c (row_hash): New function, body extracted from
3792 compute_line_metrics.
3793 (compute_line_metrics): Call row_hash, instead of computing the
3794 hash code inline.
3795
3796 * dispnew.c (verify_row_hash): Call row_hash for computing the
3797 hash code of a row, instead of duplicating code from xdisp.c.
3798
3799 * dispextern.h (row_hash): Add prototype.
3800
a2addb04
TH
38012011-11-18 Tassilo Horn <tassilo@member.fsf.org>
3802
3803 * frame.c (delete_frame): Don't delete the terminal when the last
3804 X frame is closed if emacs is built with GTK toolkit.
3805
df85d315
JB
38062011-11-17 Juanma Barranquero <lekktu@gmail.com>
3807
3808 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
3809
a0c2d0ae
MR
38102011-11-17 Martin Rudalics <rudalics@gmx.at>
3811
3812 * window.c (Vwindow_splits): Rename to
3813 Vwindow_combination_resize. Suggested by Juri Linkov.
3814 (Fsplit_window_internal): Use Vwindow_combination_resize instead
3815 of Vwindow_splits.
3816
58179cce
JB
38172011-11-16 Juanma Barranquero <lekktu@gmail.com>
3818
7877f373
JB
3819 * nsfns.m (Fns_font_name):
3820 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 3821
b6f67890
MR
38222011-11-16 Martin Rudalics <rudalics@gmx.at>
3823
3824 * window.h (window): Rename slot "nest" to "combination_limit".
3825 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
3826 (Fset_window_nest): Rename to Fset_window_combination_limit.
3827 (Vwindow_nest): Rename to Vwindow_combination_limit.
3828 (recombine_windows, make_parent_window, make_window)
3829 (Fsplit_window_internal, saved_window)
3830 (Fset_window_configuration, save_window_save): Rename all
3831 occurrences of window_nest to window_combination_limit.
3832
c7015153
JB
38332011-11-15 Juanma Barranquero <lekktu@gmail.com>
3834
3835 * image.c (imagemagick_load_image): Fix typo.
3836
322ad6ec
EZ
38372011-11-14 Eli Zaretskii <eliz@gnu.org>
3838
3839 * xdisp.c (display_line): Move the call to
3840 highlight_trailing_whitespace before the call to
3841 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
3842 faces of all the glyphs to compute ROW's hash value.
3843 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 3844
f067b8ec
JB
38452011-11-14 Juanma Barranquero <lekktu@gmail.com>
3846
3847 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
3848 just return (bug#10044).
3849
1e5b2111
EZ
38502011-11-12 Eli Zaretskii <eliz@gnu.org>
3851
7ef3cbd5
EZ
3852 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
3853 with user-defined heap size. Bump the default size of the temacs
3854 heap to 27MB, to avoid memory warning when running temacs.
3855 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
3856
1e5b2111
EZ
3857 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
3858 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
3859 (verify_row_hash) [XASSERTS]: New function.
3860 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
3861 that the hash value of glyph rows is correct.
1e5b2111 3862
89d61221
MR
38632011-11-12 Martin Rudalics <rudalics@gmx.at>
3864
3865 * window.h (window): Remove splits slot.
3866 * window.c (Fwindow_splits, Fset_window_splits): Remove.
3867 (Fdelete_other_windows_internal, make_parent_window)
3868 (make_window, Fsplit_window_internal, Fdelete_window_internal)
3869 (Fset_window_configuration, save_window_save): Don't deal with
3870 split status of windows.
3871 (saved_window): Remove splits slot.
3872 (Vwindow_splits): Rewrite doc-string.
3873
97f18cc8
JD
38742011-11-11 Jan Djärv <jan.h.d@swipnet.se>
3875
3876 * xfns.c (unwind_create_frame):
3877 * nsfns.m (unwind_create_frame):
3878 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
3879 Vframe_list (Bug#9999).
3880
22a648b4
DA
38812011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
3882
0b381c7e 3883 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 3884
659afede
KH
38852011-11-11 Kenichi Handa <handa@m17n.org>
3886
3887 * callproc.c (Fcall_process): Set the member dst_multibyte of
3888 process_coding.
3889
9ac0394b
KH
38902011-11-11 Johan Bockgård <bojohan@gnu.org>
3891
3892 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
3893 avoid a crash (bug#9496).
3894
2fbdc249
CY
38952011-11-09 Chong Yidong <cyd@gnu.org>
3896
3897 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
3898 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
3899
ac6b1f81
PE
39002011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3901
3902 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
3903
09db192c
PE
39042011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3905
3906 Avoid some portability problems by eschewing 'extern inline' functions.
3907 The trivial performance wins aren't worth the portability hassles; see
3908 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
3909 et seq.
3910 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3911 (window_box_width, window_box_left, window_box_left_offset)
3912 (window_box_right, window_box_right_offset): Undo previous change,
3913 by removing the "extern"s.
3914 * intervals.c (adjust_intervals_for_insertion)
3915 (adjust_intervals_for_deletion): Undo previous change,
3916 making these static again.
3917 (offset_intervals, temp_set_point_both, temp_set_point)
3918 (copy_intervals_to_string): No longer inline.
3919 * xdisp.c (window_text_bottom_y, window_box_width)
3920 (window_box_height, window_box_left_offset)
3921 (window_box_right_offset, window_box_left, window_box_right)
3922 (window_box): No longer inline.
3923
105216ed
CY
39242011-11-08 Chong Yidong <cyd@gnu.org>
3925
3926 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
3927 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
3928 Signal an error if not a live window.
105216ed
CY
3929 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
3930 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
3931
ae9e237f
JB
39322011-11-07 Juanma Barranquero <lekktu@gmail.com>
3933
3934 * lisp.h (syms_of_abbrev): Remove declaration.
3935 Reported by CHENG Gao <chenggao@royau.me>.
3936
c7aa8333
EZ
39372011-11-07 Eli Zaretskii <eliz@gnu.org>
3938
3939 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
3940 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
3941 of temacs in GUI mode.
3942
be7f5545
MR
39432011-11-07 Martin Rudalics <rudalics@gmx.at>
3944
3945 * window.h: Declare delete_all_child_windows instead of
3946 delete_all_subwindows.
3947 * window.c (Fwindow_nest, Fset_window_nest)
3948 (Fset_window_new_total, Fset_window_new_normal)
3949 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
3950 (delete_all_subwindows): Rename to delete_all_child_windows.
3951 (Fdelete_other_windows_internal, Fset_window_configuration):
3952 Call delete_all_child_windows instead of delete_all_subwindows.
3953 * frame.c (delete_frame): Call delete_all_child_windows instead
3954 of delete_all_subwindows.
3955
ca78dc43
PE
39562011-11-07 Paul Eggert <eggert@cs.ucla.edu>
3957
3958 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
3959 This is also needed for porting to any host where GC_MARK_STACK is
3960 not GC_MAKE_GCPROS_NOOPS.
3961 (which_symbols): Use it.
3962
a0241d01
KH
39632011-11-07 Kenichi Handa <handa@m17n.org>
3964
3965 * coding.c (coding_set_destination): Check coding->src_pos only
3966 when coding->src_object is a buffer (bug#9910).
3967
3968 * process.c (send_process): Set the member src_multibyte of coding
3969 to 0 (bug#9911) when sending a unibyte text.
3970
3971 * callproc.c (Fcall_process): Set the member src_multibyte of
3972 process_coding to 0 (bug#9912).
3973
a64bfdfa 39742011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
3975
3976 * xmenu.c (cleanup_widget_value_tree): New function.
3977 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
3978 calling free_menubar_widget_value_tree directly (Bug#9830).
3979
cb41b32a
PE
39802011-11-06 Paul Eggert <eggert@cs.ucla.edu>
3981
3982 Fix some portability problems with 'inline'.
3983 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3984 (window_box_width, window_box_left, window_box_left_offset)
3985 (window_box_right, window_box_right_offset): Declare extern.
3986 Otherwise, these inline functions do not conform to C99 and
3987 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
3988 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
3989 * intervals.c (adjust_intervals_for_insertion)
3990 (adjust_intervals_for_deletion): Now extern, because otherwise the
3991 extern inline functions 'offset_intervals' couldn't refer to it.
3992 (static_offset_intervals): Remove.
3993 (offset_intervals): Rewrite using the old contents of
3994 static_offset_intervals. The old version didn't conform to C99
3995 because an extern inline function contained a reference to an
3996 identifier with static linkage.
3997
b7041366
AS
39982011-11-06 Andreas Schwab <schwab@linux-m68k.org>
3999
4000 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
4001 GC.
4002
88a37c4d
EZ
40032011-11-06 Eli Zaretskii <eliz@gnu.org>
4004
4005 * xdisp.c (init_iterator, reseat_to_string): Don't set the
4006 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
4007 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
4008 return Qleft_to_right.
4009
49745b39
CY
40102011-11-06 Chong Yidong <cyd@gnu.org>
4011
4012 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
4013 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
4014 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
4015 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
4016 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
4017 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
4018 (Fwindow_vscroll): Doc fix.
4019 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
4020 argument, since it makes no sense to pass a live window and for
4021 consistency with window-child.
4022
1f05cd82
CS
40232011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
4024
4025 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
4026 support MSVC.
4027
22610910
JR
40282011-11-05 Jason Rumney <jasonr@gnu.org>
4029
4030 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
4031 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
4032 fonts (Bug#6029).
4033 (add_font_entity_to_list): Fix logic errors in mixed boolean and
4034 bitwise arithmetic preventing use of unicode-sip and non-truetype
4035 opentype fonts.
4036
a06776b2
EZ
40372011-11-05 Eli Zaretskii <eliz@gnu.org>
4038
3ad924ba
EZ
4039 * s/ms-w32.h (fstat, stat, utime): Move redirections to
4040 "emacs"-only part.
4041
a06776b2
EZ
4042 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
4043 initialization code to keep similarity to xfns.c after changes
4044 from 2011-11-05.
4045
c9e7db78
JD
40462011-11-05 Jan Djärv <jan.h.d@swipnet.se>
4047
a97f8f3f
JD
4048 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
4049 (unwind_create_frame): New function (Bug#9943).
4050 (Fx_create_frame): Restructure code to be more similar to the one in
4051 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
4052 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
4053 Move terminal->reference_count++ just before making the frame official
4054 (Bug#9943).
4055
4056 * nsterm.m (x_free_frame_resources): New function.
4057 (x_destroy_window): Move code to x_free_frame_resources.
4058
c9e7db78 4059 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
4060 (Fx_create_frame, x_create_tip_frame):
4061 Move terminal->reference_count++ just before making the frame
75f1671a 4062 official. Move initialization of image_cache_refcount and
c9e7db78
JD
4063 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
4064
a6fc3b5c
EZ
40652011-11-05 Eli Zaretskii <eliz@gnu.org>
4066
4067 Support MSVC build with newer versions of Visual Studio.
4068 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
4069 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
4070 nt/gmake.defs.
4071
4072 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
4073 which are not supported by MSVC.
4074 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
4075 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
4076 bitfields.
4077 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
4078 types in bitfields.
4079 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
4080
4081 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
4082
58179cce 40832011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
4084
4085 Support MSVC build with newer versions of Visual Studio.
4086 * w32.c: Don't include w32api.h for MSVC.
4087 (init_environment) [_MSC_VER]: Call sys_access, not _access.
4088
4089 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
4090 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
4091 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
4092 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
4093 e_* cousins.
4094 (alloca) [_MSC_VER]: Define to _alloca.
4095
4096 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
4097
4098 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
4099
a58c13ed
EZ
41002011-11-04 Eli Zaretskii <eliz@gnu.org>
4101
4102 * xdisp.c (note_mouse_highlight): If either of
4103 previous/next-single-property-change returns nil, treat that as
4104 the beginning or the end of the buffer. (Bug#9955)
4105
fe0b6370
JD
41062011-11-04 Jan Djärv <jan.h.d@swipnet.se>
4107
a58c13ed 4108 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
4109 label is not null (Bug#9951).
4110 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
4111 may be NULL.
4112
89bd5ee1
EZ
41132011-11-04 Eli Zaretskii <eliz@gnu.org>
4114
4115 * window.c (Fwindow_body_size): Mention in the doc string that the
4116 return value is in frame's canonical units. (Bug#9949)
4117
84c3edb9
EZ
41182011-11-03 Eli Zaretskii <eliz@gnu.org>
4119
4e2fb5c7
EZ
4120 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
4121
84c3edb9 4122 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 4123 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 4124 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 4125
bc17a887
EZ
41262011-11-01 Eli Zaretskii <eliz@gnu.org>
4127
4128 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
4129 Don't stop backward scan on the continuation glyph, even though
4130 its CHARPOS is positive.
6d5eb5b0
SM
4131 (mouse_face_from_buffer_pos, note_mouse_highlight):
4132 Rename cover_string to disp_string.
bc17a887 4133
4ee88440
MR
41342011-11-01 Martin Rudalics <rudalics@gmx.at>
4135
4136 * window.c (temp_output_buffer_show): Don't use
4137 Vtemp_buffer_show_specifiers.
4138 (Vtemp_buffer_show_specifiers): Remove unused variable.
4139
c2ff3c02
EZ
41402011-10-30 Eli Zaretskii <eliz@gnu.org>
4141
4142 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
4143 past the beginning of the current glyph matrix.
4144
58179cce 41452011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
4146
4147 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
4148 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
4149 HAVE_GTK3 (Bug#9869).
b77a6a7f 4150
3b574623
JD
4151 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
4152 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
4153
b77a6a7f
JD
4154 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
4155
4156 * xterm.c: Declare x_handle_net_wm_state to return int.
4157 (handle_one_xevent): Check if we are iconified but don't have
4158 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
4159 (get_current_wm_state): Return non-zero if not hidden,
4160 check for _NET_WM_STATE_HIDDEN (Bug#9893).
4161 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
4162 (x_handle_net_wm_state): Return what get_current_wm_state returns.
4163 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
4164
196e41e4
PE
41652011-10-29 Paul Eggert <eggert@cs.ucla.edu>
4166
4167 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
4168 so that this new function doesn't get optimized away by a
4169 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
4170
021f2e1a
AS
41712011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4172
4173 * frame.h (MOUSE_HL_INFO): Remove excess parens.
4174
8b058d44
EZ
41752011-10-29 Eli Zaretskii <eliz@gnu.org>
4176
4177 Fix the `xbytecode' command.
4178 * .gdbinit (xprintbytestr): New command.
b50a28de 4179 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
4180 (xbytecode): Print the byte-code string as well.
4181
4452fb80
EZ
41822011-10-29 Kim Storm <storm@cua.dk>
4183
8b058d44
EZ
4184 * alloc.c (which_symbols): New function.
4185
21b72067
AS
41862011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4187
4188 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
4189 line. (Bug#9903)
4190
83ed7b5c
GM
41912011-10-29 Glenn Morris <rgm@gnu.org>
4192
4193 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
4194 Not clear what it was for, and it causes various bugs. (Bug#9839)
4195
5a7a728b
EZ
41962011-10-28 Eli Zaretskii <eliz@gnu.org>
4197
4198 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
4199 possible random value that matches one of those tested as
4200 condition to clear the mouse face.
4201
d3d0842f
CY
42022011-10-28 Chong Yidong <cyd@gnu.org>
4203
4204 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
4205
31b39d13
DN
42062011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
4207
4208 * window.c (make_window): Initialize phys_cursor_on_p.
4209
9aba6043
SM
42102011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
4211
4212 * lisp.h (struct Lisp_Symbol): Update comments.
4213
c20992f4
JB
42142011-10-28 Juanma Barranquero <lekktu@gmail.com>
4215
4216 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
4217
db4f02f2
EZ
42182011-10-28 Eli Zaretskii <eliz@gnu.org>
4219
4220 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
4221 <oslsachem@gmail.com> for helping to debug this.
4222
4223 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
4224 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
4225 (g_b_init_get_glyph_outline_w): New static variables.
4226 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
4227 (GetGlyphOutlineW_Proc): New typedefs.
4228 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
4229 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
4230 New functions.
4231 (w32font_open_internal, compute_metrics):
4232 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
4233 instead of calling the "wide" APIs directly.
4234
4235 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
4236
4237 * w32.h (syms_of_w32font): Add prototype.
4238
87e68db4
JB
42392011-10-27 Juanma Barranquero <lekktu@gmail.com>
4240
4241 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
4242 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
4243 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
4244 (Fmove_to_window_line): Doc fix.
4245
435c1d67
CY
42462011-10-27 Chong Yidong <cyd@gnu.org>
4247
4248 * process.c (make_process): Set gnutls_state to NULL.
4249
4250 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
4251 non-NULL, regardless of GNUTLS_INITSTAGE.
4252 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
4253 an error. Set process slots as soon as we allocate them.
4254
4255 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
4256
9c6c6f49
CY
42572011-10-27 Chong Yidong <cyd@gnu.org>
4258
9aba6043
SM
4259 * gnutls.c (emacs_gnutls_deinit): New function.
4260 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
4261 (Fgnutls_deinit, Fgnutls_boot): Use it.
4262
4263 * process.c (make_process): Initialize GnuTLS credentials to NULL.
4264 (deactivate_process): Call emacs_gnutls_deinit.
4265
657d08d3
JB
42662011-10-27 Juanma Barranquero <lekktu@gmail.com>
4267
4268 * image.c (x_create_x_image_and_pixmap):
4269 * w32.c (sys_rename, w32_delayed_load):
4270 * w32font.c (fill_in_logfont):
4271 * w32reg.c (x_get_string_resource): Silence compiler warnings.
4272
5430d399
JB
42732011-10-26 Juanma Barranquero <lekktu@gmail.com>
4274
4275 * w32fns.c (w32_default_color_map): New function,
4276 extracted from Fw32_default_color_map.
a7ef684b 4277 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 4278
fe0055fa
PE
42792011-10-25 Paul Eggert <eggert@cs.ucla.edu>
4280
4281 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
4282
e6346438
SM
42832011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
4284
4285 * keyboard.c (test_undefined): New function (bug#9751).
4286 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
4287
e112cc37
ET
42882011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
4289
4290 * sysdep.c (init_sys_modes): Fix the check for the controlling
4291 terminal (Bug#6649).
4292
7b5d6677
EZ
42932011-10-20 Eli Zaretskii <eliz@gnu.org>
4294
4295 * dispextern.h (struct bidi_it): New member next_en_type.
4296
4297 * bidi.c (bidi_line_init): Initialize the next_en_type member.
4298 (bidi_resolve_explicit_1): When next_en_pos is valid for the
4299 current character, check also for next_en_type being WEAK_EN.
4300 (bidi_resolve_weak): Don't enter the expensive loop if the current
4301 position is before next_en_pos. Record the bidi type of the first
4302 non-ET, non-BN character we find, in addition to its position.
4303 (bidi_level_of_next_char): Invalidate next_en_type when
4304 next_en_pos is over-stepped.
4305
7da0b018
PE
43062011-10-20 Paul Eggert <eggert@cs.ucla.edu>
4307
4308 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
4309 * editfns.c: Rewrite current-time-zone so that it invokes
4310 the equivalent of (format-time-string "%Z") to get the time zone name.
4311 This fixes a bug when the time zone name contains characters that
4312 need converting from the system time locale to Emacs internal format.
4313 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
4314 that patch fixed format-time-string to do the conversion, but
4315 I forgot to fix current-time-zone.
4316 (format_time_string): New function, containing most of
4317 what Fformat_time_string used to contain.
4318 (Fformat_time_string): Rewrite in terms of format_time_string.
4319 This doesn't change this function's behavior.
4320 (current-time-zone): Rewrite to use format_time_string.
4321 This fixes the bug reported by Michael Schierl in
4322 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
4323 Jason Rumney's 2007-06-07 change worked around this bug, but
4324 didn't fix it.
4325 * systime.h (tzname, timezone): Remove no-longer-used declarations.
4326
8547b010
EZ
43272011-10-19 Eli Zaretskii <eliz@gnu.org>
4328
4329 * xdisp.c (start_display): If the character at POS is displayed
4330 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
4331 (try_window_reusing_current_matrix): If a line ends in a display
4332 vector or the next line starts in a display vector, continue
4333 redrawing the window even though the character position of
4334 start_row was reached.
8547b010
EZ
4335 (Bug#9771, part 2)
4336
4e948d15
CY
43372011-10-18 Chong Yidong <cyd@gnu.org>
4338
4339 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
4340 with nobreak-char-display too.
4341
4787455f
EZ
43422011-10-18 Eli Zaretskii <eliz@gnu.org>
4343
4344 Fix part 3 of bug#9771.
4345 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
4346 (bidi_resolve_neutral): Don't enter the expensive loop looking for
4347 non-neutral characters if the current character is a paragraph
4348 separator (a.k.a. Newline). This avoids running the same
4349 expensive loop twice, once when we consume the preceding newline
4350 and the other time when the line actually needs to be displayed.
4351 Avoid the loop when we see neutrals on the base embedding level
4352 following a character whose directionality is the same as the
4353 paragraph's. This avoids running the expensive loop when a line
4354 ends in a long sequence of neutrals, like control characters.
4355 Add assertion against STRONG_AL type. Slightly rearrange code
4356 that determines the type of a neutral given the first non-neutral
4357 that follows it.
4358 (bidi_level_of_next_char): Set next_en_pos to zero when
4359 invalidating its info.
4360
2c91f553
EZ
43612011-10-17 Eli Zaretskii <eliz@gnu.org>
4362
4363 * xdisp.c (push_display_prop): Determine whether to record string
4364 or buffer position by IT->string, not by IT->method. Allow
4365 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
4366 (move_it_vertically_backward): Don't look for character position
4367 immediately after the newline when in a continuation line.
4368 (Bug#9771, part 1)
2c91f553 4369
c7b08b0d
MR
43702011-10-15 Martin Rudalics <rudalics@gmx.at>
4371
4372 * window.c (coordinates_in_window): Rewrite and delabelize
4373 vertical border check. (Bug#5357) (Bug#9618)
4374
6b02f655
SM
43752011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
4376
4377 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
4378 errors in XSetWindowBorder (bug#9310).
4379
81d40c92
DA
43802011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
4381
4382 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
4383 avoid crash when xmalloc overrun checking is enabled.
4384
d4172c3b
EZ
43852011-10-13 Eli Zaretskii <eliz@gnu.org>
4386
4387 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
4388 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
4389 cursor motion with <left> and <right> arrow keys.
4390
4391 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
4392 some callers set that themselves.
4393
b00eea75
EZ
43942011-10-12 Eli Zaretskii <eliz@gnu.org>
4395
4396 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
4397 display string and the previous row comes from the same string and
4398 is empty. (Bug#9739) (Bug#9738)
4399
8fe012c4
SM
44002011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
4401
4402 * doc.c (get_doc_string): Encode file name (bug#9735).
4403
0074aef2
EZ
44042011-10-12 Eli Zaretskii <eliz@gnu.org>
4405
79beb178
EZ
4406 * bidi.c (bidi_level_of_next_char):
4407 * xdisp.c (get_visually_first_element): Remove old incorrect
4408 comments regarding the Unicode Line Separator character.
4409
0074aef2
EZ
4410 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
4411
6e4b3fbe
DA
44122011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
4413
4414 * alloc.c (Fgc_status): Do not access beyond zombies array
4415 boundary if nzombies > MAX_ZOMBIES.
4416 * alloc.c (dump_zombies): Add missing format specifier.
4417
0324f3af
PE
44182011-10-12 Paul Eggert <eggert@cs.ucla.edu>
4419
b5525cac
PE
4420 * xdisp.c (set_cursor_from_row): Simplify conditionals,
4421 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
4422
0324f3af
PE
4423 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
4424 Some packages use them to denote characters with modifiers.
4425
e9b5f888
AS
44262011-10-11 Andreas Schwab <schwab@linux-m68k.org>
4427
4428 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
4429 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
4430 matching a pp-number. Rename parameter var to var1.
4431
127827c0
SM
44322011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
4433
4434 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
4435
c8fd3bd0
GM
44362011-10-08 Glenn Morris <rgm@gnu.org>
4437
4438 * callint.c (Fcall_interactively): Give a more explicit error for the
4439 'c' case with a non-character input. (Bug#8479)
4440
352ec8ff
EZ
44412011-10-08 Eli Zaretskii <eliz@gnu.org>
4442
03669ccb
EZ
4443 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
4444 lines.
7061c986
EZ
4445 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
4446 lines that are hscrolled on the left.
03669ccb 4447
352ec8ff
EZ
4448 * dispnew.c (buffer_posn_from_coords): Account for a possible
4449 presence of header-line. (Bug#4426)
4450
a66cfb1c
SM
44512011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
4452
6b02f655
SM
4453 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
4454 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 4455
7c5ee88e
PE
44562011-10-07 Paul Eggert <eggert@cs.ucla.edu>
4457
4458 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
4459 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
4460 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
4461 this makes Emacs dump core during garbage collection on rare
4462 occasions. sizeof is obviously inferior to offsetof here, so
4463 stick with offsetof.
4464 (GC_POINTER_ALIGNMENT): New macro.
4465 (mark_memory): Omit 3rd (offset) arg; caller changed.
4466 Don't assume EMACS_INT alignment is the same as pointer alignment.
4467
df1bbe5b
SM
44682011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
4469
4470 * keyboard.c (read_key_sequence_remapped): New var.
4471 (read_key_sequence): Compute remapping in the right buffer.
4472 (command_loop_1): Use read_key_sequence's remapping directly.
4473
51553db6
SM
44742011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
4475
32c1fffd
SM
4476 * dired.c (file_name_completion): Don't expand file name.
4477 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
4478 before checking file name handler.
4479
51553db6
SM
4480 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
4481 they've been requested explicitly (bug#9591).
4482
b6bd1599 44832011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
4484
4485 * keymap.c (Fsingle_key_description): Use make_specified_string
4486 instead of build_string to build string from push_key_description.
4487 (Bug#5193)
4488
f701dc2a
PE
44892011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4490
4222c55d
PE
4491 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
4492 This fixes a Y2038 bug on 64-bit hosts.
4493 * buffer.c (reset_buffer):
4494 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
4495 (Fclear_buffer_auto_save_failure):
4496 Use 0, not -1, to represent an unset failure time, since time_t
4497 might not be signed.
4498
f701dc2a
PE
4499 Remove dependency on glibc malloc internals.
4500 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4501 Move back here from lisp.h, but with their new implementations.
4502 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4503 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
4504 * charset.c (charset_table_init): New static var.
4505 (syms_of_charset): Use it instead of xmalloc. This removes a
4506 dependency on glibc malloc internals. See Eli Zaretskii's comment in
4507 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
4508 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4509 Move back to alloc.c.
4510 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4511 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
4512
9ceebf39
JD
45132011-09-30 Jan Djärv <jan.h.d@swipnet.se>
4514
4515 * nsterm.m (windowDidResize): Call x_set_window_size only when
4516 ns_in_resize is true. Otherwise set pixelwidth/height and
4517 call change_frame_size (Bug#9628).
4518
cb993c58
PE
45192011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4520
3930c88b
PE
4521 Port --enable-checking=all to Fedora 14 x86-64.
4522 * charset.c (syms_of_charset): Also account for glibc malloc's
4523 internal overhead when calculating the initial malloc maximum.
4524
cb993c58
PE
4525 Port --enable-checking=all to Fedora 14 x86.
4526 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4527 Move to lisp.h.
4528 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
4529 (overrun_check_realloc, overrun_check_free):
4530 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
4531 That way, xmalloc returns a properly-aligned pointer even if
4532 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
4533 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
4534 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
4535 into account when calculating the initial malloc maximum.
4536 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4537 Move here from alloc.c, so that charset.c can use it too.
4538 Properly align; the old code wasn't right for common 32-bit hosts
4539 when configured with --enable-checking=all.
4540 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4541 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
4542
31bed486
EZ
45432011-09-29 Eli Zaretskii <eliz@gnu.org>
4544
04c70788 4545 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
4546 use EDOM.
4547
fbcaa2f3
EZ
45482011-09-28 Eli Zaretskii <eliz@gnu.org>
4549
4550 * xdisp.c (compute_display_string_end): If there's no display
4551 string at CHARPOS, return -1.
4552
4553 * bidi.c (bidi_fetch_char): When compute_display_string_end
4554 returns a negative value, treat the character as a normal
4555 character not covered by a display string. (Bug#9624)
4556
a239d4e9
JB
45572011-09-28 Juanma Barranquero <lekktu@gmail.com>
4558
4559 * lread.c (Fread_from_string): Fix typo in docstring.
4560
88652fd5
EZ
45612011-09-27 Eli Zaretskii <eliz@gnu.org>
4562
4563 * xdisp.c (handle_invisible_prop): If invisible text ends on a
4564 newline, reseat the iterator instead of bidi-iterating there one
4565 character at a time. (Bug#9610)
32c1fffd
SM
4566 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
4567 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 4568
ed497dd4
AS
45692011-09-27 Andreas Schwab <schwab@linux-m68k.org>
4570
4571 * lread.c (readevalloop): Use correct code for NBSP.
4572 (read1): Likewise. (Bug#9608)
4573
b2bf61aa
MA
45742011-09-25 Michael Albinus <michael.albinus@gmx.de>
4575
4576 * dbusbind.c (Fdbus_register_signal): When service is not
4577 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
4578
32bbb17c
GM
45792011-09-25 Glenn Morris <rgm@gnu.org>
4580
4581 * buffer.c (truncate-lines): Doc fix.
4582
94e0933e
CY
45832011-09-24 Chong Yidong <cyd@stupidchicken.com>
4584
4585 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
4586 (Fset_window_next_buffers): Doc fix.
4587
cddde921
GM
45882011-09-24 Glenn Morris <rgm@gnu.org>
4589
4590 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
4591
1260aef1
PE
45922011-09-24 Paul Eggert <eggert@cs.ucla.edu>
4593
25b4bfa0
PE
4594 Fix minor problems found by static checking.
4595 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
4596 * indent.c (Fvertical_motion): Fix == vs = typo.
4597
e3cbd34b
EZ
45982011-09-24 Eli Zaretskii <eliz@gnu.org>
4599
a66cfb1c
SM
4600 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
4601 Default value is now t. Doc fix.
6bf7006f 4602
e3cbd34b 4603 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 4604 logic when moving up, not only when moving down. Fix the
e3cbd34b 4605 confusing name and values of the it_overshoot_expected variable;
32c1fffd 4606 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
4607
4608 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
4609 CHARPOS is covered by a display string which includes newlines.
4610 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
4611 is covered by a display string with embedded newlines.
4612
a3de0cbd
MA
46132011-09-24 Michael Albinus <michael.albinus@gmx.de>
4614
4615 * dbusbind.c (Fdbus_register_signal): Add match rule to
4616 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
4617 (Fdbus_register_method, Vdbus_registered_objects_table):
4618 Fix docstring.
a3de0cbd 4619
b260039d
JM
46202011-09-24 Jim Meyering <meyering@redhat.com>
4621
32c1fffd 4622 do not ignore write error for any output size
b260039d
JM
4623 The previous change was incomplete.
4624 While it makes emacs --batch detect the vast majority of stdout
4625 write failures, errors were still ignored whenever the output size is
4626 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
4627 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
4628 && echo FAIL: ignored write error
4629 FAIL: ignored write error
4630 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
4631 && echo FAIL: ignored write error
4632 FAIL: ignored write error
4633 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
4634
8eca8a7c
AS
46352011-09-23 Andreas Schwab <schwab@linux-m68k.org>
4636
4637 * emacs.c (Fkill_emacs): In noninteractive mode exit
4638 non-successfully if a write error occurred on stdout. (Bug#9574)
4639
3341db62
EZ
46402011-09-21 Eli Zaretskii <eliz@gnu.org>
4641
4642 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
4643 the xassert test.
4644
4645 * dispextern.h (struct it): Update the comment documenting what
4646 can it->OBJECT be.
4647
8c203dbf
EZ
46482011-09-20 Eli Zaretskii <eliz@gnu.org>
4649
4650 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
4651 a display string, extend search for cursor position to end of row.
4652 (find_row_edges): If the row ends in a newline from a display
4653 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
4654 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
4655 (Fcurrent_bidi_paragraph_direction): Fix search for previous
4656 non-empty line. Fixes confusing cursor motion with arrow keys at
4657 the beginning of a line that starts with whitespace.
8c203dbf 4658
a4824228
LMI
46592011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4660
4661 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
4662 (bug#9493).
4663
33ed493b
CY
46642011-09-18 Chong Yidong <cyd@stupidchicken.com>
4665
4666 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
4667 boolean (Bug#9154).
4668
56cd55c8
EZ
46692011-09-18 Eli Zaretskii <eliz@gnu.org>
4670
4671 * xdisp.c (display_line): Record maximum and minimum buffer
4672 positions even if no glyphs were produced (e.g., by a zero-width
4673 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
4674 buffer positions that will be removed from the glyph row because
4675 they don't fit.
c02dcedf
EZ
4676 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
4677 column is beyond frame width: don't subtract 1 "pixel" when
4678 computing width of the stretch.
3e62b7e0
EZ
4679 (reseat_at_next_visible_line_start): Undo the change made on
4680 2011-09-17 that saved paragraph information and restored it after
4681 the call to `reseat'. (Bug#9545)
56cd55c8 4682
5ed99d36 46832011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
4684
4685 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
4686 and turn window cursor on if cleared (Bug#9415).
4687
5ed99d36 46882011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
4689
4690 * search.c (boyer_moore): Take unibyte characters from pattern
4691 literally. (Bug#9458)
4692
9bade7b2
EZ
46932011-09-18 Eli Zaretskii <eliz@gnu.org>
4694
4695 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
4696
e5e9d610
PE
46972011-09-18 Paul Eggert <eggert@cs.ucla.edu>
4698
87e4427a
PE
4699 Fix minor problem found by static checking.
4700 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
4701 initialized, to pacify gcc -Wuninitialized.
4702
e5e9d610
PE
4703 * fileio.c: Report proper errno when syscall falls.
4704 (Finsert_file_contents): Save and restore errno,
4705 so that report_file_error outputs the correct diagnostic.
4706 (Fwrite_region) [CLASH_DETECTION]: Likewise.
4707
a1674f0b
EZ
47082011-09-18 Eli Zaretskii <eliz@gnu.org>
4709
4710 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
4711
fbfb6dd4
EZ
47122011-09-17 Eli Zaretskii <eliz@gnu.org>
4713
4714 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
4715 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
4716
bb187662
EZ
47172011-09-17 Eli Zaretskii <eliz@gnu.org>
4718
1137e8b8 4719 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 4720 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
4721
4722 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
4723 (bidi_find_paragraph_start): Search back for paragraph beginning
4724 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
4725 (bidi_move_to_visually_next): Only trigger paragraph-related
4726 computations when the last character is a newline or at EOB, not
4727 just any NEUTRAL_B. (Bug#9470)
4728
bb187662
EZ
4729 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
4730 truncated lines if point is covered by a display string. (Bug#9524)
4731
2e621251
PE
47322011-09-16 Paul Eggert <eggert@cs.ucla.edu>
4733
4734 * xselect.c: Relax test for outgoing X longs (Bug#9498).
4735 (cons_to_x_long): New function.
4736 (lisp_data_to_selection_data): Use it. Correct the test for
4737 short-versus-long data; it was negated. Break out of vector
4738 loop, for efficiency, when a long datum is discovered.
4739
91a15bc6
SM
47402011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
4741
4742 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
4743
b41c3a35
EZ
47442011-09-16 Eli Zaretskii <eliz@gnu.org>
4745
4746 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
4747 GCC PR/17406) by declaring this function with external scope.
4748
7812ba2d
PE
47492011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4750
4751 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
4752 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
4753
cf7edc2a
AS
47542011-09-15 Andreas Schwab <schwab@linux-m68k.org>
4755
4756 * editfns.c (Fformat): Correctly handle text properties on "%%".
4757
bd01620e
EZ
47582011-09-15 Eli Zaretskii <eliz@gnu.org>
4759
4760 * xterm.c (x_draw_composite_glyph_string_foreground):
4761 * w32term.c (x_draw_composite_glyph_string_foreground):
4762 * term.c (encode_terminal_code):
4763 * composite.c (composition_update_it, get_composition_id):
4764 * xdisp.c (get_next_display_element)
4765 (fill_composite_glyph_string): Add comments about special meaning
4766 of TAB characters in a composition.
4767
a02719a3
PE
47682011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4769
4770 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
4771 This occurs when processing a multibyte format.
4772 Problem reported by Wolfgang Jenker.
a02719a3 4773
72589a3c
JB
47742011-09-15 Johan Bockgård <bojohan@gnu.org>
4775
4776 * xdisp.c (try_cursor_movement): Only check for exact match if
4777 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
4778
1c14176c
PE
47792011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4780
4781 Remove unused external symbols.
4782 * dispextern.h (calc_pixel_width_or_height): Remove decl.
4783 * xdisp.c (calc_pixel_width_or_height): Now static.
4784 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
4785 * indent.c (check_display_width):
4786 * w32term.c: Fix comment to match code.
4787 * xterm.c, xterm.h (x_catching_errors): Remove.
4788
d2eea5b5
PE
47892011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4790
4791 * xselect.c: Use signed conversions more consistently (Bug#9498).
4792 (selection_data_to_lisp_data): Assume incoming selection data are
4793 signed integers, not unsigned. This is to be consistent with
4794 outgoing selection data, which was modified to use signed integers
4795 in as part of the fix to Bug#9196 in response to Jan D.'s comment
4796 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
4797 expects long, not unsigned long.
4798
46888499
EZ
47992011-09-14 Eli Zaretskii <eliz@gnu.org>
4800
4801 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
4802 computation of loop end. Reported by Johan Bockgård
4803 <bojohan@gnu.org>.
4804
ef8ef9fb
CY
48052011-09-13 Chong Yidong <cyd@stupidchicken.com>
4806
4807 * frame.c (Fother_visible_frames_p): Function deleted.
4808
fa819fed
EZ
48092011-09-12 Eli Zaretskii <eliz@gnu.org>
4810
4811 * indent.c (compute_motion): Process display vector front to back
4812 rather than the other way around. (Bug#2496)
4813
2ba8e008
SM
48142011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
4815
4816 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
4817
20f53c69
CY
48182011-09-11 Chong Yidong <cyd@stupidchicken.com>
4819
4820 * minibuf.c (Fread_from_minibuffer): Doc fix.
4821
d562d7a4
EZ
48222011-09-11 Eli Zaretskii <eliz@gnu.org>
4823
4824 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
4825 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
4826
1c4d7f3d
LMI
48272011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4828
4829 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
4830 value for non-existent files.
4831
b885bf36
EZ
48322011-09-11 Eli Zaretskii <eliz@gnu.org>
4833
4834 * fileio.c (Finsert_file_contents): If the file cannot be opened,
4835 set its "size" to -1. This will set the modtime_size field of
4836 the corresponding buffer to -1, which is what
4837 verify-visited-file-modtime expects for files that do not exist.
4838 (Bug#9139)
4839
6612f0bf
PE
48402011-09-11 Paul Eggert <eggert@cs.ucla.edu>
4841
4842 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
4843 here ...
4844 * lisp.h: ... from here. push_key_description is no longer
4845 defined in keyboard.c, so its declaration should not be in
4846 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
4847 logically belongs with push_key_description.
4848
dfb3f755
PE
48492011-09-10 Paul Eggert <eggert@cs.ucla.edu>
4850
4851 * buffer.h: Include <sys/types.h> instead of <time.h>.
4852 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
4853 Problem reported by Herbert J. Skuhra.
4854
3134906c
LMI
48552011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
4856
4857 * xml.c (parse_region): Make the parsing work for
4858 non-comment-starting XML files again (bug#9144).
4859
8d903f4e
AS
48602011-09-10 Andreas Schwab <schwab@linux-m68k.org>
4861
4862 * image.c (gif_load): Fix calculation of bottom and right corner.
4863 (Bug#9468)
4864
80ad64f4
EZ
48652011-09-10 Eli Zaretskii <eliz@gnu.org>
4866
4867 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
4868 redisplay in small windows.
4869
208a048d
EZ
48702011-09-09 Eli Zaretskii <eliz@gnu.org>
4871
4872 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
4873
9b1c252e
MR
48742011-09-08 Martin Rudalics <rudalics@gmx.at>
4875
4876 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
4877 Operate on live windows only.
4878
2949f33b
JB
48792011-09-08 Juanma Barranquero <lekktu@gmail.com>
4880
4881 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
4882
e08dcafd
EZ
48832011-09-07 Eli Zaretskii <eliz@gnu.org>
4884
4885 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
4886 only under bidi iteration.
4887
115b96bd
JD
48882011-09-07 Jan Djärv <jan.h.d@swipnet.se>
4889
4890 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
4891
c8199d0f
PE
48922011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4893
4894 isnan: Fix porting problem to Solaris 10 with bundled gcc.
4895 Without this fix, the command to link temacs failed due to an
4896 undefined symbol __builtin_isnan. This is because
4897 /usr/include/iso/math_c99.h #defines isnan(x) to
4898 __builtin_isnan(x), but the bundled gcc, which identifies itself
4899 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
4900 a __builtin_isnan.
4901 * floatfns.c (isnan): #undef, and then #define to a clone of
4902 what's in data.c.
4903 (Fisnan): Always define, since it's always available now.
4904 (syms_of_floatfns): Always define isnan at the Lisp level.
4905
e39b275c 49062011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
4907
4908 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
4909
b2db44d9 49102011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 4911
f4af5137 4912 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
4913 The previous code assumed that file offsets (off_t values) fit in
4914 EMACS_INT variables, which is not true on typical 32-bit hosts.
4915 The code messed up by falsely reporting buffer overflow in cases
4916 such as (insert-file-contents "big" nil 1 2) into an empty buffer
4917 when "big" contains more than 2**29 bytes, even though this
4918 inserts just one byte and does not overflow the buffer.
4919 (Finsert_file_contents): Store file offsets as off_t
4920 values, not as EMACS_INT values. Check for overflow when
4921 converting between EMACS_INT and off_t. When checking for
4922 buffer overflow or for overlap, take the offsets into account.
4923 Don't use EMACS_INT for small values where int suffices.
4924 When checking for overlap, fix a typo: ZV was used where
4925 ZV_BYTE was intended.
4926 (Fwrite_region): Don't assume off_t fits into 'long'.
4927 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
4928
ecfc0a49
MA
49292011-09-05 Michael Albinus <michael.albinus@gmx.de>
4930
4931 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
4932
6511acf2 49332011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 4934
0999621a 4935 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
4936
4937 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 4938 (esprintf, exprintf, evxprintf): New functions.
62f19c19 4939 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 4940 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
4941 (modify_event_symbol): Do not assume that the length of
4942 name_alist_or_stem is safe to alloca and fits in int.
4943 (Fexecute_extended_command): Likewise for function name and binding.
4944 (Frecursion_depth): Wrap around reliably on integer overflow.
4945 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
4946 since some callers pass EMACS_INT values.
4947 (Fsingle_key_description): Don't crash if symbol name contains more
4948 than MAX_ALLOCA bytes.
4949 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
4950 (get_minibuffer): Arg is now EMACS_INT, not int.
4951 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 4952 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
4953 * window.h (command_loop_level, minibuf_level): Reflect API changes.
4954
2be7d702
PE
4955 * dbusbind.c (signature_cat): New function.
4956 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
4957 Do not overrun buffer; instead, report string overflow.
4958
9d1df220
PE
4959 * dispnew.c (add_window_display_history): Don't overrun buffer.
4960 Truncate instead; this is OK since it's just a log.
4961
33ef5c64
PE
4962 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
4963 even if the time zone offset is outlandishly large.
4964 Don't mishandle offset == INT_MIN.
4965
66c6fdd5
PE
4966 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
4967 when creating daemon; the previous buffer-overflow check was incorrect.
4968
d749b01b
PE
4969 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
4970 which has the guts of the old verror function.
4971
b5cd1905
PE
4972 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
4973 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
4974
6e1a67fb
PE
4975 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
4976 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 4977 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 4978 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
4979 length of string rather than counting it via multiple sprintfs;
4980 that's simpler and more reliable.
c21721cc
PE
4981 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
4982 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
4983 sprintf, in case result does not fit in int.
4984
c57b67fc
PE
4985 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
4986 (fontset_from_font): Print it.
4987
8a401434
PE
4988 * frame.c (tty_frame_count): Now printmax_t, not int.
4989 (make_terminal_frame, set_term_frame_name): Print it.
4990 (x_report_frame_params): In X, window IDs are unsigned long,
4991 not signed long, so print them as unsigned.
4992 (validate_x_resource_name): Check for implausibly long names,
4993 and don't assume name length fits in 'int'.
4994 (x_get_resource_string): Don't blindly alloca invocation name;
4995 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
4996 not fit in int.
4997
6e1a67fb
PE
4998 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
4999 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
5000 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
5001
0df02bf3
PE
5002 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
5003 Use esprintf, not sprintf, in case result does not fit in int.
5004
48e30793
PE
5005 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5006 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
5007 it as a large positive number.
5008 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
5009 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5010
a66ff6d8
PE
5011 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
5012 in case result does not fit in int.
5013
aca216ff
PE
5014 * print.c (float_to_string): Detect width overflow more reliably.
5015 (print_object): Make sprintf buffer a bit bigger, to avoid potential
5016 buffer overrun. Don't assume list length fits in 'int'. Treat
5017 print length of 0 as 0, not as infinity; to be consistent with other
5018 uses of print length in this function. Don't overflow print length
5019 index. Don't assume hash table size fits in 'long', or that
5020 vectorlike size fits in 'unsigned long'.
5021
31c286f7
PE
5022 * process.c (make_process): Use printmax_t, not int, to format
5023 process-name gensyms.
5024
55e5faa1
PE
5025 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
5026
80f2e268
PE
5027 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
5028 to avoid potential buffer overrun.
5029
670741ab
PE
5030 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
5031 if X resource line is longer than 512 bytes.
5032
b7163a50
PE
5033 * xfns.c (x_window): Make sprintf buffer a bit bigger
5034 to avoid potential buffer overrun.
5035
ae58ff1f
PE
5036 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
5037
c43c8a6a
PE
5038 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
5039
3f8236f4
PE
50402011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5041
53e9fe90 5042 Integer overflow fixes for scrolling, etc.
6511acf2
PE
5043 Without these, Emacs silently mishandles large integers sometimes.
5044 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
5045 it were "C-u 1 M-x recenter" on a typical 64-bit host.
5046
6511acf2
PE
5047 * xdisp.c (try_window_id): Check Emacs fixnum range before
5048 converting to 'int'.
806add1d 5049
6511acf2 5050 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
5051 Check that an Emacs fixnum is in range before assigning it to 'int'.
5052 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
5053 values converted from Emacs fixnums.
5054 (Frecenter): Don't wrap around a line count if it is out of 'int'
5055 range; instead, treat it as an extreme value.
5056 (Fset_window_configuration, compare_window_configurations):
5057 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
5058
6511acf2
PE
5059 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
5060 that can exceed INT_MAX. Check that EMACS_INT value is in range
5061 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
5062 (match_limit): Don't assume that a fixnum can fit in 'int'.
5063
6511acf2 5064 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
5065 exceed INT_MAX.
5066
6511acf2 5067 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
5068 (Fvertical_motion): Don't wrap around LINES values that don't fit
5069 in 'int'. Instead, treat them as extreme values. This is good
5070 enough for windows, which can't have more than INT_MAX lines anyway.
5071
fcb901a7
LMI
50722011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5073
0f2f6b6d
LMI
5074 * Require libxml/parser.h to avoid compilation warning.
5075
fcb901a7
LMI
5076 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
5077
5078 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
5079 since this reportedly can destroy thread storage.
5080
6e20a0d4
CY
50812011-08-30 Chong Yidong <cyd@stupidchicken.com>
5082
5083 * syntax.c (find_defun_start): Update all cache variables if
5084 exiting early (Bug#9401).
5085
148ae00e
EZ
50862011-08-30 Eli Zaretskii <eliz@gnu.org>
5087
f6cfbd8f
EZ
5088 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
5089
148ae00e
EZ
5090 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
5091 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
5092 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
5093
5094 * term.c (tty_append_glyph): New function.
5095 (produce_stretch_glyph): Static function and its prototype deleted.
5096
a66cfb1c
SM
5097 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
5098 Add prototypes.
148ae00e 5099
c4a07a4c
PE
51002011-08-29 Paul Eggert <eggert@cs.ucla.edu>
5101
5102 * image.c (parse_image_spec): Check for nonnegative, not for positive,
5103 when checking :margin (Bug#9390).
5104 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 5105 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
5106 so that the name doesn't mislead. All uses changed.
5107
6bc8cd65
JB
51082011-08-28 Johan Bockgård <bojohan@gnu.org>
5109
5110 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
5111 set_tty_hooks.
5112
dca4927e
EZ
51132011-08-27 Eli Zaretskii <eliz@gnu.org>
5114
5115 * xdisp.c (move_it_to): Don't bail out early when reaching
5116 position beyond to_charpos, if we are scanning backwards.
5117 (move_it_vertically_backward): When DY == 0, make sure we get to
5118 the first character in the line after the newline.
5119
f2cad773
PE
51202011-08-27 Paul Eggert <eggert@cs.ucla.edu>
5121
5122 * ccl.c: Improve and simplify overflow checking (Bug#9196).
5123 (ccl_driver): Do not generate an out-of-range pointer.
5124 (Fccl_execute_on_string): Remove unnecessary check for
5125 integer overflow, noted by Stefan Monnier in
5126 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
5127 Remove a FIXME that didn't need fixing.
5128 Simplify the newly-introduced buffer reallocation code.
5129
0cae2cdb
JB
51302011-08-27 Juanma Barranquero <lekktu@gmail.com>
5131
5132 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
5133
5fc295a4 51342011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 5135
70c60eb2 5136 Integer and memory overflow issues (Bug#9196).
726e0ab1 5137
d31850da
PE
5138 * doc.c (get_doc_string): Rework so that
5139 get_doc_string_buffer_size is the actual buffer size, rather than
5140 being 1 less than the actual buffer size; this makes xpalloc more
5141 convenient.
5142
a69fbedb
PE
5143 * image.c (x_allocate_bitmap_record, cache_image):
5144 * xselect.c (Fx_register_dnd_atom):
5145 Simplify previous changes by using xpalloc.
5146
fe5c5d37
PE
5147 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
5148 since either will do and ptrdiff_t is convenient with xpalloc.
5149
0065d054
PE
5150 * charset.c (charset_table_size)
5151 (struct charset_sort_data.priority): Now ptrdiff_t.
5152 (charset_compare): Don't overflow if priorities differ greatly.
5153 (Fsort_charsets): Don't assume list length fits in int.
5154 Check for size-calculation overflow when allocating sort data.
5155 (syms_of_charset): Allocate an initial charset table that is
5156 just under 64 KiB, to avoid problems with glibc malloc and mmap.
5157
5158 * cmds.c (internal_self_insert): Check for size-calculation overflow.
5159
5160 * composite.h (struct composition.glyph_len): Now int, not unsigned.
5161 The actual value is always <= INT_MAX, and leaving it unsigned made
5162 overflow checking harder.
5163
5164 * dispextern.h (struct glyph_matrix.rows_allocated)
5165 (struct face_cache.size): Now ptrdiff_t, for convenience in use
5166 with xpalloc. The values are still always <= INT_MAX.
5167
5168 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
5169
5170 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
5171 (SAFE_NALLOCA): New macro.
5172
5173 * region-cache.c (struct boundary.pos, find_cache_boundary)
5174 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
5175 (set_cache_region, invalidate_region_cache)
5176 (revalidate_region_cache, know_region_cache, region_cache_forward)
5177 (region_cache_backward, pp_cache):
5178 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
5179 so that ptrdiff_t * can be passed to xpalloc.
5180 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
5181 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
5182 (pp_cache): Don't assume cache_len fits in int.
5183 * region-cache.h: Adjust extern decls to match.
5184
5185 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
5186 EMACS_INT, since either will do, for xpalloc.
5187
5188 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
5189 (xnmalloc, xnrealloc, xpalloc): New functions.
5190
726e0ab1
PE
5191 * bidi.c (bidi_shelve_header_size): New constant.
5192 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
5193 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
5194
51f30bc5 5195 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
5196 * buffer.c (overlays_at, overlays_in, record_overlay_string)
5197 (overlay_strings):
5198 Don't update size of array until after memory allocation succeeds,
5199 because xmalloc/xrealloc may not return.
0065d054
PE
5200 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
5201 now that we have proper integer overflow checking.
5202 (record_overlay_string, overlay_strings): Catch overflows when
5203 calculating size of overlay_str_buf.
726e0ab1 5204
0065d054
PE
5205 * callproc.c (Fcall_process): Check for size overflow when
5206 calculating size of args2.
5207 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
5208 Normally we prefer signed values, but sticking with ptrdiff_t would
5209 require adding more-complicated checks.
726e0ab1
PE
5210
5211 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
5212 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
5213 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 5214 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
5215
5216 * character.c (Fstring): Check for size-calculation overflow.
5217
5218 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
5219 unnecessary integer overflow. Check for size overflow.
5220 (encode_coding_object): Don't update size until xmalloc succeeds.
5221
5222 * composite.c (get_composition_id): Check for overflow in glyph
5223 length calculations.
5224
5225 Integer and memory overflow fixes for display code.
5226 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
5227 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
5228 (scrolling_window): Check for overflow in size calculations.
5229 (line_draw_cost, realloc_glyph_pool, add_row_entry):
5230 Don't assume glyph table len fits in int.
5231 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
5232 (row_table_size): Now ptrdiff_t, not int.
5233 (scrolling_window): Avoid overflow in size calculations.
5234 Don't update size until allocation succeeds.
5235 * fns.c (concat): Check for overflow in size calculations.
5236 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
5237 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5238 (NEXT_ALMOST_PRIME_LIMIT): New constant.
5239
5240 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
5241 (get_doc_string): Check for size calculation overflow.
5242 Don't update size until allocation succeeds.
5243 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
5244 EMACS_INT, where ptrdiff_t will do.
5245 (Fsubstitute_command_keys): Check for string overflow.
5246
5247 * editfns.c (set_time_zone_rule): Don't assume environment length
5248 fits in int.
5249 (message_length): Now ptrdiff_t, not int.
5250 (Fmessage_box): Don't update size until allocation succeeds.
5251 Don't assume message length fits in int.
5252 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
5253
0065d054
PE
5254 * emacs.c (main): Do not reallocate argv, since there is a null at
5255 the end that can be overwritten, and this way there's no need to
5256 worry about size-calculation overflow.
5257 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
5258
5259 * eval.c (init_eval_once, grow_specpdl): Don't update size until
5260 alloc succeeds.
5261 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
5262
5263 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
5264 (x_set_scroll_bar_width, x_figure_window_size):
5265 Check for integer overflow.
5266 (x_set_alpha): Do not assume XINT fits in int.
5267
5268 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
5269 This is for the members text_lines, text_cols, total_lines, total_cols,
5270 where the system imposes an 'int' limit.
5271
5272 * fringe.c (Fdefine_fringe_bitmap):
5273 Don't update size until alloc works.
5274
5275 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
5276 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
5277
5278 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
5279 Check for size-calculation overflow.
5280 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
5281 do, as we prefer signed integers.
5282 (id_to_widget.max_size, id_to_widget.used)
5283 (xg_store_widget_in_map, xg_remove_widget_from_map)
5284 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
5285 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
5286 Use and return ptrdiff_t, not int.
5287 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
5288 * gtkutil.h: Change prototypes to match the above.
5289
5290 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
5291 are duplicate now that they've been promoted to lisp.h.
5292 (x_allocate_bitmap_record, x_alloc_image_color)
5293 (make_image_cache, cache_image, xpm_load):
5294 Don't update size until alloc is done.
5295 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
5296 (x_detect_edges):
3256efce 5297 Check for size calculation overflow.
726e0ab1
PE
5298 (ct_colors_allocated_max): New constant.
5299 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
5300 overflow.
3256efce 5301
726e0ab1
PE
5302 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
5303 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
5304 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
5305 Use ptrdiff_t, not int, to count maps.
5306 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
5307 calculations. Don't update size until allocation succeeds.
5308 Redo calculations to avoid overflow.
726e0ab1
PE
5309 * keyboard.h: Change prototypes to match the above.
5310
5311 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
5312 to count maps.
5313 (current_minor_maps): Check for size calculation overflow.
5314 * keymap.h: Change prototypes to match the above.
5315
5316 * lread.c (read1, init_obarray): Don't update size until alloc done.
5317
5318 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
5319 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
5320
726e0ab1
PE
5321 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
5322 Now ptrdiff_t, not int.
5323 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
5324 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
5325
5326 * process.c (Fnetwork_interface_list): Check for overflow
5327 in size calculation.
5328
5329 * region-cache.c (move_cache_gap): Check for size calculation overflow.
5330
5331 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
5332 overflow. Don't bother calling xmalloc when xrealloc will do.
5333
5334 * search.c (Freplace_match): Check for size calculation overflow.
5335 (Fset_match_data): Don't assume list lengths fit in 'int'.
5336
5337 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
5338 for command line length. Do not attempt to address one before the
5339 beginning of an array, as that's not portable.
5340
5341 * term.c (max_frame_lines): Remove; unused.
5342 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
5343 not int.
5344 (encode_terminal_code, calculate_costs): Check for size
5345 calculation overflow.
5346 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
5347 table lengths and related sizes. Don't update size until alloc
5348 done. Redo calculations to avoid overflow.
5349 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
5350
5351 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
5352 subtracting pointers.
5353 (gobble_line): Check for overflow more carefully. Don't update size
5354 until alloc done.
5355
5356 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
5357 Don't update size until alloc done.
5358 Redo size calculations to avoid overflow.
5359 Check for size calculation overflow.
0065d054 5360 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
5361
5362 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
5363 Use ptrdiff_t, not int, for sizes.
5364 (store_mode_line_noprop_char): Don't update size until alloc done.
5365
0065d054
PE
5366 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
5367 Use ptrdiff_t, not int, for sizes.
5368 (Finternal_make_lisp_face, cache_face):
5369 Check for size calculation overflow.
5370 (cache_face): Treat size calculation overflows as if they were
5371 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
5372
5373 * xfns.c (x_encode_text, x_set_name_internal)
5374 (Fx_change_window_property): Use ptrdiff_t, not int, to count
5375 sizes, since they can exceed INT_MAX in size. Check for size
5376 calculation overflow.
5377
0065d054
PE
5378 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
5379 (xg_select): Check for size calculation overflow.
726e0ab1
PE
5380 Don't update size until alloc done.
5381
0065d054 5382 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 5383 as sprintf is limited to int lengths.
1d526e2f 5384
252c5ee1
PE
5385 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
5386 (X_LONG_MIN): New macros.
864d7ce7
PE
5387 Use them to make the following changes clearer.
5388 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
5389 This change doesn't affect the value now, but it may help remind
5390 future maintainers not to raise the value too much later.
5391 (SELECTION_QUANTUM): Remove, replacing with ...
5392 (selection_quantum): ... new function, which avoids overflow.
5393 All uses changed.
5394 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
5395 assumption that selection length fits in 'int'.
5396 (x_reply_selection_request, x_handle_selection_request)
5397 (x_get_window_property, receive_incremental_selection)
5398 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
5399 (lisp_data_to_selection_data, clean_local_selection_data):
5400 Use ptrdiff_t, not int, to record length of selection.
5401 (x_reply_selection_request, x_get_window_property)
5402 (receive_incremental_selection, x_property_data_to_lisp):
5403 Redo calculations to avoid overflow.
5404 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 5405 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
5406 something.
5407 (x_get_window_property, receive_incremental_selection)
5408 (lisp_data_to_selection_data, x_property_data_to_lisp):
5409 Check for size-calculation overflow.
5410 (x_get_window_property, receive_incremental_selection)
5411 (lisp_data_to_selection_data, Fx_register_dnd_atom):
5412 Don't store size until memory allocation succeeds.
5413 (x_get_window_property): Plug memory leak on memory exhaustion.
5414 Don't double-block input; malloc is safe here. Don't assume 2**34
5415 - 4 fits in unsigned long. Add an xassert to check
5416 XGetWindowProperty overflow. Be more careful about overflow
5417 calculations, and distinguish size from memory overflow better.
5418 (receive_incremental_selection): When tracing, don't assume
5419 unsigned int is less than INT_MAX.
5420 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
5421 harmful) conversions of unsigned short to int.
5422 (lisp_data_to_selection_data): Don't assume that integers
5423 in the range -65535 through -1 fit in an X unsigned short.
5424 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
5425 result parameters unless successful. Rely on cons_to_unsigned
5426 to report problems with elements; the old code wasn't right anyway.
5427 (x_check_property_data): Check for int overflow; we cannot use
5428 a wider type due to X limits.
5429 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
5430
726e0ab1 5431 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 5432
0065d054
PE
5433 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
5434 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
5435 (x_color_cells): Don't store size until memory allocation succeeds.
5436 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 5437 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
5438 (x_term_init): Don't assume length fits in int (sprintf is limited
5439 to int size).
bc18e09d 5440
ebfa62c0
PE
5441 Use ptrdiff_t for composition IDs.
5442 * character.c (lisp_string_width):
5443 * composite.c (composition_table_size, n_compositions)
5444 (get_composition_id, composition_gstring_from_id):
5445 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
5446 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
5447 * window.c (Frecenter):
5448 Use ptrdiff_t, not int, for composition IDs.
5449 * composite.c (get_composition_id): Check for integer overflow.
5450 * composite.h: Adjust prototypes to match the above changes.
5451
d3411f89
PE
5452 Use ptrdiff_t for hash table indexes.
5453 * category.c (hash_get_category_set):
5454 * ccl.c (ccl_driver):
5455 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
5456 * coding.c (coding_system_charset_list, detect_coding_system):
5457 * coding.h (struct coding_system.id):
5458 * composite.c (get_composition_id, gstring_lookup_cache):
5459 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
5460 * image.c (xpm_get_color_table_h):
5461 * lisp.h (hash_lookup, hash_put):
5462 * minibuf.c (Ftest_completion):
5463 Use ptrdiff_t for hash table indexes, not int (which is too
5464 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
5465 32-bit --with-wide-int hosts).
5466
e097a6fa
PE
5467 * charset.c (Fdefine_charset_internal): Check for integer overflow.
5468 Add a FIXME comment about memory leaks.
5469 (syms_of_charset): Don't assume xmalloc returns.
5470
5637687f
PE
5471 Don't assume that stated character widths fit in int.
5472 * character.c (Fchar_width, c_string_width, lisp_string_width):
5473 * character.h (CHAR_WIDTH):
5474 * indent.c (MULTIBYTE_BYTES_WIDTH):
5475 Use sanitize_char_width to avoid undefined and/or bad behavior
5476 with outlandish widths.
a66cfb1c 5477 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
5478 now that we have two such functions. All uses changed.
5479 (sanitize_char_width): New inline function.
5480
a2271ba2
PE
5481 Don't assume that tab-width fits in int.
5482 * character.h (sanitize_width): New inline function.
5483 (SANE_TAB_WIDTH): New macro.
5484 (ASCII_CHAR_WIDTH): Use it.
5485 * indent.c (sane_tab_width): Remove. All uses replaced by
5486 SANE_TAB_WIDTH (current_buffer).
5487 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
5488
18c52557
PE
5489 * fileio.c: Integer overflow issues with file modes.
5490 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
5491
caeeedc1
PE
5492 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
5493 Remove unreachable code.
5494 (read_hex, load_charset_map_from_file): Check for integer overflow.
5495
6df6ae42 5496 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
5497 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
5498 (x_send_scroll_bar_event): Likewise. Check that the size does not
5499 exceed limits imposed by XClientMessageEvent, as well as the usual
5500 ptrdiff_t and size_t limits.
5501
b13995db
PE
5502 * keyboard.c: Overflow, signedness and related fixes.
5503 (make_lispy_movement): Use same integer type in forward decl
5504 that is used in the definition.
5505 (read_key_sequence, keyremap_step):
5506 Change bufsize argument back to int, undoing my 2011-03-30 change.
5507 We prefer signed types, and int is wide enough here.
5508 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
5509 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
5510 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
5511 length, not size_t. Use ptrdiff_t for index, not int.
5512 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
5513 possibility of integer overflow.
5514
13464394
PE
5515 Overflow, signedness and related fixes for images.
5516
5517 * dispextern.h (struct it.stack[0].u.image.image_id)
5518 (struct_it.image_id, struct image.id, struct image_cache.size)
5519 (struct image_cache.used, struct image_cache.ref_count):
5520 * gtkutil.c (update_frame_tool_bar):
5521 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
5522 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
5523 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
5524 * nsmenu.m (update_frame_tool_bar):
5525 * xdisp.c (calc_pixel_width_or_height):
5526 * xfns.c (image_cache_refcount):
5527 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
5528 on typical 64-bit hosts.
5529
5530 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5531 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
5532 Omit unnecessary casts to int.
5533 (parse_image_spec): Check that integers fall into 'int' range
5534 when the callers expect that.
5535 (image_ascent): Redo ascent calculation to avoid int overflow.
5536 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
5537 (lookup_image): Remove unnecessary tests.
5538 (xbm_image_p): Locals are now of int, not EMACS_INT,
5539 since parse_image_check makes sure they fit into int.
5540 (png_load, gif_load, svg_load_image):
5541 Prefer int to unsigned where either will do.
5542 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
5543 old tiff_error_handler and tiff_warning_handler.
5544 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
5545 stack buffer overflows. It uses only the features of vsnprintf
5546 that are common to both POSIX and native Microsoft.
5547 (tiff_error_handler, tiff_warning_handler): Use it.
5548 (tiff_load, gif_load, imagemagick_load_image):
5549 Don't assume :index value fits in 'int'.
5550 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
5551 (imagemagick_load_image): Check that crop parameters fit into
5552 the integer types that MagickCropImage accepts. Don't assume
5553 Vimagemagick_render_type has a nonnegative value. Don't assume
5554 size_t fits in 'long'.
5555 (gs_load): Use printmax_t to print the widest integers possible.
5556 Check for integer overflow when computing image height and width.
5557
c11821d4
EZ
55582011-08-26 Eli Zaretskii <eliz@gnu.org>
5559
5560 * xdisp.c (redisplay_window): Don't force window start if point
5561 will be invisible in the resulting window. (Bug#9324)
5562
0c95fcf7
EZ
55632011-08-25 Eli Zaretskii <eliz@gnu.org>
5564
5565 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
5566 the display spec is of the form `(space ...)'.
5567 (handle_display_spec): Return the value returned by
5568 handle_single_display_spec, not just 1 or zero.
5569 (handle_single_display_spec): If the display spec is of the form
5570 `(space ...)', and specifies display in the text area, return 2
5571 rather than 1.
fee65a97 5572 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
5573 accurately, and prefer exact match for point under bidi.
5574 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
5575
5576 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
5577 into disp_prop; all users changed.
5578
5579 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
5580 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
5581 for the text covered by the display property.
5582
e4ed06f1
CY
55832011-08-25 Chong Yidong <cyd@stupidchicken.com>
5584
5585 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
5586 Change return value to nil.
5587 (Frecord_buffer): Delete unused function.
5588
f67cdd7f
EZ
55892011-08-24 Eli Zaretskii <eliz@gnu.org>
5590
5980d4c6
EZ
5591 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
5592 buffers, return left-to-right.
8610fe8b
EZ
5593 (set_cursor_from_row): Consider candidate row a win if its glyph
5594 represents a newline and point is on that newline. Fixes cursor
5595 positioning on the newline at EOL of R2L text within L2R
5596 paragraph, and vice versa.
5597 (try_cursor_movement): Check continued rows, in addition to
5598 continuation rows. Fixes unwarranted scroll when point enters a
5599 continued line of R2L text within an L2R paragraph, or vice versa.
5600 (cursor_row_p): Consider the case of point being equal to
5601 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
5602 from the end of a short line to the beginning of a continued line
5603 of R2L text within L2R paragraph.
5604 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
5605 composed characters.
5980d4c6 5606
f67cdd7f
EZ
5607 * bidi.c (bidi_check_type): Use xassert.
5608 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
5609 members.
5610
bca633fb
EZ
56112011-08-23 Eli Zaretskii <eliz@gnu.org>
5612
5613 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
5614 a character.
5615
4a5885a7
CY
56162011-08-23 Chong Yidong <cyd@stupidchicken.com>
5617
5618 * nsfont.m (ns_otf_to_script): Fix typo.
5619
0902a04e
KH
56202011-08-22 Kenichi Handa <handa@m17n.org>
5621
5622 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
5623 extra slot even if the purpose is char-code-property-table.
5624
1a2e6670
EZ
56252011-08-23 Eli Zaretskii <eliz@gnu.org>
5626
8ddde651
EZ
5627 * xdisp.c (redisplay_window): When computing centering_position,
5628 account for the height of the header line. (Bug#8874)
5629
425cc014
EZ
5630 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
5631 instead of CHAR_TO_BYTE. Fixes a crash when a completion
5632 candidate is selected by the mouse, and that candidate has a
5633 composed character under the mouse.
5634
1a2e6670
EZ
5635 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
5636 coordinates reported by pos-visible-in-window-p for a composed
5637 character in column zero.
5638
8b76d6f8
SM
56392011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
5640
5641 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
5642
dac347dd
EZ
56432011-08-22 Eli Zaretskii <eliz@gnu.org>
5644
5645 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
5646 consider it a hit if to_charpos is anywhere in the range of the
5647 composed buffer positions.
5648
e013fb34
CY
56492011-08-22 Chong Yidong <cyd@stupidchicken.com>
5650
5651 * image.c (gif_load): Don't assume that each subimage has the same
5652 dimensions as the base image. Handle disposal method that is
5653 "undefined" by the gif spec (Bug#9335).
5654
bd1ba3e8
CY
56552011-08-20 Chong Yidong <cyd@stupidchicken.com>
5656
5657 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 5658 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 5659
54a1215b
EZ
56602011-08-19 Eli Zaretskii <eliz@gnu.org>
5661
823564e5
EZ
5662 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
5663 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
5664 from an Org mode buffer to a Speedbar frame.
5665
54a1215b
EZ
5666 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
5667 a composition, take its buffer position from IT->cmp_it.charpos.
5668 Fixes cursor positioning at the beginning of a line that begins
5669 with a composed character.
5670
9778ebcc
EZ
56712011-08-18 Eli Zaretskii <eliz@gnu.org>
5672
0be6ee06
EZ
5673 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
5674 character bidirectional type, use STRONG_L instead. Fixes crashes
5675 in a buffer produced by `describe-categories'.
5676
9778ebcc
EZ
5677 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
5678 members before the level stack, so they would be saved and
5679 restored when copying iterator state. Fixes incorrect reordering
5680 around TABs covered by display properties.
5681
156bffbe
AS
56822011-08-18 Andreas Schwab <schwab@linux-m68k.org>
5683
6b02f655 5684 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 5685
72ad093b
CY
56862011-08-17 Chong Yidong <cyd@stupidchicken.com>
5687
5688 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
5689 (internal_condition_case_2, internal_condition_case_n):
5690 Remove unnecessary aborts (Bug#9081).
72ad093b 5691
35774242
EZ
56922011-08-17 Eli Zaretskii <eliz@gnu.org>
5693
5694 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
5695 has no `load' handler, try opening the file locally. (Bug#9311)
5696
db76dd85
KB
56972011-08-16 Ken Brown <kbrown@cornell.edu>
5698
5699 * gmalloc.c: Expand comment.
5700
b215eee5
EZ
57012011-08-16 Eli Zaretskii <eliz@gnu.org>
5702
5703 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
5704 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
5705
a4579d33
KB
57062011-08-16 Ken Brown <kbrown@cornell.edu>
5707
5708 Fix memory allocation problems in Cygwin build (Bug#9273).
5709
5710 * unexcw.c ( __malloc_initialized): Declare external variable.
5711 (fixup_executable): Force the dumped emacs to reinitialize malloc.
5712
8b76d6f8
SM
5713 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
5714 New variables.
a4579d33
KB
5715 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
5716 dumped emacs.
5717 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
5718 in the static heap.
5719 [CYGWIN] (special_realloc): New function.
5720 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
5721 requests to realloc storage in the static heap.
5722
3ebec551
PE
57232011-08-15 Paul Eggert <eggert@cs.ucla.edu>
5724
5725 * bidi.c (bidi_initialize): Remove unused local.
5726
9fd8be00
EZ
57272011-08-15 Eli Zaretskii <eliz@gnu.org>
5728
6b02f655
SM
5729 * bidimirror.h:
5730 * biditype.h: Remove file.
5731 * makefile.w32-in ($(BLD)/bidi.$(O)):
5732 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
5733
5734 * dispextern.h: Fix a typo in the comment to bidi_type_t.
5735
5736 * chartab.c: Improve commentary for the uniprop_table API.
5737
32413314
EZ
5738 * bidi.c (bidi_paragraph_init): Support zero value of
5739 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
5740 (bidi_initialize): Use uniprop_table instead of including
5741 biditype.h and bidimirror.h.
32413314 5742
9fd8be00
EZ
5743 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
5744 coordinates of the iterator when restoring from ppos_it.
5745 (Bug#9296)
5746
5cf2b69b
KH
57472011-08-14 Kenichi Handa <handa@m17n.org>
5748
5749 * process.c (create_process): Call setup_process_coding_systems
72ad093b 5750 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 5751
daf17d00
EZ
57522011-08-14 Eli Zaretskii <eliz@gnu.org>
5753
5754 * xdisp.c (move_it_in_display_line_to): Don't invoke
5755 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
5756 ppos_it. Fixes vertical cursor motion when line beginning is
5757 covered by an image. (Bug#9296)
5758
08e3161a
JD
57592011-08-14 Jan Djärv <jan.h.d@swipnet.se>
5760
5761 * nsterm.h (ns_run_ascript): Declare.
5762 (NSAPP_DATA2_RUNASSCRIPT): Define.
5763
5764 * nsfns.m (as_script, as_result, as_status): New static variables.
5765 (ns_run_ascript): New function.
5e617bc2 5766 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
5767 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
5768 the event loop. Get status from as_status (Bug#7276).
5769
5770 * nsterm.m (sendEvent): If event is NSApplicationDefined and
5771 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
5772 the event loop (Bug#7276).
5773
a3720aa2
AS
57742011-08-14 Andreas Schwab <schwab@linux-m68k.org>
5775
5776 * gnutls.c (QCgnutls_bootprop_priority)
5777 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
5778 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
5779 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
5780 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
5781 (QCgnutls_bootprop_verify_hostname_error)
5782 (QCgnutls_bootprop_callbacks_verify): Rename from
5783 Qgnutls_bootprop_..., all uses changed.
5784
5785 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
5786 uses changed.
5787
0a0d27fb
PE
57882011-08-14 Paul Eggert <eggert@cs.ucla.edu>
5789
19d5c50c
PE
5790 * xfaces.c (Qframe_set_background_mode): Now static.
5791 * dispextern.h (Qframe_set_background_mode): Remove decl.
5792
0a0d27fb
PE
5793 * process.c (Fnetwork_interface_info): Declare local only if needed.
5794
377538cb
JD
57952011-08-13 Jan Djärv <jan.h.d@swipnet.se>
5796
5797 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
5798 (Fnetwork_interface_list): Allocate in increments of bytes instead
5799 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
5800 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
5801 sockaddr.
5802 (struct ifflag_def): notrailers is smart on OSX.
5803 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
5804 Get hardware address with getifaddrs if available.
5805
08fff70c
EZ
58062011-08-12 Eli Zaretskii <eliz@gnu.org>
5807
5808 * xdisp.c (iterate_out_of_display_property): xassert that
5809 IT->position is set to within IT->object's boundaries. Break from
5810 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
5811 when IT->position is set up wrongly due to some bug.
5812 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
5813 (push_display_prop): Allow GET_FROM_STRING as IT->method on
5814 entry. Force push_it to save on the stack the current
5815 buffer/string position, to be restored by pop_it. Fix flags in
5816 the iterator structure wrt the object coming from a display
5817 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
5818 properties. (Bug#9284)
5819
7be1c708 58202011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 5821
7be1c708
CY
5822 * fontset.c (fontset_get_font_group): Add proper type checks.
5823 (Bug#9172)
aac0c6e3 5824
7be1c708 58252011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 5826
7be1c708
CY
5827 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
5828 and LC_VERSION_MIN_MACOSX.
5829 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
5830 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 5831
97bb72a6
EZ
58322011-08-08 Eli Zaretskii <eliz@gnu.org>
5833
5834 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
5835 no-display-properties-and-no-overlays under bidi display.
5836 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 5837 properties and overlays.
97bb72a6 5838
d5617611
CY
58392011-08-08 Chong Yidong <cyd@stupidchicken.com>
5840
37e11a63
CY
5841 * editfns.c (Fset_time_zone_rule): Document relationship with the
5842 setenv function.
5843
d5617611
CY
5844 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
5845 the font entity extracted from the cache (Bug#8109).
5846
58872834
CY
58472011-08-07 Chong Yidong <cyd@stupidchicken.com>
5848
5849 * composite.c (autocmp_chars): Don't reset point. That is done by
5850 restore_point_unwind (Bug#5984).
5851
75bfc667
JL
58522011-08-07 Juri Linkov <juri@jurta.org>
5853
5854 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
5855 to show the arg `TIME' instead of `TIMEVAL'.
5856
d1410150
EZ
58572011-08-06 Eli Zaretskii <eliz@gnu.org>
5858
5859 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
5860 display property strides EOL and includes a newline, as in
5861 longlines-mode. (Bug#9254)
75b771e4
EZ
5862 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
5863 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
5864
5865 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
5866 is non-zero, even if the data buffer is NULL. Fixes a crash in
5867 vertical-motion with longlines-mode. (Bug#9254)
5868
35928349
EZ
58692011-08-05 Eli Zaretskii <eliz@gnu.org>
5870
ec7cc85b
EZ
5871 * bidi.c <bidi_cache_total_alloc>: Now static.
5872 (bidi_initialize): Initialize bidi_cache_total_alloc.
5873
8b76d6f8 5874 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
5875 cache. (Bug#9221)
5876
5877 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
5878 amount allocated this far in `bidi_cache_total_alloc'.
5879 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
5880 non-zero, only free the data buffer without restoring the cache
5881 contents. All callers changed.
5882
5883 * dispextern.h (bidi_unshelve_cache): Update prototype.
5884
5885 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
5886 (move_it_in_display_line, move_it_to)
5887 (move_it_vertically_backward, move_it_by_lines): Replace the call
5888 to xfree to an equivalent call to bidi_unshelve_cache.
5889 (move_it_in_display_line_to): Fix logic of returning
412b6358 5890 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 5891
e2e2423b
EZ
58922011-08-05 Eli Zaretskii <eliz@gnu.org>
5893
5894 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
5895 came from a string character with a `cursor' property. (Bug#9229)
5896
ae9e757a
JD
58972011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5898
5899 * Makefile.in (LIB_PTHREAD): New variable.
5900 (LIBES): Add LIB_PTHREAD (Bug#9216).
5901
5902 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
5903 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
5904
213bd7f2
AS
59052011-08-04 Andreas Schwab <schwab@linux-m68k.org>
5906
6b02f655 5907 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 5908
99aaf75f
JD
59092011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5910
5911 * xterm.c (x_find_topmost_parent): New function.
5912 (x_set_frame_alpha): Find topmost parent window with
5913 x_find_topmost_parent and set the property there also (bug#9181).
5914 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
5915
c74e9d86
PE
59162011-08-04 Paul Eggert <eggert@cs.ucla.edu>
5917
5918 * callproc.c (Fcall_process): Avoid vfork clobbering
5919 the local vars buffer, coding_systems, current_dir.
5920
640c8776
SM
59212011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
5922
5923 * keymap.c (Fmake_composed_keymap): Move to subr.el.
5924
f26d0e4c
PE
59252011-08-03 Paul Eggert <eggert@cs.ucla.edu>
5926
8a10d76c
PE
5927 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
5928 so that it is not optimized away.
5929
f26d0e4c
PE
5930 * xdisp.c (compute_display_string_pos): Remove unused local.
5931
55439c61
EZ
59322011-08-02 Eli Zaretskii <eliz@gnu.org>
5933
5934 Fix slow cursor motion and scrolling in large buffers with
5935 selective display, like Org Mode buffers. (Bug#9218)
5936
5937 * dispextern.h (struct bidi_it): New member disp_prop_p.
5938
5939 * xdisp.c: Remove one-slot cache of display string positions.
5940 (compute_display_string_pos): Accept an additional argument
5e617bc2 5941 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
5942 for a display string or property. If found, set DISP_PROP_P
5943 non-zero.
5944
5945 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
5946 DISP_PROP_P, and pass it to compute_display_string_pos.
5947 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
5948 non-zero. All callers of bidi_fetch_char changed.
5949
fb33fa43
SM
59502011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
5951
5952 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
5953
b099e063
DM
59542010-12-03 Don March <don@ohspite.net>
5955
5956 * keymap.c (Fdefine_key): Fix non-prefix key error message when
5957 last character M-[char] is translated to ESC [char] (bug#7541).
5958
5cc7f7af
KH
59592011-08-02 Kenichi Handa <handa@m17n.org>
5960
d0fffa3f 5961 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
5962
5963 * chartab.c (uniprop_table): Make it non-static.
5964
525d5e6e
EZ
59652011-08-01 Eli Zaretskii <eliz@gnu.org>
5966
5967 * xdisp.c (forward_to_next_line_start): Accept additional argument
5968 BIDI_IT_PREV, and store into it the state of the bidi iterator had
5969 on the newline.
5970 (reseat_at_next_visible_line_start): Use the bidi iterator state
5971 returned by forward_to_next_line_start to restore the state of
5972 it->bidi_it after backing up to previous newline. (Bug#9212)
5973
31011111
AS
59742011-07-30 Andreas Schwab <schwab@linux-m68k.org>
5975
5976 * regex.c (re_comp): Protoize.
5977 (re_exec): Fix return type.
5978 (regexec): Fix type of `ret'. (Bug#9203)
5979
476371c4
PE
59802011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5981
e5d76069
PE
5982 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
5983 This is needed if max-image-size is a floating-point number.
5984
9a79b20c
AS
59852011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5986
5987 * print.c (print_object): Print empty symbol as ##.
5988
5989 * lread.c (read1): Read ## as empty symbol.
5990
d8c2fa78
AA
59912011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5992
5993 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
5994 setting frame foreground color (Bug#9175).
5995 (x_set_background_color): Likewise.
5996
ffe57a7a
AA
5997 * nsmenu.m (-setText): Size tooltip dimensions precisely to
5998 contents (Bug#9176).
5999 (EmacsTooltip -init): Remove bezels and add shadows to
6000 tooltip windows.
6001
bf3492a5
AA
6002 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
6003 or scroll bar (Bug#8470).
6004
d55e9c53
AA
6005 * nsfont.m (nsfont_open): Remove assignment to voffset and
6006 unnecessary vars hshink, expand, hd, full_height, min_height.
6007 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
6008
6009 * nsterm.h (nsfont_info): Remove voffset field.
6010
d8c2fa78 60112011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
6012
6013 Implement strike-through and overline on NextStep (Bug#8863).
6014
6015 * nsfont.m (nsfont_open): Use underline position provided by font,
6016 instead of hard-coded value of 2.
6017 (nsfont_draw): Call ns_draw_text_decoration instead.
6018
6019 * nsterm.h: Add declaration for ns_draw_text_decoration.
6020
6021 * nsterm.m (ns_draw_text_decoration): New function for drawing
6022 underline, overline, and strike-through.
6023 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
6024 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 6025 accommodate underlining, etc.
4843aac3 6026
4cc60b9b
EZ
60272011-07-28 Eli Zaretskii <eliz@gnu.org>
6028
bc7ece87
EZ
6029 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
6030 default.
4cc60b9b 6031
476371c4
PE
60322011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6033
66606eea
PE
6034 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
6035 Without this fix, if a signal arrives just after memory fills up,
6036 'malloc' might be invoked reentrantly.
6037
476371c4
PE
6038 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
6039 In other words, assume that every image size is allowed, on non-X
6040 hosts. This assumption is probably wrong, but it lets Emacs compile.
6041
f3fcc40d
AS
60422011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6043
6044 * regex.c (re_iswctype): Convert return values to boolean.
6045
350c992f
EZ
60462011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
6047
6048 * xdisp.c (compute_display_string_pos): Don't use cached display
6049 string position if the buffer had its restriction changed.
6050 (Bug#9184)
6051
5266b4bb
PE
60522011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6053
6054 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6055
2573a837 60562011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 6057
41f55ccd 6058 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 6059
39e378da
PE
6060 * bidi.c: Integer size and overflow fixes.
6061 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
6062 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
6063 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6064 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
6065 (bidi_find_other_level_edge):
6066 Use ptrdiff_t instead of EMACS_INT where either will do.
6067 This works better on 32-bit hosts configured --with-wide-int.
6068 (bidi_cache_ensure_space): Check for size-calculation overflow.
6069 Use % rather than repeated addition, for better worst-case speed.
6070 Don't set bidi_cache_size until after xrealloc returns, because it
6071 might not return.
6072 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
6073 (bidi_cache_ensure_space): Also check that the bidi cache size
6074 does not exceed that of the largest Lisp string or buffer. See Eli
6075 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 6076
5e927815
PE
6077 * alloc.c (__malloc_size_t): Remove.
6078 All uses replaced by size_t. See Andreas Schwab's note
6079 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
6080
ca4aa935
PE
6081 * image.c: Improve checking for integer overflow.
6082 (check_image_size): Assume that f is nonnull, since
6083 it is always nonnull in practice. This is one less thing to
6084 worry about when checking for integer overflow later.
6085 (x_check_image_size): New function, which checks for integer
6086 overflow issues inside X.
6087 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
6088 This removes the need for a memory_full check.
6089 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
6090 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
6091 (xbm_read_bitmap_data): Change locals back to 'int', since
6092 their values must fit in 'int'.
6093 (xpm_load_image, png_load, tiff_load):
6094 Invoke x_create_x_image_and_pixmap earlier,
6095 to avoid much needless work if the image is too large.
6096 (tiff_load): Treat overly large images as if
6097 x_create_x_image_and_pixmap failed, not as malloc failures.
6098 (gs_load): Use x_check_image_size.
6099
5f8f9cc2
PE
6100 * gtkutil.c: Omit integer casts.
6101 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
6102 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
6103
5adf60bc
PE
6104 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
6105
c8907a93
PE
6106 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
6107 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
6108 would wrongly return t on a 64-bit host.
6109
e3c25c68
PE
6110 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
6111 The plain *_OVERFLOW macros run afoul of GCC bug 49705
6112 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
6113 and therefore cause GCC to emit a bogus diagnostic in some cases.
6114
3f791afe
PE
6115 * image.c: Integer signedness and overflow and related fixes.
6116 This is not an exhaustive set of fixes, but it's time to
6117 record what I've got.
6118 (lookup_pixel_color, check_image_size): Remove redundant decls.
6119 (check_image_size): Don't assume that arbitrary EMACS_INT values
6120 fit in 'int', or that arbitrary 'double' values fit in 'int'.
6121 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
6122 (tiff_load, imagemagick_load_image):
6123 Check for overflow in size calculations.
6124 (x_create_x_image_and_pixmap): Remove unnecessary test for
6125 xmalloc returning NULL; that can't happen.
6126 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
6127 (xpm_color_bucket): Use better integer hashing function.
6128 (xpm_cache_color): Don't possibly over-allocate memory.
6129 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
6130 (gif_memory_source):
6131 Use ptrdiff_t, not int or size_t, to record sizes.
6132 (png_load): Don't assume values greater than 2**31 fit in 'int'.
6133 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
6134 either works, as we prefer signed integers.
6135 (tiff_read_from_memory, tiff_write_from_memory):
6136 Return tsize_t, not size_t, since that's what the TIFF API wants.
6137 (tiff_read_from_memory): Don't fail simply because the read would
6138 go past EOF; instead, return a short read.
6139 (tiff_load): Omit no-longer-needed casts.
6140 (Fimagemagick_types): Don't assume size fits into 'int'.
6141
3cc5a532
PE
6142 Improve hashing quality when configured --with-wide-int.
6143 * fns.c (hash_string): New function, taken from sxhash_string.
6144 Do not discard information about ASCII character case; this
6145 discarding is no longer needed.
6146 (sxhash-string): Use it. Change sig to match it. Caller changed.
6147 * lisp.h: Declare it.
6148 * lread.c (hash_string): Remove, since we now use fns.c's version.
6149 The fns.c version returns a wider integer if --with-wide-int is
6150 specified, so this should help the quality of the hashing a bit.
6151
b312a492
PE
6152 * emacs.c: Integer overflow minor fix.
6153 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
6154 Define only if GNU_LINUX.
6155 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
6156
dfd153ae
PE
6157 * dispnew.c: Integer signedness and overflow fixes.
6158 Remove unnecessary forward decls, that were a maintenance hassle.
6159 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
6160 All uses changed.
6161 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
6162 (scrolling_window): Use ptrdiff_t, not int, for byte count.
6163 (prepare_desired_row, line_draw_cost):
6164 Use int, not unsigned, where either works.
6165 (save_current_matrix, restore_current_matrix):
6166 Use ptrdiff_t, not size_t, where either works.
6167 (init_display): Check for overflow more accurately, and without
6168 relying on undefined behavior.
6169
a81d11a3
PE
6170 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
6171 Remove, replacing with the new symbols in lisp.h. All uses changed.
6172 * fileio.c (make_temp_name):
6173 * filelock.c (lock_file_1, lock_file):
6174 * xdisp.c (message_dolog):
6175 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
6176 Use pMd etc. instead.
6177 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
6178 replacing the pWIDE etc. symbols removed from editfns.c.
6179
3300e6fd
PE
6180 * keyboard.h (num_input_events): Now uintmax_t.
6181 This is (very slightly) less likely to mess up due to wraparound.
6182 All uses changed.
6183
fd05c7e9
PE
6184 * buffer.c: Integer signedness fixes.
6185 (alloc_buffer_text, enlarge_buffer_text):
6186 Use ptrdiff_t rather than size_t when either will do, as we prefer
6187 signed integers.
6188
903fe15d
PE
6189 * alloc.c: Integer signedness and overflow fixes.
6190 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
6191 (__malloc_size_t): Default to size_t, not to int.
6192 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
6193 (Fgarbage_collect, mark_object_loop_halt, mark_object):
6194 Prefer ptrdiff_t to size_t when either would do, as we prefer
6195 signed integers.
6196 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
6197 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
6198 Now const. Initialize with values that are in range even if char
6199 is signed.
6200 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
6201 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
6202 These functions do the right thing with sizes > 2**32.
6203 (check_depth): Now ptrdiff_t, not int.
6204 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
6205 Adjust to new way of storing sizes. Check for size overflow bugs
6206 in rest of code.
6207 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
6208 slightly wrong anyway, as it missed one instance of
6209 XMALLOC_OVERRUN_CHECK_OVERHEAD.
6210 (refill_memory_reserve): Omit needless cast to size_t.
6211 (mark_object_loop_halt): Mark as externally visible.
6212
ac82cc6a
PE
6213 * xselect.c: Integer signedness and overflow fixes.
6214 (Fx_register_dnd_atom, x_handle_dnd_message):
6215 Use ptrdiff_t, not size_t, since we prefer signed.
6216 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
6217 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
6218 x_dnd_atoms_size and x_dnd_atoms_length.
6219
c2d1e36d
PE
6220 * doprnt.c: Prefer signed to unsigned when either works.
6221 * eval.c (verror):
6222 * doprnt.c (doprnt):
6223 * lisp.h (doprnt):
6224 * xdisp.c (vmessage):
6225 Use ptrdiff_t, not size_t, when using or implementing doprnt,
6226 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
6227 prefer signed arithmetic to avoid comparison confusion.
6228 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
6229 but is a bit tricky.
6230
0e926e56
PE
6231 Assume freestanding C89 headers, string.h, stdlib.h.
6232 * data.c, doprnt.c, floatfns.c, print.c:
6233 Include float.h unconditionally.
6234 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
6235 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
6236 * regex.c: Likewise for stddef.h, string.h.
6237 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
6238 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
6239 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
6240 (STDC_HEADERS): Remove obsolete defines.
6241 * sysdep.c: Include limits.h unconditionally.
6242
9cfdb3ec
PE
6243 Assume support for memcmp, memcpy, memmove, memset.
6244 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
6245 * regex.c (memcmp, memcpy):
6246 Remove; we assume C89 now.
6247
6248 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
6249 (__malloc_safe_bcopy): Remove; no longer needed.
6250
cf950e6b 6251 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
6252 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
6253 well either way, and we prefer signed to unsigned.
6254
dbf38e02
LMI
62552011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
6256
6257 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
6258 closes the connection while we're reading (bug#9182).
6259
d6f0886c 62602011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 6261
d6f0886c
JD
6262 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
6263 are specified (Bug#9168).
24e0f6b1 6264
2eb1f9e6
PE
62652011-07-25 Paul Eggert <eggert@cs.ucla.edu>
6266
6267 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
6268 Found by GCC static checking and --with-wide-int on a 32-bit host.
6269
22381272 62702011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
6271
6272 * xdisp.c (compute_display_string_pos): Fix logic of caching
6273 previous display string position. Initialize cached_prev_pos to
6274 -1. Fixes slow-down at the beginning of a buffer.
6275
f25e39b4
EZ
62762011-07-24 Eli Zaretskii <eliz@gnu.org>
6277
6278 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
6279 for attrs[LFACE_FONTSET_INDEX].
6280
04c4b52e
PE
62812011-07-23 Paul Eggert <eggert@cs.ucla.edu>
6282
6283 * xml.c (parse_region): Remove unused local
6284 that was recently introduced.
6285
c1734fbd
EZ
62862011-07-23 Eli Zaretskii <eliz@gnu.org>
6287
be18c5a5
EZ
6288 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
6289 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
6290
c1734fbd
EZ
6291 * xdisp.c (move_it_in_display_line_to): Record the best matching
6292 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
6293 exit if none of the characters scanned was an exact match.
6294 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
6295 when exact match is impossible due to invisible text, and the
6296 lines are truncated.
6297
a258d627
JD
62982011-07-23 Jan Djärv <jan.h.d@swipnet.se>
6299
6300 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
6301 for OSX >= 10.7.
6302
b6d5a689
EZ
63032011-07-22 Eli Zaretskii <eliz@gnu.org>
6304
0f74f785
EZ
6305 Fix a significant slow-down of cursor motion with C-n, C-p,
6306 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
6307 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 6308 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
6309 (next_element_from_buffer): Call compute_stop_pos_backwards to
6310 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
6311 base_level_stop.
6312 (reseat): Don't look for prev_stop, as that could mean a very long
6313 run.
6314 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
6315 <cached_disp_overlay_modiff>: Cache for last found display string
6316 position.
551918c1 6317 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
6318 about the same buffer in the same area of character positions, and
6319 the buffer wasn't changed since the time the display string
6320 position was cached.
551918c1 6321
b2d0c91a
EZ
63222011-07-22 Eli Zaretskii <eliz@gnu.org>
6323
6324 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
6325 is an integer, which is important for empty lines. (Bug#9149)
6326
043604ee
CY
63272011-07-22 Chong Yidong <cyd@stupidchicken.com>
6328
6329 * frame.c (Fmodify_frame_parameters): In tty case, update the
6330 default face if necessary (Bug#4238).
6331
da4adb04
CY
63322011-07-21 Chong Yidong <cyd@stupidchicken.com>
6333
6334 * editfns.c (Fstring_to_char): No need to explain what a character
6335 is in the docstring (Bug#6576).
6336
9abd0532
LMI
63372011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6338
6339 * xml.c (parse_region): Make sure we always return a tree.
6340
36881d16
HK
63412011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
6342
6343 * xml.c (parse_region): If a document contains only comments,
6344 return that, too.
6345
1e98674d
LMI
63462011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6347
6348 * xml.c (make_dom): Return comments, too.
6349
590bd467
PE
63502011-07-19 Paul Eggert <eggert@cs.ucla.edu>
6351
6352 Port to OpenBSD.
6353 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
6354 and the surrounding thread.
6355 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
6356 rather than fgets, and retry after EINTR. Otherwise, 'emacs
6357 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
6358 timer goes off.
6359 * s/openbsd.h (BROKEN_SIGIO): Define.
6360 * unexelf.c (unexec) [__OpenBSD__]:
6361 Don't update the .mdebug section of the Alpha COFF symbol table.
6362
f41628b2
LMI
63632011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6364
6365 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
6366 (bug#8460).
6367
b59b67c5
PE
63682011-07-18 Paul Eggert <eggert@cs.ucla.edu>
6369
15e3a074
PE
6370 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
6371 This fixes some race conditions on the permissions of any newly
6372 created file.
6373
41bed37d
PE
6374 * alloc.c (valid_pointer_p): Use pipe, not open.
6375 This fixes some permissions issues when debugging.
6376
b59b67c5
PE
6377 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
6378 If fchown fails to set both uid and gid, try to set just gid,
6379 as that is sometimes allowed. Adjust the file's mode to eliminate
6380 setuid or setgid bits that are inappropriate if fchown fails.
6381
925a6be7
SM
63822011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
6383
6384 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
6385 to compare Lisp_Objects.
6386 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
6387 global_gnutls_log_level, don't mistake it for a Lisp_Object.
6388 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
6389
52968808
AS
63902011-07-17 Andreas Schwab <schwab@linux-m68k.org>
6391
0a6a104b
AS
6392 * lread.c (read_integer): Unread even EOF character.
6393 (read1): Likewise. Properly record start position of symbol.
6394
52968808
AS
6395 * lread.c (read1): Read `#:' as empty uninterned symbol if no
6396 symbol character follows.
6397
9e381cdd
PE
63982011-07-17 Paul Eggert <eggert@cs.ucla.edu>
6399
6400 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
6401 This works around a problem with the previous change to Fcopy_file.
6402 Recent glibc declares fchown with __attribute__((warn_unused_result)),
6403 and without this change, GCC might complain about discarding
6404 fchown's return value.
6405
b5641435
JB
64062011-07-16 Juanma Barranquero <lekktu@gmail.com>
6407
6408 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
6409
a8031457
PE
64102011-07-16 Paul Eggert <eggert@cs.ucla.edu>
6411
6412 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
6413
dd889327
LMI
64142011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
6415
750c33f7
LMI
6416 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
6417 it's used from the C level.
6418
dd889327
LMI
6419 * process.c: Use the same condition for POLL_FOR_INPUT in both
6420 keyboard.c and process.c (bug#1858).
6421
87e86684
LM
64222011-07-09 Lawrence Mitchell <wence@gmx.li>
6423
6424 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
6425 (Fgnutls_boot): Use it.
6426
64348f40
AS
64272011-07-15 Andreas Schwab <schwab@linux-m68k.org>
6428
6429 * doc.c (Fsubstitute_command_keys): Revert last change.
6430
1d698799
LMI
64312011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
6432
f863868c
LMI
6433 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
6434 quotes the next character, and doesn't affect other longer
6435 sequences (bug#8935).
6436
1d698799
LMI
6437 * lread.c (syms_of_lread): Clarify that is isn't only
6438 `eval-buffer' and `eval-defun' that's affected by
6439 `lexical-binding' (bug#8460).
6440
aa4b6df6
EZ
64412011-07-15 Eli Zaretskii <eliz@gnu.org>
6442
6443 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 6444 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 6445
5d856da6
PE
64462011-07-14 Paul Eggert <eggert@cs.ucla.edu>
6447
ad6042bb
PE
6448 Fix minor problems found by static checking.
6449 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
6450 (elsz): Now a signed constant, not a size_t var. We prefer signed
6451 types to unsigned, to avoid integer comparison confusion. Without
6452 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
6453 "cannot optimize loop, the loop counter may overflow", a symptom
6454 of the confusion.
f00bbb22 6455 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
6456 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
6457
6468f31c
LMI
64582011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6459
49080b10
LMI
6460 * search.c (Fre_search_backward): Mention `case-fold-search' in
6461 all the re_search_* functions (bug#8138).
6462
6468f31c
LMI
6463 * keyboard.c (Fopen_dribble_file): Document when the file is
6464 closed (bug#8056).
6465
c965adc5
EZ
64662011-07-14 Eli Zaretskii <eliz@gnu.org>
6467
df9733bf
EZ
6468 * bidi.c (bidi_dump_cached_states): Fix format of displaying
6469 bidi_cache_idx.
6470
0bb23927
EZ
6471 Support bidi reordering of display and overlay strings.
6472 * xdisp.c (compute_display_string_pos)
6473 (compute_display_string_end): Accept additional argument STRING.
6474 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
6475 (reseat_to_string): Initialize bidi_it->string.s and
6476 bidi_it->string.schars.
6477 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
6478 NULL (avoids a crash in bidi_paragraph_init).
6479 Initialize itb.string.lstring.
0bb23927
EZ
6480 (init_iterator): Call bidi_init_it only of a valid
6481 buffer position was specified. Initialize paragraph_embedding to
6482 L2R.
6483 (reseat_to_string): Initialize the bidi iterator.
6484 (display_string): If we need to ignore text properties of
6485 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
6486 original value of -1 will not work with bidi.)
6487 (compute_display_string_pos): First arg is now struct
6488 `text_pos *'; all callers changed. Support display properties on
6489 Lisp strings.
6490 (compute_display_string_end): Support display properties on Lisp
6491 strings.
6492 (init_iterator, reseat_1, reseat_to_string): Initialize the
6493 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
6494 when iterating on a string not from display properties).
640c8776
SM
6495 (compute_display_string_pos, compute_display_string_end):
6496 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
6497 arrow keys.
6498 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
6499 base_level_stop; instead, set base_level_stop to BEGV.
6500 Fixes crashes in vertical-motion.
0bb23927
EZ
6501 (next_element_from_buffer): Improve commentary for when
6502 the iterator is before prev_stop.
6503 (init_iterator): Initialize bidi_p from the default value of
6504 bidi-display-reordering, not from buffer-local value. Use the
6505 buffer-local value only if initializing for buffer iteration.
6506 (handle_invisible_prop): Support invisible properties on strings
6507 that are being bidi-reordered.
6508 (set_iterator_to_next): Support bidi reordering of C strings and
6509 Lisp strings.
6510 (next_element_from_string): Support bidi reordering of Lisp
6511 strings.
6512 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
6513 (display_string): Support display of R2L glyph rows.
6514 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
6515 (init_iterator): Don't initialize it->bidi_p for strings
6516 here.
6517 (reseat_to_string): Initialize it->bidi_p for strings here.
6518 (next_element_from_string, next_element_from_c_string)
6519 (next_element_from_buffer): Add xassert's for correspondence
6520 between IT's object being iterated and it->bidi_it.string
6521 structure.
6522 (face_before_or_after_it_pos): Support bidi iteration.
6523 (next_element_from_c_string): Handle the case of the first string
6524 character that is not the first one in the visual order.
6525 (get_visually_first_element): New function, refactored from common
6526 parts of next_element_from_buffer, next_element_from_string, and
6527 next_element_from_c_string.
6528 (tool_bar_lines_needed, redisplay_tool_bar)
6529 (display_menu_bar): Force left-to-right direction. Add a FIXME
6530 comment for making that be controlled by a user option.
6531 (push_it, pop_it): Save and restore the state of the
6532 bidi iterator. Save and restore the bidi_p flag.
6533 (pop_it): Iterate out of display property for string iteration as
6534 well.
6535 (iterate_out_of_display_property): Support iteration over strings.
6536 (handle_single_display_spec): Set up it->bidi_it for iteration
6537 over a display string, and call bidi_init_it.
6538 (handle_single_display_spec, next_overlay_string)
6539 (get_overlay_strings_1, push_display_prop): Set up the bidi
6540 iterator for displaying display or overlay strings.
6541 (forward_to_next_line_start): Don't use the shortcut if
6542 bidi-iterating.
6543 (back_to_previous_visible_line_start): If handle_display_prop
6544 pushed the iterator stack, restore the internal state of the bidi
6545 iterator by calling bidi_pop_it same number of times.
6546 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
6547 and we are bidi-iterating, don't decrement the iterator position;
6548 instead, set the first_elt flag in the bidi iterator, to produce
6549 the same effect.
6550 (reseat_1): Remove redundant setting of string_from_display_prop_p.
6551 (push_display_prop): xassert that we are iterating a buffer.
6552 (push_it, pop_it): Save and restore paragraph_embedding member.
6553 (handle_single_display_spec, next_overlay_string)
6554 (get_overlay_strings_1, reseat_1, reseat_to_string)
6555 (push_display_prop): Set up the `unibyte' member of bidi_it.string
6556 correctly. Don't assume unibyte strings are not bidi-reordered.
6557 (compute_display_string_pos)
6558 (compute_display_string_end): Fix handling the case of C string.
6559 (push_it, pop_it): Save and restore from_disp_prop_p.
6560 (handle_single_display_spec, push_display_prop): Set the
6561 from_disp_prop_p flag.
6562 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
6563 (pop_it): Call iterate_out_of_display_property only if we are
6564 popping after iteration over a string that came from a display
6565 property. Fix a typo in popping stretch info. Add an assertion
6566 for verifying that the iterator position is in sync with the bidi
6567 iterator.
6568 (handle_single_display_spec, get_overlay_strings_1)
6569 (push_display_prop): Fix initialization of paragraph direction for
6570 string when that of the parent object is not yet determined.
6571 (reseat_1): Call bidi_init_it to resync the bidi
6572 iterator with IT's position. (Bug#7616)
6573 (find_row_edges): If ROW->start.pos gives position
6574 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
6575 (handle_stop, back_to_previous_visible_line_start, reseat_1):
6576 Reset the from_disp_prop_p flag.
6577 (SAVE_IT, RESTORE_IT): New macros.
6578 (pos_visible_p, face_before_or_after_it_pos)
6579 (back_to_previous_visible_line_start)
6580 (move_it_in_display_line_to, move_it_in_display_line)
6581 (move_it_to, move_it_vertically_backward, move_it_by_lines)
6582 (try_scrolling, redisplay_window, display_line): Use them when
6583 saving a temporary copy of the iterator and restoring it back.
6584 (back_to_previous_visible_line_start, reseat_1)
6585 (init_iterator): Empty the bidi cache "stack".
6586 (move_it_in_display_line_to): If iterator ended up at
6587 EOL, but we never saw any buffer positions smaller than
6588 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
6589 motion in bidi-reordered lines.
6590 (move_it_in_display_line_to): Record prev_method and prev_pos
6591 immediately before the call to set_iterator_to_next. Fixes cursor
6592 motion in bidi-reordered lines with stretch glyphs and strings
6593 displayed in margins. (Bug#8133) (Bug#8867)
6594 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
6595 TO_CHARPOS.
640c8776
SM
6596 (pos_visible_p): Support positions in bidi-reordered lines.
6597 Save and restore bidi cache.
0bb23927
EZ
6598
6599 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
6600 (bidi_paragraph_info): Delete unused struct.
6601 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
6602 (bidi_cache_start): New variable.
6603 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
6604 to zero.
6605 (bidi_cache_fetch_state, bidi_cache_search)
6606 (bidi_cache_find_level_change, bidi_cache_iterator_state)
6607 (bidi_cache_find, bidi_peek_at_next_level)
6608 (bidi_level_of_next_char, bidi_find_other_level_edge)
6609 (bidi_move_to_visually_next): Compare cache index with
6610 bidi_cache_start rather than with zero.
6611 (bidi_fetch_char): Accept new argument STRING; all callers
6612 changed. Support iteration over a string. Support strings with
6613 display properties. Support unibyte strings. Fix the type of
6614 `len' according to what STRING_CHAR_AND_LENGTH expects.
6615 (bidi_paragraph_init, bidi_resolve_explicit_1)
6616 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
6617 (bidi_level_of_next_char, bidi_move_to_visually_next):
6618 Support iteration over a string.
0bb23927
EZ
6619 (bidi_set_sor_type, bidi_resolve_explicit_1)
6620 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
6621 can now be zero (for strings); special values 0 and -1 were
6622 changed to -1 and -2, respectively.
6623 (bidi_char_at_pos): New function.
6624 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
6625 Call it instead of FETCH_MULTIBYTE_CHAR.
6626 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
6627 initialized to valid values.
6628 (bidi_init_it): Don't initialize charpos and bytepos with invalid
6629 values.
6630 (bidi_level_of_next_char): Allow the sentinel "position" to pass
6631 the test for valid cached positions. Fix the logic for looking up
6632 the sentinel state in the cache. GCPRO the Lisp string we are
6633 iterating.
6634 (bidi_push_it, bidi_pop_it): New functions.
6635 (bidi_initialize): Initialize the bidi cache start stack pointer.
6636 (bidi_cache_ensure_space): New function, refactored from part of
6637 bidi_cache_iterator_state. Don't assume the required size is just
6638 one BIDI_CACHE_CHUNK away.
6639 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
6640 (bidi_count_bytes, bidi_char_at_pos): New functions.
6641 (bidi_cache_search): Don't assume bidi_cache_last_idx is
6642 always valid if bidi_cache_idx is valid.
6643 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
6644 is valid if it's going to be used.
6645 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
6646 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
6647 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6648 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
6649 (bidi_find_other_level_edge, bidi_cache_start_stack):
6650 All variables related to cache indices are now EMACS_INT.
c965adc5 6651
0bb23927
EZ
6652 * dispextern.h (struct bidi_string_data): New structure.
6653 (struct bidi_it): New member `string'. Make flag members be 1-bit
6654 fields, and put them last in the struct.
640c8776
SM
6655 (compute_display_string_pos, compute_display_string_end):
6656 Update prototypes.
0bb23927
EZ
6657 (bidi_push_it, bidi_pop_it): Add prototypes.
6658 (struct iterator_stack_entry): New members bidi_p,
6659 paragraph_embedding, and from_disp_prop_p.
6660 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
6661 (bidi_shelve_cache, bidi_unshelve_cache):
6662 Declare prototypes.
0bb23927
EZ
6663
6664 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
6665 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
6666 and vector-like objects.
6667
6668 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
6669 cache around display iteration.
6670
6671 * window.c (Fwindow_end, window_scroll_pixel_based)
6672 (displayed_window_lines, Frecenter): Save and restore the bidi
6673 cache around display iteration.
6674
3bbd2265
LMI
66752011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6676
6677 * editfns.c (Fdelete_region): Clarify the use of the named
6678 parameters (bug#6788).
6679
adc47434
MR
66802011-07-14 Martin Rudalics <rudalics@gmx.at>
6681
6682 * indent.c (Fvertical_motion): Set and restore w->pointm when
6683 saving and restoring the window's buffer (Bug#9006).
6684
837c31f8
LMI
66852011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
6686
6687 * editfns.c (Fstring_to_char): Clarify just what is returned
6688 (bug#6576). Text by Eli Zaretskii.
6689
ac389d0c
JB
66902011-07-13 Juanma Barranquero <lekktu@gmail.com>
6691
6692 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
6693
0be0ce47
EZ
66942011-07-13 Eli Zaretskii <eliz@gnu.org>
6695
6696 * buffer.c (mmap_find): Fix a typo.
6697
cd18e7e3
JB
66982011-07-13 Johan Bockgård <bojohan@gnu.org>
6699
6700 Fix execution of x selection hooks.
6701 * xselect.c (Qx_lost_selection_functions)
6702 (Qx_sent_selection_functions): New vars.
6703 (syms_of_xselect): DEFSYM them.
6704 (x_handle_selection_request): Pass Qx_sent_selection_functions
6705 rather than Vx_sent_selection_functions to Frun_hook_with_args.
6706 (x_handle_selection_clear,x_clear_frame_selections):
6707 Pass Qx_lost_selection_functions rather than
6708 Vx_lost_selection_functions to Frun_hook_with_args.
6709
47ea7f44
PE
67102011-07-13 Paul Eggert <eggert@cs.ucla.edu>
6711
ac389d0c 6712 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
6713 The old code sometimes used this field without initializing it.
6714
47ea7f44
PE
6715 * alloc.c (gc_sweep): Don't read past end of array.
6716 In theory, the old code could also have corrupted Emacs internals,
6717 though it'd be very unlikely.
6718
bc985c87
AS
67192011-07-12 Andreas Schwab <schwab@linux-m68k.org>
6720
6721 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 6722 argument. (Bug#4026)
bc985c87 6723
0cf34688
LMI
67242011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
6725
b3dadd76
LMI
6726 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
6727 key" (bug#4257).
6728
0cf34688
LMI
6729 * window.c (Fset_window_start): Doc fix (bug#4199).
6730 (Fset_window_hscroll): Ditto.
6731
270768cd
PE
67322011-07-12 Paul Eggert <eggert@cs.ucla.edu>
6733
077e3dda 6734 Fix minor new problems caught by GCC 4.6.1.
270768cd 6735 * term.c (init_tty): Remove unused local.
490011a6 6736 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 6737 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 6738 not used otherwise.
270768cd 6739
b1f58454
CY
67402011-07-12 Chong Yidong <cyd@stupidchicken.com>
6741
6742 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
6743
22b9578d
LMI
67442011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6745
6e70ab07
LMI
6746 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
6747 are the mini-buffer and the echo area (bug#3320).
6748
22b9578d
LMI
6749 * term.c (init_tty): Remove support for supdup, c10 and perq
6750 terminals, which are no longer supported (bug#1482).
6751
8974cc9f
JB
67522011-07-10 Johan Bockgård <bojohan@gnu.org>
6753
6754 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
6755
a560d974
JD
67562011-07-10 Jan Djärv <jan.h.d@swipnet.se>
6757
6758 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
6759 for non-popups (Bug#3642).
6760
1dae0f0a
AS
67612011-07-10 Andreas Schwab <schwab@linux-m68k.org>
6762
268c2c36 6763 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 6764 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
6765 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
6766 * cm.c (losecursor): Likewise.
1dae0f0a
AS
6767 * data.c (fmod): Likewise.
6768 * dispnew.c (swap_glyphs_in_rows): Likewise.
6769 * emacs.c (memory_warning_signal): Likewise.
6770 * floatfns.c (float_error): Likewise.
6771 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
6772 (otf_open, font_otf_capability, generate_otf_features)
6773 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
6774 Likewise.
6775 * image.c (pbm_read_file): Likewise.
6776 * indent.c (string_display_width): Likewise.
6777 * intervals.c (check_for_interval, search_for_interval)
6778 (inc_interval_count, count_intervals, root_interval)
6779 (adjust_intervals_for_insertion, make_new_interval): Likewise.
6780 * lread.c (defalias): Likewise.
268c2c36 6781 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
6782 * regex.c (set_image_of_range_1, set_image_of_range)
6783 (regex_grow_registers): Likewise.
6784 * sysdep.c (strerror): Likewise.
6785 * termcap.c (valid_filename_p, tprint, main): Likewise.
6786 * tparam.c (main): Likewise.
6787 * unexhp9k800.c (run_time_remap, save_data_space)
6788 (update_file_ptrs, read_header, write_header, calculate_checksum)
6789 (copy_file, copy_rest, display_header): Likewise.
6790 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
6791 Likewise.
6792 * xdisp.c (check_it): Likewise.
6793 * xfaces.c (register_color, unregister_color, unregister_colors):
6794 Likewise.
6795 * xfns.c (print_fontset_result): Likewise.
6796 * xrdb.c (member, fatal, main): Likewise.
6797
99033785
PE
67982011-07-10 Paul Eggert <eggert@cs.ucla.edu>
6799
6800 Fix minor problems found by static checking (Bug#9031).
6801 * chartab.c (char_table_set_range, map_sub_char_table):
6802 Remove unused locals.
6803 (uniprop_table): Now static.
6804 * composite.c (_work_char): Remove unused static var.
6805
9cb2ac56
JB
68062011-07-09 Juanma Barranquero <lekktu@gmail.com>
6807
6808 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
6809
f25661f0
JD
68102011-07-09 Jan Djärv <jan.h.d@swipnet.se>
6811
6812 * gtkutil.c (qttip_cb): Remove code without function.
6813
8278c4fe
EZ
68142011-07-09 Eli Zaretskii <eliz@gnu.org>
6815
6816 * w32.c (pthread_sigmask): New stub.
6817
1692ae2d 68182011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 6819
8a6ebd58 6820 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
6821 sigprocmask is portable only for single-threaded applications, and
6822 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
6823 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
6824 (LIBES): Use it.
6825 * callproc.c (Fcall_process):
6826 * process.c (create_process):
6827 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
6828 Use pthread_sigmask, not sigprocmask.
123403e4 6829
1b854618
JD
68302011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6831
6832 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
6833 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
6834 wrong (Bug#8591).
6835
3fe4b549
JD
68362011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6837
0ce7e563
JD
6838 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
6839 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
6840 (xg_hide_tooltip): Fix comment.
6841
3fe4b549
JD
6842 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
6843 in registerServicesMenuSendTypes.
6844 (validRequestorForSendType): Don't check ns_return_types.
6845
6846 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
6847 ns_return_type.
6848
5df75e47
JR
68492011-07-08 Jason Rumney <jasonr@gnu.org>
6850
22610910
JR
6851 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
6852 SH_SHOW for hidden windows (Bug#5482).
6853
5df75e47
JR
6854 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
6855 frame struct members of non-existent frames (Bug#6284).
6856
699c10bd
JD
68572011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6858
4393663b
JD
6859 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
6860 variable firstTime not needed on OSX >= 10.6.
6861 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
6862 >= 10.5. Use setKnobProportion, setDoubleValue.
6863
6864 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
6865 (MAC_OS_X_VERSION_10_5): Define if not defined.
6866 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
6867 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
6868 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
6869
6870 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
6871 cString and lossyCString on OSX >= 10.4
6872
58179cce 6873 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
6874 sizeToFit on OSX >= 10.2.
6875
6876 * nsimage.m (allocInitFromFile): Don't use deprecated method
6877 bestRepresentationForDevice on OSX >= 10.6.
6878
6879 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
6880 to avoid warning.
6881
6882 * emacs.c: Declare unexec_init_emacs_zone.
6883
a63e0781
JD
6884 * nsgui.h: Fix compiler warning about gnulib redefining verify.
6885
699c10bd
JD
6886 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
6887
6888 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
6889 on svcsMenu (Bug#8842).
6890
6891 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
6892 ns_return_types.
6893 (Fns_list_services): Just return Qnil on 10.6, code not working there.
6894
6895 * nsterm.m (QUTF8_STRING): Declare.
6896 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
6897 (validRequestorForSendType): Return type is (id).
6898 Change indexOfObjectIdenticalTo to indexOfObject.
6899 Check if we have local selection before returning self (Bug#8842).
6900 (writeSelectionToPasteboard): Put local selection into paste board
6901 if we have a local selection (Bug#8842).
6902 (syms_of_nsterm): DEFSYM QUTF8_STRING.
6903
6904 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
6905 (ns_get_local_selection): Declare.
6906
54e10184
LMI
69072011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
6908
9888ff71
LMI
6909 * keymap.c (describe_map_tree): Don't insert a double newline at
6910 the end of the buffer (bug#1169) and return whether we inserted
6911 something.
6912
54e10184
LMI
6913 * callint.c (Fcall_interactively): Change "reading args" to
6914 "providing args" to try to clarify what it does (bug#1010).
6915
15fa4783
KH
69162011-07-07 Kenichi Handa <handa@m17n.org>
6917
6918 * composite.c (composition_compute_stop_pos): Ignore a static
6919 composition starting before CHARPOS (Bug#8915).
6920
6921 * xdisp.c (handle_composition_prop): Likewise.
6922
a8815b00
EZ
69232011-07-07 Eli Zaretskii <eliz@gnu.org>
6924
6925 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
6926 (Bug#9015)
6927
ef7b981d 69282011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
6929
6930 * character.h (unicode_category_t): New enum type.
6931
6932 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
6933 (Qchar_code_property_table): New variable.
6934 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
6935 (UNIPROP_COMPRESSED_FORM_P): New macros.
6936 (char_table_ascii): Uncompress the compressed values.
6937 (sub_char_table_ref): New arg is_uniprop. Callers changed.
6938 Uncompress the compressed values.
ac389d0c 6939 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
6940 (char_table_ref_and_range): Uncompress the compressed values.
6941 (sub_char_table_set): New arg is_uniprop. Callers changed.
6942 Uncompress the compressed values.
6943 (sub_char_table_set_range): Args changed. Callers changed.
6944 (char_table_set_range): Adjuted for the above change.
6945 (map_sub_char_table): Delete args default_val and parent. Add arg
6946 top. Give decoded values to a Lisp function.
640c8776 6947 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
6948 values to a Lisp function. Gcpro more variables.
6949 (uniprop_table_uncompress)
6950 (uniprop_decode_value_run_length): New functions.
6951 (uniprop_decoder, uniprop_decoder_count): New variables.
6952 (uniprop_get_decoder, uniprop_encode_value_character)
6953 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
6954 New functions.
6955 (uniprop_encoder, uniprop_encoder_count): New variables.
6956 (uniprop_get_encoder, uniprop_table)
6957 (Funicode_property_table_internal, Fget_unicode_property_internal)
6958 (Fput_unicode_property_internal): New functions.
6959 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
6960 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 6961 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
6962 char-code-property-alist.
6963
640c8776 6964 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
6965 Vunicode_category_table.
6966
640c8776 6967 * font.c (font_range): Adjust for the change of
c805dec0
KH
6968 Vunicode_category_table.
6969
76b397fb
DN
69702011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
6971
6972 * m/iris4d.h: Remove file, move contents ...
6973 * s/irix6-5.h: ... here.
6974
22b4128e
PE
69752011-07-06 Paul Eggert <eggert@cs.ucla.edu>
6976
6977 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
6978 * alloc.c (mark_buffer):
6979 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
6980 (clone_per_buffer_values): Don't assume that
22b4128e
PE
6981 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
6982 This isn't true in general, and it's particularly not true
6983 if Emacs is configured with --with-wide-int.
6984 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
6985 New macros, used in the buffer.c change.
6986
869795d6
JD
69872011-07-05 Jan Djärv <jan.h.d@swipnet.se>
6988
6989 * xsettings.c: Use both GConf and GSettings if both are available.
6990 (store_config_changed_event): Add comment.
6991 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
6992 (store_tool_bar_style_changed): New functions.
5e617bc2 6993 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
6994 (struct xsettings): Move font inside HAVE_XFT.
6995 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 6996 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 6997 Move inside HAVE_XFT.
640c8776 6998 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
6999 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
7000 also.
7001 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 7002 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 7003 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
7004 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
7005 (parse_settings): Move check for font inside HAVE_XFT.
7006 (read_settings, apply_xft_settings): Add comment.
7007 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
7008 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
7009 call store_font_name_changed.
7010 (xft_settings_event): Add comment.
7011 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
7012 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
7013 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
7014 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
7015 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
7016 (xsettings_get_system_font, xsettings_get_system_normal_font):
7017 Add comment.
869795d6 7018
d8ed26bd
PE
70192011-07-05 Paul Eggert <eggert@cs.ucla.edu>
7020
7021 Random fixes. E.g., (random) never returned negative values.
7022 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
7023 subseconds part to the entropy, as that's a bit more random.
7024 Prefer signed to unsigned, since the signedness doesn't matter and
7025 in general we prefer signed. When given a limit, use a
7026 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
7027 latter isn't right if USE_2_TAGS_FOR_INTS.
7028 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
7029 not 0..VALMASK. Don't discard "excess" bits that random () returns.
7030
cabf1cac
SM
70312011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
7032
7033 * textprop.c (text_property_stickiness):
7034 Obey Vtext_property_default_nonsticky.
7035 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
7036 * w32fns.c (syms_of_w32fns):
7037 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
7038
6e9b2be9
PE
70392011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7040
7041 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
7042 This is more efficient than Ffile_directory_p and avoids a minor race.
7043
90186c68
LMI
70442011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
7045
7c301272
LMI
7046 * buffer.c (Foverlay_put): Say what the return value is
7047 (bug#7835).
7048
c4f2d8d4
LMI
7049 * fileio.c (barf_or_query_if_file_exists): Check first if the file
7050 is a directory before asking whether to use the file name
7051 (bug#7564).
ad637907
LMI
7052 (barf_or_query_if_file_exists): Make the "File is a directory"
7053 error be more correct.
c4f2d8d4 7054
90186c68
LMI
7055 * fns.c (Frequire): Remove the mention of the .gz files, since
7056 that's installation-specific, but keep the mention of
7057 `get-load-suffixes'.
7058
da64016e
PE
70592011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7060
7061 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
7062 Report string overflow if the output is too long.
7063
7d47b580
JB
70642011-07-04 Juanma Barranquero <lekktu@gmail.com>
7065
a555cb87
JB
7066 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
7067 (syms_of_gnutls): Remove duplicate DEFSYM for
7068 Qgnutls_bootprop_verify_hostname_error, an error for
7069 Qgnutls_bootprop_verify_error (which is no longer used).
7070
7d47b580
JB
7071 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
7072 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
7073 Also (re)move comments that are misplaced or no longer relevant.
7074
1e49bfab
LMI
70752011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7076
7077 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
7078
1485f4c0
CY
70792011-07-03 Chong Yidong <cyd@stupidchicken.com>
7080
7081 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
7082 and background color parameters if they have been changed.
7083
a9ab721e
LMI
70842011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7085
7086 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
7087
cf7cff57
PE
70882011-07-03 Paul Eggert <eggert@cs.ucla.edu>
7089
2e13213d
PE
7090 * xsettings.c (SYSTEM_FONT): Define only when used.
7091 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
7092
cf7cff57
PE
7093 * keymap.c (access_keymap_1): Now static.
7094
7a8e04f7
CY
70952011-07-02 Chong Yidong <cyd@stupidchicken.com>
7096
7097 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
7098 leave any prefix arg for the up event (Bug#1586).
7099
61352f62
LMI
71002011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
7101
69bb1ef7
LMI
7102 * lread.c (syms_of_lread): Mention single symbols defined by
7103 `defvar' or `defconst' (bug#7154).
7104
61352f62 7105 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 7106 (Frequire): Mention get-load-suffixes.
61352f62 7107
28545e04
MR
71082011-07-02 Martin Rudalics <rudalics@gmx.at>
7109
7110 * window.h (window): Remove clone_number slot.
7111 * window.c (Fwindow_clone_number, Fset_window_clone_number):
7112 Remove.
7113 (make_parent_window, make_window, saved_window)
7114 (Fset_window_configuration, save_window_save): Don't deal with
7115 clone numbers.
7116 * buffer.c (Qclone_number): Remove declaration.
7117 (sort_overlays, overlay_strings): Don't deal with clone numbers.
7118
3349e122
SM
71192011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
7120
7121 Add multiple inheritance to keymaps.
7122 * keymap.c (Fmake_composed_keymap): New function.
7123 (Fset_keymap_parent): Simplify.
7124 (fix_submap_inheritance): Remove.
7125 (access_keymap_1): New function extracted from access_keymap to handle
7126 embedded parents and handle lists of maps.
7127 (access_keymap): Use it.
7128 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
7129 (Fcopy_keymap): Handle embedded parents.
7130 (Fcommand_remapping, define_as_prefix): Simplify.
7131 (Fkey_binding): Simplify.
7132 (syms_of_keymap): Move minibuffer-local-completion-map,
7133 minibuffer-local-filename-completion-map,
7134 minibuffer-local-must-match-map, and
7135 minibuffer-local-filename-must-match-map to Elisp.
7136 (syms_of_keymap): Defsubr make-composed-keymap.
7137 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
7138 (parse_menu_item): Trivial simplification.
7139
3279eb87
GM
71402011-07-01 Glenn Morris <rgm@gnu.org>
7141
7142 * Makefile.in (SETTINGS_LIBS): Fix typo.
7143
4550efdf
KI
71442011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
7145
7146 * coding.c (Fencode_coding_string): Record the last coding system
7147 used, as the function doc string says (bug#8738).
7148
0949d2b6
JD
71492011-07-01 Jan Djärv <jan.h.d@swipnet.se>
7150
7151 * xsettings.c (store_monospaced_changed): Take new font as arg and
7152 check for change against current_mono_font.
7153 (EMACS_TYPE_SETTINGS): Remove this and related defines.
7154 (emacs_settings_constructor, emacs_settings_get_property)
7155 (emacs_settings_set_property, emacs_settings_class_init)
7156 (emacs_settings_init, gsettings_obj): Remove.
7157 (something_changedCB): New function for HAVE_GSETTINGS.
7158 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
7159 with value as argument.
7160 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
7161 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 7162 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
7163 "changed".
7164
7165 * xgselect.c: Add defined (HAVE_GSETTINGS).
7166 (xgselect_initialize): Ditto.
7167
7168 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
7169 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
7170 xg_select.
7171
bbc6b304
PE
71722011-07-01 Paul Eggert <eggert@cs.ucla.edu>
7173
7174 * eval.c (struct backtrace): Simplify and port the data structure.
7175 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
7176 signed bit field, as this assumption is not portable and it makes
7177 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
7178 "char debug_on_exit : 1" as this is not portable either; instead,
7179 use the portable "unsigned int debug_on_exit : 1". Remove unused
7180 member evalargs. Remove obsolete comments about cc bombing out.
7181
9851bfc5
JD
71822011-06-30 Jan Djärv <jan.h.d@swipnet.se>
7183
51bb811f 7184 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
7185 Let HAVE_GSETTINGS override HAVE_GCONF.
7186 (store_monospaced_changed): New function.
7187 (EMACS_SETTINGS): A new type derived from GObject to handle
7188 GSettings notifications.
7189 (emacs_settings_constructor, emacs_settings_get_property)
7190 (emacs_settings_set_property, emacs_settings_class_init):
7191 New functions.
7192 (gsettings_client, gsettings_obj): New variables.
7193 (GSETTINGS_SCHEMA): New define.
7194 (something_changedCB): Call store_monospaced_changed.
7195 (init_gsettings): New function.
7196 (xsettings_initialize): Call init_gsettings.
7197 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
7198 to NULL.
7199
640c8776 7200 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
7201 GCONF_CFLAGS/LIBS.
7202
5386012d
MR
72032011-06-29 Martin Rudalics <rudalics@gmx.at>
7204
7205 * window.c (resize_root_window, grow_mini_window)
7206 (shrink_mini_window): Rename Qresize_root_window to
7207 Qwindow_resize_root_window and Qresize_root_window_vertically to
7208 Qwindow_resize_root_window_vertically.
7209
f13e0b08
PE
72102011-06-28 Paul Eggert <eggert@cs.ucla.edu>
7211
7212 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
7213
94515237
JB
72142011-06-27 Juanma Barranquero <lekktu@gmail.com>
7215
7216 * makefile.w32-in: Redesign dependencies so they reflect more
7217 clearly which files are directly included by each source file,
7218 and not through other includes.
7219
e43b6e43
MR
72202011-06-27 Martin Rudalics <rudalics@gmx.at>
7221
7222 * buffer.c (Qclone_number): Declare static and DEFSYM it.
7223 (sort_overlays, overlay_strings): When an overlay's clone number
7224 matches the window's clone number process the overlay even if
7225 the overlay's window property doesn't match the current window.
7226
d68443dc
MR
7227 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
7228 (Fwindow_hchild): Rename to Fwindow_left_child.
7229 (Fwindow_next): Rename to Fwindow_next_sibling.
7230 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
7231 (resize_window_check): Rename to window_resize_check.
7232 (resize_window_apply): Rename to window_resize_apply.
7233 (Fresize_window_apply): Rename to Fwindow_resize_apply.
7234 (Fdelete_other_windows_internal, resize_frame_windows)
7235 (Fsplit_window_internal, Fdelete_window_internal)
7236 (grow_mini_window, shrink_mini_window)
7237 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 7238
c7e73be5
JD
72392011-06-26 Jan Djärv <jan.h.d@swipnet.se>
7240
7241 * emacsgtkfixed.h: State that this is only used with Gtk+3.
7242 (emacs_fixed_set_min_size): Remove.
7243 (emacs_fixed_new): Take frame as argument.
7244
7245 * emacsgtkfixed.c: State that this is only used with Gtk+3.
7246 (_EmacsFixedPrivate): Remove minwidth/height.
7247 Add struct frame *f.
7248 (emacs_fixed_init): Initialize priv->f.
7249 (get_parent_class, emacs_fixed_set_min_size): Remove.
7250 (emacs_fixed_new): Set priv->f to argument.
7251 (emacs_fixed_get_preferred_width)
7252 (emacs_fixed_get_preferred_height): Use min_width/height from
7253 frames size_hint to set minimum and natural (Bug#8919).
7254 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
7255 and use min_width/height from frames size_hint to set
7256 min_width/height (Bug#8919).
7257
7258 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
7259 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
7260 Fix indentation.
c7e73be5 7261
cf99dcf8
EZ
72622011-06-26 Eli Zaretskii <eliz@gnu.org>
7263
7264 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
7265 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
7266 called at ZV.
7267
029529ac
CY
72682011-06-26 Chong Yidong <cyd@stupidchicken.com>
7269
7270 * process.c (wait_reading_process_output): Bypass select if
7271 waiting for a cell while ignoring keyboard input, and input is
7272 pending. Suggested by Jan Djärv (Bug#8869).
7273
7a7ef429
PE
72742011-06-25 Paul Eggert <eggert@cs.ucla.edu>
7275
7276 Use gnulib's dup2 module instead of rolling our own.
7277 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
7278
11fdef7d 72792011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
7280
7281 * dispnew.c (scrolling_window): Before scrolling, turn off a
7282 mouse-highlight in the window being scrolled.
7283
cd3520a4
JB
72842011-06-24 Juanma Barranquero <lekktu@gmail.com>
7285
7286 Move DEFSYM to lisp.h and use everywhere.
7287
7288 * character.h (DEFSYM): Move declaration...
7289 * lisp.h (DEFSYM): ...here.
7290
7291 * gnutls.c:
7292 * minibuf.c:
7293 * w32menu.c:
7294 * w32proc.c:
7295 * w32select.c: Don't include character.h.
7296
7297 * alloc.c (syms_of_alloc):
7298 * buffer.c (syms_of_buffer):
7299 * bytecode.c (syms_of_bytecode):
7300 * callint.c (syms_of_callint):
7301 * casefiddle.c (syms_of_casefiddle):
7302 * casetab.c (init_casetab_once):
7303 * category.c (init_category_once, syms_of_category):
7304 * ccl.c (syms_of_ccl):
7305 * cmds.c (syms_of_cmds):
7306 * composite.c (syms_of_composite):
7307 * dbusbind.c (syms_of_dbusbind):
7308 * dired.c (syms_of_dired):
7309 * dispnew.c (syms_of_display):
7310 * doc.c (syms_of_doc):
7311 * editfns.c (syms_of_editfns):
7312 * emacs.c (syms_of_emacs):
7313 * eval.c (syms_of_eval):
7314 * fileio.c (syms_of_fileio):
7315 * fns.c (syms_of_fns):
7316 * frame.c (syms_of_frame):
7317 * fringe.c (syms_of_fringe):
7318 * insdel.c (syms_of_insdel):
7319 * keymap.c (syms_of_keymap):
7320 * lread.c (init_obarray, syms_of_lread):
7321 * macros.c (syms_of_macros):
7322 * msdos.c (syms_of_msdos):
7323 * print.c (syms_of_print):
7324 * process.c (syms_of_process):
7325 * search.c (syms_of_search):
7326 * sound.c (syms_of_sound):
7327 * syntax.c (init_syntax_once, syms_of_syntax):
7328 * terminal.c (syms_of_terminal):
7329 * textprop.c (syms_of_textprop):
7330 * undo.c (syms_of_undo):
7331 * w32.c (globals_of_w32):
7332 * window.c (syms_of_window):
7333 * xdisp.c (syms_of_xdisp):
7334 * xfaces.c (syms_of_xfaces):
7335 * xfns.c (syms_of_xfns):
7336 * xmenu.c (syms_of_xmenu):
7337 * xsettings.c (syms_of_xsettings):
7338 * xterm.c (syms_of_xterm): Use DEFSYM.
7339
4228cf16
TZ
73402011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
7341
cd3520a4 7342 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 7343
7fcccf1e
PE
73442011-06-23 Paul Eggert <eggert@cs.ucla.edu>
7345
7efb4e0e
PE
7346 Integer and buffer overflow fixes (Bug#8873).
7347
ff5844ad
PE
7348 * print.c (printchar, strout): Check for string overflow.
7349 (PRINTPREPARE, printchar, strout):
7350 Don't set size unless allocation succeeds.
7351
90532f02
PE
7352 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
7353 for sizes. Check for string overflow more accurately.
7354 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
7355
6d84508d
PE
7356 * macros.c: Integer and buffer overflow fixes.
7357 * keyboard.h (struct keyboard.kbd_macro_bufsize):
7358 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
7359 Use ptrdiff_t, not int, for sizes.
7360 Don't increment bufsize until after realloc succeeds.
7361 Check for size-calculation overflow.
7362 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
7363
437b2cb4
PE
7364 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
7365
8b9ac8b4
PE
7366 * lread.c: Integer overflow fixes.
7367 (read_integer): Radix is now EMACS_INT, not int,
7368 to improve quality of diagnostics for out-of-range radices.
7369 Calculate buffer size correctly for out-of-range radices.
7370 (read1): Check for integer overflow in radices, and in
7371 read-circle numbers.
82cb60d3
PE
7372 (read_escape): Avoid int overflow.
7373 (Fload, openp, read_buffer_size, read1)
7374 (substitute_object_recurse, read_vector, read_list, map_obarray):
7375 Use ptrdiff_t, not int, for sizes.
7376 (read1): Use EMACS_INT, not int, for sizes.
20270765 7377 Check for size overflow.
8b9ac8b4 7378
7fcccf1e
PE
7379 * image.c (cache_image): Check for size arithmetic overflow.
7380
bfbbd7e7
PE
7381 * lread.c: Integer overflow issues.
7382 (saved_doc_string_size, saved_doc_string_length)
7383 (prev_saved_doc_string_size, prev_saved_doc_string_length):
7384 Now ptrdiff_t, not int.
7385 (read1): Don't assume doc string length fits in int. Check for
7386 out-of-range doc string lengths.
7387 (read_list): Don't assume file position fits in int.
39019e54 7388 (read_escape): Check for hex character overflow.
bfbbd7e7 7389
4e323265
LL
73902011-06-22 Leo Liu <sdl.web@gmail.com>
7391
7392 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
7393 Move to minibuffer.el.
7394
85fece3e
PE
73952011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7396
20b84ce9 7397 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
7398 The following patches are for when GLYPH_DEBUG && !XASSERT.
7399 * dispextern.h (trace_redisplay_p, dump_glyph_string):
7400 * dispnew.c (flush_stdout):
7401 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
7402 Mark as externally visible.
7403 * dispnew.c (check_window_matrix_pointers): Now static.
7404 * dispnew.c (window_to_frame_vpos):
7405 * xfns.c (unwind_create_frame):
7406 * xterm.c (x_check_font): Remove unused local.
7407 * scroll.c (CHECK_BOUNDS):
7408 * xfaces.c (cache_fache): Rename local to avoid shadowing.
7409 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
7410 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
7411 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
7412 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
7413 Now static.
7414 (debug_method_add): Use va_list and vsprintf rather than relying
7415 on undefined behavior with wrong number of arguments.
7416 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
7417 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
7418 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
7419 since we're not interested in debugging glyphs with old libraries.
7420 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
7421 GCC 4.6.0's static checking.
7422
0766b489
PE
74232011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7424
31fd4b32
PE
7425 Integer overflow and signedness fixes (Bug#8873).
7426 A few related buffer overrun fixes, too.
7427
b79e8648
PE
7428 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
7429
0766b489
PE
7430 * dispextern.h (struct face.stipple):
7431 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
7432 (x_bitmap_mask, x_allocate_bitmap_record)
7433 (x_create_bitmap_from_data, x_create_bitmap_from_file)
7434 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
7435 (x_create_bitmap_from_xpm_data):
7436 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
7437 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
7438 (.bitmaps_last):
7439 * xfaces.c (load_pixmap):
7440 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
7441 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
7442 (.bitmaps_last, struct x_output.icon_bitmap):
7443 Use ptrdiff_t, not int, for bitmap indexes.
7444 (x_allocate_bitmap_record): Check for size overflow.
7445 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
7446
b081724f
PE
7447 Use ptrdiff_t, not int, for overlay counts.
7448 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
7449 * editfns.c (overlays_around, get_pos_property):
7450 * textprop.c (get_char_property_and_overlay):
7451 * xdisp.c (next_overlay_change, note_mouse_highlight):
7452 * xfaces.c (face_at_buffer_position):
21514da7
PE
7453 * buffer.c (OVERLAY_COUNT_MAX): New macro.
7454 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
7455 (Fnext_overlay_change, Fprevious_overlay_change)
7456 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 7457 Use ptrdiff_t, not int, for sizes.
21514da7 7458 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 7459
3de73e5e
PE
7460 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
7461
2606c57b
PE
7462 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
7463 (x_session_initialize): Do not assume string length fits in int.
7464
aaafe47a
PE
7465 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
7466 This is unlikely, but can occur if DPI is outlandish.
7467
2674ddc8 7468 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
7469 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
7470
28154962
PE
7471 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
7472 * xrdb.c (magic_file_p, search_magic_path):
7473 Omit last arg SUFFIX; it was always 0. All callers changed.
7474 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
7475
7de51af5
PE
7476 * xfont.c (xfont_match): Avoid need for strlen.
7477
25ed6cc3
PE
7478 * xfns.c: Don't assume strlen fits in int.
7479 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
7480
4eab31dd
PE
7481 * xdisp.c (message_log_check_duplicate): Return intmax_t,
7482 not unsigned long, as we prefer signed integers. All callers changed.
7483 Detect integer overflow in repeat count.
7484 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 7485 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 7486
171e2a58
PE
7487 * termcap.c: Don't assume sizes fit in int and never overflow.
7488 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
7489 (gobble_line): Check for size-calculation overflow.
7490
ad39faca 7491 * minibuf.c (Fread_buffer):
6e5bb2dc 7492 * lread.c (intern, intern_c_string):
74ca2eb3
PE
7493 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
7494 Don't assume string length fits in int.
7495
52c61c22 7496 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
7497 * gtkutil.c (style_changed_cb): Avoid need for strlen.
7498
b5b8c9e5
PE
7499 * font.c: Don't assume string length fits in int.
7500 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
7501 Use ptrdiff_t, not int.
ccd6111c
PE
7502 (font_intern_prop): Don't assume string length fits in int.
7503 Don't assume integer property fits in fixnum.
7504 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 7505
882f0d81 7506 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 7507 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
7508 Reformulate so as not to need the command string.
7509 Invoke gzip -cd rather than gunzip, as it's more portable.
7510 (lock_info_type, lock_file_1, lock_file):
7511 Don't assume pid_t and time_t fit in unsigned long.
7512 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
7513 (current_lock_owner): Prefer signed type for sizes.
7514 Use memcpy, not strncpy, where memcpy is what is really wanted.
7515 Don't assume (via atoi) that time_t and pid_t fit in int.
7516 Check for time_t and/or pid_t out of range, e.g., via a network share.
7517 Don't alloca where an auto var works fine.
7518
93f4cf88
PE
7519 * fileio.c: Fix some integer overflow issues.
7520 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
7521 Don't assume string length fits in int.
7522 (directory_file_name): Don't assume string length fits in long.
7523 (make_temp_name): Don't assume pid fits in int, or that its print
7524 length is less than 20.
7525
f3e92b69
PE
7526 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
7527
1bfdaf10
PE
7528 * coding.c (make_subsidiaries): Don't assume string length fits in int.
7529
35016e9a
PE
7530 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
7531
3d1e65a1
PE
7532 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
7533 We prefer signed integers, even for size calculations.
7534
0b963a93
PE
7535 * emacs.c: Don't assume string length fits in 'int'.
7536 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
7537 (main): Don't invoke strlen when not needed.
7538
573f4b54
PE
7539 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
7540 (XD_DEBUG_MESSAGE): Don't waste a byte.
7541
989f33ba
PE
7542 * callproc.c (getenv_internal_1, getenv_internal)
7543 (Fgetenv_internal):
965d34eb
PE
7544 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
7545
e4d29b33
PE
7546 * lread.c (invalid_syntax): Omit length argument.
7547 All uses changed. This doesn't fix a bug, but it simplifies the
7548 code away from its former Hollerith-constant appearance, and it's
7549 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 7550 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 7551
eb49b136
PE
7552 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
7553 This didn't break anything, but it didn't help either.
7554 It's confusing to put a bogus integer in a place where the actual
7555 value does not matter.
9f62aeb1 7556 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 7557 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 7558
15375a22
PE
7559 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
7560 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
7561 implementation.
b61cc01c
PE
7562 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
7563 We prefer signed types, and the value cannot exceed the EMACS_INT
7564 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
7565 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
7566 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
7567 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 7568
53b2623d
PE
7569 * indent.c (sane_tab_width): New function.
7570 (current_column, scan_for_column, Findent_to, position_indentation)
7571 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 7572 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 7573
51cab52b 7574 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 7575
f2ed8a70
PE
7576 * lisp.h (lint_assume): New macro.
7577 * composite.c (composition_gstring_put_cache):
7578 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
7579
abe80cc6
PE
7580 * editfns.c, insdel.c:
7581 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 7582
b02c740e
PE
7583 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
7584
ebc96716
PE
7585 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
7586
b4e50fa0 7587 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 7588 Use much-faster test for byte-length change.
311d5d7c 7589 Don't assume string byte-length fits in 'int'.
a4cf38e4 7590 Check that character arg fits in 'int'.
85461888 7591 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 7592
c0c1ee9f
PE
7593 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
7594
a498d7f4
PE
7595 * fns.c (concat): Catch string overflow earlier.
7596 Do not rely on integer wraparound.
7597
51cab52b
PE
7598 * dispextern.h (struct it.overlay_strings_charpos)
7599 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
7600 * xdisp.c (forward_to_next_line_start)
7601 (back_to_previous_visible_line_start)
7602 (reseat_at_next_visible_line_start, next_element_from_buffer):
7603 Don't arbitrarily truncate the value of 'selective' to int.
7604
76031fad
PE
7605 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
7606
5eb55db9
PE
7607 * composite.c: Don't truncate sizes to 'int'.
7608 (composition_gstring_p, composition_reseat_it)
7609 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
7610 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
7611 not EMACS_UINT, for indexes.
5eb55db9 7612
0703a717
PE
7613 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
7614
d6202519
PE
7615 * buffer.c: Include <verify.h>.
7616 (struct sortvec.priority, struct sortstr.priority):
8961a454 7617 Now EMACS_INT, not int.
c20998a7 7618 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
7619 (struct sortstr.size, record_overlay_string)
7620 (struct sortstrlist.size, struct sortlist.used):
7621 Don't truncate size to int.
7622 (record_overlay_string): Check for size-calculation overflow.
d6202519 7623 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 7624
d5a19415
JM
76252011-06-22 Jim Meyering <meyering@redhat.com>
7626
029529ac 7627 Don't leak an XBM-image-sized buffer
d5a19415
JM
7628 * image.c (xbm_load): Free the image buffer after using it.
7629
a9041e6c
PE
76302011-06-21 Paul Eggert <eggert@cs.ucla.edu>
7631
7632 Port to Sun C.
7633 * composite.c (find_automatic_composition): Omit needless 'return 0;'
7634 that Sun C diagnosed.
7635 * fns.c (secure_hash): Fix pointer signedness issue.
7636 * intervals.c (static_offset_intervals): New function.
7637 (offset_intervals): Use it.
7638
7f3f739f
LL
76392011-06-21 Leo Liu <sdl.web@gmail.com>
7640
7641 * deps.mk (fns.o):
7642 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
7643 sha512.h.
7644
7645 * fns.c (secure_hash): Rename from crypto_hash_function and change
7646 the first arg to accept symbols.
5b66d427 7647 (Fsecure_hash): New primitive.
7f3f739f
LL
7648 (syms_of_fns): New symbols.
7649
76147d94
DD
76502011-06-20 Deniz Dogan <deniz@dogan.se>
7651
7652 * process.c (Fset_process_buffer): Clarify return value in
7653 docstring.
7654
7d7d0045
CY
76552011-06-18 Chong Yidong <cyd@stupidchicken.com>
7656
7657 * dispnew.c (add_window_display_history): Use BVAR.
7658
7659 * xdisp.c (debug_method_add): Use BVAR.
7660 (check_window_end, dump_glyph_matrix, dump_glyph)
7661 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
7662
7663 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
7664 Likewise.
7665
7666 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
7667 check till after the cache is created in init_frame_faces.
7668
ff2bc410
SM
76692011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
7670
7671 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
7672
28177add
PE
76732011-06-16 Paul Eggert <eggert@cs.ucla.edu>
7674
dd3482fe
PE
7675 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
7676 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
7677 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
7678
393d71f3 7679 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
7680 * fileio.c (Finsert_file_contents):
7681 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
7682 Remove the old (too-loose) buffer overflow checks.
7683 They weren't needed, since make_gap checks for buffer overflow.
7684 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
7685 The old code merely checked for Emacs fixnum overflow, and relied
7686 on undefined (wraparound) behavior. The new code avoids undefined
7687 behavior, and also checks for ptrdiff_t and/or size_t overflow.
7688
2e6813b0 7689 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
7690 Tune. Don't use wider integers than needed. Don't use alloca.
7691 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 7692
599a9e4f
PE
7693 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
7694
99561444
PE
7695 * insdel.c, lisp.h (buffer_overflow): New function.
7696 (insert_from_buffer_1, replace_range, replace_range_2):
7697 * insdel.c (make_gap_larger):
7698 * editfns.c (Finsert_char):
7699 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
7700
28177add
PE
7701 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
7702
e69dafad
PE
77032011-06-15 Paul Eggert <eggert@cs.ucla.edu>
7704
4baa020d 7705 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 7706
b1c46f02
PE
7707 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
7708 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
7709
e69dafad
PE
7710 * fileio.c: Don't assume EMACS_INT fits in off_t.
7711 (emacs_lseek): New static function.
7712 (Finsert_file_contents, Fwrite_region): Use it.
7713 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
7714
566684ea
PE
7715 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
7716
e6966cd6
PE
7717 * fns.c: Don't overflow int when computing a list length.
7718 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
7719 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
7720 truncation on 64-bit hosts. Check for QUIT every
7721 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
7722 faster and is responsive enough.
7723 (Flength): Report an error instead of overflowing an integer.
7724 (Fsafe_length): Return a float if the value is not representable
7725 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 7726 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 7727 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 7728
dd0b0efb
PE
7729 * alloc.c: Check that resized vectors' lengths fit in fixnums.
7730 (header_size, word_size): New constants.
7731 (allocate_vectorlike): Don't check size overflow here.
7732 (allocate_vector): Check it here instead, since this is the only
7733 caller of allocate_vectorlike that could cause overflow.
7734 Check that the new vector's length is representable as a fixnum.
7735
86fe5cfe
PE
7736 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
7737 The previous code was bogus. For example, next_almost_prime (32)
7738 returned 39, which is undesirable as it is a multiple of 3; and
7739 next_almost_prime (24) returned 25, which is a multiple of 5 so
7740 why was the code bothering to check for multiples of 7?
7741
80e88859
PE
7742 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
7743
4a2f0ad6
PE
7744 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
7745
f66c7cf8
PE
7746 Variadic C functions now count arguments with ptrdiff_t.
7747 This partly undoes my 2011-03-30 change, which replaced int with size_t.
7748 Back then I didn't know that the Emacs coding style prefers signed int.
7749 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
7750 were being counted with int, which may truncate counts on 64-bit
7751 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
7752 * lisp.h (struct Lisp_Subr.function.aMANY)
7753 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
7754 Arg counts are now ptrdiff_t, not size_t.
7755 All variadic functions and their callers changed accordingly.
7756 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
7757 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
7758 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
7759 * callint.c (Fcall_interactively): Check arg count for overflow,
7760 to avoid potential buffer overrun. Use signed char, not 'int',
7761 for 'varies' array, so that we needn't bother to check its size
7762 calculation for overflow.
7763 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
7764 * eval.c (apply_lambda):
7765 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
7766 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
7767 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
7768
a1759b76
PE
7769 * callint.c (Fcall_interactively): Don't use index var as event count.
7770
d96be9fc
PE
7771 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
7772 * mem-limits.h (SIZE): Remove; no longer used.
7773
a690a978 7774 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 7775
578c21e6
PE
7776 Remove unnecessary casts.
7777 * xterm.c (x_term_init):
7778 * xfns.c (x_set_border_pixel):
7779 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
7780 These aren't needed now that we assume ANSI C.
7781
96f53c6c
PE
7782 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
7783 It's more likely to cause problems (due to unsigned overflow)
7784 than to cure them.
7785
83c77d31
PE
7786 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
7787
ee2079f1
PE
7788 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
7789
6da65536
PE
7790 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
7791
7147c4a4
PE
7792 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
7793
193e32d9
PE
7794 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
7795
e5533da6
PE
7796 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
7797
9910e595
PE
7798 GLYPH_CODE_FACE returns EMACS_INT, not int.
7799 * dispextern.h (merge_faces):
7800 * xfaces.c (merge_faces):
01103c44
PE
7801 * xdisp.c (get_next_display_element, next_element_from_display_vector):
7802 Don't assume EMACS_INT fits in int.
9910e595 7803
2638320e
PE
7804 * character.h (CHAR_VALID_P): Remove unused parameter.
7805 * fontset.c, lisp.h, xdisp.c: All uses changed.
7806
045eb8d9
PE
7807 * editfns.c (Ftranslate_region_internal): Omit redundant test.
7808
c1f134b5
PE
7809 * fns.c (concat): Minor tuning based on overflow analysis.
7810 This doesn't fix any bugs. Use int to hold character, instead
7811 of constantly refetching from Emacs object. Use XFASTINT, not
7812 XINT, for value known to be a character. Don't bother comparing
7813 a single byte to 0400, as it's always less.
7814
395fcb93 7815 * floatfns.c (Fexpt):
327eeec8
PE
7816 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
7817
abbd3d23
PE
7818 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
7819 for characters.
7820
684a03ef
PE
7821 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
7822
0fed43f3
PE
7823 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
7824 Without this fix, on a 64-bit host (aset S 0 4294967386) would
7825 incorrectly succeed when S was a string, because 4294967386 was
7826 truncated before it was used.
7827
8fd02eb7
PE
7828 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
7829 Otherwise, an out-of-range integer could cause undefined behavior
7830 on a 64-bit host.
7831
f8c86b69
PE
7832 * composite.c: Use int, not EMACS_INT, for characters.
7833 (fill_gstring_body, composition_compute_stop_pos): Use int, not
7834 EMACS_INT, for values that are known to be in character range.
7835 This doesn't fix any bugs but is the usual style inside Emacs and
7836 may generate better code on 32-bit machines.
7837
34206dd2
PE
7838 Make sure a 64-bit char is never passed to ENCODE_CHAR.
7839 This is for reasons similar to the recent CHAR_STRING fix.
7840 * charset.c (Fencode_char): Check that character arg is actually
7841 a character. Pass an int to ENCODE_CHAR.
7842 * charset.h (ENCODE_CHAR): Verify that the character argument is no
7843 wider than 'int', as a compile-time check to prevent future regressions
7844 in this area.
7845
c5958d4c 7846 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
7847
7848 Make sure a 64-bit char is never passed to CHAR_STRING.
7849 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
7850 by silently ignoring the top 32 bits, allowing some values
7851 that were far too large to be valid characters.
7852 * character.h: Include <verify.h>.
7853 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
7854 arguments are no wider than unsigned, as a compile-time check
7855 to prevent future regressions in this area.
7856 * data.c (Faset):
01103c44 7857 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
7858 (Fsubst_char_in_region):
7859 * fns.c (concat):
7860 * xdisp.c (decode_mode_spec_coding):
7861 Adjust to CHAR_STRING's new requirement.
7862 * editfns.c (Finsert_char, Fsubst_char_in_region):
7863 * fns.c (concat): Check that character args are actually
7864 characters. Without this test, these functions did the wrong
7865 thing with wildly out-of-range values on 64-bit hosts.
7866
d37ca623
PE
7867 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
7868 These casts should not be needed on 32-bit hosts, either.
7869 * keyboard.c (read_char):
7870 * lread.c (Fload): Remove casts to unsigned.
7871
ea204efb
PE
7872 * lisp.h (UNSIGNED_CMP): New macro.
7873 This fixes comparison bugs on 64-bit hosts.
7874 (ASCII_CHAR_P): Use it.
7875 * casefiddle.c (casify_object):
01103c44 7876 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
7877 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
7878 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
7879 * dispextern.h (FACE_FROM_ID):
7880 * keyboard.c (read_char): Use UNSIGNED_CMP.
7881
41cb286c
PE
7882 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
7883 not to EMACS_INT, to avoid GCC warning.
7884
4a1b9832
PE
7885 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
7886
55daad71
PE
7887 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
7888 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
7889 isn't needed on 32-bit machines.
8f95c75c 7890
01103c44
PE
7891 * buffer.c (Fgenerate_new_buffer_name):
7892 Use EMACS_INT for count, not int.
0ceccced 7893 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
7894
7895 * data.c (Qcompiled_function): Now static.
7896
c6f072e7
PE
7897 * window.c (window_body_lines): Now static.
7898
20ce5912
PE
7899 * image.c (gif_load): Rename local to avoid shadowing.
7900
9c4c5f81
PE
7901 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
7902 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
7903 * alloc.c (make_save_value): Integer argument is now of type
7904 ptrdiff_t, not int.
7905 (mark_object): Use ptrdiff_t, not int.
7906 * lisp.h (pD): New macro.
7907 * print.c (print_object): Use it.
7908
c0c5c8ae
PE
7909 * alloc.c: Use EMACS_INT, not int, to count objects.
7910 (total_conses, total_markers, total_symbols, total_vector_size)
7911 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
7912 (total_free_floats, total_floats, total_free_intervals)
7913 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
7914 Now EMACS_INT, not int. All uses changed.
7915 (Fgarbage_collect): Compute overall total using a double, so that
7916 integer overflow is less likely to be a problem. Check for overflow
7917 when converting back to an integer.
5a25e253
PE
7918 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
7919 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
7920 These were 'int' variables that could overflow on 64-bit hosts;
7921 they were never used, so remove them instead of repairing them.
211a0b2a 7922 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
7923 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
7924 Previously, this ceilinged at INT_MAX, but that doesn't work on
7925 64-bit machines.
e46bb31a 7926 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 7927
c78baabf 7928 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 7929 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
7930 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
7931 when a (possibly-narrower) signed value would do just as well.
7932 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 7933
c9d624c6
PE
7934 * alloc.c: Catch some string size overflows that we were missing.
7935 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
7936 for convenience in STRING_BYTES_MAX.
7937 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
7938 The definition here is exact; the one in lisp.h was approximate.
7939 (allocate_string_data): Check for string overflow. This catches
7940 some instances we weren't catching before. Also, it catches
7941 size_t overflow on (unusual) hosts where SIZE_MAX <= min
7942 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
7943 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 7944
c9d624c6
PE
7945 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
7946 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 7947 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 7948
353032ce
PE
7949 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
7950
2bccce07
PE
7951 * alloc.c (Fmake_string): Check for out-of-range init.
7952
0ac30604
SM
79532011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
7954
7955 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
7956
c195f2de
JD
79572011-06-14 Jan Djärv <jan.h.d@swipnet.se>
7958
7959 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
7960 xg_get_default_scrollbar_width.
7961
7962 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
7963 (int_gtk_range_get_value): Move to the scroll bar part of the file.
7964 (style_changed_cb): Call update_theme_scrollbar_width and call
7965 x_set_scroll_bar_default_width and xg_frame_set_char_size for
7966 all frames (Bug#8505).
7967 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
7968 Call gtk_window_set_resizable if HAVE_GTK3.
7969 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
7970 and height if HAVE_GTK3 (Bug#8505).
7971 (scroll_bar_width_for_theme): New variable.
7972 (update_theme_scrollbar_width): New function.
7973 (xg_get_default_scrollbar_width): Move code to
7974 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
7975 (xg_initialize): Call update_theme_scrollbar_width.
7976
7977 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
7978
7979 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
7980
e10ac9f1
MR
79812011-06-12 Martin Rudalics <rudalics@gmx.at>
7982
7983 * frame.c (make_frame): Call other_buffer_safely instead of
7984 other_buffer.
7985
7986 * window.c (temp_output_buffer_show): Call display_buffer with
7987 second argument Vtemp_buffer_show_specifiers and reset latter
7988 immediately after the call.
7989 (Vtemp_buffer_show_specifiers): New variable.
7990 (auto_window_vscroll_p, next_screen_context_lines)
7991 (Vscroll_preserve_screen_position): Remove leading asterisks from
7992 doc-strings.
7993
2d3c217e 79942011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 7995
7b7f97e8 7996 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
7997 * buffer.c (Qclone_number): Remove for now, as it's unused.
7998 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
7999 (record_buffer): Remove unused local.
8000 * frame.c (other_visible_frames, frame_buffer_list): Now static.
8001 (set_frame_buffer_list): Remove; unused.
8002 * frame.h (other_visible_frames): Remove decl.
8003 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
8004 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
8005 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
8006 if HAVE_GPM.
8007 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
8008 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
8009 Define only if HAVE_GPM.
8010 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
8011 (update_hints_inhibit): Remove; never set. All uses removed.
8012 * widgetprv.h (emacsFrameClassRec): Remove decl.
8013 * window.c (delete_deletable_window): Now returns void, since it
8014 wasn't returning anything.
8015 (compare_window_configurations): Remove unused locals.
8016 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
8017 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
8018 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
8019 the same widths as pointers. This follows up on the 2011-05-06 patch.
8020 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
8021 * xterm.h: Likewise.
8022 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
8023
1384b89e
JB
80242011-06-12 Juanma Barranquero <lekktu@gmail.com>
8025
8026 * makefile.w32-in: Update dependencies.
8027 (LISP_H): Add lib/intprops.h.
8028
1100a63c
CY
80292011-06-11 Chong Yidong <cyd@stupidchicken.com>
8030
8031 * image.c (gif_load): Add animation frame delay to the metadata.
8032 (syms_of_image): Use DEFSYM. New symbol `delay'.
8033
6198ccd0
MR
80342011-06-11 Martin Rudalics <rudalics@gmx.at>
8035
8036 * window.c (delete_deletable_window): Re-add.
8037 (Fset_window_configuration): Rewrite to handle dead buffers and
8038 consequently deletable windows.
8039 (window_tree, Fwindow_tree): Remove. Supply functionality in
8040 window.el.
8041 (compare_window_configurations): Simplify code.
8042
b6e3633c
AS
80432011-06-11 Andreas Schwab <schwab@linux-m68k.org>
8044
1ab0dee5
AS
8045 * image.c (imagemagick_load_image): Fix type mismatch.
8046 (Fimagemagick_types): Likewise.
8047
b6e3633c
AS
8048 * window.h (replace_buffer_in_windows): Declare.
8049
9397e56f
MR
80502011-06-11 Martin Rudalics <rudalics@gmx.at>
8051
8052 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
8053 Qclone_number. Remove external declaration of Qdelete_window.
8054 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
8055 code.
640c8776
SM
8056 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
8057 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
8058 (Fother_buffer): Rewrite doc-string. Major rewrite for new
8059 buffer list implementation.
8060 (other_buffer_safely): New function.
8061 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
8062 calls to replace_buffer_in_windows and
8063 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
8064 if allowed.
8065 (record_buffer): Inhibit quitting and rewrite using quittable
8066 functions. Run Qbuffer_list_update_hook if allowed.
8067 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
8068 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
8069 Move switch-to-buffer to window.el.
9397e56f
MR
8070 (bury-buffer): Move to window.el.
8071 (Vbuffer_list_update_hook): New variable.
8072
8073 * lisp.h (other_buffer_safely): Add prototype in buffer.c
8074 section.
8075
8076 * window.h (resize_frame_windows): Move up in code.
8077 (Fwindow_frame): Remove EXFUN.
8078 (replace_buffer_in_all_windows): Remove prototype.
8079 (replace_buffer_in_windows_safely): Add prototype.
8080
8081 * window.c: Declare Qdelete_window static again. Move down
8082 declaration of select_count.
8083 (Fnext_window, Fprevious_window): Rewrite doc-strings.
8084 (Fother_window): Move to window.el.
8085 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
8086 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
8087 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
8088 window.el.
8089 (replace_buffer_in_windows): Implement by calling
8090 Qreplace_buffer_in_windows.
8091 (replace_buffer_in_all_windows): Remove with some functionality
8092 moved into replace_buffer_in_windows_safely.
8093 (replace_buffer_in_windows_safely): New function.
8094 (select_window_norecord, select_frame_norecord): Move in front
8095 of run_window_configuration_change_hook. Remove now obsolete
8096 declarations.
640c8776
SM
8097 (Fset_window_buffer): Rewrite doc-string.
8098 Call Qrecord_window_buffer.
9397e56f
MR
8099 (keys_of_window): Move binding for other-window to window.el.
8100
b50691aa
CY
81012011-06-11 Chong Yidong <cyd@stupidchicken.com>
8102
8103 * dispextern.h (struct image): Replace data member, whose int_val
8104 and ptr_val fields were not used by anything, with a single
8105 lisp_val object.
8106
8107 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
8108 (gif_clear_image, gif_load, imagemagick_load_image)
8109 (gs_clear_image, gs_load): Callers changed.
8110
3f754b86
PE
81112011-06-10 Paul Eggert <eggert@cs.ucla.edu>
8112
cca69397
PE
8113 * buffer.h: Include <time.h>, for time_t.
8114 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
8115
109e28d0
PE
8116 Fix minor problems found by static checking.
8117
60737f02
PE
8118 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
8119
4b66faf3
PE
8120 Make identifiers static if they are not used in other modules.
8121 * data.c (Qcompiled_function, Qframe, Qvector):
8122 * image.c (QimageMagick, Qsvg):
8123 * minibuf.c (Qmetadata):
8124 * window.c (resize_window_check, resize_root_window): Now static.
8125 * window.h (resize_window_check, resize_root_window): Remove decls.
8126
109e28d0
PE
8127 * window.c (window_deletion_count, delete_deletable_window):
8128 Remove; unused.
46a4ce9e
PE
8129 (window_body_lines): Now static.
8130 (Fdelete_other_windows_internal): Mark vars as initialized.
8131 Make sure 'resize_failed' is initialized.
8132 (run_window_configuration_change_hook): Rename local to avoid shadowing.
8133 (resize_window_apply): Remove unused local.
8134 * window.h (delete_deletable_window): Remove decl.
8135
109e28d0 8136 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
8137 (imagemagick_load_image): Fix pointer signedness problem by changing
8138 last arg from unsigned char * to char *. All uses changed.
8139 Also, fix a local for similar reasons.
8140 Remove unused locals. Remove locals to avoid shadowing.
8141 (fn_rsvg_handle_free): Remove; unused.
8142 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 8143 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 8144
3f754b86
PE
8145 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
8146
2547adb1
CY
81472011-06-10 Chong Yidong <cyd@stupidchicken.com>
8148
8149 * image.c (gif_load): Fix omitted cast error introduced by
8150 2011-06-06 change.
8151
2c8e37d4
MR
81522011-06-10 Martin Rudalics <rudalics@gmx.at>
8153
8154 * window.h (resize_proportionally, orig_total_lines)
8155 (orig_top_line): Remove from window structure.
8156 (set_window_height, set_window_width, change_window_heights)
8157 (Fdelete_window): Remove prototypes.
8158 (resize_frame_windows): Remove duplicate declaration.
8159
440a42e3
EZ
81602011-06-10 Eli Zaretskii <eliz@gnu.org>
8161
8162 * window.h (resize_frame_windows, resize_window_check)
8163 (delete_deletable_window, resize_root_window)
8164 (resize_frame_windows): Declare prototypes.
8165
8166 * window.c (resize_window_apply): Make definition be "static" to
8167 match the prototype.
8168
562dd5e9
MR
81692011-06-10 Martin Rudalics <rudalics@gmx.at>
8170
8171 * window.c: Remove declarations of Qwindow_size_fixed,
8172 window_min_size_1, window_min_size_2, window_min_size,
8173 size_window, window_fixed_size_p, enlarge_window, delete_window.
8174 Remove static from declaration of Qdelete_window, it's
8175 temporarily needed by Fbury_buffer.
8176 (replace_window): Don't assign orig_top_line and
8177 orig_total_lines.
8178 (Fdelete_window, delete_window): Remove. Window deletion is
8179 handled by window.el.
640c8776
SM
8180 (window_loop): Remove DELETE_OTHER_WINDOWS case.
8181 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
8182 (Fdelete_other_windows): Remove. Deleting other windows is
8183 handled by window.el.
8184 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
8185 handled in window.el.
8186 (window_min_size_2, window_min_size_1, window_min_size): Remove.
8187 Window minimum sizes are handled in window.el.
8188 (shrink_windows, size_window, set_window_height)
8189 (set_window_width, change_window_heights, window_height)
8190 (window_width, CURBEG, CURSIZE, enlarge_window)
8191 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
8192 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
8193 handled in window.el.
8194 (make_dummy_parent): Rename to make_parent_window and give it a
8195 second argument horflag.
8196 (make_window): Don't set resize_proportionally any more.
8197 (Fsplit_window): Remove. Windows are split in window.el.
8198 (save_restore_action, save_restore_orig_size)
8199 (shrink_window_lowest_first, save_restore_orig_size): Remove.
8200 Resize mini windows in window.el.
8201 (grow_mini_window, shrink_mini_window): Implement by calling
8202 Qresize_root_window_vertically, resize_window_check and
8203 resize_window_apply.
640c8776
SM
8204 (saved_window, Fset_window_configuration, save_window_save):
8205 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
8206 resize_proportionally.
8207 (window_min_height, window_min_width): Move to window.el.
8208 (keys_of_window): Move bindings for delete-other-windows,
8209 split-window, delete-window and enlarge-window to window.el.
8210
8211 * buffer.c: Temporarily extern Qdelete_window.
8212 (Fbury_buffer): Temporarily call Qdelete_window instead of
8213 Fdelete_window (Fbury_buffer will move to window.el soon).
8214
8215 * frame.c (set_menu_bar_lines_1): Remove code handling
8216 orig_top_line and orig_total_lines.
8217
8218 * dispnew.c (adjust_frame_glyphs_initially): Don't use
8219 set_window_height but set heights directly.
8220 (change_frame_size_1): Use resize_frame_windows.
8221
8222 * xdisp.c (init_xdisp): Don't use set_window_height but set
8223 heights directly.
8224
640c8776
SM
8225 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
8226 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
8227 run_window_configuration_change_hook.
8228
8229 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
8230 instead of change_window_heights and run
8231 run_window_configuration_change_hook.
8232
1a13852e
MR
82332011-06-09 Martin Rudalics <rudalics@gmx.at>
8234
8235 * window.c (replace_window): Rename second argument REPLACEMENT to
8236 NEW. New third argument SETFLAG. Rewrite.
8237 (delete_window, make_dummy_parent): Call replace_window with
8238 third argument 1.
8239 (window_list_1): Move down in code.
8240 (run_window_configuration_change_hook): Move set_buffer part
8241 before select_frame_norecord part in order to unwind correctly.
8242 Rename count1 to count.
8243 (recombine_windows, delete_deletable_window, resize_root_window)
8244 (Fdelete_other_windows_internal)
8245 (Frun_window_configuration_change_hook, make_parent_window)
8246 (resize_window_check, resize_window_apply, Fresize_window_apply)
8247 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
8248 (Fdelete_window_internal, Fresize_mini_window_internal):
8249 New functions.
1a13852e
MR
8250 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
8251
f3d1777e
MR
82522011-06-08 Martin Rudalics <rudalics@gmx.at>
8253
496e208e
MR
8254 * window.h (window): Add some new members to window structure -
8255 normal_lines, normal_cols, new_total, new_normal, clone_number,
8256 splits, nest, prev_buffers, next_buffers.
8257 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 8258 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 8259
f3d1777e
MR
8260 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
8261 Remove.
496e208e
MR
8262 (make_dummy_parent): Set new members of windows structure.
8263 (make_window): Move down in code. Handle new members of window
8264 structure.
8265 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
8266 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
8267 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
8268 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
8269 (Fset_window_next_buffers, Fset_window_clone_number):
8270 New functions.
496e208e
MR
8271 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
8272 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
8273 Doc-string fixes.
8274 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
8275 Argument WINDOW can be now internal window too.
8276 (Fwindow_use_time): Move up in code.
8277 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
8278 Rewrite doc-string.
8279 (Fset_window_configuration, saved_window)
8280 (Fcurrent_window_configuration, save_window_save): Handle new
8281 members of window structure.
b9e809c2
MR
8282 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
8283 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
8284 (syms_of_window): New Lisp objects Qrecord_window_buffer,
8285 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
8286 Qget_mru_window, Qresize_root_window,
8287 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
8288 Qauto_buffer_name; staticpro them.
f3d1777e 8289
abde8f8c
MR
82902011-06-07 Martin Rudalics <rudalics@gmx.at>
8291
8292 * window.c (Fwindow_total_size, Fwindow_left_column)
8293 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
8294 (Fwindow_list_1): New functions.
8295 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
8296 (Fwindow_width, Fscroll_left, Fscroll_right):
8297 Use window_body_cols instead of window_box_text_cols.
8298 (delete_window, Fset_window_configuration):
8299 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
8300 (delete_all_subwindows): Take a window as argument and not a
8301 structure. Rewrite.
190b47e6
MR
8302 (window_loop): Remove handling of GET_LRU_WINDOW and
8303 GET_LARGEST_WINDOW.
8304 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
8305
8306 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
8307 window_box_text_cols. delete_all_subwindows now takes a
8308 Lisp_Object as argument.
abde8f8c 8309
640c8776
SM
8310 * indent.c (compute_motion, Fcompute_motion):
8311 Use window_body_cols instead of window_box_text_cols.
abde8f8c 8312
fa8a67e6
MR
8313 * frame.c (delete_frame): Call delete_all_subwindows with root
8314 window as argument.
8315
a54e3482
DC
83162011-06-07 Daniel Colascione <dan.colascione@gmail.com>
8317
8318 * fns.c (Fputhash): Document return value.
8319
60002bf5
CY
83202011-06-06 Chong Yidong <cyd@stupidchicken.com>
8321
8322 * image.c (gif_load): Implement gif89a spec "no disposal" method.
8323
0c671da6 83242011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 8325
b862a52a 8326 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 8327
be44ca6c
PE
8328 Check for overflow when converting integer to cons and back.
8329 * charset.c (Fdefine_charset_internal, Fdecode_char):
8330 Use cons_to_unsigned to catch overflow.
8331 (Fencode_char): Use INTEGER_TO_CONS.
8332 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
8333 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
8334 * data.c (long_to_cons, cons_to_long): Remove.
8335 (cons_to_unsigned, cons_to_signed): New functions.
8336 These signal an error for invalid or out-of-range values.
8337 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
8338 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
8339 * font.c (Ffont_variation_glyphs):
8340 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
8341 * lisp.h: Include <intprops.h>.
8342 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
8343 (cons_to_signed, cons_to_unsigned): New decls.
8344 (long_to_cons, cons_to_long): Remove decls.
8345 * undo.c (record_first_change): Use INTEGER_TO_CONS.
8346 (Fprimitive_undo): Use CONS_TO_INTEGER.
8347 * xfns.c (Fx_window_property): Likewise.
8348 * xselect.c: Include <limits.h>.
8349 (x_own_selection, selection_data_to_lisp_data):
8350 Use INTEGER_TO_CONS.
8351 (x_handle_selection_request, x_handle_selection_clear)
8352 (x_get_foreign_selection, Fx_disown_selection_internal)
8353 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
8354 (lisp_data_to_selection_data): Use cons_to_unsigned.
8355 (x_fill_property_data): Use cons_to_signed.
8356 Report values out of range.
8357
d1f3d2af
PE
8358 Check for buffer and string overflow more precisely.
8359 * buffer.h (BUF_BYTES_MAX): New macro.
8360 * lisp.h (STRING_BYTES_MAX): New macro.
8361 * alloc.c (Fmake_string):
8362 * character.c (string_escape_byte8):
8363 * coding.c (coding_alloc_by_realloc):
8364 * doprnt.c (doprnt):
8365 * editfns.c (Fformat):
8366 * eval.c (verror):
8367 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
8368 since they may not be the same number.
8369 * editfns.c (Finsert_char):
8370 * fileio.c (Finsert_file_contents):
8371 Likewise for BUF_BYTES_MAX.
8372
dd52fcea
PE
8373 * image.c: Use ptrdiff_t, not int, for sizes.
8374 (slurp_file): Switch from int to ptrdiff_t.
8375 All uses changed.
8376 (slurp_file): Check that file size fits in both size_t (for
8377 malloc) and ptrdiff_t (for sanity and safety).
8378
7f9bbdbb
PE
8379 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
8380 if b->modtime has its maximal value.
8381
dfe18f82
PE
8382 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
8383
84acfcf0
PE
8384 Don't assume time_t can fit into int.
8385 * buffer.h (struct buffer.modtime): Now time_t, not int.
8386 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
8387 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
8388
ccd9a01a
PE
8389 Minor fixes for signed vs unsigned integers.
8390 * character.h (MAYBE_UNIFY_CHAR):
8391 * charset.c (maybe_unify_char):
8392 * keyboard.c (read_char, reorder_modifiers):
8393 XINT -> XFASTINT, since the integer must be nonnegative.
8394 * ftfont.c (ftfont_spec_pattern):
8395 * keymap.c (access_keymap, silly_event_symbol_error):
8396 XUINT -> XFASTINT, since the integer must be nonnegative.
8397 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
8398 since it makes no difference and we prefer signed.
8399 * keyboard.c (record_char): Use XUINT when all the neighbors do.
8400 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
8401 nonnegative.
8402
d6d100dd
SM
84032011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
8404
8405 * window.h (Fwindow_frame): Declare.
8406
2b6148e4
PE
84072011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8408
8409 * alloc.c: Simplify handling of large-request failures (Bug#8800).
8410 (SPARE_MEMORY): Always define.
8411 (LARGE_REQUEST): Remove.
8412 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
8413
f230ecc9
MR
84142011-06-06 Martin Rudalics <rudalics@gmx.at>
8415
727e958e
MR
8416 * lisp.h: Move EXFUNS for Fframe_root_window,
8417 Fframe_first_window and Fset_frame_selected_window to window.h.
8418
8419 * window.h: Move EXFUNS for Fframe_root_window,
8420 Fframe_first_window and Fset_frame_selected_window here from
8421 lisp.h.
8422
8423 * frame.c (Fwindow_frame, Fframe_first_window)
8424 (Fframe_root_window, Fframe_selected_window)
8425 (Fset_frame_selected_window): Move to window.c.
8426 (Factive_minibuffer_window): Move to minibuf.c.
8427 (Fother_visible_frames_p): New function.
8428
8429 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
8430
f230ecc9
MR
8431 * window.c (decode_window, decode_any_window): Move up in code.
8432 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
8433 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
8434 (Fwindow_buffer): Move up and rewrite doc-string.
8435 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
8436 (Fwindow_prev): New functions.
727e958e
MR
8437 (Fwindow_frame): Move here from frame.c. Accept any window as
8438 argument.
8439 (Fframe_root_window, Fframe_first_window)
8440 (Fframe_selected_window): Move here from frame.c. Accept frame
8441 or arbitrary window as argument. Update doc-strings.
8442 (Fminibuffer_window): Move up in code.
8443 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
8444 (Fset_frame_selected_window): Move here from frame.c.
8445 Marginal rewrite.
727e958e
MR
8446 (Fselected_window, select_window, Fselect_window): Move up in
8447 code. Minor doc-string fixes.
f230ecc9 8448
4d09bcf6
PE
84492011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8450
8451 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
8452 Do not assume that spare memory exists; that assumption is valid
8453 only if SYSTEM_MALLOC.
8454 (LARGE_REQUEST): New macro, so that the issue of large requests
8455 is separated from the issue of spare memory.
8456
810928a2
AS
84572011-06-05 Andreas Schwab <schwab@linux-m68k.org>
8458
172418ad
AS
8459 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
8460 format. (Bug#8806)
8461
43f862f7
AS
8462 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
8463
810928a2
AS
8464 * xfns.c (x_set_scroll_bar_default_width): Move declarations
8465 before statements.
8466
a059fe24
JD
84672011-06-05 Jan Djärv <jan.h.d@swipnet.se>
8468
8469 * gtkutil.c (xg_get_default_scrollbar_width): New function.
8470
8471 * gtkutil.h: Declare xg_get_default_scrollbar_width.
8472
8473 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
8474 min width by calling x_set_scroll_bar_default_width (Bug#8505).
8475
989bf368
JB
84762011-06-05 Juanma Barranquero <lekktu@gmail.com>
8477
8478 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
8479
4b80f674
CY
84802011-06-04 Chong Yidong <cyd@stupidchicken.com>
8481
8482 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
8483 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
8484 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
8485 New error handlers.
4b80f674
CY
8486 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
8487 Obey Vx_select_enable_clipboard_manager. Catch errors in
8488 x_clipboard_manager_save (Bug#8779).
8489 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 8490 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 8491
99a33b77 84922011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
8493
8494 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
8495
99a33b77 84962011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
8497
8498 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
8499 in the current matrix if keep_current_p is non-zero.
8500
8264569d
EZ
85012011-06-04 Eli Zaretskii <eliz@gnu.org>
8502
8503 * bidi.c (bidi_level_of_next_char): Fix last change.
8504
57f97249
EZ
85052011-06-03 Eli Zaretskii <eliz@gnu.org>
8506
fec2107c 8507 Support bidi reordering of text covered by display properties.
57f97249 8508
fec2107c
EZ
8509 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
8510 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
8511 (bidi_cache_search, bidi_cache_iterator_state)
8512 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
8513 (bidi_level_of_next_char, bidi_move_to_visually_next):
8514 Support character positions inside a run of characters covered by a
fec2107c
EZ
8515 display string.
8516 (bidi_paragraph_init, bidi_resolve_explicit_1)
8517 (bidi_level_of_next_char): Call bidi_fetch_char and
8518 bidi_fetch_char_advance instead of FETCH_CHAR and
8519 FETCH_CHAR_ADVANCE.
8520 (bidi_init_it): Initialize new members.
8521 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
8522 definitions.
8523 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
8524 instead of using explicit *_CHAR codes.
d6d100dd
SM
8525 (bidi_resolve_explicit, bidi_resolve_weak):
8526 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
8527 bidirectional text is supported only in multibyte buffers.
8528 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
8529 it to initialize the frame_window_p member of struct bidi_it.
8530 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
8531 (bidi_resolve_explicit, bidi_resolve_weak)
8532 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
8533 bidi_it->nchars is non-positive.
8534 (bidi_level_of_next_char): Don't try to lookup the cache for the
8535 next/previous character if nothing is cached there yet, or if we
8536 were just reseat()'ed to a new position.
c40e2fb2 8537
0e14fe90
EZ
8538 * xdisp.c (set_cursor_from_row): Set start and stop points
8539 according to the row's direction when priming the loop that looks
8540 for the glyph on which to display cursor.
8541 (single_display_spec_intangible_p): Function deleted.
8542 (display_prop_intangible_p): Reimplement to call
8543 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
8544 Accept 3 additional arguments needed by handle_display_spec.
8545 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
8546 values: lists, `(when COND...)' forms, etc.
8547 (single_display_spec_string_p): Support property values that are
8548 lists with the argument STRING its top-level element.
8549 (display_prop_string_p): Fix the condition for processing a
8550 property that is a list to be consistent with handle_display_spec.
fec2107c 8551 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
8552 last portion of handle_display_prop.
8553 (compute_display_string_pos): Accept additional argument
8554 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
8555 value of a `display' property is a "replacing spec".
8556 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
8557 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
8558 the display property, but just return a value indicating whether
8559 the display property will replace the characters it covers.
8560 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
8561 frame_window_p members of struct bidi_it.
d6d100dd
SM
8562 (compute_display_string_pos, compute_display_string_end):
8563 New functions.
fec2107c
EZ
8564 (push_it): Accept second argument POSITION, where pop_it should
8565 jump to continue iteration.
8566 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 8567
fec2107c
EZ
8568 * keyboard.c (adjust_point_for_property): Adjust the call to
8569 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
8570
8571 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
8572 (bidi_init_it): Update prototypes.
8573 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
8574 (compute_display_string_pos, compute_display_string_end):
8575 Declare prototypes.
fec2107c
EZ
8576 (struct bidi_it): New members nchars and disp_pos. ch_len is now
8577 EMACS_INT.
fc6f18ce 8578
40087514 85792011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 8580
57f53182
PE
8581 Malloc failure behavior now depends on size of allocation.
8582 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
8583 * lisp.h: Change signatures accordingly.
8584 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
8585 All callers changed. (Bug#8762)
8586
8587 * gnutls.c: Use Emacs's memory allocators.
8588 Without this change, the gnutls library would invoke malloc etc.
8589 directly, which causes problems on non-SYNC_INPUT hosts, and which
8590 runs afoul of improving memory_full behavior. (Bug#8761)
8591 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
8592 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
8593 xfree instead of the default malloc, realloc, free.
8594 (Fgnutls_boot): No need to check for memory allocation failure,
8595 since xmalloc does that for us.
8596
ac32cd99 8597 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
8598 * category.c (hash_get_category_set):
8599 * ccl.c (ccl_driver):
8600 * charset.c (Fdefine_charset_internal):
8601 * charset.h (struct charset.hash_index):
8602 * composite.c (get_composition_id, gstring_lookup_cache)
8603 (composition_gstring_put_cache):
8604 * composite.h (struct composition.hash_index):
8605 * dispextern.h (struct image.hash):
8606 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
8607 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
8608 (hashfn_equal, hashfn_user_defined, make_hash_table)
8609 (maybe_resize_hash_table, hash_lookup, hash_put)
8610 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
8611 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
8612 (Fsxhash, Fgethash, Fputhash, Fmaphash):
8613 * image.c (make_image, search_image_cache, lookup_image)
8614 (xpm_put_color_table_h):
8615 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 8616 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 8617 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 8618 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
8619 * alloc.c (allocate_vectorlike):
8620 Check for overflow in vector size calculations.
8621 * ccl.c (ccl_driver):
8622 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
8623 * fns.c, image.c: Remove unnecessary static decls that would otherwise
8624 need to be updated by these changes.
40087514
PE
8625 * fns.c (make_hash_table, maybe_resize_hash_table):
8626 Check for integer overflow with large hash tables.
0de4bb68
PE
8627 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
8628 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
8629 (SXHASH_REDUCE): New macro.
8630 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
8631 Use it instead of discarding useful hash info with large hash values.
8632 (sxhash_float): New function.
8633 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
8634 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
8635 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
8636 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
8637 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
8638 Adjust signatures to match updated version of code.
8639 (consing_since_gc): Now EMACS_INT, since a single hash table can
8640 use more than INT_MAX bytes.
8641
698d32e2
DN
86422011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
8643
8644 Make it possible to build with GCC-4.6+ -O2 -flto.
8645
8646 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
8647
fd6fa53f
SM
86482011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
8649
8650 * minibuf.c (get_minibuffer, read_minibuf_unwind):
8651 Call minibuffer-inactive-mode.
8652
864db017
JB
86532011-05-31 Juanma Barranquero <lekktu@gmail.com>
8654
8655 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
8656 Update dependencies.
8657
2ad0baf4
DN
86582011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8659
8660 * data.c (init_data): Remove code for UTS, this system is not
8661 supported anymore.
8662
4fcc2638
DN
86632011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8664
8665 Don't force ./temacs to start in terminal mode.
8666
8667 * frame.c (make_initial_frame): Initialize faces in all cases, not
8668 only when CANNOT_DUMP is defined.
8669 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
8670
c56e0fd5
DN
86712011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8672
8673 * dispnew.c (add_window_display_history): Use const for the string
8674 pointer. Remove declaration, not needed.
8675
333d54da 86762011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 8677
55d4c1b2 8678 Use 'inline', not 'INLINE'.
333d54da 8679 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
8680 * alloc.c, fontset.c (INLINE): Remove.
8681 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
8682 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
8683 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
8684 * gmalloc.c (register_heapinfo): Use inline unconditionally.
8685 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
8686
738db178
DN
86872011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8688
8689 Make it possible to run ./temacs.
8690
8691 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
8692 syms_of_callproc does the same thing. Remove test for
8693 "initialized", do it in the caller.
8694 * emacs.c (main): Avoid calling set_initial_environment when dumping.
8695
620c53a6
SM
86962011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
8697
8698 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
8699 (read_minibuf): Use get_minibuffer.
8700 (syms_of_minibuf): Use DEFSYM.
8701 (Qmetadata): New var.
8702 * data.c (Qbuffer): Don't make it static.
8703 (syms_of_data): Use DEFSYM.
8704
e003a292
PE
87052011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8706
8707 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
8708 (CCL_CODE_MIN): New macro.
8709
ed008a6d
PE
87102011-05-30 Paul Eggert <eggert@cs.ucla.edu>
8711
3687c2ef
PE
8712 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
8713
ed008a6d
PE
8714 * eval.c (Qdebug): Now static.
8715 * lisp.h (Qdebug): Remove decl. This reverts a part of the
8716 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
8717 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
8718
d66c4c7c
CY
87192011-05-29 Chong Yidong <cyd@stupidchicken.com>
8720
8721 * image.c: Various fixes to ImageMagick code comments.
8722 (Fimagemagick_types): Doc fix.
8723
5fbc2025
PE
87242011-05-29 Paul Eggert <eggert@cs.ucla.edu>
8725
0196f88a
PE
8726 Minor fixes prompted by GCC 4.6.0 warnings.
8727
8728 * xselect.c (converted_selections, conversion_fail_tag): Now static.
8729
5fbc2025
PE
8730 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
8731 (x_clipboard_manager_save_all): Move extern decl to ...
8732 * xterm.h: ... here, so that it can be checked for consistency.
8733
1dd3c2d9
CY
87342011-05-29 Chong Yidong <cyd@stupidchicken.com>
8735
8736 * xselect.c (x_clipboard_manager_save_frame)
8737 (x_clipboard_manager_save_all): New functions.
8738 (Fx_clipboard_manager_save): Lisp function deleted.
8739
8740 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
8741 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
8742
8743 * xterm.h: Update prototype.
8744
5ba6571d
WX
87452011-05-28 William Xu <william.xwl@gmail.com>
8746
8747 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
8748 exiting (Bug#8239).
8749
3eaff834
JM
87502011-05-28 Jim Meyering <meyering@redhat.com>
8751
e1900994 8752 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
8753 * fns.c (to_uchar): Define.
8754 (crypto_hash_function): Use it to convert some newly-signed
8755 variables to unsigned, to avoid sign-extension bugs. For example,
8756 without this change, (md5 "truc") would evaluate to
8757 45723a2aff78ff4fff7fff1114760e62 rather than the expected
8758 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 8759 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 8760
0f6990a7
PE
87612011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8762
8763 Integer overflow fixes.
c8a9ca5a 8764
08686060
PE
8765 * dbusbind.c: Serial number integer overflow fixes.
8766 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
8767 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
8768 to hold a serial number that is too large for a fixnum.
8769 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8770 Check for serial numbers out of range. Decode any serial number
59568bf0 8771 that was so large that it became a float. (Bug#8722)
08686060 8772
2d1fc3c7
PE
8773 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
8774 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8775 Use XFASTINT rather than XUINT when numbers are nonnegative.
8776 (xd_append_arg, Fdbus_method_return_internal):
8777 (Fdbus_method_error_internal): Likewise. Also, for unsigned
8778 arguments, check that Lisp number is nonnegative, rather than
59568bf0 8779 silently wrapping negative numbers around. (Bug#8722)
30217ff0 8780 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 8781 (Bug#8722)
2d1fc3c7 8782
c8a9ca5a
PE
8783 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
8784
519e1d69
PE
8785 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
8786
6df6ae42 8787 ccl: Add integer overflow checks.
30569699
PE
8788 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
8789 (IN_INT_RANGE): New macros.
8790 (ccl_driver): Use them to check for integer overflow when
8791 decoding a CCL program. Many of the new checks are whether XINT (x)
8792 fits in int; it doesn't always, on 64-bit hosts. The new version
8793 doesn't catch all possible integer overflows, but it's an
847044ea 8794 improvement. (Bug#8719)
30569699 8795
c11285dc
PE
8796 * alloc.c (make_event_array): Use XINT, not XUINT.
8797 There's no need for unsigned here.
8798
fdccd48e
PE
8799 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
8800 This follows up to the 2011-05-06 change that substituted uintptr_t
8801 for EMACS_INT. This case wasn't caught back then.
8802
37910ab2
PE
8803 Rework Fformat to avoid integer overflow issues.
8804 * editfns.c: Include <float.h> unconditionally, as it's everywhere
8805 now (part of C89). Include <verify.h>.
8806 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
8807 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
8808 (Fformat): Avoid the prepass trying to compute sizes; it was only
8809 approximate and thus did not catch overflow reliably. Instead, walk
8810 through the format just once, formatting and computing sizes as we go,
8811 checking for integer overflow at every step, and allocating a larger
8812 buffer as needed. Keep track separately whether the format is
8813 multibyte. Keep only the most-recently calculated precision, rather
8814 than them all. Record whether each argument has been converted to
8815 string. Use EMACS_INT, not int, for byte and char and arg counts.
8816 Support field widths and precisions larger than INT_MAX. Avoid
8817 sprintf's undefined behavior with conversion specifications such as %#d
8818 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
8819 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
8820 formatting out-of-range floating point numbers with int
9173deec 8821 formats. (Bug#8668)
37910ab2 8822
2e6578fb
PE
8823 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
8824
0ae6bdee
PE
8825 * data.c: Avoid integer truncation in expressions involving floats.
8826 * data.c: Include <intprops.h>.
8827 (arith_driver): When there's an integer overflow in an expression
8828 involving floating point, convert the integers to floating point
8829 so that the resulting value does not suffer from catastrophic
8830 integer truncation. For example, on a 64-bit host (* 4
8831 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
8832 Do not rely on undefined behavior after integer overflow.
8833
de883a70
PE
8834 merge count_size_as_multibyte, parse_str_to_multibyte
8835 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 8836 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
8837 Check for integer overflow.
8838 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
8839 since it's now a duplicate of the other. This is more of
8840 a character than a buffer op, so better that it's in character.c.
8841 * fns.c, print.c: Adjust to above changes.
8842
2ff916cb
PE
88432011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
8844
8845 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
8846
f1b54466
PE
88472011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8848
fb1ac845
PE
8849 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8850 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
8851 (x_clipboard_manager_save): Now static.
8852 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
8853
f1b54466
PE
8854 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8855 (crypto_hash_function): Now static.
8856 Fix pointer signedness problems. Avoid unnecessary initializations.
8857
a9f737ee
CY
88582011-05-27 Chong Yidong <cyd@stupidchicken.com>
8859
8860 * termhooks.h (Vselection_alist): Make it terminal-local.
8861
8862 * terminal.c (create_terminal): Initialize it.
8863
8864 * xselect.c: Support for clipboard managers.
8865 (Vselection_alist): Move to termhooks.h as terminal-local var.
8866 (LOCAL_SELECTION): New macro.
8867 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
8868 (symbol_to_x_atom): Remove gratuitous arg.
8869 (x_handle_selection_request, lisp_data_to_selection_data)
8870 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
8871 (x_own_selection, x_get_local_selection, x_convert_selection):
8872 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
8873 (some_frame_on_display): Delete unused function.
8874 (Fx_own_selection_internal, Fx_get_selection_internal)
8875 (Fx_disown_selection_internal, Fx_selection_owner_p)
8876 (Fx_selection_exists_p): New optional frame arg.
8877 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
8878 (x_handle_selection_clear): Don't treat other terminals with the
8879 same keyboard specially. Use the terminal-local Vselection_alist.
8880 (x_clear_frame_selections): Use Frun_hook_with_args.
8881
8882 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
8883
8884 * xterm.h: Add support for those atoms.
8885
e067f0c1
CY
88862011-05-26 Chong Yidong <cyd@stupidchicken.com>
8887
8888 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
8889 (converted_selections, conversion_fail_tag): New global variables.
8890 (x_selection_request_lisp_error): Free the above.
8891 (x_get_local_selection): Remove unnecessary code.
8892 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
8893 of converted selections stored in converted_selections.
8894 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
8895 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
8896 (x_convert_selection): New function.
8897 (x_handle_selection_event): Simplify.
8898 (x_get_foreign_selection): Don't ignore incoming requests while
8899 waiting for an answer; this will fail when we implement
8900 SAVE_TARGETS, and seems unnecessary anyway.
8901 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
8902 (Vx_sent_selection_functions): Doc fix.
8903
0f4aebc0
LL
89042011-05-26 Leo Liu <sdl.web@gmail.com>
8905
8906 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
8907
e61124cd
YM
89082011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8909
8910 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
8911
8912 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
8913 for fringe update if it has periodic bitmap.
ac389d0c 8914 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
8915 and fringe_bitmap_periodic_p.
8916
8917 * fringe.c (get_fringe_bitmap_data): New function.
8918 (draw_fringe_bitmap_1, update_window_fringes): Use it.
8919 (update_window_fringes): Record periodicity of fringe bitmap in glyph
8920 row. Mark glyph row for fringe update if periodicity changed.
8921
8922 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
8923 for fringe update unless it has periodic bitmap.
8924
f16d9837
KH
89252011-05-25 Kenichi Handa <handa@m17n.org>
8926
8927 * xdisp.c (get_next_display_element): Set correct it->face_id for
8928 a static composition.
8929
e1b90ef6
LL
89302011-05-24 Leo Liu <sdl.web@gmail.com>
8931
8932 * deps.mk (fns.o):
8933 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
8934
8935 * fns.c (crypto_hash_function, Fsha1): New function.
8936 (Fmd5): Use crypto_hash_function.
8937 (syms_of_fns): Add Ssha1.
8938
7400048f
PE
89392011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8940
8941 * gnutls.c: Remove unused macros.
8942 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
8943 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
8944 Remove macros that are defined and never used.
8945 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
8946
abb71cf4
CY
89472011-05-22 Chong Yidong <cyd@stupidchicken.com>
8948
8949 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
8950 (Fx_get_selection_internal): Minor cleanup.
8951 (Fx_own_selection_internal): Rename arguments for consistency with
8952 select.el.
8953
6307db39
PE
89542011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8955
8956 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
8957
f3d4e0a4
CY
89582011-05-22 Chong Yidong <cyd@stupidchicken.com>
8959
8960 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
8961
4d8ade89
YM
89622011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8963
8964 * dispnew.c (scrolling_window): Don't exclude the case that the
8965 last enabled row in the desired matrix touches the bottom boundary.
8966
32078c8d
GM
89672011-05-21 Glenn Morris <rgm@gnu.org>
8968
8969 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
8970 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
8971 and add some more files.
32078c8d 8972
7285dc67
EZ
89732011-05-20 Eli Zaretskii <eliz@gnu.org>
8974
8975 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
8976 report_file_error introduced by the change from 2011-05-07.
8977
89d1bd22
PE
89782011-05-20 Paul Eggert <eggert@cs.ucla.edu>
8979
8980 * systime.h (Time): Define only if emacs is defined.
8981 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
8982 where the include path doesn't have X11/X.h by default. See
8983 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
8984
cd394be1 89852011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
8986
8987 * composite.c (find_automatic_composition): Fix previous change.
8988
b9704ad9
GM
89892011-05-20 Glenn Morris <rgm@gnu.org>
8990
8991 * lisp.mk: New file, split from Makefile.in.
8992 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
8993 (shortlisp): Remove.
8994 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
8995
4a720484
GM
89962011-05-19 Glenn Morris <rgm@gnu.org>
8997
8998 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
8999 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
9000 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
9001 (lisp): Set the order to that of loadup.el.
9002 (shortlisp): Make it a copy of $lisp.
9003 (SOME_MACHINE_LISP): Remove.
9004 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
9005 Use just $shortlisp, not $SOME_MACHINE_LISP too.
9006
a28d4396
KH
90072011-05-18 Kenichi Handa <handa@m17n.org>
9008
9009 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
9010 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
9011 (find_automatic_composition): Mostly rewrite for efficiency.
9012
a2b1fa8e
JB
90132011-05-18 Juanma Barranquero <lekktu@gmail.com>
9014
9015 * makefile.w32-in: Update dependencies.
9016
8e1f5610
CS
90172011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
9018
9019 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 9020 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 9021
7025ee00 90222011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 9023
cdfa6eab
PE
9024 Fix some integer overflow issues, such as string length overflow.
9025
06d6db33
PE
9026 * insdel.c (count_size_as_multibyte): Check for string overflow.
9027
2b4560a8
PE
9028 * character.c (lisp_string_width): Check for string overflow.
9029 Use EMACS_INT, not int, for string indexes and lengths; in
9030 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
9031 the resulting string length overflows an EMACS_INT; instead,
9032 report a string overflow if no precision given. When checking for
9033 precision exhaustion, use a check that cannot possibly have
9034 integer overflow. (Bug#8675)
9035 * character.h (lisp_string_width): Adjust to new signature.
9036
cb93f9be
PE
9037 * alloc.c (string_overflow): New function.
9038 (Fmake_string): Use it. This doesn't change behavior, but saves
9039 a few bytes and will simplify future changes.
9040 * character.c (string_escape_byte8): Likewise.
9041 * lisp.h (string_overflow): New decl.
9042
1a1f3366
PE
9043 Fixups, following up to the user-interface timestamp change.
9044 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
9045 for UI timestamps, instead of unsigned long.
9fbd6841
PE
9046 * msdos.c (mouse_get_pos): Likewise.
9047 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
9048 * w32gui.h (Time): Define by including "systime.h" rather than by
9049 declaring it ourselves. (Bug#8664)
9050
d4e3e4d3
PE
9051 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
9052 * image.c (clear_image_cache): Likewise.
9053
f6a24d19
PE
9054 * term.c (term_mouse_position): Don't assume time_t wraparound.
9055
08dc5ae6
PE
9056 Be more systematic about user-interface timestamps.
9057 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
9058 and sometimes 'EMACS_UINT', to represent these timestamps.
9059 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
9060 This makes the code easier to follow, and makes it easier to catch
9061 integer overflow bugs such as Bug#8664.
9062 * frame.c (Fmouse_position, Fmouse_pixel_position):
9063 Use Time, not unsigned long, for user-interface timestamps.
9064 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
9065 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
9066 * keyboard.h (last_event_timestamp): Likewise.
9067 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
9068 * menu.h (xmenu_show): Likewise.
9069 * term.c (term_mouse_position): Likewise.
9070 * termhooks.h (struct input_event.timestamp): Likewise.
9071 (struct terminal.mouse_position_hook): Likewise.
9072 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
9073 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
9074 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
9075 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
9076 what it was before.
9077 * menu.h, termhooks.h: Include "systime.h", for Time.
9078
8e55734a
PE
9079 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
9080 Don't assume that the difference between two unsigned long values
9081 can fit into an integer. At this point, we know button_down_time
9082 <= event->timestamp, so the difference must be nonnegative, so
9083 there's no need to cast the result if double-click-time is
9084 nonnegative, as it should be; check that it's nonnegative, just in
9085 case. This bug is triggered when events are more than 2**31 ms
86db42d2 9086 apart (about 25 days). (Bug#8664)
8e55734a 9087
841f1b75 9088 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 9089 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 9090
3e26f69c
PE
9091 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
9092 that always fit in int. Use a sentinel instead of a counter, to
9093 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
9094 * frame.h (struct frame): Use int for menu_bar_items_used
9095 instead of EMACS_INT, since it always fits in int.
3e26f69c 9096
5cc152c0
PE
9097 * menu.c (grow_menu_items): Check for int overflow.
9098
d89eb65e
PE
9099 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
9100
5235bd3e
PE
9101 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
9102 Before, the code was not consistent. These values cannot exceed
9103 2**31 - 1 so there's no need to make them unsigned.
9104 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
9105 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
9106 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
9107 as modifiers.
9108 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
9109
bc827e23
PE
9110 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
9111 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
9112 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
9113 presumably because the widths might not match.
9114
78eb494e
PE
9115 * window.c (size_window): Avoid needless test at loop start.
9116
04f2d78b
CB
91172011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
9118
9119 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
9120
d2fc7e3d 91212011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
9122
9123 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
9124
d2fc7e3d 91252011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
9126
9127 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
9128 `width' to `bar_area_x' and `bar_area_width', respectively.
9129 (x_scroll_run): Take account of fringe background extension.
9130
04f2d78b
CB
9131 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
9132 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
9133 `bar_area_width', respectively.
9134 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
9135 background extension.
9136
79b70037
GM
91372011-05-10 Jim Meyering <meyering@redhat.com>
9138
9139 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
9140
2f142cc5
JB
91412011-05-10 Juanma Barranquero <lekktu@gmail.com>
9142
9143 * image.c (Finit_image_library): Return t for built-in image types,
9144 like pbm and xbm. (Bug#8640)
9145
57679c86
AS
91462011-05-09 Andreas Schwab <schwab@linux-m68k.org>
9147
9148 * w32menu.c (set_frame_menubar): Fix submenu allocation.
9149
888c9e86
EZ
91502011-05-07 Eli Zaretskii <eliz@gnu.org>
9151
b0512a1d
EZ
9152 * w32console.c (Fset_screen_color): Doc fix.
9153 (Fget_screen_color): New function.
9154 (syms_of_ntterm): Defsubr it.
9155
7285dc67
EZ
9156 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
9157 unlink the temporary file if Fcall_process didn't create it in the
9158 first place.
9159 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
9160 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
9161 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
9162 cue to call_process_cleanup not to close that handle.
9163
4d3fcc8e
BK
91642011-05-07 Ben Key <bkey76@gmail.com>
9165
9166 * makefile.w32-in: The bootstrap-temacs rule now makes use of
9167 one of two shell specific rules, either bootstrap-temacs-CMD or
9168 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
9169 to the previous implementation of the bootstrap-temacs rule.
9170 The bootstrap-temacs-CMD rule is similar to the previous
9171 implementation of the bootstrap-temacs rule except that it
9172 makes use of the ESC_CFLAGS variable instead of the CFLAGS
9173 variable.
9174
9175 These changes, along with some changes to nt/configure.bat,
9176 nt/gmake.defs, and nt/nmake.defs, are required to extend my
9177 earlier fix to add support for --cflags and --ldflags options
9178 that include quotes so that it works whether make uses cmd or
9179 sh as the shell.
9180
b4289b64
MA
91812011-05-06 Michael Albinus <michael.albinus@gmx.de>
9182
9183 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
9184 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
9185 is a constant.
9186 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
9187 a string. Handle both cases.
9188 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
9189 (Fdbus_register_method): Use Qinvalid_function.
9190
af4c0e28
JB
91912011-05-06 Juanma Barranquero <lekktu@gmail.com>
9192
9193 * makefile.w32-in: Update dependencies.
9194 (LISP_H): Add inttypes.h and stdin.h.
9195 (PROCESS_H): Add unistd.h.
9196
c51453d9
EZ
91972011-05-06 Eli Zaretskii <eliz@gnu.org>
9198
9199 * lread.c: Include limits.h (fixes the MS-Windows build broken by
9200 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
9201
8ff0ac3c 92022011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 9203
4c4b566b
PE
9204 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
9205
aab2b9b5
PE
9206 * term.c (vfatal): Remove stray call to va_end.
9207 It's not needed and the C Standard doesn't allow it here anyway.
9208
c378da0b
PE
9209 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
9210 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
9211
288b08c7
PE
9212 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
9213 bytes.
9214
e3601888
PE
9215 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
9216
db6c0e74
PE
9217 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9218
dd5963ea
PE
9219 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
9220
88c9450f
PE
9221 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
9222
2f9442b8
PE
9223 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
9224
c032b5f8
PE
9225 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
9226 * charset.c (Fdefine_charset_internal): Don't initialize
9227 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 9228 32-bit int (Bug#8600).
a108c10b
PE
9229
9230 * lread.c (read_integer): Be more consistent with string-to-number.
9231 Use string_to_number to do the actual conversion; this avoids
9232 rounding errors and fixes some other screwups. Without this fix,
9233 for example, #x1fffffffffffffff was misread as -2305843009213693952.
9234 (digit_to_number): Move earlier, for benefit of read_integer.
9235 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 9236 not a digit in any supported base. (Bug#8602)
a108c10b 9237
ad5f9eea
PE
9238 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
9239
aec1708a
PE
9240 * dispnew.c (scrolling_window): Return 1 if we scrolled,
9241 to match comment at start of function. This also removes a
9242 GCC warning about overflow in a 32+64-bit port.
9243
47be4ab5
PE
9244 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
9245
371cac43
PE
9246 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
9247 Reported by Stefan Monnier in
9248 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
9249 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9250 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 9251
d01a7826
PE
9252 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
9253 (EMACS_UINTPTR): Likewise, with uintptr_t.
9254
7fd47d5c
PE
9255 * lisp.h: Prefer 64-bit EMACS_INT if available.
9256 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
9257 on 32-bit hosts that have 64-bit int, so that they can access
9258 large files.
122b0c86
PE
9259 However, temporarily disable this change unless the temporary
9260 symbol WIDE_EMACS_INT is defined.
7fd47d5c 9261
8727937b
PE
9262 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
9263
8ac068ac
PE
9264 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
9265 This removes an assumption that EMACS_INT and long are the same
9266 width as pointers. The assumption is true for Emacs porting targets
9267 now, but we want to make other targets possible.
9268 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
9269 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
9270 In the rest of the code, change types of integers that hold casted
9271 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
9272 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
9273 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
9274 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
9275 No need to cast type when ORing.
9276 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
9277 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
9278 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
9279 assume EMACS_INT is the same width as char *.
9280 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
9281 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
9282 Remove no-longer-needed casts.
9283 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
9284 (xg_tool_bar_help_callback, xg_make_tool_item):
9285 Use EMACS_INTPTR to hold an integer
9286 that will be cast to void *; this can avoid a GCC warning
9287 if EMACS_INT is not the same width as void *.
9288 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
9289 * xdisp.c (display_echo_area_1, resize_mini_window_1):
9290 (current_message_1, set_message_1):
9291 Use a local to convert to proper width without a cast.
9292 * xmenu.c (dialog_selection_callback): Likewise.
9293
ede49d71
PE
9294 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
9295 Also, don't assume VALBITS / RAND_BITS is less than 5,
9296 and don't rely on undefined behavior when shifting a 1 left into
9297 the sign bit.
9298 * lisp.h (get_random): Change signature to match.
9299
2f30ecd0
PE
9300 * lread.c (hash_string): Use size_t, not int, for hash computation.
9301 Normally we prefer signed values; but hashing is special, because
9302 it's better to use unsigned division on hash table sizes so that
9303 the remainder is nonnegative. Also, size_t is the natural width
9304 for hashing into memory. The previous code used 'int', which doesn't
9305 retain enough info to hash well into very large tables.
9306 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
9307
2a866e7b
PE
9308 * dbusbind.c: Don't possibly lose pointer info when converting.
9309 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9310 Use XPNTR rather than XHASH, so that the high-order bits of
9311 the pointer aren't lost when converting through void *.
9312
51639eac
PE
9313 * eval.c (Fautoload): Don't double-shift a pointer.
9314
92394119
PE
9315 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
9316
dbdb9a7c
JB
93172011-05-06 Juanma Barranquero <lekktu@gmail.com>
9318
9319 * gnutls.c (DEF_GNUTLS_FN):
9320 * image.c (DEF_IMGLIB_FN): Make function pointers static.
9321
db7a0b4f
AS
93222011-05-05 Andreas Schwab <schwab@linux-m68k.org>
9323
9324 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
9325 marker. (Bug#8610)
9326
cd394be1 93272011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
9328
9329 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
9330 New version that can reserve upto 2GB of heap space.
9331
f7ff1b0f 93322011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
9333
9334 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
9335
639c109b
TZ
93362011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
9337
9338 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
9339 `gnutls_certificate_set_x509_key_file'.
9340
d2127135
JB
93412011-05-05 Juanma Barranquero <lekktu@gmail.com>
9342
9343 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
9344 Update dependencies.
9345
e968f4f3
JB
93462011-05-04 Juanma Barranquero <lekktu@gmail.com>
9347
9348 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
9349 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
9350 Remove unused parameter `fildes'.
9351 * process.c (read_process_output, send_process): Don't pass it.
9352
84d358f0
JB
93532011-05-04 Juanma Barranquero <lekktu@gmail.com>
9354
9355 Fix previous change: the library cache is defined in w32.c.
9356 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
9357 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
9358
0898ca10
JB
93592011-05-04 Juanma Barranquero <lekktu@gmail.com>
9360
9361 Implement dynamic loading of GnuTLS on Windows.
9362
9363 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
9364 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
9365 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9366 Declare.
9367
9368 * gnutls.c (Qgnutls_dll): Define.
9369 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
9370 (gnutls_*): Declare function pointers.
9371 (init_gnutls_functions): New function to initialize function pointers.
9372 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
9373 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
9374 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9375 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
9376 (emacs_gnutls_write, emacs_gnutls_read)
9377 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
9378 (Fgnutls_available_p): New function.
9379 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
9380 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
9381 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
9382
9383 * image.c: Include w32.h.
9384 (Vimage_type_cache): Delete.
9385 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
9386 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
9387 (w32_delayed_load): Move to w32.c.
9388
9389 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
9390
9391 * w32.c (QCloaded_from, Vlibrary_cache): Define.
9392 (w32_delayed_load): Move from image.c. When loading a library, record
9393 its filename in the :loaded-from property of the library id.
9394 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
9395 Initialize and staticpro them.
9396 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
9397
9398 * process.c: Include lisp.h before w32.h, not after.
9399 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
9400 instead of gnutls_record_check_pending.
9401
9402 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
9403
ff4de4aa
TZ
94042011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
9405
9406 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
9407 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
9408 as passed in.
9409
abe95abb
JD
94102011-05-03 Jan Djärv <jan.h.d@swipnet.se>
9411
9412 * xterm.c (x_set_frame_alpha): Do not set property on anything
9413 else than FRAME_X_OUTER_WINDOW (Bug#8608).
9414
e16e55d4
JB
94152011-05-02 Juanma Barranquero <lekktu@gmail.com>
9416
9417 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
9418
bafcf6a5
JB
94192011-05-02 Juanma Barranquero <lekktu@gmail.com>
9420
9421 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
9422 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
9423 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
9424 (gnutls_global_initialized, Qgnutls_bootprop_priority)
9425 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
9426 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
9427 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
9428 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
9429 (Qgnutls_bootprop_callbacks_verify): Make static.
9430
e7a6747f
AS
94312011-05-01 Andreas Schwab <schwab@linux-m68k.org>
9432
19ed11ba
AS
9433 * callproc.c: Indentation fixup.
9434
e7a6747f 9435 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
9436 (wait_for_termination, interruptible_wait_for_termination):
9437 Move after wait_for_termination_1.
e7a6747f 9438
1ef14cb4
LMI
94392011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
9440
9441 * sysdep.c (interruptible_wait_for_termination): New function
9442 which is like wait_for_termination, but allows keyboard
9443 interruptions.
9444
9445 * callproc.c (Fcall_process): Add (:file "file") as an option for
9446 the STDOUT buffer.
9447 (Fcall_process_region): Ditto.
9448
330d880c
EZ
94492011-04-30 Eli Zaretskii <eliz@gnu.org>
9450
8db90b73
EZ
9451 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
9452 rather than `XVECTOR (FOO)->size'.
9453
330d880c
EZ
9454 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
9455 inttypes.h, as a gnulib replacement is used if it not available in
9456 system headers.
9457
15cbd324
EZ
94582011-04-21 Eli Zaretskii <eliz@gnu.org>
9459
9460 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
9461 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
9462 of MOST_POSITIVE_FIXNUM. (Bug#8528)
9463
9464 * coding.c (coding_alloc_by_realloc): Error out if destination
9465 will grow beyond MOST_POSITIVE_FIXNUM.
9466 (decode_coding_emacs_mule): Abort if there isn't enough place in
9467 charbuf for the composition carryover bytes. Reserve an extra
9468 space for up to 2 characters produced in a loop.
9469 (decode_coding_iso_2022): Abort if there isn't enough place in
9470 charbuf for the composition carryover bytes.
9471
94722011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 9473
ae940cca
EZ
9474 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
9475 aborting when %lld or %lll format is passed.
9476 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
9477 %llo or %llx format is passed. (Bug#8545)
9478
03ab8921
EZ
9479 * window.c (window_scroll_line_based): Use a marker instead of
9480 simple variables to record original value of point. (Bug#7952)
9481
afda1437
EZ
9482 * doprnt.c (doprnt): Fix the case where a multibyte sequence
9483 produced by %s or %c overflows available buffer space. (Bug#8545)
9484
f76dee0c
PE
94852011-04-28 Paul Eggert <eggert@cs.ucla.edu>
9486
9487 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 9488 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 9489
fdc5744d
JB
94902011-04-28 Juanma Barranquero <lekktu@gmail.com>
9491
9492 * w32.c (init_environment): Warn about defaulting HOME to C:\.
9493
638f053a
JB
94942011-04-28 Juanma Barranquero <lekktu@gmail.com>
9495
9496 * keyboard.c (Qdelayed_warnings_hook): Define.
9497 (command_loop_1): Run `delayed-warnings-hook'
9498 if Vdelayed_warnings_list is non-nil.
9499 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
9500 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
9501
d178f871
EZ
95022011-04-28 Eli Zaretskii <eliz@gnu.org>
9503
9504 * doprnt.c (doprnt): Don't return value smaller than the buffer
9505 size if the message was truncated. (Bug#8545).
9506
b124fd93
JB
95072011-04-28 Juanma Barranquero <lekktu@gmail.com>
9508
9509 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
9510 (Fx_window_property): #if-0 the whole functions, not just the bodies.
9511
e810457d
PE
95122011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9513
9514 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
9515
ea51cceb
JB
95162011-04-27 Juanma Barranquero <lekktu@gmail.com>
9517
9518 * makefile.w32-in: Update dependencies.
9519
94dcfacf
EZ
95202011-04-27 Eli Zaretskii <eliz@gnu.org>
9521
9522 Improve `doprnt' and its usage. (Bug#8545)
9523 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
9524 `format_end'. Remove support for %l as a conversion specifier.
9525 Don't use xrealloc. Improve diagnostics when the %l size modifier
9526 is used. Update the commentary.
9527
9528 * eval.c (verror): Simplify calculation of size_t.
9529
9530 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
9531 messages.
9532
f61f41d7
PE
95332011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
9534
9535 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
9536 change.
9537
96fb4434
PE
95382011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9539
9540 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
9541 This makes this file independent of the recent pseudovector change.
9542
671875da 95432011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 9544
69e9b5a3
PE
9545 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
9546
b5f869a7 9547 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 9548 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 9549 Remove unused local.
c8926152 9550 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 9551
841a1577 9552 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
9553 GCC 4.6.0 optimizes based on type-based alias analysis.
9554 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
9555 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
9556 != &v->size, and therefore "v->size = 1; b->size = 2; return
9557 v->size;" must therefore return 1. This assumption is incorrect
9558 for Emacs, since it type-puns struct Lisp_Vector * with many other
9559 types. To fix this problem, this patch adds a new type struct
f904488f 9560 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
9561 and pseudovectors, and helps optimizing compilers not get fooled
9562 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
9563 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
9564 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
9565 the size member.
eab3844f
PE
9566 (XSETPVECTYPE): Rewrite in terms of new macro.
9567 (XSETPVECTYPESIZE): New macro, specifying both type and size.
9568 This is a bit clearer, and further avoids the possibility of
9569 undesirable aliasing.
9570 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 9571 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
9572 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
9573 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
9574 (ASIZE): Now uses header.size rather than size.
9575 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
9576 to avoid the hassle of writing XVECTOR (foo)->header.size.
9577 (struct vectorlike_header): New type.
eab3844f
PE
9578 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
9579 object, to help avoid aliasing.
9580 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
9581 (SUBRP): Likewise, since Lisp_Subr is a special case.
9582 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
9583 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
9584 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 9585 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
9586 changed to be "header.size" and "header.next".
9587 * buffer.h (struct buffer): Likewise.
9588 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
9589 * frame.h (struct frame): Likewise.
9590 * process.h (struct Lisp_Process): Likewise.
9591 * termhooks.h (struct terminal): Likewise.
9592 * window.c (struct save_window_data, struct saved_window): Likewise.
9593 * window.h (struct window): Likewise.
9594 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
9595 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
9596 * buffer.c (init_buffer_once): Likewise.
9597 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
9598 special case.
9599 * process.c (Fformat_network_address): Use local var for size,
9600 for brevity.
9601
0df1eac5
PE
9602 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
9603
847ab9d1 9604 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
9605 * data.c (atof): Remove decl; no longer used or needed.
9606 (digit_to_number): Move to lread.c.
9607 (Fstring_to_number): Use new string_to_number function, to be
9608 consistent with how the Lisp reader treats infinities and NaNs.
9609 Do not assume that floating-point numbers represent EMACS_INT
9610 without losing information; this is not true on most 64-bit hosts.
9611 Avoid double-rounding errors, by insisting on integers when
9612 parsing non-base-10 numbers, as the documentation specifies.
9613 * lisp.h (string_to_number): New decl, replacing ...
9614 (isfloat_string): Remove.
bc0a5c13 9615 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 9616 (read1): Do not accept +. and -. as integers; this
452f4150
PE
9617 appears to have been a coding error. Similarly, do not accept
9618 strings like +-1e0 as floating point numbers. Do not report
9619 overflow for integer overflows unless the base is not 10 which
9620 means we have no simple and reliable way to continue.
9621 Break out the floating-point parsing into a new
9622 function string_to_number, so that Fstring_to_number parses
9623 floating point numbers consistently with the Lisp reader.
04f2d78b 9624 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
9625 (E_CHAR, EXP_INT): Remove, replacing with ...
9626 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
9627 (string_to_number): New function, replacing isfloat_string.
9628 This function checks for valid syntax and produces the resulting
9629 Lisp float number too. Rework it so that string-to-number
bc0a5c13 9630 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
9631 so that overflow for non-base-10 numbers is reported only when
9632 there's no portable and simple way to convert to floating point.
452f4150 9633
67769ffc
PE
9634 * textprop.c (set_text_properties_1): Rewrite for clarity,
9635 and to avoid GCC warning about integer overflow.
9636
c20db43f
PE
9637 * intervals.h (struct interval): Use EMACS_INT for members
9638 where EMACS_UINT might cause problems. See
9639 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
9640 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
9641 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
9642 All uses changed.
37aa2f85
PE
9643 (offset_intervals): Tell GCC not to worry about length overflow
9644 when negating a negative length.
c20db43f 9645
2538aa2f
PE
9646 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
9647 (overrun_check_free): Likewise.
9648
f2d3008d
PE
9649 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
9650 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
9651 word size.
9652
ec8df744
PE
9653 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9654 (gnutls_make_error): Rename local to avoid shadowing.
9655 (gnutls_emacs_global_deinit): ifdef out; not used.
9656 (Fgnutls_boot): Use const for pointer to readonly storage.
9657 Comment out unused local. Fix pointer signedness problems.
9658
640ee02d
PE
9659 * lread.c (openp): Don't stuff size_t into an 'int'.
9660 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
9661 about possible signed overflow.
9662
6048fb2a
PE
9663 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9664 (GDK_KEY_g): Don't define if already defined.
9665 (xg_prepare_tooltip): Avoid pointer signedness problem.
9666 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
9667
fa3c87e1
PE
9668 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
9669 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
9670
2172544b
PE
9671 * xfns.c (Fx_window_property): Simplify a bit,
9672 to make a bit faster and to avoid GCC 4.6.0 warning.
9673 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
9674
9b821a21
PE
9675 * fns.c (internal_equal): Don't assume size_t fits in int.
9676
3c616cfa
PE
9677 * alloc.c (compact_small_strings): Tighten assertion a little.
9678
c2982e87
PE
9679 Replace pEd with more-general pI, and fix some printf arg casts.
9680 * lisp.h (pI): New macro, generalizing old pEd macro to other
9681 conversion specifiers. For example, use "...%"pI"d..." rather
9682 than "...%"pEd"...".
9683 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 9684 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
9685 * alloc.c (check_pure_size): Don't overflow by converting size to int.
9686 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
9687 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
9688 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
9689 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
9690 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
9691 64-bit hosts.
9692 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
9693 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
9694 * print.c (safe_debug_print, print_object): Likewise.
9695 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
9696 to int.
6f04d126
PE
9697 Use pI instead of if-then-else-abort. Use %p to avoid casts,
9698 avoiding the 0 flag, which is not portable.
c2982e87
PE
9699 * process.c (Fmake_network_process): Use pI to avoid cast.
9700 * region-cache.c (pp_cache): Likewise.
9701 * xdisp.c (decode_mode_spec): Likewise.
9702 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
9703 behavior on 64-bit hosts with printf arg.
6f04d126 9704 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
9705 (x_stop_queuing_selection_requests): Likewise.
9706 (x_get_window_property): Don't truncate byte count to an 'int'
9707 when tracing.
0b432f21 9708
5e073ec7
PE
9709 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
9710 here, since it parses constructs like leading '-' and spaces,
9711 which are not wanted; and it overflows with large numbers.
9712 Instead, simply match F[0-9]+, which is what is wanted anyway.
9713
36372bf9
PE
9714 * alloc.c: Remove unportable assumptions about struct layout.
9715 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
9716 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
9717 (allocate_vectorlike, make_pure_vector): Use the new macros,
9718 plus offsetof, to remove unportable assumptions about struct layout.
9719 These assumptions hold on all porting targets that I know of, but
9720 they are not guaranteed, they're easy to remove, and removing them
9721 makes further changes easier.
9722
0b432f21
PE
9723 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
9724 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
9725 (string_overrun_cookie): Now const. Use initializers that
9726 don't formally overflow signed char, to avoid warnings.
000098c1
PE
9727 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
9728 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
9729 (allocate_buffer): Don't assume sizeof (struct buffer) is a
9730 multiple of sizeof (EMACS_INT); it need not be, if
9731 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 9732 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 9733
895009e1
JB
97342011-04-26 Juanma Barranquero <lekktu@gmail.com>
9735
9736 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
9737
6a7a1b0b
TZ
97382011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
9739
9740 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 9741 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
9742 Reported by Paul Eggert <eggert@cs.ucla.edu>.
9743
841a1577 97442011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
9745
9746 * lisp.h (Qdebug): List symbol.
895009e1 9747 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
9748 * keyboard.c (debug-on-event): New variable.
9749 (handle_user_signal): Break into debugger when debug-on-event
9750 matches the current signal symbol.
9751
f2d3ba6f
DN
97522011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
9753
9754 * alloc.c (check_sblock, check_string_bytes)
9755 (check_string_free_list): Convert to standard C.
9756
42ce4c63
TZ
97572011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
9758
9759 * w32.c (emacs_gnutls_push): Fix typo.
9760
825cd63c
EZ
97612011-04-25 Eli Zaretskii <eliz@gnu.org>
9762
fb11d64d
EZ
9763 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
9764 "cast to pointer from integer of different size".
9765
825cd63c
EZ
9766 Improve doprnt and its use in verror. (Bug#8545)
9767 * doprnt.c (doprnt): Document the set of format control sequences
9768 supported by the function. Use SAFE_ALLOCA instead of always
9769 using `alloca'.
9770
9771 * eval.c (verror): Don't limit the buffer size at size_max-1, that
9772 is one byte too soon. Don't use xrealloc; instead xfree and
9773 xmalloc anew.
9774
e061a11b
TZ
97752011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
9776
9777 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
9778 callbacks stage.
9779
9780 * gnutls.c: Renamed global_initialized to
9781 gnutls_global_initialized. Added internals for the
9782 :verify-hostname-error, :verify-error, and :verify-flags
9783 parameters of `gnutls-boot' and documented those parameters in the
9784 docstring. Start callback support.
9173deec
JB
9785 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
9786 unless a fatal error occurred. Call gnutls_alert_send_appropriate
9787 on error. Return error code.
e061a11b
TZ
9788 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
9789 (emacs_gnutls_read): Likewise.
9790 (Fgnutls_boot): Return handshake error code.
9791 (emacs_gnutls_handle_error): New function.
9792 (wsaerror_to_errno): Likewise.
9793
9794 * w32.h (emacs_gnutls_pull): Add prototype.
9795 (emacs_gnutls_push): Likewise.
9796
9797 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
9798 (emacs_gnutls_push): Likewise.
9799
98002011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
9801
9802 * process.c (wait_reading_process_output): Check if GnuTLS
9803 buffered some data internally if no FDs are set for TLS
9804 connections.
9805
9806 * makefile.w32-in (OBJ2): Add gnutls.$(O).
9807 (LIBS): Link to USER_LIBS.
9808 ($(BLD)/gnutls.$(0)): New target.
9809
fa6996bc
EZ
98102011-04-24 Eli Zaretskii <eliz@gnu.org>
9811
eb35682e
EZ
9812 * xdisp.c (handle_single_display_spec): Rename the
9813 display_replaced_before_p argument into display_replaced_p, to
9814 make it consistent with the commentary. Fix typos in the
9815 commentary.
9816
e2ad650c
EZ
9817 * textprop.c (syms_of_textprop): Remove dead code.
9818 (copy_text_properties): Delete obsolete commentary about an
9819 interface that was deleted long ago. Fix typos in the description
9820 of arguments.
9821
1b2de274
EZ
9822 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
9823 to changes in oldXMenu/XMenu.h from 2011-04-16.
9824 <menu_help_message, prev_menu_help_message>: Constify.
9825 (IT_menu_make_room): menu->help_text is now `const char **';
9826 adjust.
9827
9828 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
9829 to changes in oldXMenu/XMenu.h from 2011-04-16.
9830 (struct XMenu): Declare `help_text' `const char **'.
9831
9832 * xfaces.c <Qunspecified>: Make extern again.
9833
9834 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 9835 required by POSIX.
1b2de274 9836
762b15be
EZ
9837 * doc.c (get_doc_string): Improve the format passed to `error'.
9838
9839 * doprnt.c (doprnt): Improve commentary.
9840
9841 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
9842
9843 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
9844 them with etags.
9845
f1052e5d
EZ
9846 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
9847 changes in globals.h immediately force recompilation.
762b15be
EZ
9848 (TAGS): Depend on $(CURDIR)/m/intel386.h and
9849 $(CURDIR)/s/ms-w32.h.
9850 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 9851
fa6996bc
EZ
9852 * character.c (Fchar_direction): Function deleted.
9853 (syms_of_character): Don't defsubr it.
9854 <char-direction-table>: Deleted.
9855
e6c3da20
EZ
98562011-04-23 Eli Zaretskii <eliz@gnu.org>
9857
9858 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
9859 * doprnt.c: Include limits.h.
9860 (SIZE_MAX): New macro.
04f2d78b
CB
9861 (doprnt): Return a size_t value. 2nd arg is now size_t.
9862 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
9863 Improve overflow protection. Support `l' modifier for integer
9864 conversions. Support %l conversion. Don't assume an EMACS_INT
9865 argument for integer conversions and for %c.
9866
9867 * lisp.h (doprnt): Restore prototype.
9868
9869 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
9870 $(SRC)/character.h.
9871
9872 * Makefile.in (base_obj): Add back doprnt.o.
9873
9874 * deps.mk (doprnt.o): Add back prerequisites.
9875 (callint.o): Depend on character.h.
9876
9877 * eval.c (internal_lisp_condition_case): Include the handler
9878 representation in the error message.
9879 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
9880 when breaking from the loop.
9881
9882 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
9883
9884 * callint.c (Fcall_interactively): When displaying error message
9885 about invalid control letter, pass the character's codepoint, not
9886 a pointer to its multibyte form. Improve display of the character
9887 in octal and display also its hex code.
9888
9889 * character.c (char_string): Use %x to display the (unsigned)
9890 codepoint of an invalid character, to avoid displaying a bogus
9891 negative value.
9892
9893 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
9894 `error', not SYMBOL_NAME itself.
9895
9896 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
9897 character arguments to `error'.
9898
9899 * charset.c (check_iso_charset_parameter): Fix incorrect argument
9900 to `error' in error message about FINAL_CHAR argument. Make sure
9901 FINAL_CHAR is a character, and use %c when it is passed as
9902 argument to `error'.
9903
4ffd0d6b 99042011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
9905
9906 * s/ms-w32.h (localtime): Redirect to sys_localtime.
9907
9908 * w32.c: Include <time.h>.
9909 (sys_localtime): New function.
9910
4ffd0d6b 99112011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
9912
9913 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
9914
4ffd0d6b 9915 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 9916
4ffd0d6b 99172011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 9918
4ffd0d6b
GM
9919 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
9920 zombies (Bug#8467).
aac0c6e3 9921
04c56954
EZ
99222011-04-19 Eli Zaretskii <eliz@gnu.org>
9923
9924 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
9925 gl_state.e_property when gl_state.object is Qt.
9926
9927 * insdel.c (make_gap_larger): Remove limitation of buffer size
9928 to <= INT_MAX.
9929
16a43933
CY
99302011-04-18 Chong Yidong <cyd@stupidchicken.com>
9931
9932 * xdisp.c (lookup_glyphless_char_display)
9933 (produce_glyphless_glyph): Handle cons cell entry in
9934 glyphless-char-display.
9935 (Vglyphless_char_display): Document it.
9936
9937 * term.c (produce_glyphless_glyph): Handle cons cell entry in
9938 glyphless-char-display.
9939
4581706e
CY
99402011-04-17 Chong Yidong <cyd@stupidchicken.com>
9941
9942 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
9943
9944 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
9945
9946 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
9947 definition for no-X builds.
9948
4887c6e2 99492011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 9950
fd35b6f9
PE
9951 Static checks with GCC 4.6.0 and non-default toolkits.
9952
5c1ccb01
PE
9953 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
9954
006c5daa
PE
9955 * process.c (keyboard_bit_set): Define only if SIGIO.
9956 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
9957 (send_process): Repair possible setjmp clobbering.
9958
efc736d3
PE
9959 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
9960
4e2fe2e6
PE
9961 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
9962
f97334a2
PE
9963 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
9964
4e75f29d
PE
9965 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
9966 Define only if needed.
9967
90efadd1
PE
9968 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
9969 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 9970 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 9971
3c647824
PE
9972 * dispextern.h (struct redisplay_interface): Rename param
9973 to avoid shadowing.
e264f262 9974 * termhooks.h (struct terminal): Likewise.
761383f4 9975 * xterm.c (xembed_send_message): Likewise.
3c647824 9976
b58c5c4a
PE
9977 * insdel.c (make_gap_smaller): Define only if
9978 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
9979
cad59032
PE
9980 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
9981 it.
9982
c339dc2e
PE
9983 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
9984 so that we aren't warned about unused symbols.
9985
91a3e27b
PE
9986 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
9987
399c71d3 9988 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 9989
8ffc96f5
PE
9990 * xfns.c (x_real_positions): Mark locals as initialized.
9991
eef9bc79
PE
9992 * xmenu.c (xmenu_show): Don't use uninitialized vars.
9993
098db9dd
PE
9994 * xterm.c: Fix problems found by static analysis with other toolkits.
9995 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
9996 (x_dispatch_event): Declare static if USE_GTK, and
9997 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 9998 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 9999 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
10000 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
10001 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 10002
eb18f6cc
PE
10003 * xmenu.c (menu_help_callback): Pointer type fixes.
10004 Use const pointers when pointing at readonly data. Avoid pointer
10005 signedness clashes.
10006 (FALSE): Remove unused macro.
10007 (update_frame_menubar): Remove unused decl.
10008
1fe72bf8
PE
10009 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
10010
60d9e1db
PE
10011 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
10012 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
10013 (single_menu_item): Rename local to avoid shadowing.
10014
39261c26
PE
10015 * keyboard.c (make_lispy_event): Remove unused local var.
10016
018c5e19
PE
10017 * frame.c, frame.h (x_get_resource_string): Bring this back, but
10018 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
10019
63d2b86e
PE
10020 * bitmaps: Change bitmaps from unsigned char back to the X11
10021 compatible char. Avoid the old compiler warnings about
10022 out-of-range initializers by using, for example, '\xab' rather
10023 than 0xab.
10024
aefd87e1
PE
10025 * xgselect.c (xgselect_initialize): Check vs interface
10026 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
10027
bf501fb9
PE
10028 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
10029
e9829fdf
PE
10030 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
10031 to read-only memory.
10032
1086c095
PE
10033 * fns.c (vector): Remove; this old hack is no longer needed.
10034
2baccd04 10035 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 10036 Remove unused var.
dde42981 10037 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 10038
72391843 10039 * xrdb.c (x_load_resources): Omit unused local.
3565b346 10040
436c16df 10041 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 10042 (x_window): Rename locals to avoid shadowing.
dc5ddd85 10043 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 10044
92bb796d 10045 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 10046 (x_term_init): Remove local to avoid shadowing.
92bb796d 10047
764430a3 10048 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
10049
10050 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
10051 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
10052
d1dfb56c
EZ
100532011-04-16 Eli Zaretskii <eliz@gnu.org>
10054
c4354cb4
EZ
10055 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
10056
d1dfb56c
EZ
10057 Fix regex.c, syntax.c and friends for buffers > 2GB.
10058 * syntax.h (struct gl_state_s): Declare character position members
10059 EMACS_INT.
10060
10061 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
10062
04f2d78b
CB
10063 * textprop.c (verify_interval_modification, interval_of):
10064 Declare arguments EMACS_INT.
d1dfb56c
EZ
10065
10066 * intervals.c (adjust_intervals_for_insertion): Declare arguments
10067 EMACS_INT.
10068
10069 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
10070
10071 * indent.c (Fvertical_motion): Local variable it_start is now
10072 EMACS_INT.
10073
10074 * regex.c (re_match, re_match_2, re_match_2_internal)
10075 (bcmp_translate, regcomp, regexec, print_double_string)
10076 (group_in_compile_stack, re_search, re_search_2, regex_compile)
10077 (re_compile_pattern, re_exec): Declare arguments and local
10078 variables `size_t' and `ssize_t' and return values `regoff_t', as
10079 appropriate.
10080 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
10081 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
10082 <compile_stack_type>: `size' and `avail' are now `size_t'.
10083
10084 * regex.h <regoff_t>: Use ssize_t, not int.
10085 (re_search, re_search_2, re_match, re_match_2): Arguments that
10086 specify buffer/string position and length are now ssize_t and
10087 size_t. Return type is regoff_t.
10088
613052cd
BK
100892011-04-16 Ben Key <bkey76@gmail.com>
10090
10091 * nsfont.m: Fixed bugs in ns_get_family and
10092 ns_descriptor_to_entity that were caused by using free to
10093 deallocate memory blocks that were allocated by xmalloc (via
10094 xstrdup). This caused Emacs to crash when compiled with
10095 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
10096 --enable-checking=xmallocoverrun). xfree is now used to
10097 deallocate these memory blocks.
10098
4170f62f 100992011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 10100
71b41406
PE
10101 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
10102
9587a89d
PE
10103 emacs_write: Accept and return EMACS_INT for sizes.
10104 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
10105 et seq.
10106 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
10107 Accept and return EMACS_INT.
10108 (emacs_gnutls_write): Return the number of bytes written on
10109 partial writes.
10110 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
10111 (emacs_read, emacs_write): Remove check for negative size, as the
10112 Emacs source code has been audited now.
9587a89d
PE
10113 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
10114 (emacs_read, emacs_write): Use it.
273a5f82
PE
10115 * process.c (send_process): Adjust to the new signatures of
10116 emacs_write and emacs_gnutls_write. Do not attempt to store
10117 a byte offset into an 'int'; it might overflow.
9587a89d 10118 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 10119
3e047f51
PE
10120 * sound.c: Don't assume sizes fit in 'int'.
10121 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 10122 Return EMACS_INT, not int.
3e047f51 10123 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
10124 Accept EMACS_INT, not int.
10125 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
10126 record read return values.
10127
cc39a9db
BK
101282011-04-15 Ben Key <bkey76@gmail.com>
10129
c9d0ec6d
JB
10130 * keyboard.c (Qundefined): Don't declare static since it is used
10131 in nsfns.m.
10132 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
10133 static since they are used in nsfont.m.
cc39a9db 10134
6c60eb9f
SM
101352011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
10136
10137 * process.c (Qprocessp): Don't declare static.
10138 * lisp.h (Qprocessp): Declare again.
10139
7990b61a
JB
101402011-04-15 Juanma Barranquero <lekktu@gmail.com>
10141
10142 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
10143
5d4cb038
PE
101442011-04-14 Paul Eggert <eggert@cs.ucla.edu>
10145
8bd7b830 10146 Improve C-level modularity by making more things 'static'.
cd64ea1d 10147
e3b27b31
PE
10148 Don't publish debugger-only interfaces to other modules.
10149 * lisp.h (safe_debug_print, debug_output_compilation_hack):
10150 (verify_bytepos, count_markers): Move decls to the only modules
10151 that need them.
10152 * region-cache.h (pp_cache): Likewise.
10153 * window.h (check_all_windows): Likewise.
10154 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
10155
5d4cb038
PE
10156 * sysdep.c (croak): Now static, if
10157 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
10158 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
10159
10160 * alloc.c (refill_memory_reserve): Now static if
10161 !defined REL_ALLOC || defined SYSTEM_MALLOC.
10162 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 10163
e87b6180
PE
10164 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
10165 Define only if USE_LUCID.
10166
ac64929e
PE
10167 * xrdb.c (x_customization_string, x_rm_string): Now static.
10168
6f37259d
PE
10169 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
10170 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
10171
1683e3ab
PE
10172 * xdisp.c (draw_row_with_mouse_face): Now static.
10173 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
10174
de9c2632
PE
10175 * window.h (check_all_windows): Mark externally visible.
10176
2b96acb7
PE
10177 * window.c (window_deletion_count): Now static.
10178
10179 * undo.c: Make symbols static if they're not exported.
10180 (last_undo_buffer, last_boundary_position, pending_boundary):
10181 Now static.
10182
50436f33
PE
10183 * textprop.c (interval_insert_behind_hooks): Now static.
10184 (interval_insert_in_front_hooks): Likewise.
10185
64520e5c
PE
10186 * term.c: Make symbols static if they're not exported.
10187 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
10188 (max_frame_lines, tty_set_terminal_modes):
10189 (tty_reset_terminal_modes, tty_turn_off_highlight):
10190 (get_tty_terminal): Now static.
10191 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
10192 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 10193 HAVE_WINDOW_SYSTEM.
64520e5c
PE
10194 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
10195 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
10196
1fa53021
PE
10197 * sysdep.c: Make symbols static if they're not exported.
10198 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
10199 Now static.
10200 (sigprocmask_set, full_mask): Remove; unused.
10201 (wait_debugging): Mark as visible.
10202 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
10203 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
10204
d4b43b22
PE
10205 * syntax.c (syntax_temp): Define only if !__GNUC__.
10206
b7c513d0
PE
10207 * sound.c (current_sound_device, current_sound): Now static.
10208
989b29ad
PE
10209 * search.c (searchbufs, searchbuf_head): Now static.
10210
13a55a78
PE
10211 * scroll.c (scroll_cost): Remove; unused.
10212 * dispextern.h (scroll_cost): Remove decl.
10213
de68a1fc
PE
10214 * region-cache.h (pp_cache): Mark as externally visible.
10215
40ccffa6
PE
10216 * process.c: Make symbols static if they're not exported.
10217 (process_tick, update_tick, create_process, chan_process):
10218 (Vprocess_alist, proc_buffered_char, datagram_access):
10219 (fd_callback_data, send_process_frame, process_sent_to): Now static.
10220 (deactivate_process): Mark defn as static, as well as decl.
10221 * lisp.h (create_process): Remove decl.
10222 * process.h (chan_process, Vprocess_alist): Remove decls.
10223
ad64fc97
PE
10224 * print.c: Make symbols static if they're not exported.
10225 (print_depth, new_backquote_output, being_printed, print_buffer):
10226 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
10227 (print_interval, print_number_index, initial_stderr_stream):
10228 Now static.
10229 * lisp.h (Fprinc): Remove decl.
10230 (debug_output_compilation_hack): Mark as externally visible.
10231
adddb265
PE
10232 * sysdep.c (croak): Move decl from here to syssignal.h.
10233 * syssignal.h (croak): Put it here, so the API can be checked when
10234 'croak' is called from dissociate_if_controlling_tty.
10235
1717ede2
PE
10236 * minibuf.c: Make symbols static if they're not exported.
10237 (minibuf_save_list, choose_minibuf_frame): Now static.
10238 * lisp.h (choose_minibuf_frame): Remove decl.
10239
fa5fb2bc
PE
10240 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
10241
1e3890d1
PE
10242 * lread.c: Make symbols static if they're not exported.
10243 (read_objects, initial_obarray, oblookup_last_bucket_number):
10244 Now static.
10245 (make_symbol): Remove; unused.
10246 * lisp.h (initial_obarray, make_symbol): Remove decls.
10247
8a1414fa
PE
10248 * keyboard.c: Make symbols static if they're not exported.
10249 (single_kboard, recent_keys_index, total_keys, recent_keys):
10250 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
10251 (this_single_command_key_start, echoing, last_auto_save):
10252 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
10253 (command_loop, echo_now, keyboard_init_hook, help_char_p):
10254 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
10255 (Vlispy_mouse_stem, double_click_count):
10256 Now static.
10257 (force_auto_save_soon): Define only if SIGDANGER.
10258 (ignore_mouse_drag_p): Now static if
10259 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
10260 (print_help): Remove; unused.
10261 (stop_character, last_timer_event): Mark as externally visible.
10262 * keyboard.h (ignore_mouse_drag_p): Declare only if
10263 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
10264 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
10265 * lisp.h (echoing): Remove decl.
10266 (force_auto_save_soon): Declare only if SIGDANGER.
10267 * xdisp.c (redisplay_window): Simplify code, to make it more
10268 obvious that ignore_mouse_drag_p is not accessed if !defined
10269 USE_GTK && !defined HAVE_NS.
10270
93ea6e8f
PE
10271 * intervals.c: Make symbols static if they're not exported.
10272 (merge_properties_sticky, merge_interval_right, delete_interval):
10273 Now static.
10274 * intervals.h (merge_interval_right, delete_interval): Remove decls.
10275
77382fcc
PE
10276 * insdel.c: Make symbols static if they're not exported.
10277 However, leave prepare_to_modify_buffer alone. It's never
10278 called from outside this function, but that appears to be a bug.
10279 (combine_after_change_list, combine_after_change_buffer):
4889fc82 10280 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
10281 (adjust_after_replace_noundo): Remove; unused.
10282 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 10283 (signal_before_change): Remove decls.
77382fcc 10284
9306c32e
PE
10285 * indent.c (val_compute_motion, val_vmotion): Now static.
10286
cd44d2eb
PE
10287 * image.c: Make symbols static if they're not exported.
10288 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
10289 if USE_GTK.
10290 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
10291 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
10292
ad9a7a06
PE
10293 * fringe.c (standard_bitmaps): Now static.
10294 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
10295
81626931
PE
10296 * frame.c: Make symbols static if they're not exported.
10297 (x_report_frame_params, make_terminal_frame): Now static.
10298 (get_frame_param): Now static, unless HAVE_NS.
10299 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
10300 (x_get_resource_string): Remove; not used.
10301 * frame.h (make_terminal_frame, x_report_frame_params):
10302 (x_get_resource_string); Remove decls.
10303 (x_fullscreen_adjust): Declare only if WINDOWSNT.
10304 * lisp.h (get_frame_param): Declare only if HAVE_NS.
10305
239f9db9
PE
10306 * font.c, fontset.c: Make symbols static if they're not exported.
10307 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
10308 (FACE_SUITABLE_FOR_CHAR_P): Use it.
10309 * font.c (font_close_object): Now static.
10310 * font.h (font_close_object): Remove.
10311 * fontset.c (FONTSET_OBJLIST): Remove.
10312 (free_realized_fontset) #if-0 the body, which does nothing.
10313 (face_suitable_for_char_p): #if-0, as it's never called.
10314 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
10315 * xfaces.c (face_at_string_position):
10316 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
10317 since 0 is always ASCII.
10318
dfcf3579
PE
10319 * fns.c (weak_hash_tables): Now static.
10320
5045092b
PE
10321 * fileio.c: Make symbols static if they're not exported.
10322 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
10323 (Vwrite_region_annotation_buffers): Now static.
10324
57a96f5c
PE
10325 * eval.c: Make symbols static if they're not exported.
10326 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
10327 * lisp.h (backtrace_list): Remove decl.
10328
35f08c38
PE
10329 * emacs.c: Make symbols static if they're not exported.
10330 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
10331 (fatal_error_code, fatal_error_signal_hook, standard_args):
10332 Now static.
10333 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
10334 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
10335 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
10336 * lisp.h (fatal_error_signal_hook): Remove decl.
10337 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
10338
f44bd759
PE
10339 * editfns.c: Move a (normally-unused) function to its only use.
10340 * editfns.c, lisp.h (get_operating_system_release): Remove.
10341 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
10342 worth the hassle of breaking this out.
10343
b532497d
PE
10344 * xterm.c: Make symbols static if they're not exported.
10345 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
10346 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
10347 (x_destroy_window, x_delete_display):
10348 Now static.
10349 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
10350 (x_mouse_leave): Remove; unused.
10351 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
10352 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
10353 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
10354 Remove decls.
10355 (x_mouse_leave): Declare only if WINDOWSNT.
10356 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
10357 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
10358 USE_X_TOOLKIT.
10359
1675728f
PE
10360 * ftxfont.c: Make symbols static if they're not exported.
10361 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
10362 HAVE_FREETYPE.
10363 * font.h (ftxfont_driver): Likewise.
10364
e4cebfca
PE
10365 * xfns.c: Make symbols static if they're not exported.
10366 (x_last_font_name, x_display_info_for_name):
10367 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
10368 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
10369 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
10370 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
10371 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
10372 (last_show_tip_args): Now static.
10373 (xic_defaut_fontset, xic_create_fontsetname): Define only if
10374 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
10375 (x_screen_planes): Remove; unused.
10376 * dispextern.h (x_screen_planes): Remove decl.
10377
5bf46f05
PE
10378 * dispnew.c: Make symbols static if they're not exported.
10379 * dispextern.h (redraw_garbaged_frames, scrolling):
10380 (increment_row_positions): Remove.
10381 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
10382 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
10383 Now static.
10384 (redraw_garbaged_frames): Remove; unused.
10385
435f4c28
PE
10386 * xfaces.c: Make symbols static if they're not exported.
10387 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
10388 Remove decls.
10389 * xterm.h (defined_color): Remove decls.
10390 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
10391 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
10392 (menu_face_changed_default, defined_color, free_realized_face):
10393 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
10394 (ascii_face_of_lisp_face): Remove; unused.
10395
8524aef3
PE
10396 * xdisp.c: Make symbols static if they're not exported.
10397 * dispextern.h (scratch_glyph_row, window_box_edges):
10398 (glyph_to_pixel_coords, set_cursor_from_row):
10399 (get_next_display_element, set_iterator_to_next):
10400 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
10401 (show_mouse_face): Remove decls
10402 * frame.h (message_buf_print): Likewise.
10403 * lisp.h (pop_message, set_message, check_point_in_composition):
10404 Likewise.
10405 * xterm.h (set_vertical_scroll_bar): Likewise.
10406 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
10407 (message_buf_print, scratch_glyph_row, displayed_buffer):
10408 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
10409 (get_next_display_element, show_mouse_face, window_box_edges):
10410 (frame_to_window_pixel_xy, check_point_in_composition):
10411 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
10412 (glyph_to_pixel_coords): Remove; unused.
10413
16390cd2
PE
10414 * dired.c (file_name_completion): Now static.
10415
10416 * dbusbind.c (xd_in_read_queued_messages): Now static.
10417
a25f4dfa
PE
10418 * lisp.h (circular_list_error, FOREACH): Remove; unused.
10419 * data.c (circular_list_error): Remove.
10420
14a9c8df
PE
10421 * commands.h (last_point_position, last_point_position_buffer):
10422 (last_point_position_window): Remove decls.
10423 * keyboard.c: Make these variables static.
10424
04f2d78b
CB
10425 * coding.h (coding, code_convert_region, encode_coding_gap):
10426 Remove decls.
74ab6df5
PE
10427 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
10428 (iso_code_class, detect_coding, code_convert_region): Now static.
10429 (encode_coding_gap): Remove; unused.
10430
38dfbee1
PE
10431 * chartab.c (chartab_chars, chartab_bits): Now static.
10432
a2cb4e63
PE
10433 * charset.h (charset_iso_8859_1): Remove decl.
10434 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
10435 Now static.
10436
127198fd
PE
10437 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
10438 * ccl.c (Vccl_program_table): Now static.
10439 (check_ccl_update): Remove; unused.
10440
d85b608f
PE
10441 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
10442 * category.h: ... from here.
10443 * category.c (check_category_table, set_category_set): Now static.
10444
31cd66f3
PE
10445 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
10446 * lisp.h: Remove these decls.
10447
c358e587
PE
10448 * buffer.c (buffer_count): Remove unused var.
10449
e78aecca
PE
10450 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
10451 so that it's not optimized away.
10452 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
10453 * dispextern.h (bidi_dump_cached_states): Remove, since it's
10454 exported only to the debugger.
10455
e192d7d3 10456 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 10457 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 10458
92470028
PE
10459 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
10460 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
10461 was inaccessible from Lisp.
10462 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
10463 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
10464
244ed907
PE
10465 alloc.c: Import and export fewer symbols, and remove unused items.
10466 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
10467 is defined.
10468 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
10469 it's not optimized away by whole-program optimization.
10470 (message_enable_multibyte, free_misc): Remove.
10471 (catchlist, handlerlist, mark_backtrace):
10472 Declare only if BYTE_MARK_STACK.
10473 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
10474 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
10475 (message_enable_multibyte): Remove decl.
10476 (free_misc, interval_free_list, float_block, float_block_index):
10477 (n_float_blocks, float_free_list, cons_block, cons_block_index):
10478 (cons_free_list, last_marked_index):
10479 Now static.
10480 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
10481 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
10482 (mark_backtrace): Define only if BYTE_MARK_STACK.
10483 * xdisp.c (message_enable_multibyte): Now static.
10484
61c2b50e 10485 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
10486 This makes it easier for human readers (and static analyzers)
10487 to see whether these variables are used from other modules.
10488 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
10489 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
10490 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
10491 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
10492 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
10493 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
10494 * xmenu.c, xselect.c:
10495 Declare Q* vars static if they are not used in other modules.
10496 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
10497 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
10498 Remove decls of unexported vars.
10499 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
10500
95c82688
PE
10501 * lisp.h (DEFINE_FUNC): Make sname 'static'.
10502
16a97296
PE
10503 Make Emacs functions such as Fatom 'static' by default.
10504 This makes it easier for human readers (and static analyzers)
10505 to see whether these functions can be called from other modules.
10506 DEFUN now defines a static function. To make the function external
10507 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
10508 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
10509 (Finit_image_library):
16a97296
PE
10510 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
10511 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
10512 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
10513 Remove decls, since these functions are now static.
10514 (Funintern, Fget_internal_run_time): New decls, since these functions
10515 were already external.
95c82688 10516
16a97296
PE
10517 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
10518 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
10519 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
10520 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
10521 * keyboard.c, keymap.c, lread.c:
10522 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
10523 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
10524 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
10525 Mark functions with DEFUE instead of DEFUN,
10526 if they are used in other modules.
10527 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
10528 decls for now-static functions.
10529 * buffer.h (Fdelete_overlay): Remove decl.
10530 * callproc.c (Fgetenv_internal): Mark as internal.
10531 * composite.c (Fremove_list_of_text_properties): Remove decl.
10532 (Fcomposition_get_gstring): New forward static decl.
10533 * composite.h (Fcomposite_get_gstring): Remove decl.
10534 * dired.c (Ffile_attributes): New forward static decl.
10535 * doc.c (Fdocumntation_property): New forward static decl.
10536 * eval.c (Ffetch_bytecode): New forward static decl.
10537 (Funintern): Remove extern decl; now in .h file where it belongs.
10538 * fileio.c (Fmake_symbolic_link): New forward static decl.
10539 * image.c (Finit_image_library): New forward static decl.
10540 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
10541 * intervals.h (Fprevious_property_change):
10542 (Fremove_list_of_text_properties): Remove decls.
10543 * keyboard.c (Fthis_command_keys): Remove decl.
10544 (Fcommand_execute): New forward static decl.
10545 * keymap.c (Flookup_key): New forward static decl.
10546 (Fcopy_keymap): Now static.
10547 * keymap.h (Flookup_key): Remove decl.
10548 * process.c (Fget_process): New forward static decl.
10549 (Fprocess_datagram_address): Mark as internal.
10550 * syntax.c (Fsyntax_table_p): New forward static decl.
10551 (skip_chars): Remove duplicate decl.
10552 * textprop.c (Fprevious_property_change): New forward static decl.
10553 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
10554 Now internal.
10555 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
10556 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
10557
785bbd42
PE
10558 * editfns.c (Fformat): Remove unreachable code.
10559
8b913b57
AS
105602011-04-14 Andreas Schwab <schwab@linux-m68k.org>
10561
10562 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
10563 change. (Bug#8496)
10564
a6744a35
EZ
105652011-04-13 Eli Zaretskii <eliz@gnu.org>
10566
10567 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
10568 when at ZV. (Bug#8487)
10569
e7974947
AS
105702011-04-12 Andreas Schwab <schwab@linux-m68k.org>
10571
baad03f0
AS
10572 * charset.c (Fclear_charset_maps): Use xfree instead of free.
10573 (Bug#8437)
10574 * keyboard.c (parse_tool_bar_item): Likewise.
10575 * sound.c (sound_cleanup, alsa_close): Likewise.
10576 * termcap.c (tgetent): Likewise.
10577 * xfns.c (x_default_font_parameter): Likewise.
10578 * xsettings.c (read_and_apply_settings): Likewise.
10579
e7974947
AS
10580 * alloc.c (overrun_check_malloc, overrun_check_realloc)
10581 (overrun_check_free): Protoize.
10582
28272684
PE
105832011-04-12 Paul Eggert <eggert@cs.ucla.edu>
10584
10585 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
10586 since callers should never pass a negative size.
10587 Change the signature to match that of plain 'read' and 'write'; see
10588 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
10589 * lisp.h: Update prototypes of emacs_write and emacs_read.
10590
11997c76
EZ
105912011-04-11 Eli Zaretskii <eliz@gnu.org>
10592
10593 * xdisp.c (redisplay_window): Don't try to determine the character
10594 position of the scroll margin if the window start point w->startp
e896f03c 10595 is outside the buffer's accessible region. (Bug#8468)
11997c76 10596
8a2cbd72
EZ
105972011-04-10 Eli Zaretskii <eliz@gnu.org>
10598
10599 Fix write-region and its subroutines for buffers > 2GB.
10600 * fileio.c (a_write, e_write): Modify declaration of arguments and
10601 local variables to support buffers larger than 2GB.
10602 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
10603
10604 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
10605 argument, local variables, and return value.
10606
10607 * lisp.h: Update prototypes of emacs_write and emacs_read.
10608
10609 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
10610
4073e537 106112011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 10612
1ebfdcb6
PE
10613 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
10614
b2ded58d
PE
10615 Fix more problems found by GCC 4.6.0's static checks.
10616
7d66342c
PE
10617 * xdisp.c (vmessage): Use a better test for character truncation.
10618
bbf47d44
PE
10619 * charset.c (load_charset_map): <, not <=, for optimization,
10620 and to avoid potential problems with integer overflow.
9248994d 10621 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 10622 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 10623 * editfns.c (Fformat): Likewise.
1e69125e 10624 * syntax.c (skip_chars): Likewise.
3befa583 10625
e3019616
PE
10626 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
10627 This also lets GCC 4.6.0 generate slightly better loop code.
10628
becfa255
PE
10629 * callint.c (Fcall_interactively): <, not <=, for optimization.
10630 (Fcall_interactively): Count the number of arguments produced,
10631 not the number of arguments given. This is simpler and lets GCC
10632 4.6.0 generate slightly better code.
10633
dae0cd48
PE
10634 * ftfont.c: Distingish more carefully between FcChar8 and char.
10635 The previous code passed unsigned char * to a functions like
10636 strlen and xstrcasecmp that expect char *, which does not
10637 conform to the C standard.
10638 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
10639 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
10640 char * when the C standard requires it.
10641
76032d70
PE
10642 * keyboard.c (read_char): Remove unused var.
10643
eb3f1cc8
PE
10644 * eval.c: Port to Windows vsnprintf (Bug#8435).
10645 Include <limits.h>.
10646 (SIZE_MAX): Define if the headers do not.
10647 (verror): Do not give up if vsnprintf returns a negative count.
10648 Instead, grow the buffer. This ports to Windows vsnprintf, which
10649 does not conform to C99. Problem reported by Eli Zaretskii.
10650 Also, simplify the allocation scheme, by avoiding the need for
10651 calling realloc, and removing the ALLOCATED variable.
10652
70476b54
PE
10653 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
10654
12020a9e
PE
10655 Remove invocations of doprnt, as Emacs now uses vsnprintf.
10656 But keep the doprint source code for now, as we might revamp it
10657 and use it again (Bug#8435).
ea6c7ae6
PE
10658 * lisp.h (doprnt): Remove.
10659 * Makefile.in (base_obj): Remove doprnt.o.
10660 * deps.mk (doprnt.o): Remove.
10661
5fdb398c
PE
10662 error: Print 32- and 64-bit integers portably (Bug#8435).
10663 Without this change, on typical 64-bit hosts error ("...%d...", N)
10664 was used to print both 32- and 64-bit integers N, which relied on
10665 undefined behavior.
61bdb816 10666 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
10667 * lisp.h (error, verror): Mark as printf-like functions.
10668 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
10669 Report overflow in size calculations when allocating printf buffer.
10670 Do not truncate output string at its first null byte.
10671 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
10672 Truncate the output at a character boundary, since vsnprintf does not
10673 do that.
10674 * charset.c (check_iso_charset_parameter): Convert internal
10675 character to string before calling 'error', since %c now has the
10676 printf meaning.
10677 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
10678 overflow when computing char to be passed to 'error'. Do not
10679 pass Lisp_Object to 'error'; pass the integer instead.
10680 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
10681 formatted with plain %d.
10682
b189fa66
PE
10683 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
10684
bff87ef0
PE
10685 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
10686
7e2cac20
PE
10687 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
10688
ce4d90b5
PE
10689 * xterm.c (x_catch_errors): Remove duplicate declaration.
10690
266c9547
PE
10691 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
10692
79c49ad2
PE
10693 * xdisp.c, lisp.h (message_nolog): Remove; unused.
10694
368f4090
JM
106952011-04-10 Jim Meyering <meyering@redhat.com>
10696
10697 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
10698 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
10699 return ssize_t not "int", and use size_t as the buffer length.
10700 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
10701 * gnutls.h: Update declarations.
10702 * process.c (read_process_output): Use ssize_t, to match.
10703 (send_process): Likewise.
10704
a32d4040
CY
107052011-04-09 Chong Yidong <cyd@stupidchicken.com>
10706
10707 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
10708
8546720e 107092011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 10710
04f2d78b
CB
10711 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
10712 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 10713
8546720e
GM
10714 * xterm.c (handle_one_xevent):
10715 * xmenu.c (create_and_show_popup_menu):
10716 * xselect.c (x_decline_selection_request)
10717 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 10718
0a2f5c1a 107192011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
10720
10721 Fix some uses of `int' instead of EMACS_INT.
10722 * search.c (string_match_1, fast_string_match)
10723 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
10724 (scan_buffer, find_next_newline_no_quit)
10725 (find_before_next_newline, search_command, Freplace_match)
10726 (Fmatch_data): Make some `int' variables be EMACS_INT.
10727
10728 * xdisp.c (display_count_lines): 3rd argument and return value now
10729 EMACS_INT. All callers changed.
10730 (pint2hrstr): Last argument is now EMACS_INT.
10731
10732 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
10733 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
10734 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
10735 (decode_coding_utf_16, decode_coding_emacs_mule)
10736 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
10737 (decode_coding_ccl, decode_coding_charset)
10738 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
10739 (decode_coding_iso_2022, decode_coding_emacs_mule)
10740 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
10741 <char_offset, last_offset>: Declare EMACS_INT.
10742 (encode_coding_utf_8, encode_coding_utf_16)
10743 (encode_coding_emacs_mule, encode_invocation_designation)
10744 (encode_designation_at_bol, encode_coding_iso_2022)
10745 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
10746 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
10747 Declare EMACS_INT.
10748 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
10749 (encode_invocation_designation): Last argument P_NCHARS is now
10750 EMACS_INT.
10751 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
10752 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
10753
10754 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
10755 All users changed.
10756
10757 * ccl.c (Fccl_execute_on_string): Declare some variables
10758 EMACS_INT.
10759
8546720e 107602011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
10761
10762 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
10763
4e19a977
CS
107642011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
10765
10766 * process.c (Fformat_network_address): Doc fix.
10767
87302331
R
107682011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
10769
ee7683eb 10770 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 10771
cbb59342
CY
107722011-04-08 Chong Yidong <cyd@stupidchicken.com>
10773
10774 * keyboard.c (read_char): Call Lisp function help-form-show,
10775 instead of using internal_with_output_to_temp_buffer.
10776 (Qhelp_form_show): New var.
e0d38eeb 10777 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
10778
10779 * print.c (internal_with_output_to_temp_buffer): Function deleted.
10780
10781 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
10782
e67a13ab
CY
107832011-04-06 Chong Yidong <cyd@stupidchicken.com>
10784
04f2d78b
CB
10785 * process.c (Flist_processes): Remove to Lisp.
10786 (list_processes_1): Delete.
e67a13ab 10787
973f782d
EZ
107882011-04-06 Eli Zaretskii <eliz@gnu.org>
10789
7c106b1e
EZ
10790 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
10791
973f782d
EZ
10792 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
10793
41cf7d1a 107942011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 10795
ca23cc88
PE
10796 Fix more problems found by GCC 4.6.0's static checks.
10797
f390e2d5
PE
10798 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
10799
42eea0d0
PE
10800 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
10801
b69769da 10802 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 10803
f9541e84
PE
10804 * xdisp.c (vmessage): Mark as a printf-like function.
10805
13841b55
PE
10806 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
10807
c136c10f
PE
10808 * sound.c (sound_warning): Don't crash if arg contains a printf format.
10809
5e2d4a30
PE
10810 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
10811 printf-like functions.
10812 (tiff_load): Add casts to remove these marks before passing them
10813 to system-supplied API.
10814
583f48b9
PE
10815 * eval.c (Fsignal): Remove excess argument to 'fatal'.
10816
b25d760e
PE
10817 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
10818 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
10819 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
10820 directly, rather than having caller test rule sign. This avoids
10821 some unnecessary tests.
10822 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
10823 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
10824 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 10825
bc7b6697 10826 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 10827 (xfont_open): Avoid unnecessary tests.
bc7b6697 10828
27ccc379
PE
10829 * composite.c (composition_gstring_put_cache): Use unsigned integer.
10830
dcd5c89a
PE
10831 * composite.h, composite.c (composition_gstring_put_cache):
10832 Use EMACS_INT, not int, for length.
10833
b13a45c6
PE
10834 * composite.h (COMPOSITION_DECODE_REFS): New macro,
10835 breaking out part of COMPOSITION_DECODE_RULE.
10836 (COMPOSITION_DECODE_RULE): Use it.
10837 * composite.c (get_composition_id): Remove unused local vars,
10838 by using the new macro.
10839
1e792e4d
PE
10840 * textprop.c (set_text_properties_1): Change while to do-while,
10841 since the condition is always true at first.
10842
dc6c6455 10843 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
10844 (interval_deletion_adjustment): Return unsigned value.
10845 All uses changed.
dc6c6455 10846
aba7731a
PE
10847 * process.c (list_processes_1, create_pty, read_process_output):
10848 (exec_sentinel): Remove vars that were set but not used.
afd4052b 10849 (create_pty): Remove unnecessary "volatile"s.
bc57d757 10850 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 10851 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 10852 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 10853
fdfc4bf3
PE
10854 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
10855
fca8fe46 10856 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 10857 (update_syntax_table): Use unsigned instead of int.
fca8fe46 10858
06a0259a 10859 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 10860 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 10861 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 10862
e7b9e80f
PE
10863 * print.c (print_error_message): Avoid int overflow.
10864
56201685
PE
10865 * font.c (font_list_entities): Redo for clarity,
10866 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
10867
78834453 10868 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 10869 (font_score): Avoid potential overflow in diff calculation.
78834453 10870
0bc0b309 10871 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 10872 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 10873
e610eaca
PE
10874 * eval.c (funcall_lambda): Rename local to avoid shadowing.
10875
b895abce
PE
10876 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
10877 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
10878 can always succeed if overflow has undefined behavior.
10879
1f1d9321 10880 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 10881 (wordify): Omit three unnecessary tests.
1f1d9321 10882
c59478bc
PE
10883 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
10884 All callers changed. This avoids the need for an unused var.
10885
79b73827
PE
10886 * casefiddle.c (casify_region): Remove var that is set but not used.
10887
a4db5dfe
PE
10888 * dired.c (file_name_completion): Remove var that is set but not used.
10889
43aae36e
PE
10890 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
10891
2a47c44d 10892 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 10893 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 10894
a37c69bf
PE
10895 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
10896 Check for integer overflow on size calculations.
10897
328ab8e7
PE
10898 * buffer.c (Fprevious_overlay_change): Remove var that is set
10899 but not used.
10900
e5a2a5cb
PE
10901 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
10902 Remove vars that are set but not used.
8d84a6eb 10903 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 10904 (timer_check_2): Mark vars as initialized.
e5a2a5cb 10905
a60e5f68
PE
10906 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
10907
f661cb61 10908 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 10909 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 10910
f0397f5a
PE
10911 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
10912 that are set but not used.
10913
8664db06 10914 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 10915 if XCreateBitmapFromData fails (Bug#8410).
8664db06 10916
6abdaa4a
PE
10917 * xselect.c (x_get_local_selection, x_handle_property_notify):
10918 Remove vars that are set but not used.
10919
0ce7538d 10920 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 10921 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 10922
9ae848fc
PE
10923 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
10924 Remove var that is set but not used.
0b918413
PE
10925 (scroll_bar_windows_size): Now size_t, not int.
10926 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
10927 Check for overflow.
9ae848fc 10928
a5a62657
PE
10929 * xfaces.c (realize_named_face): Remove vars that are set but not used.
10930 (map_tty_color) [!defined MSDOS]: Likewise.
10931
5c5cdd39
PE
10932 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
10933
66ebf983
PE
10934 * coding.c: Remove vars that are set but not used.
10935 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
10936 All callers changed.
10937 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
10938 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
10939 (decode_coding_charset): Remove vars that are set but not used.
10940
1be4d761
PE
10941 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
10942 that is set but not used.
10943
47553fa8
PE
10944 * print.c (print_object): Remove var that is set but not used.
10945
1f7196bf 10946 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
10947 The gnulib version avoids calling malloc in the usual case,
10948 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
10949 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
10950 * filelock.c (current_lock_owner): Likewise.
10951 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
10952 * sysdep.c: Include allocator.h, careadlinkat.h.
10953 (emacs_no_realloc_allocator): New static constant.
10954 (emacs_readlink): New function.
fdb61804
PE
10955 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
10956 ../lib/careadlinkat.h.
d1fdcab7 10957
f84c17c7
SM
109582011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
10959
10960 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
10961 first non-nil return value).
10962
ef3862ad
JD
109632011-04-03 Jan Djärv <jan.h.d@swipnet.se>
10964
10965 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
10966 if not defined (Bug#8403).
10967
376a7006
JB
109682011-04-02 Juanma Barranquero <lekktu@gmail.com>
10969
10970 * xdisp.c (display_count_lines): Remove parameter `start',
10971 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10972 (get_char_face_and_encoding): Remove parameter `multibyte_p',
10973 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10974 (fill_stretch_glyph_string): Remove parameters `row' and `area',
10975 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
10976 and thereabouts. All callers changed.
10977 (get_per_char_metric): Remove parameter `f', unused since
10978 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10979
6ca3801d
JM
109802011-04-02 Jim Meyering <meyering@redhat.com>
10981
10982 do not dereference NULL upon failed strdup
10983 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
10984 (ns_get_family): Likewise.
10985
d8e2b5ba
JB
109862011-04-02 Juanma Barranquero <lekktu@gmail.com>
10987
10988 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
10989
8c74fcbd
JD
109902011-04-02 Jan Djärv <jan.h.d@swipnet.se>
10991
10992 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
10993 later (Bug#8403).
10994
7200d79c
SM
109952011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
10996
03408648 10997 Add lexical binding.
7200d79c 10998
03408648
SM
10999 * window.c (Ftemp_output_buffer_show): New fun.
11000 (Fsave_window_excursion):
11001 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
11002
11003 * lread.c (lisp_file_lexically_bound_p): New function.
11004 (Fload): Bind Qlexical_binding.
11005 (readevalloop): Remove `evalfun' arg.
11006 Bind Qinternal_interpreter_environment.
11007 (Feval_buffer): Bind Qlexical_binding.
11008 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
11009 Mark as dynamic.
11010 (syms_of_lread): Declare `lexical-binding'.
11011
11012 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
11013
11014 * keyboard.c (eval_dyn): New fun.
11015 (menu_item_eval_property): Use it.
ca105506
SM
11016
11017 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 11018
03408648
SM
11019 * fns.c (concat, mapcar1): Accept byte-code-functions.
11020
11021 * eval.c (Fsetq): Handle lexical vars.
11022 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
11023 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
11024 (FletX, Flet): Obey lexical binding.
11025 (Fcommandp): Handle closures.
11026 (Feval): New `lexical' arg.
11027 (eval_sub): New function extracted from Feval. Use it almost
11028 everywhere where Feval was used. Look up vars in lexical env.
11029 Handle closures.
11030 (Ffunctionp): Move from subr.el.
11031 (Ffuncall): Handle closures.
11032 (apply_lambda): Remove `eval_flags'.
11033 (funcall_lambda): Handle closures and new byte-code-functions.
11034 (Fspecial_variable_p): New function.
11035 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
11036 but without exporting it to Lisp.
23aba0ea 11037
23aba0ea 11038 * doc.c (Fdocumentation, store_function_docstring):
03408648 11039 * data.c (Finteractive_form): Handle closures.
23aba0ea 11040
03408648
SM
11041 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
11042 interactive spec.
ba83908c 11043
04f2d78b
CB
11044 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
11045 New byte-codes.
03408648
SM
11046 (exec_byte_code): New function extracted from Fbyte_code to handle new
11047 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 11048
03408648 11049 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 11050
03408648 11051 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 11052
e2abce01
JB
110532011-03-31 Juanma Barranquero <lekktu@gmail.com>
11054
11055 * xdisp.c (redisplay_internal): Fix prototype.
11056
63696a73 110572011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 11058
63696a73 11059 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
11060 (try_scrolling): Use it when setting scroll_limit.
11061 Limit scrolling to 100 screen lines.
63696a73
EZ
11062 (redisplay_window): Even when falling back on "recentering",
11063 position point in the window according to scroll-conservatively,
11064 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
11065
11066 (try_scrolling): When point is above the window, allow searching
11067 as far as scroll_max, or one screenful, to compute vertical
11068 distance from PT to the scroll margin position. This prevents
11069 try_scrolling from unnecessarily failing when
11070 scroll-conservatively is set to a value slightly larger than the
11071 window height. Clean up the case of PT below the margin at bottom
11072 of window: scroll_max can no longer be INT_MAX. When aggressive
11073 scrolling is in use, don't let point enter the opposite scroll
11074 margin as result of the scroll.
11075 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
11076 threshold of 100 lines for never-recentering scrolling.
11077
e4cc2dfc
JB
110782011-03-31 Juanma Barranquero <lekktu@gmail.com>
11079
11080 * dispextern.h (move_it_by_lines):
11081 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
11082 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
11083 (message_log_check_duplicate): Remove parameters `prev_bol' and
11084 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11085 (redisplay_internal): Remove parameter `preserve_echo_area',
11086 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
11087
11088 * indent.c (Fvertical_motion):
11089 * window.c (window_scroll_pixel_based, Frecenter):
11090 Don't pass `need_y_p' to `move_it_by_lines'.
11091
1c470562
SM
110922011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
11093
44f230aa
SM
11094 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
11095 steal a few bits to be more compact.
11096 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
11097 Remove unneeded casts.
11098
1c470562
SM
11099 * bytecode.c (Fbyte_code): CAR and CDR can GC.
11100
888adce9
ZK
111012011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
11102
11103 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
11104 binding" message (bug#7967).
11105
f838ed7b
PE
111062011-03-30 Paul Eggert <eggert@cs.ucla.edu>
11107
77861b95
PE
11108 Fix more problems found by GCC 4.6.0's static checks.
11109
de6dbc14
PE
11110 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
11111 Remove unused local var.
11112
f838ed7b
PE
11113 * editfns.c (Fmessage_box): Remove unused local var.
11114
792c7b2b
PE
11115 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
11116 (note_mode_line_or_margin_highlight, note_mouse_highlight):
11117 Omit unused local vars.
c499e557 11118 * window.c (shrink_windows): Omit unused local var.
b01a1c29 11119 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
11120 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
11121 Omit unused local var.
11122
ba0165e1
PE
11123 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
11124 Don't assume string length fits in int.
32ad8845 11125 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 11126 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 11127
3c59b4c9
PE
11128 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
11129 instead of alloca (Bug#8344).
11130
a3eed478 11131 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 11132 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 11133
eb4d412d
PE
11134 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
11135
1658b401
PE
11136 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
11137 concerns.
11138
11139 * term.c (produce_glyphless_glyph): Remove unnecessary test.
11140
11141 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 11142
9a2c6e05
PE
11143 * keyboard.c (syms_of_keyboard): Use the same style as later
11144 in this function when indexing through an array. This also
11145 works around GCC bug 48267.
11146
03d0a109
PE
11147 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
11148
44f730c8
PE
11149 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
11150
fe75f926
PE
11151 * chartab.c (sub_char_table_ref_and_range): Redo for slight
11152 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
11153
ffa8c828
PE
11154 * keyboard.c, keyboard.h (num_input_events): Now size_t.
11155 This avoids undefined behavior on integer overflow, and is a bit
11156 more convenient anyway since it is compared to a size_t variable.
11157
c5101a77
PE
11158 Variadic C functions now count arguments with size_t, not int.
11159 This avoids an unnecessary limitation on 64-bit machines, which
11160 caused (substring ...) to crash on large vectors (Bug#8344).
11161 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
11162 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 11163 All variadic functions and their callers changed accordingly.
c5101a77
PE
11164 (struct gcpro.nvars): Now size_t, not int. All uses changed.
11165 * data.c (arith_driver, float_arith_driver): Likewise.
11166 * editfns.c (general_insert_function): Likewise.
11167 * eval.c (struct backtrace.nargs, interactive_p)
11168 (internal_condition_case_n, run_hook_with_args, apply_lambda)
11169 (funcall_lambda, mark_backtrace): Likewise.
11170 * fns.c (concat): Likewise.
11171 * frame.c (x_set_frame_parameters): Likewise.
11172 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
11173 0 if not found, not -1. All callers changed.
11174
dd3f25f7
PE
11175 * alloc.c (garbage_collect): Don't assume stack size fits in int.
11176 (stack_copy_size): Now size_t, not int.
11177 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
11178
461c2ab9
JB
111792011-03-28 Juanma Barranquero <lekktu@gmail.com>
11180
11181 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
11182 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11183 All callers changed.
11184
11185 * lisp.h (multibyte_char_to_unibyte):
11186 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
11187 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11188 * character.h (CHAR_TO_BYTE8):
11189 * cmds.c (internal_self_insert):
11190 * editfns.c (general_insert_function):
11191 * keymap.c (push_key_description):
11192 * search.c (Freplace_match):
11193 * xdisp.c (message_dolog, set_message_1): All callers changed.
11194
f6d62986
SM
111952011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
11196
11197 * keyboard.c (safe_run_hook_funcall): New function.
11198 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
11199 don't set the hook to nil, but remove the offending function instead.
11200 (Qcommand_hook_internal): Remove, unused.
11201 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
11202 Vcommand_hook_internal.
11203
11204 * eval.c (enum run_hooks_condition): Remove.
11205 (funcall_nil, funcall_not): New functions.
11206 (run_hook_with_args): Call each function through a `funcall' argument.
11207 Remove `cond' argument, now redundant.
11208 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
11209 (Frun_hook_with_args_until_failure): Adjust accordingly.
11210 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
11211
1db5b1ad
JB
112122011-03-28 Juanma Barranquero <lekktu@gmail.com>
11213
11214 * dispextern.h (string_buffer_position): Remove declaration.
11215
11216 * print.c (strout): Remove parameter `multibyte', unused since
11217 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
11218
11219 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
11220 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
11221 All callers changed.
11222
11223 * w32.c (_wsa_errlist): Use braces for struct initializers.
11224
11225 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
11226 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
11227 All callers changed.
11228 (string_buffer_position): Likewise. Also, make static (it's never
11229 used outside xdisp.c).
11230 (cursor_row_p): Remove parameter `w', unused since
11231 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
11232 (decode_mode_spec): Remove parameter `precision', introduced during
11233 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
11234 All callers changed.
11235
5ffb62aa
JD
112362011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11237
11238 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
11239
461c2ab9 112402011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
11241
11242 * nsterm.m (ns_menu_bar_is_hidden): New variable.
11243 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
11244 (ns_update_auto_hide_menu_bar): New functions.
11245 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
11246 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
11247 ns_constrain_all_frames.
11248 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
11249 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
11250
5c380ffb
JD
112512011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11252
11253 * nsmenu.m (runDialogAt): Remove argument to timer_check.
11254
9af30bdf
GM
112552011-03-27 Glenn Morris <rgm@gnu.org>
11256
11257 * syssignal.h: Replace RETSIGTYPE with void.
11258 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
11259 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
11260 Replace SIGTYPE with void everywhere.
11261 * s/usg5-4-common.h (SIGTYPE): Remove definition.
11262 * s/template.h (SIGTYPE): Remove commented out definition.
11263
e2abce01
JB
112642011-03-26 Eli Zaretskii <eliz@gnu.org>
11265
11266 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
11267 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
11268
f868cd8a
JB
112692011-03-26 Juanma Barranquero <lekktu@gmail.com>
11270
59eb0929
JB
11271 * w32.c (read_unc_volume): Use parameter `henum', instead of
11272 global variable `wget_enum_handle'.
11273
11274 * keymap.c (describe_vector): Remove parameters `indices' and
11275 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
11276 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
11277
f868cd8a
JB
11278 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
11279
11280 * keyboard.c (timer_check): Remove parameter `do_it_now',
11281 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
11282 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
11283 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
11284
11285 * keyboard.c (read_char):
11286 * w32menu.c (w32_menu_display_help):
11287 * xmenu.c (show_help_event, menu_help_callback):
11288 Adjust calls to `show_help_echo'.
11289
11290 * gtkutil.c (xg_maybe_add_timer):
11291 * keyboard.c (readable_events):
11292 * process.c (wait_reading_process_output):
11293 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
11294
11295 * insdel.c (adjust_markers_gap_motion):
11296 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
11297 (gap_left, gap_right): Don't call it.
11298
2ecf6fdb
CY
112992011-03-25 Chong Yidong <cyd@stupidchicken.com>
11300
11301 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
11302 incurred during fontification.
11303
6b1f9ba4
JB
113042011-03-25 Juanma Barranquero <lekktu@gmail.com>
11305
11306 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
11307 (DEFVAR_PER_BUFFER): Don't pass it.
11308
11309 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
11310 (scrolling_window): Don't pass it.
11311
0f4a96b5
JB
113122011-03-25 Juanma Barranquero <lekktu@gmail.com>
11313
11314 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
11315
11316 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
11317 and `suffix'.
11318 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
11319 of variables specific to SELinux and computation of `encoded_absname'.
11320
11321 * image.c (XPutPixel): Remove unused variable `height'.
11322
11323 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
11324
11325 * unexw32.c (get_section_info): Remove unused variable `section'.
11326
11327 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
11328 (system_process_attributes): Remove unused variable `sess'.
11329 (sys_read): Remove unused variable `err'.
11330
11331 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
11332 (w32_wnd_proc): Remove unused variable `isdead'.
11333 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
11334 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
11335 (x_create_tip_frame): Remove unused variable `tem'.
11336
11337 * w32inevt.c (w32_console_read_socket):
11338 Remove unused variable `no_events'.
11339
11340 * w32term.c (x_draw_composite_glyph_string_foreground):
11341 Remove unused variable `width'.
11342
1149507c
JB
113432011-03-24 Juanma Barranquero <lekktu@gmail.com>
11344
11345 * w32term.c (x_set_glyph_string_clipping):
11346 Don't pass uninitialized region to CombineRgn.
11347
9c88f339
JB
113482011-03-23 Juanma Barranquero <lekktu@gmail.com>
11349
11350 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
11351 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
11352 (Fx_close_connection): Remove unused variable `i'.
11353
11354 * w32font.c (w32font_draw): Return number of glyphs.
11355 (w32font_open_internal): Remove unused variable `i'.
11356 (w32font_driver): Add missing initializer.
11357
11358 * w32menu.c (utf8to16): Remove unused variable `utf16'.
11359 (fill_in_menu): Remove unused variable `items_added'.
11360
11361 * w32term.c (last_mouse_press_frame): Remove static global variable.
11362 (w32_clip_to_row): Remove unused variable `f'.
11363 (x_delete_terminal): Remove unused variable `i'.
11364
11365 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
11366 (NOTHING): Remove unused static global variable.
11367 (uniscribe_check_otf): Remove unused variable `table'.
11368 (uniscribe_font_driver): Add missing initializers.
11369
dee091a3
JD
113702011-03-23 Julien Danjou <julien@danjou.info>
11371
11372 * term.c (Fsuspend_tty, Fresume_tty):
11373 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
11374 * window.c (temp_output_buffer_show):
11375 * insdel.c (signal_before_change):
11376 * frame.c (Fhandle_switch_frame):
11377 * fileio.c (Fdo_auto_save):
11378 * emacs.c (Fkill_emacs):
11379 * editfns.c (save_excursion_restore):
11380 * cmds.c (internal_self_insert):
11381 * callint.c (Fcall_interactively):
11382 * buffer.c (Fkill_all_local_variables):
11383 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
11384 Use Frun_hooks.
0f4a96b5 11385 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 11386 unconditionally since it does the check itself.
dee091a3 11387
2c520ab5 113882011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 11389
c9c49752
PE
11390 Fix more problems found by GCC 4.5.2's static checks.
11391
8abc3f12
PE
11392 * coding.c (encode_coding_raw_text): Avoid unnecessary test
11393 the first time through the loop, since we know p0 < p1 then.
11394 This also avoids a gcc -Wstrict-overflow warning.
11395
a2d26660
PE
11396 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
11397 leading to a memory leak, possible in functions like
11398 load_charset_map_from_file that can allocate an unbounded number
b12ef411 11399 of objects (Bug#8318).
a2d26660 11400
916c72e9
PE
11401 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
11402 that could (at least in theory) be that large.
11403
19ab8a18
PE
11404 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
11405 This is less likely to overflow, and avoids undefined behavior if
11406 overflow does occur. All callers changed. Use strtoul to scan
11407 for the unsigned long integer.
b7cbbd6f
PE
11408 (pint2hrstr): Simplify and tune code slightly.
11409 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 11410
f0641eff
PE
11411 * scroll.c (do_scrolling): Work around GCC bug 48228.
11412 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
11413
7f650bb9
PE
11414 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
11415 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
11416 (validate_x_resource_name): Simplify count usage.
11417 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 11418
37dd57d1
PE
11419 * fileio.c (Fcopy_file): Report error if fchown or fchmod
11420 fail (Bug#8306).
81e56e61 11421
699979fc 11422 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 11423
401bf9b4
PE
11424 * process.c (Fmake_network_process): Use socklen_t, not int,
11425 where POSIX says socklen_t is required in portable programs.
11426 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 11427 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
11428 (Fmake_network_process, server_accept_connection):
11429 (wait_reading_process_output, read_process_output):
11430 Likewise.
11431
b93aacde
PE
11432 * process.c: Rename or move locals to avoid shadowing.
11433 (list_processes_1, Fmake_network_process):
11434 (read_process_output_error_handler, exec_sentinel_error_handler):
11435 Rename or move locals.
4dc343ee 11436 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 11437 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 11438 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 11439 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 11440 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 11441
af8a867c 11442 Make tparam.h and terminfo.c consistent.
44f230aa
SM
11443 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
11444 Include tparam.h instead, since it declares them.
af8a867c
PE
11445 * cm.h (PC): Remove extern decl; tparam.h now does this.
11446 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
11447 * terminfo.c: Include tparam.h, to check interfaces.
11448 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
11449 (tparam): Adjust signature to match interface in tparam.h;
11450 this removes some undefined behavior. Check that outstring and len
11451 are zero, which they always are with Emacs.
11452 * tparam.h (PC, BC, UP): New extern decls.
11453
0248044d 11454 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 11455 (xftfont_open): Rename locals to avoid shadowing.
0248044d 11456
8ff096c1 11457 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
11458 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
11459 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 11460 (ftfont_list): Remove unused local.
49eaafba
PE
11461 (get_adstyle_property, ftfont_pattern_entity):
11462 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
11463 Rename locals to avoid shadowing.
8ff096c1 11464
e2be39f6
PE
11465 * xfont.c (xfont_list_family): Mark var as initialized.
11466
c9735e30
PE
11467 * xml.c (make_dom): Now static.
11468
8f5201ae
PE
11469 * composite.c (composition_compute_stop_pos): Rename local to
11470 avoid shadowing.
b246f932
PE
11471 (composition_reseat_it): Remove unused locals.
11472 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 11473 (composition_update_it): Mark var as initialized.
11b61122
PE
11474 (find_automatic_composition): Mark vars as initialized,
11475 with a FIXME (Bug#8290).
8f5201ae 11476
760fbc2c
PE
11477 character.h: Rename locals to avoid shadowing.
11478 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
11479 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
11480 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
11481 (BUF_DEC_POS): Be more systematic about renaming local temporaries
11482 to avoid shadowing.
11483
ff08eb85
PE
11484 * textprop.c (property_change_between_p): Remove; unused.
11485
fc7bf025
PE
11486 * intervals.c (interval_start_pos): Now static.
11487
235d7abc
PE
11488 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
11489
44f230aa
SM
11490 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
11491 Rename locals to avoid shadowing.
3e7d6594 11492
50060332
PE
11493 * sound.c (wav_play, au_play, Fplay_sound_internal):
11494 Fix pointer signedness.
d01f234b 11495 (alsa_choose_format): Remove unused local var.
c83b8872
PE
11496 (wav_play): Initialize a variable to 0, to prevent undefined
11497 behavior (Bug#8278).
50060332 11498
c4fc4e30
PE
11499 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
11500
918436ed
PE
11501 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
11502
c939f91b
PE
11503 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
11504 clobbering (Bug#8298).
b9c7f648
PE
11505 * sysdep.c (sys_subshell): Likewise.
11506 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 11507
6bd8c144
PE
11508 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
11509 This should get cleaned up, so that child_setup has the
11510 same signature on all platforms.
11511
7710357c 11512 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 11513 (relocate_fd): Rename locals to avoid shadowing.
7710357c 11514
c59da222
CY
115152011-03-22 Chong Yidong <cyd@stupidchicken.com>
11516
11517 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
11518 not to be necessary, and produces flickering.
11519
66b87493
GM
115202011-03-20 Glenn Morris <rgm@gnu.org>
11521
11522 * config.in: Remove file.
11523
45b6f6d5
JB
115242011-03-20 Juanma Barranquero <lekktu@gmail.com>
11525
11526 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
11527 are now in src/globals.h.
11528 (syms_of_minibuf): Remove spurious & from previous change.
11529
cd394be1 115302011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
11531
11532 * minibuf.c (completing-read-function): New variable.
11533 (completing-read-default): Rename from completing-read.
11534 (completing-read): Call completing-read-function.
11535
b14e3e21
CY
115362011-03-19 Juanma Barranquero <lekktu@gmail.com>
11537
11538 * xfaces.c (Fx_load_color_file):
11539 Read color file from absolute filename (bug#8250).
11540
f2b726e6
JB
115412011-03-19 Juanma Barranquero <lekktu@gmail.com>
11542
11543 * makefile.w32-in: Update dependencies.
11544
09f6ff02
EZ
115452011-03-17 Eli Zaretskii <eliz@gnu.org>
11546
11547 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
11548
29a6015a
PE
115492011-03-17 Paul Eggert <eggert@cs.ucla.edu>
11550
a3a6c54e
PE
11551 Fix more problems found by GCC 4.5.2's static checks.
11552
b766f867
PE
11553 * process.c (make_serial_process_unwind, send_process_trap):
11554 (sigchld_handler): Now static.
11555
be02381c
PE
11556 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
11557 That way, the code declares only the vars that it needs.
11558 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
11559 * s/cygwin.h (PTY_ITERATION): Likewise.
11560 * s/darwin.h (PTY_ITERATION): Likewise.
11561 * s/gnu-linux.h (PTY_ITERATION): Likewise.
11562
57048744
PE
11563 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
11564 * process.c (allocate_pty): Don't declare stb unless it's needed.
11565
7914961c 11566 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
11567 (CONSTANTLIM): Remove; unused.
11568 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
11569 Define only if needed.
7914961c 11570
b3967b18
PE
11571 * unexelf.c (unexec): Name an expression,
11572 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
11573 Use a different way to cause a compilation error if anyone uses
11574 n rather than nn, a way that does not involve shadowing.
73366a00 11575 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 11576
29a6015a
PE
11577 * deps.mk (unexalpha.o): Remove; unused.
11578
43cfc33e 11579 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 11580 * unexec.h: New file.
ce701a33
PE
11581 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
11582 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
11583 Depend on unexec.h.
11584 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
11585 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
11586 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 11587 Change as necessary to match prototype in unexec.h.
ce701a33 11588
01f44d5a
PE
11589 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
11590 shadowing.
4f63c6bb 11591 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 11592
a6670b0b
PE
11593 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
11594 Rename locals to avoid shadowing.
11595
cef2010d 11596 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 11597 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 11598
d4d7173a
PE
11599 * print.c (Fredirect_debugging_output): Fix pointer signedess.
11600
f08b802a
PE
11601 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
11602 warning when compiling print.c.
11603
3ddb0639
PE
11604 * font.c (font_unparse_fcname): Abort in an "impossible" situation
11605 instead of using an uninitialized var.
5ad03b97 11606 (font_sort_entities): Mark var as initialized.
3ddb0639 11607
170a2692
PE
11608 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
11609
e663c700
PE
11610 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
11611 pointers to constants.
89bc529a 11612 (font_parse_fcname): Remove unused vars.
7b81e2d0 11613 (font_delete_unmatched): Now static.
ea838e10 11614 (font_get_spec): Remove; unused.
13a547c6
PE
11615 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
11616 (font_update_drivers, Ffont_get_glyphs, font_add_log):
11617 Rename or move locals to avoid shadowing.
e663c700 11618
2a80c887 11619 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 11620 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 11621
1384fa33 11622 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 11623 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 11624
8b2c52e9
PE
11625 * alloc.c (mark_backtrace): Move decl from here ...
11626 * lisp.h: ... to here, so that it can be checked.
11627
475545b5 11628 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 11629 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
11630 (lisp_indirect_variable): Name an expression,
11631 to avoid gcc -Wbad-function-cast warning.
1faed8ae 11632 (Fdefvar): Rename locals to avoid shadowing.
475545b5 11633
b1349114 11634 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 11635 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 11636 Use const pointer when appropriate.
b1349114 11637
a2928364
PE
11638 * lisp.h (get_system_name, get_operating_system_release):
11639 Move decls here, to check interfaces.
11640 * process.c (get_operating_system_release): Move decl to lisp.h.
11641 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
11642 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
11643 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
11644 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
11645 (Fformat_time_string, Fencode_time, Finsert_char):
11646 (Ftranslate_region_internal, Fformat):
11647 Rename or remove local vars to avoid shadowing.
9710023e 11648 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 11649
a415e694
PE
11650 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
11651 avoid shadowing.
11652
8ef4622d
PE
11653 * lisp.h (eassert): Check that the argument compiles, even if
11654 ENABLE_CHECKING is not defined.
11655
946f9a5b
PE
11656 * data.c (Findirect_variable): Name an expression, to avoid
11657 gcc -Wbad-function-cast warning.
112396d6 11658 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 11659 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
11660 (Fmake_variable_buffer_local, Fmake_local_variable):
11661 Mark variables as initialized.
52746918 11662 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 11663
e5aab7e7 11664 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
11665 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
11666 Rename locals to avoid shadowing.
dff45157
PE
11667 (mark_stack): Move local variables into the #ifdef region where
11668 they're used.
7bc26fdb
PE
11669 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
11670 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
11671 needed otherwise.
11672 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
11673 (GC_STRING_CHARS): Remove; not used.
d40d4be1 11674 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 11675
e5aab7e7
PE
11676 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
11677 avoids undefined behavior in theory.
11678
4da60324
PE
11679 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
11680
88043301
PE
11681 Use functions, not macros, for up- and down-casing (Bug#8254).
11682 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11683 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
11684 to use the following functions instead of these macros.
11685 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
11686 EMACS_INT, since callers assume the returned value fits in int.
11687 (upcase1): Likewise, for UPCASE_TABLE.
11688 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 11689 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 11690 the race-condition problem in the old DOWNCASE.
88043301 11691
19ed5445
PE
11692 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
11693 Rename locals to avoid shadowing.
11694 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
11695 (regex_compile, re_search_2, re_match_2_internal):
11696 Remove unused local vars.
952db0d7
PE
11697 (FREE_VAR): Rewrite so as not to use empty "else",
11698 which gcc can warn about.
da053e48 11699 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
11700 (RETALLOC_IF): Define only if needed.
11701 (WORDCHAR_P): Likewise. This one is never needed, but is used
11702 only in a comment talking about a compiler bug, so put inside
11703 the #if 0 of that comment.
11704 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
11705 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
11706 Remove; unused.
19ed5445 11707
1f3561e4 11708 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
11709 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
11710 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 11711
ded6f8f7
PE
11712 * search.c (simple_search): Remove unused var.
11713
dbd37a95
PE
11714 * dired.c (compile_pattern): Move decl from here ...
11715 * lisp.h: ... to here, so that it can be checked.
11716 (struct re_registers): New forward decl.
11717
7e47afad
PE
11718 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
11719
85f24f61
PE
11720 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
11721 All uses changed.
11722 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
11723 Rename locals to avoid shadowing.
5671df8f 11724 (Fvertical_motion): Mark locals as initialized.
85f24f61 11725
181aa2be 11726 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 11727 (casify_region): Mark local as initialized.
181aa2be 11728
930d429c
PE
11729 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
11730
7082eac6
PE
11731 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
11732 New macros, so that the caller can use some names other than
11733 gcpro1, gcpro2, etc.
11734 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
11735 of the new macros.
11736 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
11737 argument, for consistency with GCPRO2_VAR, etc: it is now the
11738 prefix of the variable, not the variable itself. All uses
11739 changed.
38b2c076
PE
11740 * dired.c (directory_files_internal, file_name_completion):
11741 Rename locals to avoid shadowing.
11742
15206ed9
PE
11743 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
11744 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
11745 dired.c's scmp function, had undefined behavior.
11746 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11747 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
11748 * buffer.h: ... to here, because these macros use current_buffer,
11749 and the new implementation with inline functions needs to have
11750 current_buffer in scope now, rather than later when the macros
11751 are used.
11752 (downcase, upcase1): New static inline functions.
11753 (DOWNCASE, UPCASE1): Reimplement using these functions.
11754 This avoids undefined behavior in expressions like
11755 DOWNCASE (x) == DOWNCASE (y), which previously suffered
11756 from race conditions in accessing the global variables
11757 case_temp1 and case_temp2.
11758 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
11759 * lisp.h (case_temp1, case_temp2): Remove their decls.
11760 * character.h (ASCII_CHAR_P): Move from here ...
11761 * lisp.h: ... to here, so that the inline functions mentioned
11762 above can use them.
11763
4a6bea26
PE
11764 * dired.c (directory_files_internal_unwind): Now static.
11765
f14b7e14
PE
11766 * fileio.c (file_name_as_directory, directory_file_name):
11767 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
11768 Now static.
2893f146
PE
11769 (file_name_as_directory): Use const pointers when appropriate.
11770 (Fexpand_file_name): Likewise. In particular, newdir might
11771 point at constant storage, so make it a const pointer.
fd4ead52 11772 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
11773 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
11774 signedness issues.
f839df0c
PE
11775 (Fset_file_times, Finsert_file_contents, auto_save_error):
11776 Rename locals to avoid shadowing.
f14b7e14 11777
5716756e 11778 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
11779 (Ftry_completion, Fall_completions): Rename or remove locals
11780 to avoid shadowing.
5716756e 11781
b4c3046a
PE
11782 * marker.c (bytepos_to_charpos): Remove; unused.
11783
b45db522
PE
11784 * lisp.h (verify_bytepos, count_markers): New decls,
11785 so that gcc does not warn that these functions aren't declared.
11786
85876d07
PE
11787 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
11788 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 11789 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 11790 (copy_text): Remove unused local var.
85876d07 11791
03d78a21 11792 * filelock.c (within_one_second): Now static.
b3dd38ab 11793 (lock_file_1): Rename local to avoid shadowing.
03d78a21 11794
5df8f01b
PE
11795 * buffer.c (fix_overlays_before): Mark locals as initialized.
11796 (fix_start_end_in_overlays): Likewise. This function should be
11797 simplified by using pointers-to-pointers, but that's a different
11798 matter.
b1d876f1 11799 (switch_to_buffer_1): Now static.
8f54f30a
PE
11800 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
11801 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 11802
a70072c9 11803 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 11804 Fix pointer signedness issue.
edced198
PE
11805 (sys_subshell): Mark local as volatile if checking for lint,
11806 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 11807 (MAXPATHLEN): Define only if needed.
a70072c9 11808
a0977c44
PE
11809 * process.c (serial_open, serial_configure): Move decls from here ...
11810 * systty.h: ... to here, so that they can be checked.
11811
a884fdcc
PE
11812 * fns.c (get_random, seed_random): Move extern decls from here ...
11813 * lisp.h: ... to here, so that they can be checked.
11814
604efe86 11815 * sysdep.c (reset_io): Now static.
b8950c94 11816 (wait_for_termination_signal): Remove; unused.
604efe86 11817
38fc62d9
PE
11818 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
11819 (copy_keymap_item, append_key, push_text_char_description):
11820 Now static.
1004a21a 11821 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 11822 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
11823 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
11824 (describe_map_tree):
11825 Rename locals to avoid shadowing.
38fc62d9 11826
2f2650da
PE
11827 * keyboard.c: Declare functions static if they are not used elsewhere.
11828 (echo_char, echo_dash, cmd_error, top_level_2):
11829 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
11830 (read_char, kbd_buffer_get_event, make_lispy_position):
11831 (make_lispy_event, make_lispy_movement, apply_modifiers):
11832 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
11833 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
11834 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 11835 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 11836 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 11837
a053e86c 11838 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
11839 (mark_kboards): Move decl here ...
11840 * alloc.c (mark_kboards): ... from here.
a053e86c 11841
4752793e
PE
11842 * lisp.h (force_auto_save_soon): New decl.
11843
74f10ca7 11844 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
11845 (DEFINE_DUMMY_FUNCTION): New macro.
11846 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
11847 Use it.
c03cd23f
PE
11848 (main): Add casts to avoid warnings
11849 if GCC considers string literals to be constants.
74f10ca7 11850
022e70d4
PE
11851 * lisp.h (fatal_error_signal): Add decl, since it's exported.
11852
59d6fe83
PE
11853 * dbusbind.c: Pointer signedness fixes.
11854 (xd_signature, xd_append_arg, xd_initialize):
11855 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11856 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11857 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
11858 (Fdbus_register_signal): Use SSDATA when the context wants char *.
11859
78320123
PE
11860 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
11861 if GCC considers string literals to be constants.
49cebcca 11862 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 11863
35ac2a97
SM
118642011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
11865
fb103ca9
SM
11866 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
11867 (print_preprocess, print_object): New macro to fix last change.
11868
35ac2a97
SM
11869 * print.c (print_preprocess): Don't forget font objects.
11870
62973b41
JB
118712011-03-16 Juanma Barranquero <lekktu@gmail.com>
11872
11873 * emacs.c (USAGE3): Doc fixes.
11874
0e48bb22
AS
118752011-03-15 Andreas Schwab <schwab@linux-m68k.org>
11876
11877 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
11878 structure.
11879
7684e57b
JB
118802011-03-14 Juanma Barranquero <lekktu@gmail.com>
11881
11882 * lisp.h (VWindow_system, Qfile_name_history):
11883 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
11884 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
11885 (w32_system_caret_x, w32_system_caret_y): Declare extern.
11886
11887 * w32select.c: Don't #include "keyboard.h".
c96bbc66 11888 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
11889
11890 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
11891 * w32console.c (detect_input_pending, read_input_pending)
11892 (encode_terminal_code):
11893 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
11894 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
11895 (w32_system_caret_y, Qfile_name_history):
11896 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
11897 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
11898 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
11899 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
11900 * w32proc.c (Qlocal, report_file_error):
11901 * w32term.c (Vwindow_system, updating_frame):
11902 * w32uniscribe.c (initialized, uniscribe_font_driver):
11903 Remove unneeded extern declarations.
11904
2aa46d6c
CY
119052011-03-14 Chong Yidong <cyd@stupidchicken.com>
11906
c96bbc66 11907 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 11908
cffc6f3b
CY
119092011-03-13 Chong Yidong <cyd@stupidchicken.com>
11910
11911 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
11912 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
11913 These macros can no longer be used for assignment.
11914
44f230aa
SM
11915 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
11916 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
11917 (record_buffer_markers, fetch_buffer_markers): New functions for
11918 recording and fetching special buffer markers.
11919 (set_buffer_internal_1, set_buffer_temp): Use them.
11920
11921 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
11922
11923 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
11924
11925 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
11926 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
11927
11928 * xdisp.c (hscroll_window_tree):
11929 (reconsider_clip_changes): Use PT instead of BUF_PT.
11930
d251f04b
EZ
119312011-03-13 Eli Zaretskii <eliz@gnu.org>
11932
11933 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
11934 $(EMACS_ROOT)/lib/intprops.h.
11935
f0c77cd1
PE
119362011-03-13 Paul Eggert <eggert@cs.ucla.edu>
11937
3eca4629
PE
11938 Fix more problems found by GCC 4.5.2's static checks.
11939
7c86ee98
PE
11940 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
11941 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
11942 (xg_free_frame_widgets): Make it clear that a local variable is
11943 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
11944 (gdk_window_get_screen): Make it clear that this macro is needed
11945 only if USE_GTK_TOOLTIP.
1e5524e7
PE
11946 (int_gtk_range_get_value): New function, which avoids a diagnostic
11947 from gcc -Wbad-function-cast.
11948 (xg_set_toolkit_scroll_bar_thumb): Use it.
11949 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
11950 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
11951 (get_utf8_string, xg_get_file_with_chooser):
11952 Rename locals to avoid shadowing.
11953 (create_dialog): Move locals to avoid shadowing.
7c86ee98 11954
41729b81
PE
11955 * xgselect.c (xg_select): Remove unused var.
11956
f0c77cd1
PE
11957 * image.c (four_corners_best): Mark locals as initialized.
11958 (gif_load): Initialize transparent_p to zero (Bug#8238).
11959 Mark another local as initialized.
ec6cf4c6 11960 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 11961
ce0ad53d 11962 * image.c (clear_image_cache): Now static.
d5d5a617 11963 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 11964 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
11965 (x_edge_detection): Remove unnecessary cast that
11966 gcc -Wbad-function-cast diagnoses.
2037898d 11967 (gif_load): Fix pointer signedness.
6ae141d6
PE
11968 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
11969 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 11970
33383987 119712011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 11972
d32df629
PE
11973 Improve quality of tests for time stamp overflow.
11974 For example, without this patch (encode-time 0 0 0 1 1
11975 1152921504606846976) returns the obviously-bogus value (-948597
11976 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
11977 reports time overflow. See
11978 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
11979 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
11980 * editfns.c: Include limits.h and intprops.h.
11981 (TIME_T_MIN, TIME_T_MAX): New macros.
11982 (time_overflow): Move earlier, to before first use.
11983 (hi_time, lo_time): New functions, for an accurate test for
11984 out-of-range times.
11985 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
11986 (Fget_internal_run_time): Don't assume time_t fits in int.
11987 (make_time): Use list2 instead of Fcons twice.
11988 (Fdecode_time): More accurate test for out-of-range times.
11989 (check_tm_member): New function.
11990 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
11991 (lisp_time_argument): Don't rely on undefined left-shift and
11992 right-shift behavior when checking for time stamp overflow.
8be6f318 11993
fe31d94c
PE
11994 * editfns.c (time_overflow): New function, refactoring common code.
11995 (Fformat_time_string, Fdecode_time, Fencode_time):
11996 (Fcurrent_time_string): Use it.
11997
8be6f318
PE
11998 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
11999 * dired.c (make_time): Move to ...
12000 * editfns.c (make_time): ... here.
12001 * systime.h: Note the move.
12002
09d9db2c 120032011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 12004
126bc0dc
YM
12005 * fringe.c (update_window_fringes): Remove unused variables.
12006
c47cbdfd
YM
12007 * unexmacosx.c (copy_data_segment): Also copy __got section.
12008 (Bug#8223)
12009
7ac80be9
EZ
120102011-03-12 Eli Zaretskii <eliz@gnu.org>
12011
c96bbc66 12012 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
12013 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
12014 Constify `char *' arguments and their references according to
12015 prototypes in tparam.h.
12016
ecb0f94d 12017 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 12018
7ac80be9
EZ
12019 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
12020 Adapt all references accordingly.
12021
12022 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
12023
ef1fd07e
TT
120242011-03-11 Tom Tromey <tromey@redhat.com>
12025
12026 * buffer.c (syms_of_buffer): Remove obsolete comment.
12027
7ef4b50c
EZ
120282011-03-11 Eli Zaretskii <eliz@gnu.org>
12029
12030 * termhooks.h (encode_terminal_code): Declare prototype.
12031
12032 * msdos.c (encode_terminal_code): Don't declare prototype.
12033
12034 * term.c (encode_terminal_code): Now external again, used by
12035 w32console.c and msdos.c.
12036
44f230aa
SM
12037 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
12038 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 12039
4b1ec863 120402011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 12041
1714f52b 12042 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 12043
4b1ec863
PE
12044 * fringe.c (update_window_fringes): Mark locals as initialized
12045 (Bug#8227).
12046 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 12047
524c7aa6
PE
12048 * alloc.c (mark_fringe_data): Move decl from here ...
12049 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
12050 to check its interface.
12051 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
12052
a5c0af81 12053 * fontset.c (free_realized_fontset): Now static.
7519b8cd 12054 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 12055 (fontset_font): Mark local as initialized.
a9a06e0b 12056 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 12057
b4716021
PE
12058 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
12059
811e9bac 12060 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 12061 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
12062 (x_own_selection, Fx_disown_selection_internal): Rename locals
12063 to avoid shadowing.
12064 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 12065
7e3ab302
PE
12066 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
12067 so that the caller can use some name other than gcpro1.
12068 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
12069 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12070 (Fx_backspace_delete_keys_p):
12071 Use them to avoid shadowing, and rename vars to avoid shadowing.
12072 (x_decode_color, x_set_name, x_window): Now static.
6b437900 12073 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 12074 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
12075 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
12076 Remove unused locals.
7e3ab302
PE
12077 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12078 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
12079 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
12080 macros.
f78faa98 12081
e2b13473
PE
12082 * xterm.h (x_mouse_leave): New decl.
12083
77f23912
PE
12084 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
12085 Remove unused functions.
cdf4ba58
PE
12086 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
12087 (x_calc_absolute_position): Now static.
7411c686 12088 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 12089 Don't declare local "event" unless it's used.
ed7bf3a5
PE
12090 (x_iconify_frame, x_free_frame_resources): Don't declare locals
12091 unless they are used.
38d0b34a
PE
12092 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
12093 (x_fatal_error_signal): Remove; not used.
a6067996
PE
12094 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
12095 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
12096 (x_error_catcher, x_connection_closed, x_error_handler):
12097 (x_error_quitter, xembed_send_message, x_iconify_frame):
12098 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 12099 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 12100 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 12101
44f230aa
SM
12102 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
12103 Rename or move locals to avoid shadowing.
6b463e58 12104 (tty_defined_color, merge_face_heights): Now static.
5967d051 12105 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
12106 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
12107 does not deduce is never used uninitialized.
73719eba
PE
12108 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
12109 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 12110
426994c3 12111 * terminal.c (store_terminal_param): Now static.
5489860b 12112
032f1620 12113 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 12114 (set_frame_menubar): Remove unused local.
d4323972 12115 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
12116 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
12117 since they might point to immutable storage.
281585b0
PE
12118 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
12119 since it's unused otherwise.
032f1620 12120
367c19e5 12121 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 12122 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
12123 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
12124 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 12125 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
12126 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
12127 does not deduce are never used uninitialized.
70739cbe 12128
07b48fa9
PE
12129 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
12130
8868a238 12131 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
12132 * window.c (window_loop, size_window):
12133 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 12134
7e5cf297 12135 * window.c (display_buffer): Now static.
d6550a9f
PE
12136 (size_window): Mark variables that gcc -Wuninitialized
12137 does not deduce are never used uninitialized.
a586633d
PE
12138 * window.h (check_all_windows): New decl, to forestall
12139 gcc -Wmissing-prototypes diagnostic.
5b555da1 12140 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 12141
f6095868
PE
12142 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
12143 shadowing.
12144 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
12145 Include <limits.h>.
12146 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
12147 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
12148 (load_charset_map): Mark variables that gcc -Wuninitialized
12149 does not deduce are never used uninitialized.
53df7c11 12150 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 12151
f38b440c
PE
12152 * coding.c (coding_set_source, coding_set_destination):
12153 Use "else { /* comment */ }" rather than "else /* comment */;"
12154 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
12155 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
12156 a block, when the outer 'i' will do.
12157 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
12158 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
12159 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
12160 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
12161 (Fdecode_sjis_char, Fdefine_coding_system_internal):
12162 Rename locals to avoid shadowing.
12163 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
12164 * coding.c (emacs_mule_char, encode_invocation_designation):
12165 Now static, since they're not used elsewhere.
413bb2db 12166 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 12167 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
12168 (decode_coding_emacs_mule): Mark variables that gcc
12169 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
12170 (detect_coding_iso_2022): Initialize a local variable that might
12171 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 12172 this initialization is needed. (Bug#8211)
5f58e762
PE
12173 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
12174 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
12175 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
12176 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
12177 Remove unused macros.
f38b440c 12178
232b38b9 12179 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 12180 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 12181 * character.c (string_count_byte8): Likewise.
232b38b9 12182
fb90da1b
PE
12183 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
12184 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
12185
fb93dbc2
PE
12186 * chartab.c (copy_sub_char_table): Now static, since it's not used
12187 elsewhere.
5c156ace
PE
12188 (sub_char_table_ref_and_range, char_table_ref_and_range):
12189 Rename locals to avoid shadowing.
bbcd0949 12190 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 12191
7d3b3862 12192 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 12193 (BIDI_BOB): Remove unused macro.
7d3b3862 12194
6be7d3da
PE
12195 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
12196 deduce are never used uninitialized.
c2ed9c8b 12197 * term.c (encode_terminal_code): Likewise.
6be7d3da 12198
75f8807f 12199 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 12200
50938595
PE
12201 * tparam.h: New file.
12202 * term.c, tparam.h: Include it.
12203 * deps.mk (term.o, tparam.o): Depend on tparam.h.
12204 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
12205 Move these decls to tparam.h, and make them agree with what
12206 is actually in tparam.c. The previous trick of using incompatible
12207 decls in different modules does not conform to the C standard.
12208 All callers of tparam changed to use tparam's actual API.
12209 * tparam.c (tparam1, tparam, tgoto):
12210 Use const pointers where appropriate.
12211
fbceeba2
PE
12212 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
12213 * cm.h (struct cm): Likewise.
12214 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
12215 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
12216 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
12217 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
12218 (turn_on_face, init_tty): Likewise.
12219 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 12220
7f3f1250
PE
12221 * term.c (term_mouse_position): Rename local to avoid shadowing.
12222
e6ca6543
PE
12223 * alloc.c (mark_ttys): Move decl from here ...
12224 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
12225
c40f8d15
AS
122262011-03-11 Andreas Schwab <schwab@linux-m68k.org>
12227
12228 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
12229
cfe0661d
JB
122302011-03-09 Juanma Barranquero <lekktu@gmail.com>
12231
12232 * search.c (compile_pattern_1): Remove argument regp, unused since
12233 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
12234 (compile_pattern): Don't pass it.
12235
0afb4571
J
122362011-03-08 Jan Djärv <jan.h.d@swipnet.se>
12237
12238 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
12239 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
12240 for ! HAVE_GTK3.
12241 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
12242
12243 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
12244
12245 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
12246 gdk_window_get_screen, gdk_window_get_geometry,
12247 gdk_x11_window_lookup_for_display and GDK_KEY_g.
12248 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
12249 (xg_get_pixbuf_from_pixmap): New function.
12250 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
12251 to Pixmap, take frame as parameter, remove GdkColormap parameter.
12252 Call xg_get_pixbuf_from_pixmap instead of
12253 gdk_pixbuf_get_from_drawable.
12254 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
12255 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
12256 (xg_check_special_colors): Use GtkStyleContext and its functions
12257 for HAVE_GTK3.
12258 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
12259 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
12260 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
12261 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
12262 Call gtk_widget_get_preferred_size.
0afb4571
J
12263 (xg_frame_resized): gdk_window_get_geometry only takes 5
12264 parameters.
44f230aa
SM
12265 (xg_win_to_widget, xg_event_is_for_menubar):
12266 Call gdk_x11_window_lookup_for_display.
0afb4571
J
12267 (xg_set_widget_bg): New function.
12268 (delete_cb): New function.
895009e1 12269 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 12270 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
12271 (xg_set_background_color): Call xg_set_widget_bg.
12272 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
12273 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
12274 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
12275 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
12276 if ! HAVE_GTK3.
12277 (update_frame_tool_bar): Call gtk_widget_hide.
12278 (xg_initialize): Use GDK_KEY_g.
12279
12280 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
12281 if ! HAVE_GTK3
12282 (x_session_initialize): Call gdk_x11_set_sm_client_id.
12283
12284 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
12285 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
12286 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
12287
1c2cc4ef
JB
122882011-03-08 Juanma Barranquero <lekktu@gmail.com>
12289
12290 * w32xfns.c (select_palette): Check success of RealizePalette against
12291 GDI_ERROR, not zero.
12292
33383987 12293See ChangeLog.11 for earlier changes.
aac0c6e3
MR
12294
12295;; Local Variables:
12296;; coding: utf-8
aac0c6e3
MR
12297;; End:
12298
2f097256 12299 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
12300
12301 This file is part of GNU Emacs.
12302
12303 GNU Emacs is free software: you can redistribute it and/or modify
12304 it under the terms of the GNU General Public License as published by
12305 the Free Software Foundation, either version 3 of the License, or
12306 (at your option) any later version.
12307
12308 GNU Emacs is distributed in the hope that it will be useful,
12309 but WITHOUT ANY WARRANTY; without even the implied warranty of
12310 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12311 GNU General Public License for more details.
12312
12313 You should have received a copy of the GNU General Public License
12314 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.