Inhibit null-string composition component (Bug#6988).
[bpt/emacs.git] / src / ChangeLog
CommitLineData
d2a51fd7
KH
12012-02-01 Kenichi Handa <handa@m17n.org>
2
3 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
4 NULL (Bug#6988).
5 (x_produce_glyphs): If the component of a composition is a null
6 string, set it->pixel_width to 1 to avoid zero-width glyph.
7
97897668
GM
82012-01-31 Glenn Morris <rgm@gnu.org>
9
10 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 11 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
12 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
13
31fd3586
GM
142012-01-29 Glenn Morris <rgm@gnu.org>
15
16 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
17
0e24a8b2
CY
182012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
19
20 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
21
cc0adcb0
CY
222012-01-28 Chong Yidong <cyd@gnu.org>
23
0e24a8b2 24
cc0adcb0
CY
25 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
26
acc28cb9
CY
272012-01-26 Chong Yidong <cyd@gnu.org>
28
9c69cfb7
CY
29 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
30
acc28cb9
CY
31 * search.c (Fsearch_forward, Fsearch_backward): Document negative
32 repeat counts (Bug#10507).
33
48da7392
GM
342012-01-26 Glenn Morris <rgm@gnu.org>
35
36 * lread.c (syms_of_lread): Doc fix.
37
14af5f7f
CY
382012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
39
40 * coding.c (encode_designation_at_bol): Change return value to
41 EMACS_INT.
42
0b21c100
CY
432012-01-25 Chong Yidong <cyd@gnu.org>
44
45 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
46
3c2907f7
CY
472012-01-21 Chong Yidong <cyd@gnu.org>
48
49 * floatfns.c (Fcopysign): Make the second argument non-optional,
50 since nil is not allowed anyway.
51
959ad23f
AS
522012-01-21 Andreas Schwab <schwab@linux-m68k.org>
53
54 * process.c (read_process_output): Use p instead of XPROCESS (proc).
55 (send_process): Likewise.
56
34a02f46
MR
572012-01-19 Martin Rudalics <rudalics@gmx.at>
58
59 * window.c (save_window_save, Fcurrent_window_configuration)
60 (Vwindow_persistent_parameters): Do not use Qstate. Rewrite
61 doc-strings.
62
1259009a 632012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
64
65 * character.c (char_width): New function.
70d4fdf6
GM
66 (Fchar_width, c_string_width, lisp_string_width):
67 Use char_width (Bug#9496).
25ed9e61 68
6a6ee00d
MR
692012-01-16 Martin Rudalics <rudalics@gmx.at>
70
71 * window.c (Vwindow_persistent_parameters): New variable.
72 (Fset_window_configuration, save_window_save): Handle persistent
73 window parameters.
74
c85efaf7
EZ
752012-01-14 Eli Zaretskii <eliz@gnu.org>
76
77 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
78 thrashing the stack of the thread. (Bug#9087)
79
5944709e
PE
802012-01-12 Paul Eggert <eggert@cs.ucla.edu>
81
82 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
83
e71f5d99
EZ
842012-01-11 Eli Zaretskii <eliz@gnu.org>
85
86 * xdisp.c (rows_from_pos_range): Handle the case where the
87 highlight ends on a newline. (Bug#10464)
88 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
89 he end column for display of highlight that ends on a newline
90 before a R2L line.
91
ce316182
GM
922012-01-11 Glenn Morris <rgm@gnu.org>
93
94 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
95 from load-path also when installation-directory is nil. (Bug#10208)
96
5b43da69
GM
972012-01-10 Glenn Morris <rgm@gnu.org>
98
74cc8ff9
GM
99 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
100
7d8d6e4e
GM
101 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
102 Update template values to be closer to their typical values these days.
5b43da69 103
a0db8d43
EZ
1042012-01-09 Eli Zaretskii <eliz@gnu.org>
105
106 * xdisp.c (rows_from_pos_range): Accept additional argument
107 DISP_STRING, and accept any glyph in a row whose object is that
108 string as eligible for mouse highlight. Fixes mouse highlight of
109 display strings from overlays. (Bug#10464)
110
9a0115ab 1112012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 112
b9110d6a 113 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
114 * fileio.c (auto_saving_dir_umask): New static var.
115 (Fmake_directory_internal): Use it.
116 (do_auto_save_make_dir): Set it, instead of invoking chmod after
117 creating the directory. The old code temporarily assigns
118 too-generous permissions to the directory.
119 (do_auto_save_eh): Clear it.
b9110d6a 120 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
121 that the var is always cleared.
122
6c1bd3f3
EZ
1232012-01-07 Eli Zaretskii <eliz@gnu.org>
124
125 * search.c (scan_buffer): Pass character positions to
126 know_region_cache, not byte positions. (Bug#6540)
127
069d2b50
L
1282012-01-07 LynX <_LynX@bk.ru> (tiny change)
129
130 * w32.c (sys_rename): Report EXDEV when rename of a directory
131 fails because the target is on another logical disk. (Bug#10284)
132
75bf0d33
DB
1332012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
134
135 * xterm.c (x_embed_request_focus): New function.
136
137 * xterm.h: Add prototype.
138
139 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
140
1c6e5a32
GM
1412012-01-05 Glenn Morris <rgm@gnu.org>
142
143 * emacs.c (emacs_copyright): Update short copyright year to 2012.
144
651e947e
EZ
1452012-01-01 Eli Zaretskii <eliz@gnu.org>
146
147 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
148 Load gnutls_transport_set_lowat only if GnuTLS version is below
149 2.11.1.
150 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
151 GnuTLS versions below 2.11.1.
152
3778cdd8
AL
1532011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
154
155 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
156 to the doc string advising against its use for altering the way
157 windows are scrolled.
158
0e5317f7
KH
1592011-12-28 Kenichi Handa <handa@m17n.org>
160
161 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
162 coding-system ASCII compatible only when it does not produce BOM
163 on encoding (Bug#10383).
164
93d5ca1f
JD
1652011-12-26 Jan Djärv <jan.h.d@swipnet.se>
166
167 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
168 can scroll.
169 (create_and_show_popup_menu): Always use menu_position_func for
170 Gtk3 (Bug#10361).
171
ca22b785
AS
1722011-12-24 Andreas Schwab <schwab@linux-m68k.org>
173
174 * callint.c (Fcall_interactively): Don't truncate prompt string.
175
d048e1e6
EZ
1762011-12-23 Eli Zaretskii <eliz@gnu.org>
177
178 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
179 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 180 resumed from there (after widening). (Bug#10360)
d048e1e6 181
5ccaba1f
JD
1822011-12-22 Jan Djärv <jan.h.d@swipnet.se>
183
184 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
185
204ee57f
JD
1862011-12-21 Jan Djärv <jan.h.d@swipnet.se>
187
b81d40f0
JB
188 * nsterm.m (x_free_frame_resources):
189 Release f->output_data.ns->miniimage.
204ee57f
JD
190 (ns_index_color): Fix indentation. Do not retain
191 color_table->colors[i].
192
193 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
194 before returning.
195
196 * nsfns.m (x_set_background_color): Assign return value from
197 ns_index_color to face-background instead of NSColor*.
198 (ns_implicitly_set_icon_type): Fix indentation.
199 Change assignment in for loop to comparison.
200
201 * emacs.c (ns_pool): New variable.
202 (main): Assign ns_pool.
203 (Fkill_emacs): Call ns_release_autorelease_pool.
204
205 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
206 autorelease fdesc, release fdAttrs and tdict.
207 (ns_get_covering_families): Release charset.
208 (ns_findfonts): Release NSFontDescriptor created with new.
209 (ns_uni_to_glyphs): Fix indentation.
210 (setString): Release attrStr before assigning new value.
211
c803b2b7
JD
2122011-12-18 Jan Djärv <jan.h.d@swipnet.se>
213
678f4426
JD
214 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
215 and NS_IMPL_COCOA.
216 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
217 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
218
cd394be1 2192011-12-18 David Reitter <reitter@cmu.edu>
678f4426 220
5fecd5fc
JD
221 * nsterm.m (ns_term_init): Subscribe for notifications
222 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
223 to method trackingNotification in EmacsMenu.
224
225 * nsmenu.m (trackingMenu): New variable.
3771cb17 226 (trackingNotification): New method (from Aquamacs).
5fecd5fc 227 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 228 from Aquamacs (Bug#7030).
678f4426
JD
229
2302011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 231
c803b2b7
JD
232 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
233 (symbol_to_nsstring): Fix indentation.
234 (ns_symbol_to_pb): New function.
235 (Fns_get_selection_internal): Renamed from Fns_get_cut_buffer_internal.
236 (Fns_rotate_cut_buffers_internal): Removed.
237 (Fns_store_selection_internal): Renamed from
238 Fns_store_cut_buffer_internal.
239 (ns_get_foreign_selection, Fx_own_selection_internal)
240 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
241 (Fns_get_selection_internal, Fns_store_selection_internal):
242 Use ns_symbol_to_pb and check if return value is nil.
243 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
244 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
245 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
246 renamed to Sns_store_selection_internal.
247 (ns_handle_selection_request): Move code to Fx_own_selection_internal
248 and remove this function.
249 (ns_handle_selection_clear): Remove, never used.
250 (Fx_own_selection_internal): Move code from ns_handle_selection_request
251 here.
252
e1b01a3a
KB
2532011-12-17 Ken Brown <kbrown@cornell.edu>
254
255 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
256 GID is unknown (Bug#10257).
257
2adb6e85
PE
2582011-12-17 Paul Eggert <eggert@cs.ucla.edu>
259
260 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
261 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
262 which caused a build failure on GNU/Linux IA-64. This problem was
263 introduced by my 2011-10-07 patch.
264
d1d7b339
JL
2652011-12-15 Juri Linkov <juri@jurta.org>
266
267 * image.c (imagemagick_error): New function. (Bug#10112)
268 (imagemagick_load_image): Comment out `MagickSetResolution' call.
269 Use `imagemagick_error' where ImageMagick functions return
270 `MagickFalse'.
271 (Fimagemagick_types): Add `Fnreverse' to return the list in the
272 proper order.
273
100d5755
KH
2742011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
275
276 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
277 fill background (Bug#8992).
278
454592a6
MR
2792011-12-13 Martin Rudalics <rudalics@gmx.at>
280
281 * window.c (Vwindow_combination_resize)
282 (Vwindow_combination_limit): Use t instead of non-nil in
283 doc-strings.
61d4b438
MR
284 (Vrecenter_redisplay): Add first sentence of doc-string on
285 separate line.
53524d93 286 (Frecenter): Fix doc-string typo.
454592a6 287
3633e3aa
KH
2882011-12-11 Kenichi Handa <handa@m17n.org>
289
290 * coding.c (Funencodable_char_position): Pay attention to the
291 buffer text relocation (Bug#9389).
292
7b9d523a
JD
2932011-12-10 Jan Djärv <jan.h.d@swipnet.se>
294
295 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
296 gtk_init (Bug#10100).
297
b73189c6
EZ
2982011-12-10 Eli Zaretskii <eliz@gnu.org>
299
300 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
301 IT->string is nil. (Bug#10263)
302
f7dfe5d6
JD
3032011-12-10 Jan Djärv <jan.h.d@swipnet.se>
304
83faebb4
JD
305 * nsterm.h (x_free_frame_resources): Declare.
306
f7dfe5d6
JD
307 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
308 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
309
310 * nsterm.h (ns_get_defaults_value): Declare.
311
312 * nsterm.m (ns_default): Call ns_get_defaults_value.
313
7cd4e72c
EZ
3142011-12-09 Eli Zaretskii <eliz@gnu.org>
315
316 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
317 (Bug#10170)
318
b34d7317
YM
3192011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
320
321 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
322 that where the value of an _OBJC_* symbol points to is in the .bss
323 section (Bug#10240).
324
76470ad1
KH
3252011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
326
327 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 328 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 329
745fff94
KH
3302011-12-08 Kenichi Handa <handa@m17n.org>
331
332 * ftfont.c (get_adstyle_property): Fix previous change
333 (Bug#10233).
334
6e44397c
JB
3352011-12-07 Juanma Barranquero <lekktu@gmail.com>
336
337 * w32.c (init_environment): If no_site_lisp, remove site-lisp
338 dirs from the default value of EMACSLOADPATH (bug#10208).
339
7efa6272
GM
3402011-12-07 Glenn Morris <rgm@gnu.org>
341
342 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
343 installation and source directories as well. (Bug#10208)
344
f6fc4d87
CY
3452011-12-06 Chong Yidong <cyd@gnu.org>
346
347 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
348
2bf26180
GM
3492011-12-06 Glenn Morris <rgm@gnu.org>
350
351 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
352 as an error, not just -1. (Bug#10217)
353
3a6ad4f0
CY
3542011-12-05 Chong Yidong <cyd@gnu.org>
355
356 * keyboard.c (process_special_events): New function.
357 (swallow_events, Finput_pending_p): Use it (Bug#10195).
358
75a3b399
PE
3592011-12-05 Paul Eggert <eggert@cs.ucla.edu>
360
361 * coding.c (encode_designation_at_bol): Don't use uninitialized
362 local variable (Bug#9318).
363
c3c9e25e
KH
3642011-12-05 Kenichi Handa <handa@m17n.org>
365
366 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
367 return Qnil (Bug#8046, Bug#10193).
368
5eb05ea3
KH
3692011-12-05 Kenichi Handa <handa@m17n.org>
370
371 * coding.c (encode_designation_at_bol): New args charbuf_end and
372 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
373 (coding_set_source): Return how many bytes coding->source was
374 relocated.
375 (coding_set_destination): Return how many bytes
376 coding->destination was relocated.
377 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
378 (CODING_CHAR_CHARSET_P): Adjusted for the avove changes.
5eb05ea3
KH
379
3802011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
381
382 * coding.c (CODING_CHAR_CHARSET_P): New macro.
383 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
384 macro (Bug#9318).
385
3862011-12-05 Andreas Schwab <schwab@linux-m68k.org>
387
388 The following changes are to fix Bug#9318.
389
a79703f5 390 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
391 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
392 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 393 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 394
7dbda6df
JB
3952011-12-05 Juanma Barranquero <lekktu@gmail.com>
396
397 * lisp.h (process_quit_flag): Fix external declaration.
398
6d5eb5b0
SM
3992011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
400
401 Don't macro-inline non-performance-critical code.
402 * eval.c (process_quit_flag): New function.
403 * lisp.h (QUIT): Use it.
404
a0c3fad0
JD
4052011-12-04 Jan Djärv <jan.h.d@swipnet.se>
406
407 * nsfns.m (get_geometry_from_preferences): New function.
408 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
409
6c07aac2
AS
4102011-12-04 Andreas Schwab <schwab@linux-m68k.org>
411
412 * emacs.c (Qkill_emacs): Define.
413 (syms_of_emacs): Initialize it.
414 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
415 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
416 (quit_throw_to_read_char): Add parameter `from_signal'.
417 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
418 * lisp.h (QUIT): Call Fkill_emacs if requested.
419
c052ead4
JD
4202011-12-03 Jan Djärv <jan.h.d@swipnet.se>
421
422 * widget.c (update_wm_hints): Return if wmshell is null.
423 (widget_update_wm_size_hints): New function.
424
425 * widget.h (widget_update_wm_size_hints): Declare.
426
427 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
428 widget_update_wm_size_hints (Bug#10104).
429
9e49252b
EZ
4302011-12-03 Eli Zaretskii <eliz@gnu.org>
431
432 * xdisp.c (handle_invisible_prop): If the invisible text ends just
433 before a newline, prepare the bidi iterator for consuming the
434 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 435 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 436
02b16839
JL
4372011-12-02 Juri Linkov <juri@jurta.org>
438
439 * search.c (Fword_search_regexp): New Lisp function created from
440 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
441 (Fword_search_backward, Fword_search_forward)
442 (Fword_search_backward_lax, Fword_search_forward_lax):
443 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
444 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
445
0068070e
SM
4462011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
447
448 * fileio.c (Finsert_file_contents): Move after-change-function call
449 to before the "handled:" label, since all "goto handled" appear in
450 cases where the *-change-functions have already been properly called
451 (bug#10117).
452
3360a3fc
AS
4532011-12-01 Andreas Schwab <schwab@linux-m68k.org>
454
455 * keyboard.c (interrupt_signal): Don't call kill-emacs when
456 waiting for input. (Bug#10169)
457
73d6c093
EZ
4582011-11-30 Eli Zaretskii <eliz@gnu.org>
459
460 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
461 verifies glyph row's hash code--we have just reallocated the
462 glyphs, so their contents can be complete garbage. (Bug#10164)
463
febe6bea
JB
4642011-11-30 Juanma Barranquero <lekktu@gmail.com>
465
466 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
467
801a4313
EZ
4682011-11-30 Eli Zaretskii <eliz@gnu.org>
469
470 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
471 attributes are tested _before_ calling verify_row_hash, to protect
472 against GCC re-ordering of the tests. (Bug#10164)
473
2b56b87e
JD
4742011-11-29 Jan Djärv <jan.h.d@swipnet.se>
475
476 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
477
478 * xterm.c (handle_one_xevent): Only set async_visible and friends
479 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 480 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
481 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
482
dbf31225
PE
4832011-11-28 Paul Eggert <eggert@cs.ucla.edu>
484
485 Remove GCPRO-related macros that exist only to avoid shadowing locals.
486 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
487 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
488 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
489 All uses changed to use GCPRO1 etc.
490 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
491 Revert to old implementation (i.e., before 2011-03-11).
492
1305621b
YM
4932011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
494
495 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
496 of scroll runs so as to avoid assigning disabled bogus rows and
497 unnecessary graphics copy operations.
498
8c9afb46
EZ
4992011-11-27 Eli Zaretskii <eliz@gnu.org>
500
501 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
502 (snprintf) [_MSC_VER]: Redirect to _snprintf.
503 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
504 (malloc, free, realloc, calloc): Redirect to e_* only when
505 compiling Emacs.
506
507 * lisp.h (GCTYPEBITS): Move before first use.
508 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
509 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
510 this macro definition.
511
512 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
513 _MSC_VER.
514
54e9e3bf
JD
5152011-11-27 Jan Djärv <jan.h.d@swipnet.se>
516
6d5eb5b0
SM
517 * gtkutil.c (xg_create_frame_widgets):
518 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
519 present with Gtk+ 2.0.
520
83aca1cb
PE
5212011-11-26 Paul Eggert <eggert@cs.ucla.edu>
522
523 * fileio.c (Finsert_file_contents): Undo previous change; see
524 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
525
5b76caa4
PE
5262011-11-26 Paul Eggert <eggert@cs.ucla.edu>
527
528 Rename locals to avoid shadowing.
529 * fileio.c (Finsert_file_contents):
530 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
531 * process.c (wait_reading_process_output):
532 Rename inner 'proc' to 'p' to avoid shadowing.
533 Indent for consistency with usual Emacs style.
534
8c535114
EZ
5352011-11-25 Eli Zaretskii <eliz@gnu.org>
536
537 * xdisp.c (redisplay_window): If cursor row is not fully visible
538 after recentering, and scroll-conservatively is set to a large
539 number, scroll window by a few more lines to make the cursor fully
540 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
541 (start_display): Don't move to the next line if the display should
542 start at a newline that is part of a display vector or an overlay
543 string. (Bug#10119)
8c535114 544
fa4fdb5c
JL
5452011-11-24 Juri Linkov <juri@jurta.org>
546
547 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
548 after the `MagickPingImage' call. (Bug#10112)
549
90ec88df
CY
5502011-11-23 Chong Yidong <cyd@gnu.org>
551
552 * window.c (Fcoordinates_in_window_p): Accept only live windows.
553
56e2e794
MR
5542011-11-23 Martin Rudalics <rudalics@gmx.at>
555
556 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
557 making another buffer current. (Bug#10114)
558
b6e64c41
GM
5592011-11-23 Glenn Morris <rgm@gnu.org>
560
561 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
562
6b21de18
CY
5632011-11-23 Chong Yidong <cyd@gnu.org>
564
565 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
566 using it (Bug#5984).
567
b12cd789
EZ
5682011-11-22 Eli Zaretskii <eliz@gnu.org>
569
570 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
571 and header-lines, as they don't have one computed for them.
572 (Bug#10098)
573
574 * .gdbinit (prow): Make displayed values more self-explaining.
575 Add row's hash code.
576
261b6fd4
LMI
5772011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
578
579 * process.c (wait_reading_process_output): Fix asynchrounous
580 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 581 (wait_reading_process_output): Add comment and URL.
261b6fd4 582
e7cfd277
JD
5832011-11-21 Jan Djärv <jan.h.d@swipnet.se>
584
585 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
586
a9b9b7f5
CY
5872011-11-21 Chong Yidong <cyd@gnu.org>
588
589 * window.c (Fnext_window, Fprevious_window): Doc fix.
590
b0d15b4f
SM
5912011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
592
593 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
594
fe7a3057
JB
5952011-11-20 Juanma Barranquero <lekktu@gmail.com>
596
597 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
598
d2999b1a
MR
5992011-11-20 Martin Rudalics <rudalics@gmx.at>
600
601 * window.c (Fset_window_combination_limit): Rename argument
602 STATUS to LIMIT.
603 (Vwindow_combination_limit): Remove "status" from doc-string.
604
d5ff9cd0
AS
6052011-11-20 Andreas Schwab <schwab@linux-m68k.org>
606
607 * m/ibms390.h: Remove.
608 * m/ibms390x.h: Don't include "ibms390.h".
609
a5bb9bd3
SM
6102011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
611
612 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
613 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
614
cd1181db
JB
6152011-11-20 Juanma Barranquero <lekktu@gmail.com>
616
617 * casetab.c (Fset_case_table):
618 * charset.c (Fcharset_after): Fix typos.
619
615a3b8d 6202011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 621
17e845af
PE
622 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
623 Otherwise, valgrind does not work on some platforms.
624 Problem reported by Andreas Schwab in
6a0bf43d
PE
625 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
626 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
627 is set, removing the need for VIRT_ADDRESS_VARIES.
628 (PURE_P): Use a more-efficient implementation that needs just one
629 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
630 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
631 to 4 (xorl, subq, cmpq, setbe).
632 * alloc.c (pure): Always extern now, since that's the
633 VIRT_ADDR_VARIES behavior.
634 (PURE_POINTER_P): Use a single comparison, not two, for
635 consistency with the new puresize.h.
636 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
637 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
638 Remove VIRT_ADDR_VARIES no longer needed.
639
f8fe6f96
EZ
6402011-11-19 Eli Zaretskii <eliz@gnu.org>
641
642 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
643 (erase_phys_cursor, update_window_cursor, show_mouse_face)
644 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
645 behave as if the cursor position were at the window margin.
646
647 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
648 and the cursor position is out of bounds, behave as if the cursor
649 position were at the window margin. (Bug#10075)
650
df05a53c
CY
6512011-11-18 Chong Yidong <cyd@gnu.org>
652
653 * window.c (Fwindow_combination_limit): Make first argument
654 non-optional, since it is meaningless for live windows like the
655 selected window.
656
2071918e
DA
6572011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
658
659 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
660
b50a28de
SM
6612011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
662
663 * intervals.c: Fix grafting over the whole buffer (bug#10071).
664 (graft_intervals_into_buffer): Simplify.
665
015137db
EZ
6662011-11-18 Eli Zaretskii <eliz@gnu.org>
667
668 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
669 hash values of the two rows.
670 (copy_row_except_pointers): Preserve the used[] arrays and the
671 hash values of the two rows. (Bug#10035)
68c95424 672 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
673
674 * xdisp.c (row_hash): New function, body extracted from
675 compute_line_metrics.
676 (compute_line_metrics): Call row_hash, instead of computing the
677 hash code inline.
678
679 * dispnew.c (verify_row_hash): Call row_hash for computing the
680 hash code of a row, instead of duplicating code from xdisp.c.
681
682 * dispextern.h (row_hash): Add prototype.
683
a2addb04
TH
6842011-11-18 Tassilo Horn <tassilo@member.fsf.org>
685
686 * frame.c (delete_frame): Don't delete the terminal when the last
687 X frame is closed if emacs is built with GTK toolkit.
688
df85d315
JB
6892011-11-17 Juanma Barranquero <lekktu@gmail.com>
690
691 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
692
a0c2d0ae
MR
6932011-11-17 Martin Rudalics <rudalics@gmx.at>
694
695 * window.c (Vwindow_splits): Rename to
696 Vwindow_combination_resize. Suggested by Juri Linkov.
697 (Fsplit_window_internal): Use Vwindow_combination_resize instead
698 of Vwindow_splits.
699
58179cce
JB
7002011-11-16 Juanma Barranquero <lekktu@gmail.com>
701
7877f373
JB
702 * nsfns.m (Fns_font_name):
703 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 704
b6f67890
MR
7052011-11-16 Martin Rudalics <rudalics@gmx.at>
706
707 * window.h (window): Rename slot "nest" to "combination_limit".
708 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
709 (Fset_window_nest): Rename to Fset_window_combination_limit.
710 (Vwindow_nest): Rename to Vwindow_combination_limit.
711 (recombine_windows, make_parent_window, make_window)
712 (Fsplit_window_internal, saved_window)
713 (Fset_window_configuration, save_window_save): Rename all
714 occurrences of window_nest to window_combination_limit.
715
c7015153
JB
7162011-11-15 Juanma Barranquero <lekktu@gmail.com>
717
718 * image.c (imagemagick_load_image): Fix typo.
719
322ad6ec
EZ
7202011-11-14 Eli Zaretskii <eliz@gnu.org>
721
722 * xdisp.c (display_line): Move the call to
723 highlight_trailing_whitespace before the call to
724 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
725 faces of all the glyphs to compute ROW's hash value.
726 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 727
f067b8ec
JB
7282011-11-14 Juanma Barranquero <lekktu@gmail.com>
729
730 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
731 just return (bug#10044).
732
1e5b2111
EZ
7332011-11-12 Eli Zaretskii <eliz@gnu.org>
734
7ef3cbd5
EZ
735 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
736 with user-defined heap size. Bump the default size of the temacs
737 heap to 27MB, to avoid memory warning when running temacs.
738 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
739
1e5b2111
EZ
740 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
741 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
742 (verify_row_hash) [XASSERTS]: New function.
743 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
744 that the hash value of glyph rows is correct.
1e5b2111 745
89d61221
MR
7462011-11-12 Martin Rudalics <rudalics@gmx.at>
747
748 * window.h (window): Remove splits slot.
749 * window.c (Fwindow_splits, Fset_window_splits): Remove.
750 (Fdelete_other_windows_internal, make_parent_window)
751 (make_window, Fsplit_window_internal, Fdelete_window_internal)
752 (Fset_window_configuration, save_window_save): Don't deal with
753 split status of windows.
754 (saved_window): Remove splits slot.
755 (Vwindow_splits): Rewrite doc-string.
756
97f18cc8
JD
7572011-11-11 Jan Djärv <jan.h.d@swipnet.se>
758
759 * xfns.c (unwind_create_frame):
760 * nsfns.m (unwind_create_frame):
761 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
762 Vframe_list (Bug#9999).
763
22a648b4
DA
7642011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
765
0b381c7e 766 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 767
659afede
KH
7682011-11-11 Kenichi Handa <handa@m17n.org>
769
770 * callproc.c (Fcall_process): Set the member dst_multibyte of
771 process_coding.
772
9ac0394b
KH
7732011-11-11 Johan Bockgård <bojohan@gnu.org>
774
775 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
776 avoid a crash (bug#9496).
777
2fbdc249
CY
7782011-11-09 Chong Yidong <cyd@gnu.org>
779
780 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
781 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
782
ac6b1f81
PE
7832011-11-08 Paul Eggert <eggert@cs.ucla.edu>
784
785 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
786
09db192c
PE
7872011-11-08 Paul Eggert <eggert@cs.ucla.edu>
788
789 Avoid some portability problems by eschewing 'extern inline' functions.
790 The trivial performance wins aren't worth the portability hassles; see
791 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
792 et seq.
793 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
794 (window_box_width, window_box_left, window_box_left_offset)
795 (window_box_right, window_box_right_offset): Undo previous change,
796 by removing the "extern"s.
797 * intervals.c (adjust_intervals_for_insertion)
798 (adjust_intervals_for_deletion): Undo previous change,
799 making these static again.
800 (offset_intervals, temp_set_point_both, temp_set_point)
801 (copy_intervals_to_string): No longer inline.
802 * xdisp.c (window_text_bottom_y, window_box_width)
803 (window_box_height, window_box_left_offset)
804 (window_box_right_offset, window_box_left, window_box_right)
805 (window_box): No longer inline.
806
105216ed
CY
8072011-11-08 Chong Yidong <cyd@gnu.org>
808
809 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
810 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
811 Signal an error if not a live window.
105216ed
CY
812 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
813 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
814
ae9e237f
JB
8152011-11-07 Juanma Barranquero <lekktu@gmail.com>
816
817 * lisp.h (syms_of_abbrev): Remove declaration.
818 Reported by CHENG Gao <chenggao@royau.me>.
819
c7aa8333
EZ
8202011-11-07 Eli Zaretskii <eliz@gnu.org>
821
822 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
823 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
824 of temacs in GUI mode.
825
be7f5545
MR
8262011-11-07 Martin Rudalics <rudalics@gmx.at>
827
828 * window.h: Declare delete_all_child_windows instead of
829 delete_all_subwindows.
830 * window.c (Fwindow_nest, Fset_window_nest)
831 (Fset_window_new_total, Fset_window_new_normal)
832 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
833 (delete_all_subwindows): Rename to delete_all_child_windows.
834 (Fdelete_other_windows_internal, Fset_window_configuration):
835 Call delete_all_child_windows instead of delete_all_subwindows.
836 * frame.c (delete_frame): Call delete_all_child_windows instead
837 of delete_all_subwindows.
838
ca78dc43
PE
8392011-11-07 Paul Eggert <eggert@cs.ucla.edu>
840
841 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
842 This is also needed for porting to any host where GC_MARK_STACK is
843 not GC_MAKE_GCPROS_NOOPS.
844 (which_symbols): Use it.
845
a0241d01
KH
8462011-11-07 Kenichi Handa <handa@m17n.org>
847
848 * coding.c (coding_set_destination): Check coding->src_pos only
849 when coding->src_object is a buffer (bug#9910).
850
851 * process.c (send_process): Set the member src_multibyte of coding
852 to 0 (bug#9911) when sending a unibyte text.
853
854 * callproc.c (Fcall_process): Set the member src_multibyte of
855 process_coding to 0 (bug#9912).
856
a64bfdfa 8572011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
858
859 * xmenu.c (cleanup_widget_value_tree): New function.
860 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
861 calling free_menubar_widget_value_tree directly (Bug#9830).
862
cb41b32a
PE
8632011-11-06 Paul Eggert <eggert@cs.ucla.edu>
864
865 Fix some portability problems with 'inline'.
866 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
867 (window_box_width, window_box_left, window_box_left_offset)
868 (window_box_right, window_box_right_offset): Declare extern.
869 Otherwise, these inline functions do not conform to C99 and
870 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
871 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
872 * intervals.c (adjust_intervals_for_insertion)
873 (adjust_intervals_for_deletion): Now extern, because otherwise the
874 extern inline functions 'offset_intervals' couldn't refer to it.
875 (static_offset_intervals): Remove.
876 (offset_intervals): Rewrite using the old contents of
877 static_offset_intervals. The old version didn't conform to C99
878 because an extern inline function contained a reference to an
879 identifier with static linkage.
880
b7041366
AS
8812011-11-06 Andreas Schwab <schwab@linux-m68k.org>
882
883 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
884 GC.
885
88a37c4d
EZ
8862011-11-06 Eli Zaretskii <eliz@gnu.org>
887
888 * xdisp.c (init_iterator, reseat_to_string): Don't set the
889 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
890 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
891 return Qleft_to_right.
892
49745b39
CY
8932011-11-06 Chong Yidong <cyd@gnu.org>
894
895 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
896 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
897 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
898 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
899 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
900 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
901 (Fwindow_vscroll): Doc fix.
902 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
903 argument, since it makes no sense to pass a live window and for
904 consistency with window-child.
905
1f05cd82
CS
9062011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
907
908 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
909 support MSVC.
910
22610910
JR
9112011-11-05 Jason Rumney <jasonr@gnu.org>
912
913 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
914 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
915 fonts (Bug#6029).
916 (add_font_entity_to_list): Fix logic errors in mixed boolean and
917 bitwise arithmetic preventing use of unicode-sip and non-truetype
918 opentype fonts.
919
a06776b2
EZ
9202011-11-05 Eli Zaretskii <eliz@gnu.org>
921
3ad924ba
EZ
922 * s/ms-w32.h (fstat, stat, utime): Move redirections to
923 "emacs"-only part.
924
a06776b2
EZ
925 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
926 initialization code to keep similarity to xfns.c after changes
927 from 2011-11-05.
928
c9e7db78
JD
9292011-11-05 Jan Djärv <jan.h.d@swipnet.se>
930
a97f8f3f
JD
931 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
932 (unwind_create_frame): New function (Bug#9943).
933 (Fx_create_frame): Restructure code to be more similar to the one in
934 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
935 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
936 Move terminal->reference_count++ just before making the frame official
937 (Bug#9943).
938
939 * nsterm.m (x_free_frame_resources): New function.
940 (x_destroy_window): Move code to x_free_frame_resources.
941
c9e7db78 942 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
943 (Fx_create_frame, x_create_tip_frame):
944 Move terminal->reference_count++ just before making the frame
c9e7db78
JD
945 official. Move initialization of image_cache_refcount and
946 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
947
a6fc3b5c
EZ
9482011-11-05 Eli Zaretskii <eliz@gnu.org>
949
950 Support MSVC build with newer versions of Visual Studio.
951 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
952 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
953 nt/gmake.defs.
954
955 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
956 which are not supported by MSVC.
957 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
958 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
959 bitfields.
960 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
961 types in bitfields.
962 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
963
964 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
965
58179cce 9662011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
967
968 Support MSVC build with newer versions of Visual Studio.
969 * w32.c: Don't include w32api.h for MSVC.
970 (init_environment) [_MSC_VER]: Call sys_access, not _access.
971
972 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
973 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
974 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
975 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
976 e_* cousins.
977 (alloca) [_MSC_VER]: Define to _alloca.
978
979 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
980
981 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
982
a58c13ed
EZ
9832011-11-04 Eli Zaretskii <eliz@gnu.org>
984
985 * xdisp.c (note_mouse_highlight): If either of
986 previous/next-single-property-change returns nil, treat that as
987 the beginning or the end of the buffer. (Bug#9955)
988
fe0b6370
JD
9892011-11-04 Jan Djärv <jan.h.d@swipnet.se>
990
a58c13ed 991 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
992 label is not null (Bug#9951).
993 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
994 may be NULL.
995
89bd5ee1
EZ
9962011-11-04 Eli Zaretskii <eliz@gnu.org>
997
998 * window.c (Fwindow_body_size): Mention in the doc string that the
999 return value is in frame's canonical units. (Bug#9949)
1000
84c3edb9
EZ
10012011-11-03 Eli Zaretskii <eliz@gnu.org>
1002
4e2fb5c7
EZ
1003 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1004
84c3edb9 1005 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 1006 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 1007 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 1008
bc17a887
EZ
10092011-11-01 Eli Zaretskii <eliz@gnu.org>
1010
1011 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1012 Don't stop backward scan on the continuation glyph, even though
1013 its CHARPOS is positive.
6d5eb5b0
SM
1014 (mouse_face_from_buffer_pos, note_mouse_highlight):
1015 Rename cover_string to disp_string.
bc17a887 1016
4ee88440
MR
10172011-11-01 Martin Rudalics <rudalics@gmx.at>
1018
1019 * window.c (temp_output_buffer_show): Don't use
1020 Vtemp_buffer_show_specifiers.
1021 (Vtemp_buffer_show_specifiers): Remove unused variable.
1022
c2ff3c02
EZ
10232011-10-30 Eli Zaretskii <eliz@gnu.org>
1024
1025 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1026 past the beginning of the current glyph matrix.
1027
58179cce 10282011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
1029
1030 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1031 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1032 HAVE_GTK3 (Bug#9869).
b77a6a7f 1033
3b574623
JD
1034 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1035 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1036
b77a6a7f
JD
1037 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1038
1039 * xterm.c: Declare x_handle_net_wm_state to return int.
1040 (handle_one_xevent): Check if we are iconified but don't have
1041 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1042 (get_current_wm_state): Return non-zero if not hidden,
1043 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1044 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1045 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1046 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1047
196e41e4
PE
10482011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1049
1050 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1051 so that this new function doesn't get optimized away by a
1052 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1053
021f2e1a
AS
10542011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1055
1056 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1057
8b058d44
EZ
10582011-10-29 Eli Zaretskii <eliz@gnu.org>
1059
1060 Fix the `xbytecode' command.
1061 * .gdbinit (xprintbytestr): New command.
b50a28de 1062 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
1063 (xbytecode): Print the byte-code string as well.
1064
4452fb80
EZ
10652011-10-29 Kim Storm <storm@cua.dk>
1066
8b058d44
EZ
1067 * alloc.c (which_symbols): New function.
1068
21b72067
AS
10692011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1070
1071 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1072 line. (Bug#9903)
1073
83ed7b5c
GM
10742011-10-29 Glenn Morris <rgm@gnu.org>
1075
1076 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1077 Not clear what it was for, and it causes various bugs. (Bug#9839)
1078
5a7a728b
EZ
10792011-10-28 Eli Zaretskii <eliz@gnu.org>
1080
1081 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1082 possible random value that matches one of those tested as
1083 condition to clear the mouse face.
1084
d3d0842f
CY
10852011-10-28 Chong Yidong <cyd@gnu.org>
1086
1087 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1088
31b39d13
DN
10892011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1090
1091 * window.c (make_window): Initialize phys_cursor_on_p.
1092
9aba6043
SM
10932011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1094
1095 * lisp.h (struct Lisp_Symbol): Update comments.
1096
c20992f4
JB
10972011-10-28 Juanma Barranquero <lekktu@gmail.com>
1098
1099 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1100
db4f02f2
EZ
11012011-10-28 Eli Zaretskii <eliz@gnu.org>
1102
1103 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1104 <oslsachem@gmail.com> for helping to debug this.
1105
1106 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1107 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1108 (g_b_init_get_glyph_outline_w): New static variables.
1109 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1110 (GetGlyphOutlineW_Proc): New typedefs.
1111 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
1112 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1113 New functions.
1114 (w32font_open_internal, compute_metrics):
1115 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
1116 instead of calling the "wide" APIs directly.
1117
1118 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1119
1120 * w32.h (syms_of_w32font): Add prototype.
1121
87e68db4
JB
11222011-10-27 Juanma Barranquero <lekktu@gmail.com>
1123
1124 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1125 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1126 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1127 (Fmove_to_window_line): Doc fix.
1128
435c1d67
CY
11292011-10-27 Chong Yidong <cyd@gnu.org>
1130
1131 * process.c (make_process): Set gnutls_state to NULL.
1132
1133 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1134 non-NULL, regardless of GNUTLS_INITSTAGE.
1135 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1136 an error. Set process slots as soon as we allocate them.
1137
1138 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1139
9c6c6f49
CY
11402011-10-27 Chong Yidong <cyd@gnu.org>
1141
9aba6043
SM
1142 * gnutls.c (emacs_gnutls_deinit): New function.
1143 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
1144 (Fgnutls_deinit, Fgnutls_boot): Use it.
1145
1146 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1147 (deactivate_process): Call emacs_gnutls_deinit.
1148
657d08d3
JB
11492011-10-27 Juanma Barranquero <lekktu@gmail.com>
1150
1151 * image.c (x_create_x_image_and_pixmap):
1152 * w32.c (sys_rename, w32_delayed_load):
1153 * w32font.c (fill_in_logfont):
1154 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1155
5430d399
JB
11562011-10-26 Juanma Barranquero <lekktu@gmail.com>
1157
1158 * w32fns.c (w32_default_color_map): New function,
1159 extracted from Fw32_default_color_map.
a7ef684b 1160 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 1161
fe0055fa
PE
11622011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1163
1164 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1165
e6346438
SM
11662011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1167
1168 * keyboard.c (test_undefined): New function (bug#9751).
1169 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1170
e112cc37
ET
11712011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1172
1173 * sysdep.c (init_sys_modes): Fix the check for the controlling
1174 terminal (Bug#6649).
1175
7b5d6677
EZ
11762011-10-20 Eli Zaretskii <eliz@gnu.org>
1177
1178 * dispextern.h (struct bidi_it): New member next_en_type.
1179
1180 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1181 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1182 current character, check also for next_en_type being WEAK_EN.
1183 (bidi_resolve_weak): Don't enter the expensive loop if the current
1184 position is before next_en_pos. Record the bidi type of the first
1185 non-ET, non-BN character we find, in addition to its position.
1186 (bidi_level_of_next_char): Invalidate next_en_type when
1187 next_en_pos is over-stepped.
1188
7da0b018
PE
11892011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1190
1191 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1192 * editfns.c: Rewrite current-time-zone so that it invokes
1193 the equivalent of (format-time-string "%Z") to get the time zone name.
1194 This fixes a bug when the time zone name contains characters that
1195 need converting from the system time locale to Emacs internal format.
1196 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1197 that patch fixed format-time-string to do the conversion, but
1198 I forgot to fix current-time-zone.
1199 (format_time_string): New function, containing most of
1200 what Fformat_time_string used to contain.
1201 (Fformat_time_string): Rewrite in terms of format_time_string.
1202 This doesn't change this function's behavior.
1203 (current-time-zone): Rewrite to use format_time_string.
1204 This fixes the bug reported by Michael Schierl in
1205 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1206 Jason Rumney's 2007-06-07 change worked around this bug, but
1207 didn't fix it.
1208 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1209
8547b010
EZ
12102011-10-19 Eli Zaretskii <eliz@gnu.org>
1211
1212 * xdisp.c (start_display): If the character at POS is displayed
1213 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
1214 (try_window_reusing_current_matrix): If a line ends in a display
1215 vector or the next line starts in a display vector, continue
1216 redrawing the window even though the character position of
1217 start_row was reached.
8547b010
EZ
1218 (Bug#9771, part 2)
1219
4e948d15
CY
12202011-10-18 Chong Yidong <cyd@gnu.org>
1221
1222 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1223 with nobreak-char-display too.
1224
4787455f
EZ
12252011-10-18 Eli Zaretskii <eliz@gnu.org>
1226
1227 Fix part 3 of bug#9771.
1228 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1229 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1230 non-neutral characters if the current character is a paragraph
1231 separator (a.k.a. Newline). This avoids running the same
1232 expensive loop twice, once when we consume the preceding newline
1233 and the other time when the line actually needs to be displayed.
1234 Avoid the loop when we see neutrals on the base embedding level
1235 following a character whose directionality is the same as the
1236 paragraph's. This avoids running the expensive loop when a line
1237 ends in a long sequence of neutrals, like control characters.
1238 Add assertion against STRONG_AL type. Slightly rearrange code
1239 that determines the type of a neutral given the first non-neutral
1240 that follows it.
1241 (bidi_level_of_next_char): Set next_en_pos to zero when
1242 invalidating its info.
1243
2c91f553
EZ
12442011-10-17 Eli Zaretskii <eliz@gnu.org>
1245
1246 * xdisp.c (push_display_prop): Determine whether to record string
1247 or buffer position by IT->string, not by IT->method. Allow
1248 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
1249 (move_it_vertically_backward): Don't look for character position
1250 immediately after the newline when in a continuation line.
1251 (Bug#9771, part 1)
2c91f553 1252
c7b08b0d
MR
12532011-10-15 Martin Rudalics <rudalics@gmx.at>
1254
1255 * window.c (coordinates_in_window): Rewrite and delabelize
1256 vertical border check. (Bug#5357) (Bug#9618)
1257
6b02f655
SM
12582011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1259
1260 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1261 errors in XSetWindowBorder (bug#9310).
1262
81d40c92
DA
12632011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1264
1265 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1266 avoid crash when xmalloc overrun checking is enabled.
1267
d4172c3b
EZ
12682011-10-13 Eli Zaretskii <eliz@gnu.org>
1269
1270 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1271 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1272 cursor motion with <left> and <right> arrow keys.
1273
1274 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1275 some callers set that themselves.
1276
b00eea75
EZ
12772011-10-12 Eli Zaretskii <eliz@gnu.org>
1278
1279 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1280 display string and the previous row comes from the same string and
1281 is empty. (Bug#9739) (Bug#9738)
1282
8fe012c4
SM
12832011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1284
1285 * doc.c (get_doc_string): Encode file name (bug#9735).
1286
0074aef2
EZ
12872011-10-12 Eli Zaretskii <eliz@gnu.org>
1288
79beb178
EZ
1289 * bidi.c (bidi_level_of_next_char):
1290 * xdisp.c (get_visually_first_element): Remove old incorrect
1291 comments regarding the Unicode Line Separator character.
1292
0074aef2
EZ
1293 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1294
6e4b3fbe
DA
12952011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1296
1297 * alloc.c (Fgc_status): Do not access beyond zombies array
1298 boundary if nzombies > MAX_ZOMBIES.
1299 * alloc.c (dump_zombies): Add missing format specifier.
1300
0324f3af
PE
13012011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1302
b5525cac
PE
1303 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1304 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1305
0324f3af
PE
1306 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1307 Some packages use them to denote characters with modifiers.
1308
e9b5f888
AS
13092011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1310
1311 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1312 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1313 matching a pp-number. Rename parameter var to var1.
1314
127827c0
SM
13152011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1316
1317 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1318
c8fd3bd0
GM
13192011-10-08 Glenn Morris <rgm@gnu.org>
1320
1321 * callint.c (Fcall_interactively): Give a more explicit error for the
1322 'c' case with a non-character input. (Bug#8479)
1323
352ec8ff
EZ
13242011-10-08 Eli Zaretskii <eliz@gnu.org>
1325
03669ccb
EZ
1326 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1327 lines.
7061c986
EZ
1328 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1329 lines that are hscrolled on the left.
03669ccb 1330
352ec8ff
EZ
1331 * dispnew.c (buffer_posn_from_coords): Account for a possible
1332 presence of header-line. (Bug#4426)
1333
a66cfb1c
SM
13342011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1335
6b02f655
SM
1336 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1337 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 1338
7c5ee88e
PE
13392011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1340
1341 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1342 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1343 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1344 this makes Emacs dump core during garbage collection on rare
1345 occasions. sizeof is obviously inferior to offsetof here, so
1346 stick with offsetof.
1347 (GC_POINTER_ALIGNMENT): New macro.
1348 (mark_memory): Omit 3rd (offset) arg; caller changed.
1349 Don't assume EMACS_INT alignment is the same as pointer alignment.
1350
df1bbe5b
SM
13512011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1352
1353 * keyboard.c (read_key_sequence_remapped): New var.
1354 (read_key_sequence): Compute remapping in the right buffer.
1355 (command_loop_1): Use read_key_sequence's remapping directly.
1356
51553db6
SM
13572011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1358
32c1fffd
SM
1359 * dired.c (file_name_completion): Don't expand file name.
1360 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1361 before checking file name handler.
1362
51553db6
SM
1363 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1364 they've been requested explicitly (bug#9591).
1365
b6bd1599 13662011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
1367
1368 * keymap.c (Fsingle_key_description): Use make_specified_string
1369 instead of build_string to build string from push_key_description.
1370 (Bug#5193)
1371
f701dc2a
PE
13722011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1373
4222c55d
PE
1374 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1375 This fixes a Y2038 bug on 64-bit hosts.
1376 * buffer.c (reset_buffer):
1377 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1378 (Fclear_buffer_auto_save_failure):
1379 Use 0, not -1, to represent an unset failure time, since time_t
1380 might not be signed.
1381
f701dc2a
PE
1382 Remove dependency on glibc malloc internals.
1383 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1384 Move back here from lisp.h, but with their new implementations.
1385 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1386 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1387 * charset.c (charset_table_init): New static var.
1388 (syms_of_charset): Use it instead of xmalloc. This removes a
1389 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1390 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1391 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1392 Move back to alloc.c.
1393 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1394 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1395
9ceebf39
JD
13962011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1397
1398 * nsterm.m (windowDidResize): Call x_set_window_size only when
1399 ns_in_resize is true. Otherwise set pixelwidth/height and
1400 call change_frame_size (Bug#9628).
1401
cb993c58
PE
14022011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1403
3930c88b
PE
1404 Port --enable-checking=all to Fedora 14 x86-64.
1405 * charset.c (syms_of_charset): Also account for glibc malloc's
1406 internal overhead when calculating the initial malloc maximum.
1407
cb993c58
PE
1408 Port --enable-checking=all to Fedora 14 x86.
1409 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1410 Move to lisp.h.
1411 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1412 (overrun_check_realloc, overrun_check_free):
1413 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1414 That way, xmalloc returns a properly-aligned pointer even if
1415 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1416 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1417 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1418 into account when calculating the initial malloc maximum.
1419 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1420 Move here from alloc.c, so that charset.c can use it too.
1421 Properly align; the old code wasn't right for common 32-bit hosts
1422 when configured with --enable-checking=all.
1423 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1424 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1425
31bed486
EZ
14262011-09-29 Eli Zaretskii <eliz@gnu.org>
1427
04c70788 1428 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
1429 use EDOM.
1430
fbcaa2f3
EZ
14312011-09-28 Eli Zaretskii <eliz@gnu.org>
1432
1433 * xdisp.c (compute_display_string_end): If there's no display
1434 string at CHARPOS, return -1.
1435
1436 * bidi.c (bidi_fetch_char): When compute_display_string_end
1437 returns a negative value, treat the character as a normal
1438 character not covered by a display string. (Bug#9624)
1439
a239d4e9
JB
14402011-09-28 Juanma Barranquero <lekktu@gmail.com>
1441
1442 * lread.c (Fread_from_string): Fix typo in docstring.
1443
88652fd5
EZ
14442011-09-27 Eli Zaretskii <eliz@gnu.org>
1445
1446 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1447 newline, reseat the iterator instead of bidi-iterating there one
1448 character at a time. (Bug#9610)
32c1fffd
SM
1449 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1450 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 1451
ed497dd4
AS
14522011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1453
1454 * lread.c (readevalloop): Use correct code for NBSP.
1455 (read1): Likewise. (Bug#9608)
1456
b2bf61aa
MA
14572011-09-25 Michael Albinus <michael.albinus@gmx.de>
1458
1459 * dbusbind.c (Fdbus_register_signal): When service is not
1460 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1461
32bbb17c
GM
14622011-09-25 Glenn Morris <rgm@gnu.org>
1463
1464 * buffer.c (truncate-lines): Doc fix.
1465
94e0933e
CY
14662011-09-24 Chong Yidong <cyd@stupidchicken.com>
1467
1468 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1469 (Fset_window_next_buffers): Doc fix.
1470
cddde921
GM
14712011-09-24 Glenn Morris <rgm@gnu.org>
1472
1473 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1474
1260aef1
PE
14752011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1476
25b4bfa0
PE
1477 Fix minor problems found by static checking.
1478 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
1479 * indent.c (Fvertical_motion): Fix == vs = typo.
1480
e3cbd34b
EZ
14812011-09-24 Eli Zaretskii <eliz@gnu.org>
1482
a66cfb1c
SM
1483 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1484 Default value is now t. Doc fix.
6bf7006f 1485
e3cbd34b 1486 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 1487 logic when moving up, not only when moving down. Fix the
e3cbd34b 1488 confusing name and values of the it_overshoot_expected variable;
32c1fffd 1489 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
1490
1491 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1492 CHARPOS is covered by a display string which includes newlines.
1493 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1494 is covered by a display string with embedded newlines.
1495
a3de0cbd
MA
14962011-09-24 Michael Albinus <michael.albinus@gmx.de>
1497
1498 * dbusbind.c (Fdbus_register_signal): Add match rule to
1499 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
1500 (Fdbus_register_method, Vdbus_registered_objects_table):
1501 Fix docstring.
a3de0cbd 1502
b260039d
JM
15032011-09-24 Jim Meyering <meyering@redhat.com>
1504
32c1fffd 1505 do not ignore write error for any output size
b260039d
JM
1506 The previous change was incomplete.
1507 While it makes emacs --batch detect the vast majority of stdout
1508 write failures, errors were still ignored whenever the output size is
1509 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1510 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1511 && echo FAIL: ignored write error
1512 FAIL: ignored write error
1513 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1514 && echo FAIL: ignored write error
1515 FAIL: ignored write error
1516 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1517
8eca8a7c
AS
15182011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1519
1520 * emacs.c (Fkill_emacs): In noninteractive mode exit
1521 non-successfully if a write error occurred on stdout. (Bug#9574)
1522
3341db62
EZ
15232011-09-21 Eli Zaretskii <eliz@gnu.org>
1524
1525 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1526 the xassert test.
1527
1528 * dispextern.h (struct it): Update the comment documenting what
1529 can it->OBJECT be.
1530
8c203dbf
EZ
15312011-09-20 Eli Zaretskii <eliz@gnu.org>
1532
1533 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1534 a display string, extend search for cursor position to end of row.
1535 (find_row_edges): If the row ends in a newline from a display
1536 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1537 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
1538 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1539 non-empty line. Fixes confusing cursor motion with arrow keys at
1540 the beginning of a line that starts with whitespace.
8c203dbf 1541
a4824228
LMI
15422011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1543
1544 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1545 (bug#9493).
1546
33ed493b
CY
15472011-09-18 Chong Yidong <cyd@stupidchicken.com>
1548
1549 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1550 boolean (Bug#9154).
1551
56cd55c8
EZ
15522011-09-18 Eli Zaretskii <eliz@gnu.org>
1553
1554 * xdisp.c (display_line): Record maximum and minimum buffer
1555 positions even if no glyphs were produced (e.g., by a zero-width
1556 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1557 buffer positions that will be removed from the glyph row because
1558 they don't fit.
c02dcedf
EZ
1559 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1560 column is beyond frame width: don't subtract 1 "pixel" when
1561 computing width of the stretch.
3e62b7e0
EZ
1562 (reseat_at_next_visible_line_start): Undo the change made on
1563 2011-09-17 that saved paragraph information and restored it after
1564 the call to `reseat'. (Bug#9545)
56cd55c8 1565
5ed99d36 15662011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
1567
1568 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1569 and turn window cursor on if cleared (Bug#9415).
1570
5ed99d36 15712011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
1572
1573 * search.c (boyer_moore): Take unibyte characters from pattern
1574 literally. (Bug#9458)
1575
9bade7b2
EZ
15762011-09-18 Eli Zaretskii <eliz@gnu.org>
1577
1578 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1579
e5e9d610
PE
15802011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1581
87e4427a
PE
1582 Fix minor problem found by static checking.
1583 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1584 initialized, to pacify gcc -Wuninitialized.
1585
e5e9d610
PE
1586 * fileio.c: Report proper errno when syscall falls.
1587 (Finsert_file_contents): Save and restore errno,
1588 so that report_file_error outputs the correct diagnostic.
1589 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1590
a1674f0b
EZ
15912011-09-18 Eli Zaretskii <eliz@gnu.org>
1592
1593 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1594
fbfb6dd4
EZ
15952011-09-17 Eli Zaretskii <eliz@gnu.org>
1596
1597 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1598 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1599
bb187662
EZ
16002011-09-17 Eli Zaretskii <eliz@gnu.org>
1601
1137e8b8 1602 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 1603 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
1604
1605 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1606 (bidi_find_paragraph_start): Search back for paragraph beginning
1607 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1608 (bidi_move_to_visually_next): Only trigger paragraph-related
1609 computations when the last character is a newline or at EOB, not
1610 just any NEUTRAL_B. (Bug#9470)
1611
bb187662
EZ
1612 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1613 truncated lines if point is covered by a display string. (Bug#9524)
1614
2e621251
PE
16152011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1616
1617 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1618 (cons_to_x_long): New function.
1619 (lisp_data_to_selection_data): Use it. Correct the test for
1620 short-versus-long data; it was negated. Break out of vector
1621 loop, for efficiency, when a long datum is discovered.
1622
91a15bc6
SM
16232011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1624
1625 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1626
b41c3a35
EZ
16272011-09-16 Eli Zaretskii <eliz@gnu.org>
1628
1629 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1630 GCC PR/17406) by declaring this function with external scope.
1631
7812ba2d
PE
16322011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1633
1634 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1635 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1636
cf7edc2a
AS
16372011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1638
1639 * editfns.c (Fformat): Correctly handle text properties on "%%".
1640
bd01620e
EZ
16412011-09-15 Eli Zaretskii <eliz@gnu.org>
1642
1643 * xterm.c (x_draw_composite_glyph_string_foreground):
1644 * w32term.c (x_draw_composite_glyph_string_foreground):
1645 * term.c (encode_terminal_code):
1646 * composite.c (composition_update_it, get_composition_id):
1647 * xdisp.c (get_next_display_element)
1648 (fill_composite_glyph_string): Add comments about special meaning
1649 of TAB characters in a composition.
1650
a02719a3
PE
16512011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1652
1653 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
1654 This occurs when processing a multibyte format.
1655 Problem reported by Wolfgang Jenker.
a02719a3 1656
72589a3c
JB
16572011-09-15 Johan Bockgård <bojohan@gnu.org>
1658
1659 * xdisp.c (try_cursor_movement): Only check for exact match if
1660 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1661
1c14176c
PE
16622011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1663
1664 Remove unused external symbols.
1665 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1666 * xdisp.c (calc_pixel_width_or_height): Now static.
1667 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1668 * indent.c (check_display_width):
1669 * w32term.c: Fix comment to match code.
1670 * xterm.c, xterm.h (x_catching_errors): Remove.
1671
d2eea5b5
PE
16722011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1673
1674 * xselect.c: Use signed conversions more consistently (Bug#9498).
1675 (selection_data_to_lisp_data): Assume incoming selection data are
1676 signed integers, not unsigned. This is to be consistent with
1677 outgoing selection data, which was modified to use signed integers
1678 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1679 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1680 expects long, not unsigned long.
1681
46888499
EZ
16822011-09-14 Eli Zaretskii <eliz@gnu.org>
1683
1684 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1685 computation of loop end. Reported by Johan Bockgård
1686 <bojohan@gnu.org>.
1687
ef8ef9fb
CY
16882011-09-13 Chong Yidong <cyd@stupidchicken.com>
1689
1690 * frame.c (Fother_visible_frames_p): Function deleted.
1691
fa819fed
EZ
16922011-09-12 Eli Zaretskii <eliz@gnu.org>
1693
1694 * indent.c (compute_motion): Process display vector front to back
1695 rather than the other way around. (Bug#2496)
1696
2ba8e008
SM
16972011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1698
1699 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1700
20f53c69
CY
17012011-09-11 Chong Yidong <cyd@stupidchicken.com>
1702
1703 * minibuf.c (Fread_from_minibuffer): Doc fix.
1704
d562d7a4
EZ
17052011-09-11 Eli Zaretskii <eliz@gnu.org>
1706
1707 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1708 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1709
1c4d7f3d
LMI
17102011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1711
1712 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1713 value for non-existent files.
1714
b885bf36
EZ
17152011-09-11 Eli Zaretskii <eliz@gnu.org>
1716
1717 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1718 set its "size" to -1. This will set the modtime_size field of
1719 the corresponding buffer to -1, which is what
1720 verify-visited-file-modtime expects for files that do not exist.
1721 (Bug#9139)
1722
6612f0bf
PE
17232011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1724
1725 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1726 here ...
1727 * lisp.h: ... from here. push_key_description is no longer
1728 defined in keyboard.c, so its declaration should not be in
1729 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1730 logically belongs with push_key_description.
1731
dfb3f755
PE
17322011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1733
1734 * buffer.h: Include <sys/types.h> instead of <time.h>.
1735 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1736 Problem reported by Herbert J. Skuhra.
1737
3134906c
LMI
17382011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1739
1740 * xml.c (parse_region): Make the parsing work for
1741 non-comment-starting XML files again (bug#9144).
1742
8d903f4e
AS
17432011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1744
1745 * image.c (gif_load): Fix calculation of bottom and right corner.
1746 (Bug#9468)
1747
80ad64f4
EZ
17482011-09-10 Eli Zaretskii <eliz@gnu.org>
1749
1750 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1751 redisplay in small windows.
1752
208a048d
EZ
17532011-09-09 Eli Zaretskii <eliz@gnu.org>
1754
1755 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1756
9b1c252e
MR
17572011-09-08 Martin Rudalics <rudalics@gmx.at>
1758
1759 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1760 Operate on live windows only.
1761
2949f33b
JB
17622011-09-08 Juanma Barranquero <lekktu@gmail.com>
1763
1764 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1765
e08dcafd
EZ
17662011-09-07 Eli Zaretskii <eliz@gnu.org>
1767
1768 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1769 only under bidi iteration.
1770
115b96bd
JD
17712011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1772
1773 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1774
c8199d0f
PE
17752011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1776
1777 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1778 Without this fix, the command to link temacs failed due to an
1779 undefined symbol __builtin_isnan. This is because
1780 /usr/include/iso/math_c99.h #defines isnan(x) to
1781 __builtin_isnan(x), but the bundled gcc, which identifies itself
1782 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1783 a __builtin_isnan.
1784 * floatfns.c (isnan): #undef, and then #define to a clone of
1785 what's in data.c.
1786 (Fisnan): Always define, since it's always available now.
1787 (syms_of_floatfns): Always define isnan at the Lisp level.
1788
e39b275c 17892011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
1790
1791 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1792
b2db44d9 17932011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 1794
f4af5137 1795 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
1796 The previous code assumed that file offsets (off_t values) fit in
1797 EMACS_INT variables, which is not true on typical 32-bit hosts.
1798 The code messed up by falsely reporting buffer overflow in cases
1799 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1800 when "big" contains more than 2**29 bytes, even though this
1801 inserts just one byte and does not overflow the buffer.
1802 (Finsert_file_contents): Store file offsets as off_t
1803 values, not as EMACS_INT values. Check for overflow when
1804 converting between EMACS_INT and off_t. When checking for
1805 buffer overflow or for overlap, take the offsets into account.
1806 Don't use EMACS_INT for small values where int suffices.
1807 When checking for overlap, fix a typo: ZV was used where
1808 ZV_BYTE was intended.
1809 (Fwrite_region): Don't assume off_t fits into 'long'.
1810 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1811
ecfc0a49
MA
18122011-09-05 Michael Albinus <michael.albinus@gmx.de>
1813
1814 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1815
6511acf2 18162011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 1817
0999621a 1818 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
1819
1820 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 1821 (esprintf, exprintf, evxprintf): New functions.
62f19c19 1822 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 1823 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
1824 (modify_event_symbol): Do not assume that the length of
1825 name_alist_or_stem is safe to alloca and fits in int.
1826 (Fexecute_extended_command): Likewise for function name and binding.
1827 (Frecursion_depth): Wrap around reliably on integer overflow.
1828 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1829 since some callers pass EMACS_INT values.
1830 (Fsingle_key_description): Don't crash if symbol name contains more
1831 than MAX_ALLOCA bytes.
1832 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1833 (get_minibuffer): Arg is now EMACS_INT, not int.
1834 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 1835 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
1836 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1837
2be7d702
PE
1838 * dbusbind.c (signature_cat): New function.
1839 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
1840 Do not overrun buffer; instead, report string overflow.
1841
9d1df220
PE
1842 * dispnew.c (add_window_display_history): Don't overrun buffer.
1843 Truncate instead; this is OK since it's just a log.
1844
33ef5c64
PE
1845 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1846 even if the time zone offset is outlandishly large.
1847 Don't mishandle offset == INT_MIN.
1848
66c6fdd5
PE
1849 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1850 when creating daemon; the previous buffer-overflow check was incorrect.
1851
d749b01b
PE
1852 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1853 which has the guts of the old verror function.
1854
b5cd1905
PE
1855 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1856 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1857
6e1a67fb
PE
1858 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1859 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 1860 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 1861 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
1862 length of string rather than counting it via multiple sprintfs;
1863 that's simpler and more reliable.
c21721cc
PE
1864 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1865 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1866 sprintf, in case result does not fit in int.
1867
c57b67fc
PE
1868 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1869 (fontset_from_font): Print it.
1870
8a401434
PE
1871 * frame.c (tty_frame_count): Now printmax_t, not int.
1872 (make_terminal_frame, set_term_frame_name): Print it.
1873 (x_report_frame_params): In X, window IDs are unsigned long,
1874 not signed long, so print them as unsigned.
1875 (validate_x_resource_name): Check for implausibly long names,
1876 and don't assume name length fits in 'int'.
1877 (x_get_resource_string): Don't blindly alloca invocation name;
1878 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1879 not fit in int.
1880
6e1a67fb
PE
1881 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1882 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
1883 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1884
0df02bf3
PE
1885 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1886 Use esprintf, not sprintf, in case result does not fit in int.
1887
48e30793
PE
1888 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1889 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1890 it as a large positive number.
1891 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1892 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1893
a66ff6d8
PE
1894 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1895 in case result does not fit in int.
1896
aca216ff
PE
1897 * print.c (float_to_string): Detect width overflow more reliably.
1898 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1899 buffer overrun. Don't assume list length fits in 'int'. Treat
1900 print length of 0 as 0, not as infinity; to be consistent with other
1901 uses of print length in this function. Don't overflow print length
1902 index. Don't assume hash table size fits in 'long', or that
1903 vectorlike size fits in 'unsigned long'.
1904
31c286f7
PE
1905 * process.c (make_process): Use printmax_t, not int, to format
1906 process-name gensyms.
1907
55e5faa1
PE
1908 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1909
80f2e268
PE
1910 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1911 to avoid potential buffer overrun.
1912
670741ab
PE
1913 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1914 if X resource line is longer than 512 bytes.
1915
b7163a50
PE
1916 * xfns.c (x_window): Make sprintf buffer a bit bigger
1917 to avoid potential buffer overrun.
1918
ae58ff1f
PE
1919 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1920
c43c8a6a
PE
1921 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1922
3f8236f4
PE
19232011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1924
53e9fe90 1925 Integer overflow fixes for scrolling, etc.
6511acf2
PE
1926 Without these, Emacs silently mishandles large integers sometimes.
1927 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
1928 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1929
6511acf2
PE
1930 * xdisp.c (try_window_id): Check Emacs fixnum range before
1931 converting to 'int'.
806add1d 1932
6511acf2 1933 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
1934 Check that an Emacs fixnum is in range before assigning it to 'int'.
1935 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1936 values converted from Emacs fixnums.
1937 (Frecenter): Don't wrap around a line count if it is out of 'int'
1938 range; instead, treat it as an extreme value.
1939 (Fset_window_configuration, compare_window_configurations):
1940 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1941
6511acf2
PE
1942 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1943 that can exceed INT_MAX. Check that EMACS_INT value is in range
1944 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
1945 (match_limit): Don't assume that a fixnum can fit in 'int'.
1946
6511acf2 1947 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
1948 exceed INT_MAX.
1949
6511acf2 1950 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
1951 (Fvertical_motion): Don't wrap around LINES values that don't fit
1952 in 'int'. Instead, treat them as extreme values. This is good
1953 enough for windows, which can't have more than INT_MAX lines anyway.
1954
fcb901a7
LMI
19552011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1956
0f2f6b6d
LMI
1957 * Require libxml/parser.h to avoid compilation warning.
1958
fcb901a7
LMI
1959 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1960
1961 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1962 since this reportedly can destroy thread storage.
1963
6e20a0d4
CY
19642011-08-30 Chong Yidong <cyd@stupidchicken.com>
1965
1966 * syntax.c (find_defun_start): Update all cache variables if
1967 exiting early (Bug#9401).
1968
148ae00e
EZ
19692011-08-30 Eli Zaretskii <eliz@gnu.org>
1970
f6cfbd8f
EZ
1971 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1972
148ae00e
EZ
1973 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1974 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1975 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1976
1977 * term.c (tty_append_glyph): New function.
1978 (produce_stretch_glyph): Static function and its prototype deleted.
1979
a66cfb1c
SM
1980 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1981 Add prototypes.
148ae00e 1982
c4a07a4c
PE
19832011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1984
1985 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1986 when checking :margin (Bug#9390).
1987 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 1988 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
1989 so that the name doesn't mislead. All uses changed.
1990
6bc8cd65
JB
19912011-08-28 Johan Bockgård <bojohan@gnu.org>
1992
1993 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1994 set_tty_hooks.
1995
dca4927e
EZ
19962011-08-27 Eli Zaretskii <eliz@gnu.org>
1997
1998 * xdisp.c (move_it_to): Don't bail out early when reaching
1999 position beyond to_charpos, if we are scanning backwards.
2000 (move_it_vertically_backward): When DY == 0, make sure we get to
2001 the first character in the line after the newline.
2002
f2cad773
PE
20032011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2004
2005 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2006 (ccl_driver): Do not generate an out-of-range pointer.
2007 (Fccl_execute_on_string): Remove unnecessary check for
2008 integer overflow, noted by Stefan Monnier in
2009 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2010 Remove a FIXME that didn't need fixing.
2011 Simplify the newly-introduced buffer reallocation code.
2012
0cae2cdb
JB
20132011-08-27 Juanma Barranquero <lekktu@gmail.com>
2014
2015 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2016
5fc295a4 20172011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 2018
70c60eb2 2019 Integer and memory overflow issues (Bug#9196).
726e0ab1 2020
d31850da
PE
2021 * doc.c (get_doc_string): Rework so that
2022 get_doc_string_buffer_size is the actual buffer size, rather than
2023 being 1 less than the actual buffer size; this makes xpalloc more
2024 convenient.
2025
a69fbedb
PE
2026 * image.c (x_allocate_bitmap_record, cache_image):
2027 * xselect.c (Fx_register_dnd_atom):
2028 Simplify previous changes by using xpalloc.
2029
fe5c5d37
PE
2030 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2031 since either will do and ptrdiff_t is convenient with xpalloc.
2032
0065d054
PE
2033 * charset.c (charset_table_size)
2034 (struct charset_sort_data.priority): Now ptrdiff_t.
2035 (charset_compare): Don't overflow if priorities differ greatly.
2036 (Fsort_charsets): Don't assume list length fits in int.
2037 Check for size-calculation overflow when allocating sort data.
2038 (syms_of_charset): Allocate an initial charset table that is
2039 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2040
2041 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2042
2043 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2044 The actual value is always <= INT_MAX, and leaving it unsigned made
2045 overflow checking harder.
2046
2047 * dispextern.h (struct glyph_matrix.rows_allocated)
2048 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2049 with xpalloc. The values are still always <= INT_MAX.
2050
2051 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2052
2053 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2054 (SAFE_NALLOCA): New macro.
2055
2056 * region-cache.c (struct boundary.pos, find_cache_boundary)
2057 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2058 (set_cache_region, invalidate_region_cache)
2059 (revalidate_region_cache, know_region_cache, region_cache_forward)
2060 (region_cache_backward, pp_cache):
2061 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2062 so that ptrdiff_t * can be passed to xpalloc.
2063 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2064 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2065 (pp_cache): Don't assume cache_len fits in int.
2066 * region-cache.h: Adjust extern decls to match.
2067
2068 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2069 EMACS_INT, since either will do, for xpalloc.
2070
2071 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2072 (xnmalloc, xnrealloc, xpalloc): New functions.
2073
726e0ab1
PE
2074 * bidi.c (bidi_shelve_header_size): New constant.
2075 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2076 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2077
51f30bc5 2078 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
2079 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2080 (overlay_strings):
2081 Don't update size of array until after memory allocation succeeds,
2082 because xmalloc/xrealloc may not return.
0065d054
PE
2083 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2084 now that we have proper integer overflow checking.
2085 (record_overlay_string, overlay_strings): Catch overflows when
2086 calculating size of overlay_str_buf.
726e0ab1 2087
0065d054
PE
2088 * callproc.c (Fcall_process): Check for size overflow when
2089 calculating size of args2.
2090 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2091 Normally we prefer signed values, but sticking with ptrdiff_t would
2092 require adding more-complicated checks.
726e0ab1
PE
2093
2094 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2095 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2096 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 2097 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
2098
2099 * character.c (Fstring): Check for size-calculation overflow.
2100
2101 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2102 unnecessary integer overflow. Check for size overflow.
2103 (encode_coding_object): Don't update size until xmalloc succeeds.
2104
2105 * composite.c (get_composition_id): Check for overflow in glyph
2106 length calculations.
2107
2108 Integer and memory overflow fixes for display code.
2109 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2110 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2111 (scrolling_window): Check for overflow in size calculations.
2112 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2113 Don't assume glyph table len fits in int.
2114 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2115 (row_table_size): Now ptrdiff_t, not int.
2116 (scrolling_window): Avoid overflow in size calculations.
2117 Don't update size until allocation succeeds.
2118 * fns.c (concat): Check for overflow in size calculations.
2119 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2120 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2121 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2122
2123 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2124 (get_doc_string): Check for size calculation overflow.
2125 Don't update size until allocation succeeds.
2126 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2127 EMACS_INT, where ptrdiff_t will do.
2128 (Fsubstitute_command_keys): Check for string overflow.
2129
2130 * editfns.c (set_time_zone_rule): Don't assume environment length
2131 fits in int.
2132 (message_length): Now ptrdiff_t, not int.
2133 (Fmessage_box): Don't update size until allocation succeeds.
2134 Don't assume message length fits in int.
2135 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2136
0065d054
PE
2137 * emacs.c (main): Do not reallocate argv, since there is a null at
2138 the end that can be overwritten, and this way there's no need to
2139 worry about size-calculation overflow.
2140 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
2141
2142 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2143 alloc succeeds.
2144 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2145
2146 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2147 (x_set_scroll_bar_width, x_figure_window_size):
2148 Check for integer overflow.
2149 (x_set_alpha): Do not assume XINT fits in int.
2150
2151 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2152 This is for the members text_lines, text_cols, total_lines, total_cols,
2153 where the system imposes an 'int' limit.
2154
2155 * fringe.c (Fdefine_fringe_bitmap):
2156 Don't update size until alloc works.
2157
2158 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2159 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2160
2161 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2162 Check for size-calculation overflow.
2163 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2164 do, as we prefer signed integers.
2165 (id_to_widget.max_size, id_to_widget.used)
2166 (xg_store_widget_in_map, xg_remove_widget_from_map)
2167 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2168 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2169 Use and return ptrdiff_t, not int.
2170 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2171 * gtkutil.h: Change prototypes to match the above.
2172
2173 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2174 are duplicate now that they've been promoted to lisp.h.
2175 (x_allocate_bitmap_record, x_alloc_image_color)
2176 (make_image_cache, cache_image, xpm_load):
2177 Don't update size until alloc is done.
2178 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2179 (x_detect_edges):
3256efce 2180 Check for size calculation overflow.
726e0ab1
PE
2181 (ct_colors_allocated_max): New constant.
2182 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2183 overflow.
3256efce 2184
726e0ab1
PE
2185 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2186 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2187 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2188 Use ptrdiff_t, not int, to count maps.
2189 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
2190 calculations. Don't update size until allocation succeeds.
2191 Redo calculations to avoid overflow.
726e0ab1
PE
2192 * keyboard.h: Change prototypes to match the above.
2193
2194 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2195 to count maps.
2196 (current_minor_maps): Check for size calculation overflow.
2197 * keymap.h: Change prototypes to match the above.
2198
2199 * lread.c (read1, init_obarray): Don't update size until alloc done.
2200
2201 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2202 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2203
726e0ab1
PE
2204 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2205 Now ptrdiff_t, not int.
2206 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2207 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2208
2209 * process.c (Fnetwork_interface_list): Check for overflow
2210 in size calculation.
2211
2212 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2213
2214 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2215 overflow. Don't bother calling xmalloc when xrealloc will do.
2216
2217 * search.c (Freplace_match): Check for size calculation overflow.
2218 (Fset_match_data): Don't assume list lengths fit in 'int'.
2219
2220 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2221 for command line length. Do not attempt to address one before the
2222 beginning of an array, as that's not portable.
2223
2224 * term.c (max_frame_lines): Remove; unused.
2225 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2226 not int.
2227 (encode_terminal_code, calculate_costs): Check for size
2228 calculation overflow.
2229 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2230 table lengths and related sizes. Don't update size until alloc
2231 done. Redo calculations to avoid overflow.
2232 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2233
2234 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2235 subtracting pointers.
2236 (gobble_line): Check for overflow more carefully. Don't update size
2237 until alloc done.
2238
2239 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2240 Don't update size until alloc done.
2241 Redo size calculations to avoid overflow.
2242 Check for size calculation overflow.
0065d054 2243 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
2244
2245 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2246 Use ptrdiff_t, not int, for sizes.
2247 (store_mode_line_noprop_char): Don't update size until alloc done.
2248
0065d054
PE
2249 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2250 Use ptrdiff_t, not int, for sizes.
2251 (Finternal_make_lisp_face, cache_face):
2252 Check for size calculation overflow.
2253 (cache_face): Treat size calculation overflows as if they were
2254 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
2255
2256 * xfns.c (x_encode_text, x_set_name_internal)
2257 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2258 sizes, since they can exceed INT_MAX in size. Check for size
2259 calculation overflow.
2260
0065d054
PE
2261 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2262 (xg_select): Check for size calculation overflow.
726e0ab1
PE
2263 Don't update size until alloc done.
2264
0065d054 2265 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 2266 as sprintf is limited to int lengths.
1d526e2f 2267
252c5ee1
PE
2268 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2269 (X_LONG_MIN): New macros.
864d7ce7
PE
2270 Use them to make the following changes clearer.
2271 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2272 This change doesn't affect the value now, but it may help remind
2273 future maintainers not to raise the value too much later.
2274 (SELECTION_QUANTUM): Remove, replacing with ...
2275 (selection_quantum): ... new function, which avoids overflow.
2276 All uses changed.
2277 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2278 assumption that selection length fits in 'int'.
2279 (x_reply_selection_request, x_handle_selection_request)
2280 (x_get_window_property, receive_incremental_selection)
2281 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2282 (lisp_data_to_selection_data, clean_local_selection_data):
2283 Use ptrdiff_t, not int, to record length of selection.
2284 (x_reply_selection_request, x_get_window_property)
2285 (receive_incremental_selection, x_property_data_to_lisp):
2286 Redo calculations to avoid overflow.
2287 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 2288 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
2289 something.
2290 (x_get_window_property, receive_incremental_selection)
2291 (lisp_data_to_selection_data, x_property_data_to_lisp):
2292 Check for size-calculation overflow.
2293 (x_get_window_property, receive_incremental_selection)
2294 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2295 Don't store size until memory allocation succeeds.
2296 (x_get_window_property): Plug memory leak on memory exhaustion.
2297 Don't double-block input; malloc is safe here. Don't assume 2**34
2298 - 4 fits in unsigned long. Add an xassert to check
2299 XGetWindowProperty overflow. Be more careful about overflow
2300 calculations, and distinguish size from memory overflow better.
2301 (receive_incremental_selection): When tracing, don't assume
2302 unsigned int is less than INT_MAX.
2303 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2304 harmful) conversions of unsigned short to int.
2305 (lisp_data_to_selection_data): Don't assume that integers
2306 in the range -65535 through -1 fit in an X unsigned short.
2307 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2308 result parameters unless successful. Rely on cons_to_unsigned
2309 to report problems with elements; the old code wasn't right anyway.
2310 (x_check_property_data): Check for int overflow; we cannot use
2311 a wider type due to X limits.
2312 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2313
726e0ab1 2314 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 2315
0065d054
PE
2316 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2317 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
2318 (x_color_cells): Don't store size until memory allocation succeeds.
2319 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 2320 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
2321 (x_term_init): Don't assume length fits in int (sprintf is limited
2322 to int size).
bc18e09d 2323
ebfa62c0
PE
2324 Use ptrdiff_t for composition IDs.
2325 * character.c (lisp_string_width):
2326 * composite.c (composition_table_size, n_compositions)
2327 (get_composition_id, composition_gstring_from_id):
2328 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2329 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2330 * window.c (Frecenter):
2331 Use ptrdiff_t, not int, for composition IDs.
2332 * composite.c (get_composition_id): Check for integer overflow.
2333 * composite.h: Adjust prototypes to match the above changes.
2334
d3411f89
PE
2335 Use ptrdiff_t for hash table indexes.
2336 * category.c (hash_get_category_set):
2337 * ccl.c (ccl_driver):
2338 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2339 * coding.c (coding_system_charset_list, detect_coding_system):
2340 * coding.h (struct coding_system.id):
2341 * composite.c (get_composition_id, gstring_lookup_cache):
2342 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2343 * image.c (xpm_get_color_table_h):
2344 * lisp.h (hash_lookup, hash_put):
2345 * minibuf.c (Ftest_completion):
2346 Use ptrdiff_t for hash table indexes, not int (which is too
2347 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2348 32-bit --with-wide-int hosts).
2349
e097a6fa
PE
2350 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2351 Add a FIXME comment about memory leaks.
2352 (syms_of_charset): Don't assume xmalloc returns.
2353
5637687f
PE
2354 Don't assume that stated character widths fit in int.
2355 * character.c (Fchar_width, c_string_width, lisp_string_width):
2356 * character.h (CHAR_WIDTH):
2357 * indent.c (MULTIBYTE_BYTES_WIDTH):
2358 Use sanitize_char_width to avoid undefined and/or bad behavior
2359 with outlandish widths.
a66cfb1c 2360 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
2361 now that we have two such functions. All uses changed.
2362 (sanitize_char_width): New inline function.
2363
a2271ba2
PE
2364 Don't assume that tab-width fits in int.
2365 * character.h (sanitize_width): New inline function.
2366 (SANE_TAB_WIDTH): New macro.
2367 (ASCII_CHAR_WIDTH): Use it.
2368 * indent.c (sane_tab_width): Remove. All uses replaced by
2369 SANE_TAB_WIDTH (current_buffer).
2370 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2371
18c52557
PE
2372 * fileio.c: Integer overflow issues with file modes.
2373 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2374
caeeedc1
PE
2375 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2376 Remove unreachable code.
2377 (read_hex, load_charset_map_from_file): Check for integer overflow.
2378
50849c52
PE
2379 * xterm.c: don't go over XClientMessageEvent limit
2380 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2381 (x_send_scroll_bar_event): Likewise. Check that the size does not
2382 exceed limits imposed by XClientMessageEvent, as well as the usual
2383 ptrdiff_t and size_t limits.
2384
b13995db
PE
2385 * keyboard.c: Overflow, signedness and related fixes.
2386 (make_lispy_movement): Use same integer type in forward decl
2387 that is used in the definition.
2388 (read_key_sequence, keyremap_step):
2389 Change bufsize argument back to int, undoing my 2011-03-30 change.
2390 We prefer signed types, and int is wide enough here.
2391 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2392 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2393 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2394 length, not size_t. Use ptrdiff_t for index, not int.
2395 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2396 possibility of integer overflow.
2397
13464394
PE
2398 Overflow, signedness and related fixes for images.
2399
2400 * dispextern.h (struct it.stack[0].u.image.image_id)
2401 (struct_it.image_id, struct image.id, struct image_cache.size)
2402 (struct image_cache.used, struct image_cache.ref_count):
2403 * gtkutil.c (update_frame_tool_bar):
2404 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2405 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2406 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2407 * nsmenu.m (update_frame_tool_bar):
2408 * xdisp.c (calc_pixel_width_or_height):
2409 * xfns.c (image_cache_refcount):
2410 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2411 on typical 64-bit hosts.
2412
2413 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2414 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2415 Omit unnecessary casts to int.
2416 (parse_image_spec): Check that integers fall into 'int' range
2417 when the callers expect that.
2418 (image_ascent): Redo ascent calculation to avoid int overflow.
2419 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2420 (lookup_image): Remove unnecessary tests.
2421 (xbm_image_p): Locals are now of int, not EMACS_INT,
2422 since parse_image_check makes sure they fit into int.
2423 (png_load, gif_load, svg_load_image):
2424 Prefer int to unsigned where either will do.
2425 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
2426 old tiff_error_handler and tiff_warning_handler.
2427 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
2428 stack buffer overflows. It uses only the features of vsnprintf
2429 that are common to both POSIX and native Microsoft.
2430 (tiff_error_handler, tiff_warning_handler): Use it.
2431 (tiff_load, gif_load, imagemagick_load_image):
2432 Don't assume :index value fits in 'int'.
2433 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2434 (imagemagick_load_image): Check that crop parameters fit into
2435 the integer types that MagickCropImage accepts. Don't assume
2436 Vimagemagick_render_type has a nonnegative value. Don't assume
2437 size_t fits in 'long'.
2438 (gs_load): Use printmax_t to print the widest integers possible.
2439 Check for integer overflow when computing image height and width.
2440
c11821d4
EZ
24412011-08-26 Eli Zaretskii <eliz@gnu.org>
2442
2443 * xdisp.c (redisplay_window): Don't force window start if point
2444 will be invisible in the resulting window. (Bug#9324)
2445
0c95fcf7
EZ
24462011-08-25 Eli Zaretskii <eliz@gnu.org>
2447
2448 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2449 the display spec is of the form `(space ...)'.
2450 (handle_display_spec): Return the value returned by
2451 handle_single_display_spec, not just 1 or zero.
2452 (handle_single_display_spec): If the display spec is of the form
2453 `(space ...)', and specifies display in the text area, return 2
2454 rather than 1.
fee65a97 2455 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
2456 accurately, and prefer exact match for point under bidi.
2457 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
2458
2459 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2460 into disp_prop; all users changed.
2461
2462 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2463 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2464 for the text covered by the display property.
2465
e4ed06f1
CY
24662011-08-25 Chong Yidong <cyd@stupidchicken.com>
2467
2468 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2469 Change return value to nil.
2470 (Frecord_buffer): Delete unused function.
2471
f67cdd7f
EZ
24722011-08-24 Eli Zaretskii <eliz@gnu.org>
2473
5980d4c6
EZ
2474 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2475 buffers, return left-to-right.
8610fe8b
EZ
2476 (set_cursor_from_row): Consider candidate row a win if its glyph
2477 represents a newline and point is on that newline. Fixes cursor
2478 positioning on the newline at EOL of R2L text within L2R
2479 paragraph, and vice versa.
2480 (try_cursor_movement): Check continued rows, in addition to
2481 continuation rows. Fixes unwarranted scroll when point enters a
2482 continued line of R2L text within an L2R paragraph, or vice versa.
2483 (cursor_row_p): Consider the case of point being equal to
2484 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2485 from the end of a short line to the beginning of a continued line
2486 of R2L text within L2R paragraph.
2487 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2488 composed characters.
5980d4c6 2489
f67cdd7f
EZ
2490 * bidi.c (bidi_check_type): Use xassert.
2491 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2492 members.
2493
bca633fb
EZ
24942011-08-23 Eli Zaretskii <eliz@gnu.org>
2495
2496 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2497 a character.
2498
4a5885a7
CY
24992011-08-23 Chong Yidong <cyd@stupidchicken.com>
2500
2501 * nsfont.m (ns_otf_to_script): Fix typo.
2502
0902a04e
KH
25032011-08-22 Kenichi Handa <handa@m17n.org>
2504
2505 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2506 extra slot even if the purpose is char-code-property-table.
2507
1a2e6670
EZ
25082011-08-23 Eli Zaretskii <eliz@gnu.org>
2509
8ddde651
EZ
2510 * xdisp.c (redisplay_window): When computing centering_position,
2511 account for the height of the header line. (Bug#8874)
2512
425cc014
EZ
2513 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2514 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2515 candidate is selected by the mouse, and that candidate has a
2516 composed character under the mouse.
2517
1a2e6670
EZ
2518 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2519 coordinates reported by pos-visible-in-window-p for a composed
2520 character in column zero.
2521
8b76d6f8
SM
25222011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2523
2524 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2525
dac347dd
EZ
25262011-08-22 Eli Zaretskii <eliz@gnu.org>
2527
2528 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2529 consider it a hit if to_charpos is anywhere in the range of the
2530 composed buffer positions.
2531
e013fb34
CY
25322011-08-22 Chong Yidong <cyd@stupidchicken.com>
2533
2534 * image.c (gif_load): Don't assume that each subimage has the same
2535 dimensions as the base image. Handle disposal method that is
2536 "undefined" by the gif spec (Bug#9335).
2537
bd1ba3e8
CY
25382011-08-20 Chong Yidong <cyd@stupidchicken.com>
2539
2540 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 2541 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 2542
54a1215b
EZ
25432011-08-19 Eli Zaretskii <eliz@gnu.org>
2544
823564e5
EZ
2545 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2546 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2547 from an Org mode buffer to a Speedbar frame.
2548
54a1215b
EZ
2549 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2550 a composition, take its buffer position from IT->cmp_it.charpos.
2551 Fixes cursor positioning at the beginning of a line that begins
2552 with a composed character.
2553
9778ebcc
EZ
25542011-08-18 Eli Zaretskii <eliz@gnu.org>
2555
0be6ee06
EZ
2556 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2557 character bidirectional type, use STRONG_L instead. Fixes crashes
2558 in a buffer produced by `describe-categories'.
2559
9778ebcc
EZ
2560 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2561 members before the level stack, so they would be saved and
2562 restored when copying iterator state. Fixes incorrect reordering
2563 around TABs covered by display properties.
2564
156bffbe
AS
25652011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2566
6b02f655 2567 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 2568
72ad093b
CY
25692011-08-17 Chong Yidong <cyd@stupidchicken.com>
2570
2571 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
2572 (internal_condition_case_2, internal_condition_case_n):
2573 Remove unnecessary aborts (Bug#9081).
72ad093b 2574
35774242
EZ
25752011-08-17 Eli Zaretskii <eliz@gnu.org>
2576
2577 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2578 has no `load' handler, try opening the file locally. (Bug#9311)
2579
db76dd85
KB
25802011-08-16 Ken Brown <kbrown@cornell.edu>
2581
2582 * gmalloc.c: Expand comment.
2583
b215eee5
EZ
25842011-08-16 Eli Zaretskii <eliz@gnu.org>
2585
2586 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2587 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2588
a4579d33
KB
25892011-08-16 Ken Brown <kbrown@cornell.edu>
2590
2591 Fix memory allocation problems in Cygwin build (Bug#9273).
2592
2593 * unexcw.c ( __malloc_initialized): Declare external variable.
2594 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2595
8b76d6f8
SM
2596 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2597 New variables.
a4579d33
KB
2598 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2599 dumped emacs.
2600 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2601 in the static heap.
2602 [CYGWIN] (special_realloc): New function.
2603 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2604 requests to realloc storage in the static heap.
2605
3ebec551
PE
26062011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2607
2608 * bidi.c (bidi_initialize): Remove unused local.
2609
9fd8be00
EZ
26102011-08-15 Eli Zaretskii <eliz@gnu.org>
2611
6b02f655
SM
2612 * bidimirror.h:
2613 * biditype.h: Remove file.
2614 * makefile.w32-in ($(BLD)/bidi.$(O)):
2615 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
2616
2617 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2618
2619 * chartab.c: Improve commentary for the uniprop_table API.
2620
32413314
EZ
2621 * bidi.c (bidi_paragraph_init): Support zero value of
2622 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
2623 (bidi_initialize): Use uniprop_table instead of including
2624 biditype.h and bidimirror.h.
32413314 2625
9fd8be00
EZ
2626 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2627 coordinates of the iterator when restoring from ppos_it.
2628 (Bug#9296)
2629
5cf2b69b
KH
26302011-08-14 Kenichi Handa <handa@m17n.org>
2631
2632 * process.c (create_process): Call setup_process_coding_systems
72ad093b 2633 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 2634
daf17d00
EZ
26352011-08-14 Eli Zaretskii <eliz@gnu.org>
2636
2637 * xdisp.c (move_it_in_display_line_to): Don't invoke
2638 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2639 ppos_it. Fixes vertical cursor motion when line beginning is
2640 covered by an image. (Bug#9296)
2641
08e3161a
JD
26422011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2643
2644 * nsterm.h (ns_run_ascript): Declare.
2645 (NSAPP_DATA2_RUNASSCRIPT): Define.
2646
2647 * nsfns.m (as_script, as_result, as_status): New static variables.
2648 (ns_run_ascript): New function.
5e617bc2 2649 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
2650 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2651 the event loop. Get status from as_status (Bug#7276).
2652
2653 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2654 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2655 the event loop (Bug#7276).
2656
a3720aa2
AS
26572011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2658
2659 * gnutls.c (QCgnutls_bootprop_priority)
2660 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2661 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2662 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2663 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2664 (QCgnutls_bootprop_verify_hostname_error)
2665 (QCgnutls_bootprop_callbacks_verify): Rename from
2666 Qgnutls_bootprop_..., all uses changed.
2667
2668 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2669 uses changed.
2670
0a0d27fb
PE
26712011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2672
19d5c50c
PE
2673 * xfaces.c (Qframe_set_background_mode): Now static.
2674 * dispextern.h (Qframe_set_background_mode): Remove decl.
2675
0a0d27fb
PE
2676 * process.c (Fnetwork_interface_info): Declare local only if needed.
2677
377538cb
JD
26782011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2679
2680 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2681 (Fnetwork_interface_list): Allocate in increments of bytes instead
2682 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2683 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2684 sockaddr.
2685 (struct ifflag_def): notrailers is smart on OSX.
2686 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2687 Get hardware address with getifaddrs if available.
2688
08fff70c
EZ
26892011-08-12 Eli Zaretskii <eliz@gnu.org>
2690
2691 * xdisp.c (iterate_out_of_display_property): xassert that
2692 IT->position is set to within IT->object's boundaries. Break from
2693 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
2694 when IT->position is set up wrongly due to some bug.
2695 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
2696 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2697 entry. Force push_it to save on the stack the current
2698 buffer/string position, to be restored by pop_it. Fix flags in
2699 the iterator structure wrt the object coming from a display
2700 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2701 properties. (Bug#9284)
2702
7be1c708 27032011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 2704
7be1c708
CY
2705 * fontset.c (fontset_get_font_group): Add proper type checks.
2706 (Bug#9172)
aac0c6e3 2707
7be1c708 27082011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 2709
7be1c708
CY
2710 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2711 and LC_VERSION_MIN_MACOSX.
2712 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2713 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 2714
97bb72a6
EZ
27152011-08-08 Eli Zaretskii <eliz@gnu.org>
2716
2717 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
2718 no-display-properties-and-no-overlays under bidi display.
2719 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 2720 properties and overlays.
97bb72a6 2721
d5617611
CY
27222011-08-08 Chong Yidong <cyd@stupidchicken.com>
2723
37e11a63
CY
2724 * editfns.c (Fset_time_zone_rule): Document relationship with the
2725 setenv function.
2726
d5617611
CY
2727 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2728 the font entity extracted from the cache (Bug#8109).
2729
58872834
CY
27302011-08-07 Chong Yidong <cyd@stupidchicken.com>
2731
2732 * composite.c (autocmp_chars): Don't reset point. That is done by
2733 restore_point_unwind (Bug#5984).
2734
75bfc667
JL
27352011-08-07 Juri Linkov <juri@jurta.org>
2736
2737 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2738 to show the arg `TIME' instead of `TIMEVAL'.
2739
d1410150
EZ
27402011-08-06 Eli Zaretskii <eliz@gnu.org>
2741
2742 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2743 display property strides EOL and includes a newline, as in
2744 longlines-mode. (Bug#9254)
75b771e4
EZ
2745 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2746 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
2747
2748 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2749 is non-zero, even if the data buffer is NULL. Fixes a crash in
2750 vertical-motion with longlines-mode. (Bug#9254)
2751
35928349
EZ
27522011-08-05 Eli Zaretskii <eliz@gnu.org>
2753
ec7cc85b
EZ
2754 * bidi.c <bidi_cache_total_alloc>: Now static.
2755 (bidi_initialize): Initialize bidi_cache_total_alloc.
2756
8b76d6f8 2757 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
2758 cache. (Bug#9221)
2759
2760 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2761 amount allocated this far in `bidi_cache_total_alloc'.
2762 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2763 non-zero, only free the data buffer without restoring the cache
2764 contents. All callers changed.
2765
2766 * dispextern.h (bidi_unshelve_cache): Update prototype.
2767
2768 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2769 (move_it_in_display_line, move_it_to)
2770 (move_it_vertically_backward, move_it_by_lines): Replace the call
2771 to xfree to an equivalent call to bidi_unshelve_cache.
2772 (move_it_in_display_line_to): Fix logic of returning
412b6358 2773 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 2774
e2e2423b
EZ
27752011-08-05 Eli Zaretskii <eliz@gnu.org>
2776
2777 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2778 came from a string character with a `cursor' property. (Bug#9229)
2779
ae9e757a
JD
27802011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2781
2782 * Makefile.in (LIB_PTHREAD): New variable.
2783 (LIBES): Add LIB_PTHREAD (Bug#9216).
2784
2785 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2786 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2787
213bd7f2
AS
27882011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2789
6b02f655 2790 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 2791
99aaf75f
JD
27922011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2793
2794 * xterm.c (x_find_topmost_parent): New function.
2795 (x_set_frame_alpha): Find topmost parent window with
2796 x_find_topmost_parent and set the property there also (bug#9181).
2797 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2798
c74e9d86
PE
27992011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2800
2801 * callproc.c (Fcall_process): Avoid vfork clobbering
2802 the local vars buffer, coding_systems, current_dir.
2803
640c8776
SM
28042011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2805
2806 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2807
f26d0e4c
PE
28082011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2809
8a10d76c
PE
2810 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2811 so that it is not optimized away.
2812
f26d0e4c
PE
2813 * xdisp.c (compute_display_string_pos): Remove unused local.
2814
55439c61
EZ
28152011-08-02 Eli Zaretskii <eliz@gnu.org>
2816
2817 Fix slow cursor motion and scrolling in large buffers with
2818 selective display, like Org Mode buffers. (Bug#9218)
2819
2820 * dispextern.h (struct bidi_it): New member disp_prop_p.
2821
2822 * xdisp.c: Remove one-slot cache of display string positions.
2823 (compute_display_string_pos): Accept an additional argument
5e617bc2 2824 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
2825 for a display string or property. If found, set DISP_PROP_P
2826 non-zero.
2827
2828 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
2829 DISP_PROP_P, and pass it to compute_display_string_pos.
2830 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
2831 non-zero. All callers of bidi_fetch_char changed.
2832
fb33fa43
SM
28332011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2834
2835 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2836
b099e063
DM
28372010-12-03 Don March <don@ohspite.net>
2838
2839 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2840 last character M-[char] is translated to ESC [char] (bug#7541).
2841
5cc7f7af
KH
28422011-08-02 Kenichi Handa <handa@m17n.org>
2843
d0fffa3f 2844 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
2845
2846 * chartab.c (uniprop_table): Make it non-static.
2847
525d5e6e
EZ
28482011-08-01 Eli Zaretskii <eliz@gnu.org>
2849
2850 * xdisp.c (forward_to_next_line_start): Accept additional argument
2851 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2852 on the newline.
2853 (reseat_at_next_visible_line_start): Use the bidi iterator state
2854 returned by forward_to_next_line_start to restore the state of
2855 it->bidi_it after backing up to previous newline. (Bug#9212)
2856
31011111
AS
28572011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2858
2859 * regex.c (re_comp): Protoize.
2860 (re_exec): Fix return type.
2861 (regexec): Fix type of `ret'. (Bug#9203)
2862
476371c4
PE
28632011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2864
e5d76069
PE
2865 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2866 This is needed if max-image-size is a floating-point number.
2867
9a79b20c
AS
28682011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2869
2870 * print.c (print_object): Print empty symbol as ##.
2871
2872 * lread.c (read1): Read ## as empty symbol.
2873
d8c2fa78
AA
28742011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2875
2876 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2877 setting frame foreground color (Bug#9175).
2878 (x_set_background_color): Likewise.
2879
ffe57a7a
AA
2880 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2881 contents (Bug#9176).
2882 (EmacsTooltip -init): Remove bezels and add shadows to
2883 tooltip windows.
2884
bf3492a5
AA
2885 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2886 or scroll bar (Bug#8470).
2887
d55e9c53
AA
2888 * nsfont.m (nsfont_open): Remove assignment to voffset and
2889 unnecessary vars hshink, expand, hd, full_height, min_height.
2890 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2891
2892 * nsterm.h (nsfont_info): Remove voffset field.
2893
d8c2fa78 28942011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
2895
2896 Implement strike-through and overline on NextStep (Bug#8863).
2897
2898 * nsfont.m (nsfont_open): Use underline position provided by font,
2899 instead of hard-coded value of 2.
2900 (nsfont_draw): Call ns_draw_text_decoration instead.
2901
2902 * nsterm.h: Add declaration for ns_draw_text_decoration.
2903
2904 * nsterm.m (ns_draw_text_decoration): New function for drawing
2905 underline, overline, and strike-through.
2906 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2907 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 2908 accommodate underlining, etc.
4843aac3 2909
4cc60b9b
EZ
29102011-07-28 Eli Zaretskii <eliz@gnu.org>
2911
bc7ece87
EZ
2912 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2913 default.
4cc60b9b 2914
476371c4
PE
29152011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2916
66606eea
PE
2917 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2918 Without this fix, if a signal arrives just after memory fills up,
2919 'malloc' might be invoked reentrantly.
2920
476371c4
PE
2921 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2922 In other words, assume that every image size is allowed, on non-X
2923 hosts. This assumption is probably wrong, but it lets Emacs compile.
2924
f3fcc40d
AS
29252011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2926
2927 * regex.c (re_iswctype): Convert return values to boolean.
2928
350c992f
EZ
29292011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2930
2931 * xdisp.c (compute_display_string_pos): Don't use cached display
2932 string position if the buffer had its restriction changed.
2933 (Bug#9184)
2934
5266b4bb
PE
29352011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2936
2937 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2938
2573a837 29392011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 2940
41f55ccd 2941 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 2942
39e378da
PE
2943 * bidi.c: Integer size and overflow fixes.
2944 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2945 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2946 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2947 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2948 (bidi_find_other_level_edge):
2949 Use ptrdiff_t instead of EMACS_INT where either will do.
2950 This works better on 32-bit hosts configured --with-wide-int.
2951 (bidi_cache_ensure_space): Check for size-calculation overflow.
2952 Use % rather than repeated addition, for better worst-case speed.
2953 Don't set bidi_cache_size until after xrealloc returns, because it
2954 might not return.
2955 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
2956 (bidi_cache_ensure_space): Also check that the bidi cache size
2957 does not exceed that of the largest Lisp string or buffer. See Eli
2958 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 2959
5e927815
PE
2960 * alloc.c (__malloc_size_t): Remove.
2961 All uses replaced by size_t. See Andreas Schwab's note
2962 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2963
ca4aa935
PE
2964 * image.c: Improve checking for integer overflow.
2965 (check_image_size): Assume that f is nonnull, since
2966 it is always nonnull in practice. This is one less thing to
2967 worry about when checking for integer overflow later.
2968 (x_check_image_size): New function, which checks for integer
2969 overflow issues inside X.
2970 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2971 This removes the need for a memory_full check.
2972 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2973 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2974 (xbm_read_bitmap_data): Change locals back to 'int', since
2975 their values must fit in 'int'.
2976 (xpm_load_image, png_load, tiff_load):
2977 Invoke x_create_x_image_and_pixmap earlier,
2978 to avoid much needless work if the image is too large.
2979 (tiff_load): Treat overly large images as if
2980 x_create_x_image_and_pixmap failed, not as malloc failures.
2981 (gs_load): Use x_check_image_size.
2982
5f8f9cc2
PE
2983 * gtkutil.c: Omit integer casts.
2984 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2985 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2986
5adf60bc
PE
2987 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2988
c8907a93
PE
2989 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2990 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2991 would wrongly return t on a 64-bit host.
2992
e3c25c68
PE
2993 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2994 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2995 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2996 and therefore cause GCC to emit a bogus diagnostic in some cases.
2997
3f791afe
PE
2998 * image.c: Integer signedness and overflow and related fixes.
2999 This is not an exhaustive set of fixes, but it's time to
3000 record what I've got.
3001 (lookup_pixel_color, check_image_size): Remove redundant decls.
3002 (check_image_size): Don't assume that arbitrary EMACS_INT values
3003 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3004 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3005 (tiff_load, imagemagick_load_image):
3006 Check for overflow in size calculations.
3007 (x_create_x_image_and_pixmap): Remove unnecessary test for
3008 xmalloc returning NULL; that can't happen.
3009 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3010 (xpm_color_bucket): Use better integer hashing function.
3011 (xpm_cache_color): Don't possibly over-allocate memory.
3012 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3013 (gif_memory_source):
3014 Use ptrdiff_t, not int or size_t, to record sizes.
3015 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3016 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3017 either works, as we prefer signed integers.
3018 (tiff_read_from_memory, tiff_write_from_memory):
3019 Return tsize_t, not size_t, since that's what the TIFF API wants.
3020 (tiff_read_from_memory): Don't fail simply because the read would
3021 go past EOF; instead, return a short read.
3022 (tiff_load): Omit no-longer-needed casts.
3023 (Fimagemagick_types): Don't assume size fits into 'int'.
3024
3cc5a532
PE
3025 Improve hashing quality when configured --with-wide-int.
3026 * fns.c (hash_string): New function, taken from sxhash_string.
3027 Do not discard information about ASCII character case; this
3028 discarding is no longer needed.
3029 (sxhash-string): Use it. Change sig to match it. Caller changed.
3030 * lisp.h: Declare it.
3031 * lread.c (hash_string): Remove, since we now use fns.c's version.
3032 The fns.c version returns a wider integer if --with-wide-int is
3033 specified, so this should help the quality of the hashing a bit.
3034
b312a492
PE
3035 * emacs.c: Integer overflow minor fix.
3036 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3037 Define only if GNU_LINUX.
3038 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3039
dfd153ae
PE
3040 * dispnew.c: Integer signedness and overflow fixes.
3041 Remove unnecessary forward decls, that were a maintenance hassle.
3042 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3043 All uses changed.
3044 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3045 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3046 (prepare_desired_row, line_draw_cost):
3047 Use int, not unsigned, where either works.
3048 (save_current_matrix, restore_current_matrix):
3049 Use ptrdiff_t, not size_t, where either works.
3050 (init_display): Check for overflow more accurately, and without
3051 relying on undefined behavior.
3052
a81d11a3
PE
3053 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3054 Remove, replacing with the new symbols in lisp.h. All uses changed.
3055 * fileio.c (make_temp_name):
3056 * filelock.c (lock_file_1, lock_file):
3057 * xdisp.c (message_dolog):
3058 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3059 Use pMd etc. instead.
3060 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3061 replacing the pWIDE etc. symbols removed from editfns.c.
3062
3300e6fd
PE
3063 * keyboard.h (num_input_events): Now uintmax_t.
3064 This is (very slightly) less likely to mess up due to wraparound.
3065 All uses changed.
3066
fd05c7e9
PE
3067 * buffer.c: Integer signedness fixes.
3068 (alloc_buffer_text, enlarge_buffer_text):
3069 Use ptrdiff_t rather than size_t when either will do, as we prefer
3070 signed integers.
3071
903fe15d
PE
3072 * alloc.c: Integer signedness and overflow fixes.
3073 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3074 (__malloc_size_t): Default to size_t, not to int.
3075 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3076 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3077 Prefer ptrdiff_t to size_t when either would do, as we prefer
3078 signed integers.
3079 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3080 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3081 Now const. Initialize with values that are in range even if char
3082 is signed.
3083 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3084 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3085 These functions do the right thing with sizes > 2**32.
3086 (check_depth): Now ptrdiff_t, not int.
3087 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3088 Adjust to new way of storing sizes. Check for size overflow bugs
3089 in rest of code.
3090 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3091 slightly wrong anyway, as it missed one instance of
3092 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3093 (refill_memory_reserve): Omit needless cast to size_t.
3094 (mark_object_loop_halt): Mark as externally visible.
3095
ac82cc6a
PE
3096 * xselect.c: Integer signedness and overflow fixes.
3097 (Fx_register_dnd_atom, x_handle_dnd_message):
3098 Use ptrdiff_t, not size_t, since we prefer signed.
3099 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3100 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3101 x_dnd_atoms_size and x_dnd_atoms_length.
3102
c2d1e36d
PE
3103 * doprnt.c: Prefer signed to unsigned when either works.
3104 * eval.c (verror):
3105 * doprnt.c (doprnt):
3106 * lisp.h (doprnt):
3107 * xdisp.c (vmessage):
3108 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3109 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3110 prefer signed arithmetic to avoid comparison confusion.
3111 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3112 but is a bit tricky.
3113
0e926e56
PE
3114 Assume freestanding C89 headers, string.h, stdlib.h.
3115 * data.c, doprnt.c, floatfns.c, print.c:
3116 Include float.h unconditionally.
3117 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3118 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3119 * regex.c: Likewise for stddef.h, string.h.
3120 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3121 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3122 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3123 (STDC_HEADERS): Remove obsolete defines.
3124 * sysdep.c: Include limits.h unconditionally.
3125
9cfdb3ec
PE
3126 Assume support for memcmp, memcpy, memmove, memset.
3127 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3128 * regex.c (memcmp, memcpy):
3129 Remove; we assume C89 now.
3130
3131 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3132 (__malloc_safe_bcopy): Remove; no longer needed.
3133
cf950e6b 3134 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
3135 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3136 well either way, and we prefer signed to unsigned.
3137
dbf38e02
LMI
31382011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3139
3140 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3141 closes the connection while we're reading (bug#9182).
3142
d6f0886c 31432011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 3144
d6f0886c
JD
3145 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3146 are specified (Bug#9168).
24e0f6b1 3147
2eb1f9e6
PE
31482011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3149
3150 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3151 Found by GCC static checking and --with-wide-int on a 32-bit host.
3152
22381272 31532011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
3154
3155 * xdisp.c (compute_display_string_pos): Fix logic of caching
3156 previous display string position. Initialize cached_prev_pos to
3157 -1. Fixes slow-down at the beginning of a buffer.
3158
f25e39b4
EZ
31592011-07-24 Eli Zaretskii <eliz@gnu.org>
3160
3161 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3162 for attrs[LFACE_FONTSET_INDEX].
3163
04c4b52e
PE
31642011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3165
3166 * xml.c (parse_region): Remove unused local
3167 that was recently introduced.
3168
c1734fbd
EZ
31692011-07-23 Eli Zaretskii <eliz@gnu.org>
3170
be18c5a5
EZ
3171 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3172 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3173
c1734fbd
EZ
3174 * xdisp.c (move_it_in_display_line_to): Record the best matching
3175 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
3176 exit if none of the characters scanned was an exact match.
3177 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
3178 when exact match is impossible due to invisible text, and the
3179 lines are truncated.
3180
a258d627
JD
31812011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3182
3183 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3184 for OSX >= 10.7.
3185
b6d5a689
EZ
31862011-07-22 Eli Zaretskii <eliz@gnu.org>
3187
0f74f785
EZ
3188 Fix a significant slow-down of cursor motion with C-n, C-p,
3189 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3190 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 3191 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
3192 (next_element_from_buffer): Call compute_stop_pos_backwards to
3193 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
3194 base_level_stop.
3195 (reseat): Don't look for prev_stop, as that could mean a very long
3196 run.
3197 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3198 <cached_disp_overlay_modiff>: Cache for last found display string
3199 position.
551918c1 3200 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
3201 about the same buffer in the same area of character positions, and
3202 the buffer wasn't changed since the time the display string
3203 position was cached.
551918c1 3204
b2d0c91a
EZ
32052011-07-22 Eli Zaretskii <eliz@gnu.org>
3206
3207 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3208 is an integer, which is important for empty lines. (Bug#9149)
3209
043604ee
CY
32102011-07-22 Chong Yidong <cyd@stupidchicken.com>
3211
3212 * frame.c (Fmodify_frame_parameters): In tty case, update the
3213 default face if necessary (Bug#4238).
3214
da4adb04
CY
32152011-07-21 Chong Yidong <cyd@stupidchicken.com>
3216
3217 * editfns.c (Fstring_to_char): No need to explain what a character
3218 is in the docstring (Bug#6576).
3219
9abd0532
LMI
32202011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3221
3222 * xml.c (parse_region): Make sure we always return a tree.
3223
36881d16
HK
32242011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3225
3226 * xml.c (parse_region): If a document contains only comments,
3227 return that, too.
3228
1e98674d
LMI
32292011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3230
3231 * xml.c (make_dom): Return comments, too.
3232
590bd467
PE
32332011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3234
3235 Port to OpenBSD.
3236 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3237 and the surrounding thread.
3238 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3239 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3240 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3241 timer goes off.
3242 * s/openbsd.h (BROKEN_SIGIO): Define.
3243 * unexelf.c (unexec) [__OpenBSD__]:
3244 Don't update the .mdebug section of the Alpha COFF symbol table.
3245
f41628b2
LMI
32462011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3247
3248 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3249 (bug#8460).
3250
b59b67c5
PE
32512011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3252
15e3a074
PE
3253 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3254 This fixes some race conditions on the permissions of any newly
3255 created file.
3256
41bed37d
PE
3257 * alloc.c (valid_pointer_p): Use pipe, not open.
3258 This fixes some permissions issues when debugging.
3259
b59b67c5
PE
3260 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3261 If fchown fails to set both uid and gid, try to set just gid,
3262 as that is sometimes allowed. Adjust the file's mode to eliminate
3263 setuid or setgid bits that are inappropriate if fchown fails.
3264
925a6be7
SM
32652011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3266
3267 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3268 to compare Lisp_Objects.
3269 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3270 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3271 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3272
52968808
AS
32732011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3274
0a6a104b
AS
3275 * lread.c (read_integer): Unread even EOF character.
3276 (read1): Likewise. Properly record start position of symbol.
3277
52968808
AS
3278 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3279 symbol character follows.
3280
9e381cdd
PE
32812011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3282
3283 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3284 This works around a problem with the previous change to Fcopy_file.
3285 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3286 and without this change, GCC might complain about discarding
3287 fchown's return value.
3288
b5641435
JB
32892011-07-16 Juanma Barranquero <lekktu@gmail.com>
3290
3291 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3292
a8031457
PE
32932011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3294
3295 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3296
dd889327
LMI
32972011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3298
750c33f7
LMI
3299 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3300 it's used from the C level.
3301
dd889327
LMI
3302 * process.c: Use the same condition for POLL_FOR_INPUT in both
3303 keyboard.c and process.c (bug#1858).
3304
87e86684
LM
33052011-07-09 Lawrence Mitchell <wence@gmx.li>
3306
3307 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3308 (Fgnutls_boot): Use it.
3309
64348f40
AS
33102011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3311
3312 * doc.c (Fsubstitute_command_keys): Revert last change.
3313
1d698799
LMI
33142011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3315
f863868c
LMI
3316 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3317 quotes the next character, and doesn't affect other longer
3318 sequences (bug#8935).
3319
1d698799
LMI
3320 * lread.c (syms_of_lread): Clarify that is isn't only
3321 `eval-buffer' and `eval-defun' that's affected by
3322 `lexical-binding' (bug#8460).
3323
aa4b6df6
EZ
33242011-07-15 Eli Zaretskii <eliz@gnu.org>
3325
3326 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 3327 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 3328
5d856da6
PE
33292011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3330
ad6042bb
PE
3331 Fix minor problems found by static checking.
3332 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3333 (elsz): Now a signed constant, not a size_t var. We prefer signed
3334 types to unsigned, to avoid integer comparison confusion. Without
3335 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3336 "cannot optimize loop, the loop counter may overflow", a symptom
3337 of the confusion.
f00bbb22 3338 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
3339 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3340
6468f31c
LMI
33412011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3342
49080b10
LMI
3343 * search.c (Fre_search_backward): Mention `case-fold-search' in
3344 all the re_search_* functions (bug#8138).
3345
6468f31c
LMI
3346 * keyboard.c (Fopen_dribble_file): Document when the file is
3347 closed (bug#8056).
3348
c965adc5
EZ
33492011-07-14 Eli Zaretskii <eliz@gnu.org>
3350
df9733bf
EZ
3351 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3352 bidi_cache_idx.
3353
0bb23927
EZ
3354 Support bidi reordering of display and overlay strings.
3355 * xdisp.c (compute_display_string_pos)
3356 (compute_display_string_end): Accept additional argument STRING.
3357 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3358 (reseat_to_string): Initialize bidi_it->string.s and
3359 bidi_it->string.schars.
3360 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
3361 NULL (avoids a crash in bidi_paragraph_init).
3362 Initialize itb.string.lstring.
0bb23927
EZ
3363 (init_iterator): Call bidi_init_it only of a valid
3364 buffer position was specified. Initialize paragraph_embedding to
3365 L2R.
3366 (reseat_to_string): Initialize the bidi iterator.
3367 (display_string): If we need to ignore text properties of
3368 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3369 original value of -1 will not work with bidi.)
3370 (compute_display_string_pos): First arg is now struct
3371 `text_pos *'; all callers changed. Support display properties on
3372 Lisp strings.
3373 (compute_display_string_end): Support display properties on Lisp
3374 strings.
3375 (init_iterator, reseat_1, reseat_to_string): Initialize the
3376 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3377 when iterating on a string not from display properties).
640c8776
SM
3378 (compute_display_string_pos, compute_display_string_end):
3379 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
3380 arrow keys.
3381 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
3382 base_level_stop; instead, set base_level_stop to BEGV.
3383 Fixes crashes in vertical-motion.
0bb23927
EZ
3384 (next_element_from_buffer): Improve commentary for when
3385 the iterator is before prev_stop.
3386 (init_iterator): Initialize bidi_p from the default value of
3387 bidi-display-reordering, not from buffer-local value. Use the
3388 buffer-local value only if initializing for buffer iteration.
3389 (handle_invisible_prop): Support invisible properties on strings
3390 that are being bidi-reordered.
3391 (set_iterator_to_next): Support bidi reordering of C strings and
3392 Lisp strings.
3393 (next_element_from_string): Support bidi reordering of Lisp
3394 strings.
3395 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
3396 (display_string): Support display of R2L glyph rows.
3397 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
3398 (init_iterator): Don't initialize it->bidi_p for strings
3399 here.
3400 (reseat_to_string): Initialize it->bidi_p for strings here.
3401 (next_element_from_string, next_element_from_c_string)
3402 (next_element_from_buffer): Add xassert's for correspondence
3403 between IT's object being iterated and it->bidi_it.string
3404 structure.
3405 (face_before_or_after_it_pos): Support bidi iteration.
3406 (next_element_from_c_string): Handle the case of the first string
3407 character that is not the first one in the visual order.
3408 (get_visually_first_element): New function, refactored from common
3409 parts of next_element_from_buffer, next_element_from_string, and
3410 next_element_from_c_string.
3411 (tool_bar_lines_needed, redisplay_tool_bar)
3412 (display_menu_bar): Force left-to-right direction. Add a FIXME
3413 comment for making that be controlled by a user option.
3414 (push_it, pop_it): Save and restore the state of the
3415 bidi iterator. Save and restore the bidi_p flag.
3416 (pop_it): Iterate out of display property for string iteration as
3417 well.
3418 (iterate_out_of_display_property): Support iteration over strings.
3419 (handle_single_display_spec): Set up it->bidi_it for iteration
3420 over a display string, and call bidi_init_it.
3421 (handle_single_display_spec, next_overlay_string)
3422 (get_overlay_strings_1, push_display_prop): Set up the bidi
3423 iterator for displaying display or overlay strings.
3424 (forward_to_next_line_start): Don't use the shortcut if
3425 bidi-iterating.
3426 (back_to_previous_visible_line_start): If handle_display_prop
3427 pushed the iterator stack, restore the internal state of the bidi
3428 iterator by calling bidi_pop_it same number of times.
3429 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3430 and we are bidi-iterating, don't decrement the iterator position;
3431 instead, set the first_elt flag in the bidi iterator, to produce
3432 the same effect.
3433 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3434 (push_display_prop): xassert that we are iterating a buffer.
3435 (push_it, pop_it): Save and restore paragraph_embedding member.
3436 (handle_single_display_spec, next_overlay_string)
3437 (get_overlay_strings_1, reseat_1, reseat_to_string)
3438 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3439 correctly. Don't assume unibyte strings are not bidi-reordered.
3440 (compute_display_string_pos)
3441 (compute_display_string_end): Fix handling the case of C string.
3442 (push_it, pop_it): Save and restore from_disp_prop_p.
3443 (handle_single_display_spec, push_display_prop): Set the
3444 from_disp_prop_p flag.
3445 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3446 (pop_it): Call iterate_out_of_display_property only if we are
3447 popping after iteration over a string that came from a display
3448 property. Fix a typo in popping stretch info. Add an assertion
3449 for verifying that the iterator position is in sync with the bidi
3450 iterator.
3451 (handle_single_display_spec, get_overlay_strings_1)
3452 (push_display_prop): Fix initialization of paragraph direction for
3453 string when that of the parent object is not yet determined.
3454 (reseat_1): Call bidi_init_it to resync the bidi
3455 iterator with IT's position. (Bug#7616)
3456 (find_row_edges): If ROW->start.pos gives position
3457 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3458 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3459 Reset the from_disp_prop_p flag.
3460 (SAVE_IT, RESTORE_IT): New macros.
3461 (pos_visible_p, face_before_or_after_it_pos)
3462 (back_to_previous_visible_line_start)
3463 (move_it_in_display_line_to, move_it_in_display_line)
3464 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3465 (try_scrolling, redisplay_window, display_line): Use them when
3466 saving a temporary copy of the iterator and restoring it back.
3467 (back_to_previous_visible_line_start, reseat_1)
3468 (init_iterator): Empty the bidi cache "stack".
3469 (move_it_in_display_line_to): If iterator ended up at
3470 EOL, but we never saw any buffer positions smaller than
3471 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3472 motion in bidi-reordered lines.
3473 (move_it_in_display_line_to): Record prev_method and prev_pos
3474 immediately before the call to set_iterator_to_next. Fixes cursor
3475 motion in bidi-reordered lines with stretch glyphs and strings
3476 displayed in margins. (Bug#8133) (Bug#8867)
3477 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3478 TO_CHARPOS.
640c8776
SM
3479 (pos_visible_p): Support positions in bidi-reordered lines.
3480 Save and restore bidi cache.
0bb23927
EZ
3481
3482 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3483 (bidi_paragraph_info): Delete unused struct.
3484 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3485 (bidi_cache_start): New variable.
3486 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3487 to zero.
3488 (bidi_cache_fetch_state, bidi_cache_search)
3489 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3490 (bidi_cache_find, bidi_peek_at_next_level)
3491 (bidi_level_of_next_char, bidi_find_other_level_edge)
3492 (bidi_move_to_visually_next): Compare cache index with
3493 bidi_cache_start rather than with zero.
3494 (bidi_fetch_char): Accept new argument STRING; all callers
3495 changed. Support iteration over a string. Support strings with
3496 display properties. Support unibyte strings. Fix the type of
3497 `len' according to what STRING_CHAR_AND_LENGTH expects.
3498 (bidi_paragraph_init, bidi_resolve_explicit_1)
3499 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
3500 (bidi_level_of_next_char, bidi_move_to_visually_next):
3501 Support iteration over a string.
0bb23927
EZ
3502 (bidi_set_sor_type, bidi_resolve_explicit_1)
3503 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3504 can now be zero (for strings); special values 0 and -1 were
3505 changed to -1 and -2, respectively.
3506 (bidi_char_at_pos): New function.
3507 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3508 Call it instead of FETCH_MULTIBYTE_CHAR.
3509 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3510 initialized to valid values.
3511 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3512 values.
3513 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3514 the test for valid cached positions. Fix the logic for looking up
3515 the sentinel state in the cache. GCPRO the Lisp string we are
3516 iterating.
3517 (bidi_push_it, bidi_pop_it): New functions.
3518 (bidi_initialize): Initialize the bidi cache start stack pointer.
3519 (bidi_cache_ensure_space): New function, refactored from part of
3520 bidi_cache_iterator_state. Don't assume the required size is just
3521 one BIDI_CACHE_CHUNK away.
3522 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3523 (bidi_count_bytes, bidi_char_at_pos): New functions.
3524 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3525 always valid if bidi_cache_idx is valid.
3526 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3527 is valid if it's going to be used.
3528 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3529 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
3530 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3531 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
3532 (bidi_find_other_level_edge, bidi_cache_start_stack):
3533 All variables related to cache indices are now EMACS_INT.
c965adc5 3534
0bb23927
EZ
3535 * dispextern.h (struct bidi_string_data): New structure.
3536 (struct bidi_it): New member `string'. Make flag members be 1-bit
3537 fields, and put them last in the struct.
640c8776
SM
3538 (compute_display_string_pos, compute_display_string_end):
3539 Update prototypes.
0bb23927
EZ
3540 (bidi_push_it, bidi_pop_it): Add prototypes.
3541 (struct iterator_stack_entry): New members bidi_p,
3542 paragraph_embedding, and from_disp_prop_p.
3543 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
3544 (bidi_shelve_cache, bidi_unshelve_cache):
3545 Declare prototypes.
0bb23927
EZ
3546
3547 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3548 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3549 and vector-like objects.
3550
3551 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3552 cache around display iteration.
3553
3554 * window.c (Fwindow_end, window_scroll_pixel_based)
3555 (displayed_window_lines, Frecenter): Save and restore the bidi
3556 cache around display iteration.
3557
3bbd2265
LMI
35582011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3559
3560 * editfns.c (Fdelete_region): Clarify the use of the named
3561 parameters (bug#6788).
3562
adc47434
MR
35632011-07-14 Martin Rudalics <rudalics@gmx.at>
3564
3565 * indent.c (Fvertical_motion): Set and restore w->pointm when
3566 saving and restoring the window's buffer (Bug#9006).
3567
837c31f8
LMI
35682011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3569
3570 * editfns.c (Fstring_to_char): Clarify just what is returned
3571 (bug#6576). Text by Eli Zaretskii.
3572
ac389d0c
JB
35732011-07-13 Juanma Barranquero <lekktu@gmail.com>
3574
3575 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3576
0be0ce47
EZ
35772011-07-13 Eli Zaretskii <eliz@gnu.org>
3578
3579 * buffer.c (mmap_find): Fix a typo.
3580
cd18e7e3
JB
35812011-07-13 Johan Bockgård <bojohan@gnu.org>
3582
3583 Fix execution of x selection hooks.
3584 * xselect.c (Qx_lost_selection_functions)
3585 (Qx_sent_selection_functions): New vars.
3586 (syms_of_xselect): DEFSYM them.
3587 (x_handle_selection_request): Pass Qx_sent_selection_functions
3588 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3589 (x_handle_selection_clear,x_clear_frame_selections):
3590 Pass Qx_lost_selection_functions rather than
3591 Vx_lost_selection_functions to Frun_hook_with_args.
3592
47ea7f44
PE
35932011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3594
ac389d0c 3595 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
3596 The old code sometimes used this field without initializing it.
3597
47ea7f44
PE
3598 * alloc.c (gc_sweep): Don't read past end of array.
3599 In theory, the old code could also have corrupted Emacs internals,
3600 though it'd be very unlikely.
3601
bc985c87
AS
36022011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3603
3604 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 3605 argument. (Bug#4026)
bc985c87 3606
0cf34688
LMI
36072011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3608
b3dadd76
LMI
3609 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3610 key" (bug#4257).
3611
0cf34688
LMI
3612 * window.c (Fset_window_start): Doc fix (bug#4199).
3613 (Fset_window_hscroll): Ditto.
3614
270768cd
PE
36152011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3616
077e3dda 3617 Fix minor new problems caught by GCC 4.6.1.
270768cd 3618 * term.c (init_tty): Remove unused local.
490011a6 3619 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 3620 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 3621 not used otherwise.
270768cd 3622
b1f58454
CY
36232011-07-12 Chong Yidong <cyd@stupidchicken.com>
3624
3625 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3626
22b9578d
LMI
36272011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3628
6e70ab07
LMI
3629 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3630 are the mini-buffer and the echo area (bug#3320).
3631
22b9578d
LMI
3632 * term.c (init_tty): Remove support for supdup, c10 and perq
3633 terminals, which are no longer supported (bug#1482).
3634
8974cc9f
JB
36352011-07-10 Johan Bockgård <bojohan@gnu.org>
3636
3637 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3638
a560d974
JD
36392011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3640
3641 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3642 for non-popups (Bug#3642).
3643
1dae0f0a
AS
36442011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3645
268c2c36 3646 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 3647 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
3648 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3649 * cm.c (losecursor): Likewise.
1dae0f0a
AS
3650 * data.c (fmod): Likewise.
3651 * dispnew.c (swap_glyphs_in_rows): Likewise.
3652 * emacs.c (memory_warning_signal): Likewise.
3653 * floatfns.c (float_error): Likewise.
3654 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3655 (otf_open, font_otf_capability, generate_otf_features)
3656 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3657 Likewise.
3658 * image.c (pbm_read_file): Likewise.
3659 * indent.c (string_display_width): Likewise.
3660 * intervals.c (check_for_interval, search_for_interval)
3661 (inc_interval_count, count_intervals, root_interval)
3662 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3663 * lread.c (defalias): Likewise.
268c2c36 3664 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
3665 * regex.c (set_image_of_range_1, set_image_of_range)
3666 (regex_grow_registers): Likewise.
3667 * sysdep.c (strerror): Likewise.
3668 * termcap.c (valid_filename_p, tprint, main): Likewise.
3669 * tparam.c (main): Likewise.
3670 * unexhp9k800.c (run_time_remap, save_data_space)
3671 (update_file_ptrs, read_header, write_header, calculate_checksum)
3672 (copy_file, copy_rest, display_header): Likewise.
3673 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3674 Likewise.
3675 * xdisp.c (check_it): Likewise.
3676 * xfaces.c (register_color, unregister_color, unregister_colors):
3677 Likewise.
3678 * xfns.c (print_fontset_result): Likewise.
3679 * xrdb.c (member, fatal, main): Likewise.
3680
99033785
PE
36812011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3682
3683 Fix minor problems found by static checking (Bug#9031).
3684 * chartab.c (char_table_set_range, map_sub_char_table):
3685 Remove unused locals.
3686 (uniprop_table): Now static.
3687 * composite.c (_work_char): Remove unused static var.
3688
9cb2ac56
JB
36892011-07-09 Juanma Barranquero <lekktu@gmail.com>
3690
3691 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3692
f25661f0
JD
36932011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3694
3695 * gtkutil.c (qttip_cb): Remove code without function.
3696
8278c4fe
EZ
36972011-07-09 Eli Zaretskii <eliz@gnu.org>
3698
3699 * w32.c (pthread_sigmask): New stub.
3700
1692ae2d 37012011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 3702
8a6ebd58 3703 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
3704 sigprocmask is portable only for single-threaded applications, and
3705 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
3706 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3707 (LIBES): Use it.
3708 * callproc.c (Fcall_process):
3709 * process.c (create_process):
3710 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3711 Use pthread_sigmask, not sigprocmask.
123403e4 3712
1b854618
JD
37132011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3714
3715 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3716 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3717 wrong (Bug#8591).
3718
3fe4b549
JD
37192011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3720
0ce7e563
JD
3721 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3722 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3723 (xg_hide_tooltip): Fix comment.
3724
3fe4b549
JD
3725 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3726 in registerServicesMenuSendTypes.
3727 (validRequestorForSendType): Don't check ns_return_types.
3728
3729 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3730 ns_return_type.
3731
5df75e47
JR
37322011-07-08 Jason Rumney <jasonr@gnu.org>
3733
22610910
JR
3734 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3735 SH_SHOW for hidden windows (Bug#5482).
3736
5df75e47
JR
3737 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3738 frame struct members of non-existent frames (Bug#6284).
3739
699c10bd
JD
37402011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3741
4393663b
JD
3742 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3743 variable firstTime not needed on OSX >= 10.6.
3744 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3745 >= 10.5. Use setKnobProportion, setDoubleValue.
3746
3747 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3748 (MAC_OS_X_VERSION_10_5): Define if not defined.
3749 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3750 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3751 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3752
3753 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3754 cString and lossyCString on OSX >= 10.4
3755
58179cce 3756 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
3757 sizeToFit on OSX >= 10.2.
3758
3759 * nsimage.m (allocInitFromFile): Don't use deprecated method
3760 bestRepresentationForDevice on OSX >= 10.6.
3761
3762 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3763 to avoid warning.
3764
3765 * emacs.c: Declare unexec_init_emacs_zone.
3766
a63e0781
JD
3767 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3768
699c10bd
JD
3769 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3770
3771 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3772 on svcsMenu (Bug#8842).
3773
3774 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3775 ns_return_types.
3776 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3777
3778 * nsterm.m (QUTF8_STRING): Declare.
3779 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3780 (validRequestorForSendType): Return type is (id).
3781 Change indexOfObjectIdenticalTo to indexOfObject.
3782 Check if we have local selection before returning self (Bug#8842).
3783 (writeSelectionToPasteboard): Put local selection into paste board
3784 if we have a local selection (Bug#8842).
3785 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3786
3787 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3788 (ns_get_local_selection): Declare.
3789
54e10184
LMI
37902011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3791
9888ff71
LMI
3792 * keymap.c (describe_map_tree): Don't insert a double newline at
3793 the end of the buffer (bug#1169) and return whether we inserted
3794 something.
3795
54e10184
LMI
3796 * callint.c (Fcall_interactively): Change "reading args" to
3797 "providing args" to try to clarify what it does (bug#1010).
3798
15fa4783
KH
37992011-07-07 Kenichi Handa <handa@m17n.org>
3800
3801 * composite.c (composition_compute_stop_pos): Ignore a static
3802 composition starting before CHARPOS (Bug#8915).
3803
3804 * xdisp.c (handle_composition_prop): Likewise.
3805
a8815b00
EZ
38062011-07-07 Eli Zaretskii <eliz@gnu.org>
3807
3808 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3809 (Bug#9015)
3810
ef7b981d 38112011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
3812
3813 * character.h (unicode_category_t): New enum type.
3814
3815 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3816 (Qchar_code_property_table): New variable.
3817 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3818 (UNIPROP_COMPRESSED_FORM_P): New macros.
3819 (char_table_ascii): Uncompress the compressed values.
3820 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3821 Uncompress the compressed values.
ac389d0c 3822 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
3823 (char_table_ref_and_range): Uncompress the compressed values.
3824 (sub_char_table_set): New arg is_uniprop. Callers changed.
3825 Uncompress the compressed values.
3826 (sub_char_table_set_range): Args changed. Callers changed.
3827 (char_table_set_range): Adjuted for the above change.
3828 (map_sub_char_table): Delete args default_val and parent. Add arg
3829 top. Give decoded values to a Lisp function.
640c8776 3830 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
3831 values to a Lisp function. Gcpro more variables.
3832 (uniprop_table_uncompress)
3833 (uniprop_decode_value_run_length): New functions.
3834 (uniprop_decoder, uniprop_decoder_count): New variables.
3835 (uniprop_get_decoder, uniprop_encode_value_character)
3836 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3837 New functions.
3838 (uniprop_encoder, uniprop_encoder_count): New variables.
3839 (uniprop_get_encoder, uniprop_table)
3840 (Funicode_property_table_internal, Fget_unicode_property_internal)
3841 (Fput_unicode_property_internal): New functions.
3842 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3843 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 3844 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
3845 char-code-property-alist.
3846
640c8776 3847 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
3848 Vunicode_category_table.
3849
640c8776 3850 * font.c (font_range): Adjust for the change of
c805dec0
KH
3851 Vunicode_category_table.
3852
76b397fb
DN
38532011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3854
3855 * m/iris4d.h: Remove file, move contents ...
3856 * s/irix6-5.h: ... here.
3857
22b4128e
PE
38582011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3859
3860 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
3861 * alloc.c (mark_buffer):
3862 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3863 (clone_per_buffer_values): Don't assume that
22b4128e
PE
3864 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3865 This isn't true in general, and it's particularly not true
3866 if Emacs is configured with --with-wide-int.
3867 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3868 New macros, used in the buffer.c change.
3869
869795d6
JD
38702011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3871
3872 * xsettings.c: Use both GConf and GSettings if both are available.
3873 (store_config_changed_event): Add comment.
3874 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3875 (store_tool_bar_style_changed): New functions.
5e617bc2 3876 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
3877 (struct xsettings): Move font inside HAVE_XFT.
3878 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 3879 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 3880 Move inside HAVE_XFT.
640c8776 3881 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
3882 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3883 also.
3884 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 3885 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 3886 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
3887 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3888 (parse_settings): Move check for font inside HAVE_XFT.
3889 (read_settings, apply_xft_settings): Add comment.
3890 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3891 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3892 call store_font_name_changed.
3893 (xft_settings_event): Add comment.
3894 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3895 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3896 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3897 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3898 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
3899 (xsettings_get_system_font, xsettings_get_system_normal_font):
3900 Add comment.
869795d6 3901
d8ed26bd
PE
39022011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3903
3904 Random fixes. E.g., (random) never returned negative values.
3905 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3906 subseconds part to the entropy, as that's a bit more random.
3907 Prefer signed to unsigned, since the signedness doesn't matter and
3908 in general we prefer signed. When given a limit, use a
3909 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3910 latter isn't right if USE_2_TAGS_FOR_INTS.
3911 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3912 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3913
cabf1cac
SM
39142011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3915
3916 * textprop.c (text_property_stickiness):
3917 Obey Vtext_property_default_nonsticky.
3918 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3919 * w32fns.c (syms_of_w32fns):
3920 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3921
6e9b2be9
PE
39222011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3923
3924 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3925 This is more efficient than Ffile_directory_p and avoids a minor race.
3926
90186c68
LMI
39272011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3928
7c301272
LMI
3929 * buffer.c (Foverlay_put): Say what the return value is
3930 (bug#7835).
3931
c4f2d8d4
LMI
3932 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3933 is a directory before asking whether to use the file name
3934 (bug#7564).
ad637907
LMI
3935 (barf_or_query_if_file_exists): Make the "File is a directory"
3936 error be more correct.
c4f2d8d4 3937
90186c68
LMI
3938 * fns.c (Frequire): Remove the mention of the .gz files, since
3939 that's installation-specific, but keep the mention of
3940 `get-load-suffixes'.
3941
da64016e
PE
39422011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3943
3944 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3945 Report string overflow if the output is too long.
3946
7d47b580
JB
39472011-07-04 Juanma Barranquero <lekktu@gmail.com>
3948
a555cb87
JB
3949 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3950 (syms_of_gnutls): Remove duplicate DEFSYM for
3951 Qgnutls_bootprop_verify_hostname_error, an error for
3952 Qgnutls_bootprop_verify_error (which is no longer used).
3953
7d47b580
JB
3954 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3955 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3956 Also (re)move comments that are misplaced or no longer relevant.
3957
1e49bfab
LMI
39582011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3959
3960 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3961
1485f4c0
CY
39622011-07-03 Chong Yidong <cyd@stupidchicken.com>
3963
3964 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3965 and background color parameters if they have been changed.
3966
a9ab721e
LMI
39672011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3968
3969 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3970
cf7cff57
PE
39712011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3972
2e13213d
PE
3973 * xsettings.c (SYSTEM_FONT): Define only when used.
3974 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3975
cf7cff57
PE
3976 * keymap.c (access_keymap_1): Now static.
3977
7a8e04f7
CY
39782011-07-02 Chong Yidong <cyd@stupidchicken.com>
3979
3980 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3981 leave any prefix arg for the up event (Bug#1586).
3982
61352f62
LMI
39832011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3984
69bb1ef7
LMI
3985 * lread.c (syms_of_lread): Mention single symbols defined by
3986 `defvar' or `defconst' (bug#7154).
3987
61352f62 3988 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 3989 (Frequire): Mention get-load-suffixes.
61352f62 3990
28545e04
MR
39912011-07-02 Martin Rudalics <rudalics@gmx.at>
3992
3993 * window.h (window): Remove clone_number slot.
3994 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3995 Remove.
3996 (make_parent_window, make_window, saved_window)
3997 (Fset_window_configuration, save_window_save): Don't deal with
3998 clone numbers.
3999 * buffer.c (Qclone_number): Remove declaration.
4000 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4001
3349e122
SM
40022011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4003
4004 Add multiple inheritance to keymaps.
4005 * keymap.c (Fmake_composed_keymap): New function.
4006 (Fset_keymap_parent): Simplify.
4007 (fix_submap_inheritance): Remove.
4008 (access_keymap_1): New function extracted from access_keymap to handle
4009 embedded parents and handle lists of maps.
4010 (access_keymap): Use it.
4011 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4012 (Fcopy_keymap): Handle embedded parents.
4013 (Fcommand_remapping, define_as_prefix): Simplify.
4014 (Fkey_binding): Simplify.
4015 (syms_of_keymap): Move minibuffer-local-completion-map,
4016 minibuffer-local-filename-completion-map,
4017 minibuffer-local-must-match-map, and
4018 minibuffer-local-filename-must-match-map to Elisp.
4019 (syms_of_keymap): Defsubr make-composed-keymap.
4020 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4021 (parse_menu_item): Trivial simplification.
4022
3279eb87
GM
40232011-07-01 Glenn Morris <rgm@gnu.org>
4024
4025 * Makefile.in (SETTINGS_LIBS): Fix typo.
4026
4550efdf
KI
40272011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4028
4029 * coding.c (Fencode_coding_string): Record the last coding system
4030 used, as the function doc string says (bug#8738).
4031
0949d2b6
JD
40322011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4033
4034 * xsettings.c (store_monospaced_changed): Take new font as arg and
4035 check for change against current_mono_font.
4036 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4037 (emacs_settings_constructor, emacs_settings_get_property)
4038 (emacs_settings_set_property, emacs_settings_class_init)
4039 (emacs_settings_init, gsettings_obj): Remove.
4040 (something_changedCB): New function for HAVE_GSETTINGS.
4041 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4042 with value as argument.
4043 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4044 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 4045 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
4046 "changed".
4047
4048 * xgselect.c: Add defined (HAVE_GSETTINGS).
4049 (xgselect_initialize): Ditto.
4050
4051 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4052 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4053 xg_select.
4054
bbc6b304
PE
40552011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4056
4057 * eval.c (struct backtrace): Simplify and port the data structure.
4058 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4059 signed bit field, as this assumption is not portable and it makes
4060 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4061 "char debug_on_exit : 1" as this is not portable either; instead,
4062 use the portable "unsigned int debug_on_exit : 1". Remove unused
4063 member evalargs. Remove obsolete comments about cc bombing out.
4064
9851bfc5
JD
40652011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4066
51bb811f 4067 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
4068 Let HAVE_GSETTINGS override HAVE_GCONF.
4069 (store_monospaced_changed): New function.
4070 (EMACS_SETTINGS): A new type derived from GObject to handle
4071 GSettings notifications.
4072 (emacs_settings_constructor, emacs_settings_get_property)
4073 (emacs_settings_set_property, emacs_settings_class_init):
4074 New functions.
4075 (gsettings_client, gsettings_obj): New variables.
4076 (GSETTINGS_SCHEMA): New define.
4077 (something_changedCB): Call store_monospaced_changed.
4078 (init_gsettings): New function.
4079 (xsettings_initialize): Call init_gsettings.
4080 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4081 to NULL.
4082
640c8776 4083 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
4084 GCONF_CFLAGS/LIBS.
4085
5386012d
MR
40862011-06-29 Martin Rudalics <rudalics@gmx.at>
4087
4088 * window.c (resize_root_window, grow_mini_window)
4089 (shrink_mini_window): Rename Qresize_root_window to
4090 Qwindow_resize_root_window and Qresize_root_window_vertically to
4091 Qwindow_resize_root_window_vertically.
4092
f13e0b08
PE
40932011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4094
4095 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4096
94515237
JB
40972011-06-27 Juanma Barranquero <lekktu@gmail.com>
4098
4099 * makefile.w32-in: Redesign dependencies so they reflect more
4100 clearly which files are directly included by each source file,
4101 and not through other includes.
4102
e43b6e43
MR
41032011-06-27 Martin Rudalics <rudalics@gmx.at>
4104
4105 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4106 (sort_overlays, overlay_strings): When an overlay's clone number
4107 matches the window's clone number process the overlay even if
4108 the overlay's window property doesn't match the current window.
4109
d68443dc
MR
4110 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4111 (Fwindow_hchild): Rename to Fwindow_left_child.
4112 (Fwindow_next): Rename to Fwindow_next_sibling.
4113 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
4114 (resize_window_check): Rename to window_resize_check.
4115 (resize_window_apply): Rename to window_resize_apply.
4116 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4117 (Fdelete_other_windows_internal, resize_frame_windows)
4118 (Fsplit_window_internal, Fdelete_window_internal)
4119 (grow_mini_window, shrink_mini_window)
4120 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 4121
c7e73be5
JD
41222011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4123
4124 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4125 (emacs_fixed_set_min_size): Remove.
4126 (emacs_fixed_new): Take frame as argument.
4127
4128 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4129 (_EmacsFixedPrivate): Remove minwidth/height.
4130 Add struct frame *f.
4131 (emacs_fixed_init): Initialize priv->f.
4132 (get_parent_class, emacs_fixed_set_min_size): Remove.
4133 (emacs_fixed_new): Set priv->f to argument.
4134 (emacs_fixed_get_preferred_width)
4135 (emacs_fixed_get_preferred_height): Use min_width/height from
4136 frames size_hint to set minimum and natural (Bug#8919).
4137 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4138 and use min_width/height from frames size_hint to set
4139 min_width/height (Bug#8919).
4140
4141 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
4142 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4143 Fix indentation.
c7e73be5 4144
cf99dcf8
EZ
41452011-06-26 Eli Zaretskii <eliz@gnu.org>
4146
4147 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4148 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4149 called at ZV.
4150
029529ac
CY
41512011-06-26 Chong Yidong <cyd@stupidchicken.com>
4152
4153 * process.c (wait_reading_process_output): Bypass select if
4154 waiting for a cell while ignoring keyboard input, and input is
4155 pending. Suggested by Jan Djärv (Bug#8869).
4156
7a7ef429
PE
41572011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4158
4159 Use gnulib's dup2 module instead of rolling our own.
4160 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4161
11fdef7d 41622011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
4163
4164 * dispnew.c (scrolling_window): Before scrolling, turn off a
4165 mouse-highlight in the window being scrolled.
4166
cd3520a4
JB
41672011-06-24 Juanma Barranquero <lekktu@gmail.com>
4168
4169 Move DEFSYM to lisp.h and use everywhere.
4170
4171 * character.h (DEFSYM): Move declaration...
4172 * lisp.h (DEFSYM): ...here.
4173
4174 * gnutls.c:
4175 * minibuf.c:
4176 * w32menu.c:
4177 * w32proc.c:
4178 * w32select.c: Don't include character.h.
4179
4180 * alloc.c (syms_of_alloc):
4181 * buffer.c (syms_of_buffer):
4182 * bytecode.c (syms_of_bytecode):
4183 * callint.c (syms_of_callint):
4184 * casefiddle.c (syms_of_casefiddle):
4185 * casetab.c (init_casetab_once):
4186 * category.c (init_category_once, syms_of_category):
4187 * ccl.c (syms_of_ccl):
4188 * cmds.c (syms_of_cmds):
4189 * composite.c (syms_of_composite):
4190 * dbusbind.c (syms_of_dbusbind):
4191 * dired.c (syms_of_dired):
4192 * dispnew.c (syms_of_display):
4193 * doc.c (syms_of_doc):
4194 * editfns.c (syms_of_editfns):
4195 * emacs.c (syms_of_emacs):
4196 * eval.c (syms_of_eval):
4197 * fileio.c (syms_of_fileio):
4198 * fns.c (syms_of_fns):
4199 * frame.c (syms_of_frame):
4200 * fringe.c (syms_of_fringe):
4201 * insdel.c (syms_of_insdel):
4202 * keymap.c (syms_of_keymap):
4203 * lread.c (init_obarray, syms_of_lread):
4204 * macros.c (syms_of_macros):
4205 * msdos.c (syms_of_msdos):
4206 * print.c (syms_of_print):
4207 * process.c (syms_of_process):
4208 * search.c (syms_of_search):
4209 * sound.c (syms_of_sound):
4210 * syntax.c (init_syntax_once, syms_of_syntax):
4211 * terminal.c (syms_of_terminal):
4212 * textprop.c (syms_of_textprop):
4213 * undo.c (syms_of_undo):
4214 * w32.c (globals_of_w32):
4215 * window.c (syms_of_window):
4216 * xdisp.c (syms_of_xdisp):
4217 * xfaces.c (syms_of_xfaces):
4218 * xfns.c (syms_of_xfns):
4219 * xmenu.c (syms_of_xmenu):
4220 * xsettings.c (syms_of_xsettings):
4221 * xterm.c (syms_of_xterm): Use DEFSYM.
4222
4228cf16
TZ
42232011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4224
cd3520a4 4225 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 4226
7fcccf1e
PE
42272011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4228
7efb4e0e
PE
4229 Integer and buffer overflow fixes (Bug#8873).
4230
ff5844ad
PE
4231 * print.c (printchar, strout): Check for string overflow.
4232 (PRINTPREPARE, printchar, strout):
4233 Don't set size unless allocation succeeds.
4234
90532f02
PE
4235 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4236 for sizes. Check for string overflow more accurately.
4237 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4238
6d84508d
PE
4239 * macros.c: Integer and buffer overflow fixes.
4240 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4241 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4242 Use ptrdiff_t, not int, for sizes.
4243 Don't increment bufsize until after realloc succeeds.
4244 Check for size-calculation overflow.
4245 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4246
437b2cb4
PE
4247 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4248
8b9ac8b4
PE
4249 * lread.c: Integer overflow fixes.
4250 (read_integer): Radix is now EMACS_INT, not int,
4251 to improve quality of diagnostics for out-of-range radices.
4252 Calculate buffer size correctly for out-of-range radices.
4253 (read1): Check for integer overflow in radices, and in
4254 read-circle numbers.
82cb60d3
PE
4255 (read_escape): Avoid int overflow.
4256 (Fload, openp, read_buffer_size, read1)
4257 (substitute_object_recurse, read_vector, read_list, map_obarray):
4258 Use ptrdiff_t, not int, for sizes.
4259 (read1): Use EMACS_INT, not int, for sizes.
20270765 4260 Check for size overflow.
8b9ac8b4 4261
7fcccf1e
PE
4262 * image.c (cache_image): Check for size arithmetic overflow.
4263
bfbbd7e7
PE
4264 * lread.c: Integer overflow issues.
4265 (saved_doc_string_size, saved_doc_string_length)
4266 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4267 Now ptrdiff_t, not int.
4268 (read1): Don't assume doc string length fits in int. Check for
4269 out-of-range doc string lengths.
4270 (read_list): Don't assume file position fits in int.
39019e54 4271 (read_escape): Check for hex character overflow.
bfbbd7e7 4272
4e323265
LL
42732011-06-22 Leo Liu <sdl.web@gmail.com>
4274
4275 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4276 Move to minibuffer.el.
4277
85fece3e
PE
42782011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4279
20b84ce9 4280 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
4281 The following patches are for when GLYPH_DEBUG && !XASSERT.
4282 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4283 * dispnew.c (flush_stdout):
4284 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4285 Mark as externally visible.
4286 * dispnew.c (check_window_matrix_pointers): Now static.
4287 * dispnew.c (window_to_frame_vpos):
4288 * xfns.c (unwind_create_frame):
4289 * xterm.c (x_check_font): Remove unused local.
4290 * scroll.c (CHECK_BOUNDS):
4291 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4292 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4293 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4294 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4295 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4296 Now static.
4297 (debug_method_add): Use va_list and vsprintf rather than relying
4298 on undefined behavior with wrong number of arguments.
4299 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4300 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4301 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4302 since we're not interested in debugging glyphs with old libraries.
4303 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4304 GCC 4.6.0's static checking.
4305
0766b489
PE
43062011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4307
31fd4b32
PE
4308 Integer overflow and signedness fixes (Bug#8873).
4309 A few related buffer overrun fixes, too.
4310
b79e8648
PE
4311 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4312
0766b489
PE
4313 * dispextern.h (struct face.stipple):
4314 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4315 (x_bitmap_mask, x_allocate_bitmap_record)
4316 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4317 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4318 (x_create_bitmap_from_xpm_data):
4319 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4320 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4321 (.bitmaps_last):
4322 * xfaces.c (load_pixmap):
4323 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4324 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4325 (.bitmaps_last, struct x_output.icon_bitmap):
4326 Use ptrdiff_t, not int, for bitmap indexes.
4327 (x_allocate_bitmap_record): Check for size overflow.
4328 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4329
b081724f
PE
4330 Use ptrdiff_t, not int, for overlay counts.
4331 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4332 * editfns.c (overlays_around, get_pos_property):
4333 * textprop.c (get_char_property_and_overlay):
4334 * xdisp.c (next_overlay_change, note_mouse_highlight):
4335 * xfaces.c (face_at_buffer_position):
21514da7
PE
4336 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4337 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4338 (Fnext_overlay_change, Fprevious_overlay_change)
4339 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 4340 Use ptrdiff_t, not int, for sizes.
21514da7 4341 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 4342
3de73e5e
PE
4343 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4344
2606c57b
PE
4345 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4346 (x_session_initialize): Do not assume string length fits in int.
4347
aaafe47a
PE
4348 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4349 This is unlikely, but can occur if DPI is outlandish.
4350
2674ddc8 4351 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
4352 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4353
28154962
PE
4354 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4355 * xrdb.c (magic_file_p, search_magic_path):
4356 Omit last arg SUFFIX; it was always 0. All callers changed.
4357 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4358
7de51af5
PE
4359 * xfont.c (xfont_match): Avoid need for strlen.
4360
25ed6cc3
PE
4361 * xfns.c: Don't assume strlen fits in int.
4362 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4363
4eab31dd
PE
4364 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4365 not unsigned long, as we prefer signed integers. All callers changed.
4366 Detect integer overflow in repeat count.
4367 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 4368 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 4369
171e2a58
PE
4370 * termcap.c: Don't assume sizes fit in int and never overflow.
4371 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4372 (gobble_line): Check for size-calculation overflow.
4373
ad39faca 4374 * minibuf.c (Fread_buffer):
6e5bb2dc 4375 * lread.c (intern, intern_c_string):
74ca2eb3
PE
4376 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4377 Don't assume string length fits in int.
4378
52c61c22 4379 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
4380 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4381
b5b8c9e5
PE
4382 * font.c: Don't assume string length fits in int.
4383 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4384 Use ptrdiff_t, not int.
ccd6111c
PE
4385 (font_intern_prop): Don't assume string length fits in int.
4386 Don't assume integer property fits in fixnum.
4387 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 4388
882f0d81 4389 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 4390 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
4391 Reformulate so as not to need the command string.
4392 Invoke gzip -cd rather than gunzip, as it's more portable.
4393 (lock_info_type, lock_file_1, lock_file):
4394 Don't assume pid_t and time_t fit in unsigned long.
4395 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4396 (current_lock_owner): Prefer signed type for sizes.
4397 Use memcpy, not strncpy, where memcpy is what is really wanted.
4398 Don't assume (via atoi) that time_t and pid_t fit in int.
4399 Check for time_t and/or pid_t out of range, e.g., via a network share.
4400 Don't alloca where an auto var works fine.
4401
93f4cf88
PE
4402 * fileio.c: Fix some integer overflow issues.
4403 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4404 Don't assume string length fits in int.
4405 (directory_file_name): Don't assume string length fits in long.
4406 (make_temp_name): Don't assume pid fits in int, or that its print
4407 length is less than 20.
4408
f3e92b69
PE
4409 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4410
1bfdaf10
PE
4411 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4412
35016e9a
PE
4413 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4414
3d1e65a1
PE
4415 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4416 We prefer signed integers, even for size calculations.
4417
0b963a93
PE
4418 * emacs.c: Don't assume string length fits in 'int'.
4419 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4420 (main): Don't invoke strlen when not needed.
4421
573f4b54
PE
4422 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4423 (XD_DEBUG_MESSAGE): Don't waste a byte.
4424
989f33ba
PE
4425 * callproc.c (getenv_internal_1, getenv_internal)
4426 (Fgetenv_internal):
965d34eb
PE
4427 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4428
e4d29b33
PE
4429 * lread.c (invalid_syntax): Omit length argument.
4430 All uses changed. This doesn't fix a bug, but it simplifies the
4431 code away from its former Hollerith-constant appearance, and it's
4432 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 4433 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 4434
eb49b136
PE
4435 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4436 This didn't break anything, but it didn't help either.
4437 It's confusing to put a bogus integer in a place where the actual
4438 value does not matter.
9f62aeb1 4439 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 4440 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 4441
15375a22
PE
4442 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4443 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4444 implementation.
b61cc01c
PE
4445 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4446 We prefer signed types, and the value cannot exceed the EMACS_INT
4447 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
4448 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4449 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4450 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 4451
53b2623d
PE
4452 * indent.c (sane_tab_width): New function.
4453 (current_column, scan_for_column, Findent_to, position_indentation)
4454 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 4455 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 4456
51cab52b 4457 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 4458
f2ed8a70
PE
4459 * lisp.h (lint_assume): New macro.
4460 * composite.c (composition_gstring_put_cache):
4461 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4462
abe80cc6
PE
4463 * editfns.c, insdel.c:
4464 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 4465
b02c740e
PE
4466 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4467
ebc96716
PE
4468 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4469
b4e50fa0 4470 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 4471 Use much-faster test for byte-length change.
311d5d7c 4472 Don't assume string byte-length fits in 'int'.
a4cf38e4 4473 Check that character arg fits in 'int'.
85461888 4474 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 4475
c0c1ee9f
PE
4476 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4477
a498d7f4
PE
4478 * fns.c (concat): Catch string overflow earlier.
4479 Do not rely on integer wraparound.
4480
51cab52b
PE
4481 * dispextern.h (struct it.overlay_strings_charpos)
4482 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
4483 * xdisp.c (forward_to_next_line_start)
4484 (back_to_previous_visible_line_start)
4485 (reseat_at_next_visible_line_start, next_element_from_buffer):
4486 Don't arbitrarily truncate the value of 'selective' to int.
4487
76031fad
PE
4488 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4489
5eb55db9
PE
4490 * composite.c: Don't truncate sizes to 'int'.
4491 (composition_gstring_p, composition_reseat_it)
4492 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
4493 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4494 not EMACS_UINT, for indexes.
5eb55db9 4495
0703a717
PE
4496 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4497
d6202519
PE
4498 * buffer.c: Include <verify.h>.
4499 (struct sortvec.priority, struct sortstr.priority):
8961a454 4500 Now EMACS_INT, not int.
c20998a7 4501 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
4502 (struct sortstr.size, record_overlay_string)
4503 (struct sortstrlist.size, struct sortlist.used):
4504 Don't truncate size to int.
4505 (record_overlay_string): Check for size-calculation overflow.
d6202519 4506 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 4507
d5a19415
JM
45082011-06-22 Jim Meyering <meyering@redhat.com>
4509
029529ac 4510 Don't leak an XBM-image-sized buffer
d5a19415
JM
4511 * image.c (xbm_load): Free the image buffer after using it.
4512
a9041e6c
PE
45132011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4514
4515 Port to Sun C.
4516 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4517 that Sun C diagnosed.
4518 * fns.c (secure_hash): Fix pointer signedness issue.
4519 * intervals.c (static_offset_intervals): New function.
4520 (offset_intervals): Use it.
4521
7f3f739f
LL
45222011-06-21 Leo Liu <sdl.web@gmail.com>
4523
4524 * deps.mk (fns.o):
4525 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4526 sha512.h.
4527
4528 * fns.c (secure_hash): Rename from crypto_hash_function and change
4529 the first arg to accept symbols.
5b66d427 4530 (Fsecure_hash): New primitive.
7f3f739f
LL
4531 (syms_of_fns): New symbols.
4532
76147d94
DD
45332011-06-20 Deniz Dogan <deniz@dogan.se>
4534
4535 * process.c (Fset_process_buffer): Clarify return value in
4536 docstring.
4537
7d7d0045
CY
45382011-06-18 Chong Yidong <cyd@stupidchicken.com>
4539
4540 * dispnew.c (add_window_display_history): Use BVAR.
4541
4542 * xdisp.c (debug_method_add): Use BVAR.
4543 (check_window_end, dump_glyph_matrix, dump_glyph)
4544 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4545
4546 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4547 Likewise.
4548
4549 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4550 check till after the cache is created in init_frame_faces.
4551
ff2bc410
SM
45522011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4553
4554 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4555
28177add
PE
45562011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4557
dd3482fe
PE
4558 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4559 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4560 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4561
393d71f3 4562 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
4563 * fileio.c (Finsert_file_contents):
4564 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4565 Remove the old (too-loose) buffer overflow checks.
4566 They weren't needed, since make_gap checks for buffer overflow.
4567 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4568 The old code merely checked for Emacs fixnum overflow, and relied
4569 on undefined (wraparound) behavior. The new code avoids undefined
4570 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4571
2e6813b0 4572 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
4573 Tune. Don't use wider integers than needed. Don't use alloca.
4574 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 4575
599a9e4f
PE
4576 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4577
99561444
PE
4578 * insdel.c, lisp.h (buffer_overflow): New function.
4579 (insert_from_buffer_1, replace_range, replace_range_2):
4580 * insdel.c (make_gap_larger):
4581 * editfns.c (Finsert_char):
4582 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4583
28177add
PE
4584 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4585
e69dafad
PE
45862011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4587
4baa020d 4588 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 4589
b1c46f02
PE
4590 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4591 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4592
e69dafad
PE
4593 * fileio.c: Don't assume EMACS_INT fits in off_t.
4594 (emacs_lseek): New static function.
4595 (Finsert_file_contents, Fwrite_region): Use it.
4596 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4597
566684ea
PE
4598 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4599
e6966cd6
PE
4600 * fns.c: Don't overflow int when computing a list length.
4601 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4602 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4603 truncation on 64-bit hosts. Check for QUIT every
4604 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4605 faster and is responsive enough.
4606 (Flength): Report an error instead of overflowing an integer.
4607 (Fsafe_length): Return a float if the value is not representable
4608 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 4609 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 4610 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 4611
dd0b0efb
PE
4612 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4613 (header_size, word_size): New constants.
4614 (allocate_vectorlike): Don't check size overflow here.
4615 (allocate_vector): Check it here instead, since this is the only
4616 caller of allocate_vectorlike that could cause overflow.
4617 Check that the new vector's length is representable as a fixnum.
4618
86fe5cfe
PE
4619 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4620 The previous code was bogus. For example, next_almost_prime (32)
4621 returned 39, which is undesirable as it is a multiple of 3; and
4622 next_almost_prime (24) returned 25, which is a multiple of 5 so
4623 why was the code bothering to check for multiples of 7?
4624
80e88859
PE
4625 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4626
4a2f0ad6
PE
4627 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4628
f66c7cf8
PE
4629 Variadic C functions now count arguments with ptrdiff_t.
4630 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4631 Back then I didn't know that the Emacs coding style prefers signed int.
4632 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
4633 were being counted with int, which may truncate counts on 64-bit
4634 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
4635 * lisp.h (struct Lisp_Subr.function.aMANY)
4636 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4637 Arg counts are now ptrdiff_t, not size_t.
4638 All variadic functions and their callers changed accordingly.
4639 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4640 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4641 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4642 * callint.c (Fcall_interactively): Check arg count for overflow,
4643 to avoid potential buffer overrun. Use signed char, not 'int',
4644 for 'varies' array, so that we needn't bother to check its size
4645 calculation for overflow.
4646 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4647 * eval.c (apply_lambda):
4648 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4649 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4650 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4651
a1759b76
PE
4652 * callint.c (Fcall_interactively): Don't use index var as event count.
4653
d96be9fc
PE
4654 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4655 * mem-limits.h (SIZE): Remove; no longer used.
4656
a690a978 4657 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 4658
578c21e6
PE
4659 Remove unnecessary casts.
4660 * xterm.c (x_term_init):
4661 * xfns.c (x_set_border_pixel):
4662 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4663 These aren't needed now that we assume ANSI C.
4664
96f53c6c
PE
4665 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4666 It's more likely to cause problems (due to unsigned overflow)
4667 than to cure them.
4668
83c77d31
PE
4669 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4670
ee2079f1
PE
4671 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4672
6da65536
PE
4673 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4674
7147c4a4
PE
4675 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4676
193e32d9
PE
4677 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4678
e5533da6
PE
4679 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4680
9910e595
PE
4681 GLYPH_CODE_FACE returns EMACS_INT, not int.
4682 * dispextern.h (merge_faces):
4683 * xfaces.c (merge_faces):
01103c44
PE
4684 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4685 Don't assume EMACS_INT fits in int.
9910e595 4686
2638320e
PE
4687 * character.h (CHAR_VALID_P): Remove unused parameter.
4688 * fontset.c, lisp.h, xdisp.c: All uses changed.
4689
045eb8d9
PE
4690 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4691
c1f134b5
PE
4692 * fns.c (concat): Minor tuning based on overflow analysis.
4693 This doesn't fix any bugs. Use int to hold character, instead
4694 of constantly refetching from Emacs object. Use XFASTINT, not
4695 XINT, for value known to be a character. Don't bother comparing
4696 a single byte to 0400, as it's always less.
4697
395fcb93 4698 * floatfns.c (Fexpt):
327eeec8
PE
4699 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4700
abbd3d23
PE
4701 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4702 for characters.
4703
684a03ef
PE
4704 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4705
0fed43f3
PE
4706 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4707 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4708 incorrectly succeed when S was a string, because 4294967386 was
4709 truncated before it was used.
4710
8fd02eb7
PE
4711 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4712 Otherwise, an out-of-range integer could cause undefined behavior
4713 on a 64-bit host.
4714
f8c86b69
PE
4715 * composite.c: Use int, not EMACS_INT, for characters.
4716 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4717 EMACS_INT, for values that are known to be in character range.
4718 This doesn't fix any bugs but is the usual style inside Emacs and
4719 may generate better code on 32-bit machines.
4720
34206dd2
PE
4721 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4722 This is for reasons similar to the recent CHAR_STRING fix.
4723 * charset.c (Fencode_char): Check that character arg is actually
4724 a character. Pass an int to ENCODE_CHAR.
4725 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4726 wider than 'int', as a compile-time check to prevent future regressions
4727 in this area.
4728
c5958d4c 4729 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
4730
4731 Make sure a 64-bit char is never passed to CHAR_STRING.
4732 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4733 by silently ignoring the top 32 bits, allowing some values
4734 that were far too large to be valid characters.
4735 * character.h: Include <verify.h>.
4736 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4737 arguments are no wider than unsigned, as a compile-time check
4738 to prevent future regressions in this area.
4739 * data.c (Faset):
01103c44 4740 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
4741 (Fsubst_char_in_region):
4742 * fns.c (concat):
4743 * xdisp.c (decode_mode_spec_coding):
4744 Adjust to CHAR_STRING's new requirement.
4745 * editfns.c (Finsert_char, Fsubst_char_in_region):
4746 * fns.c (concat): Check that character args are actually
4747 characters. Without this test, these functions did the wrong
4748 thing with wildly out-of-range values on 64-bit hosts.
4749
d37ca623
PE
4750 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4751 These casts should not be needed on 32-bit hosts, either.
4752 * keyboard.c (read_char):
4753 * lread.c (Fload): Remove casts to unsigned.
4754
ea204efb
PE
4755 * lisp.h (UNSIGNED_CMP): New macro.
4756 This fixes comparison bugs on 64-bit hosts.
4757 (ASCII_CHAR_P): Use it.
4758 * casefiddle.c (casify_object):
01103c44 4759 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
4760 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4761 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4762 * dispextern.h (FACE_FROM_ID):
4763 * keyboard.c (read_char): Use UNSIGNED_CMP.
4764
41cb286c
PE
4765 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4766 not to EMACS_INT, to avoid GCC warning.
4767
4a1b9832
PE
4768 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4769
55daad71
PE
4770 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4771 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4772 isn't needed on 32-bit machines.
8f95c75c 4773
01103c44
PE
4774 * buffer.c (Fgenerate_new_buffer_name):
4775 Use EMACS_INT for count, not int.
0ceccced 4776 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
4777
4778 * data.c (Qcompiled_function): Now static.
4779
c6f072e7
PE
4780 * window.c (window_body_lines): Now static.
4781
20ce5912
PE
4782 * image.c (gif_load): Rename local to avoid shadowing.
4783
9c4c5f81
PE
4784 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4785 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4786 * alloc.c (make_save_value): Integer argument is now of type
4787 ptrdiff_t, not int.
4788 (mark_object): Use ptrdiff_t, not int.
4789 * lisp.h (pD): New macro.
4790 * print.c (print_object): Use it.
4791
c0c5c8ae
PE
4792 * alloc.c: Use EMACS_INT, not int, to count objects.
4793 (total_conses, total_markers, total_symbols, total_vector_size)
4794 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
4795 (total_free_floats, total_floats, total_free_intervals)
4796 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
4797 Now EMACS_INT, not int. All uses changed.
4798 (Fgarbage_collect): Compute overall total using a double, so that
4799 integer overflow is less likely to be a problem. Check for overflow
4800 when converting back to an integer.
5a25e253
PE
4801 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4802 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4803 These were 'int' variables that could overflow on 64-bit hosts;
4804 they were never used, so remove them instead of repairing them.
211a0b2a 4805 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
4806 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4807 Previously, this ceilinged at INT_MAX, but that doesn't work on
4808 64-bit machines.
e46bb31a 4809 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 4810
c78baabf 4811 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 4812 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
4813 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4814 when a (possibly-narrower) signed value would do just as well.
4815 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 4816
c9d624c6
PE
4817 * alloc.c: Catch some string size overflows that we were missing.
4818 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4819 for convenience in STRING_BYTES_MAX.
4820 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4821 The definition here is exact; the one in lisp.h was approximate.
4822 (allocate_string_data): Check for string overflow. This catches
4823 some instances we weren't catching before. Also, it catches
4824 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4825 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4826 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 4827
c9d624c6
PE
4828 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4829 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 4830 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 4831
353032ce
PE
4832 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4833
2bccce07
PE
4834 * alloc.c (Fmake_string): Check for out-of-range init.
4835
0ac30604
SM
48362011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4837
4838 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4839
c195f2de
JD
48402011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4841
4842 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4843 xg_get_default_scrollbar_width.
4844
4845 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4846 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4847 (style_changed_cb): Call update_theme_scrollbar_width and call
4848 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4849 all frames (Bug#8505).
4850 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4851 Call gtk_window_set_resizable if HAVE_GTK3.
4852 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4853 and height if HAVE_GTK3 (Bug#8505).
4854 (scroll_bar_width_for_theme): New variable.
4855 (update_theme_scrollbar_width): New function.
4856 (xg_get_default_scrollbar_width): Move code to
4857 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4858 (xg_initialize): Call update_theme_scrollbar_width.
4859
4860 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4861
4862 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4863
e10ac9f1
MR
48642011-06-12 Martin Rudalics <rudalics@gmx.at>
4865
4866 * frame.c (make_frame): Call other_buffer_safely instead of
4867 other_buffer.
4868
4869 * window.c (temp_output_buffer_show): Call display_buffer with
4870 second argument Vtemp_buffer_show_specifiers and reset latter
4871 immediately after the call.
4872 (Vtemp_buffer_show_specifiers): New variable.
4873 (auto_window_vscroll_p, next_screen_context_lines)
4874 (Vscroll_preserve_screen_position): Remove leading asterisks from
4875 doc-strings.
4876
2d3c217e 48772011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 4878
7b7f97e8 4879 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
4880 * buffer.c (Qclone_number): Remove for now, as it's unused.
4881 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4882 (record_buffer): Remove unused local.
4883 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4884 (set_frame_buffer_list): Remove; unused.
4885 * frame.h (other_visible_frames): Remove decl.
4886 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4887 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4888 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4889 if HAVE_GPM.
4890 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4891 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4892 Define only if HAVE_GPM.
4893 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4894 (update_hints_inhibit): Remove; never set. All uses removed.
4895 * widgetprv.h (emacsFrameClassRec): Remove decl.
4896 * window.c (delete_deletable_window): Now returns void, since it
4897 wasn't returning anything.
4898 (compare_window_configurations): Remove unused locals.
4899 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4900 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
4901 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4902 the same widths as pointers. This follows up on the 2011-05-06 patch.
4903 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4904 * xterm.h: Likewise.
4905 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4906
1384b89e
JB
49072011-06-12 Juanma Barranquero <lekktu@gmail.com>
4908
4909 * makefile.w32-in: Update dependencies.
4910 (LISP_H): Add lib/intprops.h.
4911
1100a63c
CY
49122011-06-11 Chong Yidong <cyd@stupidchicken.com>
4913
4914 * image.c (gif_load): Add animation frame delay to the metadata.
4915 (syms_of_image): Use DEFSYM. New symbol `delay'.
4916
6198ccd0
MR
49172011-06-11 Martin Rudalics <rudalics@gmx.at>
4918
4919 * window.c (delete_deletable_window): Re-add.
4920 (Fset_window_configuration): Rewrite to handle dead buffers and
4921 consequently deletable windows.
4922 (window_tree, Fwindow_tree): Remove. Supply functionality in
4923 window.el.
4924 (compare_window_configurations): Simplify code.
4925
b6e3633c
AS
49262011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4927
1ab0dee5
AS
4928 * image.c (imagemagick_load_image): Fix type mismatch.
4929 (Fimagemagick_types): Likewise.
4930
b6e3633c
AS
4931 * window.h (replace_buffer_in_windows): Declare.
4932
9397e56f
MR
49332011-06-11 Martin Rudalics <rudalics@gmx.at>
4934
4935 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4936 Qclone_number. Remove external declaration of Qdelete_window.
4937 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4938 code.
640c8776
SM
4939 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4940 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
4941 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4942 buffer list implementation.
4943 (other_buffer_safely): New function.
4944 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4945 calls to replace_buffer_in_windows and
4946 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4947 if allowed.
4948 (record_buffer): Inhibit quitting and rewrite using quittable
4949 functions. Run Qbuffer_list_update_hook if allowed.
4950 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
4951 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4952 Move switch-to-buffer to window.el.
9397e56f
MR
4953 (bury-buffer): Move to window.el.
4954 (Vbuffer_list_update_hook): New variable.
4955
4956 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4957 section.
4958
4959 * window.h (resize_frame_windows): Move up in code.
4960 (Fwindow_frame): Remove EXFUN.
4961 (replace_buffer_in_all_windows): Remove prototype.
4962 (replace_buffer_in_windows_safely): Add prototype.
4963
4964 * window.c: Declare Qdelete_window static again. Move down
4965 declaration of select_count.
4966 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4967 (Fother_window): Move to window.el.
4968 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4969 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4970 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4971 window.el.
4972 (replace_buffer_in_windows): Implement by calling
4973 Qreplace_buffer_in_windows.
4974 (replace_buffer_in_all_windows): Remove with some functionality
4975 moved into replace_buffer_in_windows_safely.
4976 (replace_buffer_in_windows_safely): New function.
4977 (select_window_norecord, select_frame_norecord): Move in front
4978 of run_window_configuration_change_hook. Remove now obsolete
4979 declarations.
640c8776
SM
4980 (Fset_window_buffer): Rewrite doc-string.
4981 Call Qrecord_window_buffer.
9397e56f
MR
4982 (keys_of_window): Move binding for other-window to window.el.
4983
b50691aa
CY
49842011-06-11 Chong Yidong <cyd@stupidchicken.com>
4985
4986 * dispextern.h (struct image): Replace data member, whose int_val
4987 and ptr_val fields were not used by anything, with a single
4988 lisp_val object.
4989
4990 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4991 (gif_clear_image, gif_load, imagemagick_load_image)
4992 (gs_clear_image, gs_load): Callers changed.
4993
3f754b86
PE
49942011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4995
cca69397
PE
4996 * buffer.h: Include <time.h>, for time_t.
4997 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4998
109e28d0
PE
4999 Fix minor problems found by static checking.
5000
60737f02
PE
5001 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5002
4b66faf3
PE
5003 Make identifiers static if they are not used in other modules.
5004 * data.c (Qcompiled_function, Qframe, Qvector):
5005 * image.c (QimageMagick, Qsvg):
5006 * minibuf.c (Qmetadata):
5007 * window.c (resize_window_check, resize_root_window): Now static.
5008 * window.h (resize_window_check, resize_root_window): Remove decls.
5009
109e28d0
PE
5010 * window.c (window_deletion_count, delete_deletable_window):
5011 Remove; unused.
46a4ce9e
PE
5012 (window_body_lines): Now static.
5013 (Fdelete_other_windows_internal): Mark vars as initialized.
5014 Make sure 'resize_failed' is initialized.
5015 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5016 (resize_window_apply): Remove unused local.
5017 * window.h (delete_deletable_window): Remove decl.
5018
109e28d0 5019 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
5020 (imagemagick_load_image): Fix pointer signedness problem by changing
5021 last arg from unsigned char * to char *. All uses changed.
5022 Also, fix a local for similar reasons.
5023 Remove unused locals. Remove locals to avoid shadowing.
5024 (fn_rsvg_handle_free): Remove; unused.
5025 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 5026 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 5027
3f754b86
PE
5028 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5029
2547adb1
CY
50302011-06-10 Chong Yidong <cyd@stupidchicken.com>
5031
5032 * image.c (gif_load): Fix omitted cast error introduced by
5033 2011-06-06 change.
5034
2c8e37d4
MR
50352011-06-10 Martin Rudalics <rudalics@gmx.at>
5036
5037 * window.h (resize_proportionally, orig_total_lines)
5038 (orig_top_line): Remove from window structure.
5039 (set_window_height, set_window_width, change_window_heights)
5040 (Fdelete_window): Remove prototypes.
5041 (resize_frame_windows): Remove duplicate declaration.
5042
440a42e3
EZ
50432011-06-10 Eli Zaretskii <eliz@gnu.org>
5044
5045 * window.h (resize_frame_windows, resize_window_check)
5046 (delete_deletable_window, resize_root_window)
5047 (resize_frame_windows): Declare prototypes.
5048
5049 * window.c (resize_window_apply): Make definition be "static" to
5050 match the prototype.
5051
562dd5e9
MR
50522011-06-10 Martin Rudalics <rudalics@gmx.at>
5053
5054 * window.c: Remove declarations of Qwindow_size_fixed,
5055 window_min_size_1, window_min_size_2, window_min_size,
5056 size_window, window_fixed_size_p, enlarge_window, delete_window.
5057 Remove static from declaration of Qdelete_window, it's
5058 temporarily needed by Fbury_buffer.
5059 (replace_window): Don't assign orig_top_line and
5060 orig_total_lines.
5061 (Fdelete_window, delete_window): Remove. Window deletion is
5062 handled by window.el.
640c8776
SM
5063 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5064 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
5065 (Fdelete_other_windows): Remove. Deleting other windows is
5066 handled by window.el.
5067 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5068 handled in window.el.
5069 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5070 Window minimum sizes are handled in window.el.
5071 (shrink_windows, size_window, set_window_height)
5072 (set_window_width, change_window_heights, window_height)
5073 (window_width, CURBEG, CURSIZE, enlarge_window)
5074 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5075 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5076 handled in window.el.
5077 (make_dummy_parent): Rename to make_parent_window and give it a
5078 second argument horflag.
5079 (make_window): Don't set resize_proportionally any more.
5080 (Fsplit_window): Remove. Windows are split in window.el.
5081 (save_restore_action, save_restore_orig_size)
5082 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5083 Resize mini windows in window.el.
5084 (grow_mini_window, shrink_mini_window): Implement by calling
5085 Qresize_root_window_vertically, resize_window_check and
5086 resize_window_apply.
640c8776
SM
5087 (saved_window, Fset_window_configuration, save_window_save):
5088 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
5089 resize_proportionally.
5090 (window_min_height, window_min_width): Move to window.el.
5091 (keys_of_window): Move bindings for delete-other-windows,
5092 split-window, delete-window and enlarge-window to window.el.
5093
5094 * buffer.c: Temporarily extern Qdelete_window.
5095 (Fbury_buffer): Temporarily call Qdelete_window instead of
5096 Fdelete_window (Fbury_buffer will move to window.el soon).
5097
5098 * frame.c (set_menu_bar_lines_1): Remove code handling
5099 orig_top_line and orig_total_lines.
5100
5101 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5102 set_window_height but set heights directly.
5103 (change_frame_size_1): Use resize_frame_windows.
5104
5105 * xdisp.c (init_xdisp): Don't use set_window_height but set
5106 heights directly.
5107
640c8776
SM
5108 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5109 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
5110 run_window_configuration_change_hook.
5111
5112 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5113 instead of change_window_heights and run
5114 run_window_configuration_change_hook.
5115
1a13852e
MR
51162011-06-09 Martin Rudalics <rudalics@gmx.at>
5117
5118 * window.c (replace_window): Rename second argument REPLACEMENT to
5119 NEW. New third argument SETFLAG. Rewrite.
5120 (delete_window, make_dummy_parent): Call replace_window with
5121 third argument 1.
5122 (window_list_1): Move down in code.
5123 (run_window_configuration_change_hook): Move set_buffer part
5124 before select_frame_norecord part in order to unwind correctly.
5125 Rename count1 to count.
5126 (recombine_windows, delete_deletable_window, resize_root_window)
5127 (Fdelete_other_windows_internal)
5128 (Frun_window_configuration_change_hook, make_parent_window)
5129 (resize_window_check, resize_window_apply, Fresize_window_apply)
5130 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
5131 (Fdelete_window_internal, Fresize_mini_window_internal):
5132 New functions.
1a13852e
MR
5133 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5134
f3d1777e
MR
51352011-06-08 Martin Rudalics <rudalics@gmx.at>
5136
496e208e
MR
5137 * window.h (window): Add some new members to window structure -
5138 normal_lines, normal_cols, new_total, new_normal, clone_number,
5139 splits, nest, prev_buffers, next_buffers.
5140 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 5141 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 5142
f3d1777e
MR
5143 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5144 Remove.
496e208e
MR
5145 (make_dummy_parent): Set new members of windows structure.
5146 (make_window): Move down in code. Handle new members of window
5147 structure.
5148 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5149 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5150 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5151 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
5152 (Fset_window_next_buffers, Fset_window_clone_number):
5153 New functions.
496e208e
MR
5154 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5155 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5156 Doc-string fixes.
5157 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5158 Argument WINDOW can be now internal window too.
5159 (Fwindow_use_time): Move up in code.
5160 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5161 Rewrite doc-string.
5162 (Fset_window_configuration, saved_window)
5163 (Fcurrent_window_configuration, save_window_save): Handle new
5164 members of window structure.
b9e809c2
MR
5165 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5166 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5167 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5168 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5169 Qget_mru_window, Qresize_root_window,
5170 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5171 Qauto_buffer_name; staticpro them.
f3d1777e 5172
abde8f8c
MR
51732011-06-07 Martin Rudalics <rudalics@gmx.at>
5174
5175 * window.c (Fwindow_total_size, Fwindow_left_column)
5176 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5177 (Fwindow_list_1): New functions.
5178 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
5179 (Fwindow_width, Fscroll_left, Fscroll_right):
5180 Use window_body_cols instead of window_box_text_cols.
5181 (delete_window, Fset_window_configuration):
5182 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
5183 (delete_all_subwindows): Take a window as argument and not a
5184 structure. Rewrite.
190b47e6
MR
5185 (window_loop): Remove handling of GET_LRU_WINDOW and
5186 GET_LARGEST_WINDOW.
5187 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
5188
5189 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
5190 window_box_text_cols. delete_all_subwindows now takes a
5191 Lisp_Object as argument.
abde8f8c 5192
640c8776
SM
5193 * indent.c (compute_motion, Fcompute_motion):
5194 Use window_body_cols instead of window_box_text_cols.
abde8f8c 5195
fa8a67e6
MR
5196 * frame.c (delete_frame): Call delete_all_subwindows with root
5197 window as argument.
5198
a54e3482
DC
51992011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5200
5201 * fns.c (Fputhash): Document return value.
5202
60002bf5
CY
52032011-06-06 Chong Yidong <cyd@stupidchicken.com>
5204
5205 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5206
0c671da6 52072011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 5208
b862a52a 5209 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 5210
be44ca6c
PE
5211 Check for overflow when converting integer to cons and back.
5212 * charset.c (Fdefine_charset_internal, Fdecode_char):
5213 Use cons_to_unsigned to catch overflow.
5214 (Fencode_char): Use INTEGER_TO_CONS.
5215 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5216 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5217 * data.c (long_to_cons, cons_to_long): Remove.
5218 (cons_to_unsigned, cons_to_signed): New functions.
5219 These signal an error for invalid or out-of-range values.
5220 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5221 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5222 * font.c (Ffont_variation_glyphs):
5223 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5224 * lisp.h: Include <intprops.h>.
5225 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5226 (cons_to_signed, cons_to_unsigned): New decls.
5227 (long_to_cons, cons_to_long): Remove decls.
5228 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5229 (Fprimitive_undo): Use CONS_TO_INTEGER.
5230 * xfns.c (Fx_window_property): Likewise.
5231 * xselect.c: Include <limits.h>.
5232 (x_own_selection, selection_data_to_lisp_data):
5233 Use INTEGER_TO_CONS.
5234 (x_handle_selection_request, x_handle_selection_clear)
5235 (x_get_foreign_selection, Fx_disown_selection_internal)
5236 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5237 (lisp_data_to_selection_data): Use cons_to_unsigned.
5238 (x_fill_property_data): Use cons_to_signed.
5239 Report values out of range.
5240
d1f3d2af
PE
5241 Check for buffer and string overflow more precisely.
5242 * buffer.h (BUF_BYTES_MAX): New macro.
5243 * lisp.h (STRING_BYTES_MAX): New macro.
5244 * alloc.c (Fmake_string):
5245 * character.c (string_escape_byte8):
5246 * coding.c (coding_alloc_by_realloc):
5247 * doprnt.c (doprnt):
5248 * editfns.c (Fformat):
5249 * eval.c (verror):
5250 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5251 since they may not be the same number.
5252 * editfns.c (Finsert_char):
5253 * fileio.c (Finsert_file_contents):
5254 Likewise for BUF_BYTES_MAX.
5255
dd52fcea
PE
5256 * image.c: Use ptrdiff_t, not int, for sizes.
5257 (slurp_file): Switch from int to ptrdiff_t.
5258 All uses changed.
5259 (slurp_file): Check that file size fits in both size_t (for
5260 malloc) and ptrdiff_t (for sanity and safety).
5261
7f9bbdbb
PE
5262 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5263 if b->modtime has its maximal value.
5264
dfe18f82
PE
5265 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5266
84acfcf0
PE
5267 Don't assume time_t can fit into int.
5268 * buffer.h (struct buffer.modtime): Now time_t, not int.
5269 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5270 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5271
ccd9a01a
PE
5272 Minor fixes for signed vs unsigned integers.
5273 * character.h (MAYBE_UNIFY_CHAR):
5274 * charset.c (maybe_unify_char):
5275 * keyboard.c (read_char, reorder_modifiers):
5276 XINT -> XFASTINT, since the integer must be nonnegative.
5277 * ftfont.c (ftfont_spec_pattern):
5278 * keymap.c (access_keymap, silly_event_symbol_error):
5279 XUINT -> XFASTINT, since the integer must be nonnegative.
5280 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5281 since it makes no difference and we prefer signed.
5282 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5283 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5284 nonnegative.
5285
d6d100dd
SM
52862011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5287
5288 * window.h (Fwindow_frame): Declare.
5289
2b6148e4
PE
52902011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5291
5292 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5293 (SPARE_MEMORY): Always define.
5294 (LARGE_REQUEST): Remove.
5295 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5296
f230ecc9
MR
52972011-06-06 Martin Rudalics <rudalics@gmx.at>
5298
727e958e
MR
5299 * lisp.h: Move EXFUNS for Fframe_root_window,
5300 Fframe_first_window and Fset_frame_selected_window to window.h.
5301
5302 * window.h: Move EXFUNS for Fframe_root_window,
5303 Fframe_first_window and Fset_frame_selected_window here from
5304 lisp.h.
5305
5306 * frame.c (Fwindow_frame, Fframe_first_window)
5307 (Fframe_root_window, Fframe_selected_window)
5308 (Fset_frame_selected_window): Move to window.c.
5309 (Factive_minibuffer_window): Move to minibuf.c.
5310 (Fother_visible_frames_p): New function.
5311
5312 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5313
f230ecc9
MR
5314 * window.c (decode_window, decode_any_window): Move up in code.
5315 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5316 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
5317 (Fwindow_buffer): Move up and rewrite doc-string.
5318 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5319 (Fwindow_prev): New functions.
727e958e
MR
5320 (Fwindow_frame): Move here from frame.c. Accept any window as
5321 argument.
5322 (Fframe_root_window, Fframe_first_window)
5323 (Fframe_selected_window): Move here from frame.c. Accept frame
5324 or arbitrary window as argument. Update doc-strings.
5325 (Fminibuffer_window): Move up in code.
5326 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
5327 (Fset_frame_selected_window): Move here from frame.c.
5328 Marginal rewrite.
727e958e
MR
5329 (Fselected_window, select_window, Fselect_window): Move up in
5330 code. Minor doc-string fixes.
f230ecc9 5331
4d09bcf6
PE
53322011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5333
5334 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5335 Do not assume that spare memory exists; that assumption is valid
5336 only if SYSTEM_MALLOC.
5337 (LARGE_REQUEST): New macro, so that the issue of large requests
5338 is separated from the issue of spare memory.
5339
810928a2
AS
53402011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5341
172418ad
AS
5342 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5343 format. (Bug#8806)
5344
43f862f7
AS
5345 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5346
810928a2
AS
5347 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5348 before statements.
5349
a059fe24
JD
53502011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5351
5352 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5353
5354 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5355
5356 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5357 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5358
989bf368
JB
53592011-06-05 Juanma Barranquero <lekktu@gmail.com>
5360
5361 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5362
4b80f674
CY
53632011-06-04 Chong Yidong <cyd@stupidchicken.com>
5364
5365 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5366 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
5367 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5368 New error handlers.
4b80f674
CY
5369 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5370 Obey Vx_select_enable_clipboard_manager. Catch errors in
5371 x_clipboard_manager_save (Bug#8779).
5372 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 5373 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 5374
99a33b77 53752011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
5376
5377 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5378
99a33b77 53792011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
5380
5381 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5382 in the current matrix if keep_current_p is non-zero.
5383
8264569d
EZ
53842011-06-04 Eli Zaretskii <eliz@gnu.org>
5385
5386 * bidi.c (bidi_level_of_next_char): Fix last change.
5387
57f97249
EZ
53882011-06-03 Eli Zaretskii <eliz@gnu.org>
5389
fec2107c 5390 Support bidi reordering of text covered by display properties.
57f97249 5391
fec2107c
EZ
5392 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5393 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5394 (bidi_cache_search, bidi_cache_iterator_state)
5395 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
5396 (bidi_level_of_next_char, bidi_move_to_visually_next):
5397 Support character positions inside a run of characters covered by a
fec2107c
EZ
5398 display string.
5399 (bidi_paragraph_init, bidi_resolve_explicit_1)
5400 (bidi_level_of_next_char): Call bidi_fetch_char and
5401 bidi_fetch_char_advance instead of FETCH_CHAR and
5402 FETCH_CHAR_ADVANCE.
5403 (bidi_init_it): Initialize new members.
5404 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5405 definitions.
5406 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5407 instead of using explicit *_CHAR codes.
d6d100dd
SM
5408 (bidi_resolve_explicit, bidi_resolve_weak):
5409 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
5410 bidirectional text is supported only in multibyte buffers.
5411 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5412 it to initialize the frame_window_p member of struct bidi_it.
5413 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5414 (bidi_resolve_explicit, bidi_resolve_weak)
5415 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5416 bidi_it->nchars is non-positive.
5417 (bidi_level_of_next_char): Don't try to lookup the cache for the
5418 next/previous character if nothing is cached there yet, or if we
5419 were just reseat()'ed to a new position.
c40e2fb2 5420
0e14fe90
EZ
5421 * xdisp.c (set_cursor_from_row): Set start and stop points
5422 according to the row's direction when priming the loop that looks
5423 for the glyph on which to display cursor.
5424 (single_display_spec_intangible_p): Function deleted.
5425 (display_prop_intangible_p): Reimplement to call
5426 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
5427 Accept 3 additional arguments needed by handle_display_spec.
5428 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
5429 values: lists, `(when COND...)' forms, etc.
5430 (single_display_spec_string_p): Support property values that are
5431 lists with the argument STRING its top-level element.
5432 (display_prop_string_p): Fix the condition for processing a
5433 property that is a list to be consistent with handle_display_spec.
fec2107c 5434 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
5435 last portion of handle_display_prop.
5436 (compute_display_string_pos): Accept additional argument
5437 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5438 value of a `display' property is a "replacing spec".
5439 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5440 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5441 the display property, but just return a value indicating whether
5442 the display property will replace the characters it covers.
5443 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5444 frame_window_p members of struct bidi_it.
d6d100dd
SM
5445 (compute_display_string_pos, compute_display_string_end):
5446 New functions.
fec2107c
EZ
5447 (push_it): Accept second argument POSITION, where pop_it should
5448 jump to continue iteration.
5449 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 5450
fec2107c
EZ
5451 * keyboard.c (adjust_point_for_property): Adjust the call to
5452 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
5453
5454 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
5455 (bidi_init_it): Update prototypes.
5456 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
5457 (compute_display_string_pos, compute_display_string_end):
5458 Declare prototypes.
fec2107c
EZ
5459 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5460 EMACS_INT.
fc6f18ce 5461
40087514 54622011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 5463
57f53182
PE
5464 Malloc failure behavior now depends on size of allocation.
5465 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5466 * lisp.h: Change signatures accordingly.
5467 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5468 All callers changed. (Bug#8762)
5469
5470 * gnutls.c: Use Emacs's memory allocators.
5471 Without this change, the gnutls library would invoke malloc etc.
5472 directly, which causes problems on non-SYNC_INPUT hosts, and which
5473 runs afoul of improving memory_full behavior. (Bug#8761)
5474 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5475 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5476 xfree instead of the default malloc, realloc, free.
5477 (Fgnutls_boot): No need to check for memory allocation failure,
5478 since xmalloc does that for us.
5479
ac32cd99 5480 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
5481 * category.c (hash_get_category_set):
5482 * ccl.c (ccl_driver):
5483 * charset.c (Fdefine_charset_internal):
5484 * charset.h (struct charset.hash_index):
5485 * composite.c (get_composition_id, gstring_lookup_cache)
5486 (composition_gstring_put_cache):
5487 * composite.h (struct composition.hash_index):
5488 * dispextern.h (struct image.hash):
5489 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5490 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5491 (hashfn_equal, hashfn_user_defined, make_hash_table)
5492 (maybe_resize_hash_table, hash_lookup, hash_put)
5493 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5494 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5495 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5496 * image.c (make_image, search_image_cache, lookup_image)
5497 (xpm_put_color_table_h):
5498 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 5499 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 5500 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 5501 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
5502 * alloc.c (allocate_vectorlike):
5503 Check for overflow in vector size calculations.
5504 * ccl.c (ccl_driver):
5505 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
5506 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5507 need to be updated by these changes.
40087514
PE
5508 * fns.c (make_hash_table, maybe_resize_hash_table):
5509 Check for integer overflow with large hash tables.
0de4bb68
PE
5510 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5511 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5512 (SXHASH_REDUCE): New macro.
5513 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5514 Use it instead of discarding useful hash info with large hash values.
5515 (sxhash_float): New function.
5516 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5517 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
5518 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5519 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
5520 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5521 Adjust signatures to match updated version of code.
5522 (consing_since_gc): Now EMACS_INT, since a single hash table can
5523 use more than INT_MAX bytes.
5524
698d32e2
DN
55252011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5526
5527 Make it possible to build with GCC-4.6+ -O2 -flto.
5528
5529 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5530
fd6fa53f
SM
55312011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5532
5533 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5534 Call minibuffer-inactive-mode.
5535
864db017
JB
55362011-05-31 Juanma Barranquero <lekktu@gmail.com>
5537
5538 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5539 Update dependencies.
5540
2ad0baf4
DN
55412011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5542
5543 * data.c (init_data): Remove code for UTS, this system is not
5544 supported anymore.
5545
4fcc2638
DN
55462011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5547
5548 Don't force ./temacs to start in terminal mode.
5549
5550 * frame.c (make_initial_frame): Initialize faces in all cases, not
5551 only when CANNOT_DUMP is defined.
5552 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5553
c56e0fd5
DN
55542011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5555
5556 * dispnew.c (add_window_display_history): Use const for the string
5557 pointer. Remove declaration, not needed.
5558
333d54da 55592011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 5560
55d4c1b2 5561 Use 'inline', not 'INLINE'.
333d54da 5562 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
5563 * alloc.c, fontset.c (INLINE): Remove.
5564 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5565 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5566 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5567 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5568 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5569
738db178
DN
55702011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5571
5572 Make it possible to run ./temacs.
5573
5574 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5575 syms_of_callproc does the same thing. Remove test for
5576 "initialized", do it in the caller.
5577 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5578
620c53a6
SM
55792011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5580
5581 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5582 (read_minibuf): Use get_minibuffer.
5583 (syms_of_minibuf): Use DEFSYM.
5584 (Qmetadata): New var.
5585 * data.c (Qbuffer): Don't make it static.
5586 (syms_of_data): Use DEFSYM.
5587
e003a292
PE
55882011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5589
5590 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5591 (CCL_CODE_MIN): New macro.
5592
ed008a6d
PE
55932011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5594
3687c2ef
PE
5595 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5596
ed008a6d
PE
5597 * eval.c (Qdebug): Now static.
5598 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5599 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5600 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5601
d66c4c7c
CY
56022011-05-29 Chong Yidong <cyd@stupidchicken.com>
5603
5604 * image.c: Various fixes to ImageMagick code comments.
5605 (Fimagemagick_types): Doc fix.
5606
5fbc2025
PE
56072011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5608
0196f88a
PE
5609 Minor fixes prompted by GCC 4.6.0 warnings.
5610
5611 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5612
5fbc2025
PE
5613 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5614 (x_clipboard_manager_save_all): Move extern decl to ...
5615 * xterm.h: ... here, so that it can be checked for consistency.
5616
1dd3c2d9
CY
56172011-05-29 Chong Yidong <cyd@stupidchicken.com>
5618
5619 * xselect.c (x_clipboard_manager_save_frame)
5620 (x_clipboard_manager_save_all): New functions.
5621 (Fx_clipboard_manager_save): Lisp function deleted.
5622
5623 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5624 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5625
5626 * xterm.h: Update prototype.
5627
5ba6571d
WX
56282011-05-28 William Xu <william.xwl@gmail.com>
5629
5630 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5631 exiting (Bug#8239).
5632
3eaff834
JM
56332011-05-28 Jim Meyering <meyering@redhat.com>
5634
e1900994 5635 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
5636 * fns.c (to_uchar): Define.
5637 (crypto_hash_function): Use it to convert some newly-signed
5638 variables to unsigned, to avoid sign-extension bugs. For example,
5639 without this change, (md5 "truc") would evaluate to
5640 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5641 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 5642 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 5643
0f6990a7
PE
56442011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5645
5646 Integer overflow fixes.
c8a9ca5a 5647
08686060
PE
5648 * dbusbind.c: Serial number integer overflow fixes.
5649 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
5650 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5651 to hold a serial number that is too large for a fixnum.
5652 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5653 Check for serial numbers out of range. Decode any serial number
59568bf0 5654 that was so large that it became a float. (Bug#8722)
08686060 5655
2d1fc3c7
PE
5656 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5657 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5658 Use XFASTINT rather than XUINT when numbers are nonnegative.
5659 (xd_append_arg, Fdbus_method_return_internal):
5660 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5661 arguments, check that Lisp number is nonnegative, rather than
59568bf0 5662 silently wrapping negative numbers around. (Bug#8722)
30217ff0 5663 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 5664 (Bug#8722)
2d1fc3c7 5665
c8a9ca5a
PE
5666 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5667
519e1d69
PE
5668 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5669
30569699
PE
5670 ccl: add integer overflow checks
5671 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5672 (IN_INT_RANGE): New macros.
5673 (ccl_driver): Use them to check for integer overflow when
5674 decoding a CCL program. Many of the new checks are whether XINT (x)
5675 fits in int; it doesn't always, on 64-bit hosts. The new version
5676 doesn't catch all possible integer overflows, but it's an
847044ea 5677 improvement. (Bug#8719)
30569699 5678
c11285dc
PE
5679 * alloc.c (make_event_array): Use XINT, not XUINT.
5680 There's no need for unsigned here.
5681
fdccd48e
PE
5682 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5683 This follows up to the 2011-05-06 change that substituted uintptr_t
5684 for EMACS_INT. This case wasn't caught back then.
5685
37910ab2
PE
5686 Rework Fformat to avoid integer overflow issues.
5687 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5688 now (part of C89). Include <verify.h>.
5689 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5690 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5691 (Fformat): Avoid the prepass trying to compute sizes; it was only
5692 approximate and thus did not catch overflow reliably. Instead, walk
5693 through the format just once, formatting and computing sizes as we go,
5694 checking for integer overflow at every step, and allocating a larger
5695 buffer as needed. Keep track separately whether the format is
5696 multibyte. Keep only the most-recently calculated precision, rather
5697 than them all. Record whether each argument has been converted to
5698 string. Use EMACS_INT, not int, for byte and char and arg counts.
5699 Support field widths and precisions larger than INT_MAX. Avoid
5700 sprintf's undefined behavior with conversion specifications such as %#d
5701 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5702 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5703 formatting out-of-range floating point numbers with int
9173deec 5704 formats. (Bug#8668)
37910ab2 5705
2e6578fb
PE
5706 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5707
0ae6bdee
PE
5708 * data.c: Avoid integer truncation in expressions involving floats.
5709 * data.c: Include <intprops.h>.
5710 (arith_driver): When there's an integer overflow in an expression
5711 involving floating point, convert the integers to floating point
5712 so that the resulting value does not suffer from catastrophic
5713 integer truncation. For example, on a 64-bit host (* 4
5714 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5715 Do not rely on undefined behavior after integer overflow.
5716
de883a70
PE
5717 merge count_size_as_multibyte, parse_str_to_multibyte
5718 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 5719 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
5720 Check for integer overflow.
5721 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5722 since it's now a duplicate of the other. This is more of
5723 a character than a buffer op, so better that it's in character.c.
5724 * fns.c, print.c: Adjust to above changes.
5725
2ff916cb
PE
57262011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5727
5728 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5729
f1b54466
PE
57302011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5731
fb1ac845
PE
5732 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5733 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5734 (x_clipboard_manager_save): Now static.
5735 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5736
f1b54466
PE
5737 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5738 (crypto_hash_function): Now static.
5739 Fix pointer signedness problems. Avoid unnecessary initializations.
5740
a9f737ee
CY
57412011-05-27 Chong Yidong <cyd@stupidchicken.com>
5742
5743 * termhooks.h (Vselection_alist): Make it terminal-local.
5744
5745 * terminal.c (create_terminal): Initialize it.
5746
5747 * xselect.c: Support for clipboard managers.
5748 (Vselection_alist): Move to termhooks.h as terminal-local var.
5749 (LOCAL_SELECTION): New macro.
5750 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5751 (symbol_to_x_atom): Remove gratuitous arg.
5752 (x_handle_selection_request, lisp_data_to_selection_data)
5753 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
5754 (x_own_selection, x_get_local_selection, x_convert_selection):
5755 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
5756 (some_frame_on_display): Delete unused function.
5757 (Fx_own_selection_internal, Fx_get_selection_internal)
5758 (Fx_disown_selection_internal, Fx_selection_owner_p)
5759 (Fx_selection_exists_p): New optional frame arg.
5760 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5761 (x_handle_selection_clear): Don't treat other terminals with the
5762 same keyboard specially. Use the terminal-local Vselection_alist.
5763 (x_clear_frame_selections): Use Frun_hook_with_args.
5764
5765 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5766
5767 * xterm.h: Add support for those atoms.
5768
e067f0c1
CY
57692011-05-26 Chong Yidong <cyd@stupidchicken.com>
5770
5771 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5772 (converted_selections, conversion_fail_tag): New global variables.
5773 (x_selection_request_lisp_error): Free the above.
5774 (x_get_local_selection): Remove unnecessary code.
5775 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
5776 of converted selections stored in converted_selections.
5777 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
5778 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5779 (x_convert_selection): New function.
5780 (x_handle_selection_event): Simplify.
5781 (x_get_foreign_selection): Don't ignore incoming requests while
5782 waiting for an answer; this will fail when we implement
5783 SAVE_TARGETS, and seems unnecessary anyway.
5784 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5785 (Vx_sent_selection_functions): Doc fix.
5786
0f4aebc0
LL
57872011-05-26 Leo Liu <sdl.web@gmail.com>
5788
5789 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5790
e61124cd
YM
57912011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5792
5793 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5794
5795 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5796 for fringe update if it has periodic bitmap.
ac389d0c 5797 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
5798 and fringe_bitmap_periodic_p.
5799
5800 * fringe.c (get_fringe_bitmap_data): New function.
5801 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5802 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5803 row. Mark glyph row for fringe update if periodicity changed.
5804
5805 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5806 for fringe update unless it has periodic bitmap.
5807
f16d9837
KH
58082011-05-25 Kenichi Handa <handa@m17n.org>
5809
5810 * xdisp.c (get_next_display_element): Set correct it->face_id for
5811 a static composition.
5812
e1b90ef6
LL
58132011-05-24 Leo Liu <sdl.web@gmail.com>
5814
5815 * deps.mk (fns.o):
5816 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5817
5818 * fns.c (crypto_hash_function, Fsha1): New function.
5819 (Fmd5): Use crypto_hash_function.
5820 (syms_of_fns): Add Ssha1.
5821
7400048f
PE
58222011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5823
5824 * gnutls.c: Remove unused macros.
5825 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5826 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5827 Remove macros that are defined and never used.
5828 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5829
abb71cf4
CY
58302011-05-22 Chong Yidong <cyd@stupidchicken.com>
5831
5832 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5833 (Fx_get_selection_internal): Minor cleanup.
5834 (Fx_own_selection_internal): Rename arguments for consistency with
5835 select.el.
5836
6307db39
PE
58372011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5838
5839 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5840
f3d4e0a4
CY
58412011-05-22 Chong Yidong <cyd@stupidchicken.com>
5842
5843 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5844
4d8ade89
YM
58452011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5846
5847 * dispnew.c (scrolling_window): Don't exclude the case that the
5848 last enabled row in the desired matrix touches the bottom boundary.
5849
32078c8d
GM
58502011-05-21 Glenn Morris <rgm@gnu.org>
5851
5852 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
5853 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5854 and add some more files.
32078c8d 5855
7285dc67
EZ
58562011-05-20 Eli Zaretskii <eliz@gnu.org>
5857
5858 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5859 report_file_error introduced by the change from 2011-05-07.
5860
89d1bd22
PE
58612011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5862
5863 * systime.h (Time): Define only if emacs is defined.
5864 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5865 where the include path doesn't have X11/X.h by default. See
5866 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5867
cd394be1 58682011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
5869
5870 * composite.c (find_automatic_composition): Fix previous change.
5871
b9704ad9
GM
58722011-05-20 Glenn Morris <rgm@gnu.org>
5873
5874 * lisp.mk: New file, split from Makefile.in.
5875 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5876 (shortlisp): Remove.
5877 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5878
4a720484
GM
58792011-05-19 Glenn Morris <rgm@gnu.org>
5880
5881 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5882 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5883 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5884 (lisp): Set the order to that of loadup.el.
5885 (shortlisp): Make it a copy of $lisp.
5886 (SOME_MACHINE_LISP): Remove.
5887 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5888 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5889
a28d4396
KH
58902011-05-18 Kenichi Handa <handa@m17n.org>
5891
5892 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5893 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5894 (find_automatic_composition): Mostly rewrite for efficiency.
5895
a2b1fa8e
JB
58962011-05-18 Juanma Barranquero <lekktu@gmail.com>
5897
5898 * makefile.w32-in: Update dependencies.
5899
8e1f5610
CS
59002011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5901
5902 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 5903 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 5904
7025ee00 59052011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 5906
cdfa6eab
PE
5907 Fix some integer overflow issues, such as string length overflow.
5908
06d6db33
PE
5909 * insdel.c (count_size_as_multibyte): Check for string overflow.
5910
2b4560a8
PE
5911 * character.c (lisp_string_width): Check for string overflow.
5912 Use EMACS_INT, not int, for string indexes and lengths; in
5913 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5914 the resulting string length overflows an EMACS_INT; instead,
5915 report a string overflow if no precision given. When checking for
5916 precision exhaustion, use a check that cannot possibly have
5917 integer overflow. (Bug#8675)
5918 * character.h (lisp_string_width): Adjust to new signature.
5919
cb93f9be
PE
5920 * alloc.c (string_overflow): New function.
5921 (Fmake_string): Use it. This doesn't change behavior, but saves
5922 a few bytes and will simplify future changes.
5923 * character.c (string_escape_byte8): Likewise.
5924 * lisp.h (string_overflow): New decl.
5925
1a1f3366
PE
5926 Fixups, following up to the user-interface timestamp change.
5927 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5928 for UI timestamps, instead of unsigned long.
9fbd6841
PE
5929 * msdos.c (mouse_get_pos): Likewise.
5930 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
5931 * w32gui.h (Time): Define by including "systime.h" rather than by
5932 declaring it ourselves. (Bug#8664)
5933
d4e3e4d3
PE
5934 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5935 * image.c (clear_image_cache): Likewise.
5936
f6a24d19
PE
5937 * term.c (term_mouse_position): Don't assume time_t wraparound.
5938
08dc5ae6
PE
5939 Be more systematic about user-interface timestamps.
5940 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
5941 and sometimes 'EMACS_UINT', to represent these timestamps.
5942 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
5943 This makes the code easier to follow, and makes it easier to catch
5944 integer overflow bugs such as Bug#8664.
5945 * frame.c (Fmouse_position, Fmouse_pixel_position):
5946 Use Time, not unsigned long, for user-interface timestamps.
5947 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5948 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5949 * keyboard.h (last_event_timestamp): Likewise.
5950 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5951 * menu.h (xmenu_show): Likewise.
5952 * term.c (term_mouse_position): Likewise.
5953 * termhooks.h (struct input_event.timestamp): Likewise.
5954 (struct terminal.mouse_position_hook): Likewise.
5955 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5956 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5957 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5958 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5959 what it was before.
5960 * menu.h, termhooks.h: Include "systime.h", for Time.
5961
8e55734a
PE
5962 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5963 Don't assume that the difference between two unsigned long values
5964 can fit into an integer. At this point, we know button_down_time
5965 <= event->timestamp, so the difference must be nonnegative, so
5966 there's no need to cast the result if double-click-time is
5967 nonnegative, as it should be; check that it's nonnegative, just in
5968 case. This bug is triggered when events are more than 2**31 ms
86db42d2 5969 apart (about 25 days). (Bug#8664)
8e55734a 5970
841f1b75 5971 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 5972 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 5973
3e26f69c
PE
5974 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5975 that always fit in int. Use a sentinel instead of a counter, to
5976 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
5977 * frame.h (struct frame): Use int for menu_bar_items_used
5978 instead of EMACS_INT, since it always fits in int.
3e26f69c 5979
5cc152c0
PE
5980 * menu.c (grow_menu_items): Check for int overflow.
5981
d89eb65e
PE
5982 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5983
5235bd3e
PE
5984 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5985 Before, the code was not consistent. These values cannot exceed
5986 2**31 - 1 so there's no need to make them unsigned.
5987 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5988 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5989 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5990 as modifiers.
5991 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5992
bc827e23
PE
5993 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5994 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5995 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5996 presumably because the widths might not match.
5997
78eb494e
PE
5998 * window.c (size_window): Avoid needless test at loop start.
5999
04f2d78b
CB
60002011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6001
6002 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6003
d2fc7e3d 60042011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
6005
6006 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6007
d2fc7e3d 60082011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
6009
6010 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6011 `width' to `bar_area_x' and `bar_area_width', respectively.
6012 (x_scroll_run): Take account of fringe background extension.
6013
04f2d78b
CB
6014 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6015 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
6016 `bar_area_width', respectively.
6017 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6018 background extension.
6019
79b70037
GM
60202011-05-10 Jim Meyering <meyering@redhat.com>
6021
6022 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6023
2f142cc5
JB
60242011-05-10 Juanma Barranquero <lekktu@gmail.com>
6025
6026 * image.c (Finit_image_library): Return t for built-in image types,
6027 like pbm and xbm. (Bug#8640)
6028
57679c86
AS
60292011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6030
6031 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6032
888c9e86
EZ
60332011-05-07 Eli Zaretskii <eliz@gnu.org>
6034
b0512a1d
EZ
6035 * w32console.c (Fset_screen_color): Doc fix.
6036 (Fget_screen_color): New function.
6037 (syms_of_ntterm): Defsubr it.
6038
7285dc67
EZ
6039 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6040 unlink the temporary file if Fcall_process didn't create it in the
6041 first place.
6042 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6043 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
6044 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6045 cue to call_process_cleanup not to close that handle.
6046
4d3fcc8e
BK
60472011-05-07 Ben Key <bkey76@gmail.com>
6048
6049 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6050 one of two shell specific rules, either bootstrap-temacs-CMD or
6051 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6052 to the previous implementation of the bootstrap-temacs rule.
6053 The bootstrap-temacs-CMD rule is similar to the previous
6054 implementation of the bootstrap-temacs rule except that it
6055 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6056 variable.
6057
6058 These changes, along with some changes to nt/configure.bat,
6059 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6060 earlier fix to add support for --cflags and --ldflags options
6061 that include quotes so that it works whether make uses cmd or
6062 sh as the shell.
6063
b4289b64
MA
60642011-05-06 Michael Albinus <michael.albinus@gmx.de>
6065
6066 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6067 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6068 is a constant.
6069 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6070 a string. Handle both cases.
6071 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6072 (Fdbus_register_method): Use Qinvalid_function.
6073
af4c0e28
JB
60742011-05-06 Juanma Barranquero <lekktu@gmail.com>
6075
6076 * makefile.w32-in: Update dependencies.
6077 (LISP_H): Add inttypes.h and stdin.h.
6078 (PROCESS_H): Add unistd.h.
6079
c51453d9
EZ
60802011-05-06 Eli Zaretskii <eliz@gnu.org>
6081
6082 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6083 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6084
8ff0ac3c 60852011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 6086
4c4b566b
PE
6087 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6088
aab2b9b5
PE
6089 * term.c (vfatal): Remove stray call to va_end.
6090 It's not needed and the C Standard doesn't allow it here anyway.
6091
c378da0b
PE
6092 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6093 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6094
288b08c7
PE
6095 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6096 bytes.
6097
e3601888
PE
6098 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6099
db6c0e74
PE
6100 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6101
dd5963ea
PE
6102 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6103
88c9450f
PE
6104 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6105
2f9442b8
PE
6106 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6107
c032b5f8
PE
6108 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6109 * charset.c (Fdefine_charset_internal): Don't initialize
6110 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 6111 32-bit int (Bug#8600).
a108c10b
PE
6112
6113 * lread.c (read_integer): Be more consistent with string-to-number.
6114 Use string_to_number to do the actual conversion; this avoids
6115 rounding errors and fixes some other screwups. Without this fix,
6116 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6117 (digit_to_number): Move earlier, for benefit of read_integer.
6118 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 6119 not a digit in any supported base. (Bug#8602)
a108c10b 6120
ad5f9eea
PE
6121 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6122
aec1708a
PE
6123 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6124 to match comment at start of function. This also removes a
6125 GCC warning about overflow in a 32+64-bit port.
6126
47be4ab5
PE
6127 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6128
371cac43
PE
6129 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6130 Reported by Stefan Monnier in
6131 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
6132 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6133 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 6134
d01a7826
PE
6135 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6136 (EMACS_UINTPTR): Likewise, with uintptr_t.
6137
7fd47d5c
PE
6138 * lisp.h: Prefer 64-bit EMACS_INT if available.
6139 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6140 on 32-bit hosts that have 64-bit int, so that they can access
6141 large files.
122b0c86
PE
6142 However, temporarily disable this change unless the temporary
6143 symbol WIDE_EMACS_INT is defined.
7fd47d5c 6144
8727937b
PE
6145 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6146
8ac068ac
PE
6147 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6148 This removes an assumption that EMACS_INT and long are the same
6149 width as pointers. The assumption is true for Emacs porting targets
6150 now, but we want to make other targets possible.
6151 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6152 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6153 In the rest of the code, change types of integers that hold casted
6154 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6155 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6156 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6157 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6158 No need to cast type when ORing.
6159 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6160 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6161 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6162 assume EMACS_INT is the same width as char *.
6163 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6164 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6165 Remove no-longer-needed casts.
6166 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6167 (xg_tool_bar_help_callback, xg_make_tool_item):
6168 Use EMACS_INTPTR to hold an integer
6169 that will be cast to void *; this can avoid a GCC warning
6170 if EMACS_INT is not the same width as void *.
6171 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6172 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6173 (current_message_1, set_message_1):
6174 Use a local to convert to proper width without a cast.
6175 * xmenu.c (dialog_selection_callback): Likewise.
6176
ede49d71
PE
6177 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6178 Also, don't assume VALBITS / RAND_BITS is less than 5,
6179 and don't rely on undefined behavior when shifting a 1 left into
6180 the sign bit.
6181 * lisp.h (get_random): Change signature to match.
6182
2f30ecd0
PE
6183 * lread.c (hash_string): Use size_t, not int, for hash computation.
6184 Normally we prefer signed values; but hashing is special, because
6185 it's better to use unsigned division on hash table sizes so that
6186 the remainder is nonnegative. Also, size_t is the natural width
6187 for hashing into memory. The previous code used 'int', which doesn't
6188 retain enough info to hash well into very large tables.
6189 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6190
2a866e7b
PE
6191 * dbusbind.c: Don't possibly lose pointer info when converting.
6192 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6193 Use XPNTR rather than XHASH, so that the high-order bits of
6194 the pointer aren't lost when converting through void *.
6195
51639eac
PE
6196 * eval.c (Fautoload): Don't double-shift a pointer.
6197
92394119
PE
6198 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6199
dbdb9a7c
JB
62002011-05-06 Juanma Barranquero <lekktu@gmail.com>
6201
6202 * gnutls.c (DEF_GNUTLS_FN):
6203 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6204
db7a0b4f
AS
62052011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6206
6207 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6208 marker. (Bug#8610)
6209
cd394be1 62102011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
6211
6212 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6213 New version that can reserve upto 2GB of heap space.
6214
f7ff1b0f 62152011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
6216
6217 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6218
639c109b
TZ
62192011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6220
6221 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6222 `gnutls_certificate_set_x509_key_file'.
6223
d2127135
JB
62242011-05-05 Juanma Barranquero <lekktu@gmail.com>
6225
6226 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6227 Update dependencies.
6228
e968f4f3
JB
62292011-05-04 Juanma Barranquero <lekktu@gmail.com>
6230
6231 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6232 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6233 Remove unused parameter `fildes'.
6234 * process.c (read_process_output, send_process): Don't pass it.
6235
84d358f0
JB
62362011-05-04 Juanma Barranquero <lekktu@gmail.com>
6237
6238 Fix previous change: the library cache is defined in w32.c.
6239 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6240 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6241
0898ca10
JB
62422011-05-04 Juanma Barranquero <lekktu@gmail.com>
6243
6244 Implement dynamic loading of GnuTLS on Windows.
6245
6246 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6247 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6248 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6249 Declare.
6250
6251 * gnutls.c (Qgnutls_dll): Define.
6252 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6253 (gnutls_*): Declare function pointers.
6254 (init_gnutls_functions): New function to initialize function pointers.
6255 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6256 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6257 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6258 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6259 (emacs_gnutls_write, emacs_gnutls_read)
6260 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6261 (Fgnutls_available_p): New function.
6262 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6263 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6264 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6265
6266 * image.c: Include w32.h.
6267 (Vimage_type_cache): Delete.
6268 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6269 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6270 (w32_delayed_load): Move to w32.c.
6271
6272 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6273
6274 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6275 (w32_delayed_load): Move from image.c. When loading a library, record
6276 its filename in the :loaded-from property of the library id.
6277 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6278 Initialize and staticpro them.
6279 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6280
6281 * process.c: Include lisp.h before w32.h, not after.
6282 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6283 instead of gnutls_record_check_pending.
6284
6285 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6286
ff4de4aa
TZ
62872011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6288
6289 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6290 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6291 as passed in.
6292
abe95abb
JD
62932011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6294
6295 * xterm.c (x_set_frame_alpha): Do not set property on anything
6296 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6297
e16e55d4
JB
62982011-05-02 Juanma Barranquero <lekktu@gmail.com>
6299
6300 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6301
bafcf6a5
JB
63022011-05-02 Juanma Barranquero <lekktu@gmail.com>
6303
6304 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6305 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6306 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6307 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6308 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6309 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6310 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6311 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6312 (Qgnutls_bootprop_callbacks_verify): Make static.
6313
e7a6747f
AS
63142011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6315
19ed11ba
AS
6316 * callproc.c: Indentation fixup.
6317
e7a6747f 6318 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
6319 (wait_for_termination, interruptible_wait_for_termination):
6320 Move after wait_for_termination_1.
e7a6747f 6321
1ef14cb4
LMI
63222011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6323
6324 * sysdep.c (interruptible_wait_for_termination): New function
6325 which is like wait_for_termination, but allows keyboard
6326 interruptions.
6327
6328 * callproc.c (Fcall_process): Add (:file "file") as an option for
6329 the STDOUT buffer.
6330 (Fcall_process_region): Ditto.
6331
330d880c
EZ
63322011-04-30 Eli Zaretskii <eliz@gnu.org>
6333
8db90b73
EZ
6334 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6335 rather than `XVECTOR (FOO)->size'.
6336
330d880c
EZ
6337 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6338 inttypes.h, as a gnulib replacement is used if it not available in
6339 system headers.
6340
15cbd324
EZ
63412011-04-21 Eli Zaretskii <eliz@gnu.org>
6342
6343 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6344 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6345 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6346
6347 * coding.c (coding_alloc_by_realloc): Error out if destination
6348 will grow beyond MOST_POSITIVE_FIXNUM.
6349 (decode_coding_emacs_mule): Abort if there isn't enough place in
6350 charbuf for the composition carryover bytes. Reserve an extra
6351 space for up to 2 characters produced in a loop.
6352 (decode_coding_iso_2022): Abort if there isn't enough place in
6353 charbuf for the composition carryover bytes.
6354
63552011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 6356
ae940cca
EZ
6357 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6358 aborting when %lld or %lll format is passed.
6359 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6360 %llo or %llx format is passed. (Bug#8545)
6361
03ab8921
EZ
6362 * window.c (window_scroll_line_based): Use a marker instead of
6363 simple variables to record original value of point. (Bug#7952)
6364
afda1437
EZ
6365 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6366 produced by %s or %c overflows available buffer space. (Bug#8545)
6367
f76dee0c
PE
63682011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6369
6370 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 6371 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 6372
fdc5744d
JB
63732011-04-28 Juanma Barranquero <lekktu@gmail.com>
6374
6375 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6376
638f053a
JB
63772011-04-28 Juanma Barranquero <lekktu@gmail.com>
6378
6379 * keyboard.c (Qdelayed_warnings_hook): Define.
6380 (command_loop_1): Run `delayed-warnings-hook'
6381 if Vdelayed_warnings_list is non-nil.
6382 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6383 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6384
d178f871
EZ
63852011-04-28 Eli Zaretskii <eliz@gnu.org>
6386
6387 * doprnt.c (doprnt): Don't return value smaller than the buffer
6388 size if the message was truncated. (Bug#8545).
6389
b124fd93
JB
63902011-04-28 Juanma Barranquero <lekktu@gmail.com>
6391
6392 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6393 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6394
e810457d
PE
63952011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6396
6397 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6398
ea51cceb
JB
63992011-04-27 Juanma Barranquero <lekktu@gmail.com>
6400
6401 * makefile.w32-in: Update dependencies.
6402
94dcfacf
EZ
64032011-04-27 Eli Zaretskii <eliz@gnu.org>
6404
6405 Improve `doprnt' and its usage. (Bug#8545)
6406 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6407 `format_end'. Remove support for %l as a conversion specifier.
6408 Don't use xrealloc. Improve diagnostics when the %l size modifier
6409 is used. Update the commentary.
6410
6411 * eval.c (verror): Simplify calculation of size_t.
6412
6413 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6414 messages.
6415
f61f41d7
PE
64162011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6417
6418 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6419 change.
6420
96fb4434
PE
64212011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6422
6423 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6424 This makes this file independent of the recent pseudovector change.
6425
671875da 64262011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 6427
69e9b5a3
PE
6428 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6429
b5f869a7 6430 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 6431 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 6432 Remove unused local.
c8926152 6433 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 6434
841a1577 6435 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
6436 GCC 4.6.0 optimizes based on type-based alias analysis.
6437 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
6438 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6439 != &v->size, and therefore "v->size = 1; b->size = 2; return
6440 v->size;" must therefore return 1. This assumption is incorrect
6441 for Emacs, since it type-puns struct Lisp_Vector * with many other
6442 types. To fix this problem, this patch adds a new type struct
f904488f 6443 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
6444 and pseudovectors, and helps optimizing compilers not get fooled
6445 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6446 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
6447 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6448 the size member.
eab3844f
PE
6449 (XSETPVECTYPE): Rewrite in terms of new macro.
6450 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6451 This is a bit clearer, and further avoids the possibility of
6452 undesirable aliasing.
6453 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 6454 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
6455 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6456 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
6457 (ASIZE): Now uses header.size rather than size.
6458 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
6459 to avoid the hassle of writing XVECTOR (foo)->header.size.
6460 (struct vectorlike_header): New type.
eab3844f
PE
6461 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6462 object, to help avoid aliasing.
6463 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6464 (SUBRP): Likewise, since Lisp_Subr is a special case.
6465 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6466 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6467 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 6468 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
6469 changed to be "header.size" and "header.next".
6470 * buffer.h (struct buffer): Likewise.
6471 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6472 * frame.h (struct frame): Likewise.
6473 * process.h (struct Lisp_Process): Likewise.
6474 * termhooks.h (struct terminal): Likewise.
6475 * window.c (struct save_window_data, struct saved_window): Likewise.
6476 * window.h (struct window): Likewise.
6477 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6478 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6479 * buffer.c (init_buffer_once): Likewise.
6480 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6481 special case.
6482 * process.c (Fformat_network_address): Use local var for size,
6483 for brevity.
6484
0df1eac5
PE
6485 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6486
847ab9d1 6487 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
6488 * data.c (atof): Remove decl; no longer used or needed.
6489 (digit_to_number): Move to lread.c.
6490 (Fstring_to_number): Use new string_to_number function, to be
6491 consistent with how the Lisp reader treats infinities and NaNs.
6492 Do not assume that floating-point numbers represent EMACS_INT
6493 without losing information; this is not true on most 64-bit hosts.
6494 Avoid double-rounding errors, by insisting on integers when
6495 parsing non-base-10 numbers, as the documentation specifies.
6496 * lisp.h (string_to_number): New decl, replacing ...
6497 (isfloat_string): Remove.
bc0a5c13 6498 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 6499 (read1): Do not accept +. and -. as integers; this
452f4150
PE
6500 appears to have been a coding error. Similarly, do not accept
6501 strings like +-1e0 as floating point numbers. Do not report
6502 overflow for integer overflows unless the base is not 10 which
6503 means we have no simple and reliable way to continue.
6504 Break out the floating-point parsing into a new
6505 function string_to_number, so that Fstring_to_number parses
6506 floating point numbers consistently with the Lisp reader.
04f2d78b 6507 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
6508 (E_CHAR, EXP_INT): Remove, replacing with ...
6509 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6510 (string_to_number): New function, replacing isfloat_string.
6511 This function checks for valid syntax and produces the resulting
6512 Lisp float number too. Rework it so that string-to-number
bc0a5c13 6513 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
6514 so that overflow for non-base-10 numbers is reported only when
6515 there's no portable and simple way to convert to floating point.
452f4150 6516
67769ffc
PE
6517 * textprop.c (set_text_properties_1): Rewrite for clarity,
6518 and to avoid GCC warning about integer overflow.
6519
c20db43f
PE
6520 * intervals.h (struct interval): Use EMACS_INT for members
6521 where EMACS_UINT might cause problems. See
6522 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6523 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6524 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6525 All uses changed.
37aa2f85
PE
6526 (offset_intervals): Tell GCC not to worry about length overflow
6527 when negating a negative length.
c20db43f 6528
2538aa2f
PE
6529 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6530 (overrun_check_free): Likewise.
6531
f2d3008d
PE
6532 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6533 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6534 word size.
6535
ec8df744
PE
6536 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6537 (gnutls_make_error): Rename local to avoid shadowing.
6538 (gnutls_emacs_global_deinit): ifdef out; not used.
6539 (Fgnutls_boot): Use const for pointer to readonly storage.
6540 Comment out unused local. Fix pointer signedness problems.
6541
640ee02d
PE
6542 * lread.c (openp): Don't stuff size_t into an 'int'.
6543 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6544 about possible signed overflow.
6545
6048fb2a
PE
6546 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6547 (GDK_KEY_g): Don't define if already defined.
6548 (xg_prepare_tooltip): Avoid pointer signedness problem.
6549 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6550
fa3c87e1
PE
6551 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6552 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6553
2172544b
PE
6554 * xfns.c (Fx_window_property): Simplify a bit,
6555 to make a bit faster and to avoid GCC 4.6.0 warning.
6556 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6557
9b821a21
PE
6558 * fns.c (internal_equal): Don't assume size_t fits in int.
6559
3c616cfa
PE
6560 * alloc.c (compact_small_strings): Tighten assertion a little.
6561
c2982e87
PE
6562 Replace pEd with more-general pI, and fix some printf arg casts.
6563 * lisp.h (pI): New macro, generalizing old pEd macro to other
6564 conversion specifiers. For example, use "...%"pI"d..." rather
6565 than "...%"pEd"...".
6566 (pEd): Remove. All uses replaced with similar uses of pI.
6567 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6568 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6569 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6570 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6571 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6572 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6573 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6574 64-bit hosts.
6575 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6576 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6577 * print.c (safe_debug_print, print_object): Likewise.
6578 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6579 to int.
6f04d126
PE
6580 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6581 avoiding the 0 flag, which is not portable.
c2982e87
PE
6582 * process.c (Fmake_network_process): Use pI to avoid cast.
6583 * region-cache.c (pp_cache): Likewise.
6584 * xdisp.c (decode_mode_spec): Likewise.
6585 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6586 behavior on 64-bit hosts with printf arg.
6f04d126 6587 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
6588 (x_stop_queuing_selection_requests): Likewise.
6589 (x_get_window_property): Don't truncate byte count to an 'int'
6590 when tracing.
0b432f21 6591
5e073ec7
PE
6592 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6593 here, since it parses constructs like leading '-' and spaces,
6594 which are not wanted; and it overflows with large numbers.
6595 Instead, simply match F[0-9]+, which is what is wanted anyway.
6596
36372bf9
PE
6597 * alloc.c: Remove unportable assumptions about struct layout.
6598 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6599 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6600 (allocate_vectorlike, make_pure_vector): Use the new macros,
6601 plus offsetof, to remove unportable assumptions about struct layout.
6602 These assumptions hold on all porting targets that I know of, but
6603 they are not guaranteed, they're easy to remove, and removing them
6604 makes further changes easier.
6605
0b432f21
PE
6606 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6607 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
6608 (string_overrun_cookie): Now const. Use initializers that
6609 don't formally overflow signed char, to avoid warnings.
000098c1
PE
6610 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6611 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
6612 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6613 multiple of sizeof (EMACS_INT); it need not be, if
6614 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 6615 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 6616
895009e1
JB
66172011-04-26 Juanma Barranquero <lekktu@gmail.com>
6618
6619 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6620
6a7a1b0b
TZ
66212011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6622
6623 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 6624 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
6625 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6626
841a1577 66272011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
6628
6629 * lisp.h (Qdebug): List symbol.
895009e1 6630 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
6631 * keyboard.c (debug-on-event): New variable.
6632 (handle_user_signal): Break into debugger when debug-on-event
6633 matches the current signal symbol.
6634
f2d3ba6f
DN
66352011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6636
6637 * alloc.c (check_sblock, check_string_bytes)
6638 (check_string_free_list): Convert to standard C.
6639
42ce4c63
TZ
66402011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6641
6642 * w32.c (emacs_gnutls_push): Fix typo.
6643
825cd63c
EZ
66442011-04-25 Eli Zaretskii <eliz@gnu.org>
6645
fb11d64d
EZ
6646 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6647 "cast to pointer from integer of different size".
6648
825cd63c
EZ
6649 Improve doprnt and its use in verror. (Bug#8545)
6650 * doprnt.c (doprnt): Document the set of format control sequences
6651 supported by the function. Use SAFE_ALLOCA instead of always
6652 using `alloca'.
6653
6654 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6655 is one byte too soon. Don't use xrealloc; instead xfree and
6656 xmalloc anew.
6657
e061a11b
TZ
66582011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6659
6660 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6661 callbacks stage.
6662
6663 * gnutls.c: Renamed global_initialized to
6664 gnutls_global_initialized. Added internals for the
6665 :verify-hostname-error, :verify-error, and :verify-flags
6666 parameters of `gnutls-boot' and documented those parameters in the
6667 docstring. Start callback support.
9173deec
JB
6668 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6669 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6670 on error. Return error code.
e061a11b
TZ
6671 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6672 (emacs_gnutls_read): Likewise.
6673 (Fgnutls_boot): Return handshake error code.
6674 (emacs_gnutls_handle_error): New function.
6675 (wsaerror_to_errno): Likewise.
6676
6677 * w32.h (emacs_gnutls_pull): Add prototype.
6678 (emacs_gnutls_push): Likewise.
6679
6680 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6681 (emacs_gnutls_push): Likewise.
6682
66832011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6684
6685 * process.c (wait_reading_process_output): Check if GnuTLS
6686 buffered some data internally if no FDs are set for TLS
6687 connections.
6688
6689 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6690 (LIBS): Link to USER_LIBS.
6691 ($(BLD)/gnutls.$(0)): New target.
6692
fa6996bc
EZ
66932011-04-24 Eli Zaretskii <eliz@gnu.org>
6694
eb35682e
EZ
6695 * xdisp.c (handle_single_display_spec): Rename the
6696 display_replaced_before_p argument into display_replaced_p, to
6697 make it consistent with the commentary. Fix typos in the
6698 commentary.
6699
e2ad650c
EZ
6700 * textprop.c (syms_of_textprop): Remove dead code.
6701 (copy_text_properties): Delete obsolete commentary about an
6702 interface that was deleted long ago. Fix typos in the description
6703 of arguments.
6704
1b2de274
EZ
6705 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6706 to changes in oldXMenu/XMenu.h from 2011-04-16.
6707 <menu_help_message, prev_menu_help_message>: Constify.
6708 (IT_menu_make_room): menu->help_text is now `const char **';
6709 adjust.
6710
6711 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6712 to changes in oldXMenu/XMenu.h from 2011-04-16.
6713 (struct XMenu): Declare `help_text' `const char **'.
6714
6715 * xfaces.c <Qunspecified>: Make extern again.
6716
6717 * syntax.c: Include sys/types.h before including regex.h, as
6718 required by Posix.
6719
762b15be
EZ
6720 * doc.c (get_doc_string): Improve the format passed to `error'.
6721
6722 * doprnt.c (doprnt): Improve commentary.
6723
6724 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6725
6726 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6727 them with etags.
6728
f1052e5d
EZ
6729 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6730 changes in globals.h immediately force recompilation.
762b15be
EZ
6731 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6732 $(CURDIR)/s/ms-w32.h.
6733 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 6734
fa6996bc
EZ
6735 * character.c (Fchar_direction): Function deleted.
6736 (syms_of_character): Don't defsubr it.
6737 <char-direction-table>: Deleted.
6738
e6c3da20
EZ
67392011-04-23 Eli Zaretskii <eliz@gnu.org>
6740
6741 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6742 * doprnt.c: Include limits.h.
6743 (SIZE_MAX): New macro.
04f2d78b
CB
6744 (doprnt): Return a size_t value. 2nd arg is now size_t.
6745 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
6746 Improve overflow protection. Support `l' modifier for integer
6747 conversions. Support %l conversion. Don't assume an EMACS_INT
6748 argument for integer conversions and for %c.
6749
6750 * lisp.h (doprnt): Restore prototype.
6751
6752 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6753 $(SRC)/character.h.
6754
6755 * Makefile.in (base_obj): Add back doprnt.o.
6756
6757 * deps.mk (doprnt.o): Add back prerequisites.
6758 (callint.o): Depend on character.h.
6759
6760 * eval.c (internal_lisp_condition_case): Include the handler
6761 representation in the error message.
6762 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6763 when breaking from the loop.
6764
6765 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6766
6767 * callint.c (Fcall_interactively): When displaying error message
6768 about invalid control letter, pass the character's codepoint, not
6769 a pointer to its multibyte form. Improve display of the character
6770 in octal and display also its hex code.
6771
6772 * character.c (char_string): Use %x to display the (unsigned)
6773 codepoint of an invalid character, to avoid displaying a bogus
6774 negative value.
6775
6776 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6777 `error', not SYMBOL_NAME itself.
6778
6779 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6780 character arguments to `error'.
6781
6782 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6783 to `error' in error message about FINAL_CHAR argument. Make sure
6784 FINAL_CHAR is a character, and use %c when it is passed as
6785 argument to `error'.
6786
4ffd0d6b 67872011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
6788
6789 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6790
6791 * w32.c: Include <time.h>.
6792 (sys_localtime): New function.
6793
4ffd0d6b 67942011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
6795
6796 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6797
4ffd0d6b 6798 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 6799
4ffd0d6b 68002011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 6801
4ffd0d6b
GM
6802 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6803 zombies (Bug#8467).
aac0c6e3 6804
04c56954
EZ
68052011-04-19 Eli Zaretskii <eliz@gnu.org>
6806
6807 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6808 gl_state.e_property when gl_state.object is Qt.
6809
6810 * insdel.c (make_gap_larger): Remove limitation of buffer size
6811 to <= INT_MAX.
6812
16a43933
CY
68132011-04-18 Chong Yidong <cyd@stupidchicken.com>
6814
6815 * xdisp.c (lookup_glyphless_char_display)
6816 (produce_glyphless_glyph): Handle cons cell entry in
6817 glyphless-char-display.
6818 (Vglyphless_char_display): Document it.
6819
6820 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6821 glyphless-char-display.
6822
4581706e
CY
68232011-04-17 Chong Yidong <cyd@stupidchicken.com>
6824
6825 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6826
6827 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6828
6829 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6830 definition for no-X builds.
6831
4887c6e2 68322011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 6833
fd35b6f9
PE
6834 Static checks with GCC 4.6.0 and non-default toolkits.
6835
5c1ccb01
PE
6836 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6837
006c5daa
PE
6838 * process.c (keyboard_bit_set): Define only if SIGIO.
6839 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6840 (send_process): Repair possible setjmp clobbering.
6841
efc736d3
PE
6842 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6843
4e2fe2e6
PE
6844 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6845
f97334a2
PE
6846 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6847
4e75f29d
PE
6848 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6849 Define only if needed.
6850
90efadd1
PE
6851 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6852 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 6853 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 6854
3c647824
PE
6855 * dispextern.h (struct redisplay_interface): Rename param
6856 to avoid shadowing.
e264f262 6857 * termhooks.h (struct terminal): Likewise.
761383f4 6858 * xterm.c (xembed_send_message): Likewise.
3c647824 6859
b58c5c4a
PE
6860 * insdel.c (make_gap_smaller): Define only if
6861 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6862
cad59032
PE
6863 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6864 it.
6865
c339dc2e
PE
6866 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6867 so that we aren't warned about unused symbols.
6868
91a3e27b
PE
6869 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6870
399c71d3 6871 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 6872
8ffc96f5
PE
6873 * xfns.c (x_real_positions): Mark locals as initialized.
6874
eef9bc79
PE
6875 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6876
098db9dd
PE
6877 * xterm.c: Fix problems found by static analysis with other toolkits.
6878 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
6879 (x_dispatch_event): Declare static if USE_GTK, and
6880 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 6881 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 6882 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
6883 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6884 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 6885
eb18f6cc
PE
6886 * xmenu.c (menu_help_callback): Pointer type fixes.
6887 Use const pointers when pointing at readonly data. Avoid pointer
6888 signedness clashes.
6889 (FALSE): Remove unused macro.
6890 (update_frame_menubar): Remove unused decl.
6891
1fe72bf8
PE
6892 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6893
60d9e1db
PE
6894 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6895 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6896 (single_menu_item): Rename local to avoid shadowing.
6897
39261c26
PE
6898 * keyboard.c (make_lispy_event): Remove unused local var.
6899
018c5e19
PE
6900 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6901 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6902
63d2b86e
PE
6903 * bitmaps: Change bitmaps from unsigned char back to the X11
6904 compatible char. Avoid the old compiler warnings about
6905 out-of-range initializers by using, for example, '\xab' rather
6906 than 0xab.
6907
aefd87e1
PE
6908 * xgselect.c (xgselect_initialize): Check vs interface
6909 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6910
bf501fb9
PE
6911 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6912
e9829fdf
PE
6913 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6914 to read-only memory.
6915
1086c095
PE
6916 * fns.c (vector): Remove; this old hack is no longer needed.
6917
2baccd04 6918 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 6919 Remove unused var.
dde42981 6920 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 6921
72391843 6922 * xrdb.c (x_load_resources): Omit unused local.
3565b346 6923
436c16df 6924 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 6925 (x_window): Rename locals to avoid shadowing.
dc5ddd85 6926 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 6927
92bb796d 6928 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 6929 (x_term_init): Remove local to avoid shadowing.
92bb796d 6930
764430a3 6931 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
6932
6933 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6934 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6935
d1dfb56c
EZ
69362011-04-16 Eli Zaretskii <eliz@gnu.org>
6937
c4354cb4
EZ
6938 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6939
d1dfb56c
EZ
6940 Fix regex.c, syntax.c and friends for buffers > 2GB.
6941 * syntax.h (struct gl_state_s): Declare character position members
6942 EMACS_INT.
6943
6944 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6945
04f2d78b
CB
6946 * textprop.c (verify_interval_modification, interval_of):
6947 Declare arguments EMACS_INT.
d1dfb56c
EZ
6948
6949 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6950 EMACS_INT.
6951
6952 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6953
6954 * indent.c (Fvertical_motion): Local variable it_start is now
6955 EMACS_INT.
6956
6957 * regex.c (re_match, re_match_2, re_match_2_internal)
6958 (bcmp_translate, regcomp, regexec, print_double_string)
6959 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6960 (re_compile_pattern, re_exec): Declare arguments and local
6961 variables `size_t' and `ssize_t' and return values `regoff_t', as
6962 appropriate.
6963 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6964 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6965 <compile_stack_type>: `size' and `avail' are now `size_t'.
6966
6967 * regex.h <regoff_t>: Use ssize_t, not int.
6968 (re_search, re_search_2, re_match, re_match_2): Arguments that
6969 specify buffer/string position and length are now ssize_t and
6970 size_t. Return type is regoff_t.
6971
613052cd
BK
69722011-04-16 Ben Key <bkey76@gmail.com>
6973
6974 * nsfont.m: Fixed bugs in ns_get_family and
6975 ns_descriptor_to_entity that were caused by using free to
6976 deallocate memory blocks that were allocated by xmalloc (via
6977 xstrdup). This caused Emacs to crash when compiled with
6978 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6979 --enable-checking=xmallocoverrun). xfree is now used to
6980 deallocate these memory blocks.
6981
4170f62f 69822011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 6983
71b41406
PE
6984 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6985
9587a89d
PE
6986 emacs_write: Accept and return EMACS_INT for sizes.
6987 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6988 et seq.
6989 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6990 Accept and return EMACS_INT.
6991 (emacs_gnutls_write): Return the number of bytes written on
6992 partial writes.
6993 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
6994 (emacs_read, emacs_write): Remove check for negative size, as the
6995 Emacs source code has been audited now.
9587a89d
PE
6996 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6997 (emacs_read, emacs_write): Use it.
273a5f82
PE
6998 * process.c (send_process): Adjust to the new signatures of
6999 emacs_write and emacs_gnutls_write. Do not attempt to store
7000 a byte offset into an 'int'; it might overflow.
9587a89d 7001 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 7002
3e047f51
PE
7003 * sound.c: Don't assume sizes fit in 'int'.
7004 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 7005 Return EMACS_INT, not int.
3e047f51 7006 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
7007 Accept EMACS_INT, not int.
7008 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
7009 record read return values.
7010
cc39a9db
BK
70112011-04-15 Ben Key <bkey76@gmail.com>
7012
c9d0ec6d
JB
7013 * keyboard.c (Qundefined): Don't declare static since it is used
7014 in nsfns.m.
7015 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7016 static since they are used in nsfont.m.
cc39a9db 7017
6c60eb9f
SM
70182011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7019
7020 * process.c (Qprocessp): Don't declare static.
7021 * lisp.h (Qprocessp): Declare again.
7022
7990b61a
JB
70232011-04-15 Juanma Barranquero <lekktu@gmail.com>
7024
7025 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7026
5d4cb038
PE
70272011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7028
8bd7b830 7029 Improve C-level modularity by making more things 'static'.
cd64ea1d 7030
e3b27b31
PE
7031 Don't publish debugger-only interfaces to other modules.
7032 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7033 (verify_bytepos, count_markers): Move decls to the only modules
7034 that need them.
7035 * region-cache.h (pp_cache): Likewise.
7036 * window.h (check_all_windows): Likewise.
7037 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7038
5d4cb038
PE
7039 * sysdep.c (croak): Now static, if
7040 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7041 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
7042
7043 * alloc.c (refill_memory_reserve): Now static if
7044 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7045 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 7046
e87b6180
PE
7047 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7048 Define only if USE_LUCID.
7049
ac64929e
PE
7050 * xrdb.c (x_customization_string, x_rm_string): Now static.
7051
6f37259d
PE
7052 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7053 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7054
1683e3ab
PE
7055 * xdisp.c (draw_row_with_mouse_face): Now static.
7056 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7057
de9c2632
PE
7058 * window.h (check_all_windows): Mark externally visible.
7059
2b96acb7
PE
7060 * window.c (window_deletion_count): Now static.
7061
7062 * undo.c: Make symbols static if they're not exported.
7063 (last_undo_buffer, last_boundary_position, pending_boundary):
7064 Now static.
7065
50436f33
PE
7066 * textprop.c (interval_insert_behind_hooks): Now static.
7067 (interval_insert_in_front_hooks): Likewise.
7068
64520e5c
PE
7069 * term.c: Make symbols static if they're not exported.
7070 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7071 (max_frame_lines, tty_set_terminal_modes):
7072 (tty_reset_terminal_modes, tty_turn_off_highlight):
7073 (get_tty_terminal): Now static.
7074 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7075 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 7076 HAVE_WINDOW_SYSTEM.
64520e5c
PE
7077 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7078 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7079
1fa53021
PE
7080 * sysdep.c: Make symbols static if they're not exported.
7081 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7082 Now static.
7083 (sigprocmask_set, full_mask): Remove; unused.
7084 (wait_debugging): Mark as visible.
7085 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7086 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7087
d4b43b22
PE
7088 * syntax.c (syntax_temp): Define only if !__GNUC__.
7089
b7c513d0
PE
7090 * sound.c (current_sound_device, current_sound): Now static.
7091
989b29ad
PE
7092 * search.c (searchbufs, searchbuf_head): Now static.
7093
13a55a78
PE
7094 * scroll.c (scroll_cost): Remove; unused.
7095 * dispextern.h (scroll_cost): Remove decl.
7096
de68a1fc
PE
7097 * region-cache.h (pp_cache): Mark as externally visible.
7098
40ccffa6
PE
7099 * process.c: Make symbols static if they're not exported.
7100 (process_tick, update_tick, create_process, chan_process):
7101 (Vprocess_alist, proc_buffered_char, datagram_access):
7102 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7103 (deactivate_process): Mark defn as static, as well as decl.
7104 * lisp.h (create_process): Remove decl.
7105 * process.h (chan_process, Vprocess_alist): Remove decls.
7106
ad64fc97
PE
7107 * print.c: Make symbols static if they're not exported.
7108 (print_depth, new_backquote_output, being_printed, print_buffer):
7109 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7110 (print_interval, print_number_index, initial_stderr_stream):
7111 Now static.
7112 * lisp.h (Fprinc): Remove decl.
7113 (debug_output_compilation_hack): Mark as externally visible.
7114
adddb265
PE
7115 * sysdep.c (croak): Move decl from here to syssignal.h.
7116 * syssignal.h (croak): Put it here, so the API can be checked when
7117 'croak' is called from dissociate_if_controlling_tty.
7118
1717ede2
PE
7119 * minibuf.c: Make symbols static if they're not exported.
7120 (minibuf_save_list, choose_minibuf_frame): Now static.
7121 * lisp.h (choose_minibuf_frame): Remove decl.
7122
fa5fb2bc
PE
7123 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7124
1e3890d1
PE
7125 * lread.c: Make symbols static if they're not exported.
7126 (read_objects, initial_obarray, oblookup_last_bucket_number):
7127 Now static.
7128 (make_symbol): Remove; unused.
7129 * lisp.h (initial_obarray, make_symbol): Remove decls.
7130
8a1414fa
PE
7131 * keyboard.c: Make symbols static if they're not exported.
7132 (single_kboard, recent_keys_index, total_keys, recent_keys):
7133 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7134 (this_single_command_key_start, echoing, last_auto_save):
7135 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7136 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7137 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7138 (Vlispy_mouse_stem, double_click_count):
7139 Now static.
7140 (force_auto_save_soon): Define only if SIGDANGER.
7141 (ignore_mouse_drag_p): Now static if
7142 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7143 (print_help): Remove; unused.
7144 (stop_character, last_timer_event): Mark as externally visible.
7145 * keyboard.h (ignore_mouse_drag_p): Declare only if
7146 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7147 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7148 * lisp.h (echoing): Remove decl.
7149 (force_auto_save_soon): Declare only if SIGDANGER.
7150 * xdisp.c (redisplay_window): Simplify code, to make it more
7151 obvious that ignore_mouse_drag_p is not accessed if !defined
7152 USE_GTK && !defined HAVE_NS.
7153
93ea6e8f
PE
7154 * intervals.c: Make symbols static if they're not exported.
7155 (merge_properties_sticky, merge_interval_right, delete_interval):
7156 Now static.
7157 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7158
77382fcc
PE
7159 * insdel.c: Make symbols static if they're not exported.
7160 However, leave prepare_to_modify_buffer alone. It's never
7161 called from outside this function, but that appears to be a bug.
7162 (combine_after_change_list, combine_after_change_buffer):
4889fc82 7163 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
7164 (adjust_after_replace_noundo): Remove; unused.
7165 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 7166 (signal_before_change): Remove decls.
77382fcc 7167
9306c32e
PE
7168 * indent.c (val_compute_motion, val_vmotion): Now static.
7169
cd44d2eb
PE
7170 * image.c: Make symbols static if they're not exported.
7171 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7172 if USE_GTK.
7173 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7174 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7175
ad9a7a06
PE
7176 * fringe.c (standard_bitmaps): Now static.
7177 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7178
81626931
PE
7179 * frame.c: Make symbols static if they're not exported.
7180 (x_report_frame_params, make_terminal_frame): Now static.
7181 (get_frame_param): Now static, unless HAVE_NS.
7182 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7183 (x_get_resource_string): Remove; not used.
7184 * frame.h (make_terminal_frame, x_report_frame_params):
7185 (x_get_resource_string); Remove decls.
7186 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7187 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7188
239f9db9
PE
7189 * font.c, fontset.c: Make symbols static if they're not exported.
7190 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7191 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7192 * font.c (font_close_object): Now static.
7193 * font.h (font_close_object): Remove.
7194 * fontset.c (FONTSET_OBJLIST): Remove.
7195 (free_realized_fontset) #if-0 the body, which does nothing.
7196 (face_suitable_for_char_p): #if-0, as it's never called.
7197 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
7198 * xfaces.c (face_at_string_position):
7199 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
7200 since 0 is always ASCII.
7201
dfcf3579
PE
7202 * fns.c (weak_hash_tables): Now static.
7203
5045092b
PE
7204 * fileio.c: Make symbols static if they're not exported.
7205 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7206 (Vwrite_region_annotation_buffers): Now static.
7207
57a96f5c
PE
7208 * eval.c: Make symbols static if they're not exported.
7209 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7210 * lisp.h (backtrace_list): Remove decl.
7211
35f08c38
PE
7212 * emacs.c: Make symbols static if they're not exported.
7213 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7214 (fatal_error_code, fatal_error_signal_hook, standard_args):
7215 Now static.
7216 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7217 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7218 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7219 * lisp.h (fatal_error_signal_hook): Remove decl.
7220 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7221
f44bd759
PE
7222 * editfns.c: Move a (normally-unused) function to its only use.
7223 * editfns.c, lisp.h (get_operating_system_release): Remove.
7224 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7225 worth the hassle of breaking this out.
7226
b532497d
PE
7227 * xterm.c: Make symbols static if they're not exported.
7228 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7229 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7230 (x_destroy_window, x_delete_display):
7231 Now static.
7232 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7233 (x_mouse_leave): Remove; unused.
7234 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7235 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7236 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7237 Remove decls.
7238 (x_mouse_leave): Declare only if WINDOWSNT.
7239 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7240 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7241 USE_X_TOOLKIT.
7242
1675728f
PE
7243 * ftxfont.c: Make symbols static if they're not exported.
7244 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7245 HAVE_FREETYPE.
7246 * font.h (ftxfont_driver): Likewise.
7247
e4cebfca
PE
7248 * xfns.c: Make symbols static if they're not exported.
7249 (x_last_font_name, x_display_info_for_name):
7250 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7251 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7252 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7253 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7254 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7255 (last_show_tip_args): Now static.
7256 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7257 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7258 (x_screen_planes): Remove; unused.
7259 * dispextern.h (x_screen_planes): Remove decl.
7260
5bf46f05
PE
7261 * dispnew.c: Make symbols static if they're not exported.
7262 * dispextern.h (redraw_garbaged_frames, scrolling):
7263 (increment_row_positions): Remove.
7264 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7265 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7266 Now static.
7267 (redraw_garbaged_frames): Remove; unused.
7268
435f4c28
PE
7269 * xfaces.c: Make symbols static if they're not exported.
7270 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7271 Remove decls.
7272 * xterm.h (defined_color): Remove decls.
7273 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7274 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7275 (menu_face_changed_default, defined_color, free_realized_face):
7276 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7277 (ascii_face_of_lisp_face): Remove; unused.
7278
8524aef3
PE
7279 * xdisp.c: Make symbols static if they're not exported.
7280 * dispextern.h (scratch_glyph_row, window_box_edges):
7281 (glyph_to_pixel_coords, set_cursor_from_row):
7282 (get_next_display_element, set_iterator_to_next):
7283 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7284 (show_mouse_face): Remove decls
7285 * frame.h (message_buf_print): Likewise.
7286 * lisp.h (pop_message, set_message, check_point_in_composition):
7287 Likewise.
7288 * xterm.h (set_vertical_scroll_bar): Likewise.
7289 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7290 (message_buf_print, scratch_glyph_row, displayed_buffer):
7291 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7292 (get_next_display_element, show_mouse_face, window_box_edges):
7293 (frame_to_window_pixel_xy, check_point_in_composition):
7294 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7295 (glyph_to_pixel_coords): Remove; unused.
7296
16390cd2
PE
7297 * dired.c (file_name_completion): Now static.
7298
7299 * dbusbind.c (xd_in_read_queued_messages): Now static.
7300
a25f4dfa
PE
7301 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7302 * data.c (circular_list_error): Remove.
7303
14a9c8df
PE
7304 * commands.h (last_point_position, last_point_position_buffer):
7305 (last_point_position_window): Remove decls.
7306 * keyboard.c: Make these variables static.
7307
04f2d78b
CB
7308 * coding.h (coding, code_convert_region, encode_coding_gap):
7309 Remove decls.
74ab6df5
PE
7310 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7311 (iso_code_class, detect_coding, code_convert_region): Now static.
7312 (encode_coding_gap): Remove; unused.
7313
38dfbee1
PE
7314 * chartab.c (chartab_chars, chartab_bits): Now static.
7315
a2cb4e63
PE
7316 * charset.h (charset_iso_8859_1): Remove decl.
7317 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7318 Now static.
7319
127198fd
PE
7320 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7321 * ccl.c (Vccl_program_table): Now static.
7322 (check_ccl_update): Remove; unused.
7323
d85b608f
PE
7324 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7325 * category.h: ... from here.
7326 * category.c (check_category_table, set_category_set): Now static.
7327
31cd66f3
PE
7328 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7329 * lisp.h: Remove these decls.
7330
c358e587
PE
7331 * buffer.c (buffer_count): Remove unused var.
7332
e78aecca
PE
7333 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7334 so that it's not optimized away.
7335 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7336 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7337 exported only to the debugger.
7338
e192d7d3 7339 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 7340 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 7341
92470028
PE
7342 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7343 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7344 was inaccessible from Lisp.
7345 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7346 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7347
244ed907
PE
7348 alloc.c: Import and export fewer symbols, and remove unused items.
7349 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7350 is defined.
7351 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7352 it's not optimized away by whole-program optimization.
7353 (message_enable_multibyte, free_misc): Remove.
7354 (catchlist, handlerlist, mark_backtrace):
7355 Declare only if BYTE_MARK_STACK.
7356 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7357 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7358 (message_enable_multibyte): Remove decl.
7359 (free_misc, interval_free_list, float_block, float_block_index):
7360 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7361 (cons_free_list, last_marked_index):
7362 Now static.
7363 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7364 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7365 (mark_backtrace): Define only if BYTE_MARK_STACK.
7366 * xdisp.c (message_enable_multibyte): Now static.
7367
61c2b50e 7368 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
7369 This makes it easier for human readers (and static analyzers)
7370 to see whether these variables are used from other modules.
7371 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7372 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7373 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7374 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7375 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7376 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7377 * xmenu.c, xselect.c:
7378 Declare Q* vars static if they are not used in other modules.
7379 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7380 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7381 Remove decls of unexported vars.
7382 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7383
95c82688
PE
7384 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7385
16a97296
PE
7386 Make Emacs functions such as Fatom 'static' by default.
7387 This makes it easier for human readers (and static analyzers)
7388 to see whether these functions can be called from other modules.
7389 DEFUN now defines a static function. To make the function external
7390 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
7391 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7392 (Finit_image_library):
16a97296
PE
7393 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7394 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7395 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7396 Remove decls, since these functions are now static.
7397 (Funintern, Fget_internal_run_time): New decls, since these functions
7398 were already external.
95c82688 7399
16a97296
PE
7400 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7401 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7402 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7403 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7404 * keyboard.c, keymap.c, lread.c:
7405 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7406 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7407 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7408 Mark functions with DEFUE instead of DEFUN,
7409 if they are used in other modules.
7410 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7411 decls for now-static functions.
7412 * buffer.h (Fdelete_overlay): Remove decl.
7413 * callproc.c (Fgetenv_internal): Mark as internal.
7414 * composite.c (Fremove_list_of_text_properties): Remove decl.
7415 (Fcomposition_get_gstring): New forward static decl.
7416 * composite.h (Fcomposite_get_gstring): Remove decl.
7417 * dired.c (Ffile_attributes): New forward static decl.
7418 * doc.c (Fdocumntation_property): New forward static decl.
7419 * eval.c (Ffetch_bytecode): New forward static decl.
7420 (Funintern): Remove extern decl; now in .h file where it belongs.
7421 * fileio.c (Fmake_symbolic_link): New forward static decl.
7422 * image.c (Finit_image_library): New forward static decl.
7423 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7424 * intervals.h (Fprevious_property_change):
7425 (Fremove_list_of_text_properties): Remove decls.
7426 * keyboard.c (Fthis_command_keys): Remove decl.
7427 (Fcommand_execute): New forward static decl.
7428 * keymap.c (Flookup_key): New forward static decl.
7429 (Fcopy_keymap): Now static.
7430 * keymap.h (Flookup_key): Remove decl.
7431 * process.c (Fget_process): New forward static decl.
7432 (Fprocess_datagram_address): Mark as internal.
7433 * syntax.c (Fsyntax_table_p): New forward static decl.
7434 (skip_chars): Remove duplicate decl.
7435 * textprop.c (Fprevious_property_change): New forward static decl.
7436 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7437 Now internal.
7438 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7439 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7440
785bbd42
PE
7441 * editfns.c (Fformat): Remove unreachable code.
7442
8b913b57
AS
74432011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7444
7445 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7446 change. (Bug#8496)
7447
a6744a35
EZ
74482011-04-13 Eli Zaretskii <eliz@gnu.org>
7449
7450 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7451 when at ZV. (Bug#8487)
7452
e7974947
AS
74532011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7454
baad03f0
AS
7455 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7456 (Bug#8437)
7457 * keyboard.c (parse_tool_bar_item): Likewise.
7458 * sound.c (sound_cleanup, alsa_close): Likewise.
7459 * termcap.c (tgetent): Likewise.
7460 * xfns.c (x_default_font_parameter): Likewise.
7461 * xsettings.c (read_and_apply_settings): Likewise.
7462
e7974947
AS
7463 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7464 (overrun_check_free): Protoize.
7465
28272684
PE
74662011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7467
7468 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7469 since callers should never pass a negative size.
7470 Change the signature to match that of plain 'read' and 'write'; see
7471 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7472 * lisp.h: Update prototypes of emacs_write and emacs_read.
7473
11997c76
EZ
74742011-04-11 Eli Zaretskii <eliz@gnu.org>
7475
7476 * xdisp.c (redisplay_window): Don't try to determine the character
7477 position of the scroll margin if the window start point w->startp
e896f03c 7478 is outside the buffer's accessible region. (Bug#8468)
11997c76 7479
8a2cbd72
EZ
74802011-04-10 Eli Zaretskii <eliz@gnu.org>
7481
7482 Fix write-region and its subroutines for buffers > 2GB.
7483 * fileio.c (a_write, e_write): Modify declaration of arguments and
7484 local variables to support buffers larger than 2GB.
7485 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7486
7487 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7488 argument, local variables, and return value.
7489
7490 * lisp.h: Update prototypes of emacs_write and emacs_read.
7491
7492 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7493
4073e537 74942011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 7495
1ebfdcb6
PE
7496 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7497
b2ded58d
PE
7498 Fix more problems found by GCC 4.6.0's static checks.
7499
7d66342c
PE
7500 * xdisp.c (vmessage): Use a better test for character truncation.
7501
bbf47d44
PE
7502 * charset.c (load_charset_map): <, not <=, for optimization,
7503 and to avoid potential problems with integer overflow.
9248994d 7504 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 7505 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 7506 * editfns.c (Fformat): Likewise.
1e69125e 7507 * syntax.c (skip_chars): Likewise.
3befa583 7508
e3019616
PE
7509 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7510 This also lets GCC 4.6.0 generate slightly better loop code.
7511
becfa255
PE
7512 * callint.c (Fcall_interactively): <, not <=, for optimization.
7513 (Fcall_interactively): Count the number of arguments produced,
7514 not the number of arguments given. This is simpler and lets GCC
7515 4.6.0 generate slightly better code.
7516
dae0cd48
PE
7517 * ftfont.c: Distingish more carefully between FcChar8 and char.
7518 The previous code passed unsigned char * to a functions like
7519 strlen and xstrcasecmp that expect char *, which does not
7520 conform to the C standard.
7521 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7522 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7523 char * when the C standard requires it.
7524
76032d70
PE
7525 * keyboard.c (read_char): Remove unused var.
7526
eb3f1cc8
PE
7527 * eval.c: Port to Windows vsnprintf (Bug#8435).
7528 Include <limits.h>.
7529 (SIZE_MAX): Define if the headers do not.
7530 (verror): Do not give up if vsnprintf returns a negative count.
7531 Instead, grow the buffer. This ports to Windows vsnprintf, which
7532 does not conform to C99. Problem reported by Eli Zaretskii.
7533 Also, simplify the allocation scheme, by avoiding the need for
7534 calling realloc, and removing the ALLOCATED variable.
7535
70476b54
PE
7536 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7537
12020a9e
PE
7538 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7539 But keep the doprint source code for now, as we might revamp it
7540 and use it again (Bug#8435).
ea6c7ae6
PE
7541 * lisp.h (doprnt): Remove.
7542 * Makefile.in (base_obj): Remove doprnt.o.
7543 * deps.mk (doprnt.o): Remove.
7544
5fdb398c
PE
7545 error: Print 32- and 64-bit integers portably (Bug#8435).
7546 Without this change, on typical 64-bit hosts error ("...%d...", N)
7547 was used to print both 32- and 64-bit integers N, which relied on
7548 undefined behavior.
7549 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7550 New macro.
7551 * lisp.h (error, verror): Mark as printf-like functions.
7552 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7553 Report overflow in size calculations when allocating printf buffer.
7554 Do not truncate output string at its first null byte.
7555 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7556 Truncate the output at a character boundary, since vsnprintf does not
7557 do that.
7558 * charset.c (check_iso_charset_parameter): Convert internal
7559 character to string before calling 'error', since %c now has the
7560 printf meaning.
7561 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7562 overflow when computing char to be passed to 'error'. Do not
7563 pass Lisp_Object to 'error'; pass the integer instead.
7564 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7565 formatted with plain %d.
7566
b189fa66
PE
7567 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7568
bff87ef0
PE
7569 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7570
7e2cac20
PE
7571 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7572
ce4d90b5
PE
7573 * xterm.c (x_catch_errors): Remove duplicate declaration.
7574
266c9547
PE
7575 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7576
79c49ad2
PE
7577 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7578
368f4090
JM
75792011-04-10 Jim Meyering <meyering@redhat.com>
7580
7581 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7582 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7583 return ssize_t not "int", and use size_t as the buffer length.
7584 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7585 * gnutls.h: Update declarations.
7586 * process.c (read_process_output): Use ssize_t, to match.
7587 (send_process): Likewise.
7588
a32d4040
CY
75892011-04-09 Chong Yidong <cyd@stupidchicken.com>
7590
7591 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7592
8546720e 75932011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 7594
04f2d78b
CB
7595 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7596 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 7597
8546720e
GM
7598 * xterm.c (handle_one_xevent):
7599 * xmenu.c (create_and_show_popup_menu):
7600 * xselect.c (x_decline_selection_request)
7601 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 7602
0a2f5c1a 76032011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
7604
7605 Fix some uses of `int' instead of EMACS_INT.
7606 * search.c (string_match_1, fast_string_match)
7607 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7608 (scan_buffer, find_next_newline_no_quit)
7609 (find_before_next_newline, search_command, Freplace_match)
7610 (Fmatch_data): Make some `int' variables be EMACS_INT.
7611
7612 * xdisp.c (display_count_lines): 3rd argument and return value now
7613 EMACS_INT. All callers changed.
7614 (pint2hrstr): Last argument is now EMACS_INT.
7615
7616 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7617 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7618 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7619 (decode_coding_utf_16, decode_coding_emacs_mule)
7620 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7621 (decode_coding_ccl, decode_coding_charset)
7622 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7623 (decode_coding_iso_2022, decode_coding_emacs_mule)
7624 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7625 <char_offset, last_offset>: Declare EMACS_INT.
7626 (encode_coding_utf_8, encode_coding_utf_16)
7627 (encode_coding_emacs_mule, encode_invocation_designation)
7628 (encode_designation_at_bol, encode_coding_iso_2022)
7629 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7630 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7631 Declare EMACS_INT.
7632 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7633 (encode_invocation_designation): Last argument P_NCHARS is now
7634 EMACS_INT.
7635 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7636 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7637
7638 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7639 All users changed.
7640
7641 * ccl.c (Fccl_execute_on_string): Declare some variables
7642 EMACS_INT.
7643
8546720e 76442011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
7645
7646 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7647
4e19a977
CS
76482011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7649
7650 * process.c (Fformat_network_address): Doc fix.
7651
87302331
R
76522011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7653
ee7683eb 7654 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 7655
cbb59342
CY
76562011-04-08 Chong Yidong <cyd@stupidchicken.com>
7657
7658 * keyboard.c (read_char): Call Lisp function help-form-show,
7659 instead of using internal_with_output_to_temp_buffer.
7660 (Qhelp_form_show): New var.
e0d38eeb 7661 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
7662
7663 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7664
7665 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7666
e67a13ab
CY
76672011-04-06 Chong Yidong <cyd@stupidchicken.com>
7668
04f2d78b
CB
7669 * process.c (Flist_processes): Remove to Lisp.
7670 (list_processes_1): Delete.
e67a13ab 7671
973f782d
EZ
76722011-04-06 Eli Zaretskii <eliz@gnu.org>
7673
7c106b1e
EZ
7674 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7675
973f782d
EZ
7676 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7677
41cf7d1a 76782011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 7679
ca23cc88
PE
7680 Fix more problems found by GCC 4.6.0's static checks.
7681
f390e2d5
PE
7682 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7683
42eea0d0
PE
7684 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7685
b69769da 7686 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 7687
f9541e84
PE
7688 * xdisp.c (vmessage): Mark as a printf-like function.
7689
13841b55
PE
7690 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7691
c136c10f
PE
7692 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7693
5e2d4a30
PE
7694 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7695 printf-like functions.
7696 (tiff_load): Add casts to remove these marks before passing them
7697 to system-supplied API.
7698
583f48b9
PE
7699 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7700
b25d760e
PE
7701 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7702 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
7703 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7704 directly, rather than having caller test rule sign. This avoids
7705 some unnecessary tests.
7706 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7707 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7708 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 7709
bc7b6697 7710 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 7711 (xfont_open): Avoid unnecessary tests.
bc7b6697 7712
27ccc379
PE
7713 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7714
dcd5c89a
PE
7715 * composite.h, composite.c (composition_gstring_put_cache):
7716 Use EMACS_INT, not int, for length.
7717
b13a45c6
PE
7718 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7719 breaking out part of COMPOSITION_DECODE_RULE.
7720 (COMPOSITION_DECODE_RULE): Use it.
7721 * composite.c (get_composition_id): Remove unused local vars,
7722 by using the new macro.
7723
1e792e4d
PE
7724 * textprop.c (set_text_properties_1): Change while to do-while,
7725 since the condition is always true at first.
7726
dc6c6455 7727 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
7728 (interval_deletion_adjustment): Return unsigned value.
7729 All uses changed.
dc6c6455 7730
aba7731a
PE
7731 * process.c (list_processes_1, create_pty, read_process_output):
7732 (exec_sentinel): Remove vars that were set but not used.
afd4052b 7733 (create_pty): Remove unnecessary "volatile"s.
bc57d757 7734 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 7735 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 7736 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 7737
fdfc4bf3
PE
7738 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7739
fca8fe46 7740 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 7741 (update_syntax_table): Use unsigned instead of int.
fca8fe46 7742
06a0259a 7743 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 7744 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 7745 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 7746
e7b9e80f
PE
7747 * print.c (print_error_message): Avoid int overflow.
7748
56201685
PE
7749 * font.c (font_list_entities): Redo for clarity,
7750 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7751
78834453 7752 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 7753 (font_score): Avoid potential overflow in diff calculation.
78834453 7754
0bc0b309 7755 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 7756 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 7757
e610eaca
PE
7758 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7759
b895abce
PE
7760 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7761 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7762 can always succeed if overflow has undefined behavior.
7763
1f1d9321 7764 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 7765 (wordify): Omit three unnecessary tests.
1f1d9321 7766
c59478bc
PE
7767 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7768 All callers changed. This avoids the need for an unused var.
7769
79b73827
PE
7770 * casefiddle.c (casify_region): Remove var that is set but not used.
7771
a4db5dfe
PE
7772 * dired.c (file_name_completion): Remove var that is set but not used.
7773
43aae36e
PE
7774 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7775
2a47c44d 7776 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 7777 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 7778
a37c69bf
PE
7779 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7780 Check for integer overflow on size calculations.
7781
328ab8e7
PE
7782 * buffer.c (Fprevious_overlay_change): Remove var that is set
7783 but not used.
7784
e5a2a5cb
PE
7785 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7786 Remove vars that are set but not used.
8d84a6eb 7787 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 7788 (timer_check_2): Mark vars as initialized.
e5a2a5cb 7789
a60e5f68
PE
7790 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7791
f661cb61 7792 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 7793 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 7794
f0397f5a
PE
7795 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7796 that are set but not used.
7797
8664db06 7798 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 7799 if XCreateBitmapFromData fails (Bug#8410).
8664db06 7800
6abdaa4a
PE
7801 * xselect.c (x_get_local_selection, x_handle_property_notify):
7802 Remove vars that are set but not used.
7803
0ce7538d 7804 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 7805 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 7806
9ae848fc
PE
7807 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7808 Remove var that is set but not used.
0b918413
PE
7809 (scroll_bar_windows_size): Now size_t, not int.
7810 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7811 Check for overflow.
9ae848fc 7812
a5a62657
PE
7813 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7814 (map_tty_color) [!defined MSDOS]: Likewise.
7815
5c5cdd39
PE
7816 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7817
66ebf983
PE
7818 * coding.c: Remove vars that are set but not used.
7819 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7820 All callers changed.
7821 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7822 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7823 (decode_coding_charset): Remove vars that are set but not used.
7824
1be4d761
PE
7825 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7826 that is set but not used.
7827
47553fa8
PE
7828 * print.c (print_object): Remove var that is set but not used.
7829
1f7196bf 7830 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
7831 The gnulib version avoids calling malloc in the usual case,
7832 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7833 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7834 * filelock.c (current_lock_owner): Likewise.
7835 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7836 * sysdep.c: Include allocator.h, careadlinkat.h.
7837 (emacs_no_realloc_allocator): New static constant.
7838 (emacs_readlink): New function.
fdb61804
PE
7839 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7840 ../lib/careadlinkat.h.
d1fdcab7 7841
f84c17c7
SM
78422011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7843
7844 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7845 first non-nil return value).
7846
ef3862ad
JD
78472011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7848
7849 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7850 if not defined (Bug#8403).
7851
376a7006
JB
78522011-04-02 Juanma Barranquero <lekktu@gmail.com>
7853
7854 * xdisp.c (display_count_lines): Remove parameter `start',
7855 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7856 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7857 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7858 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7859 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7860 and thereabouts. All callers changed.
7861 (get_per_char_metric): Remove parameter `f', unused since
7862 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7863
6ca3801d
JM
78642011-04-02 Jim Meyering <meyering@redhat.com>
7865
7866 do not dereference NULL upon failed strdup
7867 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7868 (ns_get_family): Likewise.
7869
d8e2b5ba
JB
78702011-04-02 Juanma Barranquero <lekktu@gmail.com>
7871
7872 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7873
8c74fcbd
JD
78742011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7875
7876 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7877 later (Bug#8403).
7878
7200d79c
SM
78792011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7880
03408648 7881 Add lexical binding.
7200d79c 7882
03408648
SM
7883 * window.c (Ftemp_output_buffer_show): New fun.
7884 (Fsave_window_excursion):
7885 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7886
7887 * lread.c (lisp_file_lexically_bound_p): New function.
7888 (Fload): Bind Qlexical_binding.
7889 (readevalloop): Remove `evalfun' arg.
7890 Bind Qinternal_interpreter_environment.
7891 (Feval_buffer): Bind Qlexical_binding.
7892 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7893 Mark as dynamic.
7894 (syms_of_lread): Declare `lexical-binding'.
7895
7896 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7897
7898 * keyboard.c (eval_dyn): New fun.
7899 (menu_item_eval_property): Use it.
ca105506
SM
7900
7901 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 7902
03408648
SM
7903 * fns.c (concat, mapcar1): Accept byte-code-functions.
7904
7905 * eval.c (Fsetq): Handle lexical vars.
7906 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7907 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7908 (FletX, Flet): Obey lexical binding.
7909 (Fcommandp): Handle closures.
7910 (Feval): New `lexical' arg.
7911 (eval_sub): New function extracted from Feval. Use it almost
7912 everywhere where Feval was used. Look up vars in lexical env.
7913 Handle closures.
7914 (Ffunctionp): Move from subr.el.
7915 (Ffuncall): Handle closures.
7916 (apply_lambda): Remove `eval_flags'.
7917 (funcall_lambda): Handle closures and new byte-code-functions.
7918 (Fspecial_variable_p): New function.
7919 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7920 but without exporting it to Lisp.
23aba0ea 7921
23aba0ea 7922 * doc.c (Fdocumentation, store_function_docstring):
03408648 7923 * data.c (Finteractive_form): Handle closures.
23aba0ea 7924
03408648
SM
7925 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7926 interactive spec.
ba83908c 7927
04f2d78b
CB
7928 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7929 New byte-codes.
03408648
SM
7930 (exec_byte_code): New function extracted from Fbyte_code to handle new
7931 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 7932
03408648 7933 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 7934
03408648 7935 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 7936
e2abce01
JB
79372011-03-31 Juanma Barranquero <lekktu@gmail.com>
7938
7939 * xdisp.c (redisplay_internal): Fix prototype.
7940
63696a73 79412011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 7942
63696a73 7943 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
7944 (try_scrolling): Use it when setting scroll_limit.
7945 Limit scrolling to 100 screen lines.
63696a73
EZ
7946 (redisplay_window): Even when falling back on "recentering",
7947 position point in the window according to scroll-conservatively,
7948 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7949
7950 (try_scrolling): When point is above the window, allow searching
7951 as far as scroll_max, or one screenful, to compute vertical
7952 distance from PT to the scroll margin position. This prevents
7953 try_scrolling from unnecessarily failing when
7954 scroll-conservatively is set to a value slightly larger than the
7955 window height. Clean up the case of PT below the margin at bottom
7956 of window: scroll_max can no longer be INT_MAX. When aggressive
7957 scrolling is in use, don't let point enter the opposite scroll
7958 margin as result of the scroll.
7959 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
7960 threshold of 100 lines for never-recentering scrolling.
7961
e4cc2dfc
JB
79622011-03-31 Juanma Barranquero <lekktu@gmail.com>
7963
7964 * dispextern.h (move_it_by_lines):
7965 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7966 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7967 (message_log_check_duplicate): Remove parameters `prev_bol' and
7968 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7969 (redisplay_internal): Remove parameter `preserve_echo_area',
7970 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7971
7972 * indent.c (Fvertical_motion):
7973 * window.c (window_scroll_pixel_based, Frecenter):
7974 Don't pass `need_y_p' to `move_it_by_lines'.
7975
1c470562
SM
79762011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7977
44f230aa
SM
7978 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7979 steal a few bits to be more compact.
7980 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7981 Remove unneeded casts.
7982
1c470562
SM
7983 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7984
888adce9
ZK
79852011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7986
7987 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7988 binding" message (bug#7967).
7989
f838ed7b
PE
79902011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7991
77861b95
PE
7992 Fix more problems found by GCC 4.6.0's static checks.
7993
de6dbc14
PE
7994 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7995 Remove unused local var.
7996
f838ed7b
PE
7997 * editfns.c (Fmessage_box): Remove unused local var.
7998
792c7b2b
PE
7999 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8000 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8001 Omit unused local vars.
c499e557 8002 * window.c (shrink_windows): Omit unused local var.
b01a1c29 8003 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
8004 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8005 Omit unused local var.
8006
ba0165e1
PE
8007 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8008 Don't assume string length fits in int.
32ad8845 8009 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 8010 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 8011
3c59b4c9
PE
8012 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8013 instead of alloca (Bug#8344).
8014
a3eed478 8015 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 8016 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 8017
eb4d412d
PE
8018 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8019
1658b401
PE
8020 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8021 concerns.
8022
8023 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8024
8025 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 8026
9a2c6e05
PE
8027 * keyboard.c (syms_of_keyboard): Use the same style as later
8028 in this function when indexing through an array. This also
8029 works around GCC bug 48267.
8030
03d0a109
PE
8031 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8032
44f730c8
PE
8033 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8034
fe75f926
PE
8035 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8036 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8037
ffa8c828
PE
8038 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8039 This avoids undefined behavior on integer overflow, and is a bit
8040 more convenient anyway since it is compared to a size_t variable.
8041
c5101a77
PE
8042 Variadic C functions now count arguments with size_t, not int.
8043 This avoids an unnecessary limitation on 64-bit machines, which
8044 caused (substring ...) to crash on large vectors (Bug#8344).
8045 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8046 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 8047 All variadic functions and their callers changed accordingly.
c5101a77
PE
8048 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8049 * data.c (arith_driver, float_arith_driver): Likewise.
8050 * editfns.c (general_insert_function): Likewise.
8051 * eval.c (struct backtrace.nargs, interactive_p)
8052 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8053 (funcall_lambda, mark_backtrace): Likewise.
8054 * fns.c (concat): Likewise.
8055 * frame.c (x_set_frame_parameters): Likewise.
8056 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8057 0 if not found, not -1. All callers changed.
8058
dd3f25f7
PE
8059 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8060 (stack_copy_size): Now size_t, not int.
8061 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8062
461c2ab9
JB
80632011-03-28 Juanma Barranquero <lekktu@gmail.com>
8064
8065 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8066 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8067 All callers changed.
8068
8069 * lisp.h (multibyte_char_to_unibyte):
8070 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8071 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8072 * character.h (CHAR_TO_BYTE8):
8073 * cmds.c (internal_self_insert):
8074 * editfns.c (general_insert_function):
8075 * keymap.c (push_key_description):
8076 * search.c (Freplace_match):
8077 * xdisp.c (message_dolog, set_message_1): All callers changed.
8078
f6d62986
SM
80792011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8080
8081 * keyboard.c (safe_run_hook_funcall): New function.
8082 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8083 don't set the hook to nil, but remove the offending function instead.
8084 (Qcommand_hook_internal): Remove, unused.
8085 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8086 Vcommand_hook_internal.
8087
8088 * eval.c (enum run_hooks_condition): Remove.
8089 (funcall_nil, funcall_not): New functions.
8090 (run_hook_with_args): Call each function through a `funcall' argument.
8091 Remove `cond' argument, now redundant.
8092 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8093 (Frun_hook_with_args_until_failure): Adjust accordingly.
8094 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8095
1db5b1ad
JB
80962011-03-28 Juanma Barranquero <lekktu@gmail.com>
8097
8098 * dispextern.h (string_buffer_position): Remove declaration.
8099
8100 * print.c (strout): Remove parameter `multibyte', unused since
8101 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8102
8103 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8104 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8105 All callers changed.
8106
8107 * w32.c (_wsa_errlist): Use braces for struct initializers.
8108
8109 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8110 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8111 All callers changed.
8112 (string_buffer_position): Likewise. Also, make static (it's never
8113 used outside xdisp.c).
8114 (cursor_row_p): Remove parameter `w', unused since
8115 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8116 (decode_mode_spec): Remove parameter `precision', introduced during
8117 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8118 All callers changed.
8119
5ffb62aa
JD
81202011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8121
8122 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8123
461c2ab9 81242011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
8125
8126 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8127 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8128 (ns_update_auto_hide_menu_bar): New functions.
8129 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8130 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8131 ns_constrain_all_frames.
8132 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8133 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8134
5c380ffb
JD
81352011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8136
8137 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8138
9af30bdf
GM
81392011-03-27 Glenn Morris <rgm@gnu.org>
8140
8141 * syssignal.h: Replace RETSIGTYPE with void.
8142 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8143 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8144 Replace SIGTYPE with void everywhere.
8145 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8146 * s/template.h (SIGTYPE): Remove commented out definition.
8147
e2abce01
JB
81482011-03-26 Eli Zaretskii <eliz@gnu.org>
8149
8150 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8151 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8152
f868cd8a
JB
81532011-03-26 Juanma Barranquero <lekktu@gmail.com>
8154
59eb0929
JB
8155 * w32.c (read_unc_volume): Use parameter `henum', instead of
8156 global variable `wget_enum_handle'.
8157
8158 * keymap.c (describe_vector): Remove parameters `indices' and
8159 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8160 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8161
f868cd8a
JB
8162 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8163
8164 * keyboard.c (timer_check): Remove parameter `do_it_now',
8165 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8166 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8167 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8168
8169 * keyboard.c (read_char):
8170 * w32menu.c (w32_menu_display_help):
8171 * xmenu.c (show_help_event, menu_help_callback):
8172 Adjust calls to `show_help_echo'.
8173
8174 * gtkutil.c (xg_maybe_add_timer):
8175 * keyboard.c (readable_events):
8176 * process.c (wait_reading_process_output):
8177 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8178
8179 * insdel.c (adjust_markers_gap_motion):
8180 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8181 (gap_left, gap_right): Don't call it.
8182
2ecf6fdb
CY
81832011-03-25 Chong Yidong <cyd@stupidchicken.com>
8184
8185 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8186 incurred during fontification.
8187
6b1f9ba4
JB
81882011-03-25 Juanma Barranquero <lekktu@gmail.com>
8189
8190 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8191 (DEFVAR_PER_BUFFER): Don't pass it.
8192
8193 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8194 (scrolling_window): Don't pass it.
8195
0f4a96b5
JB
81962011-03-25 Juanma Barranquero <lekktu@gmail.com>
8197
8198 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8199
8200 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8201 and `suffix'.
8202 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8203 of variables specific to SELinux and computation of `encoded_absname'.
8204
8205 * image.c (XPutPixel): Remove unused variable `height'.
8206
8207 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8208
8209 * unexw32.c (get_section_info): Remove unused variable `section'.
8210
8211 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8212 (system_process_attributes): Remove unused variable `sess'.
8213 (sys_read): Remove unused variable `err'.
8214
8215 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8216 (w32_wnd_proc): Remove unused variable `isdead'.
8217 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8218 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8219 (x_create_tip_frame): Remove unused variable `tem'.
8220
8221 * w32inevt.c (w32_console_read_socket):
8222 Remove unused variable `no_events'.
8223
8224 * w32term.c (x_draw_composite_glyph_string_foreground):
8225 Remove unused variable `width'.
8226
1149507c
JB
82272011-03-24 Juanma Barranquero <lekktu@gmail.com>
8228
8229 * w32term.c (x_set_glyph_string_clipping):
8230 Don't pass uninitialized region to CombineRgn.
8231
9c88f339
JB
82322011-03-23 Juanma Barranquero <lekktu@gmail.com>
8233
8234 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8235 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8236 (Fx_close_connection): Remove unused variable `i'.
8237
8238 * w32font.c (w32font_draw): Return number of glyphs.
8239 (w32font_open_internal): Remove unused variable `i'.
8240 (w32font_driver): Add missing initializer.
8241
8242 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8243 (fill_in_menu): Remove unused variable `items_added'.
8244
8245 * w32term.c (last_mouse_press_frame): Remove static global variable.
8246 (w32_clip_to_row): Remove unused variable `f'.
8247 (x_delete_terminal): Remove unused variable `i'.
8248
8249 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8250 (NOTHING): Remove unused static global variable.
8251 (uniscribe_check_otf): Remove unused variable `table'.
8252 (uniscribe_font_driver): Add missing initializers.
8253
dee091a3
JD
82542011-03-23 Julien Danjou <julien@danjou.info>
8255
8256 * term.c (Fsuspend_tty, Fresume_tty):
8257 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8258 * window.c (temp_output_buffer_show):
8259 * insdel.c (signal_before_change):
8260 * frame.c (Fhandle_switch_frame):
8261 * fileio.c (Fdo_auto_save):
8262 * emacs.c (Fkill_emacs):
8263 * editfns.c (save_excursion_restore):
8264 * cmds.c (internal_self_insert):
8265 * callint.c (Fcall_interactively):
8266 * buffer.c (Fkill_all_local_variables):
8267 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8268 Use Frun_hooks.
0f4a96b5 8269 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 8270 unconditionally since it does the check itself.
dee091a3 8271
2c520ab5 82722011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 8273
c9c49752
PE
8274 Fix more problems found by GCC 4.5.2's static checks.
8275
8abc3f12
PE
8276 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8277 the first time through the loop, since we know p0 < p1 then.
8278 This also avoids a gcc -Wstrict-overflow warning.
8279
a2d26660
PE
8280 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8281 leading to a memory leak, possible in functions like
8282 load_charset_map_from_file that can allocate an unbounded number
b12ef411 8283 of objects (Bug#8318).
a2d26660 8284
916c72e9
PE
8285 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8286 that could (at least in theory) be that large.
8287
19ab8a18
PE
8288 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8289 This is less likely to overflow, and avoids undefined behavior if
8290 overflow does occur. All callers changed. Use strtoul to scan
8291 for the unsigned long integer.
b7cbbd6f
PE
8292 (pint2hrstr): Simplify and tune code slightly.
8293 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 8294
f0641eff
PE
8295 * scroll.c (do_scrolling): Work around GCC bug 48228.
8296 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8297
7f650bb9
PE
8298 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8299 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
8300 (validate_x_resource_name): Simplify count usage.
8301 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 8302
37dd57d1
PE
8303 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8304 fail (Bug#8306).
81e56e61 8305
699979fc 8306 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 8307
401bf9b4
PE
8308 * process.c (Fmake_network_process): Use socklen_t, not int,
8309 where POSIX says socklen_t is required in portable programs.
8310 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 8311 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
8312 (Fmake_network_process, server_accept_connection):
8313 (wait_reading_process_output, read_process_output):
8314 Likewise.
8315
b93aacde
PE
8316 * process.c: Rename or move locals to avoid shadowing.
8317 (list_processes_1, Fmake_network_process):
8318 (read_process_output_error_handler, exec_sentinel_error_handler):
8319 Rename or move locals.
4dc343ee 8320 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 8321 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 8322 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 8323 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 8324 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 8325
af8a867c 8326 Make tparam.h and terminfo.c consistent.
44f230aa
SM
8327 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8328 Include tparam.h instead, since it declares them.
af8a867c
PE
8329 * cm.h (PC): Remove extern decl; tparam.h now does this.
8330 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8331 * terminfo.c: Include tparam.h, to check interfaces.
8332 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8333 (tparam): Adjust signature to match interface in tparam.h;
8334 this removes some undefined behavior. Check that outstring and len
8335 are zero, which they always are with Emacs.
8336 * tparam.h (PC, BC, UP): New extern decls.
8337
0248044d 8338 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 8339 (xftfont_open): Rename locals to avoid shadowing.
0248044d 8340
8ff096c1 8341 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
8342 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8343 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 8344 (ftfont_list): Remove unused local.
49eaafba
PE
8345 (get_adstyle_property, ftfont_pattern_entity):
8346 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8347 Rename locals to avoid shadowing.
8ff096c1 8348
e2be39f6
PE
8349 * xfont.c (xfont_list_family): Mark var as initialized.
8350
c9735e30
PE
8351 * xml.c (make_dom): Now static.
8352
8f5201ae
PE
8353 * composite.c (composition_compute_stop_pos): Rename local to
8354 avoid shadowing.
b246f932
PE
8355 (composition_reseat_it): Remove unused locals.
8356 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 8357 (composition_update_it): Mark var as initialized.
11b61122
PE
8358 (find_automatic_composition): Mark vars as initialized,
8359 with a FIXME (Bug#8290).
8f5201ae 8360
760fbc2c
PE
8361 character.h: Rename locals to avoid shadowing.
8362 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8363 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8364 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8365 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8366 to avoid shadowing.
8367
ff08eb85
PE
8368 * textprop.c (property_change_between_p): Remove; unused.
8369
fc7bf025
PE
8370 * intervals.c (interval_start_pos): Now static.
8371
235d7abc
PE
8372 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8373
44f230aa
SM
8374 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8375 Rename locals to avoid shadowing.
3e7d6594 8376
50060332
PE
8377 * sound.c (wav_play, au_play, Fplay_sound_internal):
8378 Fix pointer signedness.
d01f234b 8379 (alsa_choose_format): Remove unused local var.
c83b8872
PE
8380 (wav_play): Initialize a variable to 0, to prevent undefined
8381 behavior (Bug#8278).
50060332 8382
c4fc4e30
PE
8383 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8384
918436ed
PE
8385 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8386
c939f91b
PE
8387 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8388 clobbering (Bug#8298).
b9c7f648
PE
8389 * sysdep.c (sys_subshell): Likewise.
8390 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 8391
6bd8c144
PE
8392 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8393 This should get cleaned up, so that child_setup has the
8394 same signature on all platforms.
8395
7710357c 8396 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 8397 (relocate_fd): Rename locals to avoid shadowing.
7710357c 8398
c59da222
CY
83992011-03-22 Chong Yidong <cyd@stupidchicken.com>
8400
8401 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8402 not to be necessary, and produces flickering.
8403
66b87493
GM
84042011-03-20 Glenn Morris <rgm@gnu.org>
8405
8406 * config.in: Remove file.
8407
45b6f6d5
JB
84082011-03-20 Juanma Barranquero <lekktu@gmail.com>
8409
8410 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8411 are now in src/globals.h.
8412 (syms_of_minibuf): Remove spurious & from previous change.
8413
cd394be1 84142011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
8415
8416 * minibuf.c (completing-read-function): New variable.
8417 (completing-read-default): Rename from completing-read.
8418 (completing-read): Call completing-read-function.
8419
b14e3e21
CY
84202011-03-19 Juanma Barranquero <lekktu@gmail.com>
8421
8422 * xfaces.c (Fx_load_color_file):
8423 Read color file from absolute filename (bug#8250).
8424
f2b726e6
JB
84252011-03-19 Juanma Barranquero <lekktu@gmail.com>
8426
8427 * makefile.w32-in: Update dependencies.
8428
09f6ff02
EZ
84292011-03-17 Eli Zaretskii <eliz@gnu.org>
8430
8431 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8432
29a6015a
PE
84332011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8434
a3a6c54e
PE
8435 Fix more problems found by GCC 4.5.2's static checks.
8436
b766f867
PE
8437 * process.c (make_serial_process_unwind, send_process_trap):
8438 (sigchld_handler): Now static.
8439
be02381c
PE
8440 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8441 That way, the code declares only the vars that it needs.
8442 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8443 * s/cygwin.h (PTY_ITERATION): Likewise.
8444 * s/darwin.h (PTY_ITERATION): Likewise.
8445 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8446
57048744
PE
8447 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8448 * process.c (allocate_pty): Don't declare stb unless it's needed.
8449
7914961c 8450 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
8451 (CONSTANTLIM): Remove; unused.
8452 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8453 Define only if needed.
7914961c 8454
b3967b18
PE
8455 * unexelf.c (unexec): Name an expression,
8456 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
8457 Use a different way to cause a compilation error if anyone uses
8458 n rather than nn, a way that does not involve shadowing.
73366a00 8459 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 8460
29a6015a
PE
8461 * deps.mk (unexalpha.o): Remove; unused.
8462
43cfc33e 8463 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 8464 * unexec.h: New file.
ce701a33
PE
8465 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8466 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8467 Depend on unexec.h.
8468 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8469 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8470 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 8471 Change as necessary to match prototype in unexec.h.
ce701a33 8472
01f44d5a
PE
8473 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8474 shadowing.
4f63c6bb 8475 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 8476
a6670b0b
PE
8477 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8478 Rename locals to avoid shadowing.
8479
cef2010d 8480 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 8481 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 8482
d4d7173a
PE
8483 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8484
f08b802a
PE
8485 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8486 warning when compiling print.c.
8487
3ddb0639
PE
8488 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8489 instead of using an uninitialized var.
5ad03b97 8490 (font_sort_entities): Mark var as initialized.
3ddb0639 8491
170a2692
PE
8492 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8493
e663c700
PE
8494 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8495 pointers to constants.
89bc529a 8496 (font_parse_fcname): Remove unused vars.
7b81e2d0 8497 (font_delete_unmatched): Now static.
ea838e10 8498 (font_get_spec): Remove; unused.
13a547c6
PE
8499 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8500 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8501 Rename or move locals to avoid shadowing.
e663c700 8502
2a80c887 8503 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 8504 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 8505
1384fa33 8506 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 8507 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 8508
8b2c52e9
PE
8509 * alloc.c (mark_backtrace): Move decl from here ...
8510 * lisp.h: ... to here, so that it can be checked.
8511
475545b5 8512 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 8513 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
8514 (lisp_indirect_variable): Name an expression,
8515 to avoid gcc -Wbad-function-cast warning.
1faed8ae 8516 (Fdefvar): Rename locals to avoid shadowing.
475545b5 8517
b1349114 8518 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 8519 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 8520 Use const pointer when appropriate.
b1349114 8521
a2928364
PE
8522 * lisp.h (get_system_name, get_operating_system_release):
8523 Move decls here, to check interfaces.
8524 * process.c (get_operating_system_release): Move decl to lisp.h.
8525 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
8526 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8527 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8528 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
8529 (Fformat_time_string, Fencode_time, Finsert_char):
8530 (Ftranslate_region_internal, Fformat):
8531 Rename or remove local vars to avoid shadowing.
9710023e 8532 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 8533
a415e694
PE
8534 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8535 avoid shadowing.
8536
8ef4622d
PE
8537 * lisp.h (eassert): Check that the argument compiles, even if
8538 ENABLE_CHECKING is not defined.
8539
946f9a5b
PE
8540 * data.c (Findirect_variable): Name an expression, to avoid
8541 gcc -Wbad-function-cast warning.
112396d6 8542 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 8543 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
8544 (Fmake_variable_buffer_local, Fmake_local_variable):
8545 Mark variables as initialized.
52746918 8546 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 8547
e5aab7e7 8548 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
8549 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8550 Rename locals to avoid shadowing.
dff45157
PE
8551 (mark_stack): Move local variables into the #ifdef region where
8552 they're used.
7bc26fdb
PE
8553 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8554 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8555 needed otherwise.
8556 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8557 (GC_STRING_CHARS): Remove; not used.
d40d4be1 8558 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 8559
e5aab7e7
PE
8560 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8561 avoids undefined behavior in theory.
8562
4da60324
PE
8563 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8564
88043301
PE
8565 Use functions, not macros, for up- and down-casing (Bug#8254).
8566 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8567 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8568 to use the following functions instead of these macros.
8569 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8570 EMACS_INT, since callers assume the returned value fits in int.
8571 (upcase1): Likewise, for UPCASE_TABLE.
8572 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 8573 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 8574 the race-condition problem in the old DOWNCASE.
88043301 8575
19ed5445
PE
8576 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8577 Rename locals to avoid shadowing.
8578 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
8579 (regex_compile, re_search_2, re_match_2_internal):
8580 Remove unused local vars.
952db0d7
PE
8581 (FREE_VAR): Rewrite so as not to use empty "else",
8582 which gcc can warn about.
da053e48 8583 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
8584 (RETALLOC_IF): Define only if needed.
8585 (WORDCHAR_P): Likewise. This one is never needed, but is used
8586 only in a comment talking about a compiler bug, so put inside
8587 the #if 0 of that comment.
8588 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8589 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8590 Remove; unused.
19ed5445 8591
1f3561e4 8592 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
8593 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8594 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 8595
ded6f8f7
PE
8596 * search.c (simple_search): Remove unused var.
8597
dbd37a95
PE
8598 * dired.c (compile_pattern): Move decl from here ...
8599 * lisp.h: ... to here, so that it can be checked.
8600 (struct re_registers): New forward decl.
8601
7e47afad
PE
8602 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8603
85f24f61
PE
8604 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8605 All uses changed.
8606 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8607 Rename locals to avoid shadowing.
5671df8f 8608 (Fvertical_motion): Mark locals as initialized.
85f24f61 8609
181aa2be 8610 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 8611 (casify_region): Mark local as initialized.
181aa2be 8612
930d429c
PE
8613 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8614
7082eac6
PE
8615 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8616 New macros, so that the caller can use some names other than
8617 gcpro1, gcpro2, etc.
8618 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8619 of the new macros.
8620 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8621 argument, for consistency with GCPRO2_VAR, etc: it is now the
8622 prefix of the variable, not the variable itself. All uses
8623 changed.
38b2c076
PE
8624 * dired.c (directory_files_internal, file_name_completion):
8625 Rename locals to avoid shadowing.
8626
15206ed9
PE
8627 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8628 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8629 dired.c's scmp function, had undefined behavior.
8630 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8631 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8632 * buffer.h: ... to here, because these macros use current_buffer,
8633 and the new implementation with inline functions needs to have
8634 current_buffer in scope now, rather than later when the macros
8635 are used.
8636 (downcase, upcase1): New static inline functions.
8637 (DOWNCASE, UPCASE1): Reimplement using these functions.
8638 This avoids undefined behavior in expressions like
8639 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8640 from race conditions in accessing the global variables
8641 case_temp1 and case_temp2.
8642 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8643 * lisp.h (case_temp1, case_temp2): Remove their decls.
8644 * character.h (ASCII_CHAR_P): Move from here ...
8645 * lisp.h: ... to here, so that the inline functions mentioned
8646 above can use them.
8647
4a6bea26
PE
8648 * dired.c (directory_files_internal_unwind): Now static.
8649
f14b7e14
PE
8650 * fileio.c (file_name_as_directory, directory_file_name):
8651 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8652 Now static.
2893f146
PE
8653 (file_name_as_directory): Use const pointers when appropriate.
8654 (Fexpand_file_name): Likewise. In particular, newdir might
8655 point at constant storage, so make it a const pointer.
fd4ead52 8656 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
8657 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8658 signedness issues.
f839df0c
PE
8659 (Fset_file_times, Finsert_file_contents, auto_save_error):
8660 Rename locals to avoid shadowing.
f14b7e14 8661
5716756e 8662 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
8663 (Ftry_completion, Fall_completions): Rename or remove locals
8664 to avoid shadowing.
5716756e 8665
b4c3046a
PE
8666 * marker.c (bytepos_to_charpos): Remove; unused.
8667
b45db522
PE
8668 * lisp.h (verify_bytepos, count_markers): New decls,
8669 so that gcc does not warn that these functions aren't declared.
8670
85876d07
PE
8671 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8672 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 8673 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 8674 (copy_text): Remove unused local var.
85876d07 8675
03d78a21 8676 * filelock.c (within_one_second): Now static.
b3dd38ab 8677 (lock_file_1): Rename local to avoid shadowing.
03d78a21 8678
5df8f01b
PE
8679 * buffer.c (fix_overlays_before): Mark locals as initialized.
8680 (fix_start_end_in_overlays): Likewise. This function should be
8681 simplified by using pointers-to-pointers, but that's a different
8682 matter.
b1d876f1 8683 (switch_to_buffer_1): Now static.
8f54f30a
PE
8684 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8685 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 8686
a70072c9 8687 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 8688 Fix pointer signedness issue.
edced198
PE
8689 (sys_subshell): Mark local as volatile if checking for lint,
8690 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 8691 (MAXPATHLEN): Define only if needed.
a70072c9 8692
a0977c44
PE
8693 * process.c (serial_open, serial_configure): Move decls from here ...
8694 * systty.h: ... to here, so that they can be checked.
8695
a884fdcc
PE
8696 * fns.c (get_random, seed_random): Move extern decls from here ...
8697 * lisp.h: ... to here, so that they can be checked.
8698
604efe86 8699 * sysdep.c (reset_io): Now static.
b8950c94 8700 (wait_for_termination_signal): Remove; unused.
604efe86 8701
38fc62d9
PE
8702 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8703 (copy_keymap_item, append_key, push_text_char_description):
8704 Now static.
1004a21a 8705 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 8706 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
8707 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8708 (describe_map_tree):
8709 Rename locals to avoid shadowing.
38fc62d9 8710
2f2650da
PE
8711 * keyboard.c: Declare functions static if they are not used elsewhere.
8712 (echo_char, echo_dash, cmd_error, top_level_2):
8713 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
8714 (read_char, kbd_buffer_get_event, make_lispy_position):
8715 (make_lispy_event, make_lispy_movement, apply_modifiers):
8716 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8717 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8718 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 8719 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 8720 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 8721
a053e86c 8722 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
8723 (mark_kboards): Move decl here ...
8724 * alloc.c (mark_kboards): ... from here.
a053e86c 8725
4752793e
PE
8726 * lisp.h (force_auto_save_soon): New decl.
8727
74f10ca7 8728 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
8729 (DEFINE_DUMMY_FUNCTION): New macro.
8730 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8731 Use it.
c03cd23f
PE
8732 (main): Add casts to avoid warnings
8733 if GCC considers string literals to be constants.
74f10ca7 8734
022e70d4
PE
8735 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8736
59d6fe83
PE
8737 * dbusbind.c: Pointer signedness fixes.
8738 (xd_signature, xd_append_arg, xd_initialize):
8739 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8740 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8741 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8742 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8743
78320123
PE
8744 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8745 if GCC considers string literals to be constants.
49cebcca 8746 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 8747
35ac2a97
SM
87482011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8749
fb103ca9
SM
8750 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8751 (print_preprocess, print_object): New macro to fix last change.
8752
35ac2a97
SM
8753 * print.c (print_preprocess): Don't forget font objects.
8754
62973b41
JB
87552011-03-16 Juanma Barranquero <lekktu@gmail.com>
8756
8757 * emacs.c (USAGE3): Doc fixes.
8758
0e48bb22
AS
87592011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8760
8761 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8762 structure.
8763
7684e57b
JB
87642011-03-14 Juanma Barranquero <lekktu@gmail.com>
8765
8766 * lisp.h (VWindow_system, Qfile_name_history):
8767 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8768 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8769 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8770
8771 * w32select.c: Don't #include "keyboard.h".
c96bbc66 8772 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
8773
8774 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8775 * w32console.c (detect_input_pending, read_input_pending)
8776 (encode_terminal_code):
8777 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8778 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8779 (w32_system_caret_y, Qfile_name_history):
8780 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8781 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8782 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8783 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8784 * w32proc.c (Qlocal, report_file_error):
8785 * w32term.c (Vwindow_system, updating_frame):
8786 * w32uniscribe.c (initialized, uniscribe_font_driver):
8787 Remove unneeded extern declarations.
8788
2aa46d6c
CY
87892011-03-14 Chong Yidong <cyd@stupidchicken.com>
8790
c96bbc66 8791 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 8792
cffc6f3b
CY
87932011-03-13 Chong Yidong <cyd@stupidchicken.com>
8794
8795 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8796 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8797 These macros can no longer be used for assignment.
8798
44f230aa
SM
8799 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8800 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
8801 (record_buffer_markers, fetch_buffer_markers): New functions for
8802 recording and fetching special buffer markers.
8803 (set_buffer_internal_1, set_buffer_temp): Use them.
8804
8805 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8806
8807 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8808
8809 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8810 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8811
8812 * xdisp.c (hscroll_window_tree):
8813 (reconsider_clip_changes): Use PT instead of BUF_PT.
8814
d251f04b
EZ
88152011-03-13 Eli Zaretskii <eliz@gnu.org>
8816
8817 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8818 $(EMACS_ROOT)/lib/intprops.h.
8819
f0c77cd1
PE
88202011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8821
3eca4629
PE
8822 Fix more problems found by GCC 4.5.2's static checks.
8823
7c86ee98
PE
8824 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8825 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
8826 (xg_free_frame_widgets): Make it clear that a local variable is
8827 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
8828 (gdk_window_get_screen): Make it clear that this macro is needed
8829 only if USE_GTK_TOOLTIP.
1e5524e7
PE
8830 (int_gtk_range_get_value): New function, which avoids a diagnostic
8831 from gcc -Wbad-function-cast.
8832 (xg_set_toolkit_scroll_bar_thumb): Use it.
8833 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8834 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
8835 (get_utf8_string, xg_get_file_with_chooser):
8836 Rename locals to avoid shadowing.
8837 (create_dialog): Move locals to avoid shadowing.
7c86ee98 8838
41729b81
PE
8839 * xgselect.c (xg_select): Remove unused var.
8840
f0c77cd1
PE
8841 * image.c (four_corners_best): Mark locals as initialized.
8842 (gif_load): Initialize transparent_p to zero (Bug#8238).
8843 Mark another local as initialized.
ec6cf4c6 8844 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 8845
ce0ad53d 8846 * image.c (clear_image_cache): Now static.
d5d5a617 8847 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 8848 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
8849 (x_edge_detection): Remove unnecessary cast that
8850 gcc -Wbad-function-cast diagnoses.
2037898d 8851 (gif_load): Fix pointer signedness.
6ae141d6
PE
8852 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8853 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 8854
33383987 88552011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 8856
d32df629
PE
8857 Improve quality of tests for time stamp overflow.
8858 For example, without this patch (encode-time 0 0 0 1 1
8859 1152921504606846976) returns the obviously-bogus value (-948597
8860 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8861 reports time overflow. See
8862 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
8863 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8864 * editfns.c: Include limits.h and intprops.h.
8865 (TIME_T_MIN, TIME_T_MAX): New macros.
8866 (time_overflow): Move earlier, to before first use.
8867 (hi_time, lo_time): New functions, for an accurate test for
8868 out-of-range times.
8869 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8870 (Fget_internal_run_time): Don't assume time_t fits in int.
8871 (make_time): Use list2 instead of Fcons twice.
8872 (Fdecode_time): More accurate test for out-of-range times.
8873 (check_tm_member): New function.
8874 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
8875 (lisp_time_argument): Don't rely on undefined left-shift and
8876 right-shift behavior when checking for time stamp overflow.
8be6f318 8877
fe31d94c
PE
8878 * editfns.c (time_overflow): New function, refactoring common code.
8879 (Fformat_time_string, Fdecode_time, Fencode_time):
8880 (Fcurrent_time_string): Use it.
8881
8be6f318
PE
8882 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8883 * dired.c (make_time): Move to ...
8884 * editfns.c (make_time): ... here.
8885 * systime.h: Note the move.
8886
09d9db2c 88872011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 8888
126bc0dc
YM
8889 * fringe.c (update_window_fringes): Remove unused variables.
8890
c47cbdfd
YM
8891 * unexmacosx.c (copy_data_segment): Also copy __got section.
8892 (Bug#8223)
8893
7ac80be9
EZ
88942011-03-12 Eli Zaretskii <eliz@gnu.org>
8895
c96bbc66 8896 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
8897 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8898 Constify `char *' arguments and their references according to
8899 prototypes in tparam.h.
8900
ecb0f94d 8901 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 8902
7ac80be9
EZ
8903 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8904 Adapt all references accordingly.
8905
8906 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8907
ef1fd07e
TT
89082011-03-11 Tom Tromey <tromey@redhat.com>
8909
8910 * buffer.c (syms_of_buffer): Remove obsolete comment.
8911
7ef4b50c
EZ
89122011-03-11 Eli Zaretskii <eliz@gnu.org>
8913
8914 * termhooks.h (encode_terminal_code): Declare prototype.
8915
8916 * msdos.c (encode_terminal_code): Don't declare prototype.
8917
8918 * term.c (encode_terminal_code): Now external again, used by
8919 w32console.c and msdos.c.
8920
44f230aa
SM
8921 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8922 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 8923
4b1ec863 89242011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 8925
1714f52b 8926 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 8927
4b1ec863
PE
8928 * fringe.c (update_window_fringes): Mark locals as initialized
8929 (Bug#8227).
8930 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 8931
524c7aa6
PE
8932 * alloc.c (mark_fringe_data): Move decl from here ...
8933 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8934 to check its interface.
8935 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8936
a5c0af81 8937 * fontset.c (free_realized_fontset): Now static.
7519b8cd 8938 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 8939 (fontset_font): Mark local as initialized.
a9a06e0b 8940 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 8941
b4716021
PE
8942 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8943
811e9bac 8944 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 8945 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
8946 (x_own_selection, Fx_disown_selection_internal): Rename locals
8947 to avoid shadowing.
8948 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 8949
7e3ab302
PE
8950 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8951 so that the caller can use some name other than gcpro1.
8952 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
8953 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8954 (Fx_backspace_delete_keys_p):
8955 Use them to avoid shadowing, and rename vars to avoid shadowing.
8956 (x_decode_color, x_set_name, x_window): Now static.
6b437900 8957 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 8958 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
8959 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8960 Remove unused locals.
7e3ab302
PE
8961 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8962 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8963 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8964 macros.
f78faa98 8965
e2b13473
PE
8966 * xterm.h (x_mouse_leave): New decl.
8967
77f23912
PE
8968 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8969 Remove unused functions.
cdf4ba58
PE
8970 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8971 (x_calc_absolute_position): Now static.
7411c686 8972 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 8973 Don't declare local "event" unless it's used.
ed7bf3a5
PE
8974 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8975 unless they are used.
38d0b34a
PE
8976 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8977 (x_fatal_error_signal): Remove; not used.
a6067996
PE
8978 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8979 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8980 (x_error_catcher, x_connection_closed, x_error_handler):
8981 (x_error_quitter, xembed_send_message, x_iconify_frame):
8982 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 8983 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 8984 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 8985
44f230aa
SM
8986 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8987 Rename or move locals to avoid shadowing.
6b463e58 8988 (tty_defined_color, merge_face_heights): Now static.
5967d051 8989 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
8990 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8991 does not deduce is never used uninitialized.
73719eba
PE
8992 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8993 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 8994
426994c3 8995 * terminal.c (store_terminal_param): Now static.
5489860b 8996
032f1620 8997 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 8998 (set_frame_menubar): Remove unused local.
d4323972 8999 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
9000 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9001 since they might point to immutable storage.
281585b0
PE
9002 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9003 since it's unused otherwise.
032f1620 9004
367c19e5 9005 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 9006 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
9007 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9008 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 9009 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
9010 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9011 does not deduce are never used uninitialized.
70739cbe 9012
07b48fa9
PE
9013 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9014
8868a238 9015 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
9016 * window.c (window_loop, size_window):
9017 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 9018
7e5cf297 9019 * window.c (display_buffer): Now static.
d6550a9f
PE
9020 (size_window): Mark variables that gcc -Wuninitialized
9021 does not deduce are never used uninitialized.
a586633d
PE
9022 * window.h (check_all_windows): New decl, to forestall
9023 gcc -Wmissing-prototypes diagnostic.
5b555da1 9024 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 9025
f6095868
PE
9026 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9027 shadowing.
9028 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
9029 Include <limits.h>.
9030 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9031 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
9032 (load_charset_map): Mark variables that gcc -Wuninitialized
9033 does not deduce are never used uninitialized.
53df7c11 9034 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 9035
f38b440c
PE
9036 * coding.c (coding_set_source, coding_set_destination):
9037 Use "else { /* comment */ }" rather than "else /* comment */;"
9038 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
9039 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9040 a block, when the outer 'i' will do.
9041 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9042 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9043 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9044 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9045 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9046 Rename locals to avoid shadowing.
9047 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
9048 * coding.c (emacs_mule_char, encode_invocation_designation):
9049 Now static, since they're not used elsewhere.
413bb2db 9050 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 9051 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
9052 (decode_coding_emacs_mule): Mark variables that gcc
9053 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
9054 (detect_coding_iso_2022): Initialize a local variable that might
9055 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 9056 this initialization is needed. (Bug#8211)
5f58e762
PE
9057 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9058 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9059 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9060 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9061 Remove unused macros.
f38b440c 9062
232b38b9 9063 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 9064 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 9065 * character.c (string_count_byte8): Likewise.
232b38b9 9066
fb90da1b
PE
9067 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9068 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9069
fb93dbc2
PE
9070 * chartab.c (copy_sub_char_table): Now static, since it's not used
9071 elsewhere.
5c156ace
PE
9072 (sub_char_table_ref_and_range, char_table_ref_and_range):
9073 Rename locals to avoid shadowing.
bbcd0949 9074 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 9075
7d3b3862 9076 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 9077 (BIDI_BOB): Remove unused macro.
7d3b3862 9078
6be7d3da
PE
9079 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9080 deduce are never used uninitialized.
c2ed9c8b 9081 * term.c (encode_terminal_code): Likewise.
6be7d3da 9082
75f8807f 9083 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 9084
50938595
PE
9085 * tparam.h: New file.
9086 * term.c, tparam.h: Include it.
9087 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9088 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9089 Move these decls to tparam.h, and make them agree with what
9090 is actually in tparam.c. The previous trick of using incompatible
9091 decls in different modules does not conform to the C standard.
9092 All callers of tparam changed to use tparam's actual API.
9093 * tparam.c (tparam1, tparam, tgoto):
9094 Use const pointers where appropriate.
9095
fbceeba2
PE
9096 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9097 * cm.h (struct cm): Likewise.
9098 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9099 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9100 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9101 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9102 (turn_on_face, init_tty): Likewise.
9103 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 9104
7f3f1250
PE
9105 * term.c (term_mouse_position): Rename local to avoid shadowing.
9106
e6ca6543
PE
9107 * alloc.c (mark_ttys): Move decl from here ...
9108 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9109
c40f8d15
AS
91102011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9111
9112 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9113
cfe0661d
JB
91142011-03-09 Juanma Barranquero <lekktu@gmail.com>
9115
9116 * search.c (compile_pattern_1): Remove argument regp, unused since
9117 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9118 (compile_pattern): Don't pass it.
9119
0afb4571
J
91202011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9121
9122 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9123 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9124 for ! HAVE_GTK3.
9125 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9126
9127 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9128
9129 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9130 gdk_window_get_screen, gdk_window_get_geometry,
9131 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9132 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9133 (xg_get_pixbuf_from_pixmap): New function.
9134 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9135 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9136 Call xg_get_pixbuf_from_pixmap instead of
9137 gdk_pixbuf_get_from_drawable.
9138 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9139 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9140 (xg_check_special_colors): Use GtkStyleContext and its functions
9141 for HAVE_GTK3.
9142 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9143 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9144 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
9145 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9146 Call gtk_widget_get_preferred_size.
0afb4571
J
9147 (xg_frame_resized): gdk_window_get_geometry only takes 5
9148 parameters.
44f230aa
SM
9149 (xg_win_to_widget, xg_event_is_for_menubar):
9150 Call gdk_x11_window_lookup_for_display.
0afb4571
J
9151 (xg_set_widget_bg): New function.
9152 (delete_cb): New function.
895009e1 9153 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 9154 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
9155 (xg_set_background_color): Call xg_set_widget_bg.
9156 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9157 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9158 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9159 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9160 if ! HAVE_GTK3.
9161 (update_frame_tool_bar): Call gtk_widget_hide.
9162 (xg_initialize): Use GDK_KEY_g.
9163
9164 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9165 if ! HAVE_GTK3
9166 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9167
9168 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9169 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9170 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9171
1c2cc4ef
JB
91722011-03-08 Juanma Barranquero <lekktu@gmail.com>
9173
9174 * w32xfns.c (select_palette): Check success of RealizePalette against
9175 GDI_ERROR, not zero.
9176
33383987 9177See ChangeLog.11 for earlier changes.
aac0c6e3
MR
9178
9179;; Local Variables:
9180;; coding: utf-8
aac0c6e3
MR
9181;; End:
9182
acaf905b 9183 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
9184
9185 This file is part of GNU Emacs.
9186
9187 GNU Emacs is free software: you can redistribute it and/or modify
9188 it under the terms of the GNU General Public License as published by
9189 the Free Software Foundation, either version 3 of the License, or
9190 (at your option) any later version.
9191
9192 GNU Emacs is distributed in the hope that it will be useful,
9193 but WITHOUT ANY WARRANTY; without even the implied warranty of
9194 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9195 GNU General Public License for more details.
9196
9197 You should have received a copy of the GNU General Public License
9198 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.