* src/frame.h (MOUSE_HL_INFO): Remove excess parens.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
021f2e1a
AS
12011-10-29 Andreas Schwab <schwab@linux-m68k.org>
2
3 * frame.h (MOUSE_HL_INFO): Remove excess parens.
4
8b058d44
EZ
52011-10-29 Eli Zaretskii <eliz@gnu.org>
6
7 Fix the `xbytecode' command.
8 * .gdbinit (xprintbytestr): New command.
9 (xwhichsymbols): Renamed from `which'; all callers changed.
10 (xbytecode): Print the byte-code string as well.
11
4452fb80
EZ
122011-10-29 Kim Storm <storm@cua.dk>
13
8b058d44
EZ
14 * alloc.c (which_symbols): New function.
15
21b72067
AS
162011-10-29 Andreas Schwab <schwab@linux-m68k.org>
17
18 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
19 line. (Bug#9903)
20
83ed7b5c
GM
212011-10-29 Glenn Morris <rgm@gnu.org>
22
23 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
24 Not clear what it was for, and it causes various bugs. (Bug#9839)
25
5a7a728b
EZ
262011-10-28 Eli Zaretskii <eliz@gnu.org>
27
28 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
29 possible random value that matches one of those tested as
30 condition to clear the mouse face.
31
d3d0842f
CY
322011-10-28 Chong Yidong <cyd@gnu.org>
33
34 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
35
31b39d13
DN
362011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
37
38 * window.c (make_window): Initialize phys_cursor_on_p.
39
9aba6043
SM
402011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
41
42 * lisp.h (struct Lisp_Symbol): Update comments.
43
c20992f4
JB
442011-10-28 Juanma Barranquero <lekktu@gmail.com>
45
46 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
47
db4f02f2
EZ
482011-10-28 Eli Zaretskii <eliz@gnu.org>
49
50 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
51 <oslsachem@gmail.com> for helping to debug this.
52
53 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
54 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
55 (g_b_init_get_glyph_outline_w): New static variables.
56 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
57 (GetGlyphOutlineW_Proc): New typedefs.
58 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
59 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
60 New functions.
61 (w32font_open_internal, compute_metrics):
62 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
63 instead of calling the "wide" APIs directly.
64
65 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
66
67 * w32.h (syms_of_w32font): Add prototype.
68
87e68db4
JB
692011-10-27 Juanma Barranquero <lekktu@gmail.com>
70
71 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
72 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
73 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
74 (Fmove_to_window_line): Doc fix.
75
435c1d67
CY
762011-10-27 Chong Yidong <cyd@gnu.org>
77
78 * process.c (make_process): Set gnutls_state to NULL.
79
80 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
81 non-NULL, regardless of GNUTLS_INITSTAGE.
82 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
83 an error. Set process slots as soon as we allocate them.
84
85 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
86
9c6c6f49
CY
872011-10-27 Chong Yidong <cyd@gnu.org>
88
9aba6043
SM
89 * gnutls.c (emacs_gnutls_deinit): New function.
90 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
91 (Fgnutls_deinit, Fgnutls_boot): Use it.
92
93 * process.c (make_process): Initialize GnuTLS credentials to NULL.
94 (deactivate_process): Call emacs_gnutls_deinit.
95
657d08d3
JB
962011-10-27 Juanma Barranquero <lekktu@gmail.com>
97
98 * image.c (x_create_x_image_and_pixmap):
99 * w32.c (sys_rename, w32_delayed_load):
100 * w32font.c (fill_in_logfont):
101 * w32reg.c (x_get_string_resource): Silence compiler warnings.
102
5430d399
JB
1032011-10-26 Juanma Barranquero <lekktu@gmail.com>
104
105 * w32fns.c (w32_default_color_map): New function,
106 extracted from Fw32_default_color_map.
a7ef684b 107 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 108
fe0055fa
PE
1092011-10-25 Paul Eggert <eggert@cs.ucla.edu>
110
111 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
112
e6346438
SM
1132011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
114
115 * keyboard.c (test_undefined): New function (bug#9751).
116 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
117
e112cc37
ET
1182011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
119
120 * sysdep.c (init_sys_modes): Fix the check for the controlling
121 terminal (Bug#6649).
122
7b5d6677
EZ
1232011-10-20 Eli Zaretskii <eliz@gnu.org>
124
125 * dispextern.h (struct bidi_it): New member next_en_type.
126
127 * bidi.c (bidi_line_init): Initialize the next_en_type member.
128 (bidi_resolve_explicit_1): When next_en_pos is valid for the
129 current character, check also for next_en_type being WEAK_EN.
130 (bidi_resolve_weak): Don't enter the expensive loop if the current
131 position is before next_en_pos. Record the bidi type of the first
132 non-ET, non-BN character we find, in addition to its position.
133 (bidi_level_of_next_char): Invalidate next_en_type when
134 next_en_pos is over-stepped.
135
7da0b018
PE
1362011-10-20 Paul Eggert <eggert@cs.ucla.edu>
137
138 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
139 * editfns.c: Rewrite current-time-zone so that it invokes
140 the equivalent of (format-time-string "%Z") to get the time zone name.
141 This fixes a bug when the time zone name contains characters that
142 need converting from the system time locale to Emacs internal format.
143 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
144 that patch fixed format-time-string to do the conversion, but
145 I forgot to fix current-time-zone.
146 (format_time_string): New function, containing most of
147 what Fformat_time_string used to contain.
148 (Fformat_time_string): Rewrite in terms of format_time_string.
149 This doesn't change this function's behavior.
150 (current-time-zone): Rewrite to use format_time_string.
151 This fixes the bug reported by Michael Schierl in
152 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
153 Jason Rumney's 2007-06-07 change worked around this bug, but
154 didn't fix it.
155 * systime.h (tzname, timezone): Remove no-longer-used declarations.
156
8547b010
EZ
1572011-10-19 Eli Zaretskii <eliz@gnu.org>
158
159 * xdisp.c (start_display): If the character at POS is displayed
160 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
161 (try_window_reusing_current_matrix): If a line ends in a display
162 vector or the next line starts in a display vector, continue
163 redrawing the window even though the character position of
164 start_row was reached.
8547b010
EZ
165 (Bug#9771, part 2)
166
4e948d15
CY
1672011-10-18 Chong Yidong <cyd@gnu.org>
168
169 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
170 with nobreak-char-display too.
171
4787455f
EZ
1722011-10-18 Eli Zaretskii <eliz@gnu.org>
173
174 Fix part 3 of bug#9771.
175 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
176 (bidi_resolve_neutral): Don't enter the expensive loop looking for
177 non-neutral characters if the current character is a paragraph
178 separator (a.k.a. Newline). This avoids running the same
179 expensive loop twice, once when we consume the preceding newline
180 and the other time when the line actually needs to be displayed.
181 Avoid the loop when we see neutrals on the base embedding level
182 following a character whose directionality is the same as the
183 paragraph's. This avoids running the expensive loop when a line
184 ends in a long sequence of neutrals, like control characters.
185 Add assertion against STRONG_AL type. Slightly rearrange code
186 that determines the type of a neutral given the first non-neutral
187 that follows it.
188 (bidi_level_of_next_char): Set next_en_pos to zero when
189 invalidating its info.
190
2c91f553
EZ
1912011-10-17 Eli Zaretskii <eliz@gnu.org>
192
193 * xdisp.c (push_display_prop): Determine whether to record string
194 or buffer position by IT->string, not by IT->method. Allow
195 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
196 (move_it_vertically_backward): Don't look for character position
197 immediately after the newline when in a continuation line.
198 (Bug#9771, part 1)
2c91f553 199
c7b08b0d
MR
2002011-10-15 Martin Rudalics <rudalics@gmx.at>
201
202 * window.c (coordinates_in_window): Rewrite and delabelize
203 vertical border check. (Bug#5357) (Bug#9618)
204
6b02f655
SM
2052011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
206
207 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
208 errors in XSetWindowBorder (bug#9310).
209
81d40c92
DA
2102011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
211
212 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
213 avoid crash when xmalloc overrun checking is enabled.
214
d4172c3b
EZ
2152011-10-13 Eli Zaretskii <eliz@gnu.org>
216
217 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
218 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
219 cursor motion with <left> and <right> arrow keys.
220
221 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
222 some callers set that themselves.
223
b00eea75
EZ
2242011-10-12 Eli Zaretskii <eliz@gnu.org>
225
226 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
227 display string and the previous row comes from the same string and
228 is empty. (Bug#9739) (Bug#9738)
229
8fe012c4
SM
2302011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
231
232 * doc.c (get_doc_string): Encode file name (bug#9735).
233
0074aef2
EZ
2342011-10-12 Eli Zaretskii <eliz@gnu.org>
235
79beb178
EZ
236 * bidi.c (bidi_level_of_next_char):
237 * xdisp.c (get_visually_first_element): Remove old incorrect
238 comments regarding the Unicode Line Separator character.
239
0074aef2
EZ
240 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
241
6e4b3fbe
DA
2422011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
243
244 * alloc.c (Fgc_status): Do not access beyond zombies array
245 boundary if nzombies > MAX_ZOMBIES.
246 * alloc.c (dump_zombies): Add missing format specifier.
247
0324f3af
PE
2482011-10-12 Paul Eggert <eggert@cs.ucla.edu>
249
b5525cac
PE
250 * xdisp.c (set_cursor_from_row): Simplify conditionals,
251 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
252
0324f3af
PE
253 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
254 Some packages use them to denote characters with modifiers.
255
e9b5f888
AS
2562011-10-11 Andreas Schwab <schwab@linux-m68k.org>
257
258 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
259 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
260 matching a pp-number. Rename parameter var to var1.
261
127827c0
SM
2622011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
263
264 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
265
c8fd3bd0
GM
2662011-10-08 Glenn Morris <rgm@gnu.org>
267
268 * callint.c (Fcall_interactively): Give a more explicit error for the
269 'c' case with a non-character input. (Bug#8479)
270
352ec8ff
EZ
2712011-10-08 Eli Zaretskii <eliz@gnu.org>
272
03669ccb
EZ
273 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
274 lines.
7061c986
EZ
275 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
276 lines that are hscrolled on the left.
03669ccb 277
352ec8ff
EZ
278 * dispnew.c (buffer_posn_from_coords): Account for a possible
279 presence of header-line. (Bug#4426)
280
a66cfb1c
SM
2812011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
282
6b02f655
SM
283 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
284 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 285
7c5ee88e
PE
2862011-10-07 Paul Eggert <eggert@cs.ucla.edu>
287
288 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
289 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
290 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
291 this makes Emacs dump core during garbage collection on rare
292 occasions. sizeof is obviously inferior to offsetof here, so
293 stick with offsetof.
294 (GC_POINTER_ALIGNMENT): New macro.
295 (mark_memory): Omit 3rd (offset) arg; caller changed.
296 Don't assume EMACS_INT alignment is the same as pointer alignment.
297
df1bbe5b
SM
2982011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
299
300 * keyboard.c (read_key_sequence_remapped): New var.
301 (read_key_sequence): Compute remapping in the right buffer.
302 (command_loop_1): Use read_key_sequence's remapping directly.
303
51553db6
SM
3042011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
305
32c1fffd
SM
306 * dired.c (file_name_completion): Don't expand file name.
307 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
308 before checking file name handler.
309
51553db6
SM
310 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
311 they've been requested explicitly (bug#9591).
312
b6bd1599 3132011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
314
315 * keymap.c (Fsingle_key_description): Use make_specified_string
316 instead of build_string to build string from push_key_description.
317 (Bug#5193)
318
f701dc2a
PE
3192011-09-30 Paul Eggert <eggert@cs.ucla.edu>
320
4222c55d
PE
321 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
322 This fixes a Y2038 bug on 64-bit hosts.
323 * buffer.c (reset_buffer):
324 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
325 (Fclear_buffer_auto_save_failure):
326 Use 0, not -1, to represent an unset failure time, since time_t
327 might not be signed.
328
f701dc2a
PE
329 Remove dependency on glibc malloc internals.
330 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
331 Move back here from lisp.h, but with their new implementations.
332 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
333 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
334 * charset.c (charset_table_init): New static var.
335 (syms_of_charset): Use it instead of xmalloc. This removes a
336 dependency on glibc malloc internals. See Eli Zaretskii's comment in
337 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
338 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
339 Move back to alloc.c.
340 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
341 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
342
9ceebf39
JD
3432011-09-30 Jan Djärv <jan.h.d@swipnet.se>
344
345 * nsterm.m (windowDidResize): Call x_set_window_size only when
346 ns_in_resize is true. Otherwise set pixelwidth/height and
347 call change_frame_size (Bug#9628).
348
cb993c58
PE
3492011-09-30 Paul Eggert <eggert@cs.ucla.edu>
350
3930c88b
PE
351 Port --enable-checking=all to Fedora 14 x86-64.
352 * charset.c (syms_of_charset): Also account for glibc malloc's
353 internal overhead when calculating the initial malloc maximum.
354
cb993c58
PE
355 Port --enable-checking=all to Fedora 14 x86.
356 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
357 Move to lisp.h.
358 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
359 (overrun_check_realloc, overrun_check_free):
360 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
361 That way, xmalloc returns a properly-aligned pointer even if
362 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
363 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
364 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
365 into account when calculating the initial malloc maximum.
366 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
367 Move here from alloc.c, so that charset.c can use it too.
368 Properly align; the old code wasn't right for common 32-bit hosts
369 when configured with --enable-checking=all.
370 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
371 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
372
31bed486
EZ
3732011-09-29 Eli Zaretskii <eliz@gnu.org>
374
04c70788 375 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
376 use EDOM.
377
fbcaa2f3
EZ
3782011-09-28 Eli Zaretskii <eliz@gnu.org>
379
380 * xdisp.c (compute_display_string_end): If there's no display
381 string at CHARPOS, return -1.
382
383 * bidi.c (bidi_fetch_char): When compute_display_string_end
384 returns a negative value, treat the character as a normal
385 character not covered by a display string. (Bug#9624)
386
a239d4e9
JB
3872011-09-28 Juanma Barranquero <lekktu@gmail.com>
388
389 * lread.c (Fread_from_string): Fix typo in docstring.
390
88652fd5
EZ
3912011-09-27 Eli Zaretskii <eliz@gnu.org>
392
393 * xdisp.c (handle_invisible_prop): If invisible text ends on a
394 newline, reseat the iterator instead of bidi-iterating there one
395 character at a time. (Bug#9610)
32c1fffd
SM
396 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
397 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 398
ed497dd4
AS
3992011-09-27 Andreas Schwab <schwab@linux-m68k.org>
400
401 * lread.c (readevalloop): Use correct code for NBSP.
402 (read1): Likewise. (Bug#9608)
403
b2bf61aa
MA
4042011-09-25 Michael Albinus <michael.albinus@gmx.de>
405
406 * dbusbind.c (Fdbus_register_signal): When service is not
407 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
408
32bbb17c
GM
4092011-09-25 Glenn Morris <rgm@gnu.org>
410
411 * buffer.c (truncate-lines): Doc fix.
412
94e0933e
CY
4132011-09-24 Chong Yidong <cyd@stupidchicken.com>
414
415 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
416 (Fset_window_next_buffers): Doc fix.
417
cddde921
GM
4182011-09-24 Glenn Morris <rgm@gnu.org>
419
420 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
421
1260aef1
PE
4222011-09-24 Paul Eggert <eggert@cs.ucla.edu>
423
25b4bfa0
PE
424 Fix minor problems found by static checking.
425 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
426 * indent.c (Fvertical_motion): Fix == vs = typo.
427
e3cbd34b
EZ
4282011-09-24 Eli Zaretskii <eliz@gnu.org>
429
a66cfb1c
SM
430 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
431 Default value is now t. Doc fix.
6bf7006f 432
e3cbd34b 433 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 434 logic when moving up, not only when moving down. Fix the
e3cbd34b 435 confusing name and values of the it_overshoot_expected variable;
32c1fffd 436 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
437
438 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
439 CHARPOS is covered by a display string which includes newlines.
440 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
441 is covered by a display string with embedded newlines.
442
a3de0cbd
MA
4432011-09-24 Michael Albinus <michael.albinus@gmx.de>
444
445 * dbusbind.c (Fdbus_register_signal): Add match rule to
446 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
447 (Fdbus_register_method, Vdbus_registered_objects_table):
448 Fix docstring.
a3de0cbd 449
b260039d
JM
4502011-09-24 Jim Meyering <meyering@redhat.com>
451
32c1fffd 452 do not ignore write error for any output size
b260039d
JM
453 The previous change was incomplete.
454 While it makes emacs --batch detect the vast majority of stdout
455 write failures, errors were still ignored whenever the output size is
456 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
457 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
458 && echo FAIL: ignored write error
459 FAIL: ignored write error
460 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
461 && echo FAIL: ignored write error
462 FAIL: ignored write error
463 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
464
8eca8a7c
AS
4652011-09-23 Andreas Schwab <schwab@linux-m68k.org>
466
467 * emacs.c (Fkill_emacs): In noninteractive mode exit
468 non-successfully if a write error occurred on stdout. (Bug#9574)
469
3341db62
EZ
4702011-09-21 Eli Zaretskii <eliz@gnu.org>
471
472 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
473 the xassert test.
474
475 * dispextern.h (struct it): Update the comment documenting what
476 can it->OBJECT be.
477
8c203dbf
EZ
4782011-09-20 Eli Zaretskii <eliz@gnu.org>
479
480 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
481 a display string, extend search for cursor position to end of row.
482 (find_row_edges): If the row ends in a newline from a display
483 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
484 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
485 (Fcurrent_bidi_paragraph_direction): Fix search for previous
486 non-empty line. Fixes confusing cursor motion with arrow keys at
487 the beginning of a line that starts with whitespace.
8c203dbf 488
a4824228
LMI
4892011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
490
491 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
492 (bug#9493).
493
33ed493b
CY
4942011-09-18 Chong Yidong <cyd@stupidchicken.com>
495
496 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
497 boolean (Bug#9154).
498
56cd55c8
EZ
4992011-09-18 Eli Zaretskii <eliz@gnu.org>
500
501 * xdisp.c (display_line): Record maximum and minimum buffer
502 positions even if no glyphs were produced (e.g., by a zero-width
503 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
504 buffer positions that will be removed from the glyph row because
505 they don't fit.
c02dcedf
EZ
506 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
507 column is beyond frame width: don't subtract 1 "pixel" when
508 computing width of the stretch.
3e62b7e0
EZ
509 (reseat_at_next_visible_line_start): Undo the change made on
510 2011-09-17 that saved paragraph information and restored it after
511 the call to `reseat'. (Bug#9545)
56cd55c8 512
5ed99d36 5132011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
514
515 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
516 and turn window cursor on if cleared (Bug#9415).
517
5ed99d36 5182011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
519
520 * search.c (boyer_moore): Take unibyte characters from pattern
521 literally. (Bug#9458)
522
9bade7b2
EZ
5232011-09-18 Eli Zaretskii <eliz@gnu.org>
524
525 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
526
e5e9d610
PE
5272011-09-18 Paul Eggert <eggert@cs.ucla.edu>
528
87e4427a
PE
529 Fix minor problem found by static checking.
530 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
531 initialized, to pacify gcc -Wuninitialized.
532
e5e9d610
PE
533 * fileio.c: Report proper errno when syscall falls.
534 (Finsert_file_contents): Save and restore errno,
535 so that report_file_error outputs the correct diagnostic.
536 (Fwrite_region) [CLASH_DETECTION]: Likewise.
537
a1674f0b
EZ
5382011-09-18 Eli Zaretskii <eliz@gnu.org>
539
540 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
541
fbfb6dd4
EZ
5422011-09-17 Eli Zaretskii <eliz@gnu.org>
543
544 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
545 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
546
bb187662
EZ
5472011-09-17 Eli Zaretskii <eliz@gnu.org>
548
1137e8b8 549 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 550 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
551
552 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
553 (bidi_find_paragraph_start): Search back for paragraph beginning
554 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
555 (bidi_move_to_visually_next): Only trigger paragraph-related
556 computations when the last character is a newline or at EOB, not
557 just any NEUTRAL_B. (Bug#9470)
558
bb187662
EZ
559 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
560 truncated lines if point is covered by a display string. (Bug#9524)
561
2e621251
PE
5622011-09-16 Paul Eggert <eggert@cs.ucla.edu>
563
564 * xselect.c: Relax test for outgoing X longs (Bug#9498).
565 (cons_to_x_long): New function.
566 (lisp_data_to_selection_data): Use it. Correct the test for
567 short-versus-long data; it was negated. Break out of vector
568 loop, for efficiency, when a long datum is discovered.
569
91a15bc6
SM
5702011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
571
572 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
573
b41c3a35
EZ
5742011-09-16 Eli Zaretskii <eliz@gnu.org>
575
576 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
577 GCC PR/17406) by declaring this function with external scope.
578
7812ba2d
PE
5792011-09-15 Paul Eggert <eggert@cs.ucla.edu>
580
581 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
582 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
583
cf7edc2a
AS
5842011-09-15 Andreas Schwab <schwab@linux-m68k.org>
585
586 * editfns.c (Fformat): Correctly handle text properties on "%%".
587
bd01620e
EZ
5882011-09-15 Eli Zaretskii <eliz@gnu.org>
589
590 * xterm.c (x_draw_composite_glyph_string_foreground):
591 * w32term.c (x_draw_composite_glyph_string_foreground):
592 * term.c (encode_terminal_code):
593 * composite.c (composition_update_it, get_composition_id):
594 * xdisp.c (get_next_display_element)
595 (fill_composite_glyph_string): Add comments about special meaning
596 of TAB characters in a composition.
597
a02719a3
PE
5982011-09-15 Paul Eggert <eggert@cs.ucla.edu>
599
600 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
601 This occurs when processing a multibyte format.
602 Problem reported by Wolfgang Jenker.
a02719a3 603
72589a3c
JB
6042011-09-15 Johan Bockgård <bojohan@gnu.org>
605
606 * xdisp.c (try_cursor_movement): Only check for exact match if
607 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
608
1c14176c
PE
6092011-09-14 Paul Eggert <eggert@cs.ucla.edu>
610
611 Remove unused external symbols.
612 * dispextern.h (calc_pixel_width_or_height): Remove decl.
613 * xdisp.c (calc_pixel_width_or_height): Now static.
614 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
615 * indent.c (check_display_width):
616 * w32term.c: Fix comment to match code.
617 * xterm.c, xterm.h (x_catching_errors): Remove.
618
d2eea5b5
PE
6192011-09-14 Paul Eggert <eggert@cs.ucla.edu>
620
621 * xselect.c: Use signed conversions more consistently (Bug#9498).
622 (selection_data_to_lisp_data): Assume incoming selection data are
623 signed integers, not unsigned. This is to be consistent with
624 outgoing selection data, which was modified to use signed integers
625 in as part of the fix to Bug#9196 in response to Jan D.'s comment
626 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
627 expects long, not unsigned long.
628
46888499
EZ
6292011-09-14 Eli Zaretskii <eliz@gnu.org>
630
631 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
632 computation of loop end. Reported by Johan Bockgård
633 <bojohan@gnu.org>.
634
ef8ef9fb
CY
6352011-09-13 Chong Yidong <cyd@stupidchicken.com>
636
637 * frame.c (Fother_visible_frames_p): Function deleted.
638
fa819fed
EZ
6392011-09-12 Eli Zaretskii <eliz@gnu.org>
640
641 * indent.c (compute_motion): Process display vector front to back
642 rather than the other way around. (Bug#2496)
643
2ba8e008
SM
6442011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
645
646 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
647
20f53c69
CY
6482011-09-11 Chong Yidong <cyd@stupidchicken.com>
649
650 * minibuf.c (Fread_from_minibuffer): Doc fix.
651
d562d7a4
EZ
6522011-09-11 Eli Zaretskii <eliz@gnu.org>
653
654 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
655 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
656
1c4d7f3d
LMI
6572011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
658
659 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
660 value for non-existent files.
661
b885bf36
EZ
6622011-09-11 Eli Zaretskii <eliz@gnu.org>
663
664 * fileio.c (Finsert_file_contents): If the file cannot be opened,
665 set its "size" to -1. This will set the modtime_size field of
666 the corresponding buffer to -1, which is what
667 verify-visited-file-modtime expects for files that do not exist.
668 (Bug#9139)
669
6612f0bf
PE
6702011-09-11 Paul Eggert <eggert@cs.ucla.edu>
671
672 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
673 here ...
674 * lisp.h: ... from here. push_key_description is no longer
675 defined in keyboard.c, so its declaration should not be in
676 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
677 logically belongs with push_key_description.
678
dfb3f755
PE
6792011-09-10 Paul Eggert <eggert@cs.ucla.edu>
680
681 * buffer.h: Include <sys/types.h> instead of <time.h>.
682 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
683 Problem reported by Herbert J. Skuhra.
684
3134906c
LMI
6852011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
686
687 * xml.c (parse_region): Make the parsing work for
688 non-comment-starting XML files again (bug#9144).
689
8d903f4e
AS
6902011-09-10 Andreas Schwab <schwab@linux-m68k.org>
691
692 * image.c (gif_load): Fix calculation of bottom and right corner.
693 (Bug#9468)
694
80ad64f4
EZ
6952011-09-10 Eli Zaretskii <eliz@gnu.org>
696
697 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
698 redisplay in small windows.
699
208a048d
EZ
7002011-09-09 Eli Zaretskii <eliz@gnu.org>
701
702 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
703
9b1c252e
MR
7042011-09-08 Martin Rudalics <rudalics@gmx.at>
705
706 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
707 Operate on live windows only.
708
2949f33b
JB
7092011-09-08 Juanma Barranquero <lekktu@gmail.com>
710
711 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
712
e08dcafd
EZ
7132011-09-07 Eli Zaretskii <eliz@gnu.org>
714
715 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
716 only under bidi iteration.
717
115b96bd
JD
7182011-09-07 Jan Djärv <jan.h.d@swipnet.se>
719
720 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
721
c8199d0f
PE
7222011-09-06 Paul Eggert <eggert@cs.ucla.edu>
723
724 isnan: Fix porting problem to Solaris 10 with bundled gcc.
725 Without this fix, the command to link temacs failed due to an
726 undefined symbol __builtin_isnan. This is because
727 /usr/include/iso/math_c99.h #defines isnan(x) to
728 __builtin_isnan(x), but the bundled gcc, which identifies itself
729 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
730 a __builtin_isnan.
731 * floatfns.c (isnan): #undef, and then #define to a clone of
732 what's in data.c.
733 (Fisnan): Always define, since it's always available now.
734 (syms_of_floatfns): Always define isnan at the Lisp level.
735
e39b275c 7362011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
737
738 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
739
b2db44d9 7402011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 741
f4af5137 742 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
743 The previous code assumed that file offsets (off_t values) fit in
744 EMACS_INT variables, which is not true on typical 32-bit hosts.
745 The code messed up by falsely reporting buffer overflow in cases
746 such as (insert-file-contents "big" nil 1 2) into an empty buffer
747 when "big" contains more than 2**29 bytes, even though this
748 inserts just one byte and does not overflow the buffer.
749 (Finsert_file_contents): Store file offsets as off_t
750 values, not as EMACS_INT values. Check for overflow when
751 converting between EMACS_INT and off_t. When checking for
752 buffer overflow or for overlap, take the offsets into account.
753 Don't use EMACS_INT for small values where int suffices.
754 When checking for overlap, fix a typo: ZV was used where
755 ZV_BYTE was intended.
756 (Fwrite_region): Don't assume off_t fits into 'long'.
757 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
758
ecfc0a49
MA
7592011-09-05 Michael Albinus <michael.albinus@gmx.de>
760
761 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
762
6511acf2 7632011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 764
0999621a 765 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
766
767 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 768 (esprintf, exprintf, evxprintf): New functions.
62f19c19 769 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 770 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
771 (modify_event_symbol): Do not assume that the length of
772 name_alist_or_stem is safe to alloca and fits in int.
773 (Fexecute_extended_command): Likewise for function name and binding.
774 (Frecursion_depth): Wrap around reliably on integer overflow.
775 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
776 since some callers pass EMACS_INT values.
777 (Fsingle_key_description): Don't crash if symbol name contains more
778 than MAX_ALLOCA bytes.
779 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
780 (get_minibuffer): Arg is now EMACS_INT, not int.
781 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 782 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
783 * window.h (command_loop_level, minibuf_level): Reflect API changes.
784
2be7d702
PE
785 * dbusbind.c (signature_cat): New function.
786 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
787 Do not overrun buffer; instead, report string overflow.
788
9d1df220
PE
789 * dispnew.c (add_window_display_history): Don't overrun buffer.
790 Truncate instead; this is OK since it's just a log.
791
33ef5c64
PE
792 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
793 even if the time zone offset is outlandishly large.
794 Don't mishandle offset == INT_MIN.
795
66c6fdd5
PE
796 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
797 when creating daemon; the previous buffer-overflow check was incorrect.
798
d749b01b
PE
799 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
800 which has the guts of the old verror function.
801
b5cd1905
PE
802 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
803 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
804
6e1a67fb
PE
805 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
806 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 807 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 808 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
809 length of string rather than counting it via multiple sprintfs;
810 that's simpler and more reliable.
c21721cc
PE
811 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
812 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
813 sprintf, in case result does not fit in int.
814
c57b67fc
PE
815 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
816 (fontset_from_font): Print it.
817
8a401434
PE
818 * frame.c (tty_frame_count): Now printmax_t, not int.
819 (make_terminal_frame, set_term_frame_name): Print it.
820 (x_report_frame_params): In X, window IDs are unsigned long,
821 not signed long, so print them as unsigned.
822 (validate_x_resource_name): Check for implausibly long names,
823 and don't assume name length fits in 'int'.
824 (x_get_resource_string): Don't blindly alloca invocation name;
825 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
826 not fit in int.
827
6e1a67fb
PE
828 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
829 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
830 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
831
0df02bf3
PE
832 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
833 Use esprintf, not sprintf, in case result does not fit in int.
834
48e30793
PE
835 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
836 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
837 it as a large positive number.
838 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
839 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
840
a66ff6d8
PE
841 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
842 in case result does not fit in int.
843
aca216ff
PE
844 * print.c (float_to_string): Detect width overflow more reliably.
845 (print_object): Make sprintf buffer a bit bigger, to avoid potential
846 buffer overrun. Don't assume list length fits in 'int'. Treat
847 print length of 0 as 0, not as infinity; to be consistent with other
848 uses of print length in this function. Don't overflow print length
849 index. Don't assume hash table size fits in 'long', or that
850 vectorlike size fits in 'unsigned long'.
851
31c286f7
PE
852 * process.c (make_process): Use printmax_t, not int, to format
853 process-name gensyms.
854
55e5faa1
PE
855 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
856
80f2e268
PE
857 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
858 to avoid potential buffer overrun.
859
670741ab
PE
860 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
861 if X resource line is longer than 512 bytes.
862
b7163a50
PE
863 * xfns.c (x_window): Make sprintf buffer a bit bigger
864 to avoid potential buffer overrun.
865
ae58ff1f
PE
866 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
867
c43c8a6a
PE
868 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
869
3f8236f4
PE
8702011-09-04 Paul Eggert <eggert@cs.ucla.edu>
871
53e9fe90 872 Integer overflow fixes for scrolling, etc.
6511acf2
PE
873 Without these, Emacs silently mishandles large integers sometimes.
874 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
875 it were "C-u 1 M-x recenter" on a typical 64-bit host.
876
6511acf2
PE
877 * xdisp.c (try_window_id): Check Emacs fixnum range before
878 converting to 'int'.
806add1d 879
6511acf2 880 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
881 Check that an Emacs fixnum is in range before assigning it to 'int'.
882 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
883 values converted from Emacs fixnums.
884 (Frecenter): Don't wrap around a line count if it is out of 'int'
885 range; instead, treat it as an extreme value.
886 (Fset_window_configuration, compare_window_configurations):
887 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
888
6511acf2
PE
889 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
890 that can exceed INT_MAX. Check that EMACS_INT value is in range
891 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
892 (match_limit): Don't assume that a fixnum can fit in 'int'.
893
6511acf2 894 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
895 exceed INT_MAX.
896
6511acf2 897 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
898 (Fvertical_motion): Don't wrap around LINES values that don't fit
899 in 'int'. Instead, treat them as extreme values. This is good
900 enough for windows, which can't have more than INT_MAX lines anyway.
901
fcb901a7
LMI
9022011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
903
0f2f6b6d
LMI
904 * Require libxml/parser.h to avoid compilation warning.
905
fcb901a7
LMI
906 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
907
908 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
909 since this reportedly can destroy thread storage.
910
6e20a0d4
CY
9112011-08-30 Chong Yidong <cyd@stupidchicken.com>
912
913 * syntax.c (find_defun_start): Update all cache variables if
914 exiting early (Bug#9401).
915
148ae00e
EZ
9162011-08-30 Eli Zaretskii <eliz@gnu.org>
917
f6cfbd8f
EZ
918 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
919
148ae00e
EZ
920 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
921 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
922 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
923
924 * term.c (tty_append_glyph): New function.
925 (produce_stretch_glyph): Static function and its prototype deleted.
926
a66cfb1c
SM
927 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
928 Add prototypes.
148ae00e 929
c4a07a4c
PE
9302011-08-29 Paul Eggert <eggert@cs.ucla.edu>
931
932 * image.c (parse_image_spec): Check for nonnegative, not for positive,
933 when checking :margin (Bug#9390).
934 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 935 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
936 so that the name doesn't mislead. All uses changed.
937
6bc8cd65
JB
9382011-08-28 Johan Bockgård <bojohan@gnu.org>
939
940 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
941 set_tty_hooks.
942
dca4927e
EZ
9432011-08-27 Eli Zaretskii <eliz@gnu.org>
944
945 * xdisp.c (move_it_to): Don't bail out early when reaching
946 position beyond to_charpos, if we are scanning backwards.
947 (move_it_vertically_backward): When DY == 0, make sure we get to
948 the first character in the line after the newline.
949
f2cad773
PE
9502011-08-27 Paul Eggert <eggert@cs.ucla.edu>
951
952 * ccl.c: Improve and simplify overflow checking (Bug#9196).
953 (ccl_driver): Do not generate an out-of-range pointer.
954 (Fccl_execute_on_string): Remove unnecessary check for
955 integer overflow, noted by Stefan Monnier in
956 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
957 Remove a FIXME that didn't need fixing.
958 Simplify the newly-introduced buffer reallocation code.
959
0cae2cdb
JB
9602011-08-27 Juanma Barranquero <lekktu@gmail.com>
961
962 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
963
5fc295a4 9642011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 965
70c60eb2 966 Integer and memory overflow issues (Bug#9196).
726e0ab1 967
d31850da
PE
968 * doc.c (get_doc_string): Rework so that
969 get_doc_string_buffer_size is the actual buffer size, rather than
970 being 1 less than the actual buffer size; this makes xpalloc more
971 convenient.
972
a69fbedb
PE
973 * image.c (x_allocate_bitmap_record, cache_image):
974 * xselect.c (Fx_register_dnd_atom):
975 Simplify previous changes by using xpalloc.
976
fe5c5d37
PE
977 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
978 since either will do and ptrdiff_t is convenient with xpalloc.
979
0065d054
PE
980 * charset.c (charset_table_size)
981 (struct charset_sort_data.priority): Now ptrdiff_t.
982 (charset_compare): Don't overflow if priorities differ greatly.
983 (Fsort_charsets): Don't assume list length fits in int.
984 Check for size-calculation overflow when allocating sort data.
985 (syms_of_charset): Allocate an initial charset table that is
986 just under 64 KiB, to avoid problems with glibc malloc and mmap.
987
988 * cmds.c (internal_self_insert): Check for size-calculation overflow.
989
990 * composite.h (struct composition.glyph_len): Now int, not unsigned.
991 The actual value is always <= INT_MAX, and leaving it unsigned made
992 overflow checking harder.
993
994 * dispextern.h (struct glyph_matrix.rows_allocated)
995 (struct face_cache.size): Now ptrdiff_t, for convenience in use
996 with xpalloc. The values are still always <= INT_MAX.
997
998 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
999
1000 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1001 (SAFE_NALLOCA): New macro.
1002
1003 * region-cache.c (struct boundary.pos, find_cache_boundary)
1004 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1005 (set_cache_region, invalidate_region_cache)
1006 (revalidate_region_cache, know_region_cache, region_cache_forward)
1007 (region_cache_backward, pp_cache):
1008 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1009 so that ptrdiff_t * can be passed to xpalloc.
1010 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1011 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1012 (pp_cache): Don't assume cache_len fits in int.
1013 * region-cache.h: Adjust extern decls to match.
1014
1015 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1016 EMACS_INT, since either will do, for xpalloc.
1017
1018 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1019 (xnmalloc, xnrealloc, xpalloc): New functions.
1020
726e0ab1
PE
1021 * bidi.c (bidi_shelve_header_size): New constant.
1022 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1023 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1024
51f30bc5 1025 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
1026 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1027 (overlay_strings):
1028 Don't update size of array until after memory allocation succeeds,
1029 because xmalloc/xrealloc may not return.
0065d054
PE
1030 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1031 now that we have proper integer overflow checking.
1032 (record_overlay_string, overlay_strings): Catch overflows when
1033 calculating size of overlay_str_buf.
726e0ab1 1034
0065d054
PE
1035 * callproc.c (Fcall_process): Check for size overflow when
1036 calculating size of args2.
1037 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1038 Normally we prefer signed values, but sticking with ptrdiff_t would
1039 require adding more-complicated checks.
726e0ab1
PE
1040
1041 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1042 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1043 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 1044 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
1045
1046 * character.c (Fstring): Check for size-calculation overflow.
1047
1048 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1049 unnecessary integer overflow. Check for size overflow.
1050 (encode_coding_object): Don't update size until xmalloc succeeds.
1051
1052 * composite.c (get_composition_id): Check for overflow in glyph
1053 length calculations.
1054
1055 Integer and memory overflow fixes for display code.
1056 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1057 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1058 (scrolling_window): Check for overflow in size calculations.
1059 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1060 Don't assume glyph table len fits in int.
1061 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1062 (row_table_size): Now ptrdiff_t, not int.
1063 (scrolling_window): Avoid overflow in size calculations.
1064 Don't update size until allocation succeeds.
1065 * fns.c (concat): Check for overflow in size calculations.
1066 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1067 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1068 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1069
1070 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1071 (get_doc_string): Check for size calculation overflow.
1072 Don't update size until allocation succeeds.
1073 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1074 EMACS_INT, where ptrdiff_t will do.
1075 (Fsubstitute_command_keys): Check for string overflow.
1076
1077 * editfns.c (set_time_zone_rule): Don't assume environment length
1078 fits in int.
1079 (message_length): Now ptrdiff_t, not int.
1080 (Fmessage_box): Don't update size until allocation succeeds.
1081 Don't assume message length fits in int.
1082 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1083
0065d054
PE
1084 * emacs.c (main): Do not reallocate argv, since there is a null at
1085 the end that can be overwritten, and this way there's no need to
1086 worry about size-calculation overflow.
1087 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
1088
1089 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1090 alloc succeeds.
1091 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1092
1093 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1094 (x_set_scroll_bar_width, x_figure_window_size):
1095 Check for integer overflow.
1096 (x_set_alpha): Do not assume XINT fits in int.
1097
1098 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1099 This is for the members text_lines, text_cols, total_lines, total_cols,
1100 where the system imposes an 'int' limit.
1101
1102 * fringe.c (Fdefine_fringe_bitmap):
1103 Don't update size until alloc works.
1104
1105 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1106 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1107
1108 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1109 Check for size-calculation overflow.
1110 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1111 do, as we prefer signed integers.
1112 (id_to_widget.max_size, id_to_widget.used)
1113 (xg_store_widget_in_map, xg_remove_widget_from_map)
1114 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1115 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1116 Use and return ptrdiff_t, not int.
1117 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1118 * gtkutil.h: Change prototypes to match the above.
1119
1120 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1121 are duplicate now that they've been promoted to lisp.h.
1122 (x_allocate_bitmap_record, x_alloc_image_color)
1123 (make_image_cache, cache_image, xpm_load):
1124 Don't update size until alloc is done.
1125 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1126 (x_detect_edges):
3256efce 1127 Check for size calculation overflow.
726e0ab1
PE
1128 (ct_colors_allocated_max): New constant.
1129 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1130 overflow.
3256efce 1131
726e0ab1
PE
1132 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1133 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1134 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1135 Use ptrdiff_t, not int, to count maps.
1136 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
1137 calculations. Don't update size until allocation succeeds.
1138 Redo calculations to avoid overflow.
726e0ab1
PE
1139 * keyboard.h: Change prototypes to match the above.
1140
1141 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1142 to count maps.
1143 (current_minor_maps): Check for size calculation overflow.
1144 * keymap.h: Change prototypes to match the above.
1145
1146 * lread.c (read1, init_obarray): Don't update size until alloc done.
1147
1148 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1149 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1150
726e0ab1
PE
1151 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1152 Now ptrdiff_t, not int.
1153 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1154 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1155
1156 * process.c (Fnetwork_interface_list): Check for overflow
1157 in size calculation.
1158
1159 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1160
1161 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1162 overflow. Don't bother calling xmalloc when xrealloc will do.
1163
1164 * search.c (Freplace_match): Check for size calculation overflow.
1165 (Fset_match_data): Don't assume list lengths fit in 'int'.
1166
1167 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1168 for command line length. Do not attempt to address one before the
1169 beginning of an array, as that's not portable.
1170
1171 * term.c (max_frame_lines): Remove; unused.
1172 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1173 not int.
1174 (encode_terminal_code, calculate_costs): Check for size
1175 calculation overflow.
1176 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1177 table lengths and related sizes. Don't update size until alloc
1178 done. Redo calculations to avoid overflow.
1179 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1180
1181 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1182 subtracting pointers.
1183 (gobble_line): Check for overflow more carefully. Don't update size
1184 until alloc done.
1185
1186 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1187 Don't update size until alloc done.
1188 Redo size calculations to avoid overflow.
1189 Check for size calculation overflow.
0065d054 1190 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
1191
1192 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1193 Use ptrdiff_t, not int, for sizes.
1194 (store_mode_line_noprop_char): Don't update size until alloc done.
1195
0065d054
PE
1196 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1197 Use ptrdiff_t, not int, for sizes.
1198 (Finternal_make_lisp_face, cache_face):
1199 Check for size calculation overflow.
1200 (cache_face): Treat size calculation overflows as if they were
1201 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
1202
1203 * xfns.c (x_encode_text, x_set_name_internal)
1204 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1205 sizes, since they can exceed INT_MAX in size. Check for size
1206 calculation overflow.
1207
0065d054
PE
1208 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1209 (xg_select): Check for size calculation overflow.
726e0ab1
PE
1210 Don't update size until alloc done.
1211
0065d054 1212 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 1213 as sprintf is limited to int lengths.
1d526e2f 1214
252c5ee1
PE
1215 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1216 (X_LONG_MIN): New macros.
864d7ce7
PE
1217 Use them to make the following changes clearer.
1218 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1219 This change doesn't affect the value now, but it may help remind
1220 future maintainers not to raise the value too much later.
1221 (SELECTION_QUANTUM): Remove, replacing with ...
1222 (selection_quantum): ... new function, which avoids overflow.
1223 All uses changed.
1224 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1225 assumption that selection length fits in 'int'.
1226 (x_reply_selection_request, x_handle_selection_request)
1227 (x_get_window_property, receive_incremental_selection)
1228 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1229 (lisp_data_to_selection_data, clean_local_selection_data):
1230 Use ptrdiff_t, not int, to record length of selection.
1231 (x_reply_selection_request, x_get_window_property)
1232 (receive_incremental_selection, x_property_data_to_lisp):
1233 Redo calculations to avoid overflow.
1234 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 1235 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
1236 something.
1237 (x_get_window_property, receive_incremental_selection)
1238 (lisp_data_to_selection_data, x_property_data_to_lisp):
1239 Check for size-calculation overflow.
1240 (x_get_window_property, receive_incremental_selection)
1241 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1242 Don't store size until memory allocation succeeds.
1243 (x_get_window_property): Plug memory leak on memory exhaustion.
1244 Don't double-block input; malloc is safe here. Don't assume 2**34
1245 - 4 fits in unsigned long. Add an xassert to check
1246 XGetWindowProperty overflow. Be more careful about overflow
1247 calculations, and distinguish size from memory overflow better.
1248 (receive_incremental_selection): When tracing, don't assume
1249 unsigned int is less than INT_MAX.
1250 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1251 harmful) conversions of unsigned short to int.
1252 (lisp_data_to_selection_data): Don't assume that integers
1253 in the range -65535 through -1 fit in an X unsigned short.
1254 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1255 result parameters unless successful. Rely on cons_to_unsigned
1256 to report problems with elements; the old code wasn't right anyway.
1257 (x_check_property_data): Check for int overflow; we cannot use
1258 a wider type due to X limits.
1259 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1260
726e0ab1 1261 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 1262
0065d054
PE
1263 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1264 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
1265 (x_color_cells): Don't store size until memory allocation succeeds.
1266 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 1267 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
1268 (x_term_init): Don't assume length fits in int (sprintf is limited
1269 to int size).
bc18e09d 1270
ebfa62c0
PE
1271 Use ptrdiff_t for composition IDs.
1272 * character.c (lisp_string_width):
1273 * composite.c (composition_table_size, n_compositions)
1274 (get_composition_id, composition_gstring_from_id):
1275 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1276 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1277 * window.c (Frecenter):
1278 Use ptrdiff_t, not int, for composition IDs.
1279 * composite.c (get_composition_id): Check for integer overflow.
1280 * composite.h: Adjust prototypes to match the above changes.
1281
d3411f89
PE
1282 Use ptrdiff_t for hash table indexes.
1283 * category.c (hash_get_category_set):
1284 * ccl.c (ccl_driver):
1285 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1286 * coding.c (coding_system_charset_list, detect_coding_system):
1287 * coding.h (struct coding_system.id):
1288 * composite.c (get_composition_id, gstring_lookup_cache):
1289 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1290 * image.c (xpm_get_color_table_h):
1291 * lisp.h (hash_lookup, hash_put):
1292 * minibuf.c (Ftest_completion):
1293 Use ptrdiff_t for hash table indexes, not int (which is too
1294 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1295 32-bit --with-wide-int hosts).
1296
e097a6fa
PE
1297 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1298 Add a FIXME comment about memory leaks.
1299 (syms_of_charset): Don't assume xmalloc returns.
1300
5637687f
PE
1301 Don't assume that stated character widths fit in int.
1302 * character.c (Fchar_width, c_string_width, lisp_string_width):
1303 * character.h (CHAR_WIDTH):
1304 * indent.c (MULTIBYTE_BYTES_WIDTH):
1305 Use sanitize_char_width to avoid undefined and/or bad behavior
1306 with outlandish widths.
a66cfb1c 1307 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
1308 now that we have two such functions. All uses changed.
1309 (sanitize_char_width): New inline function.
1310
a2271ba2
PE
1311 Don't assume that tab-width fits in int.
1312 * character.h (sanitize_width): New inline function.
1313 (SANE_TAB_WIDTH): New macro.
1314 (ASCII_CHAR_WIDTH): Use it.
1315 * indent.c (sane_tab_width): Remove. All uses replaced by
1316 SANE_TAB_WIDTH (current_buffer).
1317 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1318
18c52557
PE
1319 * fileio.c: Integer overflow issues with file modes.
1320 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1321
caeeedc1
PE
1322 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1323 Remove unreachable code.
1324 (read_hex, load_charset_map_from_file): Check for integer overflow.
1325
50849c52
PE
1326 * xterm.c: don't go over XClientMessageEvent limit
1327 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1328 (x_send_scroll_bar_event): Likewise. Check that the size does not
1329 exceed limits imposed by XClientMessageEvent, as well as the usual
1330 ptrdiff_t and size_t limits.
1331
b13995db
PE
1332 * keyboard.c: Overflow, signedness and related fixes.
1333 (make_lispy_movement): Use same integer type in forward decl
1334 that is used in the definition.
1335 (read_key_sequence, keyremap_step):
1336 Change bufsize argument back to int, undoing my 2011-03-30 change.
1337 We prefer signed types, and int is wide enough here.
1338 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1339 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1340 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1341 length, not size_t. Use ptrdiff_t for index, not int.
1342 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1343 possibility of integer overflow.
1344
13464394
PE
1345 Overflow, signedness and related fixes for images.
1346
1347 * dispextern.h (struct it.stack[0].u.image.image_id)
1348 (struct_it.image_id, struct image.id, struct image_cache.size)
1349 (struct image_cache.used, struct image_cache.ref_count):
1350 * gtkutil.c (update_frame_tool_bar):
1351 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1352 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1353 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1354 * nsmenu.m (update_frame_tool_bar):
1355 * xdisp.c (calc_pixel_width_or_height):
1356 * xfns.c (image_cache_refcount):
1357 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1358 on typical 64-bit hosts.
1359
1360 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1361 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1362 Omit unnecessary casts to int.
1363 (parse_image_spec): Check that integers fall into 'int' range
1364 when the callers expect that.
1365 (image_ascent): Redo ascent calculation to avoid int overflow.
1366 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1367 (lookup_image): Remove unnecessary tests.
1368 (xbm_image_p): Locals are now of int, not EMACS_INT,
1369 since parse_image_check makes sure they fit into int.
1370 (png_load, gif_load, svg_load_image):
1371 Prefer int to unsigned where either will do.
1372 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
1373 old tiff_error_handler and tiff_warning_handler.
1374 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
1375 stack buffer overflows. It uses only the features of vsnprintf
1376 that are common to both POSIX and native Microsoft.
1377 (tiff_error_handler, tiff_warning_handler): Use it.
1378 (tiff_load, gif_load, imagemagick_load_image):
1379 Don't assume :index value fits in 'int'.
1380 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1381 (imagemagick_load_image): Check that crop parameters fit into
1382 the integer types that MagickCropImage accepts. Don't assume
1383 Vimagemagick_render_type has a nonnegative value. Don't assume
1384 size_t fits in 'long'.
1385 (gs_load): Use printmax_t to print the widest integers possible.
1386 Check for integer overflow when computing image height and width.
1387
c11821d4
EZ
13882011-08-26 Eli Zaretskii <eliz@gnu.org>
1389
1390 * xdisp.c (redisplay_window): Don't force window start if point
1391 will be invisible in the resulting window. (Bug#9324)
1392
0c95fcf7
EZ
13932011-08-25 Eli Zaretskii <eliz@gnu.org>
1394
1395 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1396 the display spec is of the form `(space ...)'.
1397 (handle_display_spec): Return the value returned by
1398 handle_single_display_spec, not just 1 or zero.
1399 (handle_single_display_spec): If the display spec is of the form
1400 `(space ...)', and specifies display in the text area, return 2
1401 rather than 1.
fee65a97 1402 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
1403 accurately, and prefer exact match for point under bidi.
1404 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
1405
1406 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1407 into disp_prop; all users changed.
1408
1409 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1410 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1411 for the text covered by the display property.
1412
e4ed06f1
CY
14132011-08-25 Chong Yidong <cyd@stupidchicken.com>
1414
1415 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1416 Change return value to nil.
1417 (Frecord_buffer): Delete unused function.
1418
f67cdd7f
EZ
14192011-08-24 Eli Zaretskii <eliz@gnu.org>
1420
5980d4c6
EZ
1421 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1422 buffers, return left-to-right.
8610fe8b
EZ
1423 (set_cursor_from_row): Consider candidate row a win if its glyph
1424 represents a newline and point is on that newline. Fixes cursor
1425 positioning on the newline at EOL of R2L text within L2R
1426 paragraph, and vice versa.
1427 (try_cursor_movement): Check continued rows, in addition to
1428 continuation rows. Fixes unwarranted scroll when point enters a
1429 continued line of R2L text within an L2R paragraph, or vice versa.
1430 (cursor_row_p): Consider the case of point being equal to
1431 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1432 from the end of a short line to the beginning of a continued line
1433 of R2L text within L2R paragraph.
1434 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1435 composed characters.
5980d4c6 1436
f67cdd7f
EZ
1437 * bidi.c (bidi_check_type): Use xassert.
1438 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1439 members.
1440
bca633fb
EZ
14412011-08-23 Eli Zaretskii <eliz@gnu.org>
1442
1443 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1444 a character.
1445
4a5885a7
CY
14462011-08-23 Chong Yidong <cyd@stupidchicken.com>
1447
1448 * nsfont.m (ns_otf_to_script): Fix typo.
1449
0902a04e
KH
14502011-08-22 Kenichi Handa <handa@m17n.org>
1451
1452 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1453 extra slot even if the purpose is char-code-property-table.
1454
1a2e6670
EZ
14552011-08-23 Eli Zaretskii <eliz@gnu.org>
1456
8ddde651
EZ
1457 * xdisp.c (redisplay_window): When computing centering_position,
1458 account for the height of the header line. (Bug#8874)
1459
425cc014
EZ
1460 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1461 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1462 candidate is selected by the mouse, and that candidate has a
1463 composed character under the mouse.
1464
1a2e6670
EZ
1465 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1466 coordinates reported by pos-visible-in-window-p for a composed
1467 character in column zero.
1468
8b76d6f8
SM
14692011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1470
1471 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1472
dac347dd
EZ
14732011-08-22 Eli Zaretskii <eliz@gnu.org>
1474
1475 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1476 consider it a hit if to_charpos is anywhere in the range of the
1477 composed buffer positions.
1478
e013fb34
CY
14792011-08-22 Chong Yidong <cyd@stupidchicken.com>
1480
1481 * image.c (gif_load): Don't assume that each subimage has the same
1482 dimensions as the base image. Handle disposal method that is
1483 "undefined" by the gif spec (Bug#9335).
1484
bd1ba3e8
CY
14852011-08-20 Chong Yidong <cyd@stupidchicken.com>
1486
1487 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 1488 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 1489
54a1215b
EZ
14902011-08-19 Eli Zaretskii <eliz@gnu.org>
1491
823564e5
EZ
1492 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1493 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1494 from an Org mode buffer to a Speedbar frame.
1495
54a1215b
EZ
1496 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1497 a composition, take its buffer position from IT->cmp_it.charpos.
1498 Fixes cursor positioning at the beginning of a line that begins
1499 with a composed character.
1500
9778ebcc
EZ
15012011-08-18 Eli Zaretskii <eliz@gnu.org>
1502
0be6ee06
EZ
1503 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1504 character bidirectional type, use STRONG_L instead. Fixes crashes
1505 in a buffer produced by `describe-categories'.
1506
9778ebcc
EZ
1507 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1508 members before the level stack, so they would be saved and
1509 restored when copying iterator state. Fixes incorrect reordering
1510 around TABs covered by display properties.
1511
156bffbe
AS
15122011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1513
6b02f655 1514 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 1515
72ad093b
CY
15162011-08-17 Chong Yidong <cyd@stupidchicken.com>
1517
1518 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
1519 (internal_condition_case_2, internal_condition_case_n):
1520 Remove unnecessary aborts (Bug#9081).
72ad093b 1521
35774242
EZ
15222011-08-17 Eli Zaretskii <eliz@gnu.org>
1523
1524 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1525 has no `load' handler, try opening the file locally. (Bug#9311)
1526
db76dd85
KB
15272011-08-16 Ken Brown <kbrown@cornell.edu>
1528
1529 * gmalloc.c: Expand comment.
1530
b215eee5
EZ
15312011-08-16 Eli Zaretskii <eliz@gnu.org>
1532
1533 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1534 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1535
a4579d33
KB
15362011-08-16 Ken Brown <kbrown@cornell.edu>
1537
1538 Fix memory allocation problems in Cygwin build (Bug#9273).
1539
1540 * unexcw.c ( __malloc_initialized): Declare external variable.
1541 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1542
8b76d6f8
SM
1543 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1544 New variables.
a4579d33
KB
1545 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1546 dumped emacs.
1547 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1548 in the static heap.
1549 [CYGWIN] (special_realloc): New function.
1550 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1551 requests to realloc storage in the static heap.
1552
3ebec551
PE
15532011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1554
1555 * bidi.c (bidi_initialize): Remove unused local.
1556
9fd8be00
EZ
15572011-08-15 Eli Zaretskii <eliz@gnu.org>
1558
6b02f655
SM
1559 * bidimirror.h:
1560 * biditype.h: Remove file.
1561 * makefile.w32-in ($(BLD)/bidi.$(O)):
1562 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
1563
1564 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1565
1566 * chartab.c: Improve commentary for the uniprop_table API.
1567
32413314
EZ
1568 * bidi.c (bidi_paragraph_init): Support zero value of
1569 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
1570 (bidi_initialize): Use uniprop_table instead of including
1571 biditype.h and bidimirror.h.
32413314 1572
9fd8be00
EZ
1573 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1574 coordinates of the iterator when restoring from ppos_it.
1575 (Bug#9296)
1576
5cf2b69b
KH
15772011-08-14 Kenichi Handa <handa@m17n.org>
1578
1579 * process.c (create_process): Call setup_process_coding_systems
72ad093b 1580 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 1581
daf17d00
EZ
15822011-08-14 Eli Zaretskii <eliz@gnu.org>
1583
1584 * xdisp.c (move_it_in_display_line_to): Don't invoke
1585 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1586 ppos_it. Fixes vertical cursor motion when line beginning is
1587 covered by an image. (Bug#9296)
1588
08e3161a
JD
15892011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1590
1591 * nsterm.h (ns_run_ascript): Declare.
1592 (NSAPP_DATA2_RUNASSCRIPT): Define.
1593
1594 * nsfns.m (as_script, as_result, as_status): New static variables.
1595 (ns_run_ascript): New function.
5e617bc2 1596 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
1597 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1598 the event loop. Get status from as_status (Bug#7276).
1599
1600 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1601 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1602 the event loop (Bug#7276).
1603
a3720aa2
AS
16042011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1605
1606 * gnutls.c (QCgnutls_bootprop_priority)
1607 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1608 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1609 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1610 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1611 (QCgnutls_bootprop_verify_hostname_error)
1612 (QCgnutls_bootprop_callbacks_verify): Rename from
1613 Qgnutls_bootprop_..., all uses changed.
1614
1615 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1616 uses changed.
1617
0a0d27fb
PE
16182011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1619
19d5c50c
PE
1620 * xfaces.c (Qframe_set_background_mode): Now static.
1621 * dispextern.h (Qframe_set_background_mode): Remove decl.
1622
0a0d27fb
PE
1623 * process.c (Fnetwork_interface_info): Declare local only if needed.
1624
377538cb
JD
16252011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1626
1627 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1628 (Fnetwork_interface_list): Allocate in increments of bytes instead
1629 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1630 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1631 sockaddr.
1632 (struct ifflag_def): notrailers is smart on OSX.
1633 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1634 Get hardware address with getifaddrs if available.
1635
08fff70c
EZ
16362011-08-12 Eli Zaretskii <eliz@gnu.org>
1637
1638 * xdisp.c (iterate_out_of_display_property): xassert that
1639 IT->position is set to within IT->object's boundaries. Break from
1640 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
1641 when IT->position is set up wrongly due to some bug.
1642 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
1643 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1644 entry. Force push_it to save on the stack the current
1645 buffer/string position, to be restored by pop_it. Fix flags in
1646 the iterator structure wrt the object coming from a display
1647 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1648 properties. (Bug#9284)
1649
7be1c708 16502011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 1651
7be1c708
CY
1652 * fontset.c (fontset_get_font_group): Add proper type checks.
1653 (Bug#9172)
aac0c6e3 1654
7be1c708 16552011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 1656
7be1c708
CY
1657 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1658 and LC_VERSION_MIN_MACOSX.
1659 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1660 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 1661
97bb72a6
EZ
16622011-08-08 Eli Zaretskii <eliz@gnu.org>
1663
1664 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
1665 no-display-properties-and-no-overlays under bidi display.
1666 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 1667 properties and overlays.
97bb72a6 1668
d5617611
CY
16692011-08-08 Chong Yidong <cyd@stupidchicken.com>
1670
37e11a63
CY
1671 * editfns.c (Fset_time_zone_rule): Document relationship with the
1672 setenv function.
1673
d5617611
CY
1674 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1675 the font entity extracted from the cache (Bug#8109).
1676
58872834
CY
16772011-08-07 Chong Yidong <cyd@stupidchicken.com>
1678
1679 * composite.c (autocmp_chars): Don't reset point. That is done by
1680 restore_point_unwind (Bug#5984).
1681
75bfc667
JL
16822011-08-07 Juri Linkov <juri@jurta.org>
1683
1684 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1685 to show the arg `TIME' instead of `TIMEVAL'.
1686
d1410150
EZ
16872011-08-06 Eli Zaretskii <eliz@gnu.org>
1688
1689 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1690 display property strides EOL and includes a newline, as in
1691 longlines-mode. (Bug#9254)
75b771e4
EZ
1692 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1693 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
1694
1695 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1696 is non-zero, even if the data buffer is NULL. Fixes a crash in
1697 vertical-motion with longlines-mode. (Bug#9254)
1698
35928349
EZ
16992011-08-05 Eli Zaretskii <eliz@gnu.org>
1700
ec7cc85b
EZ
1701 * bidi.c <bidi_cache_total_alloc>: Now static.
1702 (bidi_initialize): Initialize bidi_cache_total_alloc.
1703
8b76d6f8 1704 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
1705 cache. (Bug#9221)
1706
1707 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1708 amount allocated this far in `bidi_cache_total_alloc'.
1709 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1710 non-zero, only free the data buffer without restoring the cache
1711 contents. All callers changed.
1712
1713 * dispextern.h (bidi_unshelve_cache): Update prototype.
1714
1715 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1716 (move_it_in_display_line, move_it_to)
1717 (move_it_vertically_backward, move_it_by_lines): Replace the call
1718 to xfree to an equivalent call to bidi_unshelve_cache.
1719 (move_it_in_display_line_to): Fix logic of returning
412b6358 1720 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 1721
e2e2423b
EZ
17222011-08-05 Eli Zaretskii <eliz@gnu.org>
1723
1724 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1725 came from a string character with a `cursor' property. (Bug#9229)
1726
ae9e757a
JD
17272011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1728
1729 * Makefile.in (LIB_PTHREAD): New variable.
1730 (LIBES): Add LIB_PTHREAD (Bug#9216).
1731
1732 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1733 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1734
213bd7f2
AS
17352011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1736
6b02f655 1737 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 1738
99aaf75f
JD
17392011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1740
1741 * xterm.c (x_find_topmost_parent): New function.
1742 (x_set_frame_alpha): Find topmost parent window with
1743 x_find_topmost_parent and set the property there also (bug#9181).
1744 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1745
c74e9d86
PE
17462011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1747
1748 * callproc.c (Fcall_process): Avoid vfork clobbering
1749 the local vars buffer, coding_systems, current_dir.
1750
640c8776
SM
17512011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1752
1753 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1754
f26d0e4c
PE
17552011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1756
8a10d76c
PE
1757 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1758 so that it is not optimized away.
1759
f26d0e4c
PE
1760 * xdisp.c (compute_display_string_pos): Remove unused local.
1761
55439c61
EZ
17622011-08-02 Eli Zaretskii <eliz@gnu.org>
1763
1764 Fix slow cursor motion and scrolling in large buffers with
1765 selective display, like Org Mode buffers. (Bug#9218)
1766
1767 * dispextern.h (struct bidi_it): New member disp_prop_p.
1768
1769 * xdisp.c: Remove one-slot cache of display string positions.
1770 (compute_display_string_pos): Accept an additional argument
5e617bc2 1771 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
1772 for a display string or property. If found, set DISP_PROP_P
1773 non-zero.
1774
1775 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
1776 DISP_PROP_P, and pass it to compute_display_string_pos.
1777 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
1778 non-zero. All callers of bidi_fetch_char changed.
1779
fb33fa43
SM
17802011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1781
1782 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1783
b099e063
DM
17842010-12-03 Don March <don@ohspite.net>
1785
1786 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1787 last character M-[char] is translated to ESC [char] (bug#7541).
1788
5cc7f7af
KH
17892011-08-02 Kenichi Handa <handa@m17n.org>
1790
d0fffa3f 1791 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
1792
1793 * chartab.c (uniprop_table): Make it non-static.
1794
525d5e6e
EZ
17952011-08-01 Eli Zaretskii <eliz@gnu.org>
1796
1797 * xdisp.c (forward_to_next_line_start): Accept additional argument
1798 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1799 on the newline.
1800 (reseat_at_next_visible_line_start): Use the bidi iterator state
1801 returned by forward_to_next_line_start to restore the state of
1802 it->bidi_it after backing up to previous newline. (Bug#9212)
1803
31011111
AS
18042011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1805
1806 * regex.c (re_comp): Protoize.
1807 (re_exec): Fix return type.
1808 (regexec): Fix type of `ret'. (Bug#9203)
1809
476371c4
PE
18102011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1811
e5d76069
PE
1812 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1813 This is needed if max-image-size is a floating-point number.
1814
9a79b20c
AS
18152011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1816
1817 * print.c (print_object): Print empty symbol as ##.
1818
1819 * lread.c (read1): Read ## as empty symbol.
1820
d8c2fa78
AA
18212011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1822
1823 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1824 setting frame foreground color (Bug#9175).
1825 (x_set_background_color): Likewise.
1826
ffe57a7a
AA
1827 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1828 contents (Bug#9176).
1829 (EmacsTooltip -init): Remove bezels and add shadows to
1830 tooltip windows.
1831
bf3492a5
AA
1832 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1833 or scroll bar (Bug#8470).
1834
d55e9c53
AA
1835 * nsfont.m (nsfont_open): Remove assignment to voffset and
1836 unnecessary vars hshink, expand, hd, full_height, min_height.
1837 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1838
1839 * nsterm.h (nsfont_info): Remove voffset field.
1840
d8c2fa78 18412011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
1842
1843 Implement strike-through and overline on NextStep (Bug#8863).
1844
1845 * nsfont.m (nsfont_open): Use underline position provided by font,
1846 instead of hard-coded value of 2.
1847 (nsfont_draw): Call ns_draw_text_decoration instead.
1848
1849 * nsterm.h: Add declaration for ns_draw_text_decoration.
1850
1851 * nsterm.m (ns_draw_text_decoration): New function for drawing
1852 underline, overline, and strike-through.
1853 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1854 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 1855 accommodate underlining, etc.
4843aac3 1856
4cc60b9b
EZ
18572011-07-28 Eli Zaretskii <eliz@gnu.org>
1858
bc7ece87
EZ
1859 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1860 default.
4cc60b9b 1861
476371c4
PE
18622011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1863
66606eea
PE
1864 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1865 Without this fix, if a signal arrives just after memory fills up,
1866 'malloc' might be invoked reentrantly.
1867
476371c4
PE
1868 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1869 In other words, assume that every image size is allowed, on non-X
1870 hosts. This assumption is probably wrong, but it lets Emacs compile.
1871
f3fcc40d
AS
18722011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1873
1874 * regex.c (re_iswctype): Convert return values to boolean.
1875
350c992f
EZ
18762011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1877
1878 * xdisp.c (compute_display_string_pos): Don't use cached display
1879 string position if the buffer had its restriction changed.
1880 (Bug#9184)
1881
5266b4bb
PE
18822011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1883
1884 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1885
2573a837 18862011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 1887
41f55ccd 1888 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 1889
39e378da
PE
1890 * bidi.c: Integer size and overflow fixes.
1891 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1892 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1893 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1894 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1895 (bidi_find_other_level_edge):
1896 Use ptrdiff_t instead of EMACS_INT where either will do.
1897 This works better on 32-bit hosts configured --with-wide-int.
1898 (bidi_cache_ensure_space): Check for size-calculation overflow.
1899 Use % rather than repeated addition, for better worst-case speed.
1900 Don't set bidi_cache_size until after xrealloc returns, because it
1901 might not return.
1902 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
1903 (bidi_cache_ensure_space): Also check that the bidi cache size
1904 does not exceed that of the largest Lisp string or buffer. See Eli
1905 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 1906
5e927815
PE
1907 * alloc.c (__malloc_size_t): Remove.
1908 All uses replaced by size_t. See Andreas Schwab's note
1909 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1910
ca4aa935
PE
1911 * image.c: Improve checking for integer overflow.
1912 (check_image_size): Assume that f is nonnull, since
1913 it is always nonnull in practice. This is one less thing to
1914 worry about when checking for integer overflow later.
1915 (x_check_image_size): New function, which checks for integer
1916 overflow issues inside X.
1917 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1918 This removes the need for a memory_full check.
1919 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1920 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1921 (xbm_read_bitmap_data): Change locals back to 'int', since
1922 their values must fit in 'int'.
1923 (xpm_load_image, png_load, tiff_load):
1924 Invoke x_create_x_image_and_pixmap earlier,
1925 to avoid much needless work if the image is too large.
1926 (tiff_load): Treat overly large images as if
1927 x_create_x_image_and_pixmap failed, not as malloc failures.
1928 (gs_load): Use x_check_image_size.
1929
5f8f9cc2
PE
1930 * gtkutil.c: Omit integer casts.
1931 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1932 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1933
5adf60bc
PE
1934 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1935
c8907a93
PE
1936 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1937 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1938 would wrongly return t on a 64-bit host.
1939
e3c25c68
PE
1940 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1941 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1942 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1943 and therefore cause GCC to emit a bogus diagnostic in some cases.
1944
3f791afe
PE
1945 * image.c: Integer signedness and overflow and related fixes.
1946 This is not an exhaustive set of fixes, but it's time to
1947 record what I've got.
1948 (lookup_pixel_color, check_image_size): Remove redundant decls.
1949 (check_image_size): Don't assume that arbitrary EMACS_INT values
1950 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1951 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1952 (tiff_load, imagemagick_load_image):
1953 Check for overflow in size calculations.
1954 (x_create_x_image_and_pixmap): Remove unnecessary test for
1955 xmalloc returning NULL; that can't happen.
1956 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1957 (xpm_color_bucket): Use better integer hashing function.
1958 (xpm_cache_color): Don't possibly over-allocate memory.
1959 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1960 (gif_memory_source):
1961 Use ptrdiff_t, not int or size_t, to record sizes.
1962 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1963 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1964 either works, as we prefer signed integers.
1965 (tiff_read_from_memory, tiff_write_from_memory):
1966 Return tsize_t, not size_t, since that's what the TIFF API wants.
1967 (tiff_read_from_memory): Don't fail simply because the read would
1968 go past EOF; instead, return a short read.
1969 (tiff_load): Omit no-longer-needed casts.
1970 (Fimagemagick_types): Don't assume size fits into 'int'.
1971
3cc5a532
PE
1972 Improve hashing quality when configured --with-wide-int.
1973 * fns.c (hash_string): New function, taken from sxhash_string.
1974 Do not discard information about ASCII character case; this
1975 discarding is no longer needed.
1976 (sxhash-string): Use it. Change sig to match it. Caller changed.
1977 * lisp.h: Declare it.
1978 * lread.c (hash_string): Remove, since we now use fns.c's version.
1979 The fns.c version returns a wider integer if --with-wide-int is
1980 specified, so this should help the quality of the hashing a bit.
1981
b312a492
PE
1982 * emacs.c: Integer overflow minor fix.
1983 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1984 Define only if GNU_LINUX.
1985 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1986
dfd153ae
PE
1987 * dispnew.c: Integer signedness and overflow fixes.
1988 Remove unnecessary forward decls, that were a maintenance hassle.
1989 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1990 All uses changed.
1991 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1992 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1993 (prepare_desired_row, line_draw_cost):
1994 Use int, not unsigned, where either works.
1995 (save_current_matrix, restore_current_matrix):
1996 Use ptrdiff_t, not size_t, where either works.
1997 (init_display): Check for overflow more accurately, and without
1998 relying on undefined behavior.
1999
a81d11a3
PE
2000 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2001 Remove, replacing with the new symbols in lisp.h. All uses changed.
2002 * fileio.c (make_temp_name):
2003 * filelock.c (lock_file_1, lock_file):
2004 * xdisp.c (message_dolog):
2005 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2006 Use pMd etc. instead.
2007 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2008 replacing the pWIDE etc. symbols removed from editfns.c.
2009
3300e6fd
PE
2010 * keyboard.h (num_input_events): Now uintmax_t.
2011 This is (very slightly) less likely to mess up due to wraparound.
2012 All uses changed.
2013
fd05c7e9
PE
2014 * buffer.c: Integer signedness fixes.
2015 (alloc_buffer_text, enlarge_buffer_text):
2016 Use ptrdiff_t rather than size_t when either will do, as we prefer
2017 signed integers.
2018
903fe15d
PE
2019 * alloc.c: Integer signedness and overflow fixes.
2020 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2021 (__malloc_size_t): Default to size_t, not to int.
2022 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2023 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2024 Prefer ptrdiff_t to size_t when either would do, as we prefer
2025 signed integers.
2026 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2027 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2028 Now const. Initialize with values that are in range even if char
2029 is signed.
2030 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2031 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2032 These functions do the right thing with sizes > 2**32.
2033 (check_depth): Now ptrdiff_t, not int.
2034 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2035 Adjust to new way of storing sizes. Check for size overflow bugs
2036 in rest of code.
2037 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2038 slightly wrong anyway, as it missed one instance of
2039 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2040 (refill_memory_reserve): Omit needless cast to size_t.
2041 (mark_object_loop_halt): Mark as externally visible.
2042
ac82cc6a
PE
2043 * xselect.c: Integer signedness and overflow fixes.
2044 (Fx_register_dnd_atom, x_handle_dnd_message):
2045 Use ptrdiff_t, not size_t, since we prefer signed.
2046 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2047 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2048 x_dnd_atoms_size and x_dnd_atoms_length.
2049
c2d1e36d
PE
2050 * doprnt.c: Prefer signed to unsigned when either works.
2051 * eval.c (verror):
2052 * doprnt.c (doprnt):
2053 * lisp.h (doprnt):
2054 * xdisp.c (vmessage):
2055 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2056 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2057 prefer signed arithmetic to avoid comparison confusion.
2058 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2059 but is a bit tricky.
2060
0e926e56
PE
2061 Assume freestanding C89 headers, string.h, stdlib.h.
2062 * data.c, doprnt.c, floatfns.c, print.c:
2063 Include float.h unconditionally.
2064 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2065 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2066 * regex.c: Likewise for stddef.h, string.h.
2067 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2068 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2069 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2070 (STDC_HEADERS): Remove obsolete defines.
2071 * sysdep.c: Include limits.h unconditionally.
2072
9cfdb3ec
PE
2073 Assume support for memcmp, memcpy, memmove, memset.
2074 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2075 * regex.c (memcmp, memcpy):
2076 Remove; we assume C89 now.
2077
2078 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2079 (__malloc_safe_bcopy): Remove; no longer needed.
2080
cf950e6b 2081 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
2082 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2083 well either way, and we prefer signed to unsigned.
2084
dbf38e02
LMI
20852011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2086
2087 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2088 closes the connection while we're reading (bug#9182).
2089
d6f0886c 20902011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 2091
d6f0886c
JD
2092 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2093 are specified (Bug#9168).
24e0f6b1 2094
2eb1f9e6
PE
20952011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2096
2097 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2098 Found by GCC static checking and --with-wide-int on a 32-bit host.
2099
22381272 21002011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
2101
2102 * xdisp.c (compute_display_string_pos): Fix logic of caching
2103 previous display string position. Initialize cached_prev_pos to
2104 -1. Fixes slow-down at the beginning of a buffer.
2105
f25e39b4
EZ
21062011-07-24 Eli Zaretskii <eliz@gnu.org>
2107
2108 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2109 for attrs[LFACE_FONTSET_INDEX].
2110
04c4b52e
PE
21112011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2112
2113 * xml.c (parse_region): Remove unused local
2114 that was recently introduced.
2115
c1734fbd
EZ
21162011-07-23 Eli Zaretskii <eliz@gnu.org>
2117
be18c5a5
EZ
2118 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2119 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2120
c1734fbd
EZ
2121 * xdisp.c (move_it_in_display_line_to): Record the best matching
2122 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
2123 exit if none of the characters scanned was an exact match.
2124 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
2125 when exact match is impossible due to invisible text, and the
2126 lines are truncated.
2127
a258d627
JD
21282011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2129
2130 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2131 for OSX >= 10.7.
2132
b6d5a689
EZ
21332011-07-22 Eli Zaretskii <eliz@gnu.org>
2134
0f74f785
EZ
2135 Fix a significant slow-down of cursor motion with C-n, C-p,
2136 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2137 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 2138 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
2139 (next_element_from_buffer): Call compute_stop_pos_backwards to
2140 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
2141 base_level_stop.
2142 (reseat): Don't look for prev_stop, as that could mean a very long
2143 run.
2144 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2145 <cached_disp_overlay_modiff>: Cache for last found display string
2146 position.
551918c1 2147 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
2148 about the same buffer in the same area of character positions, and
2149 the buffer wasn't changed since the time the display string
2150 position was cached.
551918c1 2151
b2d0c91a
EZ
21522011-07-22 Eli Zaretskii <eliz@gnu.org>
2153
2154 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2155 is an integer, which is important for empty lines. (Bug#9149)
2156
043604ee
CY
21572011-07-22 Chong Yidong <cyd@stupidchicken.com>
2158
2159 * frame.c (Fmodify_frame_parameters): In tty case, update the
2160 default face if necessary (Bug#4238).
2161
da4adb04
CY
21622011-07-21 Chong Yidong <cyd@stupidchicken.com>
2163
2164 * editfns.c (Fstring_to_char): No need to explain what a character
2165 is in the docstring (Bug#6576).
2166
9abd0532
LMI
21672011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2168
2169 * xml.c (parse_region): Make sure we always return a tree.
2170
36881d16
HK
21712011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2172
2173 * xml.c (parse_region): If a document contains only comments,
2174 return that, too.
2175
1e98674d
LMI
21762011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2177
2178 * xml.c (make_dom): Return comments, too.
2179
590bd467
PE
21802011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2181
2182 Port to OpenBSD.
2183 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2184 and the surrounding thread.
2185 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2186 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2187 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2188 timer goes off.
2189 * s/openbsd.h (BROKEN_SIGIO): Define.
2190 * unexelf.c (unexec) [__OpenBSD__]:
2191 Don't update the .mdebug section of the Alpha COFF symbol table.
2192
f41628b2
LMI
21932011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2194
2195 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2196 (bug#8460).
2197
b59b67c5
PE
21982011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2199
15e3a074
PE
2200 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2201 This fixes some race conditions on the permissions of any newly
2202 created file.
2203
41bed37d
PE
2204 * alloc.c (valid_pointer_p): Use pipe, not open.
2205 This fixes some permissions issues when debugging.
2206
b59b67c5
PE
2207 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2208 If fchown fails to set both uid and gid, try to set just gid,
2209 as that is sometimes allowed. Adjust the file's mode to eliminate
2210 setuid or setgid bits that are inappropriate if fchown fails.
2211
925a6be7
SM
22122011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2213
2214 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2215 to compare Lisp_Objects.
2216 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2217 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2218 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2219
52968808
AS
22202011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2221
0a6a104b
AS
2222 * lread.c (read_integer): Unread even EOF character.
2223 (read1): Likewise. Properly record start position of symbol.
2224
52968808
AS
2225 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2226 symbol character follows.
2227
9e381cdd
PE
22282011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2229
2230 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2231 This works around a problem with the previous change to Fcopy_file.
2232 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2233 and without this change, GCC might complain about discarding
2234 fchown's return value.
2235
b5641435
JB
22362011-07-16 Juanma Barranquero <lekktu@gmail.com>
2237
2238 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2239
a8031457
PE
22402011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2241
2242 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2243
dd889327
LMI
22442011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2245
750c33f7
LMI
2246 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2247 it's used from the C level.
2248
dd889327
LMI
2249 * process.c: Use the same condition for POLL_FOR_INPUT in both
2250 keyboard.c and process.c (bug#1858).
2251
87e86684
LM
22522011-07-09 Lawrence Mitchell <wence@gmx.li>
2253
2254 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2255 (Fgnutls_boot): Use it.
2256
64348f40
AS
22572011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2258
2259 * doc.c (Fsubstitute_command_keys): Revert last change.
2260
1d698799
LMI
22612011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2262
f863868c
LMI
2263 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2264 quotes the next character, and doesn't affect other longer
2265 sequences (bug#8935).
2266
1d698799
LMI
2267 * lread.c (syms_of_lread): Clarify that is isn't only
2268 `eval-buffer' and `eval-defun' that's affected by
2269 `lexical-binding' (bug#8460).
2270
aa4b6df6
EZ
22712011-07-15 Eli Zaretskii <eliz@gnu.org>
2272
2273 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 2274 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 2275
5d856da6
PE
22762011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2277
ad6042bb
PE
2278 Fix minor problems found by static checking.
2279 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2280 (elsz): Now a signed constant, not a size_t var. We prefer signed
2281 types to unsigned, to avoid integer comparison confusion. Without
2282 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2283 "cannot optimize loop, the loop counter may overflow", a symptom
2284 of the confusion.
f00bbb22 2285 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
2286 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2287
6468f31c
LMI
22882011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2289
49080b10
LMI
2290 * search.c (Fre_search_backward): Mention `case-fold-search' in
2291 all the re_search_* functions (bug#8138).
2292
6468f31c
LMI
2293 * keyboard.c (Fopen_dribble_file): Document when the file is
2294 closed (bug#8056).
2295
c965adc5
EZ
22962011-07-14 Eli Zaretskii <eliz@gnu.org>
2297
df9733bf
EZ
2298 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2299 bidi_cache_idx.
2300
0bb23927
EZ
2301 Support bidi reordering of display and overlay strings.
2302 * xdisp.c (compute_display_string_pos)
2303 (compute_display_string_end): Accept additional argument STRING.
2304 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2305 (reseat_to_string): Initialize bidi_it->string.s and
2306 bidi_it->string.schars.
2307 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
2308 NULL (avoids a crash in bidi_paragraph_init).
2309 Initialize itb.string.lstring.
0bb23927
EZ
2310 (init_iterator): Call bidi_init_it only of a valid
2311 buffer position was specified. Initialize paragraph_embedding to
2312 L2R.
2313 (reseat_to_string): Initialize the bidi iterator.
2314 (display_string): If we need to ignore text properties of
2315 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2316 original value of -1 will not work with bidi.)
2317 (compute_display_string_pos): First arg is now struct
2318 `text_pos *'; all callers changed. Support display properties on
2319 Lisp strings.
2320 (compute_display_string_end): Support display properties on Lisp
2321 strings.
2322 (init_iterator, reseat_1, reseat_to_string): Initialize the
2323 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2324 when iterating on a string not from display properties).
640c8776
SM
2325 (compute_display_string_pos, compute_display_string_end):
2326 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
2327 arrow keys.
2328 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
2329 base_level_stop; instead, set base_level_stop to BEGV.
2330 Fixes crashes in vertical-motion.
0bb23927
EZ
2331 (next_element_from_buffer): Improve commentary for when
2332 the iterator is before prev_stop.
2333 (init_iterator): Initialize bidi_p from the default value of
2334 bidi-display-reordering, not from buffer-local value. Use the
2335 buffer-local value only if initializing for buffer iteration.
2336 (handle_invisible_prop): Support invisible properties on strings
2337 that are being bidi-reordered.
2338 (set_iterator_to_next): Support bidi reordering of C strings and
2339 Lisp strings.
2340 (next_element_from_string): Support bidi reordering of Lisp
2341 strings.
2342 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
2343 (display_string): Support display of R2L glyph rows.
2344 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
2345 (init_iterator): Don't initialize it->bidi_p for strings
2346 here.
2347 (reseat_to_string): Initialize it->bidi_p for strings here.
2348 (next_element_from_string, next_element_from_c_string)
2349 (next_element_from_buffer): Add xassert's for correspondence
2350 between IT's object being iterated and it->bidi_it.string
2351 structure.
2352 (face_before_or_after_it_pos): Support bidi iteration.
2353 (next_element_from_c_string): Handle the case of the first string
2354 character that is not the first one in the visual order.
2355 (get_visually_first_element): New function, refactored from common
2356 parts of next_element_from_buffer, next_element_from_string, and
2357 next_element_from_c_string.
2358 (tool_bar_lines_needed, redisplay_tool_bar)
2359 (display_menu_bar): Force left-to-right direction. Add a FIXME
2360 comment for making that be controlled by a user option.
2361 (push_it, pop_it): Save and restore the state of the
2362 bidi iterator. Save and restore the bidi_p flag.
2363 (pop_it): Iterate out of display property for string iteration as
2364 well.
2365 (iterate_out_of_display_property): Support iteration over strings.
2366 (handle_single_display_spec): Set up it->bidi_it for iteration
2367 over a display string, and call bidi_init_it.
2368 (handle_single_display_spec, next_overlay_string)
2369 (get_overlay_strings_1, push_display_prop): Set up the bidi
2370 iterator for displaying display or overlay strings.
2371 (forward_to_next_line_start): Don't use the shortcut if
2372 bidi-iterating.
2373 (back_to_previous_visible_line_start): If handle_display_prop
2374 pushed the iterator stack, restore the internal state of the bidi
2375 iterator by calling bidi_pop_it same number of times.
2376 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2377 and we are bidi-iterating, don't decrement the iterator position;
2378 instead, set the first_elt flag in the bidi iterator, to produce
2379 the same effect.
2380 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2381 (push_display_prop): xassert that we are iterating a buffer.
2382 (push_it, pop_it): Save and restore paragraph_embedding member.
2383 (handle_single_display_spec, next_overlay_string)
2384 (get_overlay_strings_1, reseat_1, reseat_to_string)
2385 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2386 correctly. Don't assume unibyte strings are not bidi-reordered.
2387 (compute_display_string_pos)
2388 (compute_display_string_end): Fix handling the case of C string.
2389 (push_it, pop_it): Save and restore from_disp_prop_p.
2390 (handle_single_display_spec, push_display_prop): Set the
2391 from_disp_prop_p flag.
2392 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2393 (pop_it): Call iterate_out_of_display_property only if we are
2394 popping after iteration over a string that came from a display
2395 property. Fix a typo in popping stretch info. Add an assertion
2396 for verifying that the iterator position is in sync with the bidi
2397 iterator.
2398 (handle_single_display_spec, get_overlay_strings_1)
2399 (push_display_prop): Fix initialization of paragraph direction for
2400 string when that of the parent object is not yet determined.
2401 (reseat_1): Call bidi_init_it to resync the bidi
2402 iterator with IT's position. (Bug#7616)
2403 (find_row_edges): If ROW->start.pos gives position
2404 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2405 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2406 Reset the from_disp_prop_p flag.
2407 (SAVE_IT, RESTORE_IT): New macros.
2408 (pos_visible_p, face_before_or_after_it_pos)
2409 (back_to_previous_visible_line_start)
2410 (move_it_in_display_line_to, move_it_in_display_line)
2411 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2412 (try_scrolling, redisplay_window, display_line): Use them when
2413 saving a temporary copy of the iterator and restoring it back.
2414 (back_to_previous_visible_line_start, reseat_1)
2415 (init_iterator): Empty the bidi cache "stack".
2416 (move_it_in_display_line_to): If iterator ended up at
2417 EOL, but we never saw any buffer positions smaller than
2418 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2419 motion in bidi-reordered lines.
2420 (move_it_in_display_line_to): Record prev_method and prev_pos
2421 immediately before the call to set_iterator_to_next. Fixes cursor
2422 motion in bidi-reordered lines with stretch glyphs and strings
2423 displayed in margins. (Bug#8133) (Bug#8867)
2424 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2425 TO_CHARPOS.
640c8776
SM
2426 (pos_visible_p): Support positions in bidi-reordered lines.
2427 Save and restore bidi cache.
0bb23927
EZ
2428
2429 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2430 (bidi_paragraph_info): Delete unused struct.
2431 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2432 (bidi_cache_start): New variable.
2433 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2434 to zero.
2435 (bidi_cache_fetch_state, bidi_cache_search)
2436 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2437 (bidi_cache_find, bidi_peek_at_next_level)
2438 (bidi_level_of_next_char, bidi_find_other_level_edge)
2439 (bidi_move_to_visually_next): Compare cache index with
2440 bidi_cache_start rather than with zero.
2441 (bidi_fetch_char): Accept new argument STRING; all callers
2442 changed. Support iteration over a string. Support strings with
2443 display properties. Support unibyte strings. Fix the type of
2444 `len' according to what STRING_CHAR_AND_LENGTH expects.
2445 (bidi_paragraph_init, bidi_resolve_explicit_1)
2446 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
2447 (bidi_level_of_next_char, bidi_move_to_visually_next):
2448 Support iteration over a string.
0bb23927
EZ
2449 (bidi_set_sor_type, bidi_resolve_explicit_1)
2450 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2451 can now be zero (for strings); special values 0 and -1 were
2452 changed to -1 and -2, respectively.
2453 (bidi_char_at_pos): New function.
2454 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2455 Call it instead of FETCH_MULTIBYTE_CHAR.
2456 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2457 initialized to valid values.
2458 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2459 values.
2460 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2461 the test for valid cached positions. Fix the logic for looking up
2462 the sentinel state in the cache. GCPRO the Lisp string we are
2463 iterating.
2464 (bidi_push_it, bidi_pop_it): New functions.
2465 (bidi_initialize): Initialize the bidi cache start stack pointer.
2466 (bidi_cache_ensure_space): New function, refactored from part of
2467 bidi_cache_iterator_state. Don't assume the required size is just
2468 one BIDI_CACHE_CHUNK away.
2469 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2470 (bidi_count_bytes, bidi_char_at_pos): New functions.
2471 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2472 always valid if bidi_cache_idx is valid.
2473 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2474 is valid if it's going to be used.
2475 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2476 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
2477 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2478 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
2479 (bidi_find_other_level_edge, bidi_cache_start_stack):
2480 All variables related to cache indices are now EMACS_INT.
c965adc5 2481
0bb23927
EZ
2482 * dispextern.h (struct bidi_string_data): New structure.
2483 (struct bidi_it): New member `string'. Make flag members be 1-bit
2484 fields, and put them last in the struct.
640c8776
SM
2485 (compute_display_string_pos, compute_display_string_end):
2486 Update prototypes.
0bb23927
EZ
2487 (bidi_push_it, bidi_pop_it): Add prototypes.
2488 (struct iterator_stack_entry): New members bidi_p,
2489 paragraph_embedding, and from_disp_prop_p.
2490 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
2491 (bidi_shelve_cache, bidi_unshelve_cache):
2492 Declare prototypes.
0bb23927
EZ
2493
2494 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2495 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2496 and vector-like objects.
2497
2498 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2499 cache around display iteration.
2500
2501 * window.c (Fwindow_end, window_scroll_pixel_based)
2502 (displayed_window_lines, Frecenter): Save and restore the bidi
2503 cache around display iteration.
2504
3bbd2265
LMI
25052011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2506
2507 * editfns.c (Fdelete_region): Clarify the use of the named
2508 parameters (bug#6788).
2509
adc47434
MR
25102011-07-14 Martin Rudalics <rudalics@gmx.at>
2511
2512 * indent.c (Fvertical_motion): Set and restore w->pointm when
2513 saving and restoring the window's buffer (Bug#9006).
2514
837c31f8
LMI
25152011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2516
2517 * editfns.c (Fstring_to_char): Clarify just what is returned
2518 (bug#6576). Text by Eli Zaretskii.
2519
ac389d0c
JB
25202011-07-13 Juanma Barranquero <lekktu@gmail.com>
2521
2522 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2523
0be0ce47
EZ
25242011-07-13 Eli Zaretskii <eliz@gnu.org>
2525
2526 * buffer.c (mmap_find): Fix a typo.
2527
cd18e7e3
JB
25282011-07-13 Johan Bockgård <bojohan@gnu.org>
2529
2530 Fix execution of x selection hooks.
2531 * xselect.c (Qx_lost_selection_functions)
2532 (Qx_sent_selection_functions): New vars.
2533 (syms_of_xselect): DEFSYM them.
2534 (x_handle_selection_request): Pass Qx_sent_selection_functions
2535 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2536 (x_handle_selection_clear,x_clear_frame_selections):
2537 Pass Qx_lost_selection_functions rather than
2538 Vx_lost_selection_functions to Frun_hook_with_args.
2539
47ea7f44
PE
25402011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2541
ac389d0c 2542 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
2543 The old code sometimes used this field without initializing it.
2544
47ea7f44
PE
2545 * alloc.c (gc_sweep): Don't read past end of array.
2546 In theory, the old code could also have corrupted Emacs internals,
2547 though it'd be very unlikely.
2548
bc985c87
AS
25492011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2550
2551 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 2552 argument. (Bug#4026)
bc985c87 2553
0cf34688
LMI
25542011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2555
b3dadd76
LMI
2556 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2557 key" (bug#4257).
2558
0cf34688
LMI
2559 * window.c (Fset_window_start): Doc fix (bug#4199).
2560 (Fset_window_hscroll): Ditto.
2561
270768cd
PE
25622011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2563
077e3dda 2564 Fix minor new problems caught by GCC 4.6.1.
270768cd 2565 * term.c (init_tty): Remove unused local.
490011a6 2566 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 2567 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 2568 not used otherwise.
270768cd 2569
b1f58454
CY
25702011-07-12 Chong Yidong <cyd@stupidchicken.com>
2571
2572 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2573
22b9578d
LMI
25742011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2575
6e70ab07
LMI
2576 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2577 are the mini-buffer and the echo area (bug#3320).
2578
22b9578d
LMI
2579 * term.c (init_tty): Remove support for supdup, c10 and perq
2580 terminals, which are no longer supported (bug#1482).
2581
8974cc9f
JB
25822011-07-10 Johan Bockgård <bojohan@gnu.org>
2583
2584 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2585
a560d974
JD
25862011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2587
2588 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2589 for non-popups (Bug#3642).
2590
1dae0f0a
AS
25912011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2592
268c2c36 2593 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 2594 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
2595 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2596 * cm.c (losecursor): Likewise.
1dae0f0a
AS
2597 * data.c (fmod): Likewise.
2598 * dispnew.c (swap_glyphs_in_rows): Likewise.
2599 * emacs.c (memory_warning_signal): Likewise.
2600 * floatfns.c (float_error): Likewise.
2601 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2602 (otf_open, font_otf_capability, generate_otf_features)
2603 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2604 Likewise.
2605 * image.c (pbm_read_file): Likewise.
2606 * indent.c (string_display_width): Likewise.
2607 * intervals.c (check_for_interval, search_for_interval)
2608 (inc_interval_count, count_intervals, root_interval)
2609 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2610 * lread.c (defalias): Likewise.
268c2c36 2611 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
2612 * regex.c (set_image_of_range_1, set_image_of_range)
2613 (regex_grow_registers): Likewise.
2614 * sysdep.c (strerror): Likewise.
2615 * termcap.c (valid_filename_p, tprint, main): Likewise.
2616 * tparam.c (main): Likewise.
2617 * unexhp9k800.c (run_time_remap, save_data_space)
2618 (update_file_ptrs, read_header, write_header, calculate_checksum)
2619 (copy_file, copy_rest, display_header): Likewise.
2620 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2621 Likewise.
2622 * xdisp.c (check_it): Likewise.
2623 * xfaces.c (register_color, unregister_color, unregister_colors):
2624 Likewise.
2625 * xfns.c (print_fontset_result): Likewise.
2626 * xrdb.c (member, fatal, main): Likewise.
2627
99033785
PE
26282011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2629
2630 Fix minor problems found by static checking (Bug#9031).
2631 * chartab.c (char_table_set_range, map_sub_char_table):
2632 Remove unused locals.
2633 (uniprop_table): Now static.
2634 * composite.c (_work_char): Remove unused static var.
2635
9cb2ac56
JB
26362011-07-09 Juanma Barranquero <lekktu@gmail.com>
2637
2638 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2639
f25661f0
JD
26402011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2641
2642 * gtkutil.c (qttip_cb): Remove code without function.
2643
8278c4fe
EZ
26442011-07-09 Eli Zaretskii <eliz@gnu.org>
2645
2646 * w32.c (pthread_sigmask): New stub.
2647
1692ae2d 26482011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 2649
8a6ebd58 2650 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
2651 sigprocmask is portable only for single-threaded applications, and
2652 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
2653 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2654 (LIBES): Use it.
2655 * callproc.c (Fcall_process):
2656 * process.c (create_process):
2657 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2658 Use pthread_sigmask, not sigprocmask.
123403e4 2659
1b854618
JD
26602011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2661
2662 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2663 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2664 wrong (Bug#8591).
2665
3fe4b549
JD
26662011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2667
0ce7e563
JD
2668 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2669 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2670 (xg_hide_tooltip): Fix comment.
2671
3fe4b549
JD
2672 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2673 in registerServicesMenuSendTypes.
2674 (validRequestorForSendType): Don't check ns_return_types.
2675
2676 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2677 ns_return_type.
2678
5df75e47
JR
26792011-07-08 Jason Rumney <jasonr@gnu.org>
2680
2681 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2682 frame struct members of non-existent frames (Bug#6284).
2683
699c10bd
JD
26842011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2685
4393663b
JD
2686 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2687 variable firstTime not needed on OSX >= 10.6.
2688 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2689 >= 10.5. Use setKnobProportion, setDoubleValue.
2690
2691 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2692 (MAC_OS_X_VERSION_10_5): Define if not defined.
2693 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2694 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2695 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2696
2697 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2698 cString and lossyCString on OSX >= 10.4
2699
2700 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2701 sizeToFit on OSX >= 10.2.
2702
2703 * nsimage.m (allocInitFromFile): Don't use deprecated method
2704 bestRepresentationForDevice on OSX >= 10.6.
2705
2706 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2707 to avoid warning.
2708
2709 * emacs.c: Declare unexec_init_emacs_zone.
2710
a63e0781
JD
2711 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2712
699c10bd
JD
2713 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2714
2715 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2716 on svcsMenu (Bug#8842).
2717
2718 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2719 ns_return_types.
2720 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2721
2722 * nsterm.m (QUTF8_STRING): Declare.
2723 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2724 (validRequestorForSendType): Return type is (id).
2725 Change indexOfObjectIdenticalTo to indexOfObject.
2726 Check if we have local selection before returning self (Bug#8842).
2727 (writeSelectionToPasteboard): Put local selection into paste board
2728 if we have a local selection (Bug#8842).
2729 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2730
2731 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2732 (ns_get_local_selection): Declare.
2733
54e10184
LMI
27342011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2735
9888ff71
LMI
2736 * keymap.c (describe_map_tree): Don't insert a double newline at
2737 the end of the buffer (bug#1169) and return whether we inserted
2738 something.
2739
54e10184
LMI
2740 * callint.c (Fcall_interactively): Change "reading args" to
2741 "providing args" to try to clarify what it does (bug#1010).
2742
15fa4783
KH
27432011-07-07 Kenichi Handa <handa@m17n.org>
2744
2745 * composite.c (composition_compute_stop_pos): Ignore a static
2746 composition starting before CHARPOS (Bug#8915).
2747
2748 * xdisp.c (handle_composition_prop): Likewise.
2749
a8815b00
EZ
27502011-07-07 Eli Zaretskii <eliz@gnu.org>
2751
2752 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2753 (Bug#9015)
2754
ef7b981d 27552011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
2756
2757 * character.h (unicode_category_t): New enum type.
2758
2759 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2760 (Qchar_code_property_table): New variable.
2761 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2762 (UNIPROP_COMPRESSED_FORM_P): New macros.
2763 (char_table_ascii): Uncompress the compressed values.
2764 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2765 Uncompress the compressed values.
ac389d0c 2766 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
2767 (char_table_ref_and_range): Uncompress the compressed values.
2768 (sub_char_table_set): New arg is_uniprop. Callers changed.
2769 Uncompress the compressed values.
2770 (sub_char_table_set_range): Args changed. Callers changed.
2771 (char_table_set_range): Adjuted for the above change.
2772 (map_sub_char_table): Delete args default_val and parent. Add arg
2773 top. Give decoded values to a Lisp function.
640c8776 2774 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
2775 values to a Lisp function. Gcpro more variables.
2776 (uniprop_table_uncompress)
2777 (uniprop_decode_value_run_length): New functions.
2778 (uniprop_decoder, uniprop_decoder_count): New variables.
2779 (uniprop_get_decoder, uniprop_encode_value_character)
2780 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2781 New functions.
2782 (uniprop_encoder, uniprop_encoder_count): New variables.
2783 (uniprop_get_encoder, uniprop_table)
2784 (Funicode_property_table_internal, Fget_unicode_property_internal)
2785 (Fput_unicode_property_internal): New functions.
2786 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2787 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 2788 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
2789 char-code-property-alist.
2790
640c8776 2791 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
2792 Vunicode_category_table.
2793
640c8776 2794 * font.c (font_range): Adjust for the change of
c805dec0
KH
2795 Vunicode_category_table.
2796
76b397fb
DN
27972011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2798
2799 * m/iris4d.h: Remove file, move contents ...
2800 * s/irix6-5.h: ... here.
2801
22b4128e
PE
28022011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2803
2804 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
2805 * alloc.c (mark_buffer):
2806 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2807 (clone_per_buffer_values): Don't assume that
22b4128e
PE
2808 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2809 This isn't true in general, and it's particularly not true
2810 if Emacs is configured with --with-wide-int.
2811 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2812 New macros, used in the buffer.c change.
2813
869795d6
JD
28142011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2815
2816 * xsettings.c: Use both GConf and GSettings if both are available.
2817 (store_config_changed_event): Add comment.
2818 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2819 (store_tool_bar_style_changed): New functions.
5e617bc2 2820 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
2821 (struct xsettings): Move font inside HAVE_XFT.
2822 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 2823 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 2824 Move inside HAVE_XFT.
640c8776 2825 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
2826 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2827 also.
2828 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 2829 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 2830 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
2831 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2832 (parse_settings): Move check for font inside HAVE_XFT.
2833 (read_settings, apply_xft_settings): Add comment.
2834 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2835 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2836 call store_font_name_changed.
2837 (xft_settings_event): Add comment.
2838 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2839 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2840 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2841 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2842 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
2843 (xsettings_get_system_font, xsettings_get_system_normal_font):
2844 Add comment.
869795d6 2845
d8ed26bd
PE
28462011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2847
2848 Random fixes. E.g., (random) never returned negative values.
2849 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2850 subseconds part to the entropy, as that's a bit more random.
2851 Prefer signed to unsigned, since the signedness doesn't matter and
2852 in general we prefer signed. When given a limit, use a
2853 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2854 latter isn't right if USE_2_TAGS_FOR_INTS.
2855 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2856 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2857
cabf1cac
SM
28582011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2859
2860 * textprop.c (text_property_stickiness):
2861 Obey Vtext_property_default_nonsticky.
2862 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2863 * w32fns.c (syms_of_w32fns):
2864 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2865
6e9b2be9
PE
28662011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2867
2868 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2869 This is more efficient than Ffile_directory_p and avoids a minor race.
2870
90186c68
LMI
28712011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2872
7c301272
LMI
2873 * buffer.c (Foverlay_put): Say what the return value is
2874 (bug#7835).
2875
c4f2d8d4
LMI
2876 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2877 is a directory before asking whether to use the file name
2878 (bug#7564).
ad637907
LMI
2879 (barf_or_query_if_file_exists): Make the "File is a directory"
2880 error be more correct.
c4f2d8d4 2881
90186c68
LMI
2882 * fns.c (Frequire): Remove the mention of the .gz files, since
2883 that's installation-specific, but keep the mention of
2884 `get-load-suffixes'.
2885
da64016e
PE
28862011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2887
2888 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2889 Report string overflow if the output is too long.
2890
7d47b580
JB
28912011-07-04 Juanma Barranquero <lekktu@gmail.com>
2892
a555cb87
JB
2893 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2894 (syms_of_gnutls): Remove duplicate DEFSYM for
2895 Qgnutls_bootprop_verify_hostname_error, an error for
2896 Qgnutls_bootprop_verify_error (which is no longer used).
2897
7d47b580
JB
2898 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2899 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2900 Also (re)move comments that are misplaced or no longer relevant.
2901
1e49bfab
LMI
29022011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2903
2904 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2905
1485f4c0
CY
29062011-07-03 Chong Yidong <cyd@stupidchicken.com>
2907
2908 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2909 and background color parameters if they have been changed.
2910
a9ab721e
LMI
29112011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2912
2913 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2914
cf7cff57
PE
29152011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2916
2e13213d
PE
2917 * xsettings.c (SYSTEM_FONT): Define only when used.
2918 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2919
cf7cff57
PE
2920 * keymap.c (access_keymap_1): Now static.
2921
7a8e04f7
CY
29222011-07-02 Chong Yidong <cyd@stupidchicken.com>
2923
2924 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2925 leave any prefix arg for the up event (Bug#1586).
2926
61352f62
LMI
29272011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2928
69bb1ef7
LMI
2929 * lread.c (syms_of_lread): Mention single symbols defined by
2930 `defvar' or `defconst' (bug#7154).
2931
61352f62 2932 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 2933 (Frequire): Mention get-load-suffixes.
61352f62 2934
28545e04
MR
29352011-07-02 Martin Rudalics <rudalics@gmx.at>
2936
2937 * window.h (window): Remove clone_number slot.
2938 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2939 Remove.
2940 (make_parent_window, make_window, saved_window)
2941 (Fset_window_configuration, save_window_save): Don't deal with
2942 clone numbers.
2943 * buffer.c (Qclone_number): Remove declaration.
2944 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2945
3349e122
SM
29462011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2947
2948 Add multiple inheritance to keymaps.
2949 * keymap.c (Fmake_composed_keymap): New function.
2950 (Fset_keymap_parent): Simplify.
2951 (fix_submap_inheritance): Remove.
2952 (access_keymap_1): New function extracted from access_keymap to handle
2953 embedded parents and handle lists of maps.
2954 (access_keymap): Use it.
2955 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2956 (Fcopy_keymap): Handle embedded parents.
2957 (Fcommand_remapping, define_as_prefix): Simplify.
2958 (Fkey_binding): Simplify.
2959 (syms_of_keymap): Move minibuffer-local-completion-map,
2960 minibuffer-local-filename-completion-map,
2961 minibuffer-local-must-match-map, and
2962 minibuffer-local-filename-must-match-map to Elisp.
2963 (syms_of_keymap): Defsubr make-composed-keymap.
2964 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2965 (parse_menu_item): Trivial simplification.
2966
3279eb87
GM
29672011-07-01 Glenn Morris <rgm@gnu.org>
2968
2969 * Makefile.in (SETTINGS_LIBS): Fix typo.
2970
4550efdf
KI
29712011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2972
2973 * coding.c (Fencode_coding_string): Record the last coding system
2974 used, as the function doc string says (bug#8738).
2975
0949d2b6
JD
29762011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2977
2978 * xsettings.c (store_monospaced_changed): Take new font as arg and
2979 check for change against current_mono_font.
2980 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2981 (emacs_settings_constructor, emacs_settings_get_property)
2982 (emacs_settings_set_property, emacs_settings_class_init)
2983 (emacs_settings_init, gsettings_obj): Remove.
2984 (something_changedCB): New function for HAVE_GSETTINGS.
2985 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2986 with value as argument.
2987 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2988 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 2989 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
2990 "changed".
2991
2992 * xgselect.c: Add defined (HAVE_GSETTINGS).
2993 (xgselect_initialize): Ditto.
2994
2995 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2996 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2997 xg_select.
2998
bbc6b304
PE
29992011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3000
3001 * eval.c (struct backtrace): Simplify and port the data structure.
3002 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3003 signed bit field, as this assumption is not portable and it makes
3004 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3005 "char debug_on_exit : 1" as this is not portable either; instead,
3006 use the portable "unsigned int debug_on_exit : 1". Remove unused
3007 member evalargs. Remove obsolete comments about cc bombing out.
3008
9851bfc5
JD
30092011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3010
51bb811f 3011 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
3012 Let HAVE_GSETTINGS override HAVE_GCONF.
3013 (store_monospaced_changed): New function.
3014 (EMACS_SETTINGS): A new type derived from GObject to handle
3015 GSettings notifications.
3016 (emacs_settings_constructor, emacs_settings_get_property)
3017 (emacs_settings_set_property, emacs_settings_class_init):
3018 New functions.
3019 (gsettings_client, gsettings_obj): New variables.
3020 (GSETTINGS_SCHEMA): New define.
3021 (something_changedCB): Call store_monospaced_changed.
3022 (init_gsettings): New function.
3023 (xsettings_initialize): Call init_gsettings.
3024 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3025 to NULL.
3026
640c8776 3027 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
3028 GCONF_CFLAGS/LIBS.
3029
5386012d
MR
30302011-06-29 Martin Rudalics <rudalics@gmx.at>
3031
3032 * window.c (resize_root_window, grow_mini_window)
3033 (shrink_mini_window): Rename Qresize_root_window to
3034 Qwindow_resize_root_window and Qresize_root_window_vertically to
3035 Qwindow_resize_root_window_vertically.
3036
f13e0b08
PE
30372011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3038
3039 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3040
94515237
JB
30412011-06-27 Juanma Barranquero <lekktu@gmail.com>
3042
3043 * makefile.w32-in: Redesign dependencies so they reflect more
3044 clearly which files are directly included by each source file,
3045 and not through other includes.
3046
e43b6e43
MR
30472011-06-27 Martin Rudalics <rudalics@gmx.at>
3048
3049 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3050 (sort_overlays, overlay_strings): When an overlay's clone number
3051 matches the window's clone number process the overlay even if
3052 the overlay's window property doesn't match the current window.
3053
d68443dc
MR
3054 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3055 (Fwindow_hchild): Rename to Fwindow_left_child.
3056 (Fwindow_next): Rename to Fwindow_next_sibling.
3057 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
3058 (resize_window_check): Rename to window_resize_check.
3059 (resize_window_apply): Rename to window_resize_apply.
3060 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3061 (Fdelete_other_windows_internal, resize_frame_windows)
3062 (Fsplit_window_internal, Fdelete_window_internal)
3063 (grow_mini_window, shrink_mini_window)
3064 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 3065
c7e73be5
JD
30662011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3067
3068 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3069 (emacs_fixed_set_min_size): Remove.
3070 (emacs_fixed_new): Take frame as argument.
3071
3072 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3073 (_EmacsFixedPrivate): Remove minwidth/height.
3074 Add struct frame *f.
3075 (emacs_fixed_init): Initialize priv->f.
3076 (get_parent_class, emacs_fixed_set_min_size): Remove.
3077 (emacs_fixed_new): Set priv->f to argument.
3078 (emacs_fixed_get_preferred_width)
3079 (emacs_fixed_get_preferred_height): Use min_width/height from
3080 frames size_hint to set minimum and natural (Bug#8919).
3081 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3082 and use min_width/height from frames size_hint to set
3083 min_width/height (Bug#8919).
3084
3085 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
3086 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3087 Fix indentation.
c7e73be5 3088
cf99dcf8
EZ
30892011-06-26 Eli Zaretskii <eliz@gnu.org>
3090
3091 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3092 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3093 called at ZV.
3094
029529ac
CY
30952011-06-26 Chong Yidong <cyd@stupidchicken.com>
3096
3097 * process.c (wait_reading_process_output): Bypass select if
3098 waiting for a cell while ignoring keyboard input, and input is
3099 pending. Suggested by Jan Djärv (Bug#8869).
3100
7a7ef429
PE
31012011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3102
3103 Use gnulib's dup2 module instead of rolling our own.
3104 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3105
11fdef7d 31062011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
3107
3108 * dispnew.c (scrolling_window): Before scrolling, turn off a
3109 mouse-highlight in the window being scrolled.
3110
cd3520a4
JB
31112011-06-24 Juanma Barranquero <lekktu@gmail.com>
3112
3113 Move DEFSYM to lisp.h and use everywhere.
3114
3115 * character.h (DEFSYM): Move declaration...
3116 * lisp.h (DEFSYM): ...here.
3117
3118 * gnutls.c:
3119 * minibuf.c:
3120 * w32menu.c:
3121 * w32proc.c:
3122 * w32select.c: Don't include character.h.
3123
3124 * alloc.c (syms_of_alloc):
3125 * buffer.c (syms_of_buffer):
3126 * bytecode.c (syms_of_bytecode):
3127 * callint.c (syms_of_callint):
3128 * casefiddle.c (syms_of_casefiddle):
3129 * casetab.c (init_casetab_once):
3130 * category.c (init_category_once, syms_of_category):
3131 * ccl.c (syms_of_ccl):
3132 * cmds.c (syms_of_cmds):
3133 * composite.c (syms_of_composite):
3134 * dbusbind.c (syms_of_dbusbind):
3135 * dired.c (syms_of_dired):
3136 * dispnew.c (syms_of_display):
3137 * doc.c (syms_of_doc):
3138 * editfns.c (syms_of_editfns):
3139 * emacs.c (syms_of_emacs):
3140 * eval.c (syms_of_eval):
3141 * fileio.c (syms_of_fileio):
3142 * fns.c (syms_of_fns):
3143 * frame.c (syms_of_frame):
3144 * fringe.c (syms_of_fringe):
3145 * insdel.c (syms_of_insdel):
3146 * keymap.c (syms_of_keymap):
3147 * lread.c (init_obarray, syms_of_lread):
3148 * macros.c (syms_of_macros):
3149 * msdos.c (syms_of_msdos):
3150 * print.c (syms_of_print):
3151 * process.c (syms_of_process):
3152 * search.c (syms_of_search):
3153 * sound.c (syms_of_sound):
3154 * syntax.c (init_syntax_once, syms_of_syntax):
3155 * terminal.c (syms_of_terminal):
3156 * textprop.c (syms_of_textprop):
3157 * undo.c (syms_of_undo):
3158 * w32.c (globals_of_w32):
3159 * window.c (syms_of_window):
3160 * xdisp.c (syms_of_xdisp):
3161 * xfaces.c (syms_of_xfaces):
3162 * xfns.c (syms_of_xfns):
3163 * xmenu.c (syms_of_xmenu):
3164 * xsettings.c (syms_of_xsettings):
3165 * xterm.c (syms_of_xterm): Use DEFSYM.
3166
4228cf16
TZ
31672011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3168
cd3520a4 3169 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 3170
7fcccf1e
PE
31712011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3172
7efb4e0e
PE
3173 Integer and buffer overflow fixes (Bug#8873).
3174
ff5844ad
PE
3175 * print.c (printchar, strout): Check for string overflow.
3176 (PRINTPREPARE, printchar, strout):
3177 Don't set size unless allocation succeeds.
3178
90532f02
PE
3179 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3180 for sizes. Check for string overflow more accurately.
3181 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3182
6d84508d
PE
3183 * macros.c: Integer and buffer overflow fixes.
3184 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3185 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3186 Use ptrdiff_t, not int, for sizes.
3187 Don't increment bufsize until after realloc succeeds.
3188 Check for size-calculation overflow.
3189 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3190
437b2cb4
PE
3191 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3192
8b9ac8b4
PE
3193 * lread.c: Integer overflow fixes.
3194 (read_integer): Radix is now EMACS_INT, not int,
3195 to improve quality of diagnostics for out-of-range radices.
3196 Calculate buffer size correctly for out-of-range radices.
3197 (read1): Check for integer overflow in radices, and in
3198 read-circle numbers.
82cb60d3
PE
3199 (read_escape): Avoid int overflow.
3200 (Fload, openp, read_buffer_size, read1)
3201 (substitute_object_recurse, read_vector, read_list, map_obarray):
3202 Use ptrdiff_t, not int, for sizes.
3203 (read1): Use EMACS_INT, not int, for sizes.
20270765 3204 Check for size overflow.
8b9ac8b4 3205
7fcccf1e
PE
3206 * image.c (cache_image): Check for size arithmetic overflow.
3207
bfbbd7e7
PE
3208 * lread.c: Integer overflow issues.
3209 (saved_doc_string_size, saved_doc_string_length)
3210 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3211 Now ptrdiff_t, not int.
3212 (read1): Don't assume doc string length fits in int. Check for
3213 out-of-range doc string lengths.
3214 (read_list): Don't assume file position fits in int.
39019e54 3215 (read_escape): Check for hex character overflow.
bfbbd7e7 3216
4e323265
LL
32172011-06-22 Leo Liu <sdl.web@gmail.com>
3218
3219 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3220 Move to minibuffer.el.
3221
85fece3e
PE
32222011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3223
20b84ce9 3224 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
3225 The following patches are for when GLYPH_DEBUG && !XASSERT.
3226 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3227 * dispnew.c (flush_stdout):
3228 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3229 Mark as externally visible.
3230 * dispnew.c (check_window_matrix_pointers): Now static.
3231 * dispnew.c (window_to_frame_vpos):
3232 * xfns.c (unwind_create_frame):
3233 * xterm.c (x_check_font): Remove unused local.
3234 * scroll.c (CHECK_BOUNDS):
3235 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3236 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3237 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3238 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3239 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3240 Now static.
3241 (debug_method_add): Use va_list and vsprintf rather than relying
3242 on undefined behavior with wrong number of arguments.
3243 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3244 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3245 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3246 since we're not interested in debugging glyphs with old libraries.
3247 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3248 GCC 4.6.0's static checking.
3249
0766b489
PE
32502011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3251
31fd4b32
PE
3252 Integer overflow and signedness fixes (Bug#8873).
3253 A few related buffer overrun fixes, too.
3254
b79e8648
PE
3255 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3256
0766b489
PE
3257 * dispextern.h (struct face.stipple):
3258 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3259 (x_bitmap_mask, x_allocate_bitmap_record)
3260 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3261 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3262 (x_create_bitmap_from_xpm_data):
3263 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3264 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3265 (.bitmaps_last):
3266 * xfaces.c (load_pixmap):
3267 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3268 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3269 (.bitmaps_last, struct x_output.icon_bitmap):
3270 Use ptrdiff_t, not int, for bitmap indexes.
3271 (x_allocate_bitmap_record): Check for size overflow.
3272 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3273
b081724f
PE
3274 Use ptrdiff_t, not int, for overlay counts.
3275 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3276 * editfns.c (overlays_around, get_pos_property):
3277 * textprop.c (get_char_property_and_overlay):
3278 * xdisp.c (next_overlay_change, note_mouse_highlight):
3279 * xfaces.c (face_at_buffer_position):
21514da7
PE
3280 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3281 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3282 (Fnext_overlay_change, Fprevious_overlay_change)
3283 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 3284 Use ptrdiff_t, not int, for sizes.
21514da7 3285 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 3286
3de73e5e
PE
3287 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3288
2606c57b
PE
3289 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3290 (x_session_initialize): Do not assume string length fits in int.
3291
aaafe47a
PE
3292 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3293 This is unlikely, but can occur if DPI is outlandish.
3294
2674ddc8 3295 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
3296 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3297
28154962
PE
3298 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3299 * xrdb.c (magic_file_p, search_magic_path):
3300 Omit last arg SUFFIX; it was always 0. All callers changed.
3301 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3302
7de51af5
PE
3303 * xfont.c (xfont_match): Avoid need for strlen.
3304
25ed6cc3
PE
3305 * xfns.c: Don't assume strlen fits in int.
3306 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3307
4eab31dd
PE
3308 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3309 not unsigned long, as we prefer signed integers. All callers changed.
3310 Detect integer overflow in repeat count.
3311 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 3312 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 3313
171e2a58
PE
3314 * termcap.c: Don't assume sizes fit in int and never overflow.
3315 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3316 (gobble_line): Check for size-calculation overflow.
3317
ad39faca 3318 * minibuf.c (Fread_buffer):
6e5bb2dc 3319 * lread.c (intern, intern_c_string):
74ca2eb3
PE
3320 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3321 Don't assume string length fits in int.
3322
52c61c22 3323 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
3324 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3325
b5b8c9e5
PE
3326 * font.c: Don't assume string length fits in int.
3327 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3328 Use ptrdiff_t, not int.
ccd6111c
PE
3329 (font_intern_prop): Don't assume string length fits in int.
3330 Don't assume integer property fits in fixnum.
3331 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 3332
882f0d81 3333 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 3334 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
3335 Reformulate so as not to need the command string.
3336 Invoke gzip -cd rather than gunzip, as it's more portable.
3337 (lock_info_type, lock_file_1, lock_file):
3338 Don't assume pid_t and time_t fit in unsigned long.
3339 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3340 (current_lock_owner): Prefer signed type for sizes.
3341 Use memcpy, not strncpy, where memcpy is what is really wanted.
3342 Don't assume (via atoi) that time_t and pid_t fit in int.
3343 Check for time_t and/or pid_t out of range, e.g., via a network share.
3344 Don't alloca where an auto var works fine.
3345
93f4cf88
PE
3346 * fileio.c: Fix some integer overflow issues.
3347 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3348 Don't assume string length fits in int.
3349 (directory_file_name): Don't assume string length fits in long.
3350 (make_temp_name): Don't assume pid fits in int, or that its print
3351 length is less than 20.
3352
f3e92b69
PE
3353 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3354
1bfdaf10
PE
3355 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3356
35016e9a
PE
3357 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3358
3d1e65a1
PE
3359 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3360 We prefer signed integers, even for size calculations.
3361
0b963a93
PE
3362 * emacs.c: Don't assume string length fits in 'int'.
3363 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3364 (main): Don't invoke strlen when not needed.
3365
573f4b54
PE
3366 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3367 (XD_DEBUG_MESSAGE): Don't waste a byte.
3368
989f33ba
PE
3369 * callproc.c (getenv_internal_1, getenv_internal)
3370 (Fgetenv_internal):
965d34eb
PE
3371 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3372
e4d29b33
PE
3373 * lread.c (invalid_syntax): Omit length argument.
3374 All uses changed. This doesn't fix a bug, but it simplifies the
3375 code away from its former Hollerith-constant appearance, and it's
3376 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 3377 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 3378
eb49b136
PE
3379 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3380 This didn't break anything, but it didn't help either.
3381 It's confusing to put a bogus integer in a place where the actual
3382 value does not matter.
9f62aeb1 3383 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 3384 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 3385
15375a22
PE
3386 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3387 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3388 implementation.
b61cc01c
PE
3389 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3390 We prefer signed types, and the value cannot exceed the EMACS_INT
3391 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
3392 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3393 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3394 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 3395
53b2623d
PE
3396 * indent.c (sane_tab_width): New function.
3397 (current_column, scan_for_column, Findent_to, position_indentation)
3398 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 3399 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 3400
51cab52b 3401 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 3402
f2ed8a70
PE
3403 * lisp.h (lint_assume): New macro.
3404 * composite.c (composition_gstring_put_cache):
3405 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3406
abe80cc6
PE
3407 * editfns.c, insdel.c:
3408 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 3409
b02c740e
PE
3410 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3411
ebc96716
PE
3412 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3413
b4e50fa0 3414 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 3415 Use much-faster test for byte-length change.
311d5d7c 3416 Don't assume string byte-length fits in 'int'.
a4cf38e4 3417 Check that character arg fits in 'int'.
85461888 3418 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 3419
c0c1ee9f
PE
3420 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3421
a498d7f4
PE
3422 * fns.c (concat): Catch string overflow earlier.
3423 Do not rely on integer wraparound.
3424
51cab52b
PE
3425 * dispextern.h (struct it.overlay_strings_charpos)
3426 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
3427 * xdisp.c (forward_to_next_line_start)
3428 (back_to_previous_visible_line_start)
3429 (reseat_at_next_visible_line_start, next_element_from_buffer):
3430 Don't arbitrarily truncate the value of 'selective' to int.
3431
76031fad
PE
3432 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3433
5eb55db9
PE
3434 * composite.c: Don't truncate sizes to 'int'.
3435 (composition_gstring_p, composition_reseat_it)
3436 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
3437 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3438 not EMACS_UINT, for indexes.
5eb55db9 3439
0703a717
PE
3440 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3441
d6202519
PE
3442 * buffer.c: Include <verify.h>.
3443 (struct sortvec.priority, struct sortstr.priority):
8961a454 3444 Now EMACS_INT, not int.
c20998a7 3445 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
3446 (struct sortstr.size, record_overlay_string)
3447 (struct sortstrlist.size, struct sortlist.used):
3448 Don't truncate size to int.
3449 (record_overlay_string): Check for size-calculation overflow.
d6202519 3450 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 3451
d5a19415
JM
34522011-06-22 Jim Meyering <meyering@redhat.com>
3453
029529ac 3454 Don't leak an XBM-image-sized buffer
d5a19415
JM
3455 * image.c (xbm_load): Free the image buffer after using it.
3456
a9041e6c
PE
34572011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3458
3459 Port to Sun C.
3460 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3461 that Sun C diagnosed.
3462 * fns.c (secure_hash): Fix pointer signedness issue.
3463 * intervals.c (static_offset_intervals): New function.
3464 (offset_intervals): Use it.
3465
7f3f739f
LL
34662011-06-21 Leo Liu <sdl.web@gmail.com>
3467
3468 * deps.mk (fns.o):
3469 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3470 sha512.h.
3471
3472 * fns.c (secure_hash): Rename from crypto_hash_function and change
3473 the first arg to accept symbols.
5b66d427 3474 (Fsecure_hash): New primitive.
7f3f739f
LL
3475 (syms_of_fns): New symbols.
3476
76147d94
DD
34772011-06-20 Deniz Dogan <deniz@dogan.se>
3478
3479 * process.c (Fset_process_buffer): Clarify return value in
3480 docstring.
3481
7d7d0045
CY
34822011-06-18 Chong Yidong <cyd@stupidchicken.com>
3483
3484 * dispnew.c (add_window_display_history): Use BVAR.
3485
3486 * xdisp.c (debug_method_add): Use BVAR.
3487 (check_window_end, dump_glyph_matrix, dump_glyph)
3488 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3489
3490 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3491 Likewise.
3492
3493 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3494 check till after the cache is created in init_frame_faces.
3495
ff2bc410
SM
34962011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3497
3498 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3499
28177add
PE
35002011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3501
dd3482fe
PE
3502 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3503 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3504 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3505
393d71f3 3506 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
3507 * fileio.c (Finsert_file_contents):
3508 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3509 Remove the old (too-loose) buffer overflow checks.
3510 They weren't needed, since make_gap checks for buffer overflow.
3511 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3512 The old code merely checked for Emacs fixnum overflow, and relied
3513 on undefined (wraparound) behavior. The new code avoids undefined
3514 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3515
2e6813b0 3516 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
3517 Tune. Don't use wider integers than needed. Don't use alloca.
3518 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 3519
599a9e4f
PE
3520 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3521
99561444
PE
3522 * insdel.c, lisp.h (buffer_overflow): New function.
3523 (insert_from_buffer_1, replace_range, replace_range_2):
3524 * insdel.c (make_gap_larger):
3525 * editfns.c (Finsert_char):
3526 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3527
28177add
PE
3528 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3529
e69dafad
PE
35302011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3531
a7af7fde 3532 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 3533
b1c46f02
PE
3534 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3535 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3536
e69dafad
PE
3537 * fileio.c: Don't assume EMACS_INT fits in off_t.
3538 (emacs_lseek): New static function.
3539 (Finsert_file_contents, Fwrite_region): Use it.
3540 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3541
566684ea
PE
3542 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3543
e6966cd6
PE
3544 * fns.c: Don't overflow int when computing a list length.
3545 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3546 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3547 truncation on 64-bit hosts. Check for QUIT every
3548 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3549 faster and is responsive enough.
3550 (Flength): Report an error instead of overflowing an integer.
3551 (Fsafe_length): Return a float if the value is not representable
3552 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 3553 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 3554 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 3555
dd0b0efb
PE
3556 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3557 (header_size, word_size): New constants.
3558 (allocate_vectorlike): Don't check size overflow here.
3559 (allocate_vector): Check it here instead, since this is the only
3560 caller of allocate_vectorlike that could cause overflow.
3561 Check that the new vector's length is representable as a fixnum.
3562
86fe5cfe
PE
3563 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3564 The previous code was bogus. For example, next_almost_prime (32)
3565 returned 39, which is undesirable as it is a multiple of 3; and
3566 next_almost_prime (24) returned 25, which is a multiple of 5 so
3567 why was the code bothering to check for multiples of 7?
3568
80e88859
PE
3569 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3570
4a2f0ad6
PE
3571 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3572
f66c7cf8
PE
3573 Variadic C functions now count arguments with ptrdiff_t.
3574 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3575 Back then I didn't know that the Emacs coding style prefers signed int.
3576 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
3577 were being counted with int, which may truncate counts on 64-bit
3578 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
3579 * lisp.h (struct Lisp_Subr.function.aMANY)
3580 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3581 Arg counts are now ptrdiff_t, not size_t.
3582 All variadic functions and their callers changed accordingly.
3583 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3584 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3585 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3586 * callint.c (Fcall_interactively): Check arg count for overflow,
3587 to avoid potential buffer overrun. Use signed char, not 'int',
3588 for 'varies' array, so that we needn't bother to check its size
3589 calculation for overflow.
3590 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3591 * eval.c (apply_lambda):
3592 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3593 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3594 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3595
a1759b76
PE
3596 * callint.c (Fcall_interactively): Don't use index var as event count.
3597
d96be9fc
PE
3598 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3599 * mem-limits.h (SIZE): Remove; no longer used.
3600
a690a978 3601 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 3602
578c21e6
PE
3603 Remove unnecessary casts.
3604 * xterm.c (x_term_init):
3605 * xfns.c (x_set_border_pixel):
3606 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3607 These aren't needed now that we assume ANSI C.
3608
96f53c6c
PE
3609 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3610 It's more likely to cause problems (due to unsigned overflow)
3611 than to cure them.
3612
83c77d31
PE
3613 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3614
ee2079f1
PE
3615 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3616
6da65536
PE
3617 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3618
7147c4a4
PE
3619 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3620
193e32d9
PE
3621 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3622
e5533da6
PE
3623 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3624
9910e595
PE
3625 GLYPH_CODE_FACE returns EMACS_INT, not int.
3626 * dispextern.h (merge_faces):
3627 * xfaces.c (merge_faces):
01103c44
PE
3628 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3629 Don't assume EMACS_INT fits in int.
9910e595 3630
2638320e
PE
3631 * character.h (CHAR_VALID_P): Remove unused parameter.
3632 * fontset.c, lisp.h, xdisp.c: All uses changed.
3633
045eb8d9
PE
3634 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3635
c1f134b5
PE
3636 * fns.c (concat): Minor tuning based on overflow analysis.
3637 This doesn't fix any bugs. Use int to hold character, instead
3638 of constantly refetching from Emacs object. Use XFASTINT, not
3639 XINT, for value known to be a character. Don't bother comparing
3640 a single byte to 0400, as it's always less.
3641
395fcb93 3642 * floatfns.c (Fexpt):
327eeec8
PE
3643 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3644
abbd3d23
PE
3645 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3646 for characters.
3647
684a03ef
PE
3648 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3649
0fed43f3
PE
3650 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3651 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3652 incorrectly succeed when S was a string, because 4294967386 was
3653 truncated before it was used.
3654
8fd02eb7
PE
3655 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3656 Otherwise, an out-of-range integer could cause undefined behavior
3657 on a 64-bit host.
3658
f8c86b69
PE
3659 * composite.c: Use int, not EMACS_INT, for characters.
3660 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3661 EMACS_INT, for values that are known to be in character range.
3662 This doesn't fix any bugs but is the usual style inside Emacs and
3663 may generate better code on 32-bit machines.
3664
34206dd2
PE
3665 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3666 This is for reasons similar to the recent CHAR_STRING fix.
3667 * charset.c (Fencode_char): Check that character arg is actually
3668 a character. Pass an int to ENCODE_CHAR.
3669 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3670 wider than 'int', as a compile-time check to prevent future regressions
3671 in this area.
3672
c5958d4c 3673 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
3674
3675 Make sure a 64-bit char is never passed to CHAR_STRING.
3676 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3677 by silently ignoring the top 32 bits, allowing some values
3678 that were far too large to be valid characters.
3679 * character.h: Include <verify.h>.
3680 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3681 arguments are no wider than unsigned, as a compile-time check
3682 to prevent future regressions in this area.
3683 * data.c (Faset):
01103c44 3684 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
3685 (Fsubst_char_in_region):
3686 * fns.c (concat):
3687 * xdisp.c (decode_mode_spec_coding):
3688 Adjust to CHAR_STRING's new requirement.
3689 * editfns.c (Finsert_char, Fsubst_char_in_region):
3690 * fns.c (concat): Check that character args are actually
3691 characters. Without this test, these functions did the wrong
3692 thing with wildly out-of-range values on 64-bit hosts.
3693
d37ca623
PE
3694 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3695 These casts should not be needed on 32-bit hosts, either.
3696 * keyboard.c (read_char):
3697 * lread.c (Fload): Remove casts to unsigned.
3698
ea204efb
PE
3699 * lisp.h (UNSIGNED_CMP): New macro.
3700 This fixes comparison bugs on 64-bit hosts.
3701 (ASCII_CHAR_P): Use it.
3702 * casefiddle.c (casify_object):
01103c44 3703 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
3704 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3705 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3706 * dispextern.h (FACE_FROM_ID):
3707 * keyboard.c (read_char): Use UNSIGNED_CMP.
3708
41cb286c
PE
3709 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3710 not to EMACS_INT, to avoid GCC warning.
3711
4a1b9832
PE
3712 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3713
55daad71
PE
3714 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3715 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3716 isn't needed on 32-bit machines.
8f95c75c 3717
01103c44
PE
3718 * buffer.c (Fgenerate_new_buffer_name):
3719 Use EMACS_INT for count, not int.
0ceccced 3720 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
3721
3722 * data.c (Qcompiled_function): Now static.
3723
c6f072e7
PE
3724 * window.c (window_body_lines): Now static.
3725
20ce5912
PE
3726 * image.c (gif_load): Rename local to avoid shadowing.
3727
9c4c5f81
PE
3728 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3729 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3730 * alloc.c (make_save_value): Integer argument is now of type
3731 ptrdiff_t, not int.
3732 (mark_object): Use ptrdiff_t, not int.
3733 * lisp.h (pD): New macro.
3734 * print.c (print_object): Use it.
3735
c0c5c8ae
PE
3736 * alloc.c: Use EMACS_INT, not int, to count objects.
3737 (total_conses, total_markers, total_symbols, total_vector_size)
3738 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
3739 (total_free_floats, total_floats, total_free_intervals)
3740 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
3741 Now EMACS_INT, not int. All uses changed.
3742 (Fgarbage_collect): Compute overall total using a double, so that
3743 integer overflow is less likely to be a problem. Check for overflow
3744 when converting back to an integer.
5a25e253
PE
3745 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3746 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3747 These were 'int' variables that could overflow on 64-bit hosts;
3748 they were never used, so remove them instead of repairing them.
211a0b2a 3749 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
3750 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3751 Previously, this ceilinged at INT_MAX, but that doesn't work on
3752 64-bit machines.
e46bb31a 3753 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 3754
c78baabf 3755 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 3756 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
3757 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3758 when a (possibly-narrower) signed value would do just as well.
3759 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 3760
c9d624c6
PE
3761 * alloc.c: Catch some string size overflows that we were missing.
3762 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3763 for convenience in STRING_BYTES_MAX.
3764 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3765 The definition here is exact; the one in lisp.h was approximate.
3766 (allocate_string_data): Check for string overflow. This catches
3767 some instances we weren't catching before. Also, it catches
3768 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3769 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3770 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 3771
c9d624c6
PE
3772 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3773 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 3774 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 3775
353032ce
PE
3776 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3777
2bccce07
PE
3778 * alloc.c (Fmake_string): Check for out-of-range init.
3779
0ac30604
SM
37802011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3781
3782 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3783
c195f2de
JD
37842011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3785
3786 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3787 xg_get_default_scrollbar_width.
3788
3789 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3790 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3791 (style_changed_cb): Call update_theme_scrollbar_width and call
3792 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3793 all frames (Bug#8505).
3794 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3795 Call gtk_window_set_resizable if HAVE_GTK3.
3796 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3797 and height if HAVE_GTK3 (Bug#8505).
3798 (scroll_bar_width_for_theme): New variable.
3799 (update_theme_scrollbar_width): New function.
3800 (xg_get_default_scrollbar_width): Move code to
3801 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3802 (xg_initialize): Call update_theme_scrollbar_width.
3803
3804 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3805
3806 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3807
e10ac9f1
MR
38082011-06-12 Martin Rudalics <rudalics@gmx.at>
3809
3810 * frame.c (make_frame): Call other_buffer_safely instead of
3811 other_buffer.
3812
3813 * window.c (temp_output_buffer_show): Call display_buffer with
3814 second argument Vtemp_buffer_show_specifiers and reset latter
3815 immediately after the call.
3816 (Vtemp_buffer_show_specifiers): New variable.
3817 (auto_window_vscroll_p, next_screen_context_lines)
3818 (Vscroll_preserve_screen_position): Remove leading asterisks from
3819 doc-strings.
3820
2d3c217e 38212011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 3822
7b7f97e8 3823 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
3824 * buffer.c (Qclone_number): Remove for now, as it's unused.
3825 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3826 (record_buffer): Remove unused local.
3827 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3828 (set_frame_buffer_list): Remove; unused.
3829 * frame.h (other_visible_frames): Remove decl.
3830 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3831 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3832 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3833 if HAVE_GPM.
3834 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3835 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3836 Define only if HAVE_GPM.
3837 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3838 (update_hints_inhibit): Remove; never set. All uses removed.
3839 * widgetprv.h (emacsFrameClassRec): Remove decl.
3840 * window.c (delete_deletable_window): Now returns void, since it
3841 wasn't returning anything.
3842 (compare_window_configurations): Remove unused locals.
3843 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3844 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
3845 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3846 the same widths as pointers. This follows up on the 2011-05-06 patch.
3847 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3848 * xterm.h: Likewise.
3849 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3850
1384b89e
JB
38512011-06-12 Juanma Barranquero <lekktu@gmail.com>
3852
3853 * makefile.w32-in: Update dependencies.
3854 (LISP_H): Add lib/intprops.h.
3855
1100a63c
CY
38562011-06-11 Chong Yidong <cyd@stupidchicken.com>
3857
3858 * image.c (gif_load): Add animation frame delay to the metadata.
3859 (syms_of_image): Use DEFSYM. New symbol `delay'.
3860
6198ccd0
MR
38612011-06-11 Martin Rudalics <rudalics@gmx.at>
3862
3863 * window.c (delete_deletable_window): Re-add.
3864 (Fset_window_configuration): Rewrite to handle dead buffers and
3865 consequently deletable windows.
3866 (window_tree, Fwindow_tree): Remove. Supply functionality in
3867 window.el.
3868 (compare_window_configurations): Simplify code.
3869
b6e3633c
AS
38702011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3871
1ab0dee5
AS
3872 * image.c (imagemagick_load_image): Fix type mismatch.
3873 (Fimagemagick_types): Likewise.
3874
b6e3633c
AS
3875 * window.h (replace_buffer_in_windows): Declare.
3876
9397e56f
MR
38772011-06-11 Martin Rudalics <rudalics@gmx.at>
3878
3879 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3880 Qclone_number. Remove external declaration of Qdelete_window.
3881 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3882 code.
640c8776
SM
3883 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3884 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
3885 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3886 buffer list implementation.
3887 (other_buffer_safely): New function.
3888 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3889 calls to replace_buffer_in_windows and
3890 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3891 if allowed.
3892 (record_buffer): Inhibit quitting and rewrite using quittable
3893 functions. Run Qbuffer_list_update_hook if allowed.
3894 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
3895 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3896 Move switch-to-buffer to window.el.
9397e56f
MR
3897 (bury-buffer): Move to window.el.
3898 (Vbuffer_list_update_hook): New variable.
3899
3900 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3901 section.
3902
3903 * window.h (resize_frame_windows): Move up in code.
3904 (Fwindow_frame): Remove EXFUN.
3905 (replace_buffer_in_all_windows): Remove prototype.
3906 (replace_buffer_in_windows_safely): Add prototype.
3907
3908 * window.c: Declare Qdelete_window static again. Move down
3909 declaration of select_count.
3910 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3911 (Fother_window): Move to window.el.
3912 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3913 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3914 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3915 window.el.
3916 (replace_buffer_in_windows): Implement by calling
3917 Qreplace_buffer_in_windows.
3918 (replace_buffer_in_all_windows): Remove with some functionality
3919 moved into replace_buffer_in_windows_safely.
3920 (replace_buffer_in_windows_safely): New function.
3921 (select_window_norecord, select_frame_norecord): Move in front
3922 of run_window_configuration_change_hook. Remove now obsolete
3923 declarations.
640c8776
SM
3924 (Fset_window_buffer): Rewrite doc-string.
3925 Call Qrecord_window_buffer.
9397e56f
MR
3926 (keys_of_window): Move binding for other-window to window.el.
3927
b50691aa
CY
39282011-06-11 Chong Yidong <cyd@stupidchicken.com>
3929
3930 * dispextern.h (struct image): Replace data member, whose int_val
3931 and ptr_val fields were not used by anything, with a single
3932 lisp_val object.
3933
3934 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3935 (gif_clear_image, gif_load, imagemagick_load_image)
3936 (gs_clear_image, gs_load): Callers changed.
3937
3f754b86
PE
39382011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3939
cca69397
PE
3940 * buffer.h: Include <time.h>, for time_t.
3941 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3942
109e28d0
PE
3943 Fix minor problems found by static checking.
3944
60737f02
PE
3945 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3946
4b66faf3
PE
3947 Make identifiers static if they are not used in other modules.
3948 * data.c (Qcompiled_function, Qframe, Qvector):
3949 * image.c (QimageMagick, Qsvg):
3950 * minibuf.c (Qmetadata):
3951 * window.c (resize_window_check, resize_root_window): Now static.
3952 * window.h (resize_window_check, resize_root_window): Remove decls.
3953
109e28d0
PE
3954 * window.c (window_deletion_count, delete_deletable_window):
3955 Remove; unused.
46a4ce9e
PE
3956 (window_body_lines): Now static.
3957 (Fdelete_other_windows_internal): Mark vars as initialized.
3958 Make sure 'resize_failed' is initialized.
3959 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3960 (resize_window_apply): Remove unused local.
3961 * window.h (delete_deletable_window): Remove decl.
3962
109e28d0 3963 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
3964 (imagemagick_load_image): Fix pointer signedness problem by changing
3965 last arg from unsigned char * to char *. All uses changed.
3966 Also, fix a local for similar reasons.
3967 Remove unused locals. Remove locals to avoid shadowing.
3968 (fn_rsvg_handle_free): Remove; unused.
3969 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 3970 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 3971
3f754b86
PE
3972 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3973
2547adb1
CY
39742011-06-10 Chong Yidong <cyd@stupidchicken.com>
3975
3976 * image.c (gif_load): Fix omitted cast error introduced by
3977 2011-06-06 change.
3978
2c8e37d4
MR
39792011-06-10 Martin Rudalics <rudalics@gmx.at>
3980
3981 * window.h (resize_proportionally, orig_total_lines)
3982 (orig_top_line): Remove from window structure.
3983 (set_window_height, set_window_width, change_window_heights)
3984 (Fdelete_window): Remove prototypes.
3985 (resize_frame_windows): Remove duplicate declaration.
3986
440a42e3
EZ
39872011-06-10 Eli Zaretskii <eliz@gnu.org>
3988
3989 * window.h (resize_frame_windows, resize_window_check)
3990 (delete_deletable_window, resize_root_window)
3991 (resize_frame_windows): Declare prototypes.
3992
3993 * window.c (resize_window_apply): Make definition be "static" to
3994 match the prototype.
3995
562dd5e9
MR
39962011-06-10 Martin Rudalics <rudalics@gmx.at>
3997
3998 * window.c: Remove declarations of Qwindow_size_fixed,
3999 window_min_size_1, window_min_size_2, window_min_size,
4000 size_window, window_fixed_size_p, enlarge_window, delete_window.
4001 Remove static from declaration of Qdelete_window, it's
4002 temporarily needed by Fbury_buffer.
4003 (replace_window): Don't assign orig_top_line and
4004 orig_total_lines.
4005 (Fdelete_window, delete_window): Remove. Window deletion is
4006 handled by window.el.
640c8776
SM
4007 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4008 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
4009 (Fdelete_other_windows): Remove. Deleting other windows is
4010 handled by window.el.
4011 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4012 handled in window.el.
4013 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4014 Window minimum sizes are handled in window.el.
4015 (shrink_windows, size_window, set_window_height)
4016 (set_window_width, change_window_heights, window_height)
4017 (window_width, CURBEG, CURSIZE, enlarge_window)
4018 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4019 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4020 handled in window.el.
4021 (make_dummy_parent): Rename to make_parent_window and give it a
4022 second argument horflag.
4023 (make_window): Don't set resize_proportionally any more.
4024 (Fsplit_window): Remove. Windows are split in window.el.
4025 (save_restore_action, save_restore_orig_size)
4026 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4027 Resize mini windows in window.el.
4028 (grow_mini_window, shrink_mini_window): Implement by calling
4029 Qresize_root_window_vertically, resize_window_check and
4030 resize_window_apply.
640c8776
SM
4031 (saved_window, Fset_window_configuration, save_window_save):
4032 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
4033 resize_proportionally.
4034 (window_min_height, window_min_width): Move to window.el.
4035 (keys_of_window): Move bindings for delete-other-windows,
4036 split-window, delete-window and enlarge-window to window.el.
4037
4038 * buffer.c: Temporarily extern Qdelete_window.
4039 (Fbury_buffer): Temporarily call Qdelete_window instead of
4040 Fdelete_window (Fbury_buffer will move to window.el soon).
4041
4042 * frame.c (set_menu_bar_lines_1): Remove code handling
4043 orig_top_line and orig_total_lines.
4044
4045 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4046 set_window_height but set heights directly.
4047 (change_frame_size_1): Use resize_frame_windows.
4048
4049 * xdisp.c (init_xdisp): Don't use set_window_height but set
4050 heights directly.
4051
640c8776
SM
4052 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4053 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
4054 run_window_configuration_change_hook.
4055
4056 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4057 instead of change_window_heights and run
4058 run_window_configuration_change_hook.
4059
1a13852e
MR
40602011-06-09 Martin Rudalics <rudalics@gmx.at>
4061
4062 * window.c (replace_window): Rename second argument REPLACEMENT to
4063 NEW. New third argument SETFLAG. Rewrite.
4064 (delete_window, make_dummy_parent): Call replace_window with
4065 third argument 1.
4066 (window_list_1): Move down in code.
4067 (run_window_configuration_change_hook): Move set_buffer part
4068 before select_frame_norecord part in order to unwind correctly.
4069 Rename count1 to count.
4070 (recombine_windows, delete_deletable_window, resize_root_window)
4071 (Fdelete_other_windows_internal)
4072 (Frun_window_configuration_change_hook, make_parent_window)
4073 (resize_window_check, resize_window_apply, Fresize_window_apply)
4074 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
4075 (Fdelete_window_internal, Fresize_mini_window_internal):
4076 New functions.
1a13852e
MR
4077 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4078
f3d1777e
MR
40792011-06-08 Martin Rudalics <rudalics@gmx.at>
4080
496e208e
MR
4081 * window.h (window): Add some new members to window structure -
4082 normal_lines, normal_cols, new_total, new_normal, clone_number,
4083 splits, nest, prev_buffers, next_buffers.
4084 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 4085 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 4086
f3d1777e
MR
4087 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4088 Remove.
496e208e
MR
4089 (make_dummy_parent): Set new members of windows structure.
4090 (make_window): Move down in code. Handle new members of window
4091 structure.
4092 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4093 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4094 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4095 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
4096 (Fset_window_next_buffers, Fset_window_clone_number):
4097 New functions.
496e208e
MR
4098 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4099 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4100 Doc-string fixes.
4101 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4102 Argument WINDOW can be now internal window too.
4103 (Fwindow_use_time): Move up in code.
4104 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4105 Rewrite doc-string.
4106 (Fset_window_configuration, saved_window)
4107 (Fcurrent_window_configuration, save_window_save): Handle new
4108 members of window structure.
b9e809c2
MR
4109 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4110 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4111 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4112 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4113 Qget_mru_window, Qresize_root_window,
4114 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4115 Qauto_buffer_name; staticpro them.
f3d1777e 4116
abde8f8c
MR
41172011-06-07 Martin Rudalics <rudalics@gmx.at>
4118
4119 * window.c (Fwindow_total_size, Fwindow_left_column)
4120 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4121 (Fwindow_list_1): New functions.
4122 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
4123 (Fwindow_width, Fscroll_left, Fscroll_right):
4124 Use window_body_cols instead of window_box_text_cols.
4125 (delete_window, Fset_window_configuration):
4126 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
4127 (delete_all_subwindows): Take a window as argument and not a
4128 structure. Rewrite.
190b47e6
MR
4129 (window_loop): Remove handling of GET_LRU_WINDOW and
4130 GET_LARGEST_WINDOW.
4131 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
4132
4133 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
4134 window_box_text_cols. delete_all_subwindows now takes a
4135 Lisp_Object as argument.
abde8f8c 4136
640c8776
SM
4137 * indent.c (compute_motion, Fcompute_motion):
4138 Use window_body_cols instead of window_box_text_cols.
abde8f8c 4139
fa8a67e6
MR
4140 * frame.c (delete_frame): Call delete_all_subwindows with root
4141 window as argument.
4142
a54e3482
DC
41432011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4144
4145 * fns.c (Fputhash): Document return value.
4146
60002bf5
CY
41472011-06-06 Chong Yidong <cyd@stupidchicken.com>
4148
4149 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4150
0c671da6 41512011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 4152
b862a52a 4153 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 4154
be44ca6c
PE
4155 Check for overflow when converting integer to cons and back.
4156 * charset.c (Fdefine_charset_internal, Fdecode_char):
4157 Use cons_to_unsigned to catch overflow.
4158 (Fencode_char): Use INTEGER_TO_CONS.
4159 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4160 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4161 * data.c (long_to_cons, cons_to_long): Remove.
4162 (cons_to_unsigned, cons_to_signed): New functions.
4163 These signal an error for invalid or out-of-range values.
4164 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4165 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4166 * font.c (Ffont_variation_glyphs):
4167 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4168 * lisp.h: Include <intprops.h>.
4169 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4170 (cons_to_signed, cons_to_unsigned): New decls.
4171 (long_to_cons, cons_to_long): Remove decls.
4172 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4173 (Fprimitive_undo): Use CONS_TO_INTEGER.
4174 * xfns.c (Fx_window_property): Likewise.
4175 * xselect.c: Include <limits.h>.
4176 (x_own_selection, selection_data_to_lisp_data):
4177 Use INTEGER_TO_CONS.
4178 (x_handle_selection_request, x_handle_selection_clear)
4179 (x_get_foreign_selection, Fx_disown_selection_internal)
4180 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4181 (lisp_data_to_selection_data): Use cons_to_unsigned.
4182 (x_fill_property_data): Use cons_to_signed.
4183 Report values out of range.
4184
d1f3d2af
PE
4185 Check for buffer and string overflow more precisely.
4186 * buffer.h (BUF_BYTES_MAX): New macro.
4187 * lisp.h (STRING_BYTES_MAX): New macro.
4188 * alloc.c (Fmake_string):
4189 * character.c (string_escape_byte8):
4190 * coding.c (coding_alloc_by_realloc):
4191 * doprnt.c (doprnt):
4192 * editfns.c (Fformat):
4193 * eval.c (verror):
4194 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4195 since they may not be the same number.
4196 * editfns.c (Finsert_char):
4197 * fileio.c (Finsert_file_contents):
4198 Likewise for BUF_BYTES_MAX.
4199
dd52fcea
PE
4200 * image.c: Use ptrdiff_t, not int, for sizes.
4201 (slurp_file): Switch from int to ptrdiff_t.
4202 All uses changed.
4203 (slurp_file): Check that file size fits in both size_t (for
4204 malloc) and ptrdiff_t (for sanity and safety).
4205
7f9bbdbb
PE
4206 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4207 if b->modtime has its maximal value.
4208
dfe18f82
PE
4209 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4210
84acfcf0
PE
4211 Don't assume time_t can fit into int.
4212 * buffer.h (struct buffer.modtime): Now time_t, not int.
4213 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4214 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4215
ccd9a01a
PE
4216 Minor fixes for signed vs unsigned integers.
4217 * character.h (MAYBE_UNIFY_CHAR):
4218 * charset.c (maybe_unify_char):
4219 * keyboard.c (read_char, reorder_modifiers):
4220 XINT -> XFASTINT, since the integer must be nonnegative.
4221 * ftfont.c (ftfont_spec_pattern):
4222 * keymap.c (access_keymap, silly_event_symbol_error):
4223 XUINT -> XFASTINT, since the integer must be nonnegative.
4224 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4225 since it makes no difference and we prefer signed.
4226 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4227 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4228 nonnegative.
4229
d6d100dd
SM
42302011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4231
4232 * window.h (Fwindow_frame): Declare.
4233
2b6148e4
PE
42342011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4235
4236 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4237 (SPARE_MEMORY): Always define.
4238 (LARGE_REQUEST): Remove.
4239 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4240
f230ecc9
MR
42412011-06-06 Martin Rudalics <rudalics@gmx.at>
4242
727e958e
MR
4243 * lisp.h: Move EXFUNS for Fframe_root_window,
4244 Fframe_first_window and Fset_frame_selected_window to window.h.
4245
4246 * window.h: Move EXFUNS for Fframe_root_window,
4247 Fframe_first_window and Fset_frame_selected_window here from
4248 lisp.h.
4249
4250 * frame.c (Fwindow_frame, Fframe_first_window)
4251 (Fframe_root_window, Fframe_selected_window)
4252 (Fset_frame_selected_window): Move to window.c.
4253 (Factive_minibuffer_window): Move to minibuf.c.
4254 (Fother_visible_frames_p): New function.
4255
4256 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4257
f230ecc9
MR
4258 * window.c (decode_window, decode_any_window): Move up in code.
4259 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4260 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
4261 (Fwindow_buffer): Move up and rewrite doc-string.
4262 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4263 (Fwindow_prev): New functions.
727e958e
MR
4264 (Fwindow_frame): Move here from frame.c. Accept any window as
4265 argument.
4266 (Fframe_root_window, Fframe_first_window)
4267 (Fframe_selected_window): Move here from frame.c. Accept frame
4268 or arbitrary window as argument. Update doc-strings.
4269 (Fminibuffer_window): Move up in code.
4270 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
4271 (Fset_frame_selected_window): Move here from frame.c.
4272 Marginal rewrite.
727e958e
MR
4273 (Fselected_window, select_window, Fselect_window): Move up in
4274 code. Minor doc-string fixes.
f230ecc9 4275
4d09bcf6
PE
42762011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4277
4278 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4279 Do not assume that spare memory exists; that assumption is valid
4280 only if SYSTEM_MALLOC.
4281 (LARGE_REQUEST): New macro, so that the issue of large requests
4282 is separated from the issue of spare memory.
4283
810928a2
AS
42842011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4285
172418ad
AS
4286 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4287 format. (Bug#8806)
4288
43f862f7
AS
4289 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4290
810928a2
AS
4291 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4292 before statements.
4293
a059fe24
JD
42942011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4295
4296 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4297
4298 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4299
4300 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4301 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4302
989bf368
JB
43032011-06-05 Juanma Barranquero <lekktu@gmail.com>
4304
4305 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4306
4b80f674
CY
43072011-06-04 Chong Yidong <cyd@stupidchicken.com>
4308
4309 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4310 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
4311 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4312 New error handlers.
4b80f674
CY
4313 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4314 Obey Vx_select_enable_clipboard_manager. Catch errors in
4315 x_clipboard_manager_save (Bug#8779).
4316 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 4317 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 4318
99a33b77 43192011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
4320
4321 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4322
99a33b77 43232011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
4324
4325 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4326 in the current matrix if keep_current_p is non-zero.
4327
8264569d
EZ
43282011-06-04 Eli Zaretskii <eliz@gnu.org>
4329
4330 * bidi.c (bidi_level_of_next_char): Fix last change.
4331
57f97249
EZ
43322011-06-03 Eli Zaretskii <eliz@gnu.org>
4333
fec2107c 4334 Support bidi reordering of text covered by display properties.
57f97249 4335
fec2107c
EZ
4336 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4337 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4338 (bidi_cache_search, bidi_cache_iterator_state)
4339 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
4340 (bidi_level_of_next_char, bidi_move_to_visually_next):
4341 Support character positions inside a run of characters covered by a
fec2107c
EZ
4342 display string.
4343 (bidi_paragraph_init, bidi_resolve_explicit_1)
4344 (bidi_level_of_next_char): Call bidi_fetch_char and
4345 bidi_fetch_char_advance instead of FETCH_CHAR and
4346 FETCH_CHAR_ADVANCE.
4347 (bidi_init_it): Initialize new members.
4348 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4349 definitions.
4350 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4351 instead of using explicit *_CHAR codes.
d6d100dd
SM
4352 (bidi_resolve_explicit, bidi_resolve_weak):
4353 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
4354 bidirectional text is supported only in multibyte buffers.
4355 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4356 it to initialize the frame_window_p member of struct bidi_it.
4357 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4358 (bidi_resolve_explicit, bidi_resolve_weak)
4359 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4360 bidi_it->nchars is non-positive.
4361 (bidi_level_of_next_char): Don't try to lookup the cache for the
4362 next/previous character if nothing is cached there yet, or if we
4363 were just reseat()'ed to a new position.
c40e2fb2 4364
0e14fe90
EZ
4365 * xdisp.c (set_cursor_from_row): Set start and stop points
4366 according to the row's direction when priming the loop that looks
4367 for the glyph on which to display cursor.
4368 (single_display_spec_intangible_p): Function deleted.
4369 (display_prop_intangible_p): Reimplement to call
4370 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
4371 Accept 3 additional arguments needed by handle_display_spec.
4372 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
4373 values: lists, `(when COND...)' forms, etc.
4374 (single_display_spec_string_p): Support property values that are
4375 lists with the argument STRING its top-level element.
4376 (display_prop_string_p): Fix the condition for processing a
4377 property that is a list to be consistent with handle_display_spec.
fec2107c 4378 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
4379 last portion of handle_display_prop.
4380 (compute_display_string_pos): Accept additional argument
4381 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4382 value of a `display' property is a "replacing spec".
4383 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4384 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4385 the display property, but just return a value indicating whether
4386 the display property will replace the characters it covers.
4387 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4388 frame_window_p members of struct bidi_it.
d6d100dd
SM
4389 (compute_display_string_pos, compute_display_string_end):
4390 New functions.
fec2107c
EZ
4391 (push_it): Accept second argument POSITION, where pop_it should
4392 jump to continue iteration.
4393 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 4394
fec2107c
EZ
4395 * keyboard.c (adjust_point_for_property): Adjust the call to
4396 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
4397
4398 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
4399 (bidi_init_it): Update prototypes.
4400 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
4401 (compute_display_string_pos, compute_display_string_end):
4402 Declare prototypes.
fec2107c
EZ
4403 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4404 EMACS_INT.
fc6f18ce 4405
40087514 44062011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 4407
57f53182
PE
4408 Malloc failure behavior now depends on size of allocation.
4409 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4410 * lisp.h: Change signatures accordingly.
4411 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4412 All callers changed. (Bug#8762)
4413
4414 * gnutls.c: Use Emacs's memory allocators.
4415 Without this change, the gnutls library would invoke malloc etc.
4416 directly, which causes problems on non-SYNC_INPUT hosts, and which
4417 runs afoul of improving memory_full behavior. (Bug#8761)
4418 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4419 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4420 xfree instead of the default malloc, realloc, free.
4421 (Fgnutls_boot): No need to check for memory allocation failure,
4422 since xmalloc does that for us.
4423
ac32cd99 4424 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
4425 * category.c (hash_get_category_set):
4426 * ccl.c (ccl_driver):
4427 * charset.c (Fdefine_charset_internal):
4428 * charset.h (struct charset.hash_index):
4429 * composite.c (get_composition_id, gstring_lookup_cache)
4430 (composition_gstring_put_cache):
4431 * composite.h (struct composition.hash_index):
4432 * dispextern.h (struct image.hash):
4433 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4434 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4435 (hashfn_equal, hashfn_user_defined, make_hash_table)
4436 (maybe_resize_hash_table, hash_lookup, hash_put)
4437 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4438 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4439 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4440 * image.c (make_image, search_image_cache, lookup_image)
4441 (xpm_put_color_table_h):
4442 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 4443 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 4444 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 4445 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
4446 * alloc.c (allocate_vectorlike):
4447 Check for overflow in vector size calculations.
4448 * ccl.c (ccl_driver):
4449 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
4450 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4451 need to be updated by these changes.
40087514
PE
4452 * fns.c (make_hash_table, maybe_resize_hash_table):
4453 Check for integer overflow with large hash tables.
0de4bb68
PE
4454 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4455 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4456 (SXHASH_REDUCE): New macro.
4457 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4458 Use it instead of discarding useful hash info with large hash values.
4459 (sxhash_float): New function.
4460 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4461 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
4462 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4463 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
4464 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4465 Adjust signatures to match updated version of code.
4466 (consing_since_gc): Now EMACS_INT, since a single hash table can
4467 use more than INT_MAX bytes.
4468
698d32e2
DN
44692011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4470
4471 Make it possible to build with GCC-4.6+ -O2 -flto.
4472
4473 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4474
fd6fa53f
SM
44752011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4476
4477 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4478 Call minibuffer-inactive-mode.
4479
864db017
JB
44802011-05-31 Juanma Barranquero <lekktu@gmail.com>
4481
4482 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4483 Update dependencies.
4484
2ad0baf4
DN
44852011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4486
4487 * data.c (init_data): Remove code for UTS, this system is not
4488 supported anymore.
4489
4fcc2638
DN
44902011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4491
4492 Don't force ./temacs to start in terminal mode.
4493
4494 * frame.c (make_initial_frame): Initialize faces in all cases, not
4495 only when CANNOT_DUMP is defined.
4496 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4497
c56e0fd5
DN
44982011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4499
4500 * dispnew.c (add_window_display_history): Use const for the string
4501 pointer. Remove declaration, not needed.
4502
333d54da 45032011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 4504
55d4c1b2 4505 Use 'inline', not 'INLINE'.
333d54da 4506 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
4507 * alloc.c, fontset.c (INLINE): Remove.
4508 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4509 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4510 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4511 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4512 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4513
738db178
DN
45142011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4515
4516 Make it possible to run ./temacs.
4517
4518 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4519 syms_of_callproc does the same thing. Remove test for
4520 "initialized", do it in the caller.
4521 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4522
620c53a6
SM
45232011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4524
4525 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4526 (read_minibuf): Use get_minibuffer.
4527 (syms_of_minibuf): Use DEFSYM.
4528 (Qmetadata): New var.
4529 * data.c (Qbuffer): Don't make it static.
4530 (syms_of_data): Use DEFSYM.
4531
e003a292
PE
45322011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4533
4534 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4535 (CCL_CODE_MIN): New macro.
4536
ed008a6d
PE
45372011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4538
3687c2ef
PE
4539 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4540
ed008a6d
PE
4541 * eval.c (Qdebug): Now static.
4542 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4543 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4544 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4545
d66c4c7c
CY
45462011-05-29 Chong Yidong <cyd@stupidchicken.com>
4547
4548 * image.c: Various fixes to ImageMagick code comments.
4549 (Fimagemagick_types): Doc fix.
4550
5fbc2025
PE
45512011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4552
0196f88a
PE
4553 Minor fixes prompted by GCC 4.6.0 warnings.
4554
4555 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4556
5fbc2025
PE
4557 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4558 (x_clipboard_manager_save_all): Move extern decl to ...
4559 * xterm.h: ... here, so that it can be checked for consistency.
4560
1dd3c2d9
CY
45612011-05-29 Chong Yidong <cyd@stupidchicken.com>
4562
4563 * xselect.c (x_clipboard_manager_save_frame)
4564 (x_clipboard_manager_save_all): New functions.
4565 (Fx_clipboard_manager_save): Lisp function deleted.
4566
4567 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4568 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4569
4570 * xterm.h: Update prototype.
4571
5ba6571d
WX
45722011-05-28 William Xu <william.xwl@gmail.com>
4573
4574 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4575 exiting (Bug#8239).
4576
3eaff834
JM
45772011-05-28 Jim Meyering <meyering@redhat.com>
4578
e1900994 4579 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
4580 * fns.c (to_uchar): Define.
4581 (crypto_hash_function): Use it to convert some newly-signed
4582 variables to unsigned, to avoid sign-extension bugs. For example,
4583 without this change, (md5 "truc") would evaluate to
4584 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4585 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 4586 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 4587
0f6990a7
PE
45882011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4589
4590 Integer overflow fixes.
c8a9ca5a 4591
08686060
PE
4592 * dbusbind.c: Serial number integer overflow fixes.
4593 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
4594 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4595 to hold a serial number that is too large for a fixnum.
4596 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4597 Check for serial numbers out of range. Decode any serial number
59568bf0 4598 that was so large that it became a float. (Bug#8722)
08686060 4599
2d1fc3c7
PE
4600 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4601 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4602 Use XFASTINT rather than XUINT when numbers are nonnegative.
4603 (xd_append_arg, Fdbus_method_return_internal):
4604 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4605 arguments, check that Lisp number is nonnegative, rather than
59568bf0 4606 silently wrapping negative numbers around. (Bug#8722)
30217ff0 4607 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 4608 (Bug#8722)
2d1fc3c7 4609
c8a9ca5a
PE
4610 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4611
519e1d69
PE
4612 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4613
30569699
PE
4614 ccl: add integer overflow checks
4615 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4616 (IN_INT_RANGE): New macros.
4617 (ccl_driver): Use them to check for integer overflow when
4618 decoding a CCL program. Many of the new checks are whether XINT (x)
4619 fits in int; it doesn't always, on 64-bit hosts. The new version
4620 doesn't catch all possible integer overflows, but it's an
847044ea 4621 improvement. (Bug#8719)
30569699 4622
c11285dc
PE
4623 * alloc.c (make_event_array): Use XINT, not XUINT.
4624 There's no need for unsigned here.
4625
fdccd48e
PE
4626 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4627 This follows up to the 2011-05-06 change that substituted uintptr_t
4628 for EMACS_INT. This case wasn't caught back then.
4629
37910ab2
PE
4630 Rework Fformat to avoid integer overflow issues.
4631 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4632 now (part of C89). Include <verify.h>.
4633 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4634 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4635 (Fformat): Avoid the prepass trying to compute sizes; it was only
4636 approximate and thus did not catch overflow reliably. Instead, walk
4637 through the format just once, formatting and computing sizes as we go,
4638 checking for integer overflow at every step, and allocating a larger
4639 buffer as needed. Keep track separately whether the format is
4640 multibyte. Keep only the most-recently calculated precision, rather
4641 than them all. Record whether each argument has been converted to
4642 string. Use EMACS_INT, not int, for byte and char and arg counts.
4643 Support field widths and precisions larger than INT_MAX. Avoid
4644 sprintf's undefined behavior with conversion specifications such as %#d
4645 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4646 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4647 formatting out-of-range floating point numbers with int
9173deec 4648 formats. (Bug#8668)
37910ab2 4649
2e6578fb
PE
4650 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4651
0ae6bdee
PE
4652 * data.c: Avoid integer truncation in expressions involving floats.
4653 * data.c: Include <intprops.h>.
4654 (arith_driver): When there's an integer overflow in an expression
4655 involving floating point, convert the integers to floating point
4656 so that the resulting value does not suffer from catastrophic
4657 integer truncation. For example, on a 64-bit host (* 4
4658 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4659 Do not rely on undefined behavior after integer overflow.
4660
de883a70
PE
4661 merge count_size_as_multibyte, parse_str_to_multibyte
4662 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 4663 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
4664 Check for integer overflow.
4665 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4666 since it's now a duplicate of the other. This is more of
4667 a character than a buffer op, so better that it's in character.c.
4668 * fns.c, print.c: Adjust to above changes.
4669
2ff916cb
PE
46702011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4671
4672 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4673
f1b54466
PE
46742011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4675
fb1ac845
PE
4676 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4677 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4678 (x_clipboard_manager_save): Now static.
4679 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4680
f1b54466
PE
4681 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4682 (crypto_hash_function): Now static.
4683 Fix pointer signedness problems. Avoid unnecessary initializations.
4684
a9f737ee
CY
46852011-05-27 Chong Yidong <cyd@stupidchicken.com>
4686
4687 * termhooks.h (Vselection_alist): Make it terminal-local.
4688
4689 * terminal.c (create_terminal): Initialize it.
4690
4691 * xselect.c: Support for clipboard managers.
4692 (Vselection_alist): Move to termhooks.h as terminal-local var.
4693 (LOCAL_SELECTION): New macro.
4694 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4695 (symbol_to_x_atom): Remove gratuitous arg.
4696 (x_handle_selection_request, lisp_data_to_selection_data)
4697 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
4698 (x_own_selection, x_get_local_selection, x_convert_selection):
4699 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
4700 (some_frame_on_display): Delete unused function.
4701 (Fx_own_selection_internal, Fx_get_selection_internal)
4702 (Fx_disown_selection_internal, Fx_selection_owner_p)
4703 (Fx_selection_exists_p): New optional frame arg.
4704 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4705 (x_handle_selection_clear): Don't treat other terminals with the
4706 same keyboard specially. Use the terminal-local Vselection_alist.
4707 (x_clear_frame_selections): Use Frun_hook_with_args.
4708
4709 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4710
4711 * xterm.h: Add support for those atoms.
4712
e067f0c1
CY
47132011-05-26 Chong Yidong <cyd@stupidchicken.com>
4714
4715 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4716 (converted_selections, conversion_fail_tag): New global variables.
4717 (x_selection_request_lisp_error): Free the above.
4718 (x_get_local_selection): Remove unnecessary code.
4719 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
4720 of converted selections stored in converted_selections.
4721 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
4722 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4723 (x_convert_selection): New function.
4724 (x_handle_selection_event): Simplify.
4725 (x_get_foreign_selection): Don't ignore incoming requests while
4726 waiting for an answer; this will fail when we implement
4727 SAVE_TARGETS, and seems unnecessary anyway.
4728 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4729 (Vx_sent_selection_functions): Doc fix.
4730
0f4aebc0
LL
47312011-05-26 Leo Liu <sdl.web@gmail.com>
4732
4733 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4734
e61124cd
YM
47352011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4736
4737 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4738
4739 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4740 for fringe update if it has periodic bitmap.
ac389d0c 4741 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
4742 and fringe_bitmap_periodic_p.
4743
4744 * fringe.c (get_fringe_bitmap_data): New function.
4745 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4746 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4747 row. Mark glyph row for fringe update if periodicity changed.
4748
4749 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4750 for fringe update unless it has periodic bitmap.
4751
f16d9837
KH
47522011-05-25 Kenichi Handa <handa@m17n.org>
4753
4754 * xdisp.c (get_next_display_element): Set correct it->face_id for
4755 a static composition.
4756
e1b90ef6
LL
47572011-05-24 Leo Liu <sdl.web@gmail.com>
4758
4759 * deps.mk (fns.o):
4760 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4761
4762 * fns.c (crypto_hash_function, Fsha1): New function.
4763 (Fmd5): Use crypto_hash_function.
4764 (syms_of_fns): Add Ssha1.
4765
7400048f
PE
47662011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4767
4768 * gnutls.c: Remove unused macros.
4769 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4770 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4771 Remove macros that are defined and never used.
4772 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4773
abb71cf4
CY
47742011-05-22 Chong Yidong <cyd@stupidchicken.com>
4775
4776 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4777 (Fx_get_selection_internal): Minor cleanup.
4778 (Fx_own_selection_internal): Rename arguments for consistency with
4779 select.el.
4780
6307db39
PE
47812011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4782
4783 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4784
f3d4e0a4
CY
47852011-05-22 Chong Yidong <cyd@stupidchicken.com>
4786
4787 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4788
4d8ade89
YM
47892011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4790
4791 * dispnew.c (scrolling_window): Don't exclude the case that the
4792 last enabled row in the desired matrix touches the bottom boundary.
4793
32078c8d
GM
47942011-05-21 Glenn Morris <rgm@gnu.org>
4795
4796 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
4797 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4798 and add some more files.
32078c8d 4799
7285dc67
EZ
48002011-05-20 Eli Zaretskii <eliz@gnu.org>
4801
4802 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4803 report_file_error introduced by the change from 2011-05-07.
4804
89d1bd22
PE
48052011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4806
4807 * systime.h (Time): Define only if emacs is defined.
4808 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4809 where the include path doesn't have X11/X.h by default. See
4810 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4811
e23640bb 48122011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
4813
4814 * composite.c (find_automatic_composition): Fix previous change.
4815
b9704ad9
GM
48162011-05-20 Glenn Morris <rgm@gnu.org>
4817
4818 * lisp.mk: New file, split from Makefile.in.
4819 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4820 (shortlisp): Remove.
4821 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4822
4a720484
GM
48232011-05-19 Glenn Morris <rgm@gnu.org>
4824
4825 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4826 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4827 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4828 (lisp): Set the order to that of loadup.el.
4829 (shortlisp): Make it a copy of $lisp.
4830 (SOME_MACHINE_LISP): Remove.
4831 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4832 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4833
a28d4396
KH
48342011-05-18 Kenichi Handa <handa@m17n.org>
4835
4836 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4837 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4838 (find_automatic_composition): Mostly rewrite for efficiency.
4839
a2b1fa8e
JB
48402011-05-18 Juanma Barranquero <lekktu@gmail.com>
4841
4842 * makefile.w32-in: Update dependencies.
4843
8e1f5610
CS
48442011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4845
4846 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 4847 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 4848
7025ee00 48492011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 4850
cdfa6eab
PE
4851 Fix some integer overflow issues, such as string length overflow.
4852
06d6db33
PE
4853 * insdel.c (count_size_as_multibyte): Check for string overflow.
4854
2b4560a8
PE
4855 * character.c (lisp_string_width): Check for string overflow.
4856 Use EMACS_INT, not int, for string indexes and lengths; in
4857 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4858 the resulting string length overflows an EMACS_INT; instead,
4859 report a string overflow if no precision given. When checking for
4860 precision exhaustion, use a check that cannot possibly have
4861 integer overflow. (Bug#8675)
4862 * character.h (lisp_string_width): Adjust to new signature.
4863
cb93f9be
PE
4864 * alloc.c (string_overflow): New function.
4865 (Fmake_string): Use it. This doesn't change behavior, but saves
4866 a few bytes and will simplify future changes.
4867 * character.c (string_escape_byte8): Likewise.
4868 * lisp.h (string_overflow): New decl.
4869
1a1f3366
PE
4870 Fixups, following up to the user-interface timestamp change.
4871 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4872 for UI timestamps, instead of unsigned long.
9fbd6841
PE
4873 * msdos.c (mouse_get_pos): Likewise.
4874 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
4875 * w32gui.h (Time): Define by including "systime.h" rather than by
4876 declaring it ourselves. (Bug#8664)
4877
d4e3e4d3
PE
4878 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4879 * image.c (clear_image_cache): Likewise.
4880
f6a24d19
PE
4881 * term.c (term_mouse_position): Don't assume time_t wraparound.
4882
08dc5ae6
PE
4883 Be more systematic about user-interface timestamps.
4884 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
4885 and sometimes 'EMACS_UINT', to represent these timestamps.
4886 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
4887 This makes the code easier to follow, and makes it easier to catch
4888 integer overflow bugs such as Bug#8664.
4889 * frame.c (Fmouse_position, Fmouse_pixel_position):
4890 Use Time, not unsigned long, for user-interface timestamps.
4891 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4892 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4893 * keyboard.h (last_event_timestamp): Likewise.
4894 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4895 * menu.h (xmenu_show): Likewise.
4896 * term.c (term_mouse_position): Likewise.
4897 * termhooks.h (struct input_event.timestamp): Likewise.
4898 (struct terminal.mouse_position_hook): Likewise.
4899 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4900 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4901 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4902 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4903 what it was before.
4904 * menu.h, termhooks.h: Include "systime.h", for Time.
4905
8e55734a
PE
4906 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4907 Don't assume that the difference between two unsigned long values
4908 can fit into an integer. At this point, we know button_down_time
4909 <= event->timestamp, so the difference must be nonnegative, so
4910 there's no need to cast the result if double-click-time is
4911 nonnegative, as it should be; check that it's nonnegative, just in
4912 case. This bug is triggered when events are more than 2**31 ms
86db42d2 4913 apart (about 25 days). (Bug#8664)
8e55734a 4914
841f1b75 4915 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 4916 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 4917
3e26f69c
PE
4918 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4919 that always fit in int. Use a sentinel instead of a counter, to
4920 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
4921 * frame.h (struct frame): Use int for menu_bar_items_used
4922 instead of EMACS_INT, since it always fits in int.
3e26f69c 4923
5cc152c0
PE
4924 * menu.c (grow_menu_items): Check for int overflow.
4925
d89eb65e
PE
4926 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4927
5235bd3e
PE
4928 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4929 Before, the code was not consistent. These values cannot exceed
4930 2**31 - 1 so there's no need to make them unsigned.
4931 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4932 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4933 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4934 as modifiers.
4935 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4936
bc827e23
PE
4937 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4938 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4939 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4940 presumably because the widths might not match.
4941
78eb494e
PE
4942 * window.c (size_window): Avoid needless test at loop start.
4943
04f2d78b
CB
49442011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4945
4946 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4947
d2fc7e3d 49482011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
4949
4950 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4951
d2fc7e3d 49522011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
4953
4954 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4955 `width' to `bar_area_x' and `bar_area_width', respectively.
4956 (x_scroll_run): Take account of fringe background extension.
4957
04f2d78b
CB
4958 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4959 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
4960 `bar_area_width', respectively.
4961 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4962 background extension.
4963
79b70037
GM
49642011-05-10 Jim Meyering <meyering@redhat.com>
4965
4966 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4967
2f142cc5
JB
49682011-05-10 Juanma Barranquero <lekktu@gmail.com>
4969
4970 * image.c (Finit_image_library): Return t for built-in image types,
4971 like pbm and xbm. (Bug#8640)
4972
57679c86
AS
49732011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4974
4975 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4976
888c9e86
EZ
49772011-05-07 Eli Zaretskii <eliz@gnu.org>
4978
b0512a1d
EZ
4979 * w32console.c (Fset_screen_color): Doc fix.
4980 (Fget_screen_color): New function.
4981 (syms_of_ntterm): Defsubr it.
4982
7285dc67
EZ
4983 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4984 unlink the temporary file if Fcall_process didn't create it in the
4985 first place.
4986 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4987 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
4988 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4989 cue to call_process_cleanup not to close that handle.
4990
4d3fcc8e
BK
49912011-05-07 Ben Key <bkey76@gmail.com>
4992
4993 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4994 one of two shell specific rules, either bootstrap-temacs-CMD or
4995 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4996 to the previous implementation of the bootstrap-temacs rule.
4997 The bootstrap-temacs-CMD rule is similar to the previous
4998 implementation of the bootstrap-temacs rule except that it
4999 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5000 variable.
5001
5002 These changes, along with some changes to nt/configure.bat,
5003 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5004 earlier fix to add support for --cflags and --ldflags options
5005 that include quotes so that it works whether make uses cmd or
5006 sh as the shell.
5007
b4289b64
MA
50082011-05-06 Michael Albinus <michael.albinus@gmx.de>
5009
5010 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5011 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5012 is a constant.
5013 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5014 a string. Handle both cases.
5015 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5016 (Fdbus_register_method): Use Qinvalid_function.
5017
af4c0e28
JB
50182011-05-06 Juanma Barranquero <lekktu@gmail.com>
5019
5020 * makefile.w32-in: Update dependencies.
5021 (LISP_H): Add inttypes.h and stdin.h.
5022 (PROCESS_H): Add unistd.h.
5023
c51453d9
EZ
50242011-05-06 Eli Zaretskii <eliz@gnu.org>
5025
5026 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5027 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5028
8ff0ac3c 50292011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 5030
4c4b566b
PE
5031 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5032
aab2b9b5
PE
5033 * term.c (vfatal): Remove stray call to va_end.
5034 It's not needed and the C Standard doesn't allow it here anyway.
5035
c378da0b
PE
5036 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5037 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5038
288b08c7
PE
5039 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5040 bytes.
5041
e3601888
PE
5042 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5043
db6c0e74
PE
5044 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5045
dd5963ea
PE
5046 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5047
88c9450f
PE
5048 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5049
2f9442b8
PE
5050 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5051
c032b5f8
PE
5052 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5053 * charset.c (Fdefine_charset_internal): Don't initialize
5054 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 5055 32-bit int (Bug#8600).
a108c10b
PE
5056
5057 * lread.c (read_integer): Be more consistent with string-to-number.
5058 Use string_to_number to do the actual conversion; this avoids
5059 rounding errors and fixes some other screwups. Without this fix,
5060 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5061 (digit_to_number): Move earlier, for benefit of read_integer.
5062 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 5063 not a digit in any supported base. (Bug#8602)
a108c10b 5064
ad5f9eea
PE
5065 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5066
aec1708a
PE
5067 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5068 to match comment at start of function. This also removes a
5069 GCC warning about overflow in a 32+64-bit port.
5070
47be4ab5
PE
5071 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5072
371cac43
PE
5073 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5074 Reported by Stefan Monnier in
5075 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
5076 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5077 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 5078
d01a7826
PE
5079 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5080 (EMACS_UINTPTR): Likewise, with uintptr_t.
5081
7fd47d5c
PE
5082 * lisp.h: Prefer 64-bit EMACS_INT if available.
5083 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5084 on 32-bit hosts that have 64-bit int, so that they can access
5085 large files.
122b0c86
PE
5086 However, temporarily disable this change unless the temporary
5087 symbol WIDE_EMACS_INT is defined.
7fd47d5c 5088
8727937b
PE
5089 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5090
8ac068ac
PE
5091 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5092 This removes an assumption that EMACS_INT and long are the same
5093 width as pointers. The assumption is true for Emacs porting targets
5094 now, but we want to make other targets possible.
5095 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5096 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5097 In the rest of the code, change types of integers that hold casted
5098 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5099 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5100 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5101 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5102 No need to cast type when ORing.
5103 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5104 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5105 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5106 assume EMACS_INT is the same width as char *.
5107 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5108 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5109 Remove no-longer-needed casts.
5110 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5111 (xg_tool_bar_help_callback, xg_make_tool_item):
5112 Use EMACS_INTPTR to hold an integer
5113 that will be cast to void *; this can avoid a GCC warning
5114 if EMACS_INT is not the same width as void *.
5115 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5116 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5117 (current_message_1, set_message_1):
5118 Use a local to convert to proper width without a cast.
5119 * xmenu.c (dialog_selection_callback): Likewise.
5120
ede49d71
PE
5121 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5122 Also, don't assume VALBITS / RAND_BITS is less than 5,
5123 and don't rely on undefined behavior when shifting a 1 left into
5124 the sign bit.
5125 * lisp.h (get_random): Change signature to match.
5126
2f30ecd0
PE
5127 * lread.c (hash_string): Use size_t, not int, for hash computation.
5128 Normally we prefer signed values; but hashing is special, because
5129 it's better to use unsigned division on hash table sizes so that
5130 the remainder is nonnegative. Also, size_t is the natural width
5131 for hashing into memory. The previous code used 'int', which doesn't
5132 retain enough info to hash well into very large tables.
5133 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5134
2a866e7b
PE
5135 * dbusbind.c: Don't possibly lose pointer info when converting.
5136 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5137 Use XPNTR rather than XHASH, so that the high-order bits of
5138 the pointer aren't lost when converting through void *.
5139
51639eac
PE
5140 * eval.c (Fautoload): Don't double-shift a pointer.
5141
92394119
PE
5142 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5143
dbdb9a7c
JB
51442011-05-06 Juanma Barranquero <lekktu@gmail.com>
5145
5146 * gnutls.c (DEF_GNUTLS_FN):
5147 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5148
db7a0b4f
AS
51492011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5150
5151 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5152 marker. (Bug#8610)
5153
f7ff1b0f 51542011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
5155
5156 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5157 New version that can reserve upto 2GB of heap space.
5158
f7ff1b0f 51592011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
5160
5161 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5162
639c109b
TZ
51632011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5164
5165 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5166 `gnutls_certificate_set_x509_key_file'.
5167
d2127135
JB
51682011-05-05 Juanma Barranquero <lekktu@gmail.com>
5169
5170 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5171 Update dependencies.
5172
e968f4f3
JB
51732011-05-04 Juanma Barranquero <lekktu@gmail.com>
5174
5175 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5176 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5177 Remove unused parameter `fildes'.
5178 * process.c (read_process_output, send_process): Don't pass it.
5179
84d358f0
JB
51802011-05-04 Juanma Barranquero <lekktu@gmail.com>
5181
5182 Fix previous change: the library cache is defined in w32.c.
5183 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5184 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5185
0898ca10
JB
51862011-05-04 Juanma Barranquero <lekktu@gmail.com>
5187
5188 Implement dynamic loading of GnuTLS on Windows.
5189
5190 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5191 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5192 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5193 Declare.
5194
5195 * gnutls.c (Qgnutls_dll): Define.
5196 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5197 (gnutls_*): Declare function pointers.
5198 (init_gnutls_functions): New function to initialize function pointers.
5199 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5200 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5201 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5202 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5203 (emacs_gnutls_write, emacs_gnutls_read)
5204 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5205 (Fgnutls_available_p): New function.
5206 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5207 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5208 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5209
5210 * image.c: Include w32.h.
5211 (Vimage_type_cache): Delete.
5212 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5213 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5214 (w32_delayed_load): Move to w32.c.
5215
5216 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5217
5218 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5219 (w32_delayed_load): Move from image.c. When loading a library, record
5220 its filename in the :loaded-from property of the library id.
5221 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5222 Initialize and staticpro them.
5223 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5224
5225 * process.c: Include lisp.h before w32.h, not after.
5226 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5227 instead of gnutls_record_check_pending.
5228
5229 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5230
ff4de4aa
TZ
52312011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5232
5233 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5234 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5235 as passed in.
5236
abe95abb
JD
52372011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5238
5239 * xterm.c (x_set_frame_alpha): Do not set property on anything
5240 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5241
e16e55d4
JB
52422011-05-02 Juanma Barranquero <lekktu@gmail.com>
5243
5244 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5245
bafcf6a5
JB
52462011-05-02 Juanma Barranquero <lekktu@gmail.com>
5247
5248 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5249 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5250 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5251 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5252 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5253 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5254 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5255 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5256 (Qgnutls_bootprop_callbacks_verify): Make static.
5257
e7a6747f
AS
52582011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5259
19ed11ba
AS
5260 * callproc.c: Indentation fixup.
5261
e7a6747f 5262 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
5263 (wait_for_termination, interruptible_wait_for_termination):
5264 Move after wait_for_termination_1.
e7a6747f 5265
1ef14cb4
LMI
52662011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5267
5268 * sysdep.c (interruptible_wait_for_termination): New function
5269 which is like wait_for_termination, but allows keyboard
5270 interruptions.
5271
5272 * callproc.c (Fcall_process): Add (:file "file") as an option for
5273 the STDOUT buffer.
5274 (Fcall_process_region): Ditto.
5275
330d880c
EZ
52762011-04-30 Eli Zaretskii <eliz@gnu.org>
5277
8db90b73
EZ
5278 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5279 rather than `XVECTOR (FOO)->size'.
5280
330d880c
EZ
5281 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5282 inttypes.h, as a gnulib replacement is used if it not available in
5283 system headers.
5284
15cbd324
EZ
52852011-04-21 Eli Zaretskii <eliz@gnu.org>
5286
5287 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5288 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5289 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5290
5291 * coding.c (coding_alloc_by_realloc): Error out if destination
5292 will grow beyond MOST_POSITIVE_FIXNUM.
5293 (decode_coding_emacs_mule): Abort if there isn't enough place in
5294 charbuf for the composition carryover bytes. Reserve an extra
5295 space for up to 2 characters produced in a loop.
5296 (decode_coding_iso_2022): Abort if there isn't enough place in
5297 charbuf for the composition carryover bytes.
5298
52992011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 5300
ae940cca
EZ
5301 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5302 aborting when %lld or %lll format is passed.
5303 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5304 %llo or %llx format is passed. (Bug#8545)
5305
03ab8921
EZ
5306 * window.c (window_scroll_line_based): Use a marker instead of
5307 simple variables to record original value of point. (Bug#7952)
5308
afda1437
EZ
5309 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5310 produced by %s or %c overflows available buffer space. (Bug#8545)
5311
f76dee0c
PE
53122011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5313
5314 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 5315 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 5316
fdc5744d
JB
53172011-04-28 Juanma Barranquero <lekktu@gmail.com>
5318
5319 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5320
638f053a
JB
53212011-04-28 Juanma Barranquero <lekktu@gmail.com>
5322
5323 * keyboard.c (Qdelayed_warnings_hook): Define.
5324 (command_loop_1): Run `delayed-warnings-hook'
5325 if Vdelayed_warnings_list is non-nil.
5326 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5327 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5328
d178f871
EZ
53292011-04-28 Eli Zaretskii <eliz@gnu.org>
5330
5331 * doprnt.c (doprnt): Don't return value smaller than the buffer
5332 size if the message was truncated. (Bug#8545).
5333
b124fd93
JB
53342011-04-28 Juanma Barranquero <lekktu@gmail.com>
5335
5336 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5337 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5338
e810457d
PE
53392011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5340
5341 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5342
ea51cceb
JB
53432011-04-27 Juanma Barranquero <lekktu@gmail.com>
5344
5345 * makefile.w32-in: Update dependencies.
5346
94dcfacf
EZ
53472011-04-27 Eli Zaretskii <eliz@gnu.org>
5348
5349 Improve `doprnt' and its usage. (Bug#8545)
5350 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5351 `format_end'. Remove support for %l as a conversion specifier.
5352 Don't use xrealloc. Improve diagnostics when the %l size modifier
5353 is used. Update the commentary.
5354
5355 * eval.c (verror): Simplify calculation of size_t.
5356
5357 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5358 messages.
5359
f61f41d7
PE
53602011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5361
5362 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5363 change.
5364
96fb4434
PE
53652011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5366
5367 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5368 This makes this file independent of the recent pseudovector change.
5369
671875da 53702011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 5371
69e9b5a3
PE
5372 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5373
b5f869a7 5374 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 5375 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 5376 Remove unused local.
c8926152 5377 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 5378
841a1577 5379 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
5380 GCC 4.6.0 optimizes based on type-based alias analysis.
5381 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
5382 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5383 != &v->size, and therefore "v->size = 1; b->size = 2; return
5384 v->size;" must therefore return 1. This assumption is incorrect
5385 for Emacs, since it type-puns struct Lisp_Vector * with many other
5386 types. To fix this problem, this patch adds a new type struct
f904488f 5387 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
5388 and pseudovectors, and helps optimizing compilers not get fooled
5389 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5390 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
5391 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5392 the size member.
eab3844f
PE
5393 (XSETPVECTYPE): Rewrite in terms of new macro.
5394 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5395 This is a bit clearer, and further avoids the possibility of
5396 undesirable aliasing.
5397 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 5398 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
5399 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5400 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
5401 (ASIZE): Now uses header.size rather than size.
5402 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
5403 to avoid the hassle of writing XVECTOR (foo)->header.size.
5404 (struct vectorlike_header): New type.
eab3844f
PE
5405 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5406 object, to help avoid aliasing.
5407 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5408 (SUBRP): Likewise, since Lisp_Subr is a special case.
5409 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5410 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5411 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 5412 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
5413 changed to be "header.size" and "header.next".
5414 * buffer.h (struct buffer): Likewise.
5415 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5416 * frame.h (struct frame): Likewise.
5417 * process.h (struct Lisp_Process): Likewise.
5418 * termhooks.h (struct terminal): Likewise.
5419 * window.c (struct save_window_data, struct saved_window): Likewise.
5420 * window.h (struct window): Likewise.
5421 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5422 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5423 * buffer.c (init_buffer_once): Likewise.
5424 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5425 special case.
5426 * process.c (Fformat_network_address): Use local var for size,
5427 for brevity.
5428
0df1eac5
PE
5429 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5430
847ab9d1 5431 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
5432 * data.c (atof): Remove decl; no longer used or needed.
5433 (digit_to_number): Move to lread.c.
5434 (Fstring_to_number): Use new string_to_number function, to be
5435 consistent with how the Lisp reader treats infinities and NaNs.
5436 Do not assume that floating-point numbers represent EMACS_INT
5437 without losing information; this is not true on most 64-bit hosts.
5438 Avoid double-rounding errors, by insisting on integers when
5439 parsing non-base-10 numbers, as the documentation specifies.
5440 * lisp.h (string_to_number): New decl, replacing ...
5441 (isfloat_string): Remove.
bc0a5c13 5442 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 5443 (read1): Do not accept +. and -. as integers; this
452f4150
PE
5444 appears to have been a coding error. Similarly, do not accept
5445 strings like +-1e0 as floating point numbers. Do not report
5446 overflow for integer overflows unless the base is not 10 which
5447 means we have no simple and reliable way to continue.
5448 Break out the floating-point parsing into a new
5449 function string_to_number, so that Fstring_to_number parses
5450 floating point numbers consistently with the Lisp reader.
04f2d78b 5451 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
5452 (E_CHAR, EXP_INT): Remove, replacing with ...
5453 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5454 (string_to_number): New function, replacing isfloat_string.
5455 This function checks for valid syntax and produces the resulting
5456 Lisp float number too. Rework it so that string-to-number
bc0a5c13 5457 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
5458 so that overflow for non-base-10 numbers is reported only when
5459 there's no portable and simple way to convert to floating point.
452f4150 5460
67769ffc
PE
5461 * textprop.c (set_text_properties_1): Rewrite for clarity,
5462 and to avoid GCC warning about integer overflow.
5463
c20db43f
PE
5464 * intervals.h (struct interval): Use EMACS_INT for members
5465 where EMACS_UINT might cause problems. See
5466 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5467 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5468 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5469 All uses changed.
37aa2f85
PE
5470 (offset_intervals): Tell GCC not to worry about length overflow
5471 when negating a negative length.
c20db43f 5472
2538aa2f
PE
5473 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5474 (overrun_check_free): Likewise.
5475
f2d3008d
PE
5476 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5477 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5478 word size.
5479
ec8df744
PE
5480 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5481 (gnutls_make_error): Rename local to avoid shadowing.
5482 (gnutls_emacs_global_deinit): ifdef out; not used.
5483 (Fgnutls_boot): Use const for pointer to readonly storage.
5484 Comment out unused local. Fix pointer signedness problems.
5485
640ee02d
PE
5486 * lread.c (openp): Don't stuff size_t into an 'int'.
5487 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5488 about possible signed overflow.
5489
6048fb2a
PE
5490 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5491 (GDK_KEY_g): Don't define if already defined.
5492 (xg_prepare_tooltip): Avoid pointer signedness problem.
5493 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5494
fa3c87e1
PE
5495 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5496 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5497
2172544b
PE
5498 * xfns.c (Fx_window_property): Simplify a bit,
5499 to make a bit faster and to avoid GCC 4.6.0 warning.
5500 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5501
9b821a21
PE
5502 * fns.c (internal_equal): Don't assume size_t fits in int.
5503
3c616cfa
PE
5504 * alloc.c (compact_small_strings): Tighten assertion a little.
5505
c2982e87
PE
5506 Replace pEd with more-general pI, and fix some printf arg casts.
5507 * lisp.h (pI): New macro, generalizing old pEd macro to other
5508 conversion specifiers. For example, use "...%"pI"d..." rather
5509 than "...%"pEd"...".
5510 (pEd): Remove. All uses replaced with similar uses of pI.
5511 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5512 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5513 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5514 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5515 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5516 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5517 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5518 64-bit hosts.
5519 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5520 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5521 * print.c (safe_debug_print, print_object): Likewise.
5522 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5523 to int.
6f04d126
PE
5524 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5525 avoiding the 0 flag, which is not portable.
c2982e87
PE
5526 * process.c (Fmake_network_process): Use pI to avoid cast.
5527 * region-cache.c (pp_cache): Likewise.
5528 * xdisp.c (decode_mode_spec): Likewise.
5529 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5530 behavior on 64-bit hosts with printf arg.
6f04d126 5531 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
5532 (x_stop_queuing_selection_requests): Likewise.
5533 (x_get_window_property): Don't truncate byte count to an 'int'
5534 when tracing.
0b432f21 5535
5e073ec7
PE
5536 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5537 here, since it parses constructs like leading '-' and spaces,
5538 which are not wanted; and it overflows with large numbers.
5539 Instead, simply match F[0-9]+, which is what is wanted anyway.
5540
36372bf9
PE
5541 * alloc.c: Remove unportable assumptions about struct layout.
5542 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5543 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5544 (allocate_vectorlike, make_pure_vector): Use the new macros,
5545 plus offsetof, to remove unportable assumptions about struct layout.
5546 These assumptions hold on all porting targets that I know of, but
5547 they are not guaranteed, they're easy to remove, and removing them
5548 makes further changes easier.
5549
0b432f21
PE
5550 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5551 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
5552 (string_overrun_cookie): Now const. Use initializers that
5553 don't formally overflow signed char, to avoid warnings.
000098c1
PE
5554 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5555 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
5556 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5557 multiple of sizeof (EMACS_INT); it need not be, if
5558 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 5559 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 5560
895009e1
JB
55612011-04-26 Juanma Barranquero <lekktu@gmail.com>
5562
5563 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5564
6a7a1b0b
TZ
55652011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5566
5567 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 5568 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
5569 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5570
841a1577 55712011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
5572
5573 * lisp.h (Qdebug): List symbol.
895009e1 5574 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
5575 * keyboard.c (debug-on-event): New variable.
5576 (handle_user_signal): Break into debugger when debug-on-event
5577 matches the current signal symbol.
5578
f2d3ba6f
DN
55792011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5580
5581 * alloc.c (check_sblock, check_string_bytes)
5582 (check_string_free_list): Convert to standard C.
5583
42ce4c63
TZ
55842011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5585
5586 * w32.c (emacs_gnutls_push): Fix typo.
5587
825cd63c
EZ
55882011-04-25 Eli Zaretskii <eliz@gnu.org>
5589
fb11d64d
EZ
5590 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5591 "cast to pointer from integer of different size".
5592
825cd63c
EZ
5593 Improve doprnt and its use in verror. (Bug#8545)
5594 * doprnt.c (doprnt): Document the set of format control sequences
5595 supported by the function. Use SAFE_ALLOCA instead of always
5596 using `alloca'.
5597
5598 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5599 is one byte too soon. Don't use xrealloc; instead xfree and
5600 xmalloc anew.
5601
e061a11b
TZ
56022011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5603
5604 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5605 callbacks stage.
5606
5607 * gnutls.c: Renamed global_initialized to
5608 gnutls_global_initialized. Added internals for the
5609 :verify-hostname-error, :verify-error, and :verify-flags
5610 parameters of `gnutls-boot' and documented those parameters in the
5611 docstring. Start callback support.
9173deec
JB
5612 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5613 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5614 on error. Return error code.
e061a11b
TZ
5615 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5616 (emacs_gnutls_read): Likewise.
5617 (Fgnutls_boot): Return handshake error code.
5618 (emacs_gnutls_handle_error): New function.
5619 (wsaerror_to_errno): Likewise.
5620
5621 * w32.h (emacs_gnutls_pull): Add prototype.
5622 (emacs_gnutls_push): Likewise.
5623
5624 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5625 (emacs_gnutls_push): Likewise.
5626
56272011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5628
5629 * process.c (wait_reading_process_output): Check if GnuTLS
5630 buffered some data internally if no FDs are set for TLS
5631 connections.
5632
5633 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5634 (LIBS): Link to USER_LIBS.
5635 ($(BLD)/gnutls.$(0)): New target.
5636
fa6996bc
EZ
56372011-04-24 Eli Zaretskii <eliz@gnu.org>
5638
eb35682e
EZ
5639 * xdisp.c (handle_single_display_spec): Rename the
5640 display_replaced_before_p argument into display_replaced_p, to
5641 make it consistent with the commentary. Fix typos in the
5642 commentary.
5643
e2ad650c
EZ
5644 * textprop.c (syms_of_textprop): Remove dead code.
5645 (copy_text_properties): Delete obsolete commentary about an
5646 interface that was deleted long ago. Fix typos in the description
5647 of arguments.
5648
1b2de274
EZ
5649 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5650 to changes in oldXMenu/XMenu.h from 2011-04-16.
5651 <menu_help_message, prev_menu_help_message>: Constify.
5652 (IT_menu_make_room): menu->help_text is now `const char **';
5653 adjust.
5654
5655 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5656 to changes in oldXMenu/XMenu.h from 2011-04-16.
5657 (struct XMenu): Declare `help_text' `const char **'.
5658
5659 * xfaces.c <Qunspecified>: Make extern again.
5660
5661 * syntax.c: Include sys/types.h before including regex.h, as
5662 required by Posix.
5663
762b15be
EZ
5664 * doc.c (get_doc_string): Improve the format passed to `error'.
5665
5666 * doprnt.c (doprnt): Improve commentary.
5667
5668 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5669
5670 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5671 them with etags.
5672
f1052e5d
EZ
5673 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5674 changes in globals.h immediately force recompilation.
762b15be
EZ
5675 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5676 $(CURDIR)/s/ms-w32.h.
5677 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 5678
fa6996bc
EZ
5679 * character.c (Fchar_direction): Function deleted.
5680 (syms_of_character): Don't defsubr it.
5681 <char-direction-table>: Deleted.
5682
e6c3da20
EZ
56832011-04-23 Eli Zaretskii <eliz@gnu.org>
5684
5685 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5686 * doprnt.c: Include limits.h.
5687 (SIZE_MAX): New macro.
04f2d78b
CB
5688 (doprnt): Return a size_t value. 2nd arg is now size_t.
5689 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
5690 Improve overflow protection. Support `l' modifier for integer
5691 conversions. Support %l conversion. Don't assume an EMACS_INT
5692 argument for integer conversions and for %c.
5693
5694 * lisp.h (doprnt): Restore prototype.
5695
5696 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5697 $(SRC)/character.h.
5698
5699 * Makefile.in (base_obj): Add back doprnt.o.
5700
5701 * deps.mk (doprnt.o): Add back prerequisites.
5702 (callint.o): Depend on character.h.
5703
5704 * eval.c (internal_lisp_condition_case): Include the handler
5705 representation in the error message.
5706 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5707 when breaking from the loop.
5708
5709 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5710
5711 * callint.c (Fcall_interactively): When displaying error message
5712 about invalid control letter, pass the character's codepoint, not
5713 a pointer to its multibyte form. Improve display of the character
5714 in octal and display also its hex code.
5715
5716 * character.c (char_string): Use %x to display the (unsigned)
5717 codepoint of an invalid character, to avoid displaying a bogus
5718 negative value.
5719
5720 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5721 `error', not SYMBOL_NAME itself.
5722
5723 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5724 character arguments to `error'.
5725
5726 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5727 to `error' in error message about FINAL_CHAR argument. Make sure
5728 FINAL_CHAR is a character, and use %c when it is passed as
5729 argument to `error'.
5730
4ffd0d6b 57312011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
5732
5733 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5734
5735 * w32.c: Include <time.h>.
5736 (sys_localtime): New function.
5737
4ffd0d6b 57382011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
5739
5740 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5741
4ffd0d6b 5742 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 5743
4ffd0d6b 57442011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 5745
4ffd0d6b
GM
5746 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5747 zombies (Bug#8467).
aac0c6e3 5748
04c56954
EZ
57492011-04-19 Eli Zaretskii <eliz@gnu.org>
5750
5751 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5752 gl_state.e_property when gl_state.object is Qt.
5753
5754 * insdel.c (make_gap_larger): Remove limitation of buffer size
5755 to <= INT_MAX.
5756
16a43933
CY
57572011-04-18 Chong Yidong <cyd@stupidchicken.com>
5758
5759 * xdisp.c (lookup_glyphless_char_display)
5760 (produce_glyphless_glyph): Handle cons cell entry in
5761 glyphless-char-display.
5762 (Vglyphless_char_display): Document it.
5763
5764 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5765 glyphless-char-display.
5766
4581706e
CY
57672011-04-17 Chong Yidong <cyd@stupidchicken.com>
5768
5769 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5770
5771 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5772
5773 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5774 definition for no-X builds.
5775
4887c6e2 57762011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 5777
fd35b6f9
PE
5778 Static checks with GCC 4.6.0 and non-default toolkits.
5779
5c1ccb01
PE
5780 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5781
006c5daa
PE
5782 * process.c (keyboard_bit_set): Define only if SIGIO.
5783 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5784 (send_process): Repair possible setjmp clobbering.
5785
efc736d3
PE
5786 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5787
4e2fe2e6
PE
5788 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5789
f97334a2
PE
5790 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5791
4e75f29d
PE
5792 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5793 Define only if needed.
5794
90efadd1
PE
5795 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5796 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 5797 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 5798
3c647824
PE
5799 * dispextern.h (struct redisplay_interface): Rename param
5800 to avoid shadowing.
e264f262 5801 * termhooks.h (struct terminal): Likewise.
761383f4 5802 * xterm.c (xembed_send_message): Likewise.
3c647824 5803
b58c5c4a
PE
5804 * insdel.c (make_gap_smaller): Define only if
5805 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5806
cad59032
PE
5807 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5808 it.
5809
c339dc2e
PE
5810 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5811 so that we aren't warned about unused symbols.
5812
91a3e27b
PE
5813 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5814
399c71d3 5815 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 5816
8ffc96f5
PE
5817 * xfns.c (x_real_positions): Mark locals as initialized.
5818
eef9bc79
PE
5819 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5820
098db9dd
PE
5821 * xterm.c: Fix problems found by static analysis with other toolkits.
5822 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
5823 (x_dispatch_event): Declare static if USE_GTK, and
5824 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 5825 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 5826 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
5827 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5828 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 5829
eb18f6cc
PE
5830 * xmenu.c (menu_help_callback): Pointer type fixes.
5831 Use const pointers when pointing at readonly data. Avoid pointer
5832 signedness clashes.
5833 (FALSE): Remove unused macro.
5834 (update_frame_menubar): Remove unused decl.
5835
1fe72bf8
PE
5836 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5837
60d9e1db
PE
5838 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5839 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5840 (single_menu_item): Rename local to avoid shadowing.
5841
39261c26
PE
5842 * keyboard.c (make_lispy_event): Remove unused local var.
5843
018c5e19
PE
5844 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5845 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5846
63d2b86e
PE
5847 * bitmaps: Change bitmaps from unsigned char back to the X11
5848 compatible char. Avoid the old compiler warnings about
5849 out-of-range initializers by using, for example, '\xab' rather
5850 than 0xab.
5851
aefd87e1
PE
5852 * xgselect.c (xgselect_initialize): Check vs interface
5853 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5854
bf501fb9
PE
5855 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5856
e9829fdf
PE
5857 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5858 to read-only memory.
5859
1086c095
PE
5860 * fns.c (vector): Remove; this old hack is no longer needed.
5861
2baccd04 5862 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 5863 Remove unused var.
dde42981 5864 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 5865
72391843 5866 * xrdb.c (x_load_resources): Omit unused local.
3565b346 5867
436c16df 5868 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 5869 (x_window): Rename locals to avoid shadowing.
dc5ddd85 5870 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 5871
92bb796d 5872 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 5873 (x_term_init): Remove local to avoid shadowing.
92bb796d 5874
764430a3 5875 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
5876
5877 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5878 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5879
d1dfb56c
EZ
58802011-04-16 Eli Zaretskii <eliz@gnu.org>
5881
c4354cb4
EZ
5882 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5883
d1dfb56c
EZ
5884 Fix regex.c, syntax.c and friends for buffers > 2GB.
5885 * syntax.h (struct gl_state_s): Declare character position members
5886 EMACS_INT.
5887
5888 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5889
04f2d78b
CB
5890 * textprop.c (verify_interval_modification, interval_of):
5891 Declare arguments EMACS_INT.
d1dfb56c
EZ
5892
5893 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5894 EMACS_INT.
5895
5896 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5897
5898 * indent.c (Fvertical_motion): Local variable it_start is now
5899 EMACS_INT.
5900
5901 * regex.c (re_match, re_match_2, re_match_2_internal)
5902 (bcmp_translate, regcomp, regexec, print_double_string)
5903 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5904 (re_compile_pattern, re_exec): Declare arguments and local
5905 variables `size_t' and `ssize_t' and return values `regoff_t', as
5906 appropriate.
5907 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5908 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5909 <compile_stack_type>: `size' and `avail' are now `size_t'.
5910
5911 * regex.h <regoff_t>: Use ssize_t, not int.
5912 (re_search, re_search_2, re_match, re_match_2): Arguments that
5913 specify buffer/string position and length are now ssize_t and
5914 size_t. Return type is regoff_t.
5915
613052cd
BK
59162011-04-16 Ben Key <bkey76@gmail.com>
5917
5918 * nsfont.m: Fixed bugs in ns_get_family and
5919 ns_descriptor_to_entity that were caused by using free to
5920 deallocate memory blocks that were allocated by xmalloc (via
5921 xstrdup). This caused Emacs to crash when compiled with
5922 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5923 --enable-checking=xmallocoverrun). xfree is now used to
5924 deallocate these memory blocks.
5925
4170f62f 59262011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 5927
71b41406
PE
5928 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5929
9587a89d
PE
5930 emacs_write: Accept and return EMACS_INT for sizes.
5931 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5932 et seq.
5933 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5934 Accept and return EMACS_INT.
5935 (emacs_gnutls_write): Return the number of bytes written on
5936 partial writes.
5937 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
5938 (emacs_read, emacs_write): Remove check for negative size, as the
5939 Emacs source code has been audited now.
9587a89d
PE
5940 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5941 (emacs_read, emacs_write): Use it.
273a5f82
PE
5942 * process.c (send_process): Adjust to the new signatures of
5943 emacs_write and emacs_gnutls_write. Do not attempt to store
5944 a byte offset into an 'int'; it might overflow.
9587a89d 5945 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 5946
3e047f51
PE
5947 * sound.c: Don't assume sizes fit in 'int'.
5948 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 5949 Return EMACS_INT, not int.
3e047f51 5950 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
5951 Accept EMACS_INT, not int.
5952 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
5953 record read return values.
5954
cc39a9db
BK
59552011-04-15 Ben Key <bkey76@gmail.com>
5956
c9d0ec6d
JB
5957 * keyboard.c (Qundefined): Don't declare static since it is used
5958 in nsfns.m.
5959 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5960 static since they are used in nsfont.m.
cc39a9db 5961
6c60eb9f
SM
59622011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5963
5964 * process.c (Qprocessp): Don't declare static.
5965 * lisp.h (Qprocessp): Declare again.
5966
7990b61a
JB
59672011-04-15 Juanma Barranquero <lekktu@gmail.com>
5968
5969 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5970
5d4cb038
PE
59712011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5972
8bd7b830 5973 Improve C-level modularity by making more things 'static'.
cd64ea1d 5974
e3b27b31
PE
5975 Don't publish debugger-only interfaces to other modules.
5976 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5977 (verify_bytepos, count_markers): Move decls to the only modules
5978 that need them.
5979 * region-cache.h (pp_cache): Likewise.
5980 * window.h (check_all_windows): Likewise.
5981 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5982
5d4cb038
PE
5983 * sysdep.c (croak): Now static, if
5984 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5985 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
5986
5987 * alloc.c (refill_memory_reserve): Now static if
5988 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5989 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 5990
e87b6180
PE
5991 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5992 Define only if USE_LUCID.
5993
ac64929e
PE
5994 * xrdb.c (x_customization_string, x_rm_string): Now static.
5995
6f37259d
PE
5996 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5997 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5998
1683e3ab
PE
5999 * xdisp.c (draw_row_with_mouse_face): Now static.
6000 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6001
de9c2632
PE
6002 * window.h (check_all_windows): Mark externally visible.
6003
2b96acb7
PE
6004 * window.c (window_deletion_count): Now static.
6005
6006 * undo.c: Make symbols static if they're not exported.
6007 (last_undo_buffer, last_boundary_position, pending_boundary):
6008 Now static.
6009
50436f33
PE
6010 * textprop.c (interval_insert_behind_hooks): Now static.
6011 (interval_insert_in_front_hooks): Likewise.
6012
64520e5c
PE
6013 * term.c: Make symbols static if they're not exported.
6014 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6015 (max_frame_lines, tty_set_terminal_modes):
6016 (tty_reset_terminal_modes, tty_turn_off_highlight):
6017 (get_tty_terminal): Now static.
6018 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6019 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 6020 HAVE_WINDOW_SYSTEM.
64520e5c
PE
6021 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6022 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6023
1fa53021
PE
6024 * sysdep.c: Make symbols static if they're not exported.
6025 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6026 Now static.
6027 (sigprocmask_set, full_mask): Remove; unused.
6028 (wait_debugging): Mark as visible.
6029 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6030 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6031
d4b43b22
PE
6032 * syntax.c (syntax_temp): Define only if !__GNUC__.
6033
b7c513d0
PE
6034 * sound.c (current_sound_device, current_sound): Now static.
6035
989b29ad
PE
6036 * search.c (searchbufs, searchbuf_head): Now static.
6037
13a55a78
PE
6038 * scroll.c (scroll_cost): Remove; unused.
6039 * dispextern.h (scroll_cost): Remove decl.
6040
de68a1fc
PE
6041 * region-cache.h (pp_cache): Mark as externally visible.
6042
40ccffa6
PE
6043 * process.c: Make symbols static if they're not exported.
6044 (process_tick, update_tick, create_process, chan_process):
6045 (Vprocess_alist, proc_buffered_char, datagram_access):
6046 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6047 (deactivate_process): Mark defn as static, as well as decl.
6048 * lisp.h (create_process): Remove decl.
6049 * process.h (chan_process, Vprocess_alist): Remove decls.
6050
ad64fc97
PE
6051 * print.c: Make symbols static if they're not exported.
6052 (print_depth, new_backquote_output, being_printed, print_buffer):
6053 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6054 (print_interval, print_number_index, initial_stderr_stream):
6055 Now static.
6056 * lisp.h (Fprinc): Remove decl.
6057 (debug_output_compilation_hack): Mark as externally visible.
6058
adddb265
PE
6059 * sysdep.c (croak): Move decl from here to syssignal.h.
6060 * syssignal.h (croak): Put it here, so the API can be checked when
6061 'croak' is called from dissociate_if_controlling_tty.
6062
1717ede2
PE
6063 * minibuf.c: Make symbols static if they're not exported.
6064 (minibuf_save_list, choose_minibuf_frame): Now static.
6065 * lisp.h (choose_minibuf_frame): Remove decl.
6066
fa5fb2bc
PE
6067 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6068
1e3890d1
PE
6069 * lread.c: Make symbols static if they're not exported.
6070 (read_objects, initial_obarray, oblookup_last_bucket_number):
6071 Now static.
6072 (make_symbol): Remove; unused.
6073 * lisp.h (initial_obarray, make_symbol): Remove decls.
6074
8a1414fa
PE
6075 * keyboard.c: Make symbols static if they're not exported.
6076 (single_kboard, recent_keys_index, total_keys, recent_keys):
6077 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6078 (this_single_command_key_start, echoing, last_auto_save):
6079 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6080 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6081 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6082 (Vlispy_mouse_stem, double_click_count):
6083 Now static.
6084 (force_auto_save_soon): Define only if SIGDANGER.
6085 (ignore_mouse_drag_p): Now static if
6086 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6087 (print_help): Remove; unused.
6088 (stop_character, last_timer_event): Mark as externally visible.
6089 * keyboard.h (ignore_mouse_drag_p): Declare only if
6090 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6091 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6092 * lisp.h (echoing): Remove decl.
6093 (force_auto_save_soon): Declare only if SIGDANGER.
6094 * xdisp.c (redisplay_window): Simplify code, to make it more
6095 obvious that ignore_mouse_drag_p is not accessed if !defined
6096 USE_GTK && !defined HAVE_NS.
6097
93ea6e8f
PE
6098 * intervals.c: Make symbols static if they're not exported.
6099 (merge_properties_sticky, merge_interval_right, delete_interval):
6100 Now static.
6101 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6102
77382fcc
PE
6103 * insdel.c: Make symbols static if they're not exported.
6104 However, leave prepare_to_modify_buffer alone. It's never
6105 called from outside this function, but that appears to be a bug.
6106 (combine_after_change_list, combine_after_change_buffer):
4889fc82 6107 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
6108 (adjust_after_replace_noundo): Remove; unused.
6109 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 6110 (signal_before_change): Remove decls.
77382fcc 6111
9306c32e
PE
6112 * indent.c (val_compute_motion, val_vmotion): Now static.
6113
cd44d2eb
PE
6114 * image.c: Make symbols static if they're not exported.
6115 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6116 if USE_GTK.
6117 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6118 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6119
ad9a7a06
PE
6120 * fringe.c (standard_bitmaps): Now static.
6121 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6122
81626931
PE
6123 * frame.c: Make symbols static if they're not exported.
6124 (x_report_frame_params, make_terminal_frame): Now static.
6125 (get_frame_param): Now static, unless HAVE_NS.
6126 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6127 (x_get_resource_string): Remove; not used.
6128 * frame.h (make_terminal_frame, x_report_frame_params):
6129 (x_get_resource_string); Remove decls.
6130 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6131 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6132
239f9db9
PE
6133 * font.c, fontset.c: Make symbols static if they're not exported.
6134 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6135 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6136 * font.c (font_close_object): Now static.
6137 * font.h (font_close_object): Remove.
6138 * fontset.c (FONTSET_OBJLIST): Remove.
6139 (free_realized_fontset) #if-0 the body, which does nothing.
6140 (face_suitable_for_char_p): #if-0, as it's never called.
6141 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
6142 * xfaces.c (face_at_string_position):
6143 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
6144 since 0 is always ASCII.
6145
dfcf3579
PE
6146 * fns.c (weak_hash_tables): Now static.
6147
5045092b
PE
6148 * fileio.c: Make symbols static if they're not exported.
6149 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6150 (Vwrite_region_annotation_buffers): Now static.
6151
57a96f5c
PE
6152 * eval.c: Make symbols static if they're not exported.
6153 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6154 * lisp.h (backtrace_list): Remove decl.
6155
35f08c38
PE
6156 * emacs.c: Make symbols static if they're not exported.
6157 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6158 (fatal_error_code, fatal_error_signal_hook, standard_args):
6159 Now static.
6160 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6161 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6162 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6163 * lisp.h (fatal_error_signal_hook): Remove decl.
6164 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6165
f44bd759
PE
6166 * editfns.c: Move a (normally-unused) function to its only use.
6167 * editfns.c, lisp.h (get_operating_system_release): Remove.
6168 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6169 worth the hassle of breaking this out.
6170
b532497d
PE
6171 * xterm.c: Make symbols static if they're not exported.
6172 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6173 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6174 (x_destroy_window, x_delete_display):
6175 Now static.
6176 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6177 (x_mouse_leave): Remove; unused.
6178 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6179 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6180 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6181 Remove decls.
6182 (x_mouse_leave): Declare only if WINDOWSNT.
6183 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6184 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6185 USE_X_TOOLKIT.
6186
1675728f
PE
6187 * ftxfont.c: Make symbols static if they're not exported.
6188 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6189 HAVE_FREETYPE.
6190 * font.h (ftxfont_driver): Likewise.
6191
e4cebfca
PE
6192 * xfns.c: Make symbols static if they're not exported.
6193 (x_last_font_name, x_display_info_for_name):
6194 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6195 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6196 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6197 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6198 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6199 (last_show_tip_args): Now static.
6200 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6201 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6202 (x_screen_planes): Remove; unused.
6203 * dispextern.h (x_screen_planes): Remove decl.
6204
5bf46f05
PE
6205 * dispnew.c: Make symbols static if they're not exported.
6206 * dispextern.h (redraw_garbaged_frames, scrolling):
6207 (increment_row_positions): Remove.
6208 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6209 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6210 Now static.
6211 (redraw_garbaged_frames): Remove; unused.
6212
435f4c28
PE
6213 * xfaces.c: Make symbols static if they're not exported.
6214 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6215 Remove decls.
6216 * xterm.h (defined_color): Remove decls.
6217 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6218 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6219 (menu_face_changed_default, defined_color, free_realized_face):
6220 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6221 (ascii_face_of_lisp_face): Remove; unused.
6222
8524aef3
PE
6223 * xdisp.c: Make symbols static if they're not exported.
6224 * dispextern.h (scratch_glyph_row, window_box_edges):
6225 (glyph_to_pixel_coords, set_cursor_from_row):
6226 (get_next_display_element, set_iterator_to_next):
6227 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6228 (show_mouse_face): Remove decls
6229 * frame.h (message_buf_print): Likewise.
6230 * lisp.h (pop_message, set_message, check_point_in_composition):
6231 Likewise.
6232 * xterm.h (set_vertical_scroll_bar): Likewise.
6233 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6234 (message_buf_print, scratch_glyph_row, displayed_buffer):
6235 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6236 (get_next_display_element, show_mouse_face, window_box_edges):
6237 (frame_to_window_pixel_xy, check_point_in_composition):
6238 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6239 (glyph_to_pixel_coords): Remove; unused.
6240
16390cd2
PE
6241 * dired.c (file_name_completion): Now static.
6242
6243 * dbusbind.c (xd_in_read_queued_messages): Now static.
6244
a25f4dfa
PE
6245 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6246 * data.c (circular_list_error): Remove.
6247
14a9c8df
PE
6248 * commands.h (last_point_position, last_point_position_buffer):
6249 (last_point_position_window): Remove decls.
6250 * keyboard.c: Make these variables static.
6251
04f2d78b
CB
6252 * coding.h (coding, code_convert_region, encode_coding_gap):
6253 Remove decls.
74ab6df5
PE
6254 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6255 (iso_code_class, detect_coding, code_convert_region): Now static.
6256 (encode_coding_gap): Remove; unused.
6257
38dfbee1
PE
6258 * chartab.c (chartab_chars, chartab_bits): Now static.
6259
a2cb4e63
PE
6260 * charset.h (charset_iso_8859_1): Remove decl.
6261 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6262 Now static.
6263
127198fd
PE
6264 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6265 * ccl.c (Vccl_program_table): Now static.
6266 (check_ccl_update): Remove; unused.
6267
d85b608f
PE
6268 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6269 * category.h: ... from here.
6270 * category.c (check_category_table, set_category_set): Now static.
6271
31cd66f3
PE
6272 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6273 * lisp.h: Remove these decls.
6274
c358e587
PE
6275 * buffer.c (buffer_count): Remove unused var.
6276
e78aecca
PE
6277 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6278 so that it's not optimized away.
6279 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6280 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6281 exported only to the debugger.
6282
e192d7d3 6283 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 6284 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 6285
92470028
PE
6286 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6287 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6288 was inaccessible from Lisp.
6289 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6290 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6291
244ed907
PE
6292 alloc.c: Import and export fewer symbols, and remove unused items.
6293 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6294 is defined.
6295 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6296 it's not optimized away by whole-program optimization.
6297 (message_enable_multibyte, free_misc): Remove.
6298 (catchlist, handlerlist, mark_backtrace):
6299 Declare only if BYTE_MARK_STACK.
6300 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6301 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6302 (message_enable_multibyte): Remove decl.
6303 (free_misc, interval_free_list, float_block, float_block_index):
6304 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6305 (cons_free_list, last_marked_index):
6306 Now static.
6307 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6308 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6309 (mark_backtrace): Define only if BYTE_MARK_STACK.
6310 * xdisp.c (message_enable_multibyte): Now static.
6311
61c2b50e 6312 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
6313 This makes it easier for human readers (and static analyzers)
6314 to see whether these variables are used from other modules.
6315 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6316 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6317 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6318 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6319 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6320 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6321 * xmenu.c, xselect.c:
6322 Declare Q* vars static if they are not used in other modules.
6323 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6324 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6325 Remove decls of unexported vars.
6326 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6327
95c82688
PE
6328 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6329
16a97296
PE
6330 Make Emacs functions such as Fatom 'static' by default.
6331 This makes it easier for human readers (and static analyzers)
6332 to see whether these functions can be called from other modules.
6333 DEFUN now defines a static function. To make the function external
6334 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
6335 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6336 (Finit_image_library):
16a97296
PE
6337 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6338 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6339 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6340 Remove decls, since these functions are now static.
6341 (Funintern, Fget_internal_run_time): New decls, since these functions
6342 were already external.
95c82688 6343
16a97296
PE
6344 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6345 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6346 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6347 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6348 * keyboard.c, keymap.c, lread.c:
6349 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6350 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6351 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6352 Mark functions with DEFUE instead of DEFUN,
6353 if they are used in other modules.
6354 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6355 decls for now-static functions.
6356 * buffer.h (Fdelete_overlay): Remove decl.
6357 * callproc.c (Fgetenv_internal): Mark as internal.
6358 * composite.c (Fremove_list_of_text_properties): Remove decl.
6359 (Fcomposition_get_gstring): New forward static decl.
6360 * composite.h (Fcomposite_get_gstring): Remove decl.
6361 * dired.c (Ffile_attributes): New forward static decl.
6362 * doc.c (Fdocumntation_property): New forward static decl.
6363 * eval.c (Ffetch_bytecode): New forward static decl.
6364 (Funintern): Remove extern decl; now in .h file where it belongs.
6365 * fileio.c (Fmake_symbolic_link): New forward static decl.
6366 * image.c (Finit_image_library): New forward static decl.
6367 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6368 * intervals.h (Fprevious_property_change):
6369 (Fremove_list_of_text_properties): Remove decls.
6370 * keyboard.c (Fthis_command_keys): Remove decl.
6371 (Fcommand_execute): New forward static decl.
6372 * keymap.c (Flookup_key): New forward static decl.
6373 (Fcopy_keymap): Now static.
6374 * keymap.h (Flookup_key): Remove decl.
6375 * process.c (Fget_process): New forward static decl.
6376 (Fprocess_datagram_address): Mark as internal.
6377 * syntax.c (Fsyntax_table_p): New forward static decl.
6378 (skip_chars): Remove duplicate decl.
6379 * textprop.c (Fprevious_property_change): New forward static decl.
6380 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6381 Now internal.
6382 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6383 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6384
785bbd42
PE
6385 * editfns.c (Fformat): Remove unreachable code.
6386
8b913b57
AS
63872011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6388
6389 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6390 change. (Bug#8496)
6391
a6744a35
EZ
63922011-04-13 Eli Zaretskii <eliz@gnu.org>
6393
6394 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6395 when at ZV. (Bug#8487)
6396
e7974947
AS
63972011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6398
baad03f0
AS
6399 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6400 (Bug#8437)
6401 * keyboard.c (parse_tool_bar_item): Likewise.
6402 * sound.c (sound_cleanup, alsa_close): Likewise.
6403 * termcap.c (tgetent): Likewise.
6404 * xfns.c (x_default_font_parameter): Likewise.
6405 * xsettings.c (read_and_apply_settings): Likewise.
6406
e7974947
AS
6407 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6408 (overrun_check_free): Protoize.
6409
28272684
PE
64102011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6411
6412 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6413 since callers should never pass a negative size.
6414 Change the signature to match that of plain 'read' and 'write'; see
6415 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6416 * lisp.h: Update prototypes of emacs_write and emacs_read.
6417
11997c76
EZ
64182011-04-11 Eli Zaretskii <eliz@gnu.org>
6419
6420 * xdisp.c (redisplay_window): Don't try to determine the character
6421 position of the scroll margin if the window start point w->startp
e896f03c 6422 is outside the buffer's accessible region. (Bug#8468)
11997c76 6423
8a2cbd72
EZ
64242011-04-10 Eli Zaretskii <eliz@gnu.org>
6425
6426 Fix write-region and its subroutines for buffers > 2GB.
6427 * fileio.c (a_write, e_write): Modify declaration of arguments and
6428 local variables to support buffers larger than 2GB.
6429 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6430
6431 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6432 argument, local variables, and return value.
6433
6434 * lisp.h: Update prototypes of emacs_write and emacs_read.
6435
6436 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6437
4073e537 64382011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 6439
1ebfdcb6
PE
6440 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6441
b2ded58d
PE
6442 Fix more problems found by GCC 4.6.0's static checks.
6443
7d66342c
PE
6444 * xdisp.c (vmessage): Use a better test for character truncation.
6445
bbf47d44
PE
6446 * charset.c (load_charset_map): <, not <=, for optimization,
6447 and to avoid potential problems with integer overflow.
9248994d 6448 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 6449 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 6450 * editfns.c (Fformat): Likewise.
1e69125e 6451 * syntax.c (skip_chars): Likewise.
3befa583 6452
e3019616
PE
6453 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6454 This also lets GCC 4.6.0 generate slightly better loop code.
6455
becfa255
PE
6456 * callint.c (Fcall_interactively): <, not <=, for optimization.
6457 (Fcall_interactively): Count the number of arguments produced,
6458 not the number of arguments given. This is simpler and lets GCC
6459 4.6.0 generate slightly better code.
6460
dae0cd48
PE
6461 * ftfont.c: Distingish more carefully between FcChar8 and char.
6462 The previous code passed unsigned char * to a functions like
6463 strlen and xstrcasecmp that expect char *, which does not
6464 conform to the C standard.
6465 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6466 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6467 char * when the C standard requires it.
6468
76032d70
PE
6469 * keyboard.c (read_char): Remove unused var.
6470
eb3f1cc8
PE
6471 * eval.c: Port to Windows vsnprintf (Bug#8435).
6472 Include <limits.h>.
6473 (SIZE_MAX): Define if the headers do not.
6474 (verror): Do not give up if vsnprintf returns a negative count.
6475 Instead, grow the buffer. This ports to Windows vsnprintf, which
6476 does not conform to C99. Problem reported by Eli Zaretskii.
6477 Also, simplify the allocation scheme, by avoiding the need for
6478 calling realloc, and removing the ALLOCATED variable.
6479
70476b54
PE
6480 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6481
12020a9e
PE
6482 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6483 But keep the doprint source code for now, as we might revamp it
6484 and use it again (Bug#8435).
ea6c7ae6
PE
6485 * lisp.h (doprnt): Remove.
6486 * Makefile.in (base_obj): Remove doprnt.o.
6487 * deps.mk (doprnt.o): Remove.
6488
5fdb398c
PE
6489 error: Print 32- and 64-bit integers portably (Bug#8435).
6490 Without this change, on typical 64-bit hosts error ("...%d...", N)
6491 was used to print both 32- and 64-bit integers N, which relied on
6492 undefined behavior.
6493 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6494 New macro.
6495 * lisp.h (error, verror): Mark as printf-like functions.
6496 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6497 Report overflow in size calculations when allocating printf buffer.
6498 Do not truncate output string at its first null byte.
6499 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6500 Truncate the output at a character boundary, since vsnprintf does not
6501 do that.
6502 * charset.c (check_iso_charset_parameter): Convert internal
6503 character to string before calling 'error', since %c now has the
6504 printf meaning.
6505 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6506 overflow when computing char to be passed to 'error'. Do not
6507 pass Lisp_Object to 'error'; pass the integer instead.
6508 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6509 formatted with plain %d.
6510
b189fa66
PE
6511 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6512
bff87ef0
PE
6513 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6514
7e2cac20
PE
6515 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6516
ce4d90b5
PE
6517 * xterm.c (x_catch_errors): Remove duplicate declaration.
6518
266c9547
PE
6519 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6520
79c49ad2
PE
6521 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6522
368f4090
JM
65232011-04-10 Jim Meyering <meyering@redhat.com>
6524
6525 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6526 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6527 return ssize_t not "int", and use size_t as the buffer length.
6528 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6529 * gnutls.h: Update declarations.
6530 * process.c (read_process_output): Use ssize_t, to match.
6531 (send_process): Likewise.
6532
a32d4040
CY
65332011-04-09 Chong Yidong <cyd@stupidchicken.com>
6534
6535 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6536
8546720e 65372011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 6538
04f2d78b
CB
6539 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6540 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 6541
8546720e
GM
6542 * xterm.c (handle_one_xevent):
6543 * xmenu.c (create_and_show_popup_menu):
6544 * xselect.c (x_decline_selection_request)
6545 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 6546
0a2f5c1a 65472011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
6548
6549 Fix some uses of `int' instead of EMACS_INT.
6550 * search.c (string_match_1, fast_string_match)
6551 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6552 (scan_buffer, find_next_newline_no_quit)
6553 (find_before_next_newline, search_command, Freplace_match)
6554 (Fmatch_data): Make some `int' variables be EMACS_INT.
6555
6556 * xdisp.c (display_count_lines): 3rd argument and return value now
6557 EMACS_INT. All callers changed.
6558 (pint2hrstr): Last argument is now EMACS_INT.
6559
6560 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6561 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6562 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6563 (decode_coding_utf_16, decode_coding_emacs_mule)
6564 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6565 (decode_coding_ccl, decode_coding_charset)
6566 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6567 (decode_coding_iso_2022, decode_coding_emacs_mule)
6568 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6569 <char_offset, last_offset>: Declare EMACS_INT.
6570 (encode_coding_utf_8, encode_coding_utf_16)
6571 (encode_coding_emacs_mule, encode_invocation_designation)
6572 (encode_designation_at_bol, encode_coding_iso_2022)
6573 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6574 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6575 Declare EMACS_INT.
6576 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6577 (encode_invocation_designation): Last argument P_NCHARS is now
6578 EMACS_INT.
6579 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6580 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6581
6582 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6583 All users changed.
6584
6585 * ccl.c (Fccl_execute_on_string): Declare some variables
6586 EMACS_INT.
6587
8546720e 65882011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
6589
6590 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6591
4e19a977
CS
65922011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6593
6594 * process.c (Fformat_network_address): Doc fix.
6595
87302331
R
65962011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6597
6598 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6599
cbb59342
CY
66002011-04-08 Chong Yidong <cyd@stupidchicken.com>
6601
6602 * keyboard.c (read_char): Call Lisp function help-form-show,
6603 instead of using internal_with_output_to_temp_buffer.
6604 (Qhelp_form_show): New var.
e0d38eeb 6605 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
6606
6607 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6608
6609 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6610
e67a13ab
CY
66112011-04-06 Chong Yidong <cyd@stupidchicken.com>
6612
04f2d78b
CB
6613 * process.c (Flist_processes): Remove to Lisp.
6614 (list_processes_1): Delete.
e67a13ab 6615
973f782d
EZ
66162011-04-06 Eli Zaretskii <eliz@gnu.org>
6617
7c106b1e
EZ
6618 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6619
973f782d
EZ
6620 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6621
41cf7d1a 66222011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 6623
ca23cc88
PE
6624 Fix more problems found by GCC 4.6.0's static checks.
6625
f390e2d5
PE
6626 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6627
42eea0d0
PE
6628 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6629
b69769da 6630 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 6631
f9541e84
PE
6632 * xdisp.c (vmessage): Mark as a printf-like function.
6633
13841b55
PE
6634 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6635
c136c10f
PE
6636 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6637
5e2d4a30
PE
6638 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6639 printf-like functions.
6640 (tiff_load): Add casts to remove these marks before passing them
6641 to system-supplied API.
6642
583f48b9
PE
6643 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6644
b25d760e
PE
6645 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6646 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
6647 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6648 directly, rather than having caller test rule sign. This avoids
6649 some unnecessary tests.
6650 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6651 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6652 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 6653
bc7b6697 6654 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 6655 (xfont_open): Avoid unnecessary tests.
bc7b6697 6656
27ccc379
PE
6657 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6658
dcd5c89a
PE
6659 * composite.h, composite.c (composition_gstring_put_cache):
6660 Use EMACS_INT, not int, for length.
6661
b13a45c6
PE
6662 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6663 breaking out part of COMPOSITION_DECODE_RULE.
6664 (COMPOSITION_DECODE_RULE): Use it.
6665 * composite.c (get_composition_id): Remove unused local vars,
6666 by using the new macro.
6667
1e792e4d
PE
6668 * textprop.c (set_text_properties_1): Change while to do-while,
6669 since the condition is always true at first.
6670
dc6c6455 6671 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
6672 (interval_deletion_adjustment): Return unsigned value.
6673 All uses changed.
dc6c6455 6674
aba7731a
PE
6675 * process.c (list_processes_1, create_pty, read_process_output):
6676 (exec_sentinel): Remove vars that were set but not used.
afd4052b 6677 (create_pty): Remove unnecessary "volatile"s.
bc57d757 6678 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 6679 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 6680 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 6681
fdfc4bf3
PE
6682 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6683
fca8fe46 6684 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 6685 (update_syntax_table): Use unsigned instead of int.
fca8fe46 6686
06a0259a 6687 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 6688 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 6689 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 6690
e7b9e80f
PE
6691 * print.c (print_error_message): Avoid int overflow.
6692
56201685
PE
6693 * font.c (font_list_entities): Redo for clarity,
6694 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6695
78834453 6696 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 6697 (font_score): Avoid potential overflow in diff calculation.
78834453 6698
0bc0b309 6699 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 6700 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 6701
e610eaca
PE
6702 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6703
b895abce
PE
6704 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6705 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6706 can always succeed if overflow has undefined behavior.
6707
1f1d9321 6708 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 6709 (wordify): Omit three unnecessary tests.
1f1d9321 6710
c59478bc
PE
6711 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6712 All callers changed. This avoids the need for an unused var.
6713
79b73827
PE
6714 * casefiddle.c (casify_region): Remove var that is set but not used.
6715
a4db5dfe
PE
6716 * dired.c (file_name_completion): Remove var that is set but not used.
6717
43aae36e
PE
6718 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6719
2a47c44d 6720 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 6721 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 6722
a37c69bf
PE
6723 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6724 Check for integer overflow on size calculations.
6725
328ab8e7
PE
6726 * buffer.c (Fprevious_overlay_change): Remove var that is set
6727 but not used.
6728
e5a2a5cb
PE
6729 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6730 Remove vars that are set but not used.
8d84a6eb 6731 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 6732 (timer_check_2): Mark vars as initialized.
e5a2a5cb 6733
a60e5f68
PE
6734 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6735
f661cb61 6736 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 6737 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 6738
f0397f5a
PE
6739 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6740 that are set but not used.
6741
8664db06 6742 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 6743 if XCreateBitmapFromData fails (Bug#8410).
8664db06 6744
6abdaa4a
PE
6745 * xselect.c (x_get_local_selection, x_handle_property_notify):
6746 Remove vars that are set but not used.
6747
0ce7538d 6748 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 6749 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 6750
9ae848fc
PE
6751 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6752 Remove var that is set but not used.
0b918413
PE
6753 (scroll_bar_windows_size): Now size_t, not int.
6754 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6755 Check for overflow.
9ae848fc 6756
a5a62657
PE
6757 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6758 (map_tty_color) [!defined MSDOS]: Likewise.
6759
5c5cdd39
PE
6760 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6761
66ebf983
PE
6762 * coding.c: Remove vars that are set but not used.
6763 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6764 All callers changed.
6765 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6766 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6767 (decode_coding_charset): Remove vars that are set but not used.
6768
1be4d761
PE
6769 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6770 that is set but not used.
6771
47553fa8
PE
6772 * print.c (print_object): Remove var that is set but not used.
6773
1f7196bf 6774 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
6775 The gnulib version avoids calling malloc in the usual case,
6776 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6777 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6778 * filelock.c (current_lock_owner): Likewise.
6779 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6780 * sysdep.c: Include allocator.h, careadlinkat.h.
6781 (emacs_no_realloc_allocator): New static constant.
6782 (emacs_readlink): New function.
fdb61804
PE
6783 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6784 ../lib/careadlinkat.h.
d1fdcab7 6785
f84c17c7
SM
67862011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6787
6788 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6789 first non-nil return value).
6790
ef3862ad
JD
67912011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6792
6793 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6794 if not defined (Bug#8403).
6795
376a7006
JB
67962011-04-02 Juanma Barranquero <lekktu@gmail.com>
6797
6798 * xdisp.c (display_count_lines): Remove parameter `start',
6799 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6800 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6801 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6802 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6803 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6804 and thereabouts. All callers changed.
6805 (get_per_char_metric): Remove parameter `f', unused since
6806 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6807
6ca3801d
JM
68082011-04-02 Jim Meyering <meyering@redhat.com>
6809
6810 do not dereference NULL upon failed strdup
6811 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6812 (ns_get_family): Likewise.
6813
d8e2b5ba
JB
68142011-04-02 Juanma Barranquero <lekktu@gmail.com>
6815
6816 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6817
8c74fcbd
JD
68182011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6819
6820 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6821 later (Bug#8403).
6822
7200d79c
SM
68232011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6824
03408648 6825 Add lexical binding.
7200d79c 6826
03408648
SM
6827 * window.c (Ftemp_output_buffer_show): New fun.
6828 (Fsave_window_excursion):
6829 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6830
6831 * lread.c (lisp_file_lexically_bound_p): New function.
6832 (Fload): Bind Qlexical_binding.
6833 (readevalloop): Remove `evalfun' arg.
6834 Bind Qinternal_interpreter_environment.
6835 (Feval_buffer): Bind Qlexical_binding.
6836 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6837 Mark as dynamic.
6838 (syms_of_lread): Declare `lexical-binding'.
6839
6840 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6841
6842 * keyboard.c (eval_dyn): New fun.
6843 (menu_item_eval_property): Use it.
ca105506
SM
6844
6845 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 6846
03408648
SM
6847 * fns.c (concat, mapcar1): Accept byte-code-functions.
6848
6849 * eval.c (Fsetq): Handle lexical vars.
6850 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6851 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6852 (FletX, Flet): Obey lexical binding.
6853 (Fcommandp): Handle closures.
6854 (Feval): New `lexical' arg.
6855 (eval_sub): New function extracted from Feval. Use it almost
6856 everywhere where Feval was used. Look up vars in lexical env.
6857 Handle closures.
6858 (Ffunctionp): Move from subr.el.
6859 (Ffuncall): Handle closures.
6860 (apply_lambda): Remove `eval_flags'.
6861 (funcall_lambda): Handle closures and new byte-code-functions.
6862 (Fspecial_variable_p): New function.
6863 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6864 but without exporting it to Lisp.
23aba0ea 6865
23aba0ea 6866 * doc.c (Fdocumentation, store_function_docstring):
03408648 6867 * data.c (Finteractive_form): Handle closures.
23aba0ea 6868
03408648
SM
6869 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6870 interactive spec.
ba83908c 6871
04f2d78b
CB
6872 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6873 New byte-codes.
03408648
SM
6874 (exec_byte_code): New function extracted from Fbyte_code to handle new
6875 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 6876
03408648 6877 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 6878
03408648 6879 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 6880
e2abce01
JB
68812011-03-31 Juanma Barranquero <lekktu@gmail.com>
6882
6883 * xdisp.c (redisplay_internal): Fix prototype.
6884
63696a73 68852011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 6886
63696a73 6887 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
6888 (try_scrolling): Use it when setting scroll_limit.
6889 Limit scrolling to 100 screen lines.
63696a73
EZ
6890 (redisplay_window): Even when falling back on "recentering",
6891 position point in the window according to scroll-conservatively,
6892 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6893
6894 (try_scrolling): When point is above the window, allow searching
6895 as far as scroll_max, or one screenful, to compute vertical
6896 distance from PT to the scroll margin position. This prevents
6897 try_scrolling from unnecessarily failing when
6898 scroll-conservatively is set to a value slightly larger than the
6899 window height. Clean up the case of PT below the margin at bottom
6900 of window: scroll_max can no longer be INT_MAX. When aggressive
6901 scrolling is in use, don't let point enter the opposite scroll
6902 margin as result of the scroll.
6903 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
6904 threshold of 100 lines for never-recentering scrolling.
6905
e4cc2dfc
JB
69062011-03-31 Juanma Barranquero <lekktu@gmail.com>
6907
6908 * dispextern.h (move_it_by_lines):
6909 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6910 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6911 (message_log_check_duplicate): Remove parameters `prev_bol' and
6912 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6913 (redisplay_internal): Remove parameter `preserve_echo_area',
6914 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6915
6916 * indent.c (Fvertical_motion):
6917 * window.c (window_scroll_pixel_based, Frecenter):
6918 Don't pass `need_y_p' to `move_it_by_lines'.
6919
1c470562
SM
69202011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6921
44f230aa
SM
6922 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6923 steal a few bits to be more compact.
6924 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6925 Remove unneeded casts.
6926
1c470562
SM
6927 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6928
888adce9
ZK
69292011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6930
6931 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6932 binding" message (bug#7967).
6933
f838ed7b
PE
69342011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6935
77861b95
PE
6936 Fix more problems found by GCC 4.6.0's static checks.
6937
de6dbc14
PE
6938 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6939 Remove unused local var.
6940
f838ed7b
PE
6941 * editfns.c (Fmessage_box): Remove unused local var.
6942
792c7b2b
PE
6943 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6944 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6945 Omit unused local vars.
c499e557 6946 * window.c (shrink_windows): Omit unused local var.
b01a1c29 6947 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
6948 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6949 Omit unused local var.
6950
ba0165e1
PE
6951 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6952 Don't assume string length fits in int.
32ad8845 6953 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 6954 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 6955
3c59b4c9
PE
6956 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6957 instead of alloca (Bug#8344).
6958
a3eed478 6959 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 6960 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 6961
eb4d412d
PE
6962 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6963
1658b401
PE
6964 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6965 concerns.
6966
6967 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6968
6969 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 6970
9a2c6e05
PE
6971 * keyboard.c (syms_of_keyboard): Use the same style as later
6972 in this function when indexing through an array. This also
6973 works around GCC bug 48267.
6974
03d0a109
PE
6975 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6976
44f730c8
PE
6977 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6978
fe75f926
PE
6979 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6980 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6981
ffa8c828
PE
6982 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6983 This avoids undefined behavior on integer overflow, and is a bit
6984 more convenient anyway since it is compared to a size_t variable.
6985
c5101a77
PE
6986 Variadic C functions now count arguments with size_t, not int.
6987 This avoids an unnecessary limitation on 64-bit machines, which
6988 caused (substring ...) to crash on large vectors (Bug#8344).
6989 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6990 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 6991 All variadic functions and their callers changed accordingly.
c5101a77
PE
6992 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6993 * data.c (arith_driver, float_arith_driver): Likewise.
6994 * editfns.c (general_insert_function): Likewise.
6995 * eval.c (struct backtrace.nargs, interactive_p)
6996 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6997 (funcall_lambda, mark_backtrace): Likewise.
6998 * fns.c (concat): Likewise.
6999 * frame.c (x_set_frame_parameters): Likewise.
7000 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7001 0 if not found, not -1. All callers changed.
7002
dd3f25f7
PE
7003 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7004 (stack_copy_size): Now size_t, not int.
7005 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7006
461c2ab9
JB
70072011-03-28 Juanma Barranquero <lekktu@gmail.com>
7008
7009 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7010 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7011 All callers changed.
7012
7013 * lisp.h (multibyte_char_to_unibyte):
7014 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7015 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7016 * character.h (CHAR_TO_BYTE8):
7017 * cmds.c (internal_self_insert):
7018 * editfns.c (general_insert_function):
7019 * keymap.c (push_key_description):
7020 * search.c (Freplace_match):
7021 * xdisp.c (message_dolog, set_message_1): All callers changed.
7022
f6d62986
SM
70232011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7024
7025 * keyboard.c (safe_run_hook_funcall): New function.
7026 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7027 don't set the hook to nil, but remove the offending function instead.
7028 (Qcommand_hook_internal): Remove, unused.
7029 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7030 Vcommand_hook_internal.
7031
7032 * eval.c (enum run_hooks_condition): Remove.
7033 (funcall_nil, funcall_not): New functions.
7034 (run_hook_with_args): Call each function through a `funcall' argument.
7035 Remove `cond' argument, now redundant.
7036 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7037 (Frun_hook_with_args_until_failure): Adjust accordingly.
7038 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7039
1db5b1ad
JB
70402011-03-28 Juanma Barranquero <lekktu@gmail.com>
7041
7042 * dispextern.h (string_buffer_position): Remove declaration.
7043
7044 * print.c (strout): Remove parameter `multibyte', unused since
7045 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7046
7047 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7048 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7049 All callers changed.
7050
7051 * w32.c (_wsa_errlist): Use braces for struct initializers.
7052
7053 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7054 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7055 All callers changed.
7056 (string_buffer_position): Likewise. Also, make static (it's never
7057 used outside xdisp.c).
7058 (cursor_row_p): Remove parameter `w', unused since
7059 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7060 (decode_mode_spec): Remove parameter `precision', introduced during
7061 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7062 All callers changed.
7063
5ffb62aa
JD
70642011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7065
7066 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7067
461c2ab9 70682011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
7069
7070 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7071 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7072 (ns_update_auto_hide_menu_bar): New functions.
7073 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7074 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7075 ns_constrain_all_frames.
7076 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7077 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7078
5c380ffb
JD
70792011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7080
7081 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7082
9af30bdf
GM
70832011-03-27 Glenn Morris <rgm@gnu.org>
7084
7085 * syssignal.h: Replace RETSIGTYPE with void.
7086 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7087 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7088 Replace SIGTYPE with void everywhere.
7089 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7090 * s/template.h (SIGTYPE): Remove commented out definition.
7091
e2abce01
JB
70922011-03-26 Eli Zaretskii <eliz@gnu.org>
7093
7094 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7095 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7096
f868cd8a
JB
70972011-03-26 Juanma Barranquero <lekktu@gmail.com>
7098
59eb0929
JB
7099 * w32.c (read_unc_volume): Use parameter `henum', instead of
7100 global variable `wget_enum_handle'.
7101
7102 * keymap.c (describe_vector): Remove parameters `indices' and
7103 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7104 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7105
f868cd8a
JB
7106 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7107
7108 * keyboard.c (timer_check): Remove parameter `do_it_now',
7109 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7110 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7111 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7112
7113 * keyboard.c (read_char):
7114 * w32menu.c (w32_menu_display_help):
7115 * xmenu.c (show_help_event, menu_help_callback):
7116 Adjust calls to `show_help_echo'.
7117
7118 * gtkutil.c (xg_maybe_add_timer):
7119 * keyboard.c (readable_events):
7120 * process.c (wait_reading_process_output):
7121 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7122
7123 * insdel.c (adjust_markers_gap_motion):
7124 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7125 (gap_left, gap_right): Don't call it.
7126
2ecf6fdb
CY
71272011-03-25 Chong Yidong <cyd@stupidchicken.com>
7128
7129 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7130 incurred during fontification.
7131
6b1f9ba4
JB
71322011-03-25 Juanma Barranquero <lekktu@gmail.com>
7133
7134 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7135 (DEFVAR_PER_BUFFER): Don't pass it.
7136
7137 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7138 (scrolling_window): Don't pass it.
7139
0f4a96b5
JB
71402011-03-25 Juanma Barranquero <lekktu@gmail.com>
7141
7142 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7143
7144 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7145 and `suffix'.
7146 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7147 of variables specific to SELinux and computation of `encoded_absname'.
7148
7149 * image.c (XPutPixel): Remove unused variable `height'.
7150
7151 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7152
7153 * unexw32.c (get_section_info): Remove unused variable `section'.
7154
7155 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7156 (system_process_attributes): Remove unused variable `sess'.
7157 (sys_read): Remove unused variable `err'.
7158
7159 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7160 (w32_wnd_proc): Remove unused variable `isdead'.
7161 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7162 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7163 (x_create_tip_frame): Remove unused variable `tem'.
7164
7165 * w32inevt.c (w32_console_read_socket):
7166 Remove unused variable `no_events'.
7167
7168 * w32term.c (x_draw_composite_glyph_string_foreground):
7169 Remove unused variable `width'.
7170
1149507c
JB
71712011-03-24 Juanma Barranquero <lekktu@gmail.com>
7172
7173 * w32term.c (x_set_glyph_string_clipping):
7174 Don't pass uninitialized region to CombineRgn.
7175
9c88f339
JB
71762011-03-23 Juanma Barranquero <lekktu@gmail.com>
7177
7178 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7179 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7180 (Fx_close_connection): Remove unused variable `i'.
7181
7182 * w32font.c (w32font_draw): Return number of glyphs.
7183 (w32font_open_internal): Remove unused variable `i'.
7184 (w32font_driver): Add missing initializer.
7185
7186 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7187 (fill_in_menu): Remove unused variable `items_added'.
7188
7189 * w32term.c (last_mouse_press_frame): Remove static global variable.
7190 (w32_clip_to_row): Remove unused variable `f'.
7191 (x_delete_terminal): Remove unused variable `i'.
7192
7193 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7194 (NOTHING): Remove unused static global variable.
7195 (uniscribe_check_otf): Remove unused variable `table'.
7196 (uniscribe_font_driver): Add missing initializers.
7197
dee091a3
JD
71982011-03-23 Julien Danjou <julien@danjou.info>
7199
7200 * term.c (Fsuspend_tty, Fresume_tty):
7201 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7202 * window.c (temp_output_buffer_show):
7203 * insdel.c (signal_before_change):
7204 * frame.c (Fhandle_switch_frame):
7205 * fileio.c (Fdo_auto_save):
7206 * emacs.c (Fkill_emacs):
7207 * editfns.c (save_excursion_restore):
7208 * cmds.c (internal_self_insert):
7209 * callint.c (Fcall_interactively):
7210 * buffer.c (Fkill_all_local_variables):
7211 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7212 Use Frun_hooks.
0f4a96b5 7213 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
7214 unconditionnaly since it does the check itself.
7215
2c520ab5 72162011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 7217
c9c49752
PE
7218 Fix more problems found by GCC 4.5.2's static checks.
7219
8abc3f12
PE
7220 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7221 the first time through the loop, since we know p0 < p1 then.
7222 This also avoids a gcc -Wstrict-overflow warning.
7223
a2d26660
PE
7224 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7225 leading to a memory leak, possible in functions like
7226 load_charset_map_from_file that can allocate an unbounded number
b12ef411 7227 of objects (Bug#8318).
a2d26660 7228
916c72e9
PE
7229 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7230 that could (at least in theory) be that large.
7231
19ab8a18
PE
7232 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7233 This is less likely to overflow, and avoids undefined behavior if
7234 overflow does occur. All callers changed. Use strtoul to scan
7235 for the unsigned long integer.
b7cbbd6f
PE
7236 (pint2hrstr): Simplify and tune code slightly.
7237 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 7238
f0641eff
PE
7239 * scroll.c (do_scrolling): Work around GCC bug 48228.
7240 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7241
7f650bb9
PE
7242 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7243 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
7244 (validate_x_resource_name): Simplify count usage.
7245 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 7246
37dd57d1
PE
7247 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7248 fail (Bug#8306).
81e56e61 7249
699979fc 7250 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 7251
401bf9b4
PE
7252 * process.c (Fmake_network_process): Use socklen_t, not int,
7253 where POSIX says socklen_t is required in portable programs.
7254 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 7255 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
7256 (Fmake_network_process, server_accept_connection):
7257 (wait_reading_process_output, read_process_output):
7258 Likewise.
7259
b93aacde
PE
7260 * process.c: Rename or move locals to avoid shadowing.
7261 (list_processes_1, Fmake_network_process):
7262 (read_process_output_error_handler, exec_sentinel_error_handler):
7263 Rename or move locals.
4dc343ee 7264 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 7265 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 7266 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 7267 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 7268 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 7269
af8a867c 7270 Make tparam.h and terminfo.c consistent.
44f230aa
SM
7271 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7272 Include tparam.h instead, since it declares them.
af8a867c
PE
7273 * cm.h (PC): Remove extern decl; tparam.h now does this.
7274 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7275 * terminfo.c: Include tparam.h, to check interfaces.
7276 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7277 (tparam): Adjust signature to match interface in tparam.h;
7278 this removes some undefined behavior. Check that outstring and len
7279 are zero, which they always are with Emacs.
7280 * tparam.h (PC, BC, UP): New extern decls.
7281
0248044d 7282 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 7283 (xftfont_open): Rename locals to avoid shadowing.
0248044d 7284
8ff096c1 7285 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
7286 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7287 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 7288 (ftfont_list): Remove unused local.
49eaafba
PE
7289 (get_adstyle_property, ftfont_pattern_entity):
7290 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7291 Rename locals to avoid shadowing.
8ff096c1 7292
e2be39f6
PE
7293 * xfont.c (xfont_list_family): Mark var as initialized.
7294
c9735e30
PE
7295 * xml.c (make_dom): Now static.
7296
8f5201ae
PE
7297 * composite.c (composition_compute_stop_pos): Rename local to
7298 avoid shadowing.
b246f932
PE
7299 (composition_reseat_it): Remove unused locals.
7300 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 7301 (composition_update_it): Mark var as initialized.
11b61122
PE
7302 (find_automatic_composition): Mark vars as initialized,
7303 with a FIXME (Bug#8290).
8f5201ae 7304
760fbc2c
PE
7305 character.h: Rename locals to avoid shadowing.
7306 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7307 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7308 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7309 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7310 to avoid shadowing.
7311
ff08eb85
PE
7312 * textprop.c (property_change_between_p): Remove; unused.
7313
fc7bf025
PE
7314 * intervals.c (interval_start_pos): Now static.
7315
235d7abc
PE
7316 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7317
44f230aa
SM
7318 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7319 Rename locals to avoid shadowing.
3e7d6594 7320
50060332
PE
7321 * sound.c (wav_play, au_play, Fplay_sound_internal):
7322 Fix pointer signedness.
d01f234b 7323 (alsa_choose_format): Remove unused local var.
c83b8872
PE
7324 (wav_play): Initialize a variable to 0, to prevent undefined
7325 behavior (Bug#8278).
50060332 7326
c4fc4e30
PE
7327 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7328
918436ed
PE
7329 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7330
c939f91b
PE
7331 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7332 clobbering (Bug#8298).
b9c7f648
PE
7333 * sysdep.c (sys_subshell): Likewise.
7334 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 7335
6bd8c144
PE
7336 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7337 This should get cleaned up, so that child_setup has the
7338 same signature on all platforms.
7339
7710357c 7340 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 7341 (relocate_fd): Rename locals to avoid shadowing.
7710357c 7342
c59da222
CY
73432011-03-22 Chong Yidong <cyd@stupidchicken.com>
7344
7345 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7346 not to be necessary, and produces flickering.
7347
66b87493
GM
73482011-03-20 Glenn Morris <rgm@gnu.org>
7349
7350 * config.in: Remove file.
7351
45b6f6d5
JB
73522011-03-20 Juanma Barranquero <lekktu@gmail.com>
7353
7354 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7355 are now in src/globals.h.
7356 (syms_of_minibuf): Remove spurious & from previous change.
7357
3ec03f7e
LL
73582011-03-20 Leo <sdl.web@gmail.com>
7359
7360 * minibuf.c (completing-read-function): New variable.
7361 (completing-read-default): Rename from completing-read.
7362 (completing-read): Call completing-read-function.
7363
b14e3e21
CY
73642011-03-19 Juanma Barranquero <lekktu@gmail.com>
7365
7366 * xfaces.c (Fx_load_color_file):
7367 Read color file from absolute filename (bug#8250).
7368
f2b726e6
JB
73692011-03-19 Juanma Barranquero <lekktu@gmail.com>
7370
7371 * makefile.w32-in: Update dependencies.
7372
09f6ff02
EZ
73732011-03-17 Eli Zaretskii <eliz@gnu.org>
7374
7375 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7376
29a6015a
PE
73772011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7378
a3a6c54e
PE
7379 Fix more problems found by GCC 4.5.2's static checks.
7380
b766f867
PE
7381 * process.c (make_serial_process_unwind, send_process_trap):
7382 (sigchld_handler): Now static.
7383
be02381c
PE
7384 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7385 That way, the code declares only the vars that it needs.
7386 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7387 * s/cygwin.h (PTY_ITERATION): Likewise.
7388 * s/darwin.h (PTY_ITERATION): Likewise.
7389 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7390
57048744
PE
7391 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7392 * process.c (allocate_pty): Don't declare stb unless it's needed.
7393
7914961c 7394 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
7395 (CONSTANTLIM): Remove; unused.
7396 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7397 Define only if needed.
7914961c 7398
b3967b18
PE
7399 * unexelf.c (unexec): Name an expression,
7400 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
7401 Use a different way to cause a compilation error if anyone uses
7402 n rather than nn, a way that does not involve shadowing.
73366a00 7403 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 7404
29a6015a
PE
7405 * deps.mk (unexalpha.o): Remove; unused.
7406
43cfc33e 7407 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 7408 * unexec.h: New file.
ce701a33
PE
7409 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7410 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7411 Depend on unexec.h.
7412 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7413 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7414 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 7415 Change as necessary to match prototype in unexec.h.
ce701a33 7416
01f44d5a
PE
7417 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7418 shadowing.
4f63c6bb 7419 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 7420
a6670b0b
PE
7421 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7422 Rename locals to avoid shadowing.
7423
cef2010d 7424 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 7425 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 7426
d4d7173a
PE
7427 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7428
f08b802a
PE
7429 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7430 warning when compiling print.c.
7431
3ddb0639
PE
7432 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7433 instead of using an uninitialized var.
5ad03b97 7434 (font_sort_entities): Mark var as initialized.
3ddb0639 7435
170a2692
PE
7436 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7437
e663c700
PE
7438 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7439 pointers to constants.
89bc529a 7440 (font_parse_fcname): Remove unused vars.
7b81e2d0 7441 (font_delete_unmatched): Now static.
ea838e10 7442 (font_get_spec): Remove; unused.
13a547c6
PE
7443 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7444 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7445 Rename or move locals to avoid shadowing.
e663c700 7446
2a80c887 7447 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 7448 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 7449
1384fa33 7450 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 7451 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 7452
8b2c52e9
PE
7453 * alloc.c (mark_backtrace): Move decl from here ...
7454 * lisp.h: ... to here, so that it can be checked.
7455
475545b5 7456 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 7457 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
7458 (lisp_indirect_variable): Name an expression,
7459 to avoid gcc -Wbad-function-cast warning.
1faed8ae 7460 (Fdefvar): Rename locals to avoid shadowing.
475545b5 7461
b1349114 7462 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 7463 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 7464 Use const pointer when appropriate.
b1349114 7465
a2928364
PE
7466 * lisp.h (get_system_name, get_operating_system_release):
7467 Move decls here, to check interfaces.
7468 * process.c (get_operating_system_release): Move decl to lisp.h.
7469 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
7470 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7471 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7472 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
7473 (Fformat_time_string, Fencode_time, Finsert_char):
7474 (Ftranslate_region_internal, Fformat):
7475 Rename or remove local vars to avoid shadowing.
9710023e 7476 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 7477
a415e694
PE
7478 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7479 avoid shadowing.
7480
8ef4622d
PE
7481 * lisp.h (eassert): Check that the argument compiles, even if
7482 ENABLE_CHECKING is not defined.
7483
946f9a5b
PE
7484 * data.c (Findirect_variable): Name an expression, to avoid
7485 gcc -Wbad-function-cast warning.
112396d6 7486 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 7487 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
7488 (Fmake_variable_buffer_local, Fmake_local_variable):
7489 Mark variables as initialized.
52746918 7490 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 7491
e5aab7e7 7492 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
7493 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7494 Rename locals to avoid shadowing.
dff45157
PE
7495 (mark_stack): Move local variables into the #ifdef region where
7496 they're used.
7bc26fdb
PE
7497 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7498 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7499 needed otherwise.
7500 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7501 (GC_STRING_CHARS): Remove; not used.
d40d4be1 7502 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 7503
e5aab7e7
PE
7504 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7505 avoids undefined behavior in theory.
7506
4da60324
PE
7507 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7508
88043301
PE
7509 Use functions, not macros, for up- and down-casing (Bug#8254).
7510 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7511 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7512 to use the following functions instead of these macros.
7513 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7514 EMACS_INT, since callers assume the returned value fits in int.
7515 (upcase1): Likewise, for UPCASE_TABLE.
7516 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 7517 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 7518 the race-condition problem in the old DOWNCASE.
88043301 7519
19ed5445
PE
7520 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7521 Rename locals to avoid shadowing.
7522 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
7523 (regex_compile, re_search_2, re_match_2_internal):
7524 Remove unused local vars.
952db0d7
PE
7525 (FREE_VAR): Rewrite so as not to use empty "else",
7526 which gcc can warn about.
da053e48 7527 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
7528 (RETALLOC_IF): Define only if needed.
7529 (WORDCHAR_P): Likewise. This one is never needed, but is used
7530 only in a comment talking about a compiler bug, so put inside
7531 the #if 0 of that comment.
7532 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7533 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7534 Remove; unused.
19ed5445 7535
1f3561e4 7536 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
7537 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7538 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 7539
ded6f8f7
PE
7540 * search.c (simple_search): Remove unused var.
7541
dbd37a95
PE
7542 * dired.c (compile_pattern): Move decl from here ...
7543 * lisp.h: ... to here, so that it can be checked.
7544 (struct re_registers): New forward decl.
7545
7e47afad
PE
7546 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7547
85f24f61
PE
7548 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7549 All uses changed.
7550 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7551 Rename locals to avoid shadowing.
5671df8f 7552 (Fvertical_motion): Mark locals as initialized.
85f24f61 7553
181aa2be 7554 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 7555 (casify_region): Mark local as initialized.
181aa2be 7556
930d429c
PE
7557 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7558
7082eac6
PE
7559 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7560 New macros, so that the caller can use some names other than
7561 gcpro1, gcpro2, etc.
7562 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7563 of the new macros.
7564 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7565 argument, for consistency with GCPRO2_VAR, etc: it is now the
7566 prefix of the variable, not the variable itself. All uses
7567 changed.
38b2c076
PE
7568 * dired.c (directory_files_internal, file_name_completion):
7569 Rename locals to avoid shadowing.
7570
15206ed9
PE
7571 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7572 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7573 dired.c's scmp function, had undefined behavior.
7574 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7575 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7576 * buffer.h: ... to here, because these macros use current_buffer,
7577 and the new implementation with inline functions needs to have
7578 current_buffer in scope now, rather than later when the macros
7579 are used.
7580 (downcase, upcase1): New static inline functions.
7581 (DOWNCASE, UPCASE1): Reimplement using these functions.
7582 This avoids undefined behavior in expressions like
7583 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7584 from race conditions in accessing the global variables
7585 case_temp1 and case_temp2.
7586 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7587 * lisp.h (case_temp1, case_temp2): Remove their decls.
7588 * character.h (ASCII_CHAR_P): Move from here ...
7589 * lisp.h: ... to here, so that the inline functions mentioned
7590 above can use them.
7591
4a6bea26
PE
7592 * dired.c (directory_files_internal_unwind): Now static.
7593
f14b7e14
PE
7594 * fileio.c (file_name_as_directory, directory_file_name):
7595 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7596 Now static.
2893f146
PE
7597 (file_name_as_directory): Use const pointers when appropriate.
7598 (Fexpand_file_name): Likewise. In particular, newdir might
7599 point at constant storage, so make it a const pointer.
fd4ead52 7600 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
7601 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7602 signedness issues.
f839df0c
PE
7603 (Fset_file_times, Finsert_file_contents, auto_save_error):
7604 Rename locals to avoid shadowing.
f14b7e14 7605
5716756e 7606 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
7607 (Ftry_completion, Fall_completions): Rename or remove locals
7608 to avoid shadowing.
5716756e 7609
b4c3046a
PE
7610 * marker.c (bytepos_to_charpos): Remove; unused.
7611
b45db522
PE
7612 * lisp.h (verify_bytepos, count_markers): New decls,
7613 so that gcc does not warn that these functions aren't declared.
7614
85876d07
PE
7615 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7616 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 7617 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 7618 (copy_text): Remove unused local var.
85876d07 7619
03d78a21 7620 * filelock.c (within_one_second): Now static.
b3dd38ab 7621 (lock_file_1): Rename local to avoid shadowing.
03d78a21 7622
5df8f01b
PE
7623 * buffer.c (fix_overlays_before): Mark locals as initialized.
7624 (fix_start_end_in_overlays): Likewise. This function should be
7625 simplified by using pointers-to-pointers, but that's a different
7626 matter.
b1d876f1 7627 (switch_to_buffer_1): Now static.
8f54f30a
PE
7628 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7629 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 7630
a70072c9 7631 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 7632 Fix pointer signedness issue.
edced198
PE
7633 (sys_subshell): Mark local as volatile if checking for lint,
7634 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 7635 (MAXPATHLEN): Define only if needed.
a70072c9 7636
a0977c44
PE
7637 * process.c (serial_open, serial_configure): Move decls from here ...
7638 * systty.h: ... to here, so that they can be checked.
7639
a884fdcc
PE
7640 * fns.c (get_random, seed_random): Move extern decls from here ...
7641 * lisp.h: ... to here, so that they can be checked.
7642
604efe86 7643 * sysdep.c (reset_io): Now static.
b8950c94 7644 (wait_for_termination_signal): Remove; unused.
604efe86 7645
38fc62d9
PE
7646 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7647 (copy_keymap_item, append_key, push_text_char_description):
7648 Now static.
1004a21a 7649 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 7650 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
7651 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7652 (describe_map_tree):
7653 Rename locals to avoid shadowing.
38fc62d9 7654
2f2650da
PE
7655 * keyboard.c: Declare functions static if they are not used elsewhere.
7656 (echo_char, echo_dash, cmd_error, top_level_2):
7657 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
7658 (read_char, kbd_buffer_get_event, make_lispy_position):
7659 (make_lispy_event, make_lispy_movement, apply_modifiers):
7660 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7661 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7662 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 7663 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 7664 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 7665
a053e86c 7666 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
7667 (mark_kboards): Move decl here ...
7668 * alloc.c (mark_kboards): ... from here.
a053e86c 7669
4752793e
PE
7670 * lisp.h (force_auto_save_soon): New decl.
7671
74f10ca7 7672 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
7673 (DEFINE_DUMMY_FUNCTION): New macro.
7674 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7675 Use it.
c03cd23f
PE
7676 (main): Add casts to avoid warnings
7677 if GCC considers string literals to be constants.
74f10ca7 7678
022e70d4
PE
7679 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7680
59d6fe83
PE
7681 * dbusbind.c: Pointer signedness fixes.
7682 (xd_signature, xd_append_arg, xd_initialize):
7683 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7684 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7685 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7686 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7687
78320123
PE
7688 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7689 if GCC considers string literals to be constants.
49cebcca 7690 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 7691
35ac2a97
SM
76922011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7693
fb103ca9
SM
7694 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7695 (print_preprocess, print_object): New macro to fix last change.
7696
35ac2a97
SM
7697 * print.c (print_preprocess): Don't forget font objects.
7698
62973b41
JB
76992011-03-16 Juanma Barranquero <lekktu@gmail.com>
7700
7701 * emacs.c (USAGE3): Doc fixes.
7702
0e48bb22
AS
77032011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7704
7705 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7706 structure.
7707
7684e57b
JB
77082011-03-14 Juanma Barranquero <lekktu@gmail.com>
7709
7710 * lisp.h (VWindow_system, Qfile_name_history):
7711 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7712 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7713 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7714
7715 * w32select.c: Don't #include "keyboard.h".
c96bbc66 7716 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
7717
7718 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7719 * w32console.c (detect_input_pending, read_input_pending)
7720 (encode_terminal_code):
7721 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7722 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7723 (w32_system_caret_y, Qfile_name_history):
7724 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7725 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7726 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7727 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7728 * w32proc.c (Qlocal, report_file_error):
7729 * w32term.c (Vwindow_system, updating_frame):
7730 * w32uniscribe.c (initialized, uniscribe_font_driver):
7731 Remove unneeded extern declarations.
7732
2aa46d6c
CY
77332011-03-14 Chong Yidong <cyd@stupidchicken.com>
7734
c96bbc66 7735 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 7736
cffc6f3b
CY
77372011-03-13 Chong Yidong <cyd@stupidchicken.com>
7738
7739 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7740 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7741 These macros can no longer be used for assignment.
7742
44f230aa
SM
7743 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7744 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
7745 (record_buffer_markers, fetch_buffer_markers): New functions for
7746 recording and fetching special buffer markers.
7747 (set_buffer_internal_1, set_buffer_temp): Use them.
7748
7749 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7750
7751 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7752
7753 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7754 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7755
7756 * xdisp.c (hscroll_window_tree):
7757 (reconsider_clip_changes): Use PT instead of BUF_PT.
7758
d251f04b
EZ
77592011-03-13 Eli Zaretskii <eliz@gnu.org>
7760
7761 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7762 $(EMACS_ROOT)/lib/intprops.h.
7763
f0c77cd1
PE
77642011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7765
3eca4629
PE
7766 Fix more problems found by GCC 4.5.2's static checks.
7767
7c86ee98
PE
7768 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7769 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
7770 (xg_free_frame_widgets): Make it clear that a local variable is
7771 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
7772 (gdk_window_get_screen): Make it clear that this macro is needed
7773 only if USE_GTK_TOOLTIP.
1e5524e7
PE
7774 (int_gtk_range_get_value): New function, which avoids a diagnostic
7775 from gcc -Wbad-function-cast.
7776 (xg_set_toolkit_scroll_bar_thumb): Use it.
7777 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7778 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
7779 (get_utf8_string, xg_get_file_with_chooser):
7780 Rename locals to avoid shadowing.
7781 (create_dialog): Move locals to avoid shadowing.
7c86ee98 7782
41729b81
PE
7783 * xgselect.c (xg_select): Remove unused var.
7784
f0c77cd1
PE
7785 * image.c (four_corners_best): Mark locals as initialized.
7786 (gif_load): Initialize transparent_p to zero (Bug#8238).
7787 Mark another local as initialized.
ec6cf4c6 7788 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 7789
ce0ad53d 7790 * image.c (clear_image_cache): Now static.
d5d5a617 7791 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 7792 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
7793 (x_edge_detection): Remove unnecessary cast that
7794 gcc -Wbad-function-cast diagnoses.
2037898d 7795 (gif_load): Fix pointer signedness.
6ae141d6
PE
7796 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7797 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 7798
33383987 77992011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 7800
d32df629
PE
7801 Improve quality of tests for time stamp overflow.
7802 For example, without this patch (encode-time 0 0 0 1 1
7803 1152921504606846976) returns the obviously-bogus value (-948597
7804 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7805 reports time overflow. See
7806 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
7807 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7808 * editfns.c: Include limits.h and intprops.h.
7809 (TIME_T_MIN, TIME_T_MAX): New macros.
7810 (time_overflow): Move earlier, to before first use.
7811 (hi_time, lo_time): New functions, for an accurate test for
7812 out-of-range times.
7813 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7814 (Fget_internal_run_time): Don't assume time_t fits in int.
7815 (make_time): Use list2 instead of Fcons twice.
7816 (Fdecode_time): More accurate test for out-of-range times.
7817 (check_tm_member): New function.
7818 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
7819 (lisp_time_argument): Don't rely on undefined left-shift and
7820 right-shift behavior when checking for time stamp overflow.
8be6f318 7821
fe31d94c
PE
7822 * editfns.c (time_overflow): New function, refactoring common code.
7823 (Fformat_time_string, Fdecode_time, Fencode_time):
7824 (Fcurrent_time_string): Use it.
7825
8be6f318
PE
7826 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7827 * dired.c (make_time): Move to ...
7828 * editfns.c (make_time): ... here.
7829 * systime.h: Note the move.
7830
09d9db2c 78312011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 7832
126bc0dc
YM
7833 * fringe.c (update_window_fringes): Remove unused variables.
7834
c47cbdfd
YM
7835 * unexmacosx.c (copy_data_segment): Also copy __got section.
7836 (Bug#8223)
7837
7ac80be9
EZ
78382011-03-12 Eli Zaretskii <eliz@gnu.org>
7839
c96bbc66 7840 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
7841 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7842 Constify `char *' arguments and their references according to
7843 prototypes in tparam.h.
7844
ecb0f94d 7845 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 7846
7ac80be9
EZ
7847 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7848 Adapt all references accordingly.
7849
7850 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7851
ef1fd07e
TT
78522011-03-11 Tom Tromey <tromey@redhat.com>
7853
7854 * buffer.c (syms_of_buffer): Remove obsolete comment.
7855
7ef4b50c
EZ
78562011-03-11 Eli Zaretskii <eliz@gnu.org>
7857
7858 * termhooks.h (encode_terminal_code): Declare prototype.
7859
7860 * msdos.c (encode_terminal_code): Don't declare prototype.
7861
7862 * term.c (encode_terminal_code): Now external again, used by
7863 w32console.c and msdos.c.
7864
44f230aa
SM
7865 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7866 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 7867
4b1ec863 78682011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 7869
1714f52b 7870 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 7871
4b1ec863
PE
7872 * fringe.c (update_window_fringes): Mark locals as initialized
7873 (Bug#8227).
7874 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 7875
524c7aa6
PE
7876 * alloc.c (mark_fringe_data): Move decl from here ...
7877 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7878 to check its interface.
7879 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7880
a5c0af81 7881 * fontset.c (free_realized_fontset): Now static.
7519b8cd 7882 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 7883 (fontset_font): Mark local as initialized.
a9a06e0b 7884 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 7885
b4716021
PE
7886 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7887
811e9bac 7888 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 7889 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
7890 (x_own_selection, Fx_disown_selection_internal): Rename locals
7891 to avoid shadowing.
7892 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 7893
7e3ab302
PE
7894 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7895 so that the caller can use some name other than gcpro1.
7896 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
7897 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7898 (Fx_backspace_delete_keys_p):
7899 Use them to avoid shadowing, and rename vars to avoid shadowing.
7900 (x_decode_color, x_set_name, x_window): Now static.
6b437900 7901 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 7902 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
7903 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7904 Remove unused locals.
7e3ab302
PE
7905 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7906 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7907 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7908 macros.
f78faa98 7909
e2b13473
PE
7910 * xterm.h (x_mouse_leave): New decl.
7911
77f23912
PE
7912 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7913 Remove unused functions.
cdf4ba58
PE
7914 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7915 (x_calc_absolute_position): Now static.
7411c686 7916 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 7917 Don't declare local "event" unless it's used.
ed7bf3a5
PE
7918 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7919 unless they are used.
38d0b34a
PE
7920 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7921 (x_fatal_error_signal): Remove; not used.
a6067996
PE
7922 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7923 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7924 (x_error_catcher, x_connection_closed, x_error_handler):
7925 (x_error_quitter, xembed_send_message, x_iconify_frame):
7926 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 7927 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 7928 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 7929
44f230aa
SM
7930 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7931 Rename or move locals to avoid shadowing.
6b463e58 7932 (tty_defined_color, merge_face_heights): Now static.
5967d051 7933 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
7934 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7935 does not deduce is never used uninitialized.
73719eba
PE
7936 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7937 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 7938
426994c3 7939 * terminal.c (store_terminal_param): Now static.
5489860b 7940
032f1620 7941 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 7942 (set_frame_menubar): Remove unused local.
d4323972 7943 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
7944 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7945 since they might point to immutable storage.
281585b0
PE
7946 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7947 since it's unused otherwise.
032f1620 7948
367c19e5 7949 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 7950 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
7951 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7952 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 7953 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
7954 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7955 does not deduce are never used uninitialized.
70739cbe 7956
07b48fa9
PE
7957 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7958
8868a238 7959 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
7960 * window.c (window_loop, size_window):
7961 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 7962
7e5cf297 7963 * window.c (display_buffer): Now static.
d6550a9f
PE
7964 (size_window): Mark variables that gcc -Wuninitialized
7965 does not deduce are never used uninitialized.
a586633d
PE
7966 * window.h (check_all_windows): New decl, to forestall
7967 gcc -Wmissing-prototypes diagnostic.
5b555da1 7968 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 7969
f6095868
PE
7970 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7971 shadowing.
7972 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
7973 Include <limits.h>.
7974 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7975 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
7976 (load_charset_map): Mark variables that gcc -Wuninitialized
7977 does not deduce are never used uninitialized.
53df7c11 7978 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 7979
f38b440c
PE
7980 * coding.c (coding_set_source, coding_set_destination):
7981 Use "else { /* comment */ }" rather than "else /* comment */;"
7982 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
7983 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7984 a block, when the outer 'i' will do.
7985 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7986 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7987 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7988 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7989 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7990 Rename locals to avoid shadowing.
7991 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
7992 * coding.c (emacs_mule_char, encode_invocation_designation):
7993 Now static, since they're not used elsewhere.
413bb2db 7994 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 7995 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
7996 (decode_coding_emacs_mule): Mark variables that gcc
7997 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
7998 (detect_coding_iso_2022): Initialize a local variable that might
7999 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 8000 this initialization is needed. (Bug#8211)
5f58e762
PE
8001 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8002 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8003 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8004 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8005 Remove unused macros.
f38b440c 8006
232b38b9 8007 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 8008 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 8009 * character.c (string_count_byte8): Likewise.
232b38b9 8010
fb90da1b
PE
8011 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8012 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8013
fb93dbc2
PE
8014 * chartab.c (copy_sub_char_table): Now static, since it's not used
8015 elsewhere.
5c156ace
PE
8016 (sub_char_table_ref_and_range, char_table_ref_and_range):
8017 Rename locals to avoid shadowing.
bbcd0949 8018 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 8019
7d3b3862 8020 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 8021 (BIDI_BOB): Remove unused macro.
7d3b3862 8022
6be7d3da
PE
8023 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8024 deduce are never used uninitialized.
c2ed9c8b 8025 * term.c (encode_terminal_code): Likewise.
6be7d3da 8026
75f8807f 8027 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 8028
50938595
PE
8029 * tparam.h: New file.
8030 * term.c, tparam.h: Include it.
8031 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8032 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8033 Move these decls to tparam.h, and make them agree with what
8034 is actually in tparam.c. The previous trick of using incompatible
8035 decls in different modules does not conform to the C standard.
8036 All callers of tparam changed to use tparam's actual API.
8037 * tparam.c (tparam1, tparam, tgoto):
8038 Use const pointers where appropriate.
8039
fbceeba2
PE
8040 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8041 * cm.h (struct cm): Likewise.
8042 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8043 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8044 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8045 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8046 (turn_on_face, init_tty): Likewise.
8047 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 8048
7f3f1250
PE
8049 * term.c (term_mouse_position): Rename local to avoid shadowing.
8050
e6ca6543
PE
8051 * alloc.c (mark_ttys): Move decl from here ...
8052 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8053
c40f8d15
AS
80542011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8055
8056 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8057
cfe0661d
JB
80582011-03-09 Juanma Barranquero <lekktu@gmail.com>
8059
8060 * search.c (compile_pattern_1): Remove argument regp, unused since
8061 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8062 (compile_pattern): Don't pass it.
8063
0afb4571
J
80642011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8065
8066 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8067 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8068 for ! HAVE_GTK3.
8069 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8070
8071 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8072
8073 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8074 gdk_window_get_screen, gdk_window_get_geometry,
8075 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8076 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8077 (xg_get_pixbuf_from_pixmap): New function.
8078 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8079 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8080 Call xg_get_pixbuf_from_pixmap instead of
8081 gdk_pixbuf_get_from_drawable.
8082 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8083 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8084 (xg_check_special_colors): Use GtkStyleContext and its functions
8085 for HAVE_GTK3.
8086 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8087 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8088 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
8089 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8090 Call gtk_widget_get_preferred_size.
0afb4571
J
8091 (xg_frame_resized): gdk_window_get_geometry only takes 5
8092 parameters.
44f230aa
SM
8093 (xg_win_to_widget, xg_event_is_for_menubar):
8094 Call gdk_x11_window_lookup_for_display.
0afb4571
J
8095 (xg_set_widget_bg): New function.
8096 (delete_cb): New function.
895009e1 8097 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
8098 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
8099 (xg_set_background_color): Call xg_set_widget_bg.
8100 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8101 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8102 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8103 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8104 if ! HAVE_GTK3.
8105 (update_frame_tool_bar): Call gtk_widget_hide.
8106 (xg_initialize): Use GDK_KEY_g.
8107
8108 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8109 if ! HAVE_GTK3
8110 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8111
8112 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8113 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8114 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8115
1c2cc4ef
JB
81162011-03-08 Juanma Barranquero <lekktu@gmail.com>
8117
8118 * w32xfns.c (select_palette): Check success of RealizePalette against
8119 GDI_ERROR, not zero.
8120
33383987 8121See ChangeLog.11 for earlier changes.
aac0c6e3
MR
8122
8123;; Local Variables:
8124;; coding: utf-8
aac0c6e3
MR
8125;; End:
8126
33383987 8127 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
8128
8129 This file is part of GNU Emacs.
8130
8131 GNU Emacs is free software: you can redistribute it and/or modify
8132 it under the terms of the GNU General Public License as published by
8133 the Free Software Foundation, either version 3 of the License, or
8134 (at your option) any later version.
8135
8136 GNU Emacs is distributed in the hope that it will be useful,
8137 but WITHOUT ANY WARRANTY; without even the implied warranty of
8138 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8139 GNU General Public License for more details.
8140
8141 You should have received a copy of the GNU General Public License
8142 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.