* fileio.c: Add FIXMES mentioning Bug#8496.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
5d4cb038
PE
12011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2
3 * sysdep.c (croak): Now static, if
4 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
6
7 * alloc.c (refill_memory_reserve): Now static if
8 !defined REL_ALLOC || defined SYSTEM_MALLOC.
9 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 10
e87b6180
PE
11 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
12 Define only if USE_LUCID.
13
ac64929e
PE
14 * xrdb.c (x_customization_string, x_rm_string): Now static.
15
6f37259d
PE
16 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
17 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
18
1683e3ab
PE
19 * xdisp.c (draw_row_with_mouse_face): Now static.
20 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
21
de9c2632
PE
22 * window.h (check_all_windows): Mark externally visible.
23
2b96acb7
PE
24 * window.c (window_deletion_count): Now static.
25
26 * undo.c: Make symbols static if they're not exported.
27 (last_undo_buffer, last_boundary_position, pending_boundary):
28 Now static.
29
50436f33
PE
30 * textprop.c (interval_insert_behind_hooks): Now static.
31 (interval_insert_in_front_hooks): Likewise.
32
64520e5c
PE
33 * term.c: Make symbols static if they're not exported.
34 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
35 (max_frame_lines, tty_set_terminal_modes):
36 (tty_reset_terminal_modes, tty_turn_off_highlight):
37 (get_tty_terminal): Now static.
38 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
39 * termhooks.h (term_mouse_moveto): Do not declare if
40 HAVE_WINDOW_SYSTEMM.
41 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
42 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
43
1fa53021
PE
44 * sysdep.c: Make symbols static if they're not exported.
45 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
46 Now static.
47 (sigprocmask_set, full_mask): Remove; unused.
48 (wait_debugging): Mark as visible.
49 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
50 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
51
d4b43b22
PE
52 * syntax.c (syntax_temp): Define only if !__GNUC__.
53
b7c513d0
PE
54 * sound.c (current_sound_device, current_sound): Now static.
55
989b29ad
PE
56 * search.c (searchbufs, searchbuf_head): Now static.
57
13a55a78
PE
58 * scroll.c (scroll_cost): Remove; unused.
59 * dispextern.h (scroll_cost): Remove decl.
60
de68a1fc
PE
61 * region-cache.h (pp_cache): Mark as externally visible.
62
40ccffa6
PE
63 * process.c: Make symbols static if they're not exported.
64 (process_tick, update_tick, create_process, chan_process):
65 (Vprocess_alist, proc_buffered_char, datagram_access):
66 (fd_callback_data, send_process_frame, process_sent_to): Now static.
67 (deactivate_process): Mark defn as static, as well as decl.
68 * lisp.h (create_process): Remove decl.
69 * process.h (chan_process, Vprocess_alist): Remove decls.
70
ad64fc97
PE
71 * print.c: Make symbols static if they're not exported.
72 (print_depth, new_backquote_output, being_printed, print_buffer):
73 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
74 (print_interval, print_number_index, initial_stderr_stream):
75 Now static.
76 * lisp.h (Fprinc): Remove decl.
77 (debug_output_compilation_hack): Mark as externally visible.
78
adddb265
PE
79 * sysdep.c (croak): Move decl from here to syssignal.h.
80 * syssignal.h (croak): Put it here, so the API can be checked when
81 'croak' is called from dissociate_if_controlling_tty.
82
1717ede2
PE
83 * minibuf.c: Make symbols static if they're not exported.
84 (minibuf_save_list, choose_minibuf_frame): Now static.
85 * lisp.h (choose_minibuf_frame): Remove decl.
86
fa5fb2bc
PE
87 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
88
1e3890d1
PE
89 * lread.c: Make symbols static if they're not exported.
90 (read_objects, initial_obarray, oblookup_last_bucket_number):
91 Now static.
92 (make_symbol): Remove; unused.
93 * lisp.h (initial_obarray, make_symbol): Remove decls.
94
8a1414fa
PE
95 * keyboard.c: Make symbols static if they're not exported.
96 (single_kboard, recent_keys_index, total_keys, recent_keys):
97 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
98 (this_single_command_key_start, echoing, last_auto_save):
99 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
100 (command_loop, echo_now, keyboard_init_hook, help_char_p):
101 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
102 (Vlispy_mouse_stem, double_click_count):
103 Now static.
104 (force_auto_save_soon): Define only if SIGDANGER.
105 (ignore_mouse_drag_p): Now static if
106 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
107 (print_help): Remove; unused.
108 (stop_character, last_timer_event): Mark as externally visible.
109 * keyboard.h (ignore_mouse_drag_p): Declare only if
110 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
111 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
112 * lisp.h (echoing): Remove decl.
113 (force_auto_save_soon): Declare only if SIGDANGER.
114 * xdisp.c (redisplay_window): Simplify code, to make it more
115 obvious that ignore_mouse_drag_p is not accessed if !defined
116 USE_GTK && !defined HAVE_NS.
117
93ea6e8f
PE
118 * intervals.c: Make symbols static if they're not exported.
119 (merge_properties_sticky, merge_interval_right, delete_interval):
120 Now static.
121 * intervals.h (merge_interval_right, delete_interval): Remove decls.
122
b532497d
PE
1232011-04-13 Paul Eggert <eggert@cs.ucla.edu>
124
77382fcc
PE
125 * insdel.c: Make symbols static if they're not exported.
126 However, leave prepare_to_modify_buffer alone. It's never
127 called from outside this function, but that appears to be a bug.
128 (combine_after_change_list, combine_after_change_buffer):
4889fc82 129 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
130 (adjust_after_replace_noundo): Remove; unused.
131 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 132 (signal_before_change): Remove decls.
77382fcc 133
9306c32e
PE
134 * indent.c (val_compute_motion, val_vmotion): Now static.
135
cd44d2eb
PE
136 * image.c: Make symbols static if they're not exported.
137 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
138 if USE_GTK.
139 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
140 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
141
ad9a7a06
PE
142 * fringe.c (standard_bitmaps): Now static.
143 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
144
81626931
PE
145 * frame.c: Make symbols static if they're not exported.
146 (x_report_frame_params, make_terminal_frame): Now static.
147 (get_frame_param): Now static, unless HAVE_NS.
148 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
149 (x_get_resource_string): Remove; not used.
150 * frame.h (make_terminal_frame, x_report_frame_params):
151 (x_get_resource_string); Remove decls.
152 (x_fullscreen_adjust): Declare only if WINDOWSNT.
153 * lisp.h (get_frame_param): Declare only if HAVE_NS.
154
239f9db9
PE
155 * font.c, fontset.c: Make symbols static if they're not exported.
156 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
157 (FACE_SUITABLE_FOR_CHAR_P): Use it.
158 * font.c (font_close_object): Now static.
159 * font.h (font_close_object): Remove.
160 * fontset.c (FONTSET_OBJLIST): Remove.
161 (free_realized_fontset) #if-0 the body, which does nothing.
162 (face_suitable_for_char_p): #if-0, as it's never called.
163 * fontset.h (face_suitable_for_char_p): Remove decl.
164 * xfaces.c (face_at_string_position): Use
165 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
166 since 0 is always ASCII.
167
dfcf3579
PE
168 * fns.c (weak_hash_tables): Now static.
169
5045092b
PE
170 * fileio.c: Make symbols static if they're not exported.
171 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
172 (Vwrite_region_annotation_buffers): Now static.
173
57a96f5c
PE
174 * eval.c: Make symbols static if they're not exported.
175 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
176 * lisp.h (backtrace_list): Remove decl.
177
35f08c38
PE
178 * emacs.c: Make symbols static if they're not exported.
179 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
180 (fatal_error_code, fatal_error_signal_hook, standard_args):
181 Now static.
182 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
183 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
184 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
185 * lisp.h (fatal_error_signal_hook): Remove decl.
186 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
187
f44bd759
PE
188 * editfns.c: Move a (normally-unused) function to its only use.
189 * editfns.c, lisp.h (get_operating_system_release): Remove.
190 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
191 worth the hassle of breaking this out.
192
b532497d
PE
193 * xterm.c: Make symbols static if they're not exported.
194 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
195 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
196 (x_destroy_window, x_delete_display):
197 Now static.
198 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
199 (x_mouse_leave): Remove; unused.
200 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
201 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
202 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
203 Remove decls.
204 (x_mouse_leave): Declare only if WINDOWSNT.
205 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
206 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
207 USE_X_TOOLKIT.
208
a25f4dfa
PE
2092011-04-12 Paul Eggert <eggert@cs.ucla.edu>
210
1675728f
PE
211 * ftxfont.c: Make symbols static if they're not exported.
212 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
213 HAVE_FREETYPE.
214 * font.h (ftxfont_driver): Likewise.
215
e4cebfca
PE
216 * xfns.c: Make symbols static if they're not exported.
217 (x_last_font_name, x_display_info_for_name):
218 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
219 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
220 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
221 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
222 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
223 (last_show_tip_args): Now static.
224 (xic_defaut_fontset, xic_create_fontsetname): Define only if
225 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
226 (x_screen_planes): Remove; unused.
227 * dispextern.h (x_screen_planes): Remove decl.
228
5bf46f05
PE
229 * dispnew.c: Make symbols static if they're not exported.
230 * dispextern.h (redraw_garbaged_frames, scrolling):
231 (increment_row_positions): Remove.
232 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
233 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
234 Now static.
235 (redraw_garbaged_frames): Remove; unused.
236
435f4c28
PE
237 * xfaces.c: Make symbols static if they're not exported.
238 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
239 Remove decls.
240 * xterm.h (defined_color): Remove decls.
241 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
242 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
243 (menu_face_changed_default, defined_color, free_realized_face):
244 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
245 (ascii_face_of_lisp_face): Remove; unused.
246
8524aef3
PE
247 * xdisp.c: Make symbols static if they're not exported.
248 * dispextern.h (scratch_glyph_row, window_box_edges):
249 (glyph_to_pixel_coords, set_cursor_from_row):
250 (get_next_display_element, set_iterator_to_next):
251 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
252 (show_mouse_face): Remove decls
253 * frame.h (message_buf_print): Likewise.
254 * lisp.h (pop_message, set_message, check_point_in_composition):
255 Likewise.
256 * xterm.h (set_vertical_scroll_bar): Likewise.
257 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
258 (message_buf_print, scratch_glyph_row, displayed_buffer):
259 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
260 (get_next_display_element, show_mouse_face, window_box_edges):
261 (frame_to_window_pixel_xy, check_point_in_composition):
262 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
263 (glyph_to_pixel_coords): Remove; unused.
264
16390cd2
PE
265 * dired.c (file_name_completion): Now static.
266
267 * dbusbind.c (xd_in_read_queued_messages): Now static.
268
a25f4dfa
PE
269 * lisp.h (circular_list_error, FOREACH): Remove; unused.
270 * data.c (circular_list_error): Remove.
271
16a97296
PE
2722011-04-11 Paul Eggert <eggert@cs.ucla.edu>
273
14a9c8df
PE
274 * commands.h (last_point_position, last_point_position_buffer):
275 (last_point_position_window): Remove decls.
276 * keyboard.c: Make these variables static.
277
74ab6df5
PE
278 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
279 decls.
280 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
281 (iso_code_class, detect_coding, code_convert_region): Now static.
282 (encode_coding_gap): Remove; unused.
283
38dfbee1
PE
284 * chartab.c (chartab_chars, chartab_bits): Now static.
285
a2cb4e63
PE
286 * charset.h (charset_iso_8859_1): Remove decl.
287 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
288 Now static.
289
127198fd
PE
290 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
291 * ccl.c (Vccl_program_table): Now static.
292 (check_ccl_update): Remove; unused.
293
d85b608f
PE
294 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
295 * category.h: ... from here.
296 * category.c (check_category_table, set_category_set): Now static.
297
31cd66f3
PE
298 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
299 * lisp.h: Remove these decls.
300
c358e587
PE
301 * buffer.c (buffer_count): Remove unused var.
302
e78aecca
PE
303 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
304 so that it's not optimized away.
305 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
306 * dispextern.h (bidi_dump_cached_states): Remove, since it's
307 exported only to the debugger.
308
e192d7d3
PE
309 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
310 * atimer.h (run_all_atimers): Removed; not exported.
311
92470028
PE
312 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
313 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
314 was inaccessible from Lisp.
315 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
316 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
317
244ed907
PE
318 alloc.c: Import and export fewer symbols, and remove unused items.
319 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
320 is defined.
321 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
322 it's not optimized away by whole-program optimization.
323 (message_enable_multibyte, free_misc): Remove.
324 (catchlist, handlerlist, mark_backtrace):
325 Declare only if BYTE_MARK_STACK.
326 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
327 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
328 (message_enable_multibyte): Remove decl.
329 (free_misc, interval_free_list, float_block, float_block_index):
330 (n_float_blocks, float_free_list, cons_block, cons_block_index):
331 (cons_free_list, last_marked_index):
332 Now static.
333 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
334 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
335 (mark_backtrace): Define only if BYTE_MARK_STACK.
336 * xdisp.c (message_enable_multibyte): Now static.
337
955cbe7b
PE
338 Declare Lisp_Object Q* variables to be 'static' if not exproted.
339 This makes it easier for human readers (and static analyzers)
340 to see whether these variables are used from other modules.
341 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
342 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
343 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
344 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
345 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
346 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
347 * xmenu.c, xselect.c:
348 Declare Q* vars static if they are not used in other modules.
349 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
350 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
351 Remove decls of unexported vars.
352 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
353
95c82688
PE
354 * lisp.h (DEFINE_FUNC): Make sname 'static'.
355
16a97296
PE
356 Make Emacs functions such as Fatom 'static' by default.
357 This makes it easier for human readers (and static analyzers)
358 to see whether these functions can be called from other modules.
359 DEFUN now defines a static function. To make the function external
360 so that it can be used in other C modules, use the new macro DEFUE.
361 * lisp.h (DEFINE_FUNC): New macro, with the old contents of DEFUN.
362 (DEFUN): Rewrite in terms of DEFINE_FUNC. It now generates a
363 static function definition. Use DEFUE if you want an extern one.
364 (DEFUE, INFUN): New macros.
365 (Funibyte_char_to_multibyte, Fsyntax_table_p, Finit_image_library):
366 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
367 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
368 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
369 Remove decls, since these functions are now static.
370 (Funintern, Fget_internal_run_time): New decls, since these functions
371 were already external.
95c82688 372
16a97296
PE
373 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
374 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
375 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
376 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
377 * keyboard.c, keymap.c, lread.c:
378 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
379 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
380 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
381 Mark functions with DEFUE instead of DEFUN,
382 if they are used in other modules.
383 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
384 decls for now-static functions.
385 * buffer.h (Fdelete_overlay): Remove decl.
386 * callproc.c (Fgetenv_internal): Mark as internal.
387 * composite.c (Fremove_list_of_text_properties): Remove decl.
388 (Fcomposition_get_gstring): New forward static decl.
389 * composite.h (Fcomposite_get_gstring): Remove decl.
390 * dired.c (Ffile_attributes): New forward static decl.
391 * doc.c (Fdocumntation_property): New forward static decl.
392 * eval.c (Ffetch_bytecode): New forward static decl.
393 (Funintern): Remove extern decl; now in .h file where it belongs.
394 * fileio.c (Fmake_symbolic_link): New forward static decl.
395 * image.c (Finit_image_library): New forward static decl.
396 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
397 * intervals.h (Fprevious_property_change):
398 (Fremove_list_of_text_properties): Remove decls.
399 * keyboard.c (Fthis_command_keys): Remove decl.
400 (Fcommand_execute): New forward static decl.
401 * keymap.c (Flookup_key): New forward static decl.
402 (Fcopy_keymap): Now static.
403 * keymap.h (Flookup_key): Remove decl.
404 * process.c (Fget_process): New forward static decl.
405 (Fprocess_datagram_address): Mark as internal.
406 * syntax.c (Fsyntax_table_p): New forward static decl.
407 (skip_chars): Remove duplicate decl.
408 * textprop.c (Fprevious_property_change): New forward static decl.
409 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
410 Now internal.
411 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
412 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
413
785bbd42
PE
4142011-04-10 Paul Eggert <eggert@cs.ucla.edu>
415
416 * editfns.c (Fformat): Remove unreachable code.
417
4073e537 4182011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 419
b2ded58d
PE
420 Fix more problems found by GCC 4.6.0's static checks.
421
7d66342c
PE
422 * xdisp.c (vmessage): Use a better test for character truncation.
423
bbf47d44
PE
424 * charset.c (load_charset_map): <, not <=, for optimization,
425 and to avoid potential problems with integer overflow.
9248994d 426 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 427 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 428 * editfns.c (Fformat): Likewise.
1e69125e 429 * syntax.c (skip_chars): Likewise.
3befa583 430
e3019616
PE
431 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
432 This also lets GCC 4.6.0 generate slightly better loop code.
433
becfa255
PE
434 * callint.c (Fcall_interactively): <, not <=, for optimization.
435 (Fcall_interactively): Count the number of arguments produced,
436 not the number of arguments given. This is simpler and lets GCC
437 4.6.0 generate slightly better code.
438
dae0cd48
PE
439 * ftfont.c: Distingish more carefully between FcChar8 and char.
440 The previous code passed unsigned char * to a functions like
441 strlen and xstrcasecmp that expect char *, which does not
442 conform to the C standard.
443 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
444 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
445 char * when the C standard requires it.
446
76032d70
PE
447 * keyboard.c (read_char): Remove unused var.
448
eb3f1cc8
PE
449 * eval.c: Port to Windows vsnprintf (Bug#8435).
450 Include <limits.h>.
451 (SIZE_MAX): Define if the headers do not.
452 (verror): Do not give up if vsnprintf returns a negative count.
453 Instead, grow the buffer. This ports to Windows vsnprintf, which
454 does not conform to C99. Problem reported by Eli Zaretskii.
455 Also, simplify the allocation scheme, by avoiding the need for
456 calling realloc, and removing the ALLOCATED variable.
457
70476b54
PE
458 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
459
12020a9e
PE
460 Remove invocations of doprnt, as Emacs now uses vsnprintf.
461 But keep the doprint source code for now, as we might revamp it
462 and use it again (Bug#8435).
ea6c7ae6
PE
463 * lisp.h (doprnt): Remove.
464 * Makefile.in (base_obj): Remove doprnt.o.
465 * deps.mk (doprnt.o): Remove.
466
5fdb398c
PE
467 error: Print 32- and 64-bit integers portably (Bug#8435).
468 Without this change, on typical 64-bit hosts error ("...%d...", N)
469 was used to print both 32- and 64-bit integers N, which relied on
470 undefined behavior.
471 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
472 New macro.
473 * lisp.h (error, verror): Mark as printf-like functions.
474 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
475 Report overflow in size calculations when allocating printf buffer.
476 Do not truncate output string at its first null byte.
477 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
478 Truncate the output at a character boundary, since vsnprintf does not
479 do that.
480 * charset.c (check_iso_charset_parameter): Convert internal
481 character to string before calling 'error', since %c now has the
482 printf meaning.
483 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
484 overflow when computing char to be passed to 'error'. Do not
485 pass Lisp_Object to 'error'; pass the integer instead.
486 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
487 formatted with plain %d.
488
b189fa66
PE
489 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
490
bff87ef0
PE
491 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
492
7e2cac20
PE
493 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
494
ce4d90b5
PE
495 * xterm.c (x_catch_errors): Remove duplicate declaration.
496
266c9547
PE
497 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
498
79c49ad2
PE
499 * xdisp.c, lisp.h (message_nolog): Remove; unused.
500
368f4090
JM
5012011-04-10 Jim Meyering <meyering@redhat.com>
502
503 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
504 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
505 return ssize_t not "int", and use size_t as the buffer length.
506 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
507 * gnutls.h: Update declarations.
508 * process.c (read_process_output): Use ssize_t, to match.
509 (send_process): Likewise.
510
a32d4040
CY
5112011-04-09 Chong Yidong <cyd@stupidchicken.com>
512
513 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
514
8546720e 5152011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 516
8546720e
GM
517 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
518 unsigned char, to match FcChar8 type definition.
aac0c6e3 519
8546720e
GM
520 * xterm.c (handle_one_xevent):
521 * xmenu.c (create_and_show_popup_menu):
522 * xselect.c (x_decline_selection_request)
523 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 524
a53e2e89
EZ
5252011-04-09 Eli Zaretskii <eliz@emacstest.gnu.org>
526
527 Fix some uses of `int' instead of EMACS_INT.
528 * search.c (string_match_1, fast_string_match)
529 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
530 (scan_buffer, find_next_newline_no_quit)
531 (find_before_next_newline, search_command, Freplace_match)
532 (Fmatch_data): Make some `int' variables be EMACS_INT.
533
534 * xdisp.c (display_count_lines): 3rd argument and return value now
535 EMACS_INT. All callers changed.
536 (pint2hrstr): Last argument is now EMACS_INT.
537
538 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
539 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
540 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
541 (decode_coding_utf_16, decode_coding_emacs_mule)
542 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
543 (decode_coding_ccl, decode_coding_charset)
544 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
545 (decode_coding_iso_2022, decode_coding_emacs_mule)
546 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
547 <char_offset, last_offset>: Declare EMACS_INT.
548 (encode_coding_utf_8, encode_coding_utf_16)
549 (encode_coding_emacs_mule, encode_invocation_designation)
550 (encode_designation_at_bol, encode_coding_iso_2022)
551 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
552 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
553 Declare EMACS_INT.
554 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
555 (encode_invocation_designation): Last argument P_NCHARS is now
556 EMACS_INT.
557 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
558 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
559
560 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
561 All users changed.
562
563 * ccl.c (Fccl_execute_on_string): Declare some variables
564 EMACS_INT.
565
8546720e 5662011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
567
568 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
569
4e19a977
CS
5702011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
571
572 * process.c (Fformat_network_address): Doc fix.
573
87302331
R
5742011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
575
576 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
577
cbb59342
CY
5782011-04-08 Chong Yidong <cyd@stupidchicken.com>
579
580 * keyboard.c (read_char): Call Lisp function help-form-show,
581 instead of using internal_with_output_to_temp_buffer.
582 (Qhelp_form_show): New var.
e0d38eeb 583 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
584
585 * print.c (internal_with_output_to_temp_buffer): Function deleted.
586
587 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
588
e67a13ab
CY
5892011-04-06 Chong Yidong <cyd@stupidchicken.com>
590
591 * process.c (Flist_processes): Removed to Lisp.
592 (list_processes_1): Deleted.
593
973f782d
EZ
5942011-04-06 Eli Zaretskii <eliz@gnu.org>
595
7c106b1e
EZ
596 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
597
973f782d
EZ
598 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
599
41cf7d1a 6002011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 601
ca23cc88
PE
602 Fix more problems found by GCC 4.6.0's static checks.
603
f390e2d5
PE
604 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
605
42eea0d0
PE
606 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
607
b69769da 608 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 609
f9541e84
PE
610 * xdisp.c (vmessage): Mark as a printf-like function.
611
13841b55
PE
612 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
613
c136c10f
PE
614 * sound.c (sound_warning): Don't crash if arg contains a printf format.
615
5e2d4a30
PE
616 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
617 printf-like functions.
618 (tiff_load): Add casts to remove these marks before passing them
619 to system-supplied API.
620
583f48b9
PE
621 * eval.c (Fsignal): Remove excess argument to 'fatal'.
622
b25d760e
PE
623 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
624 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
625 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
626 directly, rather than having caller test rule sign. This avoids
627 some unnecessary tests.
628 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
629 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
630 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 631
bc7b6697 632 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 633 (xfont_open): Avoid unnecessary tests.
bc7b6697 634
27ccc379
PE
635 * composite.c (composition_gstring_put_cache): Use unsigned integer.
636
dcd5c89a
PE
637 * composite.h, composite.c (composition_gstring_put_cache):
638 Use EMACS_INT, not int, for length.
639
b13a45c6
PE
640 * composite.h (COMPOSITION_DECODE_REFS): New macro,
641 breaking out part of COMPOSITION_DECODE_RULE.
642 (COMPOSITION_DECODE_RULE): Use it.
643 * composite.c (get_composition_id): Remove unused local vars,
644 by using the new macro.
645
1e792e4d
PE
646 * textprop.c (set_text_properties_1): Change while to do-while,
647 since the condition is always true at first.
648
dc6c6455 649 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
650 (interval_deletion_adjustment): Return unsigned value.
651 All uses changed.
dc6c6455 652
aba7731a
PE
653 * process.c (list_processes_1, create_pty, read_process_output):
654 (exec_sentinel): Remove vars that were set but not used.
afd4052b 655 (create_pty): Remove unnecessary "volatile"s.
bc57d757 656 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 657 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 658 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 659
fdfc4bf3
PE
660 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
661
fca8fe46 662 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 663 (update_syntax_table): Use unsigned instead of int.
fca8fe46 664
06a0259a 665 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 666 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 667 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 668
e7b9e80f
PE
669 * print.c (print_error_message): Avoid int overflow.
670
56201685
PE
671 * font.c (font_list_entities): Redo for clarity,
672 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
673
78834453 674 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 675 (font_score): Avoid potential overflow in diff calculation.
78834453 676
0bc0b309 677 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 678 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 679
e610eaca
PE
680 * eval.c (funcall_lambda): Rename local to avoid shadowing.
681
b895abce
PE
682 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
683 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
684 can always succeed if overflow has undefined behavior.
685
1f1d9321 686 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 687 (wordify): Omit three unnecessary tests.
1f1d9321 688
c59478bc
PE
689 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
690 All callers changed. This avoids the need for an unused var.
691
79b73827
PE
692 * casefiddle.c (casify_region): Remove var that is set but not used.
693
a4db5dfe
PE
694 * dired.c (file_name_completion): Remove var that is set but not used.
695
43aae36e
PE
696 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
697
2a47c44d 698 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 699 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 700
a37c69bf
PE
701 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
702 Check for integer overflow on size calculations.
703
328ab8e7
PE
704 * buffer.c (Fprevious_overlay_change): Remove var that is set
705 but not used.
706
e5a2a5cb
PE
707 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
708 Remove vars that are set but not used.
8d84a6eb 709 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 710 (timer_check_2): Mark vars as initialized.
e5a2a5cb 711
a60e5f68
PE
712 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
713
f661cb61 714 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 715 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 716
f0397f5a
PE
717 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
718 that are set but not used.
719
8664db06 720 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 721 if XCreateBitmapFromData fails (Bug#8410).
8664db06 722
6abdaa4a
PE
723 * xselect.c (x_get_local_selection, x_handle_property_notify):
724 Remove vars that are set but not used.
725
0ce7538d 726 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 727 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 728
9ae848fc
PE
729 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
730 Remove var that is set but not used.
0b918413
PE
731 (scroll_bar_windows_size): Now size_t, not int.
732 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
733 Check for overflow.
9ae848fc 734
a5a62657
PE
735 * xfaces.c (realize_named_face): Remove vars that are set but not used.
736 (map_tty_color) [!defined MSDOS]: Likewise.
737
5c5cdd39
PE
738 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
739
66ebf983
PE
740 * coding.c: Remove vars that are set but not used.
741 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
742 All callers changed.
743 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
744 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
745 (decode_coding_charset): Remove vars that are set but not used.
746
1be4d761
PE
747 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
748 that is set but not used.
749
47553fa8
PE
750 * print.c (print_object): Remove var that is set but not used.
751
1f7196bf 752 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
753 The gnulib version avoids calling malloc in the usual case,
754 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
755 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
756 * filelock.c (current_lock_owner): Likewise.
757 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
758 * sysdep.c: Include allocator.h, careadlinkat.h.
759 (emacs_no_realloc_allocator): New static constant.
760 (emacs_readlink): New function.
fdb61804
PE
761 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
762 ../lib/careadlinkat.h.
d1fdcab7 763
f84c17c7
SM
7642011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
765
766 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
767 first non-nil return value).
768
ef3862ad
JD
7692011-04-03 Jan Djärv <jan.h.d@swipnet.se>
770
771 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
772 if not defined (Bug#8403).
773
376a7006
JB
7742011-04-02 Juanma Barranquero <lekktu@gmail.com>
775
776 * xdisp.c (display_count_lines): Remove parameter `start',
777 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
778 (get_char_face_and_encoding): Remove parameter `multibyte_p',
779 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
780 (fill_stretch_glyph_string): Remove parameters `row' and `area',
781 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
782 and thereabouts. All callers changed.
783 (get_per_char_metric): Remove parameter `f', unused since
784 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
785
6ca3801d
JM
7862011-04-02 Jim Meyering <meyering@redhat.com>
787
788 do not dereference NULL upon failed strdup
789 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
790 (ns_get_family): Likewise.
791
d8e2b5ba
JB
7922011-04-02 Juanma Barranquero <lekktu@gmail.com>
793
794 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
795
8c74fcbd
JD
7962011-04-02 Jan Djärv <jan.h.d@swipnet.se>
797
798 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
799 later (Bug#8403).
800
7200d79c
SM
8012011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
802
03408648 803 Add lexical binding.
7200d79c 804
03408648
SM
805 * window.c (Ftemp_output_buffer_show): New fun.
806 (Fsave_window_excursion):
807 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
808
809 * lread.c (lisp_file_lexically_bound_p): New function.
810 (Fload): Bind Qlexical_binding.
811 (readevalloop): Remove `evalfun' arg.
812 Bind Qinternal_interpreter_environment.
813 (Feval_buffer): Bind Qlexical_binding.
814 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
815 Mark as dynamic.
816 (syms_of_lread): Declare `lexical-binding'.
817
818 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
819
820 * keyboard.c (eval_dyn): New fun.
821 (menu_item_eval_property): Use it.
ca105506
SM
822
823 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 824
03408648
SM
825 * fns.c (concat, mapcar1): Accept byte-code-functions.
826
827 * eval.c (Fsetq): Handle lexical vars.
828 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
829 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
830 (FletX, Flet): Obey lexical binding.
831 (Fcommandp): Handle closures.
832 (Feval): New `lexical' arg.
833 (eval_sub): New function extracted from Feval. Use it almost
834 everywhere where Feval was used. Look up vars in lexical env.
835 Handle closures.
836 (Ffunctionp): Move from subr.el.
837 (Ffuncall): Handle closures.
838 (apply_lambda): Remove `eval_flags'.
839 (funcall_lambda): Handle closures and new byte-code-functions.
840 (Fspecial_variable_p): New function.
841 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
842 but without exporting it to Lisp.
23aba0ea 843
23aba0ea 844 * doc.c (Fdocumentation, store_function_docstring):
03408648 845 * data.c (Finteractive_form): Handle closures.
23aba0ea 846
03408648
SM
847 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
848 interactive spec.
ba83908c 849
03408648
SM
850 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
851 byte-codes.
852 (exec_byte_code): New function extracted from Fbyte_code to handle new
853 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 854
03408648 855 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 856
03408648 857 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 858
e2abce01
JB
8592011-03-31 Juanma Barranquero <lekktu@gmail.com>
860
861 * xdisp.c (redisplay_internal): Fix prototype.
862
63696a73 8632011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 864
63696a73
EZ
865 * xdisp.c (SCROLL_LIMIT): New macro.
866 (try_scrolling): Use it when setting scroll_limit. Limit
867 scrolling to 100 screen lines.
868 (redisplay_window): Even when falling back on "recentering",
869 position point in the window according to scroll-conservatively,
870 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
871
872 (try_scrolling): When point is above the window, allow searching
873 as far as scroll_max, or one screenful, to compute vertical
874 distance from PT to the scroll margin position. This prevents
875 try_scrolling from unnecessarily failing when
876 scroll-conservatively is set to a value slightly larger than the
877 window height. Clean up the case of PT below the margin at bottom
878 of window: scroll_max can no longer be INT_MAX. When aggressive
879 scrolling is in use, don't let point enter the opposite scroll
880 margin as result of the scroll.
881 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
882 threshold of 100 lines for never-recentering scrolling.
883
e4cc2dfc
JB
8842011-03-31 Juanma Barranquero <lekktu@gmail.com>
885
886 * dispextern.h (move_it_by_lines):
887 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
888 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
889 (message_log_check_duplicate): Remove parameters `prev_bol' and
890 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
891 (redisplay_internal): Remove parameter `preserve_echo_area',
892 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
893
894 * indent.c (Fvertical_motion):
895 * window.c (window_scroll_pixel_based, Frecenter):
896 Don't pass `need_y_p' to `move_it_by_lines'.
897
1c470562
SM
8982011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
899
44f230aa
SM
900 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
901 steal a few bits to be more compact.
902 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
903 Remove unneeded casts.
904
1c470562
SM
905 * bytecode.c (Fbyte_code): CAR and CDR can GC.
906
888adce9
ZK
9072011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
908
909 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
910 binding" message (bug#7967).
911
f838ed7b
PE
9122011-03-30 Paul Eggert <eggert@cs.ucla.edu>
913
77861b95
PE
914 Fix more problems found by GCC 4.6.0's static checks.
915
de6dbc14
PE
916 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
917 Remove unused local var.
918
f838ed7b
PE
919 * editfns.c (Fmessage_box): Remove unused local var.
920
792c7b2b
PE
921 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
922 (note_mode_line_or_margin_highlight, note_mouse_highlight):
923 Omit unused local vars.
c499e557 924 * window.c (shrink_windows): Omit unused local var.
b01a1c29 925 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
926 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
927 Omit unused local var.
928
ba0165e1
PE
929 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
930 Don't assume string length fits in int.
32ad8845 931 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 932 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 933
3c59b4c9
PE
934 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
935 instead of alloca (Bug#8344).
936
a3eed478 937 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 938 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 939
eb4d412d
PE
940 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
941
1658b401
PE
942 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
943 concerns.
944
945 * term.c (produce_glyphless_glyph): Remove unnecessary test.
946
947 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 948
9a2c6e05
PE
949 * keyboard.c (syms_of_keyboard): Use the same style as later
950 in this function when indexing through an array. This also
951 works around GCC bug 48267.
952
03d0a109
PE
953 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
954
44f730c8
PE
955 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
956
fe75f926
PE
957 * chartab.c (sub_char_table_ref_and_range): Redo for slight
958 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
959
ffa8c828
PE
960 * keyboard.c, keyboard.h (num_input_events): Now size_t.
961 This avoids undefined behavior on integer overflow, and is a bit
962 more convenient anyway since it is compared to a size_t variable.
963
c5101a77
PE
964 Variadic C functions now count arguments with size_t, not int.
965 This avoids an unnecessary limitation on 64-bit machines, which
966 caused (substring ...) to crash on large vectors (Bug#8344).
967 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
968 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 969 All variadic functions and their callers changed accordingly.
c5101a77
PE
970 (struct gcpro.nvars): Now size_t, not int. All uses changed.
971 * data.c (arith_driver, float_arith_driver): Likewise.
972 * editfns.c (general_insert_function): Likewise.
973 * eval.c (struct backtrace.nargs, interactive_p)
974 (internal_condition_case_n, run_hook_with_args, apply_lambda)
975 (funcall_lambda, mark_backtrace): Likewise.
976 * fns.c (concat): Likewise.
977 * frame.c (x_set_frame_parameters): Likewise.
978 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
979 0 if not found, not -1. All callers changed.
980
dd3f25f7
PE
981 * alloc.c (garbage_collect): Don't assume stack size fits in int.
982 (stack_copy_size): Now size_t, not int.
983 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
984
461c2ab9
JB
9852011-03-28 Juanma Barranquero <lekktu@gmail.com>
986
987 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
988 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
989 All callers changed.
990
991 * lisp.h (multibyte_char_to_unibyte):
992 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
993 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
994 * character.h (CHAR_TO_BYTE8):
995 * cmds.c (internal_self_insert):
996 * editfns.c (general_insert_function):
997 * keymap.c (push_key_description):
998 * search.c (Freplace_match):
999 * xdisp.c (message_dolog, set_message_1): All callers changed.
1000
f6d62986
SM
10012011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1002
1003 * keyboard.c (safe_run_hook_funcall): New function.
1004 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
1005 don't set the hook to nil, but remove the offending function instead.
1006 (Qcommand_hook_internal): Remove, unused.
1007 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
1008 Vcommand_hook_internal.
1009
1010 * eval.c (enum run_hooks_condition): Remove.
1011 (funcall_nil, funcall_not): New functions.
1012 (run_hook_with_args): Call each function through a `funcall' argument.
1013 Remove `cond' argument, now redundant.
1014 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
1015 (Frun_hook_with_args_until_failure): Adjust accordingly.
1016 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
1017
1db5b1ad
JB
10182011-03-28 Juanma Barranquero <lekktu@gmail.com>
1019
1020 * dispextern.h (string_buffer_position): Remove declaration.
1021
1022 * print.c (strout): Remove parameter `multibyte', unused since
1023 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
1024
1025 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
1026 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
1027 All callers changed.
1028
1029 * w32.c (_wsa_errlist): Use braces for struct initializers.
1030
1031 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
1032 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
1033 All callers changed.
1034 (string_buffer_position): Likewise. Also, make static (it's never
1035 used outside xdisp.c).
1036 (cursor_row_p): Remove parameter `w', unused since
1037 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
1038 (decode_mode_spec): Remove parameter `precision', introduced during
1039 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
1040 All callers changed.
1041
5ffb62aa
JD
10422011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1043
1044 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
1045
461c2ab9 10462011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
1047
1048 * nsterm.m (ns_menu_bar_is_hidden): New variable.
1049 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
1050 (ns_update_auto_hide_menu_bar): New functions.
1051 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
1052 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
1053 ns_constrain_all_frames.
1054 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
1055 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
1056
5c380ffb
JD
10572011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1058
1059 * nsmenu.m (runDialogAt): Remove argument to timer_check.
1060
9af30bdf
GM
10612011-03-27 Glenn Morris <rgm@gnu.org>
1062
1063 * syssignal.h: Replace RETSIGTYPE with void.
1064 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
1065 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
1066 Replace SIGTYPE with void everywhere.
1067 * s/usg5-4-common.h (SIGTYPE): Remove definition.
1068 * s/template.h (SIGTYPE): Remove commented out definition.
1069
e2abce01
JB
10702011-03-26 Eli Zaretskii <eliz@gnu.org>
1071
1072 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
1073 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
1074
f868cd8a
JB
10752011-03-26 Juanma Barranquero <lekktu@gmail.com>
1076
59eb0929
JB
1077 * w32.c (read_unc_volume): Use parameter `henum', instead of
1078 global variable `wget_enum_handle'.
1079
1080 * keymap.c (describe_vector): Remove parameters `indices' and
1081 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
1082 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
1083
f868cd8a
JB
1084 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
1085
1086 * keyboard.c (timer_check): Remove parameter `do_it_now',
1087 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
1088 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
1089 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
1090
1091 * keyboard.c (read_char):
1092 * w32menu.c (w32_menu_display_help):
1093 * xmenu.c (show_help_event, menu_help_callback):
1094 Adjust calls to `show_help_echo'.
1095
1096 * gtkutil.c (xg_maybe_add_timer):
1097 * keyboard.c (readable_events):
1098 * process.c (wait_reading_process_output):
1099 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
1100
1101 * insdel.c (adjust_markers_gap_motion):
1102 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
1103 (gap_left, gap_right): Don't call it.
1104
2ecf6fdb
CY
11052011-03-25 Chong Yidong <cyd@stupidchicken.com>
1106
1107 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
1108 incurred during fontification.
1109
6b1f9ba4
JB
11102011-03-25 Juanma Barranquero <lekktu@gmail.com>
1111
1112 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
1113 (DEFVAR_PER_BUFFER): Don't pass it.
1114
1115 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
1116 (scrolling_window): Don't pass it.
1117
0f4a96b5
JB
11182011-03-25 Juanma Barranquero <lekktu@gmail.com>
1119
1120 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
1121
1122 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
1123 and `suffix'.
1124 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
1125 of variables specific to SELinux and computation of `encoded_absname'.
1126
1127 * image.c (XPutPixel): Remove unused variable `height'.
1128
1129 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
1130
1131 * unexw32.c (get_section_info): Remove unused variable `section'.
1132
1133 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
1134 (system_process_attributes): Remove unused variable `sess'.
1135 (sys_read): Remove unused variable `err'.
1136
1137 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
1138 (w32_wnd_proc): Remove unused variable `isdead'.
1139 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
1140 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
1141 (x_create_tip_frame): Remove unused variable `tem'.
1142
1143 * w32inevt.c (w32_console_read_socket):
1144 Remove unused variable `no_events'.
1145
1146 * w32term.c (x_draw_composite_glyph_string_foreground):
1147 Remove unused variable `width'.
1148
1149507c
JB
11492011-03-24 Juanma Barranquero <lekktu@gmail.com>
1150
1151 * w32term.c (x_set_glyph_string_clipping):
1152 Don't pass uninitialized region to CombineRgn.
1153
9c88f339
JB
11542011-03-23 Juanma Barranquero <lekktu@gmail.com>
1155
1156 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
1157 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
1158 (Fx_close_connection): Remove unused variable `i'.
1159
1160 * w32font.c (w32font_draw): Return number of glyphs.
1161 (w32font_open_internal): Remove unused variable `i'.
1162 (w32font_driver): Add missing initializer.
1163
1164 * w32menu.c (utf8to16): Remove unused variable `utf16'.
1165 (fill_in_menu): Remove unused variable `items_added'.
1166
1167 * w32term.c (last_mouse_press_frame): Remove static global variable.
1168 (w32_clip_to_row): Remove unused variable `f'.
1169 (x_delete_terminal): Remove unused variable `i'.
1170
1171 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
1172 (NOTHING): Remove unused static global variable.
1173 (uniscribe_check_otf): Remove unused variable `table'.
1174 (uniscribe_font_driver): Add missing initializers.
1175
dee091a3
JD
11762011-03-23 Julien Danjou <julien@danjou.info>
1177
1178 * term.c (Fsuspend_tty, Fresume_tty):
1179 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
1180 * window.c (temp_output_buffer_show):
1181 * insdel.c (signal_before_change):
1182 * frame.c (Fhandle_switch_frame):
1183 * fileio.c (Fdo_auto_save):
1184 * emacs.c (Fkill_emacs):
1185 * editfns.c (save_excursion_restore):
1186 * cmds.c (internal_self_insert):
1187 * callint.c (Fcall_interactively):
1188 * buffer.c (Fkill_all_local_variables):
1189 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
1190 Use Frun_hooks.
0f4a96b5 1191 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
1192 unconditionnaly since it does the check itself.
1193
2c520ab5 11942011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 1195
c9c49752
PE
1196 Fix more problems found by GCC 4.5.2's static checks.
1197
8abc3f12
PE
1198 * coding.c (encode_coding_raw_text): Avoid unnecessary test
1199 the first time through the loop, since we know p0 < p1 then.
1200 This also avoids a gcc -Wstrict-overflow warning.
1201
a2d26660
PE
1202 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
1203 leading to a memory leak, possible in functions like
1204 load_charset_map_from_file that can allocate an unbounded number
b12ef411 1205 of objects (Bug#8318).
a2d26660 1206
916c72e9
PE
1207 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
1208 that could (at least in theory) be that large.
1209
19ab8a18
PE
1210 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
1211 This is less likely to overflow, and avoids undefined behavior if
1212 overflow does occur. All callers changed. Use strtoul to scan
1213 for the unsigned long integer.
b7cbbd6f
PE
1214 (pint2hrstr): Simplify and tune code slightly.
1215 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 1216
f0641eff
PE
1217 * scroll.c (do_scrolling): Work around GCC bug 48228.
1218 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
1219
7f650bb9
PE
1220 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
1221 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
1222 (validate_x_resource_name): Simplify count usage.
1223 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 1224
37dd57d1
PE
1225 * fileio.c (Fcopy_file): Report error if fchown or fchmod
1226 fail (Bug#8306).
81e56e61 1227
699979fc 1228 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 1229
401bf9b4
PE
1230 * process.c (Fmake_network_process): Use socklen_t, not int,
1231 where POSIX says socklen_t is required in portable programs.
1232 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 1233 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
1234 (Fmake_network_process, server_accept_connection):
1235 (wait_reading_process_output, read_process_output):
1236 Likewise.
1237
b93aacde
PE
1238 * process.c: Rename or move locals to avoid shadowing.
1239 (list_processes_1, Fmake_network_process):
1240 (read_process_output_error_handler, exec_sentinel_error_handler):
1241 Rename or move locals.
4dc343ee 1242 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 1243 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 1244 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 1245 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 1246 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 1247
af8a867c 1248 Make tparam.h and terminfo.c consistent.
44f230aa
SM
1249 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
1250 Include tparam.h instead, since it declares them.
af8a867c
PE
1251 * cm.h (PC): Remove extern decl; tparam.h now does this.
1252 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
1253 * terminfo.c: Include tparam.h, to check interfaces.
1254 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
1255 (tparam): Adjust signature to match interface in tparam.h;
1256 this removes some undefined behavior. Check that outstring and len
1257 are zero, which they always are with Emacs.
1258 * tparam.h (PC, BC, UP): New extern decls.
1259
0248044d 1260 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 1261 (xftfont_open): Rename locals to avoid shadowing.
0248044d 1262
8ff096c1 1263 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
1264 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
1265 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 1266 (ftfont_list): Remove unused local.
49eaafba
PE
1267 (get_adstyle_property, ftfont_pattern_entity):
1268 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
1269 Rename locals to avoid shadowing.
8ff096c1 1270
e2be39f6
PE
1271 * xfont.c (xfont_list_family): Mark var as initialized.
1272
c9735e30
PE
1273 * xml.c (make_dom): Now static.
1274
8f5201ae
PE
1275 * composite.c (composition_compute_stop_pos): Rename local to
1276 avoid shadowing.
b246f932
PE
1277 (composition_reseat_it): Remove unused locals.
1278 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 1279 (composition_update_it): Mark var as initialized.
11b61122
PE
1280 (find_automatic_composition): Mark vars as initialized,
1281 with a FIXME (Bug#8290).
8f5201ae 1282
760fbc2c
PE
1283 character.h: Rename locals to avoid shadowing.
1284 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
1285 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
1286 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
1287 (BUF_DEC_POS): Be more systematic about renaming local temporaries
1288 to avoid shadowing.
1289
ff08eb85
PE
1290 * textprop.c (property_change_between_p): Remove; unused.
1291
fc7bf025
PE
1292 * intervals.c (interval_start_pos): Now static.
1293
235d7abc
PE
1294 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
1295
44f230aa
SM
1296 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
1297 Rename locals to avoid shadowing.
3e7d6594 1298
50060332
PE
1299 * sound.c (wav_play, au_play, Fplay_sound_internal):
1300 Fix pointer signedness.
d01f234b 1301 (alsa_choose_format): Remove unused local var.
c83b8872
PE
1302 (wav_play): Initialize a variable to 0, to prevent undefined
1303 behavior (Bug#8278).
50060332 1304
c4fc4e30
PE
1305 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
1306
918436ed
PE
1307 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
1308
c939f91b
PE
1309 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
1310 clobbering (Bug#8298).
b9c7f648
PE
1311 * sysdep.c (sys_subshell): Likewise.
1312 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 1313
6bd8c144
PE
1314 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
1315 This should get cleaned up, so that child_setup has the
1316 same signature on all platforms.
1317
7710357c 1318 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 1319 (relocate_fd): Rename locals to avoid shadowing.
7710357c 1320
c59da222
CY
13212011-03-22 Chong Yidong <cyd@stupidchicken.com>
1322
1323 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
1324 not to be necessary, and produces flickering.
1325
66b87493
GM
13262011-03-20 Glenn Morris <rgm@gnu.org>
1327
1328 * config.in: Remove file.
1329
45b6f6d5
JB
13302011-03-20 Juanma Barranquero <lekktu@gmail.com>
1331
1332 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
1333 are now in src/globals.h.
1334 (syms_of_minibuf): Remove spurious & from previous change.
1335
3ec03f7e
LL
13362011-03-20 Leo <sdl.web@gmail.com>
1337
1338 * minibuf.c (completing-read-function): New variable.
1339 (completing-read-default): Rename from completing-read.
1340 (completing-read): Call completing-read-function.
1341
b14e3e21
CY
13422011-03-19 Juanma Barranquero <lekktu@gmail.com>
1343
1344 * xfaces.c (Fx_load_color_file):
1345 Read color file from absolute filename (bug#8250).
1346
f2b726e6
JB
13472011-03-19 Juanma Barranquero <lekktu@gmail.com>
1348
1349 * makefile.w32-in: Update dependencies.
1350
09f6ff02
EZ
13512011-03-17 Eli Zaretskii <eliz@gnu.org>
1352
1353 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
1354
29a6015a
PE
13552011-03-17 Paul Eggert <eggert@cs.ucla.edu>
1356
a3a6c54e
PE
1357 Fix more problems found by GCC 4.5.2's static checks.
1358
b766f867
PE
1359 * process.c (make_serial_process_unwind, send_process_trap):
1360 (sigchld_handler): Now static.
1361
be02381c
PE
1362 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
1363 That way, the code declares only the vars that it needs.
1364 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
1365 * s/cygwin.h (PTY_ITERATION): Likewise.
1366 * s/darwin.h (PTY_ITERATION): Likewise.
1367 * s/gnu-linux.h (PTY_ITERATION): Likewise.
1368
57048744
PE
1369 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
1370 * process.c (allocate_pty): Don't declare stb unless it's needed.
1371
7914961c 1372 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
1373 (CONSTANTLIM): Remove; unused.
1374 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
1375 Define only if needed.
7914961c 1376
b3967b18
PE
1377 * unexelf.c (unexec): Name an expression,
1378 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
1379 Use a different way to cause a compilation error if anyone uses
1380 n rather than nn, a way that does not involve shadowing.
73366a00 1381 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 1382
29a6015a
PE
1383 * deps.mk (unexalpha.o): Remove; unused.
1384
43cfc33e 1385 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 1386 * unexec.h: New file.
ce701a33
PE
1387 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
1388 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
1389 Depend on unexec.h.
1390 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
1391 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
1392 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 1393 Change as necessary to match prototype in unexec.h.
ce701a33 1394
01f44d5a
PE
1395 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
1396 shadowing.
4f63c6bb 1397 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 1398
a6670b0b
PE
1399 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
1400 Rename locals to avoid shadowing.
1401
cef2010d 1402 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 1403 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 1404
d4d7173a
PE
1405 * print.c (Fredirect_debugging_output): Fix pointer signedess.
1406
f08b802a
PE
1407 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
1408 warning when compiling print.c.
1409
3ddb0639
PE
1410 * font.c (font_unparse_fcname): Abort in an "impossible" situation
1411 instead of using an uninitialized var.
5ad03b97 1412 (font_sort_entities): Mark var as initialized.
3ddb0639 1413
170a2692
PE
1414 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
1415
e663c700
PE
1416 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
1417 pointers to constants.
89bc529a 1418 (font_parse_fcname): Remove unused vars.
7b81e2d0 1419 (font_delete_unmatched): Now static.
ea838e10 1420 (font_get_spec): Remove; unused.
13a547c6
PE
1421 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
1422 (font_update_drivers, Ffont_get_glyphs, font_add_log):
1423 Rename or move locals to avoid shadowing.
e663c700 1424
2a80c887 1425 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 1426 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 1427
1384fa33 1428 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 1429 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 1430
8b2c52e9
PE
1431 * alloc.c (mark_backtrace): Move decl from here ...
1432 * lisp.h: ... to here, so that it can be checked.
1433
475545b5 1434 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 1435 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
1436 (lisp_indirect_variable): Name an expression,
1437 to avoid gcc -Wbad-function-cast warning.
1faed8ae 1438 (Fdefvar): Rename locals to avoid shadowing.
475545b5 1439
b1349114 1440 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 1441 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 1442 Use const pointer when appropriate.
b1349114 1443
a2928364
PE
1444 * lisp.h (get_system_name, get_operating_system_release):
1445 Move decls here, to check interfaces.
1446 * process.c (get_operating_system_release): Move decl to lisp.h.
1447 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
1448 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
1449 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
1450 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
1451 (Fformat_time_string, Fencode_time, Finsert_char):
1452 (Ftranslate_region_internal, Fformat):
1453 Rename or remove local vars to avoid shadowing.
9710023e 1454 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 1455
a415e694
PE
1456 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
1457 avoid shadowing.
1458
8ef4622d
PE
1459 * lisp.h (eassert): Check that the argument compiles, even if
1460 ENABLE_CHECKING is not defined.
1461
946f9a5b
PE
1462 * data.c (Findirect_variable): Name an expression, to avoid
1463 gcc -Wbad-function-cast warning.
112396d6 1464 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 1465 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
1466 (Fmake_variable_buffer_local, Fmake_local_variable):
1467 Mark variables as initialized.
52746918 1468 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 1469
e5aab7e7 1470 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
1471 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
1472 Rename locals to avoid shadowing.
dff45157
PE
1473 (mark_stack): Move local variables into the #ifdef region where
1474 they're used.
7bc26fdb
PE
1475 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
1476 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
1477 needed otherwise.
1478 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
1479 (GC_STRING_CHARS): Remove; not used.
d40d4be1 1480 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 1481
e5aab7e7
PE
1482 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
1483 avoids undefined behavior in theory.
1484
4da60324
PE
1485 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
1486
88043301
PE
1487 Use functions, not macros, for up- and down-casing (Bug#8254).
1488 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1489 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
1490 to use the following functions instead of these macros.
1491 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
1492 EMACS_INT, since callers assume the returned value fits in int.
1493 (upcase1): Likewise, for UPCASE_TABLE.
1494 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 1495 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 1496 the race-condition problem in the old DOWNCASE.
88043301 1497
19ed5445
PE
1498 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
1499 Rename locals to avoid shadowing.
1500 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
1501 (regex_compile, re_search_2, re_match_2_internal):
1502 Remove unused local vars.
952db0d7
PE
1503 (FREE_VAR): Rewrite so as not to use empty "else",
1504 which gcc can warn about.
da053e48 1505 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
1506 (RETALLOC_IF): Define only if needed.
1507 (WORDCHAR_P): Likewise. This one is never needed, but is used
1508 only in a comment talking about a compiler bug, so put inside
1509 the #if 0 of that comment.
1510 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
1511 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
1512 Remove; unused.
19ed5445 1513
1f3561e4 1514 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
1515 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
1516 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 1517
ded6f8f7
PE
1518 * search.c (simple_search): Remove unused var.
1519
dbd37a95
PE
1520 * dired.c (compile_pattern): Move decl from here ...
1521 * lisp.h: ... to here, so that it can be checked.
1522 (struct re_registers): New forward decl.
1523
7e47afad
PE
1524 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
1525
85f24f61
PE
1526 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
1527 All uses changed.
1528 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
1529 Rename locals to avoid shadowing.
5671df8f 1530 (Fvertical_motion): Mark locals as initialized.
85f24f61 1531
181aa2be 1532 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 1533 (casify_region): Mark local as initialized.
181aa2be 1534
930d429c
PE
1535 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
1536
7082eac6
PE
1537 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
1538 New macros, so that the caller can use some names other than
1539 gcpro1, gcpro2, etc.
1540 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
1541 of the new macros.
1542 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
1543 argument, for consistency with GCPRO2_VAR, etc: it is now the
1544 prefix of the variable, not the variable itself. All uses
1545 changed.
38b2c076
PE
1546 * dired.c (directory_files_internal, file_name_completion):
1547 Rename locals to avoid shadowing.
1548
15206ed9
PE
1549 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
1550 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
1551 dired.c's scmp function, had undefined behavior.
1552 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1553 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
1554 * buffer.h: ... to here, because these macros use current_buffer,
1555 and the new implementation with inline functions needs to have
1556 current_buffer in scope now, rather than later when the macros
1557 are used.
1558 (downcase, upcase1): New static inline functions.
1559 (DOWNCASE, UPCASE1): Reimplement using these functions.
1560 This avoids undefined behavior in expressions like
1561 DOWNCASE (x) == DOWNCASE (y), which previously suffered
1562 from race conditions in accessing the global variables
1563 case_temp1 and case_temp2.
1564 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
1565 * lisp.h (case_temp1, case_temp2): Remove their decls.
1566 * character.h (ASCII_CHAR_P): Move from here ...
1567 * lisp.h: ... to here, so that the inline functions mentioned
1568 above can use them.
1569
4a6bea26
PE
1570 * dired.c (directory_files_internal_unwind): Now static.
1571
f14b7e14
PE
1572 * fileio.c (file_name_as_directory, directory_file_name):
1573 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
1574 Now static.
2893f146
PE
1575 (file_name_as_directory): Use const pointers when appropriate.
1576 (Fexpand_file_name): Likewise. In particular, newdir might
1577 point at constant storage, so make it a const pointer.
fd4ead52 1578 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
1579 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
1580 signedness issues.
f839df0c
PE
1581 (Fset_file_times, Finsert_file_contents, auto_save_error):
1582 Rename locals to avoid shadowing.
f14b7e14 1583
5716756e 1584 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
1585 (Ftry_completion, Fall_completions): Rename or remove locals
1586 to avoid shadowing.
5716756e 1587
b4c3046a
PE
1588 * marker.c (bytepos_to_charpos): Remove; unused.
1589
b45db522
PE
1590 * lisp.h (verify_bytepos, count_markers): New decls,
1591 so that gcc does not warn that these functions aren't declared.
1592
85876d07
PE
1593 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
1594 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 1595 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 1596 (copy_text): Remove unused local var.
85876d07 1597
03d78a21 1598 * filelock.c (within_one_second): Now static.
b3dd38ab 1599 (lock_file_1): Rename local to avoid shadowing.
03d78a21 1600
5df8f01b
PE
1601 * buffer.c (fix_overlays_before): Mark locals as initialized.
1602 (fix_start_end_in_overlays): Likewise. This function should be
1603 simplified by using pointers-to-pointers, but that's a different
1604 matter.
b1d876f1 1605 (switch_to_buffer_1): Now static.
8f54f30a
PE
1606 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
1607 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 1608
a70072c9 1609 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 1610 Fix pointer signedness issue.
edced198
PE
1611 (sys_subshell): Mark local as volatile if checking for lint,
1612 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 1613 (MAXPATHLEN): Define only if needed.
a70072c9 1614
a0977c44
PE
1615 * process.c (serial_open, serial_configure): Move decls from here ...
1616 * systty.h: ... to here, so that they can be checked.
1617
a884fdcc
PE
1618 * fns.c (get_random, seed_random): Move extern decls from here ...
1619 * lisp.h: ... to here, so that they can be checked.
1620
604efe86 1621 * sysdep.c (reset_io): Now static.
b8950c94 1622 (wait_for_termination_signal): Remove; unused.
604efe86 1623
38fc62d9
PE
1624 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
1625 (copy_keymap_item, append_key, push_text_char_description):
1626 Now static.
1004a21a 1627 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 1628 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
1629 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
1630 (describe_map_tree):
1631 Rename locals to avoid shadowing.
38fc62d9 1632
2f2650da
PE
1633 * keyboard.c: Declare functions static if they are not used elsewhere.
1634 (echo_char, echo_dash, cmd_error, top_level_2):
1635 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
1636 (read_char, kbd_buffer_get_event, make_lispy_position):
1637 (make_lispy_event, make_lispy_movement, apply_modifiers):
1638 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
1639 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
1640 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 1641 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 1642 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 1643
a053e86c 1644 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
1645 (mark_kboards): Move decl here ...
1646 * alloc.c (mark_kboards): ... from here.
a053e86c 1647
4752793e
PE
1648 * lisp.h (force_auto_save_soon): New decl.
1649
74f10ca7 1650 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
1651 (DEFINE_DUMMY_FUNCTION): New macro.
1652 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
1653 Use it.
c03cd23f
PE
1654 (main): Add casts to avoid warnings
1655 if GCC considers string literals to be constants.
74f10ca7 1656
022e70d4
PE
1657 * lisp.h (fatal_error_signal): Add decl, since it's exported.
1658
59d6fe83
PE
1659 * dbusbind.c: Pointer signedness fixes.
1660 (xd_signature, xd_append_arg, xd_initialize):
1661 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1662 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1663 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
1664 (Fdbus_register_signal): Use SSDATA when the context wants char *.
1665
78320123
PE
1666 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
1667 if GCC considers string literals to be constants.
49cebcca 1668 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 1669
35ac2a97
SM
16702011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
1671
fb103ca9
SM
1672 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
1673 (print_preprocess, print_object): New macro to fix last change.
1674
35ac2a97
SM
1675 * print.c (print_preprocess): Don't forget font objects.
1676
62973b41
JB
16772011-03-16 Juanma Barranquero <lekktu@gmail.com>
1678
1679 * emacs.c (USAGE3): Doc fixes.
1680
0e48bb22
AS
16812011-03-15 Andreas Schwab <schwab@linux-m68k.org>
1682
1683 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
1684 structure.
1685
7684e57b
JB
16862011-03-14 Juanma Barranquero <lekktu@gmail.com>
1687
1688 * lisp.h (VWindow_system, Qfile_name_history):
1689 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
1690 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
1691 (w32_system_caret_x, w32_system_caret_y): Declare extern.
1692
1693 * w32select.c: Don't #include "keyboard.h".
c96bbc66 1694 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
1695
1696 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
1697 * w32console.c (detect_input_pending, read_input_pending)
1698 (encode_terminal_code):
1699 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
1700 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
1701 (w32_system_caret_y, Qfile_name_history):
1702 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
1703 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
1704 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
1705 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
1706 * w32proc.c (Qlocal, report_file_error):
1707 * w32term.c (Vwindow_system, updating_frame):
1708 * w32uniscribe.c (initialized, uniscribe_font_driver):
1709 Remove unneeded extern declarations.
1710
2aa46d6c
CY
17112011-03-14 Chong Yidong <cyd@stupidchicken.com>
1712
c96bbc66 1713 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 1714
cffc6f3b
CY
17152011-03-13 Chong Yidong <cyd@stupidchicken.com>
1716
1717 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
1718 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
1719 These macros can no longer be used for assignment.
1720
44f230aa
SM
1721 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1722 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
1723 (record_buffer_markers, fetch_buffer_markers): New functions for
1724 recording and fetching special buffer markers.
1725 (set_buffer_internal_1, set_buffer_temp): Use them.
1726
1727 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
1728
1729 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
1730
1731 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
1732 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
1733
1734 * xdisp.c (hscroll_window_tree):
1735 (reconsider_clip_changes): Use PT instead of BUF_PT.
1736
d251f04b
EZ
17372011-03-13 Eli Zaretskii <eliz@gnu.org>
1738
1739 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
1740 $(EMACS_ROOT)/lib/intprops.h.
1741
f0c77cd1
PE
17422011-03-13 Paul Eggert <eggert@cs.ucla.edu>
1743
3eca4629
PE
1744 Fix more problems found by GCC 4.5.2's static checks.
1745
7c86ee98
PE
1746 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
1747 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
1748 (xg_free_frame_widgets): Make it clear that a local variable is
1749 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
1750 (gdk_window_get_screen): Make it clear that this macro is needed
1751 only if USE_GTK_TOOLTIP.
1e5524e7
PE
1752 (int_gtk_range_get_value): New function, which avoids a diagnostic
1753 from gcc -Wbad-function-cast.
1754 (xg_set_toolkit_scroll_bar_thumb): Use it.
1755 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
1756 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
1757 (get_utf8_string, xg_get_file_with_chooser):
1758 Rename locals to avoid shadowing.
1759 (create_dialog): Move locals to avoid shadowing.
7c86ee98 1760
41729b81
PE
1761 * xgselect.c (xg_select): Remove unused var.
1762
f0c77cd1
PE
1763 * image.c (four_corners_best): Mark locals as initialized.
1764 (gif_load): Initialize transparent_p to zero (Bug#8238).
1765 Mark another local as initialized.
ec6cf4c6 1766 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 1767
ce0ad53d 1768 * image.c (clear_image_cache): Now static.
d5d5a617 1769 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 1770 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
1771 (x_edge_detection): Remove unnecessary cast that
1772 gcc -Wbad-function-cast diagnoses.
2037898d 1773 (gif_load): Fix pointer signedness.
6ae141d6
PE
1774 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
1775 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 1776
33383987 17772011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 1778
d32df629
PE
1779 Improve quality of tests for time stamp overflow.
1780 For example, without this patch (encode-time 0 0 0 1 1
1781 1152921504606846976) returns the obviously-bogus value (-948597
1782 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
1783 reports time overflow. See
1784 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
1785 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
1786 * editfns.c: Include limits.h and intprops.h.
1787 (TIME_T_MIN, TIME_T_MAX): New macros.
1788 (time_overflow): Move earlier, to before first use.
1789 (hi_time, lo_time): New functions, for an accurate test for
1790 out-of-range times.
1791 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
1792 (Fget_internal_run_time): Don't assume time_t fits in int.
1793 (make_time): Use list2 instead of Fcons twice.
1794 (Fdecode_time): More accurate test for out-of-range times.
1795 (check_tm_member): New function.
1796 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
1797 (lisp_time_argument): Don't rely on undefined left-shift and
1798 right-shift behavior when checking for time stamp overflow.
8be6f318 1799
fe31d94c
PE
1800 * editfns.c (time_overflow): New function, refactoring common code.
1801 (Fformat_time_string, Fdecode_time, Fencode_time):
1802 (Fcurrent_time_string): Use it.
1803
8be6f318
PE
1804 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
1805 * dired.c (make_time): Move to ...
1806 * editfns.c (make_time): ... here.
1807 * systime.h: Note the move.
1808
09d9db2c 18092011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 1810
126bc0dc
YM
1811 * fringe.c (update_window_fringes): Remove unused variables.
1812
c47cbdfd
YM
1813 * unexmacosx.c (copy_data_segment): Also copy __got section.
1814 (Bug#8223)
1815
7ac80be9
EZ
18162011-03-12 Eli Zaretskii <eliz@gnu.org>
1817
c96bbc66 1818 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
1819 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
1820 Constify `char *' arguments and their references according to
1821 prototypes in tparam.h.
1822
ecb0f94d 1823 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 1824
7ac80be9
EZ
1825 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
1826 Adapt all references accordingly.
1827
1828 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
1829
ef1fd07e
TT
18302011-03-11 Tom Tromey <tromey@redhat.com>
1831
1832 * buffer.c (syms_of_buffer): Remove obsolete comment.
1833
7ef4b50c
EZ
18342011-03-11 Eli Zaretskii <eliz@gnu.org>
1835
1836 * termhooks.h (encode_terminal_code): Declare prototype.
1837
1838 * msdos.c (encode_terminal_code): Don't declare prototype.
1839
1840 * term.c (encode_terminal_code): Now external again, used by
1841 w32console.c and msdos.c.
1842
44f230aa
SM
1843 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
1844 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 1845
4b1ec863 18462011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 1847
1714f52b 1848 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 1849
4b1ec863
PE
1850 * fringe.c (update_window_fringes): Mark locals as initialized
1851 (Bug#8227).
1852 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 1853
524c7aa6
PE
1854 * alloc.c (mark_fringe_data): Move decl from here ...
1855 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
1856 to check its interface.
1857 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
1858
a5c0af81 1859 * fontset.c (free_realized_fontset): Now static.
7519b8cd 1860 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 1861 (fontset_font): Mark local as initialized.
a9a06e0b 1862 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 1863
b4716021
PE
1864 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
1865
811e9bac 1866 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 1867 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
1868 (x_own_selection, Fx_disown_selection_internal): Rename locals
1869 to avoid shadowing.
1870 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 1871
7e3ab302
PE
1872 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
1873 so that the caller can use some name other than gcpro1.
1874 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
1875 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1876 (Fx_backspace_delete_keys_p):
1877 Use them to avoid shadowing, and rename vars to avoid shadowing.
1878 (x_decode_color, x_set_name, x_window): Now static.
6b437900 1879 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 1880 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
1881 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
1882 Remove unused locals.
7e3ab302
PE
1883 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1884 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
1885 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
1886 macros.
f78faa98 1887
e2b13473
PE
1888 * xterm.h (x_mouse_leave): New decl.
1889
77f23912
PE
1890 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
1891 Remove unused functions.
cdf4ba58
PE
1892 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
1893 (x_calc_absolute_position): Now static.
7411c686 1894 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 1895 Don't declare local "event" unless it's used.
ed7bf3a5
PE
1896 (x_iconify_frame, x_free_frame_resources): Don't declare locals
1897 unless they are used.
38d0b34a
PE
1898 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
1899 (x_fatal_error_signal): Remove; not used.
a6067996
PE
1900 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
1901 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
1902 (x_error_catcher, x_connection_closed, x_error_handler):
1903 (x_error_quitter, xembed_send_message, x_iconify_frame):
1904 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 1905 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 1906 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 1907
44f230aa
SM
1908 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
1909 Rename or move locals to avoid shadowing.
6b463e58 1910 (tty_defined_color, merge_face_heights): Now static.
5967d051 1911 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
1912 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
1913 does not deduce is never used uninitialized.
73719eba
PE
1914 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
1915 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 1916
426994c3 1917 * terminal.c (store_terminal_param): Now static.
5489860b 1918
032f1620 1919 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 1920 (set_frame_menubar): Remove unused local.
d4323972 1921 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
1922 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
1923 since they might point to immutable storage.
281585b0
PE
1924 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
1925 since it's unused otherwise.
032f1620 1926
367c19e5 1927 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 1928 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
1929 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
1930 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 1931 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
1932 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
1933 does not deduce are never used uninitialized.
70739cbe 1934
07b48fa9
PE
1935 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
1936
8868a238 1937 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
1938 * window.c (window_loop, size_window):
1939 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 1940
7e5cf297 1941 * window.c (display_buffer): Now static.
d6550a9f
PE
1942 (size_window): Mark variables that gcc -Wuninitialized
1943 does not deduce are never used uninitialized.
a586633d
PE
1944 * window.h (check_all_windows): New decl, to forestall
1945 gcc -Wmissing-prototypes diagnostic.
5b555da1 1946 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 1947
f6095868
PE
1948 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
1949 shadowing.
1950 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
1951 Include <limits.h>.
1952 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
1953 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
1954 (load_charset_map): Mark variables that gcc -Wuninitialized
1955 does not deduce are never used uninitialized.
53df7c11 1956 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 1957
f38b440c
PE
1958 * coding.c (coding_set_source, coding_set_destination):
1959 Use "else { /* comment */ }" rather than "else /* comment */;"
1960 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
1961 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
1962 a block, when the outer 'i' will do.
1963 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
1964 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
1965 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
1966 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
1967 (Fdecode_sjis_char, Fdefine_coding_system_internal):
1968 Rename locals to avoid shadowing.
1969 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
1970 * coding.c (emacs_mule_char, encode_invocation_designation):
1971 Now static, since they're not used elsewhere.
413bb2db 1972 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 1973 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
1974 (decode_coding_emacs_mule): Mark variables that gcc
1975 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
1976 (detect_coding_iso_2022): Initialize a local variable that might
1977 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 1978 this initialization is needed. (Bug#8211)
5f58e762
PE
1979 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
1980 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
1981 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
1982 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
1983 Remove unused macros.
f38b440c 1984
232b38b9 1985 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 1986 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 1987 * character.c (string_count_byte8): Likewise.
232b38b9 1988
fb90da1b
PE
1989 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
1990 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
1991
fb93dbc2
PE
1992 * chartab.c (copy_sub_char_table): Now static, since it's not used
1993 elsewhere.
5c156ace
PE
1994 (sub_char_table_ref_and_range, char_table_ref_and_range):
1995 Rename locals to avoid shadowing.
bbcd0949 1996 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 1997
7d3b3862 1998 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 1999 (BIDI_BOB): Remove unused macro.
7d3b3862 2000
6be7d3da
PE
2001 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
2002 deduce are never used uninitialized.
c2ed9c8b 2003 * term.c (encode_terminal_code): Likewise.
6be7d3da 2004
75f8807f 2005 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 2006
50938595
PE
2007 * tparam.h: New file.
2008 * term.c, tparam.h: Include it.
2009 * deps.mk (term.o, tparam.o): Depend on tparam.h.
2010 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
2011 Move these decls to tparam.h, and make them agree with what
2012 is actually in tparam.c. The previous trick of using incompatible
2013 decls in different modules does not conform to the C standard.
2014 All callers of tparam changed to use tparam's actual API.
2015 * tparam.c (tparam1, tparam, tgoto):
2016 Use const pointers where appropriate.
2017
fbceeba2
PE
2018 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
2019 * cm.h (struct cm): Likewise.
2020 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
2021 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
2022 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
2023 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
2024 (turn_on_face, init_tty): Likewise.
2025 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 2026
7f3f1250
PE
2027 * term.c (term_mouse_position): Rename local to avoid shadowing.
2028
e6ca6543
PE
2029 * alloc.c (mark_ttys): Move decl from here ...
2030 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
2031
c40f8d15
AS
20322011-03-11 Andreas Schwab <schwab@linux-m68k.org>
2033
2034 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
2035
cfe0661d
JB
20362011-03-09 Juanma Barranquero <lekktu@gmail.com>
2037
2038 * search.c (compile_pattern_1): Remove argument regp, unused since
2039 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
2040 (compile_pattern): Don't pass it.
2041
0afb4571
J
20422011-03-08 Jan Djärv <jan.h.d@swipnet.se>
2043
2044 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
2045 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
2046 for ! HAVE_GTK3.
2047 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
2048
2049 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
2050
2051 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
2052 gdk_window_get_screen, gdk_window_get_geometry,
2053 gdk_x11_window_lookup_for_display and GDK_KEY_g.
2054 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
2055 (xg_get_pixbuf_from_pixmap): New function.
2056 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
2057 to Pixmap, take frame as parameter, remove GdkColormap parameter.
2058 Call xg_get_pixbuf_from_pixmap instead of
2059 gdk_pixbuf_get_from_drawable.
2060 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
2061 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
2062 (xg_check_special_colors): Use GtkStyleContext and its functions
2063 for HAVE_GTK3.
2064 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
2065 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
2066 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
2067 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
2068 Call gtk_widget_get_preferred_size.
0afb4571
J
2069 (xg_frame_resized): gdk_window_get_geometry only takes 5
2070 parameters.
44f230aa
SM
2071 (xg_win_to_widget, xg_event_is_for_menubar):
2072 Call gdk_x11_window_lookup_for_display.
0afb4571
J
2073 (xg_set_widget_bg): New function.
2074 (delete_cb): New function.
2075 (xg_create_frame_widgets): connect delete-event to delete_cb.
2076 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
2077 (xg_set_background_color): Call xg_set_widget_bg.
2078 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
2079 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
2080 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
2081 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
2082 if ! HAVE_GTK3.
2083 (update_frame_tool_bar): Call gtk_widget_hide.
2084 (xg_initialize): Use GDK_KEY_g.
2085
2086 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
2087 if ! HAVE_GTK3
2088 (x_session_initialize): Call gdk_x11_set_sm_client_id.
2089
2090 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
2091 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
2092 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
2093
1c2cc4ef
JB
20942011-03-08 Juanma Barranquero <lekktu@gmail.com>
2095
2096 * w32xfns.c (select_palette): Check success of RealizePalette against
2097 GDI_ERROR, not zero.
2098
33383987 2099See ChangeLog.11 for earlier changes.
aac0c6e3
MR
2100
2101;; Local Variables:
2102;; coding: utf-8
aac0c6e3
MR
2103;; End:
2104
33383987 2105 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
2106
2107 This file is part of GNU Emacs.
2108
2109 GNU Emacs is free software: you can redistribute it and/or modify
2110 it under the terms of the GNU General Public License as published by
2111 the Free Software Foundation, either version 3 of the License, or
2112 (at your option) any later version.
2113
2114 GNU Emacs is distributed in the hope that it will be useful,
2115 but WITHOUT ANY WARRANTY; without even the implied warranty of
2116 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
2117 GNU General Public License for more details.
2118
2119 You should have received a copy of the GNU General Public License
2120 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.