Do not overwrite config.status while executing it.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
adff3182
JD
12012-07-30 Jan Djärv <jan.h.d@swipnet.se>
2
3 * nsterm.m (ns_do_open_file): New variable.
4 (ns_term_init): Set ns_do_open_file to NO after run returns.
5 (openFile, openTempFile, openFileWithoutUI, openFiles): Open
6 files only if ns_do_open_file.
7
c32af1e4
PE
82012-07-30 Paul Eggert <eggert@cs.ucla.edu>
9
7393bcbb
PE
10 * lisp.h (SWITCH_ENUM_CAST): Remove. All uses removed.
11 This no-op macro hasn't been needed for many years.
12 * src/regex.c (SWITCH_ENUM_CAST) [!emacs]: Likewise.
13
c32af1e4
PE
14 Export DIRECTORY_SEP, TYPEMASK, VALMASK to GDB.
15 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]: Add lsb_bits.
16 * lisp.h (enum lsb_bits) [USE_LSB_TAG]: New enum, for
17 gdb_make_enums_visible.
18 (TYPEMASK, VALMASK) [USE_LSB_TAGS]: Now enum constants, not macros.
19 (DIRECTORY_SEP): Now a constant, not a macro.
20
302fc036
EZ
212012-07-30 Eli Zaretskii <eliz@gnu.org>
22
23 * w32fns.c (w32_wnd_proc): Pass w32_keyboard_codepage to
24 w32_kbd_patch_key as the 2nd arg. (Bug#12082)
25
26 * w32term.c <w32_keyboard_codepage>: Renamed from
27 keyboard_codepage and now external. All users changed.
28
29 * w32term.h: Add declaration of w32_keyboard_codepage.
30
31 * w32inevt.c (w32_kbd_patch_key): Accept an additional argument --
32 the codepage to translate keys to Unicode. If this argument is
33 -1, use the value returned by GetConsoleCP. All callers changed.
34
88fb40b4
PE
352012-07-30 Paul Eggert <eggert@cs.ucla.edu>
36
0aee6912
PE
37 Update .PHONY listings in makefiles.
38 * Makefile.in (.PHONY): Add all, mostlyclean, clean,
39 bootstrap-clean, distclean, maintainer-clean, versioclean,
40 extraclean, frc.
41
88fb40b4
PE
42 * lisp.h (STRING_BYTES_BOUND): Cast entire result to ptrdiff_t.
43 This is a bit clearer. Fix some commentary typos.
44
0a763bd1
GM
452012-07-30 Glenn Morris <rgm@gnu.org>
46
32bac6d6
GM
47 * s/netbsd.h: Let configure include signal.h if needed.
48 Remove file, which is now empty.
49
b65e7c46
GM
50 * s/usg5-4-common.h (_longjmp, _setjmp, TIOCSIGSEND):
51 Let configure set them.
52 * s/irix6-5.h (_longjmp, _setjmp, TIOCSIGSEND):
53 No more need to undefine.
0a763bd1 54
169304bd
AS
552012-07-30 Andreas Schwab <schwab@linux-m68k.org>
56
57 * keymap.c (Fkey_description): Don't remove 0x80 bit from
58 non-single-byte char when adding meta modifier. (Bug#12090)
59
6cd7a139
DA
602012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
61
62 Convert safe_call to use variable number of arguments.
63 * xdisp.c (safe_call): Convert to use varargs. Adjust users.
64 (safe_call2): Fix comment.
65 * lisp.h (safe_call): Adjust prototype.
66 * coding.c (encode_coding_object): Change to use safe_call2.
67 * xfaces.c (merge_face_heights): Change to use safe_call1.
68
d34d6ffc
GM
692012-07-30 Glenn Morris <rgm@gnu.org>
70
7b8a48e4 71 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
227f5bd0 72 does that unconditionally. Remove file, which is now empty.
7b8a48e4 73
d34d6ffc
GM
74 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
75 Remove empty files.
76
03a660a6
PE
772012-07-30 Paul Eggert <eggert@cs.ucla.edu>
78
79 Export to GDB most of lisp.h's remaining object-like macros.
80 * lisp.h (min, max): Move earlier, because they're used earlier now.
81 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
82 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
83 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
84 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
85 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
86 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
87 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
88 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
89 Now constants, for GDB. They need not be macros.
90 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
91 Now constants, for GDB, as well as macros, for static initializers.
92 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
93 Move to after the definition of struct Lisp_Char_Table,
94 since the former now needs that type defined.
95 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
96 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
97 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
98 New enums, for gdb_make_enums_visible.
99 (GLYPH_MODE_LINE_FACE): Remove; unused.
88fb40b4 100 * alloc.c (STRING_BYTES_MAX): Now a constant, not a macro.
03a660a6
PE
101 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
102 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
103 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
104 enum maxargs, enum MAX_ALLOCA.
105 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
106 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
107 no longer needed, now that they are done in lisp.h.
108
e499d0ee
DA
1092012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
110
111 Cleanup string bytes checking.
112 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
113 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
114 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
115 (check_sblock, compact_small_strings): Simplify.
116
d5040d2d
PE
1172012-07-29 Paul Eggert <eggert@cs.ucla.edu>
118
119 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
120 These macros are confusing and no longer need to be defined, as
121 the enum values now suffice. All uses replaced with definiens.
122 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
123
7f259ae6
JB
1242012-07-29 Juanma Barranquero <lekktu@gmail.com>
125
126 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
127 ($(BLD)/w32console.$(O)): Update dependencies.
128
7e63e0c3
DA
1292012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
130
131 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
132 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
133 time. Adjust users.
134 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
135
ffd817eb
JD
1362012-07-29 Jan Djärv <jan.h.d@swipnet.se>
137
138 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
139 setting sitelisp (Bug#12010).
140
417a7a0e
EZ
1412012-07-29 Eli Zaretskii <eliz@gnu.org>
142
143 * w32heap.h (OS_9X): Renamed from OS_WINDOWS_95.
144
145 * w32heap.c (cache_system_info):
146 * w32.c (sys_rename):
147 * w32proc.c (find_child_console, sys_kill): All users changed.
148
387d4d92
PE
1492012-07-29 Paul Eggert <eggert@cs.ucla.edu>
150
151 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
152
55a6cca6
EZ
1532012-07-29 Eli Zaretskii <eliz@gnu.org>
154
155 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
156
dbcf001c
DA
1572012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
158
159 Cleanup statistics calculation in Fgarbage_collect.
160 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start. Fix
161 zombies percentage calculation. Simplify elapsed time calculation.
162
e2688e4a
DA
1632012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
164
165 Generalize marker debugging code under MARKER_DEBUG and use eassert.
166 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
167 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
168 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
169 (replace_range, replace_range_2, del_range_2): Change to eassert.
170 * marker.c (byte_char_debug_check): Adjust style.
171
b46a6a83
PE
1722012-07-29 Paul Eggert <eggert@cs.ucla.edu>
173
174 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
175 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
176 long-ago-commented-out code that talks about "WIN32".
177 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
178 All uses changed.
179
e32a5799
PE
1802012-07-28 Paul Eggert <eggert@cs.ucla.edu>
181
182 Use Gnulib stdalign module (Bug#9772, Bug#9960).
183 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
184 Simplify by using alignof.
185 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
186 * lisp.h: Include <stdalign.h>.
187 (GCALIGNMENT): New macro and constant.
188 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
189 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
190 (stdalign): New macro, if not already defined.
191
df81cd29
EZ
1922012-07-28 Eli Zaretskii <eliz@gnu.org>
193
01bd1b0d
EZ
194 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
195 * w32inevt.c: Include w32inevt.h.
196 (w32_read_console_input): New inline function, calls either
197 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
198 w32_console_unicode_input.
199 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
200 (w32_kbd_patch_key, key_event): Use the codepage returned by
201 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
202 (key_event): use uChar.UnicodeChar only if
203 w32_console_unicode_input is non-zero.
204
205 * w32console.c: Include w32heap.h.
206 <w32_console_unicode_input>: New global variable.
207 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
208 family of Windows, zero otherwise.
209
210 * w32inevt.h: Declare w32_console_unicode_input.
211
df81cd29
EZ
212 * xdisp.c (init_iterator): Don't reference tip_frame in a build
213 --without-x. (Bug#11742)
214
c20fdd9e
PE
2152012-07-27 Paul Eggert <eggert@cs.ucla.edu>
216
217 Adjust GDB to reflect pvec_type changes (Bug#12036).
218 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
219 2012-07-04 changes to pseudovector representation. Problem
220 reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
221
32770973 2222012-07-27 Michael Albinus <michael.albinus@gmx.de>
e518bc71
MA
223
224 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
225 bus address.
226 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
227
3438fe21
EZ
2282012-07-27 Eli Zaretskii <eliz@gnu.org>
229
bcfbc9de
EZ
230 * alloc.c (listn): Fix the order the arguments are consed onto the
231 list.
232
3438fe21
EZ
233 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
234 enumeration constants, as PURE and HEAP are too general, and clash
235 with other headers and sources, such as gmalloc.c and the
236 MS-Windows system headers. All users changed.
237
eeaea515
DA
2382012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
239
240 Revert last save_excursion_save and save_excursion_restore changes.
241 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
242 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
243
073c88c2
DA
2442012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
245
246 Fix recently-introduced typos in Windows port.
247 Reported by Martin Rudalics <rudalics@gmx.at>.
248 * w32.c (init_environment): Replace comma with semicolon.
eeaea515 249 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
073c88c2 250
4706125e
PE
2512012-07-27 Paul Eggert <eggert@cs.ucla.edu>
252
253 Improve GDB symbol export (Bug#12036).
254 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
255 arms of an 'if', not using conditional expressions; otherwise GDB
256 complains about the types in the unevaluated arm when the argument
257 is an integer literal.
258 (xgetint): Simplify expression.
259 * alloc.c (gdb_make_enums_visible): New constant. This ports to
260 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
261 Zaretskii in <http://bugs.gnu.org/12036#13>.
262 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
263 needed now that we have gdb_make_enums_visible.
264 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
265 (enum enum_USE_LSB_TAG):
266 New enum types, packaging up enums that need to be exported to GDB.
267
694b6c97
DA
2682012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
269
270 Utility function to make a list from specified amount of objects.
271 * lisp.h (enum constype): New datatype.
272 (listn): New prototype.
273 * alloc.c (listn): New function.
274 (Fmemory_use_count, syms_of_alloc): Use it.
275 * buffer.c (syms_of_buffer): Likewise.
276 * callint.c (syms_of_callint): Likewise.
277 * charset.c (define_charset_internal): Likewise.
278 * coding.c (syms_of_coding): Likewise.
279 * keymap.c (syms_of_keymap): Likewise.
280 * search.c (syms_of_search): Likewise.
281 * syntax.c (syms_of_syntax): Likewise.
282 * w32.c (init_environment): Likewise.
283 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
284 * xdisp.c (syms_of_xdisp): Likewise.
285 * xfns.c (syms_of_xfns): Likewise.
286
6195f384
DA
2872012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
288
289 Fast save_excursion_save and save_excursion_restore.
290 * lisp.h (struct Lisp_Excursion): New data type.
291 (PVEC_EXCURSION): New pseudovector type.
292 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
293 to deal with it. Adjust comments.
294 (init_marker, attach_marker): New prototype.
295 (unchain_marker): Adjust prototype.
296 * marker.c (attach_marker): Change to global.
297 (init_marker): New function.
298 * alloc.c (Fmake_marker, build_marker): Use it.
299 (build_marker): More easserts.
300 (mark_object): Handle struct Lisp_Excursion.
301 * editfns.c (save_excursion_save, save_excursion_restore):
302 Reimplement to use struct Lisp_Excursion. Add comments.
303
5eceb8fb
PE
3042012-07-26 Paul Eggert <eggert@cs.ucla.edu>
305
306 Fix export of symbols to GDB (Bug#12036).
307 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
308 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
309 emacs.c, as this is a more-suitable home. Had this been done earlier
310 the fix for 12036 would have avoided some of the problems noted in
311 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
312 would have been more obvious.
562157c8
PE
313 * emacs.c: Do not include <verify.h>; no longer needed.
314 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
5eceb8fb
PE
315 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
316 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
317 Remove; now done in lisp.h.
318 * lisp.h (PUBLISH_TO_GDB): New macro.
319 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
320 (DATA_SEG_BITS): Use it.
321 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
322 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
323 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
324 not be usable in #if. This simplifies things.
325
d6749401
JB
3262012-07-26 Juanma Barranquero <lekktu@gmail.com>
327
328 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
329
1781b9e9
PE
3302012-07-26 Paul Eggert <eggert@cs.ucla.edu>
331
d89518db 332 Simplify export of symbols to GDB (Bug#12036).
1781b9e9
PE
333 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
334 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
335 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
336 Adjust to changes in lisp.h and emacs.c, by using
337 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
338 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
339 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
340 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
341 instead of gdb_valbits.
342 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
343 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
344 instead of gdb_array_mark_flag.
345 (xboolvector): Get size from $->size, not $->header.size.
346 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
347 (xreload, hook-run, hookpost-run): Remove.
348 * emacs.c: Include <verify.h>.
349 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
350 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
351 Remove.
352 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
353 (gdb_USE_LSB_TAG): New enum constants.
354 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
355 Also define these as enum constants, so they're visible to GDB.
356 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
357 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
358 as constants, so they're visible to GDB.
359 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
360 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
361 Now enum constants, not macros, so they're visible to GDB.
362 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
363 more convenient now. All uses changed.
364 (VALMASK) [USE_LSB_TAG]: Also define in this case.
365 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
366
3628596a
DA
3672012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
368
369 Explicitly free restriction data that are not needed anymore.
370 * editfns.c (save_restriction_restore): Free restriction data.
371
7abaf5cc
SM
3722012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
373
374 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
375 add argument, tune behavior, and adjust all callers.
376
71f88e00
PE
3772012-07-25 Paul Eggert <eggert@cs.ucla.edu>
378
379 Use typedef for EMACS_INT, EMACS_UINT.
380 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
381 than macros. This simplifies debugging in the usual case, since
382 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
383 and it allows expressions involving EMACS_INT casts.
384 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
385
57ec3034
JD
3862012-07-25 Jan Djärv <jan.h.d@swipnet.se>
387
388 * nsterm.m (ns_read_socket): Return early if there is a modal
389 window (Bug#12043).
390
8137e7b3
MR
3912012-07-25 Martin Rudalics <rudalics@gmx.at>
392
393 * frame.c (Fredirect_frame_focus): In doc-string don't mention
394 that FOCUS-FRAME can be omitted.
395
04e9897c
DA
3962012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
397
398 Adjust buffer text indirection counters at the end of Fkill_buffer.
399 * buffer.c (Fkill_buffer): Adjust indirection counters when the
400 buffer is definitely dead. This should really fix an issue reported
401 by Christoph Scholtes again. (Bug#12007).
402 (init_buffer_once): Initialize indirection counters of
403 buffer_defaults and buffer_local_symbols (for sanity and safety).
404
8a0484e1
EZ
4052012-07-24 Eli Zaretskii <eliz@gnu.org>
406
407 * xdisp.c (init_iterator): Don't compute dimensions of truncation
408 and continuation glyphs on tooltip frames, leave them at zero.
409 Avoids continued lines in tooltips. (Bug#11832)
410
fa691a83
DA
4112012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
412
413 Simplify copy_overlay.
04e9897c 414 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
415 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
416
436bc8e0
EZ
4172012-07-23 Eli Zaretskii <eliz@gnu.org>
418
419 * print.c (print_object): Don't crash when a frame's name is nil
420 or invalid. (Bug#12025)
421
422 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
423 it signals an error when a tooltip frame is being created.
424
d7a7fda3
DA
4252012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
426
427 Cleanup miscellaneous objects allocation and initialization.
428 * alloc.c (allocate_misc): Change to static. Add argument to
429 specify the subtype. Adjust comment and users.
430 (build_overlay): New function.
431 * buffer.c (copy_overlays, Fmake_overlay): Use it.
432 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
433 (allocate_misc): Remove prototype.
434 (build_overlay): Add prototype.
435
4362012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
437
438 Swap buffer text indirection counters in Fbuffer_swap_text.
439 * buffer.c (Fbuffer_swap_text): Swap indirections too.
440 This avoids crash reported by Christoph Scholtes at
441 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
442
9d7fa573
JD
4432012-07-22 Jan Djärv <jan.h.d@swipnet.se>
444
445 * nsmenu.m (Popdown_data): New struct.
446 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
447 free Popdown_data.
448 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
449 (initWithContentRect): Make imgView and contentView non-static
450 and autorelease them. Also autorelease img and matrix (Bug#12005).
451 (dealloc): Remove (Bug#12005).
452
0dd6d66d
DA
4532012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
454
455 Adjust consing_since_gc when objects are explicitly freed.
456 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
457 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
458 (free_cons, free_misc): Subtract object size from consing_since_gc.
459
d36d71df
DA
4602012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
461
462 Simplify and cleanup markers positioning code.
463 * marker.c (attach_marker): More useful eassert.
464 (live_buffer, set_marker_internal): New function.
465 (Fset_marker, set_marker_restricted): Use set_marker_internal.
466 (set_marker_both, set_marker_restricted_both): Use live_buffer.
467
fb9ea40f
PE
4682012-07-22 Paul Eggert <eggert@cs.ucla.edu>
469
470 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
471 as it's limited by the amount of memory, not by INT_MAX.
472
2d5c5f7d
EZ
4732012-07-21 Eli Zaretskii <eliz@gnu.org>
474
07fb592e
EZ
475 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
476 in special-event-map. See the discussion at
477 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
478 for the reasons.
479
37a9eac8 480 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
2d5c5f7d
EZ
481 info.dwItemData. Fixes crashes on 64-bit Windows. Suggested by
482 Fabrice Popineau <fabrice.popineau@supelec.fr>.
483
c4328746
JD
4842012-07-21 Jan Djärv <jan.h.d@swipnet.se>
485
486 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 487 (conversationIdentifier): Return value is NSInteger.
784051c4 488 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 489
6e5d1c12
CY
4902012-07-21 Chong Yidong <cyd@gnu.org>
491
492 * window.c (decode_any_window): Signal an error if the window is
493 on a dead frame (Bug#11984).
494
9928463d
DA
4952012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
496
497 Add indirection counting to speed up Fkill_buffer.
498 * buffer.h (struct buffer): New member.
499 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
500 (Fmake_indirect_buffer): Set indirection counter to -1, increment
501 base buffer indirection counter.
502 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
503 (Fkill_buffer): Adjust indirection counters as needed, don't walk
504 through buffer list if indirection counter is 0.
505
f8643a6b
DA
5062012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
507
508 Extend the value returned by Fgarbage_collect with heap statistics.
509 * alloc.c (Qheap): New symbol.
510 (syms_of_alloc): DEFSYM it.
511 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
512 (Fmemory_free): Remove.
513 (syms_of_alloc): Don't defsubr it.
514 * buffer.c (Fcompact_buffer): Remove.
515 (syms_of_buffer): Don't defsubr it.
516
dac616ff
DA
5172012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
518
519 Make maybe_gc inline.
520 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
521 * lisp.h (consing_since_gc, gc_relative_threshold)
522 (memory_full_cons_threshold): Revert declaration.
523 (maybe_gc): Remove prototype, define as inline.
524 * alloc.c: Remove old commented-out code.
525 (consing_since_gc, gc_relative_threshold)
526 (memory_full_cons_threshold): Revert to global.
527 (maybe_gc): Remove.
528
d7ea76b4
DA
5292012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
530
531 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
532 * lisp.h (build_unibyte_string): New function.
533 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
534 * sysdep.c, w32fns.c, xfns.c: Use it.
535 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
536 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
537 Adjust users accordingly.
538 * font.h (font_open_by_name): Adjust prototype.
539
765e61e3
DA
5402012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
541
542 Cleanup calls to Fgarbage_collect.
543 * lisp.h (maybe_gc): New prototype.
544 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
545 Remove declarations.
546 * alloc.c (maybe_gc): New function.
547 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
548 Make them static.
549 * bytecode.c (MAYBE_GC): Use maybe_gc.
550 * eval.c (eval_sub, Ffuncall): Likewise.
551 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
552 to avoid dependency from auto-save feature.
553
52b852c7
PE
5542012-07-19 Paul Eggert <eggert@cs.ucla.edu>
555
556 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
557 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
558 'for_each_per_buffer_object_at'.
559 All uses changed. It's better to use upper-case for macros that
560 cannot be implemented as functions, to give the reader a clue
561 that they're special.
562
5db81e33
SM
5632012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
564
565 * alloc.c (Fgarbage_collect): Tweak docstring.
566
5b835e1d
DA
5672012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
568
569 Tweak the value returned from Fgarbage_collect again.
570 * alloc.c (Fgarbage_collect): New return value, as confirmed in
571 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
572 Adjust documentation.
573 (total_vector_bytes): Rename to total_vector_slots, adjust
574 accounting.
575 (total_free_vector_bytes): Rename to total_free_vector_slots,
576 adjust accounting.
577 (Qstring_bytes, Qvector_slots): New symbols.
578 (syms_of_alloc): DEFSYM them.
579
9cd47b72
DA
5802012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
581
582 Buffer compaction primitive which may be used from Lisp.
583 * buffer.c (compact_buffer, Fcompact_buffer): New function.
584 (syms_of_buffer): Register Fcompact_buffer.
585 * alloc.c (Fgarbage_collect): Use compact_buffer.
586 * buffer.h (compact_buffer): New prototype.
587 (struct buffer_text): New member.
588
d17337e5
DA
5892012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
590
591 New macro to iterate over all buffers, miscellaneous cleanups.
592 * lisp.h (all_buffers): Remove declaration.
593 * buffer.h (all_buffers): Add declaration, with comment.
594 (for_each_buffer): New macro.
595 * alloc.c (Fgarbage_collect, mark_object): Use it.
596 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
597 (init_buffer): Likewise.
598 * data.c (Fset_default): Likewise.
599 * coding.c (code_conversion_restore): Remove redundant check
600 for dead buffer.
601 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
602
60cfd278
AS
6032012-07-18 Andreas Schwab <schwab@linux-m68k.org>
604
605 Fix bug that created negative-length intervals.
606 * intervals.c (merge_interval_right, merge_interval_left):
607 Do not zero out this interval if it is absorbed by its children,
608 as this interval's total length doesn't change in that case. See
609 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
610
d06714cb
PE
6112012-07-18 Paul Eggert <eggert@cs.ucla.edu>
612
83713154
PE
613 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
614 when invoking (make-bool-vector N t) and N is a positive
615 multiple of 8 -- the last 8 bits were mistakenly cleared.
616
d06714cb
PE
617 Remove some struct layout assumptions in bool vectors.
618 * alloc.c (bool_header_size): New constant.
619 (header_size, word_size): Move earlier, as they're now used earlier.
620 Use 'word_size' in a few more places, where it's appropriate.
621 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
622 padding before the data member of a bool vector.
623 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
624 than doing the check by hand with an abort ().
625
464d5a5e
SM
6262012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
627
5fbc0409
SM
628 * eval.c (Fdefvar): Don't check constants since we only set the var if
629 it's not yet defined anyway (bug#11904).
630
464d5a5e
SM
631 * lisp.h (last_undo_boundary): Declare new var.
632 * keyboard.c (command_loop_1): Set it.
633 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
634 were auto-added by the command loop (bug#11774).
635
8dc2e44a
AS
6362012-07-18 Andreas Schwab <schwab@linux-m68k.org>
637
638 * w32font.c (Qsymbol): Remove local definition.
639 (syms_of_w32font): Don't DEFSYM it.
640
169925ec
DA
6412012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
642
643 Fix sweep_vectors to handle large bool vectors correctly.
644 * alloc.c (sweep_vectors): Account total_vector_bytes for
645 bool vectors larger than VBLOCK_BYTES_MAX.
646
5fbfb018
CY
6472012-07-18 Chong Yidong <cyd@gnu.org>
648
649 * frame.c (x_set_frame_parameters): Revert bogus change introduced
650 in 2012-05-25 commit by Paul Eggert (Bug#11738).
651
3ab6e069
DA
6522012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
653
654 Return more descriptive data from Fgarbage_collect.
655 Suggested by Stefan Monnier in
656 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
657 * alloc.c (bounded_number): New function.
658 (total_buffers, total_vectors): New variable.
659 (total_string_size): Rename to total_string_bytes, adjust users.
660 (total_vector_size): Rename to total_vector_bytes, adjust users.
661 (sweep_vectors): Account total_vectors and total_vector_bytes.
662 (Fgarbage_collect): New return value. Adjust documentation.
663 (gc_sweep): Account total_buffers.
664 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
665 (VECTOR_SIZE): Remove.
666 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
667 (Qinterval, Qmisc): New symbols.
668 (syms_of_data): Initialize them.
669 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
670 (Qcons, Qbuffer): New declarations.
671
6d02fe5b
PE
6722012-07-17 Paul Eggert <eggert@cs.ucla.edu>
673
674 * alloc.c (Fmemory_free): Account for memory-free's own storage.
675 Round up, not down. Improve doc.
676
b7ffe040
DA
6772012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
678
679 Restore old code in allocate_string_data to avoid Faset breakage.
680 Reported by Julien Danjou <julien@danjou.info> in
681 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
682 * alloc.c (allocate_string_data): Restore old code with minor
683 adjustments, fix comment to explain this subtle issue.
684
4dc7c8d5
SM
6852012-07-17 Eli Zaretskii <eliz@gnu.org>
686
687 Remove FILE_SYSTEM_CASE.
688 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
689
690 * fileio.c (FILE_SYSTEM_CASE): Don't define.
691 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
692 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
693 call-process-region passes it through expand-file-name.
694
695 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
696
6972012-07-17 Andreas Schwab <schwab@linux-m68k.org>
698
699 Fix crash when creating indirect buffer (Bug#11917)
700 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
701 Don't handle unbound variables specially if non-zero.
702 (Fbuffer_local_variables): Pass zero.
703 (clone_per_buffer_values): Pass non-zero.
704
7052012-07-17 Andreas Schwab <schwab@linux-m68k.org>
706
707 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
708 to make the loop interruptible.
709
7102012-07-17 Andreas Schwab <schwab@linux-m68k.org>
711
712 * gnutls.c (emacs_gnutls_handshake): Only retry if
713 GNUTLS_E_INTERRUPTED.
714
cce7fefc
DA
7152012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
716
717 Cleanup and convert miscellaneous checks to eassert.
718 * alloc.c (mark_interval): Fix comment, partially rephrase
719 old comment from intervals.h (see below).
720 * intervals.c (find_interval, adjust_intervals_for_insertion)
721 (delete_interval, adjust_intervals_for_deletion)
722 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
723 Convert to eassert.
724 (adjust_intervals_for_insertion, make_new_interval):
725 Remove obsolete and unused code.
726 * intervals.h (struct interval): Remove obsolete comment.
727 * textprotp.c (erase_properties): Remove unused code.
728 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
729 (Fremove_list_of_text_properties): Convert to eassert.
730
9ea10cc3
CY
7312012-07-17 Chong Yidong <cyd@gnu.org>
732
733 * editfns.c (Finsert_char): Doc fix.
734
3900d5de
DA
7352012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
736
737 Fix previous change to make Fmemory_free always accurate.
738 * alloc.c (make_interval): Update total_free_intervals.
739 (make_float): Likewise for total_free_floats.
740 (free_cons, Fcons): Likewise for total_free_conses.
741 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
742 Likewise for total_free_vector_bytes.
743 (Fmake_symbol): Likewise for total_free_symbols.
744 (bytes_free): Remove.
745
7098646f
DA
7462012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
747
748 Simple free memory accounting feature.
749 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
750 (sweep_vectors): Accumulate size of free vectors.
751 (Fgarbage_collect): Setup bytes_free.
752 (Fmemory_free): New function.
753 (syms_of_alloc): Register it.
754
22657b40
DA
7552012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
756
757 Cleanup overlays checking.
758 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
759 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
760 eassert and OVERLAYP.
761 (sort_overlays): Change to use OVERLAYP.
762
ddfc8813
RK
7632012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
764
765 * editfns.c (Finsert_char): Make it interactive, and make the
766 second arg optional. Copy interactive spec and docstring from
767 ucs-insert.
768
7c26cf3c
PE
7692012-07-17 Paul Eggert <eggert@cs.ucla.edu>
770
771 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
772 Unlike the other wrapped functions, fabs has an unspecified
773 effect on errno.
774
5d127af9
JD
7752012-07-16 Jan Djärv <jan.h.d@swipnet.se>
776
777 * nsterm.m (keyDown): Interpret flags without left/right bits
778 as the left key (Bug#11670).
779
6a0dd1d7
DA
7802012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
781
782 Remove empty and useless init functions.
783 * lisp.h (init_character_once, init_fns, init_image)
784 (init_filelock, init_sound): Remove prototype.
785 * character.c (init_character_once): Remove.
786 * filelock.c (init_filelock): Likewise.
787 * fns.c (init_fns): Likewise.
788 * image.c (init_image): Likewise.
789 * sound.c (init_sound): Likewise.
790 * emacs.c (main): Adjust accordingly.
791
7a6136fd
DA
7922012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
793
794 * gtkutil.h: Tiny cleanups.
795 (use_old_gtk_file_dialog): Remove useless declaration.
796 (xg_uses_old_file_dialog): Add suggested const attribute.
797
ce811ad9
EZ
7982012-07-15 Eli Zaretskii <eliz@gnu.org>
799
800 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
801 (bidi_paragraph_init): Use it to limit search forward for a strong
802 directional character in abnormally large paragraphs full of
803 neutral or weak characters. (Bug#11943)
804
c9adfeaa
SF
8052012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
806
807 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
808 the toolbar (Bug#9451).
809 (xg_make_tool_item): Give the widget event box a transparent
810 background.
811
fff62aa9
DA
8122012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
813
814 Cleanup basic allocation variables and functions.
815 * alloc.c (ignore_warnings, init_intervals, init_float)
816 (init_cons, init_symbol, init_marker): Remove.
817 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
818 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
819 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
820 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
821 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
822 (staticidx, init_alloc_once, init_strings, free_ablock):
823 Remove redundant initialization.
824 * fns.c (init_weak_hash_tables): Remove.
825 * lisp.h (init_weak_hash_tables): Remove prototype.
826
9730daca
DA
8272012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
828
829 Use zero_vector where appropriate.
830 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
831 accordingly.
832 * lisp.h (zero_vector): New declaration.
833 * font.c (null_vector): Remove.
834 (syms_of_font): Remove initialization and staticpro.
835 (font_list_entities, font_find_for_lface): Change to use zero_vector.
836 * keymap.c (Faccessible_keymaps): Likewise.
837
2e2d2a13
LL
8382012-07-15 Leo Liu <sdl.web@gmail.com>
839
840 * fringe.c: Fix typo in comments.
841
cd276f6e
LL
8422012-07-14 Leo Liu <sdl.web@gmail.com>
843
844 * fringe.c: Add a new bitmap exclamation-mark.
845
5a1131d9
EZ
8462012-07-14 Eli Zaretskii <eliz@gnu.org>
847
848 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
849
850 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
851 (HAVE_MENUS): Don't define, defined by editing config.in with
852 msdos/sed2v2.inp.
853 (GMALLOC_INHIBIT_VALLOC): Don't define.
854 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
855
22e983b7
JB
8562012-07-14 Juanma Barranquero <lekktu@gmail.com>
857
858 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
859
5b3f250f
GM
8602012-07-14 Glenn Morris <rgm@gnu.org>
861
862 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
863 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
864 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
865
33d63ff4
GM
8662012-07-13 Glenn Morris <rgm@gnu.org>
867
5b633342
GM
868 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
869
33d63ff4
GM
870 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
871 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
872
b55b9f85
JD
8732012-07-13 Jan Djärv <jan.h.d@swipnet.se>
874
0dc8cf50
JD
875 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
876 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
877 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
878 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
879 where appropriate.
880 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
881 as boolean expression.
882 (x_set_window_size): Remove unused variable toolbar.
883 (ns_get_color_default, ns_mod_to_lisp): Remove.
884 (ns_mouse_position): Remove unused variables xchar and ychar.
885 (ns_compute_glyph_string_overhangs): Remove unused variable face.
886 (ns_set_vertical_scroll_bar): Remove unused variable count.
887 (ns_delete_terminal): Remove unused variable i.
888 (ns_term_init): Remove unused variables r, g and b.
889 (mouseDown): Remove unused variable window.
890 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
891 (initFrameFromEmacs): Remove unused variable vbextra.
892 (mouseEntered): Remove unused variables p and dpyinfo.
893 (mouseExited): Remove unused variables p and r.
894 (ns_define_frame_cursor, ns_clear_frame_area)
895 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
896 (menuDown): Assign [sender tag] to variable and cast the variable.
897
898 * nsterm.h (menuDown): Add id as type to argument sender.
899 (ns_display_info_for_name): Add Lisp_Object argument.
900 (ns_term_init): Add Lisp_Object argument.
901 (ns_map_event_to_object): Add void argument.
902 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
903 prototype with arguments and only declare if __OBJC__.
904 (nxatoms_of_nsselect): Add void argument.
905 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
906 (ns_alloc_autorelease_pool): Add void argument.
907 (ns_release_autorelease_pool): Add void* argument.
908 (ns_get_defaults_value): Add const char* argument.
909
910 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
911 (initFromContents): Use SSDATA where appropriate.
912 (ns_update_menubar): Add braces to ambigous if-else.
913 (initWithTitle): Put () around assignment in if statement.
914 (ns_menu_show): Remove unused variables window and keymap.
915 (update_frame_tool_bar): Remove unused variable selected_p.
916 (initWithContentRect): Remove unused variable this_cmd_name.
917
918 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
919 appropriate.
920 (setXBMColor): Remove unused variable len.
921 (setPixmapData): Put () around assignment in loop statement.
922
923 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
924 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
925 where appropriate.
926 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
927 around assignment in loop statement.
928 (nsfont_open): Remove unused variable i.
929 (nsfont_open): Remove unused variable len.
930 (nsfont_draw): Remove unused variable cs.
931
932 * nsfns.m (x_set_icon_name, ns_set_name_internal)
933 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
934 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
935 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
936 (Fns_font_name, Fns_perform_service)
937 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
938 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
939 (ns_set_name): Remove unused variable view.
940 (x_set_menu_bar_lines): Remove unused variable olines.
941 (x_set_tool_bar_lines): Remove unused variable root_window.
942 (Fns_list_colors): Put () around assignment in while statement.
943 (Fns_perform_service): Remove unused variable len.
944 (Fns_display_usable_bounds): Remove unused variable top.
945 (syms_of_nsfns): Remove unused variable i.
946
b55b9f85
JD
947 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
948 memcpy (Bug#11907).
949
ed9265fc 9502012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
951
952 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
953 and free it with DestroyExceptionInfo (Bug#11558).
954
ef099b57
JB
9552012-07-13 Juanma Barranquero <lekktu@gmail.com>
956
957 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
958 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
959 Set here, not in nt/config.nt.
960
ea814a5d
EZ
9612012-07-13 Eli Zaretskii <eliz@gnu.org>
962
963 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
964 cursor overflow into the last glyph on display line when the right
965 fringe is off. (Bug#11832)
966
1a952767
PE
9672012-07-13 Paul Eggert <eggert@cs.ucla.edu>
968
969 * xdisp.c (produce_special_glyphs): Now static.
970 * dispextern.h (produce_special_glyphs): Remove decl.
971
983188fd
GM
9722012-07-13 Glenn Morris <rgm@gnu.org>
973
32fb4bb6
GM
974 * s/bsd-common, s/cygwin.h: Remove empty files.
975 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
976
983188fd
GM
977 * s/usg5-4-common.h (USG, USG5):
978 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
979 * s/sol2-6.h (SOLARIS2):
980 * s/irix6-5.h (IRIX6_5):
981 * s/hpux10-20.h (USG, USG5, HPUX):
982 * s/gnu-linux.h (USG, GNU_LINUX):
983 * s/freebsd.h (BSD_SYSTEM):
984 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
985 * s/cygwin.h (CYGWIN):
986 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
987 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
988
d1e68667 9892012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
990
991 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 992
6de0e799
GM
9932012-07-13 Glenn Morris <rgm@gnu.org>
994
739ae010
GM
995 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
996
dbee5793
GM
997 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
998
6de0e799
GM
999 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
1000 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
1001
b82da769
GM
10022012-07-12 Glenn Morris <rgm@gnu.org>
1003
4fae5a7a 1004 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
1005
1006 * process.c (init_process_emacs): Rename from init_process.
1007 The old name is also the name of a Mach system call.
1008 * lisp.h, emacs.c: Update for this name change.
1009 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
1010 longer needed.
1011
5a979817
EZ
10122012-07-12 Eli Zaretskii <eliz@gnu.org>
1013
1014 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
1015 memmove call that removes glyphs covered by the left truncation
1016 glyph. Improve commentary.
1017 (display_line): Fix display of continuation glyphs on GUI frames
1018 when the right fringe is turned off and variable-size fonts are
1019 used in the window. Move the code that appends a stretch glyph to
1020 produce_special_glyphs, so that it could be used for truncation
1021 and continuation glyphs alike.
1022 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
1023 glyph of a suitably computed width, to align the special glyphs at
1024 the window margin. Code moved from display_line. (Bug#11832)
1025
3e91a053
GM
10262012-07-12 Glenn Morris <rgm@gnu.org>
1027
ba9e4b84
GM
1028 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
1029
1030 * s/gnu-linux.h, s/hpux10-20.h:
1031 Do not unconditionally define HAVE_XRMSETDATABASE.
1032
3e91a053
GM
1033 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
1034
b300b1f4
PE
10352012-07-12 Paul Eggert <eggert@cs.ucla.edu>
1036
1037 Fix typos that broke OS X build.
1038 Reported by Randal L. Schwartz in
1039 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
1040 * nsterm.m (ns_timeout): Add missing local decl.
1041 (ns_get_color): snprintf -> sprintf, to fix typo.
1042
6e777848
GM
10432012-07-12 Glenn Morris <rgm@gnu.org>
1044
3f922c37
GM
1045 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
1046 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
1047 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
1048 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
1049
0ab7b23a
GM
1050 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
1051 Move PTY_OPEN to configure.
1052
6e777848
GM
1053 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1054 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
1055 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
1056
4a7edc24
DA
10572012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
1058
1059 Use empty_unibyte_string where applicable.
1060 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
1061 * lread.c (read1): Likewise.
1062 * xsettings.c (syms_of_xsettings): Likewise.
1063
308aab79
GM
10642012-07-12 Glenn Morris <rgm@gnu.org>
1065
42bd1719
GM
1066 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
1067 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
1068 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
1069 * s/hpux10-20.h (RUN_TIME_REMAP):
1070 * s/bsd-common.h (TABDLY): Move to configure.
1071
1072 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
1073
1074 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
1075
ea0bbd17 1076 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 1077 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
1078
1079 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 1080
308aab79
GM
1081 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
1082 * s/template.h: Move NARROWPROTO to configure.
1083
ee1cf5cf
GM
10842012-07-11 Glenn Morris <rgm@gnu.org>
1085
30fe9bf4
GM
1086 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
1087 unused since 2011-01-17 change to systty.h.
1088
ee1cf5cf
GM
1089 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
1090 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1091 Move HAVE_PTYS and HAVE_SOCKETS to configure.
1092
63e47e07
PE
10932012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1094
1095 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
1096
c43fb4c3
GM
10972012-07-11 Glenn Morris <rgm@gnu.org>
1098
1099 * s/darwin.h, s/gnu-linux.h, s/template.h:
1100 Move INTERRUPT_INPUT to configure.
1101
e8df9267
DA
11022012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1103
1104 Minor adjustments to interning code.
1105 * lisp.h (intern, intern_c_string): Redefine as static inline
1106 wrappers for intern_1 and intern_c_string_1, respectively.
1107 (intern_1, intern_c_string_1): Rename prototypes.
2bce5643
DA
1108 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
1109 Vobarray checking.
e8df9267
DA
1110 * font.c (font_intern_prop): Likewise. Adjust comment.
1111 * w32font.c (intern_font_name): Likewise.
1112
34348bd4
AS
11132012-07-11 Andreas Schwab <schwab@linux-m68k.org>
1114
d96a1e0c
AS
1115 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
1116
34348bd4
AS
1117 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
1118 of Fcar/Fcdr if possible.
1119 * font.c (check_otf_features): Likewise.
1120 * fontset.c (Fnew_fontset): Likewise.
1121 * gnutls.c (Fgnutls_boot): Likewise.
1122 * minibuf.c (read_minibuf): Likewise.
1123 * msdos.c (IT_set_frame_parameters): Likewise.
1124 * xmenu.c (Fx_popup_dialog): Likewise.
1125 * w32menu.c (Fx_popup_dialog): Likewise.
1126
c8add24e
GM
11272012-07-11 Glenn Morris <rgm@gnu.org>
1128
4b575b3c
GM
1129 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
1130 since nothing has defined it on these platforms.
1131
09f4e3b0
GM
1132 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
1133 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
1134
172bedef
GM
1135 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1136 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1137 Move CLASH_DETECTION to configure.
1138
249685df
GM
1139 * s/gnu.h: Remove file, which is now empty.
1140
c8add24e
GM
1141 * s/gnu.h, s/gnu-linux.h:
1142 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
1143
b41253a3
JW
11442012-07-11 John Wiegley <johnw@newartisans.com>
1145
1146 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
1147 function attribute, so we only use it if it exists in the
1148 compiler.
1149
d923b542
DA
11502012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1151
1152 Avoid call to strlen in fast_c_string_match_ignore_case.
1153 * search.c (fast_c_string_match_ignore_case): Change to use
1154 length argument. Adjust users accordingly.
1155 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
1156
5ebbef1d
PE
11572012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1158
bb352260
PE
1159 Assume mkdir, rmdir.
1160 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
1161 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
1162
57054ddd
PE
1163 Assume rename.
1164 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
1165
b747d3f7
PE
1166 Assume perror.
1167 * s/hpux10-20.h (HAVE_PERROR): Remove.
1168 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
1169 Remove dummy definition, as this problem was obsolete long ago.
1170
5ebbef1d
PE
1171 Assume strerror.
1172 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
1173
984e7f30
DA
11742012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1175
1176 Avoid calls to strlen in font processing functions.
1177 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
d923b542 1178 (font_open_by_name): Change to use length argument. Adjust
984e7f30 1179 users accordingly.
d923b542
DA
1180 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
1181 Adjust prototypes.
1182 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
1183 Change to return ptrdiff_t.
984e7f30
DA
1184 (xfont_list_pattern, xfont_match): Use length returned by
1185 xfont_decode_coding_xlfd.
1186 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
1187
20e94fdd
GM
11882012-07-11 Glenn Morris <rgm@gnu.org>
1189
9d596af3
GM
1190 * s/darwin.h, s/freebsd.h, s/netbsd.h:
1191 Move DONT_REOPEN_PTY to configure.
1192
20e94fdd
GM
1193 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
1194 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
1195
e99a530f
PE
11962012-07-10 Paul Eggert <eggert@cs.ucla.edu>
1197
22ffb973
PE
1198 Remove "#define unix" that is no longer needed (Bug#11905).
1199 * s/aix4-2.h (unix): Remove; no longer needed.
1200
e9a9ae03
PE
1201 EMACS_TIME simplification (Bug#11875).
1202 This replaces macros (which typically do not work in GDB)
1203 with functions, typedefs and enums, making the code easier to debug.
1204 The functional style also makes code easier to read and maintain.
1205 * systime.h: Include <sys/time.h> on all hosts, not just if
1206 WINDOWSNT, since 'struct timeval' is needed in general.
1207 (EMACS_TIME): Now a typedef, not a macro.
1208 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
1209 not macros.
1210 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
1211 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
1212 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
1213 (EMACS_TIME_LE): Now functions, not macros.
1214 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
1215 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
1216 which are not functions. All uses rewritten to use:
1217 (make_emacs_time): New function.
1218 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
1219 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
1220 not functions. All uses rewritten to use the following, respectively:
1221 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
1222 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 1223 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
1224 * fileio.c (Fcopy_file):
1225 * xterm.c (XTflash): Get the current time closer to when it's used.
1226 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
1227
ffacb126
PE
1228 * bytecode.c (targets): Suppress -Woverride-init warnings.
1229
e99a530f
PE
1230 Simplify by avoiding confusing use of strncpy etc.
1231 * doc.c (Fsnarf_documentation):
1232 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
1233 * frame.c (Fmake_terminal_frame):
1234 * gtkutil.c (get_utf8_string):
1235 * lread.c (openp):
1236 * nsmenu.m (ns_update_menubar):
1237 * regex.c (regerror):
1238 Prefer memcpy to strncpy and strncat when either will do.
1239 * fileio.c (Fsubstitute_in_file_name):
1240 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
1241 (menu_separator_name_p):
1242 * nsmenu.m (ns_update_menubar):
1243 Prefer memcmp to strncmp when either will do.
1244 * nsterm.m: Include <ftoastr.h>.
1245 (ns_get_color):
1246 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
1247 Prefer snprintf to strncpy.
1248 * nsterm.m (ns_term_init):
1249 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
1250 * nsterm.m (ns_term_init):
1251 Avoid the need for strncpy, by using build_string or
1252 make_unibyte_string directly. Use dtoastr, not snprintf.
1253 * process.c (Fmake_network_process): Diagnose service names that
1254 are too long, rather than silently truncating them or creating
1255 non-null-terminated names.
1256 (Fnetwork_interface_info): Likewise, for interface names.
1257 * sysdep.c (system_process_attributes) [GNU_LINUX]:
1258 Prefer sprintf to strncat.
1259 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
1260 Prefer vsnprintf to vsprintf + strncpy.
1261
c59592b3
GM
12622012-07-10 Glenn Morris <rgm@gnu.org>
1263
1264 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
1265 Clarify fallback case.
1266
7d7bbefd
DA
12672012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1268
1269 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
1270 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
1271 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 1272 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
1273 where argument type is known to be a Lisp_Cons.
1274
3a4c8000
TT
12752012-07-10 Tom Tromey <tromey@redhat.com>
1276
1277 * bytecode.c (BYTE_CODE_THREADED): New macro.
1278 (BYTE_CODES): New macro. Replaces all old byte-code defines.
1279 (enum byte_code_op): New type.
1280 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
1281 (exec_byte_code): Use them. Use token threading when applicable.
1282
2a0213a6
DA
12832012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1284
1285 Optimize pure C strings initialization.
1286 * lisp.h (make_pure_string): Fix prototype.
1287 (build_pure_c_string): New function, defined as static inline. This
1288 provides a better opportunity to optimize away calls to strlen when
1289 the function is called with compile-time constant argument.
1290 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
1291 argument, adjust users accordingly. Use build_pure_c_string where
1292 appropriate.
1293 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
1294 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
1295 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
1296
cb1caeaf
DA
12972012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1298
1299 Avoid calls to strlen in miscellaneous functions.
1300 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
1301 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
1302 * lread.c (openp): Likewise.
1303
c293e30c
DA
13042012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1305
1306 Avoid calls to strlen in path processing functions.
1307 * fileio.c (file_name_as_directory): Add comment. Change to add
1308 srclen argument and return the length of result. Adjust users
1309 accordingly.
1310 (directory_file_name): Fix comment. Change to add srclen argument,
cb1caeaf 1311 swap 1st and 2nd arguments to obey the common convention. Adjust
c293e30c
DA
1312 users accordingly.
1313 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
1314
9e059e3f
GM
13152012-07-10 Glenn Morris <rgm@gnu.org>
1316
d02eb359
GM
1317 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
1318 Move PENDING_OUTPUT_COUNT definition to configure.
1319
882cf227
GM
1320 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
1321 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
1322 * s/gnu.h (DATA_START): Move definitions to configure.
1323
af6e839f
GM
1324 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
1325 We include usg5-4-common.h, which defines them both.
1326
40289a12
GM
1327 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
1328 O_RDONLY already includes it).
1329
9e059e3f
GM
1330 Stop ns builds setting the EMACSLOADPATH environment variable.
1331 * nsterm.m (ns_load_path): Rename from ns_init_paths.
1332 Now it does not set EMACSLOADPATH, just returns the load-path string.
1333 * nsterm.h: Update accordingly.
1334 * lread.c [HAVE_NS]: Include nsterm.h.
1335 (init_lread) [HAVE_NS]: Use ns_load_path.
1336 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
1337
7c4e8ec0
GM
13382012-07-09 Glenn Morris <rgm@gnu.org>
1339
d4f600ff
GM
1340 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
1341 since the included bsd-common.h does so.
1342
cbb31951
GM
1343 Stop ns builds setting the EMACSPATH environment variable.
1344 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
1345 (ns_init_paths): Do not set EMACSPATH.
1346 * nsterm.h (ns_exec_path): Add it.
1347 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
1348 Use ns_exec_path.
1349
7c4e8ec0
GM
1350 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
1351
26bccfae
PE
13522012-07-09 Paul Eggert <eggert@cs.ucla.edu>
1353
a0bee46f
PE
1354 * process.c (wait_reading_process_output): 'waitchannels' was unset
1355 when read_kbd || !NILP (wait_for_cell); fix this.
1356
5994c183
PE
1357 Add GCC-style 'const' attribute to functions that can use it.
1358 * character.h (char_resolve_modifier_mask):
1359 * keyboard.h (make_ctrl_char):
1360 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
1361 (init_character_once, next_almost_prime, init_fns, init_image)
1362 (flush_pending_output, init_sound):
1363 * mem-limits.h (start_of_data):
1364 * menu.h (finish_menu_items):
1365 Add ATTRIBUTE_CONST.
1366 * emacs.c (DEFINE_DUMMY_FUNCTION):
1367 Declare the dummy function with ATTRIBUTE_CONST.
1368 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
1369 Add decls with ATTRIBUTE_CONST.
1370
26bccfae
PE
1371 Minor improvements to make_formatted_string.
1372 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
1373 where int is good enough, as vsprintf returns an int.
1374 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
1375
a8290ec3
DA
13762012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1377
1378 Use make_formatted_string to avoid double length calculation.
1379 * lisp.h (make_formatted_string): New prototype.
1380 * alloc.c (make_formatted_string): New function.
1381 * buffer.c (Fgenerate_new_buffer_name): Use it.
1382 * dbus.c (syms_of_dbusbind): Likewise.
1383 * editfns.c (Fcurrent_time_zone): Likewise.
1384 * filelock.c (get_boot_time): Likewise.
1385 * frame.c (make_terminal_frame, set_term_frame_name)
1386 (x_report_frame_params): Likewise.
1387 * image.c (gs_load): Likewise.
1388 * minibuf.c (get_minibuffer): Likewise.
1389 * msdos.c (dos_set_window_size): Likewise.
1390 * process.c (make_process): Likewise.
1391 * xdisp.c (ensure_echo_area_buffers): Likewise.
1392 * xsettings.c (apply_xft_settings): Likewise.
1393
d01ba2f1
GM
13942012-07-09 Glenn Morris <rgm@gnu.org>
1395
1396 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
1397 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
1398 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
1399 * nsterm.h (ns_etc_directory): Add it.
1400 * callproc.c [HAVE_NS]: Include nsterm.h.
1401 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
1402
f1f924b6
DA
14032012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1404
1405 Move marker debugging code under MARKER_DEBUG.
1406 * marker.c (MARKER_DEBUG): Move marker debugging code under
1407 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
1408 for bootstrap with --enable-checking (~3x slowdown reported
1409 by Juanma Barranquero <lekktu@gmail.com>).
1410 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
1411
ab531b66
PE
14122012-07-08 Paul Eggert <eggert@cs.ucla.edu>
1413
1414 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
1415 See <http://bugs.gnu.org/11825#29>.
1416
c4b3bc8a
EZ
14172012-07-08 Eli Zaretskii <eliz@gnu.org>
1418
1419 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
1420 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
1421 (display_line): Add commentary about displaying truncation glyphs
1422 on GUI frames.
1423 (produce_special_glyphs): Move here from term.c.
1424
1425 * term.c (produce_special_glyphs): Move to xdisp.c.
1426
1427 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
1428 section.
c4b3bc8a 1429
b676b881
AS
14302012-07-07 Andreas Schwab <schwab@linux-m68k.org>
1431
f17c5273
AS
1432 * xdisp.c (display_line): Avoid warning about implicit declaration
1433 of FRAME_FONT.
1434
298819b9
AS
1435 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
1436
b676b881
AS
1437 * lisp.h: Remove empty conditional.
1438
6045c4fd
PE
14392012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1440
b3350bf9
PE
1441 * lread.c (load_path_check): Now static.
1442
6045c4fd
PE
1443 Fix some minor --with-ns problems found by static checking.
1444 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
1445 (x_set_font) [!HAVE_X_WINDOWS]:
1446 * image.c (xpm_load_image) [HAVE_NS]:
1447 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
1448 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
1449 Remove unused local.
1450 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
1451 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
1452 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
1453 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
1454 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
1455 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
1456 Fix pointer signedness problem.
1457 * xfaces.c (FRAME_X_FONT_TABLE):
1458 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
1459
929e7845
GM
14602012-07-07 Glenn Morris <rgm@gnu.org>
1461
1462 * lread.c (load_path_check): New function, split from init_lread.
1463 (init_lread): Reorganize. Motivation:
1464 If EMACSLOADPATH is set, check/warn about that rather than the
1465 defaults, which we are not going to use. Hence we can remove
1466 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
1467 Don't warn if site-lisp directories are missing.
1468 If not installed, start from a blank load-path, since
1469 PATH_LOADSEARCH refers to the eventual installation directories.
1470
58dd0aa4
EZ
14712012-07-07 Eli Zaretskii <eliz@gnu.org>
1472
1473 Support truncation and continuation glyphs on GUI frames, when
1474 fringes are disabled. (Bug#11832)
1475 * xdisp.c (init_iterator): Get dimensions of truncation and
1476 continuation glyphs even if on GUI frames. Adjust
1477 it->last_visible_x on GUI frames when the left or right fringes,
1478 or both, are absent.
1479 (start_display, move_it_in_display_line_to): Handle the case of a
1480 GUI frame without a fringe to display continuation or truncation
1481 glyphs.
1482 (insert_left_trunc_glyphs): Support GUI frames: make sure
1483 truncation glyphs overwrite enough glyphs from the current line to
1484 have sufficient space in pixels.
1485 (display_line): Support truncation and continuation glyphs on GUI
1486 frames. If some spare pixels are left on the line after inserting
1487 the truncation glyphs, fill that space with a stretch glyph of a
1488 suitably computed width.
1489
1490 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
1491 produce_glyphs, to support GUI sessions.
1492
31571fd7
PE
14932012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1494
5a16b9bc
PE
1495 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
1496
f3047c75
PE
1497 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
1498
31571fd7
PE
1499 Do not require float-time's arg to fit in time_t (Bug#11825).
1500 This works better on hosts where time_t is unsigned, and where
1501 float-time is applied to the (negative) difference between two times.
1502 * editfns.c (decode_time_components): Last arg is now double *,
1503 not int *, and means to store all the result as a double, without
1504 worrying about whether the seconds part fits in time_t.
1505 All callers changed.
1506 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
1507 All callers changed.
1508 (Ffloat_time): Do not fail merely because the specified time falls
1509 outside of time_t range.
1510
4516fbef
GM
15112012-07-07 Glenn Morris <rgm@gnu.org>
1512
1513 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
1514 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
1515 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
1516
07adc2c6
JB
15172012-07-07 Juanma Barranquero <lekktu@gmail.com>
1518
1519 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
1520 Update dependencies.
1521
1522 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
1523
fd573f31
PE
15242012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1525
fee5959d
PE
1526 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
1527 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
1528 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
1529 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
1530 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
1531 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
1532
fd573f31
PE
1533 * xfont.c (compare_font_names): Redo to omit the need for casts.
1534
ddadbc0e
AS
15352012-07-06 Andreas Schwab <schwab@linux-m68k.org>
1536
fca8d6b6
AS
1537 * xfns.c (Fx_change_window_property): Doc fix.
1538 * w32fns.c (Fx_change_window_property): Doc fix.
1539
ddadbc0e
AS
1540 * w32fns.c (Fx_window_property): Accept the same arguments as the
1541 X Windows version. Doc fix.
1542 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
1543
ed9265fc 15442012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
1545 Eli Zaretskii <eliz@gnu.org>
1546
1547 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
1548 Windows-specific code from nt/config.nt moved here.
1549 Obsolete settings removed.
1550
216ee680
PE
15512012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1552
1553 * process.c: Avoid unnecessary calls to gettime.
1554 (wait_reading_process_output): Don't get the time of day
1555 when gobbling data immediately and not waiting, as there's no need
1556 for it in that case. This removes a FIXME.
1557
bdd091e4
JD
15582012-07-06 Jan Djärv <jan.h.d@swipnet.se>
1559
1560 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
1561 is defined (Bug#11768).
1562
9d44f8ce
DA
15632012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1564
1565 Fix marker debugging code.
1566 * marker.c (byte_char_debug_check): Do not perform the check
1567 if buffer is not multibyte.
090bd7cb
JB
1568 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1569 Call byte_char_debug_check with correct arguments.
9d44f8ce 1570
90fc4786
DA
15712012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1572
1573 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
1574 * marker.c (byte_char_debug_check, count_markers):
1575 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
1576 (byte_debug_flag): Remove.
1577 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1578 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
1579
7b7ae965
DA
15802012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1581
4e57b342
DA
1582 Avoid code repetition in marker-related functions.
1583 * marker.c (attach_marker): New function.
1584 (Fset_marker, set_marker_restricted, set_marker_both)
1585 (set_marker_restricted_both): Use it.
1586 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
1587 Consistently rename charno to charpos.
1588 (marker_position): Add eassert.
1589 (marker_byte_position): Convert to eassert.
1590
15912012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1592
1593 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 1594 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 1595 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 1596
657924ff
DA
15972012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1598
1599 Introduce fast path for the widely used marker operation.
1600 * alloc.c (build_marker): New function.
1601 * lisp.h (build_marker): New prototype.
1602 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
1603 * composite.c (autocmp_chars): Likewise.
1604 * editfns.c (buildmark): Remove.
1605 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
1606 (save_restriction_save): Use build_marker.
1607 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
1608 * window.c (save_window_save): Likewise.
1609
041a49a6
DA
16102012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1611
1612 Do not use Fdelete_overlay in delete_all_overlays
1613 to avoid redundant calls to unchain_overlay.
1614 * buffer.c (drop_overlay): New function.
1615 (delete_all_overlays, Fdelete_overlay): Use it.
1616 * minibuf.c (get_minibuffer): Fix comment.
1617
7dca65a4
PE
16182012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1619
1620 Port to OpenBSD 5.1 amd64.
1621 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
1622 This is needed for OpenBSD, and should be harmless on all BSD systems.
1623 Also, include <sys/sysctl.h>, as it should be available on all
1624 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
1625 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
1626 use p_pid member, not kp_proc.pid.
1627
8eb876e2
GM
16282012-07-06 Glenn Morris <rgm@gnu.org>
1629
1630 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
1631
38182d90
PE
16322012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1633
1634 More xmalloc and related cleanup.
1635 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
1636 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
1637 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
1638 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
1639 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
1640 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
1641 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
1642 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
1643 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
1644 * xterm.c:
1645 Omit needless casts involving void * pointers and allocation.
1646 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
1647 as the former is more robust if P's type is changed.
1648 Prefer xzalloc to xmalloc + memset 0.
1649 Simplify malloc-or-realloc to realloc.
1650 Don't worry about xmalloc returning a null pointer.
1651 Prefer xstrdup to xmalloc + strcpy.
1652 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
1653 growing it.
1654 * keyboard.c (apply_modifiers_uncached): Prefer local array to
1655 alloca of a constant.
1656
6dd5a677
EZ
16572012-07-05 Eli Zaretskii <eliz@gnu.org>
1658
1659 * xdisp.c (display_line): Fix horizontal pixel coordinates when
1660 hscroll is larger than the line width. Fixes long and futile
1661 looping inside extend_face_to_end_of_line (on a TTY) producing
1662 glyphs that are not needed and thrown away.
1663
6b312f0f
DA
16642012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1665
1666 * marker.c (set_marker_restricted_both): Simplify by using
1667 clip_to_bounds.
1668
f520ef9b
PE
16692012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1670
1671 * editfns.c (region_limit): Simplify by using clip_to_bounds.
1672
383b7c95
JD
16732012-07-05 Jan Djärv <jan.h.d@swipnet.se>
1674
1675 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
1676 not defined (Bug#11768).
1677 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
1678 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
1679 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
1680 followed by gtk_box_set_homogeneous (Bug#11768).
1681 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
1682 (update_theme_scrollbar_width, xg_create_scroll_bar):
1683 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
1684 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
1685 (is_box_type): New function (Bug#11768).
1686 (xg_tool_item_stale_p): Call is_box_type.
5293d758 1687 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
1688 with default display (Bug#11768).
1689
d6e7bf45
EZ
16902012-07-05 Eli Zaretskii <eliz@gnu.org>
1691
1692 * xdisp.c (window_hscroll_limited): New function.
1693 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
1694 coordinates when window's hscroll is set to insanely large
1695 values. (Bug#11857)
1696
431391ec
JB
16972012-07-05 Juanma Barranquero <lekktu@gmail.com>
1698
1699 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
1700 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
1701
23f86fce
DA
17022012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1703
1704 Cleanup xmalloc.
1705 * lisp.h (xzalloc): New prototype. Omit needless casts.
1706 * alloc.c (xzalloc): New function. Omit needless casts.
1707 * charset.c: Omit needless casts. Convert all calls to
1708 xmalloc with following memset to xzalloc.
1709 * dispnew.c: Likewise.
1710 * fringe.c: Likewise.
1711 * image.c: Likewise.
1712 * sound.c: Likewise.
1713 * term.c: Likewise.
1714 * w32fns.c: Likewise.
1715 * w32font.c: Likewise.
1716 * w32term.c: Likewise.
1717 * xfaces.c: Likewise.
1718 * xfns.c: Likewise.
1719 * xterm.c: Likewise.
1720 * atimer.c: Omit needless casts.
1721 * buffer.c: Likewise.
1722 * callproc.c: Likewise.
1723 * ccl.c: Likewise.
1724 * coding.c: Likewise.
1725 * composite.c: Likewise.
1726 * doc.c: Likewise.
1727 * doprnt.c: Likewise.
1728 * editfns.c: Likewise.
1729 * emacs.c: Likewise.
1730 * eval.c: Likewise.
1731 * filelock.c: Likewise.
1732 * fns.c: Likewise.
1733 * gtkutil.c: Likewise.
1734 * keyboard.c: Likewise.
1735 * lisp.h: Likewise.
1736 * lread.c: Likewise.
1737 * minibuf.c: Likewise.
1738 * msdos.c: Likewise.
1739 * print.c: Likewise.
1740 * process.c: Likewise.
1741 * region-cache.c: Likewise.
1742 * search.c: Likewise.
1743 * sysdep.c: Likewise.
1744 * termcap.c: Likewise.
1745 * terminal.c: Likewise.
1746 * tparam.c: Likewise.
1747 * w16select.c: Likewise.
1748 * w32.c: Likewise.
1749 * w32reg.c: Likewise.
1750 * w32select.c: Likewise.
1751 * w32uniscribe.c: Likewise.
1752 * widget.c: Likewise.
1753 * xdisp.c: Likewise.
1754 * xmenu.c: Likewise.
1755 * xrdb.c: Likewise.
1756 * xselect.c: Likewise.
1757
0497dc44
PE
17582012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1759
1760 * fileio.c (time_error_value): Check the right error number.
1761 Problem reported by Troels Nielsen in
1762 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
1763
356e7178
PE
17642012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1765
4e71fd89
PE
1766 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
1767 This should be fixed in a better way; see Eli Zaretskii in
1768 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
1769 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
1770
f0941253
PE
1771 * fileio.c (time_error_value): Rename from special_mtime.
1772 The old name's problems were noted by Eli Zaretskii in
1773 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
1774
065c9eb4
PE
1775 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
1776 This variable's comment says Emacs needs at least one GDB-visible
1777 symbol of type enum pvec_type, to work around GDB problems.
1778 The symbol's value doesn't matter.
1779
356e7178
PE
1780 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
1781 that causes compilation to fail on pre-C99 compilers.
1782
ed9265fc 17832012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
1784
1785 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
1786 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
1787
3884d954
DA
17882012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1789
d209e2fb 1790 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
1791 headers for buffer_defaults and buffer_local_symbols.
1792 Reported by Juanma Barranquero <lekktu@gmail.com>.
1793
ee28be33
SM
17942012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1795
1796 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
1797 * lisp.h (enum pvec_type): Use fewer bits.
1798 (PSEUDOVECTOR_SIZE_BITS): New constant.
1799 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
1800 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
1801 change in pvec_type.
1802 (PSEUDOVECTOR_TYPEP): New macro.
1803 (TYPED_PSEUDOVECTORP): Use it.
1804 * fns.c (internal_equal): Adapt code to extract pvectype.
1805 * emacs.c (gdb_pvec_type): Update type.
1806 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
1807 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
1808 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
1809 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
1810 (sweep_vectors): Use it. Use local var `total_bytes' instead of
1811 abusing vector->header.next.nbytes.
1812 (live_vector_p): Use PVEC_TYPE.
1813 (mark_object): Adapt code to extract pvectype. Use switch.
1814
c7f2cd7f
PE
18152012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1816
1817 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
1818 Tighten new eassert a bit.
1819
8ce70ed2
DA
18202012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1821
1822 Fix compilation with --enable-gcc-warnings and -O1
1823 optimization level.
1824 * doprnt.c (doprnt): Change type of tem to int, initialize
1825 to avoid compiler warning. Add eassert.
1826 * search.c (simple_search): Initialize match_byte to avoid
1827 compiler warning. Add eassert.
1828
dea7f1e5
PE
18292012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1830
24a212eb
PE
1831 Avoid weird behavior with large horizontal scrolls.
1832 Without this change, for example, large hscroll values would
1833 mess up Emacs's display on Fedora 15 x86, presumably due to
1834 overflows in int calculations in the display code.
1835 Also, if buffers had long lines, Emacs would freeze.
1836 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
1837 (set_window_hscroll): New function, containing the old guts of
1838 Fset_window_hscroll. Return the clipped value.
1839 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
1840 This avoids the need to check against PTRDIFF_MAX.
1841
dea7f1e5
PE
1842 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
1843
76046526
DA
18442012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1845
1846 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
1847
39adff0d
PE
18482012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1849
63807d47
PE
1850 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
1851 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
1852 since GCC 4.4.6 issues a bogus warning for them.
1853
39adff0d
PE
1854 Fix bugs in file timestamp newness comparisons.
1855 * fileio.c (Ffile_newer_than_file_p):
1856 * lread.c (Fload): Use full timestamp resolution of files,
1857 not just the 1-second resolution, so that files that are only
1858 slightly newer still count as newer.
1859 * fileio.c (Ffile_newer_than_file_p): Don't assume file
1860 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
1861
dbeed9a6
PE
18622012-07-03 Paul Eggert <eggert@cs.ucla.edu>
1863
1864 * fileio.c: Improve handling of file time marker. (Bug#11852)
1865 (special_mtime): New function.
1866 (Finsert_file_contents, Fverify_visited_file_modtime):
1867 Use it to set special mtime values consistently.
1868
636334d6
AS
18692012-07-03 Andreas Schwab <schwab@linux-m68k.org>
1870
1871 * fileio.c (Finsert_file_contents): Properly handle st_mtime
1872 marker for non-existing file. (Bug#11852)
1873
e2017fe2
GM
18742012-07-03 Glenn Morris <rgm@gnu.org>
1875
1876 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
1877 and did not make it into globals.h).
1878
404dbd37
TT
18792012-07-03 Tom Tromey <tromey@redhat.com>
1880
1881 * window.c (Fset_window_margins, Fset_window_fringes)
1882 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
1883 * textprop.c (Fprevious_property_change): No longer static.
1884 * syntax.c (Fsyntax_table_p): No longer static.
1885 * process.c (Fget_process, Fprocess_datagram_address): No longer
1886 static.
1887 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
1888 * keyboard.c (Fcommand_execute): No longer static.
1889 Remove EXFUN.
1890 * insdel.c (Fcombine_after_change_execute): No longer static.
1891 * image.c (Finit_image_library): No longer static.
1892 * fileio.c (Fmake_symbolic_link): No longer static.
1893 * eval.c (Ffetch_bytecode): No longer static.
1894 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
1895 * doc.c (Fdocumentation_property, Fsnarf_documentation):
1896 No longer static.
404dbd37
TT
1897 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
1898 static.
1899 * dired.c (Ffile_attributes): No longer static.
1900 * composite.c (Fcomposition_get_gstring): No longer static.
1901 * callproc.c (Fgetenv_internal): No longer static.
1902
1903 * ccl.h: Remove EXFUNs.
1904 * buffer.h: Remove EXFUNs.
1905 * dispextern.h: Remove EXFUNs.
1906 * intervals.h: Remove EXFUNs.
1907 * fontset.h: Remove EXFUN.
1908 * font.h: Remove EXFUNs.
1909 * dosfns.c (system_process_attributes): Remove EXFUN.
1910 * keymap.h: Remove EXFUNs.
1911 * lisp.h: Remove EXFUNs.
1912 * w32term.h: Remove EXFUNs.
1913 * window.h: Remove EXFUNs.
1914 * xsettings.h: Remove EXFUN.
1915 * xterm.h: Remove EXFUN.
1916
8e4fd1e1
GM
19172012-07-03 Glenn Morris <rgm@gnu.org>
1918
1919 * lisp.h (Frandom): Make it visible to C.
1920 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
1921 buffer for invisible buffers. (Bug#1229)
1922
ca95b3eb
DA
19232012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1924
1925 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
1926 values which aren't power of 2.
1927 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
1928 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
1929 accordingly.
1930
7555c33f
SM
19312012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
1932
1933 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
1934
1935 * alloc.c (mark_object): Revert part of last patch to use `switch'.
1936
d12e8f5a
DA
19372012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1938
1939 * alloc.c (allocate_vector_block): Remove redundant
1940 calls to mallopt if DOUG_LEA_MALLOC is defined.
1941 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
1942 avoid calls to mallopt if zero_vector is returned.
1943
296094c3
DA
19442012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1945
1946 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
1947 is enabled, avoid dereferencing NULL current_sblock if
1948 running undumped.
1949
36429c89
DA
19502012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1951
1952 Cleanup basic buffer management.
1953 * buffer.h (struct buffer): Change layout to use generic vector
1954 marking code. Fix some comments. Change type of 'clip_changed'
1955 to bitfield. Remove unused #ifndef old.
1956 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
1957 (GET_OVERLAYS_AT): Fix indentation.
1958 (for_each_per_buffer_object_at): New macro.
1959 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
1960 (Fbuffer_local_variables): Use it.
1961 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
1962 * alloc.c (allocate_buffer): Adjust to match new layout of
1963 struct buffer. Fix comment.
1964 (mark_overlay): New function.
1965 (mark_buffer): Use it. Use mark_vectorlike to mark normal
1966 Lisp area of struct buffer.
1967 (mark_object): Use it. Adjust marking of misc objects
1968 and related comments.
1969
3b3e4cac
PE
19702012-07-02 Paul Eggert <eggert@cs.ucla.edu>
1971
1972 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
1973 wrapper that is not needed because the wrapped code is a no-op (zero
1974 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
1975 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
1976
cf5c0175
DA
19772012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
1978
1979 * alloc.c (mark_buffer): Simplify. Remove prototype.
1980 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 1981 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
1982 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
1983 redundant calls to mark_vectorlike for bool vectors.
1984
ca26824c
GM
19852012-06-30 Glenn Morris <rgm@gnu.org>
1986
2e4c5312
GM
1987 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
1988
ca26824c
GM
1989 * epaths.in (PATH_SITELOADSEARCH): New.
1990 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
1991 This is rather than relying on --enable-locallisppath elements
1992 having "site-lisp" in their names. (Bug#10208#25, 11658)
1993
0d23c240
EZ
19942012-06-30 Eli Zaretskii <eliz@gnu.org>
1995
c9240d7a
EZ
1996 * w32proc.c (sys_select): Accept and ignore one more argument.
1997
1998 * w32.c (emacs_gnutls_pull): Call select with one more argument.
1999
0d23c240 2000 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 2001 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
2002
2003 * sysdep.c: Don't include dos.h and dosfns.h.
2004
2005 * process.c (sys_select):
2006 * msdos.c (sys_select): Accept one more argument and ignore it.
2007
2008 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
2009 adapt data types and code to that.
2010
2011 * dosfns.c:
2012 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
2013 which clashes with the gnulib function of the same name.
2014
af5a5a98
AS
20152012-06-30 Andreas Schwab <schwab@linux-m68k.org>
2016
c5e4379c
AS
2017 * font.c (font_style_to_value, font_style_symbolic)
2018 (font_prop_validate_style): Add type checks for values in
2019 font_style_table.
2020
af5a5a98
AS
2021 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
2022 argument.
2023 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
2024 uses.
2025
8d38f461
EZ
20262012-06-29 Eli Zaretskii <eliz@gnu.org>
2027
2e5a6631
EZ
2028 * xdisp.c (try_window_id): Undo last change.
2029
8d38f461
EZ
2030 * w32.c (getwd): Adjust commentary about startup_dir.
2031 (init_environment): Always call sys_access, even in non-MSVC
2032 builds. Don't chdir to the directory of the Emacs executable.
2033 This undoes code from 1997 which was justified by the need to
2034 "avoid conflicts when removing and renaming directories". But its
2035 downside was that every relative file name was being interpreted
2036 relative to the directory of the Emacs executable, which can never
2037 be TRT. In particular, it broke sys_access when called with
2038 relative file names.
2039 (sys_access): Map GetLastError to errno.
2040
2af3565e
DA
20412012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2042
2043 * window.h (struct window): Change type of 'fringes_outside_margins'
2044 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 2045 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
2046 Adjust comment.
2047 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
2048 to ptrdiff_t.
2049
c8d3a25c 20502012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 2051
c8d3a25c
GM
2052 * gnutls.c (emacs_gnutls_handshake):
2053 Add QUIT to make the loop interruptible.
57570cd3 2054
c8d3a25c 20552012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 2056
c8d3a25c
GM
2057 * charset.c (init_charset): Make lack of etc/charsets fatal.
2058
3e984ee8
DA
20592012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2060
2061 * editfns.c (region_limit): Fix type mismatch.
2062
ef884f23
DA
20632012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2064
2065 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
2066 undefined. Convert from xassert to eassert.
2067 * nsmenu.m: Convert from xassert to eassert.
2068 * nsterm.m: Likewise.
2069
7d7e0027
SM
20702012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
2071
2072 * editfns.c (region_limit): Clip to narrowing (bug#11770).
2073
aa754e6a
PE
20742012-06-28 Paul Eggert <eggert@cs.ucla.edu>
2075
2076 Avoid integer overflow on scroll-left and scroll-right.
2077 * window.c (HSCROLL_MAX): New macro.
2078 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
2079 overflow when requested scroll falls outside ptrdiff_t range.
2080
80b00b08
DA
20812012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2082
2083 * window.h (struct window): Change type of 'hscroll',
2084 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
2085 'last_modified' and 'last_overlay_modified' to EMACS_INT.
2086 Adjust users accordingly.
2087 * xdisp.c (try_cursor_movement): Replace type check with eassert.
2088 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
2089 from EMACS_INT to ptrdiff_t.
2090 (make_window): Omit redundant initialization.
2091
62b2bcf6
JB
20922012-06-28 Juanma Barranquero <lekktu@gmail.com>
2093
2094 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
2095
45942c7d
DA
20962012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2097
2098 * window.h (struct window): Change type of 'use_time' and
2099 'sequence_number' from Lisp_Object to int.
2100 * frame.c (make_frame): Adjust users accordingly.
2101 * print.c (print_object): Likewise.
2102 * window.c (select_window, Fwindow_use_time, make_parent_window)
2103 (make_window): Likewise.
2104
e509cfa6
DA
21052012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2106
2107 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
2108 enabled with --enable-checking=[all,glyphs] configure option.
2109 Fix GLYPH_DEBUG usage assuming that it may be undefined,
2110 adjust comments accordingly.
2111 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
2112 undefined, adjust comments accordingly.
2113 * image.c: Likewise.
2114 * scroll.c: Likewise.
2115 * w32fns.c: Likewise.
2116 * w32term.c: Likewise.
2117 * xdisp.c: Likewise.
2118 * xfaces.c: Likewise.
2119 * xfns.c: Likewise.
2120 * xterm.c: Likewise.
2121
a54e2c05
DA
21222012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2123
2124 Generalize run-time debugging checks.
2125 * dispextern.h (XASSERTS): Remove.
2126 * fontset.c (xassert): Remove.
2127 Convert from xassert to eassert.
2128 * alloc.c: Convert from xassert to eassert.
2129 * bidi.c: Likewise.
2130 * dispnew.c: Likewise.
2131 * fns.c: Likewise.
2132 * fringe.c: Likewise.
2133 * ftfont.c: Likewise.
2134 * gtkutil.c: Likewise.
2135 * image.c: Likewise.
2136 * keyboard.c: Likewise.
2137 * menu.c: Likewise.
2138 * process.c: Likewise.
2139 * scroll.c: Likewise.
2140 * sound.c: Likewise.
2141 * term.c: Likewise.
2142 * w32console.c: Likewise.
2143 * w32fns.c: Likewise.
2144 * w32term.c: Likewise.
2145 * window.c: Likewise.
2146 * xdisp.c: Likewise.
2147 * xfaces.c: Likewise.
2148 * xfns.c: Likewise.
2149 * xselect.c: Likewise.
2150 * xterm.c: Likewise.
2151
1ec4b7b2
SM
21522012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
2153
2154 * fns.c (maybe_resize_hash_table): Output message when growing the
2155 purify-hashtable.
2156
2014308a
DA
21572012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2158
2159 * alloc.c (allocate_string_data): Remove dead code.
2160 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
2161 avoid GCC warning about unused macro.
2162
246155eb
DA
21632012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2164
2165 * alloc.c (allocate_string): Omit intervals initialization.
2166 * alloc.c (make_uninit_multibyte_string): Initialize intervals
2167 as in make_pure_string and make_pure_c_string.
2168
43184b7b
DA
21692012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2170
d209e2fb 2171 * alloc.c (allocate_string): Fix last change.
43184b7b 2172
3fe6dd74
DA
21732012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2174
d209e2fb 2175 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
2176 to memset, add explicit initialization where appropriate.
2177
1ba6038a
GM
21782012-06-27 Glenn Morris <rgm@gnu.org>
2179
2180 * lisp.mk (lisp): Remove paths.elc.
2181
c89926a5
CY
21822012-06-27 Chong Yidong <cyd@gnu.org>
2183
2184 * doc.c (Fsubstitute_command_keys): Fix punctuation.
2185
ed6b3510
JW
21862012-06-26 John Wiegley <johnw@newartisans.com>
2187
1ec4b7b2 2188 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
2189 on Mac OS X Lion: __mod_init_func and __mod_term_func.
2190
ed6b3510
JW
2191 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
2192 when building with Clang.
2193
8edd4a2b
SM
21942012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
2195
2196 * eval.c (Fapply): Allow calling it with a single argument.
2197
f6f62d1b
EZ
21982012-06-26 Eli Zaretskii <eliz@gnu.org>
2199
2200 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
2201 _stricmp and _strnicmp.
2202 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
2203
62efea5e
DA
22042012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2205
2206 * alloc.c (allocate_window): Zero out non-Lisp part of newly
2207 allocated window.
2208 (allocate_process): Likewise for new process.
8edd4a2b 2209 (allocate_terminal): Change to use offsetof.
62efea5e
DA
2210 (allocate_frame): Likewise.
2211 * frame.c (make_frame): Omit redundant initialization.
2212 * window.c (make_parent_window): Use memset.
2213 (make_window): Omit redundant initialization.
2214 * process.c (make_process): Omit redundant initialization.
2215 * terminal.c (create_terminal): Likewise.
2216
42997f4d
DA
22172012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2218
2219 * term.c (delete_tty): Remove redundant call to memset.
2220
1130ecfc
DA
22212012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2222
2223 * alloc.c: Remove build_string.
2224 * lisp.h: Define build_string as static inline. This provides
2225 a better opportunity to optimize away calls to strlen when the
2226 function is called with compile-time constant argument.
2227 * image.c (imagemagick_error): Convert to build_string.
2228 * w32proc.c (sys_spawnve): Likewise.
2229 * xterm.c (x_term_init): Likewise.
2230
cf38a720
PE
22312012-06-26 Paul Eggert <eggert@cs.ucla.edu>
2232
99027bdd
PE
2233 Use sprintf return value instead of invoking strlen on result.
2234 In the old days this wasn't portable, since some sprintf
2235 implementations returned char *. But they died out years ago and
2236 Emacs already assumes sprintf returns int.
2237 Similarly for float_to_string.
2238 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
2239 * ccl.c (ccl_driver):
2240 * character.c (string_escape_byte8):
2241 * data.c (Fnumber_to_string):
2242 * doprnt.c (doprnt):
2243 * print.c (print_object):
2244 * xdisp.c (message_dolog):
2245 * xfns.c (syms_of_xfns):
2246 Use sprintf or float_to_string result to avoid need to call strlen.
2247 * data.c (Fnumber_to_string):
2248 Use make_unibyte_string, since the string must be ASCII.
2249 * lisp.h, print.c (float_to_string): Now returns int length.
2250 * term.c (produce_glyphless_glyph):
2251 Use sprintf result rather than recomputing it.
2252
cf38a720
PE
2253 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
2254 * Makefile.in (ALL_CFLAGS):
2255 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
2256 * gmalloc.c, regex.c: Include <config.h> unconditionally.
2257
3511c784
DA
22582012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2259
0a08eb21 2260 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
2261 strcasecmp if available.
2262 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
2263
fb7da12e
AS
22642012-06-25 Andreas Schwab <schwab@linux-m68k.org>
2265
2266 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
2267 Avoid comma operator.
2268 * menu.c (push_submenu_start, push_submenu_end)
2269 (push_left_right_boundary, push_menu_pane): Likewise.
2270 * msdos.c (dos_rawgetc): Likewise.
2271
afa2ffd8
DA
22722012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2273
2274 * xfns.c (xic_create_fontsetname): Remove redundant calls
2275 to memset.
2276
b3b4476b
PE
22772012-06-25 Paul Eggert <eggert@cs.ucla.edu>
2278
4495ff38
PE
2279 * gtkutil.c (get_utf8_string): Remove redundant assignment.
2280 sprintf already null-terminates its output.
2281
b3b4476b
PE
2282 * xfns.c (x_window): Remove redundant cast.
2283
b00876c9
DA
22842012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2285
2286 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
2287 `const char *' to `char *' to avoid compiler warning.
2288
d188e26b
PE
22892012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2290
885d1d74
PE
2291 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
2292 instead of truncating it to 63 (admittedly a generous limit).
2293
d188e26b
PE
2294 * process.c: Fix spelling and caps in comments.
2295
e2f560b1
DN
22962012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
2297
e86db54b 2298 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
2299 * sysdep.c (setpgrp): Remove definition, not used in this file.
2300
7583a3a1
JB
23012012-06-24 Juanma Barranquero <lekktu@gmail.com>
2302
2303 * makefile.w32-in: Update dependencies.
2304
696056c2
EZ
23052012-06-24 Eli Zaretskii <eliz@gnu.org>
2306
2307 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
2308 (SYSTIME_H): Add nt/inc/sys/time.h.
2309
2310 * systime.h [WINDOWSNT]: Include sys/time.h.
2311
2312 * s/ms-w32.h (struct timespec): Definition moved from
2313 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
2314
845ca893
PE
23152012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2316
2317 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
2318 * buffer.h (buffer_slot_type_mismatch):
2319 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2320 * eval.c (unwind_to_catch):
2321 * image.c (my_png_error, my_error_exit):
2322 * keyboard.c (quit_throw_to_read_char, user_error)
2323 (Fexit_recursive_edit, Fabort_recursive_edit):
2324 * lisp.h (die, args_out_of_range, args_out_of_range_3)
2325 (wrong_type_argument, buffer_overflow, __executable_start)
2326 (memory_full, buffer_memory_full, string_overflow, Fthrow)
2327 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
2328 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
2329 (fatal):
2330 (child_setup) [!DOS_NT]:
2331 * lread.c (end_of_file_error, invalid_syntax):
2332 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2333 * puresize.h (pure_write_error):
2334 * search.c (matcher_overflow):
2335 * sound.c (sound_perror, alsa_sound_perror):
2336 * sysdep.c, syssignal.h (croak):
2337 * term.c (maybe_fatal, vfatal):
2338 * textprop.c (text_read_only):
2339 * undo.c (user_error):
2340 * unexmacosx.c (unexec_error):
2341 * xterm.c (x_ins_del_lines, x_delete_glyphs):
2342 Use _Noreturn rather than NO_RETURN.
2343 No need for separate decl merely because of _Noreturn.
2344 * sound.c (sound_warning, parse_sound):
2345 Remove unnecessary forward decls.
2346
f1dd8073
PE
23472012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2348
2349 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
2350 * lisp.h (WAIT_READING_MAX): New macro.
2351 * dispnew.c (Fsleep_for, sit_for):
2352 * keyboard.c (kbd_buffer_get_event):
2353 * process.c (Faccept_process_output):
2354 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
2355 This improves on the previous patch, which introduced a bug
2356 when time_t is unsigned and as wide as intmax_t.
2357 See <http://bugs.gnu.org/9000#51>.
2358
b82c1755
EZ
23592012-06-23 Eli Zaretskii <eliz@gnu.org>
2360
2361 * dispnew.c (sit_for, Fsleep_for):
2362 * keyboard.c (kbd_buffer_get_event):
2363 * process.c (Faccept_process_output): Avoid compiler warnings when
2364 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
2365
ca300656
JB
23662012-06-23 Juanma Barranquero <lekktu@gmail.com>
2367
049ec95b
JB
2368 * makefile.w32-in: Update dependencies.
2369
ca300656
JB
2370 * w32.c (ltime): Add return type and declare static.
2371 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
2372
db7b8d06
PE
23732012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2374
2375 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
2376 Privately reported by Herbert J. Skuhra.
2377 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
2378 All uses changed.
2379 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
2380 not make_lisp_timeval, when the argument is of type EMACS_TIME.
2381
0bd8297f
EZ
23822012-06-23 Eli Zaretskii <eliz@gnu.org>
2383
96512555
EZ
2384 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
2385 last argument of make_unibyte_string.
2386
0bd8297f
EZ
2387 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
2388 language ID in the event parameters.
2389
2390 * w32term.c (w32_read_socket): Put the new keyboard codepage into
2391 event.code, not the obscure "character set ID".
2392
63def6b6
CY
23932012-06-23 Chong Yidong <cyd@gnu.org>
2394
2395 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
2396
e8a02204
EZ
23972012-06-23 Eli Zaretskii <eliz@gnu.org>
2398
388cdec0
EZ
2399 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
2400 * w32.c (fdutimens): New function.
2401
2402 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
2403
2404 * s/ms-w32.h (pselect): Redirect to sys_select.
2405
2406 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
2407
e8a02204
EZ
2408 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
2409 in the logic of incrementing and decrementing the value of
2410 use_relocatable_buffers.
2411
d054f3fb
PE
24122012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2413
2414 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
2415 Privately reported by Herbert J. Skuhra.
2416 [__FreeBSD__]: Remove "*/" typo after "#include".
2417 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
2418 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
2419 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
2420 Don't assume EMACS_TIME and struct timeval are the same type.
2421
d35af63c
PE
24222012-06-22 Paul Eggert <eggert@cs.ucla.edu>
2423
2424 Support higher-resolution time stamps (Bug#9000).
2425 The time stamps are only nanosecond-resolution at the C level,
2426 since that's the best that any real-world system supports now.
2427 But they are picosecond-resolution at the Lisp level, as that's
2428 easy, and leaves room for future OS improvements.
2429
2430 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
2431 (LIBES): Use it.
2432
2433 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
2434 Don't get current time unless it's needed.
2435
2436 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
2437 now provides it if it's absent.
2438 (start_atimer): Port to higher-res time stamps.
2439 Check for time stamp overflow. Don't get current time more
2440 often than is needed.
2441
2442 * buffer.h (struct buffer): Buffer modtime now has high resolution.
2443 Include systime.h, not time.h.
2444 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
2445
2446 * dired.c: Include stat-time.h.
2447 (Ffile-attributes): File times now have higher resolution.
2448
2449 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
2450 (struct image): Timestamp now has higher resolution.
2451
2452 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
2453 has at least microseconds now. All uses removed.
2454 (update_frame, update_single_window, update_window, update_frame_1)
2455 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
2456
2457 * editfns.c (time_overflow): Now extern.
2458 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
2459 (float-time, Fformat_time_string, Fcurrent_time_string)
2460 (Fcurrent_time_zone): Accept and generate higher-resolution
2461 time stamps.
2462 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
2463 (decode_time_components, lisp_seconds_argument): New functions.
2464 (make_time): Now static.
2465 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
2466 Report an error if the time is invalid, rather than having the caller
2467 do that.
2468
2469 * fileio.c: Include <stat-time.h>
2470 (Fcopy_file): Copy higher-resolution time stamps.
2471 Prefer to set the time stamp via a file descriptor if that works.
2472 (Fset_file_times, Finsert_file_contents, Fwrite_region)
2473 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
2474 (Fvisited_file_modtime, Fset_visited_file_modtime):
2475 Support higher-resolution time stamps.
2476
2477 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
2478
2479 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
2480
2481 * image.c (prepare_image_for_display, clear_image_cache)
2482 (lookup_image): Port to higer-resolution time stamps.
2483
2484 * keyboard.c (start_polling, bind_polling_period):
2485 Check for time stamp overflow.
2486 (read_char, kbd_buffer_get_event, timer_start_idle)
2487 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
2488 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
2489 Port to higher-resolution time stamps. Do not assume time_t is signed.
2490 (decode_timer): New function. Timers are now vectors of length 9,
2491 not 8, to accommodate the picosecond component.
2492 (timer_check_2): Use it.
2493
2494 * nsterm.m (select_timeout, timeval_subtract): Remove.
2495 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
2496 as they're a bit more accurate and handle overflow better.
2497 (ns_select): Change prototype to be compatible with pselect.
2498 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
2499 * nsterm.h (ns_select): Adjust prototype.
2500
2501 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
2502 us-resolution time stamps.
2503 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
2504
2505 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
2506
2507 * lisp.h (time_overflow): New decl.
2508 (wait_reading_process_output): First arg is now intmax_t, not int,
2509 to accommodate larger waits.
2510
2511 * process.h (struct Lisp_Process.read_output_delay):
2512 Now counts nanoseconds, not microseconds.
2513 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
2514 EMACS_HAS_USECS.
2515 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
2516 (wait_reading_process_output):
2517 Port to ns-resolution time stamps.
2518 (Faccept_process_output, wait_reading_process_output):
2519 Check for time stamp overflow. Do not assume time_t is signed.
2520 (select_wrapper): Remove; we now use pselect.
2521 (Fprocess_attributes): Now generates ns-resolution time stamps.
2522
2523 * sysdep.c: Include utimens.h. Don't include utime.h
2524 or worry about struct utimbuf; gnulib does that for us now.
2525 (gettimeofday): Remove; gnulib provides a substitute.
2526 (make_timeval): New function.
2527 (set_file_times): Now sets ns-resolution time stamps.
2528 New arg FD; all uses changed.
2529 (time_from_jiffies, ltime_from_jiffies, get_up_time)
2530 (system_process_attributes):
2531 Now returns ns-resolution time stamp. All uses changed.
2532 Check for time stamp overflow.
2533
2534 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
2535 provides a substitute now.
2536
2537 * systime.h: Include timespec.h rather than sys/time.h and time.h,
2538 since it guarantees struct timespec.
2539 (EMACS_TIME): Now struct timespec, so that we can support
2540 ns-resolution time stamps.
2541 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
2542 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
2543 (EMACS_USECS): Remove.
2544 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
2545 so multiply the arg by 1000 before storing it.
2546 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
2547 New macros.
2548 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
2549 Port to ns-resolution time stamps.
2550 (EMACS_TIME_NEG_P): Remove; replaced by....
2551 (EMACS_TIME_SIGN): New macro.
2552 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
2553 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
2554 (set_file_times, make_time, lisp_time_argument): Adjust signature.
2555 (make_timeval, make_lisp_time, decode_time_components): New decls.
2556 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
2557 that it mishandled time_t overflow. You can't compare by subtracting!
2558 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
2559 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
2560
2561 * term.c: Include <sys/time.h>.
2562 (timeval_to_Time): New function, for proper overflow wraparound.
2563 (term_mouse_position, term_mouse_click): Use it.
2564
2565 * undo.c (record_first_change): Support higher-resolution time stamps
2566 in the undo buffer.
2567 (Fprimitive_undo): Use them when restoring time stamps.
2568
2569 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
2570 (w32_get_internal_run_time):
2571 Port to higher-resolution Emacs time stamps.
2572 (ltime): Now accepts single 64-bit integer, as that's more convenient
2573 for callers.
2574
2575 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
2576
2577 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
2578 for compatibility with pselect. Support ns-resolution time stamps.
2579
2580 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
2581
2582 * xselect.c (wait_for_property_change, x_get_foreign_selection):
2583 Check for time stamp overflow, and support ns-resolution time stamps.
2584
2585 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
2586 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
2587 (timeval_subtract): Remove; no longer needed.
2588 (XTflash, XTring_bell, x_wait_for_event):
2589 Port to ns-resolution time stamps. Don't assume time_t is signed.
2590
b6a92dfe
CY
25912012-06-22 Chong Yidong <cyd@gnu.org>
2592
2593 * xdisp.c (x_consider_frame_title): Revert last change.
2594
d251c37c
EZ
25952012-06-22 Eli Zaretskii <eliz@gnu.org>
2596
2597 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
2598 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
2599 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
2600 staticidx goes up to 1597 out of 1600 = 0x640.)
2601
f10deafb
PE
26022012-06-20 Paul Eggert <eggert@cs.ucla.edu>
2603
2604 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
2605 Otherwise, the umask might be mistakenly 0 while handling input signals.
2606
ec6de1e2
SM
26072012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
2608
2609 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
2610
28be1ada
DA
26112012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
2612
2613 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
2614 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
2615 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
2616 access to `contents' member of Lisp_Vector objects with AREF and ASET
2617 where appropriate.
2618
c6bf3022
CY
26192012-06-19 Chong Yidong <cyd@gnu.org>
2620
2621 * frame.c (delete_frame): When selecting a frame on a different
2622 text terminal, do not alter the terminal's top-frame.
2623
2624 * xdisp.c (format_mode_line_unwind_data): Record the target
2625 frame's selected window and its terminal's top-frame.
2626 (unwind_format_mode_line): Restore them.
2627 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
2628 Callers changed.
2629 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
2630 since tty frames can be explicitly named.
2631 (prepare_menu_bars): Likewise.
2632
2633 * term.c (Ftty_top_frame): New function.
2634
defd4196
PE
26352012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2636
2637 Port byte-code-meter to modern targets.
2638 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
2639 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 2640 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
2641 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
2642 (METER_1, METER_2): Simplify.
2643
1053a871
SM
26442012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
2645
2646 * data.c (Fdefalias): Return `symbol' (bug#11686).
2647
b7e8d081
MR
26482012-06-18 Martin Rudalics <rudalics@gmx.at>
2649
2650 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
2651 gets killed during executing of this function (Bug#11665).
2652 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
2653 (Vkill_buffer_query_functions): In doc-string say that functions
2654 run by this hook should not change the current buffer.
2655
7ea2b339
PE
26562012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2657
2658 Fix recently-introduced process.c problems found by static checking.
2659 * process.c (write_queue_push, write_queue_pop, send_process):
2660 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
2661 (write_queue_pop): Fix pointer signedness problem.
2662 (send_process): Remove unused local.
2663
96a313a1
CY
26642012-06-17 Chong Yidong <cyd@gnu.org>
2665
2666 * xdisp.c (redisplay_internal): No need to redisplay terminal
2667 frames that are not on top.
2668
20ca2e94
TN
26692012-06-17 Troels Nielsen <bn.troels@gmail.com>
2670
2671 * process.c (make_process): Initialize write_queue.
2672 (write_queue_push, write_queue_pop): New functions.
2673 (send_process): Use them to maintain correct ordering of process
2674 writes (Bug#10815).
2675
9a900ca9
PE
26762012-06-17 Paul Eggert <eggert@cs.ucla.edu>
2677
310fbfa8
PE
2678 * lisp.h (eassert): Assume C89 or later.
2679 This removes the need for CHECK.
2680 (CHECK): Remove. Its comments about always evaluating its
2681 argument were confusing, as 'eassert' typically does not evaluate
2682 its argument.
2683
27bb1ca4
PE
2684 * coding.c (produce_chars): Use ptrdiff_t, not int.
2685
9a900ca9
PE
2686 * xterm.c (x_draw_underwave): Check for integer overflow.
2687 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
2688
41b7f8bc 26892012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
2690
2691 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
2692 referenced (Bug#11583).
2693
9b0e3eba
AA
26942012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
2695
2696 Implement wave-style variant of underlining.
2697 * dispextern.h (face_underline_type): New enum.
2698 (face): Add field for underline type.
2699 * nsterm.m (ns_draw_underwave): New function.
2700 (ns_draw_text_decoration): Use it.
2701 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
2702 New functions.
2703 (x_draw_glyph_string): Use them.
2704 * xfaces.c (Qline, Qwave): New Lisp objects.
2705 (check_lface_attrs, merge_face_ref)
1053a871
SM
2706 (Finternal_set_lisp_face_attribute, realize_x_face):
2707 Handle wave-style underline face attributes.
9b0e3eba
AA
2708 * xterm.c (x_draw_underwave): New function.
2709 (x_draw_glyph_string): Use it.
2710
0fb52f11
JB
27112012-06-16 Juanma Barranquero <lekktu@gmail.com>
2712
2713 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
2714 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
2715 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
2716 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
2717 ($(BLD)/w32select.$(O)): Update dependencies.
2718
e5560ff7
AS
27192012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2720
2721 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
2722 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
2723 * character.c (_fetch_multibyte_char_p): Remove.
2724 * alloc.c: Include "character.h" before "buffer.h".
2725 * bidi.c: Likewise.
2726 * buffer.c: Likewise.
2727 * bytecode.c: Likewise.
2728 * callint.c: Likewise.
2729 * callproc.c: Likewise.
2730 * casefiddle.c: Likewise.
2731 * casetab.c: Likewise.
2732 * category.c: Likewise.
2733 * cmds.c: Likewise.
2734 * coding.c: Likewise.
2735 * composite.c: Likewise.
2736 * dired.c: Likewise.
2737 * dispnew.c: Likewise.
2738 * doc.c: Likewise.
2739 * dosfns.c: Likewise.
2740 * editfns.c: Likewise.
2741 * emacs.c: Likewise.
2742 * fileio.c: Likewise.
2743 * filelock.c: Likewise.
2744 * font.c: Likewise.
2745 * fontset.c: Likewise.
2746 * fringe.c: Likewise.
2747 * indent.c: Likewise.
2748 * insdel.c: Likewise.
2749 * intervals.c: Likewise.
2750 * keyboard.c: Likewise.
2751 * keymap.c: Likewise.
2752 * lread.c: Likewise.
2753 * macros.c: Likewise.
2754 * marker.c: Likewise.
2755 * minibuf.c: Likewise.
2756 * nsfns.m: Likewise.
2757 * nsmenu.m: Likewise.
2758 * print.c: Likewise.
2759 * process.c: Likewise.
2760 * regex.c: Likewise.
2761 * region-cache.c: Likewise.
2762 * search.c: Likewise.
2763 * syntax.c: Likewise.
2764 * term.c: Likewise.
2765 * textprop.c: Likewise.
2766 * undo.c: Likewise.
2767 * unexsol.c: Likewise.
2768 * w16select.c: Likewise.
2769 * w32fns.c: Likewise.
2770 * w32menu.c: Likewise.
2771 * window.c: Likewise.
2772 * xdisp.c: Likewise.
2773 * xfns.c: Likewise.
2774 * xmenu.c: Likewise.
2775 * xml.c: Likewise.
2776 * xselect.c: Likewise.
2777
2f07e6af
EZ
27782012-06-16 Eli Zaretskii <eliz@gnu.org>
2779
1053a871
SM
2780 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
2781 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 2782 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
2783 row.
2784 (handle_face_prop): Use chunk-relative overlay string index when
2785 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
2786 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
2787 the rightmost. (Bug#11720)
2f07e6af 2788
29b83cec
AS
27892012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2790
2791 * category.h (CHAR_HAS_CATEGORY): Define as inline.
2792 (CATEGORY_MEMBER): Enforce 1/0 value.
2793 * category.c (_temp_category_set): Remove.
2794
4c5501e9
EZ
27952012-06-16 Eli Zaretskii <eliz@gnu.org>
2796
2797 * window.c (Fdelete_other_windows_internal)
2798 (Fdelete_window_internal): Don't access frame's mouse highlight
2799 info of the initial frame. (Bug#11677)
2800
2b570124
PE
28012012-06-14 Paul Eggert <eggert@cs.ucla.edu>
2802
e93864f9
PE
2803 * .gdbinit (xgetint): Fix recently-introduced paren typo.
2804 Assume USE_2_TAGS_FOR_INTS.
2805 (xreload): Adjust $tagmask width to match recent lisp.h change.
2806
2b570124
PE
2807 Simplify lisp.h in minor ways that should not affect code.
2808 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
2809 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
2810 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
2811 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
2812 (INTTYPEBITS): New macro, for clarity.
2813 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
2814 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
2815 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
2816 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
2817 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
2818
81755f69
JB
28192012-06-13 Juanma Barranquero <lekktu@gmail.com>
2820
2821 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
2822
16192a57
GM
28232012-06-13 Glenn Morris <rgm@gnu.org>
2824
2825 * s/bsd-common.h (BSD4_3):
2826 * s/usg5-4-common.h (USG5_4): No longer define; unused.
2827
646b5f55
AS
28282012-06-13 Andreas Schwab <schwab@linux-m68k.org>
2829
2830 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
2831 instead of union.
2832 (XLI, XIL): Define.
1053a871
SM
2833 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
2834 Use them.
2835 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 2836 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 2837 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
2838 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
2839 * frame.c (delete_frame): Remove outdated comment.
2840 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
2841 USE_LISP_UNION_TYPE.
2842 (Fw32_unregister_hot_key): Likewise.
2843 (Fw32_toggle_lock_key): Likewise.
2844 * w32menu.c (add_menu_item): Likewise.
2845 (w32_menu_display_help): Use XIL instead of checking
2846 USE_LISP_UNION_TYPE.
2847 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
2848 (init_heap): Likewise.
2849 * w32term.c (w32_read_socket): Update comment.
2850
1d3823c9
GM
28512012-06-13 Glenn Morris <rgm@gnu.org>
2852
c62ff706
GM
2853 * s/usg5-4-common.h, src/s/unixware.h:
2854 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
2855
1d3823c9
GM
2856 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
2857
bfe3e0a2
PE
28582012-06-13 Paul Eggert <eggert@cs.ucla.edu>
2859
2860 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
2861 * alloc.c (make_number) [!defined make_number]:
2862 Remove, as lisp.h always defines this now.
2863 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
2864 (roundup_size): Verify that it is a power of 2.
2865 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
2866 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
2867 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
2868 -DUSE_LSB_TAG=0, to override the automatically-selected default.
2869 USE_LSB_TAG now is always defined to be either 0 or 1.
2870 All uses changed.
2871 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
2872 code works fine either way, and efficiency is not a concern here,
2873 as the union type is for debugging, not for production.
2874 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
2875 Use an inline function on all platforms when using the union type,
2876 since this is simpler and 'static inline' can be used portably
2877 within Emacs now.
2878 (LISP_INITIALLY_ZERO): New macro.
2879 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
2880 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
2881
45fa9c0f
GM
28822012-06-12 Glenn Morris <rgm@gnu.org>
2883
b4492cba
GM
2884 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
2885
2886 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 2887
45fa9c0f
GM
2888 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
2889 Move BROKEN_SIGIO to configure.
2890
2891 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
2892 Move NO_TERMIO to configure.
2893
0e25d334
CY
28942012-06-12 Chong Yidong <cyd@gnu.org>
2895
2896 * image.c (imagemagick_load_image): Use MagickFlattenImage if
2897 MagickMergeImageLayers is undefined. Use pixel pusher loop if
2898 MagickExportImagePixels is undefined.
2899
43682bb6
PE
29002012-06-12 Paul Eggert <eggert@cs.ucla.edu>
2901
2902 * image.c (imagemagick_load_image): Remove unused label.
2903
a9be7d2b
GM
29042012-06-11 Glenn Morris <rgm@gnu.org>
2905
2906 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
2907 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
2908 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
2909 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
2910
3017f87f
SM
29112012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
2912
2913 * alloc.c (make_byte_code): New function.
2914 (Fmake_byte_code): Use it. Don't purify here.
2915 * lread.c (read1): Use it as well to avoid extra allocation.
2916
1b9b4cf4
CY
29172012-06-11 Chong Yidong <cyd@gnu.org>
2918
2919 * image.c (imagemagick_load_image): Implement transparency.
2920
95988fcf
AS
29212012-06-10 Andreas Schwab <schwab@linux-m68k.org>
2922
2923 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
2924 account for preceding backslashes. (Bug#11663)
2925
cd4eb164
CY
29262012-06-09 Chong Yidong <cyd@gnu.org>
2927
2928 * term.c: Support italics in capable terminals (Bug#9652).
2929 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
2930 (turn_on_face): Output using TS_enter_italic_mode if available.
2931 Don't handle unused blinking and alt-charset cases.
2932 (turn_off_face): Handle italic case; discard unused tty_blinking_p
2933 and tty_alt_charset_p cases.
2934 (tty_capable_p, init_tty): Support italics.
2935
2936 * termchar.h (struct tty_display_info): Add field for italics.
2937 Remove unused blink field.
2938
2939 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
2940 Handle slant.
2941
2942 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
2943 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
2944 tty_alt_charset_p. Add tty_italic_p.
2945
ff88beb8
MA
29462012-06-09 Michael Albinus <michael.albinus@gmx.de>
2947
2948 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
2949 dbus_type_is_basic if available.
2950 (xd_extract_signed, xd_extract_unsigned): Rename from
2951 extract_signed and extract_unsigned, respectively. Adapt callers.
2952
44286096
CY
29532012-06-09 Chong Yidong <cyd@gnu.org>
2954
1682701f
CY
2955 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
2956
44286096
CY
2957 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
2958 case (Bug#9752).
2959
d86feb17
PE
29602012-06-08 Paul Eggert <eggert@cs.ucla.edu>
2961
2962 * xdisp.c (vmessage): Treat frame message as multibyte.
2963 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
2964 would generate the diagnostic "Making \302\247 buffer-local while
2965 let-bound!".
2966
d5c20fe8
EZ
29672012-06-08 Eli Zaretskii <eliz@gnu.org>
2968
2969 * dispnew.c (showing_window_margins_p): Undo last change, which
2970 was done due to an inadvertent commit.
2971 (adjust_frame_glyphs_for_frame_redisplay): Do call
2972 showing_window_margins_p.
2973
513749ee
SM
29742012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2975
2976 * eval.c (Fmake_var_non_special): New primitive.
2977 (syms_of_eval): Defsubr it.
2978 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
2979
d4a8f5c1
JB
29802012-06-08 Juanma Barranquero <lekktu@gmail.com>
2981
2982 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
2983 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
2984
8bbbc977
EZ
29852012-06-08 Eli Zaretskii <eliz@gnu.org>
2986
2987 * alloc.c (allocate_vectorlike): Fix last change.
2988
f3372c87
DA
29892012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
2990
2991 Block-based vector allocation of small vectors.
2992 * lisp.h (struct vectorlike_header): New field `nbytes',
2993 adjust comment accordingly.
2994 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
2995 to denote vector blocks. Adjust users (live_vector_p,
2996 mark_maybe_pointer, valid_lisp_object_p) accordingly.
2997 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
2998 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
2999 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
3000 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
3001 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
3002 (roundup_size): New constant.
3003 (struct vector_block): New data type.
3004 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 3005 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
3006 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
3007 (sweep_vectors): New functions.
3008 (allocate_vectorlike): Return `zero_vector' as the only vector of
3009 0 items. Allocate new vector from block if vector size is less than
3010 or equal to VBLOCK_BYTES_MAX.
3011 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
3012 (init_alloc_once): Add call to init_vectors.
3013
4f18a4ed
SM
30142012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3015
3016 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
3017
86f158bc
PE
30182012-06-07 Paul Eggert <eggert@cs.ucla.edu>
3019
3020 * doprnt.c (doprnt): Truncate multibyte char correctly.
3021 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
3022 would mishandle a string argument "Xc" if X was a multibyte
3023 character of length 2: it would truncate after X's first byte
3024 rather than including all of X.
3025
c5cfcbe0
CY
30262012-06-06 Chong Yidong <cyd@gnu.org>
3027
3028 * buffer.c (word_wrap): Doc fix.
3029
c05cf390
PE
30302012-06-04 Paul Eggert <eggert@cs.ucla.edu>
3031
3032 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
3033
0c3461de
GM
30342012-06-03 Glenn Morris <rgm@gnu.org>
3035
3036 * xdisp.c (tool-bar-style): Doc fix.
3037
c71232db
UM
30382012-06-03 Ulrich Müller <ulm@gentoo.org>
3039
3040 * Makefile.in (PAXCTL): Define.
3041 (temacs$(EXEEXT)): Disable memory randomization for the temacs
3042 binary via PaX flags if the paxctl utility is available.
3043 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
3044 Restore PaX flags to their default. (Bug#11398)
3045
383f7350
CY
30462012-06-03 Chong Yidong <cyd@gnu.org>
3047
3048 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
3049 buffer (Bug#11226).
3050
5f2c76c6
CY
30512012-06-03 Chong Yidong <cyd@gnu.org>
3052
3053 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
3054 (note_mode_line_or_margin_highlight): If there is no help echo,
3055 use mode-line-default-help-echo. Handle the case where the mouse
3056 position is past the end of the mode line string.
3057
3058 * buffer.c (buffer_local_value_1): New function, split from
3059 Fbuffer_local_value; can return Qunbound.
3060 (Fbuffer_local_value): Use it.
3061 (Vmode_line_format): Docstring tweaks.
3062
773d47f6
PE
30632012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3064
3065 * sysdep.c (system_process_attributes): Improve comment.
3066
f2d6a3df
SM
30672012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
3068
3069 * keyboard.c: Export real-this-command to Elisp.
3070 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
3071 and DEFVAR it. Update all users.
3072
63810350
PE
30732012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3074
7bd5c1f4
PE
3075 * minibuf.c (Fassoc_string): Remove duplicate declaration.
3076
63810350
PE
3077 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
3078 Convert pctcpu and pctmem to Lisp float properly.
3079 Let the compiler fold better, as 100.0/0x8000 is exact.
3080
a2821611
AS
30812012-06-02 Andreas Schwab <schwab@linux-m68k.org>
3082
3083 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
3084 cons_block.
3085
5fceba1d
PE
30862012-06-01 Paul Eggert <eggert@cs.ucla.edu>
3087
3088 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
3089
c98ff5dd
DA
30902012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
3091
3092 For a 'struct window', replace some Lisp_Object fields to
3093 bitfields where appropriate, remove unused fields.
3094 * window.h (struct window): Remove unused 'last_mark_x' and
3095 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
3096 change it's type from Lisp_Object to bitfield.
3097 Change type of 'force_start', 'optional_new_start',
3098 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
3099 fields from Lisp_Object to bitfield. Adjust users accordingly.
3100
ca34e0be
PE
31012012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3102
3103 Pacify gcc -Wdouble-precision when using Xaw.
3104 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
3105 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
3106 Use 'float' consistently, rather than 'float' in most places
3107 and 'double' in a couple of places.
3108
efc00ab1 31092012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
3110
3111 * xdisp.c (handle_stop): Detect whether we have overlay strings
3112 loaded by testing it->current.overlay_string_index to be
3113 non-negative, instead of checking whether n_overlay_strings is
3114 positive. (Bug#11587)
3115
efc00ab1 31162012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
3117
3118 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
3119
3120 * doc.c (Fsubstitute_command_keys): Doc fix.
3121
efc00ab1 31222012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
3123
3124 * search.c (search_buffer): Remove calls to
3125 r_alloc_inhibit_buffer_relocation, as it is now called by
3126 maybe_unify_char, which was the cause of relocation of buffer text
3127 in bug#11519.
3128
efc00ab1 31292012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
3130
3131 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
3132 for the duration of call to load_charset, to avoid problems with
3133 callers of maybe_unify_char that access buffer text through C
3134 pointers.
3135
3136 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
3137 decrement the inhibition flag, instead of just setting or
3138 resetting it.
3139
ba93a187
PE
31402012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3141
3142 Remove obsolete '#define static' cruft.
3143 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
3144 This #undef was "temporary" in 2000; it is no longer needed
3145 now that '#define static' has gone away.
3146 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
3147 (gray_bitmap_bits): Remove; no longer needed.
3148 All uses replaced with definiens.
3149 * xterm.c: Include "bitmaps/gray.xbm".
3150
9e4bf381
PE
31512012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3152
3153 Clean up __executable_start, monstartup when --enable-profiling.
3154 The following changes affect the code only when profiling.
3155 * dispnew.c (__executable_start): Rename from safe_bcopy.
3156 Define only on platforms that need it.
3157 * emacs.c: Include <sys/gmon.h> when profiling.
3158 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
3159 (__executable_start): Remove decl, since lisp.h does it now.
3160 (safe_bcopy): Remove decl; no longer has that name.
3161 (main): Coalesce #if into single bit of code, for simplicity.
3162 Cast pointers to uintptr_t, since standard libraries want integers
3163 and not pointers.
3164 * lisp.h (__executable_start): New decl.
3165
32d72c2f
GM
31662012-05-31 Glenn Morris <rgm@gnu.org>
3167
3168 * image.c (Fimagemagick_types): Doc fix.
3169
baac5bc7
JM
31702012-05-30 Jim Meyering <meyering@redhat.com>
3171
3172 * callproc.c (Fcall_process_region): Include directory component
3173 in mkstemp error message (Bug#11586).
3174
72cb32cf
PE
31752012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3176
3177 * alloc.c, lisp.h (make_pure_vector): Now static.
3178
61b108cc
SM
31792012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
3180
3181 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
3182 Move to byte-run.el.
3183 (Fautoload): Do the hash-doc more carefully.
3184 * data.c (Fdefalias): Purify definition, except for keymaps.
3185 (Qdefun): Move from eval.c.
3186 * lisp.h (Qdefun): Remove.
3187 * lread.c (read1): Tiny simplification.
3188
471fe23d
TN
31892012-05-29 Troels Nielsen <bn.troels@gmail.com>
3190
934f3f58 3191 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
3192 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
3193 Bug#9642, but explicitly check that the buffer the overlay would
3194 be moved to is live and rearrange lines to make sure that errors
3195 will not put the overlay in an inconsistent state.
3196 (Fdelete_overlay): Cosmetics.
3197
85d0efd1
EZ
31982012-05-28 Eli Zaretskii <eliz@gnu.org>
3199
3200 * w32term.c (my_bring_window_to_top): New function.
3201 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
3202 could be different from the original one.
3203 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
3204 (Bug#11513)
3205
3206 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
3207 by calling BringWindowToTop.
3208
3209 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
3210 (WM_EMACS_END): Increase by one.
3211
da92a98c
PE
32122012-05-28 Paul Eggert <eggert@cs.ucla.edu>
3213
3214 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
3215 This avoids undefined behavior that might cause the eassert
3216 to not catch an out-of-range value.
3217
74d1f848
JB
32182012-05-28 Juanma Barranquero <lekktu@gmail.com>
3219
3220 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
3221 Update dependencies.
3222
9e1a06fc
EZ
32232012-05-27 Eli Zaretskii <eliz@gnu.org>
3224
3225 * bidi.c (bidi_mirror_char): Fix last change.
3226
f3dd7312
AS
32272012-05-27 Andreas Schwab <schwab@linux-m68k.org>
3228
3229 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
3230 when referring to sectname field in printf format.
3231
81899c91
PE
32322012-05-27 Paul Eggert <eggert@cs.ucla.edu>
3233
57b81a9f
PE
3234 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
3235 Only r_alloc_inhibit_buffer_relocation needed to be added;
3236 the others were already declared.
3237
81899c91
PE
3238 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
3239 before checking whether it's out of range. Put the check inside
3240 eassert. See
3241 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
3242
33017faf 32432012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
3244
3245 * callproc.c (Fcall_process): Restore a line that was accidentally
3246 commented out in the 2011-02-13 change (bug#11547).
3247
33017faf 32482012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
3249
3250 * lisp.h [REL_ALLOC]: Add prototypes for external functions
3251 defined on ralloc.c.
3252
3253 * buffer.c [REL_ALLOC]: Remove prototypes of
3254 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
3255 they are now on lisp.h.
3256
3257 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
3258
3259 * search.c (search_buffer): Use it to inhibit relocation of buffer
3260 text while re_search_2 is doing its job, because re_search_2 is
3261 passed C pointers to buffer text. (Bug#11519)
3262
23415acf
EZ
3263 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
3264 Update value to 24.
3265
44e27368
EZ
3266 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
3267 state after an additional call to move_it_in_display_line_to, keep
3268 the values of it->max_ascent and it->max_descent found for the
3269 entire line.
3270 (pos_visible_p): Revert the comparison against bottom_y to what it
3271 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
3272 (Bug#11464)
3273
c1892f11
PE
32742012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3275
3276 Fix coding-related core dumps with gcc -ftrapv.
3277 The code was computing A - B, where A and B are pointers, and B is
3278 random garbage. This can lead to core dumps on platforms that
3279 have special pointer registers, and it also leads to core dumps on
3280 x86-64 when compiled with gcc -ftrapv. The fix is to compute
3281 A - B only when B is initialized properly.
3282 * coding.c (coding_set_source, coding_set_destination): Return void.
3283 (coding_change_source, coding_change_destinations): New functions,
3284 with the old behaviors of coding_set_source and coding_set_destination.
3285 All callers that need an offset changed to use these new functions.
3286
eb7afdad
GM
32872012-05-26 Glenn Morris <rgm@gnu.org>
3288
3289 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
3290
f12fdf02
EZ
32912012-05-26 Eli Zaretskii <eliz@gnu.org>
3292
53a63be6 3293 Extend mouse support on W32 text-mode console.
61b108cc
SM
3294 * xdisp.c (draw_row_with_mouse_face):
3295 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 3296
eb3f6f01 3297 * w32console.c: Include window.h.
61b108cc
SM
3298 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
3299 New functions.
eb3f6f01
EZ
3300 (initialize_w32_display): Initialize mouse-highlight data.
3301
53a63be6
EZ
3302 * w32inevt.c: Include termchar.h and window.h.
3303 (do_mouse_event): Support mouse-autoselect-window. When the mouse
3304 moves, call note_mouse_highlight. If help_echo changed, call
3305 gen_help_event to produce help-echo message in the echo area.
3306 Call clear_mouse_face if mouse_face_hidden is set in the mouse
3307 highlight info.
3308
4cfd81f6
PE
33092012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3310
3311 * lread.c (read1): Simplify slightly to avoid an overflow warning
3312 with GCC 4.7.0 on x86-64.
3313
4446092a
EZ
33142012-05-26 Eli Zaretskii <eliz@gnu.org>
3315
3316 * bidi.c (bidi_mirror_char): Revert last change: an int is
3317 definitely wide enough here.
3318
42b2a986 33192012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 3320
42b2a986 3321 Fix integer width and related bugs (Bug#9874).
eb106a49 3322 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
3323 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
3324 (string_bytes, check_sblock, allocate_string_data):
3325 (compact_small_strings, Fmake_bool_vector, make_string)
3326 (make_unibyte_string, make_multibyte_string)
3327 (make_string_from_bytes, make_specified_string)
3328 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
3329 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
3330 (mark_vectorlike):
3331 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3332 (allocate_pseudovector):
3333 Use int, not EMACS_INT, where int is wide enough.
3334 (inhibit_garbage_collection, Fgarbage_collect):
3335 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3336 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
3337 int might not be wide enough.
3338 (bidi_cache_search, bidi_cache_find, bidi_init_it)
3339 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
3340 (bidi_at_paragraph_end, bidi_find_paragraph_start)
3341 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3342 (bidi_level_of_next_char, bidi_move_to_visually_next):
3343 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3344 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
3345 (Fkill_buffer, Fset_buffer_major_mode)
3346 (advance_to_char_boundary, Fbuffer_swap_text)
3347 (Fset_buffer_multibyte, overlays_at, overlays_in)
3348 (overlay_touches_p, struct sortvec, record_overlay_string)
3349 (overlay_strings, recenter_overlay_lists)
3350 (adjust_overlays_for_insert, adjust_overlays_for_delete)
3351 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
3352 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
3353 (Foverlay_recenter, last_overlay_modification_hooks_used)
3354 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
3355 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
3356 (validate_region): Omit unnecessary test for b <= e,
3357 since that's guaranteed by the previous test.
d311d28c
PE
3358 (adjust_overlays_for_delete): Avoid pos + length overflow.
3359 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
3360 (report_overlay_modification):
3361 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3362 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
3363 Omit pointer cast, which isn't needed anyway, and doesn't work
3364 after the EMACS_INT -> ptrdiff_t change.
02481186 3365 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
3366 * buffer.h: Adjust decls to match defn changes elsewhere.
3367 (struct buffer_text, struct buffer):
3368 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3369 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
3370 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
3371 not int, to avoid needless 32-bit limit on 64-bit hosts.
3372 (exec_byte_code): Use tighter memory-full test, one that checks
3373 for alloca overflow. Don't compute the address of the object just
3374 before an array, as that's not portable. Use EMACS_INT, not
3375 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
3376 * callint.c (Fcall_interactively):
3377 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3378 * callproc.c (call_process_kill, Fcall_process):
3379 Don't assume pid_t fits into an Emacs fixnum.
3380 (call_process_cleanup, Fcall_process, child_setup):
3381 Don't assume pid_t fits into int.
3382 (call_process_cleanup, Fcall_process, delete_temp_file)
3383 (Fcall_process_region):
3384 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3385 (Fcall_process): Simplify handling of volatile integers.
3386 Use int, not EMACS_INT, where int will do.
3387 * casefiddle.c (casify_object, casify_region, operate_on_word)
3388 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
3389 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3390 (casify_object): Avoid integer overflow when overallocating buffer.
3391 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 3392 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
3393 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
3394 * category.h (CATEGORYP): Don't assume arg is nonnegative.
3395 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
3396 integers are now checked earlier. All uses replaced with XINT.
3397 (ccl_driver):
3398 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3399 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
3400 (ccl_driver, Fregister_code_conversion_map):
3401 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
3402 (resolve_symbol_ccl_program): Check that vector header is in range.
3403 Always copy the vector, so that we can check its contents reliably
3404 now rather than having to recheck each instruction as it's being
3405 executed. Check that vector words fit in 'int'.
3406 (ccl_get_compiled_code, Fregister_ccl_program)
3407 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
3408 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
3409 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
3410 contents are in range.
3411 (Fccl_execute_on_string): Check that status is in range.
3412 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
3413 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
3414 Accept and return EMACS_INT, not int, because callers can pass values
3415 out of 'int' range.
3416 (c_string_width, strwidth, lisp_string_width, chars_in_text)
3417 (multibyte_chars_in_text, parse_str_as_multibyte)
3418 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
3419 (str_as_unibyte, str_to_unibyte, string_count_byte8)
3420 (string_escape_byte8, Fget_byte):
3421 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 3422 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
3423 avoid mishandling large integers.
3424 * character.h: Adjust decls to match defn changes elsewhere.
3425 * charset.c (load_charset_map_from_file, find_charsets_in_text)
3426 (Ffind_charset_region):
3427 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3428 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
3429 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 3430 Don't assume fixnum fits in int.
d311d28c
PE
3431 (load_charset_map_from_vector, Fmap_charset_chars):
3432 Remove now-unnecessary CHECK_NATNUMs.
3433 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
3434 Don't rely on undefined behavior with signed left shift overflow.
3435 Don't assume unsigned int fits into fixnum, or that fixnum fits
3436 into unsigned int. Don't require max_code to be a valid fixnum;
3437 that's not true for gb10830 4-byte on a 32-bit host. Allow
3438 invalid_code to be a cons, for the same reason. Require code_offset
3439 to be a character. Avoid int overflow if max_char is close
3440 to INT_MAX.
3441 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
3442 this is intended anyway and avoids some undefined behavior.
3443 (load_charset_map): Pass unsigned, not int, as 2nd arg of
3444 INDEX_TO_CODE_POINT, as that's what it expects.
3445 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
3446 * charset.h (DECODE_CHAR): Return int, not unsigned;
3447 this is what was intended anyway, and it avoids undefined behavior.
3448 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
3449 integer-overflow issues.
3450 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
3451 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
3452 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
3453 * chartab.c (Fmake_char_table, Fset_char_table_range)
3454 (uniprop_get_decoder, uniprop_get_encoder):
3455 Don't assume fixnum fits in int.
3456 * cmds.c (move_point): New function, that does the gist of
3457 Fforward_char and Fbackward_char, but does so while checking
3458 for integer overflow more accurately.
c96e5d6a 3459 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
3460 (Fforward_line, Fend_of_line, internal_self_insert)
3461 (internal_self_insert):
3462 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3463 Fix a FIXME, by checking for integer overflow when calculating
3464 target_clm and actual_clm.
3465 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 3466 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
3467 (ASSURE_DESTINATION, coding_alloc_by_realloc)
3468 (coding_alloc_by_making_gap, alloc_destination)
3469 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
3470 (encode_coding_utf_16, detect_coding_emacs_mule)
3471 (decode_coding_emacs_mule, encode_coding_emacs_mule)
3472 (detect_coding_iso_2022, decode_coding_iso_2022)
3473 (encode_invocation_designation, encode_designation_at_bol)
3474 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3475 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
3476 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
3477 (encode_coding_ccl, encode_coding_raw_text)
3478 (detect_coding_charset, decode_coding_charset)
3479 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
3480 (produce_composition, produce_charset, produce_annotation)
3481 (decode_coding, handle_composition_annotation)
3482 (handle_charset_annotation, consume_chars, decode_coding_gap)
3483 (decode_coding_object, encode_coding_object, detect_coding_system)
3484 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
3485 (code_convert_region, code_convert_string)
8f50130c
PE
3486 (Fdefine_coding_system_internal)
3487 (coding_set_source, coding_set_destination):
d311d28c
PE
3488 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3489 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
3490 (Fdefine_coding_system_internal):
3491 Don't assume fixnums fit in int.
3492 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 3493 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
3494 (Funencodable_char_position, Fcheck_coding_systems_region)
3495 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 3496 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 3497 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 3498 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 3499 Don't access memory outside of the args array.
d311d28c 3500 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
3501 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
3502 result of ENCODE_CHAR.
d311d28c
PE
3503 * coding.h: Adjust decls to match defn changes elsewhere.
3504 (struct coding_system):
3505 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3506 * composite.c (get_composition_id, find_composition)
3507 (run_composition_function, update_compositions)
3508 (compose_text, composition_gstring_put_cache)
3509 (composition_gstring_p, composition_gstring_width)
3510 (fill_gstring_header, fill_gstring_body, autocmp_chars)
3511 (composition_compute_stop_pos, composition_reseat_it)
3512 (composition_update_it, struct position_record)
3513 (find_automatic_composition, composition_adjust_point)
3514 (Fcomposition_get_gstring, Ffind_composition_internal):
3515 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3516 (update_compositions):
3517 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3518 * composite.h: Adjust decls to match defn changes elsewhere.
3519 (struct composition):
3520 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3521 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
3522 Do not attempt to compute the address of the object just before a
3523 buffer; this is not portable.
3524 (Faref, Faset):
3525 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3526 (Faset): Use int, not EMACS_INT, where int is wide enough.
3527 (Fstring_to_number): Don't assume fixnums fit in int.
3528 (Frem): Don't assume arg is nonnegative.
3529 * dbusbind.c (xd_append_arg): Check for integers out of range.
3530 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 3531 (extract_signed, extract_unsigned): New functions.
243e0530
PE
3532 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
3533 (xd_get_connection_references): Return ptrdiff_t, not int.
3534 All uses changed.
3535 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
3536 (xd_read_message_1):
3537 Use int, not unsigned, where the dbus API uses int.
3538 (Fdbus_message_internal): Don't overflow mtype.
3539 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
3540 * dired.c (directory_files_internal, file_name_completion, scmp)
3541 (file_name_completion_stat):
3542 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3543 (file_name_completion): Don't overflow matchcount.
3544 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
3545 * dispextern.h: Adjust decls to match defn changes elsewhere.
3546 (struct text_pos, struct glyph, struct bidi_saved_info)
3547 (struct bidi_string_data, struct bidi_it, struct composition_it)
3548 (struct it):
3549 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3550 (struct display_pos, struct composition_it, struct it):
3551 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3552 * dispnew.c (increment_matrix_positions)
3553 (increment_row_positions, mode_line_string)
3554 (marginal_area_string):
3555 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 3556 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
3557 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3558 (duration_to_sec_usec): New function, to check for overflow better.
3559 (Fsleep_for, sit_for): Use it.
3560 * doc.c (get_doc_string, store_function_docstring):
3561 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3562 (get_doc_string, Fsnarf_documentation):
3563 Use int, not EMACS_INT, where int is wide enough.
3564 (get_doc_string):
3565 Use SAFE_ALLOCA, not alloca.
3566 Check for overflow when converting EMACS_INT to off_t.
3567 * doprnt.c (doprnt):
3568 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3569 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
3570 Don't assume uid_t fits into fixnum.
3571 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
3572 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
3573 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
3574 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
3575 (general_insert_function)
3576 (Finsert_char, make_buffer_string, make_buffer_string_both)
3577 (update_buffer_properties, Fbuffer_substring)
3578 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
3579 (Fsubst_char_in_region, check_translation)
3580 (Ftranslate_region_internal, save_restriction_restore, Fformat)
3581 (transpose_markers, Ftranspose_regions):
3582 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3583 (clip_to_bounds): Move to lisp.h as an inline function).
3584 (Fconstrain_to_field): Don't assume integers are nonnegative.
3585 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
3586 (Fsubst_char_in_region, Fsave_restriction):
3587 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3588 (Femacs_pid): Don't assume pid_t fits into fixnum.
3589 (lo_time): Use int, not EMACS_INT, when int suffices.
3590 (lisp_time_argument): Check for usec out of range.
3591 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
3592 (Fuser_login_name, Fuser_full_name): Signal an error
3593 if a uid argument is out of range, rather than relying on
3594 undefined behavior.
c8d5c857
PE
3595 (Fformat_time_string): Remove now-unnecessary check.
3596 lisp_time_argument checks for out-of-range usec now.
243e0530 3597 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
3598 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
3599 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
3600 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
3601 (init_cmdargs, Fdump_emacs):
3602 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3603 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
3604 the bottom (typically) 32 bits of the fixnum.
3605 * eval.c (specpdl_size, call_debugger):
3606 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3607 (when_entered_debugger, Fbacktrace_debug):
3608 Don't assume fixnum can fit in int.
3609 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
3610 the object just before a buffer; this is not portable.
3611 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
3612 (grow_specpdl, unbind_to):
3613 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3614 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
3615 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 3616 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
3617 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
3618 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
3619 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3620 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
3621 (a_write, e_write):
3622 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3623 (Fcopy_file, non_regular_nbytes, read_non_regular)
3624 (Finsert_file_contents):
3625 Use int, not EMACS_INT, where int is wide enough.
3626 (READ_BUF_SIZE): Verify that it fits in int.
3627 (Finsert_file_contents): Check that counts are in proper range,
3628 rather than assuming fixnums fit into ptrdiff_t etc.
3629 Don't assume fixnums fit into int.
125b3835 3630 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
3631 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
3632 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
3633 (string_char_to_byte, string_byte_to_char)
3634 (string_make_multibyte, string_to_multibyte)
3635 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
3636 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
3637 (substring_both, Fdelete, internal_equal, Ffillarray)
3638 (Fclear_string, mapcar1)
3639 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
3640 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
3641 (larger_vector, make_hash_table, maybe_resize_hash_table)
3642 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
3643 (Fmaphash, secure_hash):
3644 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3645 (concat): Check for string index and length overflow.
3646 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
3647 (Frequire):
3648 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3649 (larger_vector): New API (vec, incr_min, size_max) replaces old
3650 one (vec, new_size, init). This catches size overflow.
3651 INIT was removed because it was always Qnil.
3652 All callers changed.
3653 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
3654 the upper bound on a hash table index size.
3655 (make_hash_table, maybe_resize_hash_table): Use it.
3656 (secure_hash): Computer start_byte and end_byte only after
3657 they're known to be in ptrdiff_t range.
3658 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
3659 (Ffont_get_glyphs, Ffont_at):
3660 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3661 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
3662 (Flist_fonts, Fopen_font):
3663 Don't assume fixnum can fit in int.
3664 (check_gstring): Don't assume index can fit in int.
3665 (font_match_p): Check that fixnum is a character, not a nonnegative
3666 fixnum, since the later code needs to stuff it into an int.
3667 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
3668 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
3669 conversion overflow issues.
3670 (Fopen_font): Check for integer out of range.
3671 (Ffont_get_glyphs): Don't assume index can fit in int.
3672 * font.h: Adjust decls to match defn changes elsewhere.
3673 * fontset.c (reorder_font_vector): Redo score calculation to avoid
3674 integer overflow.
3675 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
3676 printmax_t, where ptrdiff_t is wide enough.
3677 (Finternal_char_font):
3678 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3679 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
3680 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
3681 (Fset_frame_position, x_set_frame_parameters)
3682 (x_set_line_spacing, x_set_border_width)
3683 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
3684 Check that fixnums are in proper range for system types.
3685 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
3686 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3687 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
3688 Use SAFE_ALLOCA_LISP, not alloca.
3689 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
3690 intptr_t is wide enough.
3691 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
3692 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
3693 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
3694 Check for fixnum out of range.
3695 * ftfont.c (ftfont_list): Don't assume index fits in int.
3696 Check that fixnums are in proper range for system types.
3697 (ftfont_shape_by_flt):
3698 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
3699 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3700 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3701 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
3702 Check that fixnums are in proper range for system types.
3703 * gnutls.h: Adjust decls to match defn changes elsewhere.
3704 * gtkutil.c (xg_dialog_run):
3705 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3706 (update_frame_tool_bar):
3707 Check that fixnums are in proper range for system types.
3708 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 3709 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
3710 * indent.c (last_known_column, last_known_column_point):
3711 (current_column_bol_cache):
3712 (skip_invisible, current_column, check_display_width):
3713 (check_display_width, scan_for_column, current_column_1)
3714 (Findent_to, Fcurrent_indentation, position_indentation)
3715 (indented_beyond_p, Fmove_to_column, compute_motion):
3716 (Fcompute_motion, Fvertical_motion):
3717 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3718 (last_known_column_modified): Use EMACS_INT, not int.
3719 (check_display_width):
3720 (Fcompute_motion):
3721 Check that fixnums and floats are in proper range for system types.
3722 (compute_motion): Don't assume index or fixnum fits in int.
3723 (compute_motion, Fcompute_motion):
3724 Use int, not EMACS_INT, when it is wide enough.
3725 (vmotion): Omit local var start_hpos that is always 0; that way
3726 we don't need to worry about overflow in expressions involving it.
3727 * indent.h: Adjust decls to match defn changes elsewhere.
3728 (struct position):
3729 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3730 Use int, not EMACS_INT, where int is wide enough.
3731 Remove unused members ovstring_chars_done and tab_offset;
3732 all uses removed.
3733 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
3734 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
3735 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
3736 (make_gap, copy_text, insert, insert_and_inherit)
3737 (insert_before_markers, insert_before_markers_and_inherit)
3738 (insert_1, count_combining_before, count_combining_after)
3739 (insert_1_both, insert_from_string)
3740 (insert_from_string_before_markers, insert_from_string_1)
3741 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
3742 (adjust_after_replace, adjust_after_insert, replace_range)
3743 (replace_range_2, del_range, del_range_1, del_range_byte)
3744 (del_range_both, del_range_2, modify_region)
3745 (prepare_to_modify_buffer, signal_before_change)
3746 (signal_after_change, Fcombine_after_change_execute):
3747 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3748 * intervals.c (traverse_intervals, rotate_right, rotate_left)
3749 (balance_an_interval, split_interval_right, split_interval_left)
3750 (find_interval, next_interval, update_interval)
3751 (adjust_intervals_for_insertion, delete_node, delete_interval)
3752 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3753 (static_offset_intervals, offset_intervals)
3754 (merge_interval_right, merge_interval_left, make_new_interval)
3755 (graft_intervals_into_buffer, temp_set_point_both)
3756 (temp_set_point, set_point, adjust_for_invis_intang)
3757 (set_point_both, move_if_not_intangible, get_property_and_range)
3758 (get_local_map, copy_intervals, copy_intervals_to_string)
3759 (compare_string_intervals, set_intervals_multibyte_1):
3760 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3761 * intervals.h: Adjust decls to match defn changes elsewhere.
3762 (struct interval):
3763 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3764 * keyboard.c (this_command_key_count, this_single_command_key_start)
3765 (before_command_key_count, before_command_echo_length, echo_now)
3766 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
3767 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
3768 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
3769 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
3770 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3771 (last_non_minibuf_size, last_point_position, echo_truncate)
3772 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
3773 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
3774 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
3775 (stuff_buffered_input):
3776 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3777 (last_auto_save, command_loop_1, read_char):
3778 Use EMACS_INT, not int, to avoid integer overflow.
3779 (record_char): Avoid overflow in total_keys computation.
3780 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
3781 * keyboard.h: Adjust decls to match defn changes elsewhere.
3782 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
3783 (Fkey_description, Fdescribe_vector, Flookup_key):
3784 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3785 (click_position): New function, to check that positions are in range.
3786 (Fcurrent_active_maps):
3787 (describe_command):
3788 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3789 (Faccessible_keymaps, Fkey_description):
3790 (preferred_sequence_p):
3791 Don't assume fixnum can fit into int.
3792 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
3793 Check for integer overflow in size calculations.
3794 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
3795 avoid mishandling large integers.
3796 * lisp.h: Adjust decls to match defn changes elsewhere.
3797 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
3798 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
3799 (struct Lisp_Marker):
3800 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3801 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
3802 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
3803 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
3804 All callers changed.
3805 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
3806 Assume the arg has valid form, since it always does.
3807 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
3808 unsigned integer system type.
3809 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
3810 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
3811 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3812 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
3813 (duration_to_sec_usec): New decl.
3814 * lread.c (read_from_string_index, read_from_string_index_byte)
3815 (read_from_string_limit, readchar, unreadchar, openp)
3816 (read_internal_start, read1, oblookup):
3817 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3818 (Fload, readevalloop, Feval_buffer, Feval_region):
3819 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3820 (openp): Check for out-of-range argument to 'access'.
3821 (read1): Use int, not EMACS_INT, where int is wide enough.
3822 Don't assume fixnum fits into int.
6efdadfd 3823 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
3824 (read_filtered_event): Use duration_to_sec_usec
3825 to do proper overflow checking on durations.
d311d28c
PE
3826 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
3827 in size calculation.
3828 (Fexecute_kbd_macro):
3829 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3830 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
3831 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
3832 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
3833 (set_marker_both, set_marker_restricted_both, marker_position)
3834 (marker_byte_position, Fbuffer_has_markers_at):
3835 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3836 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 3837 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
3838 It now merely ensures that the menu is large enough, without
3839 necessarily growing it, as this avoids some integer overflow issues.
3840 All callers changed.
3841 (keymap_panes, parse_single_submenu, Fx_popup_menu):
3842 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3843 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
3844 Use SAFE_ALLOCA_LISP, not alloca.
3845 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
3846 to EMACS_INT. Check that fixnums are in proper range for system types.
3847 * minibuf.c (minibuf_prompt_width, string_to_object)
3848 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
3849 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
3850 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3851 (get_minibuffer, read_minibuf_unwind):
3852 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3853 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
3854 this simplifies overflow checking. All callers changed.
3855 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
3856 (Ftest_completion):
3857 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3858 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
3859 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
3860 Check that fixnums are in proper range for system types.
3861 (Fx_create_frame, Fx_show_tip):
3862 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3863 * nsfont.m (ns_findfonts, nsfont_list_family):
3864 Don't assume fixnum fits in long.
3865 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
3866 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3867 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
3868 wide enough.
17fdb222 3869 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
3870 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3871 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
3872 (PRINTDECLARE, PRINTPREPARE):
3873 (strout, print_string):
3874 (print, print_preprocess, print_check_string_charset_prop)
3875 (print_object):
3876 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3877 (PRINTDECLARE):
3878 (temp_output_buffer_setup, Fprin1_to_string, print_object):
3879 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3880 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 3881 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 3882 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
3883 (print_error_message): Use SAFE_ALLOCA, not alloca.
3884 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
3885 (print_depth, new_backquote_output, print_number_index):
3886 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
3887 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
3888 (Fset_process_window_size, Fformat_network_address)
3889 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 3890 (sigchld_handler):
d311d28c 3891 Check that fixnums are in proper range for system types.
d44287d4 3892 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
3893 Check for process-ids out of pid_t range rather than relying on
3894 undefined behavior.
e4d81efc 3895 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
3896 (Fformat_network_address, read_process_output, send_process)
3897 (Fprocess_send_region, status_notify):
3898 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3899 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
3900 (wait_reading_process_output, read_process_output, exec_sentinel):
3901 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3902 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
3903 (Faccept_process_output): Use duration_to_sec_usec to do proper
3904 overflow checking on durations.
dde14581
PE
3905 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
3906 Don't assume pid_t fits in int.
02481186
PE
3907 * process.h (struct Lisp_Process): Members tick and update_tick
3908 are now of type EMACS_INT, not int.
b62b53e8
PE
3909 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
3910 configured --with-wide-int.
d311d28c
PE
3911 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
3912 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
3913 * search.c (looking_at_1, string_match_1):
3914 (fast_string_match, fast_c_string_match_ignore_case)
3915 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
3916 (scan_newline, find_before_next_newline, search_command)
3917 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
3918 (set_search_regs, wordify):
3919 (Freplace_match):
3920 (Fmatch_data):
3921 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3922 (string_match_1, search_buffer, set_search_regs):
3923 (Fmatch_data):
3924 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3925 (wordify): Check for overflow in size calculation.
3926 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
3927 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
3928 Check that fixnums are in proper range for system types.
3929 * sound.c (struct sound_device)
3930 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
3931 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3932 (Fplay_sound_internal):
3933 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 3934 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
3935 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
3936 (Fparse_partial_sexp):
3937 Don't assume fixnums can fit in int.
3938 (struct lisp_parse_state, find_start_pos, find_start_value)
3939 (find_start_value_byte, find_start_begv)
3940 (update_syntax_table, char_quoted, dec_bytepos)
3941 (find_defun_start, prev_char_comend_first, back_comment):
3942 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
3943 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
3944 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3945 (Finternal_describe_syntax_value): Check that match_lisp is a
3946 character, not an integer, since the code stuffs it into int.
3947 (scan_words, scan_sexps_forward):
3948 Check that fixnums are in proper range for system types.
3949 (Fforward_word):
3950 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3951 (scan_sexps_forward):
3952 Use CHARACTERP, not INTEGERP, since the value must fit into int.
3953 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
3954 * syntax.h: Adjust decls to match defn changes elsewhere.
3955 (struct gl_state_s):
3956 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
3957 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
3958 MOST_POSITIVE_FIXNUM.
d311d28c
PE
3959 * sysdep.c (wait_for_termination_1, wait_for_termination)
3960 (interruptible_wait_for_termination, mkdir):
3961 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
3962 (emacs_read, emacs_write):
3963 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
3964 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
3965 and double all fit in int.
d311d28c
PE
3966 * term.c (set_tty_color_mode):
3967 Check that fixnums are in proper range for system types.
3968 * termhooks.h (struct input_event):
3969 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3970 * textprop.c (validate_interval_range, interval_of)
3971 (Fadd_text_properties, set_text_properties_1)
3972 (Fremove_text_properties, Fremove_list_of_text_properties)
3973 (Ftext_property_any, Ftext_property_not_all)
3974 (copy_text_properties, text_property_list, extend_property_ranges)
3975 (verify_interval_modification):
3976 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3977 (Fnext_single_char_property_change)
3978 (Fprevious_single_char_property_change):
3979 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
3980 (copy_text_properties):
3981 Check for integer overflow in index calculation.
d311d28c
PE
3982 * undo.c (last_boundary_position, record_point, record_insert)
3983 (record_delete, record_marker_adjustment, record_change)
3984 (record_property_change):
3985 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3986 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
3987 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3988 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3989 (Fx_hide_tip, Fx_file_dialog):
3990 * w32menu.c (set_frame_menubar):
3991 Use ptrdiff_t, not int, for consistency with rest of code.
3992 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
3993 (select_window, Fdelete_other_windows_internal)
3994 (window_scroll_pixel_based, window_scroll_line_based)
3995 (Frecenter, Fset_window_configuration):
3996 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3997 (Fset_window_hscroll, run_window_configuration_change_hook)
3998 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 3999 (Fscroll_other_window, Frecenter):
d311d28c
PE
4000 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4001 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
4002 Don't assume fixnum fits in int.
4003 (Fset_window_scroll_bars):
4004 Check that fixnums are in proper range for system types.
4005 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
4006 (string_pos, c_string_pos, number_of_chars, init_iterator)
4007 (in_ellipses_for_invisible_text_p, init_from_display_pos)
4008 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
4009 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
4010 (face_before_or_after_it_pos, handle_invisible_prop)
4011 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
4012 (display_prop_intangible_p, string_buffer_position_lim)
4013 (string_buffer_position, handle_composition_prop, load_overlay_strings)
4014 (get_overlay_strings_1, get_overlay_strings)
4015 (iterate_out_of_display_property, forward_to_next_line_start)
4016 (back_to_previous_visible_line_start, reseat, reseat_to_string)
4017 (get_next_display_element, set_iterator_to_next)
4018 (get_visually_first_element, compute_stop_pos_backwards)
4019 (handle_stop_backwards, next_element_from_buffer)
4020 (move_it_in_display_line_to, move_it_in_display_line)
4021 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4022 (add_to_log, message_dolog, message_log_check_duplicate)
4023 (message2, message2_nolog, message3, message3_nolog
4024 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
4025 (current_message_1, truncate_echo_area, truncate_message_1)
4026 (set_message, set_message_1, store_mode_line_noprop)
4027 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
4028 (text_outside_line_unchanged_p, check_point_in_composition)
4029 (reconsider_clip_changes)
4030 (redisplay_internal, set_cursor_from_row, try_scrolling)
4031 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
4032 (redisplay_window, find_last_unchanged_at_beg_row)
4033 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
4034 (trailing_whitespace_p, find_row_edges, display_line)
4035 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
4036 (display_mode_element, store_mode_line_string)
4037 (pint2str, pint2hrstr, decode_mode_spec)
4038 (display_count_lines, display_string, draw_glyphs)
4039 (x_produce_glyphs, x_insert_glyphs)
4040 (rows_from_pos_range, mouse_face_from_buffer_pos)
4041 (fast_find_string_pos, mouse_face_from_string_pos)
4042 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4043 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4044 (safe_call, init_from_display_pos, handle_fontified_prop)
4045 (handle_single_display_spec, load_overlay_strings)
4046 (with_echo_area_buffer, setup_echo_area_for_printing)
4047 (display_echo_area, echo_area_display)
4048 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
4049 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
4050 (redisplay_window, dump_glyph_row, display_mode_line)
4051 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 4052 (handle_display_spec, display_prop_string_p):
d311d28c
PE
4053 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4054 (handle_single_display_spec, build_desired_tool_bar_string)
4055 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
4056 (get_specified_cursor_type):
4057 Check that fixnums are in proper range for system types.
4058 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
4059 (Flookup_image_map):
4060 Don't assume fixnums fit in int.
4061 (compare_overlay_entries):
4062 Avoid mishandling comparisons due to subtraction overflow.
4063 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
4064 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
4065 (handle_tool_bar_click):
4066 Use int, not unsigned, since we prefer signed and the signedness
4067 doesn't matter here.
4068 (get_next_display_element, next_element_from_display_vector):
4069 Use int, not EMACS_INT, when int is wide enough.
4070 (start_hourglass): Use duration_to_sec_usec to do proper
4071 overflow checking on durations.
4072 * xfaces.c (Fbitmap_spec_p):
4073 Check that fixnums are in proper range for system types.
4074 (compare_fonts_by_sort_order):
4075 Avoid mishandling comparisons due to subtraction overflow.
4076 (Fx_family_fonts, realize_basic_faces):
4077 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4078 (Fx_family_fonts):
4079 Don't assume fixnum fits in int.
4080 Use SAFE_ALLOCA_LISP, not alloca.
4081 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
4082 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
4083 (face_at_buffer_position, face_for_overlay_string)
4084 (face_at_string_position):
4085 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4086 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
4087 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
4088 (Fx_show_tip):
4089 Check that fixnums are in proper range for system types.
4090 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4091 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
4092 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4093 (Fx_change_window_property): Don't assume fixnums fit in int.
4094 * xfont.c (xfont_chars_supported):
4095 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4096 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
4097 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
4098 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4099 * xml.c (parse_region):
4100 * xrdb.c (magic_file_p):
4101 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4102 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
4103 (x_get_local_selection, x_reply_selection_request)
4104 (x_handle_selection_request, wait_for_property_change):
4105 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4106 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
4107 short is wide enough.
4108 (x_send_client_event): Don't assume fixnum fits in int.
4109 * xterm.c (x_x_to_emacs_modifiers):
4110 Don't assume EMACS_INT overflows nicely into int.
4111 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
4112 may come from Lisp.
4113 (handle_one_xevent): NATNUMP can eval its arg twice.
4114 (x_connection_closed):
4115 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4116 * xterm.h: Adjust decls to match defn changes elsewhere.
4117 (struct scroll_bar): Use struct vectorlike_header
4118 rather than rolling our own approximation.
4119 (SCROLL_BAR_VEC_SIZE): Remove; not used.
4120
c6574eb5
GM
41212012-05-25 Glenn Morris <rgm@gnu.org>
4122
4123 * lisp.mk (lisp): Update for more files being compiled now.
4124
e8d32c7e
SM
41252012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
4126
48def666
SM
4127 * lread.c: Remove `read_pure' which makes no difference.
4128 (read_pure): Remove var.
4129 (unreadpure): Remove function.
4130 (readevalloop): Don't call read_list with -1 flag.
4131 (read1, read_vector): Don't test read_pure any more.
4132 (read_list): Simplify.
4133
e8d32c7e
SM
4134 * fileio.c, character.h: Minor style tweaks.
4135
4b2addb7
DA
41362012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
4137
4138 * window.h (clip_changed): Remove useless declaration.
4139
584461b2
JB
41402012-05-22 Juanma Barranquero <lekktu@gmail.com>
4141
4142 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
4143 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
4144
34374650
PE
41452012-05-22 Paul Eggert <eggert@cs.ucla.edu>
4146
4147 Remove src/m/*.
4148 This directory predates autoconf and is no longer needed nowadays.
4149 Move its few remaining bits of functionality to where they're needed.
4150 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
4151 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
4152 * m/template.h: Remove.
4153 * Makefile.in (M_FILE): Remove. All uses removed.
4154 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
4155 * lisp.h (USE_LSB_TAG):
4156 * mem-limits.h (EXCEEDS_LISP_PTR):
4157 Use VAL_MAX, not VALBITS, in #if.
4158 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
4159 (EMACS_UINT): Define unconditionally now.
4160 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
4161 (BITS_PER_EMACS_INT): New constants, replacing
4162 what used to be in config.h, but not useful in #if.
4163 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
4164 define them any more.
4165 (VAL_MAX): New macro.
4166 (VALMASK): Use it.
4167 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
4168 BITS_PER_EMACS_INT, in #if.
4169 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
4170 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
4171 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
4172 * s/ms-w32.h (DATA_START):
4173 Move here from removed file m/intel386.h.
4174 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
4175 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
4176
261cb4bb
PE
41772012-05-21 Paul Eggert <eggert@cs.ucla.edu>
4178
4179 Assume C89 or later.
4180 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
4181 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
4182 (xrealloc):
4183 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
4184 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
4185 * textprop.c, tparam.c (NULL): Remove.
4186 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
4187 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
4188 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
4189 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
4190 * xterm.c (input_signal_count): Assume volatile works.
4191
ff23cd9f
KB
41922012-05-21 Ken Brown <kbrown@cornell.edu>
4193
4194 * xgselect.c (xg_select): Fix first argument in call to 'select'
4195 (bug#11508).
4196
1b170bc6
KB
41972012-05-20 Ken Brown <kbrown@cornell.edu>
4198
4199 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 4200 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 4201
b2f4d39f
KB
42022012-05-19 Ken Brown <kbrown@cornell.edu>
4203
4204 * xfns.c (x_in_use): Remove `static' qualifier.
4205 * xterm.h (x_in_use): Declare.
4206 * xgselect.c: Include xterm.h.
4207 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
4208 and `display_arg' (bug#9754).
4209
003fdae2
PE
42102012-05-19 Paul Eggert <eggert@cs.ucla.edu>
4211
9232a6d9
PE
4212 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
4213
003fdae2
PE
4214 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
4215 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
4216
784b56e2
EZ
42172012-05-18 Eli Zaretskii <eliz@gnu.org>
4218
4219 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
4220
4221 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 4222 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
4223
4224 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
4225 reference to image_cache->refcount.
4226 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
4227
a0a79cde
JL
42282012-05-17 Juri Linkov <juri@jurta.org>
4229
4230 * search.c (Fword_search_regexp, Fword_search_backward)
4231 (Fword_search_forward, Fword_search_backward_lax)
4232 (Fword_search_forward_lax): Move functions to isearch.el
4233 (bug#10145, bug#11381).
4234
b0572523
PE
42352012-05-16 Paul Eggert <eggert@cs.ucla.edu>
4236
4237 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
4238
9660f5fc
SM
42392012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
4240
4241 * lread.c (init_obarray): Declare Qt and Qnil as special.
4242
4374de83
GM
42432012-05-14 Glenn Morris <rgm@gnu.org>
4244
4245 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 4246 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 4247
dc44c39a
PE
42482012-05-14 Paul Eggert <eggert@cs.ucla.edu>
4249
078c97cb
PE
4250 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
4251
dc44c39a
PE
4252 * unexaix.c: Port to more-recent AIX compilers.
4253 (report_error, report_error_1, make_hdr, copy_sym)
4254 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
4255 Make arguments const char *, not char *, to avoid violations of C
4256 standard and to fix some AIX warnings reported by Gilles Pion.
4257
e18afed7 42582012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
4259
4260 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
4261 already have overlays loaded.
4262 (handle_single_display_spec): Before returning without displaying
4263 fringe bitmap, synchronize the bidi iterator with the main display
4264 iterator, by calling iterate_out_of_display_property.
4265 (iterate_out_of_display_property): Detect buffer iteration by
4266 testing that it->string is a Lisp string.
4267 (get_next_display_element): When the current object is exhausted,
4268 and there's something on it->stack, call set_iterator_to_next to
4269 proceed with what's on the stack, instead of returning zero.
4270 (set_iterator_to_next): If called at the end of a Lisp string,
4271 proceed to consider_string_end without incrementing string
4272 position. Don't increment display vector index past the end of
4273 the display vector. (Bug#11417)
c8fb9dc6
EZ
4274 (pos_visible_p): Don't report a position visible when move_it_to
4275 stopped at the last line of window, which happens to be scanned
4276 backwards by the bidi iteration. (Bug#11464)
ac268e67 4277
e18afed7 42782012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
4279
4280 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
4281 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
4282 are on a TTY, and thus unable to display on the fringes.
4283 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
4284 so we need to signal to the caller that this is a "replacing"
4285 display spec. This fixes display when the spec is invalid or we
4286 are on a TTY.
4287
e18afed7 42882012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
4289
4290 * unexaix.c (make_hdr): Fix typo in prototype.
4291 This bug broke the build on AIX. Problem reported by Gilles Pion.
4292
9d0a235a
MA
42932012-05-14 Michael Albinus <michael.albinus@gmx.de>
4294
4295 * keyboard.c (kbd_buffer_get_event): Read special events also in
4296 batch mode. (Bug#11415)
4297
9e6b06ed
GM
42982012-05-12 Glenn Morris <rgm@gnu.org>
4299
4300 * ns.mk: Update for ns_appbindir no longer having trailing "/".
4301
c1a1d7a3
EZ
43022012-05-12 Eli Zaretskii <eliz@gnu.org>
4303
4304 * lisp.mk (lisp): Add newcomment.elc.
4305
3fe7cdc8
GM
43062012-05-12 Glenn Morris <rgm@gnu.org>
4307
4308 * Makefile.in (MKDIR_P): New, set by configure.
4309 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
4310
53f7d2c0
PE
43112012-05-11 Paul Eggert <eggert@cs.ucla.edu>
4312
4313 Remove unused function hourglass_started.
4314 * dispextern.h (hourglass_started):
4315 * w32fns.c (hourglass_started):
4316 * xdisp.c (hourglass_started): Remove.
4317
75aafb17
JB
43182012-05-10 Juanma Barranquero <lekktu@gmail.com>
4319
4320 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
4321 Update dependencies.
4322
12959e8e
PE
43232012-05-10 Paul Eggert <eggert@cs.ucla.edu>
4324
97107e2e
PE
4325 * xgselect.c (xg_select): Put maxfds+1 into a var.
4326 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
4327
12959e8e
PE
4328 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
4329
836d29b3
DA
43302012-05-10 Dave Abrahams <dave@boostpro.com>
4331
4332 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
4333 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
4334
5cb67954
MA
43352012-05-09 Michael Albinus <michael.albinus@gmx.de>
4336
4337 * dbusbind.c (xd_registered_buses): New internal Lisp object.
4338 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
4339 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
4340 Initialize xd_registered_buses.
4341
3478ec45
PE
43422012-05-09 Paul Eggert <eggert@cs.ucla.edu>
4343
b263a6b0
PE
4344 Untag more efficiently if USE_LSB_TAG.
4345 This is based on a proposal by YAMAMOTO Mitsuharu in
4346 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
4347 For an admittedly artificial (nth 8000 longlist) benchmark on
4348 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
4349 Emacs's overall text size by 1%.
4350 * lisp.h (XUNTAG): New macro.
4351 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
4352 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
4353 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
4354 * eval.c (Fautoload):
4355 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
4356 * frame.h (XFRAME): Use XUNTAG.
4357
3478ec45
PE
4358 Port recent dbusbind.c changes to 32-bit --with-wide-int.
4359 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
4360 Remove unportable assumptions about print widths of types like
4361 dbus_uint32_t.
4362 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
4363 intptr_t when converting between pointer and integer, to avoid GCC
4364 warnings about wrong width.
4365
666b903b 43662012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
4367
4368 * w32proc.c (new_child): Force Windows to reserve only 64KB of
4369 stack for each reader_thread, instead of defaulting to 8MB
4370 determined by the linker. This avoids failures in creating
4371 subprocesses on Windows 7, see the discussion in this thread:
4372 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
4373
b120cc17
JC
43742012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
4375
4376 Fix up display of the *Minibuf-0* buffer in the mini window.
4377 * keyboard.c (read_char): Don't clear the echo area if there's no
4378 message to clear.
4379 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 4380 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 4381
9a4b36f8
MA
43822012-05-07 Michael Albinus <michael.albinus@gmx.de>
4383
4384 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
4385 batch mode.
4386
e5f9458f
CY
43872012-05-06 Chong Yidong <cyd@gnu.org>
4388
4389 * lisp.mk (lisp): Update.
4390
eceeb5fc 43912012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
4392
4393 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
4394
71873e2b
SM
43952012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
4396
4397 * data.c (PUT_ERROR): New macro.
4398 (syms_of_data): Use it. Add new error type `user-error'.
4399 * undo.c (user_error): New function.
4400 (Fprimitive_undo): Use it.
4401 * print.c (print_error_message): Adjust print style for `user-error'.
4402 * keyboard.c (user_error): New function.
4403 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
4404
ab0fa4e4
PE
44052012-05-03 Paul Eggert <eggert@cs.ucla.edu>
4406
4407 Do not limit current-time-string to years 1000..9999.
4408 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
4409 (Fcurrent_time_string): Support any year that is supported by the
4410 underlying localtime representation. Don't use asctime, as it
4411 has undefined behavior for years outside the range -999..9999.
4412
7ed806a7
PE
44132012-05-02 Paul Eggert <eggert@cs.ucla.edu>
4414
4415 Fix race conditions involving setenv, gmtime, localtime, asctime.
4416 Without this fix, interrupts could mess up code that uses these
4417 nonreentrant functions, since setting TZ invalidates existing
4418 tm_zone or tzname values, and since most of these functions return
4419 pointers to static storage.
4420 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
4421 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
4422 Grow the critical sections to include not just invoking
4423 localtime/gmtime, but also accessing these functions' results
4424 including their tm_zone values if any, and any related TZ setting.
4425 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
4426 so that the struct tm is saved in the critical section.
4427 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
4428 motivated by the fact that memory allocation needs to be outside
4429 the critical section.
4430
0c16dfed
DA
44312012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
4432
4433 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
4434 with RESET_INTERVAL.
4435
4436 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4437 Remove duplicated buffer name initialization.
4438
3f83ace8
JM
44392012-05-02 Jim Meyering <jim@meyering.net>
4440
4441 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
4442
c7b8541e
JM
4443 * xfns.c (x_window): Use xstrdup (Bug#11375).
4444
90207a15 44452012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
4446
4447 * xdisp.c (pos_visible_p): If already at a newline from the
4448 display string before the 'while' loop, don't walk back the glyphs
4449 from it3.glyph_row. Solves assertion violation when the display
4450 string begins with a newline (egg.el). (Bug#11367)
4451
b593d6a9
AH
44522012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
4453
4454 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
4455 Move to simple.el.
4456
4737362e
GM
44572012-05-01 Glenn Morris <rgm@gnu.org>
4458
99cf43f9
GM
4459 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
4460 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
4461 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
4462 All were removed before 23.1.
4463
9311dcff
GM
4464 * dispnew.c: Remove HAVE_LIBNCURSES test;
4465 it is always true on relevant platforms.
4466
4d5c6349
GM
4467 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
4468 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
4469
4737362e
GM
4470 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
4471
74dd3a6b
AS
44722012-04-30 Andreas Schwab <schwab@linux-m68k.org>
4473
4474 * .gdbinit (xpr): Remove checks for no longer existing misc types.
4475 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
4476 Remove.
4477
13c379ee
PE
44782012-04-28 Paul Eggert <eggert@cs.ucla.edu>
4479
4480 Do not avoid creating empty evaporating overlays (Bug#9642).
4481 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
4482 That is, do not delete an evaporating overlay if it becomes
4483 empty after its bounds are adjusted to fit within its buffer.
4484 This fix caused other problems, and I'm reverting it until we get
4485 to the bottom of them.
4486
a8e7d6d7 44872012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
4488
4489 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
4490
a8e7d6d7 44912012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
4492
4493 * xdisp.c (pos_visible_p): If the window start position is beyond
4494 ZV, start the display from buffer beginning. Prevents assertion
4495 violation in init_iterator when the minibuffer window is scrolled
4496 via the scroll bar.
4497
4498 * window.c (window_scroll_pixel_based): Likewise.
4499
a8e7d6d7 45002012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
4501
4502 * keymap.c (where_is_internal): Doc fix (Bug#10872).
4503
a8e7d6d7 45042012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
4505
4506 * fileio.c (Fcopy_file, Fset_file_selinux_context):
4507 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
4508
a8e7d6d7 45092012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 4510
b593d6a9
AH
4511 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
4512 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 4513
1c6900d9
EZ
45142012-04-26 Eli Zaretskii <eliz@gnu.org>
4515
4c3fa1d9
EZ
4516 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
4517 display element, check also the underlying string or buffer
4518 character. (Bug#11341)
4519
1c6900d9
EZ
4520 * w32menu.c: Include w32heap.h.
4521 (add_menu_item): If the call to AppendMenuW (via
4522 unicode_append_menu) fails, disable Unicode menus only if we are
4523 running on Windows 9X/Me.
4524
42bf8205
AS
45252012-04-24 Andreas Schwab <schwab@linux-m68k.org>
4526
4527 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
4528 (xgetint): Add missing shift for LSB tags.
4529
b1bac16e
MR
45302012-04-24 Martin Rudalics <rudalics@gmx.at>
4531
4532 * keyboard.c (read_char): Don't wipe echo area for select window
4533 events: These might get delayed via `mouse-autoselect-window'
4534 (Bug#11304).
4535
d69621cc
JB
45362012-04-24 Juanma Barranquero <lekktu@gmail.com>
4537
4538 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
4539 manipulation of :loaded-from data.
4540
02fd101b
JB
45412012-04-23 Juanma Barranquero <lekktu@gmail.com>
4542
4543 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
4544 now a cons (bug#11311).
4545
888bec30
PE
45462012-04-23 Paul Eggert <eggert@cs.ucla.edu>
4547
89a438bd
PE
4548 Do not create empty overlays with the evaporate property (Bug#9642).
4549 * buffer.c (Fmove_overlay): Delete an evaporating overlay
4550 if it becomes empty after its bounds are adjusted to fit within
4551 its buffer. Without this fix, in a nonempty buffer (let ((o
4552 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
4553 yields an empty overlay that has the evaporate property, which is
4554 not supposed to happen.
4555
1068fe4d
PE
4556 Fix minor GTK3 problems found by static checking.
4557 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4558 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4559 (struct _EmacsFixedClass, emacs_fixed_get_type):
4560 Move decls here from emacsgtkfixed.h, since they needn't be public.
4561 (emacs_fixed_get_type): Now static.
4562 (emacs_fixed_class_init): Omit unused local.
4563 (emacs_fixed_child_type): Remove; unused.
4564 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4565 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4566 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
4567 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
4568 (EMACS_FIXED_GET_CLASS): Remove; unused.
4569 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
4570
888bec30
PE
4571 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
4572 Problem reported by Juanma Barranquero for Windows -Wunused-function.
4573
de85e130
PE
45742012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4575
d0baac98 4576 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 4577 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
4578 (__malloc_size_t, __malloc_ptrdiff_t):
4579 Remove. All uses removed, replaced by the definiens if needed,
4580 since we can assume C89 or better now.
4581 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
4582 (protect_malloc_state, align, get_contiguous_space)
4583 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
4584 (malloc_atfork_handler_child, malloc_enable_thread)
4585 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
4586 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
4587 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
4588 (special_realloc, _realloc_internal_nolock, _realloc_internal)
4589 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
4590 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
4591 Define using prototypes, not old style.
4592 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
4593 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
4594 (align): Don't assume that signed integer overflow wraps around.
4595 Omit unused local var.
4596 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
4597 (_free_internal_nolock, memalign, mallochook, reallochook):
4598 Omit no-longer-needed casts.
4599 (valloc): Use getpagesize, not __getpagesize.
4600 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
4601 (struct hdr): The 'magic' member is now size_t, not unsigned long.
4602
de85e130
PE
4603 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
4604
dcbf5805
MA
46052012-04-22 Michael Albinus <michael.albinus@gmx.de>
4606
4607 Move functions from C to Lisp. Make non-blocking method calls
4608 the default. Implement further D-Bus standard interfaces.
4609
4610 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
4611 (QCdbus_request_name_allow_replacement)
4612 (QCdbus_request_name_replace_existing)
4613 (QCdbus_request_name_do_not_queue)
4614 (QCdbus_request_name_reply_primary_owner)
4615 (QCdbus_request_name_reply_in_queue)
4616 (QCdbus_request_name_reply_exists)
4617 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
4618 (QCdbus_registered_serial, QCdbus_registered_method)
4619 (QCdbus_registered_signal): New Lisp objects.
4620 (XD_DEBUG_MESSAGE): Use sizeof.
4621 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
4622 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
4623 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
4624 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
4625 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
4626 (xd_signature, xd_append_arg): Allow float for integer types.
4627 (xd_get_connection_references): New function.
b593d6a9
AH
4628 (xd_get_connection_address): Rename from xd_initialize.
4629 Return cached address.
dcbf5805
MA
4630 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
4631 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
4632 level.
4633 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 4634 Return number of refcounts.
dcbf5805
MA
4635 (Fdbus_get_unique_name): Make stronger parameter check.
4636 (Fdbus_message_internal): New defun.
4637 (Fdbus_call_method, Fdbus_call_method_asynchronously)
4638 (Fdbus_method_return_internal, Fdbus_method_error_internal)
4639 (Fdbus_send_signal, Fdbus_register_service)
4640 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
4641 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
4642 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
4643 (Vdbus_compiled_version, Vdbus_runtime_version)
4644 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
4645 (Vdbus_message_type_method_return, Vdbus_message_type_error)
4646 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
4647 (Vdbus_registered_buses, Vdbus_registered_objects_table):
4648 Adapt docstring.
dcbf5805 4649
52828e02
PE
46502012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4651
da05bc4c
PE
4652 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
4653 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
4654 Do not assume ptrdiff_t is the same width as 'int'.
4655
52828e02
PE
4656 * alloc.c: Handle unusual debugging option combinations.
4657 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
4658 since the two debugging options are incompatible.
4659 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
4660 is defined.
4661 (mem_init, mem_insert, mem_insert_fixup):
4662 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
4663 (NEED_MEM_INSERT): Remove; no longer needed.
4664
f01769f9
LL
46652012-04-22 Leo Liu <sdl.web@gmail.com>
4666
4667 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
4668
5790543d
PE
46692012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4670
4671 * sysdep.c [__FreeBSD__]: Minor cleanups.
4672 (list_system_processes, system_process_attributes) [__FreeBSD__]:
4673 Use Emacs indenting style more consistently. Avoid some casts.
4674 Use 'double' consistently rather than mixing 'float' and 'double'.
4675
b91b7e4d
EW
46762012-04-21 Eduard Wiebe <usenet@pusto.de>
4677
b593d6a9
AH
4678 * sysdep.c (list_system_processes, system_process_attributes):
4679 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 4680
6114eb15
AS
46812012-04-21 Andreas Schwab <schwab@linux-m68k.org>
4682
4683 * lisp.mk (lisp): Update.
4684
2f38dff7
PE
46852012-04-20 Paul Eggert <eggert@cs.ucla.edu>
4686
4687 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
4688 It is never used otherwise.
4689
4ae29f89
SM
46902012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
4691
4692 * print.c (print_preprocess): Only check print_depth if print-circle
4693 is nil.
4694 (print_object): Check for cycles even when print-circle is nil and
4695 print-gensym is t, but only check print_depth if print-circle is nil.
4696
f30d612a
CY
46972012-04-20 Chong Yidong <cyd@gnu.org>
4698
4699 * process.c (wait_reading_process_output): If EIO occurs on a pty,
4700 set the status to "failed" and ensure that sentinel is run.
4701
c07a4c0b 47022012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
4703
4704 * process.c (Fset_process_inherit_coding_system_flag)
4705 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 4706 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 4707
c07a4c0b 47082012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
4709
4710 * xdisp.c (string_buffer_position_lim): Limit starting position to
4711 BEGV.
4712 (set_cursor_from_row): If called for a mode-line or header-line
4713 row, return zero immediately.
4714 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
4715 farther than the first row after the header line, if any.
4716 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
4717 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
4718
c07a4c0b 47192012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 4720
4ae29f89
SM
4721 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
4722 (bug#11238).
ad3a2b41 4723
c07a4c0b 47242012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 47252012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
4726
4727 configure: new option --enable-gcc-warnings (Bug#11207)
4728 * Makefile.in (C_WARNINGS_SWITCH): Remove.
4729 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
4730 (ALL_CFLAGS): Use new macros rather than old.
4731 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
4732 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
4733 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
4734 -Wunused-result, -Wunused-variable. This should go away once
4735 the Emacs and Gnulib regex code is merged.
4736 (xmalloc, xrealloc): Now static.
4737
aba027e8
PE
47382012-04-17 Paul Eggert <eggert@cs.ucla.edu>
4739
4740 * dired.c (Fsystem_groups): Remove unused local.
4741
e5a36063
GM
47422012-04-17 Glenn Morris <rgm@gnu.org>
4743
4744 * dired.c (Fsystem_users): Doc fix.
4745
316411f0
DA
47462012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
4747
4748 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
4749 (syms_of_dired): Add them.
4750
9426aba4
PE
47512012-04-16 Paul Eggert <eggert@cs.ucla.edu>
4752
b62a57be
PE
4753 Fix minor alloc.c problems found by static checking.
4754 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
4755 New extern decls, to avoid calling undeclared functions.
4756 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
4757 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
4758 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
4759 (NEED_MEM_INSERT): New macro.
4760 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 4761 Remove one incorrect comment and fix another.
b62a57be 4762
3539f31f
PE
4763 Fix minor ralloc.c problems found by static checking.
4764 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4765 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
4766 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
4767 (r_alloc_sbrk): Now static.
4768
a041960a
PE
4769 Improve ralloc.c interface checking.
4770 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4771 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
4772 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
4773 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
4774 [REL_ALLOC]: ... to here, to check interface.
4775 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
4776 Remove decls. This fixes an "It stinks!".
4777
9426aba4
PE
4778 * alloc.c (which_symbols): Fix alignment issue / type clash.
4779
d55c12ed
AS
47802012-04-15 Andreas Schwab <schwab@linux-m68k.org>
4781
4782 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
4783 (struct Lisp_Misc_Any): Likewise.
4784 (struct Lisp_Free): Likewise.
4785 * alloc.c (union aligned_Lisp_Symbol): Define.
4786 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
4787 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
4788 (union aligned_Lisp_Misc): Define.
4789 (MARKER_BLOCK_SIZE, struct marker_block): Use union
4790 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 4791 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 4792
b948ce8b
PE
47932012-04-14 Paul Eggert <eggert@cs.ucla.edu>
4794
4795 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
4796 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
4797 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
4798 * s/netbsd.h, s/sol2-6.h:
4799 Remove definition of GC_MARK_STACK, since the default now works.
4800 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
4801 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
4802 no longer the default.
4803 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
4804
35dc09a1 48052012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 4806
35dc09a1
GM
4807 * lread.c (lisp_file_lexically_bound_p):
4808 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 4809
35dc09a1
GM
48102012-04-14 Eli Zaretskii <eliz@gnu.org>
4811
4812 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
4813 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
4814
48152012-04-14 Jan Djärv <jan.h.d@swipnet.se>
4816
4817 * nsterm.m (constrainFrameRect): Always constrain when there is only
4818 one screen (Bug#10962).
4819
bcd86815
KB
48202012-04-13 Ken Brown <kbrown@cornell.edu>
4821
4822 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
4823
c25df26e
RT
48242012-04-13 Reuben Thomas <rrt@sc3d.org>
4825
4826 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
4827
0fc59f1e
DC
48282012-04-11 Daniel Colascione <dancol@dancol.org>
4829
4830 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
4831 against is gone. It's better to use vfork now so that when Cygwin
4832 gains a new, working vfork, we use it automatically (bug#10398).
4833
de8c03dc
SM
48342012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4835
4836 * window.c (save_window_save): Obey window-point-insertion-type.
4837
2f097256
GM
48382012-04-11 Glenn Morris <rgm@gnu.org>
4839
4840 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
4841
453b951e
SM
48422012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4843
4844 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
4845
75f1671a 48462012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
4847
4848 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
4849 (force_quit_count): New var.
4850 (handle_interrupt): Use it.
4851
2a8ce227
JB
48522012-04-10 Juanma Barranquero <lekktu@gmail.com>
4853
4854 * w32.c (w32_delayed_load): Record the full path of the library
4855 being loaded (bug#10424).
4856
935396c0
GM
48572012-04-09 Glenn Morris <rgm@gnu.org>
4858
05920a43
GM
4859 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
4860 not just in the obarray, before snarfing them. (Bug#11036)
4861
935396c0
GM
4862 * Makefile.in ($(leimdir)/leim-list.el):
4863 Pass EMACS rather than BUILT_EMACS.
4864
a18ecafa
TZ
48652012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
4866
4867 * process.c (make_process):
4868 * process.h: Add integer `gnutls_handshakes_tried' member to
4869 process struct.
4870
6bbef4e5
JC
4871 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
4872 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
4873
4874 * gnutls.c (gnutls_log_function2i): Convenience log function.
4875 (emacs_gnutls_read): Use new log functions,
4876 `gnutls_handshakes_tried' process member, and
4877 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
4878 attempts per process (connection).
4879
b4d3bc10
CY
48802012-04-09 Chong Yidong <cyd@gnu.org>
4881
4882 * eval.c (Fuser_variable_p, user_variable_p_eh)
4883 (lisp_indirect_variable): Functions deleted.
4884 (Fdefvar): Caller changed.
4885
4886 * callint.c (Finteractive, Fcall_interactively):
4887 * minibuf.c (Fread_variable): Callers changed.
4888
70f4d973
EZ
48892012-04-09 Eli Zaretskii <eliz@gnu.org>
4890
4891 * xdisp.c (set_cursor_from_row): If the display string appears in
4892 the buffer at position that is closer to point than the position
4893 after the display string, display the cursor on the first glyph of
4894 the display string. Fixes cursor display when a 'display' text
4895 property immediately follows invisible text. (Bug#11094)
4896
cb3c2e3e
PE
48972012-04-09 Paul Eggert <eggert@cs.ucla.edu>
4898
4899 composite.c: use 'double' consistently
4900 * composite.c (get_composition_id): Use 'double' consistently
4901 instead of converting 'float' to 'double' and vice versa; this is
4902 easier to understand and avoids a GCC warning.
4903
fd06db5d
GM
49042012-04-09 Glenn Morris <rgm@gnu.org>
4905
50fe702a
GM
4906 * Makefile.in: Generate leim-list with bootstrap-emacs, in
4907 preparation for dumping it with emacs. (Bug#4789)
4908 (leimdir): New variable.
4909 ($(leimdir)/leim-list.el): New rule.
4910 (emacs$(EXEEXT)): Depend on leim-list.el.
4911
fd06db5d
GM
4912 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
4913 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
4914 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
4915
55c131ee
AS
49162012-04-08 Andreas Schwab <schwab@linux-m68k.org>
4917
4918 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
4919 proper alignment.
4920
9209588f
JB
49212012-04-07 Juanma Barranquero <lekktu@gmail.com>
4922
4923 * xml.c (init_libxml2_functions) [WINDOWSNT]:
4924 Remove unused local variable.
4925
e3fb2efb
PE
49262012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4927
4928 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
4929 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
4930 (mark_memory): Mark Lisp_Objects only if pointers might hide in
4931 objects, as mark_maybe_pointer will catch them otherwise.
4932 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
4933 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
4934
b5385551
PE
49352012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4936
4937 Fix typo that broke non-Windows builds.
4938 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
4939
9078ead6
EZ
49402012-04-07 Eli Zaretskii <eliz@gnu.org>
4941
4942 Support building on MS-Windows with libxml2.
4943
4944 * makefile.w32-in (OBJ2): Add xml.$(O).
4945 (GLOBAL_SOURCES): Add xml.c.
4946 ($(BLD)/xml.$(O)): New dependency list.
4947
4948 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
4949 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
4950 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
4951 [!WINDOWSNT]: New macros.
4952 (init_libxml2_functions, libxml2_loaded_p): New functions.
4953 (parse_region): Call fn_xmlCheckVersion instead of using the macro
4954 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
4955 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
4956 Calls xmlCleanupParser only if libxml2 was loaded (or statically
4957 linked in).
6bbef4e5
JC
4958 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
4959 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
4960 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
4961
4962 * emacs.c: Don't include libxml/parser.h.
4963 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
4964 xmlCleanupParser directly.
4965
4966 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
4967
3811fdf3
EZ
49682012-04-07 Eli Zaretskii <eliz@gnu.org>
4969
4970 * indent.c (Fvertical_motion): If there is a display string at
4971 point, use it.vpos to compute how many lines to backtrack after
4972 move_it_to point. (Bug#11133)
4973
2f8e16b2
EZ
49742012-04-06 Eli Zaretskii <eliz@gnu.org>
4975
4976 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
4977 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
4978 about subtle differences between FETCH_CHAR* and STRING_CHAR*
4979 macros related to unification of CJK characters. For the details,
4980 see the discussion following the message here:
4981 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
4982
3d439cd1
CY
49832012-04-04 Chong Yidong <cyd@gnu.org>
4984
4985 * keyboard.c (Vdelayed_warnings_list): Doc fix.
4986
8bc53d00
EZ
49872012-04-01 Eli Zaretskii <eliz@gnu.org>
4988
4989 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
4990 instead of alloca. (Bug#11138)
4991
3b0512a3
AS
49922012-04-01 Andreas Schwab <schwab@linux-m68k.org>
4993
4994 * w32menu.c (is_simple_dialog): Properly check lisp types.
4995 (Bug#11141)
4996
8427ddd2
EZ
49972012-03-31 Eli Zaretskii <eliz@gnu.org>
4998
979022ef
EZ
4999 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
5000 position we get to after a call to move_it_to fails the
5001 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
5002 only if we wind up in a string from display property. (Bug#11063)
5003
a6b1c7cc
EZ
5004 * window.c (Fdelete_other_windows_internal): Invalidate the row
5005 and column information about mouse highlight, so that redisplay
5006 restores it after reallocating the glyph matrices. (Bug#7464)
5007
8427ddd2
EZ
5008 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
5009 string comes from a `display' text property, use the buffer
5010 position of that property as if we actually saw that position in
5011 the row's glyphs.
697ba24b
EZ
5012 (move_it_by_lines): Remove the assertion that
5013 "it->current_x == 0 && it->hpos == 0" which can be legitimately
5014 violated when there's a before-string at the beginning of a line.
5015 (Bug#11063)
8427ddd2 5016
65a0a738
EZ
50172012-03-30 Eli Zaretskii <eliz@gnu.org>
5018
5019 * xdisp.c (append_space_for_newline): If the default face was
5020 remapped, use the remapped face for the appended newline.
5021 (extend_face_to_end_of_line): Use the remapped default face for
5022 extending the face to the end of the line.
5023 (display_line): Call extend_face_to_end_of_line when the default
5024 face was remapped. (Bug#11068)
5025
581355cc
EZ
50262012-03-29 Eli Zaretskii <eliz@gnu.org>
5027
5028 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
5029
e8fc049f
SM
50302012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5031
5032 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
5033
4fb9a543
GM
50342012-03-27 Glenn Morris <rgm@gnu.org>
5035
5036 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
5037 Doc fixes.
5038
679910f1
KH
50392012-03-26 Kenichi Handa <handa@m17n.org>
5040
5041 * dispextern.h (struct glyph): Fix previous change. Change the
5042 bit length of glyphless.ch to 25 (Bug#11082).
5043
90d49b7f
CY
50442012-03-26 Chong Yidong <cyd@gnu.org>
5045
5046 * keyboard.c (Vselection_inhibit_update_commands): New variable.
5047 (command_loop_1): Use it; inhibit selection update for
5048 handle-select-window too (Bug#8996).
5049
f514f6f0
FP
50502012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
5051
e8fc049f 5052 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 5053
bf43fa51
KH
50542012-03-25 Kenichi Handa <handa@m17n.org>
5055
5056 * dispextern.h (struct glyph): Change the bit length of
5057 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
5058
8a0c01dd
EZ
50592012-03-24 Eli Zaretskii <eliz@gnu.org>
5060
5061 * s/ms-w32.h (tzname): Include time.h before redirecting to
5062 _tzname. Fixes the MSVC build. (Bug#9960)
5063
7d1c3a76
AS
50642012-03-24 Andreas Schwab <schwab@linux-m68k.org>
5065
8ed79523
AS
5066 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
5067 characters.
5068
7d1c3a76
AS
5069 * xterm.c (XTread_socket): Only modify handling_signal if
5070 !SYNC_INPUT. (Bug#11080)
5071
e99a9b8b
EZ
50722012-03-23 Eli Zaretskii <eliz@gnu.org>
5073
5074 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
5075 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
5076 when fetching a multibyte character consumes more bytes than
5077 CHAR_BYTES returns, due to unification of CJK characters in
5078 string_char. (Bug#11073)
5079
5063c0e1
TN
50802012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
5081
5082 * process.c (wait_reading_process_output): Handle pty disconnect
5083 by refraining from sending oneself a SIGCHLD (bug#10933).
5084
9f851fbd
CY
50852012-03-22 Chong Yidong <cyd@gnu.org>
5086
5087 * dispextern.h (struct it): New member string_from_prefix_prop_p.
5088
5063c0e1 5089 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
5090 Mark string as coming from a prefix property.
5091 (handle_face_prop): Use default face for prefix strings (Bug#4281).
5092 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
5093
fb5b8aca
CY
50942012-03-21 Chong Yidong <cyd@gnu.org>
5095
5096 * xfaces.c (Vface_remapping_alist): Doc fix.
5097
62356a1b
EZ
50982012-03-20 Eli Zaretskii <eliz@gnu.org>
5099
5100 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
5101 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
5102 Doc fixes.
62356a1b 5103
025de85b
CY
51042012-03-20 Chong Yidong <cyd@gnu.org>
5105
5106 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
5107 to reflect default non-nil value of redisplay-dont-pause.
5108
4827f94e
KH
51092012-03-19 Kenichi Handa <handa@m17n.org>
5110
5111 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
5112 it fit in a valid range (Bug#11003).
5113
e50a24a2
EZ
51142012-03-18 Eli Zaretskii <eliz@gnu.org>
5115
5116 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
5117 that is not from display property, accept the row as a "cursor
5118 row" if one of the string's character has a non-nil `cursor'
5119 property. Fixes cursor positioning when there are newlines in
5120 overlay strings, e.g. in icomplete.el. (Bug#11035)
5121
9af5ed87
PE
51222012-03-12 Paul Eggert <eggert@cs.ucla.edu>
5123
5124 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
5125
d1f55f16
CY
51262012-03-12 Chong Yidong <cyd@gnu.org>
5127
5128 * eval.c (inhibit_lisp_code): Rename from
5129 inhibit_window_configuration_change_hook; move from window.c.
5130
5131 * xfns.c (unwind_create_frame_1, Fx_create_frame):
5132 * window.c (run_window_configuration_change_hook)
5133 (syms_of_window): Callers changed.
5134
66c5eebd
CY
51352012-03-11 Chong Yidong <cyd@gnu.org>
5136
413df973
CY
5137 * keymap.c (Fkey_description): Doc fix (Bug#9700).
5138
66c5eebd
CY
5139 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
5140
1de11f56
CY
51412012-03-10 Chong Yidong <cyd@gnu.org>
5142
5143 * frame.c (other_visible_frames): Don't assume the selected frame
5144 is visible (Bug#10955).
5145
cae07000
SM
51462012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
5147
5148 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
5149
89c94350
JD
51502012-03-08 Jan Djärv <jan.h.d@swipnet.se>
5151
5152 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
5153 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
5154 zero (Bug#10954).
5155
999dd333
GM
51562012-03-03 Glenn Morris <rgm@gnu.org>
5157
01a6dcc8 5158 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 5159
de0100f2
EZ
51602012-03-02 Eli Zaretskii <eliz@gnu.org>
5161
5162 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
5163 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
5164 (redisplay_window, next_element_from_string): Fix typos in
5165 comments.
3e441275
EZ
5166 (redisplay_window): Pass to move_it_vertically the margin in
5167 pixels, not in screen lines.
de0100f2 5168
96a72ee9
GM
51692012-03-02 Glenn Morris <rgm@gnu.org>
5170
5171 * buffer.c (buffer-list-update-hook): Doc fix.
5172
312508d7
EZ
51732012-02-29 Eli Zaretskii <eliz@gnu.org>
5174
5175 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
5176 push_it before setting up the iterator for the first overlay
5177 string, even if we have an empty string loaded.
5178 (next_overlay_string): If there's an empty string on the iterator
5179 stack, pop the stack. (Bug#10903)
5180
27f3c637
PE
51812012-02-25 Paul Eggert <eggert@cs.ucla.edu>
5182
5183 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
5184 Suggested by Stefan Monnier in
5185 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
5186 * alloc.c (widen_to_Lisp_Object): New static function.
5187 (mark_memory): Also mark Lisp_Objects by fetching pointer words
5188 and widening them to Lisp_Objects. This would work even if
5189 USE_LSB_TAG is defined and wide integers are used, which might
5190 happen in a future version of Emacs.
5191
3c9dfce6
CY
51922012-02-25 Chong Yidong <cyd@gnu.org>
5193
fa74b241
CY
5194 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
5195 Doc fix.
5196
3c9dfce6
CY
5197 * xselect.c (Fx_selection_exists_p): Doc fix.
5198 (x_clipboard_manager_save_all): Print an informative message
5199 before saving to clipboard manager.
5200
9486df08
CY
52012012-02-24 Chong Yidong <cyd@gnu.org>
5202
5203 * keyboard.c (process_special_events): Handle all X selection
5204 requests in kbd_buffer, not just the next one (Bug#8869).
5205
f01d3321
CY
52062012-02-23 Chong Yidong <cyd@gnu.org>
5207
5208 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
5209 call when setting menu-bar-lines and tool-bar-lines parameters.
5210 (unwind_create_frame_1): New helper function.
5211
5212 * window.c (inhibit_window_configuration_change_hook): New var.
5213 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 5214 (syms_of_window): Initialize it.
f01d3321 5215
86b847b6
CY
52162012-02-22 Chong Yidong <cyd@gnu.org>
5217
5218 * xterm.c (x_draw_image_relief): Add missing type check for
5219 Vtool_bar_button_margin (Bug#10743).
5220
a59225b1
CY
52212012-02-21 Chong Yidong <cyd@gnu.org>
5222
5223 * fileio.c (Vfile_name_handler_alist): Doc fix.
5224
5225 * buffer.c (Fget_file_buffer): Protect against invalid file
5226 handler return value.
5227
310f5bd4
PE
52282012-02-20 Paul Eggert <eggert@cs.ucla.edu>
5229
cb3a28cc
PE
5230 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
5231 when computing $valmask.
5232
310f5bd4
PE
5233 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
5234 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
5235 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
5236 It's useless in that case, and it can cause problems on hosts
5237 that allocate halves of EMACS_INT values separately.
5238 Reported by Dan Horák. Diagnosed by Andreas Schwab in
5239 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
5240 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
5241 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
5242 it avoids undefined behavior on hosts where shifting right by more
5243 than the word width has undefined behavior.
5244
2375c96a
CY
52452012-02-19 Chong Yidong <cyd@gnu.org>
5246
5247 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
5248 (Funhandled_file_name_directory, Ffile_name_as_directory)
5249 (Fdirectory_file_name, Fexpand_file_name)
5250 (Fsubstitute_in_file_name): Protect against invalid file handler
5251 return values (Bug#10845).
5252
3eb49e71
EZ
52532012-02-18 Eli Zaretskii <eliz@gnu.org>
5254
5255 * .gdbinit (pitx): Fix incorrect references to fields of the
5256 iterator stack.
5257
7b926f3f
CY
52582012-02-17 Chong Yidong <cyd@gnu.org>
5259
5260 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
5261
11273115
PE
52622012-02-15 Paul Eggert <eggert@cs.ucla.edu>
5263
5264 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
5265 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
5266
c3a70e2b
CY
52672012-02-15 Chong Yidong <cyd@gnu.org>
5268
5269 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
5270 marked as special. Also, starting docstrings with * is obsolete.
5271
0ca43699
AS
52722012-02-13 Andreas Schwab <schwab@linux-m68k.org>
5273
5274 * gnutls.c (emacs_gnutls_write): Fix last change.
5275
2e8f3c56
LI
52762012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
5277
5278 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
5279 send_process.
5280
af70074f
SM
52812012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
5282
5283 * keymap.c (Fsingle_key_description): Handle char ranges.
5284
95986d52
CY
52852012-02-12 Chong Yidong <cyd@gnu.org>
5286
afd83bd1
CY
5287 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
5288 as that creates a dangerous corner case.
5289
95986d52
CY
5290 * window.c (Fdelete_window_internal): Invalidate the mouse
5291 highlight (Bug#9904).
5292
bd7da63e
GM
52932012-02-12 Glenn Morris <rgm@gnu.org>
5294
5295 * xselect.c (Fx_own_selection_internal)
5296 (Fx_get_selection_internal, Fx_disown_selection_internal)
5297 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
5298 * nsselect.m (Fx_own_selection_internal)
5299 (Fx_disown_selection_internal, Fx_selection_exists_p)
5300 (Fx_selection_owner_p, Fx_get_selection_internal):
5301 Sync docs and argument specs with the xselect.c versions.
5302
77abcbc2
LI
53032012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
5304
5305 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
5306
90b671e2
EZ
53072012-02-11 Eli Zaretskii <eliz@gnu.org>
5308
1c0ca0b7
EZ
5309 * w32select.c (Fx_selection_exists_p): Sync doc string and
5310 argument list with xselect.c. (Bug#10783)
5311
5312 * w16select.c (Fx_selection_exists_p): Sync doc string and
5313 argument list with xselect.c. (Bug#10783)
90b671e2 5314
49241268
GM
53152012-02-10 Glenn Morris <rgm@gnu.org>
5316
5317 * fns.c (Fsecure_hash): Doc fix.
5318
f998bbe7 53192012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
5320
5321 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
5322
0992bd9c
CY
53232012-02-07 Chong Yidong <cyd@gnu.org>
5324
5325 * buffer.c (Fbuffer_local_variables)
5326 (buffer_lisp_local_variables): Handle unbound vars correctly;
5327 don't let Qunbound leak into Lisp.
5328
af008560
GM
53292012-02-07 Glenn Morris <rgm@gnu.org>
5330
dd605cc4
GM
5331 * image.c (Fimagemagick_types): Doc fix.
5332
af008560
GM
5333 * image.c (imagemagick-render-type): Change it from a lisp object
5334 to an integer. Move the doc here from the lisp manual.
5335 Treat all values not equal to 0 the same.
5336
1449fa1d
CY
53372012-02-06 Chong Yidong <cyd@gnu.org>
5338
5339 * doc.c (store_function_docstring): Avoid applying docstring of
5340 alias to base function (Bug#2603).
5341
3723ec07
AS
53422012-02-04 Andreas Schwab <schwab@linux-m68k.org>
5343
5344 * .gdbinit (pp1, pv1): Remove redundant defines.
5345 (pr): Use pp.
5346
79c1cc1e
CY
53472012-02-04 Chong Yidong <cyd@gnu.org>
5348
5349 * nsterm.m: Declare a global (Bug#10694).
5350
d7f29f8e
EZ
53512012-02-04 Eli Zaretskii <eliz@gnu.org>
5352
cae07000
SM
5353 * w32.c (get_emacs_configuration_options):
5354 Include --enable-checking, if specified, in the return value.
d7f29f8e 5355
3b95a6f9
MR
53562012-02-04 Martin Rudalics <rudalics@gmx.at>
5357
5358 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
5359 after rounding frame sizes. (Bug#9723)
5360
d6fa96a6
EZ
53612012-02-04 Eli Zaretskii <eliz@gnu.org>
5362
5363 * keyboard.c (adjust_point_for_property): Don't position point
5364 before BEGV. (Bug#10696)
5365
df0b2940
PE
53662012-02-03 Paul Eggert <eggert@cs.ucla.edu>
5367
5368 Handle overflow when computing char display width (Bug#9496).
5369 * character.c (char_width): Return EMACS_INT, not int.
5370 (char_width, c_string_width): Check for overflow when
5371 computing the width; this is possible now that individual
5372 characters can have unbounded width. Problem introduced
5373 by merge from Emacs 23 on 2012-01-19.
5374
6bee44d6
MA
53752012-02-02 Michael Albinus <michael.albinus@gmx.de>
5376
5377 * dbusbind.c (Fdbus_register_method): Mention the return value
5378 :ignore in the docstring.
5379
44f92739
GM
53802012-02-02 Glenn Morris <rgm@gnu.org>
5381
1b9f60cc
GM
5382 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
5383
44f92739
GM
5384 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5385 Unconditionally set to t. (Bug#10673)
5386 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5387 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
5388 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
5389
c5d3843c
KH
53902012-02-02 Kenichi Handa <handa@m17n.org>
5391
5392 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
5393 0, do not call append_composite_glyph.
5394
159462d4 53952012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
5396
5397 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
5398 NULL (Bug#6988).
5399 (x_produce_glyphs): If the component of a composition is a null
5400 string, set it->pixel_width to 1 to avoid zero-width glyph.
5401
78cef877
EZ
54022012-02-01 Eli Zaretskii <eliz@gnu.org>
5403
5404 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
5405 first 2 arguments are identical. This makes inserting large
5406 output from a subprocess an order of magnitude faster on
5407 MS-Windows, where all sbrk'ed memory is always contiguous.
5408
97897668
GM
54092012-01-31 Glenn Morris <rgm@gnu.org>
5410
5411 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 5412 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
5413 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
5414
31fd3586
GM
54152012-01-29 Glenn Morris <rgm@gnu.org>
5416
5417 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
5418
0e24a8b2
CY
54192012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
5420
5421 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
5422
cc0adcb0
CY
54232012-01-28 Chong Yidong <cyd@gnu.org>
5424
5425 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
5426
acc28cb9
CY
54272012-01-26 Chong Yidong <cyd@gnu.org>
5428
9c69cfb7
CY
5429 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
5430
acc28cb9
CY
5431 * search.c (Fsearch_forward, Fsearch_backward): Document negative
5432 repeat counts (Bug#10507).
5433
48da7392
GM
54342012-01-26 Glenn Morris <rgm@gnu.org>
5435
5436 * lread.c (syms_of_lread): Doc fix.
5437
14af5f7f
CY
54382012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
5439
5440 * coding.c (encode_designation_at_bol): Change return value to
5441 EMACS_INT.
5442
0b21c100
CY
54432012-01-25 Chong Yidong <cyd@gnu.org>
5444
5445 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
5446
3c2907f7
CY
54472012-01-21 Chong Yidong <cyd@gnu.org>
5448
5449 * floatfns.c (Fcopysign): Make the second argument non-optional,
5450 since nil is not allowed anyway.
5451
959ad23f
AS
54522012-01-21 Andreas Schwab <schwab@linux-m68k.org>
5453
5454 * process.c (read_process_output): Use p instead of XPROCESS (proc).
5455 (send_process): Likewise.
5456
34a02f46
MR
54572012-01-19 Martin Rudalics <rudalics@gmx.at>
5458
5459 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
5460 (Vwindow_persistent_parameters): Do not use Qstate.
5461 Rewrite doc-strings.
34a02f46 5462
1259009a 54632012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
5464
5465 * character.c (char_width): New function.
70d4fdf6
GM
5466 (Fchar_width, c_string_width, lisp_string_width):
5467 Use char_width (Bug#9496).
25ed9e61 5468
6a6ee00d
MR
54692012-01-16 Martin Rudalics <rudalics@gmx.at>
5470
5471 * window.c (Vwindow_persistent_parameters): New variable.
5472 (Fset_window_configuration, save_window_save): Handle persistent
5473 window parameters.
5474
c85efaf7
EZ
54752012-01-14 Eli Zaretskii <eliz@gnu.org>
5476
5477 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
5478 thrashing the stack of the thread. (Bug#9087)
5479
5944709e
PE
54802012-01-12 Paul Eggert <eggert@cs.ucla.edu>
5481
5482 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
5483
e71f5d99
EZ
54842012-01-11 Eli Zaretskii <eliz@gnu.org>
5485
5486 * xdisp.c (rows_from_pos_range): Handle the case where the
5487 highlight ends on a newline. (Bug#10464)
5488 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
5489 he end column for display of highlight that ends on a newline
5490 before a R2L line.
5491
ce316182
GM
54922012-01-11 Glenn Morris <rgm@gnu.org>
5493
5494 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
5495 from load-path also when installation-directory is nil. (Bug#10208)
5496
5b43da69
GM
54972012-01-10 Glenn Morris <rgm@gnu.org>
5498
74cc8ff9
GM
5499 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
5500
7d8d6e4e
GM
5501 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
5502 Update template values to be closer to their typical values these days.
5b43da69 5503
a0db8d43
EZ
55042012-01-09 Eli Zaretskii <eliz@gnu.org>
5505
5506 * xdisp.c (rows_from_pos_range): Accept additional argument
5507 DISP_STRING, and accept any glyph in a row whose object is that
5508 string as eligible for mouse highlight. Fixes mouse highlight of
5509 display strings from overlays. (Bug#10464)
5510
9a0115ab 55112012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 5512
b9110d6a 5513 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
5514 * fileio.c (auto_saving_dir_umask): New static var.
5515 (Fmake_directory_internal): Use it.
5516 (do_auto_save_make_dir): Set it, instead of invoking chmod after
5517 creating the directory. The old code temporarily assigns
5518 too-generous permissions to the directory.
5519 (do_auto_save_eh): Clear it.
b9110d6a 5520 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
5521 that the var is always cleared.
5522
6c1bd3f3
EZ
55232012-01-07 Eli Zaretskii <eliz@gnu.org>
5524
5525 * search.c (scan_buffer): Pass character positions to
5526 know_region_cache, not byte positions. (Bug#6540)
5527
069d2b50
L
55282012-01-07 LynX <_LynX@bk.ru> (tiny change)
5529
5530 * w32.c (sys_rename): Report EXDEV when rename of a directory
5531 fails because the target is on another logical disk. (Bug#10284)
5532
75bf0d33
DB
55332012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
5534
5535 * xterm.c (x_embed_request_focus): New function.
5536
5537 * xterm.h: Add prototype.
5538
5539 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
5540
1c6e5a32
GM
55412012-01-05 Glenn Morris <rgm@gnu.org>
5542
5543 * emacs.c (emacs_copyright): Update short copyright year to 2012.
5544
651e947e
EZ
55452012-01-01 Eli Zaretskii <eliz@gnu.org>
5546
5547 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
5548 Load gnutls_transport_set_lowat only if GnuTLS version is below
5549 2.11.1.
5550 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
5551 GnuTLS versions below 2.11.1.
5552
3778cdd8
AL
55532011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
5554
5555 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
5556 to the doc string advising against its use for altering the way
5557 windows are scrolled.
5558
0e5317f7
KH
55592011-12-28 Kenichi Handa <handa@m17n.org>
5560
5561 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
5562 coding-system ASCII compatible only when it does not produce BOM
5563 on encoding (Bug#10383).
5564
93d5ca1f
JD
55652011-12-26 Jan Djärv <jan.h.d@swipnet.se>
5566
5567 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
5568 can scroll.
5569 (create_and_show_popup_menu): Always use menu_position_func for
5570 Gtk3 (Bug#10361).
5571
ca22b785
AS
55722011-12-24 Andreas Schwab <schwab@linux-m68k.org>
5573
5574 * callint.c (Fcall_interactively): Don't truncate prompt string.
5575
d048e1e6
EZ
55762011-12-23 Eli Zaretskii <eliz@gnu.org>
5577
5578 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
5579 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 5580 resumed from there (after widening). (Bug#10360)
d048e1e6 5581
5ccaba1f
JD
55822011-12-22 Jan Djärv <jan.h.d@swipnet.se>
5583
5584 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
5585
204ee57f
JD
55862011-12-21 Jan Djärv <jan.h.d@swipnet.se>
5587
b81d40f0
JB
5588 * nsterm.m (x_free_frame_resources):
5589 Release f->output_data.ns->miniimage.
204ee57f
JD
5590 (ns_index_color): Fix indentation. Do not retain
5591 color_table->colors[i].
5592
5593 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
5594 before returning.
5595
5596 * nsfns.m (x_set_background_color): Assign return value from
5597 ns_index_color to face-background instead of NSColor*.
5598 (ns_implicitly_set_icon_type): Fix indentation.
5599 Change assignment in for loop to comparison.
5600
5601 * emacs.c (ns_pool): New variable.
5602 (main): Assign ns_pool.
5603 (Fkill_emacs): Call ns_release_autorelease_pool.
5604
5605 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
5606 autorelease fdesc, release fdAttrs and tdict.
5607 (ns_get_covering_families): Release charset.
5608 (ns_findfonts): Release NSFontDescriptor created with new.
5609 (ns_uni_to_glyphs): Fix indentation.
5610 (setString): Release attrStr before assigning new value.
5611
c803b2b7
JD
56122011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5613
678f4426
JD
5614 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
5615 and NS_IMPL_COCOA.
5616 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
5617 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
5618
cd394be1 56192011-12-18 David Reitter <reitter@cmu.edu>
678f4426 5620
5fecd5fc
JD
5621 * nsterm.m (ns_term_init): Subscribe for notifications
5622 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
5623 to method trackingNotification in EmacsMenu.
5624
5625 * nsmenu.m (trackingMenu): New variable.
3771cb17 5626 (trackingNotification): New method (from Aquamacs).
5fecd5fc 5627 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 5628 from Aquamacs (Bug#7030).
678f4426
JD
5629
56302011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 5631
c803b2b7
JD
5632 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
5633 (symbol_to_nsstring): Fix indentation.
5634 (ns_symbol_to_pb): New function.
cae07000
SM
5635 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
5636 (Fns_rotate_cut_buffers_internal): Remove.
5637 (Fns_store_selection_internal): Rename from
c803b2b7
JD
5638 Fns_store_cut_buffer_internal.
5639 (ns_get_foreign_selection, Fx_own_selection_internal)
5640 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
5641 (Fns_get_selection_internal, Fns_store_selection_internal):
5642 Use ns_symbol_to_pb and check if return value is nil.
5643 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
5644 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
5645 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
5646 renamed to Sns_store_selection_internal.
5647 (ns_handle_selection_request): Move code to Fx_own_selection_internal
5648 and remove this function.
5649 (ns_handle_selection_clear): Remove, never used.
5650 (Fx_own_selection_internal): Move code from ns_handle_selection_request
5651 here.
5652
e1b01a3a
KB
56532011-12-17 Ken Brown <kbrown@cornell.edu>
5654
5655 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
5656 GID is unknown (Bug#10257).
5657
2adb6e85
PE
56582011-12-17 Paul Eggert <eggert@cs.ucla.edu>
5659
5660 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
5661 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
5662 which caused a build failure on GNU/Linux IA-64. This problem was
5663 introduced by my 2011-10-07 patch.
5664
d1d7b339
JL
56652011-12-15 Juri Linkov <juri@jurta.org>
5666
5667 * image.c (imagemagick_error): New function. (Bug#10112)
5668 (imagemagick_load_image): Comment out `MagickSetResolution' call.
5669 Use `imagemagick_error' where ImageMagick functions return
5670 `MagickFalse'.
5671 (Fimagemagick_types): Add `Fnreverse' to return the list in the
5672 proper order.
5673
100d5755
KH
56742011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5675
5676 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
5677 fill background (Bug#8992).
5678
454592a6
MR
56792011-12-13 Martin Rudalics <rudalics@gmx.at>
5680
5681 * window.c (Vwindow_combination_resize)
5682 (Vwindow_combination_limit): Use t instead of non-nil in
5683 doc-strings.
61d4b438
MR
5684 (Vrecenter_redisplay): Add first sentence of doc-string on
5685 separate line.
53524d93 5686 (Frecenter): Fix doc-string typo.
454592a6 5687
3633e3aa
KH
56882011-12-11 Kenichi Handa <handa@m17n.org>
5689
5690 * coding.c (Funencodable_char_position): Pay attention to the
5691 buffer text relocation (Bug#9389).
5692
7b9d523a 56932011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 5694
7b9d523a
JD
5695 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
5696 gtk_init (Bug#10100).
5697
b73189c6
EZ
56982011-12-10 Eli Zaretskii <eliz@gnu.org>
5699
5700 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
5701 IT->string is nil. (Bug#10263)
5702
f7dfe5d6
JD
57032011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5704
83faebb4
JD
5705 * nsterm.h (x_free_frame_resources): Declare.
5706
f7dfe5d6
JD
5707 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
5708 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
5709
5710 * nsterm.h (ns_get_defaults_value): Declare.
5711
5712 * nsterm.m (ns_default): Call ns_get_defaults_value.
5713
7cd4e72c
EZ
57142011-12-09 Eli Zaretskii <eliz@gnu.org>
5715
5716 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
5717 (Bug#10170)
5718
b34d7317
YM
57192011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5720
5721 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
5722 that where the value of an _OBJC_* symbol points to is in the .bss
5723 section (Bug#10240).
5724
76470ad1
KH
57252011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5726
5727 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 5728 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 5729
745fff94
KH
57302011-12-08 Kenichi Handa <handa@m17n.org>
5731
5732 * ftfont.c (get_adstyle_property): Fix previous change
5733 (Bug#10233).
5734
6e44397c
JB
57352011-12-07 Juanma Barranquero <lekktu@gmail.com>
5736
5737 * w32.c (init_environment): If no_site_lisp, remove site-lisp
5738 dirs from the default value of EMACSLOADPATH (bug#10208).
5739
7efa6272
GM
57402011-12-07 Glenn Morris <rgm@gnu.org>
5741
5742 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
5743 installation and source directories as well. (Bug#10208)
5744
f6fc4d87
CY
57452011-12-06 Chong Yidong <cyd@gnu.org>
5746
5747 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
5748
2bf26180
GM
57492011-12-06 Glenn Morris <rgm@gnu.org>
5750
5751 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
5752 as an error, not just -1. (Bug#10217)
5753
3a6ad4f0
CY
57542011-12-05 Chong Yidong <cyd@gnu.org>
5755
5756 * keyboard.c (process_special_events): New function.
5757 (swallow_events, Finput_pending_p): Use it (Bug#10195).
5758
75a3b399
PE
57592011-12-05 Paul Eggert <eggert@cs.ucla.edu>
5760
5761 * coding.c (encode_designation_at_bol): Don't use uninitialized
5762 local variable (Bug#9318).
5763
c3c9e25e
KH
57642011-12-05 Kenichi Handa <handa@m17n.org>
5765
5766 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
5767 return Qnil (Bug#8046, Bug#10193).
5768
5eb05ea3
KH
57692011-12-05 Kenichi Handa <handa@m17n.org>
5770
5771 * coding.c (encode_designation_at_bol): New args charbuf_end and
5772 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
5773 (coding_set_source): Return how many bytes coding->source was
5774 relocated.
5775 (coding_set_destination): Return how many bytes
5776 coding->destination was relocated.
5777 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 5778 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
5779
57802011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5781
5782 * coding.c (CODING_CHAR_CHARSET_P): New macro.
5783 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
5784 macro (Bug#9318).
5785
57862011-12-05 Andreas Schwab <schwab@linux-m68k.org>
5787
5788 The following changes are to fix Bug#9318.
5789
a79703f5 5790 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
5791 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
5792 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 5793 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 5794
7dbda6df
JB
57952011-12-05 Juanma Barranquero <lekktu@gmail.com>
5796
5797 * lisp.h (process_quit_flag): Fix external declaration.
5798
6d5eb5b0
SM
57992011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
5800
5801 Don't macro-inline non-performance-critical code.
5802 * eval.c (process_quit_flag): New function.
5803 * lisp.h (QUIT): Use it.
5804
a0c3fad0
JD
58052011-12-04 Jan Djärv <jan.h.d@swipnet.se>
5806
5807 * nsfns.m (get_geometry_from_preferences): New function.
5808 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
5809
6c07aac2
AS
58102011-12-04 Andreas Schwab <schwab@linux-m68k.org>
5811
5812 * emacs.c (Qkill_emacs): Define.
5813 (syms_of_emacs): Initialize it.
5814 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
5815 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
5816 (quit_throw_to_read_char): Add parameter `from_signal'.
5817 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
5818 * lisp.h (QUIT): Call Fkill_emacs if requested.
5819
c052ead4
JD
58202011-12-03 Jan Djärv <jan.h.d@swipnet.se>
5821
5822 * widget.c (update_wm_hints): Return if wmshell is null.
5823 (widget_update_wm_size_hints): New function.
5824
5825 * widget.h (widget_update_wm_size_hints): Declare.
5826
5827 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
5828 widget_update_wm_size_hints (Bug#10104).
5829
9e49252b
EZ
58302011-12-03 Eli Zaretskii <eliz@gnu.org>
5831
5832 * xdisp.c (handle_invisible_prop): If the invisible text ends just
5833 before a newline, prepare the bidi iterator for consuming the
5834 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 5835 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 5836
02b16839
JL
58372011-12-02 Juri Linkov <juri@jurta.org>
5838
5839 * search.c (Fword_search_regexp): New Lisp function created from
5840 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
5841 (Fword_search_backward, Fword_search_forward)
5842 (Fword_search_backward_lax, Fword_search_forward_lax):
5843 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
5844 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
5845
0068070e
SM
58462011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
5847
5848 * fileio.c (Finsert_file_contents): Move after-change-function call
5849 to before the "handled:" label, since all "goto handled" appear in
5850 cases where the *-change-functions have already been properly called
5851 (bug#10117).
5852
3360a3fc
AS
58532011-12-01 Andreas Schwab <schwab@linux-m68k.org>
5854
5855 * keyboard.c (interrupt_signal): Don't call kill-emacs when
5856 waiting for input. (Bug#10169)
5857
73d6c093
EZ
58582011-11-30 Eli Zaretskii <eliz@gnu.org>
5859
5860 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
5861 verifies glyph row's hash code--we have just reallocated the
5862 glyphs, so their contents can be complete garbage. (Bug#10164)
5863
febe6bea
JB
58642011-11-30 Juanma Barranquero <lekktu@gmail.com>
5865
5866 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
5867
801a4313
EZ
58682011-11-30 Eli Zaretskii <eliz@gnu.org>
5869
5870 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
5871 attributes are tested _before_ calling verify_row_hash, to protect
5872 against GCC re-ordering of the tests. (Bug#10164)
5873
2b56b87e
JD
58742011-11-29 Jan Djärv <jan.h.d@swipnet.se>
5875
5876 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
5877
5878 * xterm.c (handle_one_xevent): Only set async_visible and friends
5879 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 5880 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
5881 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
5882
dbf31225
PE
58832011-11-28 Paul Eggert <eggert@cs.ucla.edu>
5884
5885 Remove GCPRO-related macros that exist only to avoid shadowing locals.
5886 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
5887 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
5888 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5889 All uses changed to use GCPRO1 etc.
5890 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
5891 Revert to old implementation (i.e., before 2011-03-11).
5892
1305621b
YM
58932011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5894
5895 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
5896 of scroll runs so as to avoid assigning disabled bogus rows and
5897 unnecessary graphics copy operations.
5898
8c9afb46
EZ
58992011-11-27 Eli Zaretskii <eliz@gnu.org>
5900
5901 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
5902 (snprintf) [_MSC_VER]: Redirect to _snprintf.
5903 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
5904 (malloc, free, realloc, calloc): Redirect to e_* only when
5905 compiling Emacs.
5906
5907 * lisp.h (GCTYPEBITS): Move before first use.
5908 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
5909 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
5910 this macro definition.
5911
5912 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
5913 _MSC_VER.
5914
54e9e3bf
JD
59152011-11-27 Jan Djärv <jan.h.d@swipnet.se>
5916
6d5eb5b0
SM
5917 * gtkutil.c (xg_create_frame_widgets):
5918 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
5919 present with Gtk+ 2.0.
5920
83aca1cb
PE
59212011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5922
5923 * fileio.c (Finsert_file_contents): Undo previous change; see
5924 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5925
5b76caa4
PE
59262011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5927
5928 Rename locals to avoid shadowing.
5929 * fileio.c (Finsert_file_contents):
5930 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
5931 * process.c (wait_reading_process_output):
5932 Rename inner 'proc' to 'p' to avoid shadowing.
5933 Indent for consistency with usual Emacs style.
5934
8c535114
EZ
59352011-11-25 Eli Zaretskii <eliz@gnu.org>
5936
5937 * xdisp.c (redisplay_window): If cursor row is not fully visible
5938 after recentering, and scroll-conservatively is set to a large
5939 number, scroll window by a few more lines to make the cursor fully
5940 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
5941 (start_display): Don't move to the next line if the display should
5942 start at a newline that is part of a display vector or an overlay
5943 string. (Bug#10119)
8c535114 5944
fa4fdb5c
JL
59452011-11-24 Juri Linkov <juri@jurta.org>
5946
5947 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
5948 after the `MagickPingImage' call. (Bug#10112)
5949
90ec88df
CY
59502011-11-23 Chong Yidong <cyd@gnu.org>
5951
5952 * window.c (Fcoordinates_in_window_p): Accept only live windows.
5953
56e2e794
MR
59542011-11-23 Martin Rudalics <rudalics@gmx.at>
5955
5956 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
5957 making another buffer current. (Bug#10114)
5958
b6e64c41
GM
59592011-11-23 Glenn Morris <rgm@gnu.org>
5960
5961 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
5962
6b21de18
CY
59632011-11-23 Chong Yidong <cyd@gnu.org>
5964
5965 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
5966 using it (Bug#5984).
5967
b12cd789
EZ
59682011-11-22 Eli Zaretskii <eliz@gnu.org>
5969
5970 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
5971 and header-lines, as they don't have one computed for them.
5972 (Bug#10098)
5973
5974 * .gdbinit (prow): Make displayed values more self-explaining.
5975 Add row's hash code.
5976
261b6fd4
LMI
59772011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
5978
5979 * process.c (wait_reading_process_output): Fix asynchrounous
5980 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 5981 (wait_reading_process_output): Add comment and URL.
261b6fd4 5982
e7cfd277
JD
59832011-11-21 Jan Djärv <jan.h.d@swipnet.se>
5984
5985 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
5986
a9b9b7f5
CY
59872011-11-21 Chong Yidong <cyd@gnu.org>
5988
5989 * window.c (Fnext_window, Fprevious_window): Doc fix.
5990
b0d15b4f
SM
59912011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5992
5993 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
5994
fe7a3057
JB
59952011-11-20 Juanma Barranquero <lekktu@gmail.com>
5996
5997 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
5998
d2999b1a
MR
59992011-11-20 Martin Rudalics <rudalics@gmx.at>
6000
6001 * window.c (Fset_window_combination_limit): Rename argument
6002 STATUS to LIMIT.
6003 (Vwindow_combination_limit): Remove "status" from doc-string.
6004
d5ff9cd0
AS
60052011-11-20 Andreas Schwab <schwab@linux-m68k.org>
6006
6007 * m/ibms390.h: Remove.
6008 * m/ibms390x.h: Don't include "ibms390.h".
6009
a5bb9bd3
SM
60102011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6011
6012 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
6013 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
6014
cd1181db
JB
60152011-11-20 Juanma Barranquero <lekktu@gmail.com>
6016
6017 * casetab.c (Fset_case_table):
6018 * charset.c (Fcharset_after): Fix typos.
6019
615a3b8d 60202011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 6021
17e845af
PE
6022 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
6023 Otherwise, valgrind does not work on some platforms.
6024 Problem reported by Andreas Schwab in
6a0bf43d
PE
6025 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
6026 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
6027 is set, removing the need for VIRT_ADDRESS_VARIES.
6028 (PURE_P): Use a more-efficient implementation that needs just one
6029 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
6030 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
6031 to 4 (xorl, subq, cmpq, setbe).
6032 * alloc.c (pure): Always extern now, since that's the
6033 VIRT_ADDR_VARIES behavior.
6034 (PURE_POINTER_P): Use a single comparison, not two, for
6035 consistency with the new puresize.h.
6036 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
6037 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
6038 Remove VIRT_ADDR_VARIES no longer needed.
6039
f8fe6f96
EZ
60402011-11-19 Eli Zaretskii <eliz@gnu.org>
6041
6042 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
6043 (erase_phys_cursor, update_window_cursor, show_mouse_face)
6044 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
6045 behave as if the cursor position were at the window margin.
6046
6047 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
6048 and the cursor position is out of bounds, behave as if the cursor
6049 position were at the window margin. (Bug#10075)
6050
df05a53c
CY
60512011-11-18 Chong Yidong <cyd@gnu.org>
6052
6053 * window.c (Fwindow_combination_limit): Make first argument
6054 non-optional, since it is meaningless for live windows like the
6055 selected window.
61ccba97 6056
2071918e
DA
60572011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
6058
6059 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
6060
b50a28de
SM
60612011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
6062
6063 * intervals.c: Fix grafting over the whole buffer (bug#10071).
6064 (graft_intervals_into_buffer): Simplify.
6065
015137db
EZ
60662011-11-18 Eli Zaretskii <eliz@gnu.org>
6067
6068 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
6069 hash values of the two rows.
6070 (copy_row_except_pointers): Preserve the used[] arrays and the
6071 hash values of the two rows. (Bug#10035)
68c95424 6072 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
6073
6074 * xdisp.c (row_hash): New function, body extracted from
6075 compute_line_metrics.
6076 (compute_line_metrics): Call row_hash, instead of computing the
6077 hash code inline.
6078
6079 * dispnew.c (verify_row_hash): Call row_hash for computing the
6080 hash code of a row, instead of duplicating code from xdisp.c.
6081
6082 * dispextern.h (row_hash): Add prototype.
6083
a2addb04
TH
60842011-11-18 Tassilo Horn <tassilo@member.fsf.org>
6085
6086 * frame.c (delete_frame): Don't delete the terminal when the last
6087 X frame is closed if emacs is built with GTK toolkit.
6088
df85d315
JB
60892011-11-17 Juanma Barranquero <lekktu@gmail.com>
6090
6091 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
6092
a0c2d0ae
MR
60932011-11-17 Martin Rudalics <rudalics@gmx.at>
6094
6095 * window.c (Vwindow_splits): Rename to
6096 Vwindow_combination_resize. Suggested by Juri Linkov.
6097 (Fsplit_window_internal): Use Vwindow_combination_resize instead
6098 of Vwindow_splits.
6099
58179cce
JB
61002011-11-16 Juanma Barranquero <lekktu@gmail.com>
6101
7877f373
JB
6102 * nsfns.m (Fns_font_name):
6103 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 6104
b6f67890
MR
61052011-11-16 Martin Rudalics <rudalics@gmx.at>
6106
6107 * window.h (window): Rename slot "nest" to "combination_limit".
6108 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
6109 (Fset_window_nest): Rename to Fset_window_combination_limit.
6110 (Vwindow_nest): Rename to Vwindow_combination_limit.
6111 (recombine_windows, make_parent_window, make_window)
6112 (Fsplit_window_internal, saved_window)
6113 (Fset_window_configuration, save_window_save): Rename all
6114 occurrences of window_nest to window_combination_limit.
6115
c7015153
JB
61162011-11-15 Juanma Barranquero <lekktu@gmail.com>
6117
6118 * image.c (imagemagick_load_image): Fix typo.
6119
322ad6ec
EZ
61202011-11-14 Eli Zaretskii <eliz@gnu.org>
6121
6122 * xdisp.c (display_line): Move the call to
6123 highlight_trailing_whitespace before the call to
6124 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
6125 faces of all the glyphs to compute ROW's hash value.
6126 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 6127
f067b8ec
JB
61282011-11-14 Juanma Barranquero <lekktu@gmail.com>
6129
6130 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
6131 just return (bug#10044).
6132
1e5b2111
EZ
61332011-11-12 Eli Zaretskii <eliz@gnu.org>
6134
7ef3cbd5
EZ
6135 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
6136 with user-defined heap size. Bump the default size of the temacs
6137 heap to 27MB, to avoid memory warning when running temacs.
6138 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
6139
1e5b2111
EZ
6140 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
6141 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
6142 (verify_row_hash) [XASSERTS]: New function.
6143 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
6144 that the hash value of glyph rows is correct.
1e5b2111 6145
89d61221
MR
61462011-11-12 Martin Rudalics <rudalics@gmx.at>
6147
6148 * window.h (window): Remove splits slot.
6149 * window.c (Fwindow_splits, Fset_window_splits): Remove.
6150 (Fdelete_other_windows_internal, make_parent_window)
6151 (make_window, Fsplit_window_internal, Fdelete_window_internal)
6152 (Fset_window_configuration, save_window_save): Don't deal with
6153 split status of windows.
6154 (saved_window): Remove splits slot.
6155 (Vwindow_splits): Rewrite doc-string.
6156
97f18cc8
JD
61572011-11-11 Jan Djärv <jan.h.d@swipnet.se>
6158
6159 * xfns.c (unwind_create_frame):
6160 * nsfns.m (unwind_create_frame):
6161 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
6162 Vframe_list (Bug#9999).
6163
22a648b4
DA
61642011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
6165
0b381c7e 6166 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 6167
659afede
KH
61682011-11-11 Kenichi Handa <handa@m17n.org>
6169
6170 * callproc.c (Fcall_process): Set the member dst_multibyte of
6171 process_coding.
6172
9ac0394b
KH
61732011-11-11 Johan Bockgård <bojohan@gnu.org>
6174
6175 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
6176 avoid a crash (bug#9496).
6177
2fbdc249
CY
61782011-11-09 Chong Yidong <cyd@gnu.org>
6179
6180 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
6181 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
6182
ac6b1f81
PE
61832011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6184
6185 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
6186
09db192c
PE
61872011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6188
6189 Avoid some portability problems by eschewing 'extern inline' functions.
6190 The trivial performance wins aren't worth the portability hassles; see
6191 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
6192 et seq.
6193 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6194 (window_box_width, window_box_left, window_box_left_offset)
6195 (window_box_right, window_box_right_offset): Undo previous change,
6196 by removing the "extern"s.
6197 * intervals.c (adjust_intervals_for_insertion)
6198 (adjust_intervals_for_deletion): Undo previous change,
6199 making these static again.
6200 (offset_intervals, temp_set_point_both, temp_set_point)
6201 (copy_intervals_to_string): No longer inline.
6202 * xdisp.c (window_text_bottom_y, window_box_width)
6203 (window_box_height, window_box_left_offset)
6204 (window_box_right_offset, window_box_left, window_box_right)
6205 (window_box): No longer inline.
6206
105216ed
CY
62072011-11-08 Chong Yidong <cyd@gnu.org>
6208
6209 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
6210 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
6211 Signal an error if not a live window.
105216ed
CY
6212 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
6213 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
6214
ae9e237f
JB
62152011-11-07 Juanma Barranquero <lekktu@gmail.com>
6216
6217 * lisp.h (syms_of_abbrev): Remove declaration.
6218 Reported by CHENG Gao <chenggao@royau.me>.
6219
c7aa8333
EZ
62202011-11-07 Eli Zaretskii <eliz@gnu.org>
6221
6222 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
6223 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
6224 of temacs in GUI mode.
6225
be7f5545
MR
62262011-11-07 Martin Rudalics <rudalics@gmx.at>
6227
6228 * window.h: Declare delete_all_child_windows instead of
6229 delete_all_subwindows.
6230 * window.c (Fwindow_nest, Fset_window_nest)
6231 (Fset_window_new_total, Fset_window_new_normal)
6232 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
6233 (delete_all_subwindows): Rename to delete_all_child_windows.
6234 (Fdelete_other_windows_internal, Fset_window_configuration):
6235 Call delete_all_child_windows instead of delete_all_subwindows.
6236 * frame.c (delete_frame): Call delete_all_child_windows instead
6237 of delete_all_subwindows.
6238
ca78dc43
PE
62392011-11-07 Paul Eggert <eggert@cs.ucla.edu>
6240
6241 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
6242 This is also needed for porting to any host where GC_MARK_STACK is
6243 not GC_MAKE_GCPROS_NOOPS.
6244 (which_symbols): Use it.
6245
a0241d01
KH
62462011-11-07 Kenichi Handa <handa@m17n.org>
6247
6248 * coding.c (coding_set_destination): Check coding->src_pos only
6249 when coding->src_object is a buffer (bug#9910).
6250
6251 * process.c (send_process): Set the member src_multibyte of coding
6252 to 0 (bug#9911) when sending a unibyte text.
6253
6254 * callproc.c (Fcall_process): Set the member src_multibyte of
6255 process_coding to 0 (bug#9912).
6256
a64bfdfa 62572011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
6258
6259 * xmenu.c (cleanup_widget_value_tree): New function.
6260 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
6261 calling free_menubar_widget_value_tree directly (Bug#9830).
6262
cb41b32a
PE
62632011-11-06 Paul Eggert <eggert@cs.ucla.edu>
6264
6265 Fix some portability problems with 'inline'.
6266 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6267 (window_box_width, window_box_left, window_box_left_offset)
6268 (window_box_right, window_box_right_offset): Declare extern.
6269 Otherwise, these inline functions do not conform to C99 and
6270 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
6271 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
6272 * intervals.c (adjust_intervals_for_insertion)
6273 (adjust_intervals_for_deletion): Now extern, because otherwise the
6274 extern inline functions 'offset_intervals' couldn't refer to it.
6275 (static_offset_intervals): Remove.
6276 (offset_intervals): Rewrite using the old contents of
6277 static_offset_intervals. The old version didn't conform to C99
6278 because an extern inline function contained a reference to an
6279 identifier with static linkage.
6280
b7041366
AS
62812011-11-06 Andreas Schwab <schwab@linux-m68k.org>
6282
6283 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
6284 GC.
6285
88a37c4d
EZ
62862011-11-06 Eli Zaretskii <eliz@gnu.org>
6287
6288 * xdisp.c (init_iterator, reseat_to_string): Don't set the
6289 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
6290 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
6291 return Qleft_to_right.
6292
49745b39
CY
62932011-11-06 Chong Yidong <cyd@gnu.org>
6294
6295 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
6296 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
6297 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
6298 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
6299 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
6300 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
6301 (Fwindow_vscroll): Doc fix.
6302 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
6303 argument, since it makes no sense to pass a live window and for
6304 consistency with window-child.
6305
1f05cd82
CS
63062011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
6307
6308 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
6309 support MSVC.
6310
22610910
JR
63112011-11-05 Jason Rumney <jasonr@gnu.org>
6312
6313 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
6314 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
6315 fonts (Bug#6029).
6316 (add_font_entity_to_list): Fix logic errors in mixed boolean and
6317 bitwise arithmetic preventing use of unicode-sip and non-truetype
6318 opentype fonts.
6319
a06776b2
EZ
63202011-11-05 Eli Zaretskii <eliz@gnu.org>
6321
3ad924ba
EZ
6322 * s/ms-w32.h (fstat, stat, utime): Move redirections to
6323 "emacs"-only part.
6324
a06776b2
EZ
6325 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
6326 initialization code to keep similarity to xfns.c after changes
6327 from 2011-11-05.
6328
c9e7db78
JD
63292011-11-05 Jan Djärv <jan.h.d@swipnet.se>
6330
a97f8f3f
JD
6331 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
6332 (unwind_create_frame): New function (Bug#9943).
6333 (Fx_create_frame): Restructure code to be more similar to the one in
6334 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
6335 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
6336 Move terminal->reference_count++ just before making the frame official
6337 (Bug#9943).
6338
6339 * nsterm.m (x_free_frame_resources): New function.
6340 (x_destroy_window): Move code to x_free_frame_resources.
6341
c9e7db78 6342 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
6343 (Fx_create_frame, x_create_tip_frame):
6344 Move terminal->reference_count++ just before making the frame
75f1671a 6345 official. Move initialization of image_cache_refcount and
c9e7db78
JD
6346 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
6347
a6fc3b5c
EZ
63482011-11-05 Eli Zaretskii <eliz@gnu.org>
6349
6350 Support MSVC build with newer versions of Visual Studio.
6351 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
6352 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
6353 nt/gmake.defs.
6354
6355 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
6356 which are not supported by MSVC.
6357 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
6358 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
6359 bitfields.
6360 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
6361 types in bitfields.
6362 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
6363
6364 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
6365
58179cce 63662011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
6367
6368 Support MSVC build with newer versions of Visual Studio.
6369 * w32.c: Don't include w32api.h for MSVC.
6370 (init_environment) [_MSC_VER]: Call sys_access, not _access.
6371
6372 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
6373 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
6374 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
6375 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
6376 e_* cousins.
6377 (alloca) [_MSC_VER]: Define to _alloca.
6378
6379 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
6380
6381 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
6382
a58c13ed
EZ
63832011-11-04 Eli Zaretskii <eliz@gnu.org>
6384
6385 * xdisp.c (note_mouse_highlight): If either of
6386 previous/next-single-property-change returns nil, treat that as
6387 the beginning or the end of the buffer. (Bug#9955)
6388
fe0b6370
JD
63892011-11-04 Jan Djärv <jan.h.d@swipnet.se>
6390
a58c13ed 6391 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
6392 label is not null (Bug#9951).
6393 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
6394 may be NULL.
6395
89bd5ee1
EZ
63962011-11-04 Eli Zaretskii <eliz@gnu.org>
6397
6398 * window.c (Fwindow_body_size): Mention in the doc string that the
6399 return value is in frame's canonical units. (Bug#9949)
6400
84c3edb9
EZ
64012011-11-03 Eli Zaretskii <eliz@gnu.org>
6402
4e2fb5c7
EZ
6403 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
6404
84c3edb9 6405 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 6406 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 6407 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 6408
bc17a887
EZ
64092011-11-01 Eli Zaretskii <eliz@gnu.org>
6410
6411 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
6412 Don't stop backward scan on the continuation glyph, even though
6413 its CHARPOS is positive.
6d5eb5b0
SM
6414 (mouse_face_from_buffer_pos, note_mouse_highlight):
6415 Rename cover_string to disp_string.
bc17a887 6416
4ee88440
MR
64172011-11-01 Martin Rudalics <rudalics@gmx.at>
6418
6419 * window.c (temp_output_buffer_show): Don't use
6420 Vtemp_buffer_show_specifiers.
6421 (Vtemp_buffer_show_specifiers): Remove unused variable.
6422
c2ff3c02
EZ
64232011-10-30 Eli Zaretskii <eliz@gnu.org>
6424
6425 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
6426 past the beginning of the current glyph matrix.
6427
58179cce 64282011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
6429
6430 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
6431 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
6432 HAVE_GTK3 (Bug#9869).
b77a6a7f 6433
3b574623
JD
6434 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
6435 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
6436
b77a6a7f
JD
6437 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
6438
6439 * xterm.c: Declare x_handle_net_wm_state to return int.
6440 (handle_one_xevent): Check if we are iconified but don't have
6441 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
6442 (get_current_wm_state): Return non-zero if not hidden,
6443 check for _NET_WM_STATE_HIDDEN (Bug#9893).
6444 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
6445 (x_handle_net_wm_state): Return what get_current_wm_state returns.
6446 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
6447
196e41e4
PE
64482011-10-29 Paul Eggert <eggert@cs.ucla.edu>
6449
6450 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
6451 so that this new function doesn't get optimized away by a
6452 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
6453
021f2e1a
AS
64542011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6455
6456 * frame.h (MOUSE_HL_INFO): Remove excess parens.
6457
8b058d44
EZ
64582011-10-29 Eli Zaretskii <eliz@gnu.org>
6459
6460 Fix the `xbytecode' command.
6461 * .gdbinit (xprintbytestr): New command.
b50a28de 6462 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
6463 (xbytecode): Print the byte-code string as well.
6464
4452fb80
EZ
64652011-10-29 Kim Storm <storm@cua.dk>
6466
8b058d44
EZ
6467 * alloc.c (which_symbols): New function.
6468
21b72067
AS
64692011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6470
6471 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
6472 line. (Bug#9903)
6473
83ed7b5c
GM
64742011-10-29 Glenn Morris <rgm@gnu.org>
6475
6476 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
6477 Not clear what it was for, and it causes various bugs. (Bug#9839)
6478
5a7a728b
EZ
64792011-10-28 Eli Zaretskii <eliz@gnu.org>
6480
6481 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
6482 possible random value that matches one of those tested as
6483 condition to clear the mouse face.
6484
d3d0842f
CY
64852011-10-28 Chong Yidong <cyd@gnu.org>
6486
6487 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
6488
31b39d13
DN
64892011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
6490
6491 * window.c (make_window): Initialize phys_cursor_on_p.
6492
9aba6043
SM
64932011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
6494
6495 * lisp.h (struct Lisp_Symbol): Update comments.
6496
c20992f4
JB
64972011-10-28 Juanma Barranquero <lekktu@gmail.com>
6498
6499 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
6500
db4f02f2
EZ
65012011-10-28 Eli Zaretskii <eliz@gnu.org>
6502
6503 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
6504 <oslsachem@gmail.com> for helping to debug this.
6505
6506 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
6507 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
6508 (g_b_init_get_glyph_outline_w): New static variables.
6509 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
6510 (GetGlyphOutlineW_Proc): New typedefs.
6511 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
6512 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
6513 New functions.
6514 (w32font_open_internal, compute_metrics):
6515 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
6516 instead of calling the "wide" APIs directly.
6517
6518 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
6519
6520 * w32.h (syms_of_w32font): Add prototype.
6521
87e68db4
JB
65222011-10-27 Juanma Barranquero <lekktu@gmail.com>
6523
6524 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
6525 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
6526 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
6527 (Fmove_to_window_line): Doc fix.
6528
435c1d67
CY
65292011-10-27 Chong Yidong <cyd@gnu.org>
6530
6531 * process.c (make_process): Set gnutls_state to NULL.
6532
6533 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
6534 non-NULL, regardless of GNUTLS_INITSTAGE.
6535 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
6536 an error. Set process slots as soon as we allocate them.
6537
6538 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
6539
9c6c6f49
CY
65402011-10-27 Chong Yidong <cyd@gnu.org>
6541
9aba6043
SM
6542 * gnutls.c (emacs_gnutls_deinit): New function.
6543 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
6544 (Fgnutls_deinit, Fgnutls_boot): Use it.
6545
6546 * process.c (make_process): Initialize GnuTLS credentials to NULL.
6547 (deactivate_process): Call emacs_gnutls_deinit.
6548
657d08d3
JB
65492011-10-27 Juanma Barranquero <lekktu@gmail.com>
6550
6551 * image.c (x_create_x_image_and_pixmap):
6552 * w32.c (sys_rename, w32_delayed_load):
6553 * w32font.c (fill_in_logfont):
6554 * w32reg.c (x_get_string_resource): Silence compiler warnings.
6555
5430d399
JB
65562011-10-26 Juanma Barranquero <lekktu@gmail.com>
6557
6558 * w32fns.c (w32_default_color_map): New function,
6559 extracted from Fw32_default_color_map.
a7ef684b 6560 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 6561
fe0055fa
PE
65622011-10-25 Paul Eggert <eggert@cs.ucla.edu>
6563
6564 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
6565
e6346438
SM
65662011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
6567
6568 * keyboard.c (test_undefined): New function (bug#9751).
6569 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
6570
e112cc37
ET
65712011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
6572
6573 * sysdep.c (init_sys_modes): Fix the check for the controlling
6574 terminal (Bug#6649).
6575
7b5d6677
EZ
65762011-10-20 Eli Zaretskii <eliz@gnu.org>
6577
6578 * dispextern.h (struct bidi_it): New member next_en_type.
6579
6580 * bidi.c (bidi_line_init): Initialize the next_en_type member.
6581 (bidi_resolve_explicit_1): When next_en_pos is valid for the
6582 current character, check also for next_en_type being WEAK_EN.
6583 (bidi_resolve_weak): Don't enter the expensive loop if the current
6584 position is before next_en_pos. Record the bidi type of the first
6585 non-ET, non-BN character we find, in addition to its position.
6586 (bidi_level_of_next_char): Invalidate next_en_type when
6587 next_en_pos is over-stepped.
6588
7da0b018
PE
65892011-10-20 Paul Eggert <eggert@cs.ucla.edu>
6590
6591 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
6592 * editfns.c: Rewrite current-time-zone so that it invokes
6593 the equivalent of (format-time-string "%Z") to get the time zone name.
6594 This fixes a bug when the time zone name contains characters that
6595 need converting from the system time locale to Emacs internal format.
6596 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
6597 that patch fixed format-time-string to do the conversion, but
6598 I forgot to fix current-time-zone.
6599 (format_time_string): New function, containing most of
6600 what Fformat_time_string used to contain.
6601 (Fformat_time_string): Rewrite in terms of format_time_string.
6602 This doesn't change this function's behavior.
6603 (current-time-zone): Rewrite to use format_time_string.
6604 This fixes the bug reported by Michael Schierl in
6605 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
6606 Jason Rumney's 2007-06-07 change worked around this bug, but
6607 didn't fix it.
6608 * systime.h (tzname, timezone): Remove no-longer-used declarations.
6609
8547b010
EZ
66102011-10-19 Eli Zaretskii <eliz@gnu.org>
6611
6612 * xdisp.c (start_display): If the character at POS is displayed
6613 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
6614 (try_window_reusing_current_matrix): If a line ends in a display
6615 vector or the next line starts in a display vector, continue
6616 redrawing the window even though the character position of
6617 start_row was reached.
8547b010
EZ
6618 (Bug#9771, part 2)
6619
4e948d15
CY
66202011-10-18 Chong Yidong <cyd@gnu.org>
6621
6622 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
6623 with nobreak-char-display too.
6624
4787455f
EZ
66252011-10-18 Eli Zaretskii <eliz@gnu.org>
6626
6627 Fix part 3 of bug#9771.
6628 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
6629 (bidi_resolve_neutral): Don't enter the expensive loop looking for
6630 non-neutral characters if the current character is a paragraph
6631 separator (a.k.a. Newline). This avoids running the same
6632 expensive loop twice, once when we consume the preceding newline
6633 and the other time when the line actually needs to be displayed.
6634 Avoid the loop when we see neutrals on the base embedding level
6635 following a character whose directionality is the same as the
6636 paragraph's. This avoids running the expensive loop when a line
6637 ends in a long sequence of neutrals, like control characters.
6638 Add assertion against STRONG_AL type. Slightly rearrange code
6639 that determines the type of a neutral given the first non-neutral
6640 that follows it.
6641 (bidi_level_of_next_char): Set next_en_pos to zero when
6642 invalidating its info.
6643
2c91f553
EZ
66442011-10-17 Eli Zaretskii <eliz@gnu.org>
6645
6646 * xdisp.c (push_display_prop): Determine whether to record string
6647 or buffer position by IT->string, not by IT->method. Allow
6648 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
6649 (move_it_vertically_backward): Don't look for character position
6650 immediately after the newline when in a continuation line.
6651 (Bug#9771, part 1)
2c91f553 6652
c7b08b0d
MR
66532011-10-15 Martin Rudalics <rudalics@gmx.at>
6654
6655 * window.c (coordinates_in_window): Rewrite and delabelize
6656 vertical border check. (Bug#5357) (Bug#9618)
6657
6b02f655
SM
66582011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
6659
6660 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
6661 errors in XSetWindowBorder (bug#9310).
6662
81d40c92
DA
66632011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
6664
6665 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
6666 avoid crash when xmalloc overrun checking is enabled.
6667
d4172c3b
EZ
66682011-10-13 Eli Zaretskii <eliz@gnu.org>
6669
6670 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
6671 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
6672 cursor motion with <left> and <right> arrow keys.
6673
6674 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
6675 some callers set that themselves.
6676
b00eea75
EZ
66772011-10-12 Eli Zaretskii <eliz@gnu.org>
6678
6679 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
6680 display string and the previous row comes from the same string and
6681 is empty. (Bug#9739) (Bug#9738)
6682
8fe012c4
SM
66832011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
6684
6685 * doc.c (get_doc_string): Encode file name (bug#9735).
6686
0074aef2
EZ
66872011-10-12 Eli Zaretskii <eliz@gnu.org>
6688
79beb178
EZ
6689 * bidi.c (bidi_level_of_next_char):
6690 * xdisp.c (get_visually_first_element): Remove old incorrect
6691 comments regarding the Unicode Line Separator character.
6692
0074aef2
EZ
6693 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
6694
6e4b3fbe
DA
66952011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
6696
6697 * alloc.c (Fgc_status): Do not access beyond zombies array
6698 boundary if nzombies > MAX_ZOMBIES.
6699 * alloc.c (dump_zombies): Add missing format specifier.
6700
0324f3af
PE
67012011-10-12 Paul Eggert <eggert@cs.ucla.edu>
6702
b5525cac
PE
6703 * xdisp.c (set_cursor_from_row): Simplify conditionals,
6704 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
6705
0324f3af
PE
6706 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
6707 Some packages use them to denote characters with modifiers.
6708
e9b5f888
AS
67092011-10-11 Andreas Schwab <schwab@linux-m68k.org>
6710
6711 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
6712 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
6713 matching a pp-number. Rename parameter var to var1.
6714
127827c0
SM
67152011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
6716
6717 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
6718
c8fd3bd0
GM
67192011-10-08 Glenn Morris <rgm@gnu.org>
6720
6721 * callint.c (Fcall_interactively): Give a more explicit error for the
6722 'c' case with a non-character input. (Bug#8479)
6723
352ec8ff
EZ
67242011-10-08 Eli Zaretskii <eliz@gnu.org>
6725
03669ccb
EZ
6726 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
6727 lines.
7061c986
EZ
6728 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
6729 lines that are hscrolled on the left.
03669ccb 6730
352ec8ff
EZ
6731 * dispnew.c (buffer_posn_from_coords): Account for a possible
6732 presence of header-line. (Bug#4426)
6733
a66cfb1c
SM
67342011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
6735
6b02f655
SM
6736 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
6737 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 6738
7c5ee88e
PE
67392011-10-07 Paul Eggert <eggert@cs.ucla.edu>
6740
6741 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
6742 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
6743 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
6744 this makes Emacs dump core during garbage collection on rare
6745 occasions. sizeof is obviously inferior to offsetof here, so
6746 stick with offsetof.
6747 (GC_POINTER_ALIGNMENT): New macro.
6748 (mark_memory): Omit 3rd (offset) arg; caller changed.
6749 Don't assume EMACS_INT alignment is the same as pointer alignment.
6750
df1bbe5b
SM
67512011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
6752
6753 * keyboard.c (read_key_sequence_remapped): New var.
6754 (read_key_sequence): Compute remapping in the right buffer.
6755 (command_loop_1): Use read_key_sequence's remapping directly.
6756
51553db6
SM
67572011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
6758
32c1fffd
SM
6759 * dired.c (file_name_completion): Don't expand file name.
6760 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
6761 before checking file name handler.
6762
51553db6
SM
6763 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
6764 they've been requested explicitly (bug#9591).
6765
b6bd1599 67662011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
6767
6768 * keymap.c (Fsingle_key_description): Use make_specified_string
6769 instead of build_string to build string from push_key_description.
6770 (Bug#5193)
6771
f701dc2a
PE
67722011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6773
4222c55d
PE
6774 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
6775 This fixes a Y2038 bug on 64-bit hosts.
6776 * buffer.c (reset_buffer):
6777 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
6778 (Fclear_buffer_auto_save_failure):
6779 Use 0, not -1, to represent an unset failure time, since time_t
6780 might not be signed.
6781
f701dc2a
PE
6782 Remove dependency on glibc malloc internals.
6783 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6784 Move back here from lisp.h, but with their new implementations.
6785 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6786 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
6787 * charset.c (charset_table_init): New static var.
6788 (syms_of_charset): Use it instead of xmalloc. This removes a
6789 dependency on glibc malloc internals. See Eli Zaretskii's comment in
6790 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
6791 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6792 Move back to alloc.c.
6793 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6794 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
6795
9ceebf39
JD
67962011-09-30 Jan Djärv <jan.h.d@swipnet.se>
6797
6798 * nsterm.m (windowDidResize): Call x_set_window_size only when
6799 ns_in_resize is true. Otherwise set pixelwidth/height and
6800 call change_frame_size (Bug#9628).
6801
cb993c58
PE
68022011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6803
3930c88b
PE
6804 Port --enable-checking=all to Fedora 14 x86-64.
6805 * charset.c (syms_of_charset): Also account for glibc malloc's
6806 internal overhead when calculating the initial malloc maximum.
6807
cb993c58
PE
6808 Port --enable-checking=all to Fedora 14 x86.
6809 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6810 Move to lisp.h.
6811 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
6812 (overrun_check_realloc, overrun_check_free):
6813 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
6814 That way, xmalloc returns a properly-aligned pointer even if
6815 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
6816 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
6817 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
6818 into account when calculating the initial malloc maximum.
6819 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6820 Move here from alloc.c, so that charset.c can use it too.
6821 Properly align; the old code wasn't right for common 32-bit hosts
6822 when configured with --enable-checking=all.
6823 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6824 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
6825
31bed486
EZ
68262011-09-29 Eli Zaretskii <eliz@gnu.org>
6827
04c70788 6828 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
6829 use EDOM.
6830
fbcaa2f3
EZ
68312011-09-28 Eli Zaretskii <eliz@gnu.org>
6832
6833 * xdisp.c (compute_display_string_end): If there's no display
6834 string at CHARPOS, return -1.
6835
6836 * bidi.c (bidi_fetch_char): When compute_display_string_end
6837 returns a negative value, treat the character as a normal
6838 character not covered by a display string. (Bug#9624)
6839
a239d4e9
JB
68402011-09-28 Juanma Barranquero <lekktu@gmail.com>
6841
6842 * lread.c (Fread_from_string): Fix typo in docstring.
6843
88652fd5
EZ
68442011-09-27 Eli Zaretskii <eliz@gnu.org>
6845
6846 * xdisp.c (handle_invisible_prop): If invisible text ends on a
6847 newline, reseat the iterator instead of bidi-iterating there one
6848 character at a time. (Bug#9610)
32c1fffd
SM
6849 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
6850 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 6851
ed497dd4
AS
68522011-09-27 Andreas Schwab <schwab@linux-m68k.org>
6853
6854 * lread.c (readevalloop): Use correct code for NBSP.
6855 (read1): Likewise. (Bug#9608)
6856
b2bf61aa
MA
68572011-09-25 Michael Albinus <michael.albinus@gmx.de>
6858
6859 * dbusbind.c (Fdbus_register_signal): When service is not
6860 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
6861
32bbb17c
GM
68622011-09-25 Glenn Morris <rgm@gnu.org>
6863
6864 * buffer.c (truncate-lines): Doc fix.
6865
94e0933e
CY
68662011-09-24 Chong Yidong <cyd@stupidchicken.com>
6867
6868 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
6869 (Fset_window_next_buffers): Doc fix.
6870
cddde921
GM
68712011-09-24 Glenn Morris <rgm@gnu.org>
6872
6873 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
6874
1260aef1
PE
68752011-09-24 Paul Eggert <eggert@cs.ucla.edu>
6876
25b4bfa0
PE
6877 Fix minor problems found by static checking.
6878 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
6879 * indent.c (Fvertical_motion): Fix == vs = typo.
6880
e3cbd34b
EZ
68812011-09-24 Eli Zaretskii <eliz@gnu.org>
6882
a66cfb1c
SM
6883 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
6884 Default value is now t. Doc fix.
6bf7006f 6885
e3cbd34b 6886 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 6887 logic when moving up, not only when moving down. Fix the
e3cbd34b 6888 confusing name and values of the it_overshoot_expected variable;
32c1fffd 6889 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
6890
6891 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
6892 CHARPOS is covered by a display string which includes newlines.
6893 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
6894 is covered by a display string with embedded newlines.
6895
a3de0cbd
MA
68962011-09-24 Michael Albinus <michael.albinus@gmx.de>
6897
6898 * dbusbind.c (Fdbus_register_signal): Add match rule to
6899 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
6900 (Fdbus_register_method, Vdbus_registered_objects_table):
6901 Fix docstring.
a3de0cbd 6902
b260039d
JM
69032011-09-24 Jim Meyering <meyering@redhat.com>
6904
32c1fffd 6905 do not ignore write error for any output size
b260039d
JM
6906 The previous change was incomplete.
6907 While it makes emacs --batch detect the vast majority of stdout
6908 write failures, errors were still ignored whenever the output size is
6909 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
6910 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
6911 && echo FAIL: ignored write error
6912 FAIL: ignored write error
6913 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
6914 && echo FAIL: ignored write error
6915 FAIL: ignored write error
6916 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
6917
8eca8a7c
AS
69182011-09-23 Andreas Schwab <schwab@linux-m68k.org>
6919
6920 * emacs.c (Fkill_emacs): In noninteractive mode exit
6921 non-successfully if a write error occurred on stdout. (Bug#9574)
6922
3341db62
EZ
69232011-09-21 Eli Zaretskii <eliz@gnu.org>
6924
6925 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
6926 the xassert test.
6927
6928 * dispextern.h (struct it): Update the comment documenting what
6929 can it->OBJECT be.
6930
8c203dbf
EZ
69312011-09-20 Eli Zaretskii <eliz@gnu.org>
6932
6933 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
6934 a display string, extend search for cursor position to end of row.
6935 (find_row_edges): If the row ends in a newline from a display
6936 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
6937 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
6938 (Fcurrent_bidi_paragraph_direction): Fix search for previous
6939 non-empty line. Fixes confusing cursor motion with arrow keys at
6940 the beginning of a line that starts with whitespace.
8c203dbf 6941
a4824228
LMI
69422011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6943
6944 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
6945 (bug#9493).
6946
33ed493b
CY
69472011-09-18 Chong Yidong <cyd@stupidchicken.com>
6948
6949 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
6950 boolean (Bug#9154).
6951
56cd55c8
EZ
69522011-09-18 Eli Zaretskii <eliz@gnu.org>
6953
6954 * xdisp.c (display_line): Record maximum and minimum buffer
6955 positions even if no glyphs were produced (e.g., by a zero-width
6956 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
6957 buffer positions that will be removed from the glyph row because
6958 they don't fit.
c02dcedf
EZ
6959 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
6960 column is beyond frame width: don't subtract 1 "pixel" when
6961 computing width of the stretch.
3e62b7e0
EZ
6962 (reseat_at_next_visible_line_start): Undo the change made on
6963 2011-09-17 that saved paragraph information and restored it after
6964 the call to `reseat'. (Bug#9545)
56cd55c8 6965
5ed99d36 69662011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
6967
6968 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
6969 and turn window cursor on if cleared (Bug#9415).
6970
5ed99d36 69712011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
6972
6973 * search.c (boyer_moore): Take unibyte characters from pattern
6974 literally. (Bug#9458)
6975
9bade7b2
EZ
69762011-09-18 Eli Zaretskii <eliz@gnu.org>
6977
6978 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
6979
e5e9d610
PE
69802011-09-18 Paul Eggert <eggert@cs.ucla.edu>
6981
87e4427a
PE
6982 Fix minor problem found by static checking.
6983 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
6984 initialized, to pacify gcc -Wuninitialized.
6985
e5e9d610
PE
6986 * fileio.c: Report proper errno when syscall falls.
6987 (Finsert_file_contents): Save and restore errno,
6988 so that report_file_error outputs the correct diagnostic.
6989 (Fwrite_region) [CLASH_DETECTION]: Likewise.
6990
a1674f0b
EZ
69912011-09-18 Eli Zaretskii <eliz@gnu.org>
6992
6993 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
6994
fbfb6dd4
EZ
69952011-09-17 Eli Zaretskii <eliz@gnu.org>
6996
6997 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
6998 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
6999
bb187662
EZ
70002011-09-17 Eli Zaretskii <eliz@gnu.org>
7001
1137e8b8 7002 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 7003 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
7004
7005 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
7006 (bidi_find_paragraph_start): Search back for paragraph beginning
7007 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
7008 (bidi_move_to_visually_next): Only trigger paragraph-related
7009 computations when the last character is a newline or at EOB, not
7010 just any NEUTRAL_B. (Bug#9470)
7011
bb187662
EZ
7012 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
7013 truncated lines if point is covered by a display string. (Bug#9524)
7014
2e621251
PE
70152011-09-16 Paul Eggert <eggert@cs.ucla.edu>
7016
7017 * xselect.c: Relax test for outgoing X longs (Bug#9498).
7018 (cons_to_x_long): New function.
7019 (lisp_data_to_selection_data): Use it. Correct the test for
7020 short-versus-long data; it was negated. Break out of vector
7021 loop, for efficiency, when a long datum is discovered.
7022
91a15bc6
SM
70232011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
7024
7025 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
7026
b41c3a35
EZ
70272011-09-16 Eli Zaretskii <eliz@gnu.org>
7028
7029 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
7030 GCC PR/17406) by declaring this function with external scope.
7031
7812ba2d
PE
70322011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7033
7034 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
7035 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
7036
cf7edc2a
AS
70372011-09-15 Andreas Schwab <schwab@linux-m68k.org>
7038
7039 * editfns.c (Fformat): Correctly handle text properties on "%%".
7040
bd01620e
EZ
70412011-09-15 Eli Zaretskii <eliz@gnu.org>
7042
7043 * xterm.c (x_draw_composite_glyph_string_foreground):
7044 * w32term.c (x_draw_composite_glyph_string_foreground):
7045 * term.c (encode_terminal_code):
7046 * composite.c (composition_update_it, get_composition_id):
7047 * xdisp.c (get_next_display_element)
7048 (fill_composite_glyph_string): Add comments about special meaning
7049 of TAB characters in a composition.
7050
a02719a3
PE
70512011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7052
7053 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
7054 This occurs when processing a multibyte format.
7055 Problem reported by Wolfgang Jenker.
a02719a3 7056
72589a3c
JB
70572011-09-15 Johan Bockgård <bojohan@gnu.org>
7058
7059 * xdisp.c (try_cursor_movement): Only check for exact match if
7060 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
7061
1c14176c
PE
70622011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7063
7064 Remove unused external symbols.
7065 * dispextern.h (calc_pixel_width_or_height): Remove decl.
7066 * xdisp.c (calc_pixel_width_or_height): Now static.
7067 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
7068 * indent.c (check_display_width):
7069 * w32term.c: Fix comment to match code.
7070 * xterm.c, xterm.h (x_catching_errors): Remove.
7071
d2eea5b5
PE
70722011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7073
7074 * xselect.c: Use signed conversions more consistently (Bug#9498).
7075 (selection_data_to_lisp_data): Assume incoming selection data are
7076 signed integers, not unsigned. This is to be consistent with
7077 outgoing selection data, which was modified to use signed integers
7078 in as part of the fix to Bug#9196 in response to Jan D.'s comment
7079 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
7080 expects long, not unsigned long.
7081
46888499
EZ
70822011-09-14 Eli Zaretskii <eliz@gnu.org>
7083
7084 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
7085 computation of loop end. Reported by Johan Bockgård
7086 <bojohan@gnu.org>.
7087
ef8ef9fb
CY
70882011-09-13 Chong Yidong <cyd@stupidchicken.com>
7089
7090 * frame.c (Fother_visible_frames_p): Function deleted.
7091
fa819fed
EZ
70922011-09-12 Eli Zaretskii <eliz@gnu.org>
7093
7094 * indent.c (compute_motion): Process display vector front to back
7095 rather than the other way around. (Bug#2496)
7096
2ba8e008
SM
70972011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
7098
7099 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
7100
20f53c69
CY
71012011-09-11 Chong Yidong <cyd@stupidchicken.com>
7102
7103 * minibuf.c (Fread_from_minibuffer): Doc fix.
7104
d562d7a4
EZ
71052011-09-11 Eli Zaretskii <eliz@gnu.org>
7106
7107 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
7108 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
7109
1c4d7f3d
LMI
71102011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7111
7112 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
7113 value for non-existent files.
7114
b885bf36
EZ
71152011-09-11 Eli Zaretskii <eliz@gnu.org>
7116
7117 * fileio.c (Finsert_file_contents): If the file cannot be opened,
7118 set its "size" to -1. This will set the modtime_size field of
7119 the corresponding buffer to -1, which is what
7120 verify-visited-file-modtime expects for files that do not exist.
7121 (Bug#9139)
7122
6612f0bf
PE
71232011-09-11 Paul Eggert <eggert@cs.ucla.edu>
7124
7125 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
7126 here ...
7127 * lisp.h: ... from here. push_key_description is no longer
7128 defined in keyboard.c, so its declaration should not be in
7129 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
7130 logically belongs with push_key_description.
7131
dfb3f755
PE
71322011-09-10 Paul Eggert <eggert@cs.ucla.edu>
7133
7134 * buffer.h: Include <sys/types.h> instead of <time.h>.
7135 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
7136 Problem reported by Herbert J. Skuhra.
7137
3134906c
LMI
71382011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
7139
7140 * xml.c (parse_region): Make the parsing work for
7141 non-comment-starting XML files again (bug#9144).
7142
8d903f4e
AS
71432011-09-10 Andreas Schwab <schwab@linux-m68k.org>
7144
7145 * image.c (gif_load): Fix calculation of bottom and right corner.
7146 (Bug#9468)
7147
80ad64f4
EZ
71482011-09-10 Eli Zaretskii <eliz@gnu.org>
7149
7150 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
7151 redisplay in small windows.
7152
208a048d
EZ
71532011-09-09 Eli Zaretskii <eliz@gnu.org>
7154
7155 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
7156
9b1c252e
MR
71572011-09-08 Martin Rudalics <rudalics@gmx.at>
7158
7159 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
7160 Operate on live windows only.
7161
2949f33b
JB
71622011-09-08 Juanma Barranquero <lekktu@gmail.com>
7163
7164 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
7165
e08dcafd
EZ
71662011-09-07 Eli Zaretskii <eliz@gnu.org>
7167
7168 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
7169 only under bidi iteration.
7170
115b96bd
JD
71712011-09-07 Jan Djärv <jan.h.d@swipnet.se>
7172
7173 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
7174
c8199d0f
PE
71752011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7176
7177 isnan: Fix porting problem to Solaris 10 with bundled gcc.
7178 Without this fix, the command to link temacs failed due to an
7179 undefined symbol __builtin_isnan. This is because
7180 /usr/include/iso/math_c99.h #defines isnan(x) to
7181 __builtin_isnan(x), but the bundled gcc, which identifies itself
7182 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
7183 a __builtin_isnan.
7184 * floatfns.c (isnan): #undef, and then #define to a clone of
7185 what's in data.c.
7186 (Fisnan): Always define, since it's always available now.
7187 (syms_of_floatfns): Always define isnan at the Lisp level.
7188
e39b275c 71892011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
7190
7191 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
7192
b2db44d9 71932011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 7194
f4af5137 7195 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
7196 The previous code assumed that file offsets (off_t values) fit in
7197 EMACS_INT variables, which is not true on typical 32-bit hosts.
7198 The code messed up by falsely reporting buffer overflow in cases
7199 such as (insert-file-contents "big" nil 1 2) into an empty buffer
7200 when "big" contains more than 2**29 bytes, even though this
7201 inserts just one byte and does not overflow the buffer.
7202 (Finsert_file_contents): Store file offsets as off_t
7203 values, not as EMACS_INT values. Check for overflow when
7204 converting between EMACS_INT and off_t. When checking for
7205 buffer overflow or for overlap, take the offsets into account.
7206 Don't use EMACS_INT for small values where int suffices.
7207 When checking for overlap, fix a typo: ZV was used where
7208 ZV_BYTE was intended.
7209 (Fwrite_region): Don't assume off_t fits into 'long'.
7210 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
7211
ecfc0a49
MA
72122011-09-05 Michael Albinus <michael.albinus@gmx.de>
7213
7214 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
7215
6511acf2 72162011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 7217
0999621a 7218 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
7219
7220 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 7221 (esprintf, exprintf, evxprintf): New functions.
62f19c19 7222 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 7223 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
7224 (modify_event_symbol): Do not assume that the length of
7225 name_alist_or_stem is safe to alloca and fits in int.
7226 (Fexecute_extended_command): Likewise for function name and binding.
7227 (Frecursion_depth): Wrap around reliably on integer overflow.
7228 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
7229 since some callers pass EMACS_INT values.
7230 (Fsingle_key_description): Don't crash if symbol name contains more
7231 than MAX_ALLOCA bytes.
7232 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
7233 (get_minibuffer): Arg is now EMACS_INT, not int.
7234 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 7235 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
7236 * window.h (command_loop_level, minibuf_level): Reflect API changes.
7237
2be7d702
PE
7238 * dbusbind.c (signature_cat): New function.
7239 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
7240 Do not overrun buffer; instead, report string overflow.
7241
9d1df220
PE
7242 * dispnew.c (add_window_display_history): Don't overrun buffer.
7243 Truncate instead; this is OK since it's just a log.
7244
33ef5c64
PE
7245 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
7246 even if the time zone offset is outlandishly large.
7247 Don't mishandle offset == INT_MIN.
7248
66c6fdd5
PE
7249 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
7250 when creating daemon; the previous buffer-overflow check was incorrect.
7251
d749b01b
PE
7252 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
7253 which has the guts of the old verror function.
7254
b5cd1905
PE
7255 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
7256 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
7257
6e1a67fb
PE
7258 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
7259 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 7260 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 7261 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
7262 length of string rather than counting it via multiple sprintfs;
7263 that's simpler and more reliable.
c21721cc
PE
7264 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
7265 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
7266 sprintf, in case result does not fit in int.
7267
c57b67fc
PE
7268 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
7269 (fontset_from_font): Print it.
7270
8a401434
PE
7271 * frame.c (tty_frame_count): Now printmax_t, not int.
7272 (make_terminal_frame, set_term_frame_name): Print it.
7273 (x_report_frame_params): In X, window IDs are unsigned long,
7274 not signed long, so print them as unsigned.
7275 (validate_x_resource_name): Check for implausibly long names,
7276 and don't assume name length fits in 'int'.
7277 (x_get_resource_string): Don't blindly alloca invocation name;
7278 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
7279 not fit in int.
7280
6e1a67fb
PE
7281 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
7282 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
7283 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
7284
0df02bf3
PE
7285 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
7286 Use esprintf, not sprintf, in case result does not fit in int.
7287
48e30793
PE
7288 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7289 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
7290 it as a large positive number.
7291 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
7292 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7293
a66ff6d8
PE
7294 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
7295 in case result does not fit in int.
7296
aca216ff
PE
7297 * print.c (float_to_string): Detect width overflow more reliably.
7298 (print_object): Make sprintf buffer a bit bigger, to avoid potential
7299 buffer overrun. Don't assume list length fits in 'int'. Treat
7300 print length of 0 as 0, not as infinity; to be consistent with other
7301 uses of print length in this function. Don't overflow print length
7302 index. Don't assume hash table size fits in 'long', or that
7303 vectorlike size fits in 'unsigned long'.
7304
31c286f7
PE
7305 * process.c (make_process): Use printmax_t, not int, to format
7306 process-name gensyms.
7307
55e5faa1
PE
7308 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
7309
80f2e268
PE
7310 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
7311 to avoid potential buffer overrun.
7312
670741ab
PE
7313 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
7314 if X resource line is longer than 512 bytes.
7315
b7163a50
PE
7316 * xfns.c (x_window): Make sprintf buffer a bit bigger
7317 to avoid potential buffer overrun.
7318
ae58ff1f
PE
7319 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
7320
c43c8a6a
PE
7321 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
7322
3f8236f4
PE
73232011-09-04 Paul Eggert <eggert@cs.ucla.edu>
7324
53e9fe90 7325 Integer overflow fixes for scrolling, etc.
6511acf2
PE
7326 Without these, Emacs silently mishandles large integers sometimes.
7327 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
7328 it were "C-u 1 M-x recenter" on a typical 64-bit host.
7329
6511acf2
PE
7330 * xdisp.c (try_window_id): Check Emacs fixnum range before
7331 converting to 'int'.
806add1d 7332
6511acf2 7333 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
7334 Check that an Emacs fixnum is in range before assigning it to 'int'.
7335 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
7336 values converted from Emacs fixnums.
7337 (Frecenter): Don't wrap around a line count if it is out of 'int'
7338 range; instead, treat it as an extreme value.
7339 (Fset_window_configuration, compare_window_configurations):
7340 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
7341
6511acf2
PE
7342 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
7343 that can exceed INT_MAX. Check that EMACS_INT value is in range
7344 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
7345 (match_limit): Don't assume that a fixnum can fit in 'int'.
7346
6511acf2 7347 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
7348 exceed INT_MAX.
7349
6511acf2 7350 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
7351 (Fvertical_motion): Don't wrap around LINES values that don't fit
7352 in 'int'. Instead, treat them as extreme values. This is good
7353 enough for windows, which can't have more than INT_MAX lines anyway.
7354
fcb901a7
LMI
73552011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7356
0f2f6b6d
LMI
7357 * Require libxml/parser.h to avoid compilation warning.
7358
fcb901a7
LMI
7359 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
7360
7361 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
7362 since this reportedly can destroy thread storage.
7363
6e20a0d4
CY
73642011-08-30 Chong Yidong <cyd@stupidchicken.com>
7365
7366 * syntax.c (find_defun_start): Update all cache variables if
7367 exiting early (Bug#9401).
7368
148ae00e
EZ
73692011-08-30 Eli Zaretskii <eliz@gnu.org>
7370
f6cfbd8f
EZ
7371 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
7372
148ae00e
EZ
7373 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
7374 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
7375 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
7376
7377 * term.c (tty_append_glyph): New function.
7378 (produce_stretch_glyph): Static function and its prototype deleted.
7379
a66cfb1c
SM
7380 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
7381 Add prototypes.
148ae00e 7382
c4a07a4c
PE
73832011-08-29 Paul Eggert <eggert@cs.ucla.edu>
7384
7385 * image.c (parse_image_spec): Check for nonnegative, not for positive,
7386 when checking :margin (Bug#9390).
7387 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 7388 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
7389 so that the name doesn't mislead. All uses changed.
7390
6bc8cd65
JB
73912011-08-28 Johan Bockgård <bojohan@gnu.org>
7392
7393 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
7394 set_tty_hooks.
7395
dca4927e
EZ
73962011-08-27 Eli Zaretskii <eliz@gnu.org>
7397
7398 * xdisp.c (move_it_to): Don't bail out early when reaching
7399 position beyond to_charpos, if we are scanning backwards.
7400 (move_it_vertically_backward): When DY == 0, make sure we get to
7401 the first character in the line after the newline.
7402
f2cad773
PE
74032011-08-27 Paul Eggert <eggert@cs.ucla.edu>
7404
7405 * ccl.c: Improve and simplify overflow checking (Bug#9196).
7406 (ccl_driver): Do not generate an out-of-range pointer.
7407 (Fccl_execute_on_string): Remove unnecessary check for
7408 integer overflow, noted by Stefan Monnier in
7409 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
7410 Remove a FIXME that didn't need fixing.
7411 Simplify the newly-introduced buffer reallocation code.
7412
0cae2cdb
JB
74132011-08-27 Juanma Barranquero <lekktu@gmail.com>
7414
7415 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
7416
5fc295a4 74172011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 7418
70c60eb2 7419 Integer and memory overflow issues (Bug#9196).
726e0ab1 7420
d31850da
PE
7421 * doc.c (get_doc_string): Rework so that
7422 get_doc_string_buffer_size is the actual buffer size, rather than
7423 being 1 less than the actual buffer size; this makes xpalloc more
7424 convenient.
7425
a69fbedb
PE
7426 * image.c (x_allocate_bitmap_record, cache_image):
7427 * xselect.c (Fx_register_dnd_atom):
7428 Simplify previous changes by using xpalloc.
7429
fe5c5d37
PE
7430 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
7431 since either will do and ptrdiff_t is convenient with xpalloc.
7432
0065d054
PE
7433 * charset.c (charset_table_size)
7434 (struct charset_sort_data.priority): Now ptrdiff_t.
7435 (charset_compare): Don't overflow if priorities differ greatly.
7436 (Fsort_charsets): Don't assume list length fits in int.
7437 Check for size-calculation overflow when allocating sort data.
7438 (syms_of_charset): Allocate an initial charset table that is
7439 just under 64 KiB, to avoid problems with glibc malloc and mmap.
7440
7441 * cmds.c (internal_self_insert): Check for size-calculation overflow.
7442
7443 * composite.h (struct composition.glyph_len): Now int, not unsigned.
7444 The actual value is always <= INT_MAX, and leaving it unsigned made
7445 overflow checking harder.
7446
7447 * dispextern.h (struct glyph_matrix.rows_allocated)
7448 (struct face_cache.size): Now ptrdiff_t, for convenience in use
7449 with xpalloc. The values are still always <= INT_MAX.
7450
7451 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
7452
7453 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
7454 (SAFE_NALLOCA): New macro.
7455
7456 * region-cache.c (struct boundary.pos, find_cache_boundary)
7457 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
7458 (set_cache_region, invalidate_region_cache)
7459 (revalidate_region_cache, know_region_cache, region_cache_forward)
7460 (region_cache_backward, pp_cache):
7461 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
7462 so that ptrdiff_t * can be passed to xpalloc.
7463 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
7464 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
7465 (pp_cache): Don't assume cache_len fits in int.
7466 * region-cache.h: Adjust extern decls to match.
7467
7468 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
7469 EMACS_INT, since either will do, for xpalloc.
7470
7471 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
7472 (xnmalloc, xnrealloc, xpalloc): New functions.
7473
726e0ab1
PE
7474 * bidi.c (bidi_shelve_header_size): New constant.
7475 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
7476 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
7477
51f30bc5 7478 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
7479 * buffer.c (overlays_at, overlays_in, record_overlay_string)
7480 (overlay_strings):
7481 Don't update size of array until after memory allocation succeeds,
7482 because xmalloc/xrealloc may not return.
0065d054
PE
7483 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
7484 now that we have proper integer overflow checking.
7485 (record_overlay_string, overlay_strings): Catch overflows when
7486 calculating size of overlay_str_buf.
726e0ab1 7487
0065d054
PE
7488 * callproc.c (Fcall_process): Check for size overflow when
7489 calculating size of args2.
7490 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
7491 Normally we prefer signed values, but sticking with ptrdiff_t would
7492 require adding more-complicated checks.
726e0ab1
PE
7493
7494 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
7495 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
7496 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 7497 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
7498
7499 * character.c (Fstring): Check for size-calculation overflow.
7500
7501 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
7502 unnecessary integer overflow. Check for size overflow.
7503 (encode_coding_object): Don't update size until xmalloc succeeds.
7504
7505 * composite.c (get_composition_id): Check for overflow in glyph
7506 length calculations.
7507
7508 Integer and memory overflow fixes for display code.
7509 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
7510 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
7511 (scrolling_window): Check for overflow in size calculations.
7512 (line_draw_cost, realloc_glyph_pool, add_row_entry):
7513 Don't assume glyph table len fits in int.
7514 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
7515 (row_table_size): Now ptrdiff_t, not int.
7516 (scrolling_window): Avoid overflow in size calculations.
7517 Don't update size until allocation succeeds.
7518 * fns.c (concat): Check for overflow in size calculations.
7519 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
7520 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7521 (NEXT_ALMOST_PRIME_LIMIT): New constant.
7522
7523 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
7524 (get_doc_string): Check for size calculation overflow.
7525 Don't update size until allocation succeeds.
7526 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
7527 EMACS_INT, where ptrdiff_t will do.
7528 (Fsubstitute_command_keys): Check for string overflow.
7529
7530 * editfns.c (set_time_zone_rule): Don't assume environment length
7531 fits in int.
7532 (message_length): Now ptrdiff_t, not int.
7533 (Fmessage_box): Don't update size until allocation succeeds.
7534 Don't assume message length fits in int.
7535 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
7536
0065d054
PE
7537 * emacs.c (main): Do not reallocate argv, since there is a null at
7538 the end that can be overwritten, and this way there's no need to
7539 worry about size-calculation overflow.
7540 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
7541
7542 * eval.c (init_eval_once, grow_specpdl): Don't update size until
7543 alloc succeeds.
7544 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
7545
7546 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
7547 (x_set_scroll_bar_width, x_figure_window_size):
7548 Check for integer overflow.
7549 (x_set_alpha): Do not assume XINT fits in int.
7550
7551 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
7552 This is for the members text_lines, text_cols, total_lines, total_cols,
7553 where the system imposes an 'int' limit.
7554
7555 * fringe.c (Fdefine_fringe_bitmap):
7556 Don't update size until alloc works.
7557
7558 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
7559 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
7560
7561 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
7562 Check for size-calculation overflow.
7563 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
7564 do, as we prefer signed integers.
7565 (id_to_widget.max_size, id_to_widget.used)
7566 (xg_store_widget_in_map, xg_remove_widget_from_map)
7567 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
7568 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
7569 Use and return ptrdiff_t, not int.
7570 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
7571 * gtkutil.h: Change prototypes to match the above.
7572
7573 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
7574 are duplicate now that they've been promoted to lisp.h.
7575 (x_allocate_bitmap_record, x_alloc_image_color)
7576 (make_image_cache, cache_image, xpm_load):
7577 Don't update size until alloc is done.
7578 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
7579 (x_detect_edges):
3256efce 7580 Check for size calculation overflow.
726e0ab1
PE
7581 (ct_colors_allocated_max): New constant.
7582 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
7583 overflow.
3256efce 7584
726e0ab1
PE
7585 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
7586 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
7587 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
7588 Use ptrdiff_t, not int, to count maps.
7589 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
7590 calculations. Don't update size until allocation succeeds.
7591 Redo calculations to avoid overflow.
726e0ab1
PE
7592 * keyboard.h: Change prototypes to match the above.
7593
7594 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
7595 to count maps.
7596 (current_minor_maps): Check for size calculation overflow.
7597 * keymap.h: Change prototypes to match the above.
7598
7599 * lread.c (read1, init_obarray): Don't update size until alloc done.
7600
7601 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
7602 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
7603
726e0ab1
PE
7604 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
7605 Now ptrdiff_t, not int.
7606 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
7607 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
7608
7609 * process.c (Fnetwork_interface_list): Check for overflow
7610 in size calculation.
7611
7612 * region-cache.c (move_cache_gap): Check for size calculation overflow.
7613
7614 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
7615 overflow. Don't bother calling xmalloc when xrealloc will do.
7616
7617 * search.c (Freplace_match): Check for size calculation overflow.
7618 (Fset_match_data): Don't assume list lengths fit in 'int'.
7619
7620 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
7621 for command line length. Do not attempt to address one before the
7622 beginning of an array, as that's not portable.
7623
7624 * term.c (max_frame_lines): Remove; unused.
7625 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
7626 not int.
7627 (encode_terminal_code, calculate_costs): Check for size
7628 calculation overflow.
7629 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
7630 table lengths and related sizes. Don't update size until alloc
7631 done. Redo calculations to avoid overflow.
7632 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
7633
7634 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
7635 subtracting pointers.
7636 (gobble_line): Check for overflow more carefully. Don't update size
7637 until alloc done.
7638
7639 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
7640 Don't update size until alloc done.
7641 Redo size calculations to avoid overflow.
7642 Check for size calculation overflow.
0065d054 7643 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
7644
7645 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
7646 Use ptrdiff_t, not int, for sizes.
7647 (store_mode_line_noprop_char): Don't update size until alloc done.
7648
0065d054
PE
7649 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
7650 Use ptrdiff_t, not int, for sizes.
7651 (Finternal_make_lisp_face, cache_face):
7652 Check for size calculation overflow.
7653 (cache_face): Treat size calculation overflows as if they were
7654 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
7655
7656 * xfns.c (x_encode_text, x_set_name_internal)
7657 (Fx_change_window_property): Use ptrdiff_t, not int, to count
7658 sizes, since they can exceed INT_MAX in size. Check for size
7659 calculation overflow.
7660
0065d054
PE
7661 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
7662 (xg_select): Check for size calculation overflow.
726e0ab1
PE
7663 Don't update size until alloc done.
7664
0065d054 7665 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 7666 as sprintf is limited to int lengths.
1d526e2f 7667
252c5ee1
PE
7668 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
7669 (X_LONG_MIN): New macros.
864d7ce7
PE
7670 Use them to make the following changes clearer.
7671 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
7672 This change doesn't affect the value now, but it may help remind
7673 future maintainers not to raise the value too much later.
7674 (SELECTION_QUANTUM): Remove, replacing with ...
7675 (selection_quantum): ... new function, which avoids overflow.
7676 All uses changed.
7677 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
7678 assumption that selection length fits in 'int'.
7679 (x_reply_selection_request, x_handle_selection_request)
7680 (x_get_window_property, receive_incremental_selection)
7681 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
7682 (lisp_data_to_selection_data, clean_local_selection_data):
7683 Use ptrdiff_t, not int, to record length of selection.
7684 (x_reply_selection_request, x_get_window_property)
7685 (receive_incremental_selection, x_property_data_to_lisp):
7686 Redo calculations to avoid overflow.
7687 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 7688 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
7689 something.
7690 (x_get_window_property, receive_incremental_selection)
7691 (lisp_data_to_selection_data, x_property_data_to_lisp):
7692 Check for size-calculation overflow.
7693 (x_get_window_property, receive_incremental_selection)
7694 (lisp_data_to_selection_data, Fx_register_dnd_atom):
7695 Don't store size until memory allocation succeeds.
7696 (x_get_window_property): Plug memory leak on memory exhaustion.
7697 Don't double-block input; malloc is safe here. Don't assume 2**34
7698 - 4 fits in unsigned long. Add an xassert to check
7699 XGetWindowProperty overflow. Be more careful about overflow
7700 calculations, and distinguish size from memory overflow better.
7701 (receive_incremental_selection): When tracing, don't assume
7702 unsigned int is less than INT_MAX.
7703 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
7704 harmful) conversions of unsigned short to int.
7705 (lisp_data_to_selection_data): Don't assume that integers
7706 in the range -65535 through -1 fit in an X unsigned short.
7707 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
7708 result parameters unless successful. Rely on cons_to_unsigned
7709 to report problems with elements; the old code wasn't right anyway.
7710 (x_check_property_data): Check for int overflow; we cannot use
7711 a wider type due to X limits.
7712 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
7713
726e0ab1 7714 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 7715
0065d054
PE
7716 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
7717 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
7718 (x_color_cells): Don't store size until memory allocation succeeds.
7719 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 7720 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
7721 (x_term_init): Don't assume length fits in int (sprintf is limited
7722 to int size).
bc18e09d 7723
ebfa62c0
PE
7724 Use ptrdiff_t for composition IDs.
7725 * character.c (lisp_string_width):
7726 * composite.c (composition_table_size, n_compositions)
7727 (get_composition_id, composition_gstring_from_id):
7728 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
7729 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
7730 * window.c (Frecenter):
7731 Use ptrdiff_t, not int, for composition IDs.
7732 * composite.c (get_composition_id): Check for integer overflow.
7733 * composite.h: Adjust prototypes to match the above changes.
7734
d3411f89
PE
7735 Use ptrdiff_t for hash table indexes.
7736 * category.c (hash_get_category_set):
7737 * ccl.c (ccl_driver):
7738 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
7739 * coding.c (coding_system_charset_list, detect_coding_system):
7740 * coding.h (struct coding_system.id):
7741 * composite.c (get_composition_id, gstring_lookup_cache):
7742 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
7743 * image.c (xpm_get_color_table_h):
7744 * lisp.h (hash_lookup, hash_put):
7745 * minibuf.c (Ftest_completion):
7746 Use ptrdiff_t for hash table indexes, not int (which is too
7747 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
7748 32-bit --with-wide-int hosts).
7749
e097a6fa
PE
7750 * charset.c (Fdefine_charset_internal): Check for integer overflow.
7751 Add a FIXME comment about memory leaks.
7752 (syms_of_charset): Don't assume xmalloc returns.
7753
5637687f
PE
7754 Don't assume that stated character widths fit in int.
7755 * character.c (Fchar_width, c_string_width, lisp_string_width):
7756 * character.h (CHAR_WIDTH):
7757 * indent.c (MULTIBYTE_BYTES_WIDTH):
7758 Use sanitize_char_width to avoid undefined and/or bad behavior
7759 with outlandish widths.
a66cfb1c 7760 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
7761 now that we have two such functions. All uses changed.
7762 (sanitize_char_width): New inline function.
7763
a2271ba2
PE
7764 Don't assume that tab-width fits in int.
7765 * character.h (sanitize_width): New inline function.
7766 (SANE_TAB_WIDTH): New macro.
7767 (ASCII_CHAR_WIDTH): Use it.
7768 * indent.c (sane_tab_width): Remove. All uses replaced by
7769 SANE_TAB_WIDTH (current_buffer).
7770 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
7771
18c52557
PE
7772 * fileio.c: Integer overflow issues with file modes.
7773 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
7774
caeeedc1
PE
7775 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
7776 Remove unreachable code.
7777 (read_hex, load_charset_map_from_file): Check for integer overflow.
7778
6df6ae42 7779 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
7780 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
7781 (x_send_scroll_bar_event): Likewise. Check that the size does not
7782 exceed limits imposed by XClientMessageEvent, as well as the usual
7783 ptrdiff_t and size_t limits.
7784
b13995db
PE
7785 * keyboard.c: Overflow, signedness and related fixes.
7786 (make_lispy_movement): Use same integer type in forward decl
7787 that is used in the definition.
7788 (read_key_sequence, keyremap_step):
7789 Change bufsize argument back to int, undoing my 2011-03-30 change.
7790 We prefer signed types, and int is wide enough here.
7791 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
7792 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
7793 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
7794 length, not size_t. Use ptrdiff_t for index, not int.
7795 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
7796 possibility of integer overflow.
7797
13464394
PE
7798 Overflow, signedness and related fixes for images.
7799
7800 * dispextern.h (struct it.stack[0].u.image.image_id)
7801 (struct_it.image_id, struct image.id, struct image_cache.size)
7802 (struct image_cache.used, struct image_cache.ref_count):
7803 * gtkutil.c (update_frame_tool_bar):
7804 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
7805 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
7806 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
7807 * nsmenu.m (update_frame_tool_bar):
7808 * xdisp.c (calc_pixel_width_or_height):
7809 * xfns.c (image_cache_refcount):
7810 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
7811 on typical 64-bit hosts.
7812
7813 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7814 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
7815 Omit unnecessary casts to int.
7816 (parse_image_spec): Check that integers fall into 'int' range
7817 when the callers expect that.
7818 (image_ascent): Redo ascent calculation to avoid int overflow.
7819 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
7820 (lookup_image): Remove unnecessary tests.
7821 (xbm_image_p): Locals are now of int, not EMACS_INT,
7822 since parse_image_check makes sure they fit into int.
7823 (png_load, gif_load, svg_load_image):
7824 Prefer int to unsigned where either will do.
7825 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
7826 old tiff_error_handler and tiff_warning_handler.
7827 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
7828 stack buffer overflows. It uses only the features of vsnprintf
7829 that are common to both POSIX and native Microsoft.
7830 (tiff_error_handler, tiff_warning_handler): Use it.
7831 (tiff_load, gif_load, imagemagick_load_image):
7832 Don't assume :index value fits in 'int'.
7833 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
7834 (imagemagick_load_image): Check that crop parameters fit into
7835 the integer types that MagickCropImage accepts. Don't assume
7836 Vimagemagick_render_type has a nonnegative value. Don't assume
7837 size_t fits in 'long'.
7838 (gs_load): Use printmax_t to print the widest integers possible.
7839 Check for integer overflow when computing image height and width.
7840
c11821d4
EZ
78412011-08-26 Eli Zaretskii <eliz@gnu.org>
7842
7843 * xdisp.c (redisplay_window): Don't force window start if point
7844 will be invisible in the resulting window. (Bug#9324)
7845
0c95fcf7
EZ
78462011-08-25 Eli Zaretskii <eliz@gnu.org>
7847
7848 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
7849 the display spec is of the form `(space ...)'.
7850 (handle_display_spec): Return the value returned by
7851 handle_single_display_spec, not just 1 or zero.
7852 (handle_single_display_spec): If the display spec is of the form
7853 `(space ...)', and specifies display in the text area, return 2
7854 rather than 1.
fee65a97 7855 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
7856 accurately, and prefer exact match for point under bidi.
7857 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
7858
7859 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
7860 into disp_prop; all users changed.
7861
7862 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
7863 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
7864 for the text covered by the display property.
7865
e4ed06f1
CY
78662011-08-25 Chong Yidong <cyd@stupidchicken.com>
7867
7868 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
7869 Change return value to nil.
7870 (Frecord_buffer): Delete unused function.
7871
f67cdd7f
EZ
78722011-08-24 Eli Zaretskii <eliz@gnu.org>
7873
5980d4c6
EZ
7874 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
7875 buffers, return left-to-right.
8610fe8b
EZ
7876 (set_cursor_from_row): Consider candidate row a win if its glyph
7877 represents a newline and point is on that newline. Fixes cursor
7878 positioning on the newline at EOL of R2L text within L2R
7879 paragraph, and vice versa.
7880 (try_cursor_movement): Check continued rows, in addition to
7881 continuation rows. Fixes unwarranted scroll when point enters a
7882 continued line of R2L text within an L2R paragraph, or vice versa.
7883 (cursor_row_p): Consider the case of point being equal to
7884 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
7885 from the end of a short line to the beginning of a continued line
7886 of R2L text within L2R paragraph.
7887 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
7888 composed characters.
5980d4c6 7889
f67cdd7f
EZ
7890 * bidi.c (bidi_check_type): Use xassert.
7891 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
7892 members.
7893
bca633fb
EZ
78942011-08-23 Eli Zaretskii <eliz@gnu.org>
7895
7896 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
7897 a character.
7898
4a5885a7
CY
78992011-08-23 Chong Yidong <cyd@stupidchicken.com>
7900
7901 * nsfont.m (ns_otf_to_script): Fix typo.
7902
0902a04e
KH
79032011-08-22 Kenichi Handa <handa@m17n.org>
7904
7905 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
7906 extra slot even if the purpose is char-code-property-table.
7907
1a2e6670
EZ
79082011-08-23 Eli Zaretskii <eliz@gnu.org>
7909
8ddde651
EZ
7910 * xdisp.c (redisplay_window): When computing centering_position,
7911 account for the height of the header line. (Bug#8874)
7912
425cc014
EZ
7913 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
7914 instead of CHAR_TO_BYTE. Fixes a crash when a completion
7915 candidate is selected by the mouse, and that candidate has a
7916 composed character under the mouse.
7917
1a2e6670
EZ
7918 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
7919 coordinates reported by pos-visible-in-window-p for a composed
7920 character in column zero.
7921
8b76d6f8
SM
79222011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
7923
7924 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
7925
dac347dd
EZ
79262011-08-22 Eli Zaretskii <eliz@gnu.org>
7927
7928 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
7929 consider it a hit if to_charpos is anywhere in the range of the
7930 composed buffer positions.
7931
e013fb34
CY
79322011-08-22 Chong Yidong <cyd@stupidchicken.com>
7933
7934 * image.c (gif_load): Don't assume that each subimage has the same
7935 dimensions as the base image. Handle disposal method that is
7936 "undefined" by the gif spec (Bug#9335).
7937
bd1ba3e8
CY
79382011-08-20 Chong Yidong <cyd@stupidchicken.com>
7939
7940 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 7941 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 7942
54a1215b
EZ
79432011-08-19 Eli Zaretskii <eliz@gnu.org>
7944
823564e5
EZ
7945 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
7946 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
7947 from an Org mode buffer to a Speedbar frame.
7948
54a1215b
EZ
7949 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
7950 a composition, take its buffer position from IT->cmp_it.charpos.
7951 Fixes cursor positioning at the beginning of a line that begins
7952 with a composed character.
7953
9778ebcc
EZ
79542011-08-18 Eli Zaretskii <eliz@gnu.org>
7955
0be6ee06
EZ
7956 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
7957 character bidirectional type, use STRONG_L instead. Fixes crashes
7958 in a buffer produced by `describe-categories'.
7959
9778ebcc
EZ
7960 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
7961 members before the level stack, so they would be saved and
7962 restored when copying iterator state. Fixes incorrect reordering
7963 around TABs covered by display properties.
7964
156bffbe
AS
79652011-08-18 Andreas Schwab <schwab@linux-m68k.org>
7966
6b02f655 7967 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 7968
72ad093b
CY
79692011-08-17 Chong Yidong <cyd@stupidchicken.com>
7970
7971 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
7972 (internal_condition_case_2, internal_condition_case_n):
7973 Remove unnecessary aborts (Bug#9081).
72ad093b 7974
35774242
EZ
79752011-08-17 Eli Zaretskii <eliz@gnu.org>
7976
7977 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
7978 has no `load' handler, try opening the file locally. (Bug#9311)
7979
db76dd85
KB
79802011-08-16 Ken Brown <kbrown@cornell.edu>
7981
7982 * gmalloc.c: Expand comment.
7983
b215eee5
EZ
79842011-08-16 Eli Zaretskii <eliz@gnu.org>
7985
7986 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
7987 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
7988
a4579d33
KB
79892011-08-16 Ken Brown <kbrown@cornell.edu>
7990
7991 Fix memory allocation problems in Cygwin build (Bug#9273).
7992
7993 * unexcw.c ( __malloc_initialized): Declare external variable.
7994 (fixup_executable): Force the dumped emacs to reinitialize malloc.
7995
8b76d6f8
SM
7996 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
7997 New variables.
a4579d33
KB
7998 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
7999 dumped emacs.
8000 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
8001 in the static heap.
8002 [CYGWIN] (special_realloc): New function.
8003 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
8004 requests to realloc storage in the static heap.
8005
3ebec551
PE
80062011-08-15 Paul Eggert <eggert@cs.ucla.edu>
8007
8008 * bidi.c (bidi_initialize): Remove unused local.
8009
9fd8be00
EZ
80102011-08-15 Eli Zaretskii <eliz@gnu.org>
8011
6b02f655
SM
8012 * bidimirror.h:
8013 * biditype.h: Remove file.
8014 * makefile.w32-in ($(BLD)/bidi.$(O)):
8015 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
8016
8017 * dispextern.h: Fix a typo in the comment to bidi_type_t.
8018
8019 * chartab.c: Improve commentary for the uniprop_table API.
8020
32413314
EZ
8021 * bidi.c (bidi_paragraph_init): Support zero value of
8022 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
8023 (bidi_initialize): Use uniprop_table instead of including
8024 biditype.h and bidimirror.h.
32413314 8025
9fd8be00
EZ
8026 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
8027 coordinates of the iterator when restoring from ppos_it.
8028 (Bug#9296)
8029
5cf2b69b
KH
80302011-08-14 Kenichi Handa <handa@m17n.org>
8031
8032 * process.c (create_process): Call setup_process_coding_systems
72ad093b 8033 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 8034
daf17d00
EZ
80352011-08-14 Eli Zaretskii <eliz@gnu.org>
8036
8037 * xdisp.c (move_it_in_display_line_to): Don't invoke
8038 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
8039 ppos_it. Fixes vertical cursor motion when line beginning is
8040 covered by an image. (Bug#9296)
8041
08e3161a
JD
80422011-08-14 Jan Djärv <jan.h.d@swipnet.se>
8043
8044 * nsterm.h (ns_run_ascript): Declare.
8045 (NSAPP_DATA2_RUNASSCRIPT): Define.
8046
8047 * nsfns.m (as_script, as_result, as_status): New static variables.
8048 (ns_run_ascript): New function.
5e617bc2 8049 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
8050 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
8051 the event loop. Get status from as_status (Bug#7276).
8052
8053 * nsterm.m (sendEvent): If event is NSApplicationDefined and
8054 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
8055 the event loop (Bug#7276).
8056
a3720aa2
AS
80572011-08-14 Andreas Schwab <schwab@linux-m68k.org>
8058
8059 * gnutls.c (QCgnutls_bootprop_priority)
8060 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
8061 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
8062 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
8063 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
8064 (QCgnutls_bootprop_verify_hostname_error)
8065 (QCgnutls_bootprop_callbacks_verify): Rename from
8066 Qgnutls_bootprop_..., all uses changed.
8067
8068 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
8069 uses changed.
8070
0a0d27fb
PE
80712011-08-14 Paul Eggert <eggert@cs.ucla.edu>
8072
19d5c50c
PE
8073 * xfaces.c (Qframe_set_background_mode): Now static.
8074 * dispextern.h (Qframe_set_background_mode): Remove decl.
8075
0a0d27fb
PE
8076 * process.c (Fnetwork_interface_info): Declare local only if needed.
8077
377538cb
JD
80782011-08-13 Jan Djärv <jan.h.d@swipnet.se>
8079
8080 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
8081 (Fnetwork_interface_list): Allocate in increments of bytes instead
8082 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
8083 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
8084 sockaddr.
8085 (struct ifflag_def): notrailers is smart on OSX.
8086 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
8087 Get hardware address with getifaddrs if available.
8088
08fff70c
EZ
80892011-08-12 Eli Zaretskii <eliz@gnu.org>
8090
8091 * xdisp.c (iterate_out_of_display_property): xassert that
8092 IT->position is set to within IT->object's boundaries. Break from
8093 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
8094 when IT->position is set up wrongly due to some bug.
8095 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
8096 (push_display_prop): Allow GET_FROM_STRING as IT->method on
8097 entry. Force push_it to save on the stack the current
8098 buffer/string position, to be restored by pop_it. Fix flags in
8099 the iterator structure wrt the object coming from a display
8100 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
8101 properties. (Bug#9284)
8102
7be1c708 81032011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 8104
7be1c708
CY
8105 * fontset.c (fontset_get_font_group): Add proper type checks.
8106 (Bug#9172)
aac0c6e3 8107
7be1c708 81082011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 8109
7be1c708
CY
8110 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
8111 and LC_VERSION_MIN_MACOSX.
8112 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
8113 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 8114
97bb72a6
EZ
81152011-08-08 Eli Zaretskii <eliz@gnu.org>
8116
8117 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
8118 no-display-properties-and-no-overlays under bidi display.
8119 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 8120 properties and overlays.
97bb72a6 8121
d5617611
CY
81222011-08-08 Chong Yidong <cyd@stupidchicken.com>
8123
37e11a63
CY
8124 * editfns.c (Fset_time_zone_rule): Document relationship with the
8125 setenv function.
8126
d5617611
CY
8127 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
8128 the font entity extracted from the cache (Bug#8109).
8129
58872834
CY
81302011-08-07 Chong Yidong <cyd@stupidchicken.com>
8131
8132 * composite.c (autocmp_chars): Don't reset point. That is done by
8133 restore_point_unwind (Bug#5984).
8134
75bfc667
JL
81352011-08-07 Juri Linkov <juri@jurta.org>
8136
8137 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
8138 to show the arg `TIME' instead of `TIMEVAL'.
8139
d1410150
EZ
81402011-08-06 Eli Zaretskii <eliz@gnu.org>
8141
8142 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
8143 display property strides EOL and includes a newline, as in
8144 longlines-mode. (Bug#9254)
75b771e4
EZ
8145 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
8146 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
8147
8148 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
8149 is non-zero, even if the data buffer is NULL. Fixes a crash in
8150 vertical-motion with longlines-mode. (Bug#9254)
8151
35928349
EZ
81522011-08-05 Eli Zaretskii <eliz@gnu.org>
8153
ec7cc85b
EZ
8154 * bidi.c <bidi_cache_total_alloc>: Now static.
8155 (bidi_initialize): Initialize bidi_cache_total_alloc.
8156
8b76d6f8 8157 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
8158 cache. (Bug#9221)
8159
8160 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
8161 amount allocated this far in `bidi_cache_total_alloc'.
8162 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
8163 non-zero, only free the data buffer without restoring the cache
8164 contents. All callers changed.
8165
8166 * dispextern.h (bidi_unshelve_cache): Update prototype.
8167
8168 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
8169 (move_it_in_display_line, move_it_to)
8170 (move_it_vertically_backward, move_it_by_lines): Replace the call
8171 to xfree to an equivalent call to bidi_unshelve_cache.
8172 (move_it_in_display_line_to): Fix logic of returning
412b6358 8173 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 8174
e2e2423b
EZ
81752011-08-05 Eli Zaretskii <eliz@gnu.org>
8176
8177 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
8178 came from a string character with a `cursor' property. (Bug#9229)
8179
ae9e757a
JD
81802011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8181
8182 * Makefile.in (LIB_PTHREAD): New variable.
8183 (LIBES): Add LIB_PTHREAD (Bug#9216).
8184
8185 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
8186 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
8187
213bd7f2
AS
81882011-08-04 Andreas Schwab <schwab@linux-m68k.org>
8189
6b02f655 8190 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 8191
99aaf75f
JD
81922011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8193
8194 * xterm.c (x_find_topmost_parent): New function.
8195 (x_set_frame_alpha): Find topmost parent window with
8196 x_find_topmost_parent and set the property there also (bug#9181).
8197 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
8198
c74e9d86
PE
81992011-08-04 Paul Eggert <eggert@cs.ucla.edu>
8200
8201 * callproc.c (Fcall_process): Avoid vfork clobbering
8202 the local vars buffer, coding_systems, current_dir.
8203
640c8776
SM
82042011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
8205
8206 * keymap.c (Fmake_composed_keymap): Move to subr.el.
8207
f26d0e4c
PE
82082011-08-03 Paul Eggert <eggert@cs.ucla.edu>
8209
8a10d76c
PE
8210 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
8211 so that it is not optimized away.
8212
f26d0e4c
PE
8213 * xdisp.c (compute_display_string_pos): Remove unused local.
8214
55439c61
EZ
82152011-08-02 Eli Zaretskii <eliz@gnu.org>
8216
8217 Fix slow cursor motion and scrolling in large buffers with
8218 selective display, like Org Mode buffers. (Bug#9218)
8219
8220 * dispextern.h (struct bidi_it): New member disp_prop_p.
8221
8222 * xdisp.c: Remove one-slot cache of display string positions.
8223 (compute_display_string_pos): Accept an additional argument
5e617bc2 8224 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
8225 for a display string or property. If found, set DISP_PROP_P
8226 non-zero.
8227
8228 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
8229 DISP_PROP_P, and pass it to compute_display_string_pos.
8230 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
8231 non-zero. All callers of bidi_fetch_char changed.
8232
fb33fa43
SM
82332011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
8234
8235 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
8236
b099e063
DM
82372010-12-03 Don March <don@ohspite.net>
8238
8239 * keymap.c (Fdefine_key): Fix non-prefix key error message when
8240 last character M-[char] is translated to ESC [char] (bug#7541).
8241
5cc7f7af
KH
82422011-08-02 Kenichi Handa <handa@m17n.org>
8243
d0fffa3f 8244 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
8245
8246 * chartab.c (uniprop_table): Make it non-static.
8247
525d5e6e
EZ
82482011-08-01 Eli Zaretskii <eliz@gnu.org>
8249
8250 * xdisp.c (forward_to_next_line_start): Accept additional argument
8251 BIDI_IT_PREV, and store into it the state of the bidi iterator had
8252 on the newline.
8253 (reseat_at_next_visible_line_start): Use the bidi iterator state
8254 returned by forward_to_next_line_start to restore the state of
8255 it->bidi_it after backing up to previous newline. (Bug#9212)
8256
31011111
AS
82572011-07-30 Andreas Schwab <schwab@linux-m68k.org>
8258
8259 * regex.c (re_comp): Protoize.
8260 (re_exec): Fix return type.
8261 (regexec): Fix type of `ret'. (Bug#9203)
8262
476371c4
PE
82632011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8264
e5d76069
PE
8265 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
8266 This is needed if max-image-size is a floating-point number.
8267
9a79b20c
AS
82682011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8269
8270 * print.c (print_object): Print empty symbol as ##.
8271
8272 * lread.c (read1): Read ## as empty symbol.
8273
d8c2fa78
AA
82742011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
8275
8276 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
8277 setting frame foreground color (Bug#9175).
8278 (x_set_background_color): Likewise.
8279
ffe57a7a
AA
8280 * nsmenu.m (-setText): Size tooltip dimensions precisely to
8281 contents (Bug#9176).
8282 (EmacsTooltip -init): Remove bezels and add shadows to
8283 tooltip windows.
8284
bf3492a5
AA
8285 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
8286 or scroll bar (Bug#8470).
8287
d55e9c53
AA
8288 * nsfont.m (nsfont_open): Remove assignment to voffset and
8289 unnecessary vars hshink, expand, hd, full_height, min_height.
8290 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
8291
8292 * nsterm.h (nsfont_info): Remove voffset field.
8293
d8c2fa78 82942011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
8295
8296 Implement strike-through and overline on NextStep (Bug#8863).
8297
8298 * nsfont.m (nsfont_open): Use underline position provided by font,
8299 instead of hard-coded value of 2.
8300 (nsfont_draw): Call ns_draw_text_decoration instead.
8301
8302 * nsterm.h: Add declaration for ns_draw_text_decoration.
8303
8304 * nsterm.m (ns_draw_text_decoration): New function for drawing
8305 underline, overline, and strike-through.
8306 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
8307 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 8308 accommodate underlining, etc.
4843aac3 8309
4cc60b9b
EZ
83102011-07-28 Eli Zaretskii <eliz@gnu.org>
8311
bc7ece87
EZ
8312 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
8313 default.
4cc60b9b 8314
476371c4
PE
83152011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8316
66606eea
PE
8317 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
8318 Without this fix, if a signal arrives just after memory fills up,
8319 'malloc' might be invoked reentrantly.
8320
476371c4
PE
8321 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
8322 In other words, assume that every image size is allowed, on non-X
8323 hosts. This assumption is probably wrong, but it lets Emacs compile.
8324
f3fcc40d
AS
83252011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8326
8327 * regex.c (re_iswctype): Convert return values to boolean.
8328
350c992f
EZ
83292011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
8330
8331 * xdisp.c (compute_display_string_pos): Don't use cached display
8332 string position if the buffer had its restriction changed.
8333 (Bug#9184)
8334
5266b4bb
PE
83352011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8336
8337 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8338
2573a837 83392011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 8340
41f55ccd 8341 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 8342
39e378da
PE
8343 * bidi.c: Integer size and overflow fixes.
8344 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
8345 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
8346 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8347 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
8348 (bidi_find_other_level_edge):
8349 Use ptrdiff_t instead of EMACS_INT where either will do.
8350 This works better on 32-bit hosts configured --with-wide-int.
8351 (bidi_cache_ensure_space): Check for size-calculation overflow.
8352 Use % rather than repeated addition, for better worst-case speed.
8353 Don't set bidi_cache_size until after xrealloc returns, because it
8354 might not return.
8355 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
8356 (bidi_cache_ensure_space): Also check that the bidi cache size
8357 does not exceed that of the largest Lisp string or buffer. See Eli
8358 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 8359
5e927815
PE
8360 * alloc.c (__malloc_size_t): Remove.
8361 All uses replaced by size_t. See Andreas Schwab's note
8362 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
8363
ca4aa935
PE
8364 * image.c: Improve checking for integer overflow.
8365 (check_image_size): Assume that f is nonnull, since
8366 it is always nonnull in practice. This is one less thing to
8367 worry about when checking for integer overflow later.
8368 (x_check_image_size): New function, which checks for integer
8369 overflow issues inside X.
8370 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
8371 This removes the need for a memory_full check.
8372 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
8373 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
8374 (xbm_read_bitmap_data): Change locals back to 'int', since
8375 their values must fit in 'int'.
8376 (xpm_load_image, png_load, tiff_load):
8377 Invoke x_create_x_image_and_pixmap earlier,
8378 to avoid much needless work if the image is too large.
8379 (tiff_load): Treat overly large images as if
8380 x_create_x_image_and_pixmap failed, not as malloc failures.
8381 (gs_load): Use x_check_image_size.
8382
5f8f9cc2
PE
8383 * gtkutil.c: Omit integer casts.
8384 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
8385 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
8386
5adf60bc
PE
8387 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
8388
c8907a93
PE
8389 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
8390 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
8391 would wrongly return t on a 64-bit host.
8392
e3c25c68
PE
8393 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
8394 The plain *_OVERFLOW macros run afoul of GCC bug 49705
8395 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
8396 and therefore cause GCC to emit a bogus diagnostic in some cases.
8397
3f791afe
PE
8398 * image.c: Integer signedness and overflow and related fixes.
8399 This is not an exhaustive set of fixes, but it's time to
8400 record what I've got.
8401 (lookup_pixel_color, check_image_size): Remove redundant decls.
8402 (check_image_size): Don't assume that arbitrary EMACS_INT values
8403 fit in 'int', or that arbitrary 'double' values fit in 'int'.
8404 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
8405 (tiff_load, imagemagick_load_image):
8406 Check for overflow in size calculations.
8407 (x_create_x_image_and_pixmap): Remove unnecessary test for
8408 xmalloc returning NULL; that can't happen.
8409 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
8410 (xpm_color_bucket): Use better integer hashing function.
8411 (xpm_cache_color): Don't possibly over-allocate memory.
8412 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
8413 (gif_memory_source):
8414 Use ptrdiff_t, not int or size_t, to record sizes.
8415 (png_load): Don't assume values greater than 2**31 fit in 'int'.
8416 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
8417 either works, as we prefer signed integers.
8418 (tiff_read_from_memory, tiff_write_from_memory):
8419 Return tsize_t, not size_t, since that's what the TIFF API wants.
8420 (tiff_read_from_memory): Don't fail simply because the read would
8421 go past EOF; instead, return a short read.
8422 (tiff_load): Omit no-longer-needed casts.
8423 (Fimagemagick_types): Don't assume size fits into 'int'.
8424
3cc5a532
PE
8425 Improve hashing quality when configured --with-wide-int.
8426 * fns.c (hash_string): New function, taken from sxhash_string.
8427 Do not discard information about ASCII character case; this
8428 discarding is no longer needed.
8429 (sxhash-string): Use it. Change sig to match it. Caller changed.
8430 * lisp.h: Declare it.
8431 * lread.c (hash_string): Remove, since we now use fns.c's version.
8432 The fns.c version returns a wider integer if --with-wide-int is
8433 specified, so this should help the quality of the hashing a bit.
8434
b312a492
PE
8435 * emacs.c: Integer overflow minor fix.
8436 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
8437 Define only if GNU_LINUX.
8438 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
8439
dfd153ae
PE
8440 * dispnew.c: Integer signedness and overflow fixes.
8441 Remove unnecessary forward decls, that were a maintenance hassle.
8442 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
8443 All uses changed.
8444 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
8445 (scrolling_window): Use ptrdiff_t, not int, for byte count.
8446 (prepare_desired_row, line_draw_cost):
8447 Use int, not unsigned, where either works.
8448 (save_current_matrix, restore_current_matrix):
8449 Use ptrdiff_t, not size_t, where either works.
8450 (init_display): Check for overflow more accurately, and without
8451 relying on undefined behavior.
8452
a81d11a3
PE
8453 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
8454 Remove, replacing with the new symbols in lisp.h. All uses changed.
8455 * fileio.c (make_temp_name):
8456 * filelock.c (lock_file_1, lock_file):
8457 * xdisp.c (message_dolog):
8458 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
8459 Use pMd etc. instead.
8460 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
8461 replacing the pWIDE etc. symbols removed from editfns.c.
8462
3300e6fd
PE
8463 * keyboard.h (num_input_events): Now uintmax_t.
8464 This is (very slightly) less likely to mess up due to wraparound.
8465 All uses changed.
8466
fd05c7e9
PE
8467 * buffer.c: Integer signedness fixes.
8468 (alloc_buffer_text, enlarge_buffer_text):
8469 Use ptrdiff_t rather than size_t when either will do, as we prefer
8470 signed integers.
8471
903fe15d
PE
8472 * alloc.c: Integer signedness and overflow fixes.
8473 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
8474 (__malloc_size_t): Default to size_t, not to int.
8475 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
8476 (Fgarbage_collect, mark_object_loop_halt, mark_object):
8477 Prefer ptrdiff_t to size_t when either would do, as we prefer
8478 signed integers.
8479 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
8480 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
8481 Now const. Initialize with values that are in range even if char
8482 is signed.
8483 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
8484 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
8485 These functions do the right thing with sizes > 2**32.
8486 (check_depth): Now ptrdiff_t, not int.
8487 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
8488 Adjust to new way of storing sizes. Check for size overflow bugs
8489 in rest of code.
8490 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
8491 slightly wrong anyway, as it missed one instance of
8492 XMALLOC_OVERRUN_CHECK_OVERHEAD.
8493 (refill_memory_reserve): Omit needless cast to size_t.
8494 (mark_object_loop_halt): Mark as externally visible.
8495
ac82cc6a
PE
8496 * xselect.c: Integer signedness and overflow fixes.
8497 (Fx_register_dnd_atom, x_handle_dnd_message):
8498 Use ptrdiff_t, not size_t, since we prefer signed.
8499 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
8500 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
8501 x_dnd_atoms_size and x_dnd_atoms_length.
8502
c2d1e36d
PE
8503 * doprnt.c: Prefer signed to unsigned when either works.
8504 * eval.c (verror):
8505 * doprnt.c (doprnt):
8506 * lisp.h (doprnt):
8507 * xdisp.c (vmessage):
8508 Use ptrdiff_t, not size_t, when using or implementing doprnt,
8509 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
8510 prefer signed arithmetic to avoid comparison confusion.
8511 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
8512 but is a bit tricky.
8513
0e926e56
PE
8514 Assume freestanding C89 headers, string.h, stdlib.h.
8515 * data.c, doprnt.c, floatfns.c, print.c:
8516 Include float.h unconditionally.
8517 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
8518 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
8519 * regex.c: Likewise for stddef.h, string.h.
8520 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
8521 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
8522 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
8523 (STDC_HEADERS): Remove obsolete defines.
8524 * sysdep.c: Include limits.h unconditionally.
8525
9cfdb3ec
PE
8526 Assume support for memcmp, memcpy, memmove, memset.
8527 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
8528 * regex.c (memcmp, memcpy):
8529 Remove; we assume C89 now.
8530
8531 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
8532 (__malloc_safe_bcopy): Remove; no longer needed.
8533
cf950e6b 8534 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
8535 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
8536 well either way, and we prefer signed to unsigned.
8537
dbf38e02
LMI
85382011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
8539
8540 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
8541 closes the connection while we're reading (bug#9182).
8542
d6f0886c 85432011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 8544
d6f0886c
JD
8545 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
8546 are specified (Bug#9168).
24e0f6b1 8547
2eb1f9e6
PE
85482011-07-25 Paul Eggert <eggert@cs.ucla.edu>
8549
8550 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
8551 Found by GCC static checking and --with-wide-int on a 32-bit host.
8552
22381272 85532011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
8554
8555 * xdisp.c (compute_display_string_pos): Fix logic of caching
8556 previous display string position. Initialize cached_prev_pos to
8557 -1. Fixes slow-down at the beginning of a buffer.
8558
f25e39b4
EZ
85592011-07-24 Eli Zaretskii <eliz@gnu.org>
8560
8561 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
8562 for attrs[LFACE_FONTSET_INDEX].
8563
04c4b52e
PE
85642011-07-23 Paul Eggert <eggert@cs.ucla.edu>
8565
8566 * xml.c (parse_region): Remove unused local
8567 that was recently introduced.
8568
c1734fbd
EZ
85692011-07-23 Eli Zaretskii <eliz@gnu.org>
8570
be18c5a5
EZ
8571 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
8572 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
8573
c1734fbd
EZ
8574 * xdisp.c (move_it_in_display_line_to): Record the best matching
8575 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
8576 exit if none of the characters scanned was an exact match.
8577 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
8578 when exact match is impossible due to invisible text, and the
8579 lines are truncated.
8580
a258d627
JD
85812011-07-23 Jan Djärv <jan.h.d@swipnet.se>
8582
8583 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
8584 for OSX >= 10.7.
8585
b6d5a689
EZ
85862011-07-22 Eli Zaretskii <eliz@gnu.org>
8587
0f74f785
EZ
8588 Fix a significant slow-down of cursor motion with C-n, C-p,
8589 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
8590 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 8591 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
8592 (next_element_from_buffer): Call compute_stop_pos_backwards to
8593 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
8594 base_level_stop.
8595 (reseat): Don't look for prev_stop, as that could mean a very long
8596 run.
8597 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
8598 <cached_disp_overlay_modiff>: Cache for last found display string
8599 position.
551918c1 8600 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
8601 about the same buffer in the same area of character positions, and
8602 the buffer wasn't changed since the time the display string
8603 position was cached.
551918c1 8604
b2d0c91a
EZ
86052011-07-22 Eli Zaretskii <eliz@gnu.org>
8606
8607 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
8608 is an integer, which is important for empty lines. (Bug#9149)
8609
043604ee
CY
86102011-07-22 Chong Yidong <cyd@stupidchicken.com>
8611
8612 * frame.c (Fmodify_frame_parameters): In tty case, update the
8613 default face if necessary (Bug#4238).
8614
da4adb04
CY
86152011-07-21 Chong Yidong <cyd@stupidchicken.com>
8616
8617 * editfns.c (Fstring_to_char): No need to explain what a character
8618 is in the docstring (Bug#6576).
8619
9abd0532
LMI
86202011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8621
8622 * xml.c (parse_region): Make sure we always return a tree.
8623
36881d16
HK
86242011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
8625
8626 * xml.c (parse_region): If a document contains only comments,
8627 return that, too.
8628
1e98674d
LMI
86292011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8630
8631 * xml.c (make_dom): Return comments, too.
8632
590bd467
PE
86332011-07-19 Paul Eggert <eggert@cs.ucla.edu>
8634
8635 Port to OpenBSD.
8636 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
8637 and the surrounding thread.
8638 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
8639 rather than fgets, and retry after EINTR. Otherwise, 'emacs
8640 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
8641 timer goes off.
8642 * s/openbsd.h (BROKEN_SIGIO): Define.
8643 * unexelf.c (unexec) [__OpenBSD__]:
8644 Don't update the .mdebug section of the Alpha COFF symbol table.
8645
f41628b2
LMI
86462011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
8647
8648 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
8649 (bug#8460).
8650
b59b67c5
PE
86512011-07-18 Paul Eggert <eggert@cs.ucla.edu>
8652
15e3a074
PE
8653 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
8654 This fixes some race conditions on the permissions of any newly
8655 created file.
8656
41bed37d
PE
8657 * alloc.c (valid_pointer_p): Use pipe, not open.
8658 This fixes some permissions issues when debugging.
8659
b59b67c5
PE
8660 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
8661 If fchown fails to set both uid and gid, try to set just gid,
8662 as that is sometimes allowed. Adjust the file's mode to eliminate
8663 setuid or setgid bits that are inappropriate if fchown fails.
8664
925a6be7
SM
86652011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
8666
8667 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
8668 to compare Lisp_Objects.
8669 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
8670 global_gnutls_log_level, don't mistake it for a Lisp_Object.
8671 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
8672
52968808
AS
86732011-07-17 Andreas Schwab <schwab@linux-m68k.org>
8674
0a6a104b
AS
8675 * lread.c (read_integer): Unread even EOF character.
8676 (read1): Likewise. Properly record start position of symbol.
8677
52968808
AS
8678 * lread.c (read1): Read `#:' as empty uninterned symbol if no
8679 symbol character follows.
8680
9e381cdd
PE
86812011-07-17 Paul Eggert <eggert@cs.ucla.edu>
8682
8683 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
8684 This works around a problem with the previous change to Fcopy_file.
8685 Recent glibc declares fchown with __attribute__((warn_unused_result)),
8686 and without this change, GCC might complain about discarding
8687 fchown's return value.
8688
b5641435
JB
86892011-07-16 Juanma Barranquero <lekktu@gmail.com>
8690
8691 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
8692
a8031457
PE
86932011-07-16 Paul Eggert <eggert@cs.ucla.edu>
8694
8695 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
8696
dd889327
LMI
86972011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
8698
750c33f7
LMI
8699 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
8700 it's used from the C level.
8701
dd889327
LMI
8702 * process.c: Use the same condition for POLL_FOR_INPUT in both
8703 keyboard.c and process.c (bug#1858).
8704
87e86684
LM
87052011-07-09 Lawrence Mitchell <wence@gmx.li>
8706
8707 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
8708 (Fgnutls_boot): Use it.
8709
64348f40
AS
87102011-07-15 Andreas Schwab <schwab@linux-m68k.org>
8711
8712 * doc.c (Fsubstitute_command_keys): Revert last change.
8713
1d698799
LMI
87142011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
8715
f863868c
LMI
8716 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
8717 quotes the next character, and doesn't affect other longer
8718 sequences (bug#8935).
8719
1d698799
LMI
8720 * lread.c (syms_of_lread): Clarify that is isn't only
8721 `eval-buffer' and `eval-defun' that's affected by
8722 `lexical-binding' (bug#8460).
8723
aa4b6df6
EZ
87242011-07-15 Eli Zaretskii <eliz@gnu.org>
8725
8726 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 8727 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 8728
5d856da6
PE
87292011-07-14 Paul Eggert <eggert@cs.ucla.edu>
8730
ad6042bb
PE
8731 Fix minor problems found by static checking.
8732 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
8733 (elsz): Now a signed constant, not a size_t var. We prefer signed
8734 types to unsigned, to avoid integer comparison confusion. Without
8735 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
8736 "cannot optimize loop, the loop counter may overflow", a symptom
8737 of the confusion.
f00bbb22 8738 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
8739 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
8740
6468f31c
LMI
87412011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8742
49080b10
LMI
8743 * search.c (Fre_search_backward): Mention `case-fold-search' in
8744 all the re_search_* functions (bug#8138).
8745
6468f31c
LMI
8746 * keyboard.c (Fopen_dribble_file): Document when the file is
8747 closed (bug#8056).
8748
c965adc5
EZ
87492011-07-14 Eli Zaretskii <eliz@gnu.org>
8750
df9733bf
EZ
8751 * bidi.c (bidi_dump_cached_states): Fix format of displaying
8752 bidi_cache_idx.
8753
0bb23927
EZ
8754 Support bidi reordering of display and overlay strings.
8755 * xdisp.c (compute_display_string_pos)
8756 (compute_display_string_end): Accept additional argument STRING.
8757 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
8758 (reseat_to_string): Initialize bidi_it->string.s and
8759 bidi_it->string.schars.
8760 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
8761 NULL (avoids a crash in bidi_paragraph_init).
8762 Initialize itb.string.lstring.
0bb23927
EZ
8763 (init_iterator): Call bidi_init_it only of a valid
8764 buffer position was specified. Initialize paragraph_embedding to
8765 L2R.
8766 (reseat_to_string): Initialize the bidi iterator.
8767 (display_string): If we need to ignore text properties of
8768 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
8769 original value of -1 will not work with bidi.)
8770 (compute_display_string_pos): First arg is now struct
8771 `text_pos *'; all callers changed. Support display properties on
8772 Lisp strings.
8773 (compute_display_string_end): Support display properties on Lisp
8774 strings.
8775 (init_iterator, reseat_1, reseat_to_string): Initialize the
8776 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
8777 when iterating on a string not from display properties).
640c8776
SM
8778 (compute_display_string_pos, compute_display_string_end):
8779 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
8780 arrow keys.
8781 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
8782 base_level_stop; instead, set base_level_stop to BEGV.
8783 Fixes crashes in vertical-motion.
0bb23927
EZ
8784 (next_element_from_buffer): Improve commentary for when
8785 the iterator is before prev_stop.
8786 (init_iterator): Initialize bidi_p from the default value of
8787 bidi-display-reordering, not from buffer-local value. Use the
8788 buffer-local value only if initializing for buffer iteration.
8789 (handle_invisible_prop): Support invisible properties on strings
8790 that are being bidi-reordered.
8791 (set_iterator_to_next): Support bidi reordering of C strings and
8792 Lisp strings.
8793 (next_element_from_string): Support bidi reordering of Lisp
8794 strings.
8795 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
8796 (display_string): Support display of R2L glyph rows.
8797 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
8798 (init_iterator): Don't initialize it->bidi_p for strings
8799 here.
8800 (reseat_to_string): Initialize it->bidi_p for strings here.
8801 (next_element_from_string, next_element_from_c_string)
8802 (next_element_from_buffer): Add xassert's for correspondence
8803 between IT's object being iterated and it->bidi_it.string
8804 structure.
8805 (face_before_or_after_it_pos): Support bidi iteration.
8806 (next_element_from_c_string): Handle the case of the first string
8807 character that is not the first one in the visual order.
8808 (get_visually_first_element): New function, refactored from common
8809 parts of next_element_from_buffer, next_element_from_string, and
8810 next_element_from_c_string.
8811 (tool_bar_lines_needed, redisplay_tool_bar)
8812 (display_menu_bar): Force left-to-right direction. Add a FIXME
8813 comment for making that be controlled by a user option.
8814 (push_it, pop_it): Save and restore the state of the
8815 bidi iterator. Save and restore the bidi_p flag.
8816 (pop_it): Iterate out of display property for string iteration as
8817 well.
8818 (iterate_out_of_display_property): Support iteration over strings.
8819 (handle_single_display_spec): Set up it->bidi_it for iteration
8820 over a display string, and call bidi_init_it.
8821 (handle_single_display_spec, next_overlay_string)
8822 (get_overlay_strings_1, push_display_prop): Set up the bidi
8823 iterator for displaying display or overlay strings.
8824 (forward_to_next_line_start): Don't use the shortcut if
8825 bidi-iterating.
8826 (back_to_previous_visible_line_start): If handle_display_prop
8827 pushed the iterator stack, restore the internal state of the bidi
8828 iterator by calling bidi_pop_it same number of times.
8829 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
8830 and we are bidi-iterating, don't decrement the iterator position;
8831 instead, set the first_elt flag in the bidi iterator, to produce
8832 the same effect.
8833 (reseat_1): Remove redundant setting of string_from_display_prop_p.
8834 (push_display_prop): xassert that we are iterating a buffer.
8835 (push_it, pop_it): Save and restore paragraph_embedding member.
8836 (handle_single_display_spec, next_overlay_string)
8837 (get_overlay_strings_1, reseat_1, reseat_to_string)
8838 (push_display_prop): Set up the `unibyte' member of bidi_it.string
8839 correctly. Don't assume unibyte strings are not bidi-reordered.
8840 (compute_display_string_pos)
8841 (compute_display_string_end): Fix handling the case of C string.
8842 (push_it, pop_it): Save and restore from_disp_prop_p.
8843 (handle_single_display_spec, push_display_prop): Set the
8844 from_disp_prop_p flag.
8845 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
8846 (pop_it): Call iterate_out_of_display_property only if we are
8847 popping after iteration over a string that came from a display
8848 property. Fix a typo in popping stretch info. Add an assertion
8849 for verifying that the iterator position is in sync with the bidi
8850 iterator.
8851 (handle_single_display_spec, get_overlay_strings_1)
8852 (push_display_prop): Fix initialization of paragraph direction for
8853 string when that of the parent object is not yet determined.
8854 (reseat_1): Call bidi_init_it to resync the bidi
8855 iterator with IT's position. (Bug#7616)
8856 (find_row_edges): If ROW->start.pos gives position
8857 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
8858 (handle_stop, back_to_previous_visible_line_start, reseat_1):
8859 Reset the from_disp_prop_p flag.
8860 (SAVE_IT, RESTORE_IT): New macros.
8861 (pos_visible_p, face_before_or_after_it_pos)
8862 (back_to_previous_visible_line_start)
8863 (move_it_in_display_line_to, move_it_in_display_line)
8864 (move_it_to, move_it_vertically_backward, move_it_by_lines)
8865 (try_scrolling, redisplay_window, display_line): Use them when
8866 saving a temporary copy of the iterator and restoring it back.
8867 (back_to_previous_visible_line_start, reseat_1)
8868 (init_iterator): Empty the bidi cache "stack".
8869 (move_it_in_display_line_to): If iterator ended up at
8870 EOL, but we never saw any buffer positions smaller than
8871 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
8872 motion in bidi-reordered lines.
8873 (move_it_in_display_line_to): Record prev_method and prev_pos
8874 immediately before the call to set_iterator_to_next. Fixes cursor
8875 motion in bidi-reordered lines with stretch glyphs and strings
8876 displayed in margins. (Bug#8133) (Bug#8867)
8877 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
8878 TO_CHARPOS.
640c8776
SM
8879 (pos_visible_p): Support positions in bidi-reordered lines.
8880 Save and restore bidi cache.
0bb23927
EZ
8881
8882 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
8883 (bidi_paragraph_info): Delete unused struct.
8884 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
8885 (bidi_cache_start): New variable.
8886 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
8887 to zero.
8888 (bidi_cache_fetch_state, bidi_cache_search)
8889 (bidi_cache_find_level_change, bidi_cache_iterator_state)
8890 (bidi_cache_find, bidi_peek_at_next_level)
8891 (bidi_level_of_next_char, bidi_find_other_level_edge)
8892 (bidi_move_to_visually_next): Compare cache index with
8893 bidi_cache_start rather than with zero.
8894 (bidi_fetch_char): Accept new argument STRING; all callers
8895 changed. Support iteration over a string. Support strings with
8896 display properties. Support unibyte strings. Fix the type of
8897 `len' according to what STRING_CHAR_AND_LENGTH expects.
8898 (bidi_paragraph_init, bidi_resolve_explicit_1)
8899 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
8900 (bidi_level_of_next_char, bidi_move_to_visually_next):
8901 Support iteration over a string.
0bb23927
EZ
8902 (bidi_set_sor_type, bidi_resolve_explicit_1)
8903 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
8904 can now be zero (for strings); special values 0 and -1 were
8905 changed to -1 and -2, respectively.
8906 (bidi_char_at_pos): New function.
8907 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
8908 Call it instead of FETCH_MULTIBYTE_CHAR.
8909 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
8910 initialized to valid values.
8911 (bidi_init_it): Don't initialize charpos and bytepos with invalid
8912 values.
8913 (bidi_level_of_next_char): Allow the sentinel "position" to pass
8914 the test for valid cached positions. Fix the logic for looking up
8915 the sentinel state in the cache. GCPRO the Lisp string we are
8916 iterating.
8917 (bidi_push_it, bidi_pop_it): New functions.
8918 (bidi_initialize): Initialize the bidi cache start stack pointer.
8919 (bidi_cache_ensure_space): New function, refactored from part of
8920 bidi_cache_iterator_state. Don't assume the required size is just
8921 one BIDI_CACHE_CHUNK away.
8922 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
8923 (bidi_count_bytes, bidi_char_at_pos): New functions.
8924 (bidi_cache_search): Don't assume bidi_cache_last_idx is
8925 always valid if bidi_cache_idx is valid.
8926 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
8927 is valid if it's going to be used.
8928 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
8929 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
8930 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8931 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
8932 (bidi_find_other_level_edge, bidi_cache_start_stack):
8933 All variables related to cache indices are now EMACS_INT.
c965adc5 8934
0bb23927
EZ
8935 * dispextern.h (struct bidi_string_data): New structure.
8936 (struct bidi_it): New member `string'. Make flag members be 1-bit
8937 fields, and put them last in the struct.
640c8776
SM
8938 (compute_display_string_pos, compute_display_string_end):
8939 Update prototypes.
0bb23927
EZ
8940 (bidi_push_it, bidi_pop_it): Add prototypes.
8941 (struct iterator_stack_entry): New members bidi_p,
8942 paragraph_embedding, and from_disp_prop_p.
8943 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
8944 (bidi_shelve_cache, bidi_unshelve_cache):
8945 Declare prototypes.
0bb23927
EZ
8946
8947 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
8948 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
8949 and vector-like objects.
8950
8951 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
8952 cache around display iteration.
8953
8954 * window.c (Fwindow_end, window_scroll_pixel_based)
8955 (displayed_window_lines, Frecenter): Save and restore the bidi
8956 cache around display iteration.
8957
3bbd2265
LMI
89582011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8959
8960 * editfns.c (Fdelete_region): Clarify the use of the named
8961 parameters (bug#6788).
8962
adc47434
MR
89632011-07-14 Martin Rudalics <rudalics@gmx.at>
8964
8965 * indent.c (Fvertical_motion): Set and restore w->pointm when
8966 saving and restoring the window's buffer (Bug#9006).
8967
837c31f8
LMI
89682011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
8969
8970 * editfns.c (Fstring_to_char): Clarify just what is returned
8971 (bug#6576). Text by Eli Zaretskii.
8972
ac389d0c
JB
89732011-07-13 Juanma Barranquero <lekktu@gmail.com>
8974
8975 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
8976
0be0ce47
EZ
89772011-07-13 Eli Zaretskii <eliz@gnu.org>
8978
8979 * buffer.c (mmap_find): Fix a typo.
8980
cd18e7e3
JB
89812011-07-13 Johan Bockgård <bojohan@gnu.org>
8982
8983 Fix execution of x selection hooks.
8984 * xselect.c (Qx_lost_selection_functions)
8985 (Qx_sent_selection_functions): New vars.
8986 (syms_of_xselect): DEFSYM them.
8987 (x_handle_selection_request): Pass Qx_sent_selection_functions
8988 rather than Vx_sent_selection_functions to Frun_hook_with_args.
8989 (x_handle_selection_clear,x_clear_frame_selections):
8990 Pass Qx_lost_selection_functions rather than
8991 Vx_lost_selection_functions to Frun_hook_with_args.
8992
47ea7f44
PE
89932011-07-13 Paul Eggert <eggert@cs.ucla.edu>
8994
ac389d0c 8995 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
8996 The old code sometimes used this field without initializing it.
8997
47ea7f44
PE
8998 * alloc.c (gc_sweep): Don't read past end of array.
8999 In theory, the old code could also have corrupted Emacs internals,
9000 though it'd be very unlikely.
9001
bc985c87
AS
90022011-07-12 Andreas Schwab <schwab@linux-m68k.org>
9003
9004 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 9005 argument. (Bug#4026)
bc985c87 9006
0cf34688
LMI
90072011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
9008
b3dadd76
LMI
9009 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
9010 key" (bug#4257).
9011
0cf34688
LMI
9012 * window.c (Fset_window_start): Doc fix (bug#4199).
9013 (Fset_window_hscroll): Ditto.
9014
270768cd
PE
90152011-07-12 Paul Eggert <eggert@cs.ucla.edu>
9016
077e3dda 9017 Fix minor new problems caught by GCC 4.6.1.
270768cd 9018 * term.c (init_tty): Remove unused local.
490011a6 9019 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 9020 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 9021 not used otherwise.
270768cd 9022
b1f58454
CY
90232011-07-12 Chong Yidong <cyd@stupidchicken.com>
9024
9025 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
9026
22b9578d
LMI
90272011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
9028
6e70ab07
LMI
9029 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
9030 are the mini-buffer and the echo area (bug#3320).
9031
22b9578d
LMI
9032 * term.c (init_tty): Remove support for supdup, c10 and perq
9033 terminals, which are no longer supported (bug#1482).
9034
8974cc9f
JB
90352011-07-10 Johan Bockgård <bojohan@gnu.org>
9036
9037 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
9038
a560d974
JD
90392011-07-10 Jan Djärv <jan.h.d@swipnet.se>
9040
9041 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
9042 for non-popups (Bug#3642).
9043
1dae0f0a
AS
90442011-07-10 Andreas Schwab <schwab@linux-m68k.org>
9045
268c2c36 9046 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 9047 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
9048 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
9049 * cm.c (losecursor): Likewise.
1dae0f0a
AS
9050 * data.c (fmod): Likewise.
9051 * dispnew.c (swap_glyphs_in_rows): Likewise.
9052 * emacs.c (memory_warning_signal): Likewise.
9053 * floatfns.c (float_error): Likewise.
9054 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
9055 (otf_open, font_otf_capability, generate_otf_features)
9056 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
9057 Likewise.
9058 * image.c (pbm_read_file): Likewise.
9059 * indent.c (string_display_width): Likewise.
9060 * intervals.c (check_for_interval, search_for_interval)
9061 (inc_interval_count, count_intervals, root_interval)
9062 (adjust_intervals_for_insertion, make_new_interval): Likewise.
9063 * lread.c (defalias): Likewise.
268c2c36 9064 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
9065 * regex.c (set_image_of_range_1, set_image_of_range)
9066 (regex_grow_registers): Likewise.
9067 * sysdep.c (strerror): Likewise.
9068 * termcap.c (valid_filename_p, tprint, main): Likewise.
9069 * tparam.c (main): Likewise.
9070 * unexhp9k800.c (run_time_remap, save_data_space)
9071 (update_file_ptrs, read_header, write_header, calculate_checksum)
9072 (copy_file, copy_rest, display_header): Likewise.
9073 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
9074 Likewise.
9075 * xdisp.c (check_it): Likewise.
9076 * xfaces.c (register_color, unregister_color, unregister_colors):
9077 Likewise.
9078 * xfns.c (print_fontset_result): Likewise.
9079 * xrdb.c (member, fatal, main): Likewise.
9080
99033785
PE
90812011-07-10 Paul Eggert <eggert@cs.ucla.edu>
9082
9083 Fix minor problems found by static checking (Bug#9031).
9084 * chartab.c (char_table_set_range, map_sub_char_table):
9085 Remove unused locals.
9086 (uniprop_table): Now static.
9087 * composite.c (_work_char): Remove unused static var.
9088
9cb2ac56
JB
90892011-07-09 Juanma Barranquero <lekktu@gmail.com>
9090
9091 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
9092
f25661f0
JD
90932011-07-09 Jan Djärv <jan.h.d@swipnet.se>
9094
9095 * gtkutil.c (qttip_cb): Remove code without function.
9096
8278c4fe
EZ
90972011-07-09 Eli Zaretskii <eliz@gnu.org>
9098
9099 * w32.c (pthread_sigmask): New stub.
9100
1692ae2d 91012011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 9102
8a6ebd58 9103 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
9104 sigprocmask is portable only for single-threaded applications, and
9105 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
9106 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
9107 (LIBES): Use it.
9108 * callproc.c (Fcall_process):
9109 * process.c (create_process):
9110 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
9111 Use pthread_sigmask, not sigprocmask.
123403e4 9112
1b854618
JD
91132011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9114
9115 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
9116 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
9117 wrong (Bug#8591).
9118
3fe4b549
JD
91192011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9120
0ce7e563
JD
9121 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
9122 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
9123 (xg_hide_tooltip): Fix comment.
9124
3fe4b549
JD
9125 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
9126 in registerServicesMenuSendTypes.
9127 (validRequestorForSendType): Don't check ns_return_types.
9128
9129 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
9130 ns_return_type.
9131
5df75e47
JR
91322011-07-08 Jason Rumney <jasonr@gnu.org>
9133
22610910
JR
9134 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
9135 SH_SHOW for hidden windows (Bug#5482).
9136
5df75e47
JR
9137 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
9138 frame struct members of non-existent frames (Bug#6284).
9139
699c10bd
JD
91402011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9141
4393663b
JD
9142 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
9143 variable firstTime not needed on OSX >= 10.6.
9144 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
9145 >= 10.5. Use setKnobProportion, setDoubleValue.
9146
9147 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
9148 (MAC_OS_X_VERSION_10_5): Define if not defined.
9149 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
9150 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
9151 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
9152
9153 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 9154 cString and lossyCString on OSX >= 10.4.
4393663b 9155
58179cce 9156 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
9157 sizeToFit on OSX >= 10.2.
9158
9159 * nsimage.m (allocInitFromFile): Don't use deprecated method
9160 bestRepresentationForDevice on OSX >= 10.6.
9161
9162 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
9163 to avoid warning.
9164
9165 * emacs.c: Declare unexec_init_emacs_zone.
9166
a63e0781
JD
9167 * nsgui.h: Fix compiler warning about gnulib redefining verify.
9168
699c10bd
JD
9169 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
9170
9171 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
9172 on svcsMenu (Bug#8842).
9173
9174 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
9175 ns_return_types.
9176 (Fns_list_services): Just return Qnil on 10.6, code not working there.
9177
9178 * nsterm.m (QUTF8_STRING): Declare.
9179 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
9180 (validRequestorForSendType): Return type is (id).
9181 Change indexOfObjectIdenticalTo to indexOfObject.
9182 Check if we have local selection before returning self (Bug#8842).
9183 (writeSelectionToPasteboard): Put local selection into paste board
9184 if we have a local selection (Bug#8842).
9185 (syms_of_nsterm): DEFSYM QUTF8_STRING.
9186
9187 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
9188 (ns_get_local_selection): Declare.
9189
54e10184
LMI
91902011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
9191
9888ff71
LMI
9192 * keymap.c (describe_map_tree): Don't insert a double newline at
9193 the end of the buffer (bug#1169) and return whether we inserted
9194 something.
9195
54e10184
LMI
9196 * callint.c (Fcall_interactively): Change "reading args" to
9197 "providing args" to try to clarify what it does (bug#1010).
9198
15fa4783
KH
91992011-07-07 Kenichi Handa <handa@m17n.org>
9200
9201 * composite.c (composition_compute_stop_pos): Ignore a static
9202 composition starting before CHARPOS (Bug#8915).
9203
9204 * xdisp.c (handle_composition_prop): Likewise.
9205
a8815b00
EZ
92062011-07-07 Eli Zaretskii <eliz@gnu.org>
9207
9208 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
9209 (Bug#9015)
9210
ef7b981d 92112011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
9212
9213 * character.h (unicode_category_t): New enum type.
9214
9215 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
9216 (Qchar_code_property_table): New variable.
9217 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
9218 (UNIPROP_COMPRESSED_FORM_P): New macros.
9219 (char_table_ascii): Uncompress the compressed values.
9220 (sub_char_table_ref): New arg is_uniprop. Callers changed.
9221 Uncompress the compressed values.
ac389d0c 9222 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
9223 (char_table_ref_and_range): Uncompress the compressed values.
9224 (sub_char_table_set): New arg is_uniprop. Callers changed.
9225 Uncompress the compressed values.
9226 (sub_char_table_set_range): Args changed. Callers changed.
9227 (char_table_set_range): Adjuted for the above change.
9228 (map_sub_char_table): Delete args default_val and parent. Add arg
9229 top. Give decoded values to a Lisp function.
640c8776 9230 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
9231 values to a Lisp function. Gcpro more variables.
9232 (uniprop_table_uncompress)
9233 (uniprop_decode_value_run_length): New functions.
9234 (uniprop_decoder, uniprop_decoder_count): New variables.
9235 (uniprop_get_decoder, uniprop_encode_value_character)
9236 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
9237 New functions.
9238 (uniprop_encoder, uniprop_encoder_count): New variables.
9239 (uniprop_get_encoder, uniprop_table)
9240 (Funicode_property_table_internal, Fget_unicode_property_internal)
9241 (Fput_unicode_property_internal): New functions.
9242 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
9243 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 9244 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
9245 char-code-property-alist.
9246
640c8776 9247 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
9248 Vunicode_category_table.
9249
640c8776 9250 * font.c (font_range): Adjust for the change of
c805dec0
KH
9251 Vunicode_category_table.
9252
76b397fb
DN
92532011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
9254
9255 * m/iris4d.h: Remove file, move contents ...
9256 * s/irix6-5.h: ... here.
9257
22b4128e
PE
92582011-07-06 Paul Eggert <eggert@cs.ucla.edu>
9259
9260 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
9261 * alloc.c (mark_buffer):
9262 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
9263 (clone_per_buffer_values): Don't assume that
22b4128e
PE
9264 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
9265 This isn't true in general, and it's particularly not true
9266 if Emacs is configured with --with-wide-int.
9267 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
9268 New macros, used in the buffer.c change.
9269
869795d6
JD
92702011-07-05 Jan Djärv <jan.h.d@swipnet.se>
9271
9272 * xsettings.c: Use both GConf and GSettings if both are available.
9273 (store_config_changed_event): Add comment.
9274 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
9275 (store_tool_bar_style_changed): New functions.
5e617bc2 9276 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
9277 (struct xsettings): Move font inside HAVE_XFT.
9278 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 9279 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 9280 Move inside HAVE_XFT.
640c8776 9281 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
9282 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
9283 also.
9284 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 9285 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 9286 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
9287 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
9288 (parse_settings): Move check for font inside HAVE_XFT.
9289 (read_settings, apply_xft_settings): Add comment.
9290 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
9291 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
9292 call store_font_name_changed.
9293 (xft_settings_event): Add comment.
9294 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
9295 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
9296 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
9297 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
9298 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
9299 (xsettings_get_system_font, xsettings_get_system_normal_font):
9300 Add comment.
869795d6 9301
d8ed26bd
PE
93022011-07-05 Paul Eggert <eggert@cs.ucla.edu>
9303
9304 Random fixes. E.g., (random) never returned negative values.
9305 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
9306 subseconds part to the entropy, as that's a bit more random.
9307 Prefer signed to unsigned, since the signedness doesn't matter and
9308 in general we prefer signed. When given a limit, use a
9309 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
9310 latter isn't right if USE_2_TAGS_FOR_INTS.
9311 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
9312 not 0..VALMASK. Don't discard "excess" bits that random () returns.
9313
cabf1cac
SM
93142011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
9315
9316 * textprop.c (text_property_stickiness):
9317 Obey Vtext_property_default_nonsticky.
9318 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
9319 * w32fns.c (syms_of_w32fns):
9320 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
9321
6e9b2be9
PE
93222011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9323
9324 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
9325 This is more efficient than Ffile_directory_p and avoids a minor race.
9326
90186c68
LMI
93272011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
9328
7c301272
LMI
9329 * buffer.c (Foverlay_put): Say what the return value is
9330 (bug#7835).
9331
c4f2d8d4
LMI
9332 * fileio.c (barf_or_query_if_file_exists): Check first if the file
9333 is a directory before asking whether to use the file name
9334 (bug#7564).
ad637907
LMI
9335 (barf_or_query_if_file_exists): Make the "File is a directory"
9336 error be more correct.
c4f2d8d4 9337
90186c68
LMI
9338 * fns.c (Frequire): Remove the mention of the .gz files, since
9339 that's installation-specific, but keep the mention of
9340 `get-load-suffixes'.
9341
da64016e
PE
93422011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9343
9344 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
9345 Report string overflow if the output is too long.
9346
7d47b580
JB
93472011-07-04 Juanma Barranquero <lekktu@gmail.com>
9348
a555cb87
JB
9349 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
9350 (syms_of_gnutls): Remove duplicate DEFSYM for
9351 Qgnutls_bootprop_verify_hostname_error, an error for
9352 Qgnutls_bootprop_verify_error (which is no longer used).
9353
7d47b580
JB
9354 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
9355 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
9356 Also (re)move comments that are misplaced or no longer relevant.
9357
1e49bfab
LMI
93582011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9359
9360 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
9361
1485f4c0
CY
93622011-07-03 Chong Yidong <cyd@stupidchicken.com>
9363
9364 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
9365 and background color parameters if they have been changed.
9366
a9ab721e
LMI
93672011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9368
9369 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
9370
cf7cff57
PE
93712011-07-03 Paul Eggert <eggert@cs.ucla.edu>
9372
2e13213d
PE
9373 * xsettings.c (SYSTEM_FONT): Define only when used.
9374 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
9375
cf7cff57
PE
9376 * keymap.c (access_keymap_1): Now static.
9377
7a8e04f7
CY
93782011-07-02 Chong Yidong <cyd@stupidchicken.com>
9379
9380 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
9381 leave any prefix arg for the up event (Bug#1586).
9382
61352f62
LMI
93832011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
9384
69bb1ef7
LMI
9385 * lread.c (syms_of_lread): Mention single symbols defined by
9386 `defvar' or `defconst' (bug#7154).
9387
61352f62 9388 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 9389 (Frequire): Mention get-load-suffixes.
61352f62 9390
28545e04
MR
93912011-07-02 Martin Rudalics <rudalics@gmx.at>
9392
9393 * window.h (window): Remove clone_number slot.
9394 * window.c (Fwindow_clone_number, Fset_window_clone_number):
9395 Remove.
9396 (make_parent_window, make_window, saved_window)
9397 (Fset_window_configuration, save_window_save): Don't deal with
9398 clone numbers.
9399 * buffer.c (Qclone_number): Remove declaration.
9400 (sort_overlays, overlay_strings): Don't deal with clone numbers.
9401
3349e122
SM
94022011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
9403
9404 Add multiple inheritance to keymaps.
9405 * keymap.c (Fmake_composed_keymap): New function.
9406 (Fset_keymap_parent): Simplify.
9407 (fix_submap_inheritance): Remove.
9408 (access_keymap_1): New function extracted from access_keymap to handle
9409 embedded parents and handle lists of maps.
9410 (access_keymap): Use it.
9411 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
9412 (Fcopy_keymap): Handle embedded parents.
9413 (Fcommand_remapping, define_as_prefix): Simplify.
9414 (Fkey_binding): Simplify.
9415 (syms_of_keymap): Move minibuffer-local-completion-map,
9416 minibuffer-local-filename-completion-map,
9417 minibuffer-local-must-match-map, and
9418 minibuffer-local-filename-must-match-map to Elisp.
9419 (syms_of_keymap): Defsubr make-composed-keymap.
9420 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
9421 (parse_menu_item): Trivial simplification.
9422
3279eb87
GM
94232011-07-01 Glenn Morris <rgm@gnu.org>
9424
9425 * Makefile.in (SETTINGS_LIBS): Fix typo.
9426
4550efdf
KI
94272011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
9428
9429 * coding.c (Fencode_coding_string): Record the last coding system
9430 used, as the function doc string says (bug#8738).
9431
0949d2b6
JD
94322011-07-01 Jan Djärv <jan.h.d@swipnet.se>
9433
9434 * xsettings.c (store_monospaced_changed): Take new font as arg and
9435 check for change against current_mono_font.
9436 (EMACS_TYPE_SETTINGS): Remove this and related defines.
9437 (emacs_settings_constructor, emacs_settings_get_property)
9438 (emacs_settings_set_property, emacs_settings_class_init)
9439 (emacs_settings_init, gsettings_obj): Remove.
9440 (something_changedCB): New function for HAVE_GSETTINGS.
9441 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
9442 with value as argument.
9443 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
9444 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 9445 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
9446 "changed".
9447
9448 * xgselect.c: Add defined (HAVE_GSETTINGS).
9449 (xgselect_initialize): Ditto.
9450
9451 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
9452 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
9453 xg_select.
9454
bbc6b304
PE
94552011-07-01 Paul Eggert <eggert@cs.ucla.edu>
9456
9457 * eval.c (struct backtrace): Simplify and port the data structure.
9458 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
9459 signed bit field, as this assumption is not portable and it makes
9460 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
9461 "char debug_on_exit : 1" as this is not portable either; instead,
9462 use the portable "unsigned int debug_on_exit : 1". Remove unused
9463 member evalargs. Remove obsolete comments about cc bombing out.
9464
9851bfc5
JD
94652011-06-30 Jan Djärv <jan.h.d@swipnet.se>
9466
51bb811f 9467 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
9468 Let HAVE_GSETTINGS override HAVE_GCONF.
9469 (store_monospaced_changed): New function.
9470 (EMACS_SETTINGS): A new type derived from GObject to handle
9471 GSettings notifications.
9472 (emacs_settings_constructor, emacs_settings_get_property)
9473 (emacs_settings_set_property, emacs_settings_class_init):
9474 New functions.
9475 (gsettings_client, gsettings_obj): New variables.
9476 (GSETTINGS_SCHEMA): New define.
9477 (something_changedCB): Call store_monospaced_changed.
9478 (init_gsettings): New function.
9479 (xsettings_initialize): Call init_gsettings.
9480 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
9481 to NULL.
9482
640c8776 9483 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
9484 GCONF_CFLAGS/LIBS.
9485
5386012d
MR
94862011-06-29 Martin Rudalics <rudalics@gmx.at>
9487
9488 * window.c (resize_root_window, grow_mini_window)
9489 (shrink_mini_window): Rename Qresize_root_window to
9490 Qwindow_resize_root_window and Qresize_root_window_vertically to
9491 Qwindow_resize_root_window_vertically.
9492
f13e0b08
PE
94932011-06-28 Paul Eggert <eggert@cs.ucla.edu>
9494
9495 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
9496
94515237
JB
94972011-06-27 Juanma Barranquero <lekktu@gmail.com>
9498
9499 * makefile.w32-in: Redesign dependencies so they reflect more
9500 clearly which files are directly included by each source file,
9501 and not through other includes.
9502
e43b6e43
MR
95032011-06-27 Martin Rudalics <rudalics@gmx.at>
9504
9505 * buffer.c (Qclone_number): Declare static and DEFSYM it.
9506 (sort_overlays, overlay_strings): When an overlay's clone number
9507 matches the window's clone number process the overlay even if
9508 the overlay's window property doesn't match the current window.
9509
d68443dc
MR
9510 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
9511 (Fwindow_hchild): Rename to Fwindow_left_child.
9512 (Fwindow_next): Rename to Fwindow_next_sibling.
9513 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
9514 (resize_window_check): Rename to window_resize_check.
9515 (resize_window_apply): Rename to window_resize_apply.
9516 (Fresize_window_apply): Rename to Fwindow_resize_apply.
9517 (Fdelete_other_windows_internal, resize_frame_windows)
9518 (Fsplit_window_internal, Fdelete_window_internal)
9519 (grow_mini_window, shrink_mini_window)
9520 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 9521
c7e73be5
JD
95222011-06-26 Jan Djärv <jan.h.d@swipnet.se>
9523
9524 * emacsgtkfixed.h: State that this is only used with Gtk+3.
9525 (emacs_fixed_set_min_size): Remove.
9526 (emacs_fixed_new): Take frame as argument.
9527
9528 * emacsgtkfixed.c: State that this is only used with Gtk+3.
9529 (_EmacsFixedPrivate): Remove minwidth/height.
9530 Add struct frame *f.
9531 (emacs_fixed_init): Initialize priv->f.
9532 (get_parent_class, emacs_fixed_set_min_size): Remove.
9533 (emacs_fixed_new): Set priv->f to argument.
9534 (emacs_fixed_get_preferred_width)
9535 (emacs_fixed_get_preferred_height): Use min_width/height from
9536 frames size_hint to set minimum and natural (Bug#8919).
9537 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
9538 and use min_width/height from frames size_hint to set
9539 min_width/height (Bug#8919).
9540
9541 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
9542 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
9543 Fix indentation.
c7e73be5 9544
cf99dcf8
EZ
95452011-06-26 Eli Zaretskii <eliz@gnu.org>
9546
9547 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
9548 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
9549 called at ZV.
9550
029529ac
CY
95512011-06-26 Chong Yidong <cyd@stupidchicken.com>
9552
9553 * process.c (wait_reading_process_output): Bypass select if
9554 waiting for a cell while ignoring keyboard input, and input is
9555 pending. Suggested by Jan Djärv (Bug#8869).
9556
7a7ef429
PE
95572011-06-25 Paul Eggert <eggert@cs.ucla.edu>
9558
9559 Use gnulib's dup2 module instead of rolling our own.
9560 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
9561
11fdef7d 95622011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
9563
9564 * dispnew.c (scrolling_window): Before scrolling, turn off a
9565 mouse-highlight in the window being scrolled.
9566
cd3520a4
JB
95672011-06-24 Juanma Barranquero <lekktu@gmail.com>
9568
9569 Move DEFSYM to lisp.h and use everywhere.
9570
9571 * character.h (DEFSYM): Move declaration...
9572 * lisp.h (DEFSYM): ...here.
9573
9574 * gnutls.c:
9575 * minibuf.c:
9576 * w32menu.c:
9577 * w32proc.c:
9578 * w32select.c: Don't include character.h.
9579
9580 * alloc.c (syms_of_alloc):
9581 * buffer.c (syms_of_buffer):
9582 * bytecode.c (syms_of_bytecode):
9583 * callint.c (syms_of_callint):
9584 * casefiddle.c (syms_of_casefiddle):
9585 * casetab.c (init_casetab_once):
9586 * category.c (init_category_once, syms_of_category):
9587 * ccl.c (syms_of_ccl):
9588 * cmds.c (syms_of_cmds):
9589 * composite.c (syms_of_composite):
9590 * dbusbind.c (syms_of_dbusbind):
9591 * dired.c (syms_of_dired):
9592 * dispnew.c (syms_of_display):
9593 * doc.c (syms_of_doc):
9594 * editfns.c (syms_of_editfns):
9595 * emacs.c (syms_of_emacs):
9596 * eval.c (syms_of_eval):
9597 * fileio.c (syms_of_fileio):
9598 * fns.c (syms_of_fns):
9599 * frame.c (syms_of_frame):
9600 * fringe.c (syms_of_fringe):
9601 * insdel.c (syms_of_insdel):
9602 * keymap.c (syms_of_keymap):
9603 * lread.c (init_obarray, syms_of_lread):
9604 * macros.c (syms_of_macros):
9605 * msdos.c (syms_of_msdos):
9606 * print.c (syms_of_print):
9607 * process.c (syms_of_process):
9608 * search.c (syms_of_search):
9609 * sound.c (syms_of_sound):
9610 * syntax.c (init_syntax_once, syms_of_syntax):
9611 * terminal.c (syms_of_terminal):
9612 * textprop.c (syms_of_textprop):
9613 * undo.c (syms_of_undo):
9614 * w32.c (globals_of_w32):
9615 * window.c (syms_of_window):
9616 * xdisp.c (syms_of_xdisp):
9617 * xfaces.c (syms_of_xfaces):
9618 * xfns.c (syms_of_xfns):
9619 * xmenu.c (syms_of_xmenu):
9620 * xsettings.c (syms_of_xsettings):
9621 * xterm.c (syms_of_xterm): Use DEFSYM.
9622
4228cf16
TZ
96232011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
9624
cd3520a4 9625 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 9626
7fcccf1e
PE
96272011-06-23 Paul Eggert <eggert@cs.ucla.edu>
9628
7efb4e0e
PE
9629 Integer and buffer overflow fixes (Bug#8873).
9630
ff5844ad
PE
9631 * print.c (printchar, strout): Check for string overflow.
9632 (PRINTPREPARE, printchar, strout):
9633 Don't set size unless allocation succeeds.
9634
90532f02
PE
9635 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
9636 for sizes. Check for string overflow more accurately.
9637 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
9638
6d84508d
PE
9639 * macros.c: Integer and buffer overflow fixes.
9640 * keyboard.h (struct keyboard.kbd_macro_bufsize):
9641 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
9642 Use ptrdiff_t, not int, for sizes.
9643 Don't increment bufsize until after realloc succeeds.
9644 Check for size-calculation overflow.
9645 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
9646
437b2cb4
PE
9647 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
9648
8b9ac8b4
PE
9649 * lread.c: Integer overflow fixes.
9650 (read_integer): Radix is now EMACS_INT, not int,
9651 to improve quality of diagnostics for out-of-range radices.
9652 Calculate buffer size correctly for out-of-range radices.
9653 (read1): Check for integer overflow in radices, and in
9654 read-circle numbers.
82cb60d3
PE
9655 (read_escape): Avoid int overflow.
9656 (Fload, openp, read_buffer_size, read1)
9657 (substitute_object_recurse, read_vector, read_list, map_obarray):
9658 Use ptrdiff_t, not int, for sizes.
9659 (read1): Use EMACS_INT, not int, for sizes.
20270765 9660 Check for size overflow.
8b9ac8b4 9661
7fcccf1e
PE
9662 * image.c (cache_image): Check for size arithmetic overflow.
9663
bfbbd7e7
PE
9664 * lread.c: Integer overflow issues.
9665 (saved_doc_string_size, saved_doc_string_length)
9666 (prev_saved_doc_string_size, prev_saved_doc_string_length):
9667 Now ptrdiff_t, not int.
9668 (read1): Don't assume doc string length fits in int. Check for
9669 out-of-range doc string lengths.
9670 (read_list): Don't assume file position fits in int.
39019e54 9671 (read_escape): Check for hex character overflow.
bfbbd7e7 9672
4e323265
LL
96732011-06-22 Leo Liu <sdl.web@gmail.com>
9674
9675 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
9676 Move to minibuffer.el.
9677
85fece3e
PE
96782011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9679
20b84ce9 9680 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
9681 The following patches are for when GLYPH_DEBUG && !XASSERT.
9682 * dispextern.h (trace_redisplay_p, dump_glyph_string):
9683 * dispnew.c (flush_stdout):
9684 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
9685 Mark as externally visible.
9686 * dispnew.c (check_window_matrix_pointers): Now static.
9687 * dispnew.c (window_to_frame_vpos):
9688 * xfns.c (unwind_create_frame):
9689 * xterm.c (x_check_font): Remove unused local.
9690 * scroll.c (CHECK_BOUNDS):
9691 * xfaces.c (cache_fache): Rename local to avoid shadowing.
9692 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
9693 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
9694 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
9695 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
9696 Now static.
9697 (debug_method_add): Use va_list and vsprintf rather than relying
9698 on undefined behavior with wrong number of arguments.
9699 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
9700 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
9701 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
9702 since we're not interested in debugging glyphs with old libraries.
9703 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
9704 GCC 4.6.0's static checking.
9705
0766b489
PE
97062011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9707
31fd4b32
PE
9708 Integer overflow and signedness fixes (Bug#8873).
9709 A few related buffer overrun fixes, too.
9710
b79e8648
PE
9711 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
9712
0766b489
PE
9713 * dispextern.h (struct face.stipple):
9714 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
9715 (x_bitmap_mask, x_allocate_bitmap_record)
9716 (x_create_bitmap_from_data, x_create_bitmap_from_file)
9717 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
9718 (x_create_bitmap_from_xpm_data):
9719 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
9720 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
9721 (.bitmaps_last):
9722 * xfaces.c (load_pixmap):
9723 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
9724 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
9725 (.bitmaps_last, struct x_output.icon_bitmap):
9726 Use ptrdiff_t, not int, for bitmap indexes.
9727 (x_allocate_bitmap_record): Check for size overflow.
9728 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
9729
b081724f
PE
9730 Use ptrdiff_t, not int, for overlay counts.
9731 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
9732 * editfns.c (overlays_around, get_pos_property):
9733 * textprop.c (get_char_property_and_overlay):
9734 * xdisp.c (next_overlay_change, note_mouse_highlight):
9735 * xfaces.c (face_at_buffer_position):
21514da7
PE
9736 * buffer.c (OVERLAY_COUNT_MAX): New macro.
9737 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
9738 (Fnext_overlay_change, Fprevious_overlay_change)
9739 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 9740 Use ptrdiff_t, not int, for sizes.
21514da7 9741 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 9742
3de73e5e
PE
9743 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
9744
2606c57b
PE
9745 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
9746 (x_session_initialize): Do not assume string length fits in int.
9747
aaafe47a
PE
9748 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
9749 This is unlikely, but can occur if DPI is outlandish.
9750
2674ddc8 9751 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
9752 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
9753
28154962
PE
9754 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
9755 * xrdb.c (magic_file_p, search_magic_path):
9756 Omit last arg SUFFIX; it was always 0. All callers changed.
9757 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
9758
7de51af5
PE
9759 * xfont.c (xfont_match): Avoid need for strlen.
9760
25ed6cc3
PE
9761 * xfns.c: Don't assume strlen fits in int.
9762 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
9763
4eab31dd
PE
9764 * xdisp.c (message_log_check_duplicate): Return intmax_t,
9765 not unsigned long, as we prefer signed integers. All callers changed.
9766 Detect integer overflow in repeat count.
9767 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 9768 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 9769
171e2a58
PE
9770 * termcap.c: Don't assume sizes fit in int and never overflow.
9771 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
9772 (gobble_line): Check for size-calculation overflow.
9773
ad39faca 9774 * minibuf.c (Fread_buffer):
6e5bb2dc 9775 * lread.c (intern, intern_c_string):
74ca2eb3
PE
9776 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
9777 Don't assume string length fits in int.
9778
52c61c22 9779 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
9780 * gtkutil.c (style_changed_cb): Avoid need for strlen.
9781
b5b8c9e5
PE
9782 * font.c: Don't assume string length fits in int.
9783 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
9784 Use ptrdiff_t, not int.
ccd6111c
PE
9785 (font_intern_prop): Don't assume string length fits in int.
9786 Don't assume integer property fits in fixnum.
9787 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 9788
882f0d81 9789 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 9790 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
9791 Reformulate so as not to need the command string.
9792 Invoke gzip -cd rather than gunzip, as it's more portable.
9793 (lock_info_type, lock_file_1, lock_file):
9794 Don't assume pid_t and time_t fit in unsigned long.
9795 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
9796 (current_lock_owner): Prefer signed type for sizes.
9797 Use memcpy, not strncpy, where memcpy is what is really wanted.
9798 Don't assume (via atoi) that time_t and pid_t fit in int.
9799 Check for time_t and/or pid_t out of range, e.g., via a network share.
9800 Don't alloca where an auto var works fine.
9801
93f4cf88
PE
9802 * fileio.c: Fix some integer overflow issues.
9803 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
9804 Don't assume string length fits in int.
9805 (directory_file_name): Don't assume string length fits in long.
9806 (make_temp_name): Don't assume pid fits in int, or that its print
9807 length is less than 20.
9808
f3e92b69
PE
9809 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
9810
1bfdaf10
PE
9811 * coding.c (make_subsidiaries): Don't assume string length fits in int.
9812
35016e9a
PE
9813 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
9814
3d1e65a1
PE
9815 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
9816 We prefer signed integers, even for size calculations.
9817
0b963a93
PE
9818 * emacs.c: Don't assume string length fits in 'int'.
9819 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
9820 (main): Don't invoke strlen when not needed.
9821
573f4b54
PE
9822 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
9823 (XD_DEBUG_MESSAGE): Don't waste a byte.
9824
989f33ba
PE
9825 * callproc.c (getenv_internal_1, getenv_internal)
9826 (Fgetenv_internal):
965d34eb
PE
9827 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
9828
e4d29b33
PE
9829 * lread.c (invalid_syntax): Omit length argument.
9830 All uses changed. This doesn't fix a bug, but it simplifies the
9831 code away from its former Hollerith-constant appearance, and it's
9832 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 9833 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 9834
eb49b136
PE
9835 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
9836 This didn't break anything, but it didn't help either.
9837 It's confusing to put a bogus integer in a place where the actual
9838 value does not matter.
9f62aeb1 9839 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 9840 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 9841
15375a22
PE
9842 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
9843 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
9844 implementation.
b61cc01c
PE
9845 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
9846 We prefer signed types, and the value cannot exceed the EMACS_INT
9847 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
9848 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
9849 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
9850 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 9851
53b2623d
PE
9852 * indent.c (sane_tab_width): New function.
9853 (current_column, scan_for_column, Findent_to, position_indentation)
9854 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 9855 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 9856
51cab52b 9857 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 9858
f2ed8a70
PE
9859 * lisp.h (lint_assume): New macro.
9860 * composite.c (composition_gstring_put_cache):
9861 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
9862
abe80cc6
PE
9863 * editfns.c, insdel.c:
9864 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 9865
b02c740e
PE
9866 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
9867
ebc96716
PE
9868 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
9869
b4e50fa0 9870 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 9871 Use much-faster test for byte-length change.
311d5d7c 9872 Don't assume string byte-length fits in 'int'.
a4cf38e4 9873 Check that character arg fits in 'int'.
85461888 9874 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 9875
c0c1ee9f
PE
9876 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
9877
a498d7f4
PE
9878 * fns.c (concat): Catch string overflow earlier.
9879 Do not rely on integer wraparound.
9880
51cab52b
PE
9881 * dispextern.h (struct it.overlay_strings_charpos)
9882 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
9883 * xdisp.c (forward_to_next_line_start)
9884 (back_to_previous_visible_line_start)
9885 (reseat_at_next_visible_line_start, next_element_from_buffer):
9886 Don't arbitrarily truncate the value of 'selective' to int.
9887
76031fad
PE
9888 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
9889
5eb55db9
PE
9890 * composite.c: Don't truncate sizes to 'int'.
9891 (composition_gstring_p, composition_reseat_it)
9892 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
9893 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
9894 not EMACS_UINT, for indexes.
5eb55db9 9895
0703a717
PE
9896 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
9897
d6202519
PE
9898 * buffer.c: Include <verify.h>.
9899 (struct sortvec.priority, struct sortstr.priority):
8961a454 9900 Now EMACS_INT, not int.
c20998a7 9901 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
9902 (struct sortstr.size, record_overlay_string)
9903 (struct sortstrlist.size, struct sortlist.used):
9904 Don't truncate size to int.
9905 (record_overlay_string): Check for size-calculation overflow.
d6202519 9906 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 9907
d5a19415
JM
99082011-06-22 Jim Meyering <meyering@redhat.com>
9909
029529ac 9910 Don't leak an XBM-image-sized buffer
d5a19415
JM
9911 * image.c (xbm_load): Free the image buffer after using it.
9912
a9041e6c
PE
99132011-06-21 Paul Eggert <eggert@cs.ucla.edu>
9914
9915 Port to Sun C.
9916 * composite.c (find_automatic_composition): Omit needless 'return 0;'
9917 that Sun C diagnosed.
9918 * fns.c (secure_hash): Fix pointer signedness issue.
9919 * intervals.c (static_offset_intervals): New function.
9920 (offset_intervals): Use it.
9921
7f3f739f
LL
99222011-06-21 Leo Liu <sdl.web@gmail.com>
9923
9924 * deps.mk (fns.o):
9925 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
9926 sha512.h.
9927
9928 * fns.c (secure_hash): Rename from crypto_hash_function and change
9929 the first arg to accept symbols.
5b66d427 9930 (Fsecure_hash): New primitive.
7f3f739f
LL
9931 (syms_of_fns): New symbols.
9932
76147d94
DD
99332011-06-20 Deniz Dogan <deniz@dogan.se>
9934
9935 * process.c (Fset_process_buffer): Clarify return value in
9936 docstring.
9937
7d7d0045
CY
99382011-06-18 Chong Yidong <cyd@stupidchicken.com>
9939
9940 * dispnew.c (add_window_display_history): Use BVAR.
9941
9942 * xdisp.c (debug_method_add): Use BVAR.
9943 (check_window_end, dump_glyph_matrix, dump_glyph)
9944 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
9945
9946 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
9947 Likewise.
9948
9949 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
9950 check till after the cache is created in init_frame_faces.
9951
ff2bc410
SM
99522011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
9953
9954 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
9955
28177add
PE
99562011-06-16 Paul Eggert <eggert@cs.ucla.edu>
9957
dd3482fe
PE
9958 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
9959 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
9960 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
9961
393d71f3 9962 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
9963 * fileio.c (Finsert_file_contents):
9964 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
9965 Remove the old (too-loose) buffer overflow checks.
9966 They weren't needed, since make_gap checks for buffer overflow.
9967 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
9968 The old code merely checked for Emacs fixnum overflow, and relied
9969 on undefined (wraparound) behavior. The new code avoids undefined
9970 behavior, and also checks for ptrdiff_t and/or size_t overflow.
9971
2e6813b0 9972 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
9973 Tune. Don't use wider integers than needed. Don't use alloca.
9974 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 9975
599a9e4f
PE
9976 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
9977
99561444
PE
9978 * insdel.c, lisp.h (buffer_overflow): New function.
9979 (insert_from_buffer_1, replace_range, replace_range_2):
9980 * insdel.c (make_gap_larger):
9981 * editfns.c (Finsert_char):
9982 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
9983
28177add
PE
9984 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
9985
e69dafad
PE
99862011-06-15 Paul Eggert <eggert@cs.ucla.edu>
9987
4baa020d 9988 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 9989
b1c46f02
PE
9990 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
9991 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
9992
e69dafad
PE
9993 * fileio.c: Don't assume EMACS_INT fits in off_t.
9994 (emacs_lseek): New static function.
9995 (Finsert_file_contents, Fwrite_region): Use it.
9996 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
9997
566684ea
PE
9998 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
9999
e6966cd6
PE
10000 * fns.c: Don't overflow int when computing a list length.
10001 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
10002 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
10003 truncation on 64-bit hosts. Check for QUIT every
10004 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
10005 faster and is responsive enough.
10006 (Flength): Report an error instead of overflowing an integer.
10007 (Fsafe_length): Return a float if the value is not representable
10008 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 10009 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 10010 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 10011
dd0b0efb
PE
10012 * alloc.c: Check that resized vectors' lengths fit in fixnums.
10013 (header_size, word_size): New constants.
10014 (allocate_vectorlike): Don't check size overflow here.
10015 (allocate_vector): Check it here instead, since this is the only
10016 caller of allocate_vectorlike that could cause overflow.
10017 Check that the new vector's length is representable as a fixnum.
10018
86fe5cfe
PE
10019 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
10020 The previous code was bogus. For example, next_almost_prime (32)
10021 returned 39, which is undesirable as it is a multiple of 3; and
10022 next_almost_prime (24) returned 25, which is a multiple of 5 so
10023 why was the code bothering to check for multiples of 7?
10024
80e88859
PE
10025 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
10026
4a2f0ad6
PE
10027 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
10028
f66c7cf8
PE
10029 Variadic C functions now count arguments with ptrdiff_t.
10030 This partly undoes my 2011-03-30 change, which replaced int with size_t.
10031 Back then I didn't know that the Emacs coding style prefers signed int.
10032 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
10033 were being counted with int, which may truncate counts on 64-bit
10034 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
10035 * lisp.h (struct Lisp_Subr.function.aMANY)
10036 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
10037 Arg counts are now ptrdiff_t, not size_t.
10038 All variadic functions and their callers changed accordingly.
10039 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
10040 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
10041 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
10042 * callint.c (Fcall_interactively): Check arg count for overflow,
10043 to avoid potential buffer overrun. Use signed char, not 'int',
10044 for 'varies' array, so that we needn't bother to check its size
10045 calculation for overflow.
10046 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
10047 * eval.c (apply_lambda):
10048 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
10049 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
10050 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
10051
a1759b76
PE
10052 * callint.c (Fcall_interactively): Don't use index var as event count.
10053
d96be9fc
PE
10054 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
10055 * mem-limits.h (SIZE): Remove; no longer used.
10056
a690a978 10057 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 10058
578c21e6
PE
10059 Remove unnecessary casts.
10060 * xterm.c (x_term_init):
10061 * xfns.c (x_set_border_pixel):
10062 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
10063 These aren't needed now that we assume ANSI C.
10064
96f53c6c
PE
10065 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
10066 It's more likely to cause problems (due to unsigned overflow)
10067 than to cure them.
10068
83c77d31
PE
10069 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
10070
ee2079f1
PE
10071 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
10072
6da65536
PE
10073 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
10074
7147c4a4
PE
10075 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
10076
193e32d9
PE
10077 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
10078
e5533da6
PE
10079 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
10080
9910e595
PE
10081 GLYPH_CODE_FACE returns EMACS_INT, not int.
10082 * dispextern.h (merge_faces):
10083 * xfaces.c (merge_faces):
01103c44
PE
10084 * xdisp.c (get_next_display_element, next_element_from_display_vector):
10085 Don't assume EMACS_INT fits in int.
9910e595 10086
2638320e
PE
10087 * character.h (CHAR_VALID_P): Remove unused parameter.
10088 * fontset.c, lisp.h, xdisp.c: All uses changed.
10089
045eb8d9
PE
10090 * editfns.c (Ftranslate_region_internal): Omit redundant test.
10091
c1f134b5
PE
10092 * fns.c (concat): Minor tuning based on overflow analysis.
10093 This doesn't fix any bugs. Use int to hold character, instead
10094 of constantly refetching from Emacs object. Use XFASTINT, not
10095 XINT, for value known to be a character. Don't bother comparing
10096 a single byte to 0400, as it's always less.
10097
395fcb93 10098 * floatfns.c (Fexpt):
327eeec8
PE
10099 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
10100
abbd3d23
PE
10101 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
10102 for characters.
10103
684a03ef
PE
10104 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
10105
0fed43f3
PE
10106 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
10107 Without this fix, on a 64-bit host (aset S 0 4294967386) would
10108 incorrectly succeed when S was a string, because 4294967386 was
10109 truncated before it was used.
10110
8fd02eb7
PE
10111 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
10112 Otherwise, an out-of-range integer could cause undefined behavior
10113 on a 64-bit host.
10114
f8c86b69
PE
10115 * composite.c: Use int, not EMACS_INT, for characters.
10116 (fill_gstring_body, composition_compute_stop_pos): Use int, not
10117 EMACS_INT, for values that are known to be in character range.
10118 This doesn't fix any bugs but is the usual style inside Emacs and
10119 may generate better code on 32-bit machines.
10120
34206dd2
PE
10121 Make sure a 64-bit char is never passed to ENCODE_CHAR.
10122 This is for reasons similar to the recent CHAR_STRING fix.
10123 * charset.c (Fencode_char): Check that character arg is actually
10124 a character. Pass an int to ENCODE_CHAR.
10125 * charset.h (ENCODE_CHAR): Verify that the character argument is no
10126 wider than 'int', as a compile-time check to prevent future regressions
10127 in this area.
10128
c5958d4c 10129 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
10130
10131 Make sure a 64-bit char is never passed to CHAR_STRING.
10132 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
10133 by silently ignoring the top 32 bits, allowing some values
10134 that were far too large to be valid characters.
10135 * character.h: Include <verify.h>.
10136 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
10137 arguments are no wider than unsigned, as a compile-time check
10138 to prevent future regressions in this area.
10139 * data.c (Faset):
01103c44 10140 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
10141 (Fsubst_char_in_region):
10142 * fns.c (concat):
10143 * xdisp.c (decode_mode_spec_coding):
10144 Adjust to CHAR_STRING's new requirement.
10145 * editfns.c (Finsert_char, Fsubst_char_in_region):
10146 * fns.c (concat): Check that character args are actually
10147 characters. Without this test, these functions did the wrong
10148 thing with wildly out-of-range values on 64-bit hosts.
10149
d37ca623
PE
10150 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
10151 These casts should not be needed on 32-bit hosts, either.
10152 * keyboard.c (read_char):
10153 * lread.c (Fload): Remove casts to unsigned.
10154
ea204efb
PE
10155 * lisp.h (UNSIGNED_CMP): New macro.
10156 This fixes comparison bugs on 64-bit hosts.
10157 (ASCII_CHAR_P): Use it.
10158 * casefiddle.c (casify_object):
01103c44 10159 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
10160 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
10161 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
10162 * dispextern.h (FACE_FROM_ID):
10163 * keyboard.c (read_char): Use UNSIGNED_CMP.
10164
41cb286c
PE
10165 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
10166 not to EMACS_INT, to avoid GCC warning.
10167
4a1b9832
PE
10168 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
10169
55daad71
PE
10170 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
10171 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
10172 isn't needed on 32-bit machines.
8f95c75c 10173
01103c44
PE
10174 * buffer.c (Fgenerate_new_buffer_name):
10175 Use EMACS_INT for count, not int.
0ceccced 10176 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
10177
10178 * data.c (Qcompiled_function): Now static.
10179
c6f072e7
PE
10180 * window.c (window_body_lines): Now static.
10181
20ce5912
PE
10182 * image.c (gif_load): Rename local to avoid shadowing.
10183
9c4c5f81
PE
10184 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
10185 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
10186 * alloc.c (make_save_value): Integer argument is now of type
10187 ptrdiff_t, not int.
10188 (mark_object): Use ptrdiff_t, not int.
10189 * lisp.h (pD): New macro.
10190 * print.c (print_object): Use it.
10191
c0c5c8ae
PE
10192 * alloc.c: Use EMACS_INT, not int, to count objects.
10193 (total_conses, total_markers, total_symbols, total_vector_size)
10194 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
10195 (total_free_floats, total_floats, total_free_intervals)
10196 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
10197 Now EMACS_INT, not int. All uses changed.
10198 (Fgarbage_collect): Compute overall total using a double, so that
10199 integer overflow is less likely to be a problem. Check for overflow
10200 when converting back to an integer.
5a25e253
PE
10201 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
10202 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
10203 These were 'int' variables that could overflow on 64-bit hosts;
10204 they were never used, so remove them instead of repairing them.
211a0b2a 10205 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
10206 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
10207 Previously, this ceilinged at INT_MAX, but that doesn't work on
10208 64-bit machines.
e46bb31a 10209 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 10210
c78baabf 10211 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 10212 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
10213 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
10214 when a (possibly-narrower) signed value would do just as well.
10215 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 10216
c9d624c6
PE
10217 * alloc.c: Catch some string size overflows that we were missing.
10218 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
10219 for convenience in STRING_BYTES_MAX.
10220 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
10221 The definition here is exact; the one in lisp.h was approximate.
10222 (allocate_string_data): Check for string overflow. This catches
10223 some instances we weren't catching before. Also, it catches
10224 size_t overflow on (unusual) hosts where SIZE_MAX <= min
10225 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
10226 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 10227
c9d624c6
PE
10228 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
10229 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 10230 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 10231
353032ce
PE
10232 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
10233
2bccce07
PE
10234 * alloc.c (Fmake_string): Check for out-of-range init.
10235
0ac30604
SM
102362011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
10237
10238 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
10239
c195f2de
JD
102402011-06-14 Jan Djärv <jan.h.d@swipnet.se>
10241
10242 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
10243 xg_get_default_scrollbar_width.
10244
10245 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
10246 (int_gtk_range_get_value): Move to the scroll bar part of the file.
10247 (style_changed_cb): Call update_theme_scrollbar_width and call
10248 x_set_scroll_bar_default_width and xg_frame_set_char_size for
10249 all frames (Bug#8505).
10250 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
10251 Call gtk_window_set_resizable if HAVE_GTK3.
10252 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
10253 and height if HAVE_GTK3 (Bug#8505).
10254 (scroll_bar_width_for_theme): New variable.
10255 (update_theme_scrollbar_width): New function.
10256 (xg_get_default_scrollbar_width): Move code to
10257 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
10258 (xg_initialize): Call update_theme_scrollbar_width.
10259
10260 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
10261
10262 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
10263
e10ac9f1
MR
102642011-06-12 Martin Rudalics <rudalics@gmx.at>
10265
10266 * frame.c (make_frame): Call other_buffer_safely instead of
10267 other_buffer.
10268
10269 * window.c (temp_output_buffer_show): Call display_buffer with
10270 second argument Vtemp_buffer_show_specifiers and reset latter
10271 immediately after the call.
10272 (Vtemp_buffer_show_specifiers): New variable.
10273 (auto_window_vscroll_p, next_screen_context_lines)
10274 (Vscroll_preserve_screen_position): Remove leading asterisks from
10275 doc-strings.
10276
2d3c217e 102772011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 10278
7b7f97e8 10279 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
10280 * buffer.c (Qclone_number): Remove for now, as it's unused.
10281 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
10282 (record_buffer): Remove unused local.
10283 * frame.c (other_visible_frames, frame_buffer_list): Now static.
10284 (set_frame_buffer_list): Remove; unused.
10285 * frame.h (other_visible_frames): Remove decl.
10286 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
10287 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
10288 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
10289 if HAVE_GPM.
10290 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
10291 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
10292 Define only if HAVE_GPM.
10293 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
10294 (update_hints_inhibit): Remove; never set. All uses removed.
10295 * widgetprv.h (emacsFrameClassRec): Remove decl.
10296 * window.c (delete_deletable_window): Now returns void, since it
10297 wasn't returning anything.
10298 (compare_window_configurations): Remove unused locals.
10299 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
10300 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
10301 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
10302 the same widths as pointers. This follows up on the 2011-05-06 patch.
10303 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
10304 * xterm.h: Likewise.
10305 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
10306
1384b89e
JB
103072011-06-12 Juanma Barranquero <lekktu@gmail.com>
10308
10309 * makefile.w32-in: Update dependencies.
10310 (LISP_H): Add lib/intprops.h.
10311
1100a63c
CY
103122011-06-11 Chong Yidong <cyd@stupidchicken.com>
10313
10314 * image.c (gif_load): Add animation frame delay to the metadata.
10315 (syms_of_image): Use DEFSYM. New symbol `delay'.
10316
6198ccd0
MR
103172011-06-11 Martin Rudalics <rudalics@gmx.at>
10318
10319 * window.c (delete_deletable_window): Re-add.
10320 (Fset_window_configuration): Rewrite to handle dead buffers and
10321 consequently deletable windows.
10322 (window_tree, Fwindow_tree): Remove. Supply functionality in
10323 window.el.
10324 (compare_window_configurations): Simplify code.
10325
b6e3633c
AS
103262011-06-11 Andreas Schwab <schwab@linux-m68k.org>
10327
1ab0dee5
AS
10328 * image.c (imagemagick_load_image): Fix type mismatch.
10329 (Fimagemagick_types): Likewise.
10330
b6e3633c
AS
10331 * window.h (replace_buffer_in_windows): Declare.
10332
9397e56f
MR
103332011-06-11 Martin Rudalics <rudalics@gmx.at>
10334
10335 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
10336 Qclone_number. Remove external declaration of Qdelete_window.
10337 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
10338 code.
640c8776
SM
10339 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
10340 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
10341 (Fother_buffer): Rewrite doc-string. Major rewrite for new
10342 buffer list implementation.
10343 (other_buffer_safely): New function.
10344 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
10345 calls to replace_buffer_in_windows and
10346 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
10347 if allowed.
10348 (record_buffer): Inhibit quitting and rewrite using quittable
10349 functions. Run Qbuffer_list_update_hook if allowed.
10350 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
10351 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
10352 Move switch-to-buffer to window.el.
9397e56f
MR
10353 (bury-buffer): Move to window.el.
10354 (Vbuffer_list_update_hook): New variable.
10355
10356 * lisp.h (other_buffer_safely): Add prototype in buffer.c
10357 section.
10358
10359 * window.h (resize_frame_windows): Move up in code.
10360 (Fwindow_frame): Remove EXFUN.
10361 (replace_buffer_in_all_windows): Remove prototype.
10362 (replace_buffer_in_windows_safely): Add prototype.
10363
10364 * window.c: Declare Qdelete_window static again. Move down
10365 declaration of select_count.
10366 (Fnext_window, Fprevious_window): Rewrite doc-strings.
10367 (Fother_window): Move to window.el.
10368 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
10369 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
10370 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
10371 window.el.
10372 (replace_buffer_in_windows): Implement by calling
10373 Qreplace_buffer_in_windows.
10374 (replace_buffer_in_all_windows): Remove with some functionality
10375 moved into replace_buffer_in_windows_safely.
10376 (replace_buffer_in_windows_safely): New function.
10377 (select_window_norecord, select_frame_norecord): Move in front
10378 of run_window_configuration_change_hook. Remove now obsolete
10379 declarations.
640c8776
SM
10380 (Fset_window_buffer): Rewrite doc-string.
10381 Call Qrecord_window_buffer.
9397e56f
MR
10382 (keys_of_window): Move binding for other-window to window.el.
10383
b50691aa
CY
103842011-06-11 Chong Yidong <cyd@stupidchicken.com>
10385
10386 * dispextern.h (struct image): Replace data member, whose int_val
10387 and ptr_val fields were not used by anything, with a single
10388 lisp_val object.
10389
10390 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
10391 (gif_clear_image, gif_load, imagemagick_load_image)
10392 (gs_clear_image, gs_load): Callers changed.
10393
3f754b86
PE
103942011-06-10 Paul Eggert <eggert@cs.ucla.edu>
10395
cca69397
PE
10396 * buffer.h: Include <time.h>, for time_t.
10397 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
10398
109e28d0
PE
10399 Fix minor problems found by static checking.
10400
60737f02
PE
10401 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
10402
4b66faf3
PE
10403 Make identifiers static if they are not used in other modules.
10404 * data.c (Qcompiled_function, Qframe, Qvector):
10405 * image.c (QimageMagick, Qsvg):
10406 * minibuf.c (Qmetadata):
10407 * window.c (resize_window_check, resize_root_window): Now static.
10408 * window.h (resize_window_check, resize_root_window): Remove decls.
10409
109e28d0
PE
10410 * window.c (window_deletion_count, delete_deletable_window):
10411 Remove; unused.
46a4ce9e
PE
10412 (window_body_lines): Now static.
10413 (Fdelete_other_windows_internal): Mark vars as initialized.
10414 Make sure 'resize_failed' is initialized.
10415 (run_window_configuration_change_hook): Rename local to avoid shadowing.
10416 (resize_window_apply): Remove unused local.
10417 * window.h (delete_deletable_window): Remove decl.
10418
109e28d0 10419 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
10420 (imagemagick_load_image): Fix pointer signedness problem by changing
10421 last arg from unsigned char * to char *. All uses changed.
10422 Also, fix a local for similar reasons.
10423 Remove unused locals. Remove locals to avoid shadowing.
10424 (fn_rsvg_handle_free): Remove; unused.
10425 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 10426 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 10427
3f754b86
PE
10428 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
10429
2547adb1
CY
104302011-06-10 Chong Yidong <cyd@stupidchicken.com>
10431
10432 * image.c (gif_load): Fix omitted cast error introduced by
10433 2011-06-06 change.
10434
2c8e37d4
MR
104352011-06-10 Martin Rudalics <rudalics@gmx.at>
10436
10437 * window.h (resize_proportionally, orig_total_lines)
10438 (orig_top_line): Remove from window structure.
10439 (set_window_height, set_window_width, change_window_heights)
10440 (Fdelete_window): Remove prototypes.
10441 (resize_frame_windows): Remove duplicate declaration.
10442
440a42e3
EZ
104432011-06-10 Eli Zaretskii <eliz@gnu.org>
10444
10445 * window.h (resize_frame_windows, resize_window_check)
10446 (delete_deletable_window, resize_root_window)
10447 (resize_frame_windows): Declare prototypes.
10448
10449 * window.c (resize_window_apply): Make definition be "static" to
10450 match the prototype.
10451
562dd5e9
MR
104522011-06-10 Martin Rudalics <rudalics@gmx.at>
10453
10454 * window.c: Remove declarations of Qwindow_size_fixed,
10455 window_min_size_1, window_min_size_2, window_min_size,
10456 size_window, window_fixed_size_p, enlarge_window, delete_window.
10457 Remove static from declaration of Qdelete_window, it's
10458 temporarily needed by Fbury_buffer.
10459 (replace_window): Don't assign orig_top_line and
10460 orig_total_lines.
10461 (Fdelete_window, delete_window): Remove. Window deletion is
10462 handled by window.el.
640c8776
SM
10463 (window_loop): Remove DELETE_OTHER_WINDOWS case.
10464 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
10465 (Fdelete_other_windows): Remove. Deleting other windows is
10466 handled by window.el.
10467 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
10468 handled in window.el.
10469 (window_min_size_2, window_min_size_1, window_min_size): Remove.
10470 Window minimum sizes are handled in window.el.
10471 (shrink_windows, size_window, set_window_height)
10472 (set_window_width, change_window_heights, window_height)
10473 (window_width, CURBEG, CURSIZE, enlarge_window)
10474 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
10475 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
10476 handled in window.el.
10477 (make_dummy_parent): Rename to make_parent_window and give it a
10478 second argument horflag.
10479 (make_window): Don't set resize_proportionally any more.
10480 (Fsplit_window): Remove. Windows are split in window.el.
10481 (save_restore_action, save_restore_orig_size)
10482 (shrink_window_lowest_first, save_restore_orig_size): Remove.
10483 Resize mini windows in window.el.
10484 (grow_mini_window, shrink_mini_window): Implement by calling
10485 Qresize_root_window_vertically, resize_window_check and
10486 resize_window_apply.
640c8776
SM
10487 (saved_window, Fset_window_configuration, save_window_save):
10488 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
10489 resize_proportionally.
10490 (window_min_height, window_min_width): Move to window.el.
10491 (keys_of_window): Move bindings for delete-other-windows,
10492 split-window, delete-window and enlarge-window to window.el.
10493
10494 * buffer.c: Temporarily extern Qdelete_window.
10495 (Fbury_buffer): Temporarily call Qdelete_window instead of
10496 Fdelete_window (Fbury_buffer will move to window.el soon).
10497
10498 * frame.c (set_menu_bar_lines_1): Remove code handling
10499 orig_top_line and orig_total_lines.
10500
10501 * dispnew.c (adjust_frame_glyphs_initially): Don't use
10502 set_window_height but set heights directly.
10503 (change_frame_size_1): Use resize_frame_windows.
10504
10505 * xdisp.c (init_xdisp): Don't use set_window_height but set
10506 heights directly.
10507
640c8776
SM
10508 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
10509 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
10510 run_window_configuration_change_hook.
10511
10512 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
10513 instead of change_window_heights and run
10514 run_window_configuration_change_hook.
10515
1a13852e
MR
105162011-06-09 Martin Rudalics <rudalics@gmx.at>
10517
10518 * window.c (replace_window): Rename second argument REPLACEMENT to
10519 NEW. New third argument SETFLAG. Rewrite.
10520 (delete_window, make_dummy_parent): Call replace_window with
10521 third argument 1.
10522 (window_list_1): Move down in code.
10523 (run_window_configuration_change_hook): Move set_buffer part
10524 before select_frame_norecord part in order to unwind correctly.
10525 Rename count1 to count.
10526 (recombine_windows, delete_deletable_window, resize_root_window)
10527 (Fdelete_other_windows_internal)
10528 (Frun_window_configuration_change_hook, make_parent_window)
10529 (resize_window_check, resize_window_apply, Fresize_window_apply)
10530 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
10531 (Fdelete_window_internal, Fresize_mini_window_internal):
10532 New functions.
1a13852e
MR
10533 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
10534
f3d1777e
MR
105352011-06-08 Martin Rudalics <rudalics@gmx.at>
10536
496e208e
MR
10537 * window.h (window): Add some new members to window structure -
10538 normal_lines, normal_cols, new_total, new_normal, clone_number,
10539 splits, nest, prev_buffers, next_buffers.
10540 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 10541 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 10542
f3d1777e
MR
10543 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
10544 Remove.
496e208e
MR
10545 (make_dummy_parent): Set new members of windows structure.
10546 (make_window): Move down in code. Handle new members of window
10547 structure.
10548 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
10549 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
10550 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
10551 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
10552 (Fset_window_next_buffers, Fset_window_clone_number):
10553 New functions.
496e208e
MR
10554 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
10555 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
10556 Doc-string fixes.
10557 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
10558 Argument WINDOW can be now internal window too.
10559 (Fwindow_use_time): Move up in code.
10560 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
10561 Rewrite doc-string.
10562 (Fset_window_configuration, saved_window)
10563 (Fcurrent_window_configuration, save_window_save): Handle new
10564 members of window structure.
b9e809c2
MR
10565 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
10566 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
10567 (syms_of_window): New Lisp objects Qrecord_window_buffer,
10568 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
10569 Qget_mru_window, Qresize_root_window,
10570 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
10571 Qauto_buffer_name; staticpro them.
f3d1777e 10572
abde8f8c
MR
105732011-06-07 Martin Rudalics <rudalics@gmx.at>
10574
10575 * window.c (Fwindow_total_size, Fwindow_left_column)
10576 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
10577 (Fwindow_list_1): New functions.
10578 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
10579 (Fwindow_width, Fscroll_left, Fscroll_right):
10580 Use window_body_cols instead of window_box_text_cols.
10581 (delete_window, Fset_window_configuration):
10582 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
10583 (delete_all_subwindows): Take a window as argument and not a
10584 structure. Rewrite.
190b47e6
MR
10585 (window_loop): Remove handling of GET_LRU_WINDOW and
10586 GET_LARGEST_WINDOW.
10587 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
10588
10589 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
10590 window_box_text_cols. delete_all_subwindows now takes a
10591 Lisp_Object as argument.
abde8f8c 10592
640c8776
SM
10593 * indent.c (compute_motion, Fcompute_motion):
10594 Use window_body_cols instead of window_box_text_cols.
abde8f8c 10595
fa8a67e6
MR
10596 * frame.c (delete_frame): Call delete_all_subwindows with root
10597 window as argument.
10598
a54e3482
DC
105992011-06-07 Daniel Colascione <dan.colascione@gmail.com>
10600
10601 * fns.c (Fputhash): Document return value.
10602
60002bf5
CY
106032011-06-06 Chong Yidong <cyd@stupidchicken.com>
10604
10605 * image.c (gif_load): Implement gif89a spec "no disposal" method.
10606
0c671da6 106072011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 10608
b862a52a 10609 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 10610
be44ca6c
PE
10611 Check for overflow when converting integer to cons and back.
10612 * charset.c (Fdefine_charset_internal, Fdecode_char):
10613 Use cons_to_unsigned to catch overflow.
10614 (Fencode_char): Use INTEGER_TO_CONS.
10615 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
10616 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
10617 * data.c (long_to_cons, cons_to_long): Remove.
10618 (cons_to_unsigned, cons_to_signed): New functions.
10619 These signal an error for invalid or out-of-range values.
10620 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
10621 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
10622 * font.c (Ffont_variation_glyphs):
10623 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
10624 * lisp.h: Include <intprops.h>.
10625 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
10626 (cons_to_signed, cons_to_unsigned): New decls.
10627 (long_to_cons, cons_to_long): Remove decls.
10628 * undo.c (record_first_change): Use INTEGER_TO_CONS.
10629 (Fprimitive_undo): Use CONS_TO_INTEGER.
10630 * xfns.c (Fx_window_property): Likewise.
10631 * xselect.c: Include <limits.h>.
10632 (x_own_selection, selection_data_to_lisp_data):
10633 Use INTEGER_TO_CONS.
10634 (x_handle_selection_request, x_handle_selection_clear)
10635 (x_get_foreign_selection, Fx_disown_selection_internal)
10636 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
10637 (lisp_data_to_selection_data): Use cons_to_unsigned.
10638 (x_fill_property_data): Use cons_to_signed.
10639 Report values out of range.
10640
d1f3d2af
PE
10641 Check for buffer and string overflow more precisely.
10642 * buffer.h (BUF_BYTES_MAX): New macro.
10643 * lisp.h (STRING_BYTES_MAX): New macro.
10644 * alloc.c (Fmake_string):
10645 * character.c (string_escape_byte8):
10646 * coding.c (coding_alloc_by_realloc):
10647 * doprnt.c (doprnt):
10648 * editfns.c (Fformat):
10649 * eval.c (verror):
10650 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
10651 since they may not be the same number.
10652 * editfns.c (Finsert_char):
10653 * fileio.c (Finsert_file_contents):
10654 Likewise for BUF_BYTES_MAX.
10655
dd52fcea
PE
10656 * image.c: Use ptrdiff_t, not int, for sizes.
10657 (slurp_file): Switch from int to ptrdiff_t.
10658 All uses changed.
10659 (slurp_file): Check that file size fits in both size_t (for
10660 malloc) and ptrdiff_t (for sanity and safety).
10661
7f9bbdbb
PE
10662 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
10663 if b->modtime has its maximal value.
10664
dfe18f82
PE
10665 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
10666
84acfcf0
PE
10667 Don't assume time_t can fit into int.
10668 * buffer.h (struct buffer.modtime): Now time_t, not int.
10669 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
10670 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
10671
ccd9a01a
PE
10672 Minor fixes for signed vs unsigned integers.
10673 * character.h (MAYBE_UNIFY_CHAR):
10674 * charset.c (maybe_unify_char):
10675 * keyboard.c (read_char, reorder_modifiers):
10676 XINT -> XFASTINT, since the integer must be nonnegative.
10677 * ftfont.c (ftfont_spec_pattern):
10678 * keymap.c (access_keymap, silly_event_symbol_error):
10679 XUINT -> XFASTINT, since the integer must be nonnegative.
10680 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
10681 since it makes no difference and we prefer signed.
10682 * keyboard.c (record_char): Use XUINT when all the neighbors do.
10683 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
10684 nonnegative.
10685
d6d100dd
SM
106862011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
10687
10688 * window.h (Fwindow_frame): Declare.
10689
2b6148e4
PE
106902011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10691
10692 * alloc.c: Simplify handling of large-request failures (Bug#8800).
10693 (SPARE_MEMORY): Always define.
10694 (LARGE_REQUEST): Remove.
10695 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
10696
f230ecc9
MR
106972011-06-06 Martin Rudalics <rudalics@gmx.at>
10698
727e958e
MR
10699 * lisp.h: Move EXFUNS for Fframe_root_window,
10700 Fframe_first_window and Fset_frame_selected_window to window.h.
10701
10702 * window.h: Move EXFUNS for Fframe_root_window,
10703 Fframe_first_window and Fset_frame_selected_window here from
10704 lisp.h.
10705
10706 * frame.c (Fwindow_frame, Fframe_first_window)
10707 (Fframe_root_window, Fframe_selected_window)
10708 (Fset_frame_selected_window): Move to window.c.
10709 (Factive_minibuffer_window): Move to minibuf.c.
10710 (Fother_visible_frames_p): New function.
10711
10712 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
10713
f230ecc9
MR
10714 * window.c (decode_window, decode_any_window): Move up in code.
10715 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
10716 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
10717 (Fwindow_buffer): Move up and rewrite doc-string.
10718 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
10719 (Fwindow_prev): New functions.
727e958e
MR
10720 (Fwindow_frame): Move here from frame.c. Accept any window as
10721 argument.
10722 (Fframe_root_window, Fframe_first_window)
10723 (Fframe_selected_window): Move here from frame.c. Accept frame
10724 or arbitrary window as argument. Update doc-strings.
10725 (Fminibuffer_window): Move up in code.
10726 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
10727 (Fset_frame_selected_window): Move here from frame.c.
10728 Marginal rewrite.
727e958e
MR
10729 (Fselected_window, select_window, Fselect_window): Move up in
10730 code. Minor doc-string fixes.
f230ecc9 10731
4d09bcf6
PE
107322011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10733
10734 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
10735 Do not assume that spare memory exists; that assumption is valid
10736 only if SYSTEM_MALLOC.
10737 (LARGE_REQUEST): New macro, so that the issue of large requests
10738 is separated from the issue of spare memory.
10739
810928a2
AS
107402011-06-05 Andreas Schwab <schwab@linux-m68k.org>
10741
172418ad
AS
10742 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
10743 format. (Bug#8806)
10744
43f862f7
AS
10745 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
10746
810928a2
AS
10747 * xfns.c (x_set_scroll_bar_default_width): Move declarations
10748 before statements.
10749
a059fe24
JD
107502011-06-05 Jan Djärv <jan.h.d@swipnet.se>
10751
10752 * gtkutil.c (xg_get_default_scrollbar_width): New function.
10753
10754 * gtkutil.h: Declare xg_get_default_scrollbar_width.
10755
10756 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
10757 min width by calling x_set_scroll_bar_default_width (Bug#8505).
10758
989bf368
JB
107592011-06-05 Juanma Barranquero <lekktu@gmail.com>
10760
10761 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
10762
4b80f674
CY
107632011-06-04 Chong Yidong <cyd@stupidchicken.com>
10764
10765 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
10766 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
10767 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
10768 New error handlers.
4b80f674
CY
10769 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
10770 Obey Vx_select_enable_clipboard_manager. Catch errors in
10771 x_clipboard_manager_save (Bug#8779).
10772 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 10773 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 10774
99a33b77 107752011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
10776
10777 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
10778
99a33b77 107792011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
10780
10781 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
10782 in the current matrix if keep_current_p is non-zero.
10783
8264569d
EZ
107842011-06-04 Eli Zaretskii <eliz@gnu.org>
10785
10786 * bidi.c (bidi_level_of_next_char): Fix last change.
10787
57f97249
EZ
107882011-06-03 Eli Zaretskii <eliz@gnu.org>
10789
fec2107c 10790 Support bidi reordering of text covered by display properties.
57f97249 10791
fec2107c
EZ
10792 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
10793 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
10794 (bidi_cache_search, bidi_cache_iterator_state)
10795 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
10796 (bidi_level_of_next_char, bidi_move_to_visually_next):
10797 Support character positions inside a run of characters covered by a
fec2107c
EZ
10798 display string.
10799 (bidi_paragraph_init, bidi_resolve_explicit_1)
10800 (bidi_level_of_next_char): Call bidi_fetch_char and
10801 bidi_fetch_char_advance instead of FETCH_CHAR and
10802 FETCH_CHAR_ADVANCE.
10803 (bidi_init_it): Initialize new members.
10804 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
10805 definitions.
10806 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
10807 instead of using explicit *_CHAR codes.
d6d100dd
SM
10808 (bidi_resolve_explicit, bidi_resolve_weak):
10809 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
10810 bidirectional text is supported only in multibyte buffers.
10811 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
10812 it to initialize the frame_window_p member of struct bidi_it.
10813 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
10814 (bidi_resolve_explicit, bidi_resolve_weak)
10815 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
10816 bidi_it->nchars is non-positive.
10817 (bidi_level_of_next_char): Don't try to lookup the cache for the
10818 next/previous character if nothing is cached there yet, or if we
10819 were just reseat()'ed to a new position.
c40e2fb2 10820
0e14fe90
EZ
10821 * xdisp.c (set_cursor_from_row): Set start and stop points
10822 according to the row's direction when priming the loop that looks
10823 for the glyph on which to display cursor.
10824 (single_display_spec_intangible_p): Function deleted.
10825 (display_prop_intangible_p): Reimplement to call
10826 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
10827 Accept 3 additional arguments needed by handle_display_spec.
10828 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
10829 values: lists, `(when COND...)' forms, etc.
10830 (single_display_spec_string_p): Support property values that are
10831 lists with the argument STRING its top-level element.
10832 (display_prop_string_p): Fix the condition for processing a
10833 property that is a list to be consistent with handle_display_spec.
fec2107c 10834 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
10835 last portion of handle_display_prop.
10836 (compute_display_string_pos): Accept additional argument
10837 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
10838 value of a `display' property is a "replacing spec".
10839 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
10840 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
10841 the display property, but just return a value indicating whether
10842 the display property will replace the characters it covers.
10843 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
10844 frame_window_p members of struct bidi_it.
d6d100dd
SM
10845 (compute_display_string_pos, compute_display_string_end):
10846 New functions.
fec2107c
EZ
10847 (push_it): Accept second argument POSITION, where pop_it should
10848 jump to continue iteration.
10849 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 10850
fec2107c
EZ
10851 * keyboard.c (adjust_point_for_property): Adjust the call to
10852 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
10853
10854 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
10855 (bidi_init_it): Update prototypes.
10856 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
10857 (compute_display_string_pos, compute_display_string_end):
10858 Declare prototypes.
fec2107c
EZ
10859 (struct bidi_it): New members nchars and disp_pos. ch_len is now
10860 EMACS_INT.
fc6f18ce 10861
40087514 108622011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 10863
57f53182
PE
10864 Malloc failure behavior now depends on size of allocation.
10865 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
10866 * lisp.h: Change signatures accordingly.
10867 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
10868 All callers changed. (Bug#8762)
10869
10870 * gnutls.c: Use Emacs's memory allocators.
10871 Without this change, the gnutls library would invoke malloc etc.
10872 directly, which causes problems on non-SYNC_INPUT hosts, and which
10873 runs afoul of improving memory_full behavior. (Bug#8761)
10874 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
10875 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
10876 xfree instead of the default malloc, realloc, free.
10877 (Fgnutls_boot): No need to check for memory allocation failure,
10878 since xmalloc does that for us.
10879
ac32cd99 10880 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
10881 * category.c (hash_get_category_set):
10882 * ccl.c (ccl_driver):
10883 * charset.c (Fdefine_charset_internal):
10884 * charset.h (struct charset.hash_index):
10885 * composite.c (get_composition_id, gstring_lookup_cache)
10886 (composition_gstring_put_cache):
10887 * composite.h (struct composition.hash_index):
10888 * dispextern.h (struct image.hash):
10889 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
10890 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
10891 (hashfn_equal, hashfn_user_defined, make_hash_table)
10892 (maybe_resize_hash_table, hash_lookup, hash_put)
10893 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
10894 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
10895 (Fsxhash, Fgethash, Fputhash, Fmaphash):
10896 * image.c (make_image, search_image_cache, lookup_image)
10897 (xpm_put_color_table_h):
10898 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 10899 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 10900 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 10901 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
10902 * alloc.c (allocate_vectorlike):
10903 Check for overflow in vector size calculations.
10904 * ccl.c (ccl_driver):
10905 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
10906 * fns.c, image.c: Remove unnecessary static decls that would otherwise
10907 need to be updated by these changes.
40087514
PE
10908 * fns.c (make_hash_table, maybe_resize_hash_table):
10909 Check for integer overflow with large hash tables.
0de4bb68
PE
10910 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
10911 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
10912 (SXHASH_REDUCE): New macro.
10913 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
10914 Use it instead of discarding useful hash info with large hash values.
10915 (sxhash_float): New function.
10916 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
10917 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
10918 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
10919 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
10920 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
10921 Adjust signatures to match updated version of code.
10922 (consing_since_gc): Now EMACS_INT, since a single hash table can
10923 use more than INT_MAX bytes.
10924
698d32e2
DN
109252011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
10926
10927 Make it possible to build with GCC-4.6+ -O2 -flto.
10928
10929 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
10930
fd6fa53f
SM
109312011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
10932
10933 * minibuf.c (get_minibuffer, read_minibuf_unwind):
10934 Call minibuffer-inactive-mode.
10935
864db017
JB
109362011-05-31 Juanma Barranquero <lekktu@gmail.com>
10937
10938 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
10939 Update dependencies.
10940
2ad0baf4
DN
109412011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10942
10943 * data.c (init_data): Remove code for UTS, this system is not
10944 supported anymore.
10945
4fcc2638
DN
109462011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10947
10948 Don't force ./temacs to start in terminal mode.
10949
10950 * frame.c (make_initial_frame): Initialize faces in all cases, not
10951 only when CANNOT_DUMP is defined.
10952 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
10953
c56e0fd5
DN
109542011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10955
10956 * dispnew.c (add_window_display_history): Use const for the string
10957 pointer. Remove declaration, not needed.
10958
333d54da 109592011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 10960
55d4c1b2 10961 Use 'inline', not 'INLINE'.
333d54da 10962 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
10963 * alloc.c, fontset.c (INLINE): Remove.
10964 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
10965 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
10966 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
10967 * gmalloc.c (register_heapinfo): Use inline unconditionally.
10968 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
10969
738db178
DN
109702011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10971
10972 Make it possible to run ./temacs.
10973
10974 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
10975 syms_of_callproc does the same thing. Remove test for
10976 "initialized", do it in the caller.
10977 * emacs.c (main): Avoid calling set_initial_environment when dumping.
10978
620c53a6
SM
109792011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
10980
10981 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
10982 (read_minibuf): Use get_minibuffer.
10983 (syms_of_minibuf): Use DEFSYM.
10984 (Qmetadata): New var.
10985 * data.c (Qbuffer): Don't make it static.
10986 (syms_of_data): Use DEFSYM.
10987
e003a292
PE
109882011-05-31 Paul Eggert <eggert@cs.ucla.edu>
10989
10990 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
10991 (CCL_CODE_MIN): New macro.
10992
ed008a6d
PE
109932011-05-30 Paul Eggert <eggert@cs.ucla.edu>
10994
3687c2ef
PE
10995 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
10996
ed008a6d
PE
10997 * eval.c (Qdebug): Now static.
10998 * lisp.h (Qdebug): Remove decl. This reverts a part of the
10999 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
11000 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
11001
d66c4c7c
CY
110022011-05-29 Chong Yidong <cyd@stupidchicken.com>
11003
11004 * image.c: Various fixes to ImageMagick code comments.
11005 (Fimagemagick_types): Doc fix.
11006
5fbc2025
PE
110072011-05-29 Paul Eggert <eggert@cs.ucla.edu>
11008
0196f88a
PE
11009 Minor fixes prompted by GCC 4.6.0 warnings.
11010
11011 * xselect.c (converted_selections, conversion_fail_tag): Now static.
11012
5fbc2025
PE
11013 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
11014 (x_clipboard_manager_save_all): Move extern decl to ...
11015 * xterm.h: ... here, so that it can be checked for consistency.
11016
1dd3c2d9
CY
110172011-05-29 Chong Yidong <cyd@stupidchicken.com>
11018
11019 * xselect.c (x_clipboard_manager_save_frame)
11020 (x_clipboard_manager_save_all): New functions.
11021 (Fx_clipboard_manager_save): Lisp function deleted.
11022
11023 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
11024 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
11025
11026 * xterm.h: Update prototype.
11027
5ba6571d
WX
110282011-05-28 William Xu <william.xwl@gmail.com>
11029
11030 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
11031 exiting (Bug#8239).
11032
3eaff834
JM
110332011-05-28 Jim Meyering <meyering@redhat.com>
11034
e1900994 11035 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
11036 * fns.c (to_uchar): Define.
11037 (crypto_hash_function): Use it to convert some newly-signed
11038 variables to unsigned, to avoid sign-extension bugs. For example,
11039 without this change, (md5 "truc") would evaluate to
11040 45723a2aff78ff4fff7fff1114760e62 rather than the expected
11041 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 11042 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 11043
0f6990a7
PE
110442011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11045
11046 Integer overflow fixes.
c8a9ca5a 11047
08686060
PE
11048 * dbusbind.c: Serial number integer overflow fixes.
11049 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
11050 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
11051 to hold a serial number that is too large for a fixnum.
11052 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11053 Check for serial numbers out of range. Decode any serial number
59568bf0 11054 that was so large that it became a float. (Bug#8722)
08686060 11055
2d1fc3c7
PE
11056 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
11057 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11058 Use XFASTINT rather than XUINT when numbers are nonnegative.
11059 (xd_append_arg, Fdbus_method_return_internal):
11060 (Fdbus_method_error_internal): Likewise. Also, for unsigned
11061 arguments, check that Lisp number is nonnegative, rather than
59568bf0 11062 silently wrapping negative numbers around. (Bug#8722)
30217ff0 11063 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 11064 (Bug#8722)
2d1fc3c7 11065
c8a9ca5a
PE
11066 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
11067
519e1d69
PE
11068 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
11069
6df6ae42 11070 ccl: Add integer overflow checks.
30569699
PE
11071 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
11072 (IN_INT_RANGE): New macros.
11073 (ccl_driver): Use them to check for integer overflow when
11074 decoding a CCL program. Many of the new checks are whether XINT (x)
11075 fits in int; it doesn't always, on 64-bit hosts. The new version
11076 doesn't catch all possible integer overflows, but it's an
847044ea 11077 improvement. (Bug#8719)
30569699 11078
c11285dc
PE
11079 * alloc.c (make_event_array): Use XINT, not XUINT.
11080 There's no need for unsigned here.
11081
fdccd48e
PE
11082 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
11083 This follows up to the 2011-05-06 change that substituted uintptr_t
11084 for EMACS_INT. This case wasn't caught back then.
11085
37910ab2
PE
11086 Rework Fformat to avoid integer overflow issues.
11087 * editfns.c: Include <float.h> unconditionally, as it's everywhere
11088 now (part of C89). Include <verify.h>.
11089 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
11090 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
11091 (Fformat): Avoid the prepass trying to compute sizes; it was only
11092 approximate and thus did not catch overflow reliably. Instead, walk
11093 through the format just once, formatting and computing sizes as we go,
11094 checking for integer overflow at every step, and allocating a larger
11095 buffer as needed. Keep track separately whether the format is
11096 multibyte. Keep only the most-recently calculated precision, rather
11097 than them all. Record whether each argument has been converted to
11098 string. Use EMACS_INT, not int, for byte and char and arg counts.
11099 Support field widths and precisions larger than INT_MAX. Avoid
11100 sprintf's undefined behavior with conversion specifications such as %#d
11101 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
11102 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
11103 formatting out-of-range floating point numbers with int
9173deec 11104 formats. (Bug#8668)
37910ab2 11105
2e6578fb
PE
11106 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
11107
0ae6bdee
PE
11108 * data.c: Avoid integer truncation in expressions involving floats.
11109 * data.c: Include <intprops.h>.
11110 (arith_driver): When there's an integer overflow in an expression
11111 involving floating point, convert the integers to floating point
11112 so that the resulting value does not suffer from catastrophic
11113 integer truncation. For example, on a 64-bit host (* 4
11114 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
11115 Do not rely on undefined behavior after integer overflow.
11116
de883a70
PE
11117 merge count_size_as_multibyte, parse_str_to_multibyte
11118 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 11119 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
11120 Check for integer overflow.
11121 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
11122 since it's now a duplicate of the other. This is more of
11123 a character than a buffer op, so better that it's in character.c.
11124 * fns.c, print.c: Adjust to above changes.
11125
2ff916cb
PE
111262011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
11127
11128 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
11129
f1b54466
PE
111302011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11131
fb1ac845
PE
11132 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11133 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
11134 (x_clipboard_manager_save): Now static.
11135 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
11136
f1b54466
PE
11137 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11138 (crypto_hash_function): Now static.
11139 Fix pointer signedness problems. Avoid unnecessary initializations.
11140
a9f737ee
CY
111412011-05-27 Chong Yidong <cyd@stupidchicken.com>
11142
11143 * termhooks.h (Vselection_alist): Make it terminal-local.
11144
11145 * terminal.c (create_terminal): Initialize it.
11146
11147 * xselect.c: Support for clipboard managers.
11148 (Vselection_alist): Move to termhooks.h as terminal-local var.
11149 (LOCAL_SELECTION): New macro.
11150 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
11151 (symbol_to_x_atom): Remove gratuitous arg.
11152 (x_handle_selection_request, lisp_data_to_selection_data)
11153 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
11154 (x_own_selection, x_get_local_selection, x_convert_selection):
11155 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
11156 (some_frame_on_display): Delete unused function.
11157 (Fx_own_selection_internal, Fx_get_selection_internal)
11158 (Fx_disown_selection_internal, Fx_selection_owner_p)
11159 (Fx_selection_exists_p): New optional frame arg.
11160 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
11161 (x_handle_selection_clear): Don't treat other terminals with the
11162 same keyboard specially. Use the terminal-local Vselection_alist.
11163 (x_clear_frame_selections): Use Frun_hook_with_args.
11164
11165 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
11166
11167 * xterm.h: Add support for those atoms.
11168
e067f0c1
CY
111692011-05-26 Chong Yidong <cyd@stupidchicken.com>
11170
11171 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
11172 (converted_selections, conversion_fail_tag): New global variables.
11173 (x_selection_request_lisp_error): Free the above.
11174 (x_get_local_selection): Remove unnecessary code.
11175 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
11176 of converted selections stored in converted_selections.
11177 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
11178 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
11179 (x_convert_selection): New function.
11180 (x_handle_selection_event): Simplify.
11181 (x_get_foreign_selection): Don't ignore incoming requests while
11182 waiting for an answer; this will fail when we implement
11183 SAVE_TARGETS, and seems unnecessary anyway.
11184 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
11185 (Vx_sent_selection_functions): Doc fix.
11186
0f4aebc0
LL
111872011-05-26 Leo Liu <sdl.web@gmail.com>
11188
11189 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
11190
e61124cd
YM
111912011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11192
11193 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
11194
11195 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
11196 for fringe update if it has periodic bitmap.
ac389d0c 11197 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
11198 and fringe_bitmap_periodic_p.
11199
11200 * fringe.c (get_fringe_bitmap_data): New function.
11201 (draw_fringe_bitmap_1, update_window_fringes): Use it.
11202 (update_window_fringes): Record periodicity of fringe bitmap in glyph
11203 row. Mark glyph row for fringe update if periodicity changed.
11204
11205 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
11206 for fringe update unless it has periodic bitmap.
11207
f16d9837
KH
112082011-05-25 Kenichi Handa <handa@m17n.org>
11209
11210 * xdisp.c (get_next_display_element): Set correct it->face_id for
11211 a static composition.
11212
e1b90ef6
LL
112132011-05-24 Leo Liu <sdl.web@gmail.com>
11214
11215 * deps.mk (fns.o):
11216 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
11217
11218 * fns.c (crypto_hash_function, Fsha1): New function.
11219 (Fmd5): Use crypto_hash_function.
11220 (syms_of_fns): Add Ssha1.
11221
7400048f
PE
112222011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11223
11224 * gnutls.c: Remove unused macros.
11225 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
11226 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
11227 Remove macros that are defined and never used.
11228 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
11229
abb71cf4
CY
112302011-05-22 Chong Yidong <cyd@stupidchicken.com>
11231
11232 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
11233 (Fx_get_selection_internal): Minor cleanup.
11234 (Fx_own_selection_internal): Rename arguments for consistency with
11235 select.el.
11236
6307db39
PE
112372011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11238
11239 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
11240
f3d4e0a4
CY
112412011-05-22 Chong Yidong <cyd@stupidchicken.com>
11242
11243 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
11244
4d8ade89
YM
112452011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11246
11247 * dispnew.c (scrolling_window): Don't exclude the case that the
11248 last enabled row in the desired matrix touches the bottom boundary.
11249
32078c8d
GM
112502011-05-21 Glenn Morris <rgm@gnu.org>
11251
11252 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
11253 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
11254 and add some more files.
32078c8d 11255
7285dc67
EZ
112562011-05-20 Eli Zaretskii <eliz@gnu.org>
11257
11258 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
11259 report_file_error introduced by the change from 2011-05-07.
11260
89d1bd22
PE
112612011-05-20 Paul Eggert <eggert@cs.ucla.edu>
11262
11263 * systime.h (Time): Define only if emacs is defined.
11264 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
11265 where the include path doesn't have X11/X.h by default. See
11266 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
11267
cd394be1 112682011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
11269
11270 * composite.c (find_automatic_composition): Fix previous change.
11271
b9704ad9
GM
112722011-05-20 Glenn Morris <rgm@gnu.org>
11273
11274 * lisp.mk: New file, split from Makefile.in.
11275 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
11276 (shortlisp): Remove.
11277 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
11278
4a720484
GM
112792011-05-19 Glenn Morris <rgm@gnu.org>
11280
11281 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
11282 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
11283 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
11284 (lisp): Set the order to that of loadup.el.
11285 (shortlisp): Make it a copy of $lisp.
11286 (SOME_MACHINE_LISP): Remove.
11287 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
11288 Use just $shortlisp, not $SOME_MACHINE_LISP too.
11289
a28d4396
KH
112902011-05-18 Kenichi Handa <handa@m17n.org>
11291
11292 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
11293 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
11294 (find_automatic_composition): Mostly rewrite for efficiency.
11295
a2b1fa8e
JB
112962011-05-18 Juanma Barranquero <lekktu@gmail.com>
11297
11298 * makefile.w32-in: Update dependencies.
11299
8e1f5610
CS
113002011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
11301
11302 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 11303 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 11304
7025ee00 113052011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 11306
cdfa6eab
PE
11307 Fix some integer overflow issues, such as string length overflow.
11308
06d6db33
PE
11309 * insdel.c (count_size_as_multibyte): Check for string overflow.
11310
2b4560a8
PE
11311 * character.c (lisp_string_width): Check for string overflow.
11312 Use EMACS_INT, not int, for string indexes and lengths; in
11313 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
11314 the resulting string length overflows an EMACS_INT; instead,
11315 report a string overflow if no precision given. When checking for
11316 precision exhaustion, use a check that cannot possibly have
11317 integer overflow. (Bug#8675)
11318 * character.h (lisp_string_width): Adjust to new signature.
11319
cb93f9be
PE
11320 * alloc.c (string_overflow): New function.
11321 (Fmake_string): Use it. This doesn't change behavior, but saves
11322 a few bytes and will simplify future changes.
11323 * character.c (string_escape_byte8): Likewise.
11324 * lisp.h (string_overflow): New decl.
11325
1a1f3366
PE
11326 Fixups, following up to the user-interface timestamp change.
11327 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
11328 for UI timestamps, instead of unsigned long.
9fbd6841
PE
11329 * msdos.c (mouse_get_pos): Likewise.
11330 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
11331 * w32gui.h (Time): Define by including "systime.h" rather than by
11332 declaring it ourselves. (Bug#8664)
11333
d4e3e4d3
PE
11334 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
11335 * image.c (clear_image_cache): Likewise.
11336
f6a24d19
PE
11337 * term.c (term_mouse_position): Don't assume time_t wraparound.
11338
08dc5ae6
PE
11339 Be more systematic about user-interface timestamps.
11340 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
11341 and sometimes 'EMACS_UINT', to represent these timestamps.
11342 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
11343 This makes the code easier to follow, and makes it easier to catch
11344 integer overflow bugs such as Bug#8664.
11345 * frame.c (Fmouse_position, Fmouse_pixel_position):
11346 Use Time, not unsigned long, for user-interface timestamps.
11347 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
11348 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
11349 * keyboard.h (last_event_timestamp): Likewise.
11350 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
11351 * menu.h (xmenu_show): Likewise.
11352 * term.c (term_mouse_position): Likewise.
11353 * termhooks.h (struct input_event.timestamp): Likewise.
11354 (struct terminal.mouse_position_hook): Likewise.
11355 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
11356 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
11357 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
11358 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
11359 what it was before.
11360 * menu.h, termhooks.h: Include "systime.h", for Time.
11361
8e55734a
PE
11362 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
11363 Don't assume that the difference between two unsigned long values
11364 can fit into an integer. At this point, we know button_down_time
11365 <= event->timestamp, so the difference must be nonnegative, so
11366 there's no need to cast the result if double-click-time is
11367 nonnegative, as it should be; check that it's nonnegative, just in
11368 case. This bug is triggered when events are more than 2**31 ms
86db42d2 11369 apart (about 25 days). (Bug#8664)
8e55734a 11370
841f1b75 11371 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 11372 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 11373
3e26f69c
PE
11374 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
11375 that always fit in int. Use a sentinel instead of a counter, to
11376 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
11377 * frame.h (struct frame): Use int for menu_bar_items_used
11378 instead of EMACS_INT, since it always fits in int.
3e26f69c 11379
5cc152c0
PE
11380 * menu.c (grow_menu_items): Check for int overflow.
11381
d89eb65e
PE
11382 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
11383
5235bd3e
PE
11384 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
11385 Before, the code was not consistent. These values cannot exceed
11386 2**31 - 1 so there's no need to make them unsigned.
11387 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
11388 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
11389 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
11390 as modifiers.
11391 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
11392
bc827e23
PE
11393 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
11394 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
11395 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
11396 presumably because the widths might not match.
11397
78eb494e
PE
11398 * window.c (size_window): Avoid needless test at loop start.
11399
04f2d78b
CB
114002011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
11401
11402 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
11403
d2fc7e3d 114042011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
11405
11406 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
11407
d2fc7e3d 114082011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
11409
11410 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
11411 `width' to `bar_area_x' and `bar_area_width', respectively.
11412 (x_scroll_run): Take account of fringe background extension.
11413
04f2d78b
CB
11414 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
11415 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
11416 `bar_area_width', respectively.
11417 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
11418 background extension.
11419
79b70037
GM
114202011-05-10 Jim Meyering <meyering@redhat.com>
11421
11422 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
11423
2f142cc5
JB
114242011-05-10 Juanma Barranquero <lekktu@gmail.com>
11425
11426 * image.c (Finit_image_library): Return t for built-in image types,
11427 like pbm and xbm. (Bug#8640)
11428
57679c86
AS
114292011-05-09 Andreas Schwab <schwab@linux-m68k.org>
11430
11431 * w32menu.c (set_frame_menubar): Fix submenu allocation.
11432
888c9e86
EZ
114332011-05-07 Eli Zaretskii <eliz@gnu.org>
11434
b0512a1d
EZ
11435 * w32console.c (Fset_screen_color): Doc fix.
11436 (Fget_screen_color): New function.
11437 (syms_of_ntterm): Defsubr it.
11438
7285dc67
EZ
11439 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
11440 unlink the temporary file if Fcall_process didn't create it in the
11441 first place.
11442 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
11443 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
11444 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
11445 cue to call_process_cleanup not to close that handle.
11446
4d3fcc8e
BK
114472011-05-07 Ben Key <bkey76@gmail.com>
11448
11449 * makefile.w32-in: The bootstrap-temacs rule now makes use of
11450 one of two shell specific rules, either bootstrap-temacs-CMD or
11451 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
11452 to the previous implementation of the bootstrap-temacs rule.
11453 The bootstrap-temacs-CMD rule is similar to the previous
11454 implementation of the bootstrap-temacs rule except that it
11455 makes use of the ESC_CFLAGS variable instead of the CFLAGS
11456 variable.
11457
11458 These changes, along with some changes to nt/configure.bat,
11459 nt/gmake.defs, and nt/nmake.defs, are required to extend my
11460 earlier fix to add support for --cflags and --ldflags options
11461 that include quotes so that it works whether make uses cmd or
11462 sh as the shell.
11463
b4289b64
MA
114642011-05-06 Michael Albinus <michael.albinus@gmx.de>
11465
11466 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
11467 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
11468 is a constant.
11469 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
11470 a string. Handle both cases.
11471 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
11472 (Fdbus_register_method): Use Qinvalid_function.
11473
af4c0e28
JB
114742011-05-06 Juanma Barranquero <lekktu@gmail.com>
11475
11476 * makefile.w32-in: Update dependencies.
11477 (LISP_H): Add inttypes.h and stdin.h.
11478 (PROCESS_H): Add unistd.h.
11479
c51453d9
EZ
114802011-05-06 Eli Zaretskii <eliz@gnu.org>
11481
11482 * lread.c: Include limits.h (fixes the MS-Windows build broken by
11483 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
11484
8ff0ac3c 114852011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 11486
4c4b566b
PE
11487 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
11488
aab2b9b5
PE
11489 * term.c (vfatal): Remove stray call to va_end.
11490 It's not needed and the C Standard doesn't allow it here anyway.
11491
c378da0b
PE
11492 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
11493 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
11494
288b08c7
PE
11495 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
11496 bytes.
11497
e3601888
PE
11498 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
11499
db6c0e74
PE
11500 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
11501
dd5963ea
PE
11502 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
11503
88c9450f
PE
11504 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
11505
2f9442b8
PE
11506 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
11507
c032b5f8
PE
11508 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
11509 * charset.c (Fdefine_charset_internal): Don't initialize
11510 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 11511 32-bit int (Bug#8600).
a108c10b
PE
11512
11513 * lread.c (read_integer): Be more consistent with string-to-number.
11514 Use string_to_number to do the actual conversion; this avoids
11515 rounding errors and fixes some other screwups. Without this fix,
11516 for example, #x1fffffffffffffff was misread as -2305843009213693952.
11517 (digit_to_number): Move earlier, for benefit of read_integer.
11518 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 11519 not a digit in any supported base. (Bug#8602)
a108c10b 11520
ad5f9eea
PE
11521 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
11522
aec1708a
PE
11523 * dispnew.c (scrolling_window): Return 1 if we scrolled,
11524 to match comment at start of function. This also removes a
11525 GCC warning about overflow in a 32+64-bit port.
11526
47be4ab5
PE
11527 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
11528
371cac43
PE
11529 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
11530 Reported by Stefan Monnier in
11531 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
11532 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11533 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 11534
d01a7826
PE
11535 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
11536 (EMACS_UINTPTR): Likewise, with uintptr_t.
11537
7fd47d5c
PE
11538 * lisp.h: Prefer 64-bit EMACS_INT if available.
11539 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
11540 on 32-bit hosts that have 64-bit int, so that they can access
11541 large files.
122b0c86
PE
11542 However, temporarily disable this change unless the temporary
11543 symbol WIDE_EMACS_INT is defined.
7fd47d5c 11544
8727937b
PE
11545 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
11546
8ac068ac
PE
11547 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
11548 This removes an assumption that EMACS_INT and long are the same
11549 width as pointers. The assumption is true for Emacs porting targets
11550 now, but we want to make other targets possible.
11551 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
11552 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
11553 In the rest of the code, change types of integers that hold casted
11554 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
11555 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
11556 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
11557 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
11558 No need to cast type when ORing.
11559 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
11560 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
11561 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
11562 assume EMACS_INT is the same width as char *.
11563 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
11564 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
11565 Remove no-longer-needed casts.
11566 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
11567 (xg_tool_bar_help_callback, xg_make_tool_item):
11568 Use EMACS_INTPTR to hold an integer
11569 that will be cast to void *; this can avoid a GCC warning
11570 if EMACS_INT is not the same width as void *.
11571 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
11572 * xdisp.c (display_echo_area_1, resize_mini_window_1):
11573 (current_message_1, set_message_1):
11574 Use a local to convert to proper width without a cast.
11575 * xmenu.c (dialog_selection_callback): Likewise.
11576
ede49d71
PE
11577 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
11578 Also, don't assume VALBITS / RAND_BITS is less than 5,
11579 and don't rely on undefined behavior when shifting a 1 left into
11580 the sign bit.
11581 * lisp.h (get_random): Change signature to match.
11582
2f30ecd0
PE
11583 * lread.c (hash_string): Use size_t, not int, for hash computation.
11584 Normally we prefer signed values; but hashing is special, because
11585 it's better to use unsigned division on hash table sizes so that
11586 the remainder is nonnegative. Also, size_t is the natural width
11587 for hashing into memory. The previous code used 'int', which doesn't
11588 retain enough info to hash well into very large tables.
11589 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
11590
2a866e7b
PE
11591 * dbusbind.c: Don't possibly lose pointer info when converting.
11592 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11593 Use XPNTR rather than XHASH, so that the high-order bits of
11594 the pointer aren't lost when converting through void *.
11595
51639eac
PE
11596 * eval.c (Fautoload): Don't double-shift a pointer.
11597
92394119
PE
11598 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
11599
dbdb9a7c
JB
116002011-05-06 Juanma Barranquero <lekktu@gmail.com>
11601
11602 * gnutls.c (DEF_GNUTLS_FN):
11603 * image.c (DEF_IMGLIB_FN): Make function pointers static.
11604
db7a0b4f
AS
116052011-05-05 Andreas Schwab <schwab@linux-m68k.org>
11606
11607 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
11608 marker. (Bug#8610)
11609
cd394be1 116102011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
11611
11612 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
11613 New version that can reserve upto 2GB of heap space.
11614
f7ff1b0f 116152011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
11616
11617 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
11618
639c109b
TZ
116192011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
11620
11621 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
11622 `gnutls_certificate_set_x509_key_file'.
11623
d2127135
JB
116242011-05-05 Juanma Barranquero <lekktu@gmail.com>
11625
11626 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
11627 Update dependencies.
11628
e968f4f3
JB
116292011-05-04 Juanma Barranquero <lekktu@gmail.com>
11630
11631 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
11632 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
11633 Remove unused parameter `fildes'.
11634 * process.c (read_process_output, send_process): Don't pass it.
11635
84d358f0
JB
116362011-05-04 Juanma Barranquero <lekktu@gmail.com>
11637
11638 Fix previous change: the library cache is defined in w32.c.
11639 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
11640 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
11641
0898ca10
JB
116422011-05-04 Juanma Barranquero <lekktu@gmail.com>
11643
11644 Implement dynamic loading of GnuTLS on Windows.
11645
11646 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
11647 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
11648 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11649 Declare.
11650
11651 * gnutls.c (Qgnutls_dll): Define.
11652 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
11653 (gnutls_*): Declare function pointers.
11654 (init_gnutls_functions): New function to initialize function pointers.
11655 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
11656 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
11657 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11658 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
11659 (emacs_gnutls_write, emacs_gnutls_read)
11660 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
11661 (Fgnutls_available_p): New function.
11662 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
11663 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
11664 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
11665
11666 * image.c: Include w32.h.
11667 (Vimage_type_cache): Delete.
11668 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
11669 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
11670 (w32_delayed_load): Move to w32.c.
11671
11672 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
11673
11674 * w32.c (QCloaded_from, Vlibrary_cache): Define.
11675 (w32_delayed_load): Move from image.c. When loading a library, record
11676 its filename in the :loaded-from property of the library id.
11677 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
11678 Initialize and staticpro them.
11679 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
11680
11681 * process.c: Include lisp.h before w32.h, not after.
11682 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
11683 instead of gnutls_record_check_pending.
11684
11685 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
11686
ff4de4aa
TZ
116872011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
11688
11689 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
11690 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
11691 as passed in.
11692
abe95abb
JD
116932011-05-03 Jan Djärv <jan.h.d@swipnet.se>
11694
11695 * xterm.c (x_set_frame_alpha): Do not set property on anything
11696 else than FRAME_X_OUTER_WINDOW (Bug#8608).
11697
e16e55d4
JB
116982011-05-02 Juanma Barranquero <lekktu@gmail.com>
11699
11700 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
11701
bafcf6a5
JB
117022011-05-02 Juanma Barranquero <lekktu@gmail.com>
11703
11704 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
11705 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
11706 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
11707 (gnutls_global_initialized, Qgnutls_bootprop_priority)
11708 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
11709 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
11710 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
11711 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
11712 (Qgnutls_bootprop_callbacks_verify): Make static.
11713
e7a6747f
AS
117142011-05-01 Andreas Schwab <schwab@linux-m68k.org>
11715
19ed11ba
AS
11716 * callproc.c: Indentation fixup.
11717
e7a6747f 11718 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
11719 (wait_for_termination, interruptible_wait_for_termination):
11720 Move after wait_for_termination_1.
e7a6747f 11721
1ef14cb4
LMI
117222011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
11723
11724 * sysdep.c (interruptible_wait_for_termination): New function
11725 which is like wait_for_termination, but allows keyboard
11726 interruptions.
11727
11728 * callproc.c (Fcall_process): Add (:file "file") as an option for
11729 the STDOUT buffer.
11730 (Fcall_process_region): Ditto.
11731
330d880c
EZ
117322011-04-30 Eli Zaretskii <eliz@gnu.org>
11733
8db90b73
EZ
11734 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
11735 rather than `XVECTOR (FOO)->size'.
11736
330d880c
EZ
11737 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
11738 inttypes.h, as a gnulib replacement is used if it not available in
11739 system headers.
11740
15cbd324
EZ
117412011-04-21 Eli Zaretskii <eliz@gnu.org>
11742
11743 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
11744 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
11745 of MOST_POSITIVE_FIXNUM. (Bug#8528)
11746
11747 * coding.c (coding_alloc_by_realloc): Error out if destination
11748 will grow beyond MOST_POSITIVE_FIXNUM.
11749 (decode_coding_emacs_mule): Abort if there isn't enough place in
11750 charbuf for the composition carryover bytes. Reserve an extra
11751 space for up to 2 characters produced in a loop.
11752 (decode_coding_iso_2022): Abort if there isn't enough place in
11753 charbuf for the composition carryover bytes.
11754
117552011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 11756
ae940cca
EZ
11757 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
11758 aborting when %lld or %lll format is passed.
11759 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
11760 %llo or %llx format is passed. (Bug#8545)
11761
03ab8921
EZ
11762 * window.c (window_scroll_line_based): Use a marker instead of
11763 simple variables to record original value of point. (Bug#7952)
11764
afda1437
EZ
11765 * doprnt.c (doprnt): Fix the case where a multibyte sequence
11766 produced by %s or %c overflows available buffer space. (Bug#8545)
11767
f76dee0c
PE
117682011-04-28 Paul Eggert <eggert@cs.ucla.edu>
11769
11770 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 11771 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 11772
fdc5744d
JB
117732011-04-28 Juanma Barranquero <lekktu@gmail.com>
11774
11775 * w32.c (init_environment): Warn about defaulting HOME to C:\.
11776
638f053a
JB
117772011-04-28 Juanma Barranquero <lekktu@gmail.com>
11778
11779 * keyboard.c (Qdelayed_warnings_hook): Define.
11780 (command_loop_1): Run `delayed-warnings-hook'
11781 if Vdelayed_warnings_list is non-nil.
11782 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
11783 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
11784
d178f871
EZ
117852011-04-28 Eli Zaretskii <eliz@gnu.org>
11786
11787 * doprnt.c (doprnt): Don't return value smaller than the buffer
11788 size if the message was truncated. (Bug#8545).
11789
b124fd93
JB
117902011-04-28 Juanma Barranquero <lekktu@gmail.com>
11791
11792 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
11793 (Fx_window_property): #if-0 the whole functions, not just the bodies.
11794
e810457d
PE
117952011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11796
11797 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
11798
ea51cceb
JB
117992011-04-27 Juanma Barranquero <lekktu@gmail.com>
11800
11801 * makefile.w32-in: Update dependencies.
11802
94dcfacf
EZ
118032011-04-27 Eli Zaretskii <eliz@gnu.org>
11804
11805 Improve `doprnt' and its usage. (Bug#8545)
11806 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
11807 `format_end'. Remove support for %l as a conversion specifier.
11808 Don't use xrealloc. Improve diagnostics when the %l size modifier
11809 is used. Update the commentary.
11810
11811 * eval.c (verror): Simplify calculation of size_t.
11812
11813 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
11814 messages.
11815
f61f41d7
PE
118162011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
11817
11818 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
11819 change.
11820
96fb4434
PE
118212011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11822
11823 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
11824 This makes this file independent of the recent pseudovector change.
11825
671875da 118262011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 11827
69e9b5a3
PE
11828 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
11829
b5f869a7 11830 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 11831 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 11832 Remove unused local.
c8926152 11833 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 11834
841a1577 11835 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
11836 GCC 4.6.0 optimizes based on type-based alias analysis.
11837 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
11838 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
11839 != &v->size, and therefore "v->size = 1; b->size = 2; return
11840 v->size;" must therefore return 1. This assumption is incorrect
11841 for Emacs, since it type-puns struct Lisp_Vector * with many other
11842 types. To fix this problem, this patch adds a new type struct
f904488f 11843 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
11844 and pseudovectors, and helps optimizing compilers not get fooled
11845 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
11846 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
11847 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
11848 the size member.
eab3844f
PE
11849 (XSETPVECTYPE): Rewrite in terms of new macro.
11850 (XSETPVECTYPESIZE): New macro, specifying both type and size.
11851 This is a bit clearer, and further avoids the possibility of
11852 undesirable aliasing.
11853 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 11854 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
11855 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
11856 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
11857 (ASIZE): Now uses header.size rather than size.
11858 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
11859 to avoid the hassle of writing XVECTOR (foo)->header.size.
11860 (struct vectorlike_header): New type.
eab3844f
PE
11861 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
11862 object, to help avoid aliasing.
11863 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
11864 (SUBRP): Likewise, since Lisp_Subr is a special case.
11865 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
11866 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
11867 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 11868 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
11869 changed to be "header.size" and "header.next".
11870 * buffer.h (struct buffer): Likewise.
11871 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
11872 * frame.h (struct frame): Likewise.
11873 * process.h (struct Lisp_Process): Likewise.
11874 * termhooks.h (struct terminal): Likewise.
11875 * window.c (struct save_window_data, struct saved_window): Likewise.
11876 * window.h (struct window): Likewise.
11877 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
11878 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
11879 * buffer.c (init_buffer_once): Likewise.
11880 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
11881 special case.
11882 * process.c (Fformat_network_address): Use local var for size,
11883 for brevity.
11884
0df1eac5
PE
11885 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
11886
847ab9d1 11887 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
11888 * data.c (atof): Remove decl; no longer used or needed.
11889 (digit_to_number): Move to lread.c.
11890 (Fstring_to_number): Use new string_to_number function, to be
11891 consistent with how the Lisp reader treats infinities and NaNs.
11892 Do not assume that floating-point numbers represent EMACS_INT
11893 without losing information; this is not true on most 64-bit hosts.
11894 Avoid double-rounding errors, by insisting on integers when
11895 parsing non-base-10 numbers, as the documentation specifies.
11896 * lisp.h (string_to_number): New decl, replacing ...
11897 (isfloat_string): Remove.
bc0a5c13 11898 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 11899 (read1): Do not accept +. and -. as integers; this
452f4150
PE
11900 appears to have been a coding error. Similarly, do not accept
11901 strings like +-1e0 as floating point numbers. Do not report
11902 overflow for integer overflows unless the base is not 10 which
11903 means we have no simple and reliable way to continue.
11904 Break out the floating-point parsing into a new
11905 function string_to_number, so that Fstring_to_number parses
11906 floating point numbers consistently with the Lisp reader.
04f2d78b 11907 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
11908 (E_CHAR, EXP_INT): Remove, replacing with ...
11909 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
11910 (string_to_number): New function, replacing isfloat_string.
11911 This function checks for valid syntax and produces the resulting
11912 Lisp float number too. Rework it so that string-to-number
bc0a5c13 11913 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
11914 so that overflow for non-base-10 numbers is reported only when
11915 there's no portable and simple way to convert to floating point.
452f4150 11916
67769ffc
PE
11917 * textprop.c (set_text_properties_1): Rewrite for clarity,
11918 and to avoid GCC warning about integer overflow.
11919
c20db43f
PE
11920 * intervals.h (struct interval): Use EMACS_INT for members
11921 where EMACS_UINT might cause problems. See
11922 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
11923 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
11924 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
11925 All uses changed.
37aa2f85
PE
11926 (offset_intervals): Tell GCC not to worry about length overflow
11927 when negating a negative length.
c20db43f 11928
2538aa2f
PE
11929 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
11930 (overrun_check_free): Likewise.
11931
f2d3008d
PE
11932 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
11933 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
11934 word size.
11935
ec8df744
PE
11936 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11937 (gnutls_make_error): Rename local to avoid shadowing.
11938 (gnutls_emacs_global_deinit): ifdef out; not used.
11939 (Fgnutls_boot): Use const for pointer to readonly storage.
11940 Comment out unused local. Fix pointer signedness problems.
11941
640ee02d
PE
11942 * lread.c (openp): Don't stuff size_t into an 'int'.
11943 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
11944 about possible signed overflow.
11945
6048fb2a
PE
11946 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11947 (GDK_KEY_g): Don't define if already defined.
11948 (xg_prepare_tooltip): Avoid pointer signedness problem.
11949 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
11950
fa3c87e1
PE
11951 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
11952 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
11953
2172544b
PE
11954 * xfns.c (Fx_window_property): Simplify a bit,
11955 to make a bit faster and to avoid GCC 4.6.0 warning.
11956 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
11957
9b821a21
PE
11958 * fns.c (internal_equal): Don't assume size_t fits in int.
11959
3c616cfa
PE
11960 * alloc.c (compact_small_strings): Tighten assertion a little.
11961
c2982e87
PE
11962 Replace pEd with more-general pI, and fix some printf arg casts.
11963 * lisp.h (pI): New macro, generalizing old pEd macro to other
11964 conversion specifiers. For example, use "...%"pI"d..." rather
11965 than "...%"pEd"...".
11966 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 11967 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
11968 * alloc.c (check_pure_size): Don't overflow by converting size to int.
11969 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
11970 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
11971 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
11972 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
11973 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
11974 64-bit hosts.
11975 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
11976 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
11977 * print.c (safe_debug_print, print_object): Likewise.
11978 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
11979 to int.
6f04d126
PE
11980 Use pI instead of if-then-else-abort. Use %p to avoid casts,
11981 avoiding the 0 flag, which is not portable.
c2982e87
PE
11982 * process.c (Fmake_network_process): Use pI to avoid cast.
11983 * region-cache.c (pp_cache): Likewise.
11984 * xdisp.c (decode_mode_spec): Likewise.
11985 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
11986 behavior on 64-bit hosts with printf arg.
6f04d126 11987 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
11988 (x_stop_queuing_selection_requests): Likewise.
11989 (x_get_window_property): Don't truncate byte count to an 'int'
11990 when tracing.
0b432f21 11991
5e073ec7
PE
11992 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
11993 here, since it parses constructs like leading '-' and spaces,
11994 which are not wanted; and it overflows with large numbers.
11995 Instead, simply match F[0-9]+, which is what is wanted anyway.
11996
36372bf9
PE
11997 * alloc.c: Remove unportable assumptions about struct layout.
11998 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
11999 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
12000 (allocate_vectorlike, make_pure_vector): Use the new macros,
12001 plus offsetof, to remove unportable assumptions about struct layout.
12002 These assumptions hold on all porting targets that I know of, but
12003 they are not guaranteed, they're easy to remove, and removing them
12004 makes further changes easier.
12005
0b432f21
PE
12006 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
12007 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
12008 (string_overrun_cookie): Now const. Use initializers that
12009 don't formally overflow signed char, to avoid warnings.
000098c1
PE
12010 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
12011 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
12012 (allocate_buffer): Don't assume sizeof (struct buffer) is a
12013 multiple of sizeof (EMACS_INT); it need not be, if
12014 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 12015 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 12016
895009e1
JB
120172011-04-26 Juanma Barranquero <lekktu@gmail.com>
12018
12019 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
12020
6a7a1b0b
TZ
120212011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
12022
12023 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 12024 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
12025 Reported by Paul Eggert <eggert@cs.ucla.edu>.
12026
841a1577 120272011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
12028
12029 * lisp.h (Qdebug): List symbol.
895009e1 12030 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
12031 * keyboard.c (debug-on-event): New variable.
12032 (handle_user_signal): Break into debugger when debug-on-event
12033 matches the current signal symbol.
12034
f2d3ba6f
DN
120352011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
12036
12037 * alloc.c (check_sblock, check_string_bytes)
12038 (check_string_free_list): Convert to standard C.
12039
42ce4c63
TZ
120402011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
12041
12042 * w32.c (emacs_gnutls_push): Fix typo.
12043
825cd63c
EZ
120442011-04-25 Eli Zaretskii <eliz@gnu.org>
12045
fb11d64d
EZ
12046 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
12047 "cast to pointer from integer of different size".
12048
825cd63c
EZ
12049 Improve doprnt and its use in verror. (Bug#8545)
12050 * doprnt.c (doprnt): Document the set of format control sequences
12051 supported by the function. Use SAFE_ALLOCA instead of always
12052 using `alloca'.
12053
12054 * eval.c (verror): Don't limit the buffer size at size_max-1, that
12055 is one byte too soon. Don't use xrealloc; instead xfree and
12056 xmalloc anew.
12057
e061a11b
TZ
120582011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
12059
12060 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
12061 callbacks stage.
12062
12063 * gnutls.c: Renamed global_initialized to
12064 gnutls_global_initialized. Added internals for the
12065 :verify-hostname-error, :verify-error, and :verify-flags
12066 parameters of `gnutls-boot' and documented those parameters in the
12067 docstring. Start callback support.
9173deec
JB
12068 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
12069 unless a fatal error occurred. Call gnutls_alert_send_appropriate
12070 on error. Return error code.
e061a11b
TZ
12071 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
12072 (emacs_gnutls_read): Likewise.
12073 (Fgnutls_boot): Return handshake error code.
12074 (emacs_gnutls_handle_error): New function.
12075 (wsaerror_to_errno): Likewise.
12076
12077 * w32.h (emacs_gnutls_pull): Add prototype.
12078 (emacs_gnutls_push): Likewise.
12079
12080 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
12081 (emacs_gnutls_push): Likewise.
12082
120832011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
12084
12085 * process.c (wait_reading_process_output): Check if GnuTLS
12086 buffered some data internally if no FDs are set for TLS
12087 connections.
12088
12089 * makefile.w32-in (OBJ2): Add gnutls.$(O).
12090 (LIBS): Link to USER_LIBS.
12091 ($(BLD)/gnutls.$(0)): New target.
12092
fa6996bc
EZ
120932011-04-24 Eli Zaretskii <eliz@gnu.org>
12094
eb35682e
EZ
12095 * xdisp.c (handle_single_display_spec): Rename the
12096 display_replaced_before_p argument into display_replaced_p, to
12097 make it consistent with the commentary. Fix typos in the
12098 commentary.
12099
e2ad650c
EZ
12100 * textprop.c (syms_of_textprop): Remove dead code.
12101 (copy_text_properties): Delete obsolete commentary about an
12102 interface that was deleted long ago. Fix typos in the description
12103 of arguments.
12104
1b2de274
EZ
12105 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
12106 to changes in oldXMenu/XMenu.h from 2011-04-16.
12107 <menu_help_message, prev_menu_help_message>: Constify.
12108 (IT_menu_make_room): menu->help_text is now `const char **';
12109 adjust.
12110
12111 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
12112 to changes in oldXMenu/XMenu.h from 2011-04-16.
12113 (struct XMenu): Declare `help_text' `const char **'.
12114
12115 * xfaces.c <Qunspecified>: Make extern again.
12116
12117 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 12118 required by POSIX.
1b2de274 12119
762b15be
EZ
12120 * doc.c (get_doc_string): Improve the format passed to `error'.
12121
12122 * doprnt.c (doprnt): Improve commentary.
12123
12124 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
12125
12126 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
12127 them with etags.
12128
f1052e5d
EZ
12129 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
12130 changes in globals.h immediately force recompilation.
762b15be
EZ
12131 (TAGS): Depend on $(CURDIR)/m/intel386.h and
12132 $(CURDIR)/s/ms-w32.h.
12133 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 12134
fa6996bc
EZ
12135 * character.c (Fchar_direction): Function deleted.
12136 (syms_of_character): Don't defsubr it.
12137 <char-direction-table>: Deleted.
12138
e6c3da20
EZ
121392011-04-23 Eli Zaretskii <eliz@gnu.org>
12140
12141 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
12142 * doprnt.c: Include limits.h.
12143 (SIZE_MAX): New macro.
04f2d78b
CB
12144 (doprnt): Return a size_t value. 2nd arg is now size_t.
12145 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
12146 Improve overflow protection. Support `l' modifier for integer
12147 conversions. Support %l conversion. Don't assume an EMACS_INT
12148 argument for integer conversions and for %c.
12149
12150 * lisp.h (doprnt): Restore prototype.
12151
12152 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
12153 $(SRC)/character.h.
12154
12155 * Makefile.in (base_obj): Add back doprnt.o.
12156
12157 * deps.mk (doprnt.o): Add back prerequisites.
12158 (callint.o): Depend on character.h.
12159
12160 * eval.c (internal_lisp_condition_case): Include the handler
12161 representation in the error message.
12162 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
12163 when breaking from the loop.
12164
12165 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
12166
12167 * callint.c (Fcall_interactively): When displaying error message
12168 about invalid control letter, pass the character's codepoint, not
12169 a pointer to its multibyte form. Improve display of the character
12170 in octal and display also its hex code.
12171
12172 * character.c (char_string): Use %x to display the (unsigned)
12173 codepoint of an invalid character, to avoid displaying a bogus
12174 negative value.
12175
12176 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
12177 `error', not SYMBOL_NAME itself.
12178
12179 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
12180 character arguments to `error'.
12181
12182 * charset.c (check_iso_charset_parameter): Fix incorrect argument
12183 to `error' in error message about FINAL_CHAR argument. Make sure
12184 FINAL_CHAR is a character, and use %c when it is passed as
12185 argument to `error'.
12186
4ffd0d6b 121872011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
12188
12189 * s/ms-w32.h (localtime): Redirect to sys_localtime.
12190
12191 * w32.c: Include <time.h>.
12192 (sys_localtime): New function.
12193
4ffd0d6b 121942011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
12195
12196 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
12197
4ffd0d6b 12198 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 12199
4ffd0d6b 122002011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 12201
4ffd0d6b
GM
12202 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
12203 zombies (Bug#8467).
aac0c6e3 12204
04c56954
EZ
122052011-04-19 Eli Zaretskii <eliz@gnu.org>
12206
12207 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
12208 gl_state.e_property when gl_state.object is Qt.
12209
12210 * insdel.c (make_gap_larger): Remove limitation of buffer size
12211 to <= INT_MAX.
12212
16a43933
CY
122132011-04-18 Chong Yidong <cyd@stupidchicken.com>
12214
12215 * xdisp.c (lookup_glyphless_char_display)
12216 (produce_glyphless_glyph): Handle cons cell entry in
12217 glyphless-char-display.
12218 (Vglyphless_char_display): Document it.
12219
12220 * term.c (produce_glyphless_glyph): Handle cons cell entry in
12221 glyphless-char-display.
12222
4581706e
CY
122232011-04-17 Chong Yidong <cyd@stupidchicken.com>
12224
12225 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
12226
12227 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
12228
12229 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
12230 definition for no-X builds.
12231
4887c6e2 122322011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 12233
fd35b6f9
PE
12234 Static checks with GCC 4.6.0 and non-default toolkits.
12235
5c1ccb01
PE
12236 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
12237
006c5daa
PE
12238 * process.c (keyboard_bit_set): Define only if SIGIO.
12239 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
12240 (send_process): Repair possible setjmp clobbering.
12241
efc736d3
PE
12242 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
12243
4e2fe2e6
PE
12244 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
12245
f97334a2
PE
12246 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
12247
4e75f29d
PE
12248 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
12249 Define only if needed.
12250
90efadd1
PE
12251 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
12252 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 12253 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 12254
3c647824
PE
12255 * dispextern.h (struct redisplay_interface): Rename param
12256 to avoid shadowing.
e264f262 12257 * termhooks.h (struct terminal): Likewise.
761383f4 12258 * xterm.c (xembed_send_message): Likewise.
3c647824 12259
b58c5c4a
PE
12260 * insdel.c (make_gap_smaller): Define only if
12261 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
12262
cad59032
PE
12263 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
12264 it.
12265
c339dc2e
PE
12266 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
12267 so that we aren't warned about unused symbols.
12268
91a3e27b
PE
12269 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
12270
399c71d3 12271 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 12272
8ffc96f5
PE
12273 * xfns.c (x_real_positions): Mark locals as initialized.
12274
eef9bc79
PE
12275 * xmenu.c (xmenu_show): Don't use uninitialized vars.
12276
098db9dd
PE
12277 * xterm.c: Fix problems found by static analysis with other toolkits.
12278 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
12279 (x_dispatch_event): Declare static if USE_GTK, and
12280 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 12281 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 12282 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
12283 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
12284 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 12285
eb18f6cc
PE
12286 * xmenu.c (menu_help_callback): Pointer type fixes.
12287 Use const pointers when pointing at readonly data. Avoid pointer
12288 signedness clashes.
12289 (FALSE): Remove unused macro.
12290 (update_frame_menubar): Remove unused decl.
12291
1fe72bf8
PE
12292 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
12293
60d9e1db
PE
12294 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
12295 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
12296 (single_menu_item): Rename local to avoid shadowing.
12297
39261c26
PE
12298 * keyboard.c (make_lispy_event): Remove unused local var.
12299
018c5e19
PE
12300 * frame.c, frame.h (x_get_resource_string): Bring this back, but
12301 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
12302
63d2b86e
PE
12303 * bitmaps: Change bitmaps from unsigned char back to the X11
12304 compatible char. Avoid the old compiler warnings about
12305 out-of-range initializers by using, for example, '\xab' rather
12306 than 0xab.
12307
aefd87e1
PE
12308 * xgselect.c (xgselect_initialize): Check vs interface
12309 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
12310
bf501fb9
PE
12311 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
12312
e9829fdf
PE
12313 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
12314 to read-only memory.
12315
1086c095
PE
12316 * fns.c (vector): Remove; this old hack is no longer needed.
12317
2baccd04 12318 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 12319 Remove unused var.
dde42981 12320 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 12321
72391843 12322 * xrdb.c (x_load_resources): Omit unused local.
3565b346 12323
436c16df 12324 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 12325 (x_window): Rename locals to avoid shadowing.
dc5ddd85 12326 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 12327
92bb796d 12328 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 12329 (x_term_init): Remove local to avoid shadowing.
92bb796d 12330
764430a3 12331 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
12332
12333 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
12334 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
12335
d1dfb56c
EZ
123362011-04-16 Eli Zaretskii <eliz@gnu.org>
12337
c4354cb4
EZ
12338 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
12339
d1dfb56c
EZ
12340 Fix regex.c, syntax.c and friends for buffers > 2GB.
12341 * syntax.h (struct gl_state_s): Declare character position members
12342 EMACS_INT.
12343
12344 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
12345
04f2d78b
CB
12346 * textprop.c (verify_interval_modification, interval_of):
12347 Declare arguments EMACS_INT.
d1dfb56c
EZ
12348
12349 * intervals.c (adjust_intervals_for_insertion): Declare arguments
12350 EMACS_INT.
12351
12352 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
12353
12354 * indent.c (Fvertical_motion): Local variable it_start is now
12355 EMACS_INT.
12356
12357 * regex.c (re_match, re_match_2, re_match_2_internal)
12358 (bcmp_translate, regcomp, regexec, print_double_string)
12359 (group_in_compile_stack, re_search, re_search_2, regex_compile)
12360 (re_compile_pattern, re_exec): Declare arguments and local
12361 variables `size_t' and `ssize_t' and return values `regoff_t', as
12362 appropriate.
12363 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
12364 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
12365 <compile_stack_type>: `size' and `avail' are now `size_t'.
12366
12367 * regex.h <regoff_t>: Use ssize_t, not int.
12368 (re_search, re_search_2, re_match, re_match_2): Arguments that
12369 specify buffer/string position and length are now ssize_t and
12370 size_t. Return type is regoff_t.
12371
613052cd
BK
123722011-04-16 Ben Key <bkey76@gmail.com>
12373
12374 * nsfont.m: Fixed bugs in ns_get_family and
12375 ns_descriptor_to_entity that were caused by using free to
12376 deallocate memory blocks that were allocated by xmalloc (via
12377 xstrdup). This caused Emacs to crash when compiled with
12378 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
12379 --enable-checking=xmallocoverrun). xfree is now used to
12380 deallocate these memory blocks.
12381
4170f62f 123822011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 12383
71b41406
PE
12384 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
12385
9587a89d
PE
12386 emacs_write: Accept and return EMACS_INT for sizes.
12387 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
12388 et seq.
12389 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
12390 Accept and return EMACS_INT.
12391 (emacs_gnutls_write): Return the number of bytes written on
12392 partial writes.
12393 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
12394 (emacs_read, emacs_write): Remove check for negative size, as the
12395 Emacs source code has been audited now.
9587a89d
PE
12396 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
12397 (emacs_read, emacs_write): Use it.
273a5f82
PE
12398 * process.c (send_process): Adjust to the new signatures of
12399 emacs_write and emacs_gnutls_write. Do not attempt to store
12400 a byte offset into an 'int'; it might overflow.
9587a89d 12401 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 12402
3e047f51
PE
12403 * sound.c: Don't assume sizes fit in 'int'.
12404 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 12405 Return EMACS_INT, not int.
3e047f51 12406 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
12407 Accept EMACS_INT, not int.
12408 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
12409 record read return values.
12410
cc39a9db
BK
124112011-04-15 Ben Key <bkey76@gmail.com>
12412
c9d0ec6d
JB
12413 * keyboard.c (Qundefined): Don't declare static since it is used
12414 in nsfns.m.
12415 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
12416 static since they are used in nsfont.m.
cc39a9db 12417
6c60eb9f
SM
124182011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
12419
12420 * process.c (Qprocessp): Don't declare static.
12421 * lisp.h (Qprocessp): Declare again.
12422
7990b61a
JB
124232011-04-15 Juanma Barranquero <lekktu@gmail.com>
12424
12425 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
12426
5d4cb038
PE
124272011-04-14 Paul Eggert <eggert@cs.ucla.edu>
12428
8bd7b830 12429 Improve C-level modularity by making more things 'static'.
cd64ea1d 12430
e3b27b31
PE
12431 Don't publish debugger-only interfaces to other modules.
12432 * lisp.h (safe_debug_print, debug_output_compilation_hack):
12433 (verify_bytepos, count_markers): Move decls to the only modules
12434 that need them.
12435 * region-cache.h (pp_cache): Likewise.
12436 * window.h (check_all_windows): Likewise.
12437 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
12438
5d4cb038
PE
12439 * sysdep.c (croak): Now static, if
12440 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
12441 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
12442
12443 * alloc.c (refill_memory_reserve): Now static if
12444 !defined REL_ALLOC || defined SYSTEM_MALLOC.
12445 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 12446
e87b6180
PE
12447 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
12448 Define only if USE_LUCID.
12449
ac64929e
PE
12450 * xrdb.c (x_customization_string, x_rm_string): Now static.
12451
6f37259d
PE
12452 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
12453 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
12454
1683e3ab
PE
12455 * xdisp.c (draw_row_with_mouse_face): Now static.
12456 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
12457
de9c2632
PE
12458 * window.h (check_all_windows): Mark externally visible.
12459
2b96acb7
PE
12460 * window.c (window_deletion_count): Now static.
12461
12462 * undo.c: Make symbols static if they're not exported.
12463 (last_undo_buffer, last_boundary_position, pending_boundary):
12464 Now static.
12465
50436f33
PE
12466 * textprop.c (interval_insert_behind_hooks): Now static.
12467 (interval_insert_in_front_hooks): Likewise.
12468
64520e5c
PE
12469 * term.c: Make symbols static if they're not exported.
12470 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
12471 (max_frame_lines, tty_set_terminal_modes):
12472 (tty_reset_terminal_modes, tty_turn_off_highlight):
12473 (get_tty_terminal): Now static.
12474 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
12475 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 12476 HAVE_WINDOW_SYSTEM.
64520e5c
PE
12477 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
12478 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
12479
1fa53021
PE
12480 * sysdep.c: Make symbols static if they're not exported.
12481 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
12482 Now static.
12483 (sigprocmask_set, full_mask): Remove; unused.
12484 (wait_debugging): Mark as visible.
12485 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
12486 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
12487
d4b43b22
PE
12488 * syntax.c (syntax_temp): Define only if !__GNUC__.
12489
b7c513d0
PE
12490 * sound.c (current_sound_device, current_sound): Now static.
12491
989b29ad
PE
12492 * search.c (searchbufs, searchbuf_head): Now static.
12493
13a55a78
PE
12494 * scroll.c (scroll_cost): Remove; unused.
12495 * dispextern.h (scroll_cost): Remove decl.
12496
de68a1fc
PE
12497 * region-cache.h (pp_cache): Mark as externally visible.
12498
40ccffa6
PE
12499 * process.c: Make symbols static if they're not exported.
12500 (process_tick, update_tick, create_process, chan_process):
12501 (Vprocess_alist, proc_buffered_char, datagram_access):
12502 (fd_callback_data, send_process_frame, process_sent_to): Now static.
12503 (deactivate_process): Mark defn as static, as well as decl.
12504 * lisp.h (create_process): Remove decl.
12505 * process.h (chan_process, Vprocess_alist): Remove decls.
12506
ad64fc97
PE
12507 * print.c: Make symbols static if they're not exported.
12508 (print_depth, new_backquote_output, being_printed, print_buffer):
12509 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
12510 (print_interval, print_number_index, initial_stderr_stream):
12511 Now static.
12512 * lisp.h (Fprinc): Remove decl.
12513 (debug_output_compilation_hack): Mark as externally visible.
12514
adddb265
PE
12515 * sysdep.c (croak): Move decl from here to syssignal.h.
12516 * syssignal.h (croak): Put it here, so the API can be checked when
12517 'croak' is called from dissociate_if_controlling_tty.
12518
1717ede2
PE
12519 * minibuf.c: Make symbols static if they're not exported.
12520 (minibuf_save_list, choose_minibuf_frame): Now static.
12521 * lisp.h (choose_minibuf_frame): Remove decl.
12522
fa5fb2bc
PE
12523 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
12524
1e3890d1
PE
12525 * lread.c: Make symbols static if they're not exported.
12526 (read_objects, initial_obarray, oblookup_last_bucket_number):
12527 Now static.
12528 (make_symbol): Remove; unused.
12529 * lisp.h (initial_obarray, make_symbol): Remove decls.
12530
8a1414fa
PE
12531 * keyboard.c: Make symbols static if they're not exported.
12532 (single_kboard, recent_keys_index, total_keys, recent_keys):
12533 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
12534 (this_single_command_key_start, echoing, last_auto_save):
12535 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
12536 (command_loop, echo_now, keyboard_init_hook, help_char_p):
12537 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
12538 (Vlispy_mouse_stem, double_click_count):
12539 Now static.
12540 (force_auto_save_soon): Define only if SIGDANGER.
12541 (ignore_mouse_drag_p): Now static if
12542 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
12543 (print_help): Remove; unused.
12544 (stop_character, last_timer_event): Mark as externally visible.
12545 * keyboard.h (ignore_mouse_drag_p): Declare only if
12546 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
12547 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
12548 * lisp.h (echoing): Remove decl.
12549 (force_auto_save_soon): Declare only if SIGDANGER.
12550 * xdisp.c (redisplay_window): Simplify code, to make it more
12551 obvious that ignore_mouse_drag_p is not accessed if !defined
12552 USE_GTK && !defined HAVE_NS.
12553
93ea6e8f
PE
12554 * intervals.c: Make symbols static if they're not exported.
12555 (merge_properties_sticky, merge_interval_right, delete_interval):
12556 Now static.
12557 * intervals.h (merge_interval_right, delete_interval): Remove decls.
12558
77382fcc
PE
12559 * insdel.c: Make symbols static if they're not exported.
12560 However, leave prepare_to_modify_buffer alone. It's never
12561 called from outside this function, but that appears to be a bug.
12562 (combine_after_change_list, combine_after_change_buffer):
4889fc82 12563 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
12564 (adjust_after_replace_noundo): Remove; unused.
12565 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 12566 (signal_before_change): Remove decls.
77382fcc 12567
9306c32e
PE
12568 * indent.c (val_compute_motion, val_vmotion): Now static.
12569
cd44d2eb
PE
12570 * image.c: Make symbols static if they're not exported.
12571 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
12572 if USE_GTK.
12573 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
12574 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
12575
ad9a7a06
PE
12576 * fringe.c (standard_bitmaps): Now static.
12577 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
12578
81626931
PE
12579 * frame.c: Make symbols static if they're not exported.
12580 (x_report_frame_params, make_terminal_frame): Now static.
12581 (get_frame_param): Now static, unless HAVE_NS.
12582 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
12583 (x_get_resource_string): Remove; not used.
12584 * frame.h (make_terminal_frame, x_report_frame_params):
12585 (x_get_resource_string); Remove decls.
12586 (x_fullscreen_adjust): Declare only if WINDOWSNT.
12587 * lisp.h (get_frame_param): Declare only if HAVE_NS.
12588
239f9db9
PE
12589 * font.c, fontset.c: Make symbols static if they're not exported.
12590 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
12591 (FACE_SUITABLE_FOR_CHAR_P): Use it.
12592 * font.c (font_close_object): Now static.
12593 * font.h (font_close_object): Remove.
12594 * fontset.c (FONTSET_OBJLIST): Remove.
12595 (free_realized_fontset) #if-0 the body, which does nothing.
12596 (face_suitable_for_char_p): #if-0, as it's never called.
12597 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
12598 * xfaces.c (face_at_string_position):
12599 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
12600 since 0 is always ASCII.
12601
dfcf3579
PE
12602 * fns.c (weak_hash_tables): Now static.
12603
5045092b
PE
12604 * fileio.c: Make symbols static if they're not exported.
12605 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
12606 (Vwrite_region_annotation_buffers): Now static.
12607
57a96f5c
PE
12608 * eval.c: Make symbols static if they're not exported.
12609 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
12610 * lisp.h (backtrace_list): Remove decl.
12611
35f08c38
PE
12612 * emacs.c: Make symbols static if they're not exported.
12613 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
12614 (fatal_error_code, fatal_error_signal_hook, standard_args):
12615 Now static.
12616 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
12617 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
12618 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
12619 * lisp.h (fatal_error_signal_hook): Remove decl.
12620 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
12621
f44bd759
PE
12622 * editfns.c: Move a (normally-unused) function to its only use.
12623 * editfns.c, lisp.h (get_operating_system_release): Remove.
12624 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
12625 worth the hassle of breaking this out.
12626
b532497d
PE
12627 * xterm.c: Make symbols static if they're not exported.
12628 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
12629 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
12630 (x_destroy_window, x_delete_display):
12631 Now static.
12632 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
12633 (x_mouse_leave): Remove; unused.
12634 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
12635 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
12636 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
12637 Remove decls.
12638 (x_mouse_leave): Declare only if WINDOWSNT.
12639 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
12640 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
12641 USE_X_TOOLKIT.
12642
1675728f
PE
12643 * ftxfont.c: Make symbols static if they're not exported.
12644 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
12645 HAVE_FREETYPE.
12646 * font.h (ftxfont_driver): Likewise.
12647
e4cebfca
PE
12648 * xfns.c: Make symbols static if they're not exported.
12649 (x_last_font_name, x_display_info_for_name):
12650 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
12651 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
12652 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
12653 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
12654 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
12655 (last_show_tip_args): Now static.
12656 (xic_defaut_fontset, xic_create_fontsetname): Define only if
12657 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
12658 (x_screen_planes): Remove; unused.
12659 * dispextern.h (x_screen_planes): Remove decl.
12660
5bf46f05
PE
12661 * dispnew.c: Make symbols static if they're not exported.
12662 * dispextern.h (redraw_garbaged_frames, scrolling):
12663 (increment_row_positions): Remove.
12664 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
12665 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
12666 Now static.
12667 (redraw_garbaged_frames): Remove; unused.
12668
435f4c28
PE
12669 * xfaces.c: Make symbols static if they're not exported.
12670 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
12671 Remove decls.
12672 * xterm.h (defined_color): Remove decls.
12673 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
12674 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
12675 (menu_face_changed_default, defined_color, free_realized_face):
12676 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
12677 (ascii_face_of_lisp_face): Remove; unused.
12678
8524aef3
PE
12679 * xdisp.c: Make symbols static if they're not exported.
12680 * dispextern.h (scratch_glyph_row, window_box_edges):
12681 (glyph_to_pixel_coords, set_cursor_from_row):
12682 (get_next_display_element, set_iterator_to_next):
12683 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
12684 (show_mouse_face): Remove decls
12685 * frame.h (message_buf_print): Likewise.
12686 * lisp.h (pop_message, set_message, check_point_in_composition):
12687 Likewise.
12688 * xterm.h (set_vertical_scroll_bar): Likewise.
12689 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
12690 (message_buf_print, scratch_glyph_row, displayed_buffer):
12691 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
12692 (get_next_display_element, show_mouse_face, window_box_edges):
12693 (frame_to_window_pixel_xy, check_point_in_composition):
12694 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
12695 (glyph_to_pixel_coords): Remove; unused.
12696
16390cd2
PE
12697 * dired.c (file_name_completion): Now static.
12698
12699 * dbusbind.c (xd_in_read_queued_messages): Now static.
12700
a25f4dfa
PE
12701 * lisp.h (circular_list_error, FOREACH): Remove; unused.
12702 * data.c (circular_list_error): Remove.
12703
14a9c8df
PE
12704 * commands.h (last_point_position, last_point_position_buffer):
12705 (last_point_position_window): Remove decls.
12706 * keyboard.c: Make these variables static.
12707
04f2d78b
CB
12708 * coding.h (coding, code_convert_region, encode_coding_gap):
12709 Remove decls.
74ab6df5
PE
12710 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
12711 (iso_code_class, detect_coding, code_convert_region): Now static.
12712 (encode_coding_gap): Remove; unused.
12713
38dfbee1
PE
12714 * chartab.c (chartab_chars, chartab_bits): Now static.
12715
a2cb4e63
PE
12716 * charset.h (charset_iso_8859_1): Remove decl.
12717 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
12718 Now static.
12719
127198fd
PE
12720 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
12721 * ccl.c (Vccl_program_table): Now static.
12722 (check_ccl_update): Remove; unused.
12723
d85b608f
PE
12724 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
12725 * category.h: ... from here.
12726 * category.c (check_category_table, set_category_set): Now static.
12727
31cd66f3
PE
12728 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
12729 * lisp.h: Remove these decls.
12730
c358e587
PE
12731 * buffer.c (buffer_count): Remove unused var.
12732
e78aecca
PE
12733 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
12734 so that it's not optimized away.
12735 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
12736 * dispextern.h (bidi_dump_cached_states): Remove, since it's
12737 exported only to the debugger.
12738
e192d7d3 12739 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 12740 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 12741
92470028
PE
12742 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
12743 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
12744 was inaccessible from Lisp.
12745 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
12746 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
12747
244ed907
PE
12748 alloc.c: Import and export fewer symbols, and remove unused items.
12749 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
12750 is defined.
12751 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
12752 it's not optimized away by whole-program optimization.
12753 (message_enable_multibyte, free_misc): Remove.
12754 (catchlist, handlerlist, mark_backtrace):
12755 Declare only if BYTE_MARK_STACK.
12756 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
12757 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
12758 (message_enable_multibyte): Remove decl.
12759 (free_misc, interval_free_list, float_block, float_block_index):
12760 (n_float_blocks, float_free_list, cons_block, cons_block_index):
12761 (cons_free_list, last_marked_index):
12762 Now static.
12763 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
12764 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
12765 (mark_backtrace): Define only if BYTE_MARK_STACK.
12766 * xdisp.c (message_enable_multibyte): Now static.
12767
61c2b50e 12768 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
12769 This makes it easier for human readers (and static analyzers)
12770 to see whether these variables are used from other modules.
12771 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
12772 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
12773 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
12774 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
12775 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
12776 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
12777 * xmenu.c, xselect.c:
12778 Declare Q* vars static if they are not used in other modules.
12779 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
12780 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
12781 Remove decls of unexported vars.
12782 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
12783
95c82688
PE
12784 * lisp.h (DEFINE_FUNC): Make sname 'static'.
12785
16a97296
PE
12786 Make Emacs functions such as Fatom 'static' by default.
12787 This makes it easier for human readers (and static analyzers)
12788 to see whether these functions can be called from other modules.
12789 DEFUN now defines a static function. To make the function external
12790 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
12791 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
12792 (Finit_image_library):
16a97296
PE
12793 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
12794 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
12795 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
12796 Remove decls, since these functions are now static.
12797 (Funintern, Fget_internal_run_time): New decls, since these functions
12798 were already external.
95c82688 12799
16a97296
PE
12800 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
12801 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
12802 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
12803 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
12804 * keyboard.c, keymap.c, lread.c:
12805 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
12806 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
12807 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
12808 Mark functions with DEFUE instead of DEFUN,
12809 if they are used in other modules.
12810 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
12811 decls for now-static functions.
12812 * buffer.h (Fdelete_overlay): Remove decl.
12813 * callproc.c (Fgetenv_internal): Mark as internal.
12814 * composite.c (Fremove_list_of_text_properties): Remove decl.
12815 (Fcomposition_get_gstring): New forward static decl.
12816 * composite.h (Fcomposite_get_gstring): Remove decl.
12817 * dired.c (Ffile_attributes): New forward static decl.
12818 * doc.c (Fdocumntation_property): New forward static decl.
12819 * eval.c (Ffetch_bytecode): New forward static decl.
12820 (Funintern): Remove extern decl; now in .h file where it belongs.
12821 * fileio.c (Fmake_symbolic_link): New forward static decl.
12822 * image.c (Finit_image_library): New forward static decl.
12823 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
12824 * intervals.h (Fprevious_property_change):
12825 (Fremove_list_of_text_properties): Remove decls.
12826 * keyboard.c (Fthis_command_keys): Remove decl.
12827 (Fcommand_execute): New forward static decl.
12828 * keymap.c (Flookup_key): New forward static decl.
12829 (Fcopy_keymap): Now static.
12830 * keymap.h (Flookup_key): Remove decl.
12831 * process.c (Fget_process): New forward static decl.
12832 (Fprocess_datagram_address): Mark as internal.
12833 * syntax.c (Fsyntax_table_p): New forward static decl.
12834 (skip_chars): Remove duplicate decl.
12835 * textprop.c (Fprevious_property_change): New forward static decl.
12836 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
12837 Now internal.
12838 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
12839 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
12840
785bbd42
PE
12841 * editfns.c (Fformat): Remove unreachable code.
12842
8b913b57
AS
128432011-04-14 Andreas Schwab <schwab@linux-m68k.org>
12844
12845 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
12846 change. (Bug#8496)
12847
a6744a35
EZ
128482011-04-13 Eli Zaretskii <eliz@gnu.org>
12849
12850 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
12851 when at ZV. (Bug#8487)
12852
e7974947
AS
128532011-04-12 Andreas Schwab <schwab@linux-m68k.org>
12854
baad03f0
AS
12855 * charset.c (Fclear_charset_maps): Use xfree instead of free.
12856 (Bug#8437)
12857 * keyboard.c (parse_tool_bar_item): Likewise.
12858 * sound.c (sound_cleanup, alsa_close): Likewise.
12859 * termcap.c (tgetent): Likewise.
12860 * xfns.c (x_default_font_parameter): Likewise.
12861 * xsettings.c (read_and_apply_settings): Likewise.
12862
e7974947
AS
12863 * alloc.c (overrun_check_malloc, overrun_check_realloc)
12864 (overrun_check_free): Protoize.
12865
28272684
PE
128662011-04-12 Paul Eggert <eggert@cs.ucla.edu>
12867
12868 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
12869 since callers should never pass a negative size.
12870 Change the signature to match that of plain 'read' and 'write'; see
12871 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
12872 * lisp.h: Update prototypes of emacs_write and emacs_read.
12873
11997c76
EZ
128742011-04-11 Eli Zaretskii <eliz@gnu.org>
12875
12876 * xdisp.c (redisplay_window): Don't try to determine the character
12877 position of the scroll margin if the window start point w->startp
e896f03c 12878 is outside the buffer's accessible region. (Bug#8468)
11997c76 12879
8a2cbd72
EZ
128802011-04-10 Eli Zaretskii <eliz@gnu.org>
12881
12882 Fix write-region and its subroutines for buffers > 2GB.
12883 * fileio.c (a_write, e_write): Modify declaration of arguments and
12884 local variables to support buffers larger than 2GB.
12885 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
12886
12887 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
12888 argument, local variables, and return value.
12889
12890 * lisp.h: Update prototypes of emacs_write and emacs_read.
12891
12892 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
12893
4073e537 128942011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 12895
1ebfdcb6
PE
12896 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
12897
b2ded58d
PE
12898 Fix more problems found by GCC 4.6.0's static checks.
12899
7d66342c
PE
12900 * xdisp.c (vmessage): Use a better test for character truncation.
12901
bbf47d44
PE
12902 * charset.c (load_charset_map): <, not <=, for optimization,
12903 and to avoid potential problems with integer overflow.
9248994d 12904 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 12905 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 12906 * editfns.c (Fformat): Likewise.
1e69125e 12907 * syntax.c (skip_chars): Likewise.
3befa583 12908
e3019616
PE
12909 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
12910 This also lets GCC 4.6.0 generate slightly better loop code.
12911
becfa255
PE
12912 * callint.c (Fcall_interactively): <, not <=, for optimization.
12913 (Fcall_interactively): Count the number of arguments produced,
12914 not the number of arguments given. This is simpler and lets GCC
12915 4.6.0 generate slightly better code.
12916
dae0cd48
PE
12917 * ftfont.c: Distingish more carefully between FcChar8 and char.
12918 The previous code passed unsigned char * to a functions like
12919 strlen and xstrcasecmp that expect char *, which does not
12920 conform to the C standard.
12921 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
12922 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
12923 char * when the C standard requires it.
12924
76032d70
PE
12925 * keyboard.c (read_char): Remove unused var.
12926
eb3f1cc8
PE
12927 * eval.c: Port to Windows vsnprintf (Bug#8435).
12928 Include <limits.h>.
12929 (SIZE_MAX): Define if the headers do not.
12930 (verror): Do not give up if vsnprintf returns a negative count.
12931 Instead, grow the buffer. This ports to Windows vsnprintf, which
12932 does not conform to C99. Problem reported by Eli Zaretskii.
12933 Also, simplify the allocation scheme, by avoiding the need for
12934 calling realloc, and removing the ALLOCATED variable.
12935
70476b54
PE
12936 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
12937
12020a9e
PE
12938 Remove invocations of doprnt, as Emacs now uses vsnprintf.
12939 But keep the doprint source code for now, as we might revamp it
12940 and use it again (Bug#8435).
ea6c7ae6
PE
12941 * lisp.h (doprnt): Remove.
12942 * Makefile.in (base_obj): Remove doprnt.o.
12943 * deps.mk (doprnt.o): Remove.
12944
5fdb398c
PE
12945 error: Print 32- and 64-bit integers portably (Bug#8435).
12946 Without this change, on typical 64-bit hosts error ("...%d...", N)
12947 was used to print both 32- and 64-bit integers N, which relied on
12948 undefined behavior.
61bdb816 12949 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
12950 * lisp.h (error, verror): Mark as printf-like functions.
12951 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
12952 Report overflow in size calculations when allocating printf buffer.
12953 Do not truncate output string at its first null byte.
12954 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
12955 Truncate the output at a character boundary, since vsnprintf does not
12956 do that.
12957 * charset.c (check_iso_charset_parameter): Convert internal
12958 character to string before calling 'error', since %c now has the
12959 printf meaning.
12960 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
12961 overflow when computing char to be passed to 'error'. Do not
12962 pass Lisp_Object to 'error'; pass the integer instead.
12963 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
12964 formatted with plain %d.
12965
b189fa66
PE
12966 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
12967
bff87ef0
PE
12968 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
12969
7e2cac20
PE
12970 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
12971
ce4d90b5
PE
12972 * xterm.c (x_catch_errors): Remove duplicate declaration.
12973
266c9547
PE
12974 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
12975
79c49ad2
PE
12976 * xdisp.c, lisp.h (message_nolog): Remove; unused.
12977
368f4090
JM
129782011-04-10 Jim Meyering <meyering@redhat.com>
12979
12980 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
12981 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
12982 return ssize_t not "int", and use size_t as the buffer length.
12983 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
12984 * gnutls.h: Update declarations.
12985 * process.c (read_process_output): Use ssize_t, to match.
12986 (send_process): Likewise.
12987
a32d4040
CY
129882011-04-09 Chong Yidong <cyd@stupidchicken.com>
12989
12990 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
12991
8546720e 129922011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 12993
04f2d78b
CB
12994 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
12995 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 12996
8546720e
GM
12997 * xterm.c (handle_one_xevent):
12998 * xmenu.c (create_and_show_popup_menu):
12999 * xselect.c (x_decline_selection_request)
13000 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 13001
0a2f5c1a 130022011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
13003
13004 Fix some uses of `int' instead of EMACS_INT.
13005 * search.c (string_match_1, fast_string_match)
13006 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
13007 (scan_buffer, find_next_newline_no_quit)
13008 (find_before_next_newline, search_command, Freplace_match)
13009 (Fmatch_data): Make some `int' variables be EMACS_INT.
13010
13011 * xdisp.c (display_count_lines): 3rd argument and return value now
13012 EMACS_INT. All callers changed.
13013 (pint2hrstr): Last argument is now EMACS_INT.
13014
13015 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
13016 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
13017 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
13018 (decode_coding_utf_16, decode_coding_emacs_mule)
13019 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
13020 (decode_coding_ccl, decode_coding_charset)
13021 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
13022 (decode_coding_iso_2022, decode_coding_emacs_mule)
13023 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
13024 <char_offset, last_offset>: Declare EMACS_INT.
13025 (encode_coding_utf_8, encode_coding_utf_16)
13026 (encode_coding_emacs_mule, encode_invocation_designation)
13027 (encode_designation_at_bol, encode_coding_iso_2022)
13028 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
13029 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
13030 Declare EMACS_INT.
13031 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
13032 (encode_invocation_designation): Last argument P_NCHARS is now
13033 EMACS_INT.
13034 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
13035 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
13036
13037 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
13038 All users changed.
13039
13040 * ccl.c (Fccl_execute_on_string): Declare some variables
13041 EMACS_INT.
13042
8546720e 130432011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
13044
13045 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
13046
4e19a977
CS
130472011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
13048
13049 * process.c (Fformat_network_address): Doc fix.
13050
87302331
R
130512011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
13052
ee7683eb 13053 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 13054
cbb59342
CY
130552011-04-08 Chong Yidong <cyd@stupidchicken.com>
13056
13057 * keyboard.c (read_char): Call Lisp function help-form-show,
13058 instead of using internal_with_output_to_temp_buffer.
13059 (Qhelp_form_show): New var.
e0d38eeb 13060 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
13061
13062 * print.c (internal_with_output_to_temp_buffer): Function deleted.
13063
13064 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
13065
e67a13ab
CY
130662011-04-06 Chong Yidong <cyd@stupidchicken.com>
13067
04f2d78b
CB
13068 * process.c (Flist_processes): Remove to Lisp.
13069 (list_processes_1): Delete.
e67a13ab 13070
973f782d
EZ
130712011-04-06 Eli Zaretskii <eliz@gnu.org>
13072
7c106b1e
EZ
13073 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
13074
973f782d
EZ
13075 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
13076
41cf7d1a 130772011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 13078
ca23cc88
PE
13079 Fix more problems found by GCC 4.6.0's static checks.
13080
f390e2d5
PE
13081 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
13082
42eea0d0
PE
13083 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
13084
b69769da 13085 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 13086
f9541e84
PE
13087 * xdisp.c (vmessage): Mark as a printf-like function.
13088
13841b55
PE
13089 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
13090
c136c10f
PE
13091 * sound.c (sound_warning): Don't crash if arg contains a printf format.
13092
5e2d4a30
PE
13093 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
13094 printf-like functions.
13095 (tiff_load): Add casts to remove these marks before passing them
13096 to system-supplied API.
13097
583f48b9
PE
13098 * eval.c (Fsignal): Remove excess argument to 'fatal'.
13099
b25d760e
PE
13100 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
13101 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
13102 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
13103 directly, rather than having caller test rule sign. This avoids
13104 some unnecessary tests.
13105 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
13106 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
13107 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 13108
bc7b6697 13109 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 13110 (xfont_open): Avoid unnecessary tests.
bc7b6697 13111
27ccc379
PE
13112 * composite.c (composition_gstring_put_cache): Use unsigned integer.
13113
dcd5c89a
PE
13114 * composite.h, composite.c (composition_gstring_put_cache):
13115 Use EMACS_INT, not int, for length.
13116
b13a45c6
PE
13117 * composite.h (COMPOSITION_DECODE_REFS): New macro,
13118 breaking out part of COMPOSITION_DECODE_RULE.
13119 (COMPOSITION_DECODE_RULE): Use it.
13120 * composite.c (get_composition_id): Remove unused local vars,
13121 by using the new macro.
13122
1e792e4d
PE
13123 * textprop.c (set_text_properties_1): Change while to do-while,
13124 since the condition is always true at first.
13125
dc6c6455 13126 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
13127 (interval_deletion_adjustment): Return unsigned value.
13128 All uses changed.
dc6c6455 13129
aba7731a
PE
13130 * process.c (list_processes_1, create_pty, read_process_output):
13131 (exec_sentinel): Remove vars that were set but not used.
afd4052b 13132 (create_pty): Remove unnecessary "volatile"s.
bc57d757 13133 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 13134 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 13135 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 13136
fdfc4bf3
PE
13137 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
13138
fca8fe46 13139 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 13140 (update_syntax_table): Use unsigned instead of int.
fca8fe46 13141
06a0259a 13142 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 13143 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 13144 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 13145
e7b9e80f
PE
13146 * print.c (print_error_message): Avoid int overflow.
13147
56201685
PE
13148 * font.c (font_list_entities): Redo for clarity,
13149 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
13150
78834453 13151 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 13152 (font_score): Avoid potential overflow in diff calculation.
78834453 13153
0bc0b309 13154 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 13155 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 13156
e610eaca
PE
13157 * eval.c (funcall_lambda): Rename local to avoid shadowing.
13158
b895abce
PE
13159 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
13160 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
13161 can always succeed if overflow has undefined behavior.
13162
1f1d9321 13163 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 13164 (wordify): Omit three unnecessary tests.
1f1d9321 13165
c59478bc
PE
13166 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
13167 All callers changed. This avoids the need for an unused var.
13168
79b73827
PE
13169 * casefiddle.c (casify_region): Remove var that is set but not used.
13170
a4db5dfe
PE
13171 * dired.c (file_name_completion): Remove var that is set but not used.
13172
43aae36e
PE
13173 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
13174
2a47c44d 13175 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 13176 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 13177
a37c69bf
PE
13178 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
13179 Check for integer overflow on size calculations.
13180
328ab8e7
PE
13181 * buffer.c (Fprevious_overlay_change): Remove var that is set
13182 but not used.
13183
e5a2a5cb
PE
13184 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
13185 Remove vars that are set but not used.
8d84a6eb 13186 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 13187 (timer_check_2): Mark vars as initialized.
e5a2a5cb 13188
a60e5f68
PE
13189 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
13190
f661cb61 13191 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 13192 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 13193
f0397f5a
PE
13194 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
13195 that are set but not used.
13196
8664db06 13197 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 13198 if XCreateBitmapFromData fails (Bug#8410).
8664db06 13199
6abdaa4a
PE
13200 * xselect.c (x_get_local_selection, x_handle_property_notify):
13201 Remove vars that are set but not used.
13202
0ce7538d 13203 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 13204 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 13205
9ae848fc
PE
13206 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
13207 Remove var that is set but not used.
0b918413
PE
13208 (scroll_bar_windows_size): Now size_t, not int.
13209 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
13210 Check for overflow.
9ae848fc 13211
a5a62657
PE
13212 * xfaces.c (realize_named_face): Remove vars that are set but not used.
13213 (map_tty_color) [!defined MSDOS]: Likewise.
13214
5c5cdd39
PE
13215 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
13216
66ebf983
PE
13217 * coding.c: Remove vars that are set but not used.
13218 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
13219 All callers changed.
13220 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
13221 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
13222 (decode_coding_charset): Remove vars that are set but not used.
13223
1be4d761
PE
13224 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
13225 that is set but not used.
13226
47553fa8
PE
13227 * print.c (print_object): Remove var that is set but not used.
13228
1f7196bf 13229 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
13230 The gnulib version avoids calling malloc in the usual case,
13231 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
13232 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
13233 * filelock.c (current_lock_owner): Likewise.
13234 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
13235 * sysdep.c: Include allocator.h, careadlinkat.h.
13236 (emacs_no_realloc_allocator): New static constant.
13237 (emacs_readlink): New function.
fdb61804
PE
13238 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
13239 ../lib/careadlinkat.h.
d1fdcab7 13240
f84c17c7
SM
132412011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
13242
13243 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
13244 first non-nil return value).
13245
ef3862ad
JD
132462011-04-03 Jan Djärv <jan.h.d@swipnet.se>
13247
13248 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
13249 if not defined (Bug#8403).
13250
376a7006
JB
132512011-04-02 Juanma Barranquero <lekktu@gmail.com>
13252
13253 * xdisp.c (display_count_lines): Remove parameter `start',
13254 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13255 (get_char_face_and_encoding): Remove parameter `multibyte_p',
13256 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13257 (fill_stretch_glyph_string): Remove parameters `row' and `area',
13258 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
13259 and thereabouts. All callers changed.
13260 (get_per_char_metric): Remove parameter `f', unused since
13261 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13262
6ca3801d
JM
132632011-04-02 Jim Meyering <meyering@redhat.com>
13264
13265 do not dereference NULL upon failed strdup
13266 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
13267 (ns_get_family): Likewise.
13268
d8e2b5ba
JB
132692011-04-02 Juanma Barranquero <lekktu@gmail.com>
13270
13271 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
13272
8c74fcbd
JD
132732011-04-02 Jan Djärv <jan.h.d@swipnet.se>
13274
13275 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
13276 later (Bug#8403).
13277
7200d79c
SM
132782011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
13279
03408648 13280 Add lexical binding.
7200d79c 13281
03408648
SM
13282 * window.c (Ftemp_output_buffer_show): New fun.
13283 (Fsave_window_excursion):
13284 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
13285
13286 * lread.c (lisp_file_lexically_bound_p): New function.
13287 (Fload): Bind Qlexical_binding.
13288 (readevalloop): Remove `evalfun' arg.
13289 Bind Qinternal_interpreter_environment.
13290 (Feval_buffer): Bind Qlexical_binding.
13291 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
13292 Mark as dynamic.
13293 (syms_of_lread): Declare `lexical-binding'.
13294
13295 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
13296
13297 * keyboard.c (eval_dyn): New fun.
13298 (menu_item_eval_property): Use it.
ca105506
SM
13299
13300 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 13301
03408648
SM
13302 * fns.c (concat, mapcar1): Accept byte-code-functions.
13303
13304 * eval.c (Fsetq): Handle lexical vars.
13305 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
13306 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
13307 (FletX, Flet): Obey lexical binding.
13308 (Fcommandp): Handle closures.
13309 (Feval): New `lexical' arg.
13310 (eval_sub): New function extracted from Feval. Use it almost
13311 everywhere where Feval was used. Look up vars in lexical env.
13312 Handle closures.
13313 (Ffunctionp): Move from subr.el.
13314 (Ffuncall): Handle closures.
13315 (apply_lambda): Remove `eval_flags'.
13316 (funcall_lambda): Handle closures and new byte-code-functions.
13317 (Fspecial_variable_p): New function.
13318 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
13319 but without exporting it to Lisp.
23aba0ea 13320
23aba0ea 13321 * doc.c (Fdocumentation, store_function_docstring):
03408648 13322 * data.c (Finteractive_form): Handle closures.
23aba0ea 13323
03408648
SM
13324 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
13325 interactive spec.
ba83908c 13326
04f2d78b
CB
13327 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
13328 New byte-codes.
03408648
SM
13329 (exec_byte_code): New function extracted from Fbyte_code to handle new
13330 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 13331
03408648 13332 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 13333
03408648 13334 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 13335
e2abce01
JB
133362011-03-31 Juanma Barranquero <lekktu@gmail.com>
13337
13338 * xdisp.c (redisplay_internal): Fix prototype.
13339
63696a73 133402011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 13341
63696a73 13342 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
13343 (try_scrolling): Use it when setting scroll_limit.
13344 Limit scrolling to 100 screen lines.
63696a73
EZ
13345 (redisplay_window): Even when falling back on "recentering",
13346 position point in the window according to scroll-conservatively,
13347 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
13348
13349 (try_scrolling): When point is above the window, allow searching
13350 as far as scroll_max, or one screenful, to compute vertical
13351 distance from PT to the scroll margin position. This prevents
13352 try_scrolling from unnecessarily failing when
13353 scroll-conservatively is set to a value slightly larger than the
13354 window height. Clean up the case of PT below the margin at bottom
13355 of window: scroll_max can no longer be INT_MAX. When aggressive
13356 scrolling is in use, don't let point enter the opposite scroll
13357 margin as result of the scroll.
13358 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
13359 threshold of 100 lines for never-recentering scrolling.
13360
e4cc2dfc
JB
133612011-03-31 Juanma Barranquero <lekktu@gmail.com>
13362
13363 * dispextern.h (move_it_by_lines):
13364 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
13365 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
13366 (message_log_check_duplicate): Remove parameters `prev_bol' and
13367 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13368 (redisplay_internal): Remove parameter `preserve_echo_area',
13369 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
13370
13371 * indent.c (Fvertical_motion):
13372 * window.c (window_scroll_pixel_based, Frecenter):
13373 Don't pass `need_y_p' to `move_it_by_lines'.
13374
1c470562
SM
133752011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
13376
44f230aa
SM
13377 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
13378 steal a few bits to be more compact.
13379 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
13380 Remove unneeded casts.
13381
1c470562
SM
13382 * bytecode.c (Fbyte_code): CAR and CDR can GC.
13383
888adce9
ZK
133842011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
13385
13386 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
13387 binding" message (bug#7967).
13388
f838ed7b
PE
133892011-03-30 Paul Eggert <eggert@cs.ucla.edu>
13390
77861b95
PE
13391 Fix more problems found by GCC 4.6.0's static checks.
13392
de6dbc14
PE
13393 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
13394 Remove unused local var.
13395
f838ed7b
PE
13396 * editfns.c (Fmessage_box): Remove unused local var.
13397
792c7b2b
PE
13398 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
13399 (note_mode_line_or_margin_highlight, note_mouse_highlight):
13400 Omit unused local vars.
c499e557 13401 * window.c (shrink_windows): Omit unused local var.
b01a1c29 13402 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
13403 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
13404 Omit unused local var.
13405
ba0165e1
PE
13406 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
13407 Don't assume string length fits in int.
32ad8845 13408 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 13409 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 13410
3c59b4c9
PE
13411 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
13412 instead of alloca (Bug#8344).
13413
a3eed478 13414 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 13415 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 13416
eb4d412d
PE
13417 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
13418
1658b401
PE
13419 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
13420 concerns.
13421
13422 * term.c (produce_glyphless_glyph): Remove unnecessary test.
13423
13424 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 13425
9a2c6e05
PE
13426 * keyboard.c (syms_of_keyboard): Use the same style as later
13427 in this function when indexing through an array. This also
13428 works around GCC bug 48267.
13429
03d0a109
PE
13430 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
13431
44f730c8
PE
13432 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
13433
fe75f926
PE
13434 * chartab.c (sub_char_table_ref_and_range): Redo for slight
13435 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
13436
ffa8c828
PE
13437 * keyboard.c, keyboard.h (num_input_events): Now size_t.
13438 This avoids undefined behavior on integer overflow, and is a bit
13439 more convenient anyway since it is compared to a size_t variable.
13440
c5101a77
PE
13441 Variadic C functions now count arguments with size_t, not int.
13442 This avoids an unnecessary limitation on 64-bit machines, which
13443 caused (substring ...) to crash on large vectors (Bug#8344).
13444 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
13445 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 13446 All variadic functions and their callers changed accordingly.
c5101a77
PE
13447 (struct gcpro.nvars): Now size_t, not int. All uses changed.
13448 * data.c (arith_driver, float_arith_driver): Likewise.
13449 * editfns.c (general_insert_function): Likewise.
13450 * eval.c (struct backtrace.nargs, interactive_p)
13451 (internal_condition_case_n, run_hook_with_args, apply_lambda)
13452 (funcall_lambda, mark_backtrace): Likewise.
13453 * fns.c (concat): Likewise.
13454 * frame.c (x_set_frame_parameters): Likewise.
13455 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
13456 0 if not found, not -1. All callers changed.
13457
dd3f25f7
PE
13458 * alloc.c (garbage_collect): Don't assume stack size fits in int.
13459 (stack_copy_size): Now size_t, not int.
13460 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
13461
461c2ab9
JB
134622011-03-28 Juanma Barranquero <lekktu@gmail.com>
13463
13464 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
13465 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13466 All callers changed.
13467
13468 * lisp.h (multibyte_char_to_unibyte):
13469 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
13470 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13471 * character.h (CHAR_TO_BYTE8):
13472 * cmds.c (internal_self_insert):
13473 * editfns.c (general_insert_function):
13474 * keymap.c (push_key_description):
13475 * search.c (Freplace_match):
13476 * xdisp.c (message_dolog, set_message_1): All callers changed.
13477
f6d62986
SM
134782011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
13479
13480 * keyboard.c (safe_run_hook_funcall): New function.
13481 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
13482 don't set the hook to nil, but remove the offending function instead.
13483 (Qcommand_hook_internal): Remove, unused.
13484 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
13485 Vcommand_hook_internal.
13486
13487 * eval.c (enum run_hooks_condition): Remove.
13488 (funcall_nil, funcall_not): New functions.
13489 (run_hook_with_args): Call each function through a `funcall' argument.
13490 Remove `cond' argument, now redundant.
13491 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
13492 (Frun_hook_with_args_until_failure): Adjust accordingly.
13493 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
13494
1db5b1ad
JB
134952011-03-28 Juanma Barranquero <lekktu@gmail.com>
13496
13497 * dispextern.h (string_buffer_position): Remove declaration.
13498
13499 * print.c (strout): Remove parameter `multibyte', unused since
13500 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
13501
13502 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
13503 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
13504 All callers changed.
13505
13506 * w32.c (_wsa_errlist): Use braces for struct initializers.
13507
13508 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
13509 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
13510 All callers changed.
13511 (string_buffer_position): Likewise. Also, make static (it's never
13512 used outside xdisp.c).
13513 (cursor_row_p): Remove parameter `w', unused since
13514 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
13515 (decode_mode_spec): Remove parameter `precision', introduced during
13516 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
13517 All callers changed.
13518
5ffb62aa
JD
135192011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13520
13521 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
13522
461c2ab9 135232011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
13524
13525 * nsterm.m (ns_menu_bar_is_hidden): New variable.
13526 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
13527 (ns_update_auto_hide_menu_bar): New functions.
13528 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
13529 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
13530 ns_constrain_all_frames.
13531 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
13532 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
13533
5c380ffb
JD
135342011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13535
13536 * nsmenu.m (runDialogAt): Remove argument to timer_check.
13537
9af30bdf
GM
135382011-03-27 Glenn Morris <rgm@gnu.org>
13539
13540 * syssignal.h: Replace RETSIGTYPE with void.
13541 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
13542 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
13543 Replace SIGTYPE with void everywhere.
13544 * s/usg5-4-common.h (SIGTYPE): Remove definition.
13545 * s/template.h (SIGTYPE): Remove commented out definition.
13546
e2abce01
JB
135472011-03-26 Eli Zaretskii <eliz@gnu.org>
13548
13549 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
13550 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
13551
f868cd8a
JB
135522011-03-26 Juanma Barranquero <lekktu@gmail.com>
13553
59eb0929
JB
13554 * w32.c (read_unc_volume): Use parameter `henum', instead of
13555 global variable `wget_enum_handle'.
13556
13557 * keymap.c (describe_vector): Remove parameters `indices' and
13558 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
13559 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
13560
f868cd8a
JB
13561 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
13562
13563 * keyboard.c (timer_check): Remove parameter `do_it_now',
13564 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
13565 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
13566 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
13567
13568 * keyboard.c (read_char):
13569 * w32menu.c (w32_menu_display_help):
13570 * xmenu.c (show_help_event, menu_help_callback):
13571 Adjust calls to `show_help_echo'.
13572
13573 * gtkutil.c (xg_maybe_add_timer):
13574 * keyboard.c (readable_events):
13575 * process.c (wait_reading_process_output):
13576 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
13577
13578 * insdel.c (adjust_markers_gap_motion):
13579 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
13580 (gap_left, gap_right): Don't call it.
13581
2ecf6fdb
CY
135822011-03-25 Chong Yidong <cyd@stupidchicken.com>
13583
13584 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
13585 incurred during fontification.
13586
6b1f9ba4
JB
135872011-03-25 Juanma Barranquero <lekktu@gmail.com>
13588
13589 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
13590 (DEFVAR_PER_BUFFER): Don't pass it.
13591
13592 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
13593 (scrolling_window): Don't pass it.
13594
0f4a96b5
JB
135952011-03-25 Juanma Barranquero <lekktu@gmail.com>
13596
13597 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
13598
13599 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
13600 and `suffix'.
13601 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
13602 of variables specific to SELinux and computation of `encoded_absname'.
13603
13604 * image.c (XPutPixel): Remove unused variable `height'.
13605
13606 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
13607
13608 * unexw32.c (get_section_info): Remove unused variable `section'.
13609
13610 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
13611 (system_process_attributes): Remove unused variable `sess'.
13612 (sys_read): Remove unused variable `err'.
13613
13614 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
13615 (w32_wnd_proc): Remove unused variable `isdead'.
13616 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
13617 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
13618 (x_create_tip_frame): Remove unused variable `tem'.
13619
13620 * w32inevt.c (w32_console_read_socket):
13621 Remove unused variable `no_events'.
13622
13623 * w32term.c (x_draw_composite_glyph_string_foreground):
13624 Remove unused variable `width'.
13625
1149507c
JB
136262011-03-24 Juanma Barranquero <lekktu@gmail.com>
13627
13628 * w32term.c (x_set_glyph_string_clipping):
13629 Don't pass uninitialized region to CombineRgn.
13630
9c88f339
JB
136312011-03-23 Juanma Barranquero <lekktu@gmail.com>
13632
13633 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
13634 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
13635 (Fx_close_connection): Remove unused variable `i'.
13636
13637 * w32font.c (w32font_draw): Return number of glyphs.
13638 (w32font_open_internal): Remove unused variable `i'.
13639 (w32font_driver): Add missing initializer.
13640
13641 * w32menu.c (utf8to16): Remove unused variable `utf16'.
13642 (fill_in_menu): Remove unused variable `items_added'.
13643
13644 * w32term.c (last_mouse_press_frame): Remove static global variable.
13645 (w32_clip_to_row): Remove unused variable `f'.
13646 (x_delete_terminal): Remove unused variable `i'.
13647
13648 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
13649 (NOTHING): Remove unused static global variable.
13650 (uniscribe_check_otf): Remove unused variable `table'.
13651 (uniscribe_font_driver): Add missing initializers.
13652
dee091a3
JD
136532011-03-23 Julien Danjou <julien@danjou.info>
13654
13655 * term.c (Fsuspend_tty, Fresume_tty):
13656 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
13657 * window.c (temp_output_buffer_show):
13658 * insdel.c (signal_before_change):
13659 * frame.c (Fhandle_switch_frame):
13660 * fileio.c (Fdo_auto_save):
13661 * emacs.c (Fkill_emacs):
13662 * editfns.c (save_excursion_restore):
13663 * cmds.c (internal_self_insert):
13664 * callint.c (Fcall_interactively):
13665 * buffer.c (Fkill_all_local_variables):
13666 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
13667 Use Frun_hooks.
0f4a96b5 13668 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 13669 unconditionally since it does the check itself.
dee091a3 13670
2c520ab5 136712011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 13672
c9c49752
PE
13673 Fix more problems found by GCC 4.5.2's static checks.
13674
8abc3f12
PE
13675 * coding.c (encode_coding_raw_text): Avoid unnecessary test
13676 the first time through the loop, since we know p0 < p1 then.
13677 This also avoids a gcc -Wstrict-overflow warning.
13678
a2d26660
PE
13679 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
13680 leading to a memory leak, possible in functions like
13681 load_charset_map_from_file that can allocate an unbounded number
b12ef411 13682 of objects (Bug#8318).
a2d26660 13683
916c72e9
PE
13684 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
13685 that could (at least in theory) be that large.
13686
19ab8a18
PE
13687 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
13688 This is less likely to overflow, and avoids undefined behavior if
13689 overflow does occur. All callers changed. Use strtoul to scan
13690 for the unsigned long integer.
b7cbbd6f
PE
13691 (pint2hrstr): Simplify and tune code slightly.
13692 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 13693
f0641eff
PE
13694 * scroll.c (do_scrolling): Work around GCC bug 48228.
13695 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
13696
7f650bb9
PE
13697 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
13698 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
13699 (validate_x_resource_name): Simplify count usage.
13700 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 13701
37dd57d1
PE
13702 * fileio.c (Fcopy_file): Report error if fchown or fchmod
13703 fail (Bug#8306).
81e56e61 13704
699979fc 13705 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 13706
401bf9b4
PE
13707 * process.c (Fmake_network_process): Use socklen_t, not int,
13708 where POSIX says socklen_t is required in portable programs.
13709 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 13710 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
13711 (Fmake_network_process, server_accept_connection):
13712 (wait_reading_process_output, read_process_output):
13713 Likewise.
13714
b93aacde
PE
13715 * process.c: Rename or move locals to avoid shadowing.
13716 (list_processes_1, Fmake_network_process):
13717 (read_process_output_error_handler, exec_sentinel_error_handler):
13718 Rename or move locals.
4dc343ee 13719 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 13720 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 13721 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 13722 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 13723 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 13724
af8a867c 13725 Make tparam.h and terminfo.c consistent.
44f230aa
SM
13726 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
13727 Include tparam.h instead, since it declares them.
af8a867c
PE
13728 * cm.h (PC): Remove extern decl; tparam.h now does this.
13729 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
13730 * terminfo.c: Include tparam.h, to check interfaces.
13731 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
13732 (tparam): Adjust signature to match interface in tparam.h;
13733 this removes some undefined behavior. Check that outstring and len
13734 are zero, which they always are with Emacs.
13735 * tparam.h (PC, BC, UP): New extern decls.
13736
0248044d 13737 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 13738 (xftfont_open): Rename locals to avoid shadowing.
0248044d 13739
8ff096c1 13740 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
13741 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
13742 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 13743 (ftfont_list): Remove unused local.
49eaafba
PE
13744 (get_adstyle_property, ftfont_pattern_entity):
13745 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
13746 Rename locals to avoid shadowing.
8ff096c1 13747
e2be39f6
PE
13748 * xfont.c (xfont_list_family): Mark var as initialized.
13749
c9735e30
PE
13750 * xml.c (make_dom): Now static.
13751
8f5201ae
PE
13752 * composite.c (composition_compute_stop_pos): Rename local to
13753 avoid shadowing.
b246f932
PE
13754 (composition_reseat_it): Remove unused locals.
13755 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 13756 (composition_update_it): Mark var as initialized.
11b61122
PE
13757 (find_automatic_composition): Mark vars as initialized,
13758 with a FIXME (Bug#8290).
8f5201ae 13759
760fbc2c
PE
13760 character.h: Rename locals to avoid shadowing.
13761 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
13762 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
13763 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
13764 (BUF_DEC_POS): Be more systematic about renaming local temporaries
13765 to avoid shadowing.
13766
ff08eb85
PE
13767 * textprop.c (property_change_between_p): Remove; unused.
13768
fc7bf025
PE
13769 * intervals.c (interval_start_pos): Now static.
13770
235d7abc
PE
13771 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
13772
44f230aa
SM
13773 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
13774 Rename locals to avoid shadowing.
3e7d6594 13775
50060332
PE
13776 * sound.c (wav_play, au_play, Fplay_sound_internal):
13777 Fix pointer signedness.
d01f234b 13778 (alsa_choose_format): Remove unused local var.
c83b8872
PE
13779 (wav_play): Initialize a variable to 0, to prevent undefined
13780 behavior (Bug#8278).
50060332 13781
c4fc4e30
PE
13782 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
13783
918436ed
PE
13784 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
13785
c939f91b
PE
13786 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
13787 clobbering (Bug#8298).
b9c7f648
PE
13788 * sysdep.c (sys_subshell): Likewise.
13789 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 13790
6bd8c144
PE
13791 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
13792 This should get cleaned up, so that child_setup has the
13793 same signature on all platforms.
13794
7710357c 13795 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 13796 (relocate_fd): Rename locals to avoid shadowing.
7710357c 13797
c59da222
CY
137982011-03-22 Chong Yidong <cyd@stupidchicken.com>
13799
13800 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
13801 not to be necessary, and produces flickering.
13802
66b87493
GM
138032011-03-20 Glenn Morris <rgm@gnu.org>
13804
13805 * config.in: Remove file.
13806
45b6f6d5
JB
138072011-03-20 Juanma Barranquero <lekktu@gmail.com>
13808
13809 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
13810 are now in src/globals.h.
13811 (syms_of_minibuf): Remove spurious & from previous change.
13812
cd394be1 138132011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
13814
13815 * minibuf.c (completing-read-function): New variable.
13816 (completing-read-default): Rename from completing-read.
13817 (completing-read): Call completing-read-function.
13818
b14e3e21
CY
138192011-03-19 Juanma Barranquero <lekktu@gmail.com>
13820
13821 * xfaces.c (Fx_load_color_file):
13822 Read color file from absolute filename (bug#8250).
13823
f2b726e6
JB
138242011-03-19 Juanma Barranquero <lekktu@gmail.com>
13825
13826 * makefile.w32-in: Update dependencies.
13827
09f6ff02
EZ
138282011-03-17 Eli Zaretskii <eliz@gnu.org>
13829
13830 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
13831
29a6015a
PE
138322011-03-17 Paul Eggert <eggert@cs.ucla.edu>
13833
a3a6c54e
PE
13834 Fix more problems found by GCC 4.5.2's static checks.
13835
b766f867
PE
13836 * process.c (make_serial_process_unwind, send_process_trap):
13837 (sigchld_handler): Now static.
13838
be02381c
PE
13839 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
13840 That way, the code declares only the vars that it needs.
13841 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
13842 * s/cygwin.h (PTY_ITERATION): Likewise.
13843 * s/darwin.h (PTY_ITERATION): Likewise.
13844 * s/gnu-linux.h (PTY_ITERATION): Likewise.
13845
57048744
PE
13846 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
13847 * process.c (allocate_pty): Don't declare stb unless it's needed.
13848
7914961c 13849 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
13850 (CONSTANTLIM): Remove; unused.
13851 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
13852 Define only if needed.
7914961c 13853
b3967b18
PE
13854 * unexelf.c (unexec): Name an expression,
13855 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
13856 Use a different way to cause a compilation error if anyone uses
13857 n rather than nn, a way that does not involve shadowing.
73366a00 13858 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 13859
29a6015a
PE
13860 * deps.mk (unexalpha.o): Remove; unused.
13861
43cfc33e 13862 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 13863 * unexec.h: New file.
ce701a33
PE
13864 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
13865 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
13866 Depend on unexec.h.
13867 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
13868 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
13869 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 13870 Change as necessary to match prototype in unexec.h.
ce701a33 13871
01f44d5a
PE
13872 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
13873 shadowing.
4f63c6bb 13874 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 13875
a6670b0b
PE
13876 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
13877 Rename locals to avoid shadowing.
13878
cef2010d 13879 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 13880 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 13881
d4d7173a
PE
13882 * print.c (Fredirect_debugging_output): Fix pointer signedess.
13883
f08b802a
PE
13884 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
13885 warning when compiling print.c.
13886
3ddb0639
PE
13887 * font.c (font_unparse_fcname): Abort in an "impossible" situation
13888 instead of using an uninitialized var.
5ad03b97 13889 (font_sort_entities): Mark var as initialized.
3ddb0639 13890
170a2692
PE
13891 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
13892
e663c700
PE
13893 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
13894 pointers to constants.
89bc529a 13895 (font_parse_fcname): Remove unused vars.
7b81e2d0 13896 (font_delete_unmatched): Now static.
ea838e10 13897 (font_get_spec): Remove; unused.
13a547c6
PE
13898 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
13899 (font_update_drivers, Ffont_get_glyphs, font_add_log):
13900 Rename or move locals to avoid shadowing.
e663c700 13901
2a80c887 13902 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 13903 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 13904
1384fa33 13905 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 13906 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 13907
8b2c52e9
PE
13908 * alloc.c (mark_backtrace): Move decl from here ...
13909 * lisp.h: ... to here, so that it can be checked.
13910
475545b5 13911 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 13912 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
13913 (lisp_indirect_variable): Name an expression,
13914 to avoid gcc -Wbad-function-cast warning.
1faed8ae 13915 (Fdefvar): Rename locals to avoid shadowing.
475545b5 13916
b1349114 13917 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 13918 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 13919 Use const pointer when appropriate.
b1349114 13920
a2928364
PE
13921 * lisp.h (get_system_name, get_operating_system_release):
13922 Move decls here, to check interfaces.
13923 * process.c (get_operating_system_release): Move decl to lisp.h.
13924 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
13925 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
13926 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
13927 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
13928 (Fformat_time_string, Fencode_time, Finsert_char):
13929 (Ftranslate_region_internal, Fformat):
13930 Rename or remove local vars to avoid shadowing.
9710023e 13931 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 13932
a415e694
PE
13933 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
13934 avoid shadowing.
13935
8ef4622d
PE
13936 * lisp.h (eassert): Check that the argument compiles, even if
13937 ENABLE_CHECKING is not defined.
13938
946f9a5b
PE
13939 * data.c (Findirect_variable): Name an expression, to avoid
13940 gcc -Wbad-function-cast warning.
112396d6 13941 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 13942 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
13943 (Fmake_variable_buffer_local, Fmake_local_variable):
13944 Mark variables as initialized.
52746918 13945 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 13946
e5aab7e7 13947 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
13948 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
13949 Rename locals to avoid shadowing.
dff45157
PE
13950 (mark_stack): Move local variables into the #ifdef region where
13951 they're used.
7bc26fdb
PE
13952 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
13953 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
13954 needed otherwise.
13955 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
13956 (GC_STRING_CHARS): Remove; not used.
d40d4be1 13957 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 13958
e5aab7e7
PE
13959 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
13960 avoids undefined behavior in theory.
13961
4da60324
PE
13962 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
13963
88043301
PE
13964 Use functions, not macros, for up- and down-casing (Bug#8254).
13965 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13966 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
13967 to use the following functions instead of these macros.
13968 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
13969 EMACS_INT, since callers assume the returned value fits in int.
13970 (upcase1): Likewise, for UPCASE_TABLE.
13971 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 13972 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 13973 the race-condition problem in the old DOWNCASE.
88043301 13974
19ed5445
PE
13975 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
13976 Rename locals to avoid shadowing.
13977 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
13978 (regex_compile, re_search_2, re_match_2_internal):
13979 Remove unused local vars.
952db0d7
PE
13980 (FREE_VAR): Rewrite so as not to use empty "else",
13981 which gcc can warn about.
da053e48 13982 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
13983 (RETALLOC_IF): Define only if needed.
13984 (WORDCHAR_P): Likewise. This one is never needed, but is used
13985 only in a comment talking about a compiler bug, so put inside
13986 the #if 0 of that comment.
13987 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
13988 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
13989 Remove; unused.
19ed5445 13990
1f3561e4 13991 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
13992 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
13993 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 13994
ded6f8f7
PE
13995 * search.c (simple_search): Remove unused var.
13996
dbd37a95
PE
13997 * dired.c (compile_pattern): Move decl from here ...
13998 * lisp.h: ... to here, so that it can be checked.
13999 (struct re_registers): New forward decl.
14000
7e47afad
PE
14001 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
14002
85f24f61
PE
14003 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
14004 All uses changed.
14005 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
14006 Rename locals to avoid shadowing.
5671df8f 14007 (Fvertical_motion): Mark locals as initialized.
85f24f61 14008
181aa2be 14009 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 14010 (casify_region): Mark local as initialized.
181aa2be 14011
930d429c
PE
14012 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
14013
7082eac6
PE
14014 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
14015 New macros, so that the caller can use some names other than
14016 gcpro1, gcpro2, etc.
14017 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
14018 of the new macros.
14019 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
14020 argument, for consistency with GCPRO2_VAR, etc: it is now the
14021 prefix of the variable, not the variable itself. All uses
14022 changed.
38b2c076
PE
14023 * dired.c (directory_files_internal, file_name_completion):
14024 Rename locals to avoid shadowing.
14025
15206ed9
PE
14026 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
14027 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
14028 dired.c's scmp function, had undefined behavior.
14029 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14030 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
14031 * buffer.h: ... to here, because these macros use current_buffer,
14032 and the new implementation with inline functions needs to have
14033 current_buffer in scope now, rather than later when the macros
14034 are used.
14035 (downcase, upcase1): New static inline functions.
14036 (DOWNCASE, UPCASE1): Reimplement using these functions.
14037 This avoids undefined behavior in expressions like
14038 DOWNCASE (x) == DOWNCASE (y), which previously suffered
14039 from race conditions in accessing the global variables
14040 case_temp1 and case_temp2.
14041 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
14042 * lisp.h (case_temp1, case_temp2): Remove their decls.
14043 * character.h (ASCII_CHAR_P): Move from here ...
14044 * lisp.h: ... to here, so that the inline functions mentioned
14045 above can use them.
14046
4a6bea26
PE
14047 * dired.c (directory_files_internal_unwind): Now static.
14048
f14b7e14
PE
14049 * fileio.c (file_name_as_directory, directory_file_name):
14050 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
14051 Now static.
2893f146
PE
14052 (file_name_as_directory): Use const pointers when appropriate.
14053 (Fexpand_file_name): Likewise. In particular, newdir might
14054 point at constant storage, so make it a const pointer.
fd4ead52 14055 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
14056 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
14057 signedness issues.
f839df0c
PE
14058 (Fset_file_times, Finsert_file_contents, auto_save_error):
14059 Rename locals to avoid shadowing.
f14b7e14 14060
5716756e 14061 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
14062 (Ftry_completion, Fall_completions): Rename or remove locals
14063 to avoid shadowing.
5716756e 14064
b4c3046a
PE
14065 * marker.c (bytepos_to_charpos): Remove; unused.
14066
b45db522
PE
14067 * lisp.h (verify_bytepos, count_markers): New decls,
14068 so that gcc does not warn that these functions aren't declared.
14069
85876d07
PE
14070 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
14071 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 14072 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 14073 (copy_text): Remove unused local var.
85876d07 14074
03d78a21 14075 * filelock.c (within_one_second): Now static.
b3dd38ab 14076 (lock_file_1): Rename local to avoid shadowing.
03d78a21 14077
5df8f01b
PE
14078 * buffer.c (fix_overlays_before): Mark locals as initialized.
14079 (fix_start_end_in_overlays): Likewise. This function should be
14080 simplified by using pointers-to-pointers, but that's a different
14081 matter.
b1d876f1 14082 (switch_to_buffer_1): Now static.
8f54f30a
PE
14083 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
14084 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 14085
a70072c9 14086 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 14087 Fix pointer signedness issue.
edced198
PE
14088 (sys_subshell): Mark local as volatile if checking for lint,
14089 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 14090 (MAXPATHLEN): Define only if needed.
a70072c9 14091
a0977c44
PE
14092 * process.c (serial_open, serial_configure): Move decls from here ...
14093 * systty.h: ... to here, so that they can be checked.
14094
a884fdcc
PE
14095 * fns.c (get_random, seed_random): Move extern decls from here ...
14096 * lisp.h: ... to here, so that they can be checked.
14097
604efe86 14098 * sysdep.c (reset_io): Now static.
b8950c94 14099 (wait_for_termination_signal): Remove; unused.
604efe86 14100
38fc62d9
PE
14101 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
14102 (copy_keymap_item, append_key, push_text_char_description):
14103 Now static.
1004a21a 14104 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 14105 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
14106 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
14107 (describe_map_tree):
14108 Rename locals to avoid shadowing.
38fc62d9 14109
2f2650da
PE
14110 * keyboard.c: Declare functions static if they are not used elsewhere.
14111 (echo_char, echo_dash, cmd_error, top_level_2):
14112 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
14113 (read_char, kbd_buffer_get_event, make_lispy_position):
14114 (make_lispy_event, make_lispy_movement, apply_modifiers):
14115 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
14116 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
14117 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 14118 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 14119 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 14120
a053e86c 14121 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
14122 (mark_kboards): Move decl here ...
14123 * alloc.c (mark_kboards): ... from here.
a053e86c 14124
4752793e
PE
14125 * lisp.h (force_auto_save_soon): New decl.
14126
74f10ca7 14127 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
14128 (DEFINE_DUMMY_FUNCTION): New macro.
14129 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
14130 Use it.
c03cd23f
PE
14131 (main): Add casts to avoid warnings
14132 if GCC considers string literals to be constants.
74f10ca7 14133
022e70d4
PE
14134 * lisp.h (fatal_error_signal): Add decl, since it's exported.
14135
59d6fe83
PE
14136 * dbusbind.c: Pointer signedness fixes.
14137 (xd_signature, xd_append_arg, xd_initialize):
14138 (Fdbus_call_method, Fdbus_call_method_asynchronously):
14139 (Fdbus_method_return_internal, Fdbus_method_error_internal):
14140 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
14141 (Fdbus_register_signal): Use SSDATA when the context wants char *.
14142
78320123
PE
14143 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
14144 if GCC considers string literals to be constants.
49cebcca 14145 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 14146
35ac2a97
SM
141472011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
14148
fb103ca9
SM
14149 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
14150 (print_preprocess, print_object): New macro to fix last change.
14151
35ac2a97
SM
14152 * print.c (print_preprocess): Don't forget font objects.
14153
62973b41
JB
141542011-03-16 Juanma Barranquero <lekktu@gmail.com>
14155
14156 * emacs.c (USAGE3): Doc fixes.
14157
0e48bb22
AS
141582011-03-15 Andreas Schwab <schwab@linux-m68k.org>
14159
14160 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
14161 structure.
14162
7684e57b
JB
141632011-03-14 Juanma Barranquero <lekktu@gmail.com>
14164
14165 * lisp.h (VWindow_system, Qfile_name_history):
14166 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
14167 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
14168 (w32_system_caret_x, w32_system_caret_y): Declare extern.
14169
14170 * w32select.c: Don't #include "keyboard.h".
c96bbc66 14171 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
14172
14173 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
14174 * w32console.c (detect_input_pending, read_input_pending)
14175 (encode_terminal_code):
14176 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
14177 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
14178 (w32_system_caret_y, Qfile_name_history):
14179 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
14180 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
14181 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
14182 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
14183 * w32proc.c (Qlocal, report_file_error):
14184 * w32term.c (Vwindow_system, updating_frame):
14185 * w32uniscribe.c (initialized, uniscribe_font_driver):
14186 Remove unneeded extern declarations.
14187
2aa46d6c
CY
141882011-03-14 Chong Yidong <cyd@stupidchicken.com>
14189
c96bbc66 14190 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 14191
cffc6f3b
CY
141922011-03-13 Chong Yidong <cyd@stupidchicken.com>
14193
14194 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
14195 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
14196 These macros can no longer be used for assignment.
14197
44f230aa
SM
14198 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
14199 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
14200 (record_buffer_markers, fetch_buffer_markers): New functions for
14201 recording and fetching special buffer markers.
14202 (set_buffer_internal_1, set_buffer_temp): Use them.
14203
14204 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
14205
14206 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
14207
14208 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
14209 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
14210
14211 * xdisp.c (hscroll_window_tree):
14212 (reconsider_clip_changes): Use PT instead of BUF_PT.
14213
d251f04b
EZ
142142011-03-13 Eli Zaretskii <eliz@gnu.org>
14215
14216 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
14217 $(EMACS_ROOT)/lib/intprops.h.
14218
f0c77cd1
PE
142192011-03-13 Paul Eggert <eggert@cs.ucla.edu>
14220
3eca4629
PE
14221 Fix more problems found by GCC 4.5.2's static checks.
14222
7c86ee98
PE
14223 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
14224 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
14225 (xg_free_frame_widgets): Make it clear that a local variable is
14226 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
14227 (gdk_window_get_screen): Make it clear that this macro is needed
14228 only if USE_GTK_TOOLTIP.
1e5524e7
PE
14229 (int_gtk_range_get_value): New function, which avoids a diagnostic
14230 from gcc -Wbad-function-cast.
14231 (xg_set_toolkit_scroll_bar_thumb): Use it.
14232 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
14233 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
14234 (get_utf8_string, xg_get_file_with_chooser):
14235 Rename locals to avoid shadowing.
14236 (create_dialog): Move locals to avoid shadowing.
7c86ee98 14237
41729b81
PE
14238 * xgselect.c (xg_select): Remove unused var.
14239
f0c77cd1
PE
14240 * image.c (four_corners_best): Mark locals as initialized.
14241 (gif_load): Initialize transparent_p to zero (Bug#8238).
14242 Mark another local as initialized.
ec6cf4c6 14243 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 14244
ce0ad53d 14245 * image.c (clear_image_cache): Now static.
d5d5a617 14246 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 14247 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
14248 (x_edge_detection): Remove unnecessary cast that
14249 gcc -Wbad-function-cast diagnoses.
2037898d 14250 (gif_load): Fix pointer signedness.
6ae141d6
PE
14251 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
14252 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 14253
33383987 142542011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 14255
d32df629
PE
14256 Improve quality of tests for time stamp overflow.
14257 For example, without this patch (encode-time 0 0 0 1 1
14258 1152921504606846976) returns the obviously-bogus value (-948597
14259 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
14260 reports time overflow. See
14261 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
14262 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
14263 * editfns.c: Include limits.h and intprops.h.
14264 (TIME_T_MIN, TIME_T_MAX): New macros.
14265 (time_overflow): Move earlier, to before first use.
14266 (hi_time, lo_time): New functions, for an accurate test for
14267 out-of-range times.
14268 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
14269 (Fget_internal_run_time): Don't assume time_t fits in int.
14270 (make_time): Use list2 instead of Fcons twice.
14271 (Fdecode_time): More accurate test for out-of-range times.
14272 (check_tm_member): New function.
14273 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
14274 (lisp_time_argument): Don't rely on undefined left-shift and
14275 right-shift behavior when checking for time stamp overflow.
8be6f318 14276
fe31d94c
PE
14277 * editfns.c (time_overflow): New function, refactoring common code.
14278 (Fformat_time_string, Fdecode_time, Fencode_time):
14279 (Fcurrent_time_string): Use it.
14280
8be6f318
PE
14281 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
14282 * dired.c (make_time): Move to ...
14283 * editfns.c (make_time): ... here.
14284 * systime.h: Note the move.
14285
09d9db2c 142862011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 14287
126bc0dc
YM
14288 * fringe.c (update_window_fringes): Remove unused variables.
14289
c47cbdfd
YM
14290 * unexmacosx.c (copy_data_segment): Also copy __got section.
14291 (Bug#8223)
14292
7ac80be9
EZ
142932011-03-12 Eli Zaretskii <eliz@gnu.org>
14294
c96bbc66 14295 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
14296 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
14297 Constify `char *' arguments and their references according to
14298 prototypes in tparam.h.
14299
ecb0f94d 14300 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 14301
7ac80be9
EZ
14302 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
14303 Adapt all references accordingly.
14304
14305 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
14306
ef1fd07e
TT
143072011-03-11 Tom Tromey <tromey@redhat.com>
14308
14309 * buffer.c (syms_of_buffer): Remove obsolete comment.
14310
7ef4b50c
EZ
143112011-03-11 Eli Zaretskii <eliz@gnu.org>
14312
14313 * termhooks.h (encode_terminal_code): Declare prototype.
14314
14315 * msdos.c (encode_terminal_code): Don't declare prototype.
14316
14317 * term.c (encode_terminal_code): Now external again, used by
14318 w32console.c and msdos.c.
14319
44f230aa
SM
14320 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
14321 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 14322
4b1ec863 143232011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 14324
1714f52b 14325 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 14326
4b1ec863
PE
14327 * fringe.c (update_window_fringes): Mark locals as initialized
14328 (Bug#8227).
14329 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 14330
524c7aa6
PE
14331 * alloc.c (mark_fringe_data): Move decl from here ...
14332 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
14333 to check its interface.
14334 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
14335
a5c0af81 14336 * fontset.c (free_realized_fontset): Now static.
7519b8cd 14337 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 14338 (fontset_font): Mark local as initialized.
a9a06e0b 14339 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 14340
b4716021
PE
14341 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
14342
811e9bac 14343 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 14344 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
14345 (x_own_selection, Fx_disown_selection_internal): Rename locals
14346 to avoid shadowing.
14347 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 14348
7e3ab302
PE
14349 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
14350 so that the caller can use some name other than gcpro1.
14351 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
14352 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14353 (Fx_backspace_delete_keys_p):
14354 Use them to avoid shadowing, and rename vars to avoid shadowing.
14355 (x_decode_color, x_set_name, x_window): Now static.
6b437900 14356 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 14357 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
14358 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
14359 Remove unused locals.
7e3ab302
PE
14360 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14361 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
14362 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
14363 macros.
f78faa98 14364
e2b13473
PE
14365 * xterm.h (x_mouse_leave): New decl.
14366
77f23912
PE
14367 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
14368 Remove unused functions.
cdf4ba58
PE
14369 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
14370 (x_calc_absolute_position): Now static.
7411c686 14371 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 14372 Don't declare local "event" unless it's used.
ed7bf3a5
PE
14373 (x_iconify_frame, x_free_frame_resources): Don't declare locals
14374 unless they are used.
38d0b34a
PE
14375 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
14376 (x_fatal_error_signal): Remove; not used.
a6067996
PE
14377 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
14378 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
14379 (x_error_catcher, x_connection_closed, x_error_handler):
14380 (x_error_quitter, xembed_send_message, x_iconify_frame):
14381 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 14382 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 14383 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 14384
44f230aa
SM
14385 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
14386 Rename or move locals to avoid shadowing.
6b463e58 14387 (tty_defined_color, merge_face_heights): Now static.
5967d051 14388 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
14389 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
14390 does not deduce is never used uninitialized.
73719eba
PE
14391 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
14392 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 14393
426994c3 14394 * terminal.c (store_terminal_param): Now static.
5489860b 14395
032f1620 14396 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 14397 (set_frame_menubar): Remove unused local.
d4323972 14398 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
14399 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
14400 since they might point to immutable storage.
281585b0
PE
14401 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
14402 since it's unused otherwise.
032f1620 14403
367c19e5 14404 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 14405 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
14406 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
14407 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 14408 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
14409 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
14410 does not deduce are never used uninitialized.
70739cbe 14411
07b48fa9
PE
14412 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
14413
8868a238 14414 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
14415 * window.c (window_loop, size_window):
14416 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 14417
7e5cf297 14418 * window.c (display_buffer): Now static.
d6550a9f
PE
14419 (size_window): Mark variables that gcc -Wuninitialized
14420 does not deduce are never used uninitialized.
a586633d
PE
14421 * window.h (check_all_windows): New decl, to forestall
14422 gcc -Wmissing-prototypes diagnostic.
5b555da1 14423 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 14424
f6095868
PE
14425 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
14426 shadowing.
14427 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
14428 Include <limits.h>.
14429 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
14430 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
14431 (load_charset_map): Mark variables that gcc -Wuninitialized
14432 does not deduce are never used uninitialized.
53df7c11 14433 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 14434
f38b440c
PE
14435 * coding.c (coding_set_source, coding_set_destination):
14436 Use "else { /* comment */ }" rather than "else /* comment */;"
14437 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
14438 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
14439 a block, when the outer 'i' will do.
14440 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
14441 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
14442 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
14443 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
14444 (Fdecode_sjis_char, Fdefine_coding_system_internal):
14445 Rename locals to avoid shadowing.
14446 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
14447 * coding.c (emacs_mule_char, encode_invocation_designation):
14448 Now static, since they're not used elsewhere.
413bb2db 14449 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 14450 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
14451 (decode_coding_emacs_mule): Mark variables that gcc
14452 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
14453 (detect_coding_iso_2022): Initialize a local variable that might
14454 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 14455 this initialization is needed. (Bug#8211)
5f58e762
PE
14456 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
14457 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
14458 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
14459 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
14460 Remove unused macros.
f38b440c 14461
232b38b9 14462 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 14463 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 14464 * character.c (string_count_byte8): Likewise.
232b38b9 14465
fb90da1b
PE
14466 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
14467 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
14468
fb93dbc2
PE
14469 * chartab.c (copy_sub_char_table): Now static, since it's not used
14470 elsewhere.
5c156ace
PE
14471 (sub_char_table_ref_and_range, char_table_ref_and_range):
14472 Rename locals to avoid shadowing.
bbcd0949 14473 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 14474
7d3b3862 14475 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 14476 (BIDI_BOB): Remove unused macro.
7d3b3862 14477
6be7d3da
PE
14478 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
14479 deduce are never used uninitialized.
c2ed9c8b 14480 * term.c (encode_terminal_code): Likewise.
6be7d3da 14481
75f8807f 14482 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 14483
50938595
PE
14484 * tparam.h: New file.
14485 * term.c, tparam.h: Include it.
14486 * deps.mk (term.o, tparam.o): Depend on tparam.h.
14487 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
14488 Move these decls to tparam.h, and make them agree with what
14489 is actually in tparam.c. The previous trick of using incompatible
14490 decls in different modules does not conform to the C standard.
14491 All callers of tparam changed to use tparam's actual API.
14492 * tparam.c (tparam1, tparam, tgoto):
14493 Use const pointers where appropriate.
14494
fbceeba2
PE
14495 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
14496 * cm.h (struct cm): Likewise.
14497 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
14498 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
14499 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
14500 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
14501 (turn_on_face, init_tty): Likewise.
14502 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 14503
7f3f1250
PE
14504 * term.c (term_mouse_position): Rename local to avoid shadowing.
14505
e6ca6543
PE
14506 * alloc.c (mark_ttys): Move decl from here ...
14507 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
14508
c40f8d15
AS
145092011-03-11 Andreas Schwab <schwab@linux-m68k.org>
14510
14511 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
14512
cfe0661d
JB
145132011-03-09 Juanma Barranquero <lekktu@gmail.com>
14514
14515 * search.c (compile_pattern_1): Remove argument regp, unused since
14516 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
14517 (compile_pattern): Don't pass it.
14518
0afb4571
J
145192011-03-08 Jan Djärv <jan.h.d@swipnet.se>
14520
14521 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
14522 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
14523 for ! HAVE_GTK3.
14524 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
14525
14526 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
14527
14528 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
14529 gdk_window_get_screen, gdk_window_get_geometry,
14530 gdk_x11_window_lookup_for_display and GDK_KEY_g.
14531 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
14532 (xg_get_pixbuf_from_pixmap): New function.
14533 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
14534 to Pixmap, take frame as parameter, remove GdkColormap parameter.
14535 Call xg_get_pixbuf_from_pixmap instead of
14536 gdk_pixbuf_get_from_drawable.
14537 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
14538 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
14539 (xg_check_special_colors): Use GtkStyleContext and its functions
14540 for HAVE_GTK3.
14541 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
14542 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
14543 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
14544 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
14545 Call gtk_widget_get_preferred_size.
0afb4571
J
14546 (xg_frame_resized): gdk_window_get_geometry only takes 5
14547 parameters.
44f230aa
SM
14548 (xg_win_to_widget, xg_event_is_for_menubar):
14549 Call gdk_x11_window_lookup_for_display.
0afb4571
J
14550 (xg_set_widget_bg): New function.
14551 (delete_cb): New function.
895009e1 14552 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 14553 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
14554 (xg_set_background_color): Call xg_set_widget_bg.
14555 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
14556 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
14557 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
14558 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
14559 if ! HAVE_GTK3.
14560 (update_frame_tool_bar): Call gtk_widget_hide.
14561 (xg_initialize): Use GDK_KEY_g.
14562
14563 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
14564 if ! HAVE_GTK3
14565 (x_session_initialize): Call gdk_x11_set_sm_client_id.
14566
14567 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
14568 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
14569 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
14570
1c2cc4ef
JB
145712011-03-08 Juanma Barranquero <lekktu@gmail.com>
14572
14573 * w32xfns.c (select_palette): Check success of RealizePalette against
14574 GDI_ERROR, not zero.
14575
33383987 14576See ChangeLog.11 for earlier changes.
aac0c6e3
MR
14577
14578;; Local Variables:
14579;; coding: utf-8
aac0c6e3
MR
14580;; End:
14581
2f097256 14582 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
14583
14584 This file is part of GNU Emacs.
14585
14586 GNU Emacs is free software: you can redistribute it and/or modify
14587 it under the terms of the GNU General Public License as published by
14588 the Free Software Foundation, either version 3 of the License, or
14589 (at your option) any later version.
14590
14591 GNU Emacs is distributed in the hope that it will be useful,
14592 but WITHOUT ANY WARRANTY; without even the implied warranty of
14593 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14594 GNU General Public License for more details.
14595
14596 You should have received a copy of the GNU General Public License
14597 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.