*** empty log message ***
[bpt/emacs.git] / src / ChangeLog
CommitLineData
22e983b7
JB
12012-07-14 Juanma Barranquero <lekktu@gmail.com>
2
3 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
4
5b3f250f
GM
52012-07-14 Glenn Morris <rgm@gnu.org>
6
7 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
8 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
9 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
10
33d63ff4
GM
112012-07-13 Glenn Morris <rgm@gnu.org>
12
5b633342
GM
13 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
14
33d63ff4
GM
15 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
16 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
17
b55b9f85
JD
182012-07-13 Jan Djärv <jan.h.d@swipnet.se>
19
0dc8cf50
JD
20 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
21 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
22 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
23 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
24 where appropriate.
25 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
26 as boolean expression.
27 (x_set_window_size): Remove unused variable toolbar.
28 (ns_get_color_default, ns_mod_to_lisp): Remove.
29 (ns_mouse_position): Remove unused variables xchar and ychar.
30 (ns_compute_glyph_string_overhangs): Remove unused variable face.
31 (ns_set_vertical_scroll_bar): Remove unused variable count.
32 (ns_delete_terminal): Remove unused variable i.
33 (ns_term_init): Remove unused variables r, g and b.
34 (mouseDown): Remove unused variable window.
35 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
36 (initFrameFromEmacs): Remove unused variable vbextra.
37 (mouseEntered): Remove unused variables p and dpyinfo.
38 (mouseExited): Remove unused variables p and r.
39 (ns_define_frame_cursor, ns_clear_frame_area)
40 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
41 (menuDown): Assign [sender tag] to variable and cast the variable.
42
43 * nsterm.h (menuDown): Add id as type to argument sender.
44 (ns_display_info_for_name): Add Lisp_Object argument.
45 (ns_term_init): Add Lisp_Object argument.
46 (ns_map_event_to_object): Add void argument.
47 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
48 prototype with arguments and only declare if __OBJC__.
49 (nxatoms_of_nsselect): Add void argument.
50 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
51 (ns_alloc_autorelease_pool): Add void argument.
52 (ns_release_autorelease_pool): Add void* argument.
53 (ns_get_defaults_value): Add const char* argument.
54
55 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
56 (initFromContents): Use SSDATA where appropriate.
57 (ns_update_menubar): Add braces to ambigous if-else.
58 (initWithTitle): Put () around assignment in if statement.
59 (ns_menu_show): Remove unused variables window and keymap.
60 (update_frame_tool_bar): Remove unused variable selected_p.
61 (initWithContentRect): Remove unused variable this_cmd_name.
62
63 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
64 appropriate.
65 (setXBMColor): Remove unused variable len.
66 (setPixmapData): Put () around assignment in loop statement.
67
68 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
69 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
70 where appropriate.
71 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
72 around assignment in loop statement.
73 (nsfont_open): Remove unused variable i.
74 (nsfont_open): Remove unused variable len.
75 (nsfont_draw): Remove unused variable cs.
76
77 * nsfns.m (x_set_icon_name, ns_set_name_internal)
78 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
79 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
80 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
81 (Fns_font_name, Fns_perform_service)
82 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
83 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
84 (ns_set_name): Remove unused variable view.
85 (x_set_menu_bar_lines): Remove unused variable olines.
86 (x_set_tool_bar_lines): Remove unused variable root_window.
87 (Fns_list_colors): Put () around assignment in while statement.
88 (Fns_perform_service): Remove unused variable len.
89 (Fns_display_usable_bounds): Remove unused variable top.
90 (syms_of_nsfns): Remove unused variable i.
91
b55b9f85
JD
92 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
93 memcpy (Bug#11907).
94
ed9265fc 952012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
96
97 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
98 and free it with DestroyExceptionInfo (Bug#11558).
99
ef099b57
JB
1002012-07-13 Juanma Barranquero <lekktu@gmail.com>
101
102 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
103 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
104 Set here, not in nt/config.nt.
105
ea814a5d
EZ
1062012-07-13 Eli Zaretskii <eliz@gnu.org>
107
108 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
109 cursor overflow into the last glyph on display line when the right
110 fringe is off. (Bug#11832)
111
1a952767
PE
1122012-07-13 Paul Eggert <eggert@cs.ucla.edu>
113
114 * xdisp.c (produce_special_glyphs): Now static.
115 * dispextern.h (produce_special_glyphs): Remove decl.
116
983188fd
GM
1172012-07-13 Glenn Morris <rgm@gnu.org>
118
32fb4bb6
GM
119 * s/bsd-common, s/cygwin.h: Remove empty files.
120 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
121
983188fd
GM
122 * s/usg5-4-common.h (USG, USG5):
123 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
124 * s/sol2-6.h (SOLARIS2):
125 * s/irix6-5.h (IRIX6_5):
126 * s/hpux10-20.h (USG, USG5, HPUX):
127 * s/gnu-linux.h (USG, GNU_LINUX):
128 * s/freebsd.h (BSD_SYSTEM):
129 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
130 * s/cygwin.h (CYGWIN):
131 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
132 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
133
d1e68667 1342012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
135
136 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 137
6de0e799
GM
1382012-07-13 Glenn Morris <rgm@gnu.org>
139
739ae010
GM
140 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
141
dbee5793
GM
142 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
143
6de0e799
GM
144 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
145 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
146
b82da769
GM
1472012-07-12 Glenn Morris <rgm@gnu.org>
148
4fae5a7a 149 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
150
151 * process.c (init_process_emacs): Rename from init_process.
152 The old name is also the name of a Mach system call.
153 * lisp.h, emacs.c: Update for this name change.
154 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
155 longer needed.
156
5a979817
EZ
1572012-07-12 Eli Zaretskii <eliz@gnu.org>
158
159 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
160 memmove call that removes glyphs covered by the left truncation
161 glyph. Improve commentary.
162 (display_line): Fix display of continuation glyphs on GUI frames
163 when the right fringe is turned off and variable-size fonts are
164 used in the window. Move the code that appends a stretch glyph to
165 produce_special_glyphs, so that it could be used for truncation
166 and continuation glyphs alike.
167 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
168 glyph of a suitably computed width, to align the special glyphs at
169 the window margin. Code moved from display_line. (Bug#11832)
170
3e91a053
GM
1712012-07-12 Glenn Morris <rgm@gnu.org>
172
ba9e4b84
GM
173 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
174
175 * s/gnu-linux.h, s/hpux10-20.h:
176 Do not unconditionally define HAVE_XRMSETDATABASE.
177
3e91a053
GM
178 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
179
b300b1f4
PE
1802012-07-12 Paul Eggert <eggert@cs.ucla.edu>
181
182 Fix typos that broke OS X build.
183 Reported by Randal L. Schwartz in
184 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
185 * nsterm.m (ns_timeout): Add missing local decl.
186 (ns_get_color): snprintf -> sprintf, to fix typo.
187
6e777848
GM
1882012-07-12 Glenn Morris <rgm@gnu.org>
189
3f922c37
GM
190 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
191 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
192 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
193 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
194
0ab7b23a
GM
195 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
196 Move PTY_OPEN to configure.
197
6e777848
GM
198 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
199 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
200 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
201
4a7edc24
DA
2022012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
203
204 Use empty_unibyte_string where applicable.
205 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
206 * lread.c (read1): Likewise.
207 * xsettings.c (syms_of_xsettings): Likewise.
208
308aab79
GM
2092012-07-12 Glenn Morris <rgm@gnu.org>
210
42bd1719
GM
211 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
212 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
213 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
214 * s/hpux10-20.h (RUN_TIME_REMAP):
215 * s/bsd-common.h (TABDLY): Move to configure.
216
217 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
218
219 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
220
ea0bbd17 221 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 222 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
223
224 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 225
308aab79
GM
226 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
227 * s/template.h: Move NARROWPROTO to configure.
228
ee1cf5cf
GM
2292012-07-11 Glenn Morris <rgm@gnu.org>
230
30fe9bf4
GM
231 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
232 unused since 2011-01-17 change to systty.h.
233
ee1cf5cf
GM
234 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
235 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
236 Move HAVE_PTYS and HAVE_SOCKETS to configure.
237
63e47e07
PE
2382012-07-11 Paul Eggert <eggert@cs.ucla.edu>
239
240 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
241
c43fb4c3
GM
2422012-07-11 Glenn Morris <rgm@gnu.org>
243
244 * s/darwin.h, s/gnu-linux.h, s/template.h:
245 Move INTERRUPT_INPUT to configure.
246
e8df9267
DA
2472012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
248
249 Minor adjustments to interning code.
250 * lisp.h (intern, intern_c_string): Redefine as static inline
251 wrappers for intern_1 and intern_c_string_1, respectively.
252 (intern_1, intern_c_string_1): Rename prototypes.
2bce5643
DA
253 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
254 Vobarray checking.
e8df9267
DA
255 * font.c (font_intern_prop): Likewise. Adjust comment.
256 * w32font.c (intern_font_name): Likewise.
257
34348bd4
AS
2582012-07-11 Andreas Schwab <schwab@linux-m68k.org>
259
d96a1e0c
AS
260 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
261
34348bd4
AS
262 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
263 of Fcar/Fcdr if possible.
264 * font.c (check_otf_features): Likewise.
265 * fontset.c (Fnew_fontset): Likewise.
266 * gnutls.c (Fgnutls_boot): Likewise.
267 * minibuf.c (read_minibuf): Likewise.
268 * msdos.c (IT_set_frame_parameters): Likewise.
269 * xmenu.c (Fx_popup_dialog): Likewise.
270 * w32menu.c (Fx_popup_dialog): Likewise.
271
c8add24e
GM
2722012-07-11 Glenn Morris <rgm@gnu.org>
273
4b575b3c
GM
274 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
275 since nothing has defined it on these platforms.
276
09f4e3b0
GM
277 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
278 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
279
172bedef
GM
280 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
281 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
282 Move CLASH_DETECTION to configure.
283
249685df
GM
284 * s/gnu.h: Remove file, which is now empty.
285
c8add24e
GM
286 * s/gnu.h, s/gnu-linux.h:
287 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
288
b41253a3
JW
2892012-07-11 John Wiegley <johnw@newartisans.com>
290
291 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
292 function attribute, so we only use it if it exists in the
293 compiler.
294
d923b542
DA
2952012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
296
297 Avoid call to strlen in fast_c_string_match_ignore_case.
298 * search.c (fast_c_string_match_ignore_case): Change to use
299 length argument. Adjust users accordingly.
300 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
301
5ebbef1d
PE
3022012-07-11 Paul Eggert <eggert@cs.ucla.edu>
303
bb352260
PE
304 Assume mkdir, rmdir.
305 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
306 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
307
57054ddd
PE
308 Assume rename.
309 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
310
b747d3f7
PE
311 Assume perror.
312 * s/hpux10-20.h (HAVE_PERROR): Remove.
313 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
314 Remove dummy definition, as this problem was obsolete long ago.
315
5ebbef1d
PE
316 Assume strerror.
317 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
318
984e7f30
DA
3192012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
320
321 Avoid calls to strlen in font processing functions.
322 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
d923b542 323 (font_open_by_name): Change to use length argument. Adjust
984e7f30 324 users accordingly.
d923b542
DA
325 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
326 Adjust prototypes.
327 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
328 Change to return ptrdiff_t.
984e7f30
DA
329 (xfont_list_pattern, xfont_match): Use length returned by
330 xfont_decode_coding_xlfd.
331 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
332
20e94fdd
GM
3332012-07-11 Glenn Morris <rgm@gnu.org>
334
9d596af3
GM
335 * s/darwin.h, s/freebsd.h, s/netbsd.h:
336 Move DONT_REOPEN_PTY to configure.
337
20e94fdd
GM
338 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
339 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
340
e99a530f
PE
3412012-07-10 Paul Eggert <eggert@cs.ucla.edu>
342
22ffb973
PE
343 Remove "#define unix" that is no longer needed (Bug#11905).
344 * s/aix4-2.h (unix): Remove; no longer needed.
345
e9a9ae03
PE
346 EMACS_TIME simplification (Bug#11875).
347 This replaces macros (which typically do not work in GDB)
348 with functions, typedefs and enums, making the code easier to debug.
349 The functional style also makes code easier to read and maintain.
350 * systime.h: Include <sys/time.h> on all hosts, not just if
351 WINDOWSNT, since 'struct timeval' is needed in general.
352 (EMACS_TIME): Now a typedef, not a macro.
353 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
354 not macros.
355 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
356 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
357 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
358 (EMACS_TIME_LE): Now functions, not macros.
359 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
360 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
361 which are not functions. All uses rewritten to use:
362 (make_emacs_time): New function.
363 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
364 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
365 not functions. All uses rewritten to use the following, respectively:
366 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
367 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 368 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
369 * fileio.c (Fcopy_file):
370 * xterm.c (XTflash): Get the current time closer to when it's used.
371 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
372
ffacb126
PE
373 * bytecode.c (targets): Suppress -Woverride-init warnings.
374
e99a530f
PE
375 Simplify by avoiding confusing use of strncpy etc.
376 * doc.c (Fsnarf_documentation):
377 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
378 * frame.c (Fmake_terminal_frame):
379 * gtkutil.c (get_utf8_string):
380 * lread.c (openp):
381 * nsmenu.m (ns_update_menubar):
382 * regex.c (regerror):
383 Prefer memcpy to strncpy and strncat when either will do.
384 * fileio.c (Fsubstitute_in_file_name):
385 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
386 (menu_separator_name_p):
387 * nsmenu.m (ns_update_menubar):
388 Prefer memcmp to strncmp when either will do.
389 * nsterm.m: Include <ftoastr.h>.
390 (ns_get_color):
391 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
392 Prefer snprintf to strncpy.
393 * nsterm.m (ns_term_init):
394 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
395 * nsterm.m (ns_term_init):
396 Avoid the need for strncpy, by using build_string or
397 make_unibyte_string directly. Use dtoastr, not snprintf.
398 * process.c (Fmake_network_process): Diagnose service names that
399 are too long, rather than silently truncating them or creating
400 non-null-terminated names.
401 (Fnetwork_interface_info): Likewise, for interface names.
402 * sysdep.c (system_process_attributes) [GNU_LINUX]:
403 Prefer sprintf to strncat.
404 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
405 Prefer vsnprintf to vsprintf + strncpy.
406
c59592b3
GM
4072012-07-10 Glenn Morris <rgm@gnu.org>
408
409 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
410 Clarify fallback case.
411
7d7bbefd
DA
4122012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
413
414 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
415 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
416 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 417 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
418 where argument type is known to be a Lisp_Cons.
419
3a4c8000
TT
4202012-07-10 Tom Tromey <tromey@redhat.com>
421
422 * bytecode.c (BYTE_CODE_THREADED): New macro.
423 (BYTE_CODES): New macro. Replaces all old byte-code defines.
424 (enum byte_code_op): New type.
425 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
426 (exec_byte_code): Use them. Use token threading when applicable.
427
2a0213a6
DA
4282012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
429
430 Optimize pure C strings initialization.
431 * lisp.h (make_pure_string): Fix prototype.
432 (build_pure_c_string): New function, defined as static inline. This
433 provides a better opportunity to optimize away calls to strlen when
434 the function is called with compile-time constant argument.
435 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
436 argument, adjust users accordingly. Use build_pure_c_string where
437 appropriate.
438 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
439 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
440 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
441
cb1caeaf
DA
4422012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
443
444 Avoid calls to strlen in miscellaneous functions.
445 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
446 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
447 * lread.c (openp): Likewise.
448
c293e30c
DA
4492012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
450
451 Avoid calls to strlen in path processing functions.
452 * fileio.c (file_name_as_directory): Add comment. Change to add
453 srclen argument and return the length of result. Adjust users
454 accordingly.
455 (directory_file_name): Fix comment. Change to add srclen argument,
cb1caeaf 456 swap 1st and 2nd arguments to obey the common convention. Adjust
c293e30c
DA
457 users accordingly.
458 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
459
9e059e3f
GM
4602012-07-10 Glenn Morris <rgm@gnu.org>
461
d02eb359
GM
462 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
463 Move PENDING_OUTPUT_COUNT definition to configure.
464
882cf227
GM
465 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
466 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
467 * s/gnu.h (DATA_START): Move definitions to configure.
468
af6e839f
GM
469 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
470 We include usg5-4-common.h, which defines them both.
471
40289a12
GM
472 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
473 O_RDONLY already includes it).
474
9e059e3f
GM
475 Stop ns builds setting the EMACSLOADPATH environment variable.
476 * nsterm.m (ns_load_path): Rename from ns_init_paths.
477 Now it does not set EMACSLOADPATH, just returns the load-path string.
478 * nsterm.h: Update accordingly.
479 * lread.c [HAVE_NS]: Include nsterm.h.
480 (init_lread) [HAVE_NS]: Use ns_load_path.
481 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
482
7c4e8ec0
GM
4832012-07-09 Glenn Morris <rgm@gnu.org>
484
d4f600ff
GM
485 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
486 since the included bsd-common.h does so.
487
cbb31951
GM
488 Stop ns builds setting the EMACSPATH environment variable.
489 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
490 (ns_init_paths): Do not set EMACSPATH.
491 * nsterm.h (ns_exec_path): Add it.
492 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
493 Use ns_exec_path.
494
7c4e8ec0
GM
495 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
496
26bccfae
PE
4972012-07-09 Paul Eggert <eggert@cs.ucla.edu>
498
a0bee46f
PE
499 * process.c (wait_reading_process_output): 'waitchannels' was unset
500 when read_kbd || !NILP (wait_for_cell); fix this.
501
5994c183
PE
502 Add GCC-style 'const' attribute to functions that can use it.
503 * character.h (char_resolve_modifier_mask):
504 * keyboard.h (make_ctrl_char):
505 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
506 (init_character_once, next_almost_prime, init_fns, init_image)
507 (flush_pending_output, init_sound):
508 * mem-limits.h (start_of_data):
509 * menu.h (finish_menu_items):
510 Add ATTRIBUTE_CONST.
511 * emacs.c (DEFINE_DUMMY_FUNCTION):
512 Declare the dummy function with ATTRIBUTE_CONST.
513 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
514 Add decls with ATTRIBUTE_CONST.
515
26bccfae
PE
516 Minor improvements to make_formatted_string.
517 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
518 where int is good enough, as vsprintf returns an int.
519 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
520
a8290ec3
DA
5212012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
522
523 Use make_formatted_string to avoid double length calculation.
524 * lisp.h (make_formatted_string): New prototype.
525 * alloc.c (make_formatted_string): New function.
526 * buffer.c (Fgenerate_new_buffer_name): Use it.
527 * dbus.c (syms_of_dbusbind): Likewise.
528 * editfns.c (Fcurrent_time_zone): Likewise.
529 * filelock.c (get_boot_time): Likewise.
530 * frame.c (make_terminal_frame, set_term_frame_name)
531 (x_report_frame_params): Likewise.
532 * image.c (gs_load): Likewise.
533 * minibuf.c (get_minibuffer): Likewise.
534 * msdos.c (dos_set_window_size): Likewise.
535 * process.c (make_process): Likewise.
536 * xdisp.c (ensure_echo_area_buffers): Likewise.
537 * xsettings.c (apply_xft_settings): Likewise.
538
d01ba2f1
GM
5392012-07-09 Glenn Morris <rgm@gnu.org>
540
541 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
542 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
543 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
544 * nsterm.h (ns_etc_directory): Add it.
545 * callproc.c [HAVE_NS]: Include nsterm.h.
546 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
547
f1f924b6
DA
5482012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
549
550 Move marker debugging code under MARKER_DEBUG.
551 * marker.c (MARKER_DEBUG): Move marker debugging code under
552 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
553 for bootstrap with --enable-checking (~3x slowdown reported
554 by Juanma Barranquero <lekktu@gmail.com>).
555 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
556
ab531b66
PE
5572012-07-08 Paul Eggert <eggert@cs.ucla.edu>
558
559 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
560 See <http://bugs.gnu.org/11825#29>.
561
c4b3bc8a
EZ
5622012-07-08 Eli Zaretskii <eliz@gnu.org>
563
564 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
565 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
566 (display_line): Add commentary about displaying truncation glyphs
567 on GUI frames.
568 (produce_special_glyphs): Move here from term.c.
569
570 * term.c (produce_special_glyphs): Move to xdisp.c.
571
572 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
573 section.
c4b3bc8a 574
b676b881
AS
5752012-07-07 Andreas Schwab <schwab@linux-m68k.org>
576
f17c5273
AS
577 * xdisp.c (display_line): Avoid warning about implicit declaration
578 of FRAME_FONT.
579
298819b9
AS
580 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
581
b676b881
AS
582 * lisp.h: Remove empty conditional.
583
6045c4fd
PE
5842012-07-07 Paul Eggert <eggert@cs.ucla.edu>
585
b3350bf9
PE
586 * lread.c (load_path_check): Now static.
587
6045c4fd
PE
588 Fix some minor --with-ns problems found by static checking.
589 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
590 (x_set_font) [!HAVE_X_WINDOWS]:
591 * image.c (xpm_load_image) [HAVE_NS]:
592 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
593 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
594 Remove unused local.
595 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
596 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
597 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
598 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
599 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
600 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
601 Fix pointer signedness problem.
602 * xfaces.c (FRAME_X_FONT_TABLE):
603 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
604
929e7845
GM
6052012-07-07 Glenn Morris <rgm@gnu.org>
606
607 * lread.c (load_path_check): New function, split from init_lread.
608 (init_lread): Reorganize. Motivation:
609 If EMACSLOADPATH is set, check/warn about that rather than the
610 defaults, which we are not going to use. Hence we can remove
611 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
612 Don't warn if site-lisp directories are missing.
613 If not installed, start from a blank load-path, since
614 PATH_LOADSEARCH refers to the eventual installation directories.
615
58dd0aa4
EZ
6162012-07-07 Eli Zaretskii <eliz@gnu.org>
617
618 Support truncation and continuation glyphs on GUI frames, when
619 fringes are disabled. (Bug#11832)
620 * xdisp.c (init_iterator): Get dimensions of truncation and
621 continuation glyphs even if on GUI frames. Adjust
622 it->last_visible_x on GUI frames when the left or right fringes,
623 or both, are absent.
624 (start_display, move_it_in_display_line_to): Handle the case of a
625 GUI frame without a fringe to display continuation or truncation
626 glyphs.
627 (insert_left_trunc_glyphs): Support GUI frames: make sure
628 truncation glyphs overwrite enough glyphs from the current line to
629 have sufficient space in pixels.
630 (display_line): Support truncation and continuation glyphs on GUI
631 frames. If some spare pixels are left on the line after inserting
632 the truncation glyphs, fill that space with a stretch glyph of a
633 suitably computed width.
634
635 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
636 produce_glyphs, to support GUI sessions.
637
31571fd7
PE
6382012-07-07 Paul Eggert <eggert@cs.ucla.edu>
639
5a16b9bc
PE
640 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
641
f3047c75
PE
642 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
643
31571fd7
PE
644 Do not require float-time's arg to fit in time_t (Bug#11825).
645 This works better on hosts where time_t is unsigned, and where
646 float-time is applied to the (negative) difference between two times.
647 * editfns.c (decode_time_components): Last arg is now double *,
648 not int *, and means to store all the result as a double, without
649 worrying about whether the seconds part fits in time_t.
650 All callers changed.
651 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
652 All callers changed.
653 (Ffloat_time): Do not fail merely because the specified time falls
654 outside of time_t range.
655
4516fbef
GM
6562012-07-07 Glenn Morris <rgm@gnu.org>
657
658 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
659 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
660 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
661
07adc2c6
JB
6622012-07-07 Juanma Barranquero <lekktu@gmail.com>
663
664 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
665 Update dependencies.
666
667 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
668
fd573f31
PE
6692012-07-06 Paul Eggert <eggert@cs.ucla.edu>
670
fee5959d
PE
671 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
672 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
673 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
674 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
675 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
676 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
677
fd573f31
PE
678 * xfont.c (compare_font_names): Redo to omit the need for casts.
679
ddadbc0e
AS
6802012-07-06 Andreas Schwab <schwab@linux-m68k.org>
681
fca8d6b6
AS
682 * xfns.c (Fx_change_window_property): Doc fix.
683 * w32fns.c (Fx_change_window_property): Doc fix.
684
ddadbc0e
AS
685 * w32fns.c (Fx_window_property): Accept the same arguments as the
686 X Windows version. Doc fix.
687 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
688
ed9265fc 6892012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
690 Eli Zaretskii <eliz@gnu.org>
691
692 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
693 Windows-specific code from nt/config.nt moved here.
694 Obsolete settings removed.
695
216ee680
PE
6962012-07-06 Paul Eggert <eggert@cs.ucla.edu>
697
698 * process.c: Avoid unnecessary calls to gettime.
699 (wait_reading_process_output): Don't get the time of day
700 when gobbling data immediately and not waiting, as there's no need
701 for it in that case. This removes a FIXME.
702
bdd091e4
JD
7032012-07-06 Jan Djärv <jan.h.d@swipnet.se>
704
705 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
706 is defined (Bug#11768).
707
9d44f8ce
DA
7082012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
709
710 Fix marker debugging code.
711 * marker.c (byte_char_debug_check): Do not perform the check
712 if buffer is not multibyte.
090bd7cb
JB
713 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
714 Call byte_char_debug_check with correct arguments.
9d44f8ce 715
90fc4786
DA
7162012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
717
718 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
719 * marker.c (byte_char_debug_check, count_markers):
720 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
721 (byte_debug_flag): Remove.
722 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
723 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
724
7b7ae965
DA
7252012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
726
4e57b342
DA
727 Avoid code repetition in marker-related functions.
728 * marker.c (attach_marker): New function.
729 (Fset_marker, set_marker_restricted, set_marker_both)
730 (set_marker_restricted_both): Use it.
731 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
732 Consistently rename charno to charpos.
733 (marker_position): Add eassert.
734 (marker_byte_position): Convert to eassert.
735
7362012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
737
738 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 739 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 740 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 741
657924ff
DA
7422012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
743
744 Introduce fast path for the widely used marker operation.
745 * alloc.c (build_marker): New function.
746 * lisp.h (build_marker): New prototype.
747 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
748 * composite.c (autocmp_chars): Likewise.
749 * editfns.c (buildmark): Remove.
750 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
751 (save_restriction_save): Use build_marker.
752 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
753 * window.c (save_window_save): Likewise.
754
041a49a6
DA
7552012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
756
757 Do not use Fdelete_overlay in delete_all_overlays
758 to avoid redundant calls to unchain_overlay.
759 * buffer.c (drop_overlay): New function.
760 (delete_all_overlays, Fdelete_overlay): Use it.
761 * minibuf.c (get_minibuffer): Fix comment.
762
7dca65a4
PE
7632012-07-06 Paul Eggert <eggert@cs.ucla.edu>
764
765 Port to OpenBSD 5.1 amd64.
766 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
767 This is needed for OpenBSD, and should be harmless on all BSD systems.
768 Also, include <sys/sysctl.h>, as it should be available on all
769 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
770 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
771 use p_pid member, not kp_proc.pid.
772
8eb876e2
GM
7732012-07-06 Glenn Morris <rgm@gnu.org>
774
775 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
776
38182d90
PE
7772012-07-05 Paul Eggert <eggert@cs.ucla.edu>
778
779 More xmalloc and related cleanup.
780 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
781 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
782 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
783 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
784 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
785 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
786 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
787 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
788 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
789 * xterm.c:
790 Omit needless casts involving void * pointers and allocation.
791 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
792 as the former is more robust if P's type is changed.
793 Prefer xzalloc to xmalloc + memset 0.
794 Simplify malloc-or-realloc to realloc.
795 Don't worry about xmalloc returning a null pointer.
796 Prefer xstrdup to xmalloc + strcpy.
797 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
798 growing it.
799 * keyboard.c (apply_modifiers_uncached): Prefer local array to
800 alloca of a constant.
801
6dd5a677
EZ
8022012-07-05 Eli Zaretskii <eliz@gnu.org>
803
804 * xdisp.c (display_line): Fix horizontal pixel coordinates when
805 hscroll is larger than the line width. Fixes long and futile
806 looping inside extend_face_to_end_of_line (on a TTY) producing
807 glyphs that are not needed and thrown away.
808
6b312f0f
DA
8092012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
810
811 * marker.c (set_marker_restricted_both): Simplify by using
812 clip_to_bounds.
813
f520ef9b
PE
8142012-07-05 Paul Eggert <eggert@cs.ucla.edu>
815
816 * editfns.c (region_limit): Simplify by using clip_to_bounds.
817
383b7c95
JD
8182012-07-05 Jan Djärv <jan.h.d@swipnet.se>
819
820 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
821 not defined (Bug#11768).
822 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
823 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
824 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
825 followed by gtk_box_set_homogeneous (Bug#11768).
826 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
827 (update_theme_scrollbar_width, xg_create_scroll_bar):
828 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
829 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
830 (is_box_type): New function (Bug#11768).
831 (xg_tool_item_stale_p): Call is_box_type.
5293d758 832 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
833 with default display (Bug#11768).
834
d6e7bf45
EZ
8352012-07-05 Eli Zaretskii <eliz@gnu.org>
836
837 * xdisp.c (window_hscroll_limited): New function.
838 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
839 coordinates when window's hscroll is set to insanely large
840 values. (Bug#11857)
841
431391ec
JB
8422012-07-05 Juanma Barranquero <lekktu@gmail.com>
843
844 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
845 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
846
23f86fce
DA
8472012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
848
849 Cleanup xmalloc.
850 * lisp.h (xzalloc): New prototype. Omit needless casts.
851 * alloc.c (xzalloc): New function. Omit needless casts.
852 * charset.c: Omit needless casts. Convert all calls to
853 xmalloc with following memset to xzalloc.
854 * dispnew.c: Likewise.
855 * fringe.c: Likewise.
856 * image.c: Likewise.
857 * sound.c: Likewise.
858 * term.c: Likewise.
859 * w32fns.c: Likewise.
860 * w32font.c: Likewise.
861 * w32term.c: Likewise.
862 * xfaces.c: Likewise.
863 * xfns.c: Likewise.
864 * xterm.c: Likewise.
865 * atimer.c: Omit needless casts.
866 * buffer.c: Likewise.
867 * callproc.c: Likewise.
868 * ccl.c: Likewise.
869 * coding.c: Likewise.
870 * composite.c: Likewise.
871 * doc.c: Likewise.
872 * doprnt.c: Likewise.
873 * editfns.c: Likewise.
874 * emacs.c: Likewise.
875 * eval.c: Likewise.
876 * filelock.c: Likewise.
877 * fns.c: Likewise.
878 * gtkutil.c: Likewise.
879 * keyboard.c: Likewise.
880 * lisp.h: Likewise.
881 * lread.c: Likewise.
882 * minibuf.c: Likewise.
883 * msdos.c: Likewise.
884 * print.c: Likewise.
885 * process.c: Likewise.
886 * region-cache.c: Likewise.
887 * search.c: Likewise.
888 * sysdep.c: Likewise.
889 * termcap.c: Likewise.
890 * terminal.c: Likewise.
891 * tparam.c: Likewise.
892 * w16select.c: Likewise.
893 * w32.c: Likewise.
894 * w32reg.c: Likewise.
895 * w32select.c: Likewise.
896 * w32uniscribe.c: Likewise.
897 * widget.c: Likewise.
898 * xdisp.c: Likewise.
899 * xmenu.c: Likewise.
900 * xrdb.c: Likewise.
901 * xselect.c: Likewise.
902
0497dc44
PE
9032012-07-05 Paul Eggert <eggert@cs.ucla.edu>
904
905 * fileio.c (time_error_value): Check the right error number.
906 Problem reported by Troels Nielsen in
907 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
908
356e7178
PE
9092012-07-04 Paul Eggert <eggert@cs.ucla.edu>
910
4e71fd89
PE
911 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
912 This should be fixed in a better way; see Eli Zaretskii in
913 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
914 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
915
f0941253
PE
916 * fileio.c (time_error_value): Rename from special_mtime.
917 The old name's problems were noted by Eli Zaretskii in
918 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
919
065c9eb4
PE
920 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
921 This variable's comment says Emacs needs at least one GDB-visible
922 symbol of type enum pvec_type, to work around GDB problems.
923 The symbol's value doesn't matter.
924
356e7178
PE
925 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
926 that causes compilation to fail on pre-C99 compilers.
927
ed9265fc 9282012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
929
930 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
931 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
932
3884d954
DA
9332012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
934
d209e2fb 935 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
936 headers for buffer_defaults and buffer_local_symbols.
937 Reported by Juanma Barranquero <lekktu@gmail.com>.
938
ee28be33
SM
9392012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
940
941 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
942 * lisp.h (enum pvec_type): Use fewer bits.
943 (PSEUDOVECTOR_SIZE_BITS): New constant.
944 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
945 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
946 change in pvec_type.
947 (PSEUDOVECTOR_TYPEP): New macro.
948 (TYPED_PSEUDOVECTORP): Use it.
949 * fns.c (internal_equal): Adapt code to extract pvectype.
950 * emacs.c (gdb_pvec_type): Update type.
951 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
952 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
953 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
954 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
955 (sweep_vectors): Use it. Use local var `total_bytes' instead of
956 abusing vector->header.next.nbytes.
957 (live_vector_p): Use PVEC_TYPE.
958 (mark_object): Adapt code to extract pvectype. Use switch.
959
c7f2cd7f
PE
9602012-07-04 Paul Eggert <eggert@cs.ucla.edu>
961
962 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
963 Tighten new eassert a bit.
964
8ce70ed2
DA
9652012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
966
967 Fix compilation with --enable-gcc-warnings and -O1
968 optimization level.
969 * doprnt.c (doprnt): Change type of tem to int, initialize
970 to avoid compiler warning. Add eassert.
971 * search.c (simple_search): Initialize match_byte to avoid
972 compiler warning. Add eassert.
973
dea7f1e5
PE
9742012-07-04 Paul Eggert <eggert@cs.ucla.edu>
975
24a212eb
PE
976 Avoid weird behavior with large horizontal scrolls.
977 Without this change, for example, large hscroll values would
978 mess up Emacs's display on Fedora 15 x86, presumably due to
979 overflows in int calculations in the display code.
980 Also, if buffers had long lines, Emacs would freeze.
981 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
982 (set_window_hscroll): New function, containing the old guts of
983 Fset_window_hscroll. Return the clipped value.
984 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
985 This avoids the need to check against PTRDIFF_MAX.
986
dea7f1e5
PE
987 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
988
76046526
DA
9892012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
990
991 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
992
39adff0d
PE
9932012-07-04 Paul Eggert <eggert@cs.ucla.edu>
994
63807d47
PE
995 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
996 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
997 since GCC 4.4.6 issues a bogus warning for them.
998
39adff0d
PE
999 Fix bugs in file timestamp newness comparisons.
1000 * fileio.c (Ffile_newer_than_file_p):
1001 * lread.c (Fload): Use full timestamp resolution of files,
1002 not just the 1-second resolution, so that files that are only
1003 slightly newer still count as newer.
1004 * fileio.c (Ffile_newer_than_file_p): Don't assume file
1005 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
1006
dbeed9a6
PE
10072012-07-03 Paul Eggert <eggert@cs.ucla.edu>
1008
1009 * fileio.c: Improve handling of file time marker. (Bug#11852)
1010 (special_mtime): New function.
1011 (Finsert_file_contents, Fverify_visited_file_modtime):
1012 Use it to set special mtime values consistently.
1013
636334d6
AS
10142012-07-03 Andreas Schwab <schwab@linux-m68k.org>
1015
1016 * fileio.c (Finsert_file_contents): Properly handle st_mtime
1017 marker for non-existing file. (Bug#11852)
1018
e2017fe2
GM
10192012-07-03 Glenn Morris <rgm@gnu.org>
1020
1021 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
1022 and did not make it into globals.h).
1023
404dbd37
TT
10242012-07-03 Tom Tromey <tromey@redhat.com>
1025
1026 * window.c (Fset_window_margins, Fset_window_fringes)
1027 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
1028 * textprop.c (Fprevious_property_change): No longer static.
1029 * syntax.c (Fsyntax_table_p): No longer static.
1030 * process.c (Fget_process, Fprocess_datagram_address): No longer
1031 static.
1032 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
1033 * keyboard.c (Fcommand_execute): No longer static.
1034 Remove EXFUN.
1035 * insdel.c (Fcombine_after_change_execute): No longer static.
1036 * image.c (Finit_image_library): No longer static.
1037 * fileio.c (Fmake_symbolic_link): No longer static.
1038 * eval.c (Ffetch_bytecode): No longer static.
1039 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
1040 * doc.c (Fdocumentation_property, Fsnarf_documentation):
1041 No longer static.
404dbd37
TT
1042 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
1043 static.
1044 * dired.c (Ffile_attributes): No longer static.
1045 * composite.c (Fcomposition_get_gstring): No longer static.
1046 * callproc.c (Fgetenv_internal): No longer static.
1047
1048 * ccl.h: Remove EXFUNs.
1049 * buffer.h: Remove EXFUNs.
1050 * dispextern.h: Remove EXFUNs.
1051 * intervals.h: Remove EXFUNs.
1052 * fontset.h: Remove EXFUN.
1053 * font.h: Remove EXFUNs.
1054 * dosfns.c (system_process_attributes): Remove EXFUN.
1055 * keymap.h: Remove EXFUNs.
1056 * lisp.h: Remove EXFUNs.
1057 * w32term.h: Remove EXFUNs.
1058 * window.h: Remove EXFUNs.
1059 * xsettings.h: Remove EXFUN.
1060 * xterm.h: Remove EXFUN.
1061
8e4fd1e1
GM
10622012-07-03 Glenn Morris <rgm@gnu.org>
1063
1064 * lisp.h (Frandom): Make it visible to C.
1065 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
1066 buffer for invisible buffers. (Bug#1229)
1067
ca95b3eb
DA
10682012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1069
1070 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
1071 values which aren't power of 2.
1072 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
1073 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
1074 accordingly.
1075
7555c33f
SM
10762012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
1077
1078 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
1079
1080 * alloc.c (mark_object): Revert part of last patch to use `switch'.
1081
d12e8f5a
DA
10822012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1083
1084 * alloc.c (allocate_vector_block): Remove redundant
1085 calls to mallopt if DOUG_LEA_MALLOC is defined.
1086 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
1087 avoid calls to mallopt if zero_vector is returned.
1088
296094c3
DA
10892012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1090
1091 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
1092 is enabled, avoid dereferencing NULL current_sblock if
1093 running undumped.
1094
36429c89
DA
10952012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1096
1097 Cleanup basic buffer management.
1098 * buffer.h (struct buffer): Change layout to use generic vector
1099 marking code. Fix some comments. Change type of 'clip_changed'
1100 to bitfield. Remove unused #ifndef old.
1101 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
1102 (GET_OVERLAYS_AT): Fix indentation.
1103 (for_each_per_buffer_object_at): New macro.
1104 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
1105 (Fbuffer_local_variables): Use it.
1106 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
1107 * alloc.c (allocate_buffer): Adjust to match new layout of
1108 struct buffer. Fix comment.
1109 (mark_overlay): New function.
1110 (mark_buffer): Use it. Use mark_vectorlike to mark normal
1111 Lisp area of struct buffer.
1112 (mark_object): Use it. Adjust marking of misc objects
1113 and related comments.
1114
3b3e4cac
PE
11152012-07-02 Paul Eggert <eggert@cs.ucla.edu>
1116
1117 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
1118 wrapper that is not needed because the wrapped code is a no-op (zero
1119 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
1120 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
1121
cf5c0175
DA
11222012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
1123
1124 * alloc.c (mark_buffer): Simplify. Remove prototype.
1125 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 1126 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
1127 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
1128 redundant calls to mark_vectorlike for bool vectors.
1129
ca26824c
GM
11302012-06-30 Glenn Morris <rgm@gnu.org>
1131
2e4c5312
GM
1132 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
1133
ca26824c
GM
1134 * epaths.in (PATH_SITELOADSEARCH): New.
1135 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
1136 This is rather than relying on --enable-locallisppath elements
1137 having "site-lisp" in their names. (Bug#10208#25, 11658)
1138
0d23c240
EZ
11392012-06-30 Eli Zaretskii <eliz@gnu.org>
1140
c9240d7a
EZ
1141 * w32proc.c (sys_select): Accept and ignore one more argument.
1142
1143 * w32.c (emacs_gnutls_pull): Call select with one more argument.
1144
0d23c240 1145 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 1146 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
1147
1148 * sysdep.c: Don't include dos.h and dosfns.h.
1149
1150 * process.c (sys_select):
1151 * msdos.c (sys_select): Accept one more argument and ignore it.
1152
1153 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
1154 adapt data types and code to that.
1155
1156 * dosfns.c:
1157 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
1158 which clashes with the gnulib function of the same name.
1159
af5a5a98
AS
11602012-06-30 Andreas Schwab <schwab@linux-m68k.org>
1161
c5e4379c
AS
1162 * font.c (font_style_to_value, font_style_symbolic)
1163 (font_prop_validate_style): Add type checks for values in
1164 font_style_table.
1165
af5a5a98
AS
1166 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
1167 argument.
1168 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
1169 uses.
1170
8d38f461
EZ
11712012-06-29 Eli Zaretskii <eliz@gnu.org>
1172
2e5a6631
EZ
1173 * xdisp.c (try_window_id): Undo last change.
1174
8d38f461
EZ
1175 * w32.c (getwd): Adjust commentary about startup_dir.
1176 (init_environment): Always call sys_access, even in non-MSVC
1177 builds. Don't chdir to the directory of the Emacs executable.
1178 This undoes code from 1997 which was justified by the need to
1179 "avoid conflicts when removing and renaming directories". But its
1180 downside was that every relative file name was being interpreted
1181 relative to the directory of the Emacs executable, which can never
1182 be TRT. In particular, it broke sys_access when called with
1183 relative file names.
1184 (sys_access): Map GetLastError to errno.
1185
2af3565e
DA
11862012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1187
1188 * window.h (struct window): Change type of 'fringes_outside_margins'
1189 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 1190 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
1191 Adjust comment.
1192 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
1193 to ptrdiff_t.
1194
c8d3a25c 11952012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 1196
c8d3a25c
GM
1197 * gnutls.c (emacs_gnutls_handshake):
1198 Add QUIT to make the loop interruptible.
57570cd3 1199
c8d3a25c 12002012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 1201
c8d3a25c
GM
1202 * charset.c (init_charset): Make lack of etc/charsets fatal.
1203
3e984ee8
DA
12042012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1205
1206 * editfns.c (region_limit): Fix type mismatch.
1207
ef884f23
DA
12082012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1209
1210 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
1211 undefined. Convert from xassert to eassert.
1212 * nsmenu.m: Convert from xassert to eassert.
1213 * nsterm.m: Likewise.
1214
7d7e0027
SM
12152012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
1216
1217 * editfns.c (region_limit): Clip to narrowing (bug#11770).
1218
aa754e6a
PE
12192012-06-28 Paul Eggert <eggert@cs.ucla.edu>
1220
1221 Avoid integer overflow on scroll-left and scroll-right.
1222 * window.c (HSCROLL_MAX): New macro.
1223 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
1224 overflow when requested scroll falls outside ptrdiff_t range.
1225
80b00b08
DA
12262012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1227
1228 * window.h (struct window): Change type of 'hscroll',
1229 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
1230 'last_modified' and 'last_overlay_modified' to EMACS_INT.
1231 Adjust users accordingly.
1232 * xdisp.c (try_cursor_movement): Replace type check with eassert.
1233 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
1234 from EMACS_INT to ptrdiff_t.
1235 (make_window): Omit redundant initialization.
1236
62b2bcf6
JB
12372012-06-28 Juanma Barranquero <lekktu@gmail.com>
1238
1239 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
1240
45942c7d
DA
12412012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1242
1243 * window.h (struct window): Change type of 'use_time' and
1244 'sequence_number' from Lisp_Object to int.
1245 * frame.c (make_frame): Adjust users accordingly.
1246 * print.c (print_object): Likewise.
1247 * window.c (select_window, Fwindow_use_time, make_parent_window)
1248 (make_window): Likewise.
1249
e509cfa6
DA
12502012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1251
1252 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
1253 enabled with --enable-checking=[all,glyphs] configure option.
1254 Fix GLYPH_DEBUG usage assuming that it may be undefined,
1255 adjust comments accordingly.
1256 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
1257 undefined, adjust comments accordingly.
1258 * image.c: Likewise.
1259 * scroll.c: Likewise.
1260 * w32fns.c: Likewise.
1261 * w32term.c: Likewise.
1262 * xdisp.c: Likewise.
1263 * xfaces.c: Likewise.
1264 * xfns.c: Likewise.
1265 * xterm.c: Likewise.
1266
a54e2c05
DA
12672012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1268
1269 Generalize run-time debugging checks.
1270 * dispextern.h (XASSERTS): Remove.
1271 * fontset.c (xassert): Remove.
1272 Convert from xassert to eassert.
1273 * alloc.c: Convert from xassert to eassert.
1274 * bidi.c: Likewise.
1275 * dispnew.c: Likewise.
1276 * fns.c: Likewise.
1277 * fringe.c: Likewise.
1278 * ftfont.c: Likewise.
1279 * gtkutil.c: Likewise.
1280 * image.c: Likewise.
1281 * keyboard.c: Likewise.
1282 * menu.c: Likewise.
1283 * process.c: Likewise.
1284 * scroll.c: Likewise.
1285 * sound.c: Likewise.
1286 * term.c: Likewise.
1287 * w32console.c: Likewise.
1288 * w32fns.c: Likewise.
1289 * w32term.c: Likewise.
1290 * window.c: Likewise.
1291 * xdisp.c: Likewise.
1292 * xfaces.c: Likewise.
1293 * xfns.c: Likewise.
1294 * xselect.c: Likewise.
1295 * xterm.c: Likewise.
1296
1ec4b7b2
SM
12972012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
1298
1299 * fns.c (maybe_resize_hash_table): Output message when growing the
1300 purify-hashtable.
1301
2014308a
DA
13022012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1303
1304 * alloc.c (allocate_string_data): Remove dead code.
1305 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
1306 avoid GCC warning about unused macro.
1307
246155eb
DA
13082012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1309
1310 * alloc.c (allocate_string): Omit intervals initialization.
1311 * alloc.c (make_uninit_multibyte_string): Initialize intervals
1312 as in make_pure_string and make_pure_c_string.
1313
43184b7b
DA
13142012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1315
d209e2fb 1316 * alloc.c (allocate_string): Fix last change.
43184b7b 1317
3fe6dd74
DA
13182012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1319
d209e2fb 1320 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
1321 to memset, add explicit initialization where appropriate.
1322
1ba6038a
GM
13232012-06-27 Glenn Morris <rgm@gnu.org>
1324
1325 * lisp.mk (lisp): Remove paths.elc.
1326
c89926a5
CY
13272012-06-27 Chong Yidong <cyd@gnu.org>
1328
1329 * doc.c (Fsubstitute_command_keys): Fix punctuation.
1330
ed6b3510
JW
13312012-06-26 John Wiegley <johnw@newartisans.com>
1332
1ec4b7b2 1333 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
1334 on Mac OS X Lion: __mod_init_func and __mod_term_func.
1335
ed6b3510
JW
1336 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
1337 when building with Clang.
1338
8edd4a2b
SM
13392012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
1340
1341 * eval.c (Fapply): Allow calling it with a single argument.
1342
f6f62d1b
EZ
13432012-06-26 Eli Zaretskii <eliz@gnu.org>
1344
1345 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
1346 _stricmp and _strnicmp.
1347 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
1348
62efea5e
DA
13492012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1350
1351 * alloc.c (allocate_window): Zero out non-Lisp part of newly
1352 allocated window.
1353 (allocate_process): Likewise for new process.
8edd4a2b 1354 (allocate_terminal): Change to use offsetof.
62efea5e
DA
1355 (allocate_frame): Likewise.
1356 * frame.c (make_frame): Omit redundant initialization.
1357 * window.c (make_parent_window): Use memset.
1358 (make_window): Omit redundant initialization.
1359 * process.c (make_process): Omit redundant initialization.
1360 * terminal.c (create_terminal): Likewise.
1361
42997f4d
DA
13622012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1363
1364 * term.c (delete_tty): Remove redundant call to memset.
1365
1130ecfc
DA
13662012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1367
1368 * alloc.c: Remove build_string.
1369 * lisp.h: Define build_string as static inline. This provides
1370 a better opportunity to optimize away calls to strlen when the
1371 function is called with compile-time constant argument.
1372 * image.c (imagemagick_error): Convert to build_string.
1373 * w32proc.c (sys_spawnve): Likewise.
1374 * xterm.c (x_term_init): Likewise.
1375
cf38a720
PE
13762012-06-26 Paul Eggert <eggert@cs.ucla.edu>
1377
99027bdd
PE
1378 Use sprintf return value instead of invoking strlen on result.
1379 In the old days this wasn't portable, since some sprintf
1380 implementations returned char *. But they died out years ago and
1381 Emacs already assumes sprintf returns int.
1382 Similarly for float_to_string.
1383 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
1384 * ccl.c (ccl_driver):
1385 * character.c (string_escape_byte8):
1386 * data.c (Fnumber_to_string):
1387 * doprnt.c (doprnt):
1388 * print.c (print_object):
1389 * xdisp.c (message_dolog):
1390 * xfns.c (syms_of_xfns):
1391 Use sprintf or float_to_string result to avoid need to call strlen.
1392 * data.c (Fnumber_to_string):
1393 Use make_unibyte_string, since the string must be ASCII.
1394 * lisp.h, print.c (float_to_string): Now returns int length.
1395 * term.c (produce_glyphless_glyph):
1396 Use sprintf result rather than recomputing it.
1397
cf38a720
PE
1398 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
1399 * Makefile.in (ALL_CFLAGS):
1400 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
1401 * gmalloc.c, regex.c: Include <config.h> unconditionally.
1402
3511c784
DA
14032012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1404
0a08eb21 1405 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
1406 strcasecmp if available.
1407 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
1408
fb7da12e
AS
14092012-06-25 Andreas Schwab <schwab@linux-m68k.org>
1410
1411 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
1412 Avoid comma operator.
1413 * menu.c (push_submenu_start, push_submenu_end)
1414 (push_left_right_boundary, push_menu_pane): Likewise.
1415 * msdos.c (dos_rawgetc): Likewise.
1416
afa2ffd8
DA
14172012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1418
1419 * xfns.c (xic_create_fontsetname): Remove redundant calls
1420 to memset.
1421
b3b4476b
PE
14222012-06-25 Paul Eggert <eggert@cs.ucla.edu>
1423
4495ff38
PE
1424 * gtkutil.c (get_utf8_string): Remove redundant assignment.
1425 sprintf already null-terminates its output.
1426
b3b4476b
PE
1427 * xfns.c (x_window): Remove redundant cast.
1428
b00876c9
DA
14292012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1430
1431 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
1432 `const char *' to `char *' to avoid compiler warning.
1433
d188e26b
PE
14342012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1435
885d1d74
PE
1436 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
1437 instead of truncating it to 63 (admittedly a generous limit).
1438
d188e26b
PE
1439 * process.c: Fix spelling and caps in comments.
1440
e2f560b1
DN
14412012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
1442
e86db54b 1443 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
1444 * sysdep.c (setpgrp): Remove definition, not used in this file.
1445
7583a3a1
JB
14462012-06-24 Juanma Barranquero <lekktu@gmail.com>
1447
1448 * makefile.w32-in: Update dependencies.
1449
696056c2
EZ
14502012-06-24 Eli Zaretskii <eliz@gnu.org>
1451
1452 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
1453 (SYSTIME_H): Add nt/inc/sys/time.h.
1454
1455 * systime.h [WINDOWSNT]: Include sys/time.h.
1456
1457 * s/ms-w32.h (struct timespec): Definition moved from
1458 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
1459
845ca893
PE
14602012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1461
1462 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
1463 * buffer.h (buffer_slot_type_mismatch):
1464 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1465 * eval.c (unwind_to_catch):
1466 * image.c (my_png_error, my_error_exit):
1467 * keyboard.c (quit_throw_to_read_char, user_error)
1468 (Fexit_recursive_edit, Fabort_recursive_edit):
1469 * lisp.h (die, args_out_of_range, args_out_of_range_3)
1470 (wrong_type_argument, buffer_overflow, __executable_start)
1471 (memory_full, buffer_memory_full, string_overflow, Fthrow)
1472 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
1473 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
1474 (fatal):
1475 (child_setup) [!DOS_NT]:
1476 * lread.c (end_of_file_error, invalid_syntax):
1477 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1478 * puresize.h (pure_write_error):
1479 * search.c (matcher_overflow):
1480 * sound.c (sound_perror, alsa_sound_perror):
1481 * sysdep.c, syssignal.h (croak):
1482 * term.c (maybe_fatal, vfatal):
1483 * textprop.c (text_read_only):
1484 * undo.c (user_error):
1485 * unexmacosx.c (unexec_error):
1486 * xterm.c (x_ins_del_lines, x_delete_glyphs):
1487 Use _Noreturn rather than NO_RETURN.
1488 No need for separate decl merely because of _Noreturn.
1489 * sound.c (sound_warning, parse_sound):
1490 Remove unnecessary forward decls.
1491
f1dd8073
PE
14922012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1493
1494 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
1495 * lisp.h (WAIT_READING_MAX): New macro.
1496 * dispnew.c (Fsleep_for, sit_for):
1497 * keyboard.c (kbd_buffer_get_event):
1498 * process.c (Faccept_process_output):
1499 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
1500 This improves on the previous patch, which introduced a bug
1501 when time_t is unsigned and as wide as intmax_t.
1502 See <http://bugs.gnu.org/9000#51>.
1503
b82c1755
EZ
15042012-06-23 Eli Zaretskii <eliz@gnu.org>
1505
1506 * dispnew.c (sit_for, Fsleep_for):
1507 * keyboard.c (kbd_buffer_get_event):
1508 * process.c (Faccept_process_output): Avoid compiler warnings when
1509 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
1510
ca300656
JB
15112012-06-23 Juanma Barranquero <lekktu@gmail.com>
1512
049ec95b
JB
1513 * makefile.w32-in: Update dependencies.
1514
ca300656
JB
1515 * w32.c (ltime): Add return type and declare static.
1516 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
1517
db7b8d06
PE
15182012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1519
1520 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
1521 Privately reported by Herbert J. Skuhra.
1522 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
1523 All uses changed.
1524 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
1525 not make_lisp_timeval, when the argument is of type EMACS_TIME.
1526
0bd8297f
EZ
15272012-06-23 Eli Zaretskii <eliz@gnu.org>
1528
96512555
EZ
1529 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
1530 last argument of make_unibyte_string.
1531
0bd8297f
EZ
1532 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
1533 language ID in the event parameters.
1534
1535 * w32term.c (w32_read_socket): Put the new keyboard codepage into
1536 event.code, not the obscure "character set ID".
1537
63def6b6
CY
15382012-06-23 Chong Yidong <cyd@gnu.org>
1539
1540 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
1541
e8a02204
EZ
15422012-06-23 Eli Zaretskii <eliz@gnu.org>
1543
388cdec0
EZ
1544 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
1545 * w32.c (fdutimens): New function.
1546
1547 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
1548
1549 * s/ms-w32.h (pselect): Redirect to sys_select.
1550
1551 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
1552
e8a02204
EZ
1553 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
1554 in the logic of incrementing and decrementing the value of
1555 use_relocatable_buffers.
1556
d054f3fb
PE
15572012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1558
1559 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
1560 Privately reported by Herbert J. Skuhra.
1561 [__FreeBSD__]: Remove "*/" typo after "#include".
1562 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
1563 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
1564 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
1565 Don't assume EMACS_TIME and struct timeval are the same type.
1566
d35af63c
PE
15672012-06-22 Paul Eggert <eggert@cs.ucla.edu>
1568
1569 Support higher-resolution time stamps (Bug#9000).
1570 The time stamps are only nanosecond-resolution at the C level,
1571 since that's the best that any real-world system supports now.
1572 But they are picosecond-resolution at the Lisp level, as that's
1573 easy, and leaves room for future OS improvements.
1574
1575 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
1576 (LIBES): Use it.
1577
1578 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
1579 Don't get current time unless it's needed.
1580
1581 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
1582 now provides it if it's absent.
1583 (start_atimer): Port to higher-res time stamps.
1584 Check for time stamp overflow. Don't get current time more
1585 often than is needed.
1586
1587 * buffer.h (struct buffer): Buffer modtime now has high resolution.
1588 Include systime.h, not time.h.
1589 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
1590
1591 * dired.c: Include stat-time.h.
1592 (Ffile-attributes): File times now have higher resolution.
1593
1594 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
1595 (struct image): Timestamp now has higher resolution.
1596
1597 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
1598 has at least microseconds now. All uses removed.
1599 (update_frame, update_single_window, update_window, update_frame_1)
1600 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
1601
1602 * editfns.c (time_overflow): Now extern.
1603 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
1604 (float-time, Fformat_time_string, Fcurrent_time_string)
1605 (Fcurrent_time_zone): Accept and generate higher-resolution
1606 time stamps.
1607 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
1608 (decode_time_components, lisp_seconds_argument): New functions.
1609 (make_time): Now static.
1610 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
1611 Report an error if the time is invalid, rather than having the caller
1612 do that.
1613
1614 * fileio.c: Include <stat-time.h>
1615 (Fcopy_file): Copy higher-resolution time stamps.
1616 Prefer to set the time stamp via a file descriptor if that works.
1617 (Fset_file_times, Finsert_file_contents, Fwrite_region)
1618 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
1619 (Fvisited_file_modtime, Fset_visited_file_modtime):
1620 Support higher-resolution time stamps.
1621
1622 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
1623
1624 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
1625
1626 * image.c (prepare_image_for_display, clear_image_cache)
1627 (lookup_image): Port to higer-resolution time stamps.
1628
1629 * keyboard.c (start_polling, bind_polling_period):
1630 Check for time stamp overflow.
1631 (read_char, kbd_buffer_get_event, timer_start_idle)
1632 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
1633 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
1634 Port to higher-resolution time stamps. Do not assume time_t is signed.
1635 (decode_timer): New function. Timers are now vectors of length 9,
1636 not 8, to accommodate the picosecond component.
1637 (timer_check_2): Use it.
1638
1639 * nsterm.m (select_timeout, timeval_subtract): Remove.
1640 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
1641 as they're a bit more accurate and handle overflow better.
1642 (ns_select): Change prototype to be compatible with pselect.
1643 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
1644 * nsterm.h (ns_select): Adjust prototype.
1645
1646 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
1647 us-resolution time stamps.
1648 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
1649
1650 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
1651
1652 * lisp.h (time_overflow): New decl.
1653 (wait_reading_process_output): First arg is now intmax_t, not int,
1654 to accommodate larger waits.
1655
1656 * process.h (struct Lisp_Process.read_output_delay):
1657 Now counts nanoseconds, not microseconds.
1658 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
1659 EMACS_HAS_USECS.
1660 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
1661 (wait_reading_process_output):
1662 Port to ns-resolution time stamps.
1663 (Faccept_process_output, wait_reading_process_output):
1664 Check for time stamp overflow. Do not assume time_t is signed.
1665 (select_wrapper): Remove; we now use pselect.
1666 (Fprocess_attributes): Now generates ns-resolution time stamps.
1667
1668 * sysdep.c: Include utimens.h. Don't include utime.h
1669 or worry about struct utimbuf; gnulib does that for us now.
1670 (gettimeofday): Remove; gnulib provides a substitute.
1671 (make_timeval): New function.
1672 (set_file_times): Now sets ns-resolution time stamps.
1673 New arg FD; all uses changed.
1674 (time_from_jiffies, ltime_from_jiffies, get_up_time)
1675 (system_process_attributes):
1676 Now returns ns-resolution time stamp. All uses changed.
1677 Check for time stamp overflow.
1678
1679 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
1680 provides a substitute now.
1681
1682 * systime.h: Include timespec.h rather than sys/time.h and time.h,
1683 since it guarantees struct timespec.
1684 (EMACS_TIME): Now struct timespec, so that we can support
1685 ns-resolution time stamps.
1686 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
1687 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
1688 (EMACS_USECS): Remove.
1689 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
1690 so multiply the arg by 1000 before storing it.
1691 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
1692 New macros.
1693 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
1694 Port to ns-resolution time stamps.
1695 (EMACS_TIME_NEG_P): Remove; replaced by....
1696 (EMACS_TIME_SIGN): New macro.
1697 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
1698 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
1699 (set_file_times, make_time, lisp_time_argument): Adjust signature.
1700 (make_timeval, make_lisp_time, decode_time_components): New decls.
1701 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
1702 that it mishandled time_t overflow. You can't compare by subtracting!
1703 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
1704 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
1705
1706 * term.c: Include <sys/time.h>.
1707 (timeval_to_Time): New function, for proper overflow wraparound.
1708 (term_mouse_position, term_mouse_click): Use it.
1709
1710 * undo.c (record_first_change): Support higher-resolution time stamps
1711 in the undo buffer.
1712 (Fprimitive_undo): Use them when restoring time stamps.
1713
1714 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
1715 (w32_get_internal_run_time):
1716 Port to higher-resolution Emacs time stamps.
1717 (ltime): Now accepts single 64-bit integer, as that's more convenient
1718 for callers.
1719
1720 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
1721
1722 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
1723 for compatibility with pselect. Support ns-resolution time stamps.
1724
1725 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
1726
1727 * xselect.c (wait_for_property_change, x_get_foreign_selection):
1728 Check for time stamp overflow, and support ns-resolution time stamps.
1729
1730 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
1731 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
1732 (timeval_subtract): Remove; no longer needed.
1733 (XTflash, XTring_bell, x_wait_for_event):
1734 Port to ns-resolution time stamps. Don't assume time_t is signed.
1735
b6a92dfe
CY
17362012-06-22 Chong Yidong <cyd@gnu.org>
1737
1738 * xdisp.c (x_consider_frame_title): Revert last change.
1739
d251c37c
EZ
17402012-06-22 Eli Zaretskii <eliz@gnu.org>
1741
1742 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
1743 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
1744 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
1745 staticidx goes up to 1597 out of 1600 = 0x640.)
1746
f10deafb
PE
17472012-06-20 Paul Eggert <eggert@cs.ucla.edu>
1748
1749 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
1750 Otherwise, the umask might be mistakenly 0 while handling input signals.
1751
ec6de1e2
SM
17522012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
1753
1754 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
1755
28be1ada
DA
17562012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
1757
1758 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
1759 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
1760 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
1761 access to `contents' member of Lisp_Vector objects with AREF and ASET
1762 where appropriate.
1763
c6bf3022
CY
17642012-06-19 Chong Yidong <cyd@gnu.org>
1765
1766 * frame.c (delete_frame): When selecting a frame on a different
1767 text terminal, do not alter the terminal's top-frame.
1768
1769 * xdisp.c (format_mode_line_unwind_data): Record the target
1770 frame's selected window and its terminal's top-frame.
1771 (unwind_format_mode_line): Restore them.
1772 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
1773 Callers changed.
1774 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
1775 since tty frames can be explicitly named.
1776 (prepare_menu_bars): Likewise.
1777
1778 * term.c (Ftty_top_frame): New function.
1779
defd4196
PE
17802012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1781
1782 Port byte-code-meter to modern targets.
1783 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
1784 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 1785 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
1786 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
1787 (METER_1, METER_2): Simplify.
1788
1053a871
SM
17892012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
1790
1791 * data.c (Fdefalias): Return `symbol' (bug#11686).
1792
b7e8d081
MR
17932012-06-18 Martin Rudalics <rudalics@gmx.at>
1794
1795 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
1796 gets killed during executing of this function (Bug#11665).
1797 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
1798 (Vkill_buffer_query_functions): In doc-string say that functions
1799 run by this hook should not change the current buffer.
1800
7ea2b339
PE
18012012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1802
1803 Fix recently-introduced process.c problems found by static checking.
1804 * process.c (write_queue_push, write_queue_pop, send_process):
1805 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
1806 (write_queue_pop): Fix pointer signedness problem.
1807 (send_process): Remove unused local.
1808
96a313a1
CY
18092012-06-17 Chong Yidong <cyd@gnu.org>
1810
1811 * xdisp.c (redisplay_internal): No need to redisplay terminal
1812 frames that are not on top.
1813
20ca2e94
TN
18142012-06-17 Troels Nielsen <bn.troels@gmail.com>
1815
1816 * process.c (make_process): Initialize write_queue.
1817 (write_queue_push, write_queue_pop): New functions.
1818 (send_process): Use them to maintain correct ordering of process
1819 writes (Bug#10815).
1820
9a900ca9
PE
18212012-06-17 Paul Eggert <eggert@cs.ucla.edu>
1822
310fbfa8
PE
1823 * lisp.h (eassert): Assume C89 or later.
1824 This removes the need for CHECK.
1825 (CHECK): Remove. Its comments about always evaluating its
1826 argument were confusing, as 'eassert' typically does not evaluate
1827 its argument.
1828
27bb1ca4
PE
1829 * coding.c (produce_chars): Use ptrdiff_t, not int.
1830
9a900ca9
PE
1831 * xterm.c (x_draw_underwave): Check for integer overflow.
1832 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
1833
41b7f8bc 18342012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
1835
1836 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
1837 referenced (Bug#11583).
1838
9b0e3eba
AA
18392012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
1840
1841 Implement wave-style variant of underlining.
1842 * dispextern.h (face_underline_type): New enum.
1843 (face): Add field for underline type.
1844 * nsterm.m (ns_draw_underwave): New function.
1845 (ns_draw_text_decoration): Use it.
1846 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
1847 New functions.
1848 (x_draw_glyph_string): Use them.
1849 * xfaces.c (Qline, Qwave): New Lisp objects.
1850 (check_lface_attrs, merge_face_ref)
1053a871
SM
1851 (Finternal_set_lisp_face_attribute, realize_x_face):
1852 Handle wave-style underline face attributes.
9b0e3eba
AA
1853 * xterm.c (x_draw_underwave): New function.
1854 (x_draw_glyph_string): Use it.
1855
0fb52f11
JB
18562012-06-16 Juanma Barranquero <lekktu@gmail.com>
1857
1858 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
1859 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
1860 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
1861 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
1862 ($(BLD)/w32select.$(O)): Update dependencies.
1863
e5560ff7
AS
18642012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1865
1866 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
1867 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
1868 * character.c (_fetch_multibyte_char_p): Remove.
1869 * alloc.c: Include "character.h" before "buffer.h".
1870 * bidi.c: Likewise.
1871 * buffer.c: Likewise.
1872 * bytecode.c: Likewise.
1873 * callint.c: Likewise.
1874 * callproc.c: Likewise.
1875 * casefiddle.c: Likewise.
1876 * casetab.c: Likewise.
1877 * category.c: Likewise.
1878 * cmds.c: Likewise.
1879 * coding.c: Likewise.
1880 * composite.c: Likewise.
1881 * dired.c: Likewise.
1882 * dispnew.c: Likewise.
1883 * doc.c: Likewise.
1884 * dosfns.c: Likewise.
1885 * editfns.c: Likewise.
1886 * emacs.c: Likewise.
1887 * fileio.c: Likewise.
1888 * filelock.c: Likewise.
1889 * font.c: Likewise.
1890 * fontset.c: Likewise.
1891 * fringe.c: Likewise.
1892 * indent.c: Likewise.
1893 * insdel.c: Likewise.
1894 * intervals.c: Likewise.
1895 * keyboard.c: Likewise.
1896 * keymap.c: Likewise.
1897 * lread.c: Likewise.
1898 * macros.c: Likewise.
1899 * marker.c: Likewise.
1900 * minibuf.c: Likewise.
1901 * nsfns.m: Likewise.
1902 * nsmenu.m: Likewise.
1903 * print.c: Likewise.
1904 * process.c: Likewise.
1905 * regex.c: Likewise.
1906 * region-cache.c: Likewise.
1907 * search.c: Likewise.
1908 * syntax.c: Likewise.
1909 * term.c: Likewise.
1910 * textprop.c: Likewise.
1911 * undo.c: Likewise.
1912 * unexsol.c: Likewise.
1913 * w16select.c: Likewise.
1914 * w32fns.c: Likewise.
1915 * w32menu.c: Likewise.
1916 * window.c: Likewise.
1917 * xdisp.c: Likewise.
1918 * xfns.c: Likewise.
1919 * xmenu.c: Likewise.
1920 * xml.c: Likewise.
1921 * xselect.c: Likewise.
1922
2f07e6af
EZ
19232012-06-16 Eli Zaretskii <eliz@gnu.org>
1924
1053a871
SM
1925 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
1926 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 1927 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
1928 row.
1929 (handle_face_prop): Use chunk-relative overlay string index when
1930 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
1931 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
1932 the rightmost. (Bug#11720)
2f07e6af 1933
29b83cec
AS
19342012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1935
1936 * category.h (CHAR_HAS_CATEGORY): Define as inline.
1937 (CATEGORY_MEMBER): Enforce 1/0 value.
1938 * category.c (_temp_category_set): Remove.
1939
4c5501e9
EZ
19402012-06-16 Eli Zaretskii <eliz@gnu.org>
1941
1942 * window.c (Fdelete_other_windows_internal)
1943 (Fdelete_window_internal): Don't access frame's mouse highlight
1944 info of the initial frame. (Bug#11677)
1945
2b570124
PE
19462012-06-14 Paul Eggert <eggert@cs.ucla.edu>
1947
e93864f9
PE
1948 * .gdbinit (xgetint): Fix recently-introduced paren typo.
1949 Assume USE_2_TAGS_FOR_INTS.
1950 (xreload): Adjust $tagmask width to match recent lisp.h change.
1951
2b570124
PE
1952 Simplify lisp.h in minor ways that should not affect code.
1953 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
1954 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
1955 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
1956 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
1957 (INTTYPEBITS): New macro, for clarity.
1958 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
1959 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
1960 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
1961 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
1962 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
1963
81755f69
JB
19642012-06-13 Juanma Barranquero <lekktu@gmail.com>
1965
1966 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
1967
16192a57
GM
19682012-06-13 Glenn Morris <rgm@gnu.org>
1969
1970 * s/bsd-common.h (BSD4_3):
1971 * s/usg5-4-common.h (USG5_4): No longer define; unused.
1972
646b5f55
AS
19732012-06-13 Andreas Schwab <schwab@linux-m68k.org>
1974
1975 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
1976 instead of union.
1977 (XLI, XIL): Define.
1053a871
SM
1978 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
1979 Use them.
1980 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 1981 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 1982 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
1983 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
1984 * frame.c (delete_frame): Remove outdated comment.
1985 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
1986 USE_LISP_UNION_TYPE.
1987 (Fw32_unregister_hot_key): Likewise.
1988 (Fw32_toggle_lock_key): Likewise.
1989 * w32menu.c (add_menu_item): Likewise.
1990 (w32_menu_display_help): Use XIL instead of checking
1991 USE_LISP_UNION_TYPE.
1992 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
1993 (init_heap): Likewise.
1994 * w32term.c (w32_read_socket): Update comment.
1995
1d3823c9
GM
19962012-06-13 Glenn Morris <rgm@gnu.org>
1997
c62ff706
GM
1998 * s/usg5-4-common.h, src/s/unixware.h:
1999 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
2000
1d3823c9
GM
2001 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
2002
bfe3e0a2
PE
20032012-06-13 Paul Eggert <eggert@cs.ucla.edu>
2004
2005 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
2006 * alloc.c (make_number) [!defined make_number]:
2007 Remove, as lisp.h always defines this now.
2008 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
2009 (roundup_size): Verify that it is a power of 2.
2010 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
2011 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
2012 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
2013 -DUSE_LSB_TAG=0, to override the automatically-selected default.
2014 USE_LSB_TAG now is always defined to be either 0 or 1.
2015 All uses changed.
2016 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
2017 code works fine either way, and efficiency is not a concern here,
2018 as the union type is for debugging, not for production.
2019 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
2020 Use an inline function on all platforms when using the union type,
2021 since this is simpler and 'static inline' can be used portably
2022 within Emacs now.
2023 (LISP_INITIALLY_ZERO): New macro.
2024 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
2025 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
2026
45fa9c0f
GM
20272012-06-12 Glenn Morris <rgm@gnu.org>
2028
b4492cba
GM
2029 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
2030
2031 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 2032
45fa9c0f
GM
2033 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
2034 Move BROKEN_SIGIO to configure.
2035
2036 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
2037 Move NO_TERMIO to configure.
2038
0e25d334
CY
20392012-06-12 Chong Yidong <cyd@gnu.org>
2040
2041 * image.c (imagemagick_load_image): Use MagickFlattenImage if
2042 MagickMergeImageLayers is undefined. Use pixel pusher loop if
2043 MagickExportImagePixels is undefined.
2044
43682bb6
PE
20452012-06-12 Paul Eggert <eggert@cs.ucla.edu>
2046
2047 * image.c (imagemagick_load_image): Remove unused label.
2048
a9be7d2b
GM
20492012-06-11 Glenn Morris <rgm@gnu.org>
2050
2051 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
2052 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
2053 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
2054 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
2055
3017f87f
SM
20562012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
2057
2058 * alloc.c (make_byte_code): New function.
2059 (Fmake_byte_code): Use it. Don't purify here.
2060 * lread.c (read1): Use it as well to avoid extra allocation.
2061
1b9b4cf4
CY
20622012-06-11 Chong Yidong <cyd@gnu.org>
2063
2064 * image.c (imagemagick_load_image): Implement transparency.
2065
95988fcf
AS
20662012-06-10 Andreas Schwab <schwab@linux-m68k.org>
2067
2068 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
2069 account for preceding backslashes. (Bug#11663)
2070
cd4eb164
CY
20712012-06-09 Chong Yidong <cyd@gnu.org>
2072
2073 * term.c: Support italics in capable terminals (Bug#9652).
2074 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
2075 (turn_on_face): Output using TS_enter_italic_mode if available.
2076 Don't handle unused blinking and alt-charset cases.
2077 (turn_off_face): Handle italic case; discard unused tty_blinking_p
2078 and tty_alt_charset_p cases.
2079 (tty_capable_p, init_tty): Support italics.
2080
2081 * termchar.h (struct tty_display_info): Add field for italics.
2082 Remove unused blink field.
2083
2084 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
2085 Handle slant.
2086
2087 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
2088 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
2089 tty_alt_charset_p. Add tty_italic_p.
2090
ff88beb8
MA
20912012-06-09 Michael Albinus <michael.albinus@gmx.de>
2092
2093 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
2094 dbus_type_is_basic if available.
2095 (xd_extract_signed, xd_extract_unsigned): Rename from
2096 extract_signed and extract_unsigned, respectively. Adapt callers.
2097
44286096
CY
20982012-06-09 Chong Yidong <cyd@gnu.org>
2099
1682701f
CY
2100 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
2101
44286096
CY
2102 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
2103 case (Bug#9752).
2104
d86feb17
PE
21052012-06-08 Paul Eggert <eggert@cs.ucla.edu>
2106
2107 * xdisp.c (vmessage): Treat frame message as multibyte.
2108 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
2109 would generate the diagnostic "Making \302\247 buffer-local while
2110 let-bound!".
2111
d5c20fe8
EZ
21122012-06-08 Eli Zaretskii <eliz@gnu.org>
2113
2114 * dispnew.c (showing_window_margins_p): Undo last change, which
2115 was done due to an inadvertent commit.
2116 (adjust_frame_glyphs_for_frame_redisplay): Do call
2117 showing_window_margins_p.
2118
513749ee
SM
21192012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2120
2121 * eval.c (Fmake_var_non_special): New primitive.
2122 (syms_of_eval): Defsubr it.
2123 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
2124
d4a8f5c1
JB
21252012-06-08 Juanma Barranquero <lekktu@gmail.com>
2126
2127 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
2128 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
2129
8bbbc977
EZ
21302012-06-08 Eli Zaretskii <eliz@gnu.org>
2131
2132 * alloc.c (allocate_vectorlike): Fix last change.
2133
f3372c87
DA
21342012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
2135
2136 Block-based vector allocation of small vectors.
2137 * lisp.h (struct vectorlike_header): New field `nbytes',
2138 adjust comment accordingly.
2139 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
2140 to denote vector blocks. Adjust users (live_vector_p,
2141 mark_maybe_pointer, valid_lisp_object_p) accordingly.
2142 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
2143 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
2144 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
2145 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
2146 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
2147 (roundup_size): New constant.
2148 (struct vector_block): New data type.
2149 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 2150 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
2151 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
2152 (sweep_vectors): New functions.
2153 (allocate_vectorlike): Return `zero_vector' as the only vector of
2154 0 items. Allocate new vector from block if vector size is less than
2155 or equal to VBLOCK_BYTES_MAX.
2156 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
2157 (init_alloc_once): Add call to init_vectors.
2158
4f18a4ed
SM
21592012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2160
2161 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
2162
86f158bc
PE
21632012-06-07 Paul Eggert <eggert@cs.ucla.edu>
2164
2165 * doprnt.c (doprnt): Truncate multibyte char correctly.
2166 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
2167 would mishandle a string argument "Xc" if X was a multibyte
2168 character of length 2: it would truncate after X's first byte
2169 rather than including all of X.
2170
c5cfcbe0
CY
21712012-06-06 Chong Yidong <cyd@gnu.org>
2172
2173 * buffer.c (word_wrap): Doc fix.
2174
c05cf390
PE
21752012-06-04 Paul Eggert <eggert@cs.ucla.edu>
2176
2177 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
2178
0c3461de
GM
21792012-06-03 Glenn Morris <rgm@gnu.org>
2180
2181 * xdisp.c (tool-bar-style): Doc fix.
2182
c71232db
UM
21832012-06-03 Ulrich Müller <ulm@gentoo.org>
2184
2185 * Makefile.in (PAXCTL): Define.
2186 (temacs$(EXEEXT)): Disable memory randomization for the temacs
2187 binary via PaX flags if the paxctl utility is available.
2188 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
2189 Restore PaX flags to their default. (Bug#11398)
2190
383f7350
CY
21912012-06-03 Chong Yidong <cyd@gnu.org>
2192
2193 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
2194 buffer (Bug#11226).
2195
5f2c76c6
CY
21962012-06-03 Chong Yidong <cyd@gnu.org>
2197
2198 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
2199 (note_mode_line_or_margin_highlight): If there is no help echo,
2200 use mode-line-default-help-echo. Handle the case where the mouse
2201 position is past the end of the mode line string.
2202
2203 * buffer.c (buffer_local_value_1): New function, split from
2204 Fbuffer_local_value; can return Qunbound.
2205 (Fbuffer_local_value): Use it.
2206 (Vmode_line_format): Docstring tweaks.
2207
773d47f6
PE
22082012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2209
2210 * sysdep.c (system_process_attributes): Improve comment.
2211
f2d6a3df
SM
22122012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
2213
2214 * keyboard.c: Export real-this-command to Elisp.
2215 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
2216 and DEFVAR it. Update all users.
2217
63810350
PE
22182012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2219
7bd5c1f4
PE
2220 * minibuf.c (Fassoc_string): Remove duplicate declaration.
2221
63810350
PE
2222 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
2223 Convert pctcpu and pctmem to Lisp float properly.
2224 Let the compiler fold better, as 100.0/0x8000 is exact.
2225
a2821611
AS
22262012-06-02 Andreas Schwab <schwab@linux-m68k.org>
2227
2228 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
2229 cons_block.
2230
5fceba1d
PE
22312012-06-01 Paul Eggert <eggert@cs.ucla.edu>
2232
2233 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
2234
c98ff5dd
DA
22352012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
2236
2237 For a 'struct window', replace some Lisp_Object fields to
2238 bitfields where appropriate, remove unused fields.
2239 * window.h (struct window): Remove unused 'last_mark_x' and
2240 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
2241 change it's type from Lisp_Object to bitfield.
2242 Change type of 'force_start', 'optional_new_start',
2243 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
2244 fields from Lisp_Object to bitfield. Adjust users accordingly.
2245
ca34e0be
PE
22462012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2247
2248 Pacify gcc -Wdouble-precision when using Xaw.
2249 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
2250 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
2251 Use 'float' consistently, rather than 'float' in most places
2252 and 'double' in a couple of places.
2253
efc00ab1 22542012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
2255
2256 * xdisp.c (handle_stop): Detect whether we have overlay strings
2257 loaded by testing it->current.overlay_string_index to be
2258 non-negative, instead of checking whether n_overlay_strings is
2259 positive. (Bug#11587)
2260
efc00ab1 22612012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
2262
2263 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
2264
2265 * doc.c (Fsubstitute_command_keys): Doc fix.
2266
efc00ab1 22672012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
2268
2269 * search.c (search_buffer): Remove calls to
2270 r_alloc_inhibit_buffer_relocation, as it is now called by
2271 maybe_unify_char, which was the cause of relocation of buffer text
2272 in bug#11519.
2273
efc00ab1 22742012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
2275
2276 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
2277 for the duration of call to load_charset, to avoid problems with
2278 callers of maybe_unify_char that access buffer text through C
2279 pointers.
2280
2281 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
2282 decrement the inhibition flag, instead of just setting or
2283 resetting it.
2284
ba93a187
PE
22852012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2286
2287 Remove obsolete '#define static' cruft.
2288 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
2289 This #undef was "temporary" in 2000; it is no longer needed
2290 now that '#define static' has gone away.
2291 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
2292 (gray_bitmap_bits): Remove; no longer needed.
2293 All uses replaced with definiens.
2294 * xterm.c: Include "bitmaps/gray.xbm".
2295
9e4bf381
PE
22962012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2297
2298 Clean up __executable_start, monstartup when --enable-profiling.
2299 The following changes affect the code only when profiling.
2300 * dispnew.c (__executable_start): Rename from safe_bcopy.
2301 Define only on platforms that need it.
2302 * emacs.c: Include <sys/gmon.h> when profiling.
2303 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
2304 (__executable_start): Remove decl, since lisp.h does it now.
2305 (safe_bcopy): Remove decl; no longer has that name.
2306 (main): Coalesce #if into single bit of code, for simplicity.
2307 Cast pointers to uintptr_t, since standard libraries want integers
2308 and not pointers.
2309 * lisp.h (__executable_start): New decl.
2310
32d72c2f
GM
23112012-05-31 Glenn Morris <rgm@gnu.org>
2312
2313 * image.c (Fimagemagick_types): Doc fix.
2314
baac5bc7
JM
23152012-05-30 Jim Meyering <meyering@redhat.com>
2316
2317 * callproc.c (Fcall_process_region): Include directory component
2318 in mkstemp error message (Bug#11586).
2319
72cb32cf
PE
23202012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2321
2322 * alloc.c, lisp.h (make_pure_vector): Now static.
2323
61b108cc
SM
23242012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
2325
2326 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
2327 Move to byte-run.el.
2328 (Fautoload): Do the hash-doc more carefully.
2329 * data.c (Fdefalias): Purify definition, except for keymaps.
2330 (Qdefun): Move from eval.c.
2331 * lisp.h (Qdefun): Remove.
2332 * lread.c (read1): Tiny simplification.
2333
471fe23d
TN
23342012-05-29 Troels Nielsen <bn.troels@gmail.com>
2335
934f3f58 2336 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
2337 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
2338 Bug#9642, but explicitly check that the buffer the overlay would
2339 be moved to is live and rearrange lines to make sure that errors
2340 will not put the overlay in an inconsistent state.
2341 (Fdelete_overlay): Cosmetics.
2342
85d0efd1
EZ
23432012-05-28 Eli Zaretskii <eliz@gnu.org>
2344
2345 * w32term.c (my_bring_window_to_top): New function.
2346 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
2347 could be different from the original one.
2348 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
2349 (Bug#11513)
2350
2351 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
2352 by calling BringWindowToTop.
2353
2354 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
2355 (WM_EMACS_END): Increase by one.
2356
da92a98c
PE
23572012-05-28 Paul Eggert <eggert@cs.ucla.edu>
2358
2359 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
2360 This avoids undefined behavior that might cause the eassert
2361 to not catch an out-of-range value.
2362
74d1f848
JB
23632012-05-28 Juanma Barranquero <lekktu@gmail.com>
2364
2365 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
2366 Update dependencies.
2367
9e1a06fc
EZ
23682012-05-27 Eli Zaretskii <eliz@gnu.org>
2369
2370 * bidi.c (bidi_mirror_char): Fix last change.
2371
f3dd7312
AS
23722012-05-27 Andreas Schwab <schwab@linux-m68k.org>
2373
2374 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
2375 when referring to sectname field in printf format.
2376
81899c91
PE
23772012-05-27 Paul Eggert <eggert@cs.ucla.edu>
2378
57b81a9f
PE
2379 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
2380 Only r_alloc_inhibit_buffer_relocation needed to be added;
2381 the others were already declared.
2382
81899c91
PE
2383 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
2384 before checking whether it's out of range. Put the check inside
2385 eassert. See
2386 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
2387
33017faf 23882012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
2389
2390 * callproc.c (Fcall_process): Restore a line that was accidentally
2391 commented out in the 2011-02-13 change (bug#11547).
2392
33017faf 23932012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
2394
2395 * lisp.h [REL_ALLOC]: Add prototypes for external functions
2396 defined on ralloc.c.
2397
2398 * buffer.c [REL_ALLOC]: Remove prototypes of
2399 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
2400 they are now on lisp.h.
2401
2402 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
2403
2404 * search.c (search_buffer): Use it to inhibit relocation of buffer
2405 text while re_search_2 is doing its job, because re_search_2 is
2406 passed C pointers to buffer text. (Bug#11519)
2407
23415acf
EZ
2408 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
2409 Update value to 24.
2410
44e27368
EZ
2411 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
2412 state after an additional call to move_it_in_display_line_to, keep
2413 the values of it->max_ascent and it->max_descent found for the
2414 entire line.
2415 (pos_visible_p): Revert the comparison against bottom_y to what it
2416 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
2417 (Bug#11464)
2418
c1892f11
PE
24192012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2420
2421 Fix coding-related core dumps with gcc -ftrapv.
2422 The code was computing A - B, where A and B are pointers, and B is
2423 random garbage. This can lead to core dumps on platforms that
2424 have special pointer registers, and it also leads to core dumps on
2425 x86-64 when compiled with gcc -ftrapv. The fix is to compute
2426 A - B only when B is initialized properly.
2427 * coding.c (coding_set_source, coding_set_destination): Return void.
2428 (coding_change_source, coding_change_destinations): New functions,
2429 with the old behaviors of coding_set_source and coding_set_destination.
2430 All callers that need an offset changed to use these new functions.
2431
eb7afdad
GM
24322012-05-26 Glenn Morris <rgm@gnu.org>
2433
2434 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
2435
f12fdf02
EZ
24362012-05-26 Eli Zaretskii <eliz@gnu.org>
2437
53a63be6 2438 Extend mouse support on W32 text-mode console.
61b108cc
SM
2439 * xdisp.c (draw_row_with_mouse_face):
2440 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 2441
eb3f6f01 2442 * w32console.c: Include window.h.
61b108cc
SM
2443 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
2444 New functions.
eb3f6f01
EZ
2445 (initialize_w32_display): Initialize mouse-highlight data.
2446
53a63be6
EZ
2447 * w32inevt.c: Include termchar.h and window.h.
2448 (do_mouse_event): Support mouse-autoselect-window. When the mouse
2449 moves, call note_mouse_highlight. If help_echo changed, call
2450 gen_help_event to produce help-echo message in the echo area.
2451 Call clear_mouse_face if mouse_face_hidden is set in the mouse
2452 highlight info.
2453
4cfd81f6
PE
24542012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2455
2456 * lread.c (read1): Simplify slightly to avoid an overflow warning
2457 with GCC 4.7.0 on x86-64.
2458
4446092a
EZ
24592012-05-26 Eli Zaretskii <eliz@gnu.org>
2460
2461 * bidi.c (bidi_mirror_char): Revert last change: an int is
2462 definitely wide enough here.
2463
42b2a986 24642012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 2465
42b2a986 2466 Fix integer width and related bugs (Bug#9874).
eb106a49 2467 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
2468 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
2469 (string_bytes, check_sblock, allocate_string_data):
2470 (compact_small_strings, Fmake_bool_vector, make_string)
2471 (make_unibyte_string, make_multibyte_string)
2472 (make_string_from_bytes, make_specified_string)
2473 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
2474 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
2475 (mark_vectorlike):
2476 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2477 (allocate_pseudovector):
2478 Use int, not EMACS_INT, where int is wide enough.
2479 (inhibit_garbage_collection, Fgarbage_collect):
2480 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2481 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
2482 int might not be wide enough.
2483 (bidi_cache_search, bidi_cache_find, bidi_init_it)
2484 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
2485 (bidi_at_paragraph_end, bidi_find_paragraph_start)
2486 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2487 (bidi_level_of_next_char, bidi_move_to_visually_next):
2488 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2489 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
2490 (Fkill_buffer, Fset_buffer_major_mode)
2491 (advance_to_char_boundary, Fbuffer_swap_text)
2492 (Fset_buffer_multibyte, overlays_at, overlays_in)
2493 (overlay_touches_p, struct sortvec, record_overlay_string)
2494 (overlay_strings, recenter_overlay_lists)
2495 (adjust_overlays_for_insert, adjust_overlays_for_delete)
2496 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
2497 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
2498 (Foverlay_recenter, last_overlay_modification_hooks_used)
2499 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
2500 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
2501 (validate_region): Omit unnecessary test for b <= e,
2502 since that's guaranteed by the previous test.
d311d28c
PE
2503 (adjust_overlays_for_delete): Avoid pos + length overflow.
2504 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
2505 (report_overlay_modification):
2506 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2507 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
2508 Omit pointer cast, which isn't needed anyway, and doesn't work
2509 after the EMACS_INT -> ptrdiff_t change.
02481186 2510 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
2511 * buffer.h: Adjust decls to match defn changes elsewhere.
2512 (struct buffer_text, struct buffer):
2513 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2514 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
2515 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
2516 not int, to avoid needless 32-bit limit on 64-bit hosts.
2517 (exec_byte_code): Use tighter memory-full test, one that checks
2518 for alloca overflow. Don't compute the address of the object just
2519 before an array, as that's not portable. Use EMACS_INT, not
2520 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
2521 * callint.c (Fcall_interactively):
2522 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2523 * callproc.c (call_process_kill, Fcall_process):
2524 Don't assume pid_t fits into an Emacs fixnum.
2525 (call_process_cleanup, Fcall_process, child_setup):
2526 Don't assume pid_t fits into int.
2527 (call_process_cleanup, Fcall_process, delete_temp_file)
2528 (Fcall_process_region):
2529 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2530 (Fcall_process): Simplify handling of volatile integers.
2531 Use int, not EMACS_INT, where int will do.
2532 * casefiddle.c (casify_object, casify_region, operate_on_word)
2533 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
2534 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2535 (casify_object): Avoid integer overflow when overallocating buffer.
2536 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 2537 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
2538 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
2539 * category.h (CATEGORYP): Don't assume arg is nonnegative.
2540 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
2541 integers are now checked earlier. All uses replaced with XINT.
2542 (ccl_driver):
2543 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2544 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
2545 (ccl_driver, Fregister_code_conversion_map):
2546 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
2547 (resolve_symbol_ccl_program): Check that vector header is in range.
2548 Always copy the vector, so that we can check its contents reliably
2549 now rather than having to recheck each instruction as it's being
2550 executed. Check that vector words fit in 'int'.
2551 (ccl_get_compiled_code, Fregister_ccl_program)
2552 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
2553 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
2554 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
2555 contents are in range.
2556 (Fccl_execute_on_string): Check that status is in range.
2557 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
2558 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
2559 Accept and return EMACS_INT, not int, because callers can pass values
2560 out of 'int' range.
2561 (c_string_width, strwidth, lisp_string_width, chars_in_text)
2562 (multibyte_chars_in_text, parse_str_as_multibyte)
2563 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
2564 (str_as_unibyte, str_to_unibyte, string_count_byte8)
2565 (string_escape_byte8, Fget_byte):
2566 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 2567 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
2568 avoid mishandling large integers.
2569 * character.h: Adjust decls to match defn changes elsewhere.
2570 * charset.c (load_charset_map_from_file, find_charsets_in_text)
2571 (Ffind_charset_region):
2572 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2573 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
2574 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 2575 Don't assume fixnum fits in int.
d311d28c
PE
2576 (load_charset_map_from_vector, Fmap_charset_chars):
2577 Remove now-unnecessary CHECK_NATNUMs.
2578 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
2579 Don't rely on undefined behavior with signed left shift overflow.
2580 Don't assume unsigned int fits into fixnum, or that fixnum fits
2581 into unsigned int. Don't require max_code to be a valid fixnum;
2582 that's not true for gb10830 4-byte on a 32-bit host. Allow
2583 invalid_code to be a cons, for the same reason. Require code_offset
2584 to be a character. Avoid int overflow if max_char is close
2585 to INT_MAX.
2586 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
2587 this is intended anyway and avoids some undefined behavior.
2588 (load_charset_map): Pass unsigned, not int, as 2nd arg of
2589 INDEX_TO_CODE_POINT, as that's what it expects.
2590 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
2591 * charset.h (DECODE_CHAR): Return int, not unsigned;
2592 this is what was intended anyway, and it avoids undefined behavior.
2593 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
2594 integer-overflow issues.
2595 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
2596 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
2597 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
2598 * chartab.c (Fmake_char_table, Fset_char_table_range)
2599 (uniprop_get_decoder, uniprop_get_encoder):
2600 Don't assume fixnum fits in int.
2601 * cmds.c (move_point): New function, that does the gist of
2602 Fforward_char and Fbackward_char, but does so while checking
2603 for integer overflow more accurately.
c96e5d6a 2604 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
2605 (Fforward_line, Fend_of_line, internal_self_insert)
2606 (internal_self_insert):
2607 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2608 Fix a FIXME, by checking for integer overflow when calculating
2609 target_clm and actual_clm.
2610 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 2611 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
2612 (ASSURE_DESTINATION, coding_alloc_by_realloc)
2613 (coding_alloc_by_making_gap, alloc_destination)
2614 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
2615 (encode_coding_utf_16, detect_coding_emacs_mule)
2616 (decode_coding_emacs_mule, encode_coding_emacs_mule)
2617 (detect_coding_iso_2022, decode_coding_iso_2022)
2618 (encode_invocation_designation, encode_designation_at_bol)
2619 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2620 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
2621 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
2622 (encode_coding_ccl, encode_coding_raw_text)
2623 (detect_coding_charset, decode_coding_charset)
2624 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
2625 (produce_composition, produce_charset, produce_annotation)
2626 (decode_coding, handle_composition_annotation)
2627 (handle_charset_annotation, consume_chars, decode_coding_gap)
2628 (decode_coding_object, encode_coding_object, detect_coding_system)
2629 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
2630 (code_convert_region, code_convert_string)
8f50130c
PE
2631 (Fdefine_coding_system_internal)
2632 (coding_set_source, coding_set_destination):
d311d28c
PE
2633 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2634 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
2635 (Fdefine_coding_system_internal):
2636 Don't assume fixnums fit in int.
2637 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 2638 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
2639 (Funencodable_char_position, Fcheck_coding_systems_region)
2640 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 2641 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 2642 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 2643 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 2644 Don't access memory outside of the args array.
d311d28c 2645 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
2646 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
2647 result of ENCODE_CHAR.
d311d28c
PE
2648 * coding.h: Adjust decls to match defn changes elsewhere.
2649 (struct coding_system):
2650 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2651 * composite.c (get_composition_id, find_composition)
2652 (run_composition_function, update_compositions)
2653 (compose_text, composition_gstring_put_cache)
2654 (composition_gstring_p, composition_gstring_width)
2655 (fill_gstring_header, fill_gstring_body, autocmp_chars)
2656 (composition_compute_stop_pos, composition_reseat_it)
2657 (composition_update_it, struct position_record)
2658 (find_automatic_composition, composition_adjust_point)
2659 (Fcomposition_get_gstring, Ffind_composition_internal):
2660 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2661 (update_compositions):
2662 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2663 * composite.h: Adjust decls to match defn changes elsewhere.
2664 (struct composition):
2665 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2666 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2667 Do not attempt to compute the address of the object just before a
2668 buffer; this is not portable.
2669 (Faref, Faset):
2670 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2671 (Faset): Use int, not EMACS_INT, where int is wide enough.
2672 (Fstring_to_number): Don't assume fixnums fit in int.
2673 (Frem): Don't assume arg is nonnegative.
2674 * dbusbind.c (xd_append_arg): Check for integers out of range.
2675 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 2676 (extract_signed, extract_unsigned): New functions.
243e0530
PE
2677 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
2678 (xd_get_connection_references): Return ptrdiff_t, not int.
2679 All uses changed.
2680 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
2681 (xd_read_message_1):
2682 Use int, not unsigned, where the dbus API uses int.
2683 (Fdbus_message_internal): Don't overflow mtype.
2684 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
2685 * dired.c (directory_files_internal, file_name_completion, scmp)
2686 (file_name_completion_stat):
2687 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2688 (file_name_completion): Don't overflow matchcount.
2689 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
2690 * dispextern.h: Adjust decls to match defn changes elsewhere.
2691 (struct text_pos, struct glyph, struct bidi_saved_info)
2692 (struct bidi_string_data, struct bidi_it, struct composition_it)
2693 (struct it):
2694 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2695 (struct display_pos, struct composition_it, struct it):
2696 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2697 * dispnew.c (increment_matrix_positions)
2698 (increment_row_positions, mode_line_string)
2699 (marginal_area_string):
2700 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 2701 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
2702 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2703 (duration_to_sec_usec): New function, to check for overflow better.
2704 (Fsleep_for, sit_for): Use it.
2705 * doc.c (get_doc_string, store_function_docstring):
2706 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2707 (get_doc_string, Fsnarf_documentation):
2708 Use int, not EMACS_INT, where int is wide enough.
2709 (get_doc_string):
2710 Use SAFE_ALLOCA, not alloca.
2711 Check for overflow when converting EMACS_INT to off_t.
2712 * doprnt.c (doprnt):
2713 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2714 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
2715 Don't assume uid_t fits into fixnum.
2716 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
2717 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
2718 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
2719 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
2720 (general_insert_function)
2721 (Finsert_char, make_buffer_string, make_buffer_string_both)
2722 (update_buffer_properties, Fbuffer_substring)
2723 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
2724 (Fsubst_char_in_region, check_translation)
2725 (Ftranslate_region_internal, save_restriction_restore, Fformat)
2726 (transpose_markers, Ftranspose_regions):
2727 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2728 (clip_to_bounds): Move to lisp.h as an inline function).
2729 (Fconstrain_to_field): Don't assume integers are nonnegative.
2730 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
2731 (Fsubst_char_in_region, Fsave_restriction):
2732 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2733 (Femacs_pid): Don't assume pid_t fits into fixnum.
2734 (lo_time): Use int, not EMACS_INT, when int suffices.
2735 (lisp_time_argument): Check for usec out of range.
2736 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
2737 (Fuser_login_name, Fuser_full_name): Signal an error
2738 if a uid argument is out of range, rather than relying on
2739 undefined behavior.
c8d5c857
PE
2740 (Fformat_time_string): Remove now-unnecessary check.
2741 lisp_time_argument checks for out-of-range usec now.
243e0530 2742 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
2743 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
2744 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
2745 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
2746 (init_cmdargs, Fdump_emacs):
2747 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2748 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
2749 the bottom (typically) 32 bits of the fixnum.
2750 * eval.c (specpdl_size, call_debugger):
2751 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2752 (when_entered_debugger, Fbacktrace_debug):
2753 Don't assume fixnum can fit in int.
2754 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
2755 the object just before a buffer; this is not portable.
2756 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
2757 (grow_specpdl, unbind_to):
2758 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2759 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
2760 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 2761 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
2762 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
2763 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
2764 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2765 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
2766 (a_write, e_write):
2767 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2768 (Fcopy_file, non_regular_nbytes, read_non_regular)
2769 (Finsert_file_contents):
2770 Use int, not EMACS_INT, where int is wide enough.
2771 (READ_BUF_SIZE): Verify that it fits in int.
2772 (Finsert_file_contents): Check that counts are in proper range,
2773 rather than assuming fixnums fit into ptrdiff_t etc.
2774 Don't assume fixnums fit into int.
125b3835 2775 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
2776 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
2777 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
2778 (string_char_to_byte, string_byte_to_char)
2779 (string_make_multibyte, string_to_multibyte)
2780 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
2781 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
2782 (substring_both, Fdelete, internal_equal, Ffillarray)
2783 (Fclear_string, mapcar1)
2784 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
2785 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
2786 (larger_vector, make_hash_table, maybe_resize_hash_table)
2787 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
2788 (Fmaphash, secure_hash):
2789 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2790 (concat): Check for string index and length overflow.
2791 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
2792 (Frequire):
2793 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2794 (larger_vector): New API (vec, incr_min, size_max) replaces old
2795 one (vec, new_size, init). This catches size overflow.
2796 INIT was removed because it was always Qnil.
2797 All callers changed.
2798 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
2799 the upper bound on a hash table index size.
2800 (make_hash_table, maybe_resize_hash_table): Use it.
2801 (secure_hash): Computer start_byte and end_byte only after
2802 they're known to be in ptrdiff_t range.
2803 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
2804 (Ffont_get_glyphs, Ffont_at):
2805 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2806 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
2807 (Flist_fonts, Fopen_font):
2808 Don't assume fixnum can fit in int.
2809 (check_gstring): Don't assume index can fit in int.
2810 (font_match_p): Check that fixnum is a character, not a nonnegative
2811 fixnum, since the later code needs to stuff it into an int.
2812 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
2813 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
2814 conversion overflow issues.
2815 (Fopen_font): Check for integer out of range.
2816 (Ffont_get_glyphs): Don't assume index can fit in int.
2817 * font.h: Adjust decls to match defn changes elsewhere.
2818 * fontset.c (reorder_font_vector): Redo score calculation to avoid
2819 integer overflow.
2820 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
2821 printmax_t, where ptrdiff_t is wide enough.
2822 (Finternal_char_font):
2823 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2824 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
2825 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
2826 (Fset_frame_position, x_set_frame_parameters)
2827 (x_set_line_spacing, x_set_border_width)
2828 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
2829 Check that fixnums are in proper range for system types.
2830 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
2831 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2832 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
2833 Use SAFE_ALLOCA_LISP, not alloca.
2834 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
2835 intptr_t is wide enough.
2836 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
2837 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
2838 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
2839 Check for fixnum out of range.
2840 * ftfont.c (ftfont_list): Don't assume index fits in int.
2841 Check that fixnums are in proper range for system types.
2842 (ftfont_shape_by_flt):
2843 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
2844 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2845 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2846 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
2847 Check that fixnums are in proper range for system types.
2848 * gnutls.h: Adjust decls to match defn changes elsewhere.
2849 * gtkutil.c (xg_dialog_run):
2850 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2851 (update_frame_tool_bar):
2852 Check that fixnums are in proper range for system types.
2853 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 2854 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
2855 * indent.c (last_known_column, last_known_column_point):
2856 (current_column_bol_cache):
2857 (skip_invisible, current_column, check_display_width):
2858 (check_display_width, scan_for_column, current_column_1)
2859 (Findent_to, Fcurrent_indentation, position_indentation)
2860 (indented_beyond_p, Fmove_to_column, compute_motion):
2861 (Fcompute_motion, Fvertical_motion):
2862 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2863 (last_known_column_modified): Use EMACS_INT, not int.
2864 (check_display_width):
2865 (Fcompute_motion):
2866 Check that fixnums and floats are in proper range for system types.
2867 (compute_motion): Don't assume index or fixnum fits in int.
2868 (compute_motion, Fcompute_motion):
2869 Use int, not EMACS_INT, when it is wide enough.
2870 (vmotion): Omit local var start_hpos that is always 0; that way
2871 we don't need to worry about overflow in expressions involving it.
2872 * indent.h: Adjust decls to match defn changes elsewhere.
2873 (struct position):
2874 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2875 Use int, not EMACS_INT, where int is wide enough.
2876 Remove unused members ovstring_chars_done and tab_offset;
2877 all uses removed.
2878 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
2879 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
2880 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
2881 (make_gap, copy_text, insert, insert_and_inherit)
2882 (insert_before_markers, insert_before_markers_and_inherit)
2883 (insert_1, count_combining_before, count_combining_after)
2884 (insert_1_both, insert_from_string)
2885 (insert_from_string_before_markers, insert_from_string_1)
2886 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
2887 (adjust_after_replace, adjust_after_insert, replace_range)
2888 (replace_range_2, del_range, del_range_1, del_range_byte)
2889 (del_range_both, del_range_2, modify_region)
2890 (prepare_to_modify_buffer, signal_before_change)
2891 (signal_after_change, Fcombine_after_change_execute):
2892 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2893 * intervals.c (traverse_intervals, rotate_right, rotate_left)
2894 (balance_an_interval, split_interval_right, split_interval_left)
2895 (find_interval, next_interval, update_interval)
2896 (adjust_intervals_for_insertion, delete_node, delete_interval)
2897 (interval_deletion_adjustment, adjust_intervals_for_deletion)
2898 (static_offset_intervals, offset_intervals)
2899 (merge_interval_right, merge_interval_left, make_new_interval)
2900 (graft_intervals_into_buffer, temp_set_point_both)
2901 (temp_set_point, set_point, adjust_for_invis_intang)
2902 (set_point_both, move_if_not_intangible, get_property_and_range)
2903 (get_local_map, copy_intervals, copy_intervals_to_string)
2904 (compare_string_intervals, set_intervals_multibyte_1):
2905 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2906 * intervals.h: Adjust decls to match defn changes elsewhere.
2907 (struct interval):
2908 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2909 * keyboard.c (this_command_key_count, this_single_command_key_start)
2910 (before_command_key_count, before_command_echo_length, echo_now)
2911 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
2912 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
2913 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
2914 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
2915 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2916 (last_non_minibuf_size, last_point_position, echo_truncate)
2917 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
2918 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
2919 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
2920 (stuff_buffered_input):
2921 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2922 (last_auto_save, command_loop_1, read_char):
2923 Use EMACS_INT, not int, to avoid integer overflow.
2924 (record_char): Avoid overflow in total_keys computation.
2925 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
2926 * keyboard.h: Adjust decls to match defn changes elsewhere.
2927 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
2928 (Fkey_description, Fdescribe_vector, Flookup_key):
2929 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2930 (click_position): New function, to check that positions are in range.
2931 (Fcurrent_active_maps):
2932 (describe_command):
2933 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2934 (Faccessible_keymaps, Fkey_description):
2935 (preferred_sequence_p):
2936 Don't assume fixnum can fit into int.
2937 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
2938 Check for integer overflow in size calculations.
2939 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
2940 avoid mishandling large integers.
2941 * lisp.h: Adjust decls to match defn changes elsewhere.
2942 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
2943 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
2944 (struct Lisp_Marker):
2945 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2946 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
2947 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
2948 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
2949 All callers changed.
2950 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
2951 Assume the arg has valid form, since it always does.
2952 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
2953 unsigned integer system type.
2954 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
2955 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
2956 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2957 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
2958 (duration_to_sec_usec): New decl.
2959 * lread.c (read_from_string_index, read_from_string_index_byte)
2960 (read_from_string_limit, readchar, unreadchar, openp)
2961 (read_internal_start, read1, oblookup):
2962 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2963 (Fload, readevalloop, Feval_buffer, Feval_region):
2964 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2965 (openp): Check for out-of-range argument to 'access'.
2966 (read1): Use int, not EMACS_INT, where int is wide enough.
2967 Don't assume fixnum fits into int.
6efdadfd 2968 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
2969 (read_filtered_event): Use duration_to_sec_usec
2970 to do proper overflow checking on durations.
d311d28c
PE
2971 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
2972 in size calculation.
2973 (Fexecute_kbd_macro):
2974 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2975 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
2976 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
2977 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
2978 (set_marker_both, set_marker_restricted_both, marker_position)
2979 (marker_byte_position, Fbuffer_has_markers_at):
2980 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2981 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 2982 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
2983 It now merely ensures that the menu is large enough, without
2984 necessarily growing it, as this avoids some integer overflow issues.
2985 All callers changed.
2986 (keymap_panes, parse_single_submenu, Fx_popup_menu):
2987 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2988 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
2989 Use SAFE_ALLOCA_LISP, not alloca.
2990 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
2991 to EMACS_INT. Check that fixnums are in proper range for system types.
2992 * minibuf.c (minibuf_prompt_width, string_to_object)
2993 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
2994 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
2995 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2996 (get_minibuffer, read_minibuf_unwind):
2997 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2998 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
2999 this simplifies overflow checking. All callers changed.
3000 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
3001 (Ftest_completion):
3002 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3003 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
3004 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
3005 Check that fixnums are in proper range for system types.
3006 (Fx_create_frame, Fx_show_tip):
3007 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3008 * nsfont.m (ns_findfonts, nsfont_list_family):
3009 Don't assume fixnum fits in long.
3010 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
3011 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3012 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
3013 wide enough.
17fdb222 3014 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
3015 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3016 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
3017 (PRINTDECLARE, PRINTPREPARE):
3018 (strout, print_string):
3019 (print, print_preprocess, print_check_string_charset_prop)
3020 (print_object):
3021 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3022 (PRINTDECLARE):
3023 (temp_output_buffer_setup, Fprin1_to_string, print_object):
3024 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3025 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 3026 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 3027 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
3028 (print_error_message): Use SAFE_ALLOCA, not alloca.
3029 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
3030 (print_depth, new_backquote_output, print_number_index):
3031 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
3032 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
3033 (Fset_process_window_size, Fformat_network_address)
3034 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 3035 (sigchld_handler):
d311d28c 3036 Check that fixnums are in proper range for system types.
d44287d4 3037 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
3038 Check for process-ids out of pid_t range rather than relying on
3039 undefined behavior.
e4d81efc 3040 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
3041 (Fformat_network_address, read_process_output, send_process)
3042 (Fprocess_send_region, status_notify):
3043 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3044 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
3045 (wait_reading_process_output, read_process_output, exec_sentinel):
3046 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3047 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
3048 (Faccept_process_output): Use duration_to_sec_usec to do proper
3049 overflow checking on durations.
dde14581
PE
3050 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
3051 Don't assume pid_t fits in int.
02481186
PE
3052 * process.h (struct Lisp_Process): Members tick and update_tick
3053 are now of type EMACS_INT, not int.
b62b53e8
PE
3054 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
3055 configured --with-wide-int.
d311d28c
PE
3056 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
3057 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
3058 * search.c (looking_at_1, string_match_1):
3059 (fast_string_match, fast_c_string_match_ignore_case)
3060 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
3061 (scan_newline, find_before_next_newline, search_command)
3062 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
3063 (set_search_regs, wordify):
3064 (Freplace_match):
3065 (Fmatch_data):
3066 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3067 (string_match_1, search_buffer, set_search_regs):
3068 (Fmatch_data):
3069 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3070 (wordify): Check for overflow in size calculation.
3071 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
3072 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
3073 Check that fixnums are in proper range for system types.
3074 * sound.c (struct sound_device)
3075 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
3076 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3077 (Fplay_sound_internal):
3078 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 3079 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
3080 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
3081 (Fparse_partial_sexp):
3082 Don't assume fixnums can fit in int.
3083 (struct lisp_parse_state, find_start_pos, find_start_value)
3084 (find_start_value_byte, find_start_begv)
3085 (update_syntax_table, char_quoted, dec_bytepos)
3086 (find_defun_start, prev_char_comend_first, back_comment):
3087 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
3088 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
3089 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3090 (Finternal_describe_syntax_value): Check that match_lisp is a
3091 character, not an integer, since the code stuffs it into int.
3092 (scan_words, scan_sexps_forward):
3093 Check that fixnums are in proper range for system types.
3094 (Fforward_word):
3095 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3096 (scan_sexps_forward):
3097 Use CHARACTERP, not INTEGERP, since the value must fit into int.
3098 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
3099 * syntax.h: Adjust decls to match defn changes elsewhere.
3100 (struct gl_state_s):
3101 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
3102 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
3103 MOST_POSITIVE_FIXNUM.
d311d28c
PE
3104 * sysdep.c (wait_for_termination_1, wait_for_termination)
3105 (interruptible_wait_for_termination, mkdir):
3106 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
3107 (emacs_read, emacs_write):
3108 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
3109 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
3110 and double all fit in int.
d311d28c
PE
3111 * term.c (set_tty_color_mode):
3112 Check that fixnums are in proper range for system types.
3113 * termhooks.h (struct input_event):
3114 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3115 * textprop.c (validate_interval_range, interval_of)
3116 (Fadd_text_properties, set_text_properties_1)
3117 (Fremove_text_properties, Fremove_list_of_text_properties)
3118 (Ftext_property_any, Ftext_property_not_all)
3119 (copy_text_properties, text_property_list, extend_property_ranges)
3120 (verify_interval_modification):
3121 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3122 (Fnext_single_char_property_change)
3123 (Fprevious_single_char_property_change):
3124 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
3125 (copy_text_properties):
3126 Check for integer overflow in index calculation.
d311d28c
PE
3127 * undo.c (last_boundary_position, record_point, record_insert)
3128 (record_delete, record_marker_adjustment, record_change)
3129 (record_property_change):
3130 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3131 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
3132 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3133 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3134 (Fx_hide_tip, Fx_file_dialog):
3135 * w32menu.c (set_frame_menubar):
3136 Use ptrdiff_t, not int, for consistency with rest of code.
3137 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
3138 (select_window, Fdelete_other_windows_internal)
3139 (window_scroll_pixel_based, window_scroll_line_based)
3140 (Frecenter, Fset_window_configuration):
3141 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3142 (Fset_window_hscroll, run_window_configuration_change_hook)
3143 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 3144 (Fscroll_other_window, Frecenter):
d311d28c
PE
3145 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3146 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
3147 Don't assume fixnum fits in int.
3148 (Fset_window_scroll_bars):
3149 Check that fixnums are in proper range for system types.
3150 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
3151 (string_pos, c_string_pos, number_of_chars, init_iterator)
3152 (in_ellipses_for_invisible_text_p, init_from_display_pos)
3153 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
3154 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
3155 (face_before_or_after_it_pos, handle_invisible_prop)
3156 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
3157 (display_prop_intangible_p, string_buffer_position_lim)
3158 (string_buffer_position, handle_composition_prop, load_overlay_strings)
3159 (get_overlay_strings_1, get_overlay_strings)
3160 (iterate_out_of_display_property, forward_to_next_line_start)
3161 (back_to_previous_visible_line_start, reseat, reseat_to_string)
3162 (get_next_display_element, set_iterator_to_next)
3163 (get_visually_first_element, compute_stop_pos_backwards)
3164 (handle_stop_backwards, next_element_from_buffer)
3165 (move_it_in_display_line_to, move_it_in_display_line)
3166 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3167 (add_to_log, message_dolog, message_log_check_duplicate)
3168 (message2, message2_nolog, message3, message3_nolog
3169 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
3170 (current_message_1, truncate_echo_area, truncate_message_1)
3171 (set_message, set_message_1, store_mode_line_noprop)
3172 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
3173 (text_outside_line_unchanged_p, check_point_in_composition)
3174 (reconsider_clip_changes)
3175 (redisplay_internal, set_cursor_from_row, try_scrolling)
3176 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
3177 (redisplay_window, find_last_unchanged_at_beg_row)
3178 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
3179 (trailing_whitespace_p, find_row_edges, display_line)
3180 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
3181 (display_mode_element, store_mode_line_string)
3182 (pint2str, pint2hrstr, decode_mode_spec)
3183 (display_count_lines, display_string, draw_glyphs)
3184 (x_produce_glyphs, x_insert_glyphs)
3185 (rows_from_pos_range, mouse_face_from_buffer_pos)
3186 (fast_find_string_pos, mouse_face_from_string_pos)
3187 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3188 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3189 (safe_call, init_from_display_pos, handle_fontified_prop)
3190 (handle_single_display_spec, load_overlay_strings)
3191 (with_echo_area_buffer, setup_echo_area_for_printing)
3192 (display_echo_area, echo_area_display)
3193 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
3194 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
3195 (redisplay_window, dump_glyph_row, display_mode_line)
3196 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 3197 (handle_display_spec, display_prop_string_p):
d311d28c
PE
3198 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3199 (handle_single_display_spec, build_desired_tool_bar_string)
3200 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
3201 (get_specified_cursor_type):
3202 Check that fixnums are in proper range for system types.
3203 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
3204 (Flookup_image_map):
3205 Don't assume fixnums fit in int.
3206 (compare_overlay_entries):
3207 Avoid mishandling comparisons due to subtraction overflow.
3208 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
3209 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
3210 (handle_tool_bar_click):
3211 Use int, not unsigned, since we prefer signed and the signedness
3212 doesn't matter here.
3213 (get_next_display_element, next_element_from_display_vector):
3214 Use int, not EMACS_INT, when int is wide enough.
3215 (start_hourglass): Use duration_to_sec_usec to do proper
3216 overflow checking on durations.
3217 * xfaces.c (Fbitmap_spec_p):
3218 Check that fixnums are in proper range for system types.
3219 (compare_fonts_by_sort_order):
3220 Avoid mishandling comparisons due to subtraction overflow.
3221 (Fx_family_fonts, realize_basic_faces):
3222 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3223 (Fx_family_fonts):
3224 Don't assume fixnum fits in int.
3225 Use SAFE_ALLOCA_LISP, not alloca.
3226 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
3227 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
3228 (face_at_buffer_position, face_for_overlay_string)
3229 (face_at_string_position):
3230 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3231 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
3232 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
3233 (Fx_show_tip):
3234 Check that fixnums are in proper range for system types.
3235 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3236 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
3237 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3238 (Fx_change_window_property): Don't assume fixnums fit in int.
3239 * xfont.c (xfont_chars_supported):
3240 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3241 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
3242 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
3243 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3244 * xml.c (parse_region):
3245 * xrdb.c (magic_file_p):
3246 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3247 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
3248 (x_get_local_selection, x_reply_selection_request)
3249 (x_handle_selection_request, wait_for_property_change):
3250 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3251 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
3252 short is wide enough.
3253 (x_send_client_event): Don't assume fixnum fits in int.
3254 * xterm.c (x_x_to_emacs_modifiers):
3255 Don't assume EMACS_INT overflows nicely into int.
3256 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
3257 may come from Lisp.
3258 (handle_one_xevent): NATNUMP can eval its arg twice.
3259 (x_connection_closed):
3260 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3261 * xterm.h: Adjust decls to match defn changes elsewhere.
3262 (struct scroll_bar): Use struct vectorlike_header
3263 rather than rolling our own approximation.
3264 (SCROLL_BAR_VEC_SIZE): Remove; not used.
3265
c6574eb5
GM
32662012-05-25 Glenn Morris <rgm@gnu.org>
3267
3268 * lisp.mk (lisp): Update for more files being compiled now.
3269
e8d32c7e
SM
32702012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
3271
48def666
SM
3272 * lread.c: Remove `read_pure' which makes no difference.
3273 (read_pure): Remove var.
3274 (unreadpure): Remove function.
3275 (readevalloop): Don't call read_list with -1 flag.
3276 (read1, read_vector): Don't test read_pure any more.
3277 (read_list): Simplify.
3278
e8d32c7e
SM
3279 * fileio.c, character.h: Minor style tweaks.
3280
4b2addb7
DA
32812012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
3282
3283 * window.h (clip_changed): Remove useless declaration.
3284
584461b2
JB
32852012-05-22 Juanma Barranquero <lekktu@gmail.com>
3286
3287 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
3288 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
3289
34374650
PE
32902012-05-22 Paul Eggert <eggert@cs.ucla.edu>
3291
3292 Remove src/m/*.
3293 This directory predates autoconf and is no longer needed nowadays.
3294 Move its few remaining bits of functionality to where they're needed.
3295 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
3296 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
3297 * m/template.h: Remove.
3298 * Makefile.in (M_FILE): Remove. All uses removed.
3299 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
3300 * lisp.h (USE_LSB_TAG):
3301 * mem-limits.h (EXCEEDS_LISP_PTR):
3302 Use VAL_MAX, not VALBITS, in #if.
3303 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
3304 (EMACS_UINT): Define unconditionally now.
3305 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
3306 (BITS_PER_EMACS_INT): New constants, replacing
3307 what used to be in config.h, but not useful in #if.
3308 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
3309 define them any more.
3310 (VAL_MAX): New macro.
3311 (VALMASK): Use it.
3312 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
3313 BITS_PER_EMACS_INT, in #if.
3314 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
3315 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
3316 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
3317 * s/ms-w32.h (DATA_START):
3318 Move here from removed file m/intel386.h.
3319 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
3320 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
3321
261cb4bb
PE
33222012-05-21 Paul Eggert <eggert@cs.ucla.edu>
3323
3324 Assume C89 or later.
3325 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
3326 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
3327 (xrealloc):
3328 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
3329 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
3330 * textprop.c, tparam.c (NULL): Remove.
3331 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
3332 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
3333 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
3334 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
3335 * xterm.c (input_signal_count): Assume volatile works.
3336
ff23cd9f
KB
33372012-05-21 Ken Brown <kbrown@cornell.edu>
3338
3339 * xgselect.c (xg_select): Fix first argument in call to 'select'
3340 (bug#11508).
3341
1b170bc6
KB
33422012-05-20 Ken Brown <kbrown@cornell.edu>
3343
3344 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 3345 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 3346
b2f4d39f
KB
33472012-05-19 Ken Brown <kbrown@cornell.edu>
3348
3349 * xfns.c (x_in_use): Remove `static' qualifier.
3350 * xterm.h (x_in_use): Declare.
3351 * xgselect.c: Include xterm.h.
3352 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
3353 and `display_arg' (bug#9754).
3354
003fdae2
PE
33552012-05-19 Paul Eggert <eggert@cs.ucla.edu>
3356
9232a6d9
PE
3357 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
3358
003fdae2
PE
3359 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
3360 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
3361
784b56e2
EZ
33622012-05-18 Eli Zaretskii <eliz@gnu.org>
3363
3364 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
3365
3366 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 3367 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
3368
3369 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
3370 reference to image_cache->refcount.
3371 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
3372
a0a79cde
JL
33732012-05-17 Juri Linkov <juri@jurta.org>
3374
3375 * search.c (Fword_search_regexp, Fword_search_backward)
3376 (Fword_search_forward, Fword_search_backward_lax)
3377 (Fword_search_forward_lax): Move functions to isearch.el
3378 (bug#10145, bug#11381).
3379
b0572523
PE
33802012-05-16 Paul Eggert <eggert@cs.ucla.edu>
3381
3382 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
3383
9660f5fc
SM
33842012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3385
3386 * lread.c (init_obarray): Declare Qt and Qnil as special.
3387
4374de83
GM
33882012-05-14 Glenn Morris <rgm@gnu.org>
3389
3390 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 3391 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 3392
dc44c39a
PE
33932012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3394
078c97cb
PE
3395 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
3396
dc44c39a
PE
3397 * unexaix.c: Port to more-recent AIX compilers.
3398 (report_error, report_error_1, make_hdr, copy_sym)
3399 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
3400 Make arguments const char *, not char *, to avoid violations of C
3401 standard and to fix some AIX warnings reported by Gilles Pion.
3402
e18afed7 34032012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
3404
3405 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
3406 already have overlays loaded.
3407 (handle_single_display_spec): Before returning without displaying
3408 fringe bitmap, synchronize the bidi iterator with the main display
3409 iterator, by calling iterate_out_of_display_property.
3410 (iterate_out_of_display_property): Detect buffer iteration by
3411 testing that it->string is a Lisp string.
3412 (get_next_display_element): When the current object is exhausted,
3413 and there's something on it->stack, call set_iterator_to_next to
3414 proceed with what's on the stack, instead of returning zero.
3415 (set_iterator_to_next): If called at the end of a Lisp string,
3416 proceed to consider_string_end without incrementing string
3417 position. Don't increment display vector index past the end of
3418 the display vector. (Bug#11417)
c8fb9dc6
EZ
3419 (pos_visible_p): Don't report a position visible when move_it_to
3420 stopped at the last line of window, which happens to be scanned
3421 backwards by the bidi iteration. (Bug#11464)
ac268e67 3422
e18afed7 34232012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
3424
3425 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
3426 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
3427 are on a TTY, and thus unable to display on the fringes.
3428 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
3429 so we need to signal to the caller that this is a "replacing"
3430 display spec. This fixes display when the spec is invalid or we
3431 are on a TTY.
3432
e18afed7 34332012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
3434
3435 * unexaix.c (make_hdr): Fix typo in prototype.
3436 This bug broke the build on AIX. Problem reported by Gilles Pion.
3437
9d0a235a
MA
34382012-05-14 Michael Albinus <michael.albinus@gmx.de>
3439
3440 * keyboard.c (kbd_buffer_get_event): Read special events also in
3441 batch mode. (Bug#11415)
3442
9e6b06ed
GM
34432012-05-12 Glenn Morris <rgm@gnu.org>
3444
3445 * ns.mk: Update for ns_appbindir no longer having trailing "/".
3446
c1a1d7a3
EZ
34472012-05-12 Eli Zaretskii <eliz@gnu.org>
3448
3449 * lisp.mk (lisp): Add newcomment.elc.
3450
3fe7cdc8
GM
34512012-05-12 Glenn Morris <rgm@gnu.org>
3452
3453 * Makefile.in (MKDIR_P): New, set by configure.
3454 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
3455
53f7d2c0
PE
34562012-05-11 Paul Eggert <eggert@cs.ucla.edu>
3457
3458 Remove unused function hourglass_started.
3459 * dispextern.h (hourglass_started):
3460 * w32fns.c (hourglass_started):
3461 * xdisp.c (hourglass_started): Remove.
3462
75aafb17
JB
34632012-05-10 Juanma Barranquero <lekktu@gmail.com>
3464
3465 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
3466 Update dependencies.
3467
12959e8e
PE
34682012-05-10 Paul Eggert <eggert@cs.ucla.edu>
3469
97107e2e
PE
3470 * xgselect.c (xg_select): Put maxfds+1 into a var.
3471 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
3472
12959e8e
PE
3473 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
3474
836d29b3
DA
34752012-05-10 Dave Abrahams <dave@boostpro.com>
3476
3477 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
3478 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
3479
5cb67954
MA
34802012-05-09 Michael Albinus <michael.albinus@gmx.de>
3481
3482 * dbusbind.c (xd_registered_buses): New internal Lisp object.
3483 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
3484 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
3485 Initialize xd_registered_buses.
3486
3478ec45
PE
34872012-05-09 Paul Eggert <eggert@cs.ucla.edu>
3488
b263a6b0
PE
3489 Untag more efficiently if USE_LSB_TAG.
3490 This is based on a proposal by YAMAMOTO Mitsuharu in
3491 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
3492 For an admittedly artificial (nth 8000 longlist) benchmark on
3493 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
3494 Emacs's overall text size by 1%.
3495 * lisp.h (XUNTAG): New macro.
3496 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
3497 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
3498 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
3499 * eval.c (Fautoload):
3500 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
3501 * frame.h (XFRAME): Use XUNTAG.
3502
3478ec45
PE
3503 Port recent dbusbind.c changes to 32-bit --with-wide-int.
3504 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
3505 Remove unportable assumptions about print widths of types like
3506 dbus_uint32_t.
3507 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
3508 intptr_t when converting between pointer and integer, to avoid GCC
3509 warnings about wrong width.
3510
666b903b 35112012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
3512
3513 * w32proc.c (new_child): Force Windows to reserve only 64KB of
3514 stack for each reader_thread, instead of defaulting to 8MB
3515 determined by the linker. This avoids failures in creating
3516 subprocesses on Windows 7, see the discussion in this thread:
3517 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
3518
b120cc17
JC
35192012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
3520
3521 Fix up display of the *Minibuf-0* buffer in the mini window.
3522 * keyboard.c (read_char): Don't clear the echo area if there's no
3523 message to clear.
3524 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 3525 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 3526
9a4b36f8
MA
35272012-05-07 Michael Albinus <michael.albinus@gmx.de>
3528
3529 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
3530 batch mode.
3531
e5f9458f
CY
35322012-05-06 Chong Yidong <cyd@gnu.org>
3533
3534 * lisp.mk (lisp): Update.
3535
eceeb5fc 35362012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
3537
3538 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
3539
71873e2b
SM
35402012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3541
3542 * data.c (PUT_ERROR): New macro.
3543 (syms_of_data): Use it. Add new error type `user-error'.
3544 * undo.c (user_error): New function.
3545 (Fprimitive_undo): Use it.
3546 * print.c (print_error_message): Adjust print style for `user-error'.
3547 * keyboard.c (user_error): New function.
3548 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
3549
ab0fa4e4
PE
35502012-05-03 Paul Eggert <eggert@cs.ucla.edu>
3551
3552 Do not limit current-time-string to years 1000..9999.
3553 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
3554 (Fcurrent_time_string): Support any year that is supported by the
3555 underlying localtime representation. Don't use asctime, as it
3556 has undefined behavior for years outside the range -999..9999.
3557
7ed806a7
PE
35582012-05-02 Paul Eggert <eggert@cs.ucla.edu>
3559
3560 Fix race conditions involving setenv, gmtime, localtime, asctime.
3561 Without this fix, interrupts could mess up code that uses these
3562 nonreentrant functions, since setting TZ invalidates existing
3563 tm_zone or tzname values, and since most of these functions return
3564 pointers to static storage.
3565 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
3566 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
3567 Grow the critical sections to include not just invoking
3568 localtime/gmtime, but also accessing these functions' results
3569 including their tm_zone values if any, and any related TZ setting.
3570 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
3571 so that the struct tm is saved in the critical section.
3572 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
3573 motivated by the fact that memory allocation needs to be outside
3574 the critical section.
3575
0c16dfed
DA
35762012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
3577
3578 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
3579 with RESET_INTERVAL.
3580
3581 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3582 Remove duplicated buffer name initialization.
3583
3f83ace8
JM
35842012-05-02 Jim Meyering <jim@meyering.net>
3585
3586 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
3587
c7b8541e
JM
3588 * xfns.c (x_window): Use xstrdup (Bug#11375).
3589
90207a15 35902012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
3591
3592 * xdisp.c (pos_visible_p): If already at a newline from the
3593 display string before the 'while' loop, don't walk back the glyphs
3594 from it3.glyph_row. Solves assertion violation when the display
3595 string begins with a newline (egg.el). (Bug#11367)
3596
b593d6a9
AH
35972012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
3598
3599 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
3600 Move to simple.el.
3601
4737362e
GM
36022012-05-01 Glenn Morris <rgm@gnu.org>
3603
99cf43f9
GM
3604 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
3605 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
3606 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
3607 All were removed before 23.1.
3608
9311dcff
GM
3609 * dispnew.c: Remove HAVE_LIBNCURSES test;
3610 it is always true on relevant platforms.
3611
4d5c6349
GM
3612 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
3613 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
3614
4737362e
GM
3615 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
3616
74dd3a6b
AS
36172012-04-30 Andreas Schwab <schwab@linux-m68k.org>
3618
3619 * .gdbinit (xpr): Remove checks for no longer existing misc types.
3620 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
3621 Remove.
3622
13c379ee
PE
36232012-04-28 Paul Eggert <eggert@cs.ucla.edu>
3624
3625 Do not avoid creating empty evaporating overlays (Bug#9642).
3626 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
3627 That is, do not delete an evaporating overlay if it becomes
3628 empty after its bounds are adjusted to fit within its buffer.
3629 This fix caused other problems, and I'm reverting it until we get
3630 to the bottom of them.
3631
a8e7d6d7 36322012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
3633
3634 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
3635
a8e7d6d7 36362012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
3637
3638 * xdisp.c (pos_visible_p): If the window start position is beyond
3639 ZV, start the display from buffer beginning. Prevents assertion
3640 violation in init_iterator when the minibuffer window is scrolled
3641 via the scroll bar.
3642
3643 * window.c (window_scroll_pixel_based): Likewise.
3644
a8e7d6d7 36452012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
3646
3647 * keymap.c (where_is_internal): Doc fix (Bug#10872).
3648
a8e7d6d7 36492012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
3650
3651 * fileio.c (Fcopy_file, Fset_file_selinux_context):
3652 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
3653
a8e7d6d7 36542012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 3655
b593d6a9
AH
3656 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
3657 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 3658
1c6900d9
EZ
36592012-04-26 Eli Zaretskii <eliz@gnu.org>
3660
4c3fa1d9
EZ
3661 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
3662 display element, check also the underlying string or buffer
3663 character. (Bug#11341)
3664
1c6900d9
EZ
3665 * w32menu.c: Include w32heap.h.
3666 (add_menu_item): If the call to AppendMenuW (via
3667 unicode_append_menu) fails, disable Unicode menus only if we are
3668 running on Windows 9X/Me.
3669
42bf8205
AS
36702012-04-24 Andreas Schwab <schwab@linux-m68k.org>
3671
3672 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
3673 (xgetint): Add missing shift for LSB tags.
3674
b1bac16e
MR
36752012-04-24 Martin Rudalics <rudalics@gmx.at>
3676
3677 * keyboard.c (read_char): Don't wipe echo area for select window
3678 events: These might get delayed via `mouse-autoselect-window'
3679 (Bug#11304).
3680
d69621cc
JB
36812012-04-24 Juanma Barranquero <lekktu@gmail.com>
3682
3683 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
3684 manipulation of :loaded-from data.
3685
02fd101b
JB
36862012-04-23 Juanma Barranquero <lekktu@gmail.com>
3687
3688 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
3689 now a cons (bug#11311).
3690
888bec30
PE
36912012-04-23 Paul Eggert <eggert@cs.ucla.edu>
3692
89a438bd
PE
3693 Do not create empty overlays with the evaporate property (Bug#9642).
3694 * buffer.c (Fmove_overlay): Delete an evaporating overlay
3695 if it becomes empty after its bounds are adjusted to fit within
3696 its buffer. Without this fix, in a nonempty buffer (let ((o
3697 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
3698 yields an empty overlay that has the evaporate property, which is
3699 not supposed to happen.
3700
1068fe4d
PE
3701 Fix minor GTK3 problems found by static checking.
3702 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3703 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3704 (struct _EmacsFixedClass, emacs_fixed_get_type):
3705 Move decls here from emacsgtkfixed.h, since they needn't be public.
3706 (emacs_fixed_get_type): Now static.
3707 (emacs_fixed_class_init): Omit unused local.
3708 (emacs_fixed_child_type): Remove; unused.
3709 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3710 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3711 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
3712 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
3713 (EMACS_FIXED_GET_CLASS): Remove; unused.
3714 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
3715
888bec30
PE
3716 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
3717 Problem reported by Juanma Barranquero for Windows -Wunused-function.
3718
de85e130
PE
37192012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3720
d0baac98 3721 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 3722 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
3723 (__malloc_size_t, __malloc_ptrdiff_t):
3724 Remove. All uses removed, replaced by the definiens if needed,
3725 since we can assume C89 or better now.
3726 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
3727 (protect_malloc_state, align, get_contiguous_space)
3728 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
3729 (malloc_atfork_handler_child, malloc_enable_thread)
3730 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
3731 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
3732 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
3733 (special_realloc, _realloc_internal_nolock, _realloc_internal)
3734 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
3735 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
3736 Define using prototypes, not old style.
3737 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
3738 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
3739 (align): Don't assume that signed integer overflow wraps around.
3740 Omit unused local var.
3741 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
3742 (_free_internal_nolock, memalign, mallochook, reallochook):
3743 Omit no-longer-needed casts.
3744 (valloc): Use getpagesize, not __getpagesize.
3745 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
3746 (struct hdr): The 'magic' member is now size_t, not unsigned long.
3747
de85e130
PE
3748 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
3749
dcbf5805
MA
37502012-04-22 Michael Albinus <michael.albinus@gmx.de>
3751
3752 Move functions from C to Lisp. Make non-blocking method calls
3753 the default. Implement further D-Bus standard interfaces.
3754
3755 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
3756 (QCdbus_request_name_allow_replacement)
3757 (QCdbus_request_name_replace_existing)
3758 (QCdbus_request_name_do_not_queue)
3759 (QCdbus_request_name_reply_primary_owner)
3760 (QCdbus_request_name_reply_in_queue)
3761 (QCdbus_request_name_reply_exists)
3762 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
3763 (QCdbus_registered_serial, QCdbus_registered_method)
3764 (QCdbus_registered_signal): New Lisp objects.
3765 (XD_DEBUG_MESSAGE): Use sizeof.
3766 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
3767 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
3768 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
3769 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
3770 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
3771 (xd_signature, xd_append_arg): Allow float for integer types.
3772 (xd_get_connection_references): New function.
b593d6a9
AH
3773 (xd_get_connection_address): Rename from xd_initialize.
3774 Return cached address.
dcbf5805
MA
3775 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
3776 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
3777 level.
3778 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 3779 Return number of refcounts.
dcbf5805
MA
3780 (Fdbus_get_unique_name): Make stronger parameter check.
3781 (Fdbus_message_internal): New defun.
3782 (Fdbus_call_method, Fdbus_call_method_asynchronously)
3783 (Fdbus_method_return_internal, Fdbus_method_error_internal)
3784 (Fdbus_send_signal, Fdbus_register_service)
3785 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
3786 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
3787 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
3788 (Vdbus_compiled_version, Vdbus_runtime_version)
3789 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
3790 (Vdbus_message_type_method_return, Vdbus_message_type_error)
3791 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
3792 (Vdbus_registered_buses, Vdbus_registered_objects_table):
3793 Adapt docstring.
dcbf5805 3794
52828e02
PE
37952012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3796
da05bc4c
PE
3797 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
3798 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
3799 Do not assume ptrdiff_t is the same width as 'int'.
3800
52828e02
PE
3801 * alloc.c: Handle unusual debugging option combinations.
3802 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
3803 since the two debugging options are incompatible.
3804 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
3805 is defined.
3806 (mem_init, mem_insert, mem_insert_fixup):
3807 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
3808 (NEED_MEM_INSERT): Remove; no longer needed.
3809
f01769f9
LL
38102012-04-22 Leo Liu <sdl.web@gmail.com>
3811
3812 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
3813
5790543d
PE
38142012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3815
3816 * sysdep.c [__FreeBSD__]: Minor cleanups.
3817 (list_system_processes, system_process_attributes) [__FreeBSD__]:
3818 Use Emacs indenting style more consistently. Avoid some casts.
3819 Use 'double' consistently rather than mixing 'float' and 'double'.
3820
b91b7e4d
EW
38212012-04-21 Eduard Wiebe <usenet@pusto.de>
3822
b593d6a9
AH
3823 * sysdep.c (list_system_processes, system_process_attributes):
3824 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 3825
6114eb15
AS
38262012-04-21 Andreas Schwab <schwab@linux-m68k.org>
3827
3828 * lisp.mk (lisp): Update.
3829
2f38dff7
PE
38302012-04-20 Paul Eggert <eggert@cs.ucla.edu>
3831
3832 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
3833 It is never used otherwise.
3834
4ae29f89
SM
38352012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
3836
3837 * print.c (print_preprocess): Only check print_depth if print-circle
3838 is nil.
3839 (print_object): Check for cycles even when print-circle is nil and
3840 print-gensym is t, but only check print_depth if print-circle is nil.
3841
f30d612a
CY
38422012-04-20 Chong Yidong <cyd@gnu.org>
3843
3844 * process.c (wait_reading_process_output): If EIO occurs on a pty,
3845 set the status to "failed" and ensure that sentinel is run.
3846
c07a4c0b 38472012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
3848
3849 * process.c (Fset_process_inherit_coding_system_flag)
3850 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 3851 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 3852
c07a4c0b 38532012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
3854
3855 * xdisp.c (string_buffer_position_lim): Limit starting position to
3856 BEGV.
3857 (set_cursor_from_row): If called for a mode-line or header-line
3858 row, return zero immediately.
3859 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
3860 farther than the first row after the header line, if any.
3861 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
3862 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
3863
c07a4c0b 38642012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3865
4ae29f89
SM
3866 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
3867 (bug#11238).
ad3a2b41 3868
c07a4c0b 38692012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 38702012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
3871
3872 configure: new option --enable-gcc-warnings (Bug#11207)
3873 * Makefile.in (C_WARNINGS_SWITCH): Remove.
3874 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
3875 (ALL_CFLAGS): Use new macros rather than old.
3876 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
3877 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
3878 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
3879 -Wunused-result, -Wunused-variable. This should go away once
3880 the Emacs and Gnulib regex code is merged.
3881 (xmalloc, xrealloc): Now static.
3882
aba027e8
PE
38832012-04-17 Paul Eggert <eggert@cs.ucla.edu>
3884
3885 * dired.c (Fsystem_groups): Remove unused local.
3886
e5a36063
GM
38872012-04-17 Glenn Morris <rgm@gnu.org>
3888
3889 * dired.c (Fsystem_users): Doc fix.
3890
316411f0
DA
38912012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
3892
3893 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
3894 (syms_of_dired): Add them.
3895
9426aba4
PE
38962012-04-16 Paul Eggert <eggert@cs.ucla.edu>
3897
b62a57be
PE
3898 Fix minor alloc.c problems found by static checking.
3899 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
3900 New extern decls, to avoid calling undeclared functions.
3901 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
3902 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
3903 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
3904 (NEED_MEM_INSERT): New macro.
3905 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 3906 Remove one incorrect comment and fix another.
b62a57be 3907
3539f31f
PE
3908 Fix minor ralloc.c problems found by static checking.
3909 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3910 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
3911 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
3912 (r_alloc_sbrk): Now static.
3913
a041960a
PE
3914 Improve ralloc.c interface checking.
3915 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3916 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
3917 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
3918 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
3919 [REL_ALLOC]: ... to here, to check interface.
3920 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
3921 Remove decls. This fixes an "It stinks!".
3922
9426aba4
PE
3923 * alloc.c (which_symbols): Fix alignment issue / type clash.
3924
d55c12ed
AS
39252012-04-15 Andreas Schwab <schwab@linux-m68k.org>
3926
3927 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
3928 (struct Lisp_Misc_Any): Likewise.
3929 (struct Lisp_Free): Likewise.
3930 * alloc.c (union aligned_Lisp_Symbol): Define.
3931 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
3932 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
3933 (union aligned_Lisp_Misc): Define.
3934 (MARKER_BLOCK_SIZE, struct marker_block): Use union
3935 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 3936 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 3937
b948ce8b
PE
39382012-04-14 Paul Eggert <eggert@cs.ucla.edu>
3939
3940 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
3941 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
3942 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
3943 * s/netbsd.h, s/sol2-6.h:
3944 Remove definition of GC_MARK_STACK, since the default now works.
3945 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
3946 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
3947 no longer the default.
3948 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
3949
35dc09a1 39502012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3951
35dc09a1
GM
3952 * lread.c (lisp_file_lexically_bound_p):
3953 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 3954
35dc09a1
GM
39552012-04-14 Eli Zaretskii <eliz@gnu.org>
3956
3957 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
3958 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
3959
39602012-04-14 Jan Djärv <jan.h.d@swipnet.se>
3961
3962 * nsterm.m (constrainFrameRect): Always constrain when there is only
3963 one screen (Bug#10962).
3964
bcd86815
KB
39652012-04-13 Ken Brown <kbrown@cornell.edu>
3966
3967 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
3968
c25df26e
RT
39692012-04-13 Reuben Thomas <rrt@sc3d.org>
3970
3971 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
3972
0fc59f1e
DC
39732012-04-11 Daniel Colascione <dancol@dancol.org>
3974
3975 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
3976 against is gone. It's better to use vfork now so that when Cygwin
3977 gains a new, working vfork, we use it automatically (bug#10398).
3978
de8c03dc
SM
39792012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3980
3981 * window.c (save_window_save): Obey window-point-insertion-type.
3982
2f097256
GM
39832012-04-11 Glenn Morris <rgm@gnu.org>
3984
3985 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
3986
453b951e
SM
39872012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3988
3989 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
3990
75f1671a 39912012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
3992
3993 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
3994 (force_quit_count): New var.
3995 (handle_interrupt): Use it.
3996
2a8ce227
JB
39972012-04-10 Juanma Barranquero <lekktu@gmail.com>
3998
3999 * w32.c (w32_delayed_load): Record the full path of the library
4000 being loaded (bug#10424).
4001
935396c0
GM
40022012-04-09 Glenn Morris <rgm@gnu.org>
4003
05920a43
GM
4004 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
4005 not just in the obarray, before snarfing them. (Bug#11036)
4006
935396c0
GM
4007 * Makefile.in ($(leimdir)/leim-list.el):
4008 Pass EMACS rather than BUILT_EMACS.
4009
a18ecafa
TZ
40102012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
4011
4012 * process.c (make_process):
4013 * process.h: Add integer `gnutls_handshakes_tried' member to
4014 process struct.
4015
6bbef4e5
JC
4016 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
4017 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
4018
4019 * gnutls.c (gnutls_log_function2i): Convenience log function.
4020 (emacs_gnutls_read): Use new log functions,
4021 `gnutls_handshakes_tried' process member, and
4022 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
4023 attempts per process (connection).
4024
b4d3bc10
CY
40252012-04-09 Chong Yidong <cyd@gnu.org>
4026
4027 * eval.c (Fuser_variable_p, user_variable_p_eh)
4028 (lisp_indirect_variable): Functions deleted.
4029 (Fdefvar): Caller changed.
4030
4031 * callint.c (Finteractive, Fcall_interactively):
4032 * minibuf.c (Fread_variable): Callers changed.
4033
70f4d973
EZ
40342012-04-09 Eli Zaretskii <eliz@gnu.org>
4035
4036 * xdisp.c (set_cursor_from_row): If the display string appears in
4037 the buffer at position that is closer to point than the position
4038 after the display string, display the cursor on the first glyph of
4039 the display string. Fixes cursor display when a 'display' text
4040 property immediately follows invisible text. (Bug#11094)
4041
cb3c2e3e
PE
40422012-04-09 Paul Eggert <eggert@cs.ucla.edu>
4043
4044 composite.c: use 'double' consistently
4045 * composite.c (get_composition_id): Use 'double' consistently
4046 instead of converting 'float' to 'double' and vice versa; this is
4047 easier to understand and avoids a GCC warning.
4048
fd06db5d
GM
40492012-04-09 Glenn Morris <rgm@gnu.org>
4050
50fe702a
GM
4051 * Makefile.in: Generate leim-list with bootstrap-emacs, in
4052 preparation for dumping it with emacs. (Bug#4789)
4053 (leimdir): New variable.
4054 ($(leimdir)/leim-list.el): New rule.
4055 (emacs$(EXEEXT)): Depend on leim-list.el.
4056
fd06db5d
GM
4057 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
4058 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
4059 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
4060
55c131ee
AS
40612012-04-08 Andreas Schwab <schwab@linux-m68k.org>
4062
4063 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
4064 proper alignment.
4065
9209588f
JB
40662012-04-07 Juanma Barranquero <lekktu@gmail.com>
4067
4068 * xml.c (init_libxml2_functions) [WINDOWSNT]:
4069 Remove unused local variable.
4070
e3fb2efb
PE
40712012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4072
4073 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
4074 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
4075 (mark_memory): Mark Lisp_Objects only if pointers might hide in
4076 objects, as mark_maybe_pointer will catch them otherwise.
4077 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
4078 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
4079
b5385551
PE
40802012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4081
4082 Fix typo that broke non-Windows builds.
4083 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
4084
9078ead6
EZ
40852012-04-07 Eli Zaretskii <eliz@gnu.org>
4086
4087 Support building on MS-Windows with libxml2.
4088
4089 * makefile.w32-in (OBJ2): Add xml.$(O).
4090 (GLOBAL_SOURCES): Add xml.c.
4091 ($(BLD)/xml.$(O)): New dependency list.
4092
4093 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
4094 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
4095 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
4096 [!WINDOWSNT]: New macros.
4097 (init_libxml2_functions, libxml2_loaded_p): New functions.
4098 (parse_region): Call fn_xmlCheckVersion instead of using the macro
4099 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
4100 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
4101 Calls xmlCleanupParser only if libxml2 was loaded (or statically
4102 linked in).
6bbef4e5
JC
4103 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
4104 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
4105 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
4106
4107 * emacs.c: Don't include libxml/parser.h.
4108 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
4109 xmlCleanupParser directly.
4110
4111 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
4112
3811fdf3
EZ
41132012-04-07 Eli Zaretskii <eliz@gnu.org>
4114
4115 * indent.c (Fvertical_motion): If there is a display string at
4116 point, use it.vpos to compute how many lines to backtrack after
4117 move_it_to point. (Bug#11133)
4118
2f8e16b2
EZ
41192012-04-06 Eli Zaretskii <eliz@gnu.org>
4120
4121 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
4122 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
4123 about subtle differences between FETCH_CHAR* and STRING_CHAR*
4124 macros related to unification of CJK characters. For the details,
4125 see the discussion following the message here:
4126 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
4127
3d439cd1
CY
41282012-04-04 Chong Yidong <cyd@gnu.org>
4129
4130 * keyboard.c (Vdelayed_warnings_list): Doc fix.
4131
8bc53d00
EZ
41322012-04-01 Eli Zaretskii <eliz@gnu.org>
4133
4134 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
4135 instead of alloca. (Bug#11138)
4136
3b0512a3
AS
41372012-04-01 Andreas Schwab <schwab@linux-m68k.org>
4138
4139 * w32menu.c (is_simple_dialog): Properly check lisp types.
4140 (Bug#11141)
4141
8427ddd2
EZ
41422012-03-31 Eli Zaretskii <eliz@gnu.org>
4143
979022ef
EZ
4144 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
4145 position we get to after a call to move_it_to fails the
4146 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
4147 only if we wind up in a string from display property. (Bug#11063)
4148
a6b1c7cc
EZ
4149 * window.c (Fdelete_other_windows_internal): Invalidate the row
4150 and column information about mouse highlight, so that redisplay
4151 restores it after reallocating the glyph matrices. (Bug#7464)
4152
8427ddd2
EZ
4153 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
4154 string comes from a `display' text property, use the buffer
4155 position of that property as if we actually saw that position in
4156 the row's glyphs.
697ba24b
EZ
4157 (move_it_by_lines): Remove the assertion that
4158 "it->current_x == 0 && it->hpos == 0" which can be legitimately
4159 violated when there's a before-string at the beginning of a line.
4160 (Bug#11063)
8427ddd2 4161
65a0a738
EZ
41622012-03-30 Eli Zaretskii <eliz@gnu.org>
4163
4164 * xdisp.c (append_space_for_newline): If the default face was
4165 remapped, use the remapped face for the appended newline.
4166 (extend_face_to_end_of_line): Use the remapped default face for
4167 extending the face to the end of the line.
4168 (display_line): Call extend_face_to_end_of_line when the default
4169 face was remapped. (Bug#11068)
4170
581355cc
EZ
41712012-03-29 Eli Zaretskii <eliz@gnu.org>
4172
4173 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
4174
e8fc049f
SM
41752012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4176
4177 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
4178
4fb9a543
GM
41792012-03-27 Glenn Morris <rgm@gnu.org>
4180
4181 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
4182 Doc fixes.
4183
679910f1
KH
41842012-03-26 Kenichi Handa <handa@m17n.org>
4185
4186 * dispextern.h (struct glyph): Fix previous change. Change the
4187 bit length of glyphless.ch to 25 (Bug#11082).
4188
90d49b7f
CY
41892012-03-26 Chong Yidong <cyd@gnu.org>
4190
4191 * keyboard.c (Vselection_inhibit_update_commands): New variable.
4192 (command_loop_1): Use it; inhibit selection update for
4193 handle-select-window too (Bug#8996).
4194
f514f6f0
FP
41952012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
4196
e8fc049f 4197 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 4198
bf43fa51
KH
41992012-03-25 Kenichi Handa <handa@m17n.org>
4200
4201 * dispextern.h (struct glyph): Change the bit length of
4202 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
4203
8a0c01dd
EZ
42042012-03-24 Eli Zaretskii <eliz@gnu.org>
4205
4206 * s/ms-w32.h (tzname): Include time.h before redirecting to
4207 _tzname. Fixes the MSVC build. (Bug#9960)
4208
7d1c3a76
AS
42092012-03-24 Andreas Schwab <schwab@linux-m68k.org>
4210
8ed79523
AS
4211 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
4212 characters.
4213
7d1c3a76
AS
4214 * xterm.c (XTread_socket): Only modify handling_signal if
4215 !SYNC_INPUT. (Bug#11080)
4216
e99a9b8b
EZ
42172012-03-23 Eli Zaretskii <eliz@gnu.org>
4218
4219 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
4220 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
4221 when fetching a multibyte character consumes more bytes than
4222 CHAR_BYTES returns, due to unification of CJK characters in
4223 string_char. (Bug#11073)
4224
5063c0e1
TN
42252012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
4226
4227 * process.c (wait_reading_process_output): Handle pty disconnect
4228 by refraining from sending oneself a SIGCHLD (bug#10933).
4229
9f851fbd
CY
42302012-03-22 Chong Yidong <cyd@gnu.org>
4231
4232 * dispextern.h (struct it): New member string_from_prefix_prop_p.
4233
5063c0e1 4234 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
4235 Mark string as coming from a prefix property.
4236 (handle_face_prop): Use default face for prefix strings (Bug#4281).
4237 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
4238
fb5b8aca
CY
42392012-03-21 Chong Yidong <cyd@gnu.org>
4240
4241 * xfaces.c (Vface_remapping_alist): Doc fix.
4242
62356a1b
EZ
42432012-03-20 Eli Zaretskii <eliz@gnu.org>
4244
4245 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
4246 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
4247 Doc fixes.
62356a1b 4248
025de85b
CY
42492012-03-20 Chong Yidong <cyd@gnu.org>
4250
4251 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
4252 to reflect default non-nil value of redisplay-dont-pause.
4253
4827f94e
KH
42542012-03-19 Kenichi Handa <handa@m17n.org>
4255
4256 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
4257 it fit in a valid range (Bug#11003).
4258
e50a24a2
EZ
42592012-03-18 Eli Zaretskii <eliz@gnu.org>
4260
4261 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
4262 that is not from display property, accept the row as a "cursor
4263 row" if one of the string's character has a non-nil `cursor'
4264 property. Fixes cursor positioning when there are newlines in
4265 overlay strings, e.g. in icomplete.el. (Bug#11035)
4266
9af5ed87
PE
42672012-03-12 Paul Eggert <eggert@cs.ucla.edu>
4268
4269 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
4270
d1f55f16
CY
42712012-03-12 Chong Yidong <cyd@gnu.org>
4272
4273 * eval.c (inhibit_lisp_code): Rename from
4274 inhibit_window_configuration_change_hook; move from window.c.
4275
4276 * xfns.c (unwind_create_frame_1, Fx_create_frame):
4277 * window.c (run_window_configuration_change_hook)
4278 (syms_of_window): Callers changed.
4279
66c5eebd
CY
42802012-03-11 Chong Yidong <cyd@gnu.org>
4281
413df973
CY
4282 * keymap.c (Fkey_description): Doc fix (Bug#9700).
4283
66c5eebd
CY
4284 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
4285
1de11f56
CY
42862012-03-10 Chong Yidong <cyd@gnu.org>
4287
4288 * frame.c (other_visible_frames): Don't assume the selected frame
4289 is visible (Bug#10955).
4290
cae07000
SM
42912012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
4292
4293 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
4294
89c94350
JD
42952012-03-08 Jan Djärv <jan.h.d@swipnet.se>
4296
4297 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
4298 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
4299 zero (Bug#10954).
4300
999dd333
GM
43012012-03-03 Glenn Morris <rgm@gnu.org>
4302
01a6dcc8 4303 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 4304
de0100f2
EZ
43052012-03-02 Eli Zaretskii <eliz@gnu.org>
4306
4307 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
4308 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
4309 (redisplay_window, next_element_from_string): Fix typos in
4310 comments.
3e441275
EZ
4311 (redisplay_window): Pass to move_it_vertically the margin in
4312 pixels, not in screen lines.
de0100f2 4313
96a72ee9
GM
43142012-03-02 Glenn Morris <rgm@gnu.org>
4315
4316 * buffer.c (buffer-list-update-hook): Doc fix.
4317
312508d7
EZ
43182012-02-29 Eli Zaretskii <eliz@gnu.org>
4319
4320 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
4321 push_it before setting up the iterator for the first overlay
4322 string, even if we have an empty string loaded.
4323 (next_overlay_string): If there's an empty string on the iterator
4324 stack, pop the stack. (Bug#10903)
4325
27f3c637
PE
43262012-02-25 Paul Eggert <eggert@cs.ucla.edu>
4327
4328 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
4329 Suggested by Stefan Monnier in
4330 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
4331 * alloc.c (widen_to_Lisp_Object): New static function.
4332 (mark_memory): Also mark Lisp_Objects by fetching pointer words
4333 and widening them to Lisp_Objects. This would work even if
4334 USE_LSB_TAG is defined and wide integers are used, which might
4335 happen in a future version of Emacs.
4336
3c9dfce6
CY
43372012-02-25 Chong Yidong <cyd@gnu.org>
4338
fa74b241
CY
4339 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
4340 Doc fix.
4341
3c9dfce6
CY
4342 * xselect.c (Fx_selection_exists_p): Doc fix.
4343 (x_clipboard_manager_save_all): Print an informative message
4344 before saving to clipboard manager.
4345
9486df08
CY
43462012-02-24 Chong Yidong <cyd@gnu.org>
4347
4348 * keyboard.c (process_special_events): Handle all X selection
4349 requests in kbd_buffer, not just the next one (Bug#8869).
4350
f01d3321
CY
43512012-02-23 Chong Yidong <cyd@gnu.org>
4352
4353 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
4354 call when setting menu-bar-lines and tool-bar-lines parameters.
4355 (unwind_create_frame_1): New helper function.
4356
4357 * window.c (inhibit_window_configuration_change_hook): New var.
4358 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 4359 (syms_of_window): Initialize it.
f01d3321 4360
86b847b6
CY
43612012-02-22 Chong Yidong <cyd@gnu.org>
4362
4363 * xterm.c (x_draw_image_relief): Add missing type check for
4364 Vtool_bar_button_margin (Bug#10743).
4365
a59225b1
CY
43662012-02-21 Chong Yidong <cyd@gnu.org>
4367
4368 * fileio.c (Vfile_name_handler_alist): Doc fix.
4369
4370 * buffer.c (Fget_file_buffer): Protect against invalid file
4371 handler return value.
4372
310f5bd4
PE
43732012-02-20 Paul Eggert <eggert@cs.ucla.edu>
4374
cb3a28cc
PE
4375 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
4376 when computing $valmask.
4377
310f5bd4
PE
4378 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
4379 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
4380 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
4381 It's useless in that case, and it can cause problems on hosts
4382 that allocate halves of EMACS_INT values separately.
4383 Reported by Dan Horák. Diagnosed by Andreas Schwab in
4384 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
4385 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
4386 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
4387 it avoids undefined behavior on hosts where shifting right by more
4388 than the word width has undefined behavior.
4389
2375c96a
CY
43902012-02-19 Chong Yidong <cyd@gnu.org>
4391
4392 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
4393 (Funhandled_file_name_directory, Ffile_name_as_directory)
4394 (Fdirectory_file_name, Fexpand_file_name)
4395 (Fsubstitute_in_file_name): Protect against invalid file handler
4396 return values (Bug#10845).
4397
3eb49e71
EZ
43982012-02-18 Eli Zaretskii <eliz@gnu.org>
4399
4400 * .gdbinit (pitx): Fix incorrect references to fields of the
4401 iterator stack.
4402
7b926f3f
CY
44032012-02-17 Chong Yidong <cyd@gnu.org>
4404
4405 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
4406
11273115
PE
44072012-02-15 Paul Eggert <eggert@cs.ucla.edu>
4408
4409 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
4410 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
4411
c3a70e2b
CY
44122012-02-15 Chong Yidong <cyd@gnu.org>
4413
4414 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
4415 marked as special. Also, starting docstrings with * is obsolete.
4416
0ca43699
AS
44172012-02-13 Andreas Schwab <schwab@linux-m68k.org>
4418
4419 * gnutls.c (emacs_gnutls_write): Fix last change.
4420
2e8f3c56
LI
44212012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
4422
4423 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
4424 send_process.
4425
af70074f
SM
44262012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
4427
4428 * keymap.c (Fsingle_key_description): Handle char ranges.
4429
95986d52
CY
44302012-02-12 Chong Yidong <cyd@gnu.org>
4431
afd83bd1
CY
4432 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
4433 as that creates a dangerous corner case.
4434
95986d52
CY
4435 * window.c (Fdelete_window_internal): Invalidate the mouse
4436 highlight (Bug#9904).
4437
bd7da63e
GM
44382012-02-12 Glenn Morris <rgm@gnu.org>
4439
4440 * xselect.c (Fx_own_selection_internal)
4441 (Fx_get_selection_internal, Fx_disown_selection_internal)
4442 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
4443 * nsselect.m (Fx_own_selection_internal)
4444 (Fx_disown_selection_internal, Fx_selection_exists_p)
4445 (Fx_selection_owner_p, Fx_get_selection_internal):
4446 Sync docs and argument specs with the xselect.c versions.
4447
77abcbc2
LI
44482012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
4449
4450 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
4451
90b671e2
EZ
44522012-02-11 Eli Zaretskii <eliz@gnu.org>
4453
1c0ca0b7
EZ
4454 * w32select.c (Fx_selection_exists_p): Sync doc string and
4455 argument list with xselect.c. (Bug#10783)
4456
4457 * w16select.c (Fx_selection_exists_p): Sync doc string and
4458 argument list with xselect.c. (Bug#10783)
90b671e2 4459
49241268
GM
44602012-02-10 Glenn Morris <rgm@gnu.org>
4461
4462 * fns.c (Fsecure_hash): Doc fix.
4463
f998bbe7 44642012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
4465
4466 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
4467
0992bd9c
CY
44682012-02-07 Chong Yidong <cyd@gnu.org>
4469
4470 * buffer.c (Fbuffer_local_variables)
4471 (buffer_lisp_local_variables): Handle unbound vars correctly;
4472 don't let Qunbound leak into Lisp.
4473
af008560
GM
44742012-02-07 Glenn Morris <rgm@gnu.org>
4475
dd605cc4
GM
4476 * image.c (Fimagemagick_types): Doc fix.
4477
af008560
GM
4478 * image.c (imagemagick-render-type): Change it from a lisp object
4479 to an integer. Move the doc here from the lisp manual.
4480 Treat all values not equal to 0 the same.
4481
1449fa1d
CY
44822012-02-06 Chong Yidong <cyd@gnu.org>
4483
4484 * doc.c (store_function_docstring): Avoid applying docstring of
4485 alias to base function (Bug#2603).
4486
3723ec07
AS
44872012-02-04 Andreas Schwab <schwab@linux-m68k.org>
4488
4489 * .gdbinit (pp1, pv1): Remove redundant defines.
4490 (pr): Use pp.
4491
79c1cc1e
CY
44922012-02-04 Chong Yidong <cyd@gnu.org>
4493
4494 * nsterm.m: Declare a global (Bug#10694).
4495
d7f29f8e
EZ
44962012-02-04 Eli Zaretskii <eliz@gnu.org>
4497
cae07000
SM
4498 * w32.c (get_emacs_configuration_options):
4499 Include --enable-checking, if specified, in the return value.
d7f29f8e 4500
3b95a6f9
MR
45012012-02-04 Martin Rudalics <rudalics@gmx.at>
4502
4503 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
4504 after rounding frame sizes. (Bug#9723)
4505
d6fa96a6
EZ
45062012-02-04 Eli Zaretskii <eliz@gnu.org>
4507
4508 * keyboard.c (adjust_point_for_property): Don't position point
4509 before BEGV. (Bug#10696)
4510
df0b2940
PE
45112012-02-03 Paul Eggert <eggert@cs.ucla.edu>
4512
4513 Handle overflow when computing char display width (Bug#9496).
4514 * character.c (char_width): Return EMACS_INT, not int.
4515 (char_width, c_string_width): Check for overflow when
4516 computing the width; this is possible now that individual
4517 characters can have unbounded width. Problem introduced
4518 by merge from Emacs 23 on 2012-01-19.
4519
6bee44d6
MA
45202012-02-02 Michael Albinus <michael.albinus@gmx.de>
4521
4522 * dbusbind.c (Fdbus_register_method): Mention the return value
4523 :ignore in the docstring.
4524
44f92739
GM
45252012-02-02 Glenn Morris <rgm@gnu.org>
4526
1b9f60cc
GM
4527 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
4528
44f92739
GM
4529 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4530 Unconditionally set to t. (Bug#10673)
4531 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4532 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4533 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
4534
c5d3843c
KH
45352012-02-02 Kenichi Handa <handa@m17n.org>
4536
4537 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
4538 0, do not call append_composite_glyph.
4539
159462d4 45402012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
4541
4542 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
4543 NULL (Bug#6988).
4544 (x_produce_glyphs): If the component of a composition is a null
4545 string, set it->pixel_width to 1 to avoid zero-width glyph.
4546
78cef877
EZ
45472012-02-01 Eli Zaretskii <eliz@gnu.org>
4548
4549 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
4550 first 2 arguments are identical. This makes inserting large
4551 output from a subprocess an order of magnitude faster on
4552 MS-Windows, where all sbrk'ed memory is always contiguous.
4553
97897668
GM
45542012-01-31 Glenn Morris <rgm@gnu.org>
4555
4556 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 4557 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
4558 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
4559
31fd3586
GM
45602012-01-29 Glenn Morris <rgm@gnu.org>
4561
4562 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
4563
0e24a8b2
CY
45642012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
4565
4566 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
4567
cc0adcb0
CY
45682012-01-28 Chong Yidong <cyd@gnu.org>
4569
4570 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
4571
acc28cb9
CY
45722012-01-26 Chong Yidong <cyd@gnu.org>
4573
9c69cfb7
CY
4574 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
4575
acc28cb9
CY
4576 * search.c (Fsearch_forward, Fsearch_backward): Document negative
4577 repeat counts (Bug#10507).
4578
48da7392
GM
45792012-01-26 Glenn Morris <rgm@gnu.org>
4580
4581 * lread.c (syms_of_lread): Doc fix.
4582
14af5f7f
CY
45832012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
4584
4585 * coding.c (encode_designation_at_bol): Change return value to
4586 EMACS_INT.
4587
0b21c100
CY
45882012-01-25 Chong Yidong <cyd@gnu.org>
4589
4590 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
4591
3c2907f7
CY
45922012-01-21 Chong Yidong <cyd@gnu.org>
4593
4594 * floatfns.c (Fcopysign): Make the second argument non-optional,
4595 since nil is not allowed anyway.
4596
959ad23f
AS
45972012-01-21 Andreas Schwab <schwab@linux-m68k.org>
4598
4599 * process.c (read_process_output): Use p instead of XPROCESS (proc).
4600 (send_process): Likewise.
4601
34a02f46
MR
46022012-01-19 Martin Rudalics <rudalics@gmx.at>
4603
4604 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
4605 (Vwindow_persistent_parameters): Do not use Qstate.
4606 Rewrite doc-strings.
34a02f46 4607
1259009a 46082012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
4609
4610 * character.c (char_width): New function.
70d4fdf6
GM
4611 (Fchar_width, c_string_width, lisp_string_width):
4612 Use char_width (Bug#9496).
25ed9e61 4613
6a6ee00d
MR
46142012-01-16 Martin Rudalics <rudalics@gmx.at>
4615
4616 * window.c (Vwindow_persistent_parameters): New variable.
4617 (Fset_window_configuration, save_window_save): Handle persistent
4618 window parameters.
4619
c85efaf7
EZ
46202012-01-14 Eli Zaretskii <eliz@gnu.org>
4621
4622 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
4623 thrashing the stack of the thread. (Bug#9087)
4624
5944709e
PE
46252012-01-12 Paul Eggert <eggert@cs.ucla.edu>
4626
4627 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
4628
e71f5d99
EZ
46292012-01-11 Eli Zaretskii <eliz@gnu.org>
4630
4631 * xdisp.c (rows_from_pos_range): Handle the case where the
4632 highlight ends on a newline. (Bug#10464)
4633 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
4634 he end column for display of highlight that ends on a newline
4635 before a R2L line.
4636
ce316182
GM
46372012-01-11 Glenn Morris <rgm@gnu.org>
4638
4639 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
4640 from load-path also when installation-directory is nil. (Bug#10208)
4641
5b43da69
GM
46422012-01-10 Glenn Morris <rgm@gnu.org>
4643
74cc8ff9
GM
4644 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
4645
7d8d6e4e
GM
4646 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
4647 Update template values to be closer to their typical values these days.
5b43da69 4648
a0db8d43
EZ
46492012-01-09 Eli Zaretskii <eliz@gnu.org>
4650
4651 * xdisp.c (rows_from_pos_range): Accept additional argument
4652 DISP_STRING, and accept any glyph in a row whose object is that
4653 string as eligible for mouse highlight. Fixes mouse highlight of
4654 display strings from overlays. (Bug#10464)
4655
9a0115ab 46562012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 4657
b9110d6a 4658 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
4659 * fileio.c (auto_saving_dir_umask): New static var.
4660 (Fmake_directory_internal): Use it.
4661 (do_auto_save_make_dir): Set it, instead of invoking chmod after
4662 creating the directory. The old code temporarily assigns
4663 too-generous permissions to the directory.
4664 (do_auto_save_eh): Clear it.
b9110d6a 4665 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
4666 that the var is always cleared.
4667
6c1bd3f3
EZ
46682012-01-07 Eli Zaretskii <eliz@gnu.org>
4669
4670 * search.c (scan_buffer): Pass character positions to
4671 know_region_cache, not byte positions. (Bug#6540)
4672
069d2b50
L
46732012-01-07 LynX <_LynX@bk.ru> (tiny change)
4674
4675 * w32.c (sys_rename): Report EXDEV when rename of a directory
4676 fails because the target is on another logical disk. (Bug#10284)
4677
75bf0d33
DB
46782012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
4679
4680 * xterm.c (x_embed_request_focus): New function.
4681
4682 * xterm.h: Add prototype.
4683
4684 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
4685
1c6e5a32
GM
46862012-01-05 Glenn Morris <rgm@gnu.org>
4687
4688 * emacs.c (emacs_copyright): Update short copyright year to 2012.
4689
651e947e
EZ
46902012-01-01 Eli Zaretskii <eliz@gnu.org>
4691
4692 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
4693 Load gnutls_transport_set_lowat only if GnuTLS version is below
4694 2.11.1.
4695 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
4696 GnuTLS versions below 2.11.1.
4697
3778cdd8
AL
46982011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
4699
4700 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
4701 to the doc string advising against its use for altering the way
4702 windows are scrolled.
4703
0e5317f7
KH
47042011-12-28 Kenichi Handa <handa@m17n.org>
4705
4706 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
4707 coding-system ASCII compatible only when it does not produce BOM
4708 on encoding (Bug#10383).
4709
93d5ca1f
JD
47102011-12-26 Jan Djärv <jan.h.d@swipnet.se>
4711
4712 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
4713 can scroll.
4714 (create_and_show_popup_menu): Always use menu_position_func for
4715 Gtk3 (Bug#10361).
4716
ca22b785
AS
47172011-12-24 Andreas Schwab <schwab@linux-m68k.org>
4718
4719 * callint.c (Fcall_interactively): Don't truncate prompt string.
4720
d048e1e6
EZ
47212011-12-23 Eli Zaretskii <eliz@gnu.org>
4722
4723 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
4724 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 4725 resumed from there (after widening). (Bug#10360)
d048e1e6 4726
5ccaba1f
JD
47272011-12-22 Jan Djärv <jan.h.d@swipnet.se>
4728
4729 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
4730
204ee57f
JD
47312011-12-21 Jan Djärv <jan.h.d@swipnet.se>
4732
b81d40f0
JB
4733 * nsterm.m (x_free_frame_resources):
4734 Release f->output_data.ns->miniimage.
204ee57f
JD
4735 (ns_index_color): Fix indentation. Do not retain
4736 color_table->colors[i].
4737
4738 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
4739 before returning.
4740
4741 * nsfns.m (x_set_background_color): Assign return value from
4742 ns_index_color to face-background instead of NSColor*.
4743 (ns_implicitly_set_icon_type): Fix indentation.
4744 Change assignment in for loop to comparison.
4745
4746 * emacs.c (ns_pool): New variable.
4747 (main): Assign ns_pool.
4748 (Fkill_emacs): Call ns_release_autorelease_pool.
4749
4750 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
4751 autorelease fdesc, release fdAttrs and tdict.
4752 (ns_get_covering_families): Release charset.
4753 (ns_findfonts): Release NSFontDescriptor created with new.
4754 (ns_uni_to_glyphs): Fix indentation.
4755 (setString): Release attrStr before assigning new value.
4756
c803b2b7
JD
47572011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4758
678f4426
JD
4759 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
4760 and NS_IMPL_COCOA.
4761 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
4762 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
4763
cd394be1 47642011-12-18 David Reitter <reitter@cmu.edu>
678f4426 4765
5fecd5fc
JD
4766 * nsterm.m (ns_term_init): Subscribe for notifications
4767 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
4768 to method trackingNotification in EmacsMenu.
4769
4770 * nsmenu.m (trackingMenu): New variable.
3771cb17 4771 (trackingNotification): New method (from Aquamacs).
5fecd5fc 4772 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 4773 from Aquamacs (Bug#7030).
678f4426
JD
4774
47752011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 4776
c803b2b7
JD
4777 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
4778 (symbol_to_nsstring): Fix indentation.
4779 (ns_symbol_to_pb): New function.
cae07000
SM
4780 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
4781 (Fns_rotate_cut_buffers_internal): Remove.
4782 (Fns_store_selection_internal): Rename from
c803b2b7
JD
4783 Fns_store_cut_buffer_internal.
4784 (ns_get_foreign_selection, Fx_own_selection_internal)
4785 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
4786 (Fns_get_selection_internal, Fns_store_selection_internal):
4787 Use ns_symbol_to_pb and check if return value is nil.
4788 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
4789 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
4790 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
4791 renamed to Sns_store_selection_internal.
4792 (ns_handle_selection_request): Move code to Fx_own_selection_internal
4793 and remove this function.
4794 (ns_handle_selection_clear): Remove, never used.
4795 (Fx_own_selection_internal): Move code from ns_handle_selection_request
4796 here.
4797
e1b01a3a
KB
47982011-12-17 Ken Brown <kbrown@cornell.edu>
4799
4800 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
4801 GID is unknown (Bug#10257).
4802
2adb6e85
PE
48032011-12-17 Paul Eggert <eggert@cs.ucla.edu>
4804
4805 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
4806 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
4807 which caused a build failure on GNU/Linux IA-64. This problem was
4808 introduced by my 2011-10-07 patch.
4809
d1d7b339
JL
48102011-12-15 Juri Linkov <juri@jurta.org>
4811
4812 * image.c (imagemagick_error): New function. (Bug#10112)
4813 (imagemagick_load_image): Comment out `MagickSetResolution' call.
4814 Use `imagemagick_error' where ImageMagick functions return
4815 `MagickFalse'.
4816 (Fimagemagick_types): Add `Fnreverse' to return the list in the
4817 proper order.
4818
100d5755
KH
48192011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4820
4821 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
4822 fill background (Bug#8992).
4823
454592a6
MR
48242011-12-13 Martin Rudalics <rudalics@gmx.at>
4825
4826 * window.c (Vwindow_combination_resize)
4827 (Vwindow_combination_limit): Use t instead of non-nil in
4828 doc-strings.
61d4b438
MR
4829 (Vrecenter_redisplay): Add first sentence of doc-string on
4830 separate line.
53524d93 4831 (Frecenter): Fix doc-string typo.
454592a6 4832
3633e3aa
KH
48332011-12-11 Kenichi Handa <handa@m17n.org>
4834
4835 * coding.c (Funencodable_char_position): Pay attention to the
4836 buffer text relocation (Bug#9389).
4837
7b9d523a 48382011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 4839
7b9d523a
JD
4840 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
4841 gtk_init (Bug#10100).
4842
b73189c6
EZ
48432011-12-10 Eli Zaretskii <eliz@gnu.org>
4844
4845 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
4846 IT->string is nil. (Bug#10263)
4847
f7dfe5d6
JD
48482011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4849
83faebb4
JD
4850 * nsterm.h (x_free_frame_resources): Declare.
4851
f7dfe5d6
JD
4852 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
4853 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
4854
4855 * nsterm.h (ns_get_defaults_value): Declare.
4856
4857 * nsterm.m (ns_default): Call ns_get_defaults_value.
4858
7cd4e72c
EZ
48592011-12-09 Eli Zaretskii <eliz@gnu.org>
4860
4861 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
4862 (Bug#10170)
4863
b34d7317
YM
48642011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4865
4866 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
4867 that where the value of an _OBJC_* symbol points to is in the .bss
4868 section (Bug#10240).
4869
76470ad1
KH
48702011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4871
4872 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 4873 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 4874
745fff94
KH
48752011-12-08 Kenichi Handa <handa@m17n.org>
4876
4877 * ftfont.c (get_adstyle_property): Fix previous change
4878 (Bug#10233).
4879
6e44397c
JB
48802011-12-07 Juanma Barranquero <lekktu@gmail.com>
4881
4882 * w32.c (init_environment): If no_site_lisp, remove site-lisp
4883 dirs from the default value of EMACSLOADPATH (bug#10208).
4884
7efa6272
GM
48852011-12-07 Glenn Morris <rgm@gnu.org>
4886
4887 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
4888 installation and source directories as well. (Bug#10208)
4889
f6fc4d87
CY
48902011-12-06 Chong Yidong <cyd@gnu.org>
4891
4892 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
4893
2bf26180
GM
48942011-12-06 Glenn Morris <rgm@gnu.org>
4895
4896 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
4897 as an error, not just -1. (Bug#10217)
4898
3a6ad4f0
CY
48992011-12-05 Chong Yidong <cyd@gnu.org>
4900
4901 * keyboard.c (process_special_events): New function.
4902 (swallow_events, Finput_pending_p): Use it (Bug#10195).
4903
75a3b399
PE
49042011-12-05 Paul Eggert <eggert@cs.ucla.edu>
4905
4906 * coding.c (encode_designation_at_bol): Don't use uninitialized
4907 local variable (Bug#9318).
4908
c3c9e25e
KH
49092011-12-05 Kenichi Handa <handa@m17n.org>
4910
4911 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
4912 return Qnil (Bug#8046, Bug#10193).
4913
5eb05ea3
KH
49142011-12-05 Kenichi Handa <handa@m17n.org>
4915
4916 * coding.c (encode_designation_at_bol): New args charbuf_end and
4917 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
4918 (coding_set_source): Return how many bytes coding->source was
4919 relocated.
4920 (coding_set_destination): Return how many bytes
4921 coding->destination was relocated.
4922 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 4923 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
4924
49252011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4926
4927 * coding.c (CODING_CHAR_CHARSET_P): New macro.
4928 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
4929 macro (Bug#9318).
4930
49312011-12-05 Andreas Schwab <schwab@linux-m68k.org>
4932
4933 The following changes are to fix Bug#9318.
4934
a79703f5 4935 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
4936 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
4937 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 4938 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 4939
7dbda6df
JB
49402011-12-05 Juanma Barranquero <lekktu@gmail.com>
4941
4942 * lisp.h (process_quit_flag): Fix external declaration.
4943
6d5eb5b0
SM
49442011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
4945
4946 Don't macro-inline non-performance-critical code.
4947 * eval.c (process_quit_flag): New function.
4948 * lisp.h (QUIT): Use it.
4949
a0c3fad0
JD
49502011-12-04 Jan Djärv <jan.h.d@swipnet.se>
4951
4952 * nsfns.m (get_geometry_from_preferences): New function.
4953 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
4954
6c07aac2
AS
49552011-12-04 Andreas Schwab <schwab@linux-m68k.org>
4956
4957 * emacs.c (Qkill_emacs): Define.
4958 (syms_of_emacs): Initialize it.
4959 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
4960 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
4961 (quit_throw_to_read_char): Add parameter `from_signal'.
4962 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
4963 * lisp.h (QUIT): Call Fkill_emacs if requested.
4964
c052ead4
JD
49652011-12-03 Jan Djärv <jan.h.d@swipnet.se>
4966
4967 * widget.c (update_wm_hints): Return if wmshell is null.
4968 (widget_update_wm_size_hints): New function.
4969
4970 * widget.h (widget_update_wm_size_hints): Declare.
4971
4972 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
4973 widget_update_wm_size_hints (Bug#10104).
4974
9e49252b
EZ
49752011-12-03 Eli Zaretskii <eliz@gnu.org>
4976
4977 * xdisp.c (handle_invisible_prop): If the invisible text ends just
4978 before a newline, prepare the bidi iterator for consuming the
4979 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 4980 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 4981
02b16839
JL
49822011-12-02 Juri Linkov <juri@jurta.org>
4983
4984 * search.c (Fword_search_regexp): New Lisp function created from
4985 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
4986 (Fword_search_backward, Fword_search_forward)
4987 (Fword_search_backward_lax, Fword_search_forward_lax):
4988 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
4989 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
4990
0068070e
SM
49912011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
4992
4993 * fileio.c (Finsert_file_contents): Move after-change-function call
4994 to before the "handled:" label, since all "goto handled" appear in
4995 cases where the *-change-functions have already been properly called
4996 (bug#10117).
4997
3360a3fc
AS
49982011-12-01 Andreas Schwab <schwab@linux-m68k.org>
4999
5000 * keyboard.c (interrupt_signal): Don't call kill-emacs when
5001 waiting for input. (Bug#10169)
5002
73d6c093
EZ
50032011-11-30 Eli Zaretskii <eliz@gnu.org>
5004
5005 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
5006 verifies glyph row's hash code--we have just reallocated the
5007 glyphs, so their contents can be complete garbage. (Bug#10164)
5008
febe6bea
JB
50092011-11-30 Juanma Barranquero <lekktu@gmail.com>
5010
5011 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
5012
801a4313
EZ
50132011-11-30 Eli Zaretskii <eliz@gnu.org>
5014
5015 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
5016 attributes are tested _before_ calling verify_row_hash, to protect
5017 against GCC re-ordering of the tests. (Bug#10164)
5018
2b56b87e
JD
50192011-11-29 Jan Djärv <jan.h.d@swipnet.se>
5020
5021 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
5022
5023 * xterm.c (handle_one_xevent): Only set async_visible and friends
5024 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 5025 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
5026 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
5027
dbf31225
PE
50282011-11-28 Paul Eggert <eggert@cs.ucla.edu>
5029
5030 Remove GCPRO-related macros that exist only to avoid shadowing locals.
5031 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
5032 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
5033 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5034 All uses changed to use GCPRO1 etc.
5035 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
5036 Revert to old implementation (i.e., before 2011-03-11).
5037
1305621b
YM
50382011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5039
5040 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
5041 of scroll runs so as to avoid assigning disabled bogus rows and
5042 unnecessary graphics copy operations.
5043
8c9afb46
EZ
50442011-11-27 Eli Zaretskii <eliz@gnu.org>
5045
5046 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
5047 (snprintf) [_MSC_VER]: Redirect to _snprintf.
5048 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
5049 (malloc, free, realloc, calloc): Redirect to e_* only when
5050 compiling Emacs.
5051
5052 * lisp.h (GCTYPEBITS): Move before first use.
5053 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
5054 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
5055 this macro definition.
5056
5057 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
5058 _MSC_VER.
5059
54e9e3bf
JD
50602011-11-27 Jan Djärv <jan.h.d@swipnet.se>
5061
6d5eb5b0
SM
5062 * gtkutil.c (xg_create_frame_widgets):
5063 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
5064 present with Gtk+ 2.0.
5065
83aca1cb
PE
50662011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5067
5068 * fileio.c (Finsert_file_contents): Undo previous change; see
5069 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5070
5b76caa4
PE
50712011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5072
5073 Rename locals to avoid shadowing.
5074 * fileio.c (Finsert_file_contents):
5075 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
5076 * process.c (wait_reading_process_output):
5077 Rename inner 'proc' to 'p' to avoid shadowing.
5078 Indent for consistency with usual Emacs style.
5079
8c535114
EZ
50802011-11-25 Eli Zaretskii <eliz@gnu.org>
5081
5082 * xdisp.c (redisplay_window): If cursor row is not fully visible
5083 after recentering, and scroll-conservatively is set to a large
5084 number, scroll window by a few more lines to make the cursor fully
5085 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
5086 (start_display): Don't move to the next line if the display should
5087 start at a newline that is part of a display vector or an overlay
5088 string. (Bug#10119)
8c535114 5089
fa4fdb5c
JL
50902011-11-24 Juri Linkov <juri@jurta.org>
5091
5092 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
5093 after the `MagickPingImage' call. (Bug#10112)
5094
90ec88df
CY
50952011-11-23 Chong Yidong <cyd@gnu.org>
5096
5097 * window.c (Fcoordinates_in_window_p): Accept only live windows.
5098
56e2e794
MR
50992011-11-23 Martin Rudalics <rudalics@gmx.at>
5100
5101 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
5102 making another buffer current. (Bug#10114)
5103
b6e64c41
GM
51042011-11-23 Glenn Morris <rgm@gnu.org>
5105
5106 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
5107
6b21de18
CY
51082011-11-23 Chong Yidong <cyd@gnu.org>
5109
5110 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
5111 using it (Bug#5984).
5112
b12cd789
EZ
51132011-11-22 Eli Zaretskii <eliz@gnu.org>
5114
5115 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
5116 and header-lines, as they don't have one computed for them.
5117 (Bug#10098)
5118
5119 * .gdbinit (prow): Make displayed values more self-explaining.
5120 Add row's hash code.
5121
261b6fd4
LMI
51222011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
5123
5124 * process.c (wait_reading_process_output): Fix asynchrounous
5125 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 5126 (wait_reading_process_output): Add comment and URL.
261b6fd4 5127
e7cfd277
JD
51282011-11-21 Jan Djärv <jan.h.d@swipnet.se>
5129
5130 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
5131
a9b9b7f5
CY
51322011-11-21 Chong Yidong <cyd@gnu.org>
5133
5134 * window.c (Fnext_window, Fprevious_window): Doc fix.
5135
b0d15b4f
SM
51362011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5137
5138 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
5139
fe7a3057
JB
51402011-11-20 Juanma Barranquero <lekktu@gmail.com>
5141
5142 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
5143
d2999b1a
MR
51442011-11-20 Martin Rudalics <rudalics@gmx.at>
5145
5146 * window.c (Fset_window_combination_limit): Rename argument
5147 STATUS to LIMIT.
5148 (Vwindow_combination_limit): Remove "status" from doc-string.
5149
d5ff9cd0
AS
51502011-11-20 Andreas Schwab <schwab@linux-m68k.org>
5151
5152 * m/ibms390.h: Remove.
5153 * m/ibms390x.h: Don't include "ibms390.h".
5154
a5bb9bd3
SM
51552011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5156
5157 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
5158 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
5159
cd1181db
JB
51602011-11-20 Juanma Barranquero <lekktu@gmail.com>
5161
5162 * casetab.c (Fset_case_table):
5163 * charset.c (Fcharset_after): Fix typos.
5164
615a3b8d 51652011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 5166
17e845af
PE
5167 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
5168 Otherwise, valgrind does not work on some platforms.
5169 Problem reported by Andreas Schwab in
6a0bf43d
PE
5170 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
5171 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
5172 is set, removing the need for VIRT_ADDRESS_VARIES.
5173 (PURE_P): Use a more-efficient implementation that needs just one
5174 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
5175 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
5176 to 4 (xorl, subq, cmpq, setbe).
5177 * alloc.c (pure): Always extern now, since that's the
5178 VIRT_ADDR_VARIES behavior.
5179 (PURE_POINTER_P): Use a single comparison, not two, for
5180 consistency with the new puresize.h.
5181 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
5182 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
5183 Remove VIRT_ADDR_VARIES no longer needed.
5184
f8fe6f96
EZ
51852011-11-19 Eli Zaretskii <eliz@gnu.org>
5186
5187 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
5188 (erase_phys_cursor, update_window_cursor, show_mouse_face)
5189 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
5190 behave as if the cursor position were at the window margin.
5191
5192 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
5193 and the cursor position is out of bounds, behave as if the cursor
5194 position were at the window margin. (Bug#10075)
5195
df05a53c
CY
51962011-11-18 Chong Yidong <cyd@gnu.org>
5197
5198 * window.c (Fwindow_combination_limit): Make first argument
5199 non-optional, since it is meaningless for live windows like the
5200 selected window.
61ccba97 5201
2071918e
DA
52022011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
5203
5204 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
5205
b50a28de
SM
52062011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
5207
5208 * intervals.c: Fix grafting over the whole buffer (bug#10071).
5209 (graft_intervals_into_buffer): Simplify.
5210
015137db
EZ
52112011-11-18 Eli Zaretskii <eliz@gnu.org>
5212
5213 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
5214 hash values of the two rows.
5215 (copy_row_except_pointers): Preserve the used[] arrays and the
5216 hash values of the two rows. (Bug#10035)
68c95424 5217 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
5218
5219 * xdisp.c (row_hash): New function, body extracted from
5220 compute_line_metrics.
5221 (compute_line_metrics): Call row_hash, instead of computing the
5222 hash code inline.
5223
5224 * dispnew.c (verify_row_hash): Call row_hash for computing the
5225 hash code of a row, instead of duplicating code from xdisp.c.
5226
5227 * dispextern.h (row_hash): Add prototype.
5228
a2addb04
TH
52292011-11-18 Tassilo Horn <tassilo@member.fsf.org>
5230
5231 * frame.c (delete_frame): Don't delete the terminal when the last
5232 X frame is closed if emacs is built with GTK toolkit.
5233
df85d315
JB
52342011-11-17 Juanma Barranquero <lekktu@gmail.com>
5235
5236 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
5237
a0c2d0ae
MR
52382011-11-17 Martin Rudalics <rudalics@gmx.at>
5239
5240 * window.c (Vwindow_splits): Rename to
5241 Vwindow_combination_resize. Suggested by Juri Linkov.
5242 (Fsplit_window_internal): Use Vwindow_combination_resize instead
5243 of Vwindow_splits.
5244
58179cce
JB
52452011-11-16 Juanma Barranquero <lekktu@gmail.com>
5246
7877f373
JB
5247 * nsfns.m (Fns_font_name):
5248 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 5249
b6f67890
MR
52502011-11-16 Martin Rudalics <rudalics@gmx.at>
5251
5252 * window.h (window): Rename slot "nest" to "combination_limit".
5253 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
5254 (Fset_window_nest): Rename to Fset_window_combination_limit.
5255 (Vwindow_nest): Rename to Vwindow_combination_limit.
5256 (recombine_windows, make_parent_window, make_window)
5257 (Fsplit_window_internal, saved_window)
5258 (Fset_window_configuration, save_window_save): Rename all
5259 occurrences of window_nest to window_combination_limit.
5260
c7015153
JB
52612011-11-15 Juanma Barranquero <lekktu@gmail.com>
5262
5263 * image.c (imagemagick_load_image): Fix typo.
5264
322ad6ec
EZ
52652011-11-14 Eli Zaretskii <eliz@gnu.org>
5266
5267 * xdisp.c (display_line): Move the call to
5268 highlight_trailing_whitespace before the call to
5269 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
5270 faces of all the glyphs to compute ROW's hash value.
5271 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 5272
f067b8ec
JB
52732011-11-14 Juanma Barranquero <lekktu@gmail.com>
5274
5275 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
5276 just return (bug#10044).
5277
1e5b2111
EZ
52782011-11-12 Eli Zaretskii <eliz@gnu.org>
5279
7ef3cbd5
EZ
5280 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
5281 with user-defined heap size. Bump the default size of the temacs
5282 heap to 27MB, to avoid memory warning when running temacs.
5283 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
5284
1e5b2111
EZ
5285 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
5286 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
5287 (verify_row_hash) [XASSERTS]: New function.
5288 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
5289 that the hash value of glyph rows is correct.
1e5b2111 5290
89d61221
MR
52912011-11-12 Martin Rudalics <rudalics@gmx.at>
5292
5293 * window.h (window): Remove splits slot.
5294 * window.c (Fwindow_splits, Fset_window_splits): Remove.
5295 (Fdelete_other_windows_internal, make_parent_window)
5296 (make_window, Fsplit_window_internal, Fdelete_window_internal)
5297 (Fset_window_configuration, save_window_save): Don't deal with
5298 split status of windows.
5299 (saved_window): Remove splits slot.
5300 (Vwindow_splits): Rewrite doc-string.
5301
97f18cc8
JD
53022011-11-11 Jan Djärv <jan.h.d@swipnet.se>
5303
5304 * xfns.c (unwind_create_frame):
5305 * nsfns.m (unwind_create_frame):
5306 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
5307 Vframe_list (Bug#9999).
5308
22a648b4
DA
53092011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
5310
0b381c7e 5311 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 5312
659afede
KH
53132011-11-11 Kenichi Handa <handa@m17n.org>
5314
5315 * callproc.c (Fcall_process): Set the member dst_multibyte of
5316 process_coding.
5317
9ac0394b
KH
53182011-11-11 Johan Bockgård <bojohan@gnu.org>
5319
5320 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
5321 avoid a crash (bug#9496).
5322
2fbdc249
CY
53232011-11-09 Chong Yidong <cyd@gnu.org>
5324
5325 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
5326 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
5327
ac6b1f81
PE
53282011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5329
5330 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
5331
09db192c
PE
53322011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5333
5334 Avoid some portability problems by eschewing 'extern inline' functions.
5335 The trivial performance wins aren't worth the portability hassles; see
5336 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
5337 et seq.
5338 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5339 (window_box_width, window_box_left, window_box_left_offset)
5340 (window_box_right, window_box_right_offset): Undo previous change,
5341 by removing the "extern"s.
5342 * intervals.c (adjust_intervals_for_insertion)
5343 (adjust_intervals_for_deletion): Undo previous change,
5344 making these static again.
5345 (offset_intervals, temp_set_point_both, temp_set_point)
5346 (copy_intervals_to_string): No longer inline.
5347 * xdisp.c (window_text_bottom_y, window_box_width)
5348 (window_box_height, window_box_left_offset)
5349 (window_box_right_offset, window_box_left, window_box_right)
5350 (window_box): No longer inline.
5351
105216ed
CY
53522011-11-08 Chong Yidong <cyd@gnu.org>
5353
5354 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
5355 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
5356 Signal an error if not a live window.
105216ed
CY
5357 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
5358 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
5359
ae9e237f
JB
53602011-11-07 Juanma Barranquero <lekktu@gmail.com>
5361
5362 * lisp.h (syms_of_abbrev): Remove declaration.
5363 Reported by CHENG Gao <chenggao@royau.me>.
5364
c7aa8333
EZ
53652011-11-07 Eli Zaretskii <eliz@gnu.org>
5366
5367 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
5368 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
5369 of temacs in GUI mode.
5370
be7f5545
MR
53712011-11-07 Martin Rudalics <rudalics@gmx.at>
5372
5373 * window.h: Declare delete_all_child_windows instead of
5374 delete_all_subwindows.
5375 * window.c (Fwindow_nest, Fset_window_nest)
5376 (Fset_window_new_total, Fset_window_new_normal)
5377 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
5378 (delete_all_subwindows): Rename to delete_all_child_windows.
5379 (Fdelete_other_windows_internal, Fset_window_configuration):
5380 Call delete_all_child_windows instead of delete_all_subwindows.
5381 * frame.c (delete_frame): Call delete_all_child_windows instead
5382 of delete_all_subwindows.
5383
ca78dc43
PE
53842011-11-07 Paul Eggert <eggert@cs.ucla.edu>
5385
5386 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
5387 This is also needed for porting to any host where GC_MARK_STACK is
5388 not GC_MAKE_GCPROS_NOOPS.
5389 (which_symbols): Use it.
5390
a0241d01
KH
53912011-11-07 Kenichi Handa <handa@m17n.org>
5392
5393 * coding.c (coding_set_destination): Check coding->src_pos only
5394 when coding->src_object is a buffer (bug#9910).
5395
5396 * process.c (send_process): Set the member src_multibyte of coding
5397 to 0 (bug#9911) when sending a unibyte text.
5398
5399 * callproc.c (Fcall_process): Set the member src_multibyte of
5400 process_coding to 0 (bug#9912).
5401
a64bfdfa 54022011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
5403
5404 * xmenu.c (cleanup_widget_value_tree): New function.
5405 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
5406 calling free_menubar_widget_value_tree directly (Bug#9830).
5407
cb41b32a
PE
54082011-11-06 Paul Eggert <eggert@cs.ucla.edu>
5409
5410 Fix some portability problems with 'inline'.
5411 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5412 (window_box_width, window_box_left, window_box_left_offset)
5413 (window_box_right, window_box_right_offset): Declare extern.
5414 Otherwise, these inline functions do not conform to C99 and
5415 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
5416 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
5417 * intervals.c (adjust_intervals_for_insertion)
5418 (adjust_intervals_for_deletion): Now extern, because otherwise the
5419 extern inline functions 'offset_intervals' couldn't refer to it.
5420 (static_offset_intervals): Remove.
5421 (offset_intervals): Rewrite using the old contents of
5422 static_offset_intervals. The old version didn't conform to C99
5423 because an extern inline function contained a reference to an
5424 identifier with static linkage.
5425
b7041366
AS
54262011-11-06 Andreas Schwab <schwab@linux-m68k.org>
5427
5428 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
5429 GC.
5430
88a37c4d
EZ
54312011-11-06 Eli Zaretskii <eliz@gnu.org>
5432
5433 * xdisp.c (init_iterator, reseat_to_string): Don't set the
5434 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
5435 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
5436 return Qleft_to_right.
5437
49745b39
CY
54382011-11-06 Chong Yidong <cyd@gnu.org>
5439
5440 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
5441 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
5442 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
5443 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
5444 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
5445 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
5446 (Fwindow_vscroll): Doc fix.
5447 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
5448 argument, since it makes no sense to pass a live window and for
5449 consistency with window-child.
5450
1f05cd82
CS
54512011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
5452
5453 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
5454 support MSVC.
5455
22610910
JR
54562011-11-05 Jason Rumney <jasonr@gnu.org>
5457
5458 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
5459 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
5460 fonts (Bug#6029).
5461 (add_font_entity_to_list): Fix logic errors in mixed boolean and
5462 bitwise arithmetic preventing use of unicode-sip and non-truetype
5463 opentype fonts.
5464
a06776b2
EZ
54652011-11-05 Eli Zaretskii <eliz@gnu.org>
5466
3ad924ba
EZ
5467 * s/ms-w32.h (fstat, stat, utime): Move redirections to
5468 "emacs"-only part.
5469
a06776b2
EZ
5470 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
5471 initialization code to keep similarity to xfns.c after changes
5472 from 2011-11-05.
5473
c9e7db78
JD
54742011-11-05 Jan Djärv <jan.h.d@swipnet.se>
5475
a97f8f3f
JD
5476 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
5477 (unwind_create_frame): New function (Bug#9943).
5478 (Fx_create_frame): Restructure code to be more similar to the one in
5479 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
5480 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
5481 Move terminal->reference_count++ just before making the frame official
5482 (Bug#9943).
5483
5484 * nsterm.m (x_free_frame_resources): New function.
5485 (x_destroy_window): Move code to x_free_frame_resources.
5486
c9e7db78 5487 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
5488 (Fx_create_frame, x_create_tip_frame):
5489 Move terminal->reference_count++ just before making the frame
75f1671a 5490 official. Move initialization of image_cache_refcount and
c9e7db78
JD
5491 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
5492
a6fc3b5c
EZ
54932011-11-05 Eli Zaretskii <eliz@gnu.org>
5494
5495 Support MSVC build with newer versions of Visual Studio.
5496 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
5497 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
5498 nt/gmake.defs.
5499
5500 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
5501 which are not supported by MSVC.
5502 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
5503 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
5504 bitfields.
5505 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
5506 types in bitfields.
5507 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
5508
5509 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
5510
58179cce 55112011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
5512
5513 Support MSVC build with newer versions of Visual Studio.
5514 * w32.c: Don't include w32api.h for MSVC.
5515 (init_environment) [_MSC_VER]: Call sys_access, not _access.
5516
5517 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
5518 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
5519 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
5520 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
5521 e_* cousins.
5522 (alloca) [_MSC_VER]: Define to _alloca.
5523
5524 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
5525
5526 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
5527
a58c13ed
EZ
55282011-11-04 Eli Zaretskii <eliz@gnu.org>
5529
5530 * xdisp.c (note_mouse_highlight): If either of
5531 previous/next-single-property-change returns nil, treat that as
5532 the beginning or the end of the buffer. (Bug#9955)
5533
fe0b6370
JD
55342011-11-04 Jan Djärv <jan.h.d@swipnet.se>
5535
a58c13ed 5536 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
5537 label is not null (Bug#9951).
5538 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
5539 may be NULL.
5540
89bd5ee1
EZ
55412011-11-04 Eli Zaretskii <eliz@gnu.org>
5542
5543 * window.c (Fwindow_body_size): Mention in the doc string that the
5544 return value is in frame's canonical units. (Bug#9949)
5545
84c3edb9
EZ
55462011-11-03 Eli Zaretskii <eliz@gnu.org>
5547
4e2fb5c7
EZ
5548 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
5549
84c3edb9 5550 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 5551 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 5552 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 5553
bc17a887
EZ
55542011-11-01 Eli Zaretskii <eliz@gnu.org>
5555
5556 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
5557 Don't stop backward scan on the continuation glyph, even though
5558 its CHARPOS is positive.
6d5eb5b0
SM
5559 (mouse_face_from_buffer_pos, note_mouse_highlight):
5560 Rename cover_string to disp_string.
bc17a887 5561
4ee88440
MR
55622011-11-01 Martin Rudalics <rudalics@gmx.at>
5563
5564 * window.c (temp_output_buffer_show): Don't use
5565 Vtemp_buffer_show_specifiers.
5566 (Vtemp_buffer_show_specifiers): Remove unused variable.
5567
c2ff3c02
EZ
55682011-10-30 Eli Zaretskii <eliz@gnu.org>
5569
5570 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
5571 past the beginning of the current glyph matrix.
5572
58179cce 55732011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
5574
5575 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
5576 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
5577 HAVE_GTK3 (Bug#9869).
b77a6a7f 5578
3b574623
JD
5579 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
5580 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
5581
b77a6a7f
JD
5582 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
5583
5584 * xterm.c: Declare x_handle_net_wm_state to return int.
5585 (handle_one_xevent): Check if we are iconified but don't have
5586 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
5587 (get_current_wm_state): Return non-zero if not hidden,
5588 check for _NET_WM_STATE_HIDDEN (Bug#9893).
5589 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
5590 (x_handle_net_wm_state): Return what get_current_wm_state returns.
5591 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
5592
196e41e4
PE
55932011-10-29 Paul Eggert <eggert@cs.ucla.edu>
5594
5595 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
5596 so that this new function doesn't get optimized away by a
5597 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
5598
021f2e1a
AS
55992011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5600
5601 * frame.h (MOUSE_HL_INFO): Remove excess parens.
5602
8b058d44
EZ
56032011-10-29 Eli Zaretskii <eliz@gnu.org>
5604
5605 Fix the `xbytecode' command.
5606 * .gdbinit (xprintbytestr): New command.
b50a28de 5607 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
5608 (xbytecode): Print the byte-code string as well.
5609
4452fb80
EZ
56102011-10-29 Kim Storm <storm@cua.dk>
5611
8b058d44
EZ
5612 * alloc.c (which_symbols): New function.
5613
21b72067
AS
56142011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5615
5616 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
5617 line. (Bug#9903)
5618
83ed7b5c
GM
56192011-10-29 Glenn Morris <rgm@gnu.org>
5620
5621 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
5622 Not clear what it was for, and it causes various bugs. (Bug#9839)
5623
5a7a728b
EZ
56242011-10-28 Eli Zaretskii <eliz@gnu.org>
5625
5626 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
5627 possible random value that matches one of those tested as
5628 condition to clear the mouse face.
5629
d3d0842f
CY
56302011-10-28 Chong Yidong <cyd@gnu.org>
5631
5632 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
5633
31b39d13
DN
56342011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
5635
5636 * window.c (make_window): Initialize phys_cursor_on_p.
5637
9aba6043
SM
56382011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
5639
5640 * lisp.h (struct Lisp_Symbol): Update comments.
5641
c20992f4
JB
56422011-10-28 Juanma Barranquero <lekktu@gmail.com>
5643
5644 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
5645
db4f02f2
EZ
56462011-10-28 Eli Zaretskii <eliz@gnu.org>
5647
5648 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
5649 <oslsachem@gmail.com> for helping to debug this.
5650
5651 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
5652 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
5653 (g_b_init_get_glyph_outline_w): New static variables.
5654 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
5655 (GetGlyphOutlineW_Proc): New typedefs.
5656 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
5657 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
5658 New functions.
5659 (w32font_open_internal, compute_metrics):
5660 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
5661 instead of calling the "wide" APIs directly.
5662
5663 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
5664
5665 * w32.h (syms_of_w32font): Add prototype.
5666
87e68db4
JB
56672011-10-27 Juanma Barranquero <lekktu@gmail.com>
5668
5669 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
5670 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
5671 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
5672 (Fmove_to_window_line): Doc fix.
5673
435c1d67
CY
56742011-10-27 Chong Yidong <cyd@gnu.org>
5675
5676 * process.c (make_process): Set gnutls_state to NULL.
5677
5678 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
5679 non-NULL, regardless of GNUTLS_INITSTAGE.
5680 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
5681 an error. Set process slots as soon as we allocate them.
5682
5683 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
5684
9c6c6f49
CY
56852011-10-27 Chong Yidong <cyd@gnu.org>
5686
9aba6043
SM
5687 * gnutls.c (emacs_gnutls_deinit): New function.
5688 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
5689 (Fgnutls_deinit, Fgnutls_boot): Use it.
5690
5691 * process.c (make_process): Initialize GnuTLS credentials to NULL.
5692 (deactivate_process): Call emacs_gnutls_deinit.
5693
657d08d3
JB
56942011-10-27 Juanma Barranquero <lekktu@gmail.com>
5695
5696 * image.c (x_create_x_image_and_pixmap):
5697 * w32.c (sys_rename, w32_delayed_load):
5698 * w32font.c (fill_in_logfont):
5699 * w32reg.c (x_get_string_resource): Silence compiler warnings.
5700
5430d399
JB
57012011-10-26 Juanma Barranquero <lekktu@gmail.com>
5702
5703 * w32fns.c (w32_default_color_map): New function,
5704 extracted from Fw32_default_color_map.
a7ef684b 5705 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 5706
fe0055fa
PE
57072011-10-25 Paul Eggert <eggert@cs.ucla.edu>
5708
5709 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
5710
e6346438
SM
57112011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
5712
5713 * keyboard.c (test_undefined): New function (bug#9751).
5714 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
5715
e112cc37
ET
57162011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
5717
5718 * sysdep.c (init_sys_modes): Fix the check for the controlling
5719 terminal (Bug#6649).
5720
7b5d6677
EZ
57212011-10-20 Eli Zaretskii <eliz@gnu.org>
5722
5723 * dispextern.h (struct bidi_it): New member next_en_type.
5724
5725 * bidi.c (bidi_line_init): Initialize the next_en_type member.
5726 (bidi_resolve_explicit_1): When next_en_pos is valid for the
5727 current character, check also for next_en_type being WEAK_EN.
5728 (bidi_resolve_weak): Don't enter the expensive loop if the current
5729 position is before next_en_pos. Record the bidi type of the first
5730 non-ET, non-BN character we find, in addition to its position.
5731 (bidi_level_of_next_char): Invalidate next_en_type when
5732 next_en_pos is over-stepped.
5733
7da0b018
PE
57342011-10-20 Paul Eggert <eggert@cs.ucla.edu>
5735
5736 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
5737 * editfns.c: Rewrite current-time-zone so that it invokes
5738 the equivalent of (format-time-string "%Z") to get the time zone name.
5739 This fixes a bug when the time zone name contains characters that
5740 need converting from the system time locale to Emacs internal format.
5741 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
5742 that patch fixed format-time-string to do the conversion, but
5743 I forgot to fix current-time-zone.
5744 (format_time_string): New function, containing most of
5745 what Fformat_time_string used to contain.
5746 (Fformat_time_string): Rewrite in terms of format_time_string.
5747 This doesn't change this function's behavior.
5748 (current-time-zone): Rewrite to use format_time_string.
5749 This fixes the bug reported by Michael Schierl in
5750 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
5751 Jason Rumney's 2007-06-07 change worked around this bug, but
5752 didn't fix it.
5753 * systime.h (tzname, timezone): Remove no-longer-used declarations.
5754
8547b010
EZ
57552011-10-19 Eli Zaretskii <eliz@gnu.org>
5756
5757 * xdisp.c (start_display): If the character at POS is displayed
5758 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
5759 (try_window_reusing_current_matrix): If a line ends in a display
5760 vector or the next line starts in a display vector, continue
5761 redrawing the window even though the character position of
5762 start_row was reached.
8547b010
EZ
5763 (Bug#9771, part 2)
5764
4e948d15
CY
57652011-10-18 Chong Yidong <cyd@gnu.org>
5766
5767 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
5768 with nobreak-char-display too.
5769
4787455f
EZ
57702011-10-18 Eli Zaretskii <eliz@gnu.org>
5771
5772 Fix part 3 of bug#9771.
5773 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
5774 (bidi_resolve_neutral): Don't enter the expensive loop looking for
5775 non-neutral characters if the current character is a paragraph
5776 separator (a.k.a. Newline). This avoids running the same
5777 expensive loop twice, once when we consume the preceding newline
5778 and the other time when the line actually needs to be displayed.
5779 Avoid the loop when we see neutrals on the base embedding level
5780 following a character whose directionality is the same as the
5781 paragraph's. This avoids running the expensive loop when a line
5782 ends in a long sequence of neutrals, like control characters.
5783 Add assertion against STRONG_AL type. Slightly rearrange code
5784 that determines the type of a neutral given the first non-neutral
5785 that follows it.
5786 (bidi_level_of_next_char): Set next_en_pos to zero when
5787 invalidating its info.
5788
2c91f553
EZ
57892011-10-17 Eli Zaretskii <eliz@gnu.org>
5790
5791 * xdisp.c (push_display_prop): Determine whether to record string
5792 or buffer position by IT->string, not by IT->method. Allow
5793 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
5794 (move_it_vertically_backward): Don't look for character position
5795 immediately after the newline when in a continuation line.
5796 (Bug#9771, part 1)
2c91f553 5797
c7b08b0d
MR
57982011-10-15 Martin Rudalics <rudalics@gmx.at>
5799
5800 * window.c (coordinates_in_window): Rewrite and delabelize
5801 vertical border check. (Bug#5357) (Bug#9618)
5802
6b02f655
SM
58032011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
5804
5805 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
5806 errors in XSetWindowBorder (bug#9310).
5807
81d40c92
DA
58082011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
5809
5810 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
5811 avoid crash when xmalloc overrun checking is enabled.
5812
d4172c3b
EZ
58132011-10-13 Eli Zaretskii <eliz@gnu.org>
5814
5815 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
5816 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
5817 cursor motion with <left> and <right> arrow keys.
5818
5819 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
5820 some callers set that themselves.
5821
b00eea75
EZ
58222011-10-12 Eli Zaretskii <eliz@gnu.org>
5823
5824 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
5825 display string and the previous row comes from the same string and
5826 is empty. (Bug#9739) (Bug#9738)
5827
8fe012c4
SM
58282011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
5829
5830 * doc.c (get_doc_string): Encode file name (bug#9735).
5831
0074aef2
EZ
58322011-10-12 Eli Zaretskii <eliz@gnu.org>
5833
79beb178
EZ
5834 * bidi.c (bidi_level_of_next_char):
5835 * xdisp.c (get_visually_first_element): Remove old incorrect
5836 comments regarding the Unicode Line Separator character.
5837
0074aef2
EZ
5838 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
5839
6e4b3fbe
DA
58402011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
5841
5842 * alloc.c (Fgc_status): Do not access beyond zombies array
5843 boundary if nzombies > MAX_ZOMBIES.
5844 * alloc.c (dump_zombies): Add missing format specifier.
5845
0324f3af
PE
58462011-10-12 Paul Eggert <eggert@cs.ucla.edu>
5847
b5525cac
PE
5848 * xdisp.c (set_cursor_from_row): Simplify conditionals,
5849 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
5850
0324f3af
PE
5851 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
5852 Some packages use them to denote characters with modifiers.
5853
e9b5f888
AS
58542011-10-11 Andreas Schwab <schwab@linux-m68k.org>
5855
5856 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
5857 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
5858 matching a pp-number. Rename parameter var to var1.
5859
127827c0
SM
58602011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
5861
5862 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
5863
c8fd3bd0
GM
58642011-10-08 Glenn Morris <rgm@gnu.org>
5865
5866 * callint.c (Fcall_interactively): Give a more explicit error for the
5867 'c' case with a non-character input. (Bug#8479)
5868
352ec8ff
EZ
58692011-10-08 Eli Zaretskii <eliz@gnu.org>
5870
03669ccb
EZ
5871 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
5872 lines.
7061c986
EZ
5873 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
5874 lines that are hscrolled on the left.
03669ccb 5875
352ec8ff
EZ
5876 * dispnew.c (buffer_posn_from_coords): Account for a possible
5877 presence of header-line. (Bug#4426)
5878
a66cfb1c
SM
58792011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
5880
6b02f655
SM
5881 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
5882 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 5883
7c5ee88e
PE
58842011-10-07 Paul Eggert <eggert@cs.ucla.edu>
5885
5886 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
5887 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
5888 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
5889 this makes Emacs dump core during garbage collection on rare
5890 occasions. sizeof is obviously inferior to offsetof here, so
5891 stick with offsetof.
5892 (GC_POINTER_ALIGNMENT): New macro.
5893 (mark_memory): Omit 3rd (offset) arg; caller changed.
5894 Don't assume EMACS_INT alignment is the same as pointer alignment.
5895
df1bbe5b
SM
58962011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
5897
5898 * keyboard.c (read_key_sequence_remapped): New var.
5899 (read_key_sequence): Compute remapping in the right buffer.
5900 (command_loop_1): Use read_key_sequence's remapping directly.
5901
51553db6
SM
59022011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
5903
32c1fffd
SM
5904 * dired.c (file_name_completion): Don't expand file name.
5905 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
5906 before checking file name handler.
5907
51553db6
SM
5908 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
5909 they've been requested explicitly (bug#9591).
5910
b6bd1599 59112011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
5912
5913 * keymap.c (Fsingle_key_description): Use make_specified_string
5914 instead of build_string to build string from push_key_description.
5915 (Bug#5193)
5916
f701dc2a
PE
59172011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5918
4222c55d
PE
5919 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
5920 This fixes a Y2038 bug on 64-bit hosts.
5921 * buffer.c (reset_buffer):
5922 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
5923 (Fclear_buffer_auto_save_failure):
5924 Use 0, not -1, to represent an unset failure time, since time_t
5925 might not be signed.
5926
f701dc2a
PE
5927 Remove dependency on glibc malloc internals.
5928 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5929 Move back here from lisp.h, but with their new implementations.
5930 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5931 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
5932 * charset.c (charset_table_init): New static var.
5933 (syms_of_charset): Use it instead of xmalloc. This removes a
5934 dependency on glibc malloc internals. See Eli Zaretskii's comment in
5935 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
5936 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5937 Move back to alloc.c.
5938 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5939 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
5940
9ceebf39
JD
59412011-09-30 Jan Djärv <jan.h.d@swipnet.se>
5942
5943 * nsterm.m (windowDidResize): Call x_set_window_size only when
5944 ns_in_resize is true. Otherwise set pixelwidth/height and
5945 call change_frame_size (Bug#9628).
5946
cb993c58
PE
59472011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5948
3930c88b
PE
5949 Port --enable-checking=all to Fedora 14 x86-64.
5950 * charset.c (syms_of_charset): Also account for glibc malloc's
5951 internal overhead when calculating the initial malloc maximum.
5952
cb993c58
PE
5953 Port --enable-checking=all to Fedora 14 x86.
5954 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5955 Move to lisp.h.
5956 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
5957 (overrun_check_realloc, overrun_check_free):
5958 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
5959 That way, xmalloc returns a properly-aligned pointer even if
5960 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
5961 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
5962 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
5963 into account when calculating the initial malloc maximum.
5964 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5965 Move here from alloc.c, so that charset.c can use it too.
5966 Properly align; the old code wasn't right for common 32-bit hosts
5967 when configured with --enable-checking=all.
5968 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5969 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
5970
31bed486
EZ
59712011-09-29 Eli Zaretskii <eliz@gnu.org>
5972
04c70788 5973 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
5974 use EDOM.
5975
fbcaa2f3
EZ
59762011-09-28 Eli Zaretskii <eliz@gnu.org>
5977
5978 * xdisp.c (compute_display_string_end): If there's no display
5979 string at CHARPOS, return -1.
5980
5981 * bidi.c (bidi_fetch_char): When compute_display_string_end
5982 returns a negative value, treat the character as a normal
5983 character not covered by a display string. (Bug#9624)
5984
a239d4e9
JB
59852011-09-28 Juanma Barranquero <lekktu@gmail.com>
5986
5987 * lread.c (Fread_from_string): Fix typo in docstring.
5988
88652fd5
EZ
59892011-09-27 Eli Zaretskii <eliz@gnu.org>
5990
5991 * xdisp.c (handle_invisible_prop): If invisible text ends on a
5992 newline, reseat the iterator instead of bidi-iterating there one
5993 character at a time. (Bug#9610)
32c1fffd
SM
5994 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
5995 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 5996
ed497dd4
AS
59972011-09-27 Andreas Schwab <schwab@linux-m68k.org>
5998
5999 * lread.c (readevalloop): Use correct code for NBSP.
6000 (read1): Likewise. (Bug#9608)
6001
b2bf61aa
MA
60022011-09-25 Michael Albinus <michael.albinus@gmx.de>
6003
6004 * dbusbind.c (Fdbus_register_signal): When service is not
6005 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
6006
32bbb17c
GM
60072011-09-25 Glenn Morris <rgm@gnu.org>
6008
6009 * buffer.c (truncate-lines): Doc fix.
6010
94e0933e
CY
60112011-09-24 Chong Yidong <cyd@stupidchicken.com>
6012
6013 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
6014 (Fset_window_next_buffers): Doc fix.
6015
cddde921
GM
60162011-09-24 Glenn Morris <rgm@gnu.org>
6017
6018 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
6019
1260aef1
PE
60202011-09-24 Paul Eggert <eggert@cs.ucla.edu>
6021
25b4bfa0
PE
6022 Fix minor problems found by static checking.
6023 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
6024 * indent.c (Fvertical_motion): Fix == vs = typo.
6025
e3cbd34b
EZ
60262011-09-24 Eli Zaretskii <eliz@gnu.org>
6027
a66cfb1c
SM
6028 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
6029 Default value is now t. Doc fix.
6bf7006f 6030
e3cbd34b 6031 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 6032 logic when moving up, not only when moving down. Fix the
e3cbd34b 6033 confusing name and values of the it_overshoot_expected variable;
32c1fffd 6034 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
6035
6036 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
6037 CHARPOS is covered by a display string which includes newlines.
6038 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
6039 is covered by a display string with embedded newlines.
6040
a3de0cbd
MA
60412011-09-24 Michael Albinus <michael.albinus@gmx.de>
6042
6043 * dbusbind.c (Fdbus_register_signal): Add match rule to
6044 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
6045 (Fdbus_register_method, Vdbus_registered_objects_table):
6046 Fix docstring.
a3de0cbd 6047
b260039d
JM
60482011-09-24 Jim Meyering <meyering@redhat.com>
6049
32c1fffd 6050 do not ignore write error for any output size
b260039d
JM
6051 The previous change was incomplete.
6052 While it makes emacs --batch detect the vast majority of stdout
6053 write failures, errors were still ignored whenever the output size is
6054 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
6055 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
6056 && echo FAIL: ignored write error
6057 FAIL: ignored write error
6058 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
6059 && echo FAIL: ignored write error
6060 FAIL: ignored write error
6061 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
6062
8eca8a7c
AS
60632011-09-23 Andreas Schwab <schwab@linux-m68k.org>
6064
6065 * emacs.c (Fkill_emacs): In noninteractive mode exit
6066 non-successfully if a write error occurred on stdout. (Bug#9574)
6067
3341db62
EZ
60682011-09-21 Eli Zaretskii <eliz@gnu.org>
6069
6070 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
6071 the xassert test.
6072
6073 * dispextern.h (struct it): Update the comment documenting what
6074 can it->OBJECT be.
6075
8c203dbf
EZ
60762011-09-20 Eli Zaretskii <eliz@gnu.org>
6077
6078 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
6079 a display string, extend search for cursor position to end of row.
6080 (find_row_edges): If the row ends in a newline from a display
6081 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
6082 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
6083 (Fcurrent_bidi_paragraph_direction): Fix search for previous
6084 non-empty line. Fixes confusing cursor motion with arrow keys at
6085 the beginning of a line that starts with whitespace.
8c203dbf 6086
a4824228
LMI
60872011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6088
6089 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
6090 (bug#9493).
6091
33ed493b
CY
60922011-09-18 Chong Yidong <cyd@stupidchicken.com>
6093
6094 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
6095 boolean (Bug#9154).
6096
56cd55c8
EZ
60972011-09-18 Eli Zaretskii <eliz@gnu.org>
6098
6099 * xdisp.c (display_line): Record maximum and minimum buffer
6100 positions even if no glyphs were produced (e.g., by a zero-width
6101 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
6102 buffer positions that will be removed from the glyph row because
6103 they don't fit.
c02dcedf
EZ
6104 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
6105 column is beyond frame width: don't subtract 1 "pixel" when
6106 computing width of the stretch.
3e62b7e0
EZ
6107 (reseat_at_next_visible_line_start): Undo the change made on
6108 2011-09-17 that saved paragraph information and restored it after
6109 the call to `reseat'. (Bug#9545)
56cd55c8 6110
5ed99d36 61112011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
6112
6113 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
6114 and turn window cursor on if cleared (Bug#9415).
6115
5ed99d36 61162011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
6117
6118 * search.c (boyer_moore): Take unibyte characters from pattern
6119 literally. (Bug#9458)
6120
9bade7b2
EZ
61212011-09-18 Eli Zaretskii <eliz@gnu.org>
6122
6123 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
6124
e5e9d610
PE
61252011-09-18 Paul Eggert <eggert@cs.ucla.edu>
6126
87e4427a
PE
6127 Fix minor problem found by static checking.
6128 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
6129 initialized, to pacify gcc -Wuninitialized.
6130
e5e9d610
PE
6131 * fileio.c: Report proper errno when syscall falls.
6132 (Finsert_file_contents): Save and restore errno,
6133 so that report_file_error outputs the correct diagnostic.
6134 (Fwrite_region) [CLASH_DETECTION]: Likewise.
6135
a1674f0b
EZ
61362011-09-18 Eli Zaretskii <eliz@gnu.org>
6137
6138 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
6139
fbfb6dd4
EZ
61402011-09-17 Eli Zaretskii <eliz@gnu.org>
6141
6142 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
6143 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
6144
bb187662
EZ
61452011-09-17 Eli Zaretskii <eliz@gnu.org>
6146
1137e8b8 6147 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 6148 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
6149
6150 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
6151 (bidi_find_paragraph_start): Search back for paragraph beginning
6152 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
6153 (bidi_move_to_visually_next): Only trigger paragraph-related
6154 computations when the last character is a newline or at EOB, not
6155 just any NEUTRAL_B. (Bug#9470)
6156
bb187662
EZ
6157 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
6158 truncated lines if point is covered by a display string. (Bug#9524)
6159
2e621251
PE
61602011-09-16 Paul Eggert <eggert@cs.ucla.edu>
6161
6162 * xselect.c: Relax test for outgoing X longs (Bug#9498).
6163 (cons_to_x_long): New function.
6164 (lisp_data_to_selection_data): Use it. Correct the test for
6165 short-versus-long data; it was negated. Break out of vector
6166 loop, for efficiency, when a long datum is discovered.
6167
91a15bc6
SM
61682011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
6169
6170 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
6171
b41c3a35
EZ
61722011-09-16 Eli Zaretskii <eliz@gnu.org>
6173
6174 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
6175 GCC PR/17406) by declaring this function with external scope.
6176
7812ba2d
PE
61772011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6178
6179 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
6180 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
6181
cf7edc2a
AS
61822011-09-15 Andreas Schwab <schwab@linux-m68k.org>
6183
6184 * editfns.c (Fformat): Correctly handle text properties on "%%".
6185
bd01620e
EZ
61862011-09-15 Eli Zaretskii <eliz@gnu.org>
6187
6188 * xterm.c (x_draw_composite_glyph_string_foreground):
6189 * w32term.c (x_draw_composite_glyph_string_foreground):
6190 * term.c (encode_terminal_code):
6191 * composite.c (composition_update_it, get_composition_id):
6192 * xdisp.c (get_next_display_element)
6193 (fill_composite_glyph_string): Add comments about special meaning
6194 of TAB characters in a composition.
6195
a02719a3
PE
61962011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6197
6198 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
6199 This occurs when processing a multibyte format.
6200 Problem reported by Wolfgang Jenker.
a02719a3 6201
72589a3c
JB
62022011-09-15 Johan Bockgård <bojohan@gnu.org>
6203
6204 * xdisp.c (try_cursor_movement): Only check for exact match if
6205 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
6206
1c14176c
PE
62072011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6208
6209 Remove unused external symbols.
6210 * dispextern.h (calc_pixel_width_or_height): Remove decl.
6211 * xdisp.c (calc_pixel_width_or_height): Now static.
6212 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
6213 * indent.c (check_display_width):
6214 * w32term.c: Fix comment to match code.
6215 * xterm.c, xterm.h (x_catching_errors): Remove.
6216
d2eea5b5
PE
62172011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6218
6219 * xselect.c: Use signed conversions more consistently (Bug#9498).
6220 (selection_data_to_lisp_data): Assume incoming selection data are
6221 signed integers, not unsigned. This is to be consistent with
6222 outgoing selection data, which was modified to use signed integers
6223 in as part of the fix to Bug#9196 in response to Jan D.'s comment
6224 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
6225 expects long, not unsigned long.
6226
46888499
EZ
62272011-09-14 Eli Zaretskii <eliz@gnu.org>
6228
6229 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
6230 computation of loop end. Reported by Johan Bockgård
6231 <bojohan@gnu.org>.
6232
ef8ef9fb
CY
62332011-09-13 Chong Yidong <cyd@stupidchicken.com>
6234
6235 * frame.c (Fother_visible_frames_p): Function deleted.
6236
fa819fed
EZ
62372011-09-12 Eli Zaretskii <eliz@gnu.org>
6238
6239 * indent.c (compute_motion): Process display vector front to back
6240 rather than the other way around. (Bug#2496)
6241
2ba8e008
SM
62422011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
6243
6244 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
6245
20f53c69
CY
62462011-09-11 Chong Yidong <cyd@stupidchicken.com>
6247
6248 * minibuf.c (Fread_from_minibuffer): Doc fix.
6249
d562d7a4
EZ
62502011-09-11 Eli Zaretskii <eliz@gnu.org>
6251
6252 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
6253 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
6254
1c4d7f3d
LMI
62552011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6256
6257 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
6258 value for non-existent files.
6259
b885bf36
EZ
62602011-09-11 Eli Zaretskii <eliz@gnu.org>
6261
6262 * fileio.c (Finsert_file_contents): If the file cannot be opened,
6263 set its "size" to -1. This will set the modtime_size field of
6264 the corresponding buffer to -1, which is what
6265 verify-visited-file-modtime expects for files that do not exist.
6266 (Bug#9139)
6267
6612f0bf
PE
62682011-09-11 Paul Eggert <eggert@cs.ucla.edu>
6269
6270 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
6271 here ...
6272 * lisp.h: ... from here. push_key_description is no longer
6273 defined in keyboard.c, so its declaration should not be in
6274 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
6275 logically belongs with push_key_description.
6276
dfb3f755
PE
62772011-09-10 Paul Eggert <eggert@cs.ucla.edu>
6278
6279 * buffer.h: Include <sys/types.h> instead of <time.h>.
6280 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
6281 Problem reported by Herbert J. Skuhra.
6282
3134906c
LMI
62832011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
6284
6285 * xml.c (parse_region): Make the parsing work for
6286 non-comment-starting XML files again (bug#9144).
6287
8d903f4e
AS
62882011-09-10 Andreas Schwab <schwab@linux-m68k.org>
6289
6290 * image.c (gif_load): Fix calculation of bottom and right corner.
6291 (Bug#9468)
6292
80ad64f4
EZ
62932011-09-10 Eli Zaretskii <eliz@gnu.org>
6294
6295 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
6296 redisplay in small windows.
6297
208a048d
EZ
62982011-09-09 Eli Zaretskii <eliz@gnu.org>
6299
6300 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
6301
9b1c252e
MR
63022011-09-08 Martin Rudalics <rudalics@gmx.at>
6303
6304 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
6305 Operate on live windows only.
6306
2949f33b
JB
63072011-09-08 Juanma Barranquero <lekktu@gmail.com>
6308
6309 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
6310
e08dcafd
EZ
63112011-09-07 Eli Zaretskii <eliz@gnu.org>
6312
6313 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
6314 only under bidi iteration.
6315
115b96bd
JD
63162011-09-07 Jan Djärv <jan.h.d@swipnet.se>
6317
6318 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
6319
c8199d0f
PE
63202011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6321
6322 isnan: Fix porting problem to Solaris 10 with bundled gcc.
6323 Without this fix, the command to link temacs failed due to an
6324 undefined symbol __builtin_isnan. This is because
6325 /usr/include/iso/math_c99.h #defines isnan(x) to
6326 __builtin_isnan(x), but the bundled gcc, which identifies itself
6327 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
6328 a __builtin_isnan.
6329 * floatfns.c (isnan): #undef, and then #define to a clone of
6330 what's in data.c.
6331 (Fisnan): Always define, since it's always available now.
6332 (syms_of_floatfns): Always define isnan at the Lisp level.
6333
e39b275c 63342011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
6335
6336 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
6337
b2db44d9 63382011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 6339
f4af5137 6340 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
6341 The previous code assumed that file offsets (off_t values) fit in
6342 EMACS_INT variables, which is not true on typical 32-bit hosts.
6343 The code messed up by falsely reporting buffer overflow in cases
6344 such as (insert-file-contents "big" nil 1 2) into an empty buffer
6345 when "big" contains more than 2**29 bytes, even though this
6346 inserts just one byte and does not overflow the buffer.
6347 (Finsert_file_contents): Store file offsets as off_t
6348 values, not as EMACS_INT values. Check for overflow when
6349 converting between EMACS_INT and off_t. When checking for
6350 buffer overflow or for overlap, take the offsets into account.
6351 Don't use EMACS_INT for small values where int suffices.
6352 When checking for overlap, fix a typo: ZV was used where
6353 ZV_BYTE was intended.
6354 (Fwrite_region): Don't assume off_t fits into 'long'.
6355 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
6356
ecfc0a49
MA
63572011-09-05 Michael Albinus <michael.albinus@gmx.de>
6358
6359 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
6360
6511acf2 63612011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 6362
0999621a 6363 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
6364
6365 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 6366 (esprintf, exprintf, evxprintf): New functions.
62f19c19 6367 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 6368 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
6369 (modify_event_symbol): Do not assume that the length of
6370 name_alist_or_stem is safe to alloca and fits in int.
6371 (Fexecute_extended_command): Likewise for function name and binding.
6372 (Frecursion_depth): Wrap around reliably on integer overflow.
6373 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
6374 since some callers pass EMACS_INT values.
6375 (Fsingle_key_description): Don't crash if symbol name contains more
6376 than MAX_ALLOCA bytes.
6377 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
6378 (get_minibuffer): Arg is now EMACS_INT, not int.
6379 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 6380 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
6381 * window.h (command_loop_level, minibuf_level): Reflect API changes.
6382
2be7d702
PE
6383 * dbusbind.c (signature_cat): New function.
6384 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
6385 Do not overrun buffer; instead, report string overflow.
6386
9d1df220
PE
6387 * dispnew.c (add_window_display_history): Don't overrun buffer.
6388 Truncate instead; this is OK since it's just a log.
6389
33ef5c64
PE
6390 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
6391 even if the time zone offset is outlandishly large.
6392 Don't mishandle offset == INT_MIN.
6393
66c6fdd5
PE
6394 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
6395 when creating daemon; the previous buffer-overflow check was incorrect.
6396
d749b01b
PE
6397 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
6398 which has the guts of the old verror function.
6399
b5cd1905
PE
6400 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
6401 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
6402
6e1a67fb
PE
6403 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
6404 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 6405 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 6406 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
6407 length of string rather than counting it via multiple sprintfs;
6408 that's simpler and more reliable.
c21721cc
PE
6409 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
6410 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
6411 sprintf, in case result does not fit in int.
6412
c57b67fc
PE
6413 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
6414 (fontset_from_font): Print it.
6415
8a401434
PE
6416 * frame.c (tty_frame_count): Now printmax_t, not int.
6417 (make_terminal_frame, set_term_frame_name): Print it.
6418 (x_report_frame_params): In X, window IDs are unsigned long,
6419 not signed long, so print them as unsigned.
6420 (validate_x_resource_name): Check for implausibly long names,
6421 and don't assume name length fits in 'int'.
6422 (x_get_resource_string): Don't blindly alloca invocation name;
6423 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
6424 not fit in int.
6425
6e1a67fb
PE
6426 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
6427 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
6428 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
6429
0df02bf3
PE
6430 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
6431 Use esprintf, not sprintf, in case result does not fit in int.
6432
48e30793
PE
6433 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6434 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
6435 it as a large positive number.
6436 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
6437 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6438
a66ff6d8
PE
6439 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
6440 in case result does not fit in int.
6441
aca216ff
PE
6442 * print.c (float_to_string): Detect width overflow more reliably.
6443 (print_object): Make sprintf buffer a bit bigger, to avoid potential
6444 buffer overrun. Don't assume list length fits in 'int'. Treat
6445 print length of 0 as 0, not as infinity; to be consistent with other
6446 uses of print length in this function. Don't overflow print length
6447 index. Don't assume hash table size fits in 'long', or that
6448 vectorlike size fits in 'unsigned long'.
6449
31c286f7
PE
6450 * process.c (make_process): Use printmax_t, not int, to format
6451 process-name gensyms.
6452
55e5faa1
PE
6453 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
6454
80f2e268
PE
6455 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
6456 to avoid potential buffer overrun.
6457
670741ab
PE
6458 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
6459 if X resource line is longer than 512 bytes.
6460
b7163a50
PE
6461 * xfns.c (x_window): Make sprintf buffer a bit bigger
6462 to avoid potential buffer overrun.
6463
ae58ff1f
PE
6464 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
6465
c43c8a6a
PE
6466 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
6467
3f8236f4
PE
64682011-09-04 Paul Eggert <eggert@cs.ucla.edu>
6469
53e9fe90 6470 Integer overflow fixes for scrolling, etc.
6511acf2
PE
6471 Without these, Emacs silently mishandles large integers sometimes.
6472 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
6473 it were "C-u 1 M-x recenter" on a typical 64-bit host.
6474
6511acf2
PE
6475 * xdisp.c (try_window_id): Check Emacs fixnum range before
6476 converting to 'int'.
806add1d 6477
6511acf2 6478 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
6479 Check that an Emacs fixnum is in range before assigning it to 'int'.
6480 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
6481 values converted from Emacs fixnums.
6482 (Frecenter): Don't wrap around a line count if it is out of 'int'
6483 range; instead, treat it as an extreme value.
6484 (Fset_window_configuration, compare_window_configurations):
6485 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
6486
6511acf2
PE
6487 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
6488 that can exceed INT_MAX. Check that EMACS_INT value is in range
6489 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
6490 (match_limit): Don't assume that a fixnum can fit in 'int'.
6491
6511acf2 6492 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
6493 exceed INT_MAX.
6494
6511acf2 6495 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
6496 (Fvertical_motion): Don't wrap around LINES values that don't fit
6497 in 'int'. Instead, treat them as extreme values. This is good
6498 enough for windows, which can't have more than INT_MAX lines anyway.
6499
fcb901a7
LMI
65002011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6501
0f2f6b6d
LMI
6502 * Require libxml/parser.h to avoid compilation warning.
6503
fcb901a7
LMI
6504 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
6505
6506 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
6507 since this reportedly can destroy thread storage.
6508
6e20a0d4
CY
65092011-08-30 Chong Yidong <cyd@stupidchicken.com>
6510
6511 * syntax.c (find_defun_start): Update all cache variables if
6512 exiting early (Bug#9401).
6513
148ae00e
EZ
65142011-08-30 Eli Zaretskii <eliz@gnu.org>
6515
f6cfbd8f
EZ
6516 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
6517
148ae00e
EZ
6518 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
6519 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
6520 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
6521
6522 * term.c (tty_append_glyph): New function.
6523 (produce_stretch_glyph): Static function and its prototype deleted.
6524
a66cfb1c
SM
6525 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
6526 Add prototypes.
148ae00e 6527
c4a07a4c
PE
65282011-08-29 Paul Eggert <eggert@cs.ucla.edu>
6529
6530 * image.c (parse_image_spec): Check for nonnegative, not for positive,
6531 when checking :margin (Bug#9390).
6532 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 6533 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
6534 so that the name doesn't mislead. All uses changed.
6535
6bc8cd65
JB
65362011-08-28 Johan Bockgård <bojohan@gnu.org>
6537
6538 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
6539 set_tty_hooks.
6540
dca4927e
EZ
65412011-08-27 Eli Zaretskii <eliz@gnu.org>
6542
6543 * xdisp.c (move_it_to): Don't bail out early when reaching
6544 position beyond to_charpos, if we are scanning backwards.
6545 (move_it_vertically_backward): When DY == 0, make sure we get to
6546 the first character in the line after the newline.
6547
f2cad773
PE
65482011-08-27 Paul Eggert <eggert@cs.ucla.edu>
6549
6550 * ccl.c: Improve and simplify overflow checking (Bug#9196).
6551 (ccl_driver): Do not generate an out-of-range pointer.
6552 (Fccl_execute_on_string): Remove unnecessary check for
6553 integer overflow, noted by Stefan Monnier in
6554 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
6555 Remove a FIXME that didn't need fixing.
6556 Simplify the newly-introduced buffer reallocation code.
6557
0cae2cdb
JB
65582011-08-27 Juanma Barranquero <lekktu@gmail.com>
6559
6560 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
6561
5fc295a4 65622011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 6563
70c60eb2 6564 Integer and memory overflow issues (Bug#9196).
726e0ab1 6565
d31850da
PE
6566 * doc.c (get_doc_string): Rework so that
6567 get_doc_string_buffer_size is the actual buffer size, rather than
6568 being 1 less than the actual buffer size; this makes xpalloc more
6569 convenient.
6570
a69fbedb
PE
6571 * image.c (x_allocate_bitmap_record, cache_image):
6572 * xselect.c (Fx_register_dnd_atom):
6573 Simplify previous changes by using xpalloc.
6574
fe5c5d37
PE
6575 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
6576 since either will do and ptrdiff_t is convenient with xpalloc.
6577
0065d054
PE
6578 * charset.c (charset_table_size)
6579 (struct charset_sort_data.priority): Now ptrdiff_t.
6580 (charset_compare): Don't overflow if priorities differ greatly.
6581 (Fsort_charsets): Don't assume list length fits in int.
6582 Check for size-calculation overflow when allocating sort data.
6583 (syms_of_charset): Allocate an initial charset table that is
6584 just under 64 KiB, to avoid problems with glibc malloc and mmap.
6585
6586 * cmds.c (internal_self_insert): Check for size-calculation overflow.
6587
6588 * composite.h (struct composition.glyph_len): Now int, not unsigned.
6589 The actual value is always <= INT_MAX, and leaving it unsigned made
6590 overflow checking harder.
6591
6592 * dispextern.h (struct glyph_matrix.rows_allocated)
6593 (struct face_cache.size): Now ptrdiff_t, for convenience in use
6594 with xpalloc. The values are still always <= INT_MAX.
6595
6596 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
6597
6598 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
6599 (SAFE_NALLOCA): New macro.
6600
6601 * region-cache.c (struct boundary.pos, find_cache_boundary)
6602 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
6603 (set_cache_region, invalidate_region_cache)
6604 (revalidate_region_cache, know_region_cache, region_cache_forward)
6605 (region_cache_backward, pp_cache):
6606 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
6607 so that ptrdiff_t * can be passed to xpalloc.
6608 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
6609 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
6610 (pp_cache): Don't assume cache_len fits in int.
6611 * region-cache.h: Adjust extern decls to match.
6612
6613 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
6614 EMACS_INT, since either will do, for xpalloc.
6615
6616 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
6617 (xnmalloc, xnrealloc, xpalloc): New functions.
6618
726e0ab1
PE
6619 * bidi.c (bidi_shelve_header_size): New constant.
6620 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
6621 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
6622
51f30bc5 6623 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
6624 * buffer.c (overlays_at, overlays_in, record_overlay_string)
6625 (overlay_strings):
6626 Don't update size of array until after memory allocation succeeds,
6627 because xmalloc/xrealloc may not return.
0065d054
PE
6628 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
6629 now that we have proper integer overflow checking.
6630 (record_overlay_string, overlay_strings): Catch overflows when
6631 calculating size of overlay_str_buf.
726e0ab1 6632
0065d054
PE
6633 * callproc.c (Fcall_process): Check for size overflow when
6634 calculating size of args2.
6635 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
6636 Normally we prefer signed values, but sticking with ptrdiff_t would
6637 require adding more-complicated checks.
726e0ab1
PE
6638
6639 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
6640 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
6641 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 6642 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
6643
6644 * character.c (Fstring): Check for size-calculation overflow.
6645
6646 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
6647 unnecessary integer overflow. Check for size overflow.
6648 (encode_coding_object): Don't update size until xmalloc succeeds.
6649
6650 * composite.c (get_composition_id): Check for overflow in glyph
6651 length calculations.
6652
6653 Integer and memory overflow fixes for display code.
6654 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
6655 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
6656 (scrolling_window): Check for overflow in size calculations.
6657 (line_draw_cost, realloc_glyph_pool, add_row_entry):
6658 Don't assume glyph table len fits in int.
6659 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
6660 (row_table_size): Now ptrdiff_t, not int.
6661 (scrolling_window): Avoid overflow in size calculations.
6662 Don't update size until allocation succeeds.
6663 * fns.c (concat): Check for overflow in size calculations.
6664 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
6665 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6666 (NEXT_ALMOST_PRIME_LIMIT): New constant.
6667
6668 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
6669 (get_doc_string): Check for size calculation overflow.
6670 Don't update size until allocation succeeds.
6671 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
6672 EMACS_INT, where ptrdiff_t will do.
6673 (Fsubstitute_command_keys): Check for string overflow.
6674
6675 * editfns.c (set_time_zone_rule): Don't assume environment length
6676 fits in int.
6677 (message_length): Now ptrdiff_t, not int.
6678 (Fmessage_box): Don't update size until allocation succeeds.
6679 Don't assume message length fits in int.
6680 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
6681
0065d054
PE
6682 * emacs.c (main): Do not reallocate argv, since there is a null at
6683 the end that can be overwritten, and this way there's no need to
6684 worry about size-calculation overflow.
6685 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
6686
6687 * eval.c (init_eval_once, grow_specpdl): Don't update size until
6688 alloc succeeds.
6689 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
6690
6691 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
6692 (x_set_scroll_bar_width, x_figure_window_size):
6693 Check for integer overflow.
6694 (x_set_alpha): Do not assume XINT fits in int.
6695
6696 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
6697 This is for the members text_lines, text_cols, total_lines, total_cols,
6698 where the system imposes an 'int' limit.
6699
6700 * fringe.c (Fdefine_fringe_bitmap):
6701 Don't update size until alloc works.
6702
6703 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
6704 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
6705
6706 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
6707 Check for size-calculation overflow.
6708 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
6709 do, as we prefer signed integers.
6710 (id_to_widget.max_size, id_to_widget.used)
6711 (xg_store_widget_in_map, xg_remove_widget_from_map)
6712 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
6713 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
6714 Use and return ptrdiff_t, not int.
6715 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
6716 * gtkutil.h: Change prototypes to match the above.
6717
6718 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
6719 are duplicate now that they've been promoted to lisp.h.
6720 (x_allocate_bitmap_record, x_alloc_image_color)
6721 (make_image_cache, cache_image, xpm_load):
6722 Don't update size until alloc is done.
6723 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
6724 (x_detect_edges):
3256efce 6725 Check for size calculation overflow.
726e0ab1
PE
6726 (ct_colors_allocated_max): New constant.
6727 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
6728 overflow.
3256efce 6729
726e0ab1
PE
6730 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
6731 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
6732 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
6733 Use ptrdiff_t, not int, to count maps.
6734 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
6735 calculations. Don't update size until allocation succeeds.
6736 Redo calculations to avoid overflow.
726e0ab1
PE
6737 * keyboard.h: Change prototypes to match the above.
6738
6739 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
6740 to count maps.
6741 (current_minor_maps): Check for size calculation overflow.
6742 * keymap.h: Change prototypes to match the above.
6743
6744 * lread.c (read1, init_obarray): Don't update size until alloc done.
6745
6746 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
6747 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
6748
726e0ab1
PE
6749 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
6750 Now ptrdiff_t, not int.
6751 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
6752 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
6753
6754 * process.c (Fnetwork_interface_list): Check for overflow
6755 in size calculation.
6756
6757 * region-cache.c (move_cache_gap): Check for size calculation overflow.
6758
6759 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
6760 overflow. Don't bother calling xmalloc when xrealloc will do.
6761
6762 * search.c (Freplace_match): Check for size calculation overflow.
6763 (Fset_match_data): Don't assume list lengths fit in 'int'.
6764
6765 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
6766 for command line length. Do not attempt to address one before the
6767 beginning of an array, as that's not portable.
6768
6769 * term.c (max_frame_lines): Remove; unused.
6770 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
6771 not int.
6772 (encode_terminal_code, calculate_costs): Check for size
6773 calculation overflow.
6774 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
6775 table lengths and related sizes. Don't update size until alloc
6776 done. Redo calculations to avoid overflow.
6777 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
6778
6779 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
6780 subtracting pointers.
6781 (gobble_line): Check for overflow more carefully. Don't update size
6782 until alloc done.
6783
6784 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
6785 Don't update size until alloc done.
6786 Redo size calculations to avoid overflow.
6787 Check for size calculation overflow.
0065d054 6788 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
6789
6790 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
6791 Use ptrdiff_t, not int, for sizes.
6792 (store_mode_line_noprop_char): Don't update size until alloc done.
6793
0065d054
PE
6794 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
6795 Use ptrdiff_t, not int, for sizes.
6796 (Finternal_make_lisp_face, cache_face):
6797 Check for size calculation overflow.
6798 (cache_face): Treat size calculation overflows as if they were
6799 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
6800
6801 * xfns.c (x_encode_text, x_set_name_internal)
6802 (Fx_change_window_property): Use ptrdiff_t, not int, to count
6803 sizes, since they can exceed INT_MAX in size. Check for size
6804 calculation overflow.
6805
0065d054
PE
6806 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
6807 (xg_select): Check for size calculation overflow.
726e0ab1
PE
6808 Don't update size until alloc done.
6809
0065d054 6810 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 6811 as sprintf is limited to int lengths.
1d526e2f 6812
252c5ee1
PE
6813 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
6814 (X_LONG_MIN): New macros.
864d7ce7
PE
6815 Use them to make the following changes clearer.
6816 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
6817 This change doesn't affect the value now, but it may help remind
6818 future maintainers not to raise the value too much later.
6819 (SELECTION_QUANTUM): Remove, replacing with ...
6820 (selection_quantum): ... new function, which avoids overflow.
6821 All uses changed.
6822 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
6823 assumption that selection length fits in 'int'.
6824 (x_reply_selection_request, x_handle_selection_request)
6825 (x_get_window_property, receive_incremental_selection)
6826 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
6827 (lisp_data_to_selection_data, clean_local_selection_data):
6828 Use ptrdiff_t, not int, to record length of selection.
6829 (x_reply_selection_request, x_get_window_property)
6830 (receive_incremental_selection, x_property_data_to_lisp):
6831 Redo calculations to avoid overflow.
6832 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 6833 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
6834 something.
6835 (x_get_window_property, receive_incremental_selection)
6836 (lisp_data_to_selection_data, x_property_data_to_lisp):
6837 Check for size-calculation overflow.
6838 (x_get_window_property, receive_incremental_selection)
6839 (lisp_data_to_selection_data, Fx_register_dnd_atom):
6840 Don't store size until memory allocation succeeds.
6841 (x_get_window_property): Plug memory leak on memory exhaustion.
6842 Don't double-block input; malloc is safe here. Don't assume 2**34
6843 - 4 fits in unsigned long. Add an xassert to check
6844 XGetWindowProperty overflow. Be more careful about overflow
6845 calculations, and distinguish size from memory overflow better.
6846 (receive_incremental_selection): When tracing, don't assume
6847 unsigned int is less than INT_MAX.
6848 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
6849 harmful) conversions of unsigned short to int.
6850 (lisp_data_to_selection_data): Don't assume that integers
6851 in the range -65535 through -1 fit in an X unsigned short.
6852 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
6853 result parameters unless successful. Rely on cons_to_unsigned
6854 to report problems with elements; the old code wasn't right anyway.
6855 (x_check_property_data): Check for int overflow; we cannot use
6856 a wider type due to X limits.
6857 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
6858
726e0ab1 6859 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 6860
0065d054
PE
6861 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
6862 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
6863 (x_color_cells): Don't store size until memory allocation succeeds.
6864 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 6865 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
6866 (x_term_init): Don't assume length fits in int (sprintf is limited
6867 to int size).
bc18e09d 6868
ebfa62c0
PE
6869 Use ptrdiff_t for composition IDs.
6870 * character.c (lisp_string_width):
6871 * composite.c (composition_table_size, n_compositions)
6872 (get_composition_id, composition_gstring_from_id):
6873 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
6874 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
6875 * window.c (Frecenter):
6876 Use ptrdiff_t, not int, for composition IDs.
6877 * composite.c (get_composition_id): Check for integer overflow.
6878 * composite.h: Adjust prototypes to match the above changes.
6879
d3411f89
PE
6880 Use ptrdiff_t for hash table indexes.
6881 * category.c (hash_get_category_set):
6882 * ccl.c (ccl_driver):
6883 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
6884 * coding.c (coding_system_charset_list, detect_coding_system):
6885 * coding.h (struct coding_system.id):
6886 * composite.c (get_composition_id, gstring_lookup_cache):
6887 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
6888 * image.c (xpm_get_color_table_h):
6889 * lisp.h (hash_lookup, hash_put):
6890 * minibuf.c (Ftest_completion):
6891 Use ptrdiff_t for hash table indexes, not int (which is too
6892 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
6893 32-bit --with-wide-int hosts).
6894
e097a6fa
PE
6895 * charset.c (Fdefine_charset_internal): Check for integer overflow.
6896 Add a FIXME comment about memory leaks.
6897 (syms_of_charset): Don't assume xmalloc returns.
6898
5637687f
PE
6899 Don't assume that stated character widths fit in int.
6900 * character.c (Fchar_width, c_string_width, lisp_string_width):
6901 * character.h (CHAR_WIDTH):
6902 * indent.c (MULTIBYTE_BYTES_WIDTH):
6903 Use sanitize_char_width to avoid undefined and/or bad behavior
6904 with outlandish widths.
a66cfb1c 6905 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
6906 now that we have two such functions. All uses changed.
6907 (sanitize_char_width): New inline function.
6908
a2271ba2
PE
6909 Don't assume that tab-width fits in int.
6910 * character.h (sanitize_width): New inline function.
6911 (SANE_TAB_WIDTH): New macro.
6912 (ASCII_CHAR_WIDTH): Use it.
6913 * indent.c (sane_tab_width): Remove. All uses replaced by
6914 SANE_TAB_WIDTH (current_buffer).
6915 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
6916
18c52557
PE
6917 * fileio.c: Integer overflow issues with file modes.
6918 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
6919
caeeedc1
PE
6920 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
6921 Remove unreachable code.
6922 (read_hex, load_charset_map_from_file): Check for integer overflow.
6923
6df6ae42 6924 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
6925 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
6926 (x_send_scroll_bar_event): Likewise. Check that the size does not
6927 exceed limits imposed by XClientMessageEvent, as well as the usual
6928 ptrdiff_t and size_t limits.
6929
b13995db
PE
6930 * keyboard.c: Overflow, signedness and related fixes.
6931 (make_lispy_movement): Use same integer type in forward decl
6932 that is used in the definition.
6933 (read_key_sequence, keyremap_step):
6934 Change bufsize argument back to int, undoing my 2011-03-30 change.
6935 We prefer signed types, and int is wide enough here.
6936 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
6937 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
6938 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
6939 length, not size_t. Use ptrdiff_t for index, not int.
6940 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
6941 possibility of integer overflow.
6942
13464394
PE
6943 Overflow, signedness and related fixes for images.
6944
6945 * dispextern.h (struct it.stack[0].u.image.image_id)
6946 (struct_it.image_id, struct image.id, struct image_cache.size)
6947 (struct image_cache.used, struct image_cache.ref_count):
6948 * gtkutil.c (update_frame_tool_bar):
6949 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
6950 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
6951 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
6952 * nsmenu.m (update_frame_tool_bar):
6953 * xdisp.c (calc_pixel_width_or_height):
6954 * xfns.c (image_cache_refcount):
6955 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
6956 on typical 64-bit hosts.
6957
6958 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6959 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
6960 Omit unnecessary casts to int.
6961 (parse_image_spec): Check that integers fall into 'int' range
6962 when the callers expect that.
6963 (image_ascent): Redo ascent calculation to avoid int overflow.
6964 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
6965 (lookup_image): Remove unnecessary tests.
6966 (xbm_image_p): Locals are now of int, not EMACS_INT,
6967 since parse_image_check makes sure they fit into int.
6968 (png_load, gif_load, svg_load_image):
6969 Prefer int to unsigned where either will do.
6970 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
6971 old tiff_error_handler and tiff_warning_handler.
6972 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
6973 stack buffer overflows. It uses only the features of vsnprintf
6974 that are common to both POSIX and native Microsoft.
6975 (tiff_error_handler, tiff_warning_handler): Use it.
6976 (tiff_load, gif_load, imagemagick_load_image):
6977 Don't assume :index value fits in 'int'.
6978 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
6979 (imagemagick_load_image): Check that crop parameters fit into
6980 the integer types that MagickCropImage accepts. Don't assume
6981 Vimagemagick_render_type has a nonnegative value. Don't assume
6982 size_t fits in 'long'.
6983 (gs_load): Use printmax_t to print the widest integers possible.
6984 Check for integer overflow when computing image height and width.
6985
c11821d4
EZ
69862011-08-26 Eli Zaretskii <eliz@gnu.org>
6987
6988 * xdisp.c (redisplay_window): Don't force window start if point
6989 will be invisible in the resulting window. (Bug#9324)
6990
0c95fcf7
EZ
69912011-08-25 Eli Zaretskii <eliz@gnu.org>
6992
6993 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
6994 the display spec is of the form `(space ...)'.
6995 (handle_display_spec): Return the value returned by
6996 handle_single_display_spec, not just 1 or zero.
6997 (handle_single_display_spec): If the display spec is of the form
6998 `(space ...)', and specifies display in the text area, return 2
6999 rather than 1.
fee65a97 7000 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
7001 accurately, and prefer exact match for point under bidi.
7002 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
7003
7004 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
7005 into disp_prop; all users changed.
7006
7007 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
7008 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
7009 for the text covered by the display property.
7010
e4ed06f1
CY
70112011-08-25 Chong Yidong <cyd@stupidchicken.com>
7012
7013 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
7014 Change return value to nil.
7015 (Frecord_buffer): Delete unused function.
7016
f67cdd7f
EZ
70172011-08-24 Eli Zaretskii <eliz@gnu.org>
7018
5980d4c6
EZ
7019 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
7020 buffers, return left-to-right.
8610fe8b
EZ
7021 (set_cursor_from_row): Consider candidate row a win if its glyph
7022 represents a newline and point is on that newline. Fixes cursor
7023 positioning on the newline at EOL of R2L text within L2R
7024 paragraph, and vice versa.
7025 (try_cursor_movement): Check continued rows, in addition to
7026 continuation rows. Fixes unwarranted scroll when point enters a
7027 continued line of R2L text within an L2R paragraph, or vice versa.
7028 (cursor_row_p): Consider the case of point being equal to
7029 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
7030 from the end of a short line to the beginning of a continued line
7031 of R2L text within L2R paragraph.
7032 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
7033 composed characters.
5980d4c6 7034
f67cdd7f
EZ
7035 * bidi.c (bidi_check_type): Use xassert.
7036 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
7037 members.
7038
bca633fb
EZ
70392011-08-23 Eli Zaretskii <eliz@gnu.org>
7040
7041 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
7042 a character.
7043
4a5885a7
CY
70442011-08-23 Chong Yidong <cyd@stupidchicken.com>
7045
7046 * nsfont.m (ns_otf_to_script): Fix typo.
7047
0902a04e
KH
70482011-08-22 Kenichi Handa <handa@m17n.org>
7049
7050 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
7051 extra slot even if the purpose is char-code-property-table.
7052
1a2e6670
EZ
70532011-08-23 Eli Zaretskii <eliz@gnu.org>
7054
8ddde651
EZ
7055 * xdisp.c (redisplay_window): When computing centering_position,
7056 account for the height of the header line. (Bug#8874)
7057
425cc014
EZ
7058 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
7059 instead of CHAR_TO_BYTE. Fixes a crash when a completion
7060 candidate is selected by the mouse, and that candidate has a
7061 composed character under the mouse.
7062
1a2e6670
EZ
7063 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
7064 coordinates reported by pos-visible-in-window-p for a composed
7065 character in column zero.
7066
8b76d6f8
SM
70672011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
7068
7069 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
7070
dac347dd
EZ
70712011-08-22 Eli Zaretskii <eliz@gnu.org>
7072
7073 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
7074 consider it a hit if to_charpos is anywhere in the range of the
7075 composed buffer positions.
7076
e013fb34
CY
70772011-08-22 Chong Yidong <cyd@stupidchicken.com>
7078
7079 * image.c (gif_load): Don't assume that each subimage has the same
7080 dimensions as the base image. Handle disposal method that is
7081 "undefined" by the gif spec (Bug#9335).
7082
bd1ba3e8
CY
70832011-08-20 Chong Yidong <cyd@stupidchicken.com>
7084
7085 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 7086 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 7087
54a1215b
EZ
70882011-08-19 Eli Zaretskii <eliz@gnu.org>
7089
823564e5
EZ
7090 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
7091 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
7092 from an Org mode buffer to a Speedbar frame.
7093
54a1215b
EZ
7094 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
7095 a composition, take its buffer position from IT->cmp_it.charpos.
7096 Fixes cursor positioning at the beginning of a line that begins
7097 with a composed character.
7098
9778ebcc
EZ
70992011-08-18 Eli Zaretskii <eliz@gnu.org>
7100
0be6ee06
EZ
7101 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
7102 character bidirectional type, use STRONG_L instead. Fixes crashes
7103 in a buffer produced by `describe-categories'.
7104
9778ebcc
EZ
7105 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
7106 members before the level stack, so they would be saved and
7107 restored when copying iterator state. Fixes incorrect reordering
7108 around TABs covered by display properties.
7109
156bffbe
AS
71102011-08-18 Andreas Schwab <schwab@linux-m68k.org>
7111
6b02f655 7112 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 7113
72ad093b
CY
71142011-08-17 Chong Yidong <cyd@stupidchicken.com>
7115
7116 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
7117 (internal_condition_case_2, internal_condition_case_n):
7118 Remove unnecessary aborts (Bug#9081).
72ad093b 7119
35774242
EZ
71202011-08-17 Eli Zaretskii <eliz@gnu.org>
7121
7122 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
7123 has no `load' handler, try opening the file locally. (Bug#9311)
7124
db76dd85
KB
71252011-08-16 Ken Brown <kbrown@cornell.edu>
7126
7127 * gmalloc.c: Expand comment.
7128
b215eee5
EZ
71292011-08-16 Eli Zaretskii <eliz@gnu.org>
7130
7131 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
7132 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
7133
a4579d33
KB
71342011-08-16 Ken Brown <kbrown@cornell.edu>
7135
7136 Fix memory allocation problems in Cygwin build (Bug#9273).
7137
7138 * unexcw.c ( __malloc_initialized): Declare external variable.
7139 (fixup_executable): Force the dumped emacs to reinitialize malloc.
7140
8b76d6f8
SM
7141 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
7142 New variables.
a4579d33
KB
7143 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
7144 dumped emacs.
7145 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
7146 in the static heap.
7147 [CYGWIN] (special_realloc): New function.
7148 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
7149 requests to realloc storage in the static heap.
7150
3ebec551
PE
71512011-08-15 Paul Eggert <eggert@cs.ucla.edu>
7152
7153 * bidi.c (bidi_initialize): Remove unused local.
7154
9fd8be00
EZ
71552011-08-15 Eli Zaretskii <eliz@gnu.org>
7156
6b02f655
SM
7157 * bidimirror.h:
7158 * biditype.h: Remove file.
7159 * makefile.w32-in ($(BLD)/bidi.$(O)):
7160 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
7161
7162 * dispextern.h: Fix a typo in the comment to bidi_type_t.
7163
7164 * chartab.c: Improve commentary for the uniprop_table API.
7165
32413314
EZ
7166 * bidi.c (bidi_paragraph_init): Support zero value of
7167 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
7168 (bidi_initialize): Use uniprop_table instead of including
7169 biditype.h and bidimirror.h.
32413314 7170
9fd8be00
EZ
7171 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
7172 coordinates of the iterator when restoring from ppos_it.
7173 (Bug#9296)
7174
5cf2b69b
KH
71752011-08-14 Kenichi Handa <handa@m17n.org>
7176
7177 * process.c (create_process): Call setup_process_coding_systems
72ad093b 7178 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 7179
daf17d00
EZ
71802011-08-14 Eli Zaretskii <eliz@gnu.org>
7181
7182 * xdisp.c (move_it_in_display_line_to): Don't invoke
7183 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
7184 ppos_it. Fixes vertical cursor motion when line beginning is
7185 covered by an image. (Bug#9296)
7186
08e3161a
JD
71872011-08-14 Jan Djärv <jan.h.d@swipnet.se>
7188
7189 * nsterm.h (ns_run_ascript): Declare.
7190 (NSAPP_DATA2_RUNASSCRIPT): Define.
7191
7192 * nsfns.m (as_script, as_result, as_status): New static variables.
7193 (ns_run_ascript): New function.
5e617bc2 7194 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
7195 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
7196 the event loop. Get status from as_status (Bug#7276).
7197
7198 * nsterm.m (sendEvent): If event is NSApplicationDefined and
7199 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
7200 the event loop (Bug#7276).
7201
a3720aa2
AS
72022011-08-14 Andreas Schwab <schwab@linux-m68k.org>
7203
7204 * gnutls.c (QCgnutls_bootprop_priority)
7205 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
7206 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
7207 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
7208 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
7209 (QCgnutls_bootprop_verify_hostname_error)
7210 (QCgnutls_bootprop_callbacks_verify): Rename from
7211 Qgnutls_bootprop_..., all uses changed.
7212
7213 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
7214 uses changed.
7215
0a0d27fb
PE
72162011-08-14 Paul Eggert <eggert@cs.ucla.edu>
7217
19d5c50c
PE
7218 * xfaces.c (Qframe_set_background_mode): Now static.
7219 * dispextern.h (Qframe_set_background_mode): Remove decl.
7220
0a0d27fb
PE
7221 * process.c (Fnetwork_interface_info): Declare local only if needed.
7222
377538cb
JD
72232011-08-13 Jan Djärv <jan.h.d@swipnet.se>
7224
7225 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
7226 (Fnetwork_interface_list): Allocate in increments of bytes instead
7227 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
7228 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
7229 sockaddr.
7230 (struct ifflag_def): notrailers is smart on OSX.
7231 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
7232 Get hardware address with getifaddrs if available.
7233
08fff70c
EZ
72342011-08-12 Eli Zaretskii <eliz@gnu.org>
7235
7236 * xdisp.c (iterate_out_of_display_property): xassert that
7237 IT->position is set to within IT->object's boundaries. Break from
7238 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
7239 when IT->position is set up wrongly due to some bug.
7240 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
7241 (push_display_prop): Allow GET_FROM_STRING as IT->method on
7242 entry. Force push_it to save on the stack the current
7243 buffer/string position, to be restored by pop_it. Fix flags in
7244 the iterator structure wrt the object coming from a display
7245 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
7246 properties. (Bug#9284)
7247
7be1c708 72482011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 7249
7be1c708
CY
7250 * fontset.c (fontset_get_font_group): Add proper type checks.
7251 (Bug#9172)
aac0c6e3 7252
7be1c708 72532011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 7254
7be1c708
CY
7255 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
7256 and LC_VERSION_MIN_MACOSX.
7257 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
7258 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 7259
97bb72a6
EZ
72602011-08-08 Eli Zaretskii <eliz@gnu.org>
7261
7262 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
7263 no-display-properties-and-no-overlays under bidi display.
7264 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 7265 properties and overlays.
97bb72a6 7266
d5617611
CY
72672011-08-08 Chong Yidong <cyd@stupidchicken.com>
7268
37e11a63
CY
7269 * editfns.c (Fset_time_zone_rule): Document relationship with the
7270 setenv function.
7271
d5617611
CY
7272 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
7273 the font entity extracted from the cache (Bug#8109).
7274
58872834
CY
72752011-08-07 Chong Yidong <cyd@stupidchicken.com>
7276
7277 * composite.c (autocmp_chars): Don't reset point. That is done by
7278 restore_point_unwind (Bug#5984).
7279
75bfc667
JL
72802011-08-07 Juri Linkov <juri@jurta.org>
7281
7282 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
7283 to show the arg `TIME' instead of `TIMEVAL'.
7284
d1410150
EZ
72852011-08-06 Eli Zaretskii <eliz@gnu.org>
7286
7287 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
7288 display property strides EOL and includes a newline, as in
7289 longlines-mode. (Bug#9254)
75b771e4
EZ
7290 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
7291 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
7292
7293 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
7294 is non-zero, even if the data buffer is NULL. Fixes a crash in
7295 vertical-motion with longlines-mode. (Bug#9254)
7296
35928349
EZ
72972011-08-05 Eli Zaretskii <eliz@gnu.org>
7298
ec7cc85b
EZ
7299 * bidi.c <bidi_cache_total_alloc>: Now static.
7300 (bidi_initialize): Initialize bidi_cache_total_alloc.
7301
8b76d6f8 7302 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
7303 cache. (Bug#9221)
7304
7305 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
7306 amount allocated this far in `bidi_cache_total_alloc'.
7307 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
7308 non-zero, only free the data buffer without restoring the cache
7309 contents. All callers changed.
7310
7311 * dispextern.h (bidi_unshelve_cache): Update prototype.
7312
7313 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
7314 (move_it_in_display_line, move_it_to)
7315 (move_it_vertically_backward, move_it_by_lines): Replace the call
7316 to xfree to an equivalent call to bidi_unshelve_cache.
7317 (move_it_in_display_line_to): Fix logic of returning
412b6358 7318 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 7319
e2e2423b
EZ
73202011-08-05 Eli Zaretskii <eliz@gnu.org>
7321
7322 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
7323 came from a string character with a `cursor' property. (Bug#9229)
7324
ae9e757a
JD
73252011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7326
7327 * Makefile.in (LIB_PTHREAD): New variable.
7328 (LIBES): Add LIB_PTHREAD (Bug#9216).
7329
7330 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
7331 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
7332
213bd7f2
AS
73332011-08-04 Andreas Schwab <schwab@linux-m68k.org>
7334
6b02f655 7335 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 7336
99aaf75f
JD
73372011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7338
7339 * xterm.c (x_find_topmost_parent): New function.
7340 (x_set_frame_alpha): Find topmost parent window with
7341 x_find_topmost_parent and set the property there also (bug#9181).
7342 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
7343
c74e9d86
PE
73442011-08-04 Paul Eggert <eggert@cs.ucla.edu>
7345
7346 * callproc.c (Fcall_process): Avoid vfork clobbering
7347 the local vars buffer, coding_systems, current_dir.
7348
640c8776
SM
73492011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
7350
7351 * keymap.c (Fmake_composed_keymap): Move to subr.el.
7352
f26d0e4c
PE
73532011-08-03 Paul Eggert <eggert@cs.ucla.edu>
7354
8a10d76c
PE
7355 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
7356 so that it is not optimized away.
7357
f26d0e4c
PE
7358 * xdisp.c (compute_display_string_pos): Remove unused local.
7359
55439c61
EZ
73602011-08-02 Eli Zaretskii <eliz@gnu.org>
7361
7362 Fix slow cursor motion and scrolling in large buffers with
7363 selective display, like Org Mode buffers. (Bug#9218)
7364
7365 * dispextern.h (struct bidi_it): New member disp_prop_p.
7366
7367 * xdisp.c: Remove one-slot cache of display string positions.
7368 (compute_display_string_pos): Accept an additional argument
5e617bc2 7369 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
7370 for a display string or property. If found, set DISP_PROP_P
7371 non-zero.
7372
7373 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
7374 DISP_PROP_P, and pass it to compute_display_string_pos.
7375 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
7376 non-zero. All callers of bidi_fetch_char changed.
7377
fb33fa43
SM
73782011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
7379
7380 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
7381
b099e063
DM
73822010-12-03 Don March <don@ohspite.net>
7383
7384 * keymap.c (Fdefine_key): Fix non-prefix key error message when
7385 last character M-[char] is translated to ESC [char] (bug#7541).
7386
5cc7f7af
KH
73872011-08-02 Kenichi Handa <handa@m17n.org>
7388
d0fffa3f 7389 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
7390
7391 * chartab.c (uniprop_table): Make it non-static.
7392
525d5e6e
EZ
73932011-08-01 Eli Zaretskii <eliz@gnu.org>
7394
7395 * xdisp.c (forward_to_next_line_start): Accept additional argument
7396 BIDI_IT_PREV, and store into it the state of the bidi iterator had
7397 on the newline.
7398 (reseat_at_next_visible_line_start): Use the bidi iterator state
7399 returned by forward_to_next_line_start to restore the state of
7400 it->bidi_it after backing up to previous newline. (Bug#9212)
7401
31011111
AS
74022011-07-30 Andreas Schwab <schwab@linux-m68k.org>
7403
7404 * regex.c (re_comp): Protoize.
7405 (re_exec): Fix return type.
7406 (regexec): Fix type of `ret'. (Bug#9203)
7407
476371c4
PE
74082011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7409
e5d76069
PE
7410 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
7411 This is needed if max-image-size is a floating-point number.
7412
9a79b20c
AS
74132011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7414
7415 * print.c (print_object): Print empty symbol as ##.
7416
7417 * lread.c (read1): Read ## as empty symbol.
7418
d8c2fa78
AA
74192011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7420
7421 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
7422 setting frame foreground color (Bug#9175).
7423 (x_set_background_color): Likewise.
7424
ffe57a7a
AA
7425 * nsmenu.m (-setText): Size tooltip dimensions precisely to
7426 contents (Bug#9176).
7427 (EmacsTooltip -init): Remove bezels and add shadows to
7428 tooltip windows.
7429
bf3492a5
AA
7430 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
7431 or scroll bar (Bug#8470).
7432
d55e9c53
AA
7433 * nsfont.m (nsfont_open): Remove assignment to voffset and
7434 unnecessary vars hshink, expand, hd, full_height, min_height.
7435 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
7436
7437 * nsterm.h (nsfont_info): Remove voffset field.
7438
d8c2fa78 74392011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
7440
7441 Implement strike-through and overline on NextStep (Bug#8863).
7442
7443 * nsfont.m (nsfont_open): Use underline position provided by font,
7444 instead of hard-coded value of 2.
7445 (nsfont_draw): Call ns_draw_text_decoration instead.
7446
7447 * nsterm.h: Add declaration for ns_draw_text_decoration.
7448
7449 * nsterm.m (ns_draw_text_decoration): New function for drawing
7450 underline, overline, and strike-through.
7451 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
7452 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 7453 accommodate underlining, etc.
4843aac3 7454
4cc60b9b
EZ
74552011-07-28 Eli Zaretskii <eliz@gnu.org>
7456
bc7ece87
EZ
7457 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
7458 default.
4cc60b9b 7459
476371c4
PE
74602011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7461
66606eea
PE
7462 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
7463 Without this fix, if a signal arrives just after memory fills up,
7464 'malloc' might be invoked reentrantly.
7465
476371c4
PE
7466 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
7467 In other words, assume that every image size is allowed, on non-X
7468 hosts. This assumption is probably wrong, but it lets Emacs compile.
7469
f3fcc40d
AS
74702011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7471
7472 * regex.c (re_iswctype): Convert return values to boolean.
7473
350c992f
EZ
74742011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
7475
7476 * xdisp.c (compute_display_string_pos): Don't use cached display
7477 string position if the buffer had its restriction changed.
7478 (Bug#9184)
7479
5266b4bb
PE
74802011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7481
7482 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7483
2573a837 74842011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 7485
41f55ccd 7486 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 7487
39e378da
PE
7488 * bidi.c: Integer size and overflow fixes.
7489 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
7490 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
7491 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7492 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
7493 (bidi_find_other_level_edge):
7494 Use ptrdiff_t instead of EMACS_INT where either will do.
7495 This works better on 32-bit hosts configured --with-wide-int.
7496 (bidi_cache_ensure_space): Check for size-calculation overflow.
7497 Use % rather than repeated addition, for better worst-case speed.
7498 Don't set bidi_cache_size until after xrealloc returns, because it
7499 might not return.
7500 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
7501 (bidi_cache_ensure_space): Also check that the bidi cache size
7502 does not exceed that of the largest Lisp string or buffer. See Eli
7503 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 7504
5e927815
PE
7505 * alloc.c (__malloc_size_t): Remove.
7506 All uses replaced by size_t. See Andreas Schwab's note
7507 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
7508
ca4aa935
PE
7509 * image.c: Improve checking for integer overflow.
7510 (check_image_size): Assume that f is nonnull, since
7511 it is always nonnull in practice. This is one less thing to
7512 worry about when checking for integer overflow later.
7513 (x_check_image_size): New function, which checks for integer
7514 overflow issues inside X.
7515 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
7516 This removes the need for a memory_full check.
7517 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
7518 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
7519 (xbm_read_bitmap_data): Change locals back to 'int', since
7520 their values must fit in 'int'.
7521 (xpm_load_image, png_load, tiff_load):
7522 Invoke x_create_x_image_and_pixmap earlier,
7523 to avoid much needless work if the image is too large.
7524 (tiff_load): Treat overly large images as if
7525 x_create_x_image_and_pixmap failed, not as malloc failures.
7526 (gs_load): Use x_check_image_size.
7527
5f8f9cc2
PE
7528 * gtkutil.c: Omit integer casts.
7529 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
7530 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
7531
5adf60bc
PE
7532 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
7533
c8907a93
PE
7534 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
7535 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
7536 would wrongly return t on a 64-bit host.
7537
e3c25c68
PE
7538 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
7539 The plain *_OVERFLOW macros run afoul of GCC bug 49705
7540 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
7541 and therefore cause GCC to emit a bogus diagnostic in some cases.
7542
3f791afe
PE
7543 * image.c: Integer signedness and overflow and related fixes.
7544 This is not an exhaustive set of fixes, but it's time to
7545 record what I've got.
7546 (lookup_pixel_color, check_image_size): Remove redundant decls.
7547 (check_image_size): Don't assume that arbitrary EMACS_INT values
7548 fit in 'int', or that arbitrary 'double' values fit in 'int'.
7549 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
7550 (tiff_load, imagemagick_load_image):
7551 Check for overflow in size calculations.
7552 (x_create_x_image_and_pixmap): Remove unnecessary test for
7553 xmalloc returning NULL; that can't happen.
7554 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
7555 (xpm_color_bucket): Use better integer hashing function.
7556 (xpm_cache_color): Don't possibly over-allocate memory.
7557 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
7558 (gif_memory_source):
7559 Use ptrdiff_t, not int or size_t, to record sizes.
7560 (png_load): Don't assume values greater than 2**31 fit in 'int'.
7561 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
7562 either works, as we prefer signed integers.
7563 (tiff_read_from_memory, tiff_write_from_memory):
7564 Return tsize_t, not size_t, since that's what the TIFF API wants.
7565 (tiff_read_from_memory): Don't fail simply because the read would
7566 go past EOF; instead, return a short read.
7567 (tiff_load): Omit no-longer-needed casts.
7568 (Fimagemagick_types): Don't assume size fits into 'int'.
7569
3cc5a532
PE
7570 Improve hashing quality when configured --with-wide-int.
7571 * fns.c (hash_string): New function, taken from sxhash_string.
7572 Do not discard information about ASCII character case; this
7573 discarding is no longer needed.
7574 (sxhash-string): Use it. Change sig to match it. Caller changed.
7575 * lisp.h: Declare it.
7576 * lread.c (hash_string): Remove, since we now use fns.c's version.
7577 The fns.c version returns a wider integer if --with-wide-int is
7578 specified, so this should help the quality of the hashing a bit.
7579
b312a492
PE
7580 * emacs.c: Integer overflow minor fix.
7581 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
7582 Define only if GNU_LINUX.
7583 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
7584
dfd153ae
PE
7585 * dispnew.c: Integer signedness and overflow fixes.
7586 Remove unnecessary forward decls, that were a maintenance hassle.
7587 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
7588 All uses changed.
7589 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
7590 (scrolling_window): Use ptrdiff_t, not int, for byte count.
7591 (prepare_desired_row, line_draw_cost):
7592 Use int, not unsigned, where either works.
7593 (save_current_matrix, restore_current_matrix):
7594 Use ptrdiff_t, not size_t, where either works.
7595 (init_display): Check for overflow more accurately, and without
7596 relying on undefined behavior.
7597
a81d11a3
PE
7598 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
7599 Remove, replacing with the new symbols in lisp.h. All uses changed.
7600 * fileio.c (make_temp_name):
7601 * filelock.c (lock_file_1, lock_file):
7602 * xdisp.c (message_dolog):
7603 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
7604 Use pMd etc. instead.
7605 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
7606 replacing the pWIDE etc. symbols removed from editfns.c.
7607
3300e6fd
PE
7608 * keyboard.h (num_input_events): Now uintmax_t.
7609 This is (very slightly) less likely to mess up due to wraparound.
7610 All uses changed.
7611
fd05c7e9
PE
7612 * buffer.c: Integer signedness fixes.
7613 (alloc_buffer_text, enlarge_buffer_text):
7614 Use ptrdiff_t rather than size_t when either will do, as we prefer
7615 signed integers.
7616
903fe15d
PE
7617 * alloc.c: Integer signedness and overflow fixes.
7618 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
7619 (__malloc_size_t): Default to size_t, not to int.
7620 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
7621 (Fgarbage_collect, mark_object_loop_halt, mark_object):
7622 Prefer ptrdiff_t to size_t when either would do, as we prefer
7623 signed integers.
7624 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
7625 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
7626 Now const. Initialize with values that are in range even if char
7627 is signed.
7628 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
7629 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
7630 These functions do the right thing with sizes > 2**32.
7631 (check_depth): Now ptrdiff_t, not int.
7632 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
7633 Adjust to new way of storing sizes. Check for size overflow bugs
7634 in rest of code.
7635 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
7636 slightly wrong anyway, as it missed one instance of
7637 XMALLOC_OVERRUN_CHECK_OVERHEAD.
7638 (refill_memory_reserve): Omit needless cast to size_t.
7639 (mark_object_loop_halt): Mark as externally visible.
7640
ac82cc6a
PE
7641 * xselect.c: Integer signedness and overflow fixes.
7642 (Fx_register_dnd_atom, x_handle_dnd_message):
7643 Use ptrdiff_t, not size_t, since we prefer signed.
7644 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
7645 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
7646 x_dnd_atoms_size and x_dnd_atoms_length.
7647
c2d1e36d
PE
7648 * doprnt.c: Prefer signed to unsigned when either works.
7649 * eval.c (verror):
7650 * doprnt.c (doprnt):
7651 * lisp.h (doprnt):
7652 * xdisp.c (vmessage):
7653 Use ptrdiff_t, not size_t, when using or implementing doprnt,
7654 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
7655 prefer signed arithmetic to avoid comparison confusion.
7656 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
7657 but is a bit tricky.
7658
0e926e56
PE
7659 Assume freestanding C89 headers, string.h, stdlib.h.
7660 * data.c, doprnt.c, floatfns.c, print.c:
7661 Include float.h unconditionally.
7662 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
7663 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
7664 * regex.c: Likewise for stddef.h, string.h.
7665 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
7666 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
7667 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
7668 (STDC_HEADERS): Remove obsolete defines.
7669 * sysdep.c: Include limits.h unconditionally.
7670
9cfdb3ec
PE
7671 Assume support for memcmp, memcpy, memmove, memset.
7672 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
7673 * regex.c (memcmp, memcpy):
7674 Remove; we assume C89 now.
7675
7676 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
7677 (__malloc_safe_bcopy): Remove; no longer needed.
7678
cf950e6b 7679 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
7680 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
7681 well either way, and we prefer signed to unsigned.
7682
dbf38e02
LMI
76832011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
7684
7685 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
7686 closes the connection while we're reading (bug#9182).
7687
d6f0886c 76882011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 7689
d6f0886c
JD
7690 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
7691 are specified (Bug#9168).
24e0f6b1 7692
2eb1f9e6
PE
76932011-07-25 Paul Eggert <eggert@cs.ucla.edu>
7694
7695 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
7696 Found by GCC static checking and --with-wide-int on a 32-bit host.
7697
22381272 76982011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
7699
7700 * xdisp.c (compute_display_string_pos): Fix logic of caching
7701 previous display string position. Initialize cached_prev_pos to
7702 -1. Fixes slow-down at the beginning of a buffer.
7703
f25e39b4
EZ
77042011-07-24 Eli Zaretskii <eliz@gnu.org>
7705
7706 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
7707 for attrs[LFACE_FONTSET_INDEX].
7708
04c4b52e
PE
77092011-07-23 Paul Eggert <eggert@cs.ucla.edu>
7710
7711 * xml.c (parse_region): Remove unused local
7712 that was recently introduced.
7713
c1734fbd
EZ
77142011-07-23 Eli Zaretskii <eliz@gnu.org>
7715
be18c5a5
EZ
7716 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
7717 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
7718
c1734fbd
EZ
7719 * xdisp.c (move_it_in_display_line_to): Record the best matching
7720 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
7721 exit if none of the characters scanned was an exact match.
7722 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
7723 when exact match is impossible due to invisible text, and the
7724 lines are truncated.
7725
a258d627
JD
77262011-07-23 Jan Djärv <jan.h.d@swipnet.se>
7727
7728 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
7729 for OSX >= 10.7.
7730
b6d5a689
EZ
77312011-07-22 Eli Zaretskii <eliz@gnu.org>
7732
0f74f785
EZ
7733 Fix a significant slow-down of cursor motion with C-n, C-p,
7734 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
7735 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 7736 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
7737 (next_element_from_buffer): Call compute_stop_pos_backwards to
7738 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
7739 base_level_stop.
7740 (reseat): Don't look for prev_stop, as that could mean a very long
7741 run.
7742 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
7743 <cached_disp_overlay_modiff>: Cache for last found display string
7744 position.
551918c1 7745 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
7746 about the same buffer in the same area of character positions, and
7747 the buffer wasn't changed since the time the display string
7748 position was cached.
551918c1 7749
b2d0c91a
EZ
77502011-07-22 Eli Zaretskii <eliz@gnu.org>
7751
7752 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
7753 is an integer, which is important for empty lines. (Bug#9149)
7754
043604ee
CY
77552011-07-22 Chong Yidong <cyd@stupidchicken.com>
7756
7757 * frame.c (Fmodify_frame_parameters): In tty case, update the
7758 default face if necessary (Bug#4238).
7759
da4adb04
CY
77602011-07-21 Chong Yidong <cyd@stupidchicken.com>
7761
7762 * editfns.c (Fstring_to_char): No need to explain what a character
7763 is in the docstring (Bug#6576).
7764
9abd0532
LMI
77652011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7766
7767 * xml.c (parse_region): Make sure we always return a tree.
7768
36881d16
HK
77692011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
7770
7771 * xml.c (parse_region): If a document contains only comments,
7772 return that, too.
7773
1e98674d
LMI
77742011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7775
7776 * xml.c (make_dom): Return comments, too.
7777
590bd467
PE
77782011-07-19 Paul Eggert <eggert@cs.ucla.edu>
7779
7780 Port to OpenBSD.
7781 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
7782 and the surrounding thread.
7783 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
7784 rather than fgets, and retry after EINTR. Otherwise, 'emacs
7785 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
7786 timer goes off.
7787 * s/openbsd.h (BROKEN_SIGIO): Define.
7788 * unexelf.c (unexec) [__OpenBSD__]:
7789 Don't update the .mdebug section of the Alpha COFF symbol table.
7790
f41628b2
LMI
77912011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7792
7793 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
7794 (bug#8460).
7795
b59b67c5
PE
77962011-07-18 Paul Eggert <eggert@cs.ucla.edu>
7797
15e3a074
PE
7798 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
7799 This fixes some race conditions on the permissions of any newly
7800 created file.
7801
41bed37d
PE
7802 * alloc.c (valid_pointer_p): Use pipe, not open.
7803 This fixes some permissions issues when debugging.
7804
b59b67c5
PE
7805 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
7806 If fchown fails to set both uid and gid, try to set just gid,
7807 as that is sometimes allowed. Adjust the file's mode to eliminate
7808 setuid or setgid bits that are inappropriate if fchown fails.
7809
925a6be7
SM
78102011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
7811
7812 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
7813 to compare Lisp_Objects.
7814 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
7815 global_gnutls_log_level, don't mistake it for a Lisp_Object.
7816 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
7817
52968808
AS
78182011-07-17 Andreas Schwab <schwab@linux-m68k.org>
7819
0a6a104b
AS
7820 * lread.c (read_integer): Unread even EOF character.
7821 (read1): Likewise. Properly record start position of symbol.
7822
52968808
AS
7823 * lread.c (read1): Read `#:' as empty uninterned symbol if no
7824 symbol character follows.
7825
9e381cdd
PE
78262011-07-17 Paul Eggert <eggert@cs.ucla.edu>
7827
7828 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
7829 This works around a problem with the previous change to Fcopy_file.
7830 Recent glibc declares fchown with __attribute__((warn_unused_result)),
7831 and without this change, GCC might complain about discarding
7832 fchown's return value.
7833
b5641435
JB
78342011-07-16 Juanma Barranquero <lekktu@gmail.com>
7835
7836 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
7837
a8031457
PE
78382011-07-16 Paul Eggert <eggert@cs.ucla.edu>
7839
7840 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
7841
dd889327
LMI
78422011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
7843
750c33f7
LMI
7844 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
7845 it's used from the C level.
7846
dd889327
LMI
7847 * process.c: Use the same condition for POLL_FOR_INPUT in both
7848 keyboard.c and process.c (bug#1858).
7849
87e86684
LM
78502011-07-09 Lawrence Mitchell <wence@gmx.li>
7851
7852 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
7853 (Fgnutls_boot): Use it.
7854
64348f40
AS
78552011-07-15 Andreas Schwab <schwab@linux-m68k.org>
7856
7857 * doc.c (Fsubstitute_command_keys): Revert last change.
7858
1d698799
LMI
78592011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
7860
f863868c
LMI
7861 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
7862 quotes the next character, and doesn't affect other longer
7863 sequences (bug#8935).
7864
1d698799
LMI
7865 * lread.c (syms_of_lread): Clarify that is isn't only
7866 `eval-buffer' and `eval-defun' that's affected by
7867 `lexical-binding' (bug#8460).
7868
aa4b6df6
EZ
78692011-07-15 Eli Zaretskii <eliz@gnu.org>
7870
7871 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 7872 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 7873
5d856da6
PE
78742011-07-14 Paul Eggert <eggert@cs.ucla.edu>
7875
ad6042bb
PE
7876 Fix minor problems found by static checking.
7877 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
7878 (elsz): Now a signed constant, not a size_t var. We prefer signed
7879 types to unsigned, to avoid integer comparison confusion. Without
7880 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
7881 "cannot optimize loop, the loop counter may overflow", a symptom
7882 of the confusion.
f00bbb22 7883 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
7884 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
7885
6468f31c
LMI
78862011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7887
49080b10
LMI
7888 * search.c (Fre_search_backward): Mention `case-fold-search' in
7889 all the re_search_* functions (bug#8138).
7890
6468f31c
LMI
7891 * keyboard.c (Fopen_dribble_file): Document when the file is
7892 closed (bug#8056).
7893
c965adc5
EZ
78942011-07-14 Eli Zaretskii <eliz@gnu.org>
7895
df9733bf
EZ
7896 * bidi.c (bidi_dump_cached_states): Fix format of displaying
7897 bidi_cache_idx.
7898
0bb23927
EZ
7899 Support bidi reordering of display and overlay strings.
7900 * xdisp.c (compute_display_string_pos)
7901 (compute_display_string_end): Accept additional argument STRING.
7902 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
7903 (reseat_to_string): Initialize bidi_it->string.s and
7904 bidi_it->string.schars.
7905 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
7906 NULL (avoids a crash in bidi_paragraph_init).
7907 Initialize itb.string.lstring.
0bb23927
EZ
7908 (init_iterator): Call bidi_init_it only of a valid
7909 buffer position was specified. Initialize paragraph_embedding to
7910 L2R.
7911 (reseat_to_string): Initialize the bidi iterator.
7912 (display_string): If we need to ignore text properties of
7913 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
7914 original value of -1 will not work with bidi.)
7915 (compute_display_string_pos): First arg is now struct
7916 `text_pos *'; all callers changed. Support display properties on
7917 Lisp strings.
7918 (compute_display_string_end): Support display properties on Lisp
7919 strings.
7920 (init_iterator, reseat_1, reseat_to_string): Initialize the
7921 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
7922 when iterating on a string not from display properties).
640c8776
SM
7923 (compute_display_string_pos, compute_display_string_end):
7924 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
7925 arrow keys.
7926 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
7927 base_level_stop; instead, set base_level_stop to BEGV.
7928 Fixes crashes in vertical-motion.
0bb23927
EZ
7929 (next_element_from_buffer): Improve commentary for when
7930 the iterator is before prev_stop.
7931 (init_iterator): Initialize bidi_p from the default value of
7932 bidi-display-reordering, not from buffer-local value. Use the
7933 buffer-local value only if initializing for buffer iteration.
7934 (handle_invisible_prop): Support invisible properties on strings
7935 that are being bidi-reordered.
7936 (set_iterator_to_next): Support bidi reordering of C strings and
7937 Lisp strings.
7938 (next_element_from_string): Support bidi reordering of Lisp
7939 strings.
7940 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
7941 (display_string): Support display of R2L glyph rows.
7942 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
7943 (init_iterator): Don't initialize it->bidi_p for strings
7944 here.
7945 (reseat_to_string): Initialize it->bidi_p for strings here.
7946 (next_element_from_string, next_element_from_c_string)
7947 (next_element_from_buffer): Add xassert's for correspondence
7948 between IT's object being iterated and it->bidi_it.string
7949 structure.
7950 (face_before_or_after_it_pos): Support bidi iteration.
7951 (next_element_from_c_string): Handle the case of the first string
7952 character that is not the first one in the visual order.
7953 (get_visually_first_element): New function, refactored from common
7954 parts of next_element_from_buffer, next_element_from_string, and
7955 next_element_from_c_string.
7956 (tool_bar_lines_needed, redisplay_tool_bar)
7957 (display_menu_bar): Force left-to-right direction. Add a FIXME
7958 comment for making that be controlled by a user option.
7959 (push_it, pop_it): Save and restore the state of the
7960 bidi iterator. Save and restore the bidi_p flag.
7961 (pop_it): Iterate out of display property for string iteration as
7962 well.
7963 (iterate_out_of_display_property): Support iteration over strings.
7964 (handle_single_display_spec): Set up it->bidi_it for iteration
7965 over a display string, and call bidi_init_it.
7966 (handle_single_display_spec, next_overlay_string)
7967 (get_overlay_strings_1, push_display_prop): Set up the bidi
7968 iterator for displaying display or overlay strings.
7969 (forward_to_next_line_start): Don't use the shortcut if
7970 bidi-iterating.
7971 (back_to_previous_visible_line_start): If handle_display_prop
7972 pushed the iterator stack, restore the internal state of the bidi
7973 iterator by calling bidi_pop_it same number of times.
7974 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
7975 and we are bidi-iterating, don't decrement the iterator position;
7976 instead, set the first_elt flag in the bidi iterator, to produce
7977 the same effect.
7978 (reseat_1): Remove redundant setting of string_from_display_prop_p.
7979 (push_display_prop): xassert that we are iterating a buffer.
7980 (push_it, pop_it): Save and restore paragraph_embedding member.
7981 (handle_single_display_spec, next_overlay_string)
7982 (get_overlay_strings_1, reseat_1, reseat_to_string)
7983 (push_display_prop): Set up the `unibyte' member of bidi_it.string
7984 correctly. Don't assume unibyte strings are not bidi-reordered.
7985 (compute_display_string_pos)
7986 (compute_display_string_end): Fix handling the case of C string.
7987 (push_it, pop_it): Save and restore from_disp_prop_p.
7988 (handle_single_display_spec, push_display_prop): Set the
7989 from_disp_prop_p flag.
7990 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
7991 (pop_it): Call iterate_out_of_display_property only if we are
7992 popping after iteration over a string that came from a display
7993 property. Fix a typo in popping stretch info. Add an assertion
7994 for verifying that the iterator position is in sync with the bidi
7995 iterator.
7996 (handle_single_display_spec, get_overlay_strings_1)
7997 (push_display_prop): Fix initialization of paragraph direction for
7998 string when that of the parent object is not yet determined.
7999 (reseat_1): Call bidi_init_it to resync the bidi
8000 iterator with IT's position. (Bug#7616)
8001 (find_row_edges): If ROW->start.pos gives position
8002 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
8003 (handle_stop, back_to_previous_visible_line_start, reseat_1):
8004 Reset the from_disp_prop_p flag.
8005 (SAVE_IT, RESTORE_IT): New macros.
8006 (pos_visible_p, face_before_or_after_it_pos)
8007 (back_to_previous_visible_line_start)
8008 (move_it_in_display_line_to, move_it_in_display_line)
8009 (move_it_to, move_it_vertically_backward, move_it_by_lines)
8010 (try_scrolling, redisplay_window, display_line): Use them when
8011 saving a temporary copy of the iterator and restoring it back.
8012 (back_to_previous_visible_line_start, reseat_1)
8013 (init_iterator): Empty the bidi cache "stack".
8014 (move_it_in_display_line_to): If iterator ended up at
8015 EOL, but we never saw any buffer positions smaller than
8016 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
8017 motion in bidi-reordered lines.
8018 (move_it_in_display_line_to): Record prev_method and prev_pos
8019 immediately before the call to set_iterator_to_next. Fixes cursor
8020 motion in bidi-reordered lines with stretch glyphs and strings
8021 displayed in margins. (Bug#8133) (Bug#8867)
8022 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
8023 TO_CHARPOS.
640c8776
SM
8024 (pos_visible_p): Support positions in bidi-reordered lines.
8025 Save and restore bidi cache.
0bb23927
EZ
8026
8027 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
8028 (bidi_paragraph_info): Delete unused struct.
8029 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
8030 (bidi_cache_start): New variable.
8031 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
8032 to zero.
8033 (bidi_cache_fetch_state, bidi_cache_search)
8034 (bidi_cache_find_level_change, bidi_cache_iterator_state)
8035 (bidi_cache_find, bidi_peek_at_next_level)
8036 (bidi_level_of_next_char, bidi_find_other_level_edge)
8037 (bidi_move_to_visually_next): Compare cache index with
8038 bidi_cache_start rather than with zero.
8039 (bidi_fetch_char): Accept new argument STRING; all callers
8040 changed. Support iteration over a string. Support strings with
8041 display properties. Support unibyte strings. Fix the type of
8042 `len' according to what STRING_CHAR_AND_LENGTH expects.
8043 (bidi_paragraph_init, bidi_resolve_explicit_1)
8044 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
8045 (bidi_level_of_next_char, bidi_move_to_visually_next):
8046 Support iteration over a string.
0bb23927
EZ
8047 (bidi_set_sor_type, bidi_resolve_explicit_1)
8048 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
8049 can now be zero (for strings); special values 0 and -1 were
8050 changed to -1 and -2, respectively.
8051 (bidi_char_at_pos): New function.
8052 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
8053 Call it instead of FETCH_MULTIBYTE_CHAR.
8054 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
8055 initialized to valid values.
8056 (bidi_init_it): Don't initialize charpos and bytepos with invalid
8057 values.
8058 (bidi_level_of_next_char): Allow the sentinel "position" to pass
8059 the test for valid cached positions. Fix the logic for looking up
8060 the sentinel state in the cache. GCPRO the Lisp string we are
8061 iterating.
8062 (bidi_push_it, bidi_pop_it): New functions.
8063 (bidi_initialize): Initialize the bidi cache start stack pointer.
8064 (bidi_cache_ensure_space): New function, refactored from part of
8065 bidi_cache_iterator_state. Don't assume the required size is just
8066 one BIDI_CACHE_CHUNK away.
8067 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
8068 (bidi_count_bytes, bidi_char_at_pos): New functions.
8069 (bidi_cache_search): Don't assume bidi_cache_last_idx is
8070 always valid if bidi_cache_idx is valid.
8071 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
8072 is valid if it's going to be used.
8073 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
8074 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
8075 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8076 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
8077 (bidi_find_other_level_edge, bidi_cache_start_stack):
8078 All variables related to cache indices are now EMACS_INT.
c965adc5 8079
0bb23927
EZ
8080 * dispextern.h (struct bidi_string_data): New structure.
8081 (struct bidi_it): New member `string'. Make flag members be 1-bit
8082 fields, and put them last in the struct.
640c8776
SM
8083 (compute_display_string_pos, compute_display_string_end):
8084 Update prototypes.
0bb23927
EZ
8085 (bidi_push_it, bidi_pop_it): Add prototypes.
8086 (struct iterator_stack_entry): New members bidi_p,
8087 paragraph_embedding, and from_disp_prop_p.
8088 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
8089 (bidi_shelve_cache, bidi_unshelve_cache):
8090 Declare prototypes.
0bb23927
EZ
8091
8092 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
8093 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
8094 and vector-like objects.
8095
8096 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
8097 cache around display iteration.
8098
8099 * window.c (Fwindow_end, window_scroll_pixel_based)
8100 (displayed_window_lines, Frecenter): Save and restore the bidi
8101 cache around display iteration.
8102
3bbd2265
LMI
81032011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8104
8105 * editfns.c (Fdelete_region): Clarify the use of the named
8106 parameters (bug#6788).
8107
adc47434
MR
81082011-07-14 Martin Rudalics <rudalics@gmx.at>
8109
8110 * indent.c (Fvertical_motion): Set and restore w->pointm when
8111 saving and restoring the window's buffer (Bug#9006).
8112
837c31f8
LMI
81132011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
8114
8115 * editfns.c (Fstring_to_char): Clarify just what is returned
8116 (bug#6576). Text by Eli Zaretskii.
8117
ac389d0c
JB
81182011-07-13 Juanma Barranquero <lekktu@gmail.com>
8119
8120 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
8121
0be0ce47
EZ
81222011-07-13 Eli Zaretskii <eliz@gnu.org>
8123
8124 * buffer.c (mmap_find): Fix a typo.
8125
cd18e7e3
JB
81262011-07-13 Johan Bockgård <bojohan@gnu.org>
8127
8128 Fix execution of x selection hooks.
8129 * xselect.c (Qx_lost_selection_functions)
8130 (Qx_sent_selection_functions): New vars.
8131 (syms_of_xselect): DEFSYM them.
8132 (x_handle_selection_request): Pass Qx_sent_selection_functions
8133 rather than Vx_sent_selection_functions to Frun_hook_with_args.
8134 (x_handle_selection_clear,x_clear_frame_selections):
8135 Pass Qx_lost_selection_functions rather than
8136 Vx_lost_selection_functions to Frun_hook_with_args.
8137
47ea7f44
PE
81382011-07-13 Paul Eggert <eggert@cs.ucla.edu>
8139
ac389d0c 8140 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
8141 The old code sometimes used this field without initializing it.
8142
47ea7f44
PE
8143 * alloc.c (gc_sweep): Don't read past end of array.
8144 In theory, the old code could also have corrupted Emacs internals,
8145 though it'd be very unlikely.
8146
bc985c87
AS
81472011-07-12 Andreas Schwab <schwab@linux-m68k.org>
8148
8149 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 8150 argument. (Bug#4026)
bc985c87 8151
0cf34688
LMI
81522011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
8153
b3dadd76
LMI
8154 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
8155 key" (bug#4257).
8156
0cf34688
LMI
8157 * window.c (Fset_window_start): Doc fix (bug#4199).
8158 (Fset_window_hscroll): Ditto.
8159
270768cd
PE
81602011-07-12 Paul Eggert <eggert@cs.ucla.edu>
8161
077e3dda 8162 Fix minor new problems caught by GCC 4.6.1.
270768cd 8163 * term.c (init_tty): Remove unused local.
490011a6 8164 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 8165 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 8166 not used otherwise.
270768cd 8167
b1f58454
CY
81682011-07-12 Chong Yidong <cyd@stupidchicken.com>
8169
8170 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
8171
22b9578d
LMI
81722011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
8173
6e70ab07
LMI
8174 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
8175 are the mini-buffer and the echo area (bug#3320).
8176
22b9578d
LMI
8177 * term.c (init_tty): Remove support for supdup, c10 and perq
8178 terminals, which are no longer supported (bug#1482).
8179
8974cc9f
JB
81802011-07-10 Johan Bockgård <bojohan@gnu.org>
8181
8182 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
8183
a560d974
JD
81842011-07-10 Jan Djärv <jan.h.d@swipnet.se>
8185
8186 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
8187 for non-popups (Bug#3642).
8188
1dae0f0a
AS
81892011-07-10 Andreas Schwab <schwab@linux-m68k.org>
8190
268c2c36 8191 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 8192 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
8193 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
8194 * cm.c (losecursor): Likewise.
1dae0f0a
AS
8195 * data.c (fmod): Likewise.
8196 * dispnew.c (swap_glyphs_in_rows): Likewise.
8197 * emacs.c (memory_warning_signal): Likewise.
8198 * floatfns.c (float_error): Likewise.
8199 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
8200 (otf_open, font_otf_capability, generate_otf_features)
8201 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
8202 Likewise.
8203 * image.c (pbm_read_file): Likewise.
8204 * indent.c (string_display_width): Likewise.
8205 * intervals.c (check_for_interval, search_for_interval)
8206 (inc_interval_count, count_intervals, root_interval)
8207 (adjust_intervals_for_insertion, make_new_interval): Likewise.
8208 * lread.c (defalias): Likewise.
268c2c36 8209 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
8210 * regex.c (set_image_of_range_1, set_image_of_range)
8211 (regex_grow_registers): Likewise.
8212 * sysdep.c (strerror): Likewise.
8213 * termcap.c (valid_filename_p, tprint, main): Likewise.
8214 * tparam.c (main): Likewise.
8215 * unexhp9k800.c (run_time_remap, save_data_space)
8216 (update_file_ptrs, read_header, write_header, calculate_checksum)
8217 (copy_file, copy_rest, display_header): Likewise.
8218 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
8219 Likewise.
8220 * xdisp.c (check_it): Likewise.
8221 * xfaces.c (register_color, unregister_color, unregister_colors):
8222 Likewise.
8223 * xfns.c (print_fontset_result): Likewise.
8224 * xrdb.c (member, fatal, main): Likewise.
8225
99033785
PE
82262011-07-10 Paul Eggert <eggert@cs.ucla.edu>
8227
8228 Fix minor problems found by static checking (Bug#9031).
8229 * chartab.c (char_table_set_range, map_sub_char_table):
8230 Remove unused locals.
8231 (uniprop_table): Now static.
8232 * composite.c (_work_char): Remove unused static var.
8233
9cb2ac56
JB
82342011-07-09 Juanma Barranquero <lekktu@gmail.com>
8235
8236 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
8237
f25661f0
JD
82382011-07-09 Jan Djärv <jan.h.d@swipnet.se>
8239
8240 * gtkutil.c (qttip_cb): Remove code without function.
8241
8278c4fe
EZ
82422011-07-09 Eli Zaretskii <eliz@gnu.org>
8243
8244 * w32.c (pthread_sigmask): New stub.
8245
1692ae2d 82462011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 8247
8a6ebd58 8248 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
8249 sigprocmask is portable only for single-threaded applications, and
8250 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
8251 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
8252 (LIBES): Use it.
8253 * callproc.c (Fcall_process):
8254 * process.c (create_process):
8255 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
8256 Use pthread_sigmask, not sigprocmask.
123403e4 8257
1b854618
JD
82582011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8259
8260 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
8261 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
8262 wrong (Bug#8591).
8263
3fe4b549
JD
82642011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8265
0ce7e563
JD
8266 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
8267 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
8268 (xg_hide_tooltip): Fix comment.
8269
3fe4b549
JD
8270 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
8271 in registerServicesMenuSendTypes.
8272 (validRequestorForSendType): Don't check ns_return_types.
8273
8274 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
8275 ns_return_type.
8276
5df75e47
JR
82772011-07-08 Jason Rumney <jasonr@gnu.org>
8278
22610910
JR
8279 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
8280 SH_SHOW for hidden windows (Bug#5482).
8281
5df75e47
JR
8282 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
8283 frame struct members of non-existent frames (Bug#6284).
8284
699c10bd
JD
82852011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8286
4393663b
JD
8287 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
8288 variable firstTime not needed on OSX >= 10.6.
8289 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
8290 >= 10.5. Use setKnobProportion, setDoubleValue.
8291
8292 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
8293 (MAC_OS_X_VERSION_10_5): Define if not defined.
8294 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
8295 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
8296 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
8297
8298 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 8299 cString and lossyCString on OSX >= 10.4.
4393663b 8300
58179cce 8301 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
8302 sizeToFit on OSX >= 10.2.
8303
8304 * nsimage.m (allocInitFromFile): Don't use deprecated method
8305 bestRepresentationForDevice on OSX >= 10.6.
8306
8307 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
8308 to avoid warning.
8309
8310 * emacs.c: Declare unexec_init_emacs_zone.
8311
a63e0781
JD
8312 * nsgui.h: Fix compiler warning about gnulib redefining verify.
8313
699c10bd
JD
8314 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
8315
8316 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
8317 on svcsMenu (Bug#8842).
8318
8319 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
8320 ns_return_types.
8321 (Fns_list_services): Just return Qnil on 10.6, code not working there.
8322
8323 * nsterm.m (QUTF8_STRING): Declare.
8324 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
8325 (validRequestorForSendType): Return type is (id).
8326 Change indexOfObjectIdenticalTo to indexOfObject.
8327 Check if we have local selection before returning self (Bug#8842).
8328 (writeSelectionToPasteboard): Put local selection into paste board
8329 if we have a local selection (Bug#8842).
8330 (syms_of_nsterm): DEFSYM QUTF8_STRING.
8331
8332 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
8333 (ns_get_local_selection): Declare.
8334
54e10184
LMI
83352011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
8336
9888ff71
LMI
8337 * keymap.c (describe_map_tree): Don't insert a double newline at
8338 the end of the buffer (bug#1169) and return whether we inserted
8339 something.
8340
54e10184
LMI
8341 * callint.c (Fcall_interactively): Change "reading args" to
8342 "providing args" to try to clarify what it does (bug#1010).
8343
15fa4783
KH
83442011-07-07 Kenichi Handa <handa@m17n.org>
8345
8346 * composite.c (composition_compute_stop_pos): Ignore a static
8347 composition starting before CHARPOS (Bug#8915).
8348
8349 * xdisp.c (handle_composition_prop): Likewise.
8350
a8815b00
EZ
83512011-07-07 Eli Zaretskii <eliz@gnu.org>
8352
8353 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
8354 (Bug#9015)
8355
ef7b981d 83562011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
8357
8358 * character.h (unicode_category_t): New enum type.
8359
8360 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
8361 (Qchar_code_property_table): New variable.
8362 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
8363 (UNIPROP_COMPRESSED_FORM_P): New macros.
8364 (char_table_ascii): Uncompress the compressed values.
8365 (sub_char_table_ref): New arg is_uniprop. Callers changed.
8366 Uncompress the compressed values.
ac389d0c 8367 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
8368 (char_table_ref_and_range): Uncompress the compressed values.
8369 (sub_char_table_set): New arg is_uniprop. Callers changed.
8370 Uncompress the compressed values.
8371 (sub_char_table_set_range): Args changed. Callers changed.
8372 (char_table_set_range): Adjuted for the above change.
8373 (map_sub_char_table): Delete args default_val and parent. Add arg
8374 top. Give decoded values to a Lisp function.
640c8776 8375 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
8376 values to a Lisp function. Gcpro more variables.
8377 (uniprop_table_uncompress)
8378 (uniprop_decode_value_run_length): New functions.
8379 (uniprop_decoder, uniprop_decoder_count): New variables.
8380 (uniprop_get_decoder, uniprop_encode_value_character)
8381 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
8382 New functions.
8383 (uniprop_encoder, uniprop_encoder_count): New variables.
8384 (uniprop_get_encoder, uniprop_table)
8385 (Funicode_property_table_internal, Fget_unicode_property_internal)
8386 (Fput_unicode_property_internal): New functions.
8387 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
8388 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 8389 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
8390 char-code-property-alist.
8391
640c8776 8392 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
8393 Vunicode_category_table.
8394
640c8776 8395 * font.c (font_range): Adjust for the change of
c805dec0
KH
8396 Vunicode_category_table.
8397
76b397fb
DN
83982011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
8399
8400 * m/iris4d.h: Remove file, move contents ...
8401 * s/irix6-5.h: ... here.
8402
22b4128e
PE
84032011-07-06 Paul Eggert <eggert@cs.ucla.edu>
8404
8405 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
8406 * alloc.c (mark_buffer):
8407 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
8408 (clone_per_buffer_values): Don't assume that
22b4128e
PE
8409 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
8410 This isn't true in general, and it's particularly not true
8411 if Emacs is configured with --with-wide-int.
8412 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
8413 New macros, used in the buffer.c change.
8414
869795d6
JD
84152011-07-05 Jan Djärv <jan.h.d@swipnet.se>
8416
8417 * xsettings.c: Use both GConf and GSettings if both are available.
8418 (store_config_changed_event): Add comment.
8419 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
8420 (store_tool_bar_style_changed): New functions.
5e617bc2 8421 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
8422 (struct xsettings): Move font inside HAVE_XFT.
8423 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 8424 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 8425 Move inside HAVE_XFT.
640c8776 8426 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
8427 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
8428 also.
8429 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 8430 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 8431 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
8432 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
8433 (parse_settings): Move check for font inside HAVE_XFT.
8434 (read_settings, apply_xft_settings): Add comment.
8435 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
8436 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
8437 call store_font_name_changed.
8438 (xft_settings_event): Add comment.
8439 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
8440 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
8441 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
8442 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
8443 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
8444 (xsettings_get_system_font, xsettings_get_system_normal_font):
8445 Add comment.
869795d6 8446
d8ed26bd
PE
84472011-07-05 Paul Eggert <eggert@cs.ucla.edu>
8448
8449 Random fixes. E.g., (random) never returned negative values.
8450 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
8451 subseconds part to the entropy, as that's a bit more random.
8452 Prefer signed to unsigned, since the signedness doesn't matter and
8453 in general we prefer signed. When given a limit, use a
8454 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
8455 latter isn't right if USE_2_TAGS_FOR_INTS.
8456 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
8457 not 0..VALMASK. Don't discard "excess" bits that random () returns.
8458
cabf1cac
SM
84592011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
8460
8461 * textprop.c (text_property_stickiness):
8462 Obey Vtext_property_default_nonsticky.
8463 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
8464 * w32fns.c (syms_of_w32fns):
8465 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
8466
6e9b2be9
PE
84672011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8468
8469 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
8470 This is more efficient than Ffile_directory_p and avoids a minor race.
8471
90186c68
LMI
84722011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
8473
7c301272
LMI
8474 * buffer.c (Foverlay_put): Say what the return value is
8475 (bug#7835).
8476
c4f2d8d4
LMI
8477 * fileio.c (barf_or_query_if_file_exists): Check first if the file
8478 is a directory before asking whether to use the file name
8479 (bug#7564).
ad637907
LMI
8480 (barf_or_query_if_file_exists): Make the "File is a directory"
8481 error be more correct.
c4f2d8d4 8482
90186c68
LMI
8483 * fns.c (Frequire): Remove the mention of the .gz files, since
8484 that's installation-specific, but keep the mention of
8485 `get-load-suffixes'.
8486
da64016e
PE
84872011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8488
8489 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
8490 Report string overflow if the output is too long.
8491
7d47b580
JB
84922011-07-04 Juanma Barranquero <lekktu@gmail.com>
8493
a555cb87
JB
8494 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
8495 (syms_of_gnutls): Remove duplicate DEFSYM for
8496 Qgnutls_bootprop_verify_hostname_error, an error for
8497 Qgnutls_bootprop_verify_error (which is no longer used).
8498
7d47b580
JB
8499 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
8500 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
8501 Also (re)move comments that are misplaced or no longer relevant.
8502
1e49bfab
LMI
85032011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8504
8505 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
8506
1485f4c0
CY
85072011-07-03 Chong Yidong <cyd@stupidchicken.com>
8508
8509 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
8510 and background color parameters if they have been changed.
8511
a9ab721e
LMI
85122011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8513
8514 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
8515
cf7cff57
PE
85162011-07-03 Paul Eggert <eggert@cs.ucla.edu>
8517
2e13213d
PE
8518 * xsettings.c (SYSTEM_FONT): Define only when used.
8519 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
8520
cf7cff57
PE
8521 * keymap.c (access_keymap_1): Now static.
8522
7a8e04f7
CY
85232011-07-02 Chong Yidong <cyd@stupidchicken.com>
8524
8525 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
8526 leave any prefix arg for the up event (Bug#1586).
8527
61352f62
LMI
85282011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
8529
69bb1ef7
LMI
8530 * lread.c (syms_of_lread): Mention single symbols defined by
8531 `defvar' or `defconst' (bug#7154).
8532
61352f62 8533 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 8534 (Frequire): Mention get-load-suffixes.
61352f62 8535
28545e04
MR
85362011-07-02 Martin Rudalics <rudalics@gmx.at>
8537
8538 * window.h (window): Remove clone_number slot.
8539 * window.c (Fwindow_clone_number, Fset_window_clone_number):
8540 Remove.
8541 (make_parent_window, make_window, saved_window)
8542 (Fset_window_configuration, save_window_save): Don't deal with
8543 clone numbers.
8544 * buffer.c (Qclone_number): Remove declaration.
8545 (sort_overlays, overlay_strings): Don't deal with clone numbers.
8546
3349e122
SM
85472011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
8548
8549 Add multiple inheritance to keymaps.
8550 * keymap.c (Fmake_composed_keymap): New function.
8551 (Fset_keymap_parent): Simplify.
8552 (fix_submap_inheritance): Remove.
8553 (access_keymap_1): New function extracted from access_keymap to handle
8554 embedded parents and handle lists of maps.
8555 (access_keymap): Use it.
8556 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
8557 (Fcopy_keymap): Handle embedded parents.
8558 (Fcommand_remapping, define_as_prefix): Simplify.
8559 (Fkey_binding): Simplify.
8560 (syms_of_keymap): Move minibuffer-local-completion-map,
8561 minibuffer-local-filename-completion-map,
8562 minibuffer-local-must-match-map, and
8563 minibuffer-local-filename-must-match-map to Elisp.
8564 (syms_of_keymap): Defsubr make-composed-keymap.
8565 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
8566 (parse_menu_item): Trivial simplification.
8567
3279eb87
GM
85682011-07-01 Glenn Morris <rgm@gnu.org>
8569
8570 * Makefile.in (SETTINGS_LIBS): Fix typo.
8571
4550efdf
KI
85722011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
8573
8574 * coding.c (Fencode_coding_string): Record the last coding system
8575 used, as the function doc string says (bug#8738).
8576
0949d2b6
JD
85772011-07-01 Jan Djärv <jan.h.d@swipnet.se>
8578
8579 * xsettings.c (store_monospaced_changed): Take new font as arg and
8580 check for change against current_mono_font.
8581 (EMACS_TYPE_SETTINGS): Remove this and related defines.
8582 (emacs_settings_constructor, emacs_settings_get_property)
8583 (emacs_settings_set_property, emacs_settings_class_init)
8584 (emacs_settings_init, gsettings_obj): Remove.
8585 (something_changedCB): New function for HAVE_GSETTINGS.
8586 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
8587 with value as argument.
8588 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
8589 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 8590 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
8591 "changed".
8592
8593 * xgselect.c: Add defined (HAVE_GSETTINGS).
8594 (xgselect_initialize): Ditto.
8595
8596 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
8597 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
8598 xg_select.
8599
bbc6b304
PE
86002011-07-01 Paul Eggert <eggert@cs.ucla.edu>
8601
8602 * eval.c (struct backtrace): Simplify and port the data structure.
8603 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
8604 signed bit field, as this assumption is not portable and it makes
8605 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
8606 "char debug_on_exit : 1" as this is not portable either; instead,
8607 use the portable "unsigned int debug_on_exit : 1". Remove unused
8608 member evalargs. Remove obsolete comments about cc bombing out.
8609
9851bfc5
JD
86102011-06-30 Jan Djärv <jan.h.d@swipnet.se>
8611
51bb811f 8612 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
8613 Let HAVE_GSETTINGS override HAVE_GCONF.
8614 (store_monospaced_changed): New function.
8615 (EMACS_SETTINGS): A new type derived from GObject to handle
8616 GSettings notifications.
8617 (emacs_settings_constructor, emacs_settings_get_property)
8618 (emacs_settings_set_property, emacs_settings_class_init):
8619 New functions.
8620 (gsettings_client, gsettings_obj): New variables.
8621 (GSETTINGS_SCHEMA): New define.
8622 (something_changedCB): Call store_monospaced_changed.
8623 (init_gsettings): New function.
8624 (xsettings_initialize): Call init_gsettings.
8625 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
8626 to NULL.
8627
640c8776 8628 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
8629 GCONF_CFLAGS/LIBS.
8630
5386012d
MR
86312011-06-29 Martin Rudalics <rudalics@gmx.at>
8632
8633 * window.c (resize_root_window, grow_mini_window)
8634 (shrink_mini_window): Rename Qresize_root_window to
8635 Qwindow_resize_root_window and Qresize_root_window_vertically to
8636 Qwindow_resize_root_window_vertically.
8637
f13e0b08
PE
86382011-06-28 Paul Eggert <eggert@cs.ucla.edu>
8639
8640 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
8641
94515237
JB
86422011-06-27 Juanma Barranquero <lekktu@gmail.com>
8643
8644 * makefile.w32-in: Redesign dependencies so they reflect more
8645 clearly which files are directly included by each source file,
8646 and not through other includes.
8647
e43b6e43
MR
86482011-06-27 Martin Rudalics <rudalics@gmx.at>
8649
8650 * buffer.c (Qclone_number): Declare static and DEFSYM it.
8651 (sort_overlays, overlay_strings): When an overlay's clone number
8652 matches the window's clone number process the overlay even if
8653 the overlay's window property doesn't match the current window.
8654
d68443dc
MR
8655 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
8656 (Fwindow_hchild): Rename to Fwindow_left_child.
8657 (Fwindow_next): Rename to Fwindow_next_sibling.
8658 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
8659 (resize_window_check): Rename to window_resize_check.
8660 (resize_window_apply): Rename to window_resize_apply.
8661 (Fresize_window_apply): Rename to Fwindow_resize_apply.
8662 (Fdelete_other_windows_internal, resize_frame_windows)
8663 (Fsplit_window_internal, Fdelete_window_internal)
8664 (grow_mini_window, shrink_mini_window)
8665 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 8666
c7e73be5
JD
86672011-06-26 Jan Djärv <jan.h.d@swipnet.se>
8668
8669 * emacsgtkfixed.h: State that this is only used with Gtk+3.
8670 (emacs_fixed_set_min_size): Remove.
8671 (emacs_fixed_new): Take frame as argument.
8672
8673 * emacsgtkfixed.c: State that this is only used with Gtk+3.
8674 (_EmacsFixedPrivate): Remove minwidth/height.
8675 Add struct frame *f.
8676 (emacs_fixed_init): Initialize priv->f.
8677 (get_parent_class, emacs_fixed_set_min_size): Remove.
8678 (emacs_fixed_new): Set priv->f to argument.
8679 (emacs_fixed_get_preferred_width)
8680 (emacs_fixed_get_preferred_height): Use min_width/height from
8681 frames size_hint to set minimum and natural (Bug#8919).
8682 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
8683 and use min_width/height from frames size_hint to set
8684 min_width/height (Bug#8919).
8685
8686 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
8687 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
8688 Fix indentation.
c7e73be5 8689
cf99dcf8
EZ
86902011-06-26 Eli Zaretskii <eliz@gnu.org>
8691
8692 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
8693 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
8694 called at ZV.
8695
029529ac
CY
86962011-06-26 Chong Yidong <cyd@stupidchicken.com>
8697
8698 * process.c (wait_reading_process_output): Bypass select if
8699 waiting for a cell while ignoring keyboard input, and input is
8700 pending. Suggested by Jan Djärv (Bug#8869).
8701
7a7ef429
PE
87022011-06-25 Paul Eggert <eggert@cs.ucla.edu>
8703
8704 Use gnulib's dup2 module instead of rolling our own.
8705 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
8706
11fdef7d 87072011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
8708
8709 * dispnew.c (scrolling_window): Before scrolling, turn off a
8710 mouse-highlight in the window being scrolled.
8711
cd3520a4
JB
87122011-06-24 Juanma Barranquero <lekktu@gmail.com>
8713
8714 Move DEFSYM to lisp.h and use everywhere.
8715
8716 * character.h (DEFSYM): Move declaration...
8717 * lisp.h (DEFSYM): ...here.
8718
8719 * gnutls.c:
8720 * minibuf.c:
8721 * w32menu.c:
8722 * w32proc.c:
8723 * w32select.c: Don't include character.h.
8724
8725 * alloc.c (syms_of_alloc):
8726 * buffer.c (syms_of_buffer):
8727 * bytecode.c (syms_of_bytecode):
8728 * callint.c (syms_of_callint):
8729 * casefiddle.c (syms_of_casefiddle):
8730 * casetab.c (init_casetab_once):
8731 * category.c (init_category_once, syms_of_category):
8732 * ccl.c (syms_of_ccl):
8733 * cmds.c (syms_of_cmds):
8734 * composite.c (syms_of_composite):
8735 * dbusbind.c (syms_of_dbusbind):
8736 * dired.c (syms_of_dired):
8737 * dispnew.c (syms_of_display):
8738 * doc.c (syms_of_doc):
8739 * editfns.c (syms_of_editfns):
8740 * emacs.c (syms_of_emacs):
8741 * eval.c (syms_of_eval):
8742 * fileio.c (syms_of_fileio):
8743 * fns.c (syms_of_fns):
8744 * frame.c (syms_of_frame):
8745 * fringe.c (syms_of_fringe):
8746 * insdel.c (syms_of_insdel):
8747 * keymap.c (syms_of_keymap):
8748 * lread.c (init_obarray, syms_of_lread):
8749 * macros.c (syms_of_macros):
8750 * msdos.c (syms_of_msdos):
8751 * print.c (syms_of_print):
8752 * process.c (syms_of_process):
8753 * search.c (syms_of_search):
8754 * sound.c (syms_of_sound):
8755 * syntax.c (init_syntax_once, syms_of_syntax):
8756 * terminal.c (syms_of_terminal):
8757 * textprop.c (syms_of_textprop):
8758 * undo.c (syms_of_undo):
8759 * w32.c (globals_of_w32):
8760 * window.c (syms_of_window):
8761 * xdisp.c (syms_of_xdisp):
8762 * xfaces.c (syms_of_xfaces):
8763 * xfns.c (syms_of_xfns):
8764 * xmenu.c (syms_of_xmenu):
8765 * xsettings.c (syms_of_xsettings):
8766 * xterm.c (syms_of_xterm): Use DEFSYM.
8767
4228cf16
TZ
87682011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
8769
cd3520a4 8770 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 8771
7fcccf1e
PE
87722011-06-23 Paul Eggert <eggert@cs.ucla.edu>
8773
7efb4e0e
PE
8774 Integer and buffer overflow fixes (Bug#8873).
8775
ff5844ad
PE
8776 * print.c (printchar, strout): Check for string overflow.
8777 (PRINTPREPARE, printchar, strout):
8778 Don't set size unless allocation succeeds.
8779
90532f02
PE
8780 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
8781 for sizes. Check for string overflow more accurately.
8782 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
8783
6d84508d
PE
8784 * macros.c: Integer and buffer overflow fixes.
8785 * keyboard.h (struct keyboard.kbd_macro_bufsize):
8786 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
8787 Use ptrdiff_t, not int, for sizes.
8788 Don't increment bufsize until after realloc succeeds.
8789 Check for size-calculation overflow.
8790 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
8791
437b2cb4
PE
8792 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
8793
8b9ac8b4
PE
8794 * lread.c: Integer overflow fixes.
8795 (read_integer): Radix is now EMACS_INT, not int,
8796 to improve quality of diagnostics for out-of-range radices.
8797 Calculate buffer size correctly for out-of-range radices.
8798 (read1): Check for integer overflow in radices, and in
8799 read-circle numbers.
82cb60d3
PE
8800 (read_escape): Avoid int overflow.
8801 (Fload, openp, read_buffer_size, read1)
8802 (substitute_object_recurse, read_vector, read_list, map_obarray):
8803 Use ptrdiff_t, not int, for sizes.
8804 (read1): Use EMACS_INT, not int, for sizes.
20270765 8805 Check for size overflow.
8b9ac8b4 8806
7fcccf1e
PE
8807 * image.c (cache_image): Check for size arithmetic overflow.
8808
bfbbd7e7
PE
8809 * lread.c: Integer overflow issues.
8810 (saved_doc_string_size, saved_doc_string_length)
8811 (prev_saved_doc_string_size, prev_saved_doc_string_length):
8812 Now ptrdiff_t, not int.
8813 (read1): Don't assume doc string length fits in int. Check for
8814 out-of-range doc string lengths.
8815 (read_list): Don't assume file position fits in int.
39019e54 8816 (read_escape): Check for hex character overflow.
bfbbd7e7 8817
4e323265
LL
88182011-06-22 Leo Liu <sdl.web@gmail.com>
8819
8820 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
8821 Move to minibuffer.el.
8822
85fece3e
PE
88232011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8824
20b84ce9 8825 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
8826 The following patches are for when GLYPH_DEBUG && !XASSERT.
8827 * dispextern.h (trace_redisplay_p, dump_glyph_string):
8828 * dispnew.c (flush_stdout):
8829 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
8830 Mark as externally visible.
8831 * dispnew.c (check_window_matrix_pointers): Now static.
8832 * dispnew.c (window_to_frame_vpos):
8833 * xfns.c (unwind_create_frame):
8834 * xterm.c (x_check_font): Remove unused local.
8835 * scroll.c (CHECK_BOUNDS):
8836 * xfaces.c (cache_fache): Rename local to avoid shadowing.
8837 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
8838 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
8839 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
8840 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
8841 Now static.
8842 (debug_method_add): Use va_list and vsprintf rather than relying
8843 on undefined behavior with wrong number of arguments.
8844 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
8845 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
8846 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
8847 since we're not interested in debugging glyphs with old libraries.
8848 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
8849 GCC 4.6.0's static checking.
8850
0766b489
PE
88512011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8852
31fd4b32
PE
8853 Integer overflow and signedness fixes (Bug#8873).
8854 A few related buffer overrun fixes, too.
8855
b79e8648
PE
8856 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
8857
0766b489
PE
8858 * dispextern.h (struct face.stipple):
8859 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
8860 (x_bitmap_mask, x_allocate_bitmap_record)
8861 (x_create_bitmap_from_data, x_create_bitmap_from_file)
8862 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
8863 (x_create_bitmap_from_xpm_data):
8864 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
8865 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
8866 (.bitmaps_last):
8867 * xfaces.c (load_pixmap):
8868 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
8869 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
8870 (.bitmaps_last, struct x_output.icon_bitmap):
8871 Use ptrdiff_t, not int, for bitmap indexes.
8872 (x_allocate_bitmap_record): Check for size overflow.
8873 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
8874
b081724f
PE
8875 Use ptrdiff_t, not int, for overlay counts.
8876 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
8877 * editfns.c (overlays_around, get_pos_property):
8878 * textprop.c (get_char_property_and_overlay):
8879 * xdisp.c (next_overlay_change, note_mouse_highlight):
8880 * xfaces.c (face_at_buffer_position):
21514da7
PE
8881 * buffer.c (OVERLAY_COUNT_MAX): New macro.
8882 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
8883 (Fnext_overlay_change, Fprevious_overlay_change)
8884 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 8885 Use ptrdiff_t, not int, for sizes.
21514da7 8886 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 8887
3de73e5e
PE
8888 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
8889
2606c57b
PE
8890 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
8891 (x_session_initialize): Do not assume string length fits in int.
8892
aaafe47a
PE
8893 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
8894 This is unlikely, but can occur if DPI is outlandish.
8895
2674ddc8 8896 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
8897 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
8898
28154962
PE
8899 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
8900 * xrdb.c (magic_file_p, search_magic_path):
8901 Omit last arg SUFFIX; it was always 0. All callers changed.
8902 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
8903
7de51af5
PE
8904 * xfont.c (xfont_match): Avoid need for strlen.
8905
25ed6cc3
PE
8906 * xfns.c: Don't assume strlen fits in int.
8907 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
8908
4eab31dd
PE
8909 * xdisp.c (message_log_check_duplicate): Return intmax_t,
8910 not unsigned long, as we prefer signed integers. All callers changed.
8911 Detect integer overflow in repeat count.
8912 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 8913 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 8914
171e2a58
PE
8915 * termcap.c: Don't assume sizes fit in int and never overflow.
8916 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
8917 (gobble_line): Check for size-calculation overflow.
8918
ad39faca 8919 * minibuf.c (Fread_buffer):
6e5bb2dc 8920 * lread.c (intern, intern_c_string):
74ca2eb3
PE
8921 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
8922 Don't assume string length fits in int.
8923
52c61c22 8924 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
8925 * gtkutil.c (style_changed_cb): Avoid need for strlen.
8926
b5b8c9e5
PE
8927 * font.c: Don't assume string length fits in int.
8928 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
8929 Use ptrdiff_t, not int.
ccd6111c
PE
8930 (font_intern_prop): Don't assume string length fits in int.
8931 Don't assume integer property fits in fixnum.
8932 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 8933
882f0d81 8934 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 8935 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
8936 Reformulate so as not to need the command string.
8937 Invoke gzip -cd rather than gunzip, as it's more portable.
8938 (lock_info_type, lock_file_1, lock_file):
8939 Don't assume pid_t and time_t fit in unsigned long.
8940 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
8941 (current_lock_owner): Prefer signed type for sizes.
8942 Use memcpy, not strncpy, where memcpy is what is really wanted.
8943 Don't assume (via atoi) that time_t and pid_t fit in int.
8944 Check for time_t and/or pid_t out of range, e.g., via a network share.
8945 Don't alloca where an auto var works fine.
8946
93f4cf88
PE
8947 * fileio.c: Fix some integer overflow issues.
8948 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
8949 Don't assume string length fits in int.
8950 (directory_file_name): Don't assume string length fits in long.
8951 (make_temp_name): Don't assume pid fits in int, or that its print
8952 length is less than 20.
8953
f3e92b69
PE
8954 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
8955
1bfdaf10
PE
8956 * coding.c (make_subsidiaries): Don't assume string length fits in int.
8957
35016e9a
PE
8958 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
8959
3d1e65a1
PE
8960 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
8961 We prefer signed integers, even for size calculations.
8962
0b963a93
PE
8963 * emacs.c: Don't assume string length fits in 'int'.
8964 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
8965 (main): Don't invoke strlen when not needed.
8966
573f4b54
PE
8967 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
8968 (XD_DEBUG_MESSAGE): Don't waste a byte.
8969
989f33ba
PE
8970 * callproc.c (getenv_internal_1, getenv_internal)
8971 (Fgetenv_internal):
965d34eb
PE
8972 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
8973
e4d29b33
PE
8974 * lread.c (invalid_syntax): Omit length argument.
8975 All uses changed. This doesn't fix a bug, but it simplifies the
8976 code away from its former Hollerith-constant appearance, and it's
8977 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 8978 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 8979
eb49b136
PE
8980 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
8981 This didn't break anything, but it didn't help either.
8982 It's confusing to put a bogus integer in a place where the actual
8983 value does not matter.
9f62aeb1 8984 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 8985 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 8986
15375a22
PE
8987 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
8988 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
8989 implementation.
b61cc01c
PE
8990 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
8991 We prefer signed types, and the value cannot exceed the EMACS_INT
8992 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
8993 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
8994 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
8995 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 8996
53b2623d
PE
8997 * indent.c (sane_tab_width): New function.
8998 (current_column, scan_for_column, Findent_to, position_indentation)
8999 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 9000 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 9001
51cab52b 9002 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 9003
f2ed8a70
PE
9004 * lisp.h (lint_assume): New macro.
9005 * composite.c (composition_gstring_put_cache):
9006 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
9007
abe80cc6
PE
9008 * editfns.c, insdel.c:
9009 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 9010
b02c740e
PE
9011 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
9012
ebc96716
PE
9013 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
9014
b4e50fa0 9015 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 9016 Use much-faster test for byte-length change.
311d5d7c 9017 Don't assume string byte-length fits in 'int'.
a4cf38e4 9018 Check that character arg fits in 'int'.
85461888 9019 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 9020
c0c1ee9f
PE
9021 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
9022
a498d7f4
PE
9023 * fns.c (concat): Catch string overflow earlier.
9024 Do not rely on integer wraparound.
9025
51cab52b
PE
9026 * dispextern.h (struct it.overlay_strings_charpos)
9027 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
9028 * xdisp.c (forward_to_next_line_start)
9029 (back_to_previous_visible_line_start)
9030 (reseat_at_next_visible_line_start, next_element_from_buffer):
9031 Don't arbitrarily truncate the value of 'selective' to int.
9032
76031fad
PE
9033 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
9034
5eb55db9
PE
9035 * composite.c: Don't truncate sizes to 'int'.
9036 (composition_gstring_p, composition_reseat_it)
9037 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
9038 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
9039 not EMACS_UINT, for indexes.
5eb55db9 9040
0703a717
PE
9041 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
9042
d6202519
PE
9043 * buffer.c: Include <verify.h>.
9044 (struct sortvec.priority, struct sortstr.priority):
8961a454 9045 Now EMACS_INT, not int.
c20998a7 9046 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
9047 (struct sortstr.size, record_overlay_string)
9048 (struct sortstrlist.size, struct sortlist.used):
9049 Don't truncate size to int.
9050 (record_overlay_string): Check for size-calculation overflow.
d6202519 9051 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 9052
d5a19415
JM
90532011-06-22 Jim Meyering <meyering@redhat.com>
9054
029529ac 9055 Don't leak an XBM-image-sized buffer
d5a19415
JM
9056 * image.c (xbm_load): Free the image buffer after using it.
9057
a9041e6c
PE
90582011-06-21 Paul Eggert <eggert@cs.ucla.edu>
9059
9060 Port to Sun C.
9061 * composite.c (find_automatic_composition): Omit needless 'return 0;'
9062 that Sun C diagnosed.
9063 * fns.c (secure_hash): Fix pointer signedness issue.
9064 * intervals.c (static_offset_intervals): New function.
9065 (offset_intervals): Use it.
9066
7f3f739f
LL
90672011-06-21 Leo Liu <sdl.web@gmail.com>
9068
9069 * deps.mk (fns.o):
9070 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
9071 sha512.h.
9072
9073 * fns.c (secure_hash): Rename from crypto_hash_function and change
9074 the first arg to accept symbols.
5b66d427 9075 (Fsecure_hash): New primitive.
7f3f739f
LL
9076 (syms_of_fns): New symbols.
9077
76147d94
DD
90782011-06-20 Deniz Dogan <deniz@dogan.se>
9079
9080 * process.c (Fset_process_buffer): Clarify return value in
9081 docstring.
9082
7d7d0045
CY
90832011-06-18 Chong Yidong <cyd@stupidchicken.com>
9084
9085 * dispnew.c (add_window_display_history): Use BVAR.
9086
9087 * xdisp.c (debug_method_add): Use BVAR.
9088 (check_window_end, dump_glyph_matrix, dump_glyph)
9089 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
9090
9091 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
9092 Likewise.
9093
9094 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
9095 check till after the cache is created in init_frame_faces.
9096
ff2bc410
SM
90972011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
9098
9099 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
9100
28177add
PE
91012011-06-16 Paul Eggert <eggert@cs.ucla.edu>
9102
dd3482fe
PE
9103 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
9104 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
9105 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
9106
393d71f3 9107 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
9108 * fileio.c (Finsert_file_contents):
9109 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
9110 Remove the old (too-loose) buffer overflow checks.
9111 They weren't needed, since make_gap checks for buffer overflow.
9112 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
9113 The old code merely checked for Emacs fixnum overflow, and relied
9114 on undefined (wraparound) behavior. The new code avoids undefined
9115 behavior, and also checks for ptrdiff_t and/or size_t overflow.
9116
2e6813b0 9117 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
9118 Tune. Don't use wider integers than needed. Don't use alloca.
9119 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 9120
599a9e4f
PE
9121 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
9122
99561444
PE
9123 * insdel.c, lisp.h (buffer_overflow): New function.
9124 (insert_from_buffer_1, replace_range, replace_range_2):
9125 * insdel.c (make_gap_larger):
9126 * editfns.c (Finsert_char):
9127 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
9128
28177add
PE
9129 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
9130
e69dafad
PE
91312011-06-15 Paul Eggert <eggert@cs.ucla.edu>
9132
4baa020d 9133 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 9134
b1c46f02
PE
9135 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
9136 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
9137
e69dafad
PE
9138 * fileio.c: Don't assume EMACS_INT fits in off_t.
9139 (emacs_lseek): New static function.
9140 (Finsert_file_contents, Fwrite_region): Use it.
9141 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
9142
566684ea
PE
9143 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
9144
e6966cd6
PE
9145 * fns.c: Don't overflow int when computing a list length.
9146 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
9147 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
9148 truncation on 64-bit hosts. Check for QUIT every
9149 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
9150 faster and is responsive enough.
9151 (Flength): Report an error instead of overflowing an integer.
9152 (Fsafe_length): Return a float if the value is not representable
9153 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 9154 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 9155 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 9156
dd0b0efb
PE
9157 * alloc.c: Check that resized vectors' lengths fit in fixnums.
9158 (header_size, word_size): New constants.
9159 (allocate_vectorlike): Don't check size overflow here.
9160 (allocate_vector): Check it here instead, since this is the only
9161 caller of allocate_vectorlike that could cause overflow.
9162 Check that the new vector's length is representable as a fixnum.
9163
86fe5cfe
PE
9164 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
9165 The previous code was bogus. For example, next_almost_prime (32)
9166 returned 39, which is undesirable as it is a multiple of 3; and
9167 next_almost_prime (24) returned 25, which is a multiple of 5 so
9168 why was the code bothering to check for multiples of 7?
9169
80e88859
PE
9170 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
9171
4a2f0ad6
PE
9172 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
9173
f66c7cf8
PE
9174 Variadic C functions now count arguments with ptrdiff_t.
9175 This partly undoes my 2011-03-30 change, which replaced int with size_t.
9176 Back then I didn't know that the Emacs coding style prefers signed int.
9177 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
9178 were being counted with int, which may truncate counts on 64-bit
9179 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
9180 * lisp.h (struct Lisp_Subr.function.aMANY)
9181 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
9182 Arg counts are now ptrdiff_t, not size_t.
9183 All variadic functions and their callers changed accordingly.
9184 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
9185 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
9186 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
9187 * callint.c (Fcall_interactively): Check arg count for overflow,
9188 to avoid potential buffer overrun. Use signed char, not 'int',
9189 for 'varies' array, so that we needn't bother to check its size
9190 calculation for overflow.
9191 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
9192 * eval.c (apply_lambda):
9193 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
9194 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
9195 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
9196
a1759b76
PE
9197 * callint.c (Fcall_interactively): Don't use index var as event count.
9198
d96be9fc
PE
9199 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
9200 * mem-limits.h (SIZE): Remove; no longer used.
9201
a690a978 9202 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 9203
578c21e6
PE
9204 Remove unnecessary casts.
9205 * xterm.c (x_term_init):
9206 * xfns.c (x_set_border_pixel):
9207 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
9208 These aren't needed now that we assume ANSI C.
9209
96f53c6c
PE
9210 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
9211 It's more likely to cause problems (due to unsigned overflow)
9212 than to cure them.
9213
83c77d31
PE
9214 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
9215
ee2079f1
PE
9216 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
9217
6da65536
PE
9218 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
9219
7147c4a4
PE
9220 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
9221
193e32d9
PE
9222 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
9223
e5533da6
PE
9224 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
9225
9910e595
PE
9226 GLYPH_CODE_FACE returns EMACS_INT, not int.
9227 * dispextern.h (merge_faces):
9228 * xfaces.c (merge_faces):
01103c44
PE
9229 * xdisp.c (get_next_display_element, next_element_from_display_vector):
9230 Don't assume EMACS_INT fits in int.
9910e595 9231
2638320e
PE
9232 * character.h (CHAR_VALID_P): Remove unused parameter.
9233 * fontset.c, lisp.h, xdisp.c: All uses changed.
9234
045eb8d9
PE
9235 * editfns.c (Ftranslate_region_internal): Omit redundant test.
9236
c1f134b5
PE
9237 * fns.c (concat): Minor tuning based on overflow analysis.
9238 This doesn't fix any bugs. Use int to hold character, instead
9239 of constantly refetching from Emacs object. Use XFASTINT, not
9240 XINT, for value known to be a character. Don't bother comparing
9241 a single byte to 0400, as it's always less.
9242
395fcb93 9243 * floatfns.c (Fexpt):
327eeec8
PE
9244 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
9245
abbd3d23
PE
9246 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
9247 for characters.
9248
684a03ef
PE
9249 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
9250
0fed43f3
PE
9251 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
9252 Without this fix, on a 64-bit host (aset S 0 4294967386) would
9253 incorrectly succeed when S was a string, because 4294967386 was
9254 truncated before it was used.
9255
8fd02eb7
PE
9256 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
9257 Otherwise, an out-of-range integer could cause undefined behavior
9258 on a 64-bit host.
9259
f8c86b69
PE
9260 * composite.c: Use int, not EMACS_INT, for characters.
9261 (fill_gstring_body, composition_compute_stop_pos): Use int, not
9262 EMACS_INT, for values that are known to be in character range.
9263 This doesn't fix any bugs but is the usual style inside Emacs and
9264 may generate better code on 32-bit machines.
9265
34206dd2
PE
9266 Make sure a 64-bit char is never passed to ENCODE_CHAR.
9267 This is for reasons similar to the recent CHAR_STRING fix.
9268 * charset.c (Fencode_char): Check that character arg is actually
9269 a character. Pass an int to ENCODE_CHAR.
9270 * charset.h (ENCODE_CHAR): Verify that the character argument is no
9271 wider than 'int', as a compile-time check to prevent future regressions
9272 in this area.
9273
c5958d4c 9274 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
9275
9276 Make sure a 64-bit char is never passed to CHAR_STRING.
9277 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
9278 by silently ignoring the top 32 bits, allowing some values
9279 that were far too large to be valid characters.
9280 * character.h: Include <verify.h>.
9281 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
9282 arguments are no wider than unsigned, as a compile-time check
9283 to prevent future regressions in this area.
9284 * data.c (Faset):
01103c44 9285 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
9286 (Fsubst_char_in_region):
9287 * fns.c (concat):
9288 * xdisp.c (decode_mode_spec_coding):
9289 Adjust to CHAR_STRING's new requirement.
9290 * editfns.c (Finsert_char, Fsubst_char_in_region):
9291 * fns.c (concat): Check that character args are actually
9292 characters. Without this test, these functions did the wrong
9293 thing with wildly out-of-range values on 64-bit hosts.
9294
d37ca623
PE
9295 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
9296 These casts should not be needed on 32-bit hosts, either.
9297 * keyboard.c (read_char):
9298 * lread.c (Fload): Remove casts to unsigned.
9299
ea204efb
PE
9300 * lisp.h (UNSIGNED_CMP): New macro.
9301 This fixes comparison bugs on 64-bit hosts.
9302 (ASCII_CHAR_P): Use it.
9303 * casefiddle.c (casify_object):
01103c44 9304 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
9305 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
9306 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
9307 * dispextern.h (FACE_FROM_ID):
9308 * keyboard.c (read_char): Use UNSIGNED_CMP.
9309
41cb286c
PE
9310 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
9311 not to EMACS_INT, to avoid GCC warning.
9312
4a1b9832
PE
9313 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
9314
55daad71
PE
9315 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
9316 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
9317 isn't needed on 32-bit machines.
8f95c75c 9318
01103c44
PE
9319 * buffer.c (Fgenerate_new_buffer_name):
9320 Use EMACS_INT for count, not int.
0ceccced 9321 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
9322
9323 * data.c (Qcompiled_function): Now static.
9324
c6f072e7
PE
9325 * window.c (window_body_lines): Now static.
9326
20ce5912
PE
9327 * image.c (gif_load): Rename local to avoid shadowing.
9328
9c4c5f81
PE
9329 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
9330 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
9331 * alloc.c (make_save_value): Integer argument is now of type
9332 ptrdiff_t, not int.
9333 (mark_object): Use ptrdiff_t, not int.
9334 * lisp.h (pD): New macro.
9335 * print.c (print_object): Use it.
9336
c0c5c8ae
PE
9337 * alloc.c: Use EMACS_INT, not int, to count objects.
9338 (total_conses, total_markers, total_symbols, total_vector_size)
9339 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
9340 (total_free_floats, total_floats, total_free_intervals)
9341 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
9342 Now EMACS_INT, not int. All uses changed.
9343 (Fgarbage_collect): Compute overall total using a double, so that
9344 integer overflow is less likely to be a problem. Check for overflow
9345 when converting back to an integer.
5a25e253
PE
9346 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
9347 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
9348 These were 'int' variables that could overflow on 64-bit hosts;
9349 they were never used, so remove them instead of repairing them.
211a0b2a 9350 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
9351 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
9352 Previously, this ceilinged at INT_MAX, but that doesn't work on
9353 64-bit machines.
e46bb31a 9354 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 9355
c78baabf 9356 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 9357 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
9358 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
9359 when a (possibly-narrower) signed value would do just as well.
9360 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 9361
c9d624c6
PE
9362 * alloc.c: Catch some string size overflows that we were missing.
9363 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
9364 for convenience in STRING_BYTES_MAX.
9365 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
9366 The definition here is exact; the one in lisp.h was approximate.
9367 (allocate_string_data): Check for string overflow. This catches
9368 some instances we weren't catching before. Also, it catches
9369 size_t overflow on (unusual) hosts where SIZE_MAX <= min
9370 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
9371 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 9372
c9d624c6
PE
9373 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
9374 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 9375 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 9376
353032ce
PE
9377 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
9378
2bccce07
PE
9379 * alloc.c (Fmake_string): Check for out-of-range init.
9380
0ac30604
SM
93812011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
9382
9383 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
9384
c195f2de
JD
93852011-06-14 Jan Djärv <jan.h.d@swipnet.se>
9386
9387 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
9388 xg_get_default_scrollbar_width.
9389
9390 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
9391 (int_gtk_range_get_value): Move to the scroll bar part of the file.
9392 (style_changed_cb): Call update_theme_scrollbar_width and call
9393 x_set_scroll_bar_default_width and xg_frame_set_char_size for
9394 all frames (Bug#8505).
9395 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
9396 Call gtk_window_set_resizable if HAVE_GTK3.
9397 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
9398 and height if HAVE_GTK3 (Bug#8505).
9399 (scroll_bar_width_for_theme): New variable.
9400 (update_theme_scrollbar_width): New function.
9401 (xg_get_default_scrollbar_width): Move code to
9402 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
9403 (xg_initialize): Call update_theme_scrollbar_width.
9404
9405 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
9406
9407 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
9408
e10ac9f1
MR
94092011-06-12 Martin Rudalics <rudalics@gmx.at>
9410
9411 * frame.c (make_frame): Call other_buffer_safely instead of
9412 other_buffer.
9413
9414 * window.c (temp_output_buffer_show): Call display_buffer with
9415 second argument Vtemp_buffer_show_specifiers and reset latter
9416 immediately after the call.
9417 (Vtemp_buffer_show_specifiers): New variable.
9418 (auto_window_vscroll_p, next_screen_context_lines)
9419 (Vscroll_preserve_screen_position): Remove leading asterisks from
9420 doc-strings.
9421
2d3c217e 94222011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 9423
7b7f97e8 9424 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
9425 * buffer.c (Qclone_number): Remove for now, as it's unused.
9426 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
9427 (record_buffer): Remove unused local.
9428 * frame.c (other_visible_frames, frame_buffer_list): Now static.
9429 (set_frame_buffer_list): Remove; unused.
9430 * frame.h (other_visible_frames): Remove decl.
9431 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
9432 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
9433 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
9434 if HAVE_GPM.
9435 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
9436 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
9437 Define only if HAVE_GPM.
9438 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
9439 (update_hints_inhibit): Remove; never set. All uses removed.
9440 * widgetprv.h (emacsFrameClassRec): Remove decl.
9441 * window.c (delete_deletable_window): Now returns void, since it
9442 wasn't returning anything.
9443 (compare_window_configurations): Remove unused locals.
9444 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
9445 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
9446 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
9447 the same widths as pointers. This follows up on the 2011-05-06 patch.
9448 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
9449 * xterm.h: Likewise.
9450 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
9451
1384b89e
JB
94522011-06-12 Juanma Barranquero <lekktu@gmail.com>
9453
9454 * makefile.w32-in: Update dependencies.
9455 (LISP_H): Add lib/intprops.h.
9456
1100a63c
CY
94572011-06-11 Chong Yidong <cyd@stupidchicken.com>
9458
9459 * image.c (gif_load): Add animation frame delay to the metadata.
9460 (syms_of_image): Use DEFSYM. New symbol `delay'.
9461
6198ccd0
MR
94622011-06-11 Martin Rudalics <rudalics@gmx.at>
9463
9464 * window.c (delete_deletable_window): Re-add.
9465 (Fset_window_configuration): Rewrite to handle dead buffers and
9466 consequently deletable windows.
9467 (window_tree, Fwindow_tree): Remove. Supply functionality in
9468 window.el.
9469 (compare_window_configurations): Simplify code.
9470
b6e3633c
AS
94712011-06-11 Andreas Schwab <schwab@linux-m68k.org>
9472
1ab0dee5
AS
9473 * image.c (imagemagick_load_image): Fix type mismatch.
9474 (Fimagemagick_types): Likewise.
9475
b6e3633c
AS
9476 * window.h (replace_buffer_in_windows): Declare.
9477
9397e56f
MR
94782011-06-11 Martin Rudalics <rudalics@gmx.at>
9479
9480 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
9481 Qclone_number. Remove external declaration of Qdelete_window.
9482 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
9483 code.
640c8776
SM
9484 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
9485 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
9486 (Fother_buffer): Rewrite doc-string. Major rewrite for new
9487 buffer list implementation.
9488 (other_buffer_safely): New function.
9489 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
9490 calls to replace_buffer_in_windows and
9491 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
9492 if allowed.
9493 (record_buffer): Inhibit quitting and rewrite using quittable
9494 functions. Run Qbuffer_list_update_hook if allowed.
9495 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
9496 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
9497 Move switch-to-buffer to window.el.
9397e56f
MR
9498 (bury-buffer): Move to window.el.
9499 (Vbuffer_list_update_hook): New variable.
9500
9501 * lisp.h (other_buffer_safely): Add prototype in buffer.c
9502 section.
9503
9504 * window.h (resize_frame_windows): Move up in code.
9505 (Fwindow_frame): Remove EXFUN.
9506 (replace_buffer_in_all_windows): Remove prototype.
9507 (replace_buffer_in_windows_safely): Add prototype.
9508
9509 * window.c: Declare Qdelete_window static again. Move down
9510 declaration of select_count.
9511 (Fnext_window, Fprevious_window): Rewrite doc-strings.
9512 (Fother_window): Move to window.el.
9513 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
9514 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
9515 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
9516 window.el.
9517 (replace_buffer_in_windows): Implement by calling
9518 Qreplace_buffer_in_windows.
9519 (replace_buffer_in_all_windows): Remove with some functionality
9520 moved into replace_buffer_in_windows_safely.
9521 (replace_buffer_in_windows_safely): New function.
9522 (select_window_norecord, select_frame_norecord): Move in front
9523 of run_window_configuration_change_hook. Remove now obsolete
9524 declarations.
640c8776
SM
9525 (Fset_window_buffer): Rewrite doc-string.
9526 Call Qrecord_window_buffer.
9397e56f
MR
9527 (keys_of_window): Move binding for other-window to window.el.
9528
b50691aa
CY
95292011-06-11 Chong Yidong <cyd@stupidchicken.com>
9530
9531 * dispextern.h (struct image): Replace data member, whose int_val
9532 and ptr_val fields were not used by anything, with a single
9533 lisp_val object.
9534
9535 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
9536 (gif_clear_image, gif_load, imagemagick_load_image)
9537 (gs_clear_image, gs_load): Callers changed.
9538
3f754b86
PE
95392011-06-10 Paul Eggert <eggert@cs.ucla.edu>
9540
cca69397
PE
9541 * buffer.h: Include <time.h>, for time_t.
9542 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
9543
109e28d0
PE
9544 Fix minor problems found by static checking.
9545
60737f02
PE
9546 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
9547
4b66faf3
PE
9548 Make identifiers static if they are not used in other modules.
9549 * data.c (Qcompiled_function, Qframe, Qvector):
9550 * image.c (QimageMagick, Qsvg):
9551 * minibuf.c (Qmetadata):
9552 * window.c (resize_window_check, resize_root_window): Now static.
9553 * window.h (resize_window_check, resize_root_window): Remove decls.
9554
109e28d0
PE
9555 * window.c (window_deletion_count, delete_deletable_window):
9556 Remove; unused.
46a4ce9e
PE
9557 (window_body_lines): Now static.
9558 (Fdelete_other_windows_internal): Mark vars as initialized.
9559 Make sure 'resize_failed' is initialized.
9560 (run_window_configuration_change_hook): Rename local to avoid shadowing.
9561 (resize_window_apply): Remove unused local.
9562 * window.h (delete_deletable_window): Remove decl.
9563
109e28d0 9564 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
9565 (imagemagick_load_image): Fix pointer signedness problem by changing
9566 last arg from unsigned char * to char *. All uses changed.
9567 Also, fix a local for similar reasons.
9568 Remove unused locals. Remove locals to avoid shadowing.
9569 (fn_rsvg_handle_free): Remove; unused.
9570 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 9571 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 9572
3f754b86
PE
9573 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
9574
2547adb1
CY
95752011-06-10 Chong Yidong <cyd@stupidchicken.com>
9576
9577 * image.c (gif_load): Fix omitted cast error introduced by
9578 2011-06-06 change.
9579
2c8e37d4
MR
95802011-06-10 Martin Rudalics <rudalics@gmx.at>
9581
9582 * window.h (resize_proportionally, orig_total_lines)
9583 (orig_top_line): Remove from window structure.
9584 (set_window_height, set_window_width, change_window_heights)
9585 (Fdelete_window): Remove prototypes.
9586 (resize_frame_windows): Remove duplicate declaration.
9587
440a42e3
EZ
95882011-06-10 Eli Zaretskii <eliz@gnu.org>
9589
9590 * window.h (resize_frame_windows, resize_window_check)
9591 (delete_deletable_window, resize_root_window)
9592 (resize_frame_windows): Declare prototypes.
9593
9594 * window.c (resize_window_apply): Make definition be "static" to
9595 match the prototype.
9596
562dd5e9
MR
95972011-06-10 Martin Rudalics <rudalics@gmx.at>
9598
9599 * window.c: Remove declarations of Qwindow_size_fixed,
9600 window_min_size_1, window_min_size_2, window_min_size,
9601 size_window, window_fixed_size_p, enlarge_window, delete_window.
9602 Remove static from declaration of Qdelete_window, it's
9603 temporarily needed by Fbury_buffer.
9604 (replace_window): Don't assign orig_top_line and
9605 orig_total_lines.
9606 (Fdelete_window, delete_window): Remove. Window deletion is
9607 handled by window.el.
640c8776
SM
9608 (window_loop): Remove DELETE_OTHER_WINDOWS case.
9609 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
9610 (Fdelete_other_windows): Remove. Deleting other windows is
9611 handled by window.el.
9612 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
9613 handled in window.el.
9614 (window_min_size_2, window_min_size_1, window_min_size): Remove.
9615 Window minimum sizes are handled in window.el.
9616 (shrink_windows, size_window, set_window_height)
9617 (set_window_width, change_window_heights, window_height)
9618 (window_width, CURBEG, CURSIZE, enlarge_window)
9619 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
9620 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
9621 handled in window.el.
9622 (make_dummy_parent): Rename to make_parent_window and give it a
9623 second argument horflag.
9624 (make_window): Don't set resize_proportionally any more.
9625 (Fsplit_window): Remove. Windows are split in window.el.
9626 (save_restore_action, save_restore_orig_size)
9627 (shrink_window_lowest_first, save_restore_orig_size): Remove.
9628 Resize mini windows in window.el.
9629 (grow_mini_window, shrink_mini_window): Implement by calling
9630 Qresize_root_window_vertically, resize_window_check and
9631 resize_window_apply.
640c8776
SM
9632 (saved_window, Fset_window_configuration, save_window_save):
9633 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
9634 resize_proportionally.
9635 (window_min_height, window_min_width): Move to window.el.
9636 (keys_of_window): Move bindings for delete-other-windows,
9637 split-window, delete-window and enlarge-window to window.el.
9638
9639 * buffer.c: Temporarily extern Qdelete_window.
9640 (Fbury_buffer): Temporarily call Qdelete_window instead of
9641 Fdelete_window (Fbury_buffer will move to window.el soon).
9642
9643 * frame.c (set_menu_bar_lines_1): Remove code handling
9644 orig_top_line and orig_total_lines.
9645
9646 * dispnew.c (adjust_frame_glyphs_initially): Don't use
9647 set_window_height but set heights directly.
9648 (change_frame_size_1): Use resize_frame_windows.
9649
9650 * xdisp.c (init_xdisp): Don't use set_window_height but set
9651 heights directly.
9652
640c8776
SM
9653 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
9654 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
9655 run_window_configuration_change_hook.
9656
9657 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
9658 instead of change_window_heights and run
9659 run_window_configuration_change_hook.
9660
1a13852e
MR
96612011-06-09 Martin Rudalics <rudalics@gmx.at>
9662
9663 * window.c (replace_window): Rename second argument REPLACEMENT to
9664 NEW. New third argument SETFLAG. Rewrite.
9665 (delete_window, make_dummy_parent): Call replace_window with
9666 third argument 1.
9667 (window_list_1): Move down in code.
9668 (run_window_configuration_change_hook): Move set_buffer part
9669 before select_frame_norecord part in order to unwind correctly.
9670 Rename count1 to count.
9671 (recombine_windows, delete_deletable_window, resize_root_window)
9672 (Fdelete_other_windows_internal)
9673 (Frun_window_configuration_change_hook, make_parent_window)
9674 (resize_window_check, resize_window_apply, Fresize_window_apply)
9675 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
9676 (Fdelete_window_internal, Fresize_mini_window_internal):
9677 New functions.
1a13852e
MR
9678 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
9679
f3d1777e
MR
96802011-06-08 Martin Rudalics <rudalics@gmx.at>
9681
496e208e
MR
9682 * window.h (window): Add some new members to window structure -
9683 normal_lines, normal_cols, new_total, new_normal, clone_number,
9684 splits, nest, prev_buffers, next_buffers.
9685 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 9686 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 9687
f3d1777e
MR
9688 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
9689 Remove.
496e208e
MR
9690 (make_dummy_parent): Set new members of windows structure.
9691 (make_window): Move down in code. Handle new members of window
9692 structure.
9693 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
9694 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
9695 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
9696 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
9697 (Fset_window_next_buffers, Fset_window_clone_number):
9698 New functions.
496e208e
MR
9699 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
9700 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
9701 Doc-string fixes.
9702 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
9703 Argument WINDOW can be now internal window too.
9704 (Fwindow_use_time): Move up in code.
9705 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
9706 Rewrite doc-string.
9707 (Fset_window_configuration, saved_window)
9708 (Fcurrent_window_configuration, save_window_save): Handle new
9709 members of window structure.
b9e809c2
MR
9710 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
9711 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
9712 (syms_of_window): New Lisp objects Qrecord_window_buffer,
9713 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
9714 Qget_mru_window, Qresize_root_window,
9715 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
9716 Qauto_buffer_name; staticpro them.
f3d1777e 9717
abde8f8c
MR
97182011-06-07 Martin Rudalics <rudalics@gmx.at>
9719
9720 * window.c (Fwindow_total_size, Fwindow_left_column)
9721 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
9722 (Fwindow_list_1): New functions.
9723 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
9724 (Fwindow_width, Fscroll_left, Fscroll_right):
9725 Use window_body_cols instead of window_box_text_cols.
9726 (delete_window, Fset_window_configuration):
9727 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
9728 (delete_all_subwindows): Take a window as argument and not a
9729 structure. Rewrite.
190b47e6
MR
9730 (window_loop): Remove handling of GET_LRU_WINDOW and
9731 GET_LARGEST_WINDOW.
9732 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
9733
9734 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
9735 window_box_text_cols. delete_all_subwindows now takes a
9736 Lisp_Object as argument.
abde8f8c 9737
640c8776
SM
9738 * indent.c (compute_motion, Fcompute_motion):
9739 Use window_body_cols instead of window_box_text_cols.
abde8f8c 9740
fa8a67e6
MR
9741 * frame.c (delete_frame): Call delete_all_subwindows with root
9742 window as argument.
9743
a54e3482
DC
97442011-06-07 Daniel Colascione <dan.colascione@gmail.com>
9745
9746 * fns.c (Fputhash): Document return value.
9747
60002bf5
CY
97482011-06-06 Chong Yidong <cyd@stupidchicken.com>
9749
9750 * image.c (gif_load): Implement gif89a spec "no disposal" method.
9751
0c671da6 97522011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 9753
b862a52a 9754 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 9755
be44ca6c
PE
9756 Check for overflow when converting integer to cons and back.
9757 * charset.c (Fdefine_charset_internal, Fdecode_char):
9758 Use cons_to_unsigned to catch overflow.
9759 (Fencode_char): Use INTEGER_TO_CONS.
9760 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
9761 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
9762 * data.c (long_to_cons, cons_to_long): Remove.
9763 (cons_to_unsigned, cons_to_signed): New functions.
9764 These signal an error for invalid or out-of-range values.
9765 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
9766 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
9767 * font.c (Ffont_variation_glyphs):
9768 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
9769 * lisp.h: Include <intprops.h>.
9770 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
9771 (cons_to_signed, cons_to_unsigned): New decls.
9772 (long_to_cons, cons_to_long): Remove decls.
9773 * undo.c (record_first_change): Use INTEGER_TO_CONS.
9774 (Fprimitive_undo): Use CONS_TO_INTEGER.
9775 * xfns.c (Fx_window_property): Likewise.
9776 * xselect.c: Include <limits.h>.
9777 (x_own_selection, selection_data_to_lisp_data):
9778 Use INTEGER_TO_CONS.
9779 (x_handle_selection_request, x_handle_selection_clear)
9780 (x_get_foreign_selection, Fx_disown_selection_internal)
9781 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
9782 (lisp_data_to_selection_data): Use cons_to_unsigned.
9783 (x_fill_property_data): Use cons_to_signed.
9784 Report values out of range.
9785
d1f3d2af
PE
9786 Check for buffer and string overflow more precisely.
9787 * buffer.h (BUF_BYTES_MAX): New macro.
9788 * lisp.h (STRING_BYTES_MAX): New macro.
9789 * alloc.c (Fmake_string):
9790 * character.c (string_escape_byte8):
9791 * coding.c (coding_alloc_by_realloc):
9792 * doprnt.c (doprnt):
9793 * editfns.c (Fformat):
9794 * eval.c (verror):
9795 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
9796 since they may not be the same number.
9797 * editfns.c (Finsert_char):
9798 * fileio.c (Finsert_file_contents):
9799 Likewise for BUF_BYTES_MAX.
9800
dd52fcea
PE
9801 * image.c: Use ptrdiff_t, not int, for sizes.
9802 (slurp_file): Switch from int to ptrdiff_t.
9803 All uses changed.
9804 (slurp_file): Check that file size fits in both size_t (for
9805 malloc) and ptrdiff_t (for sanity and safety).
9806
7f9bbdbb
PE
9807 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
9808 if b->modtime has its maximal value.
9809
dfe18f82
PE
9810 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
9811
84acfcf0
PE
9812 Don't assume time_t can fit into int.
9813 * buffer.h (struct buffer.modtime): Now time_t, not int.
9814 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
9815 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
9816
ccd9a01a
PE
9817 Minor fixes for signed vs unsigned integers.
9818 * character.h (MAYBE_UNIFY_CHAR):
9819 * charset.c (maybe_unify_char):
9820 * keyboard.c (read_char, reorder_modifiers):
9821 XINT -> XFASTINT, since the integer must be nonnegative.
9822 * ftfont.c (ftfont_spec_pattern):
9823 * keymap.c (access_keymap, silly_event_symbol_error):
9824 XUINT -> XFASTINT, since the integer must be nonnegative.
9825 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
9826 since it makes no difference and we prefer signed.
9827 * keyboard.c (record_char): Use XUINT when all the neighbors do.
9828 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
9829 nonnegative.
9830
d6d100dd
SM
98312011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
9832
9833 * window.h (Fwindow_frame): Declare.
9834
2b6148e4
PE
98352011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9836
9837 * alloc.c: Simplify handling of large-request failures (Bug#8800).
9838 (SPARE_MEMORY): Always define.
9839 (LARGE_REQUEST): Remove.
9840 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
9841
f230ecc9
MR
98422011-06-06 Martin Rudalics <rudalics@gmx.at>
9843
727e958e
MR
9844 * lisp.h: Move EXFUNS for Fframe_root_window,
9845 Fframe_first_window and Fset_frame_selected_window to window.h.
9846
9847 * window.h: Move EXFUNS for Fframe_root_window,
9848 Fframe_first_window and Fset_frame_selected_window here from
9849 lisp.h.
9850
9851 * frame.c (Fwindow_frame, Fframe_first_window)
9852 (Fframe_root_window, Fframe_selected_window)
9853 (Fset_frame_selected_window): Move to window.c.
9854 (Factive_minibuffer_window): Move to minibuf.c.
9855 (Fother_visible_frames_p): New function.
9856
9857 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
9858
f230ecc9
MR
9859 * window.c (decode_window, decode_any_window): Move up in code.
9860 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
9861 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
9862 (Fwindow_buffer): Move up and rewrite doc-string.
9863 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
9864 (Fwindow_prev): New functions.
727e958e
MR
9865 (Fwindow_frame): Move here from frame.c. Accept any window as
9866 argument.
9867 (Fframe_root_window, Fframe_first_window)
9868 (Fframe_selected_window): Move here from frame.c. Accept frame
9869 or arbitrary window as argument. Update doc-strings.
9870 (Fminibuffer_window): Move up in code.
9871 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
9872 (Fset_frame_selected_window): Move here from frame.c.
9873 Marginal rewrite.
727e958e
MR
9874 (Fselected_window, select_window, Fselect_window): Move up in
9875 code. Minor doc-string fixes.
f230ecc9 9876
4d09bcf6
PE
98772011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9878
9879 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
9880 Do not assume that spare memory exists; that assumption is valid
9881 only if SYSTEM_MALLOC.
9882 (LARGE_REQUEST): New macro, so that the issue of large requests
9883 is separated from the issue of spare memory.
9884
810928a2
AS
98852011-06-05 Andreas Schwab <schwab@linux-m68k.org>
9886
172418ad
AS
9887 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
9888 format. (Bug#8806)
9889
43f862f7
AS
9890 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
9891
810928a2
AS
9892 * xfns.c (x_set_scroll_bar_default_width): Move declarations
9893 before statements.
9894
a059fe24
JD
98952011-06-05 Jan Djärv <jan.h.d@swipnet.se>
9896
9897 * gtkutil.c (xg_get_default_scrollbar_width): New function.
9898
9899 * gtkutil.h: Declare xg_get_default_scrollbar_width.
9900
9901 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
9902 min width by calling x_set_scroll_bar_default_width (Bug#8505).
9903
989bf368
JB
99042011-06-05 Juanma Barranquero <lekktu@gmail.com>
9905
9906 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
9907
4b80f674
CY
99082011-06-04 Chong Yidong <cyd@stupidchicken.com>
9909
9910 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
9911 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
9912 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
9913 New error handlers.
4b80f674
CY
9914 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
9915 Obey Vx_select_enable_clipboard_manager. Catch errors in
9916 x_clipboard_manager_save (Bug#8779).
9917 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 9918 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 9919
99a33b77 99202011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
9921
9922 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
9923
99a33b77 99242011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
9925
9926 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
9927 in the current matrix if keep_current_p is non-zero.
9928
8264569d
EZ
99292011-06-04 Eli Zaretskii <eliz@gnu.org>
9930
9931 * bidi.c (bidi_level_of_next_char): Fix last change.
9932
57f97249
EZ
99332011-06-03 Eli Zaretskii <eliz@gnu.org>
9934
fec2107c 9935 Support bidi reordering of text covered by display properties.
57f97249 9936
fec2107c
EZ
9937 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
9938 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
9939 (bidi_cache_search, bidi_cache_iterator_state)
9940 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
9941 (bidi_level_of_next_char, bidi_move_to_visually_next):
9942 Support character positions inside a run of characters covered by a
fec2107c
EZ
9943 display string.
9944 (bidi_paragraph_init, bidi_resolve_explicit_1)
9945 (bidi_level_of_next_char): Call bidi_fetch_char and
9946 bidi_fetch_char_advance instead of FETCH_CHAR and
9947 FETCH_CHAR_ADVANCE.
9948 (bidi_init_it): Initialize new members.
9949 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
9950 definitions.
9951 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
9952 instead of using explicit *_CHAR codes.
d6d100dd
SM
9953 (bidi_resolve_explicit, bidi_resolve_weak):
9954 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
9955 bidirectional text is supported only in multibyte buffers.
9956 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
9957 it to initialize the frame_window_p member of struct bidi_it.
9958 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
9959 (bidi_resolve_explicit, bidi_resolve_weak)
9960 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
9961 bidi_it->nchars is non-positive.
9962 (bidi_level_of_next_char): Don't try to lookup the cache for the
9963 next/previous character if nothing is cached there yet, or if we
9964 were just reseat()'ed to a new position.
c40e2fb2 9965
0e14fe90
EZ
9966 * xdisp.c (set_cursor_from_row): Set start and stop points
9967 according to the row's direction when priming the loop that looks
9968 for the glyph on which to display cursor.
9969 (single_display_spec_intangible_p): Function deleted.
9970 (display_prop_intangible_p): Reimplement to call
9971 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
9972 Accept 3 additional arguments needed by handle_display_spec.
9973 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
9974 values: lists, `(when COND...)' forms, etc.
9975 (single_display_spec_string_p): Support property values that are
9976 lists with the argument STRING its top-level element.
9977 (display_prop_string_p): Fix the condition for processing a
9978 property that is a list to be consistent with handle_display_spec.
fec2107c 9979 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
9980 last portion of handle_display_prop.
9981 (compute_display_string_pos): Accept additional argument
9982 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
9983 value of a `display' property is a "replacing spec".
9984 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
9985 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
9986 the display property, but just return a value indicating whether
9987 the display property will replace the characters it covers.
9988 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
9989 frame_window_p members of struct bidi_it.
d6d100dd
SM
9990 (compute_display_string_pos, compute_display_string_end):
9991 New functions.
fec2107c
EZ
9992 (push_it): Accept second argument POSITION, where pop_it should
9993 jump to continue iteration.
9994 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 9995
fec2107c
EZ
9996 * keyboard.c (adjust_point_for_property): Adjust the call to
9997 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
9998
9999 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
10000 (bidi_init_it): Update prototypes.
10001 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
10002 (compute_display_string_pos, compute_display_string_end):
10003 Declare prototypes.
fec2107c
EZ
10004 (struct bidi_it): New members nchars and disp_pos. ch_len is now
10005 EMACS_INT.
fc6f18ce 10006
40087514 100072011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 10008
57f53182
PE
10009 Malloc failure behavior now depends on size of allocation.
10010 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
10011 * lisp.h: Change signatures accordingly.
10012 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
10013 All callers changed. (Bug#8762)
10014
10015 * gnutls.c: Use Emacs's memory allocators.
10016 Without this change, the gnutls library would invoke malloc etc.
10017 directly, which causes problems on non-SYNC_INPUT hosts, and which
10018 runs afoul of improving memory_full behavior. (Bug#8761)
10019 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
10020 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
10021 xfree instead of the default malloc, realloc, free.
10022 (Fgnutls_boot): No need to check for memory allocation failure,
10023 since xmalloc does that for us.
10024
ac32cd99 10025 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
10026 * category.c (hash_get_category_set):
10027 * ccl.c (ccl_driver):
10028 * charset.c (Fdefine_charset_internal):
10029 * charset.h (struct charset.hash_index):
10030 * composite.c (get_composition_id, gstring_lookup_cache)
10031 (composition_gstring_put_cache):
10032 * composite.h (struct composition.hash_index):
10033 * dispextern.h (struct image.hash):
10034 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
10035 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
10036 (hashfn_equal, hashfn_user_defined, make_hash_table)
10037 (maybe_resize_hash_table, hash_lookup, hash_put)
10038 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
10039 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
10040 (Fsxhash, Fgethash, Fputhash, Fmaphash):
10041 * image.c (make_image, search_image_cache, lookup_image)
10042 (xpm_put_color_table_h):
10043 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 10044 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 10045 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 10046 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
10047 * alloc.c (allocate_vectorlike):
10048 Check for overflow in vector size calculations.
10049 * ccl.c (ccl_driver):
10050 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
10051 * fns.c, image.c: Remove unnecessary static decls that would otherwise
10052 need to be updated by these changes.
40087514
PE
10053 * fns.c (make_hash_table, maybe_resize_hash_table):
10054 Check for integer overflow with large hash tables.
0de4bb68
PE
10055 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
10056 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
10057 (SXHASH_REDUCE): New macro.
10058 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
10059 Use it instead of discarding useful hash info with large hash values.
10060 (sxhash_float): New function.
10061 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
10062 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
10063 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
10064 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
10065 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
10066 Adjust signatures to match updated version of code.
10067 (consing_since_gc): Now EMACS_INT, since a single hash table can
10068 use more than INT_MAX bytes.
10069
698d32e2
DN
100702011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
10071
10072 Make it possible to build with GCC-4.6+ -O2 -flto.
10073
10074 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
10075
fd6fa53f
SM
100762011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
10077
10078 * minibuf.c (get_minibuffer, read_minibuf_unwind):
10079 Call minibuffer-inactive-mode.
10080
864db017
JB
100812011-05-31 Juanma Barranquero <lekktu@gmail.com>
10082
10083 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
10084 Update dependencies.
10085
2ad0baf4
DN
100862011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10087
10088 * data.c (init_data): Remove code for UTS, this system is not
10089 supported anymore.
10090
4fcc2638
DN
100912011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10092
10093 Don't force ./temacs to start in terminal mode.
10094
10095 * frame.c (make_initial_frame): Initialize faces in all cases, not
10096 only when CANNOT_DUMP is defined.
10097 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
10098
c56e0fd5
DN
100992011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10100
10101 * dispnew.c (add_window_display_history): Use const for the string
10102 pointer. Remove declaration, not needed.
10103
333d54da 101042011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 10105
55d4c1b2 10106 Use 'inline', not 'INLINE'.
333d54da 10107 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
10108 * alloc.c, fontset.c (INLINE): Remove.
10109 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
10110 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
10111 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
10112 * gmalloc.c (register_heapinfo): Use inline unconditionally.
10113 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
10114
738db178
DN
101152011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10116
10117 Make it possible to run ./temacs.
10118
10119 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
10120 syms_of_callproc does the same thing. Remove test for
10121 "initialized", do it in the caller.
10122 * emacs.c (main): Avoid calling set_initial_environment when dumping.
10123
620c53a6
SM
101242011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
10125
10126 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
10127 (read_minibuf): Use get_minibuffer.
10128 (syms_of_minibuf): Use DEFSYM.
10129 (Qmetadata): New var.
10130 * data.c (Qbuffer): Don't make it static.
10131 (syms_of_data): Use DEFSYM.
10132
e003a292
PE
101332011-05-31 Paul Eggert <eggert@cs.ucla.edu>
10134
10135 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
10136 (CCL_CODE_MIN): New macro.
10137
ed008a6d
PE
101382011-05-30 Paul Eggert <eggert@cs.ucla.edu>
10139
3687c2ef
PE
10140 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
10141
ed008a6d
PE
10142 * eval.c (Qdebug): Now static.
10143 * lisp.h (Qdebug): Remove decl. This reverts a part of the
10144 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
10145 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
10146
d66c4c7c
CY
101472011-05-29 Chong Yidong <cyd@stupidchicken.com>
10148
10149 * image.c: Various fixes to ImageMagick code comments.
10150 (Fimagemagick_types): Doc fix.
10151
5fbc2025
PE
101522011-05-29 Paul Eggert <eggert@cs.ucla.edu>
10153
0196f88a
PE
10154 Minor fixes prompted by GCC 4.6.0 warnings.
10155
10156 * xselect.c (converted_selections, conversion_fail_tag): Now static.
10157
5fbc2025
PE
10158 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
10159 (x_clipboard_manager_save_all): Move extern decl to ...
10160 * xterm.h: ... here, so that it can be checked for consistency.
10161
1dd3c2d9
CY
101622011-05-29 Chong Yidong <cyd@stupidchicken.com>
10163
10164 * xselect.c (x_clipboard_manager_save_frame)
10165 (x_clipboard_manager_save_all): New functions.
10166 (Fx_clipboard_manager_save): Lisp function deleted.
10167
10168 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
10169 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
10170
10171 * xterm.h: Update prototype.
10172
5ba6571d
WX
101732011-05-28 William Xu <william.xwl@gmail.com>
10174
10175 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
10176 exiting (Bug#8239).
10177
3eaff834
JM
101782011-05-28 Jim Meyering <meyering@redhat.com>
10179
e1900994 10180 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
10181 * fns.c (to_uchar): Define.
10182 (crypto_hash_function): Use it to convert some newly-signed
10183 variables to unsigned, to avoid sign-extension bugs. For example,
10184 without this change, (md5 "truc") would evaluate to
10185 45723a2aff78ff4fff7fff1114760e62 rather than the expected
10186 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 10187 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 10188
0f6990a7
PE
101892011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10190
10191 Integer overflow fixes.
c8a9ca5a 10192
08686060
PE
10193 * dbusbind.c: Serial number integer overflow fixes.
10194 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
10195 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
10196 to hold a serial number that is too large for a fixnum.
10197 (Fdbus_method_return_internal, Fdbus_method_error_internal):
10198 Check for serial numbers out of range. Decode any serial number
59568bf0 10199 that was so large that it became a float. (Bug#8722)
08686060 10200
2d1fc3c7
PE
10201 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
10202 (Fdbus_call_method, Fdbus_call_method_asynchronously):
10203 Use XFASTINT rather than XUINT when numbers are nonnegative.
10204 (xd_append_arg, Fdbus_method_return_internal):
10205 (Fdbus_method_error_internal): Likewise. Also, for unsigned
10206 arguments, check that Lisp number is nonnegative, rather than
59568bf0 10207 silently wrapping negative numbers around. (Bug#8722)
30217ff0 10208 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 10209 (Bug#8722)
2d1fc3c7 10210
c8a9ca5a
PE
10211 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
10212
519e1d69
PE
10213 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
10214
6df6ae42 10215 ccl: Add integer overflow checks.
30569699
PE
10216 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
10217 (IN_INT_RANGE): New macros.
10218 (ccl_driver): Use them to check for integer overflow when
10219 decoding a CCL program. Many of the new checks are whether XINT (x)
10220 fits in int; it doesn't always, on 64-bit hosts. The new version
10221 doesn't catch all possible integer overflows, but it's an
847044ea 10222 improvement. (Bug#8719)
30569699 10223
c11285dc
PE
10224 * alloc.c (make_event_array): Use XINT, not XUINT.
10225 There's no need for unsigned here.
10226
fdccd48e
PE
10227 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
10228 This follows up to the 2011-05-06 change that substituted uintptr_t
10229 for EMACS_INT. This case wasn't caught back then.
10230
37910ab2
PE
10231 Rework Fformat to avoid integer overflow issues.
10232 * editfns.c: Include <float.h> unconditionally, as it's everywhere
10233 now (part of C89). Include <verify.h>.
10234 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
10235 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
10236 (Fformat): Avoid the prepass trying to compute sizes; it was only
10237 approximate and thus did not catch overflow reliably. Instead, walk
10238 through the format just once, formatting and computing sizes as we go,
10239 checking for integer overflow at every step, and allocating a larger
10240 buffer as needed. Keep track separately whether the format is
10241 multibyte. Keep only the most-recently calculated precision, rather
10242 than them all. Record whether each argument has been converted to
10243 string. Use EMACS_INT, not int, for byte and char and arg counts.
10244 Support field widths and precisions larger than INT_MAX. Avoid
10245 sprintf's undefined behavior with conversion specifications such as %#d
10246 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
10247 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
10248 formatting out-of-range floating point numbers with int
9173deec 10249 formats. (Bug#8668)
37910ab2 10250
2e6578fb
PE
10251 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
10252
0ae6bdee
PE
10253 * data.c: Avoid integer truncation in expressions involving floats.
10254 * data.c: Include <intprops.h>.
10255 (arith_driver): When there's an integer overflow in an expression
10256 involving floating point, convert the integers to floating point
10257 so that the resulting value does not suffer from catastrophic
10258 integer truncation. For example, on a 64-bit host (* 4
10259 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
10260 Do not rely on undefined behavior after integer overflow.
10261
de883a70
PE
10262 merge count_size_as_multibyte, parse_str_to_multibyte
10263 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 10264 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
10265 Check for integer overflow.
10266 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
10267 since it's now a duplicate of the other. This is more of
10268 a character than a buffer op, so better that it's in character.c.
10269 * fns.c, print.c: Adjust to above changes.
10270
2ff916cb
PE
102712011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
10272
10273 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
10274
f1b54466
PE
102752011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10276
fb1ac845
PE
10277 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10278 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
10279 (x_clipboard_manager_save): Now static.
10280 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
10281
f1b54466
PE
10282 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10283 (crypto_hash_function): Now static.
10284 Fix pointer signedness problems. Avoid unnecessary initializations.
10285
a9f737ee
CY
102862011-05-27 Chong Yidong <cyd@stupidchicken.com>
10287
10288 * termhooks.h (Vselection_alist): Make it terminal-local.
10289
10290 * terminal.c (create_terminal): Initialize it.
10291
10292 * xselect.c: Support for clipboard managers.
10293 (Vselection_alist): Move to termhooks.h as terminal-local var.
10294 (LOCAL_SELECTION): New macro.
10295 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
10296 (symbol_to_x_atom): Remove gratuitous arg.
10297 (x_handle_selection_request, lisp_data_to_selection_data)
10298 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
10299 (x_own_selection, x_get_local_selection, x_convert_selection):
10300 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
10301 (some_frame_on_display): Delete unused function.
10302 (Fx_own_selection_internal, Fx_get_selection_internal)
10303 (Fx_disown_selection_internal, Fx_selection_owner_p)
10304 (Fx_selection_exists_p): New optional frame arg.
10305 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
10306 (x_handle_selection_clear): Don't treat other terminals with the
10307 same keyboard specially. Use the terminal-local Vselection_alist.
10308 (x_clear_frame_selections): Use Frun_hook_with_args.
10309
10310 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
10311
10312 * xterm.h: Add support for those atoms.
10313
e067f0c1
CY
103142011-05-26 Chong Yidong <cyd@stupidchicken.com>
10315
10316 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
10317 (converted_selections, conversion_fail_tag): New global variables.
10318 (x_selection_request_lisp_error): Free the above.
10319 (x_get_local_selection): Remove unnecessary code.
10320 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
10321 of converted selections stored in converted_selections.
10322 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
10323 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
10324 (x_convert_selection): New function.
10325 (x_handle_selection_event): Simplify.
10326 (x_get_foreign_selection): Don't ignore incoming requests while
10327 waiting for an answer; this will fail when we implement
10328 SAVE_TARGETS, and seems unnecessary anyway.
10329 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
10330 (Vx_sent_selection_functions): Doc fix.
10331
0f4aebc0
LL
103322011-05-26 Leo Liu <sdl.web@gmail.com>
10333
10334 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
10335
e61124cd
YM
103362011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10337
10338 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
10339
10340 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
10341 for fringe update if it has periodic bitmap.
ac389d0c 10342 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
10343 and fringe_bitmap_periodic_p.
10344
10345 * fringe.c (get_fringe_bitmap_data): New function.
10346 (draw_fringe_bitmap_1, update_window_fringes): Use it.
10347 (update_window_fringes): Record periodicity of fringe bitmap in glyph
10348 row. Mark glyph row for fringe update if periodicity changed.
10349
10350 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
10351 for fringe update unless it has periodic bitmap.
10352
f16d9837
KH
103532011-05-25 Kenichi Handa <handa@m17n.org>
10354
10355 * xdisp.c (get_next_display_element): Set correct it->face_id for
10356 a static composition.
10357
e1b90ef6
LL
103582011-05-24 Leo Liu <sdl.web@gmail.com>
10359
10360 * deps.mk (fns.o):
10361 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
10362
10363 * fns.c (crypto_hash_function, Fsha1): New function.
10364 (Fmd5): Use crypto_hash_function.
10365 (syms_of_fns): Add Ssha1.
10366
7400048f
PE
103672011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10368
10369 * gnutls.c: Remove unused macros.
10370 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
10371 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
10372 Remove macros that are defined and never used.
10373 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
10374
abb71cf4
CY
103752011-05-22 Chong Yidong <cyd@stupidchicken.com>
10376
10377 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
10378 (Fx_get_selection_internal): Minor cleanup.
10379 (Fx_own_selection_internal): Rename arguments for consistency with
10380 select.el.
10381
6307db39
PE
103822011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10383
10384 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
10385
f3d4e0a4
CY
103862011-05-22 Chong Yidong <cyd@stupidchicken.com>
10387
10388 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
10389
4d8ade89
YM
103902011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10391
10392 * dispnew.c (scrolling_window): Don't exclude the case that the
10393 last enabled row in the desired matrix touches the bottom boundary.
10394
32078c8d
GM
103952011-05-21 Glenn Morris <rgm@gnu.org>
10396
10397 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
10398 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
10399 and add some more files.
32078c8d 10400
7285dc67
EZ
104012011-05-20 Eli Zaretskii <eliz@gnu.org>
10402
10403 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
10404 report_file_error introduced by the change from 2011-05-07.
10405
89d1bd22
PE
104062011-05-20 Paul Eggert <eggert@cs.ucla.edu>
10407
10408 * systime.h (Time): Define only if emacs is defined.
10409 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
10410 where the include path doesn't have X11/X.h by default. See
10411 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
10412
cd394be1 104132011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
10414
10415 * composite.c (find_automatic_composition): Fix previous change.
10416
b9704ad9
GM
104172011-05-20 Glenn Morris <rgm@gnu.org>
10418
10419 * lisp.mk: New file, split from Makefile.in.
10420 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
10421 (shortlisp): Remove.
10422 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
10423
4a720484
GM
104242011-05-19 Glenn Morris <rgm@gnu.org>
10425
10426 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
10427 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
10428 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
10429 (lisp): Set the order to that of loadup.el.
10430 (shortlisp): Make it a copy of $lisp.
10431 (SOME_MACHINE_LISP): Remove.
10432 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
10433 Use just $shortlisp, not $SOME_MACHINE_LISP too.
10434
a28d4396
KH
104352011-05-18 Kenichi Handa <handa@m17n.org>
10436
10437 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
10438 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
10439 (find_automatic_composition): Mostly rewrite for efficiency.
10440
a2b1fa8e
JB
104412011-05-18 Juanma Barranquero <lekktu@gmail.com>
10442
10443 * makefile.w32-in: Update dependencies.
10444
8e1f5610
CS
104452011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
10446
10447 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 10448 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 10449
7025ee00 104502011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 10451
cdfa6eab
PE
10452 Fix some integer overflow issues, such as string length overflow.
10453
06d6db33
PE
10454 * insdel.c (count_size_as_multibyte): Check for string overflow.
10455
2b4560a8
PE
10456 * character.c (lisp_string_width): Check for string overflow.
10457 Use EMACS_INT, not int, for string indexes and lengths; in
10458 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
10459 the resulting string length overflows an EMACS_INT; instead,
10460 report a string overflow if no precision given. When checking for
10461 precision exhaustion, use a check that cannot possibly have
10462 integer overflow. (Bug#8675)
10463 * character.h (lisp_string_width): Adjust to new signature.
10464
cb93f9be
PE
10465 * alloc.c (string_overflow): New function.
10466 (Fmake_string): Use it. This doesn't change behavior, but saves
10467 a few bytes and will simplify future changes.
10468 * character.c (string_escape_byte8): Likewise.
10469 * lisp.h (string_overflow): New decl.
10470
1a1f3366
PE
10471 Fixups, following up to the user-interface timestamp change.
10472 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
10473 for UI timestamps, instead of unsigned long.
9fbd6841
PE
10474 * msdos.c (mouse_get_pos): Likewise.
10475 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
10476 * w32gui.h (Time): Define by including "systime.h" rather than by
10477 declaring it ourselves. (Bug#8664)
10478
d4e3e4d3
PE
10479 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
10480 * image.c (clear_image_cache): Likewise.
10481
f6a24d19
PE
10482 * term.c (term_mouse_position): Don't assume time_t wraparound.
10483
08dc5ae6
PE
10484 Be more systematic about user-interface timestamps.
10485 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
10486 and sometimes 'EMACS_UINT', to represent these timestamps.
10487 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
10488 This makes the code easier to follow, and makes it easier to catch
10489 integer overflow bugs such as Bug#8664.
10490 * frame.c (Fmouse_position, Fmouse_pixel_position):
10491 Use Time, not unsigned long, for user-interface timestamps.
10492 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
10493 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
10494 * keyboard.h (last_event_timestamp): Likewise.
10495 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
10496 * menu.h (xmenu_show): Likewise.
10497 * term.c (term_mouse_position): Likewise.
10498 * termhooks.h (struct input_event.timestamp): Likewise.
10499 (struct terminal.mouse_position_hook): Likewise.
10500 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
10501 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
10502 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
10503 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
10504 what it was before.
10505 * menu.h, termhooks.h: Include "systime.h", for Time.
10506
8e55734a
PE
10507 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
10508 Don't assume that the difference between two unsigned long values
10509 can fit into an integer. At this point, we know button_down_time
10510 <= event->timestamp, so the difference must be nonnegative, so
10511 there's no need to cast the result if double-click-time is
10512 nonnegative, as it should be; check that it's nonnegative, just in
10513 case. This bug is triggered when events are more than 2**31 ms
86db42d2 10514 apart (about 25 days). (Bug#8664)
8e55734a 10515
841f1b75 10516 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 10517 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 10518
3e26f69c
PE
10519 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
10520 that always fit in int. Use a sentinel instead of a counter, to
10521 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
10522 * frame.h (struct frame): Use int for menu_bar_items_used
10523 instead of EMACS_INT, since it always fits in int.
3e26f69c 10524
5cc152c0
PE
10525 * menu.c (grow_menu_items): Check for int overflow.
10526
d89eb65e
PE
10527 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
10528
5235bd3e
PE
10529 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
10530 Before, the code was not consistent. These values cannot exceed
10531 2**31 - 1 so there's no need to make them unsigned.
10532 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
10533 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
10534 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
10535 as modifiers.
10536 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
10537
bc827e23
PE
10538 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
10539 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
10540 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
10541 presumably because the widths might not match.
10542
78eb494e
PE
10543 * window.c (size_window): Avoid needless test at loop start.
10544
04f2d78b
CB
105452011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
10546
10547 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
10548
d2fc7e3d 105492011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
10550
10551 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
10552
d2fc7e3d 105532011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
10554
10555 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
10556 `width' to `bar_area_x' and `bar_area_width', respectively.
10557 (x_scroll_run): Take account of fringe background extension.
10558
04f2d78b
CB
10559 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
10560 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
10561 `bar_area_width', respectively.
10562 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
10563 background extension.
10564
79b70037
GM
105652011-05-10 Jim Meyering <meyering@redhat.com>
10566
10567 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
10568
2f142cc5
JB
105692011-05-10 Juanma Barranquero <lekktu@gmail.com>
10570
10571 * image.c (Finit_image_library): Return t for built-in image types,
10572 like pbm and xbm. (Bug#8640)
10573
57679c86
AS
105742011-05-09 Andreas Schwab <schwab@linux-m68k.org>
10575
10576 * w32menu.c (set_frame_menubar): Fix submenu allocation.
10577
888c9e86
EZ
105782011-05-07 Eli Zaretskii <eliz@gnu.org>
10579
b0512a1d
EZ
10580 * w32console.c (Fset_screen_color): Doc fix.
10581 (Fget_screen_color): New function.
10582 (syms_of_ntterm): Defsubr it.
10583
7285dc67
EZ
10584 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
10585 unlink the temporary file if Fcall_process didn't create it in the
10586 first place.
10587 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
10588 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
10589 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
10590 cue to call_process_cleanup not to close that handle.
10591
4d3fcc8e
BK
105922011-05-07 Ben Key <bkey76@gmail.com>
10593
10594 * makefile.w32-in: The bootstrap-temacs rule now makes use of
10595 one of two shell specific rules, either bootstrap-temacs-CMD or
10596 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
10597 to the previous implementation of the bootstrap-temacs rule.
10598 The bootstrap-temacs-CMD rule is similar to the previous
10599 implementation of the bootstrap-temacs rule except that it
10600 makes use of the ESC_CFLAGS variable instead of the CFLAGS
10601 variable.
10602
10603 These changes, along with some changes to nt/configure.bat,
10604 nt/gmake.defs, and nt/nmake.defs, are required to extend my
10605 earlier fix to add support for --cflags and --ldflags options
10606 that include quotes so that it works whether make uses cmd or
10607 sh as the shell.
10608
b4289b64
MA
106092011-05-06 Michael Albinus <michael.albinus@gmx.de>
10610
10611 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
10612 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
10613 is a constant.
10614 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
10615 a string. Handle both cases.
10616 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
10617 (Fdbus_register_method): Use Qinvalid_function.
10618
af4c0e28
JB
106192011-05-06 Juanma Barranquero <lekktu@gmail.com>
10620
10621 * makefile.w32-in: Update dependencies.
10622 (LISP_H): Add inttypes.h and stdin.h.
10623 (PROCESS_H): Add unistd.h.
10624
c51453d9
EZ
106252011-05-06 Eli Zaretskii <eliz@gnu.org>
10626
10627 * lread.c: Include limits.h (fixes the MS-Windows build broken by
10628 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
10629
8ff0ac3c 106302011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 10631
4c4b566b
PE
10632 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
10633
aab2b9b5
PE
10634 * term.c (vfatal): Remove stray call to va_end.
10635 It's not needed and the C Standard doesn't allow it here anyway.
10636
c378da0b
PE
10637 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
10638 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
10639
288b08c7
PE
10640 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
10641 bytes.
10642
e3601888
PE
10643 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
10644
db6c0e74
PE
10645 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
10646
dd5963ea
PE
10647 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
10648
88c9450f
PE
10649 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
10650
2f9442b8
PE
10651 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
10652
c032b5f8
PE
10653 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
10654 * charset.c (Fdefine_charset_internal): Don't initialize
10655 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 10656 32-bit int (Bug#8600).
a108c10b
PE
10657
10658 * lread.c (read_integer): Be more consistent with string-to-number.
10659 Use string_to_number to do the actual conversion; this avoids
10660 rounding errors and fixes some other screwups. Without this fix,
10661 for example, #x1fffffffffffffff was misread as -2305843009213693952.
10662 (digit_to_number): Move earlier, for benefit of read_integer.
10663 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 10664 not a digit in any supported base. (Bug#8602)
a108c10b 10665
ad5f9eea
PE
10666 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
10667
aec1708a
PE
10668 * dispnew.c (scrolling_window): Return 1 if we scrolled,
10669 to match comment at start of function. This also removes a
10670 GCC warning about overflow in a 32+64-bit port.
10671
47be4ab5
PE
10672 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
10673
371cac43
PE
10674 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
10675 Reported by Stefan Monnier in
10676 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
10677 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10678 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 10679
d01a7826
PE
10680 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
10681 (EMACS_UINTPTR): Likewise, with uintptr_t.
10682
7fd47d5c
PE
10683 * lisp.h: Prefer 64-bit EMACS_INT if available.
10684 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
10685 on 32-bit hosts that have 64-bit int, so that they can access
10686 large files.
122b0c86
PE
10687 However, temporarily disable this change unless the temporary
10688 symbol WIDE_EMACS_INT is defined.
7fd47d5c 10689
8727937b
PE
10690 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
10691
8ac068ac
PE
10692 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
10693 This removes an assumption that EMACS_INT and long are the same
10694 width as pointers. The assumption is true for Emacs porting targets
10695 now, but we want to make other targets possible.
10696 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
10697 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
10698 In the rest of the code, change types of integers that hold casted
10699 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
10700 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
10701 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
10702 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
10703 No need to cast type when ORing.
10704 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
10705 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
10706 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
10707 assume EMACS_INT is the same width as char *.
10708 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
10709 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
10710 Remove no-longer-needed casts.
10711 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
10712 (xg_tool_bar_help_callback, xg_make_tool_item):
10713 Use EMACS_INTPTR to hold an integer
10714 that will be cast to void *; this can avoid a GCC warning
10715 if EMACS_INT is not the same width as void *.
10716 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
10717 * xdisp.c (display_echo_area_1, resize_mini_window_1):
10718 (current_message_1, set_message_1):
10719 Use a local to convert to proper width without a cast.
10720 * xmenu.c (dialog_selection_callback): Likewise.
10721
ede49d71
PE
10722 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
10723 Also, don't assume VALBITS / RAND_BITS is less than 5,
10724 and don't rely on undefined behavior when shifting a 1 left into
10725 the sign bit.
10726 * lisp.h (get_random): Change signature to match.
10727
2f30ecd0
PE
10728 * lread.c (hash_string): Use size_t, not int, for hash computation.
10729 Normally we prefer signed values; but hashing is special, because
10730 it's better to use unsigned division on hash table sizes so that
10731 the remainder is nonnegative. Also, size_t is the natural width
10732 for hashing into memory. The previous code used 'int', which doesn't
10733 retain enough info to hash well into very large tables.
10734 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
10735
2a866e7b
PE
10736 * dbusbind.c: Don't possibly lose pointer info when converting.
10737 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10738 Use XPNTR rather than XHASH, so that the high-order bits of
10739 the pointer aren't lost when converting through void *.
10740
51639eac
PE
10741 * eval.c (Fautoload): Don't double-shift a pointer.
10742
92394119
PE
10743 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
10744
dbdb9a7c
JB
107452011-05-06 Juanma Barranquero <lekktu@gmail.com>
10746
10747 * gnutls.c (DEF_GNUTLS_FN):
10748 * image.c (DEF_IMGLIB_FN): Make function pointers static.
10749
db7a0b4f
AS
107502011-05-05 Andreas Schwab <schwab@linux-m68k.org>
10751
10752 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
10753 marker. (Bug#8610)
10754
cd394be1 107552011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
10756
10757 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
10758 New version that can reserve upto 2GB of heap space.
10759
f7ff1b0f 107602011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
10761
10762 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
10763
639c109b
TZ
107642011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
10765
10766 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
10767 `gnutls_certificate_set_x509_key_file'.
10768
d2127135
JB
107692011-05-05 Juanma Barranquero <lekktu@gmail.com>
10770
10771 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
10772 Update dependencies.
10773
e968f4f3
JB
107742011-05-04 Juanma Barranquero <lekktu@gmail.com>
10775
10776 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
10777 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
10778 Remove unused parameter `fildes'.
10779 * process.c (read_process_output, send_process): Don't pass it.
10780
84d358f0
JB
107812011-05-04 Juanma Barranquero <lekktu@gmail.com>
10782
10783 Fix previous change: the library cache is defined in w32.c.
10784 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
10785 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
10786
0898ca10
JB
107872011-05-04 Juanma Barranquero <lekktu@gmail.com>
10788
10789 Implement dynamic loading of GnuTLS on Windows.
10790
10791 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
10792 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
10793 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10794 Declare.
10795
10796 * gnutls.c (Qgnutls_dll): Define.
10797 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
10798 (gnutls_*): Declare function pointers.
10799 (init_gnutls_functions): New function to initialize function pointers.
10800 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
10801 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
10802 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10803 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
10804 (emacs_gnutls_write, emacs_gnutls_read)
10805 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
10806 (Fgnutls_available_p): New function.
10807 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
10808 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
10809 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
10810
10811 * image.c: Include w32.h.
10812 (Vimage_type_cache): Delete.
10813 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
10814 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
10815 (w32_delayed_load): Move to w32.c.
10816
10817 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
10818
10819 * w32.c (QCloaded_from, Vlibrary_cache): Define.
10820 (w32_delayed_load): Move from image.c. When loading a library, record
10821 its filename in the :loaded-from property of the library id.
10822 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
10823 Initialize and staticpro them.
10824 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
10825
10826 * process.c: Include lisp.h before w32.h, not after.
10827 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
10828 instead of gnutls_record_check_pending.
10829
10830 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
10831
ff4de4aa
TZ
108322011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
10833
10834 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
10835 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
10836 as passed in.
10837
abe95abb
JD
108382011-05-03 Jan Djärv <jan.h.d@swipnet.se>
10839
10840 * xterm.c (x_set_frame_alpha): Do not set property on anything
10841 else than FRAME_X_OUTER_WINDOW (Bug#8608).
10842
e16e55d4
JB
108432011-05-02 Juanma Barranquero <lekktu@gmail.com>
10844
10845 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
10846
bafcf6a5
JB
108472011-05-02 Juanma Barranquero <lekktu@gmail.com>
10848
10849 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
10850 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
10851 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
10852 (gnutls_global_initialized, Qgnutls_bootprop_priority)
10853 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
10854 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
10855 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
10856 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
10857 (Qgnutls_bootprop_callbacks_verify): Make static.
10858
e7a6747f
AS
108592011-05-01 Andreas Schwab <schwab@linux-m68k.org>
10860
19ed11ba
AS
10861 * callproc.c: Indentation fixup.
10862
e7a6747f 10863 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
10864 (wait_for_termination, interruptible_wait_for_termination):
10865 Move after wait_for_termination_1.
e7a6747f 10866
1ef14cb4
LMI
108672011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
10868
10869 * sysdep.c (interruptible_wait_for_termination): New function
10870 which is like wait_for_termination, but allows keyboard
10871 interruptions.
10872
10873 * callproc.c (Fcall_process): Add (:file "file") as an option for
10874 the STDOUT buffer.
10875 (Fcall_process_region): Ditto.
10876
330d880c
EZ
108772011-04-30 Eli Zaretskii <eliz@gnu.org>
10878
8db90b73
EZ
10879 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
10880 rather than `XVECTOR (FOO)->size'.
10881
330d880c
EZ
10882 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
10883 inttypes.h, as a gnulib replacement is used if it not available in
10884 system headers.
10885
15cbd324
EZ
108862011-04-21 Eli Zaretskii <eliz@gnu.org>
10887
10888 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
10889 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
10890 of MOST_POSITIVE_FIXNUM. (Bug#8528)
10891
10892 * coding.c (coding_alloc_by_realloc): Error out if destination
10893 will grow beyond MOST_POSITIVE_FIXNUM.
10894 (decode_coding_emacs_mule): Abort if there isn't enough place in
10895 charbuf for the composition carryover bytes. Reserve an extra
10896 space for up to 2 characters produced in a loop.
10897 (decode_coding_iso_2022): Abort if there isn't enough place in
10898 charbuf for the composition carryover bytes.
10899
109002011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 10901
ae940cca
EZ
10902 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
10903 aborting when %lld or %lll format is passed.
10904 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
10905 %llo or %llx format is passed. (Bug#8545)
10906
03ab8921
EZ
10907 * window.c (window_scroll_line_based): Use a marker instead of
10908 simple variables to record original value of point. (Bug#7952)
10909
afda1437
EZ
10910 * doprnt.c (doprnt): Fix the case where a multibyte sequence
10911 produced by %s or %c overflows available buffer space. (Bug#8545)
10912
f76dee0c
PE
109132011-04-28 Paul Eggert <eggert@cs.ucla.edu>
10914
10915 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 10916 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 10917
fdc5744d
JB
109182011-04-28 Juanma Barranquero <lekktu@gmail.com>
10919
10920 * w32.c (init_environment): Warn about defaulting HOME to C:\.
10921
638f053a
JB
109222011-04-28 Juanma Barranquero <lekktu@gmail.com>
10923
10924 * keyboard.c (Qdelayed_warnings_hook): Define.
10925 (command_loop_1): Run `delayed-warnings-hook'
10926 if Vdelayed_warnings_list is non-nil.
10927 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
10928 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
10929
d178f871
EZ
109302011-04-28 Eli Zaretskii <eliz@gnu.org>
10931
10932 * doprnt.c (doprnt): Don't return value smaller than the buffer
10933 size if the message was truncated. (Bug#8545).
10934
b124fd93
JB
109352011-04-28 Juanma Barranquero <lekktu@gmail.com>
10936
10937 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
10938 (Fx_window_property): #if-0 the whole functions, not just the bodies.
10939
e810457d
PE
109402011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10941
10942 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
10943
ea51cceb
JB
109442011-04-27 Juanma Barranquero <lekktu@gmail.com>
10945
10946 * makefile.w32-in: Update dependencies.
10947
94dcfacf
EZ
109482011-04-27 Eli Zaretskii <eliz@gnu.org>
10949
10950 Improve `doprnt' and its usage. (Bug#8545)
10951 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
10952 `format_end'. Remove support for %l as a conversion specifier.
10953 Don't use xrealloc. Improve diagnostics when the %l size modifier
10954 is used. Update the commentary.
10955
10956 * eval.c (verror): Simplify calculation of size_t.
10957
10958 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
10959 messages.
10960
f61f41d7
PE
109612011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
10962
10963 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
10964 change.
10965
96fb4434
PE
109662011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10967
10968 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
10969 This makes this file independent of the recent pseudovector change.
10970
671875da 109712011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 10972
69e9b5a3
PE
10973 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
10974
b5f869a7 10975 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 10976 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 10977 Remove unused local.
c8926152 10978 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 10979
841a1577 10980 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
10981 GCC 4.6.0 optimizes based on type-based alias analysis.
10982 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
10983 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
10984 != &v->size, and therefore "v->size = 1; b->size = 2; return
10985 v->size;" must therefore return 1. This assumption is incorrect
10986 for Emacs, since it type-puns struct Lisp_Vector * with many other
10987 types. To fix this problem, this patch adds a new type struct
f904488f 10988 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
10989 and pseudovectors, and helps optimizing compilers not get fooled
10990 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
10991 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
10992 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
10993 the size member.
eab3844f
PE
10994 (XSETPVECTYPE): Rewrite in terms of new macro.
10995 (XSETPVECTYPESIZE): New macro, specifying both type and size.
10996 This is a bit clearer, and further avoids the possibility of
10997 undesirable aliasing.
10998 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 10999 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
11000 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
11001 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
11002 (ASIZE): Now uses header.size rather than size.
11003 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
11004 to avoid the hassle of writing XVECTOR (foo)->header.size.
11005 (struct vectorlike_header): New type.
eab3844f
PE
11006 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
11007 object, to help avoid aliasing.
11008 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
11009 (SUBRP): Likewise, since Lisp_Subr is a special case.
11010 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
11011 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
11012 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 11013 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
11014 changed to be "header.size" and "header.next".
11015 * buffer.h (struct buffer): Likewise.
11016 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
11017 * frame.h (struct frame): Likewise.
11018 * process.h (struct Lisp_Process): Likewise.
11019 * termhooks.h (struct terminal): Likewise.
11020 * window.c (struct save_window_data, struct saved_window): Likewise.
11021 * window.h (struct window): Likewise.
11022 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
11023 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
11024 * buffer.c (init_buffer_once): Likewise.
11025 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
11026 special case.
11027 * process.c (Fformat_network_address): Use local var for size,
11028 for brevity.
11029
0df1eac5
PE
11030 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
11031
847ab9d1 11032 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
11033 * data.c (atof): Remove decl; no longer used or needed.
11034 (digit_to_number): Move to lread.c.
11035 (Fstring_to_number): Use new string_to_number function, to be
11036 consistent with how the Lisp reader treats infinities and NaNs.
11037 Do not assume that floating-point numbers represent EMACS_INT
11038 without losing information; this is not true on most 64-bit hosts.
11039 Avoid double-rounding errors, by insisting on integers when
11040 parsing non-base-10 numbers, as the documentation specifies.
11041 * lisp.h (string_to_number): New decl, replacing ...
11042 (isfloat_string): Remove.
bc0a5c13 11043 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 11044 (read1): Do not accept +. and -. as integers; this
452f4150
PE
11045 appears to have been a coding error. Similarly, do not accept
11046 strings like +-1e0 as floating point numbers. Do not report
11047 overflow for integer overflows unless the base is not 10 which
11048 means we have no simple and reliable way to continue.
11049 Break out the floating-point parsing into a new
11050 function string_to_number, so that Fstring_to_number parses
11051 floating point numbers consistently with the Lisp reader.
04f2d78b 11052 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
11053 (E_CHAR, EXP_INT): Remove, replacing with ...
11054 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
11055 (string_to_number): New function, replacing isfloat_string.
11056 This function checks for valid syntax and produces the resulting
11057 Lisp float number too. Rework it so that string-to-number
bc0a5c13 11058 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
11059 so that overflow for non-base-10 numbers is reported only when
11060 there's no portable and simple way to convert to floating point.
452f4150 11061
67769ffc
PE
11062 * textprop.c (set_text_properties_1): Rewrite for clarity,
11063 and to avoid GCC warning about integer overflow.
11064
c20db43f
PE
11065 * intervals.h (struct interval): Use EMACS_INT for members
11066 where EMACS_UINT might cause problems. See
11067 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
11068 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
11069 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
11070 All uses changed.
37aa2f85
PE
11071 (offset_intervals): Tell GCC not to worry about length overflow
11072 when negating a negative length.
c20db43f 11073
2538aa2f
PE
11074 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
11075 (overrun_check_free): Likewise.
11076
f2d3008d
PE
11077 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
11078 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
11079 word size.
11080
ec8df744
PE
11081 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11082 (gnutls_make_error): Rename local to avoid shadowing.
11083 (gnutls_emacs_global_deinit): ifdef out; not used.
11084 (Fgnutls_boot): Use const for pointer to readonly storage.
11085 Comment out unused local. Fix pointer signedness problems.
11086
640ee02d
PE
11087 * lread.c (openp): Don't stuff size_t into an 'int'.
11088 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
11089 about possible signed overflow.
11090
6048fb2a
PE
11091 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11092 (GDK_KEY_g): Don't define if already defined.
11093 (xg_prepare_tooltip): Avoid pointer signedness problem.
11094 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
11095
fa3c87e1
PE
11096 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
11097 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
11098
2172544b
PE
11099 * xfns.c (Fx_window_property): Simplify a bit,
11100 to make a bit faster and to avoid GCC 4.6.0 warning.
11101 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
11102
9b821a21
PE
11103 * fns.c (internal_equal): Don't assume size_t fits in int.
11104
3c616cfa
PE
11105 * alloc.c (compact_small_strings): Tighten assertion a little.
11106
c2982e87
PE
11107 Replace pEd with more-general pI, and fix some printf arg casts.
11108 * lisp.h (pI): New macro, generalizing old pEd macro to other
11109 conversion specifiers. For example, use "...%"pI"d..." rather
11110 than "...%"pEd"...".
11111 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 11112 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
11113 * alloc.c (check_pure_size): Don't overflow by converting size to int.
11114 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
11115 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
11116 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
11117 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
11118 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
11119 64-bit hosts.
11120 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
11121 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
11122 * print.c (safe_debug_print, print_object): Likewise.
11123 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
11124 to int.
6f04d126
PE
11125 Use pI instead of if-then-else-abort. Use %p to avoid casts,
11126 avoiding the 0 flag, which is not portable.
c2982e87
PE
11127 * process.c (Fmake_network_process): Use pI to avoid cast.
11128 * region-cache.c (pp_cache): Likewise.
11129 * xdisp.c (decode_mode_spec): Likewise.
11130 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
11131 behavior on 64-bit hosts with printf arg.
6f04d126 11132 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
11133 (x_stop_queuing_selection_requests): Likewise.
11134 (x_get_window_property): Don't truncate byte count to an 'int'
11135 when tracing.
0b432f21 11136
5e073ec7
PE
11137 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
11138 here, since it parses constructs like leading '-' and spaces,
11139 which are not wanted; and it overflows with large numbers.
11140 Instead, simply match F[0-9]+, which is what is wanted anyway.
11141
36372bf9
PE
11142 * alloc.c: Remove unportable assumptions about struct layout.
11143 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
11144 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
11145 (allocate_vectorlike, make_pure_vector): Use the new macros,
11146 plus offsetof, to remove unportable assumptions about struct layout.
11147 These assumptions hold on all porting targets that I know of, but
11148 they are not guaranteed, they're easy to remove, and removing them
11149 makes further changes easier.
11150
0b432f21
PE
11151 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
11152 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
11153 (string_overrun_cookie): Now const. Use initializers that
11154 don't formally overflow signed char, to avoid warnings.
000098c1
PE
11155 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
11156 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
11157 (allocate_buffer): Don't assume sizeof (struct buffer) is a
11158 multiple of sizeof (EMACS_INT); it need not be, if
11159 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 11160 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 11161
895009e1
JB
111622011-04-26 Juanma Barranquero <lekktu@gmail.com>
11163
11164 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
11165
6a7a1b0b
TZ
111662011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
11167
11168 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 11169 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
11170 Reported by Paul Eggert <eggert@cs.ucla.edu>.
11171
841a1577 111722011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
11173
11174 * lisp.h (Qdebug): List symbol.
895009e1 11175 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
11176 * keyboard.c (debug-on-event): New variable.
11177 (handle_user_signal): Break into debugger when debug-on-event
11178 matches the current signal symbol.
11179
f2d3ba6f
DN
111802011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
11181
11182 * alloc.c (check_sblock, check_string_bytes)
11183 (check_string_free_list): Convert to standard C.
11184
42ce4c63
TZ
111852011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
11186
11187 * w32.c (emacs_gnutls_push): Fix typo.
11188
825cd63c
EZ
111892011-04-25 Eli Zaretskii <eliz@gnu.org>
11190
fb11d64d
EZ
11191 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
11192 "cast to pointer from integer of different size".
11193
825cd63c
EZ
11194 Improve doprnt and its use in verror. (Bug#8545)
11195 * doprnt.c (doprnt): Document the set of format control sequences
11196 supported by the function. Use SAFE_ALLOCA instead of always
11197 using `alloca'.
11198
11199 * eval.c (verror): Don't limit the buffer size at size_max-1, that
11200 is one byte too soon. Don't use xrealloc; instead xfree and
11201 xmalloc anew.
11202
e061a11b
TZ
112032011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
11204
11205 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
11206 callbacks stage.
11207
11208 * gnutls.c: Renamed global_initialized to
11209 gnutls_global_initialized. Added internals for the
11210 :verify-hostname-error, :verify-error, and :verify-flags
11211 parameters of `gnutls-boot' and documented those parameters in the
11212 docstring. Start callback support.
9173deec
JB
11213 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
11214 unless a fatal error occurred. Call gnutls_alert_send_appropriate
11215 on error. Return error code.
e061a11b
TZ
11216 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
11217 (emacs_gnutls_read): Likewise.
11218 (Fgnutls_boot): Return handshake error code.
11219 (emacs_gnutls_handle_error): New function.
11220 (wsaerror_to_errno): Likewise.
11221
11222 * w32.h (emacs_gnutls_pull): Add prototype.
11223 (emacs_gnutls_push): Likewise.
11224
11225 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
11226 (emacs_gnutls_push): Likewise.
11227
112282011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
11229
11230 * process.c (wait_reading_process_output): Check if GnuTLS
11231 buffered some data internally if no FDs are set for TLS
11232 connections.
11233
11234 * makefile.w32-in (OBJ2): Add gnutls.$(O).
11235 (LIBS): Link to USER_LIBS.
11236 ($(BLD)/gnutls.$(0)): New target.
11237
fa6996bc
EZ
112382011-04-24 Eli Zaretskii <eliz@gnu.org>
11239
eb35682e
EZ
11240 * xdisp.c (handle_single_display_spec): Rename the
11241 display_replaced_before_p argument into display_replaced_p, to
11242 make it consistent with the commentary. Fix typos in the
11243 commentary.
11244
e2ad650c
EZ
11245 * textprop.c (syms_of_textprop): Remove dead code.
11246 (copy_text_properties): Delete obsolete commentary about an
11247 interface that was deleted long ago. Fix typos in the description
11248 of arguments.
11249
1b2de274
EZ
11250 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
11251 to changes in oldXMenu/XMenu.h from 2011-04-16.
11252 <menu_help_message, prev_menu_help_message>: Constify.
11253 (IT_menu_make_room): menu->help_text is now `const char **';
11254 adjust.
11255
11256 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
11257 to changes in oldXMenu/XMenu.h from 2011-04-16.
11258 (struct XMenu): Declare `help_text' `const char **'.
11259
11260 * xfaces.c <Qunspecified>: Make extern again.
11261
11262 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 11263 required by POSIX.
1b2de274 11264
762b15be
EZ
11265 * doc.c (get_doc_string): Improve the format passed to `error'.
11266
11267 * doprnt.c (doprnt): Improve commentary.
11268
11269 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
11270
11271 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
11272 them with etags.
11273
f1052e5d
EZ
11274 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
11275 changes in globals.h immediately force recompilation.
762b15be
EZ
11276 (TAGS): Depend on $(CURDIR)/m/intel386.h and
11277 $(CURDIR)/s/ms-w32.h.
11278 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 11279
fa6996bc
EZ
11280 * character.c (Fchar_direction): Function deleted.
11281 (syms_of_character): Don't defsubr it.
11282 <char-direction-table>: Deleted.
11283
e6c3da20
EZ
112842011-04-23 Eli Zaretskii <eliz@gnu.org>
11285
11286 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
11287 * doprnt.c: Include limits.h.
11288 (SIZE_MAX): New macro.
04f2d78b
CB
11289 (doprnt): Return a size_t value. 2nd arg is now size_t.
11290 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
11291 Improve overflow protection. Support `l' modifier for integer
11292 conversions. Support %l conversion. Don't assume an EMACS_INT
11293 argument for integer conversions and for %c.
11294
11295 * lisp.h (doprnt): Restore prototype.
11296
11297 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
11298 $(SRC)/character.h.
11299
11300 * Makefile.in (base_obj): Add back doprnt.o.
11301
11302 * deps.mk (doprnt.o): Add back prerequisites.
11303 (callint.o): Depend on character.h.
11304
11305 * eval.c (internal_lisp_condition_case): Include the handler
11306 representation in the error message.
11307 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
11308 when breaking from the loop.
11309
11310 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
11311
11312 * callint.c (Fcall_interactively): When displaying error message
11313 about invalid control letter, pass the character's codepoint, not
11314 a pointer to its multibyte form. Improve display of the character
11315 in octal and display also its hex code.
11316
11317 * character.c (char_string): Use %x to display the (unsigned)
11318 codepoint of an invalid character, to avoid displaying a bogus
11319 negative value.
11320
11321 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
11322 `error', not SYMBOL_NAME itself.
11323
11324 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
11325 character arguments to `error'.
11326
11327 * charset.c (check_iso_charset_parameter): Fix incorrect argument
11328 to `error' in error message about FINAL_CHAR argument. Make sure
11329 FINAL_CHAR is a character, and use %c when it is passed as
11330 argument to `error'.
11331
4ffd0d6b 113322011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
11333
11334 * s/ms-w32.h (localtime): Redirect to sys_localtime.
11335
11336 * w32.c: Include <time.h>.
11337 (sys_localtime): New function.
11338
4ffd0d6b 113392011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
11340
11341 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
11342
4ffd0d6b 11343 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 11344
4ffd0d6b 113452011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 11346
4ffd0d6b
GM
11347 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
11348 zombies (Bug#8467).
aac0c6e3 11349
04c56954
EZ
113502011-04-19 Eli Zaretskii <eliz@gnu.org>
11351
11352 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
11353 gl_state.e_property when gl_state.object is Qt.
11354
11355 * insdel.c (make_gap_larger): Remove limitation of buffer size
11356 to <= INT_MAX.
11357
16a43933
CY
113582011-04-18 Chong Yidong <cyd@stupidchicken.com>
11359
11360 * xdisp.c (lookup_glyphless_char_display)
11361 (produce_glyphless_glyph): Handle cons cell entry in
11362 glyphless-char-display.
11363 (Vglyphless_char_display): Document it.
11364
11365 * term.c (produce_glyphless_glyph): Handle cons cell entry in
11366 glyphless-char-display.
11367
4581706e
CY
113682011-04-17 Chong Yidong <cyd@stupidchicken.com>
11369
11370 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
11371
11372 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
11373
11374 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
11375 definition for no-X builds.
11376
4887c6e2 113772011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 11378
fd35b6f9
PE
11379 Static checks with GCC 4.6.0 and non-default toolkits.
11380
5c1ccb01
PE
11381 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
11382
006c5daa
PE
11383 * process.c (keyboard_bit_set): Define only if SIGIO.
11384 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
11385 (send_process): Repair possible setjmp clobbering.
11386
efc736d3
PE
11387 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
11388
4e2fe2e6
PE
11389 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
11390
f97334a2
PE
11391 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
11392
4e75f29d
PE
11393 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
11394 Define only if needed.
11395
90efadd1
PE
11396 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
11397 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 11398 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 11399
3c647824
PE
11400 * dispextern.h (struct redisplay_interface): Rename param
11401 to avoid shadowing.
e264f262 11402 * termhooks.h (struct terminal): Likewise.
761383f4 11403 * xterm.c (xembed_send_message): Likewise.
3c647824 11404
b58c5c4a
PE
11405 * insdel.c (make_gap_smaller): Define only if
11406 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
11407
cad59032
PE
11408 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
11409 it.
11410
c339dc2e
PE
11411 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
11412 so that we aren't warned about unused symbols.
11413
91a3e27b
PE
11414 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
11415
399c71d3 11416 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 11417
8ffc96f5
PE
11418 * xfns.c (x_real_positions): Mark locals as initialized.
11419
eef9bc79
PE
11420 * xmenu.c (xmenu_show): Don't use uninitialized vars.
11421
098db9dd
PE
11422 * xterm.c: Fix problems found by static analysis with other toolkits.
11423 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
11424 (x_dispatch_event): Declare static if USE_GTK, and
11425 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 11426 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 11427 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
11428 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
11429 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 11430
eb18f6cc
PE
11431 * xmenu.c (menu_help_callback): Pointer type fixes.
11432 Use const pointers when pointing at readonly data. Avoid pointer
11433 signedness clashes.
11434 (FALSE): Remove unused macro.
11435 (update_frame_menubar): Remove unused decl.
11436
1fe72bf8
PE
11437 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
11438
60d9e1db
PE
11439 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
11440 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
11441 (single_menu_item): Rename local to avoid shadowing.
11442
39261c26
PE
11443 * keyboard.c (make_lispy_event): Remove unused local var.
11444
018c5e19
PE
11445 * frame.c, frame.h (x_get_resource_string): Bring this back, but
11446 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
11447
63d2b86e
PE
11448 * bitmaps: Change bitmaps from unsigned char back to the X11
11449 compatible char. Avoid the old compiler warnings about
11450 out-of-range initializers by using, for example, '\xab' rather
11451 than 0xab.
11452
aefd87e1
PE
11453 * xgselect.c (xgselect_initialize): Check vs interface
11454 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
11455
bf501fb9
PE
11456 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
11457
e9829fdf
PE
11458 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
11459 to read-only memory.
11460
1086c095
PE
11461 * fns.c (vector): Remove; this old hack is no longer needed.
11462
2baccd04 11463 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 11464 Remove unused var.
dde42981 11465 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 11466
72391843 11467 * xrdb.c (x_load_resources): Omit unused local.
3565b346 11468
436c16df 11469 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 11470 (x_window): Rename locals to avoid shadowing.
dc5ddd85 11471 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 11472
92bb796d 11473 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 11474 (x_term_init): Remove local to avoid shadowing.
92bb796d 11475
764430a3 11476 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
11477
11478 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
11479 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
11480
d1dfb56c
EZ
114812011-04-16 Eli Zaretskii <eliz@gnu.org>
11482
c4354cb4
EZ
11483 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
11484
d1dfb56c
EZ
11485 Fix regex.c, syntax.c and friends for buffers > 2GB.
11486 * syntax.h (struct gl_state_s): Declare character position members
11487 EMACS_INT.
11488
11489 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
11490
04f2d78b
CB
11491 * textprop.c (verify_interval_modification, interval_of):
11492 Declare arguments EMACS_INT.
d1dfb56c
EZ
11493
11494 * intervals.c (adjust_intervals_for_insertion): Declare arguments
11495 EMACS_INT.
11496
11497 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
11498
11499 * indent.c (Fvertical_motion): Local variable it_start is now
11500 EMACS_INT.
11501
11502 * regex.c (re_match, re_match_2, re_match_2_internal)
11503 (bcmp_translate, regcomp, regexec, print_double_string)
11504 (group_in_compile_stack, re_search, re_search_2, regex_compile)
11505 (re_compile_pattern, re_exec): Declare arguments and local
11506 variables `size_t' and `ssize_t' and return values `regoff_t', as
11507 appropriate.
11508 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
11509 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
11510 <compile_stack_type>: `size' and `avail' are now `size_t'.
11511
11512 * regex.h <regoff_t>: Use ssize_t, not int.
11513 (re_search, re_search_2, re_match, re_match_2): Arguments that
11514 specify buffer/string position and length are now ssize_t and
11515 size_t. Return type is regoff_t.
11516
613052cd
BK
115172011-04-16 Ben Key <bkey76@gmail.com>
11518
11519 * nsfont.m: Fixed bugs in ns_get_family and
11520 ns_descriptor_to_entity that were caused by using free to
11521 deallocate memory blocks that were allocated by xmalloc (via
11522 xstrdup). This caused Emacs to crash when compiled with
11523 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
11524 --enable-checking=xmallocoverrun). xfree is now used to
11525 deallocate these memory blocks.
11526
4170f62f 115272011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 11528
71b41406
PE
11529 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
11530
9587a89d
PE
11531 emacs_write: Accept and return EMACS_INT for sizes.
11532 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
11533 et seq.
11534 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
11535 Accept and return EMACS_INT.
11536 (emacs_gnutls_write): Return the number of bytes written on
11537 partial writes.
11538 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
11539 (emacs_read, emacs_write): Remove check for negative size, as the
11540 Emacs source code has been audited now.
9587a89d
PE
11541 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
11542 (emacs_read, emacs_write): Use it.
273a5f82
PE
11543 * process.c (send_process): Adjust to the new signatures of
11544 emacs_write and emacs_gnutls_write. Do not attempt to store
11545 a byte offset into an 'int'; it might overflow.
9587a89d 11546 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 11547
3e047f51
PE
11548 * sound.c: Don't assume sizes fit in 'int'.
11549 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 11550 Return EMACS_INT, not int.
3e047f51 11551 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
11552 Accept EMACS_INT, not int.
11553 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
11554 record read return values.
11555
cc39a9db
BK
115562011-04-15 Ben Key <bkey76@gmail.com>
11557
c9d0ec6d
JB
11558 * keyboard.c (Qundefined): Don't declare static since it is used
11559 in nsfns.m.
11560 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
11561 static since they are used in nsfont.m.
cc39a9db 11562
6c60eb9f
SM
115632011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
11564
11565 * process.c (Qprocessp): Don't declare static.
11566 * lisp.h (Qprocessp): Declare again.
11567
7990b61a
JB
115682011-04-15 Juanma Barranquero <lekktu@gmail.com>
11569
11570 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
11571
5d4cb038
PE
115722011-04-14 Paul Eggert <eggert@cs.ucla.edu>
11573
8bd7b830 11574 Improve C-level modularity by making more things 'static'.
cd64ea1d 11575
e3b27b31
PE
11576 Don't publish debugger-only interfaces to other modules.
11577 * lisp.h (safe_debug_print, debug_output_compilation_hack):
11578 (verify_bytepos, count_markers): Move decls to the only modules
11579 that need them.
11580 * region-cache.h (pp_cache): Likewise.
11581 * window.h (check_all_windows): Likewise.
11582 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
11583
5d4cb038
PE
11584 * sysdep.c (croak): Now static, if
11585 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
11586 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
11587
11588 * alloc.c (refill_memory_reserve): Now static if
11589 !defined REL_ALLOC || defined SYSTEM_MALLOC.
11590 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 11591
e87b6180
PE
11592 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
11593 Define only if USE_LUCID.
11594
ac64929e
PE
11595 * xrdb.c (x_customization_string, x_rm_string): Now static.
11596
6f37259d
PE
11597 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
11598 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
11599
1683e3ab
PE
11600 * xdisp.c (draw_row_with_mouse_face): Now static.
11601 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
11602
de9c2632
PE
11603 * window.h (check_all_windows): Mark externally visible.
11604
2b96acb7
PE
11605 * window.c (window_deletion_count): Now static.
11606
11607 * undo.c: Make symbols static if they're not exported.
11608 (last_undo_buffer, last_boundary_position, pending_boundary):
11609 Now static.
11610
50436f33
PE
11611 * textprop.c (interval_insert_behind_hooks): Now static.
11612 (interval_insert_in_front_hooks): Likewise.
11613
64520e5c
PE
11614 * term.c: Make symbols static if they're not exported.
11615 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
11616 (max_frame_lines, tty_set_terminal_modes):
11617 (tty_reset_terminal_modes, tty_turn_off_highlight):
11618 (get_tty_terminal): Now static.
11619 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
11620 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 11621 HAVE_WINDOW_SYSTEM.
64520e5c
PE
11622 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
11623 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
11624
1fa53021
PE
11625 * sysdep.c: Make symbols static if they're not exported.
11626 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
11627 Now static.
11628 (sigprocmask_set, full_mask): Remove; unused.
11629 (wait_debugging): Mark as visible.
11630 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
11631 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
11632
d4b43b22
PE
11633 * syntax.c (syntax_temp): Define only if !__GNUC__.
11634
b7c513d0
PE
11635 * sound.c (current_sound_device, current_sound): Now static.
11636
989b29ad
PE
11637 * search.c (searchbufs, searchbuf_head): Now static.
11638
13a55a78
PE
11639 * scroll.c (scroll_cost): Remove; unused.
11640 * dispextern.h (scroll_cost): Remove decl.
11641
de68a1fc
PE
11642 * region-cache.h (pp_cache): Mark as externally visible.
11643
40ccffa6
PE
11644 * process.c: Make symbols static if they're not exported.
11645 (process_tick, update_tick, create_process, chan_process):
11646 (Vprocess_alist, proc_buffered_char, datagram_access):
11647 (fd_callback_data, send_process_frame, process_sent_to): Now static.
11648 (deactivate_process): Mark defn as static, as well as decl.
11649 * lisp.h (create_process): Remove decl.
11650 * process.h (chan_process, Vprocess_alist): Remove decls.
11651
ad64fc97
PE
11652 * print.c: Make symbols static if they're not exported.
11653 (print_depth, new_backquote_output, being_printed, print_buffer):
11654 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
11655 (print_interval, print_number_index, initial_stderr_stream):
11656 Now static.
11657 * lisp.h (Fprinc): Remove decl.
11658 (debug_output_compilation_hack): Mark as externally visible.
11659
adddb265
PE
11660 * sysdep.c (croak): Move decl from here to syssignal.h.
11661 * syssignal.h (croak): Put it here, so the API can be checked when
11662 'croak' is called from dissociate_if_controlling_tty.
11663
1717ede2
PE
11664 * minibuf.c: Make symbols static if they're not exported.
11665 (minibuf_save_list, choose_minibuf_frame): Now static.
11666 * lisp.h (choose_minibuf_frame): Remove decl.
11667
fa5fb2bc
PE
11668 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
11669
1e3890d1
PE
11670 * lread.c: Make symbols static if they're not exported.
11671 (read_objects, initial_obarray, oblookup_last_bucket_number):
11672 Now static.
11673 (make_symbol): Remove; unused.
11674 * lisp.h (initial_obarray, make_symbol): Remove decls.
11675
8a1414fa
PE
11676 * keyboard.c: Make symbols static if they're not exported.
11677 (single_kboard, recent_keys_index, total_keys, recent_keys):
11678 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
11679 (this_single_command_key_start, echoing, last_auto_save):
11680 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
11681 (command_loop, echo_now, keyboard_init_hook, help_char_p):
11682 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
11683 (Vlispy_mouse_stem, double_click_count):
11684 Now static.
11685 (force_auto_save_soon): Define only if SIGDANGER.
11686 (ignore_mouse_drag_p): Now static if
11687 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
11688 (print_help): Remove; unused.
11689 (stop_character, last_timer_event): Mark as externally visible.
11690 * keyboard.h (ignore_mouse_drag_p): Declare only if
11691 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
11692 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
11693 * lisp.h (echoing): Remove decl.
11694 (force_auto_save_soon): Declare only if SIGDANGER.
11695 * xdisp.c (redisplay_window): Simplify code, to make it more
11696 obvious that ignore_mouse_drag_p is not accessed if !defined
11697 USE_GTK && !defined HAVE_NS.
11698
93ea6e8f
PE
11699 * intervals.c: Make symbols static if they're not exported.
11700 (merge_properties_sticky, merge_interval_right, delete_interval):
11701 Now static.
11702 * intervals.h (merge_interval_right, delete_interval): Remove decls.
11703
77382fcc
PE
11704 * insdel.c: Make symbols static if they're not exported.
11705 However, leave prepare_to_modify_buffer alone. It's never
11706 called from outside this function, but that appears to be a bug.
11707 (combine_after_change_list, combine_after_change_buffer):
4889fc82 11708 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
11709 (adjust_after_replace_noundo): Remove; unused.
11710 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 11711 (signal_before_change): Remove decls.
77382fcc 11712
9306c32e
PE
11713 * indent.c (val_compute_motion, val_vmotion): Now static.
11714
cd44d2eb
PE
11715 * image.c: Make symbols static if they're not exported.
11716 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
11717 if USE_GTK.
11718 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
11719 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
11720
ad9a7a06
PE
11721 * fringe.c (standard_bitmaps): Now static.
11722 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
11723
81626931
PE
11724 * frame.c: Make symbols static if they're not exported.
11725 (x_report_frame_params, make_terminal_frame): Now static.
11726 (get_frame_param): Now static, unless HAVE_NS.
11727 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
11728 (x_get_resource_string): Remove; not used.
11729 * frame.h (make_terminal_frame, x_report_frame_params):
11730 (x_get_resource_string); Remove decls.
11731 (x_fullscreen_adjust): Declare only if WINDOWSNT.
11732 * lisp.h (get_frame_param): Declare only if HAVE_NS.
11733
239f9db9
PE
11734 * font.c, fontset.c: Make symbols static if they're not exported.
11735 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
11736 (FACE_SUITABLE_FOR_CHAR_P): Use it.
11737 * font.c (font_close_object): Now static.
11738 * font.h (font_close_object): Remove.
11739 * fontset.c (FONTSET_OBJLIST): Remove.
11740 (free_realized_fontset) #if-0 the body, which does nothing.
11741 (face_suitable_for_char_p): #if-0, as it's never called.
11742 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
11743 * xfaces.c (face_at_string_position):
11744 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
11745 since 0 is always ASCII.
11746
dfcf3579
PE
11747 * fns.c (weak_hash_tables): Now static.
11748
5045092b
PE
11749 * fileio.c: Make symbols static if they're not exported.
11750 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
11751 (Vwrite_region_annotation_buffers): Now static.
11752
57a96f5c
PE
11753 * eval.c: Make symbols static if they're not exported.
11754 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
11755 * lisp.h (backtrace_list): Remove decl.
11756
35f08c38
PE
11757 * emacs.c: Make symbols static if they're not exported.
11758 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
11759 (fatal_error_code, fatal_error_signal_hook, standard_args):
11760 Now static.
11761 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
11762 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
11763 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
11764 * lisp.h (fatal_error_signal_hook): Remove decl.
11765 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
11766
f44bd759
PE
11767 * editfns.c: Move a (normally-unused) function to its only use.
11768 * editfns.c, lisp.h (get_operating_system_release): Remove.
11769 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
11770 worth the hassle of breaking this out.
11771
b532497d
PE
11772 * xterm.c: Make symbols static if they're not exported.
11773 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
11774 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
11775 (x_destroy_window, x_delete_display):
11776 Now static.
11777 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
11778 (x_mouse_leave): Remove; unused.
11779 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
11780 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
11781 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
11782 Remove decls.
11783 (x_mouse_leave): Declare only if WINDOWSNT.
11784 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
11785 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
11786 USE_X_TOOLKIT.
11787
1675728f
PE
11788 * ftxfont.c: Make symbols static if they're not exported.
11789 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
11790 HAVE_FREETYPE.
11791 * font.h (ftxfont_driver): Likewise.
11792
e4cebfca
PE
11793 * xfns.c: Make symbols static if they're not exported.
11794 (x_last_font_name, x_display_info_for_name):
11795 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
11796 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
11797 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
11798 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
11799 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
11800 (last_show_tip_args): Now static.
11801 (xic_defaut_fontset, xic_create_fontsetname): Define only if
11802 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
11803 (x_screen_planes): Remove; unused.
11804 * dispextern.h (x_screen_planes): Remove decl.
11805
5bf46f05
PE
11806 * dispnew.c: Make symbols static if they're not exported.
11807 * dispextern.h (redraw_garbaged_frames, scrolling):
11808 (increment_row_positions): Remove.
11809 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
11810 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
11811 Now static.
11812 (redraw_garbaged_frames): Remove; unused.
11813
435f4c28
PE
11814 * xfaces.c: Make symbols static if they're not exported.
11815 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
11816 Remove decls.
11817 * xterm.h (defined_color): Remove decls.
11818 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
11819 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
11820 (menu_face_changed_default, defined_color, free_realized_face):
11821 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
11822 (ascii_face_of_lisp_face): Remove; unused.
11823
8524aef3
PE
11824 * xdisp.c: Make symbols static if they're not exported.
11825 * dispextern.h (scratch_glyph_row, window_box_edges):
11826 (glyph_to_pixel_coords, set_cursor_from_row):
11827 (get_next_display_element, set_iterator_to_next):
11828 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
11829 (show_mouse_face): Remove decls
11830 * frame.h (message_buf_print): Likewise.
11831 * lisp.h (pop_message, set_message, check_point_in_composition):
11832 Likewise.
11833 * xterm.h (set_vertical_scroll_bar): Likewise.
11834 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
11835 (message_buf_print, scratch_glyph_row, displayed_buffer):
11836 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
11837 (get_next_display_element, show_mouse_face, window_box_edges):
11838 (frame_to_window_pixel_xy, check_point_in_composition):
11839 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
11840 (glyph_to_pixel_coords): Remove; unused.
11841
16390cd2
PE
11842 * dired.c (file_name_completion): Now static.
11843
11844 * dbusbind.c (xd_in_read_queued_messages): Now static.
11845
a25f4dfa
PE
11846 * lisp.h (circular_list_error, FOREACH): Remove; unused.
11847 * data.c (circular_list_error): Remove.
11848
14a9c8df
PE
11849 * commands.h (last_point_position, last_point_position_buffer):
11850 (last_point_position_window): Remove decls.
11851 * keyboard.c: Make these variables static.
11852
04f2d78b
CB
11853 * coding.h (coding, code_convert_region, encode_coding_gap):
11854 Remove decls.
74ab6df5
PE
11855 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
11856 (iso_code_class, detect_coding, code_convert_region): Now static.
11857 (encode_coding_gap): Remove; unused.
11858
38dfbee1
PE
11859 * chartab.c (chartab_chars, chartab_bits): Now static.
11860
a2cb4e63
PE
11861 * charset.h (charset_iso_8859_1): Remove decl.
11862 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
11863 Now static.
11864
127198fd
PE
11865 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
11866 * ccl.c (Vccl_program_table): Now static.
11867 (check_ccl_update): Remove; unused.
11868
d85b608f
PE
11869 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
11870 * category.h: ... from here.
11871 * category.c (check_category_table, set_category_set): Now static.
11872
31cd66f3
PE
11873 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
11874 * lisp.h: Remove these decls.
11875
c358e587
PE
11876 * buffer.c (buffer_count): Remove unused var.
11877
e78aecca
PE
11878 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
11879 so that it's not optimized away.
11880 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
11881 * dispextern.h (bidi_dump_cached_states): Remove, since it's
11882 exported only to the debugger.
11883
e192d7d3 11884 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 11885 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 11886
92470028
PE
11887 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
11888 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
11889 was inaccessible from Lisp.
11890 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
11891 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
11892
244ed907
PE
11893 alloc.c: Import and export fewer symbols, and remove unused items.
11894 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
11895 is defined.
11896 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
11897 it's not optimized away by whole-program optimization.
11898 (message_enable_multibyte, free_misc): Remove.
11899 (catchlist, handlerlist, mark_backtrace):
11900 Declare only if BYTE_MARK_STACK.
11901 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
11902 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
11903 (message_enable_multibyte): Remove decl.
11904 (free_misc, interval_free_list, float_block, float_block_index):
11905 (n_float_blocks, float_free_list, cons_block, cons_block_index):
11906 (cons_free_list, last_marked_index):
11907 Now static.
11908 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
11909 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
11910 (mark_backtrace): Define only if BYTE_MARK_STACK.
11911 * xdisp.c (message_enable_multibyte): Now static.
11912
61c2b50e 11913 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
11914 This makes it easier for human readers (and static analyzers)
11915 to see whether these variables are used from other modules.
11916 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
11917 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
11918 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
11919 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
11920 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
11921 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
11922 * xmenu.c, xselect.c:
11923 Declare Q* vars static if they are not used in other modules.
11924 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
11925 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
11926 Remove decls of unexported vars.
11927 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
11928
95c82688
PE
11929 * lisp.h (DEFINE_FUNC): Make sname 'static'.
11930
16a97296
PE
11931 Make Emacs functions such as Fatom 'static' by default.
11932 This makes it easier for human readers (and static analyzers)
11933 to see whether these functions can be called from other modules.
11934 DEFUN now defines a static function. To make the function external
11935 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
11936 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
11937 (Finit_image_library):
16a97296
PE
11938 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
11939 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
11940 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
11941 Remove decls, since these functions are now static.
11942 (Funintern, Fget_internal_run_time): New decls, since these functions
11943 were already external.
95c82688 11944
16a97296
PE
11945 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
11946 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
11947 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
11948 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
11949 * keyboard.c, keymap.c, lread.c:
11950 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
11951 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
11952 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
11953 Mark functions with DEFUE instead of DEFUN,
11954 if they are used in other modules.
11955 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
11956 decls for now-static functions.
11957 * buffer.h (Fdelete_overlay): Remove decl.
11958 * callproc.c (Fgetenv_internal): Mark as internal.
11959 * composite.c (Fremove_list_of_text_properties): Remove decl.
11960 (Fcomposition_get_gstring): New forward static decl.
11961 * composite.h (Fcomposite_get_gstring): Remove decl.
11962 * dired.c (Ffile_attributes): New forward static decl.
11963 * doc.c (Fdocumntation_property): New forward static decl.
11964 * eval.c (Ffetch_bytecode): New forward static decl.
11965 (Funintern): Remove extern decl; now in .h file where it belongs.
11966 * fileio.c (Fmake_symbolic_link): New forward static decl.
11967 * image.c (Finit_image_library): New forward static decl.
11968 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
11969 * intervals.h (Fprevious_property_change):
11970 (Fremove_list_of_text_properties): Remove decls.
11971 * keyboard.c (Fthis_command_keys): Remove decl.
11972 (Fcommand_execute): New forward static decl.
11973 * keymap.c (Flookup_key): New forward static decl.
11974 (Fcopy_keymap): Now static.
11975 * keymap.h (Flookup_key): Remove decl.
11976 * process.c (Fget_process): New forward static decl.
11977 (Fprocess_datagram_address): Mark as internal.
11978 * syntax.c (Fsyntax_table_p): New forward static decl.
11979 (skip_chars): Remove duplicate decl.
11980 * textprop.c (Fprevious_property_change): New forward static decl.
11981 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
11982 Now internal.
11983 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
11984 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
11985
785bbd42
PE
11986 * editfns.c (Fformat): Remove unreachable code.
11987
8b913b57
AS
119882011-04-14 Andreas Schwab <schwab@linux-m68k.org>
11989
11990 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
11991 change. (Bug#8496)
11992
a6744a35
EZ
119932011-04-13 Eli Zaretskii <eliz@gnu.org>
11994
11995 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
11996 when at ZV. (Bug#8487)
11997
e7974947
AS
119982011-04-12 Andreas Schwab <schwab@linux-m68k.org>
11999
baad03f0
AS
12000 * charset.c (Fclear_charset_maps): Use xfree instead of free.
12001 (Bug#8437)
12002 * keyboard.c (parse_tool_bar_item): Likewise.
12003 * sound.c (sound_cleanup, alsa_close): Likewise.
12004 * termcap.c (tgetent): Likewise.
12005 * xfns.c (x_default_font_parameter): Likewise.
12006 * xsettings.c (read_and_apply_settings): Likewise.
12007
e7974947
AS
12008 * alloc.c (overrun_check_malloc, overrun_check_realloc)
12009 (overrun_check_free): Protoize.
12010
28272684
PE
120112011-04-12 Paul Eggert <eggert@cs.ucla.edu>
12012
12013 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
12014 since callers should never pass a negative size.
12015 Change the signature to match that of plain 'read' and 'write'; see
12016 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
12017 * lisp.h: Update prototypes of emacs_write and emacs_read.
12018
11997c76
EZ
120192011-04-11 Eli Zaretskii <eliz@gnu.org>
12020
12021 * xdisp.c (redisplay_window): Don't try to determine the character
12022 position of the scroll margin if the window start point w->startp
e896f03c 12023 is outside the buffer's accessible region. (Bug#8468)
11997c76 12024
8a2cbd72
EZ
120252011-04-10 Eli Zaretskii <eliz@gnu.org>
12026
12027 Fix write-region and its subroutines for buffers > 2GB.
12028 * fileio.c (a_write, e_write): Modify declaration of arguments and
12029 local variables to support buffers larger than 2GB.
12030 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
12031
12032 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
12033 argument, local variables, and return value.
12034
12035 * lisp.h: Update prototypes of emacs_write and emacs_read.
12036
12037 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
12038
4073e537 120392011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 12040
1ebfdcb6
PE
12041 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
12042
b2ded58d
PE
12043 Fix more problems found by GCC 4.6.0's static checks.
12044
7d66342c
PE
12045 * xdisp.c (vmessage): Use a better test for character truncation.
12046
bbf47d44
PE
12047 * charset.c (load_charset_map): <, not <=, for optimization,
12048 and to avoid potential problems with integer overflow.
9248994d 12049 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 12050 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 12051 * editfns.c (Fformat): Likewise.
1e69125e 12052 * syntax.c (skip_chars): Likewise.
3befa583 12053
e3019616
PE
12054 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
12055 This also lets GCC 4.6.0 generate slightly better loop code.
12056
becfa255
PE
12057 * callint.c (Fcall_interactively): <, not <=, for optimization.
12058 (Fcall_interactively): Count the number of arguments produced,
12059 not the number of arguments given. This is simpler and lets GCC
12060 4.6.0 generate slightly better code.
12061
dae0cd48
PE
12062 * ftfont.c: Distingish more carefully between FcChar8 and char.
12063 The previous code passed unsigned char * to a functions like
12064 strlen and xstrcasecmp that expect char *, which does not
12065 conform to the C standard.
12066 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
12067 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
12068 char * when the C standard requires it.
12069
76032d70
PE
12070 * keyboard.c (read_char): Remove unused var.
12071
eb3f1cc8
PE
12072 * eval.c: Port to Windows vsnprintf (Bug#8435).
12073 Include <limits.h>.
12074 (SIZE_MAX): Define if the headers do not.
12075 (verror): Do not give up if vsnprintf returns a negative count.
12076 Instead, grow the buffer. This ports to Windows vsnprintf, which
12077 does not conform to C99. Problem reported by Eli Zaretskii.
12078 Also, simplify the allocation scheme, by avoiding the need for
12079 calling realloc, and removing the ALLOCATED variable.
12080
70476b54
PE
12081 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
12082
12020a9e
PE
12083 Remove invocations of doprnt, as Emacs now uses vsnprintf.
12084 But keep the doprint source code for now, as we might revamp it
12085 and use it again (Bug#8435).
ea6c7ae6
PE
12086 * lisp.h (doprnt): Remove.
12087 * Makefile.in (base_obj): Remove doprnt.o.
12088 * deps.mk (doprnt.o): Remove.
12089
5fdb398c
PE
12090 error: Print 32- and 64-bit integers portably (Bug#8435).
12091 Without this change, on typical 64-bit hosts error ("...%d...", N)
12092 was used to print both 32- and 64-bit integers N, which relied on
12093 undefined behavior.
61bdb816 12094 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
12095 * lisp.h (error, verror): Mark as printf-like functions.
12096 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
12097 Report overflow in size calculations when allocating printf buffer.
12098 Do not truncate output string at its first null byte.
12099 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
12100 Truncate the output at a character boundary, since vsnprintf does not
12101 do that.
12102 * charset.c (check_iso_charset_parameter): Convert internal
12103 character to string before calling 'error', since %c now has the
12104 printf meaning.
12105 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
12106 overflow when computing char to be passed to 'error'. Do not
12107 pass Lisp_Object to 'error'; pass the integer instead.
12108 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
12109 formatted with plain %d.
12110
b189fa66
PE
12111 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
12112
bff87ef0
PE
12113 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
12114
7e2cac20
PE
12115 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
12116
ce4d90b5
PE
12117 * xterm.c (x_catch_errors): Remove duplicate declaration.
12118
266c9547
PE
12119 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
12120
79c49ad2
PE
12121 * xdisp.c, lisp.h (message_nolog): Remove; unused.
12122
368f4090
JM
121232011-04-10 Jim Meyering <meyering@redhat.com>
12124
12125 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
12126 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
12127 return ssize_t not "int", and use size_t as the buffer length.
12128 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
12129 * gnutls.h: Update declarations.
12130 * process.c (read_process_output): Use ssize_t, to match.
12131 (send_process): Likewise.
12132
a32d4040
CY
121332011-04-09 Chong Yidong <cyd@stupidchicken.com>
12134
12135 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
12136
8546720e 121372011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 12138
04f2d78b
CB
12139 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
12140 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 12141
8546720e
GM
12142 * xterm.c (handle_one_xevent):
12143 * xmenu.c (create_and_show_popup_menu):
12144 * xselect.c (x_decline_selection_request)
12145 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 12146
0a2f5c1a 121472011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
12148
12149 Fix some uses of `int' instead of EMACS_INT.
12150 * search.c (string_match_1, fast_string_match)
12151 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
12152 (scan_buffer, find_next_newline_no_quit)
12153 (find_before_next_newline, search_command, Freplace_match)
12154 (Fmatch_data): Make some `int' variables be EMACS_INT.
12155
12156 * xdisp.c (display_count_lines): 3rd argument and return value now
12157 EMACS_INT. All callers changed.
12158 (pint2hrstr): Last argument is now EMACS_INT.
12159
12160 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
12161 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
12162 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
12163 (decode_coding_utf_16, decode_coding_emacs_mule)
12164 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
12165 (decode_coding_ccl, decode_coding_charset)
12166 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
12167 (decode_coding_iso_2022, decode_coding_emacs_mule)
12168 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
12169 <char_offset, last_offset>: Declare EMACS_INT.
12170 (encode_coding_utf_8, encode_coding_utf_16)
12171 (encode_coding_emacs_mule, encode_invocation_designation)
12172 (encode_designation_at_bol, encode_coding_iso_2022)
12173 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
12174 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
12175 Declare EMACS_INT.
12176 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
12177 (encode_invocation_designation): Last argument P_NCHARS is now
12178 EMACS_INT.
12179 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
12180 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
12181
12182 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
12183 All users changed.
12184
12185 * ccl.c (Fccl_execute_on_string): Declare some variables
12186 EMACS_INT.
12187
8546720e 121882011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
12189
12190 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
12191
4e19a977
CS
121922011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
12193
12194 * process.c (Fformat_network_address): Doc fix.
12195
87302331
R
121962011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
12197
ee7683eb 12198 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 12199
cbb59342
CY
122002011-04-08 Chong Yidong <cyd@stupidchicken.com>
12201
12202 * keyboard.c (read_char): Call Lisp function help-form-show,
12203 instead of using internal_with_output_to_temp_buffer.
12204 (Qhelp_form_show): New var.
e0d38eeb 12205 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
12206
12207 * print.c (internal_with_output_to_temp_buffer): Function deleted.
12208
12209 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
12210
e67a13ab
CY
122112011-04-06 Chong Yidong <cyd@stupidchicken.com>
12212
04f2d78b
CB
12213 * process.c (Flist_processes): Remove to Lisp.
12214 (list_processes_1): Delete.
e67a13ab 12215
973f782d
EZ
122162011-04-06 Eli Zaretskii <eliz@gnu.org>
12217
7c106b1e
EZ
12218 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
12219
973f782d
EZ
12220 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
12221
41cf7d1a 122222011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 12223
ca23cc88
PE
12224 Fix more problems found by GCC 4.6.0's static checks.
12225
f390e2d5
PE
12226 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
12227
42eea0d0
PE
12228 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
12229
b69769da 12230 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 12231
f9541e84
PE
12232 * xdisp.c (vmessage): Mark as a printf-like function.
12233
13841b55
PE
12234 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
12235
c136c10f
PE
12236 * sound.c (sound_warning): Don't crash if arg contains a printf format.
12237
5e2d4a30
PE
12238 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
12239 printf-like functions.
12240 (tiff_load): Add casts to remove these marks before passing them
12241 to system-supplied API.
12242
583f48b9
PE
12243 * eval.c (Fsignal): Remove excess argument to 'fatal'.
12244
b25d760e
PE
12245 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
12246 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
12247 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
12248 directly, rather than having caller test rule sign. This avoids
12249 some unnecessary tests.
12250 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
12251 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
12252 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 12253
bc7b6697 12254 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 12255 (xfont_open): Avoid unnecessary tests.
bc7b6697 12256
27ccc379
PE
12257 * composite.c (composition_gstring_put_cache): Use unsigned integer.
12258
dcd5c89a
PE
12259 * composite.h, composite.c (composition_gstring_put_cache):
12260 Use EMACS_INT, not int, for length.
12261
b13a45c6
PE
12262 * composite.h (COMPOSITION_DECODE_REFS): New macro,
12263 breaking out part of COMPOSITION_DECODE_RULE.
12264 (COMPOSITION_DECODE_RULE): Use it.
12265 * composite.c (get_composition_id): Remove unused local vars,
12266 by using the new macro.
12267
1e792e4d
PE
12268 * textprop.c (set_text_properties_1): Change while to do-while,
12269 since the condition is always true at first.
12270
dc6c6455 12271 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
12272 (interval_deletion_adjustment): Return unsigned value.
12273 All uses changed.
dc6c6455 12274
aba7731a
PE
12275 * process.c (list_processes_1, create_pty, read_process_output):
12276 (exec_sentinel): Remove vars that were set but not used.
afd4052b 12277 (create_pty): Remove unnecessary "volatile"s.
bc57d757 12278 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 12279 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 12280 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 12281
fdfc4bf3
PE
12282 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
12283
fca8fe46 12284 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 12285 (update_syntax_table): Use unsigned instead of int.
fca8fe46 12286
06a0259a 12287 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 12288 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 12289 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 12290
e7b9e80f
PE
12291 * print.c (print_error_message): Avoid int overflow.
12292
56201685
PE
12293 * font.c (font_list_entities): Redo for clarity,
12294 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
12295
78834453 12296 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 12297 (font_score): Avoid potential overflow in diff calculation.
78834453 12298
0bc0b309 12299 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 12300 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 12301
e610eaca
PE
12302 * eval.c (funcall_lambda): Rename local to avoid shadowing.
12303
b895abce
PE
12304 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
12305 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
12306 can always succeed if overflow has undefined behavior.
12307
1f1d9321 12308 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 12309 (wordify): Omit three unnecessary tests.
1f1d9321 12310
c59478bc
PE
12311 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
12312 All callers changed. This avoids the need for an unused var.
12313
79b73827
PE
12314 * casefiddle.c (casify_region): Remove var that is set but not used.
12315
a4db5dfe
PE
12316 * dired.c (file_name_completion): Remove var that is set but not used.
12317
43aae36e
PE
12318 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
12319
2a47c44d 12320 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 12321 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 12322
a37c69bf
PE
12323 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
12324 Check for integer overflow on size calculations.
12325
328ab8e7
PE
12326 * buffer.c (Fprevious_overlay_change): Remove var that is set
12327 but not used.
12328
e5a2a5cb
PE
12329 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
12330 Remove vars that are set but not used.
8d84a6eb 12331 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 12332 (timer_check_2): Mark vars as initialized.
e5a2a5cb 12333
a60e5f68
PE
12334 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
12335
f661cb61 12336 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 12337 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 12338
f0397f5a
PE
12339 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
12340 that are set but not used.
12341
8664db06 12342 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 12343 if XCreateBitmapFromData fails (Bug#8410).
8664db06 12344
6abdaa4a
PE
12345 * xselect.c (x_get_local_selection, x_handle_property_notify):
12346 Remove vars that are set but not used.
12347
0ce7538d 12348 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 12349 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 12350
9ae848fc
PE
12351 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
12352 Remove var that is set but not used.
0b918413
PE
12353 (scroll_bar_windows_size): Now size_t, not int.
12354 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
12355 Check for overflow.
9ae848fc 12356
a5a62657
PE
12357 * xfaces.c (realize_named_face): Remove vars that are set but not used.
12358 (map_tty_color) [!defined MSDOS]: Likewise.
12359
5c5cdd39
PE
12360 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
12361
66ebf983
PE
12362 * coding.c: Remove vars that are set but not used.
12363 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
12364 All callers changed.
12365 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
12366 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
12367 (decode_coding_charset): Remove vars that are set but not used.
12368
1be4d761
PE
12369 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
12370 that is set but not used.
12371
47553fa8
PE
12372 * print.c (print_object): Remove var that is set but not used.
12373
1f7196bf 12374 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
12375 The gnulib version avoids calling malloc in the usual case,
12376 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
12377 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
12378 * filelock.c (current_lock_owner): Likewise.
12379 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
12380 * sysdep.c: Include allocator.h, careadlinkat.h.
12381 (emacs_no_realloc_allocator): New static constant.
12382 (emacs_readlink): New function.
fdb61804
PE
12383 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
12384 ../lib/careadlinkat.h.
d1fdcab7 12385
f84c17c7
SM
123862011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
12387
12388 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
12389 first non-nil return value).
12390
ef3862ad
JD
123912011-04-03 Jan Djärv <jan.h.d@swipnet.se>
12392
12393 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
12394 if not defined (Bug#8403).
12395
376a7006
JB
123962011-04-02 Juanma Barranquero <lekktu@gmail.com>
12397
12398 * xdisp.c (display_count_lines): Remove parameter `start',
12399 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12400 (get_char_face_and_encoding): Remove parameter `multibyte_p',
12401 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12402 (fill_stretch_glyph_string): Remove parameters `row' and `area',
12403 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
12404 and thereabouts. All callers changed.
12405 (get_per_char_metric): Remove parameter `f', unused since
12406 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12407
6ca3801d
JM
124082011-04-02 Jim Meyering <meyering@redhat.com>
12409
12410 do not dereference NULL upon failed strdup
12411 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
12412 (ns_get_family): Likewise.
12413
d8e2b5ba
JB
124142011-04-02 Juanma Barranquero <lekktu@gmail.com>
12415
12416 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
12417
8c74fcbd
JD
124182011-04-02 Jan Djärv <jan.h.d@swipnet.se>
12419
12420 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
12421 later (Bug#8403).
12422
7200d79c
SM
124232011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
12424
03408648 12425 Add lexical binding.
7200d79c 12426
03408648
SM
12427 * window.c (Ftemp_output_buffer_show): New fun.
12428 (Fsave_window_excursion):
12429 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
12430
12431 * lread.c (lisp_file_lexically_bound_p): New function.
12432 (Fload): Bind Qlexical_binding.
12433 (readevalloop): Remove `evalfun' arg.
12434 Bind Qinternal_interpreter_environment.
12435 (Feval_buffer): Bind Qlexical_binding.
12436 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
12437 Mark as dynamic.
12438 (syms_of_lread): Declare `lexical-binding'.
12439
12440 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
12441
12442 * keyboard.c (eval_dyn): New fun.
12443 (menu_item_eval_property): Use it.
ca105506
SM
12444
12445 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 12446
03408648
SM
12447 * fns.c (concat, mapcar1): Accept byte-code-functions.
12448
12449 * eval.c (Fsetq): Handle lexical vars.
12450 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
12451 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
12452 (FletX, Flet): Obey lexical binding.
12453 (Fcommandp): Handle closures.
12454 (Feval): New `lexical' arg.
12455 (eval_sub): New function extracted from Feval. Use it almost
12456 everywhere where Feval was used. Look up vars in lexical env.
12457 Handle closures.
12458 (Ffunctionp): Move from subr.el.
12459 (Ffuncall): Handle closures.
12460 (apply_lambda): Remove `eval_flags'.
12461 (funcall_lambda): Handle closures and new byte-code-functions.
12462 (Fspecial_variable_p): New function.
12463 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
12464 but without exporting it to Lisp.
23aba0ea 12465
23aba0ea 12466 * doc.c (Fdocumentation, store_function_docstring):
03408648 12467 * data.c (Finteractive_form): Handle closures.
23aba0ea 12468
03408648
SM
12469 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
12470 interactive spec.
ba83908c 12471
04f2d78b
CB
12472 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
12473 New byte-codes.
03408648
SM
12474 (exec_byte_code): New function extracted from Fbyte_code to handle new
12475 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 12476
03408648 12477 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 12478
03408648 12479 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 12480
e2abce01
JB
124812011-03-31 Juanma Barranquero <lekktu@gmail.com>
12482
12483 * xdisp.c (redisplay_internal): Fix prototype.
12484
63696a73 124852011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 12486
63696a73 12487 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
12488 (try_scrolling): Use it when setting scroll_limit.
12489 Limit scrolling to 100 screen lines.
63696a73
EZ
12490 (redisplay_window): Even when falling back on "recentering",
12491 position point in the window according to scroll-conservatively,
12492 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
12493
12494 (try_scrolling): When point is above the window, allow searching
12495 as far as scroll_max, or one screenful, to compute vertical
12496 distance from PT to the scroll margin position. This prevents
12497 try_scrolling from unnecessarily failing when
12498 scroll-conservatively is set to a value slightly larger than the
12499 window height. Clean up the case of PT below the margin at bottom
12500 of window: scroll_max can no longer be INT_MAX. When aggressive
12501 scrolling is in use, don't let point enter the opposite scroll
12502 margin as result of the scroll.
12503 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
12504 threshold of 100 lines for never-recentering scrolling.
12505
e4cc2dfc
JB
125062011-03-31 Juanma Barranquero <lekktu@gmail.com>
12507
12508 * dispextern.h (move_it_by_lines):
12509 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
12510 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
12511 (message_log_check_duplicate): Remove parameters `prev_bol' and
12512 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12513 (redisplay_internal): Remove parameter `preserve_echo_area',
12514 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
12515
12516 * indent.c (Fvertical_motion):
12517 * window.c (window_scroll_pixel_based, Frecenter):
12518 Don't pass `need_y_p' to `move_it_by_lines'.
12519
1c470562
SM
125202011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
12521
44f230aa
SM
12522 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
12523 steal a few bits to be more compact.
12524 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
12525 Remove unneeded casts.
12526
1c470562
SM
12527 * bytecode.c (Fbyte_code): CAR and CDR can GC.
12528
888adce9
ZK
125292011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
12530
12531 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
12532 binding" message (bug#7967).
12533
f838ed7b
PE
125342011-03-30 Paul Eggert <eggert@cs.ucla.edu>
12535
77861b95
PE
12536 Fix more problems found by GCC 4.6.0's static checks.
12537
de6dbc14
PE
12538 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
12539 Remove unused local var.
12540
f838ed7b
PE
12541 * editfns.c (Fmessage_box): Remove unused local var.
12542
792c7b2b
PE
12543 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
12544 (note_mode_line_or_margin_highlight, note_mouse_highlight):
12545 Omit unused local vars.
c499e557 12546 * window.c (shrink_windows): Omit unused local var.
b01a1c29 12547 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
12548 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
12549 Omit unused local var.
12550
ba0165e1
PE
12551 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
12552 Don't assume string length fits in int.
32ad8845 12553 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 12554 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 12555
3c59b4c9
PE
12556 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
12557 instead of alloca (Bug#8344).
12558
a3eed478 12559 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 12560 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 12561
eb4d412d
PE
12562 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
12563
1658b401
PE
12564 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
12565 concerns.
12566
12567 * term.c (produce_glyphless_glyph): Remove unnecessary test.
12568
12569 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 12570
9a2c6e05
PE
12571 * keyboard.c (syms_of_keyboard): Use the same style as later
12572 in this function when indexing through an array. This also
12573 works around GCC bug 48267.
12574
03d0a109
PE
12575 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
12576
44f730c8
PE
12577 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
12578
fe75f926
PE
12579 * chartab.c (sub_char_table_ref_and_range): Redo for slight
12580 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
12581
ffa8c828
PE
12582 * keyboard.c, keyboard.h (num_input_events): Now size_t.
12583 This avoids undefined behavior on integer overflow, and is a bit
12584 more convenient anyway since it is compared to a size_t variable.
12585
c5101a77
PE
12586 Variadic C functions now count arguments with size_t, not int.
12587 This avoids an unnecessary limitation on 64-bit machines, which
12588 caused (substring ...) to crash on large vectors (Bug#8344).
12589 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
12590 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 12591 All variadic functions and their callers changed accordingly.
c5101a77
PE
12592 (struct gcpro.nvars): Now size_t, not int. All uses changed.
12593 * data.c (arith_driver, float_arith_driver): Likewise.
12594 * editfns.c (general_insert_function): Likewise.
12595 * eval.c (struct backtrace.nargs, interactive_p)
12596 (internal_condition_case_n, run_hook_with_args, apply_lambda)
12597 (funcall_lambda, mark_backtrace): Likewise.
12598 * fns.c (concat): Likewise.
12599 * frame.c (x_set_frame_parameters): Likewise.
12600 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
12601 0 if not found, not -1. All callers changed.
12602
dd3f25f7
PE
12603 * alloc.c (garbage_collect): Don't assume stack size fits in int.
12604 (stack_copy_size): Now size_t, not int.
12605 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
12606
461c2ab9
JB
126072011-03-28 Juanma Barranquero <lekktu@gmail.com>
12608
12609 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
12610 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12611 All callers changed.
12612
12613 * lisp.h (multibyte_char_to_unibyte):
12614 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
12615 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12616 * character.h (CHAR_TO_BYTE8):
12617 * cmds.c (internal_self_insert):
12618 * editfns.c (general_insert_function):
12619 * keymap.c (push_key_description):
12620 * search.c (Freplace_match):
12621 * xdisp.c (message_dolog, set_message_1): All callers changed.
12622
f6d62986
SM
126232011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
12624
12625 * keyboard.c (safe_run_hook_funcall): New function.
12626 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
12627 don't set the hook to nil, but remove the offending function instead.
12628 (Qcommand_hook_internal): Remove, unused.
12629 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
12630 Vcommand_hook_internal.
12631
12632 * eval.c (enum run_hooks_condition): Remove.
12633 (funcall_nil, funcall_not): New functions.
12634 (run_hook_with_args): Call each function through a `funcall' argument.
12635 Remove `cond' argument, now redundant.
12636 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
12637 (Frun_hook_with_args_until_failure): Adjust accordingly.
12638 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
12639
1db5b1ad
JB
126402011-03-28 Juanma Barranquero <lekktu@gmail.com>
12641
12642 * dispextern.h (string_buffer_position): Remove declaration.
12643
12644 * print.c (strout): Remove parameter `multibyte', unused since
12645 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
12646
12647 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
12648 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
12649 All callers changed.
12650
12651 * w32.c (_wsa_errlist): Use braces for struct initializers.
12652
12653 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
12654 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
12655 All callers changed.
12656 (string_buffer_position): Likewise. Also, make static (it's never
12657 used outside xdisp.c).
12658 (cursor_row_p): Remove parameter `w', unused since
12659 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
12660 (decode_mode_spec): Remove parameter `precision', introduced during
12661 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
12662 All callers changed.
12663
5ffb62aa
JD
126642011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12665
12666 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
12667
461c2ab9 126682011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
12669
12670 * nsterm.m (ns_menu_bar_is_hidden): New variable.
12671 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
12672 (ns_update_auto_hide_menu_bar): New functions.
12673 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
12674 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
12675 ns_constrain_all_frames.
12676 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
12677 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
12678
5c380ffb
JD
126792011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12680
12681 * nsmenu.m (runDialogAt): Remove argument to timer_check.
12682
9af30bdf
GM
126832011-03-27 Glenn Morris <rgm@gnu.org>
12684
12685 * syssignal.h: Replace RETSIGTYPE with void.
12686 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
12687 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
12688 Replace SIGTYPE with void everywhere.
12689 * s/usg5-4-common.h (SIGTYPE): Remove definition.
12690 * s/template.h (SIGTYPE): Remove commented out definition.
12691
e2abce01
JB
126922011-03-26 Eli Zaretskii <eliz@gnu.org>
12693
12694 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
12695 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
12696
f868cd8a
JB
126972011-03-26 Juanma Barranquero <lekktu@gmail.com>
12698
59eb0929
JB
12699 * w32.c (read_unc_volume): Use parameter `henum', instead of
12700 global variable `wget_enum_handle'.
12701
12702 * keymap.c (describe_vector): Remove parameters `indices' and
12703 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
12704 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
12705
f868cd8a
JB
12706 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
12707
12708 * keyboard.c (timer_check): Remove parameter `do_it_now',
12709 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
12710 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
12711 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
12712
12713 * keyboard.c (read_char):
12714 * w32menu.c (w32_menu_display_help):
12715 * xmenu.c (show_help_event, menu_help_callback):
12716 Adjust calls to `show_help_echo'.
12717
12718 * gtkutil.c (xg_maybe_add_timer):
12719 * keyboard.c (readable_events):
12720 * process.c (wait_reading_process_output):
12721 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
12722
12723 * insdel.c (adjust_markers_gap_motion):
12724 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
12725 (gap_left, gap_right): Don't call it.
12726
2ecf6fdb
CY
127272011-03-25 Chong Yidong <cyd@stupidchicken.com>
12728
12729 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
12730 incurred during fontification.
12731
6b1f9ba4
JB
127322011-03-25 Juanma Barranquero <lekktu@gmail.com>
12733
12734 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
12735 (DEFVAR_PER_BUFFER): Don't pass it.
12736
12737 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
12738 (scrolling_window): Don't pass it.
12739
0f4a96b5
JB
127402011-03-25 Juanma Barranquero <lekktu@gmail.com>
12741
12742 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
12743
12744 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
12745 and `suffix'.
12746 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
12747 of variables specific to SELinux and computation of `encoded_absname'.
12748
12749 * image.c (XPutPixel): Remove unused variable `height'.
12750
12751 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
12752
12753 * unexw32.c (get_section_info): Remove unused variable `section'.
12754
12755 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
12756 (system_process_attributes): Remove unused variable `sess'.
12757 (sys_read): Remove unused variable `err'.
12758
12759 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
12760 (w32_wnd_proc): Remove unused variable `isdead'.
12761 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
12762 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
12763 (x_create_tip_frame): Remove unused variable `tem'.
12764
12765 * w32inevt.c (w32_console_read_socket):
12766 Remove unused variable `no_events'.
12767
12768 * w32term.c (x_draw_composite_glyph_string_foreground):
12769 Remove unused variable `width'.
12770
1149507c
JB
127712011-03-24 Juanma Barranquero <lekktu@gmail.com>
12772
12773 * w32term.c (x_set_glyph_string_clipping):
12774 Don't pass uninitialized region to CombineRgn.
12775
9c88f339
JB
127762011-03-23 Juanma Barranquero <lekktu@gmail.com>
12777
12778 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
12779 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
12780 (Fx_close_connection): Remove unused variable `i'.
12781
12782 * w32font.c (w32font_draw): Return number of glyphs.
12783 (w32font_open_internal): Remove unused variable `i'.
12784 (w32font_driver): Add missing initializer.
12785
12786 * w32menu.c (utf8to16): Remove unused variable `utf16'.
12787 (fill_in_menu): Remove unused variable `items_added'.
12788
12789 * w32term.c (last_mouse_press_frame): Remove static global variable.
12790 (w32_clip_to_row): Remove unused variable `f'.
12791 (x_delete_terminal): Remove unused variable `i'.
12792
12793 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
12794 (NOTHING): Remove unused static global variable.
12795 (uniscribe_check_otf): Remove unused variable `table'.
12796 (uniscribe_font_driver): Add missing initializers.
12797
dee091a3
JD
127982011-03-23 Julien Danjou <julien@danjou.info>
12799
12800 * term.c (Fsuspend_tty, Fresume_tty):
12801 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
12802 * window.c (temp_output_buffer_show):
12803 * insdel.c (signal_before_change):
12804 * frame.c (Fhandle_switch_frame):
12805 * fileio.c (Fdo_auto_save):
12806 * emacs.c (Fkill_emacs):
12807 * editfns.c (save_excursion_restore):
12808 * cmds.c (internal_self_insert):
12809 * callint.c (Fcall_interactively):
12810 * buffer.c (Fkill_all_local_variables):
12811 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
12812 Use Frun_hooks.
0f4a96b5 12813 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 12814 unconditionally since it does the check itself.
dee091a3 12815
2c520ab5 128162011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 12817
c9c49752
PE
12818 Fix more problems found by GCC 4.5.2's static checks.
12819
8abc3f12
PE
12820 * coding.c (encode_coding_raw_text): Avoid unnecessary test
12821 the first time through the loop, since we know p0 < p1 then.
12822 This also avoids a gcc -Wstrict-overflow warning.
12823
a2d26660
PE
12824 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
12825 leading to a memory leak, possible in functions like
12826 load_charset_map_from_file that can allocate an unbounded number
b12ef411 12827 of objects (Bug#8318).
a2d26660 12828
916c72e9
PE
12829 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
12830 that could (at least in theory) be that large.
12831
19ab8a18
PE
12832 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
12833 This is less likely to overflow, and avoids undefined behavior if
12834 overflow does occur. All callers changed. Use strtoul to scan
12835 for the unsigned long integer.
b7cbbd6f
PE
12836 (pint2hrstr): Simplify and tune code slightly.
12837 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 12838
f0641eff
PE
12839 * scroll.c (do_scrolling): Work around GCC bug 48228.
12840 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
12841
7f650bb9
PE
12842 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
12843 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
12844 (validate_x_resource_name): Simplify count usage.
12845 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 12846
37dd57d1
PE
12847 * fileio.c (Fcopy_file): Report error if fchown or fchmod
12848 fail (Bug#8306).
81e56e61 12849
699979fc 12850 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 12851
401bf9b4
PE
12852 * process.c (Fmake_network_process): Use socklen_t, not int,
12853 where POSIX says socklen_t is required in portable programs.
12854 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 12855 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
12856 (Fmake_network_process, server_accept_connection):
12857 (wait_reading_process_output, read_process_output):
12858 Likewise.
12859
b93aacde
PE
12860 * process.c: Rename or move locals to avoid shadowing.
12861 (list_processes_1, Fmake_network_process):
12862 (read_process_output_error_handler, exec_sentinel_error_handler):
12863 Rename or move locals.
4dc343ee 12864 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 12865 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 12866 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 12867 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 12868 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 12869
af8a867c 12870 Make tparam.h and terminfo.c consistent.
44f230aa
SM
12871 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
12872 Include tparam.h instead, since it declares them.
af8a867c
PE
12873 * cm.h (PC): Remove extern decl; tparam.h now does this.
12874 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
12875 * terminfo.c: Include tparam.h, to check interfaces.
12876 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
12877 (tparam): Adjust signature to match interface in tparam.h;
12878 this removes some undefined behavior. Check that outstring and len
12879 are zero, which they always are with Emacs.
12880 * tparam.h (PC, BC, UP): New extern decls.
12881
0248044d 12882 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 12883 (xftfont_open): Rename locals to avoid shadowing.
0248044d 12884
8ff096c1 12885 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
12886 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
12887 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 12888 (ftfont_list): Remove unused local.
49eaafba
PE
12889 (get_adstyle_property, ftfont_pattern_entity):
12890 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
12891 Rename locals to avoid shadowing.
8ff096c1 12892
e2be39f6
PE
12893 * xfont.c (xfont_list_family): Mark var as initialized.
12894
c9735e30
PE
12895 * xml.c (make_dom): Now static.
12896
8f5201ae
PE
12897 * composite.c (composition_compute_stop_pos): Rename local to
12898 avoid shadowing.
b246f932
PE
12899 (composition_reseat_it): Remove unused locals.
12900 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 12901 (composition_update_it): Mark var as initialized.
11b61122
PE
12902 (find_automatic_composition): Mark vars as initialized,
12903 with a FIXME (Bug#8290).
8f5201ae 12904
760fbc2c
PE
12905 character.h: Rename locals to avoid shadowing.
12906 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
12907 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
12908 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
12909 (BUF_DEC_POS): Be more systematic about renaming local temporaries
12910 to avoid shadowing.
12911
ff08eb85
PE
12912 * textprop.c (property_change_between_p): Remove; unused.
12913
fc7bf025
PE
12914 * intervals.c (interval_start_pos): Now static.
12915
235d7abc
PE
12916 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
12917
44f230aa
SM
12918 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
12919 Rename locals to avoid shadowing.
3e7d6594 12920
50060332
PE
12921 * sound.c (wav_play, au_play, Fplay_sound_internal):
12922 Fix pointer signedness.
d01f234b 12923 (alsa_choose_format): Remove unused local var.
c83b8872
PE
12924 (wav_play): Initialize a variable to 0, to prevent undefined
12925 behavior (Bug#8278).
50060332 12926
c4fc4e30
PE
12927 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
12928
918436ed
PE
12929 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
12930
c939f91b
PE
12931 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
12932 clobbering (Bug#8298).
b9c7f648
PE
12933 * sysdep.c (sys_subshell): Likewise.
12934 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 12935
6bd8c144
PE
12936 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
12937 This should get cleaned up, so that child_setup has the
12938 same signature on all platforms.
12939
7710357c 12940 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 12941 (relocate_fd): Rename locals to avoid shadowing.
7710357c 12942
c59da222
CY
129432011-03-22 Chong Yidong <cyd@stupidchicken.com>
12944
12945 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
12946 not to be necessary, and produces flickering.
12947
66b87493
GM
129482011-03-20 Glenn Morris <rgm@gnu.org>
12949
12950 * config.in: Remove file.
12951
45b6f6d5
JB
129522011-03-20 Juanma Barranquero <lekktu@gmail.com>
12953
12954 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
12955 are now in src/globals.h.
12956 (syms_of_minibuf): Remove spurious & from previous change.
12957
cd394be1 129582011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
12959
12960 * minibuf.c (completing-read-function): New variable.
12961 (completing-read-default): Rename from completing-read.
12962 (completing-read): Call completing-read-function.
12963
b14e3e21
CY
129642011-03-19 Juanma Barranquero <lekktu@gmail.com>
12965
12966 * xfaces.c (Fx_load_color_file):
12967 Read color file from absolute filename (bug#8250).
12968
f2b726e6
JB
129692011-03-19 Juanma Barranquero <lekktu@gmail.com>
12970
12971 * makefile.w32-in: Update dependencies.
12972
09f6ff02
EZ
129732011-03-17 Eli Zaretskii <eliz@gnu.org>
12974
12975 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
12976
29a6015a
PE
129772011-03-17 Paul Eggert <eggert@cs.ucla.edu>
12978
a3a6c54e
PE
12979 Fix more problems found by GCC 4.5.2's static checks.
12980
b766f867
PE
12981 * process.c (make_serial_process_unwind, send_process_trap):
12982 (sigchld_handler): Now static.
12983
be02381c
PE
12984 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
12985 That way, the code declares only the vars that it needs.
12986 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
12987 * s/cygwin.h (PTY_ITERATION): Likewise.
12988 * s/darwin.h (PTY_ITERATION): Likewise.
12989 * s/gnu-linux.h (PTY_ITERATION): Likewise.
12990
57048744
PE
12991 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
12992 * process.c (allocate_pty): Don't declare stb unless it's needed.
12993
7914961c 12994 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
12995 (CONSTANTLIM): Remove; unused.
12996 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
12997 Define only if needed.
7914961c 12998
b3967b18
PE
12999 * unexelf.c (unexec): Name an expression,
13000 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
13001 Use a different way to cause a compilation error if anyone uses
13002 n rather than nn, a way that does not involve shadowing.
73366a00 13003 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 13004
29a6015a
PE
13005 * deps.mk (unexalpha.o): Remove; unused.
13006
43cfc33e 13007 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 13008 * unexec.h: New file.
ce701a33
PE
13009 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
13010 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
13011 Depend on unexec.h.
13012 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
13013 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
13014 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 13015 Change as necessary to match prototype in unexec.h.
ce701a33 13016
01f44d5a
PE
13017 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
13018 shadowing.
4f63c6bb 13019 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 13020
a6670b0b
PE
13021 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
13022 Rename locals to avoid shadowing.
13023
cef2010d 13024 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 13025 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 13026
d4d7173a
PE
13027 * print.c (Fredirect_debugging_output): Fix pointer signedess.
13028
f08b802a
PE
13029 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
13030 warning when compiling print.c.
13031
3ddb0639
PE
13032 * font.c (font_unparse_fcname): Abort in an "impossible" situation
13033 instead of using an uninitialized var.
5ad03b97 13034 (font_sort_entities): Mark var as initialized.
3ddb0639 13035
170a2692
PE
13036 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
13037
e663c700
PE
13038 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
13039 pointers to constants.
89bc529a 13040 (font_parse_fcname): Remove unused vars.
7b81e2d0 13041 (font_delete_unmatched): Now static.
ea838e10 13042 (font_get_spec): Remove; unused.
13a547c6
PE
13043 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
13044 (font_update_drivers, Ffont_get_glyphs, font_add_log):
13045 Rename or move locals to avoid shadowing.
e663c700 13046
2a80c887 13047 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 13048 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 13049
1384fa33 13050 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 13051 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 13052
8b2c52e9
PE
13053 * alloc.c (mark_backtrace): Move decl from here ...
13054 * lisp.h: ... to here, so that it can be checked.
13055
475545b5 13056 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 13057 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
13058 (lisp_indirect_variable): Name an expression,
13059 to avoid gcc -Wbad-function-cast warning.
1faed8ae 13060 (Fdefvar): Rename locals to avoid shadowing.
475545b5 13061
b1349114 13062 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 13063 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 13064 Use const pointer when appropriate.
b1349114 13065
a2928364
PE
13066 * lisp.h (get_system_name, get_operating_system_release):
13067 Move decls here, to check interfaces.
13068 * process.c (get_operating_system_release): Move decl to lisp.h.
13069 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
13070 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
13071 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
13072 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
13073 (Fformat_time_string, Fencode_time, Finsert_char):
13074 (Ftranslate_region_internal, Fformat):
13075 Rename or remove local vars to avoid shadowing.
9710023e 13076 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 13077
a415e694
PE
13078 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
13079 avoid shadowing.
13080
8ef4622d
PE
13081 * lisp.h (eassert): Check that the argument compiles, even if
13082 ENABLE_CHECKING is not defined.
13083
946f9a5b
PE
13084 * data.c (Findirect_variable): Name an expression, to avoid
13085 gcc -Wbad-function-cast warning.
112396d6 13086 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 13087 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
13088 (Fmake_variable_buffer_local, Fmake_local_variable):
13089 Mark variables as initialized.
52746918 13090 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 13091
e5aab7e7 13092 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
13093 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
13094 Rename locals to avoid shadowing.
dff45157
PE
13095 (mark_stack): Move local variables into the #ifdef region where
13096 they're used.
7bc26fdb
PE
13097 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
13098 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
13099 needed otherwise.
13100 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
13101 (GC_STRING_CHARS): Remove; not used.
d40d4be1 13102 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 13103
e5aab7e7
PE
13104 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
13105 avoids undefined behavior in theory.
13106
4da60324
PE
13107 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
13108
88043301
PE
13109 Use functions, not macros, for up- and down-casing (Bug#8254).
13110 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13111 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
13112 to use the following functions instead of these macros.
13113 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
13114 EMACS_INT, since callers assume the returned value fits in int.
13115 (upcase1): Likewise, for UPCASE_TABLE.
13116 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 13117 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 13118 the race-condition problem in the old DOWNCASE.
88043301 13119
19ed5445
PE
13120 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
13121 Rename locals to avoid shadowing.
13122 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
13123 (regex_compile, re_search_2, re_match_2_internal):
13124 Remove unused local vars.
952db0d7
PE
13125 (FREE_VAR): Rewrite so as not to use empty "else",
13126 which gcc can warn about.
da053e48 13127 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
13128 (RETALLOC_IF): Define only if needed.
13129 (WORDCHAR_P): Likewise. This one is never needed, but is used
13130 only in a comment talking about a compiler bug, so put inside
13131 the #if 0 of that comment.
13132 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
13133 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
13134 Remove; unused.
19ed5445 13135
1f3561e4 13136 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
13137 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
13138 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 13139
ded6f8f7
PE
13140 * search.c (simple_search): Remove unused var.
13141
dbd37a95
PE
13142 * dired.c (compile_pattern): Move decl from here ...
13143 * lisp.h: ... to here, so that it can be checked.
13144 (struct re_registers): New forward decl.
13145
7e47afad
PE
13146 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
13147
85f24f61
PE
13148 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
13149 All uses changed.
13150 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
13151 Rename locals to avoid shadowing.
5671df8f 13152 (Fvertical_motion): Mark locals as initialized.
85f24f61 13153
181aa2be 13154 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 13155 (casify_region): Mark local as initialized.
181aa2be 13156
930d429c
PE
13157 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
13158
7082eac6
PE
13159 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
13160 New macros, so that the caller can use some names other than
13161 gcpro1, gcpro2, etc.
13162 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
13163 of the new macros.
13164 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
13165 argument, for consistency with GCPRO2_VAR, etc: it is now the
13166 prefix of the variable, not the variable itself. All uses
13167 changed.
38b2c076
PE
13168 * dired.c (directory_files_internal, file_name_completion):
13169 Rename locals to avoid shadowing.
13170
15206ed9
PE
13171 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
13172 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
13173 dired.c's scmp function, had undefined behavior.
13174 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13175 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
13176 * buffer.h: ... to here, because these macros use current_buffer,
13177 and the new implementation with inline functions needs to have
13178 current_buffer in scope now, rather than later when the macros
13179 are used.
13180 (downcase, upcase1): New static inline functions.
13181 (DOWNCASE, UPCASE1): Reimplement using these functions.
13182 This avoids undefined behavior in expressions like
13183 DOWNCASE (x) == DOWNCASE (y), which previously suffered
13184 from race conditions in accessing the global variables
13185 case_temp1 and case_temp2.
13186 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
13187 * lisp.h (case_temp1, case_temp2): Remove their decls.
13188 * character.h (ASCII_CHAR_P): Move from here ...
13189 * lisp.h: ... to here, so that the inline functions mentioned
13190 above can use them.
13191
4a6bea26
PE
13192 * dired.c (directory_files_internal_unwind): Now static.
13193
f14b7e14
PE
13194 * fileio.c (file_name_as_directory, directory_file_name):
13195 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
13196 Now static.
2893f146
PE
13197 (file_name_as_directory): Use const pointers when appropriate.
13198 (Fexpand_file_name): Likewise. In particular, newdir might
13199 point at constant storage, so make it a const pointer.
fd4ead52 13200 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
13201 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
13202 signedness issues.
f839df0c
PE
13203 (Fset_file_times, Finsert_file_contents, auto_save_error):
13204 Rename locals to avoid shadowing.
f14b7e14 13205
5716756e 13206 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
13207 (Ftry_completion, Fall_completions): Rename or remove locals
13208 to avoid shadowing.
5716756e 13209
b4c3046a
PE
13210 * marker.c (bytepos_to_charpos): Remove; unused.
13211
b45db522
PE
13212 * lisp.h (verify_bytepos, count_markers): New decls,
13213 so that gcc does not warn that these functions aren't declared.
13214
85876d07
PE
13215 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
13216 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 13217 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 13218 (copy_text): Remove unused local var.
85876d07 13219
03d78a21 13220 * filelock.c (within_one_second): Now static.
b3dd38ab 13221 (lock_file_1): Rename local to avoid shadowing.
03d78a21 13222
5df8f01b
PE
13223 * buffer.c (fix_overlays_before): Mark locals as initialized.
13224 (fix_start_end_in_overlays): Likewise. This function should be
13225 simplified by using pointers-to-pointers, but that's a different
13226 matter.
b1d876f1 13227 (switch_to_buffer_1): Now static.
8f54f30a
PE
13228 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
13229 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 13230
a70072c9 13231 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 13232 Fix pointer signedness issue.
edced198
PE
13233 (sys_subshell): Mark local as volatile if checking for lint,
13234 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 13235 (MAXPATHLEN): Define only if needed.
a70072c9 13236
a0977c44
PE
13237 * process.c (serial_open, serial_configure): Move decls from here ...
13238 * systty.h: ... to here, so that they can be checked.
13239
a884fdcc
PE
13240 * fns.c (get_random, seed_random): Move extern decls from here ...
13241 * lisp.h: ... to here, so that they can be checked.
13242
604efe86 13243 * sysdep.c (reset_io): Now static.
b8950c94 13244 (wait_for_termination_signal): Remove; unused.
604efe86 13245
38fc62d9
PE
13246 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
13247 (copy_keymap_item, append_key, push_text_char_description):
13248 Now static.
1004a21a 13249 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 13250 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
13251 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
13252 (describe_map_tree):
13253 Rename locals to avoid shadowing.
38fc62d9 13254
2f2650da
PE
13255 * keyboard.c: Declare functions static if they are not used elsewhere.
13256 (echo_char, echo_dash, cmd_error, top_level_2):
13257 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
13258 (read_char, kbd_buffer_get_event, make_lispy_position):
13259 (make_lispy_event, make_lispy_movement, apply_modifiers):
13260 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
13261 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
13262 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 13263 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 13264 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 13265
a053e86c 13266 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
13267 (mark_kboards): Move decl here ...
13268 * alloc.c (mark_kboards): ... from here.
a053e86c 13269
4752793e
PE
13270 * lisp.h (force_auto_save_soon): New decl.
13271
74f10ca7 13272 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
13273 (DEFINE_DUMMY_FUNCTION): New macro.
13274 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
13275 Use it.
c03cd23f
PE
13276 (main): Add casts to avoid warnings
13277 if GCC considers string literals to be constants.
74f10ca7 13278
022e70d4
PE
13279 * lisp.h (fatal_error_signal): Add decl, since it's exported.
13280
59d6fe83
PE
13281 * dbusbind.c: Pointer signedness fixes.
13282 (xd_signature, xd_append_arg, xd_initialize):
13283 (Fdbus_call_method, Fdbus_call_method_asynchronously):
13284 (Fdbus_method_return_internal, Fdbus_method_error_internal):
13285 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
13286 (Fdbus_register_signal): Use SSDATA when the context wants char *.
13287
78320123
PE
13288 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
13289 if GCC considers string literals to be constants.
49cebcca 13290 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 13291
35ac2a97
SM
132922011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
13293
fb103ca9
SM
13294 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
13295 (print_preprocess, print_object): New macro to fix last change.
13296
35ac2a97
SM
13297 * print.c (print_preprocess): Don't forget font objects.
13298
62973b41
JB
132992011-03-16 Juanma Barranquero <lekktu@gmail.com>
13300
13301 * emacs.c (USAGE3): Doc fixes.
13302
0e48bb22
AS
133032011-03-15 Andreas Schwab <schwab@linux-m68k.org>
13304
13305 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
13306 structure.
13307
7684e57b
JB
133082011-03-14 Juanma Barranquero <lekktu@gmail.com>
13309
13310 * lisp.h (VWindow_system, Qfile_name_history):
13311 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
13312 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
13313 (w32_system_caret_x, w32_system_caret_y): Declare extern.
13314
13315 * w32select.c: Don't #include "keyboard.h".
c96bbc66 13316 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
13317
13318 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
13319 * w32console.c (detect_input_pending, read_input_pending)
13320 (encode_terminal_code):
13321 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
13322 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
13323 (w32_system_caret_y, Qfile_name_history):
13324 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
13325 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
13326 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
13327 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
13328 * w32proc.c (Qlocal, report_file_error):
13329 * w32term.c (Vwindow_system, updating_frame):
13330 * w32uniscribe.c (initialized, uniscribe_font_driver):
13331 Remove unneeded extern declarations.
13332
2aa46d6c
CY
133332011-03-14 Chong Yidong <cyd@stupidchicken.com>
13334
c96bbc66 13335 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 13336
cffc6f3b
CY
133372011-03-13 Chong Yidong <cyd@stupidchicken.com>
13338
13339 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
13340 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
13341 These macros can no longer be used for assignment.
13342
44f230aa
SM
13343 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
13344 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
13345 (record_buffer_markers, fetch_buffer_markers): New functions for
13346 recording and fetching special buffer markers.
13347 (set_buffer_internal_1, set_buffer_temp): Use them.
13348
13349 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
13350
13351 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
13352
13353 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
13354 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
13355
13356 * xdisp.c (hscroll_window_tree):
13357 (reconsider_clip_changes): Use PT instead of BUF_PT.
13358
d251f04b
EZ
133592011-03-13 Eli Zaretskii <eliz@gnu.org>
13360
13361 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
13362 $(EMACS_ROOT)/lib/intprops.h.
13363
f0c77cd1
PE
133642011-03-13 Paul Eggert <eggert@cs.ucla.edu>
13365
3eca4629
PE
13366 Fix more problems found by GCC 4.5.2's static checks.
13367
7c86ee98
PE
13368 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
13369 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
13370 (xg_free_frame_widgets): Make it clear that a local variable is
13371 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
13372 (gdk_window_get_screen): Make it clear that this macro is needed
13373 only if USE_GTK_TOOLTIP.
1e5524e7
PE
13374 (int_gtk_range_get_value): New function, which avoids a diagnostic
13375 from gcc -Wbad-function-cast.
13376 (xg_set_toolkit_scroll_bar_thumb): Use it.
13377 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
13378 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
13379 (get_utf8_string, xg_get_file_with_chooser):
13380 Rename locals to avoid shadowing.
13381 (create_dialog): Move locals to avoid shadowing.
7c86ee98 13382
41729b81
PE
13383 * xgselect.c (xg_select): Remove unused var.
13384
f0c77cd1
PE
13385 * image.c (four_corners_best): Mark locals as initialized.
13386 (gif_load): Initialize transparent_p to zero (Bug#8238).
13387 Mark another local as initialized.
ec6cf4c6 13388 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 13389
ce0ad53d 13390 * image.c (clear_image_cache): Now static.
d5d5a617 13391 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 13392 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
13393 (x_edge_detection): Remove unnecessary cast that
13394 gcc -Wbad-function-cast diagnoses.
2037898d 13395 (gif_load): Fix pointer signedness.
6ae141d6
PE
13396 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
13397 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 13398
33383987 133992011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 13400
d32df629
PE
13401 Improve quality of tests for time stamp overflow.
13402 For example, without this patch (encode-time 0 0 0 1 1
13403 1152921504606846976) returns the obviously-bogus value (-948597
13404 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
13405 reports time overflow. See
13406 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
13407 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
13408 * editfns.c: Include limits.h and intprops.h.
13409 (TIME_T_MIN, TIME_T_MAX): New macros.
13410 (time_overflow): Move earlier, to before first use.
13411 (hi_time, lo_time): New functions, for an accurate test for
13412 out-of-range times.
13413 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
13414 (Fget_internal_run_time): Don't assume time_t fits in int.
13415 (make_time): Use list2 instead of Fcons twice.
13416 (Fdecode_time): More accurate test for out-of-range times.
13417 (check_tm_member): New function.
13418 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
13419 (lisp_time_argument): Don't rely on undefined left-shift and
13420 right-shift behavior when checking for time stamp overflow.
8be6f318 13421
fe31d94c
PE
13422 * editfns.c (time_overflow): New function, refactoring common code.
13423 (Fformat_time_string, Fdecode_time, Fencode_time):
13424 (Fcurrent_time_string): Use it.
13425
8be6f318
PE
13426 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
13427 * dired.c (make_time): Move to ...
13428 * editfns.c (make_time): ... here.
13429 * systime.h: Note the move.
13430
09d9db2c 134312011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 13432
126bc0dc
YM
13433 * fringe.c (update_window_fringes): Remove unused variables.
13434
c47cbdfd
YM
13435 * unexmacosx.c (copy_data_segment): Also copy __got section.
13436 (Bug#8223)
13437
7ac80be9
EZ
134382011-03-12 Eli Zaretskii <eliz@gnu.org>
13439
c96bbc66 13440 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
13441 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
13442 Constify `char *' arguments and their references according to
13443 prototypes in tparam.h.
13444
ecb0f94d 13445 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 13446
7ac80be9
EZ
13447 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
13448 Adapt all references accordingly.
13449
13450 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
13451
ef1fd07e
TT
134522011-03-11 Tom Tromey <tromey@redhat.com>
13453
13454 * buffer.c (syms_of_buffer): Remove obsolete comment.
13455
7ef4b50c
EZ
134562011-03-11 Eli Zaretskii <eliz@gnu.org>
13457
13458 * termhooks.h (encode_terminal_code): Declare prototype.
13459
13460 * msdos.c (encode_terminal_code): Don't declare prototype.
13461
13462 * term.c (encode_terminal_code): Now external again, used by
13463 w32console.c and msdos.c.
13464
44f230aa
SM
13465 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
13466 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 13467
4b1ec863 134682011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 13469
1714f52b 13470 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 13471
4b1ec863
PE
13472 * fringe.c (update_window_fringes): Mark locals as initialized
13473 (Bug#8227).
13474 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 13475
524c7aa6
PE
13476 * alloc.c (mark_fringe_data): Move decl from here ...
13477 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
13478 to check its interface.
13479 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
13480
a5c0af81 13481 * fontset.c (free_realized_fontset): Now static.
7519b8cd 13482 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 13483 (fontset_font): Mark local as initialized.
a9a06e0b 13484 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 13485
b4716021
PE
13486 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
13487
811e9bac 13488 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 13489 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
13490 (x_own_selection, Fx_disown_selection_internal): Rename locals
13491 to avoid shadowing.
13492 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 13493
7e3ab302
PE
13494 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
13495 so that the caller can use some name other than gcpro1.
13496 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
13497 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13498 (Fx_backspace_delete_keys_p):
13499 Use them to avoid shadowing, and rename vars to avoid shadowing.
13500 (x_decode_color, x_set_name, x_window): Now static.
6b437900 13501 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 13502 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
13503 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
13504 Remove unused locals.
7e3ab302
PE
13505 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13506 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
13507 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
13508 macros.
f78faa98 13509
e2b13473
PE
13510 * xterm.h (x_mouse_leave): New decl.
13511
77f23912
PE
13512 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
13513 Remove unused functions.
cdf4ba58
PE
13514 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
13515 (x_calc_absolute_position): Now static.
7411c686 13516 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 13517 Don't declare local "event" unless it's used.
ed7bf3a5
PE
13518 (x_iconify_frame, x_free_frame_resources): Don't declare locals
13519 unless they are used.
38d0b34a
PE
13520 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
13521 (x_fatal_error_signal): Remove; not used.
a6067996
PE
13522 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
13523 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
13524 (x_error_catcher, x_connection_closed, x_error_handler):
13525 (x_error_quitter, xembed_send_message, x_iconify_frame):
13526 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 13527 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 13528 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 13529
44f230aa
SM
13530 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
13531 Rename or move locals to avoid shadowing.
6b463e58 13532 (tty_defined_color, merge_face_heights): Now static.
5967d051 13533 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
13534 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
13535 does not deduce is never used uninitialized.
73719eba
PE
13536 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
13537 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 13538
426994c3 13539 * terminal.c (store_terminal_param): Now static.
5489860b 13540
032f1620 13541 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 13542 (set_frame_menubar): Remove unused local.
d4323972 13543 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
13544 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
13545 since they might point to immutable storage.
281585b0
PE
13546 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
13547 since it's unused otherwise.
032f1620 13548
367c19e5 13549 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 13550 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
13551 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
13552 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 13553 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
13554 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
13555 does not deduce are never used uninitialized.
70739cbe 13556
07b48fa9
PE
13557 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
13558
8868a238 13559 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
13560 * window.c (window_loop, size_window):
13561 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 13562
7e5cf297 13563 * window.c (display_buffer): Now static.
d6550a9f
PE
13564 (size_window): Mark variables that gcc -Wuninitialized
13565 does not deduce are never used uninitialized.
a586633d
PE
13566 * window.h (check_all_windows): New decl, to forestall
13567 gcc -Wmissing-prototypes diagnostic.
5b555da1 13568 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 13569
f6095868
PE
13570 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
13571 shadowing.
13572 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
13573 Include <limits.h>.
13574 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
13575 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
13576 (load_charset_map): Mark variables that gcc -Wuninitialized
13577 does not deduce are never used uninitialized.
53df7c11 13578 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 13579
f38b440c
PE
13580 * coding.c (coding_set_source, coding_set_destination):
13581 Use "else { /* comment */ }" rather than "else /* comment */;"
13582 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
13583 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
13584 a block, when the outer 'i' will do.
13585 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
13586 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
13587 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
13588 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
13589 (Fdecode_sjis_char, Fdefine_coding_system_internal):
13590 Rename locals to avoid shadowing.
13591 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
13592 * coding.c (emacs_mule_char, encode_invocation_designation):
13593 Now static, since they're not used elsewhere.
413bb2db 13594 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 13595 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
13596 (decode_coding_emacs_mule): Mark variables that gcc
13597 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
13598 (detect_coding_iso_2022): Initialize a local variable that might
13599 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 13600 this initialization is needed. (Bug#8211)
5f58e762
PE
13601 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
13602 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
13603 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
13604 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
13605 Remove unused macros.
f38b440c 13606
232b38b9 13607 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 13608 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 13609 * character.c (string_count_byte8): Likewise.
232b38b9 13610
fb90da1b
PE
13611 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
13612 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
13613
fb93dbc2
PE
13614 * chartab.c (copy_sub_char_table): Now static, since it's not used
13615 elsewhere.
5c156ace
PE
13616 (sub_char_table_ref_and_range, char_table_ref_and_range):
13617 Rename locals to avoid shadowing.
bbcd0949 13618 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 13619
7d3b3862 13620 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 13621 (BIDI_BOB): Remove unused macro.
7d3b3862 13622
6be7d3da
PE
13623 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
13624 deduce are never used uninitialized.
c2ed9c8b 13625 * term.c (encode_terminal_code): Likewise.
6be7d3da 13626
75f8807f 13627 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 13628
50938595
PE
13629 * tparam.h: New file.
13630 * term.c, tparam.h: Include it.
13631 * deps.mk (term.o, tparam.o): Depend on tparam.h.
13632 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
13633 Move these decls to tparam.h, and make them agree with what
13634 is actually in tparam.c. The previous trick of using incompatible
13635 decls in different modules does not conform to the C standard.
13636 All callers of tparam changed to use tparam's actual API.
13637 * tparam.c (tparam1, tparam, tgoto):
13638 Use const pointers where appropriate.
13639
fbceeba2
PE
13640 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
13641 * cm.h (struct cm): Likewise.
13642 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
13643 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
13644 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
13645 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
13646 (turn_on_face, init_tty): Likewise.
13647 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 13648
7f3f1250
PE
13649 * term.c (term_mouse_position): Rename local to avoid shadowing.
13650
e6ca6543
PE
13651 * alloc.c (mark_ttys): Move decl from here ...
13652 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
13653
c40f8d15
AS
136542011-03-11 Andreas Schwab <schwab@linux-m68k.org>
13655
13656 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
13657
cfe0661d
JB
136582011-03-09 Juanma Barranquero <lekktu@gmail.com>
13659
13660 * search.c (compile_pattern_1): Remove argument regp, unused since
13661 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
13662 (compile_pattern): Don't pass it.
13663
0afb4571
J
136642011-03-08 Jan Djärv <jan.h.d@swipnet.se>
13665
13666 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
13667 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
13668 for ! HAVE_GTK3.
13669 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
13670
13671 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
13672
13673 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
13674 gdk_window_get_screen, gdk_window_get_geometry,
13675 gdk_x11_window_lookup_for_display and GDK_KEY_g.
13676 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
13677 (xg_get_pixbuf_from_pixmap): New function.
13678 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
13679 to Pixmap, take frame as parameter, remove GdkColormap parameter.
13680 Call xg_get_pixbuf_from_pixmap instead of
13681 gdk_pixbuf_get_from_drawable.
13682 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
13683 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
13684 (xg_check_special_colors): Use GtkStyleContext and its functions
13685 for HAVE_GTK3.
13686 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
13687 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
13688 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
13689 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
13690 Call gtk_widget_get_preferred_size.
0afb4571
J
13691 (xg_frame_resized): gdk_window_get_geometry only takes 5
13692 parameters.
44f230aa
SM
13693 (xg_win_to_widget, xg_event_is_for_menubar):
13694 Call gdk_x11_window_lookup_for_display.
0afb4571
J
13695 (xg_set_widget_bg): New function.
13696 (delete_cb): New function.
895009e1 13697 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 13698 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
13699 (xg_set_background_color): Call xg_set_widget_bg.
13700 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
13701 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
13702 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
13703 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
13704 if ! HAVE_GTK3.
13705 (update_frame_tool_bar): Call gtk_widget_hide.
13706 (xg_initialize): Use GDK_KEY_g.
13707
13708 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
13709 if ! HAVE_GTK3
13710 (x_session_initialize): Call gdk_x11_set_sm_client_id.
13711
13712 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
13713 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
13714 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
13715
1c2cc4ef
JB
137162011-03-08 Juanma Barranquero <lekktu@gmail.com>
13717
13718 * w32xfns.c (select_palette): Check success of RealizePalette against
13719 GDI_ERROR, not zero.
13720
33383987 13721See ChangeLog.11 for earlier changes.
aac0c6e3
MR
13722
13723;; Local Variables:
13724;; coding: utf-8
aac0c6e3
MR
13725;; End:
13726
2f097256 13727 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
13728
13729 This file is part of GNU Emacs.
13730
13731 GNU Emacs is free software: you can redistribute it and/or modify
13732 it under the terms of the GNU General Public License as published by
13733 the Free Software Foundation, either version 3 of the License, or
13734 (at your option) any later version.
13735
13736 GNU Emacs is distributed in the hope that it will be useful,
13737 but WITHOUT ANY WARRANTY; without even the implied warranty of
13738 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13739 GNU General Public License for more details.
13740
13741 You should have received a copy of the GNU General Public License
13742 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.