* configure.ac (opsysfile): Use AH_TEMPLATE. Doc fix.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
8d8e2dfe
GM
12012-07-31 Glenn Morris <rgm@gnu.org>
2
476b1b2d
GM
3 * conf_post.h (config_opsysfile): Move earlier, so that WINDOWSNT
4 is available.
5 (alloca.h) [WINDOWSNT]: Don't include it on MS Windows.
6
b2c7a106
GM
7 * process.h (NULL_DEVICE):
8 * emacs.c (SEPCHAR):
9 * editfns.c (USER_FULL_NAME): Let configure set them.
10
d53d062a
GM
11 * s/README, s/template.h: Remove files.
12
4515017f
GM
13 * conf_post.h [HPUX]: Undefine HAVE_RANDOM and HAVE_RINT.
14
8d8e2dfe
GM
15 * conf_post.h (AMPERSAND_FULL_NAME, subprocesses):
16 Move to configure.ac.
17
5b20b3cc
EZ
182012-07-31 Eli Zaretskii <eliz@gnu.org>
19
1e0afd9a
EZ
20 * .gdbinit (xframe): Adapt to introduction of FVAR and the
21 resulting renaming of 'struct frame' members.
22
5b20b3cc
EZ
23 * w32menu.c (w32_menu_show): Revert bogus introduction of FVAR.
24
25 * fontset.c (dump_fontset): Fix compilation with ENABLE_CHECKING
26 after introduction of FVAR.
27
f1310128
JD
282012-07-31 Jan Djärv <jan.h.d@swipnet.se>
29
79e721e0
JD
30 * nsmenu.m (update_frame_tool_bar): Change key from NSObject* to id.
31
32 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Use drawInRect
33 instead of compositeToPoint.
34 (applicationShouldTerminate): Pass NS String literal to NSRunAlertPanel.
35
f1310128
JD
36 * nsfns.m, nsmenu.m, msterm.m: Adopt to struct frame/FVAR changes.
37
e34f7f79
DA
382012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
39
40 Generalize INTERNAL_FIELD between buffers, keyboards and frames.
41 * lisp.h (INTERNAL_FIELD): New macro.
42 * buffer.h (BUFFER_INTERNAL_FIELD): Removed.
43 (BVAR): Change to use INTERNAL_FIELD.
44 * keyboard.h (KBOARD_INTERNAL_FIELD): Likewise.
45 (KVAR): Change to use INTERNAL_FIELD.
46 * frame.h (FVAR): New macro.
47 (struct frame): Use INTERNAL_FIELD for all Lisp_Object fields.
48 * alloc.c, buffer.c, data.c, dispnew.c, dosfns.c, eval.c, frame.c
49 * fringe.c, gtkutil.c, minibuf.c, nsfns.m, nsterm.m, print.c
50 * term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h,
51 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
52
c09bfb2f
DA
532012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
54
55 Miscellaneous fixes for non-default X toolkits.
56 * xfns.c (Fx_file_dialog): Change to SSDATA to avoid warnings.
57 * xterm.c (x_frame_of_widget): Remove redundant prototype.
58 Move under #ifdef USE_LUCID.
59 (x_create_toolkit_scroll_bar): Adjust scroll_bar_name
60 definition and usage to avoid warnings.
61
14c114ae
JD
622012-07-31 Jan Djärv <jan.h.d@swipnet.se>
63
64 * nsterm.m (openFiles): Fix previous checkin.
65
3bd21e82
PE
662012-07-31 Paul Eggert <eggert@cs.ucla.edu>
67
68 * indent.c (compute_motion): Remove unused local.
69
c1529ded
GM
702012-07-31 Glenn Morris <rgm@gnu.org>
71
400d5621
GM
72 * s/usg5-4-common.h (wait3, WRETCODE): Let configure set them.
73
268e2432
GM
74 * conf_post.h [USG5_4]:
75 Move remaining contents of s/usg5-4-common.h here.
76 * s/usg5-4-common.h: Remove file.
77
7552f3ee
GM
78 * conf_post.h [IRIX6_5]: Move remaining contents of s/irix6-5.h here.
79 * s/irix6-5.h: Remove file.
80
6a381852
GM
81 * conf_post.h [DARWIN_OS]: Move remaining contents of s/darwin.h here.
82 * s/darwin.h: Remove file.
83
c1529ded
GM
84 * conf_post.h [HPUX]: Move random, srandom here from s/hpux10-20.h.
85 * s/hpux10-20.h: Remove file, which is now empty.
86
b429a4ee
GM
872012-07-30 Glenn Morris <rgm@gnu.org>
88
89 * conf_post.h: New, split from configure.ac's AH_BOTTOM.
90 * Makefile.in (config_h): Add conf_post.h.
91 * makefile.w32-in (CONFIG_H): Add conf_post.h.
92
adff3182
JD
932012-07-30 Jan Djärv <jan.h.d@swipnet.se>
94
95 * nsterm.m (ns_do_open_file): New variable.
b9031d69 96 (ns_term_init): Set ns_do_open_file to YES after run returns.
adff3182
JD
97 (openFile, openTempFile, openFileWithoutUI, openFiles): Open
98 files only if ns_do_open_file.
99
c32af1e4
PE
1002012-07-30 Paul Eggert <eggert@cs.ucla.edu>
101
7393bcbb
PE
102 * lisp.h (SWITCH_ENUM_CAST): Remove. All uses removed.
103 This no-op macro hasn't been needed for many years.
104 * src/regex.c (SWITCH_ENUM_CAST) [!emacs]: Likewise.
105
c32af1e4
PE
106 Export DIRECTORY_SEP, TYPEMASK, VALMASK to GDB.
107 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]: Add lsb_bits.
108 * lisp.h (enum lsb_bits) [USE_LSB_TAG]: New enum, for
109 gdb_make_enums_visible.
110 (TYPEMASK, VALMASK) [USE_LSB_TAGS]: Now enum constants, not macros.
111 (DIRECTORY_SEP): Now a constant, not a macro.
112
302fc036
EZ
1132012-07-30 Eli Zaretskii <eliz@gnu.org>
114
115 * w32fns.c (w32_wnd_proc): Pass w32_keyboard_codepage to
116 w32_kbd_patch_key as the 2nd arg. (Bug#12082)
117
118 * w32term.c <w32_keyboard_codepage>: Renamed from
119 keyboard_codepage and now external. All users changed.
120
121 * w32term.h: Add declaration of w32_keyboard_codepage.
122
123 * w32inevt.c (w32_kbd_patch_key): Accept an additional argument --
124 the codepage to translate keys to Unicode. If this argument is
125 -1, use the value returned by GetConsoleCP. All callers changed.
126
88fb40b4
PE
1272012-07-30 Paul Eggert <eggert@cs.ucla.edu>
128
0aee6912
PE
129 Update .PHONY listings in makefiles.
130 * Makefile.in (.PHONY): Add all, mostlyclean, clean,
131 bootstrap-clean, distclean, maintainer-clean, versioclean,
132 extraclean, frc.
133
88fb40b4
PE
134 * lisp.h (STRING_BYTES_BOUND): Cast entire result to ptrdiff_t.
135 This is a bit clearer. Fix some commentary typos.
136
0a763bd1
GM
1372012-07-30 Glenn Morris <rgm@gnu.org>
138
32bac6d6
GM
139 * s/netbsd.h: Let configure include signal.h if needed.
140 Remove file, which is now empty.
141
b65e7c46
GM
142 * s/usg5-4-common.h (_longjmp, _setjmp, TIOCSIGSEND):
143 Let configure set them.
144 * s/irix6-5.h (_longjmp, _setjmp, TIOCSIGSEND):
145 No more need to undefine.
0a763bd1 146
169304bd
AS
1472012-07-30 Andreas Schwab <schwab@linux-m68k.org>
148
149 * keymap.c (Fkey_description): Don't remove 0x80 bit from
150 non-single-byte char when adding meta modifier. (Bug#12090)
151
6cd7a139
DA
1522012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
153
154 Convert safe_call to use variable number of arguments.
155 * xdisp.c (safe_call): Convert to use varargs. Adjust users.
156 (safe_call2): Fix comment.
157 * lisp.h (safe_call): Adjust prototype.
158 * coding.c (encode_coding_object): Change to use safe_call2.
159 * xfaces.c (merge_face_heights): Change to use safe_call1.
160
d34d6ffc
GM
1612012-07-30 Glenn Morris <rgm@gnu.org>
162
7b8a48e4 163 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
227f5bd0 164 does that unconditionally. Remove file, which is now empty.
7b8a48e4 165
d34d6ffc
GM
166 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
167 Remove empty files.
168
03a660a6
PE
1692012-07-30 Paul Eggert <eggert@cs.ucla.edu>
170
171 Export to GDB most of lisp.h's remaining object-like macros.
172 * lisp.h (min, max): Move earlier, because they're used earlier now.
173 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
174 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
175 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
176 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
177 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
178 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
179 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
180 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
181 Now constants, for GDB. They need not be macros.
182 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
183 Now constants, for GDB, as well as macros, for static initializers.
184 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
185 Move to after the definition of struct Lisp_Char_Table,
186 since the former now needs that type defined.
187 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
188 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
189 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
190 New enums, for gdb_make_enums_visible.
191 (GLYPH_MODE_LINE_FACE): Remove; unused.
88fb40b4 192 * alloc.c (STRING_BYTES_MAX): Now a constant, not a macro.
03a660a6
PE
193 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
194 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
195 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
196 enum maxargs, enum MAX_ALLOCA.
197 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
198 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
199 no longer needed, now that they are done in lisp.h.
200
e499d0ee
DA
2012012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
202
203 Cleanup string bytes checking.
204 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
205 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
206 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
207 (check_sblock, compact_small_strings): Simplify.
208
d5040d2d
PE
2092012-07-29 Paul Eggert <eggert@cs.ucla.edu>
210
211 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
212 These macros are confusing and no longer need to be defined, as
213 the enum values now suffice. All uses replaced with definiens.
214 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
215
7f259ae6
JB
2162012-07-29 Juanma Barranquero <lekktu@gmail.com>
217
218 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
219 ($(BLD)/w32console.$(O)): Update dependencies.
220
7e63e0c3
DA
2212012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
222
223 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
224 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
225 time. Adjust users.
226 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
227
ffd817eb
JD
2282012-07-29 Jan Djärv <jan.h.d@swipnet.se>
229
230 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
231 setting sitelisp (Bug#12010).
232
417a7a0e
EZ
2332012-07-29 Eli Zaretskii <eliz@gnu.org>
234
235 * w32heap.h (OS_9X): Renamed from OS_WINDOWS_95.
236
237 * w32heap.c (cache_system_info):
238 * w32.c (sys_rename):
239 * w32proc.c (find_child_console, sys_kill): All users changed.
240
387d4d92
PE
2412012-07-29 Paul Eggert <eggert@cs.ucla.edu>
242
243 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
244
55a6cca6
EZ
2452012-07-29 Eli Zaretskii <eliz@gnu.org>
246
247 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
248
dbcf001c
DA
2492012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
250
251 Cleanup statistics calculation in Fgarbage_collect.
252 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start. Fix
253 zombies percentage calculation. Simplify elapsed time calculation.
254
e2688e4a
DA
2552012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
256
257 Generalize marker debugging code under MARKER_DEBUG and use eassert.
258 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
259 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
260 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
261 (replace_range, replace_range_2, del_range_2): Change to eassert.
262 * marker.c (byte_char_debug_check): Adjust style.
263
b46a6a83
PE
2642012-07-29 Paul Eggert <eggert@cs.ucla.edu>
265
266 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
267 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
268 long-ago-commented-out code that talks about "WIN32".
269 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
270 All uses changed.
271
e32a5799
PE
2722012-07-28 Paul Eggert <eggert@cs.ucla.edu>
273
274 Use Gnulib stdalign module (Bug#9772, Bug#9960).
275 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
276 Simplify by using alignof.
277 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
278 * lisp.h: Include <stdalign.h>.
279 (GCALIGNMENT): New macro and constant.
280 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
281 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
282 (stdalign): New macro, if not already defined.
283
df81cd29
EZ
2842012-07-28 Eli Zaretskii <eliz@gnu.org>
285
01bd1b0d
EZ
286 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
287 * w32inevt.c: Include w32inevt.h.
288 (w32_read_console_input): New inline function, calls either
289 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
290 w32_console_unicode_input.
291 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
292 (w32_kbd_patch_key, key_event): Use the codepage returned by
293 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
294 (key_event): use uChar.UnicodeChar only if
295 w32_console_unicode_input is non-zero.
296
297 * w32console.c: Include w32heap.h.
298 <w32_console_unicode_input>: New global variable.
299 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
300 family of Windows, zero otherwise.
301
302 * w32inevt.h: Declare w32_console_unicode_input.
303
df81cd29
EZ
304 * xdisp.c (init_iterator): Don't reference tip_frame in a build
305 --without-x. (Bug#11742)
306
c20fdd9e
PE
3072012-07-27 Paul Eggert <eggert@cs.ucla.edu>
308
309 Adjust GDB to reflect pvec_type changes (Bug#12036).
310 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
311 2012-07-04 changes to pseudovector representation. Problem
312 reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
313
32770973 3142012-07-27 Michael Albinus <michael.albinus@gmx.de>
e518bc71
MA
315
316 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
317 bus address.
318 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
319
3438fe21
EZ
3202012-07-27 Eli Zaretskii <eliz@gnu.org>
321
bcfbc9de
EZ
322 * alloc.c (listn): Fix the order the arguments are consed onto the
323 list.
324
3438fe21
EZ
325 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
326 enumeration constants, as PURE and HEAP are too general, and clash
327 with other headers and sources, such as gmalloc.c and the
328 MS-Windows system headers. All users changed.
329
eeaea515
DA
3302012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
331
332 Revert last save_excursion_save and save_excursion_restore changes.
333 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
334 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
335
073c88c2
DA
3362012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
337
338 Fix recently-introduced typos in Windows port.
339 Reported by Martin Rudalics <rudalics@gmx.at>.
340 * w32.c (init_environment): Replace comma with semicolon.
eeaea515 341 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
073c88c2 342
4706125e
PE
3432012-07-27 Paul Eggert <eggert@cs.ucla.edu>
344
345 Improve GDB symbol export (Bug#12036).
346 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
347 arms of an 'if', not using conditional expressions; otherwise GDB
348 complains about the types in the unevaluated arm when the argument
349 is an integer literal.
350 (xgetint): Simplify expression.
351 * alloc.c (gdb_make_enums_visible): New constant. This ports to
352 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
353 Zaretskii in <http://bugs.gnu.org/12036#13>.
354 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
355 needed now that we have gdb_make_enums_visible.
356 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
357 (enum enum_USE_LSB_TAG):
358 New enum types, packaging up enums that need to be exported to GDB.
359
694b6c97
DA
3602012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
361
362 Utility function to make a list from specified amount of objects.
363 * lisp.h (enum constype): New datatype.
364 (listn): New prototype.
365 * alloc.c (listn): New function.
366 (Fmemory_use_count, syms_of_alloc): Use it.
367 * buffer.c (syms_of_buffer): Likewise.
368 * callint.c (syms_of_callint): Likewise.
369 * charset.c (define_charset_internal): Likewise.
370 * coding.c (syms_of_coding): Likewise.
371 * keymap.c (syms_of_keymap): Likewise.
372 * search.c (syms_of_search): Likewise.
373 * syntax.c (syms_of_syntax): Likewise.
374 * w32.c (init_environment): Likewise.
375 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
376 * xdisp.c (syms_of_xdisp): Likewise.
377 * xfns.c (syms_of_xfns): Likewise.
378
6195f384
DA
3792012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
380
381 Fast save_excursion_save and save_excursion_restore.
382 * lisp.h (struct Lisp_Excursion): New data type.
383 (PVEC_EXCURSION): New pseudovector type.
384 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
385 to deal with it. Adjust comments.
386 (init_marker, attach_marker): New prototype.
387 (unchain_marker): Adjust prototype.
388 * marker.c (attach_marker): Change to global.
389 (init_marker): New function.
390 * alloc.c (Fmake_marker, build_marker): Use it.
391 (build_marker): More easserts.
392 (mark_object): Handle struct Lisp_Excursion.
393 * editfns.c (save_excursion_save, save_excursion_restore):
394 Reimplement to use struct Lisp_Excursion. Add comments.
395
5eceb8fb
PE
3962012-07-26 Paul Eggert <eggert@cs.ucla.edu>
397
398 Fix export of symbols to GDB (Bug#12036).
399 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
400 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
401 emacs.c, as this is a more-suitable home. Had this been done earlier
402 the fix for 12036 would have avoided some of the problems noted in
403 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
404 would have been more obvious.
562157c8
PE
405 * emacs.c: Do not include <verify.h>; no longer needed.
406 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
5eceb8fb
PE
407 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
408 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
409 Remove; now done in lisp.h.
410 * lisp.h (PUBLISH_TO_GDB): New macro.
411 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
412 (DATA_SEG_BITS): Use it.
413 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
414 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
415 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
416 not be usable in #if. This simplifies things.
417
d6749401
JB
4182012-07-26 Juanma Barranquero <lekktu@gmail.com>
419
420 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
421
1781b9e9
PE
4222012-07-26 Paul Eggert <eggert@cs.ucla.edu>
423
d89518db 424 Simplify export of symbols to GDB (Bug#12036).
1781b9e9
PE
425 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
426 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
427 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
428 Adjust to changes in lisp.h and emacs.c, by using
429 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
430 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
431 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
432 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
433 instead of gdb_valbits.
434 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
435 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
436 instead of gdb_array_mark_flag.
437 (xboolvector): Get size from $->size, not $->header.size.
438 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
439 (xreload, hook-run, hookpost-run): Remove.
440 * emacs.c: Include <verify.h>.
441 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
442 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
443 Remove.
444 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
445 (gdb_USE_LSB_TAG): New enum constants.
446 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
447 Also define these as enum constants, so they're visible to GDB.
448 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
449 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
450 as constants, so they're visible to GDB.
451 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
452 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
453 Now enum constants, not macros, so they're visible to GDB.
454 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
455 more convenient now. All uses changed.
456 (VALMASK) [USE_LSB_TAG]: Also define in this case.
457 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
458
3628596a
DA
4592012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
460
461 Explicitly free restriction data that are not needed anymore.
462 * editfns.c (save_restriction_restore): Free restriction data.
463
7abaf5cc
SM
4642012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
465
466 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
467 add argument, tune behavior, and adjust all callers.
468
71f88e00
PE
4692012-07-25 Paul Eggert <eggert@cs.ucla.edu>
470
471 Use typedef for EMACS_INT, EMACS_UINT.
472 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
473 than macros. This simplifies debugging in the usual case, since
474 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
475 and it allows expressions involving EMACS_INT casts.
476 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
477
57ec3034
JD
4782012-07-25 Jan Djärv <jan.h.d@swipnet.se>
479
480 * nsterm.m (ns_read_socket): Return early if there is a modal
481 window (Bug#12043).
482
8137e7b3
MR
4832012-07-25 Martin Rudalics <rudalics@gmx.at>
484
485 * frame.c (Fredirect_frame_focus): In doc-string don't mention
486 that FOCUS-FRAME can be omitted.
487
04e9897c
DA
4882012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
489
490 Adjust buffer text indirection counters at the end of Fkill_buffer.
491 * buffer.c (Fkill_buffer): Adjust indirection counters when the
492 buffer is definitely dead. This should really fix an issue reported
493 by Christoph Scholtes again. (Bug#12007).
494 (init_buffer_once): Initialize indirection counters of
495 buffer_defaults and buffer_local_symbols (for sanity and safety).
496
8a0484e1
EZ
4972012-07-24 Eli Zaretskii <eliz@gnu.org>
498
499 * xdisp.c (init_iterator): Don't compute dimensions of truncation
500 and continuation glyphs on tooltip frames, leave them at zero.
501 Avoids continued lines in tooltips. (Bug#11832)
502
fa691a83
DA
5032012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
504
505 Simplify copy_overlay.
04e9897c 506 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
507 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
508
436bc8e0
EZ
5092012-07-23 Eli Zaretskii <eliz@gnu.org>
510
511 * print.c (print_object): Don't crash when a frame's name is nil
512 or invalid. (Bug#12025)
513
514 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
515 it signals an error when a tooltip frame is being created.
516
d7a7fda3
DA
5172012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
518
519 Cleanup miscellaneous objects allocation and initialization.
520 * alloc.c (allocate_misc): Change to static. Add argument to
521 specify the subtype. Adjust comment and users.
522 (build_overlay): New function.
523 * buffer.c (copy_overlays, Fmake_overlay): Use it.
524 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
525 (allocate_misc): Remove prototype.
526 (build_overlay): Add prototype.
527
5282012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
529
530 Swap buffer text indirection counters in Fbuffer_swap_text.
531 * buffer.c (Fbuffer_swap_text): Swap indirections too.
532 This avoids crash reported by Christoph Scholtes at
533 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
534
9d7fa573
JD
5352012-07-22 Jan Djärv <jan.h.d@swipnet.se>
536
537 * nsmenu.m (Popdown_data): New struct.
538 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
539 free Popdown_data.
540 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
541 (initWithContentRect): Make imgView and contentView non-static
542 and autorelease them. Also autorelease img and matrix (Bug#12005).
543 (dealloc): Remove (Bug#12005).
544
0dd6d66d
DA
5452012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
546
547 Adjust consing_since_gc when objects are explicitly freed.
548 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
549 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
550 (free_cons, free_misc): Subtract object size from consing_since_gc.
551
d36d71df
DA
5522012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
553
554 Simplify and cleanup markers positioning code.
555 * marker.c (attach_marker): More useful eassert.
556 (live_buffer, set_marker_internal): New function.
557 (Fset_marker, set_marker_restricted): Use set_marker_internal.
558 (set_marker_both, set_marker_restricted_both): Use live_buffer.
559
fb9ea40f
PE
5602012-07-22 Paul Eggert <eggert@cs.ucla.edu>
561
562 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
563 as it's limited by the amount of memory, not by INT_MAX.
564
2d5c5f7d
EZ
5652012-07-21 Eli Zaretskii <eliz@gnu.org>
566
07fb592e
EZ
567 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
568 in special-event-map. See the discussion at
569 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
570 for the reasons.
571
37a9eac8 572 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
2d5c5f7d
EZ
573 info.dwItemData. Fixes crashes on 64-bit Windows. Suggested by
574 Fabrice Popineau <fabrice.popineau@supelec.fr>.
575
c4328746
JD
5762012-07-21 Jan Djärv <jan.h.d@swipnet.se>
577
578 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 579 (conversationIdentifier): Return value is NSInteger.
784051c4 580 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 581
6e5d1c12
CY
5822012-07-21 Chong Yidong <cyd@gnu.org>
583
584 * window.c (decode_any_window): Signal an error if the window is
585 on a dead frame (Bug#11984).
586
9928463d
DA
5872012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
588
589 Add indirection counting to speed up Fkill_buffer.
590 * buffer.h (struct buffer): New member.
591 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
592 (Fmake_indirect_buffer): Set indirection counter to -1, increment
593 base buffer indirection counter.
594 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
595 (Fkill_buffer): Adjust indirection counters as needed, don't walk
596 through buffer list if indirection counter is 0.
597
f8643a6b
DA
5982012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
599
600 Extend the value returned by Fgarbage_collect with heap statistics.
601 * alloc.c (Qheap): New symbol.
602 (syms_of_alloc): DEFSYM it.
603 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
604 (Fmemory_free): Remove.
605 (syms_of_alloc): Don't defsubr it.
606 * buffer.c (Fcompact_buffer): Remove.
607 (syms_of_buffer): Don't defsubr it.
608
dac616ff
DA
6092012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
610
611 Make maybe_gc inline.
612 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
613 * lisp.h (consing_since_gc, gc_relative_threshold)
614 (memory_full_cons_threshold): Revert declaration.
615 (maybe_gc): Remove prototype, define as inline.
616 * alloc.c: Remove old commented-out code.
617 (consing_since_gc, gc_relative_threshold)
618 (memory_full_cons_threshold): Revert to global.
619 (maybe_gc): Remove.
620
d7ea76b4
DA
6212012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
622
623 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
624 * lisp.h (build_unibyte_string): New function.
625 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
626 * sysdep.c, w32fns.c, xfns.c: Use it.
627 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
628 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
629 Adjust users accordingly.
630 * font.h (font_open_by_name): Adjust prototype.
631
765e61e3
DA
6322012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
633
634 Cleanup calls to Fgarbage_collect.
635 * lisp.h (maybe_gc): New prototype.
636 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
637 Remove declarations.
638 * alloc.c (maybe_gc): New function.
639 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
640 Make them static.
641 * bytecode.c (MAYBE_GC): Use maybe_gc.
642 * eval.c (eval_sub, Ffuncall): Likewise.
643 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
644 to avoid dependency from auto-save feature.
645
52b852c7
PE
6462012-07-19 Paul Eggert <eggert@cs.ucla.edu>
647
648 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
649 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
650 'for_each_per_buffer_object_at'.
651 All uses changed. It's better to use upper-case for macros that
652 cannot be implemented as functions, to give the reader a clue
653 that they're special.
654
5db81e33
SM
6552012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
656
657 * alloc.c (Fgarbage_collect): Tweak docstring.
658
5b835e1d
DA
6592012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
660
661 Tweak the value returned from Fgarbage_collect again.
662 * alloc.c (Fgarbage_collect): New return value, as confirmed in
663 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
664 Adjust documentation.
665 (total_vector_bytes): Rename to total_vector_slots, adjust
666 accounting.
667 (total_free_vector_bytes): Rename to total_free_vector_slots,
668 adjust accounting.
669 (Qstring_bytes, Qvector_slots): New symbols.
670 (syms_of_alloc): DEFSYM them.
671
9cd47b72
DA
6722012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
673
674 Buffer compaction primitive which may be used from Lisp.
675 * buffer.c (compact_buffer, Fcompact_buffer): New function.
676 (syms_of_buffer): Register Fcompact_buffer.
677 * alloc.c (Fgarbage_collect): Use compact_buffer.
678 * buffer.h (compact_buffer): New prototype.
679 (struct buffer_text): New member.
680
d17337e5
DA
6812012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
682
683 New macro to iterate over all buffers, miscellaneous cleanups.
684 * lisp.h (all_buffers): Remove declaration.
685 * buffer.h (all_buffers): Add declaration, with comment.
686 (for_each_buffer): New macro.
687 * alloc.c (Fgarbage_collect, mark_object): Use it.
688 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
689 (init_buffer): Likewise.
690 * data.c (Fset_default): Likewise.
691 * coding.c (code_conversion_restore): Remove redundant check
692 for dead buffer.
693 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
694
60cfd278
AS
6952012-07-18 Andreas Schwab <schwab@linux-m68k.org>
696
697 Fix bug that created negative-length intervals.
698 * intervals.c (merge_interval_right, merge_interval_left):
699 Do not zero out this interval if it is absorbed by its children,
700 as this interval's total length doesn't change in that case. See
701 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
702
d06714cb
PE
7032012-07-18 Paul Eggert <eggert@cs.ucla.edu>
704
83713154
PE
705 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
706 when invoking (make-bool-vector N t) and N is a positive
707 multiple of 8 -- the last 8 bits were mistakenly cleared.
708
d06714cb
PE
709 Remove some struct layout assumptions in bool vectors.
710 * alloc.c (bool_header_size): New constant.
711 (header_size, word_size): Move earlier, as they're now used earlier.
712 Use 'word_size' in a few more places, where it's appropriate.
713 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
714 padding before the data member of a bool vector.
715 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
716 than doing the check by hand with an abort ().
717
464d5a5e
SM
7182012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
719
5fbc0409
SM
720 * eval.c (Fdefvar): Don't check constants since we only set the var if
721 it's not yet defined anyway (bug#11904).
722
464d5a5e
SM
723 * lisp.h (last_undo_boundary): Declare new var.
724 * keyboard.c (command_loop_1): Set it.
725 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
726 were auto-added by the command loop (bug#11774).
727
8dc2e44a
AS
7282012-07-18 Andreas Schwab <schwab@linux-m68k.org>
729
730 * w32font.c (Qsymbol): Remove local definition.
731 (syms_of_w32font): Don't DEFSYM it.
732
169925ec
DA
7332012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
734
735 Fix sweep_vectors to handle large bool vectors correctly.
736 * alloc.c (sweep_vectors): Account total_vector_bytes for
737 bool vectors larger than VBLOCK_BYTES_MAX.
738
5fbfb018
CY
7392012-07-18 Chong Yidong <cyd@gnu.org>
740
741 * frame.c (x_set_frame_parameters): Revert bogus change introduced
742 in 2012-05-25 commit by Paul Eggert (Bug#11738).
743
3ab6e069
DA
7442012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
745
746 Return more descriptive data from Fgarbage_collect.
747 Suggested by Stefan Monnier in
748 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
749 * alloc.c (bounded_number): New function.
750 (total_buffers, total_vectors): New variable.
751 (total_string_size): Rename to total_string_bytes, adjust users.
752 (total_vector_size): Rename to total_vector_bytes, adjust users.
753 (sweep_vectors): Account total_vectors and total_vector_bytes.
754 (Fgarbage_collect): New return value. Adjust documentation.
755 (gc_sweep): Account total_buffers.
756 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
757 (VECTOR_SIZE): Remove.
758 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
759 (Qinterval, Qmisc): New symbols.
760 (syms_of_data): Initialize them.
761 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
762 (Qcons, Qbuffer): New declarations.
763
6d02fe5b
PE
7642012-07-17 Paul Eggert <eggert@cs.ucla.edu>
765
766 * alloc.c (Fmemory_free): Account for memory-free's own storage.
767 Round up, not down. Improve doc.
768
b7ffe040
DA
7692012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
770
771 Restore old code in allocate_string_data to avoid Faset breakage.
772 Reported by Julien Danjou <julien@danjou.info> in
773 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
774 * alloc.c (allocate_string_data): Restore old code with minor
775 adjustments, fix comment to explain this subtle issue.
776
4dc7c8d5
SM
7772012-07-17 Eli Zaretskii <eliz@gnu.org>
778
779 Remove FILE_SYSTEM_CASE.
780 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
781
782 * fileio.c (FILE_SYSTEM_CASE): Don't define.
783 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
784 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
785 call-process-region passes it through expand-file-name.
786
787 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
788
7892012-07-17 Andreas Schwab <schwab@linux-m68k.org>
790
791 Fix crash when creating indirect buffer (Bug#11917)
792 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
793 Don't handle unbound variables specially if non-zero.
794 (Fbuffer_local_variables): Pass zero.
795 (clone_per_buffer_values): Pass non-zero.
796
7972012-07-17 Andreas Schwab <schwab@linux-m68k.org>
798
799 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
800 to make the loop interruptible.
801
8022012-07-17 Andreas Schwab <schwab@linux-m68k.org>
803
804 * gnutls.c (emacs_gnutls_handshake): Only retry if
805 GNUTLS_E_INTERRUPTED.
806
cce7fefc
DA
8072012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
808
809 Cleanup and convert miscellaneous checks to eassert.
810 * alloc.c (mark_interval): Fix comment, partially rephrase
811 old comment from intervals.h (see below).
812 * intervals.c (find_interval, adjust_intervals_for_insertion)
813 (delete_interval, adjust_intervals_for_deletion)
814 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
815 Convert to eassert.
816 (adjust_intervals_for_insertion, make_new_interval):
817 Remove obsolete and unused code.
818 * intervals.h (struct interval): Remove obsolete comment.
819 * textprotp.c (erase_properties): Remove unused code.
820 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
821 (Fremove_list_of_text_properties): Convert to eassert.
822
9ea10cc3
CY
8232012-07-17 Chong Yidong <cyd@gnu.org>
824
825 * editfns.c (Finsert_char): Doc fix.
826
3900d5de
DA
8272012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
828
829 Fix previous change to make Fmemory_free always accurate.
830 * alloc.c (make_interval): Update total_free_intervals.
831 (make_float): Likewise for total_free_floats.
832 (free_cons, Fcons): Likewise for total_free_conses.
833 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
834 Likewise for total_free_vector_bytes.
835 (Fmake_symbol): Likewise for total_free_symbols.
836 (bytes_free): Remove.
837
7098646f
DA
8382012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
839
840 Simple free memory accounting feature.
841 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
842 (sweep_vectors): Accumulate size of free vectors.
843 (Fgarbage_collect): Setup bytes_free.
844 (Fmemory_free): New function.
845 (syms_of_alloc): Register it.
846
22657b40
DA
8472012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
848
849 Cleanup overlays checking.
850 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
851 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
852 eassert and OVERLAYP.
853 (sort_overlays): Change to use OVERLAYP.
854
ddfc8813
RK
8552012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
856
857 * editfns.c (Finsert_char): Make it interactive, and make the
858 second arg optional. Copy interactive spec and docstring from
859 ucs-insert.
860
7c26cf3c
PE
8612012-07-17 Paul Eggert <eggert@cs.ucla.edu>
862
863 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
864 Unlike the other wrapped functions, fabs has an unspecified
865 effect on errno.
866
5d127af9
JD
8672012-07-16 Jan Djärv <jan.h.d@swipnet.se>
868
869 * nsterm.m (keyDown): Interpret flags without left/right bits
870 as the left key (Bug#11670).
871
6a0dd1d7
DA
8722012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
873
874 Remove empty and useless init functions.
875 * lisp.h (init_character_once, init_fns, init_image)
876 (init_filelock, init_sound): Remove prototype.
877 * character.c (init_character_once): Remove.
878 * filelock.c (init_filelock): Likewise.
879 * fns.c (init_fns): Likewise.
880 * image.c (init_image): Likewise.
881 * sound.c (init_sound): Likewise.
882 * emacs.c (main): Adjust accordingly.
883
7a6136fd
DA
8842012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
885
886 * gtkutil.h: Tiny cleanups.
887 (use_old_gtk_file_dialog): Remove useless declaration.
888 (xg_uses_old_file_dialog): Add suggested const attribute.
889
ce811ad9
EZ
8902012-07-15 Eli Zaretskii <eliz@gnu.org>
891
892 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
893 (bidi_paragraph_init): Use it to limit search forward for a strong
894 directional character in abnormally large paragraphs full of
895 neutral or weak characters. (Bug#11943)
896
c9adfeaa
SF
8972012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
898
899 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
900 the toolbar (Bug#9451).
901 (xg_make_tool_item): Give the widget event box a transparent
902 background.
903
fff62aa9
DA
9042012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
905
906 Cleanup basic allocation variables and functions.
907 * alloc.c (ignore_warnings, init_intervals, init_float)
908 (init_cons, init_symbol, init_marker): Remove.
909 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
910 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
911 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
912 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
913 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
914 (staticidx, init_alloc_once, init_strings, free_ablock):
915 Remove redundant initialization.
916 * fns.c (init_weak_hash_tables): Remove.
917 * lisp.h (init_weak_hash_tables): Remove prototype.
918
9730daca
DA
9192012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
920
921 Use zero_vector where appropriate.
922 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
923 accordingly.
924 * lisp.h (zero_vector): New declaration.
925 * font.c (null_vector): Remove.
926 (syms_of_font): Remove initialization and staticpro.
927 (font_list_entities, font_find_for_lface): Change to use zero_vector.
928 * keymap.c (Faccessible_keymaps): Likewise.
929
2e2d2a13
LL
9302012-07-15 Leo Liu <sdl.web@gmail.com>
931
932 * fringe.c: Fix typo in comments.
933
cd276f6e
LL
9342012-07-14 Leo Liu <sdl.web@gmail.com>
935
936 * fringe.c: Add a new bitmap exclamation-mark.
937
5a1131d9
EZ
9382012-07-14 Eli Zaretskii <eliz@gnu.org>
939
940 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
941
942 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
943 (HAVE_MENUS): Don't define, defined by editing config.in with
944 msdos/sed2v2.inp.
945 (GMALLOC_INHIBIT_VALLOC): Don't define.
946 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
947
22e983b7
JB
9482012-07-14 Juanma Barranquero <lekktu@gmail.com>
949
950 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
951
5b3f250f
GM
9522012-07-14 Glenn Morris <rgm@gnu.org>
953
954 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
955 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
956 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
957
33d63ff4
GM
9582012-07-13 Glenn Morris <rgm@gnu.org>
959
5b633342
GM
960 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
961
33d63ff4
GM
962 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
963 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
964
b55b9f85
JD
9652012-07-13 Jan Djärv <jan.h.d@swipnet.se>
966
0dc8cf50
JD
967 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
968 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
969 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
970 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
971 where appropriate.
972 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
973 as boolean expression.
974 (x_set_window_size): Remove unused variable toolbar.
975 (ns_get_color_default, ns_mod_to_lisp): Remove.
976 (ns_mouse_position): Remove unused variables xchar and ychar.
977 (ns_compute_glyph_string_overhangs): Remove unused variable face.
978 (ns_set_vertical_scroll_bar): Remove unused variable count.
979 (ns_delete_terminal): Remove unused variable i.
980 (ns_term_init): Remove unused variables r, g and b.
981 (mouseDown): Remove unused variable window.
982 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
983 (initFrameFromEmacs): Remove unused variable vbextra.
984 (mouseEntered): Remove unused variables p and dpyinfo.
985 (mouseExited): Remove unused variables p and r.
986 (ns_define_frame_cursor, ns_clear_frame_area)
987 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
988 (menuDown): Assign [sender tag] to variable and cast the variable.
989
990 * nsterm.h (menuDown): Add id as type to argument sender.
991 (ns_display_info_for_name): Add Lisp_Object argument.
992 (ns_term_init): Add Lisp_Object argument.
993 (ns_map_event_to_object): Add void argument.
994 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
995 prototype with arguments and only declare if __OBJC__.
996 (nxatoms_of_nsselect): Add void argument.
997 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
998 (ns_alloc_autorelease_pool): Add void argument.
999 (ns_release_autorelease_pool): Add void* argument.
1000 (ns_get_defaults_value): Add const char* argument.
1001
1002 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
1003 (initFromContents): Use SSDATA where appropriate.
1004 (ns_update_menubar): Add braces to ambigous if-else.
1005 (initWithTitle): Put () around assignment in if statement.
1006 (ns_menu_show): Remove unused variables window and keymap.
1007 (update_frame_tool_bar): Remove unused variable selected_p.
1008 (initWithContentRect): Remove unused variable this_cmd_name.
1009
1010 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
1011 appropriate.
1012 (setXBMColor): Remove unused variable len.
1013 (setPixmapData): Put () around assignment in loop statement.
1014
1015 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
1016 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
1017 where appropriate.
1018 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
1019 around assignment in loop statement.
1020 (nsfont_open): Remove unused variable i.
1021 (nsfont_open): Remove unused variable len.
1022 (nsfont_draw): Remove unused variable cs.
1023
1024 * nsfns.m (x_set_icon_name, ns_set_name_internal)
1025 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
1026 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
1027 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
1028 (Fns_font_name, Fns_perform_service)
1029 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
1030 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
1031 (ns_set_name): Remove unused variable view.
1032 (x_set_menu_bar_lines): Remove unused variable olines.
1033 (x_set_tool_bar_lines): Remove unused variable root_window.
1034 (Fns_list_colors): Put () around assignment in while statement.
1035 (Fns_perform_service): Remove unused variable len.
1036 (Fns_display_usable_bounds): Remove unused variable top.
1037 (syms_of_nsfns): Remove unused variable i.
1038
b55b9f85
JD
1039 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
1040 memcpy (Bug#11907).
1041
ed9265fc 10422012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
1043
1044 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
1045 and free it with DestroyExceptionInfo (Bug#11558).
1046
ef099b57
JB
10472012-07-13 Juanma Barranquero <lekktu@gmail.com>
1048
1049 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
1050 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
1051 Set here, not in nt/config.nt.
1052
ea814a5d
EZ
10532012-07-13 Eli Zaretskii <eliz@gnu.org>
1054
1055 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
1056 cursor overflow into the last glyph on display line when the right
1057 fringe is off. (Bug#11832)
1058
1a952767
PE
10592012-07-13 Paul Eggert <eggert@cs.ucla.edu>
1060
1061 * xdisp.c (produce_special_glyphs): Now static.
1062 * dispextern.h (produce_special_glyphs): Remove decl.
1063
983188fd
GM
10642012-07-13 Glenn Morris <rgm@gnu.org>
1065
32fb4bb6
GM
1066 * s/bsd-common, s/cygwin.h: Remove empty files.
1067 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
1068
983188fd
GM
1069 * s/usg5-4-common.h (USG, USG5):
1070 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
1071 * s/sol2-6.h (SOLARIS2):
1072 * s/irix6-5.h (IRIX6_5):
1073 * s/hpux10-20.h (USG, USG5, HPUX):
1074 * s/gnu-linux.h (USG, GNU_LINUX):
1075 * s/freebsd.h (BSD_SYSTEM):
1076 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
1077 * s/cygwin.h (CYGWIN):
1078 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
1079 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
1080
d1e68667 10812012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
1082
1083 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 1084
6de0e799
GM
10852012-07-13 Glenn Morris <rgm@gnu.org>
1086
739ae010
GM
1087 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
1088
dbee5793
GM
1089 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
1090
6de0e799
GM
1091 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
1092 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
1093
b82da769
GM
10942012-07-12 Glenn Morris <rgm@gnu.org>
1095
4fae5a7a 1096 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
1097
1098 * process.c (init_process_emacs): Rename from init_process.
1099 The old name is also the name of a Mach system call.
1100 * lisp.h, emacs.c: Update for this name change.
1101 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
1102 longer needed.
1103
5a979817
EZ
11042012-07-12 Eli Zaretskii <eliz@gnu.org>
1105
1106 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
1107 memmove call that removes glyphs covered by the left truncation
1108 glyph. Improve commentary.
1109 (display_line): Fix display of continuation glyphs on GUI frames
1110 when the right fringe is turned off and variable-size fonts are
1111 used in the window. Move the code that appends a stretch glyph to
1112 produce_special_glyphs, so that it could be used for truncation
1113 and continuation glyphs alike.
1114 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
1115 glyph of a suitably computed width, to align the special glyphs at
1116 the window margin. Code moved from display_line. (Bug#11832)
1117
3e91a053
GM
11182012-07-12 Glenn Morris <rgm@gnu.org>
1119
ba9e4b84
GM
1120 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
1121
1122 * s/gnu-linux.h, s/hpux10-20.h:
1123 Do not unconditionally define HAVE_XRMSETDATABASE.
1124
3e91a053
GM
1125 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
1126
b300b1f4
PE
11272012-07-12 Paul Eggert <eggert@cs.ucla.edu>
1128
1129 Fix typos that broke OS X build.
1130 Reported by Randal L. Schwartz in
1131 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
1132 * nsterm.m (ns_timeout): Add missing local decl.
1133 (ns_get_color): snprintf -> sprintf, to fix typo.
1134
6e777848
GM
11352012-07-12 Glenn Morris <rgm@gnu.org>
1136
3f922c37
GM
1137 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
1138 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
1139 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
1140 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
1141
0ab7b23a
GM
1142 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
1143 Move PTY_OPEN to configure.
1144
6e777848
GM
1145 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1146 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
1147 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
1148
4a7edc24
DA
11492012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
1150
1151 Use empty_unibyte_string where applicable.
1152 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
1153 * lread.c (read1): Likewise.
1154 * xsettings.c (syms_of_xsettings): Likewise.
1155
308aab79
GM
11562012-07-12 Glenn Morris <rgm@gnu.org>
1157
42bd1719
GM
1158 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
1159 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
1160 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
1161 * s/hpux10-20.h (RUN_TIME_REMAP):
1162 * s/bsd-common.h (TABDLY): Move to configure.
1163
1164 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
1165
1166 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
1167
ea0bbd17 1168 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 1169 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
1170
1171 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 1172
308aab79
GM
1173 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
1174 * s/template.h: Move NARROWPROTO to configure.
1175
ee1cf5cf
GM
11762012-07-11 Glenn Morris <rgm@gnu.org>
1177
30fe9bf4
GM
1178 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
1179 unused since 2011-01-17 change to systty.h.
1180
ee1cf5cf
GM
1181 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
1182 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1183 Move HAVE_PTYS and HAVE_SOCKETS to configure.
1184
63e47e07
PE
11852012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1186
1187 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
1188
c43fb4c3
GM
11892012-07-11 Glenn Morris <rgm@gnu.org>
1190
1191 * s/darwin.h, s/gnu-linux.h, s/template.h:
1192 Move INTERRUPT_INPUT to configure.
1193
e8df9267
DA
11942012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1195
1196 Minor adjustments to interning code.
1197 * lisp.h (intern, intern_c_string): Redefine as static inline
1198 wrappers for intern_1 and intern_c_string_1, respectively.
1199 (intern_1, intern_c_string_1): Rename prototypes.
2bce5643
DA
1200 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
1201 Vobarray checking.
e8df9267
DA
1202 * font.c (font_intern_prop): Likewise. Adjust comment.
1203 * w32font.c (intern_font_name): Likewise.
1204
34348bd4
AS
12052012-07-11 Andreas Schwab <schwab@linux-m68k.org>
1206
d96a1e0c
AS
1207 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
1208
34348bd4
AS
1209 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
1210 of Fcar/Fcdr if possible.
1211 * font.c (check_otf_features): Likewise.
1212 * fontset.c (Fnew_fontset): Likewise.
1213 * gnutls.c (Fgnutls_boot): Likewise.
1214 * minibuf.c (read_minibuf): Likewise.
1215 * msdos.c (IT_set_frame_parameters): Likewise.
1216 * xmenu.c (Fx_popup_dialog): Likewise.
1217 * w32menu.c (Fx_popup_dialog): Likewise.
1218
c8add24e
GM
12192012-07-11 Glenn Morris <rgm@gnu.org>
1220
4b575b3c
GM
1221 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
1222 since nothing has defined it on these platforms.
1223
09f4e3b0
GM
1224 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
1225 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
1226
172bedef
GM
1227 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1228 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1229 Move CLASH_DETECTION to configure.
1230
249685df
GM
1231 * s/gnu.h: Remove file, which is now empty.
1232
c8add24e
GM
1233 * s/gnu.h, s/gnu-linux.h:
1234 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
1235
b41253a3
JW
12362012-07-11 John Wiegley <johnw@newartisans.com>
1237
1238 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
1239 function attribute, so we only use it if it exists in the
1240 compiler.
1241
d923b542
DA
12422012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1243
1244 Avoid call to strlen in fast_c_string_match_ignore_case.
1245 * search.c (fast_c_string_match_ignore_case): Change to use
1246 length argument. Adjust users accordingly.
1247 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
1248
5ebbef1d
PE
12492012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1250
bb352260
PE
1251 Assume mkdir, rmdir.
1252 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
1253 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
1254
57054ddd
PE
1255 Assume rename.
1256 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
1257
b747d3f7
PE
1258 Assume perror.
1259 * s/hpux10-20.h (HAVE_PERROR): Remove.
1260 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
1261 Remove dummy definition, as this problem was obsolete long ago.
1262
5ebbef1d
PE
1263 Assume strerror.
1264 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
1265
984e7f30
DA
12662012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1267
1268 Avoid calls to strlen in font processing functions.
1269 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
d923b542 1270 (font_open_by_name): Change to use length argument. Adjust
984e7f30 1271 users accordingly.
d923b542
DA
1272 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
1273 Adjust prototypes.
1274 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
1275 Change to return ptrdiff_t.
984e7f30
DA
1276 (xfont_list_pattern, xfont_match): Use length returned by
1277 xfont_decode_coding_xlfd.
1278 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
1279
20e94fdd
GM
12802012-07-11 Glenn Morris <rgm@gnu.org>
1281
9d596af3
GM
1282 * s/darwin.h, s/freebsd.h, s/netbsd.h:
1283 Move DONT_REOPEN_PTY to configure.
1284
20e94fdd
GM
1285 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
1286 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
1287
e99a530f
PE
12882012-07-10 Paul Eggert <eggert@cs.ucla.edu>
1289
22ffb973
PE
1290 Remove "#define unix" that is no longer needed (Bug#11905).
1291 * s/aix4-2.h (unix): Remove; no longer needed.
1292
e9a9ae03
PE
1293 EMACS_TIME simplification (Bug#11875).
1294 This replaces macros (which typically do not work in GDB)
1295 with functions, typedefs and enums, making the code easier to debug.
1296 The functional style also makes code easier to read and maintain.
1297 * systime.h: Include <sys/time.h> on all hosts, not just if
1298 WINDOWSNT, since 'struct timeval' is needed in general.
1299 (EMACS_TIME): Now a typedef, not a macro.
1300 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
1301 not macros.
1302 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
1303 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
1304 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
1305 (EMACS_TIME_LE): Now functions, not macros.
1306 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
1307 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
1308 which are not functions. All uses rewritten to use:
1309 (make_emacs_time): New function.
1310 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
1311 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
1312 not functions. All uses rewritten to use the following, respectively:
1313 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
1314 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 1315 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
1316 * fileio.c (Fcopy_file):
1317 * xterm.c (XTflash): Get the current time closer to when it's used.
1318 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
1319
ffacb126
PE
1320 * bytecode.c (targets): Suppress -Woverride-init warnings.
1321
e99a530f
PE
1322 Simplify by avoiding confusing use of strncpy etc.
1323 * doc.c (Fsnarf_documentation):
1324 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
1325 * frame.c (Fmake_terminal_frame):
1326 * gtkutil.c (get_utf8_string):
1327 * lread.c (openp):
1328 * nsmenu.m (ns_update_menubar):
1329 * regex.c (regerror):
1330 Prefer memcpy to strncpy and strncat when either will do.
1331 * fileio.c (Fsubstitute_in_file_name):
1332 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
1333 (menu_separator_name_p):
1334 * nsmenu.m (ns_update_menubar):
1335 Prefer memcmp to strncmp when either will do.
1336 * nsterm.m: Include <ftoastr.h>.
1337 (ns_get_color):
1338 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
1339 Prefer snprintf to strncpy.
1340 * nsterm.m (ns_term_init):
1341 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
1342 * nsterm.m (ns_term_init):
1343 Avoid the need for strncpy, by using build_string or
1344 make_unibyte_string directly. Use dtoastr, not snprintf.
1345 * process.c (Fmake_network_process): Diagnose service names that
1346 are too long, rather than silently truncating them or creating
1347 non-null-terminated names.
1348 (Fnetwork_interface_info): Likewise, for interface names.
1349 * sysdep.c (system_process_attributes) [GNU_LINUX]:
1350 Prefer sprintf to strncat.
1351 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
1352 Prefer vsnprintf to vsprintf + strncpy.
1353
c59592b3
GM
13542012-07-10 Glenn Morris <rgm@gnu.org>
1355
1356 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
1357 Clarify fallback case.
1358
7d7bbefd
DA
13592012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1360
1361 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
1362 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
1363 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 1364 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
1365 where argument type is known to be a Lisp_Cons.
1366
3a4c8000
TT
13672012-07-10 Tom Tromey <tromey@redhat.com>
1368
1369 * bytecode.c (BYTE_CODE_THREADED): New macro.
1370 (BYTE_CODES): New macro. Replaces all old byte-code defines.
1371 (enum byte_code_op): New type.
1372 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
1373 (exec_byte_code): Use them. Use token threading when applicable.
1374
2a0213a6
DA
13752012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1376
1377 Optimize pure C strings initialization.
1378 * lisp.h (make_pure_string): Fix prototype.
1379 (build_pure_c_string): New function, defined as static inline. This
1380 provides a better opportunity to optimize away calls to strlen when
1381 the function is called with compile-time constant argument.
1382 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
1383 argument, adjust users accordingly. Use build_pure_c_string where
1384 appropriate.
1385 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
1386 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
1387 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
1388
cb1caeaf
DA
13892012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1390
1391 Avoid calls to strlen in miscellaneous functions.
1392 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
1393 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
1394 * lread.c (openp): Likewise.
1395
c293e30c
DA
13962012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1397
1398 Avoid calls to strlen in path processing functions.
1399 * fileio.c (file_name_as_directory): Add comment. Change to add
1400 srclen argument and return the length of result. Adjust users
1401 accordingly.
1402 (directory_file_name): Fix comment. Change to add srclen argument,
cb1caeaf 1403 swap 1st and 2nd arguments to obey the common convention. Adjust
c293e30c
DA
1404 users accordingly.
1405 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
1406
9e059e3f
GM
14072012-07-10 Glenn Morris <rgm@gnu.org>
1408
d02eb359
GM
1409 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
1410 Move PENDING_OUTPUT_COUNT definition to configure.
1411
882cf227
GM
1412 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
1413 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
1414 * s/gnu.h (DATA_START): Move definitions to configure.
1415
af6e839f
GM
1416 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
1417 We include usg5-4-common.h, which defines them both.
1418
40289a12
GM
1419 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
1420 O_RDONLY already includes it).
1421
9e059e3f
GM
1422 Stop ns builds setting the EMACSLOADPATH environment variable.
1423 * nsterm.m (ns_load_path): Rename from ns_init_paths.
1424 Now it does not set EMACSLOADPATH, just returns the load-path string.
1425 * nsterm.h: Update accordingly.
1426 * lread.c [HAVE_NS]: Include nsterm.h.
1427 (init_lread) [HAVE_NS]: Use ns_load_path.
1428 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
1429
7c4e8ec0
GM
14302012-07-09 Glenn Morris <rgm@gnu.org>
1431
d4f600ff
GM
1432 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
1433 since the included bsd-common.h does so.
1434
cbb31951
GM
1435 Stop ns builds setting the EMACSPATH environment variable.
1436 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
1437 (ns_init_paths): Do not set EMACSPATH.
1438 * nsterm.h (ns_exec_path): Add it.
1439 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
1440 Use ns_exec_path.
1441
7c4e8ec0
GM
1442 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
1443
26bccfae
PE
14442012-07-09 Paul Eggert <eggert@cs.ucla.edu>
1445
a0bee46f
PE
1446 * process.c (wait_reading_process_output): 'waitchannels' was unset
1447 when read_kbd || !NILP (wait_for_cell); fix this.
1448
5994c183
PE
1449 Add GCC-style 'const' attribute to functions that can use it.
1450 * character.h (char_resolve_modifier_mask):
1451 * keyboard.h (make_ctrl_char):
1452 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
1453 (init_character_once, next_almost_prime, init_fns, init_image)
1454 (flush_pending_output, init_sound):
1455 * mem-limits.h (start_of_data):
1456 * menu.h (finish_menu_items):
1457 Add ATTRIBUTE_CONST.
1458 * emacs.c (DEFINE_DUMMY_FUNCTION):
1459 Declare the dummy function with ATTRIBUTE_CONST.
1460 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
1461 Add decls with ATTRIBUTE_CONST.
1462
26bccfae
PE
1463 Minor improvements to make_formatted_string.
1464 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
1465 where int is good enough, as vsprintf returns an int.
1466 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
1467
a8290ec3
DA
14682012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1469
1470 Use make_formatted_string to avoid double length calculation.
1471 * lisp.h (make_formatted_string): New prototype.
1472 * alloc.c (make_formatted_string): New function.
1473 * buffer.c (Fgenerate_new_buffer_name): Use it.
1474 * dbus.c (syms_of_dbusbind): Likewise.
1475 * editfns.c (Fcurrent_time_zone): Likewise.
1476 * filelock.c (get_boot_time): Likewise.
1477 * frame.c (make_terminal_frame, set_term_frame_name)
1478 (x_report_frame_params): Likewise.
1479 * image.c (gs_load): Likewise.
1480 * minibuf.c (get_minibuffer): Likewise.
1481 * msdos.c (dos_set_window_size): Likewise.
1482 * process.c (make_process): Likewise.
1483 * xdisp.c (ensure_echo_area_buffers): Likewise.
1484 * xsettings.c (apply_xft_settings): Likewise.
1485
d01ba2f1
GM
14862012-07-09 Glenn Morris <rgm@gnu.org>
1487
1488 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
1489 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
1490 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
1491 * nsterm.h (ns_etc_directory): Add it.
1492 * callproc.c [HAVE_NS]: Include nsterm.h.
1493 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
1494
f1f924b6
DA
14952012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1496
1497 Move marker debugging code under MARKER_DEBUG.
1498 * marker.c (MARKER_DEBUG): Move marker debugging code under
1499 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
1500 for bootstrap with --enable-checking (~3x slowdown reported
1501 by Juanma Barranquero <lekktu@gmail.com>).
1502 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
1503
ab531b66
PE
15042012-07-08 Paul Eggert <eggert@cs.ucla.edu>
1505
1506 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
1507 See <http://bugs.gnu.org/11825#29>.
1508
c4b3bc8a
EZ
15092012-07-08 Eli Zaretskii <eliz@gnu.org>
1510
1511 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
1512 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
1513 (display_line): Add commentary about displaying truncation glyphs
1514 on GUI frames.
1515 (produce_special_glyphs): Move here from term.c.
1516
1517 * term.c (produce_special_glyphs): Move to xdisp.c.
1518
1519 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
1520 section.
c4b3bc8a 1521
b676b881
AS
15222012-07-07 Andreas Schwab <schwab@linux-m68k.org>
1523
f17c5273
AS
1524 * xdisp.c (display_line): Avoid warning about implicit declaration
1525 of FRAME_FONT.
1526
298819b9
AS
1527 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
1528
b676b881
AS
1529 * lisp.h: Remove empty conditional.
1530
6045c4fd
PE
15312012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1532
b3350bf9
PE
1533 * lread.c (load_path_check): Now static.
1534
6045c4fd
PE
1535 Fix some minor --with-ns problems found by static checking.
1536 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
1537 (x_set_font) [!HAVE_X_WINDOWS]:
1538 * image.c (xpm_load_image) [HAVE_NS]:
1539 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
1540 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
1541 Remove unused local.
1542 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
1543 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
1544 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
1545 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
1546 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
1547 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
1548 Fix pointer signedness problem.
1549 * xfaces.c (FRAME_X_FONT_TABLE):
1550 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
1551
929e7845
GM
15522012-07-07 Glenn Morris <rgm@gnu.org>
1553
1554 * lread.c (load_path_check): New function, split from init_lread.
1555 (init_lread): Reorganize. Motivation:
1556 If EMACSLOADPATH is set, check/warn about that rather than the
1557 defaults, which we are not going to use. Hence we can remove
1558 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
1559 Don't warn if site-lisp directories are missing.
1560 If not installed, start from a blank load-path, since
1561 PATH_LOADSEARCH refers to the eventual installation directories.
1562
58dd0aa4
EZ
15632012-07-07 Eli Zaretskii <eliz@gnu.org>
1564
1565 Support truncation and continuation glyphs on GUI frames, when
1566 fringes are disabled. (Bug#11832)
1567 * xdisp.c (init_iterator): Get dimensions of truncation and
1568 continuation glyphs even if on GUI frames. Adjust
1569 it->last_visible_x on GUI frames when the left or right fringes,
1570 or both, are absent.
1571 (start_display, move_it_in_display_line_to): Handle the case of a
1572 GUI frame without a fringe to display continuation or truncation
1573 glyphs.
1574 (insert_left_trunc_glyphs): Support GUI frames: make sure
1575 truncation glyphs overwrite enough glyphs from the current line to
1576 have sufficient space in pixels.
1577 (display_line): Support truncation and continuation glyphs on GUI
1578 frames. If some spare pixels are left on the line after inserting
1579 the truncation glyphs, fill that space with a stretch glyph of a
1580 suitably computed width.
1581
1582 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
1583 produce_glyphs, to support GUI sessions.
1584
31571fd7
PE
15852012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1586
5a16b9bc
PE
1587 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
1588
f3047c75
PE
1589 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
1590
31571fd7
PE
1591 Do not require float-time's arg to fit in time_t (Bug#11825).
1592 This works better on hosts where time_t is unsigned, and where
1593 float-time is applied to the (negative) difference between two times.
1594 * editfns.c (decode_time_components): Last arg is now double *,
1595 not int *, and means to store all the result as a double, without
1596 worrying about whether the seconds part fits in time_t.
1597 All callers changed.
1598 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
1599 All callers changed.
1600 (Ffloat_time): Do not fail merely because the specified time falls
1601 outside of time_t range.
1602
4516fbef
GM
16032012-07-07 Glenn Morris <rgm@gnu.org>
1604
1605 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
1606 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
1607 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
1608
07adc2c6
JB
16092012-07-07 Juanma Barranquero <lekktu@gmail.com>
1610
1611 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
1612 Update dependencies.
1613
1614 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
1615
fd573f31
PE
16162012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1617
fee5959d
PE
1618 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
1619 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
1620 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
1621 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
1622 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
1623 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
1624
fd573f31
PE
1625 * xfont.c (compare_font_names): Redo to omit the need for casts.
1626
ddadbc0e
AS
16272012-07-06 Andreas Schwab <schwab@linux-m68k.org>
1628
fca8d6b6
AS
1629 * xfns.c (Fx_change_window_property): Doc fix.
1630 * w32fns.c (Fx_change_window_property): Doc fix.
1631
ddadbc0e
AS
1632 * w32fns.c (Fx_window_property): Accept the same arguments as the
1633 X Windows version. Doc fix.
1634 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
1635
ed9265fc 16362012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
1637 Eli Zaretskii <eliz@gnu.org>
1638
1639 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
1640 Windows-specific code from nt/config.nt moved here.
1641 Obsolete settings removed.
1642
216ee680
PE
16432012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1644
1645 * process.c: Avoid unnecessary calls to gettime.
1646 (wait_reading_process_output): Don't get the time of day
1647 when gobbling data immediately and not waiting, as there's no need
1648 for it in that case. This removes a FIXME.
1649
bdd091e4
JD
16502012-07-06 Jan Djärv <jan.h.d@swipnet.se>
1651
1652 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
1653 is defined (Bug#11768).
1654
9d44f8ce
DA
16552012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1656
1657 Fix marker debugging code.
1658 * marker.c (byte_char_debug_check): Do not perform the check
1659 if buffer is not multibyte.
090bd7cb
JB
1660 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1661 Call byte_char_debug_check with correct arguments.
9d44f8ce 1662
90fc4786
DA
16632012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1664
1665 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
1666 * marker.c (byte_char_debug_check, count_markers):
1667 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
1668 (byte_debug_flag): Remove.
1669 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1670 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
1671
7b7ae965
DA
16722012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1673
4e57b342
DA
1674 Avoid code repetition in marker-related functions.
1675 * marker.c (attach_marker): New function.
1676 (Fset_marker, set_marker_restricted, set_marker_both)
1677 (set_marker_restricted_both): Use it.
1678 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
1679 Consistently rename charno to charpos.
1680 (marker_position): Add eassert.
1681 (marker_byte_position): Convert to eassert.
1682
16832012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1684
1685 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 1686 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 1687 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 1688
657924ff
DA
16892012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1690
1691 Introduce fast path for the widely used marker operation.
1692 * alloc.c (build_marker): New function.
1693 * lisp.h (build_marker): New prototype.
1694 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
1695 * composite.c (autocmp_chars): Likewise.
1696 * editfns.c (buildmark): Remove.
1697 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
1698 (save_restriction_save): Use build_marker.
1699 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
1700 * window.c (save_window_save): Likewise.
1701
041a49a6
DA
17022012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1703
1704 Do not use Fdelete_overlay in delete_all_overlays
1705 to avoid redundant calls to unchain_overlay.
1706 * buffer.c (drop_overlay): New function.
1707 (delete_all_overlays, Fdelete_overlay): Use it.
1708 * minibuf.c (get_minibuffer): Fix comment.
1709
7dca65a4
PE
17102012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1711
1712 Port to OpenBSD 5.1 amd64.
1713 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
1714 This is needed for OpenBSD, and should be harmless on all BSD systems.
1715 Also, include <sys/sysctl.h>, as it should be available on all
1716 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
1717 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
1718 use p_pid member, not kp_proc.pid.
1719
8eb876e2
GM
17202012-07-06 Glenn Morris <rgm@gnu.org>
1721
1722 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
1723
38182d90
PE
17242012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1725
1726 More xmalloc and related cleanup.
1727 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
1728 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
1729 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
1730 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
1731 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
1732 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
1733 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
1734 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
1735 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
1736 * xterm.c:
1737 Omit needless casts involving void * pointers and allocation.
1738 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
1739 as the former is more robust if P's type is changed.
1740 Prefer xzalloc to xmalloc + memset 0.
1741 Simplify malloc-or-realloc to realloc.
1742 Don't worry about xmalloc returning a null pointer.
1743 Prefer xstrdup to xmalloc + strcpy.
1744 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
1745 growing it.
1746 * keyboard.c (apply_modifiers_uncached): Prefer local array to
1747 alloca of a constant.
1748
6dd5a677
EZ
17492012-07-05 Eli Zaretskii <eliz@gnu.org>
1750
1751 * xdisp.c (display_line): Fix horizontal pixel coordinates when
1752 hscroll is larger than the line width. Fixes long and futile
1753 looping inside extend_face_to_end_of_line (on a TTY) producing
1754 glyphs that are not needed and thrown away.
1755
6b312f0f
DA
17562012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1757
1758 * marker.c (set_marker_restricted_both): Simplify by using
1759 clip_to_bounds.
1760
f520ef9b
PE
17612012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1762
1763 * editfns.c (region_limit): Simplify by using clip_to_bounds.
1764
383b7c95
JD
17652012-07-05 Jan Djärv <jan.h.d@swipnet.se>
1766
1767 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
1768 not defined (Bug#11768).
1769 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
1770 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
1771 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
1772 followed by gtk_box_set_homogeneous (Bug#11768).
1773 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
1774 (update_theme_scrollbar_width, xg_create_scroll_bar):
1775 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
1776 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
1777 (is_box_type): New function (Bug#11768).
1778 (xg_tool_item_stale_p): Call is_box_type.
5293d758 1779 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
1780 with default display (Bug#11768).
1781
d6e7bf45
EZ
17822012-07-05 Eli Zaretskii <eliz@gnu.org>
1783
1784 * xdisp.c (window_hscroll_limited): New function.
1785 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
1786 coordinates when window's hscroll is set to insanely large
1787 values. (Bug#11857)
1788
431391ec
JB
17892012-07-05 Juanma Barranquero <lekktu@gmail.com>
1790
1791 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
1792 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
1793
23f86fce
DA
17942012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1795
1796 Cleanup xmalloc.
1797 * lisp.h (xzalloc): New prototype. Omit needless casts.
1798 * alloc.c (xzalloc): New function. Omit needless casts.
1799 * charset.c: Omit needless casts. Convert all calls to
1800 xmalloc with following memset to xzalloc.
1801 * dispnew.c: Likewise.
1802 * fringe.c: Likewise.
1803 * image.c: Likewise.
1804 * sound.c: Likewise.
1805 * term.c: Likewise.
1806 * w32fns.c: Likewise.
1807 * w32font.c: Likewise.
1808 * w32term.c: Likewise.
1809 * xfaces.c: Likewise.
1810 * xfns.c: Likewise.
1811 * xterm.c: Likewise.
1812 * atimer.c: Omit needless casts.
1813 * buffer.c: Likewise.
1814 * callproc.c: Likewise.
1815 * ccl.c: Likewise.
1816 * coding.c: Likewise.
1817 * composite.c: Likewise.
1818 * doc.c: Likewise.
1819 * doprnt.c: Likewise.
1820 * editfns.c: Likewise.
1821 * emacs.c: Likewise.
1822 * eval.c: Likewise.
1823 * filelock.c: Likewise.
1824 * fns.c: Likewise.
1825 * gtkutil.c: Likewise.
1826 * keyboard.c: Likewise.
1827 * lisp.h: Likewise.
1828 * lread.c: Likewise.
1829 * minibuf.c: Likewise.
1830 * msdos.c: Likewise.
1831 * print.c: Likewise.
1832 * process.c: Likewise.
1833 * region-cache.c: Likewise.
1834 * search.c: Likewise.
1835 * sysdep.c: Likewise.
1836 * termcap.c: Likewise.
1837 * terminal.c: Likewise.
1838 * tparam.c: Likewise.
1839 * w16select.c: Likewise.
1840 * w32.c: Likewise.
1841 * w32reg.c: Likewise.
1842 * w32select.c: Likewise.
1843 * w32uniscribe.c: Likewise.
1844 * widget.c: Likewise.
1845 * xdisp.c: Likewise.
1846 * xmenu.c: Likewise.
1847 * xrdb.c: Likewise.
1848 * xselect.c: Likewise.
1849
0497dc44
PE
18502012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1851
1852 * fileio.c (time_error_value): Check the right error number.
1853 Problem reported by Troels Nielsen in
1854 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
1855
356e7178
PE
18562012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1857
4e71fd89
PE
1858 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
1859 This should be fixed in a better way; see Eli Zaretskii in
1860 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
1861 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
1862
f0941253
PE
1863 * fileio.c (time_error_value): Rename from special_mtime.
1864 The old name's problems were noted by Eli Zaretskii in
1865 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
1866
065c9eb4
PE
1867 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
1868 This variable's comment says Emacs needs at least one GDB-visible
1869 symbol of type enum pvec_type, to work around GDB problems.
1870 The symbol's value doesn't matter.
1871
356e7178
PE
1872 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
1873 that causes compilation to fail on pre-C99 compilers.
1874
ed9265fc 18752012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
1876
1877 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
1878 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
1879
3884d954
DA
18802012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1881
d209e2fb 1882 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
1883 headers for buffer_defaults and buffer_local_symbols.
1884 Reported by Juanma Barranquero <lekktu@gmail.com>.
1885
ee28be33
SM
18862012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1887
1888 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
1889 * lisp.h (enum pvec_type): Use fewer bits.
1890 (PSEUDOVECTOR_SIZE_BITS): New constant.
1891 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
1892 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
1893 change in pvec_type.
1894 (PSEUDOVECTOR_TYPEP): New macro.
1895 (TYPED_PSEUDOVECTORP): Use it.
1896 * fns.c (internal_equal): Adapt code to extract pvectype.
1897 * emacs.c (gdb_pvec_type): Update type.
1898 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
1899 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
1900 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
1901 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
1902 (sweep_vectors): Use it. Use local var `total_bytes' instead of
1903 abusing vector->header.next.nbytes.
1904 (live_vector_p): Use PVEC_TYPE.
1905 (mark_object): Adapt code to extract pvectype. Use switch.
1906
c7f2cd7f
PE
19072012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1908
1909 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
1910 Tighten new eassert a bit.
1911
8ce70ed2
DA
19122012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1913
1914 Fix compilation with --enable-gcc-warnings and -O1
1915 optimization level.
1916 * doprnt.c (doprnt): Change type of tem to int, initialize
1917 to avoid compiler warning. Add eassert.
1918 * search.c (simple_search): Initialize match_byte to avoid
1919 compiler warning. Add eassert.
1920
dea7f1e5
PE
19212012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1922
24a212eb
PE
1923 Avoid weird behavior with large horizontal scrolls.
1924 Without this change, for example, large hscroll values would
1925 mess up Emacs's display on Fedora 15 x86, presumably due to
1926 overflows in int calculations in the display code.
1927 Also, if buffers had long lines, Emacs would freeze.
1928 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
1929 (set_window_hscroll): New function, containing the old guts of
1930 Fset_window_hscroll. Return the clipped value.
1931 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
1932 This avoids the need to check against PTRDIFF_MAX.
1933
dea7f1e5
PE
1934 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
1935
76046526
DA
19362012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1937
1938 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
1939
39adff0d
PE
19402012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1941
63807d47
PE
1942 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
1943 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
1944 since GCC 4.4.6 issues a bogus warning for them.
1945
39adff0d
PE
1946 Fix bugs in file timestamp newness comparisons.
1947 * fileio.c (Ffile_newer_than_file_p):
1948 * lread.c (Fload): Use full timestamp resolution of files,
1949 not just the 1-second resolution, so that files that are only
1950 slightly newer still count as newer.
1951 * fileio.c (Ffile_newer_than_file_p): Don't assume file
1952 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
1953
dbeed9a6
PE
19542012-07-03 Paul Eggert <eggert@cs.ucla.edu>
1955
1956 * fileio.c: Improve handling of file time marker. (Bug#11852)
1957 (special_mtime): New function.
1958 (Finsert_file_contents, Fverify_visited_file_modtime):
1959 Use it to set special mtime values consistently.
1960
636334d6
AS
19612012-07-03 Andreas Schwab <schwab@linux-m68k.org>
1962
1963 * fileio.c (Finsert_file_contents): Properly handle st_mtime
1964 marker for non-existing file. (Bug#11852)
1965
e2017fe2
GM
19662012-07-03 Glenn Morris <rgm@gnu.org>
1967
1968 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
1969 and did not make it into globals.h).
1970
404dbd37
TT
19712012-07-03 Tom Tromey <tromey@redhat.com>
1972
1973 * window.c (Fset_window_margins, Fset_window_fringes)
1974 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
1975 * textprop.c (Fprevious_property_change): No longer static.
1976 * syntax.c (Fsyntax_table_p): No longer static.
1977 * process.c (Fget_process, Fprocess_datagram_address): No longer
1978 static.
1979 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
1980 * keyboard.c (Fcommand_execute): No longer static.
1981 Remove EXFUN.
1982 * insdel.c (Fcombine_after_change_execute): No longer static.
1983 * image.c (Finit_image_library): No longer static.
1984 * fileio.c (Fmake_symbolic_link): No longer static.
1985 * eval.c (Ffetch_bytecode): No longer static.
1986 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
1987 * doc.c (Fdocumentation_property, Fsnarf_documentation):
1988 No longer static.
404dbd37
TT
1989 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
1990 static.
1991 * dired.c (Ffile_attributes): No longer static.
1992 * composite.c (Fcomposition_get_gstring): No longer static.
1993 * callproc.c (Fgetenv_internal): No longer static.
1994
1995 * ccl.h: Remove EXFUNs.
1996 * buffer.h: Remove EXFUNs.
1997 * dispextern.h: Remove EXFUNs.
1998 * intervals.h: Remove EXFUNs.
1999 * fontset.h: Remove EXFUN.
2000 * font.h: Remove EXFUNs.
2001 * dosfns.c (system_process_attributes): Remove EXFUN.
2002 * keymap.h: Remove EXFUNs.
2003 * lisp.h: Remove EXFUNs.
2004 * w32term.h: Remove EXFUNs.
2005 * window.h: Remove EXFUNs.
2006 * xsettings.h: Remove EXFUN.
2007 * xterm.h: Remove EXFUN.
2008
8e4fd1e1
GM
20092012-07-03 Glenn Morris <rgm@gnu.org>
2010
2011 * lisp.h (Frandom): Make it visible to C.
2012 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
2013 buffer for invisible buffers. (Bug#1229)
2014
ca95b3eb
DA
20152012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2016
2017 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
2018 values which aren't power of 2.
2019 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
2020 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
2021 accordingly.
2022
7555c33f
SM
20232012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
2024
2025 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
2026
2027 * alloc.c (mark_object): Revert part of last patch to use `switch'.
2028
d12e8f5a
DA
20292012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2030
2031 * alloc.c (allocate_vector_block): Remove redundant
2032 calls to mallopt if DOUG_LEA_MALLOC is defined.
2033 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
2034 avoid calls to mallopt if zero_vector is returned.
2035
296094c3
DA
20362012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2037
2038 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
2039 is enabled, avoid dereferencing NULL current_sblock if
2040 running undumped.
2041
36429c89
DA
20422012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2043
2044 Cleanup basic buffer management.
2045 * buffer.h (struct buffer): Change layout to use generic vector
2046 marking code. Fix some comments. Change type of 'clip_changed'
2047 to bitfield. Remove unused #ifndef old.
2048 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
2049 (GET_OVERLAYS_AT): Fix indentation.
2050 (for_each_per_buffer_object_at): New macro.
2051 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
2052 (Fbuffer_local_variables): Use it.
2053 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
2054 * alloc.c (allocate_buffer): Adjust to match new layout of
2055 struct buffer. Fix comment.
2056 (mark_overlay): New function.
2057 (mark_buffer): Use it. Use mark_vectorlike to mark normal
2058 Lisp area of struct buffer.
2059 (mark_object): Use it. Adjust marking of misc objects
2060 and related comments.
2061
3b3e4cac
PE
20622012-07-02 Paul Eggert <eggert@cs.ucla.edu>
2063
2064 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
2065 wrapper that is not needed because the wrapped code is a no-op (zero
2066 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
2067 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
2068
cf5c0175
DA
20692012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
2070
2071 * alloc.c (mark_buffer): Simplify. Remove prototype.
2072 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 2073 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
2074 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
2075 redundant calls to mark_vectorlike for bool vectors.
2076
ca26824c
GM
20772012-06-30 Glenn Morris <rgm@gnu.org>
2078
2e4c5312
GM
2079 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
2080
ca26824c
GM
2081 * epaths.in (PATH_SITELOADSEARCH): New.
2082 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
2083 This is rather than relying on --enable-locallisppath elements
2084 having "site-lisp" in their names. (Bug#10208#25, 11658)
2085
0d23c240
EZ
20862012-06-30 Eli Zaretskii <eliz@gnu.org>
2087
c9240d7a
EZ
2088 * w32proc.c (sys_select): Accept and ignore one more argument.
2089
2090 * w32.c (emacs_gnutls_pull): Call select with one more argument.
2091
0d23c240 2092 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 2093 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
2094
2095 * sysdep.c: Don't include dos.h and dosfns.h.
2096
2097 * process.c (sys_select):
2098 * msdos.c (sys_select): Accept one more argument and ignore it.
2099
2100 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
2101 adapt data types and code to that.
2102
2103 * dosfns.c:
2104 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
2105 which clashes with the gnulib function of the same name.
2106
af5a5a98
AS
21072012-06-30 Andreas Schwab <schwab@linux-m68k.org>
2108
c5e4379c
AS
2109 * font.c (font_style_to_value, font_style_symbolic)
2110 (font_prop_validate_style): Add type checks for values in
2111 font_style_table.
2112
af5a5a98
AS
2113 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
2114 argument.
2115 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
2116 uses.
2117
8d38f461
EZ
21182012-06-29 Eli Zaretskii <eliz@gnu.org>
2119
2e5a6631
EZ
2120 * xdisp.c (try_window_id): Undo last change.
2121
8d38f461
EZ
2122 * w32.c (getwd): Adjust commentary about startup_dir.
2123 (init_environment): Always call sys_access, even in non-MSVC
2124 builds. Don't chdir to the directory of the Emacs executable.
2125 This undoes code from 1997 which was justified by the need to
2126 "avoid conflicts when removing and renaming directories". But its
2127 downside was that every relative file name was being interpreted
2128 relative to the directory of the Emacs executable, which can never
2129 be TRT. In particular, it broke sys_access when called with
2130 relative file names.
2131 (sys_access): Map GetLastError to errno.
2132
2af3565e
DA
21332012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2134
2135 * window.h (struct window): Change type of 'fringes_outside_margins'
2136 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 2137 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
2138 Adjust comment.
2139 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
2140 to ptrdiff_t.
2141
c8d3a25c 21422012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 2143
c8d3a25c
GM
2144 * gnutls.c (emacs_gnutls_handshake):
2145 Add QUIT to make the loop interruptible.
57570cd3 2146
c8d3a25c 21472012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 2148
c8d3a25c
GM
2149 * charset.c (init_charset): Make lack of etc/charsets fatal.
2150
3e984ee8
DA
21512012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2152
2153 * editfns.c (region_limit): Fix type mismatch.
2154
ef884f23
DA
21552012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2156
2157 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
2158 undefined. Convert from xassert to eassert.
2159 * nsmenu.m: Convert from xassert to eassert.
2160 * nsterm.m: Likewise.
2161
7d7e0027
SM
21622012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
2163
2164 * editfns.c (region_limit): Clip to narrowing (bug#11770).
2165
aa754e6a
PE
21662012-06-28 Paul Eggert <eggert@cs.ucla.edu>
2167
2168 Avoid integer overflow on scroll-left and scroll-right.
2169 * window.c (HSCROLL_MAX): New macro.
2170 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
2171 overflow when requested scroll falls outside ptrdiff_t range.
2172
80b00b08
DA
21732012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2174
2175 * window.h (struct window): Change type of 'hscroll',
2176 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
2177 'last_modified' and 'last_overlay_modified' to EMACS_INT.
2178 Adjust users accordingly.
2179 * xdisp.c (try_cursor_movement): Replace type check with eassert.
2180 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
2181 from EMACS_INT to ptrdiff_t.
2182 (make_window): Omit redundant initialization.
2183
62b2bcf6
JB
21842012-06-28 Juanma Barranquero <lekktu@gmail.com>
2185
2186 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
2187
45942c7d
DA
21882012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2189
2190 * window.h (struct window): Change type of 'use_time' and
2191 'sequence_number' from Lisp_Object to int.
2192 * frame.c (make_frame): Adjust users accordingly.
2193 * print.c (print_object): Likewise.
2194 * window.c (select_window, Fwindow_use_time, make_parent_window)
2195 (make_window): Likewise.
2196
e509cfa6
DA
21972012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2198
2199 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
2200 enabled with --enable-checking=[all,glyphs] configure option.
2201 Fix GLYPH_DEBUG usage assuming that it may be undefined,
2202 adjust comments accordingly.
2203 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
2204 undefined, adjust comments accordingly.
2205 * image.c: Likewise.
2206 * scroll.c: Likewise.
2207 * w32fns.c: Likewise.
2208 * w32term.c: Likewise.
2209 * xdisp.c: Likewise.
2210 * xfaces.c: Likewise.
2211 * xfns.c: Likewise.
2212 * xterm.c: Likewise.
2213
a54e2c05
DA
22142012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2215
2216 Generalize run-time debugging checks.
2217 * dispextern.h (XASSERTS): Remove.
2218 * fontset.c (xassert): Remove.
2219 Convert from xassert to eassert.
2220 * alloc.c: Convert from xassert to eassert.
2221 * bidi.c: Likewise.
2222 * dispnew.c: Likewise.
2223 * fns.c: Likewise.
2224 * fringe.c: Likewise.
2225 * ftfont.c: Likewise.
2226 * gtkutil.c: Likewise.
2227 * image.c: Likewise.
2228 * keyboard.c: Likewise.
2229 * menu.c: Likewise.
2230 * process.c: Likewise.
2231 * scroll.c: Likewise.
2232 * sound.c: Likewise.
2233 * term.c: Likewise.
2234 * w32console.c: Likewise.
2235 * w32fns.c: Likewise.
2236 * w32term.c: Likewise.
2237 * window.c: Likewise.
2238 * xdisp.c: Likewise.
2239 * xfaces.c: Likewise.
2240 * xfns.c: Likewise.
2241 * xselect.c: Likewise.
2242 * xterm.c: Likewise.
2243
1ec4b7b2
SM
22442012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
2245
2246 * fns.c (maybe_resize_hash_table): Output message when growing the
2247 purify-hashtable.
2248
2014308a
DA
22492012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2250
2251 * alloc.c (allocate_string_data): Remove dead code.
2252 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
2253 avoid GCC warning about unused macro.
2254
246155eb
DA
22552012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2256
2257 * alloc.c (allocate_string): Omit intervals initialization.
2258 * alloc.c (make_uninit_multibyte_string): Initialize intervals
2259 as in make_pure_string and make_pure_c_string.
2260
43184b7b
DA
22612012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2262
d209e2fb 2263 * alloc.c (allocate_string): Fix last change.
43184b7b 2264
3fe6dd74
DA
22652012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2266
d209e2fb 2267 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
2268 to memset, add explicit initialization where appropriate.
2269
1ba6038a
GM
22702012-06-27 Glenn Morris <rgm@gnu.org>
2271
2272 * lisp.mk (lisp): Remove paths.elc.
2273
c89926a5
CY
22742012-06-27 Chong Yidong <cyd@gnu.org>
2275
2276 * doc.c (Fsubstitute_command_keys): Fix punctuation.
2277
ed6b3510
JW
22782012-06-26 John Wiegley <johnw@newartisans.com>
2279
1ec4b7b2 2280 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
2281 on Mac OS X Lion: __mod_init_func and __mod_term_func.
2282
ed6b3510
JW
2283 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
2284 when building with Clang.
2285
8edd4a2b
SM
22862012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
2287
2288 * eval.c (Fapply): Allow calling it with a single argument.
2289
f6f62d1b
EZ
22902012-06-26 Eli Zaretskii <eliz@gnu.org>
2291
2292 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
2293 _stricmp and _strnicmp.
2294 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
2295
62efea5e
DA
22962012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2297
2298 * alloc.c (allocate_window): Zero out non-Lisp part of newly
2299 allocated window.
2300 (allocate_process): Likewise for new process.
8edd4a2b 2301 (allocate_terminal): Change to use offsetof.
62efea5e
DA
2302 (allocate_frame): Likewise.
2303 * frame.c (make_frame): Omit redundant initialization.
2304 * window.c (make_parent_window): Use memset.
2305 (make_window): Omit redundant initialization.
2306 * process.c (make_process): Omit redundant initialization.
2307 * terminal.c (create_terminal): Likewise.
2308
42997f4d
DA
23092012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2310
2311 * term.c (delete_tty): Remove redundant call to memset.
2312
1130ecfc
DA
23132012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2314
2315 * alloc.c: Remove build_string.
2316 * lisp.h: Define build_string as static inline. This provides
2317 a better opportunity to optimize away calls to strlen when the
2318 function is called with compile-time constant argument.
2319 * image.c (imagemagick_error): Convert to build_string.
2320 * w32proc.c (sys_spawnve): Likewise.
2321 * xterm.c (x_term_init): Likewise.
2322
cf38a720
PE
23232012-06-26 Paul Eggert <eggert@cs.ucla.edu>
2324
99027bdd
PE
2325 Use sprintf return value instead of invoking strlen on result.
2326 In the old days this wasn't portable, since some sprintf
2327 implementations returned char *. But they died out years ago and
2328 Emacs already assumes sprintf returns int.
2329 Similarly for float_to_string.
2330 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
2331 * ccl.c (ccl_driver):
2332 * character.c (string_escape_byte8):
2333 * data.c (Fnumber_to_string):
2334 * doprnt.c (doprnt):
2335 * print.c (print_object):
2336 * xdisp.c (message_dolog):
2337 * xfns.c (syms_of_xfns):
2338 Use sprintf or float_to_string result to avoid need to call strlen.
2339 * data.c (Fnumber_to_string):
2340 Use make_unibyte_string, since the string must be ASCII.
2341 * lisp.h, print.c (float_to_string): Now returns int length.
2342 * term.c (produce_glyphless_glyph):
2343 Use sprintf result rather than recomputing it.
2344
cf38a720
PE
2345 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
2346 * Makefile.in (ALL_CFLAGS):
2347 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
2348 * gmalloc.c, regex.c: Include <config.h> unconditionally.
2349
3511c784
DA
23502012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2351
0a08eb21 2352 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
2353 strcasecmp if available.
2354 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
2355
fb7da12e
AS
23562012-06-25 Andreas Schwab <schwab@linux-m68k.org>
2357
2358 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
2359 Avoid comma operator.
2360 * menu.c (push_submenu_start, push_submenu_end)
2361 (push_left_right_boundary, push_menu_pane): Likewise.
2362 * msdos.c (dos_rawgetc): Likewise.
2363
afa2ffd8
DA
23642012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2365
2366 * xfns.c (xic_create_fontsetname): Remove redundant calls
2367 to memset.
2368
b3b4476b
PE
23692012-06-25 Paul Eggert <eggert@cs.ucla.edu>
2370
4495ff38
PE
2371 * gtkutil.c (get_utf8_string): Remove redundant assignment.
2372 sprintf already null-terminates its output.
2373
b3b4476b
PE
2374 * xfns.c (x_window): Remove redundant cast.
2375
b00876c9
DA
23762012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2377
2378 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
2379 `const char *' to `char *' to avoid compiler warning.
2380
d188e26b
PE
23812012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2382
885d1d74
PE
2383 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
2384 instead of truncating it to 63 (admittedly a generous limit).
2385
d188e26b
PE
2386 * process.c: Fix spelling and caps in comments.
2387
e2f560b1
DN
23882012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
2389
e86db54b 2390 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
2391 * sysdep.c (setpgrp): Remove definition, not used in this file.
2392
7583a3a1
JB
23932012-06-24 Juanma Barranquero <lekktu@gmail.com>
2394
2395 * makefile.w32-in: Update dependencies.
2396
696056c2
EZ
23972012-06-24 Eli Zaretskii <eliz@gnu.org>
2398
2399 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
2400 (SYSTIME_H): Add nt/inc/sys/time.h.
2401
2402 * systime.h [WINDOWSNT]: Include sys/time.h.
2403
2404 * s/ms-w32.h (struct timespec): Definition moved from
2405 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
2406
845ca893
PE
24072012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2408
2409 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
2410 * buffer.h (buffer_slot_type_mismatch):
2411 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2412 * eval.c (unwind_to_catch):
2413 * image.c (my_png_error, my_error_exit):
2414 * keyboard.c (quit_throw_to_read_char, user_error)
2415 (Fexit_recursive_edit, Fabort_recursive_edit):
2416 * lisp.h (die, args_out_of_range, args_out_of_range_3)
2417 (wrong_type_argument, buffer_overflow, __executable_start)
2418 (memory_full, buffer_memory_full, string_overflow, Fthrow)
2419 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
2420 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
2421 (fatal):
2422 (child_setup) [!DOS_NT]:
2423 * lread.c (end_of_file_error, invalid_syntax):
2424 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2425 * puresize.h (pure_write_error):
2426 * search.c (matcher_overflow):
2427 * sound.c (sound_perror, alsa_sound_perror):
2428 * sysdep.c, syssignal.h (croak):
2429 * term.c (maybe_fatal, vfatal):
2430 * textprop.c (text_read_only):
2431 * undo.c (user_error):
2432 * unexmacosx.c (unexec_error):
2433 * xterm.c (x_ins_del_lines, x_delete_glyphs):
2434 Use _Noreturn rather than NO_RETURN.
2435 No need for separate decl merely because of _Noreturn.
2436 * sound.c (sound_warning, parse_sound):
2437 Remove unnecessary forward decls.
2438
f1dd8073
PE
24392012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2440
2441 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
2442 * lisp.h (WAIT_READING_MAX): New macro.
2443 * dispnew.c (Fsleep_for, sit_for):
2444 * keyboard.c (kbd_buffer_get_event):
2445 * process.c (Faccept_process_output):
2446 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
2447 This improves on the previous patch, which introduced a bug
2448 when time_t is unsigned and as wide as intmax_t.
2449 See <http://bugs.gnu.org/9000#51>.
2450
b82c1755
EZ
24512012-06-23 Eli Zaretskii <eliz@gnu.org>
2452
2453 * dispnew.c (sit_for, Fsleep_for):
2454 * keyboard.c (kbd_buffer_get_event):
2455 * process.c (Faccept_process_output): Avoid compiler warnings when
2456 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
2457
ca300656
JB
24582012-06-23 Juanma Barranquero <lekktu@gmail.com>
2459
049ec95b
JB
2460 * makefile.w32-in: Update dependencies.
2461
ca300656
JB
2462 * w32.c (ltime): Add return type and declare static.
2463 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
2464
db7b8d06
PE
24652012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2466
2467 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
2468 Privately reported by Herbert J. Skuhra.
2469 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
2470 All uses changed.
2471 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
2472 not make_lisp_timeval, when the argument is of type EMACS_TIME.
2473
0bd8297f
EZ
24742012-06-23 Eli Zaretskii <eliz@gnu.org>
2475
96512555
EZ
2476 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
2477 last argument of make_unibyte_string.
2478
0bd8297f
EZ
2479 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
2480 language ID in the event parameters.
2481
2482 * w32term.c (w32_read_socket): Put the new keyboard codepage into
2483 event.code, not the obscure "character set ID".
2484
63def6b6
CY
24852012-06-23 Chong Yidong <cyd@gnu.org>
2486
2487 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
2488
e8a02204
EZ
24892012-06-23 Eli Zaretskii <eliz@gnu.org>
2490
388cdec0
EZ
2491 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
2492 * w32.c (fdutimens): New function.
2493
2494 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
2495
2496 * s/ms-w32.h (pselect): Redirect to sys_select.
2497
2498 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
2499
e8a02204
EZ
2500 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
2501 in the logic of incrementing and decrementing the value of
2502 use_relocatable_buffers.
2503
d054f3fb
PE
25042012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2505
2506 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
2507 Privately reported by Herbert J. Skuhra.
2508 [__FreeBSD__]: Remove "*/" typo after "#include".
2509 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
2510 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
2511 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
2512 Don't assume EMACS_TIME and struct timeval are the same type.
2513
d35af63c
PE
25142012-06-22 Paul Eggert <eggert@cs.ucla.edu>
2515
2516 Support higher-resolution time stamps (Bug#9000).
2517 The time stamps are only nanosecond-resolution at the C level,
2518 since that's the best that any real-world system supports now.
2519 But they are picosecond-resolution at the Lisp level, as that's
2520 easy, and leaves room for future OS improvements.
2521
2522 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
2523 (LIBES): Use it.
2524
2525 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
2526 Don't get current time unless it's needed.
2527
2528 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
2529 now provides it if it's absent.
2530 (start_atimer): Port to higher-res time stamps.
2531 Check for time stamp overflow. Don't get current time more
2532 often than is needed.
2533
2534 * buffer.h (struct buffer): Buffer modtime now has high resolution.
2535 Include systime.h, not time.h.
2536 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
2537
2538 * dired.c: Include stat-time.h.
2539 (Ffile-attributes): File times now have higher resolution.
2540
2541 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
2542 (struct image): Timestamp now has higher resolution.
2543
2544 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
2545 has at least microseconds now. All uses removed.
2546 (update_frame, update_single_window, update_window, update_frame_1)
2547 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
2548
2549 * editfns.c (time_overflow): Now extern.
2550 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
2551 (float-time, Fformat_time_string, Fcurrent_time_string)
2552 (Fcurrent_time_zone): Accept and generate higher-resolution
2553 time stamps.
2554 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
2555 (decode_time_components, lisp_seconds_argument): New functions.
2556 (make_time): Now static.
2557 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
2558 Report an error if the time is invalid, rather than having the caller
2559 do that.
2560
2561 * fileio.c: Include <stat-time.h>
2562 (Fcopy_file): Copy higher-resolution time stamps.
2563 Prefer to set the time stamp via a file descriptor if that works.
2564 (Fset_file_times, Finsert_file_contents, Fwrite_region)
2565 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
2566 (Fvisited_file_modtime, Fset_visited_file_modtime):
2567 Support higher-resolution time stamps.
2568
2569 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
2570
2571 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
2572
2573 * image.c (prepare_image_for_display, clear_image_cache)
2574 (lookup_image): Port to higer-resolution time stamps.
2575
2576 * keyboard.c (start_polling, bind_polling_period):
2577 Check for time stamp overflow.
2578 (read_char, kbd_buffer_get_event, timer_start_idle)
2579 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
2580 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
2581 Port to higher-resolution time stamps. Do not assume time_t is signed.
2582 (decode_timer): New function. Timers are now vectors of length 9,
2583 not 8, to accommodate the picosecond component.
2584 (timer_check_2): Use it.
2585
2586 * nsterm.m (select_timeout, timeval_subtract): Remove.
2587 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
2588 as they're a bit more accurate and handle overflow better.
2589 (ns_select): Change prototype to be compatible with pselect.
2590 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
2591 * nsterm.h (ns_select): Adjust prototype.
2592
2593 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
2594 us-resolution time stamps.
2595 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
2596
2597 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
2598
2599 * lisp.h (time_overflow): New decl.
2600 (wait_reading_process_output): First arg is now intmax_t, not int,
2601 to accommodate larger waits.
2602
2603 * process.h (struct Lisp_Process.read_output_delay):
2604 Now counts nanoseconds, not microseconds.
2605 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
2606 EMACS_HAS_USECS.
2607 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
2608 (wait_reading_process_output):
2609 Port to ns-resolution time stamps.
2610 (Faccept_process_output, wait_reading_process_output):
2611 Check for time stamp overflow. Do not assume time_t is signed.
2612 (select_wrapper): Remove; we now use pselect.
2613 (Fprocess_attributes): Now generates ns-resolution time stamps.
2614
2615 * sysdep.c: Include utimens.h. Don't include utime.h
2616 or worry about struct utimbuf; gnulib does that for us now.
2617 (gettimeofday): Remove; gnulib provides a substitute.
2618 (make_timeval): New function.
2619 (set_file_times): Now sets ns-resolution time stamps.
2620 New arg FD; all uses changed.
2621 (time_from_jiffies, ltime_from_jiffies, get_up_time)
2622 (system_process_attributes):
2623 Now returns ns-resolution time stamp. All uses changed.
2624 Check for time stamp overflow.
2625
2626 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
2627 provides a substitute now.
2628
2629 * systime.h: Include timespec.h rather than sys/time.h and time.h,
2630 since it guarantees struct timespec.
2631 (EMACS_TIME): Now struct timespec, so that we can support
2632 ns-resolution time stamps.
2633 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
2634 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
2635 (EMACS_USECS): Remove.
2636 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
2637 so multiply the arg by 1000 before storing it.
2638 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
2639 New macros.
2640 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
2641 Port to ns-resolution time stamps.
2642 (EMACS_TIME_NEG_P): Remove; replaced by....
2643 (EMACS_TIME_SIGN): New macro.
2644 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
2645 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
2646 (set_file_times, make_time, lisp_time_argument): Adjust signature.
2647 (make_timeval, make_lisp_time, decode_time_components): New decls.
2648 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
2649 that it mishandled time_t overflow. You can't compare by subtracting!
2650 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
2651 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
2652
2653 * term.c: Include <sys/time.h>.
2654 (timeval_to_Time): New function, for proper overflow wraparound.
2655 (term_mouse_position, term_mouse_click): Use it.
2656
2657 * undo.c (record_first_change): Support higher-resolution time stamps
2658 in the undo buffer.
2659 (Fprimitive_undo): Use them when restoring time stamps.
2660
2661 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
2662 (w32_get_internal_run_time):
2663 Port to higher-resolution Emacs time stamps.
2664 (ltime): Now accepts single 64-bit integer, as that's more convenient
2665 for callers.
2666
2667 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
2668
2669 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
2670 for compatibility with pselect. Support ns-resolution time stamps.
2671
2672 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
2673
2674 * xselect.c (wait_for_property_change, x_get_foreign_selection):
2675 Check for time stamp overflow, and support ns-resolution time stamps.
2676
2677 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
2678 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
2679 (timeval_subtract): Remove; no longer needed.
2680 (XTflash, XTring_bell, x_wait_for_event):
2681 Port to ns-resolution time stamps. Don't assume time_t is signed.
2682
b6a92dfe
CY
26832012-06-22 Chong Yidong <cyd@gnu.org>
2684
2685 * xdisp.c (x_consider_frame_title): Revert last change.
2686
d251c37c
EZ
26872012-06-22 Eli Zaretskii <eliz@gnu.org>
2688
2689 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
2690 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
2691 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
2692 staticidx goes up to 1597 out of 1600 = 0x640.)
2693
f10deafb
PE
26942012-06-20 Paul Eggert <eggert@cs.ucla.edu>
2695
2696 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
2697 Otherwise, the umask might be mistakenly 0 while handling input signals.
2698
ec6de1e2
SM
26992012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
2700
2701 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
2702
28be1ada
DA
27032012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
2704
2705 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
2706 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
2707 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
2708 access to `contents' member of Lisp_Vector objects with AREF and ASET
2709 where appropriate.
2710
c6bf3022
CY
27112012-06-19 Chong Yidong <cyd@gnu.org>
2712
2713 * frame.c (delete_frame): When selecting a frame on a different
2714 text terminal, do not alter the terminal's top-frame.
2715
2716 * xdisp.c (format_mode_line_unwind_data): Record the target
2717 frame's selected window and its terminal's top-frame.
2718 (unwind_format_mode_line): Restore them.
2719 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
2720 Callers changed.
2721 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
2722 since tty frames can be explicitly named.
2723 (prepare_menu_bars): Likewise.
2724
2725 * term.c (Ftty_top_frame): New function.
2726
defd4196
PE
27272012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2728
2729 Port byte-code-meter to modern targets.
2730 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
2731 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 2732 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
2733 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
2734 (METER_1, METER_2): Simplify.
2735
1053a871
SM
27362012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
2737
2738 * data.c (Fdefalias): Return `symbol' (bug#11686).
2739
b7e8d081
MR
27402012-06-18 Martin Rudalics <rudalics@gmx.at>
2741
2742 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
2743 gets killed during executing of this function (Bug#11665).
2744 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
2745 (Vkill_buffer_query_functions): In doc-string say that functions
2746 run by this hook should not change the current buffer.
2747
7ea2b339
PE
27482012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2749
2750 Fix recently-introduced process.c problems found by static checking.
2751 * process.c (write_queue_push, write_queue_pop, send_process):
2752 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
2753 (write_queue_pop): Fix pointer signedness problem.
2754 (send_process): Remove unused local.
2755
96a313a1
CY
27562012-06-17 Chong Yidong <cyd@gnu.org>
2757
2758 * xdisp.c (redisplay_internal): No need to redisplay terminal
2759 frames that are not on top.
2760
20ca2e94
TN
27612012-06-17 Troels Nielsen <bn.troels@gmail.com>
2762
2763 * process.c (make_process): Initialize write_queue.
2764 (write_queue_push, write_queue_pop): New functions.
2765 (send_process): Use them to maintain correct ordering of process
2766 writes (Bug#10815).
2767
9a900ca9
PE
27682012-06-17 Paul Eggert <eggert@cs.ucla.edu>
2769
310fbfa8
PE
2770 * lisp.h (eassert): Assume C89 or later.
2771 This removes the need for CHECK.
2772 (CHECK): Remove. Its comments about always evaluating its
2773 argument were confusing, as 'eassert' typically does not evaluate
2774 its argument.
2775
27bb1ca4
PE
2776 * coding.c (produce_chars): Use ptrdiff_t, not int.
2777
9a900ca9
PE
2778 * xterm.c (x_draw_underwave): Check for integer overflow.
2779 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
2780
41b7f8bc 27812012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
2782
2783 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
2784 referenced (Bug#11583).
2785
9b0e3eba
AA
27862012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
2787
2788 Implement wave-style variant of underlining.
2789 * dispextern.h (face_underline_type): New enum.
2790 (face): Add field for underline type.
2791 * nsterm.m (ns_draw_underwave): New function.
2792 (ns_draw_text_decoration): Use it.
2793 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
2794 New functions.
2795 (x_draw_glyph_string): Use them.
2796 * xfaces.c (Qline, Qwave): New Lisp objects.
2797 (check_lface_attrs, merge_face_ref)
1053a871
SM
2798 (Finternal_set_lisp_face_attribute, realize_x_face):
2799 Handle wave-style underline face attributes.
9b0e3eba
AA
2800 * xterm.c (x_draw_underwave): New function.
2801 (x_draw_glyph_string): Use it.
2802
0fb52f11
JB
28032012-06-16 Juanma Barranquero <lekktu@gmail.com>
2804
2805 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
2806 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
2807 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
2808 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
2809 ($(BLD)/w32select.$(O)): Update dependencies.
2810
e5560ff7
AS
28112012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2812
2813 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
2814 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
2815 * character.c (_fetch_multibyte_char_p): Remove.
2816 * alloc.c: Include "character.h" before "buffer.h".
2817 * bidi.c: Likewise.
2818 * buffer.c: Likewise.
2819 * bytecode.c: Likewise.
2820 * callint.c: Likewise.
2821 * callproc.c: Likewise.
2822 * casefiddle.c: Likewise.
2823 * casetab.c: Likewise.
2824 * category.c: Likewise.
2825 * cmds.c: Likewise.
2826 * coding.c: Likewise.
2827 * composite.c: Likewise.
2828 * dired.c: Likewise.
2829 * dispnew.c: Likewise.
2830 * doc.c: Likewise.
2831 * dosfns.c: Likewise.
2832 * editfns.c: Likewise.
2833 * emacs.c: Likewise.
2834 * fileio.c: Likewise.
2835 * filelock.c: Likewise.
2836 * font.c: Likewise.
2837 * fontset.c: Likewise.
2838 * fringe.c: Likewise.
2839 * indent.c: Likewise.
2840 * insdel.c: Likewise.
2841 * intervals.c: Likewise.
2842 * keyboard.c: Likewise.
2843 * keymap.c: Likewise.
2844 * lread.c: Likewise.
2845 * macros.c: Likewise.
2846 * marker.c: Likewise.
2847 * minibuf.c: Likewise.
2848 * nsfns.m: Likewise.
2849 * nsmenu.m: Likewise.
2850 * print.c: Likewise.
2851 * process.c: Likewise.
2852 * regex.c: Likewise.
2853 * region-cache.c: Likewise.
2854 * search.c: Likewise.
2855 * syntax.c: Likewise.
2856 * term.c: Likewise.
2857 * textprop.c: Likewise.
2858 * undo.c: Likewise.
2859 * unexsol.c: Likewise.
2860 * w16select.c: Likewise.
2861 * w32fns.c: Likewise.
2862 * w32menu.c: Likewise.
2863 * window.c: Likewise.
2864 * xdisp.c: Likewise.
2865 * xfns.c: Likewise.
2866 * xmenu.c: Likewise.
2867 * xml.c: Likewise.
2868 * xselect.c: Likewise.
2869
2f07e6af
EZ
28702012-06-16 Eli Zaretskii <eliz@gnu.org>
2871
1053a871
SM
2872 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
2873 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 2874 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
2875 row.
2876 (handle_face_prop): Use chunk-relative overlay string index when
2877 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
2878 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
2879 the rightmost. (Bug#11720)
2f07e6af 2880
29b83cec
AS
28812012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2882
2883 * category.h (CHAR_HAS_CATEGORY): Define as inline.
2884 (CATEGORY_MEMBER): Enforce 1/0 value.
2885 * category.c (_temp_category_set): Remove.
2886
4c5501e9
EZ
28872012-06-16 Eli Zaretskii <eliz@gnu.org>
2888
2889 * window.c (Fdelete_other_windows_internal)
2890 (Fdelete_window_internal): Don't access frame's mouse highlight
2891 info of the initial frame. (Bug#11677)
2892
2b570124
PE
28932012-06-14 Paul Eggert <eggert@cs.ucla.edu>
2894
e93864f9
PE
2895 * .gdbinit (xgetint): Fix recently-introduced paren typo.
2896 Assume USE_2_TAGS_FOR_INTS.
2897 (xreload): Adjust $tagmask width to match recent lisp.h change.
2898
2b570124
PE
2899 Simplify lisp.h in minor ways that should not affect code.
2900 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
2901 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
2902 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
2903 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
2904 (INTTYPEBITS): New macro, for clarity.
2905 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
2906 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
2907 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
2908 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
2909 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
2910
81755f69
JB
29112012-06-13 Juanma Barranquero <lekktu@gmail.com>
2912
2913 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
2914
16192a57
GM
29152012-06-13 Glenn Morris <rgm@gnu.org>
2916
2917 * s/bsd-common.h (BSD4_3):
2918 * s/usg5-4-common.h (USG5_4): No longer define; unused.
2919
646b5f55
AS
29202012-06-13 Andreas Schwab <schwab@linux-m68k.org>
2921
2922 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
2923 instead of union.
2924 (XLI, XIL): Define.
1053a871
SM
2925 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
2926 Use them.
2927 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 2928 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 2929 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
2930 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
2931 * frame.c (delete_frame): Remove outdated comment.
2932 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
2933 USE_LISP_UNION_TYPE.
2934 (Fw32_unregister_hot_key): Likewise.
2935 (Fw32_toggle_lock_key): Likewise.
2936 * w32menu.c (add_menu_item): Likewise.
2937 (w32_menu_display_help): Use XIL instead of checking
2938 USE_LISP_UNION_TYPE.
2939 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
2940 (init_heap): Likewise.
2941 * w32term.c (w32_read_socket): Update comment.
2942
1d3823c9
GM
29432012-06-13 Glenn Morris <rgm@gnu.org>
2944
c62ff706
GM
2945 * s/usg5-4-common.h, src/s/unixware.h:
2946 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
2947
1d3823c9
GM
2948 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
2949
bfe3e0a2
PE
29502012-06-13 Paul Eggert <eggert@cs.ucla.edu>
2951
2952 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
2953 * alloc.c (make_number) [!defined make_number]:
2954 Remove, as lisp.h always defines this now.
2955 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
2956 (roundup_size): Verify that it is a power of 2.
2957 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
2958 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
2959 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
2960 -DUSE_LSB_TAG=0, to override the automatically-selected default.
2961 USE_LSB_TAG now is always defined to be either 0 or 1.
2962 All uses changed.
2963 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
2964 code works fine either way, and efficiency is not a concern here,
2965 as the union type is for debugging, not for production.
2966 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
2967 Use an inline function on all platforms when using the union type,
2968 since this is simpler and 'static inline' can be used portably
2969 within Emacs now.
2970 (LISP_INITIALLY_ZERO): New macro.
2971 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
2972 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
2973
45fa9c0f
GM
29742012-06-12 Glenn Morris <rgm@gnu.org>
2975
b4492cba
GM
2976 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
2977
2978 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 2979
45fa9c0f
GM
2980 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
2981 Move BROKEN_SIGIO to configure.
2982
2983 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
2984 Move NO_TERMIO to configure.
2985
0e25d334
CY
29862012-06-12 Chong Yidong <cyd@gnu.org>
2987
2988 * image.c (imagemagick_load_image): Use MagickFlattenImage if
2989 MagickMergeImageLayers is undefined. Use pixel pusher loop if
2990 MagickExportImagePixels is undefined.
2991
43682bb6
PE
29922012-06-12 Paul Eggert <eggert@cs.ucla.edu>
2993
2994 * image.c (imagemagick_load_image): Remove unused label.
2995
a9be7d2b
GM
29962012-06-11 Glenn Morris <rgm@gnu.org>
2997
2998 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
2999 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
3000 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
3001 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
3002
3017f87f
SM
30032012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
3004
3005 * alloc.c (make_byte_code): New function.
3006 (Fmake_byte_code): Use it. Don't purify here.
3007 * lread.c (read1): Use it as well to avoid extra allocation.
3008
1b9b4cf4
CY
30092012-06-11 Chong Yidong <cyd@gnu.org>
3010
3011 * image.c (imagemagick_load_image): Implement transparency.
3012
95988fcf
AS
30132012-06-10 Andreas Schwab <schwab@linux-m68k.org>
3014
3015 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
3016 account for preceding backslashes. (Bug#11663)
3017
cd4eb164
CY
30182012-06-09 Chong Yidong <cyd@gnu.org>
3019
3020 * term.c: Support italics in capable terminals (Bug#9652).
3021 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
3022 (turn_on_face): Output using TS_enter_italic_mode if available.
3023 Don't handle unused blinking and alt-charset cases.
3024 (turn_off_face): Handle italic case; discard unused tty_blinking_p
3025 and tty_alt_charset_p cases.
3026 (tty_capable_p, init_tty): Support italics.
3027
3028 * termchar.h (struct tty_display_info): Add field for italics.
3029 Remove unused blink field.
3030
3031 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
3032 Handle slant.
3033
3034 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
3035 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
3036 tty_alt_charset_p. Add tty_italic_p.
3037
ff88beb8
MA
30382012-06-09 Michael Albinus <michael.albinus@gmx.de>
3039
3040 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
3041 dbus_type_is_basic if available.
3042 (xd_extract_signed, xd_extract_unsigned): Rename from
3043 extract_signed and extract_unsigned, respectively. Adapt callers.
3044
44286096
CY
30452012-06-09 Chong Yidong <cyd@gnu.org>
3046
1682701f
CY
3047 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
3048
44286096
CY
3049 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
3050 case (Bug#9752).
3051
d86feb17
PE
30522012-06-08 Paul Eggert <eggert@cs.ucla.edu>
3053
3054 * xdisp.c (vmessage): Treat frame message as multibyte.
3055 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
3056 would generate the diagnostic "Making \302\247 buffer-local while
3057 let-bound!".
3058
d5c20fe8
EZ
30592012-06-08 Eli Zaretskii <eliz@gnu.org>
3060
3061 * dispnew.c (showing_window_margins_p): Undo last change, which
3062 was done due to an inadvertent commit.
3063 (adjust_frame_glyphs_for_frame_redisplay): Do call
3064 showing_window_margins_p.
3065
513749ee
SM
30662012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3067
3068 * eval.c (Fmake_var_non_special): New primitive.
3069 (syms_of_eval): Defsubr it.
3070 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
3071
d4a8f5c1
JB
30722012-06-08 Juanma Barranquero <lekktu@gmail.com>
3073
3074 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
3075 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
3076
8bbbc977
EZ
30772012-06-08 Eli Zaretskii <eliz@gnu.org>
3078
3079 * alloc.c (allocate_vectorlike): Fix last change.
3080
f3372c87
DA
30812012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
3082
3083 Block-based vector allocation of small vectors.
3084 * lisp.h (struct vectorlike_header): New field `nbytes',
3085 adjust comment accordingly.
3086 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
3087 to denote vector blocks. Adjust users (live_vector_p,
3088 mark_maybe_pointer, valid_lisp_object_p) accordingly.
3089 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
3090 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
3091 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
3092 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
3093 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
3094 (roundup_size): New constant.
3095 (struct vector_block): New data type.
3096 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 3097 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
3098 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
3099 (sweep_vectors): New functions.
3100 (allocate_vectorlike): Return `zero_vector' as the only vector of
3101 0 items. Allocate new vector from block if vector size is less than
3102 or equal to VBLOCK_BYTES_MAX.
3103 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
3104 (init_alloc_once): Add call to init_vectors.
3105
4f18a4ed
SM
31062012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3107
3108 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
3109
86f158bc
PE
31102012-06-07 Paul Eggert <eggert@cs.ucla.edu>
3111
3112 * doprnt.c (doprnt): Truncate multibyte char correctly.
3113 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
3114 would mishandle a string argument "Xc" if X was a multibyte
3115 character of length 2: it would truncate after X's first byte
3116 rather than including all of X.
3117
c5cfcbe0
CY
31182012-06-06 Chong Yidong <cyd@gnu.org>
3119
3120 * buffer.c (word_wrap): Doc fix.
3121
c05cf390
PE
31222012-06-04 Paul Eggert <eggert@cs.ucla.edu>
3123
3124 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
3125
0c3461de
GM
31262012-06-03 Glenn Morris <rgm@gnu.org>
3127
3128 * xdisp.c (tool-bar-style): Doc fix.
3129
c71232db
UM
31302012-06-03 Ulrich Müller <ulm@gentoo.org>
3131
3132 * Makefile.in (PAXCTL): Define.
3133 (temacs$(EXEEXT)): Disable memory randomization for the temacs
3134 binary via PaX flags if the paxctl utility is available.
3135 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
3136 Restore PaX flags to their default. (Bug#11398)
3137
383f7350
CY
31382012-06-03 Chong Yidong <cyd@gnu.org>
3139
3140 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
3141 buffer (Bug#11226).
3142
5f2c76c6
CY
31432012-06-03 Chong Yidong <cyd@gnu.org>
3144
3145 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
3146 (note_mode_line_or_margin_highlight): If there is no help echo,
3147 use mode-line-default-help-echo. Handle the case where the mouse
3148 position is past the end of the mode line string.
3149
3150 * buffer.c (buffer_local_value_1): New function, split from
3151 Fbuffer_local_value; can return Qunbound.
3152 (Fbuffer_local_value): Use it.
3153 (Vmode_line_format): Docstring tweaks.
3154
773d47f6
PE
31552012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3156
3157 * sysdep.c (system_process_attributes): Improve comment.
3158
f2d6a3df
SM
31592012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
3160
3161 * keyboard.c: Export real-this-command to Elisp.
3162 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
3163 and DEFVAR it. Update all users.
3164
63810350
PE
31652012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3166
7bd5c1f4
PE
3167 * minibuf.c (Fassoc_string): Remove duplicate declaration.
3168
63810350
PE
3169 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
3170 Convert pctcpu and pctmem to Lisp float properly.
3171 Let the compiler fold better, as 100.0/0x8000 is exact.
3172
a2821611
AS
31732012-06-02 Andreas Schwab <schwab@linux-m68k.org>
3174
3175 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
3176 cons_block.
3177
5fceba1d
PE
31782012-06-01 Paul Eggert <eggert@cs.ucla.edu>
3179
3180 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
3181
c98ff5dd
DA
31822012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
3183
3184 For a 'struct window', replace some Lisp_Object fields to
3185 bitfields where appropriate, remove unused fields.
3186 * window.h (struct window): Remove unused 'last_mark_x' and
3187 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
3188 change it's type from Lisp_Object to bitfield.
3189 Change type of 'force_start', 'optional_new_start',
3190 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
3191 fields from Lisp_Object to bitfield. Adjust users accordingly.
3192
ca34e0be
PE
31932012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3194
3195 Pacify gcc -Wdouble-precision when using Xaw.
3196 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
3197 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
3198 Use 'float' consistently, rather than 'float' in most places
3199 and 'double' in a couple of places.
3200
efc00ab1 32012012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
3202
3203 * xdisp.c (handle_stop): Detect whether we have overlay strings
3204 loaded by testing it->current.overlay_string_index to be
3205 non-negative, instead of checking whether n_overlay_strings is
3206 positive. (Bug#11587)
3207
efc00ab1 32082012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
3209
3210 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
3211
3212 * doc.c (Fsubstitute_command_keys): Doc fix.
3213
efc00ab1 32142012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
3215
3216 * search.c (search_buffer): Remove calls to
3217 r_alloc_inhibit_buffer_relocation, as it is now called by
3218 maybe_unify_char, which was the cause of relocation of buffer text
3219 in bug#11519.
3220
efc00ab1 32212012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
3222
3223 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
3224 for the duration of call to load_charset, to avoid problems with
3225 callers of maybe_unify_char that access buffer text through C
3226 pointers.
3227
3228 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
3229 decrement the inhibition flag, instead of just setting or
3230 resetting it.
3231
ba93a187
PE
32322012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3233
3234 Remove obsolete '#define static' cruft.
3235 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
3236 This #undef was "temporary" in 2000; it is no longer needed
3237 now that '#define static' has gone away.
3238 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
3239 (gray_bitmap_bits): Remove; no longer needed.
3240 All uses replaced with definiens.
3241 * xterm.c: Include "bitmaps/gray.xbm".
3242
9e4bf381
PE
32432012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3244
3245 Clean up __executable_start, monstartup when --enable-profiling.
3246 The following changes affect the code only when profiling.
3247 * dispnew.c (__executable_start): Rename from safe_bcopy.
3248 Define only on platforms that need it.
3249 * emacs.c: Include <sys/gmon.h> when profiling.
3250 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
3251 (__executable_start): Remove decl, since lisp.h does it now.
3252 (safe_bcopy): Remove decl; no longer has that name.
3253 (main): Coalesce #if into single bit of code, for simplicity.
3254 Cast pointers to uintptr_t, since standard libraries want integers
3255 and not pointers.
3256 * lisp.h (__executable_start): New decl.
3257
32d72c2f
GM
32582012-05-31 Glenn Morris <rgm@gnu.org>
3259
3260 * image.c (Fimagemagick_types): Doc fix.
3261
baac5bc7
JM
32622012-05-30 Jim Meyering <meyering@redhat.com>
3263
3264 * callproc.c (Fcall_process_region): Include directory component
3265 in mkstemp error message (Bug#11586).
3266
72cb32cf
PE
32672012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3268
3269 * alloc.c, lisp.h (make_pure_vector): Now static.
3270
61b108cc
SM
32712012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
3272
3273 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
3274 Move to byte-run.el.
3275 (Fautoload): Do the hash-doc more carefully.
3276 * data.c (Fdefalias): Purify definition, except for keymaps.
3277 (Qdefun): Move from eval.c.
3278 * lisp.h (Qdefun): Remove.
3279 * lread.c (read1): Tiny simplification.
3280
471fe23d
TN
32812012-05-29 Troels Nielsen <bn.troels@gmail.com>
3282
934f3f58 3283 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
3284 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
3285 Bug#9642, but explicitly check that the buffer the overlay would
3286 be moved to is live and rearrange lines to make sure that errors
3287 will not put the overlay in an inconsistent state.
3288 (Fdelete_overlay): Cosmetics.
3289
85d0efd1
EZ
32902012-05-28 Eli Zaretskii <eliz@gnu.org>
3291
3292 * w32term.c (my_bring_window_to_top): New function.
3293 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
3294 could be different from the original one.
3295 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
3296 (Bug#11513)
3297
3298 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
3299 by calling BringWindowToTop.
3300
3301 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
3302 (WM_EMACS_END): Increase by one.
3303
da92a98c
PE
33042012-05-28 Paul Eggert <eggert@cs.ucla.edu>
3305
3306 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
3307 This avoids undefined behavior that might cause the eassert
3308 to not catch an out-of-range value.
3309
74d1f848
JB
33102012-05-28 Juanma Barranquero <lekktu@gmail.com>
3311
3312 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
3313 Update dependencies.
3314
9e1a06fc
EZ
33152012-05-27 Eli Zaretskii <eliz@gnu.org>
3316
3317 * bidi.c (bidi_mirror_char): Fix last change.
3318
f3dd7312
AS
33192012-05-27 Andreas Schwab <schwab@linux-m68k.org>
3320
3321 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
3322 when referring to sectname field in printf format.
3323
81899c91
PE
33242012-05-27 Paul Eggert <eggert@cs.ucla.edu>
3325
57b81a9f
PE
3326 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
3327 Only r_alloc_inhibit_buffer_relocation needed to be added;
3328 the others were already declared.
3329
81899c91
PE
3330 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
3331 before checking whether it's out of range. Put the check inside
3332 eassert. See
3333 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
3334
33017faf 33352012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
3336
3337 * callproc.c (Fcall_process): Restore a line that was accidentally
3338 commented out in the 2011-02-13 change (bug#11547).
3339
33017faf 33402012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
3341
3342 * lisp.h [REL_ALLOC]: Add prototypes for external functions
3343 defined on ralloc.c.
3344
3345 * buffer.c [REL_ALLOC]: Remove prototypes of
3346 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
3347 they are now on lisp.h.
3348
3349 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
3350
3351 * search.c (search_buffer): Use it to inhibit relocation of buffer
3352 text while re_search_2 is doing its job, because re_search_2 is
3353 passed C pointers to buffer text. (Bug#11519)
3354
23415acf
EZ
3355 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
3356 Update value to 24.
3357
44e27368
EZ
3358 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
3359 state after an additional call to move_it_in_display_line_to, keep
3360 the values of it->max_ascent and it->max_descent found for the
3361 entire line.
3362 (pos_visible_p): Revert the comparison against bottom_y to what it
3363 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
3364 (Bug#11464)
3365
c1892f11
PE
33662012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3367
3368 Fix coding-related core dumps with gcc -ftrapv.
3369 The code was computing A - B, where A and B are pointers, and B is
3370 random garbage. This can lead to core dumps on platforms that
3371 have special pointer registers, and it also leads to core dumps on
3372 x86-64 when compiled with gcc -ftrapv. The fix is to compute
3373 A - B only when B is initialized properly.
3374 * coding.c (coding_set_source, coding_set_destination): Return void.
3375 (coding_change_source, coding_change_destinations): New functions,
3376 with the old behaviors of coding_set_source and coding_set_destination.
3377 All callers that need an offset changed to use these new functions.
3378
eb7afdad
GM
33792012-05-26 Glenn Morris <rgm@gnu.org>
3380
3381 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
3382
f12fdf02
EZ
33832012-05-26 Eli Zaretskii <eliz@gnu.org>
3384
53a63be6 3385 Extend mouse support on W32 text-mode console.
61b108cc
SM
3386 * xdisp.c (draw_row_with_mouse_face):
3387 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 3388
eb3f6f01 3389 * w32console.c: Include window.h.
61b108cc
SM
3390 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
3391 New functions.
eb3f6f01
EZ
3392 (initialize_w32_display): Initialize mouse-highlight data.
3393
53a63be6
EZ
3394 * w32inevt.c: Include termchar.h and window.h.
3395 (do_mouse_event): Support mouse-autoselect-window. When the mouse
3396 moves, call note_mouse_highlight. If help_echo changed, call
3397 gen_help_event to produce help-echo message in the echo area.
3398 Call clear_mouse_face if mouse_face_hidden is set in the mouse
3399 highlight info.
3400
4cfd81f6
PE
34012012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3402
3403 * lread.c (read1): Simplify slightly to avoid an overflow warning
3404 with GCC 4.7.0 on x86-64.
3405
4446092a
EZ
34062012-05-26 Eli Zaretskii <eliz@gnu.org>
3407
3408 * bidi.c (bidi_mirror_char): Revert last change: an int is
3409 definitely wide enough here.
3410
42b2a986 34112012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 3412
42b2a986 3413 Fix integer width and related bugs (Bug#9874).
eb106a49 3414 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
3415 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
3416 (string_bytes, check_sblock, allocate_string_data):
3417 (compact_small_strings, Fmake_bool_vector, make_string)
3418 (make_unibyte_string, make_multibyte_string)
3419 (make_string_from_bytes, make_specified_string)
3420 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
3421 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
3422 (mark_vectorlike):
3423 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3424 (allocate_pseudovector):
3425 Use int, not EMACS_INT, where int is wide enough.
3426 (inhibit_garbage_collection, Fgarbage_collect):
3427 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3428 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
3429 int might not be wide enough.
3430 (bidi_cache_search, bidi_cache_find, bidi_init_it)
3431 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
3432 (bidi_at_paragraph_end, bidi_find_paragraph_start)
3433 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3434 (bidi_level_of_next_char, bidi_move_to_visually_next):
3435 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3436 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
3437 (Fkill_buffer, Fset_buffer_major_mode)
3438 (advance_to_char_boundary, Fbuffer_swap_text)
3439 (Fset_buffer_multibyte, overlays_at, overlays_in)
3440 (overlay_touches_p, struct sortvec, record_overlay_string)
3441 (overlay_strings, recenter_overlay_lists)
3442 (adjust_overlays_for_insert, adjust_overlays_for_delete)
3443 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
3444 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
3445 (Foverlay_recenter, last_overlay_modification_hooks_used)
3446 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
3447 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
3448 (validate_region): Omit unnecessary test for b <= e,
3449 since that's guaranteed by the previous test.
d311d28c
PE
3450 (adjust_overlays_for_delete): Avoid pos + length overflow.
3451 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
3452 (report_overlay_modification):
3453 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3454 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
3455 Omit pointer cast, which isn't needed anyway, and doesn't work
3456 after the EMACS_INT -> ptrdiff_t change.
02481186 3457 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
3458 * buffer.h: Adjust decls to match defn changes elsewhere.
3459 (struct buffer_text, struct buffer):
3460 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3461 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
3462 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
3463 not int, to avoid needless 32-bit limit on 64-bit hosts.
3464 (exec_byte_code): Use tighter memory-full test, one that checks
3465 for alloca overflow. Don't compute the address of the object just
3466 before an array, as that's not portable. Use EMACS_INT, not
3467 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
3468 * callint.c (Fcall_interactively):
3469 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3470 * callproc.c (call_process_kill, Fcall_process):
3471 Don't assume pid_t fits into an Emacs fixnum.
3472 (call_process_cleanup, Fcall_process, child_setup):
3473 Don't assume pid_t fits into int.
3474 (call_process_cleanup, Fcall_process, delete_temp_file)
3475 (Fcall_process_region):
3476 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3477 (Fcall_process): Simplify handling of volatile integers.
3478 Use int, not EMACS_INT, where int will do.
3479 * casefiddle.c (casify_object, casify_region, operate_on_word)
3480 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
3481 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3482 (casify_object): Avoid integer overflow when overallocating buffer.
3483 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 3484 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
3485 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
3486 * category.h (CATEGORYP): Don't assume arg is nonnegative.
3487 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
3488 integers are now checked earlier. All uses replaced with XINT.
3489 (ccl_driver):
3490 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3491 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
3492 (ccl_driver, Fregister_code_conversion_map):
3493 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
3494 (resolve_symbol_ccl_program): Check that vector header is in range.
3495 Always copy the vector, so that we can check its contents reliably
3496 now rather than having to recheck each instruction as it's being
3497 executed. Check that vector words fit in 'int'.
3498 (ccl_get_compiled_code, Fregister_ccl_program)
3499 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
3500 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
3501 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
3502 contents are in range.
3503 (Fccl_execute_on_string): Check that status is in range.
3504 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
3505 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
3506 Accept and return EMACS_INT, not int, because callers can pass values
3507 out of 'int' range.
3508 (c_string_width, strwidth, lisp_string_width, chars_in_text)
3509 (multibyte_chars_in_text, parse_str_as_multibyte)
3510 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
3511 (str_as_unibyte, str_to_unibyte, string_count_byte8)
3512 (string_escape_byte8, Fget_byte):
3513 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 3514 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
3515 avoid mishandling large integers.
3516 * character.h: Adjust decls to match defn changes elsewhere.
3517 * charset.c (load_charset_map_from_file, find_charsets_in_text)
3518 (Ffind_charset_region):
3519 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3520 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
3521 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 3522 Don't assume fixnum fits in int.
d311d28c
PE
3523 (load_charset_map_from_vector, Fmap_charset_chars):
3524 Remove now-unnecessary CHECK_NATNUMs.
3525 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
3526 Don't rely on undefined behavior with signed left shift overflow.
3527 Don't assume unsigned int fits into fixnum, or that fixnum fits
3528 into unsigned int. Don't require max_code to be a valid fixnum;
3529 that's not true for gb10830 4-byte on a 32-bit host. Allow
3530 invalid_code to be a cons, for the same reason. Require code_offset
3531 to be a character. Avoid int overflow if max_char is close
3532 to INT_MAX.
3533 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
3534 this is intended anyway and avoids some undefined behavior.
3535 (load_charset_map): Pass unsigned, not int, as 2nd arg of
3536 INDEX_TO_CODE_POINT, as that's what it expects.
3537 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
3538 * charset.h (DECODE_CHAR): Return int, not unsigned;
3539 this is what was intended anyway, and it avoids undefined behavior.
3540 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
3541 integer-overflow issues.
3542 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
3543 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
3544 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
3545 * chartab.c (Fmake_char_table, Fset_char_table_range)
3546 (uniprop_get_decoder, uniprop_get_encoder):
3547 Don't assume fixnum fits in int.
3548 * cmds.c (move_point): New function, that does the gist of
3549 Fforward_char and Fbackward_char, but does so while checking
3550 for integer overflow more accurately.
c96e5d6a 3551 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
3552 (Fforward_line, Fend_of_line, internal_self_insert)
3553 (internal_self_insert):
3554 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3555 Fix a FIXME, by checking for integer overflow when calculating
3556 target_clm and actual_clm.
3557 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 3558 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
3559 (ASSURE_DESTINATION, coding_alloc_by_realloc)
3560 (coding_alloc_by_making_gap, alloc_destination)
3561 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
3562 (encode_coding_utf_16, detect_coding_emacs_mule)
3563 (decode_coding_emacs_mule, encode_coding_emacs_mule)
3564 (detect_coding_iso_2022, decode_coding_iso_2022)
3565 (encode_invocation_designation, encode_designation_at_bol)
3566 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3567 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
3568 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
3569 (encode_coding_ccl, encode_coding_raw_text)
3570 (detect_coding_charset, decode_coding_charset)
3571 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
3572 (produce_composition, produce_charset, produce_annotation)
3573 (decode_coding, handle_composition_annotation)
3574 (handle_charset_annotation, consume_chars, decode_coding_gap)
3575 (decode_coding_object, encode_coding_object, detect_coding_system)
3576 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
3577 (code_convert_region, code_convert_string)
8f50130c
PE
3578 (Fdefine_coding_system_internal)
3579 (coding_set_source, coding_set_destination):
d311d28c
PE
3580 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3581 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
3582 (Fdefine_coding_system_internal):
3583 Don't assume fixnums fit in int.
3584 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 3585 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
3586 (Funencodable_char_position, Fcheck_coding_systems_region)
3587 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 3588 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 3589 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 3590 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 3591 Don't access memory outside of the args array.
d311d28c 3592 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
3593 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
3594 result of ENCODE_CHAR.
d311d28c
PE
3595 * coding.h: Adjust decls to match defn changes elsewhere.
3596 (struct coding_system):
3597 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3598 * composite.c (get_composition_id, find_composition)
3599 (run_composition_function, update_compositions)
3600 (compose_text, composition_gstring_put_cache)
3601 (composition_gstring_p, composition_gstring_width)
3602 (fill_gstring_header, fill_gstring_body, autocmp_chars)
3603 (composition_compute_stop_pos, composition_reseat_it)
3604 (composition_update_it, struct position_record)
3605 (find_automatic_composition, composition_adjust_point)
3606 (Fcomposition_get_gstring, Ffind_composition_internal):
3607 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3608 (update_compositions):
3609 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3610 * composite.h: Adjust decls to match defn changes elsewhere.
3611 (struct composition):
3612 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3613 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
3614 Do not attempt to compute the address of the object just before a
3615 buffer; this is not portable.
3616 (Faref, Faset):
3617 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3618 (Faset): Use int, not EMACS_INT, where int is wide enough.
3619 (Fstring_to_number): Don't assume fixnums fit in int.
3620 (Frem): Don't assume arg is nonnegative.
3621 * dbusbind.c (xd_append_arg): Check for integers out of range.
3622 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 3623 (extract_signed, extract_unsigned): New functions.
243e0530
PE
3624 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
3625 (xd_get_connection_references): Return ptrdiff_t, not int.
3626 All uses changed.
3627 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
3628 (xd_read_message_1):
3629 Use int, not unsigned, where the dbus API uses int.
3630 (Fdbus_message_internal): Don't overflow mtype.
3631 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
3632 * dired.c (directory_files_internal, file_name_completion, scmp)
3633 (file_name_completion_stat):
3634 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3635 (file_name_completion): Don't overflow matchcount.
3636 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
3637 * dispextern.h: Adjust decls to match defn changes elsewhere.
3638 (struct text_pos, struct glyph, struct bidi_saved_info)
3639 (struct bidi_string_data, struct bidi_it, struct composition_it)
3640 (struct it):
3641 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3642 (struct display_pos, struct composition_it, struct it):
3643 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3644 * dispnew.c (increment_matrix_positions)
3645 (increment_row_positions, mode_line_string)
3646 (marginal_area_string):
3647 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 3648 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
3649 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3650 (duration_to_sec_usec): New function, to check for overflow better.
3651 (Fsleep_for, sit_for): Use it.
3652 * doc.c (get_doc_string, store_function_docstring):
3653 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3654 (get_doc_string, Fsnarf_documentation):
3655 Use int, not EMACS_INT, where int is wide enough.
3656 (get_doc_string):
3657 Use SAFE_ALLOCA, not alloca.
3658 Check for overflow when converting EMACS_INT to off_t.
3659 * doprnt.c (doprnt):
3660 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3661 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
3662 Don't assume uid_t fits into fixnum.
3663 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
3664 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
3665 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
3666 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
3667 (general_insert_function)
3668 (Finsert_char, make_buffer_string, make_buffer_string_both)
3669 (update_buffer_properties, Fbuffer_substring)
3670 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
3671 (Fsubst_char_in_region, check_translation)
3672 (Ftranslate_region_internal, save_restriction_restore, Fformat)
3673 (transpose_markers, Ftranspose_regions):
3674 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3675 (clip_to_bounds): Move to lisp.h as an inline function).
3676 (Fconstrain_to_field): Don't assume integers are nonnegative.
3677 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
3678 (Fsubst_char_in_region, Fsave_restriction):
3679 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3680 (Femacs_pid): Don't assume pid_t fits into fixnum.
3681 (lo_time): Use int, not EMACS_INT, when int suffices.
3682 (lisp_time_argument): Check for usec out of range.
3683 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
3684 (Fuser_login_name, Fuser_full_name): Signal an error
3685 if a uid argument is out of range, rather than relying on
3686 undefined behavior.
c8d5c857
PE
3687 (Fformat_time_string): Remove now-unnecessary check.
3688 lisp_time_argument checks for out-of-range usec now.
243e0530 3689 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
3690 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
3691 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
3692 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
3693 (init_cmdargs, Fdump_emacs):
3694 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3695 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
3696 the bottom (typically) 32 bits of the fixnum.
3697 * eval.c (specpdl_size, call_debugger):
3698 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3699 (when_entered_debugger, Fbacktrace_debug):
3700 Don't assume fixnum can fit in int.
3701 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
3702 the object just before a buffer; this is not portable.
3703 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
3704 (grow_specpdl, unbind_to):
3705 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3706 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
3707 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 3708 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
3709 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
3710 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
3711 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3712 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
3713 (a_write, e_write):
3714 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3715 (Fcopy_file, non_regular_nbytes, read_non_regular)
3716 (Finsert_file_contents):
3717 Use int, not EMACS_INT, where int is wide enough.
3718 (READ_BUF_SIZE): Verify that it fits in int.
3719 (Finsert_file_contents): Check that counts are in proper range,
3720 rather than assuming fixnums fit into ptrdiff_t etc.
3721 Don't assume fixnums fit into int.
125b3835 3722 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
3723 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
3724 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
3725 (string_char_to_byte, string_byte_to_char)
3726 (string_make_multibyte, string_to_multibyte)
3727 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
3728 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
3729 (substring_both, Fdelete, internal_equal, Ffillarray)
3730 (Fclear_string, mapcar1)
3731 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
3732 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
3733 (larger_vector, make_hash_table, maybe_resize_hash_table)
3734 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
3735 (Fmaphash, secure_hash):
3736 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3737 (concat): Check for string index and length overflow.
3738 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
3739 (Frequire):
3740 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3741 (larger_vector): New API (vec, incr_min, size_max) replaces old
3742 one (vec, new_size, init). This catches size overflow.
3743 INIT was removed because it was always Qnil.
3744 All callers changed.
3745 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
3746 the upper bound on a hash table index size.
3747 (make_hash_table, maybe_resize_hash_table): Use it.
3748 (secure_hash): Computer start_byte and end_byte only after
3749 they're known to be in ptrdiff_t range.
3750 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
3751 (Ffont_get_glyphs, Ffont_at):
3752 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3753 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
3754 (Flist_fonts, Fopen_font):
3755 Don't assume fixnum can fit in int.
3756 (check_gstring): Don't assume index can fit in int.
3757 (font_match_p): Check that fixnum is a character, not a nonnegative
3758 fixnum, since the later code needs to stuff it into an int.
3759 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
3760 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
3761 conversion overflow issues.
3762 (Fopen_font): Check for integer out of range.
3763 (Ffont_get_glyphs): Don't assume index can fit in int.
3764 * font.h: Adjust decls to match defn changes elsewhere.
3765 * fontset.c (reorder_font_vector): Redo score calculation to avoid
3766 integer overflow.
3767 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
3768 printmax_t, where ptrdiff_t is wide enough.
3769 (Finternal_char_font):
3770 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3771 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
3772 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
3773 (Fset_frame_position, x_set_frame_parameters)
3774 (x_set_line_spacing, x_set_border_width)
3775 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
3776 Check that fixnums are in proper range for system types.
3777 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
3778 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3779 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
3780 Use SAFE_ALLOCA_LISP, not alloca.
3781 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
3782 intptr_t is wide enough.
3783 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
3784 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
3785 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
3786 Check for fixnum out of range.
3787 * ftfont.c (ftfont_list): Don't assume index fits in int.
3788 Check that fixnums are in proper range for system types.
3789 (ftfont_shape_by_flt):
3790 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
3791 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3792 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3793 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
3794 Check that fixnums are in proper range for system types.
3795 * gnutls.h: Adjust decls to match defn changes elsewhere.
3796 * gtkutil.c (xg_dialog_run):
3797 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3798 (update_frame_tool_bar):
3799 Check that fixnums are in proper range for system types.
3800 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 3801 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
3802 * indent.c (last_known_column, last_known_column_point):
3803 (current_column_bol_cache):
3804 (skip_invisible, current_column, check_display_width):
3805 (check_display_width, scan_for_column, current_column_1)
3806 (Findent_to, Fcurrent_indentation, position_indentation)
3807 (indented_beyond_p, Fmove_to_column, compute_motion):
3808 (Fcompute_motion, Fvertical_motion):
3809 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3810 (last_known_column_modified): Use EMACS_INT, not int.
3811 (check_display_width):
3812 (Fcompute_motion):
3813 Check that fixnums and floats are in proper range for system types.
3814 (compute_motion): Don't assume index or fixnum fits in int.
3815 (compute_motion, Fcompute_motion):
3816 Use int, not EMACS_INT, when it is wide enough.
3817 (vmotion): Omit local var start_hpos that is always 0; that way
3818 we don't need to worry about overflow in expressions involving it.
3819 * indent.h: Adjust decls to match defn changes elsewhere.
3820 (struct position):
3821 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3822 Use int, not EMACS_INT, where int is wide enough.
3823 Remove unused members ovstring_chars_done and tab_offset;
3824 all uses removed.
3825 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
3826 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
3827 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
3828 (make_gap, copy_text, insert, insert_and_inherit)
3829 (insert_before_markers, insert_before_markers_and_inherit)
3830 (insert_1, count_combining_before, count_combining_after)
3831 (insert_1_both, insert_from_string)
3832 (insert_from_string_before_markers, insert_from_string_1)
3833 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
3834 (adjust_after_replace, adjust_after_insert, replace_range)
3835 (replace_range_2, del_range, del_range_1, del_range_byte)
3836 (del_range_both, del_range_2, modify_region)
3837 (prepare_to_modify_buffer, signal_before_change)
3838 (signal_after_change, Fcombine_after_change_execute):
3839 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3840 * intervals.c (traverse_intervals, rotate_right, rotate_left)
3841 (balance_an_interval, split_interval_right, split_interval_left)
3842 (find_interval, next_interval, update_interval)
3843 (adjust_intervals_for_insertion, delete_node, delete_interval)
3844 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3845 (static_offset_intervals, offset_intervals)
3846 (merge_interval_right, merge_interval_left, make_new_interval)
3847 (graft_intervals_into_buffer, temp_set_point_both)
3848 (temp_set_point, set_point, adjust_for_invis_intang)
3849 (set_point_both, move_if_not_intangible, get_property_and_range)
3850 (get_local_map, copy_intervals, copy_intervals_to_string)
3851 (compare_string_intervals, set_intervals_multibyte_1):
3852 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3853 * intervals.h: Adjust decls to match defn changes elsewhere.
3854 (struct interval):
3855 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3856 * keyboard.c (this_command_key_count, this_single_command_key_start)
3857 (before_command_key_count, before_command_echo_length, echo_now)
3858 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
3859 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
3860 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
3861 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
3862 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3863 (last_non_minibuf_size, last_point_position, echo_truncate)
3864 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
3865 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
3866 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
3867 (stuff_buffered_input):
3868 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3869 (last_auto_save, command_loop_1, read_char):
3870 Use EMACS_INT, not int, to avoid integer overflow.
3871 (record_char): Avoid overflow in total_keys computation.
3872 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
3873 * keyboard.h: Adjust decls to match defn changes elsewhere.
3874 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
3875 (Fkey_description, Fdescribe_vector, Flookup_key):
3876 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3877 (click_position): New function, to check that positions are in range.
3878 (Fcurrent_active_maps):
3879 (describe_command):
3880 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3881 (Faccessible_keymaps, Fkey_description):
3882 (preferred_sequence_p):
3883 Don't assume fixnum can fit into int.
3884 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
3885 Check for integer overflow in size calculations.
3886 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
3887 avoid mishandling large integers.
3888 * lisp.h: Adjust decls to match defn changes elsewhere.
3889 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
3890 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
3891 (struct Lisp_Marker):
3892 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3893 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
3894 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
3895 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
3896 All callers changed.
3897 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
3898 Assume the arg has valid form, since it always does.
3899 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
3900 unsigned integer system type.
3901 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
3902 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
3903 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3904 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
3905 (duration_to_sec_usec): New decl.
3906 * lread.c (read_from_string_index, read_from_string_index_byte)
3907 (read_from_string_limit, readchar, unreadchar, openp)
3908 (read_internal_start, read1, oblookup):
3909 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3910 (Fload, readevalloop, Feval_buffer, Feval_region):
3911 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3912 (openp): Check for out-of-range argument to 'access'.
3913 (read1): Use int, not EMACS_INT, where int is wide enough.
3914 Don't assume fixnum fits into int.
6efdadfd 3915 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
3916 (read_filtered_event): Use duration_to_sec_usec
3917 to do proper overflow checking on durations.
d311d28c
PE
3918 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
3919 in size calculation.
3920 (Fexecute_kbd_macro):
3921 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3922 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
3923 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
3924 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
3925 (set_marker_both, set_marker_restricted_both, marker_position)
3926 (marker_byte_position, Fbuffer_has_markers_at):
3927 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3928 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 3929 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
3930 It now merely ensures that the menu is large enough, without
3931 necessarily growing it, as this avoids some integer overflow issues.
3932 All callers changed.
3933 (keymap_panes, parse_single_submenu, Fx_popup_menu):
3934 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3935 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
3936 Use SAFE_ALLOCA_LISP, not alloca.
3937 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
3938 to EMACS_INT. Check that fixnums are in proper range for system types.
3939 * minibuf.c (minibuf_prompt_width, string_to_object)
3940 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
3941 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
3942 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3943 (get_minibuffer, read_minibuf_unwind):
3944 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3945 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
3946 this simplifies overflow checking. All callers changed.
3947 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
3948 (Ftest_completion):
3949 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3950 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
3951 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
3952 Check that fixnums are in proper range for system types.
3953 (Fx_create_frame, Fx_show_tip):
3954 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3955 * nsfont.m (ns_findfonts, nsfont_list_family):
3956 Don't assume fixnum fits in long.
3957 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
3958 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3959 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
3960 wide enough.
17fdb222 3961 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
3962 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3963 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
3964 (PRINTDECLARE, PRINTPREPARE):
3965 (strout, print_string):
3966 (print, print_preprocess, print_check_string_charset_prop)
3967 (print_object):
3968 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3969 (PRINTDECLARE):
3970 (temp_output_buffer_setup, Fprin1_to_string, print_object):
3971 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3972 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 3973 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 3974 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
3975 (print_error_message): Use SAFE_ALLOCA, not alloca.
3976 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
3977 (print_depth, new_backquote_output, print_number_index):
3978 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
3979 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
3980 (Fset_process_window_size, Fformat_network_address)
3981 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 3982 (sigchld_handler):
d311d28c 3983 Check that fixnums are in proper range for system types.
d44287d4 3984 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
3985 Check for process-ids out of pid_t range rather than relying on
3986 undefined behavior.
e4d81efc 3987 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
3988 (Fformat_network_address, read_process_output, send_process)
3989 (Fprocess_send_region, status_notify):
3990 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3991 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
3992 (wait_reading_process_output, read_process_output, exec_sentinel):
3993 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3994 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
3995 (Faccept_process_output): Use duration_to_sec_usec to do proper
3996 overflow checking on durations.
dde14581
PE
3997 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
3998 Don't assume pid_t fits in int.
02481186
PE
3999 * process.h (struct Lisp_Process): Members tick and update_tick
4000 are now of type EMACS_INT, not int.
b62b53e8
PE
4001 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
4002 configured --with-wide-int.
d311d28c
PE
4003 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
4004 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
4005 * search.c (looking_at_1, string_match_1):
4006 (fast_string_match, fast_c_string_match_ignore_case)
4007 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
4008 (scan_newline, find_before_next_newline, search_command)
4009 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
4010 (set_search_regs, wordify):
4011 (Freplace_match):
4012 (Fmatch_data):
4013 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4014 (string_match_1, search_buffer, set_search_regs):
4015 (Fmatch_data):
4016 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4017 (wordify): Check for overflow in size calculation.
4018 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
4019 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
4020 Check that fixnums are in proper range for system types.
4021 * sound.c (struct sound_device)
4022 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
4023 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4024 (Fplay_sound_internal):
4025 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 4026 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
4027 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
4028 (Fparse_partial_sexp):
4029 Don't assume fixnums can fit in int.
4030 (struct lisp_parse_state, find_start_pos, find_start_value)
4031 (find_start_value_byte, find_start_begv)
4032 (update_syntax_table, char_quoted, dec_bytepos)
4033 (find_defun_start, prev_char_comend_first, back_comment):
4034 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
4035 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
4036 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4037 (Finternal_describe_syntax_value): Check that match_lisp is a
4038 character, not an integer, since the code stuffs it into int.
4039 (scan_words, scan_sexps_forward):
4040 Check that fixnums are in proper range for system types.
4041 (Fforward_word):
4042 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4043 (scan_sexps_forward):
4044 Use CHARACTERP, not INTEGERP, since the value must fit into int.
4045 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
4046 * syntax.h: Adjust decls to match defn changes elsewhere.
4047 (struct gl_state_s):
4048 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
4049 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
4050 MOST_POSITIVE_FIXNUM.
d311d28c
PE
4051 * sysdep.c (wait_for_termination_1, wait_for_termination)
4052 (interruptible_wait_for_termination, mkdir):
4053 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
4054 (emacs_read, emacs_write):
4055 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
4056 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
4057 and double all fit in int.
d311d28c
PE
4058 * term.c (set_tty_color_mode):
4059 Check that fixnums are in proper range for system types.
4060 * termhooks.h (struct input_event):
4061 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4062 * textprop.c (validate_interval_range, interval_of)
4063 (Fadd_text_properties, set_text_properties_1)
4064 (Fremove_text_properties, Fremove_list_of_text_properties)
4065 (Ftext_property_any, Ftext_property_not_all)
4066 (copy_text_properties, text_property_list, extend_property_ranges)
4067 (verify_interval_modification):
4068 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4069 (Fnext_single_char_property_change)
4070 (Fprevious_single_char_property_change):
4071 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
4072 (copy_text_properties):
4073 Check for integer overflow in index calculation.
d311d28c
PE
4074 * undo.c (last_boundary_position, record_point, record_insert)
4075 (record_delete, record_marker_adjustment, record_change)
4076 (record_property_change):
4077 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4078 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
4079 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4080 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4081 (Fx_hide_tip, Fx_file_dialog):
4082 * w32menu.c (set_frame_menubar):
4083 Use ptrdiff_t, not int, for consistency with rest of code.
4084 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
4085 (select_window, Fdelete_other_windows_internal)
4086 (window_scroll_pixel_based, window_scroll_line_based)
4087 (Frecenter, Fset_window_configuration):
4088 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4089 (Fset_window_hscroll, run_window_configuration_change_hook)
4090 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 4091 (Fscroll_other_window, Frecenter):
d311d28c
PE
4092 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4093 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
4094 Don't assume fixnum fits in int.
4095 (Fset_window_scroll_bars):
4096 Check that fixnums are in proper range for system types.
4097 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
4098 (string_pos, c_string_pos, number_of_chars, init_iterator)
4099 (in_ellipses_for_invisible_text_p, init_from_display_pos)
4100 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
4101 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
4102 (face_before_or_after_it_pos, handle_invisible_prop)
4103 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
4104 (display_prop_intangible_p, string_buffer_position_lim)
4105 (string_buffer_position, handle_composition_prop, load_overlay_strings)
4106 (get_overlay_strings_1, get_overlay_strings)
4107 (iterate_out_of_display_property, forward_to_next_line_start)
4108 (back_to_previous_visible_line_start, reseat, reseat_to_string)
4109 (get_next_display_element, set_iterator_to_next)
4110 (get_visually_first_element, compute_stop_pos_backwards)
4111 (handle_stop_backwards, next_element_from_buffer)
4112 (move_it_in_display_line_to, move_it_in_display_line)
4113 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4114 (add_to_log, message_dolog, message_log_check_duplicate)
4115 (message2, message2_nolog, message3, message3_nolog
4116 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
4117 (current_message_1, truncate_echo_area, truncate_message_1)
4118 (set_message, set_message_1, store_mode_line_noprop)
4119 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
4120 (text_outside_line_unchanged_p, check_point_in_composition)
4121 (reconsider_clip_changes)
4122 (redisplay_internal, set_cursor_from_row, try_scrolling)
4123 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
4124 (redisplay_window, find_last_unchanged_at_beg_row)
4125 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
4126 (trailing_whitespace_p, find_row_edges, display_line)
4127 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
4128 (display_mode_element, store_mode_line_string)
4129 (pint2str, pint2hrstr, decode_mode_spec)
4130 (display_count_lines, display_string, draw_glyphs)
4131 (x_produce_glyphs, x_insert_glyphs)
4132 (rows_from_pos_range, mouse_face_from_buffer_pos)
4133 (fast_find_string_pos, mouse_face_from_string_pos)
4134 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4135 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4136 (safe_call, init_from_display_pos, handle_fontified_prop)
4137 (handle_single_display_spec, load_overlay_strings)
4138 (with_echo_area_buffer, setup_echo_area_for_printing)
4139 (display_echo_area, echo_area_display)
4140 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
4141 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
4142 (redisplay_window, dump_glyph_row, display_mode_line)
4143 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 4144 (handle_display_spec, display_prop_string_p):
d311d28c
PE
4145 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4146 (handle_single_display_spec, build_desired_tool_bar_string)
4147 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
4148 (get_specified_cursor_type):
4149 Check that fixnums are in proper range for system types.
4150 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
4151 (Flookup_image_map):
4152 Don't assume fixnums fit in int.
4153 (compare_overlay_entries):
4154 Avoid mishandling comparisons due to subtraction overflow.
4155 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
4156 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
4157 (handle_tool_bar_click):
4158 Use int, not unsigned, since we prefer signed and the signedness
4159 doesn't matter here.
4160 (get_next_display_element, next_element_from_display_vector):
4161 Use int, not EMACS_INT, when int is wide enough.
4162 (start_hourglass): Use duration_to_sec_usec to do proper
4163 overflow checking on durations.
4164 * xfaces.c (Fbitmap_spec_p):
4165 Check that fixnums are in proper range for system types.
4166 (compare_fonts_by_sort_order):
4167 Avoid mishandling comparisons due to subtraction overflow.
4168 (Fx_family_fonts, realize_basic_faces):
4169 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4170 (Fx_family_fonts):
4171 Don't assume fixnum fits in int.
4172 Use SAFE_ALLOCA_LISP, not alloca.
4173 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
4174 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
4175 (face_at_buffer_position, face_for_overlay_string)
4176 (face_at_string_position):
4177 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4178 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
4179 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
4180 (Fx_show_tip):
4181 Check that fixnums are in proper range for system types.
4182 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4183 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
4184 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4185 (Fx_change_window_property): Don't assume fixnums fit in int.
4186 * xfont.c (xfont_chars_supported):
4187 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4188 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
4189 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
4190 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4191 * xml.c (parse_region):
4192 * xrdb.c (magic_file_p):
4193 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4194 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
4195 (x_get_local_selection, x_reply_selection_request)
4196 (x_handle_selection_request, wait_for_property_change):
4197 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4198 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
4199 short is wide enough.
4200 (x_send_client_event): Don't assume fixnum fits in int.
4201 * xterm.c (x_x_to_emacs_modifiers):
4202 Don't assume EMACS_INT overflows nicely into int.
4203 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
4204 may come from Lisp.
4205 (handle_one_xevent): NATNUMP can eval its arg twice.
4206 (x_connection_closed):
4207 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4208 * xterm.h: Adjust decls to match defn changes elsewhere.
4209 (struct scroll_bar): Use struct vectorlike_header
4210 rather than rolling our own approximation.
4211 (SCROLL_BAR_VEC_SIZE): Remove; not used.
4212
c6574eb5
GM
42132012-05-25 Glenn Morris <rgm@gnu.org>
4214
4215 * lisp.mk (lisp): Update for more files being compiled now.
4216
e8d32c7e
SM
42172012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
4218
48def666
SM
4219 * lread.c: Remove `read_pure' which makes no difference.
4220 (read_pure): Remove var.
4221 (unreadpure): Remove function.
4222 (readevalloop): Don't call read_list with -1 flag.
4223 (read1, read_vector): Don't test read_pure any more.
4224 (read_list): Simplify.
4225
e8d32c7e
SM
4226 * fileio.c, character.h: Minor style tweaks.
4227
4b2addb7
DA
42282012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
4229
4230 * window.h (clip_changed): Remove useless declaration.
4231
584461b2
JB
42322012-05-22 Juanma Barranquero <lekktu@gmail.com>
4233
4234 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
4235 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
4236
34374650
PE
42372012-05-22 Paul Eggert <eggert@cs.ucla.edu>
4238
4239 Remove src/m/*.
4240 This directory predates autoconf and is no longer needed nowadays.
4241 Move its few remaining bits of functionality to where they're needed.
4242 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
4243 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
4244 * m/template.h: Remove.
4245 * Makefile.in (M_FILE): Remove. All uses removed.
4246 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
4247 * lisp.h (USE_LSB_TAG):
4248 * mem-limits.h (EXCEEDS_LISP_PTR):
4249 Use VAL_MAX, not VALBITS, in #if.
4250 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
4251 (EMACS_UINT): Define unconditionally now.
4252 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
4253 (BITS_PER_EMACS_INT): New constants, replacing
4254 what used to be in config.h, but not useful in #if.
4255 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
4256 define them any more.
4257 (VAL_MAX): New macro.
4258 (VALMASK): Use it.
4259 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
4260 BITS_PER_EMACS_INT, in #if.
4261 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
4262 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
4263 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
4264 * s/ms-w32.h (DATA_START):
4265 Move here from removed file m/intel386.h.
4266 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
4267 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
4268
261cb4bb
PE
42692012-05-21 Paul Eggert <eggert@cs.ucla.edu>
4270
4271 Assume C89 or later.
4272 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
4273 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
4274 (xrealloc):
4275 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
4276 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
4277 * textprop.c, tparam.c (NULL): Remove.
4278 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
4279 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
4280 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
4281 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
4282 * xterm.c (input_signal_count): Assume volatile works.
4283
ff23cd9f
KB
42842012-05-21 Ken Brown <kbrown@cornell.edu>
4285
4286 * xgselect.c (xg_select): Fix first argument in call to 'select'
4287 (bug#11508).
4288
1b170bc6
KB
42892012-05-20 Ken Brown <kbrown@cornell.edu>
4290
4291 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 4292 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 4293
b2f4d39f
KB
42942012-05-19 Ken Brown <kbrown@cornell.edu>
4295
4296 * xfns.c (x_in_use): Remove `static' qualifier.
4297 * xterm.h (x_in_use): Declare.
4298 * xgselect.c: Include xterm.h.
4299 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
4300 and `display_arg' (bug#9754).
4301
003fdae2
PE
43022012-05-19 Paul Eggert <eggert@cs.ucla.edu>
4303
9232a6d9
PE
4304 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
4305
003fdae2
PE
4306 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
4307 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
4308
784b56e2
EZ
43092012-05-18 Eli Zaretskii <eliz@gnu.org>
4310
4311 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
4312
4313 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 4314 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
4315
4316 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
4317 reference to image_cache->refcount.
4318 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
4319
a0a79cde
JL
43202012-05-17 Juri Linkov <juri@jurta.org>
4321
4322 * search.c (Fword_search_regexp, Fword_search_backward)
4323 (Fword_search_forward, Fword_search_backward_lax)
4324 (Fword_search_forward_lax): Move functions to isearch.el
4325 (bug#10145, bug#11381).
4326
b0572523
PE
43272012-05-16 Paul Eggert <eggert@cs.ucla.edu>
4328
4329 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
4330
9660f5fc
SM
43312012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
4332
4333 * lread.c (init_obarray): Declare Qt and Qnil as special.
4334
4374de83
GM
43352012-05-14 Glenn Morris <rgm@gnu.org>
4336
4337 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 4338 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 4339
dc44c39a
PE
43402012-05-14 Paul Eggert <eggert@cs.ucla.edu>
4341
078c97cb
PE
4342 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
4343
dc44c39a
PE
4344 * unexaix.c: Port to more-recent AIX compilers.
4345 (report_error, report_error_1, make_hdr, copy_sym)
4346 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
4347 Make arguments const char *, not char *, to avoid violations of C
4348 standard and to fix some AIX warnings reported by Gilles Pion.
4349
e18afed7 43502012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
4351
4352 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
4353 already have overlays loaded.
4354 (handle_single_display_spec): Before returning without displaying
4355 fringe bitmap, synchronize the bidi iterator with the main display
4356 iterator, by calling iterate_out_of_display_property.
4357 (iterate_out_of_display_property): Detect buffer iteration by
4358 testing that it->string is a Lisp string.
4359 (get_next_display_element): When the current object is exhausted,
4360 and there's something on it->stack, call set_iterator_to_next to
4361 proceed with what's on the stack, instead of returning zero.
4362 (set_iterator_to_next): If called at the end of a Lisp string,
4363 proceed to consider_string_end without incrementing string
4364 position. Don't increment display vector index past the end of
4365 the display vector. (Bug#11417)
c8fb9dc6
EZ
4366 (pos_visible_p): Don't report a position visible when move_it_to
4367 stopped at the last line of window, which happens to be scanned
4368 backwards by the bidi iteration. (Bug#11464)
ac268e67 4369
e18afed7 43702012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
4371
4372 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
4373 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
4374 are on a TTY, and thus unable to display on the fringes.
4375 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
4376 so we need to signal to the caller that this is a "replacing"
4377 display spec. This fixes display when the spec is invalid or we
4378 are on a TTY.
4379
e18afed7 43802012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
4381
4382 * unexaix.c (make_hdr): Fix typo in prototype.
4383 This bug broke the build on AIX. Problem reported by Gilles Pion.
4384
9d0a235a
MA
43852012-05-14 Michael Albinus <michael.albinus@gmx.de>
4386
4387 * keyboard.c (kbd_buffer_get_event): Read special events also in
4388 batch mode. (Bug#11415)
4389
9e6b06ed
GM
43902012-05-12 Glenn Morris <rgm@gnu.org>
4391
4392 * ns.mk: Update for ns_appbindir no longer having trailing "/".
4393
c1a1d7a3
EZ
43942012-05-12 Eli Zaretskii <eliz@gnu.org>
4395
4396 * lisp.mk (lisp): Add newcomment.elc.
4397
3fe7cdc8
GM
43982012-05-12 Glenn Morris <rgm@gnu.org>
4399
4400 * Makefile.in (MKDIR_P): New, set by configure.
4401 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
4402
53f7d2c0
PE
44032012-05-11 Paul Eggert <eggert@cs.ucla.edu>
4404
4405 Remove unused function hourglass_started.
4406 * dispextern.h (hourglass_started):
4407 * w32fns.c (hourglass_started):
4408 * xdisp.c (hourglass_started): Remove.
4409
75aafb17
JB
44102012-05-10 Juanma Barranquero <lekktu@gmail.com>
4411
4412 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
4413 Update dependencies.
4414
12959e8e
PE
44152012-05-10 Paul Eggert <eggert@cs.ucla.edu>
4416
97107e2e
PE
4417 * xgselect.c (xg_select): Put maxfds+1 into a var.
4418 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
4419
12959e8e
PE
4420 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
4421
836d29b3
DA
44222012-05-10 Dave Abrahams <dave@boostpro.com>
4423
4424 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
4425 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
4426
5cb67954
MA
44272012-05-09 Michael Albinus <michael.albinus@gmx.de>
4428
4429 * dbusbind.c (xd_registered_buses): New internal Lisp object.
4430 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
4431 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
4432 Initialize xd_registered_buses.
4433
3478ec45
PE
44342012-05-09 Paul Eggert <eggert@cs.ucla.edu>
4435
b263a6b0
PE
4436 Untag more efficiently if USE_LSB_TAG.
4437 This is based on a proposal by YAMAMOTO Mitsuharu in
4438 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
4439 For an admittedly artificial (nth 8000 longlist) benchmark on
4440 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
4441 Emacs's overall text size by 1%.
4442 * lisp.h (XUNTAG): New macro.
4443 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
4444 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
4445 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
4446 * eval.c (Fautoload):
4447 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
4448 * frame.h (XFRAME): Use XUNTAG.
4449
3478ec45
PE
4450 Port recent dbusbind.c changes to 32-bit --with-wide-int.
4451 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
4452 Remove unportable assumptions about print widths of types like
4453 dbus_uint32_t.
4454 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
4455 intptr_t when converting between pointer and integer, to avoid GCC
4456 warnings about wrong width.
4457
666b903b 44582012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
4459
4460 * w32proc.c (new_child): Force Windows to reserve only 64KB of
4461 stack for each reader_thread, instead of defaulting to 8MB
4462 determined by the linker. This avoids failures in creating
4463 subprocesses on Windows 7, see the discussion in this thread:
4464 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
4465
b120cc17
JC
44662012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
4467
4468 Fix up display of the *Minibuf-0* buffer in the mini window.
4469 * keyboard.c (read_char): Don't clear the echo area if there's no
4470 message to clear.
4471 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 4472 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 4473
9a4b36f8
MA
44742012-05-07 Michael Albinus <michael.albinus@gmx.de>
4475
4476 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
4477 batch mode.
4478
e5f9458f
CY
44792012-05-06 Chong Yidong <cyd@gnu.org>
4480
4481 * lisp.mk (lisp): Update.
4482
eceeb5fc 44832012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
4484
4485 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
4486
71873e2b
SM
44872012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
4488
4489 * data.c (PUT_ERROR): New macro.
4490 (syms_of_data): Use it. Add new error type `user-error'.
4491 * undo.c (user_error): New function.
4492 (Fprimitive_undo): Use it.
4493 * print.c (print_error_message): Adjust print style for `user-error'.
4494 * keyboard.c (user_error): New function.
4495 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
4496
ab0fa4e4
PE
44972012-05-03 Paul Eggert <eggert@cs.ucla.edu>
4498
4499 Do not limit current-time-string to years 1000..9999.
4500 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
4501 (Fcurrent_time_string): Support any year that is supported by the
4502 underlying localtime representation. Don't use asctime, as it
4503 has undefined behavior for years outside the range -999..9999.
4504
7ed806a7
PE
45052012-05-02 Paul Eggert <eggert@cs.ucla.edu>
4506
4507 Fix race conditions involving setenv, gmtime, localtime, asctime.
4508 Without this fix, interrupts could mess up code that uses these
4509 nonreentrant functions, since setting TZ invalidates existing
4510 tm_zone or tzname values, and since most of these functions return
4511 pointers to static storage.
4512 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
4513 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
4514 Grow the critical sections to include not just invoking
4515 localtime/gmtime, but also accessing these functions' results
4516 including their tm_zone values if any, and any related TZ setting.
4517 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
4518 so that the struct tm is saved in the critical section.
4519 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
4520 motivated by the fact that memory allocation needs to be outside
4521 the critical section.
4522
0c16dfed
DA
45232012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
4524
4525 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
4526 with RESET_INTERVAL.
4527
4528 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4529 Remove duplicated buffer name initialization.
4530
3f83ace8
JM
45312012-05-02 Jim Meyering <jim@meyering.net>
4532
4533 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
4534
c7b8541e
JM
4535 * xfns.c (x_window): Use xstrdup (Bug#11375).
4536
90207a15 45372012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
4538
4539 * xdisp.c (pos_visible_p): If already at a newline from the
4540 display string before the 'while' loop, don't walk back the glyphs
4541 from it3.glyph_row. Solves assertion violation when the display
4542 string begins with a newline (egg.el). (Bug#11367)
4543
b593d6a9
AH
45442012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
4545
4546 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
4547 Move to simple.el.
4548
4737362e
GM
45492012-05-01 Glenn Morris <rgm@gnu.org>
4550
99cf43f9
GM
4551 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
4552 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
4553 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
4554 All were removed before 23.1.
4555
9311dcff
GM
4556 * dispnew.c: Remove HAVE_LIBNCURSES test;
4557 it is always true on relevant platforms.
4558
4d5c6349
GM
4559 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
4560 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
4561
4737362e
GM
4562 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
4563
74dd3a6b
AS
45642012-04-30 Andreas Schwab <schwab@linux-m68k.org>
4565
4566 * .gdbinit (xpr): Remove checks for no longer existing misc types.
4567 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
4568 Remove.
4569
13c379ee
PE
45702012-04-28 Paul Eggert <eggert@cs.ucla.edu>
4571
4572 Do not avoid creating empty evaporating overlays (Bug#9642).
4573 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
4574 That is, do not delete an evaporating overlay if it becomes
4575 empty after its bounds are adjusted to fit within its buffer.
4576 This fix caused other problems, and I'm reverting it until we get
4577 to the bottom of them.
4578
a8e7d6d7 45792012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
4580
4581 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
4582
a8e7d6d7 45832012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
4584
4585 * xdisp.c (pos_visible_p): If the window start position is beyond
4586 ZV, start the display from buffer beginning. Prevents assertion
4587 violation in init_iterator when the minibuffer window is scrolled
4588 via the scroll bar.
4589
4590 * window.c (window_scroll_pixel_based): Likewise.
4591
a8e7d6d7 45922012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
4593
4594 * keymap.c (where_is_internal): Doc fix (Bug#10872).
4595
a8e7d6d7 45962012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
4597
4598 * fileio.c (Fcopy_file, Fset_file_selinux_context):
4599 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
4600
a8e7d6d7 46012012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 4602
b593d6a9
AH
4603 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
4604 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 4605
1c6900d9
EZ
46062012-04-26 Eli Zaretskii <eliz@gnu.org>
4607
4c3fa1d9
EZ
4608 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
4609 display element, check also the underlying string or buffer
4610 character. (Bug#11341)
4611
1c6900d9
EZ
4612 * w32menu.c: Include w32heap.h.
4613 (add_menu_item): If the call to AppendMenuW (via
4614 unicode_append_menu) fails, disable Unicode menus only if we are
4615 running on Windows 9X/Me.
4616
42bf8205
AS
46172012-04-24 Andreas Schwab <schwab@linux-m68k.org>
4618
4619 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
4620 (xgetint): Add missing shift for LSB tags.
4621
b1bac16e
MR
46222012-04-24 Martin Rudalics <rudalics@gmx.at>
4623
4624 * keyboard.c (read_char): Don't wipe echo area for select window
4625 events: These might get delayed via `mouse-autoselect-window'
4626 (Bug#11304).
4627
d69621cc
JB
46282012-04-24 Juanma Barranquero <lekktu@gmail.com>
4629
4630 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
4631 manipulation of :loaded-from data.
4632
02fd101b
JB
46332012-04-23 Juanma Barranquero <lekktu@gmail.com>
4634
4635 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
4636 now a cons (bug#11311).
4637
888bec30
PE
46382012-04-23 Paul Eggert <eggert@cs.ucla.edu>
4639
89a438bd
PE
4640 Do not create empty overlays with the evaporate property (Bug#9642).
4641 * buffer.c (Fmove_overlay): Delete an evaporating overlay
4642 if it becomes empty after its bounds are adjusted to fit within
4643 its buffer. Without this fix, in a nonempty buffer (let ((o
4644 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
4645 yields an empty overlay that has the evaporate property, which is
4646 not supposed to happen.
4647
1068fe4d
PE
4648 Fix minor GTK3 problems found by static checking.
4649 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4650 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4651 (struct _EmacsFixedClass, emacs_fixed_get_type):
4652 Move decls here from emacsgtkfixed.h, since they needn't be public.
4653 (emacs_fixed_get_type): Now static.
4654 (emacs_fixed_class_init): Omit unused local.
4655 (emacs_fixed_child_type): Remove; unused.
4656 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4657 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4658 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
4659 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
4660 (EMACS_FIXED_GET_CLASS): Remove; unused.
4661 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
4662
888bec30
PE
4663 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
4664 Problem reported by Juanma Barranquero for Windows -Wunused-function.
4665
de85e130
PE
46662012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4667
d0baac98 4668 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 4669 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
4670 (__malloc_size_t, __malloc_ptrdiff_t):
4671 Remove. All uses removed, replaced by the definiens if needed,
4672 since we can assume C89 or better now.
4673 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
4674 (protect_malloc_state, align, get_contiguous_space)
4675 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
4676 (malloc_atfork_handler_child, malloc_enable_thread)
4677 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
4678 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
4679 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
4680 (special_realloc, _realloc_internal_nolock, _realloc_internal)
4681 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
4682 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
4683 Define using prototypes, not old style.
4684 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
4685 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
4686 (align): Don't assume that signed integer overflow wraps around.
4687 Omit unused local var.
4688 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
4689 (_free_internal_nolock, memalign, mallochook, reallochook):
4690 Omit no-longer-needed casts.
4691 (valloc): Use getpagesize, not __getpagesize.
4692 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
4693 (struct hdr): The 'magic' member is now size_t, not unsigned long.
4694
de85e130
PE
4695 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
4696
dcbf5805
MA
46972012-04-22 Michael Albinus <michael.albinus@gmx.de>
4698
4699 Move functions from C to Lisp. Make non-blocking method calls
4700 the default. Implement further D-Bus standard interfaces.
4701
4702 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
4703 (QCdbus_request_name_allow_replacement)
4704 (QCdbus_request_name_replace_existing)
4705 (QCdbus_request_name_do_not_queue)
4706 (QCdbus_request_name_reply_primary_owner)
4707 (QCdbus_request_name_reply_in_queue)
4708 (QCdbus_request_name_reply_exists)
4709 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
4710 (QCdbus_registered_serial, QCdbus_registered_method)
4711 (QCdbus_registered_signal): New Lisp objects.
4712 (XD_DEBUG_MESSAGE): Use sizeof.
4713 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
4714 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
4715 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
4716 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
4717 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
4718 (xd_signature, xd_append_arg): Allow float for integer types.
4719 (xd_get_connection_references): New function.
b593d6a9
AH
4720 (xd_get_connection_address): Rename from xd_initialize.
4721 Return cached address.
dcbf5805
MA
4722 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
4723 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
4724 level.
4725 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 4726 Return number of refcounts.
dcbf5805
MA
4727 (Fdbus_get_unique_name): Make stronger parameter check.
4728 (Fdbus_message_internal): New defun.
4729 (Fdbus_call_method, Fdbus_call_method_asynchronously)
4730 (Fdbus_method_return_internal, Fdbus_method_error_internal)
4731 (Fdbus_send_signal, Fdbus_register_service)
4732 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
4733 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
4734 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
4735 (Vdbus_compiled_version, Vdbus_runtime_version)
4736 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
4737 (Vdbus_message_type_method_return, Vdbus_message_type_error)
4738 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
4739 (Vdbus_registered_buses, Vdbus_registered_objects_table):
4740 Adapt docstring.
dcbf5805 4741
52828e02
PE
47422012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4743
da05bc4c
PE
4744 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
4745 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
4746 Do not assume ptrdiff_t is the same width as 'int'.
4747
52828e02
PE
4748 * alloc.c: Handle unusual debugging option combinations.
4749 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
4750 since the two debugging options are incompatible.
4751 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
4752 is defined.
4753 (mem_init, mem_insert, mem_insert_fixup):
4754 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
4755 (NEED_MEM_INSERT): Remove; no longer needed.
4756
f01769f9
LL
47572012-04-22 Leo Liu <sdl.web@gmail.com>
4758
4759 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
4760
5790543d
PE
47612012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4762
4763 * sysdep.c [__FreeBSD__]: Minor cleanups.
4764 (list_system_processes, system_process_attributes) [__FreeBSD__]:
4765 Use Emacs indenting style more consistently. Avoid some casts.
4766 Use 'double' consistently rather than mixing 'float' and 'double'.
4767
b91b7e4d
EW
47682012-04-21 Eduard Wiebe <usenet@pusto.de>
4769
b593d6a9
AH
4770 * sysdep.c (list_system_processes, system_process_attributes):
4771 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 4772
6114eb15
AS
47732012-04-21 Andreas Schwab <schwab@linux-m68k.org>
4774
4775 * lisp.mk (lisp): Update.
4776
2f38dff7
PE
47772012-04-20 Paul Eggert <eggert@cs.ucla.edu>
4778
4779 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
4780 It is never used otherwise.
4781
4ae29f89
SM
47822012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
4783
4784 * print.c (print_preprocess): Only check print_depth if print-circle
4785 is nil.
4786 (print_object): Check for cycles even when print-circle is nil and
4787 print-gensym is t, but only check print_depth if print-circle is nil.
4788
f30d612a
CY
47892012-04-20 Chong Yidong <cyd@gnu.org>
4790
4791 * process.c (wait_reading_process_output): If EIO occurs on a pty,
4792 set the status to "failed" and ensure that sentinel is run.
4793
c07a4c0b 47942012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
4795
4796 * process.c (Fset_process_inherit_coding_system_flag)
4797 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 4798 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 4799
c07a4c0b 48002012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
4801
4802 * xdisp.c (string_buffer_position_lim): Limit starting position to
4803 BEGV.
4804 (set_cursor_from_row): If called for a mode-line or header-line
4805 row, return zero immediately.
4806 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
4807 farther than the first row after the header line, if any.
4808 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
4809 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
4810
c07a4c0b 48112012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 4812
4ae29f89
SM
4813 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
4814 (bug#11238).
ad3a2b41 4815
c07a4c0b 48162012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 48172012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
4818
4819 configure: new option --enable-gcc-warnings (Bug#11207)
4820 * Makefile.in (C_WARNINGS_SWITCH): Remove.
4821 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
4822 (ALL_CFLAGS): Use new macros rather than old.
4823 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
4824 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
4825 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
4826 -Wunused-result, -Wunused-variable. This should go away once
4827 the Emacs and Gnulib regex code is merged.
4828 (xmalloc, xrealloc): Now static.
4829
aba027e8
PE
48302012-04-17 Paul Eggert <eggert@cs.ucla.edu>
4831
4832 * dired.c (Fsystem_groups): Remove unused local.
4833
e5a36063
GM
48342012-04-17 Glenn Morris <rgm@gnu.org>
4835
4836 * dired.c (Fsystem_users): Doc fix.
4837
316411f0
DA
48382012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
4839
4840 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
4841 (syms_of_dired): Add them.
4842
9426aba4
PE
48432012-04-16 Paul Eggert <eggert@cs.ucla.edu>
4844
b62a57be
PE
4845 Fix minor alloc.c problems found by static checking.
4846 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
4847 New extern decls, to avoid calling undeclared functions.
4848 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
4849 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
4850 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
4851 (NEED_MEM_INSERT): New macro.
4852 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 4853 Remove one incorrect comment and fix another.
b62a57be 4854
3539f31f
PE
4855 Fix minor ralloc.c problems found by static checking.
4856 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4857 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
4858 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
4859 (r_alloc_sbrk): Now static.
4860
a041960a
PE
4861 Improve ralloc.c interface checking.
4862 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4863 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
4864 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
4865 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
4866 [REL_ALLOC]: ... to here, to check interface.
4867 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
4868 Remove decls. This fixes an "It stinks!".
4869
9426aba4
PE
4870 * alloc.c (which_symbols): Fix alignment issue / type clash.
4871
d55c12ed
AS
48722012-04-15 Andreas Schwab <schwab@linux-m68k.org>
4873
4874 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
4875 (struct Lisp_Misc_Any): Likewise.
4876 (struct Lisp_Free): Likewise.
4877 * alloc.c (union aligned_Lisp_Symbol): Define.
4878 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
4879 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
4880 (union aligned_Lisp_Misc): Define.
4881 (MARKER_BLOCK_SIZE, struct marker_block): Use union
4882 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 4883 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 4884
b948ce8b
PE
48852012-04-14 Paul Eggert <eggert@cs.ucla.edu>
4886
4887 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
4888 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
4889 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
4890 * s/netbsd.h, s/sol2-6.h:
4891 Remove definition of GC_MARK_STACK, since the default now works.
4892 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
4893 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
4894 no longer the default.
4895 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
4896
35dc09a1 48972012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 4898
35dc09a1
GM
4899 * lread.c (lisp_file_lexically_bound_p):
4900 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 4901
35dc09a1
GM
49022012-04-14 Eli Zaretskii <eliz@gnu.org>
4903
4904 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
4905 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
4906
49072012-04-14 Jan Djärv <jan.h.d@swipnet.se>
4908
4909 * nsterm.m (constrainFrameRect): Always constrain when there is only
4910 one screen (Bug#10962).
4911
bcd86815
KB
49122012-04-13 Ken Brown <kbrown@cornell.edu>
4913
4914 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
4915
c25df26e
RT
49162012-04-13 Reuben Thomas <rrt@sc3d.org>
4917
4918 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
4919
0fc59f1e
DC
49202012-04-11 Daniel Colascione <dancol@dancol.org>
4921
4922 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
4923 against is gone. It's better to use vfork now so that when Cygwin
4924 gains a new, working vfork, we use it automatically (bug#10398).
4925
de8c03dc
SM
49262012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4927
4928 * window.c (save_window_save): Obey window-point-insertion-type.
4929
2f097256
GM
49302012-04-11 Glenn Morris <rgm@gnu.org>
4931
4932 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
4933
453b951e
SM
49342012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4935
4936 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
4937
75f1671a 49382012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
4939
4940 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
4941 (force_quit_count): New var.
4942 (handle_interrupt): Use it.
4943
2a8ce227
JB
49442012-04-10 Juanma Barranquero <lekktu@gmail.com>
4945
4946 * w32.c (w32_delayed_load): Record the full path of the library
4947 being loaded (bug#10424).
4948
935396c0
GM
49492012-04-09 Glenn Morris <rgm@gnu.org>
4950
05920a43
GM
4951 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
4952 not just in the obarray, before snarfing them. (Bug#11036)
4953
935396c0
GM
4954 * Makefile.in ($(leimdir)/leim-list.el):
4955 Pass EMACS rather than BUILT_EMACS.
4956
a18ecafa
TZ
49572012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
4958
4959 * process.c (make_process):
4960 * process.h: Add integer `gnutls_handshakes_tried' member to
4961 process struct.
4962
6bbef4e5
JC
4963 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
4964 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
4965
4966 * gnutls.c (gnutls_log_function2i): Convenience log function.
4967 (emacs_gnutls_read): Use new log functions,
4968 `gnutls_handshakes_tried' process member, and
4969 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
4970 attempts per process (connection).
4971
b4d3bc10
CY
49722012-04-09 Chong Yidong <cyd@gnu.org>
4973
4974 * eval.c (Fuser_variable_p, user_variable_p_eh)
4975 (lisp_indirect_variable): Functions deleted.
4976 (Fdefvar): Caller changed.
4977
4978 * callint.c (Finteractive, Fcall_interactively):
4979 * minibuf.c (Fread_variable): Callers changed.
4980
70f4d973
EZ
49812012-04-09 Eli Zaretskii <eliz@gnu.org>
4982
4983 * xdisp.c (set_cursor_from_row): If the display string appears in
4984 the buffer at position that is closer to point than the position
4985 after the display string, display the cursor on the first glyph of
4986 the display string. Fixes cursor display when a 'display' text
4987 property immediately follows invisible text. (Bug#11094)
4988
cb3c2e3e
PE
49892012-04-09 Paul Eggert <eggert@cs.ucla.edu>
4990
4991 composite.c: use 'double' consistently
4992 * composite.c (get_composition_id): Use 'double' consistently
4993 instead of converting 'float' to 'double' and vice versa; this is
4994 easier to understand and avoids a GCC warning.
4995
fd06db5d
GM
49962012-04-09 Glenn Morris <rgm@gnu.org>
4997
50fe702a
GM
4998 * Makefile.in: Generate leim-list with bootstrap-emacs, in
4999 preparation for dumping it with emacs. (Bug#4789)
5000 (leimdir): New variable.
5001 ($(leimdir)/leim-list.el): New rule.
5002 (emacs$(EXEEXT)): Depend on leim-list.el.
5003
fd06db5d
GM
5004 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
5005 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
5006 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
5007
55c131ee
AS
50082012-04-08 Andreas Schwab <schwab@linux-m68k.org>
5009
5010 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
5011 proper alignment.
5012
9209588f
JB
50132012-04-07 Juanma Barranquero <lekktu@gmail.com>
5014
5015 * xml.c (init_libxml2_functions) [WINDOWSNT]:
5016 Remove unused local variable.
5017
e3fb2efb
PE
50182012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5019
5020 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
5021 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
5022 (mark_memory): Mark Lisp_Objects only if pointers might hide in
5023 objects, as mark_maybe_pointer will catch them otherwise.
5024 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
5025 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
5026
b5385551
PE
50272012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5028
5029 Fix typo that broke non-Windows builds.
5030 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
5031
9078ead6
EZ
50322012-04-07 Eli Zaretskii <eliz@gnu.org>
5033
5034 Support building on MS-Windows with libxml2.
5035
5036 * makefile.w32-in (OBJ2): Add xml.$(O).
5037 (GLOBAL_SOURCES): Add xml.c.
5038 ($(BLD)/xml.$(O)): New dependency list.
5039
5040 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
5041 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
5042 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
5043 [!WINDOWSNT]: New macros.
5044 (init_libxml2_functions, libxml2_loaded_p): New functions.
5045 (parse_region): Call fn_xmlCheckVersion instead of using the macro
5046 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
5047 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
5048 Calls xmlCleanupParser only if libxml2 was loaded (or statically
5049 linked in).
6bbef4e5
JC
5050 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
5051 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
5052 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
5053
5054 * emacs.c: Don't include libxml/parser.h.
5055 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
5056 xmlCleanupParser directly.
5057
5058 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
5059
3811fdf3
EZ
50602012-04-07 Eli Zaretskii <eliz@gnu.org>
5061
5062 * indent.c (Fvertical_motion): If there is a display string at
5063 point, use it.vpos to compute how many lines to backtrack after
5064 move_it_to point. (Bug#11133)
5065
2f8e16b2
EZ
50662012-04-06 Eli Zaretskii <eliz@gnu.org>
5067
5068 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
5069 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
5070 about subtle differences between FETCH_CHAR* and STRING_CHAR*
5071 macros related to unification of CJK characters. For the details,
5072 see the discussion following the message here:
5073 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
5074
3d439cd1
CY
50752012-04-04 Chong Yidong <cyd@gnu.org>
5076
5077 * keyboard.c (Vdelayed_warnings_list): Doc fix.
5078
8bc53d00
EZ
50792012-04-01 Eli Zaretskii <eliz@gnu.org>
5080
5081 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
5082 instead of alloca. (Bug#11138)
5083
3b0512a3
AS
50842012-04-01 Andreas Schwab <schwab@linux-m68k.org>
5085
5086 * w32menu.c (is_simple_dialog): Properly check lisp types.
5087 (Bug#11141)
5088
8427ddd2
EZ
50892012-03-31 Eli Zaretskii <eliz@gnu.org>
5090
979022ef
EZ
5091 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
5092 position we get to after a call to move_it_to fails the
5093 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
5094 only if we wind up in a string from display property. (Bug#11063)
5095
a6b1c7cc
EZ
5096 * window.c (Fdelete_other_windows_internal): Invalidate the row
5097 and column information about mouse highlight, so that redisplay
5098 restores it after reallocating the glyph matrices. (Bug#7464)
5099
8427ddd2
EZ
5100 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
5101 string comes from a `display' text property, use the buffer
5102 position of that property as if we actually saw that position in
5103 the row's glyphs.
697ba24b
EZ
5104 (move_it_by_lines): Remove the assertion that
5105 "it->current_x == 0 && it->hpos == 0" which can be legitimately
5106 violated when there's a before-string at the beginning of a line.
5107 (Bug#11063)
8427ddd2 5108
65a0a738
EZ
51092012-03-30 Eli Zaretskii <eliz@gnu.org>
5110
5111 * xdisp.c (append_space_for_newline): If the default face was
5112 remapped, use the remapped face for the appended newline.
5113 (extend_face_to_end_of_line): Use the remapped default face for
5114 extending the face to the end of the line.
5115 (display_line): Call extend_face_to_end_of_line when the default
5116 face was remapped. (Bug#11068)
5117
581355cc
EZ
51182012-03-29 Eli Zaretskii <eliz@gnu.org>
5119
5120 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
5121
e8fc049f
SM
51222012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5123
5124 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
5125
4fb9a543
GM
51262012-03-27 Glenn Morris <rgm@gnu.org>
5127
5128 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
5129 Doc fixes.
5130
679910f1
KH
51312012-03-26 Kenichi Handa <handa@m17n.org>
5132
5133 * dispextern.h (struct glyph): Fix previous change. Change the
5134 bit length of glyphless.ch to 25 (Bug#11082).
5135
90d49b7f
CY
51362012-03-26 Chong Yidong <cyd@gnu.org>
5137
5138 * keyboard.c (Vselection_inhibit_update_commands): New variable.
5139 (command_loop_1): Use it; inhibit selection update for
5140 handle-select-window too (Bug#8996).
5141
f514f6f0
FP
51422012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
5143
e8fc049f 5144 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 5145
bf43fa51
KH
51462012-03-25 Kenichi Handa <handa@m17n.org>
5147
5148 * dispextern.h (struct glyph): Change the bit length of
5149 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
5150
8a0c01dd
EZ
51512012-03-24 Eli Zaretskii <eliz@gnu.org>
5152
5153 * s/ms-w32.h (tzname): Include time.h before redirecting to
5154 _tzname. Fixes the MSVC build. (Bug#9960)
5155
7d1c3a76
AS
51562012-03-24 Andreas Schwab <schwab@linux-m68k.org>
5157
8ed79523
AS
5158 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
5159 characters.
5160
7d1c3a76
AS
5161 * xterm.c (XTread_socket): Only modify handling_signal if
5162 !SYNC_INPUT. (Bug#11080)
5163
e99a9b8b
EZ
51642012-03-23 Eli Zaretskii <eliz@gnu.org>
5165
5166 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
5167 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
5168 when fetching a multibyte character consumes more bytes than
5169 CHAR_BYTES returns, due to unification of CJK characters in
5170 string_char. (Bug#11073)
5171
5063c0e1
TN
51722012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
5173
5174 * process.c (wait_reading_process_output): Handle pty disconnect
5175 by refraining from sending oneself a SIGCHLD (bug#10933).
5176
9f851fbd
CY
51772012-03-22 Chong Yidong <cyd@gnu.org>
5178
5179 * dispextern.h (struct it): New member string_from_prefix_prop_p.
5180
5063c0e1 5181 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
5182 Mark string as coming from a prefix property.
5183 (handle_face_prop): Use default face for prefix strings (Bug#4281).
5184 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
5185
fb5b8aca
CY
51862012-03-21 Chong Yidong <cyd@gnu.org>
5187
5188 * xfaces.c (Vface_remapping_alist): Doc fix.
5189
62356a1b
EZ
51902012-03-20 Eli Zaretskii <eliz@gnu.org>
5191
5192 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
5193 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
5194 Doc fixes.
62356a1b 5195
025de85b
CY
51962012-03-20 Chong Yidong <cyd@gnu.org>
5197
5198 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
5199 to reflect default non-nil value of redisplay-dont-pause.
5200
4827f94e
KH
52012012-03-19 Kenichi Handa <handa@m17n.org>
5202
5203 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
5204 it fit in a valid range (Bug#11003).
5205
e50a24a2
EZ
52062012-03-18 Eli Zaretskii <eliz@gnu.org>
5207
5208 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
5209 that is not from display property, accept the row as a "cursor
5210 row" if one of the string's character has a non-nil `cursor'
5211 property. Fixes cursor positioning when there are newlines in
5212 overlay strings, e.g. in icomplete.el. (Bug#11035)
5213
9af5ed87
PE
52142012-03-12 Paul Eggert <eggert@cs.ucla.edu>
5215
5216 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
5217
d1f55f16
CY
52182012-03-12 Chong Yidong <cyd@gnu.org>
5219
5220 * eval.c (inhibit_lisp_code): Rename from
5221 inhibit_window_configuration_change_hook; move from window.c.
5222
5223 * xfns.c (unwind_create_frame_1, Fx_create_frame):
5224 * window.c (run_window_configuration_change_hook)
5225 (syms_of_window): Callers changed.
5226
66c5eebd
CY
52272012-03-11 Chong Yidong <cyd@gnu.org>
5228
413df973
CY
5229 * keymap.c (Fkey_description): Doc fix (Bug#9700).
5230
66c5eebd
CY
5231 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
5232
1de11f56
CY
52332012-03-10 Chong Yidong <cyd@gnu.org>
5234
5235 * frame.c (other_visible_frames): Don't assume the selected frame
5236 is visible (Bug#10955).
5237
cae07000
SM
52382012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
5239
5240 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
5241
89c94350
JD
52422012-03-08 Jan Djärv <jan.h.d@swipnet.se>
5243
5244 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
5245 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
5246 zero (Bug#10954).
5247
999dd333
GM
52482012-03-03 Glenn Morris <rgm@gnu.org>
5249
01a6dcc8 5250 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 5251
de0100f2
EZ
52522012-03-02 Eli Zaretskii <eliz@gnu.org>
5253
5254 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
5255 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
5256 (redisplay_window, next_element_from_string): Fix typos in
5257 comments.
3e441275
EZ
5258 (redisplay_window): Pass to move_it_vertically the margin in
5259 pixels, not in screen lines.
de0100f2 5260
96a72ee9
GM
52612012-03-02 Glenn Morris <rgm@gnu.org>
5262
5263 * buffer.c (buffer-list-update-hook): Doc fix.
5264
312508d7
EZ
52652012-02-29 Eli Zaretskii <eliz@gnu.org>
5266
5267 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
5268 push_it before setting up the iterator for the first overlay
5269 string, even if we have an empty string loaded.
5270 (next_overlay_string): If there's an empty string on the iterator
5271 stack, pop the stack. (Bug#10903)
5272
27f3c637
PE
52732012-02-25 Paul Eggert <eggert@cs.ucla.edu>
5274
5275 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
5276 Suggested by Stefan Monnier in
5277 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
5278 * alloc.c (widen_to_Lisp_Object): New static function.
5279 (mark_memory): Also mark Lisp_Objects by fetching pointer words
5280 and widening them to Lisp_Objects. This would work even if
5281 USE_LSB_TAG is defined and wide integers are used, which might
5282 happen in a future version of Emacs.
5283
3c9dfce6
CY
52842012-02-25 Chong Yidong <cyd@gnu.org>
5285
fa74b241
CY
5286 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
5287 Doc fix.
5288
3c9dfce6
CY
5289 * xselect.c (Fx_selection_exists_p): Doc fix.
5290 (x_clipboard_manager_save_all): Print an informative message
5291 before saving to clipboard manager.
5292
9486df08
CY
52932012-02-24 Chong Yidong <cyd@gnu.org>
5294
5295 * keyboard.c (process_special_events): Handle all X selection
5296 requests in kbd_buffer, not just the next one (Bug#8869).
5297
f01d3321
CY
52982012-02-23 Chong Yidong <cyd@gnu.org>
5299
5300 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
5301 call when setting menu-bar-lines and tool-bar-lines parameters.
5302 (unwind_create_frame_1): New helper function.
5303
5304 * window.c (inhibit_window_configuration_change_hook): New var.
5305 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 5306 (syms_of_window): Initialize it.
f01d3321 5307
86b847b6
CY
53082012-02-22 Chong Yidong <cyd@gnu.org>
5309
5310 * xterm.c (x_draw_image_relief): Add missing type check for
5311 Vtool_bar_button_margin (Bug#10743).
5312
a59225b1
CY
53132012-02-21 Chong Yidong <cyd@gnu.org>
5314
5315 * fileio.c (Vfile_name_handler_alist): Doc fix.
5316
5317 * buffer.c (Fget_file_buffer): Protect against invalid file
5318 handler return value.
5319
310f5bd4
PE
53202012-02-20 Paul Eggert <eggert@cs.ucla.edu>
5321
cb3a28cc
PE
5322 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
5323 when computing $valmask.
5324
310f5bd4
PE
5325 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
5326 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
5327 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
5328 It's useless in that case, and it can cause problems on hosts
5329 that allocate halves of EMACS_INT values separately.
5330 Reported by Dan Horák. Diagnosed by Andreas Schwab in
5331 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
5332 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
5333 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
5334 it avoids undefined behavior on hosts where shifting right by more
5335 than the word width has undefined behavior.
5336
2375c96a
CY
53372012-02-19 Chong Yidong <cyd@gnu.org>
5338
5339 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
5340 (Funhandled_file_name_directory, Ffile_name_as_directory)
5341 (Fdirectory_file_name, Fexpand_file_name)
5342 (Fsubstitute_in_file_name): Protect against invalid file handler
5343 return values (Bug#10845).
5344
3eb49e71
EZ
53452012-02-18 Eli Zaretskii <eliz@gnu.org>
5346
5347 * .gdbinit (pitx): Fix incorrect references to fields of the
5348 iterator stack.
5349
7b926f3f
CY
53502012-02-17 Chong Yidong <cyd@gnu.org>
5351
5352 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
5353
11273115
PE
53542012-02-15 Paul Eggert <eggert@cs.ucla.edu>
5355
5356 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
5357 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
5358
c3a70e2b
CY
53592012-02-15 Chong Yidong <cyd@gnu.org>
5360
5361 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
5362 marked as special. Also, starting docstrings with * is obsolete.
5363
0ca43699
AS
53642012-02-13 Andreas Schwab <schwab@linux-m68k.org>
5365
5366 * gnutls.c (emacs_gnutls_write): Fix last change.
5367
2e8f3c56
LI
53682012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
5369
5370 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
5371 send_process.
5372
af70074f
SM
53732012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
5374
5375 * keymap.c (Fsingle_key_description): Handle char ranges.
5376
95986d52
CY
53772012-02-12 Chong Yidong <cyd@gnu.org>
5378
afd83bd1
CY
5379 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
5380 as that creates a dangerous corner case.
5381
95986d52
CY
5382 * window.c (Fdelete_window_internal): Invalidate the mouse
5383 highlight (Bug#9904).
5384
bd7da63e
GM
53852012-02-12 Glenn Morris <rgm@gnu.org>
5386
5387 * xselect.c (Fx_own_selection_internal)
5388 (Fx_get_selection_internal, Fx_disown_selection_internal)
5389 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
5390 * nsselect.m (Fx_own_selection_internal)
5391 (Fx_disown_selection_internal, Fx_selection_exists_p)
5392 (Fx_selection_owner_p, Fx_get_selection_internal):
5393 Sync docs and argument specs with the xselect.c versions.
5394
77abcbc2
LI
53952012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
5396
5397 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
5398
90b671e2
EZ
53992012-02-11 Eli Zaretskii <eliz@gnu.org>
5400
1c0ca0b7
EZ
5401 * w32select.c (Fx_selection_exists_p): Sync doc string and
5402 argument list with xselect.c. (Bug#10783)
5403
5404 * w16select.c (Fx_selection_exists_p): Sync doc string and
5405 argument list with xselect.c. (Bug#10783)
90b671e2 5406
49241268
GM
54072012-02-10 Glenn Morris <rgm@gnu.org>
5408
5409 * fns.c (Fsecure_hash): Doc fix.
5410
f998bbe7 54112012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
5412
5413 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
5414
0992bd9c
CY
54152012-02-07 Chong Yidong <cyd@gnu.org>
5416
5417 * buffer.c (Fbuffer_local_variables)
5418 (buffer_lisp_local_variables): Handle unbound vars correctly;
5419 don't let Qunbound leak into Lisp.
5420
af008560
GM
54212012-02-07 Glenn Morris <rgm@gnu.org>
5422
dd605cc4
GM
5423 * image.c (Fimagemagick_types): Doc fix.
5424
af008560
GM
5425 * image.c (imagemagick-render-type): Change it from a lisp object
5426 to an integer. Move the doc here from the lisp manual.
5427 Treat all values not equal to 0 the same.
5428
1449fa1d
CY
54292012-02-06 Chong Yidong <cyd@gnu.org>
5430
5431 * doc.c (store_function_docstring): Avoid applying docstring of
5432 alias to base function (Bug#2603).
5433
3723ec07
AS
54342012-02-04 Andreas Schwab <schwab@linux-m68k.org>
5435
5436 * .gdbinit (pp1, pv1): Remove redundant defines.
5437 (pr): Use pp.
5438
79c1cc1e
CY
54392012-02-04 Chong Yidong <cyd@gnu.org>
5440
5441 * nsterm.m: Declare a global (Bug#10694).
5442
d7f29f8e
EZ
54432012-02-04 Eli Zaretskii <eliz@gnu.org>
5444
cae07000
SM
5445 * w32.c (get_emacs_configuration_options):
5446 Include --enable-checking, if specified, in the return value.
d7f29f8e 5447
3b95a6f9
MR
54482012-02-04 Martin Rudalics <rudalics@gmx.at>
5449
5450 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
5451 after rounding frame sizes. (Bug#9723)
5452
d6fa96a6
EZ
54532012-02-04 Eli Zaretskii <eliz@gnu.org>
5454
5455 * keyboard.c (adjust_point_for_property): Don't position point
5456 before BEGV. (Bug#10696)
5457
df0b2940
PE
54582012-02-03 Paul Eggert <eggert@cs.ucla.edu>
5459
5460 Handle overflow when computing char display width (Bug#9496).
5461 * character.c (char_width): Return EMACS_INT, not int.
5462 (char_width, c_string_width): Check for overflow when
5463 computing the width; this is possible now that individual
5464 characters can have unbounded width. Problem introduced
5465 by merge from Emacs 23 on 2012-01-19.
5466
6bee44d6
MA
54672012-02-02 Michael Albinus <michael.albinus@gmx.de>
5468
5469 * dbusbind.c (Fdbus_register_method): Mention the return value
5470 :ignore in the docstring.
5471
44f92739
GM
54722012-02-02 Glenn Morris <rgm@gnu.org>
5473
1b9f60cc
GM
5474 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
5475
44f92739
GM
5476 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5477 Unconditionally set to t. (Bug#10673)
5478 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5479 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
5480 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
5481
c5d3843c
KH
54822012-02-02 Kenichi Handa <handa@m17n.org>
5483
5484 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
5485 0, do not call append_composite_glyph.
5486
159462d4 54872012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
5488
5489 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
5490 NULL (Bug#6988).
5491 (x_produce_glyphs): If the component of a composition is a null
5492 string, set it->pixel_width to 1 to avoid zero-width glyph.
5493
78cef877
EZ
54942012-02-01 Eli Zaretskii <eliz@gnu.org>
5495
5496 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
5497 first 2 arguments are identical. This makes inserting large
5498 output from a subprocess an order of magnitude faster on
5499 MS-Windows, where all sbrk'ed memory is always contiguous.
5500
97897668
GM
55012012-01-31 Glenn Morris <rgm@gnu.org>
5502
5503 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 5504 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
5505 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
5506
31fd3586
GM
55072012-01-29 Glenn Morris <rgm@gnu.org>
5508
5509 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
5510
0e24a8b2
CY
55112012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
5512
5513 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
5514
cc0adcb0
CY
55152012-01-28 Chong Yidong <cyd@gnu.org>
5516
5517 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
5518
acc28cb9
CY
55192012-01-26 Chong Yidong <cyd@gnu.org>
5520
9c69cfb7
CY
5521 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
5522
acc28cb9
CY
5523 * search.c (Fsearch_forward, Fsearch_backward): Document negative
5524 repeat counts (Bug#10507).
5525
48da7392
GM
55262012-01-26 Glenn Morris <rgm@gnu.org>
5527
5528 * lread.c (syms_of_lread): Doc fix.
5529
14af5f7f
CY
55302012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
5531
5532 * coding.c (encode_designation_at_bol): Change return value to
5533 EMACS_INT.
5534
0b21c100
CY
55352012-01-25 Chong Yidong <cyd@gnu.org>
5536
5537 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
5538
3c2907f7
CY
55392012-01-21 Chong Yidong <cyd@gnu.org>
5540
5541 * floatfns.c (Fcopysign): Make the second argument non-optional,
5542 since nil is not allowed anyway.
5543
959ad23f
AS
55442012-01-21 Andreas Schwab <schwab@linux-m68k.org>
5545
5546 * process.c (read_process_output): Use p instead of XPROCESS (proc).
5547 (send_process): Likewise.
5548
34a02f46
MR
55492012-01-19 Martin Rudalics <rudalics@gmx.at>
5550
5551 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
5552 (Vwindow_persistent_parameters): Do not use Qstate.
5553 Rewrite doc-strings.
34a02f46 5554
1259009a 55552012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
5556
5557 * character.c (char_width): New function.
70d4fdf6
GM
5558 (Fchar_width, c_string_width, lisp_string_width):
5559 Use char_width (Bug#9496).
25ed9e61 5560
6a6ee00d
MR
55612012-01-16 Martin Rudalics <rudalics@gmx.at>
5562
5563 * window.c (Vwindow_persistent_parameters): New variable.
5564 (Fset_window_configuration, save_window_save): Handle persistent
5565 window parameters.
5566
c85efaf7
EZ
55672012-01-14 Eli Zaretskii <eliz@gnu.org>
5568
5569 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
5570 thrashing the stack of the thread. (Bug#9087)
5571
5944709e
PE
55722012-01-12 Paul Eggert <eggert@cs.ucla.edu>
5573
5574 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
5575
e71f5d99
EZ
55762012-01-11 Eli Zaretskii <eliz@gnu.org>
5577
5578 * xdisp.c (rows_from_pos_range): Handle the case where the
5579 highlight ends on a newline. (Bug#10464)
5580 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
5581 he end column for display of highlight that ends on a newline
5582 before a R2L line.
5583
ce316182
GM
55842012-01-11 Glenn Morris <rgm@gnu.org>
5585
5586 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
5587 from load-path also when installation-directory is nil. (Bug#10208)
5588
5b43da69
GM
55892012-01-10 Glenn Morris <rgm@gnu.org>
5590
74cc8ff9
GM
5591 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
5592
7d8d6e4e
GM
5593 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
5594 Update template values to be closer to their typical values these days.
5b43da69 5595
a0db8d43
EZ
55962012-01-09 Eli Zaretskii <eliz@gnu.org>
5597
5598 * xdisp.c (rows_from_pos_range): Accept additional argument
5599 DISP_STRING, and accept any glyph in a row whose object is that
5600 string as eligible for mouse highlight. Fixes mouse highlight of
5601 display strings from overlays. (Bug#10464)
5602
9a0115ab 56032012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 5604
b9110d6a 5605 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
5606 * fileio.c (auto_saving_dir_umask): New static var.
5607 (Fmake_directory_internal): Use it.
5608 (do_auto_save_make_dir): Set it, instead of invoking chmod after
5609 creating the directory. The old code temporarily assigns
5610 too-generous permissions to the directory.
5611 (do_auto_save_eh): Clear it.
b9110d6a 5612 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
5613 that the var is always cleared.
5614
6c1bd3f3
EZ
56152012-01-07 Eli Zaretskii <eliz@gnu.org>
5616
5617 * search.c (scan_buffer): Pass character positions to
5618 know_region_cache, not byte positions. (Bug#6540)
5619
069d2b50
L
56202012-01-07 LynX <_LynX@bk.ru> (tiny change)
5621
5622 * w32.c (sys_rename): Report EXDEV when rename of a directory
5623 fails because the target is on another logical disk. (Bug#10284)
5624
75bf0d33
DB
56252012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
5626
5627 * xterm.c (x_embed_request_focus): New function.
5628
5629 * xterm.h: Add prototype.
5630
5631 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
5632
1c6e5a32
GM
56332012-01-05 Glenn Morris <rgm@gnu.org>
5634
5635 * emacs.c (emacs_copyright): Update short copyright year to 2012.
5636
651e947e
EZ
56372012-01-01 Eli Zaretskii <eliz@gnu.org>
5638
5639 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
5640 Load gnutls_transport_set_lowat only if GnuTLS version is below
5641 2.11.1.
5642 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
5643 GnuTLS versions below 2.11.1.
5644
3778cdd8
AL
56452011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
5646
5647 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
5648 to the doc string advising against its use for altering the way
5649 windows are scrolled.
5650
0e5317f7
KH
56512011-12-28 Kenichi Handa <handa@m17n.org>
5652
5653 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
5654 coding-system ASCII compatible only when it does not produce BOM
5655 on encoding (Bug#10383).
5656
93d5ca1f
JD
56572011-12-26 Jan Djärv <jan.h.d@swipnet.se>
5658
5659 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
5660 can scroll.
5661 (create_and_show_popup_menu): Always use menu_position_func for
5662 Gtk3 (Bug#10361).
5663
ca22b785
AS
56642011-12-24 Andreas Schwab <schwab@linux-m68k.org>
5665
5666 * callint.c (Fcall_interactively): Don't truncate prompt string.
5667
d048e1e6
EZ
56682011-12-23 Eli Zaretskii <eliz@gnu.org>
5669
5670 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
5671 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 5672 resumed from there (after widening). (Bug#10360)
d048e1e6 5673
5ccaba1f
JD
56742011-12-22 Jan Djärv <jan.h.d@swipnet.se>
5675
5676 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
5677
204ee57f
JD
56782011-12-21 Jan Djärv <jan.h.d@swipnet.se>
5679
b81d40f0
JB
5680 * nsterm.m (x_free_frame_resources):
5681 Release f->output_data.ns->miniimage.
204ee57f
JD
5682 (ns_index_color): Fix indentation. Do not retain
5683 color_table->colors[i].
5684
5685 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
5686 before returning.
5687
5688 * nsfns.m (x_set_background_color): Assign return value from
5689 ns_index_color to face-background instead of NSColor*.
5690 (ns_implicitly_set_icon_type): Fix indentation.
5691 Change assignment in for loop to comparison.
5692
5693 * emacs.c (ns_pool): New variable.
5694 (main): Assign ns_pool.
5695 (Fkill_emacs): Call ns_release_autorelease_pool.
5696
5697 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
5698 autorelease fdesc, release fdAttrs and tdict.
5699 (ns_get_covering_families): Release charset.
5700 (ns_findfonts): Release NSFontDescriptor created with new.
5701 (ns_uni_to_glyphs): Fix indentation.
5702 (setString): Release attrStr before assigning new value.
5703
c803b2b7
JD
57042011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5705
678f4426
JD
5706 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
5707 and NS_IMPL_COCOA.
5708 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
5709 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
5710
cd394be1 57112011-12-18 David Reitter <reitter@cmu.edu>
678f4426 5712
5fecd5fc
JD
5713 * nsterm.m (ns_term_init): Subscribe for notifications
5714 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
5715 to method trackingNotification in EmacsMenu.
5716
5717 * nsmenu.m (trackingMenu): New variable.
3771cb17 5718 (trackingNotification): New method (from Aquamacs).
5fecd5fc 5719 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 5720 from Aquamacs (Bug#7030).
678f4426
JD
5721
57222011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 5723
c803b2b7
JD
5724 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
5725 (symbol_to_nsstring): Fix indentation.
5726 (ns_symbol_to_pb): New function.
cae07000
SM
5727 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
5728 (Fns_rotate_cut_buffers_internal): Remove.
5729 (Fns_store_selection_internal): Rename from
c803b2b7
JD
5730 Fns_store_cut_buffer_internal.
5731 (ns_get_foreign_selection, Fx_own_selection_internal)
5732 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
5733 (Fns_get_selection_internal, Fns_store_selection_internal):
5734 Use ns_symbol_to_pb and check if return value is nil.
5735 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
5736 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
5737 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
5738 renamed to Sns_store_selection_internal.
5739 (ns_handle_selection_request): Move code to Fx_own_selection_internal
5740 and remove this function.
5741 (ns_handle_selection_clear): Remove, never used.
5742 (Fx_own_selection_internal): Move code from ns_handle_selection_request
5743 here.
5744
e1b01a3a
KB
57452011-12-17 Ken Brown <kbrown@cornell.edu>
5746
5747 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
5748 GID is unknown (Bug#10257).
5749
2adb6e85
PE
57502011-12-17 Paul Eggert <eggert@cs.ucla.edu>
5751
5752 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
5753 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
5754 which caused a build failure on GNU/Linux IA-64. This problem was
5755 introduced by my 2011-10-07 patch.
5756
d1d7b339
JL
57572011-12-15 Juri Linkov <juri@jurta.org>
5758
5759 * image.c (imagemagick_error): New function. (Bug#10112)
5760 (imagemagick_load_image): Comment out `MagickSetResolution' call.
5761 Use `imagemagick_error' where ImageMagick functions return
5762 `MagickFalse'.
5763 (Fimagemagick_types): Add `Fnreverse' to return the list in the
5764 proper order.
5765
100d5755
KH
57662011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5767
5768 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
5769 fill background (Bug#8992).
5770
454592a6
MR
57712011-12-13 Martin Rudalics <rudalics@gmx.at>
5772
5773 * window.c (Vwindow_combination_resize)
5774 (Vwindow_combination_limit): Use t instead of non-nil in
5775 doc-strings.
61d4b438
MR
5776 (Vrecenter_redisplay): Add first sentence of doc-string on
5777 separate line.
53524d93 5778 (Frecenter): Fix doc-string typo.
454592a6 5779
3633e3aa
KH
57802011-12-11 Kenichi Handa <handa@m17n.org>
5781
5782 * coding.c (Funencodable_char_position): Pay attention to the
5783 buffer text relocation (Bug#9389).
5784
7b9d523a 57852011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 5786
7b9d523a
JD
5787 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
5788 gtk_init (Bug#10100).
5789
b73189c6
EZ
57902011-12-10 Eli Zaretskii <eliz@gnu.org>
5791
5792 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
5793 IT->string is nil. (Bug#10263)
5794
f7dfe5d6
JD
57952011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5796
83faebb4
JD
5797 * nsterm.h (x_free_frame_resources): Declare.
5798
f7dfe5d6
JD
5799 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
5800 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
5801
5802 * nsterm.h (ns_get_defaults_value): Declare.
5803
5804 * nsterm.m (ns_default): Call ns_get_defaults_value.
5805
7cd4e72c
EZ
58062011-12-09 Eli Zaretskii <eliz@gnu.org>
5807
5808 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
5809 (Bug#10170)
5810
b34d7317
YM
58112011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5812
5813 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
5814 that where the value of an _OBJC_* symbol points to is in the .bss
5815 section (Bug#10240).
5816
76470ad1
KH
58172011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5818
5819 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 5820 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 5821
745fff94
KH
58222011-12-08 Kenichi Handa <handa@m17n.org>
5823
5824 * ftfont.c (get_adstyle_property): Fix previous change
5825 (Bug#10233).
5826
6e44397c
JB
58272011-12-07 Juanma Barranquero <lekktu@gmail.com>
5828
5829 * w32.c (init_environment): If no_site_lisp, remove site-lisp
5830 dirs from the default value of EMACSLOADPATH (bug#10208).
5831
7efa6272
GM
58322011-12-07 Glenn Morris <rgm@gnu.org>
5833
5834 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
5835 installation and source directories as well. (Bug#10208)
5836
f6fc4d87
CY
58372011-12-06 Chong Yidong <cyd@gnu.org>
5838
5839 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
5840
2bf26180
GM
58412011-12-06 Glenn Morris <rgm@gnu.org>
5842
5843 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
5844 as an error, not just -1. (Bug#10217)
5845
3a6ad4f0
CY
58462011-12-05 Chong Yidong <cyd@gnu.org>
5847
5848 * keyboard.c (process_special_events): New function.
5849 (swallow_events, Finput_pending_p): Use it (Bug#10195).
5850
75a3b399
PE
58512011-12-05 Paul Eggert <eggert@cs.ucla.edu>
5852
5853 * coding.c (encode_designation_at_bol): Don't use uninitialized
5854 local variable (Bug#9318).
5855
c3c9e25e
KH
58562011-12-05 Kenichi Handa <handa@m17n.org>
5857
5858 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
5859 return Qnil (Bug#8046, Bug#10193).
5860
5eb05ea3
KH
58612011-12-05 Kenichi Handa <handa@m17n.org>
5862
5863 * coding.c (encode_designation_at_bol): New args charbuf_end and
5864 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
5865 (coding_set_source): Return how many bytes coding->source was
5866 relocated.
5867 (coding_set_destination): Return how many bytes
5868 coding->destination was relocated.
5869 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 5870 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
5871
58722011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5873
5874 * coding.c (CODING_CHAR_CHARSET_P): New macro.
5875 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
5876 macro (Bug#9318).
5877
58782011-12-05 Andreas Schwab <schwab@linux-m68k.org>
5879
5880 The following changes are to fix Bug#9318.
5881
a79703f5 5882 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
5883 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
5884 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 5885 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 5886
7dbda6df
JB
58872011-12-05 Juanma Barranquero <lekktu@gmail.com>
5888
5889 * lisp.h (process_quit_flag): Fix external declaration.
5890
6d5eb5b0
SM
58912011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
5892
5893 Don't macro-inline non-performance-critical code.
5894 * eval.c (process_quit_flag): New function.
5895 * lisp.h (QUIT): Use it.
5896
a0c3fad0
JD
58972011-12-04 Jan Djärv <jan.h.d@swipnet.se>
5898
5899 * nsfns.m (get_geometry_from_preferences): New function.
5900 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
5901
6c07aac2
AS
59022011-12-04 Andreas Schwab <schwab@linux-m68k.org>
5903
5904 * emacs.c (Qkill_emacs): Define.
5905 (syms_of_emacs): Initialize it.
5906 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
5907 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
5908 (quit_throw_to_read_char): Add parameter `from_signal'.
5909 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
5910 * lisp.h (QUIT): Call Fkill_emacs if requested.
5911
c052ead4
JD
59122011-12-03 Jan Djärv <jan.h.d@swipnet.se>
5913
5914 * widget.c (update_wm_hints): Return if wmshell is null.
5915 (widget_update_wm_size_hints): New function.
5916
5917 * widget.h (widget_update_wm_size_hints): Declare.
5918
5919 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
5920 widget_update_wm_size_hints (Bug#10104).
5921
9e49252b
EZ
59222011-12-03 Eli Zaretskii <eliz@gnu.org>
5923
5924 * xdisp.c (handle_invisible_prop): If the invisible text ends just
5925 before a newline, prepare the bidi iterator for consuming the
5926 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 5927 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 5928
02b16839
JL
59292011-12-02 Juri Linkov <juri@jurta.org>
5930
5931 * search.c (Fword_search_regexp): New Lisp function created from
5932 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
5933 (Fword_search_backward, Fword_search_forward)
5934 (Fword_search_backward_lax, Fword_search_forward_lax):
5935 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
5936 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
5937
0068070e
SM
59382011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
5939
5940 * fileio.c (Finsert_file_contents): Move after-change-function call
5941 to before the "handled:" label, since all "goto handled" appear in
5942 cases where the *-change-functions have already been properly called
5943 (bug#10117).
5944
3360a3fc
AS
59452011-12-01 Andreas Schwab <schwab@linux-m68k.org>
5946
5947 * keyboard.c (interrupt_signal): Don't call kill-emacs when
5948 waiting for input. (Bug#10169)
5949
73d6c093
EZ
59502011-11-30 Eli Zaretskii <eliz@gnu.org>
5951
5952 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
5953 verifies glyph row's hash code--we have just reallocated the
5954 glyphs, so their contents can be complete garbage. (Bug#10164)
5955
febe6bea
JB
59562011-11-30 Juanma Barranquero <lekktu@gmail.com>
5957
5958 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
5959
801a4313
EZ
59602011-11-30 Eli Zaretskii <eliz@gnu.org>
5961
5962 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
5963 attributes are tested _before_ calling verify_row_hash, to protect
5964 against GCC re-ordering of the tests. (Bug#10164)
5965
2b56b87e
JD
59662011-11-29 Jan Djärv <jan.h.d@swipnet.se>
5967
5968 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
5969
5970 * xterm.c (handle_one_xevent): Only set async_visible and friends
5971 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 5972 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
5973 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
5974
dbf31225
PE
59752011-11-28 Paul Eggert <eggert@cs.ucla.edu>
5976
5977 Remove GCPRO-related macros that exist only to avoid shadowing locals.
5978 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
5979 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
5980 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5981 All uses changed to use GCPRO1 etc.
5982 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
5983 Revert to old implementation (i.e., before 2011-03-11).
5984
1305621b
YM
59852011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5986
5987 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
5988 of scroll runs so as to avoid assigning disabled bogus rows and
5989 unnecessary graphics copy operations.
5990
8c9afb46
EZ
59912011-11-27 Eli Zaretskii <eliz@gnu.org>
5992
5993 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
5994 (snprintf) [_MSC_VER]: Redirect to _snprintf.
5995 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
5996 (malloc, free, realloc, calloc): Redirect to e_* only when
5997 compiling Emacs.
5998
5999 * lisp.h (GCTYPEBITS): Move before first use.
6000 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
6001 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
6002 this macro definition.
6003
6004 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
6005 _MSC_VER.
6006
54e9e3bf
JD
60072011-11-27 Jan Djärv <jan.h.d@swipnet.se>
6008
6d5eb5b0
SM
6009 * gtkutil.c (xg_create_frame_widgets):
6010 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
6011 present with Gtk+ 2.0.
6012
83aca1cb
PE
60132011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6014
6015 * fileio.c (Finsert_file_contents): Undo previous change; see
6016 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6017
5b76caa4
PE
60182011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6019
6020 Rename locals to avoid shadowing.
6021 * fileio.c (Finsert_file_contents):
6022 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
6023 * process.c (wait_reading_process_output):
6024 Rename inner 'proc' to 'p' to avoid shadowing.
6025 Indent for consistency with usual Emacs style.
6026
8c535114
EZ
60272011-11-25 Eli Zaretskii <eliz@gnu.org>
6028
6029 * xdisp.c (redisplay_window): If cursor row is not fully visible
6030 after recentering, and scroll-conservatively is set to a large
6031 number, scroll window by a few more lines to make the cursor fully
6032 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
6033 (start_display): Don't move to the next line if the display should
6034 start at a newline that is part of a display vector or an overlay
6035 string. (Bug#10119)
8c535114 6036
fa4fdb5c
JL
60372011-11-24 Juri Linkov <juri@jurta.org>
6038
6039 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
6040 after the `MagickPingImage' call. (Bug#10112)
6041
90ec88df
CY
60422011-11-23 Chong Yidong <cyd@gnu.org>
6043
6044 * window.c (Fcoordinates_in_window_p): Accept only live windows.
6045
56e2e794
MR
60462011-11-23 Martin Rudalics <rudalics@gmx.at>
6047
6048 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
6049 making another buffer current. (Bug#10114)
6050
b6e64c41
GM
60512011-11-23 Glenn Morris <rgm@gnu.org>
6052
6053 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
6054
6b21de18
CY
60552011-11-23 Chong Yidong <cyd@gnu.org>
6056
6057 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
6058 using it (Bug#5984).
6059
b12cd789
EZ
60602011-11-22 Eli Zaretskii <eliz@gnu.org>
6061
6062 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
6063 and header-lines, as they don't have one computed for them.
6064 (Bug#10098)
6065
6066 * .gdbinit (prow): Make displayed values more self-explaining.
6067 Add row's hash code.
6068
261b6fd4
LMI
60692011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
6070
6071 * process.c (wait_reading_process_output): Fix asynchrounous
6072 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 6073 (wait_reading_process_output): Add comment and URL.
261b6fd4 6074
e7cfd277
JD
60752011-11-21 Jan Djärv <jan.h.d@swipnet.se>
6076
6077 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
6078
a9b9b7f5
CY
60792011-11-21 Chong Yidong <cyd@gnu.org>
6080
6081 * window.c (Fnext_window, Fprevious_window): Doc fix.
6082
b0d15b4f
SM
60832011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6084
6085 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
6086
fe7a3057
JB
60872011-11-20 Juanma Barranquero <lekktu@gmail.com>
6088
6089 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
6090
d2999b1a
MR
60912011-11-20 Martin Rudalics <rudalics@gmx.at>
6092
6093 * window.c (Fset_window_combination_limit): Rename argument
6094 STATUS to LIMIT.
6095 (Vwindow_combination_limit): Remove "status" from doc-string.
6096
d5ff9cd0
AS
60972011-11-20 Andreas Schwab <schwab@linux-m68k.org>
6098
6099 * m/ibms390.h: Remove.
6100 * m/ibms390x.h: Don't include "ibms390.h".
6101
a5bb9bd3
SM
61022011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6103
6104 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
6105 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
6106
cd1181db
JB
61072011-11-20 Juanma Barranquero <lekktu@gmail.com>
6108
6109 * casetab.c (Fset_case_table):
6110 * charset.c (Fcharset_after): Fix typos.
6111
615a3b8d 61122011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 6113
17e845af
PE
6114 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
6115 Otherwise, valgrind does not work on some platforms.
6116 Problem reported by Andreas Schwab in
6a0bf43d
PE
6117 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
6118 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
6119 is set, removing the need for VIRT_ADDRESS_VARIES.
6120 (PURE_P): Use a more-efficient implementation that needs just one
6121 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
6122 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
6123 to 4 (xorl, subq, cmpq, setbe).
6124 * alloc.c (pure): Always extern now, since that's the
6125 VIRT_ADDR_VARIES behavior.
6126 (PURE_POINTER_P): Use a single comparison, not two, for
6127 consistency with the new puresize.h.
6128 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
6129 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
6130 Remove VIRT_ADDR_VARIES no longer needed.
6131
f8fe6f96
EZ
61322011-11-19 Eli Zaretskii <eliz@gnu.org>
6133
6134 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
6135 (erase_phys_cursor, update_window_cursor, show_mouse_face)
6136 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
6137 behave as if the cursor position were at the window margin.
6138
6139 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
6140 and the cursor position is out of bounds, behave as if the cursor
6141 position were at the window margin. (Bug#10075)
6142
df05a53c
CY
61432011-11-18 Chong Yidong <cyd@gnu.org>
6144
6145 * window.c (Fwindow_combination_limit): Make first argument
6146 non-optional, since it is meaningless for live windows like the
6147 selected window.
61ccba97 6148
2071918e
DA
61492011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
6150
6151 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
6152
b50a28de
SM
61532011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
6154
6155 * intervals.c: Fix grafting over the whole buffer (bug#10071).
6156 (graft_intervals_into_buffer): Simplify.
6157
015137db
EZ
61582011-11-18 Eli Zaretskii <eliz@gnu.org>
6159
6160 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
6161 hash values of the two rows.
6162 (copy_row_except_pointers): Preserve the used[] arrays and the
6163 hash values of the two rows. (Bug#10035)
68c95424 6164 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
6165
6166 * xdisp.c (row_hash): New function, body extracted from
6167 compute_line_metrics.
6168 (compute_line_metrics): Call row_hash, instead of computing the
6169 hash code inline.
6170
6171 * dispnew.c (verify_row_hash): Call row_hash for computing the
6172 hash code of a row, instead of duplicating code from xdisp.c.
6173
6174 * dispextern.h (row_hash): Add prototype.
6175
a2addb04
TH
61762011-11-18 Tassilo Horn <tassilo@member.fsf.org>
6177
6178 * frame.c (delete_frame): Don't delete the terminal when the last
6179 X frame is closed if emacs is built with GTK toolkit.
6180
df85d315
JB
61812011-11-17 Juanma Barranquero <lekktu@gmail.com>
6182
6183 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
6184
a0c2d0ae
MR
61852011-11-17 Martin Rudalics <rudalics@gmx.at>
6186
6187 * window.c (Vwindow_splits): Rename to
6188 Vwindow_combination_resize. Suggested by Juri Linkov.
6189 (Fsplit_window_internal): Use Vwindow_combination_resize instead
6190 of Vwindow_splits.
6191
58179cce
JB
61922011-11-16 Juanma Barranquero <lekktu@gmail.com>
6193
7877f373
JB
6194 * nsfns.m (Fns_font_name):
6195 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 6196
b6f67890
MR
61972011-11-16 Martin Rudalics <rudalics@gmx.at>
6198
6199 * window.h (window): Rename slot "nest" to "combination_limit".
6200 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
6201 (Fset_window_nest): Rename to Fset_window_combination_limit.
6202 (Vwindow_nest): Rename to Vwindow_combination_limit.
6203 (recombine_windows, make_parent_window, make_window)
6204 (Fsplit_window_internal, saved_window)
6205 (Fset_window_configuration, save_window_save): Rename all
6206 occurrences of window_nest to window_combination_limit.
6207
c7015153
JB
62082011-11-15 Juanma Barranquero <lekktu@gmail.com>
6209
6210 * image.c (imagemagick_load_image): Fix typo.
6211
322ad6ec
EZ
62122011-11-14 Eli Zaretskii <eliz@gnu.org>
6213
6214 * xdisp.c (display_line): Move the call to
6215 highlight_trailing_whitespace before the call to
6216 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
6217 faces of all the glyphs to compute ROW's hash value.
6218 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 6219
f067b8ec
JB
62202011-11-14 Juanma Barranquero <lekktu@gmail.com>
6221
6222 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
6223 just return (bug#10044).
6224
1e5b2111
EZ
62252011-11-12 Eli Zaretskii <eliz@gnu.org>
6226
7ef3cbd5
EZ
6227 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
6228 with user-defined heap size. Bump the default size of the temacs
6229 heap to 27MB, to avoid memory warning when running temacs.
6230 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
6231
1e5b2111
EZ
6232 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
6233 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
6234 (verify_row_hash) [XASSERTS]: New function.
6235 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
6236 that the hash value of glyph rows is correct.
1e5b2111 6237
89d61221
MR
62382011-11-12 Martin Rudalics <rudalics@gmx.at>
6239
6240 * window.h (window): Remove splits slot.
6241 * window.c (Fwindow_splits, Fset_window_splits): Remove.
6242 (Fdelete_other_windows_internal, make_parent_window)
6243 (make_window, Fsplit_window_internal, Fdelete_window_internal)
6244 (Fset_window_configuration, save_window_save): Don't deal with
6245 split status of windows.
6246 (saved_window): Remove splits slot.
6247 (Vwindow_splits): Rewrite doc-string.
6248
97f18cc8
JD
62492011-11-11 Jan Djärv <jan.h.d@swipnet.se>
6250
6251 * xfns.c (unwind_create_frame):
6252 * nsfns.m (unwind_create_frame):
6253 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
6254 Vframe_list (Bug#9999).
6255
22a648b4
DA
62562011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
6257
0b381c7e 6258 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 6259
659afede
KH
62602011-11-11 Kenichi Handa <handa@m17n.org>
6261
6262 * callproc.c (Fcall_process): Set the member dst_multibyte of
6263 process_coding.
6264
9ac0394b
KH
62652011-11-11 Johan Bockgård <bojohan@gnu.org>
6266
6267 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
6268 avoid a crash (bug#9496).
6269
2fbdc249
CY
62702011-11-09 Chong Yidong <cyd@gnu.org>
6271
6272 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
6273 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
6274
ac6b1f81
PE
62752011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6276
6277 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
6278
09db192c
PE
62792011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6280
6281 Avoid some portability problems by eschewing 'extern inline' functions.
6282 The trivial performance wins aren't worth the portability hassles; see
6283 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
6284 et seq.
6285 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6286 (window_box_width, window_box_left, window_box_left_offset)
6287 (window_box_right, window_box_right_offset): Undo previous change,
6288 by removing the "extern"s.
6289 * intervals.c (adjust_intervals_for_insertion)
6290 (adjust_intervals_for_deletion): Undo previous change,
6291 making these static again.
6292 (offset_intervals, temp_set_point_both, temp_set_point)
6293 (copy_intervals_to_string): No longer inline.
6294 * xdisp.c (window_text_bottom_y, window_box_width)
6295 (window_box_height, window_box_left_offset)
6296 (window_box_right_offset, window_box_left, window_box_right)
6297 (window_box): No longer inline.
6298
105216ed
CY
62992011-11-08 Chong Yidong <cyd@gnu.org>
6300
6301 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
6302 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
6303 Signal an error if not a live window.
105216ed
CY
6304 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
6305 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
6306
ae9e237f
JB
63072011-11-07 Juanma Barranquero <lekktu@gmail.com>
6308
6309 * lisp.h (syms_of_abbrev): Remove declaration.
6310 Reported by CHENG Gao <chenggao@royau.me>.
6311
c7aa8333
EZ
63122011-11-07 Eli Zaretskii <eliz@gnu.org>
6313
6314 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
6315 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
6316 of temacs in GUI mode.
6317
be7f5545
MR
63182011-11-07 Martin Rudalics <rudalics@gmx.at>
6319
6320 * window.h: Declare delete_all_child_windows instead of
6321 delete_all_subwindows.
6322 * window.c (Fwindow_nest, Fset_window_nest)
6323 (Fset_window_new_total, Fset_window_new_normal)
6324 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
6325 (delete_all_subwindows): Rename to delete_all_child_windows.
6326 (Fdelete_other_windows_internal, Fset_window_configuration):
6327 Call delete_all_child_windows instead of delete_all_subwindows.
6328 * frame.c (delete_frame): Call delete_all_child_windows instead
6329 of delete_all_subwindows.
6330
ca78dc43
PE
63312011-11-07 Paul Eggert <eggert@cs.ucla.edu>
6332
6333 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
6334 This is also needed for porting to any host where GC_MARK_STACK is
6335 not GC_MAKE_GCPROS_NOOPS.
6336 (which_symbols): Use it.
6337
a0241d01
KH
63382011-11-07 Kenichi Handa <handa@m17n.org>
6339
6340 * coding.c (coding_set_destination): Check coding->src_pos only
6341 when coding->src_object is a buffer (bug#9910).
6342
6343 * process.c (send_process): Set the member src_multibyte of coding
6344 to 0 (bug#9911) when sending a unibyte text.
6345
6346 * callproc.c (Fcall_process): Set the member src_multibyte of
6347 process_coding to 0 (bug#9912).
6348
a64bfdfa 63492011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
6350
6351 * xmenu.c (cleanup_widget_value_tree): New function.
6352 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
6353 calling free_menubar_widget_value_tree directly (Bug#9830).
6354
cb41b32a
PE
63552011-11-06 Paul Eggert <eggert@cs.ucla.edu>
6356
6357 Fix some portability problems with 'inline'.
6358 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6359 (window_box_width, window_box_left, window_box_left_offset)
6360 (window_box_right, window_box_right_offset): Declare extern.
6361 Otherwise, these inline functions do not conform to C99 and
6362 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
6363 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
6364 * intervals.c (adjust_intervals_for_insertion)
6365 (adjust_intervals_for_deletion): Now extern, because otherwise the
6366 extern inline functions 'offset_intervals' couldn't refer to it.
6367 (static_offset_intervals): Remove.
6368 (offset_intervals): Rewrite using the old contents of
6369 static_offset_intervals. The old version didn't conform to C99
6370 because an extern inline function contained a reference to an
6371 identifier with static linkage.
6372
b7041366
AS
63732011-11-06 Andreas Schwab <schwab@linux-m68k.org>
6374
6375 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
6376 GC.
6377
88a37c4d
EZ
63782011-11-06 Eli Zaretskii <eliz@gnu.org>
6379
6380 * xdisp.c (init_iterator, reseat_to_string): Don't set the
6381 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
6382 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
6383 return Qleft_to_right.
6384
49745b39
CY
63852011-11-06 Chong Yidong <cyd@gnu.org>
6386
6387 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
6388 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
6389 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
6390 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
6391 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
6392 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
6393 (Fwindow_vscroll): Doc fix.
6394 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
6395 argument, since it makes no sense to pass a live window and for
6396 consistency with window-child.
6397
1f05cd82
CS
63982011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
6399
6400 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
6401 support MSVC.
6402
22610910
JR
64032011-11-05 Jason Rumney <jasonr@gnu.org>
6404
6405 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
6406 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
6407 fonts (Bug#6029).
6408 (add_font_entity_to_list): Fix logic errors in mixed boolean and
6409 bitwise arithmetic preventing use of unicode-sip and non-truetype
6410 opentype fonts.
6411
a06776b2
EZ
64122011-11-05 Eli Zaretskii <eliz@gnu.org>
6413
3ad924ba
EZ
6414 * s/ms-w32.h (fstat, stat, utime): Move redirections to
6415 "emacs"-only part.
6416
a06776b2
EZ
6417 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
6418 initialization code to keep similarity to xfns.c after changes
6419 from 2011-11-05.
6420
c9e7db78
JD
64212011-11-05 Jan Djärv <jan.h.d@swipnet.se>
6422
a97f8f3f
JD
6423 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
6424 (unwind_create_frame): New function (Bug#9943).
6425 (Fx_create_frame): Restructure code to be more similar to the one in
6426 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
6427 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
6428 Move terminal->reference_count++ just before making the frame official
6429 (Bug#9943).
6430
6431 * nsterm.m (x_free_frame_resources): New function.
6432 (x_destroy_window): Move code to x_free_frame_resources.
6433
c9e7db78 6434 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
6435 (Fx_create_frame, x_create_tip_frame):
6436 Move terminal->reference_count++ just before making the frame
75f1671a 6437 official. Move initialization of image_cache_refcount and
c9e7db78
JD
6438 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
6439
a6fc3b5c
EZ
64402011-11-05 Eli Zaretskii <eliz@gnu.org>
6441
6442 Support MSVC build with newer versions of Visual Studio.
6443 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
6444 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
6445 nt/gmake.defs.
6446
6447 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
6448 which are not supported by MSVC.
6449 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
6450 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
6451 bitfields.
6452 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
6453 types in bitfields.
6454 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
6455
6456 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
6457
58179cce 64582011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
6459
6460 Support MSVC build with newer versions of Visual Studio.
6461 * w32.c: Don't include w32api.h for MSVC.
6462 (init_environment) [_MSC_VER]: Call sys_access, not _access.
6463
6464 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
6465 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
6466 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
6467 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
6468 e_* cousins.
6469 (alloca) [_MSC_VER]: Define to _alloca.
6470
6471 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
6472
6473 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
6474
a58c13ed
EZ
64752011-11-04 Eli Zaretskii <eliz@gnu.org>
6476
6477 * xdisp.c (note_mouse_highlight): If either of
6478 previous/next-single-property-change returns nil, treat that as
6479 the beginning or the end of the buffer. (Bug#9955)
6480
fe0b6370
JD
64812011-11-04 Jan Djärv <jan.h.d@swipnet.se>
6482
a58c13ed 6483 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
6484 label is not null (Bug#9951).
6485 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
6486 may be NULL.
6487
89bd5ee1
EZ
64882011-11-04 Eli Zaretskii <eliz@gnu.org>
6489
6490 * window.c (Fwindow_body_size): Mention in the doc string that the
6491 return value is in frame's canonical units. (Bug#9949)
6492
84c3edb9
EZ
64932011-11-03 Eli Zaretskii <eliz@gnu.org>
6494
4e2fb5c7
EZ
6495 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
6496
84c3edb9 6497 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 6498 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 6499 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 6500
bc17a887
EZ
65012011-11-01 Eli Zaretskii <eliz@gnu.org>
6502
6503 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
6504 Don't stop backward scan on the continuation glyph, even though
6505 its CHARPOS is positive.
6d5eb5b0
SM
6506 (mouse_face_from_buffer_pos, note_mouse_highlight):
6507 Rename cover_string to disp_string.
bc17a887 6508
4ee88440
MR
65092011-11-01 Martin Rudalics <rudalics@gmx.at>
6510
6511 * window.c (temp_output_buffer_show): Don't use
6512 Vtemp_buffer_show_specifiers.
6513 (Vtemp_buffer_show_specifiers): Remove unused variable.
6514
c2ff3c02
EZ
65152011-10-30 Eli Zaretskii <eliz@gnu.org>
6516
6517 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
6518 past the beginning of the current glyph matrix.
6519
58179cce 65202011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
6521
6522 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
6523 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
6524 HAVE_GTK3 (Bug#9869).
b77a6a7f 6525
3b574623
JD
6526 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
6527 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
6528
b77a6a7f
JD
6529 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
6530
6531 * xterm.c: Declare x_handle_net_wm_state to return int.
6532 (handle_one_xevent): Check if we are iconified but don't have
6533 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
6534 (get_current_wm_state): Return non-zero if not hidden,
6535 check for _NET_WM_STATE_HIDDEN (Bug#9893).
6536 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
6537 (x_handle_net_wm_state): Return what get_current_wm_state returns.
6538 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
6539
196e41e4
PE
65402011-10-29 Paul Eggert <eggert@cs.ucla.edu>
6541
6542 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
6543 so that this new function doesn't get optimized away by a
6544 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
6545
021f2e1a
AS
65462011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6547
6548 * frame.h (MOUSE_HL_INFO): Remove excess parens.
6549
8b058d44
EZ
65502011-10-29 Eli Zaretskii <eliz@gnu.org>
6551
6552 Fix the `xbytecode' command.
6553 * .gdbinit (xprintbytestr): New command.
b50a28de 6554 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
6555 (xbytecode): Print the byte-code string as well.
6556
4452fb80
EZ
65572011-10-29 Kim Storm <storm@cua.dk>
6558
8b058d44
EZ
6559 * alloc.c (which_symbols): New function.
6560
21b72067
AS
65612011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6562
6563 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
6564 line. (Bug#9903)
6565
83ed7b5c
GM
65662011-10-29 Glenn Morris <rgm@gnu.org>
6567
6568 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
6569 Not clear what it was for, and it causes various bugs. (Bug#9839)
6570
5a7a728b
EZ
65712011-10-28 Eli Zaretskii <eliz@gnu.org>
6572
6573 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
6574 possible random value that matches one of those tested as
6575 condition to clear the mouse face.
6576
d3d0842f
CY
65772011-10-28 Chong Yidong <cyd@gnu.org>
6578
6579 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
6580
31b39d13
DN
65812011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
6582
6583 * window.c (make_window): Initialize phys_cursor_on_p.
6584
9aba6043
SM
65852011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
6586
6587 * lisp.h (struct Lisp_Symbol): Update comments.
6588
c20992f4
JB
65892011-10-28 Juanma Barranquero <lekktu@gmail.com>
6590
6591 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
6592
db4f02f2
EZ
65932011-10-28 Eli Zaretskii <eliz@gnu.org>
6594
6595 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
6596 <oslsachem@gmail.com> for helping to debug this.
6597
6598 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
6599 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
6600 (g_b_init_get_glyph_outline_w): New static variables.
6601 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
6602 (GetGlyphOutlineW_Proc): New typedefs.
6603 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
6604 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
6605 New functions.
6606 (w32font_open_internal, compute_metrics):
6607 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
6608 instead of calling the "wide" APIs directly.
6609
6610 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
6611
6612 * w32.h (syms_of_w32font): Add prototype.
6613
87e68db4
JB
66142011-10-27 Juanma Barranquero <lekktu@gmail.com>
6615
6616 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
6617 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
6618 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
6619 (Fmove_to_window_line): Doc fix.
6620
435c1d67
CY
66212011-10-27 Chong Yidong <cyd@gnu.org>
6622
6623 * process.c (make_process): Set gnutls_state to NULL.
6624
6625 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
6626 non-NULL, regardless of GNUTLS_INITSTAGE.
6627 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
6628 an error. Set process slots as soon as we allocate them.
6629
6630 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
6631
9c6c6f49
CY
66322011-10-27 Chong Yidong <cyd@gnu.org>
6633
9aba6043
SM
6634 * gnutls.c (emacs_gnutls_deinit): New function.
6635 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
6636 (Fgnutls_deinit, Fgnutls_boot): Use it.
6637
6638 * process.c (make_process): Initialize GnuTLS credentials to NULL.
6639 (deactivate_process): Call emacs_gnutls_deinit.
6640
657d08d3
JB
66412011-10-27 Juanma Barranquero <lekktu@gmail.com>
6642
6643 * image.c (x_create_x_image_and_pixmap):
6644 * w32.c (sys_rename, w32_delayed_load):
6645 * w32font.c (fill_in_logfont):
6646 * w32reg.c (x_get_string_resource): Silence compiler warnings.
6647
5430d399
JB
66482011-10-26 Juanma Barranquero <lekktu@gmail.com>
6649
6650 * w32fns.c (w32_default_color_map): New function,
6651 extracted from Fw32_default_color_map.
a7ef684b 6652 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 6653
fe0055fa
PE
66542011-10-25 Paul Eggert <eggert@cs.ucla.edu>
6655
6656 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
6657
e6346438
SM
66582011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
6659
6660 * keyboard.c (test_undefined): New function (bug#9751).
6661 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
6662
e112cc37
ET
66632011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
6664
6665 * sysdep.c (init_sys_modes): Fix the check for the controlling
6666 terminal (Bug#6649).
6667
7b5d6677
EZ
66682011-10-20 Eli Zaretskii <eliz@gnu.org>
6669
6670 * dispextern.h (struct bidi_it): New member next_en_type.
6671
6672 * bidi.c (bidi_line_init): Initialize the next_en_type member.
6673 (bidi_resolve_explicit_1): When next_en_pos is valid for the
6674 current character, check also for next_en_type being WEAK_EN.
6675 (bidi_resolve_weak): Don't enter the expensive loop if the current
6676 position is before next_en_pos. Record the bidi type of the first
6677 non-ET, non-BN character we find, in addition to its position.
6678 (bidi_level_of_next_char): Invalidate next_en_type when
6679 next_en_pos is over-stepped.
6680
7da0b018
PE
66812011-10-20 Paul Eggert <eggert@cs.ucla.edu>
6682
6683 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
6684 * editfns.c: Rewrite current-time-zone so that it invokes
6685 the equivalent of (format-time-string "%Z") to get the time zone name.
6686 This fixes a bug when the time zone name contains characters that
6687 need converting from the system time locale to Emacs internal format.
6688 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
6689 that patch fixed format-time-string to do the conversion, but
6690 I forgot to fix current-time-zone.
6691 (format_time_string): New function, containing most of
6692 what Fformat_time_string used to contain.
6693 (Fformat_time_string): Rewrite in terms of format_time_string.
6694 This doesn't change this function's behavior.
6695 (current-time-zone): Rewrite to use format_time_string.
6696 This fixes the bug reported by Michael Schierl in
6697 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
6698 Jason Rumney's 2007-06-07 change worked around this bug, but
6699 didn't fix it.
6700 * systime.h (tzname, timezone): Remove no-longer-used declarations.
6701
8547b010
EZ
67022011-10-19 Eli Zaretskii <eliz@gnu.org>
6703
6704 * xdisp.c (start_display): If the character at POS is displayed
6705 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
6706 (try_window_reusing_current_matrix): If a line ends in a display
6707 vector or the next line starts in a display vector, continue
6708 redrawing the window even though the character position of
6709 start_row was reached.
8547b010
EZ
6710 (Bug#9771, part 2)
6711
4e948d15
CY
67122011-10-18 Chong Yidong <cyd@gnu.org>
6713
6714 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
6715 with nobreak-char-display too.
6716
4787455f
EZ
67172011-10-18 Eli Zaretskii <eliz@gnu.org>
6718
6719 Fix part 3 of bug#9771.
6720 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
6721 (bidi_resolve_neutral): Don't enter the expensive loop looking for
6722 non-neutral characters if the current character is a paragraph
6723 separator (a.k.a. Newline). This avoids running the same
6724 expensive loop twice, once when we consume the preceding newline
6725 and the other time when the line actually needs to be displayed.
6726 Avoid the loop when we see neutrals on the base embedding level
6727 following a character whose directionality is the same as the
6728 paragraph's. This avoids running the expensive loop when a line
6729 ends in a long sequence of neutrals, like control characters.
6730 Add assertion against STRONG_AL type. Slightly rearrange code
6731 that determines the type of a neutral given the first non-neutral
6732 that follows it.
6733 (bidi_level_of_next_char): Set next_en_pos to zero when
6734 invalidating its info.
6735
2c91f553
EZ
67362011-10-17 Eli Zaretskii <eliz@gnu.org>
6737
6738 * xdisp.c (push_display_prop): Determine whether to record string
6739 or buffer position by IT->string, not by IT->method. Allow
6740 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
6741 (move_it_vertically_backward): Don't look for character position
6742 immediately after the newline when in a continuation line.
6743 (Bug#9771, part 1)
2c91f553 6744
c7b08b0d
MR
67452011-10-15 Martin Rudalics <rudalics@gmx.at>
6746
6747 * window.c (coordinates_in_window): Rewrite and delabelize
6748 vertical border check. (Bug#5357) (Bug#9618)
6749
6b02f655
SM
67502011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
6751
6752 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
6753 errors in XSetWindowBorder (bug#9310).
6754
81d40c92
DA
67552011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
6756
6757 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
6758 avoid crash when xmalloc overrun checking is enabled.
6759
d4172c3b
EZ
67602011-10-13 Eli Zaretskii <eliz@gnu.org>
6761
6762 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
6763 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
6764 cursor motion with <left> and <right> arrow keys.
6765
6766 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
6767 some callers set that themselves.
6768
b00eea75
EZ
67692011-10-12 Eli Zaretskii <eliz@gnu.org>
6770
6771 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
6772 display string and the previous row comes from the same string and
6773 is empty. (Bug#9739) (Bug#9738)
6774
8fe012c4
SM
67752011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
6776
6777 * doc.c (get_doc_string): Encode file name (bug#9735).
6778
0074aef2
EZ
67792011-10-12 Eli Zaretskii <eliz@gnu.org>
6780
79beb178
EZ
6781 * bidi.c (bidi_level_of_next_char):
6782 * xdisp.c (get_visually_first_element): Remove old incorrect
6783 comments regarding the Unicode Line Separator character.
6784
0074aef2
EZ
6785 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
6786
6e4b3fbe
DA
67872011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
6788
6789 * alloc.c (Fgc_status): Do not access beyond zombies array
6790 boundary if nzombies > MAX_ZOMBIES.
6791 * alloc.c (dump_zombies): Add missing format specifier.
6792
0324f3af
PE
67932011-10-12 Paul Eggert <eggert@cs.ucla.edu>
6794
b5525cac
PE
6795 * xdisp.c (set_cursor_from_row): Simplify conditionals,
6796 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
6797
0324f3af
PE
6798 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
6799 Some packages use them to denote characters with modifiers.
6800
e9b5f888
AS
68012011-10-11 Andreas Schwab <schwab@linux-m68k.org>
6802
6803 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
6804 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
6805 matching a pp-number. Rename parameter var to var1.
6806
127827c0
SM
68072011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
6808
6809 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
6810
c8fd3bd0
GM
68112011-10-08 Glenn Morris <rgm@gnu.org>
6812
6813 * callint.c (Fcall_interactively): Give a more explicit error for the
6814 'c' case with a non-character input. (Bug#8479)
6815
352ec8ff
EZ
68162011-10-08 Eli Zaretskii <eliz@gnu.org>
6817
03669ccb
EZ
6818 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
6819 lines.
7061c986
EZ
6820 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
6821 lines that are hscrolled on the left.
03669ccb 6822
352ec8ff
EZ
6823 * dispnew.c (buffer_posn_from_coords): Account for a possible
6824 presence of header-line. (Bug#4426)
6825
a66cfb1c
SM
68262011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
6827
6b02f655
SM
6828 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
6829 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 6830
7c5ee88e
PE
68312011-10-07 Paul Eggert <eggert@cs.ucla.edu>
6832
6833 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
6834 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
6835 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
6836 this makes Emacs dump core during garbage collection on rare
6837 occasions. sizeof is obviously inferior to offsetof here, so
6838 stick with offsetof.
6839 (GC_POINTER_ALIGNMENT): New macro.
6840 (mark_memory): Omit 3rd (offset) arg; caller changed.
6841 Don't assume EMACS_INT alignment is the same as pointer alignment.
6842
df1bbe5b
SM
68432011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
6844
6845 * keyboard.c (read_key_sequence_remapped): New var.
6846 (read_key_sequence): Compute remapping in the right buffer.
6847 (command_loop_1): Use read_key_sequence's remapping directly.
6848
51553db6
SM
68492011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
6850
32c1fffd
SM
6851 * dired.c (file_name_completion): Don't expand file name.
6852 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
6853 before checking file name handler.
6854
51553db6
SM
6855 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
6856 they've been requested explicitly (bug#9591).
6857
b6bd1599 68582011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
6859
6860 * keymap.c (Fsingle_key_description): Use make_specified_string
6861 instead of build_string to build string from push_key_description.
6862 (Bug#5193)
6863
f701dc2a
PE
68642011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6865
4222c55d
PE
6866 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
6867 This fixes a Y2038 bug on 64-bit hosts.
6868 * buffer.c (reset_buffer):
6869 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
6870 (Fclear_buffer_auto_save_failure):
6871 Use 0, not -1, to represent an unset failure time, since time_t
6872 might not be signed.
6873
f701dc2a
PE
6874 Remove dependency on glibc malloc internals.
6875 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6876 Move back here from lisp.h, but with their new implementations.
6877 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6878 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
6879 * charset.c (charset_table_init): New static var.
6880 (syms_of_charset): Use it instead of xmalloc. This removes a
6881 dependency on glibc malloc internals. See Eli Zaretskii's comment in
6882 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
6883 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6884 Move back to alloc.c.
6885 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6886 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
6887
9ceebf39
JD
68882011-09-30 Jan Djärv <jan.h.d@swipnet.se>
6889
6890 * nsterm.m (windowDidResize): Call x_set_window_size only when
6891 ns_in_resize is true. Otherwise set pixelwidth/height and
6892 call change_frame_size (Bug#9628).
6893
cb993c58
PE
68942011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6895
3930c88b
PE
6896 Port --enable-checking=all to Fedora 14 x86-64.
6897 * charset.c (syms_of_charset): Also account for glibc malloc's
6898 internal overhead when calculating the initial malloc maximum.
6899
cb993c58
PE
6900 Port --enable-checking=all to Fedora 14 x86.
6901 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6902 Move to lisp.h.
6903 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
6904 (overrun_check_realloc, overrun_check_free):
6905 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
6906 That way, xmalloc returns a properly-aligned pointer even if
6907 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
6908 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
6909 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
6910 into account when calculating the initial malloc maximum.
6911 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6912 Move here from alloc.c, so that charset.c can use it too.
6913 Properly align; the old code wasn't right for common 32-bit hosts
6914 when configured with --enable-checking=all.
6915 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6916 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
6917
31bed486
EZ
69182011-09-29 Eli Zaretskii <eliz@gnu.org>
6919
04c70788 6920 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
6921 use EDOM.
6922
fbcaa2f3
EZ
69232011-09-28 Eli Zaretskii <eliz@gnu.org>
6924
6925 * xdisp.c (compute_display_string_end): If there's no display
6926 string at CHARPOS, return -1.
6927
6928 * bidi.c (bidi_fetch_char): When compute_display_string_end
6929 returns a negative value, treat the character as a normal
6930 character not covered by a display string. (Bug#9624)
6931
a239d4e9
JB
69322011-09-28 Juanma Barranquero <lekktu@gmail.com>
6933
6934 * lread.c (Fread_from_string): Fix typo in docstring.
6935
88652fd5
EZ
69362011-09-27 Eli Zaretskii <eliz@gnu.org>
6937
6938 * xdisp.c (handle_invisible_prop): If invisible text ends on a
6939 newline, reseat the iterator instead of bidi-iterating there one
6940 character at a time. (Bug#9610)
32c1fffd
SM
6941 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
6942 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 6943
ed497dd4
AS
69442011-09-27 Andreas Schwab <schwab@linux-m68k.org>
6945
6946 * lread.c (readevalloop): Use correct code for NBSP.
6947 (read1): Likewise. (Bug#9608)
6948
b2bf61aa
MA
69492011-09-25 Michael Albinus <michael.albinus@gmx.de>
6950
6951 * dbusbind.c (Fdbus_register_signal): When service is not
6952 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
6953
32bbb17c
GM
69542011-09-25 Glenn Morris <rgm@gnu.org>
6955
6956 * buffer.c (truncate-lines): Doc fix.
6957
94e0933e
CY
69582011-09-24 Chong Yidong <cyd@stupidchicken.com>
6959
6960 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
6961 (Fset_window_next_buffers): Doc fix.
6962
cddde921
GM
69632011-09-24 Glenn Morris <rgm@gnu.org>
6964
6965 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
6966
1260aef1
PE
69672011-09-24 Paul Eggert <eggert@cs.ucla.edu>
6968
25b4bfa0
PE
6969 Fix minor problems found by static checking.
6970 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
6971 * indent.c (Fvertical_motion): Fix == vs = typo.
6972
e3cbd34b
EZ
69732011-09-24 Eli Zaretskii <eliz@gnu.org>
6974
a66cfb1c
SM
6975 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
6976 Default value is now t. Doc fix.
6bf7006f 6977
e3cbd34b 6978 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 6979 logic when moving up, not only when moving down. Fix the
e3cbd34b 6980 confusing name and values of the it_overshoot_expected variable;
32c1fffd 6981 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
6982
6983 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
6984 CHARPOS is covered by a display string which includes newlines.
6985 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
6986 is covered by a display string with embedded newlines.
6987
a3de0cbd
MA
69882011-09-24 Michael Albinus <michael.albinus@gmx.de>
6989
6990 * dbusbind.c (Fdbus_register_signal): Add match rule to
6991 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
6992 (Fdbus_register_method, Vdbus_registered_objects_table):
6993 Fix docstring.
a3de0cbd 6994
b260039d
JM
69952011-09-24 Jim Meyering <meyering@redhat.com>
6996
32c1fffd 6997 do not ignore write error for any output size
b260039d
JM
6998 The previous change was incomplete.
6999 While it makes emacs --batch detect the vast majority of stdout
7000 write failures, errors were still ignored whenever the output size is
7001 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
7002 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
7003 && echo FAIL: ignored write error
7004 FAIL: ignored write error
7005 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
7006 && echo FAIL: ignored write error
7007 FAIL: ignored write error
7008 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
7009
8eca8a7c
AS
70102011-09-23 Andreas Schwab <schwab@linux-m68k.org>
7011
7012 * emacs.c (Fkill_emacs): In noninteractive mode exit
7013 non-successfully if a write error occurred on stdout. (Bug#9574)
7014
3341db62
EZ
70152011-09-21 Eli Zaretskii <eliz@gnu.org>
7016
7017 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
7018 the xassert test.
7019
7020 * dispextern.h (struct it): Update the comment documenting what
7021 can it->OBJECT be.
7022
8c203dbf
EZ
70232011-09-20 Eli Zaretskii <eliz@gnu.org>
7024
7025 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
7026 a display string, extend search for cursor position to end of row.
7027 (find_row_edges): If the row ends in a newline from a display
7028 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
7029 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
7030 (Fcurrent_bidi_paragraph_direction): Fix search for previous
7031 non-empty line. Fixes confusing cursor motion with arrow keys at
7032 the beginning of a line that starts with whitespace.
8c203dbf 7033
a4824228
LMI
70342011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7035
7036 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
7037 (bug#9493).
7038
33ed493b
CY
70392011-09-18 Chong Yidong <cyd@stupidchicken.com>
7040
7041 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
7042 boolean (Bug#9154).
7043
56cd55c8
EZ
70442011-09-18 Eli Zaretskii <eliz@gnu.org>
7045
7046 * xdisp.c (display_line): Record maximum and minimum buffer
7047 positions even if no glyphs were produced (e.g., by a zero-width
7048 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
7049 buffer positions that will be removed from the glyph row because
7050 they don't fit.
c02dcedf
EZ
7051 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
7052 column is beyond frame width: don't subtract 1 "pixel" when
7053 computing width of the stretch.
3e62b7e0
EZ
7054 (reseat_at_next_visible_line_start): Undo the change made on
7055 2011-09-17 that saved paragraph information and restored it after
7056 the call to `reseat'. (Bug#9545)
56cd55c8 7057
5ed99d36 70582011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
7059
7060 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
7061 and turn window cursor on if cleared (Bug#9415).
7062
5ed99d36 70632011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
7064
7065 * search.c (boyer_moore): Take unibyte characters from pattern
7066 literally. (Bug#9458)
7067
9bade7b2
EZ
70682011-09-18 Eli Zaretskii <eliz@gnu.org>
7069
7070 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
7071
e5e9d610
PE
70722011-09-18 Paul Eggert <eggert@cs.ucla.edu>
7073
87e4427a
PE
7074 Fix minor problem found by static checking.
7075 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
7076 initialized, to pacify gcc -Wuninitialized.
7077
e5e9d610
PE
7078 * fileio.c: Report proper errno when syscall falls.
7079 (Finsert_file_contents): Save and restore errno,
7080 so that report_file_error outputs the correct diagnostic.
7081 (Fwrite_region) [CLASH_DETECTION]: Likewise.
7082
a1674f0b
EZ
70832011-09-18 Eli Zaretskii <eliz@gnu.org>
7084
7085 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
7086
fbfb6dd4
EZ
70872011-09-17 Eli Zaretskii <eliz@gnu.org>
7088
7089 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
7090 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
7091
bb187662
EZ
70922011-09-17 Eli Zaretskii <eliz@gnu.org>
7093
1137e8b8 7094 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 7095 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
7096
7097 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
7098 (bidi_find_paragraph_start): Search back for paragraph beginning
7099 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
7100 (bidi_move_to_visually_next): Only trigger paragraph-related
7101 computations when the last character is a newline or at EOB, not
7102 just any NEUTRAL_B. (Bug#9470)
7103
bb187662
EZ
7104 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
7105 truncated lines if point is covered by a display string. (Bug#9524)
7106
2e621251
PE
71072011-09-16 Paul Eggert <eggert@cs.ucla.edu>
7108
7109 * xselect.c: Relax test for outgoing X longs (Bug#9498).
7110 (cons_to_x_long): New function.
7111 (lisp_data_to_selection_data): Use it. Correct the test for
7112 short-versus-long data; it was negated. Break out of vector
7113 loop, for efficiency, when a long datum is discovered.
7114
91a15bc6
SM
71152011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
7116
7117 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
7118
b41c3a35
EZ
71192011-09-16 Eli Zaretskii <eliz@gnu.org>
7120
7121 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
7122 GCC PR/17406) by declaring this function with external scope.
7123
7812ba2d
PE
71242011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7125
7126 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
7127 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
7128
cf7edc2a
AS
71292011-09-15 Andreas Schwab <schwab@linux-m68k.org>
7130
7131 * editfns.c (Fformat): Correctly handle text properties on "%%".
7132
bd01620e
EZ
71332011-09-15 Eli Zaretskii <eliz@gnu.org>
7134
7135 * xterm.c (x_draw_composite_glyph_string_foreground):
7136 * w32term.c (x_draw_composite_glyph_string_foreground):
7137 * term.c (encode_terminal_code):
7138 * composite.c (composition_update_it, get_composition_id):
7139 * xdisp.c (get_next_display_element)
7140 (fill_composite_glyph_string): Add comments about special meaning
7141 of TAB characters in a composition.
7142
a02719a3
PE
71432011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7144
7145 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
7146 This occurs when processing a multibyte format.
7147 Problem reported by Wolfgang Jenker.
a02719a3 7148
72589a3c
JB
71492011-09-15 Johan Bockgård <bojohan@gnu.org>
7150
7151 * xdisp.c (try_cursor_movement): Only check for exact match if
7152 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
7153
1c14176c
PE
71542011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7155
7156 Remove unused external symbols.
7157 * dispextern.h (calc_pixel_width_or_height): Remove decl.
7158 * xdisp.c (calc_pixel_width_or_height): Now static.
7159 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
7160 * indent.c (check_display_width):
7161 * w32term.c: Fix comment to match code.
7162 * xterm.c, xterm.h (x_catching_errors): Remove.
7163
d2eea5b5
PE
71642011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7165
7166 * xselect.c: Use signed conversions more consistently (Bug#9498).
7167 (selection_data_to_lisp_data): Assume incoming selection data are
7168 signed integers, not unsigned. This is to be consistent with
7169 outgoing selection data, which was modified to use signed integers
7170 in as part of the fix to Bug#9196 in response to Jan D.'s comment
7171 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
7172 expects long, not unsigned long.
7173
46888499
EZ
71742011-09-14 Eli Zaretskii <eliz@gnu.org>
7175
7176 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
7177 computation of loop end. Reported by Johan Bockgård
7178 <bojohan@gnu.org>.
7179
ef8ef9fb
CY
71802011-09-13 Chong Yidong <cyd@stupidchicken.com>
7181
7182 * frame.c (Fother_visible_frames_p): Function deleted.
7183
fa819fed
EZ
71842011-09-12 Eli Zaretskii <eliz@gnu.org>
7185
7186 * indent.c (compute_motion): Process display vector front to back
7187 rather than the other way around. (Bug#2496)
7188
2ba8e008
SM
71892011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
7190
7191 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
7192
20f53c69
CY
71932011-09-11 Chong Yidong <cyd@stupidchicken.com>
7194
7195 * minibuf.c (Fread_from_minibuffer): Doc fix.
7196
d562d7a4
EZ
71972011-09-11 Eli Zaretskii <eliz@gnu.org>
7198
7199 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
7200 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
7201
1c4d7f3d
LMI
72022011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7203
7204 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
7205 value for non-existent files.
7206
b885bf36
EZ
72072011-09-11 Eli Zaretskii <eliz@gnu.org>
7208
7209 * fileio.c (Finsert_file_contents): If the file cannot be opened,
7210 set its "size" to -1. This will set the modtime_size field of
7211 the corresponding buffer to -1, which is what
7212 verify-visited-file-modtime expects for files that do not exist.
7213 (Bug#9139)
7214
6612f0bf
PE
72152011-09-11 Paul Eggert <eggert@cs.ucla.edu>
7216
7217 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
7218 here ...
7219 * lisp.h: ... from here. push_key_description is no longer
7220 defined in keyboard.c, so its declaration should not be in
7221 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
7222 logically belongs with push_key_description.
7223
dfb3f755
PE
72242011-09-10 Paul Eggert <eggert@cs.ucla.edu>
7225
7226 * buffer.h: Include <sys/types.h> instead of <time.h>.
7227 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
7228 Problem reported by Herbert J. Skuhra.
7229
3134906c
LMI
72302011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
7231
7232 * xml.c (parse_region): Make the parsing work for
7233 non-comment-starting XML files again (bug#9144).
7234
8d903f4e
AS
72352011-09-10 Andreas Schwab <schwab@linux-m68k.org>
7236
7237 * image.c (gif_load): Fix calculation of bottom and right corner.
7238 (Bug#9468)
7239
80ad64f4
EZ
72402011-09-10 Eli Zaretskii <eliz@gnu.org>
7241
7242 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
7243 redisplay in small windows.
7244
208a048d
EZ
72452011-09-09 Eli Zaretskii <eliz@gnu.org>
7246
7247 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
7248
9b1c252e
MR
72492011-09-08 Martin Rudalics <rudalics@gmx.at>
7250
7251 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
7252 Operate on live windows only.
7253
2949f33b
JB
72542011-09-08 Juanma Barranquero <lekktu@gmail.com>
7255
7256 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
7257
e08dcafd
EZ
72582011-09-07 Eli Zaretskii <eliz@gnu.org>
7259
7260 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
7261 only under bidi iteration.
7262
115b96bd
JD
72632011-09-07 Jan Djärv <jan.h.d@swipnet.se>
7264
7265 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
7266
c8199d0f
PE
72672011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7268
7269 isnan: Fix porting problem to Solaris 10 with bundled gcc.
7270 Without this fix, the command to link temacs failed due to an
7271 undefined symbol __builtin_isnan. This is because
7272 /usr/include/iso/math_c99.h #defines isnan(x) to
7273 __builtin_isnan(x), but the bundled gcc, which identifies itself
7274 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
7275 a __builtin_isnan.
7276 * floatfns.c (isnan): #undef, and then #define to a clone of
7277 what's in data.c.
7278 (Fisnan): Always define, since it's always available now.
7279 (syms_of_floatfns): Always define isnan at the Lisp level.
7280
e39b275c 72812011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
7282
7283 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
7284
b2db44d9 72852011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 7286
f4af5137 7287 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
7288 The previous code assumed that file offsets (off_t values) fit in
7289 EMACS_INT variables, which is not true on typical 32-bit hosts.
7290 The code messed up by falsely reporting buffer overflow in cases
7291 such as (insert-file-contents "big" nil 1 2) into an empty buffer
7292 when "big" contains more than 2**29 bytes, even though this
7293 inserts just one byte and does not overflow the buffer.
7294 (Finsert_file_contents): Store file offsets as off_t
7295 values, not as EMACS_INT values. Check for overflow when
7296 converting between EMACS_INT and off_t. When checking for
7297 buffer overflow or for overlap, take the offsets into account.
7298 Don't use EMACS_INT for small values where int suffices.
7299 When checking for overlap, fix a typo: ZV was used where
7300 ZV_BYTE was intended.
7301 (Fwrite_region): Don't assume off_t fits into 'long'.
7302 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
7303
ecfc0a49
MA
73042011-09-05 Michael Albinus <michael.albinus@gmx.de>
7305
7306 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
7307
6511acf2 73082011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 7309
0999621a 7310 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
7311
7312 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 7313 (esprintf, exprintf, evxprintf): New functions.
62f19c19 7314 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 7315 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
7316 (modify_event_symbol): Do not assume that the length of
7317 name_alist_or_stem is safe to alloca and fits in int.
7318 (Fexecute_extended_command): Likewise for function name and binding.
7319 (Frecursion_depth): Wrap around reliably on integer overflow.
7320 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
7321 since some callers pass EMACS_INT values.
7322 (Fsingle_key_description): Don't crash if symbol name contains more
7323 than MAX_ALLOCA bytes.
7324 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
7325 (get_minibuffer): Arg is now EMACS_INT, not int.
7326 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 7327 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
7328 * window.h (command_loop_level, minibuf_level): Reflect API changes.
7329
2be7d702
PE
7330 * dbusbind.c (signature_cat): New function.
7331 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
7332 Do not overrun buffer; instead, report string overflow.
7333
9d1df220
PE
7334 * dispnew.c (add_window_display_history): Don't overrun buffer.
7335 Truncate instead; this is OK since it's just a log.
7336
33ef5c64
PE
7337 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
7338 even if the time zone offset is outlandishly large.
7339 Don't mishandle offset == INT_MIN.
7340
66c6fdd5
PE
7341 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
7342 when creating daemon; the previous buffer-overflow check was incorrect.
7343
d749b01b
PE
7344 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
7345 which has the guts of the old verror function.
7346
b5cd1905
PE
7347 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
7348 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
7349
6e1a67fb
PE
7350 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
7351 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 7352 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 7353 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
7354 length of string rather than counting it via multiple sprintfs;
7355 that's simpler and more reliable.
c21721cc
PE
7356 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
7357 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
7358 sprintf, in case result does not fit in int.
7359
c57b67fc
PE
7360 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
7361 (fontset_from_font): Print it.
7362
8a401434
PE
7363 * frame.c (tty_frame_count): Now printmax_t, not int.
7364 (make_terminal_frame, set_term_frame_name): Print it.
7365 (x_report_frame_params): In X, window IDs are unsigned long,
7366 not signed long, so print them as unsigned.
7367 (validate_x_resource_name): Check for implausibly long names,
7368 and don't assume name length fits in 'int'.
7369 (x_get_resource_string): Don't blindly alloca invocation name;
7370 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
7371 not fit in int.
7372
6e1a67fb
PE
7373 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
7374 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
7375 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
7376
0df02bf3
PE
7377 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
7378 Use esprintf, not sprintf, in case result does not fit in int.
7379
48e30793
PE
7380 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7381 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
7382 it as a large positive number.
7383 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
7384 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7385
a66ff6d8
PE
7386 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
7387 in case result does not fit in int.
7388
aca216ff
PE
7389 * print.c (float_to_string): Detect width overflow more reliably.
7390 (print_object): Make sprintf buffer a bit bigger, to avoid potential
7391 buffer overrun. Don't assume list length fits in 'int'. Treat
7392 print length of 0 as 0, not as infinity; to be consistent with other
7393 uses of print length in this function. Don't overflow print length
7394 index. Don't assume hash table size fits in 'long', or that
7395 vectorlike size fits in 'unsigned long'.
7396
31c286f7
PE
7397 * process.c (make_process): Use printmax_t, not int, to format
7398 process-name gensyms.
7399
55e5faa1
PE
7400 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
7401
80f2e268
PE
7402 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
7403 to avoid potential buffer overrun.
7404
670741ab
PE
7405 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
7406 if X resource line is longer than 512 bytes.
7407
b7163a50
PE
7408 * xfns.c (x_window): Make sprintf buffer a bit bigger
7409 to avoid potential buffer overrun.
7410
ae58ff1f
PE
7411 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
7412
c43c8a6a
PE
7413 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
7414
3f8236f4
PE
74152011-09-04 Paul Eggert <eggert@cs.ucla.edu>
7416
53e9fe90 7417 Integer overflow fixes for scrolling, etc.
6511acf2
PE
7418 Without these, Emacs silently mishandles large integers sometimes.
7419 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
7420 it were "C-u 1 M-x recenter" on a typical 64-bit host.
7421
6511acf2
PE
7422 * xdisp.c (try_window_id): Check Emacs fixnum range before
7423 converting to 'int'.
806add1d 7424
6511acf2 7425 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
7426 Check that an Emacs fixnum is in range before assigning it to 'int'.
7427 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
7428 values converted from Emacs fixnums.
7429 (Frecenter): Don't wrap around a line count if it is out of 'int'
7430 range; instead, treat it as an extreme value.
7431 (Fset_window_configuration, compare_window_configurations):
7432 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
7433
6511acf2
PE
7434 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
7435 that can exceed INT_MAX. Check that EMACS_INT value is in range
7436 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
7437 (match_limit): Don't assume that a fixnum can fit in 'int'.
7438
6511acf2 7439 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
7440 exceed INT_MAX.
7441
6511acf2 7442 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
7443 (Fvertical_motion): Don't wrap around LINES values that don't fit
7444 in 'int'. Instead, treat them as extreme values. This is good
7445 enough for windows, which can't have more than INT_MAX lines anyway.
7446
fcb901a7
LMI
74472011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7448
0f2f6b6d
LMI
7449 * Require libxml/parser.h to avoid compilation warning.
7450
fcb901a7
LMI
7451 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
7452
7453 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
7454 since this reportedly can destroy thread storage.
7455
6e20a0d4
CY
74562011-08-30 Chong Yidong <cyd@stupidchicken.com>
7457
7458 * syntax.c (find_defun_start): Update all cache variables if
7459 exiting early (Bug#9401).
7460
148ae00e
EZ
74612011-08-30 Eli Zaretskii <eliz@gnu.org>
7462
f6cfbd8f
EZ
7463 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
7464
148ae00e
EZ
7465 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
7466 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
7467 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
7468
7469 * term.c (tty_append_glyph): New function.
7470 (produce_stretch_glyph): Static function and its prototype deleted.
7471
a66cfb1c
SM
7472 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
7473 Add prototypes.
148ae00e 7474
c4a07a4c
PE
74752011-08-29 Paul Eggert <eggert@cs.ucla.edu>
7476
7477 * image.c (parse_image_spec): Check for nonnegative, not for positive,
7478 when checking :margin (Bug#9390).
7479 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 7480 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
7481 so that the name doesn't mislead. All uses changed.
7482
6bc8cd65
JB
74832011-08-28 Johan Bockgård <bojohan@gnu.org>
7484
7485 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
7486 set_tty_hooks.
7487
dca4927e
EZ
74882011-08-27 Eli Zaretskii <eliz@gnu.org>
7489
7490 * xdisp.c (move_it_to): Don't bail out early when reaching
7491 position beyond to_charpos, if we are scanning backwards.
7492 (move_it_vertically_backward): When DY == 0, make sure we get to
7493 the first character in the line after the newline.
7494
f2cad773
PE
74952011-08-27 Paul Eggert <eggert@cs.ucla.edu>
7496
7497 * ccl.c: Improve and simplify overflow checking (Bug#9196).
7498 (ccl_driver): Do not generate an out-of-range pointer.
7499 (Fccl_execute_on_string): Remove unnecessary check for
7500 integer overflow, noted by Stefan Monnier in
7501 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
7502 Remove a FIXME that didn't need fixing.
7503 Simplify the newly-introduced buffer reallocation code.
7504
0cae2cdb
JB
75052011-08-27 Juanma Barranquero <lekktu@gmail.com>
7506
7507 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
7508
5fc295a4 75092011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 7510
70c60eb2 7511 Integer and memory overflow issues (Bug#9196).
726e0ab1 7512
d31850da
PE
7513 * doc.c (get_doc_string): Rework so that
7514 get_doc_string_buffer_size is the actual buffer size, rather than
7515 being 1 less than the actual buffer size; this makes xpalloc more
7516 convenient.
7517
a69fbedb
PE
7518 * image.c (x_allocate_bitmap_record, cache_image):
7519 * xselect.c (Fx_register_dnd_atom):
7520 Simplify previous changes by using xpalloc.
7521
fe5c5d37
PE
7522 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
7523 since either will do and ptrdiff_t is convenient with xpalloc.
7524
0065d054
PE
7525 * charset.c (charset_table_size)
7526 (struct charset_sort_data.priority): Now ptrdiff_t.
7527 (charset_compare): Don't overflow if priorities differ greatly.
7528 (Fsort_charsets): Don't assume list length fits in int.
7529 Check for size-calculation overflow when allocating sort data.
7530 (syms_of_charset): Allocate an initial charset table that is
7531 just under 64 KiB, to avoid problems with glibc malloc and mmap.
7532
7533 * cmds.c (internal_self_insert): Check for size-calculation overflow.
7534
7535 * composite.h (struct composition.glyph_len): Now int, not unsigned.
7536 The actual value is always <= INT_MAX, and leaving it unsigned made
7537 overflow checking harder.
7538
7539 * dispextern.h (struct glyph_matrix.rows_allocated)
7540 (struct face_cache.size): Now ptrdiff_t, for convenience in use
7541 with xpalloc. The values are still always <= INT_MAX.
7542
7543 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
7544
7545 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
7546 (SAFE_NALLOCA): New macro.
7547
7548 * region-cache.c (struct boundary.pos, find_cache_boundary)
7549 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
7550 (set_cache_region, invalidate_region_cache)
7551 (revalidate_region_cache, know_region_cache, region_cache_forward)
7552 (region_cache_backward, pp_cache):
7553 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
7554 so that ptrdiff_t * can be passed to xpalloc.
7555 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
7556 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
7557 (pp_cache): Don't assume cache_len fits in int.
7558 * region-cache.h: Adjust extern decls to match.
7559
7560 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
7561 EMACS_INT, since either will do, for xpalloc.
7562
7563 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
7564 (xnmalloc, xnrealloc, xpalloc): New functions.
7565
726e0ab1
PE
7566 * bidi.c (bidi_shelve_header_size): New constant.
7567 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
7568 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
7569
51f30bc5 7570 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
7571 * buffer.c (overlays_at, overlays_in, record_overlay_string)
7572 (overlay_strings):
7573 Don't update size of array until after memory allocation succeeds,
7574 because xmalloc/xrealloc may not return.
0065d054
PE
7575 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
7576 now that we have proper integer overflow checking.
7577 (record_overlay_string, overlay_strings): Catch overflows when
7578 calculating size of overlay_str_buf.
726e0ab1 7579
0065d054
PE
7580 * callproc.c (Fcall_process): Check for size overflow when
7581 calculating size of args2.
7582 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
7583 Normally we prefer signed values, but sticking with ptrdiff_t would
7584 require adding more-complicated checks.
726e0ab1
PE
7585
7586 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
7587 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
7588 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 7589 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
7590
7591 * character.c (Fstring): Check for size-calculation overflow.
7592
7593 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
7594 unnecessary integer overflow. Check for size overflow.
7595 (encode_coding_object): Don't update size until xmalloc succeeds.
7596
7597 * composite.c (get_composition_id): Check for overflow in glyph
7598 length calculations.
7599
7600 Integer and memory overflow fixes for display code.
7601 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
7602 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
7603 (scrolling_window): Check for overflow in size calculations.
7604 (line_draw_cost, realloc_glyph_pool, add_row_entry):
7605 Don't assume glyph table len fits in int.
7606 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
7607 (row_table_size): Now ptrdiff_t, not int.
7608 (scrolling_window): Avoid overflow in size calculations.
7609 Don't update size until allocation succeeds.
7610 * fns.c (concat): Check for overflow in size calculations.
7611 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
7612 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7613 (NEXT_ALMOST_PRIME_LIMIT): New constant.
7614
7615 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
7616 (get_doc_string): Check for size calculation overflow.
7617 Don't update size until allocation succeeds.
7618 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
7619 EMACS_INT, where ptrdiff_t will do.
7620 (Fsubstitute_command_keys): Check for string overflow.
7621
7622 * editfns.c (set_time_zone_rule): Don't assume environment length
7623 fits in int.
7624 (message_length): Now ptrdiff_t, not int.
7625 (Fmessage_box): Don't update size until allocation succeeds.
7626 Don't assume message length fits in int.
7627 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
7628
0065d054
PE
7629 * emacs.c (main): Do not reallocate argv, since there is a null at
7630 the end that can be overwritten, and this way there's no need to
7631 worry about size-calculation overflow.
7632 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
7633
7634 * eval.c (init_eval_once, grow_specpdl): Don't update size until
7635 alloc succeeds.
7636 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
7637
7638 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
7639 (x_set_scroll_bar_width, x_figure_window_size):
7640 Check for integer overflow.
7641 (x_set_alpha): Do not assume XINT fits in int.
7642
7643 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
7644 This is for the members text_lines, text_cols, total_lines, total_cols,
7645 where the system imposes an 'int' limit.
7646
7647 * fringe.c (Fdefine_fringe_bitmap):
7648 Don't update size until alloc works.
7649
7650 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
7651 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
7652
7653 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
7654 Check for size-calculation overflow.
7655 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
7656 do, as we prefer signed integers.
7657 (id_to_widget.max_size, id_to_widget.used)
7658 (xg_store_widget_in_map, xg_remove_widget_from_map)
7659 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
7660 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
7661 Use and return ptrdiff_t, not int.
7662 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
7663 * gtkutil.h: Change prototypes to match the above.
7664
7665 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
7666 are duplicate now that they've been promoted to lisp.h.
7667 (x_allocate_bitmap_record, x_alloc_image_color)
7668 (make_image_cache, cache_image, xpm_load):
7669 Don't update size until alloc is done.
7670 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
7671 (x_detect_edges):
3256efce 7672 Check for size calculation overflow.
726e0ab1
PE
7673 (ct_colors_allocated_max): New constant.
7674 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
7675 overflow.
3256efce 7676
726e0ab1
PE
7677 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
7678 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
7679 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
7680 Use ptrdiff_t, not int, to count maps.
7681 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
7682 calculations. Don't update size until allocation succeeds.
7683 Redo calculations to avoid overflow.
726e0ab1
PE
7684 * keyboard.h: Change prototypes to match the above.
7685
7686 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
7687 to count maps.
7688 (current_minor_maps): Check for size calculation overflow.
7689 * keymap.h: Change prototypes to match the above.
7690
7691 * lread.c (read1, init_obarray): Don't update size until alloc done.
7692
7693 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
7694 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
7695
726e0ab1
PE
7696 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
7697 Now ptrdiff_t, not int.
7698 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
7699 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
7700
7701 * process.c (Fnetwork_interface_list): Check for overflow
7702 in size calculation.
7703
7704 * region-cache.c (move_cache_gap): Check for size calculation overflow.
7705
7706 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
7707 overflow. Don't bother calling xmalloc when xrealloc will do.
7708
7709 * search.c (Freplace_match): Check for size calculation overflow.
7710 (Fset_match_data): Don't assume list lengths fit in 'int'.
7711
7712 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
7713 for command line length. Do not attempt to address one before the
7714 beginning of an array, as that's not portable.
7715
7716 * term.c (max_frame_lines): Remove; unused.
7717 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
7718 not int.
7719 (encode_terminal_code, calculate_costs): Check for size
7720 calculation overflow.
7721 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
7722 table lengths and related sizes. Don't update size until alloc
7723 done. Redo calculations to avoid overflow.
7724 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
7725
7726 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
7727 subtracting pointers.
7728 (gobble_line): Check for overflow more carefully. Don't update size
7729 until alloc done.
7730
7731 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
7732 Don't update size until alloc done.
7733 Redo size calculations to avoid overflow.
7734 Check for size calculation overflow.
0065d054 7735 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
7736
7737 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
7738 Use ptrdiff_t, not int, for sizes.
7739 (store_mode_line_noprop_char): Don't update size until alloc done.
7740
0065d054
PE
7741 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
7742 Use ptrdiff_t, not int, for sizes.
7743 (Finternal_make_lisp_face, cache_face):
7744 Check for size calculation overflow.
7745 (cache_face): Treat size calculation overflows as if they were
7746 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
7747
7748 * xfns.c (x_encode_text, x_set_name_internal)
7749 (Fx_change_window_property): Use ptrdiff_t, not int, to count
7750 sizes, since they can exceed INT_MAX in size. Check for size
7751 calculation overflow.
7752
0065d054
PE
7753 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
7754 (xg_select): Check for size calculation overflow.
726e0ab1
PE
7755 Don't update size until alloc done.
7756
0065d054 7757 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 7758 as sprintf is limited to int lengths.
1d526e2f 7759
252c5ee1
PE
7760 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
7761 (X_LONG_MIN): New macros.
864d7ce7
PE
7762 Use them to make the following changes clearer.
7763 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
7764 This change doesn't affect the value now, but it may help remind
7765 future maintainers not to raise the value too much later.
7766 (SELECTION_QUANTUM): Remove, replacing with ...
7767 (selection_quantum): ... new function, which avoids overflow.
7768 All uses changed.
7769 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
7770 assumption that selection length fits in 'int'.
7771 (x_reply_selection_request, x_handle_selection_request)
7772 (x_get_window_property, receive_incremental_selection)
7773 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
7774 (lisp_data_to_selection_data, clean_local_selection_data):
7775 Use ptrdiff_t, not int, to record length of selection.
7776 (x_reply_selection_request, x_get_window_property)
7777 (receive_incremental_selection, x_property_data_to_lisp):
7778 Redo calculations to avoid overflow.
7779 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 7780 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
7781 something.
7782 (x_get_window_property, receive_incremental_selection)
7783 (lisp_data_to_selection_data, x_property_data_to_lisp):
7784 Check for size-calculation overflow.
7785 (x_get_window_property, receive_incremental_selection)
7786 (lisp_data_to_selection_data, Fx_register_dnd_atom):
7787 Don't store size until memory allocation succeeds.
7788 (x_get_window_property): Plug memory leak on memory exhaustion.
7789 Don't double-block input; malloc is safe here. Don't assume 2**34
7790 - 4 fits in unsigned long. Add an xassert to check
7791 XGetWindowProperty overflow. Be more careful about overflow
7792 calculations, and distinguish size from memory overflow better.
7793 (receive_incremental_selection): When tracing, don't assume
7794 unsigned int is less than INT_MAX.
7795 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
7796 harmful) conversions of unsigned short to int.
7797 (lisp_data_to_selection_data): Don't assume that integers
7798 in the range -65535 through -1 fit in an X unsigned short.
7799 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
7800 result parameters unless successful. Rely on cons_to_unsigned
7801 to report problems with elements; the old code wasn't right anyway.
7802 (x_check_property_data): Check for int overflow; we cannot use
7803 a wider type due to X limits.
7804 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
7805
726e0ab1 7806 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 7807
0065d054
PE
7808 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
7809 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
7810 (x_color_cells): Don't store size until memory allocation succeeds.
7811 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 7812 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
7813 (x_term_init): Don't assume length fits in int (sprintf is limited
7814 to int size).
bc18e09d 7815
ebfa62c0
PE
7816 Use ptrdiff_t for composition IDs.
7817 * character.c (lisp_string_width):
7818 * composite.c (composition_table_size, n_compositions)
7819 (get_composition_id, composition_gstring_from_id):
7820 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
7821 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
7822 * window.c (Frecenter):
7823 Use ptrdiff_t, not int, for composition IDs.
7824 * composite.c (get_composition_id): Check for integer overflow.
7825 * composite.h: Adjust prototypes to match the above changes.
7826
d3411f89
PE
7827 Use ptrdiff_t for hash table indexes.
7828 * category.c (hash_get_category_set):
7829 * ccl.c (ccl_driver):
7830 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
7831 * coding.c (coding_system_charset_list, detect_coding_system):
7832 * coding.h (struct coding_system.id):
7833 * composite.c (get_composition_id, gstring_lookup_cache):
7834 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
7835 * image.c (xpm_get_color_table_h):
7836 * lisp.h (hash_lookup, hash_put):
7837 * minibuf.c (Ftest_completion):
7838 Use ptrdiff_t for hash table indexes, not int (which is too
7839 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
7840 32-bit --with-wide-int hosts).
7841
e097a6fa
PE
7842 * charset.c (Fdefine_charset_internal): Check for integer overflow.
7843 Add a FIXME comment about memory leaks.
7844 (syms_of_charset): Don't assume xmalloc returns.
7845
5637687f
PE
7846 Don't assume that stated character widths fit in int.
7847 * character.c (Fchar_width, c_string_width, lisp_string_width):
7848 * character.h (CHAR_WIDTH):
7849 * indent.c (MULTIBYTE_BYTES_WIDTH):
7850 Use sanitize_char_width to avoid undefined and/or bad behavior
7851 with outlandish widths.
a66cfb1c 7852 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
7853 now that we have two such functions. All uses changed.
7854 (sanitize_char_width): New inline function.
7855
a2271ba2
PE
7856 Don't assume that tab-width fits in int.
7857 * character.h (sanitize_width): New inline function.
7858 (SANE_TAB_WIDTH): New macro.
7859 (ASCII_CHAR_WIDTH): Use it.
7860 * indent.c (sane_tab_width): Remove. All uses replaced by
7861 SANE_TAB_WIDTH (current_buffer).
7862 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
7863
18c52557
PE
7864 * fileio.c: Integer overflow issues with file modes.
7865 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
7866
caeeedc1
PE
7867 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
7868 Remove unreachable code.
7869 (read_hex, load_charset_map_from_file): Check for integer overflow.
7870
6df6ae42 7871 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
7872 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
7873 (x_send_scroll_bar_event): Likewise. Check that the size does not
7874 exceed limits imposed by XClientMessageEvent, as well as the usual
7875 ptrdiff_t and size_t limits.
7876
b13995db
PE
7877 * keyboard.c: Overflow, signedness and related fixes.
7878 (make_lispy_movement): Use same integer type in forward decl
7879 that is used in the definition.
7880 (read_key_sequence, keyremap_step):
7881 Change bufsize argument back to int, undoing my 2011-03-30 change.
7882 We prefer signed types, and int is wide enough here.
7883 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
7884 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
7885 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
7886 length, not size_t. Use ptrdiff_t for index, not int.
7887 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
7888 possibility of integer overflow.
7889
13464394
PE
7890 Overflow, signedness and related fixes for images.
7891
7892 * dispextern.h (struct it.stack[0].u.image.image_id)
7893 (struct_it.image_id, struct image.id, struct image_cache.size)
7894 (struct image_cache.used, struct image_cache.ref_count):
7895 * gtkutil.c (update_frame_tool_bar):
7896 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
7897 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
7898 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
7899 * nsmenu.m (update_frame_tool_bar):
7900 * xdisp.c (calc_pixel_width_or_height):
7901 * xfns.c (image_cache_refcount):
7902 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
7903 on typical 64-bit hosts.
7904
7905 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7906 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
7907 Omit unnecessary casts to int.
7908 (parse_image_spec): Check that integers fall into 'int' range
7909 when the callers expect that.
7910 (image_ascent): Redo ascent calculation to avoid int overflow.
7911 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
7912 (lookup_image): Remove unnecessary tests.
7913 (xbm_image_p): Locals are now of int, not EMACS_INT,
7914 since parse_image_check makes sure they fit into int.
7915 (png_load, gif_load, svg_load_image):
7916 Prefer int to unsigned where either will do.
7917 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
7918 old tiff_error_handler and tiff_warning_handler.
7919 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
7920 stack buffer overflows. It uses only the features of vsnprintf
7921 that are common to both POSIX and native Microsoft.
7922 (tiff_error_handler, tiff_warning_handler): Use it.
7923 (tiff_load, gif_load, imagemagick_load_image):
7924 Don't assume :index value fits in 'int'.
7925 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
7926 (imagemagick_load_image): Check that crop parameters fit into
7927 the integer types that MagickCropImage accepts. Don't assume
7928 Vimagemagick_render_type has a nonnegative value. Don't assume
7929 size_t fits in 'long'.
7930 (gs_load): Use printmax_t to print the widest integers possible.
7931 Check for integer overflow when computing image height and width.
7932
c11821d4
EZ
79332011-08-26 Eli Zaretskii <eliz@gnu.org>
7934
7935 * xdisp.c (redisplay_window): Don't force window start if point
7936 will be invisible in the resulting window. (Bug#9324)
7937
0c95fcf7
EZ
79382011-08-25 Eli Zaretskii <eliz@gnu.org>
7939
7940 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
7941 the display spec is of the form `(space ...)'.
7942 (handle_display_spec): Return the value returned by
7943 handle_single_display_spec, not just 1 or zero.
7944 (handle_single_display_spec): If the display spec is of the form
7945 `(space ...)', and specifies display in the text area, return 2
7946 rather than 1.
fee65a97 7947 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
7948 accurately, and prefer exact match for point under bidi.
7949 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
7950
7951 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
7952 into disp_prop; all users changed.
7953
7954 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
7955 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
7956 for the text covered by the display property.
7957
e4ed06f1
CY
79582011-08-25 Chong Yidong <cyd@stupidchicken.com>
7959
7960 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
7961 Change return value to nil.
7962 (Frecord_buffer): Delete unused function.
7963
f67cdd7f
EZ
79642011-08-24 Eli Zaretskii <eliz@gnu.org>
7965
5980d4c6
EZ
7966 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
7967 buffers, return left-to-right.
8610fe8b
EZ
7968 (set_cursor_from_row): Consider candidate row a win if its glyph
7969 represents a newline and point is on that newline. Fixes cursor
7970 positioning on the newline at EOL of R2L text within L2R
7971 paragraph, and vice versa.
7972 (try_cursor_movement): Check continued rows, in addition to
7973 continuation rows. Fixes unwarranted scroll when point enters a
7974 continued line of R2L text within an L2R paragraph, or vice versa.
7975 (cursor_row_p): Consider the case of point being equal to
7976 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
7977 from the end of a short line to the beginning of a continued line
7978 of R2L text within L2R paragraph.
7979 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
7980 composed characters.
5980d4c6 7981
f67cdd7f
EZ
7982 * bidi.c (bidi_check_type): Use xassert.
7983 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
7984 members.
7985
bca633fb
EZ
79862011-08-23 Eli Zaretskii <eliz@gnu.org>
7987
7988 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
7989 a character.
7990
4a5885a7
CY
79912011-08-23 Chong Yidong <cyd@stupidchicken.com>
7992
7993 * nsfont.m (ns_otf_to_script): Fix typo.
7994
0902a04e
KH
79952011-08-22 Kenichi Handa <handa@m17n.org>
7996
7997 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
7998 extra slot even if the purpose is char-code-property-table.
7999
1a2e6670
EZ
80002011-08-23 Eli Zaretskii <eliz@gnu.org>
8001
8ddde651
EZ
8002 * xdisp.c (redisplay_window): When computing centering_position,
8003 account for the height of the header line. (Bug#8874)
8004
425cc014
EZ
8005 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
8006 instead of CHAR_TO_BYTE. Fixes a crash when a completion
8007 candidate is selected by the mouse, and that candidate has a
8008 composed character under the mouse.
8009
1a2e6670
EZ
8010 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
8011 coordinates reported by pos-visible-in-window-p for a composed
8012 character in column zero.
8013
8b76d6f8
SM
80142011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
8015
8016 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
8017
dac347dd
EZ
80182011-08-22 Eli Zaretskii <eliz@gnu.org>
8019
8020 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
8021 consider it a hit if to_charpos is anywhere in the range of the
8022 composed buffer positions.
8023
e013fb34
CY
80242011-08-22 Chong Yidong <cyd@stupidchicken.com>
8025
8026 * image.c (gif_load): Don't assume that each subimage has the same
8027 dimensions as the base image. Handle disposal method that is
8028 "undefined" by the gif spec (Bug#9335).
8029
bd1ba3e8
CY
80302011-08-20 Chong Yidong <cyd@stupidchicken.com>
8031
8032 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 8033 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 8034
54a1215b
EZ
80352011-08-19 Eli Zaretskii <eliz@gnu.org>
8036
823564e5
EZ
8037 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
8038 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
8039 from an Org mode buffer to a Speedbar frame.
8040
54a1215b
EZ
8041 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
8042 a composition, take its buffer position from IT->cmp_it.charpos.
8043 Fixes cursor positioning at the beginning of a line that begins
8044 with a composed character.
8045
9778ebcc
EZ
80462011-08-18 Eli Zaretskii <eliz@gnu.org>
8047
0be6ee06
EZ
8048 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
8049 character bidirectional type, use STRONG_L instead. Fixes crashes
8050 in a buffer produced by `describe-categories'.
8051
9778ebcc
EZ
8052 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
8053 members before the level stack, so they would be saved and
8054 restored when copying iterator state. Fixes incorrect reordering
8055 around TABs covered by display properties.
8056
156bffbe
AS
80572011-08-18 Andreas Schwab <schwab@linux-m68k.org>
8058
6b02f655 8059 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 8060
72ad093b
CY
80612011-08-17 Chong Yidong <cyd@stupidchicken.com>
8062
8063 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
8064 (internal_condition_case_2, internal_condition_case_n):
8065 Remove unnecessary aborts (Bug#9081).
72ad093b 8066
35774242
EZ
80672011-08-17 Eli Zaretskii <eliz@gnu.org>
8068
8069 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
8070 has no `load' handler, try opening the file locally. (Bug#9311)
8071
db76dd85
KB
80722011-08-16 Ken Brown <kbrown@cornell.edu>
8073
8074 * gmalloc.c: Expand comment.
8075
b215eee5
EZ
80762011-08-16 Eli Zaretskii <eliz@gnu.org>
8077
8078 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
8079 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
8080
a4579d33
KB
80812011-08-16 Ken Brown <kbrown@cornell.edu>
8082
8083 Fix memory allocation problems in Cygwin build (Bug#9273).
8084
8085 * unexcw.c ( __malloc_initialized): Declare external variable.
8086 (fixup_executable): Force the dumped emacs to reinitialize malloc.
8087
8b76d6f8
SM
8088 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
8089 New variables.
a4579d33
KB
8090 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
8091 dumped emacs.
8092 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
8093 in the static heap.
8094 [CYGWIN] (special_realloc): New function.
8095 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
8096 requests to realloc storage in the static heap.
8097
3ebec551
PE
80982011-08-15 Paul Eggert <eggert@cs.ucla.edu>
8099
8100 * bidi.c (bidi_initialize): Remove unused local.
8101
9fd8be00
EZ
81022011-08-15 Eli Zaretskii <eliz@gnu.org>
8103
6b02f655
SM
8104 * bidimirror.h:
8105 * biditype.h: Remove file.
8106 * makefile.w32-in ($(BLD)/bidi.$(O)):
8107 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
8108
8109 * dispextern.h: Fix a typo in the comment to bidi_type_t.
8110
8111 * chartab.c: Improve commentary for the uniprop_table API.
8112
32413314
EZ
8113 * bidi.c (bidi_paragraph_init): Support zero value of
8114 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
8115 (bidi_initialize): Use uniprop_table instead of including
8116 biditype.h and bidimirror.h.
32413314 8117
9fd8be00
EZ
8118 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
8119 coordinates of the iterator when restoring from ppos_it.
8120 (Bug#9296)
8121
5cf2b69b
KH
81222011-08-14 Kenichi Handa <handa@m17n.org>
8123
8124 * process.c (create_process): Call setup_process_coding_systems
72ad093b 8125 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 8126
daf17d00
EZ
81272011-08-14 Eli Zaretskii <eliz@gnu.org>
8128
8129 * xdisp.c (move_it_in_display_line_to): Don't invoke
8130 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
8131 ppos_it. Fixes vertical cursor motion when line beginning is
8132 covered by an image. (Bug#9296)
8133
08e3161a
JD
81342011-08-14 Jan Djärv <jan.h.d@swipnet.se>
8135
8136 * nsterm.h (ns_run_ascript): Declare.
8137 (NSAPP_DATA2_RUNASSCRIPT): Define.
8138
8139 * nsfns.m (as_script, as_result, as_status): New static variables.
8140 (ns_run_ascript): New function.
5e617bc2 8141 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
8142 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
8143 the event loop. Get status from as_status (Bug#7276).
8144
8145 * nsterm.m (sendEvent): If event is NSApplicationDefined and
8146 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
8147 the event loop (Bug#7276).
8148
a3720aa2
AS
81492011-08-14 Andreas Schwab <schwab@linux-m68k.org>
8150
8151 * gnutls.c (QCgnutls_bootprop_priority)
8152 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
8153 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
8154 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
8155 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
8156 (QCgnutls_bootprop_verify_hostname_error)
8157 (QCgnutls_bootprop_callbacks_verify): Rename from
8158 Qgnutls_bootprop_..., all uses changed.
8159
8160 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
8161 uses changed.
8162
0a0d27fb
PE
81632011-08-14 Paul Eggert <eggert@cs.ucla.edu>
8164
19d5c50c
PE
8165 * xfaces.c (Qframe_set_background_mode): Now static.
8166 * dispextern.h (Qframe_set_background_mode): Remove decl.
8167
0a0d27fb
PE
8168 * process.c (Fnetwork_interface_info): Declare local only if needed.
8169
377538cb
JD
81702011-08-13 Jan Djärv <jan.h.d@swipnet.se>
8171
8172 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
8173 (Fnetwork_interface_list): Allocate in increments of bytes instead
8174 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
8175 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
8176 sockaddr.
8177 (struct ifflag_def): notrailers is smart on OSX.
8178 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
8179 Get hardware address with getifaddrs if available.
8180
08fff70c
EZ
81812011-08-12 Eli Zaretskii <eliz@gnu.org>
8182
8183 * xdisp.c (iterate_out_of_display_property): xassert that
8184 IT->position is set to within IT->object's boundaries. Break from
8185 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
8186 when IT->position is set up wrongly due to some bug.
8187 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
8188 (push_display_prop): Allow GET_FROM_STRING as IT->method on
8189 entry. Force push_it to save on the stack the current
8190 buffer/string position, to be restored by pop_it. Fix flags in
8191 the iterator structure wrt the object coming from a display
8192 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
8193 properties. (Bug#9284)
8194
7be1c708 81952011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 8196
7be1c708
CY
8197 * fontset.c (fontset_get_font_group): Add proper type checks.
8198 (Bug#9172)
aac0c6e3 8199
7be1c708 82002011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 8201
7be1c708
CY
8202 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
8203 and LC_VERSION_MIN_MACOSX.
8204 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
8205 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 8206
97bb72a6
EZ
82072011-08-08 Eli Zaretskii <eliz@gnu.org>
8208
8209 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
8210 no-display-properties-and-no-overlays under bidi display.
8211 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 8212 properties and overlays.
97bb72a6 8213
d5617611
CY
82142011-08-08 Chong Yidong <cyd@stupidchicken.com>
8215
37e11a63
CY
8216 * editfns.c (Fset_time_zone_rule): Document relationship with the
8217 setenv function.
8218
d5617611
CY
8219 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
8220 the font entity extracted from the cache (Bug#8109).
8221
58872834
CY
82222011-08-07 Chong Yidong <cyd@stupidchicken.com>
8223
8224 * composite.c (autocmp_chars): Don't reset point. That is done by
8225 restore_point_unwind (Bug#5984).
8226
75bfc667
JL
82272011-08-07 Juri Linkov <juri@jurta.org>
8228
8229 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
8230 to show the arg `TIME' instead of `TIMEVAL'.
8231
d1410150
EZ
82322011-08-06 Eli Zaretskii <eliz@gnu.org>
8233
8234 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
8235 display property strides EOL and includes a newline, as in
8236 longlines-mode. (Bug#9254)
75b771e4
EZ
8237 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
8238 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
8239
8240 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
8241 is non-zero, even if the data buffer is NULL. Fixes a crash in
8242 vertical-motion with longlines-mode. (Bug#9254)
8243
35928349
EZ
82442011-08-05 Eli Zaretskii <eliz@gnu.org>
8245
ec7cc85b
EZ
8246 * bidi.c <bidi_cache_total_alloc>: Now static.
8247 (bidi_initialize): Initialize bidi_cache_total_alloc.
8248
8b76d6f8 8249 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
8250 cache. (Bug#9221)
8251
8252 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
8253 amount allocated this far in `bidi_cache_total_alloc'.
8254 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
8255 non-zero, only free the data buffer without restoring the cache
8256 contents. All callers changed.
8257
8258 * dispextern.h (bidi_unshelve_cache): Update prototype.
8259
8260 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
8261 (move_it_in_display_line, move_it_to)
8262 (move_it_vertically_backward, move_it_by_lines): Replace the call
8263 to xfree to an equivalent call to bidi_unshelve_cache.
8264 (move_it_in_display_line_to): Fix logic of returning
412b6358 8265 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 8266
e2e2423b
EZ
82672011-08-05 Eli Zaretskii <eliz@gnu.org>
8268
8269 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
8270 came from a string character with a `cursor' property. (Bug#9229)
8271
ae9e757a
JD
82722011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8273
8274 * Makefile.in (LIB_PTHREAD): New variable.
8275 (LIBES): Add LIB_PTHREAD (Bug#9216).
8276
8277 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
8278 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
8279
213bd7f2
AS
82802011-08-04 Andreas Schwab <schwab@linux-m68k.org>
8281
6b02f655 8282 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 8283
99aaf75f
JD
82842011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8285
8286 * xterm.c (x_find_topmost_parent): New function.
8287 (x_set_frame_alpha): Find topmost parent window with
8288 x_find_topmost_parent and set the property there also (bug#9181).
8289 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
8290
c74e9d86
PE
82912011-08-04 Paul Eggert <eggert@cs.ucla.edu>
8292
8293 * callproc.c (Fcall_process): Avoid vfork clobbering
8294 the local vars buffer, coding_systems, current_dir.
8295
640c8776
SM
82962011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
8297
8298 * keymap.c (Fmake_composed_keymap): Move to subr.el.
8299
f26d0e4c
PE
83002011-08-03 Paul Eggert <eggert@cs.ucla.edu>
8301
8a10d76c
PE
8302 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
8303 so that it is not optimized away.
8304
f26d0e4c
PE
8305 * xdisp.c (compute_display_string_pos): Remove unused local.
8306
55439c61
EZ
83072011-08-02 Eli Zaretskii <eliz@gnu.org>
8308
8309 Fix slow cursor motion and scrolling in large buffers with
8310 selective display, like Org Mode buffers. (Bug#9218)
8311
8312 * dispextern.h (struct bidi_it): New member disp_prop_p.
8313
8314 * xdisp.c: Remove one-slot cache of display string positions.
8315 (compute_display_string_pos): Accept an additional argument
5e617bc2 8316 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
8317 for a display string or property. If found, set DISP_PROP_P
8318 non-zero.
8319
8320 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
8321 DISP_PROP_P, and pass it to compute_display_string_pos.
8322 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
8323 non-zero. All callers of bidi_fetch_char changed.
8324
fb33fa43
SM
83252011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
8326
8327 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
8328
b099e063
DM
83292010-12-03 Don March <don@ohspite.net>
8330
8331 * keymap.c (Fdefine_key): Fix non-prefix key error message when
8332 last character M-[char] is translated to ESC [char] (bug#7541).
8333
5cc7f7af
KH
83342011-08-02 Kenichi Handa <handa@m17n.org>
8335
d0fffa3f 8336 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
8337
8338 * chartab.c (uniprop_table): Make it non-static.
8339
525d5e6e
EZ
83402011-08-01 Eli Zaretskii <eliz@gnu.org>
8341
8342 * xdisp.c (forward_to_next_line_start): Accept additional argument
8343 BIDI_IT_PREV, and store into it the state of the bidi iterator had
8344 on the newline.
8345 (reseat_at_next_visible_line_start): Use the bidi iterator state
8346 returned by forward_to_next_line_start to restore the state of
8347 it->bidi_it after backing up to previous newline. (Bug#9212)
8348
31011111
AS
83492011-07-30 Andreas Schwab <schwab@linux-m68k.org>
8350
8351 * regex.c (re_comp): Protoize.
8352 (re_exec): Fix return type.
8353 (regexec): Fix type of `ret'. (Bug#9203)
8354
476371c4
PE
83552011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8356
e5d76069
PE
8357 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
8358 This is needed if max-image-size is a floating-point number.
8359
9a79b20c
AS
83602011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8361
8362 * print.c (print_object): Print empty symbol as ##.
8363
8364 * lread.c (read1): Read ## as empty symbol.
8365
d8c2fa78
AA
83662011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
8367
8368 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
8369 setting frame foreground color (Bug#9175).
8370 (x_set_background_color): Likewise.
8371
ffe57a7a
AA
8372 * nsmenu.m (-setText): Size tooltip dimensions precisely to
8373 contents (Bug#9176).
8374 (EmacsTooltip -init): Remove bezels and add shadows to
8375 tooltip windows.
8376
bf3492a5
AA
8377 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
8378 or scroll bar (Bug#8470).
8379
d55e9c53
AA
8380 * nsfont.m (nsfont_open): Remove assignment to voffset and
8381 unnecessary vars hshink, expand, hd, full_height, min_height.
8382 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
8383
8384 * nsterm.h (nsfont_info): Remove voffset field.
8385
d8c2fa78 83862011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
8387
8388 Implement strike-through and overline on NextStep (Bug#8863).
8389
8390 * nsfont.m (nsfont_open): Use underline position provided by font,
8391 instead of hard-coded value of 2.
8392 (nsfont_draw): Call ns_draw_text_decoration instead.
8393
8394 * nsterm.h: Add declaration for ns_draw_text_decoration.
8395
8396 * nsterm.m (ns_draw_text_decoration): New function for drawing
8397 underline, overline, and strike-through.
8398 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
8399 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 8400 accommodate underlining, etc.
4843aac3 8401
4cc60b9b
EZ
84022011-07-28 Eli Zaretskii <eliz@gnu.org>
8403
bc7ece87
EZ
8404 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
8405 default.
4cc60b9b 8406
476371c4
PE
84072011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8408
66606eea
PE
8409 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
8410 Without this fix, if a signal arrives just after memory fills up,
8411 'malloc' might be invoked reentrantly.
8412
476371c4
PE
8413 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
8414 In other words, assume that every image size is allowed, on non-X
8415 hosts. This assumption is probably wrong, but it lets Emacs compile.
8416
f3fcc40d
AS
84172011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8418
8419 * regex.c (re_iswctype): Convert return values to boolean.
8420
350c992f
EZ
84212011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
8422
8423 * xdisp.c (compute_display_string_pos): Don't use cached display
8424 string position if the buffer had its restriction changed.
8425 (Bug#9184)
8426
5266b4bb
PE
84272011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8428
8429 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8430
2573a837 84312011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 8432
41f55ccd 8433 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 8434
39e378da
PE
8435 * bidi.c: Integer size and overflow fixes.
8436 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
8437 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
8438 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8439 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
8440 (bidi_find_other_level_edge):
8441 Use ptrdiff_t instead of EMACS_INT where either will do.
8442 This works better on 32-bit hosts configured --with-wide-int.
8443 (bidi_cache_ensure_space): Check for size-calculation overflow.
8444 Use % rather than repeated addition, for better worst-case speed.
8445 Don't set bidi_cache_size until after xrealloc returns, because it
8446 might not return.
8447 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
8448 (bidi_cache_ensure_space): Also check that the bidi cache size
8449 does not exceed that of the largest Lisp string or buffer. See Eli
8450 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 8451
5e927815
PE
8452 * alloc.c (__malloc_size_t): Remove.
8453 All uses replaced by size_t. See Andreas Schwab's note
8454 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
8455
ca4aa935
PE
8456 * image.c: Improve checking for integer overflow.
8457 (check_image_size): Assume that f is nonnull, since
8458 it is always nonnull in practice. This is one less thing to
8459 worry about when checking for integer overflow later.
8460 (x_check_image_size): New function, which checks for integer
8461 overflow issues inside X.
8462 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
8463 This removes the need for a memory_full check.
8464 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
8465 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
8466 (xbm_read_bitmap_data): Change locals back to 'int', since
8467 their values must fit in 'int'.
8468 (xpm_load_image, png_load, tiff_load):
8469 Invoke x_create_x_image_and_pixmap earlier,
8470 to avoid much needless work if the image is too large.
8471 (tiff_load): Treat overly large images as if
8472 x_create_x_image_and_pixmap failed, not as malloc failures.
8473 (gs_load): Use x_check_image_size.
8474
5f8f9cc2
PE
8475 * gtkutil.c: Omit integer casts.
8476 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
8477 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
8478
5adf60bc
PE
8479 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
8480
c8907a93
PE
8481 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
8482 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
8483 would wrongly return t on a 64-bit host.
8484
e3c25c68
PE
8485 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
8486 The plain *_OVERFLOW macros run afoul of GCC bug 49705
8487 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
8488 and therefore cause GCC to emit a bogus diagnostic in some cases.
8489
3f791afe
PE
8490 * image.c: Integer signedness and overflow and related fixes.
8491 This is not an exhaustive set of fixes, but it's time to
8492 record what I've got.
8493 (lookup_pixel_color, check_image_size): Remove redundant decls.
8494 (check_image_size): Don't assume that arbitrary EMACS_INT values
8495 fit in 'int', or that arbitrary 'double' values fit in 'int'.
8496 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
8497 (tiff_load, imagemagick_load_image):
8498 Check for overflow in size calculations.
8499 (x_create_x_image_and_pixmap): Remove unnecessary test for
8500 xmalloc returning NULL; that can't happen.
8501 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
8502 (xpm_color_bucket): Use better integer hashing function.
8503 (xpm_cache_color): Don't possibly over-allocate memory.
8504 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
8505 (gif_memory_source):
8506 Use ptrdiff_t, not int or size_t, to record sizes.
8507 (png_load): Don't assume values greater than 2**31 fit in 'int'.
8508 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
8509 either works, as we prefer signed integers.
8510 (tiff_read_from_memory, tiff_write_from_memory):
8511 Return tsize_t, not size_t, since that's what the TIFF API wants.
8512 (tiff_read_from_memory): Don't fail simply because the read would
8513 go past EOF; instead, return a short read.
8514 (tiff_load): Omit no-longer-needed casts.
8515 (Fimagemagick_types): Don't assume size fits into 'int'.
8516
3cc5a532
PE
8517 Improve hashing quality when configured --with-wide-int.
8518 * fns.c (hash_string): New function, taken from sxhash_string.
8519 Do not discard information about ASCII character case; this
8520 discarding is no longer needed.
8521 (sxhash-string): Use it. Change sig to match it. Caller changed.
8522 * lisp.h: Declare it.
8523 * lread.c (hash_string): Remove, since we now use fns.c's version.
8524 The fns.c version returns a wider integer if --with-wide-int is
8525 specified, so this should help the quality of the hashing a bit.
8526
b312a492
PE
8527 * emacs.c: Integer overflow minor fix.
8528 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
8529 Define only if GNU_LINUX.
8530 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
8531
dfd153ae
PE
8532 * dispnew.c: Integer signedness and overflow fixes.
8533 Remove unnecessary forward decls, that were a maintenance hassle.
8534 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
8535 All uses changed.
8536 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
8537 (scrolling_window): Use ptrdiff_t, not int, for byte count.
8538 (prepare_desired_row, line_draw_cost):
8539 Use int, not unsigned, where either works.
8540 (save_current_matrix, restore_current_matrix):
8541 Use ptrdiff_t, not size_t, where either works.
8542 (init_display): Check for overflow more accurately, and without
8543 relying on undefined behavior.
8544
a81d11a3
PE
8545 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
8546 Remove, replacing with the new symbols in lisp.h. All uses changed.
8547 * fileio.c (make_temp_name):
8548 * filelock.c (lock_file_1, lock_file):
8549 * xdisp.c (message_dolog):
8550 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
8551 Use pMd etc. instead.
8552 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
8553 replacing the pWIDE etc. symbols removed from editfns.c.
8554
3300e6fd
PE
8555 * keyboard.h (num_input_events): Now uintmax_t.
8556 This is (very slightly) less likely to mess up due to wraparound.
8557 All uses changed.
8558
fd05c7e9
PE
8559 * buffer.c: Integer signedness fixes.
8560 (alloc_buffer_text, enlarge_buffer_text):
8561 Use ptrdiff_t rather than size_t when either will do, as we prefer
8562 signed integers.
8563
903fe15d
PE
8564 * alloc.c: Integer signedness and overflow fixes.
8565 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
8566 (__malloc_size_t): Default to size_t, not to int.
8567 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
8568 (Fgarbage_collect, mark_object_loop_halt, mark_object):
8569 Prefer ptrdiff_t to size_t when either would do, as we prefer
8570 signed integers.
8571 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
8572 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
8573 Now const. Initialize with values that are in range even if char
8574 is signed.
8575 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
8576 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
8577 These functions do the right thing with sizes > 2**32.
8578 (check_depth): Now ptrdiff_t, not int.
8579 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
8580 Adjust to new way of storing sizes. Check for size overflow bugs
8581 in rest of code.
8582 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
8583 slightly wrong anyway, as it missed one instance of
8584 XMALLOC_OVERRUN_CHECK_OVERHEAD.
8585 (refill_memory_reserve): Omit needless cast to size_t.
8586 (mark_object_loop_halt): Mark as externally visible.
8587
ac82cc6a
PE
8588 * xselect.c: Integer signedness and overflow fixes.
8589 (Fx_register_dnd_atom, x_handle_dnd_message):
8590 Use ptrdiff_t, not size_t, since we prefer signed.
8591 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
8592 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
8593 x_dnd_atoms_size and x_dnd_atoms_length.
8594
c2d1e36d
PE
8595 * doprnt.c: Prefer signed to unsigned when either works.
8596 * eval.c (verror):
8597 * doprnt.c (doprnt):
8598 * lisp.h (doprnt):
8599 * xdisp.c (vmessage):
8600 Use ptrdiff_t, not size_t, when using or implementing doprnt,
8601 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
8602 prefer signed arithmetic to avoid comparison confusion.
8603 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
8604 but is a bit tricky.
8605
0e926e56
PE
8606 Assume freestanding C89 headers, string.h, stdlib.h.
8607 * data.c, doprnt.c, floatfns.c, print.c:
8608 Include float.h unconditionally.
8609 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
8610 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
8611 * regex.c: Likewise for stddef.h, string.h.
8612 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
8613 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
8614 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
8615 (STDC_HEADERS): Remove obsolete defines.
8616 * sysdep.c: Include limits.h unconditionally.
8617
9cfdb3ec
PE
8618 Assume support for memcmp, memcpy, memmove, memset.
8619 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
8620 * regex.c (memcmp, memcpy):
8621 Remove; we assume C89 now.
8622
8623 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
8624 (__malloc_safe_bcopy): Remove; no longer needed.
8625
cf950e6b 8626 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
8627 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
8628 well either way, and we prefer signed to unsigned.
8629
dbf38e02
LMI
86302011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
8631
8632 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
8633 closes the connection while we're reading (bug#9182).
8634
d6f0886c 86352011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 8636
d6f0886c
JD
8637 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
8638 are specified (Bug#9168).
24e0f6b1 8639
2eb1f9e6
PE
86402011-07-25 Paul Eggert <eggert@cs.ucla.edu>
8641
8642 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
8643 Found by GCC static checking and --with-wide-int on a 32-bit host.
8644
22381272 86452011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
8646
8647 * xdisp.c (compute_display_string_pos): Fix logic of caching
8648 previous display string position. Initialize cached_prev_pos to
8649 -1. Fixes slow-down at the beginning of a buffer.
8650
f25e39b4
EZ
86512011-07-24 Eli Zaretskii <eliz@gnu.org>
8652
8653 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
8654 for attrs[LFACE_FONTSET_INDEX].
8655
04c4b52e
PE
86562011-07-23 Paul Eggert <eggert@cs.ucla.edu>
8657
8658 * xml.c (parse_region): Remove unused local
8659 that was recently introduced.
8660
c1734fbd
EZ
86612011-07-23 Eli Zaretskii <eliz@gnu.org>
8662
be18c5a5
EZ
8663 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
8664 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
8665
c1734fbd
EZ
8666 * xdisp.c (move_it_in_display_line_to): Record the best matching
8667 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
8668 exit if none of the characters scanned was an exact match.
8669 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
8670 when exact match is impossible due to invisible text, and the
8671 lines are truncated.
8672
a258d627
JD
86732011-07-23 Jan Djärv <jan.h.d@swipnet.se>
8674
8675 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
8676 for OSX >= 10.7.
8677
b6d5a689
EZ
86782011-07-22 Eli Zaretskii <eliz@gnu.org>
8679
0f74f785
EZ
8680 Fix a significant slow-down of cursor motion with C-n, C-p,
8681 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
8682 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 8683 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
8684 (next_element_from_buffer): Call compute_stop_pos_backwards to
8685 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
8686 base_level_stop.
8687 (reseat): Don't look for prev_stop, as that could mean a very long
8688 run.
8689 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
8690 <cached_disp_overlay_modiff>: Cache for last found display string
8691 position.
551918c1 8692 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
8693 about the same buffer in the same area of character positions, and
8694 the buffer wasn't changed since the time the display string
8695 position was cached.
551918c1 8696
b2d0c91a
EZ
86972011-07-22 Eli Zaretskii <eliz@gnu.org>
8698
8699 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
8700 is an integer, which is important for empty lines. (Bug#9149)
8701
043604ee
CY
87022011-07-22 Chong Yidong <cyd@stupidchicken.com>
8703
8704 * frame.c (Fmodify_frame_parameters): In tty case, update the
8705 default face if necessary (Bug#4238).
8706
da4adb04
CY
87072011-07-21 Chong Yidong <cyd@stupidchicken.com>
8708
8709 * editfns.c (Fstring_to_char): No need to explain what a character
8710 is in the docstring (Bug#6576).
8711
9abd0532
LMI
87122011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8713
8714 * xml.c (parse_region): Make sure we always return a tree.
8715
36881d16
HK
87162011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
8717
8718 * xml.c (parse_region): If a document contains only comments,
8719 return that, too.
8720
1e98674d
LMI
87212011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8722
8723 * xml.c (make_dom): Return comments, too.
8724
590bd467
PE
87252011-07-19 Paul Eggert <eggert@cs.ucla.edu>
8726
8727 Port to OpenBSD.
8728 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
8729 and the surrounding thread.
8730 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
8731 rather than fgets, and retry after EINTR. Otherwise, 'emacs
8732 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
8733 timer goes off.
8734 * s/openbsd.h (BROKEN_SIGIO): Define.
8735 * unexelf.c (unexec) [__OpenBSD__]:
8736 Don't update the .mdebug section of the Alpha COFF symbol table.
8737
f41628b2
LMI
87382011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
8739
8740 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
8741 (bug#8460).
8742
b59b67c5
PE
87432011-07-18 Paul Eggert <eggert@cs.ucla.edu>
8744
15e3a074
PE
8745 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
8746 This fixes some race conditions on the permissions of any newly
8747 created file.
8748
41bed37d
PE
8749 * alloc.c (valid_pointer_p): Use pipe, not open.
8750 This fixes some permissions issues when debugging.
8751
b59b67c5
PE
8752 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
8753 If fchown fails to set both uid and gid, try to set just gid,
8754 as that is sometimes allowed. Adjust the file's mode to eliminate
8755 setuid or setgid bits that are inappropriate if fchown fails.
8756
925a6be7
SM
87572011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
8758
8759 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
8760 to compare Lisp_Objects.
8761 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
8762 global_gnutls_log_level, don't mistake it for a Lisp_Object.
8763 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
8764
52968808
AS
87652011-07-17 Andreas Schwab <schwab@linux-m68k.org>
8766
0a6a104b
AS
8767 * lread.c (read_integer): Unread even EOF character.
8768 (read1): Likewise. Properly record start position of symbol.
8769
52968808
AS
8770 * lread.c (read1): Read `#:' as empty uninterned symbol if no
8771 symbol character follows.
8772
9e381cdd
PE
87732011-07-17 Paul Eggert <eggert@cs.ucla.edu>
8774
8775 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
8776 This works around a problem with the previous change to Fcopy_file.
8777 Recent glibc declares fchown with __attribute__((warn_unused_result)),
8778 and without this change, GCC might complain about discarding
8779 fchown's return value.
8780
b5641435
JB
87812011-07-16 Juanma Barranquero <lekktu@gmail.com>
8782
8783 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
8784
a8031457
PE
87852011-07-16 Paul Eggert <eggert@cs.ucla.edu>
8786
8787 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
8788
dd889327
LMI
87892011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
8790
750c33f7
LMI
8791 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
8792 it's used from the C level.
8793
dd889327
LMI
8794 * process.c: Use the same condition for POLL_FOR_INPUT in both
8795 keyboard.c and process.c (bug#1858).
8796
87e86684
LM
87972011-07-09 Lawrence Mitchell <wence@gmx.li>
8798
8799 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
8800 (Fgnutls_boot): Use it.
8801
64348f40
AS
88022011-07-15 Andreas Schwab <schwab@linux-m68k.org>
8803
8804 * doc.c (Fsubstitute_command_keys): Revert last change.
8805
1d698799
LMI
88062011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
8807
f863868c
LMI
8808 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
8809 quotes the next character, and doesn't affect other longer
8810 sequences (bug#8935).
8811
1d698799
LMI
8812 * lread.c (syms_of_lread): Clarify that is isn't only
8813 `eval-buffer' and `eval-defun' that's affected by
8814 `lexical-binding' (bug#8460).
8815
aa4b6df6
EZ
88162011-07-15 Eli Zaretskii <eliz@gnu.org>
8817
8818 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 8819 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 8820
5d856da6
PE
88212011-07-14 Paul Eggert <eggert@cs.ucla.edu>
8822
ad6042bb
PE
8823 Fix minor problems found by static checking.
8824 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
8825 (elsz): Now a signed constant, not a size_t var. We prefer signed
8826 types to unsigned, to avoid integer comparison confusion. Without
8827 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
8828 "cannot optimize loop, the loop counter may overflow", a symptom
8829 of the confusion.
f00bbb22 8830 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
8831 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
8832
6468f31c
LMI
88332011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8834
49080b10
LMI
8835 * search.c (Fre_search_backward): Mention `case-fold-search' in
8836 all the re_search_* functions (bug#8138).
8837
6468f31c
LMI
8838 * keyboard.c (Fopen_dribble_file): Document when the file is
8839 closed (bug#8056).
8840
c965adc5
EZ
88412011-07-14 Eli Zaretskii <eliz@gnu.org>
8842
df9733bf
EZ
8843 * bidi.c (bidi_dump_cached_states): Fix format of displaying
8844 bidi_cache_idx.
8845
0bb23927
EZ
8846 Support bidi reordering of display and overlay strings.
8847 * xdisp.c (compute_display_string_pos)
8848 (compute_display_string_end): Accept additional argument STRING.
8849 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
8850 (reseat_to_string): Initialize bidi_it->string.s and
8851 bidi_it->string.schars.
8852 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
8853 NULL (avoids a crash in bidi_paragraph_init).
8854 Initialize itb.string.lstring.
0bb23927
EZ
8855 (init_iterator): Call bidi_init_it only of a valid
8856 buffer position was specified. Initialize paragraph_embedding to
8857 L2R.
8858 (reseat_to_string): Initialize the bidi iterator.
8859 (display_string): If we need to ignore text properties of
8860 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
8861 original value of -1 will not work with bidi.)
8862 (compute_display_string_pos): First arg is now struct
8863 `text_pos *'; all callers changed. Support display properties on
8864 Lisp strings.
8865 (compute_display_string_end): Support display properties on Lisp
8866 strings.
8867 (init_iterator, reseat_1, reseat_to_string): Initialize the
8868 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
8869 when iterating on a string not from display properties).
640c8776
SM
8870 (compute_display_string_pos, compute_display_string_end):
8871 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
8872 arrow keys.
8873 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
8874 base_level_stop; instead, set base_level_stop to BEGV.
8875 Fixes crashes in vertical-motion.
0bb23927
EZ
8876 (next_element_from_buffer): Improve commentary for when
8877 the iterator is before prev_stop.
8878 (init_iterator): Initialize bidi_p from the default value of
8879 bidi-display-reordering, not from buffer-local value. Use the
8880 buffer-local value only if initializing for buffer iteration.
8881 (handle_invisible_prop): Support invisible properties on strings
8882 that are being bidi-reordered.
8883 (set_iterator_to_next): Support bidi reordering of C strings and
8884 Lisp strings.
8885 (next_element_from_string): Support bidi reordering of Lisp
8886 strings.
8887 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
8888 (display_string): Support display of R2L glyph rows.
8889 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
8890 (init_iterator): Don't initialize it->bidi_p for strings
8891 here.
8892 (reseat_to_string): Initialize it->bidi_p for strings here.
8893 (next_element_from_string, next_element_from_c_string)
8894 (next_element_from_buffer): Add xassert's for correspondence
8895 between IT's object being iterated and it->bidi_it.string
8896 structure.
8897 (face_before_or_after_it_pos): Support bidi iteration.
8898 (next_element_from_c_string): Handle the case of the first string
8899 character that is not the first one in the visual order.
8900 (get_visually_first_element): New function, refactored from common
8901 parts of next_element_from_buffer, next_element_from_string, and
8902 next_element_from_c_string.
8903 (tool_bar_lines_needed, redisplay_tool_bar)
8904 (display_menu_bar): Force left-to-right direction. Add a FIXME
8905 comment for making that be controlled by a user option.
8906 (push_it, pop_it): Save and restore the state of the
8907 bidi iterator. Save and restore the bidi_p flag.
8908 (pop_it): Iterate out of display property for string iteration as
8909 well.
8910 (iterate_out_of_display_property): Support iteration over strings.
8911 (handle_single_display_spec): Set up it->bidi_it for iteration
8912 over a display string, and call bidi_init_it.
8913 (handle_single_display_spec, next_overlay_string)
8914 (get_overlay_strings_1, push_display_prop): Set up the bidi
8915 iterator for displaying display or overlay strings.
8916 (forward_to_next_line_start): Don't use the shortcut if
8917 bidi-iterating.
8918 (back_to_previous_visible_line_start): If handle_display_prop
8919 pushed the iterator stack, restore the internal state of the bidi
8920 iterator by calling bidi_pop_it same number of times.
8921 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
8922 and we are bidi-iterating, don't decrement the iterator position;
8923 instead, set the first_elt flag in the bidi iterator, to produce
8924 the same effect.
8925 (reseat_1): Remove redundant setting of string_from_display_prop_p.
8926 (push_display_prop): xassert that we are iterating a buffer.
8927 (push_it, pop_it): Save and restore paragraph_embedding member.
8928 (handle_single_display_spec, next_overlay_string)
8929 (get_overlay_strings_1, reseat_1, reseat_to_string)
8930 (push_display_prop): Set up the `unibyte' member of bidi_it.string
8931 correctly. Don't assume unibyte strings are not bidi-reordered.
8932 (compute_display_string_pos)
8933 (compute_display_string_end): Fix handling the case of C string.
8934 (push_it, pop_it): Save and restore from_disp_prop_p.
8935 (handle_single_display_spec, push_display_prop): Set the
8936 from_disp_prop_p flag.
8937 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
8938 (pop_it): Call iterate_out_of_display_property only if we are
8939 popping after iteration over a string that came from a display
8940 property. Fix a typo in popping stretch info. Add an assertion
8941 for verifying that the iterator position is in sync with the bidi
8942 iterator.
8943 (handle_single_display_spec, get_overlay_strings_1)
8944 (push_display_prop): Fix initialization of paragraph direction for
8945 string when that of the parent object is not yet determined.
8946 (reseat_1): Call bidi_init_it to resync the bidi
8947 iterator with IT's position. (Bug#7616)
8948 (find_row_edges): If ROW->start.pos gives position
8949 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
8950 (handle_stop, back_to_previous_visible_line_start, reseat_1):
8951 Reset the from_disp_prop_p flag.
8952 (SAVE_IT, RESTORE_IT): New macros.
8953 (pos_visible_p, face_before_or_after_it_pos)
8954 (back_to_previous_visible_line_start)
8955 (move_it_in_display_line_to, move_it_in_display_line)
8956 (move_it_to, move_it_vertically_backward, move_it_by_lines)
8957 (try_scrolling, redisplay_window, display_line): Use them when
8958 saving a temporary copy of the iterator and restoring it back.
8959 (back_to_previous_visible_line_start, reseat_1)
8960 (init_iterator): Empty the bidi cache "stack".
8961 (move_it_in_display_line_to): If iterator ended up at
8962 EOL, but we never saw any buffer positions smaller than
8963 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
8964 motion in bidi-reordered lines.
8965 (move_it_in_display_line_to): Record prev_method and prev_pos
8966 immediately before the call to set_iterator_to_next. Fixes cursor
8967 motion in bidi-reordered lines with stretch glyphs and strings
8968 displayed in margins. (Bug#8133) (Bug#8867)
8969 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
8970 TO_CHARPOS.
640c8776
SM
8971 (pos_visible_p): Support positions in bidi-reordered lines.
8972 Save and restore bidi cache.
0bb23927
EZ
8973
8974 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
8975 (bidi_paragraph_info): Delete unused struct.
8976 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
8977 (bidi_cache_start): New variable.
8978 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
8979 to zero.
8980 (bidi_cache_fetch_state, bidi_cache_search)
8981 (bidi_cache_find_level_change, bidi_cache_iterator_state)
8982 (bidi_cache_find, bidi_peek_at_next_level)
8983 (bidi_level_of_next_char, bidi_find_other_level_edge)
8984 (bidi_move_to_visually_next): Compare cache index with
8985 bidi_cache_start rather than with zero.
8986 (bidi_fetch_char): Accept new argument STRING; all callers
8987 changed. Support iteration over a string. Support strings with
8988 display properties. Support unibyte strings. Fix the type of
8989 `len' according to what STRING_CHAR_AND_LENGTH expects.
8990 (bidi_paragraph_init, bidi_resolve_explicit_1)
8991 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
8992 (bidi_level_of_next_char, bidi_move_to_visually_next):
8993 Support iteration over a string.
0bb23927
EZ
8994 (bidi_set_sor_type, bidi_resolve_explicit_1)
8995 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
8996 can now be zero (for strings); special values 0 and -1 were
8997 changed to -1 and -2, respectively.
8998 (bidi_char_at_pos): New function.
8999 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
9000 Call it instead of FETCH_MULTIBYTE_CHAR.
9001 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
9002 initialized to valid values.
9003 (bidi_init_it): Don't initialize charpos and bytepos with invalid
9004 values.
9005 (bidi_level_of_next_char): Allow the sentinel "position" to pass
9006 the test for valid cached positions. Fix the logic for looking up
9007 the sentinel state in the cache. GCPRO the Lisp string we are
9008 iterating.
9009 (bidi_push_it, bidi_pop_it): New functions.
9010 (bidi_initialize): Initialize the bidi cache start stack pointer.
9011 (bidi_cache_ensure_space): New function, refactored from part of
9012 bidi_cache_iterator_state. Don't assume the required size is just
9013 one BIDI_CACHE_CHUNK away.
9014 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
9015 (bidi_count_bytes, bidi_char_at_pos): New functions.
9016 (bidi_cache_search): Don't assume bidi_cache_last_idx is
9017 always valid if bidi_cache_idx is valid.
9018 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
9019 is valid if it's going to be used.
9020 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
9021 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
9022 (bidi_cache_find_level_change, bidi_cache_ensure_space)
9023 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
9024 (bidi_find_other_level_edge, bidi_cache_start_stack):
9025 All variables related to cache indices are now EMACS_INT.
c965adc5 9026
0bb23927
EZ
9027 * dispextern.h (struct bidi_string_data): New structure.
9028 (struct bidi_it): New member `string'. Make flag members be 1-bit
9029 fields, and put them last in the struct.
640c8776
SM
9030 (compute_display_string_pos, compute_display_string_end):
9031 Update prototypes.
0bb23927
EZ
9032 (bidi_push_it, bidi_pop_it): Add prototypes.
9033 (struct iterator_stack_entry): New members bidi_p,
9034 paragraph_embedding, and from_disp_prop_p.
9035 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
9036 (bidi_shelve_cache, bidi_unshelve_cache):
9037 Declare prototypes.
0bb23927
EZ
9038
9039 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
9040 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
9041 and vector-like objects.
9042
9043 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
9044 cache around display iteration.
9045
9046 * window.c (Fwindow_end, window_scroll_pixel_based)
9047 (displayed_window_lines, Frecenter): Save and restore the bidi
9048 cache around display iteration.
9049
3bbd2265
LMI
90502011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
9051
9052 * editfns.c (Fdelete_region): Clarify the use of the named
9053 parameters (bug#6788).
9054
adc47434
MR
90552011-07-14 Martin Rudalics <rudalics@gmx.at>
9056
9057 * indent.c (Fvertical_motion): Set and restore w->pointm when
9058 saving and restoring the window's buffer (Bug#9006).
9059
837c31f8
LMI
90602011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
9061
9062 * editfns.c (Fstring_to_char): Clarify just what is returned
9063 (bug#6576). Text by Eli Zaretskii.
9064
ac389d0c
JB
90652011-07-13 Juanma Barranquero <lekktu@gmail.com>
9066
9067 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
9068
0be0ce47
EZ
90692011-07-13 Eli Zaretskii <eliz@gnu.org>
9070
9071 * buffer.c (mmap_find): Fix a typo.
9072
cd18e7e3
JB
90732011-07-13 Johan Bockgård <bojohan@gnu.org>
9074
9075 Fix execution of x selection hooks.
9076 * xselect.c (Qx_lost_selection_functions)
9077 (Qx_sent_selection_functions): New vars.
9078 (syms_of_xselect): DEFSYM them.
9079 (x_handle_selection_request): Pass Qx_sent_selection_functions
9080 rather than Vx_sent_selection_functions to Frun_hook_with_args.
9081 (x_handle_selection_clear,x_clear_frame_selections):
9082 Pass Qx_lost_selection_functions rather than
9083 Vx_lost_selection_functions to Frun_hook_with_args.
9084
47ea7f44
PE
90852011-07-13 Paul Eggert <eggert@cs.ucla.edu>
9086
ac389d0c 9087 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
9088 The old code sometimes used this field without initializing it.
9089
47ea7f44
PE
9090 * alloc.c (gc_sweep): Don't read past end of array.
9091 In theory, the old code could also have corrupted Emacs internals,
9092 though it'd be very unlikely.
9093
bc985c87
AS
90942011-07-12 Andreas Schwab <schwab@linux-m68k.org>
9095
9096 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 9097 argument. (Bug#4026)
bc985c87 9098
0cf34688
LMI
90992011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
9100
b3dadd76
LMI
9101 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
9102 key" (bug#4257).
9103
0cf34688
LMI
9104 * window.c (Fset_window_start): Doc fix (bug#4199).
9105 (Fset_window_hscroll): Ditto.
9106
270768cd
PE
91072011-07-12 Paul Eggert <eggert@cs.ucla.edu>
9108
077e3dda 9109 Fix minor new problems caught by GCC 4.6.1.
270768cd 9110 * term.c (init_tty): Remove unused local.
490011a6 9111 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 9112 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 9113 not used otherwise.
270768cd 9114
b1f58454
CY
91152011-07-12 Chong Yidong <cyd@stupidchicken.com>
9116
9117 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
9118
22b9578d
LMI
91192011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
9120
6e70ab07
LMI
9121 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
9122 are the mini-buffer and the echo area (bug#3320).
9123
22b9578d
LMI
9124 * term.c (init_tty): Remove support for supdup, c10 and perq
9125 terminals, which are no longer supported (bug#1482).
9126
8974cc9f
JB
91272011-07-10 Johan Bockgård <bojohan@gnu.org>
9128
9129 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
9130
a560d974
JD
91312011-07-10 Jan Djärv <jan.h.d@swipnet.se>
9132
9133 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
9134 for non-popups (Bug#3642).
9135
1dae0f0a
AS
91362011-07-10 Andreas Schwab <schwab@linux-m68k.org>
9137
268c2c36 9138 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 9139 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
9140 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
9141 * cm.c (losecursor): Likewise.
1dae0f0a
AS
9142 * data.c (fmod): Likewise.
9143 * dispnew.c (swap_glyphs_in_rows): Likewise.
9144 * emacs.c (memory_warning_signal): Likewise.
9145 * floatfns.c (float_error): Likewise.
9146 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
9147 (otf_open, font_otf_capability, generate_otf_features)
9148 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
9149 Likewise.
9150 * image.c (pbm_read_file): Likewise.
9151 * indent.c (string_display_width): Likewise.
9152 * intervals.c (check_for_interval, search_for_interval)
9153 (inc_interval_count, count_intervals, root_interval)
9154 (adjust_intervals_for_insertion, make_new_interval): Likewise.
9155 * lread.c (defalias): Likewise.
268c2c36 9156 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
9157 * regex.c (set_image_of_range_1, set_image_of_range)
9158 (regex_grow_registers): Likewise.
9159 * sysdep.c (strerror): Likewise.
9160 * termcap.c (valid_filename_p, tprint, main): Likewise.
9161 * tparam.c (main): Likewise.
9162 * unexhp9k800.c (run_time_remap, save_data_space)
9163 (update_file_ptrs, read_header, write_header, calculate_checksum)
9164 (copy_file, copy_rest, display_header): Likewise.
9165 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
9166 Likewise.
9167 * xdisp.c (check_it): Likewise.
9168 * xfaces.c (register_color, unregister_color, unregister_colors):
9169 Likewise.
9170 * xfns.c (print_fontset_result): Likewise.
9171 * xrdb.c (member, fatal, main): Likewise.
9172
99033785
PE
91732011-07-10 Paul Eggert <eggert@cs.ucla.edu>
9174
9175 Fix minor problems found by static checking (Bug#9031).
9176 * chartab.c (char_table_set_range, map_sub_char_table):
9177 Remove unused locals.
9178 (uniprop_table): Now static.
9179 * composite.c (_work_char): Remove unused static var.
9180
9cb2ac56
JB
91812011-07-09 Juanma Barranquero <lekktu@gmail.com>
9182
9183 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
9184
f25661f0
JD
91852011-07-09 Jan Djärv <jan.h.d@swipnet.se>
9186
9187 * gtkutil.c (qttip_cb): Remove code without function.
9188
8278c4fe
EZ
91892011-07-09 Eli Zaretskii <eliz@gnu.org>
9190
9191 * w32.c (pthread_sigmask): New stub.
9192
1692ae2d 91932011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 9194
8a6ebd58 9195 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
9196 sigprocmask is portable only for single-threaded applications, and
9197 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
9198 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
9199 (LIBES): Use it.
9200 * callproc.c (Fcall_process):
9201 * process.c (create_process):
9202 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
9203 Use pthread_sigmask, not sigprocmask.
123403e4 9204
1b854618
JD
92052011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9206
9207 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
9208 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
9209 wrong (Bug#8591).
9210
3fe4b549
JD
92112011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9212
0ce7e563
JD
9213 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
9214 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
9215 (xg_hide_tooltip): Fix comment.
9216
3fe4b549
JD
9217 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
9218 in registerServicesMenuSendTypes.
9219 (validRequestorForSendType): Don't check ns_return_types.
9220
9221 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
9222 ns_return_type.
9223
5df75e47
JR
92242011-07-08 Jason Rumney <jasonr@gnu.org>
9225
22610910
JR
9226 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
9227 SH_SHOW for hidden windows (Bug#5482).
9228
5df75e47
JR
9229 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
9230 frame struct members of non-existent frames (Bug#6284).
9231
699c10bd
JD
92322011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9233
4393663b
JD
9234 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
9235 variable firstTime not needed on OSX >= 10.6.
9236 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
9237 >= 10.5. Use setKnobProportion, setDoubleValue.
9238
9239 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
9240 (MAC_OS_X_VERSION_10_5): Define if not defined.
9241 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
9242 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
9243 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
9244
9245 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 9246 cString and lossyCString on OSX >= 10.4.
4393663b 9247
58179cce 9248 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
9249 sizeToFit on OSX >= 10.2.
9250
9251 * nsimage.m (allocInitFromFile): Don't use deprecated method
9252 bestRepresentationForDevice on OSX >= 10.6.
9253
9254 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
9255 to avoid warning.
9256
9257 * emacs.c: Declare unexec_init_emacs_zone.
9258
a63e0781
JD
9259 * nsgui.h: Fix compiler warning about gnulib redefining verify.
9260
699c10bd
JD
9261 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
9262
9263 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
9264 on svcsMenu (Bug#8842).
9265
9266 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
9267 ns_return_types.
9268 (Fns_list_services): Just return Qnil on 10.6, code not working there.
9269
9270 * nsterm.m (QUTF8_STRING): Declare.
9271 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
9272 (validRequestorForSendType): Return type is (id).
9273 Change indexOfObjectIdenticalTo to indexOfObject.
9274 Check if we have local selection before returning self (Bug#8842).
9275 (writeSelectionToPasteboard): Put local selection into paste board
9276 if we have a local selection (Bug#8842).
9277 (syms_of_nsterm): DEFSYM QUTF8_STRING.
9278
9279 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
9280 (ns_get_local_selection): Declare.
9281
54e10184
LMI
92822011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
9283
9888ff71
LMI
9284 * keymap.c (describe_map_tree): Don't insert a double newline at
9285 the end of the buffer (bug#1169) and return whether we inserted
9286 something.
9287
54e10184
LMI
9288 * callint.c (Fcall_interactively): Change "reading args" to
9289 "providing args" to try to clarify what it does (bug#1010).
9290
15fa4783
KH
92912011-07-07 Kenichi Handa <handa@m17n.org>
9292
9293 * composite.c (composition_compute_stop_pos): Ignore a static
9294 composition starting before CHARPOS (Bug#8915).
9295
9296 * xdisp.c (handle_composition_prop): Likewise.
9297
a8815b00
EZ
92982011-07-07 Eli Zaretskii <eliz@gnu.org>
9299
9300 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
9301 (Bug#9015)
9302
ef7b981d 93032011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
9304
9305 * character.h (unicode_category_t): New enum type.
9306
9307 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
9308 (Qchar_code_property_table): New variable.
9309 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
9310 (UNIPROP_COMPRESSED_FORM_P): New macros.
9311 (char_table_ascii): Uncompress the compressed values.
9312 (sub_char_table_ref): New arg is_uniprop. Callers changed.
9313 Uncompress the compressed values.
ac389d0c 9314 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
9315 (char_table_ref_and_range): Uncompress the compressed values.
9316 (sub_char_table_set): New arg is_uniprop. Callers changed.
9317 Uncompress the compressed values.
9318 (sub_char_table_set_range): Args changed. Callers changed.
9319 (char_table_set_range): Adjuted for the above change.
9320 (map_sub_char_table): Delete args default_val and parent. Add arg
9321 top. Give decoded values to a Lisp function.
640c8776 9322 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
9323 values to a Lisp function. Gcpro more variables.
9324 (uniprop_table_uncompress)
9325 (uniprop_decode_value_run_length): New functions.
9326 (uniprop_decoder, uniprop_decoder_count): New variables.
9327 (uniprop_get_decoder, uniprop_encode_value_character)
9328 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
9329 New functions.
9330 (uniprop_encoder, uniprop_encoder_count): New variables.
9331 (uniprop_get_encoder, uniprop_table)
9332 (Funicode_property_table_internal, Fget_unicode_property_internal)
9333 (Fput_unicode_property_internal): New functions.
9334 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
9335 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 9336 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
9337 char-code-property-alist.
9338
640c8776 9339 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
9340 Vunicode_category_table.
9341
640c8776 9342 * font.c (font_range): Adjust for the change of
c805dec0
KH
9343 Vunicode_category_table.
9344
76b397fb
DN
93452011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
9346
9347 * m/iris4d.h: Remove file, move contents ...
9348 * s/irix6-5.h: ... here.
9349
22b4128e
PE
93502011-07-06 Paul Eggert <eggert@cs.ucla.edu>
9351
9352 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
9353 * alloc.c (mark_buffer):
9354 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
9355 (clone_per_buffer_values): Don't assume that
22b4128e
PE
9356 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
9357 This isn't true in general, and it's particularly not true
9358 if Emacs is configured with --with-wide-int.
9359 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
9360 New macros, used in the buffer.c change.
9361
869795d6
JD
93622011-07-05 Jan Djärv <jan.h.d@swipnet.se>
9363
9364 * xsettings.c: Use both GConf and GSettings if both are available.
9365 (store_config_changed_event): Add comment.
9366 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
9367 (store_tool_bar_style_changed): New functions.
5e617bc2 9368 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
9369 (struct xsettings): Move font inside HAVE_XFT.
9370 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 9371 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 9372 Move inside HAVE_XFT.
640c8776 9373 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
9374 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
9375 also.
9376 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 9377 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 9378 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
9379 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
9380 (parse_settings): Move check for font inside HAVE_XFT.
9381 (read_settings, apply_xft_settings): Add comment.
9382 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
9383 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
9384 call store_font_name_changed.
9385 (xft_settings_event): Add comment.
9386 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
9387 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
9388 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
9389 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
9390 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
9391 (xsettings_get_system_font, xsettings_get_system_normal_font):
9392 Add comment.
869795d6 9393
d8ed26bd
PE
93942011-07-05 Paul Eggert <eggert@cs.ucla.edu>
9395
9396 Random fixes. E.g., (random) never returned negative values.
9397 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
9398 subseconds part to the entropy, as that's a bit more random.
9399 Prefer signed to unsigned, since the signedness doesn't matter and
9400 in general we prefer signed. When given a limit, use a
9401 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
9402 latter isn't right if USE_2_TAGS_FOR_INTS.
9403 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
9404 not 0..VALMASK. Don't discard "excess" bits that random () returns.
9405
cabf1cac
SM
94062011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
9407
9408 * textprop.c (text_property_stickiness):
9409 Obey Vtext_property_default_nonsticky.
9410 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
9411 * w32fns.c (syms_of_w32fns):
9412 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
9413
6e9b2be9
PE
94142011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9415
9416 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
9417 This is more efficient than Ffile_directory_p and avoids a minor race.
9418
90186c68
LMI
94192011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
9420
7c301272
LMI
9421 * buffer.c (Foverlay_put): Say what the return value is
9422 (bug#7835).
9423
c4f2d8d4
LMI
9424 * fileio.c (barf_or_query_if_file_exists): Check first if the file
9425 is a directory before asking whether to use the file name
9426 (bug#7564).
ad637907
LMI
9427 (barf_or_query_if_file_exists): Make the "File is a directory"
9428 error be more correct.
c4f2d8d4 9429
90186c68
LMI
9430 * fns.c (Frequire): Remove the mention of the .gz files, since
9431 that's installation-specific, but keep the mention of
9432 `get-load-suffixes'.
9433
da64016e
PE
94342011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9435
9436 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
9437 Report string overflow if the output is too long.
9438
7d47b580
JB
94392011-07-04 Juanma Barranquero <lekktu@gmail.com>
9440
a555cb87
JB
9441 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
9442 (syms_of_gnutls): Remove duplicate DEFSYM for
9443 Qgnutls_bootprop_verify_hostname_error, an error for
9444 Qgnutls_bootprop_verify_error (which is no longer used).
9445
7d47b580
JB
9446 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
9447 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
9448 Also (re)move comments that are misplaced or no longer relevant.
9449
1e49bfab
LMI
94502011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9451
9452 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
9453
1485f4c0
CY
94542011-07-03 Chong Yidong <cyd@stupidchicken.com>
9455
9456 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
9457 and background color parameters if they have been changed.
9458
a9ab721e
LMI
94592011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9460
9461 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
9462
cf7cff57
PE
94632011-07-03 Paul Eggert <eggert@cs.ucla.edu>
9464
2e13213d
PE
9465 * xsettings.c (SYSTEM_FONT): Define only when used.
9466 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
9467
cf7cff57
PE
9468 * keymap.c (access_keymap_1): Now static.
9469
7a8e04f7
CY
94702011-07-02 Chong Yidong <cyd@stupidchicken.com>
9471
9472 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
9473 leave any prefix arg for the up event (Bug#1586).
9474
61352f62
LMI
94752011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
9476
69bb1ef7
LMI
9477 * lread.c (syms_of_lread): Mention single symbols defined by
9478 `defvar' or `defconst' (bug#7154).
9479
61352f62 9480 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 9481 (Frequire): Mention get-load-suffixes.
61352f62 9482
28545e04
MR
94832011-07-02 Martin Rudalics <rudalics@gmx.at>
9484
9485 * window.h (window): Remove clone_number slot.
9486 * window.c (Fwindow_clone_number, Fset_window_clone_number):
9487 Remove.
9488 (make_parent_window, make_window, saved_window)
9489 (Fset_window_configuration, save_window_save): Don't deal with
9490 clone numbers.
9491 * buffer.c (Qclone_number): Remove declaration.
9492 (sort_overlays, overlay_strings): Don't deal with clone numbers.
9493
3349e122
SM
94942011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
9495
9496 Add multiple inheritance to keymaps.
9497 * keymap.c (Fmake_composed_keymap): New function.
9498 (Fset_keymap_parent): Simplify.
9499 (fix_submap_inheritance): Remove.
9500 (access_keymap_1): New function extracted from access_keymap to handle
9501 embedded parents and handle lists of maps.
9502 (access_keymap): Use it.
9503 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
9504 (Fcopy_keymap): Handle embedded parents.
9505 (Fcommand_remapping, define_as_prefix): Simplify.
9506 (Fkey_binding): Simplify.
9507 (syms_of_keymap): Move minibuffer-local-completion-map,
9508 minibuffer-local-filename-completion-map,
9509 minibuffer-local-must-match-map, and
9510 minibuffer-local-filename-must-match-map to Elisp.
9511 (syms_of_keymap): Defsubr make-composed-keymap.
9512 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
9513 (parse_menu_item): Trivial simplification.
9514
3279eb87
GM
95152011-07-01 Glenn Morris <rgm@gnu.org>
9516
9517 * Makefile.in (SETTINGS_LIBS): Fix typo.
9518
4550efdf
KI
95192011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
9520
9521 * coding.c (Fencode_coding_string): Record the last coding system
9522 used, as the function doc string says (bug#8738).
9523
0949d2b6
JD
95242011-07-01 Jan Djärv <jan.h.d@swipnet.se>
9525
9526 * xsettings.c (store_monospaced_changed): Take new font as arg and
9527 check for change against current_mono_font.
9528 (EMACS_TYPE_SETTINGS): Remove this and related defines.
9529 (emacs_settings_constructor, emacs_settings_get_property)
9530 (emacs_settings_set_property, emacs_settings_class_init)
9531 (emacs_settings_init, gsettings_obj): Remove.
9532 (something_changedCB): New function for HAVE_GSETTINGS.
9533 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
9534 with value as argument.
9535 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
9536 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 9537 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
9538 "changed".
9539
9540 * xgselect.c: Add defined (HAVE_GSETTINGS).
9541 (xgselect_initialize): Ditto.
9542
9543 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
9544 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
9545 xg_select.
9546
bbc6b304
PE
95472011-07-01 Paul Eggert <eggert@cs.ucla.edu>
9548
9549 * eval.c (struct backtrace): Simplify and port the data structure.
9550 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
9551 signed bit field, as this assumption is not portable and it makes
9552 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
9553 "char debug_on_exit : 1" as this is not portable either; instead,
9554 use the portable "unsigned int debug_on_exit : 1". Remove unused
9555 member evalargs. Remove obsolete comments about cc bombing out.
9556
9851bfc5
JD
95572011-06-30 Jan Djärv <jan.h.d@swipnet.se>
9558
51bb811f 9559 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
9560 Let HAVE_GSETTINGS override HAVE_GCONF.
9561 (store_monospaced_changed): New function.
9562 (EMACS_SETTINGS): A new type derived from GObject to handle
9563 GSettings notifications.
9564 (emacs_settings_constructor, emacs_settings_get_property)
9565 (emacs_settings_set_property, emacs_settings_class_init):
9566 New functions.
9567 (gsettings_client, gsettings_obj): New variables.
9568 (GSETTINGS_SCHEMA): New define.
9569 (something_changedCB): Call store_monospaced_changed.
9570 (init_gsettings): New function.
9571 (xsettings_initialize): Call init_gsettings.
9572 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
9573 to NULL.
9574
640c8776 9575 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
9576 GCONF_CFLAGS/LIBS.
9577
5386012d
MR
95782011-06-29 Martin Rudalics <rudalics@gmx.at>
9579
9580 * window.c (resize_root_window, grow_mini_window)
9581 (shrink_mini_window): Rename Qresize_root_window to
9582 Qwindow_resize_root_window and Qresize_root_window_vertically to
9583 Qwindow_resize_root_window_vertically.
9584
f13e0b08
PE
95852011-06-28 Paul Eggert <eggert@cs.ucla.edu>
9586
9587 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
9588
94515237
JB
95892011-06-27 Juanma Barranquero <lekktu@gmail.com>
9590
9591 * makefile.w32-in: Redesign dependencies so they reflect more
9592 clearly which files are directly included by each source file,
9593 and not through other includes.
9594
e43b6e43
MR
95952011-06-27 Martin Rudalics <rudalics@gmx.at>
9596
9597 * buffer.c (Qclone_number): Declare static and DEFSYM it.
9598 (sort_overlays, overlay_strings): When an overlay's clone number
9599 matches the window's clone number process the overlay even if
9600 the overlay's window property doesn't match the current window.
9601
d68443dc
MR
9602 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
9603 (Fwindow_hchild): Rename to Fwindow_left_child.
9604 (Fwindow_next): Rename to Fwindow_next_sibling.
9605 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
9606 (resize_window_check): Rename to window_resize_check.
9607 (resize_window_apply): Rename to window_resize_apply.
9608 (Fresize_window_apply): Rename to Fwindow_resize_apply.
9609 (Fdelete_other_windows_internal, resize_frame_windows)
9610 (Fsplit_window_internal, Fdelete_window_internal)
9611 (grow_mini_window, shrink_mini_window)
9612 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 9613
c7e73be5
JD
96142011-06-26 Jan Djärv <jan.h.d@swipnet.se>
9615
9616 * emacsgtkfixed.h: State that this is only used with Gtk+3.
9617 (emacs_fixed_set_min_size): Remove.
9618 (emacs_fixed_new): Take frame as argument.
9619
9620 * emacsgtkfixed.c: State that this is only used with Gtk+3.
9621 (_EmacsFixedPrivate): Remove minwidth/height.
9622 Add struct frame *f.
9623 (emacs_fixed_init): Initialize priv->f.
9624 (get_parent_class, emacs_fixed_set_min_size): Remove.
9625 (emacs_fixed_new): Set priv->f to argument.
9626 (emacs_fixed_get_preferred_width)
9627 (emacs_fixed_get_preferred_height): Use min_width/height from
9628 frames size_hint to set minimum and natural (Bug#8919).
9629 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
9630 and use min_width/height from frames size_hint to set
9631 min_width/height (Bug#8919).
9632
9633 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
9634 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
9635 Fix indentation.
c7e73be5 9636
cf99dcf8
EZ
96372011-06-26 Eli Zaretskii <eliz@gnu.org>
9638
9639 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
9640 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
9641 called at ZV.
9642
029529ac
CY
96432011-06-26 Chong Yidong <cyd@stupidchicken.com>
9644
9645 * process.c (wait_reading_process_output): Bypass select if
9646 waiting for a cell while ignoring keyboard input, and input is
9647 pending. Suggested by Jan Djärv (Bug#8869).
9648
7a7ef429
PE
96492011-06-25 Paul Eggert <eggert@cs.ucla.edu>
9650
9651 Use gnulib's dup2 module instead of rolling our own.
9652 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
9653
11fdef7d 96542011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
9655
9656 * dispnew.c (scrolling_window): Before scrolling, turn off a
9657 mouse-highlight in the window being scrolled.
9658
cd3520a4
JB
96592011-06-24 Juanma Barranquero <lekktu@gmail.com>
9660
9661 Move DEFSYM to lisp.h and use everywhere.
9662
9663 * character.h (DEFSYM): Move declaration...
9664 * lisp.h (DEFSYM): ...here.
9665
9666 * gnutls.c:
9667 * minibuf.c:
9668 * w32menu.c:
9669 * w32proc.c:
9670 * w32select.c: Don't include character.h.
9671
9672 * alloc.c (syms_of_alloc):
9673 * buffer.c (syms_of_buffer):
9674 * bytecode.c (syms_of_bytecode):
9675 * callint.c (syms_of_callint):
9676 * casefiddle.c (syms_of_casefiddle):
9677 * casetab.c (init_casetab_once):
9678 * category.c (init_category_once, syms_of_category):
9679 * ccl.c (syms_of_ccl):
9680 * cmds.c (syms_of_cmds):
9681 * composite.c (syms_of_composite):
9682 * dbusbind.c (syms_of_dbusbind):
9683 * dired.c (syms_of_dired):
9684 * dispnew.c (syms_of_display):
9685 * doc.c (syms_of_doc):
9686 * editfns.c (syms_of_editfns):
9687 * emacs.c (syms_of_emacs):
9688 * eval.c (syms_of_eval):
9689 * fileio.c (syms_of_fileio):
9690 * fns.c (syms_of_fns):
9691 * frame.c (syms_of_frame):
9692 * fringe.c (syms_of_fringe):
9693 * insdel.c (syms_of_insdel):
9694 * keymap.c (syms_of_keymap):
9695 * lread.c (init_obarray, syms_of_lread):
9696 * macros.c (syms_of_macros):
9697 * msdos.c (syms_of_msdos):
9698 * print.c (syms_of_print):
9699 * process.c (syms_of_process):
9700 * search.c (syms_of_search):
9701 * sound.c (syms_of_sound):
9702 * syntax.c (init_syntax_once, syms_of_syntax):
9703 * terminal.c (syms_of_terminal):
9704 * textprop.c (syms_of_textprop):
9705 * undo.c (syms_of_undo):
9706 * w32.c (globals_of_w32):
9707 * window.c (syms_of_window):
9708 * xdisp.c (syms_of_xdisp):
9709 * xfaces.c (syms_of_xfaces):
9710 * xfns.c (syms_of_xfns):
9711 * xmenu.c (syms_of_xmenu):
9712 * xsettings.c (syms_of_xsettings):
9713 * xterm.c (syms_of_xterm): Use DEFSYM.
9714
4228cf16
TZ
97152011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
9716
cd3520a4 9717 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 9718
7fcccf1e
PE
97192011-06-23 Paul Eggert <eggert@cs.ucla.edu>
9720
7efb4e0e
PE
9721 Integer and buffer overflow fixes (Bug#8873).
9722
ff5844ad
PE
9723 * print.c (printchar, strout): Check for string overflow.
9724 (PRINTPREPARE, printchar, strout):
9725 Don't set size unless allocation succeeds.
9726
90532f02
PE
9727 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
9728 for sizes. Check for string overflow more accurately.
9729 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
9730
6d84508d
PE
9731 * macros.c: Integer and buffer overflow fixes.
9732 * keyboard.h (struct keyboard.kbd_macro_bufsize):
9733 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
9734 Use ptrdiff_t, not int, for sizes.
9735 Don't increment bufsize until after realloc succeeds.
9736 Check for size-calculation overflow.
9737 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
9738
437b2cb4
PE
9739 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
9740
8b9ac8b4
PE
9741 * lread.c: Integer overflow fixes.
9742 (read_integer): Radix is now EMACS_INT, not int,
9743 to improve quality of diagnostics for out-of-range radices.
9744 Calculate buffer size correctly for out-of-range radices.
9745 (read1): Check for integer overflow in radices, and in
9746 read-circle numbers.
82cb60d3
PE
9747 (read_escape): Avoid int overflow.
9748 (Fload, openp, read_buffer_size, read1)
9749 (substitute_object_recurse, read_vector, read_list, map_obarray):
9750 Use ptrdiff_t, not int, for sizes.
9751 (read1): Use EMACS_INT, not int, for sizes.
20270765 9752 Check for size overflow.
8b9ac8b4 9753
7fcccf1e
PE
9754 * image.c (cache_image): Check for size arithmetic overflow.
9755
bfbbd7e7
PE
9756 * lread.c: Integer overflow issues.
9757 (saved_doc_string_size, saved_doc_string_length)
9758 (prev_saved_doc_string_size, prev_saved_doc_string_length):
9759 Now ptrdiff_t, not int.
9760 (read1): Don't assume doc string length fits in int. Check for
9761 out-of-range doc string lengths.
9762 (read_list): Don't assume file position fits in int.
39019e54 9763 (read_escape): Check for hex character overflow.
bfbbd7e7 9764
4e323265
LL
97652011-06-22 Leo Liu <sdl.web@gmail.com>
9766
9767 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
9768 Move to minibuffer.el.
9769
85fece3e
PE
97702011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9771
20b84ce9 9772 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
9773 The following patches are for when GLYPH_DEBUG && !XASSERT.
9774 * dispextern.h (trace_redisplay_p, dump_glyph_string):
9775 * dispnew.c (flush_stdout):
9776 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
9777 Mark as externally visible.
9778 * dispnew.c (check_window_matrix_pointers): Now static.
9779 * dispnew.c (window_to_frame_vpos):
9780 * xfns.c (unwind_create_frame):
9781 * xterm.c (x_check_font): Remove unused local.
9782 * scroll.c (CHECK_BOUNDS):
9783 * xfaces.c (cache_fache): Rename local to avoid shadowing.
9784 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
9785 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
9786 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
9787 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
9788 Now static.
9789 (debug_method_add): Use va_list and vsprintf rather than relying
9790 on undefined behavior with wrong number of arguments.
9791 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
9792 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
9793 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
9794 since we're not interested in debugging glyphs with old libraries.
9795 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
9796 GCC 4.6.0's static checking.
9797
0766b489
PE
97982011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9799
31fd4b32
PE
9800 Integer overflow and signedness fixes (Bug#8873).
9801 A few related buffer overrun fixes, too.
9802
b79e8648
PE
9803 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
9804
0766b489
PE
9805 * dispextern.h (struct face.stipple):
9806 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
9807 (x_bitmap_mask, x_allocate_bitmap_record)
9808 (x_create_bitmap_from_data, x_create_bitmap_from_file)
9809 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
9810 (x_create_bitmap_from_xpm_data):
9811 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
9812 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
9813 (.bitmaps_last):
9814 * xfaces.c (load_pixmap):
9815 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
9816 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
9817 (.bitmaps_last, struct x_output.icon_bitmap):
9818 Use ptrdiff_t, not int, for bitmap indexes.
9819 (x_allocate_bitmap_record): Check for size overflow.
9820 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
9821
b081724f
PE
9822 Use ptrdiff_t, not int, for overlay counts.
9823 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
9824 * editfns.c (overlays_around, get_pos_property):
9825 * textprop.c (get_char_property_and_overlay):
9826 * xdisp.c (next_overlay_change, note_mouse_highlight):
9827 * xfaces.c (face_at_buffer_position):
21514da7
PE
9828 * buffer.c (OVERLAY_COUNT_MAX): New macro.
9829 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
9830 (Fnext_overlay_change, Fprevious_overlay_change)
9831 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 9832 Use ptrdiff_t, not int, for sizes.
21514da7 9833 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 9834
3de73e5e
PE
9835 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
9836
2606c57b
PE
9837 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
9838 (x_session_initialize): Do not assume string length fits in int.
9839
aaafe47a
PE
9840 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
9841 This is unlikely, but can occur if DPI is outlandish.
9842
2674ddc8 9843 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
9844 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
9845
28154962
PE
9846 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
9847 * xrdb.c (magic_file_p, search_magic_path):
9848 Omit last arg SUFFIX; it was always 0. All callers changed.
9849 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
9850
7de51af5
PE
9851 * xfont.c (xfont_match): Avoid need for strlen.
9852
25ed6cc3
PE
9853 * xfns.c: Don't assume strlen fits in int.
9854 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
9855
4eab31dd
PE
9856 * xdisp.c (message_log_check_duplicate): Return intmax_t,
9857 not unsigned long, as we prefer signed integers. All callers changed.
9858 Detect integer overflow in repeat count.
9859 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 9860 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 9861
171e2a58
PE
9862 * termcap.c: Don't assume sizes fit in int and never overflow.
9863 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
9864 (gobble_line): Check for size-calculation overflow.
9865
ad39faca 9866 * minibuf.c (Fread_buffer):
6e5bb2dc 9867 * lread.c (intern, intern_c_string):
74ca2eb3
PE
9868 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
9869 Don't assume string length fits in int.
9870
52c61c22 9871 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
9872 * gtkutil.c (style_changed_cb): Avoid need for strlen.
9873
b5b8c9e5
PE
9874 * font.c: Don't assume string length fits in int.
9875 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
9876 Use ptrdiff_t, not int.
ccd6111c
PE
9877 (font_intern_prop): Don't assume string length fits in int.
9878 Don't assume integer property fits in fixnum.
9879 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 9880
882f0d81 9881 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 9882 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
9883 Reformulate so as not to need the command string.
9884 Invoke gzip -cd rather than gunzip, as it's more portable.
9885 (lock_info_type, lock_file_1, lock_file):
9886 Don't assume pid_t and time_t fit in unsigned long.
9887 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
9888 (current_lock_owner): Prefer signed type for sizes.
9889 Use memcpy, not strncpy, where memcpy is what is really wanted.
9890 Don't assume (via atoi) that time_t and pid_t fit in int.
9891 Check for time_t and/or pid_t out of range, e.g., via a network share.
9892 Don't alloca where an auto var works fine.
9893
93f4cf88
PE
9894 * fileio.c: Fix some integer overflow issues.
9895 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
9896 Don't assume string length fits in int.
9897 (directory_file_name): Don't assume string length fits in long.
9898 (make_temp_name): Don't assume pid fits in int, or that its print
9899 length is less than 20.
9900
f3e92b69
PE
9901 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
9902
1bfdaf10
PE
9903 * coding.c (make_subsidiaries): Don't assume string length fits in int.
9904
35016e9a
PE
9905 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
9906
3d1e65a1
PE
9907 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
9908 We prefer signed integers, even for size calculations.
9909
0b963a93
PE
9910 * emacs.c: Don't assume string length fits in 'int'.
9911 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
9912 (main): Don't invoke strlen when not needed.
9913
573f4b54
PE
9914 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
9915 (XD_DEBUG_MESSAGE): Don't waste a byte.
9916
989f33ba
PE
9917 * callproc.c (getenv_internal_1, getenv_internal)
9918 (Fgetenv_internal):
965d34eb
PE
9919 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
9920
e4d29b33
PE
9921 * lread.c (invalid_syntax): Omit length argument.
9922 All uses changed. This doesn't fix a bug, but it simplifies the
9923 code away from its former Hollerith-constant appearance, and it's
9924 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 9925 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 9926
eb49b136
PE
9927 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
9928 This didn't break anything, but it didn't help either.
9929 It's confusing to put a bogus integer in a place where the actual
9930 value does not matter.
9f62aeb1 9931 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 9932 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 9933
15375a22
PE
9934 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
9935 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
9936 implementation.
b61cc01c
PE
9937 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
9938 We prefer signed types, and the value cannot exceed the EMACS_INT
9939 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
9940 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
9941 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
9942 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 9943
53b2623d
PE
9944 * indent.c (sane_tab_width): New function.
9945 (current_column, scan_for_column, Findent_to, position_indentation)
9946 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 9947 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 9948
51cab52b 9949 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 9950
f2ed8a70
PE
9951 * lisp.h (lint_assume): New macro.
9952 * composite.c (composition_gstring_put_cache):
9953 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
9954
abe80cc6
PE
9955 * editfns.c, insdel.c:
9956 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 9957
b02c740e
PE
9958 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
9959
ebc96716
PE
9960 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
9961
b4e50fa0 9962 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 9963 Use much-faster test for byte-length change.
311d5d7c 9964 Don't assume string byte-length fits in 'int'.
a4cf38e4 9965 Check that character arg fits in 'int'.
85461888 9966 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 9967
c0c1ee9f
PE
9968 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
9969
a498d7f4
PE
9970 * fns.c (concat): Catch string overflow earlier.
9971 Do not rely on integer wraparound.
9972
51cab52b
PE
9973 * dispextern.h (struct it.overlay_strings_charpos)
9974 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
9975 * xdisp.c (forward_to_next_line_start)
9976 (back_to_previous_visible_line_start)
9977 (reseat_at_next_visible_line_start, next_element_from_buffer):
9978 Don't arbitrarily truncate the value of 'selective' to int.
9979
76031fad
PE
9980 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
9981
5eb55db9
PE
9982 * composite.c: Don't truncate sizes to 'int'.
9983 (composition_gstring_p, composition_reseat_it)
9984 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
9985 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
9986 not EMACS_UINT, for indexes.
5eb55db9 9987
0703a717
PE
9988 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
9989
d6202519
PE
9990 * buffer.c: Include <verify.h>.
9991 (struct sortvec.priority, struct sortstr.priority):
8961a454 9992 Now EMACS_INT, not int.
c20998a7 9993 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
9994 (struct sortstr.size, record_overlay_string)
9995 (struct sortstrlist.size, struct sortlist.used):
9996 Don't truncate size to int.
9997 (record_overlay_string): Check for size-calculation overflow.
d6202519 9998 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 9999
d5a19415
JM
100002011-06-22 Jim Meyering <meyering@redhat.com>
10001
029529ac 10002 Don't leak an XBM-image-sized buffer
d5a19415
JM
10003 * image.c (xbm_load): Free the image buffer after using it.
10004
a9041e6c
PE
100052011-06-21 Paul Eggert <eggert@cs.ucla.edu>
10006
10007 Port to Sun C.
10008 * composite.c (find_automatic_composition): Omit needless 'return 0;'
10009 that Sun C diagnosed.
10010 * fns.c (secure_hash): Fix pointer signedness issue.
10011 * intervals.c (static_offset_intervals): New function.
10012 (offset_intervals): Use it.
10013
7f3f739f
LL
100142011-06-21 Leo Liu <sdl.web@gmail.com>
10015
10016 * deps.mk (fns.o):
10017 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
10018 sha512.h.
10019
10020 * fns.c (secure_hash): Rename from crypto_hash_function and change
10021 the first arg to accept symbols.
5b66d427 10022 (Fsecure_hash): New primitive.
7f3f739f
LL
10023 (syms_of_fns): New symbols.
10024
76147d94
DD
100252011-06-20 Deniz Dogan <deniz@dogan.se>
10026
10027 * process.c (Fset_process_buffer): Clarify return value in
10028 docstring.
10029
7d7d0045
CY
100302011-06-18 Chong Yidong <cyd@stupidchicken.com>
10031
10032 * dispnew.c (add_window_display_history): Use BVAR.
10033
10034 * xdisp.c (debug_method_add): Use BVAR.
10035 (check_window_end, dump_glyph_matrix, dump_glyph)
10036 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
10037
10038 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
10039 Likewise.
10040
10041 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
10042 check till after the cache is created in init_frame_faces.
10043
ff2bc410
SM
100442011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
10045
10046 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
10047
28177add
PE
100482011-06-16 Paul Eggert <eggert@cs.ucla.edu>
10049
dd3482fe
PE
10050 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
10051 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
10052 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
10053
393d71f3 10054 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
10055 * fileio.c (Finsert_file_contents):
10056 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
10057 Remove the old (too-loose) buffer overflow checks.
10058 They weren't needed, since make_gap checks for buffer overflow.
10059 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
10060 The old code merely checked for Emacs fixnum overflow, and relied
10061 on undefined (wraparound) behavior. The new code avoids undefined
10062 behavior, and also checks for ptrdiff_t and/or size_t overflow.
10063
2e6813b0 10064 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
10065 Tune. Don't use wider integers than needed. Don't use alloca.
10066 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 10067
599a9e4f
PE
10068 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
10069
99561444
PE
10070 * insdel.c, lisp.h (buffer_overflow): New function.
10071 (insert_from_buffer_1, replace_range, replace_range_2):
10072 * insdel.c (make_gap_larger):
10073 * editfns.c (Finsert_char):
10074 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
10075
28177add
PE
10076 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
10077
e69dafad
PE
100782011-06-15 Paul Eggert <eggert@cs.ucla.edu>
10079
4baa020d 10080 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 10081
b1c46f02
PE
10082 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
10083 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
10084
e69dafad
PE
10085 * fileio.c: Don't assume EMACS_INT fits in off_t.
10086 (emacs_lseek): New static function.
10087 (Finsert_file_contents, Fwrite_region): Use it.
10088 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
10089
566684ea
PE
10090 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
10091
e6966cd6
PE
10092 * fns.c: Don't overflow int when computing a list length.
10093 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
10094 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
10095 truncation on 64-bit hosts. Check for QUIT every
10096 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
10097 faster and is responsive enough.
10098 (Flength): Report an error instead of overflowing an integer.
10099 (Fsafe_length): Return a float if the value is not representable
10100 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 10101 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 10102 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 10103
dd0b0efb
PE
10104 * alloc.c: Check that resized vectors' lengths fit in fixnums.
10105 (header_size, word_size): New constants.
10106 (allocate_vectorlike): Don't check size overflow here.
10107 (allocate_vector): Check it here instead, since this is the only
10108 caller of allocate_vectorlike that could cause overflow.
10109 Check that the new vector's length is representable as a fixnum.
10110
86fe5cfe
PE
10111 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
10112 The previous code was bogus. For example, next_almost_prime (32)
10113 returned 39, which is undesirable as it is a multiple of 3; and
10114 next_almost_prime (24) returned 25, which is a multiple of 5 so
10115 why was the code bothering to check for multiples of 7?
10116
80e88859
PE
10117 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
10118
4a2f0ad6
PE
10119 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
10120
f66c7cf8
PE
10121 Variadic C functions now count arguments with ptrdiff_t.
10122 This partly undoes my 2011-03-30 change, which replaced int with size_t.
10123 Back then I didn't know that the Emacs coding style prefers signed int.
10124 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
10125 were being counted with int, which may truncate counts on 64-bit
10126 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
10127 * lisp.h (struct Lisp_Subr.function.aMANY)
10128 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
10129 Arg counts are now ptrdiff_t, not size_t.
10130 All variadic functions and their callers changed accordingly.
10131 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
10132 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
10133 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
10134 * callint.c (Fcall_interactively): Check arg count for overflow,
10135 to avoid potential buffer overrun. Use signed char, not 'int',
10136 for 'varies' array, so that we needn't bother to check its size
10137 calculation for overflow.
10138 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
10139 * eval.c (apply_lambda):
10140 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
10141 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
10142 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
10143
a1759b76
PE
10144 * callint.c (Fcall_interactively): Don't use index var as event count.
10145
d96be9fc
PE
10146 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
10147 * mem-limits.h (SIZE): Remove; no longer used.
10148
a690a978 10149 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 10150
578c21e6
PE
10151 Remove unnecessary casts.
10152 * xterm.c (x_term_init):
10153 * xfns.c (x_set_border_pixel):
10154 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
10155 These aren't needed now that we assume ANSI C.
10156
96f53c6c
PE
10157 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
10158 It's more likely to cause problems (due to unsigned overflow)
10159 than to cure them.
10160
83c77d31
PE
10161 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
10162
ee2079f1
PE
10163 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
10164
6da65536
PE
10165 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
10166
7147c4a4
PE
10167 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
10168
193e32d9
PE
10169 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
10170
e5533da6
PE
10171 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
10172
9910e595
PE
10173 GLYPH_CODE_FACE returns EMACS_INT, not int.
10174 * dispextern.h (merge_faces):
10175 * xfaces.c (merge_faces):
01103c44
PE
10176 * xdisp.c (get_next_display_element, next_element_from_display_vector):
10177 Don't assume EMACS_INT fits in int.
9910e595 10178
2638320e
PE
10179 * character.h (CHAR_VALID_P): Remove unused parameter.
10180 * fontset.c, lisp.h, xdisp.c: All uses changed.
10181
045eb8d9
PE
10182 * editfns.c (Ftranslate_region_internal): Omit redundant test.
10183
c1f134b5
PE
10184 * fns.c (concat): Minor tuning based on overflow analysis.
10185 This doesn't fix any bugs. Use int to hold character, instead
10186 of constantly refetching from Emacs object. Use XFASTINT, not
10187 XINT, for value known to be a character. Don't bother comparing
10188 a single byte to 0400, as it's always less.
10189
395fcb93 10190 * floatfns.c (Fexpt):
327eeec8
PE
10191 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
10192
abbd3d23
PE
10193 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
10194 for characters.
10195
684a03ef
PE
10196 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
10197
0fed43f3
PE
10198 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
10199 Without this fix, on a 64-bit host (aset S 0 4294967386) would
10200 incorrectly succeed when S was a string, because 4294967386 was
10201 truncated before it was used.
10202
8fd02eb7
PE
10203 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
10204 Otherwise, an out-of-range integer could cause undefined behavior
10205 on a 64-bit host.
10206
f8c86b69
PE
10207 * composite.c: Use int, not EMACS_INT, for characters.
10208 (fill_gstring_body, composition_compute_stop_pos): Use int, not
10209 EMACS_INT, for values that are known to be in character range.
10210 This doesn't fix any bugs but is the usual style inside Emacs and
10211 may generate better code on 32-bit machines.
10212
34206dd2
PE
10213 Make sure a 64-bit char is never passed to ENCODE_CHAR.
10214 This is for reasons similar to the recent CHAR_STRING fix.
10215 * charset.c (Fencode_char): Check that character arg is actually
10216 a character. Pass an int to ENCODE_CHAR.
10217 * charset.h (ENCODE_CHAR): Verify that the character argument is no
10218 wider than 'int', as a compile-time check to prevent future regressions
10219 in this area.
10220
c5958d4c 10221 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
10222
10223 Make sure a 64-bit char is never passed to CHAR_STRING.
10224 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
10225 by silently ignoring the top 32 bits, allowing some values
10226 that were far too large to be valid characters.
10227 * character.h: Include <verify.h>.
10228 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
10229 arguments are no wider than unsigned, as a compile-time check
10230 to prevent future regressions in this area.
10231 * data.c (Faset):
01103c44 10232 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
10233 (Fsubst_char_in_region):
10234 * fns.c (concat):
10235 * xdisp.c (decode_mode_spec_coding):
10236 Adjust to CHAR_STRING's new requirement.
10237 * editfns.c (Finsert_char, Fsubst_char_in_region):
10238 * fns.c (concat): Check that character args are actually
10239 characters. Without this test, these functions did the wrong
10240 thing with wildly out-of-range values on 64-bit hosts.
10241
d37ca623
PE
10242 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
10243 These casts should not be needed on 32-bit hosts, either.
10244 * keyboard.c (read_char):
10245 * lread.c (Fload): Remove casts to unsigned.
10246
ea204efb
PE
10247 * lisp.h (UNSIGNED_CMP): New macro.
10248 This fixes comparison bugs on 64-bit hosts.
10249 (ASCII_CHAR_P): Use it.
10250 * casefiddle.c (casify_object):
01103c44 10251 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
10252 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
10253 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
10254 * dispextern.h (FACE_FROM_ID):
10255 * keyboard.c (read_char): Use UNSIGNED_CMP.
10256
41cb286c
PE
10257 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
10258 not to EMACS_INT, to avoid GCC warning.
10259
4a1b9832
PE
10260 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
10261
55daad71
PE
10262 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
10263 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
10264 isn't needed on 32-bit machines.
8f95c75c 10265
01103c44
PE
10266 * buffer.c (Fgenerate_new_buffer_name):
10267 Use EMACS_INT for count, not int.
0ceccced 10268 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
10269
10270 * data.c (Qcompiled_function): Now static.
10271
c6f072e7
PE
10272 * window.c (window_body_lines): Now static.
10273
20ce5912
PE
10274 * image.c (gif_load): Rename local to avoid shadowing.
10275
9c4c5f81
PE
10276 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
10277 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
10278 * alloc.c (make_save_value): Integer argument is now of type
10279 ptrdiff_t, not int.
10280 (mark_object): Use ptrdiff_t, not int.
10281 * lisp.h (pD): New macro.
10282 * print.c (print_object): Use it.
10283
c0c5c8ae
PE
10284 * alloc.c: Use EMACS_INT, not int, to count objects.
10285 (total_conses, total_markers, total_symbols, total_vector_size)
10286 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
10287 (total_free_floats, total_floats, total_free_intervals)
10288 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
10289 Now EMACS_INT, not int. All uses changed.
10290 (Fgarbage_collect): Compute overall total using a double, so that
10291 integer overflow is less likely to be a problem. Check for overflow
10292 when converting back to an integer.
5a25e253
PE
10293 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
10294 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
10295 These were 'int' variables that could overflow on 64-bit hosts;
10296 they were never used, so remove them instead of repairing them.
211a0b2a 10297 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
10298 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
10299 Previously, this ceilinged at INT_MAX, but that doesn't work on
10300 64-bit machines.
e46bb31a 10301 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 10302
c78baabf 10303 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 10304 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
10305 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
10306 when a (possibly-narrower) signed value would do just as well.
10307 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 10308
c9d624c6
PE
10309 * alloc.c: Catch some string size overflows that we were missing.
10310 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
10311 for convenience in STRING_BYTES_MAX.
10312 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
10313 The definition here is exact; the one in lisp.h was approximate.
10314 (allocate_string_data): Check for string overflow. This catches
10315 some instances we weren't catching before. Also, it catches
10316 size_t overflow on (unusual) hosts where SIZE_MAX <= min
10317 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
10318 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 10319
c9d624c6
PE
10320 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
10321 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 10322 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 10323
353032ce
PE
10324 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
10325
2bccce07
PE
10326 * alloc.c (Fmake_string): Check for out-of-range init.
10327
0ac30604
SM
103282011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
10329
10330 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
10331
c195f2de
JD
103322011-06-14 Jan Djärv <jan.h.d@swipnet.se>
10333
10334 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
10335 xg_get_default_scrollbar_width.
10336
10337 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
10338 (int_gtk_range_get_value): Move to the scroll bar part of the file.
10339 (style_changed_cb): Call update_theme_scrollbar_width and call
10340 x_set_scroll_bar_default_width and xg_frame_set_char_size for
10341 all frames (Bug#8505).
10342 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
10343 Call gtk_window_set_resizable if HAVE_GTK3.
10344 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
10345 and height if HAVE_GTK3 (Bug#8505).
10346 (scroll_bar_width_for_theme): New variable.
10347 (update_theme_scrollbar_width): New function.
10348 (xg_get_default_scrollbar_width): Move code to
10349 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
10350 (xg_initialize): Call update_theme_scrollbar_width.
10351
10352 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
10353
10354 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
10355
e10ac9f1
MR
103562011-06-12 Martin Rudalics <rudalics@gmx.at>
10357
10358 * frame.c (make_frame): Call other_buffer_safely instead of
10359 other_buffer.
10360
10361 * window.c (temp_output_buffer_show): Call display_buffer with
10362 second argument Vtemp_buffer_show_specifiers and reset latter
10363 immediately after the call.
10364 (Vtemp_buffer_show_specifiers): New variable.
10365 (auto_window_vscroll_p, next_screen_context_lines)
10366 (Vscroll_preserve_screen_position): Remove leading asterisks from
10367 doc-strings.
10368
2d3c217e 103692011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 10370
7b7f97e8 10371 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
10372 * buffer.c (Qclone_number): Remove for now, as it's unused.
10373 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
10374 (record_buffer): Remove unused local.
10375 * frame.c (other_visible_frames, frame_buffer_list): Now static.
10376 (set_frame_buffer_list): Remove; unused.
10377 * frame.h (other_visible_frames): Remove decl.
10378 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
10379 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
10380 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
10381 if HAVE_GPM.
10382 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
10383 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
10384 Define only if HAVE_GPM.
10385 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
10386 (update_hints_inhibit): Remove; never set. All uses removed.
10387 * widgetprv.h (emacsFrameClassRec): Remove decl.
10388 * window.c (delete_deletable_window): Now returns void, since it
10389 wasn't returning anything.
10390 (compare_window_configurations): Remove unused locals.
10391 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
10392 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
10393 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
10394 the same widths as pointers. This follows up on the 2011-05-06 patch.
10395 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
10396 * xterm.h: Likewise.
10397 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
10398
1384b89e
JB
103992011-06-12 Juanma Barranquero <lekktu@gmail.com>
10400
10401 * makefile.w32-in: Update dependencies.
10402 (LISP_H): Add lib/intprops.h.
10403
1100a63c
CY
104042011-06-11 Chong Yidong <cyd@stupidchicken.com>
10405
10406 * image.c (gif_load): Add animation frame delay to the metadata.
10407 (syms_of_image): Use DEFSYM. New symbol `delay'.
10408
6198ccd0
MR
104092011-06-11 Martin Rudalics <rudalics@gmx.at>
10410
10411 * window.c (delete_deletable_window): Re-add.
10412 (Fset_window_configuration): Rewrite to handle dead buffers and
10413 consequently deletable windows.
10414 (window_tree, Fwindow_tree): Remove. Supply functionality in
10415 window.el.
10416 (compare_window_configurations): Simplify code.
10417
b6e3633c
AS
104182011-06-11 Andreas Schwab <schwab@linux-m68k.org>
10419
1ab0dee5
AS
10420 * image.c (imagemagick_load_image): Fix type mismatch.
10421 (Fimagemagick_types): Likewise.
10422
b6e3633c
AS
10423 * window.h (replace_buffer_in_windows): Declare.
10424
9397e56f
MR
104252011-06-11 Martin Rudalics <rudalics@gmx.at>
10426
10427 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
10428 Qclone_number. Remove external declaration of Qdelete_window.
10429 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
10430 code.
640c8776
SM
10431 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
10432 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
10433 (Fother_buffer): Rewrite doc-string. Major rewrite for new
10434 buffer list implementation.
10435 (other_buffer_safely): New function.
10436 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
10437 calls to replace_buffer_in_windows and
10438 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
10439 if allowed.
10440 (record_buffer): Inhibit quitting and rewrite using quittable
10441 functions. Run Qbuffer_list_update_hook if allowed.
10442 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
10443 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
10444 Move switch-to-buffer to window.el.
9397e56f
MR
10445 (bury-buffer): Move to window.el.
10446 (Vbuffer_list_update_hook): New variable.
10447
10448 * lisp.h (other_buffer_safely): Add prototype in buffer.c
10449 section.
10450
10451 * window.h (resize_frame_windows): Move up in code.
10452 (Fwindow_frame): Remove EXFUN.
10453 (replace_buffer_in_all_windows): Remove prototype.
10454 (replace_buffer_in_windows_safely): Add prototype.
10455
10456 * window.c: Declare Qdelete_window static again. Move down
10457 declaration of select_count.
10458 (Fnext_window, Fprevious_window): Rewrite doc-strings.
10459 (Fother_window): Move to window.el.
10460 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
10461 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
10462 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
10463 window.el.
10464 (replace_buffer_in_windows): Implement by calling
10465 Qreplace_buffer_in_windows.
10466 (replace_buffer_in_all_windows): Remove with some functionality
10467 moved into replace_buffer_in_windows_safely.
10468 (replace_buffer_in_windows_safely): New function.
10469 (select_window_norecord, select_frame_norecord): Move in front
10470 of run_window_configuration_change_hook. Remove now obsolete
10471 declarations.
640c8776
SM
10472 (Fset_window_buffer): Rewrite doc-string.
10473 Call Qrecord_window_buffer.
9397e56f
MR
10474 (keys_of_window): Move binding for other-window to window.el.
10475
b50691aa
CY
104762011-06-11 Chong Yidong <cyd@stupidchicken.com>
10477
10478 * dispextern.h (struct image): Replace data member, whose int_val
10479 and ptr_val fields were not used by anything, with a single
10480 lisp_val object.
10481
10482 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
10483 (gif_clear_image, gif_load, imagemagick_load_image)
10484 (gs_clear_image, gs_load): Callers changed.
10485
3f754b86
PE
104862011-06-10 Paul Eggert <eggert@cs.ucla.edu>
10487
cca69397
PE
10488 * buffer.h: Include <time.h>, for time_t.
10489 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
10490
109e28d0
PE
10491 Fix minor problems found by static checking.
10492
60737f02
PE
10493 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
10494
4b66faf3
PE
10495 Make identifiers static if they are not used in other modules.
10496 * data.c (Qcompiled_function, Qframe, Qvector):
10497 * image.c (QimageMagick, Qsvg):
10498 * minibuf.c (Qmetadata):
10499 * window.c (resize_window_check, resize_root_window): Now static.
10500 * window.h (resize_window_check, resize_root_window): Remove decls.
10501
109e28d0
PE
10502 * window.c (window_deletion_count, delete_deletable_window):
10503 Remove; unused.
46a4ce9e
PE
10504 (window_body_lines): Now static.
10505 (Fdelete_other_windows_internal): Mark vars as initialized.
10506 Make sure 'resize_failed' is initialized.
10507 (run_window_configuration_change_hook): Rename local to avoid shadowing.
10508 (resize_window_apply): Remove unused local.
10509 * window.h (delete_deletable_window): Remove decl.
10510
109e28d0 10511 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
10512 (imagemagick_load_image): Fix pointer signedness problem by changing
10513 last arg from unsigned char * to char *. All uses changed.
10514 Also, fix a local for similar reasons.
10515 Remove unused locals. Remove locals to avoid shadowing.
10516 (fn_rsvg_handle_free): Remove; unused.
10517 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 10518 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 10519
3f754b86
PE
10520 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
10521
2547adb1
CY
105222011-06-10 Chong Yidong <cyd@stupidchicken.com>
10523
10524 * image.c (gif_load): Fix omitted cast error introduced by
10525 2011-06-06 change.
10526
2c8e37d4
MR
105272011-06-10 Martin Rudalics <rudalics@gmx.at>
10528
10529 * window.h (resize_proportionally, orig_total_lines)
10530 (orig_top_line): Remove from window structure.
10531 (set_window_height, set_window_width, change_window_heights)
10532 (Fdelete_window): Remove prototypes.
10533 (resize_frame_windows): Remove duplicate declaration.
10534
440a42e3
EZ
105352011-06-10 Eli Zaretskii <eliz@gnu.org>
10536
10537 * window.h (resize_frame_windows, resize_window_check)
10538 (delete_deletable_window, resize_root_window)
10539 (resize_frame_windows): Declare prototypes.
10540
10541 * window.c (resize_window_apply): Make definition be "static" to
10542 match the prototype.
10543
562dd5e9
MR
105442011-06-10 Martin Rudalics <rudalics@gmx.at>
10545
10546 * window.c: Remove declarations of Qwindow_size_fixed,
10547 window_min_size_1, window_min_size_2, window_min_size,
10548 size_window, window_fixed_size_p, enlarge_window, delete_window.
10549 Remove static from declaration of Qdelete_window, it's
10550 temporarily needed by Fbury_buffer.
10551 (replace_window): Don't assign orig_top_line and
10552 orig_total_lines.
10553 (Fdelete_window, delete_window): Remove. Window deletion is
10554 handled by window.el.
640c8776
SM
10555 (window_loop): Remove DELETE_OTHER_WINDOWS case.
10556 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
10557 (Fdelete_other_windows): Remove. Deleting other windows is
10558 handled by window.el.
10559 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
10560 handled in window.el.
10561 (window_min_size_2, window_min_size_1, window_min_size): Remove.
10562 Window minimum sizes are handled in window.el.
10563 (shrink_windows, size_window, set_window_height)
10564 (set_window_width, change_window_heights, window_height)
10565 (window_width, CURBEG, CURSIZE, enlarge_window)
10566 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
10567 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
10568 handled in window.el.
10569 (make_dummy_parent): Rename to make_parent_window and give it a
10570 second argument horflag.
10571 (make_window): Don't set resize_proportionally any more.
10572 (Fsplit_window): Remove. Windows are split in window.el.
10573 (save_restore_action, save_restore_orig_size)
10574 (shrink_window_lowest_first, save_restore_orig_size): Remove.
10575 Resize mini windows in window.el.
10576 (grow_mini_window, shrink_mini_window): Implement by calling
10577 Qresize_root_window_vertically, resize_window_check and
10578 resize_window_apply.
640c8776
SM
10579 (saved_window, Fset_window_configuration, save_window_save):
10580 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
10581 resize_proportionally.
10582 (window_min_height, window_min_width): Move to window.el.
10583 (keys_of_window): Move bindings for delete-other-windows,
10584 split-window, delete-window and enlarge-window to window.el.
10585
10586 * buffer.c: Temporarily extern Qdelete_window.
10587 (Fbury_buffer): Temporarily call Qdelete_window instead of
10588 Fdelete_window (Fbury_buffer will move to window.el soon).
10589
10590 * frame.c (set_menu_bar_lines_1): Remove code handling
10591 orig_top_line and orig_total_lines.
10592
10593 * dispnew.c (adjust_frame_glyphs_initially): Don't use
10594 set_window_height but set heights directly.
10595 (change_frame_size_1): Use resize_frame_windows.
10596
10597 * xdisp.c (init_xdisp): Don't use set_window_height but set
10598 heights directly.
10599
640c8776
SM
10600 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
10601 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
10602 run_window_configuration_change_hook.
10603
10604 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
10605 instead of change_window_heights and run
10606 run_window_configuration_change_hook.
10607
1a13852e
MR
106082011-06-09 Martin Rudalics <rudalics@gmx.at>
10609
10610 * window.c (replace_window): Rename second argument REPLACEMENT to
10611 NEW. New third argument SETFLAG. Rewrite.
10612 (delete_window, make_dummy_parent): Call replace_window with
10613 third argument 1.
10614 (window_list_1): Move down in code.
10615 (run_window_configuration_change_hook): Move set_buffer part
10616 before select_frame_norecord part in order to unwind correctly.
10617 Rename count1 to count.
10618 (recombine_windows, delete_deletable_window, resize_root_window)
10619 (Fdelete_other_windows_internal)
10620 (Frun_window_configuration_change_hook, make_parent_window)
10621 (resize_window_check, resize_window_apply, Fresize_window_apply)
10622 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
10623 (Fdelete_window_internal, Fresize_mini_window_internal):
10624 New functions.
1a13852e
MR
10625 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
10626
f3d1777e
MR
106272011-06-08 Martin Rudalics <rudalics@gmx.at>
10628
496e208e
MR
10629 * window.h (window): Add some new members to window structure -
10630 normal_lines, normal_cols, new_total, new_normal, clone_number,
10631 splits, nest, prev_buffers, next_buffers.
10632 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 10633 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 10634
f3d1777e
MR
10635 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
10636 Remove.
496e208e
MR
10637 (make_dummy_parent): Set new members of windows structure.
10638 (make_window): Move down in code. Handle new members of window
10639 structure.
10640 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
10641 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
10642 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
10643 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
10644 (Fset_window_next_buffers, Fset_window_clone_number):
10645 New functions.
496e208e
MR
10646 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
10647 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
10648 Doc-string fixes.
10649 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
10650 Argument WINDOW can be now internal window too.
10651 (Fwindow_use_time): Move up in code.
10652 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
10653 Rewrite doc-string.
10654 (Fset_window_configuration, saved_window)
10655 (Fcurrent_window_configuration, save_window_save): Handle new
10656 members of window structure.
b9e809c2
MR
10657 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
10658 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
10659 (syms_of_window): New Lisp objects Qrecord_window_buffer,
10660 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
10661 Qget_mru_window, Qresize_root_window,
10662 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
10663 Qauto_buffer_name; staticpro them.
f3d1777e 10664
abde8f8c
MR
106652011-06-07 Martin Rudalics <rudalics@gmx.at>
10666
10667 * window.c (Fwindow_total_size, Fwindow_left_column)
10668 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
10669 (Fwindow_list_1): New functions.
10670 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
10671 (Fwindow_width, Fscroll_left, Fscroll_right):
10672 Use window_body_cols instead of window_box_text_cols.
10673 (delete_window, Fset_window_configuration):
10674 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
10675 (delete_all_subwindows): Take a window as argument and not a
10676 structure. Rewrite.
190b47e6
MR
10677 (window_loop): Remove handling of GET_LRU_WINDOW and
10678 GET_LARGEST_WINDOW.
10679 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
10680
10681 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
10682 window_box_text_cols. delete_all_subwindows now takes a
10683 Lisp_Object as argument.
abde8f8c 10684
640c8776
SM
10685 * indent.c (compute_motion, Fcompute_motion):
10686 Use window_body_cols instead of window_box_text_cols.
abde8f8c 10687
fa8a67e6
MR
10688 * frame.c (delete_frame): Call delete_all_subwindows with root
10689 window as argument.
10690
a54e3482
DC
106912011-06-07 Daniel Colascione <dan.colascione@gmail.com>
10692
10693 * fns.c (Fputhash): Document return value.
10694
60002bf5
CY
106952011-06-06 Chong Yidong <cyd@stupidchicken.com>
10696
10697 * image.c (gif_load): Implement gif89a spec "no disposal" method.
10698
0c671da6 106992011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 10700
b862a52a 10701 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 10702
be44ca6c
PE
10703 Check for overflow when converting integer to cons and back.
10704 * charset.c (Fdefine_charset_internal, Fdecode_char):
10705 Use cons_to_unsigned to catch overflow.
10706 (Fencode_char): Use INTEGER_TO_CONS.
10707 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
10708 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
10709 * data.c (long_to_cons, cons_to_long): Remove.
10710 (cons_to_unsigned, cons_to_signed): New functions.
10711 These signal an error for invalid or out-of-range values.
10712 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
10713 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
10714 * font.c (Ffont_variation_glyphs):
10715 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
10716 * lisp.h: Include <intprops.h>.
10717 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
10718 (cons_to_signed, cons_to_unsigned): New decls.
10719 (long_to_cons, cons_to_long): Remove decls.
10720 * undo.c (record_first_change): Use INTEGER_TO_CONS.
10721 (Fprimitive_undo): Use CONS_TO_INTEGER.
10722 * xfns.c (Fx_window_property): Likewise.
10723 * xselect.c: Include <limits.h>.
10724 (x_own_selection, selection_data_to_lisp_data):
10725 Use INTEGER_TO_CONS.
10726 (x_handle_selection_request, x_handle_selection_clear)
10727 (x_get_foreign_selection, Fx_disown_selection_internal)
10728 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
10729 (lisp_data_to_selection_data): Use cons_to_unsigned.
10730 (x_fill_property_data): Use cons_to_signed.
10731 Report values out of range.
10732
d1f3d2af
PE
10733 Check for buffer and string overflow more precisely.
10734 * buffer.h (BUF_BYTES_MAX): New macro.
10735 * lisp.h (STRING_BYTES_MAX): New macro.
10736 * alloc.c (Fmake_string):
10737 * character.c (string_escape_byte8):
10738 * coding.c (coding_alloc_by_realloc):
10739 * doprnt.c (doprnt):
10740 * editfns.c (Fformat):
10741 * eval.c (verror):
10742 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
10743 since they may not be the same number.
10744 * editfns.c (Finsert_char):
10745 * fileio.c (Finsert_file_contents):
10746 Likewise for BUF_BYTES_MAX.
10747
dd52fcea
PE
10748 * image.c: Use ptrdiff_t, not int, for sizes.
10749 (slurp_file): Switch from int to ptrdiff_t.
10750 All uses changed.
10751 (slurp_file): Check that file size fits in both size_t (for
10752 malloc) and ptrdiff_t (for sanity and safety).
10753
7f9bbdbb
PE
10754 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
10755 if b->modtime has its maximal value.
10756
dfe18f82
PE
10757 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
10758
84acfcf0
PE
10759 Don't assume time_t can fit into int.
10760 * buffer.h (struct buffer.modtime): Now time_t, not int.
10761 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
10762 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
10763
ccd9a01a
PE
10764 Minor fixes for signed vs unsigned integers.
10765 * character.h (MAYBE_UNIFY_CHAR):
10766 * charset.c (maybe_unify_char):
10767 * keyboard.c (read_char, reorder_modifiers):
10768 XINT -> XFASTINT, since the integer must be nonnegative.
10769 * ftfont.c (ftfont_spec_pattern):
10770 * keymap.c (access_keymap, silly_event_symbol_error):
10771 XUINT -> XFASTINT, since the integer must be nonnegative.
10772 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
10773 since it makes no difference and we prefer signed.
10774 * keyboard.c (record_char): Use XUINT when all the neighbors do.
10775 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
10776 nonnegative.
10777
d6d100dd
SM
107782011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
10779
10780 * window.h (Fwindow_frame): Declare.
10781
2b6148e4
PE
107822011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10783
10784 * alloc.c: Simplify handling of large-request failures (Bug#8800).
10785 (SPARE_MEMORY): Always define.
10786 (LARGE_REQUEST): Remove.
10787 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
10788
f230ecc9
MR
107892011-06-06 Martin Rudalics <rudalics@gmx.at>
10790
727e958e
MR
10791 * lisp.h: Move EXFUNS for Fframe_root_window,
10792 Fframe_first_window and Fset_frame_selected_window to window.h.
10793
10794 * window.h: Move EXFUNS for Fframe_root_window,
10795 Fframe_first_window and Fset_frame_selected_window here from
10796 lisp.h.
10797
10798 * frame.c (Fwindow_frame, Fframe_first_window)
10799 (Fframe_root_window, Fframe_selected_window)
10800 (Fset_frame_selected_window): Move to window.c.
10801 (Factive_minibuffer_window): Move to minibuf.c.
10802 (Fother_visible_frames_p): New function.
10803
10804 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
10805
f230ecc9
MR
10806 * window.c (decode_window, decode_any_window): Move up in code.
10807 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
10808 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
10809 (Fwindow_buffer): Move up and rewrite doc-string.
10810 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
10811 (Fwindow_prev): New functions.
727e958e
MR
10812 (Fwindow_frame): Move here from frame.c. Accept any window as
10813 argument.
10814 (Fframe_root_window, Fframe_first_window)
10815 (Fframe_selected_window): Move here from frame.c. Accept frame
10816 or arbitrary window as argument. Update doc-strings.
10817 (Fminibuffer_window): Move up in code.
10818 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
10819 (Fset_frame_selected_window): Move here from frame.c.
10820 Marginal rewrite.
727e958e
MR
10821 (Fselected_window, select_window, Fselect_window): Move up in
10822 code. Minor doc-string fixes.
f230ecc9 10823
4d09bcf6
PE
108242011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10825
10826 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
10827 Do not assume that spare memory exists; that assumption is valid
10828 only if SYSTEM_MALLOC.
10829 (LARGE_REQUEST): New macro, so that the issue of large requests
10830 is separated from the issue of spare memory.
10831
810928a2
AS
108322011-06-05 Andreas Schwab <schwab@linux-m68k.org>
10833
172418ad
AS
10834 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
10835 format. (Bug#8806)
10836
43f862f7
AS
10837 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
10838
810928a2
AS
10839 * xfns.c (x_set_scroll_bar_default_width): Move declarations
10840 before statements.
10841
a059fe24
JD
108422011-06-05 Jan Djärv <jan.h.d@swipnet.se>
10843
10844 * gtkutil.c (xg_get_default_scrollbar_width): New function.
10845
10846 * gtkutil.h: Declare xg_get_default_scrollbar_width.
10847
10848 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
10849 min width by calling x_set_scroll_bar_default_width (Bug#8505).
10850
989bf368
JB
108512011-06-05 Juanma Barranquero <lekktu@gmail.com>
10852
10853 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
10854
4b80f674
CY
108552011-06-04 Chong Yidong <cyd@stupidchicken.com>
10856
10857 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
10858 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
10859 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
10860 New error handlers.
4b80f674
CY
10861 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
10862 Obey Vx_select_enable_clipboard_manager. Catch errors in
10863 x_clipboard_manager_save (Bug#8779).
10864 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 10865 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 10866
99a33b77 108672011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
10868
10869 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
10870
99a33b77 108712011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
10872
10873 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
10874 in the current matrix if keep_current_p is non-zero.
10875
8264569d
EZ
108762011-06-04 Eli Zaretskii <eliz@gnu.org>
10877
10878 * bidi.c (bidi_level_of_next_char): Fix last change.
10879
57f97249
EZ
108802011-06-03 Eli Zaretskii <eliz@gnu.org>
10881
fec2107c 10882 Support bidi reordering of text covered by display properties.
57f97249 10883
fec2107c
EZ
10884 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
10885 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
10886 (bidi_cache_search, bidi_cache_iterator_state)
10887 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
10888 (bidi_level_of_next_char, bidi_move_to_visually_next):
10889 Support character positions inside a run of characters covered by a
fec2107c
EZ
10890 display string.
10891 (bidi_paragraph_init, bidi_resolve_explicit_1)
10892 (bidi_level_of_next_char): Call bidi_fetch_char and
10893 bidi_fetch_char_advance instead of FETCH_CHAR and
10894 FETCH_CHAR_ADVANCE.
10895 (bidi_init_it): Initialize new members.
10896 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
10897 definitions.
10898 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
10899 instead of using explicit *_CHAR codes.
d6d100dd
SM
10900 (bidi_resolve_explicit, bidi_resolve_weak):
10901 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
10902 bidirectional text is supported only in multibyte buffers.
10903 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
10904 it to initialize the frame_window_p member of struct bidi_it.
10905 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
10906 (bidi_resolve_explicit, bidi_resolve_weak)
10907 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
10908 bidi_it->nchars is non-positive.
10909 (bidi_level_of_next_char): Don't try to lookup the cache for the
10910 next/previous character if nothing is cached there yet, or if we
10911 were just reseat()'ed to a new position.
c40e2fb2 10912
0e14fe90
EZ
10913 * xdisp.c (set_cursor_from_row): Set start and stop points
10914 according to the row's direction when priming the loop that looks
10915 for the glyph on which to display cursor.
10916 (single_display_spec_intangible_p): Function deleted.
10917 (display_prop_intangible_p): Reimplement to call
10918 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
10919 Accept 3 additional arguments needed by handle_display_spec.
10920 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
10921 values: lists, `(when COND...)' forms, etc.
10922 (single_display_spec_string_p): Support property values that are
10923 lists with the argument STRING its top-level element.
10924 (display_prop_string_p): Fix the condition for processing a
10925 property that is a list to be consistent with handle_display_spec.
fec2107c 10926 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
10927 last portion of handle_display_prop.
10928 (compute_display_string_pos): Accept additional argument
10929 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
10930 value of a `display' property is a "replacing spec".
10931 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
10932 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
10933 the display property, but just return a value indicating whether
10934 the display property will replace the characters it covers.
10935 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
10936 frame_window_p members of struct bidi_it.
d6d100dd
SM
10937 (compute_display_string_pos, compute_display_string_end):
10938 New functions.
fec2107c
EZ
10939 (push_it): Accept second argument POSITION, where pop_it should
10940 jump to continue iteration.
10941 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 10942
fec2107c
EZ
10943 * keyboard.c (adjust_point_for_property): Adjust the call to
10944 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
10945
10946 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
10947 (bidi_init_it): Update prototypes.
10948 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
10949 (compute_display_string_pos, compute_display_string_end):
10950 Declare prototypes.
fec2107c
EZ
10951 (struct bidi_it): New members nchars and disp_pos. ch_len is now
10952 EMACS_INT.
fc6f18ce 10953
40087514 109542011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 10955
57f53182
PE
10956 Malloc failure behavior now depends on size of allocation.
10957 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
10958 * lisp.h: Change signatures accordingly.
10959 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
10960 All callers changed. (Bug#8762)
10961
10962 * gnutls.c: Use Emacs's memory allocators.
10963 Without this change, the gnutls library would invoke malloc etc.
10964 directly, which causes problems on non-SYNC_INPUT hosts, and which
10965 runs afoul of improving memory_full behavior. (Bug#8761)
10966 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
10967 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
10968 xfree instead of the default malloc, realloc, free.
10969 (Fgnutls_boot): No need to check for memory allocation failure,
10970 since xmalloc does that for us.
10971
ac32cd99 10972 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
10973 * category.c (hash_get_category_set):
10974 * ccl.c (ccl_driver):
10975 * charset.c (Fdefine_charset_internal):
10976 * charset.h (struct charset.hash_index):
10977 * composite.c (get_composition_id, gstring_lookup_cache)
10978 (composition_gstring_put_cache):
10979 * composite.h (struct composition.hash_index):
10980 * dispextern.h (struct image.hash):
10981 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
10982 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
10983 (hashfn_equal, hashfn_user_defined, make_hash_table)
10984 (maybe_resize_hash_table, hash_lookup, hash_put)
10985 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
10986 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
10987 (Fsxhash, Fgethash, Fputhash, Fmaphash):
10988 * image.c (make_image, search_image_cache, lookup_image)
10989 (xpm_put_color_table_h):
10990 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 10991 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 10992 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 10993 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
10994 * alloc.c (allocate_vectorlike):
10995 Check for overflow in vector size calculations.
10996 * ccl.c (ccl_driver):
10997 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
10998 * fns.c, image.c: Remove unnecessary static decls that would otherwise
10999 need to be updated by these changes.
40087514
PE
11000 * fns.c (make_hash_table, maybe_resize_hash_table):
11001 Check for integer overflow with large hash tables.
0de4bb68
PE
11002 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
11003 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
11004 (SXHASH_REDUCE): New macro.
11005 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
11006 Use it instead of discarding useful hash info with large hash values.
11007 (sxhash_float): New function.
11008 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
11009 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
11010 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
11011 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
11012 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
11013 Adjust signatures to match updated version of code.
11014 (consing_since_gc): Now EMACS_INT, since a single hash table can
11015 use more than INT_MAX bytes.
11016
698d32e2
DN
110172011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
11018
11019 Make it possible to build with GCC-4.6+ -O2 -flto.
11020
11021 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
11022
fd6fa53f
SM
110232011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
11024
11025 * minibuf.c (get_minibuffer, read_minibuf_unwind):
11026 Call minibuffer-inactive-mode.
11027
864db017
JB
110282011-05-31 Juanma Barranquero <lekktu@gmail.com>
11029
11030 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
11031 Update dependencies.
11032
2ad0baf4
DN
110332011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11034
11035 * data.c (init_data): Remove code for UTS, this system is not
11036 supported anymore.
11037
4fcc2638
DN
110382011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11039
11040 Don't force ./temacs to start in terminal mode.
11041
11042 * frame.c (make_initial_frame): Initialize faces in all cases, not
11043 only when CANNOT_DUMP is defined.
11044 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
11045
c56e0fd5
DN
110462011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11047
11048 * dispnew.c (add_window_display_history): Use const for the string
11049 pointer. Remove declaration, not needed.
11050
333d54da 110512011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 11052
55d4c1b2 11053 Use 'inline', not 'INLINE'.
333d54da 11054 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
11055 * alloc.c, fontset.c (INLINE): Remove.
11056 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
11057 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
11058 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
11059 * gmalloc.c (register_heapinfo): Use inline unconditionally.
11060 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
11061
738db178
DN
110622011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11063
11064 Make it possible to run ./temacs.
11065
11066 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
11067 syms_of_callproc does the same thing. Remove test for
11068 "initialized", do it in the caller.
11069 * emacs.c (main): Avoid calling set_initial_environment when dumping.
11070
620c53a6
SM
110712011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
11072
11073 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
11074 (read_minibuf): Use get_minibuffer.
11075 (syms_of_minibuf): Use DEFSYM.
11076 (Qmetadata): New var.
11077 * data.c (Qbuffer): Don't make it static.
11078 (syms_of_data): Use DEFSYM.
11079
e003a292
PE
110802011-05-31 Paul Eggert <eggert@cs.ucla.edu>
11081
11082 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
11083 (CCL_CODE_MIN): New macro.
11084
ed008a6d
PE
110852011-05-30 Paul Eggert <eggert@cs.ucla.edu>
11086
3687c2ef
PE
11087 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
11088
ed008a6d
PE
11089 * eval.c (Qdebug): Now static.
11090 * lisp.h (Qdebug): Remove decl. This reverts a part of the
11091 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
11092 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
11093
d66c4c7c
CY
110942011-05-29 Chong Yidong <cyd@stupidchicken.com>
11095
11096 * image.c: Various fixes to ImageMagick code comments.
11097 (Fimagemagick_types): Doc fix.
11098
5fbc2025
PE
110992011-05-29 Paul Eggert <eggert@cs.ucla.edu>
11100
0196f88a
PE
11101 Minor fixes prompted by GCC 4.6.0 warnings.
11102
11103 * xselect.c (converted_selections, conversion_fail_tag): Now static.
11104
5fbc2025
PE
11105 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
11106 (x_clipboard_manager_save_all): Move extern decl to ...
11107 * xterm.h: ... here, so that it can be checked for consistency.
11108
1dd3c2d9
CY
111092011-05-29 Chong Yidong <cyd@stupidchicken.com>
11110
11111 * xselect.c (x_clipboard_manager_save_frame)
11112 (x_clipboard_manager_save_all): New functions.
11113 (Fx_clipboard_manager_save): Lisp function deleted.
11114
11115 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
11116 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
11117
11118 * xterm.h: Update prototype.
11119
5ba6571d
WX
111202011-05-28 William Xu <william.xwl@gmail.com>
11121
11122 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
11123 exiting (Bug#8239).
11124
3eaff834
JM
111252011-05-28 Jim Meyering <meyering@redhat.com>
11126
e1900994 11127 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
11128 * fns.c (to_uchar): Define.
11129 (crypto_hash_function): Use it to convert some newly-signed
11130 variables to unsigned, to avoid sign-extension bugs. For example,
11131 without this change, (md5 "truc") would evaluate to
11132 45723a2aff78ff4fff7fff1114760e62 rather than the expected
11133 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 11134 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 11135
0f6990a7
PE
111362011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11137
11138 Integer overflow fixes.
c8a9ca5a 11139
08686060
PE
11140 * dbusbind.c: Serial number integer overflow fixes.
11141 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
11142 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
11143 to hold a serial number that is too large for a fixnum.
11144 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11145 Check for serial numbers out of range. Decode any serial number
59568bf0 11146 that was so large that it became a float. (Bug#8722)
08686060 11147
2d1fc3c7
PE
11148 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
11149 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11150 Use XFASTINT rather than XUINT when numbers are nonnegative.
11151 (xd_append_arg, Fdbus_method_return_internal):
11152 (Fdbus_method_error_internal): Likewise. Also, for unsigned
11153 arguments, check that Lisp number is nonnegative, rather than
59568bf0 11154 silently wrapping negative numbers around. (Bug#8722)
30217ff0 11155 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 11156 (Bug#8722)
2d1fc3c7 11157
c8a9ca5a
PE
11158 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
11159
519e1d69
PE
11160 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
11161
6df6ae42 11162 ccl: Add integer overflow checks.
30569699
PE
11163 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
11164 (IN_INT_RANGE): New macros.
11165 (ccl_driver): Use them to check for integer overflow when
11166 decoding a CCL program. Many of the new checks are whether XINT (x)
11167 fits in int; it doesn't always, on 64-bit hosts. The new version
11168 doesn't catch all possible integer overflows, but it's an
847044ea 11169 improvement. (Bug#8719)
30569699 11170
c11285dc
PE
11171 * alloc.c (make_event_array): Use XINT, not XUINT.
11172 There's no need for unsigned here.
11173
fdccd48e
PE
11174 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
11175 This follows up to the 2011-05-06 change that substituted uintptr_t
11176 for EMACS_INT. This case wasn't caught back then.
11177
37910ab2
PE
11178 Rework Fformat to avoid integer overflow issues.
11179 * editfns.c: Include <float.h> unconditionally, as it's everywhere
11180 now (part of C89). Include <verify.h>.
11181 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
11182 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
11183 (Fformat): Avoid the prepass trying to compute sizes; it was only
11184 approximate and thus did not catch overflow reliably. Instead, walk
11185 through the format just once, formatting and computing sizes as we go,
11186 checking for integer overflow at every step, and allocating a larger
11187 buffer as needed. Keep track separately whether the format is
11188 multibyte. Keep only the most-recently calculated precision, rather
11189 than them all. Record whether each argument has been converted to
11190 string. Use EMACS_INT, not int, for byte and char and arg counts.
11191 Support field widths and precisions larger than INT_MAX. Avoid
11192 sprintf's undefined behavior with conversion specifications such as %#d
11193 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
11194 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
11195 formatting out-of-range floating point numbers with int
9173deec 11196 formats. (Bug#8668)
37910ab2 11197
2e6578fb
PE
11198 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
11199
0ae6bdee
PE
11200 * data.c: Avoid integer truncation in expressions involving floats.
11201 * data.c: Include <intprops.h>.
11202 (arith_driver): When there's an integer overflow in an expression
11203 involving floating point, convert the integers to floating point
11204 so that the resulting value does not suffer from catastrophic
11205 integer truncation. For example, on a 64-bit host (* 4
11206 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
11207 Do not rely on undefined behavior after integer overflow.
11208
de883a70
PE
11209 merge count_size_as_multibyte, parse_str_to_multibyte
11210 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 11211 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
11212 Check for integer overflow.
11213 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
11214 since it's now a duplicate of the other. This is more of
11215 a character than a buffer op, so better that it's in character.c.
11216 * fns.c, print.c: Adjust to above changes.
11217
2ff916cb
PE
112182011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
11219
11220 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
11221
f1b54466
PE
112222011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11223
fb1ac845
PE
11224 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11225 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
11226 (x_clipboard_manager_save): Now static.
11227 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
11228
f1b54466
PE
11229 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11230 (crypto_hash_function): Now static.
11231 Fix pointer signedness problems. Avoid unnecessary initializations.
11232
a9f737ee
CY
112332011-05-27 Chong Yidong <cyd@stupidchicken.com>
11234
11235 * termhooks.h (Vselection_alist): Make it terminal-local.
11236
11237 * terminal.c (create_terminal): Initialize it.
11238
11239 * xselect.c: Support for clipboard managers.
11240 (Vselection_alist): Move to termhooks.h as terminal-local var.
11241 (LOCAL_SELECTION): New macro.
11242 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
11243 (symbol_to_x_atom): Remove gratuitous arg.
11244 (x_handle_selection_request, lisp_data_to_selection_data)
11245 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
11246 (x_own_selection, x_get_local_selection, x_convert_selection):
11247 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
11248 (some_frame_on_display): Delete unused function.
11249 (Fx_own_selection_internal, Fx_get_selection_internal)
11250 (Fx_disown_selection_internal, Fx_selection_owner_p)
11251 (Fx_selection_exists_p): New optional frame arg.
11252 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
11253 (x_handle_selection_clear): Don't treat other terminals with the
11254 same keyboard specially. Use the terminal-local Vselection_alist.
11255 (x_clear_frame_selections): Use Frun_hook_with_args.
11256
11257 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
11258
11259 * xterm.h: Add support for those atoms.
11260
e067f0c1
CY
112612011-05-26 Chong Yidong <cyd@stupidchicken.com>
11262
11263 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
11264 (converted_selections, conversion_fail_tag): New global variables.
11265 (x_selection_request_lisp_error): Free the above.
11266 (x_get_local_selection): Remove unnecessary code.
11267 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
11268 of converted selections stored in converted_selections.
11269 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
11270 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
11271 (x_convert_selection): New function.
11272 (x_handle_selection_event): Simplify.
11273 (x_get_foreign_selection): Don't ignore incoming requests while
11274 waiting for an answer; this will fail when we implement
11275 SAVE_TARGETS, and seems unnecessary anyway.
11276 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
11277 (Vx_sent_selection_functions): Doc fix.
11278
0f4aebc0
LL
112792011-05-26 Leo Liu <sdl.web@gmail.com>
11280
11281 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
11282
e61124cd
YM
112832011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11284
11285 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
11286
11287 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
11288 for fringe update if it has periodic bitmap.
ac389d0c 11289 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
11290 and fringe_bitmap_periodic_p.
11291
11292 * fringe.c (get_fringe_bitmap_data): New function.
11293 (draw_fringe_bitmap_1, update_window_fringes): Use it.
11294 (update_window_fringes): Record periodicity of fringe bitmap in glyph
11295 row. Mark glyph row for fringe update if periodicity changed.
11296
11297 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
11298 for fringe update unless it has periodic bitmap.
11299
f16d9837
KH
113002011-05-25 Kenichi Handa <handa@m17n.org>
11301
11302 * xdisp.c (get_next_display_element): Set correct it->face_id for
11303 a static composition.
11304
e1b90ef6
LL
113052011-05-24 Leo Liu <sdl.web@gmail.com>
11306
11307 * deps.mk (fns.o):
11308 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
11309
11310 * fns.c (crypto_hash_function, Fsha1): New function.
11311 (Fmd5): Use crypto_hash_function.
11312 (syms_of_fns): Add Ssha1.
11313
7400048f
PE
113142011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11315
11316 * gnutls.c: Remove unused macros.
11317 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
11318 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
11319 Remove macros that are defined and never used.
11320 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
11321
abb71cf4
CY
113222011-05-22 Chong Yidong <cyd@stupidchicken.com>
11323
11324 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
11325 (Fx_get_selection_internal): Minor cleanup.
11326 (Fx_own_selection_internal): Rename arguments for consistency with
11327 select.el.
11328
6307db39
PE
113292011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11330
11331 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
11332
f3d4e0a4
CY
113332011-05-22 Chong Yidong <cyd@stupidchicken.com>
11334
11335 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
11336
4d8ade89
YM
113372011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11338
11339 * dispnew.c (scrolling_window): Don't exclude the case that the
11340 last enabled row in the desired matrix touches the bottom boundary.
11341
32078c8d
GM
113422011-05-21 Glenn Morris <rgm@gnu.org>
11343
11344 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
11345 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
11346 and add some more files.
32078c8d 11347
7285dc67
EZ
113482011-05-20 Eli Zaretskii <eliz@gnu.org>
11349
11350 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
11351 report_file_error introduced by the change from 2011-05-07.
11352
89d1bd22
PE
113532011-05-20 Paul Eggert <eggert@cs.ucla.edu>
11354
11355 * systime.h (Time): Define only if emacs is defined.
11356 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
11357 where the include path doesn't have X11/X.h by default. See
11358 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
11359
cd394be1 113602011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
11361
11362 * composite.c (find_automatic_composition): Fix previous change.
11363
b9704ad9
GM
113642011-05-20 Glenn Morris <rgm@gnu.org>
11365
11366 * lisp.mk: New file, split from Makefile.in.
11367 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
11368 (shortlisp): Remove.
11369 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
11370
4a720484
GM
113712011-05-19 Glenn Morris <rgm@gnu.org>
11372
11373 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
11374 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
11375 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
11376 (lisp): Set the order to that of loadup.el.
11377 (shortlisp): Make it a copy of $lisp.
11378 (SOME_MACHINE_LISP): Remove.
11379 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
11380 Use just $shortlisp, not $SOME_MACHINE_LISP too.
11381
a28d4396
KH
113822011-05-18 Kenichi Handa <handa@m17n.org>
11383
11384 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
11385 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
11386 (find_automatic_composition): Mostly rewrite for efficiency.
11387
a2b1fa8e
JB
113882011-05-18 Juanma Barranquero <lekktu@gmail.com>
11389
11390 * makefile.w32-in: Update dependencies.
11391
8e1f5610
CS
113922011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
11393
11394 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 11395 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 11396
7025ee00 113972011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 11398
cdfa6eab
PE
11399 Fix some integer overflow issues, such as string length overflow.
11400
06d6db33
PE
11401 * insdel.c (count_size_as_multibyte): Check for string overflow.
11402
2b4560a8
PE
11403 * character.c (lisp_string_width): Check for string overflow.
11404 Use EMACS_INT, not int, for string indexes and lengths; in
11405 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
11406 the resulting string length overflows an EMACS_INT; instead,
11407 report a string overflow if no precision given. When checking for
11408 precision exhaustion, use a check that cannot possibly have
11409 integer overflow. (Bug#8675)
11410 * character.h (lisp_string_width): Adjust to new signature.
11411
cb93f9be
PE
11412 * alloc.c (string_overflow): New function.
11413 (Fmake_string): Use it. This doesn't change behavior, but saves
11414 a few bytes and will simplify future changes.
11415 * character.c (string_escape_byte8): Likewise.
11416 * lisp.h (string_overflow): New decl.
11417
1a1f3366
PE
11418 Fixups, following up to the user-interface timestamp change.
11419 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
11420 for UI timestamps, instead of unsigned long.
9fbd6841
PE
11421 * msdos.c (mouse_get_pos): Likewise.
11422 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
11423 * w32gui.h (Time): Define by including "systime.h" rather than by
11424 declaring it ourselves. (Bug#8664)
11425
d4e3e4d3
PE
11426 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
11427 * image.c (clear_image_cache): Likewise.
11428
f6a24d19
PE
11429 * term.c (term_mouse_position): Don't assume time_t wraparound.
11430
08dc5ae6
PE
11431 Be more systematic about user-interface timestamps.
11432 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
11433 and sometimes 'EMACS_UINT', to represent these timestamps.
11434 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
11435 This makes the code easier to follow, and makes it easier to catch
11436 integer overflow bugs such as Bug#8664.
11437 * frame.c (Fmouse_position, Fmouse_pixel_position):
11438 Use Time, not unsigned long, for user-interface timestamps.
11439 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
11440 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
11441 * keyboard.h (last_event_timestamp): Likewise.
11442 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
11443 * menu.h (xmenu_show): Likewise.
11444 * term.c (term_mouse_position): Likewise.
11445 * termhooks.h (struct input_event.timestamp): Likewise.
11446 (struct terminal.mouse_position_hook): Likewise.
11447 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
11448 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
11449 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
11450 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
11451 what it was before.
11452 * menu.h, termhooks.h: Include "systime.h", for Time.
11453
8e55734a
PE
11454 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
11455 Don't assume that the difference between two unsigned long values
11456 can fit into an integer. At this point, we know button_down_time
11457 <= event->timestamp, so the difference must be nonnegative, so
11458 there's no need to cast the result if double-click-time is
11459 nonnegative, as it should be; check that it's nonnegative, just in
11460 case. This bug is triggered when events are more than 2**31 ms
86db42d2 11461 apart (about 25 days). (Bug#8664)
8e55734a 11462
841f1b75 11463 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 11464 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 11465
3e26f69c
PE
11466 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
11467 that always fit in int. Use a sentinel instead of a counter, to
11468 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
11469 * frame.h (struct frame): Use int for menu_bar_items_used
11470 instead of EMACS_INT, since it always fits in int.
3e26f69c 11471
5cc152c0
PE
11472 * menu.c (grow_menu_items): Check for int overflow.
11473
d89eb65e
PE
11474 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
11475
5235bd3e
PE
11476 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
11477 Before, the code was not consistent. These values cannot exceed
11478 2**31 - 1 so there's no need to make them unsigned.
11479 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
11480 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
11481 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
11482 as modifiers.
11483 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
11484
bc827e23
PE
11485 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
11486 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
11487 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
11488 presumably because the widths might not match.
11489
78eb494e
PE
11490 * window.c (size_window): Avoid needless test at loop start.
11491
04f2d78b
CB
114922011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
11493
11494 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
11495
d2fc7e3d 114962011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
11497
11498 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
11499
d2fc7e3d 115002011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
11501
11502 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
11503 `width' to `bar_area_x' and `bar_area_width', respectively.
11504 (x_scroll_run): Take account of fringe background extension.
11505
04f2d78b
CB
11506 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
11507 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
11508 `bar_area_width', respectively.
11509 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
11510 background extension.
11511
79b70037
GM
115122011-05-10 Jim Meyering <meyering@redhat.com>
11513
11514 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
11515
2f142cc5
JB
115162011-05-10 Juanma Barranquero <lekktu@gmail.com>
11517
11518 * image.c (Finit_image_library): Return t for built-in image types,
11519 like pbm and xbm. (Bug#8640)
11520
57679c86
AS
115212011-05-09 Andreas Schwab <schwab@linux-m68k.org>
11522
11523 * w32menu.c (set_frame_menubar): Fix submenu allocation.
11524
888c9e86
EZ
115252011-05-07 Eli Zaretskii <eliz@gnu.org>
11526
b0512a1d
EZ
11527 * w32console.c (Fset_screen_color): Doc fix.
11528 (Fget_screen_color): New function.
11529 (syms_of_ntterm): Defsubr it.
11530
7285dc67
EZ
11531 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
11532 unlink the temporary file if Fcall_process didn't create it in the
11533 first place.
11534 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
11535 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
11536 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
11537 cue to call_process_cleanup not to close that handle.
11538
4d3fcc8e
BK
115392011-05-07 Ben Key <bkey76@gmail.com>
11540
11541 * makefile.w32-in: The bootstrap-temacs rule now makes use of
11542 one of two shell specific rules, either bootstrap-temacs-CMD or
11543 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
11544 to the previous implementation of the bootstrap-temacs rule.
11545 The bootstrap-temacs-CMD rule is similar to the previous
11546 implementation of the bootstrap-temacs rule except that it
11547 makes use of the ESC_CFLAGS variable instead of the CFLAGS
11548 variable.
11549
11550 These changes, along with some changes to nt/configure.bat,
11551 nt/gmake.defs, and nt/nmake.defs, are required to extend my
11552 earlier fix to add support for --cflags and --ldflags options
11553 that include quotes so that it works whether make uses cmd or
11554 sh as the shell.
11555
b4289b64
MA
115562011-05-06 Michael Albinus <michael.albinus@gmx.de>
11557
11558 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
11559 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
11560 is a constant.
11561 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
11562 a string. Handle both cases.
11563 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
11564 (Fdbus_register_method): Use Qinvalid_function.
11565
af4c0e28
JB
115662011-05-06 Juanma Barranquero <lekktu@gmail.com>
11567
11568 * makefile.w32-in: Update dependencies.
11569 (LISP_H): Add inttypes.h and stdin.h.
11570 (PROCESS_H): Add unistd.h.
11571
c51453d9
EZ
115722011-05-06 Eli Zaretskii <eliz@gnu.org>
11573
11574 * lread.c: Include limits.h (fixes the MS-Windows build broken by
11575 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
11576
8ff0ac3c 115772011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 11578
4c4b566b
PE
11579 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
11580
aab2b9b5
PE
11581 * term.c (vfatal): Remove stray call to va_end.
11582 It's not needed and the C Standard doesn't allow it here anyway.
11583
c378da0b
PE
11584 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
11585 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
11586
288b08c7
PE
11587 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
11588 bytes.
11589
e3601888
PE
11590 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
11591
db6c0e74
PE
11592 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
11593
dd5963ea
PE
11594 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
11595
88c9450f
PE
11596 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
11597
2f9442b8
PE
11598 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
11599
c032b5f8
PE
11600 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
11601 * charset.c (Fdefine_charset_internal): Don't initialize
11602 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 11603 32-bit int (Bug#8600).
a108c10b
PE
11604
11605 * lread.c (read_integer): Be more consistent with string-to-number.
11606 Use string_to_number to do the actual conversion; this avoids
11607 rounding errors and fixes some other screwups. Without this fix,
11608 for example, #x1fffffffffffffff was misread as -2305843009213693952.
11609 (digit_to_number): Move earlier, for benefit of read_integer.
11610 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 11611 not a digit in any supported base. (Bug#8602)
a108c10b 11612
ad5f9eea
PE
11613 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
11614
aec1708a
PE
11615 * dispnew.c (scrolling_window): Return 1 if we scrolled,
11616 to match comment at start of function. This also removes a
11617 GCC warning about overflow in a 32+64-bit port.
11618
47be4ab5
PE
11619 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
11620
371cac43
PE
11621 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
11622 Reported by Stefan Monnier in
11623 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
11624 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11625 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 11626
d01a7826
PE
11627 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
11628 (EMACS_UINTPTR): Likewise, with uintptr_t.
11629
7fd47d5c
PE
11630 * lisp.h: Prefer 64-bit EMACS_INT if available.
11631 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
11632 on 32-bit hosts that have 64-bit int, so that they can access
11633 large files.
122b0c86
PE
11634 However, temporarily disable this change unless the temporary
11635 symbol WIDE_EMACS_INT is defined.
7fd47d5c 11636
8727937b
PE
11637 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
11638
8ac068ac
PE
11639 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
11640 This removes an assumption that EMACS_INT and long are the same
11641 width as pointers. The assumption is true for Emacs porting targets
11642 now, but we want to make other targets possible.
11643 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
11644 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
11645 In the rest of the code, change types of integers that hold casted
11646 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
11647 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
11648 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
11649 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
11650 No need to cast type when ORing.
11651 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
11652 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
11653 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
11654 assume EMACS_INT is the same width as char *.
11655 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
11656 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
11657 Remove no-longer-needed casts.
11658 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
11659 (xg_tool_bar_help_callback, xg_make_tool_item):
11660 Use EMACS_INTPTR to hold an integer
11661 that will be cast to void *; this can avoid a GCC warning
11662 if EMACS_INT is not the same width as void *.
11663 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
11664 * xdisp.c (display_echo_area_1, resize_mini_window_1):
11665 (current_message_1, set_message_1):
11666 Use a local to convert to proper width without a cast.
11667 * xmenu.c (dialog_selection_callback): Likewise.
11668
ede49d71
PE
11669 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
11670 Also, don't assume VALBITS / RAND_BITS is less than 5,
11671 and don't rely on undefined behavior when shifting a 1 left into
11672 the sign bit.
11673 * lisp.h (get_random): Change signature to match.
11674
2f30ecd0
PE
11675 * lread.c (hash_string): Use size_t, not int, for hash computation.
11676 Normally we prefer signed values; but hashing is special, because
11677 it's better to use unsigned division on hash table sizes so that
11678 the remainder is nonnegative. Also, size_t is the natural width
11679 for hashing into memory. The previous code used 'int', which doesn't
11680 retain enough info to hash well into very large tables.
11681 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
11682
2a866e7b
PE
11683 * dbusbind.c: Don't possibly lose pointer info when converting.
11684 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11685 Use XPNTR rather than XHASH, so that the high-order bits of
11686 the pointer aren't lost when converting through void *.
11687
51639eac
PE
11688 * eval.c (Fautoload): Don't double-shift a pointer.
11689
92394119
PE
11690 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
11691
dbdb9a7c
JB
116922011-05-06 Juanma Barranquero <lekktu@gmail.com>
11693
11694 * gnutls.c (DEF_GNUTLS_FN):
11695 * image.c (DEF_IMGLIB_FN): Make function pointers static.
11696
db7a0b4f
AS
116972011-05-05 Andreas Schwab <schwab@linux-m68k.org>
11698
11699 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
11700 marker. (Bug#8610)
11701
cd394be1 117022011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
11703
11704 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
11705 New version that can reserve upto 2GB of heap space.
11706
f7ff1b0f 117072011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
11708
11709 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
11710
639c109b
TZ
117112011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
11712
11713 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
11714 `gnutls_certificate_set_x509_key_file'.
11715
d2127135
JB
117162011-05-05 Juanma Barranquero <lekktu@gmail.com>
11717
11718 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
11719 Update dependencies.
11720
e968f4f3
JB
117212011-05-04 Juanma Barranquero <lekktu@gmail.com>
11722
11723 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
11724 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
11725 Remove unused parameter `fildes'.
11726 * process.c (read_process_output, send_process): Don't pass it.
11727
84d358f0
JB
117282011-05-04 Juanma Barranquero <lekktu@gmail.com>
11729
11730 Fix previous change: the library cache is defined in w32.c.
11731 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
11732 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
11733
0898ca10
JB
117342011-05-04 Juanma Barranquero <lekktu@gmail.com>
11735
11736 Implement dynamic loading of GnuTLS on Windows.
11737
11738 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
11739 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
11740 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11741 Declare.
11742
11743 * gnutls.c (Qgnutls_dll): Define.
11744 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
11745 (gnutls_*): Declare function pointers.
11746 (init_gnutls_functions): New function to initialize function pointers.
11747 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
11748 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
11749 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11750 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
11751 (emacs_gnutls_write, emacs_gnutls_read)
11752 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
11753 (Fgnutls_available_p): New function.
11754 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
11755 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
11756 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
11757
11758 * image.c: Include w32.h.
11759 (Vimage_type_cache): Delete.
11760 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
11761 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
11762 (w32_delayed_load): Move to w32.c.
11763
11764 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
11765
11766 * w32.c (QCloaded_from, Vlibrary_cache): Define.
11767 (w32_delayed_load): Move from image.c. When loading a library, record
11768 its filename in the :loaded-from property of the library id.
11769 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
11770 Initialize and staticpro them.
11771 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
11772
11773 * process.c: Include lisp.h before w32.h, not after.
11774 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
11775 instead of gnutls_record_check_pending.
11776
11777 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
11778
ff4de4aa
TZ
117792011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
11780
11781 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
11782 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
11783 as passed in.
11784
abe95abb
JD
117852011-05-03 Jan Djärv <jan.h.d@swipnet.se>
11786
11787 * xterm.c (x_set_frame_alpha): Do not set property on anything
11788 else than FRAME_X_OUTER_WINDOW (Bug#8608).
11789
e16e55d4
JB
117902011-05-02 Juanma Barranquero <lekktu@gmail.com>
11791
11792 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
11793
bafcf6a5
JB
117942011-05-02 Juanma Barranquero <lekktu@gmail.com>
11795
11796 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
11797 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
11798 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
11799 (gnutls_global_initialized, Qgnutls_bootprop_priority)
11800 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
11801 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
11802 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
11803 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
11804 (Qgnutls_bootprop_callbacks_verify): Make static.
11805
e7a6747f
AS
118062011-05-01 Andreas Schwab <schwab@linux-m68k.org>
11807
19ed11ba
AS
11808 * callproc.c: Indentation fixup.
11809
e7a6747f 11810 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
11811 (wait_for_termination, interruptible_wait_for_termination):
11812 Move after wait_for_termination_1.
e7a6747f 11813
1ef14cb4
LMI
118142011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
11815
11816 * sysdep.c (interruptible_wait_for_termination): New function
11817 which is like wait_for_termination, but allows keyboard
11818 interruptions.
11819
11820 * callproc.c (Fcall_process): Add (:file "file") as an option for
11821 the STDOUT buffer.
11822 (Fcall_process_region): Ditto.
11823
330d880c
EZ
118242011-04-30 Eli Zaretskii <eliz@gnu.org>
11825
8db90b73
EZ
11826 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
11827 rather than `XVECTOR (FOO)->size'.
11828
330d880c
EZ
11829 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
11830 inttypes.h, as a gnulib replacement is used if it not available in
11831 system headers.
11832
15cbd324
EZ
118332011-04-21 Eli Zaretskii <eliz@gnu.org>
11834
11835 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
11836 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
11837 of MOST_POSITIVE_FIXNUM. (Bug#8528)
11838
11839 * coding.c (coding_alloc_by_realloc): Error out if destination
11840 will grow beyond MOST_POSITIVE_FIXNUM.
11841 (decode_coding_emacs_mule): Abort if there isn't enough place in
11842 charbuf for the composition carryover bytes. Reserve an extra
11843 space for up to 2 characters produced in a loop.
11844 (decode_coding_iso_2022): Abort if there isn't enough place in
11845 charbuf for the composition carryover bytes.
11846
118472011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 11848
ae940cca
EZ
11849 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
11850 aborting when %lld or %lll format is passed.
11851 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
11852 %llo or %llx format is passed. (Bug#8545)
11853
03ab8921
EZ
11854 * window.c (window_scroll_line_based): Use a marker instead of
11855 simple variables to record original value of point. (Bug#7952)
11856
afda1437
EZ
11857 * doprnt.c (doprnt): Fix the case where a multibyte sequence
11858 produced by %s or %c overflows available buffer space. (Bug#8545)
11859
f76dee0c
PE
118602011-04-28 Paul Eggert <eggert@cs.ucla.edu>
11861
11862 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 11863 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 11864
fdc5744d
JB
118652011-04-28 Juanma Barranquero <lekktu@gmail.com>
11866
11867 * w32.c (init_environment): Warn about defaulting HOME to C:\.
11868
638f053a
JB
118692011-04-28 Juanma Barranquero <lekktu@gmail.com>
11870
11871 * keyboard.c (Qdelayed_warnings_hook): Define.
11872 (command_loop_1): Run `delayed-warnings-hook'
11873 if Vdelayed_warnings_list is non-nil.
11874 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
11875 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
11876
d178f871
EZ
118772011-04-28 Eli Zaretskii <eliz@gnu.org>
11878
11879 * doprnt.c (doprnt): Don't return value smaller than the buffer
11880 size if the message was truncated. (Bug#8545).
11881
b124fd93
JB
118822011-04-28 Juanma Barranquero <lekktu@gmail.com>
11883
11884 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
11885 (Fx_window_property): #if-0 the whole functions, not just the bodies.
11886
e810457d
PE
118872011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11888
11889 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
11890
ea51cceb
JB
118912011-04-27 Juanma Barranquero <lekktu@gmail.com>
11892
11893 * makefile.w32-in: Update dependencies.
11894
94dcfacf
EZ
118952011-04-27 Eli Zaretskii <eliz@gnu.org>
11896
11897 Improve `doprnt' and its usage. (Bug#8545)
11898 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
11899 `format_end'. Remove support for %l as a conversion specifier.
11900 Don't use xrealloc. Improve diagnostics when the %l size modifier
11901 is used. Update the commentary.
11902
11903 * eval.c (verror): Simplify calculation of size_t.
11904
11905 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
11906 messages.
11907
f61f41d7
PE
119082011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
11909
11910 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
11911 change.
11912
96fb4434
PE
119132011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11914
11915 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
11916 This makes this file independent of the recent pseudovector change.
11917
671875da 119182011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 11919
69e9b5a3
PE
11920 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
11921
b5f869a7 11922 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 11923 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 11924 Remove unused local.
c8926152 11925 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 11926
841a1577 11927 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
11928 GCC 4.6.0 optimizes based on type-based alias analysis.
11929 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
11930 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
11931 != &v->size, and therefore "v->size = 1; b->size = 2; return
11932 v->size;" must therefore return 1. This assumption is incorrect
11933 for Emacs, since it type-puns struct Lisp_Vector * with many other
11934 types. To fix this problem, this patch adds a new type struct
f904488f 11935 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
11936 and pseudovectors, and helps optimizing compilers not get fooled
11937 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
11938 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
11939 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
11940 the size member.
eab3844f
PE
11941 (XSETPVECTYPE): Rewrite in terms of new macro.
11942 (XSETPVECTYPESIZE): New macro, specifying both type and size.
11943 This is a bit clearer, and further avoids the possibility of
11944 undesirable aliasing.
11945 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 11946 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
11947 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
11948 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
11949 (ASIZE): Now uses header.size rather than size.
11950 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
11951 to avoid the hassle of writing XVECTOR (foo)->header.size.
11952 (struct vectorlike_header): New type.
eab3844f
PE
11953 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
11954 object, to help avoid aliasing.
11955 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
11956 (SUBRP): Likewise, since Lisp_Subr is a special case.
11957 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
11958 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
11959 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 11960 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
11961 changed to be "header.size" and "header.next".
11962 * buffer.h (struct buffer): Likewise.
11963 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
11964 * frame.h (struct frame): Likewise.
11965 * process.h (struct Lisp_Process): Likewise.
11966 * termhooks.h (struct terminal): Likewise.
11967 * window.c (struct save_window_data, struct saved_window): Likewise.
11968 * window.h (struct window): Likewise.
11969 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
11970 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
11971 * buffer.c (init_buffer_once): Likewise.
11972 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
11973 special case.
11974 * process.c (Fformat_network_address): Use local var for size,
11975 for brevity.
11976
0df1eac5
PE
11977 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
11978
847ab9d1 11979 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
11980 * data.c (atof): Remove decl; no longer used or needed.
11981 (digit_to_number): Move to lread.c.
11982 (Fstring_to_number): Use new string_to_number function, to be
11983 consistent with how the Lisp reader treats infinities and NaNs.
11984 Do not assume that floating-point numbers represent EMACS_INT
11985 without losing information; this is not true on most 64-bit hosts.
11986 Avoid double-rounding errors, by insisting on integers when
11987 parsing non-base-10 numbers, as the documentation specifies.
11988 * lisp.h (string_to_number): New decl, replacing ...
11989 (isfloat_string): Remove.
bc0a5c13 11990 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 11991 (read1): Do not accept +. and -. as integers; this
452f4150
PE
11992 appears to have been a coding error. Similarly, do not accept
11993 strings like +-1e0 as floating point numbers. Do not report
11994 overflow for integer overflows unless the base is not 10 which
11995 means we have no simple and reliable way to continue.
11996 Break out the floating-point parsing into a new
11997 function string_to_number, so that Fstring_to_number parses
11998 floating point numbers consistently with the Lisp reader.
04f2d78b 11999 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
12000 (E_CHAR, EXP_INT): Remove, replacing with ...
12001 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
12002 (string_to_number): New function, replacing isfloat_string.
12003 This function checks for valid syntax and produces the resulting
12004 Lisp float number too. Rework it so that string-to-number
bc0a5c13 12005 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
12006 so that overflow for non-base-10 numbers is reported only when
12007 there's no portable and simple way to convert to floating point.
452f4150 12008
67769ffc
PE
12009 * textprop.c (set_text_properties_1): Rewrite for clarity,
12010 and to avoid GCC warning about integer overflow.
12011
c20db43f
PE
12012 * intervals.h (struct interval): Use EMACS_INT for members
12013 where EMACS_UINT might cause problems. See
12014 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
12015 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
12016 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
12017 All uses changed.
37aa2f85
PE
12018 (offset_intervals): Tell GCC not to worry about length overflow
12019 when negating a negative length.
c20db43f 12020
2538aa2f
PE
12021 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
12022 (overrun_check_free): Likewise.
12023
f2d3008d
PE
12024 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
12025 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
12026 word size.
12027
ec8df744
PE
12028 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12029 (gnutls_make_error): Rename local to avoid shadowing.
12030 (gnutls_emacs_global_deinit): ifdef out; not used.
12031 (Fgnutls_boot): Use const for pointer to readonly storage.
12032 Comment out unused local. Fix pointer signedness problems.
12033
640ee02d
PE
12034 * lread.c (openp): Don't stuff size_t into an 'int'.
12035 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
12036 about possible signed overflow.
12037
6048fb2a
PE
12038 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12039 (GDK_KEY_g): Don't define if already defined.
12040 (xg_prepare_tooltip): Avoid pointer signedness problem.
12041 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
12042
fa3c87e1
PE
12043 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
12044 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
12045
2172544b
PE
12046 * xfns.c (Fx_window_property): Simplify a bit,
12047 to make a bit faster and to avoid GCC 4.6.0 warning.
12048 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
12049
9b821a21
PE
12050 * fns.c (internal_equal): Don't assume size_t fits in int.
12051
3c616cfa
PE
12052 * alloc.c (compact_small_strings): Tighten assertion a little.
12053
c2982e87
PE
12054 Replace pEd with more-general pI, and fix some printf arg casts.
12055 * lisp.h (pI): New macro, generalizing old pEd macro to other
12056 conversion specifiers. For example, use "...%"pI"d..." rather
12057 than "...%"pEd"...".
12058 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 12059 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
12060 * alloc.c (check_pure_size): Don't overflow by converting size to int.
12061 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
12062 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
12063 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
12064 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
12065 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
12066 64-bit hosts.
12067 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
12068 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
12069 * print.c (safe_debug_print, print_object): Likewise.
12070 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
12071 to int.
6f04d126
PE
12072 Use pI instead of if-then-else-abort. Use %p to avoid casts,
12073 avoiding the 0 flag, which is not portable.
c2982e87
PE
12074 * process.c (Fmake_network_process): Use pI to avoid cast.
12075 * region-cache.c (pp_cache): Likewise.
12076 * xdisp.c (decode_mode_spec): Likewise.
12077 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
12078 behavior on 64-bit hosts with printf arg.
6f04d126 12079 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
12080 (x_stop_queuing_selection_requests): Likewise.
12081 (x_get_window_property): Don't truncate byte count to an 'int'
12082 when tracing.
0b432f21 12083
5e073ec7
PE
12084 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
12085 here, since it parses constructs like leading '-' and spaces,
12086 which are not wanted; and it overflows with large numbers.
12087 Instead, simply match F[0-9]+, which is what is wanted anyway.
12088
36372bf9
PE
12089 * alloc.c: Remove unportable assumptions about struct layout.
12090 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
12091 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
12092 (allocate_vectorlike, make_pure_vector): Use the new macros,
12093 plus offsetof, to remove unportable assumptions about struct layout.
12094 These assumptions hold on all porting targets that I know of, but
12095 they are not guaranteed, they're easy to remove, and removing them
12096 makes further changes easier.
12097
0b432f21
PE
12098 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
12099 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
12100 (string_overrun_cookie): Now const. Use initializers that
12101 don't formally overflow signed char, to avoid warnings.
000098c1
PE
12102 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
12103 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
12104 (allocate_buffer): Don't assume sizeof (struct buffer) is a
12105 multiple of sizeof (EMACS_INT); it need not be, if
12106 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 12107 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 12108
895009e1
JB
121092011-04-26 Juanma Barranquero <lekktu@gmail.com>
12110
12111 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
12112
6a7a1b0b
TZ
121132011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
12114
12115 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 12116 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
12117 Reported by Paul Eggert <eggert@cs.ucla.edu>.
12118
841a1577 121192011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
12120
12121 * lisp.h (Qdebug): List symbol.
895009e1 12122 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
12123 * keyboard.c (debug-on-event): New variable.
12124 (handle_user_signal): Break into debugger when debug-on-event
12125 matches the current signal symbol.
12126
f2d3ba6f
DN
121272011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
12128
12129 * alloc.c (check_sblock, check_string_bytes)
12130 (check_string_free_list): Convert to standard C.
12131
42ce4c63
TZ
121322011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
12133
12134 * w32.c (emacs_gnutls_push): Fix typo.
12135
825cd63c
EZ
121362011-04-25 Eli Zaretskii <eliz@gnu.org>
12137
fb11d64d
EZ
12138 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
12139 "cast to pointer from integer of different size".
12140
825cd63c
EZ
12141 Improve doprnt and its use in verror. (Bug#8545)
12142 * doprnt.c (doprnt): Document the set of format control sequences
12143 supported by the function. Use SAFE_ALLOCA instead of always
12144 using `alloca'.
12145
12146 * eval.c (verror): Don't limit the buffer size at size_max-1, that
12147 is one byte too soon. Don't use xrealloc; instead xfree and
12148 xmalloc anew.
12149
e061a11b
TZ
121502011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
12151
12152 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
12153 callbacks stage.
12154
12155 * gnutls.c: Renamed global_initialized to
12156 gnutls_global_initialized. Added internals for the
12157 :verify-hostname-error, :verify-error, and :verify-flags
12158 parameters of `gnutls-boot' and documented those parameters in the
12159 docstring. Start callback support.
9173deec
JB
12160 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
12161 unless a fatal error occurred. Call gnutls_alert_send_appropriate
12162 on error. Return error code.
e061a11b
TZ
12163 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
12164 (emacs_gnutls_read): Likewise.
12165 (Fgnutls_boot): Return handshake error code.
12166 (emacs_gnutls_handle_error): New function.
12167 (wsaerror_to_errno): Likewise.
12168
12169 * w32.h (emacs_gnutls_pull): Add prototype.
12170 (emacs_gnutls_push): Likewise.
12171
12172 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
12173 (emacs_gnutls_push): Likewise.
12174
121752011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
12176
12177 * process.c (wait_reading_process_output): Check if GnuTLS
12178 buffered some data internally if no FDs are set for TLS
12179 connections.
12180
12181 * makefile.w32-in (OBJ2): Add gnutls.$(O).
12182 (LIBS): Link to USER_LIBS.
12183 ($(BLD)/gnutls.$(0)): New target.
12184
fa6996bc
EZ
121852011-04-24 Eli Zaretskii <eliz@gnu.org>
12186
eb35682e
EZ
12187 * xdisp.c (handle_single_display_spec): Rename the
12188 display_replaced_before_p argument into display_replaced_p, to
12189 make it consistent with the commentary. Fix typos in the
12190 commentary.
12191
e2ad650c
EZ
12192 * textprop.c (syms_of_textprop): Remove dead code.
12193 (copy_text_properties): Delete obsolete commentary about an
12194 interface that was deleted long ago. Fix typos in the description
12195 of arguments.
12196
1b2de274
EZ
12197 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
12198 to changes in oldXMenu/XMenu.h from 2011-04-16.
12199 <menu_help_message, prev_menu_help_message>: Constify.
12200 (IT_menu_make_room): menu->help_text is now `const char **';
12201 adjust.
12202
12203 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
12204 to changes in oldXMenu/XMenu.h from 2011-04-16.
12205 (struct XMenu): Declare `help_text' `const char **'.
12206
12207 * xfaces.c <Qunspecified>: Make extern again.
12208
12209 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 12210 required by POSIX.
1b2de274 12211
762b15be
EZ
12212 * doc.c (get_doc_string): Improve the format passed to `error'.
12213
12214 * doprnt.c (doprnt): Improve commentary.
12215
12216 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
12217
12218 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
12219 them with etags.
12220
f1052e5d
EZ
12221 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
12222 changes in globals.h immediately force recompilation.
762b15be
EZ
12223 (TAGS): Depend on $(CURDIR)/m/intel386.h and
12224 $(CURDIR)/s/ms-w32.h.
12225 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 12226
fa6996bc
EZ
12227 * character.c (Fchar_direction): Function deleted.
12228 (syms_of_character): Don't defsubr it.
12229 <char-direction-table>: Deleted.
12230
e6c3da20
EZ
122312011-04-23 Eli Zaretskii <eliz@gnu.org>
12232
12233 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
12234 * doprnt.c: Include limits.h.
12235 (SIZE_MAX): New macro.
04f2d78b
CB
12236 (doprnt): Return a size_t value. 2nd arg is now size_t.
12237 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
12238 Improve overflow protection. Support `l' modifier for integer
12239 conversions. Support %l conversion. Don't assume an EMACS_INT
12240 argument for integer conversions and for %c.
12241
12242 * lisp.h (doprnt): Restore prototype.
12243
12244 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
12245 $(SRC)/character.h.
12246
12247 * Makefile.in (base_obj): Add back doprnt.o.
12248
12249 * deps.mk (doprnt.o): Add back prerequisites.
12250 (callint.o): Depend on character.h.
12251
12252 * eval.c (internal_lisp_condition_case): Include the handler
12253 representation in the error message.
12254 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
12255 when breaking from the loop.
12256
12257 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
12258
12259 * callint.c (Fcall_interactively): When displaying error message
12260 about invalid control letter, pass the character's codepoint, not
12261 a pointer to its multibyte form. Improve display of the character
12262 in octal and display also its hex code.
12263
12264 * character.c (char_string): Use %x to display the (unsigned)
12265 codepoint of an invalid character, to avoid displaying a bogus
12266 negative value.
12267
12268 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
12269 `error', not SYMBOL_NAME itself.
12270
12271 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
12272 character arguments to `error'.
12273
12274 * charset.c (check_iso_charset_parameter): Fix incorrect argument
12275 to `error' in error message about FINAL_CHAR argument. Make sure
12276 FINAL_CHAR is a character, and use %c when it is passed as
12277 argument to `error'.
12278
4ffd0d6b 122792011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
12280
12281 * s/ms-w32.h (localtime): Redirect to sys_localtime.
12282
12283 * w32.c: Include <time.h>.
12284 (sys_localtime): New function.
12285
4ffd0d6b 122862011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
12287
12288 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
12289
4ffd0d6b 12290 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 12291
4ffd0d6b 122922011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 12293
4ffd0d6b
GM
12294 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
12295 zombies (Bug#8467).
aac0c6e3 12296
04c56954
EZ
122972011-04-19 Eli Zaretskii <eliz@gnu.org>
12298
12299 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
12300 gl_state.e_property when gl_state.object is Qt.
12301
12302 * insdel.c (make_gap_larger): Remove limitation of buffer size
12303 to <= INT_MAX.
12304
16a43933
CY
123052011-04-18 Chong Yidong <cyd@stupidchicken.com>
12306
12307 * xdisp.c (lookup_glyphless_char_display)
12308 (produce_glyphless_glyph): Handle cons cell entry in
12309 glyphless-char-display.
12310 (Vglyphless_char_display): Document it.
12311
12312 * term.c (produce_glyphless_glyph): Handle cons cell entry in
12313 glyphless-char-display.
12314
4581706e
CY
123152011-04-17 Chong Yidong <cyd@stupidchicken.com>
12316
12317 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
12318
12319 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
12320
12321 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
12322 definition for no-X builds.
12323
4887c6e2 123242011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 12325
fd35b6f9
PE
12326 Static checks with GCC 4.6.0 and non-default toolkits.
12327
5c1ccb01
PE
12328 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
12329
006c5daa
PE
12330 * process.c (keyboard_bit_set): Define only if SIGIO.
12331 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
12332 (send_process): Repair possible setjmp clobbering.
12333
efc736d3
PE
12334 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
12335
4e2fe2e6
PE
12336 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
12337
f97334a2
PE
12338 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
12339
4e75f29d
PE
12340 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
12341 Define only if needed.
12342
90efadd1
PE
12343 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
12344 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 12345 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 12346
3c647824
PE
12347 * dispextern.h (struct redisplay_interface): Rename param
12348 to avoid shadowing.
e264f262 12349 * termhooks.h (struct terminal): Likewise.
761383f4 12350 * xterm.c (xembed_send_message): Likewise.
3c647824 12351
b58c5c4a
PE
12352 * insdel.c (make_gap_smaller): Define only if
12353 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
12354
cad59032
PE
12355 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
12356 it.
12357
c339dc2e
PE
12358 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
12359 so that we aren't warned about unused symbols.
12360
91a3e27b
PE
12361 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
12362
399c71d3 12363 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 12364
8ffc96f5
PE
12365 * xfns.c (x_real_positions): Mark locals as initialized.
12366
eef9bc79
PE
12367 * xmenu.c (xmenu_show): Don't use uninitialized vars.
12368
098db9dd
PE
12369 * xterm.c: Fix problems found by static analysis with other toolkits.
12370 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
12371 (x_dispatch_event): Declare static if USE_GTK, and
12372 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 12373 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 12374 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
12375 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
12376 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 12377
eb18f6cc
PE
12378 * xmenu.c (menu_help_callback): Pointer type fixes.
12379 Use const pointers when pointing at readonly data. Avoid pointer
12380 signedness clashes.
12381 (FALSE): Remove unused macro.
12382 (update_frame_menubar): Remove unused decl.
12383
1fe72bf8
PE
12384 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
12385
60d9e1db
PE
12386 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
12387 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
12388 (single_menu_item): Rename local to avoid shadowing.
12389
39261c26
PE
12390 * keyboard.c (make_lispy_event): Remove unused local var.
12391
018c5e19
PE
12392 * frame.c, frame.h (x_get_resource_string): Bring this back, but
12393 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
12394
63d2b86e
PE
12395 * bitmaps: Change bitmaps from unsigned char back to the X11
12396 compatible char. Avoid the old compiler warnings about
12397 out-of-range initializers by using, for example, '\xab' rather
12398 than 0xab.
12399
aefd87e1
PE
12400 * xgselect.c (xgselect_initialize): Check vs interface
12401 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
12402
bf501fb9
PE
12403 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
12404
e9829fdf
PE
12405 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
12406 to read-only memory.
12407
1086c095
PE
12408 * fns.c (vector): Remove; this old hack is no longer needed.
12409
2baccd04 12410 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 12411 Remove unused var.
dde42981 12412 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 12413
72391843 12414 * xrdb.c (x_load_resources): Omit unused local.
3565b346 12415
436c16df 12416 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 12417 (x_window): Rename locals to avoid shadowing.
dc5ddd85 12418 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 12419
92bb796d 12420 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 12421 (x_term_init): Remove local to avoid shadowing.
92bb796d 12422
764430a3 12423 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
12424
12425 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
12426 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
12427
d1dfb56c
EZ
124282011-04-16 Eli Zaretskii <eliz@gnu.org>
12429
c4354cb4
EZ
12430 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
12431
d1dfb56c
EZ
12432 Fix regex.c, syntax.c and friends for buffers > 2GB.
12433 * syntax.h (struct gl_state_s): Declare character position members
12434 EMACS_INT.
12435
12436 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
12437
04f2d78b
CB
12438 * textprop.c (verify_interval_modification, interval_of):
12439 Declare arguments EMACS_INT.
d1dfb56c
EZ
12440
12441 * intervals.c (adjust_intervals_for_insertion): Declare arguments
12442 EMACS_INT.
12443
12444 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
12445
12446 * indent.c (Fvertical_motion): Local variable it_start is now
12447 EMACS_INT.
12448
12449 * regex.c (re_match, re_match_2, re_match_2_internal)
12450 (bcmp_translate, regcomp, regexec, print_double_string)
12451 (group_in_compile_stack, re_search, re_search_2, regex_compile)
12452 (re_compile_pattern, re_exec): Declare arguments and local
12453 variables `size_t' and `ssize_t' and return values `regoff_t', as
12454 appropriate.
12455 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
12456 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
12457 <compile_stack_type>: `size' and `avail' are now `size_t'.
12458
12459 * regex.h <regoff_t>: Use ssize_t, not int.
12460 (re_search, re_search_2, re_match, re_match_2): Arguments that
12461 specify buffer/string position and length are now ssize_t and
12462 size_t. Return type is regoff_t.
12463
613052cd
BK
124642011-04-16 Ben Key <bkey76@gmail.com>
12465
12466 * nsfont.m: Fixed bugs in ns_get_family and
12467 ns_descriptor_to_entity that were caused by using free to
12468 deallocate memory blocks that were allocated by xmalloc (via
12469 xstrdup). This caused Emacs to crash when compiled with
12470 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
12471 --enable-checking=xmallocoverrun). xfree is now used to
12472 deallocate these memory blocks.
12473
4170f62f 124742011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 12475
71b41406
PE
12476 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
12477
9587a89d
PE
12478 emacs_write: Accept and return EMACS_INT for sizes.
12479 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
12480 et seq.
12481 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
12482 Accept and return EMACS_INT.
12483 (emacs_gnutls_write): Return the number of bytes written on
12484 partial writes.
12485 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
12486 (emacs_read, emacs_write): Remove check for negative size, as the
12487 Emacs source code has been audited now.
9587a89d
PE
12488 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
12489 (emacs_read, emacs_write): Use it.
273a5f82
PE
12490 * process.c (send_process): Adjust to the new signatures of
12491 emacs_write and emacs_gnutls_write. Do not attempt to store
12492 a byte offset into an 'int'; it might overflow.
9587a89d 12493 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 12494
3e047f51
PE
12495 * sound.c: Don't assume sizes fit in 'int'.
12496 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 12497 Return EMACS_INT, not int.
3e047f51 12498 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
12499 Accept EMACS_INT, not int.
12500 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
12501 record read return values.
12502
cc39a9db
BK
125032011-04-15 Ben Key <bkey76@gmail.com>
12504
c9d0ec6d
JB
12505 * keyboard.c (Qundefined): Don't declare static since it is used
12506 in nsfns.m.
12507 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
12508 static since they are used in nsfont.m.
cc39a9db 12509
6c60eb9f
SM
125102011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
12511
12512 * process.c (Qprocessp): Don't declare static.
12513 * lisp.h (Qprocessp): Declare again.
12514
7990b61a
JB
125152011-04-15 Juanma Barranquero <lekktu@gmail.com>
12516
12517 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
12518
5d4cb038
PE
125192011-04-14 Paul Eggert <eggert@cs.ucla.edu>
12520
8bd7b830 12521 Improve C-level modularity by making more things 'static'.
cd64ea1d 12522
e3b27b31
PE
12523 Don't publish debugger-only interfaces to other modules.
12524 * lisp.h (safe_debug_print, debug_output_compilation_hack):
12525 (verify_bytepos, count_markers): Move decls to the only modules
12526 that need them.
12527 * region-cache.h (pp_cache): Likewise.
12528 * window.h (check_all_windows): Likewise.
12529 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
12530
5d4cb038
PE
12531 * sysdep.c (croak): Now static, if
12532 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
12533 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
12534
12535 * alloc.c (refill_memory_reserve): Now static if
12536 !defined REL_ALLOC || defined SYSTEM_MALLOC.
12537 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 12538
e87b6180
PE
12539 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
12540 Define only if USE_LUCID.
12541
ac64929e
PE
12542 * xrdb.c (x_customization_string, x_rm_string): Now static.
12543
6f37259d
PE
12544 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
12545 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
12546
1683e3ab
PE
12547 * xdisp.c (draw_row_with_mouse_face): Now static.
12548 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
12549
de9c2632
PE
12550 * window.h (check_all_windows): Mark externally visible.
12551
2b96acb7
PE
12552 * window.c (window_deletion_count): Now static.
12553
12554 * undo.c: Make symbols static if they're not exported.
12555 (last_undo_buffer, last_boundary_position, pending_boundary):
12556 Now static.
12557
50436f33
PE
12558 * textprop.c (interval_insert_behind_hooks): Now static.
12559 (interval_insert_in_front_hooks): Likewise.
12560
64520e5c
PE
12561 * term.c: Make symbols static if they're not exported.
12562 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
12563 (max_frame_lines, tty_set_terminal_modes):
12564 (tty_reset_terminal_modes, tty_turn_off_highlight):
12565 (get_tty_terminal): Now static.
12566 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
12567 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 12568 HAVE_WINDOW_SYSTEM.
64520e5c
PE
12569 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
12570 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
12571
1fa53021
PE
12572 * sysdep.c: Make symbols static if they're not exported.
12573 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
12574 Now static.
12575 (sigprocmask_set, full_mask): Remove; unused.
12576 (wait_debugging): Mark as visible.
12577 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
12578 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
12579
d4b43b22
PE
12580 * syntax.c (syntax_temp): Define only if !__GNUC__.
12581
b7c513d0
PE
12582 * sound.c (current_sound_device, current_sound): Now static.
12583
989b29ad
PE
12584 * search.c (searchbufs, searchbuf_head): Now static.
12585
13a55a78
PE
12586 * scroll.c (scroll_cost): Remove; unused.
12587 * dispextern.h (scroll_cost): Remove decl.
12588
de68a1fc
PE
12589 * region-cache.h (pp_cache): Mark as externally visible.
12590
40ccffa6
PE
12591 * process.c: Make symbols static if they're not exported.
12592 (process_tick, update_tick, create_process, chan_process):
12593 (Vprocess_alist, proc_buffered_char, datagram_access):
12594 (fd_callback_data, send_process_frame, process_sent_to): Now static.
12595 (deactivate_process): Mark defn as static, as well as decl.
12596 * lisp.h (create_process): Remove decl.
12597 * process.h (chan_process, Vprocess_alist): Remove decls.
12598
ad64fc97
PE
12599 * print.c: Make symbols static if they're not exported.
12600 (print_depth, new_backquote_output, being_printed, print_buffer):
12601 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
12602 (print_interval, print_number_index, initial_stderr_stream):
12603 Now static.
12604 * lisp.h (Fprinc): Remove decl.
12605 (debug_output_compilation_hack): Mark as externally visible.
12606
adddb265
PE
12607 * sysdep.c (croak): Move decl from here to syssignal.h.
12608 * syssignal.h (croak): Put it here, so the API can be checked when
12609 'croak' is called from dissociate_if_controlling_tty.
12610
1717ede2
PE
12611 * minibuf.c: Make symbols static if they're not exported.
12612 (minibuf_save_list, choose_minibuf_frame): Now static.
12613 * lisp.h (choose_minibuf_frame): Remove decl.
12614
fa5fb2bc
PE
12615 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
12616
1e3890d1
PE
12617 * lread.c: Make symbols static if they're not exported.
12618 (read_objects, initial_obarray, oblookup_last_bucket_number):
12619 Now static.
12620 (make_symbol): Remove; unused.
12621 * lisp.h (initial_obarray, make_symbol): Remove decls.
12622
8a1414fa
PE
12623 * keyboard.c: Make symbols static if they're not exported.
12624 (single_kboard, recent_keys_index, total_keys, recent_keys):
12625 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
12626 (this_single_command_key_start, echoing, last_auto_save):
12627 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
12628 (command_loop, echo_now, keyboard_init_hook, help_char_p):
12629 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
12630 (Vlispy_mouse_stem, double_click_count):
12631 Now static.
12632 (force_auto_save_soon): Define only if SIGDANGER.
12633 (ignore_mouse_drag_p): Now static if
12634 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
12635 (print_help): Remove; unused.
12636 (stop_character, last_timer_event): Mark as externally visible.
12637 * keyboard.h (ignore_mouse_drag_p): Declare only if
12638 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
12639 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
12640 * lisp.h (echoing): Remove decl.
12641 (force_auto_save_soon): Declare only if SIGDANGER.
12642 * xdisp.c (redisplay_window): Simplify code, to make it more
12643 obvious that ignore_mouse_drag_p is not accessed if !defined
12644 USE_GTK && !defined HAVE_NS.
12645
93ea6e8f
PE
12646 * intervals.c: Make symbols static if they're not exported.
12647 (merge_properties_sticky, merge_interval_right, delete_interval):
12648 Now static.
12649 * intervals.h (merge_interval_right, delete_interval): Remove decls.
12650
77382fcc
PE
12651 * insdel.c: Make symbols static if they're not exported.
12652 However, leave prepare_to_modify_buffer alone. It's never
12653 called from outside this function, but that appears to be a bug.
12654 (combine_after_change_list, combine_after_change_buffer):
4889fc82 12655 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
12656 (adjust_after_replace_noundo): Remove; unused.
12657 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 12658 (signal_before_change): Remove decls.
77382fcc 12659
9306c32e
PE
12660 * indent.c (val_compute_motion, val_vmotion): Now static.
12661
cd44d2eb
PE
12662 * image.c: Make symbols static if they're not exported.
12663 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
12664 if USE_GTK.
12665 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
12666 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
12667
ad9a7a06
PE
12668 * fringe.c (standard_bitmaps): Now static.
12669 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
12670
81626931
PE
12671 * frame.c: Make symbols static if they're not exported.
12672 (x_report_frame_params, make_terminal_frame): Now static.
12673 (get_frame_param): Now static, unless HAVE_NS.
12674 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
12675 (x_get_resource_string): Remove; not used.
12676 * frame.h (make_terminal_frame, x_report_frame_params):
12677 (x_get_resource_string); Remove decls.
12678 (x_fullscreen_adjust): Declare only if WINDOWSNT.
12679 * lisp.h (get_frame_param): Declare only if HAVE_NS.
12680
239f9db9
PE
12681 * font.c, fontset.c: Make symbols static if they're not exported.
12682 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
12683 (FACE_SUITABLE_FOR_CHAR_P): Use it.
12684 * font.c (font_close_object): Now static.
12685 * font.h (font_close_object): Remove.
12686 * fontset.c (FONTSET_OBJLIST): Remove.
12687 (free_realized_fontset) #if-0 the body, which does nothing.
12688 (face_suitable_for_char_p): #if-0, as it's never called.
12689 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
12690 * xfaces.c (face_at_string_position):
12691 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
12692 since 0 is always ASCII.
12693
dfcf3579
PE
12694 * fns.c (weak_hash_tables): Now static.
12695
5045092b
PE
12696 * fileio.c: Make symbols static if they're not exported.
12697 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
12698 (Vwrite_region_annotation_buffers): Now static.
12699
57a96f5c
PE
12700 * eval.c: Make symbols static if they're not exported.
12701 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
12702 * lisp.h (backtrace_list): Remove decl.
12703
35f08c38
PE
12704 * emacs.c: Make symbols static if they're not exported.
12705 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
12706 (fatal_error_code, fatal_error_signal_hook, standard_args):
12707 Now static.
12708 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
12709 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
12710 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
12711 * lisp.h (fatal_error_signal_hook): Remove decl.
12712 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
12713
f44bd759
PE
12714 * editfns.c: Move a (normally-unused) function to its only use.
12715 * editfns.c, lisp.h (get_operating_system_release): Remove.
12716 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
12717 worth the hassle of breaking this out.
12718
b532497d
PE
12719 * xterm.c: Make symbols static if they're not exported.
12720 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
12721 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
12722 (x_destroy_window, x_delete_display):
12723 Now static.
12724 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
12725 (x_mouse_leave): Remove; unused.
12726 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
12727 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
12728 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
12729 Remove decls.
12730 (x_mouse_leave): Declare only if WINDOWSNT.
12731 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
12732 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
12733 USE_X_TOOLKIT.
12734
1675728f
PE
12735 * ftxfont.c: Make symbols static if they're not exported.
12736 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
12737 HAVE_FREETYPE.
12738 * font.h (ftxfont_driver): Likewise.
12739
e4cebfca
PE
12740 * xfns.c: Make symbols static if they're not exported.
12741 (x_last_font_name, x_display_info_for_name):
12742 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
12743 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
12744 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
12745 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
12746 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
12747 (last_show_tip_args): Now static.
12748 (xic_defaut_fontset, xic_create_fontsetname): Define only if
12749 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
12750 (x_screen_planes): Remove; unused.
12751 * dispextern.h (x_screen_planes): Remove decl.
12752
5bf46f05
PE
12753 * dispnew.c: Make symbols static if they're not exported.
12754 * dispextern.h (redraw_garbaged_frames, scrolling):
12755 (increment_row_positions): Remove.
12756 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
12757 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
12758 Now static.
12759 (redraw_garbaged_frames): Remove; unused.
12760
435f4c28
PE
12761 * xfaces.c: Make symbols static if they're not exported.
12762 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
12763 Remove decls.
12764 * xterm.h (defined_color): Remove decls.
12765 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
12766 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
12767 (menu_face_changed_default, defined_color, free_realized_face):
12768 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
12769 (ascii_face_of_lisp_face): Remove; unused.
12770
8524aef3
PE
12771 * xdisp.c: Make symbols static if they're not exported.
12772 * dispextern.h (scratch_glyph_row, window_box_edges):
12773 (glyph_to_pixel_coords, set_cursor_from_row):
12774 (get_next_display_element, set_iterator_to_next):
12775 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
12776 (show_mouse_face): Remove decls
12777 * frame.h (message_buf_print): Likewise.
12778 * lisp.h (pop_message, set_message, check_point_in_composition):
12779 Likewise.
12780 * xterm.h (set_vertical_scroll_bar): Likewise.
12781 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
12782 (message_buf_print, scratch_glyph_row, displayed_buffer):
12783 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
12784 (get_next_display_element, show_mouse_face, window_box_edges):
12785 (frame_to_window_pixel_xy, check_point_in_composition):
12786 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
12787 (glyph_to_pixel_coords): Remove; unused.
12788
16390cd2
PE
12789 * dired.c (file_name_completion): Now static.
12790
12791 * dbusbind.c (xd_in_read_queued_messages): Now static.
12792
a25f4dfa
PE
12793 * lisp.h (circular_list_error, FOREACH): Remove; unused.
12794 * data.c (circular_list_error): Remove.
12795
14a9c8df
PE
12796 * commands.h (last_point_position, last_point_position_buffer):
12797 (last_point_position_window): Remove decls.
12798 * keyboard.c: Make these variables static.
12799
04f2d78b
CB
12800 * coding.h (coding, code_convert_region, encode_coding_gap):
12801 Remove decls.
74ab6df5
PE
12802 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
12803 (iso_code_class, detect_coding, code_convert_region): Now static.
12804 (encode_coding_gap): Remove; unused.
12805
38dfbee1
PE
12806 * chartab.c (chartab_chars, chartab_bits): Now static.
12807
a2cb4e63
PE
12808 * charset.h (charset_iso_8859_1): Remove decl.
12809 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
12810 Now static.
12811
127198fd
PE
12812 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
12813 * ccl.c (Vccl_program_table): Now static.
12814 (check_ccl_update): Remove; unused.
12815
d85b608f
PE
12816 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
12817 * category.h: ... from here.
12818 * category.c (check_category_table, set_category_set): Now static.
12819
31cd66f3
PE
12820 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
12821 * lisp.h: Remove these decls.
12822
c358e587
PE
12823 * buffer.c (buffer_count): Remove unused var.
12824
e78aecca
PE
12825 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
12826 so that it's not optimized away.
12827 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
12828 * dispextern.h (bidi_dump_cached_states): Remove, since it's
12829 exported only to the debugger.
12830
e192d7d3 12831 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 12832 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 12833
92470028
PE
12834 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
12835 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
12836 was inaccessible from Lisp.
12837 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
12838 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
12839
244ed907
PE
12840 alloc.c: Import and export fewer symbols, and remove unused items.
12841 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
12842 is defined.
12843 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
12844 it's not optimized away by whole-program optimization.
12845 (message_enable_multibyte, free_misc): Remove.
12846 (catchlist, handlerlist, mark_backtrace):
12847 Declare only if BYTE_MARK_STACK.
12848 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
12849 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
12850 (message_enable_multibyte): Remove decl.
12851 (free_misc, interval_free_list, float_block, float_block_index):
12852 (n_float_blocks, float_free_list, cons_block, cons_block_index):
12853 (cons_free_list, last_marked_index):
12854 Now static.
12855 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
12856 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
12857 (mark_backtrace): Define only if BYTE_MARK_STACK.
12858 * xdisp.c (message_enable_multibyte): Now static.
12859
61c2b50e 12860 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
12861 This makes it easier for human readers (and static analyzers)
12862 to see whether these variables are used from other modules.
12863 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
12864 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
12865 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
12866 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
12867 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
12868 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
12869 * xmenu.c, xselect.c:
12870 Declare Q* vars static if they are not used in other modules.
12871 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
12872 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
12873 Remove decls of unexported vars.
12874 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
12875
95c82688
PE
12876 * lisp.h (DEFINE_FUNC): Make sname 'static'.
12877
16a97296
PE
12878 Make Emacs functions such as Fatom 'static' by default.
12879 This makes it easier for human readers (and static analyzers)
12880 to see whether these functions can be called from other modules.
12881 DEFUN now defines a static function. To make the function external
12882 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
12883 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
12884 (Finit_image_library):
16a97296
PE
12885 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
12886 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
12887 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
12888 Remove decls, since these functions are now static.
12889 (Funintern, Fget_internal_run_time): New decls, since these functions
12890 were already external.
95c82688 12891
16a97296
PE
12892 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
12893 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
12894 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
12895 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
12896 * keyboard.c, keymap.c, lread.c:
12897 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
12898 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
12899 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
12900 Mark functions with DEFUE instead of DEFUN,
12901 if they are used in other modules.
12902 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
12903 decls for now-static functions.
12904 * buffer.h (Fdelete_overlay): Remove decl.
12905 * callproc.c (Fgetenv_internal): Mark as internal.
12906 * composite.c (Fremove_list_of_text_properties): Remove decl.
12907 (Fcomposition_get_gstring): New forward static decl.
12908 * composite.h (Fcomposite_get_gstring): Remove decl.
12909 * dired.c (Ffile_attributes): New forward static decl.
12910 * doc.c (Fdocumntation_property): New forward static decl.
12911 * eval.c (Ffetch_bytecode): New forward static decl.
12912 (Funintern): Remove extern decl; now in .h file where it belongs.
12913 * fileio.c (Fmake_symbolic_link): New forward static decl.
12914 * image.c (Finit_image_library): New forward static decl.
12915 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
12916 * intervals.h (Fprevious_property_change):
12917 (Fremove_list_of_text_properties): Remove decls.
12918 * keyboard.c (Fthis_command_keys): Remove decl.
12919 (Fcommand_execute): New forward static decl.
12920 * keymap.c (Flookup_key): New forward static decl.
12921 (Fcopy_keymap): Now static.
12922 * keymap.h (Flookup_key): Remove decl.
12923 * process.c (Fget_process): New forward static decl.
12924 (Fprocess_datagram_address): Mark as internal.
12925 * syntax.c (Fsyntax_table_p): New forward static decl.
12926 (skip_chars): Remove duplicate decl.
12927 * textprop.c (Fprevious_property_change): New forward static decl.
12928 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
12929 Now internal.
12930 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
12931 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
12932
785bbd42
PE
12933 * editfns.c (Fformat): Remove unreachable code.
12934
8b913b57
AS
129352011-04-14 Andreas Schwab <schwab@linux-m68k.org>
12936
12937 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
12938 change. (Bug#8496)
12939
a6744a35
EZ
129402011-04-13 Eli Zaretskii <eliz@gnu.org>
12941
12942 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
12943 when at ZV. (Bug#8487)
12944
e7974947
AS
129452011-04-12 Andreas Schwab <schwab@linux-m68k.org>
12946
baad03f0
AS
12947 * charset.c (Fclear_charset_maps): Use xfree instead of free.
12948 (Bug#8437)
12949 * keyboard.c (parse_tool_bar_item): Likewise.
12950 * sound.c (sound_cleanup, alsa_close): Likewise.
12951 * termcap.c (tgetent): Likewise.
12952 * xfns.c (x_default_font_parameter): Likewise.
12953 * xsettings.c (read_and_apply_settings): Likewise.
12954
e7974947
AS
12955 * alloc.c (overrun_check_malloc, overrun_check_realloc)
12956 (overrun_check_free): Protoize.
12957
28272684
PE
129582011-04-12 Paul Eggert <eggert@cs.ucla.edu>
12959
12960 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
12961 since callers should never pass a negative size.
12962 Change the signature to match that of plain 'read' and 'write'; see
12963 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
12964 * lisp.h: Update prototypes of emacs_write and emacs_read.
12965
11997c76
EZ
129662011-04-11 Eli Zaretskii <eliz@gnu.org>
12967
12968 * xdisp.c (redisplay_window): Don't try to determine the character
12969 position of the scroll margin if the window start point w->startp
e896f03c 12970 is outside the buffer's accessible region. (Bug#8468)
11997c76 12971
8a2cbd72
EZ
129722011-04-10 Eli Zaretskii <eliz@gnu.org>
12973
12974 Fix write-region and its subroutines for buffers > 2GB.
12975 * fileio.c (a_write, e_write): Modify declaration of arguments and
12976 local variables to support buffers larger than 2GB.
12977 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
12978
12979 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
12980 argument, local variables, and return value.
12981
12982 * lisp.h: Update prototypes of emacs_write and emacs_read.
12983
12984 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
12985
4073e537 129862011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 12987
1ebfdcb6
PE
12988 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
12989
b2ded58d
PE
12990 Fix more problems found by GCC 4.6.0's static checks.
12991
7d66342c
PE
12992 * xdisp.c (vmessage): Use a better test for character truncation.
12993
bbf47d44
PE
12994 * charset.c (load_charset_map): <, not <=, for optimization,
12995 and to avoid potential problems with integer overflow.
9248994d 12996 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 12997 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 12998 * editfns.c (Fformat): Likewise.
1e69125e 12999 * syntax.c (skip_chars): Likewise.
3befa583 13000
e3019616
PE
13001 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
13002 This also lets GCC 4.6.0 generate slightly better loop code.
13003
becfa255
PE
13004 * callint.c (Fcall_interactively): <, not <=, for optimization.
13005 (Fcall_interactively): Count the number of arguments produced,
13006 not the number of arguments given. This is simpler and lets GCC
13007 4.6.0 generate slightly better code.
13008
dae0cd48
PE
13009 * ftfont.c: Distingish more carefully between FcChar8 and char.
13010 The previous code passed unsigned char * to a functions like
13011 strlen and xstrcasecmp that expect char *, which does not
13012 conform to the C standard.
13013 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
13014 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
13015 char * when the C standard requires it.
13016
76032d70
PE
13017 * keyboard.c (read_char): Remove unused var.
13018
eb3f1cc8
PE
13019 * eval.c: Port to Windows vsnprintf (Bug#8435).
13020 Include <limits.h>.
13021 (SIZE_MAX): Define if the headers do not.
13022 (verror): Do not give up if vsnprintf returns a negative count.
13023 Instead, grow the buffer. This ports to Windows vsnprintf, which
13024 does not conform to C99. Problem reported by Eli Zaretskii.
13025 Also, simplify the allocation scheme, by avoiding the need for
13026 calling realloc, and removing the ALLOCATED variable.
13027
70476b54
PE
13028 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
13029
12020a9e
PE
13030 Remove invocations of doprnt, as Emacs now uses vsnprintf.
13031 But keep the doprint source code for now, as we might revamp it
13032 and use it again (Bug#8435).
ea6c7ae6
PE
13033 * lisp.h (doprnt): Remove.
13034 * Makefile.in (base_obj): Remove doprnt.o.
13035 * deps.mk (doprnt.o): Remove.
13036
5fdb398c
PE
13037 error: Print 32- and 64-bit integers portably (Bug#8435).
13038 Without this change, on typical 64-bit hosts error ("...%d...", N)
13039 was used to print both 32- and 64-bit integers N, which relied on
13040 undefined behavior.
61bdb816 13041 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
13042 * lisp.h (error, verror): Mark as printf-like functions.
13043 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
13044 Report overflow in size calculations when allocating printf buffer.
13045 Do not truncate output string at its first null byte.
13046 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
13047 Truncate the output at a character boundary, since vsnprintf does not
13048 do that.
13049 * charset.c (check_iso_charset_parameter): Convert internal
13050 character to string before calling 'error', since %c now has the
13051 printf meaning.
13052 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
13053 overflow when computing char to be passed to 'error'. Do not
13054 pass Lisp_Object to 'error'; pass the integer instead.
13055 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
13056 formatted with plain %d.
13057
b189fa66
PE
13058 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
13059
bff87ef0
PE
13060 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
13061
7e2cac20
PE
13062 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
13063
ce4d90b5
PE
13064 * xterm.c (x_catch_errors): Remove duplicate declaration.
13065
266c9547
PE
13066 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
13067
79c49ad2
PE
13068 * xdisp.c, lisp.h (message_nolog): Remove; unused.
13069
368f4090
JM
130702011-04-10 Jim Meyering <meyering@redhat.com>
13071
13072 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
13073 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
13074 return ssize_t not "int", and use size_t as the buffer length.
13075 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
13076 * gnutls.h: Update declarations.
13077 * process.c (read_process_output): Use ssize_t, to match.
13078 (send_process): Likewise.
13079
a32d4040
CY
130802011-04-09 Chong Yidong <cyd@stupidchicken.com>
13081
13082 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
13083
8546720e 130842011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 13085
04f2d78b
CB
13086 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
13087 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 13088
8546720e
GM
13089 * xterm.c (handle_one_xevent):
13090 * xmenu.c (create_and_show_popup_menu):
13091 * xselect.c (x_decline_selection_request)
13092 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 13093
0a2f5c1a 130942011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
13095
13096 Fix some uses of `int' instead of EMACS_INT.
13097 * search.c (string_match_1, fast_string_match)
13098 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
13099 (scan_buffer, find_next_newline_no_quit)
13100 (find_before_next_newline, search_command, Freplace_match)
13101 (Fmatch_data): Make some `int' variables be EMACS_INT.
13102
13103 * xdisp.c (display_count_lines): 3rd argument and return value now
13104 EMACS_INT. All callers changed.
13105 (pint2hrstr): Last argument is now EMACS_INT.
13106
13107 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
13108 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
13109 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
13110 (decode_coding_utf_16, decode_coding_emacs_mule)
13111 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
13112 (decode_coding_ccl, decode_coding_charset)
13113 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
13114 (decode_coding_iso_2022, decode_coding_emacs_mule)
13115 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
13116 <char_offset, last_offset>: Declare EMACS_INT.
13117 (encode_coding_utf_8, encode_coding_utf_16)
13118 (encode_coding_emacs_mule, encode_invocation_designation)
13119 (encode_designation_at_bol, encode_coding_iso_2022)
13120 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
13121 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
13122 Declare EMACS_INT.
13123 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
13124 (encode_invocation_designation): Last argument P_NCHARS is now
13125 EMACS_INT.
13126 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
13127 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
13128
13129 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
13130 All users changed.
13131
13132 * ccl.c (Fccl_execute_on_string): Declare some variables
13133 EMACS_INT.
13134
8546720e 131352011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
13136
13137 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
13138
4e19a977
CS
131392011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
13140
13141 * process.c (Fformat_network_address): Doc fix.
13142
87302331
R
131432011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
13144
ee7683eb 13145 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 13146
cbb59342
CY
131472011-04-08 Chong Yidong <cyd@stupidchicken.com>
13148
13149 * keyboard.c (read_char): Call Lisp function help-form-show,
13150 instead of using internal_with_output_to_temp_buffer.
13151 (Qhelp_form_show): New var.
e0d38eeb 13152 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
13153
13154 * print.c (internal_with_output_to_temp_buffer): Function deleted.
13155
13156 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
13157
e67a13ab
CY
131582011-04-06 Chong Yidong <cyd@stupidchicken.com>
13159
04f2d78b
CB
13160 * process.c (Flist_processes): Remove to Lisp.
13161 (list_processes_1): Delete.
e67a13ab 13162
973f782d
EZ
131632011-04-06 Eli Zaretskii <eliz@gnu.org>
13164
7c106b1e
EZ
13165 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
13166
973f782d
EZ
13167 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
13168
41cf7d1a 131692011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 13170
ca23cc88
PE
13171 Fix more problems found by GCC 4.6.0's static checks.
13172
f390e2d5
PE
13173 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
13174
42eea0d0
PE
13175 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
13176
b69769da 13177 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 13178
f9541e84
PE
13179 * xdisp.c (vmessage): Mark as a printf-like function.
13180
13841b55
PE
13181 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
13182
c136c10f
PE
13183 * sound.c (sound_warning): Don't crash if arg contains a printf format.
13184
5e2d4a30
PE
13185 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
13186 printf-like functions.
13187 (tiff_load): Add casts to remove these marks before passing them
13188 to system-supplied API.
13189
583f48b9
PE
13190 * eval.c (Fsignal): Remove excess argument to 'fatal'.
13191
b25d760e
PE
13192 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
13193 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
13194 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
13195 directly, rather than having caller test rule sign. This avoids
13196 some unnecessary tests.
13197 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
13198 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
13199 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 13200
bc7b6697 13201 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 13202 (xfont_open): Avoid unnecessary tests.
bc7b6697 13203
27ccc379
PE
13204 * composite.c (composition_gstring_put_cache): Use unsigned integer.
13205
dcd5c89a
PE
13206 * composite.h, composite.c (composition_gstring_put_cache):
13207 Use EMACS_INT, not int, for length.
13208
b13a45c6
PE
13209 * composite.h (COMPOSITION_DECODE_REFS): New macro,
13210 breaking out part of COMPOSITION_DECODE_RULE.
13211 (COMPOSITION_DECODE_RULE): Use it.
13212 * composite.c (get_composition_id): Remove unused local vars,
13213 by using the new macro.
13214
1e792e4d
PE
13215 * textprop.c (set_text_properties_1): Change while to do-while,
13216 since the condition is always true at first.
13217
dc6c6455 13218 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
13219 (interval_deletion_adjustment): Return unsigned value.
13220 All uses changed.
dc6c6455 13221
aba7731a
PE
13222 * process.c (list_processes_1, create_pty, read_process_output):
13223 (exec_sentinel): Remove vars that were set but not used.
afd4052b 13224 (create_pty): Remove unnecessary "volatile"s.
bc57d757 13225 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 13226 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 13227 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 13228
fdfc4bf3
PE
13229 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
13230
fca8fe46 13231 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 13232 (update_syntax_table): Use unsigned instead of int.
fca8fe46 13233
06a0259a 13234 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 13235 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 13236 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 13237
e7b9e80f
PE
13238 * print.c (print_error_message): Avoid int overflow.
13239
56201685
PE
13240 * font.c (font_list_entities): Redo for clarity,
13241 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
13242
78834453 13243 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 13244 (font_score): Avoid potential overflow in diff calculation.
78834453 13245
0bc0b309 13246 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 13247 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 13248
e610eaca
PE
13249 * eval.c (funcall_lambda): Rename local to avoid shadowing.
13250
b895abce
PE
13251 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
13252 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
13253 can always succeed if overflow has undefined behavior.
13254
1f1d9321 13255 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 13256 (wordify): Omit three unnecessary tests.
1f1d9321 13257
c59478bc
PE
13258 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
13259 All callers changed. This avoids the need for an unused var.
13260
79b73827
PE
13261 * casefiddle.c (casify_region): Remove var that is set but not used.
13262
a4db5dfe
PE
13263 * dired.c (file_name_completion): Remove var that is set but not used.
13264
43aae36e
PE
13265 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
13266
2a47c44d 13267 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 13268 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 13269
a37c69bf
PE
13270 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
13271 Check for integer overflow on size calculations.
13272
328ab8e7
PE
13273 * buffer.c (Fprevious_overlay_change): Remove var that is set
13274 but not used.
13275
e5a2a5cb
PE
13276 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
13277 Remove vars that are set but not used.
8d84a6eb 13278 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 13279 (timer_check_2): Mark vars as initialized.
e5a2a5cb 13280
a60e5f68
PE
13281 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
13282
f661cb61 13283 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 13284 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 13285
f0397f5a
PE
13286 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
13287 that are set but not used.
13288
8664db06 13289 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 13290 if XCreateBitmapFromData fails (Bug#8410).
8664db06 13291
6abdaa4a
PE
13292 * xselect.c (x_get_local_selection, x_handle_property_notify):
13293 Remove vars that are set but not used.
13294
0ce7538d 13295 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 13296 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 13297
9ae848fc
PE
13298 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
13299 Remove var that is set but not used.
0b918413
PE
13300 (scroll_bar_windows_size): Now size_t, not int.
13301 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
13302 Check for overflow.
9ae848fc 13303
a5a62657
PE
13304 * xfaces.c (realize_named_face): Remove vars that are set but not used.
13305 (map_tty_color) [!defined MSDOS]: Likewise.
13306
5c5cdd39
PE
13307 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
13308
66ebf983
PE
13309 * coding.c: Remove vars that are set but not used.
13310 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
13311 All callers changed.
13312 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
13313 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
13314 (decode_coding_charset): Remove vars that are set but not used.
13315
1be4d761
PE
13316 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
13317 that is set but not used.
13318
47553fa8
PE
13319 * print.c (print_object): Remove var that is set but not used.
13320
1f7196bf 13321 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
13322 The gnulib version avoids calling malloc in the usual case,
13323 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
13324 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
13325 * filelock.c (current_lock_owner): Likewise.
13326 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
13327 * sysdep.c: Include allocator.h, careadlinkat.h.
13328 (emacs_no_realloc_allocator): New static constant.
13329 (emacs_readlink): New function.
fdb61804
PE
13330 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
13331 ../lib/careadlinkat.h.
d1fdcab7 13332
f84c17c7
SM
133332011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
13334
13335 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
13336 first non-nil return value).
13337
ef3862ad
JD
133382011-04-03 Jan Djärv <jan.h.d@swipnet.se>
13339
13340 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
13341 if not defined (Bug#8403).
13342
376a7006
JB
133432011-04-02 Juanma Barranquero <lekktu@gmail.com>
13344
13345 * xdisp.c (display_count_lines): Remove parameter `start',
13346 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13347 (get_char_face_and_encoding): Remove parameter `multibyte_p',
13348 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13349 (fill_stretch_glyph_string): Remove parameters `row' and `area',
13350 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
13351 and thereabouts. All callers changed.
13352 (get_per_char_metric): Remove parameter `f', unused since
13353 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13354
6ca3801d
JM
133552011-04-02 Jim Meyering <meyering@redhat.com>
13356
13357 do not dereference NULL upon failed strdup
13358 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
13359 (ns_get_family): Likewise.
13360
d8e2b5ba
JB
133612011-04-02 Juanma Barranquero <lekktu@gmail.com>
13362
13363 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
13364
8c74fcbd
JD
133652011-04-02 Jan Djärv <jan.h.d@swipnet.se>
13366
13367 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
13368 later (Bug#8403).
13369
7200d79c
SM
133702011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
13371
03408648 13372 Add lexical binding.
7200d79c 13373
03408648
SM
13374 * window.c (Ftemp_output_buffer_show): New fun.
13375 (Fsave_window_excursion):
13376 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
13377
13378 * lread.c (lisp_file_lexically_bound_p): New function.
13379 (Fload): Bind Qlexical_binding.
13380 (readevalloop): Remove `evalfun' arg.
13381 Bind Qinternal_interpreter_environment.
13382 (Feval_buffer): Bind Qlexical_binding.
13383 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
13384 Mark as dynamic.
13385 (syms_of_lread): Declare `lexical-binding'.
13386
13387 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
13388
13389 * keyboard.c (eval_dyn): New fun.
13390 (menu_item_eval_property): Use it.
ca105506
SM
13391
13392 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 13393
03408648
SM
13394 * fns.c (concat, mapcar1): Accept byte-code-functions.
13395
13396 * eval.c (Fsetq): Handle lexical vars.
13397 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
13398 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
13399 (FletX, Flet): Obey lexical binding.
13400 (Fcommandp): Handle closures.
13401 (Feval): New `lexical' arg.
13402 (eval_sub): New function extracted from Feval. Use it almost
13403 everywhere where Feval was used. Look up vars in lexical env.
13404 Handle closures.
13405 (Ffunctionp): Move from subr.el.
13406 (Ffuncall): Handle closures.
13407 (apply_lambda): Remove `eval_flags'.
13408 (funcall_lambda): Handle closures and new byte-code-functions.
13409 (Fspecial_variable_p): New function.
13410 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
13411 but without exporting it to Lisp.
23aba0ea 13412
23aba0ea 13413 * doc.c (Fdocumentation, store_function_docstring):
03408648 13414 * data.c (Finteractive_form): Handle closures.
23aba0ea 13415
03408648
SM
13416 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
13417 interactive spec.
ba83908c 13418
04f2d78b
CB
13419 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
13420 New byte-codes.
03408648
SM
13421 (exec_byte_code): New function extracted from Fbyte_code to handle new
13422 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 13423
03408648 13424 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 13425
03408648 13426 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 13427
e2abce01
JB
134282011-03-31 Juanma Barranquero <lekktu@gmail.com>
13429
13430 * xdisp.c (redisplay_internal): Fix prototype.
13431
63696a73 134322011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 13433
63696a73 13434 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
13435 (try_scrolling): Use it when setting scroll_limit.
13436 Limit scrolling to 100 screen lines.
63696a73
EZ
13437 (redisplay_window): Even when falling back on "recentering",
13438 position point in the window according to scroll-conservatively,
13439 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
13440
13441 (try_scrolling): When point is above the window, allow searching
13442 as far as scroll_max, or one screenful, to compute vertical
13443 distance from PT to the scroll margin position. This prevents
13444 try_scrolling from unnecessarily failing when
13445 scroll-conservatively is set to a value slightly larger than the
13446 window height. Clean up the case of PT below the margin at bottom
13447 of window: scroll_max can no longer be INT_MAX. When aggressive
13448 scrolling is in use, don't let point enter the opposite scroll
13449 margin as result of the scroll.
13450 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
13451 threshold of 100 lines for never-recentering scrolling.
13452
e4cc2dfc
JB
134532011-03-31 Juanma Barranquero <lekktu@gmail.com>
13454
13455 * dispextern.h (move_it_by_lines):
13456 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
13457 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
13458 (message_log_check_duplicate): Remove parameters `prev_bol' and
13459 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13460 (redisplay_internal): Remove parameter `preserve_echo_area',
13461 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
13462
13463 * indent.c (Fvertical_motion):
13464 * window.c (window_scroll_pixel_based, Frecenter):
13465 Don't pass `need_y_p' to `move_it_by_lines'.
13466
1c470562
SM
134672011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
13468
44f230aa
SM
13469 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
13470 steal a few bits to be more compact.
13471 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
13472 Remove unneeded casts.
13473
1c470562
SM
13474 * bytecode.c (Fbyte_code): CAR and CDR can GC.
13475
888adce9
ZK
134762011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
13477
13478 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
13479 binding" message (bug#7967).
13480
f838ed7b
PE
134812011-03-30 Paul Eggert <eggert@cs.ucla.edu>
13482
77861b95
PE
13483 Fix more problems found by GCC 4.6.0's static checks.
13484
de6dbc14
PE
13485 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
13486 Remove unused local var.
13487
f838ed7b
PE
13488 * editfns.c (Fmessage_box): Remove unused local var.
13489
792c7b2b
PE
13490 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
13491 (note_mode_line_or_margin_highlight, note_mouse_highlight):
13492 Omit unused local vars.
c499e557 13493 * window.c (shrink_windows): Omit unused local var.
b01a1c29 13494 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
13495 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
13496 Omit unused local var.
13497
ba0165e1
PE
13498 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
13499 Don't assume string length fits in int.
32ad8845 13500 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 13501 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 13502
3c59b4c9
PE
13503 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
13504 instead of alloca (Bug#8344).
13505
a3eed478 13506 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 13507 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 13508
eb4d412d
PE
13509 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
13510
1658b401
PE
13511 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
13512 concerns.
13513
13514 * term.c (produce_glyphless_glyph): Remove unnecessary test.
13515
13516 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 13517
9a2c6e05
PE
13518 * keyboard.c (syms_of_keyboard): Use the same style as later
13519 in this function when indexing through an array. This also
13520 works around GCC bug 48267.
13521
03d0a109
PE
13522 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
13523
44f730c8
PE
13524 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
13525
fe75f926
PE
13526 * chartab.c (sub_char_table_ref_and_range): Redo for slight
13527 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
13528
ffa8c828
PE
13529 * keyboard.c, keyboard.h (num_input_events): Now size_t.
13530 This avoids undefined behavior on integer overflow, and is a bit
13531 more convenient anyway since it is compared to a size_t variable.
13532
c5101a77
PE
13533 Variadic C functions now count arguments with size_t, not int.
13534 This avoids an unnecessary limitation on 64-bit machines, which
13535 caused (substring ...) to crash on large vectors (Bug#8344).
13536 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
13537 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 13538 All variadic functions and their callers changed accordingly.
c5101a77
PE
13539 (struct gcpro.nvars): Now size_t, not int. All uses changed.
13540 * data.c (arith_driver, float_arith_driver): Likewise.
13541 * editfns.c (general_insert_function): Likewise.
13542 * eval.c (struct backtrace.nargs, interactive_p)
13543 (internal_condition_case_n, run_hook_with_args, apply_lambda)
13544 (funcall_lambda, mark_backtrace): Likewise.
13545 * fns.c (concat): Likewise.
13546 * frame.c (x_set_frame_parameters): Likewise.
13547 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
13548 0 if not found, not -1. All callers changed.
13549
dd3f25f7
PE
13550 * alloc.c (garbage_collect): Don't assume stack size fits in int.
13551 (stack_copy_size): Now size_t, not int.
13552 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
13553
461c2ab9
JB
135542011-03-28 Juanma Barranquero <lekktu@gmail.com>
13555
13556 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
13557 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13558 All callers changed.
13559
13560 * lisp.h (multibyte_char_to_unibyte):
13561 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
13562 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13563 * character.h (CHAR_TO_BYTE8):
13564 * cmds.c (internal_self_insert):
13565 * editfns.c (general_insert_function):
13566 * keymap.c (push_key_description):
13567 * search.c (Freplace_match):
13568 * xdisp.c (message_dolog, set_message_1): All callers changed.
13569
f6d62986
SM
135702011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
13571
13572 * keyboard.c (safe_run_hook_funcall): New function.
13573 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
13574 don't set the hook to nil, but remove the offending function instead.
13575 (Qcommand_hook_internal): Remove, unused.
13576 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
13577 Vcommand_hook_internal.
13578
13579 * eval.c (enum run_hooks_condition): Remove.
13580 (funcall_nil, funcall_not): New functions.
13581 (run_hook_with_args): Call each function through a `funcall' argument.
13582 Remove `cond' argument, now redundant.
13583 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
13584 (Frun_hook_with_args_until_failure): Adjust accordingly.
13585 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
13586
1db5b1ad
JB
135872011-03-28 Juanma Barranquero <lekktu@gmail.com>
13588
13589 * dispextern.h (string_buffer_position): Remove declaration.
13590
13591 * print.c (strout): Remove parameter `multibyte', unused since
13592 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
13593
13594 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
13595 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
13596 All callers changed.
13597
13598 * w32.c (_wsa_errlist): Use braces for struct initializers.
13599
13600 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
13601 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
13602 All callers changed.
13603 (string_buffer_position): Likewise. Also, make static (it's never
13604 used outside xdisp.c).
13605 (cursor_row_p): Remove parameter `w', unused since
13606 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
13607 (decode_mode_spec): Remove parameter `precision', introduced during
13608 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
13609 All callers changed.
13610
5ffb62aa
JD
136112011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13612
13613 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
13614
461c2ab9 136152011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
13616
13617 * nsterm.m (ns_menu_bar_is_hidden): New variable.
13618 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
13619 (ns_update_auto_hide_menu_bar): New functions.
13620 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
13621 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
13622 ns_constrain_all_frames.
13623 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
13624 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
13625
5c380ffb
JD
136262011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13627
13628 * nsmenu.m (runDialogAt): Remove argument to timer_check.
13629
9af30bdf
GM
136302011-03-27 Glenn Morris <rgm@gnu.org>
13631
13632 * syssignal.h: Replace RETSIGTYPE with void.
13633 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
13634 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
13635 Replace SIGTYPE with void everywhere.
13636 * s/usg5-4-common.h (SIGTYPE): Remove definition.
13637 * s/template.h (SIGTYPE): Remove commented out definition.
13638
e2abce01
JB
136392011-03-26 Eli Zaretskii <eliz@gnu.org>
13640
13641 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
13642 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
13643
f868cd8a
JB
136442011-03-26 Juanma Barranquero <lekktu@gmail.com>
13645
59eb0929
JB
13646 * w32.c (read_unc_volume): Use parameter `henum', instead of
13647 global variable `wget_enum_handle'.
13648
13649 * keymap.c (describe_vector): Remove parameters `indices' and
13650 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
13651 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
13652
f868cd8a
JB
13653 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
13654
13655 * keyboard.c (timer_check): Remove parameter `do_it_now',
13656 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
13657 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
13658 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
13659
13660 * keyboard.c (read_char):
13661 * w32menu.c (w32_menu_display_help):
13662 * xmenu.c (show_help_event, menu_help_callback):
13663 Adjust calls to `show_help_echo'.
13664
13665 * gtkutil.c (xg_maybe_add_timer):
13666 * keyboard.c (readable_events):
13667 * process.c (wait_reading_process_output):
13668 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
13669
13670 * insdel.c (adjust_markers_gap_motion):
13671 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
13672 (gap_left, gap_right): Don't call it.
13673
2ecf6fdb
CY
136742011-03-25 Chong Yidong <cyd@stupidchicken.com>
13675
13676 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
13677 incurred during fontification.
13678
6b1f9ba4
JB
136792011-03-25 Juanma Barranquero <lekktu@gmail.com>
13680
13681 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
13682 (DEFVAR_PER_BUFFER): Don't pass it.
13683
13684 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
13685 (scrolling_window): Don't pass it.
13686
0f4a96b5
JB
136872011-03-25 Juanma Barranquero <lekktu@gmail.com>
13688
13689 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
13690
13691 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
13692 and `suffix'.
13693 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
13694 of variables specific to SELinux and computation of `encoded_absname'.
13695
13696 * image.c (XPutPixel): Remove unused variable `height'.
13697
13698 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
13699
13700 * unexw32.c (get_section_info): Remove unused variable `section'.
13701
13702 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
13703 (system_process_attributes): Remove unused variable `sess'.
13704 (sys_read): Remove unused variable `err'.
13705
13706 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
13707 (w32_wnd_proc): Remove unused variable `isdead'.
13708 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
13709 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
13710 (x_create_tip_frame): Remove unused variable `tem'.
13711
13712 * w32inevt.c (w32_console_read_socket):
13713 Remove unused variable `no_events'.
13714
13715 * w32term.c (x_draw_composite_glyph_string_foreground):
13716 Remove unused variable `width'.
13717
1149507c
JB
137182011-03-24 Juanma Barranquero <lekktu@gmail.com>
13719
13720 * w32term.c (x_set_glyph_string_clipping):
13721 Don't pass uninitialized region to CombineRgn.
13722
9c88f339
JB
137232011-03-23 Juanma Barranquero <lekktu@gmail.com>
13724
13725 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
13726 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
13727 (Fx_close_connection): Remove unused variable `i'.
13728
13729 * w32font.c (w32font_draw): Return number of glyphs.
13730 (w32font_open_internal): Remove unused variable `i'.
13731 (w32font_driver): Add missing initializer.
13732
13733 * w32menu.c (utf8to16): Remove unused variable `utf16'.
13734 (fill_in_menu): Remove unused variable `items_added'.
13735
13736 * w32term.c (last_mouse_press_frame): Remove static global variable.
13737 (w32_clip_to_row): Remove unused variable `f'.
13738 (x_delete_terminal): Remove unused variable `i'.
13739
13740 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
13741 (NOTHING): Remove unused static global variable.
13742 (uniscribe_check_otf): Remove unused variable `table'.
13743 (uniscribe_font_driver): Add missing initializers.
13744
dee091a3
JD
137452011-03-23 Julien Danjou <julien@danjou.info>
13746
13747 * term.c (Fsuspend_tty, Fresume_tty):
13748 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
13749 * window.c (temp_output_buffer_show):
13750 * insdel.c (signal_before_change):
13751 * frame.c (Fhandle_switch_frame):
13752 * fileio.c (Fdo_auto_save):
13753 * emacs.c (Fkill_emacs):
13754 * editfns.c (save_excursion_restore):
13755 * cmds.c (internal_self_insert):
13756 * callint.c (Fcall_interactively):
13757 * buffer.c (Fkill_all_local_variables):
13758 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
13759 Use Frun_hooks.
0f4a96b5 13760 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 13761 unconditionally since it does the check itself.
dee091a3 13762
2c520ab5 137632011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 13764
c9c49752
PE
13765 Fix more problems found by GCC 4.5.2's static checks.
13766
8abc3f12
PE
13767 * coding.c (encode_coding_raw_text): Avoid unnecessary test
13768 the first time through the loop, since we know p0 < p1 then.
13769 This also avoids a gcc -Wstrict-overflow warning.
13770
a2d26660
PE
13771 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
13772 leading to a memory leak, possible in functions like
13773 load_charset_map_from_file that can allocate an unbounded number
b12ef411 13774 of objects (Bug#8318).
a2d26660 13775
916c72e9
PE
13776 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
13777 that could (at least in theory) be that large.
13778
19ab8a18
PE
13779 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
13780 This is less likely to overflow, and avoids undefined behavior if
13781 overflow does occur. All callers changed. Use strtoul to scan
13782 for the unsigned long integer.
b7cbbd6f
PE
13783 (pint2hrstr): Simplify and tune code slightly.
13784 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 13785
f0641eff
PE
13786 * scroll.c (do_scrolling): Work around GCC bug 48228.
13787 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
13788
7f650bb9
PE
13789 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
13790 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
13791 (validate_x_resource_name): Simplify count usage.
13792 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 13793
37dd57d1
PE
13794 * fileio.c (Fcopy_file): Report error if fchown or fchmod
13795 fail (Bug#8306).
81e56e61 13796
699979fc 13797 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 13798
401bf9b4
PE
13799 * process.c (Fmake_network_process): Use socklen_t, not int,
13800 where POSIX says socklen_t is required in portable programs.
13801 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 13802 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
13803 (Fmake_network_process, server_accept_connection):
13804 (wait_reading_process_output, read_process_output):
13805 Likewise.
13806
b93aacde
PE
13807 * process.c: Rename or move locals to avoid shadowing.
13808 (list_processes_1, Fmake_network_process):
13809 (read_process_output_error_handler, exec_sentinel_error_handler):
13810 Rename or move locals.
4dc343ee 13811 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 13812 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 13813 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 13814 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 13815 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 13816
af8a867c 13817 Make tparam.h and terminfo.c consistent.
44f230aa
SM
13818 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
13819 Include tparam.h instead, since it declares them.
af8a867c
PE
13820 * cm.h (PC): Remove extern decl; tparam.h now does this.
13821 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
13822 * terminfo.c: Include tparam.h, to check interfaces.
13823 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
13824 (tparam): Adjust signature to match interface in tparam.h;
13825 this removes some undefined behavior. Check that outstring and len
13826 are zero, which they always are with Emacs.
13827 * tparam.h (PC, BC, UP): New extern decls.
13828
0248044d 13829 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 13830 (xftfont_open): Rename locals to avoid shadowing.
0248044d 13831
8ff096c1 13832 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
13833 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
13834 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 13835 (ftfont_list): Remove unused local.
49eaafba
PE
13836 (get_adstyle_property, ftfont_pattern_entity):
13837 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
13838 Rename locals to avoid shadowing.
8ff096c1 13839
e2be39f6
PE
13840 * xfont.c (xfont_list_family): Mark var as initialized.
13841
c9735e30
PE
13842 * xml.c (make_dom): Now static.
13843
8f5201ae
PE
13844 * composite.c (composition_compute_stop_pos): Rename local to
13845 avoid shadowing.
b246f932
PE
13846 (composition_reseat_it): Remove unused locals.
13847 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 13848 (composition_update_it): Mark var as initialized.
11b61122
PE
13849 (find_automatic_composition): Mark vars as initialized,
13850 with a FIXME (Bug#8290).
8f5201ae 13851
760fbc2c
PE
13852 character.h: Rename locals to avoid shadowing.
13853 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
13854 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
13855 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
13856 (BUF_DEC_POS): Be more systematic about renaming local temporaries
13857 to avoid shadowing.
13858
ff08eb85
PE
13859 * textprop.c (property_change_between_p): Remove; unused.
13860
fc7bf025
PE
13861 * intervals.c (interval_start_pos): Now static.
13862
235d7abc
PE
13863 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
13864
44f230aa
SM
13865 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
13866 Rename locals to avoid shadowing.
3e7d6594 13867
50060332
PE
13868 * sound.c (wav_play, au_play, Fplay_sound_internal):
13869 Fix pointer signedness.
d01f234b 13870 (alsa_choose_format): Remove unused local var.
c83b8872
PE
13871 (wav_play): Initialize a variable to 0, to prevent undefined
13872 behavior (Bug#8278).
50060332 13873
c4fc4e30
PE
13874 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
13875
918436ed
PE
13876 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
13877
c939f91b
PE
13878 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
13879 clobbering (Bug#8298).
b9c7f648
PE
13880 * sysdep.c (sys_subshell): Likewise.
13881 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 13882
6bd8c144
PE
13883 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
13884 This should get cleaned up, so that child_setup has the
13885 same signature on all platforms.
13886
7710357c 13887 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 13888 (relocate_fd): Rename locals to avoid shadowing.
7710357c 13889
c59da222
CY
138902011-03-22 Chong Yidong <cyd@stupidchicken.com>
13891
13892 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
13893 not to be necessary, and produces flickering.
13894
66b87493
GM
138952011-03-20 Glenn Morris <rgm@gnu.org>
13896
13897 * config.in: Remove file.
13898
45b6f6d5
JB
138992011-03-20 Juanma Barranquero <lekktu@gmail.com>
13900
13901 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
13902 are now in src/globals.h.
13903 (syms_of_minibuf): Remove spurious & from previous change.
13904
cd394be1 139052011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
13906
13907 * minibuf.c (completing-read-function): New variable.
13908 (completing-read-default): Rename from completing-read.
13909 (completing-read): Call completing-read-function.
13910
b14e3e21
CY
139112011-03-19 Juanma Barranquero <lekktu@gmail.com>
13912
13913 * xfaces.c (Fx_load_color_file):
13914 Read color file from absolute filename (bug#8250).
13915
f2b726e6
JB
139162011-03-19 Juanma Barranquero <lekktu@gmail.com>
13917
13918 * makefile.w32-in: Update dependencies.
13919
09f6ff02
EZ
139202011-03-17 Eli Zaretskii <eliz@gnu.org>
13921
13922 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
13923
29a6015a
PE
139242011-03-17 Paul Eggert <eggert@cs.ucla.edu>
13925
a3a6c54e
PE
13926 Fix more problems found by GCC 4.5.2's static checks.
13927
b766f867
PE
13928 * process.c (make_serial_process_unwind, send_process_trap):
13929 (sigchld_handler): Now static.
13930
be02381c
PE
13931 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
13932 That way, the code declares only the vars that it needs.
13933 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
13934 * s/cygwin.h (PTY_ITERATION): Likewise.
13935 * s/darwin.h (PTY_ITERATION): Likewise.
13936 * s/gnu-linux.h (PTY_ITERATION): Likewise.
13937
57048744
PE
13938 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
13939 * process.c (allocate_pty): Don't declare stb unless it's needed.
13940
7914961c 13941 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
13942 (CONSTANTLIM): Remove; unused.
13943 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
13944 Define only if needed.
7914961c 13945
b3967b18
PE
13946 * unexelf.c (unexec): Name an expression,
13947 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
13948 Use a different way to cause a compilation error if anyone uses
13949 n rather than nn, a way that does not involve shadowing.
73366a00 13950 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 13951
29a6015a
PE
13952 * deps.mk (unexalpha.o): Remove; unused.
13953
43cfc33e 13954 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 13955 * unexec.h: New file.
ce701a33
PE
13956 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
13957 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
13958 Depend on unexec.h.
13959 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
13960 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
13961 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 13962 Change as necessary to match prototype in unexec.h.
ce701a33 13963
01f44d5a
PE
13964 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
13965 shadowing.
4f63c6bb 13966 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 13967
a6670b0b
PE
13968 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
13969 Rename locals to avoid shadowing.
13970
cef2010d 13971 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 13972 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 13973
d4d7173a
PE
13974 * print.c (Fredirect_debugging_output): Fix pointer signedess.
13975
f08b802a
PE
13976 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
13977 warning when compiling print.c.
13978
3ddb0639
PE
13979 * font.c (font_unparse_fcname): Abort in an "impossible" situation
13980 instead of using an uninitialized var.
5ad03b97 13981 (font_sort_entities): Mark var as initialized.
3ddb0639 13982
170a2692
PE
13983 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
13984
e663c700
PE
13985 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
13986 pointers to constants.
89bc529a 13987 (font_parse_fcname): Remove unused vars.
7b81e2d0 13988 (font_delete_unmatched): Now static.
ea838e10 13989 (font_get_spec): Remove; unused.
13a547c6
PE
13990 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
13991 (font_update_drivers, Ffont_get_glyphs, font_add_log):
13992 Rename or move locals to avoid shadowing.
e663c700 13993
2a80c887 13994 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 13995 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 13996
1384fa33 13997 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 13998 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 13999
8b2c52e9
PE
14000 * alloc.c (mark_backtrace): Move decl from here ...
14001 * lisp.h: ... to here, so that it can be checked.
14002
475545b5 14003 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 14004 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
14005 (lisp_indirect_variable): Name an expression,
14006 to avoid gcc -Wbad-function-cast warning.
1faed8ae 14007 (Fdefvar): Rename locals to avoid shadowing.
475545b5 14008
b1349114 14009 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 14010 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 14011 Use const pointer when appropriate.
b1349114 14012
a2928364
PE
14013 * lisp.h (get_system_name, get_operating_system_release):
14014 Move decls here, to check interfaces.
14015 * process.c (get_operating_system_release): Move decl to lisp.h.
14016 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
14017 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
14018 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
14019 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
14020 (Fformat_time_string, Fencode_time, Finsert_char):
14021 (Ftranslate_region_internal, Fformat):
14022 Rename or remove local vars to avoid shadowing.
9710023e 14023 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 14024
a415e694
PE
14025 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
14026 avoid shadowing.
14027
8ef4622d
PE
14028 * lisp.h (eassert): Check that the argument compiles, even if
14029 ENABLE_CHECKING is not defined.
14030
946f9a5b
PE
14031 * data.c (Findirect_variable): Name an expression, to avoid
14032 gcc -Wbad-function-cast warning.
112396d6 14033 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 14034 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
14035 (Fmake_variable_buffer_local, Fmake_local_variable):
14036 Mark variables as initialized.
52746918 14037 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 14038
e5aab7e7 14039 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
14040 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
14041 Rename locals to avoid shadowing.
dff45157
PE
14042 (mark_stack): Move local variables into the #ifdef region where
14043 they're used.
7bc26fdb
PE
14044 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
14045 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
14046 needed otherwise.
14047 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
14048 (GC_STRING_CHARS): Remove; not used.
d40d4be1 14049 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 14050
e5aab7e7
PE
14051 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
14052 avoids undefined behavior in theory.
14053
4da60324
PE
14054 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
14055
88043301
PE
14056 Use functions, not macros, for up- and down-casing (Bug#8254).
14057 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14058 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
14059 to use the following functions instead of these macros.
14060 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
14061 EMACS_INT, since callers assume the returned value fits in int.
14062 (upcase1): Likewise, for UPCASE_TABLE.
14063 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 14064 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 14065 the race-condition problem in the old DOWNCASE.
88043301 14066
19ed5445
PE
14067 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
14068 Rename locals to avoid shadowing.
14069 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
14070 (regex_compile, re_search_2, re_match_2_internal):
14071 Remove unused local vars.
952db0d7
PE
14072 (FREE_VAR): Rewrite so as not to use empty "else",
14073 which gcc can warn about.
da053e48 14074 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
14075 (RETALLOC_IF): Define only if needed.
14076 (WORDCHAR_P): Likewise. This one is never needed, but is used
14077 only in a comment talking about a compiler bug, so put inside
14078 the #if 0 of that comment.
14079 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
14080 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
14081 Remove; unused.
19ed5445 14082
1f3561e4 14083 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
14084 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
14085 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 14086
ded6f8f7
PE
14087 * search.c (simple_search): Remove unused var.
14088
dbd37a95
PE
14089 * dired.c (compile_pattern): Move decl from here ...
14090 * lisp.h: ... to here, so that it can be checked.
14091 (struct re_registers): New forward decl.
14092
7e47afad
PE
14093 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
14094
85f24f61
PE
14095 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
14096 All uses changed.
14097 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
14098 Rename locals to avoid shadowing.
5671df8f 14099 (Fvertical_motion): Mark locals as initialized.
85f24f61 14100
181aa2be 14101 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 14102 (casify_region): Mark local as initialized.
181aa2be 14103
930d429c
PE
14104 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
14105
7082eac6
PE
14106 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
14107 New macros, so that the caller can use some names other than
14108 gcpro1, gcpro2, etc.
14109 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
14110 of the new macros.
14111 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
14112 argument, for consistency with GCPRO2_VAR, etc: it is now the
14113 prefix of the variable, not the variable itself. All uses
14114 changed.
38b2c076
PE
14115 * dired.c (directory_files_internal, file_name_completion):
14116 Rename locals to avoid shadowing.
14117
15206ed9
PE
14118 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
14119 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
14120 dired.c's scmp function, had undefined behavior.
14121 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14122 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
14123 * buffer.h: ... to here, because these macros use current_buffer,
14124 and the new implementation with inline functions needs to have
14125 current_buffer in scope now, rather than later when the macros
14126 are used.
14127 (downcase, upcase1): New static inline functions.
14128 (DOWNCASE, UPCASE1): Reimplement using these functions.
14129 This avoids undefined behavior in expressions like
14130 DOWNCASE (x) == DOWNCASE (y), which previously suffered
14131 from race conditions in accessing the global variables
14132 case_temp1 and case_temp2.
14133 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
14134 * lisp.h (case_temp1, case_temp2): Remove their decls.
14135 * character.h (ASCII_CHAR_P): Move from here ...
14136 * lisp.h: ... to here, so that the inline functions mentioned
14137 above can use them.
14138
4a6bea26
PE
14139 * dired.c (directory_files_internal_unwind): Now static.
14140
f14b7e14
PE
14141 * fileio.c (file_name_as_directory, directory_file_name):
14142 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
14143 Now static.
2893f146
PE
14144 (file_name_as_directory): Use const pointers when appropriate.
14145 (Fexpand_file_name): Likewise. In particular, newdir might
14146 point at constant storage, so make it a const pointer.
fd4ead52 14147 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
14148 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
14149 signedness issues.
f839df0c
PE
14150 (Fset_file_times, Finsert_file_contents, auto_save_error):
14151 Rename locals to avoid shadowing.
f14b7e14 14152
5716756e 14153 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
14154 (Ftry_completion, Fall_completions): Rename or remove locals
14155 to avoid shadowing.
5716756e 14156
b4c3046a
PE
14157 * marker.c (bytepos_to_charpos): Remove; unused.
14158
b45db522
PE
14159 * lisp.h (verify_bytepos, count_markers): New decls,
14160 so that gcc does not warn that these functions aren't declared.
14161
85876d07
PE
14162 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
14163 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 14164 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 14165 (copy_text): Remove unused local var.
85876d07 14166
03d78a21 14167 * filelock.c (within_one_second): Now static.
b3dd38ab 14168 (lock_file_1): Rename local to avoid shadowing.
03d78a21 14169
5df8f01b
PE
14170 * buffer.c (fix_overlays_before): Mark locals as initialized.
14171 (fix_start_end_in_overlays): Likewise. This function should be
14172 simplified by using pointers-to-pointers, but that's a different
14173 matter.
b1d876f1 14174 (switch_to_buffer_1): Now static.
8f54f30a
PE
14175 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
14176 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 14177
a70072c9 14178 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 14179 Fix pointer signedness issue.
edced198
PE
14180 (sys_subshell): Mark local as volatile if checking for lint,
14181 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 14182 (MAXPATHLEN): Define only if needed.
a70072c9 14183
a0977c44
PE
14184 * process.c (serial_open, serial_configure): Move decls from here ...
14185 * systty.h: ... to here, so that they can be checked.
14186
a884fdcc
PE
14187 * fns.c (get_random, seed_random): Move extern decls from here ...
14188 * lisp.h: ... to here, so that they can be checked.
14189
604efe86 14190 * sysdep.c (reset_io): Now static.
b8950c94 14191 (wait_for_termination_signal): Remove; unused.
604efe86 14192
38fc62d9
PE
14193 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
14194 (copy_keymap_item, append_key, push_text_char_description):
14195 Now static.
1004a21a 14196 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 14197 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
14198 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
14199 (describe_map_tree):
14200 Rename locals to avoid shadowing.
38fc62d9 14201
2f2650da
PE
14202 * keyboard.c: Declare functions static if they are not used elsewhere.
14203 (echo_char, echo_dash, cmd_error, top_level_2):
14204 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
14205 (read_char, kbd_buffer_get_event, make_lispy_position):
14206 (make_lispy_event, make_lispy_movement, apply_modifiers):
14207 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
14208 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
14209 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 14210 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 14211 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 14212
a053e86c 14213 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
14214 (mark_kboards): Move decl here ...
14215 * alloc.c (mark_kboards): ... from here.
a053e86c 14216
4752793e
PE
14217 * lisp.h (force_auto_save_soon): New decl.
14218
74f10ca7 14219 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
14220 (DEFINE_DUMMY_FUNCTION): New macro.
14221 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
14222 Use it.
c03cd23f
PE
14223 (main): Add casts to avoid warnings
14224 if GCC considers string literals to be constants.
74f10ca7 14225
022e70d4
PE
14226 * lisp.h (fatal_error_signal): Add decl, since it's exported.
14227
59d6fe83
PE
14228 * dbusbind.c: Pointer signedness fixes.
14229 (xd_signature, xd_append_arg, xd_initialize):
14230 (Fdbus_call_method, Fdbus_call_method_asynchronously):
14231 (Fdbus_method_return_internal, Fdbus_method_error_internal):
14232 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
14233 (Fdbus_register_signal): Use SSDATA when the context wants char *.
14234
78320123
PE
14235 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
14236 if GCC considers string literals to be constants.
49cebcca 14237 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 14238
35ac2a97
SM
142392011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
14240
fb103ca9
SM
14241 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
14242 (print_preprocess, print_object): New macro to fix last change.
14243
35ac2a97
SM
14244 * print.c (print_preprocess): Don't forget font objects.
14245
62973b41
JB
142462011-03-16 Juanma Barranquero <lekktu@gmail.com>
14247
14248 * emacs.c (USAGE3): Doc fixes.
14249
0e48bb22
AS
142502011-03-15 Andreas Schwab <schwab@linux-m68k.org>
14251
14252 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
14253 structure.
14254
7684e57b
JB
142552011-03-14 Juanma Barranquero <lekktu@gmail.com>
14256
14257 * lisp.h (VWindow_system, Qfile_name_history):
14258 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
14259 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
14260 (w32_system_caret_x, w32_system_caret_y): Declare extern.
14261
14262 * w32select.c: Don't #include "keyboard.h".
c96bbc66 14263 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
14264
14265 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
14266 * w32console.c (detect_input_pending, read_input_pending)
14267 (encode_terminal_code):
14268 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
14269 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
14270 (w32_system_caret_y, Qfile_name_history):
14271 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
14272 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
14273 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
14274 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
14275 * w32proc.c (Qlocal, report_file_error):
14276 * w32term.c (Vwindow_system, updating_frame):
14277 * w32uniscribe.c (initialized, uniscribe_font_driver):
14278 Remove unneeded extern declarations.
14279
2aa46d6c
CY
142802011-03-14 Chong Yidong <cyd@stupidchicken.com>
14281
c96bbc66 14282 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 14283
cffc6f3b
CY
142842011-03-13 Chong Yidong <cyd@stupidchicken.com>
14285
14286 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
14287 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
14288 These macros can no longer be used for assignment.
14289
44f230aa
SM
14290 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
14291 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
14292 (record_buffer_markers, fetch_buffer_markers): New functions for
14293 recording and fetching special buffer markers.
14294 (set_buffer_internal_1, set_buffer_temp): Use them.
14295
14296 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
14297
14298 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
14299
14300 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
14301 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
14302
14303 * xdisp.c (hscroll_window_tree):
14304 (reconsider_clip_changes): Use PT instead of BUF_PT.
14305
d251f04b
EZ
143062011-03-13 Eli Zaretskii <eliz@gnu.org>
14307
14308 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
14309 $(EMACS_ROOT)/lib/intprops.h.
14310
f0c77cd1
PE
143112011-03-13 Paul Eggert <eggert@cs.ucla.edu>
14312
3eca4629
PE
14313 Fix more problems found by GCC 4.5.2's static checks.
14314
7c86ee98
PE
14315 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
14316 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
14317 (xg_free_frame_widgets): Make it clear that a local variable is
14318 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
14319 (gdk_window_get_screen): Make it clear that this macro is needed
14320 only if USE_GTK_TOOLTIP.
1e5524e7
PE
14321 (int_gtk_range_get_value): New function, which avoids a diagnostic
14322 from gcc -Wbad-function-cast.
14323 (xg_set_toolkit_scroll_bar_thumb): Use it.
14324 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
14325 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
14326 (get_utf8_string, xg_get_file_with_chooser):
14327 Rename locals to avoid shadowing.
14328 (create_dialog): Move locals to avoid shadowing.
7c86ee98 14329
41729b81
PE
14330 * xgselect.c (xg_select): Remove unused var.
14331
f0c77cd1
PE
14332 * image.c (four_corners_best): Mark locals as initialized.
14333 (gif_load): Initialize transparent_p to zero (Bug#8238).
14334 Mark another local as initialized.
ec6cf4c6 14335 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 14336
ce0ad53d 14337 * image.c (clear_image_cache): Now static.
d5d5a617 14338 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 14339 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
14340 (x_edge_detection): Remove unnecessary cast that
14341 gcc -Wbad-function-cast diagnoses.
2037898d 14342 (gif_load): Fix pointer signedness.
6ae141d6
PE
14343 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
14344 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 14345
33383987 143462011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 14347
d32df629
PE
14348 Improve quality of tests for time stamp overflow.
14349 For example, without this patch (encode-time 0 0 0 1 1
14350 1152921504606846976) returns the obviously-bogus value (-948597
14351 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
14352 reports time overflow. See
14353 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
14354 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
14355 * editfns.c: Include limits.h and intprops.h.
14356 (TIME_T_MIN, TIME_T_MAX): New macros.
14357 (time_overflow): Move earlier, to before first use.
14358 (hi_time, lo_time): New functions, for an accurate test for
14359 out-of-range times.
14360 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
14361 (Fget_internal_run_time): Don't assume time_t fits in int.
14362 (make_time): Use list2 instead of Fcons twice.
14363 (Fdecode_time): More accurate test for out-of-range times.
14364 (check_tm_member): New function.
14365 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
14366 (lisp_time_argument): Don't rely on undefined left-shift and
14367 right-shift behavior when checking for time stamp overflow.
8be6f318 14368
fe31d94c
PE
14369 * editfns.c (time_overflow): New function, refactoring common code.
14370 (Fformat_time_string, Fdecode_time, Fencode_time):
14371 (Fcurrent_time_string): Use it.
14372
8be6f318
PE
14373 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
14374 * dired.c (make_time): Move to ...
14375 * editfns.c (make_time): ... here.
14376 * systime.h: Note the move.
14377
09d9db2c 143782011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 14379
126bc0dc
YM
14380 * fringe.c (update_window_fringes): Remove unused variables.
14381
c47cbdfd
YM
14382 * unexmacosx.c (copy_data_segment): Also copy __got section.
14383 (Bug#8223)
14384
7ac80be9
EZ
143852011-03-12 Eli Zaretskii <eliz@gnu.org>
14386
c96bbc66 14387 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
14388 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
14389 Constify `char *' arguments and their references according to
14390 prototypes in tparam.h.
14391
ecb0f94d 14392 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 14393
7ac80be9
EZ
14394 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
14395 Adapt all references accordingly.
14396
14397 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
14398
ef1fd07e
TT
143992011-03-11 Tom Tromey <tromey@redhat.com>
14400
14401 * buffer.c (syms_of_buffer): Remove obsolete comment.
14402
7ef4b50c
EZ
144032011-03-11 Eli Zaretskii <eliz@gnu.org>
14404
14405 * termhooks.h (encode_terminal_code): Declare prototype.
14406
14407 * msdos.c (encode_terminal_code): Don't declare prototype.
14408
14409 * term.c (encode_terminal_code): Now external again, used by
14410 w32console.c and msdos.c.
14411
44f230aa
SM
14412 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
14413 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 14414
4b1ec863 144152011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 14416
1714f52b 14417 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 14418
4b1ec863
PE
14419 * fringe.c (update_window_fringes): Mark locals as initialized
14420 (Bug#8227).
14421 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 14422
524c7aa6
PE
14423 * alloc.c (mark_fringe_data): Move decl from here ...
14424 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
14425 to check its interface.
14426 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
14427
a5c0af81 14428 * fontset.c (free_realized_fontset): Now static.
7519b8cd 14429 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 14430 (fontset_font): Mark local as initialized.
a9a06e0b 14431 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 14432
b4716021
PE
14433 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
14434
811e9bac 14435 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 14436 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
14437 (x_own_selection, Fx_disown_selection_internal): Rename locals
14438 to avoid shadowing.
14439 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 14440
7e3ab302
PE
14441 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
14442 so that the caller can use some name other than gcpro1.
14443 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
14444 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14445 (Fx_backspace_delete_keys_p):
14446 Use them to avoid shadowing, and rename vars to avoid shadowing.
14447 (x_decode_color, x_set_name, x_window): Now static.
6b437900 14448 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 14449 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
14450 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
14451 Remove unused locals.
7e3ab302
PE
14452 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14453 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
14454 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
14455 macros.
f78faa98 14456
e2b13473
PE
14457 * xterm.h (x_mouse_leave): New decl.
14458
77f23912
PE
14459 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
14460 Remove unused functions.
cdf4ba58
PE
14461 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
14462 (x_calc_absolute_position): Now static.
7411c686 14463 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 14464 Don't declare local "event" unless it's used.
ed7bf3a5
PE
14465 (x_iconify_frame, x_free_frame_resources): Don't declare locals
14466 unless they are used.
38d0b34a
PE
14467 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
14468 (x_fatal_error_signal): Remove; not used.
a6067996
PE
14469 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
14470 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
14471 (x_error_catcher, x_connection_closed, x_error_handler):
14472 (x_error_quitter, xembed_send_message, x_iconify_frame):
14473 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 14474 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 14475 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 14476
44f230aa
SM
14477 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
14478 Rename or move locals to avoid shadowing.
6b463e58 14479 (tty_defined_color, merge_face_heights): Now static.
5967d051 14480 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
14481 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
14482 does not deduce is never used uninitialized.
73719eba
PE
14483 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
14484 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 14485
426994c3 14486 * terminal.c (store_terminal_param): Now static.
5489860b 14487
032f1620 14488 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 14489 (set_frame_menubar): Remove unused local.
d4323972 14490 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
14491 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
14492 since they might point to immutable storage.
281585b0
PE
14493 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
14494 since it's unused otherwise.
032f1620 14495
367c19e5 14496 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 14497 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
14498 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
14499 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 14500 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
14501 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
14502 does not deduce are never used uninitialized.
70739cbe 14503
07b48fa9
PE
14504 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
14505
8868a238 14506 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
14507 * window.c (window_loop, size_window):
14508 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 14509
7e5cf297 14510 * window.c (display_buffer): Now static.
d6550a9f
PE
14511 (size_window): Mark variables that gcc -Wuninitialized
14512 does not deduce are never used uninitialized.
a586633d
PE
14513 * window.h (check_all_windows): New decl, to forestall
14514 gcc -Wmissing-prototypes diagnostic.
5b555da1 14515 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 14516
f6095868
PE
14517 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
14518 shadowing.
14519 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
14520 Include <limits.h>.
14521 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
14522 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
14523 (load_charset_map): Mark variables that gcc -Wuninitialized
14524 does not deduce are never used uninitialized.
53df7c11 14525 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 14526
f38b440c
PE
14527 * coding.c (coding_set_source, coding_set_destination):
14528 Use "else { /* comment */ }" rather than "else /* comment */;"
14529 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
14530 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
14531 a block, when the outer 'i' will do.
14532 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
14533 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
14534 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
14535 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
14536 (Fdecode_sjis_char, Fdefine_coding_system_internal):
14537 Rename locals to avoid shadowing.
14538 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
14539 * coding.c (emacs_mule_char, encode_invocation_designation):
14540 Now static, since they're not used elsewhere.
413bb2db 14541 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 14542 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
14543 (decode_coding_emacs_mule): Mark variables that gcc
14544 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
14545 (detect_coding_iso_2022): Initialize a local variable that might
14546 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 14547 this initialization is needed. (Bug#8211)
5f58e762
PE
14548 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
14549 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
14550 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
14551 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
14552 Remove unused macros.
f38b440c 14553
232b38b9 14554 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 14555 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 14556 * character.c (string_count_byte8): Likewise.
232b38b9 14557
fb90da1b
PE
14558 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
14559 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
14560
fb93dbc2
PE
14561 * chartab.c (copy_sub_char_table): Now static, since it's not used
14562 elsewhere.
5c156ace
PE
14563 (sub_char_table_ref_and_range, char_table_ref_and_range):
14564 Rename locals to avoid shadowing.
bbcd0949 14565 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 14566
7d3b3862 14567 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 14568 (BIDI_BOB): Remove unused macro.
7d3b3862 14569
6be7d3da
PE
14570 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
14571 deduce are never used uninitialized.
c2ed9c8b 14572 * term.c (encode_terminal_code): Likewise.
6be7d3da 14573
75f8807f 14574 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 14575
50938595
PE
14576 * tparam.h: New file.
14577 * term.c, tparam.h: Include it.
14578 * deps.mk (term.o, tparam.o): Depend on tparam.h.
14579 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
14580 Move these decls to tparam.h, and make them agree with what
14581 is actually in tparam.c. The previous trick of using incompatible
14582 decls in different modules does not conform to the C standard.
14583 All callers of tparam changed to use tparam's actual API.
14584 * tparam.c (tparam1, tparam, tgoto):
14585 Use const pointers where appropriate.
14586
fbceeba2
PE
14587 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
14588 * cm.h (struct cm): Likewise.
14589 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
14590 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
14591 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
14592 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
14593 (turn_on_face, init_tty): Likewise.
14594 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 14595
7f3f1250
PE
14596 * term.c (term_mouse_position): Rename local to avoid shadowing.
14597
e6ca6543
PE
14598 * alloc.c (mark_ttys): Move decl from here ...
14599 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
14600
c40f8d15
AS
146012011-03-11 Andreas Schwab <schwab@linux-m68k.org>
14602
14603 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
14604
cfe0661d
JB
146052011-03-09 Juanma Barranquero <lekktu@gmail.com>
14606
14607 * search.c (compile_pattern_1): Remove argument regp, unused since
14608 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
14609 (compile_pattern): Don't pass it.
14610
0afb4571
J
146112011-03-08 Jan Djärv <jan.h.d@swipnet.se>
14612
14613 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
14614 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
14615 for ! HAVE_GTK3.
14616 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
14617
14618 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
14619
14620 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
14621 gdk_window_get_screen, gdk_window_get_geometry,
14622 gdk_x11_window_lookup_for_display and GDK_KEY_g.
14623 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
14624 (xg_get_pixbuf_from_pixmap): New function.
14625 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
14626 to Pixmap, take frame as parameter, remove GdkColormap parameter.
14627 Call xg_get_pixbuf_from_pixmap instead of
14628 gdk_pixbuf_get_from_drawable.
14629 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
14630 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
14631 (xg_check_special_colors): Use GtkStyleContext and its functions
14632 for HAVE_GTK3.
14633 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
14634 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
14635 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
14636 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
14637 Call gtk_widget_get_preferred_size.
0afb4571
J
14638 (xg_frame_resized): gdk_window_get_geometry only takes 5
14639 parameters.
44f230aa
SM
14640 (xg_win_to_widget, xg_event_is_for_menubar):
14641 Call gdk_x11_window_lookup_for_display.
0afb4571
J
14642 (xg_set_widget_bg): New function.
14643 (delete_cb): New function.
895009e1 14644 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 14645 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
14646 (xg_set_background_color): Call xg_set_widget_bg.
14647 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
14648 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
14649 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
14650 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
14651 if ! HAVE_GTK3.
14652 (update_frame_tool_bar): Call gtk_widget_hide.
14653 (xg_initialize): Use GDK_KEY_g.
14654
14655 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
14656 if ! HAVE_GTK3
14657 (x_session_initialize): Call gdk_x11_set_sm_client_id.
14658
14659 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
14660 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
14661 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
14662
1c2cc4ef
JB
146632011-03-08 Juanma Barranquero <lekktu@gmail.com>
14664
14665 * w32xfns.c (select_palette): Check success of RealizePalette against
14666 GDI_ERROR, not zero.
14667
33383987 14668See ChangeLog.11 for earlier changes.
aac0c6e3
MR
14669
14670;; Local Variables:
14671;; coding: utf-8
aac0c6e3
MR
14672;; End:
14673
2f097256 14674 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
14675
14676 This file is part of GNU Emacs.
14677
14678 GNU Emacs is free software: you can redistribute it and/or modify
14679 it under the terms of the GNU General Public License as published by
14680 the Free Software Foundation, either version 3 of the License, or
14681 (at your option) any later version.
14682
14683 GNU Emacs is distributed in the hope that it will be useful,
14684 but WITHOUT ANY WARRANTY; without even the implied warranty of
14685 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14686 GNU General Public License for more details.
14687
14688 You should have received a copy of the GNU General Public License
14689 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.