Move/add window-buffer-related functions to window.el.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
9397e56f
MR
12011-06-11 Martin Rudalics <rudalics@gmx.at>
2
3 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4 Qclone_number. Remove external declaration of Qdelete_window.
5 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
6 code.
7 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
8 Qbuffer_list_update_hook if allowed.
9 (Fother_buffer): Rewrite doc-string. Major rewrite for new
10 buffer list implementation.
11 (other_buffer_safely): New function.
12 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
13 calls to replace_buffer_in_windows and
14 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
15 if allowed.
16 (record_buffer): Inhibit quitting and rewrite using quittable
17 functions. Run Qbuffer_list_update_hook if allowed.
18 (Frecord_buffer, Funrecord_buffer): New functions.
19 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
20 switch-to-buffer to window.el.
21 (bury-buffer): Move to window.el.
22 (Vbuffer_list_update_hook): New variable.
23
24 * lisp.h (other_buffer_safely): Add prototype in buffer.c
25 section.
26
27 * window.h (resize_frame_windows): Move up in code.
28 (Fwindow_frame): Remove EXFUN.
29 (replace_buffer_in_all_windows): Remove prototype.
30 (replace_buffer_in_windows_safely): Add prototype.
31
32 * window.c: Declare Qdelete_window static again. Move down
33 declaration of select_count.
34 (Fnext_window, Fprevious_window): Rewrite doc-strings.
35 (Fother_window): Move to window.el.
36 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
37 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
38 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
39 window.el.
40 (replace_buffer_in_windows): Implement by calling
41 Qreplace_buffer_in_windows.
42 (replace_buffer_in_all_windows): Remove with some functionality
43 moved into replace_buffer_in_windows_safely.
44 (replace_buffer_in_windows_safely): New function.
45 (select_window_norecord, select_frame_norecord): Move in front
46 of run_window_configuration_change_hook. Remove now obsolete
47 declarations.
48 (Fset_window_buffer): Rewrite doc-string. Call
49 Qrecord_window_buffer.
50 (keys_of_window): Move binding for other-window to window.el.
51
b50691aa
CY
522011-06-11 Chong Yidong <cyd@stupidchicken.com>
53
54 * dispextern.h (struct image): Replace data member, whose int_val
55 and ptr_val fields were not used by anything, with a single
56 lisp_val object.
57
58 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
59 (gif_clear_image, gif_load, imagemagick_load_image)
60 (gs_clear_image, gs_load): Callers changed.
61
3f754b86
PE
622011-06-10 Paul Eggert <eggert@cs.ucla.edu>
63
cca69397
PE
64 * buffer.h: Include <time.h>, for time_t.
65 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
66
109e28d0
PE
67 Fix minor problems found by static checking.
68
60737f02
PE
69 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
70
4b66faf3
PE
71 Make identifiers static if they are not used in other modules.
72 * data.c (Qcompiled_function, Qframe, Qvector):
73 * image.c (QimageMagick, Qsvg):
74 * minibuf.c (Qmetadata):
75 * window.c (resize_window_check, resize_root_window): Now static.
76 * window.h (resize_window_check, resize_root_window): Remove decls.
77
109e28d0
PE
78 * window.c (window_deletion_count, delete_deletable_window):
79 Remove; unused.
46a4ce9e
PE
80 (window_body_lines): Now static.
81 (Fdelete_other_windows_internal): Mark vars as initialized.
82 Make sure 'resize_failed' is initialized.
83 (run_window_configuration_change_hook): Rename local to avoid shadowing.
84 (resize_window_apply): Remove unused local.
85 * window.h (delete_deletable_window): Remove decl.
86
109e28d0 87 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
88 (imagemagick_load_image): Fix pointer signedness problem by changing
89 last arg from unsigned char * to char *. All uses changed.
90 Also, fix a local for similar reasons.
91 Remove unused locals. Remove locals to avoid shadowing.
92 (fn_rsvg_handle_free): Remove; unused.
93 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 94 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 95
3f754b86
PE
96 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
97
2547adb1
CY
982011-06-10 Chong Yidong <cyd@stupidchicken.com>
99
100 * image.c (gif_load): Fix omitted cast error introduced by
101 2011-06-06 change.
102
2c8e37d4
MR
1032011-06-10 Martin Rudalics <rudalics@gmx.at>
104
105 * window.h (resize_proportionally, orig_total_lines)
106 (orig_top_line): Remove from window structure.
107 (set_window_height, set_window_width, change_window_heights)
108 (Fdelete_window): Remove prototypes.
109 (resize_frame_windows): Remove duplicate declaration.
110
440a42e3
EZ
1112011-06-10 Eli Zaretskii <eliz@gnu.org>
112
113 * window.h (resize_frame_windows, resize_window_check)
114 (delete_deletable_window, resize_root_window)
115 (resize_frame_windows): Declare prototypes.
116
117 * window.c (resize_window_apply): Make definition be "static" to
118 match the prototype.
119
562dd5e9
MR
1202011-06-10 Martin Rudalics <rudalics@gmx.at>
121
122 * window.c: Remove declarations of Qwindow_size_fixed,
123 window_min_size_1, window_min_size_2, window_min_size,
124 size_window, window_fixed_size_p, enlarge_window, delete_window.
125 Remove static from declaration of Qdelete_window, it's
126 temporarily needed by Fbury_buffer.
127 (replace_window): Don't assign orig_top_line and
128 orig_total_lines.
129 (Fdelete_window, delete_window): Remove. Window deletion is
130 handled by window.el.
131 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
132 Fdelete_window calls with calls to Qdelete_window.
133 (Fdelete_other_windows): Remove. Deleting other windows is
134 handled by window.el.
135 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
136 handled in window.el.
137 (window_min_size_2, window_min_size_1, window_min_size): Remove.
138 Window minimum sizes are handled in window.el.
139 (shrink_windows, size_window, set_window_height)
140 (set_window_width, change_window_heights, window_height)
141 (window_width, CURBEG, CURSIZE, enlarge_window)
142 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
143 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
144 handled in window.el.
145 (make_dummy_parent): Rename to make_parent_window and give it a
146 second argument horflag.
147 (make_window): Don't set resize_proportionally any more.
148 (Fsplit_window): Remove. Windows are split in window.el.
149 (save_restore_action, save_restore_orig_size)
150 (shrink_window_lowest_first, save_restore_orig_size): Remove.
151 Resize mini windows in window.el.
152 (grow_mini_window, shrink_mini_window): Implement by calling
153 Qresize_root_window_vertically, resize_window_check and
154 resize_window_apply.
155 (saved_window, Fset_window_configuration, save_window_save): Do
156 not handle orig_top_line, orig_total_lines, and
157 resize_proportionally.
158 (window_min_height, window_min_width): Move to window.el.
159 (keys_of_window): Move bindings for delete-other-windows,
160 split-window, delete-window and enlarge-window to window.el.
161
162 * buffer.c: Temporarily extern Qdelete_window.
163 (Fbury_buffer): Temporarily call Qdelete_window instead of
164 Fdelete_window (Fbury_buffer will move to window.el soon).
165
166 * frame.c (set_menu_bar_lines_1): Remove code handling
167 orig_top_line and orig_total_lines.
168
169 * dispnew.c (adjust_frame_glyphs_initially): Don't use
170 set_window_height but set heights directly.
171 (change_frame_size_1): Use resize_frame_windows.
172
173 * xdisp.c (init_xdisp): Don't use set_window_height but set
174 heights directly.
175
176 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
177 resize_frame_windows instead of change_window_heights and run
178 run_window_configuration_change_hook.
179
180 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
181 instead of change_window_heights and run
182 run_window_configuration_change_hook.
183
1a13852e
MR
1842011-06-09 Martin Rudalics <rudalics@gmx.at>
185
186 * window.c (replace_window): Rename second argument REPLACEMENT to
187 NEW. New third argument SETFLAG. Rewrite.
188 (delete_window, make_dummy_parent): Call replace_window with
189 third argument 1.
190 (window_list_1): Move down in code.
191 (run_window_configuration_change_hook): Move set_buffer part
192 before select_frame_norecord part in order to unwind correctly.
193 Rename count1 to count.
194 (recombine_windows, delete_deletable_window, resize_root_window)
195 (Fdelete_other_windows_internal)
196 (Frun_window_configuration_change_hook, make_parent_window)
197 (resize_window_check, resize_window_apply, Fresize_window_apply)
198 (resize_frame_windows, Fsplit_window_internal)
199 (Fdelete_window_internal, Fresize_mini_window_internal): New
200 functions.
201 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
202
f3d1777e
MR
2032011-06-08 Martin Rudalics <rudalics@gmx.at>
204
496e208e
MR
205 * window.h (window): Add some new members to window structure -
206 normal_lines, normal_cols, new_total, new_normal, clone_number,
207 splits, nest, prev_buffers, next_buffers.
208 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 209 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 210
f3d1777e
MR
211 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
212 Remove.
496e208e
MR
213 (make_dummy_parent): Set new members of windows structure.
214 (make_window): Move down in code. Handle new members of window
215 structure.
216 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
217 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
218 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
219 (Fset_window_prev_buffers, Fwindow_next_buffers)
220 (Fset_window_next_buffers, Fset_window_clone_number): New
221 functions.
222 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
223 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
224 Doc-string fixes.
225 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
226 Argument WINDOW can be now internal window too.
227 (Fwindow_use_time): Move up in code.
228 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
229 Rewrite doc-string.
230 (Fset_window_configuration, saved_window)
231 (Fcurrent_window_configuration, save_window_save): Handle new
232 members of window structure.
b9e809c2
MR
233 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
234 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
235 (syms_of_window): New Lisp objects Qrecord_window_buffer,
236 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
237 Qget_mru_window, Qresize_root_window,
238 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
239 Qauto_buffer_name; staticpro them.
f3d1777e 240
abde8f8c
MR
2412011-06-07 Martin Rudalics <rudalics@gmx.at>
242
243 * window.c (Fwindow_total_size, Fwindow_left_column)
244 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
245 (Fwindow_list_1): New functions.
246 (window_box_text_cols): Replace with window_body_cols.
247 (Fwindow_width, Fscroll_left, Fscroll_right): Use
248 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
249 (delete_window, Fset_window_configuration): Call
250 delete_all_subwindows with window as argument.
251 (delete_all_subwindows): Take a window as argument and not a
252 structure. Rewrite.
190b47e6
MR
253 (window_loop): Remove handling of GET_LRU_WINDOW and
254 GET_LARGEST_WINDOW.
255 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
256
257 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
258 window_box_text_cols. delete_all_subwindows now takes a
259 Lisp_Object as argument.
abde8f8c
MR
260
261 * indent.c (compute_motion, Fcompute_motion): Use
262 window_body_cols instead of window_box_text_cols.
263
fa8a67e6
MR
264 * frame.c (delete_frame): Call delete_all_subwindows with root
265 window as argument.
266
a54e3482
DC
2672011-06-07 Daniel Colascione <dan.colascione@gmail.com>
268
269 * fns.c (Fputhash): Document return value.
270
60002bf5
CY
2712011-06-06 Chong Yidong <cyd@stupidchicken.com>
272
273 * image.c (gif_load): Implement gif89a spec "no disposal" method.
274
0c671da6 2752011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 276
b862a52a 277 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 278
be44ca6c
PE
279 Check for overflow when converting integer to cons and back.
280 * charset.c (Fdefine_charset_internal, Fdecode_char):
281 Use cons_to_unsigned to catch overflow.
282 (Fencode_char): Use INTEGER_TO_CONS.
283 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
284 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
285 * data.c (long_to_cons, cons_to_long): Remove.
286 (cons_to_unsigned, cons_to_signed): New functions.
287 These signal an error for invalid or out-of-range values.
288 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
289 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
290 * font.c (Ffont_variation_glyphs):
291 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
292 * lisp.h: Include <intprops.h>.
293 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
294 (cons_to_signed, cons_to_unsigned): New decls.
295 (long_to_cons, cons_to_long): Remove decls.
296 * undo.c (record_first_change): Use INTEGER_TO_CONS.
297 (Fprimitive_undo): Use CONS_TO_INTEGER.
298 * xfns.c (Fx_window_property): Likewise.
299 * xselect.c: Include <limits.h>.
300 (x_own_selection, selection_data_to_lisp_data):
301 Use INTEGER_TO_CONS.
302 (x_handle_selection_request, x_handle_selection_clear)
303 (x_get_foreign_selection, Fx_disown_selection_internal)
304 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
305 (lisp_data_to_selection_data): Use cons_to_unsigned.
306 (x_fill_property_data): Use cons_to_signed.
307 Report values out of range.
308
d1f3d2af
PE
309 Check for buffer and string overflow more precisely.
310 * buffer.h (BUF_BYTES_MAX): New macro.
311 * lisp.h (STRING_BYTES_MAX): New macro.
312 * alloc.c (Fmake_string):
313 * character.c (string_escape_byte8):
314 * coding.c (coding_alloc_by_realloc):
315 * doprnt.c (doprnt):
316 * editfns.c (Fformat):
317 * eval.c (verror):
318 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
319 since they may not be the same number.
320 * editfns.c (Finsert_char):
321 * fileio.c (Finsert_file_contents):
322 Likewise for BUF_BYTES_MAX.
323
dd52fcea
PE
324 * image.c: Use ptrdiff_t, not int, for sizes.
325 (slurp_file): Switch from int to ptrdiff_t.
326 All uses changed.
327 (slurp_file): Check that file size fits in both size_t (for
328 malloc) and ptrdiff_t (for sanity and safety).
329
7f9bbdbb
PE
330 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
331 if b->modtime has its maximal value.
332
dfe18f82
PE
333 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
334
84acfcf0
PE
335 Don't assume time_t can fit into int.
336 * buffer.h (struct buffer.modtime): Now time_t, not int.
337 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
338 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
339
ccd9a01a
PE
340 Minor fixes for signed vs unsigned integers.
341 * character.h (MAYBE_UNIFY_CHAR):
342 * charset.c (maybe_unify_char):
343 * keyboard.c (read_char, reorder_modifiers):
344 XINT -> XFASTINT, since the integer must be nonnegative.
345 * ftfont.c (ftfont_spec_pattern):
346 * keymap.c (access_keymap, silly_event_symbol_error):
347 XUINT -> XFASTINT, since the integer must be nonnegative.
348 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
349 since it makes no difference and we prefer signed.
350 * keyboard.c (record_char): Use XUINT when all the neighbors do.
351 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
352 nonnegative.
353
d6d100dd
SM
3542011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
355
356 * window.h (Fwindow_frame): Declare.
357
2b6148e4
PE
3582011-06-06 Paul Eggert <eggert@cs.ucla.edu>
359
360 * alloc.c: Simplify handling of large-request failures (Bug#8800).
361 (SPARE_MEMORY): Always define.
362 (LARGE_REQUEST): Remove.
363 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
364
f230ecc9
MR
3652011-06-06 Martin Rudalics <rudalics@gmx.at>
366
727e958e
MR
367 * lisp.h: Move EXFUNS for Fframe_root_window,
368 Fframe_first_window and Fset_frame_selected_window to window.h.
369
370 * window.h: Move EXFUNS for Fframe_root_window,
371 Fframe_first_window and Fset_frame_selected_window here from
372 lisp.h.
373
374 * frame.c (Fwindow_frame, Fframe_first_window)
375 (Fframe_root_window, Fframe_selected_window)
376 (Fset_frame_selected_window): Move to window.c.
377 (Factive_minibuffer_window): Move to minibuf.c.
378 (Fother_visible_frames_p): New function.
379
380 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
381
f230ecc9
MR
382 * window.c (decode_window, decode_any_window): Move up in code.
383 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
384 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
385 (Fwindow_buffer): Move up and rewrite doc-string.
386 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
387 (Fwindow_prev): New functions.
727e958e
MR
388 (Fwindow_frame): Move here from frame.c. Accept any window as
389 argument.
390 (Fframe_root_window, Fframe_first_window)
391 (Fframe_selected_window): Move here from frame.c. Accept frame
392 or arbitrary window as argument. Update doc-strings.
393 (Fminibuffer_window): Move up in code.
394 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
395 (Fset_frame_selected_window): Move here from frame.c.
396 Marginal rewrite.
727e958e
MR
397 (Fselected_window, select_window, Fselect_window): Move up in
398 code. Minor doc-string fixes.
f230ecc9 399
4d09bcf6
PE
4002011-06-06 Paul Eggert <eggert@cs.ucla.edu>
401
402 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
403 Do not assume that spare memory exists; that assumption is valid
404 only if SYSTEM_MALLOC.
405 (LARGE_REQUEST): New macro, so that the issue of large requests
406 is separated from the issue of spare memory.
407
810928a2
AS
4082011-06-05 Andreas Schwab <schwab@linux-m68k.org>
409
172418ad
AS
410 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
411 format. (Bug#8806)
412
43f862f7
AS
413 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
414
810928a2
AS
415 * xfns.c (x_set_scroll_bar_default_width): Move declarations
416 before statements.
417
a059fe24
JD
4182011-06-05 Jan Djärv <jan.h.d@swipnet.se>
419
420 * gtkutil.c (xg_get_default_scrollbar_width): New function.
421
422 * gtkutil.h: Declare xg_get_default_scrollbar_width.
423
424 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
425 min width by calling x_set_scroll_bar_default_width (Bug#8505).
426
989bf368
JB
4272011-06-05 Juanma Barranquero <lekktu@gmail.com>
428
429 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
430
4b80f674
CY
4312011-06-04 Chong Yidong <cyd@stupidchicken.com>
432
433 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
434 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
435 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
436 New error handlers.
4b80f674
CY
437 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
438 Obey Vx_select_enable_clipboard_manager. Catch errors in
439 x_clipboard_manager_save (Bug#8779).
440 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 441 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 442
99a33b77 4432011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
444
445 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
446
99a33b77 4472011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
448
449 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
450 in the current matrix if keep_current_p is non-zero.
451
8264569d
EZ
4522011-06-04 Eli Zaretskii <eliz@gnu.org>
453
454 * bidi.c (bidi_level_of_next_char): Fix last change.
455
57f97249
EZ
4562011-06-03 Eli Zaretskii <eliz@gnu.org>
457
fec2107c 458 Support bidi reordering of text covered by display properties.
57f97249 459
fec2107c
EZ
460 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
461 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
462 (bidi_cache_search, bidi_cache_iterator_state)
463 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
464 (bidi_level_of_next_char, bidi_move_to_visually_next):
465 Support character positions inside a run of characters covered by a
fec2107c
EZ
466 display string.
467 (bidi_paragraph_init, bidi_resolve_explicit_1)
468 (bidi_level_of_next_char): Call bidi_fetch_char and
469 bidi_fetch_char_advance instead of FETCH_CHAR and
470 FETCH_CHAR_ADVANCE.
471 (bidi_init_it): Initialize new members.
472 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
473 definitions.
474 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
475 instead of using explicit *_CHAR codes.
d6d100dd
SM
476 (bidi_resolve_explicit, bidi_resolve_weak):
477 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
478 bidirectional text is supported only in multibyte buffers.
479 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
480 it to initialize the frame_window_p member of struct bidi_it.
481 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
482 (bidi_resolve_explicit, bidi_resolve_weak)
483 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
484 bidi_it->nchars is non-positive.
485 (bidi_level_of_next_char): Don't try to lookup the cache for the
486 next/previous character if nothing is cached there yet, or if we
487 were just reseat()'ed to a new position.
c40e2fb2 488
0e14fe90
EZ
489 * xdisp.c (set_cursor_from_row): Set start and stop points
490 according to the row's direction when priming the loop that looks
491 for the glyph on which to display cursor.
492 (single_display_spec_intangible_p): Function deleted.
493 (display_prop_intangible_p): Reimplement to call
494 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
495 Accept 3 additional arguments needed by handle_display_spec.
496 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
497 values: lists, `(when COND...)' forms, etc.
498 (single_display_spec_string_p): Support property values that are
499 lists with the argument STRING its top-level element.
500 (display_prop_string_p): Fix the condition for processing a
501 property that is a list to be consistent with handle_display_spec.
fec2107c 502 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
503 last portion of handle_display_prop.
504 (compute_display_string_pos): Accept additional argument
505 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
506 value of a `display' property is a "replacing spec".
507 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
508 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
509 the display property, but just return a value indicating whether
510 the display property will replace the characters it covers.
511 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
512 frame_window_p members of struct bidi_it.
d6d100dd
SM
513 (compute_display_string_pos, compute_display_string_end):
514 New functions.
fec2107c
EZ
515 (push_it): Accept second argument POSITION, where pop_it should
516 jump to continue iteration.
517 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 518
fec2107c
EZ
519 * keyboard.c (adjust_point_for_property): Adjust the call to
520 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
521
522 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
523 (bidi_init_it): Update prototypes.
524 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
525 (compute_display_string_pos, compute_display_string_end):
526 Declare prototypes.
fec2107c
EZ
527 (struct bidi_it): New members nchars and disp_pos. ch_len is now
528 EMACS_INT.
fc6f18ce 529
40087514 5302011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 531
57f53182
PE
532 Malloc failure behavior now depends on size of allocation.
533 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
534 * lisp.h: Change signatures accordingly.
535 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
536 All callers changed. (Bug#8762)
537
538 * gnutls.c: Use Emacs's memory allocators.
539 Without this change, the gnutls library would invoke malloc etc.
540 directly, which causes problems on non-SYNC_INPUT hosts, and which
541 runs afoul of improving memory_full behavior. (Bug#8761)
542 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
543 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
544 xfree instead of the default malloc, realloc, free.
545 (Fgnutls_boot): No need to check for memory allocation failure,
546 since xmalloc does that for us.
547
ac32cd99 548 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
549 * category.c (hash_get_category_set):
550 * ccl.c (ccl_driver):
551 * charset.c (Fdefine_charset_internal):
552 * charset.h (struct charset.hash_index):
553 * composite.c (get_composition_id, gstring_lookup_cache)
554 (composition_gstring_put_cache):
555 * composite.h (struct composition.hash_index):
556 * dispextern.h (struct image.hash):
557 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
558 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
559 (hashfn_equal, hashfn_user_defined, make_hash_table)
560 (maybe_resize_hash_table, hash_lookup, hash_put)
561 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
562 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
563 (Fsxhash, Fgethash, Fputhash, Fmaphash):
564 * image.c (make_image, search_image_cache, lookup_image)
565 (xpm_put_color_table_h):
566 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 567 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
568 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
569 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
570 * alloc.c (allocate_vectorlike):
571 Check for overflow in vector size calculations.
572 * ccl.c (ccl_driver):
573 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
574 * fns.c, image.c: Remove unnecessary static decls that would otherwise
575 need to be updated by these changes.
40087514
PE
576 * fns.c (make_hash_table, maybe_resize_hash_table):
577 Check for integer overflow with large hash tables.
0de4bb68
PE
578 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
579 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
580 (SXHASH_REDUCE): New macro.
581 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
582 Use it instead of discarding useful hash info with large hash values.
583 (sxhash_float): New function.
584 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
585 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
586 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
587 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
588 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
589 Adjust signatures to match updated version of code.
590 (consing_since_gc): Now EMACS_INT, since a single hash table can
591 use more than INT_MAX bytes.
592
698d32e2
DN
5932011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
594
595 Make it possible to build with GCC-4.6+ -O2 -flto.
596
597 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
598
fd6fa53f
SM
5992011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
600
601 * minibuf.c (get_minibuffer, read_minibuf_unwind):
602 Call minibuffer-inactive-mode.
603
864db017
JB
6042011-05-31 Juanma Barranquero <lekktu@gmail.com>
605
606 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
607 Update dependencies.
608
2ad0baf4
DN
6092011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
610
611 * data.c (init_data): Remove code for UTS, this system is not
612 supported anymore.
613
4fcc2638
DN
6142011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
615
616 Don't force ./temacs to start in terminal mode.
617
618 * frame.c (make_initial_frame): Initialize faces in all cases, not
619 only when CANNOT_DUMP is defined.
620 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
621
c56e0fd5
DN
6222011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
623
624 * dispnew.c (add_window_display_history): Use const for the string
625 pointer. Remove declaration, not needed.
626
333d54da 6272011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 628
55d4c1b2 629 Use 'inline', not 'INLINE'.
333d54da 630 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
631 * alloc.c, fontset.c (INLINE): Remove.
632 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
633 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
634 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
635 * gmalloc.c (register_heapinfo): Use inline unconditionally.
636 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
637
738db178
DN
6382011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
639
640 Make it possible to run ./temacs.
641
642 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
643 syms_of_callproc does the same thing. Remove test for
644 "initialized", do it in the caller.
645 * emacs.c (main): Avoid calling set_initial_environment when dumping.
646
620c53a6
SM
6472011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
648
649 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
650 (read_minibuf): Use get_minibuffer.
651 (syms_of_minibuf): Use DEFSYM.
652 (Qmetadata): New var.
653 * data.c (Qbuffer): Don't make it static.
654 (syms_of_data): Use DEFSYM.
655
e003a292
PE
6562011-05-31 Paul Eggert <eggert@cs.ucla.edu>
657
658 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
659 (CCL_CODE_MIN): New macro.
660
ed008a6d
PE
6612011-05-30 Paul Eggert <eggert@cs.ucla.edu>
662
3687c2ef
PE
663 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
664
ed008a6d
PE
665 * eval.c (Qdebug): Now static.
666 * lisp.h (Qdebug): Remove decl. This reverts a part of the
667 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
668 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
669
d66c4c7c
CY
6702011-05-29 Chong Yidong <cyd@stupidchicken.com>
671
672 * image.c: Various fixes to ImageMagick code comments.
673 (Fimagemagick_types): Doc fix.
674
5fbc2025
PE
6752011-05-29 Paul Eggert <eggert@cs.ucla.edu>
676
0196f88a
PE
677 Minor fixes prompted by GCC 4.6.0 warnings.
678
679 * xselect.c (converted_selections, conversion_fail_tag): Now static.
680
5fbc2025
PE
681 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
682 (x_clipboard_manager_save_all): Move extern decl to ...
683 * xterm.h: ... here, so that it can be checked for consistency.
684
1dd3c2d9
CY
6852011-05-29 Chong Yidong <cyd@stupidchicken.com>
686
687 * xselect.c (x_clipboard_manager_save_frame)
688 (x_clipboard_manager_save_all): New functions.
689 (Fx_clipboard_manager_save): Lisp function deleted.
690
691 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
692 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
693
694 * xterm.h: Update prototype.
695
5ba6571d
WX
6962011-05-28 William Xu <william.xwl@gmail.com>
697
698 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
699 exiting (Bug#8239).
700
3eaff834
JM
7012011-05-28 Jim Meyering <meyering@redhat.com>
702
e1900994 703 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
704 * fns.c (to_uchar): Define.
705 (crypto_hash_function): Use it to convert some newly-signed
706 variables to unsigned, to avoid sign-extension bugs. For example,
707 without this change, (md5 "truc") would evaluate to
708 45723a2aff78ff4fff7fff1114760e62 rather than the expected
709 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 710 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 711
0f6990a7
PE
7122011-05-27 Paul Eggert <eggert@cs.ucla.edu>
713
714 Integer overflow fixes.
c8a9ca5a 715
08686060
PE
716 * dbusbind.c: Serial number integer overflow fixes.
717 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
718 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
719 to hold a serial number that is too large for a fixnum.
720 (Fdbus_method_return_internal, Fdbus_method_error_internal):
721 Check for serial numbers out of range. Decode any serial number
59568bf0 722 that was so large that it became a float. (Bug#8722)
08686060 723
2d1fc3c7
PE
724 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
725 (Fdbus_call_method, Fdbus_call_method_asynchronously):
726 Use XFASTINT rather than XUINT when numbers are nonnegative.
727 (xd_append_arg, Fdbus_method_return_internal):
728 (Fdbus_method_error_internal): Likewise. Also, for unsigned
729 arguments, check that Lisp number is nonnegative, rather than
59568bf0 730 silently wrapping negative numbers around. (Bug#8722)
30217ff0 731 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 732 (Bug#8722)
2d1fc3c7 733
c8a9ca5a
PE
734 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
735
519e1d69
PE
736 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
737
30569699
PE
738 ccl: add integer overflow checks
739 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
740 (IN_INT_RANGE): New macros.
741 (ccl_driver): Use them to check for integer overflow when
742 decoding a CCL program. Many of the new checks are whether XINT (x)
743 fits in int; it doesn't always, on 64-bit hosts. The new version
744 doesn't catch all possible integer overflows, but it's an
847044ea 745 improvement. (Bug#8719)
30569699 746
c11285dc
PE
747 * alloc.c (make_event_array): Use XINT, not XUINT.
748 There's no need for unsigned here.
749
fdccd48e
PE
750 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
751 This follows up to the 2011-05-06 change that substituted uintptr_t
752 for EMACS_INT. This case wasn't caught back then.
753
37910ab2
PE
754 Rework Fformat to avoid integer overflow issues.
755 * editfns.c: Include <float.h> unconditionally, as it's everywhere
756 now (part of C89). Include <verify.h>.
757 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
758 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
759 (Fformat): Avoid the prepass trying to compute sizes; it was only
760 approximate and thus did not catch overflow reliably. Instead, walk
761 through the format just once, formatting and computing sizes as we go,
762 checking for integer overflow at every step, and allocating a larger
763 buffer as needed. Keep track separately whether the format is
764 multibyte. Keep only the most-recently calculated precision, rather
765 than them all. Record whether each argument has been converted to
766 string. Use EMACS_INT, not int, for byte and char and arg counts.
767 Support field widths and precisions larger than INT_MAX. Avoid
768 sprintf's undefined behavior with conversion specifications such as %#d
769 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
770 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
771 formatting out-of-range floating point numbers with int
772 formats. (Bug#8668)
773
2e6578fb
PE
774 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
775
0ae6bdee
PE
776 * data.c: Avoid integer truncation in expressions involving floats.
777 * data.c: Include <intprops.h>.
778 (arith_driver): When there's an integer overflow in an expression
779 involving floating point, convert the integers to floating point
780 so that the resulting value does not suffer from catastrophic
781 integer truncation. For example, on a 64-bit host (* 4
782 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
783 Do not rely on undefined behavior after integer overflow.
784
de883a70
PE
785 merge count_size_as_multibyte, parse_str_to_multibyte
786 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 787 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
788 Check for integer overflow.
789 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
790 since it's now a duplicate of the other. This is more of
791 a character than a buffer op, so better that it's in character.c.
792 * fns.c, print.c: Adjust to above changes.
793
2ff916cb
PE
7942011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
795
796 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
797
f1b54466
PE
7982011-05-27 Paul Eggert <eggert@cs.ucla.edu>
799
fb1ac845
PE
800 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
801 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
802 (x_clipboard_manager_save): Now static.
803 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
804
f1b54466
PE
805 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
806 (crypto_hash_function): Now static.
807 Fix pointer signedness problems. Avoid unnecessary initializations.
808
a9f737ee
CY
8092011-05-27 Chong Yidong <cyd@stupidchicken.com>
810
811 * termhooks.h (Vselection_alist): Make it terminal-local.
812
813 * terminal.c (create_terminal): Initialize it.
814
815 * xselect.c: Support for clipboard managers.
816 (Vselection_alist): Move to termhooks.h as terminal-local var.
817 (LOCAL_SELECTION): New macro.
818 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
819 (symbol_to_x_atom): Remove gratuitous arg.
820 (x_handle_selection_request, lisp_data_to_selection_data)
821 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
822 (x_own_selection, x_get_local_selection, x_convert_selection):
823 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
824 (some_frame_on_display): Delete unused function.
825 (Fx_own_selection_internal, Fx_get_selection_internal)
826 (Fx_disown_selection_internal, Fx_selection_owner_p)
827 (Fx_selection_exists_p): New optional frame arg.
828 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
829 (x_handle_selection_clear): Don't treat other terminals with the
830 same keyboard specially. Use the terminal-local Vselection_alist.
831 (x_clear_frame_selections): Use Frun_hook_with_args.
832
833 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
834
835 * xterm.h: Add support for those atoms.
836
e067f0c1
CY
8372011-05-26 Chong Yidong <cyd@stupidchicken.com>
838
839 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
840 (converted_selections, conversion_fail_tag): New global variables.
841 (x_selection_request_lisp_error): Free the above.
842 (x_get_local_selection): Remove unnecessary code.
843 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
844 of converted selections stored in converted_selections.
845 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
846 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
847 (x_convert_selection): New function.
848 (x_handle_selection_event): Simplify.
849 (x_get_foreign_selection): Don't ignore incoming requests while
850 waiting for an answer; this will fail when we implement
851 SAVE_TARGETS, and seems unnecessary anyway.
852 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
853 (Vx_sent_selection_functions): Doc fix.
854
0f4aebc0
LL
8552011-05-26 Leo Liu <sdl.web@gmail.com>
856
857 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
858
e61124cd
YM
8592011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
860
861 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
862
863 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
864 for fringe update if it has periodic bitmap.
865 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
866 and fringe_bitmap_periodic_p.
867
868 * fringe.c (get_fringe_bitmap_data): New function.
869 (draw_fringe_bitmap_1, update_window_fringes): Use it.
870 (update_window_fringes): Record periodicity of fringe bitmap in glyph
871 row. Mark glyph row for fringe update if periodicity changed.
872
873 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
874 for fringe update unless it has periodic bitmap.
875
f16d9837
KH
8762011-05-25 Kenichi Handa <handa@m17n.org>
877
878 * xdisp.c (get_next_display_element): Set correct it->face_id for
879 a static composition.
880
e1b90ef6
LL
8812011-05-24 Leo Liu <sdl.web@gmail.com>
882
883 * deps.mk (fns.o):
884 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
885
886 * fns.c (crypto_hash_function, Fsha1): New function.
887 (Fmd5): Use crypto_hash_function.
888 (syms_of_fns): Add Ssha1.
889
7400048f
PE
8902011-05-22 Paul Eggert <eggert@cs.ucla.edu>
891
892 * gnutls.c: Remove unused macros.
893 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
894 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
895 Remove macros that are defined and never used.
896 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
897
abb71cf4
CY
8982011-05-22 Chong Yidong <cyd@stupidchicken.com>
899
900 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
901 (Fx_get_selection_internal): Minor cleanup.
902 (Fx_own_selection_internal): Rename arguments for consistency with
903 select.el.
904
6307db39
PE
9052011-05-22 Paul Eggert <eggert@cs.ucla.edu>
906
907 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
908
f3d4e0a4
CY
9092011-05-22 Chong Yidong <cyd@stupidchicken.com>
910
911 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
912
4d8ade89
YM
9132011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
914
915 * dispnew.c (scrolling_window): Don't exclude the case that the
916 last enabled row in the desired matrix touches the bottom boundary.
917
32078c8d
GM
9182011-05-21 Glenn Morris <rgm@gnu.org>
919
920 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
921 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
922 and add some more files.
32078c8d 923
7285dc67
EZ
9242011-05-20 Eli Zaretskii <eliz@gnu.org>
925
926 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
927 report_file_error introduced by the change from 2011-05-07.
928
89d1bd22
PE
9292011-05-20 Paul Eggert <eggert@cs.ucla.edu>
930
931 * systime.h (Time): Define only if emacs is defined.
932 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
933 where the include path doesn't have X11/X.h by default. See
934 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
935
e23640bb 9362011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
937
938 * composite.c (find_automatic_composition): Fix previous change.
939
b9704ad9
GM
9402011-05-20 Glenn Morris <rgm@gnu.org>
941
942 * lisp.mk: New file, split from Makefile.in.
943 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
944 (shortlisp): Remove.
945 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
946
4a720484
GM
9472011-05-19 Glenn Morris <rgm@gnu.org>
948
949 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
950 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
951 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
952 (lisp): Set the order to that of loadup.el.
953 (shortlisp): Make it a copy of $lisp.
954 (SOME_MACHINE_LISP): Remove.
955 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
956 Use just $shortlisp, not $SOME_MACHINE_LISP too.
957
a28d4396
KH
9582011-05-18 Kenichi Handa <handa@m17n.org>
959
960 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
961 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
962 (find_automatic_composition): Mostly rewrite for efficiency.
963
a2b1fa8e
JB
9642011-05-18 Juanma Barranquero <lekktu@gmail.com>
965
966 * makefile.w32-in: Update dependencies.
967
8e1f5610
CS
9682011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
969
970 * menu.c: Include limits.h (fixes the MS-Windows build broken by
971 revision 104625).
972
7025ee00 9732011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 974
cdfa6eab
PE
975 Fix some integer overflow issues, such as string length overflow.
976
06d6db33
PE
977 * insdel.c (count_size_as_multibyte): Check for string overflow.
978
2b4560a8
PE
979 * character.c (lisp_string_width): Check for string overflow.
980 Use EMACS_INT, not int, for string indexes and lengths; in
981 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
982 the resulting string length overflows an EMACS_INT; instead,
983 report a string overflow if no precision given. When checking for
984 precision exhaustion, use a check that cannot possibly have
985 integer overflow. (Bug#8675)
986 * character.h (lisp_string_width): Adjust to new signature.
987
cb93f9be
PE
988 * alloc.c (string_overflow): New function.
989 (Fmake_string): Use it. This doesn't change behavior, but saves
990 a few bytes and will simplify future changes.
991 * character.c (string_escape_byte8): Likewise.
992 * lisp.h (string_overflow): New decl.
993
1a1f3366
PE
994 Fixups, following up to the user-interface timestamp change.
995 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
996 for UI timestamps, instead of unsigned long.
9fbd6841
PE
997 * msdos.c (mouse_get_pos): Likewise.
998 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
999 * w32gui.h (Time): Define by including "systime.h" rather than by
1000 declaring it ourselves. (Bug#8664)
1001
d4e3e4d3
PE
1002 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1003 * image.c (clear_image_cache): Likewise.
1004
f6a24d19
PE
1005 * term.c (term_mouse_position): Don't assume time_t wraparound.
1006
08dc5ae6
PE
1007 Be more systematic about user-interface timestamps.
1008 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
1009 and sometimes 'EMACS_UINT', to represent these timestamps.
1010 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
1011 This makes the code easier to follow, and makes it easier to catch
1012 integer overflow bugs such as Bug#8664.
1013 * frame.c (Fmouse_position, Fmouse_pixel_position):
1014 Use Time, not unsigned long, for user-interface timestamps.
1015 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1016 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1017 * keyboard.h (last_event_timestamp): Likewise.
1018 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1019 * menu.h (xmenu_show): Likewise.
1020 * term.c (term_mouse_position): Likewise.
1021 * termhooks.h (struct input_event.timestamp): Likewise.
1022 (struct terminal.mouse_position_hook): Likewise.
1023 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1024 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1025 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1026 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1027 what it was before.
1028 * menu.h, termhooks.h: Include "systime.h", for Time.
1029
8e55734a
PE
1030 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1031 Don't assume that the difference between two unsigned long values
1032 can fit into an integer. At this point, we know button_down_time
1033 <= event->timestamp, so the difference must be nonnegative, so
1034 there's no need to cast the result if double-click-time is
1035 nonnegative, as it should be; check that it's nonnegative, just in
1036 case. This bug is triggered when events are more than 2**31 ms
86db42d2 1037 apart (about 25 days). (Bug#8664)
8e55734a 1038
841f1b75 1039 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 1040 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 1041
3e26f69c
PE
1042 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1043 that always fit in int. Use a sentinel instead of a counter, to
1044 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
1045 * frame.h (struct frame): Use int for menu_bar_items_used
1046 instead of EMACS_INT, since it always fits in int.
3e26f69c 1047
5cc152c0
PE
1048 * menu.c (grow_menu_items): Check for int overflow.
1049
d89eb65e
PE
1050 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1051
5235bd3e
PE
1052 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1053 Before, the code was not consistent. These values cannot exceed
1054 2**31 - 1 so there's no need to make them unsigned.
1055 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1056 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1057 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1058 as modifiers.
1059 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1060
bc827e23
PE
1061 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1062 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1063 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1064 presumably because the widths might not match.
1065
78eb494e
PE
1066 * window.c (size_window): Avoid needless test at loop start.
1067
04f2d78b
CB
10682011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1069
1070 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1071
d2fc7e3d 10722011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
1073
1074 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1075
d2fc7e3d 10762011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
1077
1078 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1079 `width' to `bar_area_x' and `bar_area_width', respectively.
1080 (x_scroll_run): Take account of fringe background extension.
1081
04f2d78b
CB
1082 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1083 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
1084 `bar_area_width', respectively.
1085 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1086 background extension.
1087
79b70037
GM
10882011-05-10 Jim Meyering <meyering@redhat.com>
1089
1090 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1091
2f142cc5
JB
10922011-05-10 Juanma Barranquero <lekktu@gmail.com>
1093
1094 * image.c (Finit_image_library): Return t for built-in image types,
1095 like pbm and xbm. (Bug#8640)
1096
57679c86
AS
10972011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1098
1099 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1100
888c9e86
EZ
11012011-05-07 Eli Zaretskii <eliz@gnu.org>
1102
b0512a1d
EZ
1103 * w32console.c (Fset_screen_color): Doc fix.
1104 (Fget_screen_color): New function.
1105 (syms_of_ntterm): Defsubr it.
1106
7285dc67
EZ
1107 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1108 unlink the temporary file if Fcall_process didn't create it in the
1109 first place.
1110 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1111 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
1112 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1113 cue to call_process_cleanup not to close that handle.
1114
4d3fcc8e
BK
11152011-05-07 Ben Key <bkey76@gmail.com>
1116
1117 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1118 one of two shell specific rules, either bootstrap-temacs-CMD or
1119 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1120 to the previous implementation of the bootstrap-temacs rule.
1121 The bootstrap-temacs-CMD rule is similar to the previous
1122 implementation of the bootstrap-temacs rule except that it
1123 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1124 variable.
1125
1126 These changes, along with some changes to nt/configure.bat,
1127 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1128 earlier fix to add support for --cflags and --ldflags options
1129 that include quotes so that it works whether make uses cmd or
1130 sh as the shell.
1131
b4289b64
MA
11322011-05-06 Michael Albinus <michael.albinus@gmx.de>
1133
1134 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1135 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1136 is a constant.
1137 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1138 a string. Handle both cases.
1139 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1140 (Fdbus_register_method): Use Qinvalid_function.
1141
af4c0e28
JB
11422011-05-06 Juanma Barranquero <lekktu@gmail.com>
1143
1144 * makefile.w32-in: Update dependencies.
1145 (LISP_H): Add inttypes.h and stdin.h.
1146 (PROCESS_H): Add unistd.h.
1147
c51453d9
EZ
11482011-05-06 Eli Zaretskii <eliz@gnu.org>
1149
1150 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1151 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1152
8ff0ac3c 11532011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 1154
4c4b566b
PE
1155 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1156
aab2b9b5
PE
1157 * term.c (vfatal): Remove stray call to va_end.
1158 It's not needed and the C Standard doesn't allow it here anyway.
1159
c378da0b
PE
1160 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1161 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1162
288b08c7
PE
1163 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1164 bytes.
1165
e3601888
PE
1166 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1167
db6c0e74
PE
1168 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1169
dd5963ea
PE
1170 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1171
88c9450f
PE
1172 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1173
2f9442b8
PE
1174 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1175
c032b5f8
PE
1176 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1177 * charset.c (Fdefine_charset_internal): Don't initialize
1178 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 1179 32-bit int (Bug#8600).
a108c10b
PE
1180
1181 * lread.c (read_integer): Be more consistent with string-to-number.
1182 Use string_to_number to do the actual conversion; this avoids
1183 rounding errors and fixes some other screwups. Without this fix,
1184 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1185 (digit_to_number): Move earlier, for benefit of read_integer.
1186 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 1187 not a digit in any supported base. (Bug#8602)
a108c10b 1188
ad5f9eea
PE
1189 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1190
aec1708a
PE
1191 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1192 to match comment at start of function. This also removes a
1193 GCC warning about overflow in a 32+64-bit port.
1194
47be4ab5
PE
1195 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1196
371cac43
PE
1197 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1198 Reported by Stefan Monnier in
1199 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
1200 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1201 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 1202
d01a7826
PE
1203 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1204 (EMACS_UINTPTR): Likewise, with uintptr_t.
1205
7fd47d5c
PE
1206 * lisp.h: Prefer 64-bit EMACS_INT if available.
1207 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1208 on 32-bit hosts that have 64-bit int, so that they can access
1209 large files.
122b0c86
PE
1210 However, temporarily disable this change unless the temporary
1211 symbol WIDE_EMACS_INT is defined.
7fd47d5c 1212
8727937b
PE
1213 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1214
8ac068ac
PE
1215 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1216 This removes an assumption that EMACS_INT and long are the same
1217 width as pointers. The assumption is true for Emacs porting targets
1218 now, but we want to make other targets possible.
1219 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1220 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1221 In the rest of the code, change types of integers that hold casted
1222 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1223 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1224 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1225 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1226 No need to cast type when ORing.
1227 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1228 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1229 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1230 assume EMACS_INT is the same width as char *.
1231 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1232 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1233 Remove no-longer-needed casts.
1234 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1235 (xg_tool_bar_help_callback, xg_make_tool_item):
1236 Use EMACS_INTPTR to hold an integer
1237 that will be cast to void *; this can avoid a GCC warning
1238 if EMACS_INT is not the same width as void *.
1239 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1240 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1241 (current_message_1, set_message_1):
1242 Use a local to convert to proper width without a cast.
1243 * xmenu.c (dialog_selection_callback): Likewise.
1244
ede49d71
PE
1245 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1246 Also, don't assume VALBITS / RAND_BITS is less than 5,
1247 and don't rely on undefined behavior when shifting a 1 left into
1248 the sign bit.
1249 * lisp.h (get_random): Change signature to match.
1250
2f30ecd0
PE
1251 * lread.c (hash_string): Use size_t, not int, for hash computation.
1252 Normally we prefer signed values; but hashing is special, because
1253 it's better to use unsigned division on hash table sizes so that
1254 the remainder is nonnegative. Also, size_t is the natural width
1255 for hashing into memory. The previous code used 'int', which doesn't
1256 retain enough info to hash well into very large tables.
1257 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1258
2a866e7b
PE
1259 * dbusbind.c: Don't possibly lose pointer info when converting.
1260 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1261 Use XPNTR rather than XHASH, so that the high-order bits of
1262 the pointer aren't lost when converting through void *.
1263
51639eac
PE
1264 * eval.c (Fautoload): Don't double-shift a pointer.
1265
92394119
PE
1266 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1267
dbdb9a7c
JB
12682011-05-06 Juanma Barranquero <lekktu@gmail.com>
1269
1270 * gnutls.c (DEF_GNUTLS_FN):
1271 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1272
db7a0b4f
AS
12732011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1274
1275 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1276 marker. (Bug#8610)
1277
f7ff1b0f 12782011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
1279
1280 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1281 New version that can reserve upto 2GB of heap space.
1282
f7ff1b0f 12832011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
1284
1285 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1286
639c109b
TZ
12872011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1288
1289 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1290 `gnutls_certificate_set_x509_key_file'.
1291
d2127135
JB
12922011-05-05 Juanma Barranquero <lekktu@gmail.com>
1293
1294 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1295 Update dependencies.
1296
e968f4f3
JB
12972011-05-04 Juanma Barranquero <lekktu@gmail.com>
1298
1299 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1300 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1301 Remove unused parameter `fildes'.
1302 * process.c (read_process_output, send_process): Don't pass it.
1303
84d358f0
JB
13042011-05-04 Juanma Barranquero <lekktu@gmail.com>
1305
1306 Fix previous change: the library cache is defined in w32.c.
1307 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1308 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1309
0898ca10
JB
13102011-05-04 Juanma Barranquero <lekktu@gmail.com>
1311
1312 Implement dynamic loading of GnuTLS on Windows.
1313
1314 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1315 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1316 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1317 Declare.
1318
1319 * gnutls.c (Qgnutls_dll): Define.
1320 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1321 (gnutls_*): Declare function pointers.
1322 (init_gnutls_functions): New function to initialize function pointers.
1323 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1324 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1325 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1326 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1327 (emacs_gnutls_write, emacs_gnutls_read)
1328 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1329 (Fgnutls_available_p): New function.
1330 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1331 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1332 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1333
1334 * image.c: Include w32.h.
1335 (Vimage_type_cache): Delete.
1336 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1337 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1338 (w32_delayed_load): Move to w32.c.
1339
1340 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1341
1342 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1343 (w32_delayed_load): Move from image.c. When loading a library, record
1344 its filename in the :loaded-from property of the library id.
1345 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1346 Initialize and staticpro them.
1347 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1348
1349 * process.c: Include lisp.h before w32.h, not after.
1350 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1351 instead of gnutls_record_check_pending.
1352
1353 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1354
ff4de4aa
TZ
13552011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1356
1357 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1358 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1359 as passed in.
1360
abe95abb
JD
13612011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1362
1363 * xterm.c (x_set_frame_alpha): Do not set property on anything
1364 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1365
e16e55d4
JB
13662011-05-02 Juanma Barranquero <lekktu@gmail.com>
1367
1368 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1369
bafcf6a5
JB
13702011-05-02 Juanma Barranquero <lekktu@gmail.com>
1371
1372 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1373 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1374 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1375 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1376 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1377 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1378 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1379 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1380 (Qgnutls_bootprop_callbacks_verify): Make static.
1381
e7a6747f
AS
13822011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1383
19ed11ba
AS
1384 * callproc.c: Indentation fixup.
1385
e7a6747f 1386 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
1387 (wait_for_termination, interruptible_wait_for_termination):
1388 Move after wait_for_termination_1.
e7a6747f 1389
1ef14cb4
LMI
13902011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1391
1392 * sysdep.c (interruptible_wait_for_termination): New function
1393 which is like wait_for_termination, but allows keyboard
1394 interruptions.
1395
1396 * callproc.c (Fcall_process): Add (:file "file") as an option for
1397 the STDOUT buffer.
1398 (Fcall_process_region): Ditto.
1399
330d880c
EZ
14002011-04-30 Eli Zaretskii <eliz@gnu.org>
1401
8db90b73
EZ
1402 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1403 rather than `XVECTOR (FOO)->size'.
1404
330d880c
EZ
1405 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1406 inttypes.h, as a gnulib replacement is used if it not available in
1407 system headers.
1408
15cbd324
EZ
14092011-04-21 Eli Zaretskii <eliz@gnu.org>
1410
1411 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1412 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1413 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1414
1415 * coding.c (coding_alloc_by_realloc): Error out if destination
1416 will grow beyond MOST_POSITIVE_FIXNUM.
1417 (decode_coding_emacs_mule): Abort if there isn't enough place in
1418 charbuf for the composition carryover bytes. Reserve an extra
1419 space for up to 2 characters produced in a loop.
1420 (decode_coding_iso_2022): Abort if there isn't enough place in
1421 charbuf for the composition carryover bytes.
1422
14232011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 1424
ae940cca
EZ
1425 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1426 aborting when %lld or %lll format is passed.
1427 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1428 %llo or %llx format is passed. (Bug#8545)
1429
03ab8921
EZ
1430 * window.c (window_scroll_line_based): Use a marker instead of
1431 simple variables to record original value of point. (Bug#7952)
1432
afda1437
EZ
1433 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1434 produced by %s or %c overflows available buffer space. (Bug#8545)
1435
f76dee0c
PE
14362011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1437
1438 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 1439 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 1440
fdc5744d
JB
14412011-04-28 Juanma Barranquero <lekktu@gmail.com>
1442
1443 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1444
638f053a
JB
14452011-04-28 Juanma Barranquero <lekktu@gmail.com>
1446
1447 * keyboard.c (Qdelayed_warnings_hook): Define.
1448 (command_loop_1): Run `delayed-warnings-hook'
1449 if Vdelayed_warnings_list is non-nil.
1450 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1451 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1452
d178f871
EZ
14532011-04-28 Eli Zaretskii <eliz@gnu.org>
1454
1455 * doprnt.c (doprnt): Don't return value smaller than the buffer
1456 size if the message was truncated. (Bug#8545).
1457
b124fd93
JB
14582011-04-28 Juanma Barranquero <lekktu@gmail.com>
1459
1460 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1461 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1462
e810457d
PE
14632011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1464
1465 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1466
ea51cceb
JB
14672011-04-27 Juanma Barranquero <lekktu@gmail.com>
1468
1469 * makefile.w32-in: Update dependencies.
1470
94dcfacf
EZ
14712011-04-27 Eli Zaretskii <eliz@gnu.org>
1472
1473 Improve `doprnt' and its usage. (Bug#8545)
1474 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1475 `format_end'. Remove support for %l as a conversion specifier.
1476 Don't use xrealloc. Improve diagnostics when the %l size modifier
1477 is used. Update the commentary.
1478
1479 * eval.c (verror): Simplify calculation of size_t.
1480
1481 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1482 messages.
1483
f61f41d7
PE
14842011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1485
1486 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1487 change.
1488
96fb4434
PE
14892011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1490
1491 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1492 This makes this file independent of the recent pseudovector change.
1493
671875da 14942011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 1495
69e9b5a3
PE
1496 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1497
b5f869a7 1498 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 1499 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 1500 Remove unused local.
c8926152 1501 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 1502
841a1577 1503 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
1504 GCC 4.6.0 optimizes based on type-based alias analysis.
1505 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
1506 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1507 != &v->size, and therefore "v->size = 1; b->size = 2; return
1508 v->size;" must therefore return 1. This assumption is incorrect
1509 for Emacs, since it type-puns struct Lisp_Vector * with many other
1510 types. To fix this problem, this patch adds a new type struct
f904488f 1511 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
1512 and pseudovectors, and helps optimizing compilers not get fooled
1513 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1514 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
1515 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1516 the size member.
eab3844f
PE
1517 (XSETPVECTYPE): Rewrite in terms of new macro.
1518 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1519 This is a bit clearer, and further avoids the possibility of
1520 undesirable aliasing.
1521 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 1522 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
1523 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1524 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
1525 (ASIZE): Now uses header.size rather than size.
1526 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
1527 to avoid the hassle of writing XVECTOR (foo)->header.size.
1528 (struct vectorlike_header): New type.
eab3844f
PE
1529 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1530 object, to help avoid aliasing.
1531 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1532 (SUBRP): Likewise, since Lisp_Subr is a special case.
1533 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1534 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1535 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 1536 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
1537 changed to be "header.size" and "header.next".
1538 * buffer.h (struct buffer): Likewise.
1539 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1540 * frame.h (struct frame): Likewise.
1541 * process.h (struct Lisp_Process): Likewise.
1542 * termhooks.h (struct terminal): Likewise.
1543 * window.c (struct save_window_data, struct saved_window): Likewise.
1544 * window.h (struct window): Likewise.
1545 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1546 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1547 * buffer.c (init_buffer_once): Likewise.
1548 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1549 special case.
1550 * process.c (Fformat_network_address): Use local var for size,
1551 for brevity.
1552
0df1eac5
PE
1553 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1554
847ab9d1 1555 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
1556 * data.c (atof): Remove decl; no longer used or needed.
1557 (digit_to_number): Move to lread.c.
1558 (Fstring_to_number): Use new string_to_number function, to be
1559 consistent with how the Lisp reader treats infinities and NaNs.
1560 Do not assume that floating-point numbers represent EMACS_INT
1561 without losing information; this is not true on most 64-bit hosts.
1562 Avoid double-rounding errors, by insisting on integers when
1563 parsing non-base-10 numbers, as the documentation specifies.
1564 * lisp.h (string_to_number): New decl, replacing ...
1565 (isfloat_string): Remove.
bc0a5c13 1566 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 1567 (read1): Do not accept +. and -. as integers; this
452f4150
PE
1568 appears to have been a coding error. Similarly, do not accept
1569 strings like +-1e0 as floating point numbers. Do not report
1570 overflow for integer overflows unless the base is not 10 which
1571 means we have no simple and reliable way to continue.
1572 Break out the floating-point parsing into a new
1573 function string_to_number, so that Fstring_to_number parses
1574 floating point numbers consistently with the Lisp reader.
04f2d78b 1575 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
1576 (E_CHAR, EXP_INT): Remove, replacing with ...
1577 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1578 (string_to_number): New function, replacing isfloat_string.
1579 This function checks for valid syntax and produces the resulting
1580 Lisp float number too. Rework it so that string-to-number
bc0a5c13 1581 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
1582 so that overflow for non-base-10 numbers is reported only when
1583 there's no portable and simple way to convert to floating point.
452f4150 1584
67769ffc
PE
1585 * textprop.c (set_text_properties_1): Rewrite for clarity,
1586 and to avoid GCC warning about integer overflow.
1587
c20db43f
PE
1588 * intervals.h (struct interval): Use EMACS_INT for members
1589 where EMACS_UINT might cause problems. See
1590 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1591 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1592 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1593 All uses changed.
37aa2f85
PE
1594 (offset_intervals): Tell GCC not to worry about length overflow
1595 when negating a negative length.
c20db43f 1596
2538aa2f
PE
1597 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1598 (overrun_check_free): Likewise.
1599
f2d3008d
PE
1600 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1601 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1602 word size.
1603
ec8df744
PE
1604 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1605 (gnutls_make_error): Rename local to avoid shadowing.
1606 (gnutls_emacs_global_deinit): ifdef out; not used.
1607 (Fgnutls_boot): Use const for pointer to readonly storage.
1608 Comment out unused local. Fix pointer signedness problems.
1609
640ee02d
PE
1610 * lread.c (openp): Don't stuff size_t into an 'int'.
1611 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1612 about possible signed overflow.
1613
6048fb2a
PE
1614 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1615 (GDK_KEY_g): Don't define if already defined.
1616 (xg_prepare_tooltip): Avoid pointer signedness problem.
1617 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1618
fa3c87e1
PE
1619 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1620 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1621
2172544b
PE
1622 * xfns.c (Fx_window_property): Simplify a bit,
1623 to make a bit faster and to avoid GCC 4.6.0 warning.
1624 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1625
9b821a21
PE
1626 * fns.c (internal_equal): Don't assume size_t fits in int.
1627
3c616cfa
PE
1628 * alloc.c (compact_small_strings): Tighten assertion a little.
1629
c2982e87
PE
1630 Replace pEd with more-general pI, and fix some printf arg casts.
1631 * lisp.h (pI): New macro, generalizing old pEd macro to other
1632 conversion specifiers. For example, use "...%"pI"d..." rather
1633 than "...%"pEd"...".
1634 (pEd): Remove. All uses replaced with similar uses of pI.
1635 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1636 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1637 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1638 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1639 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1640 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1641 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1642 64-bit hosts.
1643 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1644 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1645 * print.c (safe_debug_print, print_object): Likewise.
1646 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1647 to int.
6f04d126
PE
1648 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1649 avoiding the 0 flag, which is not portable.
c2982e87
PE
1650 * process.c (Fmake_network_process): Use pI to avoid cast.
1651 * region-cache.c (pp_cache): Likewise.
1652 * xdisp.c (decode_mode_spec): Likewise.
1653 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1654 behavior on 64-bit hosts with printf arg.
6f04d126 1655 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
1656 (x_stop_queuing_selection_requests): Likewise.
1657 (x_get_window_property): Don't truncate byte count to an 'int'
1658 when tracing.
0b432f21 1659
5e073ec7
PE
1660 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1661 here, since it parses constructs like leading '-' and spaces,
1662 which are not wanted; and it overflows with large numbers.
1663 Instead, simply match F[0-9]+, which is what is wanted anyway.
1664
36372bf9
PE
1665 * alloc.c: Remove unportable assumptions about struct layout.
1666 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1667 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1668 (allocate_vectorlike, make_pure_vector): Use the new macros,
1669 plus offsetof, to remove unportable assumptions about struct layout.
1670 These assumptions hold on all porting targets that I know of, but
1671 they are not guaranteed, they're easy to remove, and removing them
1672 makes further changes easier.
1673
0b432f21
PE
1674 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1675 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
1676 (string_overrun_cookie): Now const. Use initializers that
1677 don't formally overflow signed char, to avoid warnings.
000098c1
PE
1678 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1679 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
1680 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1681 multiple of sizeof (EMACS_INT); it need not be, if
1682 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 1683 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 1684
895009e1
JB
16852011-04-26 Juanma Barranquero <lekktu@gmail.com>
1686
1687 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1688
6a7a1b0b
TZ
16892011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1690
1691 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 1692 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
1693 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1694
841a1577 16952011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
1696
1697 * lisp.h (Qdebug): List symbol.
895009e1 1698 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
1699 * keyboard.c (debug-on-event): New variable.
1700 (handle_user_signal): Break into debugger when debug-on-event
1701 matches the current signal symbol.
1702
f2d3ba6f
DN
17032011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1704
1705 * alloc.c (check_sblock, check_string_bytes)
1706 (check_string_free_list): Convert to standard C.
1707
42ce4c63
TZ
17082011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1709
1710 * w32.c (emacs_gnutls_push): Fix typo.
1711
825cd63c
EZ
17122011-04-25 Eli Zaretskii <eliz@gnu.org>
1713
fb11d64d
EZ
1714 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1715 "cast to pointer from integer of different size".
1716
825cd63c
EZ
1717 Improve doprnt and its use in verror. (Bug#8545)
1718 * doprnt.c (doprnt): Document the set of format control sequences
1719 supported by the function. Use SAFE_ALLOCA instead of always
1720 using `alloca'.
1721
1722 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1723 is one byte too soon. Don't use xrealloc; instead xfree and
1724 xmalloc anew.
1725
e061a11b
TZ
17262011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1727
1728 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1729 callbacks stage.
1730
1731 * gnutls.c: Renamed global_initialized to
1732 gnutls_global_initialized. Added internals for the
1733 :verify-hostname-error, :verify-error, and :verify-flags
1734 parameters of `gnutls-boot' and documented those parameters in the
1735 docstring. Start callback support.
1736 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1737 unless a fatal error occured. Call gnutls_alert_send_appropriate
1738 on error. Return error code.
1739 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1740 (emacs_gnutls_read): Likewise.
1741 (Fgnutls_boot): Return handshake error code.
1742 (emacs_gnutls_handle_error): New function.
1743 (wsaerror_to_errno): Likewise.
1744
1745 * w32.h (emacs_gnutls_pull): Add prototype.
1746 (emacs_gnutls_push): Likewise.
1747
1748 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1749 (emacs_gnutls_push): Likewise.
1750
17512011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1752
1753 * process.c (wait_reading_process_output): Check if GnuTLS
1754 buffered some data internally if no FDs are set for TLS
1755 connections.
1756
1757 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1758 (LIBS): Link to USER_LIBS.
1759 ($(BLD)/gnutls.$(0)): New target.
1760
fa6996bc
EZ
17612011-04-24 Eli Zaretskii <eliz@gnu.org>
1762
eb35682e
EZ
1763 * xdisp.c (handle_single_display_spec): Rename the
1764 display_replaced_before_p argument into display_replaced_p, to
1765 make it consistent with the commentary. Fix typos in the
1766 commentary.
1767
e2ad650c
EZ
1768 * textprop.c (syms_of_textprop): Remove dead code.
1769 (copy_text_properties): Delete obsolete commentary about an
1770 interface that was deleted long ago. Fix typos in the description
1771 of arguments.
1772
1b2de274
EZ
1773 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1774 to changes in oldXMenu/XMenu.h from 2011-04-16.
1775 <menu_help_message, prev_menu_help_message>: Constify.
1776 (IT_menu_make_room): menu->help_text is now `const char **';
1777 adjust.
1778
1779 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1780 to changes in oldXMenu/XMenu.h from 2011-04-16.
1781 (struct XMenu): Declare `help_text' `const char **'.
1782
1783 * xfaces.c <Qunspecified>: Make extern again.
1784
1785 * syntax.c: Include sys/types.h before including regex.h, as
1786 required by Posix.
1787
762b15be
EZ
1788 * doc.c (get_doc_string): Improve the format passed to `error'.
1789
1790 * doprnt.c (doprnt): Improve commentary.
1791
1792 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1793
1794 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1795 them with etags.
1796
f1052e5d
EZ
1797 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1798 changes in globals.h immediately force recompilation.
762b15be
EZ
1799 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1800 $(CURDIR)/s/ms-w32.h.
1801 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 1802
fa6996bc
EZ
1803 * character.c (Fchar_direction): Function deleted.
1804 (syms_of_character): Don't defsubr it.
1805 <char-direction-table>: Deleted.
1806
e6c3da20
EZ
18072011-04-23 Eli Zaretskii <eliz@gnu.org>
1808
1809 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1810 * doprnt.c: Include limits.h.
1811 (SIZE_MAX): New macro.
04f2d78b
CB
1812 (doprnt): Return a size_t value. 2nd arg is now size_t.
1813 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
1814 Improve overflow protection. Support `l' modifier for integer
1815 conversions. Support %l conversion. Don't assume an EMACS_INT
1816 argument for integer conversions and for %c.
1817
1818 * lisp.h (doprnt): Restore prototype.
1819
1820 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1821 $(SRC)/character.h.
1822
1823 * Makefile.in (base_obj): Add back doprnt.o.
1824
1825 * deps.mk (doprnt.o): Add back prerequisites.
1826 (callint.o): Depend on character.h.
1827
1828 * eval.c (internal_lisp_condition_case): Include the handler
1829 representation in the error message.
1830 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1831 when breaking from the loop.
1832
1833 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1834
1835 * callint.c (Fcall_interactively): When displaying error message
1836 about invalid control letter, pass the character's codepoint, not
1837 a pointer to its multibyte form. Improve display of the character
1838 in octal and display also its hex code.
1839
1840 * character.c (char_string): Use %x to display the (unsigned)
1841 codepoint of an invalid character, to avoid displaying a bogus
1842 negative value.
1843
1844 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1845 `error', not SYMBOL_NAME itself.
1846
1847 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1848 character arguments to `error'.
1849
1850 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1851 to `error' in error message about FINAL_CHAR argument. Make sure
1852 FINAL_CHAR is a character, and use %c when it is passed as
1853 argument to `error'.
1854
4ffd0d6b 18552011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
1856
1857 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1858
1859 * w32.c: Include <time.h>.
1860 (sys_localtime): New function.
1861
4ffd0d6b 18622011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
1863
1864 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1865
4ffd0d6b 1866 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 1867
4ffd0d6b 18682011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 1869
4ffd0d6b
GM
1870 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1871 zombies (Bug#8467).
aac0c6e3 1872
04c56954
EZ
18732011-04-19 Eli Zaretskii <eliz@gnu.org>
1874
1875 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1876 gl_state.e_property when gl_state.object is Qt.
1877
1878 * insdel.c (make_gap_larger): Remove limitation of buffer size
1879 to <= INT_MAX.
1880
16a43933
CY
18812011-04-18 Chong Yidong <cyd@stupidchicken.com>
1882
1883 * xdisp.c (lookup_glyphless_char_display)
1884 (produce_glyphless_glyph): Handle cons cell entry in
1885 glyphless-char-display.
1886 (Vglyphless_char_display): Document it.
1887
1888 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1889 glyphless-char-display.
1890
4581706e
CY
18912011-04-17 Chong Yidong <cyd@stupidchicken.com>
1892
1893 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1894
1895 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1896
1897 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1898 definition for no-X builds.
1899
4887c6e2 19002011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 1901
fd35b6f9
PE
1902 Static checks with GCC 4.6.0 and non-default toolkits.
1903
5c1ccb01
PE
1904 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1905
006c5daa
PE
1906 * process.c (keyboard_bit_set): Define only if SIGIO.
1907 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1908 (send_process): Repair possible setjmp clobbering.
1909
efc736d3
PE
1910 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1911
4e2fe2e6
PE
1912 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1913
f97334a2
PE
1914 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1915
4e75f29d
PE
1916 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1917 Define only if needed.
1918
90efadd1
PE
1919 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1920 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 1921 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 1922
3c647824
PE
1923 * dispextern.h (struct redisplay_interface): Rename param
1924 to avoid shadowing.
e264f262 1925 * termhooks.h (struct terminal): Likewise.
761383f4 1926 * xterm.c (xembed_send_message): Likewise.
3c647824 1927
b58c5c4a
PE
1928 * insdel.c (make_gap_smaller): Define only if
1929 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1930
cad59032
PE
1931 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1932 it.
1933
c339dc2e
PE
1934 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1935 so that we aren't warned about unused symbols.
1936
91a3e27b
PE
1937 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1938
399c71d3 1939 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 1940
8ffc96f5
PE
1941 * xfns.c (x_real_positions): Mark locals as initialized.
1942
eef9bc79
PE
1943 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1944
098db9dd
PE
1945 * xterm.c: Fix problems found by static analysis with other toolkits.
1946 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
1947 (x_dispatch_event): Declare static if USE_GTK, and
1948 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 1949 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 1950 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
1951 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1952 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 1953
eb18f6cc
PE
1954 * xmenu.c (menu_help_callback): Pointer type fixes.
1955 Use const pointers when pointing at readonly data. Avoid pointer
1956 signedness clashes.
1957 (FALSE): Remove unused macro.
1958 (update_frame_menubar): Remove unused decl.
1959
1fe72bf8
PE
1960 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1961
60d9e1db
PE
1962 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1963 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1964 (single_menu_item): Rename local to avoid shadowing.
1965
39261c26
PE
1966 * keyboard.c (make_lispy_event): Remove unused local var.
1967
018c5e19
PE
1968 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1969 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1970
63d2b86e
PE
1971 * bitmaps: Change bitmaps from unsigned char back to the X11
1972 compatible char. Avoid the old compiler warnings about
1973 out-of-range initializers by using, for example, '\xab' rather
1974 than 0xab.
1975
aefd87e1
PE
1976 * xgselect.c (xgselect_initialize): Check vs interface
1977 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1978
bf501fb9
PE
1979 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1980
e9829fdf
PE
1981 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1982 to read-only memory.
1983
1086c095
PE
1984 * fns.c (vector): Remove; this old hack is no longer needed.
1985
2baccd04 1986 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 1987 Remove unused var.
dde42981 1988 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 1989
72391843 1990 * xrdb.c (x_load_resources): Omit unused local.
3565b346 1991
436c16df 1992 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 1993 (x_window): Rename locals to avoid shadowing.
dc5ddd85 1994 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 1995
92bb796d 1996 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 1997 (x_term_init): Remove local to avoid shadowing.
92bb796d 1998
764430a3 1999 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
2000
2001 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2002 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2003
d1dfb56c
EZ
20042011-04-16 Eli Zaretskii <eliz@gnu.org>
2005
c4354cb4
EZ
2006 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2007
d1dfb56c
EZ
2008 Fix regex.c, syntax.c and friends for buffers > 2GB.
2009 * syntax.h (struct gl_state_s): Declare character position members
2010 EMACS_INT.
2011
2012 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2013
04f2d78b
CB
2014 * textprop.c (verify_interval_modification, interval_of):
2015 Declare arguments EMACS_INT.
d1dfb56c
EZ
2016
2017 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2018 EMACS_INT.
2019
2020 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2021
2022 * indent.c (Fvertical_motion): Local variable it_start is now
2023 EMACS_INT.
2024
2025 * regex.c (re_match, re_match_2, re_match_2_internal)
2026 (bcmp_translate, regcomp, regexec, print_double_string)
2027 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2028 (re_compile_pattern, re_exec): Declare arguments and local
2029 variables `size_t' and `ssize_t' and return values `regoff_t', as
2030 appropriate.
2031 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2032 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2033 <compile_stack_type>: `size' and `avail' are now `size_t'.
2034
2035 * regex.h <regoff_t>: Use ssize_t, not int.
2036 (re_search, re_search_2, re_match, re_match_2): Arguments that
2037 specify buffer/string position and length are now ssize_t and
2038 size_t. Return type is regoff_t.
2039
613052cd
BK
20402011-04-16 Ben Key <bkey76@gmail.com>
2041
2042 * nsfont.m: Fixed bugs in ns_get_family and
2043 ns_descriptor_to_entity that were caused by using free to
2044 deallocate memory blocks that were allocated by xmalloc (via
2045 xstrdup). This caused Emacs to crash when compiled with
2046 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2047 --enable-checking=xmallocoverrun). xfree is now used to
2048 deallocate these memory blocks.
2049
4170f62f 20502011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 2051
71b41406
PE
2052 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2053
9587a89d
PE
2054 emacs_write: Accept and return EMACS_INT for sizes.
2055 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2056 et seq.
2057 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2058 Accept and return EMACS_INT.
2059 (emacs_gnutls_write): Return the number of bytes written on
2060 partial writes.
2061 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
2062 (emacs_read, emacs_write): Remove check for negative size, as the
2063 Emacs source code has been audited now.
9587a89d
PE
2064 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2065 (emacs_read, emacs_write): Use it.
273a5f82
PE
2066 * process.c (send_process): Adjust to the new signatures of
2067 emacs_write and emacs_gnutls_write. Do not attempt to store
2068 a byte offset into an 'int'; it might overflow.
9587a89d 2069 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 2070
3e047f51
PE
2071 * sound.c: Don't assume sizes fit in 'int'.
2072 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 2073 Return EMACS_INT, not int.
3e047f51 2074 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
2075 Accept EMACS_INT, not int.
2076 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
2077 record read return values.
2078
cc39a9db
BK
20792011-04-15 Ben Key <bkey76@gmail.com>
2080
c9d0ec6d
JB
2081 * keyboard.c (Qundefined): Don't declare static since it is used
2082 in nsfns.m.
2083 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2084 static since they are used in nsfont.m.
cc39a9db 2085
6c60eb9f
SM
20862011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2087
2088 * process.c (Qprocessp): Don't declare static.
2089 * lisp.h (Qprocessp): Declare again.
2090
7990b61a
JB
20912011-04-15 Juanma Barranquero <lekktu@gmail.com>
2092
2093 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2094
5d4cb038
PE
20952011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2096
8bd7b830 2097 Improve C-level modularity by making more things 'static'.
cd64ea1d 2098
e3b27b31
PE
2099 Don't publish debugger-only interfaces to other modules.
2100 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2101 (verify_bytepos, count_markers): Move decls to the only modules
2102 that need them.
2103 * region-cache.h (pp_cache): Likewise.
2104 * window.h (check_all_windows): Likewise.
2105 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2106
5d4cb038
PE
2107 * sysdep.c (croak): Now static, if
2108 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2109 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
2110
2111 * alloc.c (refill_memory_reserve): Now static if
2112 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2113 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 2114
e87b6180
PE
2115 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2116 Define only if USE_LUCID.
2117
ac64929e
PE
2118 * xrdb.c (x_customization_string, x_rm_string): Now static.
2119
6f37259d
PE
2120 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2121 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2122
1683e3ab
PE
2123 * xdisp.c (draw_row_with_mouse_face): Now static.
2124 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2125
de9c2632
PE
2126 * window.h (check_all_windows): Mark externally visible.
2127
2b96acb7
PE
2128 * window.c (window_deletion_count): Now static.
2129
2130 * undo.c: Make symbols static if they're not exported.
2131 (last_undo_buffer, last_boundary_position, pending_boundary):
2132 Now static.
2133
50436f33
PE
2134 * textprop.c (interval_insert_behind_hooks): Now static.
2135 (interval_insert_in_front_hooks): Likewise.
2136
64520e5c
PE
2137 * term.c: Make symbols static if they're not exported.
2138 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2139 (max_frame_lines, tty_set_terminal_modes):
2140 (tty_reset_terminal_modes, tty_turn_off_highlight):
2141 (get_tty_terminal): Now static.
2142 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2143 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 2144 HAVE_WINDOW_SYSTEM.
64520e5c
PE
2145 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2146 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2147
1fa53021
PE
2148 * sysdep.c: Make symbols static if they're not exported.
2149 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2150 Now static.
2151 (sigprocmask_set, full_mask): Remove; unused.
2152 (wait_debugging): Mark as visible.
2153 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2154 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2155
d4b43b22
PE
2156 * syntax.c (syntax_temp): Define only if !__GNUC__.
2157
b7c513d0
PE
2158 * sound.c (current_sound_device, current_sound): Now static.
2159
989b29ad
PE
2160 * search.c (searchbufs, searchbuf_head): Now static.
2161
13a55a78
PE
2162 * scroll.c (scroll_cost): Remove; unused.
2163 * dispextern.h (scroll_cost): Remove decl.
2164
de68a1fc
PE
2165 * region-cache.h (pp_cache): Mark as externally visible.
2166
40ccffa6
PE
2167 * process.c: Make symbols static if they're not exported.
2168 (process_tick, update_tick, create_process, chan_process):
2169 (Vprocess_alist, proc_buffered_char, datagram_access):
2170 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2171 (deactivate_process): Mark defn as static, as well as decl.
2172 * lisp.h (create_process): Remove decl.
2173 * process.h (chan_process, Vprocess_alist): Remove decls.
2174
ad64fc97
PE
2175 * print.c: Make symbols static if they're not exported.
2176 (print_depth, new_backquote_output, being_printed, print_buffer):
2177 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2178 (print_interval, print_number_index, initial_stderr_stream):
2179 Now static.
2180 * lisp.h (Fprinc): Remove decl.
2181 (debug_output_compilation_hack): Mark as externally visible.
2182
adddb265
PE
2183 * sysdep.c (croak): Move decl from here to syssignal.h.
2184 * syssignal.h (croak): Put it here, so the API can be checked when
2185 'croak' is called from dissociate_if_controlling_tty.
2186
1717ede2
PE
2187 * minibuf.c: Make symbols static if they're not exported.
2188 (minibuf_save_list, choose_minibuf_frame): Now static.
2189 * lisp.h (choose_minibuf_frame): Remove decl.
2190
fa5fb2bc
PE
2191 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2192
1e3890d1
PE
2193 * lread.c: Make symbols static if they're not exported.
2194 (read_objects, initial_obarray, oblookup_last_bucket_number):
2195 Now static.
2196 (make_symbol): Remove; unused.
2197 * lisp.h (initial_obarray, make_symbol): Remove decls.
2198
8a1414fa
PE
2199 * keyboard.c: Make symbols static if they're not exported.
2200 (single_kboard, recent_keys_index, total_keys, recent_keys):
2201 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2202 (this_single_command_key_start, echoing, last_auto_save):
2203 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2204 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2205 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2206 (Vlispy_mouse_stem, double_click_count):
2207 Now static.
2208 (force_auto_save_soon): Define only if SIGDANGER.
2209 (ignore_mouse_drag_p): Now static if
2210 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2211 (print_help): Remove; unused.
2212 (stop_character, last_timer_event): Mark as externally visible.
2213 * keyboard.h (ignore_mouse_drag_p): Declare only if
2214 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2215 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2216 * lisp.h (echoing): Remove decl.
2217 (force_auto_save_soon): Declare only if SIGDANGER.
2218 * xdisp.c (redisplay_window): Simplify code, to make it more
2219 obvious that ignore_mouse_drag_p is not accessed if !defined
2220 USE_GTK && !defined HAVE_NS.
2221
93ea6e8f
PE
2222 * intervals.c: Make symbols static if they're not exported.
2223 (merge_properties_sticky, merge_interval_right, delete_interval):
2224 Now static.
2225 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2226
77382fcc
PE
2227 * insdel.c: Make symbols static if they're not exported.
2228 However, leave prepare_to_modify_buffer alone. It's never
2229 called from outside this function, but that appears to be a bug.
2230 (combine_after_change_list, combine_after_change_buffer):
4889fc82 2231 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
2232 (adjust_after_replace_noundo): Remove; unused.
2233 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 2234 (signal_before_change): Remove decls.
77382fcc 2235
9306c32e
PE
2236 * indent.c (val_compute_motion, val_vmotion): Now static.
2237
cd44d2eb
PE
2238 * image.c: Make symbols static if they're not exported.
2239 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2240 if USE_GTK.
2241 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2242 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2243
ad9a7a06
PE
2244 * fringe.c (standard_bitmaps): Now static.
2245 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2246
81626931
PE
2247 * frame.c: Make symbols static if they're not exported.
2248 (x_report_frame_params, make_terminal_frame): Now static.
2249 (get_frame_param): Now static, unless HAVE_NS.
2250 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2251 (x_get_resource_string): Remove; not used.
2252 * frame.h (make_terminal_frame, x_report_frame_params):
2253 (x_get_resource_string); Remove decls.
2254 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2255 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2256
239f9db9
PE
2257 * font.c, fontset.c: Make symbols static if they're not exported.
2258 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2259 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2260 * font.c (font_close_object): Now static.
2261 * font.h (font_close_object): Remove.
2262 * fontset.c (FONTSET_OBJLIST): Remove.
2263 (free_realized_fontset) #if-0 the body, which does nothing.
2264 (face_suitable_for_char_p): #if-0, as it's never called.
2265 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
2266 * xfaces.c (face_at_string_position):
2267 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
2268 since 0 is always ASCII.
2269
dfcf3579
PE
2270 * fns.c (weak_hash_tables): Now static.
2271
5045092b
PE
2272 * fileio.c: Make symbols static if they're not exported.
2273 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2274 (Vwrite_region_annotation_buffers): Now static.
2275
57a96f5c
PE
2276 * eval.c: Make symbols static if they're not exported.
2277 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2278 * lisp.h (backtrace_list): Remove decl.
2279
35f08c38
PE
2280 * emacs.c: Make symbols static if they're not exported.
2281 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2282 (fatal_error_code, fatal_error_signal_hook, standard_args):
2283 Now static.
2284 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2285 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2286 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2287 * lisp.h (fatal_error_signal_hook): Remove decl.
2288 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2289
f44bd759
PE
2290 * editfns.c: Move a (normally-unused) function to its only use.
2291 * editfns.c, lisp.h (get_operating_system_release): Remove.
2292 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2293 worth the hassle of breaking this out.
2294
b532497d
PE
2295 * xterm.c: Make symbols static if they're not exported.
2296 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2297 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2298 (x_destroy_window, x_delete_display):
2299 Now static.
2300 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2301 (x_mouse_leave): Remove; unused.
2302 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2303 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2304 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2305 Remove decls.
2306 (x_mouse_leave): Declare only if WINDOWSNT.
2307 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2308 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2309 USE_X_TOOLKIT.
2310
1675728f
PE
2311 * ftxfont.c: Make symbols static if they're not exported.
2312 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2313 HAVE_FREETYPE.
2314 * font.h (ftxfont_driver): Likewise.
2315
e4cebfca
PE
2316 * xfns.c: Make symbols static if they're not exported.
2317 (x_last_font_name, x_display_info_for_name):
2318 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2319 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2320 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2321 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2322 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2323 (last_show_tip_args): Now static.
2324 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2325 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2326 (x_screen_planes): Remove; unused.
2327 * dispextern.h (x_screen_planes): Remove decl.
2328
5bf46f05
PE
2329 * dispnew.c: Make symbols static if they're not exported.
2330 * dispextern.h (redraw_garbaged_frames, scrolling):
2331 (increment_row_positions): Remove.
2332 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2333 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2334 Now static.
2335 (redraw_garbaged_frames): Remove; unused.
2336
435f4c28
PE
2337 * xfaces.c: Make symbols static if they're not exported.
2338 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2339 Remove decls.
2340 * xterm.h (defined_color): Remove decls.
2341 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2342 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2343 (menu_face_changed_default, defined_color, free_realized_face):
2344 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2345 (ascii_face_of_lisp_face): Remove; unused.
2346
8524aef3
PE
2347 * xdisp.c: Make symbols static if they're not exported.
2348 * dispextern.h (scratch_glyph_row, window_box_edges):
2349 (glyph_to_pixel_coords, set_cursor_from_row):
2350 (get_next_display_element, set_iterator_to_next):
2351 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2352 (show_mouse_face): Remove decls
2353 * frame.h (message_buf_print): Likewise.
2354 * lisp.h (pop_message, set_message, check_point_in_composition):
2355 Likewise.
2356 * xterm.h (set_vertical_scroll_bar): Likewise.
2357 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2358 (message_buf_print, scratch_glyph_row, displayed_buffer):
2359 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2360 (get_next_display_element, show_mouse_face, window_box_edges):
2361 (frame_to_window_pixel_xy, check_point_in_composition):
2362 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2363 (glyph_to_pixel_coords): Remove; unused.
2364
16390cd2
PE
2365 * dired.c (file_name_completion): Now static.
2366
2367 * dbusbind.c (xd_in_read_queued_messages): Now static.
2368
a25f4dfa
PE
2369 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2370 * data.c (circular_list_error): Remove.
2371
14a9c8df
PE
2372 * commands.h (last_point_position, last_point_position_buffer):
2373 (last_point_position_window): Remove decls.
2374 * keyboard.c: Make these variables static.
2375
04f2d78b
CB
2376 * coding.h (coding, code_convert_region, encode_coding_gap):
2377 Remove decls.
74ab6df5
PE
2378 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2379 (iso_code_class, detect_coding, code_convert_region): Now static.
2380 (encode_coding_gap): Remove; unused.
2381
38dfbee1
PE
2382 * chartab.c (chartab_chars, chartab_bits): Now static.
2383
a2cb4e63
PE
2384 * charset.h (charset_iso_8859_1): Remove decl.
2385 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2386 Now static.
2387
127198fd
PE
2388 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2389 * ccl.c (Vccl_program_table): Now static.
2390 (check_ccl_update): Remove; unused.
2391
d85b608f
PE
2392 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2393 * category.h: ... from here.
2394 * category.c (check_category_table, set_category_set): Now static.
2395
31cd66f3
PE
2396 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2397 * lisp.h: Remove these decls.
2398
c358e587
PE
2399 * buffer.c (buffer_count): Remove unused var.
2400
e78aecca
PE
2401 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2402 so that it's not optimized away.
2403 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2404 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2405 exported only to the debugger.
2406
e192d7d3 2407 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 2408 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 2409
92470028
PE
2410 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2411 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2412 was inaccessible from Lisp.
2413 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2414 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2415
244ed907
PE
2416 alloc.c: Import and export fewer symbols, and remove unused items.
2417 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2418 is defined.
2419 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2420 it's not optimized away by whole-program optimization.
2421 (message_enable_multibyte, free_misc): Remove.
2422 (catchlist, handlerlist, mark_backtrace):
2423 Declare only if BYTE_MARK_STACK.
2424 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2425 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2426 (message_enable_multibyte): Remove decl.
2427 (free_misc, interval_free_list, float_block, float_block_index):
2428 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2429 (cons_free_list, last_marked_index):
2430 Now static.
2431 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2432 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2433 (mark_backtrace): Define only if BYTE_MARK_STACK.
2434 * xdisp.c (message_enable_multibyte): Now static.
2435
61c2b50e 2436 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
2437 This makes it easier for human readers (and static analyzers)
2438 to see whether these variables are used from other modules.
2439 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2440 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2441 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2442 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2443 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2444 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2445 * xmenu.c, xselect.c:
2446 Declare Q* vars static if they are not used in other modules.
2447 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2448 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2449 Remove decls of unexported vars.
2450 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2451
95c82688
PE
2452 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2453
16a97296
PE
2454 Make Emacs functions such as Fatom 'static' by default.
2455 This makes it easier for human readers (and static analyzers)
2456 to see whether these functions can be called from other modules.
2457 DEFUN now defines a static function. To make the function external
2458 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
2459 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2460 (Finit_image_library):
16a97296
PE
2461 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2462 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2463 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2464 Remove decls, since these functions are now static.
2465 (Funintern, Fget_internal_run_time): New decls, since these functions
2466 were already external.
95c82688 2467
16a97296
PE
2468 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2469 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2470 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2471 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2472 * keyboard.c, keymap.c, lread.c:
2473 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2474 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2475 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2476 Mark functions with DEFUE instead of DEFUN,
2477 if they are used in other modules.
2478 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2479 decls for now-static functions.
2480 * buffer.h (Fdelete_overlay): Remove decl.
2481 * callproc.c (Fgetenv_internal): Mark as internal.
2482 * composite.c (Fremove_list_of_text_properties): Remove decl.
2483 (Fcomposition_get_gstring): New forward static decl.
2484 * composite.h (Fcomposite_get_gstring): Remove decl.
2485 * dired.c (Ffile_attributes): New forward static decl.
2486 * doc.c (Fdocumntation_property): New forward static decl.
2487 * eval.c (Ffetch_bytecode): New forward static decl.
2488 (Funintern): Remove extern decl; now in .h file where it belongs.
2489 * fileio.c (Fmake_symbolic_link): New forward static decl.
2490 * image.c (Finit_image_library): New forward static decl.
2491 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2492 * intervals.h (Fprevious_property_change):
2493 (Fremove_list_of_text_properties): Remove decls.
2494 * keyboard.c (Fthis_command_keys): Remove decl.
2495 (Fcommand_execute): New forward static decl.
2496 * keymap.c (Flookup_key): New forward static decl.
2497 (Fcopy_keymap): Now static.
2498 * keymap.h (Flookup_key): Remove decl.
2499 * process.c (Fget_process): New forward static decl.
2500 (Fprocess_datagram_address): Mark as internal.
2501 * syntax.c (Fsyntax_table_p): New forward static decl.
2502 (skip_chars): Remove duplicate decl.
2503 * textprop.c (Fprevious_property_change): New forward static decl.
2504 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2505 Now internal.
2506 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2507 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2508
785bbd42
PE
2509 * editfns.c (Fformat): Remove unreachable code.
2510
8b913b57
AS
25112011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2512
2513 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2514 change. (Bug#8496)
2515
a6744a35
EZ
25162011-04-13 Eli Zaretskii <eliz@gnu.org>
2517
2518 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2519 when at ZV. (Bug#8487)
2520
e7974947
AS
25212011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2522
baad03f0
AS
2523 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2524 (Bug#8437)
2525 * keyboard.c (parse_tool_bar_item): Likewise.
2526 * sound.c (sound_cleanup, alsa_close): Likewise.
2527 * termcap.c (tgetent): Likewise.
2528 * xfns.c (x_default_font_parameter): Likewise.
2529 * xsettings.c (read_and_apply_settings): Likewise.
2530
e7974947
AS
2531 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2532 (overrun_check_free): Protoize.
2533
28272684
PE
25342011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2535
2536 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2537 since callers should never pass a negative size.
2538 Change the signature to match that of plain 'read' and 'write'; see
2539 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2540 * lisp.h: Update prototypes of emacs_write and emacs_read.
2541
11997c76
EZ
25422011-04-11 Eli Zaretskii <eliz@gnu.org>
2543
2544 * xdisp.c (redisplay_window): Don't try to determine the character
2545 position of the scroll margin if the window start point w->startp
e896f03c 2546 is outside the buffer's accessible region. (Bug#8468)
11997c76 2547
8a2cbd72
EZ
25482011-04-10 Eli Zaretskii <eliz@gnu.org>
2549
2550 Fix write-region and its subroutines for buffers > 2GB.
2551 * fileio.c (a_write, e_write): Modify declaration of arguments and
2552 local variables to support buffers larger than 2GB.
2553 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2554
2555 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2556 argument, local variables, and return value.
2557
2558 * lisp.h: Update prototypes of emacs_write and emacs_read.
2559
2560 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2561
4073e537 25622011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 2563
1ebfdcb6
PE
2564 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2565
b2ded58d
PE
2566 Fix more problems found by GCC 4.6.0's static checks.
2567
7d66342c
PE
2568 * xdisp.c (vmessage): Use a better test for character truncation.
2569
bbf47d44
PE
2570 * charset.c (load_charset_map): <, not <=, for optimization,
2571 and to avoid potential problems with integer overflow.
9248994d 2572 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 2573 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 2574 * editfns.c (Fformat): Likewise.
1e69125e 2575 * syntax.c (skip_chars): Likewise.
3befa583 2576
e3019616
PE
2577 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2578 This also lets GCC 4.6.0 generate slightly better loop code.
2579
becfa255
PE
2580 * callint.c (Fcall_interactively): <, not <=, for optimization.
2581 (Fcall_interactively): Count the number of arguments produced,
2582 not the number of arguments given. This is simpler and lets GCC
2583 4.6.0 generate slightly better code.
2584
dae0cd48
PE
2585 * ftfont.c: Distingish more carefully between FcChar8 and char.
2586 The previous code passed unsigned char * to a functions like
2587 strlen and xstrcasecmp that expect char *, which does not
2588 conform to the C standard.
2589 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2590 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2591 char * when the C standard requires it.
2592
76032d70
PE
2593 * keyboard.c (read_char): Remove unused var.
2594
eb3f1cc8
PE
2595 * eval.c: Port to Windows vsnprintf (Bug#8435).
2596 Include <limits.h>.
2597 (SIZE_MAX): Define if the headers do not.
2598 (verror): Do not give up if vsnprintf returns a negative count.
2599 Instead, grow the buffer. This ports to Windows vsnprintf, which
2600 does not conform to C99. Problem reported by Eli Zaretskii.
2601 Also, simplify the allocation scheme, by avoiding the need for
2602 calling realloc, and removing the ALLOCATED variable.
2603
70476b54
PE
2604 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2605
12020a9e
PE
2606 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2607 But keep the doprint source code for now, as we might revamp it
2608 and use it again (Bug#8435).
ea6c7ae6
PE
2609 * lisp.h (doprnt): Remove.
2610 * Makefile.in (base_obj): Remove doprnt.o.
2611 * deps.mk (doprnt.o): Remove.
2612
5fdb398c
PE
2613 error: Print 32- and 64-bit integers portably (Bug#8435).
2614 Without this change, on typical 64-bit hosts error ("...%d...", N)
2615 was used to print both 32- and 64-bit integers N, which relied on
2616 undefined behavior.
2617 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2618 New macro.
2619 * lisp.h (error, verror): Mark as printf-like functions.
2620 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2621 Report overflow in size calculations when allocating printf buffer.
2622 Do not truncate output string at its first null byte.
2623 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2624 Truncate the output at a character boundary, since vsnprintf does not
2625 do that.
2626 * charset.c (check_iso_charset_parameter): Convert internal
2627 character to string before calling 'error', since %c now has the
2628 printf meaning.
2629 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2630 overflow when computing char to be passed to 'error'. Do not
2631 pass Lisp_Object to 'error'; pass the integer instead.
2632 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2633 formatted with plain %d.
2634
b189fa66
PE
2635 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2636
bff87ef0
PE
2637 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2638
7e2cac20
PE
2639 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2640
ce4d90b5
PE
2641 * xterm.c (x_catch_errors): Remove duplicate declaration.
2642
266c9547
PE
2643 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2644
79c49ad2
PE
2645 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2646
368f4090
JM
26472011-04-10 Jim Meyering <meyering@redhat.com>
2648
2649 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2650 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2651 return ssize_t not "int", and use size_t as the buffer length.
2652 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2653 * gnutls.h: Update declarations.
2654 * process.c (read_process_output): Use ssize_t, to match.
2655 (send_process): Likewise.
2656
a32d4040
CY
26572011-04-09 Chong Yidong <cyd@stupidchicken.com>
2658
2659 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2660
8546720e 26612011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 2662
04f2d78b
CB
2663 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
2664 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 2665
8546720e
GM
2666 * xterm.c (handle_one_xevent):
2667 * xmenu.c (create_and_show_popup_menu):
2668 * xselect.c (x_decline_selection_request)
2669 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 2670
0a2f5c1a 26712011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
2672
2673 Fix some uses of `int' instead of EMACS_INT.
2674 * search.c (string_match_1, fast_string_match)
2675 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2676 (scan_buffer, find_next_newline_no_quit)
2677 (find_before_next_newline, search_command, Freplace_match)
2678 (Fmatch_data): Make some `int' variables be EMACS_INT.
2679
2680 * xdisp.c (display_count_lines): 3rd argument and return value now
2681 EMACS_INT. All callers changed.
2682 (pint2hrstr): Last argument is now EMACS_INT.
2683
2684 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2685 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2686 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2687 (decode_coding_utf_16, decode_coding_emacs_mule)
2688 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2689 (decode_coding_ccl, decode_coding_charset)
2690 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2691 (decode_coding_iso_2022, decode_coding_emacs_mule)
2692 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2693 <char_offset, last_offset>: Declare EMACS_INT.
2694 (encode_coding_utf_8, encode_coding_utf_16)
2695 (encode_coding_emacs_mule, encode_invocation_designation)
2696 (encode_designation_at_bol, encode_coding_iso_2022)
2697 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2698 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2699 Declare EMACS_INT.
2700 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2701 (encode_invocation_designation): Last argument P_NCHARS is now
2702 EMACS_INT.
2703 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2704 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2705
2706 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2707 All users changed.
2708
2709 * ccl.c (Fccl_execute_on_string): Declare some variables
2710 EMACS_INT.
2711
8546720e 27122011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
2713
2714 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2715
4e19a977
CS
27162011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2717
2718 * process.c (Fformat_network_address): Doc fix.
2719
87302331
R
27202011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2721
2722 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2723
cbb59342
CY
27242011-04-08 Chong Yidong <cyd@stupidchicken.com>
2725
2726 * keyboard.c (read_char): Call Lisp function help-form-show,
2727 instead of using internal_with_output_to_temp_buffer.
2728 (Qhelp_form_show): New var.
e0d38eeb 2729 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
2730
2731 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2732
2733 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2734
e67a13ab
CY
27352011-04-06 Chong Yidong <cyd@stupidchicken.com>
2736
04f2d78b
CB
2737 * process.c (Flist_processes): Remove to Lisp.
2738 (list_processes_1): Delete.
e67a13ab 2739
973f782d
EZ
27402011-04-06 Eli Zaretskii <eliz@gnu.org>
2741
7c106b1e
EZ
2742 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2743
973f782d
EZ
2744 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2745
41cf7d1a 27462011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 2747
ca23cc88
PE
2748 Fix more problems found by GCC 4.6.0's static checks.
2749
f390e2d5
PE
2750 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2751
42eea0d0
PE
2752 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2753
b69769da 2754 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 2755
f9541e84
PE
2756 * xdisp.c (vmessage): Mark as a printf-like function.
2757
13841b55
PE
2758 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2759
c136c10f
PE
2760 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2761
5e2d4a30
PE
2762 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2763 printf-like functions.
2764 (tiff_load): Add casts to remove these marks before passing them
2765 to system-supplied API.
2766
583f48b9
PE
2767 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2768
b25d760e
PE
2769 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2770 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
2771 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2772 directly, rather than having caller test rule sign. This avoids
2773 some unnecessary tests.
2774 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2775 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2776 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 2777
bc7b6697 2778 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 2779 (xfont_open): Avoid unnecessary tests.
bc7b6697 2780
27ccc379
PE
2781 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2782
dcd5c89a
PE
2783 * composite.h, composite.c (composition_gstring_put_cache):
2784 Use EMACS_INT, not int, for length.
2785
b13a45c6
PE
2786 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2787 breaking out part of COMPOSITION_DECODE_RULE.
2788 (COMPOSITION_DECODE_RULE): Use it.
2789 * composite.c (get_composition_id): Remove unused local vars,
2790 by using the new macro.
2791
1e792e4d
PE
2792 * textprop.c (set_text_properties_1): Change while to do-while,
2793 since the condition is always true at first.
2794
dc6c6455 2795 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
2796 (interval_deletion_adjustment): Return unsigned value.
2797 All uses changed.
dc6c6455 2798
aba7731a
PE
2799 * process.c (list_processes_1, create_pty, read_process_output):
2800 (exec_sentinel): Remove vars that were set but not used.
afd4052b 2801 (create_pty): Remove unnecessary "volatile"s.
bc57d757 2802 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 2803 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 2804 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 2805
fdfc4bf3
PE
2806 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2807
fca8fe46 2808 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 2809 (update_syntax_table): Use unsigned instead of int.
fca8fe46 2810
06a0259a 2811 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 2812 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 2813 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 2814
e7b9e80f
PE
2815 * print.c (print_error_message): Avoid int overflow.
2816
56201685
PE
2817 * font.c (font_list_entities): Redo for clarity,
2818 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2819
78834453 2820 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 2821 (font_score): Avoid potential overflow in diff calculation.
78834453 2822
0bc0b309 2823 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 2824 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 2825
e610eaca
PE
2826 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2827
b895abce
PE
2828 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2829 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2830 can always succeed if overflow has undefined behavior.
2831
1f1d9321 2832 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 2833 (wordify): Omit three unnecessary tests.
1f1d9321 2834
c59478bc
PE
2835 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2836 All callers changed. This avoids the need for an unused var.
2837
79b73827
PE
2838 * casefiddle.c (casify_region): Remove var that is set but not used.
2839
a4db5dfe
PE
2840 * dired.c (file_name_completion): Remove var that is set but not used.
2841
43aae36e
PE
2842 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2843
2a47c44d 2844 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 2845 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 2846
a37c69bf
PE
2847 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2848 Check for integer overflow on size calculations.
2849
328ab8e7
PE
2850 * buffer.c (Fprevious_overlay_change): Remove var that is set
2851 but not used.
2852
e5a2a5cb
PE
2853 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2854 Remove vars that are set but not used.
8d84a6eb 2855 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 2856 (timer_check_2): Mark vars as initialized.
e5a2a5cb 2857
a60e5f68
PE
2858 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2859
f661cb61 2860 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 2861 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 2862
f0397f5a
PE
2863 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2864 that are set but not used.
2865
8664db06 2866 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 2867 if XCreateBitmapFromData fails (Bug#8410).
8664db06 2868
6abdaa4a
PE
2869 * xselect.c (x_get_local_selection, x_handle_property_notify):
2870 Remove vars that are set but not used.
2871
0ce7538d 2872 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 2873 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 2874
9ae848fc
PE
2875 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2876 Remove var that is set but not used.
0b918413
PE
2877 (scroll_bar_windows_size): Now size_t, not int.
2878 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2879 Check for overflow.
9ae848fc 2880
a5a62657
PE
2881 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2882 (map_tty_color) [!defined MSDOS]: Likewise.
2883
5c5cdd39
PE
2884 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2885
66ebf983
PE
2886 * coding.c: Remove vars that are set but not used.
2887 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2888 All callers changed.
2889 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2890 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2891 (decode_coding_charset): Remove vars that are set but not used.
2892
1be4d761
PE
2893 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2894 that is set but not used.
2895
47553fa8
PE
2896 * print.c (print_object): Remove var that is set but not used.
2897
1f7196bf 2898 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
2899 The gnulib version avoids calling malloc in the usual case,
2900 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2901 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2902 * filelock.c (current_lock_owner): Likewise.
2903 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2904 * sysdep.c: Include allocator.h, careadlinkat.h.
2905 (emacs_no_realloc_allocator): New static constant.
2906 (emacs_readlink): New function.
fdb61804
PE
2907 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2908 ../lib/careadlinkat.h.
d1fdcab7 2909
f84c17c7
SM
29102011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2911
2912 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2913 first non-nil return value).
2914
ef3862ad
JD
29152011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2916
2917 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2918 if not defined (Bug#8403).
2919
376a7006
JB
29202011-04-02 Juanma Barranquero <lekktu@gmail.com>
2921
2922 * xdisp.c (display_count_lines): Remove parameter `start',
2923 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2924 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2925 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2926 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2927 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2928 and thereabouts. All callers changed.
2929 (get_per_char_metric): Remove parameter `f', unused since
2930 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2931
6ca3801d
JM
29322011-04-02 Jim Meyering <meyering@redhat.com>
2933
2934 do not dereference NULL upon failed strdup
2935 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2936 (ns_get_family): Likewise.
2937
d8e2b5ba
JB
29382011-04-02 Juanma Barranquero <lekktu@gmail.com>
2939
2940 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2941
8c74fcbd
JD
29422011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2943
2944 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2945 later (Bug#8403).
2946
7200d79c
SM
29472011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2948
03408648 2949 Add lexical binding.
7200d79c 2950
03408648
SM
2951 * window.c (Ftemp_output_buffer_show): New fun.
2952 (Fsave_window_excursion):
2953 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2954
2955 * lread.c (lisp_file_lexically_bound_p): New function.
2956 (Fload): Bind Qlexical_binding.
2957 (readevalloop): Remove `evalfun' arg.
2958 Bind Qinternal_interpreter_environment.
2959 (Feval_buffer): Bind Qlexical_binding.
2960 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2961 Mark as dynamic.
2962 (syms_of_lread): Declare `lexical-binding'.
2963
2964 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2965
2966 * keyboard.c (eval_dyn): New fun.
2967 (menu_item_eval_property): Use it.
ca105506
SM
2968
2969 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 2970
03408648
SM
2971 * fns.c (concat, mapcar1): Accept byte-code-functions.
2972
2973 * eval.c (Fsetq): Handle lexical vars.
2974 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2975 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2976 (FletX, Flet): Obey lexical binding.
2977 (Fcommandp): Handle closures.
2978 (Feval): New `lexical' arg.
2979 (eval_sub): New function extracted from Feval. Use it almost
2980 everywhere where Feval was used. Look up vars in lexical env.
2981 Handle closures.
2982 (Ffunctionp): Move from subr.el.
2983 (Ffuncall): Handle closures.
2984 (apply_lambda): Remove `eval_flags'.
2985 (funcall_lambda): Handle closures and new byte-code-functions.
2986 (Fspecial_variable_p): New function.
2987 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2988 but without exporting it to Lisp.
23aba0ea 2989
23aba0ea 2990 * doc.c (Fdocumentation, store_function_docstring):
03408648 2991 * data.c (Finteractive_form): Handle closures.
23aba0ea 2992
03408648
SM
2993 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2994 interactive spec.
ba83908c 2995
04f2d78b
CB
2996 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
2997 New byte-codes.
03408648
SM
2998 (exec_byte_code): New function extracted from Fbyte_code to handle new
2999 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 3000
03408648 3001 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 3002
03408648 3003 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 3004
e2abce01
JB
30052011-03-31 Juanma Barranquero <lekktu@gmail.com>
3006
3007 * xdisp.c (redisplay_internal): Fix prototype.
3008
63696a73 30092011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 3010
63696a73 3011 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
3012 (try_scrolling): Use it when setting scroll_limit.
3013 Limit scrolling to 100 screen lines.
63696a73
EZ
3014 (redisplay_window): Even when falling back on "recentering",
3015 position point in the window according to scroll-conservatively,
3016 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3017
3018 (try_scrolling): When point is above the window, allow searching
3019 as far as scroll_max, or one screenful, to compute vertical
3020 distance from PT to the scroll margin position. This prevents
3021 try_scrolling from unnecessarily failing when
3022 scroll-conservatively is set to a value slightly larger than the
3023 window height. Clean up the case of PT below the margin at bottom
3024 of window: scroll_max can no longer be INT_MAX. When aggressive
3025 scrolling is in use, don't let point enter the opposite scroll
3026 margin as result of the scroll.
3027 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
3028 threshold of 100 lines for never-recentering scrolling.
3029
e4cc2dfc
JB
30302011-03-31 Juanma Barranquero <lekktu@gmail.com>
3031
3032 * dispextern.h (move_it_by_lines):
3033 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3034 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3035 (message_log_check_duplicate): Remove parameters `prev_bol' and
3036 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3037 (redisplay_internal): Remove parameter `preserve_echo_area',
3038 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3039
3040 * indent.c (Fvertical_motion):
3041 * window.c (window_scroll_pixel_based, Frecenter):
3042 Don't pass `need_y_p' to `move_it_by_lines'.
3043
1c470562
SM
30442011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3045
44f230aa
SM
3046 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3047 steal a few bits to be more compact.
3048 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3049 Remove unneeded casts.
3050
1c470562
SM
3051 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3052
888adce9
ZK
30532011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3054
3055 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3056 binding" message (bug#7967).
3057
f838ed7b
PE
30582011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3059
77861b95
PE
3060 Fix more problems found by GCC 4.6.0's static checks.
3061
de6dbc14
PE
3062 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3063 Remove unused local var.
3064
f838ed7b
PE
3065 * editfns.c (Fmessage_box): Remove unused local var.
3066
792c7b2b
PE
3067 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3068 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3069 Omit unused local vars.
c499e557 3070 * window.c (shrink_windows): Omit unused local var.
b01a1c29 3071 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
3072 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3073 Omit unused local var.
3074
ba0165e1
PE
3075 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3076 Don't assume string length fits in int.
32ad8845 3077 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 3078 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 3079
3c59b4c9
PE
3080 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3081 instead of alloca (Bug#8344).
3082
a3eed478 3083 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 3084 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 3085
eb4d412d
PE
3086 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3087
1658b401
PE
3088 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3089 concerns.
3090
3091 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3092
3093 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 3094
9a2c6e05
PE
3095 * keyboard.c (syms_of_keyboard): Use the same style as later
3096 in this function when indexing through an array. This also
3097 works around GCC bug 48267.
3098
03d0a109
PE
3099 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3100
44f730c8
PE
3101 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3102
fe75f926
PE
3103 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3104 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3105
ffa8c828
PE
3106 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3107 This avoids undefined behavior on integer overflow, and is a bit
3108 more convenient anyway since it is compared to a size_t variable.
3109
c5101a77
PE
3110 Variadic C functions now count arguments with size_t, not int.
3111 This avoids an unnecessary limitation on 64-bit machines, which
3112 caused (substring ...) to crash on large vectors (Bug#8344).
3113 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3114 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 3115 All variadic functions and their callers changed accordingly.
c5101a77
PE
3116 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3117 * data.c (arith_driver, float_arith_driver): Likewise.
3118 * editfns.c (general_insert_function): Likewise.
3119 * eval.c (struct backtrace.nargs, interactive_p)
3120 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3121 (funcall_lambda, mark_backtrace): Likewise.
3122 * fns.c (concat): Likewise.
3123 * frame.c (x_set_frame_parameters): Likewise.
3124 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3125 0 if not found, not -1. All callers changed.
3126
dd3f25f7
PE
3127 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3128 (stack_copy_size): Now size_t, not int.
3129 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3130
461c2ab9
JB
31312011-03-28 Juanma Barranquero <lekktu@gmail.com>
3132
3133 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3134 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3135 All callers changed.
3136
3137 * lisp.h (multibyte_char_to_unibyte):
3138 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3139 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3140 * character.h (CHAR_TO_BYTE8):
3141 * cmds.c (internal_self_insert):
3142 * editfns.c (general_insert_function):
3143 * keymap.c (push_key_description):
3144 * search.c (Freplace_match):
3145 * xdisp.c (message_dolog, set_message_1): All callers changed.
3146
f6d62986
SM
31472011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3148
3149 * keyboard.c (safe_run_hook_funcall): New function.
3150 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3151 don't set the hook to nil, but remove the offending function instead.
3152 (Qcommand_hook_internal): Remove, unused.
3153 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3154 Vcommand_hook_internal.
3155
3156 * eval.c (enum run_hooks_condition): Remove.
3157 (funcall_nil, funcall_not): New functions.
3158 (run_hook_with_args): Call each function through a `funcall' argument.
3159 Remove `cond' argument, now redundant.
3160 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3161 (Frun_hook_with_args_until_failure): Adjust accordingly.
3162 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3163
1db5b1ad
JB
31642011-03-28 Juanma Barranquero <lekktu@gmail.com>
3165
3166 * dispextern.h (string_buffer_position): Remove declaration.
3167
3168 * print.c (strout): Remove parameter `multibyte', unused since
3169 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3170
3171 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3172 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3173 All callers changed.
3174
3175 * w32.c (_wsa_errlist): Use braces for struct initializers.
3176
3177 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3178 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3179 All callers changed.
3180 (string_buffer_position): Likewise. Also, make static (it's never
3181 used outside xdisp.c).
3182 (cursor_row_p): Remove parameter `w', unused since
3183 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3184 (decode_mode_spec): Remove parameter `precision', introduced during
3185 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3186 All callers changed.
3187
5ffb62aa
JD
31882011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3189
3190 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3191
461c2ab9 31922011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
3193
3194 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3195 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3196 (ns_update_auto_hide_menu_bar): New functions.
3197 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3198 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3199 ns_constrain_all_frames.
3200 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3201 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3202
5c380ffb
JD
32032011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3204
3205 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3206
9af30bdf
GM
32072011-03-27 Glenn Morris <rgm@gnu.org>
3208
3209 * syssignal.h: Replace RETSIGTYPE with void.
3210 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3211 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3212 Replace SIGTYPE with void everywhere.
3213 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3214 * s/template.h (SIGTYPE): Remove commented out definition.
3215
e2abce01
JB
32162011-03-26 Eli Zaretskii <eliz@gnu.org>
3217
3218 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3219 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3220
f868cd8a
JB
32212011-03-26 Juanma Barranquero <lekktu@gmail.com>
3222
59eb0929
JB
3223 * w32.c (read_unc_volume): Use parameter `henum', instead of
3224 global variable `wget_enum_handle'.
3225
3226 * keymap.c (describe_vector): Remove parameters `indices' and
3227 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3228 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3229
f868cd8a
JB
3230 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3231
3232 * keyboard.c (timer_check): Remove parameter `do_it_now',
3233 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3234 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3235 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3236
3237 * keyboard.c (read_char):
3238 * w32menu.c (w32_menu_display_help):
3239 * xmenu.c (show_help_event, menu_help_callback):
3240 Adjust calls to `show_help_echo'.
3241
3242 * gtkutil.c (xg_maybe_add_timer):
3243 * keyboard.c (readable_events):
3244 * process.c (wait_reading_process_output):
3245 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3246
3247 * insdel.c (adjust_markers_gap_motion):
3248 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3249 (gap_left, gap_right): Don't call it.
3250
2ecf6fdb
CY
32512011-03-25 Chong Yidong <cyd@stupidchicken.com>
3252
3253 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3254 incurred during fontification.
3255
6b1f9ba4
JB
32562011-03-25 Juanma Barranquero <lekktu@gmail.com>
3257
3258 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3259 (DEFVAR_PER_BUFFER): Don't pass it.
3260
3261 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3262 (scrolling_window): Don't pass it.
3263
0f4a96b5
JB
32642011-03-25 Juanma Barranquero <lekktu@gmail.com>
3265
3266 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3267
3268 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3269 and `suffix'.
3270 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3271 of variables specific to SELinux and computation of `encoded_absname'.
3272
3273 * image.c (XPutPixel): Remove unused variable `height'.
3274
3275 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3276
3277 * unexw32.c (get_section_info): Remove unused variable `section'.
3278
3279 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3280 (system_process_attributes): Remove unused variable `sess'.
3281 (sys_read): Remove unused variable `err'.
3282
3283 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3284 (w32_wnd_proc): Remove unused variable `isdead'.
3285 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3286 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3287 (x_create_tip_frame): Remove unused variable `tem'.
3288
3289 * w32inevt.c (w32_console_read_socket):
3290 Remove unused variable `no_events'.
3291
3292 * w32term.c (x_draw_composite_glyph_string_foreground):
3293 Remove unused variable `width'.
3294
1149507c
JB
32952011-03-24 Juanma Barranquero <lekktu@gmail.com>
3296
3297 * w32term.c (x_set_glyph_string_clipping):
3298 Don't pass uninitialized region to CombineRgn.
3299
9c88f339
JB
33002011-03-23 Juanma Barranquero <lekktu@gmail.com>
3301
3302 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3303 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3304 (Fx_close_connection): Remove unused variable `i'.
3305
3306 * w32font.c (w32font_draw): Return number of glyphs.
3307 (w32font_open_internal): Remove unused variable `i'.
3308 (w32font_driver): Add missing initializer.
3309
3310 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3311 (fill_in_menu): Remove unused variable `items_added'.
3312
3313 * w32term.c (last_mouse_press_frame): Remove static global variable.
3314 (w32_clip_to_row): Remove unused variable `f'.
3315 (x_delete_terminal): Remove unused variable `i'.
3316
3317 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3318 (NOTHING): Remove unused static global variable.
3319 (uniscribe_check_otf): Remove unused variable `table'.
3320 (uniscribe_font_driver): Add missing initializers.
3321
dee091a3
JD
33222011-03-23 Julien Danjou <julien@danjou.info>
3323
3324 * term.c (Fsuspend_tty, Fresume_tty):
3325 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3326 * window.c (temp_output_buffer_show):
3327 * insdel.c (signal_before_change):
3328 * frame.c (Fhandle_switch_frame):
3329 * fileio.c (Fdo_auto_save):
3330 * emacs.c (Fkill_emacs):
3331 * editfns.c (save_excursion_restore):
3332 * cmds.c (internal_self_insert):
3333 * callint.c (Fcall_interactively):
3334 * buffer.c (Fkill_all_local_variables):
3335 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3336 Use Frun_hooks.
0f4a96b5 3337 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
3338 unconditionnaly since it does the check itself.
3339
2c520ab5 33402011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 3341
c9c49752
PE
3342 Fix more problems found by GCC 4.5.2's static checks.
3343
8abc3f12
PE
3344 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3345 the first time through the loop, since we know p0 < p1 then.
3346 This also avoids a gcc -Wstrict-overflow warning.
3347
a2d26660
PE
3348 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3349 leading to a memory leak, possible in functions like
3350 load_charset_map_from_file that can allocate an unbounded number
b12ef411 3351 of objects (Bug#8318).
a2d26660 3352
916c72e9
PE
3353 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3354 that could (at least in theory) be that large.
3355
19ab8a18
PE
3356 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3357 This is less likely to overflow, and avoids undefined behavior if
3358 overflow does occur. All callers changed. Use strtoul to scan
3359 for the unsigned long integer.
b7cbbd6f
PE
3360 (pint2hrstr): Simplify and tune code slightly.
3361 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 3362
f0641eff
PE
3363 * scroll.c (do_scrolling): Work around GCC bug 48228.
3364 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3365
7f650bb9
PE
3366 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3367 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
3368 (validate_x_resource_name): Simplify count usage.
3369 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 3370
37dd57d1
PE
3371 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3372 fail (Bug#8306).
81e56e61 3373
699979fc 3374 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 3375
401bf9b4
PE
3376 * process.c (Fmake_network_process): Use socklen_t, not int,
3377 where POSIX says socklen_t is required in portable programs.
3378 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 3379 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
3380 (Fmake_network_process, server_accept_connection):
3381 (wait_reading_process_output, read_process_output):
3382 Likewise.
3383
b93aacde
PE
3384 * process.c: Rename or move locals to avoid shadowing.
3385 (list_processes_1, Fmake_network_process):
3386 (read_process_output_error_handler, exec_sentinel_error_handler):
3387 Rename or move locals.
4dc343ee 3388 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 3389 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 3390 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 3391 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 3392 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 3393
af8a867c 3394 Make tparam.h and terminfo.c consistent.
44f230aa
SM
3395 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3396 Include tparam.h instead, since it declares them.
af8a867c
PE
3397 * cm.h (PC): Remove extern decl; tparam.h now does this.
3398 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3399 * terminfo.c: Include tparam.h, to check interfaces.
3400 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3401 (tparam): Adjust signature to match interface in tparam.h;
3402 this removes some undefined behavior. Check that outstring and len
3403 are zero, which they always are with Emacs.
3404 * tparam.h (PC, BC, UP): New extern decls.
3405
0248044d 3406 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 3407 (xftfont_open): Rename locals to avoid shadowing.
0248044d 3408
8ff096c1 3409 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
3410 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3411 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 3412 (ftfont_list): Remove unused local.
49eaafba
PE
3413 (get_adstyle_property, ftfont_pattern_entity):
3414 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3415 Rename locals to avoid shadowing.
8ff096c1 3416
e2be39f6
PE
3417 * xfont.c (xfont_list_family): Mark var as initialized.
3418
c9735e30
PE
3419 * xml.c (make_dom): Now static.
3420
8f5201ae
PE
3421 * composite.c (composition_compute_stop_pos): Rename local to
3422 avoid shadowing.
b246f932
PE
3423 (composition_reseat_it): Remove unused locals.
3424 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 3425 (composition_update_it): Mark var as initialized.
11b61122
PE
3426 (find_automatic_composition): Mark vars as initialized,
3427 with a FIXME (Bug#8290).
8f5201ae 3428
760fbc2c
PE
3429 character.h: Rename locals to avoid shadowing.
3430 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3431 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3432 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3433 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3434 to avoid shadowing.
3435
ff08eb85
PE
3436 * textprop.c (property_change_between_p): Remove; unused.
3437
fc7bf025
PE
3438 * intervals.c (interval_start_pos): Now static.
3439
235d7abc
PE
3440 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3441
44f230aa
SM
3442 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3443 Rename locals to avoid shadowing.
3e7d6594 3444
50060332
PE
3445 * sound.c (wav_play, au_play, Fplay_sound_internal):
3446 Fix pointer signedness.
d01f234b 3447 (alsa_choose_format): Remove unused local var.
c83b8872
PE
3448 (wav_play): Initialize a variable to 0, to prevent undefined
3449 behavior (Bug#8278).
50060332 3450
c4fc4e30
PE
3451 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3452
918436ed
PE
3453 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3454
c939f91b
PE
3455 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3456 clobbering (Bug#8298).
b9c7f648
PE
3457 * sysdep.c (sys_subshell): Likewise.
3458 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 3459
6bd8c144
PE
3460 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3461 This should get cleaned up, so that child_setup has the
3462 same signature on all platforms.
3463
7710357c 3464 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 3465 (relocate_fd): Rename locals to avoid shadowing.
7710357c 3466
c59da222
CY
34672011-03-22 Chong Yidong <cyd@stupidchicken.com>
3468
3469 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3470 not to be necessary, and produces flickering.
3471
66b87493
GM
34722011-03-20 Glenn Morris <rgm@gnu.org>
3473
3474 * config.in: Remove file.
3475
45b6f6d5
JB
34762011-03-20 Juanma Barranquero <lekktu@gmail.com>
3477
3478 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3479 are now in src/globals.h.
3480 (syms_of_minibuf): Remove spurious & from previous change.
3481
3ec03f7e
LL
34822011-03-20 Leo <sdl.web@gmail.com>
3483
3484 * minibuf.c (completing-read-function): New variable.
3485 (completing-read-default): Rename from completing-read.
3486 (completing-read): Call completing-read-function.
3487
b14e3e21
CY
34882011-03-19 Juanma Barranquero <lekktu@gmail.com>
3489
3490 * xfaces.c (Fx_load_color_file):
3491 Read color file from absolute filename (bug#8250).
3492
f2b726e6
JB
34932011-03-19 Juanma Barranquero <lekktu@gmail.com>
3494
3495 * makefile.w32-in: Update dependencies.
3496
09f6ff02
EZ
34972011-03-17 Eli Zaretskii <eliz@gnu.org>
3498
3499 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3500
29a6015a
PE
35012011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3502
a3a6c54e
PE
3503 Fix more problems found by GCC 4.5.2's static checks.
3504
b766f867
PE
3505 * process.c (make_serial_process_unwind, send_process_trap):
3506 (sigchld_handler): Now static.
3507
be02381c
PE
3508 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3509 That way, the code declares only the vars that it needs.
3510 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3511 * s/cygwin.h (PTY_ITERATION): Likewise.
3512 * s/darwin.h (PTY_ITERATION): Likewise.
3513 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3514
57048744
PE
3515 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3516 * process.c (allocate_pty): Don't declare stb unless it's needed.
3517
7914961c 3518 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
3519 (CONSTANTLIM): Remove; unused.
3520 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3521 Define only if needed.
7914961c 3522
b3967b18
PE
3523 * unexelf.c (unexec): Name an expression,
3524 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
3525 Use a different way to cause a compilation error if anyone uses
3526 n rather than nn, a way that does not involve shadowing.
73366a00 3527 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 3528
29a6015a
PE
3529 * deps.mk (unexalpha.o): Remove; unused.
3530
43cfc33e 3531 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 3532 * unexec.h: New file.
ce701a33
PE
3533 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3534 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3535 Depend on unexec.h.
3536 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3537 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3538 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 3539 Change as necessary to match prototype in unexec.h.
ce701a33 3540
01f44d5a
PE
3541 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3542 shadowing.
4f63c6bb 3543 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 3544
a6670b0b
PE
3545 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3546 Rename locals to avoid shadowing.
3547
cef2010d 3548 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 3549 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 3550
d4d7173a
PE
3551 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3552
f08b802a
PE
3553 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3554 warning when compiling print.c.
3555
3ddb0639
PE
3556 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3557 instead of using an uninitialized var.
5ad03b97 3558 (font_sort_entities): Mark var as initialized.
3ddb0639 3559
170a2692
PE
3560 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3561
e663c700
PE
3562 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3563 pointers to constants.
89bc529a 3564 (font_parse_fcname): Remove unused vars.
7b81e2d0 3565 (font_delete_unmatched): Now static.
ea838e10 3566 (font_get_spec): Remove; unused.
13a547c6
PE
3567 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3568 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3569 Rename or move locals to avoid shadowing.
e663c700 3570
2a80c887 3571 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 3572 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 3573
1384fa33 3574 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 3575 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 3576
8b2c52e9
PE
3577 * alloc.c (mark_backtrace): Move decl from here ...
3578 * lisp.h: ... to here, so that it can be checked.
3579
475545b5 3580 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 3581 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
3582 (lisp_indirect_variable): Name an expression,
3583 to avoid gcc -Wbad-function-cast warning.
1faed8ae 3584 (Fdefvar): Rename locals to avoid shadowing.
475545b5 3585
b1349114 3586 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 3587 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 3588 Use const pointer when appropriate.
b1349114 3589
a2928364
PE
3590 * lisp.h (get_system_name, get_operating_system_release):
3591 Move decls here, to check interfaces.
3592 * process.c (get_operating_system_release): Move decl to lisp.h.
3593 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
3594 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3595 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3596 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
3597 (Fformat_time_string, Fencode_time, Finsert_char):
3598 (Ftranslate_region_internal, Fformat):
3599 Rename or remove local vars to avoid shadowing.
9710023e 3600 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 3601
a415e694
PE
3602 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3603 avoid shadowing.
3604
8ef4622d
PE
3605 * lisp.h (eassert): Check that the argument compiles, even if
3606 ENABLE_CHECKING is not defined.
3607
946f9a5b
PE
3608 * data.c (Findirect_variable): Name an expression, to avoid
3609 gcc -Wbad-function-cast warning.
112396d6 3610 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 3611 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
3612 (Fmake_variable_buffer_local, Fmake_local_variable):
3613 Mark variables as initialized.
52746918 3614 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 3615
e5aab7e7 3616 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
3617 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3618 Rename locals to avoid shadowing.
dff45157
PE
3619 (mark_stack): Move local variables into the #ifdef region where
3620 they're used.
7bc26fdb
PE
3621 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3622 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3623 needed otherwise.
3624 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3625 (GC_STRING_CHARS): Remove; not used.
d40d4be1 3626 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 3627
e5aab7e7
PE
3628 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3629 avoids undefined behavior in theory.
3630
4da60324
PE
3631 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3632
88043301
PE
3633 Use functions, not macros, for up- and down-casing (Bug#8254).
3634 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3635 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3636 to use the following functions instead of these macros.
3637 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3638 EMACS_INT, since callers assume the returned value fits in int.
3639 (upcase1): Likewise, for UPCASE_TABLE.
3640 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 3641 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 3642 the race-condition problem in the old DOWNCASE.
88043301 3643
19ed5445
PE
3644 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3645 Rename locals to avoid shadowing.
3646 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
3647 (regex_compile, re_search_2, re_match_2_internal):
3648 Remove unused local vars.
952db0d7
PE
3649 (FREE_VAR): Rewrite so as not to use empty "else",
3650 which gcc can warn about.
da053e48 3651 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
3652 (RETALLOC_IF): Define only if needed.
3653 (WORDCHAR_P): Likewise. This one is never needed, but is used
3654 only in a comment talking about a compiler bug, so put inside
3655 the #if 0 of that comment.
3656 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3657 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3658 Remove; unused.
19ed5445 3659
1f3561e4 3660 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
3661 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3662 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 3663
ded6f8f7
PE
3664 * search.c (simple_search): Remove unused var.
3665
dbd37a95
PE
3666 * dired.c (compile_pattern): Move decl from here ...
3667 * lisp.h: ... to here, so that it can be checked.
3668 (struct re_registers): New forward decl.
3669
7e47afad
PE
3670 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3671
85f24f61
PE
3672 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3673 All uses changed.
3674 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3675 Rename locals to avoid shadowing.
5671df8f 3676 (Fvertical_motion): Mark locals as initialized.
85f24f61 3677
181aa2be 3678 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 3679 (casify_region): Mark local as initialized.
181aa2be 3680
930d429c
PE
3681 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3682
7082eac6
PE
3683 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3684 New macros, so that the caller can use some names other than
3685 gcpro1, gcpro2, etc.
3686 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3687 of the new macros.
3688 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3689 argument, for consistency with GCPRO2_VAR, etc: it is now the
3690 prefix of the variable, not the variable itself. All uses
3691 changed.
38b2c076
PE
3692 * dired.c (directory_files_internal, file_name_completion):
3693 Rename locals to avoid shadowing.
3694
15206ed9
PE
3695 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3696 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3697 dired.c's scmp function, had undefined behavior.
3698 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3699 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3700 * buffer.h: ... to here, because these macros use current_buffer,
3701 and the new implementation with inline functions needs to have
3702 current_buffer in scope now, rather than later when the macros
3703 are used.
3704 (downcase, upcase1): New static inline functions.
3705 (DOWNCASE, UPCASE1): Reimplement using these functions.
3706 This avoids undefined behavior in expressions like
3707 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3708 from race conditions in accessing the global variables
3709 case_temp1 and case_temp2.
3710 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3711 * lisp.h (case_temp1, case_temp2): Remove their decls.
3712 * character.h (ASCII_CHAR_P): Move from here ...
3713 * lisp.h: ... to here, so that the inline functions mentioned
3714 above can use them.
3715
4a6bea26
PE
3716 * dired.c (directory_files_internal_unwind): Now static.
3717
f14b7e14
PE
3718 * fileio.c (file_name_as_directory, directory_file_name):
3719 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3720 Now static.
2893f146
PE
3721 (file_name_as_directory): Use const pointers when appropriate.
3722 (Fexpand_file_name): Likewise. In particular, newdir might
3723 point at constant storage, so make it a const pointer.
fd4ead52 3724 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
3725 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3726 signedness issues.
f839df0c
PE
3727 (Fset_file_times, Finsert_file_contents, auto_save_error):
3728 Rename locals to avoid shadowing.
f14b7e14 3729
5716756e 3730 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
3731 (Ftry_completion, Fall_completions): Rename or remove locals
3732 to avoid shadowing.
5716756e 3733
b4c3046a
PE
3734 * marker.c (bytepos_to_charpos): Remove; unused.
3735
b45db522
PE
3736 * lisp.h (verify_bytepos, count_markers): New decls,
3737 so that gcc does not warn that these functions aren't declared.
3738
85876d07
PE
3739 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3740 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 3741 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 3742 (copy_text): Remove unused local var.
85876d07 3743
03d78a21 3744 * filelock.c (within_one_second): Now static.
b3dd38ab 3745 (lock_file_1): Rename local to avoid shadowing.
03d78a21 3746
5df8f01b
PE
3747 * buffer.c (fix_overlays_before): Mark locals as initialized.
3748 (fix_start_end_in_overlays): Likewise. This function should be
3749 simplified by using pointers-to-pointers, but that's a different
3750 matter.
b1d876f1 3751 (switch_to_buffer_1): Now static.
8f54f30a
PE
3752 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3753 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 3754
a70072c9 3755 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 3756 Fix pointer signedness issue.
edced198
PE
3757 (sys_subshell): Mark local as volatile if checking for lint,
3758 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 3759 (MAXPATHLEN): Define only if needed.
a70072c9 3760
a0977c44
PE
3761 * process.c (serial_open, serial_configure): Move decls from here ...
3762 * systty.h: ... to here, so that they can be checked.
3763
a884fdcc
PE
3764 * fns.c (get_random, seed_random): Move extern decls from here ...
3765 * lisp.h: ... to here, so that they can be checked.
3766
604efe86 3767 * sysdep.c (reset_io): Now static.
b8950c94 3768 (wait_for_termination_signal): Remove; unused.
604efe86 3769
38fc62d9
PE
3770 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3771 (copy_keymap_item, append_key, push_text_char_description):
3772 Now static.
1004a21a 3773 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 3774 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
3775 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3776 (describe_map_tree):
3777 Rename locals to avoid shadowing.
38fc62d9 3778
2f2650da
PE
3779 * keyboard.c: Declare functions static if they are not used elsewhere.
3780 (echo_char, echo_dash, cmd_error, top_level_2):
3781 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
3782 (read_char, kbd_buffer_get_event, make_lispy_position):
3783 (make_lispy_event, make_lispy_movement, apply_modifiers):
3784 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3785 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3786 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 3787 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 3788 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 3789
a053e86c 3790 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
3791 (mark_kboards): Move decl here ...
3792 * alloc.c (mark_kboards): ... from here.
a053e86c 3793
4752793e
PE
3794 * lisp.h (force_auto_save_soon): New decl.
3795
74f10ca7 3796 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
3797 (DEFINE_DUMMY_FUNCTION): New macro.
3798 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3799 Use it.
c03cd23f
PE
3800 (main): Add casts to avoid warnings
3801 if GCC considers string literals to be constants.
74f10ca7 3802
022e70d4
PE
3803 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3804
59d6fe83
PE
3805 * dbusbind.c: Pointer signedness fixes.
3806 (xd_signature, xd_append_arg, xd_initialize):
3807 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3808 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3809 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3810 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3811
78320123
PE
3812 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3813 if GCC considers string literals to be constants.
49cebcca 3814 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 3815
35ac2a97
SM
38162011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3817
fb103ca9
SM
3818 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3819 (print_preprocess, print_object): New macro to fix last change.
3820
35ac2a97
SM
3821 * print.c (print_preprocess): Don't forget font objects.
3822
62973b41
JB
38232011-03-16 Juanma Barranquero <lekktu@gmail.com>
3824
3825 * emacs.c (USAGE3): Doc fixes.
3826
0e48bb22
AS
38272011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3828
3829 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3830 structure.
3831
7684e57b
JB
38322011-03-14 Juanma Barranquero <lekktu@gmail.com>
3833
3834 * lisp.h (VWindow_system, Qfile_name_history):
3835 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3836 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3837 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3838
3839 * w32select.c: Don't #include "keyboard.h".
c96bbc66 3840 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
3841
3842 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3843 * w32console.c (detect_input_pending, read_input_pending)
3844 (encode_terminal_code):
3845 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3846 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3847 (w32_system_caret_y, Qfile_name_history):
3848 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3849 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3850 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3851 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3852 * w32proc.c (Qlocal, report_file_error):
3853 * w32term.c (Vwindow_system, updating_frame):
3854 * w32uniscribe.c (initialized, uniscribe_font_driver):
3855 Remove unneeded extern declarations.
3856
2aa46d6c
CY
38572011-03-14 Chong Yidong <cyd@stupidchicken.com>
3858
c96bbc66 3859 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 3860
cffc6f3b
CY
38612011-03-13 Chong Yidong <cyd@stupidchicken.com>
3862
3863 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3864 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3865 These macros can no longer be used for assignment.
3866
44f230aa
SM
3867 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3868 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
3869 (record_buffer_markers, fetch_buffer_markers): New functions for
3870 recording and fetching special buffer markers.
3871 (set_buffer_internal_1, set_buffer_temp): Use them.
3872
3873 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3874
3875 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3876
3877 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3878 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3879
3880 * xdisp.c (hscroll_window_tree):
3881 (reconsider_clip_changes): Use PT instead of BUF_PT.
3882
d251f04b
EZ
38832011-03-13 Eli Zaretskii <eliz@gnu.org>
3884
3885 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3886 $(EMACS_ROOT)/lib/intprops.h.
3887
f0c77cd1
PE
38882011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3889
3eca4629
PE
3890 Fix more problems found by GCC 4.5.2's static checks.
3891
7c86ee98
PE
3892 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3893 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
3894 (xg_free_frame_widgets): Make it clear that a local variable is
3895 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
3896 (gdk_window_get_screen): Make it clear that this macro is needed
3897 only if USE_GTK_TOOLTIP.
1e5524e7
PE
3898 (int_gtk_range_get_value): New function, which avoids a diagnostic
3899 from gcc -Wbad-function-cast.
3900 (xg_set_toolkit_scroll_bar_thumb): Use it.
3901 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3902 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
3903 (get_utf8_string, xg_get_file_with_chooser):
3904 Rename locals to avoid shadowing.
3905 (create_dialog): Move locals to avoid shadowing.
7c86ee98 3906
41729b81
PE
3907 * xgselect.c (xg_select): Remove unused var.
3908
f0c77cd1
PE
3909 * image.c (four_corners_best): Mark locals as initialized.
3910 (gif_load): Initialize transparent_p to zero (Bug#8238).
3911 Mark another local as initialized.
ec6cf4c6 3912 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 3913
ce0ad53d 3914 * image.c (clear_image_cache): Now static.
d5d5a617 3915 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 3916 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
3917 (x_edge_detection): Remove unnecessary cast that
3918 gcc -Wbad-function-cast diagnoses.
2037898d 3919 (gif_load): Fix pointer signedness.
6ae141d6
PE
3920 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3921 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 3922
33383987 39232011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 3924
d32df629
PE
3925 Improve quality of tests for time stamp overflow.
3926 For example, without this patch (encode-time 0 0 0 1 1
3927 1152921504606846976) returns the obviously-bogus value (-948597
3928 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3929 reports time overflow. See
3930 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
3931 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3932 * editfns.c: Include limits.h and intprops.h.
3933 (TIME_T_MIN, TIME_T_MAX): New macros.
3934 (time_overflow): Move earlier, to before first use.
3935 (hi_time, lo_time): New functions, for an accurate test for
3936 out-of-range times.
3937 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3938 (Fget_internal_run_time): Don't assume time_t fits in int.
3939 (make_time): Use list2 instead of Fcons twice.
3940 (Fdecode_time): More accurate test for out-of-range times.
3941 (check_tm_member): New function.
3942 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
3943 (lisp_time_argument): Don't rely on undefined left-shift and
3944 right-shift behavior when checking for time stamp overflow.
8be6f318 3945
fe31d94c
PE
3946 * editfns.c (time_overflow): New function, refactoring common code.
3947 (Fformat_time_string, Fdecode_time, Fencode_time):
3948 (Fcurrent_time_string): Use it.
3949
8be6f318
PE
3950 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3951 * dired.c (make_time): Move to ...
3952 * editfns.c (make_time): ... here.
3953 * systime.h: Note the move.
3954
09d9db2c 39552011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 3956
126bc0dc
YM
3957 * fringe.c (update_window_fringes): Remove unused variables.
3958
c47cbdfd
YM
3959 * unexmacosx.c (copy_data_segment): Also copy __got section.
3960 (Bug#8223)
3961
7ac80be9
EZ
39622011-03-12 Eli Zaretskii <eliz@gnu.org>
3963
c96bbc66 3964 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
3965 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3966 Constify `char *' arguments and their references according to
3967 prototypes in tparam.h.
3968
ecb0f94d 3969 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 3970
7ac80be9
EZ
3971 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3972 Adapt all references accordingly.
3973
3974 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3975
ef1fd07e
TT
39762011-03-11 Tom Tromey <tromey@redhat.com>
3977
3978 * buffer.c (syms_of_buffer): Remove obsolete comment.
3979
7ef4b50c
EZ
39802011-03-11 Eli Zaretskii <eliz@gnu.org>
3981
3982 * termhooks.h (encode_terminal_code): Declare prototype.
3983
3984 * msdos.c (encode_terminal_code): Don't declare prototype.
3985
3986 * term.c (encode_terminal_code): Now external again, used by
3987 w32console.c and msdos.c.
3988
44f230aa
SM
3989 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3990 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 3991
4b1ec863 39922011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 3993
1714f52b 3994 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 3995
4b1ec863
PE
3996 * fringe.c (update_window_fringes): Mark locals as initialized
3997 (Bug#8227).
3998 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 3999
524c7aa6
PE
4000 * alloc.c (mark_fringe_data): Move decl from here ...
4001 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4002 to check its interface.
4003 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4004
a5c0af81 4005 * fontset.c (free_realized_fontset): Now static.
7519b8cd 4006 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 4007 (fontset_font): Mark local as initialized.
a9a06e0b 4008 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 4009
b4716021
PE
4010 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4011
811e9bac 4012 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 4013 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
4014 (x_own_selection, Fx_disown_selection_internal): Rename locals
4015 to avoid shadowing.
4016 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 4017
7e3ab302
PE
4018 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4019 so that the caller can use some name other than gcpro1.
4020 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
4021 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4022 (Fx_backspace_delete_keys_p):
4023 Use them to avoid shadowing, and rename vars to avoid shadowing.
4024 (x_decode_color, x_set_name, x_window): Now static.
6b437900 4025 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 4026 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
4027 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4028 Remove unused locals.
7e3ab302
PE
4029 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4030 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4031 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4032 macros.
f78faa98 4033
e2b13473
PE
4034 * xterm.h (x_mouse_leave): New decl.
4035
77f23912
PE
4036 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4037 Remove unused functions.
cdf4ba58
PE
4038 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4039 (x_calc_absolute_position): Now static.
7411c686 4040 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 4041 Don't declare local "event" unless it's used.
ed7bf3a5
PE
4042 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4043 unless they are used.
38d0b34a
PE
4044 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4045 (x_fatal_error_signal): Remove; not used.
a6067996
PE
4046 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4047 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4048 (x_error_catcher, x_connection_closed, x_error_handler):
4049 (x_error_quitter, xembed_send_message, x_iconify_frame):
4050 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 4051 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 4052 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 4053
44f230aa
SM
4054 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4055 Rename or move locals to avoid shadowing.
6b463e58 4056 (tty_defined_color, merge_face_heights): Now static.
5967d051 4057 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
4058 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4059 does not deduce is never used uninitialized.
73719eba
PE
4060 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4061 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 4062
426994c3 4063 * terminal.c (store_terminal_param): Now static.
5489860b 4064
032f1620 4065 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 4066 (set_frame_menubar): Remove unused local.
d4323972 4067 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
4068 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4069 since they might point to immutable storage.
281585b0
PE
4070 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4071 since it's unused otherwise.
032f1620 4072
367c19e5 4073 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 4074 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
4075 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4076 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 4077 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
4078 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4079 does not deduce are never used uninitialized.
70739cbe 4080
07b48fa9
PE
4081 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4082
8868a238 4083 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
4084 * window.c (window_loop, size_window):
4085 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 4086
7e5cf297 4087 * window.c (display_buffer): Now static.
d6550a9f
PE
4088 (size_window): Mark variables that gcc -Wuninitialized
4089 does not deduce are never used uninitialized.
a586633d
PE
4090 * window.h (check_all_windows): New decl, to forestall
4091 gcc -Wmissing-prototypes diagnostic.
5b555da1 4092 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 4093
f6095868
PE
4094 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4095 shadowing.
4096 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
4097 Include <limits.h>.
4098 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4099 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
4100 (load_charset_map): Mark variables that gcc -Wuninitialized
4101 does not deduce are never used uninitialized.
53df7c11 4102 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 4103
f38b440c
PE
4104 * coding.c (coding_set_source, coding_set_destination):
4105 Use "else { /* comment */ }" rather than "else /* comment */;"
4106 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
4107 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4108 a block, when the outer 'i' will do.
4109 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4110 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4111 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4112 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4113 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4114 Rename locals to avoid shadowing.
4115 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
4116 * coding.c (emacs_mule_char, encode_invocation_designation):
4117 Now static, since they're not used elsewhere.
413bb2db 4118 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 4119 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
4120 (decode_coding_emacs_mule): Mark variables that gcc
4121 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
4122 (detect_coding_iso_2022): Initialize a local variable that might
4123 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 4124 this initialization is needed. (Bug#8211)
5f58e762
PE
4125 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4126 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4127 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4128 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4129 Remove unused macros.
f38b440c 4130
232b38b9 4131 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 4132 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 4133 * character.c (string_count_byte8): Likewise.
232b38b9 4134
fb90da1b
PE
4135 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4136 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4137
fb93dbc2
PE
4138 * chartab.c (copy_sub_char_table): Now static, since it's not used
4139 elsewhere.
5c156ace
PE
4140 (sub_char_table_ref_and_range, char_table_ref_and_range):
4141 Rename locals to avoid shadowing.
bbcd0949 4142 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 4143
7d3b3862 4144 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 4145 (BIDI_BOB): Remove unused macro.
7d3b3862 4146
6be7d3da
PE
4147 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4148 deduce are never used uninitialized.
c2ed9c8b 4149 * term.c (encode_terminal_code): Likewise.
6be7d3da 4150
75f8807f 4151 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 4152
50938595
PE
4153 * tparam.h: New file.
4154 * term.c, tparam.h: Include it.
4155 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4156 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4157 Move these decls to tparam.h, and make them agree with what
4158 is actually in tparam.c. The previous trick of using incompatible
4159 decls in different modules does not conform to the C standard.
4160 All callers of tparam changed to use tparam's actual API.
4161 * tparam.c (tparam1, tparam, tgoto):
4162 Use const pointers where appropriate.
4163
fbceeba2
PE
4164 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4165 * cm.h (struct cm): Likewise.
4166 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4167 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4168 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4169 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4170 (turn_on_face, init_tty): Likewise.
4171 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 4172
7f3f1250
PE
4173 * term.c (term_mouse_position): Rename local to avoid shadowing.
4174
e6ca6543
PE
4175 * alloc.c (mark_ttys): Move decl from here ...
4176 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4177
c40f8d15
AS
41782011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4179
4180 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4181
cfe0661d
JB
41822011-03-09 Juanma Barranquero <lekktu@gmail.com>
4183
4184 * search.c (compile_pattern_1): Remove argument regp, unused since
4185 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4186 (compile_pattern): Don't pass it.
4187
0afb4571
J
41882011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4189
4190 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4191 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4192 for ! HAVE_GTK3.
4193 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4194
4195 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4196
4197 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4198 gdk_window_get_screen, gdk_window_get_geometry,
4199 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4200 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4201 (xg_get_pixbuf_from_pixmap): New function.
4202 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4203 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4204 Call xg_get_pixbuf_from_pixmap instead of
4205 gdk_pixbuf_get_from_drawable.
4206 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4207 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4208 (xg_check_special_colors): Use GtkStyleContext and its functions
4209 for HAVE_GTK3.
4210 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4211 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4212 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
4213 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4214 Call gtk_widget_get_preferred_size.
0afb4571
J
4215 (xg_frame_resized): gdk_window_get_geometry only takes 5
4216 parameters.
44f230aa
SM
4217 (xg_win_to_widget, xg_event_is_for_menubar):
4218 Call gdk_x11_window_lookup_for_display.
0afb4571
J
4219 (xg_set_widget_bg): New function.
4220 (delete_cb): New function.
895009e1 4221 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
4222 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4223 (xg_set_background_color): Call xg_set_widget_bg.
4224 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4225 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4226 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4227 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4228 if ! HAVE_GTK3.
4229 (update_frame_tool_bar): Call gtk_widget_hide.
4230 (xg_initialize): Use GDK_KEY_g.
4231
4232 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4233 if ! HAVE_GTK3
4234 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4235
4236 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4237 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4238 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4239
1c2cc4ef
JB
42402011-03-08 Juanma Barranquero <lekktu@gmail.com>
4241
4242 * w32xfns.c (select_palette): Check success of RealizePalette against
4243 GDI_ERROR, not zero.
4244
33383987 4245See ChangeLog.11 for earlier changes.
aac0c6e3
MR
4246
4247;; Local Variables:
4248;; coding: utf-8
aac0c6e3
MR
4249;; End:
4250
33383987 4251 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
4252
4253 This file is part of GNU Emacs.
4254
4255 GNU Emacs is free software: you can redistribute it and/or modify
4256 it under the terms of the GNU General Public License as published by
4257 the Free Software Foundation, either version 3 of the License, or
4258 (at your option) any later version.
4259
4260 GNU Emacs is distributed in the hope that it will be useful,
4261 but WITHOUT ANY WARRANTY; without even the implied warranty of
4262 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4263 GNU General Public License for more details.
4264
4265 You should have received a copy of the GNU General Public License
4266 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.