Fix usage of C-x 8 key translations in Isearch.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
5fbfb018
CY
12012-07-18 Chong Yidong <cyd@gnu.org>
2
3 * frame.c (x_set_frame_parameters): Revert bogus change introduced
4 in 2012-05-25 commit by Paul Eggert (Bug#11738).
5
3ab6e069
DA
62012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
7
8 Return more descriptive data from Fgarbage_collect.
9 Suggested by Stefan Monnier in
10 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
11 * alloc.c (bounded_number): New function.
12 (total_buffers, total_vectors): New variable.
13 (total_string_size): Rename to total_string_bytes, adjust users.
14 (total_vector_size): Rename to total_vector_bytes, adjust users.
15 (sweep_vectors): Account total_vectors and total_vector_bytes.
16 (Fgarbage_collect): New return value. Adjust documentation.
17 (gc_sweep): Account total_buffers.
18 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
19 (VECTOR_SIZE): Remove.
20 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
21 (Qinterval, Qmisc): New symbols.
22 (syms_of_data): Initialize them.
23 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
24 (Qcons, Qbuffer): New declarations.
25
6d02fe5b
PE
262012-07-17 Paul Eggert <eggert@cs.ucla.edu>
27
28 * alloc.c (Fmemory_free): Account for memory-free's own storage.
29 Round up, not down. Improve doc.
30
b7ffe040
DA
312012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
32
33 Restore old code in allocate_string_data to avoid Faset breakage.
34 Reported by Julien Danjou <julien@danjou.info> in
35 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
36 * alloc.c (allocate_string_data): Restore old code with minor
37 adjustments, fix comment to explain this subtle issue.
38
4dc7c8d5
SM
392012-07-17 Eli Zaretskii <eliz@gnu.org>
40
41 Remove FILE_SYSTEM_CASE.
42 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
43
44 * fileio.c (FILE_SYSTEM_CASE): Don't define.
45 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
46 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
47 call-process-region passes it through expand-file-name.
48
49 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
50
512012-07-17 Andreas Schwab <schwab@linux-m68k.org>
52
53 Fix crash when creating indirect buffer (Bug#11917)
54 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
55 Don't handle unbound variables specially if non-zero.
56 (Fbuffer_local_variables): Pass zero.
57 (clone_per_buffer_values): Pass non-zero.
58
592012-07-17 Andreas Schwab <schwab@linux-m68k.org>
60
61 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
62 to make the loop interruptible.
63
642012-07-17 Andreas Schwab <schwab@linux-m68k.org>
65
66 * gnutls.c (emacs_gnutls_handshake): Only retry if
67 GNUTLS_E_INTERRUPTED.
68
692012-07-17 Eli Zaretskii <eliz@gnu.org>
cce7fefc
DA
702012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
71
72 Cleanup and convert miscellaneous checks to eassert.
73 * alloc.c (mark_interval): Fix comment, partially rephrase
74 old comment from intervals.h (see below).
75 * intervals.c (find_interval, adjust_intervals_for_insertion)
76 (delete_interval, adjust_intervals_for_deletion)
77 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
78 Convert to eassert.
79 (adjust_intervals_for_insertion, make_new_interval):
80 Remove obsolete and unused code.
81 * intervals.h (struct interval): Remove obsolete comment.
82 * textprotp.c (erase_properties): Remove unused code.
83 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
84 (Fremove_list_of_text_properties): Convert to eassert.
85
9ea10cc3
CY
862012-07-17 Chong Yidong <cyd@gnu.org>
87
88 * editfns.c (Finsert_char): Doc fix.
89
3900d5de
DA
902012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
91
92 Fix previous change to make Fmemory_free always accurate.
93 * alloc.c (make_interval): Update total_free_intervals.
94 (make_float): Likewise for total_free_floats.
95 (free_cons, Fcons): Likewise for total_free_conses.
96 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
97 Likewise for total_free_vector_bytes.
98 (Fmake_symbol): Likewise for total_free_symbols.
99 (bytes_free): Remove.
100
7098646f
DA
1012012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
102
103 Simple free memory accounting feature.
104 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
105 (sweep_vectors): Accumulate size of free vectors.
106 (Fgarbage_collect): Setup bytes_free.
107 (Fmemory_free): New function.
108 (syms_of_alloc): Register it.
109
22657b40
DA
1102012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
111
112 Cleanup overlays checking.
113 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
114 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
115 eassert and OVERLAYP.
116 (sort_overlays): Change to use OVERLAYP.
117
ddfc8813
RK
1182012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
119
120 * editfns.c (Finsert_char): Make it interactive, and make the
121 second arg optional. Copy interactive spec and docstring from
122 ucs-insert.
123
7c26cf3c
PE
1242012-07-17 Paul Eggert <eggert@cs.ucla.edu>
125
126 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
127 Unlike the other wrapped functions, fabs has an unspecified
128 effect on errno.
129
5d127af9
JD
1302012-07-16 Jan Djärv <jan.h.d@swipnet.se>
131
132 * nsterm.m (keyDown): Interpret flags without left/right bits
133 as the left key (Bug#11670).
134
6a0dd1d7
DA
1352012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
136
137 Remove empty and useless init functions.
138 * lisp.h (init_character_once, init_fns, init_image)
139 (init_filelock, init_sound): Remove prototype.
140 * character.c (init_character_once): Remove.
141 * filelock.c (init_filelock): Likewise.
142 * fns.c (init_fns): Likewise.
143 * image.c (init_image): Likewise.
144 * sound.c (init_sound): Likewise.
145 * emacs.c (main): Adjust accordingly.
146
7a6136fd
DA
1472012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
148
149 * gtkutil.h: Tiny cleanups.
150 (use_old_gtk_file_dialog): Remove useless declaration.
151 (xg_uses_old_file_dialog): Add suggested const attribute.
152
ce811ad9
EZ
1532012-07-15 Eli Zaretskii <eliz@gnu.org>
154
155 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
156 (bidi_paragraph_init): Use it to limit search forward for a strong
157 directional character in abnormally large paragraphs full of
158 neutral or weak characters. (Bug#11943)
159
c9adfeaa
SF
1602012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
161
162 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
163 the toolbar (Bug#9451).
164 (xg_make_tool_item): Give the widget event box a transparent
165 background.
166
fff62aa9
DA
1672012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
168
169 Cleanup basic allocation variables and functions.
170 * alloc.c (ignore_warnings, init_intervals, init_float)
171 (init_cons, init_symbol, init_marker): Remove.
172 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
173 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
174 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
175 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
176 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
177 (staticidx, init_alloc_once, init_strings, free_ablock):
178 Remove redundant initialization.
179 * fns.c (init_weak_hash_tables): Remove.
180 * lisp.h (init_weak_hash_tables): Remove prototype.
181
9730daca
DA
1822012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
183
184 Use zero_vector where appropriate.
185 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
186 accordingly.
187 * lisp.h (zero_vector): New declaration.
188 * font.c (null_vector): Remove.
189 (syms_of_font): Remove initialization and staticpro.
190 (font_list_entities, font_find_for_lface): Change to use zero_vector.
191 * keymap.c (Faccessible_keymaps): Likewise.
192
2e2d2a13
LL
1932012-07-15 Leo Liu <sdl.web@gmail.com>
194
195 * fringe.c: Fix typo in comments.
196
cd276f6e
LL
1972012-07-14 Leo Liu <sdl.web@gmail.com>
198
199 * fringe.c: Add a new bitmap exclamation-mark.
200
5a1131d9
EZ
2012012-07-14 Eli Zaretskii <eliz@gnu.org>
202
203 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
204
205 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
206 (HAVE_MENUS): Don't define, defined by editing config.in with
207 msdos/sed2v2.inp.
208 (GMALLOC_INHIBIT_VALLOC): Don't define.
209 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
210
22e983b7
JB
2112012-07-14 Juanma Barranquero <lekktu@gmail.com>
212
213 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
214
5b3f250f
GM
2152012-07-14 Glenn Morris <rgm@gnu.org>
216
217 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
218 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
219 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
220
33d63ff4
GM
2212012-07-13 Glenn Morris <rgm@gnu.org>
222
5b633342
GM
223 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
224
33d63ff4
GM
225 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
226 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
227
b55b9f85
JD
2282012-07-13 Jan Djärv <jan.h.d@swipnet.se>
229
0dc8cf50
JD
230 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
231 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
232 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
233 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
234 where appropriate.
235 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
236 as boolean expression.
237 (x_set_window_size): Remove unused variable toolbar.
238 (ns_get_color_default, ns_mod_to_lisp): Remove.
239 (ns_mouse_position): Remove unused variables xchar and ychar.
240 (ns_compute_glyph_string_overhangs): Remove unused variable face.
241 (ns_set_vertical_scroll_bar): Remove unused variable count.
242 (ns_delete_terminal): Remove unused variable i.
243 (ns_term_init): Remove unused variables r, g and b.
244 (mouseDown): Remove unused variable window.
245 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
246 (initFrameFromEmacs): Remove unused variable vbextra.
247 (mouseEntered): Remove unused variables p and dpyinfo.
248 (mouseExited): Remove unused variables p and r.
249 (ns_define_frame_cursor, ns_clear_frame_area)
250 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
251 (menuDown): Assign [sender tag] to variable and cast the variable.
252
253 * nsterm.h (menuDown): Add id as type to argument sender.
254 (ns_display_info_for_name): Add Lisp_Object argument.
255 (ns_term_init): Add Lisp_Object argument.
256 (ns_map_event_to_object): Add void argument.
257 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
258 prototype with arguments and only declare if __OBJC__.
259 (nxatoms_of_nsselect): Add void argument.
260 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
261 (ns_alloc_autorelease_pool): Add void argument.
262 (ns_release_autorelease_pool): Add void* argument.
263 (ns_get_defaults_value): Add const char* argument.
264
265 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
266 (initFromContents): Use SSDATA where appropriate.
267 (ns_update_menubar): Add braces to ambigous if-else.
268 (initWithTitle): Put () around assignment in if statement.
269 (ns_menu_show): Remove unused variables window and keymap.
270 (update_frame_tool_bar): Remove unused variable selected_p.
271 (initWithContentRect): Remove unused variable this_cmd_name.
272
273 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
274 appropriate.
275 (setXBMColor): Remove unused variable len.
276 (setPixmapData): Put () around assignment in loop statement.
277
278 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
279 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
280 where appropriate.
281 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
282 around assignment in loop statement.
283 (nsfont_open): Remove unused variable i.
284 (nsfont_open): Remove unused variable len.
285 (nsfont_draw): Remove unused variable cs.
286
287 * nsfns.m (x_set_icon_name, ns_set_name_internal)
288 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
289 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
290 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
291 (Fns_font_name, Fns_perform_service)
292 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
293 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
294 (ns_set_name): Remove unused variable view.
295 (x_set_menu_bar_lines): Remove unused variable olines.
296 (x_set_tool_bar_lines): Remove unused variable root_window.
297 (Fns_list_colors): Put () around assignment in while statement.
298 (Fns_perform_service): Remove unused variable len.
299 (Fns_display_usable_bounds): Remove unused variable top.
300 (syms_of_nsfns): Remove unused variable i.
301
b55b9f85
JD
302 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
303 memcpy (Bug#11907).
304
ed9265fc 3052012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
306
307 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
308 and free it with DestroyExceptionInfo (Bug#11558).
309
ef099b57
JB
3102012-07-13 Juanma Barranquero <lekktu@gmail.com>
311
312 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
313 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
314 Set here, not in nt/config.nt.
315
ea814a5d
EZ
3162012-07-13 Eli Zaretskii <eliz@gnu.org>
317
318 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
319 cursor overflow into the last glyph on display line when the right
320 fringe is off. (Bug#11832)
321
1a952767
PE
3222012-07-13 Paul Eggert <eggert@cs.ucla.edu>
323
324 * xdisp.c (produce_special_glyphs): Now static.
325 * dispextern.h (produce_special_glyphs): Remove decl.
326
983188fd
GM
3272012-07-13 Glenn Morris <rgm@gnu.org>
328
32fb4bb6
GM
329 * s/bsd-common, s/cygwin.h: Remove empty files.
330 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
331
983188fd
GM
332 * s/usg5-4-common.h (USG, USG5):
333 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
334 * s/sol2-6.h (SOLARIS2):
335 * s/irix6-5.h (IRIX6_5):
336 * s/hpux10-20.h (USG, USG5, HPUX):
337 * s/gnu-linux.h (USG, GNU_LINUX):
338 * s/freebsd.h (BSD_SYSTEM):
339 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
340 * s/cygwin.h (CYGWIN):
341 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
342 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
343
d1e68667 3442012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
345
346 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 347
6de0e799
GM
3482012-07-13 Glenn Morris <rgm@gnu.org>
349
739ae010
GM
350 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
351
dbee5793
GM
352 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
353
6de0e799
GM
354 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
355 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
356
b82da769
GM
3572012-07-12 Glenn Morris <rgm@gnu.org>
358
4fae5a7a 359 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
360
361 * process.c (init_process_emacs): Rename from init_process.
362 The old name is also the name of a Mach system call.
363 * lisp.h, emacs.c: Update for this name change.
364 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
365 longer needed.
366
5a979817
EZ
3672012-07-12 Eli Zaretskii <eliz@gnu.org>
368
369 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
370 memmove call that removes glyphs covered by the left truncation
371 glyph. Improve commentary.
372 (display_line): Fix display of continuation glyphs on GUI frames
373 when the right fringe is turned off and variable-size fonts are
374 used in the window. Move the code that appends a stretch glyph to
375 produce_special_glyphs, so that it could be used for truncation
376 and continuation glyphs alike.
377 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
378 glyph of a suitably computed width, to align the special glyphs at
379 the window margin. Code moved from display_line. (Bug#11832)
380
3e91a053
GM
3812012-07-12 Glenn Morris <rgm@gnu.org>
382
ba9e4b84
GM
383 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
384
385 * s/gnu-linux.h, s/hpux10-20.h:
386 Do not unconditionally define HAVE_XRMSETDATABASE.
387
3e91a053
GM
388 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
389
b300b1f4
PE
3902012-07-12 Paul Eggert <eggert@cs.ucla.edu>
391
392 Fix typos that broke OS X build.
393 Reported by Randal L. Schwartz in
394 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
395 * nsterm.m (ns_timeout): Add missing local decl.
396 (ns_get_color): snprintf -> sprintf, to fix typo.
397
6e777848
GM
3982012-07-12 Glenn Morris <rgm@gnu.org>
399
3f922c37
GM
400 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
401 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
402 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
403 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
404
0ab7b23a
GM
405 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
406 Move PTY_OPEN to configure.
407
6e777848
GM
408 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
409 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
410 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
411
4a7edc24
DA
4122012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
413
414 Use empty_unibyte_string where applicable.
415 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
416 * lread.c (read1): Likewise.
417 * xsettings.c (syms_of_xsettings): Likewise.
418
308aab79
GM
4192012-07-12 Glenn Morris <rgm@gnu.org>
420
42bd1719
GM
421 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
422 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
423 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
424 * s/hpux10-20.h (RUN_TIME_REMAP):
425 * s/bsd-common.h (TABDLY): Move to configure.
426
427 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
428
429 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
430
ea0bbd17 431 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 432 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
433
434 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 435
308aab79
GM
436 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
437 * s/template.h: Move NARROWPROTO to configure.
438
ee1cf5cf
GM
4392012-07-11 Glenn Morris <rgm@gnu.org>
440
30fe9bf4
GM
441 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
442 unused since 2011-01-17 change to systty.h.
443
ee1cf5cf
GM
444 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
445 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
446 Move HAVE_PTYS and HAVE_SOCKETS to configure.
447
63e47e07
PE
4482012-07-11 Paul Eggert <eggert@cs.ucla.edu>
449
450 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
451
c43fb4c3
GM
4522012-07-11 Glenn Morris <rgm@gnu.org>
453
454 * s/darwin.h, s/gnu-linux.h, s/template.h:
455 Move INTERRUPT_INPUT to configure.
456
e8df9267
DA
4572012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
458
459 Minor adjustments to interning code.
460 * lisp.h (intern, intern_c_string): Redefine as static inline
461 wrappers for intern_1 and intern_c_string_1, respectively.
462 (intern_1, intern_c_string_1): Rename prototypes.
2bce5643
DA
463 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
464 Vobarray checking.
e8df9267
DA
465 * font.c (font_intern_prop): Likewise. Adjust comment.
466 * w32font.c (intern_font_name): Likewise.
467
34348bd4
AS
4682012-07-11 Andreas Schwab <schwab@linux-m68k.org>
469
d96a1e0c
AS
470 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
471
34348bd4
AS
472 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
473 of Fcar/Fcdr if possible.
474 * font.c (check_otf_features): Likewise.
475 * fontset.c (Fnew_fontset): Likewise.
476 * gnutls.c (Fgnutls_boot): Likewise.
477 * minibuf.c (read_minibuf): Likewise.
478 * msdos.c (IT_set_frame_parameters): Likewise.
479 * xmenu.c (Fx_popup_dialog): Likewise.
480 * w32menu.c (Fx_popup_dialog): Likewise.
481
c8add24e
GM
4822012-07-11 Glenn Morris <rgm@gnu.org>
483
4b575b3c
GM
484 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
485 since nothing has defined it on these platforms.
486
09f4e3b0
GM
487 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
488 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
489
172bedef
GM
490 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
491 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
492 Move CLASH_DETECTION to configure.
493
249685df
GM
494 * s/gnu.h: Remove file, which is now empty.
495
c8add24e
GM
496 * s/gnu.h, s/gnu-linux.h:
497 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
498
b41253a3
JW
4992012-07-11 John Wiegley <johnw@newartisans.com>
500
501 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
502 function attribute, so we only use it if it exists in the
503 compiler.
504
d923b542
DA
5052012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
506
507 Avoid call to strlen in fast_c_string_match_ignore_case.
508 * search.c (fast_c_string_match_ignore_case): Change to use
509 length argument. Adjust users accordingly.
510 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
511
5ebbef1d
PE
5122012-07-11 Paul Eggert <eggert@cs.ucla.edu>
513
bb352260
PE
514 Assume mkdir, rmdir.
515 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
516 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
517
57054ddd
PE
518 Assume rename.
519 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
520
b747d3f7
PE
521 Assume perror.
522 * s/hpux10-20.h (HAVE_PERROR): Remove.
523 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
524 Remove dummy definition, as this problem was obsolete long ago.
525
5ebbef1d
PE
526 Assume strerror.
527 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
528
984e7f30
DA
5292012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
530
531 Avoid calls to strlen in font processing functions.
532 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
d923b542 533 (font_open_by_name): Change to use length argument. Adjust
984e7f30 534 users accordingly.
d923b542
DA
535 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
536 Adjust prototypes.
537 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
538 Change to return ptrdiff_t.
984e7f30
DA
539 (xfont_list_pattern, xfont_match): Use length returned by
540 xfont_decode_coding_xlfd.
541 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
542
20e94fdd
GM
5432012-07-11 Glenn Morris <rgm@gnu.org>
544
9d596af3
GM
545 * s/darwin.h, s/freebsd.h, s/netbsd.h:
546 Move DONT_REOPEN_PTY to configure.
547
20e94fdd
GM
548 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
549 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
550
e99a530f
PE
5512012-07-10 Paul Eggert <eggert@cs.ucla.edu>
552
22ffb973
PE
553 Remove "#define unix" that is no longer needed (Bug#11905).
554 * s/aix4-2.h (unix): Remove; no longer needed.
555
e9a9ae03
PE
556 EMACS_TIME simplification (Bug#11875).
557 This replaces macros (which typically do not work in GDB)
558 with functions, typedefs and enums, making the code easier to debug.
559 The functional style also makes code easier to read and maintain.
560 * systime.h: Include <sys/time.h> on all hosts, not just if
561 WINDOWSNT, since 'struct timeval' is needed in general.
562 (EMACS_TIME): Now a typedef, not a macro.
563 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
564 not macros.
565 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
566 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
567 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
568 (EMACS_TIME_LE): Now functions, not macros.
569 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
570 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
571 which are not functions. All uses rewritten to use:
572 (make_emacs_time): New function.
573 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
574 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
575 not functions. All uses rewritten to use the following, respectively:
576 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
577 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 578 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
579 * fileio.c (Fcopy_file):
580 * xterm.c (XTflash): Get the current time closer to when it's used.
581 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
582
ffacb126
PE
583 * bytecode.c (targets): Suppress -Woverride-init warnings.
584
e99a530f
PE
585 Simplify by avoiding confusing use of strncpy etc.
586 * doc.c (Fsnarf_documentation):
587 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
588 * frame.c (Fmake_terminal_frame):
589 * gtkutil.c (get_utf8_string):
590 * lread.c (openp):
591 * nsmenu.m (ns_update_menubar):
592 * regex.c (regerror):
593 Prefer memcpy to strncpy and strncat when either will do.
594 * fileio.c (Fsubstitute_in_file_name):
595 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
596 (menu_separator_name_p):
597 * nsmenu.m (ns_update_menubar):
598 Prefer memcmp to strncmp when either will do.
599 * nsterm.m: Include <ftoastr.h>.
600 (ns_get_color):
601 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
602 Prefer snprintf to strncpy.
603 * nsterm.m (ns_term_init):
604 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
605 * nsterm.m (ns_term_init):
606 Avoid the need for strncpy, by using build_string or
607 make_unibyte_string directly. Use dtoastr, not snprintf.
608 * process.c (Fmake_network_process): Diagnose service names that
609 are too long, rather than silently truncating them or creating
610 non-null-terminated names.
611 (Fnetwork_interface_info): Likewise, for interface names.
612 * sysdep.c (system_process_attributes) [GNU_LINUX]:
613 Prefer sprintf to strncat.
614 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
615 Prefer vsnprintf to vsprintf + strncpy.
616
c59592b3
GM
6172012-07-10 Glenn Morris <rgm@gnu.org>
618
619 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
620 Clarify fallback case.
621
7d7bbefd
DA
6222012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
623
624 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
625 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
626 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 627 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
628 where argument type is known to be a Lisp_Cons.
629
3a4c8000
TT
6302012-07-10 Tom Tromey <tromey@redhat.com>
631
632 * bytecode.c (BYTE_CODE_THREADED): New macro.
633 (BYTE_CODES): New macro. Replaces all old byte-code defines.
634 (enum byte_code_op): New type.
635 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
636 (exec_byte_code): Use them. Use token threading when applicable.
637
2a0213a6
DA
6382012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
639
640 Optimize pure C strings initialization.
641 * lisp.h (make_pure_string): Fix prototype.
642 (build_pure_c_string): New function, defined as static inline. This
643 provides a better opportunity to optimize away calls to strlen when
644 the function is called with compile-time constant argument.
645 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
646 argument, adjust users accordingly. Use build_pure_c_string where
647 appropriate.
648 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
649 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
650 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
651
cb1caeaf
DA
6522012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
653
654 Avoid calls to strlen in miscellaneous functions.
655 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
656 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
657 * lread.c (openp): Likewise.
658
c293e30c
DA
6592012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
660
661 Avoid calls to strlen in path processing functions.
662 * fileio.c (file_name_as_directory): Add comment. Change to add
663 srclen argument and return the length of result. Adjust users
664 accordingly.
665 (directory_file_name): Fix comment. Change to add srclen argument,
cb1caeaf 666 swap 1st and 2nd arguments to obey the common convention. Adjust
c293e30c
DA
667 users accordingly.
668 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
669
9e059e3f
GM
6702012-07-10 Glenn Morris <rgm@gnu.org>
671
d02eb359
GM
672 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
673 Move PENDING_OUTPUT_COUNT definition to configure.
674
882cf227
GM
675 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
676 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
677 * s/gnu.h (DATA_START): Move definitions to configure.
678
af6e839f
GM
679 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
680 We include usg5-4-common.h, which defines them both.
681
40289a12
GM
682 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
683 O_RDONLY already includes it).
684
9e059e3f
GM
685 Stop ns builds setting the EMACSLOADPATH environment variable.
686 * nsterm.m (ns_load_path): Rename from ns_init_paths.
687 Now it does not set EMACSLOADPATH, just returns the load-path string.
688 * nsterm.h: Update accordingly.
689 * lread.c [HAVE_NS]: Include nsterm.h.
690 (init_lread) [HAVE_NS]: Use ns_load_path.
691 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
692
7c4e8ec0
GM
6932012-07-09 Glenn Morris <rgm@gnu.org>
694
d4f600ff
GM
695 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
696 since the included bsd-common.h does so.
697
cbb31951
GM
698 Stop ns builds setting the EMACSPATH environment variable.
699 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
700 (ns_init_paths): Do not set EMACSPATH.
701 * nsterm.h (ns_exec_path): Add it.
702 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
703 Use ns_exec_path.
704
7c4e8ec0
GM
705 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
706
26bccfae
PE
7072012-07-09 Paul Eggert <eggert@cs.ucla.edu>
708
a0bee46f
PE
709 * process.c (wait_reading_process_output): 'waitchannels' was unset
710 when read_kbd || !NILP (wait_for_cell); fix this.
711
5994c183
PE
712 Add GCC-style 'const' attribute to functions that can use it.
713 * character.h (char_resolve_modifier_mask):
714 * keyboard.h (make_ctrl_char):
715 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
716 (init_character_once, next_almost_prime, init_fns, init_image)
717 (flush_pending_output, init_sound):
718 * mem-limits.h (start_of_data):
719 * menu.h (finish_menu_items):
720 Add ATTRIBUTE_CONST.
721 * emacs.c (DEFINE_DUMMY_FUNCTION):
722 Declare the dummy function with ATTRIBUTE_CONST.
723 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
724 Add decls with ATTRIBUTE_CONST.
725
26bccfae
PE
726 Minor improvements to make_formatted_string.
727 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
728 where int is good enough, as vsprintf returns an int.
729 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
730
a8290ec3
DA
7312012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
732
733 Use make_formatted_string to avoid double length calculation.
734 * lisp.h (make_formatted_string): New prototype.
735 * alloc.c (make_formatted_string): New function.
736 * buffer.c (Fgenerate_new_buffer_name): Use it.
737 * dbus.c (syms_of_dbusbind): Likewise.
738 * editfns.c (Fcurrent_time_zone): Likewise.
739 * filelock.c (get_boot_time): Likewise.
740 * frame.c (make_terminal_frame, set_term_frame_name)
741 (x_report_frame_params): Likewise.
742 * image.c (gs_load): Likewise.
743 * minibuf.c (get_minibuffer): Likewise.
744 * msdos.c (dos_set_window_size): Likewise.
745 * process.c (make_process): Likewise.
746 * xdisp.c (ensure_echo_area_buffers): Likewise.
747 * xsettings.c (apply_xft_settings): Likewise.
748
d01ba2f1
GM
7492012-07-09 Glenn Morris <rgm@gnu.org>
750
751 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
752 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
753 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
754 * nsterm.h (ns_etc_directory): Add it.
755 * callproc.c [HAVE_NS]: Include nsterm.h.
756 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
757
f1f924b6
DA
7582012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
759
760 Move marker debugging code under MARKER_DEBUG.
761 * marker.c (MARKER_DEBUG): Move marker debugging code under
762 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
763 for bootstrap with --enable-checking (~3x slowdown reported
764 by Juanma Barranquero <lekktu@gmail.com>).
765 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
766
ab531b66
PE
7672012-07-08 Paul Eggert <eggert@cs.ucla.edu>
768
769 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
770 See <http://bugs.gnu.org/11825#29>.
771
c4b3bc8a
EZ
7722012-07-08 Eli Zaretskii <eliz@gnu.org>
773
774 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
775 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
776 (display_line): Add commentary about displaying truncation glyphs
777 on GUI frames.
778 (produce_special_glyphs): Move here from term.c.
779
780 * term.c (produce_special_glyphs): Move to xdisp.c.
781
782 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
783 section.
c4b3bc8a 784
b676b881
AS
7852012-07-07 Andreas Schwab <schwab@linux-m68k.org>
786
f17c5273
AS
787 * xdisp.c (display_line): Avoid warning about implicit declaration
788 of FRAME_FONT.
789
298819b9
AS
790 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
791
b676b881
AS
792 * lisp.h: Remove empty conditional.
793
6045c4fd
PE
7942012-07-07 Paul Eggert <eggert@cs.ucla.edu>
795
b3350bf9
PE
796 * lread.c (load_path_check): Now static.
797
6045c4fd
PE
798 Fix some minor --with-ns problems found by static checking.
799 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
800 (x_set_font) [!HAVE_X_WINDOWS]:
801 * image.c (xpm_load_image) [HAVE_NS]:
802 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
803 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
804 Remove unused local.
805 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
806 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
807 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
808 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
809 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
810 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
811 Fix pointer signedness problem.
812 * xfaces.c (FRAME_X_FONT_TABLE):
813 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
814
929e7845
GM
8152012-07-07 Glenn Morris <rgm@gnu.org>
816
817 * lread.c (load_path_check): New function, split from init_lread.
818 (init_lread): Reorganize. Motivation:
819 If EMACSLOADPATH is set, check/warn about that rather than the
820 defaults, which we are not going to use. Hence we can remove
821 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
822 Don't warn if site-lisp directories are missing.
823 If not installed, start from a blank load-path, since
824 PATH_LOADSEARCH refers to the eventual installation directories.
825
58dd0aa4
EZ
8262012-07-07 Eli Zaretskii <eliz@gnu.org>
827
828 Support truncation and continuation glyphs on GUI frames, when
829 fringes are disabled. (Bug#11832)
830 * xdisp.c (init_iterator): Get dimensions of truncation and
831 continuation glyphs even if on GUI frames. Adjust
832 it->last_visible_x on GUI frames when the left or right fringes,
833 or both, are absent.
834 (start_display, move_it_in_display_line_to): Handle the case of a
835 GUI frame without a fringe to display continuation or truncation
836 glyphs.
837 (insert_left_trunc_glyphs): Support GUI frames: make sure
838 truncation glyphs overwrite enough glyphs from the current line to
839 have sufficient space in pixels.
840 (display_line): Support truncation and continuation glyphs on GUI
841 frames. If some spare pixels are left on the line after inserting
842 the truncation glyphs, fill that space with a stretch glyph of a
843 suitably computed width.
844
845 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
846 produce_glyphs, to support GUI sessions.
847
31571fd7
PE
8482012-07-07 Paul Eggert <eggert@cs.ucla.edu>
849
5a16b9bc
PE
850 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
851
f3047c75
PE
852 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
853
31571fd7
PE
854 Do not require float-time's arg to fit in time_t (Bug#11825).
855 This works better on hosts where time_t is unsigned, and where
856 float-time is applied to the (negative) difference between two times.
857 * editfns.c (decode_time_components): Last arg is now double *,
858 not int *, and means to store all the result as a double, without
859 worrying about whether the seconds part fits in time_t.
860 All callers changed.
861 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
862 All callers changed.
863 (Ffloat_time): Do not fail merely because the specified time falls
864 outside of time_t range.
865
4516fbef
GM
8662012-07-07 Glenn Morris <rgm@gnu.org>
867
868 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
869 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
870 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
871
07adc2c6
JB
8722012-07-07 Juanma Barranquero <lekktu@gmail.com>
873
874 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
875 Update dependencies.
876
877 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
878
fd573f31
PE
8792012-07-06 Paul Eggert <eggert@cs.ucla.edu>
880
fee5959d
PE
881 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
882 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
883 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
884 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
885 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
886 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
887
fd573f31
PE
888 * xfont.c (compare_font_names): Redo to omit the need for casts.
889
ddadbc0e
AS
8902012-07-06 Andreas Schwab <schwab@linux-m68k.org>
891
fca8d6b6
AS
892 * xfns.c (Fx_change_window_property): Doc fix.
893 * w32fns.c (Fx_change_window_property): Doc fix.
894
ddadbc0e
AS
895 * w32fns.c (Fx_window_property): Accept the same arguments as the
896 X Windows version. Doc fix.
897 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
898
ed9265fc 8992012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
900 Eli Zaretskii <eliz@gnu.org>
901
902 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
903 Windows-specific code from nt/config.nt moved here.
904 Obsolete settings removed.
905
216ee680
PE
9062012-07-06 Paul Eggert <eggert@cs.ucla.edu>
907
908 * process.c: Avoid unnecessary calls to gettime.
909 (wait_reading_process_output): Don't get the time of day
910 when gobbling data immediately and not waiting, as there's no need
911 for it in that case. This removes a FIXME.
912
bdd091e4
JD
9132012-07-06 Jan Djärv <jan.h.d@swipnet.se>
914
915 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
916 is defined (Bug#11768).
917
9d44f8ce
DA
9182012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
919
920 Fix marker debugging code.
921 * marker.c (byte_char_debug_check): Do not perform the check
922 if buffer is not multibyte.
090bd7cb
JB
923 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
924 Call byte_char_debug_check with correct arguments.
9d44f8ce 925
90fc4786
DA
9262012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
927
928 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
929 * marker.c (byte_char_debug_check, count_markers):
930 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
931 (byte_debug_flag): Remove.
932 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
933 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
934
7b7ae965
DA
9352012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
936
4e57b342
DA
937 Avoid code repetition in marker-related functions.
938 * marker.c (attach_marker): New function.
939 (Fset_marker, set_marker_restricted, set_marker_both)
940 (set_marker_restricted_both): Use it.
941 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
942 Consistently rename charno to charpos.
943 (marker_position): Add eassert.
944 (marker_byte_position): Convert to eassert.
945
9462012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
947
948 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 949 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 950 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 951
657924ff
DA
9522012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
953
954 Introduce fast path for the widely used marker operation.
955 * alloc.c (build_marker): New function.
956 * lisp.h (build_marker): New prototype.
957 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
958 * composite.c (autocmp_chars): Likewise.
959 * editfns.c (buildmark): Remove.
960 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
961 (save_restriction_save): Use build_marker.
962 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
963 * window.c (save_window_save): Likewise.
964
041a49a6
DA
9652012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
966
967 Do not use Fdelete_overlay in delete_all_overlays
968 to avoid redundant calls to unchain_overlay.
969 * buffer.c (drop_overlay): New function.
970 (delete_all_overlays, Fdelete_overlay): Use it.
971 * minibuf.c (get_minibuffer): Fix comment.
972
7dca65a4
PE
9732012-07-06 Paul Eggert <eggert@cs.ucla.edu>
974
975 Port to OpenBSD 5.1 amd64.
976 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
977 This is needed for OpenBSD, and should be harmless on all BSD systems.
978 Also, include <sys/sysctl.h>, as it should be available on all
979 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
980 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
981 use p_pid member, not kp_proc.pid.
982
8eb876e2
GM
9832012-07-06 Glenn Morris <rgm@gnu.org>
984
985 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
986
38182d90
PE
9872012-07-05 Paul Eggert <eggert@cs.ucla.edu>
988
989 More xmalloc and related cleanup.
990 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
991 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
992 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
993 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
994 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
995 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
996 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
997 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
998 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
999 * xterm.c:
1000 Omit needless casts involving void * pointers and allocation.
1001 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
1002 as the former is more robust if P's type is changed.
1003 Prefer xzalloc to xmalloc + memset 0.
1004 Simplify malloc-or-realloc to realloc.
1005 Don't worry about xmalloc returning a null pointer.
1006 Prefer xstrdup to xmalloc + strcpy.
1007 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
1008 growing it.
1009 * keyboard.c (apply_modifiers_uncached): Prefer local array to
1010 alloca of a constant.
1011
6dd5a677
EZ
10122012-07-05 Eli Zaretskii <eliz@gnu.org>
1013
1014 * xdisp.c (display_line): Fix horizontal pixel coordinates when
1015 hscroll is larger than the line width. Fixes long and futile
1016 looping inside extend_face_to_end_of_line (on a TTY) producing
1017 glyphs that are not needed and thrown away.
1018
6b312f0f
DA
10192012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1020
1021 * marker.c (set_marker_restricted_both): Simplify by using
1022 clip_to_bounds.
1023
f520ef9b
PE
10242012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1025
1026 * editfns.c (region_limit): Simplify by using clip_to_bounds.
1027
383b7c95
JD
10282012-07-05 Jan Djärv <jan.h.d@swipnet.se>
1029
1030 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
1031 not defined (Bug#11768).
1032 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
1033 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
1034 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
1035 followed by gtk_box_set_homogeneous (Bug#11768).
1036 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
1037 (update_theme_scrollbar_width, xg_create_scroll_bar):
1038 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
1039 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
1040 (is_box_type): New function (Bug#11768).
1041 (xg_tool_item_stale_p): Call is_box_type.
5293d758 1042 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
1043 with default display (Bug#11768).
1044
d6e7bf45
EZ
10452012-07-05 Eli Zaretskii <eliz@gnu.org>
1046
1047 * xdisp.c (window_hscroll_limited): New function.
1048 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
1049 coordinates when window's hscroll is set to insanely large
1050 values. (Bug#11857)
1051
431391ec
JB
10522012-07-05 Juanma Barranquero <lekktu@gmail.com>
1053
1054 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
1055 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
1056
23f86fce
DA
10572012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1058
1059 Cleanup xmalloc.
1060 * lisp.h (xzalloc): New prototype. Omit needless casts.
1061 * alloc.c (xzalloc): New function. Omit needless casts.
1062 * charset.c: Omit needless casts. Convert all calls to
1063 xmalloc with following memset to xzalloc.
1064 * dispnew.c: Likewise.
1065 * fringe.c: Likewise.
1066 * image.c: Likewise.
1067 * sound.c: Likewise.
1068 * term.c: Likewise.
1069 * w32fns.c: Likewise.
1070 * w32font.c: Likewise.
1071 * w32term.c: Likewise.
1072 * xfaces.c: Likewise.
1073 * xfns.c: Likewise.
1074 * xterm.c: Likewise.
1075 * atimer.c: Omit needless casts.
1076 * buffer.c: Likewise.
1077 * callproc.c: Likewise.
1078 * ccl.c: Likewise.
1079 * coding.c: Likewise.
1080 * composite.c: Likewise.
1081 * doc.c: Likewise.
1082 * doprnt.c: Likewise.
1083 * editfns.c: Likewise.
1084 * emacs.c: Likewise.
1085 * eval.c: Likewise.
1086 * filelock.c: Likewise.
1087 * fns.c: Likewise.
1088 * gtkutil.c: Likewise.
1089 * keyboard.c: Likewise.
1090 * lisp.h: Likewise.
1091 * lread.c: Likewise.
1092 * minibuf.c: Likewise.
1093 * msdos.c: Likewise.
1094 * print.c: Likewise.
1095 * process.c: Likewise.
1096 * region-cache.c: Likewise.
1097 * search.c: Likewise.
1098 * sysdep.c: Likewise.
1099 * termcap.c: Likewise.
1100 * terminal.c: Likewise.
1101 * tparam.c: Likewise.
1102 * w16select.c: Likewise.
1103 * w32.c: Likewise.
1104 * w32reg.c: Likewise.
1105 * w32select.c: Likewise.
1106 * w32uniscribe.c: Likewise.
1107 * widget.c: Likewise.
1108 * xdisp.c: Likewise.
1109 * xmenu.c: Likewise.
1110 * xrdb.c: Likewise.
1111 * xselect.c: Likewise.
1112
0497dc44
PE
11132012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1114
1115 * fileio.c (time_error_value): Check the right error number.
1116 Problem reported by Troels Nielsen in
1117 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
1118
356e7178
PE
11192012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1120
4e71fd89
PE
1121 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
1122 This should be fixed in a better way; see Eli Zaretskii in
1123 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
1124 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
1125
f0941253
PE
1126 * fileio.c (time_error_value): Rename from special_mtime.
1127 The old name's problems were noted by Eli Zaretskii in
1128 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
1129
065c9eb4
PE
1130 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
1131 This variable's comment says Emacs needs at least one GDB-visible
1132 symbol of type enum pvec_type, to work around GDB problems.
1133 The symbol's value doesn't matter.
1134
356e7178
PE
1135 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
1136 that causes compilation to fail on pre-C99 compilers.
1137
ed9265fc 11382012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
1139
1140 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
1141 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
1142
3884d954
DA
11432012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1144
d209e2fb 1145 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
1146 headers for buffer_defaults and buffer_local_symbols.
1147 Reported by Juanma Barranquero <lekktu@gmail.com>.
1148
ee28be33
SM
11492012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1150
1151 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
1152 * lisp.h (enum pvec_type): Use fewer bits.
1153 (PSEUDOVECTOR_SIZE_BITS): New constant.
1154 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
1155 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
1156 change in pvec_type.
1157 (PSEUDOVECTOR_TYPEP): New macro.
1158 (TYPED_PSEUDOVECTORP): Use it.
1159 * fns.c (internal_equal): Adapt code to extract pvectype.
1160 * emacs.c (gdb_pvec_type): Update type.
1161 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
1162 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
1163 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
1164 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
1165 (sweep_vectors): Use it. Use local var `total_bytes' instead of
1166 abusing vector->header.next.nbytes.
1167 (live_vector_p): Use PVEC_TYPE.
1168 (mark_object): Adapt code to extract pvectype. Use switch.
1169
c7f2cd7f
PE
11702012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1171
1172 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
1173 Tighten new eassert a bit.
1174
8ce70ed2
DA
11752012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1176
1177 Fix compilation with --enable-gcc-warnings and -O1
1178 optimization level.
1179 * doprnt.c (doprnt): Change type of tem to int, initialize
1180 to avoid compiler warning. Add eassert.
1181 * search.c (simple_search): Initialize match_byte to avoid
1182 compiler warning. Add eassert.
1183
dea7f1e5
PE
11842012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1185
24a212eb
PE
1186 Avoid weird behavior with large horizontal scrolls.
1187 Without this change, for example, large hscroll values would
1188 mess up Emacs's display on Fedora 15 x86, presumably due to
1189 overflows in int calculations in the display code.
1190 Also, if buffers had long lines, Emacs would freeze.
1191 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
1192 (set_window_hscroll): New function, containing the old guts of
1193 Fset_window_hscroll. Return the clipped value.
1194 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
1195 This avoids the need to check against PTRDIFF_MAX.
1196
dea7f1e5
PE
1197 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
1198
76046526
DA
11992012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1200
1201 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
1202
39adff0d
PE
12032012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1204
63807d47
PE
1205 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
1206 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
1207 since GCC 4.4.6 issues a bogus warning for them.
1208
39adff0d
PE
1209 Fix bugs in file timestamp newness comparisons.
1210 * fileio.c (Ffile_newer_than_file_p):
1211 * lread.c (Fload): Use full timestamp resolution of files,
1212 not just the 1-second resolution, so that files that are only
1213 slightly newer still count as newer.
1214 * fileio.c (Ffile_newer_than_file_p): Don't assume file
1215 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
1216
dbeed9a6
PE
12172012-07-03 Paul Eggert <eggert@cs.ucla.edu>
1218
1219 * fileio.c: Improve handling of file time marker. (Bug#11852)
1220 (special_mtime): New function.
1221 (Finsert_file_contents, Fverify_visited_file_modtime):
1222 Use it to set special mtime values consistently.
1223
636334d6
AS
12242012-07-03 Andreas Schwab <schwab@linux-m68k.org>
1225
1226 * fileio.c (Finsert_file_contents): Properly handle st_mtime
1227 marker for non-existing file. (Bug#11852)
1228
e2017fe2
GM
12292012-07-03 Glenn Morris <rgm@gnu.org>
1230
1231 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
1232 and did not make it into globals.h).
1233
404dbd37
TT
12342012-07-03 Tom Tromey <tromey@redhat.com>
1235
1236 * window.c (Fset_window_margins, Fset_window_fringes)
1237 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
1238 * textprop.c (Fprevious_property_change): No longer static.
1239 * syntax.c (Fsyntax_table_p): No longer static.
1240 * process.c (Fget_process, Fprocess_datagram_address): No longer
1241 static.
1242 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
1243 * keyboard.c (Fcommand_execute): No longer static.
1244 Remove EXFUN.
1245 * insdel.c (Fcombine_after_change_execute): No longer static.
1246 * image.c (Finit_image_library): No longer static.
1247 * fileio.c (Fmake_symbolic_link): No longer static.
1248 * eval.c (Ffetch_bytecode): No longer static.
1249 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
1250 * doc.c (Fdocumentation_property, Fsnarf_documentation):
1251 No longer static.
404dbd37
TT
1252 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
1253 static.
1254 * dired.c (Ffile_attributes): No longer static.
1255 * composite.c (Fcomposition_get_gstring): No longer static.
1256 * callproc.c (Fgetenv_internal): No longer static.
1257
1258 * ccl.h: Remove EXFUNs.
1259 * buffer.h: Remove EXFUNs.
1260 * dispextern.h: Remove EXFUNs.
1261 * intervals.h: Remove EXFUNs.
1262 * fontset.h: Remove EXFUN.
1263 * font.h: Remove EXFUNs.
1264 * dosfns.c (system_process_attributes): Remove EXFUN.
1265 * keymap.h: Remove EXFUNs.
1266 * lisp.h: Remove EXFUNs.
1267 * w32term.h: Remove EXFUNs.
1268 * window.h: Remove EXFUNs.
1269 * xsettings.h: Remove EXFUN.
1270 * xterm.h: Remove EXFUN.
1271
8e4fd1e1
GM
12722012-07-03 Glenn Morris <rgm@gnu.org>
1273
1274 * lisp.h (Frandom): Make it visible to C.
1275 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
1276 buffer for invisible buffers. (Bug#1229)
1277
ca95b3eb
DA
12782012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1279
1280 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
1281 values which aren't power of 2.
1282 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
1283 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
1284 accordingly.
1285
7555c33f
SM
12862012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
1287
1288 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
1289
1290 * alloc.c (mark_object): Revert part of last patch to use `switch'.
1291
d12e8f5a
DA
12922012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1293
1294 * alloc.c (allocate_vector_block): Remove redundant
1295 calls to mallopt if DOUG_LEA_MALLOC is defined.
1296 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
1297 avoid calls to mallopt if zero_vector is returned.
1298
296094c3
DA
12992012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1300
1301 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
1302 is enabled, avoid dereferencing NULL current_sblock if
1303 running undumped.
1304
36429c89
DA
13052012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1306
1307 Cleanup basic buffer management.
1308 * buffer.h (struct buffer): Change layout to use generic vector
1309 marking code. Fix some comments. Change type of 'clip_changed'
1310 to bitfield. Remove unused #ifndef old.
1311 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
1312 (GET_OVERLAYS_AT): Fix indentation.
1313 (for_each_per_buffer_object_at): New macro.
1314 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
1315 (Fbuffer_local_variables): Use it.
1316 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
1317 * alloc.c (allocate_buffer): Adjust to match new layout of
1318 struct buffer. Fix comment.
1319 (mark_overlay): New function.
1320 (mark_buffer): Use it. Use mark_vectorlike to mark normal
1321 Lisp area of struct buffer.
1322 (mark_object): Use it. Adjust marking of misc objects
1323 and related comments.
1324
3b3e4cac
PE
13252012-07-02 Paul Eggert <eggert@cs.ucla.edu>
1326
1327 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
1328 wrapper that is not needed because the wrapped code is a no-op (zero
1329 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
1330 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
1331
cf5c0175
DA
13322012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
1333
1334 * alloc.c (mark_buffer): Simplify. Remove prototype.
1335 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 1336 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
1337 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
1338 redundant calls to mark_vectorlike for bool vectors.
1339
ca26824c
GM
13402012-06-30 Glenn Morris <rgm@gnu.org>
1341
2e4c5312
GM
1342 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
1343
ca26824c
GM
1344 * epaths.in (PATH_SITELOADSEARCH): New.
1345 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
1346 This is rather than relying on --enable-locallisppath elements
1347 having "site-lisp" in their names. (Bug#10208#25, 11658)
1348
0d23c240
EZ
13492012-06-30 Eli Zaretskii <eliz@gnu.org>
1350
c9240d7a
EZ
1351 * w32proc.c (sys_select): Accept and ignore one more argument.
1352
1353 * w32.c (emacs_gnutls_pull): Call select with one more argument.
1354
0d23c240 1355 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 1356 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
1357
1358 * sysdep.c: Don't include dos.h and dosfns.h.
1359
1360 * process.c (sys_select):
1361 * msdos.c (sys_select): Accept one more argument and ignore it.
1362
1363 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
1364 adapt data types and code to that.
1365
1366 * dosfns.c:
1367 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
1368 which clashes with the gnulib function of the same name.
1369
af5a5a98
AS
13702012-06-30 Andreas Schwab <schwab@linux-m68k.org>
1371
c5e4379c
AS
1372 * font.c (font_style_to_value, font_style_symbolic)
1373 (font_prop_validate_style): Add type checks for values in
1374 font_style_table.
1375
af5a5a98
AS
1376 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
1377 argument.
1378 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
1379 uses.
1380
8d38f461
EZ
13812012-06-29 Eli Zaretskii <eliz@gnu.org>
1382
2e5a6631
EZ
1383 * xdisp.c (try_window_id): Undo last change.
1384
8d38f461
EZ
1385 * w32.c (getwd): Adjust commentary about startup_dir.
1386 (init_environment): Always call sys_access, even in non-MSVC
1387 builds. Don't chdir to the directory of the Emacs executable.
1388 This undoes code from 1997 which was justified by the need to
1389 "avoid conflicts when removing and renaming directories". But its
1390 downside was that every relative file name was being interpreted
1391 relative to the directory of the Emacs executable, which can never
1392 be TRT. In particular, it broke sys_access when called with
1393 relative file names.
1394 (sys_access): Map GetLastError to errno.
1395
2af3565e
DA
13962012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1397
1398 * window.h (struct window): Change type of 'fringes_outside_margins'
1399 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 1400 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
1401 Adjust comment.
1402 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
1403 to ptrdiff_t.
1404
c8d3a25c 14052012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 1406
c8d3a25c
GM
1407 * gnutls.c (emacs_gnutls_handshake):
1408 Add QUIT to make the loop interruptible.
57570cd3 1409
c8d3a25c 14102012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 1411
c8d3a25c
GM
1412 * charset.c (init_charset): Make lack of etc/charsets fatal.
1413
3e984ee8
DA
14142012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1415
1416 * editfns.c (region_limit): Fix type mismatch.
1417
ef884f23
DA
14182012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1419
1420 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
1421 undefined. Convert from xassert to eassert.
1422 * nsmenu.m: Convert from xassert to eassert.
1423 * nsterm.m: Likewise.
1424
7d7e0027
SM
14252012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
1426
1427 * editfns.c (region_limit): Clip to narrowing (bug#11770).
1428
aa754e6a
PE
14292012-06-28 Paul Eggert <eggert@cs.ucla.edu>
1430
1431 Avoid integer overflow on scroll-left and scroll-right.
1432 * window.c (HSCROLL_MAX): New macro.
1433 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
1434 overflow when requested scroll falls outside ptrdiff_t range.
1435
80b00b08
DA
14362012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1437
1438 * window.h (struct window): Change type of 'hscroll',
1439 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
1440 'last_modified' and 'last_overlay_modified' to EMACS_INT.
1441 Adjust users accordingly.
1442 * xdisp.c (try_cursor_movement): Replace type check with eassert.
1443 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
1444 from EMACS_INT to ptrdiff_t.
1445 (make_window): Omit redundant initialization.
1446
62b2bcf6
JB
14472012-06-28 Juanma Barranquero <lekktu@gmail.com>
1448
1449 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
1450
45942c7d
DA
14512012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1452
1453 * window.h (struct window): Change type of 'use_time' and
1454 'sequence_number' from Lisp_Object to int.
1455 * frame.c (make_frame): Adjust users accordingly.
1456 * print.c (print_object): Likewise.
1457 * window.c (select_window, Fwindow_use_time, make_parent_window)
1458 (make_window): Likewise.
1459
e509cfa6
DA
14602012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1461
1462 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
1463 enabled with --enable-checking=[all,glyphs] configure option.
1464 Fix GLYPH_DEBUG usage assuming that it may be undefined,
1465 adjust comments accordingly.
1466 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
1467 undefined, adjust comments accordingly.
1468 * image.c: Likewise.
1469 * scroll.c: Likewise.
1470 * w32fns.c: Likewise.
1471 * w32term.c: Likewise.
1472 * xdisp.c: Likewise.
1473 * xfaces.c: Likewise.
1474 * xfns.c: Likewise.
1475 * xterm.c: Likewise.
1476
a54e2c05
DA
14772012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1478
1479 Generalize run-time debugging checks.
1480 * dispextern.h (XASSERTS): Remove.
1481 * fontset.c (xassert): Remove.
1482 Convert from xassert to eassert.
1483 * alloc.c: Convert from xassert to eassert.
1484 * bidi.c: Likewise.
1485 * dispnew.c: Likewise.
1486 * fns.c: Likewise.
1487 * fringe.c: Likewise.
1488 * ftfont.c: Likewise.
1489 * gtkutil.c: Likewise.
1490 * image.c: Likewise.
1491 * keyboard.c: Likewise.
1492 * menu.c: Likewise.
1493 * process.c: Likewise.
1494 * scroll.c: Likewise.
1495 * sound.c: Likewise.
1496 * term.c: Likewise.
1497 * w32console.c: Likewise.
1498 * w32fns.c: Likewise.
1499 * w32term.c: Likewise.
1500 * window.c: Likewise.
1501 * xdisp.c: Likewise.
1502 * xfaces.c: Likewise.
1503 * xfns.c: Likewise.
1504 * xselect.c: Likewise.
1505 * xterm.c: Likewise.
1506
1ec4b7b2
SM
15072012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
1508
1509 * fns.c (maybe_resize_hash_table): Output message when growing the
1510 purify-hashtable.
1511
2014308a
DA
15122012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1513
1514 * alloc.c (allocate_string_data): Remove dead code.
1515 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
1516 avoid GCC warning about unused macro.
1517
246155eb
DA
15182012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1519
1520 * alloc.c (allocate_string): Omit intervals initialization.
1521 * alloc.c (make_uninit_multibyte_string): Initialize intervals
1522 as in make_pure_string and make_pure_c_string.
1523
43184b7b
DA
15242012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1525
d209e2fb 1526 * alloc.c (allocate_string): Fix last change.
43184b7b 1527
3fe6dd74
DA
15282012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1529
d209e2fb 1530 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
1531 to memset, add explicit initialization where appropriate.
1532
1ba6038a
GM
15332012-06-27 Glenn Morris <rgm@gnu.org>
1534
1535 * lisp.mk (lisp): Remove paths.elc.
1536
c89926a5
CY
15372012-06-27 Chong Yidong <cyd@gnu.org>
1538
1539 * doc.c (Fsubstitute_command_keys): Fix punctuation.
1540
ed6b3510
JW
15412012-06-26 John Wiegley <johnw@newartisans.com>
1542
1ec4b7b2 1543 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
1544 on Mac OS X Lion: __mod_init_func and __mod_term_func.
1545
ed6b3510
JW
1546 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
1547 when building with Clang.
1548
8edd4a2b
SM
15492012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
1550
1551 * eval.c (Fapply): Allow calling it with a single argument.
1552
f6f62d1b
EZ
15532012-06-26 Eli Zaretskii <eliz@gnu.org>
1554
1555 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
1556 _stricmp and _strnicmp.
1557 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
1558
62efea5e
DA
15592012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1560
1561 * alloc.c (allocate_window): Zero out non-Lisp part of newly
1562 allocated window.
1563 (allocate_process): Likewise for new process.
8edd4a2b 1564 (allocate_terminal): Change to use offsetof.
62efea5e
DA
1565 (allocate_frame): Likewise.
1566 * frame.c (make_frame): Omit redundant initialization.
1567 * window.c (make_parent_window): Use memset.
1568 (make_window): Omit redundant initialization.
1569 * process.c (make_process): Omit redundant initialization.
1570 * terminal.c (create_terminal): Likewise.
1571
42997f4d
DA
15722012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1573
1574 * term.c (delete_tty): Remove redundant call to memset.
1575
1130ecfc
DA
15762012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1577
1578 * alloc.c: Remove build_string.
1579 * lisp.h: Define build_string as static inline. This provides
1580 a better opportunity to optimize away calls to strlen when the
1581 function is called with compile-time constant argument.
1582 * image.c (imagemagick_error): Convert to build_string.
1583 * w32proc.c (sys_spawnve): Likewise.
1584 * xterm.c (x_term_init): Likewise.
1585
cf38a720
PE
15862012-06-26 Paul Eggert <eggert@cs.ucla.edu>
1587
99027bdd
PE
1588 Use sprintf return value instead of invoking strlen on result.
1589 In the old days this wasn't portable, since some sprintf
1590 implementations returned char *. But they died out years ago and
1591 Emacs already assumes sprintf returns int.
1592 Similarly for float_to_string.
1593 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
1594 * ccl.c (ccl_driver):
1595 * character.c (string_escape_byte8):
1596 * data.c (Fnumber_to_string):
1597 * doprnt.c (doprnt):
1598 * print.c (print_object):
1599 * xdisp.c (message_dolog):
1600 * xfns.c (syms_of_xfns):
1601 Use sprintf or float_to_string result to avoid need to call strlen.
1602 * data.c (Fnumber_to_string):
1603 Use make_unibyte_string, since the string must be ASCII.
1604 * lisp.h, print.c (float_to_string): Now returns int length.
1605 * term.c (produce_glyphless_glyph):
1606 Use sprintf result rather than recomputing it.
1607
cf38a720
PE
1608 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
1609 * Makefile.in (ALL_CFLAGS):
1610 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
1611 * gmalloc.c, regex.c: Include <config.h> unconditionally.
1612
3511c784
DA
16132012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1614
0a08eb21 1615 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
1616 strcasecmp if available.
1617 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
1618
fb7da12e
AS
16192012-06-25 Andreas Schwab <schwab@linux-m68k.org>
1620
1621 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
1622 Avoid comma operator.
1623 * menu.c (push_submenu_start, push_submenu_end)
1624 (push_left_right_boundary, push_menu_pane): Likewise.
1625 * msdos.c (dos_rawgetc): Likewise.
1626
afa2ffd8
DA
16272012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1628
1629 * xfns.c (xic_create_fontsetname): Remove redundant calls
1630 to memset.
1631
b3b4476b
PE
16322012-06-25 Paul Eggert <eggert@cs.ucla.edu>
1633
4495ff38
PE
1634 * gtkutil.c (get_utf8_string): Remove redundant assignment.
1635 sprintf already null-terminates its output.
1636
b3b4476b
PE
1637 * xfns.c (x_window): Remove redundant cast.
1638
b00876c9
DA
16392012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1640
1641 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
1642 `const char *' to `char *' to avoid compiler warning.
1643
d188e26b
PE
16442012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1645
885d1d74
PE
1646 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
1647 instead of truncating it to 63 (admittedly a generous limit).
1648
d188e26b
PE
1649 * process.c: Fix spelling and caps in comments.
1650
e2f560b1
DN
16512012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
1652
e86db54b 1653 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
1654 * sysdep.c (setpgrp): Remove definition, not used in this file.
1655
7583a3a1
JB
16562012-06-24 Juanma Barranquero <lekktu@gmail.com>
1657
1658 * makefile.w32-in: Update dependencies.
1659
696056c2
EZ
16602012-06-24 Eli Zaretskii <eliz@gnu.org>
1661
1662 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
1663 (SYSTIME_H): Add nt/inc/sys/time.h.
1664
1665 * systime.h [WINDOWSNT]: Include sys/time.h.
1666
1667 * s/ms-w32.h (struct timespec): Definition moved from
1668 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
1669
845ca893
PE
16702012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1671
1672 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
1673 * buffer.h (buffer_slot_type_mismatch):
1674 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1675 * eval.c (unwind_to_catch):
1676 * image.c (my_png_error, my_error_exit):
1677 * keyboard.c (quit_throw_to_read_char, user_error)
1678 (Fexit_recursive_edit, Fabort_recursive_edit):
1679 * lisp.h (die, args_out_of_range, args_out_of_range_3)
1680 (wrong_type_argument, buffer_overflow, __executable_start)
1681 (memory_full, buffer_memory_full, string_overflow, Fthrow)
1682 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
1683 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
1684 (fatal):
1685 (child_setup) [!DOS_NT]:
1686 * lread.c (end_of_file_error, invalid_syntax):
1687 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1688 * puresize.h (pure_write_error):
1689 * search.c (matcher_overflow):
1690 * sound.c (sound_perror, alsa_sound_perror):
1691 * sysdep.c, syssignal.h (croak):
1692 * term.c (maybe_fatal, vfatal):
1693 * textprop.c (text_read_only):
1694 * undo.c (user_error):
1695 * unexmacosx.c (unexec_error):
1696 * xterm.c (x_ins_del_lines, x_delete_glyphs):
1697 Use _Noreturn rather than NO_RETURN.
1698 No need for separate decl merely because of _Noreturn.
1699 * sound.c (sound_warning, parse_sound):
1700 Remove unnecessary forward decls.
1701
f1dd8073
PE
17022012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1703
1704 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
1705 * lisp.h (WAIT_READING_MAX): New macro.
1706 * dispnew.c (Fsleep_for, sit_for):
1707 * keyboard.c (kbd_buffer_get_event):
1708 * process.c (Faccept_process_output):
1709 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
1710 This improves on the previous patch, which introduced a bug
1711 when time_t is unsigned and as wide as intmax_t.
1712 See <http://bugs.gnu.org/9000#51>.
1713
b82c1755
EZ
17142012-06-23 Eli Zaretskii <eliz@gnu.org>
1715
1716 * dispnew.c (sit_for, Fsleep_for):
1717 * keyboard.c (kbd_buffer_get_event):
1718 * process.c (Faccept_process_output): Avoid compiler warnings when
1719 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
1720
ca300656
JB
17212012-06-23 Juanma Barranquero <lekktu@gmail.com>
1722
049ec95b
JB
1723 * makefile.w32-in: Update dependencies.
1724
ca300656
JB
1725 * w32.c (ltime): Add return type and declare static.
1726 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
1727
db7b8d06
PE
17282012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1729
1730 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
1731 Privately reported by Herbert J. Skuhra.
1732 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
1733 All uses changed.
1734 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
1735 not make_lisp_timeval, when the argument is of type EMACS_TIME.
1736
0bd8297f
EZ
17372012-06-23 Eli Zaretskii <eliz@gnu.org>
1738
96512555
EZ
1739 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
1740 last argument of make_unibyte_string.
1741
0bd8297f
EZ
1742 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
1743 language ID in the event parameters.
1744
1745 * w32term.c (w32_read_socket): Put the new keyboard codepage into
1746 event.code, not the obscure "character set ID".
1747
63def6b6
CY
17482012-06-23 Chong Yidong <cyd@gnu.org>
1749
1750 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
1751
e8a02204
EZ
17522012-06-23 Eli Zaretskii <eliz@gnu.org>
1753
388cdec0
EZ
1754 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
1755 * w32.c (fdutimens): New function.
1756
1757 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
1758
1759 * s/ms-w32.h (pselect): Redirect to sys_select.
1760
1761 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
1762
e8a02204
EZ
1763 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
1764 in the logic of incrementing and decrementing the value of
1765 use_relocatable_buffers.
1766
d054f3fb
PE
17672012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1768
1769 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
1770 Privately reported by Herbert J. Skuhra.
1771 [__FreeBSD__]: Remove "*/" typo after "#include".
1772 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
1773 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
1774 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
1775 Don't assume EMACS_TIME and struct timeval are the same type.
1776
d35af63c
PE
17772012-06-22 Paul Eggert <eggert@cs.ucla.edu>
1778
1779 Support higher-resolution time stamps (Bug#9000).
1780 The time stamps are only nanosecond-resolution at the C level,
1781 since that's the best that any real-world system supports now.
1782 But they are picosecond-resolution at the Lisp level, as that's
1783 easy, and leaves room for future OS improvements.
1784
1785 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
1786 (LIBES): Use it.
1787
1788 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
1789 Don't get current time unless it's needed.
1790
1791 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
1792 now provides it if it's absent.
1793 (start_atimer): Port to higher-res time stamps.
1794 Check for time stamp overflow. Don't get current time more
1795 often than is needed.
1796
1797 * buffer.h (struct buffer): Buffer modtime now has high resolution.
1798 Include systime.h, not time.h.
1799 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
1800
1801 * dired.c: Include stat-time.h.
1802 (Ffile-attributes): File times now have higher resolution.
1803
1804 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
1805 (struct image): Timestamp now has higher resolution.
1806
1807 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
1808 has at least microseconds now. All uses removed.
1809 (update_frame, update_single_window, update_window, update_frame_1)
1810 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
1811
1812 * editfns.c (time_overflow): Now extern.
1813 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
1814 (float-time, Fformat_time_string, Fcurrent_time_string)
1815 (Fcurrent_time_zone): Accept and generate higher-resolution
1816 time stamps.
1817 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
1818 (decode_time_components, lisp_seconds_argument): New functions.
1819 (make_time): Now static.
1820 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
1821 Report an error if the time is invalid, rather than having the caller
1822 do that.
1823
1824 * fileio.c: Include <stat-time.h>
1825 (Fcopy_file): Copy higher-resolution time stamps.
1826 Prefer to set the time stamp via a file descriptor if that works.
1827 (Fset_file_times, Finsert_file_contents, Fwrite_region)
1828 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
1829 (Fvisited_file_modtime, Fset_visited_file_modtime):
1830 Support higher-resolution time stamps.
1831
1832 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
1833
1834 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
1835
1836 * image.c (prepare_image_for_display, clear_image_cache)
1837 (lookup_image): Port to higer-resolution time stamps.
1838
1839 * keyboard.c (start_polling, bind_polling_period):
1840 Check for time stamp overflow.
1841 (read_char, kbd_buffer_get_event, timer_start_idle)
1842 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
1843 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
1844 Port to higher-resolution time stamps. Do not assume time_t is signed.
1845 (decode_timer): New function. Timers are now vectors of length 9,
1846 not 8, to accommodate the picosecond component.
1847 (timer_check_2): Use it.
1848
1849 * nsterm.m (select_timeout, timeval_subtract): Remove.
1850 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
1851 as they're a bit more accurate and handle overflow better.
1852 (ns_select): Change prototype to be compatible with pselect.
1853 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
1854 * nsterm.h (ns_select): Adjust prototype.
1855
1856 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
1857 us-resolution time stamps.
1858 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
1859
1860 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
1861
1862 * lisp.h (time_overflow): New decl.
1863 (wait_reading_process_output): First arg is now intmax_t, not int,
1864 to accommodate larger waits.
1865
1866 * process.h (struct Lisp_Process.read_output_delay):
1867 Now counts nanoseconds, not microseconds.
1868 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
1869 EMACS_HAS_USECS.
1870 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
1871 (wait_reading_process_output):
1872 Port to ns-resolution time stamps.
1873 (Faccept_process_output, wait_reading_process_output):
1874 Check for time stamp overflow. Do not assume time_t is signed.
1875 (select_wrapper): Remove; we now use pselect.
1876 (Fprocess_attributes): Now generates ns-resolution time stamps.
1877
1878 * sysdep.c: Include utimens.h. Don't include utime.h
1879 or worry about struct utimbuf; gnulib does that for us now.
1880 (gettimeofday): Remove; gnulib provides a substitute.
1881 (make_timeval): New function.
1882 (set_file_times): Now sets ns-resolution time stamps.
1883 New arg FD; all uses changed.
1884 (time_from_jiffies, ltime_from_jiffies, get_up_time)
1885 (system_process_attributes):
1886 Now returns ns-resolution time stamp. All uses changed.
1887 Check for time stamp overflow.
1888
1889 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
1890 provides a substitute now.
1891
1892 * systime.h: Include timespec.h rather than sys/time.h and time.h,
1893 since it guarantees struct timespec.
1894 (EMACS_TIME): Now struct timespec, so that we can support
1895 ns-resolution time stamps.
1896 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
1897 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
1898 (EMACS_USECS): Remove.
1899 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
1900 so multiply the arg by 1000 before storing it.
1901 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
1902 New macros.
1903 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
1904 Port to ns-resolution time stamps.
1905 (EMACS_TIME_NEG_P): Remove; replaced by....
1906 (EMACS_TIME_SIGN): New macro.
1907 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
1908 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
1909 (set_file_times, make_time, lisp_time_argument): Adjust signature.
1910 (make_timeval, make_lisp_time, decode_time_components): New decls.
1911 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
1912 that it mishandled time_t overflow. You can't compare by subtracting!
1913 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
1914 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
1915
1916 * term.c: Include <sys/time.h>.
1917 (timeval_to_Time): New function, for proper overflow wraparound.
1918 (term_mouse_position, term_mouse_click): Use it.
1919
1920 * undo.c (record_first_change): Support higher-resolution time stamps
1921 in the undo buffer.
1922 (Fprimitive_undo): Use them when restoring time stamps.
1923
1924 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
1925 (w32_get_internal_run_time):
1926 Port to higher-resolution Emacs time stamps.
1927 (ltime): Now accepts single 64-bit integer, as that's more convenient
1928 for callers.
1929
1930 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
1931
1932 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
1933 for compatibility with pselect. Support ns-resolution time stamps.
1934
1935 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
1936
1937 * xselect.c (wait_for_property_change, x_get_foreign_selection):
1938 Check for time stamp overflow, and support ns-resolution time stamps.
1939
1940 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
1941 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
1942 (timeval_subtract): Remove; no longer needed.
1943 (XTflash, XTring_bell, x_wait_for_event):
1944 Port to ns-resolution time stamps. Don't assume time_t is signed.
1945
b6a92dfe
CY
19462012-06-22 Chong Yidong <cyd@gnu.org>
1947
1948 * xdisp.c (x_consider_frame_title): Revert last change.
1949
d251c37c
EZ
19502012-06-22 Eli Zaretskii <eliz@gnu.org>
1951
1952 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
1953 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
1954 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
1955 staticidx goes up to 1597 out of 1600 = 0x640.)
1956
f10deafb
PE
19572012-06-20 Paul Eggert <eggert@cs.ucla.edu>
1958
1959 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
1960 Otherwise, the umask might be mistakenly 0 while handling input signals.
1961
ec6de1e2
SM
19622012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
1963
1964 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
1965
28be1ada
DA
19662012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
1967
1968 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
1969 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
1970 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
1971 access to `contents' member of Lisp_Vector objects with AREF and ASET
1972 where appropriate.
1973
c6bf3022
CY
19742012-06-19 Chong Yidong <cyd@gnu.org>
1975
1976 * frame.c (delete_frame): When selecting a frame on a different
1977 text terminal, do not alter the terminal's top-frame.
1978
1979 * xdisp.c (format_mode_line_unwind_data): Record the target
1980 frame's selected window and its terminal's top-frame.
1981 (unwind_format_mode_line): Restore them.
1982 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
1983 Callers changed.
1984 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
1985 since tty frames can be explicitly named.
1986 (prepare_menu_bars): Likewise.
1987
1988 * term.c (Ftty_top_frame): New function.
1989
defd4196
PE
19902012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1991
1992 Port byte-code-meter to modern targets.
1993 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
1994 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 1995 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
1996 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
1997 (METER_1, METER_2): Simplify.
1998
1053a871
SM
19992012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
2000
2001 * data.c (Fdefalias): Return `symbol' (bug#11686).
2002
b7e8d081
MR
20032012-06-18 Martin Rudalics <rudalics@gmx.at>
2004
2005 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
2006 gets killed during executing of this function (Bug#11665).
2007 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
2008 (Vkill_buffer_query_functions): In doc-string say that functions
2009 run by this hook should not change the current buffer.
2010
7ea2b339
PE
20112012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2012
2013 Fix recently-introduced process.c problems found by static checking.
2014 * process.c (write_queue_push, write_queue_pop, send_process):
2015 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
2016 (write_queue_pop): Fix pointer signedness problem.
2017 (send_process): Remove unused local.
2018
96a313a1
CY
20192012-06-17 Chong Yidong <cyd@gnu.org>
2020
2021 * xdisp.c (redisplay_internal): No need to redisplay terminal
2022 frames that are not on top.
2023
20ca2e94
TN
20242012-06-17 Troels Nielsen <bn.troels@gmail.com>
2025
2026 * process.c (make_process): Initialize write_queue.
2027 (write_queue_push, write_queue_pop): New functions.
2028 (send_process): Use them to maintain correct ordering of process
2029 writes (Bug#10815).
2030
9a900ca9
PE
20312012-06-17 Paul Eggert <eggert@cs.ucla.edu>
2032
310fbfa8
PE
2033 * lisp.h (eassert): Assume C89 or later.
2034 This removes the need for CHECK.
2035 (CHECK): Remove. Its comments about always evaluating its
2036 argument were confusing, as 'eassert' typically does not evaluate
2037 its argument.
2038
27bb1ca4
PE
2039 * coding.c (produce_chars): Use ptrdiff_t, not int.
2040
9a900ca9
PE
2041 * xterm.c (x_draw_underwave): Check for integer overflow.
2042 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
2043
41b7f8bc 20442012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
2045
2046 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
2047 referenced (Bug#11583).
2048
9b0e3eba
AA
20492012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
2050
2051 Implement wave-style variant of underlining.
2052 * dispextern.h (face_underline_type): New enum.
2053 (face): Add field for underline type.
2054 * nsterm.m (ns_draw_underwave): New function.
2055 (ns_draw_text_decoration): Use it.
2056 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
2057 New functions.
2058 (x_draw_glyph_string): Use them.
2059 * xfaces.c (Qline, Qwave): New Lisp objects.
2060 (check_lface_attrs, merge_face_ref)
1053a871
SM
2061 (Finternal_set_lisp_face_attribute, realize_x_face):
2062 Handle wave-style underline face attributes.
9b0e3eba
AA
2063 * xterm.c (x_draw_underwave): New function.
2064 (x_draw_glyph_string): Use it.
2065
0fb52f11
JB
20662012-06-16 Juanma Barranquero <lekktu@gmail.com>
2067
2068 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
2069 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
2070 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
2071 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
2072 ($(BLD)/w32select.$(O)): Update dependencies.
2073
e5560ff7
AS
20742012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2075
2076 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
2077 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
2078 * character.c (_fetch_multibyte_char_p): Remove.
2079 * alloc.c: Include "character.h" before "buffer.h".
2080 * bidi.c: Likewise.
2081 * buffer.c: Likewise.
2082 * bytecode.c: Likewise.
2083 * callint.c: Likewise.
2084 * callproc.c: Likewise.
2085 * casefiddle.c: Likewise.
2086 * casetab.c: Likewise.
2087 * category.c: Likewise.
2088 * cmds.c: Likewise.
2089 * coding.c: Likewise.
2090 * composite.c: Likewise.
2091 * dired.c: Likewise.
2092 * dispnew.c: Likewise.
2093 * doc.c: Likewise.
2094 * dosfns.c: Likewise.
2095 * editfns.c: Likewise.
2096 * emacs.c: Likewise.
2097 * fileio.c: Likewise.
2098 * filelock.c: Likewise.
2099 * font.c: Likewise.
2100 * fontset.c: Likewise.
2101 * fringe.c: Likewise.
2102 * indent.c: Likewise.
2103 * insdel.c: Likewise.
2104 * intervals.c: Likewise.
2105 * keyboard.c: Likewise.
2106 * keymap.c: Likewise.
2107 * lread.c: Likewise.
2108 * macros.c: Likewise.
2109 * marker.c: Likewise.
2110 * minibuf.c: Likewise.
2111 * nsfns.m: Likewise.
2112 * nsmenu.m: Likewise.
2113 * print.c: Likewise.
2114 * process.c: Likewise.
2115 * regex.c: Likewise.
2116 * region-cache.c: Likewise.
2117 * search.c: Likewise.
2118 * syntax.c: Likewise.
2119 * term.c: Likewise.
2120 * textprop.c: Likewise.
2121 * undo.c: Likewise.
2122 * unexsol.c: Likewise.
2123 * w16select.c: Likewise.
2124 * w32fns.c: Likewise.
2125 * w32menu.c: Likewise.
2126 * window.c: Likewise.
2127 * xdisp.c: Likewise.
2128 * xfns.c: Likewise.
2129 * xmenu.c: Likewise.
2130 * xml.c: Likewise.
2131 * xselect.c: Likewise.
2132
2f07e6af
EZ
21332012-06-16 Eli Zaretskii <eliz@gnu.org>
2134
1053a871
SM
2135 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
2136 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 2137 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
2138 row.
2139 (handle_face_prop): Use chunk-relative overlay string index when
2140 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
2141 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
2142 the rightmost. (Bug#11720)
2f07e6af 2143
29b83cec
AS
21442012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2145
2146 * category.h (CHAR_HAS_CATEGORY): Define as inline.
2147 (CATEGORY_MEMBER): Enforce 1/0 value.
2148 * category.c (_temp_category_set): Remove.
2149
4c5501e9
EZ
21502012-06-16 Eli Zaretskii <eliz@gnu.org>
2151
2152 * window.c (Fdelete_other_windows_internal)
2153 (Fdelete_window_internal): Don't access frame's mouse highlight
2154 info of the initial frame. (Bug#11677)
2155
2b570124
PE
21562012-06-14 Paul Eggert <eggert@cs.ucla.edu>
2157
e93864f9
PE
2158 * .gdbinit (xgetint): Fix recently-introduced paren typo.
2159 Assume USE_2_TAGS_FOR_INTS.
2160 (xreload): Adjust $tagmask width to match recent lisp.h change.
2161
2b570124
PE
2162 Simplify lisp.h in minor ways that should not affect code.
2163 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
2164 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
2165 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
2166 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
2167 (INTTYPEBITS): New macro, for clarity.
2168 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
2169 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
2170 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
2171 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
2172 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
2173
81755f69
JB
21742012-06-13 Juanma Barranquero <lekktu@gmail.com>
2175
2176 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
2177
16192a57
GM
21782012-06-13 Glenn Morris <rgm@gnu.org>
2179
2180 * s/bsd-common.h (BSD4_3):
2181 * s/usg5-4-common.h (USG5_4): No longer define; unused.
2182
646b5f55
AS
21832012-06-13 Andreas Schwab <schwab@linux-m68k.org>
2184
2185 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
2186 instead of union.
2187 (XLI, XIL): Define.
1053a871
SM
2188 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
2189 Use them.
2190 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 2191 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 2192 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
2193 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
2194 * frame.c (delete_frame): Remove outdated comment.
2195 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
2196 USE_LISP_UNION_TYPE.
2197 (Fw32_unregister_hot_key): Likewise.
2198 (Fw32_toggle_lock_key): Likewise.
2199 * w32menu.c (add_menu_item): Likewise.
2200 (w32_menu_display_help): Use XIL instead of checking
2201 USE_LISP_UNION_TYPE.
2202 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
2203 (init_heap): Likewise.
2204 * w32term.c (w32_read_socket): Update comment.
2205
1d3823c9
GM
22062012-06-13 Glenn Morris <rgm@gnu.org>
2207
c62ff706
GM
2208 * s/usg5-4-common.h, src/s/unixware.h:
2209 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
2210
1d3823c9
GM
2211 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
2212
bfe3e0a2
PE
22132012-06-13 Paul Eggert <eggert@cs.ucla.edu>
2214
2215 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
2216 * alloc.c (make_number) [!defined make_number]:
2217 Remove, as lisp.h always defines this now.
2218 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
2219 (roundup_size): Verify that it is a power of 2.
2220 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
2221 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
2222 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
2223 -DUSE_LSB_TAG=0, to override the automatically-selected default.
2224 USE_LSB_TAG now is always defined to be either 0 or 1.
2225 All uses changed.
2226 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
2227 code works fine either way, and efficiency is not a concern here,
2228 as the union type is for debugging, not for production.
2229 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
2230 Use an inline function on all platforms when using the union type,
2231 since this is simpler and 'static inline' can be used portably
2232 within Emacs now.
2233 (LISP_INITIALLY_ZERO): New macro.
2234 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
2235 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
2236
45fa9c0f
GM
22372012-06-12 Glenn Morris <rgm@gnu.org>
2238
b4492cba
GM
2239 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
2240
2241 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 2242
45fa9c0f
GM
2243 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
2244 Move BROKEN_SIGIO to configure.
2245
2246 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
2247 Move NO_TERMIO to configure.
2248
0e25d334
CY
22492012-06-12 Chong Yidong <cyd@gnu.org>
2250
2251 * image.c (imagemagick_load_image): Use MagickFlattenImage if
2252 MagickMergeImageLayers is undefined. Use pixel pusher loop if
2253 MagickExportImagePixels is undefined.
2254
43682bb6
PE
22552012-06-12 Paul Eggert <eggert@cs.ucla.edu>
2256
2257 * image.c (imagemagick_load_image): Remove unused label.
2258
a9be7d2b
GM
22592012-06-11 Glenn Morris <rgm@gnu.org>
2260
2261 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
2262 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
2263 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
2264 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
2265
3017f87f
SM
22662012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
2267
2268 * alloc.c (make_byte_code): New function.
2269 (Fmake_byte_code): Use it. Don't purify here.
2270 * lread.c (read1): Use it as well to avoid extra allocation.
2271
1b9b4cf4
CY
22722012-06-11 Chong Yidong <cyd@gnu.org>
2273
2274 * image.c (imagemagick_load_image): Implement transparency.
2275
95988fcf
AS
22762012-06-10 Andreas Schwab <schwab@linux-m68k.org>
2277
2278 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
2279 account for preceding backslashes. (Bug#11663)
2280
cd4eb164
CY
22812012-06-09 Chong Yidong <cyd@gnu.org>
2282
2283 * term.c: Support italics in capable terminals (Bug#9652).
2284 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
2285 (turn_on_face): Output using TS_enter_italic_mode if available.
2286 Don't handle unused blinking and alt-charset cases.
2287 (turn_off_face): Handle italic case; discard unused tty_blinking_p
2288 and tty_alt_charset_p cases.
2289 (tty_capable_p, init_tty): Support italics.
2290
2291 * termchar.h (struct tty_display_info): Add field for italics.
2292 Remove unused blink field.
2293
2294 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
2295 Handle slant.
2296
2297 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
2298 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
2299 tty_alt_charset_p. Add tty_italic_p.
2300
ff88beb8
MA
23012012-06-09 Michael Albinus <michael.albinus@gmx.de>
2302
2303 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
2304 dbus_type_is_basic if available.
2305 (xd_extract_signed, xd_extract_unsigned): Rename from
2306 extract_signed and extract_unsigned, respectively. Adapt callers.
2307
44286096
CY
23082012-06-09 Chong Yidong <cyd@gnu.org>
2309
1682701f
CY
2310 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
2311
44286096
CY
2312 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
2313 case (Bug#9752).
2314
d86feb17
PE
23152012-06-08 Paul Eggert <eggert@cs.ucla.edu>
2316
2317 * xdisp.c (vmessage): Treat frame message as multibyte.
2318 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
2319 would generate the diagnostic "Making \302\247 buffer-local while
2320 let-bound!".
2321
d5c20fe8
EZ
23222012-06-08 Eli Zaretskii <eliz@gnu.org>
2323
2324 * dispnew.c (showing_window_margins_p): Undo last change, which
2325 was done due to an inadvertent commit.
2326 (adjust_frame_glyphs_for_frame_redisplay): Do call
2327 showing_window_margins_p.
2328
513749ee
SM
23292012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2330
2331 * eval.c (Fmake_var_non_special): New primitive.
2332 (syms_of_eval): Defsubr it.
2333 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
2334
d4a8f5c1
JB
23352012-06-08 Juanma Barranquero <lekktu@gmail.com>
2336
2337 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
2338 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
2339
8bbbc977
EZ
23402012-06-08 Eli Zaretskii <eliz@gnu.org>
2341
2342 * alloc.c (allocate_vectorlike): Fix last change.
2343
f3372c87
DA
23442012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
2345
2346 Block-based vector allocation of small vectors.
2347 * lisp.h (struct vectorlike_header): New field `nbytes',
2348 adjust comment accordingly.
2349 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
2350 to denote vector blocks. Adjust users (live_vector_p,
2351 mark_maybe_pointer, valid_lisp_object_p) accordingly.
2352 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
2353 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
2354 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
2355 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
2356 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
2357 (roundup_size): New constant.
2358 (struct vector_block): New data type.
2359 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 2360 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
2361 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
2362 (sweep_vectors): New functions.
2363 (allocate_vectorlike): Return `zero_vector' as the only vector of
2364 0 items. Allocate new vector from block if vector size is less than
2365 or equal to VBLOCK_BYTES_MAX.
2366 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
2367 (init_alloc_once): Add call to init_vectors.
2368
4f18a4ed
SM
23692012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2370
2371 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
2372
86f158bc
PE
23732012-06-07 Paul Eggert <eggert@cs.ucla.edu>
2374
2375 * doprnt.c (doprnt): Truncate multibyte char correctly.
2376 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
2377 would mishandle a string argument "Xc" if X was a multibyte
2378 character of length 2: it would truncate after X's first byte
2379 rather than including all of X.
2380
c5cfcbe0
CY
23812012-06-06 Chong Yidong <cyd@gnu.org>
2382
2383 * buffer.c (word_wrap): Doc fix.
2384
c05cf390
PE
23852012-06-04 Paul Eggert <eggert@cs.ucla.edu>
2386
2387 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
2388
0c3461de
GM
23892012-06-03 Glenn Morris <rgm@gnu.org>
2390
2391 * xdisp.c (tool-bar-style): Doc fix.
2392
c71232db
UM
23932012-06-03 Ulrich Müller <ulm@gentoo.org>
2394
2395 * Makefile.in (PAXCTL): Define.
2396 (temacs$(EXEEXT)): Disable memory randomization for the temacs
2397 binary via PaX flags if the paxctl utility is available.
2398 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
2399 Restore PaX flags to their default. (Bug#11398)
2400
383f7350
CY
24012012-06-03 Chong Yidong <cyd@gnu.org>
2402
2403 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
2404 buffer (Bug#11226).
2405
5f2c76c6
CY
24062012-06-03 Chong Yidong <cyd@gnu.org>
2407
2408 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
2409 (note_mode_line_or_margin_highlight): If there is no help echo,
2410 use mode-line-default-help-echo. Handle the case where the mouse
2411 position is past the end of the mode line string.
2412
2413 * buffer.c (buffer_local_value_1): New function, split from
2414 Fbuffer_local_value; can return Qunbound.
2415 (Fbuffer_local_value): Use it.
2416 (Vmode_line_format): Docstring tweaks.
2417
773d47f6
PE
24182012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2419
2420 * sysdep.c (system_process_attributes): Improve comment.
2421
f2d6a3df
SM
24222012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
2423
2424 * keyboard.c: Export real-this-command to Elisp.
2425 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
2426 and DEFVAR it. Update all users.
2427
63810350
PE
24282012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2429
7bd5c1f4
PE
2430 * minibuf.c (Fassoc_string): Remove duplicate declaration.
2431
63810350
PE
2432 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
2433 Convert pctcpu and pctmem to Lisp float properly.
2434 Let the compiler fold better, as 100.0/0x8000 is exact.
2435
a2821611
AS
24362012-06-02 Andreas Schwab <schwab@linux-m68k.org>
2437
2438 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
2439 cons_block.
2440
5fceba1d
PE
24412012-06-01 Paul Eggert <eggert@cs.ucla.edu>
2442
2443 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
2444
c98ff5dd
DA
24452012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
2446
2447 For a 'struct window', replace some Lisp_Object fields to
2448 bitfields where appropriate, remove unused fields.
2449 * window.h (struct window): Remove unused 'last_mark_x' and
2450 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
2451 change it's type from Lisp_Object to bitfield.
2452 Change type of 'force_start', 'optional_new_start',
2453 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
2454 fields from Lisp_Object to bitfield. Adjust users accordingly.
2455
ca34e0be
PE
24562012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2457
2458 Pacify gcc -Wdouble-precision when using Xaw.
2459 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
2460 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
2461 Use 'float' consistently, rather than 'float' in most places
2462 and 'double' in a couple of places.
2463
efc00ab1 24642012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
2465
2466 * xdisp.c (handle_stop): Detect whether we have overlay strings
2467 loaded by testing it->current.overlay_string_index to be
2468 non-negative, instead of checking whether n_overlay_strings is
2469 positive. (Bug#11587)
2470
efc00ab1 24712012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
2472
2473 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
2474
2475 * doc.c (Fsubstitute_command_keys): Doc fix.
2476
efc00ab1 24772012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
2478
2479 * search.c (search_buffer): Remove calls to
2480 r_alloc_inhibit_buffer_relocation, as it is now called by
2481 maybe_unify_char, which was the cause of relocation of buffer text
2482 in bug#11519.
2483
efc00ab1 24842012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
2485
2486 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
2487 for the duration of call to load_charset, to avoid problems with
2488 callers of maybe_unify_char that access buffer text through C
2489 pointers.
2490
2491 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
2492 decrement the inhibition flag, instead of just setting or
2493 resetting it.
2494
ba93a187
PE
24952012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2496
2497 Remove obsolete '#define static' cruft.
2498 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
2499 This #undef was "temporary" in 2000; it is no longer needed
2500 now that '#define static' has gone away.
2501 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
2502 (gray_bitmap_bits): Remove; no longer needed.
2503 All uses replaced with definiens.
2504 * xterm.c: Include "bitmaps/gray.xbm".
2505
9e4bf381
PE
25062012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2507
2508 Clean up __executable_start, monstartup when --enable-profiling.
2509 The following changes affect the code only when profiling.
2510 * dispnew.c (__executable_start): Rename from safe_bcopy.
2511 Define only on platforms that need it.
2512 * emacs.c: Include <sys/gmon.h> when profiling.
2513 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
2514 (__executable_start): Remove decl, since lisp.h does it now.
2515 (safe_bcopy): Remove decl; no longer has that name.
2516 (main): Coalesce #if into single bit of code, for simplicity.
2517 Cast pointers to uintptr_t, since standard libraries want integers
2518 and not pointers.
2519 * lisp.h (__executable_start): New decl.
2520
32d72c2f
GM
25212012-05-31 Glenn Morris <rgm@gnu.org>
2522
2523 * image.c (Fimagemagick_types): Doc fix.
2524
baac5bc7
JM
25252012-05-30 Jim Meyering <meyering@redhat.com>
2526
2527 * callproc.c (Fcall_process_region): Include directory component
2528 in mkstemp error message (Bug#11586).
2529
72cb32cf
PE
25302012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2531
2532 * alloc.c, lisp.h (make_pure_vector): Now static.
2533
61b108cc
SM
25342012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
2535
2536 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
2537 Move to byte-run.el.
2538 (Fautoload): Do the hash-doc more carefully.
2539 * data.c (Fdefalias): Purify definition, except for keymaps.
2540 (Qdefun): Move from eval.c.
2541 * lisp.h (Qdefun): Remove.
2542 * lread.c (read1): Tiny simplification.
2543
471fe23d
TN
25442012-05-29 Troels Nielsen <bn.troels@gmail.com>
2545
934f3f58 2546 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
2547 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
2548 Bug#9642, but explicitly check that the buffer the overlay would
2549 be moved to is live and rearrange lines to make sure that errors
2550 will not put the overlay in an inconsistent state.
2551 (Fdelete_overlay): Cosmetics.
2552
85d0efd1
EZ
25532012-05-28 Eli Zaretskii <eliz@gnu.org>
2554
2555 * w32term.c (my_bring_window_to_top): New function.
2556 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
2557 could be different from the original one.
2558 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
2559 (Bug#11513)
2560
2561 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
2562 by calling BringWindowToTop.
2563
2564 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
2565 (WM_EMACS_END): Increase by one.
2566
da92a98c
PE
25672012-05-28 Paul Eggert <eggert@cs.ucla.edu>
2568
2569 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
2570 This avoids undefined behavior that might cause the eassert
2571 to not catch an out-of-range value.
2572
74d1f848
JB
25732012-05-28 Juanma Barranquero <lekktu@gmail.com>
2574
2575 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
2576 Update dependencies.
2577
9e1a06fc
EZ
25782012-05-27 Eli Zaretskii <eliz@gnu.org>
2579
2580 * bidi.c (bidi_mirror_char): Fix last change.
2581
f3dd7312
AS
25822012-05-27 Andreas Schwab <schwab@linux-m68k.org>
2583
2584 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
2585 when referring to sectname field in printf format.
2586
81899c91
PE
25872012-05-27 Paul Eggert <eggert@cs.ucla.edu>
2588
57b81a9f
PE
2589 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
2590 Only r_alloc_inhibit_buffer_relocation needed to be added;
2591 the others were already declared.
2592
81899c91
PE
2593 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
2594 before checking whether it's out of range. Put the check inside
2595 eassert. See
2596 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
2597
33017faf 25982012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
2599
2600 * callproc.c (Fcall_process): Restore a line that was accidentally
2601 commented out in the 2011-02-13 change (bug#11547).
2602
33017faf 26032012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
2604
2605 * lisp.h [REL_ALLOC]: Add prototypes for external functions
2606 defined on ralloc.c.
2607
2608 * buffer.c [REL_ALLOC]: Remove prototypes of
2609 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
2610 they are now on lisp.h.
2611
2612 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
2613
2614 * search.c (search_buffer): Use it to inhibit relocation of buffer
2615 text while re_search_2 is doing its job, because re_search_2 is
2616 passed C pointers to buffer text. (Bug#11519)
2617
23415acf
EZ
2618 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
2619 Update value to 24.
2620
44e27368
EZ
2621 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
2622 state after an additional call to move_it_in_display_line_to, keep
2623 the values of it->max_ascent and it->max_descent found for the
2624 entire line.
2625 (pos_visible_p): Revert the comparison against bottom_y to what it
2626 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
2627 (Bug#11464)
2628
c1892f11
PE
26292012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2630
2631 Fix coding-related core dumps with gcc -ftrapv.
2632 The code was computing A - B, where A and B are pointers, and B is
2633 random garbage. This can lead to core dumps on platforms that
2634 have special pointer registers, and it also leads to core dumps on
2635 x86-64 when compiled with gcc -ftrapv. The fix is to compute
2636 A - B only when B is initialized properly.
2637 * coding.c (coding_set_source, coding_set_destination): Return void.
2638 (coding_change_source, coding_change_destinations): New functions,
2639 with the old behaviors of coding_set_source and coding_set_destination.
2640 All callers that need an offset changed to use these new functions.
2641
eb7afdad
GM
26422012-05-26 Glenn Morris <rgm@gnu.org>
2643
2644 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
2645
f12fdf02
EZ
26462012-05-26 Eli Zaretskii <eliz@gnu.org>
2647
53a63be6 2648 Extend mouse support on W32 text-mode console.
61b108cc
SM
2649 * xdisp.c (draw_row_with_mouse_face):
2650 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 2651
eb3f6f01 2652 * w32console.c: Include window.h.
61b108cc
SM
2653 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
2654 New functions.
eb3f6f01
EZ
2655 (initialize_w32_display): Initialize mouse-highlight data.
2656
53a63be6
EZ
2657 * w32inevt.c: Include termchar.h and window.h.
2658 (do_mouse_event): Support mouse-autoselect-window. When the mouse
2659 moves, call note_mouse_highlight. If help_echo changed, call
2660 gen_help_event to produce help-echo message in the echo area.
2661 Call clear_mouse_face if mouse_face_hidden is set in the mouse
2662 highlight info.
2663
4cfd81f6
PE
26642012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2665
2666 * lread.c (read1): Simplify slightly to avoid an overflow warning
2667 with GCC 4.7.0 on x86-64.
2668
4446092a
EZ
26692012-05-26 Eli Zaretskii <eliz@gnu.org>
2670
2671 * bidi.c (bidi_mirror_char): Revert last change: an int is
2672 definitely wide enough here.
2673
42b2a986 26742012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 2675
42b2a986 2676 Fix integer width and related bugs (Bug#9874).
eb106a49 2677 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
2678 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
2679 (string_bytes, check_sblock, allocate_string_data):
2680 (compact_small_strings, Fmake_bool_vector, make_string)
2681 (make_unibyte_string, make_multibyte_string)
2682 (make_string_from_bytes, make_specified_string)
2683 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
2684 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
2685 (mark_vectorlike):
2686 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2687 (allocate_pseudovector):
2688 Use int, not EMACS_INT, where int is wide enough.
2689 (inhibit_garbage_collection, Fgarbage_collect):
2690 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2691 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
2692 int might not be wide enough.
2693 (bidi_cache_search, bidi_cache_find, bidi_init_it)
2694 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
2695 (bidi_at_paragraph_end, bidi_find_paragraph_start)
2696 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2697 (bidi_level_of_next_char, bidi_move_to_visually_next):
2698 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2699 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
2700 (Fkill_buffer, Fset_buffer_major_mode)
2701 (advance_to_char_boundary, Fbuffer_swap_text)
2702 (Fset_buffer_multibyte, overlays_at, overlays_in)
2703 (overlay_touches_p, struct sortvec, record_overlay_string)
2704 (overlay_strings, recenter_overlay_lists)
2705 (adjust_overlays_for_insert, adjust_overlays_for_delete)
2706 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
2707 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
2708 (Foverlay_recenter, last_overlay_modification_hooks_used)
2709 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
2710 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
2711 (validate_region): Omit unnecessary test for b <= e,
2712 since that's guaranteed by the previous test.
d311d28c
PE
2713 (adjust_overlays_for_delete): Avoid pos + length overflow.
2714 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
2715 (report_overlay_modification):
2716 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2717 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
2718 Omit pointer cast, which isn't needed anyway, and doesn't work
2719 after the EMACS_INT -> ptrdiff_t change.
02481186 2720 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
2721 * buffer.h: Adjust decls to match defn changes elsewhere.
2722 (struct buffer_text, struct buffer):
2723 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2724 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
2725 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
2726 not int, to avoid needless 32-bit limit on 64-bit hosts.
2727 (exec_byte_code): Use tighter memory-full test, one that checks
2728 for alloca overflow. Don't compute the address of the object just
2729 before an array, as that's not portable. Use EMACS_INT, not
2730 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
2731 * callint.c (Fcall_interactively):
2732 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2733 * callproc.c (call_process_kill, Fcall_process):
2734 Don't assume pid_t fits into an Emacs fixnum.
2735 (call_process_cleanup, Fcall_process, child_setup):
2736 Don't assume pid_t fits into int.
2737 (call_process_cleanup, Fcall_process, delete_temp_file)
2738 (Fcall_process_region):
2739 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2740 (Fcall_process): Simplify handling of volatile integers.
2741 Use int, not EMACS_INT, where int will do.
2742 * casefiddle.c (casify_object, casify_region, operate_on_word)
2743 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
2744 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2745 (casify_object): Avoid integer overflow when overallocating buffer.
2746 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 2747 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
2748 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
2749 * category.h (CATEGORYP): Don't assume arg is nonnegative.
2750 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
2751 integers are now checked earlier. All uses replaced with XINT.
2752 (ccl_driver):
2753 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2754 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
2755 (ccl_driver, Fregister_code_conversion_map):
2756 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
2757 (resolve_symbol_ccl_program): Check that vector header is in range.
2758 Always copy the vector, so that we can check its contents reliably
2759 now rather than having to recheck each instruction as it's being
2760 executed. Check that vector words fit in 'int'.
2761 (ccl_get_compiled_code, Fregister_ccl_program)
2762 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
2763 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
2764 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
2765 contents are in range.
2766 (Fccl_execute_on_string): Check that status is in range.
2767 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
2768 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
2769 Accept and return EMACS_INT, not int, because callers can pass values
2770 out of 'int' range.
2771 (c_string_width, strwidth, lisp_string_width, chars_in_text)
2772 (multibyte_chars_in_text, parse_str_as_multibyte)
2773 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
2774 (str_as_unibyte, str_to_unibyte, string_count_byte8)
2775 (string_escape_byte8, Fget_byte):
2776 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 2777 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
2778 avoid mishandling large integers.
2779 * character.h: Adjust decls to match defn changes elsewhere.
2780 * charset.c (load_charset_map_from_file, find_charsets_in_text)
2781 (Ffind_charset_region):
2782 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2783 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
2784 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 2785 Don't assume fixnum fits in int.
d311d28c
PE
2786 (load_charset_map_from_vector, Fmap_charset_chars):
2787 Remove now-unnecessary CHECK_NATNUMs.
2788 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
2789 Don't rely on undefined behavior with signed left shift overflow.
2790 Don't assume unsigned int fits into fixnum, or that fixnum fits
2791 into unsigned int. Don't require max_code to be a valid fixnum;
2792 that's not true for gb10830 4-byte on a 32-bit host. Allow
2793 invalid_code to be a cons, for the same reason. Require code_offset
2794 to be a character. Avoid int overflow if max_char is close
2795 to INT_MAX.
2796 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
2797 this is intended anyway and avoids some undefined behavior.
2798 (load_charset_map): Pass unsigned, not int, as 2nd arg of
2799 INDEX_TO_CODE_POINT, as that's what it expects.
2800 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
2801 * charset.h (DECODE_CHAR): Return int, not unsigned;
2802 this is what was intended anyway, and it avoids undefined behavior.
2803 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
2804 integer-overflow issues.
2805 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
2806 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
2807 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
2808 * chartab.c (Fmake_char_table, Fset_char_table_range)
2809 (uniprop_get_decoder, uniprop_get_encoder):
2810 Don't assume fixnum fits in int.
2811 * cmds.c (move_point): New function, that does the gist of
2812 Fforward_char and Fbackward_char, but does so while checking
2813 for integer overflow more accurately.
c96e5d6a 2814 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
2815 (Fforward_line, Fend_of_line, internal_self_insert)
2816 (internal_self_insert):
2817 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2818 Fix a FIXME, by checking for integer overflow when calculating
2819 target_clm and actual_clm.
2820 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 2821 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
2822 (ASSURE_DESTINATION, coding_alloc_by_realloc)
2823 (coding_alloc_by_making_gap, alloc_destination)
2824 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
2825 (encode_coding_utf_16, detect_coding_emacs_mule)
2826 (decode_coding_emacs_mule, encode_coding_emacs_mule)
2827 (detect_coding_iso_2022, decode_coding_iso_2022)
2828 (encode_invocation_designation, encode_designation_at_bol)
2829 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2830 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
2831 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
2832 (encode_coding_ccl, encode_coding_raw_text)
2833 (detect_coding_charset, decode_coding_charset)
2834 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
2835 (produce_composition, produce_charset, produce_annotation)
2836 (decode_coding, handle_composition_annotation)
2837 (handle_charset_annotation, consume_chars, decode_coding_gap)
2838 (decode_coding_object, encode_coding_object, detect_coding_system)
2839 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
2840 (code_convert_region, code_convert_string)
8f50130c
PE
2841 (Fdefine_coding_system_internal)
2842 (coding_set_source, coding_set_destination):
d311d28c
PE
2843 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2844 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
2845 (Fdefine_coding_system_internal):
2846 Don't assume fixnums fit in int.
2847 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 2848 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
2849 (Funencodable_char_position, Fcheck_coding_systems_region)
2850 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 2851 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 2852 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 2853 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 2854 Don't access memory outside of the args array.
d311d28c 2855 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
2856 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
2857 result of ENCODE_CHAR.
d311d28c
PE
2858 * coding.h: Adjust decls to match defn changes elsewhere.
2859 (struct coding_system):
2860 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2861 * composite.c (get_composition_id, find_composition)
2862 (run_composition_function, update_compositions)
2863 (compose_text, composition_gstring_put_cache)
2864 (composition_gstring_p, composition_gstring_width)
2865 (fill_gstring_header, fill_gstring_body, autocmp_chars)
2866 (composition_compute_stop_pos, composition_reseat_it)
2867 (composition_update_it, struct position_record)
2868 (find_automatic_composition, composition_adjust_point)
2869 (Fcomposition_get_gstring, Ffind_composition_internal):
2870 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2871 (update_compositions):
2872 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2873 * composite.h: Adjust decls to match defn changes elsewhere.
2874 (struct composition):
2875 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2876 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2877 Do not attempt to compute the address of the object just before a
2878 buffer; this is not portable.
2879 (Faref, Faset):
2880 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2881 (Faset): Use int, not EMACS_INT, where int is wide enough.
2882 (Fstring_to_number): Don't assume fixnums fit in int.
2883 (Frem): Don't assume arg is nonnegative.
2884 * dbusbind.c (xd_append_arg): Check for integers out of range.
2885 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 2886 (extract_signed, extract_unsigned): New functions.
243e0530
PE
2887 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
2888 (xd_get_connection_references): Return ptrdiff_t, not int.
2889 All uses changed.
2890 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
2891 (xd_read_message_1):
2892 Use int, not unsigned, where the dbus API uses int.
2893 (Fdbus_message_internal): Don't overflow mtype.
2894 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
2895 * dired.c (directory_files_internal, file_name_completion, scmp)
2896 (file_name_completion_stat):
2897 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2898 (file_name_completion): Don't overflow matchcount.
2899 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
2900 * dispextern.h: Adjust decls to match defn changes elsewhere.
2901 (struct text_pos, struct glyph, struct bidi_saved_info)
2902 (struct bidi_string_data, struct bidi_it, struct composition_it)
2903 (struct it):
2904 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2905 (struct display_pos, struct composition_it, struct it):
2906 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2907 * dispnew.c (increment_matrix_positions)
2908 (increment_row_positions, mode_line_string)
2909 (marginal_area_string):
2910 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 2911 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
2912 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2913 (duration_to_sec_usec): New function, to check for overflow better.
2914 (Fsleep_for, sit_for): Use it.
2915 * doc.c (get_doc_string, store_function_docstring):
2916 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2917 (get_doc_string, Fsnarf_documentation):
2918 Use int, not EMACS_INT, where int is wide enough.
2919 (get_doc_string):
2920 Use SAFE_ALLOCA, not alloca.
2921 Check for overflow when converting EMACS_INT to off_t.
2922 * doprnt.c (doprnt):
2923 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2924 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
2925 Don't assume uid_t fits into fixnum.
2926 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
2927 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
2928 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
2929 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
2930 (general_insert_function)
2931 (Finsert_char, make_buffer_string, make_buffer_string_both)
2932 (update_buffer_properties, Fbuffer_substring)
2933 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
2934 (Fsubst_char_in_region, check_translation)
2935 (Ftranslate_region_internal, save_restriction_restore, Fformat)
2936 (transpose_markers, Ftranspose_regions):
2937 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2938 (clip_to_bounds): Move to lisp.h as an inline function).
2939 (Fconstrain_to_field): Don't assume integers are nonnegative.
2940 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
2941 (Fsubst_char_in_region, Fsave_restriction):
2942 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2943 (Femacs_pid): Don't assume pid_t fits into fixnum.
2944 (lo_time): Use int, not EMACS_INT, when int suffices.
2945 (lisp_time_argument): Check for usec out of range.
2946 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
2947 (Fuser_login_name, Fuser_full_name): Signal an error
2948 if a uid argument is out of range, rather than relying on
2949 undefined behavior.
c8d5c857
PE
2950 (Fformat_time_string): Remove now-unnecessary check.
2951 lisp_time_argument checks for out-of-range usec now.
243e0530 2952 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
2953 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
2954 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
2955 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
2956 (init_cmdargs, Fdump_emacs):
2957 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2958 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
2959 the bottom (typically) 32 bits of the fixnum.
2960 * eval.c (specpdl_size, call_debugger):
2961 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2962 (when_entered_debugger, Fbacktrace_debug):
2963 Don't assume fixnum can fit in int.
2964 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
2965 the object just before a buffer; this is not portable.
2966 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
2967 (grow_specpdl, unbind_to):
2968 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2969 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
2970 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 2971 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
2972 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
2973 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
2974 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2975 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
2976 (a_write, e_write):
2977 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2978 (Fcopy_file, non_regular_nbytes, read_non_regular)
2979 (Finsert_file_contents):
2980 Use int, not EMACS_INT, where int is wide enough.
2981 (READ_BUF_SIZE): Verify that it fits in int.
2982 (Finsert_file_contents): Check that counts are in proper range,
2983 rather than assuming fixnums fit into ptrdiff_t etc.
2984 Don't assume fixnums fit into int.
125b3835 2985 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
2986 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
2987 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
2988 (string_char_to_byte, string_byte_to_char)
2989 (string_make_multibyte, string_to_multibyte)
2990 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
2991 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
2992 (substring_both, Fdelete, internal_equal, Ffillarray)
2993 (Fclear_string, mapcar1)
2994 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
2995 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
2996 (larger_vector, make_hash_table, maybe_resize_hash_table)
2997 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
2998 (Fmaphash, secure_hash):
2999 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3000 (concat): Check for string index and length overflow.
3001 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
3002 (Frequire):
3003 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3004 (larger_vector): New API (vec, incr_min, size_max) replaces old
3005 one (vec, new_size, init). This catches size overflow.
3006 INIT was removed because it was always Qnil.
3007 All callers changed.
3008 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
3009 the upper bound on a hash table index size.
3010 (make_hash_table, maybe_resize_hash_table): Use it.
3011 (secure_hash): Computer start_byte and end_byte only after
3012 they're known to be in ptrdiff_t range.
3013 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
3014 (Ffont_get_glyphs, Ffont_at):
3015 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3016 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
3017 (Flist_fonts, Fopen_font):
3018 Don't assume fixnum can fit in int.
3019 (check_gstring): Don't assume index can fit in int.
3020 (font_match_p): Check that fixnum is a character, not a nonnegative
3021 fixnum, since the later code needs to stuff it into an int.
3022 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
3023 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
3024 conversion overflow issues.
3025 (Fopen_font): Check for integer out of range.
3026 (Ffont_get_glyphs): Don't assume index can fit in int.
3027 * font.h: Adjust decls to match defn changes elsewhere.
3028 * fontset.c (reorder_font_vector): Redo score calculation to avoid
3029 integer overflow.
3030 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
3031 printmax_t, where ptrdiff_t is wide enough.
3032 (Finternal_char_font):
3033 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3034 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
3035 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
3036 (Fset_frame_position, x_set_frame_parameters)
3037 (x_set_line_spacing, x_set_border_width)
3038 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
3039 Check that fixnums are in proper range for system types.
3040 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
3041 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3042 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
3043 Use SAFE_ALLOCA_LISP, not alloca.
3044 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
3045 intptr_t is wide enough.
3046 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
3047 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
3048 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
3049 Check for fixnum out of range.
3050 * ftfont.c (ftfont_list): Don't assume index fits in int.
3051 Check that fixnums are in proper range for system types.
3052 (ftfont_shape_by_flt):
3053 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
3054 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3055 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3056 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
3057 Check that fixnums are in proper range for system types.
3058 * gnutls.h: Adjust decls to match defn changes elsewhere.
3059 * gtkutil.c (xg_dialog_run):
3060 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3061 (update_frame_tool_bar):
3062 Check that fixnums are in proper range for system types.
3063 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 3064 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
3065 * indent.c (last_known_column, last_known_column_point):
3066 (current_column_bol_cache):
3067 (skip_invisible, current_column, check_display_width):
3068 (check_display_width, scan_for_column, current_column_1)
3069 (Findent_to, Fcurrent_indentation, position_indentation)
3070 (indented_beyond_p, Fmove_to_column, compute_motion):
3071 (Fcompute_motion, Fvertical_motion):
3072 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3073 (last_known_column_modified): Use EMACS_INT, not int.
3074 (check_display_width):
3075 (Fcompute_motion):
3076 Check that fixnums and floats are in proper range for system types.
3077 (compute_motion): Don't assume index or fixnum fits in int.
3078 (compute_motion, Fcompute_motion):
3079 Use int, not EMACS_INT, when it is wide enough.
3080 (vmotion): Omit local var start_hpos that is always 0; that way
3081 we don't need to worry about overflow in expressions involving it.
3082 * indent.h: Adjust decls to match defn changes elsewhere.
3083 (struct position):
3084 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3085 Use int, not EMACS_INT, where int is wide enough.
3086 Remove unused members ovstring_chars_done and tab_offset;
3087 all uses removed.
3088 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
3089 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
3090 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
3091 (make_gap, copy_text, insert, insert_and_inherit)
3092 (insert_before_markers, insert_before_markers_and_inherit)
3093 (insert_1, count_combining_before, count_combining_after)
3094 (insert_1_both, insert_from_string)
3095 (insert_from_string_before_markers, insert_from_string_1)
3096 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
3097 (adjust_after_replace, adjust_after_insert, replace_range)
3098 (replace_range_2, del_range, del_range_1, del_range_byte)
3099 (del_range_both, del_range_2, modify_region)
3100 (prepare_to_modify_buffer, signal_before_change)
3101 (signal_after_change, Fcombine_after_change_execute):
3102 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3103 * intervals.c (traverse_intervals, rotate_right, rotate_left)
3104 (balance_an_interval, split_interval_right, split_interval_left)
3105 (find_interval, next_interval, update_interval)
3106 (adjust_intervals_for_insertion, delete_node, delete_interval)
3107 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3108 (static_offset_intervals, offset_intervals)
3109 (merge_interval_right, merge_interval_left, make_new_interval)
3110 (graft_intervals_into_buffer, temp_set_point_both)
3111 (temp_set_point, set_point, adjust_for_invis_intang)
3112 (set_point_both, move_if_not_intangible, get_property_and_range)
3113 (get_local_map, copy_intervals, copy_intervals_to_string)
3114 (compare_string_intervals, set_intervals_multibyte_1):
3115 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3116 * intervals.h: Adjust decls to match defn changes elsewhere.
3117 (struct interval):
3118 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3119 * keyboard.c (this_command_key_count, this_single_command_key_start)
3120 (before_command_key_count, before_command_echo_length, echo_now)
3121 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
3122 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
3123 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
3124 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
3125 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3126 (last_non_minibuf_size, last_point_position, echo_truncate)
3127 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
3128 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
3129 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
3130 (stuff_buffered_input):
3131 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3132 (last_auto_save, command_loop_1, read_char):
3133 Use EMACS_INT, not int, to avoid integer overflow.
3134 (record_char): Avoid overflow in total_keys computation.
3135 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
3136 * keyboard.h: Adjust decls to match defn changes elsewhere.
3137 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
3138 (Fkey_description, Fdescribe_vector, Flookup_key):
3139 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3140 (click_position): New function, to check that positions are in range.
3141 (Fcurrent_active_maps):
3142 (describe_command):
3143 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3144 (Faccessible_keymaps, Fkey_description):
3145 (preferred_sequence_p):
3146 Don't assume fixnum can fit into int.
3147 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
3148 Check for integer overflow in size calculations.
3149 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
3150 avoid mishandling large integers.
3151 * lisp.h: Adjust decls to match defn changes elsewhere.
3152 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
3153 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
3154 (struct Lisp_Marker):
3155 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3156 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
3157 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
3158 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
3159 All callers changed.
3160 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
3161 Assume the arg has valid form, since it always does.
3162 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
3163 unsigned integer system type.
3164 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
3165 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
3166 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3167 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
3168 (duration_to_sec_usec): New decl.
3169 * lread.c (read_from_string_index, read_from_string_index_byte)
3170 (read_from_string_limit, readchar, unreadchar, openp)
3171 (read_internal_start, read1, oblookup):
3172 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3173 (Fload, readevalloop, Feval_buffer, Feval_region):
3174 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3175 (openp): Check for out-of-range argument to 'access'.
3176 (read1): Use int, not EMACS_INT, where int is wide enough.
3177 Don't assume fixnum fits into int.
6efdadfd 3178 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
3179 (read_filtered_event): Use duration_to_sec_usec
3180 to do proper overflow checking on durations.
d311d28c
PE
3181 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
3182 in size calculation.
3183 (Fexecute_kbd_macro):
3184 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3185 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
3186 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
3187 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
3188 (set_marker_both, set_marker_restricted_both, marker_position)
3189 (marker_byte_position, Fbuffer_has_markers_at):
3190 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3191 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 3192 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
3193 It now merely ensures that the menu is large enough, without
3194 necessarily growing it, as this avoids some integer overflow issues.
3195 All callers changed.
3196 (keymap_panes, parse_single_submenu, Fx_popup_menu):
3197 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3198 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
3199 Use SAFE_ALLOCA_LISP, not alloca.
3200 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
3201 to EMACS_INT. Check that fixnums are in proper range for system types.
3202 * minibuf.c (minibuf_prompt_width, string_to_object)
3203 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
3204 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
3205 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3206 (get_minibuffer, read_minibuf_unwind):
3207 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3208 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
3209 this simplifies overflow checking. All callers changed.
3210 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
3211 (Ftest_completion):
3212 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3213 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
3214 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
3215 Check that fixnums are in proper range for system types.
3216 (Fx_create_frame, Fx_show_tip):
3217 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3218 * nsfont.m (ns_findfonts, nsfont_list_family):
3219 Don't assume fixnum fits in long.
3220 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
3221 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3222 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
3223 wide enough.
17fdb222 3224 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
3225 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3226 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
3227 (PRINTDECLARE, PRINTPREPARE):
3228 (strout, print_string):
3229 (print, print_preprocess, print_check_string_charset_prop)
3230 (print_object):
3231 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3232 (PRINTDECLARE):
3233 (temp_output_buffer_setup, Fprin1_to_string, print_object):
3234 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3235 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 3236 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 3237 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
3238 (print_error_message): Use SAFE_ALLOCA, not alloca.
3239 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
3240 (print_depth, new_backquote_output, print_number_index):
3241 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
3242 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
3243 (Fset_process_window_size, Fformat_network_address)
3244 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 3245 (sigchld_handler):
d311d28c 3246 Check that fixnums are in proper range for system types.
d44287d4 3247 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
3248 Check for process-ids out of pid_t range rather than relying on
3249 undefined behavior.
e4d81efc 3250 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
3251 (Fformat_network_address, read_process_output, send_process)
3252 (Fprocess_send_region, status_notify):
3253 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3254 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
3255 (wait_reading_process_output, read_process_output, exec_sentinel):
3256 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3257 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
3258 (Faccept_process_output): Use duration_to_sec_usec to do proper
3259 overflow checking on durations.
dde14581
PE
3260 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
3261 Don't assume pid_t fits in int.
02481186
PE
3262 * process.h (struct Lisp_Process): Members tick and update_tick
3263 are now of type EMACS_INT, not int.
b62b53e8
PE
3264 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
3265 configured --with-wide-int.
d311d28c
PE
3266 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
3267 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
3268 * search.c (looking_at_1, string_match_1):
3269 (fast_string_match, fast_c_string_match_ignore_case)
3270 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
3271 (scan_newline, find_before_next_newline, search_command)
3272 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
3273 (set_search_regs, wordify):
3274 (Freplace_match):
3275 (Fmatch_data):
3276 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3277 (string_match_1, search_buffer, set_search_regs):
3278 (Fmatch_data):
3279 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3280 (wordify): Check for overflow in size calculation.
3281 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
3282 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
3283 Check that fixnums are in proper range for system types.
3284 * sound.c (struct sound_device)
3285 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
3286 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3287 (Fplay_sound_internal):
3288 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 3289 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
3290 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
3291 (Fparse_partial_sexp):
3292 Don't assume fixnums can fit in int.
3293 (struct lisp_parse_state, find_start_pos, find_start_value)
3294 (find_start_value_byte, find_start_begv)
3295 (update_syntax_table, char_quoted, dec_bytepos)
3296 (find_defun_start, prev_char_comend_first, back_comment):
3297 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
3298 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
3299 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3300 (Finternal_describe_syntax_value): Check that match_lisp is a
3301 character, not an integer, since the code stuffs it into int.
3302 (scan_words, scan_sexps_forward):
3303 Check that fixnums are in proper range for system types.
3304 (Fforward_word):
3305 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3306 (scan_sexps_forward):
3307 Use CHARACTERP, not INTEGERP, since the value must fit into int.
3308 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
3309 * syntax.h: Adjust decls to match defn changes elsewhere.
3310 (struct gl_state_s):
3311 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
3312 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
3313 MOST_POSITIVE_FIXNUM.
d311d28c
PE
3314 * sysdep.c (wait_for_termination_1, wait_for_termination)
3315 (interruptible_wait_for_termination, mkdir):
3316 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
3317 (emacs_read, emacs_write):
3318 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
3319 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
3320 and double all fit in int.
d311d28c
PE
3321 * term.c (set_tty_color_mode):
3322 Check that fixnums are in proper range for system types.
3323 * termhooks.h (struct input_event):
3324 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3325 * textprop.c (validate_interval_range, interval_of)
3326 (Fadd_text_properties, set_text_properties_1)
3327 (Fremove_text_properties, Fremove_list_of_text_properties)
3328 (Ftext_property_any, Ftext_property_not_all)
3329 (copy_text_properties, text_property_list, extend_property_ranges)
3330 (verify_interval_modification):
3331 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3332 (Fnext_single_char_property_change)
3333 (Fprevious_single_char_property_change):
3334 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
3335 (copy_text_properties):
3336 Check for integer overflow in index calculation.
d311d28c
PE
3337 * undo.c (last_boundary_position, record_point, record_insert)
3338 (record_delete, record_marker_adjustment, record_change)
3339 (record_property_change):
3340 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3341 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
3342 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3343 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3344 (Fx_hide_tip, Fx_file_dialog):
3345 * w32menu.c (set_frame_menubar):
3346 Use ptrdiff_t, not int, for consistency with rest of code.
3347 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
3348 (select_window, Fdelete_other_windows_internal)
3349 (window_scroll_pixel_based, window_scroll_line_based)
3350 (Frecenter, Fset_window_configuration):
3351 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3352 (Fset_window_hscroll, run_window_configuration_change_hook)
3353 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 3354 (Fscroll_other_window, Frecenter):
d311d28c
PE
3355 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3356 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
3357 Don't assume fixnum fits in int.
3358 (Fset_window_scroll_bars):
3359 Check that fixnums are in proper range for system types.
3360 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
3361 (string_pos, c_string_pos, number_of_chars, init_iterator)
3362 (in_ellipses_for_invisible_text_p, init_from_display_pos)
3363 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
3364 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
3365 (face_before_or_after_it_pos, handle_invisible_prop)
3366 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
3367 (display_prop_intangible_p, string_buffer_position_lim)
3368 (string_buffer_position, handle_composition_prop, load_overlay_strings)
3369 (get_overlay_strings_1, get_overlay_strings)
3370 (iterate_out_of_display_property, forward_to_next_line_start)
3371 (back_to_previous_visible_line_start, reseat, reseat_to_string)
3372 (get_next_display_element, set_iterator_to_next)
3373 (get_visually_first_element, compute_stop_pos_backwards)
3374 (handle_stop_backwards, next_element_from_buffer)
3375 (move_it_in_display_line_to, move_it_in_display_line)
3376 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3377 (add_to_log, message_dolog, message_log_check_duplicate)
3378 (message2, message2_nolog, message3, message3_nolog
3379 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
3380 (current_message_1, truncate_echo_area, truncate_message_1)
3381 (set_message, set_message_1, store_mode_line_noprop)
3382 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
3383 (text_outside_line_unchanged_p, check_point_in_composition)
3384 (reconsider_clip_changes)
3385 (redisplay_internal, set_cursor_from_row, try_scrolling)
3386 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
3387 (redisplay_window, find_last_unchanged_at_beg_row)
3388 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
3389 (trailing_whitespace_p, find_row_edges, display_line)
3390 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
3391 (display_mode_element, store_mode_line_string)
3392 (pint2str, pint2hrstr, decode_mode_spec)
3393 (display_count_lines, display_string, draw_glyphs)
3394 (x_produce_glyphs, x_insert_glyphs)
3395 (rows_from_pos_range, mouse_face_from_buffer_pos)
3396 (fast_find_string_pos, mouse_face_from_string_pos)
3397 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3398 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3399 (safe_call, init_from_display_pos, handle_fontified_prop)
3400 (handle_single_display_spec, load_overlay_strings)
3401 (with_echo_area_buffer, setup_echo_area_for_printing)
3402 (display_echo_area, echo_area_display)
3403 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
3404 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
3405 (redisplay_window, dump_glyph_row, display_mode_line)
3406 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 3407 (handle_display_spec, display_prop_string_p):
d311d28c
PE
3408 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3409 (handle_single_display_spec, build_desired_tool_bar_string)
3410 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
3411 (get_specified_cursor_type):
3412 Check that fixnums are in proper range for system types.
3413 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
3414 (Flookup_image_map):
3415 Don't assume fixnums fit in int.
3416 (compare_overlay_entries):
3417 Avoid mishandling comparisons due to subtraction overflow.
3418 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
3419 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
3420 (handle_tool_bar_click):
3421 Use int, not unsigned, since we prefer signed and the signedness
3422 doesn't matter here.
3423 (get_next_display_element, next_element_from_display_vector):
3424 Use int, not EMACS_INT, when int is wide enough.
3425 (start_hourglass): Use duration_to_sec_usec to do proper
3426 overflow checking on durations.
3427 * xfaces.c (Fbitmap_spec_p):
3428 Check that fixnums are in proper range for system types.
3429 (compare_fonts_by_sort_order):
3430 Avoid mishandling comparisons due to subtraction overflow.
3431 (Fx_family_fonts, realize_basic_faces):
3432 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3433 (Fx_family_fonts):
3434 Don't assume fixnum fits in int.
3435 Use SAFE_ALLOCA_LISP, not alloca.
3436 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
3437 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
3438 (face_at_buffer_position, face_for_overlay_string)
3439 (face_at_string_position):
3440 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3441 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
3442 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
3443 (Fx_show_tip):
3444 Check that fixnums are in proper range for system types.
3445 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3446 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
3447 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3448 (Fx_change_window_property): Don't assume fixnums fit in int.
3449 * xfont.c (xfont_chars_supported):
3450 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3451 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
3452 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
3453 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3454 * xml.c (parse_region):
3455 * xrdb.c (magic_file_p):
3456 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3457 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
3458 (x_get_local_selection, x_reply_selection_request)
3459 (x_handle_selection_request, wait_for_property_change):
3460 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3461 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
3462 short is wide enough.
3463 (x_send_client_event): Don't assume fixnum fits in int.
3464 * xterm.c (x_x_to_emacs_modifiers):
3465 Don't assume EMACS_INT overflows nicely into int.
3466 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
3467 may come from Lisp.
3468 (handle_one_xevent): NATNUMP can eval its arg twice.
3469 (x_connection_closed):
3470 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3471 * xterm.h: Adjust decls to match defn changes elsewhere.
3472 (struct scroll_bar): Use struct vectorlike_header
3473 rather than rolling our own approximation.
3474 (SCROLL_BAR_VEC_SIZE): Remove; not used.
3475
c6574eb5
GM
34762012-05-25 Glenn Morris <rgm@gnu.org>
3477
3478 * lisp.mk (lisp): Update for more files being compiled now.
3479
e8d32c7e
SM
34802012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
3481
48def666
SM
3482 * lread.c: Remove `read_pure' which makes no difference.
3483 (read_pure): Remove var.
3484 (unreadpure): Remove function.
3485 (readevalloop): Don't call read_list with -1 flag.
3486 (read1, read_vector): Don't test read_pure any more.
3487 (read_list): Simplify.
3488
e8d32c7e
SM
3489 * fileio.c, character.h: Minor style tweaks.
3490
4b2addb7
DA
34912012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
3492
3493 * window.h (clip_changed): Remove useless declaration.
3494
584461b2
JB
34952012-05-22 Juanma Barranquero <lekktu@gmail.com>
3496
3497 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
3498 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
3499
34374650
PE
35002012-05-22 Paul Eggert <eggert@cs.ucla.edu>
3501
3502 Remove src/m/*.
3503 This directory predates autoconf and is no longer needed nowadays.
3504 Move its few remaining bits of functionality to where they're needed.
3505 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
3506 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
3507 * m/template.h: Remove.
3508 * Makefile.in (M_FILE): Remove. All uses removed.
3509 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
3510 * lisp.h (USE_LSB_TAG):
3511 * mem-limits.h (EXCEEDS_LISP_PTR):
3512 Use VAL_MAX, not VALBITS, in #if.
3513 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
3514 (EMACS_UINT): Define unconditionally now.
3515 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
3516 (BITS_PER_EMACS_INT): New constants, replacing
3517 what used to be in config.h, but not useful in #if.
3518 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
3519 define them any more.
3520 (VAL_MAX): New macro.
3521 (VALMASK): Use it.
3522 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
3523 BITS_PER_EMACS_INT, in #if.
3524 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
3525 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
3526 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
3527 * s/ms-w32.h (DATA_START):
3528 Move here from removed file m/intel386.h.
3529 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
3530 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
3531
261cb4bb
PE
35322012-05-21 Paul Eggert <eggert@cs.ucla.edu>
3533
3534 Assume C89 or later.
3535 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
3536 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
3537 (xrealloc):
3538 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
3539 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
3540 * textprop.c, tparam.c (NULL): Remove.
3541 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
3542 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
3543 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
3544 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
3545 * xterm.c (input_signal_count): Assume volatile works.
3546
ff23cd9f
KB
35472012-05-21 Ken Brown <kbrown@cornell.edu>
3548
3549 * xgselect.c (xg_select): Fix first argument in call to 'select'
3550 (bug#11508).
3551
1b170bc6
KB
35522012-05-20 Ken Brown <kbrown@cornell.edu>
3553
3554 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 3555 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 3556
b2f4d39f
KB
35572012-05-19 Ken Brown <kbrown@cornell.edu>
3558
3559 * xfns.c (x_in_use): Remove `static' qualifier.
3560 * xterm.h (x_in_use): Declare.
3561 * xgselect.c: Include xterm.h.
3562 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
3563 and `display_arg' (bug#9754).
3564
003fdae2
PE
35652012-05-19 Paul Eggert <eggert@cs.ucla.edu>
3566
9232a6d9
PE
3567 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
3568
003fdae2
PE
3569 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
3570 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
3571
784b56e2
EZ
35722012-05-18 Eli Zaretskii <eliz@gnu.org>
3573
3574 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
3575
3576 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 3577 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
3578
3579 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
3580 reference to image_cache->refcount.
3581 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
3582
a0a79cde
JL
35832012-05-17 Juri Linkov <juri@jurta.org>
3584
3585 * search.c (Fword_search_regexp, Fword_search_backward)
3586 (Fword_search_forward, Fword_search_backward_lax)
3587 (Fword_search_forward_lax): Move functions to isearch.el
3588 (bug#10145, bug#11381).
3589
b0572523
PE
35902012-05-16 Paul Eggert <eggert@cs.ucla.edu>
3591
3592 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
3593
9660f5fc
SM
35942012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3595
3596 * lread.c (init_obarray): Declare Qt and Qnil as special.
3597
4374de83
GM
35982012-05-14 Glenn Morris <rgm@gnu.org>
3599
3600 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 3601 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 3602
dc44c39a
PE
36032012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3604
078c97cb
PE
3605 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
3606
dc44c39a
PE
3607 * unexaix.c: Port to more-recent AIX compilers.
3608 (report_error, report_error_1, make_hdr, copy_sym)
3609 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
3610 Make arguments const char *, not char *, to avoid violations of C
3611 standard and to fix some AIX warnings reported by Gilles Pion.
3612
e18afed7 36132012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
3614
3615 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
3616 already have overlays loaded.
3617 (handle_single_display_spec): Before returning without displaying
3618 fringe bitmap, synchronize the bidi iterator with the main display
3619 iterator, by calling iterate_out_of_display_property.
3620 (iterate_out_of_display_property): Detect buffer iteration by
3621 testing that it->string is a Lisp string.
3622 (get_next_display_element): When the current object is exhausted,
3623 and there's something on it->stack, call set_iterator_to_next to
3624 proceed with what's on the stack, instead of returning zero.
3625 (set_iterator_to_next): If called at the end of a Lisp string,
3626 proceed to consider_string_end without incrementing string
3627 position. Don't increment display vector index past the end of
3628 the display vector. (Bug#11417)
c8fb9dc6
EZ
3629 (pos_visible_p): Don't report a position visible when move_it_to
3630 stopped at the last line of window, which happens to be scanned
3631 backwards by the bidi iteration. (Bug#11464)
ac268e67 3632
e18afed7 36332012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
3634
3635 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
3636 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
3637 are on a TTY, and thus unable to display on the fringes.
3638 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
3639 so we need to signal to the caller that this is a "replacing"
3640 display spec. This fixes display when the spec is invalid or we
3641 are on a TTY.
3642
e18afed7 36432012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
3644
3645 * unexaix.c (make_hdr): Fix typo in prototype.
3646 This bug broke the build on AIX. Problem reported by Gilles Pion.
3647
9d0a235a
MA
36482012-05-14 Michael Albinus <michael.albinus@gmx.de>
3649
3650 * keyboard.c (kbd_buffer_get_event): Read special events also in
3651 batch mode. (Bug#11415)
3652
9e6b06ed
GM
36532012-05-12 Glenn Morris <rgm@gnu.org>
3654
3655 * ns.mk: Update for ns_appbindir no longer having trailing "/".
3656
c1a1d7a3
EZ
36572012-05-12 Eli Zaretskii <eliz@gnu.org>
3658
3659 * lisp.mk (lisp): Add newcomment.elc.
3660
3fe7cdc8
GM
36612012-05-12 Glenn Morris <rgm@gnu.org>
3662
3663 * Makefile.in (MKDIR_P): New, set by configure.
3664 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
3665
53f7d2c0
PE
36662012-05-11 Paul Eggert <eggert@cs.ucla.edu>
3667
3668 Remove unused function hourglass_started.
3669 * dispextern.h (hourglass_started):
3670 * w32fns.c (hourglass_started):
3671 * xdisp.c (hourglass_started): Remove.
3672
75aafb17
JB
36732012-05-10 Juanma Barranquero <lekktu@gmail.com>
3674
3675 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
3676 Update dependencies.
3677
12959e8e
PE
36782012-05-10 Paul Eggert <eggert@cs.ucla.edu>
3679
97107e2e
PE
3680 * xgselect.c (xg_select): Put maxfds+1 into a var.
3681 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
3682
12959e8e
PE
3683 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
3684
836d29b3
DA
36852012-05-10 Dave Abrahams <dave@boostpro.com>
3686
3687 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
3688 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
3689
5cb67954
MA
36902012-05-09 Michael Albinus <michael.albinus@gmx.de>
3691
3692 * dbusbind.c (xd_registered_buses): New internal Lisp object.
3693 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
3694 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
3695 Initialize xd_registered_buses.
3696
3478ec45
PE
36972012-05-09 Paul Eggert <eggert@cs.ucla.edu>
3698
b263a6b0
PE
3699 Untag more efficiently if USE_LSB_TAG.
3700 This is based on a proposal by YAMAMOTO Mitsuharu in
3701 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
3702 For an admittedly artificial (nth 8000 longlist) benchmark on
3703 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
3704 Emacs's overall text size by 1%.
3705 * lisp.h (XUNTAG): New macro.
3706 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
3707 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
3708 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
3709 * eval.c (Fautoload):
3710 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
3711 * frame.h (XFRAME): Use XUNTAG.
3712
3478ec45
PE
3713 Port recent dbusbind.c changes to 32-bit --with-wide-int.
3714 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
3715 Remove unportable assumptions about print widths of types like
3716 dbus_uint32_t.
3717 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
3718 intptr_t when converting between pointer and integer, to avoid GCC
3719 warnings about wrong width.
3720
666b903b 37212012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
3722
3723 * w32proc.c (new_child): Force Windows to reserve only 64KB of
3724 stack for each reader_thread, instead of defaulting to 8MB
3725 determined by the linker. This avoids failures in creating
3726 subprocesses on Windows 7, see the discussion in this thread:
3727 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
3728
b120cc17
JC
37292012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
3730
3731 Fix up display of the *Minibuf-0* buffer in the mini window.
3732 * keyboard.c (read_char): Don't clear the echo area if there's no
3733 message to clear.
3734 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 3735 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 3736
9a4b36f8
MA
37372012-05-07 Michael Albinus <michael.albinus@gmx.de>
3738
3739 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
3740 batch mode.
3741
e5f9458f
CY
37422012-05-06 Chong Yidong <cyd@gnu.org>
3743
3744 * lisp.mk (lisp): Update.
3745
eceeb5fc 37462012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
3747
3748 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
3749
71873e2b
SM
37502012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3751
3752 * data.c (PUT_ERROR): New macro.
3753 (syms_of_data): Use it. Add new error type `user-error'.
3754 * undo.c (user_error): New function.
3755 (Fprimitive_undo): Use it.
3756 * print.c (print_error_message): Adjust print style for `user-error'.
3757 * keyboard.c (user_error): New function.
3758 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
3759
ab0fa4e4
PE
37602012-05-03 Paul Eggert <eggert@cs.ucla.edu>
3761
3762 Do not limit current-time-string to years 1000..9999.
3763 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
3764 (Fcurrent_time_string): Support any year that is supported by the
3765 underlying localtime representation. Don't use asctime, as it
3766 has undefined behavior for years outside the range -999..9999.
3767
7ed806a7
PE
37682012-05-02 Paul Eggert <eggert@cs.ucla.edu>
3769
3770 Fix race conditions involving setenv, gmtime, localtime, asctime.
3771 Without this fix, interrupts could mess up code that uses these
3772 nonreentrant functions, since setting TZ invalidates existing
3773 tm_zone or tzname values, and since most of these functions return
3774 pointers to static storage.
3775 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
3776 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
3777 Grow the critical sections to include not just invoking
3778 localtime/gmtime, but also accessing these functions' results
3779 including their tm_zone values if any, and any related TZ setting.
3780 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
3781 so that the struct tm is saved in the critical section.
3782 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
3783 motivated by the fact that memory allocation needs to be outside
3784 the critical section.
3785
0c16dfed
DA
37862012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
3787
3788 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
3789 with RESET_INTERVAL.
3790
3791 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3792 Remove duplicated buffer name initialization.
3793
3f83ace8
JM
37942012-05-02 Jim Meyering <jim@meyering.net>
3795
3796 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
3797
c7b8541e
JM
3798 * xfns.c (x_window): Use xstrdup (Bug#11375).
3799
90207a15 38002012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
3801
3802 * xdisp.c (pos_visible_p): If already at a newline from the
3803 display string before the 'while' loop, don't walk back the glyphs
3804 from it3.glyph_row. Solves assertion violation when the display
3805 string begins with a newline (egg.el). (Bug#11367)
3806
b593d6a9
AH
38072012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
3808
3809 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
3810 Move to simple.el.
3811
4737362e
GM
38122012-05-01 Glenn Morris <rgm@gnu.org>
3813
99cf43f9
GM
3814 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
3815 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
3816 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
3817 All were removed before 23.1.
3818
9311dcff
GM
3819 * dispnew.c: Remove HAVE_LIBNCURSES test;
3820 it is always true on relevant platforms.
3821
4d5c6349
GM
3822 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
3823 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
3824
4737362e
GM
3825 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
3826
74dd3a6b
AS
38272012-04-30 Andreas Schwab <schwab@linux-m68k.org>
3828
3829 * .gdbinit (xpr): Remove checks for no longer existing misc types.
3830 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
3831 Remove.
3832
13c379ee
PE
38332012-04-28 Paul Eggert <eggert@cs.ucla.edu>
3834
3835 Do not avoid creating empty evaporating overlays (Bug#9642).
3836 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
3837 That is, do not delete an evaporating overlay if it becomes
3838 empty after its bounds are adjusted to fit within its buffer.
3839 This fix caused other problems, and I'm reverting it until we get
3840 to the bottom of them.
3841
a8e7d6d7 38422012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
3843
3844 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
3845
a8e7d6d7 38462012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
3847
3848 * xdisp.c (pos_visible_p): If the window start position is beyond
3849 ZV, start the display from buffer beginning. Prevents assertion
3850 violation in init_iterator when the minibuffer window is scrolled
3851 via the scroll bar.
3852
3853 * window.c (window_scroll_pixel_based): Likewise.
3854
a8e7d6d7 38552012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
3856
3857 * keymap.c (where_is_internal): Doc fix (Bug#10872).
3858
a8e7d6d7 38592012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
3860
3861 * fileio.c (Fcopy_file, Fset_file_selinux_context):
3862 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
3863
a8e7d6d7 38642012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 3865
b593d6a9
AH
3866 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
3867 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 3868
1c6900d9
EZ
38692012-04-26 Eli Zaretskii <eliz@gnu.org>
3870
4c3fa1d9
EZ
3871 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
3872 display element, check also the underlying string or buffer
3873 character. (Bug#11341)
3874
1c6900d9
EZ
3875 * w32menu.c: Include w32heap.h.
3876 (add_menu_item): If the call to AppendMenuW (via
3877 unicode_append_menu) fails, disable Unicode menus only if we are
3878 running on Windows 9X/Me.
3879
42bf8205
AS
38802012-04-24 Andreas Schwab <schwab@linux-m68k.org>
3881
3882 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
3883 (xgetint): Add missing shift for LSB tags.
3884
b1bac16e
MR
38852012-04-24 Martin Rudalics <rudalics@gmx.at>
3886
3887 * keyboard.c (read_char): Don't wipe echo area for select window
3888 events: These might get delayed via `mouse-autoselect-window'
3889 (Bug#11304).
3890
d69621cc
JB
38912012-04-24 Juanma Barranquero <lekktu@gmail.com>
3892
3893 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
3894 manipulation of :loaded-from data.
3895
02fd101b
JB
38962012-04-23 Juanma Barranquero <lekktu@gmail.com>
3897
3898 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
3899 now a cons (bug#11311).
3900
888bec30
PE
39012012-04-23 Paul Eggert <eggert@cs.ucla.edu>
3902
89a438bd
PE
3903 Do not create empty overlays with the evaporate property (Bug#9642).
3904 * buffer.c (Fmove_overlay): Delete an evaporating overlay
3905 if it becomes empty after its bounds are adjusted to fit within
3906 its buffer. Without this fix, in a nonempty buffer (let ((o
3907 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
3908 yields an empty overlay that has the evaporate property, which is
3909 not supposed to happen.
3910
1068fe4d
PE
3911 Fix minor GTK3 problems found by static checking.
3912 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3913 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3914 (struct _EmacsFixedClass, emacs_fixed_get_type):
3915 Move decls here from emacsgtkfixed.h, since they needn't be public.
3916 (emacs_fixed_get_type): Now static.
3917 (emacs_fixed_class_init): Omit unused local.
3918 (emacs_fixed_child_type): Remove; unused.
3919 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3920 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3921 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
3922 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
3923 (EMACS_FIXED_GET_CLASS): Remove; unused.
3924 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
3925
888bec30
PE
3926 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
3927 Problem reported by Juanma Barranquero for Windows -Wunused-function.
3928
de85e130
PE
39292012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3930
d0baac98 3931 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 3932 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
3933 (__malloc_size_t, __malloc_ptrdiff_t):
3934 Remove. All uses removed, replaced by the definiens if needed,
3935 since we can assume C89 or better now.
3936 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
3937 (protect_malloc_state, align, get_contiguous_space)
3938 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
3939 (malloc_atfork_handler_child, malloc_enable_thread)
3940 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
3941 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
3942 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
3943 (special_realloc, _realloc_internal_nolock, _realloc_internal)
3944 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
3945 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
3946 Define using prototypes, not old style.
3947 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
3948 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
3949 (align): Don't assume that signed integer overflow wraps around.
3950 Omit unused local var.
3951 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
3952 (_free_internal_nolock, memalign, mallochook, reallochook):
3953 Omit no-longer-needed casts.
3954 (valloc): Use getpagesize, not __getpagesize.
3955 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
3956 (struct hdr): The 'magic' member is now size_t, not unsigned long.
3957
de85e130
PE
3958 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
3959
dcbf5805
MA
39602012-04-22 Michael Albinus <michael.albinus@gmx.de>
3961
3962 Move functions from C to Lisp. Make non-blocking method calls
3963 the default. Implement further D-Bus standard interfaces.
3964
3965 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
3966 (QCdbus_request_name_allow_replacement)
3967 (QCdbus_request_name_replace_existing)
3968 (QCdbus_request_name_do_not_queue)
3969 (QCdbus_request_name_reply_primary_owner)
3970 (QCdbus_request_name_reply_in_queue)
3971 (QCdbus_request_name_reply_exists)
3972 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
3973 (QCdbus_registered_serial, QCdbus_registered_method)
3974 (QCdbus_registered_signal): New Lisp objects.
3975 (XD_DEBUG_MESSAGE): Use sizeof.
3976 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
3977 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
3978 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
3979 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
3980 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
3981 (xd_signature, xd_append_arg): Allow float for integer types.
3982 (xd_get_connection_references): New function.
b593d6a9
AH
3983 (xd_get_connection_address): Rename from xd_initialize.
3984 Return cached address.
dcbf5805
MA
3985 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
3986 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
3987 level.
3988 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 3989 Return number of refcounts.
dcbf5805
MA
3990 (Fdbus_get_unique_name): Make stronger parameter check.
3991 (Fdbus_message_internal): New defun.
3992 (Fdbus_call_method, Fdbus_call_method_asynchronously)
3993 (Fdbus_method_return_internal, Fdbus_method_error_internal)
3994 (Fdbus_send_signal, Fdbus_register_service)
3995 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
3996 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
3997 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
3998 (Vdbus_compiled_version, Vdbus_runtime_version)
3999 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
4000 (Vdbus_message_type_method_return, Vdbus_message_type_error)
4001 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
4002 (Vdbus_registered_buses, Vdbus_registered_objects_table):
4003 Adapt docstring.
dcbf5805 4004
52828e02
PE
40052012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4006
da05bc4c
PE
4007 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
4008 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
4009 Do not assume ptrdiff_t is the same width as 'int'.
4010
52828e02
PE
4011 * alloc.c: Handle unusual debugging option combinations.
4012 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
4013 since the two debugging options are incompatible.
4014 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
4015 is defined.
4016 (mem_init, mem_insert, mem_insert_fixup):
4017 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
4018 (NEED_MEM_INSERT): Remove; no longer needed.
4019
f01769f9
LL
40202012-04-22 Leo Liu <sdl.web@gmail.com>
4021
4022 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
4023
5790543d
PE
40242012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4025
4026 * sysdep.c [__FreeBSD__]: Minor cleanups.
4027 (list_system_processes, system_process_attributes) [__FreeBSD__]:
4028 Use Emacs indenting style more consistently. Avoid some casts.
4029 Use 'double' consistently rather than mixing 'float' and 'double'.
4030
b91b7e4d
EW
40312012-04-21 Eduard Wiebe <usenet@pusto.de>
4032
b593d6a9
AH
4033 * sysdep.c (list_system_processes, system_process_attributes):
4034 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 4035
6114eb15
AS
40362012-04-21 Andreas Schwab <schwab@linux-m68k.org>
4037
4038 * lisp.mk (lisp): Update.
4039
2f38dff7
PE
40402012-04-20 Paul Eggert <eggert@cs.ucla.edu>
4041
4042 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
4043 It is never used otherwise.
4044
4ae29f89
SM
40452012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
4046
4047 * print.c (print_preprocess): Only check print_depth if print-circle
4048 is nil.
4049 (print_object): Check for cycles even when print-circle is nil and
4050 print-gensym is t, but only check print_depth if print-circle is nil.
4051
f30d612a
CY
40522012-04-20 Chong Yidong <cyd@gnu.org>
4053
4054 * process.c (wait_reading_process_output): If EIO occurs on a pty,
4055 set the status to "failed" and ensure that sentinel is run.
4056
c07a4c0b 40572012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
4058
4059 * process.c (Fset_process_inherit_coding_system_flag)
4060 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 4061 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 4062
c07a4c0b 40632012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
4064
4065 * xdisp.c (string_buffer_position_lim): Limit starting position to
4066 BEGV.
4067 (set_cursor_from_row): If called for a mode-line or header-line
4068 row, return zero immediately.
4069 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
4070 farther than the first row after the header line, if any.
4071 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
4072 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
4073
c07a4c0b 40742012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 4075
4ae29f89
SM
4076 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
4077 (bug#11238).
ad3a2b41 4078
c07a4c0b 40792012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 40802012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
4081
4082 configure: new option --enable-gcc-warnings (Bug#11207)
4083 * Makefile.in (C_WARNINGS_SWITCH): Remove.
4084 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
4085 (ALL_CFLAGS): Use new macros rather than old.
4086 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
4087 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
4088 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
4089 -Wunused-result, -Wunused-variable. This should go away once
4090 the Emacs and Gnulib regex code is merged.
4091 (xmalloc, xrealloc): Now static.
4092
aba027e8
PE
40932012-04-17 Paul Eggert <eggert@cs.ucla.edu>
4094
4095 * dired.c (Fsystem_groups): Remove unused local.
4096
e5a36063
GM
40972012-04-17 Glenn Morris <rgm@gnu.org>
4098
4099 * dired.c (Fsystem_users): Doc fix.
4100
316411f0
DA
41012012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
4102
4103 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
4104 (syms_of_dired): Add them.
4105
9426aba4
PE
41062012-04-16 Paul Eggert <eggert@cs.ucla.edu>
4107
b62a57be
PE
4108 Fix minor alloc.c problems found by static checking.
4109 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
4110 New extern decls, to avoid calling undeclared functions.
4111 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
4112 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
4113 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
4114 (NEED_MEM_INSERT): New macro.
4115 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 4116 Remove one incorrect comment and fix another.
b62a57be 4117
3539f31f
PE
4118 Fix minor ralloc.c problems found by static checking.
4119 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4120 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
4121 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
4122 (r_alloc_sbrk): Now static.
4123
a041960a
PE
4124 Improve ralloc.c interface checking.
4125 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4126 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
4127 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
4128 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
4129 [REL_ALLOC]: ... to here, to check interface.
4130 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
4131 Remove decls. This fixes an "It stinks!".
4132
9426aba4
PE
4133 * alloc.c (which_symbols): Fix alignment issue / type clash.
4134
d55c12ed
AS
41352012-04-15 Andreas Schwab <schwab@linux-m68k.org>
4136
4137 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
4138 (struct Lisp_Misc_Any): Likewise.
4139 (struct Lisp_Free): Likewise.
4140 * alloc.c (union aligned_Lisp_Symbol): Define.
4141 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
4142 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
4143 (union aligned_Lisp_Misc): Define.
4144 (MARKER_BLOCK_SIZE, struct marker_block): Use union
4145 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 4146 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 4147
b948ce8b
PE
41482012-04-14 Paul Eggert <eggert@cs.ucla.edu>
4149
4150 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
4151 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
4152 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
4153 * s/netbsd.h, s/sol2-6.h:
4154 Remove definition of GC_MARK_STACK, since the default now works.
4155 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
4156 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
4157 no longer the default.
4158 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
4159
35dc09a1 41602012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 4161
35dc09a1
GM
4162 * lread.c (lisp_file_lexically_bound_p):
4163 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 4164
35dc09a1
GM
41652012-04-14 Eli Zaretskii <eliz@gnu.org>
4166
4167 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
4168 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
4169
41702012-04-14 Jan Djärv <jan.h.d@swipnet.se>
4171
4172 * nsterm.m (constrainFrameRect): Always constrain when there is only
4173 one screen (Bug#10962).
4174
bcd86815
KB
41752012-04-13 Ken Brown <kbrown@cornell.edu>
4176
4177 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
4178
c25df26e
RT
41792012-04-13 Reuben Thomas <rrt@sc3d.org>
4180
4181 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
4182
0fc59f1e
DC
41832012-04-11 Daniel Colascione <dancol@dancol.org>
4184
4185 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
4186 against is gone. It's better to use vfork now so that when Cygwin
4187 gains a new, working vfork, we use it automatically (bug#10398).
4188
de8c03dc
SM
41892012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4190
4191 * window.c (save_window_save): Obey window-point-insertion-type.
4192
2f097256
GM
41932012-04-11 Glenn Morris <rgm@gnu.org>
4194
4195 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
4196
453b951e
SM
41972012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4198
4199 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
4200
75f1671a 42012012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
4202
4203 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
4204 (force_quit_count): New var.
4205 (handle_interrupt): Use it.
4206
2a8ce227
JB
42072012-04-10 Juanma Barranquero <lekktu@gmail.com>
4208
4209 * w32.c (w32_delayed_load): Record the full path of the library
4210 being loaded (bug#10424).
4211
935396c0
GM
42122012-04-09 Glenn Morris <rgm@gnu.org>
4213
05920a43
GM
4214 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
4215 not just in the obarray, before snarfing them. (Bug#11036)
4216
935396c0
GM
4217 * Makefile.in ($(leimdir)/leim-list.el):
4218 Pass EMACS rather than BUILT_EMACS.
4219
a18ecafa
TZ
42202012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
4221
4222 * process.c (make_process):
4223 * process.h: Add integer `gnutls_handshakes_tried' member to
4224 process struct.
4225
6bbef4e5
JC
4226 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
4227 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
4228
4229 * gnutls.c (gnutls_log_function2i): Convenience log function.
4230 (emacs_gnutls_read): Use new log functions,
4231 `gnutls_handshakes_tried' process member, and
4232 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
4233 attempts per process (connection).
4234
b4d3bc10
CY
42352012-04-09 Chong Yidong <cyd@gnu.org>
4236
4237 * eval.c (Fuser_variable_p, user_variable_p_eh)
4238 (lisp_indirect_variable): Functions deleted.
4239 (Fdefvar): Caller changed.
4240
4241 * callint.c (Finteractive, Fcall_interactively):
4242 * minibuf.c (Fread_variable): Callers changed.
4243
70f4d973
EZ
42442012-04-09 Eli Zaretskii <eliz@gnu.org>
4245
4246 * xdisp.c (set_cursor_from_row): If the display string appears in
4247 the buffer at position that is closer to point than the position
4248 after the display string, display the cursor on the first glyph of
4249 the display string. Fixes cursor display when a 'display' text
4250 property immediately follows invisible text. (Bug#11094)
4251
cb3c2e3e
PE
42522012-04-09 Paul Eggert <eggert@cs.ucla.edu>
4253
4254 composite.c: use 'double' consistently
4255 * composite.c (get_composition_id): Use 'double' consistently
4256 instead of converting 'float' to 'double' and vice versa; this is
4257 easier to understand and avoids a GCC warning.
4258
fd06db5d
GM
42592012-04-09 Glenn Morris <rgm@gnu.org>
4260
50fe702a
GM
4261 * Makefile.in: Generate leim-list with bootstrap-emacs, in
4262 preparation for dumping it with emacs. (Bug#4789)
4263 (leimdir): New variable.
4264 ($(leimdir)/leim-list.el): New rule.
4265 (emacs$(EXEEXT)): Depend on leim-list.el.
4266
fd06db5d
GM
4267 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
4268 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
4269 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
4270
55c131ee
AS
42712012-04-08 Andreas Schwab <schwab@linux-m68k.org>
4272
4273 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
4274 proper alignment.
4275
9209588f
JB
42762012-04-07 Juanma Barranquero <lekktu@gmail.com>
4277
4278 * xml.c (init_libxml2_functions) [WINDOWSNT]:
4279 Remove unused local variable.
4280
e3fb2efb
PE
42812012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4282
4283 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
4284 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
4285 (mark_memory): Mark Lisp_Objects only if pointers might hide in
4286 objects, as mark_maybe_pointer will catch them otherwise.
4287 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
4288 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
4289
b5385551
PE
42902012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4291
4292 Fix typo that broke non-Windows builds.
4293 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
4294
9078ead6
EZ
42952012-04-07 Eli Zaretskii <eliz@gnu.org>
4296
4297 Support building on MS-Windows with libxml2.
4298
4299 * makefile.w32-in (OBJ2): Add xml.$(O).
4300 (GLOBAL_SOURCES): Add xml.c.
4301 ($(BLD)/xml.$(O)): New dependency list.
4302
4303 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
4304 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
4305 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
4306 [!WINDOWSNT]: New macros.
4307 (init_libxml2_functions, libxml2_loaded_p): New functions.
4308 (parse_region): Call fn_xmlCheckVersion instead of using the macro
4309 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
4310 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
4311 Calls xmlCleanupParser only if libxml2 was loaded (or statically
4312 linked in).
6bbef4e5
JC
4313 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
4314 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
4315 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
4316
4317 * emacs.c: Don't include libxml/parser.h.
4318 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
4319 xmlCleanupParser directly.
4320
4321 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
4322
3811fdf3
EZ
43232012-04-07 Eli Zaretskii <eliz@gnu.org>
4324
4325 * indent.c (Fvertical_motion): If there is a display string at
4326 point, use it.vpos to compute how many lines to backtrack after
4327 move_it_to point. (Bug#11133)
4328
2f8e16b2
EZ
43292012-04-06 Eli Zaretskii <eliz@gnu.org>
4330
4331 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
4332 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
4333 about subtle differences between FETCH_CHAR* and STRING_CHAR*
4334 macros related to unification of CJK characters. For the details,
4335 see the discussion following the message here:
4336 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
4337
3d439cd1
CY
43382012-04-04 Chong Yidong <cyd@gnu.org>
4339
4340 * keyboard.c (Vdelayed_warnings_list): Doc fix.
4341
8bc53d00
EZ
43422012-04-01 Eli Zaretskii <eliz@gnu.org>
4343
4344 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
4345 instead of alloca. (Bug#11138)
4346
3b0512a3
AS
43472012-04-01 Andreas Schwab <schwab@linux-m68k.org>
4348
4349 * w32menu.c (is_simple_dialog): Properly check lisp types.
4350 (Bug#11141)
4351
8427ddd2
EZ
43522012-03-31 Eli Zaretskii <eliz@gnu.org>
4353
979022ef
EZ
4354 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
4355 position we get to after a call to move_it_to fails the
4356 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
4357 only if we wind up in a string from display property. (Bug#11063)
4358
a6b1c7cc
EZ
4359 * window.c (Fdelete_other_windows_internal): Invalidate the row
4360 and column information about mouse highlight, so that redisplay
4361 restores it after reallocating the glyph matrices. (Bug#7464)
4362
8427ddd2
EZ
4363 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
4364 string comes from a `display' text property, use the buffer
4365 position of that property as if we actually saw that position in
4366 the row's glyphs.
697ba24b
EZ
4367 (move_it_by_lines): Remove the assertion that
4368 "it->current_x == 0 && it->hpos == 0" which can be legitimately
4369 violated when there's a before-string at the beginning of a line.
4370 (Bug#11063)
8427ddd2 4371
65a0a738
EZ
43722012-03-30 Eli Zaretskii <eliz@gnu.org>
4373
4374 * xdisp.c (append_space_for_newline): If the default face was
4375 remapped, use the remapped face for the appended newline.
4376 (extend_face_to_end_of_line): Use the remapped default face for
4377 extending the face to the end of the line.
4378 (display_line): Call extend_face_to_end_of_line when the default
4379 face was remapped. (Bug#11068)
4380
581355cc
EZ
43812012-03-29 Eli Zaretskii <eliz@gnu.org>
4382
4383 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
4384
e8fc049f
SM
43852012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4386
4387 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
4388
4fb9a543
GM
43892012-03-27 Glenn Morris <rgm@gnu.org>
4390
4391 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
4392 Doc fixes.
4393
679910f1
KH
43942012-03-26 Kenichi Handa <handa@m17n.org>
4395
4396 * dispextern.h (struct glyph): Fix previous change. Change the
4397 bit length of glyphless.ch to 25 (Bug#11082).
4398
90d49b7f
CY
43992012-03-26 Chong Yidong <cyd@gnu.org>
4400
4401 * keyboard.c (Vselection_inhibit_update_commands): New variable.
4402 (command_loop_1): Use it; inhibit selection update for
4403 handle-select-window too (Bug#8996).
4404
f514f6f0
FP
44052012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
4406
e8fc049f 4407 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 4408
bf43fa51
KH
44092012-03-25 Kenichi Handa <handa@m17n.org>
4410
4411 * dispextern.h (struct glyph): Change the bit length of
4412 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
4413
8a0c01dd
EZ
44142012-03-24 Eli Zaretskii <eliz@gnu.org>
4415
4416 * s/ms-w32.h (tzname): Include time.h before redirecting to
4417 _tzname. Fixes the MSVC build. (Bug#9960)
4418
7d1c3a76
AS
44192012-03-24 Andreas Schwab <schwab@linux-m68k.org>
4420
8ed79523
AS
4421 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
4422 characters.
4423
7d1c3a76
AS
4424 * xterm.c (XTread_socket): Only modify handling_signal if
4425 !SYNC_INPUT. (Bug#11080)
4426
e99a9b8b
EZ
44272012-03-23 Eli Zaretskii <eliz@gnu.org>
4428
4429 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
4430 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
4431 when fetching a multibyte character consumes more bytes than
4432 CHAR_BYTES returns, due to unification of CJK characters in
4433 string_char. (Bug#11073)
4434
5063c0e1
TN
44352012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
4436
4437 * process.c (wait_reading_process_output): Handle pty disconnect
4438 by refraining from sending oneself a SIGCHLD (bug#10933).
4439
9f851fbd
CY
44402012-03-22 Chong Yidong <cyd@gnu.org>
4441
4442 * dispextern.h (struct it): New member string_from_prefix_prop_p.
4443
5063c0e1 4444 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
4445 Mark string as coming from a prefix property.
4446 (handle_face_prop): Use default face for prefix strings (Bug#4281).
4447 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
4448
fb5b8aca
CY
44492012-03-21 Chong Yidong <cyd@gnu.org>
4450
4451 * xfaces.c (Vface_remapping_alist): Doc fix.
4452
62356a1b
EZ
44532012-03-20 Eli Zaretskii <eliz@gnu.org>
4454
4455 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
4456 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
4457 Doc fixes.
62356a1b 4458
025de85b
CY
44592012-03-20 Chong Yidong <cyd@gnu.org>
4460
4461 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
4462 to reflect default non-nil value of redisplay-dont-pause.
4463
4827f94e
KH
44642012-03-19 Kenichi Handa <handa@m17n.org>
4465
4466 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
4467 it fit in a valid range (Bug#11003).
4468
e50a24a2
EZ
44692012-03-18 Eli Zaretskii <eliz@gnu.org>
4470
4471 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
4472 that is not from display property, accept the row as a "cursor
4473 row" if one of the string's character has a non-nil `cursor'
4474 property. Fixes cursor positioning when there are newlines in
4475 overlay strings, e.g. in icomplete.el. (Bug#11035)
4476
9af5ed87
PE
44772012-03-12 Paul Eggert <eggert@cs.ucla.edu>
4478
4479 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
4480
d1f55f16
CY
44812012-03-12 Chong Yidong <cyd@gnu.org>
4482
4483 * eval.c (inhibit_lisp_code): Rename from
4484 inhibit_window_configuration_change_hook; move from window.c.
4485
4486 * xfns.c (unwind_create_frame_1, Fx_create_frame):
4487 * window.c (run_window_configuration_change_hook)
4488 (syms_of_window): Callers changed.
4489
66c5eebd
CY
44902012-03-11 Chong Yidong <cyd@gnu.org>
4491
413df973
CY
4492 * keymap.c (Fkey_description): Doc fix (Bug#9700).
4493
66c5eebd
CY
4494 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
4495
1de11f56
CY
44962012-03-10 Chong Yidong <cyd@gnu.org>
4497
4498 * frame.c (other_visible_frames): Don't assume the selected frame
4499 is visible (Bug#10955).
4500
cae07000
SM
45012012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
4502
4503 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
4504
89c94350
JD
45052012-03-08 Jan Djärv <jan.h.d@swipnet.se>
4506
4507 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
4508 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
4509 zero (Bug#10954).
4510
999dd333
GM
45112012-03-03 Glenn Morris <rgm@gnu.org>
4512
01a6dcc8 4513 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 4514
de0100f2
EZ
45152012-03-02 Eli Zaretskii <eliz@gnu.org>
4516
4517 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
4518 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
4519 (redisplay_window, next_element_from_string): Fix typos in
4520 comments.
3e441275
EZ
4521 (redisplay_window): Pass to move_it_vertically the margin in
4522 pixels, not in screen lines.
de0100f2 4523
96a72ee9
GM
45242012-03-02 Glenn Morris <rgm@gnu.org>
4525
4526 * buffer.c (buffer-list-update-hook): Doc fix.
4527
312508d7
EZ
45282012-02-29 Eli Zaretskii <eliz@gnu.org>
4529
4530 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
4531 push_it before setting up the iterator for the first overlay
4532 string, even if we have an empty string loaded.
4533 (next_overlay_string): If there's an empty string on the iterator
4534 stack, pop the stack. (Bug#10903)
4535
27f3c637
PE
45362012-02-25 Paul Eggert <eggert@cs.ucla.edu>
4537
4538 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
4539 Suggested by Stefan Monnier in
4540 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
4541 * alloc.c (widen_to_Lisp_Object): New static function.
4542 (mark_memory): Also mark Lisp_Objects by fetching pointer words
4543 and widening them to Lisp_Objects. This would work even if
4544 USE_LSB_TAG is defined and wide integers are used, which might
4545 happen in a future version of Emacs.
4546
3c9dfce6
CY
45472012-02-25 Chong Yidong <cyd@gnu.org>
4548
fa74b241
CY
4549 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
4550 Doc fix.
4551
3c9dfce6
CY
4552 * xselect.c (Fx_selection_exists_p): Doc fix.
4553 (x_clipboard_manager_save_all): Print an informative message
4554 before saving to clipboard manager.
4555
9486df08
CY
45562012-02-24 Chong Yidong <cyd@gnu.org>
4557
4558 * keyboard.c (process_special_events): Handle all X selection
4559 requests in kbd_buffer, not just the next one (Bug#8869).
4560
f01d3321
CY
45612012-02-23 Chong Yidong <cyd@gnu.org>
4562
4563 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
4564 call when setting menu-bar-lines and tool-bar-lines parameters.
4565 (unwind_create_frame_1): New helper function.
4566
4567 * window.c (inhibit_window_configuration_change_hook): New var.
4568 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 4569 (syms_of_window): Initialize it.
f01d3321 4570
86b847b6
CY
45712012-02-22 Chong Yidong <cyd@gnu.org>
4572
4573 * xterm.c (x_draw_image_relief): Add missing type check for
4574 Vtool_bar_button_margin (Bug#10743).
4575
a59225b1
CY
45762012-02-21 Chong Yidong <cyd@gnu.org>
4577
4578 * fileio.c (Vfile_name_handler_alist): Doc fix.
4579
4580 * buffer.c (Fget_file_buffer): Protect against invalid file
4581 handler return value.
4582
310f5bd4
PE
45832012-02-20 Paul Eggert <eggert@cs.ucla.edu>
4584
cb3a28cc
PE
4585 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
4586 when computing $valmask.
4587
310f5bd4
PE
4588 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
4589 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
4590 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
4591 It's useless in that case, and it can cause problems on hosts
4592 that allocate halves of EMACS_INT values separately.
4593 Reported by Dan Horák. Diagnosed by Andreas Schwab in
4594 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
4595 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
4596 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
4597 it avoids undefined behavior on hosts where shifting right by more
4598 than the word width has undefined behavior.
4599
2375c96a
CY
46002012-02-19 Chong Yidong <cyd@gnu.org>
4601
4602 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
4603 (Funhandled_file_name_directory, Ffile_name_as_directory)
4604 (Fdirectory_file_name, Fexpand_file_name)
4605 (Fsubstitute_in_file_name): Protect against invalid file handler
4606 return values (Bug#10845).
4607
3eb49e71
EZ
46082012-02-18 Eli Zaretskii <eliz@gnu.org>
4609
4610 * .gdbinit (pitx): Fix incorrect references to fields of the
4611 iterator stack.
4612
7b926f3f
CY
46132012-02-17 Chong Yidong <cyd@gnu.org>
4614
4615 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
4616
11273115
PE
46172012-02-15 Paul Eggert <eggert@cs.ucla.edu>
4618
4619 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
4620 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
4621
c3a70e2b
CY
46222012-02-15 Chong Yidong <cyd@gnu.org>
4623
4624 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
4625 marked as special. Also, starting docstrings with * is obsolete.
4626
0ca43699
AS
46272012-02-13 Andreas Schwab <schwab@linux-m68k.org>
4628
4629 * gnutls.c (emacs_gnutls_write): Fix last change.
4630
2e8f3c56
LI
46312012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
4632
4633 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
4634 send_process.
4635
af70074f
SM
46362012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
4637
4638 * keymap.c (Fsingle_key_description): Handle char ranges.
4639
95986d52
CY
46402012-02-12 Chong Yidong <cyd@gnu.org>
4641
afd83bd1
CY
4642 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
4643 as that creates a dangerous corner case.
4644
95986d52
CY
4645 * window.c (Fdelete_window_internal): Invalidate the mouse
4646 highlight (Bug#9904).
4647
bd7da63e
GM
46482012-02-12 Glenn Morris <rgm@gnu.org>
4649
4650 * xselect.c (Fx_own_selection_internal)
4651 (Fx_get_selection_internal, Fx_disown_selection_internal)
4652 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
4653 * nsselect.m (Fx_own_selection_internal)
4654 (Fx_disown_selection_internal, Fx_selection_exists_p)
4655 (Fx_selection_owner_p, Fx_get_selection_internal):
4656 Sync docs and argument specs with the xselect.c versions.
4657
77abcbc2
LI
46582012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
4659
4660 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
4661
90b671e2
EZ
46622012-02-11 Eli Zaretskii <eliz@gnu.org>
4663
1c0ca0b7
EZ
4664 * w32select.c (Fx_selection_exists_p): Sync doc string and
4665 argument list with xselect.c. (Bug#10783)
4666
4667 * w16select.c (Fx_selection_exists_p): Sync doc string and
4668 argument list with xselect.c. (Bug#10783)
90b671e2 4669
49241268
GM
46702012-02-10 Glenn Morris <rgm@gnu.org>
4671
4672 * fns.c (Fsecure_hash): Doc fix.
4673
f998bbe7 46742012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
4675
4676 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
4677
0992bd9c
CY
46782012-02-07 Chong Yidong <cyd@gnu.org>
4679
4680 * buffer.c (Fbuffer_local_variables)
4681 (buffer_lisp_local_variables): Handle unbound vars correctly;
4682 don't let Qunbound leak into Lisp.
4683
af008560
GM
46842012-02-07 Glenn Morris <rgm@gnu.org>
4685
dd605cc4
GM
4686 * image.c (Fimagemagick_types): Doc fix.
4687
af008560
GM
4688 * image.c (imagemagick-render-type): Change it from a lisp object
4689 to an integer. Move the doc here from the lisp manual.
4690 Treat all values not equal to 0 the same.
4691
1449fa1d
CY
46922012-02-06 Chong Yidong <cyd@gnu.org>
4693
4694 * doc.c (store_function_docstring): Avoid applying docstring of
4695 alias to base function (Bug#2603).
4696
3723ec07
AS
46972012-02-04 Andreas Schwab <schwab@linux-m68k.org>
4698
4699 * .gdbinit (pp1, pv1): Remove redundant defines.
4700 (pr): Use pp.
4701
79c1cc1e
CY
47022012-02-04 Chong Yidong <cyd@gnu.org>
4703
4704 * nsterm.m: Declare a global (Bug#10694).
4705
d7f29f8e
EZ
47062012-02-04 Eli Zaretskii <eliz@gnu.org>
4707
cae07000
SM
4708 * w32.c (get_emacs_configuration_options):
4709 Include --enable-checking, if specified, in the return value.
d7f29f8e 4710
3b95a6f9
MR
47112012-02-04 Martin Rudalics <rudalics@gmx.at>
4712
4713 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
4714 after rounding frame sizes. (Bug#9723)
4715
d6fa96a6
EZ
47162012-02-04 Eli Zaretskii <eliz@gnu.org>
4717
4718 * keyboard.c (adjust_point_for_property): Don't position point
4719 before BEGV. (Bug#10696)
4720
df0b2940
PE
47212012-02-03 Paul Eggert <eggert@cs.ucla.edu>
4722
4723 Handle overflow when computing char display width (Bug#9496).
4724 * character.c (char_width): Return EMACS_INT, not int.
4725 (char_width, c_string_width): Check for overflow when
4726 computing the width; this is possible now that individual
4727 characters can have unbounded width. Problem introduced
4728 by merge from Emacs 23 on 2012-01-19.
4729
6bee44d6
MA
47302012-02-02 Michael Albinus <michael.albinus@gmx.de>
4731
4732 * dbusbind.c (Fdbus_register_method): Mention the return value
4733 :ignore in the docstring.
4734
44f92739
GM
47352012-02-02 Glenn Morris <rgm@gnu.org>
4736
1b9f60cc
GM
4737 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
4738
44f92739
GM
4739 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4740 Unconditionally set to t. (Bug#10673)
4741 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4742 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4743 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
4744
c5d3843c
KH
47452012-02-02 Kenichi Handa <handa@m17n.org>
4746
4747 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
4748 0, do not call append_composite_glyph.
4749
159462d4 47502012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
4751
4752 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
4753 NULL (Bug#6988).
4754 (x_produce_glyphs): If the component of a composition is a null
4755 string, set it->pixel_width to 1 to avoid zero-width glyph.
4756
78cef877
EZ
47572012-02-01 Eli Zaretskii <eliz@gnu.org>
4758
4759 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
4760 first 2 arguments are identical. This makes inserting large
4761 output from a subprocess an order of magnitude faster on
4762 MS-Windows, where all sbrk'ed memory is always contiguous.
4763
97897668
GM
47642012-01-31 Glenn Morris <rgm@gnu.org>
4765
4766 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 4767 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
4768 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
4769
31fd3586
GM
47702012-01-29 Glenn Morris <rgm@gnu.org>
4771
4772 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
4773
0e24a8b2
CY
47742012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
4775
4776 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
4777
cc0adcb0
CY
47782012-01-28 Chong Yidong <cyd@gnu.org>
4779
4780 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
4781
acc28cb9
CY
47822012-01-26 Chong Yidong <cyd@gnu.org>
4783
9c69cfb7
CY
4784 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
4785
acc28cb9
CY
4786 * search.c (Fsearch_forward, Fsearch_backward): Document negative
4787 repeat counts (Bug#10507).
4788
48da7392
GM
47892012-01-26 Glenn Morris <rgm@gnu.org>
4790
4791 * lread.c (syms_of_lread): Doc fix.
4792
14af5f7f
CY
47932012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
4794
4795 * coding.c (encode_designation_at_bol): Change return value to
4796 EMACS_INT.
4797
0b21c100
CY
47982012-01-25 Chong Yidong <cyd@gnu.org>
4799
4800 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
4801
3c2907f7
CY
48022012-01-21 Chong Yidong <cyd@gnu.org>
4803
4804 * floatfns.c (Fcopysign): Make the second argument non-optional,
4805 since nil is not allowed anyway.
4806
959ad23f
AS
48072012-01-21 Andreas Schwab <schwab@linux-m68k.org>
4808
4809 * process.c (read_process_output): Use p instead of XPROCESS (proc).
4810 (send_process): Likewise.
4811
34a02f46
MR
48122012-01-19 Martin Rudalics <rudalics@gmx.at>
4813
4814 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
4815 (Vwindow_persistent_parameters): Do not use Qstate.
4816 Rewrite doc-strings.
34a02f46 4817
1259009a 48182012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
4819
4820 * character.c (char_width): New function.
70d4fdf6
GM
4821 (Fchar_width, c_string_width, lisp_string_width):
4822 Use char_width (Bug#9496).
25ed9e61 4823
6a6ee00d
MR
48242012-01-16 Martin Rudalics <rudalics@gmx.at>
4825
4826 * window.c (Vwindow_persistent_parameters): New variable.
4827 (Fset_window_configuration, save_window_save): Handle persistent
4828 window parameters.
4829
c85efaf7
EZ
48302012-01-14 Eli Zaretskii <eliz@gnu.org>
4831
4832 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
4833 thrashing the stack of the thread. (Bug#9087)
4834
5944709e
PE
48352012-01-12 Paul Eggert <eggert@cs.ucla.edu>
4836
4837 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
4838
e71f5d99
EZ
48392012-01-11 Eli Zaretskii <eliz@gnu.org>
4840
4841 * xdisp.c (rows_from_pos_range): Handle the case where the
4842 highlight ends on a newline. (Bug#10464)
4843 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
4844 he end column for display of highlight that ends on a newline
4845 before a R2L line.
4846
ce316182
GM
48472012-01-11 Glenn Morris <rgm@gnu.org>
4848
4849 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
4850 from load-path also when installation-directory is nil. (Bug#10208)
4851
5b43da69
GM
48522012-01-10 Glenn Morris <rgm@gnu.org>
4853
74cc8ff9
GM
4854 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
4855
7d8d6e4e
GM
4856 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
4857 Update template values to be closer to their typical values these days.
5b43da69 4858
a0db8d43
EZ
48592012-01-09 Eli Zaretskii <eliz@gnu.org>
4860
4861 * xdisp.c (rows_from_pos_range): Accept additional argument
4862 DISP_STRING, and accept any glyph in a row whose object is that
4863 string as eligible for mouse highlight. Fixes mouse highlight of
4864 display strings from overlays. (Bug#10464)
4865
9a0115ab 48662012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 4867
b9110d6a 4868 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
4869 * fileio.c (auto_saving_dir_umask): New static var.
4870 (Fmake_directory_internal): Use it.
4871 (do_auto_save_make_dir): Set it, instead of invoking chmod after
4872 creating the directory. The old code temporarily assigns
4873 too-generous permissions to the directory.
4874 (do_auto_save_eh): Clear it.
b9110d6a 4875 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
4876 that the var is always cleared.
4877
6c1bd3f3
EZ
48782012-01-07 Eli Zaretskii <eliz@gnu.org>
4879
4880 * search.c (scan_buffer): Pass character positions to
4881 know_region_cache, not byte positions. (Bug#6540)
4882
069d2b50
L
48832012-01-07 LynX <_LynX@bk.ru> (tiny change)
4884
4885 * w32.c (sys_rename): Report EXDEV when rename of a directory
4886 fails because the target is on another logical disk. (Bug#10284)
4887
75bf0d33
DB
48882012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
4889
4890 * xterm.c (x_embed_request_focus): New function.
4891
4892 * xterm.h: Add prototype.
4893
4894 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
4895
1c6e5a32
GM
48962012-01-05 Glenn Morris <rgm@gnu.org>
4897
4898 * emacs.c (emacs_copyright): Update short copyright year to 2012.
4899
651e947e
EZ
49002012-01-01 Eli Zaretskii <eliz@gnu.org>
4901
4902 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
4903 Load gnutls_transport_set_lowat only if GnuTLS version is below
4904 2.11.1.
4905 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
4906 GnuTLS versions below 2.11.1.
4907
3778cdd8
AL
49082011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
4909
4910 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
4911 to the doc string advising against its use for altering the way
4912 windows are scrolled.
4913
0e5317f7
KH
49142011-12-28 Kenichi Handa <handa@m17n.org>
4915
4916 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
4917 coding-system ASCII compatible only when it does not produce BOM
4918 on encoding (Bug#10383).
4919
93d5ca1f
JD
49202011-12-26 Jan Djärv <jan.h.d@swipnet.se>
4921
4922 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
4923 can scroll.
4924 (create_and_show_popup_menu): Always use menu_position_func for
4925 Gtk3 (Bug#10361).
4926
ca22b785
AS
49272011-12-24 Andreas Schwab <schwab@linux-m68k.org>
4928
4929 * callint.c (Fcall_interactively): Don't truncate prompt string.
4930
d048e1e6
EZ
49312011-12-23 Eli Zaretskii <eliz@gnu.org>
4932
4933 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
4934 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 4935 resumed from there (after widening). (Bug#10360)
d048e1e6 4936
5ccaba1f
JD
49372011-12-22 Jan Djärv <jan.h.d@swipnet.se>
4938
4939 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
4940
204ee57f
JD
49412011-12-21 Jan Djärv <jan.h.d@swipnet.se>
4942
b81d40f0
JB
4943 * nsterm.m (x_free_frame_resources):
4944 Release f->output_data.ns->miniimage.
204ee57f
JD
4945 (ns_index_color): Fix indentation. Do not retain
4946 color_table->colors[i].
4947
4948 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
4949 before returning.
4950
4951 * nsfns.m (x_set_background_color): Assign return value from
4952 ns_index_color to face-background instead of NSColor*.
4953 (ns_implicitly_set_icon_type): Fix indentation.
4954 Change assignment in for loop to comparison.
4955
4956 * emacs.c (ns_pool): New variable.
4957 (main): Assign ns_pool.
4958 (Fkill_emacs): Call ns_release_autorelease_pool.
4959
4960 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
4961 autorelease fdesc, release fdAttrs and tdict.
4962 (ns_get_covering_families): Release charset.
4963 (ns_findfonts): Release NSFontDescriptor created with new.
4964 (ns_uni_to_glyphs): Fix indentation.
4965 (setString): Release attrStr before assigning new value.
4966
c803b2b7
JD
49672011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4968
678f4426
JD
4969 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
4970 and NS_IMPL_COCOA.
4971 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
4972 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
4973
cd394be1 49742011-12-18 David Reitter <reitter@cmu.edu>
678f4426 4975
5fecd5fc
JD
4976 * nsterm.m (ns_term_init): Subscribe for notifications
4977 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
4978 to method trackingNotification in EmacsMenu.
4979
4980 * nsmenu.m (trackingMenu): New variable.
3771cb17 4981 (trackingNotification): New method (from Aquamacs).
5fecd5fc 4982 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 4983 from Aquamacs (Bug#7030).
678f4426
JD
4984
49852011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 4986
c803b2b7
JD
4987 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
4988 (symbol_to_nsstring): Fix indentation.
4989 (ns_symbol_to_pb): New function.
cae07000
SM
4990 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
4991 (Fns_rotate_cut_buffers_internal): Remove.
4992 (Fns_store_selection_internal): Rename from
c803b2b7
JD
4993 Fns_store_cut_buffer_internal.
4994 (ns_get_foreign_selection, Fx_own_selection_internal)
4995 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
4996 (Fns_get_selection_internal, Fns_store_selection_internal):
4997 Use ns_symbol_to_pb and check if return value is nil.
4998 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
4999 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
5000 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
5001 renamed to Sns_store_selection_internal.
5002 (ns_handle_selection_request): Move code to Fx_own_selection_internal
5003 and remove this function.
5004 (ns_handle_selection_clear): Remove, never used.
5005 (Fx_own_selection_internal): Move code from ns_handle_selection_request
5006 here.
5007
e1b01a3a
KB
50082011-12-17 Ken Brown <kbrown@cornell.edu>
5009
5010 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
5011 GID is unknown (Bug#10257).
5012
2adb6e85
PE
50132011-12-17 Paul Eggert <eggert@cs.ucla.edu>
5014
5015 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
5016 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
5017 which caused a build failure on GNU/Linux IA-64. This problem was
5018 introduced by my 2011-10-07 patch.
5019
d1d7b339
JL
50202011-12-15 Juri Linkov <juri@jurta.org>
5021
5022 * image.c (imagemagick_error): New function. (Bug#10112)
5023 (imagemagick_load_image): Comment out `MagickSetResolution' call.
5024 Use `imagemagick_error' where ImageMagick functions return
5025 `MagickFalse'.
5026 (Fimagemagick_types): Add `Fnreverse' to return the list in the
5027 proper order.
5028
100d5755
KH
50292011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5030
5031 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
5032 fill background (Bug#8992).
5033
454592a6
MR
50342011-12-13 Martin Rudalics <rudalics@gmx.at>
5035
5036 * window.c (Vwindow_combination_resize)
5037 (Vwindow_combination_limit): Use t instead of non-nil in
5038 doc-strings.
61d4b438
MR
5039 (Vrecenter_redisplay): Add first sentence of doc-string on
5040 separate line.
53524d93 5041 (Frecenter): Fix doc-string typo.
454592a6 5042
3633e3aa
KH
50432011-12-11 Kenichi Handa <handa@m17n.org>
5044
5045 * coding.c (Funencodable_char_position): Pay attention to the
5046 buffer text relocation (Bug#9389).
5047
7b9d523a 50482011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 5049
7b9d523a
JD
5050 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
5051 gtk_init (Bug#10100).
5052
b73189c6
EZ
50532011-12-10 Eli Zaretskii <eliz@gnu.org>
5054
5055 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
5056 IT->string is nil. (Bug#10263)
5057
f7dfe5d6
JD
50582011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5059
83faebb4
JD
5060 * nsterm.h (x_free_frame_resources): Declare.
5061
f7dfe5d6
JD
5062 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
5063 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
5064
5065 * nsterm.h (ns_get_defaults_value): Declare.
5066
5067 * nsterm.m (ns_default): Call ns_get_defaults_value.
5068
7cd4e72c
EZ
50692011-12-09 Eli Zaretskii <eliz@gnu.org>
5070
5071 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
5072 (Bug#10170)
5073
b34d7317
YM
50742011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5075
5076 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
5077 that where the value of an _OBJC_* symbol points to is in the .bss
5078 section (Bug#10240).
5079
76470ad1
KH
50802011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5081
5082 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 5083 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 5084
745fff94
KH
50852011-12-08 Kenichi Handa <handa@m17n.org>
5086
5087 * ftfont.c (get_adstyle_property): Fix previous change
5088 (Bug#10233).
5089
6e44397c
JB
50902011-12-07 Juanma Barranquero <lekktu@gmail.com>
5091
5092 * w32.c (init_environment): If no_site_lisp, remove site-lisp
5093 dirs from the default value of EMACSLOADPATH (bug#10208).
5094
7efa6272
GM
50952011-12-07 Glenn Morris <rgm@gnu.org>
5096
5097 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
5098 installation and source directories as well. (Bug#10208)
5099
f6fc4d87
CY
51002011-12-06 Chong Yidong <cyd@gnu.org>
5101
5102 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
5103
2bf26180
GM
51042011-12-06 Glenn Morris <rgm@gnu.org>
5105
5106 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
5107 as an error, not just -1. (Bug#10217)
5108
3a6ad4f0
CY
51092011-12-05 Chong Yidong <cyd@gnu.org>
5110
5111 * keyboard.c (process_special_events): New function.
5112 (swallow_events, Finput_pending_p): Use it (Bug#10195).
5113
75a3b399
PE
51142011-12-05 Paul Eggert <eggert@cs.ucla.edu>
5115
5116 * coding.c (encode_designation_at_bol): Don't use uninitialized
5117 local variable (Bug#9318).
5118
c3c9e25e
KH
51192011-12-05 Kenichi Handa <handa@m17n.org>
5120
5121 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
5122 return Qnil (Bug#8046, Bug#10193).
5123
5eb05ea3
KH
51242011-12-05 Kenichi Handa <handa@m17n.org>
5125
5126 * coding.c (encode_designation_at_bol): New args charbuf_end and
5127 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
5128 (coding_set_source): Return how many bytes coding->source was
5129 relocated.
5130 (coding_set_destination): Return how many bytes
5131 coding->destination was relocated.
5132 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 5133 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
5134
51352011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5136
5137 * coding.c (CODING_CHAR_CHARSET_P): New macro.
5138 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
5139 macro (Bug#9318).
5140
51412011-12-05 Andreas Schwab <schwab@linux-m68k.org>
5142
5143 The following changes are to fix Bug#9318.
5144
a79703f5 5145 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
5146 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
5147 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 5148 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 5149
7dbda6df
JB
51502011-12-05 Juanma Barranquero <lekktu@gmail.com>
5151
5152 * lisp.h (process_quit_flag): Fix external declaration.
5153
6d5eb5b0
SM
51542011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
5155
5156 Don't macro-inline non-performance-critical code.
5157 * eval.c (process_quit_flag): New function.
5158 * lisp.h (QUIT): Use it.
5159
a0c3fad0
JD
51602011-12-04 Jan Djärv <jan.h.d@swipnet.se>
5161
5162 * nsfns.m (get_geometry_from_preferences): New function.
5163 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
5164
6c07aac2
AS
51652011-12-04 Andreas Schwab <schwab@linux-m68k.org>
5166
5167 * emacs.c (Qkill_emacs): Define.
5168 (syms_of_emacs): Initialize it.
5169 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
5170 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
5171 (quit_throw_to_read_char): Add parameter `from_signal'.
5172 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
5173 * lisp.h (QUIT): Call Fkill_emacs if requested.
5174
c052ead4
JD
51752011-12-03 Jan Djärv <jan.h.d@swipnet.se>
5176
5177 * widget.c (update_wm_hints): Return if wmshell is null.
5178 (widget_update_wm_size_hints): New function.
5179
5180 * widget.h (widget_update_wm_size_hints): Declare.
5181
5182 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
5183 widget_update_wm_size_hints (Bug#10104).
5184
9e49252b
EZ
51852011-12-03 Eli Zaretskii <eliz@gnu.org>
5186
5187 * xdisp.c (handle_invisible_prop): If the invisible text ends just
5188 before a newline, prepare the bidi iterator for consuming the
5189 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 5190 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 5191
02b16839
JL
51922011-12-02 Juri Linkov <juri@jurta.org>
5193
5194 * search.c (Fword_search_regexp): New Lisp function created from
5195 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
5196 (Fword_search_backward, Fword_search_forward)
5197 (Fword_search_backward_lax, Fword_search_forward_lax):
5198 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
5199 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
5200
0068070e
SM
52012011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
5202
5203 * fileio.c (Finsert_file_contents): Move after-change-function call
5204 to before the "handled:" label, since all "goto handled" appear in
5205 cases where the *-change-functions have already been properly called
5206 (bug#10117).
5207
3360a3fc
AS
52082011-12-01 Andreas Schwab <schwab@linux-m68k.org>
5209
5210 * keyboard.c (interrupt_signal): Don't call kill-emacs when
5211 waiting for input. (Bug#10169)
5212
73d6c093
EZ
52132011-11-30 Eli Zaretskii <eliz@gnu.org>
5214
5215 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
5216 verifies glyph row's hash code--we have just reallocated the
5217 glyphs, so their contents can be complete garbage. (Bug#10164)
5218
febe6bea
JB
52192011-11-30 Juanma Barranquero <lekktu@gmail.com>
5220
5221 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
5222
801a4313
EZ
52232011-11-30 Eli Zaretskii <eliz@gnu.org>
5224
5225 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
5226 attributes are tested _before_ calling verify_row_hash, to protect
5227 against GCC re-ordering of the tests. (Bug#10164)
5228
2b56b87e
JD
52292011-11-29 Jan Djärv <jan.h.d@swipnet.se>
5230
5231 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
5232
5233 * xterm.c (handle_one_xevent): Only set async_visible and friends
5234 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 5235 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
5236 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
5237
dbf31225
PE
52382011-11-28 Paul Eggert <eggert@cs.ucla.edu>
5239
5240 Remove GCPRO-related macros that exist only to avoid shadowing locals.
5241 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
5242 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
5243 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5244 All uses changed to use GCPRO1 etc.
5245 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
5246 Revert to old implementation (i.e., before 2011-03-11).
5247
1305621b
YM
52482011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5249
5250 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
5251 of scroll runs so as to avoid assigning disabled bogus rows and
5252 unnecessary graphics copy operations.
5253
8c9afb46
EZ
52542011-11-27 Eli Zaretskii <eliz@gnu.org>
5255
5256 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
5257 (snprintf) [_MSC_VER]: Redirect to _snprintf.
5258 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
5259 (malloc, free, realloc, calloc): Redirect to e_* only when
5260 compiling Emacs.
5261
5262 * lisp.h (GCTYPEBITS): Move before first use.
5263 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
5264 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
5265 this macro definition.
5266
5267 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
5268 _MSC_VER.
5269
54e9e3bf
JD
52702011-11-27 Jan Djärv <jan.h.d@swipnet.se>
5271
6d5eb5b0
SM
5272 * gtkutil.c (xg_create_frame_widgets):
5273 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
5274 present with Gtk+ 2.0.
5275
83aca1cb
PE
52762011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5277
5278 * fileio.c (Finsert_file_contents): Undo previous change; see
5279 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5280
5b76caa4
PE
52812011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5282
5283 Rename locals to avoid shadowing.
5284 * fileio.c (Finsert_file_contents):
5285 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
5286 * process.c (wait_reading_process_output):
5287 Rename inner 'proc' to 'p' to avoid shadowing.
5288 Indent for consistency with usual Emacs style.
5289
8c535114
EZ
52902011-11-25 Eli Zaretskii <eliz@gnu.org>
5291
5292 * xdisp.c (redisplay_window): If cursor row is not fully visible
5293 after recentering, and scroll-conservatively is set to a large
5294 number, scroll window by a few more lines to make the cursor fully
5295 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
5296 (start_display): Don't move to the next line if the display should
5297 start at a newline that is part of a display vector or an overlay
5298 string. (Bug#10119)
8c535114 5299
fa4fdb5c
JL
53002011-11-24 Juri Linkov <juri@jurta.org>
5301
5302 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
5303 after the `MagickPingImage' call. (Bug#10112)
5304
90ec88df
CY
53052011-11-23 Chong Yidong <cyd@gnu.org>
5306
5307 * window.c (Fcoordinates_in_window_p): Accept only live windows.
5308
56e2e794
MR
53092011-11-23 Martin Rudalics <rudalics@gmx.at>
5310
5311 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
5312 making another buffer current. (Bug#10114)
5313
b6e64c41
GM
53142011-11-23 Glenn Morris <rgm@gnu.org>
5315
5316 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
5317
6b21de18
CY
53182011-11-23 Chong Yidong <cyd@gnu.org>
5319
5320 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
5321 using it (Bug#5984).
5322
b12cd789
EZ
53232011-11-22 Eli Zaretskii <eliz@gnu.org>
5324
5325 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
5326 and header-lines, as they don't have one computed for them.
5327 (Bug#10098)
5328
5329 * .gdbinit (prow): Make displayed values more self-explaining.
5330 Add row's hash code.
5331
261b6fd4
LMI
53322011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
5333
5334 * process.c (wait_reading_process_output): Fix asynchrounous
5335 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 5336 (wait_reading_process_output): Add comment and URL.
261b6fd4 5337
e7cfd277
JD
53382011-11-21 Jan Djärv <jan.h.d@swipnet.se>
5339
5340 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
5341
a9b9b7f5
CY
53422011-11-21 Chong Yidong <cyd@gnu.org>
5343
5344 * window.c (Fnext_window, Fprevious_window): Doc fix.
5345
b0d15b4f
SM
53462011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5347
5348 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
5349
fe7a3057
JB
53502011-11-20 Juanma Barranquero <lekktu@gmail.com>
5351
5352 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
5353
d2999b1a
MR
53542011-11-20 Martin Rudalics <rudalics@gmx.at>
5355
5356 * window.c (Fset_window_combination_limit): Rename argument
5357 STATUS to LIMIT.
5358 (Vwindow_combination_limit): Remove "status" from doc-string.
5359
d5ff9cd0
AS
53602011-11-20 Andreas Schwab <schwab@linux-m68k.org>
5361
5362 * m/ibms390.h: Remove.
5363 * m/ibms390x.h: Don't include "ibms390.h".
5364
a5bb9bd3
SM
53652011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5366
5367 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
5368 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
5369
cd1181db
JB
53702011-11-20 Juanma Barranquero <lekktu@gmail.com>
5371
5372 * casetab.c (Fset_case_table):
5373 * charset.c (Fcharset_after): Fix typos.
5374
615a3b8d 53752011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 5376
17e845af
PE
5377 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
5378 Otherwise, valgrind does not work on some platforms.
5379 Problem reported by Andreas Schwab in
6a0bf43d
PE
5380 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
5381 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
5382 is set, removing the need for VIRT_ADDRESS_VARIES.
5383 (PURE_P): Use a more-efficient implementation that needs just one
5384 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
5385 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
5386 to 4 (xorl, subq, cmpq, setbe).
5387 * alloc.c (pure): Always extern now, since that's the
5388 VIRT_ADDR_VARIES behavior.
5389 (PURE_POINTER_P): Use a single comparison, not two, for
5390 consistency with the new puresize.h.
5391 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
5392 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
5393 Remove VIRT_ADDR_VARIES no longer needed.
5394
f8fe6f96
EZ
53952011-11-19 Eli Zaretskii <eliz@gnu.org>
5396
5397 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
5398 (erase_phys_cursor, update_window_cursor, show_mouse_face)
5399 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
5400 behave as if the cursor position were at the window margin.
5401
5402 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
5403 and the cursor position is out of bounds, behave as if the cursor
5404 position were at the window margin. (Bug#10075)
5405
df05a53c
CY
54062011-11-18 Chong Yidong <cyd@gnu.org>
5407
5408 * window.c (Fwindow_combination_limit): Make first argument
5409 non-optional, since it is meaningless for live windows like the
5410 selected window.
61ccba97 5411
2071918e
DA
54122011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
5413
5414 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
5415
b50a28de
SM
54162011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
5417
5418 * intervals.c: Fix grafting over the whole buffer (bug#10071).
5419 (graft_intervals_into_buffer): Simplify.
5420
015137db
EZ
54212011-11-18 Eli Zaretskii <eliz@gnu.org>
5422
5423 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
5424 hash values of the two rows.
5425 (copy_row_except_pointers): Preserve the used[] arrays and the
5426 hash values of the two rows. (Bug#10035)
68c95424 5427 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
5428
5429 * xdisp.c (row_hash): New function, body extracted from
5430 compute_line_metrics.
5431 (compute_line_metrics): Call row_hash, instead of computing the
5432 hash code inline.
5433
5434 * dispnew.c (verify_row_hash): Call row_hash for computing the
5435 hash code of a row, instead of duplicating code from xdisp.c.
5436
5437 * dispextern.h (row_hash): Add prototype.
5438
a2addb04
TH
54392011-11-18 Tassilo Horn <tassilo@member.fsf.org>
5440
5441 * frame.c (delete_frame): Don't delete the terminal when the last
5442 X frame is closed if emacs is built with GTK toolkit.
5443
df85d315
JB
54442011-11-17 Juanma Barranquero <lekktu@gmail.com>
5445
5446 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
5447
a0c2d0ae
MR
54482011-11-17 Martin Rudalics <rudalics@gmx.at>
5449
5450 * window.c (Vwindow_splits): Rename to
5451 Vwindow_combination_resize. Suggested by Juri Linkov.
5452 (Fsplit_window_internal): Use Vwindow_combination_resize instead
5453 of Vwindow_splits.
5454
58179cce
JB
54552011-11-16 Juanma Barranquero <lekktu@gmail.com>
5456
7877f373
JB
5457 * nsfns.m (Fns_font_name):
5458 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 5459
b6f67890
MR
54602011-11-16 Martin Rudalics <rudalics@gmx.at>
5461
5462 * window.h (window): Rename slot "nest" to "combination_limit".
5463 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
5464 (Fset_window_nest): Rename to Fset_window_combination_limit.
5465 (Vwindow_nest): Rename to Vwindow_combination_limit.
5466 (recombine_windows, make_parent_window, make_window)
5467 (Fsplit_window_internal, saved_window)
5468 (Fset_window_configuration, save_window_save): Rename all
5469 occurrences of window_nest to window_combination_limit.
5470
c7015153
JB
54712011-11-15 Juanma Barranquero <lekktu@gmail.com>
5472
5473 * image.c (imagemagick_load_image): Fix typo.
5474
322ad6ec
EZ
54752011-11-14 Eli Zaretskii <eliz@gnu.org>
5476
5477 * xdisp.c (display_line): Move the call to
5478 highlight_trailing_whitespace before the call to
5479 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
5480 faces of all the glyphs to compute ROW's hash value.
5481 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 5482
f067b8ec
JB
54832011-11-14 Juanma Barranquero <lekktu@gmail.com>
5484
5485 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
5486 just return (bug#10044).
5487
1e5b2111
EZ
54882011-11-12 Eli Zaretskii <eliz@gnu.org>
5489
7ef3cbd5
EZ
5490 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
5491 with user-defined heap size. Bump the default size of the temacs
5492 heap to 27MB, to avoid memory warning when running temacs.
5493 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
5494
1e5b2111
EZ
5495 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
5496 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
5497 (verify_row_hash) [XASSERTS]: New function.
5498 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
5499 that the hash value of glyph rows is correct.
1e5b2111 5500
89d61221
MR
55012011-11-12 Martin Rudalics <rudalics@gmx.at>
5502
5503 * window.h (window): Remove splits slot.
5504 * window.c (Fwindow_splits, Fset_window_splits): Remove.
5505 (Fdelete_other_windows_internal, make_parent_window)
5506 (make_window, Fsplit_window_internal, Fdelete_window_internal)
5507 (Fset_window_configuration, save_window_save): Don't deal with
5508 split status of windows.
5509 (saved_window): Remove splits slot.
5510 (Vwindow_splits): Rewrite doc-string.
5511
97f18cc8
JD
55122011-11-11 Jan Djärv <jan.h.d@swipnet.se>
5513
5514 * xfns.c (unwind_create_frame):
5515 * nsfns.m (unwind_create_frame):
5516 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
5517 Vframe_list (Bug#9999).
5518
22a648b4
DA
55192011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
5520
0b381c7e 5521 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 5522
659afede
KH
55232011-11-11 Kenichi Handa <handa@m17n.org>
5524
5525 * callproc.c (Fcall_process): Set the member dst_multibyte of
5526 process_coding.
5527
9ac0394b
KH
55282011-11-11 Johan Bockgård <bojohan@gnu.org>
5529
5530 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
5531 avoid a crash (bug#9496).
5532
2fbdc249
CY
55332011-11-09 Chong Yidong <cyd@gnu.org>
5534
5535 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
5536 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
5537
ac6b1f81
PE
55382011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5539
5540 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
5541
09db192c
PE
55422011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5543
5544 Avoid some portability problems by eschewing 'extern inline' functions.
5545 The trivial performance wins aren't worth the portability hassles; see
5546 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
5547 et seq.
5548 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5549 (window_box_width, window_box_left, window_box_left_offset)
5550 (window_box_right, window_box_right_offset): Undo previous change,
5551 by removing the "extern"s.
5552 * intervals.c (adjust_intervals_for_insertion)
5553 (adjust_intervals_for_deletion): Undo previous change,
5554 making these static again.
5555 (offset_intervals, temp_set_point_both, temp_set_point)
5556 (copy_intervals_to_string): No longer inline.
5557 * xdisp.c (window_text_bottom_y, window_box_width)
5558 (window_box_height, window_box_left_offset)
5559 (window_box_right_offset, window_box_left, window_box_right)
5560 (window_box): No longer inline.
5561
105216ed
CY
55622011-11-08 Chong Yidong <cyd@gnu.org>
5563
5564 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
5565 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
5566 Signal an error if not a live window.
105216ed
CY
5567 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
5568 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
5569
ae9e237f
JB
55702011-11-07 Juanma Barranquero <lekktu@gmail.com>
5571
5572 * lisp.h (syms_of_abbrev): Remove declaration.
5573 Reported by CHENG Gao <chenggao@royau.me>.
5574
c7aa8333
EZ
55752011-11-07 Eli Zaretskii <eliz@gnu.org>
5576
5577 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
5578 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
5579 of temacs in GUI mode.
5580
be7f5545
MR
55812011-11-07 Martin Rudalics <rudalics@gmx.at>
5582
5583 * window.h: Declare delete_all_child_windows instead of
5584 delete_all_subwindows.
5585 * window.c (Fwindow_nest, Fset_window_nest)
5586 (Fset_window_new_total, Fset_window_new_normal)
5587 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
5588 (delete_all_subwindows): Rename to delete_all_child_windows.
5589 (Fdelete_other_windows_internal, Fset_window_configuration):
5590 Call delete_all_child_windows instead of delete_all_subwindows.
5591 * frame.c (delete_frame): Call delete_all_child_windows instead
5592 of delete_all_subwindows.
5593
ca78dc43
PE
55942011-11-07 Paul Eggert <eggert@cs.ucla.edu>
5595
5596 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
5597 This is also needed for porting to any host where GC_MARK_STACK is
5598 not GC_MAKE_GCPROS_NOOPS.
5599 (which_symbols): Use it.
5600
a0241d01
KH
56012011-11-07 Kenichi Handa <handa@m17n.org>
5602
5603 * coding.c (coding_set_destination): Check coding->src_pos only
5604 when coding->src_object is a buffer (bug#9910).
5605
5606 * process.c (send_process): Set the member src_multibyte of coding
5607 to 0 (bug#9911) when sending a unibyte text.
5608
5609 * callproc.c (Fcall_process): Set the member src_multibyte of
5610 process_coding to 0 (bug#9912).
5611
a64bfdfa 56122011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
5613
5614 * xmenu.c (cleanup_widget_value_tree): New function.
5615 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
5616 calling free_menubar_widget_value_tree directly (Bug#9830).
5617
cb41b32a
PE
56182011-11-06 Paul Eggert <eggert@cs.ucla.edu>
5619
5620 Fix some portability problems with 'inline'.
5621 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5622 (window_box_width, window_box_left, window_box_left_offset)
5623 (window_box_right, window_box_right_offset): Declare extern.
5624 Otherwise, these inline functions do not conform to C99 and
5625 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
5626 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
5627 * intervals.c (adjust_intervals_for_insertion)
5628 (adjust_intervals_for_deletion): Now extern, because otherwise the
5629 extern inline functions 'offset_intervals' couldn't refer to it.
5630 (static_offset_intervals): Remove.
5631 (offset_intervals): Rewrite using the old contents of
5632 static_offset_intervals. The old version didn't conform to C99
5633 because an extern inline function contained a reference to an
5634 identifier with static linkage.
5635
b7041366
AS
56362011-11-06 Andreas Schwab <schwab@linux-m68k.org>
5637
5638 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
5639 GC.
5640
88a37c4d
EZ
56412011-11-06 Eli Zaretskii <eliz@gnu.org>
5642
5643 * xdisp.c (init_iterator, reseat_to_string): Don't set the
5644 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
5645 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
5646 return Qleft_to_right.
5647
49745b39
CY
56482011-11-06 Chong Yidong <cyd@gnu.org>
5649
5650 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
5651 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
5652 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
5653 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
5654 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
5655 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
5656 (Fwindow_vscroll): Doc fix.
5657 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
5658 argument, since it makes no sense to pass a live window and for
5659 consistency with window-child.
5660
1f05cd82
CS
56612011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
5662
5663 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
5664 support MSVC.
5665
22610910
JR
56662011-11-05 Jason Rumney <jasonr@gnu.org>
5667
5668 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
5669 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
5670 fonts (Bug#6029).
5671 (add_font_entity_to_list): Fix logic errors in mixed boolean and
5672 bitwise arithmetic preventing use of unicode-sip and non-truetype
5673 opentype fonts.
5674
a06776b2
EZ
56752011-11-05 Eli Zaretskii <eliz@gnu.org>
5676
3ad924ba
EZ
5677 * s/ms-w32.h (fstat, stat, utime): Move redirections to
5678 "emacs"-only part.
5679
a06776b2
EZ
5680 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
5681 initialization code to keep similarity to xfns.c after changes
5682 from 2011-11-05.
5683
c9e7db78
JD
56842011-11-05 Jan Djärv <jan.h.d@swipnet.se>
5685
a97f8f3f
JD
5686 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
5687 (unwind_create_frame): New function (Bug#9943).
5688 (Fx_create_frame): Restructure code to be more similar to the one in
5689 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
5690 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
5691 Move terminal->reference_count++ just before making the frame official
5692 (Bug#9943).
5693
5694 * nsterm.m (x_free_frame_resources): New function.
5695 (x_destroy_window): Move code to x_free_frame_resources.
5696
c9e7db78 5697 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
5698 (Fx_create_frame, x_create_tip_frame):
5699 Move terminal->reference_count++ just before making the frame
75f1671a 5700 official. Move initialization of image_cache_refcount and
c9e7db78
JD
5701 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
5702
a6fc3b5c
EZ
57032011-11-05 Eli Zaretskii <eliz@gnu.org>
5704
5705 Support MSVC build with newer versions of Visual Studio.
5706 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
5707 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
5708 nt/gmake.defs.
5709
5710 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
5711 which are not supported by MSVC.
5712 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
5713 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
5714 bitfields.
5715 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
5716 types in bitfields.
5717 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
5718
5719 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
5720
58179cce 57212011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
5722
5723 Support MSVC build with newer versions of Visual Studio.
5724 * w32.c: Don't include w32api.h for MSVC.
5725 (init_environment) [_MSC_VER]: Call sys_access, not _access.
5726
5727 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
5728 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
5729 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
5730 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
5731 e_* cousins.
5732 (alloca) [_MSC_VER]: Define to _alloca.
5733
5734 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
5735
5736 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
5737
a58c13ed
EZ
57382011-11-04 Eli Zaretskii <eliz@gnu.org>
5739
5740 * xdisp.c (note_mouse_highlight): If either of
5741 previous/next-single-property-change returns nil, treat that as
5742 the beginning or the end of the buffer. (Bug#9955)
5743
fe0b6370
JD
57442011-11-04 Jan Djärv <jan.h.d@swipnet.se>
5745
a58c13ed 5746 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
5747 label is not null (Bug#9951).
5748 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
5749 may be NULL.
5750
89bd5ee1
EZ
57512011-11-04 Eli Zaretskii <eliz@gnu.org>
5752
5753 * window.c (Fwindow_body_size): Mention in the doc string that the
5754 return value is in frame's canonical units. (Bug#9949)
5755
84c3edb9
EZ
57562011-11-03 Eli Zaretskii <eliz@gnu.org>
5757
4e2fb5c7
EZ
5758 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
5759
84c3edb9 5760 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 5761 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 5762 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 5763
bc17a887
EZ
57642011-11-01 Eli Zaretskii <eliz@gnu.org>
5765
5766 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
5767 Don't stop backward scan on the continuation glyph, even though
5768 its CHARPOS is positive.
6d5eb5b0
SM
5769 (mouse_face_from_buffer_pos, note_mouse_highlight):
5770 Rename cover_string to disp_string.
bc17a887 5771
4ee88440
MR
57722011-11-01 Martin Rudalics <rudalics@gmx.at>
5773
5774 * window.c (temp_output_buffer_show): Don't use
5775 Vtemp_buffer_show_specifiers.
5776 (Vtemp_buffer_show_specifiers): Remove unused variable.
5777
c2ff3c02
EZ
57782011-10-30 Eli Zaretskii <eliz@gnu.org>
5779
5780 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
5781 past the beginning of the current glyph matrix.
5782
58179cce 57832011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
5784
5785 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
5786 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
5787 HAVE_GTK3 (Bug#9869).
b77a6a7f 5788
3b574623
JD
5789 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
5790 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
5791
b77a6a7f
JD
5792 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
5793
5794 * xterm.c: Declare x_handle_net_wm_state to return int.
5795 (handle_one_xevent): Check if we are iconified but don't have
5796 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
5797 (get_current_wm_state): Return non-zero if not hidden,
5798 check for _NET_WM_STATE_HIDDEN (Bug#9893).
5799 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
5800 (x_handle_net_wm_state): Return what get_current_wm_state returns.
5801 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
5802
196e41e4
PE
58032011-10-29 Paul Eggert <eggert@cs.ucla.edu>
5804
5805 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
5806 so that this new function doesn't get optimized away by a
5807 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
5808
021f2e1a
AS
58092011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5810
5811 * frame.h (MOUSE_HL_INFO): Remove excess parens.
5812
8b058d44
EZ
58132011-10-29 Eli Zaretskii <eliz@gnu.org>
5814
5815 Fix the `xbytecode' command.
5816 * .gdbinit (xprintbytestr): New command.
b50a28de 5817 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
5818 (xbytecode): Print the byte-code string as well.
5819
4452fb80
EZ
58202011-10-29 Kim Storm <storm@cua.dk>
5821
8b058d44
EZ
5822 * alloc.c (which_symbols): New function.
5823
21b72067
AS
58242011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5825
5826 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
5827 line. (Bug#9903)
5828
83ed7b5c
GM
58292011-10-29 Glenn Morris <rgm@gnu.org>
5830
5831 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
5832 Not clear what it was for, and it causes various bugs. (Bug#9839)
5833
5a7a728b
EZ
58342011-10-28 Eli Zaretskii <eliz@gnu.org>
5835
5836 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
5837 possible random value that matches one of those tested as
5838 condition to clear the mouse face.
5839
d3d0842f
CY
58402011-10-28 Chong Yidong <cyd@gnu.org>
5841
5842 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
5843
31b39d13
DN
58442011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
5845
5846 * window.c (make_window): Initialize phys_cursor_on_p.
5847
9aba6043
SM
58482011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
5849
5850 * lisp.h (struct Lisp_Symbol): Update comments.
5851
c20992f4
JB
58522011-10-28 Juanma Barranquero <lekktu@gmail.com>
5853
5854 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
5855
db4f02f2
EZ
58562011-10-28 Eli Zaretskii <eliz@gnu.org>
5857
5858 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
5859 <oslsachem@gmail.com> for helping to debug this.
5860
5861 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
5862 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
5863 (g_b_init_get_glyph_outline_w): New static variables.
5864 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
5865 (GetGlyphOutlineW_Proc): New typedefs.
5866 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
5867 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
5868 New functions.
5869 (w32font_open_internal, compute_metrics):
5870 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
5871 instead of calling the "wide" APIs directly.
5872
5873 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
5874
5875 * w32.h (syms_of_w32font): Add prototype.
5876
87e68db4
JB
58772011-10-27 Juanma Barranquero <lekktu@gmail.com>
5878
5879 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
5880 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
5881 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
5882 (Fmove_to_window_line): Doc fix.
5883
435c1d67
CY
58842011-10-27 Chong Yidong <cyd@gnu.org>
5885
5886 * process.c (make_process): Set gnutls_state to NULL.
5887
5888 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
5889 non-NULL, regardless of GNUTLS_INITSTAGE.
5890 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
5891 an error. Set process slots as soon as we allocate them.
5892
5893 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
5894
9c6c6f49
CY
58952011-10-27 Chong Yidong <cyd@gnu.org>
5896
9aba6043
SM
5897 * gnutls.c (emacs_gnutls_deinit): New function.
5898 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
5899 (Fgnutls_deinit, Fgnutls_boot): Use it.
5900
5901 * process.c (make_process): Initialize GnuTLS credentials to NULL.
5902 (deactivate_process): Call emacs_gnutls_deinit.
5903
657d08d3
JB
59042011-10-27 Juanma Barranquero <lekktu@gmail.com>
5905
5906 * image.c (x_create_x_image_and_pixmap):
5907 * w32.c (sys_rename, w32_delayed_load):
5908 * w32font.c (fill_in_logfont):
5909 * w32reg.c (x_get_string_resource): Silence compiler warnings.
5910
5430d399
JB
59112011-10-26 Juanma Barranquero <lekktu@gmail.com>
5912
5913 * w32fns.c (w32_default_color_map): New function,
5914 extracted from Fw32_default_color_map.
a7ef684b 5915 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 5916
fe0055fa
PE
59172011-10-25 Paul Eggert <eggert@cs.ucla.edu>
5918
5919 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
5920
e6346438
SM
59212011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
5922
5923 * keyboard.c (test_undefined): New function (bug#9751).
5924 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
5925
e112cc37
ET
59262011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
5927
5928 * sysdep.c (init_sys_modes): Fix the check for the controlling
5929 terminal (Bug#6649).
5930
7b5d6677
EZ
59312011-10-20 Eli Zaretskii <eliz@gnu.org>
5932
5933 * dispextern.h (struct bidi_it): New member next_en_type.
5934
5935 * bidi.c (bidi_line_init): Initialize the next_en_type member.
5936 (bidi_resolve_explicit_1): When next_en_pos is valid for the
5937 current character, check also for next_en_type being WEAK_EN.
5938 (bidi_resolve_weak): Don't enter the expensive loop if the current
5939 position is before next_en_pos. Record the bidi type of the first
5940 non-ET, non-BN character we find, in addition to its position.
5941 (bidi_level_of_next_char): Invalidate next_en_type when
5942 next_en_pos is over-stepped.
5943
7da0b018
PE
59442011-10-20 Paul Eggert <eggert@cs.ucla.edu>
5945
5946 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
5947 * editfns.c: Rewrite current-time-zone so that it invokes
5948 the equivalent of (format-time-string "%Z") to get the time zone name.
5949 This fixes a bug when the time zone name contains characters that
5950 need converting from the system time locale to Emacs internal format.
5951 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
5952 that patch fixed format-time-string to do the conversion, but
5953 I forgot to fix current-time-zone.
5954 (format_time_string): New function, containing most of
5955 what Fformat_time_string used to contain.
5956 (Fformat_time_string): Rewrite in terms of format_time_string.
5957 This doesn't change this function's behavior.
5958 (current-time-zone): Rewrite to use format_time_string.
5959 This fixes the bug reported by Michael Schierl in
5960 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
5961 Jason Rumney's 2007-06-07 change worked around this bug, but
5962 didn't fix it.
5963 * systime.h (tzname, timezone): Remove no-longer-used declarations.
5964
8547b010
EZ
59652011-10-19 Eli Zaretskii <eliz@gnu.org>
5966
5967 * xdisp.c (start_display): If the character at POS is displayed
5968 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
5969 (try_window_reusing_current_matrix): If a line ends in a display
5970 vector or the next line starts in a display vector, continue
5971 redrawing the window even though the character position of
5972 start_row was reached.
8547b010
EZ
5973 (Bug#9771, part 2)
5974
4e948d15
CY
59752011-10-18 Chong Yidong <cyd@gnu.org>
5976
5977 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
5978 with nobreak-char-display too.
5979
4787455f
EZ
59802011-10-18 Eli Zaretskii <eliz@gnu.org>
5981
5982 Fix part 3 of bug#9771.
5983 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
5984 (bidi_resolve_neutral): Don't enter the expensive loop looking for
5985 non-neutral characters if the current character is a paragraph
5986 separator (a.k.a. Newline). This avoids running the same
5987 expensive loop twice, once when we consume the preceding newline
5988 and the other time when the line actually needs to be displayed.
5989 Avoid the loop when we see neutrals on the base embedding level
5990 following a character whose directionality is the same as the
5991 paragraph's. This avoids running the expensive loop when a line
5992 ends in a long sequence of neutrals, like control characters.
5993 Add assertion against STRONG_AL type. Slightly rearrange code
5994 that determines the type of a neutral given the first non-neutral
5995 that follows it.
5996 (bidi_level_of_next_char): Set next_en_pos to zero when
5997 invalidating its info.
5998
2c91f553
EZ
59992011-10-17 Eli Zaretskii <eliz@gnu.org>
6000
6001 * xdisp.c (push_display_prop): Determine whether to record string
6002 or buffer position by IT->string, not by IT->method. Allow
6003 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
6004 (move_it_vertically_backward): Don't look for character position
6005 immediately after the newline when in a continuation line.
6006 (Bug#9771, part 1)
2c91f553 6007
c7b08b0d
MR
60082011-10-15 Martin Rudalics <rudalics@gmx.at>
6009
6010 * window.c (coordinates_in_window): Rewrite and delabelize
6011 vertical border check. (Bug#5357) (Bug#9618)
6012
6b02f655
SM
60132011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
6014
6015 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
6016 errors in XSetWindowBorder (bug#9310).
6017
81d40c92
DA
60182011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
6019
6020 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
6021 avoid crash when xmalloc overrun checking is enabled.
6022
d4172c3b
EZ
60232011-10-13 Eli Zaretskii <eliz@gnu.org>
6024
6025 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
6026 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
6027 cursor motion with <left> and <right> arrow keys.
6028
6029 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
6030 some callers set that themselves.
6031
b00eea75
EZ
60322011-10-12 Eli Zaretskii <eliz@gnu.org>
6033
6034 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
6035 display string and the previous row comes from the same string and
6036 is empty. (Bug#9739) (Bug#9738)
6037
8fe012c4
SM
60382011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
6039
6040 * doc.c (get_doc_string): Encode file name (bug#9735).
6041
0074aef2
EZ
60422011-10-12 Eli Zaretskii <eliz@gnu.org>
6043
79beb178
EZ
6044 * bidi.c (bidi_level_of_next_char):
6045 * xdisp.c (get_visually_first_element): Remove old incorrect
6046 comments regarding the Unicode Line Separator character.
6047
0074aef2
EZ
6048 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
6049
6e4b3fbe
DA
60502011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
6051
6052 * alloc.c (Fgc_status): Do not access beyond zombies array
6053 boundary if nzombies > MAX_ZOMBIES.
6054 * alloc.c (dump_zombies): Add missing format specifier.
6055
0324f3af
PE
60562011-10-12 Paul Eggert <eggert@cs.ucla.edu>
6057
b5525cac
PE
6058 * xdisp.c (set_cursor_from_row): Simplify conditionals,
6059 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
6060
0324f3af
PE
6061 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
6062 Some packages use them to denote characters with modifiers.
6063
e9b5f888
AS
60642011-10-11 Andreas Schwab <schwab@linux-m68k.org>
6065
6066 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
6067 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
6068 matching a pp-number. Rename parameter var to var1.
6069
127827c0
SM
60702011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
6071
6072 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
6073
c8fd3bd0
GM
60742011-10-08 Glenn Morris <rgm@gnu.org>
6075
6076 * callint.c (Fcall_interactively): Give a more explicit error for the
6077 'c' case with a non-character input. (Bug#8479)
6078
352ec8ff
EZ
60792011-10-08 Eli Zaretskii <eliz@gnu.org>
6080
03669ccb
EZ
6081 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
6082 lines.
7061c986
EZ
6083 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
6084 lines that are hscrolled on the left.
03669ccb 6085
352ec8ff
EZ
6086 * dispnew.c (buffer_posn_from_coords): Account for a possible
6087 presence of header-line. (Bug#4426)
6088
a66cfb1c
SM
60892011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
6090
6b02f655
SM
6091 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
6092 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 6093
7c5ee88e
PE
60942011-10-07 Paul Eggert <eggert@cs.ucla.edu>
6095
6096 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
6097 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
6098 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
6099 this makes Emacs dump core during garbage collection on rare
6100 occasions. sizeof is obviously inferior to offsetof here, so
6101 stick with offsetof.
6102 (GC_POINTER_ALIGNMENT): New macro.
6103 (mark_memory): Omit 3rd (offset) arg; caller changed.
6104 Don't assume EMACS_INT alignment is the same as pointer alignment.
6105
df1bbe5b
SM
61062011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
6107
6108 * keyboard.c (read_key_sequence_remapped): New var.
6109 (read_key_sequence): Compute remapping in the right buffer.
6110 (command_loop_1): Use read_key_sequence's remapping directly.
6111
51553db6
SM
61122011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
6113
32c1fffd
SM
6114 * dired.c (file_name_completion): Don't expand file name.
6115 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
6116 before checking file name handler.
6117
51553db6
SM
6118 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
6119 they've been requested explicitly (bug#9591).
6120
b6bd1599 61212011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
6122
6123 * keymap.c (Fsingle_key_description): Use make_specified_string
6124 instead of build_string to build string from push_key_description.
6125 (Bug#5193)
6126
f701dc2a
PE
61272011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6128
4222c55d
PE
6129 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
6130 This fixes a Y2038 bug on 64-bit hosts.
6131 * buffer.c (reset_buffer):
6132 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
6133 (Fclear_buffer_auto_save_failure):
6134 Use 0, not -1, to represent an unset failure time, since time_t
6135 might not be signed.
6136
f701dc2a
PE
6137 Remove dependency on glibc malloc internals.
6138 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6139 Move back here from lisp.h, but with their new implementations.
6140 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6141 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
6142 * charset.c (charset_table_init): New static var.
6143 (syms_of_charset): Use it instead of xmalloc. This removes a
6144 dependency on glibc malloc internals. See Eli Zaretskii's comment in
6145 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
6146 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6147 Move back to alloc.c.
6148 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6149 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
6150
9ceebf39
JD
61512011-09-30 Jan Djärv <jan.h.d@swipnet.se>
6152
6153 * nsterm.m (windowDidResize): Call x_set_window_size only when
6154 ns_in_resize is true. Otherwise set pixelwidth/height and
6155 call change_frame_size (Bug#9628).
6156
cb993c58
PE
61572011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6158
3930c88b
PE
6159 Port --enable-checking=all to Fedora 14 x86-64.
6160 * charset.c (syms_of_charset): Also account for glibc malloc's
6161 internal overhead when calculating the initial malloc maximum.
6162
cb993c58
PE
6163 Port --enable-checking=all to Fedora 14 x86.
6164 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6165 Move to lisp.h.
6166 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
6167 (overrun_check_realloc, overrun_check_free):
6168 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
6169 That way, xmalloc returns a properly-aligned pointer even if
6170 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
6171 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
6172 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
6173 into account when calculating the initial malloc maximum.
6174 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6175 Move here from alloc.c, so that charset.c can use it too.
6176 Properly align; the old code wasn't right for common 32-bit hosts
6177 when configured with --enable-checking=all.
6178 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6179 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
6180
31bed486
EZ
61812011-09-29 Eli Zaretskii <eliz@gnu.org>
6182
04c70788 6183 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
6184 use EDOM.
6185
fbcaa2f3
EZ
61862011-09-28 Eli Zaretskii <eliz@gnu.org>
6187
6188 * xdisp.c (compute_display_string_end): If there's no display
6189 string at CHARPOS, return -1.
6190
6191 * bidi.c (bidi_fetch_char): When compute_display_string_end
6192 returns a negative value, treat the character as a normal
6193 character not covered by a display string. (Bug#9624)
6194
a239d4e9
JB
61952011-09-28 Juanma Barranquero <lekktu@gmail.com>
6196
6197 * lread.c (Fread_from_string): Fix typo in docstring.
6198
88652fd5
EZ
61992011-09-27 Eli Zaretskii <eliz@gnu.org>
6200
6201 * xdisp.c (handle_invisible_prop): If invisible text ends on a
6202 newline, reseat the iterator instead of bidi-iterating there one
6203 character at a time. (Bug#9610)
32c1fffd
SM
6204 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
6205 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 6206
ed497dd4
AS
62072011-09-27 Andreas Schwab <schwab@linux-m68k.org>
6208
6209 * lread.c (readevalloop): Use correct code for NBSP.
6210 (read1): Likewise. (Bug#9608)
6211
b2bf61aa
MA
62122011-09-25 Michael Albinus <michael.albinus@gmx.de>
6213
6214 * dbusbind.c (Fdbus_register_signal): When service is not
6215 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
6216
32bbb17c
GM
62172011-09-25 Glenn Morris <rgm@gnu.org>
6218
6219 * buffer.c (truncate-lines): Doc fix.
6220
94e0933e
CY
62212011-09-24 Chong Yidong <cyd@stupidchicken.com>
6222
6223 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
6224 (Fset_window_next_buffers): Doc fix.
6225
cddde921
GM
62262011-09-24 Glenn Morris <rgm@gnu.org>
6227
6228 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
6229
1260aef1
PE
62302011-09-24 Paul Eggert <eggert@cs.ucla.edu>
6231
25b4bfa0
PE
6232 Fix minor problems found by static checking.
6233 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
6234 * indent.c (Fvertical_motion): Fix == vs = typo.
6235
e3cbd34b
EZ
62362011-09-24 Eli Zaretskii <eliz@gnu.org>
6237
a66cfb1c
SM
6238 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
6239 Default value is now t. Doc fix.
6bf7006f 6240
e3cbd34b 6241 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 6242 logic when moving up, not only when moving down. Fix the
e3cbd34b 6243 confusing name and values of the it_overshoot_expected variable;
32c1fffd 6244 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
6245
6246 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
6247 CHARPOS is covered by a display string which includes newlines.
6248 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
6249 is covered by a display string with embedded newlines.
6250
a3de0cbd
MA
62512011-09-24 Michael Albinus <michael.albinus@gmx.de>
6252
6253 * dbusbind.c (Fdbus_register_signal): Add match rule to
6254 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
6255 (Fdbus_register_method, Vdbus_registered_objects_table):
6256 Fix docstring.
a3de0cbd 6257
b260039d
JM
62582011-09-24 Jim Meyering <meyering@redhat.com>
6259
32c1fffd 6260 do not ignore write error for any output size
b260039d
JM
6261 The previous change was incomplete.
6262 While it makes emacs --batch detect the vast majority of stdout
6263 write failures, errors were still ignored whenever the output size is
6264 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
6265 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
6266 && echo FAIL: ignored write error
6267 FAIL: ignored write error
6268 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
6269 && echo FAIL: ignored write error
6270 FAIL: ignored write error
6271 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
6272
8eca8a7c
AS
62732011-09-23 Andreas Schwab <schwab@linux-m68k.org>
6274
6275 * emacs.c (Fkill_emacs): In noninteractive mode exit
6276 non-successfully if a write error occurred on stdout. (Bug#9574)
6277
3341db62
EZ
62782011-09-21 Eli Zaretskii <eliz@gnu.org>
6279
6280 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
6281 the xassert test.
6282
6283 * dispextern.h (struct it): Update the comment documenting what
6284 can it->OBJECT be.
6285
8c203dbf
EZ
62862011-09-20 Eli Zaretskii <eliz@gnu.org>
6287
6288 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
6289 a display string, extend search for cursor position to end of row.
6290 (find_row_edges): If the row ends in a newline from a display
6291 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
6292 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
6293 (Fcurrent_bidi_paragraph_direction): Fix search for previous
6294 non-empty line. Fixes confusing cursor motion with arrow keys at
6295 the beginning of a line that starts with whitespace.
8c203dbf 6296
a4824228
LMI
62972011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6298
6299 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
6300 (bug#9493).
6301
33ed493b
CY
63022011-09-18 Chong Yidong <cyd@stupidchicken.com>
6303
6304 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
6305 boolean (Bug#9154).
6306
56cd55c8
EZ
63072011-09-18 Eli Zaretskii <eliz@gnu.org>
6308
6309 * xdisp.c (display_line): Record maximum and minimum buffer
6310 positions even if no glyphs were produced (e.g., by a zero-width
6311 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
6312 buffer positions that will be removed from the glyph row because
6313 they don't fit.
c02dcedf
EZ
6314 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
6315 column is beyond frame width: don't subtract 1 "pixel" when
6316 computing width of the stretch.
3e62b7e0
EZ
6317 (reseat_at_next_visible_line_start): Undo the change made on
6318 2011-09-17 that saved paragraph information and restored it after
6319 the call to `reseat'. (Bug#9545)
56cd55c8 6320
5ed99d36 63212011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
6322
6323 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
6324 and turn window cursor on if cleared (Bug#9415).
6325
5ed99d36 63262011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
6327
6328 * search.c (boyer_moore): Take unibyte characters from pattern
6329 literally. (Bug#9458)
6330
9bade7b2
EZ
63312011-09-18 Eli Zaretskii <eliz@gnu.org>
6332
6333 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
6334
e5e9d610
PE
63352011-09-18 Paul Eggert <eggert@cs.ucla.edu>
6336
87e4427a
PE
6337 Fix minor problem found by static checking.
6338 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
6339 initialized, to pacify gcc -Wuninitialized.
6340
e5e9d610
PE
6341 * fileio.c: Report proper errno when syscall falls.
6342 (Finsert_file_contents): Save and restore errno,
6343 so that report_file_error outputs the correct diagnostic.
6344 (Fwrite_region) [CLASH_DETECTION]: Likewise.
6345
a1674f0b
EZ
63462011-09-18 Eli Zaretskii <eliz@gnu.org>
6347
6348 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
6349
fbfb6dd4
EZ
63502011-09-17 Eli Zaretskii <eliz@gnu.org>
6351
6352 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
6353 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
6354
bb187662
EZ
63552011-09-17 Eli Zaretskii <eliz@gnu.org>
6356
1137e8b8 6357 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 6358 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
6359
6360 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
6361 (bidi_find_paragraph_start): Search back for paragraph beginning
6362 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
6363 (bidi_move_to_visually_next): Only trigger paragraph-related
6364 computations when the last character is a newline or at EOB, not
6365 just any NEUTRAL_B. (Bug#9470)
6366
bb187662
EZ
6367 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
6368 truncated lines if point is covered by a display string. (Bug#9524)
6369
2e621251
PE
63702011-09-16 Paul Eggert <eggert@cs.ucla.edu>
6371
6372 * xselect.c: Relax test for outgoing X longs (Bug#9498).
6373 (cons_to_x_long): New function.
6374 (lisp_data_to_selection_data): Use it. Correct the test for
6375 short-versus-long data; it was negated. Break out of vector
6376 loop, for efficiency, when a long datum is discovered.
6377
91a15bc6
SM
63782011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
6379
6380 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
6381
b41c3a35
EZ
63822011-09-16 Eli Zaretskii <eliz@gnu.org>
6383
6384 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
6385 GCC PR/17406) by declaring this function with external scope.
6386
7812ba2d
PE
63872011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6388
6389 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
6390 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
6391
cf7edc2a
AS
63922011-09-15 Andreas Schwab <schwab@linux-m68k.org>
6393
6394 * editfns.c (Fformat): Correctly handle text properties on "%%".
6395
bd01620e
EZ
63962011-09-15 Eli Zaretskii <eliz@gnu.org>
6397
6398 * xterm.c (x_draw_composite_glyph_string_foreground):
6399 * w32term.c (x_draw_composite_glyph_string_foreground):
6400 * term.c (encode_terminal_code):
6401 * composite.c (composition_update_it, get_composition_id):
6402 * xdisp.c (get_next_display_element)
6403 (fill_composite_glyph_string): Add comments about special meaning
6404 of TAB characters in a composition.
6405
a02719a3
PE
64062011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6407
6408 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
6409 This occurs when processing a multibyte format.
6410 Problem reported by Wolfgang Jenker.
a02719a3 6411
72589a3c
JB
64122011-09-15 Johan Bockgård <bojohan@gnu.org>
6413
6414 * xdisp.c (try_cursor_movement): Only check for exact match if
6415 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
6416
1c14176c
PE
64172011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6418
6419 Remove unused external symbols.
6420 * dispextern.h (calc_pixel_width_or_height): Remove decl.
6421 * xdisp.c (calc_pixel_width_or_height): Now static.
6422 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
6423 * indent.c (check_display_width):
6424 * w32term.c: Fix comment to match code.
6425 * xterm.c, xterm.h (x_catching_errors): Remove.
6426
d2eea5b5
PE
64272011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6428
6429 * xselect.c: Use signed conversions more consistently (Bug#9498).
6430 (selection_data_to_lisp_data): Assume incoming selection data are
6431 signed integers, not unsigned. This is to be consistent with
6432 outgoing selection data, which was modified to use signed integers
6433 in as part of the fix to Bug#9196 in response to Jan D.'s comment
6434 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
6435 expects long, not unsigned long.
6436
46888499
EZ
64372011-09-14 Eli Zaretskii <eliz@gnu.org>
6438
6439 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
6440 computation of loop end. Reported by Johan Bockgård
6441 <bojohan@gnu.org>.
6442
ef8ef9fb
CY
64432011-09-13 Chong Yidong <cyd@stupidchicken.com>
6444
6445 * frame.c (Fother_visible_frames_p): Function deleted.
6446
fa819fed
EZ
64472011-09-12 Eli Zaretskii <eliz@gnu.org>
6448
6449 * indent.c (compute_motion): Process display vector front to back
6450 rather than the other way around. (Bug#2496)
6451
2ba8e008
SM
64522011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
6453
6454 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
6455
20f53c69
CY
64562011-09-11 Chong Yidong <cyd@stupidchicken.com>
6457
6458 * minibuf.c (Fread_from_minibuffer): Doc fix.
6459
d562d7a4
EZ
64602011-09-11 Eli Zaretskii <eliz@gnu.org>
6461
6462 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
6463 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
6464
1c4d7f3d
LMI
64652011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6466
6467 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
6468 value for non-existent files.
6469
b885bf36
EZ
64702011-09-11 Eli Zaretskii <eliz@gnu.org>
6471
6472 * fileio.c (Finsert_file_contents): If the file cannot be opened,
6473 set its "size" to -1. This will set the modtime_size field of
6474 the corresponding buffer to -1, which is what
6475 verify-visited-file-modtime expects for files that do not exist.
6476 (Bug#9139)
6477
6612f0bf
PE
64782011-09-11 Paul Eggert <eggert@cs.ucla.edu>
6479
6480 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
6481 here ...
6482 * lisp.h: ... from here. push_key_description is no longer
6483 defined in keyboard.c, so its declaration should not be in
6484 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
6485 logically belongs with push_key_description.
6486
dfb3f755
PE
64872011-09-10 Paul Eggert <eggert@cs.ucla.edu>
6488
6489 * buffer.h: Include <sys/types.h> instead of <time.h>.
6490 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
6491 Problem reported by Herbert J. Skuhra.
6492
3134906c
LMI
64932011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
6494
6495 * xml.c (parse_region): Make the parsing work for
6496 non-comment-starting XML files again (bug#9144).
6497
8d903f4e
AS
64982011-09-10 Andreas Schwab <schwab@linux-m68k.org>
6499
6500 * image.c (gif_load): Fix calculation of bottom and right corner.
6501 (Bug#9468)
6502
80ad64f4
EZ
65032011-09-10 Eli Zaretskii <eliz@gnu.org>
6504
6505 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
6506 redisplay in small windows.
6507
208a048d
EZ
65082011-09-09 Eli Zaretskii <eliz@gnu.org>
6509
6510 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
6511
9b1c252e
MR
65122011-09-08 Martin Rudalics <rudalics@gmx.at>
6513
6514 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
6515 Operate on live windows only.
6516
2949f33b
JB
65172011-09-08 Juanma Barranquero <lekktu@gmail.com>
6518
6519 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
6520
e08dcafd
EZ
65212011-09-07 Eli Zaretskii <eliz@gnu.org>
6522
6523 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
6524 only under bidi iteration.
6525
115b96bd
JD
65262011-09-07 Jan Djärv <jan.h.d@swipnet.se>
6527
6528 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
6529
c8199d0f
PE
65302011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6531
6532 isnan: Fix porting problem to Solaris 10 with bundled gcc.
6533 Without this fix, the command to link temacs failed due to an
6534 undefined symbol __builtin_isnan. This is because
6535 /usr/include/iso/math_c99.h #defines isnan(x) to
6536 __builtin_isnan(x), but the bundled gcc, which identifies itself
6537 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
6538 a __builtin_isnan.
6539 * floatfns.c (isnan): #undef, and then #define to a clone of
6540 what's in data.c.
6541 (Fisnan): Always define, since it's always available now.
6542 (syms_of_floatfns): Always define isnan at the Lisp level.
6543
e39b275c 65442011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
6545
6546 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
6547
b2db44d9 65482011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 6549
f4af5137 6550 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
6551 The previous code assumed that file offsets (off_t values) fit in
6552 EMACS_INT variables, which is not true on typical 32-bit hosts.
6553 The code messed up by falsely reporting buffer overflow in cases
6554 such as (insert-file-contents "big" nil 1 2) into an empty buffer
6555 when "big" contains more than 2**29 bytes, even though this
6556 inserts just one byte and does not overflow the buffer.
6557 (Finsert_file_contents): Store file offsets as off_t
6558 values, not as EMACS_INT values. Check for overflow when
6559 converting between EMACS_INT and off_t. When checking for
6560 buffer overflow or for overlap, take the offsets into account.
6561 Don't use EMACS_INT for small values where int suffices.
6562 When checking for overlap, fix a typo: ZV was used where
6563 ZV_BYTE was intended.
6564 (Fwrite_region): Don't assume off_t fits into 'long'.
6565 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
6566
ecfc0a49
MA
65672011-09-05 Michael Albinus <michael.albinus@gmx.de>
6568
6569 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
6570
6511acf2 65712011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 6572
0999621a 6573 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
6574
6575 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 6576 (esprintf, exprintf, evxprintf): New functions.
62f19c19 6577 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 6578 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
6579 (modify_event_symbol): Do not assume that the length of
6580 name_alist_or_stem is safe to alloca and fits in int.
6581 (Fexecute_extended_command): Likewise for function name and binding.
6582 (Frecursion_depth): Wrap around reliably on integer overflow.
6583 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
6584 since some callers pass EMACS_INT values.
6585 (Fsingle_key_description): Don't crash if symbol name contains more
6586 than MAX_ALLOCA bytes.
6587 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
6588 (get_minibuffer): Arg is now EMACS_INT, not int.
6589 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 6590 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
6591 * window.h (command_loop_level, minibuf_level): Reflect API changes.
6592
2be7d702
PE
6593 * dbusbind.c (signature_cat): New function.
6594 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
6595 Do not overrun buffer; instead, report string overflow.
6596
9d1df220
PE
6597 * dispnew.c (add_window_display_history): Don't overrun buffer.
6598 Truncate instead; this is OK since it's just a log.
6599
33ef5c64
PE
6600 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
6601 even if the time zone offset is outlandishly large.
6602 Don't mishandle offset == INT_MIN.
6603
66c6fdd5
PE
6604 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
6605 when creating daemon; the previous buffer-overflow check was incorrect.
6606
d749b01b
PE
6607 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
6608 which has the guts of the old verror function.
6609
b5cd1905
PE
6610 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
6611 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
6612
6e1a67fb
PE
6613 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
6614 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 6615 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 6616 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
6617 length of string rather than counting it via multiple sprintfs;
6618 that's simpler and more reliable.
c21721cc
PE
6619 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
6620 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
6621 sprintf, in case result does not fit in int.
6622
c57b67fc
PE
6623 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
6624 (fontset_from_font): Print it.
6625
8a401434
PE
6626 * frame.c (tty_frame_count): Now printmax_t, not int.
6627 (make_terminal_frame, set_term_frame_name): Print it.
6628 (x_report_frame_params): In X, window IDs are unsigned long,
6629 not signed long, so print them as unsigned.
6630 (validate_x_resource_name): Check for implausibly long names,
6631 and don't assume name length fits in 'int'.
6632 (x_get_resource_string): Don't blindly alloca invocation name;
6633 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
6634 not fit in int.
6635
6e1a67fb
PE
6636 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
6637 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
6638 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
6639
0df02bf3
PE
6640 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
6641 Use esprintf, not sprintf, in case result does not fit in int.
6642
48e30793
PE
6643 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6644 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
6645 it as a large positive number.
6646 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
6647 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6648
a66ff6d8
PE
6649 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
6650 in case result does not fit in int.
6651
aca216ff
PE
6652 * print.c (float_to_string): Detect width overflow more reliably.
6653 (print_object): Make sprintf buffer a bit bigger, to avoid potential
6654 buffer overrun. Don't assume list length fits in 'int'. Treat
6655 print length of 0 as 0, not as infinity; to be consistent with other
6656 uses of print length in this function. Don't overflow print length
6657 index. Don't assume hash table size fits in 'long', or that
6658 vectorlike size fits in 'unsigned long'.
6659
31c286f7
PE
6660 * process.c (make_process): Use printmax_t, not int, to format
6661 process-name gensyms.
6662
55e5faa1
PE
6663 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
6664
80f2e268
PE
6665 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
6666 to avoid potential buffer overrun.
6667
670741ab
PE
6668 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
6669 if X resource line is longer than 512 bytes.
6670
b7163a50
PE
6671 * xfns.c (x_window): Make sprintf buffer a bit bigger
6672 to avoid potential buffer overrun.
6673
ae58ff1f
PE
6674 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
6675
c43c8a6a
PE
6676 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
6677
3f8236f4
PE
66782011-09-04 Paul Eggert <eggert@cs.ucla.edu>
6679
53e9fe90 6680 Integer overflow fixes for scrolling, etc.
6511acf2
PE
6681 Without these, Emacs silently mishandles large integers sometimes.
6682 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
6683 it were "C-u 1 M-x recenter" on a typical 64-bit host.
6684
6511acf2
PE
6685 * xdisp.c (try_window_id): Check Emacs fixnum range before
6686 converting to 'int'.
806add1d 6687
6511acf2 6688 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
6689 Check that an Emacs fixnum is in range before assigning it to 'int'.
6690 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
6691 values converted from Emacs fixnums.
6692 (Frecenter): Don't wrap around a line count if it is out of 'int'
6693 range; instead, treat it as an extreme value.
6694 (Fset_window_configuration, compare_window_configurations):
6695 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
6696
6511acf2
PE
6697 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
6698 that can exceed INT_MAX. Check that EMACS_INT value is in range
6699 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
6700 (match_limit): Don't assume that a fixnum can fit in 'int'.
6701
6511acf2 6702 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
6703 exceed INT_MAX.
6704
6511acf2 6705 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
6706 (Fvertical_motion): Don't wrap around LINES values that don't fit
6707 in 'int'. Instead, treat them as extreme values. This is good
6708 enough for windows, which can't have more than INT_MAX lines anyway.
6709
fcb901a7
LMI
67102011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6711
0f2f6b6d
LMI
6712 * Require libxml/parser.h to avoid compilation warning.
6713
fcb901a7
LMI
6714 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
6715
6716 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
6717 since this reportedly can destroy thread storage.
6718
6e20a0d4
CY
67192011-08-30 Chong Yidong <cyd@stupidchicken.com>
6720
6721 * syntax.c (find_defun_start): Update all cache variables if
6722 exiting early (Bug#9401).
6723
148ae00e
EZ
67242011-08-30 Eli Zaretskii <eliz@gnu.org>
6725
f6cfbd8f
EZ
6726 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
6727
148ae00e
EZ
6728 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
6729 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
6730 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
6731
6732 * term.c (tty_append_glyph): New function.
6733 (produce_stretch_glyph): Static function and its prototype deleted.
6734
a66cfb1c
SM
6735 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
6736 Add prototypes.
148ae00e 6737
c4a07a4c
PE
67382011-08-29 Paul Eggert <eggert@cs.ucla.edu>
6739
6740 * image.c (parse_image_spec): Check for nonnegative, not for positive,
6741 when checking :margin (Bug#9390).
6742 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 6743 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
6744 so that the name doesn't mislead. All uses changed.
6745
6bc8cd65
JB
67462011-08-28 Johan Bockgård <bojohan@gnu.org>
6747
6748 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
6749 set_tty_hooks.
6750
dca4927e
EZ
67512011-08-27 Eli Zaretskii <eliz@gnu.org>
6752
6753 * xdisp.c (move_it_to): Don't bail out early when reaching
6754 position beyond to_charpos, if we are scanning backwards.
6755 (move_it_vertically_backward): When DY == 0, make sure we get to
6756 the first character in the line after the newline.
6757
f2cad773
PE
67582011-08-27 Paul Eggert <eggert@cs.ucla.edu>
6759
6760 * ccl.c: Improve and simplify overflow checking (Bug#9196).
6761 (ccl_driver): Do not generate an out-of-range pointer.
6762 (Fccl_execute_on_string): Remove unnecessary check for
6763 integer overflow, noted by Stefan Monnier in
6764 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
6765 Remove a FIXME that didn't need fixing.
6766 Simplify the newly-introduced buffer reallocation code.
6767
0cae2cdb
JB
67682011-08-27 Juanma Barranquero <lekktu@gmail.com>
6769
6770 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
6771
5fc295a4 67722011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 6773
70c60eb2 6774 Integer and memory overflow issues (Bug#9196).
726e0ab1 6775
d31850da
PE
6776 * doc.c (get_doc_string): Rework so that
6777 get_doc_string_buffer_size is the actual buffer size, rather than
6778 being 1 less than the actual buffer size; this makes xpalloc more
6779 convenient.
6780
a69fbedb
PE
6781 * image.c (x_allocate_bitmap_record, cache_image):
6782 * xselect.c (Fx_register_dnd_atom):
6783 Simplify previous changes by using xpalloc.
6784
fe5c5d37
PE
6785 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
6786 since either will do and ptrdiff_t is convenient with xpalloc.
6787
0065d054
PE
6788 * charset.c (charset_table_size)
6789 (struct charset_sort_data.priority): Now ptrdiff_t.
6790 (charset_compare): Don't overflow if priorities differ greatly.
6791 (Fsort_charsets): Don't assume list length fits in int.
6792 Check for size-calculation overflow when allocating sort data.
6793 (syms_of_charset): Allocate an initial charset table that is
6794 just under 64 KiB, to avoid problems with glibc malloc and mmap.
6795
6796 * cmds.c (internal_self_insert): Check for size-calculation overflow.
6797
6798 * composite.h (struct composition.glyph_len): Now int, not unsigned.
6799 The actual value is always <= INT_MAX, and leaving it unsigned made
6800 overflow checking harder.
6801
6802 * dispextern.h (struct glyph_matrix.rows_allocated)
6803 (struct face_cache.size): Now ptrdiff_t, for convenience in use
6804 with xpalloc. The values are still always <= INT_MAX.
6805
6806 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
6807
6808 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
6809 (SAFE_NALLOCA): New macro.
6810
6811 * region-cache.c (struct boundary.pos, find_cache_boundary)
6812 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
6813 (set_cache_region, invalidate_region_cache)
6814 (revalidate_region_cache, know_region_cache, region_cache_forward)
6815 (region_cache_backward, pp_cache):
6816 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
6817 so that ptrdiff_t * can be passed to xpalloc.
6818 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
6819 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
6820 (pp_cache): Don't assume cache_len fits in int.
6821 * region-cache.h: Adjust extern decls to match.
6822
6823 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
6824 EMACS_INT, since either will do, for xpalloc.
6825
6826 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
6827 (xnmalloc, xnrealloc, xpalloc): New functions.
6828
726e0ab1
PE
6829 * bidi.c (bidi_shelve_header_size): New constant.
6830 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
6831 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
6832
51f30bc5 6833 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
6834 * buffer.c (overlays_at, overlays_in, record_overlay_string)
6835 (overlay_strings):
6836 Don't update size of array until after memory allocation succeeds,
6837 because xmalloc/xrealloc may not return.
0065d054
PE
6838 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
6839 now that we have proper integer overflow checking.
6840 (record_overlay_string, overlay_strings): Catch overflows when
6841 calculating size of overlay_str_buf.
726e0ab1 6842
0065d054
PE
6843 * callproc.c (Fcall_process): Check for size overflow when
6844 calculating size of args2.
6845 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
6846 Normally we prefer signed values, but sticking with ptrdiff_t would
6847 require adding more-complicated checks.
726e0ab1
PE
6848
6849 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
6850 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
6851 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 6852 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
6853
6854 * character.c (Fstring): Check for size-calculation overflow.
6855
6856 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
6857 unnecessary integer overflow. Check for size overflow.
6858 (encode_coding_object): Don't update size until xmalloc succeeds.
6859
6860 * composite.c (get_composition_id): Check for overflow in glyph
6861 length calculations.
6862
6863 Integer and memory overflow fixes for display code.
6864 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
6865 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
6866 (scrolling_window): Check for overflow in size calculations.
6867 (line_draw_cost, realloc_glyph_pool, add_row_entry):
6868 Don't assume glyph table len fits in int.
6869 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
6870 (row_table_size): Now ptrdiff_t, not int.
6871 (scrolling_window): Avoid overflow in size calculations.
6872 Don't update size until allocation succeeds.
6873 * fns.c (concat): Check for overflow in size calculations.
6874 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
6875 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6876 (NEXT_ALMOST_PRIME_LIMIT): New constant.
6877
6878 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
6879 (get_doc_string): Check for size calculation overflow.
6880 Don't update size until allocation succeeds.
6881 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
6882 EMACS_INT, where ptrdiff_t will do.
6883 (Fsubstitute_command_keys): Check for string overflow.
6884
6885 * editfns.c (set_time_zone_rule): Don't assume environment length
6886 fits in int.
6887 (message_length): Now ptrdiff_t, not int.
6888 (Fmessage_box): Don't update size until allocation succeeds.
6889 Don't assume message length fits in int.
6890 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
6891
0065d054
PE
6892 * emacs.c (main): Do not reallocate argv, since there is a null at
6893 the end that can be overwritten, and this way there's no need to
6894 worry about size-calculation overflow.
6895 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
6896
6897 * eval.c (init_eval_once, grow_specpdl): Don't update size until
6898 alloc succeeds.
6899 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
6900
6901 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
6902 (x_set_scroll_bar_width, x_figure_window_size):
6903 Check for integer overflow.
6904 (x_set_alpha): Do not assume XINT fits in int.
6905
6906 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
6907 This is for the members text_lines, text_cols, total_lines, total_cols,
6908 where the system imposes an 'int' limit.
6909
6910 * fringe.c (Fdefine_fringe_bitmap):
6911 Don't update size until alloc works.
6912
6913 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
6914 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
6915
6916 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
6917 Check for size-calculation overflow.
6918 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
6919 do, as we prefer signed integers.
6920 (id_to_widget.max_size, id_to_widget.used)
6921 (xg_store_widget_in_map, xg_remove_widget_from_map)
6922 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
6923 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
6924 Use and return ptrdiff_t, not int.
6925 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
6926 * gtkutil.h: Change prototypes to match the above.
6927
6928 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
6929 are duplicate now that they've been promoted to lisp.h.
6930 (x_allocate_bitmap_record, x_alloc_image_color)
6931 (make_image_cache, cache_image, xpm_load):
6932 Don't update size until alloc is done.
6933 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
6934 (x_detect_edges):
3256efce 6935 Check for size calculation overflow.
726e0ab1
PE
6936 (ct_colors_allocated_max): New constant.
6937 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
6938 overflow.
3256efce 6939
726e0ab1
PE
6940 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
6941 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
6942 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
6943 Use ptrdiff_t, not int, to count maps.
6944 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
6945 calculations. Don't update size until allocation succeeds.
6946 Redo calculations to avoid overflow.
726e0ab1
PE
6947 * keyboard.h: Change prototypes to match the above.
6948
6949 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
6950 to count maps.
6951 (current_minor_maps): Check for size calculation overflow.
6952 * keymap.h: Change prototypes to match the above.
6953
6954 * lread.c (read1, init_obarray): Don't update size until alloc done.
6955
6956 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
6957 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
6958
726e0ab1
PE
6959 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
6960 Now ptrdiff_t, not int.
6961 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
6962 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
6963
6964 * process.c (Fnetwork_interface_list): Check for overflow
6965 in size calculation.
6966
6967 * region-cache.c (move_cache_gap): Check for size calculation overflow.
6968
6969 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
6970 overflow. Don't bother calling xmalloc when xrealloc will do.
6971
6972 * search.c (Freplace_match): Check for size calculation overflow.
6973 (Fset_match_data): Don't assume list lengths fit in 'int'.
6974
6975 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
6976 for command line length. Do not attempt to address one before the
6977 beginning of an array, as that's not portable.
6978
6979 * term.c (max_frame_lines): Remove; unused.
6980 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
6981 not int.
6982 (encode_terminal_code, calculate_costs): Check for size
6983 calculation overflow.
6984 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
6985 table lengths and related sizes. Don't update size until alloc
6986 done. Redo calculations to avoid overflow.
6987 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
6988
6989 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
6990 subtracting pointers.
6991 (gobble_line): Check for overflow more carefully. Don't update size
6992 until alloc done.
6993
6994 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
6995 Don't update size until alloc done.
6996 Redo size calculations to avoid overflow.
6997 Check for size calculation overflow.
0065d054 6998 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
6999
7000 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
7001 Use ptrdiff_t, not int, for sizes.
7002 (store_mode_line_noprop_char): Don't update size until alloc done.
7003
0065d054
PE
7004 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
7005 Use ptrdiff_t, not int, for sizes.
7006 (Finternal_make_lisp_face, cache_face):
7007 Check for size calculation overflow.
7008 (cache_face): Treat size calculation overflows as if they were
7009 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
7010
7011 * xfns.c (x_encode_text, x_set_name_internal)
7012 (Fx_change_window_property): Use ptrdiff_t, not int, to count
7013 sizes, since they can exceed INT_MAX in size. Check for size
7014 calculation overflow.
7015
0065d054
PE
7016 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
7017 (xg_select): Check for size calculation overflow.
726e0ab1
PE
7018 Don't update size until alloc done.
7019
0065d054 7020 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 7021 as sprintf is limited to int lengths.
1d526e2f 7022
252c5ee1
PE
7023 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
7024 (X_LONG_MIN): New macros.
864d7ce7
PE
7025 Use them to make the following changes clearer.
7026 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
7027 This change doesn't affect the value now, but it may help remind
7028 future maintainers not to raise the value too much later.
7029 (SELECTION_QUANTUM): Remove, replacing with ...
7030 (selection_quantum): ... new function, which avoids overflow.
7031 All uses changed.
7032 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
7033 assumption that selection length fits in 'int'.
7034 (x_reply_selection_request, x_handle_selection_request)
7035 (x_get_window_property, receive_incremental_selection)
7036 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
7037 (lisp_data_to_selection_data, clean_local_selection_data):
7038 Use ptrdiff_t, not int, to record length of selection.
7039 (x_reply_selection_request, x_get_window_property)
7040 (receive_incremental_selection, x_property_data_to_lisp):
7041 Redo calculations to avoid overflow.
7042 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 7043 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
7044 something.
7045 (x_get_window_property, receive_incremental_selection)
7046 (lisp_data_to_selection_data, x_property_data_to_lisp):
7047 Check for size-calculation overflow.
7048 (x_get_window_property, receive_incremental_selection)
7049 (lisp_data_to_selection_data, Fx_register_dnd_atom):
7050 Don't store size until memory allocation succeeds.
7051 (x_get_window_property): Plug memory leak on memory exhaustion.
7052 Don't double-block input; malloc is safe here. Don't assume 2**34
7053 - 4 fits in unsigned long. Add an xassert to check
7054 XGetWindowProperty overflow. Be more careful about overflow
7055 calculations, and distinguish size from memory overflow better.
7056 (receive_incremental_selection): When tracing, don't assume
7057 unsigned int is less than INT_MAX.
7058 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
7059 harmful) conversions of unsigned short to int.
7060 (lisp_data_to_selection_data): Don't assume that integers
7061 in the range -65535 through -1 fit in an X unsigned short.
7062 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
7063 result parameters unless successful. Rely on cons_to_unsigned
7064 to report problems with elements; the old code wasn't right anyway.
7065 (x_check_property_data): Check for int overflow; we cannot use
7066 a wider type due to X limits.
7067 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
7068
726e0ab1 7069 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 7070
0065d054
PE
7071 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
7072 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
7073 (x_color_cells): Don't store size until memory allocation succeeds.
7074 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 7075 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
7076 (x_term_init): Don't assume length fits in int (sprintf is limited
7077 to int size).
bc18e09d 7078
ebfa62c0
PE
7079 Use ptrdiff_t for composition IDs.
7080 * character.c (lisp_string_width):
7081 * composite.c (composition_table_size, n_compositions)
7082 (get_composition_id, composition_gstring_from_id):
7083 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
7084 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
7085 * window.c (Frecenter):
7086 Use ptrdiff_t, not int, for composition IDs.
7087 * composite.c (get_composition_id): Check for integer overflow.
7088 * composite.h: Adjust prototypes to match the above changes.
7089
d3411f89
PE
7090 Use ptrdiff_t for hash table indexes.
7091 * category.c (hash_get_category_set):
7092 * ccl.c (ccl_driver):
7093 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
7094 * coding.c (coding_system_charset_list, detect_coding_system):
7095 * coding.h (struct coding_system.id):
7096 * composite.c (get_composition_id, gstring_lookup_cache):
7097 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
7098 * image.c (xpm_get_color_table_h):
7099 * lisp.h (hash_lookup, hash_put):
7100 * minibuf.c (Ftest_completion):
7101 Use ptrdiff_t for hash table indexes, not int (which is too
7102 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
7103 32-bit --with-wide-int hosts).
7104
e097a6fa
PE
7105 * charset.c (Fdefine_charset_internal): Check for integer overflow.
7106 Add a FIXME comment about memory leaks.
7107 (syms_of_charset): Don't assume xmalloc returns.
7108
5637687f
PE
7109 Don't assume that stated character widths fit in int.
7110 * character.c (Fchar_width, c_string_width, lisp_string_width):
7111 * character.h (CHAR_WIDTH):
7112 * indent.c (MULTIBYTE_BYTES_WIDTH):
7113 Use sanitize_char_width to avoid undefined and/or bad behavior
7114 with outlandish widths.
a66cfb1c 7115 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
7116 now that we have two such functions. All uses changed.
7117 (sanitize_char_width): New inline function.
7118
a2271ba2
PE
7119 Don't assume that tab-width fits in int.
7120 * character.h (sanitize_width): New inline function.
7121 (SANE_TAB_WIDTH): New macro.
7122 (ASCII_CHAR_WIDTH): Use it.
7123 * indent.c (sane_tab_width): Remove. All uses replaced by
7124 SANE_TAB_WIDTH (current_buffer).
7125 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
7126
18c52557
PE
7127 * fileio.c: Integer overflow issues with file modes.
7128 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
7129
caeeedc1
PE
7130 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
7131 Remove unreachable code.
7132 (read_hex, load_charset_map_from_file): Check for integer overflow.
7133
6df6ae42 7134 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
7135 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
7136 (x_send_scroll_bar_event): Likewise. Check that the size does not
7137 exceed limits imposed by XClientMessageEvent, as well as the usual
7138 ptrdiff_t and size_t limits.
7139
b13995db
PE
7140 * keyboard.c: Overflow, signedness and related fixes.
7141 (make_lispy_movement): Use same integer type in forward decl
7142 that is used in the definition.
7143 (read_key_sequence, keyremap_step):
7144 Change bufsize argument back to int, undoing my 2011-03-30 change.
7145 We prefer signed types, and int is wide enough here.
7146 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
7147 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
7148 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
7149 length, not size_t. Use ptrdiff_t for index, not int.
7150 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
7151 possibility of integer overflow.
7152
13464394
PE
7153 Overflow, signedness and related fixes for images.
7154
7155 * dispextern.h (struct it.stack[0].u.image.image_id)
7156 (struct_it.image_id, struct image.id, struct image_cache.size)
7157 (struct image_cache.used, struct image_cache.ref_count):
7158 * gtkutil.c (update_frame_tool_bar):
7159 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
7160 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
7161 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
7162 * nsmenu.m (update_frame_tool_bar):
7163 * xdisp.c (calc_pixel_width_or_height):
7164 * xfns.c (image_cache_refcount):
7165 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
7166 on typical 64-bit hosts.
7167
7168 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7169 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
7170 Omit unnecessary casts to int.
7171 (parse_image_spec): Check that integers fall into 'int' range
7172 when the callers expect that.
7173 (image_ascent): Redo ascent calculation to avoid int overflow.
7174 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
7175 (lookup_image): Remove unnecessary tests.
7176 (xbm_image_p): Locals are now of int, not EMACS_INT,
7177 since parse_image_check makes sure they fit into int.
7178 (png_load, gif_load, svg_load_image):
7179 Prefer int to unsigned where either will do.
7180 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
7181 old tiff_error_handler and tiff_warning_handler.
7182 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
7183 stack buffer overflows. It uses only the features of vsnprintf
7184 that are common to both POSIX and native Microsoft.
7185 (tiff_error_handler, tiff_warning_handler): Use it.
7186 (tiff_load, gif_load, imagemagick_load_image):
7187 Don't assume :index value fits in 'int'.
7188 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
7189 (imagemagick_load_image): Check that crop parameters fit into
7190 the integer types that MagickCropImage accepts. Don't assume
7191 Vimagemagick_render_type has a nonnegative value. Don't assume
7192 size_t fits in 'long'.
7193 (gs_load): Use printmax_t to print the widest integers possible.
7194 Check for integer overflow when computing image height and width.
7195
c11821d4
EZ
71962011-08-26 Eli Zaretskii <eliz@gnu.org>
7197
7198 * xdisp.c (redisplay_window): Don't force window start if point
7199 will be invisible in the resulting window. (Bug#9324)
7200
0c95fcf7
EZ
72012011-08-25 Eli Zaretskii <eliz@gnu.org>
7202
7203 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
7204 the display spec is of the form `(space ...)'.
7205 (handle_display_spec): Return the value returned by
7206 handle_single_display_spec, not just 1 or zero.
7207 (handle_single_display_spec): If the display spec is of the form
7208 `(space ...)', and specifies display in the text area, return 2
7209 rather than 1.
fee65a97 7210 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
7211 accurately, and prefer exact match for point under bidi.
7212 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
7213
7214 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
7215 into disp_prop; all users changed.
7216
7217 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
7218 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
7219 for the text covered by the display property.
7220
e4ed06f1
CY
72212011-08-25 Chong Yidong <cyd@stupidchicken.com>
7222
7223 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
7224 Change return value to nil.
7225 (Frecord_buffer): Delete unused function.
7226
f67cdd7f
EZ
72272011-08-24 Eli Zaretskii <eliz@gnu.org>
7228
5980d4c6
EZ
7229 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
7230 buffers, return left-to-right.
8610fe8b
EZ
7231 (set_cursor_from_row): Consider candidate row a win if its glyph
7232 represents a newline and point is on that newline. Fixes cursor
7233 positioning on the newline at EOL of R2L text within L2R
7234 paragraph, and vice versa.
7235 (try_cursor_movement): Check continued rows, in addition to
7236 continuation rows. Fixes unwarranted scroll when point enters a
7237 continued line of R2L text within an L2R paragraph, or vice versa.
7238 (cursor_row_p): Consider the case of point being equal to
7239 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
7240 from the end of a short line to the beginning of a continued line
7241 of R2L text within L2R paragraph.
7242 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
7243 composed characters.
5980d4c6 7244
f67cdd7f
EZ
7245 * bidi.c (bidi_check_type): Use xassert.
7246 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
7247 members.
7248
bca633fb
EZ
72492011-08-23 Eli Zaretskii <eliz@gnu.org>
7250
7251 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
7252 a character.
7253
4a5885a7
CY
72542011-08-23 Chong Yidong <cyd@stupidchicken.com>
7255
7256 * nsfont.m (ns_otf_to_script): Fix typo.
7257
0902a04e
KH
72582011-08-22 Kenichi Handa <handa@m17n.org>
7259
7260 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
7261 extra slot even if the purpose is char-code-property-table.
7262
1a2e6670
EZ
72632011-08-23 Eli Zaretskii <eliz@gnu.org>
7264
8ddde651
EZ
7265 * xdisp.c (redisplay_window): When computing centering_position,
7266 account for the height of the header line. (Bug#8874)
7267
425cc014
EZ
7268 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
7269 instead of CHAR_TO_BYTE. Fixes a crash when a completion
7270 candidate is selected by the mouse, and that candidate has a
7271 composed character under the mouse.
7272
1a2e6670
EZ
7273 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
7274 coordinates reported by pos-visible-in-window-p for a composed
7275 character in column zero.
7276
8b76d6f8
SM
72772011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
7278
7279 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
7280
dac347dd
EZ
72812011-08-22 Eli Zaretskii <eliz@gnu.org>
7282
7283 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
7284 consider it a hit if to_charpos is anywhere in the range of the
7285 composed buffer positions.
7286
e013fb34
CY
72872011-08-22 Chong Yidong <cyd@stupidchicken.com>
7288
7289 * image.c (gif_load): Don't assume that each subimage has the same
7290 dimensions as the base image. Handle disposal method that is
7291 "undefined" by the gif spec (Bug#9335).
7292
bd1ba3e8
CY
72932011-08-20 Chong Yidong <cyd@stupidchicken.com>
7294
7295 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 7296 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 7297
54a1215b
EZ
72982011-08-19 Eli Zaretskii <eliz@gnu.org>
7299
823564e5
EZ
7300 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
7301 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
7302 from an Org mode buffer to a Speedbar frame.
7303
54a1215b
EZ
7304 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
7305 a composition, take its buffer position from IT->cmp_it.charpos.
7306 Fixes cursor positioning at the beginning of a line that begins
7307 with a composed character.
7308
9778ebcc
EZ
73092011-08-18 Eli Zaretskii <eliz@gnu.org>
7310
0be6ee06
EZ
7311 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
7312 character bidirectional type, use STRONG_L instead. Fixes crashes
7313 in a buffer produced by `describe-categories'.
7314
9778ebcc
EZ
7315 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
7316 members before the level stack, so they would be saved and
7317 restored when copying iterator state. Fixes incorrect reordering
7318 around TABs covered by display properties.
7319
156bffbe
AS
73202011-08-18 Andreas Schwab <schwab@linux-m68k.org>
7321
6b02f655 7322 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 7323
72ad093b
CY
73242011-08-17 Chong Yidong <cyd@stupidchicken.com>
7325
7326 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
7327 (internal_condition_case_2, internal_condition_case_n):
7328 Remove unnecessary aborts (Bug#9081).
72ad093b 7329
35774242
EZ
73302011-08-17 Eli Zaretskii <eliz@gnu.org>
7331
7332 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
7333 has no `load' handler, try opening the file locally. (Bug#9311)
7334
db76dd85
KB
73352011-08-16 Ken Brown <kbrown@cornell.edu>
7336
7337 * gmalloc.c: Expand comment.
7338
b215eee5
EZ
73392011-08-16 Eli Zaretskii <eliz@gnu.org>
7340
7341 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
7342 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
7343
a4579d33
KB
73442011-08-16 Ken Brown <kbrown@cornell.edu>
7345
7346 Fix memory allocation problems in Cygwin build (Bug#9273).
7347
7348 * unexcw.c ( __malloc_initialized): Declare external variable.
7349 (fixup_executable): Force the dumped emacs to reinitialize malloc.
7350
8b76d6f8
SM
7351 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
7352 New variables.
a4579d33
KB
7353 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
7354 dumped emacs.
7355 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
7356 in the static heap.
7357 [CYGWIN] (special_realloc): New function.
7358 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
7359 requests to realloc storage in the static heap.
7360
3ebec551
PE
73612011-08-15 Paul Eggert <eggert@cs.ucla.edu>
7362
7363 * bidi.c (bidi_initialize): Remove unused local.
7364
9fd8be00
EZ
73652011-08-15 Eli Zaretskii <eliz@gnu.org>
7366
6b02f655
SM
7367 * bidimirror.h:
7368 * biditype.h: Remove file.
7369 * makefile.w32-in ($(BLD)/bidi.$(O)):
7370 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
7371
7372 * dispextern.h: Fix a typo in the comment to bidi_type_t.
7373
7374 * chartab.c: Improve commentary for the uniprop_table API.
7375
32413314
EZ
7376 * bidi.c (bidi_paragraph_init): Support zero value of
7377 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
7378 (bidi_initialize): Use uniprop_table instead of including
7379 biditype.h and bidimirror.h.
32413314 7380
9fd8be00
EZ
7381 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
7382 coordinates of the iterator when restoring from ppos_it.
7383 (Bug#9296)
7384
5cf2b69b
KH
73852011-08-14 Kenichi Handa <handa@m17n.org>
7386
7387 * process.c (create_process): Call setup_process_coding_systems
72ad093b 7388 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 7389
daf17d00
EZ
73902011-08-14 Eli Zaretskii <eliz@gnu.org>
7391
7392 * xdisp.c (move_it_in_display_line_to): Don't invoke
7393 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
7394 ppos_it. Fixes vertical cursor motion when line beginning is
7395 covered by an image. (Bug#9296)
7396
08e3161a
JD
73972011-08-14 Jan Djärv <jan.h.d@swipnet.se>
7398
7399 * nsterm.h (ns_run_ascript): Declare.
7400 (NSAPP_DATA2_RUNASSCRIPT): Define.
7401
7402 * nsfns.m (as_script, as_result, as_status): New static variables.
7403 (ns_run_ascript): New function.
5e617bc2 7404 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
7405 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
7406 the event loop. Get status from as_status (Bug#7276).
7407
7408 * nsterm.m (sendEvent): If event is NSApplicationDefined and
7409 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
7410 the event loop (Bug#7276).
7411
a3720aa2
AS
74122011-08-14 Andreas Schwab <schwab@linux-m68k.org>
7413
7414 * gnutls.c (QCgnutls_bootprop_priority)
7415 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
7416 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
7417 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
7418 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
7419 (QCgnutls_bootprop_verify_hostname_error)
7420 (QCgnutls_bootprop_callbacks_verify): Rename from
7421 Qgnutls_bootprop_..., all uses changed.
7422
7423 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
7424 uses changed.
7425
0a0d27fb
PE
74262011-08-14 Paul Eggert <eggert@cs.ucla.edu>
7427
19d5c50c
PE
7428 * xfaces.c (Qframe_set_background_mode): Now static.
7429 * dispextern.h (Qframe_set_background_mode): Remove decl.
7430
0a0d27fb
PE
7431 * process.c (Fnetwork_interface_info): Declare local only if needed.
7432
377538cb
JD
74332011-08-13 Jan Djärv <jan.h.d@swipnet.se>
7434
7435 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
7436 (Fnetwork_interface_list): Allocate in increments of bytes instead
7437 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
7438 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
7439 sockaddr.
7440 (struct ifflag_def): notrailers is smart on OSX.
7441 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
7442 Get hardware address with getifaddrs if available.
7443
08fff70c
EZ
74442011-08-12 Eli Zaretskii <eliz@gnu.org>
7445
7446 * xdisp.c (iterate_out_of_display_property): xassert that
7447 IT->position is set to within IT->object's boundaries. Break from
7448 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
7449 when IT->position is set up wrongly due to some bug.
7450 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
7451 (push_display_prop): Allow GET_FROM_STRING as IT->method on
7452 entry. Force push_it to save on the stack the current
7453 buffer/string position, to be restored by pop_it. Fix flags in
7454 the iterator structure wrt the object coming from a display
7455 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
7456 properties. (Bug#9284)
7457
7be1c708 74582011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 7459
7be1c708
CY
7460 * fontset.c (fontset_get_font_group): Add proper type checks.
7461 (Bug#9172)
aac0c6e3 7462
7be1c708 74632011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 7464
7be1c708
CY
7465 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
7466 and LC_VERSION_MIN_MACOSX.
7467 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
7468 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 7469
97bb72a6
EZ
74702011-08-08 Eli Zaretskii <eliz@gnu.org>
7471
7472 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
7473 no-display-properties-and-no-overlays under bidi display.
7474 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 7475 properties and overlays.
97bb72a6 7476
d5617611
CY
74772011-08-08 Chong Yidong <cyd@stupidchicken.com>
7478
37e11a63
CY
7479 * editfns.c (Fset_time_zone_rule): Document relationship with the
7480 setenv function.
7481
d5617611
CY
7482 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
7483 the font entity extracted from the cache (Bug#8109).
7484
58872834
CY
74852011-08-07 Chong Yidong <cyd@stupidchicken.com>
7486
7487 * composite.c (autocmp_chars): Don't reset point. That is done by
7488 restore_point_unwind (Bug#5984).
7489
75bfc667
JL
74902011-08-07 Juri Linkov <juri@jurta.org>
7491
7492 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
7493 to show the arg `TIME' instead of `TIMEVAL'.
7494
d1410150
EZ
74952011-08-06 Eli Zaretskii <eliz@gnu.org>
7496
7497 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
7498 display property strides EOL and includes a newline, as in
7499 longlines-mode. (Bug#9254)
75b771e4
EZ
7500 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
7501 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
7502
7503 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
7504 is non-zero, even if the data buffer is NULL. Fixes a crash in
7505 vertical-motion with longlines-mode. (Bug#9254)
7506
35928349
EZ
75072011-08-05 Eli Zaretskii <eliz@gnu.org>
7508
ec7cc85b
EZ
7509 * bidi.c <bidi_cache_total_alloc>: Now static.
7510 (bidi_initialize): Initialize bidi_cache_total_alloc.
7511
8b76d6f8 7512 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
7513 cache. (Bug#9221)
7514
7515 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
7516 amount allocated this far in `bidi_cache_total_alloc'.
7517 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
7518 non-zero, only free the data buffer without restoring the cache
7519 contents. All callers changed.
7520
7521 * dispextern.h (bidi_unshelve_cache): Update prototype.
7522
7523 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
7524 (move_it_in_display_line, move_it_to)
7525 (move_it_vertically_backward, move_it_by_lines): Replace the call
7526 to xfree to an equivalent call to bidi_unshelve_cache.
7527 (move_it_in_display_line_to): Fix logic of returning
412b6358 7528 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 7529
e2e2423b
EZ
75302011-08-05 Eli Zaretskii <eliz@gnu.org>
7531
7532 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
7533 came from a string character with a `cursor' property. (Bug#9229)
7534
ae9e757a
JD
75352011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7536
7537 * Makefile.in (LIB_PTHREAD): New variable.
7538 (LIBES): Add LIB_PTHREAD (Bug#9216).
7539
7540 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
7541 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
7542
213bd7f2
AS
75432011-08-04 Andreas Schwab <schwab@linux-m68k.org>
7544
6b02f655 7545 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 7546
99aaf75f
JD
75472011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7548
7549 * xterm.c (x_find_topmost_parent): New function.
7550 (x_set_frame_alpha): Find topmost parent window with
7551 x_find_topmost_parent and set the property there also (bug#9181).
7552 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
7553
c74e9d86
PE
75542011-08-04 Paul Eggert <eggert@cs.ucla.edu>
7555
7556 * callproc.c (Fcall_process): Avoid vfork clobbering
7557 the local vars buffer, coding_systems, current_dir.
7558
640c8776
SM
75592011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
7560
7561 * keymap.c (Fmake_composed_keymap): Move to subr.el.
7562
f26d0e4c
PE
75632011-08-03 Paul Eggert <eggert@cs.ucla.edu>
7564
8a10d76c
PE
7565 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
7566 so that it is not optimized away.
7567
f26d0e4c
PE
7568 * xdisp.c (compute_display_string_pos): Remove unused local.
7569
55439c61
EZ
75702011-08-02 Eli Zaretskii <eliz@gnu.org>
7571
7572 Fix slow cursor motion and scrolling in large buffers with
7573 selective display, like Org Mode buffers. (Bug#9218)
7574
7575 * dispextern.h (struct bidi_it): New member disp_prop_p.
7576
7577 * xdisp.c: Remove one-slot cache of display string positions.
7578 (compute_display_string_pos): Accept an additional argument
5e617bc2 7579 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
7580 for a display string or property. If found, set DISP_PROP_P
7581 non-zero.
7582
7583 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
7584 DISP_PROP_P, and pass it to compute_display_string_pos.
7585 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
7586 non-zero. All callers of bidi_fetch_char changed.
7587
fb33fa43
SM
75882011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
7589
7590 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
7591
b099e063
DM
75922010-12-03 Don March <don@ohspite.net>
7593
7594 * keymap.c (Fdefine_key): Fix non-prefix key error message when
7595 last character M-[char] is translated to ESC [char] (bug#7541).
7596
5cc7f7af
KH
75972011-08-02 Kenichi Handa <handa@m17n.org>
7598
d0fffa3f 7599 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
7600
7601 * chartab.c (uniprop_table): Make it non-static.
7602
525d5e6e
EZ
76032011-08-01 Eli Zaretskii <eliz@gnu.org>
7604
7605 * xdisp.c (forward_to_next_line_start): Accept additional argument
7606 BIDI_IT_PREV, and store into it the state of the bidi iterator had
7607 on the newline.
7608 (reseat_at_next_visible_line_start): Use the bidi iterator state
7609 returned by forward_to_next_line_start to restore the state of
7610 it->bidi_it after backing up to previous newline. (Bug#9212)
7611
31011111
AS
76122011-07-30 Andreas Schwab <schwab@linux-m68k.org>
7613
7614 * regex.c (re_comp): Protoize.
7615 (re_exec): Fix return type.
7616 (regexec): Fix type of `ret'. (Bug#9203)
7617
476371c4
PE
76182011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7619
e5d76069
PE
7620 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
7621 This is needed if max-image-size is a floating-point number.
7622
9a79b20c
AS
76232011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7624
7625 * print.c (print_object): Print empty symbol as ##.
7626
7627 * lread.c (read1): Read ## as empty symbol.
7628
d8c2fa78
AA
76292011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7630
7631 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
7632 setting frame foreground color (Bug#9175).
7633 (x_set_background_color): Likewise.
7634
ffe57a7a
AA
7635 * nsmenu.m (-setText): Size tooltip dimensions precisely to
7636 contents (Bug#9176).
7637 (EmacsTooltip -init): Remove bezels and add shadows to
7638 tooltip windows.
7639
bf3492a5
AA
7640 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
7641 or scroll bar (Bug#8470).
7642
d55e9c53
AA
7643 * nsfont.m (nsfont_open): Remove assignment to voffset and
7644 unnecessary vars hshink, expand, hd, full_height, min_height.
7645 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
7646
7647 * nsterm.h (nsfont_info): Remove voffset field.
7648
d8c2fa78 76492011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
7650
7651 Implement strike-through and overline on NextStep (Bug#8863).
7652
7653 * nsfont.m (nsfont_open): Use underline position provided by font,
7654 instead of hard-coded value of 2.
7655 (nsfont_draw): Call ns_draw_text_decoration instead.
7656
7657 * nsterm.h: Add declaration for ns_draw_text_decoration.
7658
7659 * nsterm.m (ns_draw_text_decoration): New function for drawing
7660 underline, overline, and strike-through.
7661 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
7662 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 7663 accommodate underlining, etc.
4843aac3 7664
4cc60b9b
EZ
76652011-07-28 Eli Zaretskii <eliz@gnu.org>
7666
bc7ece87
EZ
7667 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
7668 default.
4cc60b9b 7669
476371c4
PE
76702011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7671
66606eea
PE
7672 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
7673 Without this fix, if a signal arrives just after memory fills up,
7674 'malloc' might be invoked reentrantly.
7675
476371c4
PE
7676 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
7677 In other words, assume that every image size is allowed, on non-X
7678 hosts. This assumption is probably wrong, but it lets Emacs compile.
7679
f3fcc40d
AS
76802011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7681
7682 * regex.c (re_iswctype): Convert return values to boolean.
7683
350c992f
EZ
76842011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
7685
7686 * xdisp.c (compute_display_string_pos): Don't use cached display
7687 string position if the buffer had its restriction changed.
7688 (Bug#9184)
7689
5266b4bb
PE
76902011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7691
7692 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7693
2573a837 76942011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 7695
41f55ccd 7696 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 7697
39e378da
PE
7698 * bidi.c: Integer size and overflow fixes.
7699 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
7700 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
7701 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7702 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
7703 (bidi_find_other_level_edge):
7704 Use ptrdiff_t instead of EMACS_INT where either will do.
7705 This works better on 32-bit hosts configured --with-wide-int.
7706 (bidi_cache_ensure_space): Check for size-calculation overflow.
7707 Use % rather than repeated addition, for better worst-case speed.
7708 Don't set bidi_cache_size until after xrealloc returns, because it
7709 might not return.
7710 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
7711 (bidi_cache_ensure_space): Also check that the bidi cache size
7712 does not exceed that of the largest Lisp string or buffer. See Eli
7713 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 7714
5e927815
PE
7715 * alloc.c (__malloc_size_t): Remove.
7716 All uses replaced by size_t. See Andreas Schwab's note
7717 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
7718
ca4aa935
PE
7719 * image.c: Improve checking for integer overflow.
7720 (check_image_size): Assume that f is nonnull, since
7721 it is always nonnull in practice. This is one less thing to
7722 worry about when checking for integer overflow later.
7723 (x_check_image_size): New function, which checks for integer
7724 overflow issues inside X.
7725 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
7726 This removes the need for a memory_full check.
7727 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
7728 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
7729 (xbm_read_bitmap_data): Change locals back to 'int', since
7730 their values must fit in 'int'.
7731 (xpm_load_image, png_load, tiff_load):
7732 Invoke x_create_x_image_and_pixmap earlier,
7733 to avoid much needless work if the image is too large.
7734 (tiff_load): Treat overly large images as if
7735 x_create_x_image_and_pixmap failed, not as malloc failures.
7736 (gs_load): Use x_check_image_size.
7737
5f8f9cc2
PE
7738 * gtkutil.c: Omit integer casts.
7739 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
7740 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
7741
5adf60bc
PE
7742 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
7743
c8907a93
PE
7744 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
7745 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
7746 would wrongly return t on a 64-bit host.
7747
e3c25c68
PE
7748 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
7749 The plain *_OVERFLOW macros run afoul of GCC bug 49705
7750 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
7751 and therefore cause GCC to emit a bogus diagnostic in some cases.
7752
3f791afe
PE
7753 * image.c: Integer signedness and overflow and related fixes.
7754 This is not an exhaustive set of fixes, but it's time to
7755 record what I've got.
7756 (lookup_pixel_color, check_image_size): Remove redundant decls.
7757 (check_image_size): Don't assume that arbitrary EMACS_INT values
7758 fit in 'int', or that arbitrary 'double' values fit in 'int'.
7759 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
7760 (tiff_load, imagemagick_load_image):
7761 Check for overflow in size calculations.
7762 (x_create_x_image_and_pixmap): Remove unnecessary test for
7763 xmalloc returning NULL; that can't happen.
7764 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
7765 (xpm_color_bucket): Use better integer hashing function.
7766 (xpm_cache_color): Don't possibly over-allocate memory.
7767 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
7768 (gif_memory_source):
7769 Use ptrdiff_t, not int or size_t, to record sizes.
7770 (png_load): Don't assume values greater than 2**31 fit in 'int'.
7771 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
7772 either works, as we prefer signed integers.
7773 (tiff_read_from_memory, tiff_write_from_memory):
7774 Return tsize_t, not size_t, since that's what the TIFF API wants.
7775 (tiff_read_from_memory): Don't fail simply because the read would
7776 go past EOF; instead, return a short read.
7777 (tiff_load): Omit no-longer-needed casts.
7778 (Fimagemagick_types): Don't assume size fits into 'int'.
7779
3cc5a532
PE
7780 Improve hashing quality when configured --with-wide-int.
7781 * fns.c (hash_string): New function, taken from sxhash_string.
7782 Do not discard information about ASCII character case; this
7783 discarding is no longer needed.
7784 (sxhash-string): Use it. Change sig to match it. Caller changed.
7785 * lisp.h: Declare it.
7786 * lread.c (hash_string): Remove, since we now use fns.c's version.
7787 The fns.c version returns a wider integer if --with-wide-int is
7788 specified, so this should help the quality of the hashing a bit.
7789
b312a492
PE
7790 * emacs.c: Integer overflow minor fix.
7791 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
7792 Define only if GNU_LINUX.
7793 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
7794
dfd153ae
PE
7795 * dispnew.c: Integer signedness and overflow fixes.
7796 Remove unnecessary forward decls, that were a maintenance hassle.
7797 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
7798 All uses changed.
7799 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
7800 (scrolling_window): Use ptrdiff_t, not int, for byte count.
7801 (prepare_desired_row, line_draw_cost):
7802 Use int, not unsigned, where either works.
7803 (save_current_matrix, restore_current_matrix):
7804 Use ptrdiff_t, not size_t, where either works.
7805 (init_display): Check for overflow more accurately, and without
7806 relying on undefined behavior.
7807
a81d11a3
PE
7808 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
7809 Remove, replacing with the new symbols in lisp.h. All uses changed.
7810 * fileio.c (make_temp_name):
7811 * filelock.c (lock_file_1, lock_file):
7812 * xdisp.c (message_dolog):
7813 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
7814 Use pMd etc. instead.
7815 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
7816 replacing the pWIDE etc. symbols removed from editfns.c.
7817
3300e6fd
PE
7818 * keyboard.h (num_input_events): Now uintmax_t.
7819 This is (very slightly) less likely to mess up due to wraparound.
7820 All uses changed.
7821
fd05c7e9
PE
7822 * buffer.c: Integer signedness fixes.
7823 (alloc_buffer_text, enlarge_buffer_text):
7824 Use ptrdiff_t rather than size_t when either will do, as we prefer
7825 signed integers.
7826
903fe15d
PE
7827 * alloc.c: Integer signedness and overflow fixes.
7828 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
7829 (__malloc_size_t): Default to size_t, not to int.
7830 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
7831 (Fgarbage_collect, mark_object_loop_halt, mark_object):
7832 Prefer ptrdiff_t to size_t when either would do, as we prefer
7833 signed integers.
7834 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
7835 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
7836 Now const. Initialize with values that are in range even if char
7837 is signed.
7838 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
7839 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
7840 These functions do the right thing with sizes > 2**32.
7841 (check_depth): Now ptrdiff_t, not int.
7842 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
7843 Adjust to new way of storing sizes. Check for size overflow bugs
7844 in rest of code.
7845 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
7846 slightly wrong anyway, as it missed one instance of
7847 XMALLOC_OVERRUN_CHECK_OVERHEAD.
7848 (refill_memory_reserve): Omit needless cast to size_t.
7849 (mark_object_loop_halt): Mark as externally visible.
7850
ac82cc6a
PE
7851 * xselect.c: Integer signedness and overflow fixes.
7852 (Fx_register_dnd_atom, x_handle_dnd_message):
7853 Use ptrdiff_t, not size_t, since we prefer signed.
7854 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
7855 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
7856 x_dnd_atoms_size and x_dnd_atoms_length.
7857
c2d1e36d
PE
7858 * doprnt.c: Prefer signed to unsigned when either works.
7859 * eval.c (verror):
7860 * doprnt.c (doprnt):
7861 * lisp.h (doprnt):
7862 * xdisp.c (vmessage):
7863 Use ptrdiff_t, not size_t, when using or implementing doprnt,
7864 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
7865 prefer signed arithmetic to avoid comparison confusion.
7866 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
7867 but is a bit tricky.
7868
0e926e56
PE
7869 Assume freestanding C89 headers, string.h, stdlib.h.
7870 * data.c, doprnt.c, floatfns.c, print.c:
7871 Include float.h unconditionally.
7872 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
7873 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
7874 * regex.c: Likewise for stddef.h, string.h.
7875 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
7876 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
7877 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
7878 (STDC_HEADERS): Remove obsolete defines.
7879 * sysdep.c: Include limits.h unconditionally.
7880
9cfdb3ec
PE
7881 Assume support for memcmp, memcpy, memmove, memset.
7882 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
7883 * regex.c (memcmp, memcpy):
7884 Remove; we assume C89 now.
7885
7886 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
7887 (__malloc_safe_bcopy): Remove; no longer needed.
7888
cf950e6b 7889 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
7890 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
7891 well either way, and we prefer signed to unsigned.
7892
dbf38e02
LMI
78932011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
7894
7895 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
7896 closes the connection while we're reading (bug#9182).
7897
d6f0886c 78982011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 7899
d6f0886c
JD
7900 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
7901 are specified (Bug#9168).
24e0f6b1 7902
2eb1f9e6
PE
79032011-07-25 Paul Eggert <eggert@cs.ucla.edu>
7904
7905 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
7906 Found by GCC static checking and --with-wide-int on a 32-bit host.
7907
22381272 79082011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
7909
7910 * xdisp.c (compute_display_string_pos): Fix logic of caching
7911 previous display string position. Initialize cached_prev_pos to
7912 -1. Fixes slow-down at the beginning of a buffer.
7913
f25e39b4
EZ
79142011-07-24 Eli Zaretskii <eliz@gnu.org>
7915
7916 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
7917 for attrs[LFACE_FONTSET_INDEX].
7918
04c4b52e
PE
79192011-07-23 Paul Eggert <eggert@cs.ucla.edu>
7920
7921 * xml.c (parse_region): Remove unused local
7922 that was recently introduced.
7923
c1734fbd
EZ
79242011-07-23 Eli Zaretskii <eliz@gnu.org>
7925
be18c5a5
EZ
7926 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
7927 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
7928
c1734fbd
EZ
7929 * xdisp.c (move_it_in_display_line_to): Record the best matching
7930 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
7931 exit if none of the characters scanned was an exact match.
7932 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
7933 when exact match is impossible due to invisible text, and the
7934 lines are truncated.
7935
a258d627
JD
79362011-07-23 Jan Djärv <jan.h.d@swipnet.se>
7937
7938 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
7939 for OSX >= 10.7.
7940
b6d5a689
EZ
79412011-07-22 Eli Zaretskii <eliz@gnu.org>
7942
0f74f785
EZ
7943 Fix a significant slow-down of cursor motion with C-n, C-p,
7944 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
7945 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 7946 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
7947 (next_element_from_buffer): Call compute_stop_pos_backwards to
7948 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
7949 base_level_stop.
7950 (reseat): Don't look for prev_stop, as that could mean a very long
7951 run.
7952 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
7953 <cached_disp_overlay_modiff>: Cache for last found display string
7954 position.
551918c1 7955 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
7956 about the same buffer in the same area of character positions, and
7957 the buffer wasn't changed since the time the display string
7958 position was cached.
551918c1 7959
b2d0c91a
EZ
79602011-07-22 Eli Zaretskii <eliz@gnu.org>
7961
7962 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
7963 is an integer, which is important for empty lines. (Bug#9149)
7964
043604ee
CY
79652011-07-22 Chong Yidong <cyd@stupidchicken.com>
7966
7967 * frame.c (Fmodify_frame_parameters): In tty case, update the
7968 default face if necessary (Bug#4238).
7969
da4adb04
CY
79702011-07-21 Chong Yidong <cyd@stupidchicken.com>
7971
7972 * editfns.c (Fstring_to_char): No need to explain what a character
7973 is in the docstring (Bug#6576).
7974
9abd0532
LMI
79752011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7976
7977 * xml.c (parse_region): Make sure we always return a tree.
7978
36881d16
HK
79792011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
7980
7981 * xml.c (parse_region): If a document contains only comments,
7982 return that, too.
7983
1e98674d
LMI
79842011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7985
7986 * xml.c (make_dom): Return comments, too.
7987
590bd467
PE
79882011-07-19 Paul Eggert <eggert@cs.ucla.edu>
7989
7990 Port to OpenBSD.
7991 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
7992 and the surrounding thread.
7993 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
7994 rather than fgets, and retry after EINTR. Otherwise, 'emacs
7995 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
7996 timer goes off.
7997 * s/openbsd.h (BROKEN_SIGIO): Define.
7998 * unexelf.c (unexec) [__OpenBSD__]:
7999 Don't update the .mdebug section of the Alpha COFF symbol table.
8000
f41628b2
LMI
80012011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
8002
8003 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
8004 (bug#8460).
8005
b59b67c5
PE
80062011-07-18 Paul Eggert <eggert@cs.ucla.edu>
8007
15e3a074
PE
8008 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
8009 This fixes some race conditions on the permissions of any newly
8010 created file.
8011
41bed37d
PE
8012 * alloc.c (valid_pointer_p): Use pipe, not open.
8013 This fixes some permissions issues when debugging.
8014
b59b67c5
PE
8015 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
8016 If fchown fails to set both uid and gid, try to set just gid,
8017 as that is sometimes allowed. Adjust the file's mode to eliminate
8018 setuid or setgid bits that are inappropriate if fchown fails.
8019
925a6be7
SM
80202011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
8021
8022 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
8023 to compare Lisp_Objects.
8024 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
8025 global_gnutls_log_level, don't mistake it for a Lisp_Object.
8026 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
8027
52968808
AS
80282011-07-17 Andreas Schwab <schwab@linux-m68k.org>
8029
0a6a104b
AS
8030 * lread.c (read_integer): Unread even EOF character.
8031 (read1): Likewise. Properly record start position of symbol.
8032
52968808
AS
8033 * lread.c (read1): Read `#:' as empty uninterned symbol if no
8034 symbol character follows.
8035
9e381cdd
PE
80362011-07-17 Paul Eggert <eggert@cs.ucla.edu>
8037
8038 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
8039 This works around a problem with the previous change to Fcopy_file.
8040 Recent glibc declares fchown with __attribute__((warn_unused_result)),
8041 and without this change, GCC might complain about discarding
8042 fchown's return value.
8043
b5641435
JB
80442011-07-16 Juanma Barranquero <lekktu@gmail.com>
8045
8046 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
8047
a8031457
PE
80482011-07-16 Paul Eggert <eggert@cs.ucla.edu>
8049
8050 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
8051
dd889327
LMI
80522011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
8053
750c33f7
LMI
8054 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
8055 it's used from the C level.
8056
dd889327
LMI
8057 * process.c: Use the same condition for POLL_FOR_INPUT in both
8058 keyboard.c and process.c (bug#1858).
8059
87e86684
LM
80602011-07-09 Lawrence Mitchell <wence@gmx.li>
8061
8062 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
8063 (Fgnutls_boot): Use it.
8064
64348f40
AS
80652011-07-15 Andreas Schwab <schwab@linux-m68k.org>
8066
8067 * doc.c (Fsubstitute_command_keys): Revert last change.
8068
1d698799
LMI
80692011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
8070
f863868c
LMI
8071 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
8072 quotes the next character, and doesn't affect other longer
8073 sequences (bug#8935).
8074
1d698799
LMI
8075 * lread.c (syms_of_lread): Clarify that is isn't only
8076 `eval-buffer' and `eval-defun' that's affected by
8077 `lexical-binding' (bug#8460).
8078
aa4b6df6
EZ
80792011-07-15 Eli Zaretskii <eliz@gnu.org>
8080
8081 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 8082 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 8083
5d856da6
PE
80842011-07-14 Paul Eggert <eggert@cs.ucla.edu>
8085
ad6042bb
PE
8086 Fix minor problems found by static checking.
8087 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
8088 (elsz): Now a signed constant, not a size_t var. We prefer signed
8089 types to unsigned, to avoid integer comparison confusion. Without
8090 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
8091 "cannot optimize loop, the loop counter may overflow", a symptom
8092 of the confusion.
f00bbb22 8093 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
8094 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
8095
6468f31c
LMI
80962011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8097
49080b10
LMI
8098 * search.c (Fre_search_backward): Mention `case-fold-search' in
8099 all the re_search_* functions (bug#8138).
8100
6468f31c
LMI
8101 * keyboard.c (Fopen_dribble_file): Document when the file is
8102 closed (bug#8056).
8103
c965adc5
EZ
81042011-07-14 Eli Zaretskii <eliz@gnu.org>
8105
df9733bf
EZ
8106 * bidi.c (bidi_dump_cached_states): Fix format of displaying
8107 bidi_cache_idx.
8108
0bb23927
EZ
8109 Support bidi reordering of display and overlay strings.
8110 * xdisp.c (compute_display_string_pos)
8111 (compute_display_string_end): Accept additional argument STRING.
8112 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
8113 (reseat_to_string): Initialize bidi_it->string.s and
8114 bidi_it->string.schars.
8115 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
8116 NULL (avoids a crash in bidi_paragraph_init).
8117 Initialize itb.string.lstring.
0bb23927
EZ
8118 (init_iterator): Call bidi_init_it only of a valid
8119 buffer position was specified. Initialize paragraph_embedding to
8120 L2R.
8121 (reseat_to_string): Initialize the bidi iterator.
8122 (display_string): If we need to ignore text properties of
8123 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
8124 original value of -1 will not work with bidi.)
8125 (compute_display_string_pos): First arg is now struct
8126 `text_pos *'; all callers changed. Support display properties on
8127 Lisp strings.
8128 (compute_display_string_end): Support display properties on Lisp
8129 strings.
8130 (init_iterator, reseat_1, reseat_to_string): Initialize the
8131 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
8132 when iterating on a string not from display properties).
640c8776
SM
8133 (compute_display_string_pos, compute_display_string_end):
8134 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
8135 arrow keys.
8136 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
8137 base_level_stop; instead, set base_level_stop to BEGV.
8138 Fixes crashes in vertical-motion.
0bb23927
EZ
8139 (next_element_from_buffer): Improve commentary for when
8140 the iterator is before prev_stop.
8141 (init_iterator): Initialize bidi_p from the default value of
8142 bidi-display-reordering, not from buffer-local value. Use the
8143 buffer-local value only if initializing for buffer iteration.
8144 (handle_invisible_prop): Support invisible properties on strings
8145 that are being bidi-reordered.
8146 (set_iterator_to_next): Support bidi reordering of C strings and
8147 Lisp strings.
8148 (next_element_from_string): Support bidi reordering of Lisp
8149 strings.
8150 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
8151 (display_string): Support display of R2L glyph rows.
8152 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
8153 (init_iterator): Don't initialize it->bidi_p for strings
8154 here.
8155 (reseat_to_string): Initialize it->bidi_p for strings here.
8156 (next_element_from_string, next_element_from_c_string)
8157 (next_element_from_buffer): Add xassert's for correspondence
8158 between IT's object being iterated and it->bidi_it.string
8159 structure.
8160 (face_before_or_after_it_pos): Support bidi iteration.
8161 (next_element_from_c_string): Handle the case of the first string
8162 character that is not the first one in the visual order.
8163 (get_visually_first_element): New function, refactored from common
8164 parts of next_element_from_buffer, next_element_from_string, and
8165 next_element_from_c_string.
8166 (tool_bar_lines_needed, redisplay_tool_bar)
8167 (display_menu_bar): Force left-to-right direction. Add a FIXME
8168 comment for making that be controlled by a user option.
8169 (push_it, pop_it): Save and restore the state of the
8170 bidi iterator. Save and restore the bidi_p flag.
8171 (pop_it): Iterate out of display property for string iteration as
8172 well.
8173 (iterate_out_of_display_property): Support iteration over strings.
8174 (handle_single_display_spec): Set up it->bidi_it for iteration
8175 over a display string, and call bidi_init_it.
8176 (handle_single_display_spec, next_overlay_string)
8177 (get_overlay_strings_1, push_display_prop): Set up the bidi
8178 iterator for displaying display or overlay strings.
8179 (forward_to_next_line_start): Don't use the shortcut if
8180 bidi-iterating.
8181 (back_to_previous_visible_line_start): If handle_display_prop
8182 pushed the iterator stack, restore the internal state of the bidi
8183 iterator by calling bidi_pop_it same number of times.
8184 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
8185 and we are bidi-iterating, don't decrement the iterator position;
8186 instead, set the first_elt flag in the bidi iterator, to produce
8187 the same effect.
8188 (reseat_1): Remove redundant setting of string_from_display_prop_p.
8189 (push_display_prop): xassert that we are iterating a buffer.
8190 (push_it, pop_it): Save and restore paragraph_embedding member.
8191 (handle_single_display_spec, next_overlay_string)
8192 (get_overlay_strings_1, reseat_1, reseat_to_string)
8193 (push_display_prop): Set up the `unibyte' member of bidi_it.string
8194 correctly. Don't assume unibyte strings are not bidi-reordered.
8195 (compute_display_string_pos)
8196 (compute_display_string_end): Fix handling the case of C string.
8197 (push_it, pop_it): Save and restore from_disp_prop_p.
8198 (handle_single_display_spec, push_display_prop): Set the
8199 from_disp_prop_p flag.
8200 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
8201 (pop_it): Call iterate_out_of_display_property only if we are
8202 popping after iteration over a string that came from a display
8203 property. Fix a typo in popping stretch info. Add an assertion
8204 for verifying that the iterator position is in sync with the bidi
8205 iterator.
8206 (handle_single_display_spec, get_overlay_strings_1)
8207 (push_display_prop): Fix initialization of paragraph direction for
8208 string when that of the parent object is not yet determined.
8209 (reseat_1): Call bidi_init_it to resync the bidi
8210 iterator with IT's position. (Bug#7616)
8211 (find_row_edges): If ROW->start.pos gives position
8212 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
8213 (handle_stop, back_to_previous_visible_line_start, reseat_1):
8214 Reset the from_disp_prop_p flag.
8215 (SAVE_IT, RESTORE_IT): New macros.
8216 (pos_visible_p, face_before_or_after_it_pos)
8217 (back_to_previous_visible_line_start)
8218 (move_it_in_display_line_to, move_it_in_display_line)
8219 (move_it_to, move_it_vertically_backward, move_it_by_lines)
8220 (try_scrolling, redisplay_window, display_line): Use them when
8221 saving a temporary copy of the iterator and restoring it back.
8222 (back_to_previous_visible_line_start, reseat_1)
8223 (init_iterator): Empty the bidi cache "stack".
8224 (move_it_in_display_line_to): If iterator ended up at
8225 EOL, but we never saw any buffer positions smaller than
8226 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
8227 motion in bidi-reordered lines.
8228 (move_it_in_display_line_to): Record prev_method and prev_pos
8229 immediately before the call to set_iterator_to_next. Fixes cursor
8230 motion in bidi-reordered lines with stretch glyphs and strings
8231 displayed in margins. (Bug#8133) (Bug#8867)
8232 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
8233 TO_CHARPOS.
640c8776
SM
8234 (pos_visible_p): Support positions in bidi-reordered lines.
8235 Save and restore bidi cache.
0bb23927
EZ
8236
8237 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
8238 (bidi_paragraph_info): Delete unused struct.
8239 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
8240 (bidi_cache_start): New variable.
8241 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
8242 to zero.
8243 (bidi_cache_fetch_state, bidi_cache_search)
8244 (bidi_cache_find_level_change, bidi_cache_iterator_state)
8245 (bidi_cache_find, bidi_peek_at_next_level)
8246 (bidi_level_of_next_char, bidi_find_other_level_edge)
8247 (bidi_move_to_visually_next): Compare cache index with
8248 bidi_cache_start rather than with zero.
8249 (bidi_fetch_char): Accept new argument STRING; all callers
8250 changed. Support iteration over a string. Support strings with
8251 display properties. Support unibyte strings. Fix the type of
8252 `len' according to what STRING_CHAR_AND_LENGTH expects.
8253 (bidi_paragraph_init, bidi_resolve_explicit_1)
8254 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
8255 (bidi_level_of_next_char, bidi_move_to_visually_next):
8256 Support iteration over a string.
0bb23927
EZ
8257 (bidi_set_sor_type, bidi_resolve_explicit_1)
8258 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
8259 can now be zero (for strings); special values 0 and -1 were
8260 changed to -1 and -2, respectively.
8261 (bidi_char_at_pos): New function.
8262 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
8263 Call it instead of FETCH_MULTIBYTE_CHAR.
8264 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
8265 initialized to valid values.
8266 (bidi_init_it): Don't initialize charpos and bytepos with invalid
8267 values.
8268 (bidi_level_of_next_char): Allow the sentinel "position" to pass
8269 the test for valid cached positions. Fix the logic for looking up
8270 the sentinel state in the cache. GCPRO the Lisp string we are
8271 iterating.
8272 (bidi_push_it, bidi_pop_it): New functions.
8273 (bidi_initialize): Initialize the bidi cache start stack pointer.
8274 (bidi_cache_ensure_space): New function, refactored from part of
8275 bidi_cache_iterator_state. Don't assume the required size is just
8276 one BIDI_CACHE_CHUNK away.
8277 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
8278 (bidi_count_bytes, bidi_char_at_pos): New functions.
8279 (bidi_cache_search): Don't assume bidi_cache_last_idx is
8280 always valid if bidi_cache_idx is valid.
8281 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
8282 is valid if it's going to be used.
8283 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
8284 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
8285 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8286 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
8287 (bidi_find_other_level_edge, bidi_cache_start_stack):
8288 All variables related to cache indices are now EMACS_INT.
c965adc5 8289
0bb23927
EZ
8290 * dispextern.h (struct bidi_string_data): New structure.
8291 (struct bidi_it): New member `string'. Make flag members be 1-bit
8292 fields, and put them last in the struct.
640c8776
SM
8293 (compute_display_string_pos, compute_display_string_end):
8294 Update prototypes.
0bb23927
EZ
8295 (bidi_push_it, bidi_pop_it): Add prototypes.
8296 (struct iterator_stack_entry): New members bidi_p,
8297 paragraph_embedding, and from_disp_prop_p.
8298 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
8299 (bidi_shelve_cache, bidi_unshelve_cache):
8300 Declare prototypes.
0bb23927
EZ
8301
8302 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
8303 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
8304 and vector-like objects.
8305
8306 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
8307 cache around display iteration.
8308
8309 * window.c (Fwindow_end, window_scroll_pixel_based)
8310 (displayed_window_lines, Frecenter): Save and restore the bidi
8311 cache around display iteration.
8312
3bbd2265
LMI
83132011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8314
8315 * editfns.c (Fdelete_region): Clarify the use of the named
8316 parameters (bug#6788).
8317
adc47434
MR
83182011-07-14 Martin Rudalics <rudalics@gmx.at>
8319
8320 * indent.c (Fvertical_motion): Set and restore w->pointm when
8321 saving and restoring the window's buffer (Bug#9006).
8322
837c31f8
LMI
83232011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
8324
8325 * editfns.c (Fstring_to_char): Clarify just what is returned
8326 (bug#6576). Text by Eli Zaretskii.
8327
ac389d0c
JB
83282011-07-13 Juanma Barranquero <lekktu@gmail.com>
8329
8330 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
8331
0be0ce47
EZ
83322011-07-13 Eli Zaretskii <eliz@gnu.org>
8333
8334 * buffer.c (mmap_find): Fix a typo.
8335
cd18e7e3
JB
83362011-07-13 Johan Bockgård <bojohan@gnu.org>
8337
8338 Fix execution of x selection hooks.
8339 * xselect.c (Qx_lost_selection_functions)
8340 (Qx_sent_selection_functions): New vars.
8341 (syms_of_xselect): DEFSYM them.
8342 (x_handle_selection_request): Pass Qx_sent_selection_functions
8343 rather than Vx_sent_selection_functions to Frun_hook_with_args.
8344 (x_handle_selection_clear,x_clear_frame_selections):
8345 Pass Qx_lost_selection_functions rather than
8346 Vx_lost_selection_functions to Frun_hook_with_args.
8347
47ea7f44
PE
83482011-07-13 Paul Eggert <eggert@cs.ucla.edu>
8349
ac389d0c 8350 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
8351 The old code sometimes used this field without initializing it.
8352
47ea7f44
PE
8353 * alloc.c (gc_sweep): Don't read past end of array.
8354 In theory, the old code could also have corrupted Emacs internals,
8355 though it'd be very unlikely.
8356
bc985c87
AS
83572011-07-12 Andreas Schwab <schwab@linux-m68k.org>
8358
8359 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 8360 argument. (Bug#4026)
bc985c87 8361
0cf34688
LMI
83622011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
8363
b3dadd76
LMI
8364 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
8365 key" (bug#4257).
8366
0cf34688
LMI
8367 * window.c (Fset_window_start): Doc fix (bug#4199).
8368 (Fset_window_hscroll): Ditto.
8369
270768cd
PE
83702011-07-12 Paul Eggert <eggert@cs.ucla.edu>
8371
077e3dda 8372 Fix minor new problems caught by GCC 4.6.1.
270768cd 8373 * term.c (init_tty): Remove unused local.
490011a6 8374 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 8375 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 8376 not used otherwise.
270768cd 8377
b1f58454
CY
83782011-07-12 Chong Yidong <cyd@stupidchicken.com>
8379
8380 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
8381
22b9578d
LMI
83822011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
8383
6e70ab07
LMI
8384 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
8385 are the mini-buffer and the echo area (bug#3320).
8386
22b9578d
LMI
8387 * term.c (init_tty): Remove support for supdup, c10 and perq
8388 terminals, which are no longer supported (bug#1482).
8389
8974cc9f
JB
83902011-07-10 Johan Bockgård <bojohan@gnu.org>
8391
8392 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
8393
a560d974
JD
83942011-07-10 Jan Djärv <jan.h.d@swipnet.se>
8395
8396 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
8397 for non-popups (Bug#3642).
8398
1dae0f0a
AS
83992011-07-10 Andreas Schwab <schwab@linux-m68k.org>
8400
268c2c36 8401 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 8402 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
8403 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
8404 * cm.c (losecursor): Likewise.
1dae0f0a
AS
8405 * data.c (fmod): Likewise.
8406 * dispnew.c (swap_glyphs_in_rows): Likewise.
8407 * emacs.c (memory_warning_signal): Likewise.
8408 * floatfns.c (float_error): Likewise.
8409 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
8410 (otf_open, font_otf_capability, generate_otf_features)
8411 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
8412 Likewise.
8413 * image.c (pbm_read_file): Likewise.
8414 * indent.c (string_display_width): Likewise.
8415 * intervals.c (check_for_interval, search_for_interval)
8416 (inc_interval_count, count_intervals, root_interval)
8417 (adjust_intervals_for_insertion, make_new_interval): Likewise.
8418 * lread.c (defalias): Likewise.
268c2c36 8419 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
8420 * regex.c (set_image_of_range_1, set_image_of_range)
8421 (regex_grow_registers): Likewise.
8422 * sysdep.c (strerror): Likewise.
8423 * termcap.c (valid_filename_p, tprint, main): Likewise.
8424 * tparam.c (main): Likewise.
8425 * unexhp9k800.c (run_time_remap, save_data_space)
8426 (update_file_ptrs, read_header, write_header, calculate_checksum)
8427 (copy_file, copy_rest, display_header): Likewise.
8428 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
8429 Likewise.
8430 * xdisp.c (check_it): Likewise.
8431 * xfaces.c (register_color, unregister_color, unregister_colors):
8432 Likewise.
8433 * xfns.c (print_fontset_result): Likewise.
8434 * xrdb.c (member, fatal, main): Likewise.
8435
99033785
PE
84362011-07-10 Paul Eggert <eggert@cs.ucla.edu>
8437
8438 Fix minor problems found by static checking (Bug#9031).
8439 * chartab.c (char_table_set_range, map_sub_char_table):
8440 Remove unused locals.
8441 (uniprop_table): Now static.
8442 * composite.c (_work_char): Remove unused static var.
8443
9cb2ac56
JB
84442011-07-09 Juanma Barranquero <lekktu@gmail.com>
8445
8446 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
8447
f25661f0
JD
84482011-07-09 Jan Djärv <jan.h.d@swipnet.se>
8449
8450 * gtkutil.c (qttip_cb): Remove code without function.
8451
8278c4fe
EZ
84522011-07-09 Eli Zaretskii <eliz@gnu.org>
8453
8454 * w32.c (pthread_sigmask): New stub.
8455
1692ae2d 84562011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 8457
8a6ebd58 8458 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
8459 sigprocmask is portable only for single-threaded applications, and
8460 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
8461 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
8462 (LIBES): Use it.
8463 * callproc.c (Fcall_process):
8464 * process.c (create_process):
8465 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
8466 Use pthread_sigmask, not sigprocmask.
123403e4 8467
1b854618
JD
84682011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8469
8470 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
8471 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
8472 wrong (Bug#8591).
8473
3fe4b549
JD
84742011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8475
0ce7e563
JD
8476 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
8477 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
8478 (xg_hide_tooltip): Fix comment.
8479
3fe4b549
JD
8480 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
8481 in registerServicesMenuSendTypes.
8482 (validRequestorForSendType): Don't check ns_return_types.
8483
8484 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
8485 ns_return_type.
8486
5df75e47
JR
84872011-07-08 Jason Rumney <jasonr@gnu.org>
8488
22610910
JR
8489 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
8490 SH_SHOW for hidden windows (Bug#5482).
8491
5df75e47
JR
8492 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
8493 frame struct members of non-existent frames (Bug#6284).
8494
699c10bd
JD
84952011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8496
4393663b
JD
8497 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
8498 variable firstTime not needed on OSX >= 10.6.
8499 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
8500 >= 10.5. Use setKnobProportion, setDoubleValue.
8501
8502 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
8503 (MAC_OS_X_VERSION_10_5): Define if not defined.
8504 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
8505 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
8506 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
8507
8508 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 8509 cString and lossyCString on OSX >= 10.4.
4393663b 8510
58179cce 8511 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
8512 sizeToFit on OSX >= 10.2.
8513
8514 * nsimage.m (allocInitFromFile): Don't use deprecated method
8515 bestRepresentationForDevice on OSX >= 10.6.
8516
8517 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
8518 to avoid warning.
8519
8520 * emacs.c: Declare unexec_init_emacs_zone.
8521
a63e0781
JD
8522 * nsgui.h: Fix compiler warning about gnulib redefining verify.
8523
699c10bd
JD
8524 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
8525
8526 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
8527 on svcsMenu (Bug#8842).
8528
8529 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
8530 ns_return_types.
8531 (Fns_list_services): Just return Qnil on 10.6, code not working there.
8532
8533 * nsterm.m (QUTF8_STRING): Declare.
8534 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
8535 (validRequestorForSendType): Return type is (id).
8536 Change indexOfObjectIdenticalTo to indexOfObject.
8537 Check if we have local selection before returning self (Bug#8842).
8538 (writeSelectionToPasteboard): Put local selection into paste board
8539 if we have a local selection (Bug#8842).
8540 (syms_of_nsterm): DEFSYM QUTF8_STRING.
8541
8542 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
8543 (ns_get_local_selection): Declare.
8544
54e10184
LMI
85452011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
8546
9888ff71
LMI
8547 * keymap.c (describe_map_tree): Don't insert a double newline at
8548 the end of the buffer (bug#1169) and return whether we inserted
8549 something.
8550
54e10184
LMI
8551 * callint.c (Fcall_interactively): Change "reading args" to
8552 "providing args" to try to clarify what it does (bug#1010).
8553
15fa4783
KH
85542011-07-07 Kenichi Handa <handa@m17n.org>
8555
8556 * composite.c (composition_compute_stop_pos): Ignore a static
8557 composition starting before CHARPOS (Bug#8915).
8558
8559 * xdisp.c (handle_composition_prop): Likewise.
8560
a8815b00
EZ
85612011-07-07 Eli Zaretskii <eliz@gnu.org>
8562
8563 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
8564 (Bug#9015)
8565
ef7b981d 85662011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
8567
8568 * character.h (unicode_category_t): New enum type.
8569
8570 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
8571 (Qchar_code_property_table): New variable.
8572 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
8573 (UNIPROP_COMPRESSED_FORM_P): New macros.
8574 (char_table_ascii): Uncompress the compressed values.
8575 (sub_char_table_ref): New arg is_uniprop. Callers changed.
8576 Uncompress the compressed values.
ac389d0c 8577 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
8578 (char_table_ref_and_range): Uncompress the compressed values.
8579 (sub_char_table_set): New arg is_uniprop. Callers changed.
8580 Uncompress the compressed values.
8581 (sub_char_table_set_range): Args changed. Callers changed.
8582 (char_table_set_range): Adjuted for the above change.
8583 (map_sub_char_table): Delete args default_val and parent. Add arg
8584 top. Give decoded values to a Lisp function.
640c8776 8585 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
8586 values to a Lisp function. Gcpro more variables.
8587 (uniprop_table_uncompress)
8588 (uniprop_decode_value_run_length): New functions.
8589 (uniprop_decoder, uniprop_decoder_count): New variables.
8590 (uniprop_get_decoder, uniprop_encode_value_character)
8591 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
8592 New functions.
8593 (uniprop_encoder, uniprop_encoder_count): New variables.
8594 (uniprop_get_encoder, uniprop_table)
8595 (Funicode_property_table_internal, Fget_unicode_property_internal)
8596 (Fput_unicode_property_internal): New functions.
8597 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
8598 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 8599 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
8600 char-code-property-alist.
8601
640c8776 8602 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
8603 Vunicode_category_table.
8604
640c8776 8605 * font.c (font_range): Adjust for the change of
c805dec0
KH
8606 Vunicode_category_table.
8607
76b397fb
DN
86082011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
8609
8610 * m/iris4d.h: Remove file, move contents ...
8611 * s/irix6-5.h: ... here.
8612
22b4128e
PE
86132011-07-06 Paul Eggert <eggert@cs.ucla.edu>
8614
8615 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
8616 * alloc.c (mark_buffer):
8617 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
8618 (clone_per_buffer_values): Don't assume that
22b4128e
PE
8619 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
8620 This isn't true in general, and it's particularly not true
8621 if Emacs is configured with --with-wide-int.
8622 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
8623 New macros, used in the buffer.c change.
8624
869795d6
JD
86252011-07-05 Jan Djärv <jan.h.d@swipnet.se>
8626
8627 * xsettings.c: Use both GConf and GSettings if both are available.
8628 (store_config_changed_event): Add comment.
8629 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
8630 (store_tool_bar_style_changed): New functions.
5e617bc2 8631 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
8632 (struct xsettings): Move font inside HAVE_XFT.
8633 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 8634 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 8635 Move inside HAVE_XFT.
640c8776 8636 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
8637 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
8638 also.
8639 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 8640 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 8641 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
8642 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
8643 (parse_settings): Move check for font inside HAVE_XFT.
8644 (read_settings, apply_xft_settings): Add comment.
8645 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
8646 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
8647 call store_font_name_changed.
8648 (xft_settings_event): Add comment.
8649 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
8650 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
8651 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
8652 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
8653 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
8654 (xsettings_get_system_font, xsettings_get_system_normal_font):
8655 Add comment.
869795d6 8656
d8ed26bd
PE
86572011-07-05 Paul Eggert <eggert@cs.ucla.edu>
8658
8659 Random fixes. E.g., (random) never returned negative values.
8660 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
8661 subseconds part to the entropy, as that's a bit more random.
8662 Prefer signed to unsigned, since the signedness doesn't matter and
8663 in general we prefer signed. When given a limit, use a
8664 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
8665 latter isn't right if USE_2_TAGS_FOR_INTS.
8666 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
8667 not 0..VALMASK. Don't discard "excess" bits that random () returns.
8668
cabf1cac
SM
86692011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
8670
8671 * textprop.c (text_property_stickiness):
8672 Obey Vtext_property_default_nonsticky.
8673 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
8674 * w32fns.c (syms_of_w32fns):
8675 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
8676
6e9b2be9
PE
86772011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8678
8679 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
8680 This is more efficient than Ffile_directory_p and avoids a minor race.
8681
90186c68
LMI
86822011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
8683
7c301272
LMI
8684 * buffer.c (Foverlay_put): Say what the return value is
8685 (bug#7835).
8686
c4f2d8d4
LMI
8687 * fileio.c (barf_or_query_if_file_exists): Check first if the file
8688 is a directory before asking whether to use the file name
8689 (bug#7564).
ad637907
LMI
8690 (barf_or_query_if_file_exists): Make the "File is a directory"
8691 error be more correct.
c4f2d8d4 8692
90186c68
LMI
8693 * fns.c (Frequire): Remove the mention of the .gz files, since
8694 that's installation-specific, but keep the mention of
8695 `get-load-suffixes'.
8696
da64016e
PE
86972011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8698
8699 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
8700 Report string overflow if the output is too long.
8701
7d47b580
JB
87022011-07-04 Juanma Barranquero <lekktu@gmail.com>
8703
a555cb87
JB
8704 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
8705 (syms_of_gnutls): Remove duplicate DEFSYM for
8706 Qgnutls_bootprop_verify_hostname_error, an error for
8707 Qgnutls_bootprop_verify_error (which is no longer used).
8708
7d47b580
JB
8709 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
8710 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
8711 Also (re)move comments that are misplaced or no longer relevant.
8712
1e49bfab
LMI
87132011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8714
8715 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
8716
1485f4c0
CY
87172011-07-03 Chong Yidong <cyd@stupidchicken.com>
8718
8719 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
8720 and background color parameters if they have been changed.
8721
a9ab721e
LMI
87222011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8723
8724 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
8725
cf7cff57
PE
87262011-07-03 Paul Eggert <eggert@cs.ucla.edu>
8727
2e13213d
PE
8728 * xsettings.c (SYSTEM_FONT): Define only when used.
8729 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
8730
cf7cff57
PE
8731 * keymap.c (access_keymap_1): Now static.
8732
7a8e04f7
CY
87332011-07-02 Chong Yidong <cyd@stupidchicken.com>
8734
8735 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
8736 leave any prefix arg for the up event (Bug#1586).
8737
61352f62
LMI
87382011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
8739
69bb1ef7
LMI
8740 * lread.c (syms_of_lread): Mention single symbols defined by
8741 `defvar' or `defconst' (bug#7154).
8742
61352f62 8743 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 8744 (Frequire): Mention get-load-suffixes.
61352f62 8745
28545e04
MR
87462011-07-02 Martin Rudalics <rudalics@gmx.at>
8747
8748 * window.h (window): Remove clone_number slot.
8749 * window.c (Fwindow_clone_number, Fset_window_clone_number):
8750 Remove.
8751 (make_parent_window, make_window, saved_window)
8752 (Fset_window_configuration, save_window_save): Don't deal with
8753 clone numbers.
8754 * buffer.c (Qclone_number): Remove declaration.
8755 (sort_overlays, overlay_strings): Don't deal with clone numbers.
8756
3349e122
SM
87572011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
8758
8759 Add multiple inheritance to keymaps.
8760 * keymap.c (Fmake_composed_keymap): New function.
8761 (Fset_keymap_parent): Simplify.
8762 (fix_submap_inheritance): Remove.
8763 (access_keymap_1): New function extracted from access_keymap to handle
8764 embedded parents and handle lists of maps.
8765 (access_keymap): Use it.
8766 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
8767 (Fcopy_keymap): Handle embedded parents.
8768 (Fcommand_remapping, define_as_prefix): Simplify.
8769 (Fkey_binding): Simplify.
8770 (syms_of_keymap): Move minibuffer-local-completion-map,
8771 minibuffer-local-filename-completion-map,
8772 minibuffer-local-must-match-map, and
8773 minibuffer-local-filename-must-match-map to Elisp.
8774 (syms_of_keymap): Defsubr make-composed-keymap.
8775 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
8776 (parse_menu_item): Trivial simplification.
8777
3279eb87
GM
87782011-07-01 Glenn Morris <rgm@gnu.org>
8779
8780 * Makefile.in (SETTINGS_LIBS): Fix typo.
8781
4550efdf
KI
87822011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
8783
8784 * coding.c (Fencode_coding_string): Record the last coding system
8785 used, as the function doc string says (bug#8738).
8786
0949d2b6
JD
87872011-07-01 Jan Djärv <jan.h.d@swipnet.se>
8788
8789 * xsettings.c (store_monospaced_changed): Take new font as arg and
8790 check for change against current_mono_font.
8791 (EMACS_TYPE_SETTINGS): Remove this and related defines.
8792 (emacs_settings_constructor, emacs_settings_get_property)
8793 (emacs_settings_set_property, emacs_settings_class_init)
8794 (emacs_settings_init, gsettings_obj): Remove.
8795 (something_changedCB): New function for HAVE_GSETTINGS.
8796 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
8797 with value as argument.
8798 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
8799 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 8800 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
8801 "changed".
8802
8803 * xgselect.c: Add defined (HAVE_GSETTINGS).
8804 (xgselect_initialize): Ditto.
8805
8806 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
8807 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
8808 xg_select.
8809
bbc6b304
PE
88102011-07-01 Paul Eggert <eggert@cs.ucla.edu>
8811
8812 * eval.c (struct backtrace): Simplify and port the data structure.
8813 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
8814 signed bit field, as this assumption is not portable and it makes
8815 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
8816 "char debug_on_exit : 1" as this is not portable either; instead,
8817 use the portable "unsigned int debug_on_exit : 1". Remove unused
8818 member evalargs. Remove obsolete comments about cc bombing out.
8819
9851bfc5
JD
88202011-06-30 Jan Djärv <jan.h.d@swipnet.se>
8821
51bb811f 8822 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
8823 Let HAVE_GSETTINGS override HAVE_GCONF.
8824 (store_monospaced_changed): New function.
8825 (EMACS_SETTINGS): A new type derived from GObject to handle
8826 GSettings notifications.
8827 (emacs_settings_constructor, emacs_settings_get_property)
8828 (emacs_settings_set_property, emacs_settings_class_init):
8829 New functions.
8830 (gsettings_client, gsettings_obj): New variables.
8831 (GSETTINGS_SCHEMA): New define.
8832 (something_changedCB): Call store_monospaced_changed.
8833 (init_gsettings): New function.
8834 (xsettings_initialize): Call init_gsettings.
8835 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
8836 to NULL.
8837
640c8776 8838 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
8839 GCONF_CFLAGS/LIBS.
8840
5386012d
MR
88412011-06-29 Martin Rudalics <rudalics@gmx.at>
8842
8843 * window.c (resize_root_window, grow_mini_window)
8844 (shrink_mini_window): Rename Qresize_root_window to
8845 Qwindow_resize_root_window and Qresize_root_window_vertically to
8846 Qwindow_resize_root_window_vertically.
8847
f13e0b08
PE
88482011-06-28 Paul Eggert <eggert@cs.ucla.edu>
8849
8850 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
8851
94515237
JB
88522011-06-27 Juanma Barranquero <lekktu@gmail.com>
8853
8854 * makefile.w32-in: Redesign dependencies so they reflect more
8855 clearly which files are directly included by each source file,
8856 and not through other includes.
8857
e43b6e43
MR
88582011-06-27 Martin Rudalics <rudalics@gmx.at>
8859
8860 * buffer.c (Qclone_number): Declare static and DEFSYM it.
8861 (sort_overlays, overlay_strings): When an overlay's clone number
8862 matches the window's clone number process the overlay even if
8863 the overlay's window property doesn't match the current window.
8864
d68443dc
MR
8865 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
8866 (Fwindow_hchild): Rename to Fwindow_left_child.
8867 (Fwindow_next): Rename to Fwindow_next_sibling.
8868 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
8869 (resize_window_check): Rename to window_resize_check.
8870 (resize_window_apply): Rename to window_resize_apply.
8871 (Fresize_window_apply): Rename to Fwindow_resize_apply.
8872 (Fdelete_other_windows_internal, resize_frame_windows)
8873 (Fsplit_window_internal, Fdelete_window_internal)
8874 (grow_mini_window, shrink_mini_window)
8875 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 8876
c7e73be5
JD
88772011-06-26 Jan Djärv <jan.h.d@swipnet.se>
8878
8879 * emacsgtkfixed.h: State that this is only used with Gtk+3.
8880 (emacs_fixed_set_min_size): Remove.
8881 (emacs_fixed_new): Take frame as argument.
8882
8883 * emacsgtkfixed.c: State that this is only used with Gtk+3.
8884 (_EmacsFixedPrivate): Remove minwidth/height.
8885 Add struct frame *f.
8886 (emacs_fixed_init): Initialize priv->f.
8887 (get_parent_class, emacs_fixed_set_min_size): Remove.
8888 (emacs_fixed_new): Set priv->f to argument.
8889 (emacs_fixed_get_preferred_width)
8890 (emacs_fixed_get_preferred_height): Use min_width/height from
8891 frames size_hint to set minimum and natural (Bug#8919).
8892 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
8893 and use min_width/height from frames size_hint to set
8894 min_width/height (Bug#8919).
8895
8896 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
8897 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
8898 Fix indentation.
c7e73be5 8899
cf99dcf8
EZ
89002011-06-26 Eli Zaretskii <eliz@gnu.org>
8901
8902 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
8903 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
8904 called at ZV.
8905
029529ac
CY
89062011-06-26 Chong Yidong <cyd@stupidchicken.com>
8907
8908 * process.c (wait_reading_process_output): Bypass select if
8909 waiting for a cell while ignoring keyboard input, and input is
8910 pending. Suggested by Jan Djärv (Bug#8869).
8911
7a7ef429
PE
89122011-06-25 Paul Eggert <eggert@cs.ucla.edu>
8913
8914 Use gnulib's dup2 module instead of rolling our own.
8915 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
8916
11fdef7d 89172011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
8918
8919 * dispnew.c (scrolling_window): Before scrolling, turn off a
8920 mouse-highlight in the window being scrolled.
8921
cd3520a4
JB
89222011-06-24 Juanma Barranquero <lekktu@gmail.com>
8923
8924 Move DEFSYM to lisp.h and use everywhere.
8925
8926 * character.h (DEFSYM): Move declaration...
8927 * lisp.h (DEFSYM): ...here.
8928
8929 * gnutls.c:
8930 * minibuf.c:
8931 * w32menu.c:
8932 * w32proc.c:
8933 * w32select.c: Don't include character.h.
8934
8935 * alloc.c (syms_of_alloc):
8936 * buffer.c (syms_of_buffer):
8937 * bytecode.c (syms_of_bytecode):
8938 * callint.c (syms_of_callint):
8939 * casefiddle.c (syms_of_casefiddle):
8940 * casetab.c (init_casetab_once):
8941 * category.c (init_category_once, syms_of_category):
8942 * ccl.c (syms_of_ccl):
8943 * cmds.c (syms_of_cmds):
8944 * composite.c (syms_of_composite):
8945 * dbusbind.c (syms_of_dbusbind):
8946 * dired.c (syms_of_dired):
8947 * dispnew.c (syms_of_display):
8948 * doc.c (syms_of_doc):
8949 * editfns.c (syms_of_editfns):
8950 * emacs.c (syms_of_emacs):
8951 * eval.c (syms_of_eval):
8952 * fileio.c (syms_of_fileio):
8953 * fns.c (syms_of_fns):
8954 * frame.c (syms_of_frame):
8955 * fringe.c (syms_of_fringe):
8956 * insdel.c (syms_of_insdel):
8957 * keymap.c (syms_of_keymap):
8958 * lread.c (init_obarray, syms_of_lread):
8959 * macros.c (syms_of_macros):
8960 * msdos.c (syms_of_msdos):
8961 * print.c (syms_of_print):
8962 * process.c (syms_of_process):
8963 * search.c (syms_of_search):
8964 * sound.c (syms_of_sound):
8965 * syntax.c (init_syntax_once, syms_of_syntax):
8966 * terminal.c (syms_of_terminal):
8967 * textprop.c (syms_of_textprop):
8968 * undo.c (syms_of_undo):
8969 * w32.c (globals_of_w32):
8970 * window.c (syms_of_window):
8971 * xdisp.c (syms_of_xdisp):
8972 * xfaces.c (syms_of_xfaces):
8973 * xfns.c (syms_of_xfns):
8974 * xmenu.c (syms_of_xmenu):
8975 * xsettings.c (syms_of_xsettings):
8976 * xterm.c (syms_of_xterm): Use DEFSYM.
8977
4228cf16
TZ
89782011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
8979
cd3520a4 8980 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 8981
7fcccf1e
PE
89822011-06-23 Paul Eggert <eggert@cs.ucla.edu>
8983
7efb4e0e
PE
8984 Integer and buffer overflow fixes (Bug#8873).
8985
ff5844ad
PE
8986 * print.c (printchar, strout): Check for string overflow.
8987 (PRINTPREPARE, printchar, strout):
8988 Don't set size unless allocation succeeds.
8989
90532f02
PE
8990 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
8991 for sizes. Check for string overflow more accurately.
8992 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
8993
6d84508d
PE
8994 * macros.c: Integer and buffer overflow fixes.
8995 * keyboard.h (struct keyboard.kbd_macro_bufsize):
8996 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
8997 Use ptrdiff_t, not int, for sizes.
8998 Don't increment bufsize until after realloc succeeds.
8999 Check for size-calculation overflow.
9000 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
9001
437b2cb4
PE
9002 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
9003
8b9ac8b4
PE
9004 * lread.c: Integer overflow fixes.
9005 (read_integer): Radix is now EMACS_INT, not int,
9006 to improve quality of diagnostics for out-of-range radices.
9007 Calculate buffer size correctly for out-of-range radices.
9008 (read1): Check for integer overflow in radices, and in
9009 read-circle numbers.
82cb60d3
PE
9010 (read_escape): Avoid int overflow.
9011 (Fload, openp, read_buffer_size, read1)
9012 (substitute_object_recurse, read_vector, read_list, map_obarray):
9013 Use ptrdiff_t, not int, for sizes.
9014 (read1): Use EMACS_INT, not int, for sizes.
20270765 9015 Check for size overflow.
8b9ac8b4 9016
7fcccf1e
PE
9017 * image.c (cache_image): Check for size arithmetic overflow.
9018
bfbbd7e7
PE
9019 * lread.c: Integer overflow issues.
9020 (saved_doc_string_size, saved_doc_string_length)
9021 (prev_saved_doc_string_size, prev_saved_doc_string_length):
9022 Now ptrdiff_t, not int.
9023 (read1): Don't assume doc string length fits in int. Check for
9024 out-of-range doc string lengths.
9025 (read_list): Don't assume file position fits in int.
39019e54 9026 (read_escape): Check for hex character overflow.
bfbbd7e7 9027
4e323265
LL
90282011-06-22 Leo Liu <sdl.web@gmail.com>
9029
9030 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
9031 Move to minibuffer.el.
9032
85fece3e
PE
90332011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9034
20b84ce9 9035 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
9036 The following patches are for when GLYPH_DEBUG && !XASSERT.
9037 * dispextern.h (trace_redisplay_p, dump_glyph_string):
9038 * dispnew.c (flush_stdout):
9039 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
9040 Mark as externally visible.
9041 * dispnew.c (check_window_matrix_pointers): Now static.
9042 * dispnew.c (window_to_frame_vpos):
9043 * xfns.c (unwind_create_frame):
9044 * xterm.c (x_check_font): Remove unused local.
9045 * scroll.c (CHECK_BOUNDS):
9046 * xfaces.c (cache_fache): Rename local to avoid shadowing.
9047 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
9048 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
9049 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
9050 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
9051 Now static.
9052 (debug_method_add): Use va_list and vsprintf rather than relying
9053 on undefined behavior with wrong number of arguments.
9054 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
9055 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
9056 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
9057 since we're not interested in debugging glyphs with old libraries.
9058 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
9059 GCC 4.6.0's static checking.
9060
0766b489
PE
90612011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9062
31fd4b32
PE
9063 Integer overflow and signedness fixes (Bug#8873).
9064 A few related buffer overrun fixes, too.
9065
b79e8648
PE
9066 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
9067
0766b489
PE
9068 * dispextern.h (struct face.stipple):
9069 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
9070 (x_bitmap_mask, x_allocate_bitmap_record)
9071 (x_create_bitmap_from_data, x_create_bitmap_from_file)
9072 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
9073 (x_create_bitmap_from_xpm_data):
9074 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
9075 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
9076 (.bitmaps_last):
9077 * xfaces.c (load_pixmap):
9078 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
9079 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
9080 (.bitmaps_last, struct x_output.icon_bitmap):
9081 Use ptrdiff_t, not int, for bitmap indexes.
9082 (x_allocate_bitmap_record): Check for size overflow.
9083 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
9084
b081724f
PE
9085 Use ptrdiff_t, not int, for overlay counts.
9086 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
9087 * editfns.c (overlays_around, get_pos_property):
9088 * textprop.c (get_char_property_and_overlay):
9089 * xdisp.c (next_overlay_change, note_mouse_highlight):
9090 * xfaces.c (face_at_buffer_position):
21514da7
PE
9091 * buffer.c (OVERLAY_COUNT_MAX): New macro.
9092 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
9093 (Fnext_overlay_change, Fprevious_overlay_change)
9094 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 9095 Use ptrdiff_t, not int, for sizes.
21514da7 9096 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 9097
3de73e5e
PE
9098 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
9099
2606c57b
PE
9100 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
9101 (x_session_initialize): Do not assume string length fits in int.
9102
aaafe47a
PE
9103 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
9104 This is unlikely, but can occur if DPI is outlandish.
9105
2674ddc8 9106 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
9107 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
9108
28154962
PE
9109 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
9110 * xrdb.c (magic_file_p, search_magic_path):
9111 Omit last arg SUFFIX; it was always 0. All callers changed.
9112 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
9113
7de51af5
PE
9114 * xfont.c (xfont_match): Avoid need for strlen.
9115
25ed6cc3
PE
9116 * xfns.c: Don't assume strlen fits in int.
9117 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
9118
4eab31dd
PE
9119 * xdisp.c (message_log_check_duplicate): Return intmax_t,
9120 not unsigned long, as we prefer signed integers. All callers changed.
9121 Detect integer overflow in repeat count.
9122 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 9123 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 9124
171e2a58
PE
9125 * termcap.c: Don't assume sizes fit in int and never overflow.
9126 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
9127 (gobble_line): Check for size-calculation overflow.
9128
ad39faca 9129 * minibuf.c (Fread_buffer):
6e5bb2dc 9130 * lread.c (intern, intern_c_string):
74ca2eb3
PE
9131 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
9132 Don't assume string length fits in int.
9133
52c61c22 9134 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
9135 * gtkutil.c (style_changed_cb): Avoid need for strlen.
9136
b5b8c9e5
PE
9137 * font.c: Don't assume string length fits in int.
9138 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
9139 Use ptrdiff_t, not int.
ccd6111c
PE
9140 (font_intern_prop): Don't assume string length fits in int.
9141 Don't assume integer property fits in fixnum.
9142 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 9143
882f0d81 9144 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 9145 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
9146 Reformulate so as not to need the command string.
9147 Invoke gzip -cd rather than gunzip, as it's more portable.
9148 (lock_info_type, lock_file_1, lock_file):
9149 Don't assume pid_t and time_t fit in unsigned long.
9150 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
9151 (current_lock_owner): Prefer signed type for sizes.
9152 Use memcpy, not strncpy, where memcpy is what is really wanted.
9153 Don't assume (via atoi) that time_t and pid_t fit in int.
9154 Check for time_t and/or pid_t out of range, e.g., via a network share.
9155 Don't alloca where an auto var works fine.
9156
93f4cf88
PE
9157 * fileio.c: Fix some integer overflow issues.
9158 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
9159 Don't assume string length fits in int.
9160 (directory_file_name): Don't assume string length fits in long.
9161 (make_temp_name): Don't assume pid fits in int, or that its print
9162 length is less than 20.
9163
f3e92b69
PE
9164 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
9165
1bfdaf10
PE
9166 * coding.c (make_subsidiaries): Don't assume string length fits in int.
9167
35016e9a
PE
9168 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
9169
3d1e65a1
PE
9170 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
9171 We prefer signed integers, even for size calculations.
9172
0b963a93
PE
9173 * emacs.c: Don't assume string length fits in 'int'.
9174 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
9175 (main): Don't invoke strlen when not needed.
9176
573f4b54
PE
9177 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
9178 (XD_DEBUG_MESSAGE): Don't waste a byte.
9179
989f33ba
PE
9180 * callproc.c (getenv_internal_1, getenv_internal)
9181 (Fgetenv_internal):
965d34eb
PE
9182 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
9183
e4d29b33
PE
9184 * lread.c (invalid_syntax): Omit length argument.
9185 All uses changed. This doesn't fix a bug, but it simplifies the
9186 code away from its former Hollerith-constant appearance, and it's
9187 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 9188 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 9189
eb49b136
PE
9190 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
9191 This didn't break anything, but it didn't help either.
9192 It's confusing to put a bogus integer in a place where the actual
9193 value does not matter.
9f62aeb1 9194 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 9195 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 9196
15375a22
PE
9197 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
9198 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
9199 implementation.
b61cc01c
PE
9200 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
9201 We prefer signed types, and the value cannot exceed the EMACS_INT
9202 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
9203 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
9204 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
9205 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 9206
53b2623d
PE
9207 * indent.c (sane_tab_width): New function.
9208 (current_column, scan_for_column, Findent_to, position_indentation)
9209 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 9210 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 9211
51cab52b 9212 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 9213
f2ed8a70
PE
9214 * lisp.h (lint_assume): New macro.
9215 * composite.c (composition_gstring_put_cache):
9216 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
9217
abe80cc6
PE
9218 * editfns.c, insdel.c:
9219 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 9220
b02c740e
PE
9221 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
9222
ebc96716
PE
9223 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
9224
b4e50fa0 9225 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 9226 Use much-faster test for byte-length change.
311d5d7c 9227 Don't assume string byte-length fits in 'int'.
a4cf38e4 9228 Check that character arg fits in 'int'.
85461888 9229 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 9230
c0c1ee9f
PE
9231 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
9232
a498d7f4
PE
9233 * fns.c (concat): Catch string overflow earlier.
9234 Do not rely on integer wraparound.
9235
51cab52b
PE
9236 * dispextern.h (struct it.overlay_strings_charpos)
9237 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
9238 * xdisp.c (forward_to_next_line_start)
9239 (back_to_previous_visible_line_start)
9240 (reseat_at_next_visible_line_start, next_element_from_buffer):
9241 Don't arbitrarily truncate the value of 'selective' to int.
9242
76031fad
PE
9243 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
9244
5eb55db9
PE
9245 * composite.c: Don't truncate sizes to 'int'.
9246 (composition_gstring_p, composition_reseat_it)
9247 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
9248 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
9249 not EMACS_UINT, for indexes.
5eb55db9 9250
0703a717
PE
9251 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
9252
d6202519
PE
9253 * buffer.c: Include <verify.h>.
9254 (struct sortvec.priority, struct sortstr.priority):
8961a454 9255 Now EMACS_INT, not int.
c20998a7 9256 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
9257 (struct sortstr.size, record_overlay_string)
9258 (struct sortstrlist.size, struct sortlist.used):
9259 Don't truncate size to int.
9260 (record_overlay_string): Check for size-calculation overflow.
d6202519 9261 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 9262
d5a19415
JM
92632011-06-22 Jim Meyering <meyering@redhat.com>
9264
029529ac 9265 Don't leak an XBM-image-sized buffer
d5a19415
JM
9266 * image.c (xbm_load): Free the image buffer after using it.
9267
a9041e6c
PE
92682011-06-21 Paul Eggert <eggert@cs.ucla.edu>
9269
9270 Port to Sun C.
9271 * composite.c (find_automatic_composition): Omit needless 'return 0;'
9272 that Sun C diagnosed.
9273 * fns.c (secure_hash): Fix pointer signedness issue.
9274 * intervals.c (static_offset_intervals): New function.
9275 (offset_intervals): Use it.
9276
7f3f739f
LL
92772011-06-21 Leo Liu <sdl.web@gmail.com>
9278
9279 * deps.mk (fns.o):
9280 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
9281 sha512.h.
9282
9283 * fns.c (secure_hash): Rename from crypto_hash_function and change
9284 the first arg to accept symbols.
5b66d427 9285 (Fsecure_hash): New primitive.
7f3f739f
LL
9286 (syms_of_fns): New symbols.
9287
76147d94
DD
92882011-06-20 Deniz Dogan <deniz@dogan.se>
9289
9290 * process.c (Fset_process_buffer): Clarify return value in
9291 docstring.
9292
7d7d0045
CY
92932011-06-18 Chong Yidong <cyd@stupidchicken.com>
9294
9295 * dispnew.c (add_window_display_history): Use BVAR.
9296
9297 * xdisp.c (debug_method_add): Use BVAR.
9298 (check_window_end, dump_glyph_matrix, dump_glyph)
9299 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
9300
9301 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
9302 Likewise.
9303
9304 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
9305 check till after the cache is created in init_frame_faces.
9306
ff2bc410
SM
93072011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
9308
9309 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
9310
28177add
PE
93112011-06-16 Paul Eggert <eggert@cs.ucla.edu>
9312
dd3482fe
PE
9313 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
9314 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
9315 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
9316
393d71f3 9317 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
9318 * fileio.c (Finsert_file_contents):
9319 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
9320 Remove the old (too-loose) buffer overflow checks.
9321 They weren't needed, since make_gap checks for buffer overflow.
9322 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
9323 The old code merely checked for Emacs fixnum overflow, and relied
9324 on undefined (wraparound) behavior. The new code avoids undefined
9325 behavior, and also checks for ptrdiff_t and/or size_t overflow.
9326
2e6813b0 9327 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
9328 Tune. Don't use wider integers than needed. Don't use alloca.
9329 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 9330
599a9e4f
PE
9331 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
9332
99561444
PE
9333 * insdel.c, lisp.h (buffer_overflow): New function.
9334 (insert_from_buffer_1, replace_range, replace_range_2):
9335 * insdel.c (make_gap_larger):
9336 * editfns.c (Finsert_char):
9337 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
9338
28177add
PE
9339 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
9340
e69dafad
PE
93412011-06-15 Paul Eggert <eggert@cs.ucla.edu>
9342
4baa020d 9343 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 9344
b1c46f02
PE
9345 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
9346 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
9347
e69dafad
PE
9348 * fileio.c: Don't assume EMACS_INT fits in off_t.
9349 (emacs_lseek): New static function.
9350 (Finsert_file_contents, Fwrite_region): Use it.
9351 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
9352
566684ea
PE
9353 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
9354
e6966cd6
PE
9355 * fns.c: Don't overflow int when computing a list length.
9356 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
9357 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
9358 truncation on 64-bit hosts. Check for QUIT every
9359 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
9360 faster and is responsive enough.
9361 (Flength): Report an error instead of overflowing an integer.
9362 (Fsafe_length): Return a float if the value is not representable
9363 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 9364 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 9365 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 9366
dd0b0efb
PE
9367 * alloc.c: Check that resized vectors' lengths fit in fixnums.
9368 (header_size, word_size): New constants.
9369 (allocate_vectorlike): Don't check size overflow here.
9370 (allocate_vector): Check it here instead, since this is the only
9371 caller of allocate_vectorlike that could cause overflow.
9372 Check that the new vector's length is representable as a fixnum.
9373
86fe5cfe
PE
9374 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
9375 The previous code was bogus. For example, next_almost_prime (32)
9376 returned 39, which is undesirable as it is a multiple of 3; and
9377 next_almost_prime (24) returned 25, which is a multiple of 5 so
9378 why was the code bothering to check for multiples of 7?
9379
80e88859
PE
9380 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
9381
4a2f0ad6
PE
9382 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
9383
f66c7cf8
PE
9384 Variadic C functions now count arguments with ptrdiff_t.
9385 This partly undoes my 2011-03-30 change, which replaced int with size_t.
9386 Back then I didn't know that the Emacs coding style prefers signed int.
9387 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
9388 were being counted with int, which may truncate counts on 64-bit
9389 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
9390 * lisp.h (struct Lisp_Subr.function.aMANY)
9391 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
9392 Arg counts are now ptrdiff_t, not size_t.
9393 All variadic functions and their callers changed accordingly.
9394 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
9395 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
9396 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
9397 * callint.c (Fcall_interactively): Check arg count for overflow,
9398 to avoid potential buffer overrun. Use signed char, not 'int',
9399 for 'varies' array, so that we needn't bother to check its size
9400 calculation for overflow.
9401 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
9402 * eval.c (apply_lambda):
9403 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
9404 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
9405 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
9406
a1759b76
PE
9407 * callint.c (Fcall_interactively): Don't use index var as event count.
9408
d96be9fc
PE
9409 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
9410 * mem-limits.h (SIZE): Remove; no longer used.
9411
a690a978 9412 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 9413
578c21e6
PE
9414 Remove unnecessary casts.
9415 * xterm.c (x_term_init):
9416 * xfns.c (x_set_border_pixel):
9417 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
9418 These aren't needed now that we assume ANSI C.
9419
96f53c6c
PE
9420 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
9421 It's more likely to cause problems (due to unsigned overflow)
9422 than to cure them.
9423
83c77d31
PE
9424 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
9425
ee2079f1
PE
9426 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
9427
6da65536
PE
9428 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
9429
7147c4a4
PE
9430 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
9431
193e32d9
PE
9432 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
9433
e5533da6
PE
9434 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
9435
9910e595
PE
9436 GLYPH_CODE_FACE returns EMACS_INT, not int.
9437 * dispextern.h (merge_faces):
9438 * xfaces.c (merge_faces):
01103c44
PE
9439 * xdisp.c (get_next_display_element, next_element_from_display_vector):
9440 Don't assume EMACS_INT fits in int.
9910e595 9441
2638320e
PE
9442 * character.h (CHAR_VALID_P): Remove unused parameter.
9443 * fontset.c, lisp.h, xdisp.c: All uses changed.
9444
045eb8d9
PE
9445 * editfns.c (Ftranslate_region_internal): Omit redundant test.
9446
c1f134b5
PE
9447 * fns.c (concat): Minor tuning based on overflow analysis.
9448 This doesn't fix any bugs. Use int to hold character, instead
9449 of constantly refetching from Emacs object. Use XFASTINT, not
9450 XINT, for value known to be a character. Don't bother comparing
9451 a single byte to 0400, as it's always less.
9452
395fcb93 9453 * floatfns.c (Fexpt):
327eeec8
PE
9454 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
9455
abbd3d23
PE
9456 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
9457 for characters.
9458
684a03ef
PE
9459 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
9460
0fed43f3
PE
9461 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
9462 Without this fix, on a 64-bit host (aset S 0 4294967386) would
9463 incorrectly succeed when S was a string, because 4294967386 was
9464 truncated before it was used.
9465
8fd02eb7
PE
9466 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
9467 Otherwise, an out-of-range integer could cause undefined behavior
9468 on a 64-bit host.
9469
f8c86b69
PE
9470 * composite.c: Use int, not EMACS_INT, for characters.
9471 (fill_gstring_body, composition_compute_stop_pos): Use int, not
9472 EMACS_INT, for values that are known to be in character range.
9473 This doesn't fix any bugs but is the usual style inside Emacs and
9474 may generate better code on 32-bit machines.
9475
34206dd2
PE
9476 Make sure a 64-bit char is never passed to ENCODE_CHAR.
9477 This is for reasons similar to the recent CHAR_STRING fix.
9478 * charset.c (Fencode_char): Check that character arg is actually
9479 a character. Pass an int to ENCODE_CHAR.
9480 * charset.h (ENCODE_CHAR): Verify that the character argument is no
9481 wider than 'int', as a compile-time check to prevent future regressions
9482 in this area.
9483
c5958d4c 9484 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
9485
9486 Make sure a 64-bit char is never passed to CHAR_STRING.
9487 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
9488 by silently ignoring the top 32 bits, allowing some values
9489 that were far too large to be valid characters.
9490 * character.h: Include <verify.h>.
9491 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
9492 arguments are no wider than unsigned, as a compile-time check
9493 to prevent future regressions in this area.
9494 * data.c (Faset):
01103c44 9495 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
9496 (Fsubst_char_in_region):
9497 * fns.c (concat):
9498 * xdisp.c (decode_mode_spec_coding):
9499 Adjust to CHAR_STRING's new requirement.
9500 * editfns.c (Finsert_char, Fsubst_char_in_region):
9501 * fns.c (concat): Check that character args are actually
9502 characters. Without this test, these functions did the wrong
9503 thing with wildly out-of-range values on 64-bit hosts.
9504
d37ca623
PE
9505 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
9506 These casts should not be needed on 32-bit hosts, either.
9507 * keyboard.c (read_char):
9508 * lread.c (Fload): Remove casts to unsigned.
9509
ea204efb
PE
9510 * lisp.h (UNSIGNED_CMP): New macro.
9511 This fixes comparison bugs on 64-bit hosts.
9512 (ASCII_CHAR_P): Use it.
9513 * casefiddle.c (casify_object):
01103c44 9514 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
9515 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
9516 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
9517 * dispextern.h (FACE_FROM_ID):
9518 * keyboard.c (read_char): Use UNSIGNED_CMP.
9519
41cb286c
PE
9520 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
9521 not to EMACS_INT, to avoid GCC warning.
9522
4a1b9832
PE
9523 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
9524
55daad71
PE
9525 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
9526 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
9527 isn't needed on 32-bit machines.
8f95c75c 9528
01103c44
PE
9529 * buffer.c (Fgenerate_new_buffer_name):
9530 Use EMACS_INT for count, not int.
0ceccced 9531 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
9532
9533 * data.c (Qcompiled_function): Now static.
9534
c6f072e7
PE
9535 * window.c (window_body_lines): Now static.
9536
20ce5912
PE
9537 * image.c (gif_load): Rename local to avoid shadowing.
9538
9c4c5f81
PE
9539 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
9540 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
9541 * alloc.c (make_save_value): Integer argument is now of type
9542 ptrdiff_t, not int.
9543 (mark_object): Use ptrdiff_t, not int.
9544 * lisp.h (pD): New macro.
9545 * print.c (print_object): Use it.
9546
c0c5c8ae
PE
9547 * alloc.c: Use EMACS_INT, not int, to count objects.
9548 (total_conses, total_markers, total_symbols, total_vector_size)
9549 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
9550 (total_free_floats, total_floats, total_free_intervals)
9551 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
9552 Now EMACS_INT, not int. All uses changed.
9553 (Fgarbage_collect): Compute overall total using a double, so that
9554 integer overflow is less likely to be a problem. Check for overflow
9555 when converting back to an integer.
5a25e253
PE
9556 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
9557 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
9558 These were 'int' variables that could overflow on 64-bit hosts;
9559 they were never used, so remove them instead of repairing them.
211a0b2a 9560 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
9561 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
9562 Previously, this ceilinged at INT_MAX, but that doesn't work on
9563 64-bit machines.
e46bb31a 9564 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 9565
c78baabf 9566 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 9567 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
9568 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
9569 when a (possibly-narrower) signed value would do just as well.
9570 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 9571
c9d624c6
PE
9572 * alloc.c: Catch some string size overflows that we were missing.
9573 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
9574 for convenience in STRING_BYTES_MAX.
9575 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
9576 The definition here is exact; the one in lisp.h was approximate.
9577 (allocate_string_data): Check for string overflow. This catches
9578 some instances we weren't catching before. Also, it catches
9579 size_t overflow on (unusual) hosts where SIZE_MAX <= min
9580 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
9581 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 9582
c9d624c6
PE
9583 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
9584 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 9585 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 9586
353032ce
PE
9587 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
9588
2bccce07
PE
9589 * alloc.c (Fmake_string): Check for out-of-range init.
9590
0ac30604
SM
95912011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
9592
9593 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
9594
c195f2de
JD
95952011-06-14 Jan Djärv <jan.h.d@swipnet.se>
9596
9597 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
9598 xg_get_default_scrollbar_width.
9599
9600 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
9601 (int_gtk_range_get_value): Move to the scroll bar part of the file.
9602 (style_changed_cb): Call update_theme_scrollbar_width and call
9603 x_set_scroll_bar_default_width and xg_frame_set_char_size for
9604 all frames (Bug#8505).
9605 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
9606 Call gtk_window_set_resizable if HAVE_GTK3.
9607 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
9608 and height if HAVE_GTK3 (Bug#8505).
9609 (scroll_bar_width_for_theme): New variable.
9610 (update_theme_scrollbar_width): New function.
9611 (xg_get_default_scrollbar_width): Move code to
9612 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
9613 (xg_initialize): Call update_theme_scrollbar_width.
9614
9615 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
9616
9617 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
9618
e10ac9f1
MR
96192011-06-12 Martin Rudalics <rudalics@gmx.at>
9620
9621 * frame.c (make_frame): Call other_buffer_safely instead of
9622 other_buffer.
9623
9624 * window.c (temp_output_buffer_show): Call display_buffer with
9625 second argument Vtemp_buffer_show_specifiers and reset latter
9626 immediately after the call.
9627 (Vtemp_buffer_show_specifiers): New variable.
9628 (auto_window_vscroll_p, next_screen_context_lines)
9629 (Vscroll_preserve_screen_position): Remove leading asterisks from
9630 doc-strings.
9631
2d3c217e 96322011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 9633
7b7f97e8 9634 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
9635 * buffer.c (Qclone_number): Remove for now, as it's unused.
9636 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
9637 (record_buffer): Remove unused local.
9638 * frame.c (other_visible_frames, frame_buffer_list): Now static.
9639 (set_frame_buffer_list): Remove; unused.
9640 * frame.h (other_visible_frames): Remove decl.
9641 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
9642 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
9643 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
9644 if HAVE_GPM.
9645 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
9646 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
9647 Define only if HAVE_GPM.
9648 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
9649 (update_hints_inhibit): Remove; never set. All uses removed.
9650 * widgetprv.h (emacsFrameClassRec): Remove decl.
9651 * window.c (delete_deletable_window): Now returns void, since it
9652 wasn't returning anything.
9653 (compare_window_configurations): Remove unused locals.
9654 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
9655 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
9656 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
9657 the same widths as pointers. This follows up on the 2011-05-06 patch.
9658 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
9659 * xterm.h: Likewise.
9660 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
9661
1384b89e
JB
96622011-06-12 Juanma Barranquero <lekktu@gmail.com>
9663
9664 * makefile.w32-in: Update dependencies.
9665 (LISP_H): Add lib/intprops.h.
9666
1100a63c
CY
96672011-06-11 Chong Yidong <cyd@stupidchicken.com>
9668
9669 * image.c (gif_load): Add animation frame delay to the metadata.
9670 (syms_of_image): Use DEFSYM. New symbol `delay'.
9671
6198ccd0
MR
96722011-06-11 Martin Rudalics <rudalics@gmx.at>
9673
9674 * window.c (delete_deletable_window): Re-add.
9675 (Fset_window_configuration): Rewrite to handle dead buffers and
9676 consequently deletable windows.
9677 (window_tree, Fwindow_tree): Remove. Supply functionality in
9678 window.el.
9679 (compare_window_configurations): Simplify code.
9680
b6e3633c
AS
96812011-06-11 Andreas Schwab <schwab@linux-m68k.org>
9682
1ab0dee5
AS
9683 * image.c (imagemagick_load_image): Fix type mismatch.
9684 (Fimagemagick_types): Likewise.
9685
b6e3633c
AS
9686 * window.h (replace_buffer_in_windows): Declare.
9687
9397e56f
MR
96882011-06-11 Martin Rudalics <rudalics@gmx.at>
9689
9690 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
9691 Qclone_number. Remove external declaration of Qdelete_window.
9692 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
9693 code.
640c8776
SM
9694 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
9695 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
9696 (Fother_buffer): Rewrite doc-string. Major rewrite for new
9697 buffer list implementation.
9698 (other_buffer_safely): New function.
9699 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
9700 calls to replace_buffer_in_windows and
9701 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
9702 if allowed.
9703 (record_buffer): Inhibit quitting and rewrite using quittable
9704 functions. Run Qbuffer_list_update_hook if allowed.
9705 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
9706 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
9707 Move switch-to-buffer to window.el.
9397e56f
MR
9708 (bury-buffer): Move to window.el.
9709 (Vbuffer_list_update_hook): New variable.
9710
9711 * lisp.h (other_buffer_safely): Add prototype in buffer.c
9712 section.
9713
9714 * window.h (resize_frame_windows): Move up in code.
9715 (Fwindow_frame): Remove EXFUN.
9716 (replace_buffer_in_all_windows): Remove prototype.
9717 (replace_buffer_in_windows_safely): Add prototype.
9718
9719 * window.c: Declare Qdelete_window static again. Move down
9720 declaration of select_count.
9721 (Fnext_window, Fprevious_window): Rewrite doc-strings.
9722 (Fother_window): Move to window.el.
9723 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
9724 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
9725 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
9726 window.el.
9727 (replace_buffer_in_windows): Implement by calling
9728 Qreplace_buffer_in_windows.
9729 (replace_buffer_in_all_windows): Remove with some functionality
9730 moved into replace_buffer_in_windows_safely.
9731 (replace_buffer_in_windows_safely): New function.
9732 (select_window_norecord, select_frame_norecord): Move in front
9733 of run_window_configuration_change_hook. Remove now obsolete
9734 declarations.
640c8776
SM
9735 (Fset_window_buffer): Rewrite doc-string.
9736 Call Qrecord_window_buffer.
9397e56f
MR
9737 (keys_of_window): Move binding for other-window to window.el.
9738
b50691aa
CY
97392011-06-11 Chong Yidong <cyd@stupidchicken.com>
9740
9741 * dispextern.h (struct image): Replace data member, whose int_val
9742 and ptr_val fields were not used by anything, with a single
9743 lisp_val object.
9744
9745 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
9746 (gif_clear_image, gif_load, imagemagick_load_image)
9747 (gs_clear_image, gs_load): Callers changed.
9748
3f754b86
PE
97492011-06-10 Paul Eggert <eggert@cs.ucla.edu>
9750
cca69397
PE
9751 * buffer.h: Include <time.h>, for time_t.
9752 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
9753
109e28d0
PE
9754 Fix minor problems found by static checking.
9755
60737f02
PE
9756 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
9757
4b66faf3
PE
9758 Make identifiers static if they are not used in other modules.
9759 * data.c (Qcompiled_function, Qframe, Qvector):
9760 * image.c (QimageMagick, Qsvg):
9761 * minibuf.c (Qmetadata):
9762 * window.c (resize_window_check, resize_root_window): Now static.
9763 * window.h (resize_window_check, resize_root_window): Remove decls.
9764
109e28d0
PE
9765 * window.c (window_deletion_count, delete_deletable_window):
9766 Remove; unused.
46a4ce9e
PE
9767 (window_body_lines): Now static.
9768 (Fdelete_other_windows_internal): Mark vars as initialized.
9769 Make sure 'resize_failed' is initialized.
9770 (run_window_configuration_change_hook): Rename local to avoid shadowing.
9771 (resize_window_apply): Remove unused local.
9772 * window.h (delete_deletable_window): Remove decl.
9773
109e28d0 9774 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
9775 (imagemagick_load_image): Fix pointer signedness problem by changing
9776 last arg from unsigned char * to char *. All uses changed.
9777 Also, fix a local for similar reasons.
9778 Remove unused locals. Remove locals to avoid shadowing.
9779 (fn_rsvg_handle_free): Remove; unused.
9780 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 9781 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 9782
3f754b86
PE
9783 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
9784
2547adb1
CY
97852011-06-10 Chong Yidong <cyd@stupidchicken.com>
9786
9787 * image.c (gif_load): Fix omitted cast error introduced by
9788 2011-06-06 change.
9789
2c8e37d4
MR
97902011-06-10 Martin Rudalics <rudalics@gmx.at>
9791
9792 * window.h (resize_proportionally, orig_total_lines)
9793 (orig_top_line): Remove from window structure.
9794 (set_window_height, set_window_width, change_window_heights)
9795 (Fdelete_window): Remove prototypes.
9796 (resize_frame_windows): Remove duplicate declaration.
9797
440a42e3
EZ
97982011-06-10 Eli Zaretskii <eliz@gnu.org>
9799
9800 * window.h (resize_frame_windows, resize_window_check)
9801 (delete_deletable_window, resize_root_window)
9802 (resize_frame_windows): Declare prototypes.
9803
9804 * window.c (resize_window_apply): Make definition be "static" to
9805 match the prototype.
9806
562dd5e9
MR
98072011-06-10 Martin Rudalics <rudalics@gmx.at>
9808
9809 * window.c: Remove declarations of Qwindow_size_fixed,
9810 window_min_size_1, window_min_size_2, window_min_size,
9811 size_window, window_fixed_size_p, enlarge_window, delete_window.
9812 Remove static from declaration of Qdelete_window, it's
9813 temporarily needed by Fbury_buffer.
9814 (replace_window): Don't assign orig_top_line and
9815 orig_total_lines.
9816 (Fdelete_window, delete_window): Remove. Window deletion is
9817 handled by window.el.
640c8776
SM
9818 (window_loop): Remove DELETE_OTHER_WINDOWS case.
9819 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
9820 (Fdelete_other_windows): Remove. Deleting other windows is
9821 handled by window.el.
9822 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
9823 handled in window.el.
9824 (window_min_size_2, window_min_size_1, window_min_size): Remove.
9825 Window minimum sizes are handled in window.el.
9826 (shrink_windows, size_window, set_window_height)
9827 (set_window_width, change_window_heights, window_height)
9828 (window_width, CURBEG, CURSIZE, enlarge_window)
9829 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
9830 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
9831 handled in window.el.
9832 (make_dummy_parent): Rename to make_parent_window and give it a
9833 second argument horflag.
9834 (make_window): Don't set resize_proportionally any more.
9835 (Fsplit_window): Remove. Windows are split in window.el.
9836 (save_restore_action, save_restore_orig_size)
9837 (shrink_window_lowest_first, save_restore_orig_size): Remove.
9838 Resize mini windows in window.el.
9839 (grow_mini_window, shrink_mini_window): Implement by calling
9840 Qresize_root_window_vertically, resize_window_check and
9841 resize_window_apply.
640c8776
SM
9842 (saved_window, Fset_window_configuration, save_window_save):
9843 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
9844 resize_proportionally.
9845 (window_min_height, window_min_width): Move to window.el.
9846 (keys_of_window): Move bindings for delete-other-windows,
9847 split-window, delete-window and enlarge-window to window.el.
9848
9849 * buffer.c: Temporarily extern Qdelete_window.
9850 (Fbury_buffer): Temporarily call Qdelete_window instead of
9851 Fdelete_window (Fbury_buffer will move to window.el soon).
9852
9853 * frame.c (set_menu_bar_lines_1): Remove code handling
9854 orig_top_line and orig_total_lines.
9855
9856 * dispnew.c (adjust_frame_glyphs_initially): Don't use
9857 set_window_height but set heights directly.
9858 (change_frame_size_1): Use resize_frame_windows.
9859
9860 * xdisp.c (init_xdisp): Don't use set_window_height but set
9861 heights directly.
9862
640c8776
SM
9863 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
9864 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
9865 run_window_configuration_change_hook.
9866
9867 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
9868 instead of change_window_heights and run
9869 run_window_configuration_change_hook.
9870
1a13852e
MR
98712011-06-09 Martin Rudalics <rudalics@gmx.at>
9872
9873 * window.c (replace_window): Rename second argument REPLACEMENT to
9874 NEW. New third argument SETFLAG. Rewrite.
9875 (delete_window, make_dummy_parent): Call replace_window with
9876 third argument 1.
9877 (window_list_1): Move down in code.
9878 (run_window_configuration_change_hook): Move set_buffer part
9879 before select_frame_norecord part in order to unwind correctly.
9880 Rename count1 to count.
9881 (recombine_windows, delete_deletable_window, resize_root_window)
9882 (Fdelete_other_windows_internal)
9883 (Frun_window_configuration_change_hook, make_parent_window)
9884 (resize_window_check, resize_window_apply, Fresize_window_apply)
9885 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
9886 (Fdelete_window_internal, Fresize_mini_window_internal):
9887 New functions.
1a13852e
MR
9888 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
9889
f3d1777e
MR
98902011-06-08 Martin Rudalics <rudalics@gmx.at>
9891
496e208e
MR
9892 * window.h (window): Add some new members to window structure -
9893 normal_lines, normal_cols, new_total, new_normal, clone_number,
9894 splits, nest, prev_buffers, next_buffers.
9895 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 9896 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 9897
f3d1777e
MR
9898 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
9899 Remove.
496e208e
MR
9900 (make_dummy_parent): Set new members of windows structure.
9901 (make_window): Move down in code. Handle new members of window
9902 structure.
9903 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
9904 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
9905 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
9906 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
9907 (Fset_window_next_buffers, Fset_window_clone_number):
9908 New functions.
496e208e
MR
9909 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
9910 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
9911 Doc-string fixes.
9912 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
9913 Argument WINDOW can be now internal window too.
9914 (Fwindow_use_time): Move up in code.
9915 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
9916 Rewrite doc-string.
9917 (Fset_window_configuration, saved_window)
9918 (Fcurrent_window_configuration, save_window_save): Handle new
9919 members of window structure.
b9e809c2
MR
9920 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
9921 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
9922 (syms_of_window): New Lisp objects Qrecord_window_buffer,
9923 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
9924 Qget_mru_window, Qresize_root_window,
9925 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
9926 Qauto_buffer_name; staticpro them.
f3d1777e 9927
abde8f8c
MR
99282011-06-07 Martin Rudalics <rudalics@gmx.at>
9929
9930 * window.c (Fwindow_total_size, Fwindow_left_column)
9931 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
9932 (Fwindow_list_1): New functions.
9933 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
9934 (Fwindow_width, Fscroll_left, Fscroll_right):
9935 Use window_body_cols instead of window_box_text_cols.
9936 (delete_window, Fset_window_configuration):
9937 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
9938 (delete_all_subwindows): Take a window as argument and not a
9939 structure. Rewrite.
190b47e6
MR
9940 (window_loop): Remove handling of GET_LRU_WINDOW and
9941 GET_LARGEST_WINDOW.
9942 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
9943
9944 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
9945 window_box_text_cols. delete_all_subwindows now takes a
9946 Lisp_Object as argument.
abde8f8c 9947
640c8776
SM
9948 * indent.c (compute_motion, Fcompute_motion):
9949 Use window_body_cols instead of window_box_text_cols.
abde8f8c 9950
fa8a67e6
MR
9951 * frame.c (delete_frame): Call delete_all_subwindows with root
9952 window as argument.
9953
a54e3482
DC
99542011-06-07 Daniel Colascione <dan.colascione@gmail.com>
9955
9956 * fns.c (Fputhash): Document return value.
9957
60002bf5
CY
99582011-06-06 Chong Yidong <cyd@stupidchicken.com>
9959
9960 * image.c (gif_load): Implement gif89a spec "no disposal" method.
9961
0c671da6 99622011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 9963
b862a52a 9964 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 9965
be44ca6c
PE
9966 Check for overflow when converting integer to cons and back.
9967 * charset.c (Fdefine_charset_internal, Fdecode_char):
9968 Use cons_to_unsigned to catch overflow.
9969 (Fencode_char): Use INTEGER_TO_CONS.
9970 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
9971 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
9972 * data.c (long_to_cons, cons_to_long): Remove.
9973 (cons_to_unsigned, cons_to_signed): New functions.
9974 These signal an error for invalid or out-of-range values.
9975 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
9976 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
9977 * font.c (Ffont_variation_glyphs):
9978 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
9979 * lisp.h: Include <intprops.h>.
9980 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
9981 (cons_to_signed, cons_to_unsigned): New decls.
9982 (long_to_cons, cons_to_long): Remove decls.
9983 * undo.c (record_first_change): Use INTEGER_TO_CONS.
9984 (Fprimitive_undo): Use CONS_TO_INTEGER.
9985 * xfns.c (Fx_window_property): Likewise.
9986 * xselect.c: Include <limits.h>.
9987 (x_own_selection, selection_data_to_lisp_data):
9988 Use INTEGER_TO_CONS.
9989 (x_handle_selection_request, x_handle_selection_clear)
9990 (x_get_foreign_selection, Fx_disown_selection_internal)
9991 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
9992 (lisp_data_to_selection_data): Use cons_to_unsigned.
9993 (x_fill_property_data): Use cons_to_signed.
9994 Report values out of range.
9995
d1f3d2af
PE
9996 Check for buffer and string overflow more precisely.
9997 * buffer.h (BUF_BYTES_MAX): New macro.
9998 * lisp.h (STRING_BYTES_MAX): New macro.
9999 * alloc.c (Fmake_string):
10000 * character.c (string_escape_byte8):
10001 * coding.c (coding_alloc_by_realloc):
10002 * doprnt.c (doprnt):
10003 * editfns.c (Fformat):
10004 * eval.c (verror):
10005 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
10006 since they may not be the same number.
10007 * editfns.c (Finsert_char):
10008 * fileio.c (Finsert_file_contents):
10009 Likewise for BUF_BYTES_MAX.
10010
dd52fcea
PE
10011 * image.c: Use ptrdiff_t, not int, for sizes.
10012 (slurp_file): Switch from int to ptrdiff_t.
10013 All uses changed.
10014 (slurp_file): Check that file size fits in both size_t (for
10015 malloc) and ptrdiff_t (for sanity and safety).
10016
7f9bbdbb
PE
10017 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
10018 if b->modtime has its maximal value.
10019
dfe18f82
PE
10020 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
10021
84acfcf0
PE
10022 Don't assume time_t can fit into int.
10023 * buffer.h (struct buffer.modtime): Now time_t, not int.
10024 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
10025 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
10026
ccd9a01a
PE
10027 Minor fixes for signed vs unsigned integers.
10028 * character.h (MAYBE_UNIFY_CHAR):
10029 * charset.c (maybe_unify_char):
10030 * keyboard.c (read_char, reorder_modifiers):
10031 XINT -> XFASTINT, since the integer must be nonnegative.
10032 * ftfont.c (ftfont_spec_pattern):
10033 * keymap.c (access_keymap, silly_event_symbol_error):
10034 XUINT -> XFASTINT, since the integer must be nonnegative.
10035 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
10036 since it makes no difference and we prefer signed.
10037 * keyboard.c (record_char): Use XUINT when all the neighbors do.
10038 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
10039 nonnegative.
10040
d6d100dd
SM
100412011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
10042
10043 * window.h (Fwindow_frame): Declare.
10044
2b6148e4
PE
100452011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10046
10047 * alloc.c: Simplify handling of large-request failures (Bug#8800).
10048 (SPARE_MEMORY): Always define.
10049 (LARGE_REQUEST): Remove.
10050 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
10051
f230ecc9
MR
100522011-06-06 Martin Rudalics <rudalics@gmx.at>
10053
727e958e
MR
10054 * lisp.h: Move EXFUNS for Fframe_root_window,
10055 Fframe_first_window and Fset_frame_selected_window to window.h.
10056
10057 * window.h: Move EXFUNS for Fframe_root_window,
10058 Fframe_first_window and Fset_frame_selected_window here from
10059 lisp.h.
10060
10061 * frame.c (Fwindow_frame, Fframe_first_window)
10062 (Fframe_root_window, Fframe_selected_window)
10063 (Fset_frame_selected_window): Move to window.c.
10064 (Factive_minibuffer_window): Move to minibuf.c.
10065 (Fother_visible_frames_p): New function.
10066
10067 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
10068
f230ecc9
MR
10069 * window.c (decode_window, decode_any_window): Move up in code.
10070 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
10071 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
10072 (Fwindow_buffer): Move up and rewrite doc-string.
10073 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
10074 (Fwindow_prev): New functions.
727e958e
MR
10075 (Fwindow_frame): Move here from frame.c. Accept any window as
10076 argument.
10077 (Fframe_root_window, Fframe_first_window)
10078 (Fframe_selected_window): Move here from frame.c. Accept frame
10079 or arbitrary window as argument. Update doc-strings.
10080 (Fminibuffer_window): Move up in code.
10081 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
10082 (Fset_frame_selected_window): Move here from frame.c.
10083 Marginal rewrite.
727e958e
MR
10084 (Fselected_window, select_window, Fselect_window): Move up in
10085 code. Minor doc-string fixes.
f230ecc9 10086
4d09bcf6
PE
100872011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10088
10089 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
10090 Do not assume that spare memory exists; that assumption is valid
10091 only if SYSTEM_MALLOC.
10092 (LARGE_REQUEST): New macro, so that the issue of large requests
10093 is separated from the issue of spare memory.
10094
810928a2
AS
100952011-06-05 Andreas Schwab <schwab@linux-m68k.org>
10096
172418ad
AS
10097 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
10098 format. (Bug#8806)
10099
43f862f7
AS
10100 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
10101
810928a2
AS
10102 * xfns.c (x_set_scroll_bar_default_width): Move declarations
10103 before statements.
10104
a059fe24
JD
101052011-06-05 Jan Djärv <jan.h.d@swipnet.se>
10106
10107 * gtkutil.c (xg_get_default_scrollbar_width): New function.
10108
10109 * gtkutil.h: Declare xg_get_default_scrollbar_width.
10110
10111 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
10112 min width by calling x_set_scroll_bar_default_width (Bug#8505).
10113
989bf368
JB
101142011-06-05 Juanma Barranquero <lekktu@gmail.com>
10115
10116 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
10117
4b80f674
CY
101182011-06-04 Chong Yidong <cyd@stupidchicken.com>
10119
10120 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
10121 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
10122 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
10123 New error handlers.
4b80f674
CY
10124 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
10125 Obey Vx_select_enable_clipboard_manager. Catch errors in
10126 x_clipboard_manager_save (Bug#8779).
10127 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 10128 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 10129
99a33b77 101302011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
10131
10132 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
10133
99a33b77 101342011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
10135
10136 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
10137 in the current matrix if keep_current_p is non-zero.
10138
8264569d
EZ
101392011-06-04 Eli Zaretskii <eliz@gnu.org>
10140
10141 * bidi.c (bidi_level_of_next_char): Fix last change.
10142
57f97249
EZ
101432011-06-03 Eli Zaretskii <eliz@gnu.org>
10144
fec2107c 10145 Support bidi reordering of text covered by display properties.
57f97249 10146
fec2107c
EZ
10147 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
10148 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
10149 (bidi_cache_search, bidi_cache_iterator_state)
10150 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
10151 (bidi_level_of_next_char, bidi_move_to_visually_next):
10152 Support character positions inside a run of characters covered by a
fec2107c
EZ
10153 display string.
10154 (bidi_paragraph_init, bidi_resolve_explicit_1)
10155 (bidi_level_of_next_char): Call bidi_fetch_char and
10156 bidi_fetch_char_advance instead of FETCH_CHAR and
10157 FETCH_CHAR_ADVANCE.
10158 (bidi_init_it): Initialize new members.
10159 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
10160 definitions.
10161 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
10162 instead of using explicit *_CHAR codes.
d6d100dd
SM
10163 (bidi_resolve_explicit, bidi_resolve_weak):
10164 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
10165 bidirectional text is supported only in multibyte buffers.
10166 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
10167 it to initialize the frame_window_p member of struct bidi_it.
10168 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
10169 (bidi_resolve_explicit, bidi_resolve_weak)
10170 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
10171 bidi_it->nchars is non-positive.
10172 (bidi_level_of_next_char): Don't try to lookup the cache for the
10173 next/previous character if nothing is cached there yet, or if we
10174 were just reseat()'ed to a new position.
c40e2fb2 10175
0e14fe90
EZ
10176 * xdisp.c (set_cursor_from_row): Set start and stop points
10177 according to the row's direction when priming the loop that looks
10178 for the glyph on which to display cursor.
10179 (single_display_spec_intangible_p): Function deleted.
10180 (display_prop_intangible_p): Reimplement to call
10181 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
10182 Accept 3 additional arguments needed by handle_display_spec.
10183 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
10184 values: lists, `(when COND...)' forms, etc.
10185 (single_display_spec_string_p): Support property values that are
10186 lists with the argument STRING its top-level element.
10187 (display_prop_string_p): Fix the condition for processing a
10188 property that is a list to be consistent with handle_display_spec.
fec2107c 10189 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
10190 last portion of handle_display_prop.
10191 (compute_display_string_pos): Accept additional argument
10192 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
10193 value of a `display' property is a "replacing spec".
10194 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
10195 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
10196 the display property, but just return a value indicating whether
10197 the display property will replace the characters it covers.
10198 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
10199 frame_window_p members of struct bidi_it.
d6d100dd
SM
10200 (compute_display_string_pos, compute_display_string_end):
10201 New functions.
fec2107c
EZ
10202 (push_it): Accept second argument POSITION, where pop_it should
10203 jump to continue iteration.
10204 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 10205
fec2107c
EZ
10206 * keyboard.c (adjust_point_for_property): Adjust the call to
10207 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
10208
10209 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
10210 (bidi_init_it): Update prototypes.
10211 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
10212 (compute_display_string_pos, compute_display_string_end):
10213 Declare prototypes.
fec2107c
EZ
10214 (struct bidi_it): New members nchars and disp_pos. ch_len is now
10215 EMACS_INT.
fc6f18ce 10216
40087514 102172011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 10218
57f53182
PE
10219 Malloc failure behavior now depends on size of allocation.
10220 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
10221 * lisp.h: Change signatures accordingly.
10222 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
10223 All callers changed. (Bug#8762)
10224
10225 * gnutls.c: Use Emacs's memory allocators.
10226 Without this change, the gnutls library would invoke malloc etc.
10227 directly, which causes problems on non-SYNC_INPUT hosts, and which
10228 runs afoul of improving memory_full behavior. (Bug#8761)
10229 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
10230 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
10231 xfree instead of the default malloc, realloc, free.
10232 (Fgnutls_boot): No need to check for memory allocation failure,
10233 since xmalloc does that for us.
10234
ac32cd99 10235 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
10236 * category.c (hash_get_category_set):
10237 * ccl.c (ccl_driver):
10238 * charset.c (Fdefine_charset_internal):
10239 * charset.h (struct charset.hash_index):
10240 * composite.c (get_composition_id, gstring_lookup_cache)
10241 (composition_gstring_put_cache):
10242 * composite.h (struct composition.hash_index):
10243 * dispextern.h (struct image.hash):
10244 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
10245 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
10246 (hashfn_equal, hashfn_user_defined, make_hash_table)
10247 (maybe_resize_hash_table, hash_lookup, hash_put)
10248 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
10249 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
10250 (Fsxhash, Fgethash, Fputhash, Fmaphash):
10251 * image.c (make_image, search_image_cache, lookup_image)
10252 (xpm_put_color_table_h):
10253 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 10254 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 10255 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 10256 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
10257 * alloc.c (allocate_vectorlike):
10258 Check for overflow in vector size calculations.
10259 * ccl.c (ccl_driver):
10260 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
10261 * fns.c, image.c: Remove unnecessary static decls that would otherwise
10262 need to be updated by these changes.
40087514
PE
10263 * fns.c (make_hash_table, maybe_resize_hash_table):
10264 Check for integer overflow with large hash tables.
0de4bb68
PE
10265 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
10266 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
10267 (SXHASH_REDUCE): New macro.
10268 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
10269 Use it instead of discarding useful hash info with large hash values.
10270 (sxhash_float): New function.
10271 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
10272 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
10273 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
10274 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
10275 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
10276 Adjust signatures to match updated version of code.
10277 (consing_since_gc): Now EMACS_INT, since a single hash table can
10278 use more than INT_MAX bytes.
10279
698d32e2
DN
102802011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
10281
10282 Make it possible to build with GCC-4.6+ -O2 -flto.
10283
10284 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
10285
fd6fa53f
SM
102862011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
10287
10288 * minibuf.c (get_minibuffer, read_minibuf_unwind):
10289 Call minibuffer-inactive-mode.
10290
864db017
JB
102912011-05-31 Juanma Barranquero <lekktu@gmail.com>
10292
10293 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
10294 Update dependencies.
10295
2ad0baf4
DN
102962011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10297
10298 * data.c (init_data): Remove code for UTS, this system is not
10299 supported anymore.
10300
4fcc2638
DN
103012011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10302
10303 Don't force ./temacs to start in terminal mode.
10304
10305 * frame.c (make_initial_frame): Initialize faces in all cases, not
10306 only when CANNOT_DUMP is defined.
10307 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
10308
c56e0fd5
DN
103092011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10310
10311 * dispnew.c (add_window_display_history): Use const for the string
10312 pointer. Remove declaration, not needed.
10313
333d54da 103142011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 10315
55d4c1b2 10316 Use 'inline', not 'INLINE'.
333d54da 10317 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
10318 * alloc.c, fontset.c (INLINE): Remove.
10319 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
10320 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
10321 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
10322 * gmalloc.c (register_heapinfo): Use inline unconditionally.
10323 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
10324
738db178
DN
103252011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10326
10327 Make it possible to run ./temacs.
10328
10329 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
10330 syms_of_callproc does the same thing. Remove test for
10331 "initialized", do it in the caller.
10332 * emacs.c (main): Avoid calling set_initial_environment when dumping.
10333
620c53a6
SM
103342011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
10335
10336 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
10337 (read_minibuf): Use get_minibuffer.
10338 (syms_of_minibuf): Use DEFSYM.
10339 (Qmetadata): New var.
10340 * data.c (Qbuffer): Don't make it static.
10341 (syms_of_data): Use DEFSYM.
10342
e003a292
PE
103432011-05-31 Paul Eggert <eggert@cs.ucla.edu>
10344
10345 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
10346 (CCL_CODE_MIN): New macro.
10347
ed008a6d
PE
103482011-05-30 Paul Eggert <eggert@cs.ucla.edu>
10349
3687c2ef
PE
10350 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
10351
ed008a6d
PE
10352 * eval.c (Qdebug): Now static.
10353 * lisp.h (Qdebug): Remove decl. This reverts a part of the
10354 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
10355 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
10356
d66c4c7c
CY
103572011-05-29 Chong Yidong <cyd@stupidchicken.com>
10358
10359 * image.c: Various fixes to ImageMagick code comments.
10360 (Fimagemagick_types): Doc fix.
10361
5fbc2025
PE
103622011-05-29 Paul Eggert <eggert@cs.ucla.edu>
10363
0196f88a
PE
10364 Minor fixes prompted by GCC 4.6.0 warnings.
10365
10366 * xselect.c (converted_selections, conversion_fail_tag): Now static.
10367
5fbc2025
PE
10368 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
10369 (x_clipboard_manager_save_all): Move extern decl to ...
10370 * xterm.h: ... here, so that it can be checked for consistency.
10371
1dd3c2d9
CY
103722011-05-29 Chong Yidong <cyd@stupidchicken.com>
10373
10374 * xselect.c (x_clipboard_manager_save_frame)
10375 (x_clipboard_manager_save_all): New functions.
10376 (Fx_clipboard_manager_save): Lisp function deleted.
10377
10378 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
10379 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
10380
10381 * xterm.h: Update prototype.
10382
5ba6571d
WX
103832011-05-28 William Xu <william.xwl@gmail.com>
10384
10385 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
10386 exiting (Bug#8239).
10387
3eaff834
JM
103882011-05-28 Jim Meyering <meyering@redhat.com>
10389
e1900994 10390 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
10391 * fns.c (to_uchar): Define.
10392 (crypto_hash_function): Use it to convert some newly-signed
10393 variables to unsigned, to avoid sign-extension bugs. For example,
10394 without this change, (md5 "truc") would evaluate to
10395 45723a2aff78ff4fff7fff1114760e62 rather than the expected
10396 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 10397 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 10398
0f6990a7
PE
103992011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10400
10401 Integer overflow fixes.
c8a9ca5a 10402
08686060
PE
10403 * dbusbind.c: Serial number integer overflow fixes.
10404 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
10405 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
10406 to hold a serial number that is too large for a fixnum.
10407 (Fdbus_method_return_internal, Fdbus_method_error_internal):
10408 Check for serial numbers out of range. Decode any serial number
59568bf0 10409 that was so large that it became a float. (Bug#8722)
08686060 10410
2d1fc3c7
PE
10411 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
10412 (Fdbus_call_method, Fdbus_call_method_asynchronously):
10413 Use XFASTINT rather than XUINT when numbers are nonnegative.
10414 (xd_append_arg, Fdbus_method_return_internal):
10415 (Fdbus_method_error_internal): Likewise. Also, for unsigned
10416 arguments, check that Lisp number is nonnegative, rather than
59568bf0 10417 silently wrapping negative numbers around. (Bug#8722)
30217ff0 10418 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 10419 (Bug#8722)
2d1fc3c7 10420
c8a9ca5a
PE
10421 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
10422
519e1d69
PE
10423 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
10424
6df6ae42 10425 ccl: Add integer overflow checks.
30569699
PE
10426 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
10427 (IN_INT_RANGE): New macros.
10428 (ccl_driver): Use them to check for integer overflow when
10429 decoding a CCL program. Many of the new checks are whether XINT (x)
10430 fits in int; it doesn't always, on 64-bit hosts. The new version
10431 doesn't catch all possible integer overflows, but it's an
847044ea 10432 improvement. (Bug#8719)
30569699 10433
c11285dc
PE
10434 * alloc.c (make_event_array): Use XINT, not XUINT.
10435 There's no need for unsigned here.
10436
fdccd48e
PE
10437 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
10438 This follows up to the 2011-05-06 change that substituted uintptr_t
10439 for EMACS_INT. This case wasn't caught back then.
10440
37910ab2
PE
10441 Rework Fformat to avoid integer overflow issues.
10442 * editfns.c: Include <float.h> unconditionally, as it's everywhere
10443 now (part of C89). Include <verify.h>.
10444 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
10445 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
10446 (Fformat): Avoid the prepass trying to compute sizes; it was only
10447 approximate and thus did not catch overflow reliably. Instead, walk
10448 through the format just once, formatting and computing sizes as we go,
10449 checking for integer overflow at every step, and allocating a larger
10450 buffer as needed. Keep track separately whether the format is
10451 multibyte. Keep only the most-recently calculated precision, rather
10452 than them all. Record whether each argument has been converted to
10453 string. Use EMACS_INT, not int, for byte and char and arg counts.
10454 Support field widths and precisions larger than INT_MAX. Avoid
10455 sprintf's undefined behavior with conversion specifications such as %#d
10456 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
10457 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
10458 formatting out-of-range floating point numbers with int
9173deec 10459 formats. (Bug#8668)
37910ab2 10460
2e6578fb
PE
10461 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
10462
0ae6bdee
PE
10463 * data.c: Avoid integer truncation in expressions involving floats.
10464 * data.c: Include <intprops.h>.
10465 (arith_driver): When there's an integer overflow in an expression
10466 involving floating point, convert the integers to floating point
10467 so that the resulting value does not suffer from catastrophic
10468 integer truncation. For example, on a 64-bit host (* 4
10469 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
10470 Do not rely on undefined behavior after integer overflow.
10471
de883a70
PE
10472 merge count_size_as_multibyte, parse_str_to_multibyte
10473 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 10474 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
10475 Check for integer overflow.
10476 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
10477 since it's now a duplicate of the other. This is more of
10478 a character than a buffer op, so better that it's in character.c.
10479 * fns.c, print.c: Adjust to above changes.
10480
2ff916cb
PE
104812011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
10482
10483 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
10484
f1b54466
PE
104852011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10486
fb1ac845
PE
10487 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10488 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
10489 (x_clipboard_manager_save): Now static.
10490 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
10491
f1b54466
PE
10492 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10493 (crypto_hash_function): Now static.
10494 Fix pointer signedness problems. Avoid unnecessary initializations.
10495
a9f737ee
CY
104962011-05-27 Chong Yidong <cyd@stupidchicken.com>
10497
10498 * termhooks.h (Vselection_alist): Make it terminal-local.
10499
10500 * terminal.c (create_terminal): Initialize it.
10501
10502 * xselect.c: Support for clipboard managers.
10503 (Vselection_alist): Move to termhooks.h as terminal-local var.
10504 (LOCAL_SELECTION): New macro.
10505 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
10506 (symbol_to_x_atom): Remove gratuitous arg.
10507 (x_handle_selection_request, lisp_data_to_selection_data)
10508 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
10509 (x_own_selection, x_get_local_selection, x_convert_selection):
10510 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
10511 (some_frame_on_display): Delete unused function.
10512 (Fx_own_selection_internal, Fx_get_selection_internal)
10513 (Fx_disown_selection_internal, Fx_selection_owner_p)
10514 (Fx_selection_exists_p): New optional frame arg.
10515 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
10516 (x_handle_selection_clear): Don't treat other terminals with the
10517 same keyboard specially. Use the terminal-local Vselection_alist.
10518 (x_clear_frame_selections): Use Frun_hook_with_args.
10519
10520 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
10521
10522 * xterm.h: Add support for those atoms.
10523
e067f0c1
CY
105242011-05-26 Chong Yidong <cyd@stupidchicken.com>
10525
10526 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
10527 (converted_selections, conversion_fail_tag): New global variables.
10528 (x_selection_request_lisp_error): Free the above.
10529 (x_get_local_selection): Remove unnecessary code.
10530 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
10531 of converted selections stored in converted_selections.
10532 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
10533 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
10534 (x_convert_selection): New function.
10535 (x_handle_selection_event): Simplify.
10536 (x_get_foreign_selection): Don't ignore incoming requests while
10537 waiting for an answer; this will fail when we implement
10538 SAVE_TARGETS, and seems unnecessary anyway.
10539 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
10540 (Vx_sent_selection_functions): Doc fix.
10541
0f4aebc0
LL
105422011-05-26 Leo Liu <sdl.web@gmail.com>
10543
10544 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
10545
e61124cd
YM
105462011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10547
10548 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
10549
10550 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
10551 for fringe update if it has periodic bitmap.
ac389d0c 10552 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
10553 and fringe_bitmap_periodic_p.
10554
10555 * fringe.c (get_fringe_bitmap_data): New function.
10556 (draw_fringe_bitmap_1, update_window_fringes): Use it.
10557 (update_window_fringes): Record periodicity of fringe bitmap in glyph
10558 row. Mark glyph row for fringe update if periodicity changed.
10559
10560 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
10561 for fringe update unless it has periodic bitmap.
10562
f16d9837
KH
105632011-05-25 Kenichi Handa <handa@m17n.org>
10564
10565 * xdisp.c (get_next_display_element): Set correct it->face_id for
10566 a static composition.
10567
e1b90ef6
LL
105682011-05-24 Leo Liu <sdl.web@gmail.com>
10569
10570 * deps.mk (fns.o):
10571 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
10572
10573 * fns.c (crypto_hash_function, Fsha1): New function.
10574 (Fmd5): Use crypto_hash_function.
10575 (syms_of_fns): Add Ssha1.
10576
7400048f
PE
105772011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10578
10579 * gnutls.c: Remove unused macros.
10580 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
10581 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
10582 Remove macros that are defined and never used.
10583 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
10584
abb71cf4
CY
105852011-05-22 Chong Yidong <cyd@stupidchicken.com>
10586
10587 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
10588 (Fx_get_selection_internal): Minor cleanup.
10589 (Fx_own_selection_internal): Rename arguments for consistency with
10590 select.el.
10591
6307db39
PE
105922011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10593
10594 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
10595
f3d4e0a4
CY
105962011-05-22 Chong Yidong <cyd@stupidchicken.com>
10597
10598 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
10599
4d8ade89
YM
106002011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10601
10602 * dispnew.c (scrolling_window): Don't exclude the case that the
10603 last enabled row in the desired matrix touches the bottom boundary.
10604
32078c8d
GM
106052011-05-21 Glenn Morris <rgm@gnu.org>
10606
10607 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
10608 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
10609 and add some more files.
32078c8d 10610
7285dc67
EZ
106112011-05-20 Eli Zaretskii <eliz@gnu.org>
10612
10613 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
10614 report_file_error introduced by the change from 2011-05-07.
10615
89d1bd22
PE
106162011-05-20 Paul Eggert <eggert@cs.ucla.edu>
10617
10618 * systime.h (Time): Define only if emacs is defined.
10619 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
10620 where the include path doesn't have X11/X.h by default. See
10621 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
10622
cd394be1 106232011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
10624
10625 * composite.c (find_automatic_composition): Fix previous change.
10626
b9704ad9
GM
106272011-05-20 Glenn Morris <rgm@gnu.org>
10628
10629 * lisp.mk: New file, split from Makefile.in.
10630 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
10631 (shortlisp): Remove.
10632 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
10633
4a720484
GM
106342011-05-19 Glenn Morris <rgm@gnu.org>
10635
10636 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
10637 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
10638 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
10639 (lisp): Set the order to that of loadup.el.
10640 (shortlisp): Make it a copy of $lisp.
10641 (SOME_MACHINE_LISP): Remove.
10642 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
10643 Use just $shortlisp, not $SOME_MACHINE_LISP too.
10644
a28d4396
KH
106452011-05-18 Kenichi Handa <handa@m17n.org>
10646
10647 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
10648 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
10649 (find_automatic_composition): Mostly rewrite for efficiency.
10650
a2b1fa8e
JB
106512011-05-18 Juanma Barranquero <lekktu@gmail.com>
10652
10653 * makefile.w32-in: Update dependencies.
10654
8e1f5610
CS
106552011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
10656
10657 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 10658 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 10659
7025ee00 106602011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 10661
cdfa6eab
PE
10662 Fix some integer overflow issues, such as string length overflow.
10663
06d6db33
PE
10664 * insdel.c (count_size_as_multibyte): Check for string overflow.
10665
2b4560a8
PE
10666 * character.c (lisp_string_width): Check for string overflow.
10667 Use EMACS_INT, not int, for string indexes and lengths; in
10668 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
10669 the resulting string length overflows an EMACS_INT; instead,
10670 report a string overflow if no precision given. When checking for
10671 precision exhaustion, use a check that cannot possibly have
10672 integer overflow. (Bug#8675)
10673 * character.h (lisp_string_width): Adjust to new signature.
10674
cb93f9be
PE
10675 * alloc.c (string_overflow): New function.
10676 (Fmake_string): Use it. This doesn't change behavior, but saves
10677 a few bytes and will simplify future changes.
10678 * character.c (string_escape_byte8): Likewise.
10679 * lisp.h (string_overflow): New decl.
10680
1a1f3366
PE
10681 Fixups, following up to the user-interface timestamp change.
10682 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
10683 for UI timestamps, instead of unsigned long.
9fbd6841
PE
10684 * msdos.c (mouse_get_pos): Likewise.
10685 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
10686 * w32gui.h (Time): Define by including "systime.h" rather than by
10687 declaring it ourselves. (Bug#8664)
10688
d4e3e4d3
PE
10689 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
10690 * image.c (clear_image_cache): Likewise.
10691
f6a24d19
PE
10692 * term.c (term_mouse_position): Don't assume time_t wraparound.
10693
08dc5ae6
PE
10694 Be more systematic about user-interface timestamps.
10695 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
10696 and sometimes 'EMACS_UINT', to represent these timestamps.
10697 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
10698 This makes the code easier to follow, and makes it easier to catch
10699 integer overflow bugs such as Bug#8664.
10700 * frame.c (Fmouse_position, Fmouse_pixel_position):
10701 Use Time, not unsigned long, for user-interface timestamps.
10702 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
10703 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
10704 * keyboard.h (last_event_timestamp): Likewise.
10705 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
10706 * menu.h (xmenu_show): Likewise.
10707 * term.c (term_mouse_position): Likewise.
10708 * termhooks.h (struct input_event.timestamp): Likewise.
10709 (struct terminal.mouse_position_hook): Likewise.
10710 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
10711 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
10712 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
10713 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
10714 what it was before.
10715 * menu.h, termhooks.h: Include "systime.h", for Time.
10716
8e55734a
PE
10717 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
10718 Don't assume that the difference between two unsigned long values
10719 can fit into an integer. At this point, we know button_down_time
10720 <= event->timestamp, so the difference must be nonnegative, so
10721 there's no need to cast the result if double-click-time is
10722 nonnegative, as it should be; check that it's nonnegative, just in
10723 case. This bug is triggered when events are more than 2**31 ms
86db42d2 10724 apart (about 25 days). (Bug#8664)
8e55734a 10725
841f1b75 10726 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 10727 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 10728
3e26f69c
PE
10729 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
10730 that always fit in int. Use a sentinel instead of a counter, to
10731 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
10732 * frame.h (struct frame): Use int for menu_bar_items_used
10733 instead of EMACS_INT, since it always fits in int.
3e26f69c 10734
5cc152c0
PE
10735 * menu.c (grow_menu_items): Check for int overflow.
10736
d89eb65e
PE
10737 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
10738
5235bd3e
PE
10739 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
10740 Before, the code was not consistent. These values cannot exceed
10741 2**31 - 1 so there's no need to make them unsigned.
10742 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
10743 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
10744 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
10745 as modifiers.
10746 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
10747
bc827e23
PE
10748 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
10749 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
10750 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
10751 presumably because the widths might not match.
10752
78eb494e
PE
10753 * window.c (size_window): Avoid needless test at loop start.
10754
04f2d78b
CB
107552011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
10756
10757 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
10758
d2fc7e3d 107592011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
10760
10761 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
10762
d2fc7e3d 107632011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
10764
10765 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
10766 `width' to `bar_area_x' and `bar_area_width', respectively.
10767 (x_scroll_run): Take account of fringe background extension.
10768
04f2d78b
CB
10769 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
10770 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
10771 `bar_area_width', respectively.
10772 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
10773 background extension.
10774
79b70037
GM
107752011-05-10 Jim Meyering <meyering@redhat.com>
10776
10777 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
10778
2f142cc5
JB
107792011-05-10 Juanma Barranquero <lekktu@gmail.com>
10780
10781 * image.c (Finit_image_library): Return t for built-in image types,
10782 like pbm and xbm. (Bug#8640)
10783
57679c86
AS
107842011-05-09 Andreas Schwab <schwab@linux-m68k.org>
10785
10786 * w32menu.c (set_frame_menubar): Fix submenu allocation.
10787
888c9e86
EZ
107882011-05-07 Eli Zaretskii <eliz@gnu.org>
10789
b0512a1d
EZ
10790 * w32console.c (Fset_screen_color): Doc fix.
10791 (Fget_screen_color): New function.
10792 (syms_of_ntterm): Defsubr it.
10793
7285dc67
EZ
10794 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
10795 unlink the temporary file if Fcall_process didn't create it in the
10796 first place.
10797 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
10798 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
10799 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
10800 cue to call_process_cleanup not to close that handle.
10801
4d3fcc8e
BK
108022011-05-07 Ben Key <bkey76@gmail.com>
10803
10804 * makefile.w32-in: The bootstrap-temacs rule now makes use of
10805 one of two shell specific rules, either bootstrap-temacs-CMD or
10806 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
10807 to the previous implementation of the bootstrap-temacs rule.
10808 The bootstrap-temacs-CMD rule is similar to the previous
10809 implementation of the bootstrap-temacs rule except that it
10810 makes use of the ESC_CFLAGS variable instead of the CFLAGS
10811 variable.
10812
10813 These changes, along with some changes to nt/configure.bat,
10814 nt/gmake.defs, and nt/nmake.defs, are required to extend my
10815 earlier fix to add support for --cflags and --ldflags options
10816 that include quotes so that it works whether make uses cmd or
10817 sh as the shell.
10818
b4289b64
MA
108192011-05-06 Michael Albinus <michael.albinus@gmx.de>
10820
10821 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
10822 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
10823 is a constant.
10824 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
10825 a string. Handle both cases.
10826 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
10827 (Fdbus_register_method): Use Qinvalid_function.
10828
af4c0e28
JB
108292011-05-06 Juanma Barranquero <lekktu@gmail.com>
10830
10831 * makefile.w32-in: Update dependencies.
10832 (LISP_H): Add inttypes.h and stdin.h.
10833 (PROCESS_H): Add unistd.h.
10834
c51453d9
EZ
108352011-05-06 Eli Zaretskii <eliz@gnu.org>
10836
10837 * lread.c: Include limits.h (fixes the MS-Windows build broken by
10838 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
10839
8ff0ac3c 108402011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 10841
4c4b566b
PE
10842 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
10843
aab2b9b5
PE
10844 * term.c (vfatal): Remove stray call to va_end.
10845 It's not needed and the C Standard doesn't allow it here anyway.
10846
c378da0b
PE
10847 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
10848 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
10849
288b08c7
PE
10850 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
10851 bytes.
10852
e3601888
PE
10853 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
10854
db6c0e74
PE
10855 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
10856
dd5963ea
PE
10857 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
10858
88c9450f
PE
10859 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
10860
2f9442b8
PE
10861 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
10862
c032b5f8
PE
10863 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
10864 * charset.c (Fdefine_charset_internal): Don't initialize
10865 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 10866 32-bit int (Bug#8600).
a108c10b
PE
10867
10868 * lread.c (read_integer): Be more consistent with string-to-number.
10869 Use string_to_number to do the actual conversion; this avoids
10870 rounding errors and fixes some other screwups. Without this fix,
10871 for example, #x1fffffffffffffff was misread as -2305843009213693952.
10872 (digit_to_number): Move earlier, for benefit of read_integer.
10873 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 10874 not a digit in any supported base. (Bug#8602)
a108c10b 10875
ad5f9eea
PE
10876 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
10877
aec1708a
PE
10878 * dispnew.c (scrolling_window): Return 1 if we scrolled,
10879 to match comment at start of function. This also removes a
10880 GCC warning about overflow in a 32+64-bit port.
10881
47be4ab5
PE
10882 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
10883
371cac43
PE
10884 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
10885 Reported by Stefan Monnier in
10886 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
10887 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10888 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 10889
d01a7826
PE
10890 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
10891 (EMACS_UINTPTR): Likewise, with uintptr_t.
10892
7fd47d5c
PE
10893 * lisp.h: Prefer 64-bit EMACS_INT if available.
10894 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
10895 on 32-bit hosts that have 64-bit int, so that they can access
10896 large files.
122b0c86
PE
10897 However, temporarily disable this change unless the temporary
10898 symbol WIDE_EMACS_INT is defined.
7fd47d5c 10899
8727937b
PE
10900 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
10901
8ac068ac
PE
10902 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
10903 This removes an assumption that EMACS_INT and long are the same
10904 width as pointers. The assumption is true for Emacs porting targets
10905 now, but we want to make other targets possible.
10906 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
10907 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
10908 In the rest of the code, change types of integers that hold casted
10909 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
10910 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
10911 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
10912 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
10913 No need to cast type when ORing.
10914 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
10915 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
10916 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
10917 assume EMACS_INT is the same width as char *.
10918 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
10919 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
10920 Remove no-longer-needed casts.
10921 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
10922 (xg_tool_bar_help_callback, xg_make_tool_item):
10923 Use EMACS_INTPTR to hold an integer
10924 that will be cast to void *; this can avoid a GCC warning
10925 if EMACS_INT is not the same width as void *.
10926 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
10927 * xdisp.c (display_echo_area_1, resize_mini_window_1):
10928 (current_message_1, set_message_1):
10929 Use a local to convert to proper width without a cast.
10930 * xmenu.c (dialog_selection_callback): Likewise.
10931
ede49d71
PE
10932 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
10933 Also, don't assume VALBITS / RAND_BITS is less than 5,
10934 and don't rely on undefined behavior when shifting a 1 left into
10935 the sign bit.
10936 * lisp.h (get_random): Change signature to match.
10937
2f30ecd0
PE
10938 * lread.c (hash_string): Use size_t, not int, for hash computation.
10939 Normally we prefer signed values; but hashing is special, because
10940 it's better to use unsigned division on hash table sizes so that
10941 the remainder is nonnegative. Also, size_t is the natural width
10942 for hashing into memory. The previous code used 'int', which doesn't
10943 retain enough info to hash well into very large tables.
10944 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
10945
2a866e7b
PE
10946 * dbusbind.c: Don't possibly lose pointer info when converting.
10947 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10948 Use XPNTR rather than XHASH, so that the high-order bits of
10949 the pointer aren't lost when converting through void *.
10950
51639eac
PE
10951 * eval.c (Fautoload): Don't double-shift a pointer.
10952
92394119
PE
10953 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
10954
dbdb9a7c
JB
109552011-05-06 Juanma Barranquero <lekktu@gmail.com>
10956
10957 * gnutls.c (DEF_GNUTLS_FN):
10958 * image.c (DEF_IMGLIB_FN): Make function pointers static.
10959
db7a0b4f
AS
109602011-05-05 Andreas Schwab <schwab@linux-m68k.org>
10961
10962 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
10963 marker. (Bug#8610)
10964
cd394be1 109652011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
10966
10967 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
10968 New version that can reserve upto 2GB of heap space.
10969
f7ff1b0f 109702011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
10971
10972 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
10973
639c109b
TZ
109742011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
10975
10976 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
10977 `gnutls_certificate_set_x509_key_file'.
10978
d2127135
JB
109792011-05-05 Juanma Barranquero <lekktu@gmail.com>
10980
10981 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
10982 Update dependencies.
10983
e968f4f3
JB
109842011-05-04 Juanma Barranquero <lekktu@gmail.com>
10985
10986 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
10987 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
10988 Remove unused parameter `fildes'.
10989 * process.c (read_process_output, send_process): Don't pass it.
10990
84d358f0
JB
109912011-05-04 Juanma Barranquero <lekktu@gmail.com>
10992
10993 Fix previous change: the library cache is defined in w32.c.
10994 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
10995 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
10996
0898ca10
JB
109972011-05-04 Juanma Barranquero <lekktu@gmail.com>
10998
10999 Implement dynamic loading of GnuTLS on Windows.
11000
11001 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
11002 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
11003 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11004 Declare.
11005
11006 * gnutls.c (Qgnutls_dll): Define.
11007 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
11008 (gnutls_*): Declare function pointers.
11009 (init_gnutls_functions): New function to initialize function pointers.
11010 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
11011 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
11012 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11013 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
11014 (emacs_gnutls_write, emacs_gnutls_read)
11015 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
11016 (Fgnutls_available_p): New function.
11017 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
11018 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
11019 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
11020
11021 * image.c: Include w32.h.
11022 (Vimage_type_cache): Delete.
11023 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
11024 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
11025 (w32_delayed_load): Move to w32.c.
11026
11027 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
11028
11029 * w32.c (QCloaded_from, Vlibrary_cache): Define.
11030 (w32_delayed_load): Move from image.c. When loading a library, record
11031 its filename in the :loaded-from property of the library id.
11032 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
11033 Initialize and staticpro them.
11034 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
11035
11036 * process.c: Include lisp.h before w32.h, not after.
11037 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
11038 instead of gnutls_record_check_pending.
11039
11040 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
11041
ff4de4aa
TZ
110422011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
11043
11044 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
11045 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
11046 as passed in.
11047
abe95abb
JD
110482011-05-03 Jan Djärv <jan.h.d@swipnet.se>
11049
11050 * xterm.c (x_set_frame_alpha): Do not set property on anything
11051 else than FRAME_X_OUTER_WINDOW (Bug#8608).
11052
e16e55d4
JB
110532011-05-02 Juanma Barranquero <lekktu@gmail.com>
11054
11055 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
11056
bafcf6a5
JB
110572011-05-02 Juanma Barranquero <lekktu@gmail.com>
11058
11059 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
11060 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
11061 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
11062 (gnutls_global_initialized, Qgnutls_bootprop_priority)
11063 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
11064 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
11065 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
11066 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
11067 (Qgnutls_bootprop_callbacks_verify): Make static.
11068
e7a6747f
AS
110692011-05-01 Andreas Schwab <schwab@linux-m68k.org>
11070
19ed11ba
AS
11071 * callproc.c: Indentation fixup.
11072
e7a6747f 11073 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
11074 (wait_for_termination, interruptible_wait_for_termination):
11075 Move after wait_for_termination_1.
e7a6747f 11076
1ef14cb4
LMI
110772011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
11078
11079 * sysdep.c (interruptible_wait_for_termination): New function
11080 which is like wait_for_termination, but allows keyboard
11081 interruptions.
11082
11083 * callproc.c (Fcall_process): Add (:file "file") as an option for
11084 the STDOUT buffer.
11085 (Fcall_process_region): Ditto.
11086
330d880c
EZ
110872011-04-30 Eli Zaretskii <eliz@gnu.org>
11088
8db90b73
EZ
11089 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
11090 rather than `XVECTOR (FOO)->size'.
11091
330d880c
EZ
11092 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
11093 inttypes.h, as a gnulib replacement is used if it not available in
11094 system headers.
11095
15cbd324
EZ
110962011-04-21 Eli Zaretskii <eliz@gnu.org>
11097
11098 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
11099 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
11100 of MOST_POSITIVE_FIXNUM. (Bug#8528)
11101
11102 * coding.c (coding_alloc_by_realloc): Error out if destination
11103 will grow beyond MOST_POSITIVE_FIXNUM.
11104 (decode_coding_emacs_mule): Abort if there isn't enough place in
11105 charbuf for the composition carryover bytes. Reserve an extra
11106 space for up to 2 characters produced in a loop.
11107 (decode_coding_iso_2022): Abort if there isn't enough place in
11108 charbuf for the composition carryover bytes.
11109
111102011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 11111
ae940cca
EZ
11112 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
11113 aborting when %lld or %lll format is passed.
11114 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
11115 %llo or %llx format is passed. (Bug#8545)
11116
03ab8921
EZ
11117 * window.c (window_scroll_line_based): Use a marker instead of
11118 simple variables to record original value of point. (Bug#7952)
11119
afda1437
EZ
11120 * doprnt.c (doprnt): Fix the case where a multibyte sequence
11121 produced by %s or %c overflows available buffer space. (Bug#8545)
11122
f76dee0c
PE
111232011-04-28 Paul Eggert <eggert@cs.ucla.edu>
11124
11125 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 11126 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 11127
fdc5744d
JB
111282011-04-28 Juanma Barranquero <lekktu@gmail.com>
11129
11130 * w32.c (init_environment): Warn about defaulting HOME to C:\.
11131
638f053a
JB
111322011-04-28 Juanma Barranquero <lekktu@gmail.com>
11133
11134 * keyboard.c (Qdelayed_warnings_hook): Define.
11135 (command_loop_1): Run `delayed-warnings-hook'
11136 if Vdelayed_warnings_list is non-nil.
11137 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
11138 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
11139
d178f871
EZ
111402011-04-28 Eli Zaretskii <eliz@gnu.org>
11141
11142 * doprnt.c (doprnt): Don't return value smaller than the buffer
11143 size if the message was truncated. (Bug#8545).
11144
b124fd93
JB
111452011-04-28 Juanma Barranquero <lekktu@gmail.com>
11146
11147 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
11148 (Fx_window_property): #if-0 the whole functions, not just the bodies.
11149
e810457d
PE
111502011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11151
11152 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
11153
ea51cceb
JB
111542011-04-27 Juanma Barranquero <lekktu@gmail.com>
11155
11156 * makefile.w32-in: Update dependencies.
11157
94dcfacf
EZ
111582011-04-27 Eli Zaretskii <eliz@gnu.org>
11159
11160 Improve `doprnt' and its usage. (Bug#8545)
11161 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
11162 `format_end'. Remove support for %l as a conversion specifier.
11163 Don't use xrealloc. Improve diagnostics when the %l size modifier
11164 is used. Update the commentary.
11165
11166 * eval.c (verror): Simplify calculation of size_t.
11167
11168 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
11169 messages.
11170
f61f41d7
PE
111712011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
11172
11173 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
11174 change.
11175
96fb4434
PE
111762011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11177
11178 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
11179 This makes this file independent of the recent pseudovector change.
11180
671875da 111812011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 11182
69e9b5a3
PE
11183 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
11184
b5f869a7 11185 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 11186 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 11187 Remove unused local.
c8926152 11188 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 11189
841a1577 11190 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
11191 GCC 4.6.0 optimizes based on type-based alias analysis.
11192 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
11193 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
11194 != &v->size, and therefore "v->size = 1; b->size = 2; return
11195 v->size;" must therefore return 1. This assumption is incorrect
11196 for Emacs, since it type-puns struct Lisp_Vector * with many other
11197 types. To fix this problem, this patch adds a new type struct
f904488f 11198 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
11199 and pseudovectors, and helps optimizing compilers not get fooled
11200 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
11201 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
11202 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
11203 the size member.
eab3844f
PE
11204 (XSETPVECTYPE): Rewrite in terms of new macro.
11205 (XSETPVECTYPESIZE): New macro, specifying both type and size.
11206 This is a bit clearer, and further avoids the possibility of
11207 undesirable aliasing.
11208 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 11209 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
11210 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
11211 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
11212 (ASIZE): Now uses header.size rather than size.
11213 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
11214 to avoid the hassle of writing XVECTOR (foo)->header.size.
11215 (struct vectorlike_header): New type.
eab3844f
PE
11216 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
11217 object, to help avoid aliasing.
11218 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
11219 (SUBRP): Likewise, since Lisp_Subr is a special case.
11220 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
11221 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
11222 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 11223 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
11224 changed to be "header.size" and "header.next".
11225 * buffer.h (struct buffer): Likewise.
11226 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
11227 * frame.h (struct frame): Likewise.
11228 * process.h (struct Lisp_Process): Likewise.
11229 * termhooks.h (struct terminal): Likewise.
11230 * window.c (struct save_window_data, struct saved_window): Likewise.
11231 * window.h (struct window): Likewise.
11232 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
11233 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
11234 * buffer.c (init_buffer_once): Likewise.
11235 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
11236 special case.
11237 * process.c (Fformat_network_address): Use local var for size,
11238 for brevity.
11239
0df1eac5
PE
11240 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
11241
847ab9d1 11242 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
11243 * data.c (atof): Remove decl; no longer used or needed.
11244 (digit_to_number): Move to lread.c.
11245 (Fstring_to_number): Use new string_to_number function, to be
11246 consistent with how the Lisp reader treats infinities and NaNs.
11247 Do not assume that floating-point numbers represent EMACS_INT
11248 without losing information; this is not true on most 64-bit hosts.
11249 Avoid double-rounding errors, by insisting on integers when
11250 parsing non-base-10 numbers, as the documentation specifies.
11251 * lisp.h (string_to_number): New decl, replacing ...
11252 (isfloat_string): Remove.
bc0a5c13 11253 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 11254 (read1): Do not accept +. and -. as integers; this
452f4150
PE
11255 appears to have been a coding error. Similarly, do not accept
11256 strings like +-1e0 as floating point numbers. Do not report
11257 overflow for integer overflows unless the base is not 10 which
11258 means we have no simple and reliable way to continue.
11259 Break out the floating-point parsing into a new
11260 function string_to_number, so that Fstring_to_number parses
11261 floating point numbers consistently with the Lisp reader.
04f2d78b 11262 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
11263 (E_CHAR, EXP_INT): Remove, replacing with ...
11264 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
11265 (string_to_number): New function, replacing isfloat_string.
11266 This function checks for valid syntax and produces the resulting
11267 Lisp float number too. Rework it so that string-to-number
bc0a5c13 11268 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
11269 so that overflow for non-base-10 numbers is reported only when
11270 there's no portable and simple way to convert to floating point.
452f4150 11271
67769ffc
PE
11272 * textprop.c (set_text_properties_1): Rewrite for clarity,
11273 and to avoid GCC warning about integer overflow.
11274
c20db43f
PE
11275 * intervals.h (struct interval): Use EMACS_INT for members
11276 where EMACS_UINT might cause problems. See
11277 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
11278 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
11279 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
11280 All uses changed.
37aa2f85
PE
11281 (offset_intervals): Tell GCC not to worry about length overflow
11282 when negating a negative length.
c20db43f 11283
2538aa2f
PE
11284 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
11285 (overrun_check_free): Likewise.
11286
f2d3008d
PE
11287 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
11288 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
11289 word size.
11290
ec8df744
PE
11291 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11292 (gnutls_make_error): Rename local to avoid shadowing.
11293 (gnutls_emacs_global_deinit): ifdef out; not used.
11294 (Fgnutls_boot): Use const for pointer to readonly storage.
11295 Comment out unused local. Fix pointer signedness problems.
11296
640ee02d
PE
11297 * lread.c (openp): Don't stuff size_t into an 'int'.
11298 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
11299 about possible signed overflow.
11300
6048fb2a
PE
11301 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11302 (GDK_KEY_g): Don't define if already defined.
11303 (xg_prepare_tooltip): Avoid pointer signedness problem.
11304 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
11305
fa3c87e1
PE
11306 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
11307 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
11308
2172544b
PE
11309 * xfns.c (Fx_window_property): Simplify a bit,
11310 to make a bit faster and to avoid GCC 4.6.0 warning.
11311 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
11312
9b821a21
PE
11313 * fns.c (internal_equal): Don't assume size_t fits in int.
11314
3c616cfa
PE
11315 * alloc.c (compact_small_strings): Tighten assertion a little.
11316
c2982e87
PE
11317 Replace pEd with more-general pI, and fix some printf arg casts.
11318 * lisp.h (pI): New macro, generalizing old pEd macro to other
11319 conversion specifiers. For example, use "...%"pI"d..." rather
11320 than "...%"pEd"...".
11321 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 11322 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
11323 * alloc.c (check_pure_size): Don't overflow by converting size to int.
11324 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
11325 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
11326 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
11327 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
11328 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
11329 64-bit hosts.
11330 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
11331 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
11332 * print.c (safe_debug_print, print_object): Likewise.
11333 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
11334 to int.
6f04d126
PE
11335 Use pI instead of if-then-else-abort. Use %p to avoid casts,
11336 avoiding the 0 flag, which is not portable.
c2982e87
PE
11337 * process.c (Fmake_network_process): Use pI to avoid cast.
11338 * region-cache.c (pp_cache): Likewise.
11339 * xdisp.c (decode_mode_spec): Likewise.
11340 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
11341 behavior on 64-bit hosts with printf arg.
6f04d126 11342 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
11343 (x_stop_queuing_selection_requests): Likewise.
11344 (x_get_window_property): Don't truncate byte count to an 'int'
11345 when tracing.
0b432f21 11346
5e073ec7
PE
11347 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
11348 here, since it parses constructs like leading '-' and spaces,
11349 which are not wanted; and it overflows with large numbers.
11350 Instead, simply match F[0-9]+, which is what is wanted anyway.
11351
36372bf9
PE
11352 * alloc.c: Remove unportable assumptions about struct layout.
11353 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
11354 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
11355 (allocate_vectorlike, make_pure_vector): Use the new macros,
11356 plus offsetof, to remove unportable assumptions about struct layout.
11357 These assumptions hold on all porting targets that I know of, but
11358 they are not guaranteed, they're easy to remove, and removing them
11359 makes further changes easier.
11360
0b432f21
PE
11361 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
11362 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
11363 (string_overrun_cookie): Now const. Use initializers that
11364 don't formally overflow signed char, to avoid warnings.
000098c1
PE
11365 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
11366 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
11367 (allocate_buffer): Don't assume sizeof (struct buffer) is a
11368 multiple of sizeof (EMACS_INT); it need not be, if
11369 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 11370 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 11371
895009e1
JB
113722011-04-26 Juanma Barranquero <lekktu@gmail.com>
11373
11374 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
11375
6a7a1b0b
TZ
113762011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
11377
11378 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 11379 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
11380 Reported by Paul Eggert <eggert@cs.ucla.edu>.
11381
841a1577 113822011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
11383
11384 * lisp.h (Qdebug): List symbol.
895009e1 11385 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
11386 * keyboard.c (debug-on-event): New variable.
11387 (handle_user_signal): Break into debugger when debug-on-event
11388 matches the current signal symbol.
11389
f2d3ba6f
DN
113902011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
11391
11392 * alloc.c (check_sblock, check_string_bytes)
11393 (check_string_free_list): Convert to standard C.
11394
42ce4c63
TZ
113952011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
11396
11397 * w32.c (emacs_gnutls_push): Fix typo.
11398
825cd63c
EZ
113992011-04-25 Eli Zaretskii <eliz@gnu.org>
11400
fb11d64d
EZ
11401 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
11402 "cast to pointer from integer of different size".
11403
825cd63c
EZ
11404 Improve doprnt and its use in verror. (Bug#8545)
11405 * doprnt.c (doprnt): Document the set of format control sequences
11406 supported by the function. Use SAFE_ALLOCA instead of always
11407 using `alloca'.
11408
11409 * eval.c (verror): Don't limit the buffer size at size_max-1, that
11410 is one byte too soon. Don't use xrealloc; instead xfree and
11411 xmalloc anew.
11412
e061a11b
TZ
114132011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
11414
11415 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
11416 callbacks stage.
11417
11418 * gnutls.c: Renamed global_initialized to
11419 gnutls_global_initialized. Added internals for the
11420 :verify-hostname-error, :verify-error, and :verify-flags
11421 parameters of `gnutls-boot' and documented those parameters in the
11422 docstring. Start callback support.
9173deec
JB
11423 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
11424 unless a fatal error occurred. Call gnutls_alert_send_appropriate
11425 on error. Return error code.
e061a11b
TZ
11426 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
11427 (emacs_gnutls_read): Likewise.
11428 (Fgnutls_boot): Return handshake error code.
11429 (emacs_gnutls_handle_error): New function.
11430 (wsaerror_to_errno): Likewise.
11431
11432 * w32.h (emacs_gnutls_pull): Add prototype.
11433 (emacs_gnutls_push): Likewise.
11434
11435 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
11436 (emacs_gnutls_push): Likewise.
11437
114382011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
11439
11440 * process.c (wait_reading_process_output): Check if GnuTLS
11441 buffered some data internally if no FDs are set for TLS
11442 connections.
11443
11444 * makefile.w32-in (OBJ2): Add gnutls.$(O).
11445 (LIBS): Link to USER_LIBS.
11446 ($(BLD)/gnutls.$(0)): New target.
11447
fa6996bc
EZ
114482011-04-24 Eli Zaretskii <eliz@gnu.org>
11449
eb35682e
EZ
11450 * xdisp.c (handle_single_display_spec): Rename the
11451 display_replaced_before_p argument into display_replaced_p, to
11452 make it consistent with the commentary. Fix typos in the
11453 commentary.
11454
e2ad650c
EZ
11455 * textprop.c (syms_of_textprop): Remove dead code.
11456 (copy_text_properties): Delete obsolete commentary about an
11457 interface that was deleted long ago. Fix typos in the description
11458 of arguments.
11459
1b2de274
EZ
11460 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
11461 to changes in oldXMenu/XMenu.h from 2011-04-16.
11462 <menu_help_message, prev_menu_help_message>: Constify.
11463 (IT_menu_make_room): menu->help_text is now `const char **';
11464 adjust.
11465
11466 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
11467 to changes in oldXMenu/XMenu.h from 2011-04-16.
11468 (struct XMenu): Declare `help_text' `const char **'.
11469
11470 * xfaces.c <Qunspecified>: Make extern again.
11471
11472 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 11473 required by POSIX.
1b2de274 11474
762b15be
EZ
11475 * doc.c (get_doc_string): Improve the format passed to `error'.
11476
11477 * doprnt.c (doprnt): Improve commentary.
11478
11479 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
11480
11481 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
11482 them with etags.
11483
f1052e5d
EZ
11484 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
11485 changes in globals.h immediately force recompilation.
762b15be
EZ
11486 (TAGS): Depend on $(CURDIR)/m/intel386.h and
11487 $(CURDIR)/s/ms-w32.h.
11488 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 11489
fa6996bc
EZ
11490 * character.c (Fchar_direction): Function deleted.
11491 (syms_of_character): Don't defsubr it.
11492 <char-direction-table>: Deleted.
11493
e6c3da20
EZ
114942011-04-23 Eli Zaretskii <eliz@gnu.org>
11495
11496 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
11497 * doprnt.c: Include limits.h.
11498 (SIZE_MAX): New macro.
04f2d78b
CB
11499 (doprnt): Return a size_t value. 2nd arg is now size_t.
11500 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
11501 Improve overflow protection. Support `l' modifier for integer
11502 conversions. Support %l conversion. Don't assume an EMACS_INT
11503 argument for integer conversions and for %c.
11504
11505 * lisp.h (doprnt): Restore prototype.
11506
11507 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
11508 $(SRC)/character.h.
11509
11510 * Makefile.in (base_obj): Add back doprnt.o.
11511
11512 * deps.mk (doprnt.o): Add back prerequisites.
11513 (callint.o): Depend on character.h.
11514
11515 * eval.c (internal_lisp_condition_case): Include the handler
11516 representation in the error message.
11517 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
11518 when breaking from the loop.
11519
11520 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
11521
11522 * callint.c (Fcall_interactively): When displaying error message
11523 about invalid control letter, pass the character's codepoint, not
11524 a pointer to its multibyte form. Improve display of the character
11525 in octal and display also its hex code.
11526
11527 * character.c (char_string): Use %x to display the (unsigned)
11528 codepoint of an invalid character, to avoid displaying a bogus
11529 negative value.
11530
11531 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
11532 `error', not SYMBOL_NAME itself.
11533
11534 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
11535 character arguments to `error'.
11536
11537 * charset.c (check_iso_charset_parameter): Fix incorrect argument
11538 to `error' in error message about FINAL_CHAR argument. Make sure
11539 FINAL_CHAR is a character, and use %c when it is passed as
11540 argument to `error'.
11541
4ffd0d6b 115422011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
11543
11544 * s/ms-w32.h (localtime): Redirect to sys_localtime.
11545
11546 * w32.c: Include <time.h>.
11547 (sys_localtime): New function.
11548
4ffd0d6b 115492011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
11550
11551 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
11552
4ffd0d6b 11553 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 11554
4ffd0d6b 115552011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 11556
4ffd0d6b
GM
11557 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
11558 zombies (Bug#8467).
aac0c6e3 11559
04c56954
EZ
115602011-04-19 Eli Zaretskii <eliz@gnu.org>
11561
11562 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
11563 gl_state.e_property when gl_state.object is Qt.
11564
11565 * insdel.c (make_gap_larger): Remove limitation of buffer size
11566 to <= INT_MAX.
11567
16a43933
CY
115682011-04-18 Chong Yidong <cyd@stupidchicken.com>
11569
11570 * xdisp.c (lookup_glyphless_char_display)
11571 (produce_glyphless_glyph): Handle cons cell entry in
11572 glyphless-char-display.
11573 (Vglyphless_char_display): Document it.
11574
11575 * term.c (produce_glyphless_glyph): Handle cons cell entry in
11576 glyphless-char-display.
11577
4581706e
CY
115782011-04-17 Chong Yidong <cyd@stupidchicken.com>
11579
11580 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
11581
11582 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
11583
11584 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
11585 definition for no-X builds.
11586
4887c6e2 115872011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 11588
fd35b6f9
PE
11589 Static checks with GCC 4.6.0 and non-default toolkits.
11590
5c1ccb01
PE
11591 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
11592
006c5daa
PE
11593 * process.c (keyboard_bit_set): Define only if SIGIO.
11594 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
11595 (send_process): Repair possible setjmp clobbering.
11596
efc736d3
PE
11597 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
11598
4e2fe2e6
PE
11599 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
11600
f97334a2
PE
11601 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
11602
4e75f29d
PE
11603 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
11604 Define only if needed.
11605
90efadd1
PE
11606 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
11607 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 11608 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 11609
3c647824
PE
11610 * dispextern.h (struct redisplay_interface): Rename param
11611 to avoid shadowing.
e264f262 11612 * termhooks.h (struct terminal): Likewise.
761383f4 11613 * xterm.c (xembed_send_message): Likewise.
3c647824 11614
b58c5c4a
PE
11615 * insdel.c (make_gap_smaller): Define only if
11616 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
11617
cad59032
PE
11618 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
11619 it.
11620
c339dc2e
PE
11621 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
11622 so that we aren't warned about unused symbols.
11623
91a3e27b
PE
11624 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
11625
399c71d3 11626 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 11627
8ffc96f5
PE
11628 * xfns.c (x_real_positions): Mark locals as initialized.
11629
eef9bc79
PE
11630 * xmenu.c (xmenu_show): Don't use uninitialized vars.
11631
098db9dd
PE
11632 * xterm.c: Fix problems found by static analysis with other toolkits.
11633 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
11634 (x_dispatch_event): Declare static if USE_GTK, and
11635 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 11636 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 11637 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
11638 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
11639 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 11640
eb18f6cc
PE
11641 * xmenu.c (menu_help_callback): Pointer type fixes.
11642 Use const pointers when pointing at readonly data. Avoid pointer
11643 signedness clashes.
11644 (FALSE): Remove unused macro.
11645 (update_frame_menubar): Remove unused decl.
11646
1fe72bf8
PE
11647 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
11648
60d9e1db
PE
11649 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
11650 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
11651 (single_menu_item): Rename local to avoid shadowing.
11652
39261c26
PE
11653 * keyboard.c (make_lispy_event): Remove unused local var.
11654
018c5e19
PE
11655 * frame.c, frame.h (x_get_resource_string): Bring this back, but
11656 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
11657
63d2b86e
PE
11658 * bitmaps: Change bitmaps from unsigned char back to the X11
11659 compatible char. Avoid the old compiler warnings about
11660 out-of-range initializers by using, for example, '\xab' rather
11661 than 0xab.
11662
aefd87e1
PE
11663 * xgselect.c (xgselect_initialize): Check vs interface
11664 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
11665
bf501fb9
PE
11666 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
11667
e9829fdf
PE
11668 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
11669 to read-only memory.
11670
1086c095
PE
11671 * fns.c (vector): Remove; this old hack is no longer needed.
11672
2baccd04 11673 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 11674 Remove unused var.
dde42981 11675 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 11676
72391843 11677 * xrdb.c (x_load_resources): Omit unused local.
3565b346 11678
436c16df 11679 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 11680 (x_window): Rename locals to avoid shadowing.
dc5ddd85 11681 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 11682
92bb796d 11683 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 11684 (x_term_init): Remove local to avoid shadowing.
92bb796d 11685
764430a3 11686 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
11687
11688 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
11689 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
11690
d1dfb56c
EZ
116912011-04-16 Eli Zaretskii <eliz@gnu.org>
11692
c4354cb4
EZ
11693 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
11694
d1dfb56c
EZ
11695 Fix regex.c, syntax.c and friends for buffers > 2GB.
11696 * syntax.h (struct gl_state_s): Declare character position members
11697 EMACS_INT.
11698
11699 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
11700
04f2d78b
CB
11701 * textprop.c (verify_interval_modification, interval_of):
11702 Declare arguments EMACS_INT.
d1dfb56c
EZ
11703
11704 * intervals.c (adjust_intervals_for_insertion): Declare arguments
11705 EMACS_INT.
11706
11707 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
11708
11709 * indent.c (Fvertical_motion): Local variable it_start is now
11710 EMACS_INT.
11711
11712 * regex.c (re_match, re_match_2, re_match_2_internal)
11713 (bcmp_translate, regcomp, regexec, print_double_string)
11714 (group_in_compile_stack, re_search, re_search_2, regex_compile)
11715 (re_compile_pattern, re_exec): Declare arguments and local
11716 variables `size_t' and `ssize_t' and return values `regoff_t', as
11717 appropriate.
11718 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
11719 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
11720 <compile_stack_type>: `size' and `avail' are now `size_t'.
11721
11722 * regex.h <regoff_t>: Use ssize_t, not int.
11723 (re_search, re_search_2, re_match, re_match_2): Arguments that
11724 specify buffer/string position and length are now ssize_t and
11725 size_t. Return type is regoff_t.
11726
613052cd
BK
117272011-04-16 Ben Key <bkey76@gmail.com>
11728
11729 * nsfont.m: Fixed bugs in ns_get_family and
11730 ns_descriptor_to_entity that were caused by using free to
11731 deallocate memory blocks that were allocated by xmalloc (via
11732 xstrdup). This caused Emacs to crash when compiled with
11733 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
11734 --enable-checking=xmallocoverrun). xfree is now used to
11735 deallocate these memory blocks.
11736
4170f62f 117372011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 11738
71b41406
PE
11739 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
11740
9587a89d
PE
11741 emacs_write: Accept and return EMACS_INT for sizes.
11742 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
11743 et seq.
11744 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
11745 Accept and return EMACS_INT.
11746 (emacs_gnutls_write): Return the number of bytes written on
11747 partial writes.
11748 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
11749 (emacs_read, emacs_write): Remove check for negative size, as the
11750 Emacs source code has been audited now.
9587a89d
PE
11751 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
11752 (emacs_read, emacs_write): Use it.
273a5f82
PE
11753 * process.c (send_process): Adjust to the new signatures of
11754 emacs_write and emacs_gnutls_write. Do not attempt to store
11755 a byte offset into an 'int'; it might overflow.
9587a89d 11756 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 11757
3e047f51
PE
11758 * sound.c: Don't assume sizes fit in 'int'.
11759 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 11760 Return EMACS_INT, not int.
3e047f51 11761 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
11762 Accept EMACS_INT, not int.
11763 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
11764 record read return values.
11765
cc39a9db
BK
117662011-04-15 Ben Key <bkey76@gmail.com>
11767
c9d0ec6d
JB
11768 * keyboard.c (Qundefined): Don't declare static since it is used
11769 in nsfns.m.
11770 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
11771 static since they are used in nsfont.m.
cc39a9db 11772
6c60eb9f
SM
117732011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
11774
11775 * process.c (Qprocessp): Don't declare static.
11776 * lisp.h (Qprocessp): Declare again.
11777
7990b61a
JB
117782011-04-15 Juanma Barranquero <lekktu@gmail.com>
11779
11780 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
11781
5d4cb038
PE
117822011-04-14 Paul Eggert <eggert@cs.ucla.edu>
11783
8bd7b830 11784 Improve C-level modularity by making more things 'static'.
cd64ea1d 11785
e3b27b31
PE
11786 Don't publish debugger-only interfaces to other modules.
11787 * lisp.h (safe_debug_print, debug_output_compilation_hack):
11788 (verify_bytepos, count_markers): Move decls to the only modules
11789 that need them.
11790 * region-cache.h (pp_cache): Likewise.
11791 * window.h (check_all_windows): Likewise.
11792 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
11793
5d4cb038
PE
11794 * sysdep.c (croak): Now static, if
11795 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
11796 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
11797
11798 * alloc.c (refill_memory_reserve): Now static if
11799 !defined REL_ALLOC || defined SYSTEM_MALLOC.
11800 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 11801
e87b6180
PE
11802 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
11803 Define only if USE_LUCID.
11804
ac64929e
PE
11805 * xrdb.c (x_customization_string, x_rm_string): Now static.
11806
6f37259d
PE
11807 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
11808 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
11809
1683e3ab
PE
11810 * xdisp.c (draw_row_with_mouse_face): Now static.
11811 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
11812
de9c2632
PE
11813 * window.h (check_all_windows): Mark externally visible.
11814
2b96acb7
PE
11815 * window.c (window_deletion_count): Now static.
11816
11817 * undo.c: Make symbols static if they're not exported.
11818 (last_undo_buffer, last_boundary_position, pending_boundary):
11819 Now static.
11820
50436f33
PE
11821 * textprop.c (interval_insert_behind_hooks): Now static.
11822 (interval_insert_in_front_hooks): Likewise.
11823
64520e5c
PE
11824 * term.c: Make symbols static if they're not exported.
11825 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
11826 (max_frame_lines, tty_set_terminal_modes):
11827 (tty_reset_terminal_modes, tty_turn_off_highlight):
11828 (get_tty_terminal): Now static.
11829 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
11830 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 11831 HAVE_WINDOW_SYSTEM.
64520e5c
PE
11832 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
11833 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
11834
1fa53021
PE
11835 * sysdep.c: Make symbols static if they're not exported.
11836 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
11837 Now static.
11838 (sigprocmask_set, full_mask): Remove; unused.
11839 (wait_debugging): Mark as visible.
11840 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
11841 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
11842
d4b43b22
PE
11843 * syntax.c (syntax_temp): Define only if !__GNUC__.
11844
b7c513d0
PE
11845 * sound.c (current_sound_device, current_sound): Now static.
11846
989b29ad
PE
11847 * search.c (searchbufs, searchbuf_head): Now static.
11848
13a55a78
PE
11849 * scroll.c (scroll_cost): Remove; unused.
11850 * dispextern.h (scroll_cost): Remove decl.
11851
de68a1fc
PE
11852 * region-cache.h (pp_cache): Mark as externally visible.
11853
40ccffa6
PE
11854 * process.c: Make symbols static if they're not exported.
11855 (process_tick, update_tick, create_process, chan_process):
11856 (Vprocess_alist, proc_buffered_char, datagram_access):
11857 (fd_callback_data, send_process_frame, process_sent_to): Now static.
11858 (deactivate_process): Mark defn as static, as well as decl.
11859 * lisp.h (create_process): Remove decl.
11860 * process.h (chan_process, Vprocess_alist): Remove decls.
11861
ad64fc97
PE
11862 * print.c: Make symbols static if they're not exported.
11863 (print_depth, new_backquote_output, being_printed, print_buffer):
11864 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
11865 (print_interval, print_number_index, initial_stderr_stream):
11866 Now static.
11867 * lisp.h (Fprinc): Remove decl.
11868 (debug_output_compilation_hack): Mark as externally visible.
11869
adddb265
PE
11870 * sysdep.c (croak): Move decl from here to syssignal.h.
11871 * syssignal.h (croak): Put it here, so the API can be checked when
11872 'croak' is called from dissociate_if_controlling_tty.
11873
1717ede2
PE
11874 * minibuf.c: Make symbols static if they're not exported.
11875 (minibuf_save_list, choose_minibuf_frame): Now static.
11876 * lisp.h (choose_minibuf_frame): Remove decl.
11877
fa5fb2bc
PE
11878 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
11879
1e3890d1
PE
11880 * lread.c: Make symbols static if they're not exported.
11881 (read_objects, initial_obarray, oblookup_last_bucket_number):
11882 Now static.
11883 (make_symbol): Remove; unused.
11884 * lisp.h (initial_obarray, make_symbol): Remove decls.
11885
8a1414fa
PE
11886 * keyboard.c: Make symbols static if they're not exported.
11887 (single_kboard, recent_keys_index, total_keys, recent_keys):
11888 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
11889 (this_single_command_key_start, echoing, last_auto_save):
11890 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
11891 (command_loop, echo_now, keyboard_init_hook, help_char_p):
11892 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
11893 (Vlispy_mouse_stem, double_click_count):
11894 Now static.
11895 (force_auto_save_soon): Define only if SIGDANGER.
11896 (ignore_mouse_drag_p): Now static if
11897 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
11898 (print_help): Remove; unused.
11899 (stop_character, last_timer_event): Mark as externally visible.
11900 * keyboard.h (ignore_mouse_drag_p): Declare only if
11901 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
11902 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
11903 * lisp.h (echoing): Remove decl.
11904 (force_auto_save_soon): Declare only if SIGDANGER.
11905 * xdisp.c (redisplay_window): Simplify code, to make it more
11906 obvious that ignore_mouse_drag_p is not accessed if !defined
11907 USE_GTK && !defined HAVE_NS.
11908
93ea6e8f
PE
11909 * intervals.c: Make symbols static if they're not exported.
11910 (merge_properties_sticky, merge_interval_right, delete_interval):
11911 Now static.
11912 * intervals.h (merge_interval_right, delete_interval): Remove decls.
11913
77382fcc
PE
11914 * insdel.c: Make symbols static if they're not exported.
11915 However, leave prepare_to_modify_buffer alone. It's never
11916 called from outside this function, but that appears to be a bug.
11917 (combine_after_change_list, combine_after_change_buffer):
4889fc82 11918 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
11919 (adjust_after_replace_noundo): Remove; unused.
11920 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 11921 (signal_before_change): Remove decls.
77382fcc 11922
9306c32e
PE
11923 * indent.c (val_compute_motion, val_vmotion): Now static.
11924
cd44d2eb
PE
11925 * image.c: Make symbols static if they're not exported.
11926 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
11927 if USE_GTK.
11928 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
11929 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
11930
ad9a7a06
PE
11931 * fringe.c (standard_bitmaps): Now static.
11932 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
11933
81626931
PE
11934 * frame.c: Make symbols static if they're not exported.
11935 (x_report_frame_params, make_terminal_frame): Now static.
11936 (get_frame_param): Now static, unless HAVE_NS.
11937 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
11938 (x_get_resource_string): Remove; not used.
11939 * frame.h (make_terminal_frame, x_report_frame_params):
11940 (x_get_resource_string); Remove decls.
11941 (x_fullscreen_adjust): Declare only if WINDOWSNT.
11942 * lisp.h (get_frame_param): Declare only if HAVE_NS.
11943
239f9db9
PE
11944 * font.c, fontset.c: Make symbols static if they're not exported.
11945 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
11946 (FACE_SUITABLE_FOR_CHAR_P): Use it.
11947 * font.c (font_close_object): Now static.
11948 * font.h (font_close_object): Remove.
11949 * fontset.c (FONTSET_OBJLIST): Remove.
11950 (free_realized_fontset) #if-0 the body, which does nothing.
11951 (face_suitable_for_char_p): #if-0, as it's never called.
11952 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
11953 * xfaces.c (face_at_string_position):
11954 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
11955 since 0 is always ASCII.
11956
dfcf3579
PE
11957 * fns.c (weak_hash_tables): Now static.
11958
5045092b
PE
11959 * fileio.c: Make symbols static if they're not exported.
11960 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
11961 (Vwrite_region_annotation_buffers): Now static.
11962
57a96f5c
PE
11963 * eval.c: Make symbols static if they're not exported.
11964 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
11965 * lisp.h (backtrace_list): Remove decl.
11966
35f08c38
PE
11967 * emacs.c: Make symbols static if they're not exported.
11968 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
11969 (fatal_error_code, fatal_error_signal_hook, standard_args):
11970 Now static.
11971 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
11972 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
11973 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
11974 * lisp.h (fatal_error_signal_hook): Remove decl.
11975 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
11976
f44bd759
PE
11977 * editfns.c: Move a (normally-unused) function to its only use.
11978 * editfns.c, lisp.h (get_operating_system_release): Remove.
11979 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
11980 worth the hassle of breaking this out.
11981
b532497d
PE
11982 * xterm.c: Make symbols static if they're not exported.
11983 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
11984 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
11985 (x_destroy_window, x_delete_display):
11986 Now static.
11987 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
11988 (x_mouse_leave): Remove; unused.
11989 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
11990 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
11991 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
11992 Remove decls.
11993 (x_mouse_leave): Declare only if WINDOWSNT.
11994 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
11995 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
11996 USE_X_TOOLKIT.
11997
1675728f
PE
11998 * ftxfont.c: Make symbols static if they're not exported.
11999 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
12000 HAVE_FREETYPE.
12001 * font.h (ftxfont_driver): Likewise.
12002
e4cebfca
PE
12003 * xfns.c: Make symbols static if they're not exported.
12004 (x_last_font_name, x_display_info_for_name):
12005 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
12006 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
12007 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
12008 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
12009 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
12010 (last_show_tip_args): Now static.
12011 (xic_defaut_fontset, xic_create_fontsetname): Define only if
12012 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
12013 (x_screen_planes): Remove; unused.
12014 * dispextern.h (x_screen_planes): Remove decl.
12015
5bf46f05
PE
12016 * dispnew.c: Make symbols static if they're not exported.
12017 * dispextern.h (redraw_garbaged_frames, scrolling):
12018 (increment_row_positions): Remove.
12019 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
12020 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
12021 Now static.
12022 (redraw_garbaged_frames): Remove; unused.
12023
435f4c28
PE
12024 * xfaces.c: Make symbols static if they're not exported.
12025 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
12026 Remove decls.
12027 * xterm.h (defined_color): Remove decls.
12028 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
12029 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
12030 (menu_face_changed_default, defined_color, free_realized_face):
12031 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
12032 (ascii_face_of_lisp_face): Remove; unused.
12033
8524aef3
PE
12034 * xdisp.c: Make symbols static if they're not exported.
12035 * dispextern.h (scratch_glyph_row, window_box_edges):
12036 (glyph_to_pixel_coords, set_cursor_from_row):
12037 (get_next_display_element, set_iterator_to_next):
12038 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
12039 (show_mouse_face): Remove decls
12040 * frame.h (message_buf_print): Likewise.
12041 * lisp.h (pop_message, set_message, check_point_in_composition):
12042 Likewise.
12043 * xterm.h (set_vertical_scroll_bar): Likewise.
12044 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
12045 (message_buf_print, scratch_glyph_row, displayed_buffer):
12046 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
12047 (get_next_display_element, show_mouse_face, window_box_edges):
12048 (frame_to_window_pixel_xy, check_point_in_composition):
12049 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
12050 (glyph_to_pixel_coords): Remove; unused.
12051
16390cd2
PE
12052 * dired.c (file_name_completion): Now static.
12053
12054 * dbusbind.c (xd_in_read_queued_messages): Now static.
12055
a25f4dfa
PE
12056 * lisp.h (circular_list_error, FOREACH): Remove; unused.
12057 * data.c (circular_list_error): Remove.
12058
14a9c8df
PE
12059 * commands.h (last_point_position, last_point_position_buffer):
12060 (last_point_position_window): Remove decls.
12061 * keyboard.c: Make these variables static.
12062
04f2d78b
CB
12063 * coding.h (coding, code_convert_region, encode_coding_gap):
12064 Remove decls.
74ab6df5
PE
12065 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
12066 (iso_code_class, detect_coding, code_convert_region): Now static.
12067 (encode_coding_gap): Remove; unused.
12068
38dfbee1
PE
12069 * chartab.c (chartab_chars, chartab_bits): Now static.
12070
a2cb4e63
PE
12071 * charset.h (charset_iso_8859_1): Remove decl.
12072 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
12073 Now static.
12074
127198fd
PE
12075 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
12076 * ccl.c (Vccl_program_table): Now static.
12077 (check_ccl_update): Remove; unused.
12078
d85b608f
PE
12079 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
12080 * category.h: ... from here.
12081 * category.c (check_category_table, set_category_set): Now static.
12082
31cd66f3
PE
12083 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
12084 * lisp.h: Remove these decls.
12085
c358e587
PE
12086 * buffer.c (buffer_count): Remove unused var.
12087
e78aecca
PE
12088 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
12089 so that it's not optimized away.
12090 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
12091 * dispextern.h (bidi_dump_cached_states): Remove, since it's
12092 exported only to the debugger.
12093
e192d7d3 12094 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 12095 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 12096
92470028
PE
12097 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
12098 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
12099 was inaccessible from Lisp.
12100 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
12101 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
12102
244ed907
PE
12103 alloc.c: Import and export fewer symbols, and remove unused items.
12104 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
12105 is defined.
12106 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
12107 it's not optimized away by whole-program optimization.
12108 (message_enable_multibyte, free_misc): Remove.
12109 (catchlist, handlerlist, mark_backtrace):
12110 Declare only if BYTE_MARK_STACK.
12111 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
12112 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
12113 (message_enable_multibyte): Remove decl.
12114 (free_misc, interval_free_list, float_block, float_block_index):
12115 (n_float_blocks, float_free_list, cons_block, cons_block_index):
12116 (cons_free_list, last_marked_index):
12117 Now static.
12118 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
12119 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
12120 (mark_backtrace): Define only if BYTE_MARK_STACK.
12121 * xdisp.c (message_enable_multibyte): Now static.
12122
61c2b50e 12123 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
12124 This makes it easier for human readers (and static analyzers)
12125 to see whether these variables are used from other modules.
12126 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
12127 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
12128 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
12129 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
12130 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
12131 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
12132 * xmenu.c, xselect.c:
12133 Declare Q* vars static if they are not used in other modules.
12134 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
12135 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
12136 Remove decls of unexported vars.
12137 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
12138
95c82688
PE
12139 * lisp.h (DEFINE_FUNC): Make sname 'static'.
12140
16a97296
PE
12141 Make Emacs functions such as Fatom 'static' by default.
12142 This makes it easier for human readers (and static analyzers)
12143 to see whether these functions can be called from other modules.
12144 DEFUN now defines a static function. To make the function external
12145 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
12146 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
12147 (Finit_image_library):
16a97296
PE
12148 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
12149 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
12150 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
12151 Remove decls, since these functions are now static.
12152 (Funintern, Fget_internal_run_time): New decls, since these functions
12153 were already external.
95c82688 12154
16a97296
PE
12155 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
12156 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
12157 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
12158 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
12159 * keyboard.c, keymap.c, lread.c:
12160 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
12161 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
12162 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
12163 Mark functions with DEFUE instead of DEFUN,
12164 if they are used in other modules.
12165 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
12166 decls for now-static functions.
12167 * buffer.h (Fdelete_overlay): Remove decl.
12168 * callproc.c (Fgetenv_internal): Mark as internal.
12169 * composite.c (Fremove_list_of_text_properties): Remove decl.
12170 (Fcomposition_get_gstring): New forward static decl.
12171 * composite.h (Fcomposite_get_gstring): Remove decl.
12172 * dired.c (Ffile_attributes): New forward static decl.
12173 * doc.c (Fdocumntation_property): New forward static decl.
12174 * eval.c (Ffetch_bytecode): New forward static decl.
12175 (Funintern): Remove extern decl; now in .h file where it belongs.
12176 * fileio.c (Fmake_symbolic_link): New forward static decl.
12177 * image.c (Finit_image_library): New forward static decl.
12178 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
12179 * intervals.h (Fprevious_property_change):
12180 (Fremove_list_of_text_properties): Remove decls.
12181 * keyboard.c (Fthis_command_keys): Remove decl.
12182 (Fcommand_execute): New forward static decl.
12183 * keymap.c (Flookup_key): New forward static decl.
12184 (Fcopy_keymap): Now static.
12185 * keymap.h (Flookup_key): Remove decl.
12186 * process.c (Fget_process): New forward static decl.
12187 (Fprocess_datagram_address): Mark as internal.
12188 * syntax.c (Fsyntax_table_p): New forward static decl.
12189 (skip_chars): Remove duplicate decl.
12190 * textprop.c (Fprevious_property_change): New forward static decl.
12191 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
12192 Now internal.
12193 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
12194 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
12195
785bbd42
PE
12196 * editfns.c (Fformat): Remove unreachable code.
12197
8b913b57
AS
121982011-04-14 Andreas Schwab <schwab@linux-m68k.org>
12199
12200 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
12201 change. (Bug#8496)
12202
a6744a35
EZ
122032011-04-13 Eli Zaretskii <eliz@gnu.org>
12204
12205 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
12206 when at ZV. (Bug#8487)
12207
e7974947
AS
122082011-04-12 Andreas Schwab <schwab@linux-m68k.org>
12209
baad03f0
AS
12210 * charset.c (Fclear_charset_maps): Use xfree instead of free.
12211 (Bug#8437)
12212 * keyboard.c (parse_tool_bar_item): Likewise.
12213 * sound.c (sound_cleanup, alsa_close): Likewise.
12214 * termcap.c (tgetent): Likewise.
12215 * xfns.c (x_default_font_parameter): Likewise.
12216 * xsettings.c (read_and_apply_settings): Likewise.
12217
e7974947
AS
12218 * alloc.c (overrun_check_malloc, overrun_check_realloc)
12219 (overrun_check_free): Protoize.
12220
28272684
PE
122212011-04-12 Paul Eggert <eggert@cs.ucla.edu>
12222
12223 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
12224 since callers should never pass a negative size.
12225 Change the signature to match that of plain 'read' and 'write'; see
12226 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
12227 * lisp.h: Update prototypes of emacs_write and emacs_read.
12228
11997c76
EZ
122292011-04-11 Eli Zaretskii <eliz@gnu.org>
12230
12231 * xdisp.c (redisplay_window): Don't try to determine the character
12232 position of the scroll margin if the window start point w->startp
e896f03c 12233 is outside the buffer's accessible region. (Bug#8468)
11997c76 12234
8a2cbd72
EZ
122352011-04-10 Eli Zaretskii <eliz@gnu.org>
12236
12237 Fix write-region and its subroutines for buffers > 2GB.
12238 * fileio.c (a_write, e_write): Modify declaration of arguments and
12239 local variables to support buffers larger than 2GB.
12240 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
12241
12242 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
12243 argument, local variables, and return value.
12244
12245 * lisp.h: Update prototypes of emacs_write and emacs_read.
12246
12247 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
12248
4073e537 122492011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 12250
1ebfdcb6
PE
12251 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
12252
b2ded58d
PE
12253 Fix more problems found by GCC 4.6.0's static checks.
12254
7d66342c
PE
12255 * xdisp.c (vmessage): Use a better test for character truncation.
12256
bbf47d44
PE
12257 * charset.c (load_charset_map): <, not <=, for optimization,
12258 and to avoid potential problems with integer overflow.
9248994d 12259 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 12260 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 12261 * editfns.c (Fformat): Likewise.
1e69125e 12262 * syntax.c (skip_chars): Likewise.
3befa583 12263
e3019616
PE
12264 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
12265 This also lets GCC 4.6.0 generate slightly better loop code.
12266
becfa255
PE
12267 * callint.c (Fcall_interactively): <, not <=, for optimization.
12268 (Fcall_interactively): Count the number of arguments produced,
12269 not the number of arguments given. This is simpler and lets GCC
12270 4.6.0 generate slightly better code.
12271
dae0cd48
PE
12272 * ftfont.c: Distingish more carefully between FcChar8 and char.
12273 The previous code passed unsigned char * to a functions like
12274 strlen and xstrcasecmp that expect char *, which does not
12275 conform to the C standard.
12276 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
12277 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
12278 char * when the C standard requires it.
12279
76032d70
PE
12280 * keyboard.c (read_char): Remove unused var.
12281
eb3f1cc8
PE
12282 * eval.c: Port to Windows vsnprintf (Bug#8435).
12283 Include <limits.h>.
12284 (SIZE_MAX): Define if the headers do not.
12285 (verror): Do not give up if vsnprintf returns a negative count.
12286 Instead, grow the buffer. This ports to Windows vsnprintf, which
12287 does not conform to C99. Problem reported by Eli Zaretskii.
12288 Also, simplify the allocation scheme, by avoiding the need for
12289 calling realloc, and removing the ALLOCATED variable.
12290
70476b54
PE
12291 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
12292
12020a9e
PE
12293 Remove invocations of doprnt, as Emacs now uses vsnprintf.
12294 But keep the doprint source code for now, as we might revamp it
12295 and use it again (Bug#8435).
ea6c7ae6
PE
12296 * lisp.h (doprnt): Remove.
12297 * Makefile.in (base_obj): Remove doprnt.o.
12298 * deps.mk (doprnt.o): Remove.
12299
5fdb398c
PE
12300 error: Print 32- and 64-bit integers portably (Bug#8435).
12301 Without this change, on typical 64-bit hosts error ("...%d...", N)
12302 was used to print both 32- and 64-bit integers N, which relied on
12303 undefined behavior.
61bdb816 12304 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
12305 * lisp.h (error, verror): Mark as printf-like functions.
12306 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
12307 Report overflow in size calculations when allocating printf buffer.
12308 Do not truncate output string at its first null byte.
12309 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
12310 Truncate the output at a character boundary, since vsnprintf does not
12311 do that.
12312 * charset.c (check_iso_charset_parameter): Convert internal
12313 character to string before calling 'error', since %c now has the
12314 printf meaning.
12315 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
12316 overflow when computing char to be passed to 'error'. Do not
12317 pass Lisp_Object to 'error'; pass the integer instead.
12318 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
12319 formatted with plain %d.
12320
b189fa66
PE
12321 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
12322
bff87ef0
PE
12323 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
12324
7e2cac20
PE
12325 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
12326
ce4d90b5
PE
12327 * xterm.c (x_catch_errors): Remove duplicate declaration.
12328
266c9547
PE
12329 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
12330
79c49ad2
PE
12331 * xdisp.c, lisp.h (message_nolog): Remove; unused.
12332
368f4090
JM
123332011-04-10 Jim Meyering <meyering@redhat.com>
12334
12335 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
12336 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
12337 return ssize_t not "int", and use size_t as the buffer length.
12338 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
12339 * gnutls.h: Update declarations.
12340 * process.c (read_process_output): Use ssize_t, to match.
12341 (send_process): Likewise.
12342
a32d4040
CY
123432011-04-09 Chong Yidong <cyd@stupidchicken.com>
12344
12345 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
12346
8546720e 123472011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 12348
04f2d78b
CB
12349 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
12350 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 12351
8546720e
GM
12352 * xterm.c (handle_one_xevent):
12353 * xmenu.c (create_and_show_popup_menu):
12354 * xselect.c (x_decline_selection_request)
12355 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 12356
0a2f5c1a 123572011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
12358
12359 Fix some uses of `int' instead of EMACS_INT.
12360 * search.c (string_match_1, fast_string_match)
12361 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
12362 (scan_buffer, find_next_newline_no_quit)
12363 (find_before_next_newline, search_command, Freplace_match)
12364 (Fmatch_data): Make some `int' variables be EMACS_INT.
12365
12366 * xdisp.c (display_count_lines): 3rd argument and return value now
12367 EMACS_INT. All callers changed.
12368 (pint2hrstr): Last argument is now EMACS_INT.
12369
12370 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
12371 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
12372 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
12373 (decode_coding_utf_16, decode_coding_emacs_mule)
12374 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
12375 (decode_coding_ccl, decode_coding_charset)
12376 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
12377 (decode_coding_iso_2022, decode_coding_emacs_mule)
12378 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
12379 <char_offset, last_offset>: Declare EMACS_INT.
12380 (encode_coding_utf_8, encode_coding_utf_16)
12381 (encode_coding_emacs_mule, encode_invocation_designation)
12382 (encode_designation_at_bol, encode_coding_iso_2022)
12383 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
12384 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
12385 Declare EMACS_INT.
12386 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
12387 (encode_invocation_designation): Last argument P_NCHARS is now
12388 EMACS_INT.
12389 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
12390 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
12391
12392 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
12393 All users changed.
12394
12395 * ccl.c (Fccl_execute_on_string): Declare some variables
12396 EMACS_INT.
12397
8546720e 123982011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
12399
12400 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
12401
4e19a977
CS
124022011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
12403
12404 * process.c (Fformat_network_address): Doc fix.
12405
87302331
R
124062011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
12407
ee7683eb 12408 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 12409
cbb59342
CY
124102011-04-08 Chong Yidong <cyd@stupidchicken.com>
12411
12412 * keyboard.c (read_char): Call Lisp function help-form-show,
12413 instead of using internal_with_output_to_temp_buffer.
12414 (Qhelp_form_show): New var.
e0d38eeb 12415 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
12416
12417 * print.c (internal_with_output_to_temp_buffer): Function deleted.
12418
12419 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
12420
e67a13ab
CY
124212011-04-06 Chong Yidong <cyd@stupidchicken.com>
12422
04f2d78b
CB
12423 * process.c (Flist_processes): Remove to Lisp.
12424 (list_processes_1): Delete.
e67a13ab 12425
973f782d
EZ
124262011-04-06 Eli Zaretskii <eliz@gnu.org>
12427
7c106b1e
EZ
12428 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
12429
973f782d
EZ
12430 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
12431
41cf7d1a 124322011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 12433
ca23cc88
PE
12434 Fix more problems found by GCC 4.6.0's static checks.
12435
f390e2d5
PE
12436 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
12437
42eea0d0
PE
12438 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
12439
b69769da 12440 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 12441
f9541e84
PE
12442 * xdisp.c (vmessage): Mark as a printf-like function.
12443
13841b55
PE
12444 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
12445
c136c10f
PE
12446 * sound.c (sound_warning): Don't crash if arg contains a printf format.
12447
5e2d4a30
PE
12448 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
12449 printf-like functions.
12450 (tiff_load): Add casts to remove these marks before passing them
12451 to system-supplied API.
12452
583f48b9
PE
12453 * eval.c (Fsignal): Remove excess argument to 'fatal'.
12454
b25d760e
PE
12455 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
12456 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
12457 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
12458 directly, rather than having caller test rule sign. This avoids
12459 some unnecessary tests.
12460 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
12461 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
12462 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 12463
bc7b6697 12464 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 12465 (xfont_open): Avoid unnecessary tests.
bc7b6697 12466
27ccc379
PE
12467 * composite.c (composition_gstring_put_cache): Use unsigned integer.
12468
dcd5c89a
PE
12469 * composite.h, composite.c (composition_gstring_put_cache):
12470 Use EMACS_INT, not int, for length.
12471
b13a45c6
PE
12472 * composite.h (COMPOSITION_DECODE_REFS): New macro,
12473 breaking out part of COMPOSITION_DECODE_RULE.
12474 (COMPOSITION_DECODE_RULE): Use it.
12475 * composite.c (get_composition_id): Remove unused local vars,
12476 by using the new macro.
12477
1e792e4d
PE
12478 * textprop.c (set_text_properties_1): Change while to do-while,
12479 since the condition is always true at first.
12480
dc6c6455 12481 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
12482 (interval_deletion_adjustment): Return unsigned value.
12483 All uses changed.
dc6c6455 12484
aba7731a
PE
12485 * process.c (list_processes_1, create_pty, read_process_output):
12486 (exec_sentinel): Remove vars that were set but not used.
afd4052b 12487 (create_pty): Remove unnecessary "volatile"s.
bc57d757 12488 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 12489 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 12490 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 12491
fdfc4bf3
PE
12492 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
12493
fca8fe46 12494 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 12495 (update_syntax_table): Use unsigned instead of int.
fca8fe46 12496
06a0259a 12497 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 12498 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 12499 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 12500
e7b9e80f
PE
12501 * print.c (print_error_message): Avoid int overflow.
12502
56201685
PE
12503 * font.c (font_list_entities): Redo for clarity,
12504 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
12505
78834453 12506 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 12507 (font_score): Avoid potential overflow in diff calculation.
78834453 12508
0bc0b309 12509 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 12510 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 12511
e610eaca
PE
12512 * eval.c (funcall_lambda): Rename local to avoid shadowing.
12513
b895abce
PE
12514 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
12515 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
12516 can always succeed if overflow has undefined behavior.
12517
1f1d9321 12518 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 12519 (wordify): Omit three unnecessary tests.
1f1d9321 12520
c59478bc
PE
12521 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
12522 All callers changed. This avoids the need for an unused var.
12523
79b73827
PE
12524 * casefiddle.c (casify_region): Remove var that is set but not used.
12525
a4db5dfe
PE
12526 * dired.c (file_name_completion): Remove var that is set but not used.
12527
43aae36e
PE
12528 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
12529
2a47c44d 12530 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 12531 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 12532
a37c69bf
PE
12533 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
12534 Check for integer overflow on size calculations.
12535
328ab8e7
PE
12536 * buffer.c (Fprevious_overlay_change): Remove var that is set
12537 but not used.
12538
e5a2a5cb
PE
12539 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
12540 Remove vars that are set but not used.
8d84a6eb 12541 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 12542 (timer_check_2): Mark vars as initialized.
e5a2a5cb 12543
a60e5f68
PE
12544 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
12545
f661cb61 12546 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 12547 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 12548
f0397f5a
PE
12549 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
12550 that are set but not used.
12551
8664db06 12552 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 12553 if XCreateBitmapFromData fails (Bug#8410).
8664db06 12554
6abdaa4a
PE
12555 * xselect.c (x_get_local_selection, x_handle_property_notify):
12556 Remove vars that are set but not used.
12557
0ce7538d 12558 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 12559 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 12560
9ae848fc
PE
12561 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
12562 Remove var that is set but not used.
0b918413
PE
12563 (scroll_bar_windows_size): Now size_t, not int.
12564 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
12565 Check for overflow.
9ae848fc 12566
a5a62657
PE
12567 * xfaces.c (realize_named_face): Remove vars that are set but not used.
12568 (map_tty_color) [!defined MSDOS]: Likewise.
12569
5c5cdd39
PE
12570 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
12571
66ebf983
PE
12572 * coding.c: Remove vars that are set but not used.
12573 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
12574 All callers changed.
12575 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
12576 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
12577 (decode_coding_charset): Remove vars that are set but not used.
12578
1be4d761
PE
12579 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
12580 that is set but not used.
12581
47553fa8
PE
12582 * print.c (print_object): Remove var that is set but not used.
12583
1f7196bf 12584 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
12585 The gnulib version avoids calling malloc in the usual case,
12586 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
12587 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
12588 * filelock.c (current_lock_owner): Likewise.
12589 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
12590 * sysdep.c: Include allocator.h, careadlinkat.h.
12591 (emacs_no_realloc_allocator): New static constant.
12592 (emacs_readlink): New function.
fdb61804
PE
12593 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
12594 ../lib/careadlinkat.h.
d1fdcab7 12595
f84c17c7
SM
125962011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
12597
12598 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
12599 first non-nil return value).
12600
ef3862ad
JD
126012011-04-03 Jan Djärv <jan.h.d@swipnet.se>
12602
12603 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
12604 if not defined (Bug#8403).
12605
376a7006
JB
126062011-04-02 Juanma Barranquero <lekktu@gmail.com>
12607
12608 * xdisp.c (display_count_lines): Remove parameter `start',
12609 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12610 (get_char_face_and_encoding): Remove parameter `multibyte_p',
12611 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12612 (fill_stretch_glyph_string): Remove parameters `row' and `area',
12613 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
12614 and thereabouts. All callers changed.
12615 (get_per_char_metric): Remove parameter `f', unused since
12616 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12617
6ca3801d
JM
126182011-04-02 Jim Meyering <meyering@redhat.com>
12619
12620 do not dereference NULL upon failed strdup
12621 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
12622 (ns_get_family): Likewise.
12623
d8e2b5ba
JB
126242011-04-02 Juanma Barranquero <lekktu@gmail.com>
12625
12626 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
12627
8c74fcbd
JD
126282011-04-02 Jan Djärv <jan.h.d@swipnet.se>
12629
12630 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
12631 later (Bug#8403).
12632
7200d79c
SM
126332011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
12634
03408648 12635 Add lexical binding.
7200d79c 12636
03408648
SM
12637 * window.c (Ftemp_output_buffer_show): New fun.
12638 (Fsave_window_excursion):
12639 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
12640
12641 * lread.c (lisp_file_lexically_bound_p): New function.
12642 (Fload): Bind Qlexical_binding.
12643 (readevalloop): Remove `evalfun' arg.
12644 Bind Qinternal_interpreter_environment.
12645 (Feval_buffer): Bind Qlexical_binding.
12646 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
12647 Mark as dynamic.
12648 (syms_of_lread): Declare `lexical-binding'.
12649
12650 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
12651
12652 * keyboard.c (eval_dyn): New fun.
12653 (menu_item_eval_property): Use it.
ca105506
SM
12654
12655 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 12656
03408648
SM
12657 * fns.c (concat, mapcar1): Accept byte-code-functions.
12658
12659 * eval.c (Fsetq): Handle lexical vars.
12660 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
12661 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
12662 (FletX, Flet): Obey lexical binding.
12663 (Fcommandp): Handle closures.
12664 (Feval): New `lexical' arg.
12665 (eval_sub): New function extracted from Feval. Use it almost
12666 everywhere where Feval was used. Look up vars in lexical env.
12667 Handle closures.
12668 (Ffunctionp): Move from subr.el.
12669 (Ffuncall): Handle closures.
12670 (apply_lambda): Remove `eval_flags'.
12671 (funcall_lambda): Handle closures and new byte-code-functions.
12672 (Fspecial_variable_p): New function.
12673 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
12674 but without exporting it to Lisp.
23aba0ea 12675
23aba0ea 12676 * doc.c (Fdocumentation, store_function_docstring):
03408648 12677 * data.c (Finteractive_form): Handle closures.
23aba0ea 12678
03408648
SM
12679 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
12680 interactive spec.
ba83908c 12681
04f2d78b
CB
12682 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
12683 New byte-codes.
03408648
SM
12684 (exec_byte_code): New function extracted from Fbyte_code to handle new
12685 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 12686
03408648 12687 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 12688
03408648 12689 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 12690
e2abce01
JB
126912011-03-31 Juanma Barranquero <lekktu@gmail.com>
12692
12693 * xdisp.c (redisplay_internal): Fix prototype.
12694
63696a73 126952011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 12696
63696a73 12697 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
12698 (try_scrolling): Use it when setting scroll_limit.
12699 Limit scrolling to 100 screen lines.
63696a73
EZ
12700 (redisplay_window): Even when falling back on "recentering",
12701 position point in the window according to scroll-conservatively,
12702 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
12703
12704 (try_scrolling): When point is above the window, allow searching
12705 as far as scroll_max, or one screenful, to compute vertical
12706 distance from PT to the scroll margin position. This prevents
12707 try_scrolling from unnecessarily failing when
12708 scroll-conservatively is set to a value slightly larger than the
12709 window height. Clean up the case of PT below the margin at bottom
12710 of window: scroll_max can no longer be INT_MAX. When aggressive
12711 scrolling is in use, don't let point enter the opposite scroll
12712 margin as result of the scroll.
12713 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
12714 threshold of 100 lines for never-recentering scrolling.
12715
e4cc2dfc
JB
127162011-03-31 Juanma Barranquero <lekktu@gmail.com>
12717
12718 * dispextern.h (move_it_by_lines):
12719 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
12720 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
12721 (message_log_check_duplicate): Remove parameters `prev_bol' and
12722 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12723 (redisplay_internal): Remove parameter `preserve_echo_area',
12724 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
12725
12726 * indent.c (Fvertical_motion):
12727 * window.c (window_scroll_pixel_based, Frecenter):
12728 Don't pass `need_y_p' to `move_it_by_lines'.
12729
1c470562
SM
127302011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
12731
44f230aa
SM
12732 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
12733 steal a few bits to be more compact.
12734 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
12735 Remove unneeded casts.
12736
1c470562
SM
12737 * bytecode.c (Fbyte_code): CAR and CDR can GC.
12738
888adce9
ZK
127392011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
12740
12741 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
12742 binding" message (bug#7967).
12743
f838ed7b
PE
127442011-03-30 Paul Eggert <eggert@cs.ucla.edu>
12745
77861b95
PE
12746 Fix more problems found by GCC 4.6.0's static checks.
12747
de6dbc14
PE
12748 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
12749 Remove unused local var.
12750
f838ed7b
PE
12751 * editfns.c (Fmessage_box): Remove unused local var.
12752
792c7b2b
PE
12753 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
12754 (note_mode_line_or_margin_highlight, note_mouse_highlight):
12755 Omit unused local vars.
c499e557 12756 * window.c (shrink_windows): Omit unused local var.
b01a1c29 12757 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
12758 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
12759 Omit unused local var.
12760
ba0165e1
PE
12761 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
12762 Don't assume string length fits in int.
32ad8845 12763 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 12764 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 12765
3c59b4c9
PE
12766 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
12767 instead of alloca (Bug#8344).
12768
a3eed478 12769 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 12770 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 12771
eb4d412d
PE
12772 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
12773
1658b401
PE
12774 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
12775 concerns.
12776
12777 * term.c (produce_glyphless_glyph): Remove unnecessary test.
12778
12779 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 12780
9a2c6e05
PE
12781 * keyboard.c (syms_of_keyboard): Use the same style as later
12782 in this function when indexing through an array. This also
12783 works around GCC bug 48267.
12784
03d0a109
PE
12785 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
12786
44f730c8
PE
12787 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
12788
fe75f926
PE
12789 * chartab.c (sub_char_table_ref_and_range): Redo for slight
12790 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
12791
ffa8c828
PE
12792 * keyboard.c, keyboard.h (num_input_events): Now size_t.
12793 This avoids undefined behavior on integer overflow, and is a bit
12794 more convenient anyway since it is compared to a size_t variable.
12795
c5101a77
PE
12796 Variadic C functions now count arguments with size_t, not int.
12797 This avoids an unnecessary limitation on 64-bit machines, which
12798 caused (substring ...) to crash on large vectors (Bug#8344).
12799 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
12800 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 12801 All variadic functions and their callers changed accordingly.
c5101a77
PE
12802 (struct gcpro.nvars): Now size_t, not int. All uses changed.
12803 * data.c (arith_driver, float_arith_driver): Likewise.
12804 * editfns.c (general_insert_function): Likewise.
12805 * eval.c (struct backtrace.nargs, interactive_p)
12806 (internal_condition_case_n, run_hook_with_args, apply_lambda)
12807 (funcall_lambda, mark_backtrace): Likewise.
12808 * fns.c (concat): Likewise.
12809 * frame.c (x_set_frame_parameters): Likewise.
12810 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
12811 0 if not found, not -1. All callers changed.
12812
dd3f25f7
PE
12813 * alloc.c (garbage_collect): Don't assume stack size fits in int.
12814 (stack_copy_size): Now size_t, not int.
12815 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
12816
461c2ab9
JB
128172011-03-28 Juanma Barranquero <lekktu@gmail.com>
12818
12819 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
12820 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12821 All callers changed.
12822
12823 * lisp.h (multibyte_char_to_unibyte):
12824 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
12825 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12826 * character.h (CHAR_TO_BYTE8):
12827 * cmds.c (internal_self_insert):
12828 * editfns.c (general_insert_function):
12829 * keymap.c (push_key_description):
12830 * search.c (Freplace_match):
12831 * xdisp.c (message_dolog, set_message_1): All callers changed.
12832
f6d62986
SM
128332011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
12834
12835 * keyboard.c (safe_run_hook_funcall): New function.
12836 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
12837 don't set the hook to nil, but remove the offending function instead.
12838 (Qcommand_hook_internal): Remove, unused.
12839 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
12840 Vcommand_hook_internal.
12841
12842 * eval.c (enum run_hooks_condition): Remove.
12843 (funcall_nil, funcall_not): New functions.
12844 (run_hook_with_args): Call each function through a `funcall' argument.
12845 Remove `cond' argument, now redundant.
12846 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
12847 (Frun_hook_with_args_until_failure): Adjust accordingly.
12848 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
12849
1db5b1ad
JB
128502011-03-28 Juanma Barranquero <lekktu@gmail.com>
12851
12852 * dispextern.h (string_buffer_position): Remove declaration.
12853
12854 * print.c (strout): Remove parameter `multibyte', unused since
12855 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
12856
12857 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
12858 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
12859 All callers changed.
12860
12861 * w32.c (_wsa_errlist): Use braces for struct initializers.
12862
12863 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
12864 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
12865 All callers changed.
12866 (string_buffer_position): Likewise. Also, make static (it's never
12867 used outside xdisp.c).
12868 (cursor_row_p): Remove parameter `w', unused since
12869 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
12870 (decode_mode_spec): Remove parameter `precision', introduced during
12871 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
12872 All callers changed.
12873
5ffb62aa
JD
128742011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12875
12876 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
12877
461c2ab9 128782011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
12879
12880 * nsterm.m (ns_menu_bar_is_hidden): New variable.
12881 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
12882 (ns_update_auto_hide_menu_bar): New functions.
12883 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
12884 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
12885 ns_constrain_all_frames.
12886 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
12887 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
12888
5c380ffb
JD
128892011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12890
12891 * nsmenu.m (runDialogAt): Remove argument to timer_check.
12892
9af30bdf
GM
128932011-03-27 Glenn Morris <rgm@gnu.org>
12894
12895 * syssignal.h: Replace RETSIGTYPE with void.
12896 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
12897 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
12898 Replace SIGTYPE with void everywhere.
12899 * s/usg5-4-common.h (SIGTYPE): Remove definition.
12900 * s/template.h (SIGTYPE): Remove commented out definition.
12901
e2abce01
JB
129022011-03-26 Eli Zaretskii <eliz@gnu.org>
12903
12904 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
12905 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
12906
f868cd8a
JB
129072011-03-26 Juanma Barranquero <lekktu@gmail.com>
12908
59eb0929
JB
12909 * w32.c (read_unc_volume): Use parameter `henum', instead of
12910 global variable `wget_enum_handle'.
12911
12912 * keymap.c (describe_vector): Remove parameters `indices' and
12913 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
12914 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
12915
f868cd8a
JB
12916 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
12917
12918 * keyboard.c (timer_check): Remove parameter `do_it_now',
12919 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
12920 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
12921 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
12922
12923 * keyboard.c (read_char):
12924 * w32menu.c (w32_menu_display_help):
12925 * xmenu.c (show_help_event, menu_help_callback):
12926 Adjust calls to `show_help_echo'.
12927
12928 * gtkutil.c (xg_maybe_add_timer):
12929 * keyboard.c (readable_events):
12930 * process.c (wait_reading_process_output):
12931 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
12932
12933 * insdel.c (adjust_markers_gap_motion):
12934 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
12935 (gap_left, gap_right): Don't call it.
12936
2ecf6fdb
CY
129372011-03-25 Chong Yidong <cyd@stupidchicken.com>
12938
12939 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
12940 incurred during fontification.
12941
6b1f9ba4
JB
129422011-03-25 Juanma Barranquero <lekktu@gmail.com>
12943
12944 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
12945 (DEFVAR_PER_BUFFER): Don't pass it.
12946
12947 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
12948 (scrolling_window): Don't pass it.
12949
0f4a96b5
JB
129502011-03-25 Juanma Barranquero <lekktu@gmail.com>
12951
12952 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
12953
12954 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
12955 and `suffix'.
12956 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
12957 of variables specific to SELinux and computation of `encoded_absname'.
12958
12959 * image.c (XPutPixel): Remove unused variable `height'.
12960
12961 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
12962
12963 * unexw32.c (get_section_info): Remove unused variable `section'.
12964
12965 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
12966 (system_process_attributes): Remove unused variable `sess'.
12967 (sys_read): Remove unused variable `err'.
12968
12969 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
12970 (w32_wnd_proc): Remove unused variable `isdead'.
12971 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
12972 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
12973 (x_create_tip_frame): Remove unused variable `tem'.
12974
12975 * w32inevt.c (w32_console_read_socket):
12976 Remove unused variable `no_events'.
12977
12978 * w32term.c (x_draw_composite_glyph_string_foreground):
12979 Remove unused variable `width'.
12980
1149507c
JB
129812011-03-24 Juanma Barranquero <lekktu@gmail.com>
12982
12983 * w32term.c (x_set_glyph_string_clipping):
12984 Don't pass uninitialized region to CombineRgn.
12985
9c88f339
JB
129862011-03-23 Juanma Barranquero <lekktu@gmail.com>
12987
12988 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
12989 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
12990 (Fx_close_connection): Remove unused variable `i'.
12991
12992 * w32font.c (w32font_draw): Return number of glyphs.
12993 (w32font_open_internal): Remove unused variable `i'.
12994 (w32font_driver): Add missing initializer.
12995
12996 * w32menu.c (utf8to16): Remove unused variable `utf16'.
12997 (fill_in_menu): Remove unused variable `items_added'.
12998
12999 * w32term.c (last_mouse_press_frame): Remove static global variable.
13000 (w32_clip_to_row): Remove unused variable `f'.
13001 (x_delete_terminal): Remove unused variable `i'.
13002
13003 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
13004 (NOTHING): Remove unused static global variable.
13005 (uniscribe_check_otf): Remove unused variable `table'.
13006 (uniscribe_font_driver): Add missing initializers.
13007
dee091a3
JD
130082011-03-23 Julien Danjou <julien@danjou.info>
13009
13010 * term.c (Fsuspend_tty, Fresume_tty):
13011 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
13012 * window.c (temp_output_buffer_show):
13013 * insdel.c (signal_before_change):
13014 * frame.c (Fhandle_switch_frame):
13015 * fileio.c (Fdo_auto_save):
13016 * emacs.c (Fkill_emacs):
13017 * editfns.c (save_excursion_restore):
13018 * cmds.c (internal_self_insert):
13019 * callint.c (Fcall_interactively):
13020 * buffer.c (Fkill_all_local_variables):
13021 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
13022 Use Frun_hooks.
0f4a96b5 13023 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 13024 unconditionally since it does the check itself.
dee091a3 13025
2c520ab5 130262011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 13027
c9c49752
PE
13028 Fix more problems found by GCC 4.5.2's static checks.
13029
8abc3f12
PE
13030 * coding.c (encode_coding_raw_text): Avoid unnecessary test
13031 the first time through the loop, since we know p0 < p1 then.
13032 This also avoids a gcc -Wstrict-overflow warning.
13033
a2d26660
PE
13034 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
13035 leading to a memory leak, possible in functions like
13036 load_charset_map_from_file that can allocate an unbounded number
b12ef411 13037 of objects (Bug#8318).
a2d26660 13038
916c72e9
PE
13039 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
13040 that could (at least in theory) be that large.
13041
19ab8a18
PE
13042 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
13043 This is less likely to overflow, and avoids undefined behavior if
13044 overflow does occur. All callers changed. Use strtoul to scan
13045 for the unsigned long integer.
b7cbbd6f
PE
13046 (pint2hrstr): Simplify and tune code slightly.
13047 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 13048
f0641eff
PE
13049 * scroll.c (do_scrolling): Work around GCC bug 48228.
13050 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
13051
7f650bb9
PE
13052 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
13053 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
13054 (validate_x_resource_name): Simplify count usage.
13055 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 13056
37dd57d1
PE
13057 * fileio.c (Fcopy_file): Report error if fchown or fchmod
13058 fail (Bug#8306).
81e56e61 13059
699979fc 13060 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 13061
401bf9b4
PE
13062 * process.c (Fmake_network_process): Use socklen_t, not int,
13063 where POSIX says socklen_t is required in portable programs.
13064 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 13065 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
13066 (Fmake_network_process, server_accept_connection):
13067 (wait_reading_process_output, read_process_output):
13068 Likewise.
13069
b93aacde
PE
13070 * process.c: Rename or move locals to avoid shadowing.
13071 (list_processes_1, Fmake_network_process):
13072 (read_process_output_error_handler, exec_sentinel_error_handler):
13073 Rename or move locals.
4dc343ee 13074 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 13075 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 13076 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 13077 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 13078 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 13079
af8a867c 13080 Make tparam.h and terminfo.c consistent.
44f230aa
SM
13081 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
13082 Include tparam.h instead, since it declares them.
af8a867c
PE
13083 * cm.h (PC): Remove extern decl; tparam.h now does this.
13084 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
13085 * terminfo.c: Include tparam.h, to check interfaces.
13086 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
13087 (tparam): Adjust signature to match interface in tparam.h;
13088 this removes some undefined behavior. Check that outstring and len
13089 are zero, which they always are with Emacs.
13090 * tparam.h (PC, BC, UP): New extern decls.
13091
0248044d 13092 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 13093 (xftfont_open): Rename locals to avoid shadowing.
0248044d 13094
8ff096c1 13095 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
13096 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
13097 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 13098 (ftfont_list): Remove unused local.
49eaafba
PE
13099 (get_adstyle_property, ftfont_pattern_entity):
13100 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
13101 Rename locals to avoid shadowing.
8ff096c1 13102
e2be39f6
PE
13103 * xfont.c (xfont_list_family): Mark var as initialized.
13104
c9735e30
PE
13105 * xml.c (make_dom): Now static.
13106
8f5201ae
PE
13107 * composite.c (composition_compute_stop_pos): Rename local to
13108 avoid shadowing.
b246f932
PE
13109 (composition_reseat_it): Remove unused locals.
13110 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 13111 (composition_update_it): Mark var as initialized.
11b61122
PE
13112 (find_automatic_composition): Mark vars as initialized,
13113 with a FIXME (Bug#8290).
8f5201ae 13114
760fbc2c
PE
13115 character.h: Rename locals to avoid shadowing.
13116 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
13117 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
13118 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
13119 (BUF_DEC_POS): Be more systematic about renaming local temporaries
13120 to avoid shadowing.
13121
ff08eb85
PE
13122 * textprop.c (property_change_between_p): Remove; unused.
13123
fc7bf025
PE
13124 * intervals.c (interval_start_pos): Now static.
13125
235d7abc
PE
13126 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
13127
44f230aa
SM
13128 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
13129 Rename locals to avoid shadowing.
3e7d6594 13130
50060332
PE
13131 * sound.c (wav_play, au_play, Fplay_sound_internal):
13132 Fix pointer signedness.
d01f234b 13133 (alsa_choose_format): Remove unused local var.
c83b8872
PE
13134 (wav_play): Initialize a variable to 0, to prevent undefined
13135 behavior (Bug#8278).
50060332 13136
c4fc4e30
PE
13137 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
13138
918436ed
PE
13139 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
13140
c939f91b
PE
13141 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
13142 clobbering (Bug#8298).
b9c7f648
PE
13143 * sysdep.c (sys_subshell): Likewise.
13144 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 13145
6bd8c144
PE
13146 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
13147 This should get cleaned up, so that child_setup has the
13148 same signature on all platforms.
13149
7710357c 13150 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 13151 (relocate_fd): Rename locals to avoid shadowing.
7710357c 13152
c59da222
CY
131532011-03-22 Chong Yidong <cyd@stupidchicken.com>
13154
13155 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
13156 not to be necessary, and produces flickering.
13157
66b87493
GM
131582011-03-20 Glenn Morris <rgm@gnu.org>
13159
13160 * config.in: Remove file.
13161
45b6f6d5
JB
131622011-03-20 Juanma Barranquero <lekktu@gmail.com>
13163
13164 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
13165 are now in src/globals.h.
13166 (syms_of_minibuf): Remove spurious & from previous change.
13167
cd394be1 131682011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
13169
13170 * minibuf.c (completing-read-function): New variable.
13171 (completing-read-default): Rename from completing-read.
13172 (completing-read): Call completing-read-function.
13173
b14e3e21
CY
131742011-03-19 Juanma Barranquero <lekktu@gmail.com>
13175
13176 * xfaces.c (Fx_load_color_file):
13177 Read color file from absolute filename (bug#8250).
13178
f2b726e6
JB
131792011-03-19 Juanma Barranquero <lekktu@gmail.com>
13180
13181 * makefile.w32-in: Update dependencies.
13182
09f6ff02
EZ
131832011-03-17 Eli Zaretskii <eliz@gnu.org>
13184
13185 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
13186
29a6015a
PE
131872011-03-17 Paul Eggert <eggert@cs.ucla.edu>
13188
a3a6c54e
PE
13189 Fix more problems found by GCC 4.5.2's static checks.
13190
b766f867
PE
13191 * process.c (make_serial_process_unwind, send_process_trap):
13192 (sigchld_handler): Now static.
13193
be02381c
PE
13194 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
13195 That way, the code declares only the vars that it needs.
13196 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
13197 * s/cygwin.h (PTY_ITERATION): Likewise.
13198 * s/darwin.h (PTY_ITERATION): Likewise.
13199 * s/gnu-linux.h (PTY_ITERATION): Likewise.
13200
57048744
PE
13201 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
13202 * process.c (allocate_pty): Don't declare stb unless it's needed.
13203
7914961c 13204 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
13205 (CONSTANTLIM): Remove; unused.
13206 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
13207 Define only if needed.
7914961c 13208
b3967b18
PE
13209 * unexelf.c (unexec): Name an expression,
13210 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
13211 Use a different way to cause a compilation error if anyone uses
13212 n rather than nn, a way that does not involve shadowing.
73366a00 13213 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 13214
29a6015a
PE
13215 * deps.mk (unexalpha.o): Remove; unused.
13216
43cfc33e 13217 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 13218 * unexec.h: New file.
ce701a33
PE
13219 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
13220 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
13221 Depend on unexec.h.
13222 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
13223 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
13224 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 13225 Change as necessary to match prototype in unexec.h.
ce701a33 13226
01f44d5a
PE
13227 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
13228 shadowing.
4f63c6bb 13229 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 13230
a6670b0b
PE
13231 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
13232 Rename locals to avoid shadowing.
13233
cef2010d 13234 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 13235 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 13236
d4d7173a
PE
13237 * print.c (Fredirect_debugging_output): Fix pointer signedess.
13238
f08b802a
PE
13239 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
13240 warning when compiling print.c.
13241
3ddb0639
PE
13242 * font.c (font_unparse_fcname): Abort in an "impossible" situation
13243 instead of using an uninitialized var.
5ad03b97 13244 (font_sort_entities): Mark var as initialized.
3ddb0639 13245
170a2692
PE
13246 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
13247
e663c700
PE
13248 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
13249 pointers to constants.
89bc529a 13250 (font_parse_fcname): Remove unused vars.
7b81e2d0 13251 (font_delete_unmatched): Now static.
ea838e10 13252 (font_get_spec): Remove; unused.
13a547c6
PE
13253 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
13254 (font_update_drivers, Ffont_get_glyphs, font_add_log):
13255 Rename or move locals to avoid shadowing.
e663c700 13256
2a80c887 13257 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 13258 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 13259
1384fa33 13260 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 13261 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 13262
8b2c52e9
PE
13263 * alloc.c (mark_backtrace): Move decl from here ...
13264 * lisp.h: ... to here, so that it can be checked.
13265
475545b5 13266 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 13267 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
13268 (lisp_indirect_variable): Name an expression,
13269 to avoid gcc -Wbad-function-cast warning.
1faed8ae 13270 (Fdefvar): Rename locals to avoid shadowing.
475545b5 13271
b1349114 13272 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 13273 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 13274 Use const pointer when appropriate.
b1349114 13275
a2928364
PE
13276 * lisp.h (get_system_name, get_operating_system_release):
13277 Move decls here, to check interfaces.
13278 * process.c (get_operating_system_release): Move decl to lisp.h.
13279 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
13280 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
13281 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
13282 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
13283 (Fformat_time_string, Fencode_time, Finsert_char):
13284 (Ftranslate_region_internal, Fformat):
13285 Rename or remove local vars to avoid shadowing.
9710023e 13286 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 13287
a415e694
PE
13288 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
13289 avoid shadowing.
13290
8ef4622d
PE
13291 * lisp.h (eassert): Check that the argument compiles, even if
13292 ENABLE_CHECKING is not defined.
13293
946f9a5b
PE
13294 * data.c (Findirect_variable): Name an expression, to avoid
13295 gcc -Wbad-function-cast warning.
112396d6 13296 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 13297 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
13298 (Fmake_variable_buffer_local, Fmake_local_variable):
13299 Mark variables as initialized.
52746918 13300 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 13301
e5aab7e7 13302 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
13303 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
13304 Rename locals to avoid shadowing.
dff45157
PE
13305 (mark_stack): Move local variables into the #ifdef region where
13306 they're used.
7bc26fdb
PE
13307 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
13308 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
13309 needed otherwise.
13310 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
13311 (GC_STRING_CHARS): Remove; not used.
d40d4be1 13312 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 13313
e5aab7e7
PE
13314 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
13315 avoids undefined behavior in theory.
13316
4da60324
PE
13317 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
13318
88043301
PE
13319 Use functions, not macros, for up- and down-casing (Bug#8254).
13320 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13321 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
13322 to use the following functions instead of these macros.
13323 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
13324 EMACS_INT, since callers assume the returned value fits in int.
13325 (upcase1): Likewise, for UPCASE_TABLE.
13326 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 13327 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 13328 the race-condition problem in the old DOWNCASE.
88043301 13329
19ed5445
PE
13330 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
13331 Rename locals to avoid shadowing.
13332 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
13333 (regex_compile, re_search_2, re_match_2_internal):
13334 Remove unused local vars.
952db0d7
PE
13335 (FREE_VAR): Rewrite so as not to use empty "else",
13336 which gcc can warn about.
da053e48 13337 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
13338 (RETALLOC_IF): Define only if needed.
13339 (WORDCHAR_P): Likewise. This one is never needed, but is used
13340 only in a comment talking about a compiler bug, so put inside
13341 the #if 0 of that comment.
13342 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
13343 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
13344 Remove; unused.
19ed5445 13345
1f3561e4 13346 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
13347 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
13348 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 13349
ded6f8f7
PE
13350 * search.c (simple_search): Remove unused var.
13351
dbd37a95
PE
13352 * dired.c (compile_pattern): Move decl from here ...
13353 * lisp.h: ... to here, so that it can be checked.
13354 (struct re_registers): New forward decl.
13355
7e47afad
PE
13356 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
13357
85f24f61
PE
13358 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
13359 All uses changed.
13360 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
13361 Rename locals to avoid shadowing.
5671df8f 13362 (Fvertical_motion): Mark locals as initialized.
85f24f61 13363
181aa2be 13364 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 13365 (casify_region): Mark local as initialized.
181aa2be 13366
930d429c
PE
13367 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
13368
7082eac6
PE
13369 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
13370 New macros, so that the caller can use some names other than
13371 gcpro1, gcpro2, etc.
13372 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
13373 of the new macros.
13374 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
13375 argument, for consistency with GCPRO2_VAR, etc: it is now the
13376 prefix of the variable, not the variable itself. All uses
13377 changed.
38b2c076
PE
13378 * dired.c (directory_files_internal, file_name_completion):
13379 Rename locals to avoid shadowing.
13380
15206ed9
PE
13381 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
13382 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
13383 dired.c's scmp function, had undefined behavior.
13384 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13385 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
13386 * buffer.h: ... to here, because these macros use current_buffer,
13387 and the new implementation with inline functions needs to have
13388 current_buffer in scope now, rather than later when the macros
13389 are used.
13390 (downcase, upcase1): New static inline functions.
13391 (DOWNCASE, UPCASE1): Reimplement using these functions.
13392 This avoids undefined behavior in expressions like
13393 DOWNCASE (x) == DOWNCASE (y), which previously suffered
13394 from race conditions in accessing the global variables
13395 case_temp1 and case_temp2.
13396 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
13397 * lisp.h (case_temp1, case_temp2): Remove their decls.
13398 * character.h (ASCII_CHAR_P): Move from here ...
13399 * lisp.h: ... to here, so that the inline functions mentioned
13400 above can use them.
13401
4a6bea26
PE
13402 * dired.c (directory_files_internal_unwind): Now static.
13403
f14b7e14
PE
13404 * fileio.c (file_name_as_directory, directory_file_name):
13405 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
13406 Now static.
2893f146
PE
13407 (file_name_as_directory): Use const pointers when appropriate.
13408 (Fexpand_file_name): Likewise. In particular, newdir might
13409 point at constant storage, so make it a const pointer.
fd4ead52 13410 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
13411 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
13412 signedness issues.
f839df0c
PE
13413 (Fset_file_times, Finsert_file_contents, auto_save_error):
13414 Rename locals to avoid shadowing.
f14b7e14 13415
5716756e 13416 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
13417 (Ftry_completion, Fall_completions): Rename or remove locals
13418 to avoid shadowing.
5716756e 13419
b4c3046a
PE
13420 * marker.c (bytepos_to_charpos): Remove; unused.
13421
b45db522
PE
13422 * lisp.h (verify_bytepos, count_markers): New decls,
13423 so that gcc does not warn that these functions aren't declared.
13424
85876d07
PE
13425 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
13426 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 13427 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 13428 (copy_text): Remove unused local var.
85876d07 13429
03d78a21 13430 * filelock.c (within_one_second): Now static.
b3dd38ab 13431 (lock_file_1): Rename local to avoid shadowing.
03d78a21 13432
5df8f01b
PE
13433 * buffer.c (fix_overlays_before): Mark locals as initialized.
13434 (fix_start_end_in_overlays): Likewise. This function should be
13435 simplified by using pointers-to-pointers, but that's a different
13436 matter.
b1d876f1 13437 (switch_to_buffer_1): Now static.
8f54f30a
PE
13438 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
13439 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 13440
a70072c9 13441 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 13442 Fix pointer signedness issue.
edced198
PE
13443 (sys_subshell): Mark local as volatile if checking for lint,
13444 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 13445 (MAXPATHLEN): Define only if needed.
a70072c9 13446
a0977c44
PE
13447 * process.c (serial_open, serial_configure): Move decls from here ...
13448 * systty.h: ... to here, so that they can be checked.
13449
a884fdcc
PE
13450 * fns.c (get_random, seed_random): Move extern decls from here ...
13451 * lisp.h: ... to here, so that they can be checked.
13452
604efe86 13453 * sysdep.c (reset_io): Now static.
b8950c94 13454 (wait_for_termination_signal): Remove; unused.
604efe86 13455
38fc62d9
PE
13456 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
13457 (copy_keymap_item, append_key, push_text_char_description):
13458 Now static.
1004a21a 13459 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 13460 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
13461 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
13462 (describe_map_tree):
13463 Rename locals to avoid shadowing.
38fc62d9 13464
2f2650da
PE
13465 * keyboard.c: Declare functions static if they are not used elsewhere.
13466 (echo_char, echo_dash, cmd_error, top_level_2):
13467 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
13468 (read_char, kbd_buffer_get_event, make_lispy_position):
13469 (make_lispy_event, make_lispy_movement, apply_modifiers):
13470 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
13471 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
13472 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 13473 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 13474 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 13475
a053e86c 13476 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
13477 (mark_kboards): Move decl here ...
13478 * alloc.c (mark_kboards): ... from here.
a053e86c 13479
4752793e
PE
13480 * lisp.h (force_auto_save_soon): New decl.
13481
74f10ca7 13482 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
13483 (DEFINE_DUMMY_FUNCTION): New macro.
13484 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
13485 Use it.
c03cd23f
PE
13486 (main): Add casts to avoid warnings
13487 if GCC considers string literals to be constants.
74f10ca7 13488
022e70d4
PE
13489 * lisp.h (fatal_error_signal): Add decl, since it's exported.
13490
59d6fe83
PE
13491 * dbusbind.c: Pointer signedness fixes.
13492 (xd_signature, xd_append_arg, xd_initialize):
13493 (Fdbus_call_method, Fdbus_call_method_asynchronously):
13494 (Fdbus_method_return_internal, Fdbus_method_error_internal):
13495 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
13496 (Fdbus_register_signal): Use SSDATA when the context wants char *.
13497
78320123
PE
13498 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
13499 if GCC considers string literals to be constants.
49cebcca 13500 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 13501
35ac2a97
SM
135022011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
13503
fb103ca9
SM
13504 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
13505 (print_preprocess, print_object): New macro to fix last change.
13506
35ac2a97
SM
13507 * print.c (print_preprocess): Don't forget font objects.
13508
62973b41
JB
135092011-03-16 Juanma Barranquero <lekktu@gmail.com>
13510
13511 * emacs.c (USAGE3): Doc fixes.
13512
0e48bb22
AS
135132011-03-15 Andreas Schwab <schwab@linux-m68k.org>
13514
13515 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
13516 structure.
13517
7684e57b
JB
135182011-03-14 Juanma Barranquero <lekktu@gmail.com>
13519
13520 * lisp.h (VWindow_system, Qfile_name_history):
13521 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
13522 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
13523 (w32_system_caret_x, w32_system_caret_y): Declare extern.
13524
13525 * w32select.c: Don't #include "keyboard.h".
c96bbc66 13526 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
13527
13528 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
13529 * w32console.c (detect_input_pending, read_input_pending)
13530 (encode_terminal_code):
13531 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
13532 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
13533 (w32_system_caret_y, Qfile_name_history):
13534 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
13535 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
13536 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
13537 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
13538 * w32proc.c (Qlocal, report_file_error):
13539 * w32term.c (Vwindow_system, updating_frame):
13540 * w32uniscribe.c (initialized, uniscribe_font_driver):
13541 Remove unneeded extern declarations.
13542
2aa46d6c
CY
135432011-03-14 Chong Yidong <cyd@stupidchicken.com>
13544
c96bbc66 13545 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 13546
cffc6f3b
CY
135472011-03-13 Chong Yidong <cyd@stupidchicken.com>
13548
13549 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
13550 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
13551 These macros can no longer be used for assignment.
13552
44f230aa
SM
13553 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
13554 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
13555 (record_buffer_markers, fetch_buffer_markers): New functions for
13556 recording and fetching special buffer markers.
13557 (set_buffer_internal_1, set_buffer_temp): Use them.
13558
13559 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
13560
13561 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
13562
13563 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
13564 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
13565
13566 * xdisp.c (hscroll_window_tree):
13567 (reconsider_clip_changes): Use PT instead of BUF_PT.
13568
d251f04b
EZ
135692011-03-13 Eli Zaretskii <eliz@gnu.org>
13570
13571 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
13572 $(EMACS_ROOT)/lib/intprops.h.
13573
f0c77cd1
PE
135742011-03-13 Paul Eggert <eggert@cs.ucla.edu>
13575
3eca4629
PE
13576 Fix more problems found by GCC 4.5.2's static checks.
13577
7c86ee98
PE
13578 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
13579 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
13580 (xg_free_frame_widgets): Make it clear that a local variable is
13581 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
13582 (gdk_window_get_screen): Make it clear that this macro is needed
13583 only if USE_GTK_TOOLTIP.
1e5524e7
PE
13584 (int_gtk_range_get_value): New function, which avoids a diagnostic
13585 from gcc -Wbad-function-cast.
13586 (xg_set_toolkit_scroll_bar_thumb): Use it.
13587 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
13588 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
13589 (get_utf8_string, xg_get_file_with_chooser):
13590 Rename locals to avoid shadowing.
13591 (create_dialog): Move locals to avoid shadowing.
7c86ee98 13592
41729b81
PE
13593 * xgselect.c (xg_select): Remove unused var.
13594
f0c77cd1
PE
13595 * image.c (four_corners_best): Mark locals as initialized.
13596 (gif_load): Initialize transparent_p to zero (Bug#8238).
13597 Mark another local as initialized.
ec6cf4c6 13598 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 13599
ce0ad53d 13600 * image.c (clear_image_cache): Now static.
d5d5a617 13601 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 13602 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
13603 (x_edge_detection): Remove unnecessary cast that
13604 gcc -Wbad-function-cast diagnoses.
2037898d 13605 (gif_load): Fix pointer signedness.
6ae141d6
PE
13606 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
13607 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 13608
33383987 136092011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 13610
d32df629
PE
13611 Improve quality of tests for time stamp overflow.
13612 For example, without this patch (encode-time 0 0 0 1 1
13613 1152921504606846976) returns the obviously-bogus value (-948597
13614 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
13615 reports time overflow. See
13616 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
13617 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
13618 * editfns.c: Include limits.h and intprops.h.
13619 (TIME_T_MIN, TIME_T_MAX): New macros.
13620 (time_overflow): Move earlier, to before first use.
13621 (hi_time, lo_time): New functions, for an accurate test for
13622 out-of-range times.
13623 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
13624 (Fget_internal_run_time): Don't assume time_t fits in int.
13625 (make_time): Use list2 instead of Fcons twice.
13626 (Fdecode_time): More accurate test for out-of-range times.
13627 (check_tm_member): New function.
13628 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
13629 (lisp_time_argument): Don't rely on undefined left-shift and
13630 right-shift behavior when checking for time stamp overflow.
8be6f318 13631
fe31d94c
PE
13632 * editfns.c (time_overflow): New function, refactoring common code.
13633 (Fformat_time_string, Fdecode_time, Fencode_time):
13634 (Fcurrent_time_string): Use it.
13635
8be6f318
PE
13636 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
13637 * dired.c (make_time): Move to ...
13638 * editfns.c (make_time): ... here.
13639 * systime.h: Note the move.
13640
09d9db2c 136412011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 13642
126bc0dc
YM
13643 * fringe.c (update_window_fringes): Remove unused variables.
13644
c47cbdfd
YM
13645 * unexmacosx.c (copy_data_segment): Also copy __got section.
13646 (Bug#8223)
13647
7ac80be9
EZ
136482011-03-12 Eli Zaretskii <eliz@gnu.org>
13649
c96bbc66 13650 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
13651 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
13652 Constify `char *' arguments and their references according to
13653 prototypes in tparam.h.
13654
ecb0f94d 13655 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 13656
7ac80be9
EZ
13657 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
13658 Adapt all references accordingly.
13659
13660 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
13661
ef1fd07e
TT
136622011-03-11 Tom Tromey <tromey@redhat.com>
13663
13664 * buffer.c (syms_of_buffer): Remove obsolete comment.
13665
7ef4b50c
EZ
136662011-03-11 Eli Zaretskii <eliz@gnu.org>
13667
13668 * termhooks.h (encode_terminal_code): Declare prototype.
13669
13670 * msdos.c (encode_terminal_code): Don't declare prototype.
13671
13672 * term.c (encode_terminal_code): Now external again, used by
13673 w32console.c and msdos.c.
13674
44f230aa
SM
13675 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
13676 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 13677
4b1ec863 136782011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 13679
1714f52b 13680 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 13681
4b1ec863
PE
13682 * fringe.c (update_window_fringes): Mark locals as initialized
13683 (Bug#8227).
13684 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 13685
524c7aa6
PE
13686 * alloc.c (mark_fringe_data): Move decl from here ...
13687 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
13688 to check its interface.
13689 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
13690
a5c0af81 13691 * fontset.c (free_realized_fontset): Now static.
7519b8cd 13692 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 13693 (fontset_font): Mark local as initialized.
a9a06e0b 13694 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 13695
b4716021
PE
13696 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
13697
811e9bac 13698 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 13699 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
13700 (x_own_selection, Fx_disown_selection_internal): Rename locals
13701 to avoid shadowing.
13702 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 13703
7e3ab302
PE
13704 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
13705 so that the caller can use some name other than gcpro1.
13706 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
13707 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13708 (Fx_backspace_delete_keys_p):
13709 Use them to avoid shadowing, and rename vars to avoid shadowing.
13710 (x_decode_color, x_set_name, x_window): Now static.
6b437900 13711 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 13712 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
13713 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
13714 Remove unused locals.
7e3ab302
PE
13715 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13716 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
13717 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
13718 macros.
f78faa98 13719
e2b13473
PE
13720 * xterm.h (x_mouse_leave): New decl.
13721
77f23912
PE
13722 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
13723 Remove unused functions.
cdf4ba58
PE
13724 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
13725 (x_calc_absolute_position): Now static.
7411c686 13726 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 13727 Don't declare local "event" unless it's used.
ed7bf3a5
PE
13728 (x_iconify_frame, x_free_frame_resources): Don't declare locals
13729 unless they are used.
38d0b34a
PE
13730 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
13731 (x_fatal_error_signal): Remove; not used.
a6067996
PE
13732 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
13733 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
13734 (x_error_catcher, x_connection_closed, x_error_handler):
13735 (x_error_quitter, xembed_send_message, x_iconify_frame):
13736 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 13737 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 13738 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 13739
44f230aa
SM
13740 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
13741 Rename or move locals to avoid shadowing.
6b463e58 13742 (tty_defined_color, merge_face_heights): Now static.
5967d051 13743 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
13744 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
13745 does not deduce is never used uninitialized.
73719eba
PE
13746 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
13747 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 13748
426994c3 13749 * terminal.c (store_terminal_param): Now static.
5489860b 13750
032f1620 13751 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 13752 (set_frame_menubar): Remove unused local.
d4323972 13753 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
13754 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
13755 since they might point to immutable storage.
281585b0
PE
13756 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
13757 since it's unused otherwise.
032f1620 13758
367c19e5 13759 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 13760 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
13761 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
13762 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 13763 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
13764 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
13765 does not deduce are never used uninitialized.
70739cbe 13766
07b48fa9
PE
13767 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
13768
8868a238 13769 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
13770 * window.c (window_loop, size_window):
13771 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 13772
7e5cf297 13773 * window.c (display_buffer): Now static.
d6550a9f
PE
13774 (size_window): Mark variables that gcc -Wuninitialized
13775 does not deduce are never used uninitialized.
a586633d
PE
13776 * window.h (check_all_windows): New decl, to forestall
13777 gcc -Wmissing-prototypes diagnostic.
5b555da1 13778 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 13779
f6095868
PE
13780 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
13781 shadowing.
13782 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
13783 Include <limits.h>.
13784 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
13785 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
13786 (load_charset_map): Mark variables that gcc -Wuninitialized
13787 does not deduce are never used uninitialized.
53df7c11 13788 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 13789
f38b440c
PE
13790 * coding.c (coding_set_source, coding_set_destination):
13791 Use "else { /* comment */ }" rather than "else /* comment */;"
13792 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
13793 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
13794 a block, when the outer 'i' will do.
13795 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
13796 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
13797 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
13798 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
13799 (Fdecode_sjis_char, Fdefine_coding_system_internal):
13800 Rename locals to avoid shadowing.
13801 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
13802 * coding.c (emacs_mule_char, encode_invocation_designation):
13803 Now static, since they're not used elsewhere.
413bb2db 13804 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 13805 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
13806 (decode_coding_emacs_mule): Mark variables that gcc
13807 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
13808 (detect_coding_iso_2022): Initialize a local variable that might
13809 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 13810 this initialization is needed. (Bug#8211)
5f58e762
PE
13811 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
13812 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
13813 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
13814 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
13815 Remove unused macros.
f38b440c 13816
232b38b9 13817 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 13818 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 13819 * character.c (string_count_byte8): Likewise.
232b38b9 13820
fb90da1b
PE
13821 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
13822 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
13823
fb93dbc2
PE
13824 * chartab.c (copy_sub_char_table): Now static, since it's not used
13825 elsewhere.
5c156ace
PE
13826 (sub_char_table_ref_and_range, char_table_ref_and_range):
13827 Rename locals to avoid shadowing.
bbcd0949 13828 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 13829
7d3b3862 13830 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 13831 (BIDI_BOB): Remove unused macro.
7d3b3862 13832
6be7d3da
PE
13833 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
13834 deduce are never used uninitialized.
c2ed9c8b 13835 * term.c (encode_terminal_code): Likewise.
6be7d3da 13836
75f8807f 13837 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 13838
50938595
PE
13839 * tparam.h: New file.
13840 * term.c, tparam.h: Include it.
13841 * deps.mk (term.o, tparam.o): Depend on tparam.h.
13842 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
13843 Move these decls to tparam.h, and make them agree with what
13844 is actually in tparam.c. The previous trick of using incompatible
13845 decls in different modules does not conform to the C standard.
13846 All callers of tparam changed to use tparam's actual API.
13847 * tparam.c (tparam1, tparam, tgoto):
13848 Use const pointers where appropriate.
13849
fbceeba2
PE
13850 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
13851 * cm.h (struct cm): Likewise.
13852 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
13853 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
13854 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
13855 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
13856 (turn_on_face, init_tty): Likewise.
13857 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 13858
7f3f1250
PE
13859 * term.c (term_mouse_position): Rename local to avoid shadowing.
13860
e6ca6543
PE
13861 * alloc.c (mark_ttys): Move decl from here ...
13862 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
13863
c40f8d15
AS
138642011-03-11 Andreas Schwab <schwab@linux-m68k.org>
13865
13866 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
13867
cfe0661d
JB
138682011-03-09 Juanma Barranquero <lekktu@gmail.com>
13869
13870 * search.c (compile_pattern_1): Remove argument regp, unused since
13871 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
13872 (compile_pattern): Don't pass it.
13873
0afb4571
J
138742011-03-08 Jan Djärv <jan.h.d@swipnet.se>
13875
13876 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
13877 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
13878 for ! HAVE_GTK3.
13879 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
13880
13881 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
13882
13883 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
13884 gdk_window_get_screen, gdk_window_get_geometry,
13885 gdk_x11_window_lookup_for_display and GDK_KEY_g.
13886 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
13887 (xg_get_pixbuf_from_pixmap): New function.
13888 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
13889 to Pixmap, take frame as parameter, remove GdkColormap parameter.
13890 Call xg_get_pixbuf_from_pixmap instead of
13891 gdk_pixbuf_get_from_drawable.
13892 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
13893 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
13894 (xg_check_special_colors): Use GtkStyleContext and its functions
13895 for HAVE_GTK3.
13896 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
13897 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
13898 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
13899 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
13900 Call gtk_widget_get_preferred_size.
0afb4571
J
13901 (xg_frame_resized): gdk_window_get_geometry only takes 5
13902 parameters.
44f230aa
SM
13903 (xg_win_to_widget, xg_event_is_for_menubar):
13904 Call gdk_x11_window_lookup_for_display.
0afb4571
J
13905 (xg_set_widget_bg): New function.
13906 (delete_cb): New function.
895009e1 13907 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 13908 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
13909 (xg_set_background_color): Call xg_set_widget_bg.
13910 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
13911 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
13912 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
13913 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
13914 if ! HAVE_GTK3.
13915 (update_frame_tool_bar): Call gtk_widget_hide.
13916 (xg_initialize): Use GDK_KEY_g.
13917
13918 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
13919 if ! HAVE_GTK3
13920 (x_session_initialize): Call gdk_x11_set_sm_client_id.
13921
13922 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
13923 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
13924 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
13925
1c2cc4ef
JB
139262011-03-08 Juanma Barranquero <lekktu@gmail.com>
13927
13928 * w32xfns.c (select_palette): Check success of RealizePalette against
13929 GDI_ERROR, not zero.
13930
33383987 13931See ChangeLog.11 for earlier changes.
aac0c6e3
MR
13932
13933;; Local Variables:
13934;; coding: utf-8
aac0c6e3
MR
13935;; End:
13936
2f097256 13937 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
13938
13939 This file is part of GNU Emacs.
13940
13941 GNU Emacs is free software: you can redistribute it and/or modify
13942 it under the terms of the GNU General Public License as published by
13943 the Free Software Foundation, either version 3 of the License, or
13944 (at your option) any later version.
13945
13946 GNU Emacs is distributed in the hope that it will be useful,
13947 but WITHOUT ANY WARRANTY; without even the implied warranty of
13948 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13949 GNU General Public License for more details.
13950
13951 You should have received a copy of the GNU General Public License
13952 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.