* xdisp.c (set_cursor_from_row): Simplify conditionals,
[bpt/emacs.git] / src / ChangeLog
CommitLineData
0324f3af
PE
12011-10-12 Paul Eggert <eggert@cs.ucla.edu>
2
b5525cac
PE
3 * xdisp.c (set_cursor_from_row): Simplify conditionals,
4 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
5
0324f3af
PE
6 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
7 Some packages use them to denote characters with modifiers.
8
e9b5f888
AS
92011-10-11 Andreas Schwab <schwab@linux-m68k.org>
10
11 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
12 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
13 matching a pp-number. Rename parameter var to var1.
14
127827c0
SM
152011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
16
17 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
18
c8fd3bd0
GM
192011-10-08 Glenn Morris <rgm@gnu.org>
20
21 * callint.c (Fcall_interactively): Give a more explicit error for the
22 'c' case with a non-character input. (Bug#8479)
23
352ec8ff
EZ
242011-10-08 Eli Zaretskii <eliz@gnu.org>
25
03669ccb
EZ
26 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
27 lines.
7061c986
EZ
28 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
29 lines that are hscrolled on the left.
03669ccb 30
352ec8ff
EZ
31 * dispnew.c (buffer_posn_from_coords): Account for a possible
32 presence of header-line. (Bug#4426)
33
a66cfb1c
SM
342011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
35
36 * buffer.c (syms_of_buffer) <enable-multibyte-characters>: Don't
37 advertise functionality which we discourage or doesn't work.
38
7c5ee88e
PE
392011-10-07 Paul Eggert <eggert@cs.ucla.edu>
40
41 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
42 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
43 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
44 this makes Emacs dump core during garbage collection on rare
45 occasions. sizeof is obviously inferior to offsetof here, so
46 stick with offsetof.
47 (GC_POINTER_ALIGNMENT): New macro.
48 (mark_memory): Omit 3rd (offset) arg; caller changed.
49 Don't assume EMACS_INT alignment is the same as pointer alignment.
50
df1bbe5b
SM
512011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
52
53 * keyboard.c (read_key_sequence_remapped): New var.
54 (read_key_sequence): Compute remapping in the right buffer.
55 (command_loop_1): Use read_key_sequence's remapping directly.
56
51553db6
SM
572011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
58
32c1fffd
SM
59 * dired.c (file_name_completion): Don't expand file name.
60 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
61 before checking file name handler.
62
51553db6
SM
63 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
64 they've been requested explicitly (bug#9591).
65
b6bd1599 662011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
67
68 * keymap.c (Fsingle_key_description): Use make_specified_string
69 instead of build_string to build string from push_key_description.
70 (Bug#5193)
71
f701dc2a
PE
722011-09-30 Paul Eggert <eggert@cs.ucla.edu>
73
4222c55d
PE
74 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
75 This fixes a Y2038 bug on 64-bit hosts.
76 * buffer.c (reset_buffer):
77 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
78 (Fclear_buffer_auto_save_failure):
79 Use 0, not -1, to represent an unset failure time, since time_t
80 might not be signed.
81
f701dc2a
PE
82 Remove dependency on glibc malloc internals.
83 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
84 Move back here from lisp.h, but with their new implementations.
85 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
86 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
87 * charset.c (charset_table_init): New static var.
88 (syms_of_charset): Use it instead of xmalloc. This removes a
89 dependency on glibc malloc internals. See Eli Zaretskii's comment in
90 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
91 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
92 Move back to alloc.c.
93 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
94 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
95
9ceebf39
JD
962011-09-30 Jan Djärv <jan.h.d@swipnet.se>
97
98 * nsterm.m (windowDidResize): Call x_set_window_size only when
99 ns_in_resize is true. Otherwise set pixelwidth/height and
100 call change_frame_size (Bug#9628).
101
cb993c58
PE
1022011-09-30 Paul Eggert <eggert@cs.ucla.edu>
103
3930c88b
PE
104 Port --enable-checking=all to Fedora 14 x86-64.
105 * charset.c (syms_of_charset): Also account for glibc malloc's
106 internal overhead when calculating the initial malloc maximum.
107
cb993c58
PE
108 Port --enable-checking=all to Fedora 14 x86.
109 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
110 Move to lisp.h.
111 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
112 (overrun_check_realloc, overrun_check_free):
113 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
114 That way, xmalloc returns a properly-aligned pointer even if
115 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
116 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
117 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
118 into account when calculating the initial malloc maximum.
119 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
120 Move here from alloc.c, so that charset.c can use it too.
121 Properly align; the old code wasn't right for common 32-bit hosts
122 when configured with --enable-checking=all.
123 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
124 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
125
31bed486
EZ
1262011-09-29 Eli Zaretskii <eliz@gnu.org>
127
04c70788 128 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
129 use EDOM.
130
fbcaa2f3
EZ
1312011-09-28 Eli Zaretskii <eliz@gnu.org>
132
133 * xdisp.c (compute_display_string_end): If there's no display
134 string at CHARPOS, return -1.
135
136 * bidi.c (bidi_fetch_char): When compute_display_string_end
137 returns a negative value, treat the character as a normal
138 character not covered by a display string. (Bug#9624)
139
a239d4e9
JB
1402011-09-28 Juanma Barranquero <lekktu@gmail.com>
141
142 * lread.c (Fread_from_string): Fix typo in docstring.
143
88652fd5
EZ
1442011-09-27 Eli Zaretskii <eliz@gnu.org>
145
146 * xdisp.c (handle_invisible_prop): If invisible text ends on a
147 newline, reseat the iterator instead of bidi-iterating there one
148 character at a time. (Bug#9610)
32c1fffd
SM
149 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
150 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 151
ed497dd4
AS
1522011-09-27 Andreas Schwab <schwab@linux-m68k.org>
153
154 * lread.c (readevalloop): Use correct code for NBSP.
155 (read1): Likewise. (Bug#9608)
156
b2bf61aa
MA
1572011-09-25 Michael Albinus <michael.albinus@gmx.de>
158
159 * dbusbind.c (Fdbus_register_signal): When service is not
160 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
161
32bbb17c
GM
1622011-09-25 Glenn Morris <rgm@gnu.org>
163
164 * buffer.c (truncate-lines): Doc fix.
165
94e0933e
CY
1662011-09-24 Chong Yidong <cyd@stupidchicken.com>
167
168 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
169 (Fset_window_next_buffers): Doc fix.
170
cddde921
GM
1712011-09-24 Glenn Morris <rgm@gnu.org>
172
173 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
174
1260aef1
PE
1752011-09-24 Paul Eggert <eggert@cs.ucla.edu>
176
25b4bfa0
PE
177 Fix minor problems found by static checking.
178 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
179 * indent.c (Fvertical_motion): Fix == vs = typo.
180
e3cbd34b
EZ
1812011-09-24 Eli Zaretskii <eliz@gnu.org>
182
a66cfb1c
SM
183 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
184 Default value is now t. Doc fix.
6bf7006f 185
e3cbd34b 186 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 187 logic when moving up, not only when moving down. Fix the
e3cbd34b 188 confusing name and values of the it_overshoot_expected variable;
32c1fffd 189 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
190
191 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
192 CHARPOS is covered by a display string which includes newlines.
193 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
194 is covered by a display string with embedded newlines.
195
a3de0cbd
MA
1962011-09-24 Michael Albinus <michael.albinus@gmx.de>
197
198 * dbusbind.c (Fdbus_register_signal): Add match rule to
199 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
200 (Fdbus_register_method, Vdbus_registered_objects_table):
201 Fix docstring.
a3de0cbd 202
b260039d
JM
2032011-09-24 Jim Meyering <meyering@redhat.com>
204
32c1fffd 205 do not ignore write error for any output size
b260039d
JM
206 The previous change was incomplete.
207 While it makes emacs --batch detect the vast majority of stdout
208 write failures, errors were still ignored whenever the output size is
209 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
210 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
211 && echo FAIL: ignored write error
212 FAIL: ignored write error
213 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
214 && echo FAIL: ignored write error
215 FAIL: ignored write error
216 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
217
8eca8a7c
AS
2182011-09-23 Andreas Schwab <schwab@linux-m68k.org>
219
220 * emacs.c (Fkill_emacs): In noninteractive mode exit
221 non-successfully if a write error occurred on stdout. (Bug#9574)
222
3341db62
EZ
2232011-09-21 Eli Zaretskii <eliz@gnu.org>
224
225 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
226 the xassert test.
227
228 * dispextern.h (struct it): Update the comment documenting what
229 can it->OBJECT be.
230
8c203dbf
EZ
2312011-09-20 Eli Zaretskii <eliz@gnu.org>
232
233 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
234 a display string, extend search for cursor position to end of row.
235 (find_row_edges): If the row ends in a newline from a display
236 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
237 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
238 (Fcurrent_bidi_paragraph_direction): Fix search for previous
239 non-empty line. Fixes confusing cursor motion with arrow keys at
240 the beginning of a line that starts with whitespace.
8c203dbf 241
a4824228
LMI
2422011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
243
244 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
245 (bug#9493).
246
33ed493b
CY
2472011-09-18 Chong Yidong <cyd@stupidchicken.com>
248
249 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
250 boolean (Bug#9154).
251
56cd55c8
EZ
2522011-09-18 Eli Zaretskii <eliz@gnu.org>
253
254 * xdisp.c (display_line): Record maximum and minimum buffer
255 positions even if no glyphs were produced (e.g., by a zero-width
256 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
257 buffer positions that will be removed from the glyph row because
258 they don't fit.
c02dcedf
EZ
259 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
260 column is beyond frame width: don't subtract 1 "pixel" when
261 computing width of the stretch.
3e62b7e0
EZ
262 (reseat_at_next_visible_line_start): Undo the change made on
263 2011-09-17 that saved paragraph information and restored it after
264 the call to `reseat'. (Bug#9545)
56cd55c8 265
5ed99d36 2662011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
267
268 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
269 and turn window cursor on if cleared (Bug#9415).
270
5ed99d36 2712011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
272
273 * search.c (boyer_moore): Take unibyte characters from pattern
274 literally. (Bug#9458)
275
9bade7b2
EZ
2762011-09-18 Eli Zaretskii <eliz@gnu.org>
277
278 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
279
e5e9d610
PE
2802011-09-18 Paul Eggert <eggert@cs.ucla.edu>
281
87e4427a
PE
282 Fix minor problem found by static checking.
283 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
284 initialized, to pacify gcc -Wuninitialized.
285
e5e9d610
PE
286 * fileio.c: Report proper errno when syscall falls.
287 (Finsert_file_contents): Save and restore errno,
288 so that report_file_error outputs the correct diagnostic.
289 (Fwrite_region) [CLASH_DETECTION]: Likewise.
290
a1674f0b
EZ
2912011-09-18 Eli Zaretskii <eliz@gnu.org>
292
293 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
294
fbfb6dd4
EZ
2952011-09-17 Eli Zaretskii <eliz@gnu.org>
296
297 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
298 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
299
bb187662
EZ
3002011-09-17 Eli Zaretskii <eliz@gnu.org>
301
1137e8b8
EZ
302 * xdisp.c (reseat_at_next_visible_line_start): Keep information
303 about the current paragraph and restore it after the call to
304 reseat.
305
306 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
307 (bidi_find_paragraph_start): Search back for paragraph beginning
308 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
309 (bidi_move_to_visually_next): Only trigger paragraph-related
310 computations when the last character is a newline or at EOB, not
311 just any NEUTRAL_B. (Bug#9470)
312
bb187662
EZ
313 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
314 truncated lines if point is covered by a display string. (Bug#9524)
315
2e621251
PE
3162011-09-16 Paul Eggert <eggert@cs.ucla.edu>
317
318 * xselect.c: Relax test for outgoing X longs (Bug#9498).
319 (cons_to_x_long): New function.
320 (lisp_data_to_selection_data): Use it. Correct the test for
321 short-versus-long data; it was negated. Break out of vector
322 loop, for efficiency, when a long datum is discovered.
323
91a15bc6
SM
3242011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
325
326 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
327
b41c3a35
EZ
3282011-09-16 Eli Zaretskii <eliz@gnu.org>
329
330 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
331 GCC PR/17406) by declaring this function with external scope.
332
7812ba2d
PE
3332011-09-15 Paul Eggert <eggert@cs.ucla.edu>
334
335 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
336 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
337
cf7edc2a
AS
3382011-09-15 Andreas Schwab <schwab@linux-m68k.org>
339
340 * editfns.c (Fformat): Correctly handle text properties on "%%".
341
bd01620e
EZ
3422011-09-15 Eli Zaretskii <eliz@gnu.org>
343
344 * xterm.c (x_draw_composite_glyph_string_foreground):
345 * w32term.c (x_draw_composite_glyph_string_foreground):
346 * term.c (encode_terminal_code):
347 * composite.c (composition_update_it, get_composition_id):
348 * xdisp.c (get_next_display_element)
349 (fill_composite_glyph_string): Add comments about special meaning
350 of TAB characters in a composition.
351
a02719a3
PE
3522011-09-15 Paul Eggert <eggert@cs.ucla.edu>
353
354 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
355 This occurs when processing a multibyte format.
356 Problem reported by Wolfgang Jenker.
a02719a3 357
72589a3c
JB
3582011-09-15 Johan Bockgård <bojohan@gnu.org>
359
360 * xdisp.c (try_cursor_movement): Only check for exact match if
361 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
362
1c14176c
PE
3632011-09-14 Paul Eggert <eggert@cs.ucla.edu>
364
365 Remove unused external symbols.
366 * dispextern.h (calc_pixel_width_or_height): Remove decl.
367 * xdisp.c (calc_pixel_width_or_height): Now static.
368 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
369 * indent.c (check_display_width):
370 * w32term.c: Fix comment to match code.
371 * xterm.c, xterm.h (x_catching_errors): Remove.
372
d2eea5b5
PE
3732011-09-14 Paul Eggert <eggert@cs.ucla.edu>
374
375 * xselect.c: Use signed conversions more consistently (Bug#9498).
376 (selection_data_to_lisp_data): Assume incoming selection data are
377 signed integers, not unsigned. This is to be consistent with
378 outgoing selection data, which was modified to use signed integers
379 in as part of the fix to Bug#9196 in response to Jan D.'s comment
380 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
381 expects long, not unsigned long.
382
46888499
EZ
3832011-09-14 Eli Zaretskii <eliz@gnu.org>
384
385 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
386 computation of loop end. Reported by Johan Bockgård
387 <bojohan@gnu.org>.
388
ef8ef9fb
CY
3892011-09-13 Chong Yidong <cyd@stupidchicken.com>
390
391 * frame.c (Fother_visible_frames_p): Function deleted.
392
fa819fed
EZ
3932011-09-12 Eli Zaretskii <eliz@gnu.org>
394
395 * indent.c (compute_motion): Process display vector front to back
396 rather than the other way around. (Bug#2496)
397
2ba8e008
SM
3982011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
399
400 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
401
20f53c69
CY
4022011-09-11 Chong Yidong <cyd@stupidchicken.com>
403
404 * minibuf.c (Fread_from_minibuffer): Doc fix.
405
d562d7a4
EZ
4062011-09-11 Eli Zaretskii <eliz@gnu.org>
407
408 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
409 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
410
1c4d7f3d
LMI
4112011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
412
413 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
414 value for non-existent files.
415
b885bf36
EZ
4162011-09-11 Eli Zaretskii <eliz@gnu.org>
417
418 * fileio.c (Finsert_file_contents): If the file cannot be opened,
419 set its "size" to -1. This will set the modtime_size field of
420 the corresponding buffer to -1, which is what
421 verify-visited-file-modtime expects for files that do not exist.
422 (Bug#9139)
423
6612f0bf
PE
4242011-09-11 Paul Eggert <eggert@cs.ucla.edu>
425
426 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
427 here ...
428 * lisp.h: ... from here. push_key_description is no longer
429 defined in keyboard.c, so its declaration should not be in
430 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
431 logically belongs with push_key_description.
432
dfb3f755
PE
4332011-09-10 Paul Eggert <eggert@cs.ucla.edu>
434
435 * buffer.h: Include <sys/types.h> instead of <time.h>.
436 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
437 Problem reported by Herbert J. Skuhra.
438
3134906c
LMI
4392011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
440
441 * xml.c (parse_region): Make the parsing work for
442 non-comment-starting XML files again (bug#9144).
443
8d903f4e
AS
4442011-09-10 Andreas Schwab <schwab@linux-m68k.org>
445
446 * image.c (gif_load): Fix calculation of bottom and right corner.
447 (Bug#9468)
448
80ad64f4
EZ
4492011-09-10 Eli Zaretskii <eliz@gnu.org>
450
451 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
452 redisplay in small windows.
453
208a048d
EZ
4542011-09-09 Eli Zaretskii <eliz@gnu.org>
455
456 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
457
9b1c252e
MR
4582011-09-08 Martin Rudalics <rudalics@gmx.at>
459
460 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
461 Operate on live windows only.
462
2949f33b
JB
4632011-09-08 Juanma Barranquero <lekktu@gmail.com>
464
465 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
466
e08dcafd
EZ
4672011-09-07 Eli Zaretskii <eliz@gnu.org>
468
469 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
470 only under bidi iteration.
471
115b96bd
JD
4722011-09-07 Jan Djärv <jan.h.d@swipnet.se>
473
474 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
475
c8199d0f
PE
4762011-09-06 Paul Eggert <eggert@cs.ucla.edu>
477
478 isnan: Fix porting problem to Solaris 10 with bundled gcc.
479 Without this fix, the command to link temacs failed due to an
480 undefined symbol __builtin_isnan. This is because
481 /usr/include/iso/math_c99.h #defines isnan(x) to
482 __builtin_isnan(x), but the bundled gcc, which identifies itself
483 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
484 a __builtin_isnan.
485 * floatfns.c (isnan): #undef, and then #define to a clone of
486 what's in data.c.
487 (Fisnan): Always define, since it's always available now.
488 (syms_of_floatfns): Always define isnan at the Lisp level.
489
e39b275c 4902011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
491
492 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
493
b2db44d9 4942011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 495
f4af5137 496 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
497 The previous code assumed that file offsets (off_t values) fit in
498 EMACS_INT variables, which is not true on typical 32-bit hosts.
499 The code messed up by falsely reporting buffer overflow in cases
500 such as (insert-file-contents "big" nil 1 2) into an empty buffer
501 when "big" contains more than 2**29 bytes, even though this
502 inserts just one byte and does not overflow the buffer.
503 (Finsert_file_contents): Store file offsets as off_t
504 values, not as EMACS_INT values. Check for overflow when
505 converting between EMACS_INT and off_t. When checking for
506 buffer overflow or for overlap, take the offsets into account.
507 Don't use EMACS_INT for small values where int suffices.
508 When checking for overlap, fix a typo: ZV was used where
509 ZV_BYTE was intended.
510 (Fwrite_region): Don't assume off_t fits into 'long'.
511 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
512
ecfc0a49
MA
5132011-09-05 Michael Albinus <michael.albinus@gmx.de>
514
515 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
516
6511acf2 5172011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 518
0999621a 519 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
520
521 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 522 (esprintf, exprintf, evxprintf): New functions.
62f19c19
PE
523 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
524 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
525 (modify_event_symbol): Do not assume that the length of
526 name_alist_or_stem is safe to alloca and fits in int.
527 (Fexecute_extended_command): Likewise for function name and binding.
528 (Frecursion_depth): Wrap around reliably on integer overflow.
529 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
530 since some callers pass EMACS_INT values.
531 (Fsingle_key_description): Don't crash if symbol name contains more
532 than MAX_ALLOCA bytes.
533 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
534 (get_minibuffer): Arg is now EMACS_INT, not int.
535 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 536 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
537 * window.h (command_loop_level, minibuf_level): Reflect API changes.
538
2be7d702
PE
539 * dbusbind.c (signature_cat): New function.
540 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
541 Do not overrun buffer; instead, report string overflow.
542
9d1df220
PE
543 * dispnew.c (add_window_display_history): Don't overrun buffer.
544 Truncate instead; this is OK since it's just a log.
545
33ef5c64
PE
546 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
547 even if the time zone offset is outlandishly large.
548 Don't mishandle offset == INT_MIN.
549
66c6fdd5
PE
550 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
551 when creating daemon; the previous buffer-overflow check was incorrect.
552
d749b01b
PE
553 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
554 which has the guts of the old verror function.
555
b5cd1905
PE
556 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
557 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
558
6e1a67fb
PE
559 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
560 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 561 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 562 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
563 length of string rather than counting it via multiple sprintfs;
564 that's simpler and more reliable.
c21721cc
PE
565 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
566 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
567 sprintf, in case result does not fit in int.
568
c57b67fc
PE
569 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
570 (fontset_from_font): Print it.
571
8a401434
PE
572 * frame.c (tty_frame_count): Now printmax_t, not int.
573 (make_terminal_frame, set_term_frame_name): Print it.
574 (x_report_frame_params): In X, window IDs are unsigned long,
575 not signed long, so print them as unsigned.
576 (validate_x_resource_name): Check for implausibly long names,
577 and don't assume name length fits in 'int'.
578 (x_get_resource_string): Don't blindly alloca invocation name;
579 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
580 not fit in int.
581
6e1a67fb
PE
582 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
583 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
584 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
585
0df02bf3
PE
586 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
587 Use esprintf, not sprintf, in case result does not fit in int.
588
48e30793
PE
589 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
590 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
591 it as a large positive number.
592 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
593 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
594
a66ff6d8
PE
595 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
596 in case result does not fit in int.
597
aca216ff
PE
598 * print.c (float_to_string): Detect width overflow more reliably.
599 (print_object): Make sprintf buffer a bit bigger, to avoid potential
600 buffer overrun. Don't assume list length fits in 'int'. Treat
601 print length of 0 as 0, not as infinity; to be consistent with other
602 uses of print length in this function. Don't overflow print length
603 index. Don't assume hash table size fits in 'long', or that
604 vectorlike size fits in 'unsigned long'.
605
31c286f7
PE
606 * process.c (make_process): Use printmax_t, not int, to format
607 process-name gensyms.
608
55e5faa1
PE
609 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
610
80f2e268
PE
611 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
612 to avoid potential buffer overrun.
613
670741ab
PE
614 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
615 if X resource line is longer than 512 bytes.
616
b7163a50
PE
617 * xfns.c (x_window): Make sprintf buffer a bit bigger
618 to avoid potential buffer overrun.
619
ae58ff1f
PE
620 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
621
c43c8a6a
PE
622 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
623
3f8236f4
PE
6242011-09-04 Paul Eggert <eggert@cs.ucla.edu>
625
53e9fe90 626 Integer overflow fixes for scrolling, etc.
6511acf2
PE
627 Without these, Emacs silently mishandles large integers sometimes.
628 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
629 it were "C-u 1 M-x recenter" on a typical 64-bit host.
630
6511acf2
PE
631 * xdisp.c (try_window_id): Check Emacs fixnum range before
632 converting to 'int'.
806add1d 633
6511acf2 634 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
635 Check that an Emacs fixnum is in range before assigning it to 'int'.
636 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
637 values converted from Emacs fixnums.
638 (Frecenter): Don't wrap around a line count if it is out of 'int'
639 range; instead, treat it as an extreme value.
640 (Fset_window_configuration, compare_window_configurations):
641 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
642
6511acf2
PE
643 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
644 that can exceed INT_MAX. Check that EMACS_INT value is in range
645 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
646 (match_limit): Don't assume that a fixnum can fit in 'int'.
647
6511acf2 648 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
649 exceed INT_MAX.
650
6511acf2 651 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
652 (Fvertical_motion): Don't wrap around LINES values that don't fit
653 in 'int'. Instead, treat them as extreme values. This is good
654 enough for windows, which can't have more than INT_MAX lines anyway.
655
fcb901a7
LMI
6562011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
657
0f2f6b6d
LMI
658 * Require libxml/parser.h to avoid compilation warning.
659
fcb901a7
LMI
660 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
661
662 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
663 since this reportedly can destroy thread storage.
664
6e20a0d4
CY
6652011-08-30 Chong Yidong <cyd@stupidchicken.com>
666
667 * syntax.c (find_defun_start): Update all cache variables if
668 exiting early (Bug#9401).
669
148ae00e
EZ
6702011-08-30 Eli Zaretskii <eliz@gnu.org>
671
f6cfbd8f
EZ
672 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
673
148ae00e
EZ
674 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
675 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
676 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
677
678 * term.c (tty_append_glyph): New function.
679 (produce_stretch_glyph): Static function and its prototype deleted.
680
a66cfb1c
SM
681 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
682 Add prototypes.
148ae00e 683
c4a07a4c
PE
6842011-08-29 Paul Eggert <eggert@cs.ucla.edu>
685
686 * image.c (parse_image_spec): Check for nonnegative, not for positive,
687 when checking :margin (Bug#9390).
688 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 689 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
690 so that the name doesn't mislead. All uses changed.
691
6bc8cd65
JB
6922011-08-28 Johan Bockgård <bojohan@gnu.org>
693
694 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
695 set_tty_hooks.
696
dca4927e
EZ
6972011-08-27 Eli Zaretskii <eliz@gnu.org>
698
699 * xdisp.c (move_it_to): Don't bail out early when reaching
700 position beyond to_charpos, if we are scanning backwards.
701 (move_it_vertically_backward): When DY == 0, make sure we get to
702 the first character in the line after the newline.
703
f2cad773
PE
7042011-08-27 Paul Eggert <eggert@cs.ucla.edu>
705
706 * ccl.c: Improve and simplify overflow checking (Bug#9196).
707 (ccl_driver): Do not generate an out-of-range pointer.
708 (Fccl_execute_on_string): Remove unnecessary check for
709 integer overflow, noted by Stefan Monnier in
710 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
711 Remove a FIXME that didn't need fixing.
712 Simplify the newly-introduced buffer reallocation code.
713
0cae2cdb
JB
7142011-08-27 Juanma Barranquero <lekktu@gmail.com>
715
716 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
717
5fc295a4 7182011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 719
70c60eb2 720 Integer and memory overflow issues (Bug#9196).
726e0ab1 721
d31850da
PE
722 * doc.c (get_doc_string): Rework so that
723 get_doc_string_buffer_size is the actual buffer size, rather than
724 being 1 less than the actual buffer size; this makes xpalloc more
725 convenient.
726
a69fbedb
PE
727 * image.c (x_allocate_bitmap_record, cache_image):
728 * xselect.c (Fx_register_dnd_atom):
729 Simplify previous changes by using xpalloc.
730
fe5c5d37
PE
731 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
732 since either will do and ptrdiff_t is convenient with xpalloc.
733
0065d054
PE
734 * charset.c (charset_table_size)
735 (struct charset_sort_data.priority): Now ptrdiff_t.
736 (charset_compare): Don't overflow if priorities differ greatly.
737 (Fsort_charsets): Don't assume list length fits in int.
738 Check for size-calculation overflow when allocating sort data.
739 (syms_of_charset): Allocate an initial charset table that is
740 just under 64 KiB, to avoid problems with glibc malloc and mmap.
741
742 * cmds.c (internal_self_insert): Check for size-calculation overflow.
743
744 * composite.h (struct composition.glyph_len): Now int, not unsigned.
745 The actual value is always <= INT_MAX, and leaving it unsigned made
746 overflow checking harder.
747
748 * dispextern.h (struct glyph_matrix.rows_allocated)
749 (struct face_cache.size): Now ptrdiff_t, for convenience in use
750 with xpalloc. The values are still always <= INT_MAX.
751
752 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
753
754 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
755 (SAFE_NALLOCA): New macro.
756
757 * region-cache.c (struct boundary.pos, find_cache_boundary)
758 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
759 (set_cache_region, invalidate_region_cache)
760 (revalidate_region_cache, know_region_cache, region_cache_forward)
761 (region_cache_backward, pp_cache):
762 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
763 so that ptrdiff_t * can be passed to xpalloc.
764 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
765 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
766 (pp_cache): Don't assume cache_len fits in int.
767 * region-cache.h: Adjust extern decls to match.
768
769 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
770 EMACS_INT, since either will do, for xpalloc.
771
772 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
773 (xnmalloc, xnrealloc, xpalloc): New functions.
774
726e0ab1
PE
775 * bidi.c (bidi_shelve_header_size): New constant.
776 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
777 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
778
51f30bc5 779 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
780 * buffer.c (overlays_at, overlays_in, record_overlay_string)
781 (overlay_strings):
782 Don't update size of array until after memory allocation succeeds,
783 because xmalloc/xrealloc may not return.
0065d054
PE
784 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
785 now that we have proper integer overflow checking.
786 (record_overlay_string, overlay_strings): Catch overflows when
787 calculating size of overlay_str_buf.
726e0ab1 788
0065d054
PE
789 * callproc.c (Fcall_process): Check for size overflow when
790 calculating size of args2.
791 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
792 Normally we prefer signed values, but sticking with ptrdiff_t would
793 require adding more-complicated checks.
726e0ab1
PE
794
795 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
796 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
797 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 798 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
799
800 * character.c (Fstring): Check for size-calculation overflow.
801
802 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
803 unnecessary integer overflow. Check for size overflow.
804 (encode_coding_object): Don't update size until xmalloc succeeds.
805
806 * composite.c (get_composition_id): Check for overflow in glyph
807 length calculations.
808
809 Integer and memory overflow fixes for display code.
810 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
811 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
812 (scrolling_window): Check for overflow in size calculations.
813 (line_draw_cost, realloc_glyph_pool, add_row_entry):
814 Don't assume glyph table len fits in int.
815 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
816 (row_table_size): Now ptrdiff_t, not int.
817 (scrolling_window): Avoid overflow in size calculations.
818 Don't update size until allocation succeeds.
819 * fns.c (concat): Check for overflow in size calculations.
820 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
821 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
822 (NEXT_ALMOST_PRIME_LIMIT): New constant.
823
824 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
825 (get_doc_string): Check for size calculation overflow.
826 Don't update size until allocation succeeds.
827 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
828 EMACS_INT, where ptrdiff_t will do.
829 (Fsubstitute_command_keys): Check for string overflow.
830
831 * editfns.c (set_time_zone_rule): Don't assume environment length
832 fits in int.
833 (message_length): Now ptrdiff_t, not int.
834 (Fmessage_box): Don't update size until allocation succeeds.
835 Don't assume message length fits in int.
836 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
837
0065d054
PE
838 * emacs.c (main): Do not reallocate argv, since there is a null at
839 the end that can be overwritten, and this way there's no need to
840 worry about size-calculation overflow.
841 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
842
843 * eval.c (init_eval_once, grow_specpdl): Don't update size until
844 alloc succeeds.
845 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
846
847 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
848 (x_set_scroll_bar_width, x_figure_window_size):
849 Check for integer overflow.
850 (x_set_alpha): Do not assume XINT fits in int.
851
852 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
853 This is for the members text_lines, text_cols, total_lines, total_cols,
854 where the system imposes an 'int' limit.
855
856 * fringe.c (Fdefine_fringe_bitmap):
857 Don't update size until alloc works.
858
859 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
860 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
861
862 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
863 Check for size-calculation overflow.
864 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
865 do, as we prefer signed integers.
866 (id_to_widget.max_size, id_to_widget.used)
867 (xg_store_widget_in_map, xg_remove_widget_from_map)
868 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
869 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
870 Use and return ptrdiff_t, not int.
871 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
872 * gtkutil.h: Change prototypes to match the above.
873
874 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
875 are duplicate now that they've been promoted to lisp.h.
876 (x_allocate_bitmap_record, x_alloc_image_color)
877 (make_image_cache, cache_image, xpm_load):
878 Don't update size until alloc is done.
879 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
880 (x_detect_edges):
3256efce 881 Check for size calculation overflow.
726e0ab1
PE
882 (ct_colors_allocated_max): New constant.
883 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
884 overflow.
3256efce 885
726e0ab1
PE
886 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
887 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
888 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
889 Use ptrdiff_t, not int, to count maps.
890 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
891 calculations. Don't update size until allocation succeeds.
892 Redo calculations to avoid overflow.
726e0ab1
PE
893 * keyboard.h: Change prototypes to match the above.
894
895 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
896 to count maps.
897 (current_minor_maps): Check for size calculation overflow.
898 * keymap.h: Change prototypes to match the above.
899
900 * lread.c (read1, init_obarray): Don't update size until alloc done.
901
902 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
903 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
904
726e0ab1
PE
905 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
906 Now ptrdiff_t, not int.
907 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
908 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
909
910 * process.c (Fnetwork_interface_list): Check for overflow
911 in size calculation.
912
913 * region-cache.c (move_cache_gap): Check for size calculation overflow.
914
915 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
916 overflow. Don't bother calling xmalloc when xrealloc will do.
917
918 * search.c (Freplace_match): Check for size calculation overflow.
919 (Fset_match_data): Don't assume list lengths fit in 'int'.
920
921 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
922 for command line length. Do not attempt to address one before the
923 beginning of an array, as that's not portable.
924
925 * term.c (max_frame_lines): Remove; unused.
926 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
927 not int.
928 (encode_terminal_code, calculate_costs): Check for size
929 calculation overflow.
930 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
931 table lengths and related sizes. Don't update size until alloc
932 done. Redo calculations to avoid overflow.
933 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
934
935 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
936 subtracting pointers.
937 (gobble_line): Check for overflow more carefully. Don't update size
938 until alloc done.
939
940 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
941 Don't update size until alloc done.
942 Redo size calculations to avoid overflow.
943 Check for size calculation overflow.
0065d054 944 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
945
946 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
947 Use ptrdiff_t, not int, for sizes.
948 (store_mode_line_noprop_char): Don't update size until alloc done.
949
0065d054
PE
950 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
951 Use ptrdiff_t, not int, for sizes.
952 (Finternal_make_lisp_face, cache_face):
953 Check for size calculation overflow.
954 (cache_face): Treat size calculation overflows as if they were
955 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
956
957 * xfns.c (x_encode_text, x_set_name_internal)
958 (Fx_change_window_property): Use ptrdiff_t, not int, to count
959 sizes, since they can exceed INT_MAX in size. Check for size
960 calculation overflow.
961
0065d054
PE
962 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
963 (xg_select): Check for size calculation overflow.
726e0ab1
PE
964 Don't update size until alloc done.
965
0065d054 966 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 967 as sprintf is limited to int lengths.
1d526e2f 968
252c5ee1
PE
969 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
970 (X_LONG_MIN): New macros.
864d7ce7
PE
971 Use them to make the following changes clearer.
972 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
973 This change doesn't affect the value now, but it may help remind
974 future maintainers not to raise the value too much later.
975 (SELECTION_QUANTUM): Remove, replacing with ...
976 (selection_quantum): ... new function, which avoids overflow.
977 All uses changed.
978 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
979 assumption that selection length fits in 'int'.
980 (x_reply_selection_request, x_handle_selection_request)
981 (x_get_window_property, receive_incremental_selection)
982 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
983 (lisp_data_to_selection_data, clean_local_selection_data):
984 Use ptrdiff_t, not int, to record length of selection.
985 (x_reply_selection_request, x_get_window_property)
986 (receive_incremental_selection, x_property_data_to_lisp):
987 Redo calculations to avoid overflow.
988 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 989 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
990 something.
991 (x_get_window_property, receive_incremental_selection)
992 (lisp_data_to_selection_data, x_property_data_to_lisp):
993 Check for size-calculation overflow.
994 (x_get_window_property, receive_incremental_selection)
995 (lisp_data_to_selection_data, Fx_register_dnd_atom):
996 Don't store size until memory allocation succeeds.
997 (x_get_window_property): Plug memory leak on memory exhaustion.
998 Don't double-block input; malloc is safe here. Don't assume 2**34
999 - 4 fits in unsigned long. Add an xassert to check
1000 XGetWindowProperty overflow. Be more careful about overflow
1001 calculations, and distinguish size from memory overflow better.
1002 (receive_incremental_selection): When tracing, don't assume
1003 unsigned int is less than INT_MAX.
1004 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1005 harmful) conversions of unsigned short to int.
1006 (lisp_data_to_selection_data): Don't assume that integers
1007 in the range -65535 through -1 fit in an X unsigned short.
1008 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1009 result parameters unless successful. Rely on cons_to_unsigned
1010 to report problems with elements; the old code wasn't right anyway.
1011 (x_check_property_data): Check for int overflow; we cannot use
1012 a wider type due to X limits.
1013 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1014
726e0ab1 1015 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 1016
0065d054
PE
1017 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1018 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
1019 (x_color_cells): Don't store size until memory allocation succeeds.
1020 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 1021 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
1022 (x_term_init): Don't assume length fits in int (sprintf is limited
1023 to int size).
bc18e09d 1024
ebfa62c0
PE
1025 Use ptrdiff_t for composition IDs.
1026 * character.c (lisp_string_width):
1027 * composite.c (composition_table_size, n_compositions)
1028 (get_composition_id, composition_gstring_from_id):
1029 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1030 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1031 * window.c (Frecenter):
1032 Use ptrdiff_t, not int, for composition IDs.
1033 * composite.c (get_composition_id): Check for integer overflow.
1034 * composite.h: Adjust prototypes to match the above changes.
1035
d3411f89
PE
1036 Use ptrdiff_t for hash table indexes.
1037 * category.c (hash_get_category_set):
1038 * ccl.c (ccl_driver):
1039 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1040 * coding.c (coding_system_charset_list, detect_coding_system):
1041 * coding.h (struct coding_system.id):
1042 * composite.c (get_composition_id, gstring_lookup_cache):
1043 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1044 * image.c (xpm_get_color_table_h):
1045 * lisp.h (hash_lookup, hash_put):
1046 * minibuf.c (Ftest_completion):
1047 Use ptrdiff_t for hash table indexes, not int (which is too
1048 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1049 32-bit --with-wide-int hosts).
1050
e097a6fa
PE
1051 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1052 Add a FIXME comment about memory leaks.
1053 (syms_of_charset): Don't assume xmalloc returns.
1054
5637687f
PE
1055 Don't assume that stated character widths fit in int.
1056 * character.c (Fchar_width, c_string_width, lisp_string_width):
1057 * character.h (CHAR_WIDTH):
1058 * indent.c (MULTIBYTE_BYTES_WIDTH):
1059 Use sanitize_char_width to avoid undefined and/or bad behavior
1060 with outlandish widths.
a66cfb1c 1061 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
1062 now that we have two such functions. All uses changed.
1063 (sanitize_char_width): New inline function.
1064
a2271ba2
PE
1065 Don't assume that tab-width fits in int.
1066 * character.h (sanitize_width): New inline function.
1067 (SANE_TAB_WIDTH): New macro.
1068 (ASCII_CHAR_WIDTH): Use it.
1069 * indent.c (sane_tab_width): Remove. All uses replaced by
1070 SANE_TAB_WIDTH (current_buffer).
1071 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1072
18c52557
PE
1073 * fileio.c: Integer overflow issues with file modes.
1074 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1075
caeeedc1
PE
1076 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1077 Remove unreachable code.
1078 (read_hex, load_charset_map_from_file): Check for integer overflow.
1079
50849c52
PE
1080 * xterm.c: don't go over XClientMessageEvent limit
1081 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1082 (x_send_scroll_bar_event): Likewise. Check that the size does not
1083 exceed limits imposed by XClientMessageEvent, as well as the usual
1084 ptrdiff_t and size_t limits.
1085
b13995db
PE
1086 * keyboard.c: Overflow, signedness and related fixes.
1087 (make_lispy_movement): Use same integer type in forward decl
1088 that is used in the definition.
1089 (read_key_sequence, keyremap_step):
1090 Change bufsize argument back to int, undoing my 2011-03-30 change.
1091 We prefer signed types, and int is wide enough here.
1092 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1093 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1094 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1095 length, not size_t. Use ptrdiff_t for index, not int.
1096 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1097 possibility of integer overflow.
1098
13464394
PE
1099 Overflow, signedness and related fixes for images.
1100
1101 * dispextern.h (struct it.stack[0].u.image.image_id)
1102 (struct_it.image_id, struct image.id, struct image_cache.size)
1103 (struct image_cache.used, struct image_cache.ref_count):
1104 * gtkutil.c (update_frame_tool_bar):
1105 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1106 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1107 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1108 * nsmenu.m (update_frame_tool_bar):
1109 * xdisp.c (calc_pixel_width_or_height):
1110 * xfns.c (image_cache_refcount):
1111 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1112 on typical 64-bit hosts.
1113
1114 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1115 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1116 Omit unnecessary casts to int.
1117 (parse_image_spec): Check that integers fall into 'int' range
1118 when the callers expect that.
1119 (image_ascent): Redo ascent calculation to avoid int overflow.
1120 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1121 (lookup_image): Remove unnecessary tests.
1122 (xbm_image_p): Locals are now of int, not EMACS_INT,
1123 since parse_image_check makes sure they fit into int.
1124 (png_load, gif_load, svg_load_image):
1125 Prefer int to unsigned where either will do.
1126 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
1127 old tiff_error_handler and tiff_warning_handler.
1128 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
1129 stack buffer overflows. It uses only the features of vsnprintf
1130 that are common to both POSIX and native Microsoft.
1131 (tiff_error_handler, tiff_warning_handler): Use it.
1132 (tiff_load, gif_load, imagemagick_load_image):
1133 Don't assume :index value fits in 'int'.
1134 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1135 (imagemagick_load_image): Check that crop parameters fit into
1136 the integer types that MagickCropImage accepts. Don't assume
1137 Vimagemagick_render_type has a nonnegative value. Don't assume
1138 size_t fits in 'long'.
1139 (gs_load): Use printmax_t to print the widest integers possible.
1140 Check for integer overflow when computing image height and width.
1141
c11821d4
EZ
11422011-08-26 Eli Zaretskii <eliz@gnu.org>
1143
1144 * xdisp.c (redisplay_window): Don't force window start if point
1145 will be invisible in the resulting window. (Bug#9324)
1146
0c95fcf7
EZ
11472011-08-25 Eli Zaretskii <eliz@gnu.org>
1148
1149 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1150 the display spec is of the form `(space ...)'.
1151 (handle_display_spec): Return the value returned by
1152 handle_single_display_spec, not just 1 or zero.
1153 (handle_single_display_spec): If the display spec is of the form
1154 `(space ...)', and specifies display in the text area, return 2
1155 rather than 1.
fee65a97 1156 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
1157 accurately, and prefer exact match for point under bidi.
1158 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
1159
1160 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1161 into disp_prop; all users changed.
1162
1163 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1164 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1165 for the text covered by the display property.
1166
e4ed06f1
CY
11672011-08-25 Chong Yidong <cyd@stupidchicken.com>
1168
1169 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1170 Change return value to nil.
1171 (Frecord_buffer): Delete unused function.
1172
f67cdd7f
EZ
11732011-08-24 Eli Zaretskii <eliz@gnu.org>
1174
5980d4c6
EZ
1175 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1176 buffers, return left-to-right.
8610fe8b
EZ
1177 (set_cursor_from_row): Consider candidate row a win if its glyph
1178 represents a newline and point is on that newline. Fixes cursor
1179 positioning on the newline at EOL of R2L text within L2R
1180 paragraph, and vice versa.
1181 (try_cursor_movement): Check continued rows, in addition to
1182 continuation rows. Fixes unwarranted scroll when point enters a
1183 continued line of R2L text within an L2R paragraph, or vice versa.
1184 (cursor_row_p): Consider the case of point being equal to
1185 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1186 from the end of a short line to the beginning of a continued line
1187 of R2L text within L2R paragraph.
1188 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1189 composed characters.
5980d4c6 1190
f67cdd7f
EZ
1191 * bidi.c (bidi_check_type): Use xassert.
1192 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1193 members.
1194
bca633fb
EZ
11952011-08-23 Eli Zaretskii <eliz@gnu.org>
1196
1197 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1198 a character.
1199
4a5885a7
CY
12002011-08-23 Chong Yidong <cyd@stupidchicken.com>
1201
1202 * nsfont.m (ns_otf_to_script): Fix typo.
1203
0902a04e
KH
12042011-08-22 Kenichi Handa <handa@m17n.org>
1205
1206 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1207 extra slot even if the purpose is char-code-property-table.
1208
1a2e6670
EZ
12092011-08-23 Eli Zaretskii <eliz@gnu.org>
1210
8ddde651
EZ
1211 * xdisp.c (redisplay_window): When computing centering_position,
1212 account for the height of the header line. (Bug#8874)
1213
425cc014
EZ
1214 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1215 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1216 candidate is selected by the mouse, and that candidate has a
1217 composed character under the mouse.
1218
1a2e6670
EZ
1219 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1220 coordinates reported by pos-visible-in-window-p for a composed
1221 character in column zero.
1222
8b76d6f8
SM
12232011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1224
1225 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1226
dac347dd
EZ
12272011-08-22 Eli Zaretskii <eliz@gnu.org>
1228
1229 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1230 consider it a hit if to_charpos is anywhere in the range of the
1231 composed buffer positions.
1232
e013fb34
CY
12332011-08-22 Chong Yidong <cyd@stupidchicken.com>
1234
1235 * image.c (gif_load): Don't assume that each subimage has the same
1236 dimensions as the base image. Handle disposal method that is
1237 "undefined" by the gif spec (Bug#9335).
1238
bd1ba3e8
CY
12392011-08-20 Chong Yidong <cyd@stupidchicken.com>
1240
1241 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 1242 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 1243
54a1215b
EZ
12442011-08-19 Eli Zaretskii <eliz@gnu.org>
1245
823564e5
EZ
1246 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1247 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1248 from an Org mode buffer to a Speedbar frame.
1249
54a1215b
EZ
1250 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1251 a composition, take its buffer position from IT->cmp_it.charpos.
1252 Fixes cursor positioning at the beginning of a line that begins
1253 with a composed character.
1254
9778ebcc
EZ
12552011-08-18 Eli Zaretskii <eliz@gnu.org>
1256
0be6ee06
EZ
1257 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1258 character bidirectional type, use STRONG_L instead. Fixes crashes
1259 in a buffer produced by `describe-categories'.
1260
9778ebcc
EZ
1261 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1262 members before the level stack, so they would be saved and
1263 restored when copying iterator state. Fixes incorrect reordering
1264 around TABs covered by display properties.
1265
156bffbe
AS
12662011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1267
1268 * process.c (Fnetwork_interface_list): Correctly determine buffer
1269 size.
1270
72ad093b
CY
12712011-08-17 Chong Yidong <cyd@stupidchicken.com>
1272
1273 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
1274 (internal_condition_case_2, internal_condition_case_n):
1275 Remove unnecessary aborts (Bug#9081).
72ad093b 1276
35774242
EZ
12772011-08-17 Eli Zaretskii <eliz@gnu.org>
1278
1279 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1280 has no `load' handler, try opening the file locally. (Bug#9311)
1281
db76dd85
KB
12822011-08-16 Ken Brown <kbrown@cornell.edu>
1283
1284 * gmalloc.c: Expand comment.
1285
b215eee5
EZ
12862011-08-16 Eli Zaretskii <eliz@gnu.org>
1287
1288 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1289 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1290
a4579d33
KB
12912011-08-16 Ken Brown <kbrown@cornell.edu>
1292
1293 Fix memory allocation problems in Cygwin build (Bug#9273).
1294
1295 * unexcw.c ( __malloc_initialized): Declare external variable.
1296 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1297
8b76d6f8
SM
1298 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1299 New variables.
a4579d33
KB
1300 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1301 dumped emacs.
1302 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1303 in the static heap.
1304 [CYGWIN] (special_realloc): New function.
1305 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1306 requests to realloc storage in the static heap.
1307
3ebec551
PE
13082011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1309
1310 * bidi.c (bidi_initialize): Remove unused local.
1311
9fd8be00
EZ
13122011-08-15 Eli Zaretskii <eliz@gnu.org>
1313
474a8465
EZ
1314 * biditype.h: File removed.
1315
1316 * bidimirror.h: File removed.
1317
1318 * deps.mk (bidi.o): Remove biditype.h and
1319 bidimirror.h.
1320
1321 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
1322 bidimirror.h.
1323
1324 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1325
1326 * chartab.c: Improve commentary for the uniprop_table API.
1327
32413314
EZ
1328 * bidi.c (bidi_paragraph_init): Support zero value of
1329 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
1330 (bidi_initialize): Use uniprop_table instead of including
1331 biditype.h and bidimirror.h.
32413314 1332
9fd8be00
EZ
1333 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1334 coordinates of the iterator when restoring from ppos_it.
1335 (Bug#9296)
1336
5cf2b69b
KH
13372011-08-14 Kenichi Handa <handa@m17n.org>
1338
1339 * process.c (create_process): Call setup_process_coding_systems
72ad093b 1340 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 1341
daf17d00
EZ
13422011-08-14 Eli Zaretskii <eliz@gnu.org>
1343
1344 * xdisp.c (move_it_in_display_line_to): Don't invoke
1345 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1346 ppos_it. Fixes vertical cursor motion when line beginning is
1347 covered by an image. (Bug#9296)
1348
08e3161a
JD
13492011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1350
1351 * nsterm.h (ns_run_ascript): Declare.
1352 (NSAPP_DATA2_RUNASSCRIPT): Define.
1353
1354 * nsfns.m (as_script, as_result, as_status): New static variables.
1355 (ns_run_ascript): New function.
5e617bc2 1356 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
1357 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1358 the event loop. Get status from as_status (Bug#7276).
1359
1360 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1361 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1362 the event loop (Bug#7276).
1363
a3720aa2
AS
13642011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1365
1366 * gnutls.c (QCgnutls_bootprop_priority)
1367 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1368 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1369 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1370 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1371 (QCgnutls_bootprop_verify_hostname_error)
1372 (QCgnutls_bootprop_callbacks_verify): Rename from
1373 Qgnutls_bootprop_..., all uses changed.
1374
1375 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1376 uses changed.
1377
0a0d27fb
PE
13782011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1379
19d5c50c
PE
1380 * xfaces.c (Qframe_set_background_mode): Now static.
1381 * dispextern.h (Qframe_set_background_mode): Remove decl.
1382
0a0d27fb
PE
1383 * process.c (Fnetwork_interface_info): Declare local only if needed.
1384
377538cb
JD
13852011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1386
1387 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1388 (Fnetwork_interface_list): Allocate in increments of bytes instead
1389 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1390 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1391 sockaddr.
1392 (struct ifflag_def): notrailers is smart on OSX.
1393 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1394 Get hardware address with getifaddrs if available.
1395
08fff70c
EZ
13962011-08-12 Eli Zaretskii <eliz@gnu.org>
1397
1398 * xdisp.c (iterate_out_of_display_property): xassert that
1399 IT->position is set to within IT->object's boundaries. Break from
1400 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
1401 when IT->position is set up wrongly due to some bug.
1402 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
1403 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1404 entry. Force push_it to save on the stack the current
1405 buffer/string position, to be restored by pop_it. Fix flags in
1406 the iterator structure wrt the object coming from a display
1407 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1408 properties. (Bug#9284)
1409
7be1c708 14102011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 1411
7be1c708
CY
1412 * fontset.c (fontset_get_font_group): Add proper type checks.
1413 (Bug#9172)
aac0c6e3 1414
7be1c708 14152011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 1416
7be1c708
CY
1417 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1418 and LC_VERSION_MIN_MACOSX.
1419 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1420 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 1421
97bb72a6
EZ
14222011-08-08 Eli Zaretskii <eliz@gnu.org>
1423
1424 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
1425 no-display-properties-and-no-overlays under bidi display.
1426 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 1427 properties and overlays.
97bb72a6 1428
d5617611
CY
14292011-08-08 Chong Yidong <cyd@stupidchicken.com>
1430
37e11a63
CY
1431 * editfns.c (Fset_time_zone_rule): Document relationship with the
1432 setenv function.
1433
d5617611
CY
1434 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1435 the font entity extracted from the cache (Bug#8109).
1436
58872834
CY
14372011-08-07 Chong Yidong <cyd@stupidchicken.com>
1438
1439 * composite.c (autocmp_chars): Don't reset point. That is done by
1440 restore_point_unwind (Bug#5984).
1441
75bfc667
JL
14422011-08-07 Juri Linkov <juri@jurta.org>
1443
1444 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1445 to show the arg `TIME' instead of `TIMEVAL'.
1446
d1410150
EZ
14472011-08-06 Eli Zaretskii <eliz@gnu.org>
1448
1449 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1450 display property strides EOL and includes a newline, as in
1451 longlines-mode. (Bug#9254)
75b771e4
EZ
1452 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1453 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
1454
1455 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1456 is non-zero, even if the data buffer is NULL. Fixes a crash in
1457 vertical-motion with longlines-mode. (Bug#9254)
1458
35928349
EZ
14592011-08-05 Eli Zaretskii <eliz@gnu.org>
1460
ec7cc85b
EZ
1461 * bidi.c <bidi_cache_total_alloc>: Now static.
1462 (bidi_initialize): Initialize bidi_cache_total_alloc.
1463
8b76d6f8 1464 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
1465 cache. (Bug#9221)
1466
1467 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1468 amount allocated this far in `bidi_cache_total_alloc'.
1469 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1470 non-zero, only free the data buffer without restoring the cache
1471 contents. All callers changed.
1472
1473 * dispextern.h (bidi_unshelve_cache): Update prototype.
1474
1475 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1476 (move_it_in_display_line, move_it_to)
1477 (move_it_vertically_backward, move_it_by_lines): Replace the call
1478 to xfree to an equivalent call to bidi_unshelve_cache.
1479 (move_it_in_display_line_to): Fix logic of returning
412b6358 1480 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 1481
e2e2423b
EZ
14822011-08-05 Eli Zaretskii <eliz@gnu.org>
1483
1484 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1485 came from a string character with a `cursor' property. (Bug#9229)
1486
ae9e757a
JD
14872011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1488
1489 * Makefile.in (LIB_PTHREAD): New variable.
1490 (LIBES): Add LIB_PTHREAD (Bug#9216).
1491
1492 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1493 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1494
213bd7f2
AS
14952011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1496
1497 * regex.c (re_iswctype): Remove some redundant boolean
1498 conversions.
1499
99aaf75f
JD
15002011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1501
1502 * xterm.c (x_find_topmost_parent): New function.
1503 (x_set_frame_alpha): Find topmost parent window with
1504 x_find_topmost_parent and set the property there also (bug#9181).
1505 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1506
c74e9d86
PE
15072011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1508
1509 * callproc.c (Fcall_process): Avoid vfork clobbering
1510 the local vars buffer, coding_systems, current_dir.
1511
640c8776
SM
15122011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1513
1514 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1515
f26d0e4c
PE
15162011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1517
8a10d76c
PE
1518 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1519 so that it is not optimized away.
1520
f26d0e4c
PE
1521 * xdisp.c (compute_display_string_pos): Remove unused local.
1522
55439c61
EZ
15232011-08-02 Eli Zaretskii <eliz@gnu.org>
1524
1525 Fix slow cursor motion and scrolling in large buffers with
1526 selective display, like Org Mode buffers. (Bug#9218)
1527
1528 * dispextern.h (struct bidi_it): New member disp_prop_p.
1529
1530 * xdisp.c: Remove one-slot cache of display string positions.
1531 (compute_display_string_pos): Accept an additional argument
5e617bc2 1532 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
1533 for a display string or property. If found, set DISP_PROP_P
1534 non-zero.
1535
1536 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
1537 DISP_PROP_P, and pass it to compute_display_string_pos.
1538 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
1539 non-zero. All callers of bidi_fetch_char changed.
1540
fb33fa43
SM
15412011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1542
1543 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1544
b099e063
DM
15452010-12-03 Don March <don@ohspite.net>
1546
1547 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1548 last character M-[char] is translated to ESC [char] (bug#7541).
1549
5cc7f7af
KH
15502011-08-02 Kenichi Handa <handa@m17n.org>
1551
d0fffa3f 1552 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
1553
1554 * chartab.c (uniprop_table): Make it non-static.
1555
525d5e6e
EZ
15562011-08-01 Eli Zaretskii <eliz@gnu.org>
1557
1558 * xdisp.c (forward_to_next_line_start): Accept additional argument
1559 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1560 on the newline.
1561 (reseat_at_next_visible_line_start): Use the bidi iterator state
1562 returned by forward_to_next_line_start to restore the state of
1563 it->bidi_it after backing up to previous newline. (Bug#9212)
1564
31011111
AS
15652011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1566
1567 * regex.c (re_comp): Protoize.
1568 (re_exec): Fix return type.
1569 (regexec): Fix type of `ret'. (Bug#9203)
1570
476371c4
PE
15712011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1572
e5d76069
PE
1573 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1574 This is needed if max-image-size is a floating-point number.
1575
9a79b20c
AS
15762011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1577
1578 * print.c (print_object): Print empty symbol as ##.
1579
1580 * lread.c (read1): Read ## as empty symbol.
1581
d8c2fa78
AA
15822011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1583
1584 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1585 setting frame foreground color (Bug#9175).
1586 (x_set_background_color): Likewise.
1587
ffe57a7a
AA
1588 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1589 contents (Bug#9176).
1590 (EmacsTooltip -init): Remove bezels and add shadows to
1591 tooltip windows.
1592
bf3492a5
AA
1593 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1594 or scroll bar (Bug#8470).
1595
d55e9c53
AA
1596 * nsfont.m (nsfont_open): Remove assignment to voffset and
1597 unnecessary vars hshink, expand, hd, full_height, min_height.
1598 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1599
1600 * nsterm.h (nsfont_info): Remove voffset field.
1601
d8c2fa78 16022011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
1603
1604 Implement strike-through and overline on NextStep (Bug#8863).
1605
1606 * nsfont.m (nsfont_open): Use underline position provided by font,
1607 instead of hard-coded value of 2.
1608 (nsfont_draw): Call ns_draw_text_decoration instead.
1609
1610 * nsterm.h: Add declaration for ns_draw_text_decoration.
1611
1612 * nsterm.m (ns_draw_text_decoration): New function for drawing
1613 underline, overline, and strike-through.
1614 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1615 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 1616 accommodate underlining, etc.
4843aac3 1617
4cc60b9b
EZ
16182011-07-28 Eli Zaretskii <eliz@gnu.org>
1619
bc7ece87
EZ
1620 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1621 default.
4cc60b9b 1622
476371c4
PE
16232011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1624
66606eea
PE
1625 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1626 Without this fix, if a signal arrives just after memory fills up,
1627 'malloc' might be invoked reentrantly.
1628
476371c4
PE
1629 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1630 In other words, assume that every image size is allowed, on non-X
1631 hosts. This assumption is probably wrong, but it lets Emacs compile.
1632
f3fcc40d
AS
16332011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1634
1635 * regex.c (re_iswctype): Convert return values to boolean.
1636
350c992f
EZ
16372011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1638
1639 * xdisp.c (compute_display_string_pos): Don't use cached display
1640 string position if the buffer had its restriction changed.
1641 (Bug#9184)
1642
5266b4bb
PE
16432011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1644
1645 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1646
2573a837 16472011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 1648
41f55ccd 1649 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 1650
39e378da
PE
1651 * bidi.c: Integer size and overflow fixes.
1652 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1653 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1654 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1655 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1656 (bidi_find_other_level_edge):
1657 Use ptrdiff_t instead of EMACS_INT where either will do.
1658 This works better on 32-bit hosts configured --with-wide-int.
1659 (bidi_cache_ensure_space): Check for size-calculation overflow.
1660 Use % rather than repeated addition, for better worst-case speed.
1661 Don't set bidi_cache_size until after xrealloc returns, because it
1662 might not return.
1663 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
1664 (bidi_cache_ensure_space): Also check that the bidi cache size
1665 does not exceed that of the largest Lisp string or buffer. See Eli
1666 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 1667
5e927815
PE
1668 * alloc.c (__malloc_size_t): Remove.
1669 All uses replaced by size_t. See Andreas Schwab's note
1670 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1671
ca4aa935
PE
1672 * image.c: Improve checking for integer overflow.
1673 (check_image_size): Assume that f is nonnull, since
1674 it is always nonnull in practice. This is one less thing to
1675 worry about when checking for integer overflow later.
1676 (x_check_image_size): New function, which checks for integer
1677 overflow issues inside X.
1678 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1679 This removes the need for a memory_full check.
1680 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1681 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1682 (xbm_read_bitmap_data): Change locals back to 'int', since
1683 their values must fit in 'int'.
1684 (xpm_load_image, png_load, tiff_load):
1685 Invoke x_create_x_image_and_pixmap earlier,
1686 to avoid much needless work if the image is too large.
1687 (tiff_load): Treat overly large images as if
1688 x_create_x_image_and_pixmap failed, not as malloc failures.
1689 (gs_load): Use x_check_image_size.
1690
5f8f9cc2
PE
1691 * gtkutil.c: Omit integer casts.
1692 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1693 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1694
5adf60bc
PE
1695 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1696
c8907a93
PE
1697 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1698 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1699 would wrongly return t on a 64-bit host.
1700
e3c25c68
PE
1701 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1702 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1703 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1704 and therefore cause GCC to emit a bogus diagnostic in some cases.
1705
3f791afe
PE
1706 * image.c: Integer signedness and overflow and related fixes.
1707 This is not an exhaustive set of fixes, but it's time to
1708 record what I've got.
1709 (lookup_pixel_color, check_image_size): Remove redundant decls.
1710 (check_image_size): Don't assume that arbitrary EMACS_INT values
1711 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1712 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1713 (tiff_load, imagemagick_load_image):
1714 Check for overflow in size calculations.
1715 (x_create_x_image_and_pixmap): Remove unnecessary test for
1716 xmalloc returning NULL; that can't happen.
1717 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1718 (xpm_color_bucket): Use better integer hashing function.
1719 (xpm_cache_color): Don't possibly over-allocate memory.
1720 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1721 (gif_memory_source):
1722 Use ptrdiff_t, not int or size_t, to record sizes.
1723 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1724 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1725 either works, as we prefer signed integers.
1726 (tiff_read_from_memory, tiff_write_from_memory):
1727 Return tsize_t, not size_t, since that's what the TIFF API wants.
1728 (tiff_read_from_memory): Don't fail simply because the read would
1729 go past EOF; instead, return a short read.
1730 (tiff_load): Omit no-longer-needed casts.
1731 (Fimagemagick_types): Don't assume size fits into 'int'.
1732
3cc5a532
PE
1733 Improve hashing quality when configured --with-wide-int.
1734 * fns.c (hash_string): New function, taken from sxhash_string.
1735 Do not discard information about ASCII character case; this
1736 discarding is no longer needed.
1737 (sxhash-string): Use it. Change sig to match it. Caller changed.
1738 * lisp.h: Declare it.
1739 * lread.c (hash_string): Remove, since we now use fns.c's version.
1740 The fns.c version returns a wider integer if --with-wide-int is
1741 specified, so this should help the quality of the hashing a bit.
1742
b312a492
PE
1743 * emacs.c: Integer overflow minor fix.
1744 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1745 Define only if GNU_LINUX.
1746 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1747
dfd153ae
PE
1748 * dispnew.c: Integer signedness and overflow fixes.
1749 Remove unnecessary forward decls, that were a maintenance hassle.
1750 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1751 All uses changed.
1752 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1753 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1754 (prepare_desired_row, line_draw_cost):
1755 Use int, not unsigned, where either works.
1756 (save_current_matrix, restore_current_matrix):
1757 Use ptrdiff_t, not size_t, where either works.
1758 (init_display): Check for overflow more accurately, and without
1759 relying on undefined behavior.
1760
a81d11a3
PE
1761 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1762 Remove, replacing with the new symbols in lisp.h. All uses changed.
1763 * fileio.c (make_temp_name):
1764 * filelock.c (lock_file_1, lock_file):
1765 * xdisp.c (message_dolog):
1766 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1767 Use pMd etc. instead.
1768 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1769 replacing the pWIDE etc. symbols removed from editfns.c.
1770
3300e6fd
PE
1771 * keyboard.h (num_input_events): Now uintmax_t.
1772 This is (very slightly) less likely to mess up due to wraparound.
1773 All uses changed.
1774
fd05c7e9
PE
1775 * buffer.c: Integer signedness fixes.
1776 (alloc_buffer_text, enlarge_buffer_text):
1777 Use ptrdiff_t rather than size_t when either will do, as we prefer
1778 signed integers.
1779
903fe15d
PE
1780 * alloc.c: Integer signedness and overflow fixes.
1781 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1782 (__malloc_size_t): Default to size_t, not to int.
1783 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1784 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1785 Prefer ptrdiff_t to size_t when either would do, as we prefer
1786 signed integers.
1787 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1788 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1789 Now const. Initialize with values that are in range even if char
1790 is signed.
1791 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1792 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1793 These functions do the right thing with sizes > 2**32.
1794 (check_depth): Now ptrdiff_t, not int.
1795 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1796 Adjust to new way of storing sizes. Check for size overflow bugs
1797 in rest of code.
1798 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1799 slightly wrong anyway, as it missed one instance of
1800 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1801 (refill_memory_reserve): Omit needless cast to size_t.
1802 (mark_object_loop_halt): Mark as externally visible.
1803
ac82cc6a
PE
1804 * xselect.c: Integer signedness and overflow fixes.
1805 (Fx_register_dnd_atom, x_handle_dnd_message):
1806 Use ptrdiff_t, not size_t, since we prefer signed.
1807 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1808 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1809 x_dnd_atoms_size and x_dnd_atoms_length.
1810
c2d1e36d
PE
1811 * doprnt.c: Prefer signed to unsigned when either works.
1812 * eval.c (verror):
1813 * doprnt.c (doprnt):
1814 * lisp.h (doprnt):
1815 * xdisp.c (vmessage):
1816 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1817 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1818 prefer signed arithmetic to avoid comparison confusion.
1819 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1820 but is a bit tricky.
1821
0e926e56
PE
1822 Assume freestanding C89 headers, string.h, stdlib.h.
1823 * data.c, doprnt.c, floatfns.c, print.c:
1824 Include float.h unconditionally.
1825 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1826 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1827 * regex.c: Likewise for stddef.h, string.h.
1828 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1829 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1830 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1831 (STDC_HEADERS): Remove obsolete defines.
1832 * sysdep.c: Include limits.h unconditionally.
1833
9cfdb3ec
PE
1834 Assume support for memcmp, memcpy, memmove, memset.
1835 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1836 * regex.c (memcmp, memcpy):
1837 Remove; we assume C89 now.
1838
1839 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1840 (__malloc_safe_bcopy): Remove; no longer needed.
1841
cf950e6b 1842 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
1843 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1844 well either way, and we prefer signed to unsigned.
1845
dbf38e02
LMI
18462011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1847
1848 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1849 closes the connection while we're reading (bug#9182).
1850
d6f0886c 18512011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 1852
d6f0886c
JD
1853 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1854 are specified (Bug#9168).
24e0f6b1 1855
2eb1f9e6
PE
18562011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1857
1858 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1859 Found by GCC static checking and --with-wide-int on a 32-bit host.
1860
22381272 18612011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
1862
1863 * xdisp.c (compute_display_string_pos): Fix logic of caching
1864 previous display string position. Initialize cached_prev_pos to
1865 -1. Fixes slow-down at the beginning of a buffer.
1866
f25e39b4
EZ
18672011-07-24 Eli Zaretskii <eliz@gnu.org>
1868
1869 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1870 for attrs[LFACE_FONTSET_INDEX].
1871
04c4b52e
PE
18722011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1873
1874 * xml.c (parse_region): Remove unused local
1875 that was recently introduced.
1876
c1734fbd
EZ
18772011-07-23 Eli Zaretskii <eliz@gnu.org>
1878
be18c5a5
EZ
1879 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1880 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1881
c1734fbd
EZ
1882 * xdisp.c (move_it_in_display_line_to): Record the best matching
1883 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
1884 exit if none of the characters scanned was an exact match.
1885 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
1886 when exact match is impossible due to invisible text, and the
1887 lines are truncated.
1888
a258d627
JD
18892011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1890
1891 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1892 for OSX >= 10.7.
1893
b6d5a689
EZ
18942011-07-22 Eli Zaretskii <eliz@gnu.org>
1895
0f74f785
EZ
1896 Fix a significant slow-down of cursor motion with C-n, C-p,
1897 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1898 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 1899 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
1900 (next_element_from_buffer): Call compute_stop_pos_backwards to
1901 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
1902 base_level_stop.
1903 (reseat): Don't look for prev_stop, as that could mean a very long
1904 run.
1905 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1906 <cached_disp_overlay_modiff>: Cache for last found display string
1907 position.
551918c1 1908 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
1909 about the same buffer in the same area of character positions, and
1910 the buffer wasn't changed since the time the display string
1911 position was cached.
551918c1 1912
b2d0c91a
EZ
19132011-07-22 Eli Zaretskii <eliz@gnu.org>
1914
1915 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1916 is an integer, which is important for empty lines. (Bug#9149)
1917
043604ee
CY
19182011-07-22 Chong Yidong <cyd@stupidchicken.com>
1919
1920 * frame.c (Fmodify_frame_parameters): In tty case, update the
1921 default face if necessary (Bug#4238).
1922
da4adb04
CY
19232011-07-21 Chong Yidong <cyd@stupidchicken.com>
1924
1925 * editfns.c (Fstring_to_char): No need to explain what a character
1926 is in the docstring (Bug#6576).
1927
9abd0532
LMI
19282011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1929
1930 * xml.c (parse_region): Make sure we always return a tree.
1931
36881d16
HK
19322011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1933
1934 * xml.c (parse_region): If a document contains only comments,
1935 return that, too.
1936
1e98674d
LMI
19372011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1938
1939 * xml.c (make_dom): Return comments, too.
1940
590bd467
PE
19412011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1942
1943 Port to OpenBSD.
1944 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1945 and the surrounding thread.
1946 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1947 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1948 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1949 timer goes off.
1950 * s/openbsd.h (BROKEN_SIGIO): Define.
1951 * unexelf.c (unexec) [__OpenBSD__]:
1952 Don't update the .mdebug section of the Alpha COFF symbol table.
1953
f41628b2
LMI
19542011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1955
1956 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1957 (bug#8460).
1958
b59b67c5
PE
19592011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1960
15e3a074
PE
1961 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1962 This fixes some race conditions on the permissions of any newly
1963 created file.
1964
41bed37d
PE
1965 * alloc.c (valid_pointer_p): Use pipe, not open.
1966 This fixes some permissions issues when debugging.
1967
b59b67c5
PE
1968 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1969 If fchown fails to set both uid and gid, try to set just gid,
1970 as that is sometimes allowed. Adjust the file's mode to eliminate
1971 setuid or setgid bits that are inappropriate if fchown fails.
1972
925a6be7
SM
19732011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1974
1975 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1976 to compare Lisp_Objects.
1977 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1978 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1979 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1980
52968808
AS
19812011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1982
0a6a104b
AS
1983 * lread.c (read_integer): Unread even EOF character.
1984 (read1): Likewise. Properly record start position of symbol.
1985
52968808
AS
1986 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1987 symbol character follows.
1988
9e381cdd
PE
19892011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1990
1991 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1992 This works around a problem with the previous change to Fcopy_file.
1993 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1994 and without this change, GCC might complain about discarding
1995 fchown's return value.
1996
b5641435
JB
19972011-07-16 Juanma Barranquero <lekktu@gmail.com>
1998
1999 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2000
a8031457
PE
20012011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2002
2003 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2004
dd889327
LMI
20052011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2006
750c33f7
LMI
2007 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2008 it's used from the C level.
2009
dd889327
LMI
2010 * process.c: Use the same condition for POLL_FOR_INPUT in both
2011 keyboard.c and process.c (bug#1858).
2012
87e86684
LM
20132011-07-09 Lawrence Mitchell <wence@gmx.li>
2014
2015 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2016 (Fgnutls_boot): Use it.
2017
64348f40
AS
20182011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2019
2020 * doc.c (Fsubstitute_command_keys): Revert last change.
2021
1d698799
LMI
20222011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2023
f863868c
LMI
2024 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2025 quotes the next character, and doesn't affect other longer
2026 sequences (bug#8935).
2027
1d698799
LMI
2028 * lread.c (syms_of_lread): Clarify that is isn't only
2029 `eval-buffer' and `eval-defun' that's affected by
2030 `lexical-binding' (bug#8460).
2031
aa4b6df6
EZ
20322011-07-15 Eli Zaretskii <eliz@gnu.org>
2033
2034 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
2035 bidi redisplay when a line includes both an image and is
2036 truncated.
2037
5d856da6
PE
20382011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2039
ad6042bb
PE
2040 Fix minor problems found by static checking.
2041 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2042 (elsz): Now a signed constant, not a size_t var. We prefer signed
2043 types to unsigned, to avoid integer comparison confusion. Without
2044 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2045 "cannot optimize loop, the loop counter may overflow", a symptom
2046 of the confusion.
f00bbb22 2047 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
2048 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2049
6468f31c
LMI
20502011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2051
49080b10
LMI
2052 * search.c (Fre_search_backward): Mention `case-fold-search' in
2053 all the re_search_* functions (bug#8138).
2054
6468f31c
LMI
2055 * keyboard.c (Fopen_dribble_file): Document when the file is
2056 closed (bug#8056).
2057
c965adc5
EZ
20582011-07-14 Eli Zaretskii <eliz@gnu.org>
2059
df9733bf
EZ
2060 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2061 bidi_cache_idx.
2062
0bb23927
EZ
2063 Support bidi reordering of display and overlay strings.
2064 * xdisp.c (compute_display_string_pos)
2065 (compute_display_string_end): Accept additional argument STRING.
2066 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2067 (reseat_to_string): Initialize bidi_it->string.s and
2068 bidi_it->string.schars.
2069 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
2070 NULL (avoids a crash in bidi_paragraph_init).
2071 Initialize itb.string.lstring.
0bb23927
EZ
2072 (init_iterator): Call bidi_init_it only of a valid
2073 buffer position was specified. Initialize paragraph_embedding to
2074 L2R.
2075 (reseat_to_string): Initialize the bidi iterator.
2076 (display_string): If we need to ignore text properties of
2077 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2078 original value of -1 will not work with bidi.)
2079 (compute_display_string_pos): First arg is now struct
2080 `text_pos *'; all callers changed. Support display properties on
2081 Lisp strings.
2082 (compute_display_string_end): Support display properties on Lisp
2083 strings.
2084 (init_iterator, reseat_1, reseat_to_string): Initialize the
2085 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2086 when iterating on a string not from display properties).
640c8776
SM
2087 (compute_display_string_pos, compute_display_string_end):
2088 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
2089 arrow keys.
2090 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
2091 base_level_stop; instead, set base_level_stop to BEGV.
2092 Fixes crashes in vertical-motion.
0bb23927
EZ
2093 (next_element_from_buffer): Improve commentary for when
2094 the iterator is before prev_stop.
2095 (init_iterator): Initialize bidi_p from the default value of
2096 bidi-display-reordering, not from buffer-local value. Use the
2097 buffer-local value only if initializing for buffer iteration.
2098 (handle_invisible_prop): Support invisible properties on strings
2099 that are being bidi-reordered.
2100 (set_iterator_to_next): Support bidi reordering of C strings and
2101 Lisp strings.
2102 (next_element_from_string): Support bidi reordering of Lisp
2103 strings.
2104 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
2105 (display_string): Support display of R2L glyph rows.
2106 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
2107 (init_iterator): Don't initialize it->bidi_p for strings
2108 here.
2109 (reseat_to_string): Initialize it->bidi_p for strings here.
2110 (next_element_from_string, next_element_from_c_string)
2111 (next_element_from_buffer): Add xassert's for correspondence
2112 between IT's object being iterated and it->bidi_it.string
2113 structure.
2114 (face_before_or_after_it_pos): Support bidi iteration.
2115 (next_element_from_c_string): Handle the case of the first string
2116 character that is not the first one in the visual order.
2117 (get_visually_first_element): New function, refactored from common
2118 parts of next_element_from_buffer, next_element_from_string, and
2119 next_element_from_c_string.
2120 (tool_bar_lines_needed, redisplay_tool_bar)
2121 (display_menu_bar): Force left-to-right direction. Add a FIXME
2122 comment for making that be controlled by a user option.
2123 (push_it, pop_it): Save and restore the state of the
2124 bidi iterator. Save and restore the bidi_p flag.
2125 (pop_it): Iterate out of display property for string iteration as
2126 well.
2127 (iterate_out_of_display_property): Support iteration over strings.
2128 (handle_single_display_spec): Set up it->bidi_it for iteration
2129 over a display string, and call bidi_init_it.
2130 (handle_single_display_spec, next_overlay_string)
2131 (get_overlay_strings_1, push_display_prop): Set up the bidi
2132 iterator for displaying display or overlay strings.
2133 (forward_to_next_line_start): Don't use the shortcut if
2134 bidi-iterating.
2135 (back_to_previous_visible_line_start): If handle_display_prop
2136 pushed the iterator stack, restore the internal state of the bidi
2137 iterator by calling bidi_pop_it same number of times.
2138 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2139 and we are bidi-iterating, don't decrement the iterator position;
2140 instead, set the first_elt flag in the bidi iterator, to produce
2141 the same effect.
2142 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2143 (push_display_prop): xassert that we are iterating a buffer.
2144 (push_it, pop_it): Save and restore paragraph_embedding member.
2145 (handle_single_display_spec, next_overlay_string)
2146 (get_overlay_strings_1, reseat_1, reseat_to_string)
2147 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2148 correctly. Don't assume unibyte strings are not bidi-reordered.
2149 (compute_display_string_pos)
2150 (compute_display_string_end): Fix handling the case of C string.
2151 (push_it, pop_it): Save and restore from_disp_prop_p.
2152 (handle_single_display_spec, push_display_prop): Set the
2153 from_disp_prop_p flag.
2154 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2155 (pop_it): Call iterate_out_of_display_property only if we are
2156 popping after iteration over a string that came from a display
2157 property. Fix a typo in popping stretch info. Add an assertion
2158 for verifying that the iterator position is in sync with the bidi
2159 iterator.
2160 (handle_single_display_spec, get_overlay_strings_1)
2161 (push_display_prop): Fix initialization of paragraph direction for
2162 string when that of the parent object is not yet determined.
2163 (reseat_1): Call bidi_init_it to resync the bidi
2164 iterator with IT's position. (Bug#7616)
2165 (find_row_edges): If ROW->start.pos gives position
2166 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2167 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2168 Reset the from_disp_prop_p flag.
2169 (SAVE_IT, RESTORE_IT): New macros.
2170 (pos_visible_p, face_before_or_after_it_pos)
2171 (back_to_previous_visible_line_start)
2172 (move_it_in_display_line_to, move_it_in_display_line)
2173 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2174 (try_scrolling, redisplay_window, display_line): Use them when
2175 saving a temporary copy of the iterator and restoring it back.
2176 (back_to_previous_visible_line_start, reseat_1)
2177 (init_iterator): Empty the bidi cache "stack".
2178 (move_it_in_display_line_to): If iterator ended up at
2179 EOL, but we never saw any buffer positions smaller than
2180 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2181 motion in bidi-reordered lines.
2182 (move_it_in_display_line_to): Record prev_method and prev_pos
2183 immediately before the call to set_iterator_to_next. Fixes cursor
2184 motion in bidi-reordered lines with stretch glyphs and strings
2185 displayed in margins. (Bug#8133) (Bug#8867)
2186 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2187 TO_CHARPOS.
640c8776
SM
2188 (pos_visible_p): Support positions in bidi-reordered lines.
2189 Save and restore bidi cache.
0bb23927
EZ
2190
2191 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2192 (bidi_paragraph_info): Delete unused struct.
2193 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2194 (bidi_cache_start): New variable.
2195 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2196 to zero.
2197 (bidi_cache_fetch_state, bidi_cache_search)
2198 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2199 (bidi_cache_find, bidi_peek_at_next_level)
2200 (bidi_level_of_next_char, bidi_find_other_level_edge)
2201 (bidi_move_to_visually_next): Compare cache index with
2202 bidi_cache_start rather than with zero.
2203 (bidi_fetch_char): Accept new argument STRING; all callers
2204 changed. Support iteration over a string. Support strings with
2205 display properties. Support unibyte strings. Fix the type of
2206 `len' according to what STRING_CHAR_AND_LENGTH expects.
2207 (bidi_paragraph_init, bidi_resolve_explicit_1)
2208 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
2209 (bidi_level_of_next_char, bidi_move_to_visually_next):
2210 Support iteration over a string.
0bb23927
EZ
2211 (bidi_set_sor_type, bidi_resolve_explicit_1)
2212 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2213 can now be zero (for strings); special values 0 and -1 were
2214 changed to -1 and -2, respectively.
2215 (bidi_char_at_pos): New function.
2216 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2217 Call it instead of FETCH_MULTIBYTE_CHAR.
2218 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2219 initialized to valid values.
2220 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2221 values.
2222 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2223 the test for valid cached positions. Fix the logic for looking up
2224 the sentinel state in the cache. GCPRO the Lisp string we are
2225 iterating.
2226 (bidi_push_it, bidi_pop_it): New functions.
2227 (bidi_initialize): Initialize the bidi cache start stack pointer.
2228 (bidi_cache_ensure_space): New function, refactored from part of
2229 bidi_cache_iterator_state. Don't assume the required size is just
2230 one BIDI_CACHE_CHUNK away.
2231 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2232 (bidi_count_bytes, bidi_char_at_pos): New functions.
2233 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2234 always valid if bidi_cache_idx is valid.
2235 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2236 is valid if it's going to be used.
2237 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2238 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
2239 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2240 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
2241 (bidi_find_other_level_edge, bidi_cache_start_stack):
2242 All variables related to cache indices are now EMACS_INT.
c965adc5 2243
0bb23927
EZ
2244 * dispextern.h (struct bidi_string_data): New structure.
2245 (struct bidi_it): New member `string'. Make flag members be 1-bit
2246 fields, and put them last in the struct.
640c8776
SM
2247 (compute_display_string_pos, compute_display_string_end):
2248 Update prototypes.
0bb23927
EZ
2249 (bidi_push_it, bidi_pop_it): Add prototypes.
2250 (struct iterator_stack_entry): New members bidi_p,
2251 paragraph_embedding, and from_disp_prop_p.
2252 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
2253 (bidi_shelve_cache, bidi_unshelve_cache):
2254 Declare prototypes.
0bb23927
EZ
2255
2256 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2257 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2258 and vector-like objects.
2259
2260 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2261 cache around display iteration.
2262
2263 * window.c (Fwindow_end, window_scroll_pixel_based)
2264 (displayed_window_lines, Frecenter): Save and restore the bidi
2265 cache around display iteration.
2266
3bbd2265
LMI
22672011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2268
2269 * editfns.c (Fdelete_region): Clarify the use of the named
2270 parameters (bug#6788).
2271
adc47434
MR
22722011-07-14 Martin Rudalics <rudalics@gmx.at>
2273
2274 * indent.c (Fvertical_motion): Set and restore w->pointm when
2275 saving and restoring the window's buffer (Bug#9006).
2276
837c31f8
LMI
22772011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2278
2279 * editfns.c (Fstring_to_char): Clarify just what is returned
2280 (bug#6576). Text by Eli Zaretskii.
2281
ac389d0c
JB
22822011-07-13 Juanma Barranquero <lekktu@gmail.com>
2283
2284 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2285
0be0ce47
EZ
22862011-07-13 Eli Zaretskii <eliz@gnu.org>
2287
2288 * buffer.c (mmap_find): Fix a typo.
2289
cd18e7e3
JB
22902011-07-13 Johan Bockgård <bojohan@gnu.org>
2291
2292 Fix execution of x selection hooks.
2293 * xselect.c (Qx_lost_selection_functions)
2294 (Qx_sent_selection_functions): New vars.
2295 (syms_of_xselect): DEFSYM them.
2296 (x_handle_selection_request): Pass Qx_sent_selection_functions
2297 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2298 (x_handle_selection_clear,x_clear_frame_selections):
2299 Pass Qx_lost_selection_functions rather than
2300 Vx_lost_selection_functions to Frun_hook_with_args.
2301
47ea7f44
PE
23022011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2303
ac389d0c 2304 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
2305 The old code sometimes used this field without initializing it.
2306
47ea7f44
PE
2307 * alloc.c (gc_sweep): Don't read past end of array.
2308 In theory, the old code could also have corrupted Emacs internals,
2309 though it'd be very unlikely.
2310
bc985c87
AS
23112011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2312
2313 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 2314 argument. (Bug#4026)
bc985c87 2315
0cf34688
LMI
23162011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2317
b3dadd76
LMI
2318 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2319 key" (bug#4257).
2320
0cf34688
LMI
2321 * window.c (Fset_window_start): Doc fix (bug#4199).
2322 (Fset_window_hscroll): Ditto.
2323
270768cd
PE
23242011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2325
077e3dda 2326 Fix minor new problems caught by GCC 4.6.1.
270768cd 2327 * term.c (init_tty): Remove unused local.
490011a6 2328 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 2329 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 2330 not used otherwise.
270768cd 2331
b1f58454
CY
23322011-07-12 Chong Yidong <cyd@stupidchicken.com>
2333
2334 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2335
22b9578d
LMI
23362011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2337
6e70ab07
LMI
2338 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2339 are the mini-buffer and the echo area (bug#3320).
2340
22b9578d
LMI
2341 * term.c (init_tty): Remove support for supdup, c10 and perq
2342 terminals, which are no longer supported (bug#1482).
2343
8974cc9f
JB
23442011-07-10 Johan Bockgård <bojohan@gnu.org>
2345
2346 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2347
a560d974
JD
23482011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2349
2350 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2351 for non-popups (Bug#3642).
2352
1dae0f0a
AS
23532011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2354
268c2c36 2355 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 2356 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
2357 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2358 * cm.c (losecursor): Likewise.
1dae0f0a
AS
2359 * data.c (fmod): Likewise.
2360 * dispnew.c (swap_glyphs_in_rows): Likewise.
2361 * emacs.c (memory_warning_signal): Likewise.
2362 * floatfns.c (float_error): Likewise.
2363 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2364 (otf_open, font_otf_capability, generate_otf_features)
2365 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2366 Likewise.
2367 * image.c (pbm_read_file): Likewise.
2368 * indent.c (string_display_width): Likewise.
2369 * intervals.c (check_for_interval, search_for_interval)
2370 (inc_interval_count, count_intervals, root_interval)
2371 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2372 * lread.c (defalias): Likewise.
268c2c36 2373 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
2374 * regex.c (set_image_of_range_1, set_image_of_range)
2375 (regex_grow_registers): Likewise.
2376 * sysdep.c (strerror): Likewise.
2377 * termcap.c (valid_filename_p, tprint, main): Likewise.
2378 * tparam.c (main): Likewise.
2379 * unexhp9k800.c (run_time_remap, save_data_space)
2380 (update_file_ptrs, read_header, write_header, calculate_checksum)
2381 (copy_file, copy_rest, display_header): Likewise.
2382 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2383 Likewise.
2384 * xdisp.c (check_it): Likewise.
2385 * xfaces.c (register_color, unregister_color, unregister_colors):
2386 Likewise.
2387 * xfns.c (print_fontset_result): Likewise.
2388 * xrdb.c (member, fatal, main): Likewise.
2389
99033785
PE
23902011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2391
2392 Fix minor problems found by static checking (Bug#9031).
2393 * chartab.c (char_table_set_range, map_sub_char_table):
2394 Remove unused locals.
2395 (uniprop_table): Now static.
2396 * composite.c (_work_char): Remove unused static var.
2397
9cb2ac56
JB
23982011-07-09 Juanma Barranquero <lekktu@gmail.com>
2399
2400 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2401
f25661f0
JD
24022011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2403
2404 * gtkutil.c (qttip_cb): Remove code without function.
2405
8278c4fe
EZ
24062011-07-09 Eli Zaretskii <eliz@gnu.org>
2407
2408 * w32.c (pthread_sigmask): New stub.
2409
1692ae2d 24102011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 2411
8a6ebd58 2412 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
2413 sigprocmask is portable only for single-threaded applications, and
2414 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
2415 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2416 (LIBES): Use it.
2417 * callproc.c (Fcall_process):
2418 * process.c (create_process):
2419 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2420 Use pthread_sigmask, not sigprocmask.
123403e4 2421
1b854618
JD
24222011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2423
2424 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2425 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2426 wrong (Bug#8591).
2427
3fe4b549
JD
24282011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2429
0ce7e563
JD
2430 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2431 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2432 (xg_hide_tooltip): Fix comment.
2433
3fe4b549
JD
2434 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2435 in registerServicesMenuSendTypes.
2436 (validRequestorForSendType): Don't check ns_return_types.
2437
2438 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2439 ns_return_type.
2440
5df75e47
JR
24412011-07-08 Jason Rumney <jasonr@gnu.org>
2442
2443 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2444 frame struct members of non-existent frames (Bug#6284).
2445
699c10bd
JD
24462011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2447
4393663b
JD
2448 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2449 variable firstTime not needed on OSX >= 10.6.
2450 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2451 >= 10.5. Use setKnobProportion, setDoubleValue.
2452
2453 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2454 (MAC_OS_X_VERSION_10_5): Define if not defined.
2455 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2456 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2457 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2458
2459 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2460 cString and lossyCString on OSX >= 10.4
2461
2462 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2463 sizeToFit on OSX >= 10.2.
2464
2465 * nsimage.m (allocInitFromFile): Don't use deprecated method
2466 bestRepresentationForDevice on OSX >= 10.6.
2467
2468 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2469 to avoid warning.
2470
2471 * emacs.c: Declare unexec_init_emacs_zone.
2472
a63e0781
JD
2473 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2474
699c10bd
JD
2475 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2476
2477 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2478 on svcsMenu (Bug#8842).
2479
2480 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2481 ns_return_types.
2482 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2483
2484 * nsterm.m (QUTF8_STRING): Declare.
2485 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2486 (validRequestorForSendType): Return type is (id).
2487 Change indexOfObjectIdenticalTo to indexOfObject.
2488 Check if we have local selection before returning self (Bug#8842).
2489 (writeSelectionToPasteboard): Put local selection into paste board
2490 if we have a local selection (Bug#8842).
2491 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2492
2493 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2494 (ns_get_local_selection): Declare.
2495
54e10184
LMI
24962011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2497
9888ff71
LMI
2498 * keymap.c (describe_map_tree): Don't insert a double newline at
2499 the end of the buffer (bug#1169) and return whether we inserted
2500 something.
2501
54e10184
LMI
2502 * callint.c (Fcall_interactively): Change "reading args" to
2503 "providing args" to try to clarify what it does (bug#1010).
2504
15fa4783
KH
25052011-07-07 Kenichi Handa <handa@m17n.org>
2506
2507 * composite.c (composition_compute_stop_pos): Ignore a static
2508 composition starting before CHARPOS (Bug#8915).
2509
2510 * xdisp.c (handle_composition_prop): Likewise.
2511
a8815b00
EZ
25122011-07-07 Eli Zaretskii <eliz@gnu.org>
2513
2514 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2515 (Bug#9015)
2516
ef7b981d 25172011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
2518
2519 * character.h (unicode_category_t): New enum type.
2520
2521 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2522 (Qchar_code_property_table): New variable.
2523 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2524 (UNIPROP_COMPRESSED_FORM_P): New macros.
2525 (char_table_ascii): Uncompress the compressed values.
2526 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2527 Uncompress the compressed values.
ac389d0c 2528 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
2529 (char_table_ref_and_range): Uncompress the compressed values.
2530 (sub_char_table_set): New arg is_uniprop. Callers changed.
2531 Uncompress the compressed values.
2532 (sub_char_table_set_range): Args changed. Callers changed.
2533 (char_table_set_range): Adjuted for the above change.
2534 (map_sub_char_table): Delete args default_val and parent. Add arg
2535 top. Give decoded values to a Lisp function.
640c8776 2536 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
2537 values to a Lisp function. Gcpro more variables.
2538 (uniprop_table_uncompress)
2539 (uniprop_decode_value_run_length): New functions.
2540 (uniprop_decoder, uniprop_decoder_count): New variables.
2541 (uniprop_get_decoder, uniprop_encode_value_character)
2542 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2543 New functions.
2544 (uniprop_encoder, uniprop_encoder_count): New variables.
2545 (uniprop_get_encoder, uniprop_table)
2546 (Funicode_property_table_internal, Fget_unicode_property_internal)
2547 (Fput_unicode_property_internal): New functions.
2548 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2549 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 2550 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
2551 char-code-property-alist.
2552
640c8776 2553 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
2554 Vunicode_category_table.
2555
640c8776 2556 * font.c (font_range): Adjust for the change of
c805dec0
KH
2557 Vunicode_category_table.
2558
76b397fb
DN
25592011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2560
2561 * m/iris4d.h: Remove file, move contents ...
2562 * s/irix6-5.h: ... here.
2563
22b4128e
PE
25642011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2565
2566 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
2567 * alloc.c (mark_buffer):
2568 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2569 (clone_per_buffer_values): Don't assume that
22b4128e
PE
2570 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2571 This isn't true in general, and it's particularly not true
2572 if Emacs is configured with --with-wide-int.
2573 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2574 New macros, used in the buffer.c change.
2575
869795d6
JD
25762011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2577
2578 * xsettings.c: Use both GConf and GSettings if both are available.
2579 (store_config_changed_event): Add comment.
2580 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2581 (store_tool_bar_style_changed): New functions.
5e617bc2 2582 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
2583 (struct xsettings): Move font inside HAVE_XFT.
2584 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 2585 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 2586 Move inside HAVE_XFT.
640c8776 2587 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
2588 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2589 also.
2590 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 2591 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 2592 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
2593 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2594 (parse_settings): Move check for font inside HAVE_XFT.
2595 (read_settings, apply_xft_settings): Add comment.
2596 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2597 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2598 call store_font_name_changed.
2599 (xft_settings_event): Add comment.
2600 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2601 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2602 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2603 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2604 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
2605 (xsettings_get_system_font, xsettings_get_system_normal_font):
2606 Add comment.
869795d6 2607
d8ed26bd
PE
26082011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2609
2610 Random fixes. E.g., (random) never returned negative values.
2611 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2612 subseconds part to the entropy, as that's a bit more random.
2613 Prefer signed to unsigned, since the signedness doesn't matter and
2614 in general we prefer signed. When given a limit, use a
2615 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2616 latter isn't right if USE_2_TAGS_FOR_INTS.
2617 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2618 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2619
cabf1cac
SM
26202011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2621
2622 * textprop.c (text_property_stickiness):
2623 Obey Vtext_property_default_nonsticky.
2624 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2625 * w32fns.c (syms_of_w32fns):
2626 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2627
6e9b2be9
PE
26282011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2629
2630 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2631 This is more efficient than Ffile_directory_p and avoids a minor race.
2632
90186c68
LMI
26332011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2634
7c301272
LMI
2635 * buffer.c (Foverlay_put): Say what the return value is
2636 (bug#7835).
2637
c4f2d8d4
LMI
2638 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2639 is a directory before asking whether to use the file name
2640 (bug#7564).
ad637907
LMI
2641 (barf_or_query_if_file_exists): Make the "File is a directory"
2642 error be more correct.
c4f2d8d4 2643
90186c68
LMI
2644 * fns.c (Frequire): Remove the mention of the .gz files, since
2645 that's installation-specific, but keep the mention of
2646 `get-load-suffixes'.
2647
da64016e
PE
26482011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2649
2650 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2651 Report string overflow if the output is too long.
2652
7d47b580
JB
26532011-07-04 Juanma Barranquero <lekktu@gmail.com>
2654
a555cb87
JB
2655 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2656 (syms_of_gnutls): Remove duplicate DEFSYM for
2657 Qgnutls_bootprop_verify_hostname_error, an error for
2658 Qgnutls_bootprop_verify_error (which is no longer used).
2659
7d47b580
JB
2660 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2661 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2662 Also (re)move comments that are misplaced or no longer relevant.
2663
1e49bfab
LMI
26642011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2665
2666 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2667
1485f4c0
CY
26682011-07-03 Chong Yidong <cyd@stupidchicken.com>
2669
2670 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2671 and background color parameters if they have been changed.
2672
a9ab721e
LMI
26732011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2674
2675 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2676
cf7cff57
PE
26772011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2678
2e13213d
PE
2679 * xsettings.c (SYSTEM_FONT): Define only when used.
2680 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2681
cf7cff57
PE
2682 * keymap.c (access_keymap_1): Now static.
2683
7a8e04f7
CY
26842011-07-02 Chong Yidong <cyd@stupidchicken.com>
2685
2686 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2687 leave any prefix arg for the up event (Bug#1586).
2688
61352f62
LMI
26892011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2690
69bb1ef7
LMI
2691 * lread.c (syms_of_lread): Mention single symbols defined by
2692 `defvar' or `defconst' (bug#7154).
2693
61352f62 2694 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 2695 (Frequire): Mention get-load-suffixes.
61352f62 2696
28545e04
MR
26972011-07-02 Martin Rudalics <rudalics@gmx.at>
2698
2699 * window.h (window): Remove clone_number slot.
2700 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2701 Remove.
2702 (make_parent_window, make_window, saved_window)
2703 (Fset_window_configuration, save_window_save): Don't deal with
2704 clone numbers.
2705 * buffer.c (Qclone_number): Remove declaration.
2706 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2707
3349e122
SM
27082011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2709
2710 Add multiple inheritance to keymaps.
2711 * keymap.c (Fmake_composed_keymap): New function.
2712 (Fset_keymap_parent): Simplify.
2713 (fix_submap_inheritance): Remove.
2714 (access_keymap_1): New function extracted from access_keymap to handle
2715 embedded parents and handle lists of maps.
2716 (access_keymap): Use it.
2717 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2718 (Fcopy_keymap): Handle embedded parents.
2719 (Fcommand_remapping, define_as_prefix): Simplify.
2720 (Fkey_binding): Simplify.
2721 (syms_of_keymap): Move minibuffer-local-completion-map,
2722 minibuffer-local-filename-completion-map,
2723 minibuffer-local-must-match-map, and
2724 minibuffer-local-filename-must-match-map to Elisp.
2725 (syms_of_keymap): Defsubr make-composed-keymap.
2726 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2727 (parse_menu_item): Trivial simplification.
2728
3279eb87
GM
27292011-07-01 Glenn Morris <rgm@gnu.org>
2730
2731 * Makefile.in (SETTINGS_LIBS): Fix typo.
2732
4550efdf
KI
27332011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2734
2735 * coding.c (Fencode_coding_string): Record the last coding system
2736 used, as the function doc string says (bug#8738).
2737
0949d2b6
JD
27382011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2739
2740 * xsettings.c (store_monospaced_changed): Take new font as arg and
2741 check for change against current_mono_font.
2742 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2743 (emacs_settings_constructor, emacs_settings_get_property)
2744 (emacs_settings_set_property, emacs_settings_class_init)
2745 (emacs_settings_init, gsettings_obj): Remove.
2746 (something_changedCB): New function for HAVE_GSETTINGS.
2747 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2748 with value as argument.
2749 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2750 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 2751 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
2752 "changed".
2753
2754 * xgselect.c: Add defined (HAVE_GSETTINGS).
2755 (xgselect_initialize): Ditto.
2756
2757 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2758 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2759 xg_select.
2760
bbc6b304
PE
27612011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2762
2763 * eval.c (struct backtrace): Simplify and port the data structure.
2764 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2765 signed bit field, as this assumption is not portable and it makes
2766 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2767 "char debug_on_exit : 1" as this is not portable either; instead,
2768 use the portable "unsigned int debug_on_exit : 1". Remove unused
2769 member evalargs. Remove obsolete comments about cc bombing out.
2770
9851bfc5
JD
27712011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2772
51bb811f 2773 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
2774 Let HAVE_GSETTINGS override HAVE_GCONF.
2775 (store_monospaced_changed): New function.
2776 (EMACS_SETTINGS): A new type derived from GObject to handle
2777 GSettings notifications.
2778 (emacs_settings_constructor, emacs_settings_get_property)
2779 (emacs_settings_set_property, emacs_settings_class_init):
2780 New functions.
2781 (gsettings_client, gsettings_obj): New variables.
2782 (GSETTINGS_SCHEMA): New define.
2783 (something_changedCB): Call store_monospaced_changed.
2784 (init_gsettings): New function.
2785 (xsettings_initialize): Call init_gsettings.
2786 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2787 to NULL.
2788
640c8776 2789 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
2790 GCONF_CFLAGS/LIBS.
2791
5386012d
MR
27922011-06-29 Martin Rudalics <rudalics@gmx.at>
2793
2794 * window.c (resize_root_window, grow_mini_window)
2795 (shrink_mini_window): Rename Qresize_root_window to
2796 Qwindow_resize_root_window and Qresize_root_window_vertically to
2797 Qwindow_resize_root_window_vertically.
2798
f13e0b08
PE
27992011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2800
2801 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2802
94515237
JB
28032011-06-27 Juanma Barranquero <lekktu@gmail.com>
2804
2805 * makefile.w32-in: Redesign dependencies so they reflect more
2806 clearly which files are directly included by each source file,
2807 and not through other includes.
2808
e43b6e43
MR
28092011-06-27 Martin Rudalics <rudalics@gmx.at>
2810
2811 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2812 (sort_overlays, overlay_strings): When an overlay's clone number
2813 matches the window's clone number process the overlay even if
2814 the overlay's window property doesn't match the current window.
2815
d68443dc
MR
2816 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2817 (Fwindow_hchild): Rename to Fwindow_left_child.
2818 (Fwindow_next): Rename to Fwindow_next_sibling.
2819 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
2820 (resize_window_check): Rename to window_resize_check.
2821 (resize_window_apply): Rename to window_resize_apply.
2822 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2823 (Fdelete_other_windows_internal, resize_frame_windows)
2824 (Fsplit_window_internal, Fdelete_window_internal)
2825 (grow_mini_window, shrink_mini_window)
2826 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 2827
c7e73be5
JD
28282011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2829
2830 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2831 (emacs_fixed_set_min_size): Remove.
2832 (emacs_fixed_new): Take frame as argument.
2833
2834 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2835 (_EmacsFixedPrivate): Remove minwidth/height.
2836 Add struct frame *f.
2837 (emacs_fixed_init): Initialize priv->f.
2838 (get_parent_class, emacs_fixed_set_min_size): Remove.
2839 (emacs_fixed_new): Set priv->f to argument.
2840 (emacs_fixed_get_preferred_width)
2841 (emacs_fixed_get_preferred_height): Use min_width/height from
2842 frames size_hint to set minimum and natural (Bug#8919).
2843 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2844 and use min_width/height from frames size_hint to set
2845 min_width/height (Bug#8919).
2846
2847 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
2848 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2849 Fix indentation.
c7e73be5 2850
cf99dcf8
EZ
28512011-06-26 Eli Zaretskii <eliz@gnu.org>
2852
2853 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2854 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2855 called at ZV.
2856
029529ac
CY
28572011-06-26 Chong Yidong <cyd@stupidchicken.com>
2858
2859 * process.c (wait_reading_process_output): Bypass select if
2860 waiting for a cell while ignoring keyboard input, and input is
2861 pending. Suggested by Jan Djärv (Bug#8869).
2862
7a7ef429
PE
28632011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2864
2865 Use gnulib's dup2 module instead of rolling our own.
2866 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2867
11fdef7d 28682011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
2869
2870 * dispnew.c (scrolling_window): Before scrolling, turn off a
2871 mouse-highlight in the window being scrolled.
2872
cd3520a4
JB
28732011-06-24 Juanma Barranquero <lekktu@gmail.com>
2874
2875 Move DEFSYM to lisp.h and use everywhere.
2876
2877 * character.h (DEFSYM): Move declaration...
2878 * lisp.h (DEFSYM): ...here.
2879
2880 * gnutls.c:
2881 * minibuf.c:
2882 * w32menu.c:
2883 * w32proc.c:
2884 * w32select.c: Don't include character.h.
2885
2886 * alloc.c (syms_of_alloc):
2887 * buffer.c (syms_of_buffer):
2888 * bytecode.c (syms_of_bytecode):
2889 * callint.c (syms_of_callint):
2890 * casefiddle.c (syms_of_casefiddle):
2891 * casetab.c (init_casetab_once):
2892 * category.c (init_category_once, syms_of_category):
2893 * ccl.c (syms_of_ccl):
2894 * cmds.c (syms_of_cmds):
2895 * composite.c (syms_of_composite):
2896 * dbusbind.c (syms_of_dbusbind):
2897 * dired.c (syms_of_dired):
2898 * dispnew.c (syms_of_display):
2899 * doc.c (syms_of_doc):
2900 * editfns.c (syms_of_editfns):
2901 * emacs.c (syms_of_emacs):
2902 * eval.c (syms_of_eval):
2903 * fileio.c (syms_of_fileio):
2904 * fns.c (syms_of_fns):
2905 * frame.c (syms_of_frame):
2906 * fringe.c (syms_of_fringe):
2907 * insdel.c (syms_of_insdel):
2908 * keymap.c (syms_of_keymap):
2909 * lread.c (init_obarray, syms_of_lread):
2910 * macros.c (syms_of_macros):
2911 * msdos.c (syms_of_msdos):
2912 * print.c (syms_of_print):
2913 * process.c (syms_of_process):
2914 * search.c (syms_of_search):
2915 * sound.c (syms_of_sound):
2916 * syntax.c (init_syntax_once, syms_of_syntax):
2917 * terminal.c (syms_of_terminal):
2918 * textprop.c (syms_of_textprop):
2919 * undo.c (syms_of_undo):
2920 * w32.c (globals_of_w32):
2921 * window.c (syms_of_window):
2922 * xdisp.c (syms_of_xdisp):
2923 * xfaces.c (syms_of_xfaces):
2924 * xfns.c (syms_of_xfns):
2925 * xmenu.c (syms_of_xmenu):
2926 * xsettings.c (syms_of_xsettings):
2927 * xterm.c (syms_of_xterm): Use DEFSYM.
2928
4228cf16
TZ
29292011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2930
cd3520a4 2931 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 2932
7fcccf1e
PE
29332011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2934
7efb4e0e
PE
2935 Integer and buffer overflow fixes (Bug#8873).
2936
ff5844ad
PE
2937 * print.c (printchar, strout): Check for string overflow.
2938 (PRINTPREPARE, printchar, strout):
2939 Don't set size unless allocation succeeds.
2940
90532f02
PE
2941 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2942 for sizes. Check for string overflow more accurately.
2943 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2944
6d84508d
PE
2945 * macros.c: Integer and buffer overflow fixes.
2946 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2947 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2948 Use ptrdiff_t, not int, for sizes.
2949 Don't increment bufsize until after realloc succeeds.
2950 Check for size-calculation overflow.
2951 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2952
437b2cb4
PE
2953 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2954
8b9ac8b4
PE
2955 * lread.c: Integer overflow fixes.
2956 (read_integer): Radix is now EMACS_INT, not int,
2957 to improve quality of diagnostics for out-of-range radices.
2958 Calculate buffer size correctly for out-of-range radices.
2959 (read1): Check for integer overflow in radices, and in
2960 read-circle numbers.
82cb60d3
PE
2961 (read_escape): Avoid int overflow.
2962 (Fload, openp, read_buffer_size, read1)
2963 (substitute_object_recurse, read_vector, read_list, map_obarray):
2964 Use ptrdiff_t, not int, for sizes.
2965 (read1): Use EMACS_INT, not int, for sizes.
20270765 2966 Check for size overflow.
8b9ac8b4 2967
7fcccf1e
PE
2968 * image.c (cache_image): Check for size arithmetic overflow.
2969
bfbbd7e7
PE
2970 * lread.c: Integer overflow issues.
2971 (saved_doc_string_size, saved_doc_string_length)
2972 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2973 Now ptrdiff_t, not int.
2974 (read1): Don't assume doc string length fits in int. Check for
2975 out-of-range doc string lengths.
2976 (read_list): Don't assume file position fits in int.
39019e54 2977 (read_escape): Check for hex character overflow.
bfbbd7e7 2978
4e323265
LL
29792011-06-22 Leo Liu <sdl.web@gmail.com>
2980
2981 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2982 Move to minibuffer.el.
2983
85fece3e
PE
29842011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2985
20b84ce9 2986 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
2987 The following patches are for when GLYPH_DEBUG && !XASSERT.
2988 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2989 * dispnew.c (flush_stdout):
2990 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2991 Mark as externally visible.
2992 * dispnew.c (check_window_matrix_pointers): Now static.
2993 * dispnew.c (window_to_frame_vpos):
2994 * xfns.c (unwind_create_frame):
2995 * xterm.c (x_check_font): Remove unused local.
2996 * scroll.c (CHECK_BOUNDS):
2997 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2998 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2999 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3000 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3001 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3002 Now static.
3003 (debug_method_add): Use va_list and vsprintf rather than relying
3004 on undefined behavior with wrong number of arguments.
3005 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3006 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3007 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3008 since we're not interested in debugging glyphs with old libraries.
3009 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3010 GCC 4.6.0's static checking.
3011
0766b489
PE
30122011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3013
31fd4b32
PE
3014 Integer overflow and signedness fixes (Bug#8873).
3015 A few related buffer overrun fixes, too.
3016
b79e8648
PE
3017 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3018
0766b489
PE
3019 * dispextern.h (struct face.stipple):
3020 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3021 (x_bitmap_mask, x_allocate_bitmap_record)
3022 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3023 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3024 (x_create_bitmap_from_xpm_data):
3025 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3026 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3027 (.bitmaps_last):
3028 * xfaces.c (load_pixmap):
3029 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3030 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3031 (.bitmaps_last, struct x_output.icon_bitmap):
3032 Use ptrdiff_t, not int, for bitmap indexes.
3033 (x_allocate_bitmap_record): Check for size overflow.
3034 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3035
b081724f
PE
3036 Use ptrdiff_t, not int, for overlay counts.
3037 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3038 * editfns.c (overlays_around, get_pos_property):
3039 * textprop.c (get_char_property_and_overlay):
3040 * xdisp.c (next_overlay_change, note_mouse_highlight):
3041 * xfaces.c (face_at_buffer_position):
21514da7
PE
3042 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3043 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3044 (Fnext_overlay_change, Fprevious_overlay_change)
3045 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 3046 Use ptrdiff_t, not int, for sizes.
21514da7 3047 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 3048
3de73e5e
PE
3049 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3050
2606c57b
PE
3051 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3052 (x_session_initialize): Do not assume string length fits in int.
3053
aaafe47a
PE
3054 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3055 This is unlikely, but can occur if DPI is outlandish.
3056
2674ddc8 3057 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
3058 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3059
28154962
PE
3060 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3061 * xrdb.c (magic_file_p, search_magic_path):
3062 Omit last arg SUFFIX; it was always 0. All callers changed.
3063 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3064
7de51af5
PE
3065 * xfont.c (xfont_match): Avoid need for strlen.
3066
25ed6cc3
PE
3067 * xfns.c: Don't assume strlen fits in int.
3068 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3069
4eab31dd
PE
3070 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3071 not unsigned long, as we prefer signed integers. All callers changed.
3072 Detect integer overflow in repeat count.
3073 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 3074 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 3075
171e2a58
PE
3076 * termcap.c: Don't assume sizes fit in int and never overflow.
3077 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3078 (gobble_line): Check for size-calculation overflow.
3079
ad39faca 3080 * minibuf.c (Fread_buffer):
6e5bb2dc 3081 * lread.c (intern, intern_c_string):
74ca2eb3
PE
3082 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3083 Don't assume string length fits in int.
3084
52c61c22 3085 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
3086 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3087
b5b8c9e5
PE
3088 * font.c: Don't assume string length fits in int.
3089 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3090 Use ptrdiff_t, not int.
ccd6111c
PE
3091 (font_intern_prop): Don't assume string length fits in int.
3092 Don't assume integer property fits in fixnum.
3093 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 3094
882f0d81 3095 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 3096 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
3097 Reformulate so as not to need the command string.
3098 Invoke gzip -cd rather than gunzip, as it's more portable.
3099 (lock_info_type, lock_file_1, lock_file):
3100 Don't assume pid_t and time_t fit in unsigned long.
3101 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3102 (current_lock_owner): Prefer signed type for sizes.
3103 Use memcpy, not strncpy, where memcpy is what is really wanted.
3104 Don't assume (via atoi) that time_t and pid_t fit in int.
3105 Check for time_t and/or pid_t out of range, e.g., via a network share.
3106 Don't alloca where an auto var works fine.
3107
93f4cf88
PE
3108 * fileio.c: Fix some integer overflow issues.
3109 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3110 Don't assume string length fits in int.
3111 (directory_file_name): Don't assume string length fits in long.
3112 (make_temp_name): Don't assume pid fits in int, or that its print
3113 length is less than 20.
3114
f3e92b69
PE
3115 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3116
1bfdaf10
PE
3117 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3118
35016e9a
PE
3119 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3120
3d1e65a1
PE
3121 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3122 We prefer signed integers, even for size calculations.
3123
0b963a93
PE
3124 * emacs.c: Don't assume string length fits in 'int'.
3125 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3126 (main): Don't invoke strlen when not needed.
3127
573f4b54
PE
3128 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3129 (XD_DEBUG_MESSAGE): Don't waste a byte.
3130
989f33ba
PE
3131 * callproc.c (getenv_internal_1, getenv_internal)
3132 (Fgetenv_internal):
965d34eb
PE
3133 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3134
e4d29b33
PE
3135 * lread.c (invalid_syntax): Omit length argument.
3136 All uses changed. This doesn't fix a bug, but it simplifies the
3137 code away from its former Hollerith-constant appearance, and it's
3138 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 3139 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 3140
eb49b136
PE
3141 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3142 This didn't break anything, but it didn't help either.
3143 It's confusing to put a bogus integer in a place where the actual
3144 value does not matter.
9f62aeb1 3145 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 3146 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 3147
15375a22
PE
3148 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3149 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3150 implementation.
b61cc01c
PE
3151 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3152 We prefer signed types, and the value cannot exceed the EMACS_INT
3153 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
3154 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3155 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3156 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 3157
53b2623d
PE
3158 * indent.c (sane_tab_width): New function.
3159 (current_column, scan_for_column, Findent_to, position_indentation)
3160 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 3161 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 3162
51cab52b 3163 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 3164
f2ed8a70
PE
3165 * lisp.h (lint_assume): New macro.
3166 * composite.c (composition_gstring_put_cache):
3167 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3168
abe80cc6
PE
3169 * editfns.c, insdel.c:
3170 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 3171
b02c740e
PE
3172 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3173
ebc96716
PE
3174 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3175
b4e50fa0 3176 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 3177 Use much-faster test for byte-length change.
311d5d7c 3178 Don't assume string byte-length fits in 'int'.
a4cf38e4 3179 Check that character arg fits in 'int'.
85461888 3180 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 3181
c0c1ee9f
PE
3182 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3183
a498d7f4
PE
3184 * fns.c (concat): Catch string overflow earlier.
3185 Do not rely on integer wraparound.
3186
51cab52b
PE
3187 * dispextern.h (struct it.overlay_strings_charpos)
3188 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
3189 * xdisp.c (forward_to_next_line_start)
3190 (back_to_previous_visible_line_start)
3191 (reseat_at_next_visible_line_start, next_element_from_buffer):
3192 Don't arbitrarily truncate the value of 'selective' to int.
3193
76031fad
PE
3194 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3195
5eb55db9
PE
3196 * composite.c: Don't truncate sizes to 'int'.
3197 (composition_gstring_p, composition_reseat_it)
3198 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
3199 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3200 not EMACS_UINT, for indexes.
5eb55db9 3201
0703a717
PE
3202 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3203
d6202519
PE
3204 * buffer.c: Include <verify.h>.
3205 (struct sortvec.priority, struct sortstr.priority):
8961a454 3206 Now EMACS_INT, not int.
c20998a7 3207 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
3208 (struct sortstr.size, record_overlay_string)
3209 (struct sortstrlist.size, struct sortlist.used):
3210 Don't truncate size to int.
3211 (record_overlay_string): Check for size-calculation overflow.
d6202519 3212 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 3213
d5a19415
JM
32142011-06-22 Jim Meyering <meyering@redhat.com>
3215
029529ac 3216 Don't leak an XBM-image-sized buffer
d5a19415
JM
3217 * image.c (xbm_load): Free the image buffer after using it.
3218
a9041e6c
PE
32192011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3220
3221 Port to Sun C.
3222 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3223 that Sun C diagnosed.
3224 * fns.c (secure_hash): Fix pointer signedness issue.
3225 * intervals.c (static_offset_intervals): New function.
3226 (offset_intervals): Use it.
3227
7f3f739f
LL
32282011-06-21 Leo Liu <sdl.web@gmail.com>
3229
3230 * deps.mk (fns.o):
3231 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3232 sha512.h.
3233
3234 * fns.c (secure_hash): Rename from crypto_hash_function and change
3235 the first arg to accept symbols.
5b66d427 3236 (Fsecure_hash): New primitive.
7f3f739f
LL
3237 (syms_of_fns): New symbols.
3238
76147d94
DD
32392011-06-20 Deniz Dogan <deniz@dogan.se>
3240
3241 * process.c (Fset_process_buffer): Clarify return value in
3242 docstring.
3243
7d7d0045
CY
32442011-06-18 Chong Yidong <cyd@stupidchicken.com>
3245
3246 * dispnew.c (add_window_display_history): Use BVAR.
3247
3248 * xdisp.c (debug_method_add): Use BVAR.
3249 (check_window_end, dump_glyph_matrix, dump_glyph)
3250 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3251
3252 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3253 Likewise.
3254
3255 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3256 check till after the cache is created in init_frame_faces.
3257
ff2bc410
SM
32582011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3259
3260 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3261
28177add
PE
32622011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3263
dd3482fe
PE
3264 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3265 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3266 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3267
393d71f3 3268 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
3269 * fileio.c (Finsert_file_contents):
3270 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3271 Remove the old (too-loose) buffer overflow checks.
3272 They weren't needed, since make_gap checks for buffer overflow.
3273 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3274 The old code merely checked for Emacs fixnum overflow, and relied
3275 on undefined (wraparound) behavior. The new code avoids undefined
3276 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3277
2e6813b0 3278 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
3279 Tune. Don't use wider integers than needed. Don't use alloca.
3280 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 3281
599a9e4f
PE
3282 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3283
99561444
PE
3284 * insdel.c, lisp.h (buffer_overflow): New function.
3285 (insert_from_buffer_1, replace_range, replace_range_2):
3286 * insdel.c (make_gap_larger):
3287 * editfns.c (Finsert_char):
3288 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3289
28177add
PE
3290 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3291
e69dafad
PE
32922011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3293
a7af7fde 3294 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 3295
b1c46f02
PE
3296 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3297 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3298
e69dafad
PE
3299 * fileio.c: Don't assume EMACS_INT fits in off_t.
3300 (emacs_lseek): New static function.
3301 (Finsert_file_contents, Fwrite_region): Use it.
3302 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3303
566684ea
PE
3304 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3305
e6966cd6
PE
3306 * fns.c: Don't overflow int when computing a list length.
3307 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3308 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3309 truncation on 64-bit hosts. Check for QUIT every
3310 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3311 faster and is responsive enough.
3312 (Flength): Report an error instead of overflowing an integer.
3313 (Fsafe_length): Return a float if the value is not representable
3314 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 3315 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 3316 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 3317
dd0b0efb
PE
3318 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3319 (header_size, word_size): New constants.
3320 (allocate_vectorlike): Don't check size overflow here.
3321 (allocate_vector): Check it here instead, since this is the only
3322 caller of allocate_vectorlike that could cause overflow.
3323 Check that the new vector's length is representable as a fixnum.
3324
86fe5cfe
PE
3325 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3326 The previous code was bogus. For example, next_almost_prime (32)
3327 returned 39, which is undesirable as it is a multiple of 3; and
3328 next_almost_prime (24) returned 25, which is a multiple of 5 so
3329 why was the code bothering to check for multiples of 7?
3330
80e88859
PE
3331 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3332
4a2f0ad6
PE
3333 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3334
f66c7cf8
PE
3335 Variadic C functions now count arguments with ptrdiff_t.
3336 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3337 Back then I didn't know that the Emacs coding style prefers signed int.
3338 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
3339 were being counted with int, which may truncate counts on 64-bit
3340 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
3341 * lisp.h (struct Lisp_Subr.function.aMANY)
3342 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3343 Arg counts are now ptrdiff_t, not size_t.
3344 All variadic functions and their callers changed accordingly.
3345 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3346 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3347 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3348 * callint.c (Fcall_interactively): Check arg count for overflow,
3349 to avoid potential buffer overrun. Use signed char, not 'int',
3350 for 'varies' array, so that we needn't bother to check its size
3351 calculation for overflow.
3352 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3353 * eval.c (apply_lambda):
3354 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3355 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3356 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3357
a1759b76
PE
3358 * callint.c (Fcall_interactively): Don't use index var as event count.
3359
d96be9fc
PE
3360 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3361 * mem-limits.h (SIZE): Remove; no longer used.
3362
a690a978 3363 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 3364
578c21e6
PE
3365 Remove unnecessary casts.
3366 * xterm.c (x_term_init):
3367 * xfns.c (x_set_border_pixel):
3368 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3369 These aren't needed now that we assume ANSI C.
3370
96f53c6c
PE
3371 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3372 It's more likely to cause problems (due to unsigned overflow)
3373 than to cure them.
3374
83c77d31
PE
3375 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3376
ee2079f1
PE
3377 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3378
6da65536
PE
3379 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3380
7147c4a4
PE
3381 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3382
193e32d9
PE
3383 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3384
e5533da6
PE
3385 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3386
9910e595
PE
3387 GLYPH_CODE_FACE returns EMACS_INT, not int.
3388 * dispextern.h (merge_faces):
3389 * xfaces.c (merge_faces):
01103c44
PE
3390 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3391 Don't assume EMACS_INT fits in int.
9910e595 3392
2638320e
PE
3393 * character.h (CHAR_VALID_P): Remove unused parameter.
3394 * fontset.c, lisp.h, xdisp.c: All uses changed.
3395
045eb8d9
PE
3396 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3397
c1f134b5
PE
3398 * fns.c (concat): Minor tuning based on overflow analysis.
3399 This doesn't fix any bugs. Use int to hold character, instead
3400 of constantly refetching from Emacs object. Use XFASTINT, not
3401 XINT, for value known to be a character. Don't bother comparing
3402 a single byte to 0400, as it's always less.
3403
395fcb93 3404 * floatfns.c (Fexpt):
327eeec8
PE
3405 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3406
abbd3d23
PE
3407 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3408 for characters.
3409
684a03ef
PE
3410 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3411
0fed43f3
PE
3412 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3413 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3414 incorrectly succeed when S was a string, because 4294967386 was
3415 truncated before it was used.
3416
8fd02eb7
PE
3417 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3418 Otherwise, an out-of-range integer could cause undefined behavior
3419 on a 64-bit host.
3420
f8c86b69
PE
3421 * composite.c: Use int, not EMACS_INT, for characters.
3422 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3423 EMACS_INT, for values that are known to be in character range.
3424 This doesn't fix any bugs but is the usual style inside Emacs and
3425 may generate better code on 32-bit machines.
3426
34206dd2
PE
3427 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3428 This is for reasons similar to the recent CHAR_STRING fix.
3429 * charset.c (Fencode_char): Check that character arg is actually
3430 a character. Pass an int to ENCODE_CHAR.
3431 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3432 wider than 'int', as a compile-time check to prevent future regressions
3433 in this area.
3434
c5958d4c 3435 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
3436
3437 Make sure a 64-bit char is never passed to CHAR_STRING.
3438 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3439 by silently ignoring the top 32 bits, allowing some values
3440 that were far too large to be valid characters.
3441 * character.h: Include <verify.h>.
3442 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3443 arguments are no wider than unsigned, as a compile-time check
3444 to prevent future regressions in this area.
3445 * data.c (Faset):
01103c44 3446 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
3447 (Fsubst_char_in_region):
3448 * fns.c (concat):
3449 * xdisp.c (decode_mode_spec_coding):
3450 Adjust to CHAR_STRING's new requirement.
3451 * editfns.c (Finsert_char, Fsubst_char_in_region):
3452 * fns.c (concat): Check that character args are actually
3453 characters. Without this test, these functions did the wrong
3454 thing with wildly out-of-range values on 64-bit hosts.
3455
d37ca623
PE
3456 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3457 These casts should not be needed on 32-bit hosts, either.
3458 * keyboard.c (read_char):
3459 * lread.c (Fload): Remove casts to unsigned.
3460
ea204efb
PE
3461 * lisp.h (UNSIGNED_CMP): New macro.
3462 This fixes comparison bugs on 64-bit hosts.
3463 (ASCII_CHAR_P): Use it.
3464 * casefiddle.c (casify_object):
01103c44 3465 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
3466 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3467 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3468 * dispextern.h (FACE_FROM_ID):
3469 * keyboard.c (read_char): Use UNSIGNED_CMP.
3470
41cb286c
PE
3471 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3472 not to EMACS_INT, to avoid GCC warning.
3473
4a1b9832
PE
3474 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3475
55daad71
PE
3476 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3477 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3478 isn't needed on 32-bit machines.
8f95c75c 3479
01103c44
PE
3480 * buffer.c (Fgenerate_new_buffer_name):
3481 Use EMACS_INT for count, not int.
0ceccced 3482 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
3483
3484 * data.c (Qcompiled_function): Now static.
3485
c6f072e7
PE
3486 * window.c (window_body_lines): Now static.
3487
20ce5912
PE
3488 * image.c (gif_load): Rename local to avoid shadowing.
3489
9c4c5f81
PE
3490 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3491 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3492 * alloc.c (make_save_value): Integer argument is now of type
3493 ptrdiff_t, not int.
3494 (mark_object): Use ptrdiff_t, not int.
3495 * lisp.h (pD): New macro.
3496 * print.c (print_object): Use it.
3497
c0c5c8ae
PE
3498 * alloc.c: Use EMACS_INT, not int, to count objects.
3499 (total_conses, total_markers, total_symbols, total_vector_size)
3500 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
3501 (total_free_floats, total_floats, total_free_intervals)
3502 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
3503 Now EMACS_INT, not int. All uses changed.
3504 (Fgarbage_collect): Compute overall total using a double, so that
3505 integer overflow is less likely to be a problem. Check for overflow
3506 when converting back to an integer.
5a25e253
PE
3507 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3508 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3509 These were 'int' variables that could overflow on 64-bit hosts;
3510 they were never used, so remove them instead of repairing them.
211a0b2a 3511 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
3512 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3513 Previously, this ceilinged at INT_MAX, but that doesn't work on
3514 64-bit machines.
e46bb31a 3515 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 3516
c78baabf 3517 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 3518 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
3519 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3520 when a (possibly-narrower) signed value would do just as well.
3521 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 3522
c9d624c6
PE
3523 * alloc.c: Catch some string size overflows that we were missing.
3524 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3525 for convenience in STRING_BYTES_MAX.
3526 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3527 The definition here is exact; the one in lisp.h was approximate.
3528 (allocate_string_data): Check for string overflow. This catches
3529 some instances we weren't catching before. Also, it catches
3530 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3531 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3532 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 3533
c9d624c6
PE
3534 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3535 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 3536 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 3537
353032ce
PE
3538 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3539
2bccce07
PE
3540 * alloc.c (Fmake_string): Check for out-of-range init.
3541
0ac30604
SM
35422011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3543
3544 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3545
c195f2de
JD
35462011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3547
3548 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3549 xg_get_default_scrollbar_width.
3550
3551 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3552 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3553 (style_changed_cb): Call update_theme_scrollbar_width and call
3554 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3555 all frames (Bug#8505).
3556 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3557 Call gtk_window_set_resizable if HAVE_GTK3.
3558 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3559 and height if HAVE_GTK3 (Bug#8505).
3560 (scroll_bar_width_for_theme): New variable.
3561 (update_theme_scrollbar_width): New function.
3562 (xg_get_default_scrollbar_width): Move code to
3563 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3564 (xg_initialize): Call update_theme_scrollbar_width.
3565
3566 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3567
3568 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3569
e10ac9f1
MR
35702011-06-12 Martin Rudalics <rudalics@gmx.at>
3571
3572 * frame.c (make_frame): Call other_buffer_safely instead of
3573 other_buffer.
3574
3575 * window.c (temp_output_buffer_show): Call display_buffer with
3576 second argument Vtemp_buffer_show_specifiers and reset latter
3577 immediately after the call.
3578 (Vtemp_buffer_show_specifiers): New variable.
3579 (auto_window_vscroll_p, next_screen_context_lines)
3580 (Vscroll_preserve_screen_position): Remove leading asterisks from
3581 doc-strings.
3582
2d3c217e 35832011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 3584
7b7f97e8 3585 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
3586 * buffer.c (Qclone_number): Remove for now, as it's unused.
3587 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3588 (record_buffer): Remove unused local.
3589 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3590 (set_frame_buffer_list): Remove; unused.
3591 * frame.h (other_visible_frames): Remove decl.
3592 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3593 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3594 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3595 if HAVE_GPM.
3596 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3597 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3598 Define only if HAVE_GPM.
3599 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3600 (update_hints_inhibit): Remove; never set. All uses removed.
3601 * widgetprv.h (emacsFrameClassRec): Remove decl.
3602 * window.c (delete_deletable_window): Now returns void, since it
3603 wasn't returning anything.
3604 (compare_window_configurations): Remove unused locals.
3605 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3606 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
3607 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3608 the same widths as pointers. This follows up on the 2011-05-06 patch.
3609 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3610 * xterm.h: Likewise.
3611 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3612
1384b89e
JB
36132011-06-12 Juanma Barranquero <lekktu@gmail.com>
3614
3615 * makefile.w32-in: Update dependencies.
3616 (LISP_H): Add lib/intprops.h.
3617
1100a63c
CY
36182011-06-11 Chong Yidong <cyd@stupidchicken.com>
3619
3620 * image.c (gif_load): Add animation frame delay to the metadata.
3621 (syms_of_image): Use DEFSYM. New symbol `delay'.
3622
6198ccd0
MR
36232011-06-11 Martin Rudalics <rudalics@gmx.at>
3624
3625 * window.c (delete_deletable_window): Re-add.
3626 (Fset_window_configuration): Rewrite to handle dead buffers and
3627 consequently deletable windows.
3628 (window_tree, Fwindow_tree): Remove. Supply functionality in
3629 window.el.
3630 (compare_window_configurations): Simplify code.
3631
b6e3633c
AS
36322011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3633
1ab0dee5
AS
3634 * image.c (imagemagick_load_image): Fix type mismatch.
3635 (Fimagemagick_types): Likewise.
3636
b6e3633c
AS
3637 * window.h (replace_buffer_in_windows): Declare.
3638
9397e56f
MR
36392011-06-11 Martin Rudalics <rudalics@gmx.at>
3640
3641 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3642 Qclone_number. Remove external declaration of Qdelete_window.
3643 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3644 code.
640c8776
SM
3645 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3646 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
3647 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3648 buffer list implementation.
3649 (other_buffer_safely): New function.
3650 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3651 calls to replace_buffer_in_windows and
3652 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3653 if allowed.
3654 (record_buffer): Inhibit quitting and rewrite using quittable
3655 functions. Run Qbuffer_list_update_hook if allowed.
3656 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
3657 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3658 Move switch-to-buffer to window.el.
9397e56f
MR
3659 (bury-buffer): Move to window.el.
3660 (Vbuffer_list_update_hook): New variable.
3661
3662 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3663 section.
3664
3665 * window.h (resize_frame_windows): Move up in code.
3666 (Fwindow_frame): Remove EXFUN.
3667 (replace_buffer_in_all_windows): Remove prototype.
3668 (replace_buffer_in_windows_safely): Add prototype.
3669
3670 * window.c: Declare Qdelete_window static again. Move down
3671 declaration of select_count.
3672 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3673 (Fother_window): Move to window.el.
3674 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3675 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3676 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3677 window.el.
3678 (replace_buffer_in_windows): Implement by calling
3679 Qreplace_buffer_in_windows.
3680 (replace_buffer_in_all_windows): Remove with some functionality
3681 moved into replace_buffer_in_windows_safely.
3682 (replace_buffer_in_windows_safely): New function.
3683 (select_window_norecord, select_frame_norecord): Move in front
3684 of run_window_configuration_change_hook. Remove now obsolete
3685 declarations.
640c8776
SM
3686 (Fset_window_buffer): Rewrite doc-string.
3687 Call Qrecord_window_buffer.
9397e56f
MR
3688 (keys_of_window): Move binding for other-window to window.el.
3689
b50691aa
CY
36902011-06-11 Chong Yidong <cyd@stupidchicken.com>
3691
3692 * dispextern.h (struct image): Replace data member, whose int_val
3693 and ptr_val fields were not used by anything, with a single
3694 lisp_val object.
3695
3696 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3697 (gif_clear_image, gif_load, imagemagick_load_image)
3698 (gs_clear_image, gs_load): Callers changed.
3699
3f754b86
PE
37002011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3701
cca69397
PE
3702 * buffer.h: Include <time.h>, for time_t.
3703 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3704
109e28d0
PE
3705 Fix minor problems found by static checking.
3706
60737f02
PE
3707 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3708
4b66faf3
PE
3709 Make identifiers static if they are not used in other modules.
3710 * data.c (Qcompiled_function, Qframe, Qvector):
3711 * image.c (QimageMagick, Qsvg):
3712 * minibuf.c (Qmetadata):
3713 * window.c (resize_window_check, resize_root_window): Now static.
3714 * window.h (resize_window_check, resize_root_window): Remove decls.
3715
109e28d0
PE
3716 * window.c (window_deletion_count, delete_deletable_window):
3717 Remove; unused.
46a4ce9e
PE
3718 (window_body_lines): Now static.
3719 (Fdelete_other_windows_internal): Mark vars as initialized.
3720 Make sure 'resize_failed' is initialized.
3721 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3722 (resize_window_apply): Remove unused local.
3723 * window.h (delete_deletable_window): Remove decl.
3724
109e28d0 3725 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
3726 (imagemagick_load_image): Fix pointer signedness problem by changing
3727 last arg from unsigned char * to char *. All uses changed.
3728 Also, fix a local for similar reasons.
3729 Remove unused locals. Remove locals to avoid shadowing.
3730 (fn_rsvg_handle_free): Remove; unused.
3731 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 3732 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 3733
3f754b86
PE
3734 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3735
2547adb1
CY
37362011-06-10 Chong Yidong <cyd@stupidchicken.com>
3737
3738 * image.c (gif_load): Fix omitted cast error introduced by
3739 2011-06-06 change.
3740
2c8e37d4
MR
37412011-06-10 Martin Rudalics <rudalics@gmx.at>
3742
3743 * window.h (resize_proportionally, orig_total_lines)
3744 (orig_top_line): Remove from window structure.
3745 (set_window_height, set_window_width, change_window_heights)
3746 (Fdelete_window): Remove prototypes.
3747 (resize_frame_windows): Remove duplicate declaration.
3748
440a42e3
EZ
37492011-06-10 Eli Zaretskii <eliz@gnu.org>
3750
3751 * window.h (resize_frame_windows, resize_window_check)
3752 (delete_deletable_window, resize_root_window)
3753 (resize_frame_windows): Declare prototypes.
3754
3755 * window.c (resize_window_apply): Make definition be "static" to
3756 match the prototype.
3757
562dd5e9
MR
37582011-06-10 Martin Rudalics <rudalics@gmx.at>
3759
3760 * window.c: Remove declarations of Qwindow_size_fixed,
3761 window_min_size_1, window_min_size_2, window_min_size,
3762 size_window, window_fixed_size_p, enlarge_window, delete_window.
3763 Remove static from declaration of Qdelete_window, it's
3764 temporarily needed by Fbury_buffer.
3765 (replace_window): Don't assign orig_top_line and
3766 orig_total_lines.
3767 (Fdelete_window, delete_window): Remove. Window deletion is
3768 handled by window.el.
640c8776
SM
3769 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3770 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
3771 (Fdelete_other_windows): Remove. Deleting other windows is
3772 handled by window.el.
3773 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3774 handled in window.el.
3775 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3776 Window minimum sizes are handled in window.el.
3777 (shrink_windows, size_window, set_window_height)
3778 (set_window_width, change_window_heights, window_height)
3779 (window_width, CURBEG, CURSIZE, enlarge_window)
3780 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3781 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3782 handled in window.el.
3783 (make_dummy_parent): Rename to make_parent_window and give it a
3784 second argument horflag.
3785 (make_window): Don't set resize_proportionally any more.
3786 (Fsplit_window): Remove. Windows are split in window.el.
3787 (save_restore_action, save_restore_orig_size)
3788 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3789 Resize mini windows in window.el.
3790 (grow_mini_window, shrink_mini_window): Implement by calling
3791 Qresize_root_window_vertically, resize_window_check and
3792 resize_window_apply.
640c8776
SM
3793 (saved_window, Fset_window_configuration, save_window_save):
3794 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
3795 resize_proportionally.
3796 (window_min_height, window_min_width): Move to window.el.
3797 (keys_of_window): Move bindings for delete-other-windows,
3798 split-window, delete-window and enlarge-window to window.el.
3799
3800 * buffer.c: Temporarily extern Qdelete_window.
3801 (Fbury_buffer): Temporarily call Qdelete_window instead of
3802 Fdelete_window (Fbury_buffer will move to window.el soon).
3803
3804 * frame.c (set_menu_bar_lines_1): Remove code handling
3805 orig_top_line and orig_total_lines.
3806
3807 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3808 set_window_height but set heights directly.
3809 (change_frame_size_1): Use resize_frame_windows.
3810
3811 * xdisp.c (init_xdisp): Don't use set_window_height but set
3812 heights directly.
3813
640c8776
SM
3814 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3815 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
3816 run_window_configuration_change_hook.
3817
3818 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3819 instead of change_window_heights and run
3820 run_window_configuration_change_hook.
3821
1a13852e
MR
38222011-06-09 Martin Rudalics <rudalics@gmx.at>
3823
3824 * window.c (replace_window): Rename second argument REPLACEMENT to
3825 NEW. New third argument SETFLAG. Rewrite.
3826 (delete_window, make_dummy_parent): Call replace_window with
3827 third argument 1.
3828 (window_list_1): Move down in code.
3829 (run_window_configuration_change_hook): Move set_buffer part
3830 before select_frame_norecord part in order to unwind correctly.
3831 Rename count1 to count.
3832 (recombine_windows, delete_deletable_window, resize_root_window)
3833 (Fdelete_other_windows_internal)
3834 (Frun_window_configuration_change_hook, make_parent_window)
3835 (resize_window_check, resize_window_apply, Fresize_window_apply)
3836 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
3837 (Fdelete_window_internal, Fresize_mini_window_internal):
3838 New functions.
1a13852e
MR
3839 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3840
f3d1777e
MR
38412011-06-08 Martin Rudalics <rudalics@gmx.at>
3842
496e208e
MR
3843 * window.h (window): Add some new members to window structure -
3844 normal_lines, normal_cols, new_total, new_normal, clone_number,
3845 splits, nest, prev_buffers, next_buffers.
3846 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 3847 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 3848
f3d1777e
MR
3849 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3850 Remove.
496e208e
MR
3851 (make_dummy_parent): Set new members of windows structure.
3852 (make_window): Move down in code. Handle new members of window
3853 structure.
3854 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3855 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3856 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3857 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
3858 (Fset_window_next_buffers, Fset_window_clone_number):
3859 New functions.
496e208e
MR
3860 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3861 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3862 Doc-string fixes.
3863 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3864 Argument WINDOW can be now internal window too.
3865 (Fwindow_use_time): Move up in code.
3866 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3867 Rewrite doc-string.
3868 (Fset_window_configuration, saved_window)
3869 (Fcurrent_window_configuration, save_window_save): Handle new
3870 members of window structure.
b9e809c2
MR
3871 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3872 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3873 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3874 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3875 Qget_mru_window, Qresize_root_window,
3876 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3877 Qauto_buffer_name; staticpro them.
f3d1777e 3878
abde8f8c
MR
38792011-06-07 Martin Rudalics <rudalics@gmx.at>
3880
3881 * window.c (Fwindow_total_size, Fwindow_left_column)
3882 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3883 (Fwindow_list_1): New functions.
3884 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
3885 (Fwindow_width, Fscroll_left, Fscroll_right):
3886 Use window_body_cols instead of window_box_text_cols.
3887 (delete_window, Fset_window_configuration):
3888 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
3889 (delete_all_subwindows): Take a window as argument and not a
3890 structure. Rewrite.
190b47e6
MR
3891 (window_loop): Remove handling of GET_LRU_WINDOW and
3892 GET_LARGEST_WINDOW.
3893 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
3894
3895 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
3896 window_box_text_cols. delete_all_subwindows now takes a
3897 Lisp_Object as argument.
abde8f8c 3898
640c8776
SM
3899 * indent.c (compute_motion, Fcompute_motion):
3900 Use window_body_cols instead of window_box_text_cols.
abde8f8c 3901
fa8a67e6
MR
3902 * frame.c (delete_frame): Call delete_all_subwindows with root
3903 window as argument.
3904
a54e3482
DC
39052011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3906
3907 * fns.c (Fputhash): Document return value.
3908
60002bf5
CY
39092011-06-06 Chong Yidong <cyd@stupidchicken.com>
3910
3911 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3912
0c671da6 39132011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 3914
b862a52a 3915 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 3916
be44ca6c
PE
3917 Check for overflow when converting integer to cons and back.
3918 * charset.c (Fdefine_charset_internal, Fdecode_char):
3919 Use cons_to_unsigned to catch overflow.
3920 (Fencode_char): Use INTEGER_TO_CONS.
3921 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3922 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3923 * data.c (long_to_cons, cons_to_long): Remove.
3924 (cons_to_unsigned, cons_to_signed): New functions.
3925 These signal an error for invalid or out-of-range values.
3926 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3927 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3928 * font.c (Ffont_variation_glyphs):
3929 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3930 * lisp.h: Include <intprops.h>.
3931 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3932 (cons_to_signed, cons_to_unsigned): New decls.
3933 (long_to_cons, cons_to_long): Remove decls.
3934 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3935 (Fprimitive_undo): Use CONS_TO_INTEGER.
3936 * xfns.c (Fx_window_property): Likewise.
3937 * xselect.c: Include <limits.h>.
3938 (x_own_selection, selection_data_to_lisp_data):
3939 Use INTEGER_TO_CONS.
3940 (x_handle_selection_request, x_handle_selection_clear)
3941 (x_get_foreign_selection, Fx_disown_selection_internal)
3942 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3943 (lisp_data_to_selection_data): Use cons_to_unsigned.
3944 (x_fill_property_data): Use cons_to_signed.
3945 Report values out of range.
3946
d1f3d2af
PE
3947 Check for buffer and string overflow more precisely.
3948 * buffer.h (BUF_BYTES_MAX): New macro.
3949 * lisp.h (STRING_BYTES_MAX): New macro.
3950 * alloc.c (Fmake_string):
3951 * character.c (string_escape_byte8):
3952 * coding.c (coding_alloc_by_realloc):
3953 * doprnt.c (doprnt):
3954 * editfns.c (Fformat):
3955 * eval.c (verror):
3956 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3957 since they may not be the same number.
3958 * editfns.c (Finsert_char):
3959 * fileio.c (Finsert_file_contents):
3960 Likewise for BUF_BYTES_MAX.
3961
dd52fcea
PE
3962 * image.c: Use ptrdiff_t, not int, for sizes.
3963 (slurp_file): Switch from int to ptrdiff_t.
3964 All uses changed.
3965 (slurp_file): Check that file size fits in both size_t (for
3966 malloc) and ptrdiff_t (for sanity and safety).
3967
7f9bbdbb
PE
3968 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3969 if b->modtime has its maximal value.
3970
dfe18f82
PE
3971 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3972
84acfcf0
PE
3973 Don't assume time_t can fit into int.
3974 * buffer.h (struct buffer.modtime): Now time_t, not int.
3975 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3976 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3977
ccd9a01a
PE
3978 Minor fixes for signed vs unsigned integers.
3979 * character.h (MAYBE_UNIFY_CHAR):
3980 * charset.c (maybe_unify_char):
3981 * keyboard.c (read_char, reorder_modifiers):
3982 XINT -> XFASTINT, since the integer must be nonnegative.
3983 * ftfont.c (ftfont_spec_pattern):
3984 * keymap.c (access_keymap, silly_event_symbol_error):
3985 XUINT -> XFASTINT, since the integer must be nonnegative.
3986 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3987 since it makes no difference and we prefer signed.
3988 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3989 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3990 nonnegative.
3991
d6d100dd
SM
39922011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3993
3994 * window.h (Fwindow_frame): Declare.
3995
2b6148e4
PE
39962011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3997
3998 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3999 (SPARE_MEMORY): Always define.
4000 (LARGE_REQUEST): Remove.
4001 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4002
f230ecc9
MR
40032011-06-06 Martin Rudalics <rudalics@gmx.at>
4004
727e958e
MR
4005 * lisp.h: Move EXFUNS for Fframe_root_window,
4006 Fframe_first_window and Fset_frame_selected_window to window.h.
4007
4008 * window.h: Move EXFUNS for Fframe_root_window,
4009 Fframe_first_window and Fset_frame_selected_window here from
4010 lisp.h.
4011
4012 * frame.c (Fwindow_frame, Fframe_first_window)
4013 (Fframe_root_window, Fframe_selected_window)
4014 (Fset_frame_selected_window): Move to window.c.
4015 (Factive_minibuffer_window): Move to minibuf.c.
4016 (Fother_visible_frames_p): New function.
4017
4018 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4019
f230ecc9
MR
4020 * window.c (decode_window, decode_any_window): Move up in code.
4021 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4022 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
4023 (Fwindow_buffer): Move up and rewrite doc-string.
4024 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4025 (Fwindow_prev): New functions.
727e958e
MR
4026 (Fwindow_frame): Move here from frame.c. Accept any window as
4027 argument.
4028 (Fframe_root_window, Fframe_first_window)
4029 (Fframe_selected_window): Move here from frame.c. Accept frame
4030 or arbitrary window as argument. Update doc-strings.
4031 (Fminibuffer_window): Move up in code.
4032 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
4033 (Fset_frame_selected_window): Move here from frame.c.
4034 Marginal rewrite.
727e958e
MR
4035 (Fselected_window, select_window, Fselect_window): Move up in
4036 code. Minor doc-string fixes.
f230ecc9 4037
4d09bcf6
PE
40382011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4039
4040 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4041 Do not assume that spare memory exists; that assumption is valid
4042 only if SYSTEM_MALLOC.
4043 (LARGE_REQUEST): New macro, so that the issue of large requests
4044 is separated from the issue of spare memory.
4045
810928a2
AS
40462011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4047
172418ad
AS
4048 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4049 format. (Bug#8806)
4050
43f862f7
AS
4051 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4052
810928a2
AS
4053 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4054 before statements.
4055
a059fe24
JD
40562011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4057
4058 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4059
4060 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4061
4062 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4063 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4064
989bf368
JB
40652011-06-05 Juanma Barranquero <lekktu@gmail.com>
4066
4067 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4068
4b80f674
CY
40692011-06-04 Chong Yidong <cyd@stupidchicken.com>
4070
4071 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4072 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
4073 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4074 New error handlers.
4b80f674
CY
4075 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4076 Obey Vx_select_enable_clipboard_manager. Catch errors in
4077 x_clipboard_manager_save (Bug#8779).
4078 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 4079 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 4080
99a33b77 40812011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
4082
4083 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4084
99a33b77 40852011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
4086
4087 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4088 in the current matrix if keep_current_p is non-zero.
4089
8264569d
EZ
40902011-06-04 Eli Zaretskii <eliz@gnu.org>
4091
4092 * bidi.c (bidi_level_of_next_char): Fix last change.
4093
57f97249
EZ
40942011-06-03 Eli Zaretskii <eliz@gnu.org>
4095
fec2107c 4096 Support bidi reordering of text covered by display properties.
57f97249 4097
fec2107c
EZ
4098 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4099 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4100 (bidi_cache_search, bidi_cache_iterator_state)
4101 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
4102 (bidi_level_of_next_char, bidi_move_to_visually_next):
4103 Support character positions inside a run of characters covered by a
fec2107c
EZ
4104 display string.
4105 (bidi_paragraph_init, bidi_resolve_explicit_1)
4106 (bidi_level_of_next_char): Call bidi_fetch_char and
4107 bidi_fetch_char_advance instead of FETCH_CHAR and
4108 FETCH_CHAR_ADVANCE.
4109 (bidi_init_it): Initialize new members.
4110 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4111 definitions.
4112 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4113 instead of using explicit *_CHAR codes.
d6d100dd
SM
4114 (bidi_resolve_explicit, bidi_resolve_weak):
4115 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
4116 bidirectional text is supported only in multibyte buffers.
4117 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4118 it to initialize the frame_window_p member of struct bidi_it.
4119 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4120 (bidi_resolve_explicit, bidi_resolve_weak)
4121 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4122 bidi_it->nchars is non-positive.
4123 (bidi_level_of_next_char): Don't try to lookup the cache for the
4124 next/previous character if nothing is cached there yet, or if we
4125 were just reseat()'ed to a new position.
c40e2fb2 4126
0e14fe90
EZ
4127 * xdisp.c (set_cursor_from_row): Set start and stop points
4128 according to the row's direction when priming the loop that looks
4129 for the glyph on which to display cursor.
4130 (single_display_spec_intangible_p): Function deleted.
4131 (display_prop_intangible_p): Reimplement to call
4132 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
4133 Accept 3 additional arguments needed by handle_display_spec.
4134 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
4135 values: lists, `(when COND...)' forms, etc.
4136 (single_display_spec_string_p): Support property values that are
4137 lists with the argument STRING its top-level element.
4138 (display_prop_string_p): Fix the condition for processing a
4139 property that is a list to be consistent with handle_display_spec.
fec2107c 4140 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
4141 last portion of handle_display_prop.
4142 (compute_display_string_pos): Accept additional argument
4143 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4144 value of a `display' property is a "replacing spec".
4145 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4146 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4147 the display property, but just return a value indicating whether
4148 the display property will replace the characters it covers.
4149 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4150 frame_window_p members of struct bidi_it.
d6d100dd
SM
4151 (compute_display_string_pos, compute_display_string_end):
4152 New functions.
fec2107c
EZ
4153 (push_it): Accept second argument POSITION, where pop_it should
4154 jump to continue iteration.
4155 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 4156
fec2107c
EZ
4157 * keyboard.c (adjust_point_for_property): Adjust the call to
4158 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
4159
4160 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
4161 (bidi_init_it): Update prototypes.
4162 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
4163 (compute_display_string_pos, compute_display_string_end):
4164 Declare prototypes.
fec2107c
EZ
4165 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4166 EMACS_INT.
fc6f18ce 4167
40087514 41682011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 4169
57f53182
PE
4170 Malloc failure behavior now depends on size of allocation.
4171 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4172 * lisp.h: Change signatures accordingly.
4173 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4174 All callers changed. (Bug#8762)
4175
4176 * gnutls.c: Use Emacs's memory allocators.
4177 Without this change, the gnutls library would invoke malloc etc.
4178 directly, which causes problems on non-SYNC_INPUT hosts, and which
4179 runs afoul of improving memory_full behavior. (Bug#8761)
4180 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4181 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4182 xfree instead of the default malloc, realloc, free.
4183 (Fgnutls_boot): No need to check for memory allocation failure,
4184 since xmalloc does that for us.
4185
ac32cd99 4186 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
4187 * category.c (hash_get_category_set):
4188 * ccl.c (ccl_driver):
4189 * charset.c (Fdefine_charset_internal):
4190 * charset.h (struct charset.hash_index):
4191 * composite.c (get_composition_id, gstring_lookup_cache)
4192 (composition_gstring_put_cache):
4193 * composite.h (struct composition.hash_index):
4194 * dispextern.h (struct image.hash):
4195 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4196 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4197 (hashfn_equal, hashfn_user_defined, make_hash_table)
4198 (maybe_resize_hash_table, hash_lookup, hash_put)
4199 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4200 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4201 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4202 * image.c (make_image, search_image_cache, lookup_image)
4203 (xpm_put_color_table_h):
4204 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 4205 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 4206 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 4207 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
4208 * alloc.c (allocate_vectorlike):
4209 Check for overflow in vector size calculations.
4210 * ccl.c (ccl_driver):
4211 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
4212 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4213 need to be updated by these changes.
40087514
PE
4214 * fns.c (make_hash_table, maybe_resize_hash_table):
4215 Check for integer overflow with large hash tables.
0de4bb68
PE
4216 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4217 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4218 (SXHASH_REDUCE): New macro.
4219 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4220 Use it instead of discarding useful hash info with large hash values.
4221 (sxhash_float): New function.
4222 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4223 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
4224 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4225 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
4226 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4227 Adjust signatures to match updated version of code.
4228 (consing_since_gc): Now EMACS_INT, since a single hash table can
4229 use more than INT_MAX bytes.
4230
698d32e2
DN
42312011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4232
4233 Make it possible to build with GCC-4.6+ -O2 -flto.
4234
4235 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4236
fd6fa53f
SM
42372011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4238
4239 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4240 Call minibuffer-inactive-mode.
4241
864db017
JB
42422011-05-31 Juanma Barranquero <lekktu@gmail.com>
4243
4244 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4245 Update dependencies.
4246
2ad0baf4
DN
42472011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4248
4249 * data.c (init_data): Remove code for UTS, this system is not
4250 supported anymore.
4251
4fcc2638
DN
42522011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4253
4254 Don't force ./temacs to start in terminal mode.
4255
4256 * frame.c (make_initial_frame): Initialize faces in all cases, not
4257 only when CANNOT_DUMP is defined.
4258 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4259
c56e0fd5
DN
42602011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4261
4262 * dispnew.c (add_window_display_history): Use const for the string
4263 pointer. Remove declaration, not needed.
4264
333d54da 42652011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 4266
55d4c1b2 4267 Use 'inline', not 'INLINE'.
333d54da 4268 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
4269 * alloc.c, fontset.c (INLINE): Remove.
4270 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4271 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4272 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4273 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4274 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4275
738db178
DN
42762011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4277
4278 Make it possible to run ./temacs.
4279
4280 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4281 syms_of_callproc does the same thing. Remove test for
4282 "initialized", do it in the caller.
4283 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4284
620c53a6
SM
42852011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4286
4287 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4288 (read_minibuf): Use get_minibuffer.
4289 (syms_of_minibuf): Use DEFSYM.
4290 (Qmetadata): New var.
4291 * data.c (Qbuffer): Don't make it static.
4292 (syms_of_data): Use DEFSYM.
4293
e003a292
PE
42942011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4295
4296 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4297 (CCL_CODE_MIN): New macro.
4298
ed008a6d
PE
42992011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4300
3687c2ef
PE
4301 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4302
ed008a6d
PE
4303 * eval.c (Qdebug): Now static.
4304 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4305 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4306 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4307
d66c4c7c
CY
43082011-05-29 Chong Yidong <cyd@stupidchicken.com>
4309
4310 * image.c: Various fixes to ImageMagick code comments.
4311 (Fimagemagick_types): Doc fix.
4312
5fbc2025
PE
43132011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4314
0196f88a
PE
4315 Minor fixes prompted by GCC 4.6.0 warnings.
4316
4317 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4318
5fbc2025
PE
4319 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4320 (x_clipboard_manager_save_all): Move extern decl to ...
4321 * xterm.h: ... here, so that it can be checked for consistency.
4322
1dd3c2d9
CY
43232011-05-29 Chong Yidong <cyd@stupidchicken.com>
4324
4325 * xselect.c (x_clipboard_manager_save_frame)
4326 (x_clipboard_manager_save_all): New functions.
4327 (Fx_clipboard_manager_save): Lisp function deleted.
4328
4329 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4330 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4331
4332 * xterm.h: Update prototype.
4333
5ba6571d
WX
43342011-05-28 William Xu <william.xwl@gmail.com>
4335
4336 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4337 exiting (Bug#8239).
4338
3eaff834
JM
43392011-05-28 Jim Meyering <meyering@redhat.com>
4340
e1900994 4341 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
4342 * fns.c (to_uchar): Define.
4343 (crypto_hash_function): Use it to convert some newly-signed
4344 variables to unsigned, to avoid sign-extension bugs. For example,
4345 without this change, (md5 "truc") would evaluate to
4346 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4347 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 4348 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 4349
0f6990a7
PE
43502011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4351
4352 Integer overflow fixes.
c8a9ca5a 4353
08686060
PE
4354 * dbusbind.c: Serial number integer overflow fixes.
4355 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
4356 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4357 to hold a serial number that is too large for a fixnum.
4358 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4359 Check for serial numbers out of range. Decode any serial number
59568bf0 4360 that was so large that it became a float. (Bug#8722)
08686060 4361
2d1fc3c7
PE
4362 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4363 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4364 Use XFASTINT rather than XUINT when numbers are nonnegative.
4365 (xd_append_arg, Fdbus_method_return_internal):
4366 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4367 arguments, check that Lisp number is nonnegative, rather than
59568bf0 4368 silently wrapping negative numbers around. (Bug#8722)
30217ff0 4369 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 4370 (Bug#8722)
2d1fc3c7 4371
c8a9ca5a
PE
4372 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4373
519e1d69
PE
4374 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4375
30569699
PE
4376 ccl: add integer overflow checks
4377 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4378 (IN_INT_RANGE): New macros.
4379 (ccl_driver): Use them to check for integer overflow when
4380 decoding a CCL program. Many of the new checks are whether XINT (x)
4381 fits in int; it doesn't always, on 64-bit hosts. The new version
4382 doesn't catch all possible integer overflows, but it's an
847044ea 4383 improvement. (Bug#8719)
30569699 4384
c11285dc
PE
4385 * alloc.c (make_event_array): Use XINT, not XUINT.
4386 There's no need for unsigned here.
4387
fdccd48e
PE
4388 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4389 This follows up to the 2011-05-06 change that substituted uintptr_t
4390 for EMACS_INT. This case wasn't caught back then.
4391
37910ab2
PE
4392 Rework Fformat to avoid integer overflow issues.
4393 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4394 now (part of C89). Include <verify.h>.
4395 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4396 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4397 (Fformat): Avoid the prepass trying to compute sizes; it was only
4398 approximate and thus did not catch overflow reliably. Instead, walk
4399 through the format just once, formatting and computing sizes as we go,
4400 checking for integer overflow at every step, and allocating a larger
4401 buffer as needed. Keep track separately whether the format is
4402 multibyte. Keep only the most-recently calculated precision, rather
4403 than them all. Record whether each argument has been converted to
4404 string. Use EMACS_INT, not int, for byte and char and arg counts.
4405 Support field widths and precisions larger than INT_MAX. Avoid
4406 sprintf's undefined behavior with conversion specifications such as %#d
4407 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4408 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4409 formatting out-of-range floating point numbers with int
9173deec 4410 formats. (Bug#8668)
37910ab2 4411
2e6578fb
PE
4412 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4413
0ae6bdee
PE
4414 * data.c: Avoid integer truncation in expressions involving floats.
4415 * data.c: Include <intprops.h>.
4416 (arith_driver): When there's an integer overflow in an expression
4417 involving floating point, convert the integers to floating point
4418 so that the resulting value does not suffer from catastrophic
4419 integer truncation. For example, on a 64-bit host (* 4
4420 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4421 Do not rely on undefined behavior after integer overflow.
4422
de883a70
PE
4423 merge count_size_as_multibyte, parse_str_to_multibyte
4424 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 4425 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
4426 Check for integer overflow.
4427 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4428 since it's now a duplicate of the other. This is more of
4429 a character than a buffer op, so better that it's in character.c.
4430 * fns.c, print.c: Adjust to above changes.
4431
2ff916cb
PE
44322011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4433
4434 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4435
f1b54466
PE
44362011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4437
fb1ac845
PE
4438 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4439 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4440 (x_clipboard_manager_save): Now static.
4441 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4442
f1b54466
PE
4443 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4444 (crypto_hash_function): Now static.
4445 Fix pointer signedness problems. Avoid unnecessary initializations.
4446
a9f737ee
CY
44472011-05-27 Chong Yidong <cyd@stupidchicken.com>
4448
4449 * termhooks.h (Vselection_alist): Make it terminal-local.
4450
4451 * terminal.c (create_terminal): Initialize it.
4452
4453 * xselect.c: Support for clipboard managers.
4454 (Vselection_alist): Move to termhooks.h as terminal-local var.
4455 (LOCAL_SELECTION): New macro.
4456 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4457 (symbol_to_x_atom): Remove gratuitous arg.
4458 (x_handle_selection_request, lisp_data_to_selection_data)
4459 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
4460 (x_own_selection, x_get_local_selection, x_convert_selection):
4461 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
4462 (some_frame_on_display): Delete unused function.
4463 (Fx_own_selection_internal, Fx_get_selection_internal)
4464 (Fx_disown_selection_internal, Fx_selection_owner_p)
4465 (Fx_selection_exists_p): New optional frame arg.
4466 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4467 (x_handle_selection_clear): Don't treat other terminals with the
4468 same keyboard specially. Use the terminal-local Vselection_alist.
4469 (x_clear_frame_selections): Use Frun_hook_with_args.
4470
4471 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4472
4473 * xterm.h: Add support for those atoms.
4474
e067f0c1
CY
44752011-05-26 Chong Yidong <cyd@stupidchicken.com>
4476
4477 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4478 (converted_selections, conversion_fail_tag): New global variables.
4479 (x_selection_request_lisp_error): Free the above.
4480 (x_get_local_selection): Remove unnecessary code.
4481 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
4482 of converted selections stored in converted_selections.
4483 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
4484 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4485 (x_convert_selection): New function.
4486 (x_handle_selection_event): Simplify.
4487 (x_get_foreign_selection): Don't ignore incoming requests while
4488 waiting for an answer; this will fail when we implement
4489 SAVE_TARGETS, and seems unnecessary anyway.
4490 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4491 (Vx_sent_selection_functions): Doc fix.
4492
0f4aebc0
LL
44932011-05-26 Leo Liu <sdl.web@gmail.com>
4494
4495 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4496
e61124cd
YM
44972011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4498
4499 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4500
4501 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4502 for fringe update if it has periodic bitmap.
ac389d0c 4503 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
4504 and fringe_bitmap_periodic_p.
4505
4506 * fringe.c (get_fringe_bitmap_data): New function.
4507 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4508 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4509 row. Mark glyph row for fringe update if periodicity changed.
4510
4511 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4512 for fringe update unless it has periodic bitmap.
4513
f16d9837
KH
45142011-05-25 Kenichi Handa <handa@m17n.org>
4515
4516 * xdisp.c (get_next_display_element): Set correct it->face_id for
4517 a static composition.
4518
e1b90ef6
LL
45192011-05-24 Leo Liu <sdl.web@gmail.com>
4520
4521 * deps.mk (fns.o):
4522 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4523
4524 * fns.c (crypto_hash_function, Fsha1): New function.
4525 (Fmd5): Use crypto_hash_function.
4526 (syms_of_fns): Add Ssha1.
4527
7400048f
PE
45282011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4529
4530 * gnutls.c: Remove unused macros.
4531 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4532 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4533 Remove macros that are defined and never used.
4534 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4535
abb71cf4
CY
45362011-05-22 Chong Yidong <cyd@stupidchicken.com>
4537
4538 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4539 (Fx_get_selection_internal): Minor cleanup.
4540 (Fx_own_selection_internal): Rename arguments for consistency with
4541 select.el.
4542
6307db39
PE
45432011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4544
4545 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4546
f3d4e0a4
CY
45472011-05-22 Chong Yidong <cyd@stupidchicken.com>
4548
4549 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4550
4d8ade89
YM
45512011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4552
4553 * dispnew.c (scrolling_window): Don't exclude the case that the
4554 last enabled row in the desired matrix touches the bottom boundary.
4555
32078c8d
GM
45562011-05-21 Glenn Morris <rgm@gnu.org>
4557
4558 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
4559 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4560 and add some more files.
32078c8d 4561
7285dc67
EZ
45622011-05-20 Eli Zaretskii <eliz@gnu.org>
4563
4564 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4565 report_file_error introduced by the change from 2011-05-07.
4566
89d1bd22
PE
45672011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4568
4569 * systime.h (Time): Define only if emacs is defined.
4570 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4571 where the include path doesn't have X11/X.h by default. See
4572 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4573
e23640bb 45742011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
4575
4576 * composite.c (find_automatic_composition): Fix previous change.
4577
b9704ad9
GM
45782011-05-20 Glenn Morris <rgm@gnu.org>
4579
4580 * lisp.mk: New file, split from Makefile.in.
4581 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4582 (shortlisp): Remove.
4583 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4584
4a720484
GM
45852011-05-19 Glenn Morris <rgm@gnu.org>
4586
4587 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4588 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4589 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4590 (lisp): Set the order to that of loadup.el.
4591 (shortlisp): Make it a copy of $lisp.
4592 (SOME_MACHINE_LISP): Remove.
4593 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4594 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4595
a28d4396
KH
45962011-05-18 Kenichi Handa <handa@m17n.org>
4597
4598 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4599 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4600 (find_automatic_composition): Mostly rewrite for efficiency.
4601
a2b1fa8e
JB
46022011-05-18 Juanma Barranquero <lekktu@gmail.com>
4603
4604 * makefile.w32-in: Update dependencies.
4605
8e1f5610
CS
46062011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4607
4608 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 4609 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 4610
7025ee00 46112011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 4612
cdfa6eab
PE
4613 Fix some integer overflow issues, such as string length overflow.
4614
06d6db33
PE
4615 * insdel.c (count_size_as_multibyte): Check for string overflow.
4616
2b4560a8
PE
4617 * character.c (lisp_string_width): Check for string overflow.
4618 Use EMACS_INT, not int, for string indexes and lengths; in
4619 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4620 the resulting string length overflows an EMACS_INT; instead,
4621 report a string overflow if no precision given. When checking for
4622 precision exhaustion, use a check that cannot possibly have
4623 integer overflow. (Bug#8675)
4624 * character.h (lisp_string_width): Adjust to new signature.
4625
cb93f9be
PE
4626 * alloc.c (string_overflow): New function.
4627 (Fmake_string): Use it. This doesn't change behavior, but saves
4628 a few bytes and will simplify future changes.
4629 * character.c (string_escape_byte8): Likewise.
4630 * lisp.h (string_overflow): New decl.
4631
1a1f3366
PE
4632 Fixups, following up to the user-interface timestamp change.
4633 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4634 for UI timestamps, instead of unsigned long.
9fbd6841
PE
4635 * msdos.c (mouse_get_pos): Likewise.
4636 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
4637 * w32gui.h (Time): Define by including "systime.h" rather than by
4638 declaring it ourselves. (Bug#8664)
4639
d4e3e4d3
PE
4640 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4641 * image.c (clear_image_cache): Likewise.
4642
f6a24d19
PE
4643 * term.c (term_mouse_position): Don't assume time_t wraparound.
4644
08dc5ae6
PE
4645 Be more systematic about user-interface timestamps.
4646 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
4647 and sometimes 'EMACS_UINT', to represent these timestamps.
4648 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
4649 This makes the code easier to follow, and makes it easier to catch
4650 integer overflow bugs such as Bug#8664.
4651 * frame.c (Fmouse_position, Fmouse_pixel_position):
4652 Use Time, not unsigned long, for user-interface timestamps.
4653 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4654 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4655 * keyboard.h (last_event_timestamp): Likewise.
4656 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4657 * menu.h (xmenu_show): Likewise.
4658 * term.c (term_mouse_position): Likewise.
4659 * termhooks.h (struct input_event.timestamp): Likewise.
4660 (struct terminal.mouse_position_hook): Likewise.
4661 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4662 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4663 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4664 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4665 what it was before.
4666 * menu.h, termhooks.h: Include "systime.h", for Time.
4667
8e55734a
PE
4668 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4669 Don't assume that the difference between two unsigned long values
4670 can fit into an integer. At this point, we know button_down_time
4671 <= event->timestamp, so the difference must be nonnegative, so
4672 there's no need to cast the result if double-click-time is
4673 nonnegative, as it should be; check that it's nonnegative, just in
4674 case. This bug is triggered when events are more than 2**31 ms
86db42d2 4675 apart (about 25 days). (Bug#8664)
8e55734a 4676
841f1b75 4677 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 4678 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 4679
3e26f69c
PE
4680 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4681 that always fit in int. Use a sentinel instead of a counter, to
4682 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
4683 * frame.h (struct frame): Use int for menu_bar_items_used
4684 instead of EMACS_INT, since it always fits in int.
3e26f69c 4685
5cc152c0
PE
4686 * menu.c (grow_menu_items): Check for int overflow.
4687
d89eb65e
PE
4688 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4689
5235bd3e
PE
4690 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4691 Before, the code was not consistent. These values cannot exceed
4692 2**31 - 1 so there's no need to make them unsigned.
4693 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4694 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4695 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4696 as modifiers.
4697 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4698
bc827e23
PE
4699 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4700 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4701 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4702 presumably because the widths might not match.
4703
78eb494e
PE
4704 * window.c (size_window): Avoid needless test at loop start.
4705
04f2d78b
CB
47062011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4707
4708 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4709
d2fc7e3d 47102011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
4711
4712 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4713
d2fc7e3d 47142011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
4715
4716 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4717 `width' to `bar_area_x' and `bar_area_width', respectively.
4718 (x_scroll_run): Take account of fringe background extension.
4719
04f2d78b
CB
4720 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4721 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
4722 `bar_area_width', respectively.
4723 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4724 background extension.
4725
79b70037
GM
47262011-05-10 Jim Meyering <meyering@redhat.com>
4727
4728 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4729
2f142cc5
JB
47302011-05-10 Juanma Barranquero <lekktu@gmail.com>
4731
4732 * image.c (Finit_image_library): Return t for built-in image types,
4733 like pbm and xbm. (Bug#8640)
4734
57679c86
AS
47352011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4736
4737 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4738
888c9e86
EZ
47392011-05-07 Eli Zaretskii <eliz@gnu.org>
4740
b0512a1d
EZ
4741 * w32console.c (Fset_screen_color): Doc fix.
4742 (Fget_screen_color): New function.
4743 (syms_of_ntterm): Defsubr it.
4744
7285dc67
EZ
4745 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4746 unlink the temporary file if Fcall_process didn't create it in the
4747 first place.
4748 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4749 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
4750 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4751 cue to call_process_cleanup not to close that handle.
4752
4d3fcc8e
BK
47532011-05-07 Ben Key <bkey76@gmail.com>
4754
4755 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4756 one of two shell specific rules, either bootstrap-temacs-CMD or
4757 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4758 to the previous implementation of the bootstrap-temacs rule.
4759 The bootstrap-temacs-CMD rule is similar to the previous
4760 implementation of the bootstrap-temacs rule except that it
4761 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4762 variable.
4763
4764 These changes, along with some changes to nt/configure.bat,
4765 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4766 earlier fix to add support for --cflags and --ldflags options
4767 that include quotes so that it works whether make uses cmd or
4768 sh as the shell.
4769
b4289b64
MA
47702011-05-06 Michael Albinus <michael.albinus@gmx.de>
4771
4772 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4773 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4774 is a constant.
4775 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4776 a string. Handle both cases.
4777 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4778 (Fdbus_register_method): Use Qinvalid_function.
4779
af4c0e28
JB
47802011-05-06 Juanma Barranquero <lekktu@gmail.com>
4781
4782 * makefile.w32-in: Update dependencies.
4783 (LISP_H): Add inttypes.h and stdin.h.
4784 (PROCESS_H): Add unistd.h.
4785
c51453d9
EZ
47862011-05-06 Eli Zaretskii <eliz@gnu.org>
4787
4788 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4789 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4790
8ff0ac3c 47912011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 4792
4c4b566b
PE
4793 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4794
aab2b9b5
PE
4795 * term.c (vfatal): Remove stray call to va_end.
4796 It's not needed and the C Standard doesn't allow it here anyway.
4797
c378da0b
PE
4798 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4799 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4800
288b08c7
PE
4801 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4802 bytes.
4803
e3601888
PE
4804 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4805
db6c0e74
PE
4806 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4807
dd5963ea
PE
4808 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4809
88c9450f
PE
4810 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4811
2f9442b8
PE
4812 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4813
c032b5f8
PE
4814 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4815 * charset.c (Fdefine_charset_internal): Don't initialize
4816 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 4817 32-bit int (Bug#8600).
a108c10b
PE
4818
4819 * lread.c (read_integer): Be more consistent with string-to-number.
4820 Use string_to_number to do the actual conversion; this avoids
4821 rounding errors and fixes some other screwups. Without this fix,
4822 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4823 (digit_to_number): Move earlier, for benefit of read_integer.
4824 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 4825 not a digit in any supported base. (Bug#8602)
a108c10b 4826
ad5f9eea
PE
4827 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4828
aec1708a
PE
4829 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4830 to match comment at start of function. This also removes a
4831 GCC warning about overflow in a 32+64-bit port.
4832
47be4ab5
PE
4833 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4834
371cac43
PE
4835 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4836 Reported by Stefan Monnier in
4837 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
4838 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4839 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 4840
d01a7826
PE
4841 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4842 (EMACS_UINTPTR): Likewise, with uintptr_t.
4843
7fd47d5c
PE
4844 * lisp.h: Prefer 64-bit EMACS_INT if available.
4845 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4846 on 32-bit hosts that have 64-bit int, so that they can access
4847 large files.
122b0c86
PE
4848 However, temporarily disable this change unless the temporary
4849 symbol WIDE_EMACS_INT is defined.
7fd47d5c 4850
8727937b
PE
4851 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4852
8ac068ac
PE
4853 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4854 This removes an assumption that EMACS_INT and long are the same
4855 width as pointers. The assumption is true for Emacs porting targets
4856 now, but we want to make other targets possible.
4857 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4858 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4859 In the rest of the code, change types of integers that hold casted
4860 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4861 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4862 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4863 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4864 No need to cast type when ORing.
4865 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4866 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4867 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4868 assume EMACS_INT is the same width as char *.
4869 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4870 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4871 Remove no-longer-needed casts.
4872 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4873 (xg_tool_bar_help_callback, xg_make_tool_item):
4874 Use EMACS_INTPTR to hold an integer
4875 that will be cast to void *; this can avoid a GCC warning
4876 if EMACS_INT is not the same width as void *.
4877 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4878 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4879 (current_message_1, set_message_1):
4880 Use a local to convert to proper width without a cast.
4881 * xmenu.c (dialog_selection_callback): Likewise.
4882
ede49d71
PE
4883 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4884 Also, don't assume VALBITS / RAND_BITS is less than 5,
4885 and don't rely on undefined behavior when shifting a 1 left into
4886 the sign bit.
4887 * lisp.h (get_random): Change signature to match.
4888
2f30ecd0
PE
4889 * lread.c (hash_string): Use size_t, not int, for hash computation.
4890 Normally we prefer signed values; but hashing is special, because
4891 it's better to use unsigned division on hash table sizes so that
4892 the remainder is nonnegative. Also, size_t is the natural width
4893 for hashing into memory. The previous code used 'int', which doesn't
4894 retain enough info to hash well into very large tables.
4895 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4896
2a866e7b
PE
4897 * dbusbind.c: Don't possibly lose pointer info when converting.
4898 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4899 Use XPNTR rather than XHASH, so that the high-order bits of
4900 the pointer aren't lost when converting through void *.
4901
51639eac
PE
4902 * eval.c (Fautoload): Don't double-shift a pointer.
4903
92394119
PE
4904 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4905
dbdb9a7c
JB
49062011-05-06 Juanma Barranquero <lekktu@gmail.com>
4907
4908 * gnutls.c (DEF_GNUTLS_FN):
4909 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4910
db7a0b4f
AS
49112011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4912
4913 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4914 marker. (Bug#8610)
4915
f7ff1b0f 49162011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
4917
4918 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4919 New version that can reserve upto 2GB of heap space.
4920
f7ff1b0f 49212011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
4922
4923 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4924
639c109b
TZ
49252011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4926
4927 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4928 `gnutls_certificate_set_x509_key_file'.
4929
d2127135
JB
49302011-05-05 Juanma Barranquero <lekktu@gmail.com>
4931
4932 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4933 Update dependencies.
4934
e968f4f3
JB
49352011-05-04 Juanma Barranquero <lekktu@gmail.com>
4936
4937 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4938 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4939 Remove unused parameter `fildes'.
4940 * process.c (read_process_output, send_process): Don't pass it.
4941
84d358f0
JB
49422011-05-04 Juanma Barranquero <lekktu@gmail.com>
4943
4944 Fix previous change: the library cache is defined in w32.c.
4945 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4946 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4947
0898ca10
JB
49482011-05-04 Juanma Barranquero <lekktu@gmail.com>
4949
4950 Implement dynamic loading of GnuTLS on Windows.
4951
4952 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4953 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4954 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4955 Declare.
4956
4957 * gnutls.c (Qgnutls_dll): Define.
4958 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4959 (gnutls_*): Declare function pointers.
4960 (init_gnutls_functions): New function to initialize function pointers.
4961 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4962 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4963 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4964 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4965 (emacs_gnutls_write, emacs_gnutls_read)
4966 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4967 (Fgnutls_available_p): New function.
4968 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4969 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4970 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4971
4972 * image.c: Include w32.h.
4973 (Vimage_type_cache): Delete.
4974 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4975 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4976 (w32_delayed_load): Move to w32.c.
4977
4978 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4979
4980 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4981 (w32_delayed_load): Move from image.c. When loading a library, record
4982 its filename in the :loaded-from property of the library id.
4983 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4984 Initialize and staticpro them.
4985 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4986
4987 * process.c: Include lisp.h before w32.h, not after.
4988 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4989 instead of gnutls_record_check_pending.
4990
4991 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4992
ff4de4aa
TZ
49932011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4994
4995 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4996 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4997 as passed in.
4998
abe95abb
JD
49992011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5000
5001 * xterm.c (x_set_frame_alpha): Do not set property on anything
5002 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5003
e16e55d4
JB
50042011-05-02 Juanma Barranquero <lekktu@gmail.com>
5005
5006 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5007
bafcf6a5
JB
50082011-05-02 Juanma Barranquero <lekktu@gmail.com>
5009
5010 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5011 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5012 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5013 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5014 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5015 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5016 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5017 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5018 (Qgnutls_bootprop_callbacks_verify): Make static.
5019
e7a6747f
AS
50202011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5021
19ed11ba
AS
5022 * callproc.c: Indentation fixup.
5023
e7a6747f 5024 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
5025 (wait_for_termination, interruptible_wait_for_termination):
5026 Move after wait_for_termination_1.
e7a6747f 5027
1ef14cb4
LMI
50282011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5029
5030 * sysdep.c (interruptible_wait_for_termination): New function
5031 which is like wait_for_termination, but allows keyboard
5032 interruptions.
5033
5034 * callproc.c (Fcall_process): Add (:file "file") as an option for
5035 the STDOUT buffer.
5036 (Fcall_process_region): Ditto.
5037
330d880c
EZ
50382011-04-30 Eli Zaretskii <eliz@gnu.org>
5039
8db90b73
EZ
5040 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5041 rather than `XVECTOR (FOO)->size'.
5042
330d880c
EZ
5043 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5044 inttypes.h, as a gnulib replacement is used if it not available in
5045 system headers.
5046
15cbd324
EZ
50472011-04-21 Eli Zaretskii <eliz@gnu.org>
5048
5049 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5050 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5051 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5052
5053 * coding.c (coding_alloc_by_realloc): Error out if destination
5054 will grow beyond MOST_POSITIVE_FIXNUM.
5055 (decode_coding_emacs_mule): Abort if there isn't enough place in
5056 charbuf for the composition carryover bytes. Reserve an extra
5057 space for up to 2 characters produced in a loop.
5058 (decode_coding_iso_2022): Abort if there isn't enough place in
5059 charbuf for the composition carryover bytes.
5060
50612011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 5062
ae940cca
EZ
5063 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5064 aborting when %lld or %lll format is passed.
5065 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5066 %llo or %llx format is passed. (Bug#8545)
5067
03ab8921
EZ
5068 * window.c (window_scroll_line_based): Use a marker instead of
5069 simple variables to record original value of point. (Bug#7952)
5070
afda1437
EZ
5071 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5072 produced by %s or %c overflows available buffer space. (Bug#8545)
5073
f76dee0c
PE
50742011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5075
5076 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 5077 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 5078
fdc5744d
JB
50792011-04-28 Juanma Barranquero <lekktu@gmail.com>
5080
5081 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5082
638f053a
JB
50832011-04-28 Juanma Barranquero <lekktu@gmail.com>
5084
5085 * keyboard.c (Qdelayed_warnings_hook): Define.
5086 (command_loop_1): Run `delayed-warnings-hook'
5087 if Vdelayed_warnings_list is non-nil.
5088 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5089 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5090
d178f871
EZ
50912011-04-28 Eli Zaretskii <eliz@gnu.org>
5092
5093 * doprnt.c (doprnt): Don't return value smaller than the buffer
5094 size if the message was truncated. (Bug#8545).
5095
b124fd93
JB
50962011-04-28 Juanma Barranquero <lekktu@gmail.com>
5097
5098 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5099 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5100
e810457d
PE
51012011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5102
5103 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5104
ea51cceb
JB
51052011-04-27 Juanma Barranquero <lekktu@gmail.com>
5106
5107 * makefile.w32-in: Update dependencies.
5108
94dcfacf
EZ
51092011-04-27 Eli Zaretskii <eliz@gnu.org>
5110
5111 Improve `doprnt' and its usage. (Bug#8545)
5112 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5113 `format_end'. Remove support for %l as a conversion specifier.
5114 Don't use xrealloc. Improve diagnostics when the %l size modifier
5115 is used. Update the commentary.
5116
5117 * eval.c (verror): Simplify calculation of size_t.
5118
5119 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5120 messages.
5121
f61f41d7
PE
51222011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5123
5124 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5125 change.
5126
96fb4434
PE
51272011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5128
5129 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5130 This makes this file independent of the recent pseudovector change.
5131
671875da 51322011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 5133
69e9b5a3
PE
5134 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5135
b5f869a7 5136 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 5137 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 5138 Remove unused local.
c8926152 5139 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 5140
841a1577 5141 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
5142 GCC 4.6.0 optimizes based on type-based alias analysis.
5143 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
5144 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5145 != &v->size, and therefore "v->size = 1; b->size = 2; return
5146 v->size;" must therefore return 1. This assumption is incorrect
5147 for Emacs, since it type-puns struct Lisp_Vector * with many other
5148 types. To fix this problem, this patch adds a new type struct
f904488f 5149 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
5150 and pseudovectors, and helps optimizing compilers not get fooled
5151 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5152 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
5153 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5154 the size member.
eab3844f
PE
5155 (XSETPVECTYPE): Rewrite in terms of new macro.
5156 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5157 This is a bit clearer, and further avoids the possibility of
5158 undesirable aliasing.
5159 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 5160 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
5161 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5162 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
5163 (ASIZE): Now uses header.size rather than size.
5164 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
5165 to avoid the hassle of writing XVECTOR (foo)->header.size.
5166 (struct vectorlike_header): New type.
eab3844f
PE
5167 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5168 object, to help avoid aliasing.
5169 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5170 (SUBRP): Likewise, since Lisp_Subr is a special case.
5171 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5172 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5173 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 5174 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
5175 changed to be "header.size" and "header.next".
5176 * buffer.h (struct buffer): Likewise.
5177 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5178 * frame.h (struct frame): Likewise.
5179 * process.h (struct Lisp_Process): Likewise.
5180 * termhooks.h (struct terminal): Likewise.
5181 * window.c (struct save_window_data, struct saved_window): Likewise.
5182 * window.h (struct window): Likewise.
5183 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5184 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5185 * buffer.c (init_buffer_once): Likewise.
5186 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5187 special case.
5188 * process.c (Fformat_network_address): Use local var for size,
5189 for brevity.
5190
0df1eac5
PE
5191 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5192
847ab9d1 5193 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
5194 * data.c (atof): Remove decl; no longer used or needed.
5195 (digit_to_number): Move to lread.c.
5196 (Fstring_to_number): Use new string_to_number function, to be
5197 consistent with how the Lisp reader treats infinities and NaNs.
5198 Do not assume that floating-point numbers represent EMACS_INT
5199 without losing information; this is not true on most 64-bit hosts.
5200 Avoid double-rounding errors, by insisting on integers when
5201 parsing non-base-10 numbers, as the documentation specifies.
5202 * lisp.h (string_to_number): New decl, replacing ...
5203 (isfloat_string): Remove.
bc0a5c13 5204 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 5205 (read1): Do not accept +. and -. as integers; this
452f4150
PE
5206 appears to have been a coding error. Similarly, do not accept
5207 strings like +-1e0 as floating point numbers. Do not report
5208 overflow for integer overflows unless the base is not 10 which
5209 means we have no simple and reliable way to continue.
5210 Break out the floating-point parsing into a new
5211 function string_to_number, so that Fstring_to_number parses
5212 floating point numbers consistently with the Lisp reader.
04f2d78b 5213 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
5214 (E_CHAR, EXP_INT): Remove, replacing with ...
5215 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5216 (string_to_number): New function, replacing isfloat_string.
5217 This function checks for valid syntax and produces the resulting
5218 Lisp float number too. Rework it so that string-to-number
bc0a5c13 5219 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
5220 so that overflow for non-base-10 numbers is reported only when
5221 there's no portable and simple way to convert to floating point.
452f4150 5222
67769ffc
PE
5223 * textprop.c (set_text_properties_1): Rewrite for clarity,
5224 and to avoid GCC warning about integer overflow.
5225
c20db43f
PE
5226 * intervals.h (struct interval): Use EMACS_INT for members
5227 where EMACS_UINT might cause problems. See
5228 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5229 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5230 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5231 All uses changed.
37aa2f85
PE
5232 (offset_intervals): Tell GCC not to worry about length overflow
5233 when negating a negative length.
c20db43f 5234
2538aa2f
PE
5235 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5236 (overrun_check_free): Likewise.
5237
f2d3008d
PE
5238 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5239 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5240 word size.
5241
ec8df744
PE
5242 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5243 (gnutls_make_error): Rename local to avoid shadowing.
5244 (gnutls_emacs_global_deinit): ifdef out; not used.
5245 (Fgnutls_boot): Use const for pointer to readonly storage.
5246 Comment out unused local. Fix pointer signedness problems.
5247
640ee02d
PE
5248 * lread.c (openp): Don't stuff size_t into an 'int'.
5249 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5250 about possible signed overflow.
5251
6048fb2a
PE
5252 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5253 (GDK_KEY_g): Don't define if already defined.
5254 (xg_prepare_tooltip): Avoid pointer signedness problem.
5255 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5256
fa3c87e1
PE
5257 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5258 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5259
2172544b
PE
5260 * xfns.c (Fx_window_property): Simplify a bit,
5261 to make a bit faster and to avoid GCC 4.6.0 warning.
5262 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5263
9b821a21
PE
5264 * fns.c (internal_equal): Don't assume size_t fits in int.
5265
3c616cfa
PE
5266 * alloc.c (compact_small_strings): Tighten assertion a little.
5267
c2982e87
PE
5268 Replace pEd with more-general pI, and fix some printf arg casts.
5269 * lisp.h (pI): New macro, generalizing old pEd macro to other
5270 conversion specifiers. For example, use "...%"pI"d..." rather
5271 than "...%"pEd"...".
5272 (pEd): Remove. All uses replaced with similar uses of pI.
5273 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5274 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5275 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5276 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5277 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5278 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5279 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5280 64-bit hosts.
5281 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5282 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5283 * print.c (safe_debug_print, print_object): Likewise.
5284 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5285 to int.
6f04d126
PE
5286 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5287 avoiding the 0 flag, which is not portable.
c2982e87
PE
5288 * process.c (Fmake_network_process): Use pI to avoid cast.
5289 * region-cache.c (pp_cache): Likewise.
5290 * xdisp.c (decode_mode_spec): Likewise.
5291 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5292 behavior on 64-bit hosts with printf arg.
6f04d126 5293 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
5294 (x_stop_queuing_selection_requests): Likewise.
5295 (x_get_window_property): Don't truncate byte count to an 'int'
5296 when tracing.
0b432f21 5297
5e073ec7
PE
5298 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5299 here, since it parses constructs like leading '-' and spaces,
5300 which are not wanted; and it overflows with large numbers.
5301 Instead, simply match F[0-9]+, which is what is wanted anyway.
5302
36372bf9
PE
5303 * alloc.c: Remove unportable assumptions about struct layout.
5304 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5305 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5306 (allocate_vectorlike, make_pure_vector): Use the new macros,
5307 plus offsetof, to remove unportable assumptions about struct layout.
5308 These assumptions hold on all porting targets that I know of, but
5309 they are not guaranteed, they're easy to remove, and removing them
5310 makes further changes easier.
5311
0b432f21
PE
5312 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5313 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
5314 (string_overrun_cookie): Now const. Use initializers that
5315 don't formally overflow signed char, to avoid warnings.
000098c1
PE
5316 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5317 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
5318 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5319 multiple of sizeof (EMACS_INT); it need not be, if
5320 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 5321 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 5322
895009e1
JB
53232011-04-26 Juanma Barranquero <lekktu@gmail.com>
5324
5325 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5326
6a7a1b0b
TZ
53272011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5328
5329 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 5330 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
5331 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5332
841a1577 53332011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
5334
5335 * lisp.h (Qdebug): List symbol.
895009e1 5336 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
5337 * keyboard.c (debug-on-event): New variable.
5338 (handle_user_signal): Break into debugger when debug-on-event
5339 matches the current signal symbol.
5340
f2d3ba6f
DN
53412011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5342
5343 * alloc.c (check_sblock, check_string_bytes)
5344 (check_string_free_list): Convert to standard C.
5345
42ce4c63
TZ
53462011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5347
5348 * w32.c (emacs_gnutls_push): Fix typo.
5349
825cd63c
EZ
53502011-04-25 Eli Zaretskii <eliz@gnu.org>
5351
fb11d64d
EZ
5352 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5353 "cast to pointer from integer of different size".
5354
825cd63c
EZ
5355 Improve doprnt and its use in verror. (Bug#8545)
5356 * doprnt.c (doprnt): Document the set of format control sequences
5357 supported by the function. Use SAFE_ALLOCA instead of always
5358 using `alloca'.
5359
5360 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5361 is one byte too soon. Don't use xrealloc; instead xfree and
5362 xmalloc anew.
5363
e061a11b
TZ
53642011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5365
5366 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5367 callbacks stage.
5368
5369 * gnutls.c: Renamed global_initialized to
5370 gnutls_global_initialized. Added internals for the
5371 :verify-hostname-error, :verify-error, and :verify-flags
5372 parameters of `gnutls-boot' and documented those parameters in the
5373 docstring. Start callback support.
9173deec
JB
5374 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5375 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5376 on error. Return error code.
e061a11b
TZ
5377 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5378 (emacs_gnutls_read): Likewise.
5379 (Fgnutls_boot): Return handshake error code.
5380 (emacs_gnutls_handle_error): New function.
5381 (wsaerror_to_errno): Likewise.
5382
5383 * w32.h (emacs_gnutls_pull): Add prototype.
5384 (emacs_gnutls_push): Likewise.
5385
5386 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5387 (emacs_gnutls_push): Likewise.
5388
53892011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5390
5391 * process.c (wait_reading_process_output): Check if GnuTLS
5392 buffered some data internally if no FDs are set for TLS
5393 connections.
5394
5395 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5396 (LIBS): Link to USER_LIBS.
5397 ($(BLD)/gnutls.$(0)): New target.
5398
fa6996bc
EZ
53992011-04-24 Eli Zaretskii <eliz@gnu.org>
5400
eb35682e
EZ
5401 * xdisp.c (handle_single_display_spec): Rename the
5402 display_replaced_before_p argument into display_replaced_p, to
5403 make it consistent with the commentary. Fix typos in the
5404 commentary.
5405
e2ad650c
EZ
5406 * textprop.c (syms_of_textprop): Remove dead code.
5407 (copy_text_properties): Delete obsolete commentary about an
5408 interface that was deleted long ago. Fix typos in the description
5409 of arguments.
5410
1b2de274
EZ
5411 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5412 to changes in oldXMenu/XMenu.h from 2011-04-16.
5413 <menu_help_message, prev_menu_help_message>: Constify.
5414 (IT_menu_make_room): menu->help_text is now `const char **';
5415 adjust.
5416
5417 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5418 to changes in oldXMenu/XMenu.h from 2011-04-16.
5419 (struct XMenu): Declare `help_text' `const char **'.
5420
5421 * xfaces.c <Qunspecified>: Make extern again.
5422
5423 * syntax.c: Include sys/types.h before including regex.h, as
5424 required by Posix.
5425
762b15be
EZ
5426 * doc.c (get_doc_string): Improve the format passed to `error'.
5427
5428 * doprnt.c (doprnt): Improve commentary.
5429
5430 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5431
5432 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5433 them with etags.
5434
f1052e5d
EZ
5435 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5436 changes in globals.h immediately force recompilation.
762b15be
EZ
5437 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5438 $(CURDIR)/s/ms-w32.h.
5439 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 5440
fa6996bc
EZ
5441 * character.c (Fchar_direction): Function deleted.
5442 (syms_of_character): Don't defsubr it.
5443 <char-direction-table>: Deleted.
5444
e6c3da20
EZ
54452011-04-23 Eli Zaretskii <eliz@gnu.org>
5446
5447 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5448 * doprnt.c: Include limits.h.
5449 (SIZE_MAX): New macro.
04f2d78b
CB
5450 (doprnt): Return a size_t value. 2nd arg is now size_t.
5451 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
5452 Improve overflow protection. Support `l' modifier for integer
5453 conversions. Support %l conversion. Don't assume an EMACS_INT
5454 argument for integer conversions and for %c.
5455
5456 * lisp.h (doprnt): Restore prototype.
5457
5458 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5459 $(SRC)/character.h.
5460
5461 * Makefile.in (base_obj): Add back doprnt.o.
5462
5463 * deps.mk (doprnt.o): Add back prerequisites.
5464 (callint.o): Depend on character.h.
5465
5466 * eval.c (internal_lisp_condition_case): Include the handler
5467 representation in the error message.
5468 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5469 when breaking from the loop.
5470
5471 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5472
5473 * callint.c (Fcall_interactively): When displaying error message
5474 about invalid control letter, pass the character's codepoint, not
5475 a pointer to its multibyte form. Improve display of the character
5476 in octal and display also its hex code.
5477
5478 * character.c (char_string): Use %x to display the (unsigned)
5479 codepoint of an invalid character, to avoid displaying a bogus
5480 negative value.
5481
5482 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5483 `error', not SYMBOL_NAME itself.
5484
5485 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5486 character arguments to `error'.
5487
5488 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5489 to `error' in error message about FINAL_CHAR argument. Make sure
5490 FINAL_CHAR is a character, and use %c when it is passed as
5491 argument to `error'.
5492
4ffd0d6b 54932011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
5494
5495 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5496
5497 * w32.c: Include <time.h>.
5498 (sys_localtime): New function.
5499
4ffd0d6b 55002011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
5501
5502 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5503
4ffd0d6b 5504 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 5505
4ffd0d6b 55062011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 5507
4ffd0d6b
GM
5508 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5509 zombies (Bug#8467).
aac0c6e3 5510
04c56954
EZ
55112011-04-19 Eli Zaretskii <eliz@gnu.org>
5512
5513 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5514 gl_state.e_property when gl_state.object is Qt.
5515
5516 * insdel.c (make_gap_larger): Remove limitation of buffer size
5517 to <= INT_MAX.
5518
16a43933
CY
55192011-04-18 Chong Yidong <cyd@stupidchicken.com>
5520
5521 * xdisp.c (lookup_glyphless_char_display)
5522 (produce_glyphless_glyph): Handle cons cell entry in
5523 glyphless-char-display.
5524 (Vglyphless_char_display): Document it.
5525
5526 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5527 glyphless-char-display.
5528
4581706e
CY
55292011-04-17 Chong Yidong <cyd@stupidchicken.com>
5530
5531 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5532
5533 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5534
5535 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5536 definition for no-X builds.
5537
4887c6e2 55382011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 5539
fd35b6f9
PE
5540 Static checks with GCC 4.6.0 and non-default toolkits.
5541
5c1ccb01
PE
5542 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5543
006c5daa
PE
5544 * process.c (keyboard_bit_set): Define only if SIGIO.
5545 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5546 (send_process): Repair possible setjmp clobbering.
5547
efc736d3
PE
5548 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5549
4e2fe2e6
PE
5550 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5551
f97334a2
PE
5552 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5553
4e75f29d
PE
5554 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5555 Define only if needed.
5556
90efadd1
PE
5557 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5558 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 5559 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 5560
3c647824
PE
5561 * dispextern.h (struct redisplay_interface): Rename param
5562 to avoid shadowing.
e264f262 5563 * termhooks.h (struct terminal): Likewise.
761383f4 5564 * xterm.c (xembed_send_message): Likewise.
3c647824 5565
b58c5c4a
PE
5566 * insdel.c (make_gap_smaller): Define only if
5567 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5568
cad59032
PE
5569 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5570 it.
5571
c339dc2e
PE
5572 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5573 so that we aren't warned about unused symbols.
5574
91a3e27b
PE
5575 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5576
399c71d3 5577 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 5578
8ffc96f5
PE
5579 * xfns.c (x_real_positions): Mark locals as initialized.
5580
eef9bc79
PE
5581 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5582
098db9dd
PE
5583 * xterm.c: Fix problems found by static analysis with other toolkits.
5584 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
5585 (x_dispatch_event): Declare static if USE_GTK, and
5586 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 5587 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 5588 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
5589 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5590 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 5591
eb18f6cc
PE
5592 * xmenu.c (menu_help_callback): Pointer type fixes.
5593 Use const pointers when pointing at readonly data. Avoid pointer
5594 signedness clashes.
5595 (FALSE): Remove unused macro.
5596 (update_frame_menubar): Remove unused decl.
5597
1fe72bf8
PE
5598 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5599
60d9e1db
PE
5600 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5601 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5602 (single_menu_item): Rename local to avoid shadowing.
5603
39261c26
PE
5604 * keyboard.c (make_lispy_event): Remove unused local var.
5605
018c5e19
PE
5606 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5607 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5608
63d2b86e
PE
5609 * bitmaps: Change bitmaps from unsigned char back to the X11
5610 compatible char. Avoid the old compiler warnings about
5611 out-of-range initializers by using, for example, '\xab' rather
5612 than 0xab.
5613
aefd87e1
PE
5614 * xgselect.c (xgselect_initialize): Check vs interface
5615 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5616
bf501fb9
PE
5617 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5618
e9829fdf
PE
5619 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5620 to read-only memory.
5621
1086c095
PE
5622 * fns.c (vector): Remove; this old hack is no longer needed.
5623
2baccd04 5624 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 5625 Remove unused var.
dde42981 5626 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 5627
72391843 5628 * xrdb.c (x_load_resources): Omit unused local.
3565b346 5629
436c16df 5630 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 5631 (x_window): Rename locals to avoid shadowing.
dc5ddd85 5632 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 5633
92bb796d 5634 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 5635 (x_term_init): Remove local to avoid shadowing.
92bb796d 5636
764430a3 5637 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
5638
5639 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5640 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5641
d1dfb56c
EZ
56422011-04-16 Eli Zaretskii <eliz@gnu.org>
5643
c4354cb4
EZ
5644 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5645
d1dfb56c
EZ
5646 Fix regex.c, syntax.c and friends for buffers > 2GB.
5647 * syntax.h (struct gl_state_s): Declare character position members
5648 EMACS_INT.
5649
5650 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5651
04f2d78b
CB
5652 * textprop.c (verify_interval_modification, interval_of):
5653 Declare arguments EMACS_INT.
d1dfb56c
EZ
5654
5655 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5656 EMACS_INT.
5657
5658 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5659
5660 * indent.c (Fvertical_motion): Local variable it_start is now
5661 EMACS_INT.
5662
5663 * regex.c (re_match, re_match_2, re_match_2_internal)
5664 (bcmp_translate, regcomp, regexec, print_double_string)
5665 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5666 (re_compile_pattern, re_exec): Declare arguments and local
5667 variables `size_t' and `ssize_t' and return values `regoff_t', as
5668 appropriate.
5669 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5670 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5671 <compile_stack_type>: `size' and `avail' are now `size_t'.
5672
5673 * regex.h <regoff_t>: Use ssize_t, not int.
5674 (re_search, re_search_2, re_match, re_match_2): Arguments that
5675 specify buffer/string position and length are now ssize_t and
5676 size_t. Return type is regoff_t.
5677
613052cd
BK
56782011-04-16 Ben Key <bkey76@gmail.com>
5679
5680 * nsfont.m: Fixed bugs in ns_get_family and
5681 ns_descriptor_to_entity that were caused by using free to
5682 deallocate memory blocks that were allocated by xmalloc (via
5683 xstrdup). This caused Emacs to crash when compiled with
5684 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5685 --enable-checking=xmallocoverrun). xfree is now used to
5686 deallocate these memory blocks.
5687
4170f62f 56882011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 5689
71b41406
PE
5690 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5691
9587a89d
PE
5692 emacs_write: Accept and return EMACS_INT for sizes.
5693 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5694 et seq.
5695 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5696 Accept and return EMACS_INT.
5697 (emacs_gnutls_write): Return the number of bytes written on
5698 partial writes.
5699 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
5700 (emacs_read, emacs_write): Remove check for negative size, as the
5701 Emacs source code has been audited now.
9587a89d
PE
5702 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5703 (emacs_read, emacs_write): Use it.
273a5f82
PE
5704 * process.c (send_process): Adjust to the new signatures of
5705 emacs_write and emacs_gnutls_write. Do not attempt to store
5706 a byte offset into an 'int'; it might overflow.
9587a89d 5707 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 5708
3e047f51
PE
5709 * sound.c: Don't assume sizes fit in 'int'.
5710 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 5711 Return EMACS_INT, not int.
3e047f51 5712 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
5713 Accept EMACS_INT, not int.
5714 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
5715 record read return values.
5716
cc39a9db
BK
57172011-04-15 Ben Key <bkey76@gmail.com>
5718
c9d0ec6d
JB
5719 * keyboard.c (Qundefined): Don't declare static since it is used
5720 in nsfns.m.
5721 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5722 static since they are used in nsfont.m.
cc39a9db 5723
6c60eb9f
SM
57242011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5725
5726 * process.c (Qprocessp): Don't declare static.
5727 * lisp.h (Qprocessp): Declare again.
5728
7990b61a
JB
57292011-04-15 Juanma Barranquero <lekktu@gmail.com>
5730
5731 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5732
5d4cb038
PE
57332011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5734
8bd7b830 5735 Improve C-level modularity by making more things 'static'.
cd64ea1d 5736
e3b27b31
PE
5737 Don't publish debugger-only interfaces to other modules.
5738 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5739 (verify_bytepos, count_markers): Move decls to the only modules
5740 that need them.
5741 * region-cache.h (pp_cache): Likewise.
5742 * window.h (check_all_windows): Likewise.
5743 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5744
5d4cb038
PE
5745 * sysdep.c (croak): Now static, if
5746 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5747 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
5748
5749 * alloc.c (refill_memory_reserve): Now static if
5750 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5751 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 5752
e87b6180
PE
5753 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5754 Define only if USE_LUCID.
5755
ac64929e
PE
5756 * xrdb.c (x_customization_string, x_rm_string): Now static.
5757
6f37259d
PE
5758 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5759 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5760
1683e3ab
PE
5761 * xdisp.c (draw_row_with_mouse_face): Now static.
5762 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5763
de9c2632
PE
5764 * window.h (check_all_windows): Mark externally visible.
5765
2b96acb7
PE
5766 * window.c (window_deletion_count): Now static.
5767
5768 * undo.c: Make symbols static if they're not exported.
5769 (last_undo_buffer, last_boundary_position, pending_boundary):
5770 Now static.
5771
50436f33
PE
5772 * textprop.c (interval_insert_behind_hooks): Now static.
5773 (interval_insert_in_front_hooks): Likewise.
5774
64520e5c
PE
5775 * term.c: Make symbols static if they're not exported.
5776 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5777 (max_frame_lines, tty_set_terminal_modes):
5778 (tty_reset_terminal_modes, tty_turn_off_highlight):
5779 (get_tty_terminal): Now static.
5780 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5781 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 5782 HAVE_WINDOW_SYSTEM.
64520e5c
PE
5783 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5784 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5785
1fa53021
PE
5786 * sysdep.c: Make symbols static if they're not exported.
5787 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5788 Now static.
5789 (sigprocmask_set, full_mask): Remove; unused.
5790 (wait_debugging): Mark as visible.
5791 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5792 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5793
d4b43b22
PE
5794 * syntax.c (syntax_temp): Define only if !__GNUC__.
5795
b7c513d0
PE
5796 * sound.c (current_sound_device, current_sound): Now static.
5797
989b29ad
PE
5798 * search.c (searchbufs, searchbuf_head): Now static.
5799
13a55a78
PE
5800 * scroll.c (scroll_cost): Remove; unused.
5801 * dispextern.h (scroll_cost): Remove decl.
5802
de68a1fc
PE
5803 * region-cache.h (pp_cache): Mark as externally visible.
5804
40ccffa6
PE
5805 * process.c: Make symbols static if they're not exported.
5806 (process_tick, update_tick, create_process, chan_process):
5807 (Vprocess_alist, proc_buffered_char, datagram_access):
5808 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5809 (deactivate_process): Mark defn as static, as well as decl.
5810 * lisp.h (create_process): Remove decl.
5811 * process.h (chan_process, Vprocess_alist): Remove decls.
5812
ad64fc97
PE
5813 * print.c: Make symbols static if they're not exported.
5814 (print_depth, new_backquote_output, being_printed, print_buffer):
5815 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5816 (print_interval, print_number_index, initial_stderr_stream):
5817 Now static.
5818 * lisp.h (Fprinc): Remove decl.
5819 (debug_output_compilation_hack): Mark as externally visible.
5820
adddb265
PE
5821 * sysdep.c (croak): Move decl from here to syssignal.h.
5822 * syssignal.h (croak): Put it here, so the API can be checked when
5823 'croak' is called from dissociate_if_controlling_tty.
5824
1717ede2
PE
5825 * minibuf.c: Make symbols static if they're not exported.
5826 (minibuf_save_list, choose_minibuf_frame): Now static.
5827 * lisp.h (choose_minibuf_frame): Remove decl.
5828
fa5fb2bc
PE
5829 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5830
1e3890d1
PE
5831 * lread.c: Make symbols static if they're not exported.
5832 (read_objects, initial_obarray, oblookup_last_bucket_number):
5833 Now static.
5834 (make_symbol): Remove; unused.
5835 * lisp.h (initial_obarray, make_symbol): Remove decls.
5836
8a1414fa
PE
5837 * keyboard.c: Make symbols static if they're not exported.
5838 (single_kboard, recent_keys_index, total_keys, recent_keys):
5839 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5840 (this_single_command_key_start, echoing, last_auto_save):
5841 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5842 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5843 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5844 (Vlispy_mouse_stem, double_click_count):
5845 Now static.
5846 (force_auto_save_soon): Define only if SIGDANGER.
5847 (ignore_mouse_drag_p): Now static if
5848 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5849 (print_help): Remove; unused.
5850 (stop_character, last_timer_event): Mark as externally visible.
5851 * keyboard.h (ignore_mouse_drag_p): Declare only if
5852 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5853 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5854 * lisp.h (echoing): Remove decl.
5855 (force_auto_save_soon): Declare only if SIGDANGER.
5856 * xdisp.c (redisplay_window): Simplify code, to make it more
5857 obvious that ignore_mouse_drag_p is not accessed if !defined
5858 USE_GTK && !defined HAVE_NS.
5859
93ea6e8f
PE
5860 * intervals.c: Make symbols static if they're not exported.
5861 (merge_properties_sticky, merge_interval_right, delete_interval):
5862 Now static.
5863 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5864
77382fcc
PE
5865 * insdel.c: Make symbols static if they're not exported.
5866 However, leave prepare_to_modify_buffer alone. It's never
5867 called from outside this function, but that appears to be a bug.
5868 (combine_after_change_list, combine_after_change_buffer):
4889fc82 5869 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
5870 (adjust_after_replace_noundo): Remove; unused.
5871 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 5872 (signal_before_change): Remove decls.
77382fcc 5873
9306c32e
PE
5874 * indent.c (val_compute_motion, val_vmotion): Now static.
5875
cd44d2eb
PE
5876 * image.c: Make symbols static if they're not exported.
5877 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5878 if USE_GTK.
5879 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5880 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5881
ad9a7a06
PE
5882 * fringe.c (standard_bitmaps): Now static.
5883 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5884
81626931
PE
5885 * frame.c: Make symbols static if they're not exported.
5886 (x_report_frame_params, make_terminal_frame): Now static.
5887 (get_frame_param): Now static, unless HAVE_NS.
5888 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5889 (x_get_resource_string): Remove; not used.
5890 * frame.h (make_terminal_frame, x_report_frame_params):
5891 (x_get_resource_string); Remove decls.
5892 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5893 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5894
239f9db9
PE
5895 * font.c, fontset.c: Make symbols static if they're not exported.
5896 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5897 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5898 * font.c (font_close_object): Now static.
5899 * font.h (font_close_object): Remove.
5900 * fontset.c (FONTSET_OBJLIST): Remove.
5901 (free_realized_fontset) #if-0 the body, which does nothing.
5902 (face_suitable_for_char_p): #if-0, as it's never called.
5903 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
5904 * xfaces.c (face_at_string_position):
5905 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
5906 since 0 is always ASCII.
5907
dfcf3579
PE
5908 * fns.c (weak_hash_tables): Now static.
5909
5045092b
PE
5910 * fileio.c: Make symbols static if they're not exported.
5911 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5912 (Vwrite_region_annotation_buffers): Now static.
5913
57a96f5c
PE
5914 * eval.c: Make symbols static if they're not exported.
5915 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5916 * lisp.h (backtrace_list): Remove decl.
5917
35f08c38
PE
5918 * emacs.c: Make symbols static if they're not exported.
5919 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5920 (fatal_error_code, fatal_error_signal_hook, standard_args):
5921 Now static.
5922 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5923 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5924 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5925 * lisp.h (fatal_error_signal_hook): Remove decl.
5926 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5927
f44bd759
PE
5928 * editfns.c: Move a (normally-unused) function to its only use.
5929 * editfns.c, lisp.h (get_operating_system_release): Remove.
5930 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5931 worth the hassle of breaking this out.
5932
b532497d
PE
5933 * xterm.c: Make symbols static if they're not exported.
5934 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5935 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5936 (x_destroy_window, x_delete_display):
5937 Now static.
5938 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5939 (x_mouse_leave): Remove; unused.
5940 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5941 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5942 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5943 Remove decls.
5944 (x_mouse_leave): Declare only if WINDOWSNT.
5945 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5946 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5947 USE_X_TOOLKIT.
5948
1675728f
PE
5949 * ftxfont.c: Make symbols static if they're not exported.
5950 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5951 HAVE_FREETYPE.
5952 * font.h (ftxfont_driver): Likewise.
5953
e4cebfca
PE
5954 * xfns.c: Make symbols static if they're not exported.
5955 (x_last_font_name, x_display_info_for_name):
5956 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5957 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5958 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5959 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5960 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5961 (last_show_tip_args): Now static.
5962 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5963 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5964 (x_screen_planes): Remove; unused.
5965 * dispextern.h (x_screen_planes): Remove decl.
5966
5bf46f05
PE
5967 * dispnew.c: Make symbols static if they're not exported.
5968 * dispextern.h (redraw_garbaged_frames, scrolling):
5969 (increment_row_positions): Remove.
5970 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5971 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5972 Now static.
5973 (redraw_garbaged_frames): Remove; unused.
5974
435f4c28
PE
5975 * xfaces.c: Make symbols static if they're not exported.
5976 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5977 Remove decls.
5978 * xterm.h (defined_color): Remove decls.
5979 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5980 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5981 (menu_face_changed_default, defined_color, free_realized_face):
5982 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5983 (ascii_face_of_lisp_face): Remove; unused.
5984
8524aef3
PE
5985 * xdisp.c: Make symbols static if they're not exported.
5986 * dispextern.h (scratch_glyph_row, window_box_edges):
5987 (glyph_to_pixel_coords, set_cursor_from_row):
5988 (get_next_display_element, set_iterator_to_next):
5989 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5990 (show_mouse_face): Remove decls
5991 * frame.h (message_buf_print): Likewise.
5992 * lisp.h (pop_message, set_message, check_point_in_composition):
5993 Likewise.
5994 * xterm.h (set_vertical_scroll_bar): Likewise.
5995 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5996 (message_buf_print, scratch_glyph_row, displayed_buffer):
5997 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5998 (get_next_display_element, show_mouse_face, window_box_edges):
5999 (frame_to_window_pixel_xy, check_point_in_composition):
6000 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6001 (glyph_to_pixel_coords): Remove; unused.
6002
16390cd2
PE
6003 * dired.c (file_name_completion): Now static.
6004
6005 * dbusbind.c (xd_in_read_queued_messages): Now static.
6006
a25f4dfa
PE
6007 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6008 * data.c (circular_list_error): Remove.
6009
14a9c8df
PE
6010 * commands.h (last_point_position, last_point_position_buffer):
6011 (last_point_position_window): Remove decls.
6012 * keyboard.c: Make these variables static.
6013
04f2d78b
CB
6014 * coding.h (coding, code_convert_region, encode_coding_gap):
6015 Remove decls.
74ab6df5
PE
6016 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6017 (iso_code_class, detect_coding, code_convert_region): Now static.
6018 (encode_coding_gap): Remove; unused.
6019
38dfbee1
PE
6020 * chartab.c (chartab_chars, chartab_bits): Now static.
6021
a2cb4e63
PE
6022 * charset.h (charset_iso_8859_1): Remove decl.
6023 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6024 Now static.
6025
127198fd
PE
6026 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6027 * ccl.c (Vccl_program_table): Now static.
6028 (check_ccl_update): Remove; unused.
6029
d85b608f
PE
6030 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6031 * category.h: ... from here.
6032 * category.c (check_category_table, set_category_set): Now static.
6033
31cd66f3
PE
6034 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6035 * lisp.h: Remove these decls.
6036
c358e587
PE
6037 * buffer.c (buffer_count): Remove unused var.
6038
e78aecca
PE
6039 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6040 so that it's not optimized away.
6041 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6042 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6043 exported only to the debugger.
6044
e192d7d3 6045 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 6046 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 6047
92470028
PE
6048 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6049 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6050 was inaccessible from Lisp.
6051 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6052 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6053
244ed907
PE
6054 alloc.c: Import and export fewer symbols, and remove unused items.
6055 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6056 is defined.
6057 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6058 it's not optimized away by whole-program optimization.
6059 (message_enable_multibyte, free_misc): Remove.
6060 (catchlist, handlerlist, mark_backtrace):
6061 Declare only if BYTE_MARK_STACK.
6062 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6063 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6064 (message_enable_multibyte): Remove decl.
6065 (free_misc, interval_free_list, float_block, float_block_index):
6066 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6067 (cons_free_list, last_marked_index):
6068 Now static.
6069 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6070 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6071 (mark_backtrace): Define only if BYTE_MARK_STACK.
6072 * xdisp.c (message_enable_multibyte): Now static.
6073
61c2b50e 6074 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
6075 This makes it easier for human readers (and static analyzers)
6076 to see whether these variables are used from other modules.
6077 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6078 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6079 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6080 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6081 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6082 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6083 * xmenu.c, xselect.c:
6084 Declare Q* vars static if they are not used in other modules.
6085 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6086 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6087 Remove decls of unexported vars.
6088 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6089
95c82688
PE
6090 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6091
16a97296
PE
6092 Make Emacs functions such as Fatom 'static' by default.
6093 This makes it easier for human readers (and static analyzers)
6094 to see whether these functions can be called from other modules.
6095 DEFUN now defines a static function. To make the function external
6096 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
6097 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6098 (Finit_image_library):
16a97296
PE
6099 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6100 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6101 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6102 Remove decls, since these functions are now static.
6103 (Funintern, Fget_internal_run_time): New decls, since these functions
6104 were already external.
95c82688 6105
16a97296
PE
6106 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6107 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6108 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6109 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6110 * keyboard.c, keymap.c, lread.c:
6111 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6112 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6113 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6114 Mark functions with DEFUE instead of DEFUN,
6115 if they are used in other modules.
6116 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6117 decls for now-static functions.
6118 * buffer.h (Fdelete_overlay): Remove decl.
6119 * callproc.c (Fgetenv_internal): Mark as internal.
6120 * composite.c (Fremove_list_of_text_properties): Remove decl.
6121 (Fcomposition_get_gstring): New forward static decl.
6122 * composite.h (Fcomposite_get_gstring): Remove decl.
6123 * dired.c (Ffile_attributes): New forward static decl.
6124 * doc.c (Fdocumntation_property): New forward static decl.
6125 * eval.c (Ffetch_bytecode): New forward static decl.
6126 (Funintern): Remove extern decl; now in .h file where it belongs.
6127 * fileio.c (Fmake_symbolic_link): New forward static decl.
6128 * image.c (Finit_image_library): New forward static decl.
6129 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6130 * intervals.h (Fprevious_property_change):
6131 (Fremove_list_of_text_properties): Remove decls.
6132 * keyboard.c (Fthis_command_keys): Remove decl.
6133 (Fcommand_execute): New forward static decl.
6134 * keymap.c (Flookup_key): New forward static decl.
6135 (Fcopy_keymap): Now static.
6136 * keymap.h (Flookup_key): Remove decl.
6137 * process.c (Fget_process): New forward static decl.
6138 (Fprocess_datagram_address): Mark as internal.
6139 * syntax.c (Fsyntax_table_p): New forward static decl.
6140 (skip_chars): Remove duplicate decl.
6141 * textprop.c (Fprevious_property_change): New forward static decl.
6142 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6143 Now internal.
6144 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6145 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6146
785bbd42
PE
6147 * editfns.c (Fformat): Remove unreachable code.
6148
8b913b57
AS
61492011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6150
6151 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6152 change. (Bug#8496)
6153
a6744a35
EZ
61542011-04-13 Eli Zaretskii <eliz@gnu.org>
6155
6156 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6157 when at ZV. (Bug#8487)
6158
e7974947
AS
61592011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6160
baad03f0
AS
6161 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6162 (Bug#8437)
6163 * keyboard.c (parse_tool_bar_item): Likewise.
6164 * sound.c (sound_cleanup, alsa_close): Likewise.
6165 * termcap.c (tgetent): Likewise.
6166 * xfns.c (x_default_font_parameter): Likewise.
6167 * xsettings.c (read_and_apply_settings): Likewise.
6168
e7974947
AS
6169 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6170 (overrun_check_free): Protoize.
6171
28272684
PE
61722011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6173
6174 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6175 since callers should never pass a negative size.
6176 Change the signature to match that of plain 'read' and 'write'; see
6177 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6178 * lisp.h: Update prototypes of emacs_write and emacs_read.
6179
11997c76
EZ
61802011-04-11 Eli Zaretskii <eliz@gnu.org>
6181
6182 * xdisp.c (redisplay_window): Don't try to determine the character
6183 position of the scroll margin if the window start point w->startp
e896f03c 6184 is outside the buffer's accessible region. (Bug#8468)
11997c76 6185
8a2cbd72
EZ
61862011-04-10 Eli Zaretskii <eliz@gnu.org>
6187
6188 Fix write-region and its subroutines for buffers > 2GB.
6189 * fileio.c (a_write, e_write): Modify declaration of arguments and
6190 local variables to support buffers larger than 2GB.
6191 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6192
6193 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6194 argument, local variables, and return value.
6195
6196 * lisp.h: Update prototypes of emacs_write and emacs_read.
6197
6198 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6199
4073e537 62002011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 6201
1ebfdcb6
PE
6202 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6203
b2ded58d
PE
6204 Fix more problems found by GCC 4.6.0's static checks.
6205
7d66342c
PE
6206 * xdisp.c (vmessage): Use a better test for character truncation.
6207
bbf47d44
PE
6208 * charset.c (load_charset_map): <, not <=, for optimization,
6209 and to avoid potential problems with integer overflow.
9248994d 6210 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 6211 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 6212 * editfns.c (Fformat): Likewise.
1e69125e 6213 * syntax.c (skip_chars): Likewise.
3befa583 6214
e3019616
PE
6215 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6216 This also lets GCC 4.6.0 generate slightly better loop code.
6217
becfa255
PE
6218 * callint.c (Fcall_interactively): <, not <=, for optimization.
6219 (Fcall_interactively): Count the number of arguments produced,
6220 not the number of arguments given. This is simpler and lets GCC
6221 4.6.0 generate slightly better code.
6222
dae0cd48
PE
6223 * ftfont.c: Distingish more carefully between FcChar8 and char.
6224 The previous code passed unsigned char * to a functions like
6225 strlen and xstrcasecmp that expect char *, which does not
6226 conform to the C standard.
6227 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6228 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6229 char * when the C standard requires it.
6230
76032d70
PE
6231 * keyboard.c (read_char): Remove unused var.
6232
eb3f1cc8
PE
6233 * eval.c: Port to Windows vsnprintf (Bug#8435).
6234 Include <limits.h>.
6235 (SIZE_MAX): Define if the headers do not.
6236 (verror): Do not give up if vsnprintf returns a negative count.
6237 Instead, grow the buffer. This ports to Windows vsnprintf, which
6238 does not conform to C99. Problem reported by Eli Zaretskii.
6239 Also, simplify the allocation scheme, by avoiding the need for
6240 calling realloc, and removing the ALLOCATED variable.
6241
70476b54
PE
6242 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6243
12020a9e
PE
6244 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6245 But keep the doprint source code for now, as we might revamp it
6246 and use it again (Bug#8435).
ea6c7ae6
PE
6247 * lisp.h (doprnt): Remove.
6248 * Makefile.in (base_obj): Remove doprnt.o.
6249 * deps.mk (doprnt.o): Remove.
6250
5fdb398c
PE
6251 error: Print 32- and 64-bit integers portably (Bug#8435).
6252 Without this change, on typical 64-bit hosts error ("...%d...", N)
6253 was used to print both 32- and 64-bit integers N, which relied on
6254 undefined behavior.
6255 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6256 New macro.
6257 * lisp.h (error, verror): Mark as printf-like functions.
6258 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6259 Report overflow in size calculations when allocating printf buffer.
6260 Do not truncate output string at its first null byte.
6261 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6262 Truncate the output at a character boundary, since vsnprintf does not
6263 do that.
6264 * charset.c (check_iso_charset_parameter): Convert internal
6265 character to string before calling 'error', since %c now has the
6266 printf meaning.
6267 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6268 overflow when computing char to be passed to 'error'. Do not
6269 pass Lisp_Object to 'error'; pass the integer instead.
6270 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6271 formatted with plain %d.
6272
b189fa66
PE
6273 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6274
bff87ef0
PE
6275 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6276
7e2cac20
PE
6277 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6278
ce4d90b5
PE
6279 * xterm.c (x_catch_errors): Remove duplicate declaration.
6280
266c9547
PE
6281 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6282
79c49ad2
PE
6283 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6284
368f4090
JM
62852011-04-10 Jim Meyering <meyering@redhat.com>
6286
6287 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6288 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6289 return ssize_t not "int", and use size_t as the buffer length.
6290 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6291 * gnutls.h: Update declarations.
6292 * process.c (read_process_output): Use ssize_t, to match.
6293 (send_process): Likewise.
6294
a32d4040
CY
62952011-04-09 Chong Yidong <cyd@stupidchicken.com>
6296
6297 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6298
8546720e 62992011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 6300
04f2d78b
CB
6301 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6302 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 6303
8546720e
GM
6304 * xterm.c (handle_one_xevent):
6305 * xmenu.c (create_and_show_popup_menu):
6306 * xselect.c (x_decline_selection_request)
6307 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 6308
0a2f5c1a 63092011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
6310
6311 Fix some uses of `int' instead of EMACS_INT.
6312 * search.c (string_match_1, fast_string_match)
6313 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6314 (scan_buffer, find_next_newline_no_quit)
6315 (find_before_next_newline, search_command, Freplace_match)
6316 (Fmatch_data): Make some `int' variables be EMACS_INT.
6317
6318 * xdisp.c (display_count_lines): 3rd argument and return value now
6319 EMACS_INT. All callers changed.
6320 (pint2hrstr): Last argument is now EMACS_INT.
6321
6322 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6323 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6324 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6325 (decode_coding_utf_16, decode_coding_emacs_mule)
6326 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6327 (decode_coding_ccl, decode_coding_charset)
6328 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6329 (decode_coding_iso_2022, decode_coding_emacs_mule)
6330 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6331 <char_offset, last_offset>: Declare EMACS_INT.
6332 (encode_coding_utf_8, encode_coding_utf_16)
6333 (encode_coding_emacs_mule, encode_invocation_designation)
6334 (encode_designation_at_bol, encode_coding_iso_2022)
6335 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6336 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6337 Declare EMACS_INT.
6338 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6339 (encode_invocation_designation): Last argument P_NCHARS is now
6340 EMACS_INT.
6341 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6342 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6343
6344 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6345 All users changed.
6346
6347 * ccl.c (Fccl_execute_on_string): Declare some variables
6348 EMACS_INT.
6349
8546720e 63502011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
6351
6352 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6353
4e19a977
CS
63542011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6355
6356 * process.c (Fformat_network_address): Doc fix.
6357
87302331
R
63582011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6359
6360 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6361
cbb59342
CY
63622011-04-08 Chong Yidong <cyd@stupidchicken.com>
6363
6364 * keyboard.c (read_char): Call Lisp function help-form-show,
6365 instead of using internal_with_output_to_temp_buffer.
6366 (Qhelp_form_show): New var.
e0d38eeb 6367 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
6368
6369 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6370
6371 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6372
e67a13ab
CY
63732011-04-06 Chong Yidong <cyd@stupidchicken.com>
6374
04f2d78b
CB
6375 * process.c (Flist_processes): Remove to Lisp.
6376 (list_processes_1): Delete.
e67a13ab 6377
973f782d
EZ
63782011-04-06 Eli Zaretskii <eliz@gnu.org>
6379
7c106b1e
EZ
6380 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6381
973f782d
EZ
6382 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6383
41cf7d1a 63842011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 6385
ca23cc88
PE
6386 Fix more problems found by GCC 4.6.0's static checks.
6387
f390e2d5
PE
6388 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6389
42eea0d0
PE
6390 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6391
b69769da 6392 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 6393
f9541e84
PE
6394 * xdisp.c (vmessage): Mark as a printf-like function.
6395
13841b55
PE
6396 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6397
c136c10f
PE
6398 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6399
5e2d4a30
PE
6400 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6401 printf-like functions.
6402 (tiff_load): Add casts to remove these marks before passing them
6403 to system-supplied API.
6404
583f48b9
PE
6405 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6406
b25d760e
PE
6407 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6408 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
6409 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6410 directly, rather than having caller test rule sign. This avoids
6411 some unnecessary tests.
6412 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6413 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6414 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 6415
bc7b6697 6416 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 6417 (xfont_open): Avoid unnecessary tests.
bc7b6697 6418
27ccc379
PE
6419 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6420
dcd5c89a
PE
6421 * composite.h, composite.c (composition_gstring_put_cache):
6422 Use EMACS_INT, not int, for length.
6423
b13a45c6
PE
6424 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6425 breaking out part of COMPOSITION_DECODE_RULE.
6426 (COMPOSITION_DECODE_RULE): Use it.
6427 * composite.c (get_composition_id): Remove unused local vars,
6428 by using the new macro.
6429
1e792e4d
PE
6430 * textprop.c (set_text_properties_1): Change while to do-while,
6431 since the condition is always true at first.
6432
dc6c6455 6433 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
6434 (interval_deletion_adjustment): Return unsigned value.
6435 All uses changed.
dc6c6455 6436
aba7731a
PE
6437 * process.c (list_processes_1, create_pty, read_process_output):
6438 (exec_sentinel): Remove vars that were set but not used.
afd4052b 6439 (create_pty): Remove unnecessary "volatile"s.
bc57d757 6440 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 6441 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 6442 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 6443
fdfc4bf3
PE
6444 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6445
fca8fe46 6446 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 6447 (update_syntax_table): Use unsigned instead of int.
fca8fe46 6448
06a0259a 6449 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 6450 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 6451 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 6452
e7b9e80f
PE
6453 * print.c (print_error_message): Avoid int overflow.
6454
56201685
PE
6455 * font.c (font_list_entities): Redo for clarity,
6456 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6457
78834453 6458 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 6459 (font_score): Avoid potential overflow in diff calculation.
78834453 6460
0bc0b309 6461 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 6462 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 6463
e610eaca
PE
6464 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6465
b895abce
PE
6466 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6467 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6468 can always succeed if overflow has undefined behavior.
6469
1f1d9321 6470 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 6471 (wordify): Omit three unnecessary tests.
1f1d9321 6472
c59478bc
PE
6473 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6474 All callers changed. This avoids the need for an unused var.
6475
79b73827
PE
6476 * casefiddle.c (casify_region): Remove var that is set but not used.
6477
a4db5dfe
PE
6478 * dired.c (file_name_completion): Remove var that is set but not used.
6479
43aae36e
PE
6480 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6481
2a47c44d 6482 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 6483 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 6484
a37c69bf
PE
6485 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6486 Check for integer overflow on size calculations.
6487
328ab8e7
PE
6488 * buffer.c (Fprevious_overlay_change): Remove var that is set
6489 but not used.
6490
e5a2a5cb
PE
6491 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6492 Remove vars that are set but not used.
8d84a6eb 6493 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 6494 (timer_check_2): Mark vars as initialized.
e5a2a5cb 6495
a60e5f68
PE
6496 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6497
f661cb61 6498 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 6499 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 6500
f0397f5a
PE
6501 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6502 that are set but not used.
6503
8664db06 6504 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 6505 if XCreateBitmapFromData fails (Bug#8410).
8664db06 6506
6abdaa4a
PE
6507 * xselect.c (x_get_local_selection, x_handle_property_notify):
6508 Remove vars that are set but not used.
6509
0ce7538d 6510 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 6511 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 6512
9ae848fc
PE
6513 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6514 Remove var that is set but not used.
0b918413
PE
6515 (scroll_bar_windows_size): Now size_t, not int.
6516 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6517 Check for overflow.
9ae848fc 6518
a5a62657
PE
6519 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6520 (map_tty_color) [!defined MSDOS]: Likewise.
6521
5c5cdd39
PE
6522 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6523
66ebf983
PE
6524 * coding.c: Remove vars that are set but not used.
6525 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6526 All callers changed.
6527 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6528 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6529 (decode_coding_charset): Remove vars that are set but not used.
6530
1be4d761
PE
6531 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6532 that is set but not used.
6533
47553fa8
PE
6534 * print.c (print_object): Remove var that is set but not used.
6535
1f7196bf 6536 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
6537 The gnulib version avoids calling malloc in the usual case,
6538 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6539 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6540 * filelock.c (current_lock_owner): Likewise.
6541 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6542 * sysdep.c: Include allocator.h, careadlinkat.h.
6543 (emacs_no_realloc_allocator): New static constant.
6544 (emacs_readlink): New function.
fdb61804
PE
6545 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6546 ../lib/careadlinkat.h.
d1fdcab7 6547
f84c17c7
SM
65482011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6549
6550 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6551 first non-nil return value).
6552
ef3862ad
JD
65532011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6554
6555 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6556 if not defined (Bug#8403).
6557
376a7006
JB
65582011-04-02 Juanma Barranquero <lekktu@gmail.com>
6559
6560 * xdisp.c (display_count_lines): Remove parameter `start',
6561 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6562 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6563 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6564 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6565 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6566 and thereabouts. All callers changed.
6567 (get_per_char_metric): Remove parameter `f', unused since
6568 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6569
6ca3801d
JM
65702011-04-02 Jim Meyering <meyering@redhat.com>
6571
6572 do not dereference NULL upon failed strdup
6573 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6574 (ns_get_family): Likewise.
6575
d8e2b5ba
JB
65762011-04-02 Juanma Barranquero <lekktu@gmail.com>
6577
6578 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6579
8c74fcbd
JD
65802011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6581
6582 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6583 later (Bug#8403).
6584
7200d79c
SM
65852011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6586
03408648 6587 Add lexical binding.
7200d79c 6588
03408648
SM
6589 * window.c (Ftemp_output_buffer_show): New fun.
6590 (Fsave_window_excursion):
6591 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6592
6593 * lread.c (lisp_file_lexically_bound_p): New function.
6594 (Fload): Bind Qlexical_binding.
6595 (readevalloop): Remove `evalfun' arg.
6596 Bind Qinternal_interpreter_environment.
6597 (Feval_buffer): Bind Qlexical_binding.
6598 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6599 Mark as dynamic.
6600 (syms_of_lread): Declare `lexical-binding'.
6601
6602 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6603
6604 * keyboard.c (eval_dyn): New fun.
6605 (menu_item_eval_property): Use it.
ca105506
SM
6606
6607 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 6608
03408648
SM
6609 * fns.c (concat, mapcar1): Accept byte-code-functions.
6610
6611 * eval.c (Fsetq): Handle lexical vars.
6612 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6613 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6614 (FletX, Flet): Obey lexical binding.
6615 (Fcommandp): Handle closures.
6616 (Feval): New `lexical' arg.
6617 (eval_sub): New function extracted from Feval. Use it almost
6618 everywhere where Feval was used. Look up vars in lexical env.
6619 Handle closures.
6620 (Ffunctionp): Move from subr.el.
6621 (Ffuncall): Handle closures.
6622 (apply_lambda): Remove `eval_flags'.
6623 (funcall_lambda): Handle closures and new byte-code-functions.
6624 (Fspecial_variable_p): New function.
6625 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6626 but without exporting it to Lisp.
23aba0ea 6627
23aba0ea 6628 * doc.c (Fdocumentation, store_function_docstring):
03408648 6629 * data.c (Finteractive_form): Handle closures.
23aba0ea 6630
03408648
SM
6631 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6632 interactive spec.
ba83908c 6633
04f2d78b
CB
6634 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6635 New byte-codes.
03408648
SM
6636 (exec_byte_code): New function extracted from Fbyte_code to handle new
6637 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 6638
03408648 6639 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 6640
03408648 6641 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 6642
e2abce01
JB
66432011-03-31 Juanma Barranquero <lekktu@gmail.com>
6644
6645 * xdisp.c (redisplay_internal): Fix prototype.
6646
63696a73 66472011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 6648
63696a73 6649 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
6650 (try_scrolling): Use it when setting scroll_limit.
6651 Limit scrolling to 100 screen lines.
63696a73
EZ
6652 (redisplay_window): Even when falling back on "recentering",
6653 position point in the window according to scroll-conservatively,
6654 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6655
6656 (try_scrolling): When point is above the window, allow searching
6657 as far as scroll_max, or one screenful, to compute vertical
6658 distance from PT to the scroll margin position. This prevents
6659 try_scrolling from unnecessarily failing when
6660 scroll-conservatively is set to a value slightly larger than the
6661 window height. Clean up the case of PT below the margin at bottom
6662 of window: scroll_max can no longer be INT_MAX. When aggressive
6663 scrolling is in use, don't let point enter the opposite scroll
6664 margin as result of the scroll.
6665 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
6666 threshold of 100 lines for never-recentering scrolling.
6667
e4cc2dfc
JB
66682011-03-31 Juanma Barranquero <lekktu@gmail.com>
6669
6670 * dispextern.h (move_it_by_lines):
6671 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6672 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6673 (message_log_check_duplicate): Remove parameters `prev_bol' and
6674 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6675 (redisplay_internal): Remove parameter `preserve_echo_area',
6676 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6677
6678 * indent.c (Fvertical_motion):
6679 * window.c (window_scroll_pixel_based, Frecenter):
6680 Don't pass `need_y_p' to `move_it_by_lines'.
6681
1c470562
SM
66822011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6683
44f230aa
SM
6684 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6685 steal a few bits to be more compact.
6686 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6687 Remove unneeded casts.
6688
1c470562
SM
6689 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6690
888adce9
ZK
66912011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6692
6693 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6694 binding" message (bug#7967).
6695
f838ed7b
PE
66962011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6697
77861b95
PE
6698 Fix more problems found by GCC 4.6.0's static checks.
6699
de6dbc14
PE
6700 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6701 Remove unused local var.
6702
f838ed7b
PE
6703 * editfns.c (Fmessage_box): Remove unused local var.
6704
792c7b2b
PE
6705 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6706 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6707 Omit unused local vars.
c499e557 6708 * window.c (shrink_windows): Omit unused local var.
b01a1c29 6709 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
6710 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6711 Omit unused local var.
6712
ba0165e1
PE
6713 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6714 Don't assume string length fits in int.
32ad8845 6715 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 6716 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 6717
3c59b4c9
PE
6718 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6719 instead of alloca (Bug#8344).
6720
a3eed478 6721 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 6722 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 6723
eb4d412d
PE
6724 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6725
1658b401
PE
6726 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6727 concerns.
6728
6729 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6730
6731 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 6732
9a2c6e05
PE
6733 * keyboard.c (syms_of_keyboard): Use the same style as later
6734 in this function when indexing through an array. This also
6735 works around GCC bug 48267.
6736
03d0a109
PE
6737 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6738
44f730c8
PE
6739 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6740
fe75f926
PE
6741 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6742 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6743
ffa8c828
PE
6744 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6745 This avoids undefined behavior on integer overflow, and is a bit
6746 more convenient anyway since it is compared to a size_t variable.
6747
c5101a77
PE
6748 Variadic C functions now count arguments with size_t, not int.
6749 This avoids an unnecessary limitation on 64-bit machines, which
6750 caused (substring ...) to crash on large vectors (Bug#8344).
6751 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6752 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 6753 All variadic functions and their callers changed accordingly.
c5101a77
PE
6754 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6755 * data.c (arith_driver, float_arith_driver): Likewise.
6756 * editfns.c (general_insert_function): Likewise.
6757 * eval.c (struct backtrace.nargs, interactive_p)
6758 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6759 (funcall_lambda, mark_backtrace): Likewise.
6760 * fns.c (concat): Likewise.
6761 * frame.c (x_set_frame_parameters): Likewise.
6762 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6763 0 if not found, not -1. All callers changed.
6764
dd3f25f7
PE
6765 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6766 (stack_copy_size): Now size_t, not int.
6767 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6768
461c2ab9
JB
67692011-03-28 Juanma Barranquero <lekktu@gmail.com>
6770
6771 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6772 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6773 All callers changed.
6774
6775 * lisp.h (multibyte_char_to_unibyte):
6776 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6777 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6778 * character.h (CHAR_TO_BYTE8):
6779 * cmds.c (internal_self_insert):
6780 * editfns.c (general_insert_function):
6781 * keymap.c (push_key_description):
6782 * search.c (Freplace_match):
6783 * xdisp.c (message_dolog, set_message_1): All callers changed.
6784
f6d62986
SM
67852011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6786
6787 * keyboard.c (safe_run_hook_funcall): New function.
6788 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6789 don't set the hook to nil, but remove the offending function instead.
6790 (Qcommand_hook_internal): Remove, unused.
6791 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6792 Vcommand_hook_internal.
6793
6794 * eval.c (enum run_hooks_condition): Remove.
6795 (funcall_nil, funcall_not): New functions.
6796 (run_hook_with_args): Call each function through a `funcall' argument.
6797 Remove `cond' argument, now redundant.
6798 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6799 (Frun_hook_with_args_until_failure): Adjust accordingly.
6800 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6801
1db5b1ad
JB
68022011-03-28 Juanma Barranquero <lekktu@gmail.com>
6803
6804 * dispextern.h (string_buffer_position): Remove declaration.
6805
6806 * print.c (strout): Remove parameter `multibyte', unused since
6807 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6808
6809 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6810 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6811 All callers changed.
6812
6813 * w32.c (_wsa_errlist): Use braces for struct initializers.
6814
6815 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6816 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6817 All callers changed.
6818 (string_buffer_position): Likewise. Also, make static (it's never
6819 used outside xdisp.c).
6820 (cursor_row_p): Remove parameter `w', unused since
6821 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6822 (decode_mode_spec): Remove parameter `precision', introduced during
6823 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6824 All callers changed.
6825
5ffb62aa
JD
68262011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6827
6828 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6829
461c2ab9 68302011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
6831
6832 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6833 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6834 (ns_update_auto_hide_menu_bar): New functions.
6835 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6836 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6837 ns_constrain_all_frames.
6838 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6839 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6840
5c380ffb
JD
68412011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6842
6843 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6844
9af30bdf
GM
68452011-03-27 Glenn Morris <rgm@gnu.org>
6846
6847 * syssignal.h: Replace RETSIGTYPE with void.
6848 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6849 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6850 Replace SIGTYPE with void everywhere.
6851 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6852 * s/template.h (SIGTYPE): Remove commented out definition.
6853
e2abce01
JB
68542011-03-26 Eli Zaretskii <eliz@gnu.org>
6855
6856 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6857 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6858
f868cd8a
JB
68592011-03-26 Juanma Barranquero <lekktu@gmail.com>
6860
59eb0929
JB
6861 * w32.c (read_unc_volume): Use parameter `henum', instead of
6862 global variable `wget_enum_handle'.
6863
6864 * keymap.c (describe_vector): Remove parameters `indices' and
6865 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6866 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6867
f868cd8a
JB
6868 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6869
6870 * keyboard.c (timer_check): Remove parameter `do_it_now',
6871 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6872 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6873 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6874
6875 * keyboard.c (read_char):
6876 * w32menu.c (w32_menu_display_help):
6877 * xmenu.c (show_help_event, menu_help_callback):
6878 Adjust calls to `show_help_echo'.
6879
6880 * gtkutil.c (xg_maybe_add_timer):
6881 * keyboard.c (readable_events):
6882 * process.c (wait_reading_process_output):
6883 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6884
6885 * insdel.c (adjust_markers_gap_motion):
6886 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6887 (gap_left, gap_right): Don't call it.
6888
2ecf6fdb
CY
68892011-03-25 Chong Yidong <cyd@stupidchicken.com>
6890
6891 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6892 incurred during fontification.
6893
6b1f9ba4
JB
68942011-03-25 Juanma Barranquero <lekktu@gmail.com>
6895
6896 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6897 (DEFVAR_PER_BUFFER): Don't pass it.
6898
6899 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6900 (scrolling_window): Don't pass it.
6901
0f4a96b5
JB
69022011-03-25 Juanma Barranquero <lekktu@gmail.com>
6903
6904 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6905
6906 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6907 and `suffix'.
6908 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6909 of variables specific to SELinux and computation of `encoded_absname'.
6910
6911 * image.c (XPutPixel): Remove unused variable `height'.
6912
6913 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6914
6915 * unexw32.c (get_section_info): Remove unused variable `section'.
6916
6917 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6918 (system_process_attributes): Remove unused variable `sess'.
6919 (sys_read): Remove unused variable `err'.
6920
6921 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6922 (w32_wnd_proc): Remove unused variable `isdead'.
6923 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6924 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6925 (x_create_tip_frame): Remove unused variable `tem'.
6926
6927 * w32inevt.c (w32_console_read_socket):
6928 Remove unused variable `no_events'.
6929
6930 * w32term.c (x_draw_composite_glyph_string_foreground):
6931 Remove unused variable `width'.
6932
1149507c
JB
69332011-03-24 Juanma Barranquero <lekktu@gmail.com>
6934
6935 * w32term.c (x_set_glyph_string_clipping):
6936 Don't pass uninitialized region to CombineRgn.
6937
9c88f339
JB
69382011-03-23 Juanma Barranquero <lekktu@gmail.com>
6939
6940 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6941 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6942 (Fx_close_connection): Remove unused variable `i'.
6943
6944 * w32font.c (w32font_draw): Return number of glyphs.
6945 (w32font_open_internal): Remove unused variable `i'.
6946 (w32font_driver): Add missing initializer.
6947
6948 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6949 (fill_in_menu): Remove unused variable `items_added'.
6950
6951 * w32term.c (last_mouse_press_frame): Remove static global variable.
6952 (w32_clip_to_row): Remove unused variable `f'.
6953 (x_delete_terminal): Remove unused variable `i'.
6954
6955 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6956 (NOTHING): Remove unused static global variable.
6957 (uniscribe_check_otf): Remove unused variable `table'.
6958 (uniscribe_font_driver): Add missing initializers.
6959
dee091a3
JD
69602011-03-23 Julien Danjou <julien@danjou.info>
6961
6962 * term.c (Fsuspend_tty, Fresume_tty):
6963 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6964 * window.c (temp_output_buffer_show):
6965 * insdel.c (signal_before_change):
6966 * frame.c (Fhandle_switch_frame):
6967 * fileio.c (Fdo_auto_save):
6968 * emacs.c (Fkill_emacs):
6969 * editfns.c (save_excursion_restore):
6970 * cmds.c (internal_self_insert):
6971 * callint.c (Fcall_interactively):
6972 * buffer.c (Fkill_all_local_variables):
6973 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6974 Use Frun_hooks.
0f4a96b5 6975 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
6976 unconditionnaly since it does the check itself.
6977
2c520ab5 69782011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 6979
c9c49752
PE
6980 Fix more problems found by GCC 4.5.2's static checks.
6981
8abc3f12
PE
6982 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6983 the first time through the loop, since we know p0 < p1 then.
6984 This also avoids a gcc -Wstrict-overflow warning.
6985
a2d26660
PE
6986 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6987 leading to a memory leak, possible in functions like
6988 load_charset_map_from_file that can allocate an unbounded number
b12ef411 6989 of objects (Bug#8318).
a2d26660 6990
916c72e9
PE
6991 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6992 that could (at least in theory) be that large.
6993
19ab8a18
PE
6994 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6995 This is less likely to overflow, and avoids undefined behavior if
6996 overflow does occur. All callers changed. Use strtoul to scan
6997 for the unsigned long integer.
b7cbbd6f
PE
6998 (pint2hrstr): Simplify and tune code slightly.
6999 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 7000
f0641eff
PE
7001 * scroll.c (do_scrolling): Work around GCC bug 48228.
7002 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7003
7f650bb9
PE
7004 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7005 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
7006 (validate_x_resource_name): Simplify count usage.
7007 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 7008
37dd57d1
PE
7009 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7010 fail (Bug#8306).
81e56e61 7011
699979fc 7012 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 7013
401bf9b4
PE
7014 * process.c (Fmake_network_process): Use socklen_t, not int,
7015 where POSIX says socklen_t is required in portable programs.
7016 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 7017 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
7018 (Fmake_network_process, server_accept_connection):
7019 (wait_reading_process_output, read_process_output):
7020 Likewise.
7021
b93aacde
PE
7022 * process.c: Rename or move locals to avoid shadowing.
7023 (list_processes_1, Fmake_network_process):
7024 (read_process_output_error_handler, exec_sentinel_error_handler):
7025 Rename or move locals.
4dc343ee 7026 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 7027 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 7028 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 7029 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 7030 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 7031
af8a867c 7032 Make tparam.h and terminfo.c consistent.
44f230aa
SM
7033 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7034 Include tparam.h instead, since it declares them.
af8a867c
PE
7035 * cm.h (PC): Remove extern decl; tparam.h now does this.
7036 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7037 * terminfo.c: Include tparam.h, to check interfaces.
7038 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7039 (tparam): Adjust signature to match interface in tparam.h;
7040 this removes some undefined behavior. Check that outstring and len
7041 are zero, which they always are with Emacs.
7042 * tparam.h (PC, BC, UP): New extern decls.
7043
0248044d 7044 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 7045 (xftfont_open): Rename locals to avoid shadowing.
0248044d 7046
8ff096c1 7047 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
7048 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7049 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 7050 (ftfont_list): Remove unused local.
49eaafba
PE
7051 (get_adstyle_property, ftfont_pattern_entity):
7052 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7053 Rename locals to avoid shadowing.
8ff096c1 7054
e2be39f6
PE
7055 * xfont.c (xfont_list_family): Mark var as initialized.
7056
c9735e30
PE
7057 * xml.c (make_dom): Now static.
7058
8f5201ae
PE
7059 * composite.c (composition_compute_stop_pos): Rename local to
7060 avoid shadowing.
b246f932
PE
7061 (composition_reseat_it): Remove unused locals.
7062 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 7063 (composition_update_it): Mark var as initialized.
11b61122
PE
7064 (find_automatic_composition): Mark vars as initialized,
7065 with a FIXME (Bug#8290).
8f5201ae 7066
760fbc2c
PE
7067 character.h: Rename locals to avoid shadowing.
7068 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7069 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7070 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7071 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7072 to avoid shadowing.
7073
ff08eb85
PE
7074 * textprop.c (property_change_between_p): Remove; unused.
7075
fc7bf025
PE
7076 * intervals.c (interval_start_pos): Now static.
7077
235d7abc
PE
7078 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7079
44f230aa
SM
7080 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7081 Rename locals to avoid shadowing.
3e7d6594 7082
50060332
PE
7083 * sound.c (wav_play, au_play, Fplay_sound_internal):
7084 Fix pointer signedness.
d01f234b 7085 (alsa_choose_format): Remove unused local var.
c83b8872
PE
7086 (wav_play): Initialize a variable to 0, to prevent undefined
7087 behavior (Bug#8278).
50060332 7088
c4fc4e30
PE
7089 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7090
918436ed
PE
7091 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7092
c939f91b
PE
7093 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7094 clobbering (Bug#8298).
b9c7f648
PE
7095 * sysdep.c (sys_subshell): Likewise.
7096 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 7097
6bd8c144
PE
7098 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7099 This should get cleaned up, so that child_setup has the
7100 same signature on all platforms.
7101
7710357c 7102 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 7103 (relocate_fd): Rename locals to avoid shadowing.
7710357c 7104
c59da222
CY
71052011-03-22 Chong Yidong <cyd@stupidchicken.com>
7106
7107 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7108 not to be necessary, and produces flickering.
7109
66b87493
GM
71102011-03-20 Glenn Morris <rgm@gnu.org>
7111
7112 * config.in: Remove file.
7113
45b6f6d5
JB
71142011-03-20 Juanma Barranquero <lekktu@gmail.com>
7115
7116 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7117 are now in src/globals.h.
7118 (syms_of_minibuf): Remove spurious & from previous change.
7119
3ec03f7e
LL
71202011-03-20 Leo <sdl.web@gmail.com>
7121
7122 * minibuf.c (completing-read-function): New variable.
7123 (completing-read-default): Rename from completing-read.
7124 (completing-read): Call completing-read-function.
7125
b14e3e21
CY
71262011-03-19 Juanma Barranquero <lekktu@gmail.com>
7127
7128 * xfaces.c (Fx_load_color_file):
7129 Read color file from absolute filename (bug#8250).
7130
f2b726e6
JB
71312011-03-19 Juanma Barranquero <lekktu@gmail.com>
7132
7133 * makefile.w32-in: Update dependencies.
7134
09f6ff02
EZ
71352011-03-17 Eli Zaretskii <eliz@gnu.org>
7136
7137 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7138
29a6015a
PE
71392011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7140
a3a6c54e
PE
7141 Fix more problems found by GCC 4.5.2's static checks.
7142
b766f867
PE
7143 * process.c (make_serial_process_unwind, send_process_trap):
7144 (sigchld_handler): Now static.
7145
be02381c
PE
7146 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7147 That way, the code declares only the vars that it needs.
7148 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7149 * s/cygwin.h (PTY_ITERATION): Likewise.
7150 * s/darwin.h (PTY_ITERATION): Likewise.
7151 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7152
57048744
PE
7153 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7154 * process.c (allocate_pty): Don't declare stb unless it's needed.
7155
7914961c 7156 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
7157 (CONSTANTLIM): Remove; unused.
7158 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7159 Define only if needed.
7914961c 7160
b3967b18
PE
7161 * unexelf.c (unexec): Name an expression,
7162 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
7163 Use a different way to cause a compilation error if anyone uses
7164 n rather than nn, a way that does not involve shadowing.
73366a00 7165 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 7166
29a6015a
PE
7167 * deps.mk (unexalpha.o): Remove; unused.
7168
43cfc33e 7169 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 7170 * unexec.h: New file.
ce701a33
PE
7171 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7172 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7173 Depend on unexec.h.
7174 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7175 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7176 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 7177 Change as necessary to match prototype in unexec.h.
ce701a33 7178
01f44d5a
PE
7179 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7180 shadowing.
4f63c6bb 7181 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 7182
a6670b0b
PE
7183 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7184 Rename locals to avoid shadowing.
7185
cef2010d 7186 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 7187 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 7188
d4d7173a
PE
7189 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7190
f08b802a
PE
7191 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7192 warning when compiling print.c.
7193
3ddb0639
PE
7194 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7195 instead of using an uninitialized var.
5ad03b97 7196 (font_sort_entities): Mark var as initialized.
3ddb0639 7197
170a2692
PE
7198 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7199
e663c700
PE
7200 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7201 pointers to constants.
89bc529a 7202 (font_parse_fcname): Remove unused vars.
7b81e2d0 7203 (font_delete_unmatched): Now static.
ea838e10 7204 (font_get_spec): Remove; unused.
13a547c6
PE
7205 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7206 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7207 Rename or move locals to avoid shadowing.
e663c700 7208
2a80c887 7209 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 7210 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 7211
1384fa33 7212 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 7213 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 7214
8b2c52e9
PE
7215 * alloc.c (mark_backtrace): Move decl from here ...
7216 * lisp.h: ... to here, so that it can be checked.
7217
475545b5 7218 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 7219 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
7220 (lisp_indirect_variable): Name an expression,
7221 to avoid gcc -Wbad-function-cast warning.
1faed8ae 7222 (Fdefvar): Rename locals to avoid shadowing.
475545b5 7223
b1349114 7224 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 7225 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 7226 Use const pointer when appropriate.
b1349114 7227
a2928364
PE
7228 * lisp.h (get_system_name, get_operating_system_release):
7229 Move decls here, to check interfaces.
7230 * process.c (get_operating_system_release): Move decl to lisp.h.
7231 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
7232 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7233 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7234 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
7235 (Fformat_time_string, Fencode_time, Finsert_char):
7236 (Ftranslate_region_internal, Fformat):
7237 Rename or remove local vars to avoid shadowing.
9710023e 7238 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 7239
a415e694
PE
7240 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7241 avoid shadowing.
7242
8ef4622d
PE
7243 * lisp.h (eassert): Check that the argument compiles, even if
7244 ENABLE_CHECKING is not defined.
7245
946f9a5b
PE
7246 * data.c (Findirect_variable): Name an expression, to avoid
7247 gcc -Wbad-function-cast warning.
112396d6 7248 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 7249 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
7250 (Fmake_variable_buffer_local, Fmake_local_variable):
7251 Mark variables as initialized.
52746918 7252 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 7253
e5aab7e7 7254 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
7255 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7256 Rename locals to avoid shadowing.
dff45157
PE
7257 (mark_stack): Move local variables into the #ifdef region where
7258 they're used.
7bc26fdb
PE
7259 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7260 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7261 needed otherwise.
7262 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7263 (GC_STRING_CHARS): Remove; not used.
d40d4be1 7264 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 7265
e5aab7e7
PE
7266 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7267 avoids undefined behavior in theory.
7268
4da60324
PE
7269 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7270
88043301
PE
7271 Use functions, not macros, for up- and down-casing (Bug#8254).
7272 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7273 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7274 to use the following functions instead of these macros.
7275 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7276 EMACS_INT, since callers assume the returned value fits in int.
7277 (upcase1): Likewise, for UPCASE_TABLE.
7278 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 7279 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 7280 the race-condition problem in the old DOWNCASE.
88043301 7281
19ed5445
PE
7282 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7283 Rename locals to avoid shadowing.
7284 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
7285 (regex_compile, re_search_2, re_match_2_internal):
7286 Remove unused local vars.
952db0d7
PE
7287 (FREE_VAR): Rewrite so as not to use empty "else",
7288 which gcc can warn about.
da053e48 7289 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
7290 (RETALLOC_IF): Define only if needed.
7291 (WORDCHAR_P): Likewise. This one is never needed, but is used
7292 only in a comment talking about a compiler bug, so put inside
7293 the #if 0 of that comment.
7294 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7295 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7296 Remove; unused.
19ed5445 7297
1f3561e4 7298 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
7299 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7300 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 7301
ded6f8f7
PE
7302 * search.c (simple_search): Remove unused var.
7303
dbd37a95
PE
7304 * dired.c (compile_pattern): Move decl from here ...
7305 * lisp.h: ... to here, so that it can be checked.
7306 (struct re_registers): New forward decl.
7307
7e47afad
PE
7308 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7309
85f24f61
PE
7310 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7311 All uses changed.
7312 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7313 Rename locals to avoid shadowing.
5671df8f 7314 (Fvertical_motion): Mark locals as initialized.
85f24f61 7315
181aa2be 7316 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 7317 (casify_region): Mark local as initialized.
181aa2be 7318
930d429c
PE
7319 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7320
7082eac6
PE
7321 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7322 New macros, so that the caller can use some names other than
7323 gcpro1, gcpro2, etc.
7324 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7325 of the new macros.
7326 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7327 argument, for consistency with GCPRO2_VAR, etc: it is now the
7328 prefix of the variable, not the variable itself. All uses
7329 changed.
38b2c076
PE
7330 * dired.c (directory_files_internal, file_name_completion):
7331 Rename locals to avoid shadowing.
7332
15206ed9
PE
7333 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7334 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7335 dired.c's scmp function, had undefined behavior.
7336 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7337 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7338 * buffer.h: ... to here, because these macros use current_buffer,
7339 and the new implementation with inline functions needs to have
7340 current_buffer in scope now, rather than later when the macros
7341 are used.
7342 (downcase, upcase1): New static inline functions.
7343 (DOWNCASE, UPCASE1): Reimplement using these functions.
7344 This avoids undefined behavior in expressions like
7345 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7346 from race conditions in accessing the global variables
7347 case_temp1 and case_temp2.
7348 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7349 * lisp.h (case_temp1, case_temp2): Remove their decls.
7350 * character.h (ASCII_CHAR_P): Move from here ...
7351 * lisp.h: ... to here, so that the inline functions mentioned
7352 above can use them.
7353
4a6bea26
PE
7354 * dired.c (directory_files_internal_unwind): Now static.
7355
f14b7e14
PE
7356 * fileio.c (file_name_as_directory, directory_file_name):
7357 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7358 Now static.
2893f146
PE
7359 (file_name_as_directory): Use const pointers when appropriate.
7360 (Fexpand_file_name): Likewise. In particular, newdir might
7361 point at constant storage, so make it a const pointer.
fd4ead52 7362 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
7363 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7364 signedness issues.
f839df0c
PE
7365 (Fset_file_times, Finsert_file_contents, auto_save_error):
7366 Rename locals to avoid shadowing.
f14b7e14 7367
5716756e 7368 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
7369 (Ftry_completion, Fall_completions): Rename or remove locals
7370 to avoid shadowing.
5716756e 7371
b4c3046a
PE
7372 * marker.c (bytepos_to_charpos): Remove; unused.
7373
b45db522
PE
7374 * lisp.h (verify_bytepos, count_markers): New decls,
7375 so that gcc does not warn that these functions aren't declared.
7376
85876d07
PE
7377 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7378 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 7379 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 7380 (copy_text): Remove unused local var.
85876d07 7381
03d78a21 7382 * filelock.c (within_one_second): Now static.
b3dd38ab 7383 (lock_file_1): Rename local to avoid shadowing.
03d78a21 7384
5df8f01b
PE
7385 * buffer.c (fix_overlays_before): Mark locals as initialized.
7386 (fix_start_end_in_overlays): Likewise. This function should be
7387 simplified by using pointers-to-pointers, but that's a different
7388 matter.
b1d876f1 7389 (switch_to_buffer_1): Now static.
8f54f30a
PE
7390 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7391 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 7392
a70072c9 7393 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 7394 Fix pointer signedness issue.
edced198
PE
7395 (sys_subshell): Mark local as volatile if checking for lint,
7396 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 7397 (MAXPATHLEN): Define only if needed.
a70072c9 7398
a0977c44
PE
7399 * process.c (serial_open, serial_configure): Move decls from here ...
7400 * systty.h: ... to here, so that they can be checked.
7401
a884fdcc
PE
7402 * fns.c (get_random, seed_random): Move extern decls from here ...
7403 * lisp.h: ... to here, so that they can be checked.
7404
604efe86 7405 * sysdep.c (reset_io): Now static.
b8950c94 7406 (wait_for_termination_signal): Remove; unused.
604efe86 7407
38fc62d9
PE
7408 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7409 (copy_keymap_item, append_key, push_text_char_description):
7410 Now static.
1004a21a 7411 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 7412 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
7413 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7414 (describe_map_tree):
7415 Rename locals to avoid shadowing.
38fc62d9 7416
2f2650da
PE
7417 * keyboard.c: Declare functions static if they are not used elsewhere.
7418 (echo_char, echo_dash, cmd_error, top_level_2):
7419 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
7420 (read_char, kbd_buffer_get_event, make_lispy_position):
7421 (make_lispy_event, make_lispy_movement, apply_modifiers):
7422 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7423 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7424 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 7425 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 7426 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 7427
a053e86c 7428 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
7429 (mark_kboards): Move decl here ...
7430 * alloc.c (mark_kboards): ... from here.
a053e86c 7431
4752793e
PE
7432 * lisp.h (force_auto_save_soon): New decl.
7433
74f10ca7 7434 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
7435 (DEFINE_DUMMY_FUNCTION): New macro.
7436 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7437 Use it.
c03cd23f
PE
7438 (main): Add casts to avoid warnings
7439 if GCC considers string literals to be constants.
74f10ca7 7440
022e70d4
PE
7441 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7442
59d6fe83
PE
7443 * dbusbind.c: Pointer signedness fixes.
7444 (xd_signature, xd_append_arg, xd_initialize):
7445 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7446 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7447 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7448 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7449
78320123
PE
7450 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7451 if GCC considers string literals to be constants.
49cebcca 7452 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 7453
35ac2a97
SM
74542011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7455
fb103ca9
SM
7456 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7457 (print_preprocess, print_object): New macro to fix last change.
7458
35ac2a97
SM
7459 * print.c (print_preprocess): Don't forget font objects.
7460
62973b41
JB
74612011-03-16 Juanma Barranquero <lekktu@gmail.com>
7462
7463 * emacs.c (USAGE3): Doc fixes.
7464
0e48bb22
AS
74652011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7466
7467 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7468 structure.
7469
7684e57b
JB
74702011-03-14 Juanma Barranquero <lekktu@gmail.com>
7471
7472 * lisp.h (VWindow_system, Qfile_name_history):
7473 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7474 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7475 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7476
7477 * w32select.c: Don't #include "keyboard.h".
c96bbc66 7478 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
7479
7480 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7481 * w32console.c (detect_input_pending, read_input_pending)
7482 (encode_terminal_code):
7483 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7484 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7485 (w32_system_caret_y, Qfile_name_history):
7486 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7487 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7488 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7489 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7490 * w32proc.c (Qlocal, report_file_error):
7491 * w32term.c (Vwindow_system, updating_frame):
7492 * w32uniscribe.c (initialized, uniscribe_font_driver):
7493 Remove unneeded extern declarations.
7494
2aa46d6c
CY
74952011-03-14 Chong Yidong <cyd@stupidchicken.com>
7496
c96bbc66 7497 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 7498
cffc6f3b
CY
74992011-03-13 Chong Yidong <cyd@stupidchicken.com>
7500
7501 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7502 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7503 These macros can no longer be used for assignment.
7504
44f230aa
SM
7505 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7506 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
7507 (record_buffer_markers, fetch_buffer_markers): New functions for
7508 recording and fetching special buffer markers.
7509 (set_buffer_internal_1, set_buffer_temp): Use them.
7510
7511 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7512
7513 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7514
7515 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7516 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7517
7518 * xdisp.c (hscroll_window_tree):
7519 (reconsider_clip_changes): Use PT instead of BUF_PT.
7520
d251f04b
EZ
75212011-03-13 Eli Zaretskii <eliz@gnu.org>
7522
7523 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7524 $(EMACS_ROOT)/lib/intprops.h.
7525
f0c77cd1
PE
75262011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7527
3eca4629
PE
7528 Fix more problems found by GCC 4.5.2's static checks.
7529
7c86ee98
PE
7530 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7531 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
7532 (xg_free_frame_widgets): Make it clear that a local variable is
7533 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
7534 (gdk_window_get_screen): Make it clear that this macro is needed
7535 only if USE_GTK_TOOLTIP.
1e5524e7
PE
7536 (int_gtk_range_get_value): New function, which avoids a diagnostic
7537 from gcc -Wbad-function-cast.
7538 (xg_set_toolkit_scroll_bar_thumb): Use it.
7539 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7540 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
7541 (get_utf8_string, xg_get_file_with_chooser):
7542 Rename locals to avoid shadowing.
7543 (create_dialog): Move locals to avoid shadowing.
7c86ee98 7544
41729b81
PE
7545 * xgselect.c (xg_select): Remove unused var.
7546
f0c77cd1
PE
7547 * image.c (four_corners_best): Mark locals as initialized.
7548 (gif_load): Initialize transparent_p to zero (Bug#8238).
7549 Mark another local as initialized.
ec6cf4c6 7550 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 7551
ce0ad53d 7552 * image.c (clear_image_cache): Now static.
d5d5a617 7553 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 7554 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
7555 (x_edge_detection): Remove unnecessary cast that
7556 gcc -Wbad-function-cast diagnoses.
2037898d 7557 (gif_load): Fix pointer signedness.
6ae141d6
PE
7558 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7559 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 7560
33383987 75612011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 7562
d32df629
PE
7563 Improve quality of tests for time stamp overflow.
7564 For example, without this patch (encode-time 0 0 0 1 1
7565 1152921504606846976) returns the obviously-bogus value (-948597
7566 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7567 reports time overflow. See
7568 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
7569 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7570 * editfns.c: Include limits.h and intprops.h.
7571 (TIME_T_MIN, TIME_T_MAX): New macros.
7572 (time_overflow): Move earlier, to before first use.
7573 (hi_time, lo_time): New functions, for an accurate test for
7574 out-of-range times.
7575 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7576 (Fget_internal_run_time): Don't assume time_t fits in int.
7577 (make_time): Use list2 instead of Fcons twice.
7578 (Fdecode_time): More accurate test for out-of-range times.
7579 (check_tm_member): New function.
7580 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
7581 (lisp_time_argument): Don't rely on undefined left-shift and
7582 right-shift behavior when checking for time stamp overflow.
8be6f318 7583
fe31d94c
PE
7584 * editfns.c (time_overflow): New function, refactoring common code.
7585 (Fformat_time_string, Fdecode_time, Fencode_time):
7586 (Fcurrent_time_string): Use it.
7587
8be6f318
PE
7588 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7589 * dired.c (make_time): Move to ...
7590 * editfns.c (make_time): ... here.
7591 * systime.h: Note the move.
7592
09d9db2c 75932011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 7594
126bc0dc
YM
7595 * fringe.c (update_window_fringes): Remove unused variables.
7596
c47cbdfd
YM
7597 * unexmacosx.c (copy_data_segment): Also copy __got section.
7598 (Bug#8223)
7599
7ac80be9
EZ
76002011-03-12 Eli Zaretskii <eliz@gnu.org>
7601
c96bbc66 7602 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
7603 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7604 Constify `char *' arguments and their references according to
7605 prototypes in tparam.h.
7606
ecb0f94d 7607 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 7608
7ac80be9
EZ
7609 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7610 Adapt all references accordingly.
7611
7612 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7613
ef1fd07e
TT
76142011-03-11 Tom Tromey <tromey@redhat.com>
7615
7616 * buffer.c (syms_of_buffer): Remove obsolete comment.
7617
7ef4b50c
EZ
76182011-03-11 Eli Zaretskii <eliz@gnu.org>
7619
7620 * termhooks.h (encode_terminal_code): Declare prototype.
7621
7622 * msdos.c (encode_terminal_code): Don't declare prototype.
7623
7624 * term.c (encode_terminal_code): Now external again, used by
7625 w32console.c and msdos.c.
7626
44f230aa
SM
7627 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7628 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 7629
4b1ec863 76302011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 7631
1714f52b 7632 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 7633
4b1ec863
PE
7634 * fringe.c (update_window_fringes): Mark locals as initialized
7635 (Bug#8227).
7636 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 7637
524c7aa6
PE
7638 * alloc.c (mark_fringe_data): Move decl from here ...
7639 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7640 to check its interface.
7641 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7642
a5c0af81 7643 * fontset.c (free_realized_fontset): Now static.
7519b8cd 7644 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 7645 (fontset_font): Mark local as initialized.
a9a06e0b 7646 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 7647
b4716021
PE
7648 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7649
811e9bac 7650 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 7651 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
7652 (x_own_selection, Fx_disown_selection_internal): Rename locals
7653 to avoid shadowing.
7654 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 7655
7e3ab302
PE
7656 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7657 so that the caller can use some name other than gcpro1.
7658 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
7659 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7660 (Fx_backspace_delete_keys_p):
7661 Use them to avoid shadowing, and rename vars to avoid shadowing.
7662 (x_decode_color, x_set_name, x_window): Now static.
6b437900 7663 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 7664 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
7665 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7666 Remove unused locals.
7e3ab302
PE
7667 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7668 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7669 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7670 macros.
f78faa98 7671
e2b13473
PE
7672 * xterm.h (x_mouse_leave): New decl.
7673
77f23912
PE
7674 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7675 Remove unused functions.
cdf4ba58
PE
7676 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7677 (x_calc_absolute_position): Now static.
7411c686 7678 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 7679 Don't declare local "event" unless it's used.
ed7bf3a5
PE
7680 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7681 unless they are used.
38d0b34a
PE
7682 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7683 (x_fatal_error_signal): Remove; not used.
a6067996
PE
7684 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7685 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7686 (x_error_catcher, x_connection_closed, x_error_handler):
7687 (x_error_quitter, xembed_send_message, x_iconify_frame):
7688 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 7689 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 7690 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 7691
44f230aa
SM
7692 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7693 Rename or move locals to avoid shadowing.
6b463e58 7694 (tty_defined_color, merge_face_heights): Now static.
5967d051 7695 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
7696 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7697 does not deduce is never used uninitialized.
73719eba
PE
7698 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7699 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 7700
426994c3 7701 * terminal.c (store_terminal_param): Now static.
5489860b 7702
032f1620 7703 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 7704 (set_frame_menubar): Remove unused local.
d4323972 7705 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
7706 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7707 since they might point to immutable storage.
281585b0
PE
7708 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7709 since it's unused otherwise.
032f1620 7710
367c19e5 7711 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 7712 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
7713 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7714 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 7715 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
7716 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7717 does not deduce are never used uninitialized.
70739cbe 7718
07b48fa9
PE
7719 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7720
8868a238 7721 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
7722 * window.c (window_loop, size_window):
7723 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 7724
7e5cf297 7725 * window.c (display_buffer): Now static.
d6550a9f
PE
7726 (size_window): Mark variables that gcc -Wuninitialized
7727 does not deduce are never used uninitialized.
a586633d
PE
7728 * window.h (check_all_windows): New decl, to forestall
7729 gcc -Wmissing-prototypes diagnostic.
5b555da1 7730 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 7731
f6095868
PE
7732 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7733 shadowing.
7734 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
7735 Include <limits.h>.
7736 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7737 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
7738 (load_charset_map): Mark variables that gcc -Wuninitialized
7739 does not deduce are never used uninitialized.
53df7c11 7740 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 7741
f38b440c
PE
7742 * coding.c (coding_set_source, coding_set_destination):
7743 Use "else { /* comment */ }" rather than "else /* comment */;"
7744 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
7745 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7746 a block, when the outer 'i' will do.
7747 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7748 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7749 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7750 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7751 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7752 Rename locals to avoid shadowing.
7753 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
7754 * coding.c (emacs_mule_char, encode_invocation_designation):
7755 Now static, since they're not used elsewhere.
413bb2db 7756 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 7757 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
7758 (decode_coding_emacs_mule): Mark variables that gcc
7759 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
7760 (detect_coding_iso_2022): Initialize a local variable that might
7761 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 7762 this initialization is needed. (Bug#8211)
5f58e762
PE
7763 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7764 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7765 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7766 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7767 Remove unused macros.
f38b440c 7768
232b38b9 7769 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 7770 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 7771 * character.c (string_count_byte8): Likewise.
232b38b9 7772
fb90da1b
PE
7773 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7774 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7775
fb93dbc2
PE
7776 * chartab.c (copy_sub_char_table): Now static, since it's not used
7777 elsewhere.
5c156ace
PE
7778 (sub_char_table_ref_and_range, char_table_ref_and_range):
7779 Rename locals to avoid shadowing.
bbcd0949 7780 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 7781
7d3b3862 7782 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 7783 (BIDI_BOB): Remove unused macro.
7d3b3862 7784
6be7d3da
PE
7785 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7786 deduce are never used uninitialized.
c2ed9c8b 7787 * term.c (encode_terminal_code): Likewise.
6be7d3da 7788
75f8807f 7789 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 7790
50938595
PE
7791 * tparam.h: New file.
7792 * term.c, tparam.h: Include it.
7793 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7794 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7795 Move these decls to tparam.h, and make them agree with what
7796 is actually in tparam.c. The previous trick of using incompatible
7797 decls in different modules does not conform to the C standard.
7798 All callers of tparam changed to use tparam's actual API.
7799 * tparam.c (tparam1, tparam, tgoto):
7800 Use const pointers where appropriate.
7801
fbceeba2
PE
7802 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7803 * cm.h (struct cm): Likewise.
7804 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7805 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7806 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7807 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7808 (turn_on_face, init_tty): Likewise.
7809 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 7810
7f3f1250
PE
7811 * term.c (term_mouse_position): Rename local to avoid shadowing.
7812
e6ca6543
PE
7813 * alloc.c (mark_ttys): Move decl from here ...
7814 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7815
c40f8d15
AS
78162011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7817
7818 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7819
cfe0661d
JB
78202011-03-09 Juanma Barranquero <lekktu@gmail.com>
7821
7822 * search.c (compile_pattern_1): Remove argument regp, unused since
7823 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7824 (compile_pattern): Don't pass it.
7825
0afb4571
J
78262011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7827
7828 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7829 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7830 for ! HAVE_GTK3.
7831 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7832
7833 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7834
7835 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7836 gdk_window_get_screen, gdk_window_get_geometry,
7837 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7838 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7839 (xg_get_pixbuf_from_pixmap): New function.
7840 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7841 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7842 Call xg_get_pixbuf_from_pixmap instead of
7843 gdk_pixbuf_get_from_drawable.
7844 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7845 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7846 (xg_check_special_colors): Use GtkStyleContext and its functions
7847 for HAVE_GTK3.
7848 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7849 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7850 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
7851 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7852 Call gtk_widget_get_preferred_size.
0afb4571
J
7853 (xg_frame_resized): gdk_window_get_geometry only takes 5
7854 parameters.
44f230aa
SM
7855 (xg_win_to_widget, xg_event_is_for_menubar):
7856 Call gdk_x11_window_lookup_for_display.
0afb4571
J
7857 (xg_set_widget_bg): New function.
7858 (delete_cb): New function.
895009e1 7859 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
7860 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7861 (xg_set_background_color): Call xg_set_widget_bg.
7862 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7863 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7864 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7865 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7866 if ! HAVE_GTK3.
7867 (update_frame_tool_bar): Call gtk_widget_hide.
7868 (xg_initialize): Use GDK_KEY_g.
7869
7870 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7871 if ! HAVE_GTK3
7872 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7873
7874 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7875 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7876 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7877
1c2cc4ef
JB
78782011-03-08 Juanma Barranquero <lekktu@gmail.com>
7879
7880 * w32xfns.c (select_palette): Check success of RealizePalette against
7881 GDI_ERROR, not zero.
7882
33383987 7883See ChangeLog.11 for earlier changes.
aac0c6e3
MR
7884
7885;; Local Variables:
7886;; coding: utf-8
aac0c6e3
MR
7887;; End:
7888
33383987 7889 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
7890
7891 This file is part of GNU Emacs.
7892
7893 GNU Emacs is free software: you can redistribute it and/or modify
7894 it under the terms of the GNU General Public License as published by
7895 the Free Software Foundation, either version 3 of the License, or
7896 (at your option) any later version.
7897
7898 GNU Emacs is distributed in the hope that it will be useful,
7899 but WITHOUT ANY WARRANTY; without even the implied warranty of
7900 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7901 GNU General Public License for more details.
7902
7903 You should have received a copy of the GNU General Public License
7904 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.