ChangeLog merge fix
[bpt/emacs.git] / src / ChangeLog
CommitLineData
ca34e0be
PE
12012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2
3 Pacify gcc -Wdouble-precision when using Xaw.
4 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
5 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
6 Use 'float' consistently, rather than 'float' in most places
7 and 'double' in a couple of places.
8
efc00ab1 92012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
10
11 * xdisp.c (handle_stop): Detect whether we have overlay strings
12 loaded by testing it->current.overlay_string_index to be
13 non-negative, instead of checking whether n_overlay_strings is
14 positive. (Bug#11587)
15
efc00ab1 162012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
17
18 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
19
20 * doc.c (Fsubstitute_command_keys): Doc fix.
21
efc00ab1 222012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
23
24 * search.c (search_buffer): Remove calls to
25 r_alloc_inhibit_buffer_relocation, as it is now called by
26 maybe_unify_char, which was the cause of relocation of buffer text
27 in bug#11519.
28
efc00ab1 292012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
30
31 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
32 for the duration of call to load_charset, to avoid problems with
33 callers of maybe_unify_char that access buffer text through C
34 pointers.
35
36 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
37 decrement the inhibition flag, instead of just setting or
38 resetting it.
39
ba93a187
PE
402012-05-31 Paul Eggert <eggert@cs.ucla.edu>
41
42 Remove obsolete '#define static' cruft.
43 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
44 This #undef was "temporary" in 2000; it is no longer needed
45 now that '#define static' has gone away.
46 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
47 (gray_bitmap_bits): Remove; no longer needed.
48 All uses replaced with definiens.
49 * xterm.c: Include "bitmaps/gray.xbm".
50
9e4bf381
PE
512012-05-30 Paul Eggert <eggert@cs.ucla.edu>
52
53 Clean up __executable_start, monstartup when --enable-profiling.
54 The following changes affect the code only when profiling.
55 * dispnew.c (__executable_start): Rename from safe_bcopy.
56 Define only on platforms that need it.
57 * emacs.c: Include <sys/gmon.h> when profiling.
58 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
59 (__executable_start): Remove decl, since lisp.h does it now.
60 (safe_bcopy): Remove decl; no longer has that name.
61 (main): Coalesce #if into single bit of code, for simplicity.
62 Cast pointers to uintptr_t, since standard libraries want integers
63 and not pointers.
64 * lisp.h (__executable_start): New decl.
65
32d72c2f
GM
662012-05-31 Glenn Morris <rgm@gnu.org>
67
68 * image.c (Fimagemagick_types): Doc fix.
69
baac5bc7
JM
702012-05-30 Jim Meyering <meyering@redhat.com>
71
72 * callproc.c (Fcall_process_region): Include directory component
73 in mkstemp error message (Bug#11586).
74
72cb32cf
PE
752012-05-30 Paul Eggert <eggert@cs.ucla.edu>
76
77 * alloc.c, lisp.h (make_pure_vector): Now static.
78
61b108cc
SM
792012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
80
81 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
82 Move to byte-run.el.
83 (Fautoload): Do the hash-doc more carefully.
84 * data.c (Fdefalias): Purify definition, except for keymaps.
85 (Qdefun): Move from eval.c.
86 * lisp.h (Qdefun): Remove.
87 * lread.c (read1): Tiny simplification.
88
471fe23d
TN
892012-05-29 Troels Nielsen <bn.troels@gmail.com>
90
934f3f58 91 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
92 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
93 Bug#9642, but explicitly check that the buffer the overlay would
94 be moved to is live and rearrange lines to make sure that errors
95 will not put the overlay in an inconsistent state.
96 (Fdelete_overlay): Cosmetics.
97
85d0efd1
EZ
982012-05-28 Eli Zaretskii <eliz@gnu.org>
99
100 * w32term.c (my_bring_window_to_top): New function.
101 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
102 could be different from the original one.
103 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
104 (Bug#11513)
105
106 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
107 by calling BringWindowToTop.
108
109 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
110 (WM_EMACS_END): Increase by one.
111
da92a98c
PE
1122012-05-28 Paul Eggert <eggert@cs.ucla.edu>
113
114 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
115 This avoids undefined behavior that might cause the eassert
116 to not catch an out-of-range value.
117
74d1f848
JB
1182012-05-28 Juanma Barranquero <lekktu@gmail.com>
119
120 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
121 Update dependencies.
122
9e1a06fc
EZ
1232012-05-27 Eli Zaretskii <eliz@gnu.org>
124
125 * bidi.c (bidi_mirror_char): Fix last change.
126
f3dd7312
AS
1272012-05-27 Andreas Schwab <schwab@linux-m68k.org>
128
129 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
130 when referring to sectname field in printf format.
131
81899c91
PE
1322012-05-27 Paul Eggert <eggert@cs.ucla.edu>
133
57b81a9f
PE
134 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
135 Only r_alloc_inhibit_buffer_relocation needed to be added;
136 the others were already declared.
137
81899c91
PE
138 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
139 before checking whether it's out of range. Put the check inside
140 eassert. See
141 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
142
33017faf 1432012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
144
145 * callproc.c (Fcall_process): Restore a line that was accidentally
146 commented out in the 2011-02-13 change (bug#11547).
147
33017faf 1482012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
149
150 * lisp.h [REL_ALLOC]: Add prototypes for external functions
151 defined on ralloc.c.
152
153 * buffer.c [REL_ALLOC]: Remove prototypes of
154 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
155 they are now on lisp.h.
156
157 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
158
159 * search.c (search_buffer): Use it to inhibit relocation of buffer
160 text while re_search_2 is doing its job, because re_search_2 is
161 passed C pointers to buffer text. (Bug#11519)
162
23415acf
EZ
163 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
164 Update value to 24.
165
44e27368
EZ
166 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
167 state after an additional call to move_it_in_display_line_to, keep
168 the values of it->max_ascent and it->max_descent found for the
169 entire line.
170 (pos_visible_p): Revert the comparison against bottom_y to what it
171 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
172 (Bug#11464)
173
c1892f11
PE
1742012-05-26 Paul Eggert <eggert@cs.ucla.edu>
175
176 Fix coding-related core dumps with gcc -ftrapv.
177 The code was computing A - B, where A and B are pointers, and B is
178 random garbage. This can lead to core dumps on platforms that
179 have special pointer registers, and it also leads to core dumps on
180 x86-64 when compiled with gcc -ftrapv. The fix is to compute
181 A - B only when B is initialized properly.
182 * coding.c (coding_set_source, coding_set_destination): Return void.
183 (coding_change_source, coding_change_destinations): New functions,
184 with the old behaviors of coding_set_source and coding_set_destination.
185 All callers that need an offset changed to use these new functions.
186
eb7afdad
GM
1872012-05-26 Glenn Morris <rgm@gnu.org>
188
189 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
190
f12fdf02
EZ
1912012-05-26 Eli Zaretskii <eliz@gnu.org>
192
53a63be6 193 Extend mouse support on W32 text-mode console.
61b108cc
SM
194 * xdisp.c (draw_row_with_mouse_face):
195 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 196
eb3f6f01 197 * w32console.c: Include window.h.
61b108cc
SM
198 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
199 New functions.
eb3f6f01
EZ
200 (initialize_w32_display): Initialize mouse-highlight data.
201
53a63be6
EZ
202 * w32inevt.c: Include termchar.h and window.h.
203 (do_mouse_event): Support mouse-autoselect-window. When the mouse
204 moves, call note_mouse_highlight. If help_echo changed, call
205 gen_help_event to produce help-echo message in the echo area.
206 Call clear_mouse_face if mouse_face_hidden is set in the mouse
207 highlight info.
208
4cfd81f6
PE
2092012-05-26 Paul Eggert <eggert@cs.ucla.edu>
210
211 * lread.c (read1): Simplify slightly to avoid an overflow warning
212 with GCC 4.7.0 on x86-64.
213
4446092a
EZ
2142012-05-26 Eli Zaretskii <eliz@gnu.org>
215
216 * bidi.c (bidi_mirror_char): Revert last change: an int is
217 definitely wide enough here.
218
42b2a986 2192012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 220
42b2a986 221 Fix integer width and related bugs (Bug#9874).
eb106a49 222 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
223 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
224 (string_bytes, check_sblock, allocate_string_data):
225 (compact_small_strings, Fmake_bool_vector, make_string)
226 (make_unibyte_string, make_multibyte_string)
227 (make_string_from_bytes, make_specified_string)
228 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
229 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
230 (mark_vectorlike):
231 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
232 (allocate_pseudovector):
233 Use int, not EMACS_INT, where int is wide enough.
234 (inhibit_garbage_collection, Fgarbage_collect):
235 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
236 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
237 int might not be wide enough.
238 (bidi_cache_search, bidi_cache_find, bidi_init_it)
239 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
240 (bidi_at_paragraph_end, bidi_find_paragraph_start)
241 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
242 (bidi_level_of_next_char, bidi_move_to_visually_next):
243 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
244 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
245 (Fkill_buffer, Fset_buffer_major_mode)
246 (advance_to_char_boundary, Fbuffer_swap_text)
247 (Fset_buffer_multibyte, overlays_at, overlays_in)
248 (overlay_touches_p, struct sortvec, record_overlay_string)
249 (overlay_strings, recenter_overlay_lists)
250 (adjust_overlays_for_insert, adjust_overlays_for_delete)
251 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
252 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
253 (Foverlay_recenter, last_overlay_modification_hooks_used)
254 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
255 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
256 (validate_region): Omit unnecessary test for b <= e,
257 since that's guaranteed by the previous test.
d311d28c
PE
258 (adjust_overlays_for_delete): Avoid pos + length overflow.
259 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
260 (report_overlay_modification):
261 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
262 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
263 Omit pointer cast, which isn't needed anyway, and doesn't work
264 after the EMACS_INT -> ptrdiff_t change.
02481186 265 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
266 * buffer.h: Adjust decls to match defn changes elsewhere.
267 (struct buffer_text, struct buffer):
268 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
269 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
270 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
271 not int, to avoid needless 32-bit limit on 64-bit hosts.
272 (exec_byte_code): Use tighter memory-full test, one that checks
273 for alloca overflow. Don't compute the address of the object just
274 before an array, as that's not portable. Use EMACS_INT, not
275 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
276 * callint.c (Fcall_interactively):
277 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
278 * callproc.c (call_process_kill, Fcall_process):
279 Don't assume pid_t fits into an Emacs fixnum.
280 (call_process_cleanup, Fcall_process, child_setup):
281 Don't assume pid_t fits into int.
282 (call_process_cleanup, Fcall_process, delete_temp_file)
283 (Fcall_process_region):
284 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
285 (Fcall_process): Simplify handling of volatile integers.
286 Use int, not EMACS_INT, where int will do.
287 * casefiddle.c (casify_object, casify_region, operate_on_word)
288 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
289 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
290 (casify_object): Avoid integer overflow when overallocating buffer.
291 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 292 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
293 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
294 * category.h (CATEGORYP): Don't assume arg is nonnegative.
295 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
296 integers are now checked earlier. All uses replaced with XINT.
297 (ccl_driver):
298 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
299 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
300 (ccl_driver, Fregister_code_conversion_map):
301 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
302 (resolve_symbol_ccl_program): Check that vector header is in range.
303 Always copy the vector, so that we can check its contents reliably
304 now rather than having to recheck each instruction as it's being
305 executed. Check that vector words fit in 'int'.
306 (ccl_get_compiled_code, Fregister_ccl_program)
307 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
308 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
309 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
310 contents are in range.
311 (Fccl_execute_on_string): Check that status is in range.
312 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
313 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
314 Accept and return EMACS_INT, not int, because callers can pass values
315 out of 'int' range.
316 (c_string_width, strwidth, lisp_string_width, chars_in_text)
317 (multibyte_chars_in_text, parse_str_as_multibyte)
318 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
319 (str_as_unibyte, str_to_unibyte, string_count_byte8)
320 (string_escape_byte8, Fget_byte):
321 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 322 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
323 avoid mishandling large integers.
324 * character.h: Adjust decls to match defn changes elsewhere.
325 * charset.c (load_charset_map_from_file, find_charsets_in_text)
326 (Ffind_charset_region):
327 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
328 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
329 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 330 Don't assume fixnum fits in int.
d311d28c
PE
331 (load_charset_map_from_vector, Fmap_charset_chars):
332 Remove now-unnecessary CHECK_NATNUMs.
333 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
334 Don't rely on undefined behavior with signed left shift overflow.
335 Don't assume unsigned int fits into fixnum, or that fixnum fits
336 into unsigned int. Don't require max_code to be a valid fixnum;
337 that's not true for gb10830 4-byte on a 32-bit host. Allow
338 invalid_code to be a cons, for the same reason. Require code_offset
339 to be a character. Avoid int overflow if max_char is close
340 to INT_MAX.
341 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
342 this is intended anyway and avoids some undefined behavior.
343 (load_charset_map): Pass unsigned, not int, as 2nd arg of
344 INDEX_TO_CODE_POINT, as that's what it expects.
345 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
346 * charset.h (DECODE_CHAR): Return int, not unsigned;
347 this is what was intended anyway, and it avoids undefined behavior.
348 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
349 integer-overflow issues.
350 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
351 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
352 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
353 * chartab.c (Fmake_char_table, Fset_char_table_range)
354 (uniprop_get_decoder, uniprop_get_encoder):
355 Don't assume fixnum fits in int.
356 * cmds.c (move_point): New function, that does the gist of
357 Fforward_char and Fbackward_char, but does so while checking
358 for integer overflow more accurately.
c96e5d6a 359 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
360 (Fforward_line, Fend_of_line, internal_self_insert)
361 (internal_self_insert):
362 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
363 Fix a FIXME, by checking for integer overflow when calculating
364 target_clm and actual_clm.
365 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 366 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
367 (ASSURE_DESTINATION, coding_alloc_by_realloc)
368 (coding_alloc_by_making_gap, alloc_destination)
369 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
370 (encode_coding_utf_16, detect_coding_emacs_mule)
371 (decode_coding_emacs_mule, encode_coding_emacs_mule)
372 (detect_coding_iso_2022, decode_coding_iso_2022)
373 (encode_invocation_designation, encode_designation_at_bol)
374 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
375 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
376 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
377 (encode_coding_ccl, encode_coding_raw_text)
378 (detect_coding_charset, decode_coding_charset)
379 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
380 (produce_composition, produce_charset, produce_annotation)
381 (decode_coding, handle_composition_annotation)
382 (handle_charset_annotation, consume_chars, decode_coding_gap)
383 (decode_coding_object, encode_coding_object, detect_coding_system)
384 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
385 (code_convert_region, code_convert_string)
8f50130c
PE
386 (Fdefine_coding_system_internal)
387 (coding_set_source, coding_set_destination):
d311d28c
PE
388 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
389 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
390 (Fdefine_coding_system_internal):
391 Don't assume fixnums fit in int.
392 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 393 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
394 (Funencodable_char_position, Fcheck_coding_systems_region)
395 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 396 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 397 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 398 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 399 Don't access memory outside of the args array.
d311d28c 400 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
401 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
402 result of ENCODE_CHAR.
d311d28c
PE
403 * coding.h: Adjust decls to match defn changes elsewhere.
404 (struct coding_system):
405 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
406 * composite.c (get_composition_id, find_composition)
407 (run_composition_function, update_compositions)
408 (compose_text, composition_gstring_put_cache)
409 (composition_gstring_p, composition_gstring_width)
410 (fill_gstring_header, fill_gstring_body, autocmp_chars)
411 (composition_compute_stop_pos, composition_reseat_it)
412 (composition_update_it, struct position_record)
413 (find_automatic_composition, composition_adjust_point)
414 (Fcomposition_get_gstring, Ffind_composition_internal):
415 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
416 (update_compositions):
417 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
418 * composite.h: Adjust decls to match defn changes elsewhere.
419 (struct composition):
420 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
421 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
422 Do not attempt to compute the address of the object just before a
423 buffer; this is not portable.
424 (Faref, Faset):
425 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
426 (Faset): Use int, not EMACS_INT, where int is wide enough.
427 (Fstring_to_number): Don't assume fixnums fit in int.
428 (Frem): Don't assume arg is nonnegative.
429 * dbusbind.c (xd_append_arg): Check for integers out of range.
430 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 431 (extract_signed, extract_unsigned): New functions.
243e0530
PE
432 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
433 (xd_get_connection_references): Return ptrdiff_t, not int.
434 All uses changed.
435 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
436 (xd_read_message_1):
437 Use int, not unsigned, where the dbus API uses int.
438 (Fdbus_message_internal): Don't overflow mtype.
439 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
440 * dired.c (directory_files_internal, file_name_completion, scmp)
441 (file_name_completion_stat):
442 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
443 (file_name_completion): Don't overflow matchcount.
444 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
445 * dispextern.h: Adjust decls to match defn changes elsewhere.
446 (struct text_pos, struct glyph, struct bidi_saved_info)
447 (struct bidi_string_data, struct bidi_it, struct composition_it)
448 (struct it):
449 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
450 (struct display_pos, struct composition_it, struct it):
451 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
452 * dispnew.c (increment_matrix_positions)
453 (increment_row_positions, mode_line_string)
454 (marginal_area_string):
455 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 456 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
457 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
458 (duration_to_sec_usec): New function, to check for overflow better.
459 (Fsleep_for, sit_for): Use it.
460 * doc.c (get_doc_string, store_function_docstring):
461 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
462 (get_doc_string, Fsnarf_documentation):
463 Use int, not EMACS_INT, where int is wide enough.
464 (get_doc_string):
465 Use SAFE_ALLOCA, not alloca.
466 Check for overflow when converting EMACS_INT to off_t.
467 * doprnt.c (doprnt):
468 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
469 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
470 Don't assume uid_t fits into fixnum.
471 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
472 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
473 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
474 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
475 (general_insert_function)
476 (Finsert_char, make_buffer_string, make_buffer_string_both)
477 (update_buffer_properties, Fbuffer_substring)
478 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
479 (Fsubst_char_in_region, check_translation)
480 (Ftranslate_region_internal, save_restriction_restore, Fformat)
481 (transpose_markers, Ftranspose_regions):
482 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
483 (clip_to_bounds): Move to lisp.h as an inline function).
484 (Fconstrain_to_field): Don't assume integers are nonnegative.
485 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
486 (Fsubst_char_in_region, Fsave_restriction):
487 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
488 (Femacs_pid): Don't assume pid_t fits into fixnum.
489 (lo_time): Use int, not EMACS_INT, when int suffices.
490 (lisp_time_argument): Check for usec out of range.
491 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
492 (Fuser_login_name, Fuser_full_name): Signal an error
493 if a uid argument is out of range, rather than relying on
494 undefined behavior.
c8d5c857
PE
495 (Fformat_time_string): Remove now-unnecessary check.
496 lisp_time_argument checks for out-of-range usec now.
243e0530 497 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
498 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
499 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
500 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
501 (init_cmdargs, Fdump_emacs):
502 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
503 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
504 the bottom (typically) 32 bits of the fixnum.
505 * eval.c (specpdl_size, call_debugger):
506 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
507 (when_entered_debugger, Fbacktrace_debug):
508 Don't assume fixnum can fit in int.
509 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
510 the object just before a buffer; this is not portable.
511 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
512 (grow_specpdl, unbind_to):
513 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
514 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
515 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 516 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
517 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
518 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
519 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
520 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
521 (a_write, e_write):
522 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
523 (Fcopy_file, non_regular_nbytes, read_non_regular)
524 (Finsert_file_contents):
525 Use int, not EMACS_INT, where int is wide enough.
526 (READ_BUF_SIZE): Verify that it fits in int.
527 (Finsert_file_contents): Check that counts are in proper range,
528 rather than assuming fixnums fit into ptrdiff_t etc.
529 Don't assume fixnums fit into int.
125b3835 530 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
531 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
532 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
533 (string_char_to_byte, string_byte_to_char)
534 (string_make_multibyte, string_to_multibyte)
535 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
536 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
537 (substring_both, Fdelete, internal_equal, Ffillarray)
538 (Fclear_string, mapcar1)
539 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
540 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
541 (larger_vector, make_hash_table, maybe_resize_hash_table)
542 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
543 (Fmaphash, secure_hash):
544 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
545 (concat): Check for string index and length overflow.
546 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
547 (Frequire):
548 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
549 (larger_vector): New API (vec, incr_min, size_max) replaces old
550 one (vec, new_size, init). This catches size overflow.
551 INIT was removed because it was always Qnil.
552 All callers changed.
553 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
554 the upper bound on a hash table index size.
555 (make_hash_table, maybe_resize_hash_table): Use it.
556 (secure_hash): Computer start_byte and end_byte only after
557 they're known to be in ptrdiff_t range.
558 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
559 (Ffont_get_glyphs, Ffont_at):
560 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
561 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
562 (Flist_fonts, Fopen_font):
563 Don't assume fixnum can fit in int.
564 (check_gstring): Don't assume index can fit in int.
565 (font_match_p): Check that fixnum is a character, not a nonnegative
566 fixnum, since the later code needs to stuff it into an int.
567 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
568 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
569 conversion overflow issues.
570 (Fopen_font): Check for integer out of range.
571 (Ffont_get_glyphs): Don't assume index can fit in int.
572 * font.h: Adjust decls to match defn changes elsewhere.
573 * fontset.c (reorder_font_vector): Redo score calculation to avoid
574 integer overflow.
575 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
576 printmax_t, where ptrdiff_t is wide enough.
577 (Finternal_char_font):
578 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
579 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
580 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
581 (Fset_frame_position, x_set_frame_parameters)
582 (x_set_line_spacing, x_set_border_width)
583 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
584 Check that fixnums are in proper range for system types.
585 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
586 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
587 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
588 Use SAFE_ALLOCA_LISP, not alloca.
589 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
590 intptr_t is wide enough.
591 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
592 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
593 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
594 Check for fixnum out of range.
595 * ftfont.c (ftfont_list): Don't assume index fits in int.
596 Check that fixnums are in proper range for system types.
597 (ftfont_shape_by_flt):
598 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
599 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
600 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
601 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
602 Check that fixnums are in proper range for system types.
603 * gnutls.h: Adjust decls to match defn changes elsewhere.
604 * gtkutil.c (xg_dialog_run):
605 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
606 (update_frame_tool_bar):
607 Check that fixnums are in proper range for system types.
608 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 609 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
610 * indent.c (last_known_column, last_known_column_point):
611 (current_column_bol_cache):
612 (skip_invisible, current_column, check_display_width):
613 (check_display_width, scan_for_column, current_column_1)
614 (Findent_to, Fcurrent_indentation, position_indentation)
615 (indented_beyond_p, Fmove_to_column, compute_motion):
616 (Fcompute_motion, Fvertical_motion):
617 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
618 (last_known_column_modified): Use EMACS_INT, not int.
619 (check_display_width):
620 (Fcompute_motion):
621 Check that fixnums and floats are in proper range for system types.
622 (compute_motion): Don't assume index or fixnum fits in int.
623 (compute_motion, Fcompute_motion):
624 Use int, not EMACS_INT, when it is wide enough.
625 (vmotion): Omit local var start_hpos that is always 0; that way
626 we don't need to worry about overflow in expressions involving it.
627 * indent.h: Adjust decls to match defn changes elsewhere.
628 (struct position):
629 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
630 Use int, not EMACS_INT, where int is wide enough.
631 Remove unused members ovstring_chars_done and tab_offset;
632 all uses removed.
633 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
634 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
635 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
636 (make_gap, copy_text, insert, insert_and_inherit)
637 (insert_before_markers, insert_before_markers_and_inherit)
638 (insert_1, count_combining_before, count_combining_after)
639 (insert_1_both, insert_from_string)
640 (insert_from_string_before_markers, insert_from_string_1)
641 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
642 (adjust_after_replace, adjust_after_insert, replace_range)
643 (replace_range_2, del_range, del_range_1, del_range_byte)
644 (del_range_both, del_range_2, modify_region)
645 (prepare_to_modify_buffer, signal_before_change)
646 (signal_after_change, Fcombine_after_change_execute):
647 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
648 * intervals.c (traverse_intervals, rotate_right, rotate_left)
649 (balance_an_interval, split_interval_right, split_interval_left)
650 (find_interval, next_interval, update_interval)
651 (adjust_intervals_for_insertion, delete_node, delete_interval)
652 (interval_deletion_adjustment, adjust_intervals_for_deletion)
653 (static_offset_intervals, offset_intervals)
654 (merge_interval_right, merge_interval_left, make_new_interval)
655 (graft_intervals_into_buffer, temp_set_point_both)
656 (temp_set_point, set_point, adjust_for_invis_intang)
657 (set_point_both, move_if_not_intangible, get_property_and_range)
658 (get_local_map, copy_intervals, copy_intervals_to_string)
659 (compare_string_intervals, set_intervals_multibyte_1):
660 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
661 * intervals.h: Adjust decls to match defn changes elsewhere.
662 (struct interval):
663 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
664 * keyboard.c (this_command_key_count, this_single_command_key_start)
665 (before_command_key_count, before_command_echo_length, echo_now)
666 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
667 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
668 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
669 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
670 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
671 (last_non_minibuf_size, last_point_position, echo_truncate)
672 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
673 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
674 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
675 (stuff_buffered_input):
676 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
677 (last_auto_save, command_loop_1, read_char):
678 Use EMACS_INT, not int, to avoid integer overflow.
679 (record_char): Avoid overflow in total_keys computation.
680 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
681 * keyboard.h: Adjust decls to match defn changes elsewhere.
682 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
683 (Fkey_description, Fdescribe_vector, Flookup_key):
684 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
685 (click_position): New function, to check that positions are in range.
686 (Fcurrent_active_maps):
687 (describe_command):
688 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
689 (Faccessible_keymaps, Fkey_description):
690 (preferred_sequence_p):
691 Don't assume fixnum can fit into int.
692 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
693 Check for integer overflow in size calculations.
694 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
695 avoid mishandling large integers.
696 * lisp.h: Adjust decls to match defn changes elsewhere.
697 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
698 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
699 (struct Lisp_Marker):
700 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
701 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
702 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
703 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
704 All callers changed.
705 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
706 Assume the arg has valid form, since it always does.
707 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
708 unsigned integer system type.
709 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
710 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
711 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
712 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
713 (duration_to_sec_usec): New decl.
714 * lread.c (read_from_string_index, read_from_string_index_byte)
715 (read_from_string_limit, readchar, unreadchar, openp)
716 (read_internal_start, read1, oblookup):
717 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
718 (Fload, readevalloop, Feval_buffer, Feval_region):
719 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
720 (openp): Check for out-of-range argument to 'access'.
721 (read1): Use int, not EMACS_INT, where int is wide enough.
722 Don't assume fixnum fits into int.
6efdadfd 723 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
724 (read_filtered_event): Use duration_to_sec_usec
725 to do proper overflow checking on durations.
d311d28c
PE
726 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
727 in size calculation.
728 (Fexecute_kbd_macro):
729 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
730 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
731 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
732 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
733 (set_marker_both, set_marker_restricted_both, marker_position)
734 (marker_byte_position, Fbuffer_has_markers_at):
735 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
736 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 737 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
738 It now merely ensures that the menu is large enough, without
739 necessarily growing it, as this avoids some integer overflow issues.
740 All callers changed.
741 (keymap_panes, parse_single_submenu, Fx_popup_menu):
742 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
743 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
744 Use SAFE_ALLOCA_LISP, not alloca.
745 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
746 to EMACS_INT. Check that fixnums are in proper range for system types.
747 * minibuf.c (minibuf_prompt_width, string_to_object)
748 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
749 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
750 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
751 (get_minibuffer, read_minibuf_unwind):
752 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
753 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
754 this simplifies overflow checking. All callers changed.
755 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
756 (Ftest_completion):
757 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
758 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
759 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
760 Check that fixnums are in proper range for system types.
761 (Fx_create_frame, Fx_show_tip):
762 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
763 * nsfont.m (ns_findfonts, nsfont_list_family):
764 Don't assume fixnum fits in long.
765 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
766 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
767 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
768 wide enough.
17fdb222 769 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
770 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
771 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
772 (PRINTDECLARE, PRINTPREPARE):
773 (strout, print_string):
774 (print, print_preprocess, print_check_string_charset_prop)
775 (print_object):
776 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
777 (PRINTDECLARE):
778 (temp_output_buffer_setup, Fprin1_to_string, print_object):
779 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
780 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 781 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 782 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
783 (print_error_message): Use SAFE_ALLOCA, not alloca.
784 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
785 (print_depth, new_backquote_output, print_number_index):
786 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
787 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
788 (Fset_process_window_size, Fformat_network_address)
789 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 790 (sigchld_handler):
d311d28c 791 Check that fixnums are in proper range for system types.
d44287d4 792 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
793 Check for process-ids out of pid_t range rather than relying on
794 undefined behavior.
e4d81efc 795 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
796 (Fformat_network_address, read_process_output, send_process)
797 (Fprocess_send_region, status_notify):
798 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
799 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
800 (wait_reading_process_output, read_process_output, exec_sentinel):
801 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
802 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
803 (Faccept_process_output): Use duration_to_sec_usec to do proper
804 overflow checking on durations.
dde14581
PE
805 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
806 Don't assume pid_t fits in int.
02481186
PE
807 * process.h (struct Lisp_Process): Members tick and update_tick
808 are now of type EMACS_INT, not int.
b62b53e8
PE
809 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
810 configured --with-wide-int.
d311d28c
PE
811 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
812 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
813 * search.c (looking_at_1, string_match_1):
814 (fast_string_match, fast_c_string_match_ignore_case)
815 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
816 (scan_newline, find_before_next_newline, search_command)
817 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
818 (set_search_regs, wordify):
819 (Freplace_match):
820 (Fmatch_data):
821 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
822 (string_match_1, search_buffer, set_search_regs):
823 (Fmatch_data):
824 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
825 (wordify): Check for overflow in size calculation.
826 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
827 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
828 Check that fixnums are in proper range for system types.
829 * sound.c (struct sound_device)
830 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
831 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
832 (Fplay_sound_internal):
833 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 834 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
835 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
836 (Fparse_partial_sexp):
837 Don't assume fixnums can fit in int.
838 (struct lisp_parse_state, find_start_pos, find_start_value)
839 (find_start_value_byte, find_start_begv)
840 (update_syntax_table, char_quoted, dec_bytepos)
841 (find_defun_start, prev_char_comend_first, back_comment):
842 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
843 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
844 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
845 (Finternal_describe_syntax_value): Check that match_lisp is a
846 character, not an integer, since the code stuffs it into int.
847 (scan_words, scan_sexps_forward):
848 Check that fixnums are in proper range for system types.
849 (Fforward_word):
850 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
851 (scan_sexps_forward):
852 Use CHARACTERP, not INTEGERP, since the value must fit into int.
853 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
854 * syntax.h: Adjust decls to match defn changes elsewhere.
855 (struct gl_state_s):
856 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
857 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
858 MOST_POSITIVE_FIXNUM.
d311d28c
PE
859 * sysdep.c (wait_for_termination_1, wait_for_termination)
860 (interruptible_wait_for_termination, mkdir):
861 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
862 (emacs_read, emacs_write):
863 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
864 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
865 and double all fit in int.
d311d28c
PE
866 * term.c (set_tty_color_mode):
867 Check that fixnums are in proper range for system types.
868 * termhooks.h (struct input_event):
869 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
870 * textprop.c (validate_interval_range, interval_of)
871 (Fadd_text_properties, set_text_properties_1)
872 (Fremove_text_properties, Fremove_list_of_text_properties)
873 (Ftext_property_any, Ftext_property_not_all)
874 (copy_text_properties, text_property_list, extend_property_ranges)
875 (verify_interval_modification):
876 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
877 (Fnext_single_char_property_change)
878 (Fprevious_single_char_property_change):
879 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
880 (copy_text_properties):
881 Check for integer overflow in index calculation.
d311d28c
PE
882 * undo.c (last_boundary_position, record_point, record_insert)
883 (record_delete, record_marker_adjustment, record_change)
884 (record_property_change):
885 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
886 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
887 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
888 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
889 (Fx_hide_tip, Fx_file_dialog):
890 * w32menu.c (set_frame_menubar):
891 Use ptrdiff_t, not int, for consistency with rest of code.
892 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
893 (select_window, Fdelete_other_windows_internal)
894 (window_scroll_pixel_based, window_scroll_line_based)
895 (Frecenter, Fset_window_configuration):
896 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
897 (Fset_window_hscroll, run_window_configuration_change_hook)
898 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 899 (Fscroll_other_window, Frecenter):
d311d28c
PE
900 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
901 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
902 Don't assume fixnum fits in int.
903 (Fset_window_scroll_bars):
904 Check that fixnums are in proper range for system types.
905 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
906 (string_pos, c_string_pos, number_of_chars, init_iterator)
907 (in_ellipses_for_invisible_text_p, init_from_display_pos)
908 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
909 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
910 (face_before_or_after_it_pos, handle_invisible_prop)
911 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
912 (display_prop_intangible_p, string_buffer_position_lim)
913 (string_buffer_position, handle_composition_prop, load_overlay_strings)
914 (get_overlay_strings_1, get_overlay_strings)
915 (iterate_out_of_display_property, forward_to_next_line_start)
916 (back_to_previous_visible_line_start, reseat, reseat_to_string)
917 (get_next_display_element, set_iterator_to_next)
918 (get_visually_first_element, compute_stop_pos_backwards)
919 (handle_stop_backwards, next_element_from_buffer)
920 (move_it_in_display_line_to, move_it_in_display_line)
921 (move_it_to, move_it_vertically_backward, move_it_by_lines)
922 (add_to_log, message_dolog, message_log_check_duplicate)
923 (message2, message2_nolog, message3, message3_nolog
924 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
925 (current_message_1, truncate_echo_area, truncate_message_1)
926 (set_message, set_message_1, store_mode_line_noprop)
927 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
928 (text_outside_line_unchanged_p, check_point_in_composition)
929 (reconsider_clip_changes)
930 (redisplay_internal, set_cursor_from_row, try_scrolling)
931 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
932 (redisplay_window, find_last_unchanged_at_beg_row)
933 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
934 (trailing_whitespace_p, find_row_edges, display_line)
935 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
936 (display_mode_element, store_mode_line_string)
937 (pint2str, pint2hrstr, decode_mode_spec)
938 (display_count_lines, display_string, draw_glyphs)
939 (x_produce_glyphs, x_insert_glyphs)
940 (rows_from_pos_range, mouse_face_from_buffer_pos)
941 (fast_find_string_pos, mouse_face_from_string_pos)
942 (note_mode_line_or_margin_highlight, note_mouse_highlight):
943 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
944 (safe_call, init_from_display_pos, handle_fontified_prop)
945 (handle_single_display_spec, load_overlay_strings)
946 (with_echo_area_buffer, setup_echo_area_for_printing)
947 (display_echo_area, echo_area_display)
948 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
949 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
950 (redisplay_window, dump_glyph_row, display_mode_line)
951 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 952 (handle_display_spec, display_prop_string_p):
d311d28c
PE
953 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
954 (handle_single_display_spec, build_desired_tool_bar_string)
955 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
956 (get_specified_cursor_type):
957 Check that fixnums are in proper range for system types.
958 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
959 (Flookup_image_map):
960 Don't assume fixnums fit in int.
961 (compare_overlay_entries):
962 Avoid mishandling comparisons due to subtraction overflow.
963 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
964 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
965 (handle_tool_bar_click):
966 Use int, not unsigned, since we prefer signed and the signedness
967 doesn't matter here.
968 (get_next_display_element, next_element_from_display_vector):
969 Use int, not EMACS_INT, when int is wide enough.
970 (start_hourglass): Use duration_to_sec_usec to do proper
971 overflow checking on durations.
972 * xfaces.c (Fbitmap_spec_p):
973 Check that fixnums are in proper range for system types.
974 (compare_fonts_by_sort_order):
975 Avoid mishandling comparisons due to subtraction overflow.
976 (Fx_family_fonts, realize_basic_faces):
977 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
978 (Fx_family_fonts):
979 Don't assume fixnum fits in int.
980 Use SAFE_ALLOCA_LISP, not alloca.
981 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
982 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
983 (face_at_buffer_position, face_for_overlay_string)
984 (face_at_string_position):
985 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
986 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
987 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
988 (Fx_show_tip):
989 Check that fixnums are in proper range for system types.
990 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
991 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
992 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
993 (Fx_change_window_property): Don't assume fixnums fit in int.
994 * xfont.c (xfont_chars_supported):
995 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
996 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
997 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
998 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
999 * xml.c (parse_region):
1000 * xrdb.c (magic_file_p):
1001 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1002 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
1003 (x_get_local_selection, x_reply_selection_request)
1004 (x_handle_selection_request, wait_for_property_change):
1005 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1006 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
1007 short is wide enough.
1008 (x_send_client_event): Don't assume fixnum fits in int.
1009 * xterm.c (x_x_to_emacs_modifiers):
1010 Don't assume EMACS_INT overflows nicely into int.
1011 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
1012 may come from Lisp.
1013 (handle_one_xevent): NATNUMP can eval its arg twice.
1014 (x_connection_closed):
1015 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1016 * xterm.h: Adjust decls to match defn changes elsewhere.
1017 (struct scroll_bar): Use struct vectorlike_header
1018 rather than rolling our own approximation.
1019 (SCROLL_BAR_VEC_SIZE): Remove; not used.
1020
c6574eb5
GM
10212012-05-25 Glenn Morris <rgm@gnu.org>
1022
1023 * lisp.mk (lisp): Update for more files being compiled now.
1024
e8d32c7e
SM
10252012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
1026
48def666
SM
1027 * lread.c: Remove `read_pure' which makes no difference.
1028 (read_pure): Remove var.
1029 (unreadpure): Remove function.
1030 (readevalloop): Don't call read_list with -1 flag.
1031 (read1, read_vector): Don't test read_pure any more.
1032 (read_list): Simplify.
1033
e8d32c7e
SM
1034 * fileio.c, character.h: Minor style tweaks.
1035
4b2addb7
DA
10362012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
1037
1038 * window.h (clip_changed): Remove useless declaration.
1039
584461b2
JB
10402012-05-22 Juanma Barranquero <lekktu@gmail.com>
1041
1042 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
1043 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
1044
34374650
PE
10452012-05-22 Paul Eggert <eggert@cs.ucla.edu>
1046
1047 Remove src/m/*.
1048 This directory predates autoconf and is no longer needed nowadays.
1049 Move its few remaining bits of functionality to where they're needed.
1050 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
1051 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
1052 * m/template.h: Remove.
1053 * Makefile.in (M_FILE): Remove. All uses removed.
1054 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
1055 * lisp.h (USE_LSB_TAG):
1056 * mem-limits.h (EXCEEDS_LISP_PTR):
1057 Use VAL_MAX, not VALBITS, in #if.
1058 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
1059 (EMACS_UINT): Define unconditionally now.
1060 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
1061 (BITS_PER_EMACS_INT): New constants, replacing
1062 what used to be in config.h, but not useful in #if.
1063 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
1064 define them any more.
1065 (VAL_MAX): New macro.
1066 (VALMASK): Use it.
1067 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
1068 BITS_PER_EMACS_INT, in #if.
1069 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1070 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
1071 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
1072 * s/ms-w32.h (DATA_START):
1073 Move here from removed file m/intel386.h.
1074 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
1075 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
1076
261cb4bb
PE
10772012-05-21 Paul Eggert <eggert@cs.ucla.edu>
1078
1079 Assume C89 or later.
1080 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
1081 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
1082 (xrealloc):
1083 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
1084 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
1085 * textprop.c, tparam.c (NULL): Remove.
1086 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
1087 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
1088 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
1089 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
1090 * xterm.c (input_signal_count): Assume volatile works.
1091
ff23cd9f
KB
10922012-05-21 Ken Brown <kbrown@cornell.edu>
1093
1094 * xgselect.c (xg_select): Fix first argument in call to 'select'
1095 (bug#11508).
1096
1b170bc6
KB
10972012-05-20 Ken Brown <kbrown@cornell.edu>
1098
1099 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 1100 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 1101
b2f4d39f
KB
11022012-05-19 Ken Brown <kbrown@cornell.edu>
1103
1104 * xfns.c (x_in_use): Remove `static' qualifier.
1105 * xterm.h (x_in_use): Declare.
1106 * xgselect.c: Include xterm.h.
1107 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
1108 and `display_arg' (bug#9754).
1109
003fdae2
PE
11102012-05-19 Paul Eggert <eggert@cs.ucla.edu>
1111
9232a6d9
PE
1112 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
1113
003fdae2
PE
1114 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
1115 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
1116
784b56e2
EZ
11172012-05-18 Eli Zaretskii <eliz@gnu.org>
1118
1119 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
1120
1121 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
1122 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
1123
1124 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
1125 reference to image_cache->refcount.
1126 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
1127
a0a79cde
JL
11282012-05-17 Juri Linkov <juri@jurta.org>
1129
1130 * search.c (Fword_search_regexp, Fword_search_backward)
1131 (Fword_search_forward, Fword_search_backward_lax)
1132 (Fword_search_forward_lax): Move functions to isearch.el
1133 (bug#10145, bug#11381).
1134
b0572523
PE
11352012-05-16 Paul Eggert <eggert@cs.ucla.edu>
1136
1137 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
1138
9660f5fc
SM
11392012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
1140
1141 * lread.c (init_obarray): Declare Qt and Qnil as special.
1142
4374de83
GM
11432012-05-14 Glenn Morris <rgm@gnu.org>
1144
1145 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 1146 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 1147
dc44c39a
PE
11482012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1149
078c97cb
PE
1150 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
1151
dc44c39a
PE
1152 * unexaix.c: Port to more-recent AIX compilers.
1153 (report_error, report_error_1, make_hdr, copy_sym)
1154 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
1155 Make arguments const char *, not char *, to avoid violations of C
1156 standard and to fix some AIX warnings reported by Gilles Pion.
1157
e18afed7 11582012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
1159
1160 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
1161 already have overlays loaded.
1162 (handle_single_display_spec): Before returning without displaying
1163 fringe bitmap, synchronize the bidi iterator with the main display
1164 iterator, by calling iterate_out_of_display_property.
1165 (iterate_out_of_display_property): Detect buffer iteration by
1166 testing that it->string is a Lisp string.
1167 (get_next_display_element): When the current object is exhausted,
1168 and there's something on it->stack, call set_iterator_to_next to
1169 proceed with what's on the stack, instead of returning zero.
1170 (set_iterator_to_next): If called at the end of a Lisp string,
1171 proceed to consider_string_end without incrementing string
1172 position. Don't increment display vector index past the end of
1173 the display vector. (Bug#11417)
c8fb9dc6
EZ
1174 (pos_visible_p): Don't report a position visible when move_it_to
1175 stopped at the last line of window, which happens to be scanned
1176 backwards by the bidi iteration. (Bug#11464)
ac268e67 1177
e18afed7 11782012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
1179
1180 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
1181 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
1182 are on a TTY, and thus unable to display on the fringes.
1183 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
1184 so we need to signal to the caller that this is a "replacing"
1185 display spec. This fixes display when the spec is invalid or we
1186 are on a TTY.
1187
e18afed7 11882012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
1189
1190 * unexaix.c (make_hdr): Fix typo in prototype.
1191 This bug broke the build on AIX. Problem reported by Gilles Pion.
1192
9d0a235a
MA
11932012-05-14 Michael Albinus <michael.albinus@gmx.de>
1194
1195 * keyboard.c (kbd_buffer_get_event): Read special events also in
1196 batch mode. (Bug#11415)
1197
9e6b06ed
GM
11982012-05-12 Glenn Morris <rgm@gnu.org>
1199
1200 * ns.mk: Update for ns_appbindir no longer having trailing "/".
1201
c1a1d7a3
EZ
12022012-05-12 Eli Zaretskii <eliz@gnu.org>
1203
1204 * lisp.mk (lisp): Add newcomment.elc.
1205
3fe7cdc8
GM
12062012-05-12 Glenn Morris <rgm@gnu.org>
1207
1208 * Makefile.in (MKDIR_P): New, set by configure.
1209 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
1210
53f7d2c0
PE
12112012-05-11 Paul Eggert <eggert@cs.ucla.edu>
1212
1213 Remove unused function hourglass_started.
1214 * dispextern.h (hourglass_started):
1215 * w32fns.c (hourglass_started):
1216 * xdisp.c (hourglass_started): Remove.
1217
75aafb17
JB
12182012-05-10 Juanma Barranquero <lekktu@gmail.com>
1219
1220 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
1221 Update dependencies.
1222
12959e8e
PE
12232012-05-10 Paul Eggert <eggert@cs.ucla.edu>
1224
97107e2e
PE
1225 * xgselect.c (xg_select): Put maxfds+1 into a var.
1226 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
1227
12959e8e
PE
1228 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
1229
836d29b3
DA
12302012-05-10 Dave Abrahams <dave@boostpro.com>
1231
1232 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
1233 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
1234
5cb67954
MA
12352012-05-09 Michael Albinus <michael.albinus@gmx.de>
1236
1237 * dbusbind.c (xd_registered_buses): New internal Lisp object.
1238 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
1239 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
1240 Initialize xd_registered_buses.
1241
3478ec45
PE
12422012-05-09 Paul Eggert <eggert@cs.ucla.edu>
1243
b263a6b0
PE
1244 Untag more efficiently if USE_LSB_TAG.
1245 This is based on a proposal by YAMAMOTO Mitsuharu in
1246 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
1247 For an admittedly artificial (nth 8000 longlist) benchmark on
1248 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
1249 Emacs's overall text size by 1%.
1250 * lisp.h (XUNTAG): New macro.
1251 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
1252 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
1253 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
1254 * eval.c (Fautoload):
1255 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
1256 * frame.h (XFRAME): Use XUNTAG.
1257
3478ec45
PE
1258 Port recent dbusbind.c changes to 32-bit --with-wide-int.
1259 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
1260 Remove unportable assumptions about print widths of types like
1261 dbus_uint32_t.
1262 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
1263 intptr_t when converting between pointer and integer, to avoid GCC
1264 warnings about wrong width.
1265
666b903b 12662012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
1267
1268 * w32proc.c (new_child): Force Windows to reserve only 64KB of
1269 stack for each reader_thread, instead of defaulting to 8MB
1270 determined by the linker. This avoids failures in creating
1271 subprocesses on Windows 7, see the discussion in this thread:
1272 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
1273
b120cc17
JC
12742012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
1275
1276 Fix up display of the *Minibuf-0* buffer in the mini window.
1277 * keyboard.c (read_char): Don't clear the echo area if there's no
1278 message to clear.
1279 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 1280 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 1281
9a4b36f8
MA
12822012-05-07 Michael Albinus <michael.albinus@gmx.de>
1283
1284 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
1285 batch mode.
1286
e5f9458f
CY
12872012-05-06 Chong Yidong <cyd@gnu.org>
1288
1289 * lisp.mk (lisp): Update.
1290
eceeb5fc 12912012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
1292
1293 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
1294
71873e2b
SM
12952012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
1296
1297 * data.c (PUT_ERROR): New macro.
1298 (syms_of_data): Use it. Add new error type `user-error'.
1299 * undo.c (user_error): New function.
1300 (Fprimitive_undo): Use it.
1301 * print.c (print_error_message): Adjust print style for `user-error'.
1302 * keyboard.c (user_error): New function.
1303 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
1304
ab0fa4e4
PE
13052012-05-03 Paul Eggert <eggert@cs.ucla.edu>
1306
1307 Do not limit current-time-string to years 1000..9999.
1308 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
1309 (Fcurrent_time_string): Support any year that is supported by the
1310 underlying localtime representation. Don't use asctime, as it
1311 has undefined behavior for years outside the range -999..9999.
1312
7ed806a7
PE
13132012-05-02 Paul Eggert <eggert@cs.ucla.edu>
1314
1315 Fix race conditions involving setenv, gmtime, localtime, asctime.
1316 Without this fix, interrupts could mess up code that uses these
1317 nonreentrant functions, since setting TZ invalidates existing
1318 tm_zone or tzname values, and since most of these functions return
1319 pointers to static storage.
1320 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
1321 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
1322 Grow the critical sections to include not just invoking
1323 localtime/gmtime, but also accessing these functions' results
1324 including their tm_zone values if any, and any related TZ setting.
1325 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
1326 so that the struct tm is saved in the critical section.
1327 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
1328 motivated by the fact that memory allocation needs to be outside
1329 the critical section.
1330
0c16dfed
DA
13312012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
1332
1333 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
1334 with RESET_INTERVAL.
1335
1336 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1337 Remove duplicated buffer name initialization.
1338
3f83ace8
JM
13392012-05-02 Jim Meyering <jim@meyering.net>
1340
1341 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
1342
c7b8541e
JM
1343 * xfns.c (x_window): Use xstrdup (Bug#11375).
1344
90207a15 13452012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
1346
1347 * xdisp.c (pos_visible_p): If already at a newline from the
1348 display string before the 'while' loop, don't walk back the glyphs
1349 from it3.glyph_row. Solves assertion violation when the display
1350 string begins with a newline (egg.el). (Bug#11367)
1351
b593d6a9
AH
13522012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
1353
1354 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
1355 Move to simple.el.
1356
4737362e
GM
13572012-05-01 Glenn Morris <rgm@gnu.org>
1358
99cf43f9
GM
1359 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
1360 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
1361 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
1362 All were removed before 23.1.
1363
9311dcff
GM
1364 * dispnew.c: Remove HAVE_LIBNCURSES test;
1365 it is always true on relevant platforms.
1366
4d5c6349
GM
1367 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
1368 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
1369
4737362e
GM
1370 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
1371
74dd3a6b
AS
13722012-04-30 Andreas Schwab <schwab@linux-m68k.org>
1373
1374 * .gdbinit (xpr): Remove checks for no longer existing misc types.
1375 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
1376 Remove.
1377
13c379ee
PE
13782012-04-28 Paul Eggert <eggert@cs.ucla.edu>
1379
1380 Do not avoid creating empty evaporating overlays (Bug#9642).
1381 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
1382 That is, do not delete an evaporating overlay if it becomes
1383 empty after its bounds are adjusted to fit within its buffer.
1384 This fix caused other problems, and I'm reverting it until we get
1385 to the bottom of them.
1386
a8e7d6d7 13872012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
1388
1389 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
1390
a8e7d6d7 13912012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
1392
1393 * xdisp.c (pos_visible_p): If the window start position is beyond
1394 ZV, start the display from buffer beginning. Prevents assertion
1395 violation in init_iterator when the minibuffer window is scrolled
1396 via the scroll bar.
1397
1398 * window.c (window_scroll_pixel_based): Likewise.
1399
a8e7d6d7 14002012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
1401
1402 * keymap.c (where_is_internal): Doc fix (Bug#10872).
1403
a8e7d6d7 14042012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
1405
1406 * fileio.c (Fcopy_file, Fset_file_selinux_context):
1407 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
1408
a8e7d6d7 14092012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 1410
b593d6a9
AH
1411 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
1412 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 1413
1c6900d9
EZ
14142012-04-26 Eli Zaretskii <eliz@gnu.org>
1415
4c3fa1d9
EZ
1416 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
1417 display element, check also the underlying string or buffer
1418 character. (Bug#11341)
1419
1c6900d9
EZ
1420 * w32menu.c: Include w32heap.h.
1421 (add_menu_item): If the call to AppendMenuW (via
1422 unicode_append_menu) fails, disable Unicode menus only if we are
1423 running on Windows 9X/Me.
1424
42bf8205
AS
14252012-04-24 Andreas Schwab <schwab@linux-m68k.org>
1426
1427 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
1428 (xgetint): Add missing shift for LSB tags.
1429
b1bac16e
MR
14302012-04-24 Martin Rudalics <rudalics@gmx.at>
1431
1432 * keyboard.c (read_char): Don't wipe echo area for select window
1433 events: These might get delayed via `mouse-autoselect-window'
1434 (Bug#11304).
1435
d69621cc
JB
14362012-04-24 Juanma Barranquero <lekktu@gmail.com>
1437
1438 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
1439 manipulation of :loaded-from data.
1440
02fd101b
JB
14412012-04-23 Juanma Barranquero <lekktu@gmail.com>
1442
1443 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
1444 now a cons (bug#11311).
1445
888bec30
PE
14462012-04-23 Paul Eggert <eggert@cs.ucla.edu>
1447
89a438bd
PE
1448 Do not create empty overlays with the evaporate property (Bug#9642).
1449 * buffer.c (Fmove_overlay): Delete an evaporating overlay
1450 if it becomes empty after its bounds are adjusted to fit within
1451 its buffer. Without this fix, in a nonempty buffer (let ((o
1452 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
1453 yields an empty overlay that has the evaporate property, which is
1454 not supposed to happen.
1455
1068fe4d
PE
1456 Fix minor GTK3 problems found by static checking.
1457 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1458 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1459 (struct _EmacsFixedClass, emacs_fixed_get_type):
1460 Move decls here from emacsgtkfixed.h, since they needn't be public.
1461 (emacs_fixed_get_type): Now static.
1462 (emacs_fixed_class_init): Omit unused local.
1463 (emacs_fixed_child_type): Remove; unused.
1464 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1465 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1466 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
1467 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
1468 (EMACS_FIXED_GET_CLASS): Remove; unused.
1469 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
1470
888bec30
PE
1471 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
1472 Problem reported by Juanma Barranquero for Windows -Wunused-function.
1473
de85e130
PE
14742012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1475
d0baac98 1476 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 1477 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
1478 (__malloc_size_t, __malloc_ptrdiff_t):
1479 Remove. All uses removed, replaced by the definiens if needed,
1480 since we can assume C89 or better now.
1481 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
1482 (protect_malloc_state, align, get_contiguous_space)
1483 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
1484 (malloc_atfork_handler_child, malloc_enable_thread)
1485 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
1486 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
1487 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
1488 (special_realloc, _realloc_internal_nolock, _realloc_internal)
1489 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
1490 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
1491 Define using prototypes, not old style.
1492 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
1493 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
1494 (align): Don't assume that signed integer overflow wraps around.
1495 Omit unused local var.
1496 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
1497 (_free_internal_nolock, memalign, mallochook, reallochook):
1498 Omit no-longer-needed casts.
1499 (valloc): Use getpagesize, not __getpagesize.
1500 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
1501 (struct hdr): The 'magic' member is now size_t, not unsigned long.
1502
de85e130
PE
1503 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
1504
dcbf5805
MA
15052012-04-22 Michael Albinus <michael.albinus@gmx.de>
1506
1507 Move functions from C to Lisp. Make non-blocking method calls
1508 the default. Implement further D-Bus standard interfaces.
1509
1510 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
1511 (QCdbus_request_name_allow_replacement)
1512 (QCdbus_request_name_replace_existing)
1513 (QCdbus_request_name_do_not_queue)
1514 (QCdbus_request_name_reply_primary_owner)
1515 (QCdbus_request_name_reply_in_queue)
1516 (QCdbus_request_name_reply_exists)
1517 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
1518 (QCdbus_registered_serial, QCdbus_registered_method)
1519 (QCdbus_registered_signal): New Lisp objects.
1520 (XD_DEBUG_MESSAGE): Use sizeof.
1521 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
1522 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
1523 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
1524 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
1525 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
1526 (xd_signature, xd_append_arg): Allow float for integer types.
1527 (xd_get_connection_references): New function.
b593d6a9
AH
1528 (xd_get_connection_address): Rename from xd_initialize.
1529 Return cached address.
dcbf5805
MA
1530 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
1531 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
1532 level.
1533 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 1534 Return number of refcounts.
dcbf5805
MA
1535 (Fdbus_get_unique_name): Make stronger parameter check.
1536 (Fdbus_message_internal): New defun.
1537 (Fdbus_call_method, Fdbus_call_method_asynchronously)
1538 (Fdbus_method_return_internal, Fdbus_method_error_internal)
1539 (Fdbus_send_signal, Fdbus_register_service)
1540 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
1541 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
1542 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
1543 (Vdbus_compiled_version, Vdbus_runtime_version)
1544 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
1545 (Vdbus_message_type_method_return, Vdbus_message_type_error)
1546 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
1547 (Vdbus_registered_buses, Vdbus_registered_objects_table):
1548 Adapt docstring.
dcbf5805 1549
52828e02
PE
15502012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1551
da05bc4c
PE
1552 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
1553 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
1554 Do not assume ptrdiff_t is the same width as 'int'.
1555
52828e02
PE
1556 * alloc.c: Handle unusual debugging option combinations.
1557 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
1558 since the two debugging options are incompatible.
1559 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
1560 is defined.
1561 (mem_init, mem_insert, mem_insert_fixup):
1562 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
1563 (NEED_MEM_INSERT): Remove; no longer needed.
1564
f01769f9
LL
15652012-04-22 Leo Liu <sdl.web@gmail.com>
1566
1567 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
1568
5790543d
PE
15692012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1570
1571 * sysdep.c [__FreeBSD__]: Minor cleanups.
1572 (list_system_processes, system_process_attributes) [__FreeBSD__]:
1573 Use Emacs indenting style more consistently. Avoid some casts.
1574 Use 'double' consistently rather than mixing 'float' and 'double'.
1575
b91b7e4d
EW
15762012-04-21 Eduard Wiebe <usenet@pusto.de>
1577
b593d6a9
AH
1578 * sysdep.c (list_system_processes, system_process_attributes):
1579 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 1580
6114eb15
AS
15812012-04-21 Andreas Schwab <schwab@linux-m68k.org>
1582
1583 * lisp.mk (lisp): Update.
1584
2f38dff7
PE
15852012-04-20 Paul Eggert <eggert@cs.ucla.edu>
1586
1587 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
1588 It is never used otherwise.
1589
4ae29f89
SM
15902012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
1591
1592 * print.c (print_preprocess): Only check print_depth if print-circle
1593 is nil.
1594 (print_object): Check for cycles even when print-circle is nil and
1595 print-gensym is t, but only check print_depth if print-circle is nil.
1596
f30d612a
CY
15972012-04-20 Chong Yidong <cyd@gnu.org>
1598
1599 * process.c (wait_reading_process_output): If EIO occurs on a pty,
1600 set the status to "failed" and ensure that sentinel is run.
1601
c07a4c0b 16022012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
1603
1604 * process.c (Fset_process_inherit_coding_system_flag)
1605 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 1606 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 1607
c07a4c0b 16082012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
1609
1610 * xdisp.c (string_buffer_position_lim): Limit starting position to
1611 BEGV.
1612 (set_cursor_from_row): If called for a mode-line or header-line
1613 row, return zero immediately.
1614 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
1615 farther than the first row after the header line, if any.
1616 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
1617 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
1618
c07a4c0b 16192012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 1620
4ae29f89
SM
1621 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
1622 (bug#11238).
ad3a2b41 1623
c07a4c0b 16242012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 16252012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
1626
1627 configure: new option --enable-gcc-warnings (Bug#11207)
1628 * Makefile.in (C_WARNINGS_SWITCH): Remove.
1629 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
1630 (ALL_CFLAGS): Use new macros rather than old.
1631 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
1632 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
1633 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
1634 -Wunused-result, -Wunused-variable. This should go away once
1635 the Emacs and Gnulib regex code is merged.
1636 (xmalloc, xrealloc): Now static.
1637
aba027e8
PE
16382012-04-17 Paul Eggert <eggert@cs.ucla.edu>
1639
1640 * dired.c (Fsystem_groups): Remove unused local.
1641
e5a36063
GM
16422012-04-17 Glenn Morris <rgm@gnu.org>
1643
1644 * dired.c (Fsystem_users): Doc fix.
1645
316411f0
DA
16462012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
1647
1648 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
1649 (syms_of_dired): Add them.
1650
9426aba4
PE
16512012-04-16 Paul Eggert <eggert@cs.ucla.edu>
1652
b62a57be
PE
1653 Fix minor alloc.c problems found by static checking.
1654 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
1655 New extern decls, to avoid calling undeclared functions.
1656 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
1657 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
1658 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
1659 (NEED_MEM_INSERT): New macro.
1660 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 1661 Remove one incorrect comment and fix another.
b62a57be 1662
3539f31f
PE
1663 Fix minor ralloc.c problems found by static checking.
1664 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1665 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
1666 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
1667 (r_alloc_sbrk): Now static.
1668
a041960a
PE
1669 Improve ralloc.c interface checking.
1670 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1671 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
1672 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
1673 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
1674 [REL_ALLOC]: ... to here, to check interface.
1675 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
1676 Remove decls. This fixes an "It stinks!".
1677
9426aba4
PE
1678 * alloc.c (which_symbols): Fix alignment issue / type clash.
1679
d55c12ed
AS
16802012-04-15 Andreas Schwab <schwab@linux-m68k.org>
1681
1682 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
1683 (struct Lisp_Misc_Any): Likewise.
1684 (struct Lisp_Free): Likewise.
1685 * alloc.c (union aligned_Lisp_Symbol): Define.
1686 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
1687 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
1688 (union aligned_Lisp_Misc): Define.
1689 (MARKER_BLOCK_SIZE, struct marker_block): Use union
1690 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 1691 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 1692
b948ce8b
PE
16932012-04-14 Paul Eggert <eggert@cs.ucla.edu>
1694
1695 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
1696 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
1697 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
1698 * s/netbsd.h, s/sol2-6.h:
1699 Remove definition of GC_MARK_STACK, since the default now works.
1700 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
1701 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
1702 no longer the default.
1703 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
1704
35dc09a1 17052012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 1706
35dc09a1
GM
1707 * lread.c (lisp_file_lexically_bound_p):
1708 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 1709
35dc09a1
GM
17102012-04-14 Eli Zaretskii <eliz@gnu.org>
1711
1712 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
1713 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
1714
17152012-04-14 Jan Djärv <jan.h.d@swipnet.se>
1716
1717 * nsterm.m (constrainFrameRect): Always constrain when there is only
1718 one screen (Bug#10962).
1719
bcd86815
KB
17202012-04-13 Ken Brown <kbrown@cornell.edu>
1721
1722 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
1723
c25df26e
RT
17242012-04-13 Reuben Thomas <rrt@sc3d.org>
1725
1726 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
1727
0fc59f1e
DC
17282012-04-11 Daniel Colascione <dancol@dancol.org>
1729
1730 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
1731 against is gone. It's better to use vfork now so that when Cygwin
1732 gains a new, working vfork, we use it automatically (bug#10398).
1733
de8c03dc
SM
17342012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1735
1736 * window.c (save_window_save): Obey window-point-insertion-type.
1737
2f097256
GM
17382012-04-11 Glenn Morris <rgm@gnu.org>
1739
1740 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
1741
453b951e
SM
17422012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1743
1744 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
1745
75f1671a 17462012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
1747
1748 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
1749 (force_quit_count): New var.
1750 (handle_interrupt): Use it.
1751
2a8ce227
JB
17522012-04-10 Juanma Barranquero <lekktu@gmail.com>
1753
1754 * w32.c (w32_delayed_load): Record the full path of the library
1755 being loaded (bug#10424).
1756
935396c0
GM
17572012-04-09 Glenn Morris <rgm@gnu.org>
1758
05920a43
GM
1759 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
1760 not just in the obarray, before snarfing them. (Bug#11036)
1761
935396c0
GM
1762 * Makefile.in ($(leimdir)/leim-list.el):
1763 Pass EMACS rather than BUILT_EMACS.
1764
a18ecafa
TZ
17652012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
1766
1767 * process.c (make_process):
1768 * process.h: Add integer `gnutls_handshakes_tried' member to
1769 process struct.
1770
6bbef4e5
JC
1771 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
1772 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
1773
1774 * gnutls.c (gnutls_log_function2i): Convenience log function.
1775 (emacs_gnutls_read): Use new log functions,
1776 `gnutls_handshakes_tried' process member, and
1777 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
1778 attempts per process (connection).
1779
b4d3bc10
CY
17802012-04-09 Chong Yidong <cyd@gnu.org>
1781
1782 * eval.c (Fuser_variable_p, user_variable_p_eh)
1783 (lisp_indirect_variable): Functions deleted.
1784 (Fdefvar): Caller changed.
1785
1786 * callint.c (Finteractive, Fcall_interactively):
1787 * minibuf.c (Fread_variable): Callers changed.
1788
70f4d973
EZ
17892012-04-09 Eli Zaretskii <eliz@gnu.org>
1790
1791 * xdisp.c (set_cursor_from_row): If the display string appears in
1792 the buffer at position that is closer to point than the position
1793 after the display string, display the cursor on the first glyph of
1794 the display string. Fixes cursor display when a 'display' text
1795 property immediately follows invisible text. (Bug#11094)
1796
cb3c2e3e
PE
17972012-04-09 Paul Eggert <eggert@cs.ucla.edu>
1798
1799 composite.c: use 'double' consistently
1800 * composite.c (get_composition_id): Use 'double' consistently
1801 instead of converting 'float' to 'double' and vice versa; this is
1802 easier to understand and avoids a GCC warning.
1803
fd06db5d
GM
18042012-04-09 Glenn Morris <rgm@gnu.org>
1805
50fe702a
GM
1806 * Makefile.in: Generate leim-list with bootstrap-emacs, in
1807 preparation for dumping it with emacs. (Bug#4789)
1808 (leimdir): New variable.
1809 ($(leimdir)/leim-list.el): New rule.
1810 (emacs$(EXEEXT)): Depend on leim-list.el.
1811
fd06db5d
GM
1812 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
1813 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
1814 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
1815
55c131ee
AS
18162012-04-08 Andreas Schwab <schwab@linux-m68k.org>
1817
1818 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
1819 proper alignment.
1820
9209588f
JB
18212012-04-07 Juanma Barranquero <lekktu@gmail.com>
1822
1823 * xml.c (init_libxml2_functions) [WINDOWSNT]:
1824 Remove unused local variable.
1825
e3fb2efb
PE
18262012-04-07 Paul Eggert <eggert@cs.ucla.edu>
1827
1828 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
1829 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
1830 (mark_memory): Mark Lisp_Objects only if pointers might hide in
1831 objects, as mark_maybe_pointer will catch them otherwise.
1832 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
1833 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
1834
b5385551
PE
18352012-04-07 Paul Eggert <eggert@cs.ucla.edu>
1836
1837 Fix typo that broke non-Windows builds.
1838 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
1839
9078ead6
EZ
18402012-04-07 Eli Zaretskii <eliz@gnu.org>
1841
1842 Support building on MS-Windows with libxml2.
1843
1844 * makefile.w32-in (OBJ2): Add xml.$(O).
1845 (GLOBAL_SOURCES): Add xml.c.
1846 ($(BLD)/xml.$(O)): New dependency list.
1847
1848 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
1849 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
1850 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
1851 [!WINDOWSNT]: New macros.
1852 (init_libxml2_functions, libxml2_loaded_p): New functions.
1853 (parse_region): Call fn_xmlCheckVersion instead of using the macro
1854 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
1855 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
1856 Calls xmlCleanupParser only if libxml2 was loaded (or statically
1857 linked in).
6bbef4e5
JC
1858 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
1859 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
1860 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
1861
1862 * emacs.c: Don't include libxml/parser.h.
1863 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
1864 xmlCleanupParser directly.
1865
1866 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
1867
3811fdf3
EZ
18682012-04-07 Eli Zaretskii <eliz@gnu.org>
1869
1870 * indent.c (Fvertical_motion): If there is a display string at
1871 point, use it.vpos to compute how many lines to backtrack after
1872 move_it_to point. (Bug#11133)
1873
2f8e16b2
EZ
18742012-04-06 Eli Zaretskii <eliz@gnu.org>
1875
1876 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
1877 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
1878 about subtle differences between FETCH_CHAR* and STRING_CHAR*
1879 macros related to unification of CJK characters. For the details,
1880 see the discussion following the message here:
1881 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
1882
3d439cd1
CY
18832012-04-04 Chong Yidong <cyd@gnu.org>
1884
1885 * keyboard.c (Vdelayed_warnings_list): Doc fix.
1886
8bc53d00
EZ
18872012-04-01 Eli Zaretskii <eliz@gnu.org>
1888
1889 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
1890 instead of alloca. (Bug#11138)
1891
3b0512a3
AS
18922012-04-01 Andreas Schwab <schwab@linux-m68k.org>
1893
1894 * w32menu.c (is_simple_dialog): Properly check lisp types.
1895 (Bug#11141)
1896
8427ddd2
EZ
18972012-03-31 Eli Zaretskii <eliz@gnu.org>
1898
979022ef
EZ
1899 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
1900 position we get to after a call to move_it_to fails the
1901 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
1902 only if we wind up in a string from display property. (Bug#11063)
1903
a6b1c7cc
EZ
1904 * window.c (Fdelete_other_windows_internal): Invalidate the row
1905 and column information about mouse highlight, so that redisplay
1906 restores it after reallocating the glyph matrices. (Bug#7464)
1907
8427ddd2
EZ
1908 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
1909 string comes from a `display' text property, use the buffer
1910 position of that property as if we actually saw that position in
1911 the row's glyphs.
697ba24b
EZ
1912 (move_it_by_lines): Remove the assertion that
1913 "it->current_x == 0 && it->hpos == 0" which can be legitimately
1914 violated when there's a before-string at the beginning of a line.
1915 (Bug#11063)
8427ddd2 1916
65a0a738
EZ
19172012-03-30 Eli Zaretskii <eliz@gnu.org>
1918
1919 * xdisp.c (append_space_for_newline): If the default face was
1920 remapped, use the remapped face for the appended newline.
1921 (extend_face_to_end_of_line): Use the remapped default face for
1922 extending the face to the end of the line.
1923 (display_line): Call extend_face_to_end_of_line when the default
1924 face was remapped. (Bug#11068)
1925
581355cc
EZ
19262012-03-29 Eli Zaretskii <eliz@gnu.org>
1927
1928 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
1929
e8fc049f
SM
19302012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1931
1932 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
1933
4fb9a543
GM
19342012-03-27 Glenn Morris <rgm@gnu.org>
1935
1936 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
1937 Doc fixes.
1938
679910f1
KH
19392012-03-26 Kenichi Handa <handa@m17n.org>
1940
1941 * dispextern.h (struct glyph): Fix previous change. Change the
1942 bit length of glyphless.ch to 25 (Bug#11082).
1943
90d49b7f
CY
19442012-03-26 Chong Yidong <cyd@gnu.org>
1945
1946 * keyboard.c (Vselection_inhibit_update_commands): New variable.
1947 (command_loop_1): Use it; inhibit selection update for
1948 handle-select-window too (Bug#8996).
1949
f514f6f0
FP
19502012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
1951
e8fc049f 1952 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 1953
bf43fa51
KH
19542012-03-25 Kenichi Handa <handa@m17n.org>
1955
1956 * dispextern.h (struct glyph): Change the bit length of
1957 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
1958
8a0c01dd
EZ
19592012-03-24 Eli Zaretskii <eliz@gnu.org>
1960
1961 * s/ms-w32.h (tzname): Include time.h before redirecting to
1962 _tzname. Fixes the MSVC build. (Bug#9960)
1963
7d1c3a76
AS
19642012-03-24 Andreas Schwab <schwab@linux-m68k.org>
1965
8ed79523
AS
1966 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
1967 characters.
1968
7d1c3a76
AS
1969 * xterm.c (XTread_socket): Only modify handling_signal if
1970 !SYNC_INPUT. (Bug#11080)
1971
e99a9b8b
EZ
19722012-03-23 Eli Zaretskii <eliz@gnu.org>
1973
1974 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
1975 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
1976 when fetching a multibyte character consumes more bytes than
1977 CHAR_BYTES returns, due to unification of CJK characters in
1978 string_char. (Bug#11073)
1979
5063c0e1
TN
19802012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
1981
1982 * process.c (wait_reading_process_output): Handle pty disconnect
1983 by refraining from sending oneself a SIGCHLD (bug#10933).
1984
9f851fbd
CY
19852012-03-22 Chong Yidong <cyd@gnu.org>
1986
1987 * dispextern.h (struct it): New member string_from_prefix_prop_p.
1988
5063c0e1 1989 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
1990 Mark string as coming from a prefix property.
1991 (handle_face_prop): Use default face for prefix strings (Bug#4281).
1992 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
1993
fb5b8aca
CY
19942012-03-21 Chong Yidong <cyd@gnu.org>
1995
1996 * xfaces.c (Vface_remapping_alist): Doc fix.
1997
62356a1b
EZ
19982012-03-20 Eli Zaretskii <eliz@gnu.org>
1999
2000 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
2001 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
2002 Doc fixes.
62356a1b 2003
025de85b
CY
20042012-03-20 Chong Yidong <cyd@gnu.org>
2005
2006 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
2007 to reflect default non-nil value of redisplay-dont-pause.
2008
4827f94e
KH
20092012-03-19 Kenichi Handa <handa@m17n.org>
2010
2011 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
2012 it fit in a valid range (Bug#11003).
2013
e50a24a2
EZ
20142012-03-18 Eli Zaretskii <eliz@gnu.org>
2015
2016 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
2017 that is not from display property, accept the row as a "cursor
2018 row" if one of the string's character has a non-nil `cursor'
2019 property. Fixes cursor positioning when there are newlines in
2020 overlay strings, e.g. in icomplete.el. (Bug#11035)
2021
9af5ed87
PE
20222012-03-12 Paul Eggert <eggert@cs.ucla.edu>
2023
2024 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
2025
d1f55f16
CY
20262012-03-12 Chong Yidong <cyd@gnu.org>
2027
2028 * eval.c (inhibit_lisp_code): Rename from
2029 inhibit_window_configuration_change_hook; move from window.c.
2030
2031 * xfns.c (unwind_create_frame_1, Fx_create_frame):
2032 * window.c (run_window_configuration_change_hook)
2033 (syms_of_window): Callers changed.
2034
66c5eebd
CY
20352012-03-11 Chong Yidong <cyd@gnu.org>
2036
413df973
CY
2037 * keymap.c (Fkey_description): Doc fix (Bug#9700).
2038
66c5eebd
CY
2039 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
2040
1de11f56
CY
20412012-03-10 Chong Yidong <cyd@gnu.org>
2042
2043 * frame.c (other_visible_frames): Don't assume the selected frame
2044 is visible (Bug#10955).
2045
cae07000
SM
20462012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
2047
2048 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
2049
89c94350
JD
20502012-03-08 Jan Djärv <jan.h.d@swipnet.se>
2051
2052 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
2053 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
2054 zero (Bug#10954).
2055
999dd333
GM
20562012-03-03 Glenn Morris <rgm@gnu.org>
2057
01a6dcc8 2058 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 2059
de0100f2
EZ
20602012-03-02 Eli Zaretskii <eliz@gnu.org>
2061
2062 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
2063 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
2064 (redisplay_window, next_element_from_string): Fix typos in
2065 comments.
3e441275
EZ
2066 (redisplay_window): Pass to move_it_vertically the margin in
2067 pixels, not in screen lines.
de0100f2 2068
96a72ee9
GM
20692012-03-02 Glenn Morris <rgm@gnu.org>
2070
2071 * buffer.c (buffer-list-update-hook): Doc fix.
2072
312508d7
EZ
20732012-02-29 Eli Zaretskii <eliz@gnu.org>
2074
2075 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
2076 push_it before setting up the iterator for the first overlay
2077 string, even if we have an empty string loaded.
2078 (next_overlay_string): If there's an empty string on the iterator
2079 stack, pop the stack. (Bug#10903)
2080
27f3c637
PE
20812012-02-25 Paul Eggert <eggert@cs.ucla.edu>
2082
2083 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
2084 Suggested by Stefan Monnier in
2085 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
2086 * alloc.c (widen_to_Lisp_Object): New static function.
2087 (mark_memory): Also mark Lisp_Objects by fetching pointer words
2088 and widening them to Lisp_Objects. This would work even if
2089 USE_LSB_TAG is defined and wide integers are used, which might
2090 happen in a future version of Emacs.
2091
3c9dfce6
CY
20922012-02-25 Chong Yidong <cyd@gnu.org>
2093
fa74b241
CY
2094 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
2095 Doc fix.
2096
3c9dfce6
CY
2097 * xselect.c (Fx_selection_exists_p): Doc fix.
2098 (x_clipboard_manager_save_all): Print an informative message
2099 before saving to clipboard manager.
2100
9486df08
CY
21012012-02-24 Chong Yidong <cyd@gnu.org>
2102
2103 * keyboard.c (process_special_events): Handle all X selection
2104 requests in kbd_buffer, not just the next one (Bug#8869).
2105
f01d3321
CY
21062012-02-23 Chong Yidong <cyd@gnu.org>
2107
2108 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
2109 call when setting menu-bar-lines and tool-bar-lines parameters.
2110 (unwind_create_frame_1): New helper function.
2111
2112 * window.c (inhibit_window_configuration_change_hook): New var.
2113 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 2114 (syms_of_window): Initialize it.
f01d3321 2115
86b847b6
CY
21162012-02-22 Chong Yidong <cyd@gnu.org>
2117
2118 * xterm.c (x_draw_image_relief): Add missing type check for
2119 Vtool_bar_button_margin (Bug#10743).
2120
a59225b1
CY
21212012-02-21 Chong Yidong <cyd@gnu.org>
2122
2123 * fileio.c (Vfile_name_handler_alist): Doc fix.
2124
2125 * buffer.c (Fget_file_buffer): Protect against invalid file
2126 handler return value.
2127
310f5bd4
PE
21282012-02-20 Paul Eggert <eggert@cs.ucla.edu>
2129
cb3a28cc
PE
2130 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
2131 when computing $valmask.
2132
310f5bd4
PE
2133 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
2134 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
2135 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
2136 It's useless in that case, and it can cause problems on hosts
2137 that allocate halves of EMACS_INT values separately.
2138 Reported by Dan Horák. Diagnosed by Andreas Schwab in
2139 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
2140 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
2141 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
2142 it avoids undefined behavior on hosts where shifting right by more
2143 than the word width has undefined behavior.
2144
2375c96a
CY
21452012-02-19 Chong Yidong <cyd@gnu.org>
2146
2147 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
2148 (Funhandled_file_name_directory, Ffile_name_as_directory)
2149 (Fdirectory_file_name, Fexpand_file_name)
2150 (Fsubstitute_in_file_name): Protect against invalid file handler
2151 return values (Bug#10845).
2152
3eb49e71
EZ
21532012-02-18 Eli Zaretskii <eliz@gnu.org>
2154
2155 * .gdbinit (pitx): Fix incorrect references to fields of the
2156 iterator stack.
2157
7b926f3f
CY
21582012-02-17 Chong Yidong <cyd@gnu.org>
2159
2160 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
2161
11273115
PE
21622012-02-15 Paul Eggert <eggert@cs.ucla.edu>
2163
2164 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
2165 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
2166
c3a70e2b
CY
21672012-02-15 Chong Yidong <cyd@gnu.org>
2168
2169 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
2170 marked as special. Also, starting docstrings with * is obsolete.
2171
0ca43699
AS
21722012-02-13 Andreas Schwab <schwab@linux-m68k.org>
2173
2174 * gnutls.c (emacs_gnutls_write): Fix last change.
2175
2e8f3c56
LI
21762012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
2177
2178 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
2179 send_process.
2180
af70074f
SM
21812012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
2182
2183 * keymap.c (Fsingle_key_description): Handle char ranges.
2184
95986d52
CY
21852012-02-12 Chong Yidong <cyd@gnu.org>
2186
afd83bd1
CY
2187 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
2188 as that creates a dangerous corner case.
2189
95986d52
CY
2190 * window.c (Fdelete_window_internal): Invalidate the mouse
2191 highlight (Bug#9904).
2192
bd7da63e
GM
21932012-02-12 Glenn Morris <rgm@gnu.org>
2194
2195 * xselect.c (Fx_own_selection_internal)
2196 (Fx_get_selection_internal, Fx_disown_selection_internal)
2197 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
2198 * nsselect.m (Fx_own_selection_internal)
2199 (Fx_disown_selection_internal, Fx_selection_exists_p)
2200 (Fx_selection_owner_p, Fx_get_selection_internal):
2201 Sync docs and argument specs with the xselect.c versions.
2202
77abcbc2
LI
22032012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
2204
2205 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
2206
90b671e2
EZ
22072012-02-11 Eli Zaretskii <eliz@gnu.org>
2208
1c0ca0b7
EZ
2209 * w32select.c (Fx_selection_exists_p): Sync doc string and
2210 argument list with xselect.c. (Bug#10783)
2211
2212 * w16select.c (Fx_selection_exists_p): Sync doc string and
2213 argument list with xselect.c. (Bug#10783)
90b671e2 2214
49241268
GM
22152012-02-10 Glenn Morris <rgm@gnu.org>
2216
2217 * fns.c (Fsecure_hash): Doc fix.
2218
f998bbe7 22192012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
2220
2221 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
2222
0992bd9c
CY
22232012-02-07 Chong Yidong <cyd@gnu.org>
2224
2225 * buffer.c (Fbuffer_local_variables)
2226 (buffer_lisp_local_variables): Handle unbound vars correctly;
2227 don't let Qunbound leak into Lisp.
2228
af008560
GM
22292012-02-07 Glenn Morris <rgm@gnu.org>
2230
dd605cc4
GM
2231 * image.c (Fimagemagick_types): Doc fix.
2232
af008560
GM
2233 * image.c (imagemagick-render-type): Change it from a lisp object
2234 to an integer. Move the doc here from the lisp manual.
2235 Treat all values not equal to 0 the same.
2236
1449fa1d
CY
22372012-02-06 Chong Yidong <cyd@gnu.org>
2238
2239 * doc.c (store_function_docstring): Avoid applying docstring of
2240 alias to base function (Bug#2603).
2241
3723ec07
AS
22422012-02-04 Andreas Schwab <schwab@linux-m68k.org>
2243
2244 * .gdbinit (pp1, pv1): Remove redundant defines.
2245 (pr): Use pp.
2246
79c1cc1e
CY
22472012-02-04 Chong Yidong <cyd@gnu.org>
2248
2249 * nsterm.m: Declare a global (Bug#10694).
2250
d7f29f8e
EZ
22512012-02-04 Eli Zaretskii <eliz@gnu.org>
2252
cae07000
SM
2253 * w32.c (get_emacs_configuration_options):
2254 Include --enable-checking, if specified, in the return value.
d7f29f8e 2255
3b95a6f9
MR
22562012-02-04 Martin Rudalics <rudalics@gmx.at>
2257
2258 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
2259 after rounding frame sizes. (Bug#9723)
2260
d6fa96a6
EZ
22612012-02-04 Eli Zaretskii <eliz@gnu.org>
2262
2263 * keyboard.c (adjust_point_for_property): Don't position point
2264 before BEGV. (Bug#10696)
2265
df0b2940
PE
22662012-02-03 Paul Eggert <eggert@cs.ucla.edu>
2267
2268 Handle overflow when computing char display width (Bug#9496).
2269 * character.c (char_width): Return EMACS_INT, not int.
2270 (char_width, c_string_width): Check for overflow when
2271 computing the width; this is possible now that individual
2272 characters can have unbounded width. Problem introduced
2273 by merge from Emacs 23 on 2012-01-19.
2274
6bee44d6
MA
22752012-02-02 Michael Albinus <michael.albinus@gmx.de>
2276
2277 * dbusbind.c (Fdbus_register_method): Mention the return value
2278 :ignore in the docstring.
2279
44f92739
GM
22802012-02-02 Glenn Morris <rgm@gnu.org>
2281
1b9f60cc
GM
2282 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
2283
44f92739
GM
2284 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2285 Unconditionally set to t. (Bug#10673)
2286 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2287 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2288 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
2289
c5d3843c
KH
22902012-02-02 Kenichi Handa <handa@m17n.org>
2291
2292 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
2293 0, do not call append_composite_glyph.
2294
159462d4 22952012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
2296
2297 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
2298 NULL (Bug#6988).
2299 (x_produce_glyphs): If the component of a composition is a null
2300 string, set it->pixel_width to 1 to avoid zero-width glyph.
2301
78cef877
EZ
23022012-02-01 Eli Zaretskii <eliz@gnu.org>
2303
2304 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
2305 first 2 arguments are identical. This makes inserting large
2306 output from a subprocess an order of magnitude faster on
2307 MS-Windows, where all sbrk'ed memory is always contiguous.
2308
97897668
GM
23092012-01-31 Glenn Morris <rgm@gnu.org>
2310
2311 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 2312 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
2313 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
2314
31fd3586
GM
23152012-01-29 Glenn Morris <rgm@gnu.org>
2316
2317 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
2318
0e24a8b2
CY
23192012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
2320
2321 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
2322
cc0adcb0
CY
23232012-01-28 Chong Yidong <cyd@gnu.org>
2324
2325 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
2326
acc28cb9
CY
23272012-01-26 Chong Yidong <cyd@gnu.org>
2328
9c69cfb7
CY
2329 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
2330
acc28cb9
CY
2331 * search.c (Fsearch_forward, Fsearch_backward): Document negative
2332 repeat counts (Bug#10507).
2333
48da7392
GM
23342012-01-26 Glenn Morris <rgm@gnu.org>
2335
2336 * lread.c (syms_of_lread): Doc fix.
2337
14af5f7f
CY
23382012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
2339
2340 * coding.c (encode_designation_at_bol): Change return value to
2341 EMACS_INT.
2342
0b21c100
CY
23432012-01-25 Chong Yidong <cyd@gnu.org>
2344
2345 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
2346
3c2907f7
CY
23472012-01-21 Chong Yidong <cyd@gnu.org>
2348
2349 * floatfns.c (Fcopysign): Make the second argument non-optional,
2350 since nil is not allowed anyway.
2351
959ad23f
AS
23522012-01-21 Andreas Schwab <schwab@linux-m68k.org>
2353
2354 * process.c (read_process_output): Use p instead of XPROCESS (proc).
2355 (send_process): Likewise.
2356
34a02f46
MR
23572012-01-19 Martin Rudalics <rudalics@gmx.at>
2358
2359 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
2360 (Vwindow_persistent_parameters): Do not use Qstate.
2361 Rewrite doc-strings.
34a02f46 2362
1259009a 23632012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
2364
2365 * character.c (char_width): New function.
70d4fdf6
GM
2366 (Fchar_width, c_string_width, lisp_string_width):
2367 Use char_width (Bug#9496).
25ed9e61 2368
6a6ee00d
MR
23692012-01-16 Martin Rudalics <rudalics@gmx.at>
2370
2371 * window.c (Vwindow_persistent_parameters): New variable.
2372 (Fset_window_configuration, save_window_save): Handle persistent
2373 window parameters.
2374
c85efaf7
EZ
23752012-01-14 Eli Zaretskii <eliz@gnu.org>
2376
2377 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
2378 thrashing the stack of the thread. (Bug#9087)
2379
5944709e
PE
23802012-01-12 Paul Eggert <eggert@cs.ucla.edu>
2381
2382 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
2383
e71f5d99
EZ
23842012-01-11 Eli Zaretskii <eliz@gnu.org>
2385
2386 * xdisp.c (rows_from_pos_range): Handle the case where the
2387 highlight ends on a newline. (Bug#10464)
2388 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
2389 he end column for display of highlight that ends on a newline
2390 before a R2L line.
2391
ce316182
GM
23922012-01-11 Glenn Morris <rgm@gnu.org>
2393
2394 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
2395 from load-path also when installation-directory is nil. (Bug#10208)
2396
5b43da69
GM
23972012-01-10 Glenn Morris <rgm@gnu.org>
2398
74cc8ff9
GM
2399 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
2400
7d8d6e4e
GM
2401 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
2402 Update template values to be closer to their typical values these days.
5b43da69 2403
a0db8d43
EZ
24042012-01-09 Eli Zaretskii <eliz@gnu.org>
2405
2406 * xdisp.c (rows_from_pos_range): Accept additional argument
2407 DISP_STRING, and accept any glyph in a row whose object is that
2408 string as eligible for mouse highlight. Fixes mouse highlight of
2409 display strings from overlays. (Bug#10464)
2410
9a0115ab 24112012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 2412
b9110d6a 2413 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
2414 * fileio.c (auto_saving_dir_umask): New static var.
2415 (Fmake_directory_internal): Use it.
2416 (do_auto_save_make_dir): Set it, instead of invoking chmod after
2417 creating the directory. The old code temporarily assigns
2418 too-generous permissions to the directory.
2419 (do_auto_save_eh): Clear it.
b9110d6a 2420 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
2421 that the var is always cleared.
2422
6c1bd3f3
EZ
24232012-01-07 Eli Zaretskii <eliz@gnu.org>
2424
2425 * search.c (scan_buffer): Pass character positions to
2426 know_region_cache, not byte positions. (Bug#6540)
2427
069d2b50
L
24282012-01-07 LynX <_LynX@bk.ru> (tiny change)
2429
2430 * w32.c (sys_rename): Report EXDEV when rename of a directory
2431 fails because the target is on another logical disk. (Bug#10284)
2432
75bf0d33
DB
24332012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
2434
2435 * xterm.c (x_embed_request_focus): New function.
2436
2437 * xterm.h: Add prototype.
2438
2439 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
2440
1c6e5a32
GM
24412012-01-05 Glenn Morris <rgm@gnu.org>
2442
2443 * emacs.c (emacs_copyright): Update short copyright year to 2012.
2444
651e947e
EZ
24452012-01-01 Eli Zaretskii <eliz@gnu.org>
2446
2447 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
2448 Load gnutls_transport_set_lowat only if GnuTLS version is below
2449 2.11.1.
2450 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
2451 GnuTLS versions below 2.11.1.
2452
3778cdd8
AL
24532011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
2454
2455 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
2456 to the doc string advising against its use for altering the way
2457 windows are scrolled.
2458
0e5317f7
KH
24592011-12-28 Kenichi Handa <handa@m17n.org>
2460
2461 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
2462 coding-system ASCII compatible only when it does not produce BOM
2463 on encoding (Bug#10383).
2464
93d5ca1f
JD
24652011-12-26 Jan Djärv <jan.h.d@swipnet.se>
2466
2467 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
2468 can scroll.
2469 (create_and_show_popup_menu): Always use menu_position_func for
2470 Gtk3 (Bug#10361).
2471
ca22b785
AS
24722011-12-24 Andreas Schwab <schwab@linux-m68k.org>
2473
2474 * callint.c (Fcall_interactively): Don't truncate prompt string.
2475
d048e1e6
EZ
24762011-12-23 Eli Zaretskii <eliz@gnu.org>
2477
2478 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
2479 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 2480 resumed from there (after widening). (Bug#10360)
d048e1e6 2481
5ccaba1f
JD
24822011-12-22 Jan Djärv <jan.h.d@swipnet.se>
2483
2484 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
2485
204ee57f
JD
24862011-12-21 Jan Djärv <jan.h.d@swipnet.se>
2487
b81d40f0
JB
2488 * nsterm.m (x_free_frame_resources):
2489 Release f->output_data.ns->miniimage.
204ee57f
JD
2490 (ns_index_color): Fix indentation. Do not retain
2491 color_table->colors[i].
2492
2493 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
2494 before returning.
2495
2496 * nsfns.m (x_set_background_color): Assign return value from
2497 ns_index_color to face-background instead of NSColor*.
2498 (ns_implicitly_set_icon_type): Fix indentation.
2499 Change assignment in for loop to comparison.
2500
2501 * emacs.c (ns_pool): New variable.
2502 (main): Assign ns_pool.
2503 (Fkill_emacs): Call ns_release_autorelease_pool.
2504
2505 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
2506 autorelease fdesc, release fdAttrs and tdict.
2507 (ns_get_covering_families): Release charset.
2508 (ns_findfonts): Release NSFontDescriptor created with new.
2509 (ns_uni_to_glyphs): Fix indentation.
2510 (setString): Release attrStr before assigning new value.
2511
c803b2b7
JD
25122011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2513
678f4426
JD
2514 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
2515 and NS_IMPL_COCOA.
2516 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
2517 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
2518
cd394be1 25192011-12-18 David Reitter <reitter@cmu.edu>
678f4426 2520
5fecd5fc
JD
2521 * nsterm.m (ns_term_init): Subscribe for notifications
2522 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
2523 to method trackingNotification in EmacsMenu.
2524
2525 * nsmenu.m (trackingMenu): New variable.
3771cb17 2526 (trackingNotification): New method (from Aquamacs).
5fecd5fc 2527 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 2528 from Aquamacs (Bug#7030).
678f4426
JD
2529
25302011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 2531
c803b2b7
JD
2532 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
2533 (symbol_to_nsstring): Fix indentation.
2534 (ns_symbol_to_pb): New function.
cae07000
SM
2535 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
2536 (Fns_rotate_cut_buffers_internal): Remove.
2537 (Fns_store_selection_internal): Rename from
c803b2b7
JD
2538 Fns_store_cut_buffer_internal.
2539 (ns_get_foreign_selection, Fx_own_selection_internal)
2540 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
2541 (Fns_get_selection_internal, Fns_store_selection_internal):
2542 Use ns_symbol_to_pb and check if return value is nil.
2543 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
2544 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
2545 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
2546 renamed to Sns_store_selection_internal.
2547 (ns_handle_selection_request): Move code to Fx_own_selection_internal
2548 and remove this function.
2549 (ns_handle_selection_clear): Remove, never used.
2550 (Fx_own_selection_internal): Move code from ns_handle_selection_request
2551 here.
2552
e1b01a3a
KB
25532011-12-17 Ken Brown <kbrown@cornell.edu>
2554
2555 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
2556 GID is unknown (Bug#10257).
2557
2adb6e85
PE
25582011-12-17 Paul Eggert <eggert@cs.ucla.edu>
2559
2560 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
2561 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
2562 which caused a build failure on GNU/Linux IA-64. This problem was
2563 introduced by my 2011-10-07 patch.
2564
d1d7b339
JL
25652011-12-15 Juri Linkov <juri@jurta.org>
2566
2567 * image.c (imagemagick_error): New function. (Bug#10112)
2568 (imagemagick_load_image): Comment out `MagickSetResolution' call.
2569 Use `imagemagick_error' where ImageMagick functions return
2570 `MagickFalse'.
2571 (Fimagemagick_types): Add `Fnreverse' to return the list in the
2572 proper order.
2573
100d5755
KH
25742011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2575
2576 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
2577 fill background (Bug#8992).
2578
454592a6
MR
25792011-12-13 Martin Rudalics <rudalics@gmx.at>
2580
2581 * window.c (Vwindow_combination_resize)
2582 (Vwindow_combination_limit): Use t instead of non-nil in
2583 doc-strings.
61d4b438
MR
2584 (Vrecenter_redisplay): Add first sentence of doc-string on
2585 separate line.
53524d93 2586 (Frecenter): Fix doc-string typo.
454592a6 2587
3633e3aa
KH
25882011-12-11 Kenichi Handa <handa@m17n.org>
2589
2590 * coding.c (Funencodable_char_position): Pay attention to the
2591 buffer text relocation (Bug#9389).
2592
7b9d523a 25932011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 2594
7b9d523a
JD
2595 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
2596 gtk_init (Bug#10100).
2597
b73189c6
EZ
25982011-12-10 Eli Zaretskii <eliz@gnu.org>
2599
2600 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
2601 IT->string is nil. (Bug#10263)
2602
f7dfe5d6
JD
26032011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2604
83faebb4
JD
2605 * nsterm.h (x_free_frame_resources): Declare.
2606
f7dfe5d6
JD
2607 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
2608 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
2609
2610 * nsterm.h (ns_get_defaults_value): Declare.
2611
2612 * nsterm.m (ns_default): Call ns_get_defaults_value.
2613
7cd4e72c
EZ
26142011-12-09 Eli Zaretskii <eliz@gnu.org>
2615
2616 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
2617 (Bug#10170)
2618
b34d7317
YM
26192011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2620
2621 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
2622 that where the value of an _OBJC_* symbol points to is in the .bss
2623 section (Bug#10240).
2624
76470ad1
KH
26252011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2626
2627 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 2628 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 2629
745fff94
KH
26302011-12-08 Kenichi Handa <handa@m17n.org>
2631
2632 * ftfont.c (get_adstyle_property): Fix previous change
2633 (Bug#10233).
2634
6e44397c
JB
26352011-12-07 Juanma Barranquero <lekktu@gmail.com>
2636
2637 * w32.c (init_environment): If no_site_lisp, remove site-lisp
2638 dirs from the default value of EMACSLOADPATH (bug#10208).
2639
7efa6272
GM
26402011-12-07 Glenn Morris <rgm@gnu.org>
2641
2642 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
2643 installation and source directories as well. (Bug#10208)
2644
f6fc4d87
CY
26452011-12-06 Chong Yidong <cyd@gnu.org>
2646
2647 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
2648
2bf26180
GM
26492011-12-06 Glenn Morris <rgm@gnu.org>
2650
2651 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
2652 as an error, not just -1. (Bug#10217)
2653
3a6ad4f0
CY
26542011-12-05 Chong Yidong <cyd@gnu.org>
2655
2656 * keyboard.c (process_special_events): New function.
2657 (swallow_events, Finput_pending_p): Use it (Bug#10195).
2658
75a3b399
PE
26592011-12-05 Paul Eggert <eggert@cs.ucla.edu>
2660
2661 * coding.c (encode_designation_at_bol): Don't use uninitialized
2662 local variable (Bug#9318).
2663
c3c9e25e
KH
26642011-12-05 Kenichi Handa <handa@m17n.org>
2665
2666 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
2667 return Qnil (Bug#8046, Bug#10193).
2668
5eb05ea3
KH
26692011-12-05 Kenichi Handa <handa@m17n.org>
2670
2671 * coding.c (encode_designation_at_bol): New args charbuf_end and
2672 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
2673 (coding_set_source): Return how many bytes coding->source was
2674 relocated.
2675 (coding_set_destination): Return how many bytes
2676 coding->destination was relocated.
2677 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 2678 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
2679
26802011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2681
2682 * coding.c (CODING_CHAR_CHARSET_P): New macro.
2683 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
2684 macro (Bug#9318).
2685
26862011-12-05 Andreas Schwab <schwab@linux-m68k.org>
2687
2688 The following changes are to fix Bug#9318.
2689
a79703f5 2690 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
2691 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
2692 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 2693 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 2694
7dbda6df
JB
26952011-12-05 Juanma Barranquero <lekktu@gmail.com>
2696
2697 * lisp.h (process_quit_flag): Fix external declaration.
2698
6d5eb5b0
SM
26992011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
2700
2701 Don't macro-inline non-performance-critical code.
2702 * eval.c (process_quit_flag): New function.
2703 * lisp.h (QUIT): Use it.
2704
a0c3fad0
JD
27052011-12-04 Jan Djärv <jan.h.d@swipnet.se>
2706
2707 * nsfns.m (get_geometry_from_preferences): New function.
2708 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
2709
6c07aac2
AS
27102011-12-04 Andreas Schwab <schwab@linux-m68k.org>
2711
2712 * emacs.c (Qkill_emacs): Define.
2713 (syms_of_emacs): Initialize it.
2714 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
2715 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
2716 (quit_throw_to_read_char): Add parameter `from_signal'.
2717 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
2718 * lisp.h (QUIT): Call Fkill_emacs if requested.
2719
c052ead4
JD
27202011-12-03 Jan Djärv <jan.h.d@swipnet.se>
2721
2722 * widget.c (update_wm_hints): Return if wmshell is null.
2723 (widget_update_wm_size_hints): New function.
2724
2725 * widget.h (widget_update_wm_size_hints): Declare.
2726
2727 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
2728 widget_update_wm_size_hints (Bug#10104).
2729
9e49252b
EZ
27302011-12-03 Eli Zaretskii <eliz@gnu.org>
2731
2732 * xdisp.c (handle_invisible_prop): If the invisible text ends just
2733 before a newline, prepare the bidi iterator for consuming the
2734 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 2735 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 2736
02b16839
JL
27372011-12-02 Juri Linkov <juri@jurta.org>
2738
2739 * search.c (Fword_search_regexp): New Lisp function created from
2740 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
2741 (Fword_search_backward, Fword_search_forward)
2742 (Fword_search_backward_lax, Fword_search_forward_lax):
2743 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
2744 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
2745
0068070e
SM
27462011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
2747
2748 * fileio.c (Finsert_file_contents): Move after-change-function call
2749 to before the "handled:" label, since all "goto handled" appear in
2750 cases where the *-change-functions have already been properly called
2751 (bug#10117).
2752
3360a3fc
AS
27532011-12-01 Andreas Schwab <schwab@linux-m68k.org>
2754
2755 * keyboard.c (interrupt_signal): Don't call kill-emacs when
2756 waiting for input. (Bug#10169)
2757
73d6c093
EZ
27582011-11-30 Eli Zaretskii <eliz@gnu.org>
2759
2760 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
2761 verifies glyph row's hash code--we have just reallocated the
2762 glyphs, so their contents can be complete garbage. (Bug#10164)
2763
febe6bea
JB
27642011-11-30 Juanma Barranquero <lekktu@gmail.com>
2765
2766 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
2767
801a4313
EZ
27682011-11-30 Eli Zaretskii <eliz@gnu.org>
2769
2770 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
2771 attributes are tested _before_ calling verify_row_hash, to protect
2772 against GCC re-ordering of the tests. (Bug#10164)
2773
2b56b87e
JD
27742011-11-29 Jan Djärv <jan.h.d@swipnet.se>
2775
2776 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
2777
2778 * xterm.c (handle_one_xevent): Only set async_visible and friends
2779 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 2780 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
2781 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
2782
dbf31225
PE
27832011-11-28 Paul Eggert <eggert@cs.ucla.edu>
2784
2785 Remove GCPRO-related macros that exist only to avoid shadowing locals.
2786 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
2787 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
2788 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
2789 All uses changed to use GCPRO1 etc.
2790 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
2791 Revert to old implementation (i.e., before 2011-03-11).
2792
1305621b
YM
27932011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2794
2795 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
2796 of scroll runs so as to avoid assigning disabled bogus rows and
2797 unnecessary graphics copy operations.
2798
8c9afb46
EZ
27992011-11-27 Eli Zaretskii <eliz@gnu.org>
2800
2801 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
2802 (snprintf) [_MSC_VER]: Redirect to _snprintf.
2803 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
2804 (malloc, free, realloc, calloc): Redirect to e_* only when
2805 compiling Emacs.
2806
2807 * lisp.h (GCTYPEBITS): Move before first use.
2808 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
2809 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
2810 this macro definition.
2811
2812 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
2813 _MSC_VER.
2814
54e9e3bf
JD
28152011-11-27 Jan Djärv <jan.h.d@swipnet.se>
2816
6d5eb5b0
SM
2817 * gtkutil.c (xg_create_frame_widgets):
2818 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
2819 present with Gtk+ 2.0.
2820
83aca1cb
PE
28212011-11-26 Paul Eggert <eggert@cs.ucla.edu>
2822
2823 * fileio.c (Finsert_file_contents): Undo previous change; see
2824 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
2825
5b76caa4
PE
28262011-11-26 Paul Eggert <eggert@cs.ucla.edu>
2827
2828 Rename locals to avoid shadowing.
2829 * fileio.c (Finsert_file_contents):
2830 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
2831 * process.c (wait_reading_process_output):
2832 Rename inner 'proc' to 'p' to avoid shadowing.
2833 Indent for consistency with usual Emacs style.
2834
8c535114
EZ
28352011-11-25 Eli Zaretskii <eliz@gnu.org>
2836
2837 * xdisp.c (redisplay_window): If cursor row is not fully visible
2838 after recentering, and scroll-conservatively is set to a large
2839 number, scroll window by a few more lines to make the cursor fully
2840 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
2841 (start_display): Don't move to the next line if the display should
2842 start at a newline that is part of a display vector or an overlay
2843 string. (Bug#10119)
8c535114 2844
fa4fdb5c
JL
28452011-11-24 Juri Linkov <juri@jurta.org>
2846
2847 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
2848 after the `MagickPingImage' call. (Bug#10112)
2849
90ec88df
CY
28502011-11-23 Chong Yidong <cyd@gnu.org>
2851
2852 * window.c (Fcoordinates_in_window_p): Accept only live windows.
2853
56e2e794
MR
28542011-11-23 Martin Rudalics <rudalics@gmx.at>
2855
2856 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
2857 making another buffer current. (Bug#10114)
2858
b6e64c41
GM
28592011-11-23 Glenn Morris <rgm@gnu.org>
2860
2861 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
2862
6b21de18
CY
28632011-11-23 Chong Yidong <cyd@gnu.org>
2864
2865 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
2866 using it (Bug#5984).
2867
b12cd789
EZ
28682011-11-22 Eli Zaretskii <eliz@gnu.org>
2869
2870 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
2871 and header-lines, as they don't have one computed for them.
2872 (Bug#10098)
2873
2874 * .gdbinit (prow): Make displayed values more self-explaining.
2875 Add row's hash code.
2876
261b6fd4
LMI
28772011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
2878
2879 * process.c (wait_reading_process_output): Fix asynchrounous
2880 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 2881 (wait_reading_process_output): Add comment and URL.
261b6fd4 2882
e7cfd277
JD
28832011-11-21 Jan Djärv <jan.h.d@swipnet.se>
2884
2885 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
2886
a9b9b7f5
CY
28872011-11-21 Chong Yidong <cyd@gnu.org>
2888
2889 * window.c (Fnext_window, Fprevious_window): Doc fix.
2890
b0d15b4f
SM
28912011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
2892
2893 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
2894
fe7a3057
JB
28952011-11-20 Juanma Barranquero <lekktu@gmail.com>
2896
2897 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
2898
d2999b1a
MR
28992011-11-20 Martin Rudalics <rudalics@gmx.at>
2900
2901 * window.c (Fset_window_combination_limit): Rename argument
2902 STATUS to LIMIT.
2903 (Vwindow_combination_limit): Remove "status" from doc-string.
2904
d5ff9cd0
AS
29052011-11-20 Andreas Schwab <schwab@linux-m68k.org>
2906
2907 * m/ibms390.h: Remove.
2908 * m/ibms390x.h: Don't include "ibms390.h".
2909
a5bb9bd3
SM
29102011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
2911
2912 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
2913 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
2914
cd1181db
JB
29152011-11-20 Juanma Barranquero <lekktu@gmail.com>
2916
2917 * casetab.c (Fset_case_table):
2918 * charset.c (Fcharset_after): Fix typos.
2919
615a3b8d 29202011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 2921
17e845af
PE
2922 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
2923 Otherwise, valgrind does not work on some platforms.
2924 Problem reported by Andreas Schwab in
6a0bf43d
PE
2925 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
2926 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
2927 is set, removing the need for VIRT_ADDRESS_VARIES.
2928 (PURE_P): Use a more-efficient implementation that needs just one
2929 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
2930 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
2931 to 4 (xorl, subq, cmpq, setbe).
2932 * alloc.c (pure): Always extern now, since that's the
2933 VIRT_ADDR_VARIES behavior.
2934 (PURE_POINTER_P): Use a single comparison, not two, for
2935 consistency with the new puresize.h.
2936 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
2937 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
2938 Remove VIRT_ADDR_VARIES no longer needed.
2939
f8fe6f96
EZ
29402011-11-19 Eli Zaretskii <eliz@gnu.org>
2941
2942 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
2943 (erase_phys_cursor, update_window_cursor, show_mouse_face)
2944 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
2945 behave as if the cursor position were at the window margin.
2946
2947 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
2948 and the cursor position is out of bounds, behave as if the cursor
2949 position were at the window margin. (Bug#10075)
2950
df05a53c
CY
29512011-11-18 Chong Yidong <cyd@gnu.org>
2952
2953 * window.c (Fwindow_combination_limit): Make first argument
2954 non-optional, since it is meaningless for live windows like the
2955 selected window.
61ccba97 2956
2071918e
DA
29572011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
2958
2959 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
2960
b50a28de
SM
29612011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
2962
2963 * intervals.c: Fix grafting over the whole buffer (bug#10071).
2964 (graft_intervals_into_buffer): Simplify.
2965
015137db
EZ
29662011-11-18 Eli Zaretskii <eliz@gnu.org>
2967
2968 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
2969 hash values of the two rows.
2970 (copy_row_except_pointers): Preserve the used[] arrays and the
2971 hash values of the two rows. (Bug#10035)
68c95424 2972 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
2973
2974 * xdisp.c (row_hash): New function, body extracted from
2975 compute_line_metrics.
2976 (compute_line_metrics): Call row_hash, instead of computing the
2977 hash code inline.
2978
2979 * dispnew.c (verify_row_hash): Call row_hash for computing the
2980 hash code of a row, instead of duplicating code from xdisp.c.
2981
2982 * dispextern.h (row_hash): Add prototype.
2983
a2addb04
TH
29842011-11-18 Tassilo Horn <tassilo@member.fsf.org>
2985
2986 * frame.c (delete_frame): Don't delete the terminal when the last
2987 X frame is closed if emacs is built with GTK toolkit.
2988
df85d315
JB
29892011-11-17 Juanma Barranquero <lekktu@gmail.com>
2990
2991 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
2992
a0c2d0ae
MR
29932011-11-17 Martin Rudalics <rudalics@gmx.at>
2994
2995 * window.c (Vwindow_splits): Rename to
2996 Vwindow_combination_resize. Suggested by Juri Linkov.
2997 (Fsplit_window_internal): Use Vwindow_combination_resize instead
2998 of Vwindow_splits.
2999
58179cce
JB
30002011-11-16 Juanma Barranquero <lekktu@gmail.com>
3001
7877f373
JB
3002 * nsfns.m (Fns_font_name):
3003 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 3004
b6f67890
MR
30052011-11-16 Martin Rudalics <rudalics@gmx.at>
3006
3007 * window.h (window): Rename slot "nest" to "combination_limit".
3008 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
3009 (Fset_window_nest): Rename to Fset_window_combination_limit.
3010 (Vwindow_nest): Rename to Vwindow_combination_limit.
3011 (recombine_windows, make_parent_window, make_window)
3012 (Fsplit_window_internal, saved_window)
3013 (Fset_window_configuration, save_window_save): Rename all
3014 occurrences of window_nest to window_combination_limit.
3015
c7015153
JB
30162011-11-15 Juanma Barranquero <lekktu@gmail.com>
3017
3018 * image.c (imagemagick_load_image): Fix typo.
3019
322ad6ec
EZ
30202011-11-14 Eli Zaretskii <eliz@gnu.org>
3021
3022 * xdisp.c (display_line): Move the call to
3023 highlight_trailing_whitespace before the call to
3024 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
3025 faces of all the glyphs to compute ROW's hash value.
3026 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 3027
f067b8ec
JB
30282011-11-14 Juanma Barranquero <lekktu@gmail.com>
3029
3030 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
3031 just return (bug#10044).
3032
1e5b2111
EZ
30332011-11-12 Eli Zaretskii <eliz@gnu.org>
3034
7ef3cbd5
EZ
3035 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
3036 with user-defined heap size. Bump the default size of the temacs
3037 heap to 27MB, to avoid memory warning when running temacs.
3038 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
3039
1e5b2111
EZ
3040 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
3041 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
3042 (verify_row_hash) [XASSERTS]: New function.
3043 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
3044 that the hash value of glyph rows is correct.
1e5b2111 3045
89d61221
MR
30462011-11-12 Martin Rudalics <rudalics@gmx.at>
3047
3048 * window.h (window): Remove splits slot.
3049 * window.c (Fwindow_splits, Fset_window_splits): Remove.
3050 (Fdelete_other_windows_internal, make_parent_window)
3051 (make_window, Fsplit_window_internal, Fdelete_window_internal)
3052 (Fset_window_configuration, save_window_save): Don't deal with
3053 split status of windows.
3054 (saved_window): Remove splits slot.
3055 (Vwindow_splits): Rewrite doc-string.
3056
97f18cc8
JD
30572011-11-11 Jan Djärv <jan.h.d@swipnet.se>
3058
3059 * xfns.c (unwind_create_frame):
3060 * nsfns.m (unwind_create_frame):
3061 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
3062 Vframe_list (Bug#9999).
3063
22a648b4
DA
30642011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
3065
0b381c7e 3066 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 3067
659afede
KH
30682011-11-11 Kenichi Handa <handa@m17n.org>
3069
3070 * callproc.c (Fcall_process): Set the member dst_multibyte of
3071 process_coding.
3072
9ac0394b
KH
30732011-11-11 Johan Bockgård <bojohan@gnu.org>
3074
3075 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
3076 avoid a crash (bug#9496).
3077
2fbdc249
CY
30782011-11-09 Chong Yidong <cyd@gnu.org>
3079
3080 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
3081 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
3082
ac6b1f81
PE
30832011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3084
3085 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
3086
09db192c
PE
30872011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3088
3089 Avoid some portability problems by eschewing 'extern inline' functions.
3090 The trivial performance wins aren't worth the portability hassles; see
3091 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
3092 et seq.
3093 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3094 (window_box_width, window_box_left, window_box_left_offset)
3095 (window_box_right, window_box_right_offset): Undo previous change,
3096 by removing the "extern"s.
3097 * intervals.c (adjust_intervals_for_insertion)
3098 (adjust_intervals_for_deletion): Undo previous change,
3099 making these static again.
3100 (offset_intervals, temp_set_point_both, temp_set_point)
3101 (copy_intervals_to_string): No longer inline.
3102 * xdisp.c (window_text_bottom_y, window_box_width)
3103 (window_box_height, window_box_left_offset)
3104 (window_box_right_offset, window_box_left, window_box_right)
3105 (window_box): No longer inline.
3106
105216ed
CY
31072011-11-08 Chong Yidong <cyd@gnu.org>
3108
3109 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
3110 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
3111 Signal an error if not a live window.
105216ed
CY
3112 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
3113 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
3114
ae9e237f
JB
31152011-11-07 Juanma Barranquero <lekktu@gmail.com>
3116
3117 * lisp.h (syms_of_abbrev): Remove declaration.
3118 Reported by CHENG Gao <chenggao@royau.me>.
3119
c7aa8333
EZ
31202011-11-07 Eli Zaretskii <eliz@gnu.org>
3121
3122 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
3123 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
3124 of temacs in GUI mode.
3125
be7f5545
MR
31262011-11-07 Martin Rudalics <rudalics@gmx.at>
3127
3128 * window.h: Declare delete_all_child_windows instead of
3129 delete_all_subwindows.
3130 * window.c (Fwindow_nest, Fset_window_nest)
3131 (Fset_window_new_total, Fset_window_new_normal)
3132 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
3133 (delete_all_subwindows): Rename to delete_all_child_windows.
3134 (Fdelete_other_windows_internal, Fset_window_configuration):
3135 Call delete_all_child_windows instead of delete_all_subwindows.
3136 * frame.c (delete_frame): Call delete_all_child_windows instead
3137 of delete_all_subwindows.
3138
ca78dc43
PE
31392011-11-07 Paul Eggert <eggert@cs.ucla.edu>
3140
3141 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
3142 This is also needed for porting to any host where GC_MARK_STACK is
3143 not GC_MAKE_GCPROS_NOOPS.
3144 (which_symbols): Use it.
3145
a0241d01
KH
31462011-11-07 Kenichi Handa <handa@m17n.org>
3147
3148 * coding.c (coding_set_destination): Check coding->src_pos only
3149 when coding->src_object is a buffer (bug#9910).
3150
3151 * process.c (send_process): Set the member src_multibyte of coding
3152 to 0 (bug#9911) when sending a unibyte text.
3153
3154 * callproc.c (Fcall_process): Set the member src_multibyte of
3155 process_coding to 0 (bug#9912).
3156
a64bfdfa 31572011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
3158
3159 * xmenu.c (cleanup_widget_value_tree): New function.
3160 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
3161 calling free_menubar_widget_value_tree directly (Bug#9830).
3162
cb41b32a
PE
31632011-11-06 Paul Eggert <eggert@cs.ucla.edu>
3164
3165 Fix some portability problems with 'inline'.
3166 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3167 (window_box_width, window_box_left, window_box_left_offset)
3168 (window_box_right, window_box_right_offset): Declare extern.
3169 Otherwise, these inline functions do not conform to C99 and
3170 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
3171 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
3172 * intervals.c (adjust_intervals_for_insertion)
3173 (adjust_intervals_for_deletion): Now extern, because otherwise the
3174 extern inline functions 'offset_intervals' couldn't refer to it.
3175 (static_offset_intervals): Remove.
3176 (offset_intervals): Rewrite using the old contents of
3177 static_offset_intervals. The old version didn't conform to C99
3178 because an extern inline function contained a reference to an
3179 identifier with static linkage.
3180
b7041366
AS
31812011-11-06 Andreas Schwab <schwab@linux-m68k.org>
3182
3183 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
3184 GC.
3185
88a37c4d
EZ
31862011-11-06 Eli Zaretskii <eliz@gnu.org>
3187
3188 * xdisp.c (init_iterator, reseat_to_string): Don't set the
3189 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
3190 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
3191 return Qleft_to_right.
3192
49745b39
CY
31932011-11-06 Chong Yidong <cyd@gnu.org>
3194
3195 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
3196 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
3197 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
3198 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
3199 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
3200 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
3201 (Fwindow_vscroll): Doc fix.
3202 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
3203 argument, since it makes no sense to pass a live window and for
3204 consistency with window-child.
3205
1f05cd82
CS
32062011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
3207
3208 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
3209 support MSVC.
3210
22610910
JR
32112011-11-05 Jason Rumney <jasonr@gnu.org>
3212
3213 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
3214 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
3215 fonts (Bug#6029).
3216 (add_font_entity_to_list): Fix logic errors in mixed boolean and
3217 bitwise arithmetic preventing use of unicode-sip and non-truetype
3218 opentype fonts.
3219
a06776b2
EZ
32202011-11-05 Eli Zaretskii <eliz@gnu.org>
3221
3ad924ba
EZ
3222 * s/ms-w32.h (fstat, stat, utime): Move redirections to
3223 "emacs"-only part.
3224
a06776b2
EZ
3225 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
3226 initialization code to keep similarity to xfns.c after changes
3227 from 2011-11-05.
3228
c9e7db78
JD
32292011-11-05 Jan Djärv <jan.h.d@swipnet.se>
3230
a97f8f3f
JD
3231 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
3232 (unwind_create_frame): New function (Bug#9943).
3233 (Fx_create_frame): Restructure code to be more similar to the one in
3234 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
3235 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
3236 Move terminal->reference_count++ just before making the frame official
3237 (Bug#9943).
3238
3239 * nsterm.m (x_free_frame_resources): New function.
3240 (x_destroy_window): Move code to x_free_frame_resources.
3241
c9e7db78 3242 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
3243 (Fx_create_frame, x_create_tip_frame):
3244 Move terminal->reference_count++ just before making the frame
75f1671a 3245 official. Move initialization of image_cache_refcount and
c9e7db78
JD
3246 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
3247
a6fc3b5c
EZ
32482011-11-05 Eli Zaretskii <eliz@gnu.org>
3249
3250 Support MSVC build with newer versions of Visual Studio.
3251 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
3252 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
3253 nt/gmake.defs.
3254
3255 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
3256 which are not supported by MSVC.
3257 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
3258 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
3259 bitfields.
3260 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
3261 types in bitfields.
3262 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
3263
3264 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
3265
58179cce 32662011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
3267
3268 Support MSVC build with newer versions of Visual Studio.
3269 * w32.c: Don't include w32api.h for MSVC.
3270 (init_environment) [_MSC_VER]: Call sys_access, not _access.
3271
3272 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
3273 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
3274 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
3275 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
3276 e_* cousins.
3277 (alloca) [_MSC_VER]: Define to _alloca.
3278
3279 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
3280
3281 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
3282
a58c13ed
EZ
32832011-11-04 Eli Zaretskii <eliz@gnu.org>
3284
3285 * xdisp.c (note_mouse_highlight): If either of
3286 previous/next-single-property-change returns nil, treat that as
3287 the beginning or the end of the buffer. (Bug#9955)
3288
fe0b6370
JD
32892011-11-04 Jan Djärv <jan.h.d@swipnet.se>
3290
a58c13ed 3291 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
3292 label is not null (Bug#9951).
3293 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
3294 may be NULL.
3295
89bd5ee1
EZ
32962011-11-04 Eli Zaretskii <eliz@gnu.org>
3297
3298 * window.c (Fwindow_body_size): Mention in the doc string that the
3299 return value is in frame's canonical units. (Bug#9949)
3300
84c3edb9
EZ
33012011-11-03 Eli Zaretskii <eliz@gnu.org>
3302
4e2fb5c7
EZ
3303 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
3304
84c3edb9 3305 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 3306 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 3307 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 3308
bc17a887
EZ
33092011-11-01 Eli Zaretskii <eliz@gnu.org>
3310
3311 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
3312 Don't stop backward scan on the continuation glyph, even though
3313 its CHARPOS is positive.
6d5eb5b0
SM
3314 (mouse_face_from_buffer_pos, note_mouse_highlight):
3315 Rename cover_string to disp_string.
bc17a887 3316
4ee88440
MR
33172011-11-01 Martin Rudalics <rudalics@gmx.at>
3318
3319 * window.c (temp_output_buffer_show): Don't use
3320 Vtemp_buffer_show_specifiers.
3321 (Vtemp_buffer_show_specifiers): Remove unused variable.
3322
c2ff3c02
EZ
33232011-10-30 Eli Zaretskii <eliz@gnu.org>
3324
3325 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
3326 past the beginning of the current glyph matrix.
3327
58179cce 33282011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
3329
3330 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
3331 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
3332 HAVE_GTK3 (Bug#9869).
b77a6a7f 3333
3b574623
JD
3334 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
3335 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
3336
b77a6a7f
JD
3337 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
3338
3339 * xterm.c: Declare x_handle_net_wm_state to return int.
3340 (handle_one_xevent): Check if we are iconified but don't have
3341 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
3342 (get_current_wm_state): Return non-zero if not hidden,
3343 check for _NET_WM_STATE_HIDDEN (Bug#9893).
3344 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
3345 (x_handle_net_wm_state): Return what get_current_wm_state returns.
3346 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
3347
196e41e4
PE
33482011-10-29 Paul Eggert <eggert@cs.ucla.edu>
3349
3350 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
3351 so that this new function doesn't get optimized away by a
3352 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
3353
021f2e1a
AS
33542011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3355
3356 * frame.h (MOUSE_HL_INFO): Remove excess parens.
3357
8b058d44
EZ
33582011-10-29 Eli Zaretskii <eliz@gnu.org>
3359
3360 Fix the `xbytecode' command.
3361 * .gdbinit (xprintbytestr): New command.
b50a28de 3362 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
3363 (xbytecode): Print the byte-code string as well.
3364
4452fb80
EZ
33652011-10-29 Kim Storm <storm@cua.dk>
3366
8b058d44
EZ
3367 * alloc.c (which_symbols): New function.
3368
21b72067
AS
33692011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3370
3371 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
3372 line. (Bug#9903)
3373
83ed7b5c
GM
33742011-10-29 Glenn Morris <rgm@gnu.org>
3375
3376 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
3377 Not clear what it was for, and it causes various bugs. (Bug#9839)
3378
5a7a728b
EZ
33792011-10-28 Eli Zaretskii <eliz@gnu.org>
3380
3381 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
3382 possible random value that matches one of those tested as
3383 condition to clear the mouse face.
3384
d3d0842f
CY
33852011-10-28 Chong Yidong <cyd@gnu.org>
3386
3387 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
3388
31b39d13
DN
33892011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
3390
3391 * window.c (make_window): Initialize phys_cursor_on_p.
3392
9aba6043
SM
33932011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
3394
3395 * lisp.h (struct Lisp_Symbol): Update comments.
3396
c20992f4
JB
33972011-10-28 Juanma Barranquero <lekktu@gmail.com>
3398
3399 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
3400
db4f02f2
EZ
34012011-10-28 Eli Zaretskii <eliz@gnu.org>
3402
3403 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
3404 <oslsachem@gmail.com> for helping to debug this.
3405
3406 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
3407 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
3408 (g_b_init_get_glyph_outline_w): New static variables.
3409 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
3410 (GetGlyphOutlineW_Proc): New typedefs.
3411 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
3412 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
3413 New functions.
3414 (w32font_open_internal, compute_metrics):
3415 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
3416 instead of calling the "wide" APIs directly.
3417
3418 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
3419
3420 * w32.h (syms_of_w32font): Add prototype.
3421
87e68db4
JB
34222011-10-27 Juanma Barranquero <lekktu@gmail.com>
3423
3424 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
3425 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
3426 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
3427 (Fmove_to_window_line): Doc fix.
3428
435c1d67
CY
34292011-10-27 Chong Yidong <cyd@gnu.org>
3430
3431 * process.c (make_process): Set gnutls_state to NULL.
3432
3433 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
3434 non-NULL, regardless of GNUTLS_INITSTAGE.
3435 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
3436 an error. Set process slots as soon as we allocate them.
3437
3438 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
3439
9c6c6f49
CY
34402011-10-27 Chong Yidong <cyd@gnu.org>
3441
9aba6043
SM
3442 * gnutls.c (emacs_gnutls_deinit): New function.
3443 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
3444 (Fgnutls_deinit, Fgnutls_boot): Use it.
3445
3446 * process.c (make_process): Initialize GnuTLS credentials to NULL.
3447 (deactivate_process): Call emacs_gnutls_deinit.
3448
657d08d3
JB
34492011-10-27 Juanma Barranquero <lekktu@gmail.com>
3450
3451 * image.c (x_create_x_image_and_pixmap):
3452 * w32.c (sys_rename, w32_delayed_load):
3453 * w32font.c (fill_in_logfont):
3454 * w32reg.c (x_get_string_resource): Silence compiler warnings.
3455
5430d399
JB
34562011-10-26 Juanma Barranquero <lekktu@gmail.com>
3457
3458 * w32fns.c (w32_default_color_map): New function,
3459 extracted from Fw32_default_color_map.
a7ef684b 3460 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 3461
fe0055fa
PE
34622011-10-25 Paul Eggert <eggert@cs.ucla.edu>
3463
3464 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
3465
e6346438
SM
34662011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
3467
3468 * keyboard.c (test_undefined): New function (bug#9751).
3469 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
3470
e112cc37
ET
34712011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
3472
3473 * sysdep.c (init_sys_modes): Fix the check for the controlling
3474 terminal (Bug#6649).
3475
7b5d6677
EZ
34762011-10-20 Eli Zaretskii <eliz@gnu.org>
3477
3478 * dispextern.h (struct bidi_it): New member next_en_type.
3479
3480 * bidi.c (bidi_line_init): Initialize the next_en_type member.
3481 (bidi_resolve_explicit_1): When next_en_pos is valid for the
3482 current character, check also for next_en_type being WEAK_EN.
3483 (bidi_resolve_weak): Don't enter the expensive loop if the current
3484 position is before next_en_pos. Record the bidi type of the first
3485 non-ET, non-BN character we find, in addition to its position.
3486 (bidi_level_of_next_char): Invalidate next_en_type when
3487 next_en_pos is over-stepped.
3488
7da0b018
PE
34892011-10-20 Paul Eggert <eggert@cs.ucla.edu>
3490
3491 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
3492 * editfns.c: Rewrite current-time-zone so that it invokes
3493 the equivalent of (format-time-string "%Z") to get the time zone name.
3494 This fixes a bug when the time zone name contains characters that
3495 need converting from the system time locale to Emacs internal format.
3496 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
3497 that patch fixed format-time-string to do the conversion, but
3498 I forgot to fix current-time-zone.
3499 (format_time_string): New function, containing most of
3500 what Fformat_time_string used to contain.
3501 (Fformat_time_string): Rewrite in terms of format_time_string.
3502 This doesn't change this function's behavior.
3503 (current-time-zone): Rewrite to use format_time_string.
3504 This fixes the bug reported by Michael Schierl in
3505 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
3506 Jason Rumney's 2007-06-07 change worked around this bug, but
3507 didn't fix it.
3508 * systime.h (tzname, timezone): Remove no-longer-used declarations.
3509
8547b010
EZ
35102011-10-19 Eli Zaretskii <eliz@gnu.org>
3511
3512 * xdisp.c (start_display): If the character at POS is displayed
3513 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
3514 (try_window_reusing_current_matrix): If a line ends in a display
3515 vector or the next line starts in a display vector, continue
3516 redrawing the window even though the character position of
3517 start_row was reached.
8547b010
EZ
3518 (Bug#9771, part 2)
3519
4e948d15
CY
35202011-10-18 Chong Yidong <cyd@gnu.org>
3521
3522 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
3523 with nobreak-char-display too.
3524
4787455f
EZ
35252011-10-18 Eli Zaretskii <eliz@gnu.org>
3526
3527 Fix part 3 of bug#9771.
3528 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
3529 (bidi_resolve_neutral): Don't enter the expensive loop looking for
3530 non-neutral characters if the current character is a paragraph
3531 separator (a.k.a. Newline). This avoids running the same
3532 expensive loop twice, once when we consume the preceding newline
3533 and the other time when the line actually needs to be displayed.
3534 Avoid the loop when we see neutrals on the base embedding level
3535 following a character whose directionality is the same as the
3536 paragraph's. This avoids running the expensive loop when a line
3537 ends in a long sequence of neutrals, like control characters.
3538 Add assertion against STRONG_AL type. Slightly rearrange code
3539 that determines the type of a neutral given the first non-neutral
3540 that follows it.
3541 (bidi_level_of_next_char): Set next_en_pos to zero when
3542 invalidating its info.
3543
2c91f553
EZ
35442011-10-17 Eli Zaretskii <eliz@gnu.org>
3545
3546 * xdisp.c (push_display_prop): Determine whether to record string
3547 or buffer position by IT->string, not by IT->method. Allow
3548 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
3549 (move_it_vertically_backward): Don't look for character position
3550 immediately after the newline when in a continuation line.
3551 (Bug#9771, part 1)
2c91f553 3552
c7b08b0d
MR
35532011-10-15 Martin Rudalics <rudalics@gmx.at>
3554
3555 * window.c (coordinates_in_window): Rewrite and delabelize
3556 vertical border check. (Bug#5357) (Bug#9618)
3557
6b02f655
SM
35582011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
3559
3560 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
3561 errors in XSetWindowBorder (bug#9310).
3562
81d40c92
DA
35632011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
3564
3565 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
3566 avoid crash when xmalloc overrun checking is enabled.
3567
d4172c3b
EZ
35682011-10-13 Eli Zaretskii <eliz@gnu.org>
3569
3570 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
3571 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
3572 cursor motion with <left> and <right> arrow keys.
3573
3574 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
3575 some callers set that themselves.
3576
b00eea75
EZ
35772011-10-12 Eli Zaretskii <eliz@gnu.org>
3578
3579 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
3580 display string and the previous row comes from the same string and
3581 is empty. (Bug#9739) (Bug#9738)
3582
8fe012c4
SM
35832011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
3584
3585 * doc.c (get_doc_string): Encode file name (bug#9735).
3586
0074aef2
EZ
35872011-10-12 Eli Zaretskii <eliz@gnu.org>
3588
79beb178
EZ
3589 * bidi.c (bidi_level_of_next_char):
3590 * xdisp.c (get_visually_first_element): Remove old incorrect
3591 comments regarding the Unicode Line Separator character.
3592
0074aef2
EZ
3593 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
3594
6e4b3fbe
DA
35952011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
3596
3597 * alloc.c (Fgc_status): Do not access beyond zombies array
3598 boundary if nzombies > MAX_ZOMBIES.
3599 * alloc.c (dump_zombies): Add missing format specifier.
3600
0324f3af
PE
36012011-10-12 Paul Eggert <eggert@cs.ucla.edu>
3602
b5525cac
PE
3603 * xdisp.c (set_cursor_from_row): Simplify conditionals,
3604 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
3605
0324f3af
PE
3606 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
3607 Some packages use them to denote characters with modifiers.
3608
e9b5f888
AS
36092011-10-11 Andreas Schwab <schwab@linux-m68k.org>
3610
3611 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
3612 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
3613 matching a pp-number. Rename parameter var to var1.
3614
127827c0
SM
36152011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
3616
3617 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
3618
c8fd3bd0
GM
36192011-10-08 Glenn Morris <rgm@gnu.org>
3620
3621 * callint.c (Fcall_interactively): Give a more explicit error for the
3622 'c' case with a non-character input. (Bug#8479)
3623
352ec8ff
EZ
36242011-10-08 Eli Zaretskii <eliz@gnu.org>
3625
03669ccb
EZ
3626 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
3627 lines.
7061c986
EZ
3628 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
3629 lines that are hscrolled on the left.
03669ccb 3630
352ec8ff
EZ
3631 * dispnew.c (buffer_posn_from_coords): Account for a possible
3632 presence of header-line. (Bug#4426)
3633
a66cfb1c
SM
36342011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
3635
6b02f655
SM
3636 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
3637 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 3638
7c5ee88e
PE
36392011-10-07 Paul Eggert <eggert@cs.ucla.edu>
3640
3641 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
3642 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
3643 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
3644 this makes Emacs dump core during garbage collection on rare
3645 occasions. sizeof is obviously inferior to offsetof here, so
3646 stick with offsetof.
3647 (GC_POINTER_ALIGNMENT): New macro.
3648 (mark_memory): Omit 3rd (offset) arg; caller changed.
3649 Don't assume EMACS_INT alignment is the same as pointer alignment.
3650
df1bbe5b
SM
36512011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
3652
3653 * keyboard.c (read_key_sequence_remapped): New var.
3654 (read_key_sequence): Compute remapping in the right buffer.
3655 (command_loop_1): Use read_key_sequence's remapping directly.
3656
51553db6
SM
36572011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
3658
32c1fffd
SM
3659 * dired.c (file_name_completion): Don't expand file name.
3660 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
3661 before checking file name handler.
3662
51553db6
SM
3663 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
3664 they've been requested explicitly (bug#9591).
3665
b6bd1599 36662011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
3667
3668 * keymap.c (Fsingle_key_description): Use make_specified_string
3669 instead of build_string to build string from push_key_description.
3670 (Bug#5193)
3671
f701dc2a
PE
36722011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3673
4222c55d
PE
3674 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
3675 This fixes a Y2038 bug on 64-bit hosts.
3676 * buffer.c (reset_buffer):
3677 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
3678 (Fclear_buffer_auto_save_failure):
3679 Use 0, not -1, to represent an unset failure time, since time_t
3680 might not be signed.
3681
f701dc2a
PE
3682 Remove dependency on glibc malloc internals.
3683 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3684 Move back here from lisp.h, but with their new implementations.
3685 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3686 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
3687 * charset.c (charset_table_init): New static var.
3688 (syms_of_charset): Use it instead of xmalloc. This removes a
3689 dependency on glibc malloc internals. See Eli Zaretskii's comment in
3690 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
3691 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3692 Move back to alloc.c.
3693 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3694 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
3695
9ceebf39
JD
36962011-09-30 Jan Djärv <jan.h.d@swipnet.se>
3697
3698 * nsterm.m (windowDidResize): Call x_set_window_size only when
3699 ns_in_resize is true. Otherwise set pixelwidth/height and
3700 call change_frame_size (Bug#9628).
3701
cb993c58
PE
37022011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3703
3930c88b
PE
3704 Port --enable-checking=all to Fedora 14 x86-64.
3705 * charset.c (syms_of_charset): Also account for glibc malloc's
3706 internal overhead when calculating the initial malloc maximum.
3707
cb993c58
PE
3708 Port --enable-checking=all to Fedora 14 x86.
3709 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3710 Move to lisp.h.
3711 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
3712 (overrun_check_realloc, overrun_check_free):
3713 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
3714 That way, xmalloc returns a properly-aligned pointer even if
3715 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
3716 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
3717 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
3718 into account when calculating the initial malloc maximum.
3719 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3720 Move here from alloc.c, so that charset.c can use it too.
3721 Properly align; the old code wasn't right for common 32-bit hosts
3722 when configured with --enable-checking=all.
3723 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3724 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
3725
31bed486
EZ
37262011-09-29 Eli Zaretskii <eliz@gnu.org>
3727
04c70788 3728 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
3729 use EDOM.
3730
fbcaa2f3
EZ
37312011-09-28 Eli Zaretskii <eliz@gnu.org>
3732
3733 * xdisp.c (compute_display_string_end): If there's no display
3734 string at CHARPOS, return -1.
3735
3736 * bidi.c (bidi_fetch_char): When compute_display_string_end
3737 returns a negative value, treat the character as a normal
3738 character not covered by a display string. (Bug#9624)
3739
a239d4e9
JB
37402011-09-28 Juanma Barranquero <lekktu@gmail.com>
3741
3742 * lread.c (Fread_from_string): Fix typo in docstring.
3743
88652fd5
EZ
37442011-09-27 Eli Zaretskii <eliz@gnu.org>
3745
3746 * xdisp.c (handle_invisible_prop): If invisible text ends on a
3747 newline, reseat the iterator instead of bidi-iterating there one
3748 character at a time. (Bug#9610)
32c1fffd
SM
3749 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
3750 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 3751
ed497dd4
AS
37522011-09-27 Andreas Schwab <schwab@linux-m68k.org>
3753
3754 * lread.c (readevalloop): Use correct code for NBSP.
3755 (read1): Likewise. (Bug#9608)
3756
b2bf61aa
MA
37572011-09-25 Michael Albinus <michael.albinus@gmx.de>
3758
3759 * dbusbind.c (Fdbus_register_signal): When service is not
3760 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
3761
32bbb17c
GM
37622011-09-25 Glenn Morris <rgm@gnu.org>
3763
3764 * buffer.c (truncate-lines): Doc fix.
3765
94e0933e
CY
37662011-09-24 Chong Yidong <cyd@stupidchicken.com>
3767
3768 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
3769 (Fset_window_next_buffers): Doc fix.
3770
cddde921
GM
37712011-09-24 Glenn Morris <rgm@gnu.org>
3772
3773 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
3774
1260aef1
PE
37752011-09-24 Paul Eggert <eggert@cs.ucla.edu>
3776
25b4bfa0
PE
3777 Fix minor problems found by static checking.
3778 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
3779 * indent.c (Fvertical_motion): Fix == vs = typo.
3780
e3cbd34b
EZ
37812011-09-24 Eli Zaretskii <eliz@gnu.org>
3782
a66cfb1c
SM
3783 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
3784 Default value is now t. Doc fix.
6bf7006f 3785
e3cbd34b 3786 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 3787 logic when moving up, not only when moving down. Fix the
e3cbd34b 3788 confusing name and values of the it_overshoot_expected variable;
32c1fffd 3789 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
3790
3791 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
3792 CHARPOS is covered by a display string which includes newlines.
3793 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
3794 is covered by a display string with embedded newlines.
3795
a3de0cbd
MA
37962011-09-24 Michael Albinus <michael.albinus@gmx.de>
3797
3798 * dbusbind.c (Fdbus_register_signal): Add match rule to
3799 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
3800 (Fdbus_register_method, Vdbus_registered_objects_table):
3801 Fix docstring.
a3de0cbd 3802
b260039d
JM
38032011-09-24 Jim Meyering <meyering@redhat.com>
3804
32c1fffd 3805 do not ignore write error for any output size
b260039d
JM
3806 The previous change was incomplete.
3807 While it makes emacs --batch detect the vast majority of stdout
3808 write failures, errors were still ignored whenever the output size is
3809 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
3810 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
3811 && echo FAIL: ignored write error
3812 FAIL: ignored write error
3813 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
3814 && echo FAIL: ignored write error
3815 FAIL: ignored write error
3816 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
3817
8eca8a7c
AS
38182011-09-23 Andreas Schwab <schwab@linux-m68k.org>
3819
3820 * emacs.c (Fkill_emacs): In noninteractive mode exit
3821 non-successfully if a write error occurred on stdout. (Bug#9574)
3822
3341db62
EZ
38232011-09-21 Eli Zaretskii <eliz@gnu.org>
3824
3825 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
3826 the xassert test.
3827
3828 * dispextern.h (struct it): Update the comment documenting what
3829 can it->OBJECT be.
3830
8c203dbf
EZ
38312011-09-20 Eli Zaretskii <eliz@gnu.org>
3832
3833 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
3834 a display string, extend search for cursor position to end of row.
3835 (find_row_edges): If the row ends in a newline from a display
3836 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
3837 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
3838 (Fcurrent_bidi_paragraph_direction): Fix search for previous
3839 non-empty line. Fixes confusing cursor motion with arrow keys at
3840 the beginning of a line that starts with whitespace.
8c203dbf 3841
a4824228
LMI
38422011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3843
3844 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
3845 (bug#9493).
3846
33ed493b
CY
38472011-09-18 Chong Yidong <cyd@stupidchicken.com>
3848
3849 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
3850 boolean (Bug#9154).
3851
56cd55c8
EZ
38522011-09-18 Eli Zaretskii <eliz@gnu.org>
3853
3854 * xdisp.c (display_line): Record maximum and minimum buffer
3855 positions even if no glyphs were produced (e.g., by a zero-width
3856 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
3857 buffer positions that will be removed from the glyph row because
3858 they don't fit.
c02dcedf
EZ
3859 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
3860 column is beyond frame width: don't subtract 1 "pixel" when
3861 computing width of the stretch.
3e62b7e0
EZ
3862 (reseat_at_next_visible_line_start): Undo the change made on
3863 2011-09-17 that saved paragraph information and restored it after
3864 the call to `reseat'. (Bug#9545)
56cd55c8 3865
5ed99d36 38662011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
3867
3868 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
3869 and turn window cursor on if cleared (Bug#9415).
3870
5ed99d36 38712011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
3872
3873 * search.c (boyer_moore): Take unibyte characters from pattern
3874 literally. (Bug#9458)
3875
9bade7b2
EZ
38762011-09-18 Eli Zaretskii <eliz@gnu.org>
3877
3878 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
3879
e5e9d610
PE
38802011-09-18 Paul Eggert <eggert@cs.ucla.edu>
3881
87e4427a
PE
3882 Fix minor problem found by static checking.
3883 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
3884 initialized, to pacify gcc -Wuninitialized.
3885
e5e9d610
PE
3886 * fileio.c: Report proper errno when syscall falls.
3887 (Finsert_file_contents): Save and restore errno,
3888 so that report_file_error outputs the correct diagnostic.
3889 (Fwrite_region) [CLASH_DETECTION]: Likewise.
3890
a1674f0b
EZ
38912011-09-18 Eli Zaretskii <eliz@gnu.org>
3892
3893 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
3894
fbfb6dd4
EZ
38952011-09-17 Eli Zaretskii <eliz@gnu.org>
3896
3897 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
3898 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
3899
bb187662
EZ
39002011-09-17 Eli Zaretskii <eliz@gnu.org>
3901
1137e8b8 3902 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 3903 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
3904
3905 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
3906 (bidi_find_paragraph_start): Search back for paragraph beginning
3907 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
3908 (bidi_move_to_visually_next): Only trigger paragraph-related
3909 computations when the last character is a newline or at EOB, not
3910 just any NEUTRAL_B. (Bug#9470)
3911
bb187662
EZ
3912 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
3913 truncated lines if point is covered by a display string. (Bug#9524)
3914
2e621251
PE
39152011-09-16 Paul Eggert <eggert@cs.ucla.edu>
3916
3917 * xselect.c: Relax test for outgoing X longs (Bug#9498).
3918 (cons_to_x_long): New function.
3919 (lisp_data_to_selection_data): Use it. Correct the test for
3920 short-versus-long data; it was negated. Break out of vector
3921 loop, for efficiency, when a long datum is discovered.
3922
91a15bc6
SM
39232011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
3924
3925 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
3926
b41c3a35
EZ
39272011-09-16 Eli Zaretskii <eliz@gnu.org>
3928
3929 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
3930 GCC PR/17406) by declaring this function with external scope.
3931
7812ba2d
PE
39322011-09-15 Paul Eggert <eggert@cs.ucla.edu>
3933
3934 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
3935 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
3936
cf7edc2a
AS
39372011-09-15 Andreas Schwab <schwab@linux-m68k.org>
3938
3939 * editfns.c (Fformat): Correctly handle text properties on "%%".
3940
bd01620e
EZ
39412011-09-15 Eli Zaretskii <eliz@gnu.org>
3942
3943 * xterm.c (x_draw_composite_glyph_string_foreground):
3944 * w32term.c (x_draw_composite_glyph_string_foreground):
3945 * term.c (encode_terminal_code):
3946 * composite.c (composition_update_it, get_composition_id):
3947 * xdisp.c (get_next_display_element)
3948 (fill_composite_glyph_string): Add comments about special meaning
3949 of TAB characters in a composition.
3950
a02719a3
PE
39512011-09-15 Paul Eggert <eggert@cs.ucla.edu>
3952
3953 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
3954 This occurs when processing a multibyte format.
3955 Problem reported by Wolfgang Jenker.
a02719a3 3956
72589a3c
JB
39572011-09-15 Johan Bockgård <bojohan@gnu.org>
3958
3959 * xdisp.c (try_cursor_movement): Only check for exact match if
3960 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
3961
1c14176c
PE
39622011-09-14 Paul Eggert <eggert@cs.ucla.edu>
3963
3964 Remove unused external symbols.
3965 * dispextern.h (calc_pixel_width_or_height): Remove decl.
3966 * xdisp.c (calc_pixel_width_or_height): Now static.
3967 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
3968 * indent.c (check_display_width):
3969 * w32term.c: Fix comment to match code.
3970 * xterm.c, xterm.h (x_catching_errors): Remove.
3971
d2eea5b5
PE
39722011-09-14 Paul Eggert <eggert@cs.ucla.edu>
3973
3974 * xselect.c: Use signed conversions more consistently (Bug#9498).
3975 (selection_data_to_lisp_data): Assume incoming selection data are
3976 signed integers, not unsigned. This is to be consistent with
3977 outgoing selection data, which was modified to use signed integers
3978 in as part of the fix to Bug#9196 in response to Jan D.'s comment
3979 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
3980 expects long, not unsigned long.
3981
46888499
EZ
39822011-09-14 Eli Zaretskii <eliz@gnu.org>
3983
3984 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
3985 computation of loop end. Reported by Johan Bockgård
3986 <bojohan@gnu.org>.
3987
ef8ef9fb
CY
39882011-09-13 Chong Yidong <cyd@stupidchicken.com>
3989
3990 * frame.c (Fother_visible_frames_p): Function deleted.
3991
fa819fed
EZ
39922011-09-12 Eli Zaretskii <eliz@gnu.org>
3993
3994 * indent.c (compute_motion): Process display vector front to back
3995 rather than the other way around. (Bug#2496)
3996
2ba8e008
SM
39972011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
3998
3999 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
4000
20f53c69
CY
40012011-09-11 Chong Yidong <cyd@stupidchicken.com>
4002
4003 * minibuf.c (Fread_from_minibuffer): Doc fix.
4004
d562d7a4
EZ
40052011-09-11 Eli Zaretskii <eliz@gnu.org>
4006
4007 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
4008 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
4009
1c4d7f3d
LMI
40102011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4011
4012 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
4013 value for non-existent files.
4014
b885bf36
EZ
40152011-09-11 Eli Zaretskii <eliz@gnu.org>
4016
4017 * fileio.c (Finsert_file_contents): If the file cannot be opened,
4018 set its "size" to -1. This will set the modtime_size field of
4019 the corresponding buffer to -1, which is what
4020 verify-visited-file-modtime expects for files that do not exist.
4021 (Bug#9139)
4022
6612f0bf
PE
40232011-09-11 Paul Eggert <eggert@cs.ucla.edu>
4024
4025 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
4026 here ...
4027 * lisp.h: ... from here. push_key_description is no longer
4028 defined in keyboard.c, so its declaration should not be in
4029 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
4030 logically belongs with push_key_description.
4031
dfb3f755
PE
40322011-09-10 Paul Eggert <eggert@cs.ucla.edu>
4033
4034 * buffer.h: Include <sys/types.h> instead of <time.h>.
4035 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
4036 Problem reported by Herbert J. Skuhra.
4037
3134906c
LMI
40382011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
4039
4040 * xml.c (parse_region): Make the parsing work for
4041 non-comment-starting XML files again (bug#9144).
4042
8d903f4e
AS
40432011-09-10 Andreas Schwab <schwab@linux-m68k.org>
4044
4045 * image.c (gif_load): Fix calculation of bottom and right corner.
4046 (Bug#9468)
4047
80ad64f4
EZ
40482011-09-10 Eli Zaretskii <eliz@gnu.org>
4049
4050 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
4051 redisplay in small windows.
4052
208a048d
EZ
40532011-09-09 Eli Zaretskii <eliz@gnu.org>
4054
4055 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
4056
9b1c252e
MR
40572011-09-08 Martin Rudalics <rudalics@gmx.at>
4058
4059 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
4060 Operate on live windows only.
4061
2949f33b
JB
40622011-09-08 Juanma Barranquero <lekktu@gmail.com>
4063
4064 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
4065
e08dcafd
EZ
40662011-09-07 Eli Zaretskii <eliz@gnu.org>
4067
4068 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
4069 only under bidi iteration.
4070
115b96bd
JD
40712011-09-07 Jan Djärv <jan.h.d@swipnet.se>
4072
4073 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
4074
c8199d0f
PE
40752011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4076
4077 isnan: Fix porting problem to Solaris 10 with bundled gcc.
4078 Without this fix, the command to link temacs failed due to an
4079 undefined symbol __builtin_isnan. This is because
4080 /usr/include/iso/math_c99.h #defines isnan(x) to
4081 __builtin_isnan(x), but the bundled gcc, which identifies itself
4082 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
4083 a __builtin_isnan.
4084 * floatfns.c (isnan): #undef, and then #define to a clone of
4085 what's in data.c.
4086 (Fisnan): Always define, since it's always available now.
4087 (syms_of_floatfns): Always define isnan at the Lisp level.
4088
e39b275c 40892011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
4090
4091 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
4092
b2db44d9 40932011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 4094
f4af5137 4095 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
4096 The previous code assumed that file offsets (off_t values) fit in
4097 EMACS_INT variables, which is not true on typical 32-bit hosts.
4098 The code messed up by falsely reporting buffer overflow in cases
4099 such as (insert-file-contents "big" nil 1 2) into an empty buffer
4100 when "big" contains more than 2**29 bytes, even though this
4101 inserts just one byte and does not overflow the buffer.
4102 (Finsert_file_contents): Store file offsets as off_t
4103 values, not as EMACS_INT values. Check for overflow when
4104 converting between EMACS_INT and off_t. When checking for
4105 buffer overflow or for overlap, take the offsets into account.
4106 Don't use EMACS_INT for small values where int suffices.
4107 When checking for overlap, fix a typo: ZV was used where
4108 ZV_BYTE was intended.
4109 (Fwrite_region): Don't assume off_t fits into 'long'.
4110 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
4111
ecfc0a49
MA
41122011-09-05 Michael Albinus <michael.albinus@gmx.de>
4113
4114 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
4115
6511acf2 41162011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 4117
0999621a 4118 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
4119
4120 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 4121 (esprintf, exprintf, evxprintf): New functions.
62f19c19 4122 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 4123 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
4124 (modify_event_symbol): Do not assume that the length of
4125 name_alist_or_stem is safe to alloca and fits in int.
4126 (Fexecute_extended_command): Likewise for function name and binding.
4127 (Frecursion_depth): Wrap around reliably on integer overflow.
4128 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
4129 since some callers pass EMACS_INT values.
4130 (Fsingle_key_description): Don't crash if symbol name contains more
4131 than MAX_ALLOCA bytes.
4132 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
4133 (get_minibuffer): Arg is now EMACS_INT, not int.
4134 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 4135 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
4136 * window.h (command_loop_level, minibuf_level): Reflect API changes.
4137
2be7d702
PE
4138 * dbusbind.c (signature_cat): New function.
4139 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
4140 Do not overrun buffer; instead, report string overflow.
4141
9d1df220
PE
4142 * dispnew.c (add_window_display_history): Don't overrun buffer.
4143 Truncate instead; this is OK since it's just a log.
4144
33ef5c64
PE
4145 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
4146 even if the time zone offset is outlandishly large.
4147 Don't mishandle offset == INT_MIN.
4148
66c6fdd5
PE
4149 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
4150 when creating daemon; the previous buffer-overflow check was incorrect.
4151
d749b01b
PE
4152 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
4153 which has the guts of the old verror function.
4154
b5cd1905
PE
4155 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
4156 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
4157
6e1a67fb
PE
4158 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
4159 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 4160 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 4161 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
4162 length of string rather than counting it via multiple sprintfs;
4163 that's simpler and more reliable.
c21721cc
PE
4164 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
4165 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
4166 sprintf, in case result does not fit in int.
4167
c57b67fc
PE
4168 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
4169 (fontset_from_font): Print it.
4170
8a401434
PE
4171 * frame.c (tty_frame_count): Now printmax_t, not int.
4172 (make_terminal_frame, set_term_frame_name): Print it.
4173 (x_report_frame_params): In X, window IDs are unsigned long,
4174 not signed long, so print them as unsigned.
4175 (validate_x_resource_name): Check for implausibly long names,
4176 and don't assume name length fits in 'int'.
4177 (x_get_resource_string): Don't blindly alloca invocation name;
4178 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
4179 not fit in int.
4180
6e1a67fb
PE
4181 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
4182 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
4183 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
4184
0df02bf3
PE
4185 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
4186 Use esprintf, not sprintf, in case result does not fit in int.
4187
48e30793
PE
4188 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4189 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
4190 it as a large positive number.
4191 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
4192 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4193
a66ff6d8
PE
4194 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
4195 in case result does not fit in int.
4196
aca216ff
PE
4197 * print.c (float_to_string): Detect width overflow more reliably.
4198 (print_object): Make sprintf buffer a bit bigger, to avoid potential
4199 buffer overrun. Don't assume list length fits in 'int'. Treat
4200 print length of 0 as 0, not as infinity; to be consistent with other
4201 uses of print length in this function. Don't overflow print length
4202 index. Don't assume hash table size fits in 'long', or that
4203 vectorlike size fits in 'unsigned long'.
4204
31c286f7
PE
4205 * process.c (make_process): Use printmax_t, not int, to format
4206 process-name gensyms.
4207
55e5faa1
PE
4208 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
4209
80f2e268
PE
4210 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
4211 to avoid potential buffer overrun.
4212
670741ab
PE
4213 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
4214 if X resource line is longer than 512 bytes.
4215
b7163a50
PE
4216 * xfns.c (x_window): Make sprintf buffer a bit bigger
4217 to avoid potential buffer overrun.
4218
ae58ff1f
PE
4219 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
4220
c43c8a6a
PE
4221 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
4222
3f8236f4
PE
42232011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4224
53e9fe90 4225 Integer overflow fixes for scrolling, etc.
6511acf2
PE
4226 Without these, Emacs silently mishandles large integers sometimes.
4227 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
4228 it were "C-u 1 M-x recenter" on a typical 64-bit host.
4229
6511acf2
PE
4230 * xdisp.c (try_window_id): Check Emacs fixnum range before
4231 converting to 'int'.
806add1d 4232
6511acf2 4233 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
4234 Check that an Emacs fixnum is in range before assigning it to 'int'.
4235 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
4236 values converted from Emacs fixnums.
4237 (Frecenter): Don't wrap around a line count if it is out of 'int'
4238 range; instead, treat it as an extreme value.
4239 (Fset_window_configuration, compare_window_configurations):
4240 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
4241
6511acf2
PE
4242 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
4243 that can exceed INT_MAX. Check that EMACS_INT value is in range
4244 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
4245 (match_limit): Don't assume that a fixnum can fit in 'int'.
4246
6511acf2 4247 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
4248 exceed INT_MAX.
4249
6511acf2 4250 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
4251 (Fvertical_motion): Don't wrap around LINES values that don't fit
4252 in 'int'. Instead, treat them as extreme values. This is good
4253 enough for windows, which can't have more than INT_MAX lines anyway.
4254
fcb901a7
LMI
42552011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4256
0f2f6b6d
LMI
4257 * Require libxml/parser.h to avoid compilation warning.
4258
fcb901a7
LMI
4259 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
4260
4261 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
4262 since this reportedly can destroy thread storage.
4263
6e20a0d4
CY
42642011-08-30 Chong Yidong <cyd@stupidchicken.com>
4265
4266 * syntax.c (find_defun_start): Update all cache variables if
4267 exiting early (Bug#9401).
4268
148ae00e
EZ
42692011-08-30 Eli Zaretskii <eliz@gnu.org>
4270
f6cfbd8f
EZ
4271 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
4272
148ae00e
EZ
4273 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
4274 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
4275 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
4276
4277 * term.c (tty_append_glyph): New function.
4278 (produce_stretch_glyph): Static function and its prototype deleted.
4279
a66cfb1c
SM
4280 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
4281 Add prototypes.
148ae00e 4282
c4a07a4c
PE
42832011-08-29 Paul Eggert <eggert@cs.ucla.edu>
4284
4285 * image.c (parse_image_spec): Check for nonnegative, not for positive,
4286 when checking :margin (Bug#9390).
4287 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 4288 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
4289 so that the name doesn't mislead. All uses changed.
4290
6bc8cd65
JB
42912011-08-28 Johan Bockgård <bojohan@gnu.org>
4292
4293 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
4294 set_tty_hooks.
4295
dca4927e
EZ
42962011-08-27 Eli Zaretskii <eliz@gnu.org>
4297
4298 * xdisp.c (move_it_to): Don't bail out early when reaching
4299 position beyond to_charpos, if we are scanning backwards.
4300 (move_it_vertically_backward): When DY == 0, make sure we get to
4301 the first character in the line after the newline.
4302
f2cad773
PE
43032011-08-27 Paul Eggert <eggert@cs.ucla.edu>
4304
4305 * ccl.c: Improve and simplify overflow checking (Bug#9196).
4306 (ccl_driver): Do not generate an out-of-range pointer.
4307 (Fccl_execute_on_string): Remove unnecessary check for
4308 integer overflow, noted by Stefan Monnier in
4309 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
4310 Remove a FIXME that didn't need fixing.
4311 Simplify the newly-introduced buffer reallocation code.
4312
0cae2cdb
JB
43132011-08-27 Juanma Barranquero <lekktu@gmail.com>
4314
4315 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
4316
5fc295a4 43172011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 4318
70c60eb2 4319 Integer and memory overflow issues (Bug#9196).
726e0ab1 4320
d31850da
PE
4321 * doc.c (get_doc_string): Rework so that
4322 get_doc_string_buffer_size is the actual buffer size, rather than
4323 being 1 less than the actual buffer size; this makes xpalloc more
4324 convenient.
4325
a69fbedb
PE
4326 * image.c (x_allocate_bitmap_record, cache_image):
4327 * xselect.c (Fx_register_dnd_atom):
4328 Simplify previous changes by using xpalloc.
4329
fe5c5d37
PE
4330 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
4331 since either will do and ptrdiff_t is convenient with xpalloc.
4332
0065d054
PE
4333 * charset.c (charset_table_size)
4334 (struct charset_sort_data.priority): Now ptrdiff_t.
4335 (charset_compare): Don't overflow if priorities differ greatly.
4336 (Fsort_charsets): Don't assume list length fits in int.
4337 Check for size-calculation overflow when allocating sort data.
4338 (syms_of_charset): Allocate an initial charset table that is
4339 just under 64 KiB, to avoid problems with glibc malloc and mmap.
4340
4341 * cmds.c (internal_self_insert): Check for size-calculation overflow.
4342
4343 * composite.h (struct composition.glyph_len): Now int, not unsigned.
4344 The actual value is always <= INT_MAX, and leaving it unsigned made
4345 overflow checking harder.
4346
4347 * dispextern.h (struct glyph_matrix.rows_allocated)
4348 (struct face_cache.size): Now ptrdiff_t, for convenience in use
4349 with xpalloc. The values are still always <= INT_MAX.
4350
4351 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
4352
4353 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
4354 (SAFE_NALLOCA): New macro.
4355
4356 * region-cache.c (struct boundary.pos, find_cache_boundary)
4357 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
4358 (set_cache_region, invalidate_region_cache)
4359 (revalidate_region_cache, know_region_cache, region_cache_forward)
4360 (region_cache_backward, pp_cache):
4361 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
4362 so that ptrdiff_t * can be passed to xpalloc.
4363 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
4364 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
4365 (pp_cache): Don't assume cache_len fits in int.
4366 * region-cache.h: Adjust extern decls to match.
4367
4368 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
4369 EMACS_INT, since either will do, for xpalloc.
4370
4371 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
4372 (xnmalloc, xnrealloc, xpalloc): New functions.
4373
726e0ab1
PE
4374 * bidi.c (bidi_shelve_header_size): New constant.
4375 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
4376 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
4377
51f30bc5 4378 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
4379 * buffer.c (overlays_at, overlays_in, record_overlay_string)
4380 (overlay_strings):
4381 Don't update size of array until after memory allocation succeeds,
4382 because xmalloc/xrealloc may not return.
0065d054
PE
4383 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
4384 now that we have proper integer overflow checking.
4385 (record_overlay_string, overlay_strings): Catch overflows when
4386 calculating size of overlay_str_buf.
726e0ab1 4387
0065d054
PE
4388 * callproc.c (Fcall_process): Check for size overflow when
4389 calculating size of args2.
4390 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
4391 Normally we prefer signed values, but sticking with ptrdiff_t would
4392 require adding more-complicated checks.
726e0ab1
PE
4393
4394 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
4395 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
4396 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 4397 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
4398
4399 * character.c (Fstring): Check for size-calculation overflow.
4400
4401 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
4402 unnecessary integer overflow. Check for size overflow.
4403 (encode_coding_object): Don't update size until xmalloc succeeds.
4404
4405 * composite.c (get_composition_id): Check for overflow in glyph
4406 length calculations.
4407
4408 Integer and memory overflow fixes for display code.
4409 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
4410 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
4411 (scrolling_window): Check for overflow in size calculations.
4412 (line_draw_cost, realloc_glyph_pool, add_row_entry):
4413 Don't assume glyph table len fits in int.
4414 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
4415 (row_table_size): Now ptrdiff_t, not int.
4416 (scrolling_window): Avoid overflow in size calculations.
4417 Don't update size until allocation succeeds.
4418 * fns.c (concat): Check for overflow in size calculations.
4419 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
4420 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4421 (NEXT_ALMOST_PRIME_LIMIT): New constant.
4422
4423 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
4424 (get_doc_string): Check for size calculation overflow.
4425 Don't update size until allocation succeeds.
4426 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
4427 EMACS_INT, where ptrdiff_t will do.
4428 (Fsubstitute_command_keys): Check for string overflow.
4429
4430 * editfns.c (set_time_zone_rule): Don't assume environment length
4431 fits in int.
4432 (message_length): Now ptrdiff_t, not int.
4433 (Fmessage_box): Don't update size until allocation succeeds.
4434 Don't assume message length fits in int.
4435 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
4436
0065d054
PE
4437 * emacs.c (main): Do not reallocate argv, since there is a null at
4438 the end that can be overwritten, and this way there's no need to
4439 worry about size-calculation overflow.
4440 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
4441
4442 * eval.c (init_eval_once, grow_specpdl): Don't update size until
4443 alloc succeeds.
4444 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
4445
4446 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
4447 (x_set_scroll_bar_width, x_figure_window_size):
4448 Check for integer overflow.
4449 (x_set_alpha): Do not assume XINT fits in int.
4450
4451 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
4452 This is for the members text_lines, text_cols, total_lines, total_cols,
4453 where the system imposes an 'int' limit.
4454
4455 * fringe.c (Fdefine_fringe_bitmap):
4456 Don't update size until alloc works.
4457
4458 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
4459 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
4460
4461 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
4462 Check for size-calculation overflow.
4463 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
4464 do, as we prefer signed integers.
4465 (id_to_widget.max_size, id_to_widget.used)
4466 (xg_store_widget_in_map, xg_remove_widget_from_map)
4467 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
4468 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
4469 Use and return ptrdiff_t, not int.
4470 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
4471 * gtkutil.h: Change prototypes to match the above.
4472
4473 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
4474 are duplicate now that they've been promoted to lisp.h.
4475 (x_allocate_bitmap_record, x_alloc_image_color)
4476 (make_image_cache, cache_image, xpm_load):
4477 Don't update size until alloc is done.
4478 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
4479 (x_detect_edges):
3256efce 4480 Check for size calculation overflow.
726e0ab1
PE
4481 (ct_colors_allocated_max): New constant.
4482 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
4483 overflow.
3256efce 4484
726e0ab1
PE
4485 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
4486 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
4487 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
4488 Use ptrdiff_t, not int, to count maps.
4489 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
4490 calculations. Don't update size until allocation succeeds.
4491 Redo calculations to avoid overflow.
726e0ab1
PE
4492 * keyboard.h: Change prototypes to match the above.
4493
4494 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
4495 to count maps.
4496 (current_minor_maps): Check for size calculation overflow.
4497 * keymap.h: Change prototypes to match the above.
4498
4499 * lread.c (read1, init_obarray): Don't update size until alloc done.
4500
4501 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
4502 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
4503
726e0ab1
PE
4504 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
4505 Now ptrdiff_t, not int.
4506 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
4507 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
4508
4509 * process.c (Fnetwork_interface_list): Check for overflow
4510 in size calculation.
4511
4512 * region-cache.c (move_cache_gap): Check for size calculation overflow.
4513
4514 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
4515 overflow. Don't bother calling xmalloc when xrealloc will do.
4516
4517 * search.c (Freplace_match): Check for size calculation overflow.
4518 (Fset_match_data): Don't assume list lengths fit in 'int'.
4519
4520 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
4521 for command line length. Do not attempt to address one before the
4522 beginning of an array, as that's not portable.
4523
4524 * term.c (max_frame_lines): Remove; unused.
4525 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
4526 not int.
4527 (encode_terminal_code, calculate_costs): Check for size
4528 calculation overflow.
4529 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
4530 table lengths and related sizes. Don't update size until alloc
4531 done. Redo calculations to avoid overflow.
4532 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
4533
4534 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
4535 subtracting pointers.
4536 (gobble_line): Check for overflow more carefully. Don't update size
4537 until alloc done.
4538
4539 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
4540 Don't update size until alloc done.
4541 Redo size calculations to avoid overflow.
4542 Check for size calculation overflow.
0065d054 4543 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
4544
4545 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
4546 Use ptrdiff_t, not int, for sizes.
4547 (store_mode_line_noprop_char): Don't update size until alloc done.
4548
0065d054
PE
4549 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
4550 Use ptrdiff_t, not int, for sizes.
4551 (Finternal_make_lisp_face, cache_face):
4552 Check for size calculation overflow.
4553 (cache_face): Treat size calculation overflows as if they were
4554 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
4555
4556 * xfns.c (x_encode_text, x_set_name_internal)
4557 (Fx_change_window_property): Use ptrdiff_t, not int, to count
4558 sizes, since they can exceed INT_MAX in size. Check for size
4559 calculation overflow.
4560
0065d054
PE
4561 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
4562 (xg_select): Check for size calculation overflow.
726e0ab1
PE
4563 Don't update size until alloc done.
4564
0065d054 4565 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 4566 as sprintf is limited to int lengths.
1d526e2f 4567
252c5ee1
PE
4568 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
4569 (X_LONG_MIN): New macros.
864d7ce7
PE
4570 Use them to make the following changes clearer.
4571 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
4572 This change doesn't affect the value now, but it may help remind
4573 future maintainers not to raise the value too much later.
4574 (SELECTION_QUANTUM): Remove, replacing with ...
4575 (selection_quantum): ... new function, which avoids overflow.
4576 All uses changed.
4577 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
4578 assumption that selection length fits in 'int'.
4579 (x_reply_selection_request, x_handle_selection_request)
4580 (x_get_window_property, receive_incremental_selection)
4581 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
4582 (lisp_data_to_selection_data, clean_local_selection_data):
4583 Use ptrdiff_t, not int, to record length of selection.
4584 (x_reply_selection_request, x_get_window_property)
4585 (receive_incremental_selection, x_property_data_to_lisp):
4586 Redo calculations to avoid overflow.
4587 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 4588 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
4589 something.
4590 (x_get_window_property, receive_incremental_selection)
4591 (lisp_data_to_selection_data, x_property_data_to_lisp):
4592 Check for size-calculation overflow.
4593 (x_get_window_property, receive_incremental_selection)
4594 (lisp_data_to_selection_data, Fx_register_dnd_atom):
4595 Don't store size until memory allocation succeeds.
4596 (x_get_window_property): Plug memory leak on memory exhaustion.
4597 Don't double-block input; malloc is safe here. Don't assume 2**34
4598 - 4 fits in unsigned long. Add an xassert to check
4599 XGetWindowProperty overflow. Be more careful about overflow
4600 calculations, and distinguish size from memory overflow better.
4601 (receive_incremental_selection): When tracing, don't assume
4602 unsigned int is less than INT_MAX.
4603 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
4604 harmful) conversions of unsigned short to int.
4605 (lisp_data_to_selection_data): Don't assume that integers
4606 in the range -65535 through -1 fit in an X unsigned short.
4607 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
4608 result parameters unless successful. Rely on cons_to_unsigned
4609 to report problems with elements; the old code wasn't right anyway.
4610 (x_check_property_data): Check for int overflow; we cannot use
4611 a wider type due to X limits.
4612 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
4613
726e0ab1 4614 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 4615
0065d054
PE
4616 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
4617 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
4618 (x_color_cells): Don't store size until memory allocation succeeds.
4619 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 4620 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
4621 (x_term_init): Don't assume length fits in int (sprintf is limited
4622 to int size).
bc18e09d 4623
ebfa62c0
PE
4624 Use ptrdiff_t for composition IDs.
4625 * character.c (lisp_string_width):
4626 * composite.c (composition_table_size, n_compositions)
4627 (get_composition_id, composition_gstring_from_id):
4628 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
4629 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
4630 * window.c (Frecenter):
4631 Use ptrdiff_t, not int, for composition IDs.
4632 * composite.c (get_composition_id): Check for integer overflow.
4633 * composite.h: Adjust prototypes to match the above changes.
4634
d3411f89
PE
4635 Use ptrdiff_t for hash table indexes.
4636 * category.c (hash_get_category_set):
4637 * ccl.c (ccl_driver):
4638 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
4639 * coding.c (coding_system_charset_list, detect_coding_system):
4640 * coding.h (struct coding_system.id):
4641 * composite.c (get_composition_id, gstring_lookup_cache):
4642 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
4643 * image.c (xpm_get_color_table_h):
4644 * lisp.h (hash_lookup, hash_put):
4645 * minibuf.c (Ftest_completion):
4646 Use ptrdiff_t for hash table indexes, not int (which is too
4647 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
4648 32-bit --with-wide-int hosts).
4649
e097a6fa
PE
4650 * charset.c (Fdefine_charset_internal): Check for integer overflow.
4651 Add a FIXME comment about memory leaks.
4652 (syms_of_charset): Don't assume xmalloc returns.
4653
5637687f
PE
4654 Don't assume that stated character widths fit in int.
4655 * character.c (Fchar_width, c_string_width, lisp_string_width):
4656 * character.h (CHAR_WIDTH):
4657 * indent.c (MULTIBYTE_BYTES_WIDTH):
4658 Use sanitize_char_width to avoid undefined and/or bad behavior
4659 with outlandish widths.
a66cfb1c 4660 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
4661 now that we have two such functions. All uses changed.
4662 (sanitize_char_width): New inline function.
4663
a2271ba2
PE
4664 Don't assume that tab-width fits in int.
4665 * character.h (sanitize_width): New inline function.
4666 (SANE_TAB_WIDTH): New macro.
4667 (ASCII_CHAR_WIDTH): Use it.
4668 * indent.c (sane_tab_width): Remove. All uses replaced by
4669 SANE_TAB_WIDTH (current_buffer).
4670 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
4671
18c52557
PE
4672 * fileio.c: Integer overflow issues with file modes.
4673 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
4674
caeeedc1
PE
4675 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
4676 Remove unreachable code.
4677 (read_hex, load_charset_map_from_file): Check for integer overflow.
4678
6df6ae42 4679 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
4680 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
4681 (x_send_scroll_bar_event): Likewise. Check that the size does not
4682 exceed limits imposed by XClientMessageEvent, as well as the usual
4683 ptrdiff_t and size_t limits.
4684
b13995db
PE
4685 * keyboard.c: Overflow, signedness and related fixes.
4686 (make_lispy_movement): Use same integer type in forward decl
4687 that is used in the definition.
4688 (read_key_sequence, keyremap_step):
4689 Change bufsize argument back to int, undoing my 2011-03-30 change.
4690 We prefer signed types, and int is wide enough here.
4691 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
4692 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
4693 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
4694 length, not size_t. Use ptrdiff_t for index, not int.
4695 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
4696 possibility of integer overflow.
4697
13464394
PE
4698 Overflow, signedness and related fixes for images.
4699
4700 * dispextern.h (struct it.stack[0].u.image.image_id)
4701 (struct_it.image_id, struct image.id, struct image_cache.size)
4702 (struct image_cache.used, struct image_cache.ref_count):
4703 * gtkutil.c (update_frame_tool_bar):
4704 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
4705 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
4706 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
4707 * nsmenu.m (update_frame_tool_bar):
4708 * xdisp.c (calc_pixel_width_or_height):
4709 * xfns.c (image_cache_refcount):
4710 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
4711 on typical 64-bit hosts.
4712
4713 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4714 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
4715 Omit unnecessary casts to int.
4716 (parse_image_spec): Check that integers fall into 'int' range
4717 when the callers expect that.
4718 (image_ascent): Redo ascent calculation to avoid int overflow.
4719 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
4720 (lookup_image): Remove unnecessary tests.
4721 (xbm_image_p): Locals are now of int, not EMACS_INT,
4722 since parse_image_check makes sure they fit into int.
4723 (png_load, gif_load, svg_load_image):
4724 Prefer int to unsigned where either will do.
4725 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
4726 old tiff_error_handler and tiff_warning_handler.
4727 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
4728 stack buffer overflows. It uses only the features of vsnprintf
4729 that are common to both POSIX and native Microsoft.
4730 (tiff_error_handler, tiff_warning_handler): Use it.
4731 (tiff_load, gif_load, imagemagick_load_image):
4732 Don't assume :index value fits in 'int'.
4733 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
4734 (imagemagick_load_image): Check that crop parameters fit into
4735 the integer types that MagickCropImage accepts. Don't assume
4736 Vimagemagick_render_type has a nonnegative value. Don't assume
4737 size_t fits in 'long'.
4738 (gs_load): Use printmax_t to print the widest integers possible.
4739 Check for integer overflow when computing image height and width.
4740
c11821d4
EZ
47412011-08-26 Eli Zaretskii <eliz@gnu.org>
4742
4743 * xdisp.c (redisplay_window): Don't force window start if point
4744 will be invisible in the resulting window. (Bug#9324)
4745
0c95fcf7
EZ
47462011-08-25 Eli Zaretskii <eliz@gnu.org>
4747
4748 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
4749 the display spec is of the form `(space ...)'.
4750 (handle_display_spec): Return the value returned by
4751 handle_single_display_spec, not just 1 or zero.
4752 (handle_single_display_spec): If the display spec is of the form
4753 `(space ...)', and specifies display in the text area, return 2
4754 rather than 1.
fee65a97 4755 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
4756 accurately, and prefer exact match for point under bidi.
4757 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
4758
4759 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
4760 into disp_prop; all users changed.
4761
4762 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
4763 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
4764 for the text covered by the display property.
4765
e4ed06f1
CY
47662011-08-25 Chong Yidong <cyd@stupidchicken.com>
4767
4768 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
4769 Change return value to nil.
4770 (Frecord_buffer): Delete unused function.
4771
f67cdd7f
EZ
47722011-08-24 Eli Zaretskii <eliz@gnu.org>
4773
5980d4c6
EZ
4774 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
4775 buffers, return left-to-right.
8610fe8b
EZ
4776 (set_cursor_from_row): Consider candidate row a win if its glyph
4777 represents a newline and point is on that newline. Fixes cursor
4778 positioning on the newline at EOL of R2L text within L2R
4779 paragraph, and vice versa.
4780 (try_cursor_movement): Check continued rows, in addition to
4781 continuation rows. Fixes unwarranted scroll when point enters a
4782 continued line of R2L text within an L2R paragraph, or vice versa.
4783 (cursor_row_p): Consider the case of point being equal to
4784 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
4785 from the end of a short line to the beginning of a continued line
4786 of R2L text within L2R paragraph.
4787 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
4788 composed characters.
5980d4c6 4789
f67cdd7f
EZ
4790 * bidi.c (bidi_check_type): Use xassert.
4791 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
4792 members.
4793
bca633fb
EZ
47942011-08-23 Eli Zaretskii <eliz@gnu.org>
4795
4796 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
4797 a character.
4798
4a5885a7
CY
47992011-08-23 Chong Yidong <cyd@stupidchicken.com>
4800
4801 * nsfont.m (ns_otf_to_script): Fix typo.
4802
0902a04e
KH
48032011-08-22 Kenichi Handa <handa@m17n.org>
4804
4805 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
4806 extra slot even if the purpose is char-code-property-table.
4807
1a2e6670
EZ
48082011-08-23 Eli Zaretskii <eliz@gnu.org>
4809
8ddde651
EZ
4810 * xdisp.c (redisplay_window): When computing centering_position,
4811 account for the height of the header line. (Bug#8874)
4812
425cc014
EZ
4813 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
4814 instead of CHAR_TO_BYTE. Fixes a crash when a completion
4815 candidate is selected by the mouse, and that candidate has a
4816 composed character under the mouse.
4817
1a2e6670
EZ
4818 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
4819 coordinates reported by pos-visible-in-window-p for a composed
4820 character in column zero.
4821
8b76d6f8
SM
48222011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
4823
4824 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
4825
dac347dd
EZ
48262011-08-22 Eli Zaretskii <eliz@gnu.org>
4827
4828 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
4829 consider it a hit if to_charpos is anywhere in the range of the
4830 composed buffer positions.
4831
e013fb34
CY
48322011-08-22 Chong Yidong <cyd@stupidchicken.com>
4833
4834 * image.c (gif_load): Don't assume that each subimage has the same
4835 dimensions as the base image. Handle disposal method that is
4836 "undefined" by the gif spec (Bug#9335).
4837
bd1ba3e8
CY
48382011-08-20 Chong Yidong <cyd@stupidchicken.com>
4839
4840 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 4841 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 4842
54a1215b
EZ
48432011-08-19 Eli Zaretskii <eliz@gnu.org>
4844
823564e5
EZ
4845 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
4846 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
4847 from an Org mode buffer to a Speedbar frame.
4848
54a1215b
EZ
4849 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
4850 a composition, take its buffer position from IT->cmp_it.charpos.
4851 Fixes cursor positioning at the beginning of a line that begins
4852 with a composed character.
4853
9778ebcc
EZ
48542011-08-18 Eli Zaretskii <eliz@gnu.org>
4855
0be6ee06
EZ
4856 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
4857 character bidirectional type, use STRONG_L instead. Fixes crashes
4858 in a buffer produced by `describe-categories'.
4859
9778ebcc
EZ
4860 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
4861 members before the level stack, so they would be saved and
4862 restored when copying iterator state. Fixes incorrect reordering
4863 around TABs covered by display properties.
4864
156bffbe
AS
48652011-08-18 Andreas Schwab <schwab@linux-m68k.org>
4866
6b02f655 4867 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 4868
72ad093b
CY
48692011-08-17 Chong Yidong <cyd@stupidchicken.com>
4870
4871 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
4872 (internal_condition_case_2, internal_condition_case_n):
4873 Remove unnecessary aborts (Bug#9081).
72ad093b 4874
35774242
EZ
48752011-08-17 Eli Zaretskii <eliz@gnu.org>
4876
4877 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
4878 has no `load' handler, try opening the file locally. (Bug#9311)
4879
db76dd85
KB
48802011-08-16 Ken Brown <kbrown@cornell.edu>
4881
4882 * gmalloc.c: Expand comment.
4883
b215eee5
EZ
48842011-08-16 Eli Zaretskii <eliz@gnu.org>
4885
4886 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
4887 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
4888
a4579d33
KB
48892011-08-16 Ken Brown <kbrown@cornell.edu>
4890
4891 Fix memory allocation problems in Cygwin build (Bug#9273).
4892
4893 * unexcw.c ( __malloc_initialized): Declare external variable.
4894 (fixup_executable): Force the dumped emacs to reinitialize malloc.
4895
8b76d6f8
SM
4896 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
4897 New variables.
a4579d33
KB
4898 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
4899 dumped emacs.
4900 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
4901 in the static heap.
4902 [CYGWIN] (special_realloc): New function.
4903 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
4904 requests to realloc storage in the static heap.
4905
3ebec551
PE
49062011-08-15 Paul Eggert <eggert@cs.ucla.edu>
4907
4908 * bidi.c (bidi_initialize): Remove unused local.
4909
9fd8be00
EZ
49102011-08-15 Eli Zaretskii <eliz@gnu.org>
4911
6b02f655
SM
4912 * bidimirror.h:
4913 * biditype.h: Remove file.
4914 * makefile.w32-in ($(BLD)/bidi.$(O)):
4915 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
4916
4917 * dispextern.h: Fix a typo in the comment to bidi_type_t.
4918
4919 * chartab.c: Improve commentary for the uniprop_table API.
4920
32413314
EZ
4921 * bidi.c (bidi_paragraph_init): Support zero value of
4922 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
4923 (bidi_initialize): Use uniprop_table instead of including
4924 biditype.h and bidimirror.h.
32413314 4925
9fd8be00
EZ
4926 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
4927 coordinates of the iterator when restoring from ppos_it.
4928 (Bug#9296)
4929
5cf2b69b
KH
49302011-08-14 Kenichi Handa <handa@m17n.org>
4931
4932 * process.c (create_process): Call setup_process_coding_systems
72ad093b 4933 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 4934
daf17d00
EZ
49352011-08-14 Eli Zaretskii <eliz@gnu.org>
4936
4937 * xdisp.c (move_it_in_display_line_to): Don't invoke
4938 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
4939 ppos_it. Fixes vertical cursor motion when line beginning is
4940 covered by an image. (Bug#9296)
4941
08e3161a
JD
49422011-08-14 Jan Djärv <jan.h.d@swipnet.se>
4943
4944 * nsterm.h (ns_run_ascript): Declare.
4945 (NSAPP_DATA2_RUNASSCRIPT): Define.
4946
4947 * nsfns.m (as_script, as_result, as_status): New static variables.
4948 (ns_run_ascript): New function.
5e617bc2 4949 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
4950 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
4951 the event loop. Get status from as_status (Bug#7276).
4952
4953 * nsterm.m (sendEvent): If event is NSApplicationDefined and
4954 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
4955 the event loop (Bug#7276).
4956
a3720aa2
AS
49572011-08-14 Andreas Schwab <schwab@linux-m68k.org>
4958
4959 * gnutls.c (QCgnutls_bootprop_priority)
4960 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
4961 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
4962 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
4963 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
4964 (QCgnutls_bootprop_verify_hostname_error)
4965 (QCgnutls_bootprop_callbacks_verify): Rename from
4966 Qgnutls_bootprop_..., all uses changed.
4967
4968 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
4969 uses changed.
4970
0a0d27fb
PE
49712011-08-14 Paul Eggert <eggert@cs.ucla.edu>
4972
19d5c50c
PE
4973 * xfaces.c (Qframe_set_background_mode): Now static.
4974 * dispextern.h (Qframe_set_background_mode): Remove decl.
4975
0a0d27fb
PE
4976 * process.c (Fnetwork_interface_info): Declare local only if needed.
4977
377538cb
JD
49782011-08-13 Jan Djärv <jan.h.d@swipnet.se>
4979
4980 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
4981 (Fnetwork_interface_list): Allocate in increments of bytes instead
4982 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
4983 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
4984 sockaddr.
4985 (struct ifflag_def): notrailers is smart on OSX.
4986 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
4987 Get hardware address with getifaddrs if available.
4988
08fff70c
EZ
49892011-08-12 Eli Zaretskii <eliz@gnu.org>
4990
4991 * xdisp.c (iterate_out_of_display_property): xassert that
4992 IT->position is set to within IT->object's boundaries. Break from
4993 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
4994 when IT->position is set up wrongly due to some bug.
4995 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
4996 (push_display_prop): Allow GET_FROM_STRING as IT->method on
4997 entry. Force push_it to save on the stack the current
4998 buffer/string position, to be restored by pop_it. Fix flags in
4999 the iterator structure wrt the object coming from a display
5000 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
5001 properties. (Bug#9284)
5002
7be1c708 50032011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 5004
7be1c708
CY
5005 * fontset.c (fontset_get_font_group): Add proper type checks.
5006 (Bug#9172)
aac0c6e3 5007
7be1c708 50082011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 5009
7be1c708
CY
5010 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
5011 and LC_VERSION_MIN_MACOSX.
5012 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
5013 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 5014
97bb72a6
EZ
50152011-08-08 Eli Zaretskii <eliz@gnu.org>
5016
5017 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
5018 no-display-properties-and-no-overlays under bidi display.
5019 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 5020 properties and overlays.
97bb72a6 5021
d5617611
CY
50222011-08-08 Chong Yidong <cyd@stupidchicken.com>
5023
37e11a63
CY
5024 * editfns.c (Fset_time_zone_rule): Document relationship with the
5025 setenv function.
5026
d5617611
CY
5027 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
5028 the font entity extracted from the cache (Bug#8109).
5029
58872834
CY
50302011-08-07 Chong Yidong <cyd@stupidchicken.com>
5031
5032 * composite.c (autocmp_chars): Don't reset point. That is done by
5033 restore_point_unwind (Bug#5984).
5034
75bfc667
JL
50352011-08-07 Juri Linkov <juri@jurta.org>
5036
5037 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
5038 to show the arg `TIME' instead of `TIMEVAL'.
5039
d1410150
EZ
50402011-08-06 Eli Zaretskii <eliz@gnu.org>
5041
5042 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
5043 display property strides EOL and includes a newline, as in
5044 longlines-mode. (Bug#9254)
75b771e4
EZ
5045 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
5046 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
5047
5048 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
5049 is non-zero, even if the data buffer is NULL. Fixes a crash in
5050 vertical-motion with longlines-mode. (Bug#9254)
5051
35928349
EZ
50522011-08-05 Eli Zaretskii <eliz@gnu.org>
5053
ec7cc85b
EZ
5054 * bidi.c <bidi_cache_total_alloc>: Now static.
5055 (bidi_initialize): Initialize bidi_cache_total_alloc.
5056
8b76d6f8 5057 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
5058 cache. (Bug#9221)
5059
5060 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
5061 amount allocated this far in `bidi_cache_total_alloc'.
5062 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
5063 non-zero, only free the data buffer without restoring the cache
5064 contents. All callers changed.
5065
5066 * dispextern.h (bidi_unshelve_cache): Update prototype.
5067
5068 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
5069 (move_it_in_display_line, move_it_to)
5070 (move_it_vertically_backward, move_it_by_lines): Replace the call
5071 to xfree to an equivalent call to bidi_unshelve_cache.
5072 (move_it_in_display_line_to): Fix logic of returning
412b6358 5073 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 5074
e2e2423b
EZ
50752011-08-05 Eli Zaretskii <eliz@gnu.org>
5076
5077 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
5078 came from a string character with a `cursor' property. (Bug#9229)
5079
ae9e757a
JD
50802011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5081
5082 * Makefile.in (LIB_PTHREAD): New variable.
5083 (LIBES): Add LIB_PTHREAD (Bug#9216).
5084
5085 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
5086 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
5087
213bd7f2
AS
50882011-08-04 Andreas Schwab <schwab@linux-m68k.org>
5089
6b02f655 5090 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 5091
99aaf75f
JD
50922011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5093
5094 * xterm.c (x_find_topmost_parent): New function.
5095 (x_set_frame_alpha): Find topmost parent window with
5096 x_find_topmost_parent and set the property there also (bug#9181).
5097 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
5098
c74e9d86
PE
50992011-08-04 Paul Eggert <eggert@cs.ucla.edu>
5100
5101 * callproc.c (Fcall_process): Avoid vfork clobbering
5102 the local vars buffer, coding_systems, current_dir.
5103
640c8776
SM
51042011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
5105
5106 * keymap.c (Fmake_composed_keymap): Move to subr.el.
5107
f26d0e4c
PE
51082011-08-03 Paul Eggert <eggert@cs.ucla.edu>
5109
8a10d76c
PE
5110 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
5111 so that it is not optimized away.
5112
f26d0e4c
PE
5113 * xdisp.c (compute_display_string_pos): Remove unused local.
5114
55439c61
EZ
51152011-08-02 Eli Zaretskii <eliz@gnu.org>
5116
5117 Fix slow cursor motion and scrolling in large buffers with
5118 selective display, like Org Mode buffers. (Bug#9218)
5119
5120 * dispextern.h (struct bidi_it): New member disp_prop_p.
5121
5122 * xdisp.c: Remove one-slot cache of display string positions.
5123 (compute_display_string_pos): Accept an additional argument
5e617bc2 5124 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
5125 for a display string or property. If found, set DISP_PROP_P
5126 non-zero.
5127
5128 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
5129 DISP_PROP_P, and pass it to compute_display_string_pos.
5130 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
5131 non-zero. All callers of bidi_fetch_char changed.
5132
fb33fa43
SM
51332011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
5134
5135 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
5136
b099e063
DM
51372010-12-03 Don March <don@ohspite.net>
5138
5139 * keymap.c (Fdefine_key): Fix non-prefix key error message when
5140 last character M-[char] is translated to ESC [char] (bug#7541).
5141
5cc7f7af
KH
51422011-08-02 Kenichi Handa <handa@m17n.org>
5143
d0fffa3f 5144 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
5145
5146 * chartab.c (uniprop_table): Make it non-static.
5147
525d5e6e
EZ
51482011-08-01 Eli Zaretskii <eliz@gnu.org>
5149
5150 * xdisp.c (forward_to_next_line_start): Accept additional argument
5151 BIDI_IT_PREV, and store into it the state of the bidi iterator had
5152 on the newline.
5153 (reseat_at_next_visible_line_start): Use the bidi iterator state
5154 returned by forward_to_next_line_start to restore the state of
5155 it->bidi_it after backing up to previous newline. (Bug#9212)
5156
31011111
AS
51572011-07-30 Andreas Schwab <schwab@linux-m68k.org>
5158
5159 * regex.c (re_comp): Protoize.
5160 (re_exec): Fix return type.
5161 (regexec): Fix type of `ret'. (Bug#9203)
5162
476371c4
PE
51632011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5164
e5d76069
PE
5165 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
5166 This is needed if max-image-size is a floating-point number.
5167
9a79b20c
AS
51682011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5169
5170 * print.c (print_object): Print empty symbol as ##.
5171
5172 * lread.c (read1): Read ## as empty symbol.
5173
d8c2fa78
AA
51742011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5175
5176 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
5177 setting frame foreground color (Bug#9175).
5178 (x_set_background_color): Likewise.
5179
ffe57a7a
AA
5180 * nsmenu.m (-setText): Size tooltip dimensions precisely to
5181 contents (Bug#9176).
5182 (EmacsTooltip -init): Remove bezels and add shadows to
5183 tooltip windows.
5184
bf3492a5
AA
5185 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
5186 or scroll bar (Bug#8470).
5187
d55e9c53
AA
5188 * nsfont.m (nsfont_open): Remove assignment to voffset and
5189 unnecessary vars hshink, expand, hd, full_height, min_height.
5190 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
5191
5192 * nsterm.h (nsfont_info): Remove voffset field.
5193
d8c2fa78 51942011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
5195
5196 Implement strike-through and overline on NextStep (Bug#8863).
5197
5198 * nsfont.m (nsfont_open): Use underline position provided by font,
5199 instead of hard-coded value of 2.
5200 (nsfont_draw): Call ns_draw_text_decoration instead.
5201
5202 * nsterm.h: Add declaration for ns_draw_text_decoration.
5203
5204 * nsterm.m (ns_draw_text_decoration): New function for drawing
5205 underline, overline, and strike-through.
5206 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
5207 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 5208 accommodate underlining, etc.
4843aac3 5209
4cc60b9b
EZ
52102011-07-28 Eli Zaretskii <eliz@gnu.org>
5211
bc7ece87
EZ
5212 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
5213 default.
4cc60b9b 5214
476371c4
PE
52152011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5216
66606eea
PE
5217 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
5218 Without this fix, if a signal arrives just after memory fills up,
5219 'malloc' might be invoked reentrantly.
5220
476371c4
PE
5221 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
5222 In other words, assume that every image size is allowed, on non-X
5223 hosts. This assumption is probably wrong, but it lets Emacs compile.
5224
f3fcc40d
AS
52252011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5226
5227 * regex.c (re_iswctype): Convert return values to boolean.
5228
350c992f
EZ
52292011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
5230
5231 * xdisp.c (compute_display_string_pos): Don't use cached display
5232 string position if the buffer had its restriction changed.
5233 (Bug#9184)
5234
5266b4bb
PE
52352011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5236
5237 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5238
2573a837 52392011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 5240
41f55ccd 5241 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 5242
39e378da
PE
5243 * bidi.c: Integer size and overflow fixes.
5244 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
5245 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
5246 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5247 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
5248 (bidi_find_other_level_edge):
5249 Use ptrdiff_t instead of EMACS_INT where either will do.
5250 This works better on 32-bit hosts configured --with-wide-int.
5251 (bidi_cache_ensure_space): Check for size-calculation overflow.
5252 Use % rather than repeated addition, for better worst-case speed.
5253 Don't set bidi_cache_size until after xrealloc returns, because it
5254 might not return.
5255 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
5256 (bidi_cache_ensure_space): Also check that the bidi cache size
5257 does not exceed that of the largest Lisp string or buffer. See Eli
5258 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 5259
5e927815
PE
5260 * alloc.c (__malloc_size_t): Remove.
5261 All uses replaced by size_t. See Andreas Schwab's note
5262 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
5263
ca4aa935
PE
5264 * image.c: Improve checking for integer overflow.
5265 (check_image_size): Assume that f is nonnull, since
5266 it is always nonnull in practice. This is one less thing to
5267 worry about when checking for integer overflow later.
5268 (x_check_image_size): New function, which checks for integer
5269 overflow issues inside X.
5270 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
5271 This removes the need for a memory_full check.
5272 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
5273 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
5274 (xbm_read_bitmap_data): Change locals back to 'int', since
5275 their values must fit in 'int'.
5276 (xpm_load_image, png_load, tiff_load):
5277 Invoke x_create_x_image_and_pixmap earlier,
5278 to avoid much needless work if the image is too large.
5279 (tiff_load): Treat overly large images as if
5280 x_create_x_image_and_pixmap failed, not as malloc failures.
5281 (gs_load): Use x_check_image_size.
5282
5f8f9cc2
PE
5283 * gtkutil.c: Omit integer casts.
5284 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
5285 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
5286
5adf60bc
PE
5287 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
5288
c8907a93
PE
5289 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
5290 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
5291 would wrongly return t on a 64-bit host.
5292
e3c25c68
PE
5293 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
5294 The plain *_OVERFLOW macros run afoul of GCC bug 49705
5295 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
5296 and therefore cause GCC to emit a bogus diagnostic in some cases.
5297
3f791afe
PE
5298 * image.c: Integer signedness and overflow and related fixes.
5299 This is not an exhaustive set of fixes, but it's time to
5300 record what I've got.
5301 (lookup_pixel_color, check_image_size): Remove redundant decls.
5302 (check_image_size): Don't assume that arbitrary EMACS_INT values
5303 fit in 'int', or that arbitrary 'double' values fit in 'int'.
5304 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
5305 (tiff_load, imagemagick_load_image):
5306 Check for overflow in size calculations.
5307 (x_create_x_image_and_pixmap): Remove unnecessary test for
5308 xmalloc returning NULL; that can't happen.
5309 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
5310 (xpm_color_bucket): Use better integer hashing function.
5311 (xpm_cache_color): Don't possibly over-allocate memory.
5312 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
5313 (gif_memory_source):
5314 Use ptrdiff_t, not int or size_t, to record sizes.
5315 (png_load): Don't assume values greater than 2**31 fit in 'int'.
5316 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
5317 either works, as we prefer signed integers.
5318 (tiff_read_from_memory, tiff_write_from_memory):
5319 Return tsize_t, not size_t, since that's what the TIFF API wants.
5320 (tiff_read_from_memory): Don't fail simply because the read would
5321 go past EOF; instead, return a short read.
5322 (tiff_load): Omit no-longer-needed casts.
5323 (Fimagemagick_types): Don't assume size fits into 'int'.
5324
3cc5a532
PE
5325 Improve hashing quality when configured --with-wide-int.
5326 * fns.c (hash_string): New function, taken from sxhash_string.
5327 Do not discard information about ASCII character case; this
5328 discarding is no longer needed.
5329 (sxhash-string): Use it. Change sig to match it. Caller changed.
5330 * lisp.h: Declare it.
5331 * lread.c (hash_string): Remove, since we now use fns.c's version.
5332 The fns.c version returns a wider integer if --with-wide-int is
5333 specified, so this should help the quality of the hashing a bit.
5334
b312a492
PE
5335 * emacs.c: Integer overflow minor fix.
5336 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
5337 Define only if GNU_LINUX.
5338 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
5339
dfd153ae
PE
5340 * dispnew.c: Integer signedness and overflow fixes.
5341 Remove unnecessary forward decls, that were a maintenance hassle.
5342 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
5343 All uses changed.
5344 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
5345 (scrolling_window): Use ptrdiff_t, not int, for byte count.
5346 (prepare_desired_row, line_draw_cost):
5347 Use int, not unsigned, where either works.
5348 (save_current_matrix, restore_current_matrix):
5349 Use ptrdiff_t, not size_t, where either works.
5350 (init_display): Check for overflow more accurately, and without
5351 relying on undefined behavior.
5352
a81d11a3
PE
5353 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
5354 Remove, replacing with the new symbols in lisp.h. All uses changed.
5355 * fileio.c (make_temp_name):
5356 * filelock.c (lock_file_1, lock_file):
5357 * xdisp.c (message_dolog):
5358 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
5359 Use pMd etc. instead.
5360 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
5361 replacing the pWIDE etc. symbols removed from editfns.c.
5362
3300e6fd
PE
5363 * keyboard.h (num_input_events): Now uintmax_t.
5364 This is (very slightly) less likely to mess up due to wraparound.
5365 All uses changed.
5366
fd05c7e9
PE
5367 * buffer.c: Integer signedness fixes.
5368 (alloc_buffer_text, enlarge_buffer_text):
5369 Use ptrdiff_t rather than size_t when either will do, as we prefer
5370 signed integers.
5371
903fe15d
PE
5372 * alloc.c: Integer signedness and overflow fixes.
5373 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
5374 (__malloc_size_t): Default to size_t, not to int.
5375 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
5376 (Fgarbage_collect, mark_object_loop_halt, mark_object):
5377 Prefer ptrdiff_t to size_t when either would do, as we prefer
5378 signed integers.
5379 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
5380 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
5381 Now const. Initialize with values that are in range even if char
5382 is signed.
5383 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
5384 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
5385 These functions do the right thing with sizes > 2**32.
5386 (check_depth): Now ptrdiff_t, not int.
5387 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
5388 Adjust to new way of storing sizes. Check for size overflow bugs
5389 in rest of code.
5390 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
5391 slightly wrong anyway, as it missed one instance of
5392 XMALLOC_OVERRUN_CHECK_OVERHEAD.
5393 (refill_memory_reserve): Omit needless cast to size_t.
5394 (mark_object_loop_halt): Mark as externally visible.
5395
ac82cc6a
PE
5396 * xselect.c: Integer signedness and overflow fixes.
5397 (Fx_register_dnd_atom, x_handle_dnd_message):
5398 Use ptrdiff_t, not size_t, since we prefer signed.
5399 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
5400 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
5401 x_dnd_atoms_size and x_dnd_atoms_length.
5402
c2d1e36d
PE
5403 * doprnt.c: Prefer signed to unsigned when either works.
5404 * eval.c (verror):
5405 * doprnt.c (doprnt):
5406 * lisp.h (doprnt):
5407 * xdisp.c (vmessage):
5408 Use ptrdiff_t, not size_t, when using or implementing doprnt,
5409 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
5410 prefer signed arithmetic to avoid comparison confusion.
5411 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
5412 but is a bit tricky.
5413
0e926e56
PE
5414 Assume freestanding C89 headers, string.h, stdlib.h.
5415 * data.c, doprnt.c, floatfns.c, print.c:
5416 Include float.h unconditionally.
5417 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
5418 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
5419 * regex.c: Likewise for stddef.h, string.h.
5420 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
5421 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
5422 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
5423 (STDC_HEADERS): Remove obsolete defines.
5424 * sysdep.c: Include limits.h unconditionally.
5425
9cfdb3ec
PE
5426 Assume support for memcmp, memcpy, memmove, memset.
5427 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
5428 * regex.c (memcmp, memcpy):
5429 Remove; we assume C89 now.
5430
5431 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
5432 (__malloc_safe_bcopy): Remove; no longer needed.
5433
cf950e6b 5434 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
5435 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
5436 well either way, and we prefer signed to unsigned.
5437
dbf38e02
LMI
54382011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
5439
5440 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
5441 closes the connection while we're reading (bug#9182).
5442
d6f0886c 54432011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 5444
d6f0886c
JD
5445 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
5446 are specified (Bug#9168).
24e0f6b1 5447
2eb1f9e6
PE
54482011-07-25 Paul Eggert <eggert@cs.ucla.edu>
5449
5450 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
5451 Found by GCC static checking and --with-wide-int on a 32-bit host.
5452
22381272 54532011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
5454
5455 * xdisp.c (compute_display_string_pos): Fix logic of caching
5456 previous display string position. Initialize cached_prev_pos to
5457 -1. Fixes slow-down at the beginning of a buffer.
5458
f25e39b4
EZ
54592011-07-24 Eli Zaretskii <eliz@gnu.org>
5460
5461 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
5462 for attrs[LFACE_FONTSET_INDEX].
5463
04c4b52e
PE
54642011-07-23 Paul Eggert <eggert@cs.ucla.edu>
5465
5466 * xml.c (parse_region): Remove unused local
5467 that was recently introduced.
5468
c1734fbd
EZ
54692011-07-23 Eli Zaretskii <eliz@gnu.org>
5470
be18c5a5
EZ
5471 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
5472 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
5473
c1734fbd
EZ
5474 * xdisp.c (move_it_in_display_line_to): Record the best matching
5475 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
5476 exit if none of the characters scanned was an exact match.
5477 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
5478 when exact match is impossible due to invisible text, and the
5479 lines are truncated.
5480
a258d627
JD
54812011-07-23 Jan Djärv <jan.h.d@swipnet.se>
5482
5483 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
5484 for OSX >= 10.7.
5485
b6d5a689
EZ
54862011-07-22 Eli Zaretskii <eliz@gnu.org>
5487
0f74f785
EZ
5488 Fix a significant slow-down of cursor motion with C-n, C-p,
5489 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
5490 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 5491 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
5492 (next_element_from_buffer): Call compute_stop_pos_backwards to
5493 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
5494 base_level_stop.
5495 (reseat): Don't look for prev_stop, as that could mean a very long
5496 run.
5497 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
5498 <cached_disp_overlay_modiff>: Cache for last found display string
5499 position.
551918c1 5500 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
5501 about the same buffer in the same area of character positions, and
5502 the buffer wasn't changed since the time the display string
5503 position was cached.
551918c1 5504
b2d0c91a
EZ
55052011-07-22 Eli Zaretskii <eliz@gnu.org>
5506
5507 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
5508 is an integer, which is important for empty lines. (Bug#9149)
5509
043604ee
CY
55102011-07-22 Chong Yidong <cyd@stupidchicken.com>
5511
5512 * frame.c (Fmodify_frame_parameters): In tty case, update the
5513 default face if necessary (Bug#4238).
5514
da4adb04
CY
55152011-07-21 Chong Yidong <cyd@stupidchicken.com>
5516
5517 * editfns.c (Fstring_to_char): No need to explain what a character
5518 is in the docstring (Bug#6576).
5519
9abd0532
LMI
55202011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5521
5522 * xml.c (parse_region): Make sure we always return a tree.
5523
36881d16
HK
55242011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
5525
5526 * xml.c (parse_region): If a document contains only comments,
5527 return that, too.
5528
1e98674d
LMI
55292011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5530
5531 * xml.c (make_dom): Return comments, too.
5532
590bd467
PE
55332011-07-19 Paul Eggert <eggert@cs.ucla.edu>
5534
5535 Port to OpenBSD.
5536 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
5537 and the surrounding thread.
5538 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
5539 rather than fgets, and retry after EINTR. Otherwise, 'emacs
5540 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
5541 timer goes off.
5542 * s/openbsd.h (BROKEN_SIGIO): Define.
5543 * unexelf.c (unexec) [__OpenBSD__]:
5544 Don't update the .mdebug section of the Alpha COFF symbol table.
5545
f41628b2
LMI
55462011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5547
5548 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
5549 (bug#8460).
5550
b59b67c5
PE
55512011-07-18 Paul Eggert <eggert@cs.ucla.edu>
5552
15e3a074
PE
5553 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
5554 This fixes some race conditions on the permissions of any newly
5555 created file.
5556
41bed37d
PE
5557 * alloc.c (valid_pointer_p): Use pipe, not open.
5558 This fixes some permissions issues when debugging.
5559
b59b67c5
PE
5560 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
5561 If fchown fails to set both uid and gid, try to set just gid,
5562 as that is sometimes allowed. Adjust the file's mode to eliminate
5563 setuid or setgid bits that are inappropriate if fchown fails.
5564
925a6be7
SM
55652011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
5566
5567 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
5568 to compare Lisp_Objects.
5569 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
5570 global_gnutls_log_level, don't mistake it for a Lisp_Object.
5571 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
5572
52968808
AS
55732011-07-17 Andreas Schwab <schwab@linux-m68k.org>
5574
0a6a104b
AS
5575 * lread.c (read_integer): Unread even EOF character.
5576 (read1): Likewise. Properly record start position of symbol.
5577
52968808
AS
5578 * lread.c (read1): Read `#:' as empty uninterned symbol if no
5579 symbol character follows.
5580
9e381cdd
PE
55812011-07-17 Paul Eggert <eggert@cs.ucla.edu>
5582
5583 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
5584 This works around a problem with the previous change to Fcopy_file.
5585 Recent glibc declares fchown with __attribute__((warn_unused_result)),
5586 and without this change, GCC might complain about discarding
5587 fchown's return value.
5588
b5641435
JB
55892011-07-16 Juanma Barranquero <lekktu@gmail.com>
5590
5591 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
5592
a8031457
PE
55932011-07-16 Paul Eggert <eggert@cs.ucla.edu>
5594
5595 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
5596
dd889327
LMI
55972011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
5598
750c33f7
LMI
5599 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
5600 it's used from the C level.
5601
dd889327
LMI
5602 * process.c: Use the same condition for POLL_FOR_INPUT in both
5603 keyboard.c and process.c (bug#1858).
5604
87e86684
LM
56052011-07-09 Lawrence Mitchell <wence@gmx.li>
5606
5607 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
5608 (Fgnutls_boot): Use it.
5609
64348f40
AS
56102011-07-15 Andreas Schwab <schwab@linux-m68k.org>
5611
5612 * doc.c (Fsubstitute_command_keys): Revert last change.
5613
1d698799
LMI
56142011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
5615
f863868c
LMI
5616 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
5617 quotes the next character, and doesn't affect other longer
5618 sequences (bug#8935).
5619
1d698799
LMI
5620 * lread.c (syms_of_lread): Clarify that is isn't only
5621 `eval-buffer' and `eval-defun' that's affected by
5622 `lexical-binding' (bug#8460).
5623
aa4b6df6
EZ
56242011-07-15 Eli Zaretskii <eliz@gnu.org>
5625
5626 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 5627 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 5628
5d856da6
PE
56292011-07-14 Paul Eggert <eggert@cs.ucla.edu>
5630
ad6042bb
PE
5631 Fix minor problems found by static checking.
5632 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
5633 (elsz): Now a signed constant, not a size_t var. We prefer signed
5634 types to unsigned, to avoid integer comparison confusion. Without
5635 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
5636 "cannot optimize loop, the loop counter may overflow", a symptom
5637 of the confusion.
f00bbb22 5638 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
5639 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
5640
6468f31c
LMI
56412011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5642
49080b10
LMI
5643 * search.c (Fre_search_backward): Mention `case-fold-search' in
5644 all the re_search_* functions (bug#8138).
5645
6468f31c
LMI
5646 * keyboard.c (Fopen_dribble_file): Document when the file is
5647 closed (bug#8056).
5648
c965adc5
EZ
56492011-07-14 Eli Zaretskii <eliz@gnu.org>
5650
df9733bf
EZ
5651 * bidi.c (bidi_dump_cached_states): Fix format of displaying
5652 bidi_cache_idx.
5653
0bb23927
EZ
5654 Support bidi reordering of display and overlay strings.
5655 * xdisp.c (compute_display_string_pos)
5656 (compute_display_string_end): Accept additional argument STRING.
5657 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
5658 (reseat_to_string): Initialize bidi_it->string.s and
5659 bidi_it->string.schars.
5660 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
5661 NULL (avoids a crash in bidi_paragraph_init).
5662 Initialize itb.string.lstring.
0bb23927
EZ
5663 (init_iterator): Call bidi_init_it only of a valid
5664 buffer position was specified. Initialize paragraph_embedding to
5665 L2R.
5666 (reseat_to_string): Initialize the bidi iterator.
5667 (display_string): If we need to ignore text properties of
5668 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
5669 original value of -1 will not work with bidi.)
5670 (compute_display_string_pos): First arg is now struct
5671 `text_pos *'; all callers changed. Support display properties on
5672 Lisp strings.
5673 (compute_display_string_end): Support display properties on Lisp
5674 strings.
5675 (init_iterator, reseat_1, reseat_to_string): Initialize the
5676 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
5677 when iterating on a string not from display properties).
640c8776
SM
5678 (compute_display_string_pos, compute_display_string_end):
5679 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
5680 arrow keys.
5681 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
5682 base_level_stop; instead, set base_level_stop to BEGV.
5683 Fixes crashes in vertical-motion.
0bb23927
EZ
5684 (next_element_from_buffer): Improve commentary for when
5685 the iterator is before prev_stop.
5686 (init_iterator): Initialize bidi_p from the default value of
5687 bidi-display-reordering, not from buffer-local value. Use the
5688 buffer-local value only if initializing for buffer iteration.
5689 (handle_invisible_prop): Support invisible properties on strings
5690 that are being bidi-reordered.
5691 (set_iterator_to_next): Support bidi reordering of C strings and
5692 Lisp strings.
5693 (next_element_from_string): Support bidi reordering of Lisp
5694 strings.
5695 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
5696 (display_string): Support display of R2L glyph rows.
5697 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
5698 (init_iterator): Don't initialize it->bidi_p for strings
5699 here.
5700 (reseat_to_string): Initialize it->bidi_p for strings here.
5701 (next_element_from_string, next_element_from_c_string)
5702 (next_element_from_buffer): Add xassert's for correspondence
5703 between IT's object being iterated and it->bidi_it.string
5704 structure.
5705 (face_before_or_after_it_pos): Support bidi iteration.
5706 (next_element_from_c_string): Handle the case of the first string
5707 character that is not the first one in the visual order.
5708 (get_visually_first_element): New function, refactored from common
5709 parts of next_element_from_buffer, next_element_from_string, and
5710 next_element_from_c_string.
5711 (tool_bar_lines_needed, redisplay_tool_bar)
5712 (display_menu_bar): Force left-to-right direction. Add a FIXME
5713 comment for making that be controlled by a user option.
5714 (push_it, pop_it): Save and restore the state of the
5715 bidi iterator. Save and restore the bidi_p flag.
5716 (pop_it): Iterate out of display property for string iteration as
5717 well.
5718 (iterate_out_of_display_property): Support iteration over strings.
5719 (handle_single_display_spec): Set up it->bidi_it for iteration
5720 over a display string, and call bidi_init_it.
5721 (handle_single_display_spec, next_overlay_string)
5722 (get_overlay_strings_1, push_display_prop): Set up the bidi
5723 iterator for displaying display or overlay strings.
5724 (forward_to_next_line_start): Don't use the shortcut if
5725 bidi-iterating.
5726 (back_to_previous_visible_line_start): If handle_display_prop
5727 pushed the iterator stack, restore the internal state of the bidi
5728 iterator by calling bidi_pop_it same number of times.
5729 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
5730 and we are bidi-iterating, don't decrement the iterator position;
5731 instead, set the first_elt flag in the bidi iterator, to produce
5732 the same effect.
5733 (reseat_1): Remove redundant setting of string_from_display_prop_p.
5734 (push_display_prop): xassert that we are iterating a buffer.
5735 (push_it, pop_it): Save and restore paragraph_embedding member.
5736 (handle_single_display_spec, next_overlay_string)
5737 (get_overlay_strings_1, reseat_1, reseat_to_string)
5738 (push_display_prop): Set up the `unibyte' member of bidi_it.string
5739 correctly. Don't assume unibyte strings are not bidi-reordered.
5740 (compute_display_string_pos)
5741 (compute_display_string_end): Fix handling the case of C string.
5742 (push_it, pop_it): Save and restore from_disp_prop_p.
5743 (handle_single_display_spec, push_display_prop): Set the
5744 from_disp_prop_p flag.
5745 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
5746 (pop_it): Call iterate_out_of_display_property only if we are
5747 popping after iteration over a string that came from a display
5748 property. Fix a typo in popping stretch info. Add an assertion
5749 for verifying that the iterator position is in sync with the bidi
5750 iterator.
5751 (handle_single_display_spec, get_overlay_strings_1)
5752 (push_display_prop): Fix initialization of paragraph direction for
5753 string when that of the parent object is not yet determined.
5754 (reseat_1): Call bidi_init_it to resync the bidi
5755 iterator with IT's position. (Bug#7616)
5756 (find_row_edges): If ROW->start.pos gives position
5757 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
5758 (handle_stop, back_to_previous_visible_line_start, reseat_1):
5759 Reset the from_disp_prop_p flag.
5760 (SAVE_IT, RESTORE_IT): New macros.
5761 (pos_visible_p, face_before_or_after_it_pos)
5762 (back_to_previous_visible_line_start)
5763 (move_it_in_display_line_to, move_it_in_display_line)
5764 (move_it_to, move_it_vertically_backward, move_it_by_lines)
5765 (try_scrolling, redisplay_window, display_line): Use them when
5766 saving a temporary copy of the iterator and restoring it back.
5767 (back_to_previous_visible_line_start, reseat_1)
5768 (init_iterator): Empty the bidi cache "stack".
5769 (move_it_in_display_line_to): If iterator ended up at
5770 EOL, but we never saw any buffer positions smaller than
5771 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
5772 motion in bidi-reordered lines.
5773 (move_it_in_display_line_to): Record prev_method and prev_pos
5774 immediately before the call to set_iterator_to_next. Fixes cursor
5775 motion in bidi-reordered lines with stretch glyphs and strings
5776 displayed in margins. (Bug#8133) (Bug#8867)
5777 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
5778 TO_CHARPOS.
640c8776
SM
5779 (pos_visible_p): Support positions in bidi-reordered lines.
5780 Save and restore bidi cache.
0bb23927
EZ
5781
5782 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
5783 (bidi_paragraph_info): Delete unused struct.
5784 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
5785 (bidi_cache_start): New variable.
5786 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
5787 to zero.
5788 (bidi_cache_fetch_state, bidi_cache_search)
5789 (bidi_cache_find_level_change, bidi_cache_iterator_state)
5790 (bidi_cache_find, bidi_peek_at_next_level)
5791 (bidi_level_of_next_char, bidi_find_other_level_edge)
5792 (bidi_move_to_visually_next): Compare cache index with
5793 bidi_cache_start rather than with zero.
5794 (bidi_fetch_char): Accept new argument STRING; all callers
5795 changed. Support iteration over a string. Support strings with
5796 display properties. Support unibyte strings. Fix the type of
5797 `len' according to what STRING_CHAR_AND_LENGTH expects.
5798 (bidi_paragraph_init, bidi_resolve_explicit_1)
5799 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
5800 (bidi_level_of_next_char, bidi_move_to_visually_next):
5801 Support iteration over a string.
0bb23927
EZ
5802 (bidi_set_sor_type, bidi_resolve_explicit_1)
5803 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
5804 can now be zero (for strings); special values 0 and -1 were
5805 changed to -1 and -2, respectively.
5806 (bidi_char_at_pos): New function.
5807 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
5808 Call it instead of FETCH_MULTIBYTE_CHAR.
5809 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
5810 initialized to valid values.
5811 (bidi_init_it): Don't initialize charpos and bytepos with invalid
5812 values.
5813 (bidi_level_of_next_char): Allow the sentinel "position" to pass
5814 the test for valid cached positions. Fix the logic for looking up
5815 the sentinel state in the cache. GCPRO the Lisp string we are
5816 iterating.
5817 (bidi_push_it, bidi_pop_it): New functions.
5818 (bidi_initialize): Initialize the bidi cache start stack pointer.
5819 (bidi_cache_ensure_space): New function, refactored from part of
5820 bidi_cache_iterator_state. Don't assume the required size is just
5821 one BIDI_CACHE_CHUNK away.
5822 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
5823 (bidi_count_bytes, bidi_char_at_pos): New functions.
5824 (bidi_cache_search): Don't assume bidi_cache_last_idx is
5825 always valid if bidi_cache_idx is valid.
5826 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
5827 is valid if it's going to be used.
5828 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
5829 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
5830 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5831 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
5832 (bidi_find_other_level_edge, bidi_cache_start_stack):
5833 All variables related to cache indices are now EMACS_INT.
c965adc5 5834
0bb23927
EZ
5835 * dispextern.h (struct bidi_string_data): New structure.
5836 (struct bidi_it): New member `string'. Make flag members be 1-bit
5837 fields, and put them last in the struct.
640c8776
SM
5838 (compute_display_string_pos, compute_display_string_end):
5839 Update prototypes.
0bb23927
EZ
5840 (bidi_push_it, bidi_pop_it): Add prototypes.
5841 (struct iterator_stack_entry): New members bidi_p,
5842 paragraph_embedding, and from_disp_prop_p.
5843 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
5844 (bidi_shelve_cache, bidi_unshelve_cache):
5845 Declare prototypes.
0bb23927
EZ
5846
5847 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
5848 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
5849 and vector-like objects.
5850
5851 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
5852 cache around display iteration.
5853
5854 * window.c (Fwindow_end, window_scroll_pixel_based)
5855 (displayed_window_lines, Frecenter): Save and restore the bidi
5856 cache around display iteration.
5857
3bbd2265
LMI
58582011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5859
5860 * editfns.c (Fdelete_region): Clarify the use of the named
5861 parameters (bug#6788).
5862
adc47434
MR
58632011-07-14 Martin Rudalics <rudalics@gmx.at>
5864
5865 * indent.c (Fvertical_motion): Set and restore w->pointm when
5866 saving and restoring the window's buffer (Bug#9006).
5867
837c31f8
LMI
58682011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
5869
5870 * editfns.c (Fstring_to_char): Clarify just what is returned
5871 (bug#6576). Text by Eli Zaretskii.
5872
ac389d0c
JB
58732011-07-13 Juanma Barranquero <lekktu@gmail.com>
5874
5875 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
5876
0be0ce47
EZ
58772011-07-13 Eli Zaretskii <eliz@gnu.org>
5878
5879 * buffer.c (mmap_find): Fix a typo.
5880
cd18e7e3
JB
58812011-07-13 Johan Bockgård <bojohan@gnu.org>
5882
5883 Fix execution of x selection hooks.
5884 * xselect.c (Qx_lost_selection_functions)
5885 (Qx_sent_selection_functions): New vars.
5886 (syms_of_xselect): DEFSYM them.
5887 (x_handle_selection_request): Pass Qx_sent_selection_functions
5888 rather than Vx_sent_selection_functions to Frun_hook_with_args.
5889 (x_handle_selection_clear,x_clear_frame_selections):
5890 Pass Qx_lost_selection_functions rather than
5891 Vx_lost_selection_functions to Frun_hook_with_args.
5892
47ea7f44
PE
58932011-07-13 Paul Eggert <eggert@cs.ucla.edu>
5894
ac389d0c 5895 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
5896 The old code sometimes used this field without initializing it.
5897
47ea7f44
PE
5898 * alloc.c (gc_sweep): Don't read past end of array.
5899 In theory, the old code could also have corrupted Emacs internals,
5900 though it'd be very unlikely.
5901
bc985c87
AS
59022011-07-12 Andreas Schwab <schwab@linux-m68k.org>
5903
5904 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 5905 argument. (Bug#4026)
bc985c87 5906
0cf34688
LMI
59072011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
5908
b3dadd76
LMI
5909 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
5910 key" (bug#4257).
5911
0cf34688
LMI
5912 * window.c (Fset_window_start): Doc fix (bug#4199).
5913 (Fset_window_hscroll): Ditto.
5914
270768cd
PE
59152011-07-12 Paul Eggert <eggert@cs.ucla.edu>
5916
077e3dda 5917 Fix minor new problems caught by GCC 4.6.1.
270768cd 5918 * term.c (init_tty): Remove unused local.
490011a6 5919 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 5920 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 5921 not used otherwise.
270768cd 5922
b1f58454
CY
59232011-07-12 Chong Yidong <cyd@stupidchicken.com>
5924
5925 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
5926
22b9578d
LMI
59272011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5928
6e70ab07
LMI
5929 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
5930 are the mini-buffer and the echo area (bug#3320).
5931
22b9578d
LMI
5932 * term.c (init_tty): Remove support for supdup, c10 and perq
5933 terminals, which are no longer supported (bug#1482).
5934
8974cc9f
JB
59352011-07-10 Johan Bockgård <bojohan@gnu.org>
5936
5937 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
5938
a560d974
JD
59392011-07-10 Jan Djärv <jan.h.d@swipnet.se>
5940
5941 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
5942 for non-popups (Bug#3642).
5943
1dae0f0a
AS
59442011-07-10 Andreas Schwab <schwab@linux-m68k.org>
5945
268c2c36 5946 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 5947 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
5948 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
5949 * cm.c (losecursor): Likewise.
1dae0f0a
AS
5950 * data.c (fmod): Likewise.
5951 * dispnew.c (swap_glyphs_in_rows): Likewise.
5952 * emacs.c (memory_warning_signal): Likewise.
5953 * floatfns.c (float_error): Likewise.
5954 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
5955 (otf_open, font_otf_capability, generate_otf_features)
5956 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
5957 Likewise.
5958 * image.c (pbm_read_file): Likewise.
5959 * indent.c (string_display_width): Likewise.
5960 * intervals.c (check_for_interval, search_for_interval)
5961 (inc_interval_count, count_intervals, root_interval)
5962 (adjust_intervals_for_insertion, make_new_interval): Likewise.
5963 * lread.c (defalias): Likewise.
268c2c36 5964 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
5965 * regex.c (set_image_of_range_1, set_image_of_range)
5966 (regex_grow_registers): Likewise.
5967 * sysdep.c (strerror): Likewise.
5968 * termcap.c (valid_filename_p, tprint, main): Likewise.
5969 * tparam.c (main): Likewise.
5970 * unexhp9k800.c (run_time_remap, save_data_space)
5971 (update_file_ptrs, read_header, write_header, calculate_checksum)
5972 (copy_file, copy_rest, display_header): Likewise.
5973 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
5974 Likewise.
5975 * xdisp.c (check_it): Likewise.
5976 * xfaces.c (register_color, unregister_color, unregister_colors):
5977 Likewise.
5978 * xfns.c (print_fontset_result): Likewise.
5979 * xrdb.c (member, fatal, main): Likewise.
5980
99033785
PE
59812011-07-10 Paul Eggert <eggert@cs.ucla.edu>
5982
5983 Fix minor problems found by static checking (Bug#9031).
5984 * chartab.c (char_table_set_range, map_sub_char_table):
5985 Remove unused locals.
5986 (uniprop_table): Now static.
5987 * composite.c (_work_char): Remove unused static var.
5988
9cb2ac56
JB
59892011-07-09 Juanma Barranquero <lekktu@gmail.com>
5990
5991 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
5992
f25661f0
JD
59932011-07-09 Jan Djärv <jan.h.d@swipnet.se>
5994
5995 * gtkutil.c (qttip_cb): Remove code without function.
5996
8278c4fe
EZ
59972011-07-09 Eli Zaretskii <eliz@gnu.org>
5998
5999 * w32.c (pthread_sigmask): New stub.
6000
1692ae2d 60012011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 6002
8a6ebd58 6003 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
6004 sigprocmask is portable only for single-threaded applications, and
6005 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
6006 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
6007 (LIBES): Use it.
6008 * callproc.c (Fcall_process):
6009 * process.c (create_process):
6010 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
6011 Use pthread_sigmask, not sigprocmask.
123403e4 6012
1b854618
JD
60132011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6014
6015 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
6016 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
6017 wrong (Bug#8591).
6018
3fe4b549
JD
60192011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6020
0ce7e563
JD
6021 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
6022 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
6023 (xg_hide_tooltip): Fix comment.
6024
3fe4b549
JD
6025 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
6026 in registerServicesMenuSendTypes.
6027 (validRequestorForSendType): Don't check ns_return_types.
6028
6029 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
6030 ns_return_type.
6031
5df75e47
JR
60322011-07-08 Jason Rumney <jasonr@gnu.org>
6033
22610910
JR
6034 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
6035 SH_SHOW for hidden windows (Bug#5482).
6036
5df75e47
JR
6037 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
6038 frame struct members of non-existent frames (Bug#6284).
6039
699c10bd
JD
60402011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6041
4393663b
JD
6042 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
6043 variable firstTime not needed on OSX >= 10.6.
6044 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
6045 >= 10.5. Use setKnobProportion, setDoubleValue.
6046
6047 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
6048 (MAC_OS_X_VERSION_10_5): Define if not defined.
6049 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
6050 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
6051 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
6052
6053 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
6054 cString and lossyCString on OSX >= 10.4
6055
58179cce 6056 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
6057 sizeToFit on OSX >= 10.2.
6058
6059 * nsimage.m (allocInitFromFile): Don't use deprecated method
6060 bestRepresentationForDevice on OSX >= 10.6.
6061
6062 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
6063 to avoid warning.
6064
6065 * emacs.c: Declare unexec_init_emacs_zone.
6066
a63e0781
JD
6067 * nsgui.h: Fix compiler warning about gnulib redefining verify.
6068
699c10bd
JD
6069 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
6070
6071 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
6072 on svcsMenu (Bug#8842).
6073
6074 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
6075 ns_return_types.
6076 (Fns_list_services): Just return Qnil on 10.6, code not working there.
6077
6078 * nsterm.m (QUTF8_STRING): Declare.
6079 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
6080 (validRequestorForSendType): Return type is (id).
6081 Change indexOfObjectIdenticalTo to indexOfObject.
6082 Check if we have local selection before returning self (Bug#8842).
6083 (writeSelectionToPasteboard): Put local selection into paste board
6084 if we have a local selection (Bug#8842).
6085 (syms_of_nsterm): DEFSYM QUTF8_STRING.
6086
6087 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
6088 (ns_get_local_selection): Declare.
6089
54e10184
LMI
60902011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
6091
9888ff71
LMI
6092 * keymap.c (describe_map_tree): Don't insert a double newline at
6093 the end of the buffer (bug#1169) and return whether we inserted
6094 something.
6095
54e10184
LMI
6096 * callint.c (Fcall_interactively): Change "reading args" to
6097 "providing args" to try to clarify what it does (bug#1010).
6098
15fa4783
KH
60992011-07-07 Kenichi Handa <handa@m17n.org>
6100
6101 * composite.c (composition_compute_stop_pos): Ignore a static
6102 composition starting before CHARPOS (Bug#8915).
6103
6104 * xdisp.c (handle_composition_prop): Likewise.
6105
a8815b00
EZ
61062011-07-07 Eli Zaretskii <eliz@gnu.org>
6107
6108 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
6109 (Bug#9015)
6110
ef7b981d 61112011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
6112
6113 * character.h (unicode_category_t): New enum type.
6114
6115 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
6116 (Qchar_code_property_table): New variable.
6117 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
6118 (UNIPROP_COMPRESSED_FORM_P): New macros.
6119 (char_table_ascii): Uncompress the compressed values.
6120 (sub_char_table_ref): New arg is_uniprop. Callers changed.
6121 Uncompress the compressed values.
ac389d0c 6122 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
6123 (char_table_ref_and_range): Uncompress the compressed values.
6124 (sub_char_table_set): New arg is_uniprop. Callers changed.
6125 Uncompress the compressed values.
6126 (sub_char_table_set_range): Args changed. Callers changed.
6127 (char_table_set_range): Adjuted for the above change.
6128 (map_sub_char_table): Delete args default_val and parent. Add arg
6129 top. Give decoded values to a Lisp function.
640c8776 6130 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
6131 values to a Lisp function. Gcpro more variables.
6132 (uniprop_table_uncompress)
6133 (uniprop_decode_value_run_length): New functions.
6134 (uniprop_decoder, uniprop_decoder_count): New variables.
6135 (uniprop_get_decoder, uniprop_encode_value_character)
6136 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
6137 New functions.
6138 (uniprop_encoder, uniprop_encoder_count): New variables.
6139 (uniprop_get_encoder, uniprop_table)
6140 (Funicode_property_table_internal, Fget_unicode_property_internal)
6141 (Fput_unicode_property_internal): New functions.
6142 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
6143 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 6144 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
6145 char-code-property-alist.
6146
640c8776 6147 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
6148 Vunicode_category_table.
6149
640c8776 6150 * font.c (font_range): Adjust for the change of
c805dec0
KH
6151 Vunicode_category_table.
6152
76b397fb
DN
61532011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
6154
6155 * m/iris4d.h: Remove file, move contents ...
6156 * s/irix6-5.h: ... here.
6157
22b4128e
PE
61582011-07-06 Paul Eggert <eggert@cs.ucla.edu>
6159
6160 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
6161 * alloc.c (mark_buffer):
6162 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
6163 (clone_per_buffer_values): Don't assume that
22b4128e
PE
6164 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
6165 This isn't true in general, and it's particularly not true
6166 if Emacs is configured with --with-wide-int.
6167 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
6168 New macros, used in the buffer.c change.
6169
869795d6
JD
61702011-07-05 Jan Djärv <jan.h.d@swipnet.se>
6171
6172 * xsettings.c: Use both GConf and GSettings if both are available.
6173 (store_config_changed_event): Add comment.
6174 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
6175 (store_tool_bar_style_changed): New functions.
5e617bc2 6176 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
6177 (struct xsettings): Move font inside HAVE_XFT.
6178 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 6179 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 6180 Move inside HAVE_XFT.
640c8776 6181 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
6182 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
6183 also.
6184 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 6185 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 6186 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
6187 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
6188 (parse_settings): Move check for font inside HAVE_XFT.
6189 (read_settings, apply_xft_settings): Add comment.
6190 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
6191 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
6192 call store_font_name_changed.
6193 (xft_settings_event): Add comment.
6194 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
6195 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
6196 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
6197 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
6198 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
6199 (xsettings_get_system_font, xsettings_get_system_normal_font):
6200 Add comment.
869795d6 6201
d8ed26bd
PE
62022011-07-05 Paul Eggert <eggert@cs.ucla.edu>
6203
6204 Random fixes. E.g., (random) never returned negative values.
6205 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
6206 subseconds part to the entropy, as that's a bit more random.
6207 Prefer signed to unsigned, since the signedness doesn't matter and
6208 in general we prefer signed. When given a limit, use a
6209 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
6210 latter isn't right if USE_2_TAGS_FOR_INTS.
6211 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
6212 not 0..VALMASK. Don't discard "excess" bits that random () returns.
6213
cabf1cac
SM
62142011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
6215
6216 * textprop.c (text_property_stickiness):
6217 Obey Vtext_property_default_nonsticky.
6218 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
6219 * w32fns.c (syms_of_w32fns):
6220 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
6221
6e9b2be9
PE
62222011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6223
6224 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
6225 This is more efficient than Ffile_directory_p and avoids a minor race.
6226
90186c68
LMI
62272011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
6228
7c301272
LMI
6229 * buffer.c (Foverlay_put): Say what the return value is
6230 (bug#7835).
6231
c4f2d8d4
LMI
6232 * fileio.c (barf_or_query_if_file_exists): Check first if the file
6233 is a directory before asking whether to use the file name
6234 (bug#7564).
ad637907
LMI
6235 (barf_or_query_if_file_exists): Make the "File is a directory"
6236 error be more correct.
c4f2d8d4 6237
90186c68
LMI
6238 * fns.c (Frequire): Remove the mention of the .gz files, since
6239 that's installation-specific, but keep the mention of
6240 `get-load-suffixes'.
6241
da64016e
PE
62422011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6243
6244 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
6245 Report string overflow if the output is too long.
6246
7d47b580
JB
62472011-07-04 Juanma Barranquero <lekktu@gmail.com>
6248
a555cb87
JB
6249 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
6250 (syms_of_gnutls): Remove duplicate DEFSYM for
6251 Qgnutls_bootprop_verify_hostname_error, an error for
6252 Qgnutls_bootprop_verify_error (which is no longer used).
6253
7d47b580
JB
6254 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
6255 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
6256 Also (re)move comments that are misplaced or no longer relevant.
6257
1e49bfab
LMI
62582011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6259
6260 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
6261
1485f4c0
CY
62622011-07-03 Chong Yidong <cyd@stupidchicken.com>
6263
6264 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
6265 and background color parameters if they have been changed.
6266
a9ab721e
LMI
62672011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6268
6269 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
6270
cf7cff57
PE
62712011-07-03 Paul Eggert <eggert@cs.ucla.edu>
6272
2e13213d
PE
6273 * xsettings.c (SYSTEM_FONT): Define only when used.
6274 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
6275
cf7cff57
PE
6276 * keymap.c (access_keymap_1): Now static.
6277
7a8e04f7
CY
62782011-07-02 Chong Yidong <cyd@stupidchicken.com>
6279
6280 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
6281 leave any prefix arg for the up event (Bug#1586).
6282
61352f62
LMI
62832011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
6284
69bb1ef7
LMI
6285 * lread.c (syms_of_lread): Mention single symbols defined by
6286 `defvar' or `defconst' (bug#7154).
6287
61352f62 6288 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 6289 (Frequire): Mention get-load-suffixes.
61352f62 6290
28545e04
MR
62912011-07-02 Martin Rudalics <rudalics@gmx.at>
6292
6293 * window.h (window): Remove clone_number slot.
6294 * window.c (Fwindow_clone_number, Fset_window_clone_number):
6295 Remove.
6296 (make_parent_window, make_window, saved_window)
6297 (Fset_window_configuration, save_window_save): Don't deal with
6298 clone numbers.
6299 * buffer.c (Qclone_number): Remove declaration.
6300 (sort_overlays, overlay_strings): Don't deal with clone numbers.
6301
3349e122
SM
63022011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
6303
6304 Add multiple inheritance to keymaps.
6305 * keymap.c (Fmake_composed_keymap): New function.
6306 (Fset_keymap_parent): Simplify.
6307 (fix_submap_inheritance): Remove.
6308 (access_keymap_1): New function extracted from access_keymap to handle
6309 embedded parents and handle lists of maps.
6310 (access_keymap): Use it.
6311 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
6312 (Fcopy_keymap): Handle embedded parents.
6313 (Fcommand_remapping, define_as_prefix): Simplify.
6314 (Fkey_binding): Simplify.
6315 (syms_of_keymap): Move minibuffer-local-completion-map,
6316 minibuffer-local-filename-completion-map,
6317 minibuffer-local-must-match-map, and
6318 minibuffer-local-filename-must-match-map to Elisp.
6319 (syms_of_keymap): Defsubr make-composed-keymap.
6320 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
6321 (parse_menu_item): Trivial simplification.
6322
3279eb87
GM
63232011-07-01 Glenn Morris <rgm@gnu.org>
6324
6325 * Makefile.in (SETTINGS_LIBS): Fix typo.
6326
4550efdf
KI
63272011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
6328
6329 * coding.c (Fencode_coding_string): Record the last coding system
6330 used, as the function doc string says (bug#8738).
6331
0949d2b6
JD
63322011-07-01 Jan Djärv <jan.h.d@swipnet.se>
6333
6334 * xsettings.c (store_monospaced_changed): Take new font as arg and
6335 check for change against current_mono_font.
6336 (EMACS_TYPE_SETTINGS): Remove this and related defines.
6337 (emacs_settings_constructor, emacs_settings_get_property)
6338 (emacs_settings_set_property, emacs_settings_class_init)
6339 (emacs_settings_init, gsettings_obj): Remove.
6340 (something_changedCB): New function for HAVE_GSETTINGS.
6341 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
6342 with value as argument.
6343 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
6344 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 6345 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
6346 "changed".
6347
6348 * xgselect.c: Add defined (HAVE_GSETTINGS).
6349 (xgselect_initialize): Ditto.
6350
6351 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
6352 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
6353 xg_select.
6354
bbc6b304
PE
63552011-07-01 Paul Eggert <eggert@cs.ucla.edu>
6356
6357 * eval.c (struct backtrace): Simplify and port the data structure.
6358 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
6359 signed bit field, as this assumption is not portable and it makes
6360 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
6361 "char debug_on_exit : 1" as this is not portable either; instead,
6362 use the portable "unsigned int debug_on_exit : 1". Remove unused
6363 member evalargs. Remove obsolete comments about cc bombing out.
6364
9851bfc5
JD
63652011-06-30 Jan Djärv <jan.h.d@swipnet.se>
6366
51bb811f 6367 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
6368 Let HAVE_GSETTINGS override HAVE_GCONF.
6369 (store_monospaced_changed): New function.
6370 (EMACS_SETTINGS): A new type derived from GObject to handle
6371 GSettings notifications.
6372 (emacs_settings_constructor, emacs_settings_get_property)
6373 (emacs_settings_set_property, emacs_settings_class_init):
6374 New functions.
6375 (gsettings_client, gsettings_obj): New variables.
6376 (GSETTINGS_SCHEMA): New define.
6377 (something_changedCB): Call store_monospaced_changed.
6378 (init_gsettings): New function.
6379 (xsettings_initialize): Call init_gsettings.
6380 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
6381 to NULL.
6382
640c8776 6383 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
6384 GCONF_CFLAGS/LIBS.
6385
5386012d
MR
63862011-06-29 Martin Rudalics <rudalics@gmx.at>
6387
6388 * window.c (resize_root_window, grow_mini_window)
6389 (shrink_mini_window): Rename Qresize_root_window to
6390 Qwindow_resize_root_window and Qresize_root_window_vertically to
6391 Qwindow_resize_root_window_vertically.
6392
f13e0b08
PE
63932011-06-28 Paul Eggert <eggert@cs.ucla.edu>
6394
6395 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
6396
94515237
JB
63972011-06-27 Juanma Barranquero <lekktu@gmail.com>
6398
6399 * makefile.w32-in: Redesign dependencies so they reflect more
6400 clearly which files are directly included by each source file,
6401 and not through other includes.
6402
e43b6e43
MR
64032011-06-27 Martin Rudalics <rudalics@gmx.at>
6404
6405 * buffer.c (Qclone_number): Declare static and DEFSYM it.
6406 (sort_overlays, overlay_strings): When an overlay's clone number
6407 matches the window's clone number process the overlay even if
6408 the overlay's window property doesn't match the current window.
6409
d68443dc
MR
6410 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
6411 (Fwindow_hchild): Rename to Fwindow_left_child.
6412 (Fwindow_next): Rename to Fwindow_next_sibling.
6413 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
6414 (resize_window_check): Rename to window_resize_check.
6415 (resize_window_apply): Rename to window_resize_apply.
6416 (Fresize_window_apply): Rename to Fwindow_resize_apply.
6417 (Fdelete_other_windows_internal, resize_frame_windows)
6418 (Fsplit_window_internal, Fdelete_window_internal)
6419 (grow_mini_window, shrink_mini_window)
6420 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 6421
c7e73be5
JD
64222011-06-26 Jan Djärv <jan.h.d@swipnet.se>
6423
6424 * emacsgtkfixed.h: State that this is only used with Gtk+3.
6425 (emacs_fixed_set_min_size): Remove.
6426 (emacs_fixed_new): Take frame as argument.
6427
6428 * emacsgtkfixed.c: State that this is only used with Gtk+3.
6429 (_EmacsFixedPrivate): Remove minwidth/height.
6430 Add struct frame *f.
6431 (emacs_fixed_init): Initialize priv->f.
6432 (get_parent_class, emacs_fixed_set_min_size): Remove.
6433 (emacs_fixed_new): Set priv->f to argument.
6434 (emacs_fixed_get_preferred_width)
6435 (emacs_fixed_get_preferred_height): Use min_width/height from
6436 frames size_hint to set minimum and natural (Bug#8919).
6437 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
6438 and use min_width/height from frames size_hint to set
6439 min_width/height (Bug#8919).
6440
6441 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
6442 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
6443 Fix indentation.
c7e73be5 6444
cf99dcf8
EZ
64452011-06-26 Eli Zaretskii <eliz@gnu.org>
6446
6447 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
6448 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
6449 called at ZV.
6450
029529ac
CY
64512011-06-26 Chong Yidong <cyd@stupidchicken.com>
6452
6453 * process.c (wait_reading_process_output): Bypass select if
6454 waiting for a cell while ignoring keyboard input, and input is
6455 pending. Suggested by Jan Djärv (Bug#8869).
6456
7a7ef429
PE
64572011-06-25 Paul Eggert <eggert@cs.ucla.edu>
6458
6459 Use gnulib's dup2 module instead of rolling our own.
6460 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
6461
11fdef7d 64622011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
6463
6464 * dispnew.c (scrolling_window): Before scrolling, turn off a
6465 mouse-highlight in the window being scrolled.
6466
cd3520a4
JB
64672011-06-24 Juanma Barranquero <lekktu@gmail.com>
6468
6469 Move DEFSYM to lisp.h and use everywhere.
6470
6471 * character.h (DEFSYM): Move declaration...
6472 * lisp.h (DEFSYM): ...here.
6473
6474 * gnutls.c:
6475 * minibuf.c:
6476 * w32menu.c:
6477 * w32proc.c:
6478 * w32select.c: Don't include character.h.
6479
6480 * alloc.c (syms_of_alloc):
6481 * buffer.c (syms_of_buffer):
6482 * bytecode.c (syms_of_bytecode):
6483 * callint.c (syms_of_callint):
6484 * casefiddle.c (syms_of_casefiddle):
6485 * casetab.c (init_casetab_once):
6486 * category.c (init_category_once, syms_of_category):
6487 * ccl.c (syms_of_ccl):
6488 * cmds.c (syms_of_cmds):
6489 * composite.c (syms_of_composite):
6490 * dbusbind.c (syms_of_dbusbind):
6491 * dired.c (syms_of_dired):
6492 * dispnew.c (syms_of_display):
6493 * doc.c (syms_of_doc):
6494 * editfns.c (syms_of_editfns):
6495 * emacs.c (syms_of_emacs):
6496 * eval.c (syms_of_eval):
6497 * fileio.c (syms_of_fileio):
6498 * fns.c (syms_of_fns):
6499 * frame.c (syms_of_frame):
6500 * fringe.c (syms_of_fringe):
6501 * insdel.c (syms_of_insdel):
6502 * keymap.c (syms_of_keymap):
6503 * lread.c (init_obarray, syms_of_lread):
6504 * macros.c (syms_of_macros):
6505 * msdos.c (syms_of_msdos):
6506 * print.c (syms_of_print):
6507 * process.c (syms_of_process):
6508 * search.c (syms_of_search):
6509 * sound.c (syms_of_sound):
6510 * syntax.c (init_syntax_once, syms_of_syntax):
6511 * terminal.c (syms_of_terminal):
6512 * textprop.c (syms_of_textprop):
6513 * undo.c (syms_of_undo):
6514 * w32.c (globals_of_w32):
6515 * window.c (syms_of_window):
6516 * xdisp.c (syms_of_xdisp):
6517 * xfaces.c (syms_of_xfaces):
6518 * xfns.c (syms_of_xfns):
6519 * xmenu.c (syms_of_xmenu):
6520 * xsettings.c (syms_of_xsettings):
6521 * xterm.c (syms_of_xterm): Use DEFSYM.
6522
4228cf16
TZ
65232011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
6524
cd3520a4 6525 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 6526
7fcccf1e
PE
65272011-06-23 Paul Eggert <eggert@cs.ucla.edu>
6528
7efb4e0e
PE
6529 Integer and buffer overflow fixes (Bug#8873).
6530
ff5844ad
PE
6531 * print.c (printchar, strout): Check for string overflow.
6532 (PRINTPREPARE, printchar, strout):
6533 Don't set size unless allocation succeeds.
6534
90532f02
PE
6535 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
6536 for sizes. Check for string overflow more accurately.
6537 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
6538
6d84508d
PE
6539 * macros.c: Integer and buffer overflow fixes.
6540 * keyboard.h (struct keyboard.kbd_macro_bufsize):
6541 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
6542 Use ptrdiff_t, not int, for sizes.
6543 Don't increment bufsize until after realloc succeeds.
6544 Check for size-calculation overflow.
6545 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
6546
437b2cb4
PE
6547 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
6548
8b9ac8b4
PE
6549 * lread.c: Integer overflow fixes.
6550 (read_integer): Radix is now EMACS_INT, not int,
6551 to improve quality of diagnostics for out-of-range radices.
6552 Calculate buffer size correctly for out-of-range radices.
6553 (read1): Check for integer overflow in radices, and in
6554 read-circle numbers.
82cb60d3
PE
6555 (read_escape): Avoid int overflow.
6556 (Fload, openp, read_buffer_size, read1)
6557 (substitute_object_recurse, read_vector, read_list, map_obarray):
6558 Use ptrdiff_t, not int, for sizes.
6559 (read1): Use EMACS_INT, not int, for sizes.
20270765 6560 Check for size overflow.
8b9ac8b4 6561
7fcccf1e
PE
6562 * image.c (cache_image): Check for size arithmetic overflow.
6563
bfbbd7e7
PE
6564 * lread.c: Integer overflow issues.
6565 (saved_doc_string_size, saved_doc_string_length)
6566 (prev_saved_doc_string_size, prev_saved_doc_string_length):
6567 Now ptrdiff_t, not int.
6568 (read1): Don't assume doc string length fits in int. Check for
6569 out-of-range doc string lengths.
6570 (read_list): Don't assume file position fits in int.
39019e54 6571 (read_escape): Check for hex character overflow.
bfbbd7e7 6572
4e323265
LL
65732011-06-22 Leo Liu <sdl.web@gmail.com>
6574
6575 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
6576 Move to minibuffer.el.
6577
85fece3e
PE
65782011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6579
20b84ce9 6580 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
6581 The following patches are for when GLYPH_DEBUG && !XASSERT.
6582 * dispextern.h (trace_redisplay_p, dump_glyph_string):
6583 * dispnew.c (flush_stdout):
6584 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
6585 Mark as externally visible.
6586 * dispnew.c (check_window_matrix_pointers): Now static.
6587 * dispnew.c (window_to_frame_vpos):
6588 * xfns.c (unwind_create_frame):
6589 * xterm.c (x_check_font): Remove unused local.
6590 * scroll.c (CHECK_BOUNDS):
6591 * xfaces.c (cache_fache): Rename local to avoid shadowing.
6592 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
6593 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
6594 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
6595 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
6596 Now static.
6597 (debug_method_add): Use va_list and vsprintf rather than relying
6598 on undefined behavior with wrong number of arguments.
6599 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
6600 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
6601 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
6602 since we're not interested in debugging glyphs with old libraries.
6603 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
6604 GCC 4.6.0's static checking.
6605
0766b489
PE
66062011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6607
31fd4b32
PE
6608 Integer overflow and signedness fixes (Bug#8873).
6609 A few related buffer overrun fixes, too.
6610
b79e8648
PE
6611 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
6612
0766b489
PE
6613 * dispextern.h (struct face.stipple):
6614 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
6615 (x_bitmap_mask, x_allocate_bitmap_record)
6616 (x_create_bitmap_from_data, x_create_bitmap_from_file)
6617 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
6618 (x_create_bitmap_from_xpm_data):
6619 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
6620 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
6621 (.bitmaps_last):
6622 * xfaces.c (load_pixmap):
6623 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
6624 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
6625 (.bitmaps_last, struct x_output.icon_bitmap):
6626 Use ptrdiff_t, not int, for bitmap indexes.
6627 (x_allocate_bitmap_record): Check for size overflow.
6628 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
6629
b081724f
PE
6630 Use ptrdiff_t, not int, for overlay counts.
6631 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
6632 * editfns.c (overlays_around, get_pos_property):
6633 * textprop.c (get_char_property_and_overlay):
6634 * xdisp.c (next_overlay_change, note_mouse_highlight):
6635 * xfaces.c (face_at_buffer_position):
21514da7
PE
6636 * buffer.c (OVERLAY_COUNT_MAX): New macro.
6637 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
6638 (Fnext_overlay_change, Fprevious_overlay_change)
6639 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 6640 Use ptrdiff_t, not int, for sizes.
21514da7 6641 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 6642
3de73e5e
PE
6643 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
6644
2606c57b
PE
6645 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
6646 (x_session_initialize): Do not assume string length fits in int.
6647
aaafe47a
PE
6648 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
6649 This is unlikely, but can occur if DPI is outlandish.
6650
2674ddc8 6651 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
6652 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
6653
28154962
PE
6654 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
6655 * xrdb.c (magic_file_p, search_magic_path):
6656 Omit last arg SUFFIX; it was always 0. All callers changed.
6657 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
6658
7de51af5
PE
6659 * xfont.c (xfont_match): Avoid need for strlen.
6660
25ed6cc3
PE
6661 * xfns.c: Don't assume strlen fits in int.
6662 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
6663
4eab31dd
PE
6664 * xdisp.c (message_log_check_duplicate): Return intmax_t,
6665 not unsigned long, as we prefer signed integers. All callers changed.
6666 Detect integer overflow in repeat count.
6667 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 6668 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 6669
171e2a58
PE
6670 * termcap.c: Don't assume sizes fit in int and never overflow.
6671 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
6672 (gobble_line): Check for size-calculation overflow.
6673
ad39faca 6674 * minibuf.c (Fread_buffer):
6e5bb2dc 6675 * lread.c (intern, intern_c_string):
74ca2eb3
PE
6676 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
6677 Don't assume string length fits in int.
6678
52c61c22 6679 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
6680 * gtkutil.c (style_changed_cb): Avoid need for strlen.
6681
b5b8c9e5
PE
6682 * font.c: Don't assume string length fits in int.
6683 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
6684 Use ptrdiff_t, not int.
ccd6111c
PE
6685 (font_intern_prop): Don't assume string length fits in int.
6686 Don't assume integer property fits in fixnum.
6687 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 6688
882f0d81 6689 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 6690 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
6691 Reformulate so as not to need the command string.
6692 Invoke gzip -cd rather than gunzip, as it's more portable.
6693 (lock_info_type, lock_file_1, lock_file):
6694 Don't assume pid_t and time_t fit in unsigned long.
6695 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
6696 (current_lock_owner): Prefer signed type for sizes.
6697 Use memcpy, not strncpy, where memcpy is what is really wanted.
6698 Don't assume (via atoi) that time_t and pid_t fit in int.
6699 Check for time_t and/or pid_t out of range, e.g., via a network share.
6700 Don't alloca where an auto var works fine.
6701
93f4cf88
PE
6702 * fileio.c: Fix some integer overflow issues.
6703 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
6704 Don't assume string length fits in int.
6705 (directory_file_name): Don't assume string length fits in long.
6706 (make_temp_name): Don't assume pid fits in int, or that its print
6707 length is less than 20.
6708
f3e92b69
PE
6709 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
6710
1bfdaf10
PE
6711 * coding.c (make_subsidiaries): Don't assume string length fits in int.
6712
35016e9a
PE
6713 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
6714
3d1e65a1
PE
6715 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
6716 We prefer signed integers, even for size calculations.
6717
0b963a93
PE
6718 * emacs.c: Don't assume string length fits in 'int'.
6719 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
6720 (main): Don't invoke strlen when not needed.
6721
573f4b54
PE
6722 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
6723 (XD_DEBUG_MESSAGE): Don't waste a byte.
6724
989f33ba
PE
6725 * callproc.c (getenv_internal_1, getenv_internal)
6726 (Fgetenv_internal):
965d34eb
PE
6727 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
6728
e4d29b33
PE
6729 * lread.c (invalid_syntax): Omit length argument.
6730 All uses changed. This doesn't fix a bug, but it simplifies the
6731 code away from its former Hollerith-constant appearance, and it's
6732 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 6733 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 6734
eb49b136
PE
6735 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
6736 This didn't break anything, but it didn't help either.
6737 It's confusing to put a bogus integer in a place where the actual
6738 value does not matter.
9f62aeb1 6739 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 6740 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 6741
15375a22
PE
6742 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
6743 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
6744 implementation.
b61cc01c
PE
6745 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
6746 We prefer signed types, and the value cannot exceed the EMACS_INT
6747 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
6748 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
6749 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
6750 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 6751
53b2623d
PE
6752 * indent.c (sane_tab_width): New function.
6753 (current_column, scan_for_column, Findent_to, position_indentation)
6754 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 6755 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 6756
51cab52b 6757 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 6758
f2ed8a70
PE
6759 * lisp.h (lint_assume): New macro.
6760 * composite.c (composition_gstring_put_cache):
6761 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
6762
abe80cc6
PE
6763 * editfns.c, insdel.c:
6764 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 6765
b02c740e
PE
6766 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
6767
ebc96716
PE
6768 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
6769
b4e50fa0 6770 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 6771 Use much-faster test for byte-length change.
311d5d7c 6772 Don't assume string byte-length fits in 'int'.
a4cf38e4 6773 Check that character arg fits in 'int'.
85461888 6774 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 6775
c0c1ee9f
PE
6776 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
6777
a498d7f4
PE
6778 * fns.c (concat): Catch string overflow earlier.
6779 Do not rely on integer wraparound.
6780
51cab52b
PE
6781 * dispextern.h (struct it.overlay_strings_charpos)
6782 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
6783 * xdisp.c (forward_to_next_line_start)
6784 (back_to_previous_visible_line_start)
6785 (reseat_at_next_visible_line_start, next_element_from_buffer):
6786 Don't arbitrarily truncate the value of 'selective' to int.
6787
76031fad
PE
6788 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
6789
5eb55db9
PE
6790 * composite.c: Don't truncate sizes to 'int'.
6791 (composition_gstring_p, composition_reseat_it)
6792 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
6793 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
6794 not EMACS_UINT, for indexes.
5eb55db9 6795
0703a717
PE
6796 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
6797
d6202519
PE
6798 * buffer.c: Include <verify.h>.
6799 (struct sortvec.priority, struct sortstr.priority):
8961a454 6800 Now EMACS_INT, not int.
c20998a7 6801 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
6802 (struct sortstr.size, record_overlay_string)
6803 (struct sortstrlist.size, struct sortlist.used):
6804 Don't truncate size to int.
6805 (record_overlay_string): Check for size-calculation overflow.
d6202519 6806 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 6807
d5a19415
JM
68082011-06-22 Jim Meyering <meyering@redhat.com>
6809
029529ac 6810 Don't leak an XBM-image-sized buffer
d5a19415
JM
6811 * image.c (xbm_load): Free the image buffer after using it.
6812
a9041e6c
PE
68132011-06-21 Paul Eggert <eggert@cs.ucla.edu>
6814
6815 Port to Sun C.
6816 * composite.c (find_automatic_composition): Omit needless 'return 0;'
6817 that Sun C diagnosed.
6818 * fns.c (secure_hash): Fix pointer signedness issue.
6819 * intervals.c (static_offset_intervals): New function.
6820 (offset_intervals): Use it.
6821
7f3f739f
LL
68222011-06-21 Leo Liu <sdl.web@gmail.com>
6823
6824 * deps.mk (fns.o):
6825 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
6826 sha512.h.
6827
6828 * fns.c (secure_hash): Rename from crypto_hash_function and change
6829 the first arg to accept symbols.
5b66d427 6830 (Fsecure_hash): New primitive.
7f3f739f
LL
6831 (syms_of_fns): New symbols.
6832
76147d94
DD
68332011-06-20 Deniz Dogan <deniz@dogan.se>
6834
6835 * process.c (Fset_process_buffer): Clarify return value in
6836 docstring.
6837
7d7d0045
CY
68382011-06-18 Chong Yidong <cyd@stupidchicken.com>
6839
6840 * dispnew.c (add_window_display_history): Use BVAR.
6841
6842 * xdisp.c (debug_method_add): Use BVAR.
6843 (check_window_end, dump_glyph_matrix, dump_glyph)
6844 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
6845
6846 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
6847 Likewise.
6848
6849 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
6850 check till after the cache is created in init_frame_faces.
6851
ff2bc410
SM
68522011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
6853
6854 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
6855
28177add
PE
68562011-06-16 Paul Eggert <eggert@cs.ucla.edu>
6857
dd3482fe
PE
6858 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
6859 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
6860 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
6861
393d71f3 6862 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
6863 * fileio.c (Finsert_file_contents):
6864 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
6865 Remove the old (too-loose) buffer overflow checks.
6866 They weren't needed, since make_gap checks for buffer overflow.
6867 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
6868 The old code merely checked for Emacs fixnum overflow, and relied
6869 on undefined (wraparound) behavior. The new code avoids undefined
6870 behavior, and also checks for ptrdiff_t and/or size_t overflow.
6871
2e6813b0 6872 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
6873 Tune. Don't use wider integers than needed. Don't use alloca.
6874 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 6875
599a9e4f
PE
6876 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
6877
99561444
PE
6878 * insdel.c, lisp.h (buffer_overflow): New function.
6879 (insert_from_buffer_1, replace_range, replace_range_2):
6880 * insdel.c (make_gap_larger):
6881 * editfns.c (Finsert_char):
6882 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
6883
28177add
PE
6884 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
6885
e69dafad
PE
68862011-06-15 Paul Eggert <eggert@cs.ucla.edu>
6887
4baa020d 6888 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 6889
b1c46f02
PE
6890 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
6891 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
6892
e69dafad
PE
6893 * fileio.c: Don't assume EMACS_INT fits in off_t.
6894 (emacs_lseek): New static function.
6895 (Finsert_file_contents, Fwrite_region): Use it.
6896 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
6897
566684ea
PE
6898 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
6899
e6966cd6
PE
6900 * fns.c: Don't overflow int when computing a list length.
6901 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
6902 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
6903 truncation on 64-bit hosts. Check for QUIT every
6904 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
6905 faster and is responsive enough.
6906 (Flength): Report an error instead of overflowing an integer.
6907 (Fsafe_length): Return a float if the value is not representable
6908 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 6909 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 6910 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 6911
dd0b0efb
PE
6912 * alloc.c: Check that resized vectors' lengths fit in fixnums.
6913 (header_size, word_size): New constants.
6914 (allocate_vectorlike): Don't check size overflow here.
6915 (allocate_vector): Check it here instead, since this is the only
6916 caller of allocate_vectorlike that could cause overflow.
6917 Check that the new vector's length is representable as a fixnum.
6918
86fe5cfe
PE
6919 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
6920 The previous code was bogus. For example, next_almost_prime (32)
6921 returned 39, which is undesirable as it is a multiple of 3; and
6922 next_almost_prime (24) returned 25, which is a multiple of 5 so
6923 why was the code bothering to check for multiples of 7?
6924
80e88859
PE
6925 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
6926
4a2f0ad6
PE
6927 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
6928
f66c7cf8
PE
6929 Variadic C functions now count arguments with ptrdiff_t.
6930 This partly undoes my 2011-03-30 change, which replaced int with size_t.
6931 Back then I didn't know that the Emacs coding style prefers signed int.
6932 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
6933 were being counted with int, which may truncate counts on 64-bit
6934 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
6935 * lisp.h (struct Lisp_Subr.function.aMANY)
6936 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
6937 Arg counts are now ptrdiff_t, not size_t.
6938 All variadic functions and their callers changed accordingly.
6939 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
6940 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
6941 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
6942 * callint.c (Fcall_interactively): Check arg count for overflow,
6943 to avoid potential buffer overrun. Use signed char, not 'int',
6944 for 'varies' array, so that we needn't bother to check its size
6945 calculation for overflow.
6946 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
6947 * eval.c (apply_lambda):
6948 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
6949 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
6950 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
6951
a1759b76
PE
6952 * callint.c (Fcall_interactively): Don't use index var as event count.
6953
d96be9fc
PE
6954 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
6955 * mem-limits.h (SIZE): Remove; no longer used.
6956
a690a978 6957 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 6958
578c21e6
PE
6959 Remove unnecessary casts.
6960 * xterm.c (x_term_init):
6961 * xfns.c (x_set_border_pixel):
6962 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
6963 These aren't needed now that we assume ANSI C.
6964
96f53c6c
PE
6965 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
6966 It's more likely to cause problems (due to unsigned overflow)
6967 than to cure them.
6968
83c77d31
PE
6969 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
6970
ee2079f1
PE
6971 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
6972
6da65536
PE
6973 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
6974
7147c4a4
PE
6975 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
6976
193e32d9
PE
6977 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
6978
e5533da6
PE
6979 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
6980
9910e595
PE
6981 GLYPH_CODE_FACE returns EMACS_INT, not int.
6982 * dispextern.h (merge_faces):
6983 * xfaces.c (merge_faces):
01103c44
PE
6984 * xdisp.c (get_next_display_element, next_element_from_display_vector):
6985 Don't assume EMACS_INT fits in int.
9910e595 6986
2638320e
PE
6987 * character.h (CHAR_VALID_P): Remove unused parameter.
6988 * fontset.c, lisp.h, xdisp.c: All uses changed.
6989
045eb8d9
PE
6990 * editfns.c (Ftranslate_region_internal): Omit redundant test.
6991
c1f134b5
PE
6992 * fns.c (concat): Minor tuning based on overflow analysis.
6993 This doesn't fix any bugs. Use int to hold character, instead
6994 of constantly refetching from Emacs object. Use XFASTINT, not
6995 XINT, for value known to be a character. Don't bother comparing
6996 a single byte to 0400, as it's always less.
6997
395fcb93 6998 * floatfns.c (Fexpt):
327eeec8
PE
6999 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
7000
abbd3d23
PE
7001 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
7002 for characters.
7003
684a03ef
PE
7004 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
7005
0fed43f3
PE
7006 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
7007 Without this fix, on a 64-bit host (aset S 0 4294967386) would
7008 incorrectly succeed when S was a string, because 4294967386 was
7009 truncated before it was used.
7010
8fd02eb7
PE
7011 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
7012 Otherwise, an out-of-range integer could cause undefined behavior
7013 on a 64-bit host.
7014
f8c86b69
PE
7015 * composite.c: Use int, not EMACS_INT, for characters.
7016 (fill_gstring_body, composition_compute_stop_pos): Use int, not
7017 EMACS_INT, for values that are known to be in character range.
7018 This doesn't fix any bugs but is the usual style inside Emacs and
7019 may generate better code on 32-bit machines.
7020
34206dd2
PE
7021 Make sure a 64-bit char is never passed to ENCODE_CHAR.
7022 This is for reasons similar to the recent CHAR_STRING fix.
7023 * charset.c (Fencode_char): Check that character arg is actually
7024 a character. Pass an int to ENCODE_CHAR.
7025 * charset.h (ENCODE_CHAR): Verify that the character argument is no
7026 wider than 'int', as a compile-time check to prevent future regressions
7027 in this area.
7028
c5958d4c 7029 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
7030
7031 Make sure a 64-bit char is never passed to CHAR_STRING.
7032 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
7033 by silently ignoring the top 32 bits, allowing some values
7034 that were far too large to be valid characters.
7035 * character.h: Include <verify.h>.
7036 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
7037 arguments are no wider than unsigned, as a compile-time check
7038 to prevent future regressions in this area.
7039 * data.c (Faset):
01103c44 7040 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
7041 (Fsubst_char_in_region):
7042 * fns.c (concat):
7043 * xdisp.c (decode_mode_spec_coding):
7044 Adjust to CHAR_STRING's new requirement.
7045 * editfns.c (Finsert_char, Fsubst_char_in_region):
7046 * fns.c (concat): Check that character args are actually
7047 characters. Without this test, these functions did the wrong
7048 thing with wildly out-of-range values on 64-bit hosts.
7049
d37ca623
PE
7050 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
7051 These casts should not be needed on 32-bit hosts, either.
7052 * keyboard.c (read_char):
7053 * lread.c (Fload): Remove casts to unsigned.
7054
ea204efb
PE
7055 * lisp.h (UNSIGNED_CMP): New macro.
7056 This fixes comparison bugs on 64-bit hosts.
7057 (ASCII_CHAR_P): Use it.
7058 * casefiddle.c (casify_object):
01103c44 7059 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
7060 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
7061 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
7062 * dispextern.h (FACE_FROM_ID):
7063 * keyboard.c (read_char): Use UNSIGNED_CMP.
7064
41cb286c
PE
7065 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
7066 not to EMACS_INT, to avoid GCC warning.
7067
4a1b9832
PE
7068 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
7069
55daad71
PE
7070 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
7071 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
7072 isn't needed on 32-bit machines.
8f95c75c 7073
01103c44
PE
7074 * buffer.c (Fgenerate_new_buffer_name):
7075 Use EMACS_INT for count, not int.
0ceccced 7076 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
7077
7078 * data.c (Qcompiled_function): Now static.
7079
c6f072e7
PE
7080 * window.c (window_body_lines): Now static.
7081
20ce5912
PE
7082 * image.c (gif_load): Rename local to avoid shadowing.
7083
9c4c5f81
PE
7084 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
7085 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
7086 * alloc.c (make_save_value): Integer argument is now of type
7087 ptrdiff_t, not int.
7088 (mark_object): Use ptrdiff_t, not int.
7089 * lisp.h (pD): New macro.
7090 * print.c (print_object): Use it.
7091
c0c5c8ae
PE
7092 * alloc.c: Use EMACS_INT, not int, to count objects.
7093 (total_conses, total_markers, total_symbols, total_vector_size)
7094 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
7095 (total_free_floats, total_floats, total_free_intervals)
7096 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
7097 Now EMACS_INT, not int. All uses changed.
7098 (Fgarbage_collect): Compute overall total using a double, so that
7099 integer overflow is less likely to be a problem. Check for overflow
7100 when converting back to an integer.
5a25e253
PE
7101 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
7102 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
7103 These were 'int' variables that could overflow on 64-bit hosts;
7104 they were never used, so remove them instead of repairing them.
211a0b2a 7105 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
7106 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
7107 Previously, this ceilinged at INT_MAX, but that doesn't work on
7108 64-bit machines.
e46bb31a 7109 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 7110
c78baabf 7111 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 7112 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
7113 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
7114 when a (possibly-narrower) signed value would do just as well.
7115 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 7116
c9d624c6
PE
7117 * alloc.c: Catch some string size overflows that we were missing.
7118 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
7119 for convenience in STRING_BYTES_MAX.
7120 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
7121 The definition here is exact; the one in lisp.h was approximate.
7122 (allocate_string_data): Check for string overflow. This catches
7123 some instances we weren't catching before. Also, it catches
7124 size_t overflow on (unusual) hosts where SIZE_MAX <= min
7125 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
7126 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 7127
c9d624c6
PE
7128 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
7129 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 7130 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 7131
353032ce
PE
7132 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
7133
2bccce07
PE
7134 * alloc.c (Fmake_string): Check for out-of-range init.
7135
0ac30604
SM
71362011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
7137
7138 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
7139
c195f2de
JD
71402011-06-14 Jan Djärv <jan.h.d@swipnet.se>
7141
7142 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
7143 xg_get_default_scrollbar_width.
7144
7145 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
7146 (int_gtk_range_get_value): Move to the scroll bar part of the file.
7147 (style_changed_cb): Call update_theme_scrollbar_width and call
7148 x_set_scroll_bar_default_width and xg_frame_set_char_size for
7149 all frames (Bug#8505).
7150 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
7151 Call gtk_window_set_resizable if HAVE_GTK3.
7152 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
7153 and height if HAVE_GTK3 (Bug#8505).
7154 (scroll_bar_width_for_theme): New variable.
7155 (update_theme_scrollbar_width): New function.
7156 (xg_get_default_scrollbar_width): Move code to
7157 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
7158 (xg_initialize): Call update_theme_scrollbar_width.
7159
7160 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
7161
7162 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
7163
e10ac9f1
MR
71642011-06-12 Martin Rudalics <rudalics@gmx.at>
7165
7166 * frame.c (make_frame): Call other_buffer_safely instead of
7167 other_buffer.
7168
7169 * window.c (temp_output_buffer_show): Call display_buffer with
7170 second argument Vtemp_buffer_show_specifiers and reset latter
7171 immediately after the call.
7172 (Vtemp_buffer_show_specifiers): New variable.
7173 (auto_window_vscroll_p, next_screen_context_lines)
7174 (Vscroll_preserve_screen_position): Remove leading asterisks from
7175 doc-strings.
7176
2d3c217e 71772011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 7178
7b7f97e8 7179 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
7180 * buffer.c (Qclone_number): Remove for now, as it's unused.
7181 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
7182 (record_buffer): Remove unused local.
7183 * frame.c (other_visible_frames, frame_buffer_list): Now static.
7184 (set_frame_buffer_list): Remove; unused.
7185 * frame.h (other_visible_frames): Remove decl.
7186 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
7187 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
7188 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
7189 if HAVE_GPM.
7190 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
7191 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
7192 Define only if HAVE_GPM.
7193 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
7194 (update_hints_inhibit): Remove; never set. All uses removed.
7195 * widgetprv.h (emacsFrameClassRec): Remove decl.
7196 * window.c (delete_deletable_window): Now returns void, since it
7197 wasn't returning anything.
7198 (compare_window_configurations): Remove unused locals.
7199 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
7200 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
7201 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
7202 the same widths as pointers. This follows up on the 2011-05-06 patch.
7203 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
7204 * xterm.h: Likewise.
7205 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
7206
1384b89e
JB
72072011-06-12 Juanma Barranquero <lekktu@gmail.com>
7208
7209 * makefile.w32-in: Update dependencies.
7210 (LISP_H): Add lib/intprops.h.
7211
1100a63c
CY
72122011-06-11 Chong Yidong <cyd@stupidchicken.com>
7213
7214 * image.c (gif_load): Add animation frame delay to the metadata.
7215 (syms_of_image): Use DEFSYM. New symbol `delay'.
7216
6198ccd0
MR
72172011-06-11 Martin Rudalics <rudalics@gmx.at>
7218
7219 * window.c (delete_deletable_window): Re-add.
7220 (Fset_window_configuration): Rewrite to handle dead buffers and
7221 consequently deletable windows.
7222 (window_tree, Fwindow_tree): Remove. Supply functionality in
7223 window.el.
7224 (compare_window_configurations): Simplify code.
7225
b6e3633c
AS
72262011-06-11 Andreas Schwab <schwab@linux-m68k.org>
7227
1ab0dee5
AS
7228 * image.c (imagemagick_load_image): Fix type mismatch.
7229 (Fimagemagick_types): Likewise.
7230
b6e3633c
AS
7231 * window.h (replace_buffer_in_windows): Declare.
7232
9397e56f
MR
72332011-06-11 Martin Rudalics <rudalics@gmx.at>
7234
7235 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
7236 Qclone_number. Remove external declaration of Qdelete_window.
7237 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
7238 code.
640c8776
SM
7239 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
7240 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
7241 (Fother_buffer): Rewrite doc-string. Major rewrite for new
7242 buffer list implementation.
7243 (other_buffer_safely): New function.
7244 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
7245 calls to replace_buffer_in_windows and
7246 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
7247 if allowed.
7248 (record_buffer): Inhibit quitting and rewrite using quittable
7249 functions. Run Qbuffer_list_update_hook if allowed.
7250 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
7251 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
7252 Move switch-to-buffer to window.el.
9397e56f
MR
7253 (bury-buffer): Move to window.el.
7254 (Vbuffer_list_update_hook): New variable.
7255
7256 * lisp.h (other_buffer_safely): Add prototype in buffer.c
7257 section.
7258
7259 * window.h (resize_frame_windows): Move up in code.
7260 (Fwindow_frame): Remove EXFUN.
7261 (replace_buffer_in_all_windows): Remove prototype.
7262 (replace_buffer_in_windows_safely): Add prototype.
7263
7264 * window.c: Declare Qdelete_window static again. Move down
7265 declaration of select_count.
7266 (Fnext_window, Fprevious_window): Rewrite doc-strings.
7267 (Fother_window): Move to window.el.
7268 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
7269 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
7270 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
7271 window.el.
7272 (replace_buffer_in_windows): Implement by calling
7273 Qreplace_buffer_in_windows.
7274 (replace_buffer_in_all_windows): Remove with some functionality
7275 moved into replace_buffer_in_windows_safely.
7276 (replace_buffer_in_windows_safely): New function.
7277 (select_window_norecord, select_frame_norecord): Move in front
7278 of run_window_configuration_change_hook. Remove now obsolete
7279 declarations.
640c8776
SM
7280 (Fset_window_buffer): Rewrite doc-string.
7281 Call Qrecord_window_buffer.
9397e56f
MR
7282 (keys_of_window): Move binding for other-window to window.el.
7283
b50691aa
CY
72842011-06-11 Chong Yidong <cyd@stupidchicken.com>
7285
7286 * dispextern.h (struct image): Replace data member, whose int_val
7287 and ptr_val fields were not used by anything, with a single
7288 lisp_val object.
7289
7290 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
7291 (gif_clear_image, gif_load, imagemagick_load_image)
7292 (gs_clear_image, gs_load): Callers changed.
7293
3f754b86
PE
72942011-06-10 Paul Eggert <eggert@cs.ucla.edu>
7295
cca69397
PE
7296 * buffer.h: Include <time.h>, for time_t.
7297 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
7298
109e28d0
PE
7299 Fix minor problems found by static checking.
7300
60737f02
PE
7301 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
7302
4b66faf3
PE
7303 Make identifiers static if they are not used in other modules.
7304 * data.c (Qcompiled_function, Qframe, Qvector):
7305 * image.c (QimageMagick, Qsvg):
7306 * minibuf.c (Qmetadata):
7307 * window.c (resize_window_check, resize_root_window): Now static.
7308 * window.h (resize_window_check, resize_root_window): Remove decls.
7309
109e28d0
PE
7310 * window.c (window_deletion_count, delete_deletable_window):
7311 Remove; unused.
46a4ce9e
PE
7312 (window_body_lines): Now static.
7313 (Fdelete_other_windows_internal): Mark vars as initialized.
7314 Make sure 'resize_failed' is initialized.
7315 (run_window_configuration_change_hook): Rename local to avoid shadowing.
7316 (resize_window_apply): Remove unused local.
7317 * window.h (delete_deletable_window): Remove decl.
7318
109e28d0 7319 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
7320 (imagemagick_load_image): Fix pointer signedness problem by changing
7321 last arg from unsigned char * to char *. All uses changed.
7322 Also, fix a local for similar reasons.
7323 Remove unused locals. Remove locals to avoid shadowing.
7324 (fn_rsvg_handle_free): Remove; unused.
7325 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 7326 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 7327
3f754b86
PE
7328 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
7329
2547adb1
CY
73302011-06-10 Chong Yidong <cyd@stupidchicken.com>
7331
7332 * image.c (gif_load): Fix omitted cast error introduced by
7333 2011-06-06 change.
7334
2c8e37d4
MR
73352011-06-10 Martin Rudalics <rudalics@gmx.at>
7336
7337 * window.h (resize_proportionally, orig_total_lines)
7338 (orig_top_line): Remove from window structure.
7339 (set_window_height, set_window_width, change_window_heights)
7340 (Fdelete_window): Remove prototypes.
7341 (resize_frame_windows): Remove duplicate declaration.
7342
440a42e3
EZ
73432011-06-10 Eli Zaretskii <eliz@gnu.org>
7344
7345 * window.h (resize_frame_windows, resize_window_check)
7346 (delete_deletable_window, resize_root_window)
7347 (resize_frame_windows): Declare prototypes.
7348
7349 * window.c (resize_window_apply): Make definition be "static" to
7350 match the prototype.
7351
562dd5e9
MR
73522011-06-10 Martin Rudalics <rudalics@gmx.at>
7353
7354 * window.c: Remove declarations of Qwindow_size_fixed,
7355 window_min_size_1, window_min_size_2, window_min_size,
7356 size_window, window_fixed_size_p, enlarge_window, delete_window.
7357 Remove static from declaration of Qdelete_window, it's
7358 temporarily needed by Fbury_buffer.
7359 (replace_window): Don't assign orig_top_line and
7360 orig_total_lines.
7361 (Fdelete_window, delete_window): Remove. Window deletion is
7362 handled by window.el.
640c8776
SM
7363 (window_loop): Remove DELETE_OTHER_WINDOWS case.
7364 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
7365 (Fdelete_other_windows): Remove. Deleting other windows is
7366 handled by window.el.
7367 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
7368 handled in window.el.
7369 (window_min_size_2, window_min_size_1, window_min_size): Remove.
7370 Window minimum sizes are handled in window.el.
7371 (shrink_windows, size_window, set_window_height)
7372 (set_window_width, change_window_heights, window_height)
7373 (window_width, CURBEG, CURSIZE, enlarge_window)
7374 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
7375 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
7376 handled in window.el.
7377 (make_dummy_parent): Rename to make_parent_window and give it a
7378 second argument horflag.
7379 (make_window): Don't set resize_proportionally any more.
7380 (Fsplit_window): Remove. Windows are split in window.el.
7381 (save_restore_action, save_restore_orig_size)
7382 (shrink_window_lowest_first, save_restore_orig_size): Remove.
7383 Resize mini windows in window.el.
7384 (grow_mini_window, shrink_mini_window): Implement by calling
7385 Qresize_root_window_vertically, resize_window_check and
7386 resize_window_apply.
640c8776
SM
7387 (saved_window, Fset_window_configuration, save_window_save):
7388 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
7389 resize_proportionally.
7390 (window_min_height, window_min_width): Move to window.el.
7391 (keys_of_window): Move bindings for delete-other-windows,
7392 split-window, delete-window and enlarge-window to window.el.
7393
7394 * buffer.c: Temporarily extern Qdelete_window.
7395 (Fbury_buffer): Temporarily call Qdelete_window instead of
7396 Fdelete_window (Fbury_buffer will move to window.el soon).
7397
7398 * frame.c (set_menu_bar_lines_1): Remove code handling
7399 orig_top_line and orig_total_lines.
7400
7401 * dispnew.c (adjust_frame_glyphs_initially): Don't use
7402 set_window_height but set heights directly.
7403 (change_frame_size_1): Use resize_frame_windows.
7404
7405 * xdisp.c (init_xdisp): Don't use set_window_height but set
7406 heights directly.
7407
640c8776
SM
7408 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
7409 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
7410 run_window_configuration_change_hook.
7411
7412 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
7413 instead of change_window_heights and run
7414 run_window_configuration_change_hook.
7415
1a13852e
MR
74162011-06-09 Martin Rudalics <rudalics@gmx.at>
7417
7418 * window.c (replace_window): Rename second argument REPLACEMENT to
7419 NEW. New third argument SETFLAG. Rewrite.
7420 (delete_window, make_dummy_parent): Call replace_window with
7421 third argument 1.
7422 (window_list_1): Move down in code.
7423 (run_window_configuration_change_hook): Move set_buffer part
7424 before select_frame_norecord part in order to unwind correctly.
7425 Rename count1 to count.
7426 (recombine_windows, delete_deletable_window, resize_root_window)
7427 (Fdelete_other_windows_internal)
7428 (Frun_window_configuration_change_hook, make_parent_window)
7429 (resize_window_check, resize_window_apply, Fresize_window_apply)
7430 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
7431 (Fdelete_window_internal, Fresize_mini_window_internal):
7432 New functions.
1a13852e
MR
7433 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
7434
f3d1777e
MR
74352011-06-08 Martin Rudalics <rudalics@gmx.at>
7436
496e208e
MR
7437 * window.h (window): Add some new members to window structure -
7438 normal_lines, normal_cols, new_total, new_normal, clone_number,
7439 splits, nest, prev_buffers, next_buffers.
7440 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 7441 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 7442
f3d1777e
MR
7443 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
7444 Remove.
496e208e
MR
7445 (make_dummy_parent): Set new members of windows structure.
7446 (make_window): Move down in code. Handle new members of window
7447 structure.
7448 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
7449 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
7450 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
7451 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
7452 (Fset_window_next_buffers, Fset_window_clone_number):
7453 New functions.
496e208e
MR
7454 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
7455 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
7456 Doc-string fixes.
7457 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
7458 Argument WINDOW can be now internal window too.
7459 (Fwindow_use_time): Move up in code.
7460 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
7461 Rewrite doc-string.
7462 (Fset_window_configuration, saved_window)
7463 (Fcurrent_window_configuration, save_window_save): Handle new
7464 members of window structure.
b9e809c2
MR
7465 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
7466 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
7467 (syms_of_window): New Lisp objects Qrecord_window_buffer,
7468 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
7469 Qget_mru_window, Qresize_root_window,
7470 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
7471 Qauto_buffer_name; staticpro them.
f3d1777e 7472
abde8f8c
MR
74732011-06-07 Martin Rudalics <rudalics@gmx.at>
7474
7475 * window.c (Fwindow_total_size, Fwindow_left_column)
7476 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
7477 (Fwindow_list_1): New functions.
7478 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
7479 (Fwindow_width, Fscroll_left, Fscroll_right):
7480 Use window_body_cols instead of window_box_text_cols.
7481 (delete_window, Fset_window_configuration):
7482 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
7483 (delete_all_subwindows): Take a window as argument and not a
7484 structure. Rewrite.
190b47e6
MR
7485 (window_loop): Remove handling of GET_LRU_WINDOW and
7486 GET_LARGEST_WINDOW.
7487 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
7488
7489 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
7490 window_box_text_cols. delete_all_subwindows now takes a
7491 Lisp_Object as argument.
abde8f8c 7492
640c8776
SM
7493 * indent.c (compute_motion, Fcompute_motion):
7494 Use window_body_cols instead of window_box_text_cols.
abde8f8c 7495
fa8a67e6
MR
7496 * frame.c (delete_frame): Call delete_all_subwindows with root
7497 window as argument.
7498
a54e3482
DC
74992011-06-07 Daniel Colascione <dan.colascione@gmail.com>
7500
7501 * fns.c (Fputhash): Document return value.
7502
60002bf5
CY
75032011-06-06 Chong Yidong <cyd@stupidchicken.com>
7504
7505 * image.c (gif_load): Implement gif89a spec "no disposal" method.
7506
0c671da6 75072011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 7508
b862a52a 7509 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 7510
be44ca6c
PE
7511 Check for overflow when converting integer to cons and back.
7512 * charset.c (Fdefine_charset_internal, Fdecode_char):
7513 Use cons_to_unsigned to catch overflow.
7514 (Fencode_char): Use INTEGER_TO_CONS.
7515 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
7516 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
7517 * data.c (long_to_cons, cons_to_long): Remove.
7518 (cons_to_unsigned, cons_to_signed): New functions.
7519 These signal an error for invalid or out-of-range values.
7520 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
7521 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
7522 * font.c (Ffont_variation_glyphs):
7523 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
7524 * lisp.h: Include <intprops.h>.
7525 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
7526 (cons_to_signed, cons_to_unsigned): New decls.
7527 (long_to_cons, cons_to_long): Remove decls.
7528 * undo.c (record_first_change): Use INTEGER_TO_CONS.
7529 (Fprimitive_undo): Use CONS_TO_INTEGER.
7530 * xfns.c (Fx_window_property): Likewise.
7531 * xselect.c: Include <limits.h>.
7532 (x_own_selection, selection_data_to_lisp_data):
7533 Use INTEGER_TO_CONS.
7534 (x_handle_selection_request, x_handle_selection_clear)
7535 (x_get_foreign_selection, Fx_disown_selection_internal)
7536 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
7537 (lisp_data_to_selection_data): Use cons_to_unsigned.
7538 (x_fill_property_data): Use cons_to_signed.
7539 Report values out of range.
7540
d1f3d2af
PE
7541 Check for buffer and string overflow more precisely.
7542 * buffer.h (BUF_BYTES_MAX): New macro.
7543 * lisp.h (STRING_BYTES_MAX): New macro.
7544 * alloc.c (Fmake_string):
7545 * character.c (string_escape_byte8):
7546 * coding.c (coding_alloc_by_realloc):
7547 * doprnt.c (doprnt):
7548 * editfns.c (Fformat):
7549 * eval.c (verror):
7550 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
7551 since they may not be the same number.
7552 * editfns.c (Finsert_char):
7553 * fileio.c (Finsert_file_contents):
7554 Likewise for BUF_BYTES_MAX.
7555
dd52fcea
PE
7556 * image.c: Use ptrdiff_t, not int, for sizes.
7557 (slurp_file): Switch from int to ptrdiff_t.
7558 All uses changed.
7559 (slurp_file): Check that file size fits in both size_t (for
7560 malloc) and ptrdiff_t (for sanity and safety).
7561
7f9bbdbb
PE
7562 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
7563 if b->modtime has its maximal value.
7564
dfe18f82
PE
7565 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
7566
84acfcf0
PE
7567 Don't assume time_t can fit into int.
7568 * buffer.h (struct buffer.modtime): Now time_t, not int.
7569 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
7570 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
7571
ccd9a01a
PE
7572 Minor fixes for signed vs unsigned integers.
7573 * character.h (MAYBE_UNIFY_CHAR):
7574 * charset.c (maybe_unify_char):
7575 * keyboard.c (read_char, reorder_modifiers):
7576 XINT -> XFASTINT, since the integer must be nonnegative.
7577 * ftfont.c (ftfont_spec_pattern):
7578 * keymap.c (access_keymap, silly_event_symbol_error):
7579 XUINT -> XFASTINT, since the integer must be nonnegative.
7580 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
7581 since it makes no difference and we prefer signed.
7582 * keyboard.c (record_char): Use XUINT when all the neighbors do.
7583 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
7584 nonnegative.
7585
d6d100dd
SM
75862011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
7587
7588 * window.h (Fwindow_frame): Declare.
7589
2b6148e4
PE
75902011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7591
7592 * alloc.c: Simplify handling of large-request failures (Bug#8800).
7593 (SPARE_MEMORY): Always define.
7594 (LARGE_REQUEST): Remove.
7595 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
7596
f230ecc9
MR
75972011-06-06 Martin Rudalics <rudalics@gmx.at>
7598
727e958e
MR
7599 * lisp.h: Move EXFUNS for Fframe_root_window,
7600 Fframe_first_window and Fset_frame_selected_window to window.h.
7601
7602 * window.h: Move EXFUNS for Fframe_root_window,
7603 Fframe_first_window and Fset_frame_selected_window here from
7604 lisp.h.
7605
7606 * frame.c (Fwindow_frame, Fframe_first_window)
7607 (Fframe_root_window, Fframe_selected_window)
7608 (Fset_frame_selected_window): Move to window.c.
7609 (Factive_minibuffer_window): Move to minibuf.c.
7610 (Fother_visible_frames_p): New function.
7611
7612 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
7613
f230ecc9
MR
7614 * window.c (decode_window, decode_any_window): Move up in code.
7615 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
7616 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
7617 (Fwindow_buffer): Move up and rewrite doc-string.
7618 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
7619 (Fwindow_prev): New functions.
727e958e
MR
7620 (Fwindow_frame): Move here from frame.c. Accept any window as
7621 argument.
7622 (Fframe_root_window, Fframe_first_window)
7623 (Fframe_selected_window): Move here from frame.c. Accept frame
7624 or arbitrary window as argument. Update doc-strings.
7625 (Fminibuffer_window): Move up in code.
7626 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
7627 (Fset_frame_selected_window): Move here from frame.c.
7628 Marginal rewrite.
727e958e
MR
7629 (Fselected_window, select_window, Fselect_window): Move up in
7630 code. Minor doc-string fixes.
f230ecc9 7631
4d09bcf6
PE
76322011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7633
7634 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
7635 Do not assume that spare memory exists; that assumption is valid
7636 only if SYSTEM_MALLOC.
7637 (LARGE_REQUEST): New macro, so that the issue of large requests
7638 is separated from the issue of spare memory.
7639
810928a2
AS
76402011-06-05 Andreas Schwab <schwab@linux-m68k.org>
7641
172418ad
AS
7642 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
7643 format. (Bug#8806)
7644
43f862f7
AS
7645 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
7646
810928a2
AS
7647 * xfns.c (x_set_scroll_bar_default_width): Move declarations
7648 before statements.
7649
a059fe24
JD
76502011-06-05 Jan Djärv <jan.h.d@swipnet.se>
7651
7652 * gtkutil.c (xg_get_default_scrollbar_width): New function.
7653
7654 * gtkutil.h: Declare xg_get_default_scrollbar_width.
7655
7656 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
7657 min width by calling x_set_scroll_bar_default_width (Bug#8505).
7658
989bf368
JB
76592011-06-05 Juanma Barranquero <lekktu@gmail.com>
7660
7661 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
7662
4b80f674
CY
76632011-06-04 Chong Yidong <cyd@stupidchicken.com>
7664
7665 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
7666 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
7667 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
7668 New error handlers.
4b80f674
CY
7669 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
7670 Obey Vx_select_enable_clipboard_manager. Catch errors in
7671 x_clipboard_manager_save (Bug#8779).
7672 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 7673 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 7674
99a33b77 76752011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
7676
7677 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
7678
99a33b77 76792011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
7680
7681 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
7682 in the current matrix if keep_current_p is non-zero.
7683
8264569d
EZ
76842011-06-04 Eli Zaretskii <eliz@gnu.org>
7685
7686 * bidi.c (bidi_level_of_next_char): Fix last change.
7687
57f97249
EZ
76882011-06-03 Eli Zaretskii <eliz@gnu.org>
7689
fec2107c 7690 Support bidi reordering of text covered by display properties.
57f97249 7691
fec2107c
EZ
7692 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
7693 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
7694 (bidi_cache_search, bidi_cache_iterator_state)
7695 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
7696 (bidi_level_of_next_char, bidi_move_to_visually_next):
7697 Support character positions inside a run of characters covered by a
fec2107c
EZ
7698 display string.
7699 (bidi_paragraph_init, bidi_resolve_explicit_1)
7700 (bidi_level_of_next_char): Call bidi_fetch_char and
7701 bidi_fetch_char_advance instead of FETCH_CHAR and
7702 FETCH_CHAR_ADVANCE.
7703 (bidi_init_it): Initialize new members.
7704 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
7705 definitions.
7706 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
7707 instead of using explicit *_CHAR codes.
d6d100dd
SM
7708 (bidi_resolve_explicit, bidi_resolve_weak):
7709 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
7710 bidirectional text is supported only in multibyte buffers.
7711 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
7712 it to initialize the frame_window_p member of struct bidi_it.
7713 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
7714 (bidi_resolve_explicit, bidi_resolve_weak)
7715 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
7716 bidi_it->nchars is non-positive.
7717 (bidi_level_of_next_char): Don't try to lookup the cache for the
7718 next/previous character if nothing is cached there yet, or if we
7719 were just reseat()'ed to a new position.
c40e2fb2 7720
0e14fe90
EZ
7721 * xdisp.c (set_cursor_from_row): Set start and stop points
7722 according to the row's direction when priming the loop that looks
7723 for the glyph on which to display cursor.
7724 (single_display_spec_intangible_p): Function deleted.
7725 (display_prop_intangible_p): Reimplement to call
7726 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
7727 Accept 3 additional arguments needed by handle_display_spec.
7728 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
7729 values: lists, `(when COND...)' forms, etc.
7730 (single_display_spec_string_p): Support property values that are
7731 lists with the argument STRING its top-level element.
7732 (display_prop_string_p): Fix the condition for processing a
7733 property that is a list to be consistent with handle_display_spec.
fec2107c 7734 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
7735 last portion of handle_display_prop.
7736 (compute_display_string_pos): Accept additional argument
7737 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
7738 value of a `display' property is a "replacing spec".
7739 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
7740 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
7741 the display property, but just return a value indicating whether
7742 the display property will replace the characters it covers.
7743 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
7744 frame_window_p members of struct bidi_it.
d6d100dd
SM
7745 (compute_display_string_pos, compute_display_string_end):
7746 New functions.
fec2107c
EZ
7747 (push_it): Accept second argument POSITION, where pop_it should
7748 jump to continue iteration.
7749 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 7750
fec2107c
EZ
7751 * keyboard.c (adjust_point_for_property): Adjust the call to
7752 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
7753
7754 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
7755 (bidi_init_it): Update prototypes.
7756 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
7757 (compute_display_string_pos, compute_display_string_end):
7758 Declare prototypes.
fec2107c
EZ
7759 (struct bidi_it): New members nchars and disp_pos. ch_len is now
7760 EMACS_INT.
fc6f18ce 7761
40087514 77622011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 7763
57f53182
PE
7764 Malloc failure behavior now depends on size of allocation.
7765 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
7766 * lisp.h: Change signatures accordingly.
7767 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
7768 All callers changed. (Bug#8762)
7769
7770 * gnutls.c: Use Emacs's memory allocators.
7771 Without this change, the gnutls library would invoke malloc etc.
7772 directly, which causes problems on non-SYNC_INPUT hosts, and which
7773 runs afoul of improving memory_full behavior. (Bug#8761)
7774 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
7775 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
7776 xfree instead of the default malloc, realloc, free.
7777 (Fgnutls_boot): No need to check for memory allocation failure,
7778 since xmalloc does that for us.
7779
ac32cd99 7780 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
7781 * category.c (hash_get_category_set):
7782 * ccl.c (ccl_driver):
7783 * charset.c (Fdefine_charset_internal):
7784 * charset.h (struct charset.hash_index):
7785 * composite.c (get_composition_id, gstring_lookup_cache)
7786 (composition_gstring_put_cache):
7787 * composite.h (struct composition.hash_index):
7788 * dispextern.h (struct image.hash):
7789 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
7790 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
7791 (hashfn_equal, hashfn_user_defined, make_hash_table)
7792 (maybe_resize_hash_table, hash_lookup, hash_put)
7793 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
7794 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
7795 (Fsxhash, Fgethash, Fputhash, Fmaphash):
7796 * image.c (make_image, search_image_cache, lookup_image)
7797 (xpm_put_color_table_h):
7798 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 7799 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 7800 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 7801 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
7802 * alloc.c (allocate_vectorlike):
7803 Check for overflow in vector size calculations.
7804 * ccl.c (ccl_driver):
7805 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
7806 * fns.c, image.c: Remove unnecessary static decls that would otherwise
7807 need to be updated by these changes.
40087514
PE
7808 * fns.c (make_hash_table, maybe_resize_hash_table):
7809 Check for integer overflow with large hash tables.
0de4bb68
PE
7810 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
7811 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
7812 (SXHASH_REDUCE): New macro.
7813 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
7814 Use it instead of discarding useful hash info with large hash values.
7815 (sxhash_float): New function.
7816 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
7817 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
7818 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
7819 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
7820 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
7821 Adjust signatures to match updated version of code.
7822 (consing_since_gc): Now EMACS_INT, since a single hash table can
7823 use more than INT_MAX bytes.
7824
698d32e2
DN
78252011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
7826
7827 Make it possible to build with GCC-4.6+ -O2 -flto.
7828
7829 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
7830
fd6fa53f
SM
78312011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
7832
7833 * minibuf.c (get_minibuffer, read_minibuf_unwind):
7834 Call minibuffer-inactive-mode.
7835
864db017
JB
78362011-05-31 Juanma Barranquero <lekktu@gmail.com>
7837
7838 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
7839 Update dependencies.
7840
2ad0baf4
DN
78412011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7842
7843 * data.c (init_data): Remove code for UTS, this system is not
7844 supported anymore.
7845
4fcc2638
DN
78462011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7847
7848 Don't force ./temacs to start in terminal mode.
7849
7850 * frame.c (make_initial_frame): Initialize faces in all cases, not
7851 only when CANNOT_DUMP is defined.
7852 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
7853
c56e0fd5
DN
78542011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7855
7856 * dispnew.c (add_window_display_history): Use const for the string
7857 pointer. Remove declaration, not needed.
7858
333d54da 78592011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 7860
55d4c1b2 7861 Use 'inline', not 'INLINE'.
333d54da 7862 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
7863 * alloc.c, fontset.c (INLINE): Remove.
7864 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
7865 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
7866 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
7867 * gmalloc.c (register_heapinfo): Use inline unconditionally.
7868 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
7869
738db178
DN
78702011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7871
7872 Make it possible to run ./temacs.
7873
7874 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
7875 syms_of_callproc does the same thing. Remove test for
7876 "initialized", do it in the caller.
7877 * emacs.c (main): Avoid calling set_initial_environment when dumping.
7878
620c53a6
SM
78792011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
7880
7881 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
7882 (read_minibuf): Use get_minibuffer.
7883 (syms_of_minibuf): Use DEFSYM.
7884 (Qmetadata): New var.
7885 * data.c (Qbuffer): Don't make it static.
7886 (syms_of_data): Use DEFSYM.
7887
e003a292
PE
78882011-05-31 Paul Eggert <eggert@cs.ucla.edu>
7889
7890 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
7891 (CCL_CODE_MIN): New macro.
7892
ed008a6d
PE
78932011-05-30 Paul Eggert <eggert@cs.ucla.edu>
7894
3687c2ef
PE
7895 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
7896
ed008a6d
PE
7897 * eval.c (Qdebug): Now static.
7898 * lisp.h (Qdebug): Remove decl. This reverts a part of the
7899 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
7900 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
7901
d66c4c7c
CY
79022011-05-29 Chong Yidong <cyd@stupidchicken.com>
7903
7904 * image.c: Various fixes to ImageMagick code comments.
7905 (Fimagemagick_types): Doc fix.
7906
5fbc2025
PE
79072011-05-29 Paul Eggert <eggert@cs.ucla.edu>
7908
0196f88a
PE
7909 Minor fixes prompted by GCC 4.6.0 warnings.
7910
7911 * xselect.c (converted_selections, conversion_fail_tag): Now static.
7912
5fbc2025
PE
7913 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
7914 (x_clipboard_manager_save_all): Move extern decl to ...
7915 * xterm.h: ... here, so that it can be checked for consistency.
7916
1dd3c2d9
CY
79172011-05-29 Chong Yidong <cyd@stupidchicken.com>
7918
7919 * xselect.c (x_clipboard_manager_save_frame)
7920 (x_clipboard_manager_save_all): New functions.
7921 (Fx_clipboard_manager_save): Lisp function deleted.
7922
7923 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
7924 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
7925
7926 * xterm.h: Update prototype.
7927
5ba6571d
WX
79282011-05-28 William Xu <william.xwl@gmail.com>
7929
7930 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
7931 exiting (Bug#8239).
7932
3eaff834
JM
79332011-05-28 Jim Meyering <meyering@redhat.com>
7934
e1900994 7935 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
7936 * fns.c (to_uchar): Define.
7937 (crypto_hash_function): Use it to convert some newly-signed
7938 variables to unsigned, to avoid sign-extension bugs. For example,
7939 without this change, (md5 "truc") would evaluate to
7940 45723a2aff78ff4fff7fff1114760e62 rather than the expected
7941 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 7942 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 7943
0f6990a7
PE
79442011-05-27 Paul Eggert <eggert@cs.ucla.edu>
7945
7946 Integer overflow fixes.
c8a9ca5a 7947
08686060
PE
7948 * dbusbind.c: Serial number integer overflow fixes.
7949 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
7950 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
7951 to hold a serial number that is too large for a fixnum.
7952 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7953 Check for serial numbers out of range. Decode any serial number
59568bf0 7954 that was so large that it became a float. (Bug#8722)
08686060 7955
2d1fc3c7
PE
7956 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
7957 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7958 Use XFASTINT rather than XUINT when numbers are nonnegative.
7959 (xd_append_arg, Fdbus_method_return_internal):
7960 (Fdbus_method_error_internal): Likewise. Also, for unsigned
7961 arguments, check that Lisp number is nonnegative, rather than
59568bf0 7962 silently wrapping negative numbers around. (Bug#8722)
30217ff0 7963 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 7964 (Bug#8722)
2d1fc3c7 7965
c8a9ca5a
PE
7966 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
7967
519e1d69
PE
7968 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
7969
6df6ae42 7970 ccl: Add integer overflow checks.
30569699
PE
7971 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
7972 (IN_INT_RANGE): New macros.
7973 (ccl_driver): Use them to check for integer overflow when
7974 decoding a CCL program. Many of the new checks are whether XINT (x)
7975 fits in int; it doesn't always, on 64-bit hosts. The new version
7976 doesn't catch all possible integer overflows, but it's an
847044ea 7977 improvement. (Bug#8719)
30569699 7978
c11285dc
PE
7979 * alloc.c (make_event_array): Use XINT, not XUINT.
7980 There's no need for unsigned here.
7981
fdccd48e
PE
7982 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
7983 This follows up to the 2011-05-06 change that substituted uintptr_t
7984 for EMACS_INT. This case wasn't caught back then.
7985
37910ab2
PE
7986 Rework Fformat to avoid integer overflow issues.
7987 * editfns.c: Include <float.h> unconditionally, as it's everywhere
7988 now (part of C89). Include <verify.h>.
7989 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
7990 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
7991 (Fformat): Avoid the prepass trying to compute sizes; it was only
7992 approximate and thus did not catch overflow reliably. Instead, walk
7993 through the format just once, formatting and computing sizes as we go,
7994 checking for integer overflow at every step, and allocating a larger
7995 buffer as needed. Keep track separately whether the format is
7996 multibyte. Keep only the most-recently calculated precision, rather
7997 than them all. Record whether each argument has been converted to
7998 string. Use EMACS_INT, not int, for byte and char and arg counts.
7999 Support field widths and precisions larger than INT_MAX. Avoid
8000 sprintf's undefined behavior with conversion specifications such as %#d
8001 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
8002 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
8003 formatting out-of-range floating point numbers with int
9173deec 8004 formats. (Bug#8668)
37910ab2 8005
2e6578fb
PE
8006 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
8007
0ae6bdee
PE
8008 * data.c: Avoid integer truncation in expressions involving floats.
8009 * data.c: Include <intprops.h>.
8010 (arith_driver): When there's an integer overflow in an expression
8011 involving floating point, convert the integers to floating point
8012 so that the resulting value does not suffer from catastrophic
8013 integer truncation. For example, on a 64-bit host (* 4
8014 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
8015 Do not rely on undefined behavior after integer overflow.
8016
de883a70
PE
8017 merge count_size_as_multibyte, parse_str_to_multibyte
8018 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 8019 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
8020 Check for integer overflow.
8021 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
8022 since it's now a duplicate of the other. This is more of
8023 a character than a buffer op, so better that it's in character.c.
8024 * fns.c, print.c: Adjust to above changes.
8025
2ff916cb
PE
80262011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
8027
8028 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
8029
f1b54466
PE
80302011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8031
fb1ac845
PE
8032 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8033 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
8034 (x_clipboard_manager_save): Now static.
8035 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
8036
f1b54466
PE
8037 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8038 (crypto_hash_function): Now static.
8039 Fix pointer signedness problems. Avoid unnecessary initializations.
8040
a9f737ee
CY
80412011-05-27 Chong Yidong <cyd@stupidchicken.com>
8042
8043 * termhooks.h (Vselection_alist): Make it terminal-local.
8044
8045 * terminal.c (create_terminal): Initialize it.
8046
8047 * xselect.c: Support for clipboard managers.
8048 (Vselection_alist): Move to termhooks.h as terminal-local var.
8049 (LOCAL_SELECTION): New macro.
8050 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
8051 (symbol_to_x_atom): Remove gratuitous arg.
8052 (x_handle_selection_request, lisp_data_to_selection_data)
8053 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
8054 (x_own_selection, x_get_local_selection, x_convert_selection):
8055 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
8056 (some_frame_on_display): Delete unused function.
8057 (Fx_own_selection_internal, Fx_get_selection_internal)
8058 (Fx_disown_selection_internal, Fx_selection_owner_p)
8059 (Fx_selection_exists_p): New optional frame arg.
8060 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
8061 (x_handle_selection_clear): Don't treat other terminals with the
8062 same keyboard specially. Use the terminal-local Vselection_alist.
8063 (x_clear_frame_selections): Use Frun_hook_with_args.
8064
8065 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
8066
8067 * xterm.h: Add support for those atoms.
8068
e067f0c1
CY
80692011-05-26 Chong Yidong <cyd@stupidchicken.com>
8070
8071 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
8072 (converted_selections, conversion_fail_tag): New global variables.
8073 (x_selection_request_lisp_error): Free the above.
8074 (x_get_local_selection): Remove unnecessary code.
8075 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
8076 of converted selections stored in converted_selections.
8077 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
8078 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
8079 (x_convert_selection): New function.
8080 (x_handle_selection_event): Simplify.
8081 (x_get_foreign_selection): Don't ignore incoming requests while
8082 waiting for an answer; this will fail when we implement
8083 SAVE_TARGETS, and seems unnecessary anyway.
8084 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
8085 (Vx_sent_selection_functions): Doc fix.
8086
0f4aebc0
LL
80872011-05-26 Leo Liu <sdl.web@gmail.com>
8088
8089 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
8090
e61124cd
YM
80912011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8092
8093 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
8094
8095 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
8096 for fringe update if it has periodic bitmap.
ac389d0c 8097 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
8098 and fringe_bitmap_periodic_p.
8099
8100 * fringe.c (get_fringe_bitmap_data): New function.
8101 (draw_fringe_bitmap_1, update_window_fringes): Use it.
8102 (update_window_fringes): Record periodicity of fringe bitmap in glyph
8103 row. Mark glyph row for fringe update if periodicity changed.
8104
8105 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
8106 for fringe update unless it has periodic bitmap.
8107
f16d9837
KH
81082011-05-25 Kenichi Handa <handa@m17n.org>
8109
8110 * xdisp.c (get_next_display_element): Set correct it->face_id for
8111 a static composition.
8112
e1b90ef6
LL
81132011-05-24 Leo Liu <sdl.web@gmail.com>
8114
8115 * deps.mk (fns.o):
8116 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
8117
8118 * fns.c (crypto_hash_function, Fsha1): New function.
8119 (Fmd5): Use crypto_hash_function.
8120 (syms_of_fns): Add Ssha1.
8121
7400048f
PE
81222011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8123
8124 * gnutls.c: Remove unused macros.
8125 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
8126 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
8127 Remove macros that are defined and never used.
8128 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
8129
abb71cf4
CY
81302011-05-22 Chong Yidong <cyd@stupidchicken.com>
8131
8132 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
8133 (Fx_get_selection_internal): Minor cleanup.
8134 (Fx_own_selection_internal): Rename arguments for consistency with
8135 select.el.
8136
6307db39
PE
81372011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8138
8139 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
8140
f3d4e0a4
CY
81412011-05-22 Chong Yidong <cyd@stupidchicken.com>
8142
8143 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
8144
4d8ade89
YM
81452011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8146
8147 * dispnew.c (scrolling_window): Don't exclude the case that the
8148 last enabled row in the desired matrix touches the bottom boundary.
8149
32078c8d
GM
81502011-05-21 Glenn Morris <rgm@gnu.org>
8151
8152 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
8153 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
8154 and add some more files.
32078c8d 8155
7285dc67
EZ
81562011-05-20 Eli Zaretskii <eliz@gnu.org>
8157
8158 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
8159 report_file_error introduced by the change from 2011-05-07.
8160
89d1bd22
PE
81612011-05-20 Paul Eggert <eggert@cs.ucla.edu>
8162
8163 * systime.h (Time): Define only if emacs is defined.
8164 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
8165 where the include path doesn't have X11/X.h by default. See
8166 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
8167
cd394be1 81682011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
8169
8170 * composite.c (find_automatic_composition): Fix previous change.
8171
b9704ad9
GM
81722011-05-20 Glenn Morris <rgm@gnu.org>
8173
8174 * lisp.mk: New file, split from Makefile.in.
8175 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
8176 (shortlisp): Remove.
8177 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
8178
4a720484
GM
81792011-05-19 Glenn Morris <rgm@gnu.org>
8180
8181 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
8182 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
8183 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
8184 (lisp): Set the order to that of loadup.el.
8185 (shortlisp): Make it a copy of $lisp.
8186 (SOME_MACHINE_LISP): Remove.
8187 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
8188 Use just $shortlisp, not $SOME_MACHINE_LISP too.
8189
a28d4396
KH
81902011-05-18 Kenichi Handa <handa@m17n.org>
8191
8192 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
8193 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
8194 (find_automatic_composition): Mostly rewrite for efficiency.
8195
a2b1fa8e
JB
81962011-05-18 Juanma Barranquero <lekktu@gmail.com>
8197
8198 * makefile.w32-in: Update dependencies.
8199
8e1f5610
CS
82002011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
8201
8202 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 8203 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 8204
7025ee00 82052011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 8206
cdfa6eab
PE
8207 Fix some integer overflow issues, such as string length overflow.
8208
06d6db33
PE
8209 * insdel.c (count_size_as_multibyte): Check for string overflow.
8210
2b4560a8
PE
8211 * character.c (lisp_string_width): Check for string overflow.
8212 Use EMACS_INT, not int, for string indexes and lengths; in
8213 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
8214 the resulting string length overflows an EMACS_INT; instead,
8215 report a string overflow if no precision given. When checking for
8216 precision exhaustion, use a check that cannot possibly have
8217 integer overflow. (Bug#8675)
8218 * character.h (lisp_string_width): Adjust to new signature.
8219
cb93f9be
PE
8220 * alloc.c (string_overflow): New function.
8221 (Fmake_string): Use it. This doesn't change behavior, but saves
8222 a few bytes and will simplify future changes.
8223 * character.c (string_escape_byte8): Likewise.
8224 * lisp.h (string_overflow): New decl.
8225
1a1f3366
PE
8226 Fixups, following up to the user-interface timestamp change.
8227 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
8228 for UI timestamps, instead of unsigned long.
9fbd6841
PE
8229 * msdos.c (mouse_get_pos): Likewise.
8230 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
8231 * w32gui.h (Time): Define by including "systime.h" rather than by
8232 declaring it ourselves. (Bug#8664)
8233
d4e3e4d3
PE
8234 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
8235 * image.c (clear_image_cache): Likewise.
8236
f6a24d19
PE
8237 * term.c (term_mouse_position): Don't assume time_t wraparound.
8238
08dc5ae6
PE
8239 Be more systematic about user-interface timestamps.
8240 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
8241 and sometimes 'EMACS_UINT', to represent these timestamps.
8242 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
8243 This makes the code easier to follow, and makes it easier to catch
8244 integer overflow bugs such as Bug#8664.
8245 * frame.c (Fmouse_position, Fmouse_pixel_position):
8246 Use Time, not unsigned long, for user-interface timestamps.
8247 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
8248 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
8249 * keyboard.h (last_event_timestamp): Likewise.
8250 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
8251 * menu.h (xmenu_show): Likewise.
8252 * term.c (term_mouse_position): Likewise.
8253 * termhooks.h (struct input_event.timestamp): Likewise.
8254 (struct terminal.mouse_position_hook): Likewise.
8255 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
8256 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
8257 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
8258 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
8259 what it was before.
8260 * menu.h, termhooks.h: Include "systime.h", for Time.
8261
8e55734a
PE
8262 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
8263 Don't assume that the difference between two unsigned long values
8264 can fit into an integer. At this point, we know button_down_time
8265 <= event->timestamp, so the difference must be nonnegative, so
8266 there's no need to cast the result if double-click-time is
8267 nonnegative, as it should be; check that it's nonnegative, just in
8268 case. This bug is triggered when events are more than 2**31 ms
86db42d2 8269 apart (about 25 days). (Bug#8664)
8e55734a 8270
841f1b75 8271 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 8272 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 8273
3e26f69c
PE
8274 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
8275 that always fit in int. Use a sentinel instead of a counter, to
8276 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
8277 * frame.h (struct frame): Use int for menu_bar_items_used
8278 instead of EMACS_INT, since it always fits in int.
3e26f69c 8279
5cc152c0
PE
8280 * menu.c (grow_menu_items): Check for int overflow.
8281
d89eb65e
PE
8282 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
8283
5235bd3e
PE
8284 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
8285 Before, the code was not consistent. These values cannot exceed
8286 2**31 - 1 so there's no need to make them unsigned.
8287 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
8288 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
8289 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
8290 as modifiers.
8291 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
8292
bc827e23
PE
8293 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
8294 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
8295 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
8296 presumably because the widths might not match.
8297
78eb494e
PE
8298 * window.c (size_window): Avoid needless test at loop start.
8299
04f2d78b
CB
83002011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
8301
8302 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
8303
d2fc7e3d 83042011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
8305
8306 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
8307
d2fc7e3d 83082011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
8309
8310 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
8311 `width' to `bar_area_x' and `bar_area_width', respectively.
8312 (x_scroll_run): Take account of fringe background extension.
8313
04f2d78b
CB
8314 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
8315 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
8316 `bar_area_width', respectively.
8317 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
8318 background extension.
8319
79b70037
GM
83202011-05-10 Jim Meyering <meyering@redhat.com>
8321
8322 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
8323
2f142cc5
JB
83242011-05-10 Juanma Barranquero <lekktu@gmail.com>
8325
8326 * image.c (Finit_image_library): Return t for built-in image types,
8327 like pbm and xbm. (Bug#8640)
8328
57679c86
AS
83292011-05-09 Andreas Schwab <schwab@linux-m68k.org>
8330
8331 * w32menu.c (set_frame_menubar): Fix submenu allocation.
8332
888c9e86
EZ
83332011-05-07 Eli Zaretskii <eliz@gnu.org>
8334
b0512a1d
EZ
8335 * w32console.c (Fset_screen_color): Doc fix.
8336 (Fget_screen_color): New function.
8337 (syms_of_ntterm): Defsubr it.
8338
7285dc67
EZ
8339 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
8340 unlink the temporary file if Fcall_process didn't create it in the
8341 first place.
8342 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
8343 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
8344 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
8345 cue to call_process_cleanup not to close that handle.
8346
4d3fcc8e
BK
83472011-05-07 Ben Key <bkey76@gmail.com>
8348
8349 * makefile.w32-in: The bootstrap-temacs rule now makes use of
8350 one of two shell specific rules, either bootstrap-temacs-CMD or
8351 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
8352 to the previous implementation of the bootstrap-temacs rule.
8353 The bootstrap-temacs-CMD rule is similar to the previous
8354 implementation of the bootstrap-temacs rule except that it
8355 makes use of the ESC_CFLAGS variable instead of the CFLAGS
8356 variable.
8357
8358 These changes, along with some changes to nt/configure.bat,
8359 nt/gmake.defs, and nt/nmake.defs, are required to extend my
8360 earlier fix to add support for --cflags and --ldflags options
8361 that include quotes so that it works whether make uses cmd or
8362 sh as the shell.
8363
b4289b64
MA
83642011-05-06 Michael Albinus <michael.albinus@gmx.de>
8365
8366 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
8367 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
8368 is a constant.
8369 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
8370 a string. Handle both cases.
8371 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
8372 (Fdbus_register_method): Use Qinvalid_function.
8373
af4c0e28
JB
83742011-05-06 Juanma Barranquero <lekktu@gmail.com>
8375
8376 * makefile.w32-in: Update dependencies.
8377 (LISP_H): Add inttypes.h and stdin.h.
8378 (PROCESS_H): Add unistd.h.
8379
c51453d9
EZ
83802011-05-06 Eli Zaretskii <eliz@gnu.org>
8381
8382 * lread.c: Include limits.h (fixes the MS-Windows build broken by
8383 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
8384
8ff0ac3c 83852011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 8386
4c4b566b
PE
8387 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
8388
aab2b9b5
PE
8389 * term.c (vfatal): Remove stray call to va_end.
8390 It's not needed and the C Standard doesn't allow it here anyway.
8391
c378da0b
PE
8392 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
8393 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
8394
288b08c7
PE
8395 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
8396 bytes.
8397
e3601888
PE
8398 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
8399
db6c0e74
PE
8400 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8401
dd5963ea
PE
8402 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
8403
88c9450f
PE
8404 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
8405
2f9442b8
PE
8406 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
8407
c032b5f8
PE
8408 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
8409 * charset.c (Fdefine_charset_internal): Don't initialize
8410 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 8411 32-bit int (Bug#8600).
a108c10b
PE
8412
8413 * lread.c (read_integer): Be more consistent with string-to-number.
8414 Use string_to_number to do the actual conversion; this avoids
8415 rounding errors and fixes some other screwups. Without this fix,
8416 for example, #x1fffffffffffffff was misread as -2305843009213693952.
8417 (digit_to_number): Move earlier, for benefit of read_integer.
8418 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 8419 not a digit in any supported base. (Bug#8602)
a108c10b 8420
ad5f9eea
PE
8421 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
8422
aec1708a
PE
8423 * dispnew.c (scrolling_window): Return 1 if we scrolled,
8424 to match comment at start of function. This also removes a
8425 GCC warning about overflow in a 32+64-bit port.
8426
47be4ab5
PE
8427 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
8428
371cac43
PE
8429 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
8430 Reported by Stefan Monnier in
8431 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
8432 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8433 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 8434
d01a7826
PE
8435 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
8436 (EMACS_UINTPTR): Likewise, with uintptr_t.
8437
7fd47d5c
PE
8438 * lisp.h: Prefer 64-bit EMACS_INT if available.
8439 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
8440 on 32-bit hosts that have 64-bit int, so that they can access
8441 large files.
122b0c86
PE
8442 However, temporarily disable this change unless the temporary
8443 symbol WIDE_EMACS_INT is defined.
7fd47d5c 8444
8727937b
PE
8445 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
8446
8ac068ac
PE
8447 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
8448 This removes an assumption that EMACS_INT and long are the same
8449 width as pointers. The assumption is true for Emacs porting targets
8450 now, but we want to make other targets possible.
8451 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
8452 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
8453 In the rest of the code, change types of integers that hold casted
8454 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
8455 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
8456 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
8457 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
8458 No need to cast type when ORing.
8459 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
8460 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
8461 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
8462 assume EMACS_INT is the same width as char *.
8463 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
8464 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
8465 Remove no-longer-needed casts.
8466 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
8467 (xg_tool_bar_help_callback, xg_make_tool_item):
8468 Use EMACS_INTPTR to hold an integer
8469 that will be cast to void *; this can avoid a GCC warning
8470 if EMACS_INT is not the same width as void *.
8471 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
8472 * xdisp.c (display_echo_area_1, resize_mini_window_1):
8473 (current_message_1, set_message_1):
8474 Use a local to convert to proper width without a cast.
8475 * xmenu.c (dialog_selection_callback): Likewise.
8476
ede49d71
PE
8477 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
8478 Also, don't assume VALBITS / RAND_BITS is less than 5,
8479 and don't rely on undefined behavior when shifting a 1 left into
8480 the sign bit.
8481 * lisp.h (get_random): Change signature to match.
8482
2f30ecd0
PE
8483 * lread.c (hash_string): Use size_t, not int, for hash computation.
8484 Normally we prefer signed values; but hashing is special, because
8485 it's better to use unsigned division on hash table sizes so that
8486 the remainder is nonnegative. Also, size_t is the natural width
8487 for hashing into memory. The previous code used 'int', which doesn't
8488 retain enough info to hash well into very large tables.
8489 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
8490
2a866e7b
PE
8491 * dbusbind.c: Don't possibly lose pointer info when converting.
8492 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8493 Use XPNTR rather than XHASH, so that the high-order bits of
8494 the pointer aren't lost when converting through void *.
8495
51639eac
PE
8496 * eval.c (Fautoload): Don't double-shift a pointer.
8497
92394119
PE
8498 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
8499
dbdb9a7c
JB
85002011-05-06 Juanma Barranquero <lekktu@gmail.com>
8501
8502 * gnutls.c (DEF_GNUTLS_FN):
8503 * image.c (DEF_IMGLIB_FN): Make function pointers static.
8504
db7a0b4f
AS
85052011-05-05 Andreas Schwab <schwab@linux-m68k.org>
8506
8507 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
8508 marker. (Bug#8610)
8509
cd394be1 85102011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
8511
8512 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
8513 New version that can reserve upto 2GB of heap space.
8514
f7ff1b0f 85152011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
8516
8517 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
8518
639c109b
TZ
85192011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
8520
8521 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
8522 `gnutls_certificate_set_x509_key_file'.
8523
d2127135
JB
85242011-05-05 Juanma Barranquero <lekktu@gmail.com>
8525
8526 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
8527 Update dependencies.
8528
e968f4f3
JB
85292011-05-04 Juanma Barranquero <lekktu@gmail.com>
8530
8531 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
8532 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
8533 Remove unused parameter `fildes'.
8534 * process.c (read_process_output, send_process): Don't pass it.
8535
84d358f0
JB
85362011-05-04 Juanma Barranquero <lekktu@gmail.com>
8537
8538 Fix previous change: the library cache is defined in w32.c.
8539 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
8540 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
8541
0898ca10
JB
85422011-05-04 Juanma Barranquero <lekktu@gmail.com>
8543
8544 Implement dynamic loading of GnuTLS on Windows.
8545
8546 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
8547 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
8548 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8549 Declare.
8550
8551 * gnutls.c (Qgnutls_dll): Define.
8552 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
8553 (gnutls_*): Declare function pointers.
8554 (init_gnutls_functions): New function to initialize function pointers.
8555 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
8556 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
8557 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8558 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
8559 (emacs_gnutls_write, emacs_gnutls_read)
8560 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
8561 (Fgnutls_available_p): New function.
8562 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
8563 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
8564 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
8565
8566 * image.c: Include w32.h.
8567 (Vimage_type_cache): Delete.
8568 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
8569 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
8570 (w32_delayed_load): Move to w32.c.
8571
8572 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
8573
8574 * w32.c (QCloaded_from, Vlibrary_cache): Define.
8575 (w32_delayed_load): Move from image.c. When loading a library, record
8576 its filename in the :loaded-from property of the library id.
8577 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
8578 Initialize and staticpro them.
8579 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
8580
8581 * process.c: Include lisp.h before w32.h, not after.
8582 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
8583 instead of gnutls_record_check_pending.
8584
8585 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
8586
ff4de4aa
TZ
85872011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
8588
8589 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
8590 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
8591 as passed in.
8592
abe95abb
JD
85932011-05-03 Jan Djärv <jan.h.d@swipnet.se>
8594
8595 * xterm.c (x_set_frame_alpha): Do not set property on anything
8596 else than FRAME_X_OUTER_WINDOW (Bug#8608).
8597
e16e55d4
JB
85982011-05-02 Juanma Barranquero <lekktu@gmail.com>
8599
8600 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
8601
bafcf6a5
JB
86022011-05-02 Juanma Barranquero <lekktu@gmail.com>
8603
8604 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
8605 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
8606 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
8607 (gnutls_global_initialized, Qgnutls_bootprop_priority)
8608 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
8609 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
8610 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
8611 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
8612 (Qgnutls_bootprop_callbacks_verify): Make static.
8613
e7a6747f
AS
86142011-05-01 Andreas Schwab <schwab@linux-m68k.org>
8615
19ed11ba
AS
8616 * callproc.c: Indentation fixup.
8617
e7a6747f 8618 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
8619 (wait_for_termination, interruptible_wait_for_termination):
8620 Move after wait_for_termination_1.
e7a6747f 8621
1ef14cb4
LMI
86222011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
8623
8624 * sysdep.c (interruptible_wait_for_termination): New function
8625 which is like wait_for_termination, but allows keyboard
8626 interruptions.
8627
8628 * callproc.c (Fcall_process): Add (:file "file") as an option for
8629 the STDOUT buffer.
8630 (Fcall_process_region): Ditto.
8631
330d880c
EZ
86322011-04-30 Eli Zaretskii <eliz@gnu.org>
8633
8db90b73
EZ
8634 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
8635 rather than `XVECTOR (FOO)->size'.
8636
330d880c
EZ
8637 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
8638 inttypes.h, as a gnulib replacement is used if it not available in
8639 system headers.
8640
15cbd324
EZ
86412011-04-21 Eli Zaretskii <eliz@gnu.org>
8642
8643 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
8644 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
8645 of MOST_POSITIVE_FIXNUM. (Bug#8528)
8646
8647 * coding.c (coding_alloc_by_realloc): Error out if destination
8648 will grow beyond MOST_POSITIVE_FIXNUM.
8649 (decode_coding_emacs_mule): Abort if there isn't enough place in
8650 charbuf for the composition carryover bytes. Reserve an extra
8651 space for up to 2 characters produced in a loop.
8652 (decode_coding_iso_2022): Abort if there isn't enough place in
8653 charbuf for the composition carryover bytes.
8654
86552011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 8656
ae940cca
EZ
8657 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
8658 aborting when %lld or %lll format is passed.
8659 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
8660 %llo or %llx format is passed. (Bug#8545)
8661
03ab8921
EZ
8662 * window.c (window_scroll_line_based): Use a marker instead of
8663 simple variables to record original value of point. (Bug#7952)
8664
afda1437
EZ
8665 * doprnt.c (doprnt): Fix the case where a multibyte sequence
8666 produced by %s or %c overflows available buffer space. (Bug#8545)
8667
f76dee0c
PE
86682011-04-28 Paul Eggert <eggert@cs.ucla.edu>
8669
8670 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 8671 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 8672
fdc5744d
JB
86732011-04-28 Juanma Barranquero <lekktu@gmail.com>
8674
8675 * w32.c (init_environment): Warn about defaulting HOME to C:\.
8676
638f053a
JB
86772011-04-28 Juanma Barranquero <lekktu@gmail.com>
8678
8679 * keyboard.c (Qdelayed_warnings_hook): Define.
8680 (command_loop_1): Run `delayed-warnings-hook'
8681 if Vdelayed_warnings_list is non-nil.
8682 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
8683 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
8684
d178f871
EZ
86852011-04-28 Eli Zaretskii <eliz@gnu.org>
8686
8687 * doprnt.c (doprnt): Don't return value smaller than the buffer
8688 size if the message was truncated. (Bug#8545).
8689
b124fd93
JB
86902011-04-28 Juanma Barranquero <lekktu@gmail.com>
8691
8692 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
8693 (Fx_window_property): #if-0 the whole functions, not just the bodies.
8694
e810457d
PE
86952011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8696
8697 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
8698
ea51cceb
JB
86992011-04-27 Juanma Barranquero <lekktu@gmail.com>
8700
8701 * makefile.w32-in: Update dependencies.
8702
94dcfacf
EZ
87032011-04-27 Eli Zaretskii <eliz@gnu.org>
8704
8705 Improve `doprnt' and its usage. (Bug#8545)
8706 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
8707 `format_end'. Remove support for %l as a conversion specifier.
8708 Don't use xrealloc. Improve diagnostics when the %l size modifier
8709 is used. Update the commentary.
8710
8711 * eval.c (verror): Simplify calculation of size_t.
8712
8713 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
8714 messages.
8715
f61f41d7
PE
87162011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
8717
8718 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
8719 change.
8720
96fb4434
PE
87212011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8722
8723 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
8724 This makes this file independent of the recent pseudovector change.
8725
671875da 87262011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 8727
69e9b5a3
PE
8728 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
8729
b5f869a7 8730 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 8731 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 8732 Remove unused local.
c8926152 8733 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 8734
841a1577 8735 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
8736 GCC 4.6.0 optimizes based on type-based alias analysis.
8737 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
8738 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
8739 != &v->size, and therefore "v->size = 1; b->size = 2; return
8740 v->size;" must therefore return 1. This assumption is incorrect
8741 for Emacs, since it type-puns struct Lisp_Vector * with many other
8742 types. To fix this problem, this patch adds a new type struct
f904488f 8743 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
8744 and pseudovectors, and helps optimizing compilers not get fooled
8745 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
8746 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
8747 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
8748 the size member.
eab3844f
PE
8749 (XSETPVECTYPE): Rewrite in terms of new macro.
8750 (XSETPVECTYPESIZE): New macro, specifying both type and size.
8751 This is a bit clearer, and further avoids the possibility of
8752 undesirable aliasing.
8753 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 8754 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
8755 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
8756 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
8757 (ASIZE): Now uses header.size rather than size.
8758 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
8759 to avoid the hassle of writing XVECTOR (foo)->header.size.
8760 (struct vectorlike_header): New type.
eab3844f
PE
8761 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
8762 object, to help avoid aliasing.
8763 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
8764 (SUBRP): Likewise, since Lisp_Subr is a special case.
8765 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
8766 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
8767 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 8768 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
8769 changed to be "header.size" and "header.next".
8770 * buffer.h (struct buffer): Likewise.
8771 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
8772 * frame.h (struct frame): Likewise.
8773 * process.h (struct Lisp_Process): Likewise.
8774 * termhooks.h (struct terminal): Likewise.
8775 * window.c (struct save_window_data, struct saved_window): Likewise.
8776 * window.h (struct window): Likewise.
8777 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
8778 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
8779 * buffer.c (init_buffer_once): Likewise.
8780 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
8781 special case.
8782 * process.c (Fformat_network_address): Use local var for size,
8783 for brevity.
8784
0df1eac5
PE
8785 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
8786
847ab9d1 8787 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
8788 * data.c (atof): Remove decl; no longer used or needed.
8789 (digit_to_number): Move to lread.c.
8790 (Fstring_to_number): Use new string_to_number function, to be
8791 consistent with how the Lisp reader treats infinities and NaNs.
8792 Do not assume that floating-point numbers represent EMACS_INT
8793 without losing information; this is not true on most 64-bit hosts.
8794 Avoid double-rounding errors, by insisting on integers when
8795 parsing non-base-10 numbers, as the documentation specifies.
8796 * lisp.h (string_to_number): New decl, replacing ...
8797 (isfloat_string): Remove.
bc0a5c13 8798 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 8799 (read1): Do not accept +. and -. as integers; this
452f4150
PE
8800 appears to have been a coding error. Similarly, do not accept
8801 strings like +-1e0 as floating point numbers. Do not report
8802 overflow for integer overflows unless the base is not 10 which
8803 means we have no simple and reliable way to continue.
8804 Break out the floating-point parsing into a new
8805 function string_to_number, so that Fstring_to_number parses
8806 floating point numbers consistently with the Lisp reader.
04f2d78b 8807 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
8808 (E_CHAR, EXP_INT): Remove, replacing with ...
8809 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
8810 (string_to_number): New function, replacing isfloat_string.
8811 This function checks for valid syntax and produces the resulting
8812 Lisp float number too. Rework it so that string-to-number
bc0a5c13 8813 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
8814 so that overflow for non-base-10 numbers is reported only when
8815 there's no portable and simple way to convert to floating point.
452f4150 8816
67769ffc
PE
8817 * textprop.c (set_text_properties_1): Rewrite for clarity,
8818 and to avoid GCC warning about integer overflow.
8819
c20db43f
PE
8820 * intervals.h (struct interval): Use EMACS_INT for members
8821 where EMACS_UINT might cause problems. See
8822 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
8823 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
8824 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
8825 All uses changed.
37aa2f85
PE
8826 (offset_intervals): Tell GCC not to worry about length overflow
8827 when negating a negative length.
c20db43f 8828
2538aa2f
PE
8829 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
8830 (overrun_check_free): Likewise.
8831
f2d3008d
PE
8832 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
8833 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
8834 word size.
8835
ec8df744
PE
8836 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
8837 (gnutls_make_error): Rename local to avoid shadowing.
8838 (gnutls_emacs_global_deinit): ifdef out; not used.
8839 (Fgnutls_boot): Use const for pointer to readonly storage.
8840 Comment out unused local. Fix pointer signedness problems.
8841
640ee02d
PE
8842 * lread.c (openp): Don't stuff size_t into an 'int'.
8843 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
8844 about possible signed overflow.
8845
6048fb2a
PE
8846 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
8847 (GDK_KEY_g): Don't define if already defined.
8848 (xg_prepare_tooltip): Avoid pointer signedness problem.
8849 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
8850
fa3c87e1
PE
8851 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
8852 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
8853
2172544b
PE
8854 * xfns.c (Fx_window_property): Simplify a bit,
8855 to make a bit faster and to avoid GCC 4.6.0 warning.
8856 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
8857
9b821a21
PE
8858 * fns.c (internal_equal): Don't assume size_t fits in int.
8859
3c616cfa
PE
8860 * alloc.c (compact_small_strings): Tighten assertion a little.
8861
c2982e87
PE
8862 Replace pEd with more-general pI, and fix some printf arg casts.
8863 * lisp.h (pI): New macro, generalizing old pEd macro to other
8864 conversion specifiers. For example, use "...%"pI"d..." rather
8865 than "...%"pEd"...".
8866 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 8867 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
8868 * alloc.c (check_pure_size): Don't overflow by converting size to int.
8869 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
8870 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
8871 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
8872 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
8873 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
8874 64-bit hosts.
8875 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
8876 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
8877 * print.c (safe_debug_print, print_object): Likewise.
8878 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
8879 to int.
6f04d126
PE
8880 Use pI instead of if-then-else-abort. Use %p to avoid casts,
8881 avoiding the 0 flag, which is not portable.
c2982e87
PE
8882 * process.c (Fmake_network_process): Use pI to avoid cast.
8883 * region-cache.c (pp_cache): Likewise.
8884 * xdisp.c (decode_mode_spec): Likewise.
8885 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
8886 behavior on 64-bit hosts with printf arg.
6f04d126 8887 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
8888 (x_stop_queuing_selection_requests): Likewise.
8889 (x_get_window_property): Don't truncate byte count to an 'int'
8890 when tracing.
0b432f21 8891
5e073ec7
PE
8892 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
8893 here, since it parses constructs like leading '-' and spaces,
8894 which are not wanted; and it overflows with large numbers.
8895 Instead, simply match F[0-9]+, which is what is wanted anyway.
8896
36372bf9
PE
8897 * alloc.c: Remove unportable assumptions about struct layout.
8898 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
8899 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
8900 (allocate_vectorlike, make_pure_vector): Use the new macros,
8901 plus offsetof, to remove unportable assumptions about struct layout.
8902 These assumptions hold on all porting targets that I know of, but
8903 they are not guaranteed, they're easy to remove, and removing them
8904 makes further changes easier.
8905
0b432f21
PE
8906 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
8907 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
8908 (string_overrun_cookie): Now const. Use initializers that
8909 don't formally overflow signed char, to avoid warnings.
000098c1
PE
8910 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
8911 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
8912 (allocate_buffer): Don't assume sizeof (struct buffer) is a
8913 multiple of sizeof (EMACS_INT); it need not be, if
8914 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 8915 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 8916
895009e1
JB
89172011-04-26 Juanma Barranquero <lekktu@gmail.com>
8918
8919 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
8920
6a7a1b0b
TZ
89212011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
8922
8923 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 8924 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
8925 Reported by Paul Eggert <eggert@cs.ucla.edu>.
8926
841a1577 89272011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
8928
8929 * lisp.h (Qdebug): List symbol.
895009e1 8930 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
8931 * keyboard.c (debug-on-event): New variable.
8932 (handle_user_signal): Break into debugger when debug-on-event
8933 matches the current signal symbol.
8934
f2d3ba6f
DN
89352011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
8936
8937 * alloc.c (check_sblock, check_string_bytes)
8938 (check_string_free_list): Convert to standard C.
8939
42ce4c63
TZ
89402011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
8941
8942 * w32.c (emacs_gnutls_push): Fix typo.
8943
825cd63c
EZ
89442011-04-25 Eli Zaretskii <eliz@gnu.org>
8945
fb11d64d
EZ
8946 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
8947 "cast to pointer from integer of different size".
8948
825cd63c
EZ
8949 Improve doprnt and its use in verror. (Bug#8545)
8950 * doprnt.c (doprnt): Document the set of format control sequences
8951 supported by the function. Use SAFE_ALLOCA instead of always
8952 using `alloca'.
8953
8954 * eval.c (verror): Don't limit the buffer size at size_max-1, that
8955 is one byte too soon. Don't use xrealloc; instead xfree and
8956 xmalloc anew.
8957
e061a11b
TZ
89582011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
8959
8960 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
8961 callbacks stage.
8962
8963 * gnutls.c: Renamed global_initialized to
8964 gnutls_global_initialized. Added internals for the
8965 :verify-hostname-error, :verify-error, and :verify-flags
8966 parameters of `gnutls-boot' and documented those parameters in the
8967 docstring. Start callback support.
9173deec
JB
8968 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
8969 unless a fatal error occurred. Call gnutls_alert_send_appropriate
8970 on error. Return error code.
e061a11b
TZ
8971 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
8972 (emacs_gnutls_read): Likewise.
8973 (Fgnutls_boot): Return handshake error code.
8974 (emacs_gnutls_handle_error): New function.
8975 (wsaerror_to_errno): Likewise.
8976
8977 * w32.h (emacs_gnutls_pull): Add prototype.
8978 (emacs_gnutls_push): Likewise.
8979
8980 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
8981 (emacs_gnutls_push): Likewise.
8982
89832011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
8984
8985 * process.c (wait_reading_process_output): Check if GnuTLS
8986 buffered some data internally if no FDs are set for TLS
8987 connections.
8988
8989 * makefile.w32-in (OBJ2): Add gnutls.$(O).
8990 (LIBS): Link to USER_LIBS.
8991 ($(BLD)/gnutls.$(0)): New target.
8992
fa6996bc
EZ
89932011-04-24 Eli Zaretskii <eliz@gnu.org>
8994
eb35682e
EZ
8995 * xdisp.c (handle_single_display_spec): Rename the
8996 display_replaced_before_p argument into display_replaced_p, to
8997 make it consistent with the commentary. Fix typos in the
8998 commentary.
8999
e2ad650c
EZ
9000 * textprop.c (syms_of_textprop): Remove dead code.
9001 (copy_text_properties): Delete obsolete commentary about an
9002 interface that was deleted long ago. Fix typos in the description
9003 of arguments.
9004
1b2de274
EZ
9005 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
9006 to changes in oldXMenu/XMenu.h from 2011-04-16.
9007 <menu_help_message, prev_menu_help_message>: Constify.
9008 (IT_menu_make_room): menu->help_text is now `const char **';
9009 adjust.
9010
9011 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
9012 to changes in oldXMenu/XMenu.h from 2011-04-16.
9013 (struct XMenu): Declare `help_text' `const char **'.
9014
9015 * xfaces.c <Qunspecified>: Make extern again.
9016
9017 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 9018 required by POSIX.
1b2de274 9019
762b15be
EZ
9020 * doc.c (get_doc_string): Improve the format passed to `error'.
9021
9022 * doprnt.c (doprnt): Improve commentary.
9023
9024 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
9025
9026 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
9027 them with etags.
9028
f1052e5d
EZ
9029 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
9030 changes in globals.h immediately force recompilation.
762b15be
EZ
9031 (TAGS): Depend on $(CURDIR)/m/intel386.h and
9032 $(CURDIR)/s/ms-w32.h.
9033 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 9034
fa6996bc
EZ
9035 * character.c (Fchar_direction): Function deleted.
9036 (syms_of_character): Don't defsubr it.
9037 <char-direction-table>: Deleted.
9038
e6c3da20
EZ
90392011-04-23 Eli Zaretskii <eliz@gnu.org>
9040
9041 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
9042 * doprnt.c: Include limits.h.
9043 (SIZE_MAX): New macro.
04f2d78b
CB
9044 (doprnt): Return a size_t value. 2nd arg is now size_t.
9045 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
9046 Improve overflow protection. Support `l' modifier for integer
9047 conversions. Support %l conversion. Don't assume an EMACS_INT
9048 argument for integer conversions and for %c.
9049
9050 * lisp.h (doprnt): Restore prototype.
9051
9052 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
9053 $(SRC)/character.h.
9054
9055 * Makefile.in (base_obj): Add back doprnt.o.
9056
9057 * deps.mk (doprnt.o): Add back prerequisites.
9058 (callint.o): Depend on character.h.
9059
9060 * eval.c (internal_lisp_condition_case): Include the handler
9061 representation in the error message.
9062 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
9063 when breaking from the loop.
9064
9065 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
9066
9067 * callint.c (Fcall_interactively): When displaying error message
9068 about invalid control letter, pass the character's codepoint, not
9069 a pointer to its multibyte form. Improve display of the character
9070 in octal and display also its hex code.
9071
9072 * character.c (char_string): Use %x to display the (unsigned)
9073 codepoint of an invalid character, to avoid displaying a bogus
9074 negative value.
9075
9076 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
9077 `error', not SYMBOL_NAME itself.
9078
9079 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
9080 character arguments to `error'.
9081
9082 * charset.c (check_iso_charset_parameter): Fix incorrect argument
9083 to `error' in error message about FINAL_CHAR argument. Make sure
9084 FINAL_CHAR is a character, and use %c when it is passed as
9085 argument to `error'.
9086
4ffd0d6b 90872011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
9088
9089 * s/ms-w32.h (localtime): Redirect to sys_localtime.
9090
9091 * w32.c: Include <time.h>.
9092 (sys_localtime): New function.
9093
4ffd0d6b 90942011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
9095
9096 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
9097
4ffd0d6b 9098 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 9099
4ffd0d6b 91002011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 9101
4ffd0d6b
GM
9102 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
9103 zombies (Bug#8467).
aac0c6e3 9104
04c56954
EZ
91052011-04-19 Eli Zaretskii <eliz@gnu.org>
9106
9107 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
9108 gl_state.e_property when gl_state.object is Qt.
9109
9110 * insdel.c (make_gap_larger): Remove limitation of buffer size
9111 to <= INT_MAX.
9112
16a43933
CY
91132011-04-18 Chong Yidong <cyd@stupidchicken.com>
9114
9115 * xdisp.c (lookup_glyphless_char_display)
9116 (produce_glyphless_glyph): Handle cons cell entry in
9117 glyphless-char-display.
9118 (Vglyphless_char_display): Document it.
9119
9120 * term.c (produce_glyphless_glyph): Handle cons cell entry in
9121 glyphless-char-display.
9122
4581706e
CY
91232011-04-17 Chong Yidong <cyd@stupidchicken.com>
9124
9125 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
9126
9127 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
9128
9129 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
9130 definition for no-X builds.
9131
4887c6e2 91322011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 9133
fd35b6f9
PE
9134 Static checks with GCC 4.6.0 and non-default toolkits.
9135
5c1ccb01
PE
9136 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
9137
006c5daa
PE
9138 * process.c (keyboard_bit_set): Define only if SIGIO.
9139 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
9140 (send_process): Repair possible setjmp clobbering.
9141
efc736d3
PE
9142 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
9143
4e2fe2e6
PE
9144 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
9145
f97334a2
PE
9146 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
9147
4e75f29d
PE
9148 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
9149 Define only if needed.
9150
90efadd1
PE
9151 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
9152 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 9153 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 9154
3c647824
PE
9155 * dispextern.h (struct redisplay_interface): Rename param
9156 to avoid shadowing.
e264f262 9157 * termhooks.h (struct terminal): Likewise.
761383f4 9158 * xterm.c (xembed_send_message): Likewise.
3c647824 9159
b58c5c4a
PE
9160 * insdel.c (make_gap_smaller): Define only if
9161 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
9162
cad59032
PE
9163 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
9164 it.
9165
c339dc2e
PE
9166 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
9167 so that we aren't warned about unused symbols.
9168
91a3e27b
PE
9169 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
9170
399c71d3 9171 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 9172
8ffc96f5
PE
9173 * xfns.c (x_real_positions): Mark locals as initialized.
9174
eef9bc79
PE
9175 * xmenu.c (xmenu_show): Don't use uninitialized vars.
9176
098db9dd
PE
9177 * xterm.c: Fix problems found by static analysis with other toolkits.
9178 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
9179 (x_dispatch_event): Declare static if USE_GTK, and
9180 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 9181 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 9182 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
9183 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
9184 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 9185
eb18f6cc
PE
9186 * xmenu.c (menu_help_callback): Pointer type fixes.
9187 Use const pointers when pointing at readonly data. Avoid pointer
9188 signedness clashes.
9189 (FALSE): Remove unused macro.
9190 (update_frame_menubar): Remove unused decl.
9191
1fe72bf8
PE
9192 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
9193
60d9e1db
PE
9194 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
9195 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
9196 (single_menu_item): Rename local to avoid shadowing.
9197
39261c26
PE
9198 * keyboard.c (make_lispy_event): Remove unused local var.
9199
018c5e19
PE
9200 * frame.c, frame.h (x_get_resource_string): Bring this back, but
9201 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
9202
63d2b86e
PE
9203 * bitmaps: Change bitmaps from unsigned char back to the X11
9204 compatible char. Avoid the old compiler warnings about
9205 out-of-range initializers by using, for example, '\xab' rather
9206 than 0xab.
9207
aefd87e1
PE
9208 * xgselect.c (xgselect_initialize): Check vs interface
9209 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
9210
bf501fb9
PE
9211 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
9212
e9829fdf
PE
9213 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
9214 to read-only memory.
9215
1086c095
PE
9216 * fns.c (vector): Remove; this old hack is no longer needed.
9217
2baccd04 9218 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 9219 Remove unused var.
dde42981 9220 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 9221
72391843 9222 * xrdb.c (x_load_resources): Omit unused local.
3565b346 9223
436c16df 9224 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 9225 (x_window): Rename locals to avoid shadowing.
dc5ddd85 9226 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 9227
92bb796d 9228 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 9229 (x_term_init): Remove local to avoid shadowing.
92bb796d 9230
764430a3 9231 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
9232
9233 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
9234 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
9235
d1dfb56c
EZ
92362011-04-16 Eli Zaretskii <eliz@gnu.org>
9237
c4354cb4
EZ
9238 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
9239
d1dfb56c
EZ
9240 Fix regex.c, syntax.c and friends for buffers > 2GB.
9241 * syntax.h (struct gl_state_s): Declare character position members
9242 EMACS_INT.
9243
9244 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
9245
04f2d78b
CB
9246 * textprop.c (verify_interval_modification, interval_of):
9247 Declare arguments EMACS_INT.
d1dfb56c
EZ
9248
9249 * intervals.c (adjust_intervals_for_insertion): Declare arguments
9250 EMACS_INT.
9251
9252 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
9253
9254 * indent.c (Fvertical_motion): Local variable it_start is now
9255 EMACS_INT.
9256
9257 * regex.c (re_match, re_match_2, re_match_2_internal)
9258 (bcmp_translate, regcomp, regexec, print_double_string)
9259 (group_in_compile_stack, re_search, re_search_2, regex_compile)
9260 (re_compile_pattern, re_exec): Declare arguments and local
9261 variables `size_t' and `ssize_t' and return values `regoff_t', as
9262 appropriate.
9263 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
9264 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
9265 <compile_stack_type>: `size' and `avail' are now `size_t'.
9266
9267 * regex.h <regoff_t>: Use ssize_t, not int.
9268 (re_search, re_search_2, re_match, re_match_2): Arguments that
9269 specify buffer/string position and length are now ssize_t and
9270 size_t. Return type is regoff_t.
9271
613052cd
BK
92722011-04-16 Ben Key <bkey76@gmail.com>
9273
9274 * nsfont.m: Fixed bugs in ns_get_family and
9275 ns_descriptor_to_entity that were caused by using free to
9276 deallocate memory blocks that were allocated by xmalloc (via
9277 xstrdup). This caused Emacs to crash when compiled with
9278 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
9279 --enable-checking=xmallocoverrun). xfree is now used to
9280 deallocate these memory blocks.
9281
4170f62f 92822011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 9283
71b41406
PE
9284 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
9285
9587a89d
PE
9286 emacs_write: Accept and return EMACS_INT for sizes.
9287 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
9288 et seq.
9289 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
9290 Accept and return EMACS_INT.
9291 (emacs_gnutls_write): Return the number of bytes written on
9292 partial writes.
9293 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
9294 (emacs_read, emacs_write): Remove check for negative size, as the
9295 Emacs source code has been audited now.
9587a89d
PE
9296 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
9297 (emacs_read, emacs_write): Use it.
273a5f82
PE
9298 * process.c (send_process): Adjust to the new signatures of
9299 emacs_write and emacs_gnutls_write. Do not attempt to store
9300 a byte offset into an 'int'; it might overflow.
9587a89d 9301 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 9302
3e047f51
PE
9303 * sound.c: Don't assume sizes fit in 'int'.
9304 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 9305 Return EMACS_INT, not int.
3e047f51 9306 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
9307 Accept EMACS_INT, not int.
9308 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
9309 record read return values.
9310
cc39a9db
BK
93112011-04-15 Ben Key <bkey76@gmail.com>
9312
c9d0ec6d
JB
9313 * keyboard.c (Qundefined): Don't declare static since it is used
9314 in nsfns.m.
9315 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
9316 static since they are used in nsfont.m.
cc39a9db 9317
6c60eb9f
SM
93182011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
9319
9320 * process.c (Qprocessp): Don't declare static.
9321 * lisp.h (Qprocessp): Declare again.
9322
7990b61a
JB
93232011-04-15 Juanma Barranquero <lekktu@gmail.com>
9324
9325 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
9326
5d4cb038
PE
93272011-04-14 Paul Eggert <eggert@cs.ucla.edu>
9328
8bd7b830 9329 Improve C-level modularity by making more things 'static'.
cd64ea1d 9330
e3b27b31
PE
9331 Don't publish debugger-only interfaces to other modules.
9332 * lisp.h (safe_debug_print, debug_output_compilation_hack):
9333 (verify_bytepos, count_markers): Move decls to the only modules
9334 that need them.
9335 * region-cache.h (pp_cache): Likewise.
9336 * window.h (check_all_windows): Likewise.
9337 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
9338
5d4cb038
PE
9339 * sysdep.c (croak): Now static, if
9340 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
9341 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
9342
9343 * alloc.c (refill_memory_reserve): Now static if
9344 !defined REL_ALLOC || defined SYSTEM_MALLOC.
9345 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 9346
e87b6180
PE
9347 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
9348 Define only if USE_LUCID.
9349
ac64929e
PE
9350 * xrdb.c (x_customization_string, x_rm_string): Now static.
9351
6f37259d
PE
9352 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
9353 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
9354
1683e3ab
PE
9355 * xdisp.c (draw_row_with_mouse_face): Now static.
9356 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
9357
de9c2632
PE
9358 * window.h (check_all_windows): Mark externally visible.
9359
2b96acb7
PE
9360 * window.c (window_deletion_count): Now static.
9361
9362 * undo.c: Make symbols static if they're not exported.
9363 (last_undo_buffer, last_boundary_position, pending_boundary):
9364 Now static.
9365
50436f33
PE
9366 * textprop.c (interval_insert_behind_hooks): Now static.
9367 (interval_insert_in_front_hooks): Likewise.
9368
64520e5c
PE
9369 * term.c: Make symbols static if they're not exported.
9370 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
9371 (max_frame_lines, tty_set_terminal_modes):
9372 (tty_reset_terminal_modes, tty_turn_off_highlight):
9373 (get_tty_terminal): Now static.
9374 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
9375 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 9376 HAVE_WINDOW_SYSTEM.
64520e5c
PE
9377 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
9378 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
9379
1fa53021
PE
9380 * sysdep.c: Make symbols static if they're not exported.
9381 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
9382 Now static.
9383 (sigprocmask_set, full_mask): Remove; unused.
9384 (wait_debugging): Mark as visible.
9385 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
9386 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
9387
d4b43b22
PE
9388 * syntax.c (syntax_temp): Define only if !__GNUC__.
9389
b7c513d0
PE
9390 * sound.c (current_sound_device, current_sound): Now static.
9391
989b29ad
PE
9392 * search.c (searchbufs, searchbuf_head): Now static.
9393
13a55a78
PE
9394 * scroll.c (scroll_cost): Remove; unused.
9395 * dispextern.h (scroll_cost): Remove decl.
9396
de68a1fc
PE
9397 * region-cache.h (pp_cache): Mark as externally visible.
9398
40ccffa6
PE
9399 * process.c: Make symbols static if they're not exported.
9400 (process_tick, update_tick, create_process, chan_process):
9401 (Vprocess_alist, proc_buffered_char, datagram_access):
9402 (fd_callback_data, send_process_frame, process_sent_to): Now static.
9403 (deactivate_process): Mark defn as static, as well as decl.
9404 * lisp.h (create_process): Remove decl.
9405 * process.h (chan_process, Vprocess_alist): Remove decls.
9406
ad64fc97
PE
9407 * print.c: Make symbols static if they're not exported.
9408 (print_depth, new_backquote_output, being_printed, print_buffer):
9409 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
9410 (print_interval, print_number_index, initial_stderr_stream):
9411 Now static.
9412 * lisp.h (Fprinc): Remove decl.
9413 (debug_output_compilation_hack): Mark as externally visible.
9414
adddb265
PE
9415 * sysdep.c (croak): Move decl from here to syssignal.h.
9416 * syssignal.h (croak): Put it here, so the API can be checked when
9417 'croak' is called from dissociate_if_controlling_tty.
9418
1717ede2
PE
9419 * minibuf.c: Make symbols static if they're not exported.
9420 (minibuf_save_list, choose_minibuf_frame): Now static.
9421 * lisp.h (choose_minibuf_frame): Remove decl.
9422
fa5fb2bc
PE
9423 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
9424
1e3890d1
PE
9425 * lread.c: Make symbols static if they're not exported.
9426 (read_objects, initial_obarray, oblookup_last_bucket_number):
9427 Now static.
9428 (make_symbol): Remove; unused.
9429 * lisp.h (initial_obarray, make_symbol): Remove decls.
9430
8a1414fa
PE
9431 * keyboard.c: Make symbols static if they're not exported.
9432 (single_kboard, recent_keys_index, total_keys, recent_keys):
9433 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
9434 (this_single_command_key_start, echoing, last_auto_save):
9435 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
9436 (command_loop, echo_now, keyboard_init_hook, help_char_p):
9437 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
9438 (Vlispy_mouse_stem, double_click_count):
9439 Now static.
9440 (force_auto_save_soon): Define only if SIGDANGER.
9441 (ignore_mouse_drag_p): Now static if
9442 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
9443 (print_help): Remove; unused.
9444 (stop_character, last_timer_event): Mark as externally visible.
9445 * keyboard.h (ignore_mouse_drag_p): Declare only if
9446 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
9447 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
9448 * lisp.h (echoing): Remove decl.
9449 (force_auto_save_soon): Declare only if SIGDANGER.
9450 * xdisp.c (redisplay_window): Simplify code, to make it more
9451 obvious that ignore_mouse_drag_p is not accessed if !defined
9452 USE_GTK && !defined HAVE_NS.
9453
93ea6e8f
PE
9454 * intervals.c: Make symbols static if they're not exported.
9455 (merge_properties_sticky, merge_interval_right, delete_interval):
9456 Now static.
9457 * intervals.h (merge_interval_right, delete_interval): Remove decls.
9458
77382fcc
PE
9459 * insdel.c: Make symbols static if they're not exported.
9460 However, leave prepare_to_modify_buffer alone. It's never
9461 called from outside this function, but that appears to be a bug.
9462 (combine_after_change_list, combine_after_change_buffer):
4889fc82 9463 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
9464 (adjust_after_replace_noundo): Remove; unused.
9465 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 9466 (signal_before_change): Remove decls.
77382fcc 9467
9306c32e
PE
9468 * indent.c (val_compute_motion, val_vmotion): Now static.
9469
cd44d2eb
PE
9470 * image.c: Make symbols static if they're not exported.
9471 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
9472 if USE_GTK.
9473 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
9474 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
9475
ad9a7a06
PE
9476 * fringe.c (standard_bitmaps): Now static.
9477 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
9478
81626931
PE
9479 * frame.c: Make symbols static if they're not exported.
9480 (x_report_frame_params, make_terminal_frame): Now static.
9481 (get_frame_param): Now static, unless HAVE_NS.
9482 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
9483 (x_get_resource_string): Remove; not used.
9484 * frame.h (make_terminal_frame, x_report_frame_params):
9485 (x_get_resource_string); Remove decls.
9486 (x_fullscreen_adjust): Declare only if WINDOWSNT.
9487 * lisp.h (get_frame_param): Declare only if HAVE_NS.
9488
239f9db9
PE
9489 * font.c, fontset.c: Make symbols static if they're not exported.
9490 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
9491 (FACE_SUITABLE_FOR_CHAR_P): Use it.
9492 * font.c (font_close_object): Now static.
9493 * font.h (font_close_object): Remove.
9494 * fontset.c (FONTSET_OBJLIST): Remove.
9495 (free_realized_fontset) #if-0 the body, which does nothing.
9496 (face_suitable_for_char_p): #if-0, as it's never called.
9497 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
9498 * xfaces.c (face_at_string_position):
9499 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
9500 since 0 is always ASCII.
9501
dfcf3579
PE
9502 * fns.c (weak_hash_tables): Now static.
9503
5045092b
PE
9504 * fileio.c: Make symbols static if they're not exported.
9505 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
9506 (Vwrite_region_annotation_buffers): Now static.
9507
57a96f5c
PE
9508 * eval.c: Make symbols static if they're not exported.
9509 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
9510 * lisp.h (backtrace_list): Remove decl.
9511
35f08c38
PE
9512 * emacs.c: Make symbols static if they're not exported.
9513 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
9514 (fatal_error_code, fatal_error_signal_hook, standard_args):
9515 Now static.
9516 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
9517 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
9518 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
9519 * lisp.h (fatal_error_signal_hook): Remove decl.
9520 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
9521
f44bd759
PE
9522 * editfns.c: Move a (normally-unused) function to its only use.
9523 * editfns.c, lisp.h (get_operating_system_release): Remove.
9524 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
9525 worth the hassle of breaking this out.
9526
b532497d
PE
9527 * xterm.c: Make symbols static if they're not exported.
9528 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
9529 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
9530 (x_destroy_window, x_delete_display):
9531 Now static.
9532 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
9533 (x_mouse_leave): Remove; unused.
9534 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
9535 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
9536 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
9537 Remove decls.
9538 (x_mouse_leave): Declare only if WINDOWSNT.
9539 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
9540 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
9541 USE_X_TOOLKIT.
9542
1675728f
PE
9543 * ftxfont.c: Make symbols static if they're not exported.
9544 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
9545 HAVE_FREETYPE.
9546 * font.h (ftxfont_driver): Likewise.
9547
e4cebfca
PE
9548 * xfns.c: Make symbols static if they're not exported.
9549 (x_last_font_name, x_display_info_for_name):
9550 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
9551 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
9552 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
9553 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
9554 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
9555 (last_show_tip_args): Now static.
9556 (xic_defaut_fontset, xic_create_fontsetname): Define only if
9557 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
9558 (x_screen_planes): Remove; unused.
9559 * dispextern.h (x_screen_planes): Remove decl.
9560
5bf46f05
PE
9561 * dispnew.c: Make symbols static if they're not exported.
9562 * dispextern.h (redraw_garbaged_frames, scrolling):
9563 (increment_row_positions): Remove.
9564 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
9565 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
9566 Now static.
9567 (redraw_garbaged_frames): Remove; unused.
9568
435f4c28
PE
9569 * xfaces.c: Make symbols static if they're not exported.
9570 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
9571 Remove decls.
9572 * xterm.h (defined_color): Remove decls.
9573 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
9574 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
9575 (menu_face_changed_default, defined_color, free_realized_face):
9576 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
9577 (ascii_face_of_lisp_face): Remove; unused.
9578
8524aef3
PE
9579 * xdisp.c: Make symbols static if they're not exported.
9580 * dispextern.h (scratch_glyph_row, window_box_edges):
9581 (glyph_to_pixel_coords, set_cursor_from_row):
9582 (get_next_display_element, set_iterator_to_next):
9583 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
9584 (show_mouse_face): Remove decls
9585 * frame.h (message_buf_print): Likewise.
9586 * lisp.h (pop_message, set_message, check_point_in_composition):
9587 Likewise.
9588 * xterm.h (set_vertical_scroll_bar): Likewise.
9589 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
9590 (message_buf_print, scratch_glyph_row, displayed_buffer):
9591 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
9592 (get_next_display_element, show_mouse_face, window_box_edges):
9593 (frame_to_window_pixel_xy, check_point_in_composition):
9594 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
9595 (glyph_to_pixel_coords): Remove; unused.
9596
16390cd2
PE
9597 * dired.c (file_name_completion): Now static.
9598
9599 * dbusbind.c (xd_in_read_queued_messages): Now static.
9600
a25f4dfa
PE
9601 * lisp.h (circular_list_error, FOREACH): Remove; unused.
9602 * data.c (circular_list_error): Remove.
9603
14a9c8df
PE
9604 * commands.h (last_point_position, last_point_position_buffer):
9605 (last_point_position_window): Remove decls.
9606 * keyboard.c: Make these variables static.
9607
04f2d78b
CB
9608 * coding.h (coding, code_convert_region, encode_coding_gap):
9609 Remove decls.
74ab6df5
PE
9610 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
9611 (iso_code_class, detect_coding, code_convert_region): Now static.
9612 (encode_coding_gap): Remove; unused.
9613
38dfbee1
PE
9614 * chartab.c (chartab_chars, chartab_bits): Now static.
9615
a2cb4e63
PE
9616 * charset.h (charset_iso_8859_1): Remove decl.
9617 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
9618 Now static.
9619
127198fd
PE
9620 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
9621 * ccl.c (Vccl_program_table): Now static.
9622 (check_ccl_update): Remove; unused.
9623
d85b608f
PE
9624 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
9625 * category.h: ... from here.
9626 * category.c (check_category_table, set_category_set): Now static.
9627
31cd66f3
PE
9628 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
9629 * lisp.h: Remove these decls.
9630
c358e587
PE
9631 * buffer.c (buffer_count): Remove unused var.
9632
e78aecca
PE
9633 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
9634 so that it's not optimized away.
9635 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
9636 * dispextern.h (bidi_dump_cached_states): Remove, since it's
9637 exported only to the debugger.
9638
e192d7d3 9639 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 9640 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 9641
92470028
PE
9642 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
9643 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
9644 was inaccessible from Lisp.
9645 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
9646 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
9647
244ed907
PE
9648 alloc.c: Import and export fewer symbols, and remove unused items.
9649 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
9650 is defined.
9651 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
9652 it's not optimized away by whole-program optimization.
9653 (message_enable_multibyte, free_misc): Remove.
9654 (catchlist, handlerlist, mark_backtrace):
9655 Declare only if BYTE_MARK_STACK.
9656 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
9657 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
9658 (message_enable_multibyte): Remove decl.
9659 (free_misc, interval_free_list, float_block, float_block_index):
9660 (n_float_blocks, float_free_list, cons_block, cons_block_index):
9661 (cons_free_list, last_marked_index):
9662 Now static.
9663 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
9664 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
9665 (mark_backtrace): Define only if BYTE_MARK_STACK.
9666 * xdisp.c (message_enable_multibyte): Now static.
9667
61c2b50e 9668 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
9669 This makes it easier for human readers (and static analyzers)
9670 to see whether these variables are used from other modules.
9671 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
9672 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
9673 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
9674 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
9675 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
9676 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
9677 * xmenu.c, xselect.c:
9678 Declare Q* vars static if they are not used in other modules.
9679 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
9680 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
9681 Remove decls of unexported vars.
9682 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
9683
95c82688
PE
9684 * lisp.h (DEFINE_FUNC): Make sname 'static'.
9685
16a97296
PE
9686 Make Emacs functions such as Fatom 'static' by default.
9687 This makes it easier for human readers (and static analyzers)
9688 to see whether these functions can be called from other modules.
9689 DEFUN now defines a static function. To make the function external
9690 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
9691 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
9692 (Finit_image_library):
16a97296
PE
9693 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
9694 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
9695 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
9696 Remove decls, since these functions are now static.
9697 (Funintern, Fget_internal_run_time): New decls, since these functions
9698 were already external.
95c82688 9699
16a97296
PE
9700 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
9701 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
9702 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
9703 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
9704 * keyboard.c, keymap.c, lread.c:
9705 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
9706 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
9707 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
9708 Mark functions with DEFUE instead of DEFUN,
9709 if they are used in other modules.
9710 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
9711 decls for now-static functions.
9712 * buffer.h (Fdelete_overlay): Remove decl.
9713 * callproc.c (Fgetenv_internal): Mark as internal.
9714 * composite.c (Fremove_list_of_text_properties): Remove decl.
9715 (Fcomposition_get_gstring): New forward static decl.
9716 * composite.h (Fcomposite_get_gstring): Remove decl.
9717 * dired.c (Ffile_attributes): New forward static decl.
9718 * doc.c (Fdocumntation_property): New forward static decl.
9719 * eval.c (Ffetch_bytecode): New forward static decl.
9720 (Funintern): Remove extern decl; now in .h file where it belongs.
9721 * fileio.c (Fmake_symbolic_link): New forward static decl.
9722 * image.c (Finit_image_library): New forward static decl.
9723 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
9724 * intervals.h (Fprevious_property_change):
9725 (Fremove_list_of_text_properties): Remove decls.
9726 * keyboard.c (Fthis_command_keys): Remove decl.
9727 (Fcommand_execute): New forward static decl.
9728 * keymap.c (Flookup_key): New forward static decl.
9729 (Fcopy_keymap): Now static.
9730 * keymap.h (Flookup_key): Remove decl.
9731 * process.c (Fget_process): New forward static decl.
9732 (Fprocess_datagram_address): Mark as internal.
9733 * syntax.c (Fsyntax_table_p): New forward static decl.
9734 (skip_chars): Remove duplicate decl.
9735 * textprop.c (Fprevious_property_change): New forward static decl.
9736 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
9737 Now internal.
9738 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
9739 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
9740
785bbd42
PE
9741 * editfns.c (Fformat): Remove unreachable code.
9742
8b913b57
AS
97432011-04-14 Andreas Schwab <schwab@linux-m68k.org>
9744
9745 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
9746 change. (Bug#8496)
9747
a6744a35
EZ
97482011-04-13 Eli Zaretskii <eliz@gnu.org>
9749
9750 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
9751 when at ZV. (Bug#8487)
9752
e7974947
AS
97532011-04-12 Andreas Schwab <schwab@linux-m68k.org>
9754
baad03f0
AS
9755 * charset.c (Fclear_charset_maps): Use xfree instead of free.
9756 (Bug#8437)
9757 * keyboard.c (parse_tool_bar_item): Likewise.
9758 * sound.c (sound_cleanup, alsa_close): Likewise.
9759 * termcap.c (tgetent): Likewise.
9760 * xfns.c (x_default_font_parameter): Likewise.
9761 * xsettings.c (read_and_apply_settings): Likewise.
9762
e7974947
AS
9763 * alloc.c (overrun_check_malloc, overrun_check_realloc)
9764 (overrun_check_free): Protoize.
9765
28272684
PE
97662011-04-12 Paul Eggert <eggert@cs.ucla.edu>
9767
9768 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
9769 since callers should never pass a negative size.
9770 Change the signature to match that of plain 'read' and 'write'; see
9771 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
9772 * lisp.h: Update prototypes of emacs_write and emacs_read.
9773
11997c76
EZ
97742011-04-11 Eli Zaretskii <eliz@gnu.org>
9775
9776 * xdisp.c (redisplay_window): Don't try to determine the character
9777 position of the scroll margin if the window start point w->startp
e896f03c 9778 is outside the buffer's accessible region. (Bug#8468)
11997c76 9779
8a2cbd72
EZ
97802011-04-10 Eli Zaretskii <eliz@gnu.org>
9781
9782 Fix write-region and its subroutines for buffers > 2GB.
9783 * fileio.c (a_write, e_write): Modify declaration of arguments and
9784 local variables to support buffers larger than 2GB.
9785 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
9786
9787 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
9788 argument, local variables, and return value.
9789
9790 * lisp.h: Update prototypes of emacs_write and emacs_read.
9791
9792 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
9793
4073e537 97942011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 9795
1ebfdcb6
PE
9796 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
9797
b2ded58d
PE
9798 Fix more problems found by GCC 4.6.0's static checks.
9799
7d66342c
PE
9800 * xdisp.c (vmessage): Use a better test for character truncation.
9801
bbf47d44
PE
9802 * charset.c (load_charset_map): <, not <=, for optimization,
9803 and to avoid potential problems with integer overflow.
9248994d 9804 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 9805 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 9806 * editfns.c (Fformat): Likewise.
1e69125e 9807 * syntax.c (skip_chars): Likewise.
3befa583 9808
e3019616
PE
9809 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
9810 This also lets GCC 4.6.0 generate slightly better loop code.
9811
becfa255
PE
9812 * callint.c (Fcall_interactively): <, not <=, for optimization.
9813 (Fcall_interactively): Count the number of arguments produced,
9814 not the number of arguments given. This is simpler and lets GCC
9815 4.6.0 generate slightly better code.
9816
dae0cd48
PE
9817 * ftfont.c: Distingish more carefully between FcChar8 and char.
9818 The previous code passed unsigned char * to a functions like
9819 strlen and xstrcasecmp that expect char *, which does not
9820 conform to the C standard.
9821 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
9822 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
9823 char * when the C standard requires it.
9824
76032d70
PE
9825 * keyboard.c (read_char): Remove unused var.
9826
eb3f1cc8
PE
9827 * eval.c: Port to Windows vsnprintf (Bug#8435).
9828 Include <limits.h>.
9829 (SIZE_MAX): Define if the headers do not.
9830 (verror): Do not give up if vsnprintf returns a negative count.
9831 Instead, grow the buffer. This ports to Windows vsnprintf, which
9832 does not conform to C99. Problem reported by Eli Zaretskii.
9833 Also, simplify the allocation scheme, by avoiding the need for
9834 calling realloc, and removing the ALLOCATED variable.
9835
70476b54
PE
9836 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
9837
12020a9e
PE
9838 Remove invocations of doprnt, as Emacs now uses vsnprintf.
9839 But keep the doprint source code for now, as we might revamp it
9840 and use it again (Bug#8435).
ea6c7ae6
PE
9841 * lisp.h (doprnt): Remove.
9842 * Makefile.in (base_obj): Remove doprnt.o.
9843 * deps.mk (doprnt.o): Remove.
9844
5fdb398c
PE
9845 error: Print 32- and 64-bit integers portably (Bug#8435).
9846 Without this change, on typical 64-bit hosts error ("...%d...", N)
9847 was used to print both 32- and 64-bit integers N, which relied on
9848 undefined behavior.
61bdb816 9849 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
9850 * lisp.h (error, verror): Mark as printf-like functions.
9851 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
9852 Report overflow in size calculations when allocating printf buffer.
9853 Do not truncate output string at its first null byte.
9854 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
9855 Truncate the output at a character boundary, since vsnprintf does not
9856 do that.
9857 * charset.c (check_iso_charset_parameter): Convert internal
9858 character to string before calling 'error', since %c now has the
9859 printf meaning.
9860 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
9861 overflow when computing char to be passed to 'error'. Do not
9862 pass Lisp_Object to 'error'; pass the integer instead.
9863 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
9864 formatted with plain %d.
9865
b189fa66
PE
9866 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
9867
bff87ef0
PE
9868 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
9869
7e2cac20
PE
9870 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
9871
ce4d90b5
PE
9872 * xterm.c (x_catch_errors): Remove duplicate declaration.
9873
266c9547
PE
9874 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
9875
79c49ad2
PE
9876 * xdisp.c, lisp.h (message_nolog): Remove; unused.
9877
368f4090
JM
98782011-04-10 Jim Meyering <meyering@redhat.com>
9879
9880 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
9881 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
9882 return ssize_t not "int", and use size_t as the buffer length.
9883 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
9884 * gnutls.h: Update declarations.
9885 * process.c (read_process_output): Use ssize_t, to match.
9886 (send_process): Likewise.
9887
a32d4040
CY
98882011-04-09 Chong Yidong <cyd@stupidchicken.com>
9889
9890 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
9891
8546720e 98922011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 9893
04f2d78b
CB
9894 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
9895 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 9896
8546720e
GM
9897 * xterm.c (handle_one_xevent):
9898 * xmenu.c (create_and_show_popup_menu):
9899 * xselect.c (x_decline_selection_request)
9900 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 9901
0a2f5c1a 99022011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
9903
9904 Fix some uses of `int' instead of EMACS_INT.
9905 * search.c (string_match_1, fast_string_match)
9906 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
9907 (scan_buffer, find_next_newline_no_quit)
9908 (find_before_next_newline, search_command, Freplace_match)
9909 (Fmatch_data): Make some `int' variables be EMACS_INT.
9910
9911 * xdisp.c (display_count_lines): 3rd argument and return value now
9912 EMACS_INT. All callers changed.
9913 (pint2hrstr): Last argument is now EMACS_INT.
9914
9915 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
9916 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
9917 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
9918 (decode_coding_utf_16, decode_coding_emacs_mule)
9919 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
9920 (decode_coding_ccl, decode_coding_charset)
9921 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
9922 (decode_coding_iso_2022, decode_coding_emacs_mule)
9923 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
9924 <char_offset, last_offset>: Declare EMACS_INT.
9925 (encode_coding_utf_8, encode_coding_utf_16)
9926 (encode_coding_emacs_mule, encode_invocation_designation)
9927 (encode_designation_at_bol, encode_coding_iso_2022)
9928 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
9929 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
9930 Declare EMACS_INT.
9931 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
9932 (encode_invocation_designation): Last argument P_NCHARS is now
9933 EMACS_INT.
9934 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
9935 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
9936
9937 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
9938 All users changed.
9939
9940 * ccl.c (Fccl_execute_on_string): Declare some variables
9941 EMACS_INT.
9942
8546720e 99432011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
9944
9945 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
9946
4e19a977
CS
99472011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
9948
9949 * process.c (Fformat_network_address): Doc fix.
9950
87302331
R
99512011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
9952
ee7683eb 9953 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 9954
cbb59342
CY
99552011-04-08 Chong Yidong <cyd@stupidchicken.com>
9956
9957 * keyboard.c (read_char): Call Lisp function help-form-show,
9958 instead of using internal_with_output_to_temp_buffer.
9959 (Qhelp_form_show): New var.
e0d38eeb 9960 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
9961
9962 * print.c (internal_with_output_to_temp_buffer): Function deleted.
9963
9964 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
9965
e67a13ab
CY
99662011-04-06 Chong Yidong <cyd@stupidchicken.com>
9967
04f2d78b
CB
9968 * process.c (Flist_processes): Remove to Lisp.
9969 (list_processes_1): Delete.
e67a13ab 9970
973f782d
EZ
99712011-04-06 Eli Zaretskii <eliz@gnu.org>
9972
7c106b1e
EZ
9973 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
9974
973f782d
EZ
9975 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
9976
41cf7d1a 99772011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 9978
ca23cc88
PE
9979 Fix more problems found by GCC 4.6.0's static checks.
9980
f390e2d5
PE
9981 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
9982
42eea0d0
PE
9983 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
9984
b69769da 9985 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 9986
f9541e84
PE
9987 * xdisp.c (vmessage): Mark as a printf-like function.
9988
13841b55
PE
9989 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
9990
c136c10f
PE
9991 * sound.c (sound_warning): Don't crash if arg contains a printf format.
9992
5e2d4a30
PE
9993 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
9994 printf-like functions.
9995 (tiff_load): Add casts to remove these marks before passing them
9996 to system-supplied API.
9997
583f48b9
PE
9998 * eval.c (Fsignal): Remove excess argument to 'fatal'.
9999
b25d760e
PE
10000 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
10001 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
10002 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
10003 directly, rather than having caller test rule sign. This avoids
10004 some unnecessary tests.
10005 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
10006 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
10007 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 10008
bc7b6697 10009 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 10010 (xfont_open): Avoid unnecessary tests.
bc7b6697 10011
27ccc379
PE
10012 * composite.c (composition_gstring_put_cache): Use unsigned integer.
10013
dcd5c89a
PE
10014 * composite.h, composite.c (composition_gstring_put_cache):
10015 Use EMACS_INT, not int, for length.
10016
b13a45c6
PE
10017 * composite.h (COMPOSITION_DECODE_REFS): New macro,
10018 breaking out part of COMPOSITION_DECODE_RULE.
10019 (COMPOSITION_DECODE_RULE): Use it.
10020 * composite.c (get_composition_id): Remove unused local vars,
10021 by using the new macro.
10022
1e792e4d
PE
10023 * textprop.c (set_text_properties_1): Change while to do-while,
10024 since the condition is always true at first.
10025
dc6c6455 10026 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
10027 (interval_deletion_adjustment): Return unsigned value.
10028 All uses changed.
dc6c6455 10029
aba7731a
PE
10030 * process.c (list_processes_1, create_pty, read_process_output):
10031 (exec_sentinel): Remove vars that were set but not used.
afd4052b 10032 (create_pty): Remove unnecessary "volatile"s.
bc57d757 10033 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 10034 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 10035 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 10036
fdfc4bf3
PE
10037 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
10038
fca8fe46 10039 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 10040 (update_syntax_table): Use unsigned instead of int.
fca8fe46 10041
06a0259a 10042 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 10043 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 10044 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 10045
e7b9e80f
PE
10046 * print.c (print_error_message): Avoid int overflow.
10047
56201685
PE
10048 * font.c (font_list_entities): Redo for clarity,
10049 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
10050
78834453 10051 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 10052 (font_score): Avoid potential overflow in diff calculation.
78834453 10053
0bc0b309 10054 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 10055 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 10056
e610eaca
PE
10057 * eval.c (funcall_lambda): Rename local to avoid shadowing.
10058
b895abce
PE
10059 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
10060 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
10061 can always succeed if overflow has undefined behavior.
10062
1f1d9321 10063 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 10064 (wordify): Omit three unnecessary tests.
1f1d9321 10065
c59478bc
PE
10066 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
10067 All callers changed. This avoids the need for an unused var.
10068
79b73827
PE
10069 * casefiddle.c (casify_region): Remove var that is set but not used.
10070
a4db5dfe
PE
10071 * dired.c (file_name_completion): Remove var that is set but not used.
10072
43aae36e
PE
10073 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
10074
2a47c44d 10075 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 10076 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 10077
a37c69bf
PE
10078 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
10079 Check for integer overflow on size calculations.
10080
328ab8e7
PE
10081 * buffer.c (Fprevious_overlay_change): Remove var that is set
10082 but not used.
10083
e5a2a5cb
PE
10084 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
10085 Remove vars that are set but not used.
8d84a6eb 10086 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 10087 (timer_check_2): Mark vars as initialized.
e5a2a5cb 10088
a60e5f68
PE
10089 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
10090
f661cb61 10091 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 10092 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 10093
f0397f5a
PE
10094 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
10095 that are set but not used.
10096
8664db06 10097 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 10098 if XCreateBitmapFromData fails (Bug#8410).
8664db06 10099
6abdaa4a
PE
10100 * xselect.c (x_get_local_selection, x_handle_property_notify):
10101 Remove vars that are set but not used.
10102
0ce7538d 10103 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 10104 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 10105
9ae848fc
PE
10106 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
10107 Remove var that is set but not used.
0b918413
PE
10108 (scroll_bar_windows_size): Now size_t, not int.
10109 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
10110 Check for overflow.
9ae848fc 10111
a5a62657
PE
10112 * xfaces.c (realize_named_face): Remove vars that are set but not used.
10113 (map_tty_color) [!defined MSDOS]: Likewise.
10114
5c5cdd39
PE
10115 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
10116
66ebf983
PE
10117 * coding.c: Remove vars that are set but not used.
10118 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
10119 All callers changed.
10120 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
10121 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
10122 (decode_coding_charset): Remove vars that are set but not used.
10123
1be4d761
PE
10124 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
10125 that is set but not used.
10126
47553fa8
PE
10127 * print.c (print_object): Remove var that is set but not used.
10128
1f7196bf 10129 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
10130 The gnulib version avoids calling malloc in the usual case,
10131 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
10132 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
10133 * filelock.c (current_lock_owner): Likewise.
10134 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
10135 * sysdep.c: Include allocator.h, careadlinkat.h.
10136 (emacs_no_realloc_allocator): New static constant.
10137 (emacs_readlink): New function.
fdb61804
PE
10138 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
10139 ../lib/careadlinkat.h.
d1fdcab7 10140
f84c17c7
SM
101412011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
10142
10143 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
10144 first non-nil return value).
10145
ef3862ad
JD
101462011-04-03 Jan Djärv <jan.h.d@swipnet.se>
10147
10148 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
10149 if not defined (Bug#8403).
10150
376a7006
JB
101512011-04-02 Juanma Barranquero <lekktu@gmail.com>
10152
10153 * xdisp.c (display_count_lines): Remove parameter `start',
10154 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10155 (get_char_face_and_encoding): Remove parameter `multibyte_p',
10156 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10157 (fill_stretch_glyph_string): Remove parameters `row' and `area',
10158 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
10159 and thereabouts. All callers changed.
10160 (get_per_char_metric): Remove parameter `f', unused since
10161 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10162
6ca3801d
JM
101632011-04-02 Jim Meyering <meyering@redhat.com>
10164
10165 do not dereference NULL upon failed strdup
10166 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
10167 (ns_get_family): Likewise.
10168
d8e2b5ba
JB
101692011-04-02 Juanma Barranquero <lekktu@gmail.com>
10170
10171 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
10172
8c74fcbd
JD
101732011-04-02 Jan Djärv <jan.h.d@swipnet.se>
10174
10175 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
10176 later (Bug#8403).
10177
7200d79c
SM
101782011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
10179
03408648 10180 Add lexical binding.
7200d79c 10181
03408648
SM
10182 * window.c (Ftemp_output_buffer_show): New fun.
10183 (Fsave_window_excursion):
10184 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
10185
10186 * lread.c (lisp_file_lexically_bound_p): New function.
10187 (Fload): Bind Qlexical_binding.
10188 (readevalloop): Remove `evalfun' arg.
10189 Bind Qinternal_interpreter_environment.
10190 (Feval_buffer): Bind Qlexical_binding.
10191 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
10192 Mark as dynamic.
10193 (syms_of_lread): Declare `lexical-binding'.
10194
10195 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
10196
10197 * keyboard.c (eval_dyn): New fun.
10198 (menu_item_eval_property): Use it.
ca105506
SM
10199
10200 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 10201
03408648
SM
10202 * fns.c (concat, mapcar1): Accept byte-code-functions.
10203
10204 * eval.c (Fsetq): Handle lexical vars.
10205 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
10206 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
10207 (FletX, Flet): Obey lexical binding.
10208 (Fcommandp): Handle closures.
10209 (Feval): New `lexical' arg.
10210 (eval_sub): New function extracted from Feval. Use it almost
10211 everywhere where Feval was used. Look up vars in lexical env.
10212 Handle closures.
10213 (Ffunctionp): Move from subr.el.
10214 (Ffuncall): Handle closures.
10215 (apply_lambda): Remove `eval_flags'.
10216 (funcall_lambda): Handle closures and new byte-code-functions.
10217 (Fspecial_variable_p): New function.
10218 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
10219 but without exporting it to Lisp.
23aba0ea 10220
23aba0ea 10221 * doc.c (Fdocumentation, store_function_docstring):
03408648 10222 * data.c (Finteractive_form): Handle closures.
23aba0ea 10223
03408648
SM
10224 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
10225 interactive spec.
ba83908c 10226
04f2d78b
CB
10227 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
10228 New byte-codes.
03408648
SM
10229 (exec_byte_code): New function extracted from Fbyte_code to handle new
10230 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 10231
03408648 10232 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 10233
03408648 10234 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 10235
e2abce01
JB
102362011-03-31 Juanma Barranquero <lekktu@gmail.com>
10237
10238 * xdisp.c (redisplay_internal): Fix prototype.
10239
63696a73 102402011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 10241
63696a73 10242 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
10243 (try_scrolling): Use it when setting scroll_limit.
10244 Limit scrolling to 100 screen lines.
63696a73
EZ
10245 (redisplay_window): Even when falling back on "recentering",
10246 position point in the window according to scroll-conservatively,
10247 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
10248
10249 (try_scrolling): When point is above the window, allow searching
10250 as far as scroll_max, or one screenful, to compute vertical
10251 distance from PT to the scroll margin position. This prevents
10252 try_scrolling from unnecessarily failing when
10253 scroll-conservatively is set to a value slightly larger than the
10254 window height. Clean up the case of PT below the margin at bottom
10255 of window: scroll_max can no longer be INT_MAX. When aggressive
10256 scrolling is in use, don't let point enter the opposite scroll
10257 margin as result of the scroll.
10258 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
10259 threshold of 100 lines for never-recentering scrolling.
10260
e4cc2dfc
JB
102612011-03-31 Juanma Barranquero <lekktu@gmail.com>
10262
10263 * dispextern.h (move_it_by_lines):
10264 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
10265 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
10266 (message_log_check_duplicate): Remove parameters `prev_bol' and
10267 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10268 (redisplay_internal): Remove parameter `preserve_echo_area',
10269 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
10270
10271 * indent.c (Fvertical_motion):
10272 * window.c (window_scroll_pixel_based, Frecenter):
10273 Don't pass `need_y_p' to `move_it_by_lines'.
10274
1c470562
SM
102752011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
10276
44f230aa
SM
10277 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
10278 steal a few bits to be more compact.
10279 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
10280 Remove unneeded casts.
10281
1c470562
SM
10282 * bytecode.c (Fbyte_code): CAR and CDR can GC.
10283
888adce9
ZK
102842011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
10285
10286 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
10287 binding" message (bug#7967).
10288
f838ed7b
PE
102892011-03-30 Paul Eggert <eggert@cs.ucla.edu>
10290
77861b95
PE
10291 Fix more problems found by GCC 4.6.0's static checks.
10292
de6dbc14
PE
10293 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
10294 Remove unused local var.
10295
f838ed7b
PE
10296 * editfns.c (Fmessage_box): Remove unused local var.
10297
792c7b2b
PE
10298 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
10299 (note_mode_line_or_margin_highlight, note_mouse_highlight):
10300 Omit unused local vars.
c499e557 10301 * window.c (shrink_windows): Omit unused local var.
b01a1c29 10302 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
10303 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
10304 Omit unused local var.
10305
ba0165e1
PE
10306 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
10307 Don't assume string length fits in int.
32ad8845 10308 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 10309 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 10310
3c59b4c9
PE
10311 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
10312 instead of alloca (Bug#8344).
10313
a3eed478 10314 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 10315 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 10316
eb4d412d
PE
10317 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
10318
1658b401
PE
10319 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
10320 concerns.
10321
10322 * term.c (produce_glyphless_glyph): Remove unnecessary test.
10323
10324 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 10325
9a2c6e05
PE
10326 * keyboard.c (syms_of_keyboard): Use the same style as later
10327 in this function when indexing through an array. This also
10328 works around GCC bug 48267.
10329
03d0a109
PE
10330 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
10331
44f730c8
PE
10332 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
10333
fe75f926
PE
10334 * chartab.c (sub_char_table_ref_and_range): Redo for slight
10335 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
10336
ffa8c828
PE
10337 * keyboard.c, keyboard.h (num_input_events): Now size_t.
10338 This avoids undefined behavior on integer overflow, and is a bit
10339 more convenient anyway since it is compared to a size_t variable.
10340
c5101a77
PE
10341 Variadic C functions now count arguments with size_t, not int.
10342 This avoids an unnecessary limitation on 64-bit machines, which
10343 caused (substring ...) to crash on large vectors (Bug#8344).
10344 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
10345 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 10346 All variadic functions and their callers changed accordingly.
c5101a77
PE
10347 (struct gcpro.nvars): Now size_t, not int. All uses changed.
10348 * data.c (arith_driver, float_arith_driver): Likewise.
10349 * editfns.c (general_insert_function): Likewise.
10350 * eval.c (struct backtrace.nargs, interactive_p)
10351 (internal_condition_case_n, run_hook_with_args, apply_lambda)
10352 (funcall_lambda, mark_backtrace): Likewise.
10353 * fns.c (concat): Likewise.
10354 * frame.c (x_set_frame_parameters): Likewise.
10355 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
10356 0 if not found, not -1. All callers changed.
10357
dd3f25f7
PE
10358 * alloc.c (garbage_collect): Don't assume stack size fits in int.
10359 (stack_copy_size): Now size_t, not int.
10360 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
10361
461c2ab9
JB
103622011-03-28 Juanma Barranquero <lekktu@gmail.com>
10363
10364 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
10365 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10366 All callers changed.
10367
10368 * lisp.h (multibyte_char_to_unibyte):
10369 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
10370 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10371 * character.h (CHAR_TO_BYTE8):
10372 * cmds.c (internal_self_insert):
10373 * editfns.c (general_insert_function):
10374 * keymap.c (push_key_description):
10375 * search.c (Freplace_match):
10376 * xdisp.c (message_dolog, set_message_1): All callers changed.
10377
f6d62986
SM
103782011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
10379
10380 * keyboard.c (safe_run_hook_funcall): New function.
10381 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
10382 don't set the hook to nil, but remove the offending function instead.
10383 (Qcommand_hook_internal): Remove, unused.
10384 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
10385 Vcommand_hook_internal.
10386
10387 * eval.c (enum run_hooks_condition): Remove.
10388 (funcall_nil, funcall_not): New functions.
10389 (run_hook_with_args): Call each function through a `funcall' argument.
10390 Remove `cond' argument, now redundant.
10391 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
10392 (Frun_hook_with_args_until_failure): Adjust accordingly.
10393 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
10394
1db5b1ad
JB
103952011-03-28 Juanma Barranquero <lekktu@gmail.com>
10396
10397 * dispextern.h (string_buffer_position): Remove declaration.
10398
10399 * print.c (strout): Remove parameter `multibyte', unused since
10400 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
10401
10402 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
10403 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
10404 All callers changed.
10405
10406 * w32.c (_wsa_errlist): Use braces for struct initializers.
10407
10408 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
10409 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
10410 All callers changed.
10411 (string_buffer_position): Likewise. Also, make static (it's never
10412 used outside xdisp.c).
10413 (cursor_row_p): Remove parameter `w', unused since
10414 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
10415 (decode_mode_spec): Remove parameter `precision', introduced during
10416 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
10417 All callers changed.
10418
5ffb62aa
JD
104192011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10420
10421 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
10422
461c2ab9 104232011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
10424
10425 * nsterm.m (ns_menu_bar_is_hidden): New variable.
10426 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
10427 (ns_update_auto_hide_menu_bar): New functions.
10428 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
10429 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
10430 ns_constrain_all_frames.
10431 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
10432 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
10433
5c380ffb
JD
104342011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10435
10436 * nsmenu.m (runDialogAt): Remove argument to timer_check.
10437
9af30bdf
GM
104382011-03-27 Glenn Morris <rgm@gnu.org>
10439
10440 * syssignal.h: Replace RETSIGTYPE with void.
10441 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
10442 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
10443 Replace SIGTYPE with void everywhere.
10444 * s/usg5-4-common.h (SIGTYPE): Remove definition.
10445 * s/template.h (SIGTYPE): Remove commented out definition.
10446
e2abce01
JB
104472011-03-26 Eli Zaretskii <eliz@gnu.org>
10448
10449 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
10450 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
10451
f868cd8a
JB
104522011-03-26 Juanma Barranquero <lekktu@gmail.com>
10453
59eb0929
JB
10454 * w32.c (read_unc_volume): Use parameter `henum', instead of
10455 global variable `wget_enum_handle'.
10456
10457 * keymap.c (describe_vector): Remove parameters `indices' and
10458 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
10459 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
10460
f868cd8a
JB
10461 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
10462
10463 * keyboard.c (timer_check): Remove parameter `do_it_now',
10464 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
10465 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
10466 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
10467
10468 * keyboard.c (read_char):
10469 * w32menu.c (w32_menu_display_help):
10470 * xmenu.c (show_help_event, menu_help_callback):
10471 Adjust calls to `show_help_echo'.
10472
10473 * gtkutil.c (xg_maybe_add_timer):
10474 * keyboard.c (readable_events):
10475 * process.c (wait_reading_process_output):
10476 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
10477
10478 * insdel.c (adjust_markers_gap_motion):
10479 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
10480 (gap_left, gap_right): Don't call it.
10481
2ecf6fdb
CY
104822011-03-25 Chong Yidong <cyd@stupidchicken.com>
10483
10484 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
10485 incurred during fontification.
10486
6b1f9ba4
JB
104872011-03-25 Juanma Barranquero <lekktu@gmail.com>
10488
10489 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
10490 (DEFVAR_PER_BUFFER): Don't pass it.
10491
10492 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
10493 (scrolling_window): Don't pass it.
10494
0f4a96b5
JB
104952011-03-25 Juanma Barranquero <lekktu@gmail.com>
10496
10497 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
10498
10499 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
10500 and `suffix'.
10501 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
10502 of variables specific to SELinux and computation of `encoded_absname'.
10503
10504 * image.c (XPutPixel): Remove unused variable `height'.
10505
10506 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
10507
10508 * unexw32.c (get_section_info): Remove unused variable `section'.
10509
10510 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
10511 (system_process_attributes): Remove unused variable `sess'.
10512 (sys_read): Remove unused variable `err'.
10513
10514 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
10515 (w32_wnd_proc): Remove unused variable `isdead'.
10516 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
10517 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
10518 (x_create_tip_frame): Remove unused variable `tem'.
10519
10520 * w32inevt.c (w32_console_read_socket):
10521 Remove unused variable `no_events'.
10522
10523 * w32term.c (x_draw_composite_glyph_string_foreground):
10524 Remove unused variable `width'.
10525
1149507c
JB
105262011-03-24 Juanma Barranquero <lekktu@gmail.com>
10527
10528 * w32term.c (x_set_glyph_string_clipping):
10529 Don't pass uninitialized region to CombineRgn.
10530
9c88f339
JB
105312011-03-23 Juanma Barranquero <lekktu@gmail.com>
10532
10533 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
10534 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
10535 (Fx_close_connection): Remove unused variable `i'.
10536
10537 * w32font.c (w32font_draw): Return number of glyphs.
10538 (w32font_open_internal): Remove unused variable `i'.
10539 (w32font_driver): Add missing initializer.
10540
10541 * w32menu.c (utf8to16): Remove unused variable `utf16'.
10542 (fill_in_menu): Remove unused variable `items_added'.
10543
10544 * w32term.c (last_mouse_press_frame): Remove static global variable.
10545 (w32_clip_to_row): Remove unused variable `f'.
10546 (x_delete_terminal): Remove unused variable `i'.
10547
10548 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
10549 (NOTHING): Remove unused static global variable.
10550 (uniscribe_check_otf): Remove unused variable `table'.
10551 (uniscribe_font_driver): Add missing initializers.
10552
dee091a3
JD
105532011-03-23 Julien Danjou <julien@danjou.info>
10554
10555 * term.c (Fsuspend_tty, Fresume_tty):
10556 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
10557 * window.c (temp_output_buffer_show):
10558 * insdel.c (signal_before_change):
10559 * frame.c (Fhandle_switch_frame):
10560 * fileio.c (Fdo_auto_save):
10561 * emacs.c (Fkill_emacs):
10562 * editfns.c (save_excursion_restore):
10563 * cmds.c (internal_self_insert):
10564 * callint.c (Fcall_interactively):
10565 * buffer.c (Fkill_all_local_variables):
10566 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
10567 Use Frun_hooks.
0f4a96b5 10568 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 10569 unconditionally since it does the check itself.
dee091a3 10570
2c520ab5 105712011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 10572
c9c49752
PE
10573 Fix more problems found by GCC 4.5.2's static checks.
10574
8abc3f12
PE
10575 * coding.c (encode_coding_raw_text): Avoid unnecessary test
10576 the first time through the loop, since we know p0 < p1 then.
10577 This also avoids a gcc -Wstrict-overflow warning.
10578
a2d26660
PE
10579 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
10580 leading to a memory leak, possible in functions like
10581 load_charset_map_from_file that can allocate an unbounded number
b12ef411 10582 of objects (Bug#8318).
a2d26660 10583
916c72e9
PE
10584 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
10585 that could (at least in theory) be that large.
10586
19ab8a18
PE
10587 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
10588 This is less likely to overflow, and avoids undefined behavior if
10589 overflow does occur. All callers changed. Use strtoul to scan
10590 for the unsigned long integer.
b7cbbd6f
PE
10591 (pint2hrstr): Simplify and tune code slightly.
10592 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 10593
f0641eff
PE
10594 * scroll.c (do_scrolling): Work around GCC bug 48228.
10595 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
10596
7f650bb9
PE
10597 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
10598 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
10599 (validate_x_resource_name): Simplify count usage.
10600 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 10601
37dd57d1
PE
10602 * fileio.c (Fcopy_file): Report error if fchown or fchmod
10603 fail (Bug#8306).
81e56e61 10604
699979fc 10605 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 10606
401bf9b4
PE
10607 * process.c (Fmake_network_process): Use socklen_t, not int,
10608 where POSIX says socklen_t is required in portable programs.
10609 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 10610 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
10611 (Fmake_network_process, server_accept_connection):
10612 (wait_reading_process_output, read_process_output):
10613 Likewise.
10614
b93aacde
PE
10615 * process.c: Rename or move locals to avoid shadowing.
10616 (list_processes_1, Fmake_network_process):
10617 (read_process_output_error_handler, exec_sentinel_error_handler):
10618 Rename or move locals.
4dc343ee 10619 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 10620 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 10621 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 10622 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 10623 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 10624
af8a867c 10625 Make tparam.h and terminfo.c consistent.
44f230aa
SM
10626 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
10627 Include tparam.h instead, since it declares them.
af8a867c
PE
10628 * cm.h (PC): Remove extern decl; tparam.h now does this.
10629 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
10630 * terminfo.c: Include tparam.h, to check interfaces.
10631 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
10632 (tparam): Adjust signature to match interface in tparam.h;
10633 this removes some undefined behavior. Check that outstring and len
10634 are zero, which they always are with Emacs.
10635 * tparam.h (PC, BC, UP): New extern decls.
10636
0248044d 10637 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 10638 (xftfont_open): Rename locals to avoid shadowing.
0248044d 10639
8ff096c1 10640 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
10641 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
10642 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 10643 (ftfont_list): Remove unused local.
49eaafba
PE
10644 (get_adstyle_property, ftfont_pattern_entity):
10645 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
10646 Rename locals to avoid shadowing.
8ff096c1 10647
e2be39f6
PE
10648 * xfont.c (xfont_list_family): Mark var as initialized.
10649
c9735e30
PE
10650 * xml.c (make_dom): Now static.
10651
8f5201ae
PE
10652 * composite.c (composition_compute_stop_pos): Rename local to
10653 avoid shadowing.
b246f932
PE
10654 (composition_reseat_it): Remove unused locals.
10655 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 10656 (composition_update_it): Mark var as initialized.
11b61122
PE
10657 (find_automatic_composition): Mark vars as initialized,
10658 with a FIXME (Bug#8290).
8f5201ae 10659
760fbc2c
PE
10660 character.h: Rename locals to avoid shadowing.
10661 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
10662 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
10663 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
10664 (BUF_DEC_POS): Be more systematic about renaming local temporaries
10665 to avoid shadowing.
10666
ff08eb85
PE
10667 * textprop.c (property_change_between_p): Remove; unused.
10668
fc7bf025
PE
10669 * intervals.c (interval_start_pos): Now static.
10670
235d7abc
PE
10671 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
10672
44f230aa
SM
10673 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
10674 Rename locals to avoid shadowing.
3e7d6594 10675
50060332
PE
10676 * sound.c (wav_play, au_play, Fplay_sound_internal):
10677 Fix pointer signedness.
d01f234b 10678 (alsa_choose_format): Remove unused local var.
c83b8872
PE
10679 (wav_play): Initialize a variable to 0, to prevent undefined
10680 behavior (Bug#8278).
50060332 10681
c4fc4e30
PE
10682 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
10683
918436ed
PE
10684 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
10685
c939f91b
PE
10686 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
10687 clobbering (Bug#8298).
b9c7f648
PE
10688 * sysdep.c (sys_subshell): Likewise.
10689 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 10690
6bd8c144
PE
10691 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
10692 This should get cleaned up, so that child_setup has the
10693 same signature on all platforms.
10694
7710357c 10695 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 10696 (relocate_fd): Rename locals to avoid shadowing.
7710357c 10697
c59da222
CY
106982011-03-22 Chong Yidong <cyd@stupidchicken.com>
10699
10700 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
10701 not to be necessary, and produces flickering.
10702
66b87493
GM
107032011-03-20 Glenn Morris <rgm@gnu.org>
10704
10705 * config.in: Remove file.
10706
45b6f6d5
JB
107072011-03-20 Juanma Barranquero <lekktu@gmail.com>
10708
10709 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
10710 are now in src/globals.h.
10711 (syms_of_minibuf): Remove spurious & from previous change.
10712
cd394be1 107132011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
10714
10715 * minibuf.c (completing-read-function): New variable.
10716 (completing-read-default): Rename from completing-read.
10717 (completing-read): Call completing-read-function.
10718
b14e3e21
CY
107192011-03-19 Juanma Barranquero <lekktu@gmail.com>
10720
10721 * xfaces.c (Fx_load_color_file):
10722 Read color file from absolute filename (bug#8250).
10723
f2b726e6
JB
107242011-03-19 Juanma Barranquero <lekktu@gmail.com>
10725
10726 * makefile.w32-in: Update dependencies.
10727
09f6ff02
EZ
107282011-03-17 Eli Zaretskii <eliz@gnu.org>
10729
10730 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
10731
29a6015a
PE
107322011-03-17 Paul Eggert <eggert@cs.ucla.edu>
10733
a3a6c54e
PE
10734 Fix more problems found by GCC 4.5.2's static checks.
10735
b766f867
PE
10736 * process.c (make_serial_process_unwind, send_process_trap):
10737 (sigchld_handler): Now static.
10738
be02381c
PE
10739 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
10740 That way, the code declares only the vars that it needs.
10741 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
10742 * s/cygwin.h (PTY_ITERATION): Likewise.
10743 * s/darwin.h (PTY_ITERATION): Likewise.
10744 * s/gnu-linux.h (PTY_ITERATION): Likewise.
10745
57048744
PE
10746 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
10747 * process.c (allocate_pty): Don't declare stb unless it's needed.
10748
7914961c 10749 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
10750 (CONSTANTLIM): Remove; unused.
10751 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
10752 Define only if needed.
7914961c 10753
b3967b18
PE
10754 * unexelf.c (unexec): Name an expression,
10755 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
10756 Use a different way to cause a compilation error if anyone uses
10757 n rather than nn, a way that does not involve shadowing.
73366a00 10758 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 10759
29a6015a
PE
10760 * deps.mk (unexalpha.o): Remove; unused.
10761
43cfc33e 10762 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 10763 * unexec.h: New file.
ce701a33
PE
10764 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
10765 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
10766 Depend on unexec.h.
10767 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
10768 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
10769 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 10770 Change as necessary to match prototype in unexec.h.
ce701a33 10771
01f44d5a
PE
10772 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
10773 shadowing.
4f63c6bb 10774 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 10775
a6670b0b
PE
10776 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
10777 Rename locals to avoid shadowing.
10778
cef2010d 10779 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 10780 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 10781
d4d7173a
PE
10782 * print.c (Fredirect_debugging_output): Fix pointer signedess.
10783
f08b802a
PE
10784 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
10785 warning when compiling print.c.
10786
3ddb0639
PE
10787 * font.c (font_unparse_fcname): Abort in an "impossible" situation
10788 instead of using an uninitialized var.
5ad03b97 10789 (font_sort_entities): Mark var as initialized.
3ddb0639 10790
170a2692
PE
10791 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
10792
e663c700
PE
10793 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
10794 pointers to constants.
89bc529a 10795 (font_parse_fcname): Remove unused vars.
7b81e2d0 10796 (font_delete_unmatched): Now static.
ea838e10 10797 (font_get_spec): Remove; unused.
13a547c6
PE
10798 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
10799 (font_update_drivers, Ffont_get_glyphs, font_add_log):
10800 Rename or move locals to avoid shadowing.
e663c700 10801
2a80c887 10802 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 10803 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 10804
1384fa33 10805 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 10806 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 10807
8b2c52e9
PE
10808 * alloc.c (mark_backtrace): Move decl from here ...
10809 * lisp.h: ... to here, so that it can be checked.
10810
475545b5 10811 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 10812 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
10813 (lisp_indirect_variable): Name an expression,
10814 to avoid gcc -Wbad-function-cast warning.
1faed8ae 10815 (Fdefvar): Rename locals to avoid shadowing.
475545b5 10816
b1349114 10817 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 10818 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 10819 Use const pointer when appropriate.
b1349114 10820
a2928364
PE
10821 * lisp.h (get_system_name, get_operating_system_release):
10822 Move decls here, to check interfaces.
10823 * process.c (get_operating_system_release): Move decl to lisp.h.
10824 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
10825 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
10826 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
10827 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
10828 (Fformat_time_string, Fencode_time, Finsert_char):
10829 (Ftranslate_region_internal, Fformat):
10830 Rename or remove local vars to avoid shadowing.
9710023e 10831 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 10832
a415e694
PE
10833 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
10834 avoid shadowing.
10835
8ef4622d
PE
10836 * lisp.h (eassert): Check that the argument compiles, even if
10837 ENABLE_CHECKING is not defined.
10838
946f9a5b
PE
10839 * data.c (Findirect_variable): Name an expression, to avoid
10840 gcc -Wbad-function-cast warning.
112396d6 10841 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 10842 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
10843 (Fmake_variable_buffer_local, Fmake_local_variable):
10844 Mark variables as initialized.
52746918 10845 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 10846
e5aab7e7 10847 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
10848 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
10849 Rename locals to avoid shadowing.
dff45157
PE
10850 (mark_stack): Move local variables into the #ifdef region where
10851 they're used.
7bc26fdb
PE
10852 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
10853 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
10854 needed otherwise.
10855 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
10856 (GC_STRING_CHARS): Remove; not used.
d40d4be1 10857 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 10858
e5aab7e7
PE
10859 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
10860 avoids undefined behavior in theory.
10861
4da60324
PE
10862 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
10863
88043301
PE
10864 Use functions, not macros, for up- and down-casing (Bug#8254).
10865 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
10866 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
10867 to use the following functions instead of these macros.
10868 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
10869 EMACS_INT, since callers assume the returned value fits in int.
10870 (upcase1): Likewise, for UPCASE_TABLE.
10871 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 10872 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 10873 the race-condition problem in the old DOWNCASE.
88043301 10874
19ed5445
PE
10875 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
10876 Rename locals to avoid shadowing.
10877 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
10878 (regex_compile, re_search_2, re_match_2_internal):
10879 Remove unused local vars.
952db0d7
PE
10880 (FREE_VAR): Rewrite so as not to use empty "else",
10881 which gcc can warn about.
da053e48 10882 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
10883 (RETALLOC_IF): Define only if needed.
10884 (WORDCHAR_P): Likewise. This one is never needed, but is used
10885 only in a comment talking about a compiler bug, so put inside
10886 the #if 0 of that comment.
10887 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
10888 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
10889 Remove; unused.
19ed5445 10890
1f3561e4 10891 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
10892 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
10893 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 10894
ded6f8f7
PE
10895 * search.c (simple_search): Remove unused var.
10896
dbd37a95
PE
10897 * dired.c (compile_pattern): Move decl from here ...
10898 * lisp.h: ... to here, so that it can be checked.
10899 (struct re_registers): New forward decl.
10900
7e47afad
PE
10901 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
10902
85f24f61
PE
10903 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
10904 All uses changed.
10905 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
10906 Rename locals to avoid shadowing.
5671df8f 10907 (Fvertical_motion): Mark locals as initialized.
85f24f61 10908
181aa2be 10909 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 10910 (casify_region): Mark local as initialized.
181aa2be 10911
930d429c
PE
10912 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
10913
7082eac6
PE
10914 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
10915 New macros, so that the caller can use some names other than
10916 gcpro1, gcpro2, etc.
10917 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
10918 of the new macros.
10919 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
10920 argument, for consistency with GCPRO2_VAR, etc: it is now the
10921 prefix of the variable, not the variable itself. All uses
10922 changed.
38b2c076
PE
10923 * dired.c (directory_files_internal, file_name_completion):
10924 Rename locals to avoid shadowing.
10925
15206ed9
PE
10926 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
10927 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
10928 dired.c's scmp function, had undefined behavior.
10929 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
10930 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
10931 * buffer.h: ... to here, because these macros use current_buffer,
10932 and the new implementation with inline functions needs to have
10933 current_buffer in scope now, rather than later when the macros
10934 are used.
10935 (downcase, upcase1): New static inline functions.
10936 (DOWNCASE, UPCASE1): Reimplement using these functions.
10937 This avoids undefined behavior in expressions like
10938 DOWNCASE (x) == DOWNCASE (y), which previously suffered
10939 from race conditions in accessing the global variables
10940 case_temp1 and case_temp2.
10941 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
10942 * lisp.h (case_temp1, case_temp2): Remove their decls.
10943 * character.h (ASCII_CHAR_P): Move from here ...
10944 * lisp.h: ... to here, so that the inline functions mentioned
10945 above can use them.
10946
4a6bea26
PE
10947 * dired.c (directory_files_internal_unwind): Now static.
10948
f14b7e14
PE
10949 * fileio.c (file_name_as_directory, directory_file_name):
10950 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
10951 Now static.
2893f146
PE
10952 (file_name_as_directory): Use const pointers when appropriate.
10953 (Fexpand_file_name): Likewise. In particular, newdir might
10954 point at constant storage, so make it a const pointer.
fd4ead52 10955 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
10956 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
10957 signedness issues.
f839df0c
PE
10958 (Fset_file_times, Finsert_file_contents, auto_save_error):
10959 Rename locals to avoid shadowing.
f14b7e14 10960
5716756e 10961 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
10962 (Ftry_completion, Fall_completions): Rename or remove locals
10963 to avoid shadowing.
5716756e 10964
b4c3046a
PE
10965 * marker.c (bytepos_to_charpos): Remove; unused.
10966
b45db522
PE
10967 * lisp.h (verify_bytepos, count_markers): New decls,
10968 so that gcc does not warn that these functions aren't declared.
10969
85876d07
PE
10970 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
10971 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 10972 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 10973 (copy_text): Remove unused local var.
85876d07 10974
03d78a21 10975 * filelock.c (within_one_second): Now static.
b3dd38ab 10976 (lock_file_1): Rename local to avoid shadowing.
03d78a21 10977
5df8f01b
PE
10978 * buffer.c (fix_overlays_before): Mark locals as initialized.
10979 (fix_start_end_in_overlays): Likewise. This function should be
10980 simplified by using pointers-to-pointers, but that's a different
10981 matter.
b1d876f1 10982 (switch_to_buffer_1): Now static.
8f54f30a
PE
10983 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
10984 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 10985
a70072c9 10986 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 10987 Fix pointer signedness issue.
edced198
PE
10988 (sys_subshell): Mark local as volatile if checking for lint,
10989 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 10990 (MAXPATHLEN): Define only if needed.
a70072c9 10991
a0977c44
PE
10992 * process.c (serial_open, serial_configure): Move decls from here ...
10993 * systty.h: ... to here, so that they can be checked.
10994
a884fdcc
PE
10995 * fns.c (get_random, seed_random): Move extern decls from here ...
10996 * lisp.h: ... to here, so that they can be checked.
10997
604efe86 10998 * sysdep.c (reset_io): Now static.
b8950c94 10999 (wait_for_termination_signal): Remove; unused.
604efe86 11000
38fc62d9
PE
11001 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
11002 (copy_keymap_item, append_key, push_text_char_description):
11003 Now static.
1004a21a 11004 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 11005 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
11006 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
11007 (describe_map_tree):
11008 Rename locals to avoid shadowing.
38fc62d9 11009
2f2650da
PE
11010 * keyboard.c: Declare functions static if they are not used elsewhere.
11011 (echo_char, echo_dash, cmd_error, top_level_2):
11012 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
11013 (read_char, kbd_buffer_get_event, make_lispy_position):
11014 (make_lispy_event, make_lispy_movement, apply_modifiers):
11015 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
11016 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
11017 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 11018 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 11019 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 11020
a053e86c 11021 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
11022 (mark_kboards): Move decl here ...
11023 * alloc.c (mark_kboards): ... from here.
a053e86c 11024
4752793e
PE
11025 * lisp.h (force_auto_save_soon): New decl.
11026
74f10ca7 11027 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
11028 (DEFINE_DUMMY_FUNCTION): New macro.
11029 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
11030 Use it.
c03cd23f
PE
11031 (main): Add casts to avoid warnings
11032 if GCC considers string literals to be constants.
74f10ca7 11033
022e70d4
PE
11034 * lisp.h (fatal_error_signal): Add decl, since it's exported.
11035
59d6fe83
PE
11036 * dbusbind.c: Pointer signedness fixes.
11037 (xd_signature, xd_append_arg, xd_initialize):
11038 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11039 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11040 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
11041 (Fdbus_register_signal): Use SSDATA when the context wants char *.
11042
78320123
PE
11043 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
11044 if GCC considers string literals to be constants.
49cebcca 11045 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 11046
35ac2a97
SM
110472011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
11048
fb103ca9
SM
11049 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
11050 (print_preprocess, print_object): New macro to fix last change.
11051
35ac2a97
SM
11052 * print.c (print_preprocess): Don't forget font objects.
11053
62973b41
JB
110542011-03-16 Juanma Barranquero <lekktu@gmail.com>
11055
11056 * emacs.c (USAGE3): Doc fixes.
11057
0e48bb22
AS
110582011-03-15 Andreas Schwab <schwab@linux-m68k.org>
11059
11060 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
11061 structure.
11062
7684e57b
JB
110632011-03-14 Juanma Barranquero <lekktu@gmail.com>
11064
11065 * lisp.h (VWindow_system, Qfile_name_history):
11066 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
11067 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
11068 (w32_system_caret_x, w32_system_caret_y): Declare extern.
11069
11070 * w32select.c: Don't #include "keyboard.h".
c96bbc66 11071 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
11072
11073 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
11074 * w32console.c (detect_input_pending, read_input_pending)
11075 (encode_terminal_code):
11076 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
11077 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
11078 (w32_system_caret_y, Qfile_name_history):
11079 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
11080 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
11081 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
11082 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
11083 * w32proc.c (Qlocal, report_file_error):
11084 * w32term.c (Vwindow_system, updating_frame):
11085 * w32uniscribe.c (initialized, uniscribe_font_driver):
11086 Remove unneeded extern declarations.
11087
2aa46d6c
CY
110882011-03-14 Chong Yidong <cyd@stupidchicken.com>
11089
c96bbc66 11090 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 11091
cffc6f3b
CY
110922011-03-13 Chong Yidong <cyd@stupidchicken.com>
11093
11094 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
11095 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
11096 These macros can no longer be used for assignment.
11097
44f230aa
SM
11098 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
11099 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
11100 (record_buffer_markers, fetch_buffer_markers): New functions for
11101 recording and fetching special buffer markers.
11102 (set_buffer_internal_1, set_buffer_temp): Use them.
11103
11104 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
11105
11106 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
11107
11108 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
11109 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
11110
11111 * xdisp.c (hscroll_window_tree):
11112 (reconsider_clip_changes): Use PT instead of BUF_PT.
11113
d251f04b
EZ
111142011-03-13 Eli Zaretskii <eliz@gnu.org>
11115
11116 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
11117 $(EMACS_ROOT)/lib/intprops.h.
11118
f0c77cd1
PE
111192011-03-13 Paul Eggert <eggert@cs.ucla.edu>
11120
3eca4629
PE
11121 Fix more problems found by GCC 4.5.2's static checks.
11122
7c86ee98
PE
11123 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
11124 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
11125 (xg_free_frame_widgets): Make it clear that a local variable is
11126 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
11127 (gdk_window_get_screen): Make it clear that this macro is needed
11128 only if USE_GTK_TOOLTIP.
1e5524e7
PE
11129 (int_gtk_range_get_value): New function, which avoids a diagnostic
11130 from gcc -Wbad-function-cast.
11131 (xg_set_toolkit_scroll_bar_thumb): Use it.
11132 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
11133 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
11134 (get_utf8_string, xg_get_file_with_chooser):
11135 Rename locals to avoid shadowing.
11136 (create_dialog): Move locals to avoid shadowing.
7c86ee98 11137
41729b81
PE
11138 * xgselect.c (xg_select): Remove unused var.
11139
f0c77cd1
PE
11140 * image.c (four_corners_best): Mark locals as initialized.
11141 (gif_load): Initialize transparent_p to zero (Bug#8238).
11142 Mark another local as initialized.
ec6cf4c6 11143 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 11144
ce0ad53d 11145 * image.c (clear_image_cache): Now static.
d5d5a617 11146 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 11147 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
11148 (x_edge_detection): Remove unnecessary cast that
11149 gcc -Wbad-function-cast diagnoses.
2037898d 11150 (gif_load): Fix pointer signedness.
6ae141d6
PE
11151 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
11152 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 11153
33383987 111542011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 11155
d32df629
PE
11156 Improve quality of tests for time stamp overflow.
11157 For example, without this patch (encode-time 0 0 0 1 1
11158 1152921504606846976) returns the obviously-bogus value (-948597
11159 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
11160 reports time overflow. See
11161 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
11162 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
11163 * editfns.c: Include limits.h and intprops.h.
11164 (TIME_T_MIN, TIME_T_MAX): New macros.
11165 (time_overflow): Move earlier, to before first use.
11166 (hi_time, lo_time): New functions, for an accurate test for
11167 out-of-range times.
11168 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
11169 (Fget_internal_run_time): Don't assume time_t fits in int.
11170 (make_time): Use list2 instead of Fcons twice.
11171 (Fdecode_time): More accurate test for out-of-range times.
11172 (check_tm_member): New function.
11173 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
11174 (lisp_time_argument): Don't rely on undefined left-shift and
11175 right-shift behavior when checking for time stamp overflow.
8be6f318 11176
fe31d94c
PE
11177 * editfns.c (time_overflow): New function, refactoring common code.
11178 (Fformat_time_string, Fdecode_time, Fencode_time):
11179 (Fcurrent_time_string): Use it.
11180
8be6f318
PE
11181 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
11182 * dired.c (make_time): Move to ...
11183 * editfns.c (make_time): ... here.
11184 * systime.h: Note the move.
11185
09d9db2c 111862011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 11187
126bc0dc
YM
11188 * fringe.c (update_window_fringes): Remove unused variables.
11189
c47cbdfd
YM
11190 * unexmacosx.c (copy_data_segment): Also copy __got section.
11191 (Bug#8223)
11192
7ac80be9
EZ
111932011-03-12 Eli Zaretskii <eliz@gnu.org>
11194
c96bbc66 11195 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
11196 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
11197 Constify `char *' arguments and their references according to
11198 prototypes in tparam.h.
11199
ecb0f94d 11200 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 11201
7ac80be9
EZ
11202 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
11203 Adapt all references accordingly.
11204
11205 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
11206
ef1fd07e
TT
112072011-03-11 Tom Tromey <tromey@redhat.com>
11208
11209 * buffer.c (syms_of_buffer): Remove obsolete comment.
11210
7ef4b50c
EZ
112112011-03-11 Eli Zaretskii <eliz@gnu.org>
11212
11213 * termhooks.h (encode_terminal_code): Declare prototype.
11214
11215 * msdos.c (encode_terminal_code): Don't declare prototype.
11216
11217 * term.c (encode_terminal_code): Now external again, used by
11218 w32console.c and msdos.c.
11219
44f230aa
SM
11220 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
11221 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 11222
4b1ec863 112232011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 11224
1714f52b 11225 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 11226
4b1ec863
PE
11227 * fringe.c (update_window_fringes): Mark locals as initialized
11228 (Bug#8227).
11229 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 11230
524c7aa6
PE
11231 * alloc.c (mark_fringe_data): Move decl from here ...
11232 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
11233 to check its interface.
11234 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
11235
a5c0af81 11236 * fontset.c (free_realized_fontset): Now static.
7519b8cd 11237 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 11238 (fontset_font): Mark local as initialized.
a9a06e0b 11239 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 11240
b4716021
PE
11241 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
11242
811e9bac 11243 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 11244 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
11245 (x_own_selection, Fx_disown_selection_internal): Rename locals
11246 to avoid shadowing.
11247 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 11248
7e3ab302
PE
11249 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
11250 so that the caller can use some name other than gcpro1.
11251 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
11252 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11253 (Fx_backspace_delete_keys_p):
11254 Use them to avoid shadowing, and rename vars to avoid shadowing.
11255 (x_decode_color, x_set_name, x_window): Now static.
6b437900 11256 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 11257 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
11258 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
11259 Remove unused locals.
7e3ab302
PE
11260 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11261 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
11262 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
11263 macros.
f78faa98 11264
e2b13473
PE
11265 * xterm.h (x_mouse_leave): New decl.
11266
77f23912
PE
11267 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
11268 Remove unused functions.
cdf4ba58
PE
11269 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
11270 (x_calc_absolute_position): Now static.
7411c686 11271 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 11272 Don't declare local "event" unless it's used.
ed7bf3a5
PE
11273 (x_iconify_frame, x_free_frame_resources): Don't declare locals
11274 unless they are used.
38d0b34a
PE
11275 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
11276 (x_fatal_error_signal): Remove; not used.
a6067996
PE
11277 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
11278 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
11279 (x_error_catcher, x_connection_closed, x_error_handler):
11280 (x_error_quitter, xembed_send_message, x_iconify_frame):
11281 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 11282 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 11283 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 11284
44f230aa
SM
11285 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
11286 Rename or move locals to avoid shadowing.
6b463e58 11287 (tty_defined_color, merge_face_heights): Now static.
5967d051 11288 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
11289 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
11290 does not deduce is never used uninitialized.
73719eba
PE
11291 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
11292 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 11293
426994c3 11294 * terminal.c (store_terminal_param): Now static.
5489860b 11295
032f1620 11296 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 11297 (set_frame_menubar): Remove unused local.
d4323972 11298 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
11299 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
11300 since they might point to immutable storage.
281585b0
PE
11301 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
11302 since it's unused otherwise.
032f1620 11303
367c19e5 11304 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 11305 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
11306 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
11307 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 11308 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
11309 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
11310 does not deduce are never used uninitialized.
70739cbe 11311
07b48fa9
PE
11312 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
11313
8868a238 11314 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
11315 * window.c (window_loop, size_window):
11316 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 11317
7e5cf297 11318 * window.c (display_buffer): Now static.
d6550a9f
PE
11319 (size_window): Mark variables that gcc -Wuninitialized
11320 does not deduce are never used uninitialized.
a586633d
PE
11321 * window.h (check_all_windows): New decl, to forestall
11322 gcc -Wmissing-prototypes diagnostic.
5b555da1 11323 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 11324
f6095868
PE
11325 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
11326 shadowing.
11327 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
11328 Include <limits.h>.
11329 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
11330 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
11331 (load_charset_map): Mark variables that gcc -Wuninitialized
11332 does not deduce are never used uninitialized.
53df7c11 11333 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 11334
f38b440c
PE
11335 * coding.c (coding_set_source, coding_set_destination):
11336 Use "else { /* comment */ }" rather than "else /* comment */;"
11337 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
11338 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
11339 a block, when the outer 'i' will do.
11340 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
11341 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
11342 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
11343 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
11344 (Fdecode_sjis_char, Fdefine_coding_system_internal):
11345 Rename locals to avoid shadowing.
11346 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
11347 * coding.c (emacs_mule_char, encode_invocation_designation):
11348 Now static, since they're not used elsewhere.
413bb2db 11349 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 11350 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
11351 (decode_coding_emacs_mule): Mark variables that gcc
11352 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
11353 (detect_coding_iso_2022): Initialize a local variable that might
11354 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 11355 this initialization is needed. (Bug#8211)
5f58e762
PE
11356 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
11357 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
11358 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
11359 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
11360 Remove unused macros.
f38b440c 11361
232b38b9 11362 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 11363 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 11364 * character.c (string_count_byte8): Likewise.
232b38b9 11365
fb90da1b
PE
11366 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
11367 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
11368
fb93dbc2
PE
11369 * chartab.c (copy_sub_char_table): Now static, since it's not used
11370 elsewhere.
5c156ace
PE
11371 (sub_char_table_ref_and_range, char_table_ref_and_range):
11372 Rename locals to avoid shadowing.
bbcd0949 11373 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 11374
7d3b3862 11375 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 11376 (BIDI_BOB): Remove unused macro.
7d3b3862 11377
6be7d3da
PE
11378 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
11379 deduce are never used uninitialized.
c2ed9c8b 11380 * term.c (encode_terminal_code): Likewise.
6be7d3da 11381
75f8807f 11382 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 11383
50938595
PE
11384 * tparam.h: New file.
11385 * term.c, tparam.h: Include it.
11386 * deps.mk (term.o, tparam.o): Depend on tparam.h.
11387 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
11388 Move these decls to tparam.h, and make them agree with what
11389 is actually in tparam.c. The previous trick of using incompatible
11390 decls in different modules does not conform to the C standard.
11391 All callers of tparam changed to use tparam's actual API.
11392 * tparam.c (tparam1, tparam, tgoto):
11393 Use const pointers where appropriate.
11394
fbceeba2
PE
11395 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
11396 * cm.h (struct cm): Likewise.
11397 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
11398 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
11399 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
11400 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
11401 (turn_on_face, init_tty): Likewise.
11402 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 11403
7f3f1250
PE
11404 * term.c (term_mouse_position): Rename local to avoid shadowing.
11405
e6ca6543
PE
11406 * alloc.c (mark_ttys): Move decl from here ...
11407 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
11408
c40f8d15
AS
114092011-03-11 Andreas Schwab <schwab@linux-m68k.org>
11410
11411 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
11412
cfe0661d
JB
114132011-03-09 Juanma Barranquero <lekktu@gmail.com>
11414
11415 * search.c (compile_pattern_1): Remove argument regp, unused since
11416 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
11417 (compile_pattern): Don't pass it.
11418
0afb4571
J
114192011-03-08 Jan Djärv <jan.h.d@swipnet.se>
11420
11421 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
11422 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
11423 for ! HAVE_GTK3.
11424 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
11425
11426 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
11427
11428 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
11429 gdk_window_get_screen, gdk_window_get_geometry,
11430 gdk_x11_window_lookup_for_display and GDK_KEY_g.
11431 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
11432 (xg_get_pixbuf_from_pixmap): New function.
11433 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
11434 to Pixmap, take frame as parameter, remove GdkColormap parameter.
11435 Call xg_get_pixbuf_from_pixmap instead of
11436 gdk_pixbuf_get_from_drawable.
11437 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
11438 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
11439 (xg_check_special_colors): Use GtkStyleContext and its functions
11440 for HAVE_GTK3.
11441 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
11442 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
11443 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
11444 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
11445 Call gtk_widget_get_preferred_size.
0afb4571
J
11446 (xg_frame_resized): gdk_window_get_geometry only takes 5
11447 parameters.
44f230aa
SM
11448 (xg_win_to_widget, xg_event_is_for_menubar):
11449 Call gdk_x11_window_lookup_for_display.
0afb4571
J
11450 (xg_set_widget_bg): New function.
11451 (delete_cb): New function.
895009e1 11452 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 11453 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
11454 (xg_set_background_color): Call xg_set_widget_bg.
11455 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
11456 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
11457 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
11458 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
11459 if ! HAVE_GTK3.
11460 (update_frame_tool_bar): Call gtk_widget_hide.
11461 (xg_initialize): Use GDK_KEY_g.
11462
11463 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
11464 if ! HAVE_GTK3
11465 (x_session_initialize): Call gdk_x11_set_sm_client_id.
11466
11467 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
11468 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
11469 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
11470
1c2cc4ef
JB
114712011-03-08 Juanma Barranquero <lekktu@gmail.com>
11472
11473 * w32xfns.c (select_palette): Check success of RealizePalette against
11474 GDI_ERROR, not zero.
11475
33383987 11476See ChangeLog.11 for earlier changes.
aac0c6e3
MR
11477
11478;; Local Variables:
11479;; coding: utf-8
aac0c6e3
MR
11480;; End:
11481
2f097256 11482 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
11483
11484 This file is part of GNU Emacs.
11485
11486 GNU Emacs is free software: you can redistribute it and/or modify
11487 it under the terms of the GNU General Public License as published by
11488 the Free Software Foundation, either version 3 of the License, or
11489 (at your option) any later version.
11490
11491 GNU Emacs is distributed in the hope that it will be useful,
11492 but WITHOUT ANY WARRANTY; without even the implied warranty of
11493 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11494 GNU General Public License for more details.
11495
11496 You should have received a copy of the GNU General Public License
11497 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.